gdb/ChangeLog

   1 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
   4         delete default constructor.
   5         (find_partial_die): Update to return const struct.
   6         (partial_die_parent_scope): Move variable declaration into scope
   7         of its use and change its type to auto.
   8         (guess_partial_die_structure_name): Likewise.
   9         (partial_die_info::fixup): Likewise.
  10
  11 2019-05-17  Tom Tromey  <tromey@adacore.com>
  12
  13         * source.c (find_and_open_source): Remove cast.
  14
  15 2019-05-17  Tom Tromey  <tromey@adacore.com>
  16
  17         * annotate.c (annotate_source): Make "filename" const.
  18         * annotate.h (annotate_source): Use const.
  19
  20 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  21
  22         * disasm.c (set_disassembler_options): Send errors to stderr.
  23
  24 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  25
  26         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  27         (cli_interp_base::set_logging): Check debug_redirect.
  28         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  29         * cli/cli-logging.c (debug_redirect): Add static variable.
  30         (pop_output_files): Add default param.
  31         (handle_redirections): Print debug setting.
  32         (show_logging_command): Likewise.
  33         (_initialize_cli_logging): Add debugredirect command.
  34         * interps.c (current_interp_set_logging): Add debug_redirect
  35         parameter.
  36         * interps.h (set_logging): Add debug_redirect parameter.
  37         (current_interp_set_logging): Likewise.
  38         * mi/mi-common.h: Likewise.
  39         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  40
  41 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  42             Tom Tromey  <tromey@adacore.com>
  43
  44         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  45         directly.
  46         * cli/cli-interp.h (make_logging_output): Remove declaration.
  47         * cli/cli-logging.c (make_logging_output): Remove function.
  48         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  49         directly.
  50         * ui-file.c (tee_file::tee_file): Remove bools.
  51         (tee_file::~tee_file): Remove deletes.
  52         * ui-file.h (tee_file): Remove bools.
  53
  54 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  55
  56         * mi/mi-cmds.h (mi_cmd_complete): New function.
  57         * mi/mi-main.c (mi_cmd_complete): Likewise.
  58         * mi/mi-cmds.c: Define new MI command -complete.
  59         * NEWS: Mention new -complete command.
  60
  61 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
  62
  63         * completer.h (complete): New function.
  64         * completer.c (complete): Likewise.
  65         * cli/cli-cmds.c: (complete_command): Update to use new complete()
  66         function defined in completer.h.
  67
  68 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
  69
  70        * MAINTAINERS (Write After Approval): Add myself.
  71
  72 2019-05-17  Tom de Vries  <tdevries@suse.de>
  73
  74         PR gdb/24094
  75         * dwarf2read.c (struct cu_partial_die_info): New struct.
  76         (find_partial_die): Return cu_partial_die_info.
  77         (partial_die_parent_scope, guess_partial_die_structure_name)
  78         (partial_die_info::fixup): Handle new return type of find_partial_die.
  79
  80 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  81
  82         * stap-probe.c (stap_parse_register_operand): Make "regname" an
  83         "std::string", simplifying the algorithm.
  84
  85 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  86
  87         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
  88         (stap_static_probe_ops::get_probes): Likewise.
  89
  90 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  91
  92         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
  93         '-')" and "else if".
  94         (stap_parse_single_operand): Join checks for
  95         "gdbarch_stap_parse_special_token_p" and
  96         "gdbarch_stap_parse_special_token" in the same "if" statement.
  97         Invert check when verifying for operation on register
  98         displacement.
  99
 100 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 101
 102         * stap-probe.c (stap_get_opcode): Update comment.
 103         (stap_get_expected_argument_type): Likewise.
 104         (handle_stap_probe): Likewise.
 105
 106 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 107
 108         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 109         return type to 'bool'.  Adjust comment.  Use 'bool' when
 110         appropriate.
 111         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 112         * stap-probe.c (stap_parse_argument_1): Likewise.
 113         (stap_is_operator): Likewise.
 114         (stap_is_generic_prefix): Likewise.
 115         (stap_is_register_prefix): Likewise.
 116         (stap_is_register_indirection_prefix): Likewise.
 117         (stap_is_integer_prefix): Likewise.
 118         (stap_generic_check_suffix): Likewise.
 119         (stap_check_integer_suffix): Likewise.
 120         (stap_check_register_suffix): Likewise.
 121         (stap_check_register_indirection_suffix): Likewise.
 122         (stap_parse_register_operand): Likewise.
 123         (stap_parse_single_operand): Likewise.
 124         (stap_parse_argument_1): Likewise.
 125         (stap_probe::get_argument_count): Likewise.
 126         (stap_is_operator): Likewise.
 127
 128 2019-05-16  Tom Tromey  <tromey@adacore.com>
 129
 130         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 131         keyword to foreach.
 132
 133 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 134
 135         * linux-thread-db.c (try_thread_db_load_1): Change return type
 136         to bool.
 137         (try_thread_db_load): Likewise.
 138         (try_thread_db_load_from_pdir_1): Likewise.
 139         (try_thread_db_load_from_pdir): Likewise.
 140         (try_thread_db_load_from_sdir): Likewise.
 141         (try_thread_db_load_from_dir): Likewise.
 142         (thread_db_load_search): Likewise.
 143         (has_libpthread): Likewise.
 144         (thread_db_load): Likewise.
 145
 146 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 147
 148         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 149         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 150         NULL, and complain/return if that's the case.
 151
 152 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 153
 154         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 155         (advance, posn, abstract_read_memory): New functions.
 156         [struct mem_read_abstraction]: New struct.
 157         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 158
 159 2019-05-14  Tom Tromey  <tromey@adacore.com>
 160
 161         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 162         value is not lval_memory.
 163
 164 2019-05-14  Tom Tromey  <tromey@adacore.com>
 165
 166         * solib.c (info_sharedlibrary_command): Style the file name.
 167
 168 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 169
 170         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 171         (aarch64_vnv_type): Likewise.
 172         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 173         * common/tdesc.c: Likewise.
 174         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 175         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 176         * features/aarch64-fpu.xml: Add ieee half view.
 177         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 178         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 179         * gdbtypes.h (struct builtin_type): Likewise.
 180         (struct objfile_type): Likewise.
 181
 182 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 183
 184         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 185         typo.
 186         * location.h (string_to_event_location): Likewise.
 187
 188 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 189
 190         GDB 8.3 released.
 191
 192 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 193
 194         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 195         New variable declaration.
 196         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 197         New variable.
 198         (print_one_breakpoint): Use ui_out::test_flags and new global
 199         variable to compute use_fixed_output.
 200         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 201         Remove.
 202         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 203         (mi_multi_location_breakpoint_output_fixed): Remove.
 204         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 205         new variable.
 206         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 207         fix_multi_location_breakpoint_output flag if version >= 3.
 208         * ui-out.h (enum ui_out_flag)
 209         <fix_multi_location_breakpoint_output>: New enumerator.
 210
 211 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 212
 213         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 214
 215 2019-05-10  Tom Tromey  <tromey@adacore.com>
 216
 217         * ada-lang.c (catch_ada_completer): New function.
 218         (_initialize_ada_language): Use it.
 219
 220 2019-05-10  Tom Tromey  <tromey@adacore.com>
 221
 222         * thread.c (print_thread_info): Make "requested_threads" const.
 223         * gdbthread.h (print_thread_info): Make "requested_threads"
 224         const.
 225         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 226         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 227
 228 2019-05-08  Tom Tromey  <tom@tromey.com>
 229
 230         * gdbtypes.c (objfile_type_data): Change type.
 231         (objfile_type, _initialize_gdbtypes): Update.
 232
 233 2019-05-08  Tom Tromey  <tom@tromey.com>
 234
 235         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 236         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 237         (_initialize_dwarf2_frame): Update.
 238
 239 2019-05-08  Tom Tromey  <tom@tromey.com>
 240
 241         * objc-lang.c (objc_objfile_data): Change type.
 242         (find_methods): Update.
 243         (_initialize_objc_lang): Remove.
 244
 245 2019-05-08  Tom Tromey  <tom@tromey.com>
 246
 247         * stabsread.c (rs6000_builtin_type_data): Change type.
 248         (rs6000_builtin_type, _initialize_stabsread): Update.
 249
 250 2019-05-08  Tom Tromey  <tom@tromey.com>
 251
 252         * mips-tdep.c (mips_pdr_data): Remove.
 253         (_initialize_mips_tdep): Update.
 254
 255 2019-05-08  Tom Tromey  <tom@tromey.com>
 256
 257         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 258         (hppa_init_objfile_priv_data, read_unwind_info)
 259         (find_unwind_entry, _initialize_hppa_tdep): Update.
 260
 261 2019-05-08  Tom Tromey  <tom@tromey.com>
 262
 263         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 264         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 265         on obstack.
 266         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 267
 268 2019-05-08  Tom Tromey  <tom@tromey.com>
 269
 270         * mdebugread.c (basic_type_data): Change type.
 271         (basic_type, _initialize_mdebugread): Update.
 272
 273 2019-05-08  Tom Tromey  <tom@tromey.com>
 274
 275         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 276
 277 2019-05-08  Tom Tromey  <tom@tromey.com>
 278
 279         * nto-tdep.c (nto_inferior_data_reg): Change type.
 280         (nto_inferior_data): Update.
 281         (nto_inferior_data_cleanup, nto_new_inferior_data)
 282         (_initialize_nto_tdep): Remove.
 283         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 284
 285 2019-05-08  Tom Tromey  <tom@tromey.com>
 286
 287         * ada-lang.c (struct ada_inferior_data): Add initializers.
 288         (ada_inferior_data): Change type.
 289         (ada_inferior_data_cleanup): Remove.
 290         (get_ada_inferior_data, ada_inferior_exit)
 291         (struct ada_pspace_data): Add initializers, destructor.
 292         (ada_pspace_data_handle): Change type.
 293         (get_ada_pspace_data): Update.
 294         (ada_pspace_data_cleanup): Remove.
 295
 296 2019-05-08  Tom Tromey  <tom@tromey.com>
 297
 298         * coffread.c (struct coff_symfile_info): Add initializers.
 299         (coff_objfile_data_key): Move lower.  Change type.
 300         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 301         Update.
 302         (coff_free_info): Remove.
 303
 304 2019-05-08  Tom Tromey  <tom@tromey.com>
 305
 306         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 307         (fbsd_pspace_data_handle): Move lower.  Change type.
 308         (get_fbsd_pspace_data): Update.
 309         (fbsd_pspace_data_cleanup): Remove.
 310         (_initialize_fbsd_tdep): Update.
 311
 312 2019-05-08  Tom Tromey  <tom@tromey.com>
 313
 314         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 315         (get_ada_tasks_pspace_data): Update.
 316         (ada_tasks_pspace_data_cleanup): Remove.
 317         (_initialize_tasks): Update.
 318         (ada_tasks_inferior_data_handle): Change type.
 319         (get_ada_tasks_inferior_data): Update.
 320         (ada_tasks_inferior_data_cleanup): Remove.
 321         (struct ada_tasks_pspace_data): Add initializers.
 322
 323 2019-05-08  Tom Tromey  <tom@tromey.com>
 324
 325         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 326         * symfile-debug.c (debug_sym_get_probes): Change type.
 327         * stap-probe.c (handle_stap_probe):
 328         (stap_static_probe_ops::get_probes): Change type.
 329         * probe.h (class static_probe_ops) <get_probes>: Change type.
 330         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 331         (parse_probes_in_pspace): Update.
 332         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 333         Update.
 334         (any_static_probe_ops::get_probes): Change type.
 335         * elfread.c (elfread_data): New typedef.
 336         (probe_key): Change type.
 337         (elf_get_probes): Likewise.  Update.
 338         (probe_key_free): Remove.
 339         (_initialize_elfread): Update.
 340         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 341         Change type.
 342         (dtrace_process_dof_probe, dtrace_process_dof)
 343         (dtrace_static_probe_ops::get_probe): Change type.
 344
 345 2019-05-08  Tom Tromey  <tom@tromey.com>
 346
 347         * xcoffread.c (struct xcoff_symfile_info): Rename from
 348         coff_symfile_info.  Add initializers.
 349         (xcoff_objfile_data_key): Move lower.  Change type.
 350         (XCOFF_DATA): Rewrite.
 351         (xcoff_free_info): Remove.
 352         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 353         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 354         (xcoff_initial_scan): Update.
 355
 356 2019-05-08  Tom Tromey  <tom@tromey.com>
 357
 358         * solib-svr4.c (struct svr4_info): Add initializers and
 359         destructor.
 360         <probes_table>: Now an htab_up.
 361         (solib_svr4_pspace_data): Change type.
 362         (free_probes_table): Simplify.
 363         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 364         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 365         (probes_table_remove_objfile_probes, register_solib_event_probe)
 366         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 367         (_initialize_svr4_solib): Update.
 368
 369 2019-05-08  Tom Tromey  <tom@tromey.com>
 370
 371         * remote.c (remote_pspace_data): Change type.
 372         (remote_pspace_data_cleanup): Remove.
 373         (get_remote_exec_file, set_pspace_remote_exec_file)
 374         (_initialize_remote): Update.
 375
 376 2019-05-08  Tom Tromey  <tom@tromey.com>
 377
 378         * breakpoint.c (breakpoint_objfile_key): Change type.
 379         (get_breakpoint_objfile_data): Update.
 380         (free_breakpoint_objfile_data): Remove.
 381         (_initialize_breakpoint): Update.
 382
 383 2019-05-08  Tom Tromey  <tom@tromey.com>
 384
 385         * linux-tdep.c (struct linux_info): Add initializers.
 386         (linux_inferior_data): Move.  Change type.
 387         (invalidate_linux_cache_inf): Update.
 388         (linux_inferior_data_cleanup): Remove.
 389         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 390
 391 2019-05-08  Tom Tromey  <tom@tromey.com>
 392
 393         * auxv.c (auxv_inferior_data): Move.  Change type.
 394         (auxv_inferior_data_cleanup): Remove.
 395         (invalidate_auxv_cache_inf): Rewrite.
 396         (get_auxv_inferior_data, _initialize_auxv): Update.
 397
 398 2019-05-08  Tom Tromey  <tom@tromey.com>
 399
 400         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 401         (symfile_debug_objfile_data_key): Change type.
 402         (symfile_debug_installed, debug_qf_has_symbols)
 403         (debug_qf_find_last_source_symtab)
 404         (debug_qf_forget_cached_source_info)
 405         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 406         (debug_qf_print_stats, debug_qf_dump)
 407         (debug_qf_expand_symtabs_for_function)
 408         (debug_qf_expand_all_symtabs)
 409         (debug_qf_expand_symtabs_with_fullname)
 410         (debug_qf_map_matching_symbols)
 411         (debug_qf_expand_symtabs_matching)
 412         (debug_qf_find_pc_sect_compunit_symtab)
 413         (debug_qf_map_symbol_filenames)
 414         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 415         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 416         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 417         (debug_sym_read_linetable, debug_sym_relocate): Update.
 418         (symfile_debug_free_objfile): Remove.
 419         (install_symfile_debug_logging, _initialize_symfile_debug):
 420         Update.
 421
 422 2019-05-08  Tom Tromey  <tom@tromey.com>
 423
 424         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 425         allocate_on_obstack.
 426         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 427         (get_dwarf2_per_objfile): Update.
 428         (set_dwarf2_per_objfile): Remove.
 429         (dwarf2_has_info, dwarf2_get_section_info): Update.
 430         (dwarf2_free_objfile): Remove.
 431         (_initialize_dwarf2_read): Update.
 432
 433 2019-05-08  Tom Tromey  <tom@tromey.com>
 434
 435         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 436         initializers.
 437         <unsupported_script_warning_printed,
 438         script_not_found_warning_printed>: Now bool.
 439         (auto_load_pspace_data): Change type.
 440         (~auto_load_pspace_info): Rename from
 441         auto_load_pspace_data_cleanup.
 442         (get_auto_load_pspace_data, init_loaded_scripts_info)
 443         (clear_section_scripts, maybe_print_unsupported_script_warning)
 444         (maybe_print_script_not_found_warning, _initialize_auto_load):
 445         Update.
 446
 447 2019-05-08  Tom Tromey  <tom@tromey.com>
 448
 449         * objfiles.c (objfile_pspace_info): Add destructor and
 450         initializers.
 451         (objfiles_pspace_data): Change type.
 452         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 453         (get_objfile_pspace_data): Update.
 454         (objfiles_bfd_data): Change type.
 455         (get_objfile_bfd_data): Update.
 456         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 457
 458 2019-05-08  Tom Tromey  <tom@tromey.com>
 459
 460         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 461         Change type.
 462         (get_catch_syscall_inferior_data): Update.
 463         (catch_syscall_inferior_data_cleanup): Remove.
 464         (_initialize_break_catch_syscall): Update.
 465
 466 2019-05-08  Tom Tromey  <tom@tromey.com>
 467
 468         * inflow.c (struct terminal_info): Add destructor and
 469         initializers.
 470         (inflow_inferior_data): Change type.
 471         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 472         (get_inflow_inferior_data, inflow_inferior_exit)
 473         (swap_terminal_info, _initialize_inflow): Update.
 474
 475 2019-05-08  Tom Tromey  <tom@tromey.com>
 476
 477         * target-dcache.c (target_dcache_cleanup): Remove.
 478         (target_dcache_aspace_key): Change type.
 479         (target_dcache_init_p, target_dcache_invalidate)
 480         (target_dcache_get, target_dcache_get_or_init)
 481         (_initialize_target_dcache): Update.
 482         * dcache.h (struct dcache_deleter): New.
 483
 484 2019-05-08  Tom Tromey  <tom@tromey.com>
 485
 486         * symtab.c (struct symbol_cache): Add destructor and
 487         initializers.
 488         (symbol_cache_key): Move.  Change type.
 489         (make_symbol_cache, free_symbol_cache): Remove.
 490         (get_symbol_cache): Update.
 491         (symbol_cache_cleanup): Remove.
 492         (ALL_PSPACES, symbol_cache_flush)
 493         (maintenance_print_symbol_cache)
 494         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 495         Update.
 496
 497 2019-05-08  Tom Tromey  <tom@tromey.com>
 498
 499         * symtab.c (struct main_info): Add destructor and initializers.
 500         (main_progspace_key): Move.  Change type.
 501         (get_main_info): Update.
 502         (main_info_cleanup): Remove.
 503         (_initialize_symtab): Update.
 504
 505 2019-05-08  Tom Tromey  <tom@tromey.com>
 506
 507         * registry.h (DECLARE_REGISTRY): Define the _key class.
 508
 509 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * NEWS: Merge two 'New commands' sections.
 512
 513 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 514
 515         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 516         parameter and use Ada language definition instead.
 517         (ada_val_print_ptr): Remove unused language parameter.
 518         (ada_val_print_num): Remove language parameter and use Ada language
 519         definition instead.
 520         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 521         parameter.
 522         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 523         parameter and use Ada language definition instead.
 524         (ada_val_print_1): Update all ada_val_print_xxx calls.
 525         Remove language parameter.
 526         (ada_val_print): Update ada_val_print_1 call.
 527
 528 2019-05-08  Tom Tromey  <tromey@adacore.com>
 529
 530         * remote.c (remote_hw_watchpoint_limit)
 531         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 532         Now static.
 533
 534 2019-05-08  Tom Tromey  <tromey@adacore.com>
 535
 536         * maint.c (_initialize_maint_cmds): Move initialization code to
 537         remote.c.
 538         (watchdog, show_watchdog): Move to remote.c.
 539         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 540         "watchdog" static.
 541         (_initialize_remote): Move initialization code from maint.c.
 542         * defs.h (watchdog): Don't declare.
 543
 544 2019-05-08  Tom Tromey  <tromey@adacore.com>
 545
 546         * tui/tui-interp.c: Include main.h.
 547         * interps.c: Include main.h.
 548         * main.h (interpreter_p): Declare.
 549         * defs.h (interpreter_p): Don't declare.
 550
 551 2019-05-08  Tom Tromey  <tromey@adacore.com>
 552
 553         * dwarf2loc.c: Include dwarf2read.h.
 554         * defs.h (read_unsigned_leb128): Don't declare.
 555         * dwarf2read.h (read_unsigned_leb128): Declare.
 556
 557 2019-05-08  Tom Tromey  <tromey@adacore.com>
 558
 559         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 560         method.
 561
 562 2019-05-08  Tom Tromey  <tromey@adacore.com>
 563
 564         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 565         when no wrap column is set.
 566
 567 2019-05-08  Tom Tromey  <tromey@adacore.com>
 568
 569         * c-lang.c (c_get_string): Handle non-C-style arrays.
 570
 571 2019-05-08  Tom Tromey  <tromey@adacore.com>
 572
 573         * typeprint.c (print_offset_data::update): Print the bit offset,
 574         not the number of bits remaining.
 575
 576 2019-05-08  Tom Tromey  <tromey@adacore.com>
 577
 578         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 579         padding at end of comment.
 580
 581 2019-05-08  Tom Tromey  <tromey@adacore.com>
 582
 583         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 584         Compare main types.
 585
 586 2019-05-06  Tom Tromey  <tom@tromey.com>
 587
 588         * common/scoped_mmap.c: Include common-defs.h.
 589         * common/scoped_mmap.h: Don't include config.h.
 590
 591 2019-05-04  Tom Tromey  <tom@tromey.com>
 592
 593         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 594         (struct aarch64_call_info): Add initializers.
 595         <si>: Now a std::vector.
 596         (pass_on_stack, aarch64_push_dummy_call): Update.
 597
 598 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 599             Tom Tromey  <tom@tromey.com>
 600
 601         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 602         (ppc_threads): Now a std::vector.  Now static.
 603         (hwdebug_find_thread_points_by_tid)
 604         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 605         Update.
 606
 607 2019-05-04  Tom Tromey  <tom@tromey.com>
 608
 609         * arc-tdep.c (arc_tdesc_init): Return bool.
 610
 611 2019-05-04  Tom Tromey  <tom@tromey.com>
 612
 613         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 614         Use gdb_assert_not_reached.
 615
 616 2019-05-04  Tom Tromey  <tom@tromey.com>
 617
 618         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 619         "false".
 620
 621 2019-05-04  Tom Tromey  <tom@tromey.com>
 622
 623         * arc-tdep.c (arc_tdesc_init): Use bool.
 624
 625 2019-05-04  Tom Tromey  <tom@tromey.com>
 626
 627         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 628
 629 2019-05-04  Tom Tromey  <tom@tromey.com>
 630
 631         * cli/cli-cmds.c (valid_command_p): Return bool.
 632
 633 2019-05-04  Tom Tromey  <tom@tromey.com>
 634
 635         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 636         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 637
 638 2019-05-04  Raul Tambre  <raul@tambre.ee>
 639
 640         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 641         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 642         operator for comparison.
 643
 644 2019-05-04  Tom Tromey  <tom@tromey.com>
 645
 646         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 647         (lookup_partial_symbol, print_partial_symbols)
 648         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 649         (psymbol_compare): Update.
 650         (add_psymbol_to_bcache): Clear the entire psymbol.
 651         (maintenance_check_psymtabs): Update.
 652         * psympriv.h (struct partial_symbol): Don't derive from
 653         general_symbol_info.
 654         <obj_section, unrelocated_address, address,
 655         set_unrelocated_address>: Update.
 656         <ginfo>: New member.
 657         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 658         (debug_names::write_psymbols): Update.
 659
 660 2019-05-04  Tom de Vries  <tdevries@suse.de>
 661
 662         * contrib/cc-with-tweaks.sh: Support -n arg.
 663
 664 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 665
 666         * corelow.c (core_target::detach): Ensure frame cache and
 667         register caches are cleared.
 668         inferior.c (exit_inferior_1): Likewise.
 669
 670 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 671             Tom Tromey  <tom@tromey.com>
 672
 673         * dictionary.c (collate_pending_symbols_by_language): Remove
 674         "struct" from foreach.
 675         * symtab.c (lookup_global_symbol_from_objfile)
 676         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 677         foreach.
 678         * ser-tcp.c (net_open): Remove "struct" from foreach.
 679         * objfiles.c (objfile_relocate, objfile_rebase)
 680         (objfile_has_symbols): Remove "struct" from foreach.
 681         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 682         from foreach.
 683         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 684         foreach.
 685         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 686         "struct" from foreach.
 687         * ada-lang.c (create_excep_cond_exprs)
 688         (ada_exception_catchpoint_cond_string): Remove "struct" from
 689         foreach.
 690
 691 2019-05-03  Tom Tromey  <tromey@adacore.com>
 692
 693         * ada-exp.y (convert_char_literal): Check suffix of each
 694         enumerator.
 695
 696 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 697
 698         PR ada/21406:
 699         * ada-exp.y (yywrap): Don't define.
 700         * ada-lex.l (%option): Add noyywrap
 701         (yywrap): Remove.
 702
 703 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 704
 705         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 706         _WIN32_WINNT to the XP level, unless already defined to a higher
 707         level.
 708
 709         * unittests/parse-connection-spec-selftests.c:
 710         * ser-tcp.c:
 711         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 712         override.
 713
 714         * symfile.c (find_separate_debug_file): Remove colon from the
 715         drive spec of DOS/Windows file names of the target, so that the
 716         file name produced from DEBUGDIR and the target's directory will
 717         be valid on DOS/Windows systems.
 718
 719 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * rust-lang.c (val_print_struct): Handle printing structures
 722         containing strings.
 723
 724 2019-05-02  Tom Tromey  <tromey@adacore.com>
 725
 726         * valarith.c (_initialize_valarith): Remove.
 727
 728 2019-05-01  Tom Tromey  <tromey@adacore.com>
 729
 730         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 731         bitfields.
 732
 733 2019-05-01  Tom Tromey  <tromey@adacore.com>
 734
 735         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 736         for big-endian copies.
 737
 738 2019-04-30  Ali Tamur  <tamur@google.com>
 739         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 740         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 741         (read_3_bytes): New function.
 742
 743 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 744
 745         * windows-nat.c (main_thread_id): Delete.
 746         (handle_output_debug_string): Replace main_thread_id by
 747         current_event.dwThreadId.
 748         (fake_create_process): Likewise.
 749         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 750         Do not set main_thread_id.
 751         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 752         current_event.dwThreadId.
 753         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 754
 755 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 756
 757         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 758         Use current_event.dwThreadId instead of main_thread_id.
 759
 760 2019-04-30  Tom Tromey  <tromey@adacore.com>
 761
 762         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 763         (create_excep_cond_exprs): Iterate over program spaces.
 764         (ada_exception_catchpoint_cond_string): Examine all minimal
 765         symbols for exception types.
 766
 767 2019-04-30  Tom Tromey  <tromey@adacore.com>
 768
 769         PR c++/24470:
 770         * dwarf2read.c (process_structure_scope): Handle case where type
 771         has template parameters but no symbol was created.
 772
 773 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 774             Chris January  <chris.january@arm.com>
 775
 776         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 777         qualifier.
 778         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 779
 780 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * f-typeprint.c (f_print_type): Update rules for printing
 783         whitespace.
 784         (f_type_print_varspec_suffix): Likewise.
 785
 786 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 787             Chris January  <chris.january@arm.com>
 788
 789         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 790         function arguments.
 791
 792 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 793
 794         * f-lang.c (build_fortran_types): Change name of void type to
 795         lower case.
 796         * f-typeprint.c (f_type_print_base): Print the name of the void
 797         type, rather than a fixed string.
 798         * f-valprint.c (f_decorations): Use lower case void string.
 799
 800 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 801             Chris January  <chris.january@arm.com>
 802
 803         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 804         types for Fortran.
 805
 806 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 807             Chris January  <chris.january@arm.com>
 808             David Lecomber  <david.lecomber@arm.com>
 809
 810         * f-exp.y (BINOP_INTRINSIC): New token.
 811         (exp): New parser rule handling BINOP_INTRINSIC.
 812         (f77_keywords): Add new builtin procedures.
 813         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 814         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 815         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 816         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 817         (print_unop_subexp_f): New function.
 818         (print_binop_subexp_f): New function.
 819         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 820         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 821         (dump_subexp_body_f): Likewise.
 822         (operator_check_f): Likewise.
 823         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 824         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 825
 826 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 829         UNOP_KIND.
 830         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 831         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 832         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 833         (operator_length_f): New fuction.
 834         (print_subexp_f): New function.
 835         (op_name_f): New function.
 836         (dump_subexp_body_f): New function.
 837         (operator_check_f): New function.
 838         (exp_descriptor_f): Replace standard expression handling functions
 839         with new functions.
 840         * gdb/fortran-operator.def: New file.
 841         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 842         * gdb/std-operator.def: Remove UNOP_KIND.
 843
 844 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 845
 846         * std-operator.def: Remove unbalanced, stray double quote
 847         character.
 848
 849 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 850             Chris January  <chris.january@arm.com>
 851             Daniel Everett  <daniel.everett@arm.com>
 852             Nick Forrington  <nick.forrington@arm.com>
 853             Richard Bunt  <richard.bunt@arm.com>
 854
 855         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 856         of depth when printing anonymous structs or unions.
 857         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 858         Don't print either the top-level value, or the children if the
 859         max-depth is exceeded.
 860         (ppscm_print_children): When printing the key of a map, allow one
 861         extra level of depth.
 862         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 863         print either the top-level value, or the children if the max-depth
 864         is exceeded.
 865         (print_children): When printing the key of a map, allow one extra
 866         level of depth.
 867         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 868         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 869         (user_print_options): Initialise max_depth field.
 870         (val_print_scalar_or_string_type_p): New function.
 871         (val_print): Check to see if the max depth has been reached.
 872         (val_print_check_max_depth): Define new function.
 873         (show_print_max_depth): New function.
 874         (_initialize_valprint): Add 'print max-depth' option.
 875         * valprint.h (struct value_print_options) <max_depth>: New field.
 876         (val_print_check_max_depth): Declare new function.
 877         * NEWS: Document new feature.
 878
 879 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * ada-lang.c (ada_language_defn): Initialise new field.
 882         * c-lang.c (c_is_string_type_p): New function.
 883         (c_language_defn): Initialise new field.
 884         (cplus_language_defn): Initialise new field.
 885         (asm_language_defn): Initialise new field.
 886         (minimal_language_defn): Initialise new field.
 887         * c-lang.h (c_is_string_type_p): Declare new function.
 888         * d-lang.c (d_language_defn): Initialise new field.
 889         * f-lang.c (f_is_string_type_p): New function.
 890         (f_language_defn): Initialise new field.
 891         * go-lang.c (go_is_string_type_p): New function.
 892         (go_language_defn): Initialise new field.
 893         * language.c (default_is_string_type_p): New function.
 894         (unknown_language_defn): Initialise new field.
 895         (auto_language_defn): Initialise new field.
 896         * language.h (struct language_defn) <la_is_string_type_p>: New
 897         member variable.
 898         (default_is_string_type_p): Declare new function.
 899         * m2-lang.c (m2_language_defn): Initialise new field.
 900         * objc-lang.c (objc_language_defn): Initialise new field.
 901         * opencl-lang.c (opencl_language_defn): Initialise new field.
 902         * p-lang.c (pascal_is_string_type_p): New function.
 903         (pascal_language_defn): Initialise new field.
 904         * rust-lang.c (rust_is_string_type_p): New function.
 905         (rust_language_defn): Initialise new field.
 906
 907 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 910         New field.
 911         * ada-lang.c (ada_language_defn): Initialise new field.
 912         * c-lang.c (c_language_defn): Likewise.
 913         (cplus_language_defn): Likewise.
 914         (asm_language_defn): Likewise.
 915         (minimal_language_defn): Likewise.
 916         * d-lang.c (d_language_defn): Likewise.
 917         * f-lang.c (f_language_defn): Likewise.
 918         * go-lang.c (go_language_defn): Likewise.
 919         * language.c (unknown_language_defn): Likewise.
 920         (auto_language_defn): Likewise.
 921         * m2-lang.c (m2_language_defn): Likewise.
 922         * objc-lang.c (objc_language_defn): Likewise.
 923         * opencl-lang.c (opencl_language_defn): Likewise.
 924         * p-lang.c (pascal_language_defn): Likewise.
 925         * rust-lang.c (rust_language_defn): Likewise.
 926
 927 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * ada-lang.c (ada_is_character_type): Change return type to bool.
 930         (ada_is_string_type): Likewise.
 931         * ada-lang.h (ada_is_character_type): Update declaration
 932         (ada_is_string_type): Likewise.
 933
 934 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 935
 936         Support style in 'frame|thread apply'
 937
 938         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 939         * record.c (record_start, record_stop): Update callers of
 940         execute_command_to_string with false.
 941         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 942         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 943         methods.
 944         (class string_file): New constructor with term_out parameter.
 945         Override methods term_out and can_emit_style_escape.  New member
 946         term_out.
 947         (class stdio_file): Override can_emit_style_escape.
 948         (class tee_file): Override term_out and can_emit_style_escape.
 949         * utils.h (can_emit_style_escape): Remove.
 950         * utils.c (can_emit_style_escape): Likewise.
 951         Update all callers of can_emit_style_escape (SOMESTREAM) to
 952         SOMESTREAM->can_emit_style_escape.
 953         * source-cache.c (source_cache::get_source_lines): Likewise.
 954         * stack.c (frame_apply_command_count): Call execute_command_to_string
 955         passing the term_out characteristic of the current gdb_stdout.
 956         * thread.c (thr_try_catch_cmd): Likewise.
 957         * top.c (execute_command_to_string): pass term_out parameter
 958         to construct the string_file for the command output.
 959         * ui-file.c (term_cli_styling): New function (most code moved
 960         from utils.c can_emit_style_escape).
 961         (string_file::string_file, string_file::can_emit_style_escape,
 962         stdio_file::can_emit_style_escape, tee_file::term_out,
 963         tee_file::can_emit_style_escape): New functions.
 964
 965 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 966
 967         * NEWS: Mention the new set|show may-call-functions.
 968         * infcall.c (may_call_functions_p): New variable.
 969         (show_may_call_functions_p): New function.
 970         (call_function_by_hand_dummy): Throws an error if not
 971         may-call-functions.
 972         (_initialize_infcall): Call add_setshow_boolean_cmd for
 973         may-call-functions.
 974
 975 2019-04-25  Keith Seitz  <keiths@redhat.com>
 976
 977         PR c++/24367
 978         * cp-support.c (inspect_type): Don't attempt substitutions
 979         of symbol with the same name.
 980
 981 2019-04-25  Tom Tromey  <tromey@adacore.com>
 982
 983         PR gdb/24475:
 984         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 985         static.
 986
 987 2019-04-25  Tom Tromey  <tromey@adacore.com>
 988
 989         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 990         rvalue reference.
 991         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 992         (gdb_xml_parser::parse): Use std::move.
 993         * python/python-internal.h (gdbpy_convert_exception): Take a const
 994         reference.
 995         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 996         std::move.
 997         * python/py-utils.c (gdbpy_convert_exception): Take a const
 998         reference.
 999         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1000         Use std::move.
1001         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1002         Use std::move.
1003         * mi/mi-main.c (mi_print_exception): Take a const reference.
1004         * main.c (handle_command_errors): Take a const reference.
1005         * linespec.c (parse_linespec): Use std::move.
1006         * infcall.c (run_inferior_call): Use std::move.
1007         (call_function_by_hand_dummy): Use std::move.
1008         * exec.c (try_open_exec_file): Use std::move.
1009         * exceptions.h (exception_print, exception_fprintf)
1010         (exception_print_same): Update.
1011         * exceptions.c (print_exception, exception_print)
1012         (exception_fprintf, exception_print_same): Change parameters to
1013         const reference.
1014         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1015         * common/new-op.c: Use std::move.
1016         * common/common-exceptions.h (struct gdb_exception): Add move
1017         constructor.
1018         (struct gdb_exception_error, struct gdb_exception_quit, struct
1019         gdb_quit_bad_alloc): Change constructor to move constructor.
1020         (throw_exception): Change parameter to rvalue reference.
1021         * common/common-exceptions.c (throw_exception): Take rvalue
1022         reference.
1023         * cli/cli-interp.c (safe_execute_command): Use std::move.
1024         * breakpoint.c (insert_bp_location, location_to_sals): Use
1025         std::move.
1026
1027 2019-04-25  Tom Tromey  <tromey@adacore.com>
1028
1029         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1030         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1031         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1032         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1033         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1034         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1035         guile/scm-value.c: Use unpack.
1036         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1037         gdbscm_gdb_exception.
1038         (gdbscm_throw_gdb_exception): Likewise.
1039         (struct gdbscm_gdb_exception): New.
1040         (unpack): New function.
1041         (gdbscm_wrap): Use unpack.
1042
1043 2019-04-25  Tom Tromey  <tromey@adacore.com>
1044
1045         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1046         (gdb_rl_callback_handler): Use std::move.
1047         * common/common-exceptions.h (struct gdb_exception): Add move
1048         assignment operator.
1049         (throw_exception_sjlj): Change "exception" to const reference.
1050         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1051         (throw_exception_sjlj): Change "exception" to const reference.
1052
1053 2019-04-25  Tom Tromey  <tromey@adacore.com>
1054
1055         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1056         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1057         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1058         Update.
1059         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1060         Update.
1061         * mi/mi-interp.c (mi_interp::exec): Update.
1062         * linespec.c (parse_linespec): Update.
1063         * infcall.c (run_inferior_call): Update.
1064         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1065         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1066         (gdbscm_lookup_global_symbol): Update.
1067         * guile/scm-param.c (gdbscm_parameter_value): Update.
1068         * guile/scm-frame.c (gdbscm_frame_read_register)
1069         (gdbscm_frame_read_var): Update.
1070         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1071         * exec.c (try_open_exec_file): Update.
1072         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1073         (gdb_rl_callback_handler): Update.
1074         * common/common-exceptions.h (exception_none): Don't declare.
1075         * common/common-exceptions.c (exception_none): Don't define.
1076         (struct catcher) <exception>: Update.
1077         * cli/cli-interp.c (safe_execute_command): Update.
1078         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1079
1080 2019-04-25  Ali Tamur  <tamur@google.com>
1081
1082         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1083         (read_attribute_value): Likewise.
1084         (dwarf2_read_addr_index): Update comment.
1085         (read_str_index): Add DW_FORM_strx.
1086         (dwarf2_string_attr): Likewise.
1087         (dwarf2_const_value_attr): Likewise.
1088         (dump_die_shallow): Likewise.
1089         (dwarf2_fetch_constant_bytes): Likewise.
1090         (skip_form_bytes): Likewise.
1091         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1092
1093 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1094
1095         PR corefiles/11608
1096         PR corefiles/18187
1097         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1098         OFFSET.  Verify if current mapping contains an ELF header.
1099         (linux_find_memory_regions_full): Adjust call to
1100         dump_mapping_p.
1101
1102 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1103             Kang Li <kanglictf@gmail.com>
1104
1105         PR gdb/21600
1106
1107         * dwarf2-frame.c (read_initial_length): Be consistent about using
1108         unsigned representation of length.
1109         (decode_frame_entry_1): Likewise.  Check for wraparound of
1110         end pointer as well as buffer overflow.
1111
1112 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1113
1114         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1115         "vq".
1116
1117 2019-04-24  Tom Tromey  <tromey@adacore.com>
1118
1119         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1120
1121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         * s12z-tdep.c (s12z_unwind_pc): Delete.
1124         (s12z_unwind_sp): Delete.
1125         (s12z_gdbarch_init): Don't register deleted functions with
1126         gdbarch.
1127
1128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * rl78-tdep.c (rl78_unwind_sp): Delete.
1131         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1132
1133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1136         (xstormy16_unwind_pc): Delete.
1137         (xstormy16_dummy_id): Delete.
1138         (xstormy16_gdbarch_init): Don't register deleted functions with
1139         gdbarch.
1140
1141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * vax-tdep.c (vax_unwind_pc): Delete.
1144         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1145
1146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * v850-tdep.c (v850_unwind_sp): Delete.
1149         (v850_unwind_pc): Delete.
1150         (v850_dummy_id): Delete.
1151         (v850_gdbarch_init): Don't register deleted functions with
1152         gdbarch.
1153
1154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1157         (tilegx_unwind_pc): Delete.
1158         (tilegx_unwind_dummy_id): Delete.
1159         (tilegx_gdbarch_init): Don't register deleted functions with
1160         gdbarch.
1161
1162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1165         (tic6x_dummy_id): Delete.
1166         (tic6x_gdbarch_init): Don't register deleted functions with
1167         gdbarch.
1168
1169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * sparc-tdep.c (sparc_unwind_pc): Delete.
1172         (sparc32_gdbarch_init): Don't register deleted function with
1173         gdbarch.
1174
1175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1176
1177         * sh-tdep.c (sh_unwind_sp): Delete.
1178         (sh_unwind_pc): Delete.
1179         (sh_dummy_id): Delete.
1180         (sh_gdbarch_init): Don't register deleted functions with
1181         gdbarch.
1182
1183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1184
1185         * score-tdep.c (score_unwind_sp): Delete.
1186         (score_unwind_pc): Delete.
1187         (score_dummy_id): Delete.
1188         (score_gdbarch_init): Don't register deleted functions with
1189         gdbarch.
1190
1191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         * rx-tdep.c (rx_unwind_pc): Delete.
1194         (rx_unwind_sp): Delete.
1195         (rx_dummy_id): Delete.
1196         (rx_gdbarch_init): Don't register deleted functions with
1197         gdbarch.  Update comment.
1198
1199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1202         (rs6000_dummy_id): Delete.
1203         (rs6000_gdbarch_init): Don't register deleted functions with
1204         gdbarch.
1205
1206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1207
1208         * or1k-tdep.c (or1k_dummy_id): Delete.
1209         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1210
1211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1212
1213         * nios2-tdep.c (nios2_dummy_id): Delete.
1214         (nios2_unwind_sp): Delete.
1215         (nios2_gdbarch_init): Don't register deleted functions with
1216         gdbarch.
1217
1218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * nds32-tdep.c (nds32_dummy_id): Delete.
1221         (nds32_unwind_pc): Delete.
1222         (nds32_unwind_sp): Delete.
1223         (nds32_gdbarch_init): Don't register deleted functions with
1224         gdbarch.
1225
1226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * msp430-tdep.c (msp430_unwind_pc): Delete.
1229         (msp430_unwind_sp): Delete.
1230         (msp430_dummy_id): Delete.
1231         (msp430_gdbarch_init): Don't register deleted functions with
1232         gdbarch.
1233
1234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * moxie-tdep.c (moxie_unwind_sp): Delete.
1237         (moxie_unwind_pc): Delete.
1238         (moxie_dummy_id): Delete.
1239         (moxie_gdbarch_init): Don't register deleted functions with
1240         gdbarch.
1241
1242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1245         (mn10300_unwind_pc): Delete.
1246         (mn10300_unwind_sp): Delete.
1247         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1248         mn10300_unwind_sp.
1249         (mn10300_frame_unwind_init): Don't register deleted functions with
1250         gdbarch.
1251
1252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * mep-tdep.c (mep_unwind_pc): Delete.
1255         (mep_unwind_sp): Delete.
1256         (mep_dummy_id): Delete.
1257         (mep_gdbarch_init): Don't register deleted functions with
1258         gdbarch.
1259
1260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1263         (m68hc11_unwind_sp): Delete.
1264         (m68hc11_gdbarch_init): Don't register deleted functions with
1265         gdbarch.
1266
1267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * m32r-tdep.c (m32r_unwind_sp): Delete.
1270         (m32r_unwind_pc): Delete.
1271         (m32r_dummy_id): Delete.
1272         (m32r_gdbarch_init): Don't register deleted functions with
1273         gdbarch.
1274
1275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * m32c-tdep.c (m32c_unwind_pc): Delete.
1278         (m32c_unwind_sp): Delete.
1279         (m32c_dummy_id): Delete.
1280         (m32c_gdbarch_init): Don't register deleted functions with
1281         gdbarch.
1282
1283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1286         (lm32_unwind_pc): Delete.
1287         (lm32_dummy_id): Delete.
1288         (lm32_gdbarch_init): Don't register deleted functions with
1289         gdbarch.
1290
1291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1294         (iq2000_unwind_pc): Delete.
1295         (iq2000_dummy_id): Delete.
1296         (iq2000_gdbarch_init): Don't register deleted functions with
1297         gdbarch.
1298
1299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * nds32-tdep.c (nds32_type_align): Delete.
1302         (nds32_push_dummy_call): Use type_align instead.
1303
1304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * arm-tdep.c (arm_type_align): Only handle vector override case.
1307         (arm_push_dummy_call): Use type_align.
1308         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1309
1310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1313         case.
1314         (pass_on_stack): Use type_align.
1315         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1316         function.
1317
1318 2019-04-23  Tom Tromey  <tromey@adacore.com>
1319
1320         * dwarf2read.c (line_header::file_name_at): Remove unused
1321         overload.
1322
1323 2019-04-23  Tom de Vries  <tdevries@suse.de>
1324
1325         PR gdb/24438
1326         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1327         invocation.
1328
1329
1330 2019-03-27  Ali Tamur  <tamur@google.com>
1331
1332         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1333         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1334         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1335         (dwarf_expr_context::get_addr_index): Likewise
1336         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1337         (symbol_needs_eval_context::get_addr_index): Likewise
1338         (disassemble_dwarf_expression): Add DW_OP_addrx
1339         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1340         (read_cutu_die_from_dwo): Update comment
1341         (skip_one_die): Add DW_FORM_addrx
1342         (read_attribute_value): Likewise
1343         (var_decode_location): Add DW_OP_addrx
1344         (dwarf2_const_value_attr): Add DW_FORM_addrx
1345         (dump_die_shallow): Likewise
1346         (dwarf2_fetch_constant_bytes): Likewise
1347         (decode_locdesc): Add DW_OP_addrx
1348         (skip_form_bytes): Add DW_FORM_addrx
1349
1350 2019-04-22  Ali Tamur  <tamur@google.com>
1351
1352         * MAINTAINERS (Write After Approval): Add self.
1353
1354 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1355
1356         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1357         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1358         (open_symbol_file_object): Likewise.
1359         (svr4_default_sos): Add info parameter.
1360         (svr4_read_so_list): Likewise.
1361         (svr4_current_sos_direct): Adjust functions calls to pass down
1362         info.
1363         (svr4_current_sos_1): Add info parameter.
1364         (svr4_current_sos): Call get_svr4_info, pass info down to
1365         svr4_current_sos_1.
1366         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1367         get_svr4_info.
1368         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1369         get_svr4_info.
1370         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1371         to get_svr4_info.
1372         (probes_table_remove_objfile_probes): Likewise.
1373         (register_solib_event_probe): Add info parameter.
1374         (solist_update_incremental): Pass info parameter down to
1375         svr4_read_so_list.
1376         (disable_probes_interface): Add info parameter.
1377         (svr4_handle_solib_event): Pass current_program_space to
1378         get_svr4_info.  Adjust disable_probes_interface cleanup.
1379         (svr4_create_probe_breakpoints): Add info parameter, pass it
1380         down to register_solib_event_probe.
1381         (svr4_create_solib_event_breakpoints): Add info parameter,
1382         pass it down to svr4_create_probe_breakpoints.
1383         (enable_break): Pass info down to
1384         svr4_create_solib_event_breakpoints.
1385         (svr4_solib_create_inferior_hook): Pass current_program_space to
1386         get_svr4_info.
1387         (svr4_clear_solib): Likewise.
1388
1389 2019-04-22  Pedro Alves  <palves@redhat.com>
1390
1391         * solib-svr4.c (svr4_free_objfile_observer): New.
1392         (probe_and_action::objfile): New field.
1393         (probes_table_htab_remove_objfile_probes)
1394         (probes_table_remove_objfile_probes): New functions.
1395         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1396         in the new probe_and_action.  Don't store the probe in 'lookup'.
1397         (svr4_create_probe_breakpoints): Pass objfile to
1398         register_solib_event_probe.
1399         (_initialize_svr4_solib): Register a free_objfile observer.
1400
1401 2019-04-19  Tom Tromey  <tom@tromey.com>
1402
1403         * common/queue.h: Remove.
1404
1405 2019-04-19  Tom Tromey  <tom@tromey.com>
1406
1407         * event-loop.c: Don't include "common/queue.h".
1408
1409 2019-04-19  Tom Tromey  <tom@tromey.com>
1410
1411         * remote.c (remote_target): Use delete.
1412         * remote-notif.h: Include <list>, not "common/queue.h".
1413         (notif_client_p): Remove typedef.
1414         (remote_notif_state): Add constructor, destructor, initializer.
1415         <notif_queue>: Now a std::list.
1416         (remote_notif_state_xfree): Don't declare.
1417         * remote-notif.c (remote_notif_process, handle_notification)
1418         (remote_notif_state_allocate): Update.
1419         (~remote_notif_state): Rename from remote_notif_state_xfree.
1420
1421 2019-04-19  Tom Tromey  <tom@tromey.com>
1422
1423         * symfile.c (reread_symbols): Update.
1424         * objfiles.c (objfile_register_static_link)
1425         (objfile_lookup_static_link): Update
1426         (~objfile) Don't delete static_links.
1427         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1428
1429 2019-04-19  Tom Tromey  <tom@tromey.com>
1430
1431         * type-stack.h (struct type_stack) <insert>: Constify string.
1432         * type-stack.c (type_stack::insert): Constify string.
1433         * gdbtypes.h (lookup_template_type): Update.
1434         (address_space_name_to_int): Update.
1435         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1436         const.
1437         (lookup_template_type): Make name const.
1438         * c-exp.y: Update rules.
1439         (lex_one_token, classify_name, classify_inner_name)
1440         (c_print_token): Update.
1441         * p-exp.y: Update rules.
1442         (yylex): Update.
1443         * f-exp.y: Update rules.
1444         (yylex): Update.
1445         * d-exp.y: Update rules.
1446         (lex_one_token, classify_name, classify_inner_name): Update.
1447         * parse.c (write_dollar_variable, copy_name): Return std::string.
1448         * parser-defs.h (copy_name): Change return type.
1449         * m2-exp.y: Update rules.
1450         (yylex): Update.
1451         * go-exp.y (lex_one_token): Update.
1452         Update rules.
1453         (classify_unsafe_function, classify_packaged_name)
1454         (classify_name, yylex): Update.
1455
1456 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1457
1458         * configure.ac: add --enable-source-highlight switch.
1459         * configure: Regenerate.
1460         * top.c (print_gdb_version): plumb --enable-source-highlight
1461         status to "show configuration".
1462
1463 2019-04-19  Tom Tromey  <tromey@adacore.com>
1464
1465         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1466         Check ADA_TYPE_P.
1467         (empty_record, ada_template_to_fixed_record_type_1)
1468         (template_to_static_fixed_type)
1469         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1470         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1471         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1472         macros.
1473
1474 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1475
1476         PR symtab/24423:
1477         * source.c (print_source_lines_base): Advance "iter" when a
1478         control character is seen.
1479
1480 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1481
1482         * inferior.h (struct infcall_suspend_state_deleter):
1483         Catch exception in destructor to avoid crash.
1484
1485 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1486
1487         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1488         close to the add_com "shell".
1489
1490 2019-04-18  Tom Tromey  <tromey@adacore.com>
1491
1492         * process-stratum-target.h (class process_stratum_target)
1493         <stratum>: Add "final".
1494
1495 2019-04-17  Tom Tromey  <tromey@adacore.com>
1496
1497         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1498         against nullptr before use.
1499
1500 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1501
1502         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1503
1504 2019-04-17  Jim Wilson  <jimw@sifive.com>
1505             Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1508         code read might fail, assume 4-byte breakpoint in that case.
1509
1510 2019-04-15  Leszek Swirski  <leszeks@google.com>
1511
1512         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1513         rather than a hand-rolled POD check when checking for forced MEMORY
1514         classification.
1515
1516 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1517
1518         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1519         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1520         function.
1521         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1522         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1523         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1524         declaration.
1525
1526 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1527
1528         * aarch64-linux-nat.c
1529         (aarch64_linux_nat_target::thread_architecture): Add override.
1530         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1531         each VQ.
1532
1533 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1534
1535         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1536
1537 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1540         target types of size 96-bits, add some additional comments, and
1541         check that the builtin type we found was the correct size.
1542
1543 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1544
1545         * utils.c (prompt_for_continue): Don't restore the styling at the
1546         end, as applied_style has the wrong value.  This fixes styling in
1547         long lists of file names that are interrupted by the "Continue?"
1548         prompt.
1549
1550 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1553         * c-lang.c (c_language_defn): Likewise.
1554         (cplus_language_defn): Likewise.
1555         (asm_language_defn): Likewise.
1556         (minimal_language_defn): Likewise.
1557         * d-lang.c (d_language_defn): Likewise.
1558         * f-lang.c (f_language_defn): Likewise.
1559         * go-lang.c (go_language_defn): Likewise.
1560         * language.c (unknown_language_defn): Likewise.
1561         (auto_language_defn): Likewise.
1562         * language.h (struct language_defn): Remove la_magic field.
1563         (LANG_MAGIC): Delete.
1564         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1565         * objc-lang.c (objc_language_defn): Likewise.
1566         * opencl-lang.c (opencl_language_defn): Likewise.
1567         * p-lang.c (pascal_language_defn): Likewise.
1568         * rust-lang.c (rust_language_defn): Likewise.
1569
1570 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1571
1572         * riscv-tdep.c (riscv_type_align): New function.
1573         (riscv_type_alignment): Delete.
1574         (riscv_arg_location): Use 'type_align'.
1575         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1576
1577 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1578
1579         * gdbtypes.c (type_align): A struct with no non-static fields also
1580         has alignment of 1.
1581
1582 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1583
1584         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1585         component to 0.
1586         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1587         member.
1588         (riscv_struct_info::analyse): New implementation using new
1589         analyse_inner member function.
1590         (riscv_struct_info::field_offset): New member function.
1591         (riscv_struct_info::m_offsets): New member variable.
1592         (riscv_struct_info::analyse_inner): New private member function,
1593         takes the old implementation of riscv_struct_info::analyse but
1594         extended to track field offsets.
1595         (riscv_call_arg_struct): Update the struct folding special cases
1596         to handle cases where empty C++ structs, which are non-zero
1597         length, are found.
1598         (riscv_arg_location): Initialise the length of each location, a
1599         non-zero length now indicates the location is in use.
1600         (riscv_push_dummy_call): Allow for the first location having a
1601         non-zero offset when setting up arguments.
1602         (riscv_return_value): Likewise, but for return values.
1603
1604 2019-04-11  Tom Tromey  <tromey@adacore.com>
1605
1606         * utils.c (internal_vproblem): Make "msg" const.
1607
1608 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1609
1610         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1611         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1612         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1613         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1614
1615 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1616
1617         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1618         function.
1619         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1620         of amd64_collect_native_gregset.
1621         (amd64_linux_nat_target::store_registers): Likewise.
1622
1623 2019-04-10  Tom Tromey  <tom@tromey.com>
1624
1625         * symtab.c (lookup_global_symbol_from_objfile)
1626         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1627         * objfiles.h (class separate_debug_iterator): New.
1628         (class separate_debug_range): New.
1629         (struct objfile) <separate_debug_objfiles>: New method.
1630         (objfile_separate_debug_iterate): Don't declare.
1631         * objfiles.c (separate_debug_iterator::operator++): Rename from
1632         objfile_separate_debug_iterate.
1633         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1634         iterator.
1635         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1636         iterator.
1637
1638 2019-04-10  Tom Tromey  <tom@tromey.com>
1639
1640         * symfile.c (reread_symbols): Remove old comment.
1641         * objfiles.c (free_all_objfiles): Fix a typo.
1642
1643 2019-04-10  Tom Tromey  <tom@tromey.com>
1644
1645         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1646         * minsyms.c (lookup_minimal_symbol): Use foreach.
1647         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1648         (lookup_minimal_symbol_solib_trampoline): Likewise.
1649         * symfile.c (reread_symbols): Use foreach.
1650
1651 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1652             Tom Tromey  <tromey@adacore.com>
1653
1654         PR rust/24414:
1655         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1656         (rust_lex_int_test): Change "value" to be LONGEST.
1657         (rust_lex_tests): Add test for long integer literal.
1658
1659 2019-04-09  Tom Tromey  <tromey@adacore.com>
1660
1661         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1662         to bool.
1663         (extended_remote_target::attach): Update.
1664         (remote_target::remote_notice_new_inferior): Update.
1665         (remote_target::add_current_inferior_and_thread): Update.
1666         * inferior.c (exit_inferior_1): Use "false".
1667         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1668
1669 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1670
1671         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1672         the "start" command.
1673
1674 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1675
1676         * python/py-inferior.c (infpy_thread_from_thread_handle):
1677         Adjust comments to reflect renaming of thread_from_thread_handle
1678         to thread_from_handle.  Adjust keywords.  Fix type error message.
1679         (inferior_object_methods): Add thread_from_handle.  Retain
1680         thread_from_thread_handle, but mark it as deprecated.
1681
1682 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1683
1684         * gdbthread.h (find_thread_by_handle): Revise declaration.
1685         * thread.c (find_thread_by_handle): Likewise.  Adjust
1686         implementation too.
1687         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1688         support for buffer objects as handles.
1689
1690 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1691
1692         * python/py-infthread.c (thpy_thread_handle): New function.
1693         (thread_object_methods): Register thpy_thread_handle.
1694
1695 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1696
1697         * gdbthread.h (thread_to_thread_handle): Declare.
1698         * thread.c (gdbtypes.h): Include.
1699         (thread_to_thread_handle): New function.
1700
1701         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1702         (target_thread_info_to_thread_handle): Declare.
1703         * target.c (target_thread_info_to_thread_handle): New function.
1704         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1705         * target-delegates.c: Regenerate.
1706
1707         * linux-thread-db.c (class thread_db_target): Add method
1708         thread_info_to_thread_handle.
1709         (thread_db_target::thread_info_to_thread_handle): Define.
1710         * remote.c (class remote_target): Add new method
1711         thread_info_to_thread_handle.
1712         (remote_target::thread_info_to_thread_handle): Define.
1713
1714 2019-04-08  Pedro Alves  <palves@redhat.com>
1715
1716         * common/common-exceptions.c (throw_exception): Don't create
1717         named object to throw; throw directly.
1718         (throw_it): Likewise.  Don't initialize gdb_exception::message
1719         here, with new; pass FMT and AP to the ctor instead.
1720         * common/common-exceptions.h: Include <string>.
1721         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1722         const char *, va_list)): New ctor.  Use std::make_shared.
1723         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1724         errors)): Delete.
1725         (gdb_exception_error::gdb_exception_error(enum errors, const char
1726         *, va_list)): New.
1727         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1728         Add assertion.
1729         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1730         errors)): Delete.
1731         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1732         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1733         Add assertion.
1734
1735 2019-04-08  Tom Tromey  <tom@tromey.com>
1736
1737         * valops.c (value_rtti_indirect_type): Replace throw_exception
1738         with throw.
1739         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1740         with throw.
1741         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1742         throw.
1743         * target.c (target_translate_tls_address): Replace throw_exception
1744         with throw.
1745         * stack.c (frame_apply_command_count): Replace throw_exception
1746         with throw.
1747         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1748         throw.
1749         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1750         with throw.
1751         * rs6000-tdep.c (rs6000_frame_cache)
1752         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1753         * remote.c: Replace throw_exception with throw.
1754         * record-full.c (record_full_message, record_full_wait_1)
1755         (record_full_restore): Replace throw_exception with throw.
1756         * record-btrace.c:
1757         (get_thread_current_frame_id, record_btrace_start_replaying)
1758         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1759         (cmd_record_btrace_start): Replace throw_exception with throw.
1760         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1761         throw.
1762         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1763         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1764         * linespec.c:
1765         (find_linespec_symbols): Replace throw_exception with throw.
1766         * infrun.c (displaced_step_prepare, resume): Replace
1767         throw_exception with throw.
1768         * infcmd.c (post_create_inferior): Replace throw_exception with
1769         throw.
1770         * inf-loop.c (inferior_event_handler): Replace throw_exception
1771         with throw.
1772         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1773         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1774         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1775         (get_prev_frame_always, get_frame_pc_if_available)
1776         (get_frame_address_in_block_if_available, get_frame_language):
1777         Replace throw_exception with throw.
1778         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1779         throw_exception with throw.
1780         * eval.c (fetch_subexp_value, evaluate_var_value)
1781         (evaluate_funcall, evaluate_subexp_standard): Replace
1782         throw_exception with throw.
1783         * dwarf2loc.c (call_site_find_chain)
1784         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1785         Replace throw_exception with throw.
1786         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1787         with throw.
1788         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1789         throw.
1790         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1791         * completer.c (complete_line_internal): Replace throw_exception
1792         with throw.
1793         * compile/compile-object-run.c (compile_object_run): Replace
1794         throw_exception with throw.
1795         * cli/cli-script.c (process_next_line): Replace throw_exception
1796         with throw.
1797         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1798         (btrace_enable, btrace_maint_update_pt_packets): Replace
1799         throw_exception with throw.
1800         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1801         throw_exception with throw.
1802         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1803         throw_exception with throw.
1804         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1805         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1806         * aarch64-tdep.c (aarch64_make_prologue_cache)
1807         (aarch64_make_stub_cache): Replace throw_exception with throw.
1808
1809 2019-04-08  Tom Tromey  <tom@tromey.com>
1810
1811         * common/common-exceptions.c (throw_exception): Rename from
1812         throw_exception_cxx.  Remove old copy.  Make argument const.
1813         (throw_it): Create and throw exception objects directly.
1814         * common/common-exceptions.h (throw_exception): Make argument
1815         const.
1816         (struct gdb_exception_error): Add constructor.
1817         (struct gdb_exception_quit): Add constructor.
1818
1819 2019-04-08  Tom Tromey  <tom@tromey.com>
1820
1821         * common/common-exceptions.h (exception_rethrow): Don't declare.
1822         (TRY_SJLJ): Update comment.
1823         (TRY, CATCH, END_CATCH): Remove.
1824         * common/common-exceptions.c (exception_rethrow): Remove.
1825
1826 2019-04-08  Tom Tromey  <tom@tromey.com>
1827
1828         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1829         Remove.
1830         (gdb_exception_error): Rename from
1831         gdb_exception_RETURN_MASK_ERROR.
1832         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1833         (gdb_quit_bad_alloc): Update.
1834         * aarch64-tdep.c: Update.
1835         * ada-lang.c: Update.
1836         * ada-typeprint.c: Update.
1837         * ada-valprint.c: Update.
1838         * amd64-tdep.c: Update.
1839         * arch-utils.c: Update.
1840         * break-catch-throw.c: Update.
1841         * breakpoint.c: Update.
1842         * btrace.c: Update.
1843         * c-varobj.c: Update.
1844         * cli/cli-cmds.c: Update.
1845         * cli/cli-interp.c: Update.
1846         * cli/cli-script.c: Update.
1847         * common/common-exceptions.c: Update.
1848         * common/new-op.c: Update.
1849         * common/selftest.c: Update.
1850         * compile/compile-c-symbols.c: Update.
1851         * compile/compile-cplus-symbols.c: Update.
1852         * compile/compile-object-load.c: Update.
1853         * compile/compile-object-run.c: Update.
1854         * completer.c: Update.
1855         * corelow.c: Update.
1856         * cp-abi.c: Update.
1857         * cp-support.c: Update.
1858         * cp-valprint.c: Update.
1859         * darwin-nat.c: Update.
1860         * disasm-selftests.c: Update.
1861         * dtrace-probe.c: Update.
1862         * dwarf-index-cache.c: Update.
1863         * dwarf-index-write.c: Update.
1864         * dwarf2-frame-tailcall.c: Update.
1865         * dwarf2-frame.c: Update.
1866         * dwarf2loc.c: Update.
1867         * dwarf2read.c: Update.
1868         * eval.c: Update.
1869         * event-loop.c: Update.
1870         * event-top.c: Update.
1871         * exec.c: Update.
1872         * f-valprint.c: Update.
1873         * fbsd-tdep.c: Update.
1874         * frame-unwind.c: Update.
1875         * frame.c: Update.
1876         * gdbtypes.c: Update.
1877         * gnu-v3-abi.c: Update.
1878         * guile/guile-internal.h: Update.
1879         * guile/scm-block.c: Update.
1880         * guile/scm-breakpoint.c: Update.
1881         * guile/scm-cmd.c: Update.
1882         * guile/scm-disasm.c: Update.
1883         * guile/scm-frame.c: Update.
1884         * guile/scm-lazy-string.c: Update.
1885         * guile/scm-math.c: Update.
1886         * guile/scm-param.c: Update.
1887         * guile/scm-ports.c: Update.
1888         * guile/scm-pretty-print.c: Update.
1889         * guile/scm-symbol.c: Update.
1890         * guile/scm-symtab.c: Update.
1891         * guile/scm-type.c: Update.
1892         * guile/scm-value.c: Update.
1893         * i386-linux-tdep.c: Update.
1894         * i386-tdep.c: Update.
1895         * inf-loop.c: Update.
1896         * infcall.c: Update.
1897         * infcmd.c: Update.
1898         * infrun.c: Update.
1899         * jit.c: Update.
1900         * language.c: Update.
1901         * linespec.c: Update.
1902         * linux-fork.c: Update.
1903         * linux-nat.c: Update.
1904         * linux-tdep.c: Update.
1905         * linux-thread-db.c: Update.
1906         * main.c: Update.
1907         * mi/mi-cmd-break.c: Update.
1908         * mi/mi-cmd-stack.c: Update.
1909         * mi/mi-interp.c: Update.
1910         * mi/mi-main.c: Update.
1911         * objc-lang.c: Update.
1912         * p-valprint.c: Update.
1913         * parse.c: Update.
1914         * ppc-linux-tdep.c: Update.
1915         * printcmd.c: Update.
1916         * python/py-arch.c: Update.
1917         * python/py-breakpoint.c: Update.
1918         * python/py-cmd.c: Update.
1919         * python/py-finishbreakpoint.c: Update.
1920         * python/py-frame.c: Update.
1921         * python/py-framefilter.c: Update.
1922         * python/py-gdb-readline.c: Update.
1923         * python/py-inferior.c: Update.
1924         * python/py-infthread.c: Update.
1925         * python/py-lazy-string.c: Update.
1926         * python/py-linetable.c: Update.
1927         * python/py-objfile.c: Update.
1928         * python/py-param.c: Update.
1929         * python/py-prettyprint.c: Update.
1930         * python/py-progspace.c: Update.
1931         * python/py-record-btrace.c: Update.
1932         * python/py-record.c: Update.
1933         * python/py-symbol.c: Update.
1934         * python/py-type.c: Update.
1935         * python/py-unwind.c: Update.
1936         * python/py-utils.c: Update.
1937         * python/py-value.c: Update.
1938         * python/python.c: Update.
1939         * record-btrace.c: Update.
1940         * record-full.c: Update.
1941         * remote-fileio.c: Update.
1942         * remote.c: Update.
1943         * riscv-tdep.c: Update.
1944         * rs6000-aix-tdep.c: Update.
1945         * rs6000-tdep.c: Update.
1946         * rust-exp.y: Update.
1947         * rust-lang.c: Update.
1948         * s390-tdep.c: Update.
1949         * selftest-arch.c: Update.
1950         * solib-dsbt.c: Update.
1951         * solib-frv.c: Update.
1952         * solib-spu.c: Update.
1953         * solib-svr4.c: Update.
1954         * solib.c: Update.
1955         * sparc64-linux-tdep.c: Update.
1956         * stack.c: Update.
1957         * symfile-mem.c: Update.
1958         * symmisc.c: Update.
1959         * target.c: Update.
1960         * thread.c: Update.
1961         * top.c: Update.
1962         * tracefile-tfile.c: Update.
1963         * tui/tui.c: Update.
1964         * typeprint.c: Update.
1965         * unittests/cli-utils-selftests.c: Update.
1966         * unittests/parse-connection-spec-selftests.c: Update.
1967         * valops.c: Update.
1968         * valprint.c: Update.
1969         * value.c: Update.
1970         * varobj.c: Update.
1971         * windows-nat.c: Update.
1972         * x86-linux-nat.c: Update.
1973         * xml-support.c: Update.
1974
1975 2019-04-08  Tom Tromey  <tom@tromey.com>
1976
1977         * xml-support.c: Use C++ exception handling.
1978         * x86-linux-nat.c: Use C++ exception handling.
1979         * windows-nat.c: Use C++ exception handling.
1980         * varobj.c: Use C++ exception handling.
1981         * value.c: Use C++ exception handling.
1982         * valprint.c: Use C++ exception handling.
1983         * valops.c: Use C++ exception handling.
1984         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1985         handling.
1986         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1987         * typeprint.c: Use C++ exception handling.
1988         * tui/tui.c: Use C++ exception handling.
1989         * tracefile-tfile.c: Use C++ exception handling.
1990         * top.c: Use C++ exception handling.
1991         * thread.c: Use C++ exception handling.
1992         * target.c: Use C++ exception handling.
1993         * symmisc.c: Use C++ exception handling.
1994         * symfile-mem.c: Use C++ exception handling.
1995         * stack.c: Use C++ exception handling.
1996         * sparc64-linux-tdep.c: Use C++ exception handling.
1997         * solib.c: Use C++ exception handling.
1998         * solib-svr4.c: Use C++ exception handling.
1999         * solib-spu.c: Use C++ exception handling.
2000         * solib-frv.c: Use C++ exception handling.
2001         * solib-dsbt.c: Use C++ exception handling.
2002         * selftest-arch.c: Use C++ exception handling.
2003         * s390-tdep.c: Use C++ exception handling.
2004         * rust-lang.c: Use C++ exception handling.
2005         * rust-exp.y: Use C++ exception handling.
2006         * rs6000-tdep.c: Use C++ exception handling.
2007         * rs6000-aix-tdep.c: Use C++ exception handling.
2008         * riscv-tdep.c: Use C++ exception handling.
2009         * remote.c: Use C++ exception handling.
2010         * remote-fileio.c: Use C++ exception handling.
2011         * record-full.c: Use C++ exception handling.
2012         * record-btrace.c: Use C++ exception handling.
2013         * python/python.c: Use C++ exception handling.
2014         * python/py-value.c: Use C++ exception handling.
2015         * python/py-utils.c: Use C++ exception handling.
2016         * python/py-unwind.c: Use C++ exception handling.
2017         * python/py-type.c: Use C++ exception handling.
2018         * python/py-symbol.c: Use C++ exception handling.
2019         * python/py-record.c: Use C++ exception handling.
2020         * python/py-record-btrace.c: Use C++ exception handling.
2021         * python/py-progspace.c: Use C++ exception handling.
2022         * python/py-prettyprint.c: Use C++ exception handling.
2023         * python/py-param.c: Use C++ exception handling.
2024         * python/py-objfile.c: Use C++ exception handling.
2025         * python/py-linetable.c: Use C++ exception handling.
2026         * python/py-lazy-string.c: Use C++ exception handling.
2027         * python/py-infthread.c: Use C++ exception handling.
2028         * python/py-inferior.c: Use C++ exception handling.
2029         * python/py-gdb-readline.c: Use C++ exception handling.
2030         * python/py-framefilter.c: Use C++ exception handling.
2031         * python/py-frame.c: Use C++ exception handling.
2032         * python/py-finishbreakpoint.c: Use C++ exception handling.
2033         * python/py-cmd.c: Use C++ exception handling.
2034         * python/py-breakpoint.c: Use C++ exception handling.
2035         * python/py-arch.c: Use C++ exception handling.
2036         * printcmd.c: Use C++ exception handling.
2037         * ppc-linux-tdep.c: Use C++ exception handling.
2038         * parse.c: Use C++ exception handling.
2039         * p-valprint.c: Use C++ exception handling.
2040         * objc-lang.c: Use C++ exception handling.
2041         * mi/mi-main.c: Use C++ exception handling.
2042         * mi/mi-interp.c: Use C++ exception handling.
2043         * mi/mi-cmd-stack.c: Use C++ exception handling.
2044         * mi/mi-cmd-break.c: Use C++ exception handling.
2045         * main.c: Use C++ exception handling.
2046         * linux-thread-db.c: Use C++ exception handling.
2047         * linux-tdep.c: Use C++ exception handling.
2048         * linux-nat.c: Use C++ exception handling.
2049         * linux-fork.c: Use C++ exception handling.
2050         * linespec.c: Use C++ exception handling.
2051         * language.c: Use C++ exception handling.
2052         * jit.c: Use C++ exception handling.
2053         * infrun.c: Use C++ exception handling.
2054         * infcmd.c: Use C++ exception handling.
2055         * infcall.c: Use C++ exception handling.
2056         * inf-loop.c: Use C++ exception handling.
2057         * i386-tdep.c: Use C++ exception handling.
2058         * i386-linux-tdep.c: Use C++ exception handling.
2059         * guile/scm-value.c: Use C++ exception handling.
2060         * guile/scm-type.c: Use C++ exception handling.
2061         * guile/scm-symtab.c: Use C++ exception handling.
2062         * guile/scm-symbol.c: Use C++ exception handling.
2063         * guile/scm-pretty-print.c: Use C++ exception handling.
2064         * guile/scm-ports.c: Use C++ exception handling.
2065         * guile/scm-param.c: Use C++ exception handling.
2066         * guile/scm-math.c: Use C++ exception handling.
2067         * guile/scm-lazy-string.c: Use C++ exception handling.
2068         * guile/scm-frame.c: Use C++ exception handling.
2069         * guile/scm-disasm.c: Use C++ exception handling.
2070         * guile/scm-cmd.c: Use C++ exception handling.
2071         * guile/scm-breakpoint.c: Use C++ exception handling.
2072         * guile/scm-block.c: Use C++ exception handling.
2073         * guile/guile-internal.h: Use C++ exception handling.
2074         * gnu-v3-abi.c: Use C++ exception handling.
2075         * gdbtypes.c: Use C++ exception handling.
2076         * frame.c: Use C++ exception handling.
2077         * frame-unwind.c: Use C++ exception handling.
2078         * fbsd-tdep.c: Use C++ exception handling.
2079         * f-valprint.c: Use C++ exception handling.
2080         * exec.c: Use C++ exception handling.
2081         * event-top.c: Use C++ exception handling.
2082         * event-loop.c: Use C++ exception handling.
2083         * eval.c: Use C++ exception handling.
2084         * dwarf2read.c: Use C++ exception handling.
2085         * dwarf2loc.c: Use C++ exception handling.
2086         * dwarf2-frame.c: Use C++ exception handling.
2087         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2088         * dwarf-index-write.c: Use C++ exception handling.
2089         * dwarf-index-cache.c: Use C++ exception handling.
2090         * dtrace-probe.c: Use C++ exception handling.
2091         * disasm-selftests.c: Use C++ exception handling.
2092         * darwin-nat.c: Use C++ exception handling.
2093         * cp-valprint.c: Use C++ exception handling.
2094         * cp-support.c: Use C++ exception handling.
2095         * cp-abi.c: Use C++ exception handling.
2096         * corelow.c: Use C++ exception handling.
2097         * completer.c: Use C++ exception handling.
2098         * compile/compile-object-run.c: Use C++ exception handling.
2099         * compile/compile-object-load.c: Use C++ exception handling.
2100         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2101         * compile/compile-c-symbols.c: Use C++ exception handling.
2102         * common/selftest.c: Use C++ exception handling.
2103         * common/new-op.c: Use C++ exception handling.
2104         * cli/cli-script.c: Use C++ exception handling.
2105         * cli/cli-interp.c: Use C++ exception handling.
2106         * cli/cli-cmds.c: Use C++ exception handling.
2107         * c-varobj.c: Use C++ exception handling.
2108         * btrace.c: Use C++ exception handling.
2109         * breakpoint.c: Use C++ exception handling.
2110         * break-catch-throw.c: Use C++ exception handling.
2111         * arch-utils.c: Use C++ exception handling.
2112         * amd64-tdep.c: Use C++ exception handling.
2113         * ada-valprint.c: Use C++ exception handling.
2114         * ada-typeprint.c: Use C++ exception handling.
2115         * ada-lang.c: Use C++ exception handling.
2116         * aarch64-tdep.c: Use C++ exception handling.
2117
2118 2019-04-08  Tom Tromey  <tom@tromey.com>
2119
2120         * xml-support.c (gdb_xml_parser::parse): Update.
2121         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2122         * value.c (show_convenience): Update.
2123         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2124         (test_parse_flags_qcs): Update.
2125         * thread.c (thr_try_catch_cmd): Update.
2126         * target.c (target_translate_tls_address): Update.
2127         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2128         (info_frame_command_core, frame_apply_command_count): Update.
2129         * rust-exp.y (rust_lex_exception_test): Update.
2130         * riscv-tdep.c (riscv_print_one_register_info): Update.
2131         * remote.c (remote_target::enable_btrace): Update.
2132         * record-btrace.c (record_btrace_enable_warn): Update.
2133         * python/py-utils.c (gdbpy_convert_exception): Update.
2134         * printcmd.c (do_one_display, print_variable_and_value): Update.
2135         * mi/mi-main.c (mi_print_exception): Update.
2136         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2137         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2138         * linux-nat.c (linux_nat_target::attach): Update.
2139         * linux-fork.c (class scoped_switch_fork_info): Update.
2140         * infrun.c (displaced_step_prepare): Update.
2141         * infcall.c (call_function_by_hand_dummy): Update.
2142         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2143         * gnu-v3-abi.c (print_one_vtable): Update.
2144         * frame.c (get_prev_frame_always): Update.
2145         * f-valprint.c (info_common_command_for_block): Update.
2146         * exec.c (try_open_exec_file): Update.
2147         * exceptions.c (print_exception, exception_print)
2148         (exception_fprintf, exception_print_same): Update.
2149         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2150         * dwarf-index-cache.c (index_cache::store)
2151         (index_cache::lookup_gdb_index): Update.
2152         * darwin-nat.c (maybe_cache_shell): Update.
2153         * cp-valprint.c (cp_print_value_fields): Update.
2154         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2155         (gcc_cplus_symbol_address): Update.
2156         * compile/compile-c-symbols.c (gcc_convert_symbol)
2157         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2158         * common/selftest.c: Update.
2159         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2160         a std::string.
2161         (exception_try_scope_entry, exception_try_scope_exit): Don't
2162         declare.
2163         (struct exception_try_scope): Remove.
2164         (TRY): Don't use exception_try_scope.
2165         (struct gdb_exception): Add constructor, operator=.
2166         <what>: New method.
2167         (struct gdb_exception_RETURN_MASK_ALL)
2168         (struct gdb_exception_RETURN_MASK_ERROR)
2169         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2170         (struct gdb_quit_bad_alloc): Update.
2171         * common/common-exceptions.c (exception_none): Change
2172         initializer.
2173         (struct catcher) <state, exception>: Initialize inline.
2174         <prev>: Remove member.
2175         (current_catcher): Remove.
2176         (catchers): New global.
2177         (exceptions_state_mc_init): Simplify.
2178         (catcher_pop): Remove.
2179         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2180         (try_scope_depth, exception_try_scope_entry)
2181         (exception_try_scope_exit): Remove.
2182         (throw_exception_sjlj): Update.
2183         (exception_messages, exception_messages_size): Remove.
2184         (throw_it): Simplify.
2185         (gdb_exception_sliced_copy): Remove.
2186         (throw_exception_cxx): Update.
2187         * cli/cli-script.c (script_from_file): Update.
2188         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2189         Update.
2190         * ada-valprint.c (ada_val_print): Update.
2191         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2192         (create_excep_cond_exprs): Update.
2193
2194 2019-04-08  Tom Tromey  <tom@tromey.com>
2195
2196         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2197         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2198         (TRY, CATCH, END_CATCH): Remove some definitions.
2199         * common/common-exceptions.c: Don't use GDB_XCPT.
2200         (catcher_list_size): Remove.
2201         (throw_exception, throw_it): Simplify.
2202
2203 2019-04-05  Tom Tromey  <tom@tromey.com>
2204
2205         Revert the header-sorting patch.
2206         * ft32-tdep.c: Revert.
2207         * frv-tdep.c: Revert.
2208         * frv-linux-tdep.c: Revert.
2209         * frame.c: Revert.
2210         * frame-unwind.c: Revert.
2211         * frame-base.c: Revert.
2212         * fork-child.c: Revert.
2213         * findvar.c: Revert.
2214         * findcmd.c: Revert.
2215         * filesystem.c: Revert.
2216         * filename-seen-cache.h: Revert.
2217         * filename-seen-cache.c: Revert.
2218         * fbsd-tdep.c: Revert.
2219         * fbsd-nat.h: Revert.
2220         * fbsd-nat.c: Revert.
2221         * f-valprint.c: Revert.
2222         * f-typeprint.c: Revert.
2223         * f-lang.c: Revert.
2224         * extension.h: Revert.
2225         * extension.c: Revert.
2226         * extension-priv.h: Revert.
2227         * expprint.c: Revert.
2228         * exec.h: Revert.
2229         * exec.c: Revert.
2230         * exceptions.c: Revert.
2231         * event-top.c: Revert.
2232         * event-loop.c: Revert.
2233         * eval.c: Revert.
2234         * elfread.c: Revert.
2235         * dwarf2read.h: Revert.
2236         * dwarf2read.c: Revert.
2237         * dwarf2loc.c: Revert.
2238         * dwarf2expr.h: Revert.
2239         * dwarf2expr.c: Revert.
2240         * dwarf2-frame.c: Revert.
2241         * dwarf2-frame-tailcall.c: Revert.
2242         * dwarf-index-write.h: Revert.
2243         * dwarf-index-write.c: Revert.
2244         * dwarf-index-common.c: Revert.
2245         * dwarf-index-cache.h: Revert.
2246         * dwarf-index-cache.c: Revert.
2247         * dummy-frame.c: Revert.
2248         * dtrace-probe.c: Revert.
2249         * disasm.h: Revert.
2250         * disasm.c: Revert.
2251         * disasm-selftests.c: Revert.
2252         * dictionary.c: Revert.
2253         * dicos-tdep.c: Revert.
2254         * demangle.c: Revert.
2255         * dcache.h: Revert.
2256         * dcache.c: Revert.
2257         * darwin-nat.h: Revert.
2258         * darwin-nat.c: Revert.
2259         * darwin-nat-info.c: Revert.
2260         * d-valprint.c: Revert.
2261         * d-namespace.c: Revert.
2262         * d-lang.c: Revert.
2263         * ctf.c: Revert.
2264         * csky-tdep.c: Revert.
2265         * csky-linux-tdep.c: Revert.
2266         * cris-tdep.c: Revert.
2267         * cris-linux-tdep.c: Revert.
2268         * cp-valprint.c: Revert.
2269         * cp-support.c: Revert.
2270         * cp-namespace.c: Revert.
2271         * cp-abi.c: Revert.
2272         * corelow.c: Revert.
2273         * corefile.c: Revert.
2274         * continuations.c: Revert.
2275         * completer.h: Revert.
2276         * completer.c: Revert.
2277         * complaints.c: Revert.
2278         * coffread.c: Revert.
2279         * coff-pe-read.c: Revert.
2280         * cli-out.h: Revert.
2281         * cli-out.c: Revert.
2282         * charset.c: Revert.
2283         * c-varobj.c: Revert.
2284         * c-valprint.c: Revert.
2285         * c-typeprint.c: Revert.
2286         * c-lang.c: Revert.
2287         * buildsym.c: Revert.
2288         * buildsym-legacy.c: Revert.
2289         * build-id.h: Revert.
2290         * build-id.c: Revert.
2291         * btrace.c: Revert.
2292         * bsd-uthread.c: Revert.
2293         * breakpoint.h: Revert.
2294         * breakpoint.c: Revert.
2295         * break-catch-throw.c: Revert.
2296         * break-catch-syscall.c: Revert.
2297         * break-catch-sig.c: Revert.
2298         * blockframe.c: Revert.
2299         * block.c: Revert.
2300         * bfin-tdep.c: Revert.
2301         * bfin-linux-tdep.c: Revert.
2302         * bfd-target.c: Revert.
2303         * bcache.c: Revert.
2304         * ax-general.c: Revert.
2305         * ax-gdb.h: Revert.
2306         * ax-gdb.c: Revert.
2307         * avr-tdep.c: Revert.
2308         * auxv.c: Revert.
2309         * auto-load.c: Revert.
2310         * arm-wince-tdep.c: Revert.
2311         * arm-tdep.c: Revert.
2312         * arm-symbian-tdep.c: Revert.
2313         * arm-pikeos-tdep.c: Revert.
2314         * arm-obsd-tdep.c: Revert.
2315         * arm-nbsd-tdep.c: Revert.
2316         * arm-nbsd-nat.c: Revert.
2317         * arm-linux-tdep.c: Revert.
2318         * arm-linux-nat.c: Revert.
2319         * arm-fbsd-tdep.c: Revert.
2320         * arm-fbsd-nat.c: Revert.
2321         * arm-bsd-tdep.c: Revert.
2322         * arch-utils.c: Revert.
2323         * arc-tdep.c: Revert.
2324         * arc-newlib-tdep.c: Revert.
2325         * annotate.h: Revert.
2326         * annotate.c: Revert.
2327         * amd64-windows-tdep.c: Revert.
2328         * amd64-windows-nat.c: Revert.
2329         * amd64-tdep.c: Revert.
2330         * amd64-sol2-tdep.c: Revert.
2331         * amd64-obsd-tdep.c: Revert.
2332         * amd64-obsd-nat.c: Revert.
2333         * amd64-nbsd-tdep.c: Revert.
2334         * amd64-nbsd-nat.c: Revert.
2335         * amd64-nat.c: Revert.
2336         * amd64-linux-tdep.c: Revert.
2337         * amd64-linux-nat.c: Revert.
2338         * amd64-fbsd-tdep.c: Revert.
2339         * amd64-fbsd-nat.c: Revert.
2340         * amd64-dicos-tdep.c: Revert.
2341         * amd64-darwin-tdep.c: Revert.
2342         * amd64-bsd-nat.c: Revert.
2343         * alpha-tdep.c: Revert.
2344         * alpha-obsd-tdep.c: Revert.
2345         * alpha-nbsd-tdep.c: Revert.
2346         * alpha-mdebug-tdep.c: Revert.
2347         * alpha-linux-tdep.c: Revert.
2348         * alpha-linux-nat.c: Revert.
2349         * alpha-bsd-tdep.c: Revert.
2350         * alpha-bsd-nat.c: Revert.
2351         * aix-thread.c: Revert.
2352         * agent.c: Revert.
2353         * addrmap.c: Revert.
2354         * ada-varobj.c: Revert.
2355         * ada-valprint.c: Revert.
2356         * ada-typeprint.c: Revert.
2357         * ada-tasks.c: Revert.
2358         * ada-lang.c: Revert.
2359         * aarch64-tdep.c: Revert.
2360         * aarch64-ravenscar-thread.c: Revert.
2361         * aarch64-newlib-tdep.c: Revert.
2362         * aarch64-linux-tdep.c: Revert.
2363         * aarch64-linux-nat.c: Revert.
2364         * aarch64-fbsd-tdep.c: Revert.
2365         * aarch64-fbsd-nat.c: Revert.
2366         * aarch32-linux-nat.c: Revert.
2367
2368 2019-04-05  Tom Tromey  <tom@tromey.com>
2369
2370         * ft32-tdep.c: Sort headers.
2371         * frv-tdep.c: Sort headers.
2372         * frv-linux-tdep.c: Sort headers.
2373         * frame.c: Sort headers.
2374         * frame-unwind.c: Sort headers.
2375         * frame-base.c: Sort headers.
2376         * fork-child.c: Sort headers.
2377         * findvar.c: Sort headers.
2378         * findcmd.c: Sort headers.
2379         * filesystem.c: Sort headers.
2380         * filename-seen-cache.h: Sort headers.
2381         * filename-seen-cache.c: Sort headers.
2382         * fbsd-tdep.c: Sort headers.
2383         * fbsd-nat.h: Sort headers.
2384         * fbsd-nat.c: Sort headers.
2385         * f-valprint.c: Sort headers.
2386         * f-typeprint.c: Sort headers.
2387         * f-lang.c: Sort headers.
2388         * extension.h: Sort headers.
2389         * extension.c: Sort headers.
2390         * extension-priv.h: Sort headers.
2391         * expprint.c: Sort headers.
2392         * exec.h: Sort headers.
2393         * exec.c: Sort headers.
2394         * exceptions.c: Sort headers.
2395         * event-top.c: Sort headers.
2396         * event-loop.c: Sort headers.
2397         * eval.c: Sort headers.
2398         * elfread.c: Sort headers.
2399         * dwarf2read.h: Sort headers.
2400         * dwarf2read.c: Sort headers.
2401         * dwarf2loc.c: Sort headers.
2402         * dwarf2expr.h: Sort headers.
2403         * dwarf2expr.c: Sort headers.
2404         * dwarf2-frame.c: Sort headers.
2405         * dwarf2-frame-tailcall.c: Sort headers.
2406         * dwarf-index-write.h: Sort headers.
2407         * dwarf-index-write.c: Sort headers.
2408         * dwarf-index-common.c: Sort headers.
2409         * dwarf-index-cache.h: Sort headers.
2410         * dwarf-index-cache.c: Sort headers.
2411         * dummy-frame.c: Sort headers.
2412         * dtrace-probe.c: Sort headers.
2413         * disasm.h: Sort headers.
2414         * disasm.c: Sort headers.
2415         * disasm-selftests.c: Sort headers.
2416         * dictionary.c: Sort headers.
2417         * dicos-tdep.c: Sort headers.
2418         * demangle.c: Sort headers.
2419         * dcache.h: Sort headers.
2420         * dcache.c: Sort headers.
2421         * darwin-nat.h: Sort headers.
2422         * darwin-nat.c: Sort headers.
2423         * darwin-nat-info.c: Sort headers.
2424         * d-valprint.c: Sort headers.
2425         * d-namespace.c: Sort headers.
2426         * d-lang.c: Sort headers.
2427         * ctf.c: Sort headers.
2428         * csky-tdep.c: Sort headers.
2429         * csky-linux-tdep.c: Sort headers.
2430         * cris-tdep.c: Sort headers.
2431         * cris-linux-tdep.c: Sort headers.
2432         * cp-valprint.c: Sort headers.
2433         * cp-support.c: Sort headers.
2434         * cp-namespace.c: Sort headers.
2435         * cp-abi.c: Sort headers.
2436         * corelow.c: Sort headers.
2437         * corefile.c: Sort headers.
2438         * continuations.c: Sort headers.
2439         * completer.h: Sort headers.
2440         * completer.c: Sort headers.
2441         * complaints.c: Sort headers.
2442         * coffread.c: Sort headers.
2443         * coff-pe-read.c: Sort headers.
2444         * cli-out.h: Sort headers.
2445         * cli-out.c: Sort headers.
2446         * charset.c: Sort headers.
2447         * c-varobj.c: Sort headers.
2448         * c-valprint.c: Sort headers.
2449         * c-typeprint.c: Sort headers.
2450         * c-lang.c: Sort headers.
2451         * buildsym.c: Sort headers.
2452         * buildsym-legacy.c: Sort headers.
2453         * build-id.h: Sort headers.
2454         * build-id.c: Sort headers.
2455         * btrace.c: Sort headers.
2456         * bsd-uthread.c: Sort headers.
2457         * breakpoint.h: Sort headers.
2458         * breakpoint.c: Sort headers.
2459         * break-catch-throw.c: Sort headers.
2460         * break-catch-syscall.c: Sort headers.
2461         * break-catch-sig.c: Sort headers.
2462         * blockframe.c: Sort headers.
2463         * block.c: Sort headers.
2464         * bfin-tdep.c: Sort headers.
2465         * bfin-linux-tdep.c: Sort headers.
2466         * bfd-target.c: Sort headers.
2467         * bcache.c: Sort headers.
2468         * ax-general.c: Sort headers.
2469         * ax-gdb.h: Sort headers.
2470         * ax-gdb.c: Sort headers.
2471         * avr-tdep.c: Sort headers.
2472         * auxv.c: Sort headers.
2473         * auto-load.c: Sort headers.
2474         * arm-wince-tdep.c: Sort headers.
2475         * arm-tdep.c: Sort headers.
2476         * arm-symbian-tdep.c: Sort headers.
2477         * arm-pikeos-tdep.c: Sort headers.
2478         * arm-obsd-tdep.c: Sort headers.
2479         * arm-nbsd-tdep.c: Sort headers.
2480         * arm-nbsd-nat.c: Sort headers.
2481         * arm-linux-tdep.c: Sort headers.
2482         * arm-linux-nat.c: Sort headers.
2483         * arm-fbsd-tdep.c: Sort headers.
2484         * arm-fbsd-nat.c: Sort headers.
2485         * arm-bsd-tdep.c: Sort headers.
2486         * arch-utils.c: Sort headers.
2487         * arc-tdep.c: Sort headers.
2488         * arc-newlib-tdep.c: Sort headers.
2489         * annotate.h: Sort headers.
2490         * annotate.c: Sort headers.
2491         * amd64-windows-tdep.c: Sort headers.
2492         * amd64-windows-nat.c: Sort headers.
2493         * amd64-tdep.c: Sort headers.
2494         * amd64-sol2-tdep.c: Sort headers.
2495         * amd64-obsd-tdep.c: Sort headers.
2496         * amd64-obsd-nat.c: Sort headers.
2497         * amd64-nbsd-tdep.c: Sort headers.
2498         * amd64-nbsd-nat.c: Sort headers.
2499         * amd64-nat.c: Sort headers.
2500         * amd64-linux-tdep.c: Sort headers.
2501         * amd64-linux-nat.c: Sort headers.
2502         * amd64-fbsd-tdep.c: Sort headers.
2503         * amd64-fbsd-nat.c: Sort headers.
2504         * amd64-dicos-tdep.c: Sort headers.
2505         * amd64-darwin-tdep.c: Sort headers.
2506         * amd64-bsd-nat.c: Sort headers.
2507         * alpha-tdep.c: Sort headers.
2508         * alpha-obsd-tdep.c: Sort headers.
2509         * alpha-nbsd-tdep.c: Sort headers.
2510         * alpha-mdebug-tdep.c: Sort headers.
2511         * alpha-linux-tdep.c: Sort headers.
2512         * alpha-linux-nat.c: Sort headers.
2513         * alpha-bsd-tdep.c: Sort headers.
2514         * alpha-bsd-nat.c: Sort headers.
2515         * aix-thread.c: Sort headers.
2516         * agent.c: Sort headers.
2517         * addrmap.c: Sort headers.
2518         * ada-varobj.c: Sort headers.
2519         * ada-valprint.c: Sort headers.
2520         * ada-typeprint.c: Sort headers.
2521         * ada-tasks.c: Sort headers.
2522         * ada-lang.c: Sort headers.
2523         * aarch64-tdep.c: Sort headers.
2524         * aarch64-ravenscar-thread.c: Sort headers.
2525         * aarch64-newlib-tdep.c: Sort headers.
2526         * aarch64-linux-tdep.c: Sort headers.
2527         * aarch64-linux-nat.c: Sort headers.
2528         * aarch64-fbsd-tdep.c: Sort headers.
2529         * aarch64-fbsd-nat.c: Sort headers.
2530         * aarch32-linux-nat.c: Sort headers.
2531
2532 2019-04-04  Tom Tromey  <tom@tromey.com>
2533
2534         * varobj.c (varobj_create): Update.
2535         * rust-exp.y (struct rust_parser) <update_innermost_block,
2536         lookup_symbol>: New methods.
2537         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2538         Rename.
2539         (rust_parser::rust_lookup_type)
2540         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2541         * printcmd.c (display_command, do_one_display): Update.
2542         * parser-defs.h (struct parser_state) <parser_state>: Add
2543         "tracker" parameter.
2544         (block_tracker): New member.
2545         (class innermost_block_tracker) <innermost_block_tracker>: Add
2546         "types" parameter.
2547         <reset>: Remove method.
2548         (innermost_block): Don't declare.
2549         (null_post_parser): Update.
2550         * parse.c (innermost_block): Remove global.
2551         (write_dollar_variable): Update.
2552         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2553         Remove "tracker_types" parameter.
2554         (parse_expression): Add "tracker" parameter.
2555         (parse_expression_for_completion): Update.
2556         (null_post_parser): Add "tracker" parameter.
2557         * p-exp.y: Update rules.
2558         * m2-exp.y: Update rules.
2559         * language.h (struct language_defn) <la_post_parser>: Add
2560         "tracker" parameter.
2561         * go-exp.y: Update rules.
2562         * f-exp.y: Update rules.
2563         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2564         parameter.
2565         * d-exp.y: Update rules.
2566         * c-exp.y: Update rules.
2567         * breakpoint.c (set_breakpoint_condition): Create an
2568         innermost_block_tracker.
2569         (watch_command_1): Likewise.
2570         * ada-lang.c (resolve): Add "tracker" parameter.
2571         (resolve_subexp): Likewise.
2572         * ada-exp.y (write_var_from_sym): Update.
2573
2574 2019-04-04  Tom Tromey  <tom@tromey.com>
2575
2576         * type-stack.h: New file.
2577         * type-stack.c: New file.
2578         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2579         type-stack.h.
2580         (insert_into_type_stack, insert_type, push_type, push_type_int)
2581         (insert_type_address_space, pop_type, pop_type_int)
2582         (pop_typelist, pop_type_stack, append_type_stack)
2583         (push_type_stack, get_type_stack, push_typelist)
2584         (follow_type_instance_flags, follow_types): Don't declare.
2585         * parse.c (type_stack): Remove global.
2586         (parse_exp_in_context): Update.
2587         (insert_into_type_stack, insert_type, push_type, push_type_int)
2588         (insert_type_address_space, pop_type, pop_type_int)
2589         (pop_typelist, pop_type_stack, append_type_stack)
2590         (push_type_stack, get_type_stack, push_typelist)
2591         (follow_type_instance_flags, follow_types): Remove (moved to
2592         type-stack.c).
2593         * f-exp.y (type_stack): New global.
2594         Update rules.
2595         (push_kind_type, f_parse): Update.
2596         * d-exp.y (type_stack): New global.
2597         Update rules.
2598         (d_parse): Update.
2599         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2600         Update rules.
2601         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2602         (HFILES_NO_SRCDIR): Add type-stack.h.
2603
2604 2019-04-04  Tom Tromey  <tom@tromey.com>
2605
2606         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2607         (rust_parser::convert_ast_to_expression, rust_parse)
2608         (rust_lex_test_completion, rust_lex_tests): Update.
2609         * parser-defs.h (struct expr_completion_state): New.
2610         (struct parser_state) <parser_state>: Add completion parameter.
2611         <mark_struct_expression, mark_completion_tag>: New methods.
2612         <parse_completion, m_completion_state>: New members.
2613         (prefixify_expression, null_post_parser): Update.
2614         (mark_struct_expression, mark_completion_tag): Don't declare.
2615         * parse.c (parse_completion, expout_last_struct)
2616         (expout_tag_completion_type, expout_completion_name): Remove
2617         globals.
2618         (parser_state::mark_struct_expression)
2619         (parser_state::mark_completion_tag): Now methods.
2620         (prefixify_expression): Add last_struct parameter.
2621         (prefixify_subexp): Likewise.
2622         (parse_exp_1): Update.
2623         (parse_exp_in_context): Add cstate parameter.  Update.
2624         (parse_expression_for_completion): Create an
2625         expr_completion_state.
2626         (null_post_parser): Add "completion" parameter.
2627         * p-exp.y: Update rules.
2628         (yylex): Update.
2629         * language.h (struct language_defn) <la_post_parser>: Add
2630         "completing" parameter.
2631         * go-exp.y: Update rules.
2632         (lex_one_token): Update.
2633         * expression.h (parse_completion): Don't declare.
2634         * d-exp.y: Update rules.
2635         (lex_one_token): Update rules.
2636         * c-exp.y: Update rules.
2637         (lex_one_token): Update.
2638         * ada-lang.c (resolve): Add "parse_completion" parameter.
2639         (resolve_subexp): Likewise.
2640         (ada_resolve_function): Likewise.
2641
2642 2019-04-04  Tom Tromey  <tom@tromey.com>
2643
2644         * parser-defs.h (struct parser_state) <start_arglist,
2645         end_arglist>: New methods.
2646         <arglist_len, m_funcall_chain>: New members.
2647         (arglist_len, start_arglist, end_arglist): Don't declare.
2648         * parse.c (arglist_len, funcall_chain): Remove global.
2649         (start_arglist, end_arglist): Remove functions.
2650         (parse_exp_in_context): Update.
2651         * p-exp.y: Update rules.
2652         * m2-exp.y: Update rules.
2653         * go-exp.y: Update rules.
2654         * f-exp.y: Update rules.
2655         * d-exp.y: Update rules.
2656         * c-exp.y: Update rules.
2657
2658 2019-04-04  Tom Tromey  <tom@tromey.com>
2659
2660         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2661         lex_operator, push_back>: New methods.
2662         Update all rules.
2663         (rust_parser::lex_hex, lex_escape): Rename and update.
2664         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2665         (rust_parser::lex_operator): Rename and update.
2666         (rust_parser::lex_number, rustyylex, rustyyerror)
2667         (rust_lex_test_init, rust_lex_test_sequence)
2668         (rust_lex_test_push_back, rust_lex_tests): Update.
2669         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2670         parameter.
2671         <lexptr, prev_lexptr>: New members.
2672         (lexptr, prev_lexptr): Don't declare.
2673         * parse.c (lexptr, prev_lexptr): Remove globals.
2674         (parse_exp_in_context): Update.
2675         * p-exp.y (yylex, yyerror): Update.
2676         * m2-exp.y (parse_number, yylex, yyerror): Update.
2677         * go-exp.y (lex_one_token, yyerror): Update.
2678         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2679         * d-exp.y (lex_one_token, yyerror): Update.
2680         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2681         (lex_one_token, yyerror): Update.
2682         * ada-lex.l (YY_INPUT): Update.
2683         (rewind_to_char): Update.
2684         * ada-exp.y (yyerror): Update.
2685
2686 2019-04-04  Tom Tromey  <tom@tromey.com>
2687
2688         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2689         * parser-defs.h (struct parser_state) <parser_state>: Add new
2690         parameter.
2691         <comma_terminates>: New member.
2692         (comma_terminates): Don't declare global.
2693         * parse.c (comma_terminates): Remove global.
2694         (parse_exp_in_context): Update.
2695         * p-exp.y (yylex): Update.
2696         * m2-exp.y (yylex): Update.
2697         * go-exp.y (lex_one_token): Update.
2698         * f-exp.y (yylex): Update.
2699         * d-exp.y (lex_one_token): Update.
2700         * c-exp.y (lex_one_token): Update.
2701         * ada-lex.l: Update.
2702
2703 2019-04-04  Tom Tromey  <tom@tromey.com>
2704
2705         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2706         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2707         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2708         * parser-defs.h (paren_depth): Don't declare.
2709         * parse.c (paren_depth): Remove global.
2710         (parse_exp_in_context): Update.
2711         * p-exp.y (paren_depth): New global.
2712         (pascal_parse): Initialize it.
2713         * m2-exp.y (paren_depth): New global.
2714         (m2_parse): Initialize it.
2715         * go-exp.y (paren_depth): New global.
2716         (go_parse): Initialize it.
2717         * f-exp.y (paren_depth): New global.
2718         (f_parse): Initialize it.
2719         * d-exp.y (paren_depth): New global.
2720         (d_parse): Initialize it.
2721         * c-exp.y (paren_depth): New global.
2722         (c_parse): Initialize it.
2723         * ada-lex.l (paren_depth): New global.
2724         (lexer_init): Initialize it.
2725
2726 2019-04-04  Tom Tromey  <tom@tromey.com>
2727
2728         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2729         (rust_parser::convert_ast_to_type)
2730         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2731         * parser-defs.h (struct parser_state) <parser_state>: Add
2732         parameters.  Initialize new members.
2733         <expression_context_block, expression_context_pc>: New members.
2734         * parse.c (expression_context_block, expression_context_pc):
2735         Remove globals.
2736         (parse_exp_in_context): Update.
2737         * p-exp.y: Update all rules.
2738         (yylex): Update.
2739         * m2-exp.y: Update all rules.
2740         (yylex): Update.
2741         * go-exp.y (yylex): Update.
2742         * f-exp.y (yylex): Update.
2743         * d-exp.y: Update all rules.
2744         (yylex): Update.
2745         * c-exp.y: Update all rules.
2746         (lex_one_token, classify_name, yylex, c_parse): Update.
2747         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2748
2749 2019-04-04  Tom Tromey  <tom@tromey.com>
2750
2751         * gdbarch.h, gdbarch.c: Rebuild.
2752         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2753         * stap-probe.h:
2754         (struct stap_parse_info): Replace "parser_state" with
2755         "expr_builder".
2756         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2757         (parser_state): New class.
2758         * parse.c (expr_builder): Rename.
2759         (expr_builder::release): Rename.
2760         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2761         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2762         (write_exp_elt_longcst, write_exp_elt_floatcst)
2763         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2764         (write_exp_string_vector, write_exp_bitstring)
2765         (write_exp_msymbol, mark_struct_expression)
2766         (write_dollar_variable)
2767         (insert_type_address_space, increase_expout_size): Replace
2768         "parser_state" with "expr_builder".
2769         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2770         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2771         "parser_state" with "expr_builder".
2772
2773 2019-04-04  Tom Tromey  <tom@tromey.com>
2774
2775         * rust-exp.y: Replace "parse_language" with method call.
2776         * p-exp.y:
2777         (yylex): Replace "parse_language" with method call.
2778         * m2-exp.y:
2779         (yylex): Replace "parse_language" with method call.
2780         * go-exp.y (classify_name): Replace "parse_language" with method
2781         call.
2782         * f-exp.y (yylex): Replace "parse_language" with method call.
2783         * d-exp.y (lex_one_token): Replace "parse_language" with method
2784         call.
2785         * c-exp.y:
2786         (lex_one_token, classify_name, yylex): Replace "parse_language"
2787         with method call.
2788         * ada-exp.y (find_primitive_type, type_char)
2789         (type_system_address): Replace "parse_language" with method call.
2790
2791 2019-04-04  Tom Tromey  <tom@tromey.com>
2792
2793         * rust-exp.y: Replace "parse_gdbarch" with method call.
2794         * parse.c (write_dollar_variable, insert_type_address_space):
2795         Replace "parse_gdbarch" with method call.
2796         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2797         call.
2798         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2799         call.
2800         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2801         "parse_gdbarch" with method call.
2802         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2803         with method call.
2804         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2805         "parse_gdbarch" with method call.
2806         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2807         "parse_gdbarch" with method call.
2808         * c-exp.y (parse_type, parse_number, classify_name): Replace
2809         "parse_gdbarch" with method call.
2810         * ada-lex.l: Replace "parse_gdbarch" with method call.
2811         * ada-exp.y (parse_type, find_primitive_type, type_char)
2812         (type_system_address): Replace "parse_gdbarch" with method call.
2813
2814 2019-04-04  Tom Tromey  <tom@tromey.com>
2815
2816         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2817         * stap-probe.c (stap_parse_argument): Update.
2818         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2819         initial_size parameter.
2820         * rust-exp.y (rust_lex_tests): Update.
2821         * parse.c (parser_state): Update.
2822         (parse_exp_in_context): Update.
2823         * parser-defs.h (struct parser_state) <parser_state>: Remove
2824         "initial_size" parameter.
2825
2826 2019-04-04  Tom Tromey  <tom@tromey.com>
2827
2828         * parser-defs.h (increase_expout_size): Don't declare.
2829         * parse.c (increase_expout_size): Now static.
2830
2831 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2832
2833         * gnu-nat.c (gnu_nat_target::wait): Fix
2834         target_waitstatus_to_string call.
2835
2836 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * eval.c (evaluate_subexp_standard): Handle internal functions
2839         during Fortran function call handling.
2840
2841 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * NEWS: Mention new internal functions.
2844         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2845         (read_base_type): Use dwarf2_init_complex_target_type.
2846         * value.c (creal_internal_fn): New function.
2847         (cimag_internal_fn): New function.
2848         (_initialize_values): Register new internal functions.
2849
2850 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2851
2852         * infrun.c (stop_all_threads): If debug_infrun, always
2853         trace the wait status after wait_one, using
2854         target_waitstatus_to_string and target_pid_to_str.
2855         (handle_inferior_event): Replace various trace of
2856         wait status kind by a single trace.
2857         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2858         wait status kind image by target_waitstatus_to_string.
2859         * target/waitstatus.c (target_waitstatus_to_string): Fix
2860         obsolete comment.
2861
2862 2019-04-01  Tom Tromey  <tromey@adacore.com>
2863
2864         PR symtab/23331:
2865         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2866
2867 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2868             Pedro Alves  <palves@redhat.com>
2869
2870         * top.c (quit_force): Call 'finalize_values'.
2871         * value.c (finalize_values): New function.
2872         * value.h (finalize_values): Declare.
2873
2874 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2875
2876         * NEWS: Announce $_gdb_major and $_gdb_minor.
2877
2878         * top.c (init_gdb_version_vars): New function.
2879         (gdb_init): Call init_gdb_version_vars.
2880
2881 2019-03-29  Tom Tromey  <tromey@adacore.com>
2882
2883         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2884         help text.  Remove dead code.
2885
2886 2019-03-29  Keith Seitz  <keiths@redhat.com>
2887
2888         From Siddhesh Poyarekar:
2889         * f-lang.h (f77_get_upperbound): Return LONGEST.
2890         (f77_get_lowerbound): Likewise.
2891         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2892         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2893         print them.
2894         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2895         plongest to format print it.
2896         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2897         (f77_get_upperbound): Likewise.
2898         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2899         LOWER_BOUND to LONGEST.
2900         (f77_create_arrayprint_offset_tbl): Likewise.
2901
2902 2019-03-29  Keith Seitz  <keiths@redhat.com>
2903
2904         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2905         %s/pulongest for TYPE_LENGTH instead of %d in format
2906         strings.
2907         * ada-typerint.c (ada_print_type): Likewise.
2908         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2909         * compile/compile-c-support.c (generate_register_struct): Likewise.
2910         * gdbtypes.c (recursive_dump_type): Likewise.
2911         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2912         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2913         instead of %d in format strings.
2914         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2915         to std::min to ULONGEST.
2916         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2917         instead of %d in format strings.
2918         * tracepoint.c (info_scope_command): Likewise.
2919         * typeprint.c (print_offset_data::update)
2920         (print_offset_data::finish): Likewise.
2921         * xtensa-tdep.c (xtensa_store_return_value)
2922         (xtensa_push_dummy_call): Likewise.
2923
2924 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2925
2926         * windows-nat.c (display_selector): Fixed format specifications
2927         for 64-bit Cygwin.
2928
2929 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2930
2931         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2932
2933 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2934
2935         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2936         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2937         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2938         (nios2_linux_init_abi): Install it.
2939
2940 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2941
2942         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2943
2944 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2945
2946         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2947
2948 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2949             Tom Tromey  <tromey@adacore.com>
2950
2951         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2952
2953 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2954
2955         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2956         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2957         method to compute the bounds of range types. Also print "[evaluated]"
2958         if the bounds' values come from a dynamic evaluation.
2959
2960 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2963         whitespace when pretty printing is on.
2964
2965 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2966
2967         * ppc-linux-nat.c: Add include.
2968
2969 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2970
2971         * NEWS: Mention AArch64 Pointer Authentication.
2972
2973 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2974
2975         * arm-linux-nat.c: Add include.
2976
2977 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2978
2979         * source-cache.c (source_cache::get_source_lines): Re-read
2980         fullname after calling open_source_file.
2981
2982 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2983
2984         * NEWS: Mention TLS support for FreeBSD.
2985
2986 2019-03-25  Tom Tromey  <tromey@adacore.com>
2987
2988         * minsyms.c (BUNCH_SIZE): Update comment.
2989         (~minimal_symbol_reader): Remove old comment.
2990         (compact_minimal_symbols): Update comment.
2991         (minimal_symbol_reader::install): Remove old comment.  Update
2992         other comments.
2993
2994 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2995
2996         * s390-linux-nat.c: Add include.
2997
2998 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2999
3000         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3001         Call linux_get_hwcap.
3002         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3003         Likewise.
3004         (aarch64_linux_get_hwcap): Remove function.
3005         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3006         declaration.
3007         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3008         linux_get_hwcap.
3009         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3010         * linux-tdep.c (linux_get_hwcap): Add function.
3011         (linux_get_hwcap2): Likewise.
3012         * linux-tdep.h (linux_get_hwcap): Add declaration.
3013         (linux_get_hwcap2): Likewise.
3014         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3015         (ppc_linux_get_hwcap2): Likewise.
3016         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3017         linux_get_hwcap.
3018         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3019         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3020         (ppc_linux_nat_target::read_description): Likewise.
3021         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3022         * s390-linux-nat.c: Likewise.
3023         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3024
3025 2019-03-24  Tom Tromey  <tom@tromey.com>
3026
3027         * ada-lang.c (standard_lookup): Simplify initialization.
3028         (ada_lookup_symbol_nonlocal): Simplify return.
3029         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3030         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3031         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3032         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3033         initialization.
3034         * solib.c (solib_global_lookup): Simplify.
3035         * symtab.c (null_block_symbol): Remove.
3036         (symbol_cache_lookup): Simplify returns.
3037         (lookup_language_this): Simplify returns.
3038         (lookup_symbol_aux): Simplify return.
3039         (lookup_local_symbol): Simplify returns.
3040         (lookup_global_symbol_from_objfile): Simplify return.
3041         (lookup_symbol_in_objfile_symtabs)
3042         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3043         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3044         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3045         * cp-namespace.c (cp_lookup_bare_symbol)
3046         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3047         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3048         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3049         (cp_lookup_symbol_via_imports): Simplify initialization.
3050         (find_symbol_in_baseclass): Likewise.
3051         * symtab.h (null_block_symbol): Remove.
3052         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3053         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3054         (d_lookup_symbol_module): Likewise.
3055         (find_symbol_in_baseclass): Simplify initialization.
3056
3057 2019-03-24  Tom Tromey  <tom@tromey.com>
3058
3059         * expression.h: Don't include symtab.h.
3060         (struct block): Forward declare.
3061
3062 2019-03-24  Tom Tromey  <tom@tromey.com>
3063
3064         * c-exp.y (typebase): Remove casts.
3065         * gdbtypes.c (lookup_unsigned_typename, )
3066         (lookup_signed_typename): Remove cast.
3067         * eval.c (parse_to_comma_and_eval): Remove cast.
3068         * parse.c (write_dollar_variable): Remove cast.
3069         * block.h (struct block) <superblock>: Now const.
3070         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3071         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3072         (map_block): Make "block" const.
3073         * symfile.h (struct quick_symbol_functions)
3074         <map_matching_symbols>: Constify block argument to "callback".
3075         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3076         const.
3077         (find_pc_sect_compunit_symtab): Make "b" const.
3078         (find_symbol_at_address): Likewise.
3079         (search_symbols): Likewise.
3080         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3081         (dw2_debug_names_lookup_symbol): Likewise.
3082         (dw2_map_matching_symbols): Update.
3083         * p-valprint.c (pascal_val_print): Remove "block".
3084         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3085         (aux_add_nonlocal_symbols): Make "block" const.
3086         (resolve_subexp): Remove cast.
3087         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3088         const.
3089         (iterate_over_file_blocks): Likewise.
3090         * f-exp.y (%union) <bval>: Remove.
3091         * coffread.c (patch_opaque_types): Make "b" const.
3092         * spu-tdep.c (spu_catch_start): Make "block" const.
3093         * c-valprint.c (print_unpacked_pointer): Remove "block".
3094         * symmisc.c (dump_symtab_1): Make "b" const.
3095         (block_depth): Make "block" const.
3096         * d-exp.y (%union) <bval>: Remove.
3097         * cp-support.h (cp_lookup_rtti_type): Update.
3098         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3099         * psymtab.c (psym_lookup_symbol): Make "block" const.
3100         (maintenance_check_psymtabs): Make "b" const.
3101         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3102         (enumerate_locals, enumerate_args): Update.
3103         * python/py-symtab.c (stpy_global_block): Make "block" const.
3104         (stpy_static_block): Likewise.
3105         * inline-frame.c (block_starting_point_at): Make "new_block"
3106         const.
3107         * block.c (find_block_in_blockvector): Make return type const.
3108         (blockvector_for_pc_sect): Make "b" const.
3109         (find_block_in_blockvector): Make "b" const.
3110
3111 2019-03-23  Tom Tromey  <tom@tromey.com>
3112
3113         * varobj.c (varobj_create): Update.
3114         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3115         * printcmd.c (display_command, do_one_display): Don't reset
3116         innermost_block.
3117         * parser-defs.h (enum innermost_block_tracker_type): Move to
3118         expression.h.
3119         (innermost_block): Update comment.
3120         * parse.c (parse_exp_1): Add tracker_types parameter.
3121         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3122         tracker_types parameter.  Reset innermost_block.
3123         (parse_exp_in_context): Remove.
3124         (parse_expression_for_completion): Update.
3125         * objfiles.c (~objfile): Don't reset expression_context_block or
3126         innermost_block.
3127         * expression.h (enum innermost_block_tracker_type): Move from
3128         parser-defs.h.
3129         (parse_exp_1): Add tracker_types parameter.
3130         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3131         reset innermost_block.
3132
3133 2019-03-23  Tom Tromey  <tom@tromey.com>
3134
3135         * objfiles.h: Include bcache.h.
3136
3137 2019-03-23  Tom Tromey  <tom@tromey.com>
3138
3139         * linespec.c (get_current_search_block): Use
3140         scoped_restore_current_language.
3141         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3142
3143 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3144             Jiong Wang  <jiong.wang@arm.com>
3145
3146         * aarch64-linux-tdep.c
3147         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3148         section.
3149         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3150
3151 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3152             Jiong Wang  <jiong.wang@arm.com>
3153
3154         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3155         instructions.
3156         (aarch64_analyze_prologue_test): Add PACIASP test.
3157         (aarch64_prologue_prev_register): Unmask PC value.
3158
3159 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3160             Jiong Wang  <jiong.wang@arm.com>
3161
3162         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3163         (aarch64_dwarf2_prev_register): Unmask PC value.
3164         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3165         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3166         DW_CFA_AARCH64_negate_ra_state.
3167         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3168
3169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3170             Jiong Wang  <jiong.wang@arm.com>
3171
3172         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3173         registers.
3174         (aarch64_pseudo_register_name): Likewise.
3175         (aarch64_pseudo_register_type): Likewise.
3176         (aarch64_pseudo_register_reggroup_p): Likewise.
3177         (aarch64_gdbarch_init): Add pauth registers.
3178         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3179         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3180         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3181         (struct gdbarch_tdep): Add regnum for ra_state.
3182
3183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3184             Jiong Wang  <jiong.wang@arm.com>
3185
3186         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3187
3188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3189             Jiong Wang  <jiong.wang@arm.com>
3190
3191         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3192         function.
3193         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3194         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3195         (aarch64_gdbarch_init): Add puth registers.
3196         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3197         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3198         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3199
3200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3201             Jiong Wang  <jiong.wang@arm.com>
3202
3203         * aarch64-linux-nat.c
3204         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3205         * aarch64-linux-tdep.c
3206         (aarch64_linux_core_read_description): Likewise.
3207         (aarch64_linux_get_hwcap): New function.
3208         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3209         (aarch64_linux_get_hwcap): New declaration.
3210
3211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3212             Jiong Wang  <jiong.wang@arm.com>
3213
3214         * aarch64-linux-nat.c
3215         (aarch64_linux_nat_target::read_description): Add pauth param.
3216         * aarch64-linux-tdep.c
3217         (aarch64_linux_core_read_description): Likewise.
3218         * aarch64-tdep.c (struct target_desc): Add in pauth.
3219         (aarch64_read_description): Add pauth param.
3220         (aarch64_gdbarch_init): Likewise.
3221         * aarch64-tdep.h (aarch64_read_description): Likewise.
3222         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3223         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3224         * features/Makefile: Add new files.
3225         * features/aarch64-pauth.c: New file.
3226         * features/aarch64-pauth.xml: New file.
3227
3228 2019-03-20  Tom Tromey  <tromey@adacore.com>
3229
3230         * infrun.c (handle_inferior_event): Rename from
3231         handle_inferior_event_1.  Create a scoped_value_mark.
3232         (handle_inferior_event): Remove.
3233
3234 2019-03-19  Tom Tromey  <tromey@adacore.com>
3235
3236         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3237         * infrun.h (print_stop_event): Add "displays" parameter.
3238         * infrun.c (print_stop_event): Add "displays" parameter.
3239
3240 2019-03-19  Pedro Alves  <palves@redhat.com>
3241
3242         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3243         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3244         to -1.  Fix TABs vs spaces.
3245         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3246         * tui/tui-out.h (tui_ui_out) Add intro comments.
3247         <m_line, m_start_of_line>: In-class initialize, and add describing
3248         comment.
3249
3250 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3251
3252         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3253         variable names.
3254         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3255
3256 2019-03-18  Pedro Alves  <palves@redhat.com>
3257             Eli Zaretskii <eliz@gnu.org>
3258
3259         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3260         m_line and m_start_of_line.
3261
3262 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3263
3264         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3265         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3266         it returns a newline.  This fixes a regression in TU mode, whereby
3267         the next line is output on the same screen line as the user input.
3268
3269 2019-03-18  Tom Tromey  <tromey@adacore.com>
3270
3271         * minsyms.c (minimal_symbol_reader::install): Remove call to
3272         obstack_blank.
3273
3274 2019-03-18  Pedro Alves  <palves@redhat.com>
3275
3276         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3277         New globals.
3278         (apply_style): New, factored out from ...
3279         (apply_ansi_escape): ... this.  Handle reverse video mode.
3280         (tui_set_reverse_mode): New function.
3281         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3282         * tui/tui-winsource.c (tui_show_source_line): Use
3283         tui_set_reverse_mode instead of setting A_STANDOUT.
3284         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3285         New setter methods.
3286
3287 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3288
3289         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3290         Handle tabs.
3291
3292 2019-03-18  Tom Tromey  <tromey@adacore.com>
3293
3294         * ada-lang.c (empty_array): Add "high" parameter.
3295         (ada_evaluate_subexp): Update.
3296
3297 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3298
3299         * unittests/string_view-selftests.c: Define
3300         _initialize_string_view_selftests unconditionally.
3301
3302 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3303
3304         PR gdb/24350
3305         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3306
3307 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3308
3309         PR gdb/24351
3310         * windows-nat.c (display_selector): Fix format specifiers.
3311
3312 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3313
3314         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3315         tui_refill_source_window instead of tui_refresh_win, to update the
3316         current execution line.  This fixes redisplay of the current line
3317         when stepping through the code with "next" or "step".
3318
3319 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3320
3321         * source-cache.c (source_cache::get_source_lines): Call
3322         find_source_lines to initialize s->nlines.  This fixes vertical
3323         scrolling of TUI source window when the DOWN arrow is pressed.
3324
3325 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3326
3327         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3328         linux-thread-db.c (_initialize_thread_db): Likewise.
3329
3330 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3331
3332         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3333         wclrtoeol in tui_show_source_line".  This reverts changes made in
3334         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3335
3336 2019-03-15  Tom Tromey  <tom@tromey.com>
3337
3338         * symtab.h (struct minimal_symbol): Derive from
3339         general_symbol_info.
3340         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3341         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3342         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3343         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3344         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3345         (MSYMBOL_SEARCH_NAME): Update.
3346         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3347         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3348         * minsyms.c (minimal_symbol_reader::record_full): Update.
3349
3350 2019-03-15  Tom Tromey  <tom@tromey.com>
3351
3352         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3353
3354 2019-03-15  Tom Tromey  <tom@tromey.com>
3355
3356         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3357         unique_xmalloc_ptr.
3358         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3359         Update.
3360         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3361         (build_minimal_symbol_hash_tables)
3362         (minimal_symbol_reader::install): Update.
3363
3364 2019-03-15  Tom Tromey  <tom@tromey.com>
3365
3366         * symtab.c (create_demangled_names_hash): Update.
3367         (symbol_set_names): Update.
3368         * objfiles.h (struct objfile_per_bfd_storage)
3369         <demangled_names_hash>: Now an htab_up.
3370         * objfiles.c (objfile_per_bfd_storage): Simplify.
3371
3372 2019-03-15  Tom Tromey  <tom@tromey.com>
3373
3374         * objfiles.h (struct objfile_per_bfd_storage): Declare
3375         destructor.
3376         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3377         New.
3378         (get_objfile_bfd_data): Use new.  Don't initialize
3379         language_of_main.
3380         (free_objfile_per_bfd_storage): Remove.
3381         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3382
3383 2019-03-15  Tom Tromey  <tom@tromey.com>
3384
3385         * symfile.c (reread_symbols): Update.
3386         * objfiles.c (objfile::objfile): Update.
3387         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3388         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3389         comment.
3390         (minimal_symbol_reader::install): Update.
3391         (terminate_minimal_symbol_table): Remove.
3392         * jit.c (jit_object_close_impl): Update.
3393
3394 2019-03-15  Tom Tromey  <tom@tromey.com>
3395
3396         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3397         initializations.
3398
3399 2019-03-15  Tom Tromey  <tom@tromey.com>
3400
3401         * objfiles.h (struct objfile_per_bfd_storage)
3402         <demangled_hash_languages>: Now a bitset.
3403         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3404         (lookup_minimal_symbol): Update.
3405
3406 2019-03-15  Tom Tromey  <tom@tromey.com>
3407
3408         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3409         Don't return the symbol.
3410         * coffread.c (record_minimal_symbol): Use record_full.
3411
3412 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3413
3414         The MS-Windows port of ncurses fails to switch to a color pair if
3415         one or both of the colors are the implicit default colors.  This
3416         change records the default colors when TUI is initialized, and
3417         then specifies them explicitly when a color pair uses the default
3418         colors.  This allows color styling in TUI mode on MS-Windows.
3419
3420         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3421         ncurses_norm_attr.
3422         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3423         colors in ncurses_norm_attr.
3424         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3425         "none", replace it with the default color recorded in
3426         ncurses_norm_attr.
3427
3428 2019-03-14  Tom Tromey  <tromey@adacore.com>
3429
3430         * source-cache.h (class source_cache) <get_source_lines>: Return
3431         std::string.
3432         * source-cache.c (source_cache::extract_lines): Handle case where
3433         first_pos==npos.  Return std::string.
3434         (source_cache::get_source_lines): Update.
3435
3436 2019-03-14  Tom Tromey  <tromey@adacore.com>
3437
3438         * NEWS: Add item for "style sources" commands.
3439         * source-cache.c (source_cache::get_source_lines): Check
3440         source_styling.
3441         * cli/cli-style.c (source_styling): New global.
3442         (_initialize_cli_style): Add "style sources" commands.
3443         (show_style_sources): New function.
3444         * cli/cli-style.h (source_styling): Declare.
3445
3446 2019-03-14  Pedro Alves  <palves@redhat.com>
3447             Tom Tromey  <tromey@adacore.com>
3448
3449         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3450         * tui/tui-winsource.c (tui_refill_source_window): New function,
3451         from...
3452         (tui_horizontal_source_scroll): ... here.  Move some logic.
3453         * cli/cli-style.c (set_style_enabled): Notify new observable.
3454         * tui/tui-hooks.c (tui_redisplay_source): New function.
3455         (tui_attach_detach_observers): Attach or detach
3456         tui_redisplay_source.
3457         * observable.h (source_styling_changed): New observable.
3458         * observable.c: Define source_styling_changed observable.
3459
3460 2019-03-13  Tom Tromey  <tromey@adacore.com>
3461
3462         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3463         (i386_gnu_nat_target::store_registers): Update.
3464         * target-debug.h (target_debug_print_std_string): New macro.
3465         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3466         * windows-tdep.c (display_one_tib): Update.
3467         * tui/tui-stack.c (tui_make_status_line): Update.
3468         * top.c (print_inferior_quit_action): Update.
3469         * thread.c (thr_try_catch_cmd): Update.
3470         (add_thread_with_info): Update.
3471         (thread_target_id_str): Update.
3472         (thr_try_catch_cmd): Update.
3473         (thread_command): Update.
3474         (thread_find_command): Update.
3475         * record-btrace.c (record_btrace_target::info_record)
3476         (record_btrace_resume_thread, record_btrace_target::resume)
3477         (record_btrace_cancel_resume, record_btrace_step_thread)
3478         (record_btrace_target::wait, record_btrace_target::wait)
3479         (record_btrace_target::wait, record_btrace_target::stop): Update.
3480         * progspace.c (print_program_space): Update.
3481         * process-stratum-target.c
3482         (process_stratum_target::thread_address_space): Update.
3483         * linux-fork.c (linux_fork_mourn_inferior)
3484         (detach_checkpoint_command, info_checkpoints_command)
3485         (linux_fork_context): Update.
3486         (linux_fork_detach): Update.
3487         (class scoped_switch_fork_info): Update.
3488         (delete_checkpoint_command): Update.
3489         * infrun.c (follow_fork_inferior): Update.
3490         (follow_fork_inferior): Update.
3491         (proceed_after_vfork_done): Update.
3492         (handle_vfork_child_exec_or_exit): Update.
3493         (follow_exec): Update.
3494         (displaced_step_prepare_throw): Update.
3495         (displaced_step_restore): Update.
3496         (start_step_over): Update.
3497         (resume_1): Update.
3498         (clear_proceed_status_thread): Update.
3499         (proceed): Update.
3500         (print_target_wait_results): Update.
3501         (do_target_wait): Update.
3502         (context_switch): Update.
3503         (stop_all_threads): Update.
3504         (restart_threads): Update.
3505         (finish_step_over): Update.
3506         (handle_signal_stop): Update.
3507         (switch_back_to_stepped_thread): Update.
3508         (keep_going_pass_signal): Update.
3509         (print_exited_reason): Update.
3510         (normal_stop): Update.
3511         * inferior.c (inferior_pid_to_str): Change return type.
3512         (print_selected_inferior): Update.
3513         (add_inferior): Update.
3514         (detach_inferior): Update.
3515         * dummy-frame.c (fprint_dummy_frames): Update.
3516         * dcache.c (dcache_info_1): Update.
3517         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3518         (btrace_fetch, btrace_clear): Update.
3519         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3520         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3521         type.
3522         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3523         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3524         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3525         * gdbarch.c, gdbarch.h: Rebuild.
3526         * gdbarch.sh (core_pid_to_str): Change return type.
3527         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3528         return type.
3529         (windows_nat_target::pid_to_str): Change return type.
3530         (windows_delete_thread): Update.
3531         (windows_nat_target::attach): Update.
3532         (windows_nat_target::files_info): Update.
3533         * target-delegates.c: Rebuild.
3534         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3535         return type.
3536         (sol_thread_target::pid_to_str): Change return type.
3537         * remote.c (class remote_target) <pid_to_str>: Change return
3538         type.
3539         (remote_target::pid_to_str): Change return type.
3540         (extended_remote_target::attach, remote_target::remote_stop_ns)
3541         (remote_target::remote_notif_remove_queued_reply)
3542         (remote_target::push_stop_reply, remote_target::disable_btrace):
3543         Update.
3544         (extended_remote_target::attach): Update.
3545         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3546         type.
3547         (gdbsim_target::pid_to_str): Change return type.
3548         * ravenscar-thread.c (struct ravenscar_thread_target)
3549         <pid_to_str>: Change return type.
3550         (ravenscar_thread_target::pid_to_str): Change return type.
3551         * procfs.c (class procfs_target) <pid_to_str>: Change return
3552         type.
3553         (procfs_target::pid_to_str): Change return type.
3554         (procfs_target::attach): Update.
3555         (procfs_target::detach): Update.
3556         (procfs_target::fetch_registers): Update.
3557         (procfs_target::store_registers): Update.
3558         (procfs_target::wait): Update.
3559         (procfs_target::files_info): Update.
3560         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3561         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3562         return type.
3563         (nto_procfs_target::pid_to_str): Change return type.
3564         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3565         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3566         return type.
3567         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3568         (exit_lwp): Update.
3569         (attach_proc_task_lwp_callback, get_detach_signal)
3570         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3571         (linux_nat_target::resume, wait_lwp, stop_callback)
3572         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3573         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3574         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3575         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3576         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3577         type.
3578         (inf_ptrace_target::attach): Update.
3579         (inf_ptrace_target::files_info): Update.
3580         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3581         type.
3582         (go32_nat_target::pid_to_str): Change return type.
3583         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3584         (gnu_nat_target::wait): Update.
3585         (gnu_nat_target::wait): Update.
3586         (gnu_nat_target::resume): Update.
3587         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3588         (fbsd_nat_target::wait): Update.
3589         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3590         type.
3591         (darwin_nat_target::attach): Update.
3592         * corelow.c (class core_target) <pid_to_str>: Change return type.
3593         (core_target::pid_to_str): Change return type.
3594         * target.c (normal_pid_to_str): Change return type.
3595         (default_pid_to_str): Likewise.
3596         (target_pid_to_str): Change return type.
3597         (target_translate_tls_address): Update.
3598         (target_announce_detach): Update.
3599         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3600         return type.
3601         (bsd_uthread_target::pid_to_str): Change return type.
3602         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3603         type.
3604         (bsd_kvm_target::pid_to_str): Change return type.
3605         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3606         return type.
3607         (aix_thread_target::pid_to_str): Change return type.
3608         * target.h (struct target_ops) <pid_to_str>: Change return type.
3609         (target_pid_to_str, normal_pid_to_str): Likewise.
3610         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3611         type.
3612         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3613         type.
3614         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3615         return type.
3616         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3617         type.
3618         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3619         type.
3620         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3621         return type.
3622
3623 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3624
3625         * NEWS: Mention that the new default MI version is 3.  Mention
3626         changes to the output of commands and events that deal with
3627         multi-location breakpoints.
3628         * breakpoint.c: Include "mi/mi-out.h".
3629         (print_one_breakpoint): Change output syntax if using MI version
3630         >= 3.
3631         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3632         New.
3633         (mi_multi_location_breakpoint_output_fixed): New.
3634         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3635         (mi_cmd_fix_multi_location_breakpoint_output): New.
3636         (mi_multi_location_breakpoint_output_fixed): New.
3637         * mi/mi-cmds.c (mi_cmds): Register command
3638         -fix-multi-location-breakpoint-output.
3639         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3640         interpreter "mi".
3641
3642 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3643
3644         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3645         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3646         instantiate mi_ui_out based on interpreter name.
3647         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3648         * mi/mi-main.c (mi_load_progress): Likewise.
3649
3650 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3651
3652         * NEWS: Combine separate "New targets" sections for 8.3.
3653
3654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3655
3656         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3657         (ppcfbsd_init_abi): Install gdbarch
3658         "fetch_tls_load_module_address" and "get_thread_local_address"
3659         methods.
3660
3661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3662
3663         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3664         (riscv_fbsd_init_abi): Install gdbarch
3665         "fetch_tls_load_module_address" and "get_thread_local_address"
3666         methods.
3667
3668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3669
3670         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3671         (i386fbsd_init_abi): Install gdbarch
3672         "fetch_tls_load_module_address" and "get_thread_local_address"
3673         methods.
3674
3675 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3676
3677         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3678         (amd64fbsd_init_abi): Install gdbarch
3679         "fetch_tls_load_module_address" and "get_thread_local_address"
3680         methods.
3681
3682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3683
3684         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3685         (struct fbsd_pspace_data): New type.
3686         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3687         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3688         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3689         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3690         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3691
3692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3693
3694         * gdbtypes.c (lookup_struct_elt): New function.
3695         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3696         * gdbtypes.h (struct struct_elt): New type.
3697         (lookup_struct_elt): New prototype.
3698
3699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3700
3701         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3702         remove disabled code block.
3703
3704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3705
3706         * gdbarch.sh (get_thread_local_address): New method.
3707         * gdbarch.h, gdbarch.c: Regenerate.
3708         * target.c (target_translate_tls_address): Use
3709         gdbarch_get_thread_local_address if present instead of
3710         target::get_thread_local_address.
3711
3712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3713
3714         * target.h (target::get_thread_local_address): Update comment.
3715
3716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3717
3718         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3719         objfile->separate_debug_objfile_backlink if not NULL.
3720
3721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3722
3723         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3724         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3725         (amd64bsd_store_inferior_registers): Likewise.
3726         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3727         Enable segment base registers.
3728         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3729         PT_GETFSBASE and PT_GETGSBASE.
3730         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3731         PT_SETGSBASE.
3732         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3733         segment base registers.
3734         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3735
3736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3737
3738         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3739         Update calls to i386_target_description to add 'segments'
3740         parameter.
3741         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3742         add segment base registers.
3743         * arch/i386.c (i386_create_target_description): Add 'segments'
3744         parameter to enable segment base registers.
3745         * arch/i386.h (i386_create_target_description): Likewise.
3746         * features/i386/32bit-segments.xml: New file.
3747         * features/i386/32bit-segments.c: Generate.
3748         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3749         call to i386_target_description to add 'segments' parameter.
3750         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3751         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3752         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3753         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3754         if feature is present.
3755         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3756         Add 'segments' parameter to call to i386_target_description.
3757         (i386_target_description): Add 'segments' parameter to enable
3758         segment base registers.
3759         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3760         to call to i386_target_description.
3761         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3762         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3763         Define I386_NUM_REGS.
3764         (i386_target_description): Add 'segments' parameter to enable
3765         segment base registers.
3766
3767 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3768
3769         PR/24325
3770         * source-cache.c: #undef open and close, to avoid unresolved
3771         externals during linking.
3772
3773 2019-03-12  Tom Tromey  <tromey@adacore.com>
3774
3775         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3776         const.  Add initializers.
3777         (_initialize_remote): Don't initialize ptid globals.
3778
3779 2019-03-12  Pedro Alves  <palves@redhat.com>
3780
3781         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3782
3783 2019-03-12  Pedro Alves  <palves@redhat.com>
3784
3785         * cp-name-parser.y (main): Remove unused 'len' variable.
3786
3787 2019-03-12  Tom Tromey  <tromey@adacore.com>
3788
3789         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3790         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3791
3792 2019-03-12  Tom Tromey  <tromey@adacore.com>
3793
3794         * linux-nat.c (iterate_over_lwps): Update.
3795         (stop_callback): Remove parameter.
3796         (stop_wait_callback, detach_callback, resume_set_callback)
3797         (select_singlestep_lwp_callback, set_ignore_sigint)
3798         (status_callback, resumed_callback, resume_clear_callback)
3799         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3800         data parameter.
3801         (linux_nat_target::detach, linux_nat_target::resume)
3802         (linux_stop_and_wait_all_lwps, select_event_lwp)
3803         (linux_nat_filter_event, linux_nat_wait_1)
3804         (linux_nat_target::kill, linux_nat_target::stop)
3805         (linux_nat_target::stop): Update.
3806         (linux_nat_resume_callback): Change type.
3807         (resume_stopped_resumed_lwps, count_events_callback)
3808         (select_event_lwp_callback): Likewise.
3809         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3810         * arm-linux-nat.c (struct update_registers_data): Remove.
3811         (update_registers_callback): Change type.
3812         (arm_linux_insert_hw_breakpoint1): Update.
3813         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3814         parameter.
3815         (x86_linux_dr_set_addr): Update.
3816         (x86_linux_dr_set_control): Update.
3817         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3818         (iterate_over_lwps): Use gdb::function_view.
3819         * nat/aarch64-linux-hw-point.c (struct
3820         aarch64_dr_update_callback_param): Remove.
3821         (debug_reg_change_callback): Change type.
3822         (aarch64_notify_debug_reg_change): Update.
3823         * s390-linux-nat.c (s390_refresh_per_info): Update.
3824
3825 2019-03-11  Tom Tromey  <tromey@adacore.com>
3826
3827         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3828         redundant assignment to "this_cu".
3829
3830 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3831
3832         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3833
3834 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3835
3836         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3837         from...
3838         (rank_one_type): ... this.
3839
3840 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3841
3842         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3843         from...
3844         (rank_one_type): ... this.
3845
3846 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3847
3848         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3849         from...
3850         (rank_one_type): ... this.
3851
3852 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3853
3854         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3855         from...
3856         (rank_one_type): ... this.
3857
3858 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3859
3860         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3861         from...
3862         (rank_one_type): ... this.
3863
3864 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3865
3866         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3867         from...
3868         (rank_one_type): ... this.
3869
3870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3871
3872         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3873         from...
3874         (rank_one_type): ... this.
3875
3876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3877
3878         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3879         from...
3880         (rank_one_type): ... this.
3881
3882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3883
3884         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3885         from...
3886         (rank_one_type): ... this.
3887
3888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3889
3890         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3891         from...
3892         (rank_one_type): ... this.
3893
3894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3895
3896         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3897         from...
3898         (rank_one_type): ... this.
3899
3900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3901
3902         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3903         from...
3904         (rank_one_type): ... this.
3905
3906 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3907
3908         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3909         inferior-events' shows the example events.
3910
3911 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3912
3913         Support styling on native MS-Windows console
3914
3915         PR/24315
3916         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3917         on MS-Windows if $TERM is not defined.
3918
3919         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3920
3921         * posix-hdep.c (gdb_console_fputs):
3922         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3923         functions.
3924         * ui-file.h (gdb_console_fputs): Add prototype.
3925
3926         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3927         back to fputs only if the former returns zero.
3928
3929 2019-03-07  Tom Tromey  <tom@tromey.com>
3930
3931         * symmisc.c (print_symbol_bcache_statistics): Update.
3932         (print_objfile_statistics): Update.
3933         * symfile.c (allocate_symtab): Update.
3934         * stabsread.c: Don't include bcache.h.
3935         * psymtab.h (struct psymbol_bcache): Don't declare.
3936         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3937         (psymbol_bcache_init, psymbol_bcache_free)
3938         (psymbol_bcache_get_bcache): Don't declare.
3939         * psymtab.c (struct psymbol_bcache): Remove.
3940         (psymtab_storage::psymtab_storage): Update.
3941         (psymtab_storage::~psymtab_storage): Update.
3942         (psymbol_bcache_init, psymbol_bcache_free)
3943         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3944         (add_psymbol_to_bcache): Update.
3945         (allocate_psymtab): Update.
3946         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3947         macro_cache>: No longer pointers.
3948         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3949         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3950         * macrotab.c (macro_bcache): Update.
3951         * macroexp.c: Don't include bcache.h.
3952         * gdbtypes.c (check_types_worklist): Update.
3953         (types_deeply_equal): Remove TRY/CATCH.  Update.
3954         * elfread.c (elf_symtab_read): Update.
3955         * dwarf2read.c: Don't include bcache.h.
3956         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3957         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3958         (print_bcache_statistics, bcache_memory_used): Don't declare.
3959         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3960         methods.  Rename all data members.
3961         * bcache.c (struct bcache): Move to bcache.h.
3962         (bcache::expand_hash_table): Rename from expand_hash_table.
3963         (bcache): Remove.
3964         (bcache::insert): Rename from bcache_full.
3965         (bcache::compare): Rename from bcache_compare.
3966         (bcache_xmalloc): Remove.
3967         (bcache::~bcache): Rename from bcache_xfree.
3968         (bcache::print_statistics): Rename from print_bcache_statistics.
3969         (bcache::memory_used): Rename from bcache_memory_used.
3970
3971 2019-03-07  Pedro Alves  <palves@redhat.com>
3972
3973         * infrun.c (normal_stop): Also check for
3974         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3975
3976 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3977
3978         * f-lang.c (value_from_host_double): Moved to...
3979         * value.c (value_from_host_double): ...here.
3980         * value.h (value_from_host_double): Declare.
3981         * guile/scm-math.c (vlscm_convert_typed_number): Use
3982         value_from_host_double.
3983         (vlscm_convert_number): Likewise.
3984         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3985         * python/py-value.c (convert_value_from_python): Likewise.
3986
3987 2019-03-06  Tom Tromey  <tom@tromey.com>
3988
3989         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3990
3991 2019-03-06  Tom Tromey  <tom@tromey.com>
3992
3993         * utils.h (free_current_contents): Don't declare.
3994         * utils.c (free_current_contents): Remove.
3995
3996 2019-03-06  Tom Tromey  <tom@tromey.com>
3997
3998         * top.c (quit_force): Update.
3999         * main.c (captured_command_loop): Update.
4000         * common/new-op.c (operator new): Update.
4001         * common/common-exceptions.c (struct catcher)
4002         <save_cleanup_chain>: Remove member.
4003         (exceptions_state_mc_init): Update.
4004         (exception_try_scope_entry): Return nullptr.
4005         (exception_try_scope_exit, exception_rethrow)
4006         (throw_exception_sjlj, throw_exception_cxx): Update.
4007         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4008         (all_cleanups, do_cleanups, discard_cleanups)
4009         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4010         (restore_cleanups, restore_final_cleanups): Don't declare.
4011         (do_final_cleanups): Remove parameter.
4012         * common/cleanups.c (cleanup_chain, make_cleanup)
4013         (make_cleanup_dtor, all_cleanups, do_cleanups)
4014         (discard_my_cleanups, discard_cleanups)
4015         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4016         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4017         (null_cleanup): Remove.
4018         (do_final_cleanups): Remove parameter.
4019
4020 2019-03-06  Tom Tromey  <tom@tromey.com>
4021
4022         * remote.c (remote_target::remote_parse_stop_reply): Use
4023         unique_xmalloc_ptr.
4024
4025 2019-03-06  Tom Tromey  <tom@tromey.com>
4026
4027         * stabsread.c (struct stabs_field_info): Rename from field_info.
4028         <list, fnlist>: Add initializers.
4029         <obstack>: New member.
4030         (read_member_functions, read_struct_fields, read_baseclasses):
4031         Allocate on obstack.  Don't use cleanups.
4032         (read_one_struct_field, read_member_functions, read_struct_fields)
4033         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4034         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4035         (read_struct_type): Update.
4036
4037 2019-03-06  Tom Tromey  <tom@tromey.com>
4038
4039         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4040         * common/filestuff.h (make_cleanup_close): Don't declare.
4041         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4042         Remove.
4043
4044 2019-03-06  Tom Tromey  <tom@tromey.com>
4045
4046         * solib-aix.c: Use make_scope_exit.
4047
4048 2019-03-06  Tom Tromey  <tom@tromey.com>
4049
4050         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4051         Use make_scope_exit.
4052
4053 2019-03-06  Tom Tromey  <tom@tromey.com>
4054
4055         * solib-svr4.c (disable_probes_interface): Remove parameter.
4056         (svr4_handle_solib_event): Use make_scope_exit.
4057
4058 2019-03-06  Tom Tromey  <tom@tromey.com>
4059
4060         * remote.c (struct stop_reply_deleter): Remove.
4061         (stop_reply_up): Update.
4062         (struct stop_reply): Derive from notif_event.  Don't typedef.
4063         <regcache>: Now a std::vector.
4064         (stop_reply_xfree): Remove.
4065         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4066         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4067         (remote_target::discard_pending_stop_replies): Use delete.
4068         (remote_target::remote_parse_stop_reply): Update.
4069         (remote_target::process_stop_reply): Update.
4070         * remote-notif.h (struct notif_event): Add virtual destructor.
4071         Remove "dtr" member.
4072         (struct notif_client) <alloc_event>: Return a unique_ptr.
4073         (notif_event_xfree): Don't declare.
4074         (notif_event_up): New typedef.
4075         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4076         (notif_event_xfree, do_notif_event_xfree): Remove.
4077         (remote_notif_state_xfree): Update.
4078
4079 2019-03-06  Tom Tromey  <tom@tromey.com>
4080
4081         * infrun.c (displaced_step_clear_cleanup): Now a
4082         forward_scope_exit type.
4083         (displaced_step_prepare_throw): Update.
4084         (displaced_step_fixup): Update.
4085
4086 2019-03-06  Tom Tromey  <tom@tromey.com>
4087
4088         * inferior.h (class inferior): Update comment.
4089         * gdbthread.h (class thread_info): Update comment.
4090
4091 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4092             Tom Tromey  <tom@tromey.com>
4093
4094         * stabsread.h (struct stab_section_list): Remove.
4095         (coffstab_build_psymtabs): Update.
4096         * dbxread.c (symbuf_sections): Now a std::vector.
4097         (sect_idx): New global.
4098         (fill_symbuf): Update.
4099         (coffstab_build_psymtabs): Change type of stabsects parameter.
4100         Update.
4101         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4102         std::vector.
4103         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4104         (coff_locate_sections): Update.
4105         (coff_symfile_read): Remove cleanups.  Update.
4106         (init_stringtab): Add storage parameter.
4107         (free_stringtab, free_stringtab_cleanup): Remove.
4108         (init_lineno): Add storage parameter.
4109         (free_linetab, free_linetab_cleanup): Remove.
4110
4111 2019-03-06  Pedro Alves  <palves@redhat.com>
4112
4113         * linux-fork.c (fork_info::clobber_regs): Delete.
4114         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4115         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4116         comment.  Adjust.
4117         (scoped_switch_fork_info::scoped_switch_fork_info)
4118         (checkpoint_command, linux_fork_context): Adjust
4119         fork_save_infrun_state calls.
4120
4121 2019-03-06  Pedro Alves  <palves@redhat.com>
4122
4123         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4124         (inf_has_multiple_threads): Return 'bool' and rewrite using
4125         inferior_info::threads().
4126
4127 2019-03-06  Pedro Alves  <palves@redhat.com>
4128
4129         * linux-fork.c: Include <list>.
4130         (fork_list): Now a std::list instance.
4131         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4132         (forks_exist_p, find_last_fork): Adjust.
4133         (new_fork): Delete.
4134         (one_fork_p): New.
4135         (add_fork): Adjust.
4136         (free_fork): Delete, folded into fork_info::~fork_info().
4137         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4138         Adjust.
4139         (init_fork_list): Delete.
4140         (linux_fork_killall, linux_fork_mourn_inferior)
4141         (linux_fork_detach, info_checkpoints_command): Adjust.
4142         (_initialize_linux_fork): No longer call init_fork_list.
4143
4144 2019-03-06  Pedro Alves  <palves@redhat.com>
4145
4146         * linux-fork.c (new_fork): New, split out of ...
4147         (add_fork): ... this.  Return void.  Move "first fork" special
4148         case from here, to ...
4149         (checkpoint_command): ... here.
4150         * linux-linux.h (add_fork): Return void.
4151
4152 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4155
4156 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4157             Chris January  <chris.january@arm.com>
4158             David Lecomber  <david.lecomber@arm.com>
4159
4160         * f-exp.y: New token, UNOP_INTRINSIC.
4161         (exp): New pattern using UNOP_INTRINSIC token.
4162         (f77_keywords): Add 'abs' keyword.
4163         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4164         (value_from_host_double): New function.
4165         (evaluate_subexp_f): Support UNOP_ABS.
4166
4167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4170         types.
4171
4172 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4175         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4176         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4177
4178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4179
4180         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4181
4182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4183             Chris January  <chris.january@arm.com>
4184
4185         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4186         * f-exp.y: Define 'KIND' token.
4187         (exp): New pattern for KIND expressions.
4188         (ptype): Handle types with a kind extension.
4189         (direct_abs_decl): Extend to spot kind extensions.
4190         (f77_keywords): Add 'kind' to the list.
4191         (push_kind_type): New function.
4192         (convert_to_kind_type): New function.
4193         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4194         * parse.c (operator_length_standard): Likewise.
4195         * parser-defs.h (enum type_pieces): Add tp_kind.
4196         * std-operator.def: Add UNOP_KIND.
4197
4198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * f-exp.y (f_parse): Set yydebug.
4201
4202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * f-lang.c (evaluate_subexp_f): New function.
4205         (exp_descriptor_f): New global.
4206         (f_language_defn): Use exp_descriptor_f instead of
4207         exp_descriptor_standard.
4208
4209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * f-exp.y (struct token): Add comments.
4212         (dot_ops): Remove uppercase versions and the end marker.
4213         (f77_keywords): Likewise.
4214         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4215         entries in the dot_ops array are case insensitive, and use
4216         strncasecmp to compare strings.  Also some whitespace cleanup in
4217         this area.  Similar for the f77_keywords array, except entries in
4218         this list might be case sensitive.
4219
4220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * f-exp.y (struct f77_boolean_val): Add comments.
4223         (boolean_values): Remove uppercase versions, and end marker.
4224         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4225         and use strncasecmp to achieve case insensitivity.  Additionally,
4226         perform whitespace cleanup around this code.
4227
4228 2019-03-06  Tom Tromey  <tromey@adacore.com>
4229
4230         * remote-sim.c (gdbsim_target_open): Use result of
4231         gdb_argv::release.
4232
4233 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4234         Dirk Schubert  <dirk.schubert@arm.com>
4235         Chris January  <chris.january@arm.com>
4236
4237         * eval.c (evaluate_subexp_standard): Call Fortran argument
4238         wrapping logic.
4239         * f-lang.c (struct value): A value which can be passed into a
4240         Fortran function call.
4241         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4242         where appropriate.
4243         (struct type): Value ready for a Fortran function call.
4244         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4245         is needed.
4246         * f-lang.h (fortran_argument_convert): Declaration.
4247         (fortran_preserve_arg_pointer): Declaration.
4248         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4249
4250 2019-03-05  Tom Tromey  <tromey@adacore.com>
4251
4252         * python/py-prettyprint.c (print_string_repr): Remove #if.
4253         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4254
4255 2019-03-05  Tom Tromey  <tromey@adacore.com>
4256
4257         * target.c (the_dummy_target): Move later.  Change type to
4258         "dummy_target".
4259         (initialize_targets): Don't initialize the_dummy_target.
4260
4261 2019-03-05  Tom Tromey  <tromey@adacore.com>
4262
4263         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4264         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4265
4266 2019-03-05  Tom Tromey  <tromey@adacore.com>
4267
4268         * windows-nat.c (windows_nat_target::attach)
4269         (windows_nat_target::detach): Don't call gdb_flush.
4270         * valprint.c (generic_val_print, val_print, val_print_string):
4271         Don't call gdb_flush.
4272         * utils.c (defaulted_query): Don't call gdb_flush.
4273         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4274         * target.c (target_announce_detach): Don't call gdb_flush.
4275         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4276         * remote.c (extended_remote_target::attach): Don't call
4277         gdb_flush.
4278         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4279         * printcmd.c (do_examine): Don't call gdb_flush.
4280         (info_display_command): Don't call gdb_flush.
4281         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4282         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4283         * memattr.c (info_mem_command): Don't call gdb_flush.
4284         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4285         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4286         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4287         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4288         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4289         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4290         (gnu_nat_target::detach): Don't call gdb_flush.
4291         * f-valprint.c (f_val_print): Don't call gdb_flush.
4292         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4293         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4294         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4295         gdb_flush.
4296         * c-valprint.c (c_val_print): Don't call gdb_flush.
4297         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4298
4299 2019-03-05  Tom Tromey  <tromey@adacore.com>
4300
4301         * varobj.c (update_dynamic_varobj_children): Update.
4302         (install_default_visualizer): Use reset, not release.
4303         * value.c (set_internalvar): Update.
4304         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4305         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4306         ATTRIBUTE_UNUSED_RESULT.
4307
4308 2019-03-05  Tom Tromey  <tromey@adacore.com>
4309
4310         * remote.c (class scoped_remote_fd) <release>: Add
4311         ATTRIBUTE_UNUSED_RESULT.
4312
4313 2019-03-05  Tom Tromey  <tromey@adacore.com>
4314
4315         * macroexp.c (struct macro_buffer) <release>: Add
4316         ATTRIBUTE_UNUSED_RESULT.
4317
4318 2019-03-05  Tom Tromey  <tromey@adacore.com>
4319
4320         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4321         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4322         ATTRIBUTE_UNUSED_RESULT.
4323
4324 2019-03-05  Tom Tromey  <tromey@adacore.com>
4325
4326         * common/scoped_fd.h (class scoped_fd) <release>: Add
4327         ATTRIBUTE_UNUSED_RESULT.
4328
4329 2019-03-05  Tom Tromey  <tromey@adacore.com>
4330
4331         * parser-defs.h (struct parser_state) <release>: Add
4332         ATTRIBUTE_UNUSED_RESULT.
4333
4334 2019-03-05  Tom Tromey  <tromey@adacore.com>
4335
4336         * utils.h (class gdb_argv) <release>: Add
4337         ATTRIBUTE_UNUSED_RESULT.
4338         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4339
4340 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4341
4342         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4343         for-loop range, to avoid compiler warnings.
4344
4345         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4346         avoid compiler warnings about unused variables.
4347
4348         * NEWS: Mention end of support for native debugging on MS-Windows
4349         before XP.
4350
4351         PR gdb/24292
4352         * common/netstuff.c:
4353         * gdbserver/gdbreplay.c
4354         * gdbserver/remote-utils.c:
4355         * ser-tcp.c:
4356         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4357         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4358         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4359         'getaddrinfo' and 'freeaddrinfo' were not available before
4360         Windows XP, and mingw.org's MinGW headers by default define
4361         _WIN32_WINNT to 0x500.
4362
4363 2019-03-01  Gary Benson <gbenson@redhat.com>
4364
4365         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4366
4367 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4368             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4369
4370         PR gdb/8527
4371         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4372         set_sigint_trap, clear_sigint_trap.
4373
4374 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4375
4376         * target.c (target_detach): Clear the regcache and the
4377         frame cache.
4378
4379 2019-02-27  Pedro Alves  <palves@redhat.com>
4380
4381         * utils.c (set_screen_size): When we cap the height/width sizes,
4382         tweak the corresponding command variable to show "unlimited":
4383
4384 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4385             Pedro Alves  <palves@redhat.com>
4386
4387         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4388         before calling rl_set_screen_size.
4389
4390 2019-02-27  Tom Tromey  <tromey@adacore.com>
4391
4392         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4393         define.
4394         * python/py-value.c: Remove Python 2.4 workaround.
4395         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4396         workaround.
4397         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4398         Python 2.4 workaround.
4399         * python/python-internal.h: Remove Python 2.4 comment.
4400         (Py_ssize_t): Don't define.
4401         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4402         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4403         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4404         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4405         * python/python.c (do_start_initialization): Remove Python 2.4
4406         workaround.
4407         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4408         (print_children): Remove Python 2.4 workaround.
4409         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4410         workaround.
4411         (CHARBUFFERPROC_NAME): Remove.
4412         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4413         Python 2.4 workaround.
4414
4415 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4416
4417         * NEWS: Note minimum Python version.
4418
4419 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4420
4421         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4422         code from these functions.  Remove corresponding ifdefs.  Use
4423         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4424         Remove gotos and target of gotos.
4425         (infpy_search_memory): Likewise.
4426
4427 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4430         (hppa_gdbarch_init): Don't register deleted functions with
4431         gdbarch.
4432
4433 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4436         (h8300_unwind_sp): Delete.
4437         (h8300_dummy_id): Delete.
4438         (h8300_gdbarch_init): Don't register deleted functions with
4439         gdbarch.
4440
4441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4444         (ft32_unwind_pc): Delete.
4445         (ft32_unwind_sp): Delete.
4446         (ft32_gdbarch_init): Don't register deleted functions with
4447         gdbarch.
4448
4449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4450
4451         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4452         (frv_unwind_pc): Delete.
4453         (frv_unwind_sp): Delete.
4454         (frv_gdbarch_init): Don't register deleted functions with
4455         gdbarch.
4456
4457 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4458
4459         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4460         (riscv_unwind_pc): Delete.
4461         (riscv_unwind_sp): Delete.
4462         (riscv_gdbarch_init): Don't register deleted functions with
4463         gdbarch.
4464
4465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4466
4467         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4468         (csky_unwind_pc): Delete.
4469         (csky_unwind_sp): Delete.
4470         (csky_gdbarch_init): Don't register deleted functions with
4471         gdbarch.
4472
4473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4476         (cris_unwind_pc): Delete.
4477         (cris_unwind_sp): Delete.
4478         (cris_gdbarch_init): Don't register deleted functions with
4479         gdbarch.
4480
4481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4484         (bfin_unwind_pc): Delete.
4485         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4486
4487 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4488
4489         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4490         (arm_unwind_pc): Delete.
4491         (arm_unwind_sp): Delete.
4492         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4493
4494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4497         (arc_unwind_pc): Delete.
4498         (arc_unwind_sp): Delete.
4499         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4500
4501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4504         (alpha_unwind_pc): Delete.
4505         (alpha_gdbarch_init): Don't register deleted functions with
4506         gdbarch.
4507
4508 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4511         (aarch64_unwind_pc): Delete.
4512         (aarch64_unwind_sp): Delete.
4513         (aarch64_gdbarch_init): Don't register deleted functions with
4514         gdbarch.
4515
4516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * gdbtypes.c (type_align): Don't consider static members when
4519         computing structure alignment.
4520
4521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4524         return 0 for other types.
4525         * arch-utils.c (default_type_align): Always return 0.
4526         * gdbarch.h: Regenerate.
4527         * gdbarch.sh (type_align): Extend comment.
4528         * gdbtypes.c (type_align): Add additional comments, always call
4529         gdbarch_type_align before applying the default rules.
4530         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4531         generic code will then apply a suitable default.
4532         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4533         types, return 0 for other types.
4534
4535 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4536
4537         * NEWS: Create a new section for the next release branch.
4538         Rename the section of the current branch, now that it has
4539         been cut.
4540
4541 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4542
4543         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4544         * version.in: Bump version to 8.3.50.DATE-git.
4545
4546 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4547
4548         * aix-thread.c (ptid_cmp): Remove unused variable.
4549         (get_signaled_thread): Likewise.
4550         (store_regs_user_thread): Likewise.
4551         (store_regs_kernel_thread): Likewise.
4552         (fetch_regs_kernel_thread): Remove shadowed variable.
4553
4554 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * features/riscv/32bit-cpu.xml: Add register numbers.
4557         * features/riscv/32bit-fpu.c: Regenerate.
4558         * features/riscv/32bit-fpu.xml: Add register numbers.
4559         * features/riscv/64bit-cpu.xml: Add register numbers.
4560         * features/riscv/64bit-fpu.c: Regenerate.
4561         * features/riscv/64bit-fpu.xml: Add register numbers.
4562
4563 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4564
4565         * NEWS: Mention two argument form of gdb.Value constructor.
4566         * python/py-value.c (convert_buffer_and_type_to_value): New
4567         function.
4568         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4569         Add support for handling an optional second argument.  Call
4570         convert_buffer_and_type_to_value as appropriate.
4571         * python/python-internal.h (Py_buffer_deleter): New struct.
4572         (Py_buffer_up): New typedef.
4573
4574 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4575
4576         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4577         instead of releasing ownership.
4578
4579 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4580
4581         * dwarf2read.c (open_and_init_dwp_file): Call
4582         elf_numsections instead of bfd_count_sections to initialize
4583         dwp_file->num_sections.
4584
4585 2019-02-25  Tom Tromey  <tromey@adacore.com>
4586
4587         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4588
4589 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4590
4591         * gcore.in: Add '--readnever' option when invoking GDB.
4592
4593 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4594
4595         * MAINTAINERS: Update my email address.
4596
4597 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4598
4599         * build-id.c (build_id_to_debug_bfd_1): New function.
4600         (build_id_to_debug_bfd): Look for separate debug file in
4601         sysroot.
4602
4603 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * gdbarch.sh: Update the copyright year range that is placed into
4606         generated files.
4607
4608 2019-02-22  Keith Seitz  <keiths@redhat.com>
4609
4610         PR symtab/23853
4611         * linespec.c (create_sals_line_offset): Search for the default
4612         symtab's filename instead of its fullname.
4613
4614 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4615
4616         * NEWS: Update style defaults.
4617
4618 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4619
4620         * main.c (captured_main_1): Disable styling in batch mode.
4621
4622 2019-02-20  Tom Tromey  <tom@tromey.com>
4623
4624         * symtab.c (symtab_symbol_info): Fix typos.
4625
4626 2019-02-20  Tom Tromey  <tromey@adacore.com>
4627
4628         * findcmd.c (_initialize_mem_search): Use upper case for
4629         metasyntactic variables.
4630
4631 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4632
4633         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4634         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4635
4636 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4637
4638         * top.h (source_file_name): Change to std::string.
4639         * top.c (source_file_name): Likewise.
4640         (command_line_input): Adjust.
4641         * cli/cli-script.c (script_from_file): Adjust.
4642
4643 2019-02-19  Tom Tromey  <tromey@adacore.com>
4644
4645         * ravenscar-thread.c
4646         (ravenscar_thread_target::update_thread_list): Don't call
4647         ada_build_task_list.
4648         * ada-lang.h (ada_build_task_list): Don't declare.
4649         * ada-tasks.c (struct ada_tasks_inferior_data)
4650         <task_list_valid_p>: Now bool.
4651         (read_known_tasks, ada_task_list_changed)
4652         (ada_tasks_invalidate_inferior_data): Update.
4653         (read_known_tasks_array): Return bool.
4654         (read_known_tasks_list): Likewise.
4655         (read_known_tasks): Return void.
4656         (ada_build_task_list): Now static.
4657
4658 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4661         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4662
4663 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4664
4665         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4666         variant for ada_tasks_pspace_data_handle and
4667         ada_tasks_inferior_data_handle.
4668         (ada_tasks_pspace_data_cleanup): New function.
4669         (ada_tasks_inferior_data_cleanup): New function.
4670
4671 2019-02-17  Tom Tromey  <tom@tromey.com>
4672
4673         * macrotab.h (macro_source_fullname): Return a std::string.
4674         * macrotab.c (macro_include, check_for_redefinition)
4675         (macro_undef, macro_lookup_definition, foreach_macro)
4676         (foreach_macro_in_scope): Update.
4677         (macro_source_fullname): Return a std::string.
4678         * macrocmd.c (show_pp_source_pos): Update.
4679
4680 2019-02-17  Tom Tromey  <tom@tromey.com>
4681
4682         * macrocmd.c (show_pp_source_pos): Style the file names.
4683
4684 2019-02-17  Tom Tromey  <tom@tromey.com>
4685
4686         PR tui/24197:
4687         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4688
4689 2019-02-17  Tom Tromey  <tom@tromey.com>
4690
4691         * ada-lang.c (user_select_syms): Use filtered printing.
4692         * utils.c (wrap_style): New global.
4693         (desired_style): Remove.
4694         (emit_style_escape): Add stream parameter.
4695         (set_output_style, reset_terminal_style, prompt_for_continue):
4696         Update.
4697         (flush_wrap_buffer): Only flush gdb_stdout.
4698         (wrap_here): Set wrap_style.
4699         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4700         treat escape sequences as a character.  Change when wrap buffer is
4701         flushed.
4702         (fputs_styled): Do not set the output style when the default is
4703         requested.
4704         * ui-style.h (struct ui_file_style) <is_default>: New method.
4705         * source.c (print_source_lines_base): Emit escape sequences in one
4706         piece.
4707
4708 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4709
4710         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4711         integers and enumeration types.
4712
4713 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4714
4715         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4716         instead of lookup_symbol_in_language
4717         (do_exact_match): New function.
4718         (ada_get_symbol_name_matcher): Return do_exact_match when
4719         doing a verbatim match.
4720
4721 2019-02-15  Tom Tromey  <tromey@adacore.com>
4722
4723         * ravenscar-thread.c (ravenscar_thread_target::resume)
4724         (ravenscar_thread_target::wait): Special case wildcard requests.
4725
4726 2019-02-15  Tom Tromey  <tromey@adacore.com>
4727
4728         * ravenscar-thread.c (base_ptid): Remove.
4729         (struct ravenscar_thread_target) <close>: New method.
4730         <m_base_ptid>: New member.
4731         <update_inferior_ptid, active_task, task_is_currently_active,
4732         runtime_initialized>: Declare methods.
4733         <ravenscar_thread_target>: Add constructor.
4734         (ravenscar_thread_target::task_is_currently_active)
4735         (ravenscar_thread_target::update_inferior_ptid)
4736         (ravenscar_runtime_initialized): Rename.  Now methods.
4737         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4738         (ravenscar_thread_target::update_thread_list): Update.
4739         (ravenscar_thread_target::active_task): Now method.
4740         (ravenscar_thread_target::store_registers)
4741         (ravenscar_thread_target::prepare_to_store)
4742         (ravenscar_thread_target::prepare_to_store)
4743         (ravenscar_thread_target::mourn_inferior): Update.
4744         (ravenscar_inferior_created): Use "new" to create target.
4745         (ravenscar_thread_target::get_ada_task_ptid): Update.
4746         (_initialize_ravenscar): Don't initialize base_ptid.
4747         (ravenscar_ops): Remove global.
4748
4749 2019-02-15  Tom Tromey  <tromey@adacore.com>
4750
4751         * target.h (push_target): Declare new overload.
4752         * target.c (push_target): New overload, taking an rvalue reference.
4753         * remote.c (remote_target::open_1): Use push_target overload.
4754         * corelow.c (core_target_open): Use push_target overload.
4755
4756 2019-02-15  Tom Tromey  <tromey@adacore.com>
4757
4758         * ravenscar-thread.c (is_ravenscar_task)
4759         (ravenscar_task_is_currently_active): Return bool.
4760         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4761         (_initialize_ravenscar): Remove "(void)".
4762         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4763         Return bool.
4764
4765 2019-02-15  Tom Tromey  <tromey@adacore.com>
4766
4767         * ravenscar-thread.c (ravenscar_runtime_initializer)
4768         (has_ravenscar_runtime, get_running_thread_id)
4769         (ravenscar_thread_target::resume): Fix indentation.
4770
4771 2019-02-15  Tom Tromey  <tromey@adacore.com>
4772
4773         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4774         from ravenscar_arch_ops.
4775         (sparc_ravenscar_ops::fetch_registers)
4776         (sparc_ravenscar_ops::store_registers): Now methods.
4777         (sparc_ravenscar_prepare_to_store): Remove.
4778         (sparc_ravenscar_ops): Redefine.
4779         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4780         methods and destructor.  Remove members.
4781         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4782         (ravenscar_thread_target::store_registers)
4783         (ravenscar_thread_target::prepare_to_store): Update.
4784         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4785         Remove.
4786         (struct ppc_ravenscar_powerpc_ops): Derive from
4787         ravenscar_arch_ops.
4788         (ppc_ravenscar_powerpc_ops::fetch_registers)
4789         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4790         (ppc_ravenscar_powerpc_ops): Redefine.
4791         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4792         (ppc_ravenscar_e500_ops::fetch_registers)
4793         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4794         (ppc_ravenscar_e500_ops): Redefine.
4795         * aarch64-ravenscar-thread.c
4796         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4797         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4798         (aarch64_ravenscar_fetch_registers)
4799         (aarch64_ravenscar_store_registers): Now methods.
4800         (aarch64_ravenscar_ops): Redefine.
4801
4802 2019-02-15  Tom Tromey  <tromey@adacore.com>
4803
4804         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4805         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4806         (ravenscar_thread_target::stopped_by_watchpoint)
4807         (ravenscar_thread_target::stopped_data_address)
4808         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4809
4810 2019-02-15  Tom Tromey  <tromey@adacore.com>
4811
4812         * ravenscar-thread.c: Fix some typos.
4813
4814 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4815             Tom Tromey  <tromey@adacore.com>
4816
4817         * ada-lang.c (ada_exception_sal): Change addr_string to a
4818         std::string.
4819         (create_ada_exception_catchpoint): Update.
4820
4821 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4822             Tom Tromey  <tromey@adacore.com>
4823
4824         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4825         (bp_location_ops): Remove.
4826         (base_breakpoint_allocate_location): Update.
4827         (free_bp_location): Update.
4828         * ada-lang.c (class ada_catchpoint_location)
4829         <ada_catchpoint_location>: Remove ops parameter.
4830         (ada_catchpoint_location_dtor): Remove.
4831         (ada_catchpoint_location_ops): Remove.
4832         (allocate_location_exception): Update.
4833         * breakpoint.h (struct bp_location_ops): Remove.
4834         (class bp_location) <bp_location>: Remove bp_location_ops
4835         parameter.
4836         <~bp_location>: Add destructor.
4837         <ops>: Remove.
4838
4839 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4840             Pedro Alves  <palves@redhat.com>
4841
4842         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4843         'PATH_MAX'.
4844
4845 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4846             Samuel Thibault  <samuel.thibault@gnu.org>
4847             Thomas Schwinge  <thomas@codesourcery.com>
4848
4849         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4850         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4851
4852 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4853
4854         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4855         (check_empty): Use "const char *".
4856
4857         * gnu-nat.c (gnu_nat_target::detach): Instead of
4858         'detach_inferior (pid)' call
4859         'detach_inferior (find_inferior_pid (pid))'.
4860
4861         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4862         'nat/fork-inferior.o'.
4863         * gnu-nat.c: #include "nat/fork-inferior.h".
4864
4865         * gnu-nat.c (gnu_nat_target::detach): Instead of
4866         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4867         * gnu-nat.h: #include "inf-child.h".
4868         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4869         'i386_gnu_nat_target::fetch_registers'.
4870         (gnu_store_registers): Rename/move to
4871         'i386_gnu_nat_target::store_registers'.
4872
4873         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4874         * gnu-nat.h (mach_thread_info): New function.
4875         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4876
4877         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4878
4879 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4880
4881         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4882
4883 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4884
4885         * windows-nat.c (windows_add_thread): Add new parameter
4886         "main_thread_p" with default value set to false.  Update
4887         function documentation as well as all callers.
4888         (windows_delete_thread): Likewise.
4889         (fake_create_process): Update call to windows_add_thread.
4890         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4891         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4892         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4893         call to windows_delete_thread.
4894
4895 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4896
4897         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4898
4899 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4900
4901         * symfile.c (find_separate_debug_file): Use canonical path of
4902         sysroot with child_path instead of gdb_sysroot if it is valid.
4903
4904 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4905
4906         * symfile.c (find_separate_debug_file): Use child_path to
4907         determine if an object file is under a sysroot.
4908
4909 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4910
4911         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4912         unittests/child-path-selftests.c.
4913         * common/pathstuff.c (child_path): New function.
4914         * common/pathstuff.h (child_path): New prototype.
4915         * unittests/child-path-selftests.c: New file.
4916
4917 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4918
4919         * symfile.c (find_separate_debug_file): Look for separate debug
4920         files in debug directories under the sysroot.
4921
4922 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4923
4924         * symtab.h (struct minimal_symbol data_p): New const method.
4925         (struct minimal_symbol text_p): Likewise.
4926         * symtab.c (output_source_filename): Use file name style
4927         to print file name.
4928         (print_symbol_info): Likewise.
4929         (print_msymbol_info): Use address style to print addresses.
4930         Use function name style to print executable text symbols.
4931         (expand_symtab_containing_pc): Use data_p.
4932         (find_pc_sect_compunit_symtab): Likewise.
4933
4934 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4935
4936         * breakpoint.c (describe_other_breakpoints): Use address style
4937         to print addresses.
4938         (say_where): Likewise.
4939
4940 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4941
4942         * ada-typeprint.c (print_func_type): Print function name
4943         style to print function name.
4944         * c-typeprint.c (c_print_type_1): Likewise.
4945
4946 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4947
4948         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4949         for execve.
4950
4951 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4952
4953         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4954         type_stack.
4955
4956 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4957
4958         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4959         TYPE_CODE_REF types.
4960
4961 2019-02-08  Jim Wilson  <jimw@sifive.com>
4962
4963         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4964         (riscv_linux_fregset): New.
4965         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4966
4967 2019-02-07  Tom Tromey  <tom@tromey.com>
4968
4969         * thread.c (thread_cancel_execution_command): Update.
4970         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4971         methods.
4972         (struct thread_fsm_ops): Remove.
4973         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4974         (thread_fsm_should_stop, thread_fsm_return_value)
4975         (thread_fsm_set_finished, thread_fsm_finished_p)
4976         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4977         Don't declare.
4978         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4979         * infrun.c (clear_proceed_status_thread)
4980         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4981         (print_stop_event): Update.
4982         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4983         Add constructor.
4984         (step_command_fsm_ops): Remove.
4985         (new_step_command_fsm): Remove.
4986         (step_1): Update.
4987         (step_command_fsm::should_stop): Rename from
4988         step_command_fsm_should_stop.
4989         (step_command_fsm::clean_up): Rename from
4990         step_command_fsm_clean_up.
4991         (step_command_fsm::do_async_reply_reason): Rename from
4992         step_command_fsm_async_reply_reason.
4993         (struct until_next_fsm): Inherit from thread_fsm.  Add
4994         constructor.
4995         (until_next_fsm_ops): Remove.
4996         (new_until_next_fsm): Remove.
4997         (until_next_fsm::should_stop): Rename from
4998         until_next_fsm_should_stop.
4999         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5000         (until_next_fsm::do_async_reply_reason): Rename from
5001         until_next_fsm_async_reply_reason.
5002         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5003         constructor.  Change type of breakpoint.
5004         (finish_command_fsm_ops): Remove.
5005         (new_finish_command_fsm): Remove.
5006         (finish_command_fsm::should_stop): Rename from
5007         finish_command_fsm_should_stop.
5008         (finish_command_fsm::clean_up): Rename from
5009         finish_command_fsm_clean_up.
5010         (finish_command_fsm::return_value): Rename from
5011         finish_command_fsm_return_value.
5012         (finish_command_fsm::do_async_reply_reason): Rename from
5013         finish_command_fsm_async_reply_reason.
5014         (finish_command): Update.
5015         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5016         Add constructor.
5017         (call_thread_fsm_ops): Remove.
5018         (call_thread_fsm::call_thread_fsm): Rename from
5019         new_call_thread_fsm.
5020         (call_thread_fsm::should_stop): Rename from
5021         call_thread_fsm_should_stop.
5022         (call_thread_fsm::should_notify_stop): Rename from
5023         call_thread_fsm_should_notify_stop.
5024         (run_inferior_call, call_function_by_hand_dummy): Update.
5025         * cli/cli-interp.c (should_print_stop_to_console): Update.
5026         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5027         Add constructor.  Change type of location_breakpoint,
5028         caller_breakpoint.
5029         (until_break_fsm_ops): Remove.
5030         (new_until_break_fsm): Remove.
5031         (until_break_fsm::should_stop): Rename from
5032         until_break_fsm_should_stop.
5033         (until_break_fsm::clean_up): Rename from
5034         until_break_fsm_clean_up.
5035         (until_break_fsm::do_async_reply_reason): Rename from
5036         until_break_fsm_async_reply_reason.
5037         (until_break_command): Update.
5038         * thread-fsm.c: Remove.
5039         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5040
5041 2019-02-07  Tom Tromey  <tom@tromey.com>
5042
5043         * yy-remap.h: Add include guard.
5044         * xtensa-tdep.h: Add include guard.
5045         * xcoffread.h: Rename include guard.
5046         * varobj-iter.h: Add include guard.
5047         * tui/tui.h: Rename include guard.
5048         * tui/tui-winsource.h: Rename include guard.
5049         * tui/tui-wingeneral.h: Rename include guard.
5050         * tui/tui-windata.h: Rename include guard.
5051         * tui/tui-win.h: Rename include guard.
5052         * tui/tui-stack.h: Rename include guard.
5053         * tui/tui-source.h: Rename include guard.
5054         * tui/tui-regs.h: Rename include guard.
5055         * tui/tui-out.h: Rename include guard.
5056         * tui/tui-layout.h: Rename include guard.
5057         * tui/tui-io.h: Rename include guard.
5058         * tui/tui-hooks.h: Rename include guard.
5059         * tui/tui-file.h: Rename include guard.
5060         * tui/tui-disasm.h: Rename include guard.
5061         * tui/tui-data.h: Rename include guard.
5062         * tui/tui-command.h: Rename include guard.
5063         * tic6x-tdep.h: Add include guard.
5064         * target/waitstatus.h: Rename include guard.
5065         * target/wait.h: Rename include guard.
5066         * target/target.h: Rename include guard.
5067         * target/resume.h: Rename include guard.
5068         * target-float.h: Rename include guard.
5069         * stabsread.h: Add include guard.
5070         * rs6000-tdep.h: Add include guard.
5071         * riscv-fbsd-tdep.h: Add include guard.
5072         * regformats/regdef.h: Rename include guard.
5073         * record.h: Rename include guard.
5074         * python/python.h: Rename include guard.
5075         * python/python-internal.h: Rename include guard.
5076         * python/py-stopevent.h: Rename include guard.
5077         * python/py-ref.h: Rename include guard.
5078         * python/py-record.h: Rename include guard.
5079         * python/py-record-full.h: Rename include guard.
5080         * python/py-record-btrace.h: Rename include guard.
5081         * python/py-instruction.h: Rename include guard.
5082         * python/py-events.h: Rename include guard.
5083         * python/py-event.h: Rename include guard.
5084         * procfs.h: Add include guard.
5085         * proc-utils.h: Add include guard.
5086         * p-lang.h: Add include guard.
5087         * or1k-tdep.h: Rename include guard.
5088         * observable.h: Rename include guard.
5089         * nto-tdep.h: Rename include guard.
5090         * nat/x86-linux.h: Rename include guard.
5091         * nat/x86-linux-dregs.h: Rename include guard.
5092         * nat/x86-gcc-cpuid.h: Add include guard.
5093         * nat/x86-dregs.h: Rename include guard.
5094         * nat/x86-cpuid.h: Rename include guard.
5095         * nat/ppc-linux.h: Rename include guard.
5096         * nat/mips-linux-watch.h: Rename include guard.
5097         * nat/linux-waitpid.h: Rename include guard.
5098         * nat/linux-ptrace.h: Rename include guard.
5099         * nat/linux-procfs.h: Rename include guard.
5100         * nat/linux-osdata.h: Rename include guard.
5101         * nat/linux-nat.h: Rename include guard.
5102         * nat/linux-namespaces.h: Rename include guard.
5103         * nat/linux-btrace.h: Rename include guard.
5104         * nat/glibc_thread_db.h: Rename include guard.
5105         * nat/gdb_thread_db.h: Rename include guard.
5106         * nat/gdb_ptrace.h: Rename include guard.
5107         * nat/fork-inferior.h: Rename include guard.
5108         * nat/amd64-linux-siginfo.h: Rename include guard.
5109         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5110         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5111         * nat/aarch64-linux.h: Rename include guard.
5112         * nat/aarch64-linux-hw-point.h: Rename include guard.
5113         * mn10300-tdep.h: Add include guard.
5114         * mips-linux-tdep.h: Add include guard.
5115         * mi/mi-parse.h: Rename include guard.
5116         * mi/mi-out.h: Rename include guard.
5117         * mi/mi-main.h: Rename include guard.
5118         * mi/mi-interp.h: Rename include guard.
5119         * mi/mi-getopt.h: Rename include guard.
5120         * mi/mi-console.h: Rename include guard.
5121         * mi/mi-common.h: Rename include guard.
5122         * mi/mi-cmds.h: Rename include guard.
5123         * mi/mi-cmd-break.h: Rename include guard.
5124         * m2-lang.h: Add include guard.
5125         * location.h: Rename include guard.
5126         * linux-record.h: Rename include guard.
5127         * linux-nat.h: Add include guard.
5128         * linux-fork.h: Add include guard.
5129         * i386-darwin-tdep.h: Rename include guard.
5130         * hppa-linux-offsets.h: Add include guard.
5131         * guile/guile.h: Rename include guard.
5132         * guile/guile-internal.h: Rename include guard.
5133         * gnu-nat.h: Rename include guard.
5134         * gdb-stabs.h: Rename include guard.
5135         * frv-tdep.h: Add include guard.
5136         * f-lang.h: Add include guard.
5137         * event-loop.h: Add include guard.
5138         * darwin-nat.h: Rename include guard.
5139         * cp-abi.h: Rename include guard.
5140         * config/sparc/nm-sol2.h: Rename include guard.
5141         * config/nm-nto.h: Rename include guard.
5142         * config/nm-linux.h: Add include guard.
5143         * config/i386/nm-i386gnu.h: Rename include guard.
5144         * config/djgpp/nl_types.h: Rename include guard.
5145         * config/djgpp/langinfo.h: Rename include guard.
5146         * compile/gcc-cp-plugin.h: Add include guard.
5147         * compile/gcc-c-plugin.h: Add include guard.
5148         * compile/compile.h: Rename include guard.
5149         * compile/compile-object-run.h: Rename include guard.
5150         * compile/compile-object-load.h: Rename include guard.
5151         * compile/compile-internal.h: Rename include guard.
5152         * compile/compile-cplus.h: Rename include guard.
5153         * compile/compile-c.h: Rename include guard.
5154         * common/xml-utils.h: Rename include guard.
5155         * common/x86-xstate.h: Rename include guard.
5156         * common/version.h: Rename include guard.
5157         * common/vec.h: Rename include guard.
5158         * common/tdesc.h: Rename include guard.
5159         * common/selftest.h: Rename include guard.
5160         * common/scoped_restore.h: Rename include guard.
5161         * common/scoped_mmap.h: Rename include guard.
5162         * common/scoped_fd.h: Rename include guard.
5163         * common/safe-iterator.h: Rename include guard.
5164         * common/run-time-clock.h: Rename include guard.
5165         * common/refcounted-object.h: Rename include guard.
5166         * common/queue.h: Rename include guard.
5167         * common/ptid.h: Rename include guard.
5168         * common/print-utils.h: Rename include guard.
5169         * common/preprocessor.h: Rename include guard.
5170         * common/pathstuff.h: Rename include guard.
5171         * common/observable.h: Rename include guard.
5172         * common/netstuff.h: Rename include guard.
5173         * common/job-control.h: Rename include guard.
5174         * common/host-defs.h: Rename include guard.
5175         * common/gdb_wait.h: Rename include guard.
5176         * common/gdb_vecs.h: Rename include guard.
5177         * common/gdb_unlinker.h: Rename include guard.
5178         * common/gdb_unique_ptr.h: Rename include guard.
5179         * common/gdb_tilde_expand.h: Rename include guard.
5180         * common/gdb_sys_time.h: Rename include guard.
5181         * common/gdb_string_view.h: Rename include guard.
5182         * common/gdb_splay_tree.h: Rename include guard.
5183         * common/gdb_setjmp.h: Rename include guard.
5184         * common/gdb_ref_ptr.h: Rename include guard.
5185         * common/gdb_optional.h: Rename include guard.
5186         * common/gdb_locale.h: Rename include guard.
5187         * common/gdb_assert.h: Rename include guard.
5188         * common/filtered-iterator.h: Rename include guard.
5189         * common/filestuff.h: Rename include guard.
5190         * common/fileio.h: Rename include guard.
5191         * common/environ.h: Rename include guard.
5192         * common/common-utils.h: Rename include guard.
5193         * common/common-types.h: Rename include guard.
5194         * common/common-regcache.h: Rename include guard.
5195         * common/common-inferior.h: Rename include guard.
5196         * common/common-gdbthread.h: Rename include guard.
5197         * common/common-exceptions.h: Rename include guard.
5198         * common/common-defs.h: Rename include guard.
5199         * common/common-debug.h: Rename include guard.
5200         * common/cleanups.h: Rename include guard.
5201         * common/buffer.h: Rename include guard.
5202         * common/btrace-common.h: Rename include guard.
5203         * common/break-common.h: Rename include guard.
5204         * cli/cli-utils.h: Rename include guard.
5205         * cli/cli-style.h: Rename include guard.
5206         * cli/cli-setshow.h: Rename include guard.
5207         * cli/cli-script.h: Rename include guard.
5208         * cli/cli-interp.h: Rename include guard.
5209         * cli/cli-decode.h: Rename include guard.
5210         * cli/cli-cmds.h: Rename include guard.
5211         * charset-list.h: Add include guard.
5212         * buildsym-legacy.h: Rename include guard.
5213         * bfin-tdep.h: Add include guard.
5214         * ax.h: Rename include guard.
5215         * arm-linux-tdep.h: Add include guard.
5216         * arm-fbsd-tdep.h: Add include guard.
5217         * arch/xtensa.h: Rename include guard.
5218         * arch/tic6x.h: Add include guard.
5219         * arch/i386.h: Add include guard.
5220         * arch/arm.h: Rename include guard.
5221         * arch/arm-linux.h: Rename include guard.
5222         * arch/arm-get-next-pcs.h: Rename include guard.
5223         * arch/amd64.h: Add include guard.
5224         * arch/aarch64-insn.h: Rename include guard.
5225         * arch-utils.h: Rename include guard.
5226         * annotate.h: Add include guard.
5227         * amd64-darwin-tdep.h: Rename include guard.
5228         * aarch64-linux-tdep.h: Add include guard.
5229         * aarch64-fbsd-tdep.h: Add include guard.
5230         * aarch32-linux-nat.h: Add include guard.
5231
5232 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5233
5234         * macrotab.c (macro_define_internal): New function that
5235         factorizes macro_define_object_internal and macro_define_function
5236         code.
5237         (macro_define_object_internal): Use macro_define_internal.
5238         (macro_define_function): Likewise.
5239
5240 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5241
5242         * macrocmd.c (extract_identifier): Return
5243         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5244         callers.
5245
5246 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5247
5248         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5249
5250 2019-02-05  Tom Tromey  <tom@tromey.com>
5251
5252         * target.c (target_stack::unpush): Move assertion earlier.
5253
5254 2019-01-30  Tom Tromey  <tom@tromey.com>
5255
5256         PR python/23615:
5257         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5258         (gdbpy_parse_and_eval): Likewise.
5259         * python/python-internal.h (gdbpy_allow_threads): New class.
5260
5261 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5262
5263         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5264         (aarch64_fbsd_fpregmap): Move earlier.
5265         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5266         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5267         instead of individual calls to trad_frame_set_reg_addr.
5268         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5269         earlier.
5270         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5271         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5272         instead of individual calls to trad_frame_set_reg_addr.
5273
5274 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5275
5276         * CONTRIBUTE: Replace contribution list with wiki link.
5277
5278 2019-01-25  Tom Tromey  <tom@tromey.com>
5279
5280         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5281
5282 2019-01-25  Tom Tromey  <tom@tromey.com>
5283
5284         * xtensa-linux-nat.c: Fix common/ includes.
5285         * xml-support.h: Fix common/ includes.
5286         * xml-support.c: Fix common/ includes.
5287         * x86-linux-nat.c: Fix common/ includes.
5288         * windows-nat.c: Fix common/ includes.
5289         * varobj.h: Fix common/ includes.
5290         * varobj.c: Fix common/ includes.
5291         * value.c: Fix common/ includes.
5292         * valops.c: Fix common/ includes.
5293         * utils.c: Fix common/ includes.
5294         * unittests/xml-utils-selftests.c: Fix common/ includes.
5295         * unittests/utils-selftests.c: Fix common/ includes.
5296         * unittests/unpack-selftests.c: Fix common/ includes.
5297         * unittests/tracepoint-selftests.c: Fix common/ includes.
5298         * unittests/style-selftests.c: Fix common/ includes.
5299         * unittests/string_view-selftests.c: Fix common/ includes.
5300         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5301         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5302         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5303         * unittests/rsp-low-selftests.c: Fix common/ includes.
5304         * unittests/parse-connection-spec-selftests.c: Fix common/
5305         includes.
5306         * unittests/optional-selftests.c: Fix common/ includes.
5307         * unittests/offset-type-selftests.c: Fix common/ includes.
5308         * unittests/observable-selftests.c: Fix common/ includes.
5309         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5310         * unittests/memrange-selftests.c: Fix common/ includes.
5311         * unittests/memory-map-selftests.c: Fix common/ includes.
5312         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5313         * unittests/function-view-selftests.c: Fix common/ includes.
5314         * unittests/environ-selftests.c: Fix common/ includes.
5315         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5316         * unittests/common-utils-selftests.c: Fix common/ includes.
5317         * unittests/cli-utils-selftests.c: Fix common/ includes.
5318         * unittests/array-view-selftests.c: Fix common/ includes.
5319         * ui-file.c: Fix common/ includes.
5320         * tui/tui-io.c: Fix common/ includes.
5321         * tracepoint.h: Fix common/ includes.
5322         * tracepoint.c: Fix common/ includes.
5323         * tracefile-tfile.c: Fix common/ includes.
5324         * top.h: Fix common/ includes.
5325         * top.c: Fix common/ includes.
5326         * thread.c: Fix common/ includes.
5327         * target/waitstatus.h: Fix common/ includes.
5328         * target/waitstatus.c: Fix common/ includes.
5329         * target.h: Fix common/ includes.
5330         * target.c: Fix common/ includes.
5331         * target-memory.c: Fix common/ includes.
5332         * target-descriptions.c: Fix common/ includes.
5333         * symtab.h: Fix common/ includes.
5334         * symfile.c: Fix common/ includes.
5335         * stap-probe.c: Fix common/ includes.
5336         * spu-linux-nat.c: Fix common/ includes.
5337         * sparc-nat.c: Fix common/ includes.
5338         * source.c: Fix common/ includes.
5339         * solib.c: Fix common/ includes.
5340         * solib-target.c: Fix common/ includes.
5341         * ser-unix.c: Fix common/ includes.
5342         * ser-tcp.c: Fix common/ includes.
5343         * ser-pipe.c: Fix common/ includes.
5344         * ser-base.c: Fix common/ includes.
5345         * selftest-arch.c: Fix common/ includes.
5346         * s12z-tdep.c: Fix common/ includes.
5347         * rust-exp.y: Fix common/ includes.
5348         * rs6000-aix-tdep.c: Fix common/ includes.
5349         * riscv-tdep.c: Fix common/ includes.
5350         * remote.c: Fix common/ includes.
5351         * remote-notif.h: Fix common/ includes.
5352         * remote-fileio.h: Fix common/ includes.
5353         * remote-fileio.c: Fix common/ includes.
5354         * regcache.h: Fix common/ includes.
5355         * regcache.c: Fix common/ includes.
5356         * record-btrace.c: Fix common/ includes.
5357         * python/python.c: Fix common/ includes.
5358         * python/py-type.c: Fix common/ includes.
5359         * python/py-inferior.c: Fix common/ includes.
5360         * progspace.h: Fix common/ includes.
5361         * producer.c: Fix common/ includes.
5362         * procfs.c: Fix common/ includes.
5363         * proc-api.c: Fix common/ includes.
5364         * printcmd.c: Fix common/ includes.
5365         * ppc-linux-nat.c: Fix common/ includes.
5366         * parser-defs.h: Fix common/ includes.
5367         * osdata.c: Fix common/ includes.
5368         * obsd-nat.c: Fix common/ includes.
5369         * nat/x86-linux.c: Fix common/ includes.
5370         * nat/x86-linux-dregs.c: Fix common/ includes.
5371         * nat/x86-dregs.h: Fix common/ includes.
5372         * nat/x86-dregs.c: Fix common/ includes.
5373         * nat/ppc-linux.c: Fix common/ includes.
5374         * nat/mips-linux-watch.h: Fix common/ includes.
5375         * nat/mips-linux-watch.c: Fix common/ includes.
5376         * nat/linux-waitpid.c: Fix common/ includes.
5377         * nat/linux-ptrace.h: Fix common/ includes.
5378         * nat/linux-ptrace.c: Fix common/ includes.
5379         * nat/linux-procfs.c: Fix common/ includes.
5380         * nat/linux-personality.c: Fix common/ includes.
5381         * nat/linux-osdata.c: Fix common/ includes.
5382         * nat/linux-namespaces.c: Fix common/ includes.
5383         * nat/linux-btrace.h: Fix common/ includes.
5384         * nat/linux-btrace.c: Fix common/ includes.
5385         * nat/fork-inferior.c: Fix common/ includes.
5386         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5387         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5388         * nat/aarch64-linux.c: Fix common/ includes.
5389         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5390         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5391         * namespace.h: Fix common/ includes.
5392         * mips-linux-tdep.c: Fix common/ includes.
5393         * minsyms.c: Fix common/ includes.
5394         * mi/mi-parse.h: Fix common/ includes.
5395         * mi/mi-main.c: Fix common/ includes.
5396         * mi/mi-cmd-env.c: Fix common/ includes.
5397         * memrange.h: Fix common/ includes.
5398         * memattr.c: Fix common/ includes.
5399         * maint.h: Fix common/ includes.
5400         * maint.c: Fix common/ includes.
5401         * main.c: Fix common/ includes.
5402         * machoread.c: Fix common/ includes.
5403         * location.c: Fix common/ includes.
5404         * linux-thread-db.c: Fix common/ includes.
5405         * linux-nat.c: Fix common/ includes.
5406         * linux-fork.c: Fix common/ includes.
5407         * inline-frame.c: Fix common/ includes.
5408         * infrun.c: Fix common/ includes.
5409         * inflow.c: Fix common/ includes.
5410         * inferior.h: Fix common/ includes.
5411         * inferior.c: Fix common/ includes.
5412         * infcmd.c: Fix common/ includes.
5413         * inf-ptrace.c: Fix common/ includes.
5414         * inf-child.c: Fix common/ includes.
5415         * ia64-linux-nat.c: Fix common/ includes.
5416         * i387-tdep.c: Fix common/ includes.
5417         * i386-tdep.c: Fix common/ includes.
5418         * i386-linux-tdep.c: Fix common/ includes.
5419         * i386-linux-nat.c: Fix common/ includes.
5420         * i386-go32-tdep.c: Fix common/ includes.
5421         * i386-fbsd-tdep.c: Fix common/ includes.
5422         * i386-fbsd-nat.c: Fix common/ includes.
5423         * guile/scm-type.c: Fix common/ includes.
5424         * guile/guile.c: Fix common/ includes.
5425         * go32-nat.c: Fix common/ includes.
5426         * gnu-nat.c: Fix common/ includes.
5427         * gdbthread.h: Fix common/ includes.
5428         * gdbarch-selftests.c: Fix common/ includes.
5429         * gdb_usleep.c: Fix common/ includes.
5430         * gdb_select.h: Fix common/ includes.
5431         * gdb_bfd.c: Fix common/ includes.
5432         * gcore.c: Fix common/ includes.
5433         * fork-child.c: Fix common/ includes.
5434         * findvar.c: Fix common/ includes.
5435         * fbsd-nat.c: Fix common/ includes.
5436         * event-top.c: Fix common/ includes.
5437         * event-loop.c: Fix common/ includes.
5438         * dwarf2read.c: Fix common/ includes.
5439         * dwarf2loc.c: Fix common/ includes.
5440         * dwarf2-frame.c: Fix common/ includes.
5441         * dwarf-index-cache.c: Fix common/ includes.
5442         * dtrace-probe.c: Fix common/ includes.
5443         * disasm-selftests.c: Fix common/ includes.
5444         * defs.h: Fix common/ includes.
5445         * csky-tdep.c: Fix common/ includes.
5446         * cp-valprint.c: Fix common/ includes.
5447         * cp-support.h: Fix common/ includes.
5448         * cp-support.c: Fix common/ includes.
5449         * corelow.c: Fix common/ includes.
5450         * completer.h: Fix common/ includes.
5451         * completer.c: Fix common/ includes.
5452         * compile/compile.c: Fix common/ includes.
5453         * compile/compile-loc2c.c: Fix common/ includes.
5454         * compile/compile-cplus-types.c: Fix common/ includes.
5455         * compile/compile-cplus-symbols.c: Fix common/ includes.
5456         * command.h: Fix common/ includes.
5457         * cli/cli-dump.c: Fix common/ includes.
5458         * cli/cli-cmds.c: Fix common/ includes.
5459         * charset.c: Fix common/ includes.
5460         * build-id.c: Fix common/ includes.
5461         * btrace.h: Fix common/ includes.
5462         * btrace.c: Fix common/ includes.
5463         * breakpoint.h: Fix common/ includes.
5464         * breakpoint.c: Fix common/ includes.
5465         * ax.h:
5466         (enum agent_op): Fix common/ includes.
5467         * ax-general.c (struct aop_map): Fix common/ includes.
5468         * ax-gdb.c: Fix common/ includes.
5469         * auxv.c: Fix common/ includes.
5470         * auto-load.c: Fix common/ includes.
5471         * arm-tdep.c: Fix common/ includes.
5472         * arch/riscv.c: Fix common/ includes.
5473         * arch/ppc-linux-common.c: Fix common/ includes.
5474         * arch/i386.c: Fix common/ includes.
5475         * arch/arm.c: Fix common/ includes.
5476         * arch/arm-linux.c: Fix common/ includes.
5477         * arch/arm-get-next-pcs.c: Fix common/ includes.
5478         * arch/amd64.c: Fix common/ includes.
5479         * arch/aarch64.c: Fix common/ includes.
5480         * arch/aarch64-insn.c: Fix common/ includes.
5481         * arch-utils.c: Fix common/ includes.
5482         * amd64-windows-tdep.c: Fix common/ includes.
5483         * amd64-tdep.c: Fix common/ includes.
5484         * amd64-sol2-tdep.c: Fix common/ includes.
5485         * amd64-obsd-tdep.c: Fix common/ includes.
5486         * amd64-nbsd-tdep.c: Fix common/ includes.
5487         * amd64-linux-tdep.c: Fix common/ includes.
5488         * amd64-linux-nat.c: Fix common/ includes.
5489         * amd64-fbsd-tdep.c: Fix common/ includes.
5490         * amd64-fbsd-nat.c: Fix common/ includes.
5491         * amd64-dicos-tdep.c: Fix common/ includes.
5492         * amd64-darwin-tdep.c: Fix common/ includes.
5493         * agent.c: Fix common/ includes.
5494         * ada-lang.h: Fix common/ includes.
5495         * ada-lang.c: Fix common/ includes.
5496         * aarch64-tdep.c: Fix common/ includes.
5497
5498 2019-01-25  Tom Tromey  <tom@tromey.com>
5499
5500         * common/create-version.sh: Use common/version.h.
5501
5502 2019-01-24  Pedro Alves  <palves@redhat.com>
5503
5504         * infrun.c (signal_stop, signal_print, signal_program)
5505         (signal_catch, signal_pass): Now arrays instead of pointers.
5506         (update_signals_program_target, do_target_resume)
5507         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5508         * linux-nat.c (linux_nat_target::pass_signals)
5509         (linux_nat_target::create_inferior, linux_nat_target::attach):
5510         Adjust.
5511         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5512         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5513         * procfs.c (procfs_target::pass_signals): Adjust.
5514         * record-full.c (record_full_target::resume): Adjust.
5515         * remote.c (remote_target::pass_signals)
5516         (remote_target::program_signals): Adjust.
5517         * target-debug.h (target_debug_print_signals): Now takes a
5518         gdb::array_view as parameter.  Adjust.
5519         * target.h (target_ops) <pass_signals, program_signals>: Replace
5520         pointer and length parameters with gdb::array_view.
5521         (target_pass_signals, target_program_signals): Likewise.
5522         * target-delegates.c: Regenerate.
5523
5524 2019-01-24  Pedro Alves  <palves@redhat.com>
5525
5526         * common/forward-scope-exit.h
5527         (forward_scope_exit::forward_scope_exit): Pass arguments to
5528         m_bind_function directly, instead of creating a std::bind and
5529         copying that.
5530
5531 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5532
5533         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5534         for static members.
5535         (pass_in_v_vfp_candidate): Likewise.
5536
5537 2019-01-23  Tom Tromey  <tom@tromey.com>
5538             Pedro Alves  <palves@redhat.com>
5539
5540         * regcache.c (class regcache_invalidator): Remove.
5541         (regcache::raw_write): Use make_scope_exit.
5542
5543 2019-01-23  Tom Tromey  <tom@tromey.com>
5544
5545         * ui-out.h (class ui_out_emit_type): Update comment.
5546
5547 2019-01-23  Tom Tromey  <tom@tromey.com>
5548
5549         * infrun.c (fetch_inferior_event): Update comment.
5550
5551 2019-01-23  Tom Tromey  <tom@tromey.com>
5552             Pedro Alves  <palves@redhat.com>
5553
5554         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5555         parameter.
5556         (fetch_inferior_event): Use SCOPE_EXIT.
5557
5558
5559 2019-01-23  Tom Tromey  <tom@tromey.com>
5560             Pedro Alves  <palves@redhat.com>
5561
5562         * infrun.c (disable_thread_events): Delete.
5563         (stop_all_threads): Use SCOPE_EXIT.
5564
5565 2019-01-23  Tom Tromey  <tom@tromey.com>
5566             Pedro Alves  <palves@redhat.com>
5567
5568         * symfile.c: Include forward-scope-exit.h.
5569         (clear_symtab_users_cleanup): Replace forward declaration with
5570         a FORWARD_SCOPE_EXIT.
5571         (syms_from_objfile_1): Use the forward_scope_exit and
5572         gdb::optional instead of cleanup_function.
5573         (reread_symbols): Use the forward_scope_exit instead of
5574         cleanup_function.
5575         (clear_symtab_users_cleanup): Remove function.
5576
5577 2019-01-23  Tom Tromey  <tom@tromey.com>
5578             Pedro Alves  <palves@redhat.com>
5579
5580         * linux-nat.c: Include scope-exit.h.
5581         (cleanup_target_stop): Remove.
5582         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5583         SCOPE_EXIT.
5584
5585 2019-01-23  Tom Tromey  <tom@tromey.com>
5586             Pedro Alves  <palves@redhat.com>
5587
5588         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5589         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5590
5591 2019-01-23  Tom Tromey  <tom@tromey.com>
5592             Andrew Burgess  <andrew.burgess@embecosm.com>
5593             Pedro Alves  <palves@redhat.com>
5594
5595         * infrun.c (fetch_inferior_event): Use scope_exit.
5596         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5597         * top.c (execute_command): Use scope_exit.
5598         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5599         * utils.c (do_bpstat_clear_actions_cleanup)
5600         (make_bpstat_clear_actions_cleanup): Remove.
5601
5602 2019-01-23  Tom Tromey  <tom@tromey.com>
5603             Pedro Alves  <palves@redhat.com>
5604
5605         * infrun.c: Include "common/scope-exit.h"
5606         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5607         (wait_for_inferior): Use SCOPE_EXIT.
5608         (fetch_inferior_event): Use scope_exit.
5609
5610 2019-01-23  Tom Tromey  <tom@tromey.com>
5611             Pedro Alves  <palves@redhat.com>
5612
5613         * breakpoint.c (create_breakpoint): Remove cleanup.
5614
5615 2019-01-23  Tom Tromey  <tom@tromey.com>
5616             Andrew Burgess  <andrew.burgess@embecosm.com>
5617             Pedro Alves  <palves@redhat.com>
5618
5619 2019-01-23  Pedro Alves  <palves@redhat.com>
5620
5621         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5622
5623 2019-01-23  Pedro Alves  <palves@redhat.com>
5624             Andrew Burgess  <andrew.burgess@embecosm.com>
5625
5626         * gdbthread.h: Include "common/forward-scope-exit.h".
5627         (scoped_finish_thread_state): Redefine custom class in terms of
5628         forward_scope_exit.
5629
5630 2019-01-23  Pedro Alves  <palves@redhat.com>
5631             Andrew Burgess  <andrew.burgess@embecosm.com>
5632
5633         * common/forward-scope-exit.h: New file.
5634
5635 2019-01-23  Pedro Alves  <palves@redhat.com>
5636             Andrew Burgess  <andrew.burgess@embecosm.com>
5637             Tom Tromey  <tom@tromey.com>
5638
5639         * common/scope-exit.h: New file.
5640
5641 2019-01-23  Pedro Alves  <palves@redhat.com>
5642
5643         * common/preprocessor.h (ESC): Rename to ...
5644         (ESC_PARENS): ... this.
5645         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5646         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5647
5648 2019-01-23  Tom Tromey  <tom@tromey.com>
5649
5650         * language.h (class scoped_switch_to_sym_language_if_auto):
5651         Initialize m_lang in both cases.
5652
5653 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5654
5655         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5656         with XCNEW.
5657
5658 2019-01-22  Tom Tromey  <tom@tromey.com>
5659
5660         * corelow.c: Do not include sys/file.h.
5661
5662 2019-01-22  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-wingeneral.h: Include gdb_curses.h.
5665
5666 2019-01-22  Tom Tromey  <tom@tromey.com>
5667
5668         * source-cache.h (class source_cache) <get_source_lines,
5669         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5670
5671 2019-01-22  Tom Tromey  <tom@tromey.com>
5672
5673         * remote-fileio.h (struct remote_target): Declare.
5674
5675 2019-01-22  Tom Tromey  <tom@tromey.com>
5676
5677         * python/py-arch.c: Do not include py-ref.h.
5678         * python/py-bpevent.c: Do not include py-ref.h.
5679         * python/py-cmd.c: Do not include py-ref.h.
5680         * python/py-continueevent.c: Do not include py-ref.h.
5681         * python/py-event.h: Do not include py-ref.h.
5682         * python/py-evtregistry.c: Do not include py-ref.h.
5683         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5684         * python/py-frame.c: Do not include py-ref.h.
5685         * python/py-framefilter.c: Do not include py-ref.h.
5686         * python/py-function.c: Do not include py-ref.h.
5687         * python/py-infevents.c: Do not include py-ref.h.
5688         * python/py-linetable.c: Do not include py-ref.h.
5689         * python/py-objfile.c: Do not include py-ref.h.
5690         * python/py-param.c: Do not include py-ref.h.
5691         * python/py-prettyprint.c: Do not include py-ref.h.
5692         * python/py-progspace.c: Do not include py-ref.h.
5693         * python/py-symbol.c: Do not include py-ref.h.
5694         * python/py-symtab.c: Do not include py-ref.h.
5695         * python/py-type.c: Do not include py-ref.h.
5696         * python/py-unwind.c: Do not include py-ref.h.
5697         * python/py-utils.c: Do not include py-ref.h.
5698         * python/py-value.c: Do not include py-ref.h.
5699         * python/py-varobj.c: Do not include py-ref.h.
5700         * python/py-xmethods.c: Do not include py-ref.h.
5701         * python/python.c: Do not include py-ref.h.
5702         * varobj.c: Do not include py-ref.h.
5703
5704 2019-01-22  Tom Tromey  <tom@tromey.com>
5705
5706         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5707         keyword for bcache.
5708
5709 2019-01-22  Tom Tromey  <tom@tromey.com>
5710
5711         * compile/compile-cplus-types.c: Remove a comment by #include.
5712
5713 2019-01-22  Tom Tromey  <tom@tromey.com>
5714
5715         * compile/gcc-c-plugin.h: Include compile-internal.h.
5716
5717 2019-01-22  Tom Tromey  <tom@tromey.com>
5718
5719         * stabsread.c (EXTERN): Do not define.
5720         (symnum, next_symbol_text_func, processing_gcc_compilation)
5721         (within_function, global_sym_chain, global_stabs)
5722         (previous_stab_code, this_object_header_files)
5723         (n_this_object_header_files)
5724         (n_allocated_this_object_header_files): Define.
5725         * stabsread.h (EXTERN): Never define.  Use "extern".
5726
5727 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5728
5729         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5730         history_value.
5731
5732 2019-01-21  Tom Tromey  <tom@tromey.com>
5733
5734         * ui-out.c: Fix includes.
5735         * tui/tui-source.c: Fix includes.
5736         * target.c: Fix includes.
5737         * remote.c: Fix includes.
5738         * regcache.c: Fix includes.
5739         * python/py-block.c: Fix includes.
5740         * printcmd.c: Fix includes.
5741         * or1k-tdep.c: Fix includes.
5742         * mi/mi-main.c: Fix includes.
5743         * m32r-tdep.c: Fix includes.
5744         * csky-tdep.c: Fix includes.
5745         * compile/compile-cplus-types.c: Fix includes.
5746         * cli/cli-interp.c: Fix includes.
5747
5748 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5749
5750         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5751         for padding.
5752
5753 2019-01-16  Tom Tromey  <tom@tromey.com>
5754
5755         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5756         earlier.
5757         (struct objfile) <msymbols_range>: Move from top level.
5758         <msymbols>: New method.
5759         (class objfile_msymbols): Remove.
5760         * symtab.c (default_collect_symbol_completion_matches_break_on):
5761         Update.
5762         * symmisc.c (dump_msymbols): Update.
5763         * stabsread.c (scan_file_globals): Update.
5764         * objc-lang.c (info_selectors_command, info_classes_command)
5765         (find_methods): Update.
5766         * minsyms.c (find_solib_trampoline_target): Update.
5767         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5768         * coffread.c (coff_symfile_read): Update.
5769         * ada-lang.c (ada_lookup_simple_minsym)
5770         (ada_collect_symbol_completion_matches): Update.
5771
5772 2019-01-16  Tom Tromey  <tom@tromey.com>
5773
5774         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5775         type.  Remove no-argument constructor.
5776         <iterator::operator++>: Simplify.
5777         <begin>: Update.
5778         <end>: Use minimal_symbol_count.
5779
5780 2019-01-16  Tom Tromey  <tom@tromey.com>
5781
5782         * objfiles.h (struct objfile) <psymtabs>: New method.
5783         (class objfile_psymtabs): Remove.
5784         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5785         typedef.
5786         <range>: New method.
5787         (require_partial_symbols): Change return type.
5788         * psymtab.c (require_partial_symbols)
5789         (psym_expand_symtabs_matching): Update.
5790         * mdebugread.c (parse_partial_symbols): Update.
5791         * dbxread.c (dbx_end_psymtab): Update.
5792
5793 2019-01-15  Tom Tromey  <tom@tromey.com>
5794
5795         * symtab.c (lookup_objfile_from_block)
5796         (lookup_symbol_in_objfile_symtabs)
5797         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5798         (find_line_symtab, info_sources_command)
5799         (default_collect_symbol_completion_matches_break_on)
5800         (make_source_files_completion_list): Update.
5801         * symmisc.c (print_objfile_statistics, dump_objfile)
5802         (maintenance_print_symbols, maintenance_info_symtabs)
5803         (maintenance_check_symtabs, maintenance_info_line_tables):
5804         Update.
5805         * source.c (select_source_symtab)
5806         (forget_cached_source_info_for_objfile): Update.
5807         * objfiles.h (class objfile_compunits): Remove.
5808         (struct objfile) <compunits_range>: New typedef.
5809         (compunits): New method.
5810         * objfiles.c (objfile_relocate1): Update.
5811         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5812         * maint.c (count_symtabs_and_blocks): Update.
5813         * linespec.c (iterate_over_all_matching_symtabs): Update.
5814         * cp-support.c (add_symbol_overload_list_qualified): Update.
5815         * coffread.c (coff_symtab_read): Update.
5816         * ada-lang.c (add_nonlocal_symbols)
5817         (ada_collect_symbol_completion_matches)
5818         (ada_add_global_exceptions): Update.
5819
5820 2019-01-15  Tom Tromey  <tom@tromey.com>
5821
5822         * progspace.h (program_space) <objfiles_safe_range>: New
5823         typedef.
5824         <objfiles_safe>: New method.
5825         * objfiles.h (class all_objfiles_safe): Remove.
5826         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5827         * jit.c (jit_inferior_exit_hook): Update.
5828
5829 2019-01-17  Tom Tromey  <tom@tromey.com>
5830
5831         * progspace.h (program_space) <objfiles_range>: New typedef.
5832         <objfiles>: New method.
5833         <objfiles_head>: Rename from objfiles.
5834         (object_files): Update.
5835         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5836         * guile/scm-pretty-print.c
5837         (ppscm_find_pretty_printer_from_objfiles): Update.
5838         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5839         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5840         Update.
5841         * python/py-progspace.c (pspy_get_objfiles): Update.
5842         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5843         Update.
5844         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5845         (objfpy_lookup_objfile_by_build_id): Update.
5846         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5847         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5848         Update.
5849         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5850         (expand_symtab_containing_pc, lookup_objfile_from_block)
5851         (lookup_static_symbol, basic_lookup_transparent_type)
5852         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5853         (find_line_symtab, info_sources_command)
5854         (default_collect_symbol_completion_matches_break_on)
5855         (make_source_files_completion_list, find_main_name): Update.
5856         * symmisc.c (print_symbol_bcache_statistics)
5857         (print_objfile_statistics, maintenance_print_symbols)
5858         (maintenance_print_msymbols, maintenance_print_objfiles)
5859         (maintenance_info_symtabs, maintenance_check_symtabs)
5860         (maintenance_expand_symtabs, maintenance_info_line_tables):
5861         Update.
5862         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5863         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5864         (map_overlay_command, unmap_overlay_command)
5865         (simple_overlay_update, expand_symtabs_matching)
5866         (map_symbol_filenames): Update.
5867         * symfile-debug.c (set_debug_symfile): Update.
5868         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5869         Update.
5870         * source.c (select_source_symtab, forget_cached_source_info):
5871         Update.
5872         * solib.c (solib_read_symbols): Update.
5873         * solib-spu.c (append_ocl_sos): Update.
5874         * psymtab.c (maintenance_print_psymbols)
5875         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5876         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5877         * printcmd.c (info_symbol_command): Update.
5878         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5879         Update.
5880         * objfiles.h (class all_objfiles): Remove.
5881         * objfiles.c (have_partial_symbols, have_full_symbols)
5882         (have_minimal_symbols, qsort_cmp, update_section_map)
5883         (shared_objfile_contains_address_p)
5884         (default_iterate_over_objfiles_in_search_order): Update.
5885         * objc-lang.c (info_selectors_command, info_classes_command)
5886         (find_methods): Update.
5887         * minsyms.c (find_solib_trampoline_target): Update.
5888         * maint.c (maintenance_info_sections)
5889         (maintenance_translate_address, count_symtabs_and_blocks):
5890         Update.
5891         * main.c (captured_main_1): Update.
5892         * linux-thread-db.c (try_thread_db_load_from_pdir)
5893         (has_libpthread): Update.
5894         * linespec.c (iterate_over_all_matching_symtabs)
5895         (search_minsyms_for_name): Update.
5896         * jit.c (jit_find_objf_with_entry_addr): Update.
5897         * hppa-tdep.c (find_unwind_entry)
5898         (hppa_lookup_stub_minimal_symbol): Update.
5899         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5900         Update.
5901         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5902         (elf_gnu_ifunc_resolve_by_got): Update.
5903         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5904         * dwarf-index-write.c (save_gdb_index_command): Update.
5905         * cp-support.c (add_symbol_overload_list_qualified): Update.
5906         * breakpoint.c (create_overlay_event_breakpoint)
5907         (create_longjmp_master_breakpoint)
5908         (create_std_terminate_master_breakpoint)
5909         (create_exception_master_breakpoint): Update.
5910         * blockframe.c (find_pc_partial_function): Update.
5911         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5912         (ada_collect_symbol_completion_matches)
5913         (ada_add_global_exceptions): Update.
5914
5915 2019-01-17  Tom Tromey  <tom@tromey.com>
5916
5917         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5918         declare VEC.
5919         (solib_target_parse_libraries): Change return type.
5920         (library_list_start_segment, library_list_start_section)
5921         (library_list_end_library, library_list_start_library); Update.
5922         (solib_target_free_library_list): Remove.
5923         (solib_target_parse_libraries): Remove cleanup.  Change return
5924         type.
5925         (solib_target_current_sos): Update.
5926
5927 2019-01-17  Tom Tromey  <tromey@bapiya>
5928
5929         * valprint.c: Replace "the the" with "the".
5930         * symtab.c: Replace "the the" with "the".
5931         * solib.c: Replace "the the" with "the".
5932         * solib-dsbt.c: Replace "the the" with "the".
5933         * linespec.c: Replace "the the" with "the".
5934         * dwarf2loc.h: Replace "the the" with "the".
5935         * amd64-windows-tdep.c: Replace "the the" with "the".
5936         * aarch64-tdep.c: Replace "the the" with "the".
5937
5938 2019-01-16  Keith Seitz  <keiths@redhat.com>
5939
5940         PR gdb/23773
5941         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5942         <builder>: Rename to ..
5943         <m_builder>: ... this and make private.
5944         (dwarf2_cu::get_builder): New method.  Change all users of
5945         `builder' to use this method.
5946         (dwarf2_start_symtab): Move to ...
5947         (dwarf2_cu::start_symtab): ... here.  Update all callers
5948         (setup_type_unit_groups): Move to ...
5949         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5950         callers.
5951         (dwarf2_cu::reset_builder): New method.
5952         (process_full_compunit, process_full_type_unit): Use
5953         dwarf2_cu::reset_builder.
5954         (follow_die_offset): Record the ancestor CU if it is different
5955         from the followed DIE's CU.
5956         (follow_die_sig_1): Likewise.
5957
5958 2019-01-15  Tom Tromey  <tom@tromey.com>
5959
5960         * remote.c (class remote_state) <buf>: Now a char_vector.
5961         <buf_size>: Remove.
5962         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5963         parameter.
5964         (remote_target::getpkt_or_notif_sane_1)
5965         (remote_target::getpkt_sane)
5966         (remote_target::getpkt_or_notif_sane): Likewise.
5967         (class remote_target) <putpkt>: New overload.
5968         (remote_target::read_frame): Change type of "buf_p".  Remove
5969         sizeof_p parameter.
5970         (packet_ok): New overload.
5971         (packet_check_result): New overload.
5972         Update all uses.
5973
5974 2019-01-14  Tom Tromey  <tom@tromey.com>
5975
5976         * remote-notif.c (handle_notification, remote_notif_ack)
5977         (remote_notif_parse): Make "buf" const.
5978         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5979         const.
5980         (remote_notif_parse, remote_notif_ack, handle_notification):
5981         Likewise.
5982         * remote.c (remote_notif_stop_parse): Make "buf" const.
5983         (remote_target::remote_parse_stop_reply): Make "buf" const.
5984         (remote_notif_stop_ack): Make "buf" const.
5985
5986 2019-01-14  Tom Tromey  <tom@tromey.com>
5987
5988         * remote.c (remote_console_output): Make parameter const.
5989
5990 2019-01-14  Tom Tromey  <tom@tromey.com>
5991
5992         * target-debug.h (target_debug_print_signals): Constify.
5993         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5994         * procfs.c (procfs_target::pass_signals): Update.
5995         * linux-nat.c (linux_nat_target::pass_signals): Update.
5996         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5997         * target-delegates.c: Rebuild.
5998         * remote.c (remote_target::program_signals): Update.
5999         (remote_target::pass_signals): Update.
6000         * target.c (target_pass_signals): Constify argument.
6001         (target_program_signals): Likewise.
6002         * target.h (struct target_ops) <pass_signals, program_signals>:
6003         Constify argument.
6004         (target_pass_signals, target_program_signals): Constify argument.
6005
6006 2019-01-14  Tom Tromey  <tom@tromey.com>
6007
6008         PR tui/28819:
6009         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6010
6011 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6012
6013         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6014         field.
6015         * rs6000-tdep.c: Include reggroups.h.
6016         (IS_V_ALIAS_PSEUDOREG): Define.
6017         (rs6000_register_name): Return names for the "vX" aliases.
6018         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6019         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6020         aliases.  Call default_register_reggroup_p for all other
6021         pseudo-registers.
6022         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6023         New functions.
6024         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6025         Handle "vX" aliases.
6026         (v_alias_pseudo_register_collect): New function.
6027         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6028         (rs6000_gdbarch_init): Initialize "vX" aliases as
6029         pseudo-registers.  Restore registration of
6030         rs6000_pseudo_register_reggroup_p with
6031         set_tdesc_pseudo_register_reggroup_p.
6032
6033 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6034
6035         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6036         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6037         set_gdbarch_num_pseudo_regs.
6038
6039 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6040
6041         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6042         Remove arg prefixname, add do_set and do_show.
6043         Add member functions set_list and show_list.
6044         * cli/cli-style.c (class cli_style_option): Update accordingly.
6045         (style_set_list): Move to file scope.
6046         (style_show_list): Likewise.
6047         (set_style): Call help_list.
6048         (show_style): Call cmd_show_list.
6049         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6050         Update to use the new macro.
6051
6052 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6053
6054         * ada-lang.c (_initialize_ada_language): Expand the help text
6055         for the "catch exception" command.
6056
6057 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6058
6059         * symtab.c (matching_obj_sections): Initialize obj,
6060         declare it closer to its usage.
6061
6062 2019-01-10  Tom Tromey  <tom@tromey.com>
6063
6064         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6065         (basic_inf_threads_range): Remove.
6066         (inf_threads_range, inf_non_exited_threads_range)
6067         (safe_inf_threads_range): Use next_adapter.
6068
6069 2019-01-10  Keith Seitz  <keiths@redhat.com>
6070
6071         PR gdb/23712
6072         PR symtab/23010
6073         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6074         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6075
6076 2019-01-10  Keith Seitz  <keiths@redhat.com>
6077
6078         PR gdb/23712
6079         PR symtab/23010
6080         * dictionary.c (pending_to_vector): Remove.
6081         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6082         Remove _1 suffix, replacing functions of the same name.  Update
6083         all callers.
6084         (dict_create_hashed, dict_create_hashed_expandable)
6085         (dict_create_linear, dict_create_linear_expandable, dict_free)
6086         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6087         Make functions static.
6088
6089 2019-01-10  Keith Seitz  <keiths@redhat.com>
6090
6091         PR gdb/23712
6092         PR symtab/23010
6093         * dictionary.h (struct dictionary): Replace declaration with
6094         multidictionary.
6095         (dict_create_hashed, dict_create_hashed_expandable)
6096         (dict_create_linear, dict_create_linear_expandable)
6097         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6098         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6099         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6100         taking multidictionary argument.
6101         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6102         * block.h (struct block) <dict>: Change to multidictionary
6103         and rename `multidict'.
6104         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6105         symmisc.c: Update all dictionary references to multidictionary.
6106
6107 2019-01-10  Keith Seitz  <keiths@redhat.com>
6108
6109         PR gdb/23712
6110         PR symtab/23010
6111         * dictionary.c: Include unordered_map.
6112         (pending_to_vector): New function.
6113         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6114         Rewrite the non-"_1" functions to take vector instead
6115         of linked list.
6116         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6117         "new" _1 versions of the same name.
6118         (multidictionary): Define.
6119         (std::hash<enum language): New definition.
6120         (collate_pending_symbols_by_language, mdict_create_hashed)
6121         (mdict_create_hashed_expandable, mdict_create_linear)
6122         (mdict_create_linear_expandable, mdict_free)
6123         (find_language_dictionary, create_new_language_dictionary)
6124         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6125         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6126         (mdict_size, mdict_empty): New functions.
6127         * dictionary.h (mdict_iterator): Define.
6128
6129 2019-01-10  Pedro Alves  <palves@redhat.com>
6130
6131         * breakpoint.c (read_uploaded_action)
6132         (create_tracepoint_from_upload): Adjust to use
6133         gdb::unique_xmalloc_ptr.
6134         * ctf.c (ctf_write_uploaded_tp):
6135         (SET_ARRAY_FIELD): Use emplace_back.
6136         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6137         * tracefile-tfile.c (tfile_write_uploaded_tp):
6138         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6139         gdb::unique_xmalloc_ptr.
6140         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6141         at_string, cond_string, cmd_strings>: Replace char pointers
6142         with gdb::unique_xmalloc_ptr.
6143
6144 2019-01-10  Pedro Alves  <palves@redhat.com>
6145
6146         * solib-target.c (library_list_start_library): Don't xstrdup name.
6147
6148 2019-01-10  Pedro Alves  <palves@redhat.com>
6149
6150         * mdebugread.c (parse_partial_symbols): Use
6151         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6152
6153 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6154
6155         * linux-fork.c (scoped_switch_fork_info)
6156         <~scoped_switch_fork_info>: Fix incorrect variable name.
6157
6158 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6159
6160         * linux-fork.c (scoped_switch_fork_info)
6161         <scoped_switch_fork_info>: Make explicit.
6162         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6163
6164 2019-01-10  Tom Tromey  <tom@tromey.com>
6165
6166         * objfiles.h (objfile::reset_psymtabs): Update.
6167         * objfiles.c (objfile::objfile): Update.
6168         * psymtab.h (psymtab_storage::obstack): Update.
6169         (psymtab_storage::m_obstack): Use gdb::optional.
6170         (class psymtab_storage): Update comment.  Remove objfile
6171         parameter.
6172         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6173
6174 2019-01-10  Tom Tromey  <tom@tromey.com>
6175
6176         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6177         <free_psymtabs>: Now private.
6178         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6179         (allocate_psymtab): Use new method.
6180
6181 2019-01-10  Tom Tromey  <tom@tromey.com>
6182
6183         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6184         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6185         * mdebugread.c (parse_partial_symbols): Use
6186         allocate_dependencies.
6187         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6188         allocate_dependencies.
6189         (process_psymtab_comp_unit_reader)
6190         (build_type_psymtab_dependencies): Likewise.
6191         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6192
6193 2019-01-10  Tom Tromey  <tom@tromey.com>
6194
6195         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6196         PSYMBOL_SET_LANGUAGE.
6197         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6198
6199 2019-01-10  Tom Tromey  <tom@tromey.com>
6200
6201         * psymtab.h (psymtab_storage::obstack): New method.
6202         <m_obstack>: Rename from obstack; now private.
6203         * psymtab.c (psymtab_storage): Update.
6204         * dwarf2read.c (create_addrmap_from_index)
6205         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6206         Update.
6207
6208 2019-01-10  Tom Tromey  <tom@tromey.com>
6209
6210         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6211         * objfiles.h (objfile::reset_psymtabs): New method.
6212
6213 2019-01-10  Tom Tromey  <tom@tromey.com>
6214
6215         * symmisc.c (print_symbol_bcache_statistics): Update.
6216         (print_objfile_statistics): Update.
6217         * symfile.c (reread_symbols): Update.
6218         * psymtab.h (class psymtab_storage): New.
6219         * psymtab.c (psymtab_storage): New constructor.
6220         (~psymtab_storage): New destructor.
6221         (require_partial_symbols): Update.
6222         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6223         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6224         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6225         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6226         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6227         (start_psymtab_common, end_psymtab_common)
6228         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6229         (allocate_psymtab): Update.
6230         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6231         Update.
6232         (dump_psymtab_addrmap, maintenance_print_psymbols)
6233         (maintenance_check_psymtabs): Update.
6234         (class objfile_psymtabs): Move to objfiles.h.
6235         * psympriv.h (discard_psymtab): Now inline.
6236         (psymtab_discarder::psymtab_discarder): Update.
6237         (psymtab_discarder::~psymtab_discarder): Update.
6238         (ALL_OBJFILE_PSYMTABS): Rewrite.
6239         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6240         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6241         Remove fields.
6242         <partial_symtabs>: New field.
6243         (class objfile_psymtabs): Move from psymtab.h.  Update.
6244         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6245         psymbol_cache.
6246         (objfile::~objfile): Don't destroy psymbol_cache.
6247         * mdebugread.c (parse_partial_symbols): Update.
6248         * dwarf2read.c (create_addrmap_from_index)
6249         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6250         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6251         (add_partial_subprogram, dwarf2_ranges_read): Update.
6252         * dwarf-index-write.c (write_address_map)
6253         (write_one_signatured_type, recursively_write_psymbols)
6254         (class debug_names, class debug_names, write_psymtabs_to_index):
6255         Update.
6256
6257 2019-01-10  Tom Tromey  <tom@tromey.com>
6258
6259         * symtab.h (SYMBOL_SET_NAMES): Update.
6260         (symbol_set_names): Update.
6261         (MSYMBOL_SET_NAMES): Update.
6262         * symtab.c (symbol_set_names): Change argument to be an
6263         objfile_per_bfd_storage.
6264         * psymtab.c (add_psymbol_to_bcache): Update.
6265         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6266
6267 2019-01-10  Tom Tromey  <tom@tromey.com>
6268
6269         * symtab.c (create_demangled_names_hash): Change argument to be an
6270         objfile_per_bfd_storage.
6271         (symbol_set_names): Update.
6272
6273 2019-01-10  Tom Tromey  <tom@tromey.com>
6274
6275         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6276         init_psymbol_list.
6277         * psymtab.c (init_psymbol_list): Do nothing if already called.
6278         * psympriv.h (init_psymbol_list): Add comment.
6279         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6280         init_psymbol_list.
6281         * dbxread.c (dbx_symfile_read): Unconditionally call
6282         init_psymbol_list.
6283
6284 2019-01-10  Tom Tromey  <tom@tromey.com>
6285
6286         * xcoffread.c (scan_xcoff_symtab): Update.
6287         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6288         "where".
6289         * mdebugread.c (parse_partial_symbols)
6290         (handle_psymbol_enumerators): Update.
6291         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6292         * dbxread.c (read_dbx_symtab): Update.
6293         * psympriv.h (psymbol_placement): New enum.
6294         (add_psymbol_to_list): Update.
6295
6296 2019-01-10  Tom Tromey  <tom@tromey.com>
6297
6298         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6299         static_psymbols parameters.
6300         (scan_xcoff_symtab): Update.
6301         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6302         static_psymbols parameters.
6303         * psympriv.h (start_psymtab_common): Update.
6304         * mdebugread.c (parse_partial_symbols): Update.
6305         * dwarf2read.c (create_partial_symtab): Update.
6306         * dbxread.c (read_dbx_symtab): Update.
6307         (start_psymtab): Remove global_psymbols and static_psymbols
6308         parameters.
6309
6310 2019-01-10  Tom Tromey  <tom@tromey.com>
6311
6312         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6313         * psymtab.c (allocate_psymtab): Add comment.
6314         * psympriv.h (allocate_psymtab): Add comment.
6315         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6316         initializations.
6317         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6318
6319 2019-01-10  Tom Tromey  <tom@tromey.com>
6320
6321         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6322         Don't declare.
6323         * mipsread.c: Include mdebugread.h.
6324         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6325         Declare.
6326         * elfread.c: Include mdebugread.h.
6327
6328 2019-01-09  Tom Tromey  <tom@tromey.com>
6329
6330         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6331         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6332         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6333         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6334         (psym_lookup_symbol, psym_find_last_source_symtab)
6335         (psym_forget_cached_source_info, psym_print_stats)
6336         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6337         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6338         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6339         (psym_find_compunit_symtab_by_address)
6340         (maintenance_print_psymbols, maintenance_info_psymtabs)
6341         (maintenance_check_psymtabs): Use ranged for.
6342         * psymtab.h (class objfile_psymtabs): New.
6343         (require_partial_symbols): Return objfile_psymtabs.
6344         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6345
6346 2019-01-09  Tom Tromey  <tom@tromey.com>
6347
6348         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6349         (find_pc_mapped_section, list_overlays_command)
6350         (map_overlay_command, unmap_overlay_command)
6351         (simple_overlay_update): Use all_objfiles.
6352         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6353         * printcmd.c (info_symbol_command): Use all_objfiles.
6354         * objfiles.h (ALL_OBJSECTIONS): Remove.
6355         * maint.c (maintenance_translate_address): Use all_objfiles.
6356         * gcore.c (gcore_create_callback): Use all_objfiles.
6357         (objfile_find_memory_regions): Likewise.
6358
6359 2019-01-09  Tom Tromey  <tom@tromey.com>
6360
6361         * symtab.c (find_line_symtab, info_sources_command)
6362         (make_source_files_completion_list): Use objfile_compunits.
6363         * source.c (select_source_symtab): Use objfile_compunits.
6364         * objfiles.h (struct objfile): Update comment.
6365         (ALL_OBJFILES): Remove.
6366         (ALL_FILETABS): Remove.
6367         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6368         objfile_compunits.
6369
6370 2019-01-09  Tom Tromey  <tom@tromey.com>
6371
6372         * symmisc.c (print_objfile_statistics, dump_objfile)
6373         (maintenance_print_symbols): Use compunit_filetabs.
6374         * source.c (forget_cached_source_info_for_objfile): Use
6375         compunit_filetabs.
6376         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6377         (ALL_FILETABS): Use compunit_filetabs.
6378         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6379         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6380
6381 2019-01-09  Tom Tromey  <tom@tromey.com>
6382
6383         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6384         (compunit_filetabs): New.
6385         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6386         compunit_filetabs.
6387         (info_sources_command, make_source_files_completion_list): Remove
6388         declaration.
6389         * symmisc.c (print_objfile_statistics, dump_objfile)
6390         (maintenance_print_symbols): Remove declaration.
6391         (maintenance_info_symtabs): Use compunit_filetabs.
6392         (maintenance_info_line_tables): Likewise.
6393         * source.c (select_source_symtab): Change local variable name.
6394         (forget_cached_source_info_for_objfile): Remove declaration.
6395         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6396         * objfiles.c (objfile_relocate1): Remove declaration.
6397         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6398         declaration.
6399         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6400         * coffread.c (coff_symtab_read): Remove declaration.
6401         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6402         compunit_filetabs.
6403
6404 2019-01-09  Tom Tromey  <tom@tromey.com>
6405
6406         * symtab.c (lookup_objfile_from_block)
6407         (find_pc_sect_compunit_symtab, search_symbols)
6408         (default_collect_symbol_completion_matches_break_on): Use
6409         objfile_compunits.
6410         * objfiles.h (ALL_COMPUNITS): Remove.
6411         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6412         * cp-support.c (add_symbol_overload_list_qualified): Use
6413         objfile_compunits.
6414         * ada-lang.c (ada_collect_symbol_completion_matches)
6415         (ada_add_global_exceptions): Use objfile_compunits.
6416
6417 2019-01-09  Tom Tromey  <tom@tromey.com>
6418
6419         * source.c (select_source_symtab)
6420         (forget_cached_source_info_for_objfile): Remove declaration.
6421         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6422         declaration.
6423         * maint.c (count_symtabs_and_blocks): Remove declaration.
6424         * cp-support.c (add_symbol_overload_list_qualified): Remove
6425         declaration.
6426         * coffread.c (coff_symtab_read): Remove declaration.
6427         * symtab.c (lookup_symbol_in_objfile_symtabs)
6428         (basic_lookup_transparent_type_1): Use objfile_compunits.
6429         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6430         (info_sources_command, search_symbols)
6431         (default_collect_symbol_completion_matches_break_on)
6432         (make_source_files_completion_list): Remove declaration.
6433         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6434         (ada_collect_symbol_completion_matches)
6435         (ada_add_global_exceptions): Remove declaration.
6436         * linespec.c (iterate_over_all_matching_symtabs): Use
6437         objfile_compunits.
6438         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6439         (class objfile_compunits): New.
6440         (ALL_COMPUNITS): Use objfile_compunits.
6441         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6442         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6443         objfile_compunits.
6444         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6445
6446 2019-01-09  Tom Tromey  <tom@tromey.com>
6447
6448         * symtab.c (search_symbols)
6449         (default_collect_symbol_completion_matches_break_on): Use
6450         objfile_msymbols.
6451         * ada-lang.c (ada_lookup_simple_minsym)
6452         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6453         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6454         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6455         objfile_msymbols.
6456         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6457         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6458         * objc-lang.c (find_methods): Use objfile_msymbols.
6459         (info_selectors_command, info_classes_command): Likewise.
6460         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6461         * objfiles.h (class objfile_msymbols): New.
6462         (ALL_OBJFILE_MSYMBOLS): Remove.
6463         (ALL_MSYMBOLS): Remove.
6464
6465 2019-01-09  Tom Tromey  <tom@tromey.com>
6466
6467         * common/next-iterator.h (next_adapter): Add Iterator template
6468         parameter.
6469         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6470         (class all_objfiles_safe): New.
6471         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6472         * objfiles.c (put_objfile_before): Update comment.
6473         (add_separate_debug_objfile): Likewise.
6474         (free_all_objfiles): Use all_objfiles_safe.
6475         (objfile_purge_solibs): Likewise.
6476
6477 2019-01-09  Tom Tromey  <tom@tromey.com>
6478
6479         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6480         (expand_symtab_containing_pc, lookup_static_symbol)
6481         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6482         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6483         all_objfiles.
6484         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6485         * breakpoint.c (create_overlay_event_breakpoint)
6486         (create_longjmp_master_breakpoint)
6487         (create_std_terminate_master_breakpoint)
6488         (create_exception_master_breakpoint): Use all_objfiles.
6489         * linux-thread-db.c (try_thread_db_load_from_pdir)
6490         (has_libpthread): Use all_objfiles.
6491         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6492         * linespec.c (iterate_over_all_matching_symtabs)
6493         (search_minsyms_for_name): Use all_objfiles.
6494         * maint.c (maintenance_info_sections): Use all_objfiles.
6495         * main.c (captured_main_1): Use all_objfiles.
6496         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6497         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6498         * guile/scm-pretty-print.c
6499         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6500         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6501         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6502         (maintenance_print_msymbols): Use all_objfiles.
6503         * source.c (select_source_symtab): Use all_objfiles.
6504         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6505         * symfile.c (remove_symbol_file_command)
6506         (expand_symtabs_matching, map_symbol_filenames): Use
6507         all_objfiles.
6508         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6509         all_objfiles.
6510         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6511         * objc-lang.c (find_methods): Use all_objfiles.
6512         * objfiles.c (have_partial_symbols, have_full_symbols)
6513         (have_minimal_symbols, qsort_cmp)
6514         (default_iterate_over_objfiles_in_search_order): Use
6515         all_objfiles.
6516         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6517         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6518         (maintenance_check_psymtabs): Use all_objfiles.
6519         (ALL_PSYMTABS): Remove.
6520         * compile/compile-object-run.c (do_module_cleanup): Use
6521         all_objfiles.
6522         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6523         * cp-support.c (add_symbol_overload_list_qualified): Use
6524         all_objfiles.
6525         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6526         Use all_objfiles.
6527         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6528         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6529         all_objfiles.
6530         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6531         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6532         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6533         Uses all_objfiles.
6534         * solib.c (solib_read_symbols): Use all_objfiles
6535
6536 2019-01-09  Tom Tromey  <tom@tromey.com>
6537
6538         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6539         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6540         all_objfiles.
6541         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6542         * symmisc.c (print_symbol_bcache_statistics)
6543         (print_objfile_statistics, maintenance_print_objfiles)
6544         (maintenance_info_symtabs, maintenance_check_symtabs)
6545         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6546         all_objfiles.
6547         * source.c (forget_cached_source_info): Use all_objfiles.
6548         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6549         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6550         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6551         * objfiles.c (update_section_map): Use all_objfiles.
6552         (shared_objfile_contains_address_p): Likewise.
6553         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6554         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6555
6556 2019-01-09  Tom Tromey  <tom@tromey.com>
6557
6558         * common/next-iterator.h: New file.
6559         * objfiles.h (class all_objfiles): New.
6560         (struct objfile_iterator): New.
6561
6562 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6563
6564         * NEWS: Move the description of the changed "frame", "select-frame",
6565          and "info frame" commands to the Changed commands section.
6566
6567 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6568
6569         * gdbtypes.c (check_stub_method_group): Remove handling of old
6570         mangling schemes.
6571         * linespec.c (find_methods): Likewise.
6572         * stabsread.c (read_member_functions): Likewise.
6573         * valops.c (search_struct_method): Likewise.
6574         (value_struct_elt_for_reference): Likewise.
6575         * NEWS: Mention this change.
6576
6577 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6578
6579         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6580         print_source_lines.
6581         * source.c (print_source_lines_base): Update line number check.
6582         (print_source_lines): New function.
6583         (source_lines_range::source_lines_range): New function.
6584         * source.h (class source_lines_range): New class.
6585         (print_source_lines): New declaration.
6586
6587 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6588
6589         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6590
6591 2019-01-08  Tom Tromey  <tom@tromey.com>
6592             Simon Marchi  <simon.marchi@ericsson.com>
6593
6594         PR gdb/24060
6595         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6596         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6597         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6598         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6599         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6600         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6601
6602 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6603
6604         * source.c (select_source_symtab): Move header comment to
6605         declaration in source.h.
6606         (forget_cached_source_info_for_objfile): Likewise.
6607         (forget_cached_source_info): Likewise.
6608         (identify_source_line): Likewise.
6609         * source.h (identify_source_line): Move declaration from symtab.h
6610         and add comment from source.c
6611         (print_source_lines): Likewise.
6612         (forget_cached_source_info_for_objfile): Likewise.
6613         (forget_cached_source_info): Likewise.
6614         (select_source_symtab): Likewise.
6615         (enum print_source_lines_flag): Move definition from symtab.h.
6616         * symtab.h (identify_source_line): Move declaration to source.h.
6617         (print_source_lines): Likewise.
6618         (forget_cached_source_info_for_objfile): Likewise.
6619         (forget_cached_source_info): Likewise.
6620         (select_source_symtab): Likewise.
6621         (enum print_source_lines_flag): Move definition to source.h.
6622         * tui/tui-hooks.c: Add 'source.h' include.
6623
6624 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6625
6626         * source.c (print_source_lines_base): Handle requests to print
6627         reverse line number sequences, and guard against empty lines
6628         string.
6629
6630 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6631
6632         * source.c (print_source_lines_base): Fix skip of '\r' if next
6633         character is '\n'.
6634
6635 2019-01-06  Tom Tromey  <tom@tromey.com>
6636
6637         * c-exp.y (struct c_parse_state) <macro_original_text,
6638         expansion_obstack>: New member.
6639         (macro_original_text, expansion_obstack): Remove globals.
6640         (scan_macro_expansion, scanning_macro_expansion)
6641         (finished_macro_expansion): Update.
6642         (scan_macro_cleanup): Remove.
6643         (yylex, c_parse): Update.
6644
6645 2019-01-06  Tom Tromey  <tom@tromey.com>
6646
6647         * c-exp.y (struct c_parse_state) <strings>: New member.
6648         (operator_stoken): Update.
6649
6650 2019-01-06  Tom Tromey  <tom@tromey.com>
6651
6652         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6653         (union type_stack_elt) <typelist_val>: Now a pointer to
6654         std::vector.
6655         (type_stack_cleanup): Don't declare.
6656         (push_typelist): Update.
6657         * parse.c (pop_typelist): Return a std::vector.
6658         (push_typelist): Take a std::vector.
6659         (follow_types): Update.  Do not free args.
6660         (type_stack_cleanup): Remove.
6661         * c-exp.y (struct c_parse_state): New.
6662         (cpstate): New global.
6663         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6664         (nonempty_typelist): Update.
6665         (func_mod): Create a new vector.
6666         (c_parse): Create a c_parse_state.
6667         (check_parameter_typelist): Do not delete params.
6668         (function_method): Update.  Do not delete type_list.
6669
6670 2019-01-06  Tom Tromey  <tom@tromey.com>
6671
6672         PR gdb/28155:
6673         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6674         check_typedef.
6675         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6676         (print_return_value): Likewise.
6677
6678 2019-01-05  Tom Tromey  <tom@tromey.com>
6679
6680         * contrib/cleanup_check.py: Remove.
6681         * contrib/gcc-with-excheck: Remove.
6682         * contrib/exsummary.py: Remove.
6683         * contrib/excheck.py: Remove.
6684
6685 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6686
6687         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6688         NULL. Initialize tpprev to NULL instead of assigning it
6689         to NULL on the next statement.
6690         * windows-nat.c (windows_delete_thread): Remove check for
6691         main_thread_id before printing thread exit notifications.
6692         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6693         Remove thread ID check against main_thread_id.
6694         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6695         windows_delete_thread.
6696         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6697
6698 2019-01-04  Tom Tromey  <tom@tromey.com>
6699
6700         * compile/compile.c (_initialize_compile): Use upper case for
6701         metasyntactic variables.
6702         * symmisc.c (_initialize_symmisc): Use upper case for
6703         metasyntactic variables.
6704         * psymtab.c (_initialize_psymtab): Use upper case for
6705         metasyntactic variables.
6706         * demangle.c (demangle_command): Use upper case for metasyntactic
6707         variables.
6708         (_initialize_demangler): Likewise.
6709         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6710         variables.
6711
6712 2019-01-03  Tom Tromey  <tom@tromey.com>
6713
6714         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6715
6716 2019-01-03  Tom Tromey  <tom@tromey.com>
6717
6718         * python/py-symtab.c (salpy_str): Update.
6719         (struct salpy_sal_object) <symtab>: Now a PyObject.
6720         (salpy_dealloc): Update.
6721         (del_objfile_sal): Use gdbpy_ref.
6722
6723 2019-01-03  Tom Tromey  <tom@tromey.com>
6724
6725         * python/py-type.c (convert_field): Use new_reference.  Return
6726         gdbpy_ref.
6727         (make_fielditem): Return gdbpy_ref.
6728         (typy_fields): Update.
6729         (typy_getitem): Update.
6730         (field_name): Return gdbpy_ref.  Use new_reference.
6731         (typy_iterator_iternext): Update.
6732
6733 2019-01-03  Tom Tromey  <tom@tromey.com>
6734
6735         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6736
6737 2019-01-03  Tom Tromey  <tom@tromey.com>
6738
6739         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6740         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6741         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6742         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6743         (pspy_set_type_printers): Likewise.
6744         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6745         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6746         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6747         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6748         (objfpy_set_type_printers): Likewise.
6749
6750 2019-01-03  Tom Tromey  <tom@tromey.com>
6751
6752         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6753         (gdbpy_print_stack): Use gdbpy_err_fetch.
6754         * python/python-internal.h (class gdbpy_err_fetch): New class.
6755         (class gdbpy_enter) <m_error_type, m_error_value,
6756         m_error_traceback>: Remove.
6757         <m_error>: New member.
6758         (gdbpy_exception_to_string): Don't declare.
6759         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6760         * python/py-value.c (convert_value_from_python): Use
6761         gdbpy_err_fetch.
6762         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6763         gdbpy_exception_to_string.
6764         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6765         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6766         gdbpy_err_fetch.
6767
6768 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6769
6770         * linux-nat.c (delete_lwp_cleanup): Delete.
6771         (struct lwp_deleter): New struct.
6772         (lwp_info_up): New typedef.
6773         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6774         lwp_info_up.
6775
6776 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6777
6778         * linux-fork.c (class scoped_switch_fork_info): New class.
6779         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6780
6781 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6782
6783         * valops.c (find_overload_match): Remove use of null_cleanup, and
6784         calls to do_cleanups.
6785
6786 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6787
6788         * compile/compile-cplus-types.c
6789         (compile_cplus_instance::decl_name): Handle changes to
6790         cp_func_name.
6791         * cp-support.c (cp_func_name): Update header comment, update
6792         return type.
6793         * cp-support.h (cp_func_name): Update return type in declaration.
6794         * valops.c (find_overload_match): Move temp_func local to top
6795         level of function and change its type.  Use temp_func to hold and
6796         delete temporary string obtained from cp_func_name.
6797
6798 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6799
6800         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6801         gdb::char_vector, remove cleanup, and update uses of `msg`.
6802
6803 2019-01-03  Jim Wilson  <jimw@sifive.com>
6804
6805         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6806
6807 2019-01-02  Tom Tromey  <tom@tromey.com>
6808
6809         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6810         (tdesc_parse_xml): Remove cleanups.
6811         * target-descriptions.h (make_cleanup_free_target_description):
6812         Don't declare.
6813         (target_desc_deleter): New struct.
6814         (target_desc_up): New typedef.
6815         * target-descriptions.c (target_desc_deleter::operator()): Rename
6816         from free_target_description.
6817         (make_cleanup_free_target_description): Remove.
6818
6819 2019-01-02  Tom Tromey  <tom@tromey.com>
6820
6821         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6822         constructor, destructor.
6823         (linespec_parser): Remove typedef.
6824         (~linespec_parser): Rename from linespec_parser_delete.
6825         (linespec_lex_to_end, linespec_complete_label)
6826         (linespec_complete): Update.
6827         (decode_line_full): Remove cleanups.
6828         (decode_line_1): Update.
6829
6830 2019-01-02  Tom Tromey  <tom@tromey.com>
6831
6832         * python/python-internal.h (inferior_to_inferior_object): Change
6833         return type.
6834         * python/py-exitedevent.c (create_exited_event_object): Update.
6835         * python/py-inferior.c (inferior_to_inferior_object): Return
6836         gdbpy_ref.
6837         (python_new_inferior, python_inferior_deleted)
6838         (thread_to_thread_object, delete_thread_object)
6839         (build_inferior_list, gdbpy_selected_inferior): Update.
6840         * python/py-infthread.c (create_thread_object): Update.  Also fail
6841         if inferior_to_inferior_object fails.
6842
6843 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6844
6845         * inferior.h (class inferior) <displaced_step_state>: New field.
6846         * infrun.h (struct displaced_step_state): Move here from
6847         infrun.c.  Initialize fields, add constructor.
6848         <inf>: Remove field.
6849         <reset>: New method.
6850         * infrun.c (struct displaced_step_inferior_state): Move to
6851         infrun.h.
6852         (displaced_step_inferior_states): Remove.
6853         (get_displaced_stepping_state): Adust.
6854         (displaced_step_in_progress_any_inferior): Adjust.
6855         (displaced_step_in_progress_thread): Adjust.
6856         (displaced_step_in_progress): Adjust.
6857         (add_displaced_stepping_state): Remove.
6858         (get_displaced_step_closure_by_addr): Adjust.
6859         (remove_displaced_stepping_state): Remove.
6860         (infrun_inferior_exit): Call displaced_step_state.reset.
6861         (use_displaced_stepping): Don't check for NULL.
6862         (displaced_step_prepare_throw): Call
6863         get_displaced_stepping_state.
6864         (displaced_step_fixup): Don't check for NULL.
6865         (prepare_for_detach): Don't check for NULL.
6866
6867 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6868
6869         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6870          in case of call that did not complete.
6871
6872 2019-01-02  Andrey Utkin  <autkin@undo.io>
6873
6874         * symfile.c (find_separate_debug_file): Fix search of debug files for
6875         remote debuggee.
6876
6877 2019-01-02  Tom Tromey  <tom@tromey.com>
6878
6879         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6880         indentation.
6881         * python/py-frame.c (frapy_older): Remove cast.
6882         (frapy_newer): Likewise.
6883         * python/py-breakpoint.c (local_setattro): Remove cast.
6884         * python/py-arch.c (archpy_name): Remove local variable.
6885         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6886
6887 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6888
6889         * unittests/basic_string_view/element_access/char/empty.cc:
6890         Fix year range in copyright header.
6891
6892 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6893
6894         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6895         Delete.
6896         <operator==>: Update with for removed field.
6897         <hash>: Likewise.
6898         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6899         <isa_features>: ...this.
6900         <abi_features>: New field.
6901         (riscv_isa_flen): Update comment.
6902         (riscv_abi_xlen): New declaration.
6903         (riscv_abi_flen): New declaration.
6904         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6905         isa_features.
6906         (riscv_abi_xlen): New function.
6907         (riscv_isa_flen): Update to get answer from isa_features.
6908         (riscv_abi_flen): New function.
6909         (riscv_has_fp_abi): Update to get answer from abi_features.
6910         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6911         xlen and flen.
6912         (riscv_call_info) <xlen, flen>: Update comment.
6913         (riscv_call_arg_struct): Remove invalid assertions
6914         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6915         is removed.
6916         (riscv_gdbarch_init): Gather isa features and abi features
6917         separately, ensure both match on the gdbarch when reusing an old
6918         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6919         a target with 64-bit float hardware.
6920
6921 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6922
6923         * source.c (search_command_helper): Stop reverse search
6924         when line 1 has been searched.
6925
6926 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6927
6928         * record-full.c (record_full_base_target::close): Rewrite
6929         record_full_core_buf_list free logic.
6930
6931 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6932
6933         * break-catch-syscall.c (print_one_catch_syscall): xfree
6934         the last text.
6935
6936 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6937
6938         * top.c (print_gdb_version): Update Copyright year in version
6939         message.
6940
6941 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6942
6943         Update copyright year range in all GDB files.
6944
6945 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6946
6947         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6948
6949 For older changes see ChangeLog-2018.
6950 \f
6951 Local Variables:
6952 mode: change-log
6953 left-margin: 8
6954 fill-column: 74
6955 version-control: never
6956 coding: utf-8
6957 End:
6958