gdb/ChangeLog

   1 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
   2
   3         GDB 8.3 released.
   4
   5 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
   6
   7         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
   8         New variable declaration.
   9         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
  10         New variable.
  11         (print_one_breakpoint): Use ui_out::test_flags and new global
  12         variable to compute use_fixed_output.
  13         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
  14         Remove.
  15         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
  16         (mi_multi_location_breakpoint_output_fixed): Remove.
  17         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
  18         new variable.
  19         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
  20         fix_multi_location_breakpoint_output flag if version >= 3.
  21         * ui-out.h (enum ui_out_flag)
  22         <fix_multi_location_breakpoint_output>: New enumerator.
  23
  24 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  25
  26         * contrib/cc-with-tweaks.sh: Validate dwz's work.
  27
  28 2019-05-10  Tom Tromey  <tromey@adacore.com>
  29
  30         * ada-lang.c (catch_ada_completer): New function.
  31         (_initialize_ada_language): Use it.
  32
  33 2019-05-10  Tom Tromey  <tromey@adacore.com>
  34
  35         * thread.c (print_thread_info): Make "requested_threads" const.
  36         * gdbthread.h (print_thread_info): Make "requested_threads"
  37         const.
  38         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
  39         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
  40
  41 2019-05-08  Tom Tromey  <tom@tromey.com>
  42
  43         * gdbtypes.c (objfile_type_data): Change type.
  44         (objfile_type, _initialize_gdbtypes): Update.
  45
  46 2019-05-08  Tom Tromey  <tom@tromey.com>
  47
  48         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
  49         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
  50         (_initialize_dwarf2_frame): Update.
  51
  52 2019-05-08  Tom Tromey  <tom@tromey.com>
  53
  54         * objc-lang.c (objc_objfile_data): Change type.
  55         (find_methods): Update.
  56         (_initialize_objc_lang): Remove.
  57
  58 2019-05-08  Tom Tromey  <tom@tromey.com>
  59
  60         * stabsread.c (rs6000_builtin_type_data): Change type.
  61         (rs6000_builtin_type, _initialize_stabsread): Update.
  62
  63 2019-05-08  Tom Tromey  <tom@tromey.com>
  64
  65         * mips-tdep.c (mips_pdr_data): Remove.
  66         (_initialize_mips_tdep): Update.
  67
  68 2019-05-08  Tom Tromey  <tom@tromey.com>
  69
  70         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
  71         (hppa_init_objfile_priv_data, read_unwind_info)
  72         (find_unwind_entry, _initialize_hppa_tdep): Update.
  73
  74 2019-05-08  Tom Tromey  <tom@tromey.com>
  75
  76         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
  77         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
  78         on obstack.
  79         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
  80
  81 2019-05-08  Tom Tromey  <tom@tromey.com>
  82
  83         * mdebugread.c (basic_type_data): Change type.
  84         (basic_type, _initialize_mdebugread): Update.
  85
  86 2019-05-08  Tom Tromey  <tom@tromey.com>
  87
  88         * common/gdb_unique_ptr.h (struct noop_deleter): New.
  89
  90 2019-05-08  Tom Tromey  <tom@tromey.com>
  91
  92         * nto-tdep.c (nto_inferior_data_reg): Change type.
  93         (nto_inferior_data): Update.
  94         (nto_inferior_data_cleanup, nto_new_inferior_data)
  95         (_initialize_nto_tdep): Remove.
  96         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  97
  98 2019-05-08  Tom Tromey  <tom@tromey.com>
  99
 100         * ada-lang.c (struct ada_inferior_data): Add initializers.
 101         (ada_inferior_data): Change type.
 102         (ada_inferior_data_cleanup): Remove.
 103         (get_ada_inferior_data, ada_inferior_exit)
 104         (struct ada_pspace_data): Add initializers, destructor.
 105         (ada_pspace_data_handle): Change type.
 106         (get_ada_pspace_data): Update.
 107         (ada_pspace_data_cleanup): Remove.
 108
 109 2019-05-08  Tom Tromey  <tom@tromey.com>
 110
 111         * coffread.c (struct coff_symfile_info): Add initializers.
 112         (coff_objfile_data_key): Move lower.  Change type.
 113         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 114         Update.
 115         (coff_free_info): Remove.
 116
 117 2019-05-08  Tom Tromey  <tom@tromey.com>
 118
 119         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 120         (fbsd_pspace_data_handle): Move lower.  Change type.
 121         (get_fbsd_pspace_data): Update.
 122         (fbsd_pspace_data_cleanup): Remove.
 123         (_initialize_fbsd_tdep): Update.
 124
 125 2019-05-08  Tom Tromey  <tom@tromey.com>
 126
 127         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 128         (get_ada_tasks_pspace_data): Update.
 129         (ada_tasks_pspace_data_cleanup): Remove.
 130         (_initialize_tasks): Update.
 131         (ada_tasks_inferior_data_handle): Change type.
 132         (get_ada_tasks_inferior_data): Update.
 133         (ada_tasks_inferior_data_cleanup): Remove.
 134         (struct ada_tasks_pspace_data): Add initializers.
 135
 136 2019-05-08  Tom Tromey  <tom@tromey.com>
 137
 138         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 139         * symfile-debug.c (debug_sym_get_probes): Change type.
 140         * stap-probe.c (handle_stap_probe):
 141         (stap_static_probe_ops::get_probes): Change type.
 142         * probe.h (class static_probe_ops) <get_probes>: Change type.
 143         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 144         (parse_probes_in_pspace): Update.
 145         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 146         Update.
 147         (any_static_probe_ops::get_probes): Change type.
 148         * elfread.c (elfread_data): New typedef.
 149         (probe_key): Change type.
 150         (elf_get_probes): Likewise.  Update.
 151         (probe_key_free): Remove.
 152         (_initialize_elfread): Update.
 153         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 154         Change type.
 155         (dtrace_process_dof_probe, dtrace_process_dof)
 156         (dtrace_static_probe_ops::get_probe): Change type.
 157
 158 2019-05-08  Tom Tromey  <tom@tromey.com>
 159
 160         * xcoffread.c (struct xcoff_symfile_info): Rename from
 161         coff_symfile_info.  Add initializers.
 162         (xcoff_objfile_data_key): Move lower.  Change type.
 163         (XCOFF_DATA): Rewrite.
 164         (xcoff_free_info): Remove.
 165         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 166         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 167         (xcoff_initial_scan): Update.
 168
 169 2019-05-08  Tom Tromey  <tom@tromey.com>
 170
 171         * solib-svr4.c (struct svr4_info): Add initializers and
 172         destructor.
 173         <probes_table>: Now an htab_up.
 174         (solib_svr4_pspace_data): Change type.
 175         (free_probes_table): Simplify.
 176         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 177         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 178         (probes_table_remove_objfile_probes, register_solib_event_probe)
 179         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 180         (_initialize_svr4_solib): Update.
 181
 182 2019-05-08  Tom Tromey  <tom@tromey.com>
 183
 184         * remote.c (remote_pspace_data): Change type.
 185         (remote_pspace_data_cleanup): Remove.
 186         (get_remote_exec_file, set_pspace_remote_exec_file)
 187         (_initialize_remote): Update.
 188
 189 2019-05-08  Tom Tromey  <tom@tromey.com>
 190
 191         * breakpoint.c (breakpoint_objfile_key): Change type.
 192         (get_breakpoint_objfile_data): Update.
 193         (free_breakpoint_objfile_data): Remove.
 194         (_initialize_breakpoint): Update.
 195
 196 2019-05-08  Tom Tromey  <tom@tromey.com>
 197
 198         * linux-tdep.c (struct linux_info): Add initializers.
 199         (linux_inferior_data): Move.  Change type.
 200         (invalidate_linux_cache_inf): Update.
 201         (linux_inferior_data_cleanup): Remove.
 202         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 203
 204 2019-05-08  Tom Tromey  <tom@tromey.com>
 205
 206         * auxv.c (auxv_inferior_data): Move.  Change type.
 207         (auxv_inferior_data_cleanup): Remove.
 208         (invalidate_auxv_cache_inf): Rewrite.
 209         (get_auxv_inferior_data, _initialize_auxv): Update.
 210
 211 2019-05-08  Tom Tromey  <tom@tromey.com>
 212
 213         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 214         (symfile_debug_objfile_data_key): Change type.
 215         (symfile_debug_installed, debug_qf_has_symbols)
 216         (debug_qf_find_last_source_symtab)
 217         (debug_qf_forget_cached_source_info)
 218         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 219         (debug_qf_print_stats, debug_qf_dump)
 220         (debug_qf_expand_symtabs_for_function)
 221         (debug_qf_expand_all_symtabs)
 222         (debug_qf_expand_symtabs_with_fullname)
 223         (debug_qf_map_matching_symbols)
 224         (debug_qf_expand_symtabs_matching)
 225         (debug_qf_find_pc_sect_compunit_symtab)
 226         (debug_qf_map_symbol_filenames)
 227         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 228         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 229         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 230         (debug_sym_read_linetable, debug_sym_relocate): Update.
 231         (symfile_debug_free_objfile): Remove.
 232         (install_symfile_debug_logging, _initialize_symfile_debug):
 233         Update.
 234
 235 2019-05-08  Tom Tromey  <tom@tromey.com>
 236
 237         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 238         allocate_on_obstack.
 239         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 240         (get_dwarf2_per_objfile): Update.
 241         (set_dwarf2_per_objfile): Remove.
 242         (dwarf2_has_info, dwarf2_get_section_info): Update.
 243         (dwarf2_free_objfile): Remove.
 244         (_initialize_dwarf2_read): Update.
 245
 246 2019-05-08  Tom Tromey  <tom@tromey.com>
 247
 248         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 249         initializers.
 250         <unsupported_script_warning_printed,
 251         script_not_found_warning_printed>: Now bool.
 252         (auto_load_pspace_data): Change type.
 253         (~auto_load_pspace_info): Rename from
 254         auto_load_pspace_data_cleanup.
 255         (get_auto_load_pspace_data, init_loaded_scripts_info)
 256         (clear_section_scripts, maybe_print_unsupported_script_warning)
 257         (maybe_print_script_not_found_warning, _initialize_auto_load):
 258         Update.
 259
 260 2019-05-08  Tom Tromey  <tom@tromey.com>
 261
 262         * objfiles.c (objfile_pspace_info): Add destructor and
 263         initializers.
 264         (objfiles_pspace_data): Change type.
 265         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 266         (get_objfile_pspace_data): Update.
 267         (objfiles_bfd_data): Change type.
 268         (get_objfile_bfd_data): Update.
 269         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 270
 271 2019-05-08  Tom Tromey  <tom@tromey.com>
 272
 273         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 274         Change type.
 275         (get_catch_syscall_inferior_data): Update.
 276         (catch_syscall_inferior_data_cleanup): Remove.
 277         (_initialize_break_catch_syscall): Update.
 278
 279 2019-05-08  Tom Tromey  <tom@tromey.com>
 280
 281         * inflow.c (struct terminal_info): Add destructor and
 282         initializers.
 283         (inflow_inferior_data): Change type.
 284         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 285         (get_inflow_inferior_data, inflow_inferior_exit)
 286         (swap_terminal_info, _initialize_inflow): Update.
 287
 288 2019-05-08  Tom Tromey  <tom@tromey.com>
 289
 290         * target-dcache.c (target_dcache_cleanup): Remove.
 291         (target_dcache_aspace_key): Change type.
 292         (target_dcache_init_p, target_dcache_invalidate)
 293         (target_dcache_get, target_dcache_get_or_init)
 294         (_initialize_target_dcache): Update.
 295         * dcache.h (struct dcache_deleter): New.
 296
 297 2019-05-08  Tom Tromey  <tom@tromey.com>
 298
 299         * symtab.c (struct symbol_cache): Add destructor and
 300         initializers.
 301         (symbol_cache_key): Move.  Change type.
 302         (make_symbol_cache, free_symbol_cache): Remove.
 303         (get_symbol_cache): Update.
 304         (symbol_cache_cleanup): Remove.
 305         (ALL_PSPACES, symbol_cache_flush)
 306         (maintenance_print_symbol_cache)
 307         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 308         Update.
 309
 310 2019-05-08  Tom Tromey  <tom@tromey.com>
 311
 312         * symtab.c (struct main_info): Add destructor and initializers.
 313         (main_progspace_key): Move.  Change type.
 314         (get_main_info): Update.
 315         (main_info_cleanup): Remove.
 316         (_initialize_symtab): Update.
 317
 318 2019-05-08  Tom Tromey  <tom@tromey.com>
 319
 320         * registry.h (DECLARE_REGISTRY): Define the _key class.
 321
 322 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 323
 324         * NEWS: Merge two 'New commands' sections.
 325
 326 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 327
 328         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 329         parameter and use Ada language definition instead.
 330         (ada_val_print_ptr): Remove unused language parameter.
 331         (ada_val_print_num): Remove language parameter and use Ada language
 332         definition instead.
 333         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 334         parameter.
 335         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 336         parameter and use Ada language definition instead.
 337         (ada_val_print_1): Update all ada_val_print_xxx calls.
 338         Remove language parameter.
 339         (ada_val_print): Update ada_val_print_1 call.
 340
 341 2019-05-08  Tom Tromey  <tromey@adacore.com>
 342
 343         * remote.c (remote_hw_watchpoint_limit)
 344         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 345         Now static.
 346
 347 2019-05-08  Tom Tromey  <tromey@adacore.com>
 348
 349         * maint.c (_initialize_maint_cmds): Move initialization code to
 350         remote.c.
 351         (watchdog, show_watchdog): Move to remote.c.
 352         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 353         "watchdog" static.
 354         (_initialize_remote): Move initialization code from maint.c.
 355         * defs.h (watchdog): Don't declare.
 356
 357 2019-05-08  Tom Tromey  <tromey@adacore.com>
 358
 359         * tui/tui-interp.c: Include main.h.
 360         * interps.c: Include main.h.
 361         * main.h (interpreter_p): Declare.
 362         * defs.h (interpreter_p): Don't declare.
 363
 364 2019-05-08  Tom Tromey  <tromey@adacore.com>
 365
 366         * dwarf2loc.c: Include dwarf2read.h.
 367         * defs.h (read_unsigned_leb128): Don't declare.
 368         * dwarf2read.h (read_unsigned_leb128): Declare.
 369
 370 2019-05-08  Tom Tromey  <tromey@adacore.com>
 371
 372         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 373         method.
 374
 375 2019-05-08  Tom Tromey  <tromey@adacore.com>
 376
 377         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 378         when no wrap column is set.
 379
 380 2019-05-08  Tom Tromey  <tromey@adacore.com>
 381
 382         * c-lang.c (c_get_string): Handle non-C-style arrays.
 383
 384 2019-05-08  Tom Tromey  <tromey@adacore.com>
 385
 386         * typeprint.c (print_offset_data::update): Print the bit offset,
 387         not the number of bits remaining.
 388
 389 2019-05-08  Tom Tromey  <tromey@adacore.com>
 390
 391         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 392         padding at end of comment.
 393
 394 2019-05-08  Tom Tromey  <tromey@adacore.com>
 395
 396         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 397         Compare main types.
 398
 399 2019-05-06  Tom Tromey  <tom@tromey.com>
 400
 401         * common/scoped_mmap.c: Include common-defs.h.
 402         * common/scoped_mmap.h: Don't include config.h.
 403
 404 2019-05-04  Tom Tromey  <tom@tromey.com>
 405
 406         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 407         (struct aarch64_call_info): Add initializers.
 408         <si>: Now a std::vector.
 409         (pass_on_stack, aarch64_push_dummy_call): Update.
 410
 411 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 412             Tom Tromey  <tom@tromey.com>
 413
 414         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 415         (ppc_threads): Now a std::vector.  Now static.
 416         (hwdebug_find_thread_points_by_tid)
 417         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 418         Update.
 419
 420 2019-05-04  Tom Tromey  <tom@tromey.com>
 421
 422         * arc-tdep.c (arc_tdesc_init): Return bool.
 423
 424 2019-05-04  Tom Tromey  <tom@tromey.com>
 425
 426         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 427         Use gdb_assert_not_reached.
 428
 429 2019-05-04  Tom Tromey  <tom@tromey.com>
 430
 431         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 432         "false".
 433
 434 2019-05-04  Tom Tromey  <tom@tromey.com>
 435
 436         * arc-tdep.c (arc_tdesc_init): Use bool.
 437
 438 2019-05-04  Tom Tromey  <tom@tromey.com>
 439
 440         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 441
 442 2019-05-04  Tom Tromey  <tom@tromey.com>
 443
 444         * cli/cli-cmds.c (valid_command_p): Return bool.
 445
 446 2019-05-04  Tom Tromey  <tom@tromey.com>
 447
 448         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 449         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 450
 451 2019-05-04  Raul Tambre  <raul@tambre.ee>
 452
 453         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 454         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 455         operator for comparison.
 456
 457 2019-05-04  Tom Tromey  <tom@tromey.com>
 458
 459         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 460         (lookup_partial_symbol, print_partial_symbols)
 461         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 462         (psymbol_compare): Update.
 463         (add_psymbol_to_bcache): Clear the entire psymbol.
 464         (maintenance_check_psymtabs): Update.
 465         * psympriv.h (struct partial_symbol): Don't derive from
 466         general_symbol_info.
 467         <obj_section, unrelocated_address, address,
 468         set_unrelocated_address>: Update.
 469         <ginfo>: New member.
 470         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 471         (debug_names::write_psymbols): Update.
 472
 473 2019-05-04  Tom de Vries  <tdevries@suse.de>
 474
 475         * contrib/cc-with-tweaks.sh: Support -n arg.
 476
 477 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 478
 479         * corelow.c (core_target::detach): Ensure frame cache and
 480         register caches are cleared.
 481         inferior.c (exit_inferior_1): Likewise.
 482
 483 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 484             Tom Tromey  <tom@tromey.com>
 485
 486         * dictionary.c (collate_pending_symbols_by_language): Remove
 487         "struct" from foreach.
 488         * symtab.c (lookup_global_symbol_from_objfile)
 489         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 490         foreach.
 491         * ser-tcp.c (net_open): Remove "struct" from foreach.
 492         * objfiles.c (objfile_relocate, objfile_rebase)
 493         (objfile_has_symbols): Remove "struct" from foreach.
 494         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 495         from foreach.
 496         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 497         foreach.
 498         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 499         "struct" from foreach.
 500         * ada-lang.c (create_excep_cond_exprs)
 501         (ada_exception_catchpoint_cond_string): Remove "struct" from
 502         foreach.
 503
 504 2019-05-03  Tom Tromey  <tromey@adacore.com>
 505
 506         * ada-exp.y (convert_char_literal): Check suffix of each
 507         enumerator.
 508
 509 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 510
 511         PR ada/21406:
 512         * ada-exp.y (yywrap): Don't define.
 513         * ada-lex.l (%option): Add noyywrap
 514         (yywrap): Remove.
 515
 516 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 517
 518         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 519         _WIN32_WINNT to the XP level, unless already defined to a higher
 520         level.
 521
 522         * unittests/parse-connection-spec-selftests.c:
 523         * ser-tcp.c:
 524         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 525         override.
 526
 527         * symfile.c (find_separate_debug_file): Remove colon from the
 528         drive spec of DOS/Windows file names of the target, so that the
 529         file name produced from DEBUGDIR and the target's directory will
 530         be valid on DOS/Windows systems.
 531
 532 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * rust-lang.c (val_print_struct): Handle printing structures
 535         containing strings.
 536
 537 2019-05-02  Tom Tromey  <tromey@adacore.com>
 538
 539         * valarith.c (_initialize_valarith): Remove.
 540
 541 2019-05-01  Tom Tromey  <tromey@adacore.com>
 542
 543         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 544         bitfields.
 545
 546 2019-05-01  Tom Tromey  <tromey@adacore.com>
 547
 548         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 549         for big-endian copies.
 550
 551 2019-04-30  Ali Tamur  <tamur@google.com>
 552         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 553         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 554         (read_3_bytes): New function.
 555
 556 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 557
 558         * windows-nat.c (main_thread_id): Delete.
 559         (handle_output_debug_string): Replace main_thread_id by
 560         current_event.dwThreadId.
 561         (fake_create_process): Likewise.
 562         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 563         Do not set main_thread_id.
 564         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 565         current_event.dwThreadId.
 566         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 567
 568 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 569
 570         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 571         Use current_event.dwThreadId instead of main_thread_id.
 572
 573 2019-04-30  Tom Tromey  <tromey@adacore.com>
 574
 575         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 576         (create_excep_cond_exprs): Iterate over program spaces.
 577         (ada_exception_catchpoint_cond_string): Examine all minimal
 578         symbols for exception types.
 579
 580 2019-04-30  Tom Tromey  <tromey@adacore.com>
 581
 582         PR c++/24470:
 583         * dwarf2read.c (process_structure_scope): Handle case where type
 584         has template parameters but no symbol was created.
 585
 586 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 587             Chris January  <chris.january@arm.com>
 588
 589         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 590         qualifier.
 591         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 592
 593 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 594
 595         * f-typeprint.c (f_print_type): Update rules for printing
 596         whitespace.
 597         (f_type_print_varspec_suffix): Likewise.
 598
 599 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 600             Chris January  <chris.january@arm.com>
 601
 602         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 603         function arguments.
 604
 605 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         * f-lang.c (build_fortran_types): Change name of void type to
 608         lower case.
 609         * f-typeprint.c (f_type_print_base): Print the name of the void
 610         type, rather than a fixed string.
 611         * f-valprint.c (f_decorations): Use lower case void string.
 612
 613 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 614             Chris January  <chris.january@arm.com>
 615
 616         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 617         types for Fortran.
 618
 619 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 620             Chris January  <chris.january@arm.com>
 621             David Lecomber  <david.lecomber@arm.com>
 622
 623         * f-exp.y (BINOP_INTRINSIC): New token.
 624         (exp): New parser rule handling BINOP_INTRINSIC.
 625         (f77_keywords): Add new builtin procedures.
 626         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 627         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 628         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 629         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 630         (print_unop_subexp_f): New function.
 631         (print_binop_subexp_f): New function.
 632         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 633         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 634         (dump_subexp_body_f): Likewise.
 635         (operator_check_f): Likewise.
 636         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 637         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 638
 639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 640
 641         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 642         UNOP_KIND.
 643         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 644         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 645         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 646         (operator_length_f): New fuction.
 647         (print_subexp_f): New function.
 648         (op_name_f): New function.
 649         (dump_subexp_body_f): New function.
 650         (operator_check_f): New function.
 651         (exp_descriptor_f): Replace standard expression handling functions
 652         with new functions.
 653         * gdb/fortran-operator.def: New file.
 654         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 655         * gdb/std-operator.def: Remove UNOP_KIND.
 656
 657 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 658
 659         * std-operator.def: Remove unbalanced, stray double quote
 660         character.
 661
 662 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 663             Chris January  <chris.january@arm.com>
 664             Daniel Everett  <daniel.everett@arm.com>
 665             Nick Forrington  <nick.forrington@arm.com>
 666             Richard Bunt  <richard.bunt@arm.com>
 667
 668         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 669         of depth when printing anonymous structs or unions.
 670         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 671         Don't print either the top-level value, or the children if the
 672         max-depth is exceeded.
 673         (ppscm_print_children): When printing the key of a map, allow one
 674         extra level of depth.
 675         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 676         print either the top-level value, or the children if the max-depth
 677         is exceeded.
 678         (print_children): When printing the key of a map, allow one extra
 679         level of depth.
 680         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 681         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 682         (user_print_options): Initialise max_depth field.
 683         (val_print_scalar_or_string_type_p): New function.
 684         (val_print): Check to see if the max depth has been reached.
 685         (val_print_check_max_depth): Define new function.
 686         (show_print_max_depth): New function.
 687         (_initialize_valprint): Add 'print max-depth' option.
 688         * valprint.h (struct value_print_options) <max_depth>: New field.
 689         (val_print_check_max_depth): Declare new function.
 690         * NEWS: Document new feature.
 691
 692 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 693
 694         * ada-lang.c (ada_language_defn): Initialise new field.
 695         * c-lang.c (c_is_string_type_p): New function.
 696         (c_language_defn): Initialise new field.
 697         (cplus_language_defn): Initialise new field.
 698         (asm_language_defn): Initialise new field.
 699         (minimal_language_defn): Initialise new field.
 700         * c-lang.h (c_is_string_type_p): Declare new function.
 701         * d-lang.c (d_language_defn): Initialise new field.
 702         * f-lang.c (f_is_string_type_p): New function.
 703         (f_language_defn): Initialise new field.
 704         * go-lang.c (go_is_string_type_p): New function.
 705         (go_language_defn): Initialise new field.
 706         * language.c (default_is_string_type_p): New function.
 707         (unknown_language_defn): Initialise new field.
 708         (auto_language_defn): Initialise new field.
 709         * language.h (struct language_defn) <la_is_string_type_p>: New
 710         member variable.
 711         (default_is_string_type_p): Declare new function.
 712         * m2-lang.c (m2_language_defn): Initialise new field.
 713         * objc-lang.c (objc_language_defn): Initialise new field.
 714         * opencl-lang.c (opencl_language_defn): Initialise new field.
 715         * p-lang.c (pascal_is_string_type_p): New function.
 716         (pascal_language_defn): Initialise new field.
 717         * rust-lang.c (rust_is_string_type_p): New function.
 718         (rust_language_defn): Initialise new field.
 719
 720 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 721
 722         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 723         New field.
 724         * ada-lang.c (ada_language_defn): Initialise new field.
 725         * c-lang.c (c_language_defn): Likewise.
 726         (cplus_language_defn): Likewise.
 727         (asm_language_defn): Likewise.
 728         (minimal_language_defn): Likewise.
 729         * d-lang.c (d_language_defn): Likewise.
 730         * f-lang.c (f_language_defn): Likewise.
 731         * go-lang.c (go_language_defn): Likewise.
 732         * language.c (unknown_language_defn): Likewise.
 733         (auto_language_defn): Likewise.
 734         * m2-lang.c (m2_language_defn): Likewise.
 735         * objc-lang.c (objc_language_defn): Likewise.
 736         * opencl-lang.c (opencl_language_defn): Likewise.
 737         * p-lang.c (pascal_language_defn): Likewise.
 738         * rust-lang.c (rust_language_defn): Likewise.
 739
 740 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * ada-lang.c (ada_is_character_type): Change return type to bool.
 743         (ada_is_string_type): Likewise.
 744         * ada-lang.h (ada_is_character_type): Update declaration
 745         (ada_is_string_type): Likewise.
 746
 747 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 748
 749         Support style in 'frame|thread apply'
 750
 751         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 752         * record.c (record_start, record_stop): Update callers of
 753         execute_command_to_string with false.
 754         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 755         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 756         methods.
 757         (class string_file): New constructor with term_out parameter.
 758         Override methods term_out and can_emit_style_escape.  New member
 759         term_out.
 760         (class stdio_file): Override can_emit_style_escape.
 761         (class tee_file): Override term_out and can_emit_style_escape.
 762         * utils.h (can_emit_style_escape): Remove.
 763         * utils.c (can_emit_style_escape): Likewise.
 764         Update all callers of can_emit_style_escape (SOMESTREAM) to
 765         SOMESTREAM->can_emit_style_escape.
 766         * source-cache.c (source_cache::get_source_lines): Likewise.
 767         * stack.c (frame_apply_command_count): Call execute_command_to_string
 768         passing the term_out characteristic of the current gdb_stdout.
 769         * thread.c (thr_try_catch_cmd): Likewise.
 770         * top.c (execute_command_to_string): pass term_out parameter
 771         to construct the string_file for the command output.
 772         * ui-file.c (term_cli_styling): New function (most code moved
 773         from utils.c can_emit_style_escape).
 774         (string_file::string_file, string_file::can_emit_style_escape,
 775         stdio_file::can_emit_style_escape, tee_file::term_out,
 776         tee_file::can_emit_style_escape): New functions.
 777
 778 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 779
 780         * NEWS: Mention the new set|show may-call-functions.
 781         * infcall.c (may_call_functions_p): New variable.
 782         (show_may_call_functions_p): New function.
 783         (call_function_by_hand_dummy): Throws an error if not
 784         may-call-functions.
 785         (_initialize_infcall): Call add_setshow_boolean_cmd for
 786         may-call-functions.
 787
 788 2019-04-25  Keith Seitz  <keiths@redhat.com>
 789
 790         PR c++/24367
 791         * cp-support.c (inspect_type): Don't attempt substitutions
 792         of symbol with the same name.
 793
 794 2019-04-25  Tom Tromey  <tromey@adacore.com>
 795
 796         PR gdb/24475:
 797         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 798         static.
 799
 800 2019-04-25  Tom Tromey  <tromey@adacore.com>
 801
 802         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 803         rvalue reference.
 804         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 805         (gdb_xml_parser::parse): Use std::move.
 806         * python/python-internal.h (gdbpy_convert_exception): Take a const
 807         reference.
 808         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 809         std::move.
 810         * python/py-utils.c (gdbpy_convert_exception): Take a const
 811         reference.
 812         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 813         Use std::move.
 814         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 815         Use std::move.
 816         * mi/mi-main.c (mi_print_exception): Take a const reference.
 817         * main.c (handle_command_errors): Take a const reference.
 818         * linespec.c (parse_linespec): Use std::move.
 819         * infcall.c (run_inferior_call): Use std::move.
 820         (call_function_by_hand_dummy): Use std::move.
 821         * exec.c (try_open_exec_file): Use std::move.
 822         * exceptions.h (exception_print, exception_fprintf)
 823         (exception_print_same): Update.
 824         * exceptions.c (print_exception, exception_print)
 825         (exception_fprintf, exception_print_same): Change parameters to
 826         const reference.
 827         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 828         * common/new-op.c: Use std::move.
 829         * common/common-exceptions.h (struct gdb_exception): Add move
 830         constructor.
 831         (struct gdb_exception_error, struct gdb_exception_quit, struct
 832         gdb_quit_bad_alloc): Change constructor to move constructor.
 833         (throw_exception): Change parameter to rvalue reference.
 834         * common/common-exceptions.c (throw_exception): Take rvalue
 835         reference.
 836         * cli/cli-interp.c (safe_execute_command): Use std::move.
 837         * breakpoint.c (insert_bp_location, location_to_sals): Use
 838         std::move.
 839
 840 2019-04-25  Tom Tromey  <tromey@adacore.com>
 841
 842         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 843         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 844         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 845         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 846         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 847         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 848         guile/scm-value.c: Use unpack.
 849         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 850         gdbscm_gdb_exception.
 851         (gdbscm_throw_gdb_exception): Likewise.
 852         (struct gdbscm_gdb_exception): New.
 853         (unpack): New function.
 854         (gdbscm_wrap): Use unpack.
 855
 856 2019-04-25  Tom Tromey  <tromey@adacore.com>
 857
 858         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 859         (gdb_rl_callback_handler): Use std::move.
 860         * common/common-exceptions.h (struct gdb_exception): Add move
 861         assignment operator.
 862         (throw_exception_sjlj): Change "exception" to const reference.
 863         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 864         (throw_exception_sjlj): Change "exception" to const reference.
 865
 866 2019-04-25  Tom Tromey  <tromey@adacore.com>
 867
 868         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 869         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 870         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 871         Update.
 872         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 873         Update.
 874         * mi/mi-interp.c (mi_interp::exec): Update.
 875         * linespec.c (parse_linespec): Update.
 876         * infcall.c (run_inferior_call): Update.
 877         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 878         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 879         (gdbscm_lookup_global_symbol): Update.
 880         * guile/scm-param.c (gdbscm_parameter_value): Update.
 881         * guile/scm-frame.c (gdbscm_frame_read_register)
 882         (gdbscm_frame_read_var): Update.
 883         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 884         * exec.c (try_open_exec_file): Update.
 885         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 886         (gdb_rl_callback_handler): Update.
 887         * common/common-exceptions.h (exception_none): Don't declare.
 888         * common/common-exceptions.c (exception_none): Don't define.
 889         (struct catcher) <exception>: Update.
 890         * cli/cli-interp.c (safe_execute_command): Update.
 891         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 892
 893 2019-04-25  Ali Tamur  <tamur@google.com>
 894
 895         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 896         (read_attribute_value): Likewise.
 897         (dwarf2_read_addr_index): Update comment.
 898         (read_str_index): Add DW_FORM_strx.
 899         (dwarf2_string_attr): Likewise.
 900         (dwarf2_const_value_attr): Likewise.
 901         (dump_die_shallow): Likewise.
 902         (dwarf2_fetch_constant_bytes): Likewise.
 903         (skip_form_bytes): Likewise.
 904         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 905
 906 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 907
 908         PR corefiles/11608
 909         PR corefiles/18187
 910         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 911         OFFSET.  Verify if current mapping contains an ELF header.
 912         (linux_find_memory_regions_full): Adjust call to
 913         dump_mapping_p.
 914
 915 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 916             Kang Li <kanglictf@gmail.com>
 917
 918         PR gdb/21600
 919
 920         * dwarf2-frame.c (read_initial_length): Be consistent about using
 921         unsigned representation of length.
 922         (decode_frame_entry_1): Likewise.  Check for wraparound of
 923         end pointer as well as buffer overflow.
 924
 925 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 926
 927         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 928         "vq".
 929
 930 2019-04-24  Tom Tromey  <tromey@adacore.com>
 931
 932         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 933
 934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * s12z-tdep.c (s12z_unwind_pc): Delete.
 937         (s12z_unwind_sp): Delete.
 938         (s12z_gdbarch_init): Don't register deleted functions with
 939         gdbarch.
 940
 941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 942
 943         * rl78-tdep.c (rl78_unwind_sp): Delete.
 944         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 945
 946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 947
 948         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 949         (xstormy16_unwind_pc): Delete.
 950         (xstormy16_dummy_id): Delete.
 951         (xstormy16_gdbarch_init): Don't register deleted functions with
 952         gdbarch.
 953
 954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * vax-tdep.c (vax_unwind_pc): Delete.
 957         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 958
 959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * v850-tdep.c (v850_unwind_sp): Delete.
 962         (v850_unwind_pc): Delete.
 963         (v850_dummy_id): Delete.
 964         (v850_gdbarch_init): Don't register deleted functions with
 965         gdbarch.
 966
 967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 970         (tilegx_unwind_pc): Delete.
 971         (tilegx_unwind_dummy_id): Delete.
 972         (tilegx_gdbarch_init): Don't register deleted functions with
 973         gdbarch.
 974
 975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 976
 977         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 978         (tic6x_dummy_id): Delete.
 979         (tic6x_gdbarch_init): Don't register deleted functions with
 980         gdbarch.
 981
 982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * sparc-tdep.c (sparc_unwind_pc): Delete.
 985         (sparc32_gdbarch_init): Don't register deleted function with
 986         gdbarch.
 987
 988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * sh-tdep.c (sh_unwind_sp): Delete.
 991         (sh_unwind_pc): Delete.
 992         (sh_dummy_id): Delete.
 993         (sh_gdbarch_init): Don't register deleted functions with
 994         gdbarch.
 995
 996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * score-tdep.c (score_unwind_sp): Delete.
 999         (score_unwind_pc): Delete.
1000         (score_dummy_id): Delete.
1001         (score_gdbarch_init): Don't register deleted functions with
1002         gdbarch.
1003
1004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * rx-tdep.c (rx_unwind_pc): Delete.
1007         (rx_unwind_sp): Delete.
1008         (rx_dummy_id): Delete.
1009         (rx_gdbarch_init): Don't register deleted functions with
1010         gdbarch.  Update comment.
1011
1012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1013
1014         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1015         (rs6000_dummy_id): Delete.
1016         (rs6000_gdbarch_init): Don't register deleted functions with
1017         gdbarch.
1018
1019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1020
1021         * or1k-tdep.c (or1k_dummy_id): Delete.
1022         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1023
1024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * nios2-tdep.c (nios2_dummy_id): Delete.
1027         (nios2_unwind_sp): Delete.
1028         (nios2_gdbarch_init): Don't register deleted functions with
1029         gdbarch.
1030
1031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * nds32-tdep.c (nds32_dummy_id): Delete.
1034         (nds32_unwind_pc): Delete.
1035         (nds32_unwind_sp): Delete.
1036         (nds32_gdbarch_init): Don't register deleted functions with
1037         gdbarch.
1038
1039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * msp430-tdep.c (msp430_unwind_pc): Delete.
1042         (msp430_unwind_sp): Delete.
1043         (msp430_dummy_id): Delete.
1044         (msp430_gdbarch_init): Don't register deleted functions with
1045         gdbarch.
1046
1047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1048
1049         * moxie-tdep.c (moxie_unwind_sp): Delete.
1050         (moxie_unwind_pc): Delete.
1051         (moxie_dummy_id): Delete.
1052         (moxie_gdbarch_init): Don't register deleted functions with
1053         gdbarch.
1054
1055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1058         (mn10300_unwind_pc): Delete.
1059         (mn10300_unwind_sp): Delete.
1060         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1061         mn10300_unwind_sp.
1062         (mn10300_frame_unwind_init): Don't register deleted functions with
1063         gdbarch.
1064
1065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * mep-tdep.c (mep_unwind_pc): Delete.
1068         (mep_unwind_sp): Delete.
1069         (mep_dummy_id): Delete.
1070         (mep_gdbarch_init): Don't register deleted functions with
1071         gdbarch.
1072
1073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1076         (m68hc11_unwind_sp): Delete.
1077         (m68hc11_gdbarch_init): Don't register deleted functions with
1078         gdbarch.
1079
1080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * m32r-tdep.c (m32r_unwind_sp): Delete.
1083         (m32r_unwind_pc): Delete.
1084         (m32r_dummy_id): Delete.
1085         (m32r_gdbarch_init): Don't register deleted functions with
1086         gdbarch.
1087
1088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * m32c-tdep.c (m32c_unwind_pc): Delete.
1091         (m32c_unwind_sp): Delete.
1092         (m32c_dummy_id): Delete.
1093         (m32c_gdbarch_init): Don't register deleted functions with
1094         gdbarch.
1095
1096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1099         (lm32_unwind_pc): Delete.
1100         (lm32_dummy_id): Delete.
1101         (lm32_gdbarch_init): Don't register deleted functions with
1102         gdbarch.
1103
1104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1107         (iq2000_unwind_pc): Delete.
1108         (iq2000_dummy_id): Delete.
1109         (iq2000_gdbarch_init): Don't register deleted functions with
1110         gdbarch.
1111
1112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1113
1114         * nds32-tdep.c (nds32_type_align): Delete.
1115         (nds32_push_dummy_call): Use type_align instead.
1116
1117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1118
1119         * arm-tdep.c (arm_type_align): Only handle vector override case.
1120         (arm_push_dummy_call): Use type_align.
1121         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1122
1123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1126         case.
1127         (pass_on_stack): Use type_align.
1128         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1129         function.
1130
1131 2019-04-23  Tom Tromey  <tromey@adacore.com>
1132
1133         * dwarf2read.c (line_header::file_name_at): Remove unused
1134         overload.
1135
1136 2019-04-23  Tom de Vries  <tdevries@suse.de>
1137
1138         PR gdb/24438
1139         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1140         invocation.
1141
1142
1143 2019-03-27  Ali Tamur  <tamur@google.com>
1144
1145         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1146         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1147         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1148         (dwarf_expr_context::get_addr_index): Likewise
1149         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1150         (symbol_needs_eval_context::get_addr_index): Likewise
1151         (disassemble_dwarf_expression): Add DW_OP_addrx
1152         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1153         (read_cutu_die_from_dwo): Update comment
1154         (skip_one_die): Add DW_FORM_addrx
1155         (read_attribute_value): Likewise
1156         (var_decode_location): Add DW_OP_addrx
1157         (dwarf2_const_value_attr): Add DW_FORM_addrx
1158         (dump_die_shallow): Likewise
1159         (dwarf2_fetch_constant_bytes): Likewise
1160         (decode_locdesc): Add DW_OP_addrx
1161         (skip_form_bytes): Add DW_FORM_addrx
1162
1163 2019-04-22  Ali Tamur  <tamur@google.com>
1164
1165         * MAINTAINERS (Write After Approval): Add self.
1166
1167 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1168
1169         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1170         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1171         (open_symbol_file_object): Likewise.
1172         (svr4_default_sos): Add info parameter.
1173         (svr4_read_so_list): Likewise.
1174         (svr4_current_sos_direct): Adjust functions calls to pass down
1175         info.
1176         (svr4_current_sos_1): Add info parameter.
1177         (svr4_current_sos): Call get_svr4_info, pass info down to
1178         svr4_current_sos_1.
1179         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1180         get_svr4_info.
1181         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1182         get_svr4_info.
1183         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1184         to get_svr4_info.
1185         (probes_table_remove_objfile_probes): Likewise.
1186         (register_solib_event_probe): Add info parameter.
1187         (solist_update_incremental): Pass info parameter down to
1188         svr4_read_so_list.
1189         (disable_probes_interface): Add info parameter.
1190         (svr4_handle_solib_event): Pass current_program_space to
1191         get_svr4_info.  Adjust disable_probes_interface cleanup.
1192         (svr4_create_probe_breakpoints): Add info parameter, pass it
1193         down to register_solib_event_probe.
1194         (svr4_create_solib_event_breakpoints): Add info parameter,
1195         pass it down to svr4_create_probe_breakpoints.
1196         (enable_break): Pass info down to
1197         svr4_create_solib_event_breakpoints.
1198         (svr4_solib_create_inferior_hook): Pass current_program_space to
1199         get_svr4_info.
1200         (svr4_clear_solib): Likewise.
1201
1202 2019-04-22  Pedro Alves  <palves@redhat.com>
1203
1204         * solib-svr4.c (svr4_free_objfile_observer): New.
1205         (probe_and_action::objfile): New field.
1206         (probes_table_htab_remove_objfile_probes)
1207         (probes_table_remove_objfile_probes): New functions.
1208         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1209         in the new probe_and_action.  Don't store the probe in 'lookup'.
1210         (svr4_create_probe_breakpoints): Pass objfile to
1211         register_solib_event_probe.
1212         (_initialize_svr4_solib): Register a free_objfile observer.
1213
1214 2019-04-19  Tom Tromey  <tom@tromey.com>
1215
1216         * common/queue.h: Remove.
1217
1218 2019-04-19  Tom Tromey  <tom@tromey.com>
1219
1220         * event-loop.c: Don't include "common/queue.h".
1221
1222 2019-04-19  Tom Tromey  <tom@tromey.com>
1223
1224         * remote.c (remote_target): Use delete.
1225         * remote-notif.h: Include <list>, not "common/queue.h".
1226         (notif_client_p): Remove typedef.
1227         (remote_notif_state): Add constructor, destructor, initializer.
1228         <notif_queue>: Now a std::list.
1229         (remote_notif_state_xfree): Don't declare.
1230         * remote-notif.c (remote_notif_process, handle_notification)
1231         (remote_notif_state_allocate): Update.
1232         (~remote_notif_state): Rename from remote_notif_state_xfree.
1233
1234 2019-04-19  Tom Tromey  <tom@tromey.com>
1235
1236         * symfile.c (reread_symbols): Update.
1237         * objfiles.c (objfile_register_static_link)
1238         (objfile_lookup_static_link): Update
1239         (~objfile) Don't delete static_links.
1240         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1241
1242 2019-04-19  Tom Tromey  <tom@tromey.com>
1243
1244         * type-stack.h (struct type_stack) <insert>: Constify string.
1245         * type-stack.c (type_stack::insert): Constify string.
1246         * gdbtypes.h (lookup_template_type): Update.
1247         (address_space_name_to_int): Update.
1248         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1249         const.
1250         (lookup_template_type): Make name const.
1251         * c-exp.y: Update rules.
1252         (lex_one_token, classify_name, classify_inner_name)
1253         (c_print_token): Update.
1254         * p-exp.y: Update rules.
1255         (yylex): Update.
1256         * f-exp.y: Update rules.
1257         (yylex): Update.
1258         * d-exp.y: Update rules.
1259         (lex_one_token, classify_name, classify_inner_name): Update.
1260         * parse.c (write_dollar_variable, copy_name): Return std::string.
1261         * parser-defs.h (copy_name): Change return type.
1262         * m2-exp.y: Update rules.
1263         (yylex): Update.
1264         * go-exp.y (lex_one_token): Update.
1265         Update rules.
1266         (classify_unsafe_function, classify_packaged_name)
1267         (classify_name, yylex): Update.
1268
1269 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1270
1271         * configure.ac: add --enable-source-highlight switch.
1272         * configure: Regenerate.
1273         * top.c (print_gdb_version): plumb --enable-source-highlight
1274         status to "show configuration".
1275
1276 2019-04-19  Tom Tromey  <tromey@adacore.com>
1277
1278         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1279         Check ADA_TYPE_P.
1280         (empty_record, ada_template_to_fixed_record_type_1)
1281         (template_to_static_fixed_type)
1282         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1283         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1284         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1285         macros.
1286
1287 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1288
1289         PR symtab/24423:
1290         * source.c (print_source_lines_base): Advance "iter" when a
1291         control character is seen.
1292
1293 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1294
1295         * inferior.h (struct infcall_suspend_state_deleter):
1296         Catch exception in destructor to avoid crash.
1297
1298 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1299
1300         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1301         close to the add_com "shell".
1302
1303 2019-04-18  Tom Tromey  <tromey@adacore.com>
1304
1305         * process-stratum-target.h (class process_stratum_target)
1306         <stratum>: Add "final".
1307
1308 2019-04-17  Tom Tromey  <tromey@adacore.com>
1309
1310         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1311         against nullptr before use.
1312
1313 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1314
1315         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1316
1317 2019-04-17  Jim Wilson  <jimw@sifive.com>
1318             Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1321         code read might fail, assume 4-byte breakpoint in that case.
1322
1323 2019-04-15  Leszek Swirski  <leszeks@google.com>
1324
1325         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1326         rather than a hand-rolled POD check when checking for forced MEMORY
1327         classification.
1328
1329 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1330
1331         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1332         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1333         function.
1334         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1335         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1336         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1337         declaration.
1338
1339 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1340
1341         * aarch64-linux-nat.c
1342         (aarch64_linux_nat_target::thread_architecture): Add override.
1343         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1344         each VQ.
1345
1346 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1347
1348         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1349
1350 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1353         target types of size 96-bits, add some additional comments, and
1354         check that the builtin type we found was the correct size.
1355
1356 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1357
1358         * utils.c (prompt_for_continue): Don't restore the styling at the
1359         end, as applied_style has the wrong value.  This fixes styling in
1360         long lists of file names that are interrupted by the "Continue?"
1361         prompt.
1362
1363 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1366         * c-lang.c (c_language_defn): Likewise.
1367         (cplus_language_defn): Likewise.
1368         (asm_language_defn): Likewise.
1369         (minimal_language_defn): Likewise.
1370         * d-lang.c (d_language_defn): Likewise.
1371         * f-lang.c (f_language_defn): Likewise.
1372         * go-lang.c (go_language_defn): Likewise.
1373         * language.c (unknown_language_defn): Likewise.
1374         (auto_language_defn): Likewise.
1375         * language.h (struct language_defn): Remove la_magic field.
1376         (LANG_MAGIC): Delete.
1377         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1378         * objc-lang.c (objc_language_defn): Likewise.
1379         * opencl-lang.c (opencl_language_defn): Likewise.
1380         * p-lang.c (pascal_language_defn): Likewise.
1381         * rust-lang.c (rust_language_defn): Likewise.
1382
1383 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * riscv-tdep.c (riscv_type_align): New function.
1386         (riscv_type_alignment): Delete.
1387         (riscv_arg_location): Use 'type_align'.
1388         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1389
1390 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * gdbtypes.c (type_align): A struct with no non-static fields also
1393         has alignment of 1.
1394
1395 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1396
1397         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1398         component to 0.
1399         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1400         member.
1401         (riscv_struct_info::analyse): New implementation using new
1402         analyse_inner member function.
1403         (riscv_struct_info::field_offset): New member function.
1404         (riscv_struct_info::m_offsets): New member variable.
1405         (riscv_struct_info::analyse_inner): New private member function,
1406         takes the old implementation of riscv_struct_info::analyse but
1407         extended to track field offsets.
1408         (riscv_call_arg_struct): Update the struct folding special cases
1409         to handle cases where empty C++ structs, which are non-zero
1410         length, are found.
1411         (riscv_arg_location): Initialise the length of each location, a
1412         non-zero length now indicates the location is in use.
1413         (riscv_push_dummy_call): Allow for the first location having a
1414         non-zero offset when setting up arguments.
1415         (riscv_return_value): Likewise, but for return values.
1416
1417 2019-04-11  Tom Tromey  <tromey@adacore.com>
1418
1419         * utils.c (internal_vproblem): Make "msg" const.
1420
1421 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1422
1423         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1424         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1425         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1426         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1427
1428 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1429
1430         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1431         function.
1432         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1433         of amd64_collect_native_gregset.
1434         (amd64_linux_nat_target::store_registers): Likewise.
1435
1436 2019-04-10  Tom Tromey  <tom@tromey.com>
1437
1438         * symtab.c (lookup_global_symbol_from_objfile)
1439         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1440         * objfiles.h (class separate_debug_iterator): New.
1441         (class separate_debug_range): New.
1442         (struct objfile) <separate_debug_objfiles>: New method.
1443         (objfile_separate_debug_iterate): Don't declare.
1444         * objfiles.c (separate_debug_iterator::operator++): Rename from
1445         objfile_separate_debug_iterate.
1446         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1447         iterator.
1448         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1449         iterator.
1450
1451 2019-04-10  Tom Tromey  <tom@tromey.com>
1452
1453         * symfile.c (reread_symbols): Remove old comment.
1454         * objfiles.c (free_all_objfiles): Fix a typo.
1455
1456 2019-04-10  Tom Tromey  <tom@tromey.com>
1457
1458         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1459         * minsyms.c (lookup_minimal_symbol): Use foreach.
1460         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1461         (lookup_minimal_symbol_solib_trampoline): Likewise.
1462         * symfile.c (reread_symbols): Use foreach.
1463
1464 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1465             Tom Tromey  <tromey@adacore.com>
1466
1467         PR rust/24414:
1468         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1469         (rust_lex_int_test): Change "value" to be LONGEST.
1470         (rust_lex_tests): Add test for long integer literal.
1471
1472 2019-04-09  Tom Tromey  <tromey@adacore.com>
1473
1474         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1475         to bool.
1476         (extended_remote_target::attach): Update.
1477         (remote_target::remote_notice_new_inferior): Update.
1478         (remote_target::add_current_inferior_and_thread): Update.
1479         * inferior.c (exit_inferior_1): Use "false".
1480         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1481
1482 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1483
1484         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1485         the "start" command.
1486
1487 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1488
1489         * python/py-inferior.c (infpy_thread_from_thread_handle):
1490         Adjust comments to reflect renaming of thread_from_thread_handle
1491         to thread_from_handle.  Adjust keywords.  Fix type error message.
1492         (inferior_object_methods): Add thread_from_handle.  Retain
1493         thread_from_thread_handle, but mark it as deprecated.
1494
1495 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1496
1497         * gdbthread.h (find_thread_by_handle): Revise declaration.
1498         * thread.c (find_thread_by_handle): Likewise.  Adjust
1499         implementation too.
1500         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1501         support for buffer objects as handles.
1502
1503 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1504
1505         * python/py-infthread.c (thpy_thread_handle): New function.
1506         (thread_object_methods): Register thpy_thread_handle.
1507
1508 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1509
1510         * gdbthread.h (thread_to_thread_handle): Declare.
1511         * thread.c (gdbtypes.h): Include.
1512         (thread_to_thread_handle): New function.
1513
1514         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1515         (target_thread_info_to_thread_handle): Declare.
1516         * target.c (target_thread_info_to_thread_handle): New function.
1517         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1518         * target-delegates.c: Regenerate.
1519
1520         * linux-thread-db.c (class thread_db_target): Add method
1521         thread_info_to_thread_handle.
1522         (thread_db_target::thread_info_to_thread_handle): Define.
1523         * remote.c (class remote_target): Add new method
1524         thread_info_to_thread_handle.
1525         (remote_target::thread_info_to_thread_handle): Define.
1526
1527 2019-04-08  Pedro Alves  <palves@redhat.com>
1528
1529         * common/common-exceptions.c (throw_exception): Don't create
1530         named object to throw; throw directly.
1531         (throw_it): Likewise.  Don't initialize gdb_exception::message
1532         here, with new; pass FMT and AP to the ctor instead.
1533         * common/common-exceptions.h: Include <string>.
1534         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1535         const char *, va_list)): New ctor.  Use std::make_shared.
1536         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1537         errors)): Delete.
1538         (gdb_exception_error::gdb_exception_error(enum errors, const char
1539         *, va_list)): New.
1540         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1541         Add assertion.
1542         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1543         errors)): Delete.
1544         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1545         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1546         Add assertion.
1547
1548 2019-04-08  Tom Tromey  <tom@tromey.com>
1549
1550         * valops.c (value_rtti_indirect_type): Replace throw_exception
1551         with throw.
1552         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1553         with throw.
1554         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1555         throw.
1556         * target.c (target_translate_tls_address): Replace throw_exception
1557         with throw.
1558         * stack.c (frame_apply_command_count): Replace throw_exception
1559         with throw.
1560         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1561         throw.
1562         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1563         with throw.
1564         * rs6000-tdep.c (rs6000_frame_cache)
1565         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1566         * remote.c: Replace throw_exception with throw.
1567         * record-full.c (record_full_message, record_full_wait_1)
1568         (record_full_restore): Replace throw_exception with throw.
1569         * record-btrace.c:
1570         (get_thread_current_frame_id, record_btrace_start_replaying)
1571         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1572         (cmd_record_btrace_start): Replace throw_exception with throw.
1573         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1574         throw.
1575         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1576         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1577         * linespec.c:
1578         (find_linespec_symbols): Replace throw_exception with throw.
1579         * infrun.c (displaced_step_prepare, resume): Replace
1580         throw_exception with throw.
1581         * infcmd.c (post_create_inferior): Replace throw_exception with
1582         throw.
1583         * inf-loop.c (inferior_event_handler): Replace throw_exception
1584         with throw.
1585         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1586         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1587         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1588         (get_prev_frame_always, get_frame_pc_if_available)
1589         (get_frame_address_in_block_if_available, get_frame_language):
1590         Replace throw_exception with throw.
1591         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1592         throw_exception with throw.
1593         * eval.c (fetch_subexp_value, evaluate_var_value)
1594         (evaluate_funcall, evaluate_subexp_standard): Replace
1595         throw_exception with throw.
1596         * dwarf2loc.c (call_site_find_chain)
1597         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1598         Replace throw_exception with throw.
1599         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1600         with throw.
1601         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1602         throw.
1603         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1604         * completer.c (complete_line_internal): Replace throw_exception
1605         with throw.
1606         * compile/compile-object-run.c (compile_object_run): Replace
1607         throw_exception with throw.
1608         * cli/cli-script.c (process_next_line): Replace throw_exception
1609         with throw.
1610         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1611         (btrace_enable, btrace_maint_update_pt_packets): Replace
1612         throw_exception with throw.
1613         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1614         throw_exception with throw.
1615         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1616         throw_exception with throw.
1617         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1618         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1619         * aarch64-tdep.c (aarch64_make_prologue_cache)
1620         (aarch64_make_stub_cache): Replace throw_exception with throw.
1621
1622 2019-04-08  Tom Tromey  <tom@tromey.com>
1623
1624         * common/common-exceptions.c (throw_exception): Rename from
1625         throw_exception_cxx.  Remove old copy.  Make argument const.
1626         (throw_it): Create and throw exception objects directly.
1627         * common/common-exceptions.h (throw_exception): Make argument
1628         const.
1629         (struct gdb_exception_error): Add constructor.
1630         (struct gdb_exception_quit): Add constructor.
1631
1632 2019-04-08  Tom Tromey  <tom@tromey.com>
1633
1634         * common/common-exceptions.h (exception_rethrow): Don't declare.
1635         (TRY_SJLJ): Update comment.
1636         (TRY, CATCH, END_CATCH): Remove.
1637         * common/common-exceptions.c (exception_rethrow): Remove.
1638
1639 2019-04-08  Tom Tromey  <tom@tromey.com>
1640
1641         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1642         Remove.
1643         (gdb_exception_error): Rename from
1644         gdb_exception_RETURN_MASK_ERROR.
1645         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1646         (gdb_quit_bad_alloc): Update.
1647         * aarch64-tdep.c: Update.
1648         * ada-lang.c: Update.
1649         * ada-typeprint.c: Update.
1650         * ada-valprint.c: Update.
1651         * amd64-tdep.c: Update.
1652         * arch-utils.c: Update.
1653         * break-catch-throw.c: Update.
1654         * breakpoint.c: Update.
1655         * btrace.c: Update.
1656         * c-varobj.c: Update.
1657         * cli/cli-cmds.c: Update.
1658         * cli/cli-interp.c: Update.
1659         * cli/cli-script.c: Update.
1660         * common/common-exceptions.c: Update.
1661         * common/new-op.c: Update.
1662         * common/selftest.c: Update.
1663         * compile/compile-c-symbols.c: Update.
1664         * compile/compile-cplus-symbols.c: Update.
1665         * compile/compile-object-load.c: Update.
1666         * compile/compile-object-run.c: Update.
1667         * completer.c: Update.
1668         * corelow.c: Update.
1669         * cp-abi.c: Update.
1670         * cp-support.c: Update.
1671         * cp-valprint.c: Update.
1672         * darwin-nat.c: Update.
1673         * disasm-selftests.c: Update.
1674         * dtrace-probe.c: Update.
1675         * dwarf-index-cache.c: Update.
1676         * dwarf-index-write.c: Update.
1677         * dwarf2-frame-tailcall.c: Update.
1678         * dwarf2-frame.c: Update.
1679         * dwarf2loc.c: Update.
1680         * dwarf2read.c: Update.
1681         * eval.c: Update.
1682         * event-loop.c: Update.
1683         * event-top.c: Update.
1684         * exec.c: Update.
1685         * f-valprint.c: Update.
1686         * fbsd-tdep.c: Update.
1687         * frame-unwind.c: Update.
1688         * frame.c: Update.
1689         * gdbtypes.c: Update.
1690         * gnu-v3-abi.c: Update.
1691         * guile/guile-internal.h: Update.
1692         * guile/scm-block.c: Update.
1693         * guile/scm-breakpoint.c: Update.
1694         * guile/scm-cmd.c: Update.
1695         * guile/scm-disasm.c: Update.
1696         * guile/scm-frame.c: Update.
1697         * guile/scm-lazy-string.c: Update.
1698         * guile/scm-math.c: Update.
1699         * guile/scm-param.c: Update.
1700         * guile/scm-ports.c: Update.
1701         * guile/scm-pretty-print.c: Update.
1702         * guile/scm-symbol.c: Update.
1703         * guile/scm-symtab.c: Update.
1704         * guile/scm-type.c: Update.
1705         * guile/scm-value.c: Update.
1706         * i386-linux-tdep.c: Update.
1707         * i386-tdep.c: Update.
1708         * inf-loop.c: Update.
1709         * infcall.c: Update.
1710         * infcmd.c: Update.
1711         * infrun.c: Update.
1712         * jit.c: Update.
1713         * language.c: Update.
1714         * linespec.c: Update.
1715         * linux-fork.c: Update.
1716         * linux-nat.c: Update.
1717         * linux-tdep.c: Update.
1718         * linux-thread-db.c: Update.
1719         * main.c: Update.
1720         * mi/mi-cmd-break.c: Update.
1721         * mi/mi-cmd-stack.c: Update.
1722         * mi/mi-interp.c: Update.
1723         * mi/mi-main.c: Update.
1724         * objc-lang.c: Update.
1725         * p-valprint.c: Update.
1726         * parse.c: Update.
1727         * ppc-linux-tdep.c: Update.
1728         * printcmd.c: Update.
1729         * python/py-arch.c: Update.
1730         * python/py-breakpoint.c: Update.
1731         * python/py-cmd.c: Update.
1732         * python/py-finishbreakpoint.c: Update.
1733         * python/py-frame.c: Update.
1734         * python/py-framefilter.c: Update.
1735         * python/py-gdb-readline.c: Update.
1736         * python/py-inferior.c: Update.
1737         * python/py-infthread.c: Update.
1738         * python/py-lazy-string.c: Update.
1739         * python/py-linetable.c: Update.
1740         * python/py-objfile.c: Update.
1741         * python/py-param.c: Update.
1742         * python/py-prettyprint.c: Update.
1743         * python/py-progspace.c: Update.
1744         * python/py-record-btrace.c: Update.
1745         * python/py-record.c: Update.
1746         * python/py-symbol.c: Update.
1747         * python/py-type.c: Update.
1748         * python/py-unwind.c: Update.
1749         * python/py-utils.c: Update.
1750         * python/py-value.c: Update.
1751         * python/python.c: Update.
1752         * record-btrace.c: Update.
1753         * record-full.c: Update.
1754         * remote-fileio.c: Update.
1755         * remote.c: Update.
1756         * riscv-tdep.c: Update.
1757         * rs6000-aix-tdep.c: Update.
1758         * rs6000-tdep.c: Update.
1759         * rust-exp.y: Update.
1760         * rust-lang.c: Update.
1761         * s390-tdep.c: Update.
1762         * selftest-arch.c: Update.
1763         * solib-dsbt.c: Update.
1764         * solib-frv.c: Update.
1765         * solib-spu.c: Update.
1766         * solib-svr4.c: Update.
1767         * solib.c: Update.
1768         * sparc64-linux-tdep.c: Update.
1769         * stack.c: Update.
1770         * symfile-mem.c: Update.
1771         * symmisc.c: Update.
1772         * target.c: Update.
1773         * thread.c: Update.
1774         * top.c: Update.
1775         * tracefile-tfile.c: Update.
1776         * tui/tui.c: Update.
1777         * typeprint.c: Update.
1778         * unittests/cli-utils-selftests.c: Update.
1779         * unittests/parse-connection-spec-selftests.c: Update.
1780         * valops.c: Update.
1781         * valprint.c: Update.
1782         * value.c: Update.
1783         * varobj.c: Update.
1784         * windows-nat.c: Update.
1785         * x86-linux-nat.c: Update.
1786         * xml-support.c: Update.
1787
1788 2019-04-08  Tom Tromey  <tom@tromey.com>
1789
1790         * xml-support.c: Use C++ exception handling.
1791         * x86-linux-nat.c: Use C++ exception handling.
1792         * windows-nat.c: Use C++ exception handling.
1793         * varobj.c: Use C++ exception handling.
1794         * value.c: Use C++ exception handling.
1795         * valprint.c: Use C++ exception handling.
1796         * valops.c: Use C++ exception handling.
1797         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1798         handling.
1799         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1800         * typeprint.c: Use C++ exception handling.
1801         * tui/tui.c: Use C++ exception handling.
1802         * tracefile-tfile.c: Use C++ exception handling.
1803         * top.c: Use C++ exception handling.
1804         * thread.c: Use C++ exception handling.
1805         * target.c: Use C++ exception handling.
1806         * symmisc.c: Use C++ exception handling.
1807         * symfile-mem.c: Use C++ exception handling.
1808         * stack.c: Use C++ exception handling.
1809         * sparc64-linux-tdep.c: Use C++ exception handling.
1810         * solib.c: Use C++ exception handling.
1811         * solib-svr4.c: Use C++ exception handling.
1812         * solib-spu.c: Use C++ exception handling.
1813         * solib-frv.c: Use C++ exception handling.
1814         * solib-dsbt.c: Use C++ exception handling.
1815         * selftest-arch.c: Use C++ exception handling.
1816         * s390-tdep.c: Use C++ exception handling.
1817         * rust-lang.c: Use C++ exception handling.
1818         * rust-exp.y: Use C++ exception handling.
1819         * rs6000-tdep.c: Use C++ exception handling.
1820         * rs6000-aix-tdep.c: Use C++ exception handling.
1821         * riscv-tdep.c: Use C++ exception handling.
1822         * remote.c: Use C++ exception handling.
1823         * remote-fileio.c: Use C++ exception handling.
1824         * record-full.c: Use C++ exception handling.
1825         * record-btrace.c: Use C++ exception handling.
1826         * python/python.c: Use C++ exception handling.
1827         * python/py-value.c: Use C++ exception handling.
1828         * python/py-utils.c: Use C++ exception handling.
1829         * python/py-unwind.c: Use C++ exception handling.
1830         * python/py-type.c: Use C++ exception handling.
1831         * python/py-symbol.c: Use C++ exception handling.
1832         * python/py-record.c: Use C++ exception handling.
1833         * python/py-record-btrace.c: Use C++ exception handling.
1834         * python/py-progspace.c: Use C++ exception handling.
1835         * python/py-prettyprint.c: Use C++ exception handling.
1836         * python/py-param.c: Use C++ exception handling.
1837         * python/py-objfile.c: Use C++ exception handling.
1838         * python/py-linetable.c: Use C++ exception handling.
1839         * python/py-lazy-string.c: Use C++ exception handling.
1840         * python/py-infthread.c: Use C++ exception handling.
1841         * python/py-inferior.c: Use C++ exception handling.
1842         * python/py-gdb-readline.c: Use C++ exception handling.
1843         * python/py-framefilter.c: Use C++ exception handling.
1844         * python/py-frame.c: Use C++ exception handling.
1845         * python/py-finishbreakpoint.c: Use C++ exception handling.
1846         * python/py-cmd.c: Use C++ exception handling.
1847         * python/py-breakpoint.c: Use C++ exception handling.
1848         * python/py-arch.c: Use C++ exception handling.
1849         * printcmd.c: Use C++ exception handling.
1850         * ppc-linux-tdep.c: Use C++ exception handling.
1851         * parse.c: Use C++ exception handling.
1852         * p-valprint.c: Use C++ exception handling.
1853         * objc-lang.c: Use C++ exception handling.
1854         * mi/mi-main.c: Use C++ exception handling.
1855         * mi/mi-interp.c: Use C++ exception handling.
1856         * mi/mi-cmd-stack.c: Use C++ exception handling.
1857         * mi/mi-cmd-break.c: Use C++ exception handling.
1858         * main.c: Use C++ exception handling.
1859         * linux-thread-db.c: Use C++ exception handling.
1860         * linux-tdep.c: Use C++ exception handling.
1861         * linux-nat.c: Use C++ exception handling.
1862         * linux-fork.c: Use C++ exception handling.
1863         * linespec.c: Use C++ exception handling.
1864         * language.c: Use C++ exception handling.
1865         * jit.c: Use C++ exception handling.
1866         * infrun.c: Use C++ exception handling.
1867         * infcmd.c: Use C++ exception handling.
1868         * infcall.c: Use C++ exception handling.
1869         * inf-loop.c: Use C++ exception handling.
1870         * i386-tdep.c: Use C++ exception handling.
1871         * i386-linux-tdep.c: Use C++ exception handling.
1872         * guile/scm-value.c: Use C++ exception handling.
1873         * guile/scm-type.c: Use C++ exception handling.
1874         * guile/scm-symtab.c: Use C++ exception handling.
1875         * guile/scm-symbol.c: Use C++ exception handling.
1876         * guile/scm-pretty-print.c: Use C++ exception handling.
1877         * guile/scm-ports.c: Use C++ exception handling.
1878         * guile/scm-param.c: Use C++ exception handling.
1879         * guile/scm-math.c: Use C++ exception handling.
1880         * guile/scm-lazy-string.c: Use C++ exception handling.
1881         * guile/scm-frame.c: Use C++ exception handling.
1882         * guile/scm-disasm.c: Use C++ exception handling.
1883         * guile/scm-cmd.c: Use C++ exception handling.
1884         * guile/scm-breakpoint.c: Use C++ exception handling.
1885         * guile/scm-block.c: Use C++ exception handling.
1886         * guile/guile-internal.h: Use C++ exception handling.
1887         * gnu-v3-abi.c: Use C++ exception handling.
1888         * gdbtypes.c: Use C++ exception handling.
1889         * frame.c: Use C++ exception handling.
1890         * frame-unwind.c: Use C++ exception handling.
1891         * fbsd-tdep.c: Use C++ exception handling.
1892         * f-valprint.c: Use C++ exception handling.
1893         * exec.c: Use C++ exception handling.
1894         * event-top.c: Use C++ exception handling.
1895         * event-loop.c: Use C++ exception handling.
1896         * eval.c: Use C++ exception handling.
1897         * dwarf2read.c: Use C++ exception handling.
1898         * dwarf2loc.c: Use C++ exception handling.
1899         * dwarf2-frame.c: Use C++ exception handling.
1900         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1901         * dwarf-index-write.c: Use C++ exception handling.
1902         * dwarf-index-cache.c: Use C++ exception handling.
1903         * dtrace-probe.c: Use C++ exception handling.
1904         * disasm-selftests.c: Use C++ exception handling.
1905         * darwin-nat.c: Use C++ exception handling.
1906         * cp-valprint.c: Use C++ exception handling.
1907         * cp-support.c: Use C++ exception handling.
1908         * cp-abi.c: Use C++ exception handling.
1909         * corelow.c: Use C++ exception handling.
1910         * completer.c: Use C++ exception handling.
1911         * compile/compile-object-run.c: Use C++ exception handling.
1912         * compile/compile-object-load.c: Use C++ exception handling.
1913         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1914         * compile/compile-c-symbols.c: Use C++ exception handling.
1915         * common/selftest.c: Use C++ exception handling.
1916         * common/new-op.c: Use C++ exception handling.
1917         * cli/cli-script.c: Use C++ exception handling.
1918         * cli/cli-interp.c: Use C++ exception handling.
1919         * cli/cli-cmds.c: Use C++ exception handling.
1920         * c-varobj.c: Use C++ exception handling.
1921         * btrace.c: Use C++ exception handling.
1922         * breakpoint.c: Use C++ exception handling.
1923         * break-catch-throw.c: Use C++ exception handling.
1924         * arch-utils.c: Use C++ exception handling.
1925         * amd64-tdep.c: Use C++ exception handling.
1926         * ada-valprint.c: Use C++ exception handling.
1927         * ada-typeprint.c: Use C++ exception handling.
1928         * ada-lang.c: Use C++ exception handling.
1929         * aarch64-tdep.c: Use C++ exception handling.
1930
1931 2019-04-08  Tom Tromey  <tom@tromey.com>
1932
1933         * xml-support.c (gdb_xml_parser::parse): Update.
1934         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1935         * value.c (show_convenience): Update.
1936         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1937         (test_parse_flags_qcs): Update.
1938         * thread.c (thr_try_catch_cmd): Update.
1939         * target.c (target_translate_tls_address): Update.
1940         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1941         (info_frame_command_core, frame_apply_command_count): Update.
1942         * rust-exp.y (rust_lex_exception_test): Update.
1943         * riscv-tdep.c (riscv_print_one_register_info): Update.
1944         * remote.c (remote_target::enable_btrace): Update.
1945         * record-btrace.c (record_btrace_enable_warn): Update.
1946         * python/py-utils.c (gdbpy_convert_exception): Update.
1947         * printcmd.c (do_one_display, print_variable_and_value): Update.
1948         * mi/mi-main.c (mi_print_exception): Update.
1949         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1950         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1951         * linux-nat.c (linux_nat_target::attach): Update.
1952         * linux-fork.c (class scoped_switch_fork_info): Update.
1953         * infrun.c (displaced_step_prepare): Update.
1954         * infcall.c (call_function_by_hand_dummy): Update.
1955         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1956         * gnu-v3-abi.c (print_one_vtable): Update.
1957         * frame.c (get_prev_frame_always): Update.
1958         * f-valprint.c (info_common_command_for_block): Update.
1959         * exec.c (try_open_exec_file): Update.
1960         * exceptions.c (print_exception, exception_print)
1961         (exception_fprintf, exception_print_same): Update.
1962         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1963         * dwarf-index-cache.c (index_cache::store)
1964         (index_cache::lookup_gdb_index): Update.
1965         * darwin-nat.c (maybe_cache_shell): Update.
1966         * cp-valprint.c (cp_print_value_fields): Update.
1967         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1968         (gcc_cplus_symbol_address): Update.
1969         * compile/compile-c-symbols.c (gcc_convert_symbol)
1970         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1971         * common/selftest.c: Update.
1972         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1973         a std::string.
1974         (exception_try_scope_entry, exception_try_scope_exit): Don't
1975         declare.
1976         (struct exception_try_scope): Remove.
1977         (TRY): Don't use exception_try_scope.
1978         (struct gdb_exception): Add constructor, operator=.
1979         <what>: New method.
1980         (struct gdb_exception_RETURN_MASK_ALL)
1981         (struct gdb_exception_RETURN_MASK_ERROR)
1982         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1983         (struct gdb_quit_bad_alloc): Update.
1984         * common/common-exceptions.c (exception_none): Change
1985         initializer.
1986         (struct catcher) <state, exception>: Initialize inline.
1987         <prev>: Remove member.
1988         (current_catcher): Remove.
1989         (catchers): New global.
1990         (exceptions_state_mc_init): Simplify.
1991         (catcher_pop): Remove.
1992         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1993         (try_scope_depth, exception_try_scope_entry)
1994         (exception_try_scope_exit): Remove.
1995         (throw_exception_sjlj): Update.
1996         (exception_messages, exception_messages_size): Remove.
1997         (throw_it): Simplify.
1998         (gdb_exception_sliced_copy): Remove.
1999         (throw_exception_cxx): Update.
2000         * cli/cli-script.c (script_from_file): Update.
2001         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2002         Update.
2003         * ada-valprint.c (ada_val_print): Update.
2004         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2005         (create_excep_cond_exprs): Update.
2006
2007 2019-04-08  Tom Tromey  <tom@tromey.com>
2008
2009         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2010         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2011         (TRY, CATCH, END_CATCH): Remove some definitions.
2012         * common/common-exceptions.c: Don't use GDB_XCPT.
2013         (catcher_list_size): Remove.
2014         (throw_exception, throw_it): Simplify.
2015
2016 2019-04-05  Tom Tromey  <tom@tromey.com>
2017
2018         Revert the header-sorting patch.
2019         * ft32-tdep.c: Revert.
2020         * frv-tdep.c: Revert.
2021         * frv-linux-tdep.c: Revert.
2022         * frame.c: Revert.
2023         * frame-unwind.c: Revert.
2024         * frame-base.c: Revert.
2025         * fork-child.c: Revert.
2026         * findvar.c: Revert.
2027         * findcmd.c: Revert.
2028         * filesystem.c: Revert.
2029         * filename-seen-cache.h: Revert.
2030         * filename-seen-cache.c: Revert.
2031         * fbsd-tdep.c: Revert.
2032         * fbsd-nat.h: Revert.
2033         * fbsd-nat.c: Revert.
2034         * f-valprint.c: Revert.
2035         * f-typeprint.c: Revert.
2036         * f-lang.c: Revert.
2037         * extension.h: Revert.
2038         * extension.c: Revert.
2039         * extension-priv.h: Revert.
2040         * expprint.c: Revert.
2041         * exec.h: Revert.
2042         * exec.c: Revert.
2043         * exceptions.c: Revert.
2044         * event-top.c: Revert.
2045         * event-loop.c: Revert.
2046         * eval.c: Revert.
2047         * elfread.c: Revert.
2048         * dwarf2read.h: Revert.
2049         * dwarf2read.c: Revert.
2050         * dwarf2loc.c: Revert.
2051         * dwarf2expr.h: Revert.
2052         * dwarf2expr.c: Revert.
2053         * dwarf2-frame.c: Revert.
2054         * dwarf2-frame-tailcall.c: Revert.
2055         * dwarf-index-write.h: Revert.
2056         * dwarf-index-write.c: Revert.
2057         * dwarf-index-common.c: Revert.
2058         * dwarf-index-cache.h: Revert.
2059         * dwarf-index-cache.c: Revert.
2060         * dummy-frame.c: Revert.
2061         * dtrace-probe.c: Revert.
2062         * disasm.h: Revert.
2063         * disasm.c: Revert.
2064         * disasm-selftests.c: Revert.
2065         * dictionary.c: Revert.
2066         * dicos-tdep.c: Revert.
2067         * demangle.c: Revert.
2068         * dcache.h: Revert.
2069         * dcache.c: Revert.
2070         * darwin-nat.h: Revert.
2071         * darwin-nat.c: Revert.
2072         * darwin-nat-info.c: Revert.
2073         * d-valprint.c: Revert.
2074         * d-namespace.c: Revert.
2075         * d-lang.c: Revert.
2076         * ctf.c: Revert.
2077         * csky-tdep.c: Revert.
2078         * csky-linux-tdep.c: Revert.
2079         * cris-tdep.c: Revert.
2080         * cris-linux-tdep.c: Revert.
2081         * cp-valprint.c: Revert.
2082         * cp-support.c: Revert.
2083         * cp-namespace.c: Revert.
2084         * cp-abi.c: Revert.
2085         * corelow.c: Revert.
2086         * corefile.c: Revert.
2087         * continuations.c: Revert.
2088         * completer.h: Revert.
2089         * completer.c: Revert.
2090         * complaints.c: Revert.
2091         * coffread.c: Revert.
2092         * coff-pe-read.c: Revert.
2093         * cli-out.h: Revert.
2094         * cli-out.c: Revert.
2095         * charset.c: Revert.
2096         * c-varobj.c: Revert.
2097         * c-valprint.c: Revert.
2098         * c-typeprint.c: Revert.
2099         * c-lang.c: Revert.
2100         * buildsym.c: Revert.
2101         * buildsym-legacy.c: Revert.
2102         * build-id.h: Revert.
2103         * build-id.c: Revert.
2104         * btrace.c: Revert.
2105         * bsd-uthread.c: Revert.
2106         * breakpoint.h: Revert.
2107         * breakpoint.c: Revert.
2108         * break-catch-throw.c: Revert.
2109         * break-catch-syscall.c: Revert.
2110         * break-catch-sig.c: Revert.
2111         * blockframe.c: Revert.
2112         * block.c: Revert.
2113         * bfin-tdep.c: Revert.
2114         * bfin-linux-tdep.c: Revert.
2115         * bfd-target.c: Revert.
2116         * bcache.c: Revert.
2117         * ax-general.c: Revert.
2118         * ax-gdb.h: Revert.
2119         * ax-gdb.c: Revert.
2120         * avr-tdep.c: Revert.
2121         * auxv.c: Revert.
2122         * auto-load.c: Revert.
2123         * arm-wince-tdep.c: Revert.
2124         * arm-tdep.c: Revert.
2125         * arm-symbian-tdep.c: Revert.
2126         * arm-pikeos-tdep.c: Revert.
2127         * arm-obsd-tdep.c: Revert.
2128         * arm-nbsd-tdep.c: Revert.
2129         * arm-nbsd-nat.c: Revert.
2130         * arm-linux-tdep.c: Revert.
2131         * arm-linux-nat.c: Revert.
2132         * arm-fbsd-tdep.c: Revert.
2133         * arm-fbsd-nat.c: Revert.
2134         * arm-bsd-tdep.c: Revert.
2135         * arch-utils.c: Revert.
2136         * arc-tdep.c: Revert.
2137         * arc-newlib-tdep.c: Revert.
2138         * annotate.h: Revert.
2139         * annotate.c: Revert.
2140         * amd64-windows-tdep.c: Revert.
2141         * amd64-windows-nat.c: Revert.
2142         * amd64-tdep.c: Revert.
2143         * amd64-sol2-tdep.c: Revert.
2144         * amd64-obsd-tdep.c: Revert.
2145         * amd64-obsd-nat.c: Revert.
2146         * amd64-nbsd-tdep.c: Revert.
2147         * amd64-nbsd-nat.c: Revert.
2148         * amd64-nat.c: Revert.
2149         * amd64-linux-tdep.c: Revert.
2150         * amd64-linux-nat.c: Revert.
2151         * amd64-fbsd-tdep.c: Revert.
2152         * amd64-fbsd-nat.c: Revert.
2153         * amd64-dicos-tdep.c: Revert.
2154         * amd64-darwin-tdep.c: Revert.
2155         * amd64-bsd-nat.c: Revert.
2156         * alpha-tdep.c: Revert.
2157         * alpha-obsd-tdep.c: Revert.
2158         * alpha-nbsd-tdep.c: Revert.
2159         * alpha-mdebug-tdep.c: Revert.
2160         * alpha-linux-tdep.c: Revert.
2161         * alpha-linux-nat.c: Revert.
2162         * alpha-bsd-tdep.c: Revert.
2163         * alpha-bsd-nat.c: Revert.
2164         * aix-thread.c: Revert.
2165         * agent.c: Revert.
2166         * addrmap.c: Revert.
2167         * ada-varobj.c: Revert.
2168         * ada-valprint.c: Revert.
2169         * ada-typeprint.c: Revert.
2170         * ada-tasks.c: Revert.
2171         * ada-lang.c: Revert.
2172         * aarch64-tdep.c: Revert.
2173         * aarch64-ravenscar-thread.c: Revert.
2174         * aarch64-newlib-tdep.c: Revert.
2175         * aarch64-linux-tdep.c: Revert.
2176         * aarch64-linux-nat.c: Revert.
2177         * aarch64-fbsd-tdep.c: Revert.
2178         * aarch64-fbsd-nat.c: Revert.
2179         * aarch32-linux-nat.c: Revert.
2180
2181 2019-04-05  Tom Tromey  <tom@tromey.com>
2182
2183         * ft32-tdep.c: Sort headers.
2184         * frv-tdep.c: Sort headers.
2185         * frv-linux-tdep.c: Sort headers.
2186         * frame.c: Sort headers.
2187         * frame-unwind.c: Sort headers.
2188         * frame-base.c: Sort headers.
2189         * fork-child.c: Sort headers.
2190         * findvar.c: Sort headers.
2191         * findcmd.c: Sort headers.
2192         * filesystem.c: Sort headers.
2193         * filename-seen-cache.h: Sort headers.
2194         * filename-seen-cache.c: Sort headers.
2195         * fbsd-tdep.c: Sort headers.
2196         * fbsd-nat.h: Sort headers.
2197         * fbsd-nat.c: Sort headers.
2198         * f-valprint.c: Sort headers.
2199         * f-typeprint.c: Sort headers.
2200         * f-lang.c: Sort headers.
2201         * extension.h: Sort headers.
2202         * extension.c: Sort headers.
2203         * extension-priv.h: Sort headers.
2204         * expprint.c: Sort headers.
2205         * exec.h: Sort headers.
2206         * exec.c: Sort headers.
2207         * exceptions.c: Sort headers.
2208         * event-top.c: Sort headers.
2209         * event-loop.c: Sort headers.
2210         * eval.c: Sort headers.
2211         * elfread.c: Sort headers.
2212         * dwarf2read.h: Sort headers.
2213         * dwarf2read.c: Sort headers.
2214         * dwarf2loc.c: Sort headers.
2215         * dwarf2expr.h: Sort headers.
2216         * dwarf2expr.c: Sort headers.
2217         * dwarf2-frame.c: Sort headers.
2218         * dwarf2-frame-tailcall.c: Sort headers.
2219         * dwarf-index-write.h: Sort headers.
2220         * dwarf-index-write.c: Sort headers.
2221         * dwarf-index-common.c: Sort headers.
2222         * dwarf-index-cache.h: Sort headers.
2223         * dwarf-index-cache.c: Sort headers.
2224         * dummy-frame.c: Sort headers.
2225         * dtrace-probe.c: Sort headers.
2226         * disasm.h: Sort headers.
2227         * disasm.c: Sort headers.
2228         * disasm-selftests.c: Sort headers.
2229         * dictionary.c: Sort headers.
2230         * dicos-tdep.c: Sort headers.
2231         * demangle.c: Sort headers.
2232         * dcache.h: Sort headers.
2233         * dcache.c: Sort headers.
2234         * darwin-nat.h: Sort headers.
2235         * darwin-nat.c: Sort headers.
2236         * darwin-nat-info.c: Sort headers.
2237         * d-valprint.c: Sort headers.
2238         * d-namespace.c: Sort headers.
2239         * d-lang.c: Sort headers.
2240         * ctf.c: Sort headers.
2241         * csky-tdep.c: Sort headers.
2242         * csky-linux-tdep.c: Sort headers.
2243         * cris-tdep.c: Sort headers.
2244         * cris-linux-tdep.c: Sort headers.
2245         * cp-valprint.c: Sort headers.
2246         * cp-support.c: Sort headers.
2247         * cp-namespace.c: Sort headers.
2248         * cp-abi.c: Sort headers.
2249         * corelow.c: Sort headers.
2250         * corefile.c: Sort headers.
2251         * continuations.c: Sort headers.
2252         * completer.h: Sort headers.
2253         * completer.c: Sort headers.
2254         * complaints.c: Sort headers.
2255         * coffread.c: Sort headers.
2256         * coff-pe-read.c: Sort headers.
2257         * cli-out.h: Sort headers.
2258         * cli-out.c: Sort headers.
2259         * charset.c: Sort headers.
2260         * c-varobj.c: Sort headers.
2261         * c-valprint.c: Sort headers.
2262         * c-typeprint.c: Sort headers.
2263         * c-lang.c: Sort headers.
2264         * buildsym.c: Sort headers.
2265         * buildsym-legacy.c: Sort headers.
2266         * build-id.h: Sort headers.
2267         * build-id.c: Sort headers.
2268         * btrace.c: Sort headers.
2269         * bsd-uthread.c: Sort headers.
2270         * breakpoint.h: Sort headers.
2271         * breakpoint.c: Sort headers.
2272         * break-catch-throw.c: Sort headers.
2273         * break-catch-syscall.c: Sort headers.
2274         * break-catch-sig.c: Sort headers.
2275         * blockframe.c: Sort headers.
2276         * block.c: Sort headers.
2277         * bfin-tdep.c: Sort headers.
2278         * bfin-linux-tdep.c: Sort headers.
2279         * bfd-target.c: Sort headers.
2280         * bcache.c: Sort headers.
2281         * ax-general.c: Sort headers.
2282         * ax-gdb.h: Sort headers.
2283         * ax-gdb.c: Sort headers.
2284         * avr-tdep.c: Sort headers.
2285         * auxv.c: Sort headers.
2286         * auto-load.c: Sort headers.
2287         * arm-wince-tdep.c: Sort headers.
2288         * arm-tdep.c: Sort headers.
2289         * arm-symbian-tdep.c: Sort headers.
2290         * arm-pikeos-tdep.c: Sort headers.
2291         * arm-obsd-tdep.c: Sort headers.
2292         * arm-nbsd-tdep.c: Sort headers.
2293         * arm-nbsd-nat.c: Sort headers.
2294         * arm-linux-tdep.c: Sort headers.
2295         * arm-linux-nat.c: Sort headers.
2296         * arm-fbsd-tdep.c: Sort headers.
2297         * arm-fbsd-nat.c: Sort headers.
2298         * arm-bsd-tdep.c: Sort headers.
2299         * arch-utils.c: Sort headers.
2300         * arc-tdep.c: Sort headers.
2301         * arc-newlib-tdep.c: Sort headers.
2302         * annotate.h: Sort headers.
2303         * annotate.c: Sort headers.
2304         * amd64-windows-tdep.c: Sort headers.
2305         * amd64-windows-nat.c: Sort headers.
2306         * amd64-tdep.c: Sort headers.
2307         * amd64-sol2-tdep.c: Sort headers.
2308         * amd64-obsd-tdep.c: Sort headers.
2309         * amd64-obsd-nat.c: Sort headers.
2310         * amd64-nbsd-tdep.c: Sort headers.
2311         * amd64-nbsd-nat.c: Sort headers.
2312         * amd64-nat.c: Sort headers.
2313         * amd64-linux-tdep.c: Sort headers.
2314         * amd64-linux-nat.c: Sort headers.
2315         * amd64-fbsd-tdep.c: Sort headers.
2316         * amd64-fbsd-nat.c: Sort headers.
2317         * amd64-dicos-tdep.c: Sort headers.
2318         * amd64-darwin-tdep.c: Sort headers.
2319         * amd64-bsd-nat.c: Sort headers.
2320         * alpha-tdep.c: Sort headers.
2321         * alpha-obsd-tdep.c: Sort headers.
2322         * alpha-nbsd-tdep.c: Sort headers.
2323         * alpha-mdebug-tdep.c: Sort headers.
2324         * alpha-linux-tdep.c: Sort headers.
2325         * alpha-linux-nat.c: Sort headers.
2326         * alpha-bsd-tdep.c: Sort headers.
2327         * alpha-bsd-nat.c: Sort headers.
2328         * aix-thread.c: Sort headers.
2329         * agent.c: Sort headers.
2330         * addrmap.c: Sort headers.
2331         * ada-varobj.c: Sort headers.
2332         * ada-valprint.c: Sort headers.
2333         * ada-typeprint.c: Sort headers.
2334         * ada-tasks.c: Sort headers.
2335         * ada-lang.c: Sort headers.
2336         * aarch64-tdep.c: Sort headers.
2337         * aarch64-ravenscar-thread.c: Sort headers.
2338         * aarch64-newlib-tdep.c: Sort headers.
2339         * aarch64-linux-tdep.c: Sort headers.
2340         * aarch64-linux-nat.c: Sort headers.
2341         * aarch64-fbsd-tdep.c: Sort headers.
2342         * aarch64-fbsd-nat.c: Sort headers.
2343         * aarch32-linux-nat.c: Sort headers.
2344
2345 2019-04-04  Tom Tromey  <tom@tromey.com>
2346
2347         * varobj.c (varobj_create): Update.
2348         * rust-exp.y (struct rust_parser) <update_innermost_block,
2349         lookup_symbol>: New methods.
2350         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2351         Rename.
2352         (rust_parser::rust_lookup_type)
2353         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2354         * printcmd.c (display_command, do_one_display): Update.
2355         * parser-defs.h (struct parser_state) <parser_state>: Add
2356         "tracker" parameter.
2357         (block_tracker): New member.
2358         (class innermost_block_tracker) <innermost_block_tracker>: Add
2359         "types" parameter.
2360         <reset>: Remove method.
2361         (innermost_block): Don't declare.
2362         (null_post_parser): Update.
2363         * parse.c (innermost_block): Remove global.
2364         (write_dollar_variable): Update.
2365         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2366         Remove "tracker_types" parameter.
2367         (parse_expression): Add "tracker" parameter.
2368         (parse_expression_for_completion): Update.
2369         (null_post_parser): Add "tracker" parameter.
2370         * p-exp.y: Update rules.
2371         * m2-exp.y: Update rules.
2372         * language.h (struct language_defn) <la_post_parser>: Add
2373         "tracker" parameter.
2374         * go-exp.y: Update rules.
2375         * f-exp.y: Update rules.
2376         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2377         parameter.
2378         * d-exp.y: Update rules.
2379         * c-exp.y: Update rules.
2380         * breakpoint.c (set_breakpoint_condition): Create an
2381         innermost_block_tracker.
2382         (watch_command_1): Likewise.
2383         * ada-lang.c (resolve): Add "tracker" parameter.
2384         (resolve_subexp): Likewise.
2385         * ada-exp.y (write_var_from_sym): Update.
2386
2387 2019-04-04  Tom Tromey  <tom@tromey.com>
2388
2389         * type-stack.h: New file.
2390         * type-stack.c: New file.
2391         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2392         type-stack.h.
2393         (insert_into_type_stack, insert_type, push_type, push_type_int)
2394         (insert_type_address_space, pop_type, pop_type_int)
2395         (pop_typelist, pop_type_stack, append_type_stack)
2396         (push_type_stack, get_type_stack, push_typelist)
2397         (follow_type_instance_flags, follow_types): Don't declare.
2398         * parse.c (type_stack): Remove global.
2399         (parse_exp_in_context): Update.
2400         (insert_into_type_stack, insert_type, push_type, push_type_int)
2401         (insert_type_address_space, pop_type, pop_type_int)
2402         (pop_typelist, pop_type_stack, append_type_stack)
2403         (push_type_stack, get_type_stack, push_typelist)
2404         (follow_type_instance_flags, follow_types): Remove (moved to
2405         type-stack.c).
2406         * f-exp.y (type_stack): New global.
2407         Update rules.
2408         (push_kind_type, f_parse): Update.
2409         * d-exp.y (type_stack): New global.
2410         Update rules.
2411         (d_parse): Update.
2412         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2413         Update rules.
2414         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2415         (HFILES_NO_SRCDIR): Add type-stack.h.
2416
2417 2019-04-04  Tom Tromey  <tom@tromey.com>
2418
2419         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2420         (rust_parser::convert_ast_to_expression, rust_parse)
2421         (rust_lex_test_completion, rust_lex_tests): Update.
2422         * parser-defs.h (struct expr_completion_state): New.
2423         (struct parser_state) <parser_state>: Add completion parameter.
2424         <mark_struct_expression, mark_completion_tag>: New methods.
2425         <parse_completion, m_completion_state>: New members.
2426         (prefixify_expression, null_post_parser): Update.
2427         (mark_struct_expression, mark_completion_tag): Don't declare.
2428         * parse.c (parse_completion, expout_last_struct)
2429         (expout_tag_completion_type, expout_completion_name): Remove
2430         globals.
2431         (parser_state::mark_struct_expression)
2432         (parser_state::mark_completion_tag): Now methods.
2433         (prefixify_expression): Add last_struct parameter.
2434         (prefixify_subexp): Likewise.
2435         (parse_exp_1): Update.
2436         (parse_exp_in_context): Add cstate parameter.  Update.
2437         (parse_expression_for_completion): Create an
2438         expr_completion_state.
2439         (null_post_parser): Add "completion" parameter.
2440         * p-exp.y: Update rules.
2441         (yylex): Update.
2442         * language.h (struct language_defn) <la_post_parser>: Add
2443         "completing" parameter.
2444         * go-exp.y: Update rules.
2445         (lex_one_token): Update.
2446         * expression.h (parse_completion): Don't declare.
2447         * d-exp.y: Update rules.
2448         (lex_one_token): Update rules.
2449         * c-exp.y: Update rules.
2450         (lex_one_token): Update.
2451         * ada-lang.c (resolve): Add "parse_completion" parameter.
2452         (resolve_subexp): Likewise.
2453         (ada_resolve_function): Likewise.
2454
2455 2019-04-04  Tom Tromey  <tom@tromey.com>
2456
2457         * parser-defs.h (struct parser_state) <start_arglist,
2458         end_arglist>: New methods.
2459         <arglist_len, m_funcall_chain>: New members.
2460         (arglist_len, start_arglist, end_arglist): Don't declare.
2461         * parse.c (arglist_len, funcall_chain): Remove global.
2462         (start_arglist, end_arglist): Remove functions.
2463         (parse_exp_in_context): Update.
2464         * p-exp.y: Update rules.
2465         * m2-exp.y: Update rules.
2466         * go-exp.y: Update rules.
2467         * f-exp.y: Update rules.
2468         * d-exp.y: Update rules.
2469         * c-exp.y: Update rules.
2470
2471 2019-04-04  Tom Tromey  <tom@tromey.com>
2472
2473         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2474         lex_operator, push_back>: New methods.
2475         Update all rules.
2476         (rust_parser::lex_hex, lex_escape): Rename and update.
2477         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2478         (rust_parser::lex_operator): Rename and update.
2479         (rust_parser::lex_number, rustyylex, rustyyerror)
2480         (rust_lex_test_init, rust_lex_test_sequence)
2481         (rust_lex_test_push_back, rust_lex_tests): Update.
2482         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2483         parameter.
2484         <lexptr, prev_lexptr>: New members.
2485         (lexptr, prev_lexptr): Don't declare.
2486         * parse.c (lexptr, prev_lexptr): Remove globals.
2487         (parse_exp_in_context): Update.
2488         * p-exp.y (yylex, yyerror): Update.
2489         * m2-exp.y (parse_number, yylex, yyerror): Update.
2490         * go-exp.y (lex_one_token, yyerror): Update.
2491         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2492         * d-exp.y (lex_one_token, yyerror): Update.
2493         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2494         (lex_one_token, yyerror): Update.
2495         * ada-lex.l (YY_INPUT): Update.
2496         (rewind_to_char): Update.
2497         * ada-exp.y (yyerror): Update.
2498
2499 2019-04-04  Tom Tromey  <tom@tromey.com>
2500
2501         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2502         * parser-defs.h (struct parser_state) <parser_state>: Add new
2503         parameter.
2504         <comma_terminates>: New member.
2505         (comma_terminates): Don't declare global.
2506         * parse.c (comma_terminates): Remove global.
2507         (parse_exp_in_context): Update.
2508         * p-exp.y (yylex): Update.
2509         * m2-exp.y (yylex): Update.
2510         * go-exp.y (lex_one_token): Update.
2511         * f-exp.y (yylex): Update.
2512         * d-exp.y (lex_one_token): Update.
2513         * c-exp.y (lex_one_token): Update.
2514         * ada-lex.l: Update.
2515
2516 2019-04-04  Tom Tromey  <tom@tromey.com>
2517
2518         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2519         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2520         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2521         * parser-defs.h (paren_depth): Don't declare.
2522         * parse.c (paren_depth): Remove global.
2523         (parse_exp_in_context): Update.
2524         * p-exp.y (paren_depth): New global.
2525         (pascal_parse): Initialize it.
2526         * m2-exp.y (paren_depth): New global.
2527         (m2_parse): Initialize it.
2528         * go-exp.y (paren_depth): New global.
2529         (go_parse): Initialize it.
2530         * f-exp.y (paren_depth): New global.
2531         (f_parse): Initialize it.
2532         * d-exp.y (paren_depth): New global.
2533         (d_parse): Initialize it.
2534         * c-exp.y (paren_depth): New global.
2535         (c_parse): Initialize it.
2536         * ada-lex.l (paren_depth): New global.
2537         (lexer_init): Initialize it.
2538
2539 2019-04-04  Tom Tromey  <tom@tromey.com>
2540
2541         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2542         (rust_parser::convert_ast_to_type)
2543         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2544         * parser-defs.h (struct parser_state) <parser_state>: Add
2545         parameters.  Initialize new members.
2546         <expression_context_block, expression_context_pc>: New members.
2547         * parse.c (expression_context_block, expression_context_pc):
2548         Remove globals.
2549         (parse_exp_in_context): Update.
2550         * p-exp.y: Update all rules.
2551         (yylex): Update.
2552         * m2-exp.y: Update all rules.
2553         (yylex): Update.
2554         * go-exp.y (yylex): Update.
2555         * f-exp.y (yylex): Update.
2556         * d-exp.y: Update all rules.
2557         (yylex): Update.
2558         * c-exp.y: Update all rules.
2559         (lex_one_token, classify_name, yylex, c_parse): Update.
2560         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2561
2562 2019-04-04  Tom Tromey  <tom@tromey.com>
2563
2564         * gdbarch.h, gdbarch.c: Rebuild.
2565         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2566         * stap-probe.h:
2567         (struct stap_parse_info): Replace "parser_state" with
2568         "expr_builder".
2569         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2570         (parser_state): New class.
2571         * parse.c (expr_builder): Rename.
2572         (expr_builder::release): Rename.
2573         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2574         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2575         (write_exp_elt_longcst, write_exp_elt_floatcst)
2576         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2577         (write_exp_string_vector, write_exp_bitstring)
2578         (write_exp_msymbol, mark_struct_expression)
2579         (write_dollar_variable)
2580         (insert_type_address_space, increase_expout_size): Replace
2581         "parser_state" with "expr_builder".
2582         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2583         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2584         "parser_state" with "expr_builder".
2585
2586 2019-04-04  Tom Tromey  <tom@tromey.com>
2587
2588         * rust-exp.y: Replace "parse_language" with method call.
2589         * p-exp.y:
2590         (yylex): Replace "parse_language" with method call.
2591         * m2-exp.y:
2592         (yylex): Replace "parse_language" with method call.
2593         * go-exp.y (classify_name): Replace "parse_language" with method
2594         call.
2595         * f-exp.y (yylex): Replace "parse_language" with method call.
2596         * d-exp.y (lex_one_token): Replace "parse_language" with method
2597         call.
2598         * c-exp.y:
2599         (lex_one_token, classify_name, yylex): Replace "parse_language"
2600         with method call.
2601         * ada-exp.y (find_primitive_type, type_char)
2602         (type_system_address): Replace "parse_language" with method call.
2603
2604 2019-04-04  Tom Tromey  <tom@tromey.com>
2605
2606         * rust-exp.y: Replace "parse_gdbarch" with method call.
2607         * parse.c (write_dollar_variable, insert_type_address_space):
2608         Replace "parse_gdbarch" with method call.
2609         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2610         call.
2611         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2612         call.
2613         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2614         "parse_gdbarch" with method call.
2615         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2616         with method call.
2617         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2618         "parse_gdbarch" with method call.
2619         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2620         "parse_gdbarch" with method call.
2621         * c-exp.y (parse_type, parse_number, classify_name): Replace
2622         "parse_gdbarch" with method call.
2623         * ada-lex.l: Replace "parse_gdbarch" with method call.
2624         * ada-exp.y (parse_type, find_primitive_type, type_char)
2625         (type_system_address): Replace "parse_gdbarch" with method call.
2626
2627 2019-04-04  Tom Tromey  <tom@tromey.com>
2628
2629         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2630         * stap-probe.c (stap_parse_argument): Update.
2631         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2632         initial_size parameter.
2633         * rust-exp.y (rust_lex_tests): Update.
2634         * parse.c (parser_state): Update.
2635         (parse_exp_in_context): Update.
2636         * parser-defs.h (struct parser_state) <parser_state>: Remove
2637         "initial_size" parameter.
2638
2639 2019-04-04  Tom Tromey  <tom@tromey.com>
2640
2641         * parser-defs.h (increase_expout_size): Don't declare.
2642         * parse.c (increase_expout_size): Now static.
2643
2644 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2645
2646         * gnu-nat.c (gnu_nat_target::wait): Fix
2647         target_waitstatus_to_string call.
2648
2649 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2650
2651         * eval.c (evaluate_subexp_standard): Handle internal functions
2652         during Fortran function call handling.
2653
2654 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2655
2656         * NEWS: Mention new internal functions.
2657         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2658         (read_base_type): Use dwarf2_init_complex_target_type.
2659         * value.c (creal_internal_fn): New function.
2660         (cimag_internal_fn): New function.
2661         (_initialize_values): Register new internal functions.
2662
2663 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2664
2665         * infrun.c (stop_all_threads): If debug_infrun, always
2666         trace the wait status after wait_one, using
2667         target_waitstatus_to_string and target_pid_to_str.
2668         (handle_inferior_event): Replace various trace of
2669         wait status kind by a single trace.
2670         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2671         wait status kind image by target_waitstatus_to_string.
2672         * target/waitstatus.c (target_waitstatus_to_string): Fix
2673         obsolete comment.
2674
2675 2019-04-01  Tom Tromey  <tromey@adacore.com>
2676
2677         PR symtab/23331:
2678         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2679
2680 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2681             Pedro Alves  <palves@redhat.com>
2682
2683         * top.c (quit_force): Call 'finalize_values'.
2684         * value.c (finalize_values): New function.
2685         * value.h (finalize_values): Declare.
2686
2687 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2688
2689         * NEWS: Announce $_gdb_major and $_gdb_minor.
2690
2691         * top.c (init_gdb_version_vars): New function.
2692         (gdb_init): Call init_gdb_version_vars.
2693
2694 2019-03-29  Tom Tromey  <tromey@adacore.com>
2695
2696         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2697         help text.  Remove dead code.
2698
2699 2019-03-29  Keith Seitz  <keiths@redhat.com>
2700
2701         From Siddhesh Poyarekar:
2702         * f-lang.h (f77_get_upperbound): Return LONGEST.
2703         (f77_get_lowerbound): Likewise.
2704         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2705         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2706         print them.
2707         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2708         plongest to format print it.
2709         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2710         (f77_get_upperbound): Likewise.
2711         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2712         LOWER_BOUND to LONGEST.
2713         (f77_create_arrayprint_offset_tbl): Likewise.
2714
2715 2019-03-29  Keith Seitz  <keiths@redhat.com>
2716
2717         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2718         %s/pulongest for TYPE_LENGTH instead of %d in format
2719         strings.
2720         * ada-typerint.c (ada_print_type): Likewise.
2721         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2722         * compile/compile-c-support.c (generate_register_struct): Likewise.
2723         * gdbtypes.c (recursive_dump_type): Likewise.
2724         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2725         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2726         instead of %d in format strings.
2727         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2728         to std::min to ULONGEST.
2729         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2730         instead of %d in format strings.
2731         * tracepoint.c (info_scope_command): Likewise.
2732         * typeprint.c (print_offset_data::update)
2733         (print_offset_data::finish): Likewise.
2734         * xtensa-tdep.c (xtensa_store_return_value)
2735         (xtensa_push_dummy_call): Likewise.
2736
2737 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2738
2739         * windows-nat.c (display_selector): Fixed format specifications
2740         for 64-bit Cygwin.
2741
2742 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2743
2744         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2745
2746 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2747
2748         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2749         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2750         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2751         (nios2_linux_init_abi): Install it.
2752
2753 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2754
2755         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2756
2757 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2758
2759         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2760
2761 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2762             Tom Tromey  <tromey@adacore.com>
2763
2764         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2765
2766 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2767
2768         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2769         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2770         method to compute the bounds of range types. Also print "[evaluated]"
2771         if the bounds' values come from a dynamic evaluation.
2772
2773 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2776         whitespace when pretty printing is on.
2777
2778 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2779
2780         * ppc-linux-nat.c: Add include.
2781
2782 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2783
2784         * NEWS: Mention AArch64 Pointer Authentication.
2785
2786 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2787
2788         * arm-linux-nat.c: Add include.
2789
2790 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2791
2792         * source-cache.c (source_cache::get_source_lines): Re-read
2793         fullname after calling open_source_file.
2794
2795 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2796
2797         * NEWS: Mention TLS support for FreeBSD.
2798
2799 2019-03-25  Tom Tromey  <tromey@adacore.com>
2800
2801         * minsyms.c (BUNCH_SIZE): Update comment.
2802         (~minimal_symbol_reader): Remove old comment.
2803         (compact_minimal_symbols): Update comment.
2804         (minimal_symbol_reader::install): Remove old comment.  Update
2805         other comments.
2806
2807 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2808
2809         * s390-linux-nat.c: Add include.
2810
2811 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2812
2813         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2814         Call linux_get_hwcap.
2815         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2816         Likewise.
2817         (aarch64_linux_get_hwcap): Remove function.
2818         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2819         declaration.
2820         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2821         linux_get_hwcap.
2822         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2823         * linux-tdep.c (linux_get_hwcap): Add function.
2824         (linux_get_hwcap2): Likewise.
2825         * linux-tdep.h (linux_get_hwcap): Add declaration.
2826         (linux_get_hwcap2): Likewise.
2827         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2828         (ppc_linux_get_hwcap2): Likewise.
2829         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2830         linux_get_hwcap.
2831         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2832         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2833         (ppc_linux_nat_target::read_description): Likewise.
2834         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2835         * s390-linux-nat.c: Likewise.
2836         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2837
2838 2019-03-24  Tom Tromey  <tom@tromey.com>
2839
2840         * ada-lang.c (standard_lookup): Simplify initialization.
2841         (ada_lookup_symbol_nonlocal): Simplify return.
2842         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2843         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2844         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2845         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2846         initialization.
2847         * solib.c (solib_global_lookup): Simplify.
2848         * symtab.c (null_block_symbol): Remove.
2849         (symbol_cache_lookup): Simplify returns.
2850         (lookup_language_this): Simplify returns.
2851         (lookup_symbol_aux): Simplify return.
2852         (lookup_local_symbol): Simplify returns.
2853         (lookup_global_symbol_from_objfile): Simplify return.
2854         (lookup_symbol_in_objfile_symtabs)
2855         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2856         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2857         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2858         * cp-namespace.c (cp_lookup_bare_symbol)
2859         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2860         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2861         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2862         (cp_lookup_symbol_via_imports): Simplify initialization.
2863         (find_symbol_in_baseclass): Likewise.
2864         * symtab.h (null_block_symbol): Remove.
2865         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2866         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2867         (d_lookup_symbol_module): Likewise.
2868         (find_symbol_in_baseclass): Simplify initialization.
2869
2870 2019-03-24  Tom Tromey  <tom@tromey.com>
2871
2872         * expression.h: Don't include symtab.h.
2873         (struct block): Forward declare.
2874
2875 2019-03-24  Tom Tromey  <tom@tromey.com>
2876
2877         * c-exp.y (typebase): Remove casts.
2878         * gdbtypes.c (lookup_unsigned_typename, )
2879         (lookup_signed_typename): Remove cast.
2880         * eval.c (parse_to_comma_and_eval): Remove cast.
2881         * parse.c (write_dollar_variable): Remove cast.
2882         * block.h (struct block) <superblock>: Now const.
2883         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2884         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2885         (map_block): Make "block" const.
2886         * symfile.h (struct quick_symbol_functions)
2887         <map_matching_symbols>: Constify block argument to "callback".
2888         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2889         const.
2890         (find_pc_sect_compunit_symtab): Make "b" const.
2891         (find_symbol_at_address): Likewise.
2892         (search_symbols): Likewise.
2893         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2894         (dw2_debug_names_lookup_symbol): Likewise.
2895         (dw2_map_matching_symbols): Update.
2896         * p-valprint.c (pascal_val_print): Remove "block".
2897         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2898         (aux_add_nonlocal_symbols): Make "block" const.
2899         (resolve_subexp): Remove cast.
2900         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2901         const.
2902         (iterate_over_file_blocks): Likewise.
2903         * f-exp.y (%union) <bval>: Remove.
2904         * coffread.c (patch_opaque_types): Make "b" const.
2905         * spu-tdep.c (spu_catch_start): Make "block" const.
2906         * c-valprint.c (print_unpacked_pointer): Remove "block".
2907         * symmisc.c (dump_symtab_1): Make "b" const.
2908         (block_depth): Make "block" const.
2909         * d-exp.y (%union) <bval>: Remove.
2910         * cp-support.h (cp_lookup_rtti_type): Update.
2911         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2912         * psymtab.c (psym_lookup_symbol): Make "block" const.
2913         (maintenance_check_psymtabs): Make "b" const.
2914         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2915         (enumerate_locals, enumerate_args): Update.
2916         * python/py-symtab.c (stpy_global_block): Make "block" const.
2917         (stpy_static_block): Likewise.
2918         * inline-frame.c (block_starting_point_at): Make "new_block"
2919         const.
2920         * block.c (find_block_in_blockvector): Make return type const.
2921         (blockvector_for_pc_sect): Make "b" const.
2922         (find_block_in_blockvector): Make "b" const.
2923
2924 2019-03-23  Tom Tromey  <tom@tromey.com>
2925
2926         * varobj.c (varobj_create): Update.
2927         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2928         * printcmd.c (display_command, do_one_display): Don't reset
2929         innermost_block.
2930         * parser-defs.h (enum innermost_block_tracker_type): Move to
2931         expression.h.
2932         (innermost_block): Update comment.
2933         * parse.c (parse_exp_1): Add tracker_types parameter.
2934         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2935         tracker_types parameter.  Reset innermost_block.
2936         (parse_exp_in_context): Remove.
2937         (parse_expression_for_completion): Update.
2938         * objfiles.c (~objfile): Don't reset expression_context_block or
2939         innermost_block.
2940         * expression.h (enum innermost_block_tracker_type): Move from
2941         parser-defs.h.
2942         (parse_exp_1): Add tracker_types parameter.
2943         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2944         reset innermost_block.
2945
2946 2019-03-23  Tom Tromey  <tom@tromey.com>
2947
2948         * objfiles.h: Include bcache.h.
2949
2950 2019-03-23  Tom Tromey  <tom@tromey.com>
2951
2952         * linespec.c (get_current_search_block): Use
2953         scoped_restore_current_language.
2954         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2955
2956 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2957             Jiong Wang  <jiong.wang@arm.com>
2958
2959         * aarch64-linux-tdep.c
2960         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2961         section.
2962         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2963
2964 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2965             Jiong Wang  <jiong.wang@arm.com>
2966
2967         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2968         instructions.
2969         (aarch64_analyze_prologue_test): Add PACIASP test.
2970         (aarch64_prologue_prev_register): Unmask PC value.
2971
2972 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2973             Jiong Wang  <jiong.wang@arm.com>
2974
2975         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2976         (aarch64_dwarf2_prev_register): Unmask PC value.
2977         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2978         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2979         DW_CFA_AARCH64_negate_ra_state.
2980         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2981
2982 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2983             Jiong Wang  <jiong.wang@arm.com>
2984
2985         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2986         registers.
2987         (aarch64_pseudo_register_name): Likewise.
2988         (aarch64_pseudo_register_type): Likewise.
2989         (aarch64_pseudo_register_reggroup_p): Likewise.
2990         (aarch64_gdbarch_init): Add pauth registers.
2991         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2992         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2993         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2994         (struct gdbarch_tdep): Add regnum for ra_state.
2995
2996 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2997             Jiong Wang  <jiong.wang@arm.com>
2998
2999         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3000
3001 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3002             Jiong Wang  <jiong.wang@arm.com>
3003
3004         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3005         function.
3006         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3007         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3008         (aarch64_gdbarch_init): Add puth registers.
3009         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3010         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3011         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3012
3013 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3014             Jiong Wang  <jiong.wang@arm.com>
3015
3016         * aarch64-linux-nat.c
3017         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3018         * aarch64-linux-tdep.c
3019         (aarch64_linux_core_read_description): Likewise.
3020         (aarch64_linux_get_hwcap): New function.
3021         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3022         (aarch64_linux_get_hwcap): New declaration.
3023
3024 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3025             Jiong Wang  <jiong.wang@arm.com>
3026
3027         * aarch64-linux-nat.c
3028         (aarch64_linux_nat_target::read_description): Add pauth param.
3029         * aarch64-linux-tdep.c
3030         (aarch64_linux_core_read_description): Likewise.
3031         * aarch64-tdep.c (struct target_desc): Add in pauth.
3032         (aarch64_read_description): Add pauth param.
3033         (aarch64_gdbarch_init): Likewise.
3034         * aarch64-tdep.h (aarch64_read_description): Likewise.
3035         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3036         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3037         * features/Makefile: Add new files.
3038         * features/aarch64-pauth.c: New file.
3039         * features/aarch64-pauth.xml: New file.
3040
3041 2019-03-20  Tom Tromey  <tromey@adacore.com>
3042
3043         * infrun.c (handle_inferior_event): Rename from
3044         handle_inferior_event_1.  Create a scoped_value_mark.
3045         (handle_inferior_event): Remove.
3046
3047 2019-03-19  Tom Tromey  <tromey@adacore.com>
3048
3049         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3050         * infrun.h (print_stop_event): Add "displays" parameter.
3051         * infrun.c (print_stop_event): Add "displays" parameter.
3052
3053 2019-03-19  Pedro Alves  <palves@redhat.com>
3054
3055         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3056         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3057         to -1.  Fix TABs vs spaces.
3058         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3059         * tui/tui-out.h (tui_ui_out) Add intro comments.
3060         <m_line, m_start_of_line>: In-class initialize, and add describing
3061         comment.
3062
3063 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3064
3065         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3066         variable names.
3067         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3068
3069 2019-03-18  Pedro Alves  <palves@redhat.com>
3070             Eli Zaretskii <eliz@gnu.org>
3071
3072         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3073         m_line and m_start_of_line.
3074
3075 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3076
3077         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3078         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3079         it returns a newline.  This fixes a regression in TU mode, whereby
3080         the next line is output on the same screen line as the user input.
3081
3082 2019-03-18  Tom Tromey  <tromey@adacore.com>
3083
3084         * minsyms.c (minimal_symbol_reader::install): Remove call to
3085         obstack_blank.
3086
3087 2019-03-18  Pedro Alves  <palves@redhat.com>
3088
3089         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3090         New globals.
3091         (apply_style): New, factored out from ...
3092         (apply_ansi_escape): ... this.  Handle reverse video mode.
3093         (tui_set_reverse_mode): New function.
3094         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3095         * tui/tui-winsource.c (tui_show_source_line): Use
3096         tui_set_reverse_mode instead of setting A_STANDOUT.
3097         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3098         New setter methods.
3099
3100 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3101
3102         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3103         Handle tabs.
3104
3105 2019-03-18  Tom Tromey  <tromey@adacore.com>
3106
3107         * ada-lang.c (empty_array): Add "high" parameter.
3108         (ada_evaluate_subexp): Update.
3109
3110 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3111
3112         * unittests/string_view-selftests.c: Define
3113         _initialize_string_view_selftests unconditionally.
3114
3115 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3116
3117         PR gdb/24350
3118         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3119
3120 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3121
3122         PR gdb/24351
3123         * windows-nat.c (display_selector): Fix format specifiers.
3124
3125 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3126
3127         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3128         tui_refill_source_window instead of tui_refresh_win, to update the
3129         current execution line.  This fixes redisplay of the current line
3130         when stepping through the code with "next" or "step".
3131
3132 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3133
3134         * source-cache.c (source_cache::get_source_lines): Call
3135         find_source_lines to initialize s->nlines.  This fixes vertical
3136         scrolling of TUI source window when the DOWN arrow is pressed.
3137
3138 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3139
3140         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3141         linux-thread-db.c (_initialize_thread_db): Likewise.
3142
3143 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3144
3145         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3146         wclrtoeol in tui_show_source_line".  This reverts changes made in
3147         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3148
3149 2019-03-15  Tom Tromey  <tom@tromey.com>
3150
3151         * symtab.h (struct minimal_symbol): Derive from
3152         general_symbol_info.
3153         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3154         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3155         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3156         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3157         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3158         (MSYMBOL_SEARCH_NAME): Update.
3159         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3160         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3161         * minsyms.c (minimal_symbol_reader::record_full): Update.
3162
3163 2019-03-15  Tom Tromey  <tom@tromey.com>
3164
3165         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3166
3167 2019-03-15  Tom Tromey  <tom@tromey.com>
3168
3169         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3170         unique_xmalloc_ptr.
3171         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3172         Update.
3173         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3174         (build_minimal_symbol_hash_tables)
3175         (minimal_symbol_reader::install): Update.
3176
3177 2019-03-15  Tom Tromey  <tom@tromey.com>
3178
3179         * symtab.c (create_demangled_names_hash): Update.
3180         (symbol_set_names): Update.
3181         * objfiles.h (struct objfile_per_bfd_storage)
3182         <demangled_names_hash>: Now an htab_up.
3183         * objfiles.c (objfile_per_bfd_storage): Simplify.
3184
3185 2019-03-15  Tom Tromey  <tom@tromey.com>
3186
3187         * objfiles.h (struct objfile_per_bfd_storage): Declare
3188         destructor.
3189         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3190         New.
3191         (get_objfile_bfd_data): Use new.  Don't initialize
3192         language_of_main.
3193         (free_objfile_per_bfd_storage): Remove.
3194         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3195
3196 2019-03-15  Tom Tromey  <tom@tromey.com>
3197
3198         * symfile.c (reread_symbols): Update.
3199         * objfiles.c (objfile::objfile): Update.
3200         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3201         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3202         comment.
3203         (minimal_symbol_reader::install): Update.
3204         (terminate_minimal_symbol_table): Remove.
3205         * jit.c (jit_object_close_impl): Update.
3206
3207 2019-03-15  Tom Tromey  <tom@tromey.com>
3208
3209         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3210         initializations.
3211
3212 2019-03-15  Tom Tromey  <tom@tromey.com>
3213
3214         * objfiles.h (struct objfile_per_bfd_storage)
3215         <demangled_hash_languages>: Now a bitset.
3216         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3217         (lookup_minimal_symbol): Update.
3218
3219 2019-03-15  Tom Tromey  <tom@tromey.com>
3220
3221         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3222         Don't return the symbol.
3223         * coffread.c (record_minimal_symbol): Use record_full.
3224
3225 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3226
3227         The MS-Windows port of ncurses fails to switch to a color pair if
3228         one or both of the colors are the implicit default colors.  This
3229         change records the default colors when TUI is initialized, and
3230         then specifies them explicitly when a color pair uses the default
3231         colors.  This allows color styling in TUI mode on MS-Windows.
3232
3233         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3234         ncurses_norm_attr.
3235         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3236         colors in ncurses_norm_attr.
3237         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3238         "none", replace it with the default color recorded in
3239         ncurses_norm_attr.
3240
3241 2019-03-14  Tom Tromey  <tromey@adacore.com>
3242
3243         * source-cache.h (class source_cache) <get_source_lines>: Return
3244         std::string.
3245         * source-cache.c (source_cache::extract_lines): Handle case where
3246         first_pos==npos.  Return std::string.
3247         (source_cache::get_source_lines): Update.
3248
3249 2019-03-14  Tom Tromey  <tromey@adacore.com>
3250
3251         * NEWS: Add item for "style sources" commands.
3252         * source-cache.c (source_cache::get_source_lines): Check
3253         source_styling.
3254         * cli/cli-style.c (source_styling): New global.
3255         (_initialize_cli_style): Add "style sources" commands.
3256         (show_style_sources): New function.
3257         * cli/cli-style.h (source_styling): Declare.
3258
3259 2019-03-14  Pedro Alves  <palves@redhat.com>
3260             Tom Tromey  <tromey@adacore.com>
3261
3262         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3263         * tui/tui-winsource.c (tui_refill_source_window): New function,
3264         from...
3265         (tui_horizontal_source_scroll): ... here.  Move some logic.
3266         * cli/cli-style.c (set_style_enabled): Notify new observable.
3267         * tui/tui-hooks.c (tui_redisplay_source): New function.
3268         (tui_attach_detach_observers): Attach or detach
3269         tui_redisplay_source.
3270         * observable.h (source_styling_changed): New observable.
3271         * observable.c: Define source_styling_changed observable.
3272
3273 2019-03-13  Tom Tromey  <tromey@adacore.com>
3274
3275         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3276         (i386_gnu_nat_target::store_registers): Update.
3277         * target-debug.h (target_debug_print_std_string): New macro.
3278         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3279         * windows-tdep.c (display_one_tib): Update.
3280         * tui/tui-stack.c (tui_make_status_line): Update.
3281         * top.c (print_inferior_quit_action): Update.
3282         * thread.c (thr_try_catch_cmd): Update.
3283         (add_thread_with_info): Update.
3284         (thread_target_id_str): Update.
3285         (thr_try_catch_cmd): Update.
3286         (thread_command): Update.
3287         (thread_find_command): Update.
3288         * record-btrace.c (record_btrace_target::info_record)
3289         (record_btrace_resume_thread, record_btrace_target::resume)
3290         (record_btrace_cancel_resume, record_btrace_step_thread)
3291         (record_btrace_target::wait, record_btrace_target::wait)
3292         (record_btrace_target::wait, record_btrace_target::stop): Update.
3293         * progspace.c (print_program_space): Update.
3294         * process-stratum-target.c
3295         (process_stratum_target::thread_address_space): Update.
3296         * linux-fork.c (linux_fork_mourn_inferior)
3297         (detach_checkpoint_command, info_checkpoints_command)
3298         (linux_fork_context): Update.
3299         (linux_fork_detach): Update.
3300         (class scoped_switch_fork_info): Update.
3301         (delete_checkpoint_command): Update.
3302         * infrun.c (follow_fork_inferior): Update.
3303         (follow_fork_inferior): Update.
3304         (proceed_after_vfork_done): Update.
3305         (handle_vfork_child_exec_or_exit): Update.
3306         (follow_exec): Update.
3307         (displaced_step_prepare_throw): Update.
3308         (displaced_step_restore): Update.
3309         (start_step_over): Update.
3310         (resume_1): Update.
3311         (clear_proceed_status_thread): Update.
3312         (proceed): Update.
3313         (print_target_wait_results): Update.
3314         (do_target_wait): Update.
3315         (context_switch): Update.
3316         (stop_all_threads): Update.
3317         (restart_threads): Update.
3318         (finish_step_over): Update.
3319         (handle_signal_stop): Update.
3320         (switch_back_to_stepped_thread): Update.
3321         (keep_going_pass_signal): Update.
3322         (print_exited_reason): Update.
3323         (normal_stop): Update.
3324         * inferior.c (inferior_pid_to_str): Change return type.
3325         (print_selected_inferior): Update.
3326         (add_inferior): Update.
3327         (detach_inferior): Update.
3328         * dummy-frame.c (fprint_dummy_frames): Update.
3329         * dcache.c (dcache_info_1): Update.
3330         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3331         (btrace_fetch, btrace_clear): Update.
3332         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3333         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3334         type.
3335         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3336         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3337         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3338         * gdbarch.c, gdbarch.h: Rebuild.
3339         * gdbarch.sh (core_pid_to_str): Change return type.
3340         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3341         return type.
3342         (windows_nat_target::pid_to_str): Change return type.
3343         (windows_delete_thread): Update.
3344         (windows_nat_target::attach): Update.
3345         (windows_nat_target::files_info): Update.
3346         * target-delegates.c: Rebuild.
3347         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3348         return type.
3349         (sol_thread_target::pid_to_str): Change return type.
3350         * remote.c (class remote_target) <pid_to_str>: Change return
3351         type.
3352         (remote_target::pid_to_str): Change return type.
3353         (extended_remote_target::attach, remote_target::remote_stop_ns)
3354         (remote_target::remote_notif_remove_queued_reply)
3355         (remote_target::push_stop_reply, remote_target::disable_btrace):
3356         Update.
3357         (extended_remote_target::attach): Update.
3358         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3359         type.
3360         (gdbsim_target::pid_to_str): Change return type.
3361         * ravenscar-thread.c (struct ravenscar_thread_target)
3362         <pid_to_str>: Change return type.
3363         (ravenscar_thread_target::pid_to_str): Change return type.
3364         * procfs.c (class procfs_target) <pid_to_str>: Change return
3365         type.
3366         (procfs_target::pid_to_str): Change return type.
3367         (procfs_target::attach): Update.
3368         (procfs_target::detach): Update.
3369         (procfs_target::fetch_registers): Update.
3370         (procfs_target::store_registers): Update.
3371         (procfs_target::wait): Update.
3372         (procfs_target::files_info): Update.
3373         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3374         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3375         return type.
3376         (nto_procfs_target::pid_to_str): Change return type.
3377         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3378         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3379         return type.
3380         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3381         (exit_lwp): Update.
3382         (attach_proc_task_lwp_callback, get_detach_signal)
3383         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3384         (linux_nat_target::resume, wait_lwp, stop_callback)
3385         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3386         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3387         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3388         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3389         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3390         type.
3391         (inf_ptrace_target::attach): Update.
3392         (inf_ptrace_target::files_info): Update.
3393         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3394         type.
3395         (go32_nat_target::pid_to_str): Change return type.
3396         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3397         (gnu_nat_target::wait): Update.
3398         (gnu_nat_target::wait): Update.
3399         (gnu_nat_target::resume): Update.
3400         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3401         (fbsd_nat_target::wait): Update.
3402         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3403         type.
3404         (darwin_nat_target::attach): Update.
3405         * corelow.c (class core_target) <pid_to_str>: Change return type.
3406         (core_target::pid_to_str): Change return type.
3407         * target.c (normal_pid_to_str): Change return type.
3408         (default_pid_to_str): Likewise.
3409         (target_pid_to_str): Change return type.
3410         (target_translate_tls_address): Update.
3411         (target_announce_detach): Update.
3412         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3413         return type.
3414         (bsd_uthread_target::pid_to_str): Change return type.
3415         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3416         type.
3417         (bsd_kvm_target::pid_to_str): Change return type.
3418         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3419         return type.
3420         (aix_thread_target::pid_to_str): Change return type.
3421         * target.h (struct target_ops) <pid_to_str>: Change return type.
3422         (target_pid_to_str, normal_pid_to_str): Likewise.
3423         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3424         type.
3425         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3426         type.
3427         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3428         return type.
3429         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3430         type.
3431         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3432         type.
3433         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3434         return type.
3435
3436 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3437
3438         * NEWS: Mention that the new default MI version is 3.  Mention
3439         changes to the output of commands and events that deal with
3440         multi-location breakpoints.
3441         * breakpoint.c: Include "mi/mi-out.h".
3442         (print_one_breakpoint): Change output syntax if using MI version
3443         >= 3.
3444         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3445         New.
3446         (mi_multi_location_breakpoint_output_fixed): New.
3447         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3448         (mi_cmd_fix_multi_location_breakpoint_output): New.
3449         (mi_multi_location_breakpoint_output_fixed): New.
3450         * mi/mi-cmds.c (mi_cmds): Register command
3451         -fix-multi-location-breakpoint-output.
3452         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3453         interpreter "mi".
3454
3455 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3456
3457         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3458         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3459         instantiate mi_ui_out based on interpreter name.
3460         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3461         * mi/mi-main.c (mi_load_progress): Likewise.
3462
3463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3464
3465         * NEWS: Combine separate "New targets" sections for 8.3.
3466
3467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3468
3469         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3470         (ppcfbsd_init_abi): Install gdbarch
3471         "fetch_tls_load_module_address" and "get_thread_local_address"
3472         methods.
3473
3474 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3475
3476         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3477         (riscv_fbsd_init_abi): Install gdbarch
3478         "fetch_tls_load_module_address" and "get_thread_local_address"
3479         methods.
3480
3481 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3482
3483         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3484         (i386fbsd_init_abi): Install gdbarch
3485         "fetch_tls_load_module_address" and "get_thread_local_address"
3486         methods.
3487
3488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3489
3490         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3491         (amd64fbsd_init_abi): Install gdbarch
3492         "fetch_tls_load_module_address" and "get_thread_local_address"
3493         methods.
3494
3495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3496
3497         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3498         (struct fbsd_pspace_data): New type.
3499         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3500         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3501         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3502         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3503         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3504
3505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3506
3507         * gdbtypes.c (lookup_struct_elt): New function.
3508         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3509         * gdbtypes.h (struct struct_elt): New type.
3510         (lookup_struct_elt): New prototype.
3511
3512 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3513
3514         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3515         remove disabled code block.
3516
3517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3518
3519         * gdbarch.sh (get_thread_local_address): New method.
3520         * gdbarch.h, gdbarch.c: Regenerate.
3521         * target.c (target_translate_tls_address): Use
3522         gdbarch_get_thread_local_address if present instead of
3523         target::get_thread_local_address.
3524
3525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3526
3527         * target.h (target::get_thread_local_address): Update comment.
3528
3529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3530
3531         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3532         objfile->separate_debug_objfile_backlink if not NULL.
3533
3534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3535
3536         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3537         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3538         (amd64bsd_store_inferior_registers): Likewise.
3539         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3540         Enable segment base registers.
3541         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3542         PT_GETFSBASE and PT_GETGSBASE.
3543         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3544         PT_SETGSBASE.
3545         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3546         segment base registers.
3547         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3548
3549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3550
3551         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3552         Update calls to i386_target_description to add 'segments'
3553         parameter.
3554         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3555         add segment base registers.
3556         * arch/i386.c (i386_create_target_description): Add 'segments'
3557         parameter to enable segment base registers.
3558         * arch/i386.h (i386_create_target_description): Likewise.
3559         * features/i386/32bit-segments.xml: New file.
3560         * features/i386/32bit-segments.c: Generate.
3561         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3562         call to i386_target_description to add 'segments' parameter.
3563         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3564         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3565         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3566         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3567         if feature is present.
3568         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3569         Add 'segments' parameter to call to i386_target_description.
3570         (i386_target_description): Add 'segments' parameter to enable
3571         segment base registers.
3572         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3573         to call to i386_target_description.
3574         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3575         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3576         Define I386_NUM_REGS.
3577         (i386_target_description): Add 'segments' parameter to enable
3578         segment base registers.
3579
3580 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3581
3582         PR/24325
3583         * source-cache.c: #undef open and close, to avoid unresolved
3584         externals during linking.
3585
3586 2019-03-12  Tom Tromey  <tromey@adacore.com>
3587
3588         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3589         const.  Add initializers.
3590         (_initialize_remote): Don't initialize ptid globals.
3591
3592 2019-03-12  Pedro Alves  <palves@redhat.com>
3593
3594         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3595
3596 2019-03-12  Pedro Alves  <palves@redhat.com>
3597
3598         * cp-name-parser.y (main): Remove unused 'len' variable.
3599
3600 2019-03-12  Tom Tromey  <tromey@adacore.com>
3601
3602         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3603         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3604
3605 2019-03-12  Tom Tromey  <tromey@adacore.com>
3606
3607         * linux-nat.c (iterate_over_lwps): Update.
3608         (stop_callback): Remove parameter.
3609         (stop_wait_callback, detach_callback, resume_set_callback)
3610         (select_singlestep_lwp_callback, set_ignore_sigint)
3611         (status_callback, resumed_callback, resume_clear_callback)
3612         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3613         data parameter.
3614         (linux_nat_target::detach, linux_nat_target::resume)
3615         (linux_stop_and_wait_all_lwps, select_event_lwp)
3616         (linux_nat_filter_event, linux_nat_wait_1)
3617         (linux_nat_target::kill, linux_nat_target::stop)
3618         (linux_nat_target::stop): Update.
3619         (linux_nat_resume_callback): Change type.
3620         (resume_stopped_resumed_lwps, count_events_callback)
3621         (select_event_lwp_callback): Likewise.
3622         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3623         * arm-linux-nat.c (struct update_registers_data): Remove.
3624         (update_registers_callback): Change type.
3625         (arm_linux_insert_hw_breakpoint1): Update.
3626         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3627         parameter.
3628         (x86_linux_dr_set_addr): Update.
3629         (x86_linux_dr_set_control): Update.
3630         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3631         (iterate_over_lwps): Use gdb::function_view.
3632         * nat/aarch64-linux-hw-point.c (struct
3633         aarch64_dr_update_callback_param): Remove.
3634         (debug_reg_change_callback): Change type.
3635         (aarch64_notify_debug_reg_change): Update.
3636         * s390-linux-nat.c (s390_refresh_per_info): Update.
3637
3638 2019-03-11  Tom Tromey  <tromey@adacore.com>
3639
3640         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3641         redundant assignment to "this_cu".
3642
3643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3644
3645         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3646
3647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3648
3649         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3650         from...
3651         (rank_one_type): ... this.
3652
3653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3654
3655         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3656         from...
3657         (rank_one_type): ... this.
3658
3659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3660
3661         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3662         from...
3663         (rank_one_type): ... this.
3664
3665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3666
3667         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3668         from...
3669         (rank_one_type): ... this.
3670
3671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3672
3673         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3674         from...
3675         (rank_one_type): ... this.
3676
3677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3678
3679         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3680         from...
3681         (rank_one_type): ... this.
3682
3683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3684
3685         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3686         from...
3687         (rank_one_type): ... this.
3688
3689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3690
3691         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3692         from...
3693         (rank_one_type): ... this.
3694
3695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3696
3697         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3698         from...
3699         (rank_one_type): ... this.
3700
3701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3702
3703         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3704         from...
3705         (rank_one_type): ... this.
3706
3707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3708
3709         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3710         from...
3711         (rank_one_type): ... this.
3712
3713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3714
3715         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3716         from...
3717         (rank_one_type): ... this.
3718
3719 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3720
3721         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3722         inferior-events' shows the example events.
3723
3724 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3725
3726         Support styling on native MS-Windows console
3727
3728         PR/24315
3729         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3730         on MS-Windows if $TERM is not defined.
3731
3732         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3733
3734         * posix-hdep.c (gdb_console_fputs):
3735         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3736         functions.
3737         * ui-file.h (gdb_console_fputs): Add prototype.
3738
3739         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3740         back to fputs only if the former returns zero.
3741
3742 2019-03-07  Tom Tromey  <tom@tromey.com>
3743
3744         * symmisc.c (print_symbol_bcache_statistics): Update.
3745         (print_objfile_statistics): Update.
3746         * symfile.c (allocate_symtab): Update.
3747         * stabsread.c: Don't include bcache.h.
3748         * psymtab.h (struct psymbol_bcache): Don't declare.
3749         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3750         (psymbol_bcache_init, psymbol_bcache_free)
3751         (psymbol_bcache_get_bcache): Don't declare.
3752         * psymtab.c (struct psymbol_bcache): Remove.
3753         (psymtab_storage::psymtab_storage): Update.
3754         (psymtab_storage::~psymtab_storage): Update.
3755         (psymbol_bcache_init, psymbol_bcache_free)
3756         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3757         (add_psymbol_to_bcache): Update.
3758         (allocate_psymtab): Update.
3759         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3760         macro_cache>: No longer pointers.
3761         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3762         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3763         * macrotab.c (macro_bcache): Update.
3764         * macroexp.c: Don't include bcache.h.
3765         * gdbtypes.c (check_types_worklist): Update.
3766         (types_deeply_equal): Remove TRY/CATCH.  Update.
3767         * elfread.c (elf_symtab_read): Update.
3768         * dwarf2read.c: Don't include bcache.h.
3769         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3770         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3771         (print_bcache_statistics, bcache_memory_used): Don't declare.
3772         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3773         methods.  Rename all data members.
3774         * bcache.c (struct bcache): Move to bcache.h.
3775         (bcache::expand_hash_table): Rename from expand_hash_table.
3776         (bcache): Remove.
3777         (bcache::insert): Rename from bcache_full.
3778         (bcache::compare): Rename from bcache_compare.
3779         (bcache_xmalloc): Remove.
3780         (bcache::~bcache): Rename from bcache_xfree.
3781         (bcache::print_statistics): Rename from print_bcache_statistics.
3782         (bcache::memory_used): Rename from bcache_memory_used.
3783
3784 2019-03-07  Pedro Alves  <palves@redhat.com>
3785
3786         * infrun.c (normal_stop): Also check for
3787         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3788
3789 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3790
3791         * f-lang.c (value_from_host_double): Moved to...
3792         * value.c (value_from_host_double): ...here.
3793         * value.h (value_from_host_double): Declare.
3794         * guile/scm-math.c (vlscm_convert_typed_number): Use
3795         value_from_host_double.
3796         (vlscm_convert_number): Likewise.
3797         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3798         * python/py-value.c (convert_value_from_python): Likewise.
3799
3800 2019-03-06  Tom Tromey  <tom@tromey.com>
3801
3802         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3803
3804 2019-03-06  Tom Tromey  <tom@tromey.com>
3805
3806         * utils.h (free_current_contents): Don't declare.
3807         * utils.c (free_current_contents): Remove.
3808
3809 2019-03-06  Tom Tromey  <tom@tromey.com>
3810
3811         * top.c (quit_force): Update.
3812         * main.c (captured_command_loop): Update.
3813         * common/new-op.c (operator new): Update.
3814         * common/common-exceptions.c (struct catcher)
3815         <save_cleanup_chain>: Remove member.
3816         (exceptions_state_mc_init): Update.
3817         (exception_try_scope_entry): Return nullptr.
3818         (exception_try_scope_exit, exception_rethrow)
3819         (throw_exception_sjlj, throw_exception_cxx): Update.
3820         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3821         (all_cleanups, do_cleanups, discard_cleanups)
3822         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3823         (restore_cleanups, restore_final_cleanups): Don't declare.
3824         (do_final_cleanups): Remove parameter.
3825         * common/cleanups.c (cleanup_chain, make_cleanup)
3826         (make_cleanup_dtor, all_cleanups, do_cleanups)
3827         (discard_my_cleanups, discard_cleanups)
3828         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3829         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3830         (null_cleanup): Remove.
3831         (do_final_cleanups): Remove parameter.
3832
3833 2019-03-06  Tom Tromey  <tom@tromey.com>
3834
3835         * remote.c (remote_target::remote_parse_stop_reply): Use
3836         unique_xmalloc_ptr.
3837
3838 2019-03-06  Tom Tromey  <tom@tromey.com>
3839
3840         * stabsread.c (struct stabs_field_info): Rename from field_info.
3841         <list, fnlist>: Add initializers.
3842         <obstack>: New member.
3843         (read_member_functions, read_struct_fields, read_baseclasses):
3844         Allocate on obstack.  Don't use cleanups.
3845         (read_one_struct_field, read_member_functions, read_struct_fields)
3846         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3847         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3848         (read_struct_type): Update.
3849
3850 2019-03-06  Tom Tromey  <tom@tromey.com>
3851
3852         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3853         * common/filestuff.h (make_cleanup_close): Don't declare.
3854         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3855         Remove.
3856
3857 2019-03-06  Tom Tromey  <tom@tromey.com>
3858
3859         * solib-aix.c: Use make_scope_exit.
3860
3861 2019-03-06  Tom Tromey  <tom@tromey.com>
3862
3863         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3864         Use make_scope_exit.
3865
3866 2019-03-06  Tom Tromey  <tom@tromey.com>
3867
3868         * solib-svr4.c (disable_probes_interface): Remove parameter.
3869         (svr4_handle_solib_event): Use make_scope_exit.
3870
3871 2019-03-06  Tom Tromey  <tom@tromey.com>
3872
3873         * remote.c (struct stop_reply_deleter): Remove.
3874         (stop_reply_up): Update.
3875         (struct stop_reply): Derive from notif_event.  Don't typedef.
3876         <regcache>: Now a std::vector.
3877         (stop_reply_xfree): Remove.
3878         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3879         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3880         (remote_target::discard_pending_stop_replies): Use delete.
3881         (remote_target::remote_parse_stop_reply): Update.
3882         (remote_target::process_stop_reply): Update.
3883         * remote-notif.h (struct notif_event): Add virtual destructor.
3884         Remove "dtr" member.
3885         (struct notif_client) <alloc_event>: Return a unique_ptr.
3886         (notif_event_xfree): Don't declare.
3887         (notif_event_up): New typedef.
3888         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3889         (notif_event_xfree, do_notif_event_xfree): Remove.
3890         (remote_notif_state_xfree): Update.
3891
3892 2019-03-06  Tom Tromey  <tom@tromey.com>
3893
3894         * infrun.c (displaced_step_clear_cleanup): Now a
3895         forward_scope_exit type.
3896         (displaced_step_prepare_throw): Update.
3897         (displaced_step_fixup): Update.
3898
3899 2019-03-06  Tom Tromey  <tom@tromey.com>
3900
3901         * inferior.h (class inferior): Update comment.
3902         * gdbthread.h (class thread_info): Update comment.
3903
3904 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3905             Tom Tromey  <tom@tromey.com>
3906
3907         * stabsread.h (struct stab_section_list): Remove.
3908         (coffstab_build_psymtabs): Update.
3909         * dbxread.c (symbuf_sections): Now a std::vector.
3910         (sect_idx): New global.
3911         (fill_symbuf): Update.
3912         (coffstab_build_psymtabs): Change type of stabsects parameter.
3913         Update.
3914         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3915         std::vector.
3916         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3917         (coff_locate_sections): Update.
3918         (coff_symfile_read): Remove cleanups.  Update.
3919         (init_stringtab): Add storage parameter.
3920         (free_stringtab, free_stringtab_cleanup): Remove.
3921         (init_lineno): Add storage parameter.
3922         (free_linetab, free_linetab_cleanup): Remove.
3923
3924 2019-03-06  Pedro Alves  <palves@redhat.com>
3925
3926         * linux-fork.c (fork_info::clobber_regs): Delete.
3927         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3928         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3929         comment.  Adjust.
3930         (scoped_switch_fork_info::scoped_switch_fork_info)
3931         (checkpoint_command, linux_fork_context): Adjust
3932         fork_save_infrun_state calls.
3933
3934 2019-03-06  Pedro Alves  <palves@redhat.com>
3935
3936         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3937         (inf_has_multiple_threads): Return 'bool' and rewrite using
3938         inferior_info::threads().
3939
3940 2019-03-06  Pedro Alves  <palves@redhat.com>
3941
3942         * linux-fork.c: Include <list>.
3943         (fork_list): Now a std::list instance.
3944         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3945         (forks_exist_p, find_last_fork): Adjust.
3946         (new_fork): Delete.
3947         (one_fork_p): New.
3948         (add_fork): Adjust.
3949         (free_fork): Delete, folded into fork_info::~fork_info().
3950         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3951         Adjust.
3952         (init_fork_list): Delete.
3953         (linux_fork_killall, linux_fork_mourn_inferior)
3954         (linux_fork_detach, info_checkpoints_command): Adjust.
3955         (_initialize_linux_fork): No longer call init_fork_list.
3956
3957 2019-03-06  Pedro Alves  <palves@redhat.com>
3958
3959         * linux-fork.c (new_fork): New, split out of ...
3960         (add_fork): ... this.  Return void.  Move "first fork" special
3961         case from here, to ...
3962         (checkpoint_command): ... here.
3963         * linux-linux.h (add_fork): Return void.
3964
3965 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3966
3967         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3968
3969 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3970             Chris January  <chris.january@arm.com>
3971             David Lecomber  <david.lecomber@arm.com>
3972
3973         * f-exp.y: New token, UNOP_INTRINSIC.
3974         (exp): New pattern using UNOP_INTRINSIC token.
3975         (f77_keywords): Add 'abs' keyword.
3976         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3977         (value_from_host_double): New function.
3978         (evaluate_subexp_f): Support UNOP_ABS.
3979
3980 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3983         types.
3984
3985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3986
3987         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3988         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3989         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3990
3991 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3994
3995 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3996             Chris January  <chris.january@arm.com>
3997
3998         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3999         * f-exp.y: Define 'KIND' token.
4000         (exp): New pattern for KIND expressions.
4001         (ptype): Handle types with a kind extension.
4002         (direct_abs_decl): Extend to spot kind extensions.
4003         (f77_keywords): Add 'kind' to the list.
4004         (push_kind_type): New function.
4005         (convert_to_kind_type): New function.
4006         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4007         * parse.c (operator_length_standard): Likewise.
4008         * parser-defs.h (enum type_pieces): Add tp_kind.
4009         * std-operator.def: Add UNOP_KIND.
4010
4011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4012
4013         * f-exp.y (f_parse): Set yydebug.
4014
4015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4016
4017         * f-lang.c (evaluate_subexp_f): New function.
4018         (exp_descriptor_f): New global.
4019         (f_language_defn): Use exp_descriptor_f instead of
4020         exp_descriptor_standard.
4021
4022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * f-exp.y (struct token): Add comments.
4025         (dot_ops): Remove uppercase versions and the end marker.
4026         (f77_keywords): Likewise.
4027         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4028         entries in the dot_ops array are case insensitive, and use
4029         strncasecmp to compare strings.  Also some whitespace cleanup in
4030         this area.  Similar for the f77_keywords array, except entries in
4031         this list might be case sensitive.
4032
4033 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * f-exp.y (struct f77_boolean_val): Add comments.
4036         (boolean_values): Remove uppercase versions, and end marker.
4037         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4038         and use strncasecmp to achieve case insensitivity.  Additionally,
4039         perform whitespace cleanup around this code.
4040
4041 2019-03-06  Tom Tromey  <tromey@adacore.com>
4042
4043         * remote-sim.c (gdbsim_target_open): Use result of
4044         gdb_argv::release.
4045
4046 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4047         Dirk Schubert  <dirk.schubert@arm.com>
4048         Chris January  <chris.january@arm.com>
4049
4050         * eval.c (evaluate_subexp_standard): Call Fortran argument
4051         wrapping logic.
4052         * f-lang.c (struct value): A value which can be passed into a
4053         Fortran function call.
4054         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4055         where appropriate.
4056         (struct type): Value ready for a Fortran function call.
4057         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4058         is needed.
4059         * f-lang.h (fortran_argument_convert): Declaration.
4060         (fortran_preserve_arg_pointer): Declaration.
4061         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4062
4063 2019-03-05  Tom Tromey  <tromey@adacore.com>
4064
4065         * python/py-prettyprint.c (print_string_repr): Remove #if.
4066         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4067
4068 2019-03-05  Tom Tromey  <tromey@adacore.com>
4069
4070         * target.c (the_dummy_target): Move later.  Change type to
4071         "dummy_target".
4072         (initialize_targets): Don't initialize the_dummy_target.
4073
4074 2019-03-05  Tom Tromey  <tromey@adacore.com>
4075
4076         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4077         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4078
4079 2019-03-05  Tom Tromey  <tromey@adacore.com>
4080
4081         * windows-nat.c (windows_nat_target::attach)
4082         (windows_nat_target::detach): Don't call gdb_flush.
4083         * valprint.c (generic_val_print, val_print, val_print_string):
4084         Don't call gdb_flush.
4085         * utils.c (defaulted_query): Don't call gdb_flush.
4086         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4087         * target.c (target_announce_detach): Don't call gdb_flush.
4088         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4089         * remote.c (extended_remote_target::attach): Don't call
4090         gdb_flush.
4091         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4092         * printcmd.c (do_examine): Don't call gdb_flush.
4093         (info_display_command): Don't call gdb_flush.
4094         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4095         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4096         * memattr.c (info_mem_command): Don't call gdb_flush.
4097         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4098         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4099         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4100         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4101         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4102         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4103         (gnu_nat_target::detach): Don't call gdb_flush.
4104         * f-valprint.c (f_val_print): Don't call gdb_flush.
4105         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4106         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4107         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4108         gdb_flush.
4109         * c-valprint.c (c_val_print): Don't call gdb_flush.
4110         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4111
4112 2019-03-05  Tom Tromey  <tromey@adacore.com>
4113
4114         * varobj.c (update_dynamic_varobj_children): Update.
4115         (install_default_visualizer): Use reset, not release.
4116         * value.c (set_internalvar): Update.
4117         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4118         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4119         ATTRIBUTE_UNUSED_RESULT.
4120
4121 2019-03-05  Tom Tromey  <tromey@adacore.com>
4122
4123         * remote.c (class scoped_remote_fd) <release>: Add
4124         ATTRIBUTE_UNUSED_RESULT.
4125
4126 2019-03-05  Tom Tromey  <tromey@adacore.com>
4127
4128         * macroexp.c (struct macro_buffer) <release>: Add
4129         ATTRIBUTE_UNUSED_RESULT.
4130
4131 2019-03-05  Tom Tromey  <tromey@adacore.com>
4132
4133         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4134         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4135         ATTRIBUTE_UNUSED_RESULT.
4136
4137 2019-03-05  Tom Tromey  <tromey@adacore.com>
4138
4139         * common/scoped_fd.h (class scoped_fd) <release>: Add
4140         ATTRIBUTE_UNUSED_RESULT.
4141
4142 2019-03-05  Tom Tromey  <tromey@adacore.com>
4143
4144         * parser-defs.h (struct parser_state) <release>: Add
4145         ATTRIBUTE_UNUSED_RESULT.
4146
4147 2019-03-05  Tom Tromey  <tromey@adacore.com>
4148
4149         * utils.h (class gdb_argv) <release>: Add
4150         ATTRIBUTE_UNUSED_RESULT.
4151         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4152
4153 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4154
4155         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4156         for-loop range, to avoid compiler warnings.
4157
4158         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4159         avoid compiler warnings about unused variables.
4160
4161         * NEWS: Mention end of support for native debugging on MS-Windows
4162         before XP.
4163
4164         PR gdb/24292
4165         * common/netstuff.c:
4166         * gdbserver/gdbreplay.c
4167         * gdbserver/remote-utils.c:
4168         * ser-tcp.c:
4169         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4170         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4171         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4172         'getaddrinfo' and 'freeaddrinfo' were not available before
4173         Windows XP, and mingw.org's MinGW headers by default define
4174         _WIN32_WINNT to 0x500.
4175
4176 2019-03-01  Gary Benson <gbenson@redhat.com>
4177
4178         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4179
4180 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4181             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4182
4183         PR gdb/8527
4184         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4185         set_sigint_trap, clear_sigint_trap.
4186
4187 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4188
4189         * target.c (target_detach): Clear the regcache and the
4190         frame cache.
4191
4192 2019-02-27  Pedro Alves  <palves@redhat.com>
4193
4194         * utils.c (set_screen_size): When we cap the height/width sizes,
4195         tweak the corresponding command variable to show "unlimited":
4196
4197 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4198             Pedro Alves  <palves@redhat.com>
4199
4200         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4201         before calling rl_set_screen_size.
4202
4203 2019-02-27  Tom Tromey  <tromey@adacore.com>
4204
4205         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4206         define.
4207         * python/py-value.c: Remove Python 2.4 workaround.
4208         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4209         workaround.
4210         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4211         Python 2.4 workaround.
4212         * python/python-internal.h: Remove Python 2.4 comment.
4213         (Py_ssize_t): Don't define.
4214         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4215         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4216         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4217         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4218         * python/python.c (do_start_initialization): Remove Python 2.4
4219         workaround.
4220         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4221         (print_children): Remove Python 2.4 workaround.
4222         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4223         workaround.
4224         (CHARBUFFERPROC_NAME): Remove.
4225         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4226         Python 2.4 workaround.
4227
4228 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4229
4230         * NEWS: Note minimum Python version.
4231
4232 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4233
4234         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4235         code from these functions.  Remove corresponding ifdefs.  Use
4236         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4237         Remove gotos and target of gotos.
4238         (infpy_search_memory): Likewise.
4239
4240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4243         (hppa_gdbarch_init): Don't register deleted functions with
4244         gdbarch.
4245
4246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4249         (h8300_unwind_sp): Delete.
4250         (h8300_dummy_id): Delete.
4251         (h8300_gdbarch_init): Don't register deleted functions with
4252         gdbarch.
4253
4254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4257         (ft32_unwind_pc): Delete.
4258         (ft32_unwind_sp): Delete.
4259         (ft32_gdbarch_init): Don't register deleted functions with
4260         gdbarch.
4261
4262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4265         (frv_unwind_pc): Delete.
4266         (frv_unwind_sp): Delete.
4267         (frv_gdbarch_init): Don't register deleted functions with
4268         gdbarch.
4269
4270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4273         (riscv_unwind_pc): Delete.
4274         (riscv_unwind_sp): Delete.
4275         (riscv_gdbarch_init): Don't register deleted functions with
4276         gdbarch.
4277
4278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4281         (csky_unwind_pc): Delete.
4282         (csky_unwind_sp): Delete.
4283         (csky_gdbarch_init): Don't register deleted functions with
4284         gdbarch.
4285
4286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4287
4288         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4289         (cris_unwind_pc): Delete.
4290         (cris_unwind_sp): Delete.
4291         (cris_gdbarch_init): Don't register deleted functions with
4292         gdbarch.
4293
4294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4297         (bfin_unwind_pc): Delete.
4298         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4299
4300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4303         (arm_unwind_pc): Delete.
4304         (arm_unwind_sp): Delete.
4305         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4306
4307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4308
4309         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4310         (arc_unwind_pc): Delete.
4311         (arc_unwind_sp): Delete.
4312         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4313
4314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4317         (alpha_unwind_pc): Delete.
4318         (alpha_gdbarch_init): Don't register deleted functions with
4319         gdbarch.
4320
4321 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4322
4323         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4324         (aarch64_unwind_pc): Delete.
4325         (aarch64_unwind_sp): Delete.
4326         (aarch64_gdbarch_init): Don't register deleted functions with
4327         gdbarch.
4328
4329 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         * gdbtypes.c (type_align): Don't consider static members when
4332         computing structure alignment.
4333
4334 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4335
4336         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4337         return 0 for other types.
4338         * arch-utils.c (default_type_align): Always return 0.
4339         * gdbarch.h: Regenerate.
4340         * gdbarch.sh (type_align): Extend comment.
4341         * gdbtypes.c (type_align): Add additional comments, always call
4342         gdbarch_type_align before applying the default rules.
4343         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4344         generic code will then apply a suitable default.
4345         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4346         types, return 0 for other types.
4347
4348 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4349
4350         * NEWS: Create a new section for the next release branch.
4351         Rename the section of the current branch, now that it has
4352         been cut.
4353
4354 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4355
4356         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4357         * version.in: Bump version to 8.3.50.DATE-git.
4358
4359 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4360
4361         * aix-thread.c (ptid_cmp): Remove unused variable.
4362         (get_signaled_thread): Likewise.
4363         (store_regs_user_thread): Likewise.
4364         (store_regs_kernel_thread): Likewise.
4365         (fetch_regs_kernel_thread): Remove shadowed variable.
4366
4367 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * features/riscv/32bit-cpu.xml: Add register numbers.
4370         * features/riscv/32bit-fpu.c: Regenerate.
4371         * features/riscv/32bit-fpu.xml: Add register numbers.
4372         * features/riscv/64bit-cpu.xml: Add register numbers.
4373         * features/riscv/64bit-fpu.c: Regenerate.
4374         * features/riscv/64bit-fpu.xml: Add register numbers.
4375
4376 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4377
4378         * NEWS: Mention two argument form of gdb.Value constructor.
4379         * python/py-value.c (convert_buffer_and_type_to_value): New
4380         function.
4381         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4382         Add support for handling an optional second argument.  Call
4383         convert_buffer_and_type_to_value as appropriate.
4384         * python/python-internal.h (Py_buffer_deleter): New struct.
4385         (Py_buffer_up): New typedef.
4386
4387 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4388
4389         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4390         instead of releasing ownership.
4391
4392 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4393
4394         * dwarf2read.c (open_and_init_dwp_file): Call
4395         elf_numsections instead of bfd_count_sections to initialize
4396         dwp_file->num_sections.
4397
4398 2019-02-25  Tom Tromey  <tromey@adacore.com>
4399
4400         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4401
4402 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4403
4404         * gcore.in: Add '--readnever' option when invoking GDB.
4405
4406 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4407
4408         * MAINTAINERS: Update my email address.
4409
4410 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4411
4412         * build-id.c (build_id_to_debug_bfd_1): New function.
4413         (build_id_to_debug_bfd): Look for separate debug file in
4414         sysroot.
4415
4416 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4417
4418         * gdbarch.sh: Update the copyright year range that is placed into
4419         generated files.
4420
4421 2019-02-22  Keith Seitz  <keiths@redhat.com>
4422
4423         PR symtab/23853
4424         * linespec.c (create_sals_line_offset): Search for the default
4425         symtab's filename instead of its fullname.
4426
4427 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4428
4429         * NEWS: Update style defaults.
4430
4431 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4432
4433         * main.c (captured_main_1): Disable styling in batch mode.
4434
4435 2019-02-20  Tom Tromey  <tom@tromey.com>
4436
4437         * symtab.c (symtab_symbol_info): Fix typos.
4438
4439 2019-02-20  Tom Tromey  <tromey@adacore.com>
4440
4441         * findcmd.c (_initialize_mem_search): Use upper case for
4442         metasyntactic variables.
4443
4444 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4445
4446         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4447         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4448
4449 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4450
4451         * top.h (source_file_name): Change to std::string.
4452         * top.c (source_file_name): Likewise.
4453         (command_line_input): Adjust.
4454         * cli/cli-script.c (script_from_file): Adjust.
4455
4456 2019-02-19  Tom Tromey  <tromey@adacore.com>
4457
4458         * ravenscar-thread.c
4459         (ravenscar_thread_target::update_thread_list): Don't call
4460         ada_build_task_list.
4461         * ada-lang.h (ada_build_task_list): Don't declare.
4462         * ada-tasks.c (struct ada_tasks_inferior_data)
4463         <task_list_valid_p>: Now bool.
4464         (read_known_tasks, ada_task_list_changed)
4465         (ada_tasks_invalidate_inferior_data): Update.
4466         (read_known_tasks_array): Return bool.
4467         (read_known_tasks_list): Likewise.
4468         (read_known_tasks): Return void.
4469         (ada_build_task_list): Now static.
4470
4471 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4474         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4475
4476 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4477
4478         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4479         variant for ada_tasks_pspace_data_handle and
4480         ada_tasks_inferior_data_handle.
4481         (ada_tasks_pspace_data_cleanup): New function.
4482         (ada_tasks_inferior_data_cleanup): New function.
4483
4484 2019-02-17  Tom Tromey  <tom@tromey.com>
4485
4486         * macrotab.h (macro_source_fullname): Return a std::string.
4487         * macrotab.c (macro_include, check_for_redefinition)
4488         (macro_undef, macro_lookup_definition, foreach_macro)
4489         (foreach_macro_in_scope): Update.
4490         (macro_source_fullname): Return a std::string.
4491         * macrocmd.c (show_pp_source_pos): Update.
4492
4493 2019-02-17  Tom Tromey  <tom@tromey.com>
4494
4495         * macrocmd.c (show_pp_source_pos): Style the file names.
4496
4497 2019-02-17  Tom Tromey  <tom@tromey.com>
4498
4499         PR tui/24197:
4500         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4501
4502 2019-02-17  Tom Tromey  <tom@tromey.com>
4503
4504         * ada-lang.c (user_select_syms): Use filtered printing.
4505         * utils.c (wrap_style): New global.
4506         (desired_style): Remove.
4507         (emit_style_escape): Add stream parameter.
4508         (set_output_style, reset_terminal_style, prompt_for_continue):
4509         Update.
4510         (flush_wrap_buffer): Only flush gdb_stdout.
4511         (wrap_here): Set wrap_style.
4512         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4513         treat escape sequences as a character.  Change when wrap buffer is
4514         flushed.
4515         (fputs_styled): Do not set the output style when the default is
4516         requested.
4517         * ui-style.h (struct ui_file_style) <is_default>: New method.
4518         * source.c (print_source_lines_base): Emit escape sequences in one
4519         piece.
4520
4521 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4522
4523         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4524         integers and enumeration types.
4525
4526 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4527
4528         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4529         instead of lookup_symbol_in_language
4530         (do_exact_match): New function.
4531         (ada_get_symbol_name_matcher): Return do_exact_match when
4532         doing a verbatim match.
4533
4534 2019-02-15  Tom Tromey  <tromey@adacore.com>
4535
4536         * ravenscar-thread.c (ravenscar_thread_target::resume)
4537         (ravenscar_thread_target::wait): Special case wildcard requests.
4538
4539 2019-02-15  Tom Tromey  <tromey@adacore.com>
4540
4541         * ravenscar-thread.c (base_ptid): Remove.
4542         (struct ravenscar_thread_target) <close>: New method.
4543         <m_base_ptid>: New member.
4544         <update_inferior_ptid, active_task, task_is_currently_active,
4545         runtime_initialized>: Declare methods.
4546         <ravenscar_thread_target>: Add constructor.
4547         (ravenscar_thread_target::task_is_currently_active)
4548         (ravenscar_thread_target::update_inferior_ptid)
4549         (ravenscar_runtime_initialized): Rename.  Now methods.
4550         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4551         (ravenscar_thread_target::update_thread_list): Update.
4552         (ravenscar_thread_target::active_task): Now method.
4553         (ravenscar_thread_target::store_registers)
4554         (ravenscar_thread_target::prepare_to_store)
4555         (ravenscar_thread_target::prepare_to_store)
4556         (ravenscar_thread_target::mourn_inferior): Update.
4557         (ravenscar_inferior_created): Use "new" to create target.
4558         (ravenscar_thread_target::get_ada_task_ptid): Update.
4559         (_initialize_ravenscar): Don't initialize base_ptid.
4560         (ravenscar_ops): Remove global.
4561
4562 2019-02-15  Tom Tromey  <tromey@adacore.com>
4563
4564         * target.h (push_target): Declare new overload.
4565         * target.c (push_target): New overload, taking an rvalue reference.
4566         * remote.c (remote_target::open_1): Use push_target overload.
4567         * corelow.c (core_target_open): Use push_target overload.
4568
4569 2019-02-15  Tom Tromey  <tromey@adacore.com>
4570
4571         * ravenscar-thread.c (is_ravenscar_task)
4572         (ravenscar_task_is_currently_active): Return bool.
4573         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4574         (_initialize_ravenscar): Remove "(void)".
4575         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4576         Return bool.
4577
4578 2019-02-15  Tom Tromey  <tromey@adacore.com>
4579
4580         * ravenscar-thread.c (ravenscar_runtime_initializer)
4581         (has_ravenscar_runtime, get_running_thread_id)
4582         (ravenscar_thread_target::resume): Fix indentation.
4583
4584 2019-02-15  Tom Tromey  <tromey@adacore.com>
4585
4586         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4587         from ravenscar_arch_ops.
4588         (sparc_ravenscar_ops::fetch_registers)
4589         (sparc_ravenscar_ops::store_registers): Now methods.
4590         (sparc_ravenscar_prepare_to_store): Remove.
4591         (sparc_ravenscar_ops): Redefine.
4592         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4593         methods and destructor.  Remove members.
4594         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4595         (ravenscar_thread_target::store_registers)
4596         (ravenscar_thread_target::prepare_to_store): Update.
4597         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4598         Remove.
4599         (struct ppc_ravenscar_powerpc_ops): Derive from
4600         ravenscar_arch_ops.
4601         (ppc_ravenscar_powerpc_ops::fetch_registers)
4602         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4603         (ppc_ravenscar_powerpc_ops): Redefine.
4604         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4605         (ppc_ravenscar_e500_ops::fetch_registers)
4606         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4607         (ppc_ravenscar_e500_ops): Redefine.
4608         * aarch64-ravenscar-thread.c
4609         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4610         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4611         (aarch64_ravenscar_fetch_registers)
4612         (aarch64_ravenscar_store_registers): Now methods.
4613         (aarch64_ravenscar_ops): Redefine.
4614
4615 2019-02-15  Tom Tromey  <tromey@adacore.com>
4616
4617         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4618         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4619         (ravenscar_thread_target::stopped_by_watchpoint)
4620         (ravenscar_thread_target::stopped_data_address)
4621         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4622
4623 2019-02-15  Tom Tromey  <tromey@adacore.com>
4624
4625         * ravenscar-thread.c: Fix some typos.
4626
4627 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4628             Tom Tromey  <tromey@adacore.com>
4629
4630         * ada-lang.c (ada_exception_sal): Change addr_string to a
4631         std::string.
4632         (create_ada_exception_catchpoint): Update.
4633
4634 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4635             Tom Tromey  <tromey@adacore.com>
4636
4637         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4638         (bp_location_ops): Remove.
4639         (base_breakpoint_allocate_location): Update.
4640         (free_bp_location): Update.
4641         * ada-lang.c (class ada_catchpoint_location)
4642         <ada_catchpoint_location>: Remove ops parameter.
4643         (ada_catchpoint_location_dtor): Remove.
4644         (ada_catchpoint_location_ops): Remove.
4645         (allocate_location_exception): Update.
4646         * breakpoint.h (struct bp_location_ops): Remove.
4647         (class bp_location) <bp_location>: Remove bp_location_ops
4648         parameter.
4649         <~bp_location>: Add destructor.
4650         <ops>: Remove.
4651
4652 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4653             Pedro Alves  <palves@redhat.com>
4654
4655         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4656         'PATH_MAX'.
4657
4658 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4659             Samuel Thibault  <samuel.thibault@gnu.org>
4660             Thomas Schwinge  <thomas@codesourcery.com>
4661
4662         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4663         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4664
4665 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4666
4667         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4668         (check_empty): Use "const char *".
4669
4670         * gnu-nat.c (gnu_nat_target::detach): Instead of
4671         'detach_inferior (pid)' call
4672         'detach_inferior (find_inferior_pid (pid))'.
4673
4674         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4675         'nat/fork-inferior.o'.
4676         * gnu-nat.c: #include "nat/fork-inferior.h".
4677
4678         * gnu-nat.c (gnu_nat_target::detach): Instead of
4679         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4680         * gnu-nat.h: #include "inf-child.h".
4681         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4682         'i386_gnu_nat_target::fetch_registers'.
4683         (gnu_store_registers): Rename/move to
4684         'i386_gnu_nat_target::store_registers'.
4685
4686         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4687         * gnu-nat.h (mach_thread_info): New function.
4688         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4689
4690         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4691
4692 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4693
4694         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4695
4696 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4697
4698         * windows-nat.c (windows_add_thread): Add new parameter
4699         "main_thread_p" with default value set to false.  Update
4700         function documentation as well as all callers.
4701         (windows_delete_thread): Likewise.
4702         (fake_create_process): Update call to windows_add_thread.
4703         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4704         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4705         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4706         call to windows_delete_thread.
4707
4708 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4709
4710         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4711
4712 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4713
4714         * symfile.c (find_separate_debug_file): Use canonical path of
4715         sysroot with child_path instead of gdb_sysroot if it is valid.
4716
4717 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4718
4719         * symfile.c (find_separate_debug_file): Use child_path to
4720         determine if an object file is under a sysroot.
4721
4722 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4723
4724         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4725         unittests/child-path-selftests.c.
4726         * common/pathstuff.c (child_path): New function.
4727         * common/pathstuff.h (child_path): New prototype.
4728         * unittests/child-path-selftests.c: New file.
4729
4730 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4731
4732         * symfile.c (find_separate_debug_file): Look for separate debug
4733         files in debug directories under the sysroot.
4734
4735 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4736
4737         * symtab.h (struct minimal_symbol data_p): New const method.
4738         (struct minimal_symbol text_p): Likewise.
4739         * symtab.c (output_source_filename): Use file name style
4740         to print file name.
4741         (print_symbol_info): Likewise.
4742         (print_msymbol_info): Use address style to print addresses.
4743         Use function name style to print executable text symbols.
4744         (expand_symtab_containing_pc): Use data_p.
4745         (find_pc_sect_compunit_symtab): Likewise.
4746
4747 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4748
4749         * breakpoint.c (describe_other_breakpoints): Use address style
4750         to print addresses.
4751         (say_where): Likewise.
4752
4753 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4754
4755         * ada-typeprint.c (print_func_type): Print function name
4756         style to print function name.
4757         * c-typeprint.c (c_print_type_1): Likewise.
4758
4759 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4760
4761         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4762         for execve.
4763
4764 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4765
4766         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4767         type_stack.
4768
4769 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4770
4771         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4772         TYPE_CODE_REF types.
4773
4774 2019-02-08  Jim Wilson  <jimw@sifive.com>
4775
4776         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4777         (riscv_linux_fregset): New.
4778         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4779
4780 2019-02-07  Tom Tromey  <tom@tromey.com>
4781
4782         * thread.c (thread_cancel_execution_command): Update.
4783         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4784         methods.
4785         (struct thread_fsm_ops): Remove.
4786         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4787         (thread_fsm_should_stop, thread_fsm_return_value)
4788         (thread_fsm_set_finished, thread_fsm_finished_p)
4789         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4790         Don't declare.
4791         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4792         * infrun.c (clear_proceed_status_thread)
4793         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4794         (print_stop_event): Update.
4795         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4796         Add constructor.
4797         (step_command_fsm_ops): Remove.
4798         (new_step_command_fsm): Remove.
4799         (step_1): Update.
4800         (step_command_fsm::should_stop): Rename from
4801         step_command_fsm_should_stop.
4802         (step_command_fsm::clean_up): Rename from
4803         step_command_fsm_clean_up.
4804         (step_command_fsm::do_async_reply_reason): Rename from
4805         step_command_fsm_async_reply_reason.
4806         (struct until_next_fsm): Inherit from thread_fsm.  Add
4807         constructor.
4808         (until_next_fsm_ops): Remove.
4809         (new_until_next_fsm): Remove.
4810         (until_next_fsm::should_stop): Rename from
4811         until_next_fsm_should_stop.
4812         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4813         (until_next_fsm::do_async_reply_reason): Rename from
4814         until_next_fsm_async_reply_reason.
4815         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4816         constructor.  Change type of breakpoint.
4817         (finish_command_fsm_ops): Remove.
4818         (new_finish_command_fsm): Remove.
4819         (finish_command_fsm::should_stop): Rename from
4820         finish_command_fsm_should_stop.
4821         (finish_command_fsm::clean_up): Rename from
4822         finish_command_fsm_clean_up.
4823         (finish_command_fsm::return_value): Rename from
4824         finish_command_fsm_return_value.
4825         (finish_command_fsm::do_async_reply_reason): Rename from
4826         finish_command_fsm_async_reply_reason.
4827         (finish_command): Update.
4828         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4829         Add constructor.
4830         (call_thread_fsm_ops): Remove.
4831         (call_thread_fsm::call_thread_fsm): Rename from
4832         new_call_thread_fsm.
4833         (call_thread_fsm::should_stop): Rename from
4834         call_thread_fsm_should_stop.
4835         (call_thread_fsm::should_notify_stop): Rename from
4836         call_thread_fsm_should_notify_stop.
4837         (run_inferior_call, call_function_by_hand_dummy): Update.
4838         * cli/cli-interp.c (should_print_stop_to_console): Update.
4839         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4840         Add constructor.  Change type of location_breakpoint,
4841         caller_breakpoint.
4842         (until_break_fsm_ops): Remove.
4843         (new_until_break_fsm): Remove.
4844         (until_break_fsm::should_stop): Rename from
4845         until_break_fsm_should_stop.
4846         (until_break_fsm::clean_up): Rename from
4847         until_break_fsm_clean_up.
4848         (until_break_fsm::do_async_reply_reason): Rename from
4849         until_break_fsm_async_reply_reason.
4850         (until_break_command): Update.
4851         * thread-fsm.c: Remove.
4852         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4853
4854 2019-02-07  Tom Tromey  <tom@tromey.com>
4855
4856         * yy-remap.h: Add include guard.
4857         * xtensa-tdep.h: Add include guard.
4858         * xcoffread.h: Rename include guard.
4859         * varobj-iter.h: Add include guard.
4860         * tui/tui.h: Rename include guard.
4861         * tui/tui-winsource.h: Rename include guard.
4862         * tui/tui-wingeneral.h: Rename include guard.
4863         * tui/tui-windata.h: Rename include guard.
4864         * tui/tui-win.h: Rename include guard.
4865         * tui/tui-stack.h: Rename include guard.
4866         * tui/tui-source.h: Rename include guard.
4867         * tui/tui-regs.h: Rename include guard.
4868         * tui/tui-out.h: Rename include guard.
4869         * tui/tui-layout.h: Rename include guard.
4870         * tui/tui-io.h: Rename include guard.
4871         * tui/tui-hooks.h: Rename include guard.
4872         * tui/tui-file.h: Rename include guard.
4873         * tui/tui-disasm.h: Rename include guard.
4874         * tui/tui-data.h: Rename include guard.
4875         * tui/tui-command.h: Rename include guard.
4876         * tic6x-tdep.h: Add include guard.
4877         * target/waitstatus.h: Rename include guard.
4878         * target/wait.h: Rename include guard.
4879         * target/target.h: Rename include guard.
4880         * target/resume.h: Rename include guard.
4881         * target-float.h: Rename include guard.
4882         * stabsread.h: Add include guard.
4883         * rs6000-tdep.h: Add include guard.
4884         * riscv-fbsd-tdep.h: Add include guard.
4885         * regformats/regdef.h: Rename include guard.
4886         * record.h: Rename include guard.
4887         * python/python.h: Rename include guard.
4888         * python/python-internal.h: Rename include guard.
4889         * python/py-stopevent.h: Rename include guard.
4890         * python/py-ref.h: Rename include guard.
4891         * python/py-record.h: Rename include guard.
4892         * python/py-record-full.h: Rename include guard.
4893         * python/py-record-btrace.h: Rename include guard.
4894         * python/py-instruction.h: Rename include guard.
4895         * python/py-events.h: Rename include guard.
4896         * python/py-event.h: Rename include guard.
4897         * procfs.h: Add include guard.
4898         * proc-utils.h: Add include guard.
4899         * p-lang.h: Add include guard.
4900         * or1k-tdep.h: Rename include guard.
4901         * observable.h: Rename include guard.
4902         * nto-tdep.h: Rename include guard.
4903         * nat/x86-linux.h: Rename include guard.
4904         * nat/x86-linux-dregs.h: Rename include guard.
4905         * nat/x86-gcc-cpuid.h: Add include guard.
4906         * nat/x86-dregs.h: Rename include guard.
4907         * nat/x86-cpuid.h: Rename include guard.
4908         * nat/ppc-linux.h: Rename include guard.
4909         * nat/mips-linux-watch.h: Rename include guard.
4910         * nat/linux-waitpid.h: Rename include guard.
4911         * nat/linux-ptrace.h: Rename include guard.
4912         * nat/linux-procfs.h: Rename include guard.
4913         * nat/linux-osdata.h: Rename include guard.
4914         * nat/linux-nat.h: Rename include guard.
4915         * nat/linux-namespaces.h: Rename include guard.
4916         * nat/linux-btrace.h: Rename include guard.
4917         * nat/glibc_thread_db.h: Rename include guard.
4918         * nat/gdb_thread_db.h: Rename include guard.
4919         * nat/gdb_ptrace.h: Rename include guard.
4920         * nat/fork-inferior.h: Rename include guard.
4921         * nat/amd64-linux-siginfo.h: Rename include guard.
4922         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4923         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4924         * nat/aarch64-linux.h: Rename include guard.
4925         * nat/aarch64-linux-hw-point.h: Rename include guard.
4926         * mn10300-tdep.h: Add include guard.
4927         * mips-linux-tdep.h: Add include guard.
4928         * mi/mi-parse.h: Rename include guard.
4929         * mi/mi-out.h: Rename include guard.
4930         * mi/mi-main.h: Rename include guard.
4931         * mi/mi-interp.h: Rename include guard.
4932         * mi/mi-getopt.h: Rename include guard.
4933         * mi/mi-console.h: Rename include guard.
4934         * mi/mi-common.h: Rename include guard.
4935         * mi/mi-cmds.h: Rename include guard.
4936         * mi/mi-cmd-break.h: Rename include guard.
4937         * m2-lang.h: Add include guard.
4938         * location.h: Rename include guard.
4939         * linux-record.h: Rename include guard.
4940         * linux-nat.h: Add include guard.
4941         * linux-fork.h: Add include guard.
4942         * i386-darwin-tdep.h: Rename include guard.
4943         * hppa-linux-offsets.h: Add include guard.
4944         * guile/guile.h: Rename include guard.
4945         * guile/guile-internal.h: Rename include guard.
4946         * gnu-nat.h: Rename include guard.
4947         * gdb-stabs.h: Rename include guard.
4948         * frv-tdep.h: Add include guard.
4949         * f-lang.h: Add include guard.
4950         * event-loop.h: Add include guard.
4951         * darwin-nat.h: Rename include guard.
4952         * cp-abi.h: Rename include guard.
4953         * config/sparc/nm-sol2.h: Rename include guard.
4954         * config/nm-nto.h: Rename include guard.
4955         * config/nm-linux.h: Add include guard.
4956         * config/i386/nm-i386gnu.h: Rename include guard.
4957         * config/djgpp/nl_types.h: Rename include guard.
4958         * config/djgpp/langinfo.h: Rename include guard.
4959         * compile/gcc-cp-plugin.h: Add include guard.
4960         * compile/gcc-c-plugin.h: Add include guard.
4961         * compile/compile.h: Rename include guard.
4962         * compile/compile-object-run.h: Rename include guard.
4963         * compile/compile-object-load.h: Rename include guard.
4964         * compile/compile-internal.h: Rename include guard.
4965         * compile/compile-cplus.h: Rename include guard.
4966         * compile/compile-c.h: Rename include guard.
4967         * common/xml-utils.h: Rename include guard.
4968         * common/x86-xstate.h: Rename include guard.
4969         * common/version.h: Rename include guard.
4970         * common/vec.h: Rename include guard.
4971         * common/tdesc.h: Rename include guard.
4972         * common/selftest.h: Rename include guard.
4973         * common/scoped_restore.h: Rename include guard.
4974         * common/scoped_mmap.h: Rename include guard.
4975         * common/scoped_fd.h: Rename include guard.
4976         * common/safe-iterator.h: Rename include guard.
4977         * common/run-time-clock.h: Rename include guard.
4978         * common/refcounted-object.h: Rename include guard.
4979         * common/queue.h: Rename include guard.
4980         * common/ptid.h: Rename include guard.
4981         * common/print-utils.h: Rename include guard.
4982         * common/preprocessor.h: Rename include guard.
4983         * common/pathstuff.h: Rename include guard.
4984         * common/observable.h: Rename include guard.
4985         * common/netstuff.h: Rename include guard.
4986         * common/job-control.h: Rename include guard.
4987         * common/host-defs.h: Rename include guard.
4988         * common/gdb_wait.h: Rename include guard.
4989         * common/gdb_vecs.h: Rename include guard.
4990         * common/gdb_unlinker.h: Rename include guard.
4991         * common/gdb_unique_ptr.h: Rename include guard.
4992         * common/gdb_tilde_expand.h: Rename include guard.
4993         * common/gdb_sys_time.h: Rename include guard.
4994         * common/gdb_string_view.h: Rename include guard.
4995         * common/gdb_splay_tree.h: Rename include guard.
4996         * common/gdb_setjmp.h: Rename include guard.
4997         * common/gdb_ref_ptr.h: Rename include guard.
4998         * common/gdb_optional.h: Rename include guard.
4999         * common/gdb_locale.h: Rename include guard.
5000         * common/gdb_assert.h: Rename include guard.
5001         * common/filtered-iterator.h: Rename include guard.
5002         * common/filestuff.h: Rename include guard.
5003         * common/fileio.h: Rename include guard.
5004         * common/environ.h: Rename include guard.
5005         * common/common-utils.h: Rename include guard.
5006         * common/common-types.h: Rename include guard.
5007         * common/common-regcache.h: Rename include guard.
5008         * common/common-inferior.h: Rename include guard.
5009         * common/common-gdbthread.h: Rename include guard.
5010         * common/common-exceptions.h: Rename include guard.
5011         * common/common-defs.h: Rename include guard.
5012         * common/common-debug.h: Rename include guard.
5013         * common/cleanups.h: Rename include guard.
5014         * common/buffer.h: Rename include guard.
5015         * common/btrace-common.h: Rename include guard.
5016         * common/break-common.h: Rename include guard.
5017         * cli/cli-utils.h: Rename include guard.
5018         * cli/cli-style.h: Rename include guard.
5019         * cli/cli-setshow.h: Rename include guard.
5020         * cli/cli-script.h: Rename include guard.
5021         * cli/cli-interp.h: Rename include guard.
5022         * cli/cli-decode.h: Rename include guard.
5023         * cli/cli-cmds.h: Rename include guard.
5024         * charset-list.h: Add include guard.
5025         * buildsym-legacy.h: Rename include guard.
5026         * bfin-tdep.h: Add include guard.
5027         * ax.h: Rename include guard.
5028         * arm-linux-tdep.h: Add include guard.
5029         * arm-fbsd-tdep.h: Add include guard.
5030         * arch/xtensa.h: Rename include guard.
5031         * arch/tic6x.h: Add include guard.
5032         * arch/i386.h: Add include guard.
5033         * arch/arm.h: Rename include guard.
5034         * arch/arm-linux.h: Rename include guard.
5035         * arch/arm-get-next-pcs.h: Rename include guard.
5036         * arch/amd64.h: Add include guard.
5037         * arch/aarch64-insn.h: Rename include guard.
5038         * arch-utils.h: Rename include guard.
5039         * annotate.h: Add include guard.
5040         * amd64-darwin-tdep.h: Rename include guard.
5041         * aarch64-linux-tdep.h: Add include guard.
5042         * aarch64-fbsd-tdep.h: Add include guard.
5043         * aarch32-linux-nat.h: Add include guard.
5044
5045 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5046
5047         * macrotab.c (macro_define_internal): New function that
5048         factorizes macro_define_object_internal and macro_define_function
5049         code.
5050         (macro_define_object_internal): Use macro_define_internal.
5051         (macro_define_function): Likewise.
5052
5053 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5054
5055         * macrocmd.c (extract_identifier): Return
5056         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5057         callers.
5058
5059 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5060
5061         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5062
5063 2019-02-05  Tom Tromey  <tom@tromey.com>
5064
5065         * target.c (target_stack::unpush): Move assertion earlier.
5066
5067 2019-01-30  Tom Tromey  <tom@tromey.com>
5068
5069         PR python/23615:
5070         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5071         (gdbpy_parse_and_eval): Likewise.
5072         * python/python-internal.h (gdbpy_allow_threads): New class.
5073
5074 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5075
5076         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5077         (aarch64_fbsd_fpregmap): Move earlier.
5078         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5079         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5080         instead of individual calls to trad_frame_set_reg_addr.
5081         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5082         earlier.
5083         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5084         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5085         instead of individual calls to trad_frame_set_reg_addr.
5086
5087 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5088
5089         * CONTRIBUTE: Replace contribution list with wiki link.
5090
5091 2019-01-25  Tom Tromey  <tom@tromey.com>
5092
5093         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5094
5095 2019-01-25  Tom Tromey  <tom@tromey.com>
5096
5097         * xtensa-linux-nat.c: Fix common/ includes.
5098         * xml-support.h: Fix common/ includes.
5099         * xml-support.c: Fix common/ includes.
5100         * x86-linux-nat.c: Fix common/ includes.
5101         * windows-nat.c: Fix common/ includes.
5102         * varobj.h: Fix common/ includes.
5103         * varobj.c: Fix common/ includes.
5104         * value.c: Fix common/ includes.
5105         * valops.c: Fix common/ includes.
5106         * utils.c: Fix common/ includes.
5107         * unittests/xml-utils-selftests.c: Fix common/ includes.
5108         * unittests/utils-selftests.c: Fix common/ includes.
5109         * unittests/unpack-selftests.c: Fix common/ includes.
5110         * unittests/tracepoint-selftests.c: Fix common/ includes.
5111         * unittests/style-selftests.c: Fix common/ includes.
5112         * unittests/string_view-selftests.c: Fix common/ includes.
5113         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5114         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5115         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5116         * unittests/rsp-low-selftests.c: Fix common/ includes.
5117         * unittests/parse-connection-spec-selftests.c: Fix common/
5118         includes.
5119         * unittests/optional-selftests.c: Fix common/ includes.
5120         * unittests/offset-type-selftests.c: Fix common/ includes.
5121         * unittests/observable-selftests.c: Fix common/ includes.
5122         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5123         * unittests/memrange-selftests.c: Fix common/ includes.
5124         * unittests/memory-map-selftests.c: Fix common/ includes.
5125         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5126         * unittests/function-view-selftests.c: Fix common/ includes.
5127         * unittests/environ-selftests.c: Fix common/ includes.
5128         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5129         * unittests/common-utils-selftests.c: Fix common/ includes.
5130         * unittests/cli-utils-selftests.c: Fix common/ includes.
5131         * unittests/array-view-selftests.c: Fix common/ includes.
5132         * ui-file.c: Fix common/ includes.
5133         * tui/tui-io.c: Fix common/ includes.
5134         * tracepoint.h: Fix common/ includes.
5135         * tracepoint.c: Fix common/ includes.
5136         * tracefile-tfile.c: Fix common/ includes.
5137         * top.h: Fix common/ includes.
5138         * top.c: Fix common/ includes.
5139         * thread.c: Fix common/ includes.
5140         * target/waitstatus.h: Fix common/ includes.
5141         * target/waitstatus.c: Fix common/ includes.
5142         * target.h: Fix common/ includes.
5143         * target.c: Fix common/ includes.
5144         * target-memory.c: Fix common/ includes.
5145         * target-descriptions.c: Fix common/ includes.
5146         * symtab.h: Fix common/ includes.
5147         * symfile.c: Fix common/ includes.
5148         * stap-probe.c: Fix common/ includes.
5149         * spu-linux-nat.c: Fix common/ includes.
5150         * sparc-nat.c: Fix common/ includes.
5151         * source.c: Fix common/ includes.
5152         * solib.c: Fix common/ includes.
5153         * solib-target.c: Fix common/ includes.
5154         * ser-unix.c: Fix common/ includes.
5155         * ser-tcp.c: Fix common/ includes.
5156         * ser-pipe.c: Fix common/ includes.
5157         * ser-base.c: Fix common/ includes.
5158         * selftest-arch.c: Fix common/ includes.
5159         * s12z-tdep.c: Fix common/ includes.
5160         * rust-exp.y: Fix common/ includes.
5161         * rs6000-aix-tdep.c: Fix common/ includes.
5162         * riscv-tdep.c: Fix common/ includes.
5163         * remote.c: Fix common/ includes.
5164         * remote-notif.h: Fix common/ includes.
5165         * remote-fileio.h: Fix common/ includes.
5166         * remote-fileio.c: Fix common/ includes.
5167         * regcache.h: Fix common/ includes.
5168         * regcache.c: Fix common/ includes.
5169         * record-btrace.c: Fix common/ includes.
5170         * python/python.c: Fix common/ includes.
5171         * python/py-type.c: Fix common/ includes.
5172         * python/py-inferior.c: Fix common/ includes.
5173         * progspace.h: Fix common/ includes.
5174         * producer.c: Fix common/ includes.
5175         * procfs.c: Fix common/ includes.
5176         * proc-api.c: Fix common/ includes.
5177         * printcmd.c: Fix common/ includes.
5178         * ppc-linux-nat.c: Fix common/ includes.
5179         * parser-defs.h: Fix common/ includes.
5180         * osdata.c: Fix common/ includes.
5181         * obsd-nat.c: Fix common/ includes.
5182         * nat/x86-linux.c: Fix common/ includes.
5183         * nat/x86-linux-dregs.c: Fix common/ includes.
5184         * nat/x86-dregs.h: Fix common/ includes.
5185         * nat/x86-dregs.c: Fix common/ includes.
5186         * nat/ppc-linux.c: Fix common/ includes.
5187         * nat/mips-linux-watch.h: Fix common/ includes.
5188         * nat/mips-linux-watch.c: Fix common/ includes.
5189         * nat/linux-waitpid.c: Fix common/ includes.
5190         * nat/linux-ptrace.h: Fix common/ includes.
5191         * nat/linux-ptrace.c: Fix common/ includes.
5192         * nat/linux-procfs.c: Fix common/ includes.
5193         * nat/linux-personality.c: Fix common/ includes.
5194         * nat/linux-osdata.c: Fix common/ includes.
5195         * nat/linux-namespaces.c: Fix common/ includes.
5196         * nat/linux-btrace.h: Fix common/ includes.
5197         * nat/linux-btrace.c: Fix common/ includes.
5198         * nat/fork-inferior.c: Fix common/ includes.
5199         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5200         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5201         * nat/aarch64-linux.c: Fix common/ includes.
5202         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5203         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5204         * namespace.h: Fix common/ includes.
5205         * mips-linux-tdep.c: Fix common/ includes.
5206         * minsyms.c: Fix common/ includes.
5207         * mi/mi-parse.h: Fix common/ includes.
5208         * mi/mi-main.c: Fix common/ includes.
5209         * mi/mi-cmd-env.c: Fix common/ includes.
5210         * memrange.h: Fix common/ includes.
5211         * memattr.c: Fix common/ includes.
5212         * maint.h: Fix common/ includes.
5213         * maint.c: Fix common/ includes.
5214         * main.c: Fix common/ includes.
5215         * machoread.c: Fix common/ includes.
5216         * location.c: Fix common/ includes.
5217         * linux-thread-db.c: Fix common/ includes.
5218         * linux-nat.c: Fix common/ includes.
5219         * linux-fork.c: Fix common/ includes.
5220         * inline-frame.c: Fix common/ includes.
5221         * infrun.c: Fix common/ includes.
5222         * inflow.c: Fix common/ includes.
5223         * inferior.h: Fix common/ includes.
5224         * inferior.c: Fix common/ includes.
5225         * infcmd.c: Fix common/ includes.
5226         * inf-ptrace.c: Fix common/ includes.
5227         * inf-child.c: Fix common/ includes.
5228         * ia64-linux-nat.c: Fix common/ includes.
5229         * i387-tdep.c: Fix common/ includes.
5230         * i386-tdep.c: Fix common/ includes.
5231         * i386-linux-tdep.c: Fix common/ includes.
5232         * i386-linux-nat.c: Fix common/ includes.
5233         * i386-go32-tdep.c: Fix common/ includes.
5234         * i386-fbsd-tdep.c: Fix common/ includes.
5235         * i386-fbsd-nat.c: Fix common/ includes.
5236         * guile/scm-type.c: Fix common/ includes.
5237         * guile/guile.c: Fix common/ includes.
5238         * go32-nat.c: Fix common/ includes.
5239         * gnu-nat.c: Fix common/ includes.
5240         * gdbthread.h: Fix common/ includes.
5241         * gdbarch-selftests.c: Fix common/ includes.
5242         * gdb_usleep.c: Fix common/ includes.
5243         * gdb_select.h: Fix common/ includes.
5244         * gdb_bfd.c: Fix common/ includes.
5245         * gcore.c: Fix common/ includes.
5246         * fork-child.c: Fix common/ includes.
5247         * findvar.c: Fix common/ includes.
5248         * fbsd-nat.c: Fix common/ includes.
5249         * event-top.c: Fix common/ includes.
5250         * event-loop.c: Fix common/ includes.
5251         * dwarf2read.c: Fix common/ includes.
5252         * dwarf2loc.c: Fix common/ includes.
5253         * dwarf2-frame.c: Fix common/ includes.
5254         * dwarf-index-cache.c: Fix common/ includes.
5255         * dtrace-probe.c: Fix common/ includes.
5256         * disasm-selftests.c: Fix common/ includes.
5257         * defs.h: Fix common/ includes.
5258         * csky-tdep.c: Fix common/ includes.
5259         * cp-valprint.c: Fix common/ includes.
5260         * cp-support.h: Fix common/ includes.
5261         * cp-support.c: Fix common/ includes.
5262         * corelow.c: Fix common/ includes.
5263         * completer.h: Fix common/ includes.
5264         * completer.c: Fix common/ includes.
5265         * compile/compile.c: Fix common/ includes.
5266         * compile/compile-loc2c.c: Fix common/ includes.
5267         * compile/compile-cplus-types.c: Fix common/ includes.
5268         * compile/compile-cplus-symbols.c: Fix common/ includes.
5269         * command.h: Fix common/ includes.
5270         * cli/cli-dump.c: Fix common/ includes.
5271         * cli/cli-cmds.c: Fix common/ includes.
5272         * charset.c: Fix common/ includes.
5273         * build-id.c: Fix common/ includes.
5274         * btrace.h: Fix common/ includes.
5275         * btrace.c: Fix common/ includes.
5276         * breakpoint.h: Fix common/ includes.
5277         * breakpoint.c: Fix common/ includes.
5278         * ax.h:
5279         (enum agent_op): Fix common/ includes.
5280         * ax-general.c (struct aop_map): Fix common/ includes.
5281         * ax-gdb.c: Fix common/ includes.
5282         * auxv.c: Fix common/ includes.
5283         * auto-load.c: Fix common/ includes.
5284         * arm-tdep.c: Fix common/ includes.
5285         * arch/riscv.c: Fix common/ includes.
5286         * arch/ppc-linux-common.c: Fix common/ includes.
5287         * arch/i386.c: Fix common/ includes.
5288         * arch/arm.c: Fix common/ includes.
5289         * arch/arm-linux.c: Fix common/ includes.
5290         * arch/arm-get-next-pcs.c: Fix common/ includes.
5291         * arch/amd64.c: Fix common/ includes.
5292         * arch/aarch64.c: Fix common/ includes.
5293         * arch/aarch64-insn.c: Fix common/ includes.
5294         * arch-utils.c: Fix common/ includes.
5295         * amd64-windows-tdep.c: Fix common/ includes.
5296         * amd64-tdep.c: Fix common/ includes.
5297         * amd64-sol2-tdep.c: Fix common/ includes.
5298         * amd64-obsd-tdep.c: Fix common/ includes.
5299         * amd64-nbsd-tdep.c: Fix common/ includes.
5300         * amd64-linux-tdep.c: Fix common/ includes.
5301         * amd64-linux-nat.c: Fix common/ includes.
5302         * amd64-fbsd-tdep.c: Fix common/ includes.
5303         * amd64-fbsd-nat.c: Fix common/ includes.
5304         * amd64-dicos-tdep.c: Fix common/ includes.
5305         * amd64-darwin-tdep.c: Fix common/ includes.
5306         * agent.c: Fix common/ includes.
5307         * ada-lang.h: Fix common/ includes.
5308         * ada-lang.c: Fix common/ includes.
5309         * aarch64-tdep.c: Fix common/ includes.
5310
5311 2019-01-25  Tom Tromey  <tom@tromey.com>
5312
5313         * common/create-version.sh: Use common/version.h.
5314
5315 2019-01-24  Pedro Alves  <palves@redhat.com>
5316
5317         * infrun.c (signal_stop, signal_print, signal_program)
5318         (signal_catch, signal_pass): Now arrays instead of pointers.
5319         (update_signals_program_target, do_target_resume)
5320         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5321         * linux-nat.c (linux_nat_target::pass_signals)
5322         (linux_nat_target::create_inferior, linux_nat_target::attach):
5323         Adjust.
5324         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5325         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5326         * procfs.c (procfs_target::pass_signals): Adjust.
5327         * record-full.c (record_full_target::resume): Adjust.
5328         * remote.c (remote_target::pass_signals)
5329         (remote_target::program_signals): Adjust.
5330         * target-debug.h (target_debug_print_signals): Now takes a
5331         gdb::array_view as parameter.  Adjust.
5332         * target.h (target_ops) <pass_signals, program_signals>: Replace
5333         pointer and length parameters with gdb::array_view.
5334         (target_pass_signals, target_program_signals): Likewise.
5335         * target-delegates.c: Regenerate.
5336
5337 2019-01-24  Pedro Alves  <palves@redhat.com>
5338
5339         * common/forward-scope-exit.h
5340         (forward_scope_exit::forward_scope_exit): Pass arguments to
5341         m_bind_function directly, instead of creating a std::bind and
5342         copying that.
5343
5344 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5345
5346         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5347         for static members.
5348         (pass_in_v_vfp_candidate): Likewise.
5349
5350 2019-01-23  Tom Tromey  <tom@tromey.com>
5351             Pedro Alves  <palves@redhat.com>
5352
5353         * regcache.c (class regcache_invalidator): Remove.
5354         (regcache::raw_write): Use make_scope_exit.
5355
5356 2019-01-23  Tom Tromey  <tom@tromey.com>
5357
5358         * ui-out.h (class ui_out_emit_type): Update comment.
5359
5360 2019-01-23  Tom Tromey  <tom@tromey.com>
5361
5362         * infrun.c (fetch_inferior_event): Update comment.
5363
5364 2019-01-23  Tom Tromey  <tom@tromey.com>
5365             Pedro Alves  <palves@redhat.com>
5366
5367         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5368         parameter.
5369         (fetch_inferior_event): Use SCOPE_EXIT.
5370
5371
5372 2019-01-23  Tom Tromey  <tom@tromey.com>
5373             Pedro Alves  <palves@redhat.com>
5374
5375         * infrun.c (disable_thread_events): Delete.
5376         (stop_all_threads): Use SCOPE_EXIT.
5377
5378 2019-01-23  Tom Tromey  <tom@tromey.com>
5379             Pedro Alves  <palves@redhat.com>
5380
5381         * symfile.c: Include forward-scope-exit.h.
5382         (clear_symtab_users_cleanup): Replace forward declaration with
5383         a FORWARD_SCOPE_EXIT.
5384         (syms_from_objfile_1): Use the forward_scope_exit and
5385         gdb::optional instead of cleanup_function.
5386         (reread_symbols): Use the forward_scope_exit instead of
5387         cleanup_function.
5388         (clear_symtab_users_cleanup): Remove function.
5389
5390 2019-01-23  Tom Tromey  <tom@tromey.com>
5391             Pedro Alves  <palves@redhat.com>
5392
5393         * linux-nat.c: Include scope-exit.h.
5394         (cleanup_target_stop): Remove.
5395         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5396         SCOPE_EXIT.
5397
5398 2019-01-23  Tom Tromey  <tom@tromey.com>
5399             Pedro Alves  <palves@redhat.com>
5400
5401         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5402         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5403
5404 2019-01-23  Tom Tromey  <tom@tromey.com>
5405             Andrew Burgess  <andrew.burgess@embecosm.com>
5406             Pedro Alves  <palves@redhat.com>
5407
5408         * infrun.c (fetch_inferior_event): Use scope_exit.
5409         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5410         * top.c (execute_command): Use scope_exit.
5411         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5412         * utils.c (do_bpstat_clear_actions_cleanup)
5413         (make_bpstat_clear_actions_cleanup): Remove.
5414
5415 2019-01-23  Tom Tromey  <tom@tromey.com>
5416             Pedro Alves  <palves@redhat.com>
5417
5418         * infrun.c: Include "common/scope-exit.h"
5419         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5420         (wait_for_inferior): Use SCOPE_EXIT.
5421         (fetch_inferior_event): Use scope_exit.
5422
5423 2019-01-23  Tom Tromey  <tom@tromey.com>
5424             Pedro Alves  <palves@redhat.com>
5425
5426         * breakpoint.c (create_breakpoint): Remove cleanup.
5427
5428 2019-01-23  Tom Tromey  <tom@tromey.com>
5429             Andrew Burgess  <andrew.burgess@embecosm.com>
5430             Pedro Alves  <palves@redhat.com>
5431
5432 2019-01-23  Pedro Alves  <palves@redhat.com>
5433
5434         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5435
5436 2019-01-23  Pedro Alves  <palves@redhat.com>
5437             Andrew Burgess  <andrew.burgess@embecosm.com>
5438
5439         * gdbthread.h: Include "common/forward-scope-exit.h".
5440         (scoped_finish_thread_state): Redefine custom class in terms of
5441         forward_scope_exit.
5442
5443 2019-01-23  Pedro Alves  <palves@redhat.com>
5444             Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * common/forward-scope-exit.h: New file.
5447
5448 2019-01-23  Pedro Alves  <palves@redhat.com>
5449             Andrew Burgess  <andrew.burgess@embecosm.com>
5450             Tom Tromey  <tom@tromey.com>
5451
5452         * common/scope-exit.h: New file.
5453
5454 2019-01-23  Pedro Alves  <palves@redhat.com>
5455
5456         * common/preprocessor.h (ESC): Rename to ...
5457         (ESC_PARENS): ... this.
5458         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5459         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5460
5461 2019-01-23  Tom Tromey  <tom@tromey.com>
5462
5463         * language.h (class scoped_switch_to_sym_language_if_auto):
5464         Initialize m_lang in both cases.
5465
5466 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5467
5468         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5469         with XCNEW.
5470
5471 2019-01-22  Tom Tromey  <tom@tromey.com>
5472
5473         * corelow.c: Do not include sys/file.h.
5474
5475 2019-01-22  Tom Tromey  <tom@tromey.com>
5476
5477         * tui/tui-wingeneral.h: Include gdb_curses.h.
5478
5479 2019-01-22  Tom Tromey  <tom@tromey.com>
5480
5481         * source-cache.h (class source_cache) <get_source_lines,
5482         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5483
5484 2019-01-22  Tom Tromey  <tom@tromey.com>
5485
5486         * remote-fileio.h (struct remote_target): Declare.
5487
5488 2019-01-22  Tom Tromey  <tom@tromey.com>
5489
5490         * python/py-arch.c: Do not include py-ref.h.
5491         * python/py-bpevent.c: Do not include py-ref.h.
5492         * python/py-cmd.c: Do not include py-ref.h.
5493         * python/py-continueevent.c: Do not include py-ref.h.
5494         * python/py-event.h: Do not include py-ref.h.
5495         * python/py-evtregistry.c: Do not include py-ref.h.
5496         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5497         * python/py-frame.c: Do not include py-ref.h.
5498         * python/py-framefilter.c: Do not include py-ref.h.
5499         * python/py-function.c: Do not include py-ref.h.
5500         * python/py-infevents.c: Do not include py-ref.h.
5501         * python/py-linetable.c: Do not include py-ref.h.
5502         * python/py-objfile.c: Do not include py-ref.h.
5503         * python/py-param.c: Do not include py-ref.h.
5504         * python/py-prettyprint.c: Do not include py-ref.h.
5505         * python/py-progspace.c: Do not include py-ref.h.
5506         * python/py-symbol.c: Do not include py-ref.h.
5507         * python/py-symtab.c: Do not include py-ref.h.
5508         * python/py-type.c: Do not include py-ref.h.
5509         * python/py-unwind.c: Do not include py-ref.h.
5510         * python/py-utils.c: Do not include py-ref.h.
5511         * python/py-value.c: Do not include py-ref.h.
5512         * python/py-varobj.c: Do not include py-ref.h.
5513         * python/py-xmethods.c: Do not include py-ref.h.
5514         * python/python.c: Do not include py-ref.h.
5515         * varobj.c: Do not include py-ref.h.
5516
5517 2019-01-22  Tom Tromey  <tom@tromey.com>
5518
5519         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5520         keyword for bcache.
5521
5522 2019-01-22  Tom Tromey  <tom@tromey.com>
5523
5524         * compile/compile-cplus-types.c: Remove a comment by #include.
5525
5526 2019-01-22  Tom Tromey  <tom@tromey.com>
5527
5528         * compile/gcc-c-plugin.h: Include compile-internal.h.
5529
5530 2019-01-22  Tom Tromey  <tom@tromey.com>
5531
5532         * stabsread.c (EXTERN): Do not define.
5533         (symnum, next_symbol_text_func, processing_gcc_compilation)
5534         (within_function, global_sym_chain, global_stabs)
5535         (previous_stab_code, this_object_header_files)
5536         (n_this_object_header_files)
5537         (n_allocated_this_object_header_files): Define.
5538         * stabsread.h (EXTERN): Never define.  Use "extern".
5539
5540 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5541
5542         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5543         history_value.
5544
5545 2019-01-21  Tom Tromey  <tom@tromey.com>
5546
5547         * ui-out.c: Fix includes.
5548         * tui/tui-source.c: Fix includes.
5549         * target.c: Fix includes.
5550         * remote.c: Fix includes.
5551         * regcache.c: Fix includes.
5552         * python/py-block.c: Fix includes.
5553         * printcmd.c: Fix includes.
5554         * or1k-tdep.c: Fix includes.
5555         * mi/mi-main.c: Fix includes.
5556         * m32r-tdep.c: Fix includes.
5557         * csky-tdep.c: Fix includes.
5558         * compile/compile-cplus-types.c: Fix includes.
5559         * cli/cli-interp.c: Fix includes.
5560
5561 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5562
5563         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5564         for padding.
5565
5566 2019-01-16  Tom Tromey  <tom@tromey.com>
5567
5568         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5569         earlier.
5570         (struct objfile) <msymbols_range>: Move from top level.
5571         <msymbols>: New method.
5572         (class objfile_msymbols): Remove.
5573         * symtab.c (default_collect_symbol_completion_matches_break_on):
5574         Update.
5575         * symmisc.c (dump_msymbols): Update.
5576         * stabsread.c (scan_file_globals): Update.
5577         * objc-lang.c (info_selectors_command, info_classes_command)
5578         (find_methods): Update.
5579         * minsyms.c (find_solib_trampoline_target): Update.
5580         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5581         * coffread.c (coff_symfile_read): Update.
5582         * ada-lang.c (ada_lookup_simple_minsym)
5583         (ada_collect_symbol_completion_matches): Update.
5584
5585 2019-01-16  Tom Tromey  <tom@tromey.com>
5586
5587         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5588         type.  Remove no-argument constructor.
5589         <iterator::operator++>: Simplify.
5590         <begin>: Update.
5591         <end>: Use minimal_symbol_count.
5592
5593 2019-01-16  Tom Tromey  <tom@tromey.com>
5594
5595         * objfiles.h (struct objfile) <psymtabs>: New method.
5596         (class objfile_psymtabs): Remove.
5597         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5598         typedef.
5599         <range>: New method.
5600         (require_partial_symbols): Change return type.
5601         * psymtab.c (require_partial_symbols)
5602         (psym_expand_symtabs_matching): Update.
5603         * mdebugread.c (parse_partial_symbols): Update.
5604         * dbxread.c (dbx_end_psymtab): Update.
5605
5606 2019-01-15  Tom Tromey  <tom@tromey.com>
5607
5608         * symtab.c (lookup_objfile_from_block)
5609         (lookup_symbol_in_objfile_symtabs)
5610         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5611         (find_line_symtab, info_sources_command)
5612         (default_collect_symbol_completion_matches_break_on)
5613         (make_source_files_completion_list): Update.
5614         * symmisc.c (print_objfile_statistics, dump_objfile)
5615         (maintenance_print_symbols, maintenance_info_symtabs)
5616         (maintenance_check_symtabs, maintenance_info_line_tables):
5617         Update.
5618         * source.c (select_source_symtab)
5619         (forget_cached_source_info_for_objfile): Update.
5620         * objfiles.h (class objfile_compunits): Remove.
5621         (struct objfile) <compunits_range>: New typedef.
5622         (compunits): New method.
5623         * objfiles.c (objfile_relocate1): Update.
5624         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5625         * maint.c (count_symtabs_and_blocks): Update.
5626         * linespec.c (iterate_over_all_matching_symtabs): Update.
5627         * cp-support.c (add_symbol_overload_list_qualified): Update.
5628         * coffread.c (coff_symtab_read): Update.
5629         * ada-lang.c (add_nonlocal_symbols)
5630         (ada_collect_symbol_completion_matches)
5631         (ada_add_global_exceptions): Update.
5632
5633 2019-01-15  Tom Tromey  <tom@tromey.com>
5634
5635         * progspace.h (program_space) <objfiles_safe_range>: New
5636         typedef.
5637         <objfiles_safe>: New method.
5638         * objfiles.h (class all_objfiles_safe): Remove.
5639         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5640         * jit.c (jit_inferior_exit_hook): Update.
5641
5642 2019-01-17  Tom Tromey  <tom@tromey.com>
5643
5644         * progspace.h (program_space) <objfiles_range>: New typedef.
5645         <objfiles>: New method.
5646         <objfiles_head>: Rename from objfiles.
5647         (object_files): Update.
5648         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5649         * guile/scm-pretty-print.c
5650         (ppscm_find_pretty_printer_from_objfiles): Update.
5651         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5652         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5653         Update.
5654         * python/py-progspace.c (pspy_get_objfiles): Update.
5655         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5656         Update.
5657         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5658         (objfpy_lookup_objfile_by_build_id): Update.
5659         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5660         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5661         Update.
5662         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5663         (expand_symtab_containing_pc, lookup_objfile_from_block)
5664         (lookup_static_symbol, basic_lookup_transparent_type)
5665         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5666         (find_line_symtab, info_sources_command)
5667         (default_collect_symbol_completion_matches_break_on)
5668         (make_source_files_completion_list, find_main_name): Update.
5669         * symmisc.c (print_symbol_bcache_statistics)
5670         (print_objfile_statistics, maintenance_print_symbols)
5671         (maintenance_print_msymbols, maintenance_print_objfiles)
5672         (maintenance_info_symtabs, maintenance_check_symtabs)
5673         (maintenance_expand_symtabs, maintenance_info_line_tables):
5674         Update.
5675         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5676         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5677         (map_overlay_command, unmap_overlay_command)
5678         (simple_overlay_update, expand_symtabs_matching)
5679         (map_symbol_filenames): Update.
5680         * symfile-debug.c (set_debug_symfile): Update.
5681         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5682         Update.
5683         * source.c (select_source_symtab, forget_cached_source_info):
5684         Update.
5685         * solib.c (solib_read_symbols): Update.
5686         * solib-spu.c (append_ocl_sos): Update.
5687         * psymtab.c (maintenance_print_psymbols)
5688         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5689         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5690         * printcmd.c (info_symbol_command): Update.
5691         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5692         Update.
5693         * objfiles.h (class all_objfiles): Remove.
5694         * objfiles.c (have_partial_symbols, have_full_symbols)
5695         (have_minimal_symbols, qsort_cmp, update_section_map)
5696         (shared_objfile_contains_address_p)
5697         (default_iterate_over_objfiles_in_search_order): Update.
5698         * objc-lang.c (info_selectors_command, info_classes_command)
5699         (find_methods): Update.
5700         * minsyms.c (find_solib_trampoline_target): Update.
5701         * maint.c (maintenance_info_sections)
5702         (maintenance_translate_address, count_symtabs_and_blocks):
5703         Update.
5704         * main.c (captured_main_1): Update.
5705         * linux-thread-db.c (try_thread_db_load_from_pdir)
5706         (has_libpthread): Update.
5707         * linespec.c (iterate_over_all_matching_symtabs)
5708         (search_minsyms_for_name): Update.
5709         * jit.c (jit_find_objf_with_entry_addr): Update.
5710         * hppa-tdep.c (find_unwind_entry)
5711         (hppa_lookup_stub_minimal_symbol): Update.
5712         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5713         Update.
5714         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5715         (elf_gnu_ifunc_resolve_by_got): Update.
5716         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5717         * dwarf-index-write.c (save_gdb_index_command): Update.
5718         * cp-support.c (add_symbol_overload_list_qualified): Update.
5719         * breakpoint.c (create_overlay_event_breakpoint)
5720         (create_longjmp_master_breakpoint)
5721         (create_std_terminate_master_breakpoint)
5722         (create_exception_master_breakpoint): Update.
5723         * blockframe.c (find_pc_partial_function): Update.
5724         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5725         (ada_collect_symbol_completion_matches)
5726         (ada_add_global_exceptions): Update.
5727
5728 2019-01-17  Tom Tromey  <tom@tromey.com>
5729
5730         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5731         declare VEC.
5732         (solib_target_parse_libraries): Change return type.
5733         (library_list_start_segment, library_list_start_section)
5734         (library_list_end_library, library_list_start_library); Update.
5735         (solib_target_free_library_list): Remove.
5736         (solib_target_parse_libraries): Remove cleanup.  Change return
5737         type.
5738         (solib_target_current_sos): Update.
5739
5740 2019-01-17  Tom Tromey  <tromey@bapiya>
5741
5742         * valprint.c: Replace "the the" with "the".
5743         * symtab.c: Replace "the the" with "the".
5744         * solib.c: Replace "the the" with "the".
5745         * solib-dsbt.c: Replace "the the" with "the".
5746         * linespec.c: Replace "the the" with "the".
5747         * dwarf2loc.h: Replace "the the" with "the".
5748         * amd64-windows-tdep.c: Replace "the the" with "the".
5749         * aarch64-tdep.c: Replace "the the" with "the".
5750
5751 2019-01-16  Keith Seitz  <keiths@redhat.com>
5752
5753         PR gdb/23773
5754         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5755         <builder>: Rename to ..
5756         <m_builder>: ... this and make private.
5757         (dwarf2_cu::get_builder): New method.  Change all users of
5758         `builder' to use this method.
5759         (dwarf2_start_symtab): Move to ...
5760         (dwarf2_cu::start_symtab): ... here.  Update all callers
5761         (setup_type_unit_groups): Move to ...
5762         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5763         callers.
5764         (dwarf2_cu::reset_builder): New method.
5765         (process_full_compunit, process_full_type_unit): Use
5766         dwarf2_cu::reset_builder.
5767         (follow_die_offset): Record the ancestor CU if it is different
5768         from the followed DIE's CU.
5769         (follow_die_sig_1): Likewise.
5770
5771 2019-01-15  Tom Tromey  <tom@tromey.com>
5772
5773         * remote.c (class remote_state) <buf>: Now a char_vector.
5774         <buf_size>: Remove.
5775         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5776         parameter.
5777         (remote_target::getpkt_or_notif_sane_1)
5778         (remote_target::getpkt_sane)
5779         (remote_target::getpkt_or_notif_sane): Likewise.
5780         (class remote_target) <putpkt>: New overload.
5781         (remote_target::read_frame): Change type of "buf_p".  Remove
5782         sizeof_p parameter.
5783         (packet_ok): New overload.
5784         (packet_check_result): New overload.
5785         Update all uses.
5786
5787 2019-01-14  Tom Tromey  <tom@tromey.com>
5788
5789         * remote-notif.c (handle_notification, remote_notif_ack)
5790         (remote_notif_parse): Make "buf" const.
5791         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5792         const.
5793         (remote_notif_parse, remote_notif_ack, handle_notification):
5794         Likewise.
5795         * remote.c (remote_notif_stop_parse): Make "buf" const.
5796         (remote_target::remote_parse_stop_reply): Make "buf" const.
5797         (remote_notif_stop_ack): Make "buf" const.
5798
5799 2019-01-14  Tom Tromey  <tom@tromey.com>
5800
5801         * remote.c (remote_console_output): Make parameter const.
5802
5803 2019-01-14  Tom Tromey  <tom@tromey.com>
5804
5805         * target-debug.h (target_debug_print_signals): Constify.
5806         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5807         * procfs.c (procfs_target::pass_signals): Update.
5808         * linux-nat.c (linux_nat_target::pass_signals): Update.
5809         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5810         * target-delegates.c: Rebuild.
5811         * remote.c (remote_target::program_signals): Update.
5812         (remote_target::pass_signals): Update.
5813         * target.c (target_pass_signals): Constify argument.
5814         (target_program_signals): Likewise.
5815         * target.h (struct target_ops) <pass_signals, program_signals>:
5816         Constify argument.
5817         (target_pass_signals, target_program_signals): Constify argument.
5818
5819 2019-01-14  Tom Tromey  <tom@tromey.com>
5820
5821         PR tui/28819:
5822         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5823
5824 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5825
5826         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5827         field.
5828         * rs6000-tdep.c: Include reggroups.h.
5829         (IS_V_ALIAS_PSEUDOREG): Define.
5830         (rs6000_register_name): Return names for the "vX" aliases.
5831         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5832         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5833         aliases.  Call default_register_reggroup_p for all other
5834         pseudo-registers.
5835         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5836         New functions.
5837         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5838         Handle "vX" aliases.
5839         (v_alias_pseudo_register_collect): New function.
5840         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5841         (rs6000_gdbarch_init): Initialize "vX" aliases as
5842         pseudo-registers.  Restore registration of
5843         rs6000_pseudo_register_reggroup_p with
5844         set_tdesc_pseudo_register_reggroup_p.
5845
5846 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5847
5848         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5849         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5850         set_gdbarch_num_pseudo_regs.
5851
5852 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5853
5854         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5855         Remove arg prefixname, add do_set and do_show.
5856         Add member functions set_list and show_list.
5857         * cli/cli-style.c (class cli_style_option): Update accordingly.
5858         (style_set_list): Move to file scope.
5859         (style_show_list): Likewise.
5860         (set_style): Call help_list.
5861         (show_style): Call cmd_show_list.
5862         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5863         Update to use the new macro.
5864
5865 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5866
5867         * ada-lang.c (_initialize_ada_language): Expand the help text
5868         for the "catch exception" command.
5869
5870 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5871
5872         * symtab.c (matching_obj_sections): Initialize obj,
5873         declare it closer to its usage.
5874
5875 2019-01-10  Tom Tromey  <tom@tromey.com>
5876
5877         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5878         (basic_inf_threads_range): Remove.
5879         (inf_threads_range, inf_non_exited_threads_range)
5880         (safe_inf_threads_range): Use next_adapter.
5881
5882 2019-01-10  Keith Seitz  <keiths@redhat.com>
5883
5884         PR gdb/23712
5885         PR symtab/23010
5886         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5887         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5888
5889 2019-01-10  Keith Seitz  <keiths@redhat.com>
5890
5891         PR gdb/23712
5892         PR symtab/23010
5893         * dictionary.c (pending_to_vector): Remove.
5894         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5895         Remove _1 suffix, replacing functions of the same name.  Update
5896         all callers.
5897         (dict_create_hashed, dict_create_hashed_expandable)
5898         (dict_create_linear, dict_create_linear_expandable, dict_free)
5899         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5900         Make functions static.
5901
5902 2019-01-10  Keith Seitz  <keiths@redhat.com>
5903
5904         PR gdb/23712
5905         PR symtab/23010
5906         * dictionary.h (struct dictionary): Replace declaration with
5907         multidictionary.
5908         (dict_create_hashed, dict_create_hashed_expandable)
5909         (dict_create_linear, dict_create_linear_expandable)
5910         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5911         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5912         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5913         taking multidictionary argument.
5914         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5915         * block.h (struct block) <dict>: Change to multidictionary
5916         and rename `multidict'.
5917         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5918         symmisc.c: Update all dictionary references to multidictionary.
5919
5920 2019-01-10  Keith Seitz  <keiths@redhat.com>
5921
5922         PR gdb/23712
5923         PR symtab/23010
5924         * dictionary.c: Include unordered_map.
5925         (pending_to_vector): New function.
5926         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5927         Rewrite the non-"_1" functions to take vector instead
5928         of linked list.
5929         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5930         "new" _1 versions of the same name.
5931         (multidictionary): Define.
5932         (std::hash<enum language): New definition.
5933         (collate_pending_symbols_by_language, mdict_create_hashed)
5934         (mdict_create_hashed_expandable, mdict_create_linear)
5935         (mdict_create_linear_expandable, mdict_free)
5936         (find_language_dictionary, create_new_language_dictionary)
5937         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5938         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5939         (mdict_size, mdict_empty): New functions.
5940         * dictionary.h (mdict_iterator): Define.
5941
5942 2019-01-10  Pedro Alves  <palves@redhat.com>
5943
5944         * breakpoint.c (read_uploaded_action)
5945         (create_tracepoint_from_upload): Adjust to use
5946         gdb::unique_xmalloc_ptr.
5947         * ctf.c (ctf_write_uploaded_tp):
5948         (SET_ARRAY_FIELD): Use emplace_back.
5949         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5950         * tracefile-tfile.c (tfile_write_uploaded_tp):
5951         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5952         gdb::unique_xmalloc_ptr.
5953         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5954         at_string, cond_string, cmd_strings>: Replace char pointers
5955         with gdb::unique_xmalloc_ptr.
5956
5957 2019-01-10  Pedro Alves  <palves@redhat.com>
5958
5959         * solib-target.c (library_list_start_library): Don't xstrdup name.
5960
5961 2019-01-10  Pedro Alves  <palves@redhat.com>
5962
5963         * mdebugread.c (parse_partial_symbols): Use
5964         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5965
5966 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5967
5968         * linux-fork.c (scoped_switch_fork_info)
5969         <~scoped_switch_fork_info>: Fix incorrect variable name.
5970
5971 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5972
5973         * linux-fork.c (scoped_switch_fork_info)
5974         <scoped_switch_fork_info>: Make explicit.
5975         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5976
5977 2019-01-10  Tom Tromey  <tom@tromey.com>
5978
5979         * objfiles.h (objfile::reset_psymtabs): Update.
5980         * objfiles.c (objfile::objfile): Update.
5981         * psymtab.h (psymtab_storage::obstack): Update.
5982         (psymtab_storage::m_obstack): Use gdb::optional.
5983         (class psymtab_storage): Update comment.  Remove objfile
5984         parameter.
5985         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5986
5987 2019-01-10  Tom Tromey  <tom@tromey.com>
5988
5989         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5990         <free_psymtabs>: Now private.
5991         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5992         (allocate_psymtab): Use new method.
5993
5994 2019-01-10  Tom Tromey  <tom@tromey.com>
5995
5996         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5997         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5998         * mdebugread.c (parse_partial_symbols): Use
5999         allocate_dependencies.
6000         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6001         allocate_dependencies.
6002         (process_psymtab_comp_unit_reader)
6003         (build_type_psymtab_dependencies): Likewise.
6004         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6005
6006 2019-01-10  Tom Tromey  <tom@tromey.com>
6007
6008         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6009         PSYMBOL_SET_LANGUAGE.
6010         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6011
6012 2019-01-10  Tom Tromey  <tom@tromey.com>
6013
6014         * psymtab.h (psymtab_storage::obstack): New method.
6015         <m_obstack>: Rename from obstack; now private.
6016         * psymtab.c (psymtab_storage): Update.
6017         * dwarf2read.c (create_addrmap_from_index)
6018         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6019         Update.
6020
6021 2019-01-10  Tom Tromey  <tom@tromey.com>
6022
6023         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6024         * objfiles.h (objfile::reset_psymtabs): New method.
6025
6026 2019-01-10  Tom Tromey  <tom@tromey.com>
6027
6028         * symmisc.c (print_symbol_bcache_statistics): Update.
6029         (print_objfile_statistics): Update.
6030         * symfile.c (reread_symbols): Update.
6031         * psymtab.h (class psymtab_storage): New.
6032         * psymtab.c (psymtab_storage): New constructor.
6033         (~psymtab_storage): New destructor.
6034         (require_partial_symbols): Update.
6035         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6036         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6037         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6038         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6039         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6040         (start_psymtab_common, end_psymtab_common)
6041         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6042         (allocate_psymtab): Update.
6043         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6044         Update.
6045         (dump_psymtab_addrmap, maintenance_print_psymbols)
6046         (maintenance_check_psymtabs): Update.
6047         (class objfile_psymtabs): Move to objfiles.h.
6048         * psympriv.h (discard_psymtab): Now inline.
6049         (psymtab_discarder::psymtab_discarder): Update.
6050         (psymtab_discarder::~psymtab_discarder): Update.
6051         (ALL_OBJFILE_PSYMTABS): Rewrite.
6052         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6053         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6054         Remove fields.
6055         <partial_symtabs>: New field.
6056         (class objfile_psymtabs): Move from psymtab.h.  Update.
6057         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6058         psymbol_cache.
6059         (objfile::~objfile): Don't destroy psymbol_cache.
6060         * mdebugread.c (parse_partial_symbols): Update.
6061         * dwarf2read.c (create_addrmap_from_index)
6062         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6063         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6064         (add_partial_subprogram, dwarf2_ranges_read): Update.
6065         * dwarf-index-write.c (write_address_map)
6066         (write_one_signatured_type, recursively_write_psymbols)
6067         (class debug_names, class debug_names, write_psymtabs_to_index):
6068         Update.
6069
6070 2019-01-10  Tom Tromey  <tom@tromey.com>
6071
6072         * symtab.h (SYMBOL_SET_NAMES): Update.
6073         (symbol_set_names): Update.
6074         (MSYMBOL_SET_NAMES): Update.
6075         * symtab.c (symbol_set_names): Change argument to be an
6076         objfile_per_bfd_storage.
6077         * psymtab.c (add_psymbol_to_bcache): Update.
6078         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6079
6080 2019-01-10  Tom Tromey  <tom@tromey.com>
6081
6082         * symtab.c (create_demangled_names_hash): Change argument to be an
6083         objfile_per_bfd_storage.
6084         (symbol_set_names): Update.
6085
6086 2019-01-10  Tom Tromey  <tom@tromey.com>
6087
6088         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6089         init_psymbol_list.
6090         * psymtab.c (init_psymbol_list): Do nothing if already called.
6091         * psympriv.h (init_psymbol_list): Add comment.
6092         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6093         init_psymbol_list.
6094         * dbxread.c (dbx_symfile_read): Unconditionally call
6095         init_psymbol_list.
6096
6097 2019-01-10  Tom Tromey  <tom@tromey.com>
6098
6099         * xcoffread.c (scan_xcoff_symtab): Update.
6100         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6101         "where".
6102         * mdebugread.c (parse_partial_symbols)
6103         (handle_psymbol_enumerators): Update.
6104         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6105         * dbxread.c (read_dbx_symtab): Update.
6106         * psympriv.h (psymbol_placement): New enum.
6107         (add_psymbol_to_list): Update.
6108
6109 2019-01-10  Tom Tromey  <tom@tromey.com>
6110
6111         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6112         static_psymbols parameters.
6113         (scan_xcoff_symtab): Update.
6114         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6115         static_psymbols parameters.
6116         * psympriv.h (start_psymtab_common): Update.
6117         * mdebugread.c (parse_partial_symbols): Update.
6118         * dwarf2read.c (create_partial_symtab): Update.
6119         * dbxread.c (read_dbx_symtab): Update.
6120         (start_psymtab): Remove global_psymbols and static_psymbols
6121         parameters.
6122
6123 2019-01-10  Tom Tromey  <tom@tromey.com>
6124
6125         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6126         * psymtab.c (allocate_psymtab): Add comment.
6127         * psympriv.h (allocate_psymtab): Add comment.
6128         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6129         initializations.
6130         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6131
6132 2019-01-10  Tom Tromey  <tom@tromey.com>
6133
6134         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6135         Don't declare.
6136         * mipsread.c: Include mdebugread.h.
6137         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6138         Declare.
6139         * elfread.c: Include mdebugread.h.
6140
6141 2019-01-09  Tom Tromey  <tom@tromey.com>
6142
6143         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6144         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6145         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6146         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6147         (psym_lookup_symbol, psym_find_last_source_symtab)
6148         (psym_forget_cached_source_info, psym_print_stats)
6149         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6150         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6151         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6152         (psym_find_compunit_symtab_by_address)
6153         (maintenance_print_psymbols, maintenance_info_psymtabs)
6154         (maintenance_check_psymtabs): Use ranged for.
6155         * psymtab.h (class objfile_psymtabs): New.
6156         (require_partial_symbols): Return objfile_psymtabs.
6157         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6158
6159 2019-01-09  Tom Tromey  <tom@tromey.com>
6160
6161         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6162         (find_pc_mapped_section, list_overlays_command)
6163         (map_overlay_command, unmap_overlay_command)
6164         (simple_overlay_update): Use all_objfiles.
6165         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6166         * printcmd.c (info_symbol_command): Use all_objfiles.
6167         * objfiles.h (ALL_OBJSECTIONS): Remove.
6168         * maint.c (maintenance_translate_address): Use all_objfiles.
6169         * gcore.c (gcore_create_callback): Use all_objfiles.
6170         (objfile_find_memory_regions): Likewise.
6171
6172 2019-01-09  Tom Tromey  <tom@tromey.com>
6173
6174         * symtab.c (find_line_symtab, info_sources_command)
6175         (make_source_files_completion_list): Use objfile_compunits.
6176         * source.c (select_source_symtab): Use objfile_compunits.
6177         * objfiles.h (struct objfile): Update comment.
6178         (ALL_OBJFILES): Remove.
6179         (ALL_FILETABS): Remove.
6180         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6181         objfile_compunits.
6182
6183 2019-01-09  Tom Tromey  <tom@tromey.com>
6184
6185         * symmisc.c (print_objfile_statistics, dump_objfile)
6186         (maintenance_print_symbols): Use compunit_filetabs.
6187         * source.c (forget_cached_source_info_for_objfile): Use
6188         compunit_filetabs.
6189         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6190         (ALL_FILETABS): Use compunit_filetabs.
6191         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6192         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6193
6194 2019-01-09  Tom Tromey  <tom@tromey.com>
6195
6196         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6197         (compunit_filetabs): New.
6198         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6199         compunit_filetabs.
6200         (info_sources_command, make_source_files_completion_list): Remove
6201         declaration.
6202         * symmisc.c (print_objfile_statistics, dump_objfile)
6203         (maintenance_print_symbols): Remove declaration.
6204         (maintenance_info_symtabs): Use compunit_filetabs.
6205         (maintenance_info_line_tables): Likewise.
6206         * source.c (select_source_symtab): Change local variable name.
6207         (forget_cached_source_info_for_objfile): Remove declaration.
6208         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6209         * objfiles.c (objfile_relocate1): Remove declaration.
6210         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6211         declaration.
6212         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6213         * coffread.c (coff_symtab_read): Remove declaration.
6214         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6215         compunit_filetabs.
6216
6217 2019-01-09  Tom Tromey  <tom@tromey.com>
6218
6219         * symtab.c (lookup_objfile_from_block)
6220         (find_pc_sect_compunit_symtab, search_symbols)
6221         (default_collect_symbol_completion_matches_break_on): Use
6222         objfile_compunits.
6223         * objfiles.h (ALL_COMPUNITS): Remove.
6224         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6225         * cp-support.c (add_symbol_overload_list_qualified): Use
6226         objfile_compunits.
6227         * ada-lang.c (ada_collect_symbol_completion_matches)
6228         (ada_add_global_exceptions): Use objfile_compunits.
6229
6230 2019-01-09  Tom Tromey  <tom@tromey.com>
6231
6232         * source.c (select_source_symtab)
6233         (forget_cached_source_info_for_objfile): Remove declaration.
6234         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6235         declaration.
6236         * maint.c (count_symtabs_and_blocks): Remove declaration.
6237         * cp-support.c (add_symbol_overload_list_qualified): Remove
6238         declaration.
6239         * coffread.c (coff_symtab_read): Remove declaration.
6240         * symtab.c (lookup_symbol_in_objfile_symtabs)
6241         (basic_lookup_transparent_type_1): Use objfile_compunits.
6242         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6243         (info_sources_command, search_symbols)
6244         (default_collect_symbol_completion_matches_break_on)
6245         (make_source_files_completion_list): Remove declaration.
6246         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6247         (ada_collect_symbol_completion_matches)
6248         (ada_add_global_exceptions): Remove declaration.
6249         * linespec.c (iterate_over_all_matching_symtabs): Use
6250         objfile_compunits.
6251         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6252         (class objfile_compunits): New.
6253         (ALL_COMPUNITS): Use objfile_compunits.
6254         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6255         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6256         objfile_compunits.
6257         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6258
6259 2019-01-09  Tom Tromey  <tom@tromey.com>
6260
6261         * symtab.c (search_symbols)
6262         (default_collect_symbol_completion_matches_break_on): Use
6263         objfile_msymbols.
6264         * ada-lang.c (ada_lookup_simple_minsym)
6265         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6266         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6267         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6268         objfile_msymbols.
6269         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6270         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6271         * objc-lang.c (find_methods): Use objfile_msymbols.
6272         (info_selectors_command, info_classes_command): Likewise.
6273         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6274         * objfiles.h (class objfile_msymbols): New.
6275         (ALL_OBJFILE_MSYMBOLS): Remove.
6276         (ALL_MSYMBOLS): Remove.
6277
6278 2019-01-09  Tom Tromey  <tom@tromey.com>
6279
6280         * common/next-iterator.h (next_adapter): Add Iterator template
6281         parameter.
6282         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6283         (class all_objfiles_safe): New.
6284         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6285         * objfiles.c (put_objfile_before): Update comment.
6286         (add_separate_debug_objfile): Likewise.
6287         (free_all_objfiles): Use all_objfiles_safe.
6288         (objfile_purge_solibs): Likewise.
6289
6290 2019-01-09  Tom Tromey  <tom@tromey.com>
6291
6292         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6293         (expand_symtab_containing_pc, lookup_static_symbol)
6294         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6295         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6296         all_objfiles.
6297         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6298         * breakpoint.c (create_overlay_event_breakpoint)
6299         (create_longjmp_master_breakpoint)
6300         (create_std_terminate_master_breakpoint)
6301         (create_exception_master_breakpoint): Use all_objfiles.
6302         * linux-thread-db.c (try_thread_db_load_from_pdir)
6303         (has_libpthread): Use all_objfiles.
6304         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6305         * linespec.c (iterate_over_all_matching_symtabs)
6306         (search_minsyms_for_name): Use all_objfiles.
6307         * maint.c (maintenance_info_sections): Use all_objfiles.
6308         * main.c (captured_main_1): Use all_objfiles.
6309         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6310         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6311         * guile/scm-pretty-print.c
6312         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6313         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6314         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6315         (maintenance_print_msymbols): Use all_objfiles.
6316         * source.c (select_source_symtab): Use all_objfiles.
6317         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6318         * symfile.c (remove_symbol_file_command)
6319         (expand_symtabs_matching, map_symbol_filenames): Use
6320         all_objfiles.
6321         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6322         all_objfiles.
6323         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6324         * objc-lang.c (find_methods): Use all_objfiles.
6325         * objfiles.c (have_partial_symbols, have_full_symbols)
6326         (have_minimal_symbols, qsort_cmp)
6327         (default_iterate_over_objfiles_in_search_order): Use
6328         all_objfiles.
6329         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6330         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6331         (maintenance_check_psymtabs): Use all_objfiles.
6332         (ALL_PSYMTABS): Remove.
6333         * compile/compile-object-run.c (do_module_cleanup): Use
6334         all_objfiles.
6335         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6336         * cp-support.c (add_symbol_overload_list_qualified): Use
6337         all_objfiles.
6338         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6339         Use all_objfiles.
6340         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6341         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6342         all_objfiles.
6343         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6344         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6345         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6346         Uses all_objfiles.
6347         * solib.c (solib_read_symbols): Use all_objfiles
6348
6349 2019-01-09  Tom Tromey  <tom@tromey.com>
6350
6351         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6352         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6353         all_objfiles.
6354         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6355         * symmisc.c (print_symbol_bcache_statistics)
6356         (print_objfile_statistics, maintenance_print_objfiles)
6357         (maintenance_info_symtabs, maintenance_check_symtabs)
6358         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6359         all_objfiles.
6360         * source.c (forget_cached_source_info): Use all_objfiles.
6361         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6362         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6363         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6364         * objfiles.c (update_section_map): Use all_objfiles.
6365         (shared_objfile_contains_address_p): Likewise.
6366         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6367         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6368
6369 2019-01-09  Tom Tromey  <tom@tromey.com>
6370
6371         * common/next-iterator.h: New file.
6372         * objfiles.h (class all_objfiles): New.
6373         (struct objfile_iterator): New.
6374
6375 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6376
6377         * NEWS: Move the description of the changed "frame", "select-frame",
6378          and "info frame" commands to the Changed commands section.
6379
6380 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6381
6382         * gdbtypes.c (check_stub_method_group): Remove handling of old
6383         mangling schemes.
6384         * linespec.c (find_methods): Likewise.
6385         * stabsread.c (read_member_functions): Likewise.
6386         * valops.c (search_struct_method): Likewise.
6387         (value_struct_elt_for_reference): Likewise.
6388         * NEWS: Mention this change.
6389
6390 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6391
6392         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6393         print_source_lines.
6394         * source.c (print_source_lines_base): Update line number check.
6395         (print_source_lines): New function.
6396         (source_lines_range::source_lines_range): New function.
6397         * source.h (class source_lines_range): New class.
6398         (print_source_lines): New declaration.
6399
6400 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6401
6402         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6403
6404 2019-01-08  Tom Tromey  <tom@tromey.com>
6405             Simon Marchi  <simon.marchi@ericsson.com>
6406
6407         PR gdb/24060
6408         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6409         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6410         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6411         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6412         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6413         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6414
6415 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * source.c (select_source_symtab): Move header comment to
6418         declaration in source.h.
6419         (forget_cached_source_info_for_objfile): Likewise.
6420         (forget_cached_source_info): Likewise.
6421         (identify_source_line): Likewise.
6422         * source.h (identify_source_line): Move declaration from symtab.h
6423         and add comment from source.c
6424         (print_source_lines): Likewise.
6425         (forget_cached_source_info_for_objfile): Likewise.
6426         (forget_cached_source_info): Likewise.
6427         (select_source_symtab): Likewise.
6428         (enum print_source_lines_flag): Move definition from symtab.h.
6429         * symtab.h (identify_source_line): Move declaration to source.h.
6430         (print_source_lines): Likewise.
6431         (forget_cached_source_info_for_objfile): Likewise.
6432         (forget_cached_source_info): Likewise.
6433         (select_source_symtab): Likewise.
6434         (enum print_source_lines_flag): Move definition to source.h.
6435         * tui/tui-hooks.c: Add 'source.h' include.
6436
6437 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6438
6439         * source.c (print_source_lines_base): Handle requests to print
6440         reverse line number sequences, and guard against empty lines
6441         string.
6442
6443 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * source.c (print_source_lines_base): Fix skip of '\r' if next
6446         character is '\n'.
6447
6448 2019-01-06  Tom Tromey  <tom@tromey.com>
6449
6450         * c-exp.y (struct c_parse_state) <macro_original_text,
6451         expansion_obstack>: New member.
6452         (macro_original_text, expansion_obstack): Remove globals.
6453         (scan_macro_expansion, scanning_macro_expansion)
6454         (finished_macro_expansion): Update.
6455         (scan_macro_cleanup): Remove.
6456         (yylex, c_parse): Update.
6457
6458 2019-01-06  Tom Tromey  <tom@tromey.com>
6459
6460         * c-exp.y (struct c_parse_state) <strings>: New member.
6461         (operator_stoken): Update.
6462
6463 2019-01-06  Tom Tromey  <tom@tromey.com>
6464
6465         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6466         (union type_stack_elt) <typelist_val>: Now a pointer to
6467         std::vector.
6468         (type_stack_cleanup): Don't declare.
6469         (push_typelist): Update.
6470         * parse.c (pop_typelist): Return a std::vector.
6471         (push_typelist): Take a std::vector.
6472         (follow_types): Update.  Do not free args.
6473         (type_stack_cleanup): Remove.
6474         * c-exp.y (struct c_parse_state): New.
6475         (cpstate): New global.
6476         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6477         (nonempty_typelist): Update.
6478         (func_mod): Create a new vector.
6479         (c_parse): Create a c_parse_state.
6480         (check_parameter_typelist): Do not delete params.
6481         (function_method): Update.  Do not delete type_list.
6482
6483 2019-01-06  Tom Tromey  <tom@tromey.com>
6484
6485         PR gdb/28155:
6486         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6487         check_typedef.
6488         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6489         (print_return_value): Likewise.
6490
6491 2019-01-05  Tom Tromey  <tom@tromey.com>
6492
6493         * contrib/cleanup_check.py: Remove.
6494         * contrib/gcc-with-excheck: Remove.
6495         * contrib/exsummary.py: Remove.
6496         * contrib/excheck.py: Remove.
6497
6498 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6499
6500         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6501         NULL. Initialize tpprev to NULL instead of assigning it
6502         to NULL on the next statement.
6503         * windows-nat.c (windows_delete_thread): Remove check for
6504         main_thread_id before printing thread exit notifications.
6505         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6506         Remove thread ID check against main_thread_id.
6507         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6508         windows_delete_thread.
6509         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6510
6511 2019-01-04  Tom Tromey  <tom@tromey.com>
6512
6513         * compile/compile.c (_initialize_compile): Use upper case for
6514         metasyntactic variables.
6515         * symmisc.c (_initialize_symmisc): Use upper case for
6516         metasyntactic variables.
6517         * psymtab.c (_initialize_psymtab): Use upper case for
6518         metasyntactic variables.
6519         * demangle.c (demangle_command): Use upper case for metasyntactic
6520         variables.
6521         (_initialize_demangler): Likewise.
6522         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6523         variables.
6524
6525 2019-01-03  Tom Tromey  <tom@tromey.com>
6526
6527         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6528
6529 2019-01-03  Tom Tromey  <tom@tromey.com>
6530
6531         * python/py-symtab.c (salpy_str): Update.
6532         (struct salpy_sal_object) <symtab>: Now a PyObject.
6533         (salpy_dealloc): Update.
6534         (del_objfile_sal): Use gdbpy_ref.
6535
6536 2019-01-03  Tom Tromey  <tom@tromey.com>
6537
6538         * python/py-type.c (convert_field): Use new_reference.  Return
6539         gdbpy_ref.
6540         (make_fielditem): Return gdbpy_ref.
6541         (typy_fields): Update.
6542         (typy_getitem): Update.
6543         (field_name): Return gdbpy_ref.  Use new_reference.
6544         (typy_iterator_iternext): Update.
6545
6546 2019-01-03  Tom Tromey  <tom@tromey.com>
6547
6548         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6549
6550 2019-01-03  Tom Tromey  <tom@tromey.com>
6551
6552         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6553         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6554         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6555         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6556         (pspy_set_type_printers): Likewise.
6557         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6558         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6559         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6560         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6561         (objfpy_set_type_printers): Likewise.
6562
6563 2019-01-03  Tom Tromey  <tom@tromey.com>
6564
6565         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6566         (gdbpy_print_stack): Use gdbpy_err_fetch.
6567         * python/python-internal.h (class gdbpy_err_fetch): New class.
6568         (class gdbpy_enter) <m_error_type, m_error_value,
6569         m_error_traceback>: Remove.
6570         <m_error>: New member.
6571         (gdbpy_exception_to_string): Don't declare.
6572         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6573         * python/py-value.c (convert_value_from_python): Use
6574         gdbpy_err_fetch.
6575         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6576         gdbpy_exception_to_string.
6577         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6578         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6579         gdbpy_err_fetch.
6580
6581 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6582
6583         * linux-nat.c (delete_lwp_cleanup): Delete.
6584         (struct lwp_deleter): New struct.
6585         (lwp_info_up): New typedef.
6586         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6587         lwp_info_up.
6588
6589 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6590
6591         * linux-fork.c (class scoped_switch_fork_info): New class.
6592         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6593
6594 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6595
6596         * valops.c (find_overload_match): Remove use of null_cleanup, and
6597         calls to do_cleanups.
6598
6599 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6600
6601         * compile/compile-cplus-types.c
6602         (compile_cplus_instance::decl_name): Handle changes to
6603         cp_func_name.
6604         * cp-support.c (cp_func_name): Update header comment, update
6605         return type.
6606         * cp-support.h (cp_func_name): Update return type in declaration.
6607         * valops.c (find_overload_match): Move temp_func local to top
6608         level of function and change its type.  Use temp_func to hold and
6609         delete temporary string obtained from cp_func_name.
6610
6611 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6612
6613         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6614         gdb::char_vector, remove cleanup, and update uses of `msg`.
6615
6616 2019-01-03  Jim Wilson  <jimw@sifive.com>
6617
6618         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6619
6620 2019-01-02  Tom Tromey  <tom@tromey.com>
6621
6622         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6623         (tdesc_parse_xml): Remove cleanups.
6624         * target-descriptions.h (make_cleanup_free_target_description):
6625         Don't declare.
6626         (target_desc_deleter): New struct.
6627         (target_desc_up): New typedef.
6628         * target-descriptions.c (target_desc_deleter::operator()): Rename
6629         from free_target_description.
6630         (make_cleanup_free_target_description): Remove.
6631
6632 2019-01-02  Tom Tromey  <tom@tromey.com>
6633
6634         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6635         constructor, destructor.
6636         (linespec_parser): Remove typedef.
6637         (~linespec_parser): Rename from linespec_parser_delete.
6638         (linespec_lex_to_end, linespec_complete_label)
6639         (linespec_complete): Update.
6640         (decode_line_full): Remove cleanups.
6641         (decode_line_1): Update.
6642
6643 2019-01-02  Tom Tromey  <tom@tromey.com>
6644
6645         * python/python-internal.h (inferior_to_inferior_object): Change
6646         return type.
6647         * python/py-exitedevent.c (create_exited_event_object): Update.
6648         * python/py-inferior.c (inferior_to_inferior_object): Return
6649         gdbpy_ref.
6650         (python_new_inferior, python_inferior_deleted)
6651         (thread_to_thread_object, delete_thread_object)
6652         (build_inferior_list, gdbpy_selected_inferior): Update.
6653         * python/py-infthread.c (create_thread_object): Update.  Also fail
6654         if inferior_to_inferior_object fails.
6655
6656 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6657
6658         * inferior.h (class inferior) <displaced_step_state>: New field.
6659         * infrun.h (struct displaced_step_state): Move here from
6660         infrun.c.  Initialize fields, add constructor.
6661         <inf>: Remove field.
6662         <reset>: New method.
6663         * infrun.c (struct displaced_step_inferior_state): Move to
6664         infrun.h.
6665         (displaced_step_inferior_states): Remove.
6666         (get_displaced_stepping_state): Adust.
6667         (displaced_step_in_progress_any_inferior): Adjust.
6668         (displaced_step_in_progress_thread): Adjust.
6669         (displaced_step_in_progress): Adjust.
6670         (add_displaced_stepping_state): Remove.
6671         (get_displaced_step_closure_by_addr): Adjust.
6672         (remove_displaced_stepping_state): Remove.
6673         (infrun_inferior_exit): Call displaced_step_state.reset.
6674         (use_displaced_stepping): Don't check for NULL.
6675         (displaced_step_prepare_throw): Call
6676         get_displaced_stepping_state.
6677         (displaced_step_fixup): Don't check for NULL.
6678         (prepare_for_detach): Don't check for NULL.
6679
6680 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6681
6682         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6683          in case of call that did not complete.
6684
6685 2019-01-02  Andrey Utkin  <autkin@undo.io>
6686
6687         * symfile.c (find_separate_debug_file): Fix search of debug files for
6688         remote debuggee.
6689
6690 2019-01-02  Tom Tromey  <tom@tromey.com>
6691
6692         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6693         indentation.
6694         * python/py-frame.c (frapy_older): Remove cast.
6695         (frapy_newer): Likewise.
6696         * python/py-breakpoint.c (local_setattro): Remove cast.
6697         * python/py-arch.c (archpy_name): Remove local variable.
6698         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6699
6700 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6701
6702         * unittests/basic_string_view/element_access/char/empty.cc:
6703         Fix year range in copyright header.
6704
6705 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6706
6707         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6708         Delete.
6709         <operator==>: Update with for removed field.
6710         <hash>: Likewise.
6711         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6712         <isa_features>: ...this.
6713         <abi_features>: New field.
6714         (riscv_isa_flen): Update comment.
6715         (riscv_abi_xlen): New declaration.
6716         (riscv_abi_flen): New declaration.
6717         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6718         isa_features.
6719         (riscv_abi_xlen): New function.
6720         (riscv_isa_flen): Update to get answer from isa_features.
6721         (riscv_abi_flen): New function.
6722         (riscv_has_fp_abi): Update to get answer from abi_features.
6723         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6724         xlen and flen.
6725         (riscv_call_info) <xlen, flen>: Update comment.
6726         (riscv_call_arg_struct): Remove invalid assertions
6727         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6728         is removed.
6729         (riscv_gdbarch_init): Gather isa features and abi features
6730         separately, ensure both match on the gdbarch when reusing an old
6731         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6732         a target with 64-bit float hardware.
6733
6734 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6735
6736         * source.c (search_command_helper): Stop reverse search
6737         when line 1 has been searched.
6738
6739 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6740
6741         * record-full.c (record_full_base_target::close): Rewrite
6742         record_full_core_buf_list free logic.
6743
6744 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6745
6746         * break-catch-syscall.c (print_one_catch_syscall): xfree
6747         the last text.
6748
6749 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6750
6751         * top.c (print_gdb_version): Update Copyright year in version
6752         message.
6753
6754 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6755
6756         Update copyright year range in all GDB files.
6757
6758 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6759
6760         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6761
6762 For older changes see ChangeLog-2018.
6763 \f
6764 Local Variables:
6765 mode: change-log
6766 left-margin: 8
6767 fill-column: 74
6768 version-control: never
6769 coding: utf-8
6770 End:
6771