gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * coffread.c (struct coff_symfile_info): Add initializers.
   4         (coff_objfile_data_key): Move lower.  Change type.
   5         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
   6         Update.
   7         (coff_free_info): Remove.
   8
   9 2019-05-08  Tom Tromey  <tom@tromey.com>
  10
  11         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  12         (fbsd_pspace_data_handle): Move lower.  Change type.
  13         (get_fbsd_pspace_data): Update.
  14         (fbsd_pspace_data_cleanup): Remove.
  15         (_initialize_fbsd_tdep): Update.
  16
  17 2019-05-08  Tom Tromey  <tom@tromey.com>
  18
  19         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  20         (get_ada_tasks_pspace_data): Update.
  21         (ada_tasks_pspace_data_cleanup): Remove.
  22         (_initialize_tasks): Update.
  23         (ada_tasks_inferior_data_handle): Change type.
  24         (get_ada_tasks_inferior_data): Update.
  25         (ada_tasks_inferior_data_cleanup): Remove.
  26         (struct ada_tasks_pspace_data): Add initializers.
  27
  28 2019-05-08  Tom Tromey  <tom@tromey.com>
  29
  30         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  31         * symfile-debug.c (debug_sym_get_probes): Change type.
  32         * stap-probe.c (handle_stap_probe):
  33         (stap_static_probe_ops::get_probes): Change type.
  34         * probe.h (class static_probe_ops) <get_probes>: Change type.
  35         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  36         (parse_probes_in_pspace): Update.
  37         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  38         Update.
  39         (any_static_probe_ops::get_probes): Change type.
  40         * elfread.c (elfread_data): New typedef.
  41         (probe_key): Change type.
  42         (elf_get_probes): Likewise.  Update.
  43         (probe_key_free): Remove.
  44         (_initialize_elfread): Update.
  45         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  46         Change type.
  47         (dtrace_process_dof_probe, dtrace_process_dof)
  48         (dtrace_static_probe_ops::get_probe): Change type.
  49
  50 2019-05-08  Tom Tromey  <tom@tromey.com>
  51
  52         * xcoffread.c (struct xcoff_symfile_info): Rename from
  53         coff_symfile_info.  Add initializers.
  54         (xcoff_objfile_data_key): Move lower.  Change type.
  55         (XCOFF_DATA): Rewrite.
  56         (xcoff_free_info): Remove.
  57         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  58         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  59         (xcoff_initial_scan): Update.
  60
  61 2019-05-08  Tom Tromey  <tom@tromey.com>
  62
  63         * solib-svr4.c (struct svr4_info): Add initializers and
  64         destructor.
  65         <probes_table>: Now an htab_up.
  66         (solib_svr4_pspace_data): Change type.
  67         (free_probes_table): Simplify.
  68         (~svr4_info): Rename from svr4_pspace_data_cleanup.
  69         (get_svr4_info, probes_table_htab_remove_objfile_probes)
  70         (probes_table_remove_objfile_probes, register_solib_event_probe)
  71         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
  72         (_initialize_svr4_solib): Update.
  73
  74 2019-05-08  Tom Tromey  <tom@tromey.com>
  75
  76         * remote.c (remote_pspace_data): Change type.
  77         (remote_pspace_data_cleanup): Remove.
  78         (get_remote_exec_file, set_pspace_remote_exec_file)
  79         (_initialize_remote): Update.
  80
  81 2019-05-08  Tom Tromey  <tom@tromey.com>
  82
  83         * breakpoint.c (breakpoint_objfile_key): Change type.
  84         (get_breakpoint_objfile_data): Update.
  85         (free_breakpoint_objfile_data): Remove.
  86         (_initialize_breakpoint): Update.
  87
  88 2019-05-08  Tom Tromey  <tom@tromey.com>
  89
  90         * linux-tdep.c (struct linux_info): Add initializers.
  91         (linux_inferior_data): Move.  Change type.
  92         (invalidate_linux_cache_inf): Update.
  93         (linux_inferior_data_cleanup): Remove.
  94         (get_linux_inferior_data, _initialize_linux_tdep): Update.
  95
  96 2019-05-08  Tom Tromey  <tom@tromey.com>
  97
  98         * auxv.c (auxv_inferior_data): Move.  Change type.
  99         (auxv_inferior_data_cleanup): Remove.
 100         (invalidate_auxv_cache_inf): Rewrite.
 101         (get_auxv_inferior_data, _initialize_auxv): Update.
 102
 103 2019-05-08  Tom Tromey  <tom@tromey.com>
 104
 105         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 106         (symfile_debug_objfile_data_key): Change type.
 107         (symfile_debug_installed, debug_qf_has_symbols)
 108         (debug_qf_find_last_source_symtab)
 109         (debug_qf_forget_cached_source_info)
 110         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 111         (debug_qf_print_stats, debug_qf_dump)
 112         (debug_qf_expand_symtabs_for_function)
 113         (debug_qf_expand_all_symtabs)
 114         (debug_qf_expand_symtabs_with_fullname)
 115         (debug_qf_map_matching_symbols)
 116         (debug_qf_expand_symtabs_matching)
 117         (debug_qf_find_pc_sect_compunit_symtab)
 118         (debug_qf_map_symbol_filenames)
 119         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 120         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 121         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 122         (debug_sym_read_linetable, debug_sym_relocate): Update.
 123         (symfile_debug_free_objfile): Remove.
 124         (install_symfile_debug_logging, _initialize_symfile_debug):
 125         Update.
 126
 127 2019-05-08  Tom Tromey  <tom@tromey.com>
 128
 129         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 130         allocate_on_obstack.
 131         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 132         (get_dwarf2_per_objfile): Update.
 133         (set_dwarf2_per_objfile): Remove.
 134         (dwarf2_has_info, dwarf2_get_section_info): Update.
 135         (dwarf2_free_objfile): Remove.
 136         (_initialize_dwarf2_read): Update.
 137
 138 2019-05-08  Tom Tromey  <tom@tromey.com>
 139
 140         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 141         initializers.
 142         <unsupported_script_warning_printed,
 143         script_not_found_warning_printed>: Now bool.
 144         (auto_load_pspace_data): Change type.
 145         (~auto_load_pspace_info): Rename from
 146         auto_load_pspace_data_cleanup.
 147         (get_auto_load_pspace_data, init_loaded_scripts_info)
 148         (clear_section_scripts, maybe_print_unsupported_script_warning)
 149         (maybe_print_script_not_found_warning, _initialize_auto_load):
 150         Update.
 151
 152 2019-05-08  Tom Tromey  <tom@tromey.com>
 153
 154         * objfiles.c (objfile_pspace_info): Add destructor and
 155         initializers.
 156         (objfiles_pspace_data): Change type.
 157         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 158         (get_objfile_pspace_data): Update.
 159         (objfiles_bfd_data): Change type.
 160         (get_objfile_bfd_data): Update.
 161         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 162
 163 2019-05-08  Tom Tromey  <tom@tromey.com>
 164
 165         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 166         Change type.
 167         (get_catch_syscall_inferior_data): Update.
 168         (catch_syscall_inferior_data_cleanup): Remove.
 169         (_initialize_break_catch_syscall): Update.
 170
 171 2019-05-08  Tom Tromey  <tom@tromey.com>
 172
 173         * inflow.c (struct terminal_info): Add destructor and
 174         initializers.
 175         (inflow_inferior_data): Change type.
 176         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 177         (get_inflow_inferior_data, inflow_inferior_exit)
 178         (swap_terminal_info, _initialize_inflow): Update.
 179
 180 2019-05-08  Tom Tromey  <tom@tromey.com>
 181
 182         * target-dcache.c (target_dcache_cleanup): Remove.
 183         (target_dcache_aspace_key): Change type.
 184         (target_dcache_init_p, target_dcache_invalidate)
 185         (target_dcache_get, target_dcache_get_or_init)
 186         (_initialize_target_dcache): Update.
 187         * dcache.h (struct dcache_deleter): New.
 188
 189 2019-05-08  Tom Tromey  <tom@tromey.com>
 190
 191         * symtab.c (struct symbol_cache): Add destructor and
 192         initializers.
 193         (symbol_cache_key): Move.  Change type.
 194         (make_symbol_cache, free_symbol_cache): Remove.
 195         (get_symbol_cache): Update.
 196         (symbol_cache_cleanup): Remove.
 197         (ALL_PSPACES, symbol_cache_flush)
 198         (maintenance_print_symbol_cache)
 199         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 200         Update.
 201
 202 2019-05-08  Tom Tromey  <tom@tromey.com>
 203
 204         * symtab.c (struct main_info): Add destructor and initializers.
 205         (main_progspace_key): Move.  Change type.
 206         (get_main_info): Update.
 207         (main_info_cleanup): Remove.
 208         (_initialize_symtab): Update.
 209
 210 2019-05-08  Tom Tromey  <tom@tromey.com>
 211
 212         * registry.h (DECLARE_REGISTRY): Define the _key class.
 213
 214 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 215
 216         * NEWS: Merge two 'New commands' sections.
 217
 218 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 219
 220         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 221         parameter and use Ada language definition instead.
 222         (ada_val_print_ptr): Remove unused language parameter.
 223         (ada_val_print_num): Remove language parameter and use Ada language
 224         definition instead.
 225         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 226         parameter.
 227         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 228         parameter and use Ada language definition instead.
 229         (ada_val_print_1): Update all ada_val_print_xxx calls.
 230         Remove language parameter.
 231         (ada_val_print): Update ada_val_print_1 call.
 232
 233 2019-05-08  Tom Tromey  <tromey@adacore.com>
 234
 235         * remote.c (remote_hw_watchpoint_limit)
 236         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 237         Now static.
 238
 239 2019-05-08  Tom Tromey  <tromey@adacore.com>
 240
 241         * maint.c (_initialize_maint_cmds): Move initialization code to
 242         remote.c.
 243         (watchdog, show_watchdog): Move to remote.c.
 244         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 245         "watchdog" static.
 246         (_initialize_remote): Move initialization code from maint.c.
 247         * defs.h (watchdog): Don't declare.
 248
 249 2019-05-08  Tom Tromey  <tromey@adacore.com>
 250
 251         * tui/tui-interp.c: Include main.h.
 252         * interps.c: Include main.h.
 253         * main.h (interpreter_p): Declare.
 254         * defs.h (interpreter_p): Don't declare.
 255
 256 2019-05-08  Tom Tromey  <tromey@adacore.com>
 257
 258         * dwarf2loc.c: Include dwarf2read.h.
 259         * defs.h (read_unsigned_leb128): Don't declare.
 260         * dwarf2read.h (read_unsigned_leb128): Declare.
 261
 262 2019-05-08  Tom Tromey  <tromey@adacore.com>
 263
 264         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 265         method.
 266
 267 2019-05-08  Tom Tromey  <tromey@adacore.com>
 268
 269         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 270         when no wrap column is set.
 271
 272 2019-05-08  Tom Tromey  <tromey@adacore.com>
 273
 274         * c-lang.c (c_get_string): Handle non-C-style arrays.
 275
 276 2019-05-08  Tom Tromey  <tromey@adacore.com>
 277
 278         * typeprint.c (print_offset_data::update): Print the bit offset,
 279         not the number of bits remaining.
 280
 281 2019-05-08  Tom Tromey  <tromey@adacore.com>
 282
 283         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 284         padding at end of comment.
 285
 286 2019-05-08  Tom Tromey  <tromey@adacore.com>
 287
 288         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 289         Compare main types.
 290
 291 2019-05-06  Tom Tromey  <tom@tromey.com>
 292
 293         * common/scoped_mmap.c: Include common-defs.h.
 294         * common/scoped_mmap.h: Don't include config.h.
 295
 296 2019-05-04  Tom Tromey  <tom@tromey.com>
 297
 298         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 299         (struct aarch64_call_info): Add initializers.
 300         <si>: Now a std::vector.
 301         (pass_on_stack, aarch64_push_dummy_call): Update.
 302
 303 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 304             Tom Tromey  <tom@tromey.com>
 305
 306         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 307         (ppc_threads): Now a std::vector.  Now static.
 308         (hwdebug_find_thread_points_by_tid)
 309         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 310         Update.
 311
 312 2019-05-04  Tom Tromey  <tom@tromey.com>
 313
 314         * arc-tdep.c (arc_tdesc_init): Return bool.
 315
 316 2019-05-04  Tom Tromey  <tom@tromey.com>
 317
 318         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 319         Use gdb_assert_not_reached.
 320
 321 2019-05-04  Tom Tromey  <tom@tromey.com>
 322
 323         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 324         "false".
 325
 326 2019-05-04  Tom Tromey  <tom@tromey.com>
 327
 328         * arc-tdep.c (arc_tdesc_init): Use bool.
 329
 330 2019-05-04  Tom Tromey  <tom@tromey.com>
 331
 332         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 333
 334 2019-05-04  Tom Tromey  <tom@tromey.com>
 335
 336         * cli/cli-cmds.c (valid_command_p): Return bool.
 337
 338 2019-05-04  Tom Tromey  <tom@tromey.com>
 339
 340         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 341         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 342
 343 2019-05-04  Raul Tambre  <raul@tambre.ee>
 344
 345         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 346         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 347         operator for comparison.
 348
 349 2019-05-04  Tom Tromey  <tom@tromey.com>
 350
 351         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 352         (lookup_partial_symbol, print_partial_symbols)
 353         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 354         (psymbol_compare): Update.
 355         (add_psymbol_to_bcache): Clear the entire psymbol.
 356         (maintenance_check_psymtabs): Update.
 357         * psympriv.h (struct partial_symbol): Don't derive from
 358         general_symbol_info.
 359         <obj_section, unrelocated_address, address,
 360         set_unrelocated_address>: Update.
 361         <ginfo>: New member.
 362         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 363         (debug_names::write_psymbols): Update.
 364
 365 2019-05-04  Tom de Vries  <tdevries@suse.de>
 366
 367         * contrib/cc-with-tweaks.sh: Support -n arg.
 368
 369 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 370
 371         * corelow.c (core_target::detach): Ensure frame cache and
 372         register caches are cleared.
 373         inferior.c (exit_inferior_1): Likewise.
 374
 375 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 376             Tom Tromey  <tom@tromey.com>
 377
 378         * dictionary.c (collate_pending_symbols_by_language): Remove
 379         "struct" from foreach.
 380         * symtab.c (lookup_global_symbol_from_objfile)
 381         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 382         foreach.
 383         * ser-tcp.c (net_open): Remove "struct" from foreach.
 384         * objfiles.c (objfile_relocate, objfile_rebase)
 385         (objfile_has_symbols): Remove "struct" from foreach.
 386         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 387         from foreach.
 388         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 389         foreach.
 390         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 391         "struct" from foreach.
 392         * ada-lang.c (create_excep_cond_exprs)
 393         (ada_exception_catchpoint_cond_string): Remove "struct" from
 394         foreach.
 395
 396 2019-05-03  Tom Tromey  <tromey@adacore.com>
 397
 398         * ada-exp.y (convert_char_literal): Check suffix of each
 399         enumerator.
 400
 401 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 402
 403         PR ada/21406:
 404         * ada-exp.y (yywrap): Don't define.
 405         * ada-lex.l (%option): Add noyywrap
 406         (yywrap): Remove.
 407
 408 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 409
 410         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 411         _WIN32_WINNT to the XP level, unless already defined to a higher
 412         level.
 413
 414         * unittests/parse-connection-spec-selftests.c:
 415         * ser-tcp.c:
 416         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 417         override.
 418
 419         * symfile.c (find_separate_debug_file): Remove colon from the
 420         drive spec of DOS/Windows file names of the target, so that the
 421         file name produced from DEBUGDIR and the target's directory will
 422         be valid on DOS/Windows systems.
 423
 424 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 425
 426         * rust-lang.c (val_print_struct): Handle printing structures
 427         containing strings.
 428
 429 2019-05-02  Tom Tromey  <tromey@adacore.com>
 430
 431         * valarith.c (_initialize_valarith): Remove.
 432
 433 2019-05-01  Tom Tromey  <tromey@adacore.com>
 434
 435         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 436         bitfields.
 437
 438 2019-05-01  Tom Tromey  <tromey@adacore.com>
 439
 440         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 441         for big-endian copies.
 442
 443 2019-04-30  Ali Tamur  <tamur@google.com>
 444         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 445         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 446         (read_3_bytes): New function.
 447
 448 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 449
 450         * windows-nat.c (main_thread_id): Delete.
 451         (handle_output_debug_string): Replace main_thread_id by
 452         current_event.dwThreadId.
 453         (fake_create_process): Likewise.
 454         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 455         Do not set main_thread_id.
 456         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 457         current_event.dwThreadId.
 458         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 459
 460 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 461
 462         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 463         Use current_event.dwThreadId instead of main_thread_id.
 464
 465 2019-04-30  Tom Tromey  <tromey@adacore.com>
 466
 467         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 468         (create_excep_cond_exprs): Iterate over program spaces.
 469         (ada_exception_catchpoint_cond_string): Examine all minimal
 470         symbols for exception types.
 471
 472 2019-04-30  Tom Tromey  <tromey@adacore.com>
 473
 474         PR c++/24470:
 475         * dwarf2read.c (process_structure_scope): Handle case where type
 476         has template parameters but no symbol was created.
 477
 478 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 479             Chris January  <chris.january@arm.com>
 480
 481         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 482         qualifier.
 483         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 484
 485 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 486
 487         * f-typeprint.c (f_print_type): Update rules for printing
 488         whitespace.
 489         (f_type_print_varspec_suffix): Likewise.
 490
 491 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 492             Chris January  <chris.january@arm.com>
 493
 494         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 495         function arguments.
 496
 497 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 498
 499         * f-lang.c (build_fortran_types): Change name of void type to
 500         lower case.
 501         * f-typeprint.c (f_type_print_base): Print the name of the void
 502         type, rather than a fixed string.
 503         * f-valprint.c (f_decorations): Use lower case void string.
 504
 505 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 506             Chris January  <chris.january@arm.com>
 507
 508         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 509         types for Fortran.
 510
 511 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 512             Chris January  <chris.january@arm.com>
 513             David Lecomber  <david.lecomber@arm.com>
 514
 515         * f-exp.y (BINOP_INTRINSIC): New token.
 516         (exp): New parser rule handling BINOP_INTRINSIC.
 517         (f77_keywords): Add new builtin procedures.
 518         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 519         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 520         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 521         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 522         (print_unop_subexp_f): New function.
 523         (print_binop_subexp_f): New function.
 524         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 525         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 526         (dump_subexp_body_f): Likewise.
 527         (operator_check_f): Likewise.
 528         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 529         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 530
 531 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 534         UNOP_KIND.
 535         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 536         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 537         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 538         (operator_length_f): New fuction.
 539         (print_subexp_f): New function.
 540         (op_name_f): New function.
 541         (dump_subexp_body_f): New function.
 542         (operator_check_f): New function.
 543         (exp_descriptor_f): Replace standard expression handling functions
 544         with new functions.
 545         * gdb/fortran-operator.def: New file.
 546         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 547         * gdb/std-operator.def: Remove UNOP_KIND.
 548
 549 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * std-operator.def: Remove unbalanced, stray double quote
 552         character.
 553
 554 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 555             Chris January  <chris.january@arm.com>
 556             Daniel Everett  <daniel.everett@arm.com>
 557             Nick Forrington  <nick.forrington@arm.com>
 558             Richard Bunt  <richard.bunt@arm.com>
 559
 560         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 561         of depth when printing anonymous structs or unions.
 562         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 563         Don't print either the top-level value, or the children if the
 564         max-depth is exceeded.
 565         (ppscm_print_children): When printing the key of a map, allow one
 566         extra level of depth.
 567         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 568         print either the top-level value, or the children if the max-depth
 569         is exceeded.
 570         (print_children): When printing the key of a map, allow one extra
 571         level of depth.
 572         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 573         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 574         (user_print_options): Initialise max_depth field.
 575         (val_print_scalar_or_string_type_p): New function.
 576         (val_print): Check to see if the max depth has been reached.
 577         (val_print_check_max_depth): Define new function.
 578         (show_print_max_depth): New function.
 579         (_initialize_valprint): Add 'print max-depth' option.
 580         * valprint.h (struct value_print_options) <max_depth>: New field.
 581         (val_print_check_max_depth): Declare new function.
 582         * NEWS: Document new feature.
 583
 584 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 585
 586         * ada-lang.c (ada_language_defn): Initialise new field.
 587         * c-lang.c (c_is_string_type_p): New function.
 588         (c_language_defn): Initialise new field.
 589         (cplus_language_defn): Initialise new field.
 590         (asm_language_defn): Initialise new field.
 591         (minimal_language_defn): Initialise new field.
 592         * c-lang.h (c_is_string_type_p): Declare new function.
 593         * d-lang.c (d_language_defn): Initialise new field.
 594         * f-lang.c (f_is_string_type_p): New function.
 595         (f_language_defn): Initialise new field.
 596         * go-lang.c (go_is_string_type_p): New function.
 597         (go_language_defn): Initialise new field.
 598         * language.c (default_is_string_type_p): New function.
 599         (unknown_language_defn): Initialise new field.
 600         (auto_language_defn): Initialise new field.
 601         * language.h (struct language_defn) <la_is_string_type_p>: New
 602         member variable.
 603         (default_is_string_type_p): Declare new function.
 604         * m2-lang.c (m2_language_defn): Initialise new field.
 605         * objc-lang.c (objc_language_defn): Initialise new field.
 606         * opencl-lang.c (opencl_language_defn): Initialise new field.
 607         * p-lang.c (pascal_is_string_type_p): New function.
 608         (pascal_language_defn): Initialise new field.
 609         * rust-lang.c (rust_is_string_type_p): New function.
 610         (rust_language_defn): Initialise new field.
 611
 612 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 613
 614         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 615         New field.
 616         * ada-lang.c (ada_language_defn): Initialise new field.
 617         * c-lang.c (c_language_defn): Likewise.
 618         (cplus_language_defn): Likewise.
 619         (asm_language_defn): Likewise.
 620         (minimal_language_defn): Likewise.
 621         * d-lang.c (d_language_defn): Likewise.
 622         * f-lang.c (f_language_defn): Likewise.
 623         * go-lang.c (go_language_defn): Likewise.
 624         * language.c (unknown_language_defn): Likewise.
 625         (auto_language_defn): Likewise.
 626         * m2-lang.c (m2_language_defn): Likewise.
 627         * objc-lang.c (objc_language_defn): Likewise.
 628         * opencl-lang.c (opencl_language_defn): Likewise.
 629         * p-lang.c (pascal_language_defn): Likewise.
 630         * rust-lang.c (rust_language_defn): Likewise.
 631
 632 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         * ada-lang.c (ada_is_character_type): Change return type to bool.
 635         (ada_is_string_type): Likewise.
 636         * ada-lang.h (ada_is_character_type): Update declaration
 637         (ada_is_string_type): Likewise.
 638
 639 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 640
 641         Support style in 'frame|thread apply'
 642
 643         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 644         * record.c (record_start, record_stop): Update callers of
 645         execute_command_to_string with false.
 646         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 647         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 648         methods.
 649         (class string_file): New constructor with term_out parameter.
 650         Override methods term_out and can_emit_style_escape.  New member
 651         term_out.
 652         (class stdio_file): Override can_emit_style_escape.
 653         (class tee_file): Override term_out and can_emit_style_escape.
 654         * utils.h (can_emit_style_escape): Remove.
 655         * utils.c (can_emit_style_escape): Likewise.
 656         Update all callers of can_emit_style_escape (SOMESTREAM) to
 657         SOMESTREAM->can_emit_style_escape.
 658         * source-cache.c (source_cache::get_source_lines): Likewise.
 659         * stack.c (frame_apply_command_count): Call execute_command_to_string
 660         passing the term_out characteristic of the current gdb_stdout.
 661         * thread.c (thr_try_catch_cmd): Likewise.
 662         * top.c (execute_command_to_string): pass term_out parameter
 663         to construct the string_file for the command output.
 664         * ui-file.c (term_cli_styling): New function (most code moved
 665         from utils.c can_emit_style_escape).
 666         (string_file::string_file, string_file::can_emit_style_escape,
 667         stdio_file::can_emit_style_escape, tee_file::term_out,
 668         tee_file::can_emit_style_escape): New functions.
 669
 670 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 671
 672         * NEWS: Mention the new set|show may-call-functions.
 673         * infcall.c (may_call_functions_p): New variable.
 674         (show_may_call_functions_p): New function.
 675         (call_function_by_hand_dummy): Throws an error if not
 676         may-call-functions.
 677         (_initialize_infcall): Call add_setshow_boolean_cmd for
 678         may-call-functions.
 679
 680 2019-04-25  Keith Seitz  <keiths@redhat.com>
 681
 682         PR c++/24367
 683         * cp-support.c (inspect_type): Don't attempt substitutions
 684         of symbol with the same name.
 685
 686 2019-04-25  Tom Tromey  <tromey@adacore.com>
 687
 688         PR gdb/24475:
 689         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 690         static.
 691
 692 2019-04-25  Tom Tromey  <tromey@adacore.com>
 693
 694         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 695         rvalue reference.
 696         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 697         (gdb_xml_parser::parse): Use std::move.
 698         * python/python-internal.h (gdbpy_convert_exception): Take a const
 699         reference.
 700         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 701         std::move.
 702         * python/py-utils.c (gdbpy_convert_exception): Take a const
 703         reference.
 704         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 705         Use std::move.
 706         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 707         Use std::move.
 708         * mi/mi-main.c (mi_print_exception): Take a const reference.
 709         * main.c (handle_command_errors): Take a const reference.
 710         * linespec.c (parse_linespec): Use std::move.
 711         * infcall.c (run_inferior_call): Use std::move.
 712         (call_function_by_hand_dummy): Use std::move.
 713         * exec.c (try_open_exec_file): Use std::move.
 714         * exceptions.h (exception_print, exception_fprintf)
 715         (exception_print_same): Update.
 716         * exceptions.c (print_exception, exception_print)
 717         (exception_fprintf, exception_print_same): Change parameters to
 718         const reference.
 719         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 720         * common/new-op.c: Use std::move.
 721         * common/common-exceptions.h (struct gdb_exception): Add move
 722         constructor.
 723         (struct gdb_exception_error, struct gdb_exception_quit, struct
 724         gdb_quit_bad_alloc): Change constructor to move constructor.
 725         (throw_exception): Change parameter to rvalue reference.
 726         * common/common-exceptions.c (throw_exception): Take rvalue
 727         reference.
 728         * cli/cli-interp.c (safe_execute_command): Use std::move.
 729         * breakpoint.c (insert_bp_location, location_to_sals): Use
 730         std::move.
 731
 732 2019-04-25  Tom Tromey  <tromey@adacore.com>
 733
 734         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 735         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 736         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 737         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 738         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 739         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 740         guile/scm-value.c: Use unpack.
 741         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 742         gdbscm_gdb_exception.
 743         (gdbscm_throw_gdb_exception): Likewise.
 744         (struct gdbscm_gdb_exception): New.
 745         (unpack): New function.
 746         (gdbscm_wrap): Use unpack.
 747
 748 2019-04-25  Tom Tromey  <tromey@adacore.com>
 749
 750         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 751         (gdb_rl_callback_handler): Use std::move.
 752         * common/common-exceptions.h (struct gdb_exception): Add move
 753         assignment operator.
 754         (throw_exception_sjlj): Change "exception" to const reference.
 755         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 756         (throw_exception_sjlj): Change "exception" to const reference.
 757
 758 2019-04-25  Tom Tromey  <tromey@adacore.com>
 759
 760         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 761         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 762         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 763         Update.
 764         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 765         Update.
 766         * mi/mi-interp.c (mi_interp::exec): Update.
 767         * linespec.c (parse_linespec): Update.
 768         * infcall.c (run_inferior_call): Update.
 769         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 770         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 771         (gdbscm_lookup_global_symbol): Update.
 772         * guile/scm-param.c (gdbscm_parameter_value): Update.
 773         * guile/scm-frame.c (gdbscm_frame_read_register)
 774         (gdbscm_frame_read_var): Update.
 775         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 776         * exec.c (try_open_exec_file): Update.
 777         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 778         (gdb_rl_callback_handler): Update.
 779         * common/common-exceptions.h (exception_none): Don't declare.
 780         * common/common-exceptions.c (exception_none): Don't define.
 781         (struct catcher) <exception>: Update.
 782         * cli/cli-interp.c (safe_execute_command): Update.
 783         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 784
 785 2019-04-25  Ali Tamur  <tamur@google.com>
 786
 787         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 788         (read_attribute_value): Likewise.
 789         (dwarf2_read_addr_index): Update comment.
 790         (read_str_index): Add DW_FORM_strx.
 791         (dwarf2_string_attr): Likewise.
 792         (dwarf2_const_value_attr): Likewise.
 793         (dump_die_shallow): Likewise.
 794         (dwarf2_fetch_constant_bytes): Likewise.
 795         (skip_form_bytes): Likewise.
 796         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 797
 798 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 799
 800         PR corefiles/11608
 801         PR corefiles/18187
 802         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 803         OFFSET.  Verify if current mapping contains an ELF header.
 804         (linux_find_memory_regions_full): Adjust call to
 805         dump_mapping_p.
 806
 807 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 808             Kang Li <kanglictf@gmail.com>
 809
 810         PR gdb/21600
 811
 812         * dwarf2-frame.c (read_initial_length): Be consistent about using
 813         unsigned representation of length.
 814         (decode_frame_entry_1): Likewise.  Check for wraparound of
 815         end pointer as well as buffer overflow.
 816
 817 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 818
 819         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 820         "vq".
 821
 822 2019-04-24  Tom Tromey  <tromey@adacore.com>
 823
 824         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 825
 826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         * s12z-tdep.c (s12z_unwind_pc): Delete.
 829         (s12z_unwind_sp): Delete.
 830         (s12z_gdbarch_init): Don't register deleted functions with
 831         gdbarch.
 832
 833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * rl78-tdep.c (rl78_unwind_sp): Delete.
 836         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 837
 838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 841         (xstormy16_unwind_pc): Delete.
 842         (xstormy16_dummy_id): Delete.
 843         (xstormy16_gdbarch_init): Don't register deleted functions with
 844         gdbarch.
 845
 846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * vax-tdep.c (vax_unwind_pc): Delete.
 849         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 850
 851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * v850-tdep.c (v850_unwind_sp): Delete.
 854         (v850_unwind_pc): Delete.
 855         (v850_dummy_id): Delete.
 856         (v850_gdbarch_init): Don't register deleted functions with
 857         gdbarch.
 858
 859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 862         (tilegx_unwind_pc): Delete.
 863         (tilegx_unwind_dummy_id): Delete.
 864         (tilegx_gdbarch_init): Don't register deleted functions with
 865         gdbarch.
 866
 867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 870         (tic6x_dummy_id): Delete.
 871         (tic6x_gdbarch_init): Don't register deleted functions with
 872         gdbarch.
 873
 874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * sparc-tdep.c (sparc_unwind_pc): Delete.
 877         (sparc32_gdbarch_init): Don't register deleted function with
 878         gdbarch.
 879
 880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * sh-tdep.c (sh_unwind_sp): Delete.
 883         (sh_unwind_pc): Delete.
 884         (sh_dummy_id): Delete.
 885         (sh_gdbarch_init): Don't register deleted functions with
 886         gdbarch.
 887
 888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * score-tdep.c (score_unwind_sp): Delete.
 891         (score_unwind_pc): Delete.
 892         (score_dummy_id): Delete.
 893         (score_gdbarch_init): Don't register deleted functions with
 894         gdbarch.
 895
 896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 897
 898         * rx-tdep.c (rx_unwind_pc): Delete.
 899         (rx_unwind_sp): Delete.
 900         (rx_dummy_id): Delete.
 901         (rx_gdbarch_init): Don't register deleted functions with
 902         gdbarch.  Update comment.
 903
 904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 907         (rs6000_dummy_id): Delete.
 908         (rs6000_gdbarch_init): Don't register deleted functions with
 909         gdbarch.
 910
 911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 912
 913         * or1k-tdep.c (or1k_dummy_id): Delete.
 914         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 915
 916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * nios2-tdep.c (nios2_dummy_id): Delete.
 919         (nios2_unwind_sp): Delete.
 920         (nios2_gdbarch_init): Don't register deleted functions with
 921         gdbarch.
 922
 923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * nds32-tdep.c (nds32_dummy_id): Delete.
 926         (nds32_unwind_pc): Delete.
 927         (nds32_unwind_sp): Delete.
 928         (nds32_gdbarch_init): Don't register deleted functions with
 929         gdbarch.
 930
 931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * msp430-tdep.c (msp430_unwind_pc): Delete.
 934         (msp430_unwind_sp): Delete.
 935         (msp430_dummy_id): Delete.
 936         (msp430_gdbarch_init): Don't register deleted functions with
 937         gdbarch.
 938
 939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * moxie-tdep.c (moxie_unwind_sp): Delete.
 942         (moxie_unwind_pc): Delete.
 943         (moxie_dummy_id): Delete.
 944         (moxie_gdbarch_init): Don't register deleted functions with
 945         gdbarch.
 946
 947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 950         (mn10300_unwind_pc): Delete.
 951         (mn10300_unwind_sp): Delete.
 952         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 953         mn10300_unwind_sp.
 954         (mn10300_frame_unwind_init): Don't register deleted functions with
 955         gdbarch.
 956
 957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * mep-tdep.c (mep_unwind_pc): Delete.
 960         (mep_unwind_sp): Delete.
 961         (mep_dummy_id): Delete.
 962         (mep_gdbarch_init): Don't register deleted functions with
 963         gdbarch.
 964
 965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 968         (m68hc11_unwind_sp): Delete.
 969         (m68hc11_gdbarch_init): Don't register deleted functions with
 970         gdbarch.
 971
 972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * m32r-tdep.c (m32r_unwind_sp): Delete.
 975         (m32r_unwind_pc): Delete.
 976         (m32r_dummy_id): Delete.
 977         (m32r_gdbarch_init): Don't register deleted functions with
 978         gdbarch.
 979
 980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * m32c-tdep.c (m32c_unwind_pc): Delete.
 983         (m32c_unwind_sp): Delete.
 984         (m32c_dummy_id): Delete.
 985         (m32c_gdbarch_init): Don't register deleted functions with
 986         gdbarch.
 987
 988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 991         (lm32_unwind_pc): Delete.
 992         (lm32_dummy_id): Delete.
 993         (lm32_gdbarch_init): Don't register deleted functions with
 994         gdbarch.
 995
 996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 999         (iq2000_unwind_pc): Delete.
1000         (iq2000_dummy_id): Delete.
1001         (iq2000_gdbarch_init): Don't register deleted functions with
1002         gdbarch.
1003
1004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * nds32-tdep.c (nds32_type_align): Delete.
1007         (nds32_push_dummy_call): Use type_align instead.
1008
1009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * arm-tdep.c (arm_type_align): Only handle vector override case.
1012         (arm_push_dummy_call): Use type_align.
1013         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1014
1015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1018         case.
1019         (pass_on_stack): Use type_align.
1020         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1021         function.
1022
1023 2019-04-23  Tom Tromey  <tromey@adacore.com>
1024
1025         * dwarf2read.c (line_header::file_name_at): Remove unused
1026         overload.
1027
1028 2019-04-23  Tom de Vries  <tdevries@suse.de>
1029
1030         PR gdb/24438
1031         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1032         invocation.
1033
1034
1035 2019-03-27  Ali Tamur  <tamur@google.com>
1036
1037         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1038         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1039         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1040         (dwarf_expr_context::get_addr_index): Likewise
1041         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1042         (symbol_needs_eval_context::get_addr_index): Likewise
1043         (disassemble_dwarf_expression): Add DW_OP_addrx
1044         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1045         (read_cutu_die_from_dwo): Update comment
1046         (skip_one_die): Add DW_FORM_addrx
1047         (read_attribute_value): Likewise
1048         (var_decode_location): Add DW_OP_addrx
1049         (dwarf2_const_value_attr): Add DW_FORM_addrx
1050         (dump_die_shallow): Likewise
1051         (dwarf2_fetch_constant_bytes): Likewise
1052         (decode_locdesc): Add DW_OP_addrx
1053         (skip_form_bytes): Add DW_FORM_addrx
1054
1055 2019-04-22  Ali Tamur  <tamur@google.com>
1056
1057         * MAINTAINERS (Write After Approval): Add self.
1058
1059 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1060
1061         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1062         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1063         (open_symbol_file_object): Likewise.
1064         (svr4_default_sos): Add info parameter.
1065         (svr4_read_so_list): Likewise.
1066         (svr4_current_sos_direct): Adjust functions calls to pass down
1067         info.
1068         (svr4_current_sos_1): Add info parameter.
1069         (svr4_current_sos): Call get_svr4_info, pass info down to
1070         svr4_current_sos_1.
1071         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1072         get_svr4_info.
1073         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1074         get_svr4_info.
1075         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1076         to get_svr4_info.
1077         (probes_table_remove_objfile_probes): Likewise.
1078         (register_solib_event_probe): Add info parameter.
1079         (solist_update_incremental): Pass info parameter down to
1080         svr4_read_so_list.
1081         (disable_probes_interface): Add info parameter.
1082         (svr4_handle_solib_event): Pass current_program_space to
1083         get_svr4_info.  Adjust disable_probes_interface cleanup.
1084         (svr4_create_probe_breakpoints): Add info parameter, pass it
1085         down to register_solib_event_probe.
1086         (svr4_create_solib_event_breakpoints): Add info parameter,
1087         pass it down to svr4_create_probe_breakpoints.
1088         (enable_break): Pass info down to
1089         svr4_create_solib_event_breakpoints.
1090         (svr4_solib_create_inferior_hook): Pass current_program_space to
1091         get_svr4_info.
1092         (svr4_clear_solib): Likewise.
1093
1094 2019-04-22  Pedro Alves  <palves@redhat.com>
1095
1096         * solib-svr4.c (svr4_free_objfile_observer): New.
1097         (probe_and_action::objfile): New field.
1098         (probes_table_htab_remove_objfile_probes)
1099         (probes_table_remove_objfile_probes): New functions.
1100         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1101         in the new probe_and_action.  Don't store the probe in 'lookup'.
1102         (svr4_create_probe_breakpoints): Pass objfile to
1103         register_solib_event_probe.
1104         (_initialize_svr4_solib): Register a free_objfile observer.
1105
1106 2019-04-19  Tom Tromey  <tom@tromey.com>
1107
1108         * common/queue.h: Remove.
1109
1110 2019-04-19  Tom Tromey  <tom@tromey.com>
1111
1112         * event-loop.c: Don't include "common/queue.h".
1113
1114 2019-04-19  Tom Tromey  <tom@tromey.com>
1115
1116         * remote.c (remote_target): Use delete.
1117         * remote-notif.h: Include <list>, not "common/queue.h".
1118         (notif_client_p): Remove typedef.
1119         (remote_notif_state): Add constructor, destructor, initializer.
1120         <notif_queue>: Now a std::list.
1121         (remote_notif_state_xfree): Don't declare.
1122         * remote-notif.c (remote_notif_process, handle_notification)
1123         (remote_notif_state_allocate): Update.
1124         (~remote_notif_state): Rename from remote_notif_state_xfree.
1125
1126 2019-04-19  Tom Tromey  <tom@tromey.com>
1127
1128         * symfile.c (reread_symbols): Update.
1129         * objfiles.c (objfile_register_static_link)
1130         (objfile_lookup_static_link): Update
1131         (~objfile) Don't delete static_links.
1132         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1133
1134 2019-04-19  Tom Tromey  <tom@tromey.com>
1135
1136         * type-stack.h (struct type_stack) <insert>: Constify string.
1137         * type-stack.c (type_stack::insert): Constify string.
1138         * gdbtypes.h (lookup_template_type): Update.
1139         (address_space_name_to_int): Update.
1140         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1141         const.
1142         (lookup_template_type): Make name const.
1143         * c-exp.y: Update rules.
1144         (lex_one_token, classify_name, classify_inner_name)
1145         (c_print_token): Update.
1146         * p-exp.y: Update rules.
1147         (yylex): Update.
1148         * f-exp.y: Update rules.
1149         (yylex): Update.
1150         * d-exp.y: Update rules.
1151         (lex_one_token, classify_name, classify_inner_name): Update.
1152         * parse.c (write_dollar_variable, copy_name): Return std::string.
1153         * parser-defs.h (copy_name): Change return type.
1154         * m2-exp.y: Update rules.
1155         (yylex): Update.
1156         * go-exp.y (lex_one_token): Update.
1157         Update rules.
1158         (classify_unsafe_function, classify_packaged_name)
1159         (classify_name, yylex): Update.
1160
1161 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1162
1163         * configure.ac: add --enable-source-highlight switch.
1164         * configure: Regenerate.
1165         * top.c (print_gdb_version): plumb --enable-source-highlight
1166         status to "show configuration".
1167
1168 2019-04-19  Tom Tromey  <tromey@adacore.com>
1169
1170         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1171         Check ADA_TYPE_P.
1172         (empty_record, ada_template_to_fixed_record_type_1)
1173         (template_to_static_fixed_type)
1174         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1175         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1176         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1177         macros.
1178
1179 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1180
1181         PR symtab/24423:
1182         * source.c (print_source_lines_base): Advance "iter" when a
1183         control character is seen.
1184
1185 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1186
1187         * inferior.h (struct infcall_suspend_state_deleter):
1188         Catch exception in destructor to avoid crash.
1189
1190 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1191
1192         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1193         close to the add_com "shell".
1194
1195 2019-04-18  Tom Tromey  <tromey@adacore.com>
1196
1197         * process-stratum-target.h (class process_stratum_target)
1198         <stratum>: Add "final".
1199
1200 2019-04-17  Tom Tromey  <tromey@adacore.com>
1201
1202         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1203         against nullptr before use.
1204
1205 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1206
1207         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1208
1209 2019-04-17  Jim Wilson  <jimw@sifive.com>
1210             Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1213         code read might fail, assume 4-byte breakpoint in that case.
1214
1215 2019-04-15  Leszek Swirski  <leszeks@google.com>
1216
1217         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1218         rather than a hand-rolled POD check when checking for forced MEMORY
1219         classification.
1220
1221 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1222
1223         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1224         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1225         function.
1226         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1227         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1228         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1229         declaration.
1230
1231 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1232
1233         * aarch64-linux-nat.c
1234         (aarch64_linux_nat_target::thread_architecture): Add override.
1235         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1236         each VQ.
1237
1238 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1239
1240         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1241
1242 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1245         target types of size 96-bits, add some additional comments, and
1246         check that the builtin type we found was the correct size.
1247
1248 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1249
1250         * utils.c (prompt_for_continue): Don't restore the styling at the
1251         end, as applied_style has the wrong value.  This fixes styling in
1252         long lists of file names that are interrupted by the "Continue?"
1253         prompt.
1254
1255 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1258         * c-lang.c (c_language_defn): Likewise.
1259         (cplus_language_defn): Likewise.
1260         (asm_language_defn): Likewise.
1261         (minimal_language_defn): Likewise.
1262         * d-lang.c (d_language_defn): Likewise.
1263         * f-lang.c (f_language_defn): Likewise.
1264         * go-lang.c (go_language_defn): Likewise.
1265         * language.c (unknown_language_defn): Likewise.
1266         (auto_language_defn): Likewise.
1267         * language.h (struct language_defn): Remove la_magic field.
1268         (LANG_MAGIC): Delete.
1269         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1270         * objc-lang.c (objc_language_defn): Likewise.
1271         * opencl-lang.c (opencl_language_defn): Likewise.
1272         * p-lang.c (pascal_language_defn): Likewise.
1273         * rust-lang.c (rust_language_defn): Likewise.
1274
1275 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * riscv-tdep.c (riscv_type_align): New function.
1278         (riscv_type_alignment): Delete.
1279         (riscv_arg_location): Use 'type_align'.
1280         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1281
1282 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * gdbtypes.c (type_align): A struct with no non-static fields also
1285         has alignment of 1.
1286
1287 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1290         component to 0.
1291         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1292         member.
1293         (riscv_struct_info::analyse): New implementation using new
1294         analyse_inner member function.
1295         (riscv_struct_info::field_offset): New member function.
1296         (riscv_struct_info::m_offsets): New member variable.
1297         (riscv_struct_info::analyse_inner): New private member function,
1298         takes the old implementation of riscv_struct_info::analyse but
1299         extended to track field offsets.
1300         (riscv_call_arg_struct): Update the struct folding special cases
1301         to handle cases where empty C++ structs, which are non-zero
1302         length, are found.
1303         (riscv_arg_location): Initialise the length of each location, a
1304         non-zero length now indicates the location is in use.
1305         (riscv_push_dummy_call): Allow for the first location having a
1306         non-zero offset when setting up arguments.
1307         (riscv_return_value): Likewise, but for return values.
1308
1309 2019-04-11  Tom Tromey  <tromey@adacore.com>
1310
1311         * utils.c (internal_vproblem): Make "msg" const.
1312
1313 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1314
1315         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1316         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1317         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1318         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1319
1320 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1321
1322         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1323         function.
1324         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1325         of amd64_collect_native_gregset.
1326         (amd64_linux_nat_target::store_registers): Likewise.
1327
1328 2019-04-10  Tom Tromey  <tom@tromey.com>
1329
1330         * symtab.c (lookup_global_symbol_from_objfile)
1331         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1332         * objfiles.h (class separate_debug_iterator): New.
1333         (class separate_debug_range): New.
1334         (struct objfile) <separate_debug_objfiles>: New method.
1335         (objfile_separate_debug_iterate): Don't declare.
1336         * objfiles.c (separate_debug_iterator::operator++): Rename from
1337         objfile_separate_debug_iterate.
1338         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1339         iterator.
1340         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1341         iterator.
1342
1343 2019-04-10  Tom Tromey  <tom@tromey.com>
1344
1345         * symfile.c (reread_symbols): Remove old comment.
1346         * objfiles.c (free_all_objfiles): Fix a typo.
1347
1348 2019-04-10  Tom Tromey  <tom@tromey.com>
1349
1350         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1351         * minsyms.c (lookup_minimal_symbol): Use foreach.
1352         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1353         (lookup_minimal_symbol_solib_trampoline): Likewise.
1354         * symfile.c (reread_symbols): Use foreach.
1355
1356 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1357             Tom Tromey  <tromey@adacore.com>
1358
1359         PR rust/24414:
1360         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1361         (rust_lex_int_test): Change "value" to be LONGEST.
1362         (rust_lex_tests): Add test for long integer literal.
1363
1364 2019-04-09  Tom Tromey  <tromey@adacore.com>
1365
1366         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1367         to bool.
1368         (extended_remote_target::attach): Update.
1369         (remote_target::remote_notice_new_inferior): Update.
1370         (remote_target::add_current_inferior_and_thread): Update.
1371         * inferior.c (exit_inferior_1): Use "false".
1372         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1373
1374 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1375
1376         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1377         the "start" command.
1378
1379 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1380
1381         * python/py-inferior.c (infpy_thread_from_thread_handle):
1382         Adjust comments to reflect renaming of thread_from_thread_handle
1383         to thread_from_handle.  Adjust keywords.  Fix type error message.
1384         (inferior_object_methods): Add thread_from_handle.  Retain
1385         thread_from_thread_handle, but mark it as deprecated.
1386
1387 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1388
1389         * gdbthread.h (find_thread_by_handle): Revise declaration.
1390         * thread.c (find_thread_by_handle): Likewise.  Adjust
1391         implementation too.
1392         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1393         support for buffer objects as handles.
1394
1395 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1396
1397         * python/py-infthread.c (thpy_thread_handle): New function.
1398         (thread_object_methods): Register thpy_thread_handle.
1399
1400 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1401
1402         * gdbthread.h (thread_to_thread_handle): Declare.
1403         * thread.c (gdbtypes.h): Include.
1404         (thread_to_thread_handle): New function.
1405
1406         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1407         (target_thread_info_to_thread_handle): Declare.
1408         * target.c (target_thread_info_to_thread_handle): New function.
1409         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1410         * target-delegates.c: Regenerate.
1411
1412         * linux-thread-db.c (class thread_db_target): Add method
1413         thread_info_to_thread_handle.
1414         (thread_db_target::thread_info_to_thread_handle): Define.
1415         * remote.c (class remote_target): Add new method
1416         thread_info_to_thread_handle.
1417         (remote_target::thread_info_to_thread_handle): Define.
1418
1419 2019-04-08  Pedro Alves  <palves@redhat.com>
1420
1421         * common/common-exceptions.c (throw_exception): Don't create
1422         named object to throw; throw directly.
1423         (throw_it): Likewise.  Don't initialize gdb_exception::message
1424         here, with new; pass FMT and AP to the ctor instead.
1425         * common/common-exceptions.h: Include <string>.
1426         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1427         const char *, va_list)): New ctor.  Use std::make_shared.
1428         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1429         errors)): Delete.
1430         (gdb_exception_error::gdb_exception_error(enum errors, const char
1431         *, va_list)): New.
1432         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1433         Add assertion.
1434         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1435         errors)): Delete.
1436         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1437         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1438         Add assertion.
1439
1440 2019-04-08  Tom Tromey  <tom@tromey.com>
1441
1442         * valops.c (value_rtti_indirect_type): Replace throw_exception
1443         with throw.
1444         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1445         with throw.
1446         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1447         throw.
1448         * target.c (target_translate_tls_address): Replace throw_exception
1449         with throw.
1450         * stack.c (frame_apply_command_count): Replace throw_exception
1451         with throw.
1452         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1453         throw.
1454         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1455         with throw.
1456         * rs6000-tdep.c (rs6000_frame_cache)
1457         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1458         * remote.c: Replace throw_exception with throw.
1459         * record-full.c (record_full_message, record_full_wait_1)
1460         (record_full_restore): Replace throw_exception with throw.
1461         * record-btrace.c:
1462         (get_thread_current_frame_id, record_btrace_start_replaying)
1463         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1464         (cmd_record_btrace_start): Replace throw_exception with throw.
1465         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1466         throw.
1467         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1468         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1469         * linespec.c:
1470         (find_linespec_symbols): Replace throw_exception with throw.
1471         * infrun.c (displaced_step_prepare, resume): Replace
1472         throw_exception with throw.
1473         * infcmd.c (post_create_inferior): Replace throw_exception with
1474         throw.
1475         * inf-loop.c (inferior_event_handler): Replace throw_exception
1476         with throw.
1477         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1478         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1479         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1480         (get_prev_frame_always, get_frame_pc_if_available)
1481         (get_frame_address_in_block_if_available, get_frame_language):
1482         Replace throw_exception with throw.
1483         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1484         throw_exception with throw.
1485         * eval.c (fetch_subexp_value, evaluate_var_value)
1486         (evaluate_funcall, evaluate_subexp_standard): Replace
1487         throw_exception with throw.
1488         * dwarf2loc.c (call_site_find_chain)
1489         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1490         Replace throw_exception with throw.
1491         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1492         with throw.
1493         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1494         throw.
1495         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1496         * completer.c (complete_line_internal): Replace throw_exception
1497         with throw.
1498         * compile/compile-object-run.c (compile_object_run): Replace
1499         throw_exception with throw.
1500         * cli/cli-script.c (process_next_line): Replace throw_exception
1501         with throw.
1502         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1503         (btrace_enable, btrace_maint_update_pt_packets): Replace
1504         throw_exception with throw.
1505         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1506         throw_exception with throw.
1507         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1508         throw_exception with throw.
1509         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1510         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1511         * aarch64-tdep.c (aarch64_make_prologue_cache)
1512         (aarch64_make_stub_cache): Replace throw_exception with throw.
1513
1514 2019-04-08  Tom Tromey  <tom@tromey.com>
1515
1516         * common/common-exceptions.c (throw_exception): Rename from
1517         throw_exception_cxx.  Remove old copy.  Make argument const.
1518         (throw_it): Create and throw exception objects directly.
1519         * common/common-exceptions.h (throw_exception): Make argument
1520         const.
1521         (struct gdb_exception_error): Add constructor.
1522         (struct gdb_exception_quit): Add constructor.
1523
1524 2019-04-08  Tom Tromey  <tom@tromey.com>
1525
1526         * common/common-exceptions.h (exception_rethrow): Don't declare.
1527         (TRY_SJLJ): Update comment.
1528         (TRY, CATCH, END_CATCH): Remove.
1529         * common/common-exceptions.c (exception_rethrow): Remove.
1530
1531 2019-04-08  Tom Tromey  <tom@tromey.com>
1532
1533         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1534         Remove.
1535         (gdb_exception_error): Rename from
1536         gdb_exception_RETURN_MASK_ERROR.
1537         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1538         (gdb_quit_bad_alloc): Update.
1539         * aarch64-tdep.c: Update.
1540         * ada-lang.c: Update.
1541         * ada-typeprint.c: Update.
1542         * ada-valprint.c: Update.
1543         * amd64-tdep.c: Update.
1544         * arch-utils.c: Update.
1545         * break-catch-throw.c: Update.
1546         * breakpoint.c: Update.
1547         * btrace.c: Update.
1548         * c-varobj.c: Update.
1549         * cli/cli-cmds.c: Update.
1550         * cli/cli-interp.c: Update.
1551         * cli/cli-script.c: Update.
1552         * common/common-exceptions.c: Update.
1553         * common/new-op.c: Update.
1554         * common/selftest.c: Update.
1555         * compile/compile-c-symbols.c: Update.
1556         * compile/compile-cplus-symbols.c: Update.
1557         * compile/compile-object-load.c: Update.
1558         * compile/compile-object-run.c: Update.
1559         * completer.c: Update.
1560         * corelow.c: Update.
1561         * cp-abi.c: Update.
1562         * cp-support.c: Update.
1563         * cp-valprint.c: Update.
1564         * darwin-nat.c: Update.
1565         * disasm-selftests.c: Update.
1566         * dtrace-probe.c: Update.
1567         * dwarf-index-cache.c: Update.
1568         * dwarf-index-write.c: Update.
1569         * dwarf2-frame-tailcall.c: Update.
1570         * dwarf2-frame.c: Update.
1571         * dwarf2loc.c: Update.
1572         * dwarf2read.c: Update.
1573         * eval.c: Update.
1574         * event-loop.c: Update.
1575         * event-top.c: Update.
1576         * exec.c: Update.
1577         * f-valprint.c: Update.
1578         * fbsd-tdep.c: Update.
1579         * frame-unwind.c: Update.
1580         * frame.c: Update.
1581         * gdbtypes.c: Update.
1582         * gnu-v3-abi.c: Update.
1583         * guile/guile-internal.h: Update.
1584         * guile/scm-block.c: Update.
1585         * guile/scm-breakpoint.c: Update.
1586         * guile/scm-cmd.c: Update.
1587         * guile/scm-disasm.c: Update.
1588         * guile/scm-frame.c: Update.
1589         * guile/scm-lazy-string.c: Update.
1590         * guile/scm-math.c: Update.
1591         * guile/scm-param.c: Update.
1592         * guile/scm-ports.c: Update.
1593         * guile/scm-pretty-print.c: Update.
1594         * guile/scm-symbol.c: Update.
1595         * guile/scm-symtab.c: Update.
1596         * guile/scm-type.c: Update.
1597         * guile/scm-value.c: Update.
1598         * i386-linux-tdep.c: Update.
1599         * i386-tdep.c: Update.
1600         * inf-loop.c: Update.
1601         * infcall.c: Update.
1602         * infcmd.c: Update.
1603         * infrun.c: Update.
1604         * jit.c: Update.
1605         * language.c: Update.
1606         * linespec.c: Update.
1607         * linux-fork.c: Update.
1608         * linux-nat.c: Update.
1609         * linux-tdep.c: Update.
1610         * linux-thread-db.c: Update.
1611         * main.c: Update.
1612         * mi/mi-cmd-break.c: Update.
1613         * mi/mi-cmd-stack.c: Update.
1614         * mi/mi-interp.c: Update.
1615         * mi/mi-main.c: Update.
1616         * objc-lang.c: Update.
1617         * p-valprint.c: Update.
1618         * parse.c: Update.
1619         * ppc-linux-tdep.c: Update.
1620         * printcmd.c: Update.
1621         * python/py-arch.c: Update.
1622         * python/py-breakpoint.c: Update.
1623         * python/py-cmd.c: Update.
1624         * python/py-finishbreakpoint.c: Update.
1625         * python/py-frame.c: Update.
1626         * python/py-framefilter.c: Update.
1627         * python/py-gdb-readline.c: Update.
1628         * python/py-inferior.c: Update.
1629         * python/py-infthread.c: Update.
1630         * python/py-lazy-string.c: Update.
1631         * python/py-linetable.c: Update.
1632         * python/py-objfile.c: Update.
1633         * python/py-param.c: Update.
1634         * python/py-prettyprint.c: Update.
1635         * python/py-progspace.c: Update.
1636         * python/py-record-btrace.c: Update.
1637         * python/py-record.c: Update.
1638         * python/py-symbol.c: Update.
1639         * python/py-type.c: Update.
1640         * python/py-unwind.c: Update.
1641         * python/py-utils.c: Update.
1642         * python/py-value.c: Update.
1643         * python/python.c: Update.
1644         * record-btrace.c: Update.
1645         * record-full.c: Update.
1646         * remote-fileio.c: Update.
1647         * remote.c: Update.
1648         * riscv-tdep.c: Update.
1649         * rs6000-aix-tdep.c: Update.
1650         * rs6000-tdep.c: Update.
1651         * rust-exp.y: Update.
1652         * rust-lang.c: Update.
1653         * s390-tdep.c: Update.
1654         * selftest-arch.c: Update.
1655         * solib-dsbt.c: Update.
1656         * solib-frv.c: Update.
1657         * solib-spu.c: Update.
1658         * solib-svr4.c: Update.
1659         * solib.c: Update.
1660         * sparc64-linux-tdep.c: Update.
1661         * stack.c: Update.
1662         * symfile-mem.c: Update.
1663         * symmisc.c: Update.
1664         * target.c: Update.
1665         * thread.c: Update.
1666         * top.c: Update.
1667         * tracefile-tfile.c: Update.
1668         * tui/tui.c: Update.
1669         * typeprint.c: Update.
1670         * unittests/cli-utils-selftests.c: Update.
1671         * unittests/parse-connection-spec-selftests.c: Update.
1672         * valops.c: Update.
1673         * valprint.c: Update.
1674         * value.c: Update.
1675         * varobj.c: Update.
1676         * windows-nat.c: Update.
1677         * x86-linux-nat.c: Update.
1678         * xml-support.c: Update.
1679
1680 2019-04-08  Tom Tromey  <tom@tromey.com>
1681
1682         * xml-support.c: Use C++ exception handling.
1683         * x86-linux-nat.c: Use C++ exception handling.
1684         * windows-nat.c: Use C++ exception handling.
1685         * varobj.c: Use C++ exception handling.
1686         * value.c: Use C++ exception handling.
1687         * valprint.c: Use C++ exception handling.
1688         * valops.c: Use C++ exception handling.
1689         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1690         handling.
1691         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1692         * typeprint.c: Use C++ exception handling.
1693         * tui/tui.c: Use C++ exception handling.
1694         * tracefile-tfile.c: Use C++ exception handling.
1695         * top.c: Use C++ exception handling.
1696         * thread.c: Use C++ exception handling.
1697         * target.c: Use C++ exception handling.
1698         * symmisc.c: Use C++ exception handling.
1699         * symfile-mem.c: Use C++ exception handling.
1700         * stack.c: Use C++ exception handling.
1701         * sparc64-linux-tdep.c: Use C++ exception handling.
1702         * solib.c: Use C++ exception handling.
1703         * solib-svr4.c: Use C++ exception handling.
1704         * solib-spu.c: Use C++ exception handling.
1705         * solib-frv.c: Use C++ exception handling.
1706         * solib-dsbt.c: Use C++ exception handling.
1707         * selftest-arch.c: Use C++ exception handling.
1708         * s390-tdep.c: Use C++ exception handling.
1709         * rust-lang.c: Use C++ exception handling.
1710         * rust-exp.y: Use C++ exception handling.
1711         * rs6000-tdep.c: Use C++ exception handling.
1712         * rs6000-aix-tdep.c: Use C++ exception handling.
1713         * riscv-tdep.c: Use C++ exception handling.
1714         * remote.c: Use C++ exception handling.
1715         * remote-fileio.c: Use C++ exception handling.
1716         * record-full.c: Use C++ exception handling.
1717         * record-btrace.c: Use C++ exception handling.
1718         * python/python.c: Use C++ exception handling.
1719         * python/py-value.c: Use C++ exception handling.
1720         * python/py-utils.c: Use C++ exception handling.
1721         * python/py-unwind.c: Use C++ exception handling.
1722         * python/py-type.c: Use C++ exception handling.
1723         * python/py-symbol.c: Use C++ exception handling.
1724         * python/py-record.c: Use C++ exception handling.
1725         * python/py-record-btrace.c: Use C++ exception handling.
1726         * python/py-progspace.c: Use C++ exception handling.
1727         * python/py-prettyprint.c: Use C++ exception handling.
1728         * python/py-param.c: Use C++ exception handling.
1729         * python/py-objfile.c: Use C++ exception handling.
1730         * python/py-linetable.c: Use C++ exception handling.
1731         * python/py-lazy-string.c: Use C++ exception handling.
1732         * python/py-infthread.c: Use C++ exception handling.
1733         * python/py-inferior.c: Use C++ exception handling.
1734         * python/py-gdb-readline.c: Use C++ exception handling.
1735         * python/py-framefilter.c: Use C++ exception handling.
1736         * python/py-frame.c: Use C++ exception handling.
1737         * python/py-finishbreakpoint.c: Use C++ exception handling.
1738         * python/py-cmd.c: Use C++ exception handling.
1739         * python/py-breakpoint.c: Use C++ exception handling.
1740         * python/py-arch.c: Use C++ exception handling.
1741         * printcmd.c: Use C++ exception handling.
1742         * ppc-linux-tdep.c: Use C++ exception handling.
1743         * parse.c: Use C++ exception handling.
1744         * p-valprint.c: Use C++ exception handling.
1745         * objc-lang.c: Use C++ exception handling.
1746         * mi/mi-main.c: Use C++ exception handling.
1747         * mi/mi-interp.c: Use C++ exception handling.
1748         * mi/mi-cmd-stack.c: Use C++ exception handling.
1749         * mi/mi-cmd-break.c: Use C++ exception handling.
1750         * main.c: Use C++ exception handling.
1751         * linux-thread-db.c: Use C++ exception handling.
1752         * linux-tdep.c: Use C++ exception handling.
1753         * linux-nat.c: Use C++ exception handling.
1754         * linux-fork.c: Use C++ exception handling.
1755         * linespec.c: Use C++ exception handling.
1756         * language.c: Use C++ exception handling.
1757         * jit.c: Use C++ exception handling.
1758         * infrun.c: Use C++ exception handling.
1759         * infcmd.c: Use C++ exception handling.
1760         * infcall.c: Use C++ exception handling.
1761         * inf-loop.c: Use C++ exception handling.
1762         * i386-tdep.c: Use C++ exception handling.
1763         * i386-linux-tdep.c: Use C++ exception handling.
1764         * guile/scm-value.c: Use C++ exception handling.
1765         * guile/scm-type.c: Use C++ exception handling.
1766         * guile/scm-symtab.c: Use C++ exception handling.
1767         * guile/scm-symbol.c: Use C++ exception handling.
1768         * guile/scm-pretty-print.c: Use C++ exception handling.
1769         * guile/scm-ports.c: Use C++ exception handling.
1770         * guile/scm-param.c: Use C++ exception handling.
1771         * guile/scm-math.c: Use C++ exception handling.
1772         * guile/scm-lazy-string.c: Use C++ exception handling.
1773         * guile/scm-frame.c: Use C++ exception handling.
1774         * guile/scm-disasm.c: Use C++ exception handling.
1775         * guile/scm-cmd.c: Use C++ exception handling.
1776         * guile/scm-breakpoint.c: Use C++ exception handling.
1777         * guile/scm-block.c: Use C++ exception handling.
1778         * guile/guile-internal.h: Use C++ exception handling.
1779         * gnu-v3-abi.c: Use C++ exception handling.
1780         * gdbtypes.c: Use C++ exception handling.
1781         * frame.c: Use C++ exception handling.
1782         * frame-unwind.c: Use C++ exception handling.
1783         * fbsd-tdep.c: Use C++ exception handling.
1784         * f-valprint.c: Use C++ exception handling.
1785         * exec.c: Use C++ exception handling.
1786         * event-top.c: Use C++ exception handling.
1787         * event-loop.c: Use C++ exception handling.
1788         * eval.c: Use C++ exception handling.
1789         * dwarf2read.c: Use C++ exception handling.
1790         * dwarf2loc.c: Use C++ exception handling.
1791         * dwarf2-frame.c: Use C++ exception handling.
1792         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1793         * dwarf-index-write.c: Use C++ exception handling.
1794         * dwarf-index-cache.c: Use C++ exception handling.
1795         * dtrace-probe.c: Use C++ exception handling.
1796         * disasm-selftests.c: Use C++ exception handling.
1797         * darwin-nat.c: Use C++ exception handling.
1798         * cp-valprint.c: Use C++ exception handling.
1799         * cp-support.c: Use C++ exception handling.
1800         * cp-abi.c: Use C++ exception handling.
1801         * corelow.c: Use C++ exception handling.
1802         * completer.c: Use C++ exception handling.
1803         * compile/compile-object-run.c: Use C++ exception handling.
1804         * compile/compile-object-load.c: Use C++ exception handling.
1805         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1806         * compile/compile-c-symbols.c: Use C++ exception handling.
1807         * common/selftest.c: Use C++ exception handling.
1808         * common/new-op.c: Use C++ exception handling.
1809         * cli/cli-script.c: Use C++ exception handling.
1810         * cli/cli-interp.c: Use C++ exception handling.
1811         * cli/cli-cmds.c: Use C++ exception handling.
1812         * c-varobj.c: Use C++ exception handling.
1813         * btrace.c: Use C++ exception handling.
1814         * breakpoint.c: Use C++ exception handling.
1815         * break-catch-throw.c: Use C++ exception handling.
1816         * arch-utils.c: Use C++ exception handling.
1817         * amd64-tdep.c: Use C++ exception handling.
1818         * ada-valprint.c: Use C++ exception handling.
1819         * ada-typeprint.c: Use C++ exception handling.
1820         * ada-lang.c: Use C++ exception handling.
1821         * aarch64-tdep.c: Use C++ exception handling.
1822
1823 2019-04-08  Tom Tromey  <tom@tromey.com>
1824
1825         * xml-support.c (gdb_xml_parser::parse): Update.
1826         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1827         * value.c (show_convenience): Update.
1828         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1829         (test_parse_flags_qcs): Update.
1830         * thread.c (thr_try_catch_cmd): Update.
1831         * target.c (target_translate_tls_address): Update.
1832         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1833         (info_frame_command_core, frame_apply_command_count): Update.
1834         * rust-exp.y (rust_lex_exception_test): Update.
1835         * riscv-tdep.c (riscv_print_one_register_info): Update.
1836         * remote.c (remote_target::enable_btrace): Update.
1837         * record-btrace.c (record_btrace_enable_warn): Update.
1838         * python/py-utils.c (gdbpy_convert_exception): Update.
1839         * printcmd.c (do_one_display, print_variable_and_value): Update.
1840         * mi/mi-main.c (mi_print_exception): Update.
1841         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1842         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1843         * linux-nat.c (linux_nat_target::attach): Update.
1844         * linux-fork.c (class scoped_switch_fork_info): Update.
1845         * infrun.c (displaced_step_prepare): Update.
1846         * infcall.c (call_function_by_hand_dummy): Update.
1847         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1848         * gnu-v3-abi.c (print_one_vtable): Update.
1849         * frame.c (get_prev_frame_always): Update.
1850         * f-valprint.c (info_common_command_for_block): Update.
1851         * exec.c (try_open_exec_file): Update.
1852         * exceptions.c (print_exception, exception_print)
1853         (exception_fprintf, exception_print_same): Update.
1854         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1855         * dwarf-index-cache.c (index_cache::store)
1856         (index_cache::lookup_gdb_index): Update.
1857         * darwin-nat.c (maybe_cache_shell): Update.
1858         * cp-valprint.c (cp_print_value_fields): Update.
1859         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1860         (gcc_cplus_symbol_address): Update.
1861         * compile/compile-c-symbols.c (gcc_convert_symbol)
1862         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1863         * common/selftest.c: Update.
1864         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1865         a std::string.
1866         (exception_try_scope_entry, exception_try_scope_exit): Don't
1867         declare.
1868         (struct exception_try_scope): Remove.
1869         (TRY): Don't use exception_try_scope.
1870         (struct gdb_exception): Add constructor, operator=.
1871         <what>: New method.
1872         (struct gdb_exception_RETURN_MASK_ALL)
1873         (struct gdb_exception_RETURN_MASK_ERROR)
1874         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1875         (struct gdb_quit_bad_alloc): Update.
1876         * common/common-exceptions.c (exception_none): Change
1877         initializer.
1878         (struct catcher) <state, exception>: Initialize inline.
1879         <prev>: Remove member.
1880         (current_catcher): Remove.
1881         (catchers): New global.
1882         (exceptions_state_mc_init): Simplify.
1883         (catcher_pop): Remove.
1884         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1885         (try_scope_depth, exception_try_scope_entry)
1886         (exception_try_scope_exit): Remove.
1887         (throw_exception_sjlj): Update.
1888         (exception_messages, exception_messages_size): Remove.
1889         (throw_it): Simplify.
1890         (gdb_exception_sliced_copy): Remove.
1891         (throw_exception_cxx): Update.
1892         * cli/cli-script.c (script_from_file): Update.
1893         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1894         Update.
1895         * ada-valprint.c (ada_val_print): Update.
1896         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1897         (create_excep_cond_exprs): Update.
1898
1899 2019-04-08  Tom Tromey  <tom@tromey.com>
1900
1901         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1902         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1903         (TRY, CATCH, END_CATCH): Remove some definitions.
1904         * common/common-exceptions.c: Don't use GDB_XCPT.
1905         (catcher_list_size): Remove.
1906         (throw_exception, throw_it): Simplify.
1907
1908 2019-04-05  Tom Tromey  <tom@tromey.com>
1909
1910         Revert the header-sorting patch.
1911         * ft32-tdep.c: Revert.
1912         * frv-tdep.c: Revert.
1913         * frv-linux-tdep.c: Revert.
1914         * frame.c: Revert.
1915         * frame-unwind.c: Revert.
1916         * frame-base.c: Revert.
1917         * fork-child.c: Revert.
1918         * findvar.c: Revert.
1919         * findcmd.c: Revert.
1920         * filesystem.c: Revert.
1921         * filename-seen-cache.h: Revert.
1922         * filename-seen-cache.c: Revert.
1923         * fbsd-tdep.c: Revert.
1924         * fbsd-nat.h: Revert.
1925         * fbsd-nat.c: Revert.
1926         * f-valprint.c: Revert.
1927         * f-typeprint.c: Revert.
1928         * f-lang.c: Revert.
1929         * extension.h: Revert.
1930         * extension.c: Revert.
1931         * extension-priv.h: Revert.
1932         * expprint.c: Revert.
1933         * exec.h: Revert.
1934         * exec.c: Revert.
1935         * exceptions.c: Revert.
1936         * event-top.c: Revert.
1937         * event-loop.c: Revert.
1938         * eval.c: Revert.
1939         * elfread.c: Revert.
1940         * dwarf2read.h: Revert.
1941         * dwarf2read.c: Revert.
1942         * dwarf2loc.c: Revert.
1943         * dwarf2expr.h: Revert.
1944         * dwarf2expr.c: Revert.
1945         * dwarf2-frame.c: Revert.
1946         * dwarf2-frame-tailcall.c: Revert.
1947         * dwarf-index-write.h: Revert.
1948         * dwarf-index-write.c: Revert.
1949         * dwarf-index-common.c: Revert.
1950         * dwarf-index-cache.h: Revert.
1951         * dwarf-index-cache.c: Revert.
1952         * dummy-frame.c: Revert.
1953         * dtrace-probe.c: Revert.
1954         * disasm.h: Revert.
1955         * disasm.c: Revert.
1956         * disasm-selftests.c: Revert.
1957         * dictionary.c: Revert.
1958         * dicos-tdep.c: Revert.
1959         * demangle.c: Revert.
1960         * dcache.h: Revert.
1961         * dcache.c: Revert.
1962         * darwin-nat.h: Revert.
1963         * darwin-nat.c: Revert.
1964         * darwin-nat-info.c: Revert.
1965         * d-valprint.c: Revert.
1966         * d-namespace.c: Revert.
1967         * d-lang.c: Revert.
1968         * ctf.c: Revert.
1969         * csky-tdep.c: Revert.
1970         * csky-linux-tdep.c: Revert.
1971         * cris-tdep.c: Revert.
1972         * cris-linux-tdep.c: Revert.
1973         * cp-valprint.c: Revert.
1974         * cp-support.c: Revert.
1975         * cp-namespace.c: Revert.
1976         * cp-abi.c: Revert.
1977         * corelow.c: Revert.
1978         * corefile.c: Revert.
1979         * continuations.c: Revert.
1980         * completer.h: Revert.
1981         * completer.c: Revert.
1982         * complaints.c: Revert.
1983         * coffread.c: Revert.
1984         * coff-pe-read.c: Revert.
1985         * cli-out.h: Revert.
1986         * cli-out.c: Revert.
1987         * charset.c: Revert.
1988         * c-varobj.c: Revert.
1989         * c-valprint.c: Revert.
1990         * c-typeprint.c: Revert.
1991         * c-lang.c: Revert.
1992         * buildsym.c: Revert.
1993         * buildsym-legacy.c: Revert.
1994         * build-id.h: Revert.
1995         * build-id.c: Revert.
1996         * btrace.c: Revert.
1997         * bsd-uthread.c: Revert.
1998         * breakpoint.h: Revert.
1999         * breakpoint.c: Revert.
2000         * break-catch-throw.c: Revert.
2001         * break-catch-syscall.c: Revert.
2002         * break-catch-sig.c: Revert.
2003         * blockframe.c: Revert.
2004         * block.c: Revert.
2005         * bfin-tdep.c: Revert.
2006         * bfin-linux-tdep.c: Revert.
2007         * bfd-target.c: Revert.
2008         * bcache.c: Revert.
2009         * ax-general.c: Revert.
2010         * ax-gdb.h: Revert.
2011         * ax-gdb.c: Revert.
2012         * avr-tdep.c: Revert.
2013         * auxv.c: Revert.
2014         * auto-load.c: Revert.
2015         * arm-wince-tdep.c: Revert.
2016         * arm-tdep.c: Revert.
2017         * arm-symbian-tdep.c: Revert.
2018         * arm-pikeos-tdep.c: Revert.
2019         * arm-obsd-tdep.c: Revert.
2020         * arm-nbsd-tdep.c: Revert.
2021         * arm-nbsd-nat.c: Revert.
2022         * arm-linux-tdep.c: Revert.
2023         * arm-linux-nat.c: Revert.
2024         * arm-fbsd-tdep.c: Revert.
2025         * arm-fbsd-nat.c: Revert.
2026         * arm-bsd-tdep.c: Revert.
2027         * arch-utils.c: Revert.
2028         * arc-tdep.c: Revert.
2029         * arc-newlib-tdep.c: Revert.
2030         * annotate.h: Revert.
2031         * annotate.c: Revert.
2032         * amd64-windows-tdep.c: Revert.
2033         * amd64-windows-nat.c: Revert.
2034         * amd64-tdep.c: Revert.
2035         * amd64-sol2-tdep.c: Revert.
2036         * amd64-obsd-tdep.c: Revert.
2037         * amd64-obsd-nat.c: Revert.
2038         * amd64-nbsd-tdep.c: Revert.
2039         * amd64-nbsd-nat.c: Revert.
2040         * amd64-nat.c: Revert.
2041         * amd64-linux-tdep.c: Revert.
2042         * amd64-linux-nat.c: Revert.
2043         * amd64-fbsd-tdep.c: Revert.
2044         * amd64-fbsd-nat.c: Revert.
2045         * amd64-dicos-tdep.c: Revert.
2046         * amd64-darwin-tdep.c: Revert.
2047         * amd64-bsd-nat.c: Revert.
2048         * alpha-tdep.c: Revert.
2049         * alpha-obsd-tdep.c: Revert.
2050         * alpha-nbsd-tdep.c: Revert.
2051         * alpha-mdebug-tdep.c: Revert.
2052         * alpha-linux-tdep.c: Revert.
2053         * alpha-linux-nat.c: Revert.
2054         * alpha-bsd-tdep.c: Revert.
2055         * alpha-bsd-nat.c: Revert.
2056         * aix-thread.c: Revert.
2057         * agent.c: Revert.
2058         * addrmap.c: Revert.
2059         * ada-varobj.c: Revert.
2060         * ada-valprint.c: Revert.
2061         * ada-typeprint.c: Revert.
2062         * ada-tasks.c: Revert.
2063         * ada-lang.c: Revert.
2064         * aarch64-tdep.c: Revert.
2065         * aarch64-ravenscar-thread.c: Revert.
2066         * aarch64-newlib-tdep.c: Revert.
2067         * aarch64-linux-tdep.c: Revert.
2068         * aarch64-linux-nat.c: Revert.
2069         * aarch64-fbsd-tdep.c: Revert.
2070         * aarch64-fbsd-nat.c: Revert.
2071         * aarch32-linux-nat.c: Revert.
2072
2073 2019-04-05  Tom Tromey  <tom@tromey.com>
2074
2075         * ft32-tdep.c: Sort headers.
2076         * frv-tdep.c: Sort headers.
2077         * frv-linux-tdep.c: Sort headers.
2078         * frame.c: Sort headers.
2079         * frame-unwind.c: Sort headers.
2080         * frame-base.c: Sort headers.
2081         * fork-child.c: Sort headers.
2082         * findvar.c: Sort headers.
2083         * findcmd.c: Sort headers.
2084         * filesystem.c: Sort headers.
2085         * filename-seen-cache.h: Sort headers.
2086         * filename-seen-cache.c: Sort headers.
2087         * fbsd-tdep.c: Sort headers.
2088         * fbsd-nat.h: Sort headers.
2089         * fbsd-nat.c: Sort headers.
2090         * f-valprint.c: Sort headers.
2091         * f-typeprint.c: Sort headers.
2092         * f-lang.c: Sort headers.
2093         * extension.h: Sort headers.
2094         * extension.c: Sort headers.
2095         * extension-priv.h: Sort headers.
2096         * expprint.c: Sort headers.
2097         * exec.h: Sort headers.
2098         * exec.c: Sort headers.
2099         * exceptions.c: Sort headers.
2100         * event-top.c: Sort headers.
2101         * event-loop.c: Sort headers.
2102         * eval.c: Sort headers.
2103         * elfread.c: Sort headers.
2104         * dwarf2read.h: Sort headers.
2105         * dwarf2read.c: Sort headers.
2106         * dwarf2loc.c: Sort headers.
2107         * dwarf2expr.h: Sort headers.
2108         * dwarf2expr.c: Sort headers.
2109         * dwarf2-frame.c: Sort headers.
2110         * dwarf2-frame-tailcall.c: Sort headers.
2111         * dwarf-index-write.h: Sort headers.
2112         * dwarf-index-write.c: Sort headers.
2113         * dwarf-index-common.c: Sort headers.
2114         * dwarf-index-cache.h: Sort headers.
2115         * dwarf-index-cache.c: Sort headers.
2116         * dummy-frame.c: Sort headers.
2117         * dtrace-probe.c: Sort headers.
2118         * disasm.h: Sort headers.
2119         * disasm.c: Sort headers.
2120         * disasm-selftests.c: Sort headers.
2121         * dictionary.c: Sort headers.
2122         * dicos-tdep.c: Sort headers.
2123         * demangle.c: Sort headers.
2124         * dcache.h: Sort headers.
2125         * dcache.c: Sort headers.
2126         * darwin-nat.h: Sort headers.
2127         * darwin-nat.c: Sort headers.
2128         * darwin-nat-info.c: Sort headers.
2129         * d-valprint.c: Sort headers.
2130         * d-namespace.c: Sort headers.
2131         * d-lang.c: Sort headers.
2132         * ctf.c: Sort headers.
2133         * csky-tdep.c: Sort headers.
2134         * csky-linux-tdep.c: Sort headers.
2135         * cris-tdep.c: Sort headers.
2136         * cris-linux-tdep.c: Sort headers.
2137         * cp-valprint.c: Sort headers.
2138         * cp-support.c: Sort headers.
2139         * cp-namespace.c: Sort headers.
2140         * cp-abi.c: Sort headers.
2141         * corelow.c: Sort headers.
2142         * corefile.c: Sort headers.
2143         * continuations.c: Sort headers.
2144         * completer.h: Sort headers.
2145         * completer.c: Sort headers.
2146         * complaints.c: Sort headers.
2147         * coffread.c: Sort headers.
2148         * coff-pe-read.c: Sort headers.
2149         * cli-out.h: Sort headers.
2150         * cli-out.c: Sort headers.
2151         * charset.c: Sort headers.
2152         * c-varobj.c: Sort headers.
2153         * c-valprint.c: Sort headers.
2154         * c-typeprint.c: Sort headers.
2155         * c-lang.c: Sort headers.
2156         * buildsym.c: Sort headers.
2157         * buildsym-legacy.c: Sort headers.
2158         * build-id.h: Sort headers.
2159         * build-id.c: Sort headers.
2160         * btrace.c: Sort headers.
2161         * bsd-uthread.c: Sort headers.
2162         * breakpoint.h: Sort headers.
2163         * breakpoint.c: Sort headers.
2164         * break-catch-throw.c: Sort headers.
2165         * break-catch-syscall.c: Sort headers.
2166         * break-catch-sig.c: Sort headers.
2167         * blockframe.c: Sort headers.
2168         * block.c: Sort headers.
2169         * bfin-tdep.c: Sort headers.
2170         * bfin-linux-tdep.c: Sort headers.
2171         * bfd-target.c: Sort headers.
2172         * bcache.c: Sort headers.
2173         * ax-general.c: Sort headers.
2174         * ax-gdb.h: Sort headers.
2175         * ax-gdb.c: Sort headers.
2176         * avr-tdep.c: Sort headers.
2177         * auxv.c: Sort headers.
2178         * auto-load.c: Sort headers.
2179         * arm-wince-tdep.c: Sort headers.
2180         * arm-tdep.c: Sort headers.
2181         * arm-symbian-tdep.c: Sort headers.
2182         * arm-pikeos-tdep.c: Sort headers.
2183         * arm-obsd-tdep.c: Sort headers.
2184         * arm-nbsd-tdep.c: Sort headers.
2185         * arm-nbsd-nat.c: Sort headers.
2186         * arm-linux-tdep.c: Sort headers.
2187         * arm-linux-nat.c: Sort headers.
2188         * arm-fbsd-tdep.c: Sort headers.
2189         * arm-fbsd-nat.c: Sort headers.
2190         * arm-bsd-tdep.c: Sort headers.
2191         * arch-utils.c: Sort headers.
2192         * arc-tdep.c: Sort headers.
2193         * arc-newlib-tdep.c: Sort headers.
2194         * annotate.h: Sort headers.
2195         * annotate.c: Sort headers.
2196         * amd64-windows-tdep.c: Sort headers.
2197         * amd64-windows-nat.c: Sort headers.
2198         * amd64-tdep.c: Sort headers.
2199         * amd64-sol2-tdep.c: Sort headers.
2200         * amd64-obsd-tdep.c: Sort headers.
2201         * amd64-obsd-nat.c: Sort headers.
2202         * amd64-nbsd-tdep.c: Sort headers.
2203         * amd64-nbsd-nat.c: Sort headers.
2204         * amd64-nat.c: Sort headers.
2205         * amd64-linux-tdep.c: Sort headers.
2206         * amd64-linux-nat.c: Sort headers.
2207         * amd64-fbsd-tdep.c: Sort headers.
2208         * amd64-fbsd-nat.c: Sort headers.
2209         * amd64-dicos-tdep.c: Sort headers.
2210         * amd64-darwin-tdep.c: Sort headers.
2211         * amd64-bsd-nat.c: Sort headers.
2212         * alpha-tdep.c: Sort headers.
2213         * alpha-obsd-tdep.c: Sort headers.
2214         * alpha-nbsd-tdep.c: Sort headers.
2215         * alpha-mdebug-tdep.c: Sort headers.
2216         * alpha-linux-tdep.c: Sort headers.
2217         * alpha-linux-nat.c: Sort headers.
2218         * alpha-bsd-tdep.c: Sort headers.
2219         * alpha-bsd-nat.c: Sort headers.
2220         * aix-thread.c: Sort headers.
2221         * agent.c: Sort headers.
2222         * addrmap.c: Sort headers.
2223         * ada-varobj.c: Sort headers.
2224         * ada-valprint.c: Sort headers.
2225         * ada-typeprint.c: Sort headers.
2226         * ada-tasks.c: Sort headers.
2227         * ada-lang.c: Sort headers.
2228         * aarch64-tdep.c: Sort headers.
2229         * aarch64-ravenscar-thread.c: Sort headers.
2230         * aarch64-newlib-tdep.c: Sort headers.
2231         * aarch64-linux-tdep.c: Sort headers.
2232         * aarch64-linux-nat.c: Sort headers.
2233         * aarch64-fbsd-tdep.c: Sort headers.
2234         * aarch64-fbsd-nat.c: Sort headers.
2235         * aarch32-linux-nat.c: Sort headers.
2236
2237 2019-04-04  Tom Tromey  <tom@tromey.com>
2238
2239         * varobj.c (varobj_create): Update.
2240         * rust-exp.y (struct rust_parser) <update_innermost_block,
2241         lookup_symbol>: New methods.
2242         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2243         Rename.
2244         (rust_parser::rust_lookup_type)
2245         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2246         * printcmd.c (display_command, do_one_display): Update.
2247         * parser-defs.h (struct parser_state) <parser_state>: Add
2248         "tracker" parameter.
2249         (block_tracker): New member.
2250         (class innermost_block_tracker) <innermost_block_tracker>: Add
2251         "types" parameter.
2252         <reset>: Remove method.
2253         (innermost_block): Don't declare.
2254         (null_post_parser): Update.
2255         * parse.c (innermost_block): Remove global.
2256         (write_dollar_variable): Update.
2257         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2258         Remove "tracker_types" parameter.
2259         (parse_expression): Add "tracker" parameter.
2260         (parse_expression_for_completion): Update.
2261         (null_post_parser): Add "tracker" parameter.
2262         * p-exp.y: Update rules.
2263         * m2-exp.y: Update rules.
2264         * language.h (struct language_defn) <la_post_parser>: Add
2265         "tracker" parameter.
2266         * go-exp.y: Update rules.
2267         * f-exp.y: Update rules.
2268         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2269         parameter.
2270         * d-exp.y: Update rules.
2271         * c-exp.y: Update rules.
2272         * breakpoint.c (set_breakpoint_condition): Create an
2273         innermost_block_tracker.
2274         (watch_command_1): Likewise.
2275         * ada-lang.c (resolve): Add "tracker" parameter.
2276         (resolve_subexp): Likewise.
2277         * ada-exp.y (write_var_from_sym): Update.
2278
2279 2019-04-04  Tom Tromey  <tom@tromey.com>
2280
2281         * type-stack.h: New file.
2282         * type-stack.c: New file.
2283         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2284         type-stack.h.
2285         (insert_into_type_stack, insert_type, push_type, push_type_int)
2286         (insert_type_address_space, pop_type, pop_type_int)
2287         (pop_typelist, pop_type_stack, append_type_stack)
2288         (push_type_stack, get_type_stack, push_typelist)
2289         (follow_type_instance_flags, follow_types): Don't declare.
2290         * parse.c (type_stack): Remove global.
2291         (parse_exp_in_context): Update.
2292         (insert_into_type_stack, insert_type, push_type, push_type_int)
2293         (insert_type_address_space, pop_type, pop_type_int)
2294         (pop_typelist, pop_type_stack, append_type_stack)
2295         (push_type_stack, get_type_stack, push_typelist)
2296         (follow_type_instance_flags, follow_types): Remove (moved to
2297         type-stack.c).
2298         * f-exp.y (type_stack): New global.
2299         Update rules.
2300         (push_kind_type, f_parse): Update.
2301         * d-exp.y (type_stack): New global.
2302         Update rules.
2303         (d_parse): Update.
2304         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2305         Update rules.
2306         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2307         (HFILES_NO_SRCDIR): Add type-stack.h.
2308
2309 2019-04-04  Tom Tromey  <tom@tromey.com>
2310
2311         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2312         (rust_parser::convert_ast_to_expression, rust_parse)
2313         (rust_lex_test_completion, rust_lex_tests): Update.
2314         * parser-defs.h (struct expr_completion_state): New.
2315         (struct parser_state) <parser_state>: Add completion parameter.
2316         <mark_struct_expression, mark_completion_tag>: New methods.
2317         <parse_completion, m_completion_state>: New members.
2318         (prefixify_expression, null_post_parser): Update.
2319         (mark_struct_expression, mark_completion_tag): Don't declare.
2320         * parse.c (parse_completion, expout_last_struct)
2321         (expout_tag_completion_type, expout_completion_name): Remove
2322         globals.
2323         (parser_state::mark_struct_expression)
2324         (parser_state::mark_completion_tag): Now methods.
2325         (prefixify_expression): Add last_struct parameter.
2326         (prefixify_subexp): Likewise.
2327         (parse_exp_1): Update.
2328         (parse_exp_in_context): Add cstate parameter.  Update.
2329         (parse_expression_for_completion): Create an
2330         expr_completion_state.
2331         (null_post_parser): Add "completion" parameter.
2332         * p-exp.y: Update rules.
2333         (yylex): Update.
2334         * language.h (struct language_defn) <la_post_parser>: Add
2335         "completing" parameter.
2336         * go-exp.y: Update rules.
2337         (lex_one_token): Update.
2338         * expression.h (parse_completion): Don't declare.
2339         * d-exp.y: Update rules.
2340         (lex_one_token): Update rules.
2341         * c-exp.y: Update rules.
2342         (lex_one_token): Update.
2343         * ada-lang.c (resolve): Add "parse_completion" parameter.
2344         (resolve_subexp): Likewise.
2345         (ada_resolve_function): Likewise.
2346
2347 2019-04-04  Tom Tromey  <tom@tromey.com>
2348
2349         * parser-defs.h (struct parser_state) <start_arglist,
2350         end_arglist>: New methods.
2351         <arglist_len, m_funcall_chain>: New members.
2352         (arglist_len, start_arglist, end_arglist): Don't declare.
2353         * parse.c (arglist_len, funcall_chain): Remove global.
2354         (start_arglist, end_arglist): Remove functions.
2355         (parse_exp_in_context): Update.
2356         * p-exp.y: Update rules.
2357         * m2-exp.y: Update rules.
2358         * go-exp.y: Update rules.
2359         * f-exp.y: Update rules.
2360         * d-exp.y: Update rules.
2361         * c-exp.y: Update rules.
2362
2363 2019-04-04  Tom Tromey  <tom@tromey.com>
2364
2365         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2366         lex_operator, push_back>: New methods.
2367         Update all rules.
2368         (rust_parser::lex_hex, lex_escape): Rename and update.
2369         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2370         (rust_parser::lex_operator): Rename and update.
2371         (rust_parser::lex_number, rustyylex, rustyyerror)
2372         (rust_lex_test_init, rust_lex_test_sequence)
2373         (rust_lex_test_push_back, rust_lex_tests): Update.
2374         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2375         parameter.
2376         <lexptr, prev_lexptr>: New members.
2377         (lexptr, prev_lexptr): Don't declare.
2378         * parse.c (lexptr, prev_lexptr): Remove globals.
2379         (parse_exp_in_context): Update.
2380         * p-exp.y (yylex, yyerror): Update.
2381         * m2-exp.y (parse_number, yylex, yyerror): Update.
2382         * go-exp.y (lex_one_token, yyerror): Update.
2383         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2384         * d-exp.y (lex_one_token, yyerror): Update.
2385         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2386         (lex_one_token, yyerror): Update.
2387         * ada-lex.l (YY_INPUT): Update.
2388         (rewind_to_char): Update.
2389         * ada-exp.y (yyerror): Update.
2390
2391 2019-04-04  Tom Tromey  <tom@tromey.com>
2392
2393         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2394         * parser-defs.h (struct parser_state) <parser_state>: Add new
2395         parameter.
2396         <comma_terminates>: New member.
2397         (comma_terminates): Don't declare global.
2398         * parse.c (comma_terminates): Remove global.
2399         (parse_exp_in_context): Update.
2400         * p-exp.y (yylex): Update.
2401         * m2-exp.y (yylex): Update.
2402         * go-exp.y (lex_one_token): Update.
2403         * f-exp.y (yylex): Update.
2404         * d-exp.y (lex_one_token): Update.
2405         * c-exp.y (lex_one_token): Update.
2406         * ada-lex.l: Update.
2407
2408 2019-04-04  Tom Tromey  <tom@tromey.com>
2409
2410         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2411         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2412         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2413         * parser-defs.h (paren_depth): Don't declare.
2414         * parse.c (paren_depth): Remove global.
2415         (parse_exp_in_context): Update.
2416         * p-exp.y (paren_depth): New global.
2417         (pascal_parse): Initialize it.
2418         * m2-exp.y (paren_depth): New global.
2419         (m2_parse): Initialize it.
2420         * go-exp.y (paren_depth): New global.
2421         (go_parse): Initialize it.
2422         * f-exp.y (paren_depth): New global.
2423         (f_parse): Initialize it.
2424         * d-exp.y (paren_depth): New global.
2425         (d_parse): Initialize it.
2426         * c-exp.y (paren_depth): New global.
2427         (c_parse): Initialize it.
2428         * ada-lex.l (paren_depth): New global.
2429         (lexer_init): Initialize it.
2430
2431 2019-04-04  Tom Tromey  <tom@tromey.com>
2432
2433         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2434         (rust_parser::convert_ast_to_type)
2435         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2436         * parser-defs.h (struct parser_state) <parser_state>: Add
2437         parameters.  Initialize new members.
2438         <expression_context_block, expression_context_pc>: New members.
2439         * parse.c (expression_context_block, expression_context_pc):
2440         Remove globals.
2441         (parse_exp_in_context): Update.
2442         * p-exp.y: Update all rules.
2443         (yylex): Update.
2444         * m2-exp.y: Update all rules.
2445         (yylex): Update.
2446         * go-exp.y (yylex): Update.
2447         * f-exp.y (yylex): Update.
2448         * d-exp.y: Update all rules.
2449         (yylex): Update.
2450         * c-exp.y: Update all rules.
2451         (lex_one_token, classify_name, yylex, c_parse): Update.
2452         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2453
2454 2019-04-04  Tom Tromey  <tom@tromey.com>
2455
2456         * gdbarch.h, gdbarch.c: Rebuild.
2457         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2458         * stap-probe.h:
2459         (struct stap_parse_info): Replace "parser_state" with
2460         "expr_builder".
2461         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2462         (parser_state): New class.
2463         * parse.c (expr_builder): Rename.
2464         (expr_builder::release): Rename.
2465         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2466         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2467         (write_exp_elt_longcst, write_exp_elt_floatcst)
2468         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2469         (write_exp_string_vector, write_exp_bitstring)
2470         (write_exp_msymbol, mark_struct_expression)
2471         (write_dollar_variable)
2472         (insert_type_address_space, increase_expout_size): Replace
2473         "parser_state" with "expr_builder".
2474         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2475         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2476         "parser_state" with "expr_builder".
2477
2478 2019-04-04  Tom Tromey  <tom@tromey.com>
2479
2480         * rust-exp.y: Replace "parse_language" with method call.
2481         * p-exp.y:
2482         (yylex): Replace "parse_language" with method call.
2483         * m2-exp.y:
2484         (yylex): Replace "parse_language" with method call.
2485         * go-exp.y (classify_name): Replace "parse_language" with method
2486         call.
2487         * f-exp.y (yylex): Replace "parse_language" with method call.
2488         * d-exp.y (lex_one_token): Replace "parse_language" with method
2489         call.
2490         * c-exp.y:
2491         (lex_one_token, classify_name, yylex): Replace "parse_language"
2492         with method call.
2493         * ada-exp.y (find_primitive_type, type_char)
2494         (type_system_address): Replace "parse_language" with method call.
2495
2496 2019-04-04  Tom Tromey  <tom@tromey.com>
2497
2498         * rust-exp.y: Replace "parse_gdbarch" with method call.
2499         * parse.c (write_dollar_variable, insert_type_address_space):
2500         Replace "parse_gdbarch" with method call.
2501         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2502         call.
2503         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2504         call.
2505         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2506         "parse_gdbarch" with method call.
2507         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2508         with method call.
2509         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2510         "parse_gdbarch" with method call.
2511         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2512         "parse_gdbarch" with method call.
2513         * c-exp.y (parse_type, parse_number, classify_name): Replace
2514         "parse_gdbarch" with method call.
2515         * ada-lex.l: Replace "parse_gdbarch" with method call.
2516         * ada-exp.y (parse_type, find_primitive_type, type_char)
2517         (type_system_address): Replace "parse_gdbarch" with method call.
2518
2519 2019-04-04  Tom Tromey  <tom@tromey.com>
2520
2521         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2522         * stap-probe.c (stap_parse_argument): Update.
2523         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2524         initial_size parameter.
2525         * rust-exp.y (rust_lex_tests): Update.
2526         * parse.c (parser_state): Update.
2527         (parse_exp_in_context): Update.
2528         * parser-defs.h (struct parser_state) <parser_state>: Remove
2529         "initial_size" parameter.
2530
2531 2019-04-04  Tom Tromey  <tom@tromey.com>
2532
2533         * parser-defs.h (increase_expout_size): Don't declare.
2534         * parse.c (increase_expout_size): Now static.
2535
2536 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2537
2538         * gnu-nat.c (gnu_nat_target::wait): Fix
2539         target_waitstatus_to_string call.
2540
2541 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * eval.c (evaluate_subexp_standard): Handle internal functions
2544         during Fortran function call handling.
2545
2546 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * NEWS: Mention new internal functions.
2549         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2550         (read_base_type): Use dwarf2_init_complex_target_type.
2551         * value.c (creal_internal_fn): New function.
2552         (cimag_internal_fn): New function.
2553         (_initialize_values): Register new internal functions.
2554
2555 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2556
2557         * infrun.c (stop_all_threads): If debug_infrun, always
2558         trace the wait status after wait_one, using
2559         target_waitstatus_to_string and target_pid_to_str.
2560         (handle_inferior_event): Replace various trace of
2561         wait status kind by a single trace.
2562         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2563         wait status kind image by target_waitstatus_to_string.
2564         * target/waitstatus.c (target_waitstatus_to_string): Fix
2565         obsolete comment.
2566
2567 2019-04-01  Tom Tromey  <tromey@adacore.com>
2568
2569         PR symtab/23331:
2570         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2571
2572 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2573             Pedro Alves  <palves@redhat.com>
2574
2575         * top.c (quit_force): Call 'finalize_values'.
2576         * value.c (finalize_values): New function.
2577         * value.h (finalize_values): Declare.
2578
2579 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2580
2581         * NEWS: Announce $_gdb_major and $_gdb_minor.
2582
2583         * top.c (init_gdb_version_vars): New function.
2584         (gdb_init): Call init_gdb_version_vars.
2585
2586 2019-03-29  Tom Tromey  <tromey@adacore.com>
2587
2588         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2589         help text.  Remove dead code.
2590
2591 2019-03-29  Keith Seitz  <keiths@redhat.com>
2592
2593         From Siddhesh Poyarekar:
2594         * f-lang.h (f77_get_upperbound): Return LONGEST.
2595         (f77_get_lowerbound): Likewise.
2596         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2597         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2598         print them.
2599         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2600         plongest to format print it.
2601         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2602         (f77_get_upperbound): Likewise.
2603         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2604         LOWER_BOUND to LONGEST.
2605         (f77_create_arrayprint_offset_tbl): Likewise.
2606
2607 2019-03-29  Keith Seitz  <keiths@redhat.com>
2608
2609         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2610         %s/pulongest for TYPE_LENGTH instead of %d in format
2611         strings.
2612         * ada-typerint.c (ada_print_type): Likewise.
2613         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2614         * compile/compile-c-support.c (generate_register_struct): Likewise.
2615         * gdbtypes.c (recursive_dump_type): Likewise.
2616         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2617         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2618         instead of %d in format strings.
2619         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2620         to std::min to ULONGEST.
2621         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2622         instead of %d in format strings.
2623         * tracepoint.c (info_scope_command): Likewise.
2624         * typeprint.c (print_offset_data::update)
2625         (print_offset_data::finish): Likewise.
2626         * xtensa-tdep.c (xtensa_store_return_value)
2627         (xtensa_push_dummy_call): Likewise.
2628
2629 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2630
2631         * windows-nat.c (display_selector): Fixed format specifications
2632         for 64-bit Cygwin.
2633
2634 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2635
2636         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2637
2638 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2639
2640         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2641         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2642         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2643         (nios2_linux_init_abi): Install it.
2644
2645 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2646
2647         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2648
2649 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2650
2651         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2652
2653 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2654             Tom Tromey  <tromey@adacore.com>
2655
2656         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2657
2658 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2659
2660         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2661         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2662         method to compute the bounds of range types. Also print "[evaluated]"
2663         if the bounds' values come from a dynamic evaluation.
2664
2665 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2668         whitespace when pretty printing is on.
2669
2670 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2671
2672         * ppc-linux-nat.c: Add include.
2673
2674 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2675
2676         * NEWS: Mention AArch64 Pointer Authentication.
2677
2678 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2679
2680         * arm-linux-nat.c: Add include.
2681
2682 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2683
2684         * source-cache.c (source_cache::get_source_lines): Re-read
2685         fullname after calling open_source_file.
2686
2687 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2688
2689         * NEWS: Mention TLS support for FreeBSD.
2690
2691 2019-03-25  Tom Tromey  <tromey@adacore.com>
2692
2693         * minsyms.c (BUNCH_SIZE): Update comment.
2694         (~minimal_symbol_reader): Remove old comment.
2695         (compact_minimal_symbols): Update comment.
2696         (minimal_symbol_reader::install): Remove old comment.  Update
2697         other comments.
2698
2699 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2700
2701         * s390-linux-nat.c: Add include.
2702
2703 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2704
2705         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2706         Call linux_get_hwcap.
2707         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2708         Likewise.
2709         (aarch64_linux_get_hwcap): Remove function.
2710         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2711         declaration.
2712         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2713         linux_get_hwcap.
2714         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2715         * linux-tdep.c (linux_get_hwcap): Add function.
2716         (linux_get_hwcap2): Likewise.
2717         * linux-tdep.h (linux_get_hwcap): Add declaration.
2718         (linux_get_hwcap2): Likewise.
2719         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2720         (ppc_linux_get_hwcap2): Likewise.
2721         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2722         linux_get_hwcap.
2723         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2724         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2725         (ppc_linux_nat_target::read_description): Likewise.
2726         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2727         * s390-linux-nat.c: Likewise.
2728         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2729
2730 2019-03-24  Tom Tromey  <tom@tromey.com>
2731
2732         * ada-lang.c (standard_lookup): Simplify initialization.
2733         (ada_lookup_symbol_nonlocal): Simplify return.
2734         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2735         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2736         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2737         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2738         initialization.
2739         * solib.c (solib_global_lookup): Simplify.
2740         * symtab.c (null_block_symbol): Remove.
2741         (symbol_cache_lookup): Simplify returns.
2742         (lookup_language_this): Simplify returns.
2743         (lookup_symbol_aux): Simplify return.
2744         (lookup_local_symbol): Simplify returns.
2745         (lookup_global_symbol_from_objfile): Simplify return.
2746         (lookup_symbol_in_objfile_symtabs)
2747         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2748         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2749         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2750         * cp-namespace.c (cp_lookup_bare_symbol)
2751         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2752         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2753         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2754         (cp_lookup_symbol_via_imports): Simplify initialization.
2755         (find_symbol_in_baseclass): Likewise.
2756         * symtab.h (null_block_symbol): Remove.
2757         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2758         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2759         (d_lookup_symbol_module): Likewise.
2760         (find_symbol_in_baseclass): Simplify initialization.
2761
2762 2019-03-24  Tom Tromey  <tom@tromey.com>
2763
2764         * expression.h: Don't include symtab.h.
2765         (struct block): Forward declare.
2766
2767 2019-03-24  Tom Tromey  <tom@tromey.com>
2768
2769         * c-exp.y (typebase): Remove casts.
2770         * gdbtypes.c (lookup_unsigned_typename, )
2771         (lookup_signed_typename): Remove cast.
2772         * eval.c (parse_to_comma_and_eval): Remove cast.
2773         * parse.c (write_dollar_variable): Remove cast.
2774         * block.h (struct block) <superblock>: Now const.
2775         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2776         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2777         (map_block): Make "block" const.
2778         * symfile.h (struct quick_symbol_functions)
2779         <map_matching_symbols>: Constify block argument to "callback".
2780         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2781         const.
2782         (find_pc_sect_compunit_symtab): Make "b" const.
2783         (find_symbol_at_address): Likewise.
2784         (search_symbols): Likewise.
2785         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2786         (dw2_debug_names_lookup_symbol): Likewise.
2787         (dw2_map_matching_symbols): Update.
2788         * p-valprint.c (pascal_val_print): Remove "block".
2789         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2790         (aux_add_nonlocal_symbols): Make "block" const.
2791         (resolve_subexp): Remove cast.
2792         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2793         const.
2794         (iterate_over_file_blocks): Likewise.
2795         * f-exp.y (%union) <bval>: Remove.
2796         * coffread.c (patch_opaque_types): Make "b" const.
2797         * spu-tdep.c (spu_catch_start): Make "block" const.
2798         * c-valprint.c (print_unpacked_pointer): Remove "block".
2799         * symmisc.c (dump_symtab_1): Make "b" const.
2800         (block_depth): Make "block" const.
2801         * d-exp.y (%union) <bval>: Remove.
2802         * cp-support.h (cp_lookup_rtti_type): Update.
2803         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2804         * psymtab.c (psym_lookup_symbol): Make "block" const.
2805         (maintenance_check_psymtabs): Make "b" const.
2806         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2807         (enumerate_locals, enumerate_args): Update.
2808         * python/py-symtab.c (stpy_global_block): Make "block" const.
2809         (stpy_static_block): Likewise.
2810         * inline-frame.c (block_starting_point_at): Make "new_block"
2811         const.
2812         * block.c (find_block_in_blockvector): Make return type const.
2813         (blockvector_for_pc_sect): Make "b" const.
2814         (find_block_in_blockvector): Make "b" const.
2815
2816 2019-03-23  Tom Tromey  <tom@tromey.com>
2817
2818         * varobj.c (varobj_create): Update.
2819         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2820         * printcmd.c (display_command, do_one_display): Don't reset
2821         innermost_block.
2822         * parser-defs.h (enum innermost_block_tracker_type): Move to
2823         expression.h.
2824         (innermost_block): Update comment.
2825         * parse.c (parse_exp_1): Add tracker_types parameter.
2826         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2827         tracker_types parameter.  Reset innermost_block.
2828         (parse_exp_in_context): Remove.
2829         (parse_expression_for_completion): Update.
2830         * objfiles.c (~objfile): Don't reset expression_context_block or
2831         innermost_block.
2832         * expression.h (enum innermost_block_tracker_type): Move from
2833         parser-defs.h.
2834         (parse_exp_1): Add tracker_types parameter.
2835         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2836         reset innermost_block.
2837
2838 2019-03-23  Tom Tromey  <tom@tromey.com>
2839
2840         * objfiles.h: Include bcache.h.
2841
2842 2019-03-23  Tom Tromey  <tom@tromey.com>
2843
2844         * linespec.c (get_current_search_block): Use
2845         scoped_restore_current_language.
2846         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2847
2848 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2849             Jiong Wang  <jiong.wang@arm.com>
2850
2851         * aarch64-linux-tdep.c
2852         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2853         section.
2854         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2855
2856 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2857             Jiong Wang  <jiong.wang@arm.com>
2858
2859         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2860         instructions.
2861         (aarch64_analyze_prologue_test): Add PACIASP test.
2862         (aarch64_prologue_prev_register): Unmask PC value.
2863
2864 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2865             Jiong Wang  <jiong.wang@arm.com>
2866
2867         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2868         (aarch64_dwarf2_prev_register): Unmask PC value.
2869         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2870         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2871         DW_CFA_AARCH64_negate_ra_state.
2872         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2873
2874 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2875             Jiong Wang  <jiong.wang@arm.com>
2876
2877         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2878         registers.
2879         (aarch64_pseudo_register_name): Likewise.
2880         (aarch64_pseudo_register_type): Likewise.
2881         (aarch64_pseudo_register_reggroup_p): Likewise.
2882         (aarch64_gdbarch_init): Add pauth registers.
2883         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2884         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2885         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2886         (struct gdbarch_tdep): Add regnum for ra_state.
2887
2888 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2889             Jiong Wang  <jiong.wang@arm.com>
2890
2891         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2892
2893 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2894             Jiong Wang  <jiong.wang@arm.com>
2895
2896         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2897         function.
2898         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2899         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2900         (aarch64_gdbarch_init): Add puth registers.
2901         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2902         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2903         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2904
2905 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2906             Jiong Wang  <jiong.wang@arm.com>
2907
2908         * aarch64-linux-nat.c
2909         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2910         * aarch64-linux-tdep.c
2911         (aarch64_linux_core_read_description): Likewise.
2912         (aarch64_linux_get_hwcap): New function.
2913         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2914         (aarch64_linux_get_hwcap): New declaration.
2915
2916 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2917             Jiong Wang  <jiong.wang@arm.com>
2918
2919         * aarch64-linux-nat.c
2920         (aarch64_linux_nat_target::read_description): Add pauth param.
2921         * aarch64-linux-tdep.c
2922         (aarch64_linux_core_read_description): Likewise.
2923         * aarch64-tdep.c (struct target_desc): Add in pauth.
2924         (aarch64_read_description): Add pauth param.
2925         (aarch64_gdbarch_init): Likewise.
2926         * aarch64-tdep.h (aarch64_read_description): Likewise.
2927         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2928         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2929         * features/Makefile: Add new files.
2930         * features/aarch64-pauth.c: New file.
2931         * features/aarch64-pauth.xml: New file.
2932
2933 2019-03-20  Tom Tromey  <tromey@adacore.com>
2934
2935         * infrun.c (handle_inferior_event): Rename from
2936         handle_inferior_event_1.  Create a scoped_value_mark.
2937         (handle_inferior_event): Remove.
2938
2939 2019-03-19  Tom Tromey  <tromey@adacore.com>
2940
2941         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2942         * infrun.h (print_stop_event): Add "displays" parameter.
2943         * infrun.c (print_stop_event): Add "displays" parameter.
2944
2945 2019-03-19  Pedro Alves  <palves@redhat.com>
2946
2947         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2948         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2949         to -1.  Fix TABs vs spaces.
2950         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2951         * tui/tui-out.h (tui_ui_out) Add intro comments.
2952         <m_line, m_start_of_line>: In-class initialize, and add describing
2953         comment.
2954
2955 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2956
2957         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2958         variable names.
2959         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2960
2961 2019-03-18  Pedro Alves  <palves@redhat.com>
2962             Eli Zaretskii <eliz@gnu.org>
2963
2964         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2965         m_line and m_start_of_line.
2966
2967 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2968
2969         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2970         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2971         it returns a newline.  This fixes a regression in TU mode, whereby
2972         the next line is output on the same screen line as the user input.
2973
2974 2019-03-18  Tom Tromey  <tromey@adacore.com>
2975
2976         * minsyms.c (minimal_symbol_reader::install): Remove call to
2977         obstack_blank.
2978
2979 2019-03-18  Pedro Alves  <palves@redhat.com>
2980
2981         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2982         New globals.
2983         (apply_style): New, factored out from ...
2984         (apply_ansi_escape): ... this.  Handle reverse video mode.
2985         (tui_set_reverse_mode): New function.
2986         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2987         * tui/tui-winsource.c (tui_show_source_line): Use
2988         tui_set_reverse_mode instead of setting A_STANDOUT.
2989         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2990         New setter methods.
2991
2992 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2993
2994         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2995         Handle tabs.
2996
2997 2019-03-18  Tom Tromey  <tromey@adacore.com>
2998
2999         * ada-lang.c (empty_array): Add "high" parameter.
3000         (ada_evaluate_subexp): Update.
3001
3002 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3003
3004         * unittests/string_view-selftests.c: Define
3005         _initialize_string_view_selftests unconditionally.
3006
3007 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3008
3009         PR gdb/24350
3010         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3011
3012 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3013
3014         PR gdb/24351
3015         * windows-nat.c (display_selector): Fix format specifiers.
3016
3017 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3018
3019         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3020         tui_refill_source_window instead of tui_refresh_win, to update the
3021         current execution line.  This fixes redisplay of the current line
3022         when stepping through the code with "next" or "step".
3023
3024 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3025
3026         * source-cache.c (source_cache::get_source_lines): Call
3027         find_source_lines to initialize s->nlines.  This fixes vertical
3028         scrolling of TUI source window when the DOWN arrow is pressed.
3029
3030 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3031
3032         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3033         linux-thread-db.c (_initialize_thread_db): Likewise.
3034
3035 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3036
3037         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3038         wclrtoeol in tui_show_source_line".  This reverts changes made in
3039         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3040
3041 2019-03-15  Tom Tromey  <tom@tromey.com>
3042
3043         * symtab.h (struct minimal_symbol): Derive from
3044         general_symbol_info.
3045         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3046         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3047         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3048         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3049         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3050         (MSYMBOL_SEARCH_NAME): Update.
3051         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3052         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3053         * minsyms.c (minimal_symbol_reader::record_full): Update.
3054
3055 2019-03-15  Tom Tromey  <tom@tromey.com>
3056
3057         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3058
3059 2019-03-15  Tom Tromey  <tom@tromey.com>
3060
3061         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3062         unique_xmalloc_ptr.
3063         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3064         Update.
3065         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3066         (build_minimal_symbol_hash_tables)
3067         (minimal_symbol_reader::install): Update.
3068
3069 2019-03-15  Tom Tromey  <tom@tromey.com>
3070
3071         * symtab.c (create_demangled_names_hash): Update.
3072         (symbol_set_names): Update.
3073         * objfiles.h (struct objfile_per_bfd_storage)
3074         <demangled_names_hash>: Now an htab_up.
3075         * objfiles.c (objfile_per_bfd_storage): Simplify.
3076
3077 2019-03-15  Tom Tromey  <tom@tromey.com>
3078
3079         * objfiles.h (struct objfile_per_bfd_storage): Declare
3080         destructor.
3081         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3082         New.
3083         (get_objfile_bfd_data): Use new.  Don't initialize
3084         language_of_main.
3085         (free_objfile_per_bfd_storage): Remove.
3086         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3087
3088 2019-03-15  Tom Tromey  <tom@tromey.com>
3089
3090         * symfile.c (reread_symbols): Update.
3091         * objfiles.c (objfile::objfile): Update.
3092         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3093         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3094         comment.
3095         (minimal_symbol_reader::install): Update.
3096         (terminate_minimal_symbol_table): Remove.
3097         * jit.c (jit_object_close_impl): Update.
3098
3099 2019-03-15  Tom Tromey  <tom@tromey.com>
3100
3101         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3102         initializations.
3103
3104 2019-03-15  Tom Tromey  <tom@tromey.com>
3105
3106         * objfiles.h (struct objfile_per_bfd_storage)
3107         <demangled_hash_languages>: Now a bitset.
3108         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3109         (lookup_minimal_symbol): Update.
3110
3111 2019-03-15  Tom Tromey  <tom@tromey.com>
3112
3113         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3114         Don't return the symbol.
3115         * coffread.c (record_minimal_symbol): Use record_full.
3116
3117 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3118
3119         The MS-Windows port of ncurses fails to switch to a color pair if
3120         one or both of the colors are the implicit default colors.  This
3121         change records the default colors when TUI is initialized, and
3122         then specifies them explicitly when a color pair uses the default
3123         colors.  This allows color styling in TUI mode on MS-Windows.
3124
3125         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3126         ncurses_norm_attr.
3127         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3128         colors in ncurses_norm_attr.
3129         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3130         "none", replace it with the default color recorded in
3131         ncurses_norm_attr.
3132
3133 2019-03-14  Tom Tromey  <tromey@adacore.com>
3134
3135         * source-cache.h (class source_cache) <get_source_lines>: Return
3136         std::string.
3137         * source-cache.c (source_cache::extract_lines): Handle case where
3138         first_pos==npos.  Return std::string.
3139         (source_cache::get_source_lines): Update.
3140
3141 2019-03-14  Tom Tromey  <tromey@adacore.com>
3142
3143         * NEWS: Add item for "style sources" commands.
3144         * source-cache.c (source_cache::get_source_lines): Check
3145         source_styling.
3146         * cli/cli-style.c (source_styling): New global.
3147         (_initialize_cli_style): Add "style sources" commands.
3148         (show_style_sources): New function.
3149         * cli/cli-style.h (source_styling): Declare.
3150
3151 2019-03-14  Pedro Alves  <palves@redhat.com>
3152             Tom Tromey  <tromey@adacore.com>
3153
3154         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3155         * tui/tui-winsource.c (tui_refill_source_window): New function,
3156         from...
3157         (tui_horizontal_source_scroll): ... here.  Move some logic.
3158         * cli/cli-style.c (set_style_enabled): Notify new observable.
3159         * tui/tui-hooks.c (tui_redisplay_source): New function.
3160         (tui_attach_detach_observers): Attach or detach
3161         tui_redisplay_source.
3162         * observable.h (source_styling_changed): New observable.
3163         * observable.c: Define source_styling_changed observable.
3164
3165 2019-03-13  Tom Tromey  <tromey@adacore.com>
3166
3167         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3168         (i386_gnu_nat_target::store_registers): Update.
3169         * target-debug.h (target_debug_print_std_string): New macro.
3170         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3171         * windows-tdep.c (display_one_tib): Update.
3172         * tui/tui-stack.c (tui_make_status_line): Update.
3173         * top.c (print_inferior_quit_action): Update.
3174         * thread.c (thr_try_catch_cmd): Update.
3175         (add_thread_with_info): Update.
3176         (thread_target_id_str): Update.
3177         (thr_try_catch_cmd): Update.
3178         (thread_command): Update.
3179         (thread_find_command): Update.
3180         * record-btrace.c (record_btrace_target::info_record)
3181         (record_btrace_resume_thread, record_btrace_target::resume)
3182         (record_btrace_cancel_resume, record_btrace_step_thread)
3183         (record_btrace_target::wait, record_btrace_target::wait)
3184         (record_btrace_target::wait, record_btrace_target::stop): Update.
3185         * progspace.c (print_program_space): Update.
3186         * process-stratum-target.c
3187         (process_stratum_target::thread_address_space): Update.
3188         * linux-fork.c (linux_fork_mourn_inferior)
3189         (detach_checkpoint_command, info_checkpoints_command)
3190         (linux_fork_context): Update.
3191         (linux_fork_detach): Update.
3192         (class scoped_switch_fork_info): Update.
3193         (delete_checkpoint_command): Update.
3194         * infrun.c (follow_fork_inferior): Update.
3195         (follow_fork_inferior): Update.
3196         (proceed_after_vfork_done): Update.
3197         (handle_vfork_child_exec_or_exit): Update.
3198         (follow_exec): Update.
3199         (displaced_step_prepare_throw): Update.
3200         (displaced_step_restore): Update.
3201         (start_step_over): Update.
3202         (resume_1): Update.
3203         (clear_proceed_status_thread): Update.
3204         (proceed): Update.
3205         (print_target_wait_results): Update.
3206         (do_target_wait): Update.
3207         (context_switch): Update.
3208         (stop_all_threads): Update.
3209         (restart_threads): Update.
3210         (finish_step_over): Update.
3211         (handle_signal_stop): Update.
3212         (switch_back_to_stepped_thread): Update.
3213         (keep_going_pass_signal): Update.
3214         (print_exited_reason): Update.
3215         (normal_stop): Update.
3216         * inferior.c (inferior_pid_to_str): Change return type.
3217         (print_selected_inferior): Update.
3218         (add_inferior): Update.
3219         (detach_inferior): Update.
3220         * dummy-frame.c (fprint_dummy_frames): Update.
3221         * dcache.c (dcache_info_1): Update.
3222         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3223         (btrace_fetch, btrace_clear): Update.
3224         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3225         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3226         type.
3227         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3228         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3229         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3230         * gdbarch.c, gdbarch.h: Rebuild.
3231         * gdbarch.sh (core_pid_to_str): Change return type.
3232         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3233         return type.
3234         (windows_nat_target::pid_to_str): Change return type.
3235         (windows_delete_thread): Update.
3236         (windows_nat_target::attach): Update.
3237         (windows_nat_target::files_info): Update.
3238         * target-delegates.c: Rebuild.
3239         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3240         return type.
3241         (sol_thread_target::pid_to_str): Change return type.
3242         * remote.c (class remote_target) <pid_to_str>: Change return
3243         type.
3244         (remote_target::pid_to_str): Change return type.
3245         (extended_remote_target::attach, remote_target::remote_stop_ns)
3246         (remote_target::remote_notif_remove_queued_reply)
3247         (remote_target::push_stop_reply, remote_target::disable_btrace):
3248         Update.
3249         (extended_remote_target::attach): Update.
3250         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3251         type.
3252         (gdbsim_target::pid_to_str): Change return type.
3253         * ravenscar-thread.c (struct ravenscar_thread_target)
3254         <pid_to_str>: Change return type.
3255         (ravenscar_thread_target::pid_to_str): Change return type.
3256         * procfs.c (class procfs_target) <pid_to_str>: Change return
3257         type.
3258         (procfs_target::pid_to_str): Change return type.
3259         (procfs_target::attach): Update.
3260         (procfs_target::detach): Update.
3261         (procfs_target::fetch_registers): Update.
3262         (procfs_target::store_registers): Update.
3263         (procfs_target::wait): Update.
3264         (procfs_target::files_info): Update.
3265         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3266         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3267         return type.
3268         (nto_procfs_target::pid_to_str): Change return type.
3269         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3270         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3271         return type.
3272         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3273         (exit_lwp): Update.
3274         (attach_proc_task_lwp_callback, get_detach_signal)
3275         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3276         (linux_nat_target::resume, wait_lwp, stop_callback)
3277         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3278         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3279         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3280         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3281         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3282         type.
3283         (inf_ptrace_target::attach): Update.
3284         (inf_ptrace_target::files_info): Update.
3285         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3286         type.
3287         (go32_nat_target::pid_to_str): Change return type.
3288         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3289         (gnu_nat_target::wait): Update.
3290         (gnu_nat_target::wait): Update.
3291         (gnu_nat_target::resume): Update.
3292         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3293         (fbsd_nat_target::wait): Update.
3294         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3295         type.
3296         (darwin_nat_target::attach): Update.
3297         * corelow.c (class core_target) <pid_to_str>: Change return type.
3298         (core_target::pid_to_str): Change return type.
3299         * target.c (normal_pid_to_str): Change return type.
3300         (default_pid_to_str): Likewise.
3301         (target_pid_to_str): Change return type.
3302         (target_translate_tls_address): Update.
3303         (target_announce_detach): Update.
3304         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3305         return type.
3306         (bsd_uthread_target::pid_to_str): Change return type.
3307         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3308         type.
3309         (bsd_kvm_target::pid_to_str): Change return type.
3310         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3311         return type.
3312         (aix_thread_target::pid_to_str): Change return type.
3313         * target.h (struct target_ops) <pid_to_str>: Change return type.
3314         (target_pid_to_str, normal_pid_to_str): Likewise.
3315         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3316         type.
3317         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3318         type.
3319         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3320         return type.
3321         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3322         type.
3323         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3324         type.
3325         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3326         return type.
3327
3328 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3329
3330         * NEWS: Mention that the new default MI version is 3.  Mention
3331         changes to the output of commands and events that deal with
3332         multi-location breakpoints.
3333         * breakpoint.c: Include "mi/mi-out.h".
3334         (print_one_breakpoint): Change output syntax if using MI version
3335         >= 3.
3336         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3337         New.
3338         (mi_multi_location_breakpoint_output_fixed): New.
3339         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3340         (mi_cmd_fix_multi_location_breakpoint_output): New.
3341         (mi_multi_location_breakpoint_output_fixed): New.
3342         * mi/mi-cmds.c (mi_cmds): Register command
3343         -fix-multi-location-breakpoint-output.
3344         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3345         interpreter "mi".
3346
3347 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3348
3349         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3350         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3351         instantiate mi_ui_out based on interpreter name.
3352         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3353         * mi/mi-main.c (mi_load_progress): Likewise.
3354
3355 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3356
3357         * NEWS: Combine separate "New targets" sections for 8.3.
3358
3359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3360
3361         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3362         (ppcfbsd_init_abi): Install gdbarch
3363         "fetch_tls_load_module_address" and "get_thread_local_address"
3364         methods.
3365
3366 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3367
3368         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3369         (riscv_fbsd_init_abi): Install gdbarch
3370         "fetch_tls_load_module_address" and "get_thread_local_address"
3371         methods.
3372
3373 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3374
3375         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3376         (i386fbsd_init_abi): Install gdbarch
3377         "fetch_tls_load_module_address" and "get_thread_local_address"
3378         methods.
3379
3380 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3381
3382         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3383         (amd64fbsd_init_abi): Install gdbarch
3384         "fetch_tls_load_module_address" and "get_thread_local_address"
3385         methods.
3386
3387 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3388
3389         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3390         (struct fbsd_pspace_data): New type.
3391         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3392         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3393         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3394         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3395         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3396
3397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3398
3399         * gdbtypes.c (lookup_struct_elt): New function.
3400         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3401         * gdbtypes.h (struct struct_elt): New type.
3402         (lookup_struct_elt): New prototype.
3403
3404 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3405
3406         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3407         remove disabled code block.
3408
3409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3410
3411         * gdbarch.sh (get_thread_local_address): New method.
3412         * gdbarch.h, gdbarch.c: Regenerate.
3413         * target.c (target_translate_tls_address): Use
3414         gdbarch_get_thread_local_address if present instead of
3415         target::get_thread_local_address.
3416
3417 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3418
3419         * target.h (target::get_thread_local_address): Update comment.
3420
3421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3422
3423         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3424         objfile->separate_debug_objfile_backlink if not NULL.
3425
3426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3427
3428         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3429         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3430         (amd64bsd_store_inferior_registers): Likewise.
3431         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3432         Enable segment base registers.
3433         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3434         PT_GETFSBASE and PT_GETGSBASE.
3435         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3436         PT_SETGSBASE.
3437         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3438         segment base registers.
3439         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3440
3441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3442
3443         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3444         Update calls to i386_target_description to add 'segments'
3445         parameter.
3446         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3447         add segment base registers.
3448         * arch/i386.c (i386_create_target_description): Add 'segments'
3449         parameter to enable segment base registers.
3450         * arch/i386.h (i386_create_target_description): Likewise.
3451         * features/i386/32bit-segments.xml: New file.
3452         * features/i386/32bit-segments.c: Generate.
3453         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3454         call to i386_target_description to add 'segments' parameter.
3455         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3456         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3457         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3458         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3459         if feature is present.
3460         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3461         Add 'segments' parameter to call to i386_target_description.
3462         (i386_target_description): Add 'segments' parameter to enable
3463         segment base registers.
3464         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3465         to call to i386_target_description.
3466         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3467         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3468         Define I386_NUM_REGS.
3469         (i386_target_description): Add 'segments' parameter to enable
3470         segment base registers.
3471
3472 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3473
3474         PR/24325
3475         * source-cache.c: #undef open and close, to avoid unresolved
3476         externals during linking.
3477
3478 2019-03-12  Tom Tromey  <tromey@adacore.com>
3479
3480         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3481         const.  Add initializers.
3482         (_initialize_remote): Don't initialize ptid globals.
3483
3484 2019-03-12  Pedro Alves  <palves@redhat.com>
3485
3486         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3487
3488 2019-03-12  Pedro Alves  <palves@redhat.com>
3489
3490         * cp-name-parser.y (main): Remove unused 'len' variable.
3491
3492 2019-03-12  Tom Tromey  <tromey@adacore.com>
3493
3494         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3495         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3496
3497 2019-03-12  Tom Tromey  <tromey@adacore.com>
3498
3499         * linux-nat.c (iterate_over_lwps): Update.
3500         (stop_callback): Remove parameter.
3501         (stop_wait_callback, detach_callback, resume_set_callback)
3502         (select_singlestep_lwp_callback, set_ignore_sigint)
3503         (status_callback, resumed_callback, resume_clear_callback)
3504         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3505         data parameter.
3506         (linux_nat_target::detach, linux_nat_target::resume)
3507         (linux_stop_and_wait_all_lwps, select_event_lwp)
3508         (linux_nat_filter_event, linux_nat_wait_1)
3509         (linux_nat_target::kill, linux_nat_target::stop)
3510         (linux_nat_target::stop): Update.
3511         (linux_nat_resume_callback): Change type.
3512         (resume_stopped_resumed_lwps, count_events_callback)
3513         (select_event_lwp_callback): Likewise.
3514         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3515         * arm-linux-nat.c (struct update_registers_data): Remove.
3516         (update_registers_callback): Change type.
3517         (arm_linux_insert_hw_breakpoint1): Update.
3518         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3519         parameter.
3520         (x86_linux_dr_set_addr): Update.
3521         (x86_linux_dr_set_control): Update.
3522         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3523         (iterate_over_lwps): Use gdb::function_view.
3524         * nat/aarch64-linux-hw-point.c (struct
3525         aarch64_dr_update_callback_param): Remove.
3526         (debug_reg_change_callback): Change type.
3527         (aarch64_notify_debug_reg_change): Update.
3528         * s390-linux-nat.c (s390_refresh_per_info): Update.
3529
3530 2019-03-11  Tom Tromey  <tromey@adacore.com>
3531
3532         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3533         redundant assignment to "this_cu".
3534
3535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3536
3537         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3538
3539 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3540
3541         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3542         from...
3543         (rank_one_type): ... this.
3544
3545 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3546
3547         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3548         from...
3549         (rank_one_type): ... this.
3550
3551 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3552
3553         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3554         from...
3555         (rank_one_type): ... this.
3556
3557 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3558
3559         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3560         from...
3561         (rank_one_type): ... this.
3562
3563 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3564
3565         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3566         from...
3567         (rank_one_type): ... this.
3568
3569 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3570
3571         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3572         from...
3573         (rank_one_type): ... this.
3574
3575 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3576
3577         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3578         from...
3579         (rank_one_type): ... this.
3580
3581 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3582
3583         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3584         from...
3585         (rank_one_type): ... this.
3586
3587 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3588
3589         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3590         from...
3591         (rank_one_type): ... this.
3592
3593 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3594
3595         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3596         from...
3597         (rank_one_type): ... this.
3598
3599 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3600
3601         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3602         from...
3603         (rank_one_type): ... this.
3604
3605 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3606
3607         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3608         from...
3609         (rank_one_type): ... this.
3610
3611 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3612
3613         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3614         inferior-events' shows the example events.
3615
3616 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3617
3618         Support styling on native MS-Windows console
3619
3620         PR/24315
3621         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3622         on MS-Windows if $TERM is not defined.
3623
3624         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3625
3626         * posix-hdep.c (gdb_console_fputs):
3627         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3628         functions.
3629         * ui-file.h (gdb_console_fputs): Add prototype.
3630
3631         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3632         back to fputs only if the former returns zero.
3633
3634 2019-03-07  Tom Tromey  <tom@tromey.com>
3635
3636         * symmisc.c (print_symbol_bcache_statistics): Update.
3637         (print_objfile_statistics): Update.
3638         * symfile.c (allocate_symtab): Update.
3639         * stabsread.c: Don't include bcache.h.
3640         * psymtab.h (struct psymbol_bcache): Don't declare.
3641         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3642         (psymbol_bcache_init, psymbol_bcache_free)
3643         (psymbol_bcache_get_bcache): Don't declare.
3644         * psymtab.c (struct psymbol_bcache): Remove.
3645         (psymtab_storage::psymtab_storage): Update.
3646         (psymtab_storage::~psymtab_storage): Update.
3647         (psymbol_bcache_init, psymbol_bcache_free)
3648         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3649         (add_psymbol_to_bcache): Update.
3650         (allocate_psymtab): Update.
3651         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3652         macro_cache>: No longer pointers.
3653         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3654         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3655         * macrotab.c (macro_bcache): Update.
3656         * macroexp.c: Don't include bcache.h.
3657         * gdbtypes.c (check_types_worklist): Update.
3658         (types_deeply_equal): Remove TRY/CATCH.  Update.
3659         * elfread.c (elf_symtab_read): Update.
3660         * dwarf2read.c: Don't include bcache.h.
3661         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3662         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3663         (print_bcache_statistics, bcache_memory_used): Don't declare.
3664         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3665         methods.  Rename all data members.
3666         * bcache.c (struct bcache): Move to bcache.h.
3667         (bcache::expand_hash_table): Rename from expand_hash_table.
3668         (bcache): Remove.
3669         (bcache::insert): Rename from bcache_full.
3670         (bcache::compare): Rename from bcache_compare.
3671         (bcache_xmalloc): Remove.
3672         (bcache::~bcache): Rename from bcache_xfree.
3673         (bcache::print_statistics): Rename from print_bcache_statistics.
3674         (bcache::memory_used): Rename from bcache_memory_used.
3675
3676 2019-03-07  Pedro Alves  <palves@redhat.com>
3677
3678         * infrun.c (normal_stop): Also check for
3679         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3680
3681 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * f-lang.c (value_from_host_double): Moved to...
3684         * value.c (value_from_host_double): ...here.
3685         * value.h (value_from_host_double): Declare.
3686         * guile/scm-math.c (vlscm_convert_typed_number): Use
3687         value_from_host_double.
3688         (vlscm_convert_number): Likewise.
3689         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3690         * python/py-value.c (convert_value_from_python): Likewise.
3691
3692 2019-03-06  Tom Tromey  <tom@tromey.com>
3693
3694         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3695
3696 2019-03-06  Tom Tromey  <tom@tromey.com>
3697
3698         * utils.h (free_current_contents): Don't declare.
3699         * utils.c (free_current_contents): Remove.
3700
3701 2019-03-06  Tom Tromey  <tom@tromey.com>
3702
3703         * top.c (quit_force): Update.
3704         * main.c (captured_command_loop): Update.
3705         * common/new-op.c (operator new): Update.
3706         * common/common-exceptions.c (struct catcher)
3707         <save_cleanup_chain>: Remove member.
3708         (exceptions_state_mc_init): Update.
3709         (exception_try_scope_entry): Return nullptr.
3710         (exception_try_scope_exit, exception_rethrow)
3711         (throw_exception_sjlj, throw_exception_cxx): Update.
3712         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3713         (all_cleanups, do_cleanups, discard_cleanups)
3714         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3715         (restore_cleanups, restore_final_cleanups): Don't declare.
3716         (do_final_cleanups): Remove parameter.
3717         * common/cleanups.c (cleanup_chain, make_cleanup)
3718         (make_cleanup_dtor, all_cleanups, do_cleanups)
3719         (discard_my_cleanups, discard_cleanups)
3720         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3721         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3722         (null_cleanup): Remove.
3723         (do_final_cleanups): Remove parameter.
3724
3725 2019-03-06  Tom Tromey  <tom@tromey.com>
3726
3727         * remote.c (remote_target::remote_parse_stop_reply): Use
3728         unique_xmalloc_ptr.
3729
3730 2019-03-06  Tom Tromey  <tom@tromey.com>
3731
3732         * stabsread.c (struct stabs_field_info): Rename from field_info.
3733         <list, fnlist>: Add initializers.
3734         <obstack>: New member.
3735         (read_member_functions, read_struct_fields, read_baseclasses):
3736         Allocate on obstack.  Don't use cleanups.
3737         (read_one_struct_field, read_member_functions, read_struct_fields)
3738         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3739         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3740         (read_struct_type): Update.
3741
3742 2019-03-06  Tom Tromey  <tom@tromey.com>
3743
3744         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3745         * common/filestuff.h (make_cleanup_close): Don't declare.
3746         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3747         Remove.
3748
3749 2019-03-06  Tom Tromey  <tom@tromey.com>
3750
3751         * solib-aix.c: Use make_scope_exit.
3752
3753 2019-03-06  Tom Tromey  <tom@tromey.com>
3754
3755         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3756         Use make_scope_exit.
3757
3758 2019-03-06  Tom Tromey  <tom@tromey.com>
3759
3760         * solib-svr4.c (disable_probes_interface): Remove parameter.
3761         (svr4_handle_solib_event): Use make_scope_exit.
3762
3763 2019-03-06  Tom Tromey  <tom@tromey.com>
3764
3765         * remote.c (struct stop_reply_deleter): Remove.
3766         (stop_reply_up): Update.
3767         (struct stop_reply): Derive from notif_event.  Don't typedef.
3768         <regcache>: Now a std::vector.
3769         (stop_reply_xfree): Remove.
3770         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3771         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3772         (remote_target::discard_pending_stop_replies): Use delete.
3773         (remote_target::remote_parse_stop_reply): Update.
3774         (remote_target::process_stop_reply): Update.
3775         * remote-notif.h (struct notif_event): Add virtual destructor.
3776         Remove "dtr" member.
3777         (struct notif_client) <alloc_event>: Return a unique_ptr.
3778         (notif_event_xfree): Don't declare.
3779         (notif_event_up): New typedef.
3780         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3781         (notif_event_xfree, do_notif_event_xfree): Remove.
3782         (remote_notif_state_xfree): Update.
3783
3784 2019-03-06  Tom Tromey  <tom@tromey.com>
3785
3786         * infrun.c (displaced_step_clear_cleanup): Now a
3787         forward_scope_exit type.
3788         (displaced_step_prepare_throw): Update.
3789         (displaced_step_fixup): Update.
3790
3791 2019-03-06  Tom Tromey  <tom@tromey.com>
3792
3793         * inferior.h (class inferior): Update comment.
3794         * gdbthread.h (class thread_info): Update comment.
3795
3796 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3797             Tom Tromey  <tom@tromey.com>
3798
3799         * stabsread.h (struct stab_section_list): Remove.
3800         (coffstab_build_psymtabs): Update.
3801         * dbxread.c (symbuf_sections): Now a std::vector.
3802         (sect_idx): New global.
3803         (fill_symbuf): Update.
3804         (coffstab_build_psymtabs): Change type of stabsects parameter.
3805         Update.
3806         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3807         std::vector.
3808         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3809         (coff_locate_sections): Update.
3810         (coff_symfile_read): Remove cleanups.  Update.
3811         (init_stringtab): Add storage parameter.
3812         (free_stringtab, free_stringtab_cleanup): Remove.
3813         (init_lineno): Add storage parameter.
3814         (free_linetab, free_linetab_cleanup): Remove.
3815
3816 2019-03-06  Pedro Alves  <palves@redhat.com>
3817
3818         * linux-fork.c (fork_info::clobber_regs): Delete.
3819         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3820         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3821         comment.  Adjust.
3822         (scoped_switch_fork_info::scoped_switch_fork_info)
3823         (checkpoint_command, linux_fork_context): Adjust
3824         fork_save_infrun_state calls.
3825
3826 2019-03-06  Pedro Alves  <palves@redhat.com>
3827
3828         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3829         (inf_has_multiple_threads): Return 'bool' and rewrite using
3830         inferior_info::threads().
3831
3832 2019-03-06  Pedro Alves  <palves@redhat.com>
3833
3834         * linux-fork.c: Include <list>.
3835         (fork_list): Now a std::list instance.
3836         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3837         (forks_exist_p, find_last_fork): Adjust.
3838         (new_fork): Delete.
3839         (one_fork_p): New.
3840         (add_fork): Adjust.
3841         (free_fork): Delete, folded into fork_info::~fork_info().
3842         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3843         Adjust.
3844         (init_fork_list): Delete.
3845         (linux_fork_killall, linux_fork_mourn_inferior)
3846         (linux_fork_detach, info_checkpoints_command): Adjust.
3847         (_initialize_linux_fork): No longer call init_fork_list.
3848
3849 2019-03-06  Pedro Alves  <palves@redhat.com>
3850
3851         * linux-fork.c (new_fork): New, split out of ...
3852         (add_fork): ... this.  Return void.  Move "first fork" special
3853         case from here, to ...
3854         (checkpoint_command): ... here.
3855         * linux-linux.h (add_fork): Return void.
3856
3857 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3858
3859         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3860
3861 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3862             Chris January  <chris.january@arm.com>
3863             David Lecomber  <david.lecomber@arm.com>
3864
3865         * f-exp.y: New token, UNOP_INTRINSIC.
3866         (exp): New pattern using UNOP_INTRINSIC token.
3867         (f77_keywords): Add 'abs' keyword.
3868         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3869         (value_from_host_double): New function.
3870         (evaluate_subexp_f): Support UNOP_ABS.
3871
3872 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3875         types.
3876
3877 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3880         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3881         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3882
3883 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3886
3887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3888             Chris January  <chris.january@arm.com>
3889
3890         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3891         * f-exp.y: Define 'KIND' token.
3892         (exp): New pattern for KIND expressions.
3893         (ptype): Handle types with a kind extension.
3894         (direct_abs_decl): Extend to spot kind extensions.
3895         (f77_keywords): Add 'kind' to the list.
3896         (push_kind_type): New function.
3897         (convert_to_kind_type): New function.
3898         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3899         * parse.c (operator_length_standard): Likewise.
3900         * parser-defs.h (enum type_pieces): Add tp_kind.
3901         * std-operator.def: Add UNOP_KIND.
3902
3903 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * f-exp.y (f_parse): Set yydebug.
3906
3907 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * f-lang.c (evaluate_subexp_f): New function.
3910         (exp_descriptor_f): New global.
3911         (f_language_defn): Use exp_descriptor_f instead of
3912         exp_descriptor_standard.
3913
3914 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3915
3916         * f-exp.y (struct token): Add comments.
3917         (dot_ops): Remove uppercase versions and the end marker.
3918         (f77_keywords): Likewise.
3919         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3920         entries in the dot_ops array are case insensitive, and use
3921         strncasecmp to compare strings.  Also some whitespace cleanup in
3922         this area.  Similar for the f77_keywords array, except entries in
3923         this list might be case sensitive.
3924
3925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3926
3927         * f-exp.y (struct f77_boolean_val): Add comments.
3928         (boolean_values): Remove uppercase versions, and end marker.
3929         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3930         and use strncasecmp to achieve case insensitivity.  Additionally,
3931         perform whitespace cleanup around this code.
3932
3933 2019-03-06  Tom Tromey  <tromey@adacore.com>
3934
3935         * remote-sim.c (gdbsim_target_open): Use result of
3936         gdb_argv::release.
3937
3938 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3939         Dirk Schubert  <dirk.schubert@arm.com>
3940         Chris January  <chris.january@arm.com>
3941
3942         * eval.c (evaluate_subexp_standard): Call Fortran argument
3943         wrapping logic.
3944         * f-lang.c (struct value): A value which can be passed into a
3945         Fortran function call.
3946         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3947         where appropriate.
3948         (struct type): Value ready for a Fortran function call.
3949         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3950         is needed.
3951         * f-lang.h (fortran_argument_convert): Declaration.
3952         (fortran_preserve_arg_pointer): Declaration.
3953         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3954
3955 2019-03-05  Tom Tromey  <tromey@adacore.com>
3956
3957         * python/py-prettyprint.c (print_string_repr): Remove #if.
3958         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3959
3960 2019-03-05  Tom Tromey  <tromey@adacore.com>
3961
3962         * target.c (the_dummy_target): Move later.  Change type to
3963         "dummy_target".
3964         (initialize_targets): Don't initialize the_dummy_target.
3965
3966 2019-03-05  Tom Tromey  <tromey@adacore.com>
3967
3968         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3969         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3970
3971 2019-03-05  Tom Tromey  <tromey@adacore.com>
3972
3973         * windows-nat.c (windows_nat_target::attach)
3974         (windows_nat_target::detach): Don't call gdb_flush.
3975         * valprint.c (generic_val_print, val_print, val_print_string):
3976         Don't call gdb_flush.
3977         * utils.c (defaulted_query): Don't call gdb_flush.
3978         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3979         * target.c (target_announce_detach): Don't call gdb_flush.
3980         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3981         * remote.c (extended_remote_target::attach): Don't call
3982         gdb_flush.
3983         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3984         * printcmd.c (do_examine): Don't call gdb_flush.
3985         (info_display_command): Don't call gdb_flush.
3986         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3987         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3988         * memattr.c (info_mem_command): Don't call gdb_flush.
3989         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3990         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3991         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3992         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3993         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3994         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3995         (gnu_nat_target::detach): Don't call gdb_flush.
3996         * f-valprint.c (f_val_print): Don't call gdb_flush.
3997         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3998         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3999         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4000         gdb_flush.
4001         * c-valprint.c (c_val_print): Don't call gdb_flush.
4002         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4003
4004 2019-03-05  Tom Tromey  <tromey@adacore.com>
4005
4006         * varobj.c (update_dynamic_varobj_children): Update.
4007         (install_default_visualizer): Use reset, not release.
4008         * value.c (set_internalvar): Update.
4009         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4010         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4011         ATTRIBUTE_UNUSED_RESULT.
4012
4013 2019-03-05  Tom Tromey  <tromey@adacore.com>
4014
4015         * remote.c (class scoped_remote_fd) <release>: Add
4016         ATTRIBUTE_UNUSED_RESULT.
4017
4018 2019-03-05  Tom Tromey  <tromey@adacore.com>
4019
4020         * macroexp.c (struct macro_buffer) <release>: Add
4021         ATTRIBUTE_UNUSED_RESULT.
4022
4023 2019-03-05  Tom Tromey  <tromey@adacore.com>
4024
4025         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4026         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4027         ATTRIBUTE_UNUSED_RESULT.
4028
4029 2019-03-05  Tom Tromey  <tromey@adacore.com>
4030
4031         * common/scoped_fd.h (class scoped_fd) <release>: Add
4032         ATTRIBUTE_UNUSED_RESULT.
4033
4034 2019-03-05  Tom Tromey  <tromey@adacore.com>
4035
4036         * parser-defs.h (struct parser_state) <release>: Add
4037         ATTRIBUTE_UNUSED_RESULT.
4038
4039 2019-03-05  Tom Tromey  <tromey@adacore.com>
4040
4041         * utils.h (class gdb_argv) <release>: Add
4042         ATTRIBUTE_UNUSED_RESULT.
4043         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4044
4045 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4046
4047         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4048         for-loop range, to avoid compiler warnings.
4049
4050         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4051         avoid compiler warnings about unused variables.
4052
4053         * NEWS: Mention end of support for native debugging on MS-Windows
4054         before XP.
4055
4056         PR gdb/24292
4057         * common/netstuff.c:
4058         * gdbserver/gdbreplay.c
4059         * gdbserver/remote-utils.c:
4060         * ser-tcp.c:
4061         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4062         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4063         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4064         'getaddrinfo' and 'freeaddrinfo' were not available before
4065         Windows XP, and mingw.org's MinGW headers by default define
4066         _WIN32_WINNT to 0x500.
4067
4068 2019-03-01  Gary Benson <gbenson@redhat.com>
4069
4070         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4071
4072 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4073             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4074
4075         PR gdb/8527
4076         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4077         set_sigint_trap, clear_sigint_trap.
4078
4079 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4080
4081         * target.c (target_detach): Clear the regcache and the
4082         frame cache.
4083
4084 2019-02-27  Pedro Alves  <palves@redhat.com>
4085
4086         * utils.c (set_screen_size): When we cap the height/width sizes,
4087         tweak the corresponding command variable to show "unlimited":
4088
4089 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4090             Pedro Alves  <palves@redhat.com>
4091
4092         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4093         before calling rl_set_screen_size.
4094
4095 2019-02-27  Tom Tromey  <tromey@adacore.com>
4096
4097         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4098         define.
4099         * python/py-value.c: Remove Python 2.4 workaround.
4100         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4101         workaround.
4102         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4103         Python 2.4 workaround.
4104         * python/python-internal.h: Remove Python 2.4 comment.
4105         (Py_ssize_t): Don't define.
4106         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4107         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4108         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4109         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4110         * python/python.c (do_start_initialization): Remove Python 2.4
4111         workaround.
4112         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4113         (print_children): Remove Python 2.4 workaround.
4114         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4115         workaround.
4116         (CHARBUFFERPROC_NAME): Remove.
4117         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4118         Python 2.4 workaround.
4119
4120 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4121
4122         * NEWS: Note minimum Python version.
4123
4124 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4125
4126         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4127         code from these functions.  Remove corresponding ifdefs.  Use
4128         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4129         Remove gotos and target of gotos.
4130         (infpy_search_memory): Likewise.
4131
4132 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4135         (hppa_gdbarch_init): Don't register deleted functions with
4136         gdbarch.
4137
4138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4141         (h8300_unwind_sp): Delete.
4142         (h8300_dummy_id): Delete.
4143         (h8300_gdbarch_init): Don't register deleted functions with
4144         gdbarch.
4145
4146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4149         (ft32_unwind_pc): Delete.
4150         (ft32_unwind_sp): Delete.
4151         (ft32_gdbarch_init): Don't register deleted functions with
4152         gdbarch.
4153
4154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4155
4156         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4157         (frv_unwind_pc): Delete.
4158         (frv_unwind_sp): Delete.
4159         (frv_gdbarch_init): Don't register deleted functions with
4160         gdbarch.
4161
4162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4165         (riscv_unwind_pc): Delete.
4166         (riscv_unwind_sp): Delete.
4167         (riscv_gdbarch_init): Don't register deleted functions with
4168         gdbarch.
4169
4170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4171
4172         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4173         (csky_unwind_pc): Delete.
4174         (csky_unwind_sp): Delete.
4175         (csky_gdbarch_init): Don't register deleted functions with
4176         gdbarch.
4177
4178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4179
4180         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4181         (cris_unwind_pc): Delete.
4182         (cris_unwind_sp): Delete.
4183         (cris_gdbarch_init): Don't register deleted functions with
4184         gdbarch.
4185
4186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4187
4188         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4189         (bfin_unwind_pc): Delete.
4190         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4191
4192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4193
4194         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4195         (arm_unwind_pc): Delete.
4196         (arm_unwind_sp): Delete.
4197         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4198
4199 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4202         (arc_unwind_pc): Delete.
4203         (arc_unwind_sp): Delete.
4204         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4205
4206 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4209         (alpha_unwind_pc): Delete.
4210         (alpha_gdbarch_init): Don't register deleted functions with
4211         gdbarch.
4212
4213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4216         (aarch64_unwind_pc): Delete.
4217         (aarch64_unwind_sp): Delete.
4218         (aarch64_gdbarch_init): Don't register deleted functions with
4219         gdbarch.
4220
4221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4222
4223         * gdbtypes.c (type_align): Don't consider static members when
4224         computing structure alignment.
4225
4226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4227
4228         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4229         return 0 for other types.
4230         * arch-utils.c (default_type_align): Always return 0.
4231         * gdbarch.h: Regenerate.
4232         * gdbarch.sh (type_align): Extend comment.
4233         * gdbtypes.c (type_align): Add additional comments, always call
4234         gdbarch_type_align before applying the default rules.
4235         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4236         generic code will then apply a suitable default.
4237         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4238         types, return 0 for other types.
4239
4240 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4241
4242         * NEWS: Create a new section for the next release branch.
4243         Rename the section of the current branch, now that it has
4244         been cut.
4245
4246 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4247
4248         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4249         * version.in: Bump version to 8.3.50.DATE-git.
4250
4251 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4252
4253         * aix-thread.c (ptid_cmp): Remove unused variable.
4254         (get_signaled_thread): Likewise.
4255         (store_regs_user_thread): Likewise.
4256         (store_regs_kernel_thread): Likewise.
4257         (fetch_regs_kernel_thread): Remove shadowed variable.
4258
4259 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * features/riscv/32bit-cpu.xml: Add register numbers.
4262         * features/riscv/32bit-fpu.c: Regenerate.
4263         * features/riscv/32bit-fpu.xml: Add register numbers.
4264         * features/riscv/64bit-cpu.xml: Add register numbers.
4265         * features/riscv/64bit-fpu.c: Regenerate.
4266         * features/riscv/64bit-fpu.xml: Add register numbers.
4267
4268 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4269
4270         * NEWS: Mention two argument form of gdb.Value constructor.
4271         * python/py-value.c (convert_buffer_and_type_to_value): New
4272         function.
4273         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4274         Add support for handling an optional second argument.  Call
4275         convert_buffer_and_type_to_value as appropriate.
4276         * python/python-internal.h (Py_buffer_deleter): New struct.
4277         (Py_buffer_up): New typedef.
4278
4279 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4280
4281         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4282         instead of releasing ownership.
4283
4284 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4285
4286         * dwarf2read.c (open_and_init_dwp_file): Call
4287         elf_numsections instead of bfd_count_sections to initialize
4288         dwp_file->num_sections.
4289
4290 2019-02-25  Tom Tromey  <tromey@adacore.com>
4291
4292         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4293
4294 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4295
4296         * gcore.in: Add '--readnever' option when invoking GDB.
4297
4298 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4299
4300         * MAINTAINERS: Update my email address.
4301
4302 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4303
4304         * build-id.c (build_id_to_debug_bfd_1): New function.
4305         (build_id_to_debug_bfd): Look for separate debug file in
4306         sysroot.
4307
4308 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4309
4310         * gdbarch.sh: Update the copyright year range that is placed into
4311         generated files.
4312
4313 2019-02-22  Keith Seitz  <keiths@redhat.com>
4314
4315         PR symtab/23853
4316         * linespec.c (create_sals_line_offset): Search for the default
4317         symtab's filename instead of its fullname.
4318
4319 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4320
4321         * NEWS: Update style defaults.
4322
4323 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4324
4325         * main.c (captured_main_1): Disable styling in batch mode.
4326
4327 2019-02-20  Tom Tromey  <tom@tromey.com>
4328
4329         * symtab.c (symtab_symbol_info): Fix typos.
4330
4331 2019-02-20  Tom Tromey  <tromey@adacore.com>
4332
4333         * findcmd.c (_initialize_mem_search): Use upper case for
4334         metasyntactic variables.
4335
4336 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4337
4338         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4339         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4340
4341 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4342
4343         * top.h (source_file_name): Change to std::string.
4344         * top.c (source_file_name): Likewise.
4345         (command_line_input): Adjust.
4346         * cli/cli-script.c (script_from_file): Adjust.
4347
4348 2019-02-19  Tom Tromey  <tromey@adacore.com>
4349
4350         * ravenscar-thread.c
4351         (ravenscar_thread_target::update_thread_list): Don't call
4352         ada_build_task_list.
4353         * ada-lang.h (ada_build_task_list): Don't declare.
4354         * ada-tasks.c (struct ada_tasks_inferior_data)
4355         <task_list_valid_p>: Now bool.
4356         (read_known_tasks, ada_task_list_changed)
4357         (ada_tasks_invalidate_inferior_data): Update.
4358         (read_known_tasks_array): Return bool.
4359         (read_known_tasks_list): Likewise.
4360         (read_known_tasks): Return void.
4361         (ada_build_task_list): Now static.
4362
4363 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4364
4365         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4366         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4367
4368 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4369
4370         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4371         variant for ada_tasks_pspace_data_handle and
4372         ada_tasks_inferior_data_handle.
4373         (ada_tasks_pspace_data_cleanup): New function.
4374         (ada_tasks_inferior_data_cleanup): New function.
4375
4376 2019-02-17  Tom Tromey  <tom@tromey.com>
4377
4378         * macrotab.h (macro_source_fullname): Return a std::string.
4379         * macrotab.c (macro_include, check_for_redefinition)
4380         (macro_undef, macro_lookup_definition, foreach_macro)
4381         (foreach_macro_in_scope): Update.
4382         (macro_source_fullname): Return a std::string.
4383         * macrocmd.c (show_pp_source_pos): Update.
4384
4385 2019-02-17  Tom Tromey  <tom@tromey.com>
4386
4387         * macrocmd.c (show_pp_source_pos): Style the file names.
4388
4389 2019-02-17  Tom Tromey  <tom@tromey.com>
4390
4391         PR tui/24197:
4392         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4393
4394 2019-02-17  Tom Tromey  <tom@tromey.com>
4395
4396         * ada-lang.c (user_select_syms): Use filtered printing.
4397         * utils.c (wrap_style): New global.
4398         (desired_style): Remove.
4399         (emit_style_escape): Add stream parameter.
4400         (set_output_style, reset_terminal_style, prompt_for_continue):
4401         Update.
4402         (flush_wrap_buffer): Only flush gdb_stdout.
4403         (wrap_here): Set wrap_style.
4404         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4405         treat escape sequences as a character.  Change when wrap buffer is
4406         flushed.
4407         (fputs_styled): Do not set the output style when the default is
4408         requested.
4409         * ui-style.h (struct ui_file_style) <is_default>: New method.
4410         * source.c (print_source_lines_base): Emit escape sequences in one
4411         piece.
4412
4413 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4414
4415         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4416         integers and enumeration types.
4417
4418 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4419
4420         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4421         instead of lookup_symbol_in_language
4422         (do_exact_match): New function.
4423         (ada_get_symbol_name_matcher): Return do_exact_match when
4424         doing a verbatim match.
4425
4426 2019-02-15  Tom Tromey  <tromey@adacore.com>
4427
4428         * ravenscar-thread.c (ravenscar_thread_target::resume)
4429         (ravenscar_thread_target::wait): Special case wildcard requests.
4430
4431 2019-02-15  Tom Tromey  <tromey@adacore.com>
4432
4433         * ravenscar-thread.c (base_ptid): Remove.
4434         (struct ravenscar_thread_target) <close>: New method.
4435         <m_base_ptid>: New member.
4436         <update_inferior_ptid, active_task, task_is_currently_active,
4437         runtime_initialized>: Declare methods.
4438         <ravenscar_thread_target>: Add constructor.
4439         (ravenscar_thread_target::task_is_currently_active)
4440         (ravenscar_thread_target::update_inferior_ptid)
4441         (ravenscar_runtime_initialized): Rename.  Now methods.
4442         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4443         (ravenscar_thread_target::update_thread_list): Update.
4444         (ravenscar_thread_target::active_task): Now method.
4445         (ravenscar_thread_target::store_registers)
4446         (ravenscar_thread_target::prepare_to_store)
4447         (ravenscar_thread_target::prepare_to_store)
4448         (ravenscar_thread_target::mourn_inferior): Update.
4449         (ravenscar_inferior_created): Use "new" to create target.
4450         (ravenscar_thread_target::get_ada_task_ptid): Update.
4451         (_initialize_ravenscar): Don't initialize base_ptid.
4452         (ravenscar_ops): Remove global.
4453
4454 2019-02-15  Tom Tromey  <tromey@adacore.com>
4455
4456         * target.h (push_target): Declare new overload.
4457         * target.c (push_target): New overload, taking an rvalue reference.
4458         * remote.c (remote_target::open_1): Use push_target overload.
4459         * corelow.c (core_target_open): Use push_target overload.
4460
4461 2019-02-15  Tom Tromey  <tromey@adacore.com>
4462
4463         * ravenscar-thread.c (is_ravenscar_task)
4464         (ravenscar_task_is_currently_active): Return bool.
4465         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4466         (_initialize_ravenscar): Remove "(void)".
4467         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4468         Return bool.
4469
4470 2019-02-15  Tom Tromey  <tromey@adacore.com>
4471
4472         * ravenscar-thread.c (ravenscar_runtime_initializer)
4473         (has_ravenscar_runtime, get_running_thread_id)
4474         (ravenscar_thread_target::resume): Fix indentation.
4475
4476 2019-02-15  Tom Tromey  <tromey@adacore.com>
4477
4478         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4479         from ravenscar_arch_ops.
4480         (sparc_ravenscar_ops::fetch_registers)
4481         (sparc_ravenscar_ops::store_registers): Now methods.
4482         (sparc_ravenscar_prepare_to_store): Remove.
4483         (sparc_ravenscar_ops): Redefine.
4484         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4485         methods and destructor.  Remove members.
4486         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4487         (ravenscar_thread_target::store_registers)
4488         (ravenscar_thread_target::prepare_to_store): Update.
4489         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4490         Remove.
4491         (struct ppc_ravenscar_powerpc_ops): Derive from
4492         ravenscar_arch_ops.
4493         (ppc_ravenscar_powerpc_ops::fetch_registers)
4494         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4495         (ppc_ravenscar_powerpc_ops): Redefine.
4496         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4497         (ppc_ravenscar_e500_ops::fetch_registers)
4498         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4499         (ppc_ravenscar_e500_ops): Redefine.
4500         * aarch64-ravenscar-thread.c
4501         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4502         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4503         (aarch64_ravenscar_fetch_registers)
4504         (aarch64_ravenscar_store_registers): Now methods.
4505         (aarch64_ravenscar_ops): Redefine.
4506
4507 2019-02-15  Tom Tromey  <tromey@adacore.com>
4508
4509         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4510         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4511         (ravenscar_thread_target::stopped_by_watchpoint)
4512         (ravenscar_thread_target::stopped_data_address)
4513         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4514
4515 2019-02-15  Tom Tromey  <tromey@adacore.com>
4516
4517         * ravenscar-thread.c: Fix some typos.
4518
4519 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4520             Tom Tromey  <tromey@adacore.com>
4521
4522         * ada-lang.c (ada_exception_sal): Change addr_string to a
4523         std::string.
4524         (create_ada_exception_catchpoint): Update.
4525
4526 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4527             Tom Tromey  <tromey@adacore.com>
4528
4529         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4530         (bp_location_ops): Remove.
4531         (base_breakpoint_allocate_location): Update.
4532         (free_bp_location): Update.
4533         * ada-lang.c (class ada_catchpoint_location)
4534         <ada_catchpoint_location>: Remove ops parameter.
4535         (ada_catchpoint_location_dtor): Remove.
4536         (ada_catchpoint_location_ops): Remove.
4537         (allocate_location_exception): Update.
4538         * breakpoint.h (struct bp_location_ops): Remove.
4539         (class bp_location) <bp_location>: Remove bp_location_ops
4540         parameter.
4541         <~bp_location>: Add destructor.
4542         <ops>: Remove.
4543
4544 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4545             Pedro Alves  <palves@redhat.com>
4546
4547         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4548         'PATH_MAX'.
4549
4550 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4551             Samuel Thibault  <samuel.thibault@gnu.org>
4552             Thomas Schwinge  <thomas@codesourcery.com>
4553
4554         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4555         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4556
4557 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4558
4559         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4560         (check_empty): Use "const char *".
4561
4562         * gnu-nat.c (gnu_nat_target::detach): Instead of
4563         'detach_inferior (pid)' call
4564         'detach_inferior (find_inferior_pid (pid))'.
4565
4566         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4567         'nat/fork-inferior.o'.
4568         * gnu-nat.c: #include "nat/fork-inferior.h".
4569
4570         * gnu-nat.c (gnu_nat_target::detach): Instead of
4571         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4572         * gnu-nat.h: #include "inf-child.h".
4573         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4574         'i386_gnu_nat_target::fetch_registers'.
4575         (gnu_store_registers): Rename/move to
4576         'i386_gnu_nat_target::store_registers'.
4577
4578         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4579         * gnu-nat.h (mach_thread_info): New function.
4580         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4581
4582         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4583
4584 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4585
4586         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4587
4588 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4589
4590         * windows-nat.c (windows_add_thread): Add new parameter
4591         "main_thread_p" with default value set to false.  Update
4592         function documentation as well as all callers.
4593         (windows_delete_thread): Likewise.
4594         (fake_create_process): Update call to windows_add_thread.
4595         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4596         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4597         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4598         call to windows_delete_thread.
4599
4600 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4601
4602         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4603
4604 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4605
4606         * symfile.c (find_separate_debug_file): Use canonical path of
4607         sysroot with child_path instead of gdb_sysroot if it is valid.
4608
4609 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4610
4611         * symfile.c (find_separate_debug_file): Use child_path to
4612         determine if an object file is under a sysroot.
4613
4614 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4615
4616         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4617         unittests/child-path-selftests.c.
4618         * common/pathstuff.c (child_path): New function.
4619         * common/pathstuff.h (child_path): New prototype.
4620         * unittests/child-path-selftests.c: New file.
4621
4622 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4623
4624         * symfile.c (find_separate_debug_file): Look for separate debug
4625         files in debug directories under the sysroot.
4626
4627 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4628
4629         * symtab.h (struct minimal_symbol data_p): New const method.
4630         (struct minimal_symbol text_p): Likewise.
4631         * symtab.c (output_source_filename): Use file name style
4632         to print file name.
4633         (print_symbol_info): Likewise.
4634         (print_msymbol_info): Use address style to print addresses.
4635         Use function name style to print executable text symbols.
4636         (expand_symtab_containing_pc): Use data_p.
4637         (find_pc_sect_compunit_symtab): Likewise.
4638
4639 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4640
4641         * breakpoint.c (describe_other_breakpoints): Use address style
4642         to print addresses.
4643         (say_where): Likewise.
4644
4645 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4646
4647         * ada-typeprint.c (print_func_type): Print function name
4648         style to print function name.
4649         * c-typeprint.c (c_print_type_1): Likewise.
4650
4651 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4652
4653         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4654         for execve.
4655
4656 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4657
4658         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4659         type_stack.
4660
4661 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4662
4663         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4664         TYPE_CODE_REF types.
4665
4666 2019-02-08  Jim Wilson  <jimw@sifive.com>
4667
4668         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4669         (riscv_linux_fregset): New.
4670         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4671
4672 2019-02-07  Tom Tromey  <tom@tromey.com>
4673
4674         * thread.c (thread_cancel_execution_command): Update.
4675         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4676         methods.
4677         (struct thread_fsm_ops): Remove.
4678         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4679         (thread_fsm_should_stop, thread_fsm_return_value)
4680         (thread_fsm_set_finished, thread_fsm_finished_p)
4681         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4682         Don't declare.
4683         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4684         * infrun.c (clear_proceed_status_thread)
4685         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4686         (print_stop_event): Update.
4687         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4688         Add constructor.
4689         (step_command_fsm_ops): Remove.
4690         (new_step_command_fsm): Remove.
4691         (step_1): Update.
4692         (step_command_fsm::should_stop): Rename from
4693         step_command_fsm_should_stop.
4694         (step_command_fsm::clean_up): Rename from
4695         step_command_fsm_clean_up.
4696         (step_command_fsm::do_async_reply_reason): Rename from
4697         step_command_fsm_async_reply_reason.
4698         (struct until_next_fsm): Inherit from thread_fsm.  Add
4699         constructor.
4700         (until_next_fsm_ops): Remove.
4701         (new_until_next_fsm): Remove.
4702         (until_next_fsm::should_stop): Rename from
4703         until_next_fsm_should_stop.
4704         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4705         (until_next_fsm::do_async_reply_reason): Rename from
4706         until_next_fsm_async_reply_reason.
4707         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4708         constructor.  Change type of breakpoint.
4709         (finish_command_fsm_ops): Remove.
4710         (new_finish_command_fsm): Remove.
4711         (finish_command_fsm::should_stop): Rename from
4712         finish_command_fsm_should_stop.
4713         (finish_command_fsm::clean_up): Rename from
4714         finish_command_fsm_clean_up.
4715         (finish_command_fsm::return_value): Rename from
4716         finish_command_fsm_return_value.
4717         (finish_command_fsm::do_async_reply_reason): Rename from
4718         finish_command_fsm_async_reply_reason.
4719         (finish_command): Update.
4720         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4721         Add constructor.
4722         (call_thread_fsm_ops): Remove.
4723         (call_thread_fsm::call_thread_fsm): Rename from
4724         new_call_thread_fsm.
4725         (call_thread_fsm::should_stop): Rename from
4726         call_thread_fsm_should_stop.
4727         (call_thread_fsm::should_notify_stop): Rename from
4728         call_thread_fsm_should_notify_stop.
4729         (run_inferior_call, call_function_by_hand_dummy): Update.
4730         * cli/cli-interp.c (should_print_stop_to_console): Update.
4731         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4732         Add constructor.  Change type of location_breakpoint,
4733         caller_breakpoint.
4734         (until_break_fsm_ops): Remove.
4735         (new_until_break_fsm): Remove.
4736         (until_break_fsm::should_stop): Rename from
4737         until_break_fsm_should_stop.
4738         (until_break_fsm::clean_up): Rename from
4739         until_break_fsm_clean_up.
4740         (until_break_fsm::do_async_reply_reason): Rename from
4741         until_break_fsm_async_reply_reason.
4742         (until_break_command): Update.
4743         * thread-fsm.c: Remove.
4744         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4745
4746 2019-02-07  Tom Tromey  <tom@tromey.com>
4747
4748         * yy-remap.h: Add include guard.
4749         * xtensa-tdep.h: Add include guard.
4750         * xcoffread.h: Rename include guard.
4751         * varobj-iter.h: Add include guard.
4752         * tui/tui.h: Rename include guard.
4753         * tui/tui-winsource.h: Rename include guard.
4754         * tui/tui-wingeneral.h: Rename include guard.
4755         * tui/tui-windata.h: Rename include guard.
4756         * tui/tui-win.h: Rename include guard.
4757         * tui/tui-stack.h: Rename include guard.
4758         * tui/tui-source.h: Rename include guard.
4759         * tui/tui-regs.h: Rename include guard.
4760         * tui/tui-out.h: Rename include guard.
4761         * tui/tui-layout.h: Rename include guard.
4762         * tui/tui-io.h: Rename include guard.
4763         * tui/tui-hooks.h: Rename include guard.
4764         * tui/tui-file.h: Rename include guard.
4765         * tui/tui-disasm.h: Rename include guard.
4766         * tui/tui-data.h: Rename include guard.
4767         * tui/tui-command.h: Rename include guard.
4768         * tic6x-tdep.h: Add include guard.
4769         * target/waitstatus.h: Rename include guard.
4770         * target/wait.h: Rename include guard.
4771         * target/target.h: Rename include guard.
4772         * target/resume.h: Rename include guard.
4773         * target-float.h: Rename include guard.
4774         * stabsread.h: Add include guard.
4775         * rs6000-tdep.h: Add include guard.
4776         * riscv-fbsd-tdep.h: Add include guard.
4777         * regformats/regdef.h: Rename include guard.
4778         * record.h: Rename include guard.
4779         * python/python.h: Rename include guard.
4780         * python/python-internal.h: Rename include guard.
4781         * python/py-stopevent.h: Rename include guard.
4782         * python/py-ref.h: Rename include guard.
4783         * python/py-record.h: Rename include guard.
4784         * python/py-record-full.h: Rename include guard.
4785         * python/py-record-btrace.h: Rename include guard.
4786         * python/py-instruction.h: Rename include guard.
4787         * python/py-events.h: Rename include guard.
4788         * python/py-event.h: Rename include guard.
4789         * procfs.h: Add include guard.
4790         * proc-utils.h: Add include guard.
4791         * p-lang.h: Add include guard.
4792         * or1k-tdep.h: Rename include guard.
4793         * observable.h: Rename include guard.
4794         * nto-tdep.h: Rename include guard.
4795         * nat/x86-linux.h: Rename include guard.
4796         * nat/x86-linux-dregs.h: Rename include guard.
4797         * nat/x86-gcc-cpuid.h: Add include guard.
4798         * nat/x86-dregs.h: Rename include guard.
4799         * nat/x86-cpuid.h: Rename include guard.
4800         * nat/ppc-linux.h: Rename include guard.
4801         * nat/mips-linux-watch.h: Rename include guard.
4802         * nat/linux-waitpid.h: Rename include guard.
4803         * nat/linux-ptrace.h: Rename include guard.
4804         * nat/linux-procfs.h: Rename include guard.
4805         * nat/linux-osdata.h: Rename include guard.
4806         * nat/linux-nat.h: Rename include guard.
4807         * nat/linux-namespaces.h: Rename include guard.
4808         * nat/linux-btrace.h: Rename include guard.
4809         * nat/glibc_thread_db.h: Rename include guard.
4810         * nat/gdb_thread_db.h: Rename include guard.
4811         * nat/gdb_ptrace.h: Rename include guard.
4812         * nat/fork-inferior.h: Rename include guard.
4813         * nat/amd64-linux-siginfo.h: Rename include guard.
4814         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4815         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4816         * nat/aarch64-linux.h: Rename include guard.
4817         * nat/aarch64-linux-hw-point.h: Rename include guard.
4818         * mn10300-tdep.h: Add include guard.
4819         * mips-linux-tdep.h: Add include guard.
4820         * mi/mi-parse.h: Rename include guard.
4821         * mi/mi-out.h: Rename include guard.
4822         * mi/mi-main.h: Rename include guard.
4823         * mi/mi-interp.h: Rename include guard.
4824         * mi/mi-getopt.h: Rename include guard.
4825         * mi/mi-console.h: Rename include guard.
4826         * mi/mi-common.h: Rename include guard.
4827         * mi/mi-cmds.h: Rename include guard.
4828         * mi/mi-cmd-break.h: Rename include guard.
4829         * m2-lang.h: Add include guard.
4830         * location.h: Rename include guard.
4831         * linux-record.h: Rename include guard.
4832         * linux-nat.h: Add include guard.
4833         * linux-fork.h: Add include guard.
4834         * i386-darwin-tdep.h: Rename include guard.
4835         * hppa-linux-offsets.h: Add include guard.
4836         * guile/guile.h: Rename include guard.
4837         * guile/guile-internal.h: Rename include guard.
4838         * gnu-nat.h: Rename include guard.
4839         * gdb-stabs.h: Rename include guard.
4840         * frv-tdep.h: Add include guard.
4841         * f-lang.h: Add include guard.
4842         * event-loop.h: Add include guard.
4843         * darwin-nat.h: Rename include guard.
4844         * cp-abi.h: Rename include guard.
4845         * config/sparc/nm-sol2.h: Rename include guard.
4846         * config/nm-nto.h: Rename include guard.
4847         * config/nm-linux.h: Add include guard.
4848         * config/i386/nm-i386gnu.h: Rename include guard.
4849         * config/djgpp/nl_types.h: Rename include guard.
4850         * config/djgpp/langinfo.h: Rename include guard.
4851         * compile/gcc-cp-plugin.h: Add include guard.
4852         * compile/gcc-c-plugin.h: Add include guard.
4853         * compile/compile.h: Rename include guard.
4854         * compile/compile-object-run.h: Rename include guard.
4855         * compile/compile-object-load.h: Rename include guard.
4856         * compile/compile-internal.h: Rename include guard.
4857         * compile/compile-cplus.h: Rename include guard.
4858         * compile/compile-c.h: Rename include guard.
4859         * common/xml-utils.h: Rename include guard.
4860         * common/x86-xstate.h: Rename include guard.
4861         * common/version.h: Rename include guard.
4862         * common/vec.h: Rename include guard.
4863         * common/tdesc.h: Rename include guard.
4864         * common/selftest.h: Rename include guard.
4865         * common/scoped_restore.h: Rename include guard.
4866         * common/scoped_mmap.h: Rename include guard.
4867         * common/scoped_fd.h: Rename include guard.
4868         * common/safe-iterator.h: Rename include guard.
4869         * common/run-time-clock.h: Rename include guard.
4870         * common/refcounted-object.h: Rename include guard.
4871         * common/queue.h: Rename include guard.
4872         * common/ptid.h: Rename include guard.
4873         * common/print-utils.h: Rename include guard.
4874         * common/preprocessor.h: Rename include guard.
4875         * common/pathstuff.h: Rename include guard.
4876         * common/observable.h: Rename include guard.
4877         * common/netstuff.h: Rename include guard.
4878         * common/job-control.h: Rename include guard.
4879         * common/host-defs.h: Rename include guard.
4880         * common/gdb_wait.h: Rename include guard.
4881         * common/gdb_vecs.h: Rename include guard.
4882         * common/gdb_unlinker.h: Rename include guard.
4883         * common/gdb_unique_ptr.h: Rename include guard.
4884         * common/gdb_tilde_expand.h: Rename include guard.
4885         * common/gdb_sys_time.h: Rename include guard.
4886         * common/gdb_string_view.h: Rename include guard.
4887         * common/gdb_splay_tree.h: Rename include guard.
4888         * common/gdb_setjmp.h: Rename include guard.
4889         * common/gdb_ref_ptr.h: Rename include guard.
4890         * common/gdb_optional.h: Rename include guard.
4891         * common/gdb_locale.h: Rename include guard.
4892         * common/gdb_assert.h: Rename include guard.
4893         * common/filtered-iterator.h: Rename include guard.
4894         * common/filestuff.h: Rename include guard.
4895         * common/fileio.h: Rename include guard.
4896         * common/environ.h: Rename include guard.
4897         * common/common-utils.h: Rename include guard.
4898         * common/common-types.h: Rename include guard.
4899         * common/common-regcache.h: Rename include guard.
4900         * common/common-inferior.h: Rename include guard.
4901         * common/common-gdbthread.h: Rename include guard.
4902         * common/common-exceptions.h: Rename include guard.
4903         * common/common-defs.h: Rename include guard.
4904         * common/common-debug.h: Rename include guard.
4905         * common/cleanups.h: Rename include guard.
4906         * common/buffer.h: Rename include guard.
4907         * common/btrace-common.h: Rename include guard.
4908         * common/break-common.h: Rename include guard.
4909         * cli/cli-utils.h: Rename include guard.
4910         * cli/cli-style.h: Rename include guard.
4911         * cli/cli-setshow.h: Rename include guard.
4912         * cli/cli-script.h: Rename include guard.
4913         * cli/cli-interp.h: Rename include guard.
4914         * cli/cli-decode.h: Rename include guard.
4915         * cli/cli-cmds.h: Rename include guard.
4916         * charset-list.h: Add include guard.
4917         * buildsym-legacy.h: Rename include guard.
4918         * bfin-tdep.h: Add include guard.
4919         * ax.h: Rename include guard.
4920         * arm-linux-tdep.h: Add include guard.
4921         * arm-fbsd-tdep.h: Add include guard.
4922         * arch/xtensa.h: Rename include guard.
4923         * arch/tic6x.h: Add include guard.
4924         * arch/i386.h: Add include guard.
4925         * arch/arm.h: Rename include guard.
4926         * arch/arm-linux.h: Rename include guard.
4927         * arch/arm-get-next-pcs.h: Rename include guard.
4928         * arch/amd64.h: Add include guard.
4929         * arch/aarch64-insn.h: Rename include guard.
4930         * arch-utils.h: Rename include guard.
4931         * annotate.h: Add include guard.
4932         * amd64-darwin-tdep.h: Rename include guard.
4933         * aarch64-linux-tdep.h: Add include guard.
4934         * aarch64-fbsd-tdep.h: Add include guard.
4935         * aarch32-linux-nat.h: Add include guard.
4936
4937 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4938
4939         * macrotab.c (macro_define_internal): New function that
4940         factorizes macro_define_object_internal and macro_define_function
4941         code.
4942         (macro_define_object_internal): Use macro_define_internal.
4943         (macro_define_function): Likewise.
4944
4945 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4946
4947         * macrocmd.c (extract_identifier): Return
4948         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4949         callers.
4950
4951 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4952
4953         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4954
4955 2019-02-05  Tom Tromey  <tom@tromey.com>
4956
4957         * target.c (target_stack::unpush): Move assertion earlier.
4958
4959 2019-01-30  Tom Tromey  <tom@tromey.com>
4960
4961         PR python/23615:
4962         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4963         (gdbpy_parse_and_eval): Likewise.
4964         * python/python-internal.h (gdbpy_allow_threads): New class.
4965
4966 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4967
4968         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4969         (aarch64_fbsd_fpregmap): Move earlier.
4970         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4971         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4972         instead of individual calls to trad_frame_set_reg_addr.
4973         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4974         earlier.
4975         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4976         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4977         instead of individual calls to trad_frame_set_reg_addr.
4978
4979 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4980
4981         * CONTRIBUTE: Replace contribution list with wiki link.
4982
4983 2019-01-25  Tom Tromey  <tom@tromey.com>
4984
4985         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4986
4987 2019-01-25  Tom Tromey  <tom@tromey.com>
4988
4989         * xtensa-linux-nat.c: Fix common/ includes.
4990         * xml-support.h: Fix common/ includes.
4991         * xml-support.c: Fix common/ includes.
4992         * x86-linux-nat.c: Fix common/ includes.
4993         * windows-nat.c: Fix common/ includes.
4994         * varobj.h: Fix common/ includes.
4995         * varobj.c: Fix common/ includes.
4996         * value.c: Fix common/ includes.
4997         * valops.c: Fix common/ includes.
4998         * utils.c: Fix common/ includes.
4999         * unittests/xml-utils-selftests.c: Fix common/ includes.
5000         * unittests/utils-selftests.c: Fix common/ includes.
5001         * unittests/unpack-selftests.c: Fix common/ includes.
5002         * unittests/tracepoint-selftests.c: Fix common/ includes.
5003         * unittests/style-selftests.c: Fix common/ includes.
5004         * unittests/string_view-selftests.c: Fix common/ includes.
5005         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5006         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5007         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5008         * unittests/rsp-low-selftests.c: Fix common/ includes.
5009         * unittests/parse-connection-spec-selftests.c: Fix common/
5010         includes.
5011         * unittests/optional-selftests.c: Fix common/ includes.
5012         * unittests/offset-type-selftests.c: Fix common/ includes.
5013         * unittests/observable-selftests.c: Fix common/ includes.
5014         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5015         * unittests/memrange-selftests.c: Fix common/ includes.
5016         * unittests/memory-map-selftests.c: Fix common/ includes.
5017         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5018         * unittests/function-view-selftests.c: Fix common/ includes.
5019         * unittests/environ-selftests.c: Fix common/ includes.
5020         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5021         * unittests/common-utils-selftests.c: Fix common/ includes.
5022         * unittests/cli-utils-selftests.c: Fix common/ includes.
5023         * unittests/array-view-selftests.c: Fix common/ includes.
5024         * ui-file.c: Fix common/ includes.
5025         * tui/tui-io.c: Fix common/ includes.
5026         * tracepoint.h: Fix common/ includes.
5027         * tracepoint.c: Fix common/ includes.
5028         * tracefile-tfile.c: Fix common/ includes.
5029         * top.h: Fix common/ includes.
5030         * top.c: Fix common/ includes.
5031         * thread.c: Fix common/ includes.
5032         * target/waitstatus.h: Fix common/ includes.
5033         * target/waitstatus.c: Fix common/ includes.
5034         * target.h: Fix common/ includes.
5035         * target.c: Fix common/ includes.
5036         * target-memory.c: Fix common/ includes.
5037         * target-descriptions.c: Fix common/ includes.
5038         * symtab.h: Fix common/ includes.
5039         * symfile.c: Fix common/ includes.
5040         * stap-probe.c: Fix common/ includes.
5041         * spu-linux-nat.c: Fix common/ includes.
5042         * sparc-nat.c: Fix common/ includes.
5043         * source.c: Fix common/ includes.
5044         * solib.c: Fix common/ includes.
5045         * solib-target.c: Fix common/ includes.
5046         * ser-unix.c: Fix common/ includes.
5047         * ser-tcp.c: Fix common/ includes.
5048         * ser-pipe.c: Fix common/ includes.
5049         * ser-base.c: Fix common/ includes.
5050         * selftest-arch.c: Fix common/ includes.
5051         * s12z-tdep.c: Fix common/ includes.
5052         * rust-exp.y: Fix common/ includes.
5053         * rs6000-aix-tdep.c: Fix common/ includes.
5054         * riscv-tdep.c: Fix common/ includes.
5055         * remote.c: Fix common/ includes.
5056         * remote-notif.h: Fix common/ includes.
5057         * remote-fileio.h: Fix common/ includes.
5058         * remote-fileio.c: Fix common/ includes.
5059         * regcache.h: Fix common/ includes.
5060         * regcache.c: Fix common/ includes.
5061         * record-btrace.c: Fix common/ includes.
5062         * python/python.c: Fix common/ includes.
5063         * python/py-type.c: Fix common/ includes.
5064         * python/py-inferior.c: Fix common/ includes.
5065         * progspace.h: Fix common/ includes.
5066         * producer.c: Fix common/ includes.
5067         * procfs.c: Fix common/ includes.
5068         * proc-api.c: Fix common/ includes.
5069         * printcmd.c: Fix common/ includes.
5070         * ppc-linux-nat.c: Fix common/ includes.
5071         * parser-defs.h: Fix common/ includes.
5072         * osdata.c: Fix common/ includes.
5073         * obsd-nat.c: Fix common/ includes.
5074         * nat/x86-linux.c: Fix common/ includes.
5075         * nat/x86-linux-dregs.c: Fix common/ includes.
5076         * nat/x86-dregs.h: Fix common/ includes.
5077         * nat/x86-dregs.c: Fix common/ includes.
5078         * nat/ppc-linux.c: Fix common/ includes.
5079         * nat/mips-linux-watch.h: Fix common/ includes.
5080         * nat/mips-linux-watch.c: Fix common/ includes.
5081         * nat/linux-waitpid.c: Fix common/ includes.
5082         * nat/linux-ptrace.h: Fix common/ includes.
5083         * nat/linux-ptrace.c: Fix common/ includes.
5084         * nat/linux-procfs.c: Fix common/ includes.
5085         * nat/linux-personality.c: Fix common/ includes.
5086         * nat/linux-osdata.c: Fix common/ includes.
5087         * nat/linux-namespaces.c: Fix common/ includes.
5088         * nat/linux-btrace.h: Fix common/ includes.
5089         * nat/linux-btrace.c: Fix common/ includes.
5090         * nat/fork-inferior.c: Fix common/ includes.
5091         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5092         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5093         * nat/aarch64-linux.c: Fix common/ includes.
5094         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5095         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5096         * namespace.h: Fix common/ includes.
5097         * mips-linux-tdep.c: Fix common/ includes.
5098         * minsyms.c: Fix common/ includes.
5099         * mi/mi-parse.h: Fix common/ includes.
5100         * mi/mi-main.c: Fix common/ includes.
5101         * mi/mi-cmd-env.c: Fix common/ includes.
5102         * memrange.h: Fix common/ includes.
5103         * memattr.c: Fix common/ includes.
5104         * maint.h: Fix common/ includes.
5105         * maint.c: Fix common/ includes.
5106         * main.c: Fix common/ includes.
5107         * machoread.c: Fix common/ includes.
5108         * location.c: Fix common/ includes.
5109         * linux-thread-db.c: Fix common/ includes.
5110         * linux-nat.c: Fix common/ includes.
5111         * linux-fork.c: Fix common/ includes.
5112         * inline-frame.c: Fix common/ includes.
5113         * infrun.c: Fix common/ includes.
5114         * inflow.c: Fix common/ includes.
5115         * inferior.h: Fix common/ includes.
5116         * inferior.c: Fix common/ includes.
5117         * infcmd.c: Fix common/ includes.
5118         * inf-ptrace.c: Fix common/ includes.
5119         * inf-child.c: Fix common/ includes.
5120         * ia64-linux-nat.c: Fix common/ includes.
5121         * i387-tdep.c: Fix common/ includes.
5122         * i386-tdep.c: Fix common/ includes.
5123         * i386-linux-tdep.c: Fix common/ includes.
5124         * i386-linux-nat.c: Fix common/ includes.
5125         * i386-go32-tdep.c: Fix common/ includes.
5126         * i386-fbsd-tdep.c: Fix common/ includes.
5127         * i386-fbsd-nat.c: Fix common/ includes.
5128         * guile/scm-type.c: Fix common/ includes.
5129         * guile/guile.c: Fix common/ includes.
5130         * go32-nat.c: Fix common/ includes.
5131         * gnu-nat.c: Fix common/ includes.
5132         * gdbthread.h: Fix common/ includes.
5133         * gdbarch-selftests.c: Fix common/ includes.
5134         * gdb_usleep.c: Fix common/ includes.
5135         * gdb_select.h: Fix common/ includes.
5136         * gdb_bfd.c: Fix common/ includes.
5137         * gcore.c: Fix common/ includes.
5138         * fork-child.c: Fix common/ includes.
5139         * findvar.c: Fix common/ includes.
5140         * fbsd-nat.c: Fix common/ includes.
5141         * event-top.c: Fix common/ includes.
5142         * event-loop.c: Fix common/ includes.
5143         * dwarf2read.c: Fix common/ includes.
5144         * dwarf2loc.c: Fix common/ includes.
5145         * dwarf2-frame.c: Fix common/ includes.
5146         * dwarf-index-cache.c: Fix common/ includes.
5147         * dtrace-probe.c: Fix common/ includes.
5148         * disasm-selftests.c: Fix common/ includes.
5149         * defs.h: Fix common/ includes.
5150         * csky-tdep.c: Fix common/ includes.
5151         * cp-valprint.c: Fix common/ includes.
5152         * cp-support.h: Fix common/ includes.
5153         * cp-support.c: Fix common/ includes.
5154         * corelow.c: Fix common/ includes.
5155         * completer.h: Fix common/ includes.
5156         * completer.c: Fix common/ includes.
5157         * compile/compile.c: Fix common/ includes.
5158         * compile/compile-loc2c.c: Fix common/ includes.
5159         * compile/compile-cplus-types.c: Fix common/ includes.
5160         * compile/compile-cplus-symbols.c: Fix common/ includes.
5161         * command.h: Fix common/ includes.
5162         * cli/cli-dump.c: Fix common/ includes.
5163         * cli/cli-cmds.c: Fix common/ includes.
5164         * charset.c: Fix common/ includes.
5165         * build-id.c: Fix common/ includes.
5166         * btrace.h: Fix common/ includes.
5167         * btrace.c: Fix common/ includes.
5168         * breakpoint.h: Fix common/ includes.
5169         * breakpoint.c: Fix common/ includes.
5170         * ax.h:
5171         (enum agent_op): Fix common/ includes.
5172         * ax-general.c (struct aop_map): Fix common/ includes.
5173         * ax-gdb.c: Fix common/ includes.
5174         * auxv.c: Fix common/ includes.
5175         * auto-load.c: Fix common/ includes.
5176         * arm-tdep.c: Fix common/ includes.
5177         * arch/riscv.c: Fix common/ includes.
5178         * arch/ppc-linux-common.c: Fix common/ includes.
5179         * arch/i386.c: Fix common/ includes.
5180         * arch/arm.c: Fix common/ includes.
5181         * arch/arm-linux.c: Fix common/ includes.
5182         * arch/arm-get-next-pcs.c: Fix common/ includes.
5183         * arch/amd64.c: Fix common/ includes.
5184         * arch/aarch64.c: Fix common/ includes.
5185         * arch/aarch64-insn.c: Fix common/ includes.
5186         * arch-utils.c: Fix common/ includes.
5187         * amd64-windows-tdep.c: Fix common/ includes.
5188         * amd64-tdep.c: Fix common/ includes.
5189         * amd64-sol2-tdep.c: Fix common/ includes.
5190         * amd64-obsd-tdep.c: Fix common/ includes.
5191         * amd64-nbsd-tdep.c: Fix common/ includes.
5192         * amd64-linux-tdep.c: Fix common/ includes.
5193         * amd64-linux-nat.c: Fix common/ includes.
5194         * amd64-fbsd-tdep.c: Fix common/ includes.
5195         * amd64-fbsd-nat.c: Fix common/ includes.
5196         * amd64-dicos-tdep.c: Fix common/ includes.
5197         * amd64-darwin-tdep.c: Fix common/ includes.
5198         * agent.c: Fix common/ includes.
5199         * ada-lang.h: Fix common/ includes.
5200         * ada-lang.c: Fix common/ includes.
5201         * aarch64-tdep.c: Fix common/ includes.
5202
5203 2019-01-25  Tom Tromey  <tom@tromey.com>
5204
5205         * common/create-version.sh: Use common/version.h.
5206
5207 2019-01-24  Pedro Alves  <palves@redhat.com>
5208
5209         * infrun.c (signal_stop, signal_print, signal_program)
5210         (signal_catch, signal_pass): Now arrays instead of pointers.
5211         (update_signals_program_target, do_target_resume)
5212         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5213         * linux-nat.c (linux_nat_target::pass_signals)
5214         (linux_nat_target::create_inferior, linux_nat_target::attach):
5215         Adjust.
5216         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5217         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5218         * procfs.c (procfs_target::pass_signals): Adjust.
5219         * record-full.c (record_full_target::resume): Adjust.
5220         * remote.c (remote_target::pass_signals)
5221         (remote_target::program_signals): Adjust.
5222         * target-debug.h (target_debug_print_signals): Now takes a
5223         gdb::array_view as parameter.  Adjust.
5224         * target.h (target_ops) <pass_signals, program_signals>: Replace
5225         pointer and length parameters with gdb::array_view.
5226         (target_pass_signals, target_program_signals): Likewise.
5227         * target-delegates.c: Regenerate.
5228
5229 2019-01-24  Pedro Alves  <palves@redhat.com>
5230
5231         * common/forward-scope-exit.h
5232         (forward_scope_exit::forward_scope_exit): Pass arguments to
5233         m_bind_function directly, instead of creating a std::bind and
5234         copying that.
5235
5236 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5237
5238         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5239         for static members.
5240         (pass_in_v_vfp_candidate): Likewise.
5241
5242 2019-01-23  Tom Tromey  <tom@tromey.com>
5243             Pedro Alves  <palves@redhat.com>
5244
5245         * regcache.c (class regcache_invalidator): Remove.
5246         (regcache::raw_write): Use make_scope_exit.
5247
5248 2019-01-23  Tom Tromey  <tom@tromey.com>
5249
5250         * ui-out.h (class ui_out_emit_type): Update comment.
5251
5252 2019-01-23  Tom Tromey  <tom@tromey.com>
5253
5254         * infrun.c (fetch_inferior_event): Update comment.
5255
5256 2019-01-23  Tom Tromey  <tom@tromey.com>
5257             Pedro Alves  <palves@redhat.com>
5258
5259         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5260         parameter.
5261         (fetch_inferior_event): Use SCOPE_EXIT.
5262
5263
5264 2019-01-23  Tom Tromey  <tom@tromey.com>
5265             Pedro Alves  <palves@redhat.com>
5266
5267         * infrun.c (disable_thread_events): Delete.
5268         (stop_all_threads): Use SCOPE_EXIT.
5269
5270 2019-01-23  Tom Tromey  <tom@tromey.com>
5271             Pedro Alves  <palves@redhat.com>
5272
5273         * symfile.c: Include forward-scope-exit.h.
5274         (clear_symtab_users_cleanup): Replace forward declaration with
5275         a FORWARD_SCOPE_EXIT.
5276         (syms_from_objfile_1): Use the forward_scope_exit and
5277         gdb::optional instead of cleanup_function.
5278         (reread_symbols): Use the forward_scope_exit instead of
5279         cleanup_function.
5280         (clear_symtab_users_cleanup): Remove function.
5281
5282 2019-01-23  Tom Tromey  <tom@tromey.com>
5283             Pedro Alves  <palves@redhat.com>
5284
5285         * linux-nat.c: Include scope-exit.h.
5286         (cleanup_target_stop): Remove.
5287         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5288         SCOPE_EXIT.
5289
5290 2019-01-23  Tom Tromey  <tom@tromey.com>
5291             Pedro Alves  <palves@redhat.com>
5292
5293         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5294         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5295
5296 2019-01-23  Tom Tromey  <tom@tromey.com>
5297             Andrew Burgess  <andrew.burgess@embecosm.com>
5298             Pedro Alves  <palves@redhat.com>
5299
5300         * infrun.c (fetch_inferior_event): Use scope_exit.
5301         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5302         * top.c (execute_command): Use scope_exit.
5303         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5304         * utils.c (do_bpstat_clear_actions_cleanup)
5305         (make_bpstat_clear_actions_cleanup): Remove.
5306
5307 2019-01-23  Tom Tromey  <tom@tromey.com>
5308             Pedro Alves  <palves@redhat.com>
5309
5310         * infrun.c: Include "common/scope-exit.h"
5311         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5312         (wait_for_inferior): Use SCOPE_EXIT.
5313         (fetch_inferior_event): Use scope_exit.
5314
5315 2019-01-23  Tom Tromey  <tom@tromey.com>
5316             Pedro Alves  <palves@redhat.com>
5317
5318         * breakpoint.c (create_breakpoint): Remove cleanup.
5319
5320 2019-01-23  Tom Tromey  <tom@tromey.com>
5321             Andrew Burgess  <andrew.burgess@embecosm.com>
5322             Pedro Alves  <palves@redhat.com>
5323
5324 2019-01-23  Pedro Alves  <palves@redhat.com>
5325
5326         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5327
5328 2019-01-23  Pedro Alves  <palves@redhat.com>
5329             Andrew Burgess  <andrew.burgess@embecosm.com>
5330
5331         * gdbthread.h: Include "common/forward-scope-exit.h".
5332         (scoped_finish_thread_state): Redefine custom class in terms of
5333         forward_scope_exit.
5334
5335 2019-01-23  Pedro Alves  <palves@redhat.com>
5336             Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * common/forward-scope-exit.h: New file.
5339
5340 2019-01-23  Pedro Alves  <palves@redhat.com>
5341             Andrew Burgess  <andrew.burgess@embecosm.com>
5342             Tom Tromey  <tom@tromey.com>
5343
5344         * common/scope-exit.h: New file.
5345
5346 2019-01-23  Pedro Alves  <palves@redhat.com>
5347
5348         * common/preprocessor.h (ESC): Rename to ...
5349         (ESC_PARENS): ... this.
5350         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5351         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5352
5353 2019-01-23  Tom Tromey  <tom@tromey.com>
5354
5355         * language.h (class scoped_switch_to_sym_language_if_auto):
5356         Initialize m_lang in both cases.
5357
5358 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5359
5360         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5361         with XCNEW.
5362
5363 2019-01-22  Tom Tromey  <tom@tromey.com>
5364
5365         * corelow.c: Do not include sys/file.h.
5366
5367 2019-01-22  Tom Tromey  <tom@tromey.com>
5368
5369         * tui/tui-wingeneral.h: Include gdb_curses.h.
5370
5371 2019-01-22  Tom Tromey  <tom@tromey.com>
5372
5373         * source-cache.h (class source_cache) <get_source_lines,
5374         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5375
5376 2019-01-22  Tom Tromey  <tom@tromey.com>
5377
5378         * remote-fileio.h (struct remote_target): Declare.
5379
5380 2019-01-22  Tom Tromey  <tom@tromey.com>
5381
5382         * python/py-arch.c: Do not include py-ref.h.
5383         * python/py-bpevent.c: Do not include py-ref.h.
5384         * python/py-cmd.c: Do not include py-ref.h.
5385         * python/py-continueevent.c: Do not include py-ref.h.
5386         * python/py-event.h: Do not include py-ref.h.
5387         * python/py-evtregistry.c: Do not include py-ref.h.
5388         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5389         * python/py-frame.c: Do not include py-ref.h.
5390         * python/py-framefilter.c: Do not include py-ref.h.
5391         * python/py-function.c: Do not include py-ref.h.
5392         * python/py-infevents.c: Do not include py-ref.h.
5393         * python/py-linetable.c: Do not include py-ref.h.
5394         * python/py-objfile.c: Do not include py-ref.h.
5395         * python/py-param.c: Do not include py-ref.h.
5396         * python/py-prettyprint.c: Do not include py-ref.h.
5397         * python/py-progspace.c: Do not include py-ref.h.
5398         * python/py-symbol.c: Do not include py-ref.h.
5399         * python/py-symtab.c: Do not include py-ref.h.
5400         * python/py-type.c: Do not include py-ref.h.
5401         * python/py-unwind.c: Do not include py-ref.h.
5402         * python/py-utils.c: Do not include py-ref.h.
5403         * python/py-value.c: Do not include py-ref.h.
5404         * python/py-varobj.c: Do not include py-ref.h.
5405         * python/py-xmethods.c: Do not include py-ref.h.
5406         * python/python.c: Do not include py-ref.h.
5407         * varobj.c: Do not include py-ref.h.
5408
5409 2019-01-22  Tom Tromey  <tom@tromey.com>
5410
5411         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5412         keyword for bcache.
5413
5414 2019-01-22  Tom Tromey  <tom@tromey.com>
5415
5416         * compile/compile-cplus-types.c: Remove a comment by #include.
5417
5418 2019-01-22  Tom Tromey  <tom@tromey.com>
5419
5420         * compile/gcc-c-plugin.h: Include compile-internal.h.
5421
5422 2019-01-22  Tom Tromey  <tom@tromey.com>
5423
5424         * stabsread.c (EXTERN): Do not define.
5425         (symnum, next_symbol_text_func, processing_gcc_compilation)
5426         (within_function, global_sym_chain, global_stabs)
5427         (previous_stab_code, this_object_header_files)
5428         (n_this_object_header_files)
5429         (n_allocated_this_object_header_files): Define.
5430         * stabsread.h (EXTERN): Never define.  Use "extern".
5431
5432 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5433
5434         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5435         history_value.
5436
5437 2019-01-21  Tom Tromey  <tom@tromey.com>
5438
5439         * ui-out.c: Fix includes.
5440         * tui/tui-source.c: Fix includes.
5441         * target.c: Fix includes.
5442         * remote.c: Fix includes.
5443         * regcache.c: Fix includes.
5444         * python/py-block.c: Fix includes.
5445         * printcmd.c: Fix includes.
5446         * or1k-tdep.c: Fix includes.
5447         * mi/mi-main.c: Fix includes.
5448         * m32r-tdep.c: Fix includes.
5449         * csky-tdep.c: Fix includes.
5450         * compile/compile-cplus-types.c: Fix includes.
5451         * cli/cli-interp.c: Fix includes.
5452
5453 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5454
5455         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5456         for padding.
5457
5458 2019-01-16  Tom Tromey  <tom@tromey.com>
5459
5460         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5461         earlier.
5462         (struct objfile) <msymbols_range>: Move from top level.
5463         <msymbols>: New method.
5464         (class objfile_msymbols): Remove.
5465         * symtab.c (default_collect_symbol_completion_matches_break_on):
5466         Update.
5467         * symmisc.c (dump_msymbols): Update.
5468         * stabsread.c (scan_file_globals): Update.
5469         * objc-lang.c (info_selectors_command, info_classes_command)
5470         (find_methods): Update.
5471         * minsyms.c (find_solib_trampoline_target): Update.
5472         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5473         * coffread.c (coff_symfile_read): Update.
5474         * ada-lang.c (ada_lookup_simple_minsym)
5475         (ada_collect_symbol_completion_matches): Update.
5476
5477 2019-01-16  Tom Tromey  <tom@tromey.com>
5478
5479         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5480         type.  Remove no-argument constructor.
5481         <iterator::operator++>: Simplify.
5482         <begin>: Update.
5483         <end>: Use minimal_symbol_count.
5484
5485 2019-01-16  Tom Tromey  <tom@tromey.com>
5486
5487         * objfiles.h (struct objfile) <psymtabs>: New method.
5488         (class objfile_psymtabs): Remove.
5489         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5490         typedef.
5491         <range>: New method.
5492         (require_partial_symbols): Change return type.
5493         * psymtab.c (require_partial_symbols)
5494         (psym_expand_symtabs_matching): Update.
5495         * mdebugread.c (parse_partial_symbols): Update.
5496         * dbxread.c (dbx_end_psymtab): Update.
5497
5498 2019-01-15  Tom Tromey  <tom@tromey.com>
5499
5500         * symtab.c (lookup_objfile_from_block)
5501         (lookup_symbol_in_objfile_symtabs)
5502         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5503         (find_line_symtab, info_sources_command)
5504         (default_collect_symbol_completion_matches_break_on)
5505         (make_source_files_completion_list): Update.
5506         * symmisc.c (print_objfile_statistics, dump_objfile)
5507         (maintenance_print_symbols, maintenance_info_symtabs)
5508         (maintenance_check_symtabs, maintenance_info_line_tables):
5509         Update.
5510         * source.c (select_source_symtab)
5511         (forget_cached_source_info_for_objfile): Update.
5512         * objfiles.h (class objfile_compunits): Remove.
5513         (struct objfile) <compunits_range>: New typedef.
5514         (compunits): New method.
5515         * objfiles.c (objfile_relocate1): Update.
5516         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5517         * maint.c (count_symtabs_and_blocks): Update.
5518         * linespec.c (iterate_over_all_matching_symtabs): Update.
5519         * cp-support.c (add_symbol_overload_list_qualified): Update.
5520         * coffread.c (coff_symtab_read): Update.
5521         * ada-lang.c (add_nonlocal_symbols)
5522         (ada_collect_symbol_completion_matches)
5523         (ada_add_global_exceptions): Update.
5524
5525 2019-01-15  Tom Tromey  <tom@tromey.com>
5526
5527         * progspace.h (program_space) <objfiles_safe_range>: New
5528         typedef.
5529         <objfiles_safe>: New method.
5530         * objfiles.h (class all_objfiles_safe): Remove.
5531         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5532         * jit.c (jit_inferior_exit_hook): Update.
5533
5534 2019-01-17  Tom Tromey  <tom@tromey.com>
5535
5536         * progspace.h (program_space) <objfiles_range>: New typedef.
5537         <objfiles>: New method.
5538         <objfiles_head>: Rename from objfiles.
5539         (object_files): Update.
5540         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5541         * guile/scm-pretty-print.c
5542         (ppscm_find_pretty_printer_from_objfiles): Update.
5543         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5544         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5545         Update.
5546         * python/py-progspace.c (pspy_get_objfiles): Update.
5547         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5548         Update.
5549         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5550         (objfpy_lookup_objfile_by_build_id): Update.
5551         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5552         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5553         Update.
5554         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5555         (expand_symtab_containing_pc, lookup_objfile_from_block)
5556         (lookup_static_symbol, basic_lookup_transparent_type)
5557         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5558         (find_line_symtab, info_sources_command)
5559         (default_collect_symbol_completion_matches_break_on)
5560         (make_source_files_completion_list, find_main_name): Update.
5561         * symmisc.c (print_symbol_bcache_statistics)
5562         (print_objfile_statistics, maintenance_print_symbols)
5563         (maintenance_print_msymbols, maintenance_print_objfiles)
5564         (maintenance_info_symtabs, maintenance_check_symtabs)
5565         (maintenance_expand_symtabs, maintenance_info_line_tables):
5566         Update.
5567         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5568         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5569         (map_overlay_command, unmap_overlay_command)
5570         (simple_overlay_update, expand_symtabs_matching)
5571         (map_symbol_filenames): Update.
5572         * symfile-debug.c (set_debug_symfile): Update.
5573         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5574         Update.
5575         * source.c (select_source_symtab, forget_cached_source_info):
5576         Update.
5577         * solib.c (solib_read_symbols): Update.
5578         * solib-spu.c (append_ocl_sos): Update.
5579         * psymtab.c (maintenance_print_psymbols)
5580         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5581         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5582         * printcmd.c (info_symbol_command): Update.
5583         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5584         Update.
5585         * objfiles.h (class all_objfiles): Remove.
5586         * objfiles.c (have_partial_symbols, have_full_symbols)
5587         (have_minimal_symbols, qsort_cmp, update_section_map)
5588         (shared_objfile_contains_address_p)
5589         (default_iterate_over_objfiles_in_search_order): Update.
5590         * objc-lang.c (info_selectors_command, info_classes_command)
5591         (find_methods): Update.
5592         * minsyms.c (find_solib_trampoline_target): Update.
5593         * maint.c (maintenance_info_sections)
5594         (maintenance_translate_address, count_symtabs_and_blocks):
5595         Update.
5596         * main.c (captured_main_1): Update.
5597         * linux-thread-db.c (try_thread_db_load_from_pdir)
5598         (has_libpthread): Update.
5599         * linespec.c (iterate_over_all_matching_symtabs)
5600         (search_minsyms_for_name): Update.
5601         * jit.c (jit_find_objf_with_entry_addr): Update.
5602         * hppa-tdep.c (find_unwind_entry)
5603         (hppa_lookup_stub_minimal_symbol): Update.
5604         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5605         Update.
5606         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5607         (elf_gnu_ifunc_resolve_by_got): Update.
5608         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5609         * dwarf-index-write.c (save_gdb_index_command): Update.
5610         * cp-support.c (add_symbol_overload_list_qualified): Update.
5611         * breakpoint.c (create_overlay_event_breakpoint)
5612         (create_longjmp_master_breakpoint)
5613         (create_std_terminate_master_breakpoint)
5614         (create_exception_master_breakpoint): Update.
5615         * blockframe.c (find_pc_partial_function): Update.
5616         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5617         (ada_collect_symbol_completion_matches)
5618         (ada_add_global_exceptions): Update.
5619
5620 2019-01-17  Tom Tromey  <tom@tromey.com>
5621
5622         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5623         declare VEC.
5624         (solib_target_parse_libraries): Change return type.
5625         (library_list_start_segment, library_list_start_section)
5626         (library_list_end_library, library_list_start_library); Update.
5627         (solib_target_free_library_list): Remove.
5628         (solib_target_parse_libraries): Remove cleanup.  Change return
5629         type.
5630         (solib_target_current_sos): Update.
5631
5632 2019-01-17  Tom Tromey  <tromey@bapiya>
5633
5634         * valprint.c: Replace "the the" with "the".
5635         * symtab.c: Replace "the the" with "the".
5636         * solib.c: Replace "the the" with "the".
5637         * solib-dsbt.c: Replace "the the" with "the".
5638         * linespec.c: Replace "the the" with "the".
5639         * dwarf2loc.h: Replace "the the" with "the".
5640         * amd64-windows-tdep.c: Replace "the the" with "the".
5641         * aarch64-tdep.c: Replace "the the" with "the".
5642
5643 2019-01-16  Keith Seitz  <keiths@redhat.com>
5644
5645         PR gdb/23773
5646         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5647         <builder>: Rename to ..
5648         <m_builder>: ... this and make private.
5649         (dwarf2_cu::get_builder): New method.  Change all users of
5650         `builder' to use this method.
5651         (dwarf2_start_symtab): Move to ...
5652         (dwarf2_cu::start_symtab): ... here.  Update all callers
5653         (setup_type_unit_groups): Move to ...
5654         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5655         callers.
5656         (dwarf2_cu::reset_builder): New method.
5657         (process_full_compunit, process_full_type_unit): Use
5658         dwarf2_cu::reset_builder.
5659         (follow_die_offset): Record the ancestor CU if it is different
5660         from the followed DIE's CU.
5661         (follow_die_sig_1): Likewise.
5662
5663 2019-01-15  Tom Tromey  <tom@tromey.com>
5664
5665         * remote.c (class remote_state) <buf>: Now a char_vector.
5666         <buf_size>: Remove.
5667         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5668         parameter.
5669         (remote_target::getpkt_or_notif_sane_1)
5670         (remote_target::getpkt_sane)
5671         (remote_target::getpkt_or_notif_sane): Likewise.
5672         (class remote_target) <putpkt>: New overload.
5673         (remote_target::read_frame): Change type of "buf_p".  Remove
5674         sizeof_p parameter.
5675         (packet_ok): New overload.
5676         (packet_check_result): New overload.
5677         Update all uses.
5678
5679 2019-01-14  Tom Tromey  <tom@tromey.com>
5680
5681         * remote-notif.c (handle_notification, remote_notif_ack)
5682         (remote_notif_parse): Make "buf" const.
5683         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5684         const.
5685         (remote_notif_parse, remote_notif_ack, handle_notification):
5686         Likewise.
5687         * remote.c (remote_notif_stop_parse): Make "buf" const.
5688         (remote_target::remote_parse_stop_reply): Make "buf" const.
5689         (remote_notif_stop_ack): Make "buf" const.
5690
5691 2019-01-14  Tom Tromey  <tom@tromey.com>
5692
5693         * remote.c (remote_console_output): Make parameter const.
5694
5695 2019-01-14  Tom Tromey  <tom@tromey.com>
5696
5697         * target-debug.h (target_debug_print_signals): Constify.
5698         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5699         * procfs.c (procfs_target::pass_signals): Update.
5700         * linux-nat.c (linux_nat_target::pass_signals): Update.
5701         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5702         * target-delegates.c: Rebuild.
5703         * remote.c (remote_target::program_signals): Update.
5704         (remote_target::pass_signals): Update.
5705         * target.c (target_pass_signals): Constify argument.
5706         (target_program_signals): Likewise.
5707         * target.h (struct target_ops) <pass_signals, program_signals>:
5708         Constify argument.
5709         (target_pass_signals, target_program_signals): Constify argument.
5710
5711 2019-01-14  Tom Tromey  <tom@tromey.com>
5712
5713         PR tui/28819:
5714         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5715
5716 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5717
5718         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5719         field.
5720         * rs6000-tdep.c: Include reggroups.h.
5721         (IS_V_ALIAS_PSEUDOREG): Define.
5722         (rs6000_register_name): Return names for the "vX" aliases.
5723         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5724         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5725         aliases.  Call default_register_reggroup_p for all other
5726         pseudo-registers.
5727         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5728         New functions.
5729         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5730         Handle "vX" aliases.
5731         (v_alias_pseudo_register_collect): New function.
5732         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5733         (rs6000_gdbarch_init): Initialize "vX" aliases as
5734         pseudo-registers.  Restore registration of
5735         rs6000_pseudo_register_reggroup_p with
5736         set_tdesc_pseudo_register_reggroup_p.
5737
5738 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5739
5740         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5741         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5742         set_gdbarch_num_pseudo_regs.
5743
5744 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5745
5746         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5747         Remove arg prefixname, add do_set and do_show.
5748         Add member functions set_list and show_list.
5749         * cli/cli-style.c (class cli_style_option): Update accordingly.
5750         (style_set_list): Move to file scope.
5751         (style_show_list): Likewise.
5752         (set_style): Call help_list.
5753         (show_style): Call cmd_show_list.
5754         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5755         Update to use the new macro.
5756
5757 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5758
5759         * ada-lang.c (_initialize_ada_language): Expand the help text
5760         for the "catch exception" command.
5761
5762 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5763
5764         * symtab.c (matching_obj_sections): Initialize obj,
5765         declare it closer to its usage.
5766
5767 2019-01-10  Tom Tromey  <tom@tromey.com>
5768
5769         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5770         (basic_inf_threads_range): Remove.
5771         (inf_threads_range, inf_non_exited_threads_range)
5772         (safe_inf_threads_range): Use next_adapter.
5773
5774 2019-01-10  Keith Seitz  <keiths@redhat.com>
5775
5776         PR gdb/23712
5777         PR symtab/23010
5778         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5779         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5780
5781 2019-01-10  Keith Seitz  <keiths@redhat.com>
5782
5783         PR gdb/23712
5784         PR symtab/23010
5785         * dictionary.c (pending_to_vector): Remove.
5786         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5787         Remove _1 suffix, replacing functions of the same name.  Update
5788         all callers.
5789         (dict_create_hashed, dict_create_hashed_expandable)
5790         (dict_create_linear, dict_create_linear_expandable, dict_free)
5791         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5792         Make functions static.
5793
5794 2019-01-10  Keith Seitz  <keiths@redhat.com>
5795
5796         PR gdb/23712
5797         PR symtab/23010
5798         * dictionary.h (struct dictionary): Replace declaration with
5799         multidictionary.
5800         (dict_create_hashed, dict_create_hashed_expandable)
5801         (dict_create_linear, dict_create_linear_expandable)
5802         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5803         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5804         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5805         taking multidictionary argument.
5806         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5807         * block.h (struct block) <dict>: Change to multidictionary
5808         and rename `multidict'.
5809         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5810         symmisc.c: Update all dictionary references to multidictionary.
5811
5812 2019-01-10  Keith Seitz  <keiths@redhat.com>
5813
5814         PR gdb/23712
5815         PR symtab/23010
5816         * dictionary.c: Include unordered_map.
5817         (pending_to_vector): New function.
5818         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5819         Rewrite the non-"_1" functions to take vector instead
5820         of linked list.
5821         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5822         "new" _1 versions of the same name.
5823         (multidictionary): Define.
5824         (std::hash<enum language): New definition.
5825         (collate_pending_symbols_by_language, mdict_create_hashed)
5826         (mdict_create_hashed_expandable, mdict_create_linear)
5827         (mdict_create_linear_expandable, mdict_free)
5828         (find_language_dictionary, create_new_language_dictionary)
5829         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5830         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5831         (mdict_size, mdict_empty): New functions.
5832         * dictionary.h (mdict_iterator): Define.
5833
5834 2019-01-10  Pedro Alves  <palves@redhat.com>
5835
5836         * breakpoint.c (read_uploaded_action)
5837         (create_tracepoint_from_upload): Adjust to use
5838         gdb::unique_xmalloc_ptr.
5839         * ctf.c (ctf_write_uploaded_tp):
5840         (SET_ARRAY_FIELD): Use emplace_back.
5841         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5842         * tracefile-tfile.c (tfile_write_uploaded_tp):
5843         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5844         gdb::unique_xmalloc_ptr.
5845         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5846         at_string, cond_string, cmd_strings>: Replace char pointers
5847         with gdb::unique_xmalloc_ptr.
5848
5849 2019-01-10  Pedro Alves  <palves@redhat.com>
5850
5851         * solib-target.c (library_list_start_library): Don't xstrdup name.
5852
5853 2019-01-10  Pedro Alves  <palves@redhat.com>
5854
5855         * mdebugread.c (parse_partial_symbols): Use
5856         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5857
5858 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * linux-fork.c (scoped_switch_fork_info)
5861         <~scoped_switch_fork_info>: Fix incorrect variable name.
5862
5863 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5864
5865         * linux-fork.c (scoped_switch_fork_info)
5866         <scoped_switch_fork_info>: Make explicit.
5867         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5868
5869 2019-01-10  Tom Tromey  <tom@tromey.com>
5870
5871         * objfiles.h (objfile::reset_psymtabs): Update.
5872         * objfiles.c (objfile::objfile): Update.
5873         * psymtab.h (psymtab_storage::obstack): Update.
5874         (psymtab_storage::m_obstack): Use gdb::optional.
5875         (class psymtab_storage): Update comment.  Remove objfile
5876         parameter.
5877         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5878
5879 2019-01-10  Tom Tromey  <tom@tromey.com>
5880
5881         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5882         <free_psymtabs>: Now private.
5883         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5884         (allocate_psymtab): Use new method.
5885
5886 2019-01-10  Tom Tromey  <tom@tromey.com>
5887
5888         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5889         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5890         * mdebugread.c (parse_partial_symbols): Use
5891         allocate_dependencies.
5892         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5893         allocate_dependencies.
5894         (process_psymtab_comp_unit_reader)
5895         (build_type_psymtab_dependencies): Likewise.
5896         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5897
5898 2019-01-10  Tom Tromey  <tom@tromey.com>
5899
5900         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5901         PSYMBOL_SET_LANGUAGE.
5902         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5903
5904 2019-01-10  Tom Tromey  <tom@tromey.com>
5905
5906         * psymtab.h (psymtab_storage::obstack): New method.
5907         <m_obstack>: Rename from obstack; now private.
5908         * psymtab.c (psymtab_storage): Update.
5909         * dwarf2read.c (create_addrmap_from_index)
5910         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5911         Update.
5912
5913 2019-01-10  Tom Tromey  <tom@tromey.com>
5914
5915         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5916         * objfiles.h (objfile::reset_psymtabs): New method.
5917
5918 2019-01-10  Tom Tromey  <tom@tromey.com>
5919
5920         * symmisc.c (print_symbol_bcache_statistics): Update.
5921         (print_objfile_statistics): Update.
5922         * symfile.c (reread_symbols): Update.
5923         * psymtab.h (class psymtab_storage): New.
5924         * psymtab.c (psymtab_storage): New constructor.
5925         (~psymtab_storage): New destructor.
5926         (require_partial_symbols): Update.
5927         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5928         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5929         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5930         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5931         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5932         (start_psymtab_common, end_psymtab_common)
5933         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5934         (allocate_psymtab): Update.
5935         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5936         Update.
5937         (dump_psymtab_addrmap, maintenance_print_psymbols)
5938         (maintenance_check_psymtabs): Update.
5939         (class objfile_psymtabs): Move to objfiles.h.
5940         * psympriv.h (discard_psymtab): Now inline.
5941         (psymtab_discarder::psymtab_discarder): Update.
5942         (psymtab_discarder::~psymtab_discarder): Update.
5943         (ALL_OBJFILE_PSYMTABS): Rewrite.
5944         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5945         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5946         Remove fields.
5947         <partial_symtabs>: New field.
5948         (class objfile_psymtabs): Move from psymtab.h.  Update.
5949         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5950         psymbol_cache.
5951         (objfile::~objfile): Don't destroy psymbol_cache.
5952         * mdebugread.c (parse_partial_symbols): Update.
5953         * dwarf2read.c (create_addrmap_from_index)
5954         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5955         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5956         (add_partial_subprogram, dwarf2_ranges_read): Update.
5957         * dwarf-index-write.c (write_address_map)
5958         (write_one_signatured_type, recursively_write_psymbols)
5959         (class debug_names, class debug_names, write_psymtabs_to_index):
5960         Update.
5961
5962 2019-01-10  Tom Tromey  <tom@tromey.com>
5963
5964         * symtab.h (SYMBOL_SET_NAMES): Update.
5965         (symbol_set_names): Update.
5966         (MSYMBOL_SET_NAMES): Update.
5967         * symtab.c (symbol_set_names): Change argument to be an
5968         objfile_per_bfd_storage.
5969         * psymtab.c (add_psymbol_to_bcache): Update.
5970         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5971
5972 2019-01-10  Tom Tromey  <tom@tromey.com>
5973
5974         * symtab.c (create_demangled_names_hash): Change argument to be an
5975         objfile_per_bfd_storage.
5976         (symbol_set_names): Update.
5977
5978 2019-01-10  Tom Tromey  <tom@tromey.com>
5979
5980         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5981         init_psymbol_list.
5982         * psymtab.c (init_psymbol_list): Do nothing if already called.
5983         * psympriv.h (init_psymbol_list): Add comment.
5984         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5985         init_psymbol_list.
5986         * dbxread.c (dbx_symfile_read): Unconditionally call
5987         init_psymbol_list.
5988
5989 2019-01-10  Tom Tromey  <tom@tromey.com>
5990
5991         * xcoffread.c (scan_xcoff_symtab): Update.
5992         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5993         "where".
5994         * mdebugread.c (parse_partial_symbols)
5995         (handle_psymbol_enumerators): Update.
5996         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5997         * dbxread.c (read_dbx_symtab): Update.
5998         * psympriv.h (psymbol_placement): New enum.
5999         (add_psymbol_to_list): Update.
6000
6001 2019-01-10  Tom Tromey  <tom@tromey.com>
6002
6003         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6004         static_psymbols parameters.
6005         (scan_xcoff_symtab): Update.
6006         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6007         static_psymbols parameters.
6008         * psympriv.h (start_psymtab_common): Update.
6009         * mdebugread.c (parse_partial_symbols): Update.
6010         * dwarf2read.c (create_partial_symtab): Update.
6011         * dbxread.c (read_dbx_symtab): Update.
6012         (start_psymtab): Remove global_psymbols and static_psymbols
6013         parameters.
6014
6015 2019-01-10  Tom Tromey  <tom@tromey.com>
6016
6017         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6018         * psymtab.c (allocate_psymtab): Add comment.
6019         * psympriv.h (allocate_psymtab): Add comment.
6020         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6021         initializations.
6022         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6023
6024 2019-01-10  Tom Tromey  <tom@tromey.com>
6025
6026         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6027         Don't declare.
6028         * mipsread.c: Include mdebugread.h.
6029         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6030         Declare.
6031         * elfread.c: Include mdebugread.h.
6032
6033 2019-01-09  Tom Tromey  <tom@tromey.com>
6034
6035         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6036         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6037         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6038         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6039         (psym_lookup_symbol, psym_find_last_source_symtab)
6040         (psym_forget_cached_source_info, psym_print_stats)
6041         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6042         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6043         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6044         (psym_find_compunit_symtab_by_address)
6045         (maintenance_print_psymbols, maintenance_info_psymtabs)
6046         (maintenance_check_psymtabs): Use ranged for.
6047         * psymtab.h (class objfile_psymtabs): New.
6048         (require_partial_symbols): Return objfile_psymtabs.
6049         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6050
6051 2019-01-09  Tom Tromey  <tom@tromey.com>
6052
6053         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6054         (find_pc_mapped_section, list_overlays_command)
6055         (map_overlay_command, unmap_overlay_command)
6056         (simple_overlay_update): Use all_objfiles.
6057         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6058         * printcmd.c (info_symbol_command): Use all_objfiles.
6059         * objfiles.h (ALL_OBJSECTIONS): Remove.
6060         * maint.c (maintenance_translate_address): Use all_objfiles.
6061         * gcore.c (gcore_create_callback): Use all_objfiles.
6062         (objfile_find_memory_regions): Likewise.
6063
6064 2019-01-09  Tom Tromey  <tom@tromey.com>
6065
6066         * symtab.c (find_line_symtab, info_sources_command)
6067         (make_source_files_completion_list): Use objfile_compunits.
6068         * source.c (select_source_symtab): Use objfile_compunits.
6069         * objfiles.h (struct objfile): Update comment.
6070         (ALL_OBJFILES): Remove.
6071         (ALL_FILETABS): Remove.
6072         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6073         objfile_compunits.
6074
6075 2019-01-09  Tom Tromey  <tom@tromey.com>
6076
6077         * symmisc.c (print_objfile_statistics, dump_objfile)
6078         (maintenance_print_symbols): Use compunit_filetabs.
6079         * source.c (forget_cached_source_info_for_objfile): Use
6080         compunit_filetabs.
6081         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6082         (ALL_FILETABS): Use compunit_filetabs.
6083         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6084         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6085
6086 2019-01-09  Tom Tromey  <tom@tromey.com>
6087
6088         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6089         (compunit_filetabs): New.
6090         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6091         compunit_filetabs.
6092         (info_sources_command, make_source_files_completion_list): Remove
6093         declaration.
6094         * symmisc.c (print_objfile_statistics, dump_objfile)
6095         (maintenance_print_symbols): Remove declaration.
6096         (maintenance_info_symtabs): Use compunit_filetabs.
6097         (maintenance_info_line_tables): Likewise.
6098         * source.c (select_source_symtab): Change local variable name.
6099         (forget_cached_source_info_for_objfile): Remove declaration.
6100         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6101         * objfiles.c (objfile_relocate1): Remove declaration.
6102         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6103         declaration.
6104         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6105         * coffread.c (coff_symtab_read): Remove declaration.
6106         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6107         compunit_filetabs.
6108
6109 2019-01-09  Tom Tromey  <tom@tromey.com>
6110
6111         * symtab.c (lookup_objfile_from_block)
6112         (find_pc_sect_compunit_symtab, search_symbols)
6113         (default_collect_symbol_completion_matches_break_on): Use
6114         objfile_compunits.
6115         * objfiles.h (ALL_COMPUNITS): Remove.
6116         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6117         * cp-support.c (add_symbol_overload_list_qualified): Use
6118         objfile_compunits.
6119         * ada-lang.c (ada_collect_symbol_completion_matches)
6120         (ada_add_global_exceptions): Use objfile_compunits.
6121
6122 2019-01-09  Tom Tromey  <tom@tromey.com>
6123
6124         * source.c (select_source_symtab)
6125         (forget_cached_source_info_for_objfile): Remove declaration.
6126         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6127         declaration.
6128         * maint.c (count_symtabs_and_blocks): Remove declaration.
6129         * cp-support.c (add_symbol_overload_list_qualified): Remove
6130         declaration.
6131         * coffread.c (coff_symtab_read): Remove declaration.
6132         * symtab.c (lookup_symbol_in_objfile_symtabs)
6133         (basic_lookup_transparent_type_1): Use objfile_compunits.
6134         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6135         (info_sources_command, search_symbols)
6136         (default_collect_symbol_completion_matches_break_on)
6137         (make_source_files_completion_list): Remove declaration.
6138         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6139         (ada_collect_symbol_completion_matches)
6140         (ada_add_global_exceptions): Remove declaration.
6141         * linespec.c (iterate_over_all_matching_symtabs): Use
6142         objfile_compunits.
6143         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6144         (class objfile_compunits): New.
6145         (ALL_COMPUNITS): Use objfile_compunits.
6146         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6147         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6148         objfile_compunits.
6149         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6150
6151 2019-01-09  Tom Tromey  <tom@tromey.com>
6152
6153         * symtab.c (search_symbols)
6154         (default_collect_symbol_completion_matches_break_on): Use
6155         objfile_msymbols.
6156         * ada-lang.c (ada_lookup_simple_minsym)
6157         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6158         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6159         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6160         objfile_msymbols.
6161         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6162         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6163         * objc-lang.c (find_methods): Use objfile_msymbols.
6164         (info_selectors_command, info_classes_command): Likewise.
6165         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6166         * objfiles.h (class objfile_msymbols): New.
6167         (ALL_OBJFILE_MSYMBOLS): Remove.
6168         (ALL_MSYMBOLS): Remove.
6169
6170 2019-01-09  Tom Tromey  <tom@tromey.com>
6171
6172         * common/next-iterator.h (next_adapter): Add Iterator template
6173         parameter.
6174         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6175         (class all_objfiles_safe): New.
6176         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6177         * objfiles.c (put_objfile_before): Update comment.
6178         (add_separate_debug_objfile): Likewise.
6179         (free_all_objfiles): Use all_objfiles_safe.
6180         (objfile_purge_solibs): Likewise.
6181
6182 2019-01-09  Tom Tromey  <tom@tromey.com>
6183
6184         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6185         (expand_symtab_containing_pc, lookup_static_symbol)
6186         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6187         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6188         all_objfiles.
6189         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6190         * breakpoint.c (create_overlay_event_breakpoint)
6191         (create_longjmp_master_breakpoint)
6192         (create_std_terminate_master_breakpoint)
6193         (create_exception_master_breakpoint): Use all_objfiles.
6194         * linux-thread-db.c (try_thread_db_load_from_pdir)
6195         (has_libpthread): Use all_objfiles.
6196         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6197         * linespec.c (iterate_over_all_matching_symtabs)
6198         (search_minsyms_for_name): Use all_objfiles.
6199         * maint.c (maintenance_info_sections): Use all_objfiles.
6200         * main.c (captured_main_1): Use all_objfiles.
6201         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6202         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6203         * guile/scm-pretty-print.c
6204         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6205         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6206         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6207         (maintenance_print_msymbols): Use all_objfiles.
6208         * source.c (select_source_symtab): Use all_objfiles.
6209         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6210         * symfile.c (remove_symbol_file_command)
6211         (expand_symtabs_matching, map_symbol_filenames): Use
6212         all_objfiles.
6213         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6214         all_objfiles.
6215         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6216         * objc-lang.c (find_methods): Use all_objfiles.
6217         * objfiles.c (have_partial_symbols, have_full_symbols)
6218         (have_minimal_symbols, qsort_cmp)
6219         (default_iterate_over_objfiles_in_search_order): Use
6220         all_objfiles.
6221         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6222         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6223         (maintenance_check_psymtabs): Use all_objfiles.
6224         (ALL_PSYMTABS): Remove.
6225         * compile/compile-object-run.c (do_module_cleanup): Use
6226         all_objfiles.
6227         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6228         * cp-support.c (add_symbol_overload_list_qualified): Use
6229         all_objfiles.
6230         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6231         Use all_objfiles.
6232         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6233         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6234         all_objfiles.
6235         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6236         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6237         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6238         Uses all_objfiles.
6239         * solib.c (solib_read_symbols): Use all_objfiles
6240
6241 2019-01-09  Tom Tromey  <tom@tromey.com>
6242
6243         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6244         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6245         all_objfiles.
6246         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6247         * symmisc.c (print_symbol_bcache_statistics)
6248         (print_objfile_statistics, maintenance_print_objfiles)
6249         (maintenance_info_symtabs, maintenance_check_symtabs)
6250         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6251         all_objfiles.
6252         * source.c (forget_cached_source_info): Use all_objfiles.
6253         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6254         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6255         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6256         * objfiles.c (update_section_map): Use all_objfiles.
6257         (shared_objfile_contains_address_p): Likewise.
6258         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6259         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6260
6261 2019-01-09  Tom Tromey  <tom@tromey.com>
6262
6263         * common/next-iterator.h: New file.
6264         * objfiles.h (class all_objfiles): New.
6265         (struct objfile_iterator): New.
6266
6267 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6268
6269         * NEWS: Move the description of the changed "frame", "select-frame",
6270          and "info frame" commands to the Changed commands section.
6271
6272 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6273
6274         * gdbtypes.c (check_stub_method_group): Remove handling of old
6275         mangling schemes.
6276         * linespec.c (find_methods): Likewise.
6277         * stabsread.c (read_member_functions): Likewise.
6278         * valops.c (search_struct_method): Likewise.
6279         (value_struct_elt_for_reference): Likewise.
6280         * NEWS: Mention this change.
6281
6282 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6285         print_source_lines.
6286         * source.c (print_source_lines_base): Update line number check.
6287         (print_source_lines): New function.
6288         (source_lines_range::source_lines_range): New function.
6289         * source.h (class source_lines_range): New class.
6290         (print_source_lines): New declaration.
6291
6292 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6293
6294         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6295
6296 2019-01-08  Tom Tromey  <tom@tromey.com>
6297             Simon Marchi  <simon.marchi@ericsson.com>
6298
6299         PR gdb/24060
6300         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6301         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6302         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6303         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6304         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6305         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6306
6307 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6308
6309         * source.c (select_source_symtab): Move header comment to
6310         declaration in source.h.
6311         (forget_cached_source_info_for_objfile): Likewise.
6312         (forget_cached_source_info): Likewise.
6313         (identify_source_line): Likewise.
6314         * source.h (identify_source_line): Move declaration from symtab.h
6315         and add comment from source.c
6316         (print_source_lines): Likewise.
6317         (forget_cached_source_info_for_objfile): Likewise.
6318         (forget_cached_source_info): Likewise.
6319         (select_source_symtab): Likewise.
6320         (enum print_source_lines_flag): Move definition from symtab.h.
6321         * symtab.h (identify_source_line): Move declaration to source.h.
6322         (print_source_lines): Likewise.
6323         (forget_cached_source_info_for_objfile): Likewise.
6324         (forget_cached_source_info): Likewise.
6325         (select_source_symtab): Likewise.
6326         (enum print_source_lines_flag): Move definition to source.h.
6327         * tui/tui-hooks.c: Add 'source.h' include.
6328
6329 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6330
6331         * source.c (print_source_lines_base): Handle requests to print
6332         reverse line number sequences, and guard against empty lines
6333         string.
6334
6335 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6336
6337         * source.c (print_source_lines_base): Fix skip of '\r' if next
6338         character is '\n'.
6339
6340 2019-01-06  Tom Tromey  <tom@tromey.com>
6341
6342         * c-exp.y (struct c_parse_state) <macro_original_text,
6343         expansion_obstack>: New member.
6344         (macro_original_text, expansion_obstack): Remove globals.
6345         (scan_macro_expansion, scanning_macro_expansion)
6346         (finished_macro_expansion): Update.
6347         (scan_macro_cleanup): Remove.
6348         (yylex, c_parse): Update.
6349
6350 2019-01-06  Tom Tromey  <tom@tromey.com>
6351
6352         * c-exp.y (struct c_parse_state) <strings>: New member.
6353         (operator_stoken): Update.
6354
6355 2019-01-06  Tom Tromey  <tom@tromey.com>
6356
6357         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6358         (union type_stack_elt) <typelist_val>: Now a pointer to
6359         std::vector.
6360         (type_stack_cleanup): Don't declare.
6361         (push_typelist): Update.
6362         * parse.c (pop_typelist): Return a std::vector.
6363         (push_typelist): Take a std::vector.
6364         (follow_types): Update.  Do not free args.
6365         (type_stack_cleanup): Remove.
6366         * c-exp.y (struct c_parse_state): New.
6367         (cpstate): New global.
6368         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6369         (nonempty_typelist): Update.
6370         (func_mod): Create a new vector.
6371         (c_parse): Create a c_parse_state.
6372         (check_parameter_typelist): Do not delete params.
6373         (function_method): Update.  Do not delete type_list.
6374
6375 2019-01-06  Tom Tromey  <tom@tromey.com>
6376
6377         PR gdb/28155:
6378         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6379         check_typedef.
6380         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6381         (print_return_value): Likewise.
6382
6383 2019-01-05  Tom Tromey  <tom@tromey.com>
6384
6385         * contrib/cleanup_check.py: Remove.
6386         * contrib/gcc-with-excheck: Remove.
6387         * contrib/exsummary.py: Remove.
6388         * contrib/excheck.py: Remove.
6389
6390 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6391
6392         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6393         NULL. Initialize tpprev to NULL instead of assigning it
6394         to NULL on the next statement.
6395         * windows-nat.c (windows_delete_thread): Remove check for
6396         main_thread_id before printing thread exit notifications.
6397         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6398         Remove thread ID check against main_thread_id.
6399         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6400         windows_delete_thread.
6401         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6402
6403 2019-01-04  Tom Tromey  <tom@tromey.com>
6404
6405         * compile/compile.c (_initialize_compile): Use upper case for
6406         metasyntactic variables.
6407         * symmisc.c (_initialize_symmisc): Use upper case for
6408         metasyntactic variables.
6409         * psymtab.c (_initialize_psymtab): Use upper case for
6410         metasyntactic variables.
6411         * demangle.c (demangle_command): Use upper case for metasyntactic
6412         variables.
6413         (_initialize_demangler): Likewise.
6414         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6415         variables.
6416
6417 2019-01-03  Tom Tromey  <tom@tromey.com>
6418
6419         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6420
6421 2019-01-03  Tom Tromey  <tom@tromey.com>
6422
6423         * python/py-symtab.c (salpy_str): Update.
6424         (struct salpy_sal_object) <symtab>: Now a PyObject.
6425         (salpy_dealloc): Update.
6426         (del_objfile_sal): Use gdbpy_ref.
6427
6428 2019-01-03  Tom Tromey  <tom@tromey.com>
6429
6430         * python/py-type.c (convert_field): Use new_reference.  Return
6431         gdbpy_ref.
6432         (make_fielditem): Return gdbpy_ref.
6433         (typy_fields): Update.
6434         (typy_getitem): Update.
6435         (field_name): Return gdbpy_ref.  Use new_reference.
6436         (typy_iterator_iternext): Update.
6437
6438 2019-01-03  Tom Tromey  <tom@tromey.com>
6439
6440         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6441
6442 2019-01-03  Tom Tromey  <tom@tromey.com>
6443
6444         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6445         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6446         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6447         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6448         (pspy_set_type_printers): Likewise.
6449         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6450         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6451         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6452         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6453         (objfpy_set_type_printers): Likewise.
6454
6455 2019-01-03  Tom Tromey  <tom@tromey.com>
6456
6457         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6458         (gdbpy_print_stack): Use gdbpy_err_fetch.
6459         * python/python-internal.h (class gdbpy_err_fetch): New class.
6460         (class gdbpy_enter) <m_error_type, m_error_value,
6461         m_error_traceback>: Remove.
6462         <m_error>: New member.
6463         (gdbpy_exception_to_string): Don't declare.
6464         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6465         * python/py-value.c (convert_value_from_python): Use
6466         gdbpy_err_fetch.
6467         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6468         gdbpy_exception_to_string.
6469         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6470         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6471         gdbpy_err_fetch.
6472
6473 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6474
6475         * linux-nat.c (delete_lwp_cleanup): Delete.
6476         (struct lwp_deleter): New struct.
6477         (lwp_info_up): New typedef.
6478         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6479         lwp_info_up.
6480
6481 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6482
6483         * linux-fork.c (class scoped_switch_fork_info): New class.
6484         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6485
6486 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6487
6488         * valops.c (find_overload_match): Remove use of null_cleanup, and
6489         calls to do_cleanups.
6490
6491 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6492
6493         * compile/compile-cplus-types.c
6494         (compile_cplus_instance::decl_name): Handle changes to
6495         cp_func_name.
6496         * cp-support.c (cp_func_name): Update header comment, update
6497         return type.
6498         * cp-support.h (cp_func_name): Update return type in declaration.
6499         * valops.c (find_overload_match): Move temp_func local to top
6500         level of function and change its type.  Use temp_func to hold and
6501         delete temporary string obtained from cp_func_name.
6502
6503 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6506         gdb::char_vector, remove cleanup, and update uses of `msg`.
6507
6508 2019-01-03  Jim Wilson  <jimw@sifive.com>
6509
6510         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6511
6512 2019-01-02  Tom Tromey  <tom@tromey.com>
6513
6514         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6515         (tdesc_parse_xml): Remove cleanups.
6516         * target-descriptions.h (make_cleanup_free_target_description):
6517         Don't declare.
6518         (target_desc_deleter): New struct.
6519         (target_desc_up): New typedef.
6520         * target-descriptions.c (target_desc_deleter::operator()): Rename
6521         from free_target_description.
6522         (make_cleanup_free_target_description): Remove.
6523
6524 2019-01-02  Tom Tromey  <tom@tromey.com>
6525
6526         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6527         constructor, destructor.
6528         (linespec_parser): Remove typedef.
6529         (~linespec_parser): Rename from linespec_parser_delete.
6530         (linespec_lex_to_end, linespec_complete_label)
6531         (linespec_complete): Update.
6532         (decode_line_full): Remove cleanups.
6533         (decode_line_1): Update.
6534
6535 2019-01-02  Tom Tromey  <tom@tromey.com>
6536
6537         * python/python-internal.h (inferior_to_inferior_object): Change
6538         return type.
6539         * python/py-exitedevent.c (create_exited_event_object): Update.
6540         * python/py-inferior.c (inferior_to_inferior_object): Return
6541         gdbpy_ref.
6542         (python_new_inferior, python_inferior_deleted)
6543         (thread_to_thread_object, delete_thread_object)
6544         (build_inferior_list, gdbpy_selected_inferior): Update.
6545         * python/py-infthread.c (create_thread_object): Update.  Also fail
6546         if inferior_to_inferior_object fails.
6547
6548 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6549
6550         * inferior.h (class inferior) <displaced_step_state>: New field.
6551         * infrun.h (struct displaced_step_state): Move here from
6552         infrun.c.  Initialize fields, add constructor.
6553         <inf>: Remove field.
6554         <reset>: New method.
6555         * infrun.c (struct displaced_step_inferior_state): Move to
6556         infrun.h.
6557         (displaced_step_inferior_states): Remove.
6558         (get_displaced_stepping_state): Adust.
6559         (displaced_step_in_progress_any_inferior): Adjust.
6560         (displaced_step_in_progress_thread): Adjust.
6561         (displaced_step_in_progress): Adjust.
6562         (add_displaced_stepping_state): Remove.
6563         (get_displaced_step_closure_by_addr): Adjust.
6564         (remove_displaced_stepping_state): Remove.
6565         (infrun_inferior_exit): Call displaced_step_state.reset.
6566         (use_displaced_stepping): Don't check for NULL.
6567         (displaced_step_prepare_throw): Call
6568         get_displaced_stepping_state.
6569         (displaced_step_fixup): Don't check for NULL.
6570         (prepare_for_detach): Don't check for NULL.
6571
6572 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6573
6574         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6575          in case of call that did not complete.
6576
6577 2019-01-02  Andrey Utkin  <autkin@undo.io>
6578
6579         * symfile.c (find_separate_debug_file): Fix search of debug files for
6580         remote debuggee.
6581
6582 2019-01-02  Tom Tromey  <tom@tromey.com>
6583
6584         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6585         indentation.
6586         * python/py-frame.c (frapy_older): Remove cast.
6587         (frapy_newer): Likewise.
6588         * python/py-breakpoint.c (local_setattro): Remove cast.
6589         * python/py-arch.c (archpy_name): Remove local variable.
6590         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6591
6592 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6593
6594         * unittests/basic_string_view/element_access/char/empty.cc:
6595         Fix year range in copyright header.
6596
6597 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6598
6599         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6600         Delete.
6601         <operator==>: Update with for removed field.
6602         <hash>: Likewise.
6603         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6604         <isa_features>: ...this.
6605         <abi_features>: New field.
6606         (riscv_isa_flen): Update comment.
6607         (riscv_abi_xlen): New declaration.
6608         (riscv_abi_flen): New declaration.
6609         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6610         isa_features.
6611         (riscv_abi_xlen): New function.
6612         (riscv_isa_flen): Update to get answer from isa_features.
6613         (riscv_abi_flen): New function.
6614         (riscv_has_fp_abi): Update to get answer from abi_features.
6615         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6616         xlen and flen.
6617         (riscv_call_info) <xlen, flen>: Update comment.
6618         (riscv_call_arg_struct): Remove invalid assertions
6619         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6620         is removed.
6621         (riscv_gdbarch_init): Gather isa features and abi features
6622         separately, ensure both match on the gdbarch when reusing an old
6623         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6624         a target with 64-bit float hardware.
6625
6626 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6627
6628         * source.c (search_command_helper): Stop reverse search
6629         when line 1 has been searched.
6630
6631 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6632
6633         * record-full.c (record_full_base_target::close): Rewrite
6634         record_full_core_buf_list free logic.
6635
6636 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6637
6638         * break-catch-syscall.c (print_one_catch_syscall): xfree
6639         the last text.
6640
6641 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6642
6643         * top.c (print_gdb_version): Update Copyright year in version
6644         message.
6645
6646 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6647
6648         Update copyright year range in all GDB files.
6649
6650 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6651
6652         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6653
6654 For older changes see ChangeLog-2018.
6655 \f
6656 Local Variables:
6657 mode: change-log
6658 left-margin: 8
6659 fill-column: 74
6660 version-control: never
6661 coding: utf-8
6662 End:
6663