gdb/ChangeLog

   1 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * selftest.m4: Move to gdbsupport/.
   4         * acinclude.m4: Update path to selftest.m4.
   5
   6 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
   7
   8         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
   9         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
  10         gdbarch-selfselftests.c and selftest-arch.c.
  11         (SUBDIR_UNITTESTS_OBS): Rename to...
  12         (SELFTESTS_OBS): ... this.
  13         (COMMON_SFILES): Remove disasm-selftests.c and
  14         gdbarch-selftests.c.
  15         * configure.ac: Don't add selftest-arch.{c,o} to
  16         CONFIG_{SRCS,OBS}.
  17         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
  18         preprocessor conditions.
  19
  20 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
  21
  22         * configure.ac: Don't source bfd/development.sh.
  23         * selftest.m4: Modify comment.
  24         * configure: Re-generate.
  25
  26 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
  27
  28         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
  29         not "true" or "false".
  30         * configure: Re-generate.
  31
  32 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
  33
  34         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
  35         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
  36         renamed to arm_nbsd_supply_gregset.
  37         (fetch_register): Update to call arm_nbsd_supply_gregset.
  38         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
  39         (arm_netbsd_nat_target::fetch_registers): Update.
  40         (fetch_elfcore_registers): Removed.
  41         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
  42         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
  43         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
  44         not require NetBSD system headers.
  45         (arm_nbsd_regset): New struct.
  46         (arm_nbsd_iterate_over_regset_sections): New function.
  47         (arm_netbsd_init_abi_common): Updated to call
  48         set_gdbarch_iterate_over_regset_sections.
  49         * arm-nbsd-tdep.h: New file.
  50
  51 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
  52
  53         * symtab.c (find_pc_sect_line): Add check which prevents infinite
  54         recursion.
  55
  56 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
  57
  58         * configure: Re-generate.
  59
  60 2020-03-11  Tom Tromey  <tromey@adacore.com>
  61
  62         * ada-typeprint.c (print_choices): Fix comment.
  63
  64 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  65
  66         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
  67         previous item in the list, when the list has no items.
  68
  69 2020-03-11  Tom de Vries  <tdevries@suse.de>
  70
  71         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
  72         PROP_LOCLIST handling code.
  73
  74 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * buildsym-legacy.c (record_line): Pass extra parameter to
  77         record_line.
  78         * buildsym.c (buildsym_compunit::record_line): Take an extra
  79         parameter, reduce duplication in the line table, and record the
  80         is_stmt flag in the line table.
  81         * buildsym.h (buildsym_compunit::record_line): Add extra
  82         parameter.
  83         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
  84         non-statement lines.
  85         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
  86         this to the symtab builder.
  87         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
  88         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
  89         through to dwarf_record_line_1.
  90         * infrun.c (process_event_stop_test): When stepping, don't stop at
  91         a non-statement instruction, and only refresh the step info when
  92         we land in the middle of a line's range.  Also add an extra
  93         comment.
  94         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
  95         field.
  96         * record-btrace.c (btrace_find_line_range): Only record lines
  97         marked as is-statement.
  98         * stack.c (frame_show_address): Show the frame address if we are
  99         in a non-statement sal.
 100         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
 101         (maintenance_print_one_line_table): Print a header for the is_stmt
 102         column, and include is_stmt information in the output.
 103         * symtab.c (find_pc_sect_line): Find lines marked as statements in
 104         preference to non-statements.
 105         (find_pcs_for_symtab_line): Prefer is-statement entries.
 106         (find_line_common): Likewise.
 107         * symtab.h (struct linetable_entry): Add is_stmt field.
 108         (struct symtab_and_line): Likewise.
 109         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
 110         arranging the line table.
 111
 112 2020-03-07  Tom de Vries  <tdevries@suse.de>
 113
 114         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
 115         DIE.
 116
 117 2020-03-07  Tom Tromey  <tom@tromey.com>
 118
 119         * valops.c (value_literal_complex): Remove obsolete comment.
 120         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
 121         comment.
 122
 123 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
 124
 125         * infrun.h: Forward-declare thread_info.
 126         (set_step_info): Add thread_info parameter, add doc.
 127         * infrun.c (set_step_info): Add thread_info parameter, move doc
 128         to header.
 129         * infrun.c (process_event_stop_test): Pass thread to
 130         set_step_info call.
 131         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
 132         set_step_info.
 133         (prepare_one_step): Add thread_info parameter, pass it to
 134         set_step_frame and prepare_one_step (recursive) call.
 135         (step_1): Pass thread to prepare_one_step call.
 136         (step_command_fsm::should_stop): Pass thread to
 137         prepare_one_step.
 138         (until_next_fsm): Pass thread to set_step_frame call.
 139         (finish_command): Pass thread to set_step_info call.
 140
 141 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
 142
 143         * windows-tdep.c (windows_solib_create_inferior_hook):
 144         Check if inferior is running.
 145
 146 2020-03-06  Tom de Vries  <tdevries@suse.de>
 147
 148         * NEWS: Fix "the the".
 149         * ctfread.c: Same.
 150
 151 2020-03-06  Tom de Vries  <tdevries@suse.de>
 152
 153         * psymtab.c (psymtab_to_symtab): Don't print "done.".
 154
 155 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 156
 157         * .dir-locals.el: Add a comment referencing the other copies of
 158         this file.
 159
 160 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
 161
 162         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
 163         psargs.
 164
 165 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 166
 167         * .gitattributes: New file.
 168
 169 2020-03-04  Tom Tromey  <tom@tromey.com>
 170
 171         * symmisc.c (print_symbol_bcache_statistics)
 172         (print_objfile_statistics): Update.
 173         * symfile.c (allocate_symtab): Use intern.
 174         * psymtab.c (partial_symtab::partial_symtab): Use intern.
 175         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 176         macro_cache>: Remove.
 177         <string_cache>: New member.
 178         (struct objfile) <intern>: New methods.
 179         * elfread.c (elf_symtab_read): Use intern.
 180         * dwarf2/read.c (fixup_go_packaging): Intern package name.
 181         (dwarf2_compute_name, dwarf2_physname)
 182         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
 183         names.
 184         (guess_partial_die_structure_name): Update.
 185         (partial_die_info::fixup): Intern name.
 186         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
 187         name.
 188         (dwarf2_name): Intern name.  Update.
 189         * buildsym.c (buildsym_compunit::get_macro_table): Use
 190         string_cache.
 191
 192 2020-03-04  Tom Tromey  <tom@tromey.com>
 193
 194         * jit.c (bfd_open_from_target_memory): Make "target" const.
 195         * corefile.c (gnutarget): Now const.
 196         * gdbcore.h (gnutarget): Now const.
 197
 198 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
 199
 200         * NEWS: Mention support for WOW64 processes.
 201         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
 202         (amd64_windows_segment_register_p): Remove static.
 203         (_initialize_amd64_windows_nat): Update.
 204         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
 205         * i386-windows-nat.c (context_offset): Update.
 206         (i386_mappings): Rename and remove static.
 207         (i386_windows_segment_register_p): Remove static.
 208         (_initialize_i386_windows_nat): Update.
 209         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
 210         (STATUS_WX86_SINGLE_STEP): New macro.
 211         (EnumProcessModulesEx): New macro.
 212         (Wow64SuspendThread): New macro.
 213         (Wow64GetThreadContext): New macro.
 214         (Wow64SetThreadContext): New macro.
 215         (Wow64GetThreadSelectorEntry): New macro.
 216         (windows_set_context_register_offsets): Add static.
 217         (windows_set_segment_register_p): Likewise.
 218         (windows_add_thread): Adapt for WOW64 processes.
 219         (windows_fetch_one_register): Likewise.
 220         (windows_nat_target::fetch_registers): Likewise.
 221         (windows_store_one_register): Likewise.
 222         (display_selector): Likewise.
 223         (display_selectors): Likewise.
 224         (handle_exception): Likewise.
 225         (windows_continue): Likewise.
 226         (windows_nat_target::resume): Likewise.
 227         (windows_add_all_dlls): Likewise.
 228         (do_initial_windows_stuff): Likewise.
 229         (windows_nat_target::attach): Likewise.
 230         (windows_get_exec_module_filename): Likewise.
 231         (windows_nat_target::create_inferior): Likewise.
 232         (windows_xfer_siginfo): Likewise.
 233         (_initialize_loadable): Initialize Wow64SuspendThread,
 234         Wow64GetThreadContext, Wow64SetThreadContext,
 235         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
 236         * windows-nat.h (windows_set_context_register_offsets):
 237         Remove declaration.
 238         (windows_set_segment_register_p): Likewise.
 239         (i386_windows_segment_register_p): Add declaration.
 240         (amd64_windows_segment_register_p): Likewise.
 241
 242 2020-03-04  Luis Machado  <luis.machado@linaro.org>
 243
 244         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
 245         in "info registers" for AArch64/ARM.
 246
 247         The change caused "info registers" to not print GPR's.
 248
 249         gdb/ChangeLog:
 250
 251         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
 252
 253         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 254         when reg->group is empty and reggroup is not.
 255
 256 2020-03-03  Tom Tromey  <tromey@adacore.com>
 257
 258         * dwarf2/frame.c (struct dwarf2_frame_cache)
 259         <checked_tailcall_bottom, entry_cfa_sp_offset,
 260         entry_cfa_sp_offset_p>: Remove members.
 261         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
 262         (dwarf2_frame_prev_register): Don't call
 263         dwarf2_tailcall_sniffer_first.
 264         (dwarf2_append_unwinders): Don't append tailcall unwinder.
 265         * frame-unwind.c (add_unwinder): New fuction.
 266         (frame_unwind_init): Use it.  Add tailcall unwinder.
 267
 268 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 269             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 270
 271         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
 272         value should be printed as true.
 273
 274 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
 275
 276         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
 277         (windows_init_abi): Set and use windows_so_ops.
 278
 279 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 280
 281         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
 282         when verifying if dealing with a convenience variable.
 283
 284 2020-03-03  Luis Machado  <luis.machado@linaro.org>
 285
 286         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
 287
 288 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
 289
 290         * infrun.c (gdbarch_supports_displaced_stepping): New.
 291         (use_displaced_stepping): Break up conditions in smaller pieces.
 292         Use gdbarch_supports_displaced_stepping.
 293         (displaced_step_prepare_throw): Use
 294         gdbarch_supports_displaced_stepping.
 295
 296 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * NEWS: Mention new behaviour of the history filename.
 299         * top.c (write_history_p): Add comment.
 300         (show_write_history_p): Add header comment, give a different
 301         message when history writing is on, but the history filename is
 302         empty.
 303         (history_filename): Add comment.
 304         (history_filename_empty): New function.
 305         (show_history_filename): Add header comment, give a different
 306         message when the filename is empty.
 307         (init_history): Compare history_filename against nullptr, and only
 308         read history if the filename is not empty.
 309         (set_history_filename): Add header comment, and only make
 310         non-empty filenames absolute.
 311         (init_main): Make the filename argument to 'set history filename'
 312         optional.
 313
 314 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
 315
 316         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
 317         (arm_supply_vfpregset): ...this, and update to use VFP registers.
 318         (fetch_fp_register): Update.
 319         (fetch_fp_regs): Update.
 320         (store_fp_register): Update.
 321         (store_fp_regs): Update.
 322         (arm_netbsd_nat_target::read_description): New function.
 323         (fetch_elfcore_registers): Update.
 324
 325 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 326
 327         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
 328         general_thread if the stop reply is missing a thread-id.
 329         (remote_target::process_stop_reply): Use the first non-exited
 330         thread if the target didn't pass a thread-id.
 331         * infrun.c (do_target_wait): Move call to
 332         switch_to_inferior_no_thread to ....
 333         (do_target_wait_1): ... here.
 334
 335 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
 336
 337         * debuginfod-support.c: Include defs.h first.
 338
 339 2020-02-28  Tom de Vries  <tdevries@suse.de>
 340
 341         * symfile.c (set_initial_language): Use default language for lookup.
 342
 343 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
 344
 345         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
 346         reader variable, pass `this` to read_cutu_die_from_dwo.
 347
 348 2020-02-27  Aaron Merey  <amerey@redhat.com>
 349
 350         * source.c (open_source_file): Check for nullptr when computing
 351         srcpath.
 352
 353 2020-02-27  Tom Tromey  <tromey@adacore.com>
 354
 355         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
 356         member.
 357         (dwarf2_add_field): Don't update nfields.
 358         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
 359
 360 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 361
 362         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
 363         abs.
 364
 365 2020-02-26  Tom Tromey  <tom@tromey.com>
 366
 367         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
 368         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
 369         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
 370         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
 371         per_cu_data.
 372
 373 2020-02-26  Tom Tromey  <tom@tromey.com>
 374
 375         * dwarf2/index-write.c (psym_index_map): Change type.
 376         (add_address_entry_worker, write_one_signatured_type)
 377         (recursively_count_psymbols, recursively_write_psymbols)
 378         (class debug_names, psyms_seen_size, write_gdbindex)
 379         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
 380
 381 2020-02-26  Aaron Merey  <amerey@redhat.com>
 382
 383         * Makefile.in: Handle optional debuginfod support.
 384         * NEWS: Update.
 385         * README: Add --with-debuginfod summary.
 386         * config.in: Regenerate.
 387         * configure: Regenerate.
 388         * configure.ac: Handle optional debuginfod support.
 389         * debuginfod-support.c: debuginfod helper functions.
 390         * debuginfod-support.h: Ditto.
 391         * doc/gdb.texinfo: Add --with-debuginfod to configure options
 392         summary.
 393         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
 394         when a dwz file cannot be found.
 395         * elfread.c (elf_symfile_read): Query debuginfod servers when a
 396         debuginfo file cannot be found.
 397         * source.c (open_source_file): Query debuginfod servers when a
 398         source file cannot be found.
 399         * top.c (print_gdb_configuration): Include
 400         --{with,without}-debuginfod in the output.
 401
 402 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
 403
 404         * thread.c (thr_try_catch_cmd): Print thread name.
 405
 406 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
 407
 408         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
 409         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 410         dwarf2_fetch_die_type_sect_off): Move to...
 411         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
 412         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 413         dwarf2_fetch_die_type_sect_off): ... here.
 414         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
 415         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 416         dwarf2_fetch_die_type_sect_off): Move doc to header file.
 417
 418 2020-02-26  Tom de Vries  <tdevries@suse.de>
 419
 420         PR gdb/25603
 421         * symfile.c (set_initial_language): Exit-early if
 422         language_mode == language_mode_manual.
 423
 424 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 425
 426         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
 427         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
 428         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
 429
 430 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 431
 432         * gdbtypes.c (create_array_type_with_stride): Handle negative
 433         array strides.
 434         * valarith.c (value_subscripted_rvalue): Likewise.
 435
 436 2020-02-25  Luis Machado  <luis.machado@linaro.org>
 437
 438         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
 439
 440 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 441
 442         * loc.h (dwarf2_get_die_type): Move to...
 443         * read.h (dwarf2_get_die_type): ... here.
 444         * read.c (dwarf2_get_die_type): Move doc to header.
 445
 446 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
 447
 448         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
 449         'gnulib/Makefile.in' to the list.
 450
 451 2020-02-24  Tom Tromey  <tom@tromey.com>
 452
 453         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
 454         Remove.
 455         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
 456         XOBNEWVEC.
 457
 458 2020-02-24  Tom Tromey  <tom@tromey.com>
 459
 460         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
 461         New method.
 462         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
 463         (dw2_do_instantiate_symtab, dw2_get_file_names)
 464         (build_type_psymtab_dependencies, load_full_type_unit): Update.
 465
 466 2020-02-24  Tom Tromey  <tom@tromey.com>
 467
 468         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
 469         make_scoped_restore.
 470         (dwarf2_psymtab::read_symtab): Don't clear
 471         reading_partial_symbols.
 472
 473 2020-02-24  Tom de Vries  <tdevries@suse.de>
 474
 475         PR gdb/25592
 476         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
 477
 478 2020-02-24  Tom de Vries  <tdevries@suse.de>
 479
 480         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
 481         commands layout next/prev/regs.
 482
 483 2020-02-22  Tom Tromey  <tom@tromey.com>
 484
 485         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
 486         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
 487
 488 2020-02-22  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
 491
 492 2020-02-22  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-win.c (_initialize_tui_win): Add usage text.
 495         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
 496         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
 497         * tui/tui.c (_initialize_tui): Add usage text.
 498
 499 2020-02-22  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-win.c (tui_set_focus_command)
 502         (tui_set_win_height_command): Use error_no_arg.
 503         (_initialize_tui_win): Update help text.
 504         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
 505
 506 2020-02-22  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
 509         * tui/tui-disasm.h (struct tui_disasm_window)
 510         <display_start_addr>: Declare.
 511         * tui/tui-source.h (struct tui_source_window)
 512         <display_start_addr>: Declare.
 513         * tui/tui-winsource.h (struct tui_source_window_base)
 514         <show_source_line, display_start_addr>: New methods.
 515         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
 516         Rename and move to protected section.
 517         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 518         (tui_source_window_base::do_erase_source_content): Update.
 519         (tui_source_window_base::show_source_line): Now a method.
 520         (tui_source_window_base::show_source_content)
 521         (tui_source_window_base::tui_source_window_base)
 522         (tui_source_window_base::rerender)
 523         (tui_source_window_base::refill)
 524         (tui_source_window_base::do_scroll_horizontal)
 525         (tui_source_window_base::set_is_exec_point_at)
 526         (tui_source_window_base::update_breakpoint_info)
 527         (tui_source_window_base::update_exec_info): Update.
 528         * tui/tui-source.c (tui_source_window::set_contents)
 529         (tui_source_window::showing_source_p)
 530         (tui_source_window::do_scroll_vertical)
 531         (tui_source_window::location_matches_p)
 532         (tui_source_window::line_is_displayed): Update.
 533         (tui_source_window::display_start_addr): New method.
 534         * tui/tui-disasm.c (tui_disasm_window::set_contents)
 535         (tui_disasm_window::do_scroll_vertical)
 536         (tui_disasm_window::location_matches_p): Update.
 537         (tui_disasm_window::display_start_addr): New method.
 538
 539 2020-02-22  Tom Tromey  <tom@tromey.com>
 540
 541         * NEWS: Add entry for gdb.register_window_type.
 542         * tui/tui-layout.h (window_factory): New typedef.
 543         (tui_register_window): Declare.
 544         * tui/tui-layout.c (saved_tui_windows): New global.
 545         (tui_apply_current_layout): Use it.
 546         (tui_register_window): New function.
 547         * python/python.c (do_start_initialization): Call
 548         gdbpy_initialize_tui.
 549         (python_GdbMethods): Add "register_window_type" function.
 550         * python/python-internal.h (gdbpy_register_tui_window)
 551         (gdbpy_initialize_tui): Declare.
 552         * python/py-tui.c: New file.
 553         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
 554
 555 2020-02-22  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
 558
 559 2020-02-22  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
 562         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
 563         * tui/tui-data.c (tui_set_win_with_focus): Remove.
 564         (tui_set_win_focus_to): Move from tui-win.c.
 565
 566 2020-02-22  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-layout.c (make_standard_window, get_locator_window): New
 569         functions.
 570         (known_window_types): New global.
 571         (tui_get_window_by_name): Reimplement.
 572         (initialize_known_windows): New function.
 573         (validate_window_name): Rewrite.
 574         (_initialize_tui_layout): Call initialize_known_windows.
 575
 576 2020-02-22  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
 579         Remove constants.
 580         * tui/tui-winsource.h (struct tui_source_window_base)
 581         <tui_source_window_base>: Remove parameter.
 582         * tui/tui-winsource.c
 583         (tui_source_window_base::tui_source_window_base): Remove
 584         parameter.
 585         (tui_source_window_base::refill): Update.
 586         * tui/tui-stack.h (struct tui_locator_window)
 587         <tui_locator_window>: Update.
 588         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
 589         Default the constructor.
 590         * tui/tui-regs.h (struct tui_data_item_window)
 591         <tui_data_item_window>: Default the constructor.
 592         (struct tui_data_window) <tui_data_window>: Likewise.
 593         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
 594         Default the constructor.
 595         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
 596         Default the constructor.
 597         <type>: Remove.
 598         (struct tui_win_info) <tui_win_info>: Default the constructor.
 599         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
 600         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 601         Default the constructor.
 602
 603 2020-02-22  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
 606         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
 607         * tui/tui-win.c (tui_resize_all): Don't call
 608         tui_delete_invisible_windows.
 609         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
 610         done.
 611         (tui_set_layout): Update.
 612         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
 613         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
 614         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
 615
 616 2020-02-22  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
 619         correctly.
 620
 621 2020-02-22  Tom Tromey  <tom@tromey.com>
 622
 623         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
 624
 625 2020-02-22  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-winsource.h (struct tui_source_window_iterator)
 628         <inner_iterator>: New etytypedef.
 629         <tui_source_window_iterator>: Take "end" parameter.
 630         <tui_source_window_iterator>: Take iterator.
 631         <operator*, advance>: Update.
 632         <m_iter>: Change type.
 633         <m_end>: New field.
 634         (struct tui_source_windows) <begin, end>: Update.
 635         * tui/tui-layout.c (tui_windows): New global.
 636         (tui_apply_current_layout): Clear tui_windows.
 637         (tui_layout_window::apply): Update tui_windows.
 638         * tui/tui-data.h (tui_windows): Declare.
 639         (all_tui_windows): Now inline function.
 640         (class tui_window_iterator, struct all_tui_windows): Remove.
 641
 642 2020-02-22  Tom Tromey  <tom@tromey.com>
 643
 644         PR tui/17850:
 645         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
 646         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
 647         "height" argument.
 648         (class tui_layout_window) <get_sizes>: Likewise.
 649         (class tui_layout_split) <tui_layout_split>: Add "vertical"
 650         argument.
 651         <get_sizes>: Add "height" argument.
 652         <m_vertical>: New field.
 653         * tui/tui-layout.c (tui_layout_split::clone): Update.
 654         (tui_layout_split::get_sizes): Add "height" argument.
 655         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
 656         (tui_new_layout_command): Parse "-horizontal".
 657         (_initialize_tui_layout): Update help string.
 658         (tui_layout_split::specification): Add "-horizontal" when needed.
 659         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
 660         argument.
 661         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
 662         New methods.
 663
 664 2020-02-22  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-layout.h (enum tui_adjust_result): New.
 667         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
 668         (class tui_layout_window) <adjust_size>: Return
 669         tui_adjust_result.  Rewrite.
 670         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
 671         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
 672
 673 2020-02-22  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
 676         parameter and return types.
 677         (class tui_layout_base) <specification>: Add "depth".
 678         (class tui_layout_window) <specification>: Add "depth".
 679         (class tui_layout_split) <specification>: Add "depth".
 680         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
 681         and return types.
 682         (tui_new_layout_command): Parse sub-layouts.
 683         (_initialize_tui_layout): Update help string.
 684         (tui_layout_window::specification): Add "depth".
 685         (add_layout_command): Update.
 686
 687 2020-02-22  Tom Tromey  <tom@tromey.com>
 688
 689         * NEWS: Add "tui new-layout" item.
 690         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
 691         Add new-layout command to help text.
 692         (validate_window_name): New function.
 693         (tui_new_layout_command): New function.
 694         (_initialize_tui_layout): Register "new-layout".
 695         (tui_layout_window::specification): New method.
 696         (tui_layout_window::specification): New method.
 697         * tui/tui-layout.h (class tui_layout_base) <specification>: New
 698         method.
 699         (class tui_layout_window) <specification>: New method.
 700         (class tui_layout_split) <specification>: New method.
 701
 702 2020-02-22  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
 705         * tui/tui-win.c (window_name_completer): Update comment.
 706         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
 707         Declare method.
 708         (class tui_layout_window) <replace_window>: Likewise.
 709         (class tui_layout_split) <replace_window>: Likewise.
 710         (tui_set_layout): Don't declare.
 711         (tui_set_initial_layout): Declare function.
 712         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
 713         (asm_regs_layout): New globals.
 714         (tui_current_layout, show_layout): Remove.
 715         (tui_set_layout, tui_add_win_to_layout): Rewrite.
 716         (find_layout, tui_apply_layout): New function.
 717         (layout_completer): Remove.
 718         (tui_next_layout): Reimplement.
 719         (tui_next_layout_command): New function.
 720         (tui_set_initial_layout, tui_prev_layout_command): New functions.
 721         (tui_regs_layout): Reimplement.
 722         (tui_regs_layout_command): New function.
 723         (extract_display_start_addr): Rewrite.
 724         (next_layout, prev_layout): Remove.
 725         (tui_layout_window::replace_window): New method.
 726         (tui_layout_split::replace_window): New method.
 727         (destroy_layout): New function.
 728         (layout_list): New global.
 729         (add_layout_command): New function.
 730         (initialize_layouts): Update.
 731         (tui_layout_command): New function.
 732         (_initialize_tui_layout): Install "layout" commands.
 733         * tui/tui-data.h (enum tui_layout_type): Remove.
 734         (tui_current_layout): Don't declare.
 735
 736 2020-02-22  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-regs.c (tui_reg_layout): Remove.
 739         (tui_reg_command): Use tui_regs_layout.
 740         * tui/tui-layout.h (tui_reg_command): Declare.
 741         * tui/tui-layout.c (tui_reg_command): New function.
 742
 743 2020-02-22  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui.c (tui_rl_delete_other_windows): Call
 746         tui_remove_some_windows.
 747         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
 748         Declare method.
 749         (class tui_layout_window) <remove_windows>: New method.
 750         (class tui_layout_split) <remove_windows>: Declare.
 751         (tui_remove_some_windows): Declare.
 752         * tui/tui-layout.c (tui_remove_some_windows): New function.
 753         (tui_layout_split::remove_windows): New method.
 754
 755 2020-02-22  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
 758         * tui/tui-layout.h (tui_next_layout): Declare.
 759         * tui/tui-layout.c (tui_next_layout): New function.
 760
 761 2020-02-22  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
 764         correct coordinates.
 765
 766 2020-02-22  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
 769         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
 770         DATA_WIN case.
 771
 772 2020-02-22  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
 775         TUI_DISASM_WIN, not tui_win_list.
 776
 777 2020-02-22  Tom Tromey  <tom@tromey.com>
 778
 779         * valprint.c (generic_val_print_enum_1)
 780         (val_print_type_code_flags): Style member names.
 781         * rust-lang.c (val_print_struct, rust_print_enum)
 782         (rust_print_struct_def, rust_internal_print_type): Style member
 783         names.
 784         * p-valprint.c (pascal_object_print_value_fields): Style member
 785         names.  Only call fprintf_symbol_filtered for static members.
 786         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
 787         * f-valprint.c (f_val_print): Style member names.
 788         * f-typeprint.c (f_type_print_base): Style member names.
 789         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
 790         call fprintf_symbol_filtered for static members.
 791         (cp_print_class_member): Style member names.
 792         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
 793         member names.
 794         * ada-valprint.c (ada_print_scalar): Style enum names.
 795         (ada_val_print_enum): Likewise.
 796         * ada-typeprint.c (print_enum_type): Style enum names.
 797
 798 2020-02-21  Tom Tromey  <tom@tromey.com>
 799
 800         * psympriv.h (struct partial_symtab): Update comment.
 801
 802 2020-02-21  Tom Tromey  <tromey@adacore.com>
 803
 804         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
 805         type is CORE_ADDR.
 806
 807 2020-02-21  Tom de Vries  <tdevries@suse.de>
 808
 809         PR gdb/25534
 810         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
 811         if dependencies[i]->user != NULL.
 812
 813 2020-02-21  Ali Tamur  <tamur@google.com>
 814
 815         * dwarf2/read.c (dwarf2_name): Add null check.
 816
 817 2020-02-20  Tom Tromey  <tom@tromey.com>
 818
 819         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
 820         ">=", in binary search.
 821         (dwarf2_find_containing_comp_unit): New overload.
 822         (run_test): New self-test.
 823         (_initialize_dwarf2_read): Register new test.
 824
 825 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
 826
 827         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
 828         * riscv-tdep.h: Likewise.
 829         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
 830         rv32-only CSR.
 831         * features/riscv/64bit-csr.xml: Regenerated.
 832
 833 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
 834             Tom Tromey  <tom@tromey.com>
 835
 836         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
 837         of 'fputc_unfiltered'.
 838         (putchar_unfiltered): Call 'fputc_unfiltered'.
 839         (fputc_unfiltered): Call 'fputs_unfiltered'.
 840
 841 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
 842
 843         * config.in: Regenerate.
 844         * configure: Regenerate.
 845         * configure.ac: Add --with-python-libdir option.
 846         * main.c: Use WITH_PYTHON_LIBDIR.
 847
 848 2020-02-19  Tom Tromey  <tom@tromey.com>
 849
 850         * symtab.c (general_symbol_info::compute_and_set_names): Use
 851         obstack_strndup.  Simplify call to symbol_set_demangled_name.
 852
 853 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
 854
 855         * dwarf2/read.c (allocate_signatured_type_table,
 856         allocate_dwo_unit_table, allocate_type_unit_groups_table,
 857         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
 858         Remove objfile parameter, update all callers.
 859
 860 2020-02-19  Doug Evans  <dje@google.com>
 861
 862         PR rust/25535
 863         * rust-lang.c (rust_print_enum): Apply embedded_offset to
 864         rust_enum_variant calculation.
 865
 866 2020-02-19  Tom Tromey  <tromey@adacore.com>
 867
 868         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
 869
 870 2020-02-19  Tom Tromey  <tromey@adacore.com>
 871
 872         * ada-lang.c (cache_symbol): Use obstack_strdup.
 873
 874 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * configure: Regenerate.
 877
 878 2020-02-19  Tom Tromey  <tromey@adacore.com>
 879
 880         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
 881         NULL check.
 882
 883 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
 884
 885         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
 886
 887 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
 890         if GDBSERVER is not defined.
 891         (riscv_tdesc_cache): Likewise, also store const target_desc.
 892         (STATIC_IN_GDB): Define.
 893         (riscv_create_target_description): Update declaration with
 894         STATIC_IN_GDB.
 895         (riscv_lookup_target_description): New function, only define if
 896         GDBSERVER is not defined.
 897         * arch/riscv.h (riscv_create_target_description): Declare only
 898         when GDBSERVER is defined.
 899         (riscv_lookup_target_description): New declaration when GDBSERVER
 900         is not defined.
 901         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
 902         (riscv_linux_read_features): ...this, and return
 903         riscv_gdbarch_features instead of target_desc.
 904         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
 905         (riscv_linux_read_description): Rename to...
 906         (riscv_linux_read_features): ...this.
 907         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
 908         Update to use riscv_gdbarch_features and
 909         riscv_lookup_target_description.
 910         * riscv-tdep.c (riscv_find_default_target_description): Use
 911         riscv_lookup_target_description instead of
 912         riscv_create_target_description.
 913
 914 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 915
 916         * valprint.c (generic_val_print_enum_1): When printing a flag
 917         enum with value 0 and there is no enumerator with value 0, print
 918         just "0" instead of "(unknown: 0x0)".
 919
 920 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 921
 922         * valprint.c (generic_val_print_enum_1): Print unknown part of
 923         flag enum in hex.
 924
 925 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 926
 927         * dwarf2/read.c (update_enumeration_type_from_children): Allow
 928         flag enums to contain duplicate enumerators.
 929         * valprint.c (generic_val_print_enum_1): Update comment.
 930
 931 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 932
 933         * dwarf2/read.c: Include "count-one-bits.h".
 934         (update_enumeration_type_from_children): If an enumerator has
 935         multiple bits set, don't treat the enumeration as a "flag enum".
 936         * valprint.c (generic_val_print_enum_1): Assert that enumerators
 937         of flag enums have 0 or 1 bit set.
 938
 939 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 940
 941         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
 942         conversion.
 943         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 944         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
 945         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 946         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
 947         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
 948
 949 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 950
 951         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
 952
 953 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 954
 955         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
 956         displaced_step_closure_up.
 957         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
 958         (struct displaced_step_closure_up):
 959         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 960         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
 961         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
 962         Likewise.
 963         * gdbarch.sh (displaced_step_copy_insn): Likewise.
 964         * gdbarch.c, gdbarch.h: Re-generate.
 965         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
 966         displaced_step_closure_up.
 967         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 968         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
 969         * infrun.h (displaced_step_closure_up): New type alias.
 970         (struct displaced_step_inferior_state) <step_closure>: Change
 971         type to displaced_step_closure_up.
 972         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
 973         displaced_step_closure_up.
 974         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
 975
 976 2020-02-14  Tom Tromey  <tom@tromey.com>
 977
 978         * minidebug.c (gnu_debug_key): New global.
 979         (find_separate_debug_file_in_section): Use it.
 980
 981 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 982
 983         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
 984         std::unique_ptr.
 985         * gdbarch.c: Re-generate.
 986         * gdbarch.h: Re-generate.
 987         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
 988         change.
 989         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
 990         type to std::unique_ptr.
 991         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
 992         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 993         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
 994         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
 995         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
 996         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 997         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
 998         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
 999         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1000
1001 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1002
1003         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
1004         std::unique_ptr.
1005         (displaced_step_clear): Rename to...
1006         (displaced_step_reset): ... this.  Just call displaced->reset ().
1007         (displaced_step_clear_cleanup): Rename to...
1008         (displaced_step_reset_cleanup): ... this.
1009         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
1010         (displaced_step_fixup): Likewise.
1011         (resume_1): Likewise.
1012         (handle_inferior_event): Restore child's memory before calling
1013         displaced_step_fixup on the parent.
1014         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
1015         to std::unique_ptr.
1016         <step_closure>: Change type to std::unique_ptr.
1017
1018 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1019
1020         * arm-tdep.c: Include count-one-bits.h.
1021         (cleanup_block_store_pc): Use count_one_bits.
1022         (cleanup_block_load_pc): Use count_one_bits.
1023         (arm_copy_block_xfer): Use count_one_bits.
1024         (thumb2_copy_block_xfer): Use count_one_bits.
1025         (thumb_copy_pop_pc_16bit): Use count_one_bits.
1026         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
1027         (thumb_get_next_pcs_raw): Use count_one_bits.
1028         (arm_get_next_pcs_raw): Use count_one_bits_l.
1029         * arch/arm.c (bitcount): Remove.
1030         * arch/arm.h (bitcount): Remove.
1031
1032 2020-02-14  Tom Tromey  <tromey@adacore.com>
1033
1034         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
1035         Update.
1036         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
1037         * dwarf2/loc.c (call_site_find_chain_1): Return
1038         unique_xmalloc_ptr.
1039         (call_site_find_chain): Likewise.
1040
1041 2020-02-14  Richard Biener  <rguenther@suse.de>
1042
1043         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
1044         on expression with division operators.
1045
1046 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1047
1048         * MAINTAINERS (Write After Approval): Adding myself.
1049
1050 2020-02-12  Tom Tromey  <tom@tromey.com>
1051
1052         * event-loop.c (event_data, gdb_event, event_handler_func):
1053         Remove.
1054
1055 2020-02-12  Tom Tromey  <tom@tromey.com>
1056
1057         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
1058         (dwarf2_frame_objfile_data): Add comment.
1059         (find_comp_unit, set_comp_unit): New functions.
1060         (dwarf2_frame_find_fde): Use find_comp_unit.
1061         (dwarf2_build_frame_info): Use set_comp_unit.
1062
1063 2020-02-12  Tom Tromey  <tom@tromey.com>
1064
1065         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
1066         (comp_unit): Don't initialize objfile.
1067         (execute_cfa_program): Add text_offset parameter.
1068         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
1069         (dwarf2_frame_cache): Update.
1070         (dwarf2_build_frame_info): Don't set "objfile" member.
1071
1072 2020-02-12  Tom Tromey  <tom@tromey.com>
1073
1074         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
1075         (decode_frame_entry): Likewise.
1076         (dwarf2_build_frame_info): Update.
1077
1078 2020-02-12  Tom Tromey  <tom@tromey.com>
1079
1080         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
1081         (decode_frame_entry_1): Use the comp_unit obstack.
1082
1083 2020-02-12  Tom Tromey  <tom@tromey.com>
1084
1085         * dwarf2/frame.c (struct comp_unit): Add initializers and
1086         constructor.
1087         (dwarf2_frame_objfile_data): Store a comp_unit.
1088         (dwarf2_frame_find_fde): Update.
1089         (dwarf2_build_frame_info): Use "new".
1090
1091 2020-02-12  Tom Tromey  <tom@tromey.com>
1092
1093         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
1094         (dwarf2_fde_table): Typedef for std::vector.
1095         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
1096         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
1097         (decode_frame_entry): Update.
1098         (dwarf2_build_frame_info): Use "new".
1099
1100 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1101
1102         * arm-tdep.c (arm_gdbarch_init): Update.
1103         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
1104         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
1105         have_neon, is_m>: Change to bool.
1106
1107 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1108
1109         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
1110
1111 2020-02-12  Tom Tromey  <tom@tromey.com>
1112
1113         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
1114
1115 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
1116
1117         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
1118         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
1119
1120 2020-02-11  Tom Tromey  <tom@tromey.com>
1121
1122         * psymtab.h: Update comment.
1123
1124 2020-02-11  Tom Tromey  <tom@tromey.com>
1125
1126         * gdb_obstack.h (struct auto_obstack): Use
1127         DISABLE_COPY_AND_ASSIGN.
1128
1129 2020-02-11  Tom Tromey  <tom@tromey.com>
1130
1131         * dwarf2/frame.h (struct objfile): Don't forward declare.
1132
1133 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1134
1135         * cris-tdep.c (cris_supply_gregset): Change signature to match
1136         what struct regset expects.
1137         (cris_regset): New struct.
1138         (fetch_core_registers): Remove.
1139         (cris_iterate_over_regset_sections): New function.
1140         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
1141         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
1142
1143 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1144
1145         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
1146         registers.
1147
1148 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1149
1150         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
1151
1152 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1153
1154         * configure: Re-generate.
1155
1156 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1157
1158         * configure: Re-generate.
1159
1160 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1161
1162         * acinclude: Update warning.m4 path.
1163         * warning.m4: Move to gdbsupport.
1164
1165 2020-02-11  Tom Tromey  <tromey@adacore.com>
1166
1167         * remote.c (remote_console_output): Update.
1168         * printcmd.c (printf_command): Update.
1169         * event-loop.c (gdb_wait_for_event): Update.
1170         * linux-nat.c (sigchld_handler): Update.
1171         * remote-sim.c (gdb_os_write_stdout): Update.
1172         (gdb_os_flush_stdout): Update.
1173         (gdb_os_flush_stderr): Update.
1174         (gdb_os_write_stderr): Update.
1175         * exceptions.c (print_exception): Update.
1176         * remote-fileio.c (remote_fileio_func_read): Update.
1177         (remote_fileio_func_write): Update.
1178         * tui/tui.c (tui_enable): Update.
1179         * tui/tui-interp.c (tui_interp::init): Update.
1180         * utils.c (init_page_info): Update.
1181         (putchar_unfiltered, fputc_unfiltered): Update.
1182         (gdb_flush): Update.
1183         (emit_style_escape): Update.
1184         (flush_wrap_buffer, fputs_maybe_filtered): Update.
1185         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
1186         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
1187         (stderr_file::write): Update.
1188         (stderr_file::puts): Update.
1189         * ui-file.h (ui_file_isatty, ui_file_write)
1190         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
1191         (ui_file_puts): Don't declare.
1192
1193 2020-02-10  Tom de Vries  <tdevries@suse.de>
1194
1195         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
1196         sentinel to char *.
1197
1198 2020-02-09  Tom de Vries  <tdevries@suse.de>
1199
1200         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
1201         filename if it matches "<artificial>".
1202
1203 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1204
1205         * windows-tdep.c (struct enum_value_name): New struct.
1206         (create_enum): New function.
1207         (windows_get_siginfo_type): Create and use enum types.
1208
1209 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1210
1211         * NEWS: Mention $_siginfo support for Windows.
1212         * windows-nat.c (handle_exception): Set siginfo_er.
1213         (windows_nat_target::mourn_inferior): Reset siginfo_er.
1214         (windows_xfer_siginfo): New function.
1215         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
1216         * windows-tdep.c (struct windows_gdbarch_data): New struct.
1217         (init_windows_gdbarch_data): New function.
1218         (get_windows_gdbarch_data): New function.
1219         (windows_get_siginfo_type): New function.
1220         (windows_init_abi): Register windows_get_siginfo_type.
1221         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
1222
1223 2020-02-08  Tom Tromey  <tom@tromey.com>
1224
1225         * dwarf2/read.c (class cutu_reader) <cutu_reader,
1226         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
1227         <keep>: Declare method.
1228         <m_keep>: Remove member.
1229         <~cutu_reader>: Remove.
1230         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1231         (cutu_reader::cutu_reader): Update.
1232         (cutu_reader::keep): Rename from ~cutu_reader.
1233         (process_psymtab_comp_unit, build_type_psymtabs_1)
1234         (process_skeletonless_type_unit, load_partial_comp_unit)
1235         (load_full_comp_unit, dwarf2_read_addr_index)
1236         (read_signatured_type): Update.
1237
1238 2020-02-08  Tom Tromey  <tom@tromey.com>
1239
1240         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
1241         "want_partial_unit" parameter.
1242         (process_psymtab_comp_unit): Change want_partial_unit to bool.
1243         Inline check for DW_TAG_partial_unit.
1244         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
1245
1246 2020-02-08  Tom Tromey  <tom@tromey.com>
1247
1248         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
1249         read.c.
1250         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
1251         read.c.
1252
1253 2020-02-08  Tom Tromey  <tom@tromey.com>
1254
1255         * dwarf2/read.c (read_address): Move to comp-unit.c.
1256         (dwarf2_rnglists_process, dwarf2_ranges_process)
1257         (read_attribute_value, dwarf_decode_lines_1)
1258         (var_decode_location, decode_locdesc): Update.
1259         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
1260         read.c.  Remove "cu" parameter.
1261         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
1262         method.
1263
1264 2020-02-08  Tom Tromey  <tom@tromey.com>
1265
1266         * dwarf2/read.c (read_attribute_value, read_indirect_string)
1267         (read_indirect_line_string): Update.
1268         * dwarf2/comp-unit.c (read_offset): Remove.
1269         (read_comp_unit_head): Update.
1270         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
1271         method.
1272         (read_offset): Don't declare.
1273
1274 2020-02-08  Tom Tromey  <tom@tromey.com>
1275
1276         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
1277         * dwarf2/read.c (struct comp_unit_head): Move to
1278         dwarf2/comp-unit.h.
1279         (enum class rcuh_kind): Move to comp-unit.h.
1280         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
1281         (read_comp_unit_head, error_check_comp_unit_head)
1282         (read_and_check_comp_unit_head): Move to comp-unit.c.
1283         (read_offset, dwarf_unit_type_name): Likewise.
1284         (create_debug_type_hash_table, read_cutu_die_from_dwo)
1285         (cutu_reader::cutu_reader, read_call_site_scope)
1286         (find_partial_die, follow_die_offset): Update.
1287         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
1288
1289 2020-02-08  Tom Tromey  <tom@tromey.com>
1290
1291         * dwarf2/read.c (read_offset_1): Move to leb.c.
1292         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
1293         (dwarf_decode_macro_bytes): Update.
1294         * dwarf2/leb.c (read_offset): Rename; move from read.c.
1295         * dwarf2/leb.h (read_offset): Declare.
1296
1297 2020-02-08  Tom Tromey  <tom@tromey.com>
1298
1299         * dwarf2/read.c (dwarf2_section_size): Remove.
1300         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
1301         Update.
1302         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
1303
1304 2020-02-08  Tom Tromey  <tom@tromey.com>
1305
1306         * dwarf2/read.c (read_initial_length): Move to leb.c.
1307         * dwarf2/leb.h (read_initial_length): Declare.
1308         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
1309         handle_nonstd parameter.
1310         * dwarf2/frame.c (read_initial_length): Remove.
1311         (decode_frame_entry_1): Update.
1312
1313 2020-02-08  Tom Tromey  <tom@tromey.com>
1314
1315         * dwarf2/loc.c (dwarf2_find_location_expression)
1316         (dwarf_evaluate_loc_desc::get_tls_address)
1317         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
1318         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
1319         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
1320         (dwarf2_compile_property_to_c)
1321         (dwarf2_loc_desc_get_symbol_read_needs)
1322         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
1323         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
1324         (loclist_describe_location, loclist_tracepoint_var_ref)
1325         (loclist_generate_c_location): Update.
1326         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1327         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
1328         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
1329         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
1330         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
1331         (dwarf2_per_cu_data::addr_size)
1332         (dwarf2_per_cu_data::ref_addr_size)
1333         (dwarf2_per_cu_data::text_offset)
1334         (dwarf2_per_cu_data::addr_type): Now methods.
1335         (per_cu_header_read_in): Make per_cu "const".
1336         (dwarf2_version): Remove.
1337         (dwarf2_per_cu_data::int_type): Now a method.
1338         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
1339         (set_die_type, read_array_type, read_subrange_index_type)
1340         (read_tag_string_type, read_subrange_type): Update.
1341         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
1342         offset_size, ref_addr_size, text_offset, addr_type, version,
1343         objfile, int_type, addr_sized_int_type>: Declare methods.
1344
1345 2020-02-08  Tom Tromey  <tom@tromey.com>
1346
1347         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
1348         Move earlier.
1349
1350 2020-02-08  Tom Tromey  <tom@tromey.com>
1351
1352         * dwarf2/read.h (dwarf_line_debug): Declare.
1353         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
1354         * dwarf2/read.c: Move line_header code to new files.
1355         (dwarf_line_debug): No longer static.
1356         * dwarf2/line-header.c: New file.
1357         * dwarf2/line-header.h: New file.
1358
1359 2020-02-08  Tom Tromey  <tom@tromey.com>
1360
1361         * dwarf2/read.c (struct line_header) <file_full_name,
1362         file_file_name>: Return unique_xmalloc_ptr.
1363         (line_header::file_file_name): Update.
1364         (line_header::file_full_name): Update.
1365         (dw2_get_file_names_reader): Update.
1366         (macro_start_file): Update.
1367
1368 2020-02-08  Tom Tromey  <tom@tromey.com>
1369
1370         * dwarf2/read.c (struct line_header) <file_full_name,
1371         file_file_name>: Declare methods.
1372         (dw2_get_file_names_reader): Update.
1373         (file_file_name): Now a method.
1374         (file_full_name): Likewise.
1375         (macro_start_file): Update.
1376
1377 2020-02-08  Tom Tromey  <tom@tromey.com>
1378
1379         * dwarf2/read.c (dwarf_always_disassemble)
1380         (show_dwarf_always_disassemble): Move to loc.c.
1381         (_initialize_dwarf2_read): Move "always-disassemble" registration
1382         to loc.c.
1383         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
1384         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
1385         static.
1386         (show_dwarf_always_disassemble): Move from read.c.
1387         (_initialize_dwarf2loc): Move always-disassemble from read.c.
1388
1389 2020-02-08  Tom Tromey  <tom@tromey.com>
1390
1391         * dwarf2/read.c (~dwarf2_per_objfile): Update.
1392         (create_quick_file_names_table): Return htab_up.
1393         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
1394         Update.
1395         * dwarf2/read.h (struct dwarf2_per_objfile)
1396         <quick_file_names_table>: Now htab_up.
1397
1398 2020-02-08  Tom Tromey  <tom@tromey.com>
1399
1400         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
1401
1402 2020-02-08  Tom Tromey  <tom@tromey.com>
1403
1404         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
1405         Rewrite.
1406         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
1407         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
1408         (abbrev_table::abbrev_table): No longer inline.
1409         (ABBREV_HASH_SIZE): Remove.
1410         (abbrev_table::m_abbrevs): Now an htab_up.
1411
1412 2020-02-08  Tom Tromey  <tom@tromey.com>
1413
1414         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
1415         (cutu_reader): Update.
1416         (build_type_psymtabs_1): Update.
1417         * dwarf2/abbrev.c (abbrev_table::read): Rename.
1418         (abbrev_table::alloc_abbrev): Update.
1419         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
1420         (abbrev_table::read): New static method, renamed from
1421         abbrev_table_read_table.
1422         (abbrev_table::alloc_abbrev)
1423         (abbrev_table::add_abbrev): Now private.
1424         (abbrev_table::abbrev_table): Now private.
1425         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
1426
1427 2020-02-08  Tom Tromey  <tom@tromey.com>
1428
1429         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
1430         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
1431         htab_up.
1432
1433 2020-02-08  Tom Tromey  <tom@tromey.com>
1434
1435         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
1436         htab_up.
1437         (lookup_dwo_unit_in_dwp): Update.
1438         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
1439         on obstack.
1440
1441 2020-02-08  Tom Tromey  <tom@tromey.com>
1442
1443         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
1444         obstack.
1445
1446 2020-02-08  Tom Tromey  <tom@tromey.com>
1447
1448         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
1449         line_header_hash.
1450         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
1451         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
1452         Change type to htab_up.
1453
1454 2020-02-08  Tom Tromey  <tom@tromey.com>
1455
1456         * dwarf2/read.c (allocate_type_unit_groups_table): Return
1457         htab_up.  Don't allocate on obstack.
1458         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
1459         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
1460         Change type to htab_up.
1461
1462 2020-02-08  Tom Tromey  <tom@tromey.com>
1463
1464         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
1465         Change type to htab_up.
1466         * dwarf2/read.c (create_signatured_type_table_from_index)
1467         (create_signatured_type_table_from_debug_names)
1468         (create_all_type_units, add_type_unit)
1469         (lookup_dwo_signatured_type, lookup_signatured_type)
1470         (process_skeletonless_type_unit): Update.
1471         (create_debug_type_hash_table, create_debug_types_hash_table):
1472         Change type of types_htab.
1473         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
1474         htab_up.  Don't allocate on obstack.
1475         (create_cus_hash_table): Change type of cus_htab parameter.
1476         (struct dwo_file) <cus, tus>: Now htab_up.
1477         (lookup_dwo_signatured_type, lookup_dwo_cutu)
1478         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
1479         (queue_and_load_all_dwo_tus): Update.
1480         * dwarf2/index-write.c (write_gdbindex): Update.
1481         (write_debug_names): Update.
1482
1483 2020-02-08  Tom Tromey  <tom@tromey.com>
1484
1485         * dwarf2/read.h (struct dwarf2_queue_item): Move from
1486         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
1487         destructor.
1488         (struct dwarf2_per_objfile) <queue>: New member.
1489         * dwarf2/read.c (struct dwarf2_queue_item): Move to
1490         dwarf2/read.h.
1491         (dwarf2_queue, dwarf2_queue_tail): Remove.
1492         (class dwarf2_queue_guard): Add parameter to constructor.  Use
1493         DISABLE_COPY_AND_ASSIGN.
1494         <m_per_objfile>: New member.
1495         <~dwarf2_queue_guard>: Rewrite.
1496         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
1497         Update.
1498         (~dwarf2_queue_item): New.
1499
1500 2020-02-08  Tom Tromey  <tom@tromey.com>
1501
1502         * dwarf2/read.c (struct die_info) <has_children>: New member.
1503         (dw2_get_file_names_reader): Remove has_children.
1504         (dw2_get_file_names): Update.
1505         (read_cutu_die_from_dwo): Remove has_children.
1506         (cutu_reader::init_tu_and_read_dwo_dies)
1507         (cutu_reader::cutu_reader): Update.
1508         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
1509         Remove has_children.
1510         (build_type_psymtabs_1, process_skeletonless_type_unit)
1511         (load_partial_comp_unit, load_full_comp_unit): Update.
1512         (create_dwo_cu_reader): Remove has_children.
1513         (create_cus_hash_table, read_die_and_children): Update.
1514         (read_full_die_1,read_full_die): Remove has_children.
1515         (read_signatured_type): Update.
1516         (class cutu_reader) <has_children>: Remove.
1517
1518 2020-02-08  Tom Tromey  <tom@tromey.com>
1519
1520         * dwarf2/expr.c: Rename from dwarf2expr.c.
1521         * dwarf2/expr.h: Rename from dwarf2expr.h.
1522         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
1523         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
1524         * dwarf2/frame.c: Rename from dwarf2-frame.c.
1525         * dwarf2/frame.h: Rename from dwarf2-frame.h.
1526         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
1527         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
1528         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
1529         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
1530         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
1531         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
1532         * dwarf2/loc.c: Rename from dwarf2loc.c.
1533         * dwarf2/loc.h: Rename from dwarf2loc.h.
1534         * dwarf2/read.c: Rename from dwarf2read.c.
1535         * dwarf2/read.h: Rename from dwarf2read.h.
1536         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
1537         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
1538         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
1539         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
1540         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
1541         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
1542         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
1543         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
1544         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
1545         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
1546         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
1547         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
1548         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
1549         Update.
1550         * Makefile.in (COMMON_SFILES): Update.
1551         (HFILES_NO_SRCDIR): Update.
1552
1553 2020-02-08  Tom Tromey  <tom@tromey.com>
1554
1555         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
1556         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
1557
1558 2020-02-08  Tom Tromey  <tom@tromey.com>
1559
1560         * dwarf2read.h (struct die_info): Don't declare.
1561
1562 2020-02-08  Tom Tromey  <tom@tromey.com>
1563
1564         * dwarf2read.h (die_info_ptr): Remove typedef.
1565
1566 2020-02-08  Tom Tromey  <tom@tromey.com>
1567
1568         * dwarf2read.c (read_call_site_scope)
1569         (handle_data_member_location, dwarf2_add_member_fn)
1570         (mark_common_block_symbol_computed, read_common_block)
1571         (attr_to_dynamic_prop, partial_die_info::read)
1572         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
1573         (dwarf2_symbol_mark_computed, set_die_type): Update.
1574         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
1575         method.
1576         (attr_form_is_block): Don't declare.
1577         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
1578
1579 2020-02-08  Tom Tromey  <tom@tromey.com>
1580
1581         * dwarf2read.c (dwarf2_find_base_address, )
1582         (read_call_site_scope, rust_containing_type)
1583         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
1584         (handle_data_member_location, dwarf2_add_member_fn)
1585         (get_alignment, read_structure_type, process_structure_scope)
1586         (mark_common_block_symbol_computed, read_common_block)
1587         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
1588         (partial_die_info::read, read_attribute_value, new_symbol)
1589         (lookup_die_type, dwarf2_get_ref_die_offset)
1590         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
1591         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
1592         (dwarf2_symbol_mark_computed): Update.
1593         * dwarf2/attribute.h (struct attribute) <value_as_address,
1594         form_is_section_offset, form_is_constant, form_is_ref>: Declare
1595         methods.
1596         (value_as_address, attr_form_is_section_offset)
1597         (attr_form_is_constant, attr_form_is_ref): Don't declare.
1598         * dwarf2/attribute.c (attribute::value_as_address)
1599         (attribute::form_is_section_offset, attribute::form_is_constant)
1600         (attribute::form_is_ref): Now methods.
1601
1602 2020-02-08  Tom Tromey  <tom@tromey.com>
1603
1604         * dwarf2read.c (struct attribute, DW_STRING)
1605         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
1606         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
1607         (attr_form_is_block, attr_form_is_section_offset)
1608         (attr_form_is_constant, attr_form_is_ref): Move.
1609         * dwarf2/attribute.h: New file.
1610         * dwarf2/attribute.c: New file, from dwarf2read.c.
1611         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
1612
1613 2020-02-08  Tom Tromey  <tom@tromey.com>
1614
1615         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
1616         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
1617         Move.
1618         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
1619         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
1620         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
1621         abbrev.c.
1622         * dwarf2/abbrev.h: New file.
1623         * dwarf2/abbrev.c: New file, from dwarf2read.c.
1624         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
1625
1626 2020-02-08  Tom Tromey  <tom@tromey.com>
1627
1628         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
1629         (dwarf2_section_size, dwarf2_get_section_info)
1630         (create_signatured_type_table_from_debug_names)
1631         (create_addrmap_from_aranges, read_debug_names_from_section)
1632         (get_gdb_index_contents_from_section, read_comp_unit_head)
1633         (error_check_comp_unit_head, read_abbrev_offset)
1634         (create_debug_type_hash_table, init_cu_die_reader)
1635         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
1636         (read_comp_units_from_section, create_cus_hash_table)
1637         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1638         (create_dwp_v2_section, dwarf2_rnglists_process)
1639         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
1640         (abbrev_table_read_table, read_indirect_string_at_offset_from)
1641         (read_indirect_string_from_dwz, read_addr_index_1)
1642         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
1643         (dwarf_decode_macro_bytes, dwarf_decode_macros)
1644         (fill_in_loclist_baton): Update.
1645         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
1646         get_containing_section, get_bfd_owner, get_bfd_section,
1647         get_file_name, get_id, get_flags, empty, read>: Declare methods.
1648         (dwarf2_read_section, get_section_name, get_section_file_name)
1649         (get_containing_section, get_section_bfd_owner)
1650         (get_section_bfd_section, get_section_name, get_section_file_name)
1651         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
1652         declare.
1653         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
1654         (dwarf2_section_info::get_bfd_owner)
1655         (dwarf2_section_info::get_bfd_section)
1656         (dwarf2_section_info::get_name)
1657         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
1658         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
1659         (dwarf2_section_info::read): Now methods.
1660         * dwarf-index-write.c (class debug_names): Update.
1661
1662 2020-02-08  Tom Tromey  <tom@tromey.com>
1663
1664         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
1665         Move to dwarf2/section.h.
1666         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
1667         (get_section_bfd_section, get_section_name)
1668         (get_section_file_name, get_section_id, get_section_flags)
1669         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
1670         dwarf2/section.c.
1671         * dwarf2/section.h: New file.
1672         * dwarf2/section.c: New file, from dwarf2read.c.
1673         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
1674
1675 2020-02-08  Tom Tromey  <tom@tromey.com>
1676
1677         * dwarf2read.h (read_unsigned_leb128): Don't declare.
1678         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
1679         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
1680         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
1681         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
1682         * dwarf2/leb.h: New file, from dwarf2read.c.
1683         * dwarf2/leb.c: New file, from dwarf2read.c.
1684         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
1685         Remove.
1686         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
1687         (COMMON_SFILES): Add dwarf2/leb.c.
1688
1689 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
1690
1691         GDB 9.1 released.
1692
1693 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1694
1695         PR gdb/25190:
1696         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
1697         * gdb/remote.c (remote_console_output): Update.
1698         * gdb/ui-file.c (fputs_unfiltered): Rename to...
1699         (ui_file_puts): ...this.
1700         * gdb/ui-file.h (ui_file_puts): Add declaration.
1701         * gdb/utils.c (emit_style_escape): Update.
1702         (flush_wrap_buffer): Update.
1703         (fputs_maybe_filtered): Update.
1704         (fputs_unfiltered): Add function.
1705
1706 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1707
1708         * gdb/event-loop.c (gdb_wait_for_event): Update.
1709         * gdb/printcmd.c (printf_command): Update.
1710         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
1711         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
1712         (gdb_os_flush_stderr): Update.
1713         * gdb/remote.c (remote_console_output): Update.
1714         * gdb/ui-file.c (gdb_flush): Rename to...
1715         (ui_file_flush): ...this.
1716         (stderr_file::write): Update.
1717         (stderr_file::puts): Update.
1718         * gdb/ui-file.h (gdb_flush): Rename to...
1719         (ui_file_flush): ...this.
1720         * gdb/utils.c (gdb_flush): Add function.
1721         * gdb/utils.h (gdb_flush): Add declaration.
1722
1723 2020-02-07  Tom Tromey  <tromey@adacore.com>
1724
1725         PR breakpoints/24915:
1726         * source.c (find_and_open_source): Do not check basenames_may_differ.
1727
1728 2020-02-07  Tom Tromey  <tom@tromey.com>
1729
1730         * README: Update gdbserver documentation.
1731         * gdbserver: Move to top level.
1732         * configure.tgt (build_gdbserver): Remove.
1733         * configure.ac: Remove --enable-gdbserver.
1734         * configure: Rebuild.
1735         * Makefile.in (distclean): Don't mention gdbserver.
1736
1737 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1738
1739         * source-cache.c (source_cache::ensure): Surround
1740         get_plain_source_lines with a try/catch.
1741         (source_cache::get_line_charpos): Get rid of try/catch
1742         and only check for the return value of "ensure".
1743         * tui/tui-source.c (tui_source_window::set_contents):
1744         Simplify "nlines" calculation.
1745
1746 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1747
1748         * MAINTAINERS (Write After Approval): Add myself.
1749
1750 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1751
1752         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
1753         function call.
1754
1755 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1756
1757         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
1758
1759 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
1760
1761         * nat/riscv-linux-tdesc.h: New file.
1762         * nat/riscv-linux-tdesc.c: New file, taking code from...
1763         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1764         ... here.
1765         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
1766         NATDEPFILES.
1767
1768 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
1771         we don't set the fake simulator ptid to the null_ptid.
1772
1773 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
1774
1775         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
1776         * gdbthread.h (class thread_info) <resumed>: Likewise.
1777         * infrun.c (resume_1): Likewise.
1778         (proceed): Likewise.
1779         (infrun_thread_stop_requested): Likewise.
1780         (stop_all_threads): Likewise.
1781         (handle_inferior_event): Likewise.
1782         (restart_threads): Likewise.
1783         (finish_step_over): Likewise.
1784         (keep_going_stepped_thread): Likewise.
1785         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
1786         (linux_handle_extended_wait): Likewise.
1787         * record-btrace.c (get_thread_current_frame_id): Likewise.
1788         * record-full.c (record_full_wait_1): Likewise.
1789         * remote.c (remote_target::process_initial_stop_replies): Likewise.
1790         * target.c (target_resume): Likewise.
1791         * thread.c (set_running_thread): Likewise.
1792
1793 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1794
1795         * f-valprint.c (f77_print_array_1): Changed datatype of index
1796         variable to LONGEST from int to enable it to contain bound
1797         values correctly.
1798
1799 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
1800
1801         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
1802         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
1803         offsets according to FLEN determined.
1804         (riscv_linux_nat_target::read_description): Determine FLEN
1805         dynamically.
1806         (riscv_linux_nat_target::fetch_registers): Size regset buffer
1807         according to FLEN determined.
1808         (riscv_linux_nat_target::store_registers): Likewise.
1809
1810 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1811
1812         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1813         when reg->group is empty and reggroup is not.
1814
1815 2020-01-31  Tom Tromey  <tromey@adacore.com>
1816
1817         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
1818         Call beneath target's mourn_inferior after unpushing.
1819
1820 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1821
1822         PR tui/9765
1823         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
1824         have enough lines to fill the screen, still return the lowest
1825         address we found.
1826
1827 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1828
1829         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
1830         '-', '<', and '>' commands.
1831
1832 2020-01-29  Pedro Alves  <palves@redhat.com>
1833             Sergio Durigan Junior  <sergiodj@redhat.com>
1834
1835         * infcmd.c (construct_inferior_arguments): Assert that
1836         'argc' is greater than 0.
1837
1838 2020-01-29  Luis Machado  <luis.machado@linaro.org>
1839
1840         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
1841         (BRK_INSN_MASK): Define to 0xd4200000.
1842         (aarch64_program_breakpoint_here_p): New function.
1843         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
1844         * arch-utils.c (default_program_breakpoint_here_p): Moved from
1845         breakpoint.c.
1846         * arch-utils.h (default_program_breakpoint_here_p): Moved from
1847         breakpoint.h
1848         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
1849         call gdbarch_program_breakpoint_here_p.
1850         (program_breakpoint_here): Moved to arch-utils.c, renamed to
1851         default_program_breakpoint_here_p, changed return type to bool and
1852         simplified.
1853         * breakpoint.h (program_breakpoint_here): Moved prototype to
1854         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
1855         return type to bool.
1856         * gdbarch.c: Regenerate.
1857         * gdbarch.h: Regenerate.
1858         * gdbarch.sh (program_breakpoint_here_p): New method.
1859         * infrun.c (handle_signal_stop): Call
1860         gdbarch_program_breakpoint_here_p.
1861
1862 2020-01-26  Tom Tromey  <tom@tromey.com>
1863
1864         * ctfread.c (struct ctf_fp_info): Reindent.
1865         (_initialize_ctfread): Remove.
1866
1867 2020-01-26  Tom Tromey  <tom@tromey.com>
1868
1869         * psymtab.c (partial_map_expand_apply)
1870         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
1871         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
1872         (psym_print_stats, psym_expand_symtabs_for_function)
1873         (psym_map_symbol_filenames, psym_map_matching_symbols)
1874         (psym_expand_symtabs_matching)
1875         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
1876         (maintenance_check_psymtabs): Use new methods.
1877         * psympriv.h (struct partial_symtab) <readin_p,
1878         get_compunit_symtab>: New methods.
1879         <readin, compunit_symtab>: Remove members.
1880         (struct standard_psymtab): New.
1881         (struct legacy_psymtab): Derive from standard_psymtab.
1882         * dwarf2read.h (struct dwarf2_psymtab): Derive from
1883         standard_psymtab.
1884         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
1885
1886 2020-01-26  Tom Tromey  <tom@tromey.com>
1887
1888         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
1889         read_dependencies.  Add assert.
1890         * psymtab.c (partial_symtab::read_dependencies): New method.
1891         * psympriv.h (struct partial_symtab) <read_dependencies>: New
1892         method.
1893         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
1894         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
1895         read_dependencies.
1896         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
1897         Add assert.
1898
1899 2020-01-26  Tom Tromey  <tom@tromey.com>
1900
1901         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
1902         Call expand_psymtab.
1903         (xcoff_read_symtab): Call expand_psymtab.
1904         (xcoff_start_psymtab, xcoff_end_psymtab): Set
1905         legacy_expand_psymtab.
1906         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
1907         method.
1908         (struct legacy_psymtab) <expand_psymtab>: Implement.
1909         <legacy_expand_psymtab>: New member.
1910         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
1911         (parse_partial_symbols): Set legacy_expand_psymtab.
1912         (psymtab_to_symtab_1): Change argument order.  Call
1913         expand_psymtab.
1914         (new_psymtab): Set legacy_expand_psymtab.
1915         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
1916         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
1917         expand_psymtab.
1918         (dwarf2_psymtab::expand_psymtab): Rename from
1919         psymtab_to_symtab_1.  Call expand_psymtab.
1920         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
1921         (dbx_end_psymtab): Likewise.
1922         (dbx_psymtab_to_symtab_1): Change argument order. Call
1923         expand_psymtab.
1924         (dbx_read_symtab): Call expand_psymtab.
1925         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
1926         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
1927         (ctf_psymtab::read_symtab): Call expand_psymtab.
1928
1929 2020-01-26  Tom Tromey  <tom@tromey.com>
1930
1931         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
1932         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
1933         messages.
1934         * mdebugread.c (mdebug_read_symtab): Remove prints.
1935         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
1936         assert.
1937         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
1938
1939 2020-01-26  Tom Tromey  <tom@tromey.com>
1940
1941         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
1942         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
1943         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
1944         legacy_symtab.
1945         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
1946         * psymtab.c (psymtab_to_symtab): Call method.
1947         (dump_psymtab): Update.
1948         * psympriv.h (struct partial_symtab): Add virtual destructor.
1949         <read_symtab>: New method.
1950         (struct legacy_symtab): New.
1951         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
1952         (struct pst_map) <pst>: Now a legacy_psymtab.
1953         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
1954         (new_psymtab): Use legacy_psymtab.
1955         * dwarf2read.h (struct dwarf2_psymtab): New.
1956         (struct dwarf2_per_cu_data) <psymtab>: Use it.
1957         * dwarf2read.c (dwarf2_create_include_psymtab)
1958         (dwarf2_build_include_psymtabs, create_type_unit_group)
1959         (create_partial_symtab, process_psymtab_comp_unit_reader)
1960         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
1961         (set_partial_user): Use dwarf2_psymtab.
1962         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
1963         (psymtab_to_symtab_1, process_full_comp_unit)
1964         (process_full_type_unit, dwarf2_ranges_read)
1965         (dwarf2_get_pc_bounds, psymtab_include_file_name)
1966         (dwarf_decode_lines): Use dwarf2_psymtab.
1967         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
1968         (add_address_entry_worker, write_one_signatured_type)
1969         (recursively_count_psymbols, recursively_write_psymbols)
1970         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
1971         (write_debug_names): Likewise.
1972         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
1973         <pst>: Now a legacy_psymtab.
1974         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
1975         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
1976         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
1977         * ctfread.c (struct ctf_psymtab): New.
1978         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
1979         ctf_psymtab.
1980         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
1981         (create_partial_symtab): Return a ctf_psymtab.
1982         (scan_partial_symbols): Update.
1983
1984 2020-01-26  Tom Tromey  <tom@tromey.com>
1985
1986         * xcoffread.c (xcoff_start_psymtab): Use new.
1987         * psymtab.c (partial_symtab::partial_symtab): New constructor,
1988         renamed from start_psymtab_common.
1989         * psympriv.h (struct partial_symtab): Add new constructor.
1990         (start_psymtab_common): Don't declare.
1991         * mdebugread.c (parse_partial_symbols): Use new.
1992         * dwarf2read.c (create_partial_symtab): Use new.
1993         * dbxread.c (start_psymtab): Use new.
1994         * ctfread.c (create_partial_symtab): Use new.
1995
1996 2020-01-26  Tom Tromey  <tom@tromey.com>
1997
1998         * xcoffread.c (xcoff_end_psymtab): Use new.
1999         * psymtab.c (start_psymtab_common): Use new.
2000         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
2001         Update.
2002         * psympriv.h (struct partial_symtab): Add parameters to
2003         constructor.  Don't inline.
2004         (allocate_psymtab): Don't declare.
2005         * mdebugread.c (new_psymtab): Use new.
2006         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
2007         * dbxread.c (dbx_end_psymtab): Use new.
2008
2009 2020-01-26  Tom Tromey  <tom@tromey.com>
2010
2011         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
2012         allocate_psymtab.  Update documentation.
2013         * psymtab.c (psymtab_storage::install_psymtab): Rename from
2014         allocate_psymtab.  Do not use new.
2015         (allocate_psymtab): Use new.  Update.
2016
2017 2020-01-26  Tom Tromey  <tom@tromey.com>
2018
2019         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2020         * psymtab.c (psym_print_stats): Update.
2021         * psympriv.h (struct partial_symtab) <readin,
2022         psymtabs_addrmap_supported, anonymous>: Now bool.
2023         * mdebugread.c (psymtab_to_symtab_1): Update.
2024         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
2025         (build_type_psymtabs_reader, psymtab_to_symtab_1)
2026         (process_full_comp_unit, process_full_type_unit): Update.
2027         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2028         * ctfread.c (psymtab_to_symtab): Update.
2029
2030 2020-01-26  Tom Tromey  <tom@tromey.com>
2031
2032         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
2033         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
2034         * psymtab.c (psymtab_storage): Delete psymtabs.
2035         (psymtab_storage::allocate_psymtab): Use new.
2036         (psymtab_storage::discard_psymtab): Use delete.
2037         * psympriv.h (struct partial_symtab): Add constructor and
2038         initializers.
2039
2040 2020-01-26  Tom Tromey  <tom@tromey.com>
2041
2042         * machoread.c: Do not include psympriv.h.
2043
2044 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2045
2046         * NEWS: Mention the new option and the set/show commands.
2047
2048 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2049
2050         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
2051         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
2052         (validate_exec_file): New variables, enums, functions.
2053         (exec_file_locate_attach, print_section_info): Style the filenames.
2054         (_initialize_exec): Install show_exec_file_mismatch_command and
2055          set_exec_file_mismatch_command.
2056         * gdbcore.h (validate_exec_file): Declare.
2057         * infcmd.c (attach_command): Call validate_exec_file.
2058         * remote.c ( remote_target::remote_add_inferior): Likewise.
2059
2060 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * frame.c (find_frame_sal): Move call to get_next_frame into more
2063         inner scope.
2064         * inline-frame.c (inilne_state) <inline_state>: Update argument
2065         types.
2066         (inilne_state) <skipped_symbol>: Rename to...
2067         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
2068         (skip_inline_frames): Build vector of skipped symbols and use this
2069         to reate the inline_state.
2070         (inline_skipped_symbol): Add a comment and some assertions, fetch
2071         skipped symbol from the list.
2072
2073 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2074
2075         * buildsym.c (lte_is_less_than): Delete.
2076         (buildsym_compunit::end_symtab_with_blockvector): Create local
2077         lambda function to sort line table entries, and use
2078         std::stable_sort instead of std::sort.
2079         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
2080         markers when looking for a previous line.
2081
2082 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * dwarf2read.c (lnp_state_machine::record_line): Include
2085         end_sequence parameter in debug print out.  Record the line if we
2086         are at an end_sequence marker even if it's not the start of a
2087         statement.
2088         * symmisc.c (maintenance_print_one_line_table): Print end of
2089         sequence markers with 'END' not '0'.
2090
2091 2020-01-24  Pedro Alves  <palves@redhat.com>
2092
2093         PR gdb/25410
2094         * thread.c (scoped_restore_current_thread::restore): Use
2095         switch_to_inferior_no_thread.
2096         * exec.c: Include "progspace-and-thread.h".
2097         (add_target_sections, remove_target_sections):
2098         scoped_restore_current_pspace_and_thread instead of
2099         scoped_restore_current_thread.
2100         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
2101         and aspace to the inferior before calling clone_program_space.
2102         Remove stale comment.
2103
2104 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2105
2106         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
2107         (arm_netbsd_nat_target::fetch_registers): ...this.
2108         (arm_nbsd_nat_target::store_registers): Rename to...
2109         (arm_netbsd_nat_target::store_registers): ...this.
2110
2111 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2112
2113         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2114         register_t.
2115
2116 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2117
2118         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
2119         Update comment.
2120         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
2121         Likewise.
2122         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
2123         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
2124         the correct replacement (iterate_over_regset_sections).
2125         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
2126         Update comment.
2127
2128 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
2129
2130         PR gdb/23718
2131         * gdb/python/python.c (execute_gdb_command): Call
2132         async_enable_stdin in catch block.
2133
2134 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2135
2136         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
2137         SWITCH_THRU_ALL_UIS.
2138
2139 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         PR tui/9765
2142         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
2143         comment, add extra parameter, and update to store previous symbol
2144         when appropriate.
2145         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
2146         add extra parameter.
2147         * tui/tui-disasm.c (tui_disassemble): Update header comment,
2148         remove unneeded parameter, add try/catch around gdb_print_insn,
2149         rewrite to add items to asm_lines vector.
2150         (tui_find_backward_disassembly_start_address): New function.
2151         (tui_find_disassembly_address): Updated throughout.
2152         (tui_disasm_window::set_contents): Update for changes to
2153         tui_disassemble.
2154         (tui_disasm_window::do_scroll_vertical): No need to adjust the
2155         number of lines to scroll.
2156
2157 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
2158
2159         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
2160         (SECT_OFF_DATA): Likewise.
2161         (SECT_OFF_RODATA): Likewise.
2162         (SECT_OFF_TEXT): Likewise.
2163         (SECT_OFF_BSS): Likewise.
2164         (struct objfile) <text_section_offset, data_section_offset>: New
2165         methods.
2166         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
2167         objfile::text_section_offset.
2168         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
2169         * coffread.c (coff_symtab_read): Likewise.
2170         (enter_linenos): Likewise.
2171         (process_coff_symbol): Likewise.
2172         * ctfread.c (get_objfile_text_range): Likewise.
2173         * dtrace-probe.c (dtrace_probe::get_relocated_address):
2174         Use objfile::data_section_offset.
2175         * dwarf2-frame.c (execute_cfa_program): Use
2176         objfile::text_section_offset.
2177         (dwarf2_frame_find_fde): Likewise.
2178         * dwarf2read.c (create_addrmap_from_index): Likewise.
2179         (create_addrmap_from_aranges): Likewise.
2180         (dw2_find_pc_sect_compunit_symtab): Likewise.
2181         (process_psymtab_comp_unit_reader): Likewise.
2182         (add_partial_symbol): Likewise.
2183         (add_partial_subprogram): Likewise.
2184         (process_full_comp_unit): Likewise.
2185         (read_file_scope): Likewise.
2186         (read_func_scope): Likewise.
2187         (read_lexical_block_scope): Likewise.
2188         (read_call_site_scope): Likewise.
2189         (dwarf2_rnglists_process): Likewise.
2190         (dwarf2_ranges_process): Likewise.
2191         (dwarf2_ranges_read): Likewise.
2192         (dwarf_decode_lines_1): Likewise.
2193         (new_symbol): Likewise.
2194         (dwarf2_fetch_die_loc_sect_off): Likewise.
2195         (dwarf2_per_cu_text_offset): Likewise.
2196         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
2197         * hppa-tdep.c (read_unwind_info): Likewise.
2198         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
2199         * psympriv.h (struct partial_symtab): Likewise.
2200         * psymtab.c (find_pc_sect_psymtab): Likewise.
2201         * solib-svr4.c (enable_break): Likewise.
2202         * stap-probe.c (relocate_address): Use
2203         objfile::data_section_offset.
2204         * xcoffread.c (enter_line_range): Use
2205         objfile::text_section_offset.
2206         (read_xcoff_symtab): Likewise.
2207
2208 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2209
2210         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
2211         declaration to narrower scopes.
2212
2213 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2214
2215         * darwin-nat.h (struct darwin_exception_msg, enum
2216         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
2217         Move up.
2218         (class darwin_nat_target) <wait_1, check_new_threads,
2219         decode_exception_message, decode_message, stop_inferior,
2220         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
2221         * darwin-nat.c (darwin_check_new_threads): Rename to...
2222         (darwin_nat_target::check_new_threads): ... this.
2223         (darwin_suspend_inferior_it): Remove.
2224         (darwin_decode_exception_message): Rename to...
2225         (darwin_nat_target::decode_exception_message): ... this.
2226         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
2227         (darwin_decode_message): Rename to...
2228         (darwin_nat_target::decode_message): ... this.
2229         (cancel_breakpoint): Rename to...
2230         (darwin_nat_target::cancel_breakpoint): ... this.
2231         (darwin_wait): Rename to...
2232         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
2233         instead of iterate_over_inferiors.
2234         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
2235         (darwin_stop_inferior): Rename to...
2236         (darwin_nat_target::stop_inferior): ... this.
2237         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
2238         (darwin_init_thread_list): Rename to...
2239         (darwin_nat_target::init_thread_list): ... this.
2240         (darwin_ptrace_him): Rename to...
2241         (darwin_nat_target::ptrace_him): ... this.
2242         (darwin_nat_target::create_inferior): Pass lambda function to
2243         fork_inferior.
2244         (darwin_nat_target::detach): Call stop_inferior instead of
2245         darwin_stop_inferior.
2246         * fork-inferior.h (fork_inferior): Change init_trace_fun
2247         parameter to gdb::function_view.
2248         * fork-inferior.c (fork_inferior): Likewise.
2249
2250 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
2251
2252         * i386-cygwin-tdep.c (core_process_module_section): Update.
2253         * windows-nat.c (struct lm_info_windows): Add text_offset.
2254         (windows_xfer_shared_libraries): Update.
2255         * windows-tdep.c (windows_xfer_shared_library):
2256         Add text_offset_cached argument.
2257         * windows-tdep.h (windows_xfer_shared_library): Update.
2258
2259 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2260
2261         * gdbarch.sh: Add declaration for _initialize_gdbarch.
2262
2263 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2264
2265         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
2266         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
2267         replace with range-based for.
2268         (gdbsim_interrupt_inferior): Remove.
2269         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
2270         with a range-based for.  Inline code from
2271         gdbsim_interrupt_inferior.
2272
2273 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2274
2275         * infrun.c (proceed): Fix indentation.
2276
2277 2020-01-21  Tom Tromey  <tromey@adacore.com>
2278
2279         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
2280         * python/python.c (python_extension_ops): Update.
2281         (gdbpy_colorize): New function.
2282         * python/lib/gdb/__init__.py (colorize): New function.
2283         * extension.h (ext_lang_colorize): Declare.
2284         * extension.c (ext_lang_colorize): New function.
2285         * extension-priv.h (struct extension_language_ops) <colorize>: New
2286         member.
2287         * cli/cli-style.c (_initialize_cli_style): Update help text.
2288
2289 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2290
2291         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
2292         <cond>: Change type to bool.
2293         (aarch64_displaced_step_b_cond): Update cond to use bool type.
2294         (aarch64_displaced_step_cb): Likewise.
2295         (aarch64_displaced_step_tb): Likewise.
2296
2297 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2298
2299         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
2300         output.
2301
2302 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2303
2304         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
2305         <pc_adjust>: Adjust the documentation.
2306         (aarch64_displaced_step_fixup): Check if PC really moved before
2307         adjusting it.
2308
2309 2020-01-19  Tom Tromey  <tom@tromey.com>
2310
2311         * disasm.c (~gdb_disassembler): New destructor.
2312         (gdb_buffered_insn_length): Call disassemble_free_target.
2313         * disasm.h (class gdb_disassembler): Declare destructor.  Use
2314         DISABLE_COPY_AND_ASSIGN.
2315
2316 2020-01-19  Tom Tromey  <tom@tromey.com>
2317
2318         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
2319         (die_reader_func_ftype): Remove.
2320         (cutu_reader): New class.
2321         (dw2_get_file_names_reader): Remove "data" parameter.
2322         (dw2_get_file_names): Use cutu_reader.
2323         (create_debug_type_hash_table): Update.
2324         (read_cutu_die_from_dwo): Update comment.
2325         (lookup_dwo_unit): Add dwo_name parameter.
2326         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
2327         die_reader_func_ftype and data parameters.
2328         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
2329         Remove die_reader_func_ftype and data parameters.
2330         (~cutu_reader): New; from init_cutu_and_read_dies.
2331         (cutu_reader::cutu_reader): Rename from
2332         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
2333         and data parameters.
2334         (init_cutu_and_read_dies_simple): Remove.
2335         (struct process_psymtab_comp_unit_data): Remove.
2336         (process_psymtab_comp_unit_reader): Remove data parameter; add
2337         want_partial_unit and pretend_language parameters.
2338         (process_psymtab_comp_unit): Use cutu_reader.
2339         (build_type_psymtabs_reader): Remove data parameter.
2340         (build_type_psymtabs_1): Use cutu_reader.
2341         (process_skeletonless_type_unit): Likewise.
2342         (load_partial_comp_unit_reader): Remove.
2343         (load_partial_comp_unit): Use cutu_reader.
2344         (load_full_comp_unit_reader): Remove.
2345         (load_full_comp_unit): Use cutu_reader.
2346         (struct create_dwo_cu_data): Remove.
2347         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
2348         dwo_unit parameters.
2349         (create_cus_hash_table): Use cutu_reader.
2350         (struct dwarf2_read_addr_index_data): Remove.
2351         (dwarf2_read_addr_index_reader): Remove.
2352         (dwarf2_read_addr_index): Use cutu_reader.
2353         (read_signatured_type_reader): Remove.
2354         (read_signatured_type): Use cutu_reader.
2355
2356 2020-01-19  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
2359         * tui/tui-wingeneral.h (class tui_suppress_output): New.
2360         (tui_wrefresh): Declare.
2361         * tui/tui-wingeneral.c (suppress_output): New global.
2362         (tui_suppress_output, ~tui_suppress_output): New constructor and
2363         destructor.
2364         (tui_wrefresh): New function.
2365         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
2366         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
2367         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
2368         method.
2369         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
2370         tui_wrefresh.
2371         (tui_data_window::no_refresh): New method.
2372         (tui_data_item_window::refresh_window): Call tui_wrefresh.
2373         (tui_reg_command): Use tui_suppress_output
2374         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
2375         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
2376         method.
2377         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
2378
2379 2020-01-19  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-winsource.c (tui_update_source_windows_with_line):
2382         Handle case where symtab is null.
2383
2384 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
2385
2386         * linux-fork.c (one_fork_p): Simplify.
2387
2388 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2389
2390         * top.c (struct qt_args): Remove.
2391         (kill_or_detach): Change return type to void, replace `void *`
2392         parameter with a proper one.
2393         (print_inferior_quit_action):  Likewise.
2394         (quit_confirm): Use range-based for loop to iterate over inferiors.
2395         (quit_force): Likewise.
2396
2397 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2398
2399         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
2400         `void *` parameter with proper parameters.
2401         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
2402         (print_one_inferior): Change return type to void, replace `void *`
2403         parameter with proper parameters.
2404         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
2405         inferiors.
2406         (get_other_inferior): Remove.
2407         (mi_cmd_remove_inferior): Use range-based loop to iterate over
2408         inferiors.
2409
2410 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2411
2412         * mi/mi-interp.c (report_initial_inferior): Remove.
2413         (mi_interp::init): Use range-based for to iterate over inferiors.
2414
2415 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2416
2417         * python/py-inferior.c (build_inferior_list): Remove.
2418         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
2419
2420 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
2421
2422         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
2423         (btrace_stitch_trace): Likewise.
2424         * charset.c (intermediate_encoding): Likewise (vaild).
2425         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
2426         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
2427         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
2428
2429 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
2430
2431         * windows-tdep.c (windows_get_tlb_type):
2432         Add rtl_user_process_parameters type.
2433
2434 2020-01-16  Pedro Alves  <palves@redhat.com>
2435             Norbert Lange  <nolange79@gmail.com>
2436
2437         PR build/24805
2438         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
2439         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
2440         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
2441         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
2442         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
2443         (ps_plog): Redeclare exported functions with default visibility.
2444
2445 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
2446
2447         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
2448         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
2449
2450 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
2451
2452         * infcmd.c (post_create_inferior): Use get_thread_regcache
2453         instead of get_current_regcache.
2454
2455 2020-01-14  Tom Tromey  <tom@tromey.com>
2456
2457         PR symtab/12535:
2458         * python/python.c (gdbpy_decode_line): Treat empty string the same
2459         as no argument.
2460
2461 2020-01-14  Tom Tromey  <tom@tromey.com>
2462
2463         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
2464
2465 2020-01-14  Tom Tromey  <tom@tromey.com>
2466
2467         * nat/linux-btrace.c: Don't include <config.h>.
2468         * nat/linux-ptrace.c: Don't include <config.h>.
2469         * nat/x86-linux-dregs.c: Don't include <config.h>.
2470
2471 2020-01-14  Tom Tromey  <tom@tromey.com>
2472
2473         * configure: Rebuild.
2474         * configure.ac: Move many checks to ../gdbsupport/common.m4.
2475
2476 2020-01-14  Tom Tromey  <tom@tromey.com>
2477
2478         * nat/x86-linux-dregs.c: Include configh.h.
2479         * nat/linux-ptrace.c: Include configh.h.
2480         * nat/linux-btrace.c: Include configh.h.
2481         * defs.h: Include config.h, bfd.h.
2482         * configure.ac: Don't source common.host.
2483         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
2484         * configure: Rebuild.
2485         * acinclude.m4: Update path.
2486         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
2487         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
2488         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
2489         (CLIBS): Add LIBSUPPORT.
2490         (CDEPS): Likewise.
2491         (COMMON_SFILES): Remove gdbsupport files.
2492         (HFILES_NO_SRCDIR): Likewise.
2493         (stamp-version): Update path to create-version.sh.
2494         (ALLDEPFILES): Remove gdbsupport files.
2495
2496 2020-01-14  Tom Tromey  <tom@tromey.com>
2497
2498         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
2499         USE_WIN32API when needed.
2500         * configure.ac (USE_WIN32API): Don't define.
2501         (WIN32LIBS): Use WIN32APILIBS.
2502         * configure: Rebuild.
2503
2504 2020-01-14  Tom Tromey  <tom@tromey.com>
2505
2506         * configure: Rebuild.
2507         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
2508
2509 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2510
2511         * skip.c (skip_function_command): Make skip w/o arguments use the
2512         name of the inlined function if pc is inside any inlined function.
2513
2514 2020-01-14  Luis Machado  <luis.machado@linaro.org>
2515
2516         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
2517         * infrun.c (resume_1): Likewise.
2518         (handle_inferior_event): Remove stale comment.
2519         * linux-nat.c (linux_nat_target::resume): Update comments.
2520         (save_stop_reason): Likewise.
2521         (linux_nat_filter_event): Likewise.
2522         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
2523
2524 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2525
2526         * elfread.c (record_minimal_symbol): Set section index to 0 for
2527         non-allocatable sections.
2528
2529
2530 2020-01-13  Ali Tamur <tamur@google.com>
2531
2532         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
2533         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
2534         to gdb::optional.  Update comments.
2535         (dwo_file): Update comments.
2536         (read_attribute): Update API to take an additional out parameter,
2537         need_reprocess.  This is used to mark attributes that need other
2538         attributes (e.g. str_offsets_base) for correct computation which may not
2539         have been read yet.
2540         (read_attribute_reprocess): New function declaration.
2541         (read_addr_index): Likewise.
2542         (read_dwo_str_index): Likewise.
2543         (read_stub_str_index): Likewise.
2544         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
2545         (lookup_addr_base): New function definition.
2546         (lookup_ranges_base): Likewise.
2547         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
2548         lookup_ranges_base.
2549         (init_cutu_and_read_dies): Update comments.
2550         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
2551         unit.  This is used to inherit parent's str_offsets_base and addr_base.
2552         Update comments.
2553         (init_cutu_and_read_dies_simple): Reflect API changes.
2554         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
2555         (create_cus_hash_table): Change API to take parent compile unit.
2556         Reflect API changes.
2557         (open_and_init_dwo_file): Reflect API changes.
2558         (dwarf2_get_pc_bounds): Update comments.
2559         (dwarf2_record_block_ranges): Likewise.
2560         (read_full_die_1): Change implementation to reprocess attributes that
2561         need str_offsets_base and addr_base.
2562         (partial_die_info::read): Likewise.
2563         (read_attribute_reprocess): New function definition.
2564         (read_attribute_value): Change API to take an additional out parameter,
2565         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
2566         when a non-dwo compile unit has index based attributes.
2567         (read_attribute): Reflect API changes.
2568         (read_addr_index_1): Reflect API changes.  Update comments.
2569         (dwarf2_read_addr_index_data): Reflect API changes.
2570         (dwarf2_read_addr_index): Likewise.
2571         (read_str_index): Change API and implementation.  This becomes a helper
2572         to be used by the new string index related methods.  Update error
2573         message and comments.
2574         (read_dwo_str_index): New function definition.
2575         (read_stub_str_index): Likewise.
2576         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
2577         * symfile.h (dwarf2_debug_sections): Likewise.
2578         * xcoffread.c (dwarf2_debug_sections): Likewise.
2579
2580 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2581
2582         * gdbcore.h (struct core_fns) <core_read_registers>: Change
2583         core_reg_sect type to gdb_byte *.
2584         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
2585         * cris-tdep.c (fetch_core_registers): Likewise.
2586         * corelow.c (core_target::get_core_register_section): Change
2587         type of `contents` to gdb::byte_vector.
2588
2589 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2590
2591         * tui/tui-wingeneral.c (box_win): Position the title in the center
2592         of the border.
2593
2594 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2595
2596         * corelow.c (core_target::get_core_register_section): Use
2597           std::vector instead of alloca.
2598
2599 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2600
2601         * warning.m4: Add -Wmissing-declarations to build_warnings.
2602         * configure: Re-generate.
2603
2604 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2605
2606         * python/python.c (init__gdb_module): Add declaration.
2607
2608 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2609
2610         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
2611         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
2612         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
2613         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
2614         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
2615         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
2616         * ada-exp.y (_initialize_ada_exp): Add declaration.
2617         * ada-lang.c (_initialize_ada_language): Add declaration.
2618         * ada-tasks.c (_initialize_tasks): Add declaration.
2619         * agent.c (_initialize_agent): Add declaration.
2620         * aix-thread.c (_initialize_aix_thread): Add declaration.
2621         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
2622         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
2623         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
2624         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
2625         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
2626         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
2627         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
2628         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
2629         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
2630         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
2631         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
2632         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
2633         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
2634         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
2635         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
2636         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
2637         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
2638         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
2639         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
2640         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
2641         * annotate.c (_initialize_annotate): Add declaration.
2642         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
2643         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
2644         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
2645         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
2646         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
2647         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
2648         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
2649         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
2650         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
2651         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
2652         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
2653         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
2654         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
2655         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
2656         * auto-load.c (_initialize_auto_load): Add declaration.
2657         * auxv.c (_initialize_auxv): Add declaration.
2658         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
2659         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
2660         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
2661         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
2662         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
2663         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
2664         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
2665         * breakpoint.c (_initialize_breakpoint): Add declaration.
2666         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
2667         * btrace.c (_initialize_btrace): Add declaration.
2668         * charset.c (_initialize_charset): Add declaration.
2669         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
2670         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
2671         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
2672         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
2673         * cli/cli-script.c (_initialize_cli_script): Add declaration.
2674         * cli/cli-style.c (_initialize_cli_style): Add declaration.
2675         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
2676         * coffread.c (_initialize_coffread): Add declaration.
2677         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
2678         * compile/compile.c (_initialize_compile): Add declaration.
2679         * complaints.c (_initialize_complaints): Add declaration.
2680         * completer.c (_initialize_completer): Add declaration.
2681         * copying.c (_initialize_copying): Add declaration.
2682         * corefile.c (_initialize_core): Add declaration.
2683         * corelow.c (_initialize_corelow): Add declaration.
2684         * cp-abi.c (_initialize_cp_abi): Add declaration.
2685         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
2686         * cp-support.c (_initialize_cp_support): Add declaration.
2687         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
2688         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
2689         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
2690         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
2691         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
2692         * ctfread.c (_initialize_ctfread): Add declaration.
2693         * d-lang.c (_initialize_d_language): Add declaration.
2694         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
2695         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
2696         * dbxread.c (_initialize_dbxread): Add declaration.
2697         * dcache.c (_initialize_dcache): Add declaration.
2698         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
2699         * disasm.c (_initialize_disasm): Add declaration.
2700         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
2701         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
2702         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
2703         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
2704         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
2705         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
2706         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
2707         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
2708         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
2709         * elfread.c (_initialize_elfread): Add declaration.
2710         * exec.c (_initialize_exec): Add declaration.
2711         * extension.c (_initialize_extension): Add declaration.
2712         * f-lang.c (_initialize_f_language): Add declaration.
2713         * f-valprint.c (_initialize_f_valprint): Add declaration.
2714         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
2715         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
2716         * filesystem.c (_initialize_filesystem): Add declaration.
2717         * findcmd.c (_initialize_mem_search): Add declaration.
2718         * findvar.c (_initialize_findvar): Add declaration.
2719         * fork-child.c (_initialize_fork_child): Add declaration.
2720         * frame-base.c (_initialize_frame_base): Add declaration.
2721         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
2722         * frame.c (_initialize_frame): Add declaration.
2723         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
2724         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
2725         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
2726         * gcore.c (_initialize_gcore): Add declaration.
2727         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
2728         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
2729         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
2730         * gdbarch.c (_initialize_gdbarch): Add declaration.
2731         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
2732         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
2733         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
2734         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
2735         * go-lang.c (_initialize_go_language): Add declaration.
2736         * go32-nat.c (_initialize_go32_nat): Add declaration.
2737         * guile/guile.c (_initialize_guile): Add declaration.
2738         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
2739         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
2740         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
2741         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
2742         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
2743         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
2744         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
2745         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
2746         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
2747         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
2748         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
2749         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
2750         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
2751         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
2752         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
2753         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
2754         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
2755         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
2756         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
2757         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
2758         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
2759         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
2760         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
2761         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
2762         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
2763         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
2764         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
2765         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
2766         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
2767         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
2768         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
2769         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
2770         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
2771         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
2772         * infcall.c (_initialize_infcall): Add declaration.
2773         * infcmd.c (_initialize_infcmd): Add declaration.
2774         * inflow.c (_initialize_inflow): Add declaration.
2775         * infrun.c (_initialize_infrun): Add declaration.
2776         * interps.c (_initialize_interpreter): Add declaration.
2777         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
2778         * jit.c (_initialize_jit): Add declaration.
2779         * language.c (_initialize_language): Add declaration.
2780         * linux-fork.c (_initialize_linux_fork): Add declaration.
2781         * linux-nat.c (_initialize_linux_nat): Add declaration.
2782         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
2783         * linux-thread-db.c (_initialize_thread_db): Add declaration.
2784         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
2785         * m2-lang.c (_initialize_m2_language): Add declaration.
2786         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
2787         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
2788         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
2789         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
2790         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
2791         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
2792         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
2793         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
2794         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
2795         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
2796         * machoread.c (_initialize_machoread): Add declaration.
2797         * macrocmd.c (_initialize_macrocmd): Add declaration.
2798         * macroscope.c (_initialize_macroscope): Add declaration.
2799         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
2800         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
2801         * maint.c (_initialize_maint_cmds): Add declaration.
2802         * mdebugread.c (_initialize_mdebugread): Add declaration.
2803         * memattr.c (_initialize_mem): Add declaration.
2804         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
2805         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
2806         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
2807         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
2808         * mi/mi-main.c (_initialize_mi_main): Add declaration.
2809         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
2810         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
2811         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
2812         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
2813         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
2814         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
2815         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
2816         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
2817         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
2818         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
2819         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
2820         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
2821         * mipsread.c (_initialize_mipsread): Add declaration.
2822         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
2823         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
2824         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
2825         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
2826         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
2827         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
2828         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
2829         * nto-procfs.c (_initialize_procfs): Add declaration.
2830         * objc-lang.c (_initialize_objc_language): Add declaration.
2831         * observable.c (_initialize_observer): Add declaration.
2832         * opencl-lang.c (_initialize_opencl_language): Add declaration.
2833         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
2834         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
2835         * osabi.c (_initialize_gdb_osabi): Add declaration.
2836         * osdata.c (_initialize_osdata): Add declaration.
2837         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
2838         * parse.c (_initialize_parse): Add declaration.
2839         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
2840         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
2841         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
2842         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
2843         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
2844         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
2845         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
2846         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
2847         * printcmd.c (_initialize_printcmd): Add declaration.
2848         * probe.c (_initialize_probe): Add declaration.
2849         * proc-api.c (_initialize_proc_api): Add declaration.
2850         * proc-events.c (_initialize_proc_events): Add declaration.
2851         * proc-service.c (_initialize_proc_service): Add declaration.
2852         * procfs.c (_initialize_procfs): Add declaration.
2853         * producer.c (_initialize_producer): Add declaration.
2854         * psymtab.c (_initialize_psymtab): Add declaration.
2855         * python/python.c (_initialize_python): Add declaration.
2856         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
2857         * record-btrace.c (_initialize_record_btrace): Add declaration.
2858         * record-full.c (_initialize_record_full): Add declaration.
2859         * record.c (_initialize_record): Add declaration.
2860         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
2861         * regcache.c (_initialize_regcache): Add declaration.
2862         * reggroups.c (_initialize_reggroup): Add declaration.
2863         * remote-notif.c (_initialize_notif): Add declaration.
2864         * remote-sim.c (_initialize_remote_sim): Add declaration.
2865         * remote.c (_initialize_remote): Add declaration.
2866         * reverse.c (_initialize_reverse): Add declaration.
2867         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
2868         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
2869         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
2870         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
2871         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
2872         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
2873         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
2874         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
2875         Add declaration.
2876         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
2877         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
2878         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
2879         * rust-exp.y (_initialize_rust_exp): Add declaration.
2880         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
2881         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
2882         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
2883         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
2884         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
2885         * score-tdep.c (_initialize_score_tdep): Add declaration.
2886         * ser-go32.c (_initialize_ser_dos): Add declaration.
2887         * ser-mingw.c (_initialize_ser_windows): Add declaration.
2888         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
2889         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
2890         * ser-uds.c (_initialize_ser_socket): Add declaration.
2891         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
2892         * serial.c (_initialize_serial): Add declaration.
2893         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
2894         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
2895         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
2896         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
2897         * skip.c (_initialize_step_skip): Add declaration.
2898         * sol-thread.c (_initialize_sol_thread): Add declaration.
2899         * solib-aix.c (_initialize_solib_aix): Add declaration.
2900         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
2901         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
2902         * solib-frv.c (_initialize_frv_solib): Add declaration.
2903         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
2904         * solib-target.c (_initialize_solib_target): Add declaration.
2905         * solib.c (_initialize_solib): Add declaration.
2906         * source-cache.c (_initialize_source_cache): Add declaration.
2907         * source.c (_initialize_source): Add declaration.
2908         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
2909         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
2910         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
2911         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
2912         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
2913         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
2914         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
2915         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
2916         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
2917         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
2918         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
2919         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
2920         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
2921         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
2922         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
2923         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
2924         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
2925         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
2926         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
2927         * stabsread.c (_initialize_stabsread): Add declaration.
2928         * stack.c (_initialize_stack): Add declaration.
2929         * stap-probe.c (_initialize_stap_probe): Add declaration.
2930         * std-regs.c (_initialize_frame_reg): Add declaration.
2931         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
2932         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
2933         * symfile.c (_initialize_symfile): Add declaration.
2934         * symmisc.c (_initialize_symmisc): Add declaration.
2935         * symtab.c (_initialize_symtab): Add declaration.
2936         * target.c (_initialize_target): Add declaration.
2937         * target-connection.c (_initialize_target_connection): Add
2938         declaration.
2939         * target-dcache.c (_initialize_target_dcache): Add declaration.
2940         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
2941         * thread.c (_initialize_thread): Add declaration.
2942         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
2943         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
2944         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
2945         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
2946         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
2947         * tracectf.c (_initialize_ctf): Add declaration.
2948         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
2949         * tracefile.c (_initialize_tracefile): Add declaration.
2950         * tracepoint.c (_initialize_tracepoint): Add declaration.
2951         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
2952         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
2953         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
2954         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
2955         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
2956         * tui/tui-win.c (_initialize_tui_win): Add declaration.
2957         * tui/tui.c (_initialize_tui): Add declaration.
2958         * typeprint.c (_initialize_typeprint): Add declaration.
2959         * ui-style.c (_initialize_ui_style): Add declaration.
2960         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
2961         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
2962         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
2963         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
2964         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
2965         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
2966         * unittests/filtered_iterator-selftests.c
2967         (_initialize_filtered_iterator_selftests): Add declaration.
2968         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
2969         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
2970         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
2971         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
2972         * unittests/main-thread-selftests.c
2973         (_initialize_main_thread_selftests): Add declaration.
2974         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
2975         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
2976         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
2977         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
2978         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
2979         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
2980         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
2981         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
2982         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
2983         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
2984         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
2985         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
2986         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
2987         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
2988         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
2989         declaration.
2990         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
2991         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
2992         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
2993         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
2994         * user-regs.c (_initialize_user_regs): Add declaration.
2995         * utils.c (_initialize_utils): Add declaration.
2996         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
2997         * valops.c (_initialize_valops): Add declaration.
2998         * valprint.c (_initialize_valprint): Add declaration.
2999         * value.c (_initialize_values): Add declaration.
3000         * varobj.c (_initialize_varobj): Add declaration.
3001         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
3002         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
3003         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
3004         * windows-nat.c (_initialize_windows_nat): Add declaration.
3005         (_initialize_check_for_gdb_ini): Add declaration.
3006         (_initialize_loadable): Add declaration.
3007         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
3008         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
3009         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
3010         * xcoffread.c (_initialize_xcoffread): Add declaration.
3011         * xml-support.c (_initialize_xml_support): Add declaration.
3012         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
3013         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
3014         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
3015         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
3016
3017 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3018
3019         * regformats/regdat.sh: Generate declaration for init function.
3020
3021 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3022
3023         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
3024         up.
3025         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
3026         close_one_inferior>: New methods.
3027         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
3028         pass down target to find_inferior_pid.
3029         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
3030         Pass down target to find_inferior_ptid.
3031         (gdbsim_target::create_inferior): Pass down target to
3032         add_thread_silent.
3033         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
3034         target down to find_inferior_ptid and switch_to_thread.
3035         (gdbsim_target::close): Update to call close_one_inferior.
3036         (struct resume_data): Remove.
3037         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
3038         directly, rather than through a void pointer.
3039         (gdbsim_target::resume): Update to call resume_one_inferior.
3040
3041 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
3042
3043         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
3044
3045 2020-01-12  Pedro Alves  <palves@redhat.com>
3046
3047         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
3048         directly for the current inferior instead of
3049         discard_all_inferiors.
3050         (discard_all_inferiors): Delete.
3051
3052 2020-01-11  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-wingeneral.c (box_win): Check cli_styling.
3055         * tui/tui-winsource.c (tui_source_window_base::refill): Use
3056         deprecated_safe_get_selected_frame.
3057
3058 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3059
3060         * inferior.c (print_inferior): Switch inferior before printing it.
3061
3062 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
3063             Pedro Alves  <palves@redhat.com>
3064
3065         * progspace-and-thread.c (switch_to_program_space_and_thread):
3066         Assert there's an inferior for PSPACE.  Use
3067         switch_to_inferior_no_thread to switch the inferior too.
3068         * progspace.c (program_space::~program_space): Call
3069         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
3070         (program_space::free_all_objfiles): Don't call clear_symtab_users
3071         here.
3072         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
3073
3074 2020-01-10  Pedro Alves  <palves@redhat.com>
3075
3076         * NEWS: Mention multi-target debugging, "info connections", and
3077         "add-inferior -no-connection".
3078
3079 2020-01-10  Pedro Alves  <palves@redhat.com>
3080
3081         * infrun.c: Include "target-connection.h".
3082         (check_multi_target_resumption): New.
3083         (proceed): Call it.
3084         * target-connection.c (make_target_connection_string): Make
3085         extern.
3086         * target-connection.h (make_target_connection_string): Declare.
3087
3088 2020-01-10  Pedro Alves  <palves@redhat.com>
3089
3090         * Makefile.in (COMMON_SFILES): Add target-connection.c.
3091         * inferior.c (uiout_field_connection): New function.
3092         (print_inferior): Add new "connection-id" column.
3093         (add_inferior_command): Show connection number/string of added
3094         inferior.
3095         * process-stratum-target.h
3096         (process_stratum_target::connection_string): New virtual method.
3097         (process_stratum_target::connection_number): New field.
3098         * remote.c (remote_target::connection_string): New override.
3099         * target-connection.c: New file.
3100         * target-connection.h: New file.
3101         * target.c (decref_target): Remove process_stratum targets from
3102         the connection list.
3103         (target_stack::push): Add process_stratum targets to the
3104         connection list.
3105
3106 2020-01-10  Pedro Alves  <palves@redhat.com>
3107
3108         Revert:
3109         2016-04-12  Pedro Alves  <palves@redhat.com>
3110         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
3111         Remove references to name.
3112         * serial.h (struct serial) <name>: Delete.
3113
3114 2020-01-10  Pedro Alves  <palves@redhat.com>
3115
3116         * gdbarch-selftests.c (register_to_value_test): Remove "target
3117         already pushed" check.
3118
3119 2020-01-10  Pedro Alves  <palves@redhat.com>
3120             John Baldwin  <jhb@FreeBSD.org>
3121
3122         * aarch64-linux-nat.c
3123         (aarch64_linux_nat_target::thread_architecture): Adjust.
3124         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
3125         (task_command_1): Likewise.
3126         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
3127         (aix_thread_target::wait, aix_thread_target::fetch_registers)
3128         (aix_thread_target::store_registers)
3129         (aix_thread_target::thread_alive): Adjust.
3130         * amd64-fbsd-tdep.c: Include "inferior.h".
3131         (amd64fbsd_get_thread_local_address): Pass down target.
3132         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
3133         thread's gdbarch instead of target_gdbarch.
3134         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
3135         get_last_target_status.
3136         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
3137         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
3138         inferiors.
3139         (update_inserted_breakpoint_locations): Skip if inferiors with no
3140         execution.
3141         (update_global_location_list): When handling moribund locations,
3142         find representative inferior for location's pspace, and use thread
3143         count of its process_stratum target.
3144         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
3145         * bsd-uthread.c (bsd_uthread_target::wait): Use
3146         as_process_stratum_target and adjust thread_change_ptid and
3147         add_thread calls.
3148         (bsd_uthread_target::update_thread_list): Use
3149         as_process_stratum_target and adjust find_thread_ptid,
3150         thread_change_ptid and add_thread calls.
3151         * btrace.c (maint_btrace_packet_history_cmd): Adjust
3152         find_thread_ptid call.
3153         * corelow.c (add_to_thread_list): Adjust add_thread call.
3154         (core_target_open): Adjust add_thread_silent and thread_count
3155         calls.
3156         (core_target::pid_to_str): Adjust find_inferior_ptid call.
3157         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
3158         * event-top.c (async_disconnect): Pop targets from all inferiors.
3159         * exec.c (add_target_sections): Push exec target on all inferiors
3160         sharing the program space.
3161         (remove_target_sections): Remove the exec target from all
3162         inferiors sharing the program space.
3163         (exec_on_vfork): New.
3164         * exec.h (exec_on_vfork): Declare.
3165         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
3166         Pass it down.
3167         (fbsd_nat_target::update_thread_list): Adjust.
3168         (fbsd_nat_target::resume): Adjust.
3169         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
3170         down.
3171         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
3172         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
3173         get_thread_arch_regcache call.
3174         * fork-child.c (gdb_startup_inferior): Pass target down to
3175         startup_inferior and set_executing.
3176         * gdbthread.h (struct process_stratum_target): Forward declare.
3177         (add_thread, add_thread_silent, add_thread_with_info)
3178         (in_thread_list): Add process_stratum_target parameter.
3179         (find_thread_ptid(inferior*, ptid_t)): New overload.
3180         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
3181         parameter.
3182         (all_threads()): Delete overload.
3183         (all_threads, all_non_exited_threads): Add process_stratum_target
3184         parameter.
3185         (all_threads_safe): Use brace initialization.
3186         (thread_count): Add process_stratum_target parameter.
3187         (set_resumed, set_running, set_stop_requested, set_executing)
3188         (threads_are_executing, finish_thread_state): Add
3189         process_stratum_target parameter.
3190         (switch_to_thread): Use is_current_thread.
3191         * i386-fbsd-tdep.c: Include "inferior.h".
3192         (i386fbsd_get_thread_local_address): Pass down target.
3193         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
3194         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
3195         have_inferiors check.
3196         * inf-ptrace.c (inf_ptrace_target::create_inferior)
3197         (inf_ptrace_target::attach): Adjust.
3198         * infcall.c (run_inferior_call): Adjust.
3199         * infcmd.c (run_command_1): Pass target to
3200         scoped_finish_thread_state.
3201         (proceed_thread_callback): Skip inferiors with no execution.
3202         (continue_command): Rename 'all_threads' local to avoid hiding
3203         'all_threads' function.  Adjust get_last_target_status call.
3204         (prepare_one_step): Adjust set_running call.
3205         (signal_command): Use user_visible_resume_target.  Compare thread
3206         pointers instead of inferior_ptid.
3207         (info_program_command): Adjust to pass down target.
3208         (attach_command): Mark target's 'thread_executing' flag.
3209         (stop_current_target_threads_ns): New, factored out from ...
3210         (interrupt_target_1): ... this.  Switch inferior before making
3211         target calls.
3212         * inferior-iter.h
3213         (struct all_inferiors_iterator, struct all_inferiors_range)
3214         (struct all_inferiors_safe_range)
3215         (struct all_non_exited_inferiors_range): Filter on
3216         process_stratum_target too.  Remove explicit.
3217         * inferior.c (inferior::inferior): Push dummy target on target
3218         stack.
3219         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
3220         Add process_stratum_target parameter, and pass it down.
3221         (have_live_inferiors): Adjust.
3222         (switch_to_inferior_and_push_target): New.
3223         (add_inferior_command, clone_inferior_command): Handle
3224         "-no-connection" parameter.  Use
3225         switch_to_inferior_and_push_target.
3226         (_initialize_inferior): Mention "-no-connection" option in
3227         the help of "add-inferior" and "clone-inferior" commands.
3228         * inferior.h: Include "process-stratum-target.h".
3229         (interrupt_target_1): Use bool.
3230         (struct inferior) <push_target, unpush_target, target_is_pushed,
3231         find_target_beneath, top_target, process_target, target_at,
3232         m_stack>: New.
3233         (discard_all_inferiors): Delete.
3234         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
3235         (all_inferiors, all_non_exited_inferiors): Add
3236         process_stratum_target parameter.
3237         * infrun.c: Include "gdb_select.h" and <unordered_map>.
3238         (target_last_proc_target): New global.
3239         (follow_fork_inferior): Push target on new inferior.  Pass target
3240         to add_thread_silent.  Call exec_on_vfork.  Handle target's
3241         reference count.
3242         (follow_fork): Adjust get_last_target_status call.  Also consider
3243         target.
3244         (follow_exec): Push target on new inferior.
3245         (struct execution_control_state) <target>: New field.
3246         (user_visible_resume_target): New.
3247         (do_target_resume): Call target_async.
3248         (resume_1): Set target's threads_executing flag.  Consider resume
3249         target.
3250         (commit_resume_all_targets): New.
3251         (proceed): Also consider resume target.  Skip threads of inferiors
3252         with no execution.  Commit resumtion in all targets.
3253         (start_remote): Pass current inferior to wait_for_inferior.
3254         (infrun_thread_stop_requested): Consider target as well.  Pass
3255         thread_info pointer to clear_inline_frame_state instead of ptid.
3256         (infrun_thread_thread_exit): Consider target as well.
3257         (random_pending_event_thread): New inferior parameter.  Use it.
3258         (do_target_wait): Rename to ...
3259         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
3260         down.
3261         (threads_are_resumed_pending_p, do_target_wait): New.
3262         (prepare_for_detach): Adjust calls.
3263         (wait_for_inferior): New inferior parameter.  Handle it.  Use
3264         do_target_wait_1 instead of do_target_wait.
3265         (fetch_inferior_event): Adjust.  Switch to representative
3266         inferior.  Pass target down.
3267         (set_last_target_status): Add process_stratum_target parameter.
3268         Save target in global.
3269         (get_last_target_status): Add process_stratum_target parameter and
3270         handle it.
3271         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
3272         (context_switch): Check inferior_ptid == null_ptid before calling
3273         inferior_thread().
3274         (get_inferior_stop_soon): Pass down target.
3275         (wait_one): Rename to ...
3276         (poll_one_curr_target): ... this.
3277         (struct wait_one_event): New.
3278         (wait_one): New.
3279         (stop_all_threads): Adjust.
3280         (handle_no_resumed, handle_inferior_event): Adjust to consider the
3281         event's target.
3282         (switch_back_to_stepped_thread): Also consider target.
3283         (print_stop_event): Update.
3284         (normal_stop): Update.  Also consider the resume target.
3285         * infrun.h (wait_for_inferior): Remove declaration.
3286         (user_visible_resume_target): New declaration.
3287         (get_last_target_status, set_last_target_status): New
3288         process_stratum_target parameter.
3289         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3290         process_stratum_target parameter, and use it.
3291         (clear_inline_frame_state (thread_info*)): New.
3292         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3293         process_stratum_target parameter.
3294         (clear_inline_frame_state (thread_info*)): Declare.
3295         * linux-fork.c (delete_checkpoint_command): Pass target down to
3296         find_thread_ptid.
3297         (checkpoint_command): Adjust.
3298         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
3299         instead of just tweaking inferior_ptid.
3300         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
3301         (exit_lwp): Pass target down to find_thread_ptid.
3302         (attach_proc_task_lwp_callback): Pass target down to
3303         add_thread/set_running/set_executing.
3304         (linux_nat_target::attach): Pass target down to
3305         thread_change_ptid.
3306         (get_detach_signal): Pass target down to find_thread_ptid.
3307         Consider last target status's target.
3308         (linux_resume_one_lwp_throw, resume_lwp)
3309         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
3310         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
3311         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
3312         (linux_nat_target::async_wait_fd): New.
3313         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
3314         target down.
3315         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
3316         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
3317         * linux-thread-db.c (struct thread_db_info::process_target): New
3318         field.
3319         (add_thread_db_info): Save target.
3320         (get_thread_db_info): New process_stratum_target parameter.  Also
3321         match target.
3322         (delete_thread_db_info): New process_stratum_target parameter.
3323         Also match target.
3324         (thread_from_lwp): Adjust to pass down target.
3325         (thread_db_notice_clone): Pass down target.
3326         (check_thread_db_callback): Pass down target.
3327         (try_thread_db_load_1): Always push the thread_db target.
3328         (try_thread_db_load, record_thread): Pass target down.
3329         (thread_db_target::detach): Pass target down.  Always unpush the
3330         thread_db target.
3331         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
3332         target down.  Always unpush the thread_db target.
3333         (find_new_threads_callback, thread_db_find_new_threads_2)
3334         (thread_db_target::update_thread_list): Pass target down.
3335         (thread_db_target::pid_to_str): Pass current inferior down.
3336         (thread_db_target::get_thread_local_address): Pass target down.
3337         (thread_db_target::resume, maintenance_check_libthread_db): Pass
3338         target down.
3339         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
3340         * procfs.c (procfs_target::procfs_init_inferior): Declare.
3341         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
3342         (procfs_init_inferior): Rename to ...
3343         (procfs_target::procfs_init_inferior): ... this and adjust.
3344         (procfs_target::create_inferior, procfs_notice_thread)
3345         (procfs_do_thread_registers): Adjust.
3346         * ppc-fbsd-tdep.c: Include "inferior.h".
3347         (ppcfbsd_get_thread_local_address): Pass down target.
3348         * proc-service.c (ps_xfer_memory): Switch current inferior and
3349         program space as well.
3350         (get_ps_regcache): Pass target down.
3351         * process-stratum-target.c
3352         (process_stratum_target::thread_address_space)
3353         (process_stratum_target::thread_architecture): Pass target down.
3354         * process-stratum-target.h
3355         (process_stratum_target::threads_executing): New field.
3356         (as_process_stratum_target): New.
3357         * ravenscar-thread.c
3358         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
3359         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
3360         down.
3361         * record-btrace.c (record_btrace_target::info_record): Adjust.
3362         (record_btrace_target::record_method)
3363         (record_btrace_target::record_is_replaying)
3364         (record_btrace_target::fetch_registers)
3365         (get_thread_current_frame_id, record_btrace_target::resume)
3366         (record_btrace_target::wait, record_btrace_target::stop): Pass
3367         target down.
3368         * record-full.c (record_full_wait_1): Switch to event thread.
3369         Pass target down.
3370         * regcache.c (regcache::regcache)
3371         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
3372         process_stratum_target parameter and handle it.
3373         (current_thread_target): New global.
3374         (get_thread_regcache): Add process_stratum_target parameter and
3375         handle it.  Switch inferior before calling target method.
3376         (get_thread_regcache): Pass target down.
3377         (get_thread_regcache_for_ptid): Pass target down.
3378         (registers_changed_ptid): Add process_stratum_target parameter and
3379         handle it.
3380         (registers_changed_thread, registers_changed): Pass target down.
3381         (test_get_thread_arch_aspace_regcache): New.
3382         (current_regcache_test): Define a couple local test_target_ops
3383         instances and use them for testing.
3384         (readwrite_regcache): Pass process_stratum_target parameter.
3385         (cooked_read_test, cooked_write_test): Pass mock_target down.
3386         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
3387         (get_thread_arch_aspace_regcache): Add process_stratum_target
3388         parameter.
3389         (regcache::target): New method.
3390         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
3391         (regcache::registers_changed_ptid): Add process_stratum_target
3392         parameter.
3393         (regcache::m_target): New field.
3394         (registers_changed_ptid): Add process_stratum_target parameter.
3395         * remote.c (remote_state::supports_vCont_probed): New field.
3396         (remote_target::async_wait_fd): New method.
3397         (remote_unpush_and_throw): Add remote_target parameter.
3398         (get_current_remote_target): Adjust.
3399         (remote_target::remote_add_inferior): Push target.
3400         (remote_target::remote_add_thread)
3401         (remote_target::remote_notice_new_inferior)
3402         (get_remote_thread_info): Pass target down.
3403         (remote_target::update_thread_list): Skip threads of inferiors
3404         bound to other targets.  (remote_target::close): Don't discard
3405         inferiors.  (remote_target::add_current_inferior_and_thread)
3406         (remote_target::process_initial_stop_replies)
3407         (remote_target::start_remote)
3408         (remote_target::remote_serial_quit_handler): Pass down target.
3409         (remote_target::remote_unpush_target): New remote_target
3410         parameter.  Unpush the target from all inferiors.
3411         (remote_target::remote_unpush_and_throw): New remote_target
3412         parameter.  Pass it down.
3413         (remote_target::open_1): Check whether the current inferior has
3414         execution instead of checking whether any inferior is live.  Pass
3415         target down.
3416         (remote_target::remote_detach_1): Pass down target.  Use
3417         remote_unpush_target.
3418         (extended_remote_target::attach): Pass down target.
3419         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
3420         (remote_target::append_resumption): Pass down target.
3421         (remote_target::append_pending_thread_resumptions)
3422         (remote_target::remote_resume_with_hc, remote_target::resume)
3423         (remote_target::commit_resume): Pass down target.
3424         (remote_target::remote_stop_ns): Check supports_vCont_probed.
3425         (remote_target::interrupt_query)
3426         (remote_target::remove_new_fork_children)
3427         (remote_target::check_pending_events_prevent_wildcard_vcont)
3428         (remote_target::remote_parse_stop_reply)
3429         (remote_target::process_stop_reply): Pass down target.
3430         (first_remote_resumed_thread): New remote_target parameter.  Pass
3431         it down.
3432         (remote_target::wait_as): Pass down target.
3433         (unpush_and_perror): New remote_target parameter.  Pass it down.
3434         (remote_target::readchar, remote_target::remote_serial_write)
3435         (remote_target::getpkt_or_notif_sane_1)
3436         (remote_target::kill_new_fork_children, remote_target::kill): Pass
3437         down target.
3438         (remote_target::mourn_inferior): Pass down target.  Use
3439         remote_unpush_target.
3440         (remote_target::core_of_thread)
3441         (remote_target::remote_btrace_maybe_reopen): Pass down target.
3442         (remote_target::pid_to_exec_file)
3443         (remote_target::thread_handle_to_thread_info): Pass down target.
3444         (remote_target::async_wait_fd): New.
3445         * riscv-fbsd-tdep.c: Include "inferior.h".
3446         (riscv_fbsd_get_thread_local_address): Pass down target.
3447         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
3448         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
3449         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
3450         Adjust.
3451         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
3452         * solib-svr4.c (enable_break): Pass down target.
3453         * spu-multiarch.c (parse_spufs_run): Pass down target.
3454         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
3455         * target-delegates.c: Regenerate.
3456         * target.c (g_target_stack): Delete.
3457         (current_top_target): Return the current inferior's top target.
3458         (target_has_execution_1): Refer to the passed-in inferior's top
3459         target.
3460         (target_supports_terminal_ours): Check whether the initial
3461         inferior was already created.
3462         (decref_target): New.
3463         (target_stack::push): Incref/decref the target.
3464         (push_target, push_target, unpush_target): Adjust.
3465         (target_stack::unpush): Defref target.
3466         (target_is_pushed): Return bool.  Adjust to refer to the current
3467         inferior's target stack.
3468         (dispose_inferior): Delete, and inline parts ...
3469         (target_preopen): ... here.  Only dispose of the current inferior.
3470         (target_detach): Hold strong target reference while detaching.
3471         Pass target down.
3472         (target_thread_name): Add assertion.
3473         (target_resume): Pass down target.
3474         (target_ops::beneath, find_target_at): Adjust to refer to the
3475         current inferior's target stack.
3476         (get_dummy_target): New.
3477         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
3478         has a thread running.
3479         (initialize_targets): Rename to ...
3480         (_initialize_target): ... this.
3481         * target.h: Include "gdbsupport/refcounted-object.h".
3482         (struct target_ops): Inherit refcounted_object.
3483         (target_ops::shortname, target_ops::longname): Make const.
3484         (target_ops::async_wait_fd): New method.
3485         (decref_target): Declare.
3486         (struct target_ops_ref_policy): New.
3487         (target_ops_ref): New typedef.
3488         (get_dummy_target): Declare function.
3489         (target_is_pushed): Return bool.
3490         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
3491         (all_matching_threads_iterator::all_matching_threads_iterator):
3492         Handle filter target.
3493         * thread-iter.h (struct all_matching_threads_iterator, struct
3494         all_matching_threads_range, class all_non_exited_threads_range):
3495         Filter by target too.  Remove explicit.
3496         * thread.c (threads_executing): Delete.
3497         (inferior_thread): Pass down current inferior.
3498         (clear_thread_inferior_resources): Pass down thread pointer
3499         instead of ptid_t.
3500         (add_thread_silent, add_thread_with_info, add_thread): Add
3501         process_stratum_target parameter.  Use it for thread and inferior
3502         searches.
3503         (is_current_thread): New.
3504         (thread_info::deletable): Use it.
3505         (find_thread_ptid, thread_count, in_thread_list)
3506         (thread_change_ptid, set_resumed, set_running): New
3507         process_stratum_target parameter.  Pass it down.
3508         (set_executing): New process_stratum_target parameter.  Pass it
3509         down.  Adjust reference to 'threads_executing'.
3510         (threads_are_executing): New process_stratum_target parameter.
3511         Adjust reference to 'threads_executing'.
3512         (set_stop_requested, finish_thread_state): New
3513         process_stratum_target parameter.  Pass it down.
3514         (switch_to_thread): Also match inferior.
3515         (switch_to_thread): New process_stratum_target parameter.  Pass it
3516         down.
3517         (update_threads_executing): Reimplement.
3518         * top.c (quit_force): Pop targets from all inferior.
3519         (gdb_init): Don't call initialize_targets.
3520         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
3521         Declare.
3522         (windows_add_thread, windows_delete_thread): Adjust.
3523         (get_windows_debug_event): Rename to ...
3524         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
3525         * tracefile-tfile.c (tfile_target_open): Pass down target.
3526         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
3527         Forward declare.
3528         (switch_to_thread): Add process_stratum_target parameter.
3529         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
3530         parameter.  Use it.
3531         (mi_on_resume): Pass target down.
3532         * nat/fork-inferior.c (startup_inferior): Add
3533         process_stratum_target parameter.  Pass it down.
3534         * nat/fork-inferior.h (startup_inferior): Add
3535         process_stratum_target parameter.
3536         * python/py-threadevent.c (py_get_event_thread): Pass target down.
3537
3538 2020-01-10  Pedro Alves  <palves@redhat.com>
3539
3540         * remote.c (remote_target::start_remote): Don't set inferior_ptid
3541         directly.  Instead find the first thread in the thread list and
3542         use switch_to_thread.
3543
3544 2020-01-10  Pedro Alves  <palves@redhat.com>
3545
3546         * remote.c (remote_target::remote_add_inferior): Don't bind a
3547         process to the current inferior if the current inferior is already
3548         bound to a process.
3549
3550 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3551             Pedro Alves  <palves@redhat.com>
3552
3553         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
3554         If no process is specified, return null_ptid instead of
3555         inferior_ptid.
3556         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
3557         TARGET_WAITKIND_SIGNALLED with no pid.
3558
3559 2020-01-10  Pedro Alves  <palves@redhat.com>
3560
3561         * remote.c (first_remote_resumed_thread): New.
3562         (remote_target::wait_as): Use it as default event_ptid instead of
3563         inferior_ptid.
3564
3565 2020-01-10  Pedro Alves  <palves@redhat.com>
3566
3567         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
3568
3569 2020-01-10  Pedro Alves  <palves@redhat.com>
3570
3571         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
3572         not -1.
3573
3574 2020-01-10  Pedro Alves  <palves@redhat.com>
3575
3576         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
3577         ptid to get_last_target_status.
3578         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
3579         ptid to get_last_target_status.
3580         * infcmd.c (continue_command): Don't pass a target_waitstatus to
3581         get_last_target_status.
3582         (info_program_command): Don't pass a target_waitstatus to
3583         get_last_target_status.
3584         * infrun.c (init_wait_for_inferior): Use
3585         nullify_last_target_wait_ptid.
3586         (get_last_target_status): Handle nullptr arguments.
3587         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
3588         (print_stop_event): Don't pass a ptid to get_last_target_status.
3589         (normal_stop): Don't pass a ptid to get_last_target_status.
3590         * infrun.h (get_last_target_status, set_last_target_status): Move
3591         comments here and update.
3592         (nullify_last_target_wait_ptid): Declare.
3593         * linux-fork.c (fork_load_infrun_state): Remove local extern
3594         declaration of nullify_last_target_wait_ptid.
3595         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
3596         to get_last_target_status.
3597
3598 2020-01-10  Pedro Alves  <palves@redhat.com>
3599
3600         * gdbthread.h (scoped_restore_current_thread)
3601         <dont_restore, restore, m_dont_restore>: Declare.
3602         * thread.c (thread_alive): Add assertion.  Return bool.
3603         (switch_to_thread_if_alive): New.
3604         (prune_threads): Switch inferior/thread.
3605         (print_thread_info_1): Switch thread before calling target methods.
3606         (scoped_restore_current_thread::restore): New, factored out from
3607         ...
3608         (scoped_restore_current_thread::~scoped_restore_current_thread):
3609         ... this.
3610         (scoped_restore_current_thread::scoped_restore_current_thread):
3611         Add assertion.
3612         (thread_apply_all_command, thread_select): Use
3613         switch_to_thread_if_alive.
3614         * infrun.c (proceed, restart_threads, handle_signal_stop)
3615         (switch_back_to_stepped_thread): Switch current thread before
3616         calling target methods.
3617
3618 2020-01-10  Pedro Alves <palves@redhat.com>
3619
3620         * inferior.c (switch_to_inferior_no_thread): New function,
3621         factored out from ...
3622         (inferior_command): ... here.
3623         * inferior.h (switch_to_inferior_no_thread): Declare.
3624         * mi/mi-main.c (run_one_inferior): Use
3625         switch_to_inferior_no_thread.
3626
3627 2020-01-10  Pedro Alves  <palves@redhat.com>
3628
3629         * infcmd.c (kill_command): Remove dead code.
3630
3631 2020-01-10  Pedro Alves  <palves@redhat.com>
3632
3633         * remote.c (remote_target::mourn_inferior): No longer check
3634         whether the target is running.
3635
3636 2020-01-10  Pedro Alves  <palves@redhat.com>
3637
3638         * corelow.c (core_target::has_execution): Change parameter type to
3639         inferior pointer.
3640         * inferior.c (number_of_live_inferiors): Use
3641         inferior::has_execution instead of target_has_execution_1.
3642         * inferior.h (inferior::has_execution): New.
3643         * linux-thread-db.c (thread_db_target::update_thread_list): Use
3644         inferior::has_execution instead of target_has_execution_1.
3645         * process-stratum-target.c
3646         (process_stratum_target::has_execution): Change parameter type to
3647         inferior pointer.  Check the inferior's PID instead of
3648         inferior_ptid.
3649         * process-stratum-target.h
3650         (process_stratum_target::has_execution): Change parameter type to
3651         inferior pointer.
3652         * record-full.c (record_full_core_target::has_execution): Change
3653         parameter type to inferior pointer.
3654         * target.c (target_has_execution_1): Change parameter type to
3655         inferior pointer.
3656         (target_has_execution_current): Adjust.
3657         * target.h (target_ops::has_execution): Change parameter type to
3658         inferior pointer.
3659         (target_has_execution_1): Change parameter type to inferior
3660         pointer.  Change return type to bool.
3661         * tracefile.h (tracefile_target::has_execution): Change parameter
3662         type to inferior pointer.
3663
3664 2020-01-10  Pedro Alves  <palves@redhat.com>
3665
3666         * exceptions.c (print_flush): Remove current_top_target() check.
3667
3668 2020-01-10  Pedro Alves  <palves@redhat.com>
3669
3670         * remote.c (show_remote_exec_file): Show the current inferior's
3671         exec-file instead of the command variable's value.
3672
3673 2020-01-10  Pedro Alves  <palves@redhat.com>
3674
3675         * record-full.c (record_full_resume_ptid): New global.
3676         (record_full_target::resume): Set it.
3677         (record_full_wait_1): Use record_full_resume_ptid instead of
3678         inferior_ptid.
3679
3680 2020-01-10  Pedro Alves  <palves@redhat.com>
3681
3682         * gdbthread.h (scoped_restore_current_thread)
3683         <dont_restore, restore, m_dont_restore>: Declare.
3684         * thread.c (thread_alive): Add assertion.  Return bool.
3685         (switch_to_thread_if_alive): New.
3686         (prune_threads): Switch inferior/thread.
3687         (print_thread_info_1): Switch thread before calling target methods.
3688         (scoped_restore_current_thread::restore): New, factored out from
3689         ...
3690         (scoped_restore_current_thread::~scoped_restore_current_thread):
3691         ... this.
3692         (scoped_restore_current_thread::scoped_restore_current_thread):
3693         Add assertion.
3694         (thread_apply_all_command, thread_select): Use
3695         switch_to_thread_if_alive.
3696
3697 2020-01-10  George Barrett  <bob@bob131.so>
3698
3699         * stap-probe.c (stap_modify_semaphore): Don't check for null
3700         semaphores.
3701         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
3702         for null semaphores.
3703
3704 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
3707         all source windows, and maintain horizontal scroll status while
3708         doing so.
3709
3710 2020-01-09  Tom Tromey  <tom@tromey.com>
3711
3712         PR tui/18932:
3713         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
3714         update_source_window, not print_source_lines.
3715
3716 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * tui/tui.c (tui_enable): Register tui hooks after calling
3719         tui_display_main.
3720
3721 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3722
3723         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
3724
3725 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
3726
3727         * thread.c (print_thread_info_1): Fix indentation.
3728
3729 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3730
3731         * symtab.c (general_symbol_info::compute_and_set_names): Move the
3732         unique_xmalloc_ptr outside the if to always free the demangled name.
3733
3734 2020-01-08  Tom Tromey  <tromey@adacore.com>
3735
3736         * xcoffread.c (enter_line_range, read_xcoff_symtab)
3737         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
3738         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
3739         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
3740         Remove.
3741         (section_offsets): New typedef.
3742         * symtab.c (fixup_section, get_msymbol_address): Update.
3743         * symmisc.c (dump_msymbols): Update.
3744         * symfile.h (relative_addr_info_to_section_offsets)
3745         (symfile_map_offsets_to_segments): Update.
3746         * symfile.c (build_section_addr_info_from_objfile)
3747         (init_objfile_sect_indices): Update.
3748         (struct place_section_arg): Change type of "offsets".
3749         (place_section): Update.
3750         (relative_addr_info_to_section_offsets): Change type of
3751         "section_offsets".  Remove "num_sections" parameter.
3752         (default_symfile_offsets, syms_from_objfile_1)
3753         (set_objfile_default_section_offset): Update.
3754         (reread_symbols): No need to preserve section offsets by hand.
3755         (symfile_map_offsets_to_segments): Change type of "offsets".
3756         * stap-probe.c (relocate_address): Update.
3757         * stabsread.h (process_one_symbol): Update.
3758         * solib-target.c (struct lm_info_target) <offsets>: Change type.
3759         (solib_target_relocate_section_addresses): Update.
3760         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
3761         Update.
3762         * solib-frv.c (frv_relocate_main_executable): Update.
3763         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
3764         * solib-aix.c (solib_aix_get_section_offsets): Change return
3765         type.
3766         (solib_aix_solib_create_inferior_hook): Update.
3767         * remote.c (remote_target::get_offsets): Update.
3768         * psymtab.c (find_pc_sect_psymtab): Update.
3769         * psympriv.h (struct partial_symbol) <address, text_low,
3770         text_high>: Update.
3771         * objfiles.h (obj_section_offset): Update.
3772         (struct objfile) <section_offsets>: Change type.
3773         <num_sections>: Remove.
3774         (objfile_relocate): Update.
3775         * objfiles.c (entry_point_address_query): Update
3776         (relocate_one_symbol): Change type of "section_offsets".
3777         (objfile_relocate1, objfile_relocate1): Change type of
3778         "new_offsets".
3779         (objfile_rebase1): Update.
3780         * mipsread.c (mipscoff_symfile_read): Update.
3781         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
3782         parameter.
3783         * mdebugread.c (parse_symbol): Change type of "section_offsets".
3784         (parse_external, psymtab_to_symtab_1): Update.
3785         * machoread.c (macho_symfile_offsets): Update.
3786         * ia64-tdep.c (ia64_find_unwind_table): Update.
3787         * hppa-tdep.c (read_unwind_info): Update.
3788         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
3789         * dwarf2read.c (create_addrmap_from_index)
3790         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3791         (process_psymtab_comp_unit_reader, add_partial_symbol)
3792         (add_partial_subprogram, process_full_comp_unit)
3793         (read_file_scope, read_func_scope, read_lexical_block_scope)
3794         (read_call_site_scope, dwarf2_rnglists_process)
3795         (dwarf2_ranges_process, dwarf2_ranges_read)
3796         (dwarf_decode_lines_1, var_decode_location, new_symbol)
3797         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
3798         Update.
3799         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
3800         Update.
3801         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
3802         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
3803         (process_one_symbol): Change type of "section_offsets".
3804         * ctfread.c (get_objfile_text_range): Update.
3805         * coffread.c (coff_symtab_read, enter_linenos)
3806         (process_coff_symbol): Update.
3807         * coff-pe-read.c (add_pe_forwarded_sym): Update.
3808         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
3809
3810 2020-01-08  Tom Tromey  <tromey@adacore.com>
3811
3812         * dwarf2read.c (parse_macro_definition): Use std::string.
3813         (parse_macro_definition): Likewise.
3814
3815 2020-01-08  Tom Tromey  <tromey@adacore.com>
3816
3817         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
3818         (ATTR_ALLOC_CHUNK): Remove.
3819
3820 2020-01-08  Tom Tromey  <tromey@adacore.com>
3821
3822         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
3823
3824 2020-01-08  Tom Tromey  <tromey@adacore.com>
3825
3826         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
3827         (dwarf2_compute_name, open_dwo_file): Likewise.
3828         (process_enumeration_scope): Use std::vector.
3829         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
3830         (partial_die_info::fixup, dwarf2_start_subfile)
3831         (guess_full_die_structure_name, dwarf2_name): Likewise.
3832         (determine_prefix): Update.
3833         (guess_full_die_structure_name): Make return type const.
3834         (partial_die_full_name): Return unique_xmalloc_ptr.
3835         (DW_FIELD_ALLOC_CHUNK): Remove.
3836
3837 2020-01-07  Tom Tromey  <tromey@adacore.com>
3838
3839         PR build/24937:
3840         * stap-probe.c (class stap_static_probe_ops): Add constructor.
3841
3842 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3843
3844         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
3845
3846 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3847
3848         * stack.c (print_frame_info): Move disassemble_next_line code
3849         inside source_print block.
3850
3851 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3852
3853         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
3854         gdb/signals.h, as we are now using native signal symbols.
3855
3856 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3857
3858         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
3859         overflow by an early check of content vs threshold.
3860         * tui/tui-source.c (tui_source_window::line_is_displayed):
3861         Likewise.
3862
3863 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3864
3865         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
3866
3867 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3868
3869         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
3870         export table if no section contains it's RVA.
3871
3872 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3873
3874         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
3875
3876 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
3877
3878         * source.c (print_source_lines_base): Set last_line_listed.
3879
3880 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3881
3882         * tui/tui-disasm.c: Remove trailing spaces.
3883
3884 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3885             Pedro Alves  <palves@redhat.com>
3886
3887         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
3888         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
3889         (windows_gdb_signal_to_target): New function, uses the above
3890         enumeration to convert GDB internal signal codes to equivalent
3891         Windows codes.
3892         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
3893         * windows-nat.c: Include "gdb_wait.h".
3894         (get_windows_debug_event): Extract the fatal exception from the
3895         exit status and convert to the equivalent Posix signal number.
3896         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
3897         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
3898         * gdbsupport/gdb_wait.c: New file, implements
3899         windows_status_to_termsig.
3900         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
3901         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
3902
3903 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
3906         show_layout.
3907
3908 2020-01-05  Luis Machado  <luis.machado@linaro.org>
3909
3910         * aarch64-linux-nat.c
3911         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
3912         and bfd_mach_aarch64.
3913
3914 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3915
3916         * ui-file.c (stdio_file::can_emit_style_escape)
3917         (tee_file::can_emit_style_escape): Ensure style is used also on
3918         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
3919         to gdb_stdout.
3920         * main.c (set_gdb_data_directory): Use file style to output the
3921         warning that the given pathname is not a directory.
3922         * top.c (show_history_filename, gdb_safe_append_history)
3923         (show_gdb_datadir): Use file style.
3924
3925 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
3926
3927         * solib-target.c (struct lm_info_target):
3928         Change offsets to be a unique_xmalloc_ptr.
3929         (solib_target_relocate_section_addresses): Update.
3930
3931 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
3932
3933         * windows-nat.c (windows_clear_solib): Free so_list linked list.
3934
3935 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3936
3937         * MAINTAINERS (Write After Approval): Add myself.
3938
3939 2020-01-02  Luis Machado  <luis.machado@linaro.org>
3940
3941         * proc-service.c (get_ps_regcache): Remove reference to obsolete
3942         Cell BE architecture.
3943         * target.h (struct target_ops) <thread_architecture>: Likewise.
3944
3945 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
3946
3947         * Makefile.in: Use INSTALL_PROGRAM_ENV.
3948
3949 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
3950
3951         * MAINTAINERS (Write After Approval): Add myself.
3952
3953 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3954
3955         * gdbarch.sh: Update copyright year range of generated files.
3956
3957 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3958
3959         Update copyright year range in all GDB files.
3960
3961 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3962
3963         * copyright.py: Convert to Python 3.
3964
3965 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3966
3967         * copyright.py: Adapt after move of gnulib directory from gdb
3968         directory to toplevel directory.
3969
3970 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3971
3972         * copyright.py (main): Exit if run from the wrong directory.
3973
3974 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3975
3976         * top.c (print_gdb_version): Change copyright year to 2020.
3977
3978 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3979
3980         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
3981
3982 For older changes see ChangeLog-2019.
3983 \f
3984 Local Variables:
3985 mode: change-log
3986 left-margin: 8
3987 fill-column: 74
3988 version-control: never
3989 coding: utf-8
3990 End: