gdb/ChangeLog

   1 2019-01-23  Tom Tromey  <tom@tromey.com>
   2
   3         * ui-out.h (class ui_out_emit_type): Update comment.
   4
   5 2019-01-23  Tom Tromey  <tom@tromey.com>
   6
   7         * infrun.c (fetch_inferior_event): Update comment.
   8
   9 2019-01-23  Tom Tromey  <tom@tromey.com>
  10             Pedro Alves  <palves@redhat.com>
  11
  12         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
  13         parameter.
  14         (fetch_inferior_event): Use SCOPE_EXIT.
  15
  16
  17 2019-01-23  Tom Tromey  <tom@tromey.com>
  18             Pedro Alves  <palves@redhat.com>
  19
  20         * infrun.c (disable_thread_events): Delete.
  21         (stop_all_threads): Use SCOPE_EXIT.
  22
  23 2019-01-23  Tom Tromey  <tom@tromey.com>
  24             Pedro Alves  <palves@redhat.com>
  25
  26         * symfile.c: Include forward-scope-exit.h.
  27         (clear_symtab_users_cleanup): Replace forward declaration with
  28         a FORWARD_SCOPE_EXIT.
  29         (syms_from_objfile_1): Use the forward_scope_exit and
  30         gdb::optional instead of cleanup_function.
  31         (reread_symbols): Use the forward_scope_exit instead of
  32         cleanup_function.
  33         (clear_symtab_users_cleanup): Remove function.
  34
  35 2019-01-23  Tom Tromey  <tom@tromey.com>
  36             Pedro Alves  <palves@redhat.com>
  37
  38         * linux-nat.c: Include scope-exit.h.
  39         (cleanup_target_stop): Remove.
  40         (linux_nat_target::static_tracepoint_markers_by_strid): Use
  41         SCOPE_EXIT.
  42
  43 2019-01-23  Tom Tromey  <tom@tromey.com>
  44             Pedro Alves  <palves@redhat.com>
  45
  46         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
  47         (call_function_by_hand_dummy): Use SCOPE_EXIT.
  48
  49 2019-01-23  Tom Tromey  <tom@tromey.com>
  50             Andrew Burgess  <andrew.burgess@embecosm.com>
  51             Pedro Alves  <palves@redhat.com>
  52
  53         * infrun.c (fetch_inferior_event): Use scope_exit.
  54         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
  55         * top.c (execute_command): Use scope_exit.
  56         * breakpoint.c (bpstat_do_actions): Use scope_exit.
  57         * utils.c (do_bpstat_clear_actions_cleanup)
  58         (make_bpstat_clear_actions_cleanup): Remove.
  59
  60 2019-01-23  Tom Tromey  <tom@tromey.com>
  61             Pedro Alves  <palves@redhat.com>
  62
  63         * infrun.c: Include "common/scope-exit.h"
  64         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
  65         (wait_for_inferior): Use SCOPE_EXIT.
  66         (fetch_inferior_event): Use scope_exit.
  67
  68 2019-01-23  Tom Tromey  <tom@tromey.com>
  69             Pedro Alves  <palves@redhat.com>
  70
  71         * breakpoint.c (create_breakpoint): Remove cleanup.
  72
  73 2019-01-23  Tom Tromey  <tom@tromey.com>
  74             Andrew Burgess  <andrew.burgess@embecosm.com>
  75             Pedro Alves  <palves@redhat.com>
  76
  77 2019-01-23  Pedro Alves  <palves@redhat.com>
  78
  79         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
  80
  81 2019-01-23  Pedro Alves  <palves@redhat.com>
  82             Andrew Burgess  <andrew.burgess@embecosm.com>
  83
  84         * gdbthread.h: Include "common/forward-scope-exit.h".
  85         (scoped_finish_thread_state): Redefine custom class in terms of
  86         forward_scope_exit.
  87
  88 2019-01-23  Pedro Alves  <palves@redhat.com>
  89             Andrew Burgess  <andrew.burgess@embecosm.com>
  90
  91         * common/forward-scope-exit.h: New file.
  92
  93 2019-01-23  Pedro Alves  <palves@redhat.com>
  94             Andrew Burgess  <andrew.burgess@embecosm.com>
  95             Tom Tromey  <tom@tromey.com>
  96
  97         * common/scope-exit.h: New file.
  98
  99 2019-01-23  Pedro Alves  <palves@redhat.com>
 100
 101         * common/preprocessor.h (ESC): Rename to ...
 102         (ESC_PARENS): ... this.
 103         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 104         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 105
 106 2019-01-23  Tom Tromey  <tom@tromey.com>
 107
 108         * language.h (class scoped_switch_to_sym_language_if_auto):
 109         Initialize m_lang in both cases.
 110
 111 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 112
 113         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 114         with XCNEW.
 115
 116 2019-01-22  Tom Tromey  <tom@tromey.com>
 117
 118         * corelow.c: Do not include sys/file.h.
 119
 120 2019-01-22  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-wingeneral.h: Include gdb_curses.h.
 123
 124 2019-01-22  Tom Tromey  <tom@tromey.com>
 125
 126         * source-cache.h (class source_cache) <get_source_lines,
 127         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 128
 129 2019-01-22  Tom Tromey  <tom@tromey.com>
 130
 131         * remote-fileio.h (struct remote_target): Declare.
 132
 133 2019-01-22  Tom Tromey  <tom@tromey.com>
 134
 135         * python/py-arch.c: Do not include py-ref.h.
 136         * python/py-bpevent.c: Do not include py-ref.h.
 137         * python/py-cmd.c: Do not include py-ref.h.
 138         * python/py-continueevent.c: Do not include py-ref.h.
 139         * python/py-event.h: Do not include py-ref.h.
 140         * python/py-evtregistry.c: Do not include py-ref.h.
 141         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 142         * python/py-frame.c: Do not include py-ref.h.
 143         * python/py-framefilter.c: Do not include py-ref.h.
 144         * python/py-function.c: Do not include py-ref.h.
 145         * python/py-infevents.c: Do not include py-ref.h.
 146         * python/py-linetable.c: Do not include py-ref.h.
 147         * python/py-objfile.c: Do not include py-ref.h.
 148         * python/py-param.c: Do not include py-ref.h.
 149         * python/py-prettyprint.c: Do not include py-ref.h.
 150         * python/py-progspace.c: Do not include py-ref.h.
 151         * python/py-symbol.c: Do not include py-ref.h.
 152         * python/py-symtab.c: Do not include py-ref.h.
 153         * python/py-type.c: Do not include py-ref.h.
 154         * python/py-unwind.c: Do not include py-ref.h.
 155         * python/py-utils.c: Do not include py-ref.h.
 156         * python/py-value.c: Do not include py-ref.h.
 157         * python/py-varobj.c: Do not include py-ref.h.
 158         * python/py-xmethods.c: Do not include py-ref.h.
 159         * python/python.c: Do not include py-ref.h.
 160         * varobj.c: Do not include py-ref.h.
 161
 162 2019-01-22  Tom Tromey  <tom@tromey.com>
 163
 164         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 165         keyword for bcache.
 166
 167 2019-01-22  Tom Tromey  <tom@tromey.com>
 168
 169         * compile/compile-cplus-types.c: Remove a comment by #include.
 170
 171 2019-01-22  Tom Tromey  <tom@tromey.com>
 172
 173         * compile/gcc-c-plugin.h: Include compile-internal.h.
 174
 175 2019-01-22  Tom Tromey  <tom@tromey.com>
 176
 177         * stabsread.c (EXTERN): Do not define.
 178         (symnum, next_symbol_text_func, processing_gcc_compilation)
 179         (within_function, global_sym_chain, global_stabs)
 180         (previous_stab_code, this_object_header_files)
 181         (n_this_object_header_files)
 182         (n_allocated_this_object_header_files): Define.
 183         * stabsread.h (EXTERN): Never define.  Use "extern".
 184
 185 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 186
 187         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 188         history_value.
 189
 190 2019-01-21  Tom Tromey  <tom@tromey.com>
 191
 192         * ui-out.c: Fix includes.
 193         * tui/tui-source.c: Fix includes.
 194         * target.c: Fix includes.
 195         * remote.c: Fix includes.
 196         * regcache.c: Fix includes.
 197         * python/py-block.c: Fix includes.
 198         * printcmd.c: Fix includes.
 199         * or1k-tdep.c: Fix includes.
 200         * mi/mi-main.c: Fix includes.
 201         * m32r-tdep.c: Fix includes.
 202         * csky-tdep.c: Fix includes.
 203         * compile/compile-cplus-types.c: Fix includes.
 204         * cli/cli-interp.c: Fix includes.
 205
 206 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 207
 208         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 209         for padding.
 210
 211 2019-01-16  Tom Tromey  <tom@tromey.com>
 212
 213         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 214         earlier.
 215         (struct objfile) <msymbols_range>: Move from top level.
 216         <msymbols>: New method.
 217         (class objfile_msymbols): Remove.
 218         * symtab.c (default_collect_symbol_completion_matches_break_on):
 219         Update.
 220         * symmisc.c (dump_msymbols): Update.
 221         * stabsread.c (scan_file_globals): Update.
 222         * objc-lang.c (info_selectors_command, info_classes_command)
 223         (find_methods): Update.
 224         * minsyms.c (find_solib_trampoline_target): Update.
 225         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 226         * coffread.c (coff_symfile_read): Update.
 227         * ada-lang.c (ada_lookup_simple_minsym)
 228         (ada_collect_symbol_completion_matches): Update.
 229
 230 2019-01-16  Tom Tromey  <tom@tromey.com>
 231
 232         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 233         type.  Remove no-argument constructor.
 234         <iterator::operator++>: Simplify.
 235         <begin>: Update.
 236         <end>: Use minimal_symbol_count.
 237
 238 2019-01-16  Tom Tromey  <tom@tromey.com>
 239
 240         * objfiles.h (struct objfile) <psymtabs>: New method.
 241         (class objfile_psymtabs): Remove.
 242         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 243         typedef.
 244         <range>: New method.
 245         (require_partial_symbols): Change return type.
 246         * psymtab.c (require_partial_symbols)
 247         (psym_expand_symtabs_matching): Update.
 248         * mdebugread.c (parse_partial_symbols): Update.
 249         * dbxread.c (dbx_end_psymtab): Update.
 250
 251 2019-01-15  Tom Tromey  <tom@tromey.com>
 252
 253         * symtab.c (lookup_objfile_from_block)
 254         (lookup_symbol_in_objfile_symtabs)
 255         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 256         (find_line_symtab, info_sources_command)
 257         (default_collect_symbol_completion_matches_break_on)
 258         (make_source_files_completion_list): Update.
 259         * symmisc.c (print_objfile_statistics, dump_objfile)
 260         (maintenance_print_symbols, maintenance_info_symtabs)
 261         (maintenance_check_symtabs, maintenance_info_line_tables):
 262         Update.
 263         * source.c (select_source_symtab)
 264         (forget_cached_source_info_for_objfile): Update.
 265         * objfiles.h (class objfile_compunits): Remove.
 266         (struct objfile) <compunits_range>: New typedef.
 267         (compunits): New method.
 268         * objfiles.c (objfile_relocate1): Update.
 269         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 270         * maint.c (count_symtabs_and_blocks): Update.
 271         * linespec.c (iterate_over_all_matching_symtabs): Update.
 272         * cp-support.c (add_symbol_overload_list_qualified): Update.
 273         * coffread.c (coff_symtab_read): Update.
 274         * ada-lang.c (add_nonlocal_symbols)
 275         (ada_collect_symbol_completion_matches)
 276         (ada_add_global_exceptions): Update.
 277
 278 2019-01-15  Tom Tromey  <tom@tromey.com>
 279
 280         * progspace.h (program_space) <objfiles_safe_range>: New
 281         typedef.
 282         <objfiles_safe>: New method.
 283         * objfiles.h (class all_objfiles_safe): Remove.
 284         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 285         * jit.c (jit_inferior_exit_hook): Update.
 286
 287 2019-01-17  Tom Tromey  <tom@tromey.com>
 288
 289         * progspace.h (program_space) <objfiles_range>: New typedef.
 290         <objfiles>: New method.
 291         <objfiles_head>: Rename from objfiles.
 292         (object_files): Update.
 293         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 294         * guile/scm-pretty-print.c
 295         (ppscm_find_pretty_printer_from_objfiles): Update.
 296         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 297         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 298         Update.
 299         * python/py-progspace.c (pspy_get_objfiles): Update.
 300         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 301         Update.
 302         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 303         (objfpy_lookup_objfile_by_build_id): Update.
 304         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 305         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 306         Update.
 307         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 308         (expand_symtab_containing_pc, lookup_objfile_from_block)
 309         (lookup_static_symbol, basic_lookup_transparent_type)
 310         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 311         (find_line_symtab, info_sources_command)
 312         (default_collect_symbol_completion_matches_break_on)
 313         (make_source_files_completion_list, find_main_name): Update.
 314         * symmisc.c (print_symbol_bcache_statistics)
 315         (print_objfile_statistics, maintenance_print_symbols)
 316         (maintenance_print_msymbols, maintenance_print_objfiles)
 317         (maintenance_info_symtabs, maintenance_check_symtabs)
 318         (maintenance_expand_symtabs, maintenance_info_line_tables):
 319         Update.
 320         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 321         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 322         (map_overlay_command, unmap_overlay_command)
 323         (simple_overlay_update, expand_symtabs_matching)
 324         (map_symbol_filenames): Update.
 325         * symfile-debug.c (set_debug_symfile): Update.
 326         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 327         Update.
 328         * source.c (select_source_symtab, forget_cached_source_info):
 329         Update.
 330         * solib.c (solib_read_symbols): Update.
 331         * solib-spu.c (append_ocl_sos): Update.
 332         * psymtab.c (maintenance_print_psymbols)
 333         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 334         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 335         * printcmd.c (info_symbol_command): Update.
 336         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 337         Update.
 338         * objfiles.h (class all_objfiles): Remove.
 339         * objfiles.c (have_partial_symbols, have_full_symbols)
 340         (have_minimal_symbols, qsort_cmp, update_section_map)
 341         (shared_objfile_contains_address_p)
 342         (default_iterate_over_objfiles_in_search_order): Update.
 343         * objc-lang.c (info_selectors_command, info_classes_command)
 344         (find_methods): Update.
 345         * minsyms.c (find_solib_trampoline_target): Update.
 346         * maint.c (maintenance_info_sections)
 347         (maintenance_translate_address, count_symtabs_and_blocks):
 348         Update.
 349         * main.c (captured_main_1): Update.
 350         * linux-thread-db.c (try_thread_db_load_from_pdir)
 351         (has_libpthread): Update.
 352         * linespec.c (iterate_over_all_matching_symtabs)
 353         (search_minsyms_for_name): Update.
 354         * jit.c (jit_find_objf_with_entry_addr): Update.
 355         * hppa-tdep.c (find_unwind_entry)
 356         (hppa_lookup_stub_minimal_symbol): Update.
 357         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 358         Update.
 359         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 360         (elf_gnu_ifunc_resolve_by_got): Update.
 361         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 362         * dwarf-index-write.c (save_gdb_index_command): Update.
 363         * cp-support.c (add_symbol_overload_list_qualified): Update.
 364         * breakpoint.c (create_overlay_event_breakpoint)
 365         (create_longjmp_master_breakpoint)
 366         (create_std_terminate_master_breakpoint)
 367         (create_exception_master_breakpoint): Update.
 368         * blockframe.c (find_pc_partial_function): Update.
 369         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 370         (ada_collect_symbol_completion_matches)
 371         (ada_add_global_exceptions): Update.
 372
 373 2019-01-17  Tom Tromey  <tom@tromey.com>
 374
 375         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 376         declare VEC.
 377         (solib_target_parse_libraries): Change return type.
 378         (library_list_start_segment, library_list_start_section)
 379         (library_list_end_library, library_list_start_library); Update.
 380         (solib_target_free_library_list): Remove.
 381         (solib_target_parse_libraries): Remove cleanup.  Change return
 382         type.
 383         (solib_target_current_sos): Update.
 384
 385 2019-01-17  Tom Tromey  <tromey@bapiya>
 386
 387         * valprint.c: Replace "the the" with "the".
 388         * symtab.c: Replace "the the" with "the".
 389         * solib.c: Replace "the the" with "the".
 390         * solib-dsbt.c: Replace "the the" with "the".
 391         * linespec.c: Replace "the the" with "the".
 392         * dwarf2loc.h: Replace "the the" with "the".
 393         * amd64-windows-tdep.c: Replace "the the" with "the".
 394         * aarch64-tdep.c: Replace "the the" with "the".
 395
 396 2019-01-16  Keith Seitz  <keiths@redhat.com>
 397
 398         PR gdb/23773
 399         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 400         <builder>: Rename to ..
 401         <m_builder>: ... this and make private.
 402         (dwarf2_cu::get_builder): New method.  Change all users of
 403         `builder' to use this method.
 404         (dwarf2_start_symtab): Move to ...
 405         (dwarf2_cu::start_symtab): ... here.  Update all callers
 406         (setup_type_unit_groups): Move to ...
 407         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 408         callers.
 409         (dwarf2_cu::reset_builder): New method.
 410         (process_full_compunit, process_full_type_unit): Use
 411         dwarf2_cu::reset_builder.
 412         (follow_die_offset): Record the ancestor CU if it is different
 413         from the followed DIE's CU.
 414         (follow_die_sig_1): Likewise.
 415
 416 2019-01-15  Tom Tromey  <tom@tromey.com>
 417
 418         * remote.c (class remote_state) <buf>: Now a char_vector.
 419         <buf_size>: Remove.
 420         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 421         parameter.
 422         (remote_target::getpkt_or_notif_sane_1)
 423         (remote_target::getpkt_sane)
 424         (remote_target::getpkt_or_notif_sane): Likewise.
 425         (class remote_target) <putpkt>: New overload.
 426         (remote_target::read_frame): Change type of "buf_p".  Remove
 427         sizeof_p parameter.
 428         (packet_ok): New overload.
 429         (packet_check_result): New overload.
 430         Update all uses.
 431
 432 2019-01-14  Tom Tromey  <tom@tromey.com>
 433
 434         * remote-notif.c (handle_notification, remote_notif_ack)
 435         (remote_notif_parse): Make "buf" const.
 436         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 437         const.
 438         (remote_notif_parse, remote_notif_ack, handle_notification):
 439         Likewise.
 440         * remote.c (remote_notif_stop_parse): Make "buf" const.
 441         (remote_target::remote_parse_stop_reply): Make "buf" const.
 442         (remote_notif_stop_ack): Make "buf" const.
 443
 444 2019-01-14  Tom Tromey  <tom@tromey.com>
 445
 446         * remote.c (remote_console_output): Make parameter const.
 447
 448 2019-01-14  Tom Tromey  <tom@tromey.com>
 449
 450         * target-debug.h (target_debug_print_signals): Constify.
 451         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 452         * procfs.c (procfs_target::pass_signals): Update.
 453         * linux-nat.c (linux_nat_target::pass_signals): Update.
 454         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 455         * target-delegates.c: Rebuild.
 456         * remote.c (remote_target::program_signals): Update.
 457         (remote_target::pass_signals): Update.
 458         * target.c (target_pass_signals): Constify argument.
 459         (target_program_signals): Likewise.
 460         * target.h (struct target_ops) <pass_signals, program_signals>:
 461         Constify argument.
 462         (target_pass_signals, target_program_signals): Constify argument.
 463
 464 2019-01-14  Tom Tromey  <tom@tromey.com>
 465
 466         PR tui/28819:
 467         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 468
 469 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 470
 471         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 472         field.
 473         * rs6000-tdep.c: Include reggroups.h.
 474         (IS_V_ALIAS_PSEUDOREG): Define.
 475         (rs6000_register_name): Return names for the "vX" aliases.
 476         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 477         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 478         aliases.  Call default_register_reggroup_p for all other
 479         pseudo-registers.
 480         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 481         New functions.
 482         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 483         Handle "vX" aliases.
 484         (v_alias_pseudo_register_collect): New function.
 485         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 486         (rs6000_gdbarch_init): Initialize "vX" aliases as
 487         pseudo-registers.  Restore registration of
 488         rs6000_pseudo_register_reggroup_p with
 489         set_tdesc_pseudo_register_reggroup_p.
 490
 491 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 492
 493         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 494         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 495         set_gdbarch_num_pseudo_regs.
 496
 497 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 498
 499         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 500         Remove arg prefixname, add do_set and do_show.
 501         Add member functions set_list and show_list.
 502         * cli/cli-style.c (class cli_style_option): Update accordingly.
 503         (style_set_list): Move to file scope.
 504         (style_show_list): Likewise.
 505         (set_style): Call help_list.
 506         (show_style): Call cmd_show_list.
 507         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 508         Update to use the new macro.
 509
 510 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 511
 512         * ada-lang.c (_initialize_ada_language): Expand the help text
 513         for the "catch exception" command.
 514
 515 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 516
 517         * symtab.c (matching_obj_sections): Initialize obj,
 518         declare it closer to its usage.
 519
 520 2019-01-10  Tom Tromey  <tom@tromey.com>
 521
 522         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 523         (basic_inf_threads_range): Remove.
 524         (inf_threads_range, inf_non_exited_threads_range)
 525         (safe_inf_threads_range): Use next_adapter.
 526
 527 2019-01-10  Keith Seitz  <keiths@redhat.com>
 528
 529         PR gdb/23712
 530         PR symtab/23010
 531         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 532         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 533
 534 2019-01-10  Keith Seitz  <keiths@redhat.com>
 535
 536         PR gdb/23712
 537         PR symtab/23010
 538         * dictionary.c (pending_to_vector): Remove.
 539         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 540         Remove _1 suffix, replacing functions of the same name.  Update
 541         all callers.
 542         (dict_create_hashed, dict_create_hashed_expandable)
 543         (dict_create_linear, dict_create_linear_expandable, dict_free)
 544         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 545         Make functions static.
 546
 547 2019-01-10  Keith Seitz  <keiths@redhat.com>
 548
 549         PR gdb/23712
 550         PR symtab/23010
 551         * dictionary.h (struct dictionary): Replace declaration with
 552         multidictionary.
 553         (dict_create_hashed, dict_create_hashed_expandable)
 554         (dict_create_linear, dict_create_linear_expandable)
 555         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 556         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 557         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 558         taking multidictionary argument.
 559         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 560         * block.h (struct block) <dict>: Change to multidictionary
 561         and rename `multidict'.
 562         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 563         symmisc.c: Update all dictionary references to multidictionary.
 564
 565 2019-01-10  Keith Seitz  <keiths@redhat.com>
 566
 567         PR gdb/23712
 568         PR symtab/23010
 569         * dictionary.c: Include unordered_map.
 570         (pending_to_vector): New function.
 571         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 572         Rewrite the non-"_1" functions to take vector instead
 573         of linked list.
 574         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 575         "new" _1 versions of the same name.
 576         (multidictionary): Define.
 577         (std::hash<enum language): New definition.
 578         (collate_pending_symbols_by_language, mdict_create_hashed)
 579         (mdict_create_hashed_expandable, mdict_create_linear)
 580         (mdict_create_linear_expandable, mdict_free)
 581         (find_language_dictionary, create_new_language_dictionary)
 582         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 583         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 584         (mdict_size, mdict_empty): New functions.
 585         * dictionary.h (mdict_iterator): Define.
 586
 587 2019-01-10  Pedro Alves  <palves@redhat.com>
 588
 589         * breakpoint.c (read_uploaded_action)
 590         (create_tracepoint_from_upload): Adjust to use
 591         gdb::unique_xmalloc_ptr.
 592         * ctf.c (ctf_write_uploaded_tp):
 593         (SET_ARRAY_FIELD): Use emplace_back.
 594         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 595         * tracefile-tfile.c (tfile_write_uploaded_tp):
 596         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 597         gdb::unique_xmalloc_ptr.
 598         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 599         at_string, cond_string, cmd_strings>: Replace char pointers
 600         with gdb::unique_xmalloc_ptr.
 601
 602 2019-01-10  Pedro Alves  <palves@redhat.com>
 603
 604         * solib-target.c (library_list_start_library): Don't xstrdup name.
 605
 606 2019-01-10  Pedro Alves  <palves@redhat.com>
 607
 608         * mdebugread.c (parse_partial_symbols): Use
 609         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 610
 611 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 612
 613         * linux-fork.c (scoped_switch_fork_info)
 614         <~scoped_switch_fork_info>: Fix incorrect variable name.
 615
 616 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 617
 618         * linux-fork.c (scoped_switch_fork_info)
 619         <scoped_switch_fork_info>: Make explicit.
 620         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 621
 622 2019-01-10  Tom Tromey  <tom@tromey.com>
 623
 624         * objfiles.h (objfile::reset_psymtabs): Update.
 625         * objfiles.c (objfile::objfile): Update.
 626         * psymtab.h (psymtab_storage::obstack): Update.
 627         (psymtab_storage::m_obstack): Use gdb::optional.
 628         (class psymtab_storage): Update comment.  Remove objfile
 629         parameter.
 630         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 631
 632 2019-01-10  Tom Tromey  <tom@tromey.com>
 633
 634         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 635         <free_psymtabs>: Now private.
 636         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 637         (allocate_psymtab): Use new method.
 638
 639 2019-01-10  Tom Tromey  <tom@tromey.com>
 640
 641         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 642         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 643         * mdebugread.c (parse_partial_symbols): Use
 644         allocate_dependencies.
 645         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 646         allocate_dependencies.
 647         (process_psymtab_comp_unit_reader)
 648         (build_type_psymtab_dependencies): Likewise.
 649         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 650
 651 2019-01-10  Tom Tromey  <tom@tromey.com>
 652
 653         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 654         PSYMBOL_SET_LANGUAGE.
 655         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 656
 657 2019-01-10  Tom Tromey  <tom@tromey.com>
 658
 659         * psymtab.h (psymtab_storage::obstack): New method.
 660         <m_obstack>: Rename from obstack; now private.
 661         * psymtab.c (psymtab_storage): Update.
 662         * dwarf2read.c (create_addrmap_from_index)
 663         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 664         Update.
 665
 666 2019-01-10  Tom Tromey  <tom@tromey.com>
 667
 668         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 669         * objfiles.h (objfile::reset_psymtabs): New method.
 670
 671 2019-01-10  Tom Tromey  <tom@tromey.com>
 672
 673         * symmisc.c (print_symbol_bcache_statistics): Update.
 674         (print_objfile_statistics): Update.
 675         * symfile.c (reread_symbols): Update.
 676         * psymtab.h (class psymtab_storage): New.
 677         * psymtab.c (psymtab_storage): New constructor.
 678         (~psymtab_storage): New destructor.
 679         (require_partial_symbols): Update.
 680         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 681         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 682         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 683         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 684         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 685         (start_psymtab_common, end_psymtab_common)
 686         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 687         (allocate_psymtab): Update.
 688         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 689         Update.
 690         (dump_psymtab_addrmap, maintenance_print_psymbols)
 691         (maintenance_check_psymtabs): Update.
 692         (class objfile_psymtabs): Move to objfiles.h.
 693         * psympriv.h (discard_psymtab): Now inline.
 694         (psymtab_discarder::psymtab_discarder): Update.
 695         (psymtab_discarder::~psymtab_discarder): Update.
 696         (ALL_OBJFILE_PSYMTABS): Rewrite.
 697         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 698         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 699         Remove fields.
 700         <partial_symtabs>: New field.
 701         (class objfile_psymtabs): Move from psymtab.h.  Update.
 702         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 703         psymbol_cache.
 704         (objfile::~objfile): Don't destroy psymbol_cache.
 705         * mdebugread.c (parse_partial_symbols): Update.
 706         * dwarf2read.c (create_addrmap_from_index)
 707         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 708         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 709         (add_partial_subprogram, dwarf2_ranges_read): Update.
 710         * dwarf-index-write.c (write_address_map)
 711         (write_one_signatured_type, recursively_write_psymbols)
 712         (class debug_names, class debug_names, write_psymtabs_to_index):
 713         Update.
 714
 715 2019-01-10  Tom Tromey  <tom@tromey.com>
 716
 717         * symtab.h (SYMBOL_SET_NAMES): Update.
 718         (symbol_set_names): Update.
 719         (MSYMBOL_SET_NAMES): Update.
 720         * symtab.c (symbol_set_names): Change argument to be an
 721         objfile_per_bfd_storage.
 722         * psymtab.c (add_psymbol_to_bcache): Update.
 723         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 724
 725 2019-01-10  Tom Tromey  <tom@tromey.com>
 726
 727         * symtab.c (create_demangled_names_hash): Change argument to be an
 728         objfile_per_bfd_storage.
 729         (symbol_set_names): Update.
 730
 731 2019-01-10  Tom Tromey  <tom@tromey.com>
 732
 733         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 734         init_psymbol_list.
 735         * psymtab.c (init_psymbol_list): Do nothing if already called.
 736         * psympriv.h (init_psymbol_list): Add comment.
 737         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 738         init_psymbol_list.
 739         * dbxread.c (dbx_symfile_read): Unconditionally call
 740         init_psymbol_list.
 741
 742 2019-01-10  Tom Tromey  <tom@tromey.com>
 743
 744         * xcoffread.c (scan_xcoff_symtab): Update.
 745         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 746         "where".
 747         * mdebugread.c (parse_partial_symbols)
 748         (handle_psymbol_enumerators): Update.
 749         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 750         * dbxread.c (read_dbx_symtab): Update.
 751         * psympriv.h (psymbol_placement): New enum.
 752         (add_psymbol_to_list): Update.
 753
 754 2019-01-10  Tom Tromey  <tom@tromey.com>
 755
 756         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 757         static_psymbols parameters.
 758         (scan_xcoff_symtab): Update.
 759         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 760         static_psymbols parameters.
 761         * psympriv.h (start_psymtab_common): Update.
 762         * mdebugread.c (parse_partial_symbols): Update.
 763         * dwarf2read.c (create_partial_symtab): Update.
 764         * dbxread.c (read_dbx_symtab): Update.
 765         (start_psymtab): Remove global_psymbols and static_psymbols
 766         parameters.
 767
 768 2019-01-10  Tom Tromey  <tom@tromey.com>
 769
 770         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 771         * psymtab.c (allocate_psymtab): Add comment.
 772         * psympriv.h (allocate_psymtab): Add comment.
 773         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 774         initializations.
 775         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 776
 777 2019-01-10  Tom Tromey  <tom@tromey.com>
 778
 779         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 780         Don't declare.
 781         * mipsread.c: Include mdebugread.h.
 782         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 783         Declare.
 784         * elfread.c: Include mdebugread.h.
 785
 786 2019-01-09  Tom Tromey  <tom@tromey.com>
 787
 788         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 789         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 790         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 791         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 792         (psym_lookup_symbol, psym_find_last_source_symtab)
 793         (psym_forget_cached_source_info, psym_print_stats)
 794         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 795         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 796         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 797         (psym_find_compunit_symtab_by_address)
 798         (maintenance_print_psymbols, maintenance_info_psymtabs)
 799         (maintenance_check_psymtabs): Use ranged for.
 800         * psymtab.h (class objfile_psymtabs): New.
 801         (require_partial_symbols): Return objfile_psymtabs.
 802         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 803
 804 2019-01-09  Tom Tromey  <tom@tromey.com>
 805
 806         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 807         (find_pc_mapped_section, list_overlays_command)
 808         (map_overlay_command, unmap_overlay_command)
 809         (simple_overlay_update): Use all_objfiles.
 810         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 811         * printcmd.c (info_symbol_command): Use all_objfiles.
 812         * objfiles.h (ALL_OBJSECTIONS): Remove.
 813         * maint.c (maintenance_translate_address): Use all_objfiles.
 814         * gcore.c (gcore_create_callback): Use all_objfiles.
 815         (objfile_find_memory_regions): Likewise.
 816
 817 2019-01-09  Tom Tromey  <tom@tromey.com>
 818
 819         * symtab.c (find_line_symtab, info_sources_command)
 820         (make_source_files_completion_list): Use objfile_compunits.
 821         * source.c (select_source_symtab): Use objfile_compunits.
 822         * objfiles.h (struct objfile): Update comment.
 823         (ALL_OBJFILES): Remove.
 824         (ALL_FILETABS): Remove.
 825         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 826         objfile_compunits.
 827
 828 2019-01-09  Tom Tromey  <tom@tromey.com>
 829
 830         * symmisc.c (print_objfile_statistics, dump_objfile)
 831         (maintenance_print_symbols): Use compunit_filetabs.
 832         * source.c (forget_cached_source_info_for_objfile): Use
 833         compunit_filetabs.
 834         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 835         (ALL_FILETABS): Use compunit_filetabs.
 836         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 837         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 838
 839 2019-01-09  Tom Tromey  <tom@tromey.com>
 840
 841         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 842         (compunit_filetabs): New.
 843         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 844         compunit_filetabs.
 845         (info_sources_command, make_source_files_completion_list): Remove
 846         declaration.
 847         * symmisc.c (print_objfile_statistics, dump_objfile)
 848         (maintenance_print_symbols): Remove declaration.
 849         (maintenance_info_symtabs): Use compunit_filetabs.
 850         (maintenance_info_line_tables): Likewise.
 851         * source.c (select_source_symtab): Change local variable name.
 852         (forget_cached_source_info_for_objfile): Remove declaration.
 853         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 854         * objfiles.c (objfile_relocate1): Remove declaration.
 855         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 856         declaration.
 857         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 858         * coffread.c (coff_symtab_read): Remove declaration.
 859         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 860         compunit_filetabs.
 861
 862 2019-01-09  Tom Tromey  <tom@tromey.com>
 863
 864         * symtab.c (lookup_objfile_from_block)
 865         (find_pc_sect_compunit_symtab, search_symbols)
 866         (default_collect_symbol_completion_matches_break_on): Use
 867         objfile_compunits.
 868         * objfiles.h (ALL_COMPUNITS): Remove.
 869         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 870         * cp-support.c (add_symbol_overload_list_qualified): Use
 871         objfile_compunits.
 872         * ada-lang.c (ada_collect_symbol_completion_matches)
 873         (ada_add_global_exceptions): Use objfile_compunits.
 874
 875 2019-01-09  Tom Tromey  <tom@tromey.com>
 876
 877         * source.c (select_source_symtab)
 878         (forget_cached_source_info_for_objfile): Remove declaration.
 879         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 880         declaration.
 881         * maint.c (count_symtabs_and_blocks): Remove declaration.
 882         * cp-support.c (add_symbol_overload_list_qualified): Remove
 883         declaration.
 884         * coffread.c (coff_symtab_read): Remove declaration.
 885         * symtab.c (lookup_symbol_in_objfile_symtabs)
 886         (basic_lookup_transparent_type_1): Use objfile_compunits.
 887         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 888         (info_sources_command, search_symbols)
 889         (default_collect_symbol_completion_matches_break_on)
 890         (make_source_files_completion_list): Remove declaration.
 891         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 892         (ada_collect_symbol_completion_matches)
 893         (ada_add_global_exceptions): Remove declaration.
 894         * linespec.c (iterate_over_all_matching_symtabs): Use
 895         objfile_compunits.
 896         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 897         (class objfile_compunits): New.
 898         (ALL_COMPUNITS): Use objfile_compunits.
 899         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 900         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 901         objfile_compunits.
 902         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 903
 904 2019-01-09  Tom Tromey  <tom@tromey.com>
 905
 906         * symtab.c (search_symbols)
 907         (default_collect_symbol_completion_matches_break_on): Use
 908         objfile_msymbols.
 909         * ada-lang.c (ada_lookup_simple_minsym)
 910         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 911         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 912         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 913         objfile_msymbols.
 914         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 915         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 916         * objc-lang.c (find_methods): Use objfile_msymbols.
 917         (info_selectors_command, info_classes_command): Likewise.
 918         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 919         * objfiles.h (class objfile_msymbols): New.
 920         (ALL_OBJFILE_MSYMBOLS): Remove.
 921         (ALL_MSYMBOLS): Remove.
 922
 923 2019-01-09  Tom Tromey  <tom@tromey.com>
 924
 925         * common/next-iterator.h (next_adapter): Add Iterator template
 926         parameter.
 927         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 928         (class all_objfiles_safe): New.
 929         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 930         * objfiles.c (put_objfile_before): Update comment.
 931         (add_separate_debug_objfile): Likewise.
 932         (free_all_objfiles): Use all_objfiles_safe.
 933         (objfile_purge_solibs): Likewise.
 934
 935 2019-01-09  Tom Tromey  <tom@tromey.com>
 936
 937         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 938         (expand_symtab_containing_pc, lookup_static_symbol)
 939         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 940         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 941         all_objfiles.
 942         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 943         * breakpoint.c (create_overlay_event_breakpoint)
 944         (create_longjmp_master_breakpoint)
 945         (create_std_terminate_master_breakpoint)
 946         (create_exception_master_breakpoint): Use all_objfiles.
 947         * linux-thread-db.c (try_thread_db_load_from_pdir)
 948         (has_libpthread): Use all_objfiles.
 949         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 950         * linespec.c (iterate_over_all_matching_symtabs)
 951         (search_minsyms_for_name): Use all_objfiles.
 952         * maint.c (maintenance_info_sections): Use all_objfiles.
 953         * main.c (captured_main_1): Use all_objfiles.
 954         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 955         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 956         * guile/scm-pretty-print.c
 957         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 958         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 959         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 960         (maintenance_print_msymbols): Use all_objfiles.
 961         * source.c (select_source_symtab): Use all_objfiles.
 962         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 963         * symfile.c (remove_symbol_file_command)
 964         (expand_symtabs_matching, map_symbol_filenames): Use
 965         all_objfiles.
 966         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 967         all_objfiles.
 968         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 969         * objc-lang.c (find_methods): Use all_objfiles.
 970         * objfiles.c (have_partial_symbols, have_full_symbols)
 971         (have_minimal_symbols, qsort_cmp)
 972         (default_iterate_over_objfiles_in_search_order): Use
 973         all_objfiles.
 974         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 975         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 976         (maintenance_check_psymtabs): Use all_objfiles.
 977         (ALL_PSYMTABS): Remove.
 978         * compile/compile-object-run.c (do_module_cleanup): Use
 979         all_objfiles.
 980         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 981         * cp-support.c (add_symbol_overload_list_qualified): Use
 982         all_objfiles.
 983         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 984         Use all_objfiles.
 985         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 986         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 987         all_objfiles.
 988         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 989         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 990         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 991         Uses all_objfiles.
 992         * solib.c (solib_read_symbols): Use all_objfiles
 993
 994 2019-01-09  Tom Tromey  <tom@tromey.com>
 995
 996         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 997         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 998         all_objfiles.
 999         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1000         * symmisc.c (print_symbol_bcache_statistics)
1001         (print_objfile_statistics, maintenance_print_objfiles)
1002         (maintenance_info_symtabs, maintenance_check_symtabs)
1003         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1004         all_objfiles.
1005         * source.c (forget_cached_source_info): Use all_objfiles.
1006         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1007         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1008         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1009         * objfiles.c (update_section_map): Use all_objfiles.
1010         (shared_objfile_contains_address_p): Likewise.
1011         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1012         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1013
1014 2019-01-09  Tom Tromey  <tom@tromey.com>
1015
1016         * common/next-iterator.h: New file.
1017         * objfiles.h (class all_objfiles): New.
1018         (struct objfile_iterator): New.
1019
1020 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1021
1022         * NEWS: Move the description of the changed "frame", "select-frame",
1023          and "info frame" commands to the Changed commands section.
1024
1025 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1026
1027         * gdbtypes.c (check_stub_method_group): Remove handling of old
1028         mangling schemes.
1029         * linespec.c (find_methods): Likewise.
1030         * stabsread.c (read_member_functions): Likewise.
1031         * valops.c (search_struct_method): Likewise.
1032         (value_struct_elt_for_reference): Likewise.
1033         * NEWS: Mention this change.
1034
1035 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1038         print_source_lines.
1039         * source.c (print_source_lines_base): Update line number check.
1040         (print_source_lines): New function.
1041         (source_lines_range::source_lines_range): New function.
1042         * source.h (class source_lines_range): New class.
1043         (print_source_lines): New declaration.
1044
1045 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1046
1047         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1048
1049 2019-01-08  Tom Tromey  <tom@tromey.com>
1050             Simon Marchi  <simon.marchi@ericsson.com>
1051
1052         PR gdb/24060
1053         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1054         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1055         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1056         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1057         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1058         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1059
1060 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * source.c (select_source_symtab): Move header comment to
1063         declaration in source.h.
1064         (forget_cached_source_info_for_objfile): Likewise.
1065         (forget_cached_source_info): Likewise.
1066         (identify_source_line): Likewise.
1067         * source.h (identify_source_line): Move declaration from symtab.h
1068         and add comment from source.c
1069         (print_source_lines): Likewise.
1070         (forget_cached_source_info_for_objfile): Likewise.
1071         (forget_cached_source_info): Likewise.
1072         (select_source_symtab): Likewise.
1073         (enum print_source_lines_flag): Move definition from symtab.h.
1074         * symtab.h (identify_source_line): Move declaration to source.h.
1075         (print_source_lines): Likewise.
1076         (forget_cached_source_info_for_objfile): Likewise.
1077         (forget_cached_source_info): Likewise.
1078         (select_source_symtab): Likewise.
1079         (enum print_source_lines_flag): Move definition to source.h.
1080         * tui/tui-hooks.c: Add 'source.h' include.
1081
1082 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1083
1084         * source.c (print_source_lines_base): Handle requests to print
1085         reverse line number sequences, and guard against empty lines
1086         string.
1087
1088 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * source.c (print_source_lines_base): Fix skip of '\r' if next
1091         character is '\n'.
1092
1093 2019-01-06  Tom Tromey  <tom@tromey.com>
1094
1095         * c-exp.y (struct c_parse_state) <macro_original_text,
1096         expansion_obstack>: New member.
1097         (macro_original_text, expansion_obstack): Remove globals.
1098         (scan_macro_expansion, scanning_macro_expansion)
1099         (finished_macro_expansion): Update.
1100         (scan_macro_cleanup): Remove.
1101         (yylex, c_parse): Update.
1102
1103 2019-01-06  Tom Tromey  <tom@tromey.com>
1104
1105         * c-exp.y (struct c_parse_state) <strings>: New member.
1106         (operator_stoken): Update.
1107
1108 2019-01-06  Tom Tromey  <tom@tromey.com>
1109
1110         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1111         (union type_stack_elt) <typelist_val>: Now a pointer to
1112         std::vector.
1113         (type_stack_cleanup): Don't declare.
1114         (push_typelist): Update.
1115         * parse.c (pop_typelist): Return a std::vector.
1116         (push_typelist): Take a std::vector.
1117         (follow_types): Update.  Do not free args.
1118         (type_stack_cleanup): Remove.
1119         * c-exp.y (struct c_parse_state): New.
1120         (cpstate): New global.
1121         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1122         (nonempty_typelist): Update.
1123         (func_mod): Create a new vector.
1124         (c_parse): Create a c_parse_state.
1125         (check_parameter_typelist): Do not delete params.
1126         (function_method): Update.  Do not delete type_list.
1127
1128 2019-01-06  Tom Tromey  <tom@tromey.com>
1129
1130         PR gdb/28155:
1131         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1132         check_typedef.
1133         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1134         (print_return_value): Likewise.
1135
1136 2019-01-05  Tom Tromey  <tom@tromey.com>
1137
1138         * contrib/cleanup_check.py: Remove.
1139         * contrib/gcc-with-excheck: Remove.
1140         * contrib/exsummary.py: Remove.
1141         * contrib/excheck.py: Remove.
1142
1143 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1144
1145         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1146         NULL. Initialize tpprev to NULL instead of assigning it
1147         to NULL on the next statement.
1148         * windows-nat.c (windows_delete_thread): Remove check for
1149         main_thread_id before printing thread exit notifications.
1150         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1151         Remove thread ID check against main_thread_id.
1152         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1153         windows_delete_thread.
1154         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1155
1156 2019-01-04  Tom Tromey  <tom@tromey.com>
1157
1158         * compile/compile.c (_initialize_compile): Use upper case for
1159         metasyntactic variables.
1160         * symmisc.c (_initialize_symmisc): Use upper case for
1161         metasyntactic variables.
1162         * psymtab.c (_initialize_psymtab): Use upper case for
1163         metasyntactic variables.
1164         * demangle.c (demangle_command): Use upper case for metasyntactic
1165         variables.
1166         (_initialize_demangler): Likewise.
1167         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1168         variables.
1169
1170 2019-01-03  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1173
1174 2019-01-03  Tom Tromey  <tom@tromey.com>
1175
1176         * python/py-symtab.c (salpy_str): Update.
1177         (struct salpy_sal_object) <symtab>: Now a PyObject.
1178         (salpy_dealloc): Update.
1179         (del_objfile_sal): Use gdbpy_ref.
1180
1181 2019-01-03  Tom Tromey  <tom@tromey.com>
1182
1183         * python/py-type.c (convert_field): Use new_reference.  Return
1184         gdbpy_ref.
1185         (make_fielditem): Return gdbpy_ref.
1186         (typy_fields): Update.
1187         (typy_getitem): Update.
1188         (field_name): Return gdbpy_ref.  Use new_reference.
1189         (typy_iterator_iternext): Update.
1190
1191 2019-01-03  Tom Tromey  <tom@tromey.com>
1192
1193         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1194
1195 2019-01-03  Tom Tromey  <tom@tromey.com>
1196
1197         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1198         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1199         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1200         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1201         (pspy_set_type_printers): Likewise.
1202         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1203         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1204         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1205         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1206         (objfpy_set_type_printers): Likewise.
1207
1208 2019-01-03  Tom Tromey  <tom@tromey.com>
1209
1210         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1211         (gdbpy_print_stack): Use gdbpy_err_fetch.
1212         * python/python-internal.h (class gdbpy_err_fetch): New class.
1213         (class gdbpy_enter) <m_error_type, m_error_value,
1214         m_error_traceback>: Remove.
1215         <m_error>: New member.
1216         (gdbpy_exception_to_string): Don't declare.
1217         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1218         * python/py-value.c (convert_value_from_python): Use
1219         gdbpy_err_fetch.
1220         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1221         gdbpy_exception_to_string.
1222         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1223         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1224         gdbpy_err_fetch.
1225
1226 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * linux-nat.c (delete_lwp_cleanup): Delete.
1229         (struct lwp_deleter): New struct.
1230         (lwp_info_up): New typedef.
1231         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1232         lwp_info_up.
1233
1234 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * linux-fork.c (class scoped_switch_fork_info): New class.
1237         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1238
1239 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * valops.c (find_overload_match): Remove use of null_cleanup, and
1242         calls to do_cleanups.
1243
1244 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * compile/compile-cplus-types.c
1247         (compile_cplus_instance::decl_name): Handle changes to
1248         cp_func_name.
1249         * cp-support.c (cp_func_name): Update header comment, update
1250         return type.
1251         * cp-support.h (cp_func_name): Update return type in declaration.
1252         * valops.c (find_overload_match): Move temp_func local to top
1253         level of function and change its type.  Use temp_func to hold and
1254         delete temporary string obtained from cp_func_name.
1255
1256 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1259         gdb::char_vector, remove cleanup, and update uses of `msg`.
1260
1261 2019-01-03  Jim Wilson  <jimw@sifive.com>
1262
1263         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1264
1265 2019-01-02  Tom Tromey  <tom@tromey.com>
1266
1267         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1268         (tdesc_parse_xml): Remove cleanups.
1269         * target-descriptions.h (make_cleanup_free_target_description):
1270         Don't declare.
1271         (target_desc_deleter): New struct.
1272         (target_desc_up): New typedef.
1273         * target-descriptions.c (target_desc_deleter::operator()): Rename
1274         from free_target_description.
1275         (make_cleanup_free_target_description): Remove.
1276
1277 2019-01-02  Tom Tromey  <tom@tromey.com>
1278
1279         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1280         constructor, destructor.
1281         (linespec_parser): Remove typedef.
1282         (~linespec_parser): Rename from linespec_parser_delete.
1283         (linespec_lex_to_end, linespec_complete_label)
1284         (linespec_complete): Update.
1285         (decode_line_full): Remove cleanups.
1286         (decode_line_1): Update.
1287
1288 2019-01-02  Tom Tromey  <tom@tromey.com>
1289
1290         * python/python-internal.h (inferior_to_inferior_object): Change
1291         return type.
1292         * python/py-exitedevent.c (create_exited_event_object): Update.
1293         * python/py-inferior.c (inferior_to_inferior_object): Return
1294         gdbpy_ref.
1295         (python_new_inferior, python_inferior_deleted)
1296         (thread_to_thread_object, delete_thread_object)
1297         (build_inferior_list, gdbpy_selected_inferior): Update.
1298         * python/py-infthread.c (create_thread_object): Update.  Also fail
1299         if inferior_to_inferior_object fails.
1300
1301 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1302
1303         * inferior.h (class inferior) <displaced_step_state>: New field.
1304         * infrun.h (struct displaced_step_state): Move here from
1305         infrun.c.  Initialize fields, add constructor.
1306         <inf>: Remove field.
1307         <reset>: New method.
1308         * infrun.c (struct displaced_step_inferior_state): Move to
1309         infrun.h.
1310         (displaced_step_inferior_states): Remove.
1311         (get_displaced_stepping_state): Adust.
1312         (displaced_step_in_progress_any_inferior): Adjust.
1313         (displaced_step_in_progress_thread): Adjust.
1314         (displaced_step_in_progress): Adjust.
1315         (add_displaced_stepping_state): Remove.
1316         (get_displaced_step_closure_by_addr): Adjust.
1317         (remove_displaced_stepping_state): Remove.
1318         (infrun_inferior_exit): Call displaced_step_state.reset.
1319         (use_displaced_stepping): Don't check for NULL.
1320         (displaced_step_prepare_throw): Call
1321         get_displaced_stepping_state.
1322         (displaced_step_fixup): Don't check for NULL.
1323         (prepare_for_detach): Don't check for NULL.
1324
1325 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1326
1327         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1328          in case of call that did not complete.
1329
1330 2019-01-02  Andrey Utkin  <autkin@undo.io>
1331
1332         * symfile.c (find_separate_debug_file): Fix search of debug files for
1333         remote debuggee.
1334
1335 2019-01-02  Tom Tromey  <tom@tromey.com>
1336
1337         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1338         indentation.
1339         * python/py-frame.c (frapy_older): Remove cast.
1340         (frapy_newer): Likewise.
1341         * python/py-breakpoint.c (local_setattro): Remove cast.
1342         * python/py-arch.c (archpy_name): Remove local variable.
1343         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1344
1345 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1346
1347         * unittests/basic_string_view/element_access/char/empty.cc:
1348         Fix year range in copyright header.
1349
1350 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1353         Delete.
1354         <operator==>: Update with for removed field.
1355         <hash>: Likewise.
1356         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1357         <isa_features>: ...this.
1358         <abi_features>: New field.
1359         (riscv_isa_flen): Update comment.
1360         (riscv_abi_xlen): New declaration.
1361         (riscv_abi_flen): New declaration.
1362         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1363         isa_features.
1364         (riscv_abi_xlen): New function.
1365         (riscv_isa_flen): Update to get answer from isa_features.
1366         (riscv_abi_flen): New function.
1367         (riscv_has_fp_abi): Update to get answer from abi_features.
1368         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1369         xlen and flen.
1370         (riscv_call_info) <xlen, flen>: Update comment.
1371         (riscv_call_arg_struct): Remove invalid assertions
1372         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1373         is removed.
1374         (riscv_gdbarch_init): Gather isa features and abi features
1375         separately, ensure both match on the gdbarch when reusing an old
1376         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1377         a target with 64-bit float hardware.
1378
1379 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1380
1381         * source.c (search_command_helper): Stop reverse search
1382         when line 1 has been searched.
1383
1384 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1385
1386         * record-full.c (record_full_base_target::close): Rewrite
1387         record_full_core_buf_list free logic.
1388
1389 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1390
1391         * break-catch-syscall.c (print_one_catch_syscall): xfree
1392         the last text.
1393
1394 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1395
1396         * top.c (print_gdb_version): Update Copyright year in version
1397         message.
1398
1399 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1400
1401         Update copyright year range in all GDB files.
1402
1403 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1404
1405         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1406
1407 For older changes see ChangeLog-2018.
1408 \f
1409 Local Variables:
1410 mode: change-log
1411 left-margin: 8
1412 fill-column: 74
1413 version-control: never
1414 coding: utf-8
1415 End:
1416