gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * common/gdb_unique_ptr.h (struct noop_deleter): New.
   4
   5 2019-05-08  Tom Tromey  <tom@tromey.com>
   6
   7         * nto-tdep.c (nto_inferior_data_reg): Change type.
   8         (nto_inferior_data): Update.
   9         (nto_inferior_data_cleanup, nto_new_inferior_data)
  10         (_initialize_nto_tdep): Remove.
  11         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  12
  13 2019-05-08  Tom Tromey  <tom@tromey.com>
  14
  15         * ada-lang.c (struct ada_inferior_data): Add initializers.
  16         (ada_inferior_data): Change type.
  17         (ada_inferior_data_cleanup): Remove.
  18         (get_ada_inferior_data, ada_inferior_exit)
  19         (struct ada_pspace_data): Add initializers, destructor.
  20         (ada_pspace_data_handle): Change type.
  21         (get_ada_pspace_data): Update.
  22         (ada_pspace_data_cleanup): Remove.
  23
  24 2019-05-08  Tom Tromey  <tom@tromey.com>
  25
  26         * coffread.c (struct coff_symfile_info): Add initializers.
  27         (coff_objfile_data_key): Move lower.  Change type.
  28         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  29         Update.
  30         (coff_free_info): Remove.
  31
  32 2019-05-08  Tom Tromey  <tom@tromey.com>
  33
  34         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  35         (fbsd_pspace_data_handle): Move lower.  Change type.
  36         (get_fbsd_pspace_data): Update.
  37         (fbsd_pspace_data_cleanup): Remove.
  38         (_initialize_fbsd_tdep): Update.
  39
  40 2019-05-08  Tom Tromey  <tom@tromey.com>
  41
  42         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  43         (get_ada_tasks_pspace_data): Update.
  44         (ada_tasks_pspace_data_cleanup): Remove.
  45         (_initialize_tasks): Update.
  46         (ada_tasks_inferior_data_handle): Change type.
  47         (get_ada_tasks_inferior_data): Update.
  48         (ada_tasks_inferior_data_cleanup): Remove.
  49         (struct ada_tasks_pspace_data): Add initializers.
  50
  51 2019-05-08  Tom Tromey  <tom@tromey.com>
  52
  53         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  54         * symfile-debug.c (debug_sym_get_probes): Change type.
  55         * stap-probe.c (handle_stap_probe):
  56         (stap_static_probe_ops::get_probes): Change type.
  57         * probe.h (class static_probe_ops) <get_probes>: Change type.
  58         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  59         (parse_probes_in_pspace): Update.
  60         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  61         Update.
  62         (any_static_probe_ops::get_probes): Change type.
  63         * elfread.c (elfread_data): New typedef.
  64         (probe_key): Change type.
  65         (elf_get_probes): Likewise.  Update.
  66         (probe_key_free): Remove.
  67         (_initialize_elfread): Update.
  68         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  69         Change type.
  70         (dtrace_process_dof_probe, dtrace_process_dof)
  71         (dtrace_static_probe_ops::get_probe): Change type.
  72
  73 2019-05-08  Tom Tromey  <tom@tromey.com>
  74
  75         * xcoffread.c (struct xcoff_symfile_info): Rename from
  76         coff_symfile_info.  Add initializers.
  77         (xcoff_objfile_data_key): Move lower.  Change type.
  78         (XCOFF_DATA): Rewrite.
  79         (xcoff_free_info): Remove.
  80         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  81         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  82         (xcoff_initial_scan): Update.
  83
  84 2019-05-08  Tom Tromey  <tom@tromey.com>
  85
  86         * solib-svr4.c (struct svr4_info): Add initializers and
  87         destructor.
  88         <probes_table>: Now an htab_up.
  89         (solib_svr4_pspace_data): Change type.
  90         (free_probes_table): Simplify.
  91         (~svr4_info): Rename from svr4_pspace_data_cleanup.
  92         (get_svr4_info, probes_table_htab_remove_objfile_probes)
  93         (probes_table_remove_objfile_probes, register_solib_event_probe)
  94         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
  95         (_initialize_svr4_solib): Update.
  96
  97 2019-05-08  Tom Tromey  <tom@tromey.com>
  98
  99         * remote.c (remote_pspace_data): Change type.
 100         (remote_pspace_data_cleanup): Remove.
 101         (get_remote_exec_file, set_pspace_remote_exec_file)
 102         (_initialize_remote): Update.
 103
 104 2019-05-08  Tom Tromey  <tom@tromey.com>
 105
 106         * breakpoint.c (breakpoint_objfile_key): Change type.
 107         (get_breakpoint_objfile_data): Update.
 108         (free_breakpoint_objfile_data): Remove.
 109         (_initialize_breakpoint): Update.
 110
 111 2019-05-08  Tom Tromey  <tom@tromey.com>
 112
 113         * linux-tdep.c (struct linux_info): Add initializers.
 114         (linux_inferior_data): Move.  Change type.
 115         (invalidate_linux_cache_inf): Update.
 116         (linux_inferior_data_cleanup): Remove.
 117         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 118
 119 2019-05-08  Tom Tromey  <tom@tromey.com>
 120
 121         * auxv.c (auxv_inferior_data): Move.  Change type.
 122         (auxv_inferior_data_cleanup): Remove.
 123         (invalidate_auxv_cache_inf): Rewrite.
 124         (get_auxv_inferior_data, _initialize_auxv): Update.
 125
 126 2019-05-08  Tom Tromey  <tom@tromey.com>
 127
 128         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 129         (symfile_debug_objfile_data_key): Change type.
 130         (symfile_debug_installed, debug_qf_has_symbols)
 131         (debug_qf_find_last_source_symtab)
 132         (debug_qf_forget_cached_source_info)
 133         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 134         (debug_qf_print_stats, debug_qf_dump)
 135         (debug_qf_expand_symtabs_for_function)
 136         (debug_qf_expand_all_symtabs)
 137         (debug_qf_expand_symtabs_with_fullname)
 138         (debug_qf_map_matching_symbols)
 139         (debug_qf_expand_symtabs_matching)
 140         (debug_qf_find_pc_sect_compunit_symtab)
 141         (debug_qf_map_symbol_filenames)
 142         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 143         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 144         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 145         (debug_sym_read_linetable, debug_sym_relocate): Update.
 146         (symfile_debug_free_objfile): Remove.
 147         (install_symfile_debug_logging, _initialize_symfile_debug):
 148         Update.
 149
 150 2019-05-08  Tom Tromey  <tom@tromey.com>
 151
 152         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 153         allocate_on_obstack.
 154         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 155         (get_dwarf2_per_objfile): Update.
 156         (set_dwarf2_per_objfile): Remove.
 157         (dwarf2_has_info, dwarf2_get_section_info): Update.
 158         (dwarf2_free_objfile): Remove.
 159         (_initialize_dwarf2_read): Update.
 160
 161 2019-05-08  Tom Tromey  <tom@tromey.com>
 162
 163         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 164         initializers.
 165         <unsupported_script_warning_printed,
 166         script_not_found_warning_printed>: Now bool.
 167         (auto_load_pspace_data): Change type.
 168         (~auto_load_pspace_info): Rename from
 169         auto_load_pspace_data_cleanup.
 170         (get_auto_load_pspace_data, init_loaded_scripts_info)
 171         (clear_section_scripts, maybe_print_unsupported_script_warning)
 172         (maybe_print_script_not_found_warning, _initialize_auto_load):
 173         Update.
 174
 175 2019-05-08  Tom Tromey  <tom@tromey.com>
 176
 177         * objfiles.c (objfile_pspace_info): Add destructor and
 178         initializers.
 179         (objfiles_pspace_data): Change type.
 180         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 181         (get_objfile_pspace_data): Update.
 182         (objfiles_bfd_data): Change type.
 183         (get_objfile_bfd_data): Update.
 184         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 185
 186 2019-05-08  Tom Tromey  <tom@tromey.com>
 187
 188         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 189         Change type.
 190         (get_catch_syscall_inferior_data): Update.
 191         (catch_syscall_inferior_data_cleanup): Remove.
 192         (_initialize_break_catch_syscall): Update.
 193
 194 2019-05-08  Tom Tromey  <tom@tromey.com>
 195
 196         * inflow.c (struct terminal_info): Add destructor and
 197         initializers.
 198         (inflow_inferior_data): Change type.
 199         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 200         (get_inflow_inferior_data, inflow_inferior_exit)
 201         (swap_terminal_info, _initialize_inflow): Update.
 202
 203 2019-05-08  Tom Tromey  <tom@tromey.com>
 204
 205         * target-dcache.c (target_dcache_cleanup): Remove.
 206         (target_dcache_aspace_key): Change type.
 207         (target_dcache_init_p, target_dcache_invalidate)
 208         (target_dcache_get, target_dcache_get_or_init)
 209         (_initialize_target_dcache): Update.
 210         * dcache.h (struct dcache_deleter): New.
 211
 212 2019-05-08  Tom Tromey  <tom@tromey.com>
 213
 214         * symtab.c (struct symbol_cache): Add destructor and
 215         initializers.
 216         (symbol_cache_key): Move.  Change type.
 217         (make_symbol_cache, free_symbol_cache): Remove.
 218         (get_symbol_cache): Update.
 219         (symbol_cache_cleanup): Remove.
 220         (ALL_PSPACES, symbol_cache_flush)
 221         (maintenance_print_symbol_cache)
 222         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 223         Update.
 224
 225 2019-05-08  Tom Tromey  <tom@tromey.com>
 226
 227         * symtab.c (struct main_info): Add destructor and initializers.
 228         (main_progspace_key): Move.  Change type.
 229         (get_main_info): Update.
 230         (main_info_cleanup): Remove.
 231         (_initialize_symtab): Update.
 232
 233 2019-05-08  Tom Tromey  <tom@tromey.com>
 234
 235         * registry.h (DECLARE_REGISTRY): Define the _key class.
 236
 237 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * NEWS: Merge two 'New commands' sections.
 240
 241 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 242
 243         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 244         parameter and use Ada language definition instead.
 245         (ada_val_print_ptr): Remove unused language parameter.
 246         (ada_val_print_num): Remove language parameter and use Ada language
 247         definition instead.
 248         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 249         parameter.
 250         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 251         parameter and use Ada language definition instead.
 252         (ada_val_print_1): Update all ada_val_print_xxx calls.
 253         Remove language parameter.
 254         (ada_val_print): Update ada_val_print_1 call.
 255
 256 2019-05-08  Tom Tromey  <tromey@adacore.com>
 257
 258         * remote.c (remote_hw_watchpoint_limit)
 259         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 260         Now static.
 261
 262 2019-05-08  Tom Tromey  <tromey@adacore.com>
 263
 264         * maint.c (_initialize_maint_cmds): Move initialization code to
 265         remote.c.
 266         (watchdog, show_watchdog): Move to remote.c.
 267         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 268         "watchdog" static.
 269         (_initialize_remote): Move initialization code from maint.c.
 270         * defs.h (watchdog): Don't declare.
 271
 272 2019-05-08  Tom Tromey  <tromey@adacore.com>
 273
 274         * tui/tui-interp.c: Include main.h.
 275         * interps.c: Include main.h.
 276         * main.h (interpreter_p): Declare.
 277         * defs.h (interpreter_p): Don't declare.
 278
 279 2019-05-08  Tom Tromey  <tromey@adacore.com>
 280
 281         * dwarf2loc.c: Include dwarf2read.h.
 282         * defs.h (read_unsigned_leb128): Don't declare.
 283         * dwarf2read.h (read_unsigned_leb128): Declare.
 284
 285 2019-05-08  Tom Tromey  <tromey@adacore.com>
 286
 287         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 288         method.
 289
 290 2019-05-08  Tom Tromey  <tromey@adacore.com>
 291
 292         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 293         when no wrap column is set.
 294
 295 2019-05-08  Tom Tromey  <tromey@adacore.com>
 296
 297         * c-lang.c (c_get_string): Handle non-C-style arrays.
 298
 299 2019-05-08  Tom Tromey  <tromey@adacore.com>
 300
 301         * typeprint.c (print_offset_data::update): Print the bit offset,
 302         not the number of bits remaining.
 303
 304 2019-05-08  Tom Tromey  <tromey@adacore.com>
 305
 306         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 307         padding at end of comment.
 308
 309 2019-05-08  Tom Tromey  <tromey@adacore.com>
 310
 311         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 312         Compare main types.
 313
 314 2019-05-06  Tom Tromey  <tom@tromey.com>
 315
 316         * common/scoped_mmap.c: Include common-defs.h.
 317         * common/scoped_mmap.h: Don't include config.h.
 318
 319 2019-05-04  Tom Tromey  <tom@tromey.com>
 320
 321         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 322         (struct aarch64_call_info): Add initializers.
 323         <si>: Now a std::vector.
 324         (pass_on_stack, aarch64_push_dummy_call): Update.
 325
 326 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 327             Tom Tromey  <tom@tromey.com>
 328
 329         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 330         (ppc_threads): Now a std::vector.  Now static.
 331         (hwdebug_find_thread_points_by_tid)
 332         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 333         Update.
 334
 335 2019-05-04  Tom Tromey  <tom@tromey.com>
 336
 337         * arc-tdep.c (arc_tdesc_init): Return bool.
 338
 339 2019-05-04  Tom Tromey  <tom@tromey.com>
 340
 341         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 342         Use gdb_assert_not_reached.
 343
 344 2019-05-04  Tom Tromey  <tom@tromey.com>
 345
 346         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 347         "false".
 348
 349 2019-05-04  Tom Tromey  <tom@tromey.com>
 350
 351         * arc-tdep.c (arc_tdesc_init): Use bool.
 352
 353 2019-05-04  Tom Tromey  <tom@tromey.com>
 354
 355         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 356
 357 2019-05-04  Tom Tromey  <tom@tromey.com>
 358
 359         * cli/cli-cmds.c (valid_command_p): Return bool.
 360
 361 2019-05-04  Tom Tromey  <tom@tromey.com>
 362
 363         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 364         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 365
 366 2019-05-04  Raul Tambre  <raul@tambre.ee>
 367
 368         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 369         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 370         operator for comparison.
 371
 372 2019-05-04  Tom Tromey  <tom@tromey.com>
 373
 374         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 375         (lookup_partial_symbol, print_partial_symbols)
 376         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 377         (psymbol_compare): Update.
 378         (add_psymbol_to_bcache): Clear the entire psymbol.
 379         (maintenance_check_psymtabs): Update.
 380         * psympriv.h (struct partial_symbol): Don't derive from
 381         general_symbol_info.
 382         <obj_section, unrelocated_address, address,
 383         set_unrelocated_address>: Update.
 384         <ginfo>: New member.
 385         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 386         (debug_names::write_psymbols): Update.
 387
 388 2019-05-04  Tom de Vries  <tdevries@suse.de>
 389
 390         * contrib/cc-with-tweaks.sh: Support -n arg.
 391
 392 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 393
 394         * corelow.c (core_target::detach): Ensure frame cache and
 395         register caches are cleared.
 396         inferior.c (exit_inferior_1): Likewise.
 397
 398 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 399             Tom Tromey  <tom@tromey.com>
 400
 401         * dictionary.c (collate_pending_symbols_by_language): Remove
 402         "struct" from foreach.
 403         * symtab.c (lookup_global_symbol_from_objfile)
 404         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 405         foreach.
 406         * ser-tcp.c (net_open): Remove "struct" from foreach.
 407         * objfiles.c (objfile_relocate, objfile_rebase)
 408         (objfile_has_symbols): Remove "struct" from foreach.
 409         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 410         from foreach.
 411         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 412         foreach.
 413         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 414         "struct" from foreach.
 415         * ada-lang.c (create_excep_cond_exprs)
 416         (ada_exception_catchpoint_cond_string): Remove "struct" from
 417         foreach.
 418
 419 2019-05-03  Tom Tromey  <tromey@adacore.com>
 420
 421         * ada-exp.y (convert_char_literal): Check suffix of each
 422         enumerator.
 423
 424 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 425
 426         PR ada/21406:
 427         * ada-exp.y (yywrap): Don't define.
 428         * ada-lex.l (%option): Add noyywrap
 429         (yywrap): Remove.
 430
 431 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 432
 433         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 434         _WIN32_WINNT to the XP level, unless already defined to a higher
 435         level.
 436
 437         * unittests/parse-connection-spec-selftests.c:
 438         * ser-tcp.c:
 439         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 440         override.
 441
 442         * symfile.c (find_separate_debug_file): Remove colon from the
 443         drive spec of DOS/Windows file names of the target, so that the
 444         file name produced from DEBUGDIR and the target's directory will
 445         be valid on DOS/Windows systems.
 446
 447 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 448
 449         * rust-lang.c (val_print_struct): Handle printing structures
 450         containing strings.
 451
 452 2019-05-02  Tom Tromey  <tromey@adacore.com>
 453
 454         * valarith.c (_initialize_valarith): Remove.
 455
 456 2019-05-01  Tom Tromey  <tromey@adacore.com>
 457
 458         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 459         bitfields.
 460
 461 2019-05-01  Tom Tromey  <tromey@adacore.com>
 462
 463         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 464         for big-endian copies.
 465
 466 2019-04-30  Ali Tamur  <tamur@google.com>
 467         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 468         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 469         (read_3_bytes): New function.
 470
 471 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 472
 473         * windows-nat.c (main_thread_id): Delete.
 474         (handle_output_debug_string): Replace main_thread_id by
 475         current_event.dwThreadId.
 476         (fake_create_process): Likewise.
 477         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 478         Do not set main_thread_id.
 479         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 480         current_event.dwThreadId.
 481         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 482
 483 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 484
 485         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 486         Use current_event.dwThreadId instead of main_thread_id.
 487
 488 2019-04-30  Tom Tromey  <tromey@adacore.com>
 489
 490         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 491         (create_excep_cond_exprs): Iterate over program spaces.
 492         (ada_exception_catchpoint_cond_string): Examine all minimal
 493         symbols for exception types.
 494
 495 2019-04-30  Tom Tromey  <tromey@adacore.com>
 496
 497         PR c++/24470:
 498         * dwarf2read.c (process_structure_scope): Handle case where type
 499         has template parameters but no symbol was created.
 500
 501 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 502             Chris January  <chris.january@arm.com>
 503
 504         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 505         qualifier.
 506         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 507
 508 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         * f-typeprint.c (f_print_type): Update rules for printing
 511         whitespace.
 512         (f_type_print_varspec_suffix): Likewise.
 513
 514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 515             Chris January  <chris.january@arm.com>
 516
 517         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 518         function arguments.
 519
 520 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 521
 522         * f-lang.c (build_fortran_types): Change name of void type to
 523         lower case.
 524         * f-typeprint.c (f_type_print_base): Print the name of the void
 525         type, rather than a fixed string.
 526         * f-valprint.c (f_decorations): Use lower case void string.
 527
 528 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 529             Chris January  <chris.january@arm.com>
 530
 531         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 532         types for Fortran.
 533
 534 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 535             Chris January  <chris.january@arm.com>
 536             David Lecomber  <david.lecomber@arm.com>
 537
 538         * f-exp.y (BINOP_INTRINSIC): New token.
 539         (exp): New parser rule handling BINOP_INTRINSIC.
 540         (f77_keywords): Add new builtin procedures.
 541         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 542         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 543         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 544         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 545         (print_unop_subexp_f): New function.
 546         (print_binop_subexp_f): New function.
 547         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 548         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 549         (dump_subexp_body_f): Likewise.
 550         (operator_check_f): Likewise.
 551         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 552         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 553
 554 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 557         UNOP_KIND.
 558         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 559         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 560         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 561         (operator_length_f): New fuction.
 562         (print_subexp_f): New function.
 563         (op_name_f): New function.
 564         (dump_subexp_body_f): New function.
 565         (operator_check_f): New function.
 566         (exp_descriptor_f): Replace standard expression handling functions
 567         with new functions.
 568         * gdb/fortran-operator.def: New file.
 569         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 570         * gdb/std-operator.def: Remove UNOP_KIND.
 571
 572 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * std-operator.def: Remove unbalanced, stray double quote
 575         character.
 576
 577 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 578             Chris January  <chris.january@arm.com>
 579             Daniel Everett  <daniel.everett@arm.com>
 580             Nick Forrington  <nick.forrington@arm.com>
 581             Richard Bunt  <richard.bunt@arm.com>
 582
 583         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 584         of depth when printing anonymous structs or unions.
 585         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 586         Don't print either the top-level value, or the children if the
 587         max-depth is exceeded.
 588         (ppscm_print_children): When printing the key of a map, allow one
 589         extra level of depth.
 590         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 591         print either the top-level value, or the children if the max-depth
 592         is exceeded.
 593         (print_children): When printing the key of a map, allow one extra
 594         level of depth.
 595         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 596         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 597         (user_print_options): Initialise max_depth field.
 598         (val_print_scalar_or_string_type_p): New function.
 599         (val_print): Check to see if the max depth has been reached.
 600         (val_print_check_max_depth): Define new function.
 601         (show_print_max_depth): New function.
 602         (_initialize_valprint): Add 'print max-depth' option.
 603         * valprint.h (struct value_print_options) <max_depth>: New field.
 604         (val_print_check_max_depth): Declare new function.
 605         * NEWS: Document new feature.
 606
 607 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * ada-lang.c (ada_language_defn): Initialise new field.
 610         * c-lang.c (c_is_string_type_p): New function.
 611         (c_language_defn): Initialise new field.
 612         (cplus_language_defn): Initialise new field.
 613         (asm_language_defn): Initialise new field.
 614         (minimal_language_defn): Initialise new field.
 615         * c-lang.h (c_is_string_type_p): Declare new function.
 616         * d-lang.c (d_language_defn): Initialise new field.
 617         * f-lang.c (f_is_string_type_p): New function.
 618         (f_language_defn): Initialise new field.
 619         * go-lang.c (go_is_string_type_p): New function.
 620         (go_language_defn): Initialise new field.
 621         * language.c (default_is_string_type_p): New function.
 622         (unknown_language_defn): Initialise new field.
 623         (auto_language_defn): Initialise new field.
 624         * language.h (struct language_defn) <la_is_string_type_p>: New
 625         member variable.
 626         (default_is_string_type_p): Declare new function.
 627         * m2-lang.c (m2_language_defn): Initialise new field.
 628         * objc-lang.c (objc_language_defn): Initialise new field.
 629         * opencl-lang.c (opencl_language_defn): Initialise new field.
 630         * p-lang.c (pascal_is_string_type_p): New function.
 631         (pascal_language_defn): Initialise new field.
 632         * rust-lang.c (rust_is_string_type_p): New function.
 633         (rust_language_defn): Initialise new field.
 634
 635 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 636
 637         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 638         New field.
 639         * ada-lang.c (ada_language_defn): Initialise new field.
 640         * c-lang.c (c_language_defn): Likewise.
 641         (cplus_language_defn): Likewise.
 642         (asm_language_defn): Likewise.
 643         (minimal_language_defn): Likewise.
 644         * d-lang.c (d_language_defn): Likewise.
 645         * f-lang.c (f_language_defn): Likewise.
 646         * go-lang.c (go_language_defn): Likewise.
 647         * language.c (unknown_language_defn): Likewise.
 648         (auto_language_defn): Likewise.
 649         * m2-lang.c (m2_language_defn): Likewise.
 650         * objc-lang.c (objc_language_defn): Likewise.
 651         * opencl-lang.c (opencl_language_defn): Likewise.
 652         * p-lang.c (pascal_language_defn): Likewise.
 653         * rust-lang.c (rust_language_defn): Likewise.
 654
 655 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 656
 657         * ada-lang.c (ada_is_character_type): Change return type to bool.
 658         (ada_is_string_type): Likewise.
 659         * ada-lang.h (ada_is_character_type): Update declaration
 660         (ada_is_string_type): Likewise.
 661
 662 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 663
 664         Support style in 'frame|thread apply'
 665
 666         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 667         * record.c (record_start, record_stop): Update callers of
 668         execute_command_to_string with false.
 669         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 670         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 671         methods.
 672         (class string_file): New constructor with term_out parameter.
 673         Override methods term_out and can_emit_style_escape.  New member
 674         term_out.
 675         (class stdio_file): Override can_emit_style_escape.
 676         (class tee_file): Override term_out and can_emit_style_escape.
 677         * utils.h (can_emit_style_escape): Remove.
 678         * utils.c (can_emit_style_escape): Likewise.
 679         Update all callers of can_emit_style_escape (SOMESTREAM) to
 680         SOMESTREAM->can_emit_style_escape.
 681         * source-cache.c (source_cache::get_source_lines): Likewise.
 682         * stack.c (frame_apply_command_count): Call execute_command_to_string
 683         passing the term_out characteristic of the current gdb_stdout.
 684         * thread.c (thr_try_catch_cmd): Likewise.
 685         * top.c (execute_command_to_string): pass term_out parameter
 686         to construct the string_file for the command output.
 687         * ui-file.c (term_cli_styling): New function (most code moved
 688         from utils.c can_emit_style_escape).
 689         (string_file::string_file, string_file::can_emit_style_escape,
 690         stdio_file::can_emit_style_escape, tee_file::term_out,
 691         tee_file::can_emit_style_escape): New functions.
 692
 693 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 694
 695         * NEWS: Mention the new set|show may-call-functions.
 696         * infcall.c (may_call_functions_p): New variable.
 697         (show_may_call_functions_p): New function.
 698         (call_function_by_hand_dummy): Throws an error if not
 699         may-call-functions.
 700         (_initialize_infcall): Call add_setshow_boolean_cmd for
 701         may-call-functions.
 702
 703 2019-04-25  Keith Seitz  <keiths@redhat.com>
 704
 705         PR c++/24367
 706         * cp-support.c (inspect_type): Don't attempt substitutions
 707         of symbol with the same name.
 708
 709 2019-04-25  Tom Tromey  <tromey@adacore.com>
 710
 711         PR gdb/24475:
 712         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 713         static.
 714
 715 2019-04-25  Tom Tromey  <tromey@adacore.com>
 716
 717         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 718         rvalue reference.
 719         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 720         (gdb_xml_parser::parse): Use std::move.
 721         * python/python-internal.h (gdbpy_convert_exception): Take a const
 722         reference.
 723         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 724         std::move.
 725         * python/py-utils.c (gdbpy_convert_exception): Take a const
 726         reference.
 727         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 728         Use std::move.
 729         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 730         Use std::move.
 731         * mi/mi-main.c (mi_print_exception): Take a const reference.
 732         * main.c (handle_command_errors): Take a const reference.
 733         * linespec.c (parse_linespec): Use std::move.
 734         * infcall.c (run_inferior_call): Use std::move.
 735         (call_function_by_hand_dummy): Use std::move.
 736         * exec.c (try_open_exec_file): Use std::move.
 737         * exceptions.h (exception_print, exception_fprintf)
 738         (exception_print_same): Update.
 739         * exceptions.c (print_exception, exception_print)
 740         (exception_fprintf, exception_print_same): Change parameters to
 741         const reference.
 742         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 743         * common/new-op.c: Use std::move.
 744         * common/common-exceptions.h (struct gdb_exception): Add move
 745         constructor.
 746         (struct gdb_exception_error, struct gdb_exception_quit, struct
 747         gdb_quit_bad_alloc): Change constructor to move constructor.
 748         (throw_exception): Change parameter to rvalue reference.
 749         * common/common-exceptions.c (throw_exception): Take rvalue
 750         reference.
 751         * cli/cli-interp.c (safe_execute_command): Use std::move.
 752         * breakpoint.c (insert_bp_location, location_to_sals): Use
 753         std::move.
 754
 755 2019-04-25  Tom Tromey  <tromey@adacore.com>
 756
 757         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 758         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 759         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 760         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 761         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 762         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 763         guile/scm-value.c: Use unpack.
 764         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 765         gdbscm_gdb_exception.
 766         (gdbscm_throw_gdb_exception): Likewise.
 767         (struct gdbscm_gdb_exception): New.
 768         (unpack): New function.
 769         (gdbscm_wrap): Use unpack.
 770
 771 2019-04-25  Tom Tromey  <tromey@adacore.com>
 772
 773         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 774         (gdb_rl_callback_handler): Use std::move.
 775         * common/common-exceptions.h (struct gdb_exception): Add move
 776         assignment operator.
 777         (throw_exception_sjlj): Change "exception" to const reference.
 778         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 779         (throw_exception_sjlj): Change "exception" to const reference.
 780
 781 2019-04-25  Tom Tromey  <tromey@adacore.com>
 782
 783         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 784         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 785         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 786         Update.
 787         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 788         Update.
 789         * mi/mi-interp.c (mi_interp::exec): Update.
 790         * linespec.c (parse_linespec): Update.
 791         * infcall.c (run_inferior_call): Update.
 792         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 793         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 794         (gdbscm_lookup_global_symbol): Update.
 795         * guile/scm-param.c (gdbscm_parameter_value): Update.
 796         * guile/scm-frame.c (gdbscm_frame_read_register)
 797         (gdbscm_frame_read_var): Update.
 798         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 799         * exec.c (try_open_exec_file): Update.
 800         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 801         (gdb_rl_callback_handler): Update.
 802         * common/common-exceptions.h (exception_none): Don't declare.
 803         * common/common-exceptions.c (exception_none): Don't define.
 804         (struct catcher) <exception>: Update.
 805         * cli/cli-interp.c (safe_execute_command): Update.
 806         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 807
 808 2019-04-25  Ali Tamur  <tamur@google.com>
 809
 810         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 811         (read_attribute_value): Likewise.
 812         (dwarf2_read_addr_index): Update comment.
 813         (read_str_index): Add DW_FORM_strx.
 814         (dwarf2_string_attr): Likewise.
 815         (dwarf2_const_value_attr): Likewise.
 816         (dump_die_shallow): Likewise.
 817         (dwarf2_fetch_constant_bytes): Likewise.
 818         (skip_form_bytes): Likewise.
 819         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 820
 821 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 822
 823         PR corefiles/11608
 824         PR corefiles/18187
 825         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 826         OFFSET.  Verify if current mapping contains an ELF header.
 827         (linux_find_memory_regions_full): Adjust call to
 828         dump_mapping_p.
 829
 830 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 831             Kang Li <kanglictf@gmail.com>
 832
 833         PR gdb/21600
 834
 835         * dwarf2-frame.c (read_initial_length): Be consistent about using
 836         unsigned representation of length.
 837         (decode_frame_entry_1): Likewise.  Check for wraparound of
 838         end pointer as well as buffer overflow.
 839
 840 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 841
 842         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 843         "vq".
 844
 845 2019-04-24  Tom Tromey  <tromey@adacore.com>
 846
 847         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 848
 849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * s12z-tdep.c (s12z_unwind_pc): Delete.
 852         (s12z_unwind_sp): Delete.
 853         (s12z_gdbarch_init): Don't register deleted functions with
 854         gdbarch.
 855
 856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 857
 858         * rl78-tdep.c (rl78_unwind_sp): Delete.
 859         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 860
 861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 862
 863         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 864         (xstormy16_unwind_pc): Delete.
 865         (xstormy16_dummy_id): Delete.
 866         (xstormy16_gdbarch_init): Don't register deleted functions with
 867         gdbarch.
 868
 869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         * vax-tdep.c (vax_unwind_pc): Delete.
 872         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 873
 874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * v850-tdep.c (v850_unwind_sp): Delete.
 877         (v850_unwind_pc): Delete.
 878         (v850_dummy_id): Delete.
 879         (v850_gdbarch_init): Don't register deleted functions with
 880         gdbarch.
 881
 882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 885         (tilegx_unwind_pc): Delete.
 886         (tilegx_unwind_dummy_id): Delete.
 887         (tilegx_gdbarch_init): Don't register deleted functions with
 888         gdbarch.
 889
 890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 893         (tic6x_dummy_id): Delete.
 894         (tic6x_gdbarch_init): Don't register deleted functions with
 895         gdbarch.
 896
 897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 898
 899         * sparc-tdep.c (sparc_unwind_pc): Delete.
 900         (sparc32_gdbarch_init): Don't register deleted function with
 901         gdbarch.
 902
 903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 904
 905         * sh-tdep.c (sh_unwind_sp): Delete.
 906         (sh_unwind_pc): Delete.
 907         (sh_dummy_id): Delete.
 908         (sh_gdbarch_init): Don't register deleted functions with
 909         gdbarch.
 910
 911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 912
 913         * score-tdep.c (score_unwind_sp): Delete.
 914         (score_unwind_pc): Delete.
 915         (score_dummy_id): Delete.
 916         (score_gdbarch_init): Don't register deleted functions with
 917         gdbarch.
 918
 919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 920
 921         * rx-tdep.c (rx_unwind_pc): Delete.
 922         (rx_unwind_sp): Delete.
 923         (rx_dummy_id): Delete.
 924         (rx_gdbarch_init): Don't register deleted functions with
 925         gdbarch.  Update comment.
 926
 927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 930         (rs6000_dummy_id): Delete.
 931         (rs6000_gdbarch_init): Don't register deleted functions with
 932         gdbarch.
 933
 934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * or1k-tdep.c (or1k_dummy_id): Delete.
 937         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 938
 939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * nios2-tdep.c (nios2_dummy_id): Delete.
 942         (nios2_unwind_sp): Delete.
 943         (nios2_gdbarch_init): Don't register deleted functions with
 944         gdbarch.
 945
 946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 947
 948         * nds32-tdep.c (nds32_dummy_id): Delete.
 949         (nds32_unwind_pc): Delete.
 950         (nds32_unwind_sp): Delete.
 951         (nds32_gdbarch_init): Don't register deleted functions with
 952         gdbarch.
 953
 954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * msp430-tdep.c (msp430_unwind_pc): Delete.
 957         (msp430_unwind_sp): Delete.
 958         (msp430_dummy_id): Delete.
 959         (msp430_gdbarch_init): Don't register deleted functions with
 960         gdbarch.
 961
 962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * moxie-tdep.c (moxie_unwind_sp): Delete.
 965         (moxie_unwind_pc): Delete.
 966         (moxie_dummy_id): Delete.
 967         (moxie_gdbarch_init): Don't register deleted functions with
 968         gdbarch.
 969
 970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 973         (mn10300_unwind_pc): Delete.
 974         (mn10300_unwind_sp): Delete.
 975         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 976         mn10300_unwind_sp.
 977         (mn10300_frame_unwind_init): Don't register deleted functions with
 978         gdbarch.
 979
 980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * mep-tdep.c (mep_unwind_pc): Delete.
 983         (mep_unwind_sp): Delete.
 984         (mep_dummy_id): Delete.
 985         (mep_gdbarch_init): Don't register deleted functions with
 986         gdbarch.
 987
 988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 991         (m68hc11_unwind_sp): Delete.
 992         (m68hc11_gdbarch_init): Don't register deleted functions with
 993         gdbarch.
 994
 995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 996
 997         * m32r-tdep.c (m32r_unwind_sp): Delete.
 998         (m32r_unwind_pc): Delete.
 999         (m32r_dummy_id): Delete.
1000         (m32r_gdbarch_init): Don't register deleted functions with
1001         gdbarch.
1002
1003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * m32c-tdep.c (m32c_unwind_pc): Delete.
1006         (m32c_unwind_sp): Delete.
1007         (m32c_dummy_id): Delete.
1008         (m32c_gdbarch_init): Don't register deleted functions with
1009         gdbarch.
1010
1011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1012
1013         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1014         (lm32_unwind_pc): Delete.
1015         (lm32_dummy_id): Delete.
1016         (lm32_gdbarch_init): Don't register deleted functions with
1017         gdbarch.
1018
1019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1020
1021         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1022         (iq2000_unwind_pc): Delete.
1023         (iq2000_dummy_id): Delete.
1024         (iq2000_gdbarch_init): Don't register deleted functions with
1025         gdbarch.
1026
1027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1028
1029         * nds32-tdep.c (nds32_type_align): Delete.
1030         (nds32_push_dummy_call): Use type_align instead.
1031
1032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1033
1034         * arm-tdep.c (arm_type_align): Only handle vector override case.
1035         (arm_push_dummy_call): Use type_align.
1036         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1037
1038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1041         case.
1042         (pass_on_stack): Use type_align.
1043         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1044         function.
1045
1046 2019-04-23  Tom Tromey  <tromey@adacore.com>
1047
1048         * dwarf2read.c (line_header::file_name_at): Remove unused
1049         overload.
1050
1051 2019-04-23  Tom de Vries  <tdevries@suse.de>
1052
1053         PR gdb/24438
1054         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1055         invocation.
1056
1057
1058 2019-03-27  Ali Tamur  <tamur@google.com>
1059
1060         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1061         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1062         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1063         (dwarf_expr_context::get_addr_index): Likewise
1064         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1065         (symbol_needs_eval_context::get_addr_index): Likewise
1066         (disassemble_dwarf_expression): Add DW_OP_addrx
1067         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1068         (read_cutu_die_from_dwo): Update comment
1069         (skip_one_die): Add DW_FORM_addrx
1070         (read_attribute_value): Likewise
1071         (var_decode_location): Add DW_OP_addrx
1072         (dwarf2_const_value_attr): Add DW_FORM_addrx
1073         (dump_die_shallow): Likewise
1074         (dwarf2_fetch_constant_bytes): Likewise
1075         (decode_locdesc): Add DW_OP_addrx
1076         (skip_form_bytes): Add DW_FORM_addrx
1077
1078 2019-04-22  Ali Tamur  <tamur@google.com>
1079
1080         * MAINTAINERS (Write After Approval): Add self.
1081
1082 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1083
1084         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1085         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1086         (open_symbol_file_object): Likewise.
1087         (svr4_default_sos): Add info parameter.
1088         (svr4_read_so_list): Likewise.
1089         (svr4_current_sos_direct): Adjust functions calls to pass down
1090         info.
1091         (svr4_current_sos_1): Add info parameter.
1092         (svr4_current_sos): Call get_svr4_info, pass info down to
1093         svr4_current_sos_1.
1094         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1095         get_svr4_info.
1096         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1097         get_svr4_info.
1098         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1099         to get_svr4_info.
1100         (probes_table_remove_objfile_probes): Likewise.
1101         (register_solib_event_probe): Add info parameter.
1102         (solist_update_incremental): Pass info parameter down to
1103         svr4_read_so_list.
1104         (disable_probes_interface): Add info parameter.
1105         (svr4_handle_solib_event): Pass current_program_space to
1106         get_svr4_info.  Adjust disable_probes_interface cleanup.
1107         (svr4_create_probe_breakpoints): Add info parameter, pass it
1108         down to register_solib_event_probe.
1109         (svr4_create_solib_event_breakpoints): Add info parameter,
1110         pass it down to svr4_create_probe_breakpoints.
1111         (enable_break): Pass info down to
1112         svr4_create_solib_event_breakpoints.
1113         (svr4_solib_create_inferior_hook): Pass current_program_space to
1114         get_svr4_info.
1115         (svr4_clear_solib): Likewise.
1116
1117 2019-04-22  Pedro Alves  <palves@redhat.com>
1118
1119         * solib-svr4.c (svr4_free_objfile_observer): New.
1120         (probe_and_action::objfile): New field.
1121         (probes_table_htab_remove_objfile_probes)
1122         (probes_table_remove_objfile_probes): New functions.
1123         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1124         in the new probe_and_action.  Don't store the probe in 'lookup'.
1125         (svr4_create_probe_breakpoints): Pass objfile to
1126         register_solib_event_probe.
1127         (_initialize_svr4_solib): Register a free_objfile observer.
1128
1129 2019-04-19  Tom Tromey  <tom@tromey.com>
1130
1131         * common/queue.h: Remove.
1132
1133 2019-04-19  Tom Tromey  <tom@tromey.com>
1134
1135         * event-loop.c: Don't include "common/queue.h".
1136
1137 2019-04-19  Tom Tromey  <tom@tromey.com>
1138
1139         * remote.c (remote_target): Use delete.
1140         * remote-notif.h: Include <list>, not "common/queue.h".
1141         (notif_client_p): Remove typedef.
1142         (remote_notif_state): Add constructor, destructor, initializer.
1143         <notif_queue>: Now a std::list.
1144         (remote_notif_state_xfree): Don't declare.
1145         * remote-notif.c (remote_notif_process, handle_notification)
1146         (remote_notif_state_allocate): Update.
1147         (~remote_notif_state): Rename from remote_notif_state_xfree.
1148
1149 2019-04-19  Tom Tromey  <tom@tromey.com>
1150
1151         * symfile.c (reread_symbols): Update.
1152         * objfiles.c (objfile_register_static_link)
1153         (objfile_lookup_static_link): Update
1154         (~objfile) Don't delete static_links.
1155         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1156
1157 2019-04-19  Tom Tromey  <tom@tromey.com>
1158
1159         * type-stack.h (struct type_stack) <insert>: Constify string.
1160         * type-stack.c (type_stack::insert): Constify string.
1161         * gdbtypes.h (lookup_template_type): Update.
1162         (address_space_name_to_int): Update.
1163         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1164         const.
1165         (lookup_template_type): Make name const.
1166         * c-exp.y: Update rules.
1167         (lex_one_token, classify_name, classify_inner_name)
1168         (c_print_token): Update.
1169         * p-exp.y: Update rules.
1170         (yylex): Update.
1171         * f-exp.y: Update rules.
1172         (yylex): Update.
1173         * d-exp.y: Update rules.
1174         (lex_one_token, classify_name, classify_inner_name): Update.
1175         * parse.c (write_dollar_variable, copy_name): Return std::string.
1176         * parser-defs.h (copy_name): Change return type.
1177         * m2-exp.y: Update rules.
1178         (yylex): Update.
1179         * go-exp.y (lex_one_token): Update.
1180         Update rules.
1181         (classify_unsafe_function, classify_packaged_name)
1182         (classify_name, yylex): Update.
1183
1184 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1185
1186         * configure.ac: add --enable-source-highlight switch.
1187         * configure: Regenerate.
1188         * top.c (print_gdb_version): plumb --enable-source-highlight
1189         status to "show configuration".
1190
1191 2019-04-19  Tom Tromey  <tromey@adacore.com>
1192
1193         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1194         Check ADA_TYPE_P.
1195         (empty_record, ada_template_to_fixed_record_type_1)
1196         (template_to_static_fixed_type)
1197         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1198         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1199         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1200         macros.
1201
1202 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1203
1204         PR symtab/24423:
1205         * source.c (print_source_lines_base): Advance "iter" when a
1206         control character is seen.
1207
1208 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1209
1210         * inferior.h (struct infcall_suspend_state_deleter):
1211         Catch exception in destructor to avoid crash.
1212
1213 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1214
1215         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1216         close to the add_com "shell".
1217
1218 2019-04-18  Tom Tromey  <tromey@adacore.com>
1219
1220         * process-stratum-target.h (class process_stratum_target)
1221         <stratum>: Add "final".
1222
1223 2019-04-17  Tom Tromey  <tromey@adacore.com>
1224
1225         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1226         against nullptr before use.
1227
1228 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1229
1230         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1231
1232 2019-04-17  Jim Wilson  <jimw@sifive.com>
1233             Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1236         code read might fail, assume 4-byte breakpoint in that case.
1237
1238 2019-04-15  Leszek Swirski  <leszeks@google.com>
1239
1240         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1241         rather than a hand-rolled POD check when checking for forced MEMORY
1242         classification.
1243
1244 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1245
1246         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1247         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1248         function.
1249         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1250         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1251         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1252         declaration.
1253
1254 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1255
1256         * aarch64-linux-nat.c
1257         (aarch64_linux_nat_target::thread_architecture): Add override.
1258         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1259         each VQ.
1260
1261 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1262
1263         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1264
1265 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1266
1267         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1268         target types of size 96-bits, add some additional comments, and
1269         check that the builtin type we found was the correct size.
1270
1271 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1272
1273         * utils.c (prompt_for_continue): Don't restore the styling at the
1274         end, as applied_style has the wrong value.  This fixes styling in
1275         long lists of file names that are interrupted by the "Continue?"
1276         prompt.
1277
1278 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1281         * c-lang.c (c_language_defn): Likewise.
1282         (cplus_language_defn): Likewise.
1283         (asm_language_defn): Likewise.
1284         (minimal_language_defn): Likewise.
1285         * d-lang.c (d_language_defn): Likewise.
1286         * f-lang.c (f_language_defn): Likewise.
1287         * go-lang.c (go_language_defn): Likewise.
1288         * language.c (unknown_language_defn): Likewise.
1289         (auto_language_defn): Likewise.
1290         * language.h (struct language_defn): Remove la_magic field.
1291         (LANG_MAGIC): Delete.
1292         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1293         * objc-lang.c (objc_language_defn): Likewise.
1294         * opencl-lang.c (opencl_language_defn): Likewise.
1295         * p-lang.c (pascal_language_defn): Likewise.
1296         * rust-lang.c (rust_language_defn): Likewise.
1297
1298 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * riscv-tdep.c (riscv_type_align): New function.
1301         (riscv_type_alignment): Delete.
1302         (riscv_arg_location): Use 'type_align'.
1303         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1304
1305 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * gdbtypes.c (type_align): A struct with no non-static fields also
1308         has alignment of 1.
1309
1310 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1313         component to 0.
1314         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1315         member.
1316         (riscv_struct_info::analyse): New implementation using new
1317         analyse_inner member function.
1318         (riscv_struct_info::field_offset): New member function.
1319         (riscv_struct_info::m_offsets): New member variable.
1320         (riscv_struct_info::analyse_inner): New private member function,
1321         takes the old implementation of riscv_struct_info::analyse but
1322         extended to track field offsets.
1323         (riscv_call_arg_struct): Update the struct folding special cases
1324         to handle cases where empty C++ structs, which are non-zero
1325         length, are found.
1326         (riscv_arg_location): Initialise the length of each location, a
1327         non-zero length now indicates the location is in use.
1328         (riscv_push_dummy_call): Allow for the first location having a
1329         non-zero offset when setting up arguments.
1330         (riscv_return_value): Likewise, but for return values.
1331
1332 2019-04-11  Tom Tromey  <tromey@adacore.com>
1333
1334         * utils.c (internal_vproblem): Make "msg" const.
1335
1336 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1337
1338         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1339         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1340         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1341         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1342
1343 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1344
1345         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1346         function.
1347         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1348         of amd64_collect_native_gregset.
1349         (amd64_linux_nat_target::store_registers): Likewise.
1350
1351 2019-04-10  Tom Tromey  <tom@tromey.com>
1352
1353         * symtab.c (lookup_global_symbol_from_objfile)
1354         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1355         * objfiles.h (class separate_debug_iterator): New.
1356         (class separate_debug_range): New.
1357         (struct objfile) <separate_debug_objfiles>: New method.
1358         (objfile_separate_debug_iterate): Don't declare.
1359         * objfiles.c (separate_debug_iterator::operator++): Rename from
1360         objfile_separate_debug_iterate.
1361         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1362         iterator.
1363         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1364         iterator.
1365
1366 2019-04-10  Tom Tromey  <tom@tromey.com>
1367
1368         * symfile.c (reread_symbols): Remove old comment.
1369         * objfiles.c (free_all_objfiles): Fix a typo.
1370
1371 2019-04-10  Tom Tromey  <tom@tromey.com>
1372
1373         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1374         * minsyms.c (lookup_minimal_symbol): Use foreach.
1375         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1376         (lookup_minimal_symbol_solib_trampoline): Likewise.
1377         * symfile.c (reread_symbols): Use foreach.
1378
1379 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1380             Tom Tromey  <tromey@adacore.com>
1381
1382         PR rust/24414:
1383         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1384         (rust_lex_int_test): Change "value" to be LONGEST.
1385         (rust_lex_tests): Add test for long integer literal.
1386
1387 2019-04-09  Tom Tromey  <tromey@adacore.com>
1388
1389         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1390         to bool.
1391         (extended_remote_target::attach): Update.
1392         (remote_target::remote_notice_new_inferior): Update.
1393         (remote_target::add_current_inferior_and_thread): Update.
1394         * inferior.c (exit_inferior_1): Use "false".
1395         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1396
1397 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1398
1399         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1400         the "start" command.
1401
1402 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1403
1404         * python/py-inferior.c (infpy_thread_from_thread_handle):
1405         Adjust comments to reflect renaming of thread_from_thread_handle
1406         to thread_from_handle.  Adjust keywords.  Fix type error message.
1407         (inferior_object_methods): Add thread_from_handle.  Retain
1408         thread_from_thread_handle, but mark it as deprecated.
1409
1410 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1411
1412         * gdbthread.h (find_thread_by_handle): Revise declaration.
1413         * thread.c (find_thread_by_handle): Likewise.  Adjust
1414         implementation too.
1415         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1416         support for buffer objects as handles.
1417
1418 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1419
1420         * python/py-infthread.c (thpy_thread_handle): New function.
1421         (thread_object_methods): Register thpy_thread_handle.
1422
1423 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1424
1425         * gdbthread.h (thread_to_thread_handle): Declare.
1426         * thread.c (gdbtypes.h): Include.
1427         (thread_to_thread_handle): New function.
1428
1429         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1430         (target_thread_info_to_thread_handle): Declare.
1431         * target.c (target_thread_info_to_thread_handle): New function.
1432         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1433         * target-delegates.c: Regenerate.
1434
1435         * linux-thread-db.c (class thread_db_target): Add method
1436         thread_info_to_thread_handle.
1437         (thread_db_target::thread_info_to_thread_handle): Define.
1438         * remote.c (class remote_target): Add new method
1439         thread_info_to_thread_handle.
1440         (remote_target::thread_info_to_thread_handle): Define.
1441
1442 2019-04-08  Pedro Alves  <palves@redhat.com>
1443
1444         * common/common-exceptions.c (throw_exception): Don't create
1445         named object to throw; throw directly.
1446         (throw_it): Likewise.  Don't initialize gdb_exception::message
1447         here, with new; pass FMT and AP to the ctor instead.
1448         * common/common-exceptions.h: Include <string>.
1449         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1450         const char *, va_list)): New ctor.  Use std::make_shared.
1451         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1452         errors)): Delete.
1453         (gdb_exception_error::gdb_exception_error(enum errors, const char
1454         *, va_list)): New.
1455         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1456         Add assertion.
1457         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1458         errors)): Delete.
1459         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1460         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1461         Add assertion.
1462
1463 2019-04-08  Tom Tromey  <tom@tromey.com>
1464
1465         * valops.c (value_rtti_indirect_type): Replace throw_exception
1466         with throw.
1467         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1468         with throw.
1469         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1470         throw.
1471         * target.c (target_translate_tls_address): Replace throw_exception
1472         with throw.
1473         * stack.c (frame_apply_command_count): Replace throw_exception
1474         with throw.
1475         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1476         throw.
1477         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1478         with throw.
1479         * rs6000-tdep.c (rs6000_frame_cache)
1480         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1481         * remote.c: Replace throw_exception with throw.
1482         * record-full.c (record_full_message, record_full_wait_1)
1483         (record_full_restore): Replace throw_exception with throw.
1484         * record-btrace.c:
1485         (get_thread_current_frame_id, record_btrace_start_replaying)
1486         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1487         (cmd_record_btrace_start): Replace throw_exception with throw.
1488         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1489         throw.
1490         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1491         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1492         * linespec.c:
1493         (find_linespec_symbols): Replace throw_exception with throw.
1494         * infrun.c (displaced_step_prepare, resume): Replace
1495         throw_exception with throw.
1496         * infcmd.c (post_create_inferior): Replace throw_exception with
1497         throw.
1498         * inf-loop.c (inferior_event_handler): Replace throw_exception
1499         with throw.
1500         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1501         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1502         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1503         (get_prev_frame_always, get_frame_pc_if_available)
1504         (get_frame_address_in_block_if_available, get_frame_language):
1505         Replace throw_exception with throw.
1506         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1507         throw_exception with throw.
1508         * eval.c (fetch_subexp_value, evaluate_var_value)
1509         (evaluate_funcall, evaluate_subexp_standard): Replace
1510         throw_exception with throw.
1511         * dwarf2loc.c (call_site_find_chain)
1512         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1513         Replace throw_exception with throw.
1514         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1515         with throw.
1516         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1517         throw.
1518         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1519         * completer.c (complete_line_internal): Replace throw_exception
1520         with throw.
1521         * compile/compile-object-run.c (compile_object_run): Replace
1522         throw_exception with throw.
1523         * cli/cli-script.c (process_next_line): Replace throw_exception
1524         with throw.
1525         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1526         (btrace_enable, btrace_maint_update_pt_packets): Replace
1527         throw_exception with throw.
1528         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1529         throw_exception with throw.
1530         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1531         throw_exception with throw.
1532         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1533         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1534         * aarch64-tdep.c (aarch64_make_prologue_cache)
1535         (aarch64_make_stub_cache): Replace throw_exception with throw.
1536
1537 2019-04-08  Tom Tromey  <tom@tromey.com>
1538
1539         * common/common-exceptions.c (throw_exception): Rename from
1540         throw_exception_cxx.  Remove old copy.  Make argument const.
1541         (throw_it): Create and throw exception objects directly.
1542         * common/common-exceptions.h (throw_exception): Make argument
1543         const.
1544         (struct gdb_exception_error): Add constructor.
1545         (struct gdb_exception_quit): Add constructor.
1546
1547 2019-04-08  Tom Tromey  <tom@tromey.com>
1548
1549         * common/common-exceptions.h (exception_rethrow): Don't declare.
1550         (TRY_SJLJ): Update comment.
1551         (TRY, CATCH, END_CATCH): Remove.
1552         * common/common-exceptions.c (exception_rethrow): Remove.
1553
1554 2019-04-08  Tom Tromey  <tom@tromey.com>
1555
1556         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1557         Remove.
1558         (gdb_exception_error): Rename from
1559         gdb_exception_RETURN_MASK_ERROR.
1560         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1561         (gdb_quit_bad_alloc): Update.
1562         * aarch64-tdep.c: Update.
1563         * ada-lang.c: Update.
1564         * ada-typeprint.c: Update.
1565         * ada-valprint.c: Update.
1566         * amd64-tdep.c: Update.
1567         * arch-utils.c: Update.
1568         * break-catch-throw.c: Update.
1569         * breakpoint.c: Update.
1570         * btrace.c: Update.
1571         * c-varobj.c: Update.
1572         * cli/cli-cmds.c: Update.
1573         * cli/cli-interp.c: Update.
1574         * cli/cli-script.c: Update.
1575         * common/common-exceptions.c: Update.
1576         * common/new-op.c: Update.
1577         * common/selftest.c: Update.
1578         * compile/compile-c-symbols.c: Update.
1579         * compile/compile-cplus-symbols.c: Update.
1580         * compile/compile-object-load.c: Update.
1581         * compile/compile-object-run.c: Update.
1582         * completer.c: Update.
1583         * corelow.c: Update.
1584         * cp-abi.c: Update.
1585         * cp-support.c: Update.
1586         * cp-valprint.c: Update.
1587         * darwin-nat.c: Update.
1588         * disasm-selftests.c: Update.
1589         * dtrace-probe.c: Update.
1590         * dwarf-index-cache.c: Update.
1591         * dwarf-index-write.c: Update.
1592         * dwarf2-frame-tailcall.c: Update.
1593         * dwarf2-frame.c: Update.
1594         * dwarf2loc.c: Update.
1595         * dwarf2read.c: Update.
1596         * eval.c: Update.
1597         * event-loop.c: Update.
1598         * event-top.c: Update.
1599         * exec.c: Update.
1600         * f-valprint.c: Update.
1601         * fbsd-tdep.c: Update.
1602         * frame-unwind.c: Update.
1603         * frame.c: Update.
1604         * gdbtypes.c: Update.
1605         * gnu-v3-abi.c: Update.
1606         * guile/guile-internal.h: Update.
1607         * guile/scm-block.c: Update.
1608         * guile/scm-breakpoint.c: Update.
1609         * guile/scm-cmd.c: Update.
1610         * guile/scm-disasm.c: Update.
1611         * guile/scm-frame.c: Update.
1612         * guile/scm-lazy-string.c: Update.
1613         * guile/scm-math.c: Update.
1614         * guile/scm-param.c: Update.
1615         * guile/scm-ports.c: Update.
1616         * guile/scm-pretty-print.c: Update.
1617         * guile/scm-symbol.c: Update.
1618         * guile/scm-symtab.c: Update.
1619         * guile/scm-type.c: Update.
1620         * guile/scm-value.c: Update.
1621         * i386-linux-tdep.c: Update.
1622         * i386-tdep.c: Update.
1623         * inf-loop.c: Update.
1624         * infcall.c: Update.
1625         * infcmd.c: Update.
1626         * infrun.c: Update.
1627         * jit.c: Update.
1628         * language.c: Update.
1629         * linespec.c: Update.
1630         * linux-fork.c: Update.
1631         * linux-nat.c: Update.
1632         * linux-tdep.c: Update.
1633         * linux-thread-db.c: Update.
1634         * main.c: Update.
1635         * mi/mi-cmd-break.c: Update.
1636         * mi/mi-cmd-stack.c: Update.
1637         * mi/mi-interp.c: Update.
1638         * mi/mi-main.c: Update.
1639         * objc-lang.c: Update.
1640         * p-valprint.c: Update.
1641         * parse.c: Update.
1642         * ppc-linux-tdep.c: Update.
1643         * printcmd.c: Update.
1644         * python/py-arch.c: Update.
1645         * python/py-breakpoint.c: Update.
1646         * python/py-cmd.c: Update.
1647         * python/py-finishbreakpoint.c: Update.
1648         * python/py-frame.c: Update.
1649         * python/py-framefilter.c: Update.
1650         * python/py-gdb-readline.c: Update.
1651         * python/py-inferior.c: Update.
1652         * python/py-infthread.c: Update.
1653         * python/py-lazy-string.c: Update.
1654         * python/py-linetable.c: Update.
1655         * python/py-objfile.c: Update.
1656         * python/py-param.c: Update.
1657         * python/py-prettyprint.c: Update.
1658         * python/py-progspace.c: Update.
1659         * python/py-record-btrace.c: Update.
1660         * python/py-record.c: Update.
1661         * python/py-symbol.c: Update.
1662         * python/py-type.c: Update.
1663         * python/py-unwind.c: Update.
1664         * python/py-utils.c: Update.
1665         * python/py-value.c: Update.
1666         * python/python.c: Update.
1667         * record-btrace.c: Update.
1668         * record-full.c: Update.
1669         * remote-fileio.c: Update.
1670         * remote.c: Update.
1671         * riscv-tdep.c: Update.
1672         * rs6000-aix-tdep.c: Update.
1673         * rs6000-tdep.c: Update.
1674         * rust-exp.y: Update.
1675         * rust-lang.c: Update.
1676         * s390-tdep.c: Update.
1677         * selftest-arch.c: Update.
1678         * solib-dsbt.c: Update.
1679         * solib-frv.c: Update.
1680         * solib-spu.c: Update.
1681         * solib-svr4.c: Update.
1682         * solib.c: Update.
1683         * sparc64-linux-tdep.c: Update.
1684         * stack.c: Update.
1685         * symfile-mem.c: Update.
1686         * symmisc.c: Update.
1687         * target.c: Update.
1688         * thread.c: Update.
1689         * top.c: Update.
1690         * tracefile-tfile.c: Update.
1691         * tui/tui.c: Update.
1692         * typeprint.c: Update.
1693         * unittests/cli-utils-selftests.c: Update.
1694         * unittests/parse-connection-spec-selftests.c: Update.
1695         * valops.c: Update.
1696         * valprint.c: Update.
1697         * value.c: Update.
1698         * varobj.c: Update.
1699         * windows-nat.c: Update.
1700         * x86-linux-nat.c: Update.
1701         * xml-support.c: Update.
1702
1703 2019-04-08  Tom Tromey  <tom@tromey.com>
1704
1705         * xml-support.c: Use C++ exception handling.
1706         * x86-linux-nat.c: Use C++ exception handling.
1707         * windows-nat.c: Use C++ exception handling.
1708         * varobj.c: Use C++ exception handling.
1709         * value.c: Use C++ exception handling.
1710         * valprint.c: Use C++ exception handling.
1711         * valops.c: Use C++ exception handling.
1712         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1713         handling.
1714         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1715         * typeprint.c: Use C++ exception handling.
1716         * tui/tui.c: Use C++ exception handling.
1717         * tracefile-tfile.c: Use C++ exception handling.
1718         * top.c: Use C++ exception handling.
1719         * thread.c: Use C++ exception handling.
1720         * target.c: Use C++ exception handling.
1721         * symmisc.c: Use C++ exception handling.
1722         * symfile-mem.c: Use C++ exception handling.
1723         * stack.c: Use C++ exception handling.
1724         * sparc64-linux-tdep.c: Use C++ exception handling.
1725         * solib.c: Use C++ exception handling.
1726         * solib-svr4.c: Use C++ exception handling.
1727         * solib-spu.c: Use C++ exception handling.
1728         * solib-frv.c: Use C++ exception handling.
1729         * solib-dsbt.c: Use C++ exception handling.
1730         * selftest-arch.c: Use C++ exception handling.
1731         * s390-tdep.c: Use C++ exception handling.
1732         * rust-lang.c: Use C++ exception handling.
1733         * rust-exp.y: Use C++ exception handling.
1734         * rs6000-tdep.c: Use C++ exception handling.
1735         * rs6000-aix-tdep.c: Use C++ exception handling.
1736         * riscv-tdep.c: Use C++ exception handling.
1737         * remote.c: Use C++ exception handling.
1738         * remote-fileio.c: Use C++ exception handling.
1739         * record-full.c: Use C++ exception handling.
1740         * record-btrace.c: Use C++ exception handling.
1741         * python/python.c: Use C++ exception handling.
1742         * python/py-value.c: Use C++ exception handling.
1743         * python/py-utils.c: Use C++ exception handling.
1744         * python/py-unwind.c: Use C++ exception handling.
1745         * python/py-type.c: Use C++ exception handling.
1746         * python/py-symbol.c: Use C++ exception handling.
1747         * python/py-record.c: Use C++ exception handling.
1748         * python/py-record-btrace.c: Use C++ exception handling.
1749         * python/py-progspace.c: Use C++ exception handling.
1750         * python/py-prettyprint.c: Use C++ exception handling.
1751         * python/py-param.c: Use C++ exception handling.
1752         * python/py-objfile.c: Use C++ exception handling.
1753         * python/py-linetable.c: Use C++ exception handling.
1754         * python/py-lazy-string.c: Use C++ exception handling.
1755         * python/py-infthread.c: Use C++ exception handling.
1756         * python/py-inferior.c: Use C++ exception handling.
1757         * python/py-gdb-readline.c: Use C++ exception handling.
1758         * python/py-framefilter.c: Use C++ exception handling.
1759         * python/py-frame.c: Use C++ exception handling.
1760         * python/py-finishbreakpoint.c: Use C++ exception handling.
1761         * python/py-cmd.c: Use C++ exception handling.
1762         * python/py-breakpoint.c: Use C++ exception handling.
1763         * python/py-arch.c: Use C++ exception handling.
1764         * printcmd.c: Use C++ exception handling.
1765         * ppc-linux-tdep.c: Use C++ exception handling.
1766         * parse.c: Use C++ exception handling.
1767         * p-valprint.c: Use C++ exception handling.
1768         * objc-lang.c: Use C++ exception handling.
1769         * mi/mi-main.c: Use C++ exception handling.
1770         * mi/mi-interp.c: Use C++ exception handling.
1771         * mi/mi-cmd-stack.c: Use C++ exception handling.
1772         * mi/mi-cmd-break.c: Use C++ exception handling.
1773         * main.c: Use C++ exception handling.
1774         * linux-thread-db.c: Use C++ exception handling.
1775         * linux-tdep.c: Use C++ exception handling.
1776         * linux-nat.c: Use C++ exception handling.
1777         * linux-fork.c: Use C++ exception handling.
1778         * linespec.c: Use C++ exception handling.
1779         * language.c: Use C++ exception handling.
1780         * jit.c: Use C++ exception handling.
1781         * infrun.c: Use C++ exception handling.
1782         * infcmd.c: Use C++ exception handling.
1783         * infcall.c: Use C++ exception handling.
1784         * inf-loop.c: Use C++ exception handling.
1785         * i386-tdep.c: Use C++ exception handling.
1786         * i386-linux-tdep.c: Use C++ exception handling.
1787         * guile/scm-value.c: Use C++ exception handling.
1788         * guile/scm-type.c: Use C++ exception handling.
1789         * guile/scm-symtab.c: Use C++ exception handling.
1790         * guile/scm-symbol.c: Use C++ exception handling.
1791         * guile/scm-pretty-print.c: Use C++ exception handling.
1792         * guile/scm-ports.c: Use C++ exception handling.
1793         * guile/scm-param.c: Use C++ exception handling.
1794         * guile/scm-math.c: Use C++ exception handling.
1795         * guile/scm-lazy-string.c: Use C++ exception handling.
1796         * guile/scm-frame.c: Use C++ exception handling.
1797         * guile/scm-disasm.c: Use C++ exception handling.
1798         * guile/scm-cmd.c: Use C++ exception handling.
1799         * guile/scm-breakpoint.c: Use C++ exception handling.
1800         * guile/scm-block.c: Use C++ exception handling.
1801         * guile/guile-internal.h: Use C++ exception handling.
1802         * gnu-v3-abi.c: Use C++ exception handling.
1803         * gdbtypes.c: Use C++ exception handling.
1804         * frame.c: Use C++ exception handling.
1805         * frame-unwind.c: Use C++ exception handling.
1806         * fbsd-tdep.c: Use C++ exception handling.
1807         * f-valprint.c: Use C++ exception handling.
1808         * exec.c: Use C++ exception handling.
1809         * event-top.c: Use C++ exception handling.
1810         * event-loop.c: Use C++ exception handling.
1811         * eval.c: Use C++ exception handling.
1812         * dwarf2read.c: Use C++ exception handling.
1813         * dwarf2loc.c: Use C++ exception handling.
1814         * dwarf2-frame.c: Use C++ exception handling.
1815         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1816         * dwarf-index-write.c: Use C++ exception handling.
1817         * dwarf-index-cache.c: Use C++ exception handling.
1818         * dtrace-probe.c: Use C++ exception handling.
1819         * disasm-selftests.c: Use C++ exception handling.
1820         * darwin-nat.c: Use C++ exception handling.
1821         * cp-valprint.c: Use C++ exception handling.
1822         * cp-support.c: Use C++ exception handling.
1823         * cp-abi.c: Use C++ exception handling.
1824         * corelow.c: Use C++ exception handling.
1825         * completer.c: Use C++ exception handling.
1826         * compile/compile-object-run.c: Use C++ exception handling.
1827         * compile/compile-object-load.c: Use C++ exception handling.
1828         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1829         * compile/compile-c-symbols.c: Use C++ exception handling.
1830         * common/selftest.c: Use C++ exception handling.
1831         * common/new-op.c: Use C++ exception handling.
1832         * cli/cli-script.c: Use C++ exception handling.
1833         * cli/cli-interp.c: Use C++ exception handling.
1834         * cli/cli-cmds.c: Use C++ exception handling.
1835         * c-varobj.c: Use C++ exception handling.
1836         * btrace.c: Use C++ exception handling.
1837         * breakpoint.c: Use C++ exception handling.
1838         * break-catch-throw.c: Use C++ exception handling.
1839         * arch-utils.c: Use C++ exception handling.
1840         * amd64-tdep.c: Use C++ exception handling.
1841         * ada-valprint.c: Use C++ exception handling.
1842         * ada-typeprint.c: Use C++ exception handling.
1843         * ada-lang.c: Use C++ exception handling.
1844         * aarch64-tdep.c: Use C++ exception handling.
1845
1846 2019-04-08  Tom Tromey  <tom@tromey.com>
1847
1848         * xml-support.c (gdb_xml_parser::parse): Update.
1849         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1850         * value.c (show_convenience): Update.
1851         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1852         (test_parse_flags_qcs): Update.
1853         * thread.c (thr_try_catch_cmd): Update.
1854         * target.c (target_translate_tls_address): Update.
1855         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1856         (info_frame_command_core, frame_apply_command_count): Update.
1857         * rust-exp.y (rust_lex_exception_test): Update.
1858         * riscv-tdep.c (riscv_print_one_register_info): Update.
1859         * remote.c (remote_target::enable_btrace): Update.
1860         * record-btrace.c (record_btrace_enable_warn): Update.
1861         * python/py-utils.c (gdbpy_convert_exception): Update.
1862         * printcmd.c (do_one_display, print_variable_and_value): Update.
1863         * mi/mi-main.c (mi_print_exception): Update.
1864         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1865         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1866         * linux-nat.c (linux_nat_target::attach): Update.
1867         * linux-fork.c (class scoped_switch_fork_info): Update.
1868         * infrun.c (displaced_step_prepare): Update.
1869         * infcall.c (call_function_by_hand_dummy): Update.
1870         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1871         * gnu-v3-abi.c (print_one_vtable): Update.
1872         * frame.c (get_prev_frame_always): Update.
1873         * f-valprint.c (info_common_command_for_block): Update.
1874         * exec.c (try_open_exec_file): Update.
1875         * exceptions.c (print_exception, exception_print)
1876         (exception_fprintf, exception_print_same): Update.
1877         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1878         * dwarf-index-cache.c (index_cache::store)
1879         (index_cache::lookup_gdb_index): Update.
1880         * darwin-nat.c (maybe_cache_shell): Update.
1881         * cp-valprint.c (cp_print_value_fields): Update.
1882         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1883         (gcc_cplus_symbol_address): Update.
1884         * compile/compile-c-symbols.c (gcc_convert_symbol)
1885         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1886         * common/selftest.c: Update.
1887         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1888         a std::string.
1889         (exception_try_scope_entry, exception_try_scope_exit): Don't
1890         declare.
1891         (struct exception_try_scope): Remove.
1892         (TRY): Don't use exception_try_scope.
1893         (struct gdb_exception): Add constructor, operator=.
1894         <what>: New method.
1895         (struct gdb_exception_RETURN_MASK_ALL)
1896         (struct gdb_exception_RETURN_MASK_ERROR)
1897         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1898         (struct gdb_quit_bad_alloc): Update.
1899         * common/common-exceptions.c (exception_none): Change
1900         initializer.
1901         (struct catcher) <state, exception>: Initialize inline.
1902         <prev>: Remove member.
1903         (current_catcher): Remove.
1904         (catchers): New global.
1905         (exceptions_state_mc_init): Simplify.
1906         (catcher_pop): Remove.
1907         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1908         (try_scope_depth, exception_try_scope_entry)
1909         (exception_try_scope_exit): Remove.
1910         (throw_exception_sjlj): Update.
1911         (exception_messages, exception_messages_size): Remove.
1912         (throw_it): Simplify.
1913         (gdb_exception_sliced_copy): Remove.
1914         (throw_exception_cxx): Update.
1915         * cli/cli-script.c (script_from_file): Update.
1916         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1917         Update.
1918         * ada-valprint.c (ada_val_print): Update.
1919         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1920         (create_excep_cond_exprs): Update.
1921
1922 2019-04-08  Tom Tromey  <tom@tromey.com>
1923
1924         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1925         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1926         (TRY, CATCH, END_CATCH): Remove some definitions.
1927         * common/common-exceptions.c: Don't use GDB_XCPT.
1928         (catcher_list_size): Remove.
1929         (throw_exception, throw_it): Simplify.
1930
1931 2019-04-05  Tom Tromey  <tom@tromey.com>
1932
1933         Revert the header-sorting patch.
1934         * ft32-tdep.c: Revert.
1935         * frv-tdep.c: Revert.
1936         * frv-linux-tdep.c: Revert.
1937         * frame.c: Revert.
1938         * frame-unwind.c: Revert.
1939         * frame-base.c: Revert.
1940         * fork-child.c: Revert.
1941         * findvar.c: Revert.
1942         * findcmd.c: Revert.
1943         * filesystem.c: Revert.
1944         * filename-seen-cache.h: Revert.
1945         * filename-seen-cache.c: Revert.
1946         * fbsd-tdep.c: Revert.
1947         * fbsd-nat.h: Revert.
1948         * fbsd-nat.c: Revert.
1949         * f-valprint.c: Revert.
1950         * f-typeprint.c: Revert.
1951         * f-lang.c: Revert.
1952         * extension.h: Revert.
1953         * extension.c: Revert.
1954         * extension-priv.h: Revert.
1955         * expprint.c: Revert.
1956         * exec.h: Revert.
1957         * exec.c: Revert.
1958         * exceptions.c: Revert.
1959         * event-top.c: Revert.
1960         * event-loop.c: Revert.
1961         * eval.c: Revert.
1962         * elfread.c: Revert.
1963         * dwarf2read.h: Revert.
1964         * dwarf2read.c: Revert.
1965         * dwarf2loc.c: Revert.
1966         * dwarf2expr.h: Revert.
1967         * dwarf2expr.c: Revert.
1968         * dwarf2-frame.c: Revert.
1969         * dwarf2-frame-tailcall.c: Revert.
1970         * dwarf-index-write.h: Revert.
1971         * dwarf-index-write.c: Revert.
1972         * dwarf-index-common.c: Revert.
1973         * dwarf-index-cache.h: Revert.
1974         * dwarf-index-cache.c: Revert.
1975         * dummy-frame.c: Revert.
1976         * dtrace-probe.c: Revert.
1977         * disasm.h: Revert.
1978         * disasm.c: Revert.
1979         * disasm-selftests.c: Revert.
1980         * dictionary.c: Revert.
1981         * dicos-tdep.c: Revert.
1982         * demangle.c: Revert.
1983         * dcache.h: Revert.
1984         * dcache.c: Revert.
1985         * darwin-nat.h: Revert.
1986         * darwin-nat.c: Revert.
1987         * darwin-nat-info.c: Revert.
1988         * d-valprint.c: Revert.
1989         * d-namespace.c: Revert.
1990         * d-lang.c: Revert.
1991         * ctf.c: Revert.
1992         * csky-tdep.c: Revert.
1993         * csky-linux-tdep.c: Revert.
1994         * cris-tdep.c: Revert.
1995         * cris-linux-tdep.c: Revert.
1996         * cp-valprint.c: Revert.
1997         * cp-support.c: Revert.
1998         * cp-namespace.c: Revert.
1999         * cp-abi.c: Revert.
2000         * corelow.c: Revert.
2001         * corefile.c: Revert.
2002         * continuations.c: Revert.
2003         * completer.h: Revert.
2004         * completer.c: Revert.
2005         * complaints.c: Revert.
2006         * coffread.c: Revert.
2007         * coff-pe-read.c: Revert.
2008         * cli-out.h: Revert.
2009         * cli-out.c: Revert.
2010         * charset.c: Revert.
2011         * c-varobj.c: Revert.
2012         * c-valprint.c: Revert.
2013         * c-typeprint.c: Revert.
2014         * c-lang.c: Revert.
2015         * buildsym.c: Revert.
2016         * buildsym-legacy.c: Revert.
2017         * build-id.h: Revert.
2018         * build-id.c: Revert.
2019         * btrace.c: Revert.
2020         * bsd-uthread.c: Revert.
2021         * breakpoint.h: Revert.
2022         * breakpoint.c: Revert.
2023         * break-catch-throw.c: Revert.
2024         * break-catch-syscall.c: Revert.
2025         * break-catch-sig.c: Revert.
2026         * blockframe.c: Revert.
2027         * block.c: Revert.
2028         * bfin-tdep.c: Revert.
2029         * bfin-linux-tdep.c: Revert.
2030         * bfd-target.c: Revert.
2031         * bcache.c: Revert.
2032         * ax-general.c: Revert.
2033         * ax-gdb.h: Revert.
2034         * ax-gdb.c: Revert.
2035         * avr-tdep.c: Revert.
2036         * auxv.c: Revert.
2037         * auto-load.c: Revert.
2038         * arm-wince-tdep.c: Revert.
2039         * arm-tdep.c: Revert.
2040         * arm-symbian-tdep.c: Revert.
2041         * arm-pikeos-tdep.c: Revert.
2042         * arm-obsd-tdep.c: Revert.
2043         * arm-nbsd-tdep.c: Revert.
2044         * arm-nbsd-nat.c: Revert.
2045         * arm-linux-tdep.c: Revert.
2046         * arm-linux-nat.c: Revert.
2047         * arm-fbsd-tdep.c: Revert.
2048         * arm-fbsd-nat.c: Revert.
2049         * arm-bsd-tdep.c: Revert.
2050         * arch-utils.c: Revert.
2051         * arc-tdep.c: Revert.
2052         * arc-newlib-tdep.c: Revert.
2053         * annotate.h: Revert.
2054         * annotate.c: Revert.
2055         * amd64-windows-tdep.c: Revert.
2056         * amd64-windows-nat.c: Revert.
2057         * amd64-tdep.c: Revert.
2058         * amd64-sol2-tdep.c: Revert.
2059         * amd64-obsd-tdep.c: Revert.
2060         * amd64-obsd-nat.c: Revert.
2061         * amd64-nbsd-tdep.c: Revert.
2062         * amd64-nbsd-nat.c: Revert.
2063         * amd64-nat.c: Revert.
2064         * amd64-linux-tdep.c: Revert.
2065         * amd64-linux-nat.c: Revert.
2066         * amd64-fbsd-tdep.c: Revert.
2067         * amd64-fbsd-nat.c: Revert.
2068         * amd64-dicos-tdep.c: Revert.
2069         * amd64-darwin-tdep.c: Revert.
2070         * amd64-bsd-nat.c: Revert.
2071         * alpha-tdep.c: Revert.
2072         * alpha-obsd-tdep.c: Revert.
2073         * alpha-nbsd-tdep.c: Revert.
2074         * alpha-mdebug-tdep.c: Revert.
2075         * alpha-linux-tdep.c: Revert.
2076         * alpha-linux-nat.c: Revert.
2077         * alpha-bsd-tdep.c: Revert.
2078         * alpha-bsd-nat.c: Revert.
2079         * aix-thread.c: Revert.
2080         * agent.c: Revert.
2081         * addrmap.c: Revert.
2082         * ada-varobj.c: Revert.
2083         * ada-valprint.c: Revert.
2084         * ada-typeprint.c: Revert.
2085         * ada-tasks.c: Revert.
2086         * ada-lang.c: Revert.
2087         * aarch64-tdep.c: Revert.
2088         * aarch64-ravenscar-thread.c: Revert.
2089         * aarch64-newlib-tdep.c: Revert.
2090         * aarch64-linux-tdep.c: Revert.
2091         * aarch64-linux-nat.c: Revert.
2092         * aarch64-fbsd-tdep.c: Revert.
2093         * aarch64-fbsd-nat.c: Revert.
2094         * aarch32-linux-nat.c: Revert.
2095
2096 2019-04-05  Tom Tromey  <tom@tromey.com>
2097
2098         * ft32-tdep.c: Sort headers.
2099         * frv-tdep.c: Sort headers.
2100         * frv-linux-tdep.c: Sort headers.
2101         * frame.c: Sort headers.
2102         * frame-unwind.c: Sort headers.
2103         * frame-base.c: Sort headers.
2104         * fork-child.c: Sort headers.
2105         * findvar.c: Sort headers.
2106         * findcmd.c: Sort headers.
2107         * filesystem.c: Sort headers.
2108         * filename-seen-cache.h: Sort headers.
2109         * filename-seen-cache.c: Sort headers.
2110         * fbsd-tdep.c: Sort headers.
2111         * fbsd-nat.h: Sort headers.
2112         * fbsd-nat.c: Sort headers.
2113         * f-valprint.c: Sort headers.
2114         * f-typeprint.c: Sort headers.
2115         * f-lang.c: Sort headers.
2116         * extension.h: Sort headers.
2117         * extension.c: Sort headers.
2118         * extension-priv.h: Sort headers.
2119         * expprint.c: Sort headers.
2120         * exec.h: Sort headers.
2121         * exec.c: Sort headers.
2122         * exceptions.c: Sort headers.
2123         * event-top.c: Sort headers.
2124         * event-loop.c: Sort headers.
2125         * eval.c: Sort headers.
2126         * elfread.c: Sort headers.
2127         * dwarf2read.h: Sort headers.
2128         * dwarf2read.c: Sort headers.
2129         * dwarf2loc.c: Sort headers.
2130         * dwarf2expr.h: Sort headers.
2131         * dwarf2expr.c: Sort headers.
2132         * dwarf2-frame.c: Sort headers.
2133         * dwarf2-frame-tailcall.c: Sort headers.
2134         * dwarf-index-write.h: Sort headers.
2135         * dwarf-index-write.c: Sort headers.
2136         * dwarf-index-common.c: Sort headers.
2137         * dwarf-index-cache.h: Sort headers.
2138         * dwarf-index-cache.c: Sort headers.
2139         * dummy-frame.c: Sort headers.
2140         * dtrace-probe.c: Sort headers.
2141         * disasm.h: Sort headers.
2142         * disasm.c: Sort headers.
2143         * disasm-selftests.c: Sort headers.
2144         * dictionary.c: Sort headers.
2145         * dicos-tdep.c: Sort headers.
2146         * demangle.c: Sort headers.
2147         * dcache.h: Sort headers.
2148         * dcache.c: Sort headers.
2149         * darwin-nat.h: Sort headers.
2150         * darwin-nat.c: Sort headers.
2151         * darwin-nat-info.c: Sort headers.
2152         * d-valprint.c: Sort headers.
2153         * d-namespace.c: Sort headers.
2154         * d-lang.c: Sort headers.
2155         * ctf.c: Sort headers.
2156         * csky-tdep.c: Sort headers.
2157         * csky-linux-tdep.c: Sort headers.
2158         * cris-tdep.c: Sort headers.
2159         * cris-linux-tdep.c: Sort headers.
2160         * cp-valprint.c: Sort headers.
2161         * cp-support.c: Sort headers.
2162         * cp-namespace.c: Sort headers.
2163         * cp-abi.c: Sort headers.
2164         * corelow.c: Sort headers.
2165         * corefile.c: Sort headers.
2166         * continuations.c: Sort headers.
2167         * completer.h: Sort headers.
2168         * completer.c: Sort headers.
2169         * complaints.c: Sort headers.
2170         * coffread.c: Sort headers.
2171         * coff-pe-read.c: Sort headers.
2172         * cli-out.h: Sort headers.
2173         * cli-out.c: Sort headers.
2174         * charset.c: Sort headers.
2175         * c-varobj.c: Sort headers.
2176         * c-valprint.c: Sort headers.
2177         * c-typeprint.c: Sort headers.
2178         * c-lang.c: Sort headers.
2179         * buildsym.c: Sort headers.
2180         * buildsym-legacy.c: Sort headers.
2181         * build-id.h: Sort headers.
2182         * build-id.c: Sort headers.
2183         * btrace.c: Sort headers.
2184         * bsd-uthread.c: Sort headers.
2185         * breakpoint.h: Sort headers.
2186         * breakpoint.c: Sort headers.
2187         * break-catch-throw.c: Sort headers.
2188         * break-catch-syscall.c: Sort headers.
2189         * break-catch-sig.c: Sort headers.
2190         * blockframe.c: Sort headers.
2191         * block.c: Sort headers.
2192         * bfin-tdep.c: Sort headers.
2193         * bfin-linux-tdep.c: Sort headers.
2194         * bfd-target.c: Sort headers.
2195         * bcache.c: Sort headers.
2196         * ax-general.c: Sort headers.
2197         * ax-gdb.h: Sort headers.
2198         * ax-gdb.c: Sort headers.
2199         * avr-tdep.c: Sort headers.
2200         * auxv.c: Sort headers.
2201         * auto-load.c: Sort headers.
2202         * arm-wince-tdep.c: Sort headers.
2203         * arm-tdep.c: Sort headers.
2204         * arm-symbian-tdep.c: Sort headers.
2205         * arm-pikeos-tdep.c: Sort headers.
2206         * arm-obsd-tdep.c: Sort headers.
2207         * arm-nbsd-tdep.c: Sort headers.
2208         * arm-nbsd-nat.c: Sort headers.
2209         * arm-linux-tdep.c: Sort headers.
2210         * arm-linux-nat.c: Sort headers.
2211         * arm-fbsd-tdep.c: Sort headers.
2212         * arm-fbsd-nat.c: Sort headers.
2213         * arm-bsd-tdep.c: Sort headers.
2214         * arch-utils.c: Sort headers.
2215         * arc-tdep.c: Sort headers.
2216         * arc-newlib-tdep.c: Sort headers.
2217         * annotate.h: Sort headers.
2218         * annotate.c: Sort headers.
2219         * amd64-windows-tdep.c: Sort headers.
2220         * amd64-windows-nat.c: Sort headers.
2221         * amd64-tdep.c: Sort headers.
2222         * amd64-sol2-tdep.c: Sort headers.
2223         * amd64-obsd-tdep.c: Sort headers.
2224         * amd64-obsd-nat.c: Sort headers.
2225         * amd64-nbsd-tdep.c: Sort headers.
2226         * amd64-nbsd-nat.c: Sort headers.
2227         * amd64-nat.c: Sort headers.
2228         * amd64-linux-tdep.c: Sort headers.
2229         * amd64-linux-nat.c: Sort headers.
2230         * amd64-fbsd-tdep.c: Sort headers.
2231         * amd64-fbsd-nat.c: Sort headers.
2232         * amd64-dicos-tdep.c: Sort headers.
2233         * amd64-darwin-tdep.c: Sort headers.
2234         * amd64-bsd-nat.c: Sort headers.
2235         * alpha-tdep.c: Sort headers.
2236         * alpha-obsd-tdep.c: Sort headers.
2237         * alpha-nbsd-tdep.c: Sort headers.
2238         * alpha-mdebug-tdep.c: Sort headers.
2239         * alpha-linux-tdep.c: Sort headers.
2240         * alpha-linux-nat.c: Sort headers.
2241         * alpha-bsd-tdep.c: Sort headers.
2242         * alpha-bsd-nat.c: Sort headers.
2243         * aix-thread.c: Sort headers.
2244         * agent.c: Sort headers.
2245         * addrmap.c: Sort headers.
2246         * ada-varobj.c: Sort headers.
2247         * ada-valprint.c: Sort headers.
2248         * ada-typeprint.c: Sort headers.
2249         * ada-tasks.c: Sort headers.
2250         * ada-lang.c: Sort headers.
2251         * aarch64-tdep.c: Sort headers.
2252         * aarch64-ravenscar-thread.c: Sort headers.
2253         * aarch64-newlib-tdep.c: Sort headers.
2254         * aarch64-linux-tdep.c: Sort headers.
2255         * aarch64-linux-nat.c: Sort headers.
2256         * aarch64-fbsd-tdep.c: Sort headers.
2257         * aarch64-fbsd-nat.c: Sort headers.
2258         * aarch32-linux-nat.c: Sort headers.
2259
2260 2019-04-04  Tom Tromey  <tom@tromey.com>
2261
2262         * varobj.c (varobj_create): Update.
2263         * rust-exp.y (struct rust_parser) <update_innermost_block,
2264         lookup_symbol>: New methods.
2265         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2266         Rename.
2267         (rust_parser::rust_lookup_type)
2268         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2269         * printcmd.c (display_command, do_one_display): Update.
2270         * parser-defs.h (struct parser_state) <parser_state>: Add
2271         "tracker" parameter.
2272         (block_tracker): New member.
2273         (class innermost_block_tracker) <innermost_block_tracker>: Add
2274         "types" parameter.
2275         <reset>: Remove method.
2276         (innermost_block): Don't declare.
2277         (null_post_parser): Update.
2278         * parse.c (innermost_block): Remove global.
2279         (write_dollar_variable): Update.
2280         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2281         Remove "tracker_types" parameter.
2282         (parse_expression): Add "tracker" parameter.
2283         (parse_expression_for_completion): Update.
2284         (null_post_parser): Add "tracker" parameter.
2285         * p-exp.y: Update rules.
2286         * m2-exp.y: Update rules.
2287         * language.h (struct language_defn) <la_post_parser>: Add
2288         "tracker" parameter.
2289         * go-exp.y: Update rules.
2290         * f-exp.y: Update rules.
2291         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2292         parameter.
2293         * d-exp.y: Update rules.
2294         * c-exp.y: Update rules.
2295         * breakpoint.c (set_breakpoint_condition): Create an
2296         innermost_block_tracker.
2297         (watch_command_1): Likewise.
2298         * ada-lang.c (resolve): Add "tracker" parameter.
2299         (resolve_subexp): Likewise.
2300         * ada-exp.y (write_var_from_sym): Update.
2301
2302 2019-04-04  Tom Tromey  <tom@tromey.com>
2303
2304         * type-stack.h: New file.
2305         * type-stack.c: New file.
2306         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2307         type-stack.h.
2308         (insert_into_type_stack, insert_type, push_type, push_type_int)
2309         (insert_type_address_space, pop_type, pop_type_int)
2310         (pop_typelist, pop_type_stack, append_type_stack)
2311         (push_type_stack, get_type_stack, push_typelist)
2312         (follow_type_instance_flags, follow_types): Don't declare.
2313         * parse.c (type_stack): Remove global.
2314         (parse_exp_in_context): Update.
2315         (insert_into_type_stack, insert_type, push_type, push_type_int)
2316         (insert_type_address_space, pop_type, pop_type_int)
2317         (pop_typelist, pop_type_stack, append_type_stack)
2318         (push_type_stack, get_type_stack, push_typelist)
2319         (follow_type_instance_flags, follow_types): Remove (moved to
2320         type-stack.c).
2321         * f-exp.y (type_stack): New global.
2322         Update rules.
2323         (push_kind_type, f_parse): Update.
2324         * d-exp.y (type_stack): New global.
2325         Update rules.
2326         (d_parse): Update.
2327         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2328         Update rules.
2329         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2330         (HFILES_NO_SRCDIR): Add type-stack.h.
2331
2332 2019-04-04  Tom Tromey  <tom@tromey.com>
2333
2334         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2335         (rust_parser::convert_ast_to_expression, rust_parse)
2336         (rust_lex_test_completion, rust_lex_tests): Update.
2337         * parser-defs.h (struct expr_completion_state): New.
2338         (struct parser_state) <parser_state>: Add completion parameter.
2339         <mark_struct_expression, mark_completion_tag>: New methods.
2340         <parse_completion, m_completion_state>: New members.
2341         (prefixify_expression, null_post_parser): Update.
2342         (mark_struct_expression, mark_completion_tag): Don't declare.
2343         * parse.c (parse_completion, expout_last_struct)
2344         (expout_tag_completion_type, expout_completion_name): Remove
2345         globals.
2346         (parser_state::mark_struct_expression)
2347         (parser_state::mark_completion_tag): Now methods.
2348         (prefixify_expression): Add last_struct parameter.
2349         (prefixify_subexp): Likewise.
2350         (parse_exp_1): Update.
2351         (parse_exp_in_context): Add cstate parameter.  Update.
2352         (parse_expression_for_completion): Create an
2353         expr_completion_state.
2354         (null_post_parser): Add "completion" parameter.
2355         * p-exp.y: Update rules.
2356         (yylex): Update.
2357         * language.h (struct language_defn) <la_post_parser>: Add
2358         "completing" parameter.
2359         * go-exp.y: Update rules.
2360         (lex_one_token): Update.
2361         * expression.h (parse_completion): Don't declare.
2362         * d-exp.y: Update rules.
2363         (lex_one_token): Update rules.
2364         * c-exp.y: Update rules.
2365         (lex_one_token): Update.
2366         * ada-lang.c (resolve): Add "parse_completion" parameter.
2367         (resolve_subexp): Likewise.
2368         (ada_resolve_function): Likewise.
2369
2370 2019-04-04  Tom Tromey  <tom@tromey.com>
2371
2372         * parser-defs.h (struct parser_state) <start_arglist,
2373         end_arglist>: New methods.
2374         <arglist_len, m_funcall_chain>: New members.
2375         (arglist_len, start_arglist, end_arglist): Don't declare.
2376         * parse.c (arglist_len, funcall_chain): Remove global.
2377         (start_arglist, end_arglist): Remove functions.
2378         (parse_exp_in_context): Update.
2379         * p-exp.y: Update rules.
2380         * m2-exp.y: Update rules.
2381         * go-exp.y: Update rules.
2382         * f-exp.y: Update rules.
2383         * d-exp.y: Update rules.
2384         * c-exp.y: Update rules.
2385
2386 2019-04-04  Tom Tromey  <tom@tromey.com>
2387
2388         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2389         lex_operator, push_back>: New methods.
2390         Update all rules.
2391         (rust_parser::lex_hex, lex_escape): Rename and update.
2392         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2393         (rust_parser::lex_operator): Rename and update.
2394         (rust_parser::lex_number, rustyylex, rustyyerror)
2395         (rust_lex_test_init, rust_lex_test_sequence)
2396         (rust_lex_test_push_back, rust_lex_tests): Update.
2397         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2398         parameter.
2399         <lexptr, prev_lexptr>: New members.
2400         (lexptr, prev_lexptr): Don't declare.
2401         * parse.c (lexptr, prev_lexptr): Remove globals.
2402         (parse_exp_in_context): Update.
2403         * p-exp.y (yylex, yyerror): Update.
2404         * m2-exp.y (parse_number, yylex, yyerror): Update.
2405         * go-exp.y (lex_one_token, yyerror): Update.
2406         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2407         * d-exp.y (lex_one_token, yyerror): Update.
2408         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2409         (lex_one_token, yyerror): Update.
2410         * ada-lex.l (YY_INPUT): Update.
2411         (rewind_to_char): Update.
2412         * ada-exp.y (yyerror): Update.
2413
2414 2019-04-04  Tom Tromey  <tom@tromey.com>
2415
2416         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2417         * parser-defs.h (struct parser_state) <parser_state>: Add new
2418         parameter.
2419         <comma_terminates>: New member.
2420         (comma_terminates): Don't declare global.
2421         * parse.c (comma_terminates): Remove global.
2422         (parse_exp_in_context): Update.
2423         * p-exp.y (yylex): Update.
2424         * m2-exp.y (yylex): Update.
2425         * go-exp.y (lex_one_token): Update.
2426         * f-exp.y (yylex): Update.
2427         * d-exp.y (lex_one_token): Update.
2428         * c-exp.y (lex_one_token): Update.
2429         * ada-lex.l: Update.
2430
2431 2019-04-04  Tom Tromey  <tom@tromey.com>
2432
2433         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2434         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2435         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2436         * parser-defs.h (paren_depth): Don't declare.
2437         * parse.c (paren_depth): Remove global.
2438         (parse_exp_in_context): Update.
2439         * p-exp.y (paren_depth): New global.
2440         (pascal_parse): Initialize it.
2441         * m2-exp.y (paren_depth): New global.
2442         (m2_parse): Initialize it.
2443         * go-exp.y (paren_depth): New global.
2444         (go_parse): Initialize it.
2445         * f-exp.y (paren_depth): New global.
2446         (f_parse): Initialize it.
2447         * d-exp.y (paren_depth): New global.
2448         (d_parse): Initialize it.
2449         * c-exp.y (paren_depth): New global.
2450         (c_parse): Initialize it.
2451         * ada-lex.l (paren_depth): New global.
2452         (lexer_init): Initialize it.
2453
2454 2019-04-04  Tom Tromey  <tom@tromey.com>
2455
2456         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2457         (rust_parser::convert_ast_to_type)
2458         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2459         * parser-defs.h (struct parser_state) <parser_state>: Add
2460         parameters.  Initialize new members.
2461         <expression_context_block, expression_context_pc>: New members.
2462         * parse.c (expression_context_block, expression_context_pc):
2463         Remove globals.
2464         (parse_exp_in_context): Update.
2465         * p-exp.y: Update all rules.
2466         (yylex): Update.
2467         * m2-exp.y: Update all rules.
2468         (yylex): Update.
2469         * go-exp.y (yylex): Update.
2470         * f-exp.y (yylex): Update.
2471         * d-exp.y: Update all rules.
2472         (yylex): Update.
2473         * c-exp.y: Update all rules.
2474         (lex_one_token, classify_name, yylex, c_parse): Update.
2475         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2476
2477 2019-04-04  Tom Tromey  <tom@tromey.com>
2478
2479         * gdbarch.h, gdbarch.c: Rebuild.
2480         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2481         * stap-probe.h:
2482         (struct stap_parse_info): Replace "parser_state" with
2483         "expr_builder".
2484         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2485         (parser_state): New class.
2486         * parse.c (expr_builder): Rename.
2487         (expr_builder::release): Rename.
2488         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2489         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2490         (write_exp_elt_longcst, write_exp_elt_floatcst)
2491         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2492         (write_exp_string_vector, write_exp_bitstring)
2493         (write_exp_msymbol, mark_struct_expression)
2494         (write_dollar_variable)
2495         (insert_type_address_space, increase_expout_size): Replace
2496         "parser_state" with "expr_builder".
2497         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2498         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2499         "parser_state" with "expr_builder".
2500
2501 2019-04-04  Tom Tromey  <tom@tromey.com>
2502
2503         * rust-exp.y: Replace "parse_language" with method call.
2504         * p-exp.y:
2505         (yylex): Replace "parse_language" with method call.
2506         * m2-exp.y:
2507         (yylex): Replace "parse_language" with method call.
2508         * go-exp.y (classify_name): Replace "parse_language" with method
2509         call.
2510         * f-exp.y (yylex): Replace "parse_language" with method call.
2511         * d-exp.y (lex_one_token): Replace "parse_language" with method
2512         call.
2513         * c-exp.y:
2514         (lex_one_token, classify_name, yylex): Replace "parse_language"
2515         with method call.
2516         * ada-exp.y (find_primitive_type, type_char)
2517         (type_system_address): Replace "parse_language" with method call.
2518
2519 2019-04-04  Tom Tromey  <tom@tromey.com>
2520
2521         * rust-exp.y: Replace "parse_gdbarch" with method call.
2522         * parse.c (write_dollar_variable, insert_type_address_space):
2523         Replace "parse_gdbarch" with method call.
2524         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2525         call.
2526         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2527         call.
2528         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2529         "parse_gdbarch" with method call.
2530         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2531         with method call.
2532         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2533         "parse_gdbarch" with method call.
2534         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2535         "parse_gdbarch" with method call.
2536         * c-exp.y (parse_type, parse_number, classify_name): Replace
2537         "parse_gdbarch" with method call.
2538         * ada-lex.l: Replace "parse_gdbarch" with method call.
2539         * ada-exp.y (parse_type, find_primitive_type, type_char)
2540         (type_system_address): Replace "parse_gdbarch" with method call.
2541
2542 2019-04-04  Tom Tromey  <tom@tromey.com>
2543
2544         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2545         * stap-probe.c (stap_parse_argument): Update.
2546         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2547         initial_size parameter.
2548         * rust-exp.y (rust_lex_tests): Update.
2549         * parse.c (parser_state): Update.
2550         (parse_exp_in_context): Update.
2551         * parser-defs.h (struct parser_state) <parser_state>: Remove
2552         "initial_size" parameter.
2553
2554 2019-04-04  Tom Tromey  <tom@tromey.com>
2555
2556         * parser-defs.h (increase_expout_size): Don't declare.
2557         * parse.c (increase_expout_size): Now static.
2558
2559 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2560
2561         * gnu-nat.c (gnu_nat_target::wait): Fix
2562         target_waitstatus_to_string call.
2563
2564 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * eval.c (evaluate_subexp_standard): Handle internal functions
2567         during Fortran function call handling.
2568
2569 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * NEWS: Mention new internal functions.
2572         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2573         (read_base_type): Use dwarf2_init_complex_target_type.
2574         * value.c (creal_internal_fn): New function.
2575         (cimag_internal_fn): New function.
2576         (_initialize_values): Register new internal functions.
2577
2578 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2579
2580         * infrun.c (stop_all_threads): If debug_infrun, always
2581         trace the wait status after wait_one, using
2582         target_waitstatus_to_string and target_pid_to_str.
2583         (handle_inferior_event): Replace various trace of
2584         wait status kind by a single trace.
2585         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2586         wait status kind image by target_waitstatus_to_string.
2587         * target/waitstatus.c (target_waitstatus_to_string): Fix
2588         obsolete comment.
2589
2590 2019-04-01  Tom Tromey  <tromey@adacore.com>
2591
2592         PR symtab/23331:
2593         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2594
2595 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2596             Pedro Alves  <palves@redhat.com>
2597
2598         * top.c (quit_force): Call 'finalize_values'.
2599         * value.c (finalize_values): New function.
2600         * value.h (finalize_values): Declare.
2601
2602 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2603
2604         * NEWS: Announce $_gdb_major and $_gdb_minor.
2605
2606         * top.c (init_gdb_version_vars): New function.
2607         (gdb_init): Call init_gdb_version_vars.
2608
2609 2019-03-29  Tom Tromey  <tromey@adacore.com>
2610
2611         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2612         help text.  Remove dead code.
2613
2614 2019-03-29  Keith Seitz  <keiths@redhat.com>
2615
2616         From Siddhesh Poyarekar:
2617         * f-lang.h (f77_get_upperbound): Return LONGEST.
2618         (f77_get_lowerbound): Likewise.
2619         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2620         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2621         print them.
2622         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2623         plongest to format print it.
2624         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2625         (f77_get_upperbound): Likewise.
2626         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2627         LOWER_BOUND to LONGEST.
2628         (f77_create_arrayprint_offset_tbl): Likewise.
2629
2630 2019-03-29  Keith Seitz  <keiths@redhat.com>
2631
2632         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2633         %s/pulongest for TYPE_LENGTH instead of %d in format
2634         strings.
2635         * ada-typerint.c (ada_print_type): Likewise.
2636         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2637         * compile/compile-c-support.c (generate_register_struct): Likewise.
2638         * gdbtypes.c (recursive_dump_type): Likewise.
2639         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2640         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2641         instead of %d in format strings.
2642         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2643         to std::min to ULONGEST.
2644         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2645         instead of %d in format strings.
2646         * tracepoint.c (info_scope_command): Likewise.
2647         * typeprint.c (print_offset_data::update)
2648         (print_offset_data::finish): Likewise.
2649         * xtensa-tdep.c (xtensa_store_return_value)
2650         (xtensa_push_dummy_call): Likewise.
2651
2652 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2653
2654         * windows-nat.c (display_selector): Fixed format specifications
2655         for 64-bit Cygwin.
2656
2657 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2658
2659         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2660
2661 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2662
2663         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2664         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2665         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2666         (nios2_linux_init_abi): Install it.
2667
2668 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2669
2670         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2671
2672 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2673
2674         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2675
2676 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2677             Tom Tromey  <tromey@adacore.com>
2678
2679         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2680
2681 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2682
2683         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2684         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2685         method to compute the bounds of range types. Also print "[evaluated]"
2686         if the bounds' values come from a dynamic evaluation.
2687
2688 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2691         whitespace when pretty printing is on.
2692
2693 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2694
2695         * ppc-linux-nat.c: Add include.
2696
2697 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2698
2699         * NEWS: Mention AArch64 Pointer Authentication.
2700
2701 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2702
2703         * arm-linux-nat.c: Add include.
2704
2705 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2706
2707         * source-cache.c (source_cache::get_source_lines): Re-read
2708         fullname after calling open_source_file.
2709
2710 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2711
2712         * NEWS: Mention TLS support for FreeBSD.
2713
2714 2019-03-25  Tom Tromey  <tromey@adacore.com>
2715
2716         * minsyms.c (BUNCH_SIZE): Update comment.
2717         (~minimal_symbol_reader): Remove old comment.
2718         (compact_minimal_symbols): Update comment.
2719         (minimal_symbol_reader::install): Remove old comment.  Update
2720         other comments.
2721
2722 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2723
2724         * s390-linux-nat.c: Add include.
2725
2726 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2727
2728         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2729         Call linux_get_hwcap.
2730         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2731         Likewise.
2732         (aarch64_linux_get_hwcap): Remove function.
2733         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2734         declaration.
2735         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2736         linux_get_hwcap.
2737         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2738         * linux-tdep.c (linux_get_hwcap): Add function.
2739         (linux_get_hwcap2): Likewise.
2740         * linux-tdep.h (linux_get_hwcap): Add declaration.
2741         (linux_get_hwcap2): Likewise.
2742         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2743         (ppc_linux_get_hwcap2): Likewise.
2744         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2745         linux_get_hwcap.
2746         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2747         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2748         (ppc_linux_nat_target::read_description): Likewise.
2749         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2750         * s390-linux-nat.c: Likewise.
2751         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2752
2753 2019-03-24  Tom Tromey  <tom@tromey.com>
2754
2755         * ada-lang.c (standard_lookup): Simplify initialization.
2756         (ada_lookup_symbol_nonlocal): Simplify return.
2757         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2758         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2759         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2760         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2761         initialization.
2762         * solib.c (solib_global_lookup): Simplify.
2763         * symtab.c (null_block_symbol): Remove.
2764         (symbol_cache_lookup): Simplify returns.
2765         (lookup_language_this): Simplify returns.
2766         (lookup_symbol_aux): Simplify return.
2767         (lookup_local_symbol): Simplify returns.
2768         (lookup_global_symbol_from_objfile): Simplify return.
2769         (lookup_symbol_in_objfile_symtabs)
2770         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2771         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2772         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2773         * cp-namespace.c (cp_lookup_bare_symbol)
2774         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2775         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2776         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2777         (cp_lookup_symbol_via_imports): Simplify initialization.
2778         (find_symbol_in_baseclass): Likewise.
2779         * symtab.h (null_block_symbol): Remove.
2780         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2781         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2782         (d_lookup_symbol_module): Likewise.
2783         (find_symbol_in_baseclass): Simplify initialization.
2784
2785 2019-03-24  Tom Tromey  <tom@tromey.com>
2786
2787         * expression.h: Don't include symtab.h.
2788         (struct block): Forward declare.
2789
2790 2019-03-24  Tom Tromey  <tom@tromey.com>
2791
2792         * c-exp.y (typebase): Remove casts.
2793         * gdbtypes.c (lookup_unsigned_typename, )
2794         (lookup_signed_typename): Remove cast.
2795         * eval.c (parse_to_comma_and_eval): Remove cast.
2796         * parse.c (write_dollar_variable): Remove cast.
2797         * block.h (struct block) <superblock>: Now const.
2798         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2799         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2800         (map_block): Make "block" const.
2801         * symfile.h (struct quick_symbol_functions)
2802         <map_matching_symbols>: Constify block argument to "callback".
2803         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2804         const.
2805         (find_pc_sect_compunit_symtab): Make "b" const.
2806         (find_symbol_at_address): Likewise.
2807         (search_symbols): Likewise.
2808         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2809         (dw2_debug_names_lookup_symbol): Likewise.
2810         (dw2_map_matching_symbols): Update.
2811         * p-valprint.c (pascal_val_print): Remove "block".
2812         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2813         (aux_add_nonlocal_symbols): Make "block" const.
2814         (resolve_subexp): Remove cast.
2815         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2816         const.
2817         (iterate_over_file_blocks): Likewise.
2818         * f-exp.y (%union) <bval>: Remove.
2819         * coffread.c (patch_opaque_types): Make "b" const.
2820         * spu-tdep.c (spu_catch_start): Make "block" const.
2821         * c-valprint.c (print_unpacked_pointer): Remove "block".
2822         * symmisc.c (dump_symtab_1): Make "b" const.
2823         (block_depth): Make "block" const.
2824         * d-exp.y (%union) <bval>: Remove.
2825         * cp-support.h (cp_lookup_rtti_type): Update.
2826         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2827         * psymtab.c (psym_lookup_symbol): Make "block" const.
2828         (maintenance_check_psymtabs): Make "b" const.
2829         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2830         (enumerate_locals, enumerate_args): Update.
2831         * python/py-symtab.c (stpy_global_block): Make "block" const.
2832         (stpy_static_block): Likewise.
2833         * inline-frame.c (block_starting_point_at): Make "new_block"
2834         const.
2835         * block.c (find_block_in_blockvector): Make return type const.
2836         (blockvector_for_pc_sect): Make "b" const.
2837         (find_block_in_blockvector): Make "b" const.
2838
2839 2019-03-23  Tom Tromey  <tom@tromey.com>
2840
2841         * varobj.c (varobj_create): Update.
2842         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2843         * printcmd.c (display_command, do_one_display): Don't reset
2844         innermost_block.
2845         * parser-defs.h (enum innermost_block_tracker_type): Move to
2846         expression.h.
2847         (innermost_block): Update comment.
2848         * parse.c (parse_exp_1): Add tracker_types parameter.
2849         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2850         tracker_types parameter.  Reset innermost_block.
2851         (parse_exp_in_context): Remove.
2852         (parse_expression_for_completion): Update.
2853         * objfiles.c (~objfile): Don't reset expression_context_block or
2854         innermost_block.
2855         * expression.h (enum innermost_block_tracker_type): Move from
2856         parser-defs.h.
2857         (parse_exp_1): Add tracker_types parameter.
2858         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2859         reset innermost_block.
2860
2861 2019-03-23  Tom Tromey  <tom@tromey.com>
2862
2863         * objfiles.h: Include bcache.h.
2864
2865 2019-03-23  Tom Tromey  <tom@tromey.com>
2866
2867         * linespec.c (get_current_search_block): Use
2868         scoped_restore_current_language.
2869         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2870
2871 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2872             Jiong Wang  <jiong.wang@arm.com>
2873
2874         * aarch64-linux-tdep.c
2875         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2876         section.
2877         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2878
2879 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2880             Jiong Wang  <jiong.wang@arm.com>
2881
2882         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2883         instructions.
2884         (aarch64_analyze_prologue_test): Add PACIASP test.
2885         (aarch64_prologue_prev_register): Unmask PC value.
2886
2887 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2888             Jiong Wang  <jiong.wang@arm.com>
2889
2890         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2891         (aarch64_dwarf2_prev_register): Unmask PC value.
2892         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2893         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2894         DW_CFA_AARCH64_negate_ra_state.
2895         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2896
2897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2898             Jiong Wang  <jiong.wang@arm.com>
2899
2900         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2901         registers.
2902         (aarch64_pseudo_register_name): Likewise.
2903         (aarch64_pseudo_register_type): Likewise.
2904         (aarch64_pseudo_register_reggroup_p): Likewise.
2905         (aarch64_gdbarch_init): Add pauth registers.
2906         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2907         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2908         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2909         (struct gdbarch_tdep): Add regnum for ra_state.
2910
2911 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2912             Jiong Wang  <jiong.wang@arm.com>
2913
2914         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2915
2916 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2917             Jiong Wang  <jiong.wang@arm.com>
2918
2919         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2920         function.
2921         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2922         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2923         (aarch64_gdbarch_init): Add puth registers.
2924         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2925         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2926         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2927
2928 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2929             Jiong Wang  <jiong.wang@arm.com>
2930
2931         * aarch64-linux-nat.c
2932         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2933         * aarch64-linux-tdep.c
2934         (aarch64_linux_core_read_description): Likewise.
2935         (aarch64_linux_get_hwcap): New function.
2936         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2937         (aarch64_linux_get_hwcap): New declaration.
2938
2939 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2940             Jiong Wang  <jiong.wang@arm.com>
2941
2942         * aarch64-linux-nat.c
2943         (aarch64_linux_nat_target::read_description): Add pauth param.
2944         * aarch64-linux-tdep.c
2945         (aarch64_linux_core_read_description): Likewise.
2946         * aarch64-tdep.c (struct target_desc): Add in pauth.
2947         (aarch64_read_description): Add pauth param.
2948         (aarch64_gdbarch_init): Likewise.
2949         * aarch64-tdep.h (aarch64_read_description): Likewise.
2950         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2951         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2952         * features/Makefile: Add new files.
2953         * features/aarch64-pauth.c: New file.
2954         * features/aarch64-pauth.xml: New file.
2955
2956 2019-03-20  Tom Tromey  <tromey@adacore.com>
2957
2958         * infrun.c (handle_inferior_event): Rename from
2959         handle_inferior_event_1.  Create a scoped_value_mark.
2960         (handle_inferior_event): Remove.
2961
2962 2019-03-19  Tom Tromey  <tromey@adacore.com>
2963
2964         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2965         * infrun.h (print_stop_event): Add "displays" parameter.
2966         * infrun.c (print_stop_event): Add "displays" parameter.
2967
2968 2019-03-19  Pedro Alves  <palves@redhat.com>
2969
2970         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2971         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2972         to -1.  Fix TABs vs spaces.
2973         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2974         * tui/tui-out.h (tui_ui_out) Add intro comments.
2975         <m_line, m_start_of_line>: In-class initialize, and add describing
2976         comment.
2977
2978 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2979
2980         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2981         variable names.
2982         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2983
2984 2019-03-18  Pedro Alves  <palves@redhat.com>
2985             Eli Zaretskii <eliz@gnu.org>
2986
2987         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2988         m_line and m_start_of_line.
2989
2990 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2991
2992         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2993         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2994         it returns a newline.  This fixes a regression in TU mode, whereby
2995         the next line is output on the same screen line as the user input.
2996
2997 2019-03-18  Tom Tromey  <tromey@adacore.com>
2998
2999         * minsyms.c (minimal_symbol_reader::install): Remove call to
3000         obstack_blank.
3001
3002 2019-03-18  Pedro Alves  <palves@redhat.com>
3003
3004         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3005         New globals.
3006         (apply_style): New, factored out from ...
3007         (apply_ansi_escape): ... this.  Handle reverse video mode.
3008         (tui_set_reverse_mode): New function.
3009         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3010         * tui/tui-winsource.c (tui_show_source_line): Use
3011         tui_set_reverse_mode instead of setting A_STANDOUT.
3012         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3013         New setter methods.
3014
3015 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3016
3017         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3018         Handle tabs.
3019
3020 2019-03-18  Tom Tromey  <tromey@adacore.com>
3021
3022         * ada-lang.c (empty_array): Add "high" parameter.
3023         (ada_evaluate_subexp): Update.
3024
3025 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3026
3027         * unittests/string_view-selftests.c: Define
3028         _initialize_string_view_selftests unconditionally.
3029
3030 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3031
3032         PR gdb/24350
3033         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3034
3035 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3036
3037         PR gdb/24351
3038         * windows-nat.c (display_selector): Fix format specifiers.
3039
3040 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3041
3042         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3043         tui_refill_source_window instead of tui_refresh_win, to update the
3044         current execution line.  This fixes redisplay of the current line
3045         when stepping through the code with "next" or "step".
3046
3047 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3048
3049         * source-cache.c (source_cache::get_source_lines): Call
3050         find_source_lines to initialize s->nlines.  This fixes vertical
3051         scrolling of TUI source window when the DOWN arrow is pressed.
3052
3053 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3054
3055         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3056         linux-thread-db.c (_initialize_thread_db): Likewise.
3057
3058 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3059
3060         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3061         wclrtoeol in tui_show_source_line".  This reverts changes made in
3062         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3063
3064 2019-03-15  Tom Tromey  <tom@tromey.com>
3065
3066         * symtab.h (struct minimal_symbol): Derive from
3067         general_symbol_info.
3068         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3069         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3070         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3071         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3072         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3073         (MSYMBOL_SEARCH_NAME): Update.
3074         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3075         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3076         * minsyms.c (minimal_symbol_reader::record_full): Update.
3077
3078 2019-03-15  Tom Tromey  <tom@tromey.com>
3079
3080         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3081
3082 2019-03-15  Tom Tromey  <tom@tromey.com>
3083
3084         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3085         unique_xmalloc_ptr.
3086         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3087         Update.
3088         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3089         (build_minimal_symbol_hash_tables)
3090         (minimal_symbol_reader::install): Update.
3091
3092 2019-03-15  Tom Tromey  <tom@tromey.com>
3093
3094         * symtab.c (create_demangled_names_hash): Update.
3095         (symbol_set_names): Update.
3096         * objfiles.h (struct objfile_per_bfd_storage)
3097         <demangled_names_hash>: Now an htab_up.
3098         * objfiles.c (objfile_per_bfd_storage): Simplify.
3099
3100 2019-03-15  Tom Tromey  <tom@tromey.com>
3101
3102         * objfiles.h (struct objfile_per_bfd_storage): Declare
3103         destructor.
3104         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3105         New.
3106         (get_objfile_bfd_data): Use new.  Don't initialize
3107         language_of_main.
3108         (free_objfile_per_bfd_storage): Remove.
3109         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3110
3111 2019-03-15  Tom Tromey  <tom@tromey.com>
3112
3113         * symfile.c (reread_symbols): Update.
3114         * objfiles.c (objfile::objfile): Update.
3115         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3116         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3117         comment.
3118         (minimal_symbol_reader::install): Update.
3119         (terminate_minimal_symbol_table): Remove.
3120         * jit.c (jit_object_close_impl): Update.
3121
3122 2019-03-15  Tom Tromey  <tom@tromey.com>
3123
3124         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3125         initializations.
3126
3127 2019-03-15  Tom Tromey  <tom@tromey.com>
3128
3129         * objfiles.h (struct objfile_per_bfd_storage)
3130         <demangled_hash_languages>: Now a bitset.
3131         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3132         (lookup_minimal_symbol): Update.
3133
3134 2019-03-15  Tom Tromey  <tom@tromey.com>
3135
3136         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3137         Don't return the symbol.
3138         * coffread.c (record_minimal_symbol): Use record_full.
3139
3140 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3141
3142         The MS-Windows port of ncurses fails to switch to a color pair if
3143         one or both of the colors are the implicit default colors.  This
3144         change records the default colors when TUI is initialized, and
3145         then specifies them explicitly when a color pair uses the default
3146         colors.  This allows color styling in TUI mode on MS-Windows.
3147
3148         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3149         ncurses_norm_attr.
3150         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3151         colors in ncurses_norm_attr.
3152         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3153         "none", replace it with the default color recorded in
3154         ncurses_norm_attr.
3155
3156 2019-03-14  Tom Tromey  <tromey@adacore.com>
3157
3158         * source-cache.h (class source_cache) <get_source_lines>: Return
3159         std::string.
3160         * source-cache.c (source_cache::extract_lines): Handle case where
3161         first_pos==npos.  Return std::string.
3162         (source_cache::get_source_lines): Update.
3163
3164 2019-03-14  Tom Tromey  <tromey@adacore.com>
3165
3166         * NEWS: Add item for "style sources" commands.
3167         * source-cache.c (source_cache::get_source_lines): Check
3168         source_styling.
3169         * cli/cli-style.c (source_styling): New global.
3170         (_initialize_cli_style): Add "style sources" commands.
3171         (show_style_sources): New function.
3172         * cli/cli-style.h (source_styling): Declare.
3173
3174 2019-03-14  Pedro Alves  <palves@redhat.com>
3175             Tom Tromey  <tromey@adacore.com>
3176
3177         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3178         * tui/tui-winsource.c (tui_refill_source_window): New function,
3179         from...
3180         (tui_horizontal_source_scroll): ... here.  Move some logic.
3181         * cli/cli-style.c (set_style_enabled): Notify new observable.
3182         * tui/tui-hooks.c (tui_redisplay_source): New function.
3183         (tui_attach_detach_observers): Attach or detach
3184         tui_redisplay_source.
3185         * observable.h (source_styling_changed): New observable.
3186         * observable.c: Define source_styling_changed observable.
3187
3188 2019-03-13  Tom Tromey  <tromey@adacore.com>
3189
3190         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3191         (i386_gnu_nat_target::store_registers): Update.
3192         * target-debug.h (target_debug_print_std_string): New macro.
3193         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3194         * windows-tdep.c (display_one_tib): Update.
3195         * tui/tui-stack.c (tui_make_status_line): Update.
3196         * top.c (print_inferior_quit_action): Update.
3197         * thread.c (thr_try_catch_cmd): Update.
3198         (add_thread_with_info): Update.
3199         (thread_target_id_str): Update.
3200         (thr_try_catch_cmd): Update.
3201         (thread_command): Update.
3202         (thread_find_command): Update.
3203         * record-btrace.c (record_btrace_target::info_record)
3204         (record_btrace_resume_thread, record_btrace_target::resume)
3205         (record_btrace_cancel_resume, record_btrace_step_thread)
3206         (record_btrace_target::wait, record_btrace_target::wait)
3207         (record_btrace_target::wait, record_btrace_target::stop): Update.
3208         * progspace.c (print_program_space): Update.
3209         * process-stratum-target.c
3210         (process_stratum_target::thread_address_space): Update.
3211         * linux-fork.c (linux_fork_mourn_inferior)
3212         (detach_checkpoint_command, info_checkpoints_command)
3213         (linux_fork_context): Update.
3214         (linux_fork_detach): Update.
3215         (class scoped_switch_fork_info): Update.
3216         (delete_checkpoint_command): Update.
3217         * infrun.c (follow_fork_inferior): Update.
3218         (follow_fork_inferior): Update.
3219         (proceed_after_vfork_done): Update.
3220         (handle_vfork_child_exec_or_exit): Update.
3221         (follow_exec): Update.
3222         (displaced_step_prepare_throw): Update.
3223         (displaced_step_restore): Update.
3224         (start_step_over): Update.
3225         (resume_1): Update.
3226         (clear_proceed_status_thread): Update.
3227         (proceed): Update.
3228         (print_target_wait_results): Update.
3229         (do_target_wait): Update.
3230         (context_switch): Update.
3231         (stop_all_threads): Update.
3232         (restart_threads): Update.
3233         (finish_step_over): Update.
3234         (handle_signal_stop): Update.
3235         (switch_back_to_stepped_thread): Update.
3236         (keep_going_pass_signal): Update.
3237         (print_exited_reason): Update.
3238         (normal_stop): Update.
3239         * inferior.c (inferior_pid_to_str): Change return type.
3240         (print_selected_inferior): Update.
3241         (add_inferior): Update.
3242         (detach_inferior): Update.
3243         * dummy-frame.c (fprint_dummy_frames): Update.
3244         * dcache.c (dcache_info_1): Update.
3245         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3246         (btrace_fetch, btrace_clear): Update.
3247         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3248         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3249         type.
3250         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3251         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3252         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3253         * gdbarch.c, gdbarch.h: Rebuild.
3254         * gdbarch.sh (core_pid_to_str): Change return type.
3255         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3256         return type.
3257         (windows_nat_target::pid_to_str): Change return type.
3258         (windows_delete_thread): Update.
3259         (windows_nat_target::attach): Update.
3260         (windows_nat_target::files_info): Update.
3261         * target-delegates.c: Rebuild.
3262         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3263         return type.
3264         (sol_thread_target::pid_to_str): Change return type.
3265         * remote.c (class remote_target) <pid_to_str>: Change return
3266         type.
3267         (remote_target::pid_to_str): Change return type.
3268         (extended_remote_target::attach, remote_target::remote_stop_ns)
3269         (remote_target::remote_notif_remove_queued_reply)
3270         (remote_target::push_stop_reply, remote_target::disable_btrace):
3271         Update.
3272         (extended_remote_target::attach): Update.
3273         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3274         type.
3275         (gdbsim_target::pid_to_str): Change return type.
3276         * ravenscar-thread.c (struct ravenscar_thread_target)
3277         <pid_to_str>: Change return type.
3278         (ravenscar_thread_target::pid_to_str): Change return type.
3279         * procfs.c (class procfs_target) <pid_to_str>: Change return
3280         type.
3281         (procfs_target::pid_to_str): Change return type.
3282         (procfs_target::attach): Update.
3283         (procfs_target::detach): Update.
3284         (procfs_target::fetch_registers): Update.
3285         (procfs_target::store_registers): Update.
3286         (procfs_target::wait): Update.
3287         (procfs_target::files_info): Update.
3288         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3289         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3290         return type.
3291         (nto_procfs_target::pid_to_str): Change return type.
3292         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3293         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3294         return type.
3295         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3296         (exit_lwp): Update.
3297         (attach_proc_task_lwp_callback, get_detach_signal)
3298         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3299         (linux_nat_target::resume, wait_lwp, stop_callback)
3300         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3301         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3302         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3303         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3304         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3305         type.
3306         (inf_ptrace_target::attach): Update.
3307         (inf_ptrace_target::files_info): Update.
3308         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3309         type.
3310         (go32_nat_target::pid_to_str): Change return type.
3311         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3312         (gnu_nat_target::wait): Update.
3313         (gnu_nat_target::wait): Update.
3314         (gnu_nat_target::resume): Update.
3315         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3316         (fbsd_nat_target::wait): Update.
3317         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3318         type.
3319         (darwin_nat_target::attach): Update.
3320         * corelow.c (class core_target) <pid_to_str>: Change return type.
3321         (core_target::pid_to_str): Change return type.
3322         * target.c (normal_pid_to_str): Change return type.
3323         (default_pid_to_str): Likewise.
3324         (target_pid_to_str): Change return type.
3325         (target_translate_tls_address): Update.
3326         (target_announce_detach): Update.
3327         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3328         return type.
3329         (bsd_uthread_target::pid_to_str): Change return type.
3330         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3331         type.
3332         (bsd_kvm_target::pid_to_str): Change return type.
3333         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3334         return type.
3335         (aix_thread_target::pid_to_str): Change return type.
3336         * target.h (struct target_ops) <pid_to_str>: Change return type.
3337         (target_pid_to_str, normal_pid_to_str): Likewise.
3338         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3339         type.
3340         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3341         type.
3342         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3343         return type.
3344         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3345         type.
3346         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3347         type.
3348         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3349         return type.
3350
3351 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3352
3353         * NEWS: Mention that the new default MI version is 3.  Mention
3354         changes to the output of commands and events that deal with
3355         multi-location breakpoints.
3356         * breakpoint.c: Include "mi/mi-out.h".
3357         (print_one_breakpoint): Change output syntax if using MI version
3358         >= 3.
3359         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3360         New.
3361         (mi_multi_location_breakpoint_output_fixed): New.
3362         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3363         (mi_cmd_fix_multi_location_breakpoint_output): New.
3364         (mi_multi_location_breakpoint_output_fixed): New.
3365         * mi/mi-cmds.c (mi_cmds): Register command
3366         -fix-multi-location-breakpoint-output.
3367         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3368         interpreter "mi".
3369
3370 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3371
3372         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3373         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3374         instantiate mi_ui_out based on interpreter name.
3375         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3376         * mi/mi-main.c (mi_load_progress): Likewise.
3377
3378 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3379
3380         * NEWS: Combine separate "New targets" sections for 8.3.
3381
3382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3383
3384         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3385         (ppcfbsd_init_abi): Install gdbarch
3386         "fetch_tls_load_module_address" and "get_thread_local_address"
3387         methods.
3388
3389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3390
3391         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3392         (riscv_fbsd_init_abi): Install gdbarch
3393         "fetch_tls_load_module_address" and "get_thread_local_address"
3394         methods.
3395
3396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3397
3398         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3399         (i386fbsd_init_abi): Install gdbarch
3400         "fetch_tls_load_module_address" and "get_thread_local_address"
3401         methods.
3402
3403 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3404
3405         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3406         (amd64fbsd_init_abi): Install gdbarch
3407         "fetch_tls_load_module_address" and "get_thread_local_address"
3408         methods.
3409
3410 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3411
3412         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3413         (struct fbsd_pspace_data): New type.
3414         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3415         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3416         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3417         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3418         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3419
3420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3421
3422         * gdbtypes.c (lookup_struct_elt): New function.
3423         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3424         * gdbtypes.h (struct struct_elt): New type.
3425         (lookup_struct_elt): New prototype.
3426
3427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3428
3429         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3430         remove disabled code block.
3431
3432 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3433
3434         * gdbarch.sh (get_thread_local_address): New method.
3435         * gdbarch.h, gdbarch.c: Regenerate.
3436         * target.c (target_translate_tls_address): Use
3437         gdbarch_get_thread_local_address if present instead of
3438         target::get_thread_local_address.
3439
3440 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3441
3442         * target.h (target::get_thread_local_address): Update comment.
3443
3444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3445
3446         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3447         objfile->separate_debug_objfile_backlink if not NULL.
3448
3449 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3450
3451         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3452         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3453         (amd64bsd_store_inferior_registers): Likewise.
3454         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3455         Enable segment base registers.
3456         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3457         PT_GETFSBASE and PT_GETGSBASE.
3458         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3459         PT_SETGSBASE.
3460         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3461         segment base registers.
3462         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3463
3464 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3465
3466         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3467         Update calls to i386_target_description to add 'segments'
3468         parameter.
3469         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3470         add segment base registers.
3471         * arch/i386.c (i386_create_target_description): Add 'segments'
3472         parameter to enable segment base registers.
3473         * arch/i386.h (i386_create_target_description): Likewise.
3474         * features/i386/32bit-segments.xml: New file.
3475         * features/i386/32bit-segments.c: Generate.
3476         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3477         call to i386_target_description to add 'segments' parameter.
3478         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3479         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3480         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3481         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3482         if feature is present.
3483         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3484         Add 'segments' parameter to call to i386_target_description.
3485         (i386_target_description): Add 'segments' parameter to enable
3486         segment base registers.
3487         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3488         to call to i386_target_description.
3489         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3490         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3491         Define I386_NUM_REGS.
3492         (i386_target_description): Add 'segments' parameter to enable
3493         segment base registers.
3494
3495 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3496
3497         PR/24325
3498         * source-cache.c: #undef open and close, to avoid unresolved
3499         externals during linking.
3500
3501 2019-03-12  Tom Tromey  <tromey@adacore.com>
3502
3503         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3504         const.  Add initializers.
3505         (_initialize_remote): Don't initialize ptid globals.
3506
3507 2019-03-12  Pedro Alves  <palves@redhat.com>
3508
3509         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3510
3511 2019-03-12  Pedro Alves  <palves@redhat.com>
3512
3513         * cp-name-parser.y (main): Remove unused 'len' variable.
3514
3515 2019-03-12  Tom Tromey  <tromey@adacore.com>
3516
3517         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3518         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3519
3520 2019-03-12  Tom Tromey  <tromey@adacore.com>
3521
3522         * linux-nat.c (iterate_over_lwps): Update.
3523         (stop_callback): Remove parameter.
3524         (stop_wait_callback, detach_callback, resume_set_callback)
3525         (select_singlestep_lwp_callback, set_ignore_sigint)
3526         (status_callback, resumed_callback, resume_clear_callback)
3527         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3528         data parameter.
3529         (linux_nat_target::detach, linux_nat_target::resume)
3530         (linux_stop_and_wait_all_lwps, select_event_lwp)
3531         (linux_nat_filter_event, linux_nat_wait_1)
3532         (linux_nat_target::kill, linux_nat_target::stop)
3533         (linux_nat_target::stop): Update.
3534         (linux_nat_resume_callback): Change type.
3535         (resume_stopped_resumed_lwps, count_events_callback)
3536         (select_event_lwp_callback): Likewise.
3537         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3538         * arm-linux-nat.c (struct update_registers_data): Remove.
3539         (update_registers_callback): Change type.
3540         (arm_linux_insert_hw_breakpoint1): Update.
3541         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3542         parameter.
3543         (x86_linux_dr_set_addr): Update.
3544         (x86_linux_dr_set_control): Update.
3545         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3546         (iterate_over_lwps): Use gdb::function_view.
3547         * nat/aarch64-linux-hw-point.c (struct
3548         aarch64_dr_update_callback_param): Remove.
3549         (debug_reg_change_callback): Change type.
3550         (aarch64_notify_debug_reg_change): Update.
3551         * s390-linux-nat.c (s390_refresh_per_info): Update.
3552
3553 2019-03-11  Tom Tromey  <tromey@adacore.com>
3554
3555         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3556         redundant assignment to "this_cu".
3557
3558 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3559
3560         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3561
3562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3563
3564         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3565         from...
3566         (rank_one_type): ... this.
3567
3568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3569
3570         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3571         from...
3572         (rank_one_type): ... this.
3573
3574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3575
3576         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3577         from...
3578         (rank_one_type): ... this.
3579
3580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3581
3582         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3583         from...
3584         (rank_one_type): ... this.
3585
3586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3587
3588         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3589         from...
3590         (rank_one_type): ... this.
3591
3592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3593
3594         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3595         from...
3596         (rank_one_type): ... this.
3597
3598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3599
3600         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3601         from...
3602         (rank_one_type): ... this.
3603
3604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3605
3606         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3607         from...
3608         (rank_one_type): ... this.
3609
3610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3611
3612         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3613         from...
3614         (rank_one_type): ... this.
3615
3616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3617
3618         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3619         from...
3620         (rank_one_type): ... this.
3621
3622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3623
3624         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3625         from...
3626         (rank_one_type): ... this.
3627
3628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3629
3630         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3631         from...
3632         (rank_one_type): ... this.
3633
3634 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3635
3636         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3637         inferior-events' shows the example events.
3638
3639 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3640
3641         Support styling on native MS-Windows console
3642
3643         PR/24315
3644         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3645         on MS-Windows if $TERM is not defined.
3646
3647         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3648
3649         * posix-hdep.c (gdb_console_fputs):
3650         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3651         functions.
3652         * ui-file.h (gdb_console_fputs): Add prototype.
3653
3654         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3655         back to fputs only if the former returns zero.
3656
3657 2019-03-07  Tom Tromey  <tom@tromey.com>
3658
3659         * symmisc.c (print_symbol_bcache_statistics): Update.
3660         (print_objfile_statistics): Update.
3661         * symfile.c (allocate_symtab): Update.
3662         * stabsread.c: Don't include bcache.h.
3663         * psymtab.h (struct psymbol_bcache): Don't declare.
3664         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3665         (psymbol_bcache_init, psymbol_bcache_free)
3666         (psymbol_bcache_get_bcache): Don't declare.
3667         * psymtab.c (struct psymbol_bcache): Remove.
3668         (psymtab_storage::psymtab_storage): Update.
3669         (psymtab_storage::~psymtab_storage): Update.
3670         (psymbol_bcache_init, psymbol_bcache_free)
3671         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3672         (add_psymbol_to_bcache): Update.
3673         (allocate_psymtab): Update.
3674         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3675         macro_cache>: No longer pointers.
3676         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3677         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3678         * macrotab.c (macro_bcache): Update.
3679         * macroexp.c: Don't include bcache.h.
3680         * gdbtypes.c (check_types_worklist): Update.
3681         (types_deeply_equal): Remove TRY/CATCH.  Update.
3682         * elfread.c (elf_symtab_read): Update.
3683         * dwarf2read.c: Don't include bcache.h.
3684         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3685         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3686         (print_bcache_statistics, bcache_memory_used): Don't declare.
3687         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3688         methods.  Rename all data members.
3689         * bcache.c (struct bcache): Move to bcache.h.
3690         (bcache::expand_hash_table): Rename from expand_hash_table.
3691         (bcache): Remove.
3692         (bcache::insert): Rename from bcache_full.
3693         (bcache::compare): Rename from bcache_compare.
3694         (bcache_xmalloc): Remove.
3695         (bcache::~bcache): Rename from bcache_xfree.
3696         (bcache::print_statistics): Rename from print_bcache_statistics.
3697         (bcache::memory_used): Rename from bcache_memory_used.
3698
3699 2019-03-07  Pedro Alves  <palves@redhat.com>
3700
3701         * infrun.c (normal_stop): Also check for
3702         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3703
3704 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * f-lang.c (value_from_host_double): Moved to...
3707         * value.c (value_from_host_double): ...here.
3708         * value.h (value_from_host_double): Declare.
3709         * guile/scm-math.c (vlscm_convert_typed_number): Use
3710         value_from_host_double.
3711         (vlscm_convert_number): Likewise.
3712         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3713         * python/py-value.c (convert_value_from_python): Likewise.
3714
3715 2019-03-06  Tom Tromey  <tom@tromey.com>
3716
3717         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3718
3719 2019-03-06  Tom Tromey  <tom@tromey.com>
3720
3721         * utils.h (free_current_contents): Don't declare.
3722         * utils.c (free_current_contents): Remove.
3723
3724 2019-03-06  Tom Tromey  <tom@tromey.com>
3725
3726         * top.c (quit_force): Update.
3727         * main.c (captured_command_loop): Update.
3728         * common/new-op.c (operator new): Update.
3729         * common/common-exceptions.c (struct catcher)
3730         <save_cleanup_chain>: Remove member.
3731         (exceptions_state_mc_init): Update.
3732         (exception_try_scope_entry): Return nullptr.
3733         (exception_try_scope_exit, exception_rethrow)
3734         (throw_exception_sjlj, throw_exception_cxx): Update.
3735         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3736         (all_cleanups, do_cleanups, discard_cleanups)
3737         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3738         (restore_cleanups, restore_final_cleanups): Don't declare.
3739         (do_final_cleanups): Remove parameter.
3740         * common/cleanups.c (cleanup_chain, make_cleanup)
3741         (make_cleanup_dtor, all_cleanups, do_cleanups)
3742         (discard_my_cleanups, discard_cleanups)
3743         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3744         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3745         (null_cleanup): Remove.
3746         (do_final_cleanups): Remove parameter.
3747
3748 2019-03-06  Tom Tromey  <tom@tromey.com>
3749
3750         * remote.c (remote_target::remote_parse_stop_reply): Use
3751         unique_xmalloc_ptr.
3752
3753 2019-03-06  Tom Tromey  <tom@tromey.com>
3754
3755         * stabsread.c (struct stabs_field_info): Rename from field_info.
3756         <list, fnlist>: Add initializers.
3757         <obstack>: New member.
3758         (read_member_functions, read_struct_fields, read_baseclasses):
3759         Allocate on obstack.  Don't use cleanups.
3760         (read_one_struct_field, read_member_functions, read_struct_fields)
3761         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3762         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3763         (read_struct_type): Update.
3764
3765 2019-03-06  Tom Tromey  <tom@tromey.com>
3766
3767         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3768         * common/filestuff.h (make_cleanup_close): Don't declare.
3769         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3770         Remove.
3771
3772 2019-03-06  Tom Tromey  <tom@tromey.com>
3773
3774         * solib-aix.c: Use make_scope_exit.
3775
3776 2019-03-06  Tom Tromey  <tom@tromey.com>
3777
3778         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3779         Use make_scope_exit.
3780
3781 2019-03-06  Tom Tromey  <tom@tromey.com>
3782
3783         * solib-svr4.c (disable_probes_interface): Remove parameter.
3784         (svr4_handle_solib_event): Use make_scope_exit.
3785
3786 2019-03-06  Tom Tromey  <tom@tromey.com>
3787
3788         * remote.c (struct stop_reply_deleter): Remove.
3789         (stop_reply_up): Update.
3790         (struct stop_reply): Derive from notif_event.  Don't typedef.
3791         <regcache>: Now a std::vector.
3792         (stop_reply_xfree): Remove.
3793         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3794         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3795         (remote_target::discard_pending_stop_replies): Use delete.
3796         (remote_target::remote_parse_stop_reply): Update.
3797         (remote_target::process_stop_reply): Update.
3798         * remote-notif.h (struct notif_event): Add virtual destructor.
3799         Remove "dtr" member.
3800         (struct notif_client) <alloc_event>: Return a unique_ptr.
3801         (notif_event_xfree): Don't declare.
3802         (notif_event_up): New typedef.
3803         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3804         (notif_event_xfree, do_notif_event_xfree): Remove.
3805         (remote_notif_state_xfree): Update.
3806
3807 2019-03-06  Tom Tromey  <tom@tromey.com>
3808
3809         * infrun.c (displaced_step_clear_cleanup): Now a
3810         forward_scope_exit type.
3811         (displaced_step_prepare_throw): Update.
3812         (displaced_step_fixup): Update.
3813
3814 2019-03-06  Tom Tromey  <tom@tromey.com>
3815
3816         * inferior.h (class inferior): Update comment.
3817         * gdbthread.h (class thread_info): Update comment.
3818
3819 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3820             Tom Tromey  <tom@tromey.com>
3821
3822         * stabsread.h (struct stab_section_list): Remove.
3823         (coffstab_build_psymtabs): Update.
3824         * dbxread.c (symbuf_sections): Now a std::vector.
3825         (sect_idx): New global.
3826         (fill_symbuf): Update.
3827         (coffstab_build_psymtabs): Change type of stabsects parameter.
3828         Update.
3829         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3830         std::vector.
3831         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3832         (coff_locate_sections): Update.
3833         (coff_symfile_read): Remove cleanups.  Update.
3834         (init_stringtab): Add storage parameter.
3835         (free_stringtab, free_stringtab_cleanup): Remove.
3836         (init_lineno): Add storage parameter.
3837         (free_linetab, free_linetab_cleanup): Remove.
3838
3839 2019-03-06  Pedro Alves  <palves@redhat.com>
3840
3841         * linux-fork.c (fork_info::clobber_regs): Delete.
3842         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3843         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3844         comment.  Adjust.
3845         (scoped_switch_fork_info::scoped_switch_fork_info)
3846         (checkpoint_command, linux_fork_context): Adjust
3847         fork_save_infrun_state calls.
3848
3849 2019-03-06  Pedro Alves  <palves@redhat.com>
3850
3851         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3852         (inf_has_multiple_threads): Return 'bool' and rewrite using
3853         inferior_info::threads().
3854
3855 2019-03-06  Pedro Alves  <palves@redhat.com>
3856
3857         * linux-fork.c: Include <list>.
3858         (fork_list): Now a std::list instance.
3859         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3860         (forks_exist_p, find_last_fork): Adjust.
3861         (new_fork): Delete.
3862         (one_fork_p): New.
3863         (add_fork): Adjust.
3864         (free_fork): Delete, folded into fork_info::~fork_info().
3865         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3866         Adjust.
3867         (init_fork_list): Delete.
3868         (linux_fork_killall, linux_fork_mourn_inferior)
3869         (linux_fork_detach, info_checkpoints_command): Adjust.
3870         (_initialize_linux_fork): No longer call init_fork_list.
3871
3872 2019-03-06  Pedro Alves  <palves@redhat.com>
3873
3874         * linux-fork.c (new_fork): New, split out of ...
3875         (add_fork): ... this.  Return void.  Move "first fork" special
3876         case from here, to ...
3877         (checkpoint_command): ... here.
3878         * linux-linux.h (add_fork): Return void.
3879
3880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3883
3884 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3885             Chris January  <chris.january@arm.com>
3886             David Lecomber  <david.lecomber@arm.com>
3887
3888         * f-exp.y: New token, UNOP_INTRINSIC.
3889         (exp): New pattern using UNOP_INTRINSIC token.
3890         (f77_keywords): Add 'abs' keyword.
3891         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3892         (value_from_host_double): New function.
3893         (evaluate_subexp_f): Support UNOP_ABS.
3894
3895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3898         types.
3899
3900 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3903         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3904         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3905
3906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3909
3910 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3911             Chris January  <chris.january@arm.com>
3912
3913         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3914         * f-exp.y: Define 'KIND' token.
3915         (exp): New pattern for KIND expressions.
3916         (ptype): Handle types with a kind extension.
3917         (direct_abs_decl): Extend to spot kind extensions.
3918         (f77_keywords): Add 'kind' to the list.
3919         (push_kind_type): New function.
3920         (convert_to_kind_type): New function.
3921         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3922         * parse.c (operator_length_standard): Likewise.
3923         * parser-defs.h (enum type_pieces): Add tp_kind.
3924         * std-operator.def: Add UNOP_KIND.
3925
3926 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * f-exp.y (f_parse): Set yydebug.
3929
3930 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * f-lang.c (evaluate_subexp_f): New function.
3933         (exp_descriptor_f): New global.
3934         (f_language_defn): Use exp_descriptor_f instead of
3935         exp_descriptor_standard.
3936
3937 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3938
3939         * f-exp.y (struct token): Add comments.
3940         (dot_ops): Remove uppercase versions and the end marker.
3941         (f77_keywords): Likewise.
3942         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3943         entries in the dot_ops array are case insensitive, and use
3944         strncasecmp to compare strings.  Also some whitespace cleanup in
3945         this area.  Similar for the f77_keywords array, except entries in
3946         this list might be case sensitive.
3947
3948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3949
3950         * f-exp.y (struct f77_boolean_val): Add comments.
3951         (boolean_values): Remove uppercase versions, and end marker.
3952         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3953         and use strncasecmp to achieve case insensitivity.  Additionally,
3954         perform whitespace cleanup around this code.
3955
3956 2019-03-06  Tom Tromey  <tromey@adacore.com>
3957
3958         * remote-sim.c (gdbsim_target_open): Use result of
3959         gdb_argv::release.
3960
3961 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3962         Dirk Schubert  <dirk.schubert@arm.com>
3963         Chris January  <chris.january@arm.com>
3964
3965         * eval.c (evaluate_subexp_standard): Call Fortran argument
3966         wrapping logic.
3967         * f-lang.c (struct value): A value which can be passed into a
3968         Fortran function call.
3969         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3970         where appropriate.
3971         (struct type): Value ready for a Fortran function call.
3972         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3973         is needed.
3974         * f-lang.h (fortran_argument_convert): Declaration.
3975         (fortran_preserve_arg_pointer): Declaration.
3976         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3977
3978 2019-03-05  Tom Tromey  <tromey@adacore.com>
3979
3980         * python/py-prettyprint.c (print_string_repr): Remove #if.
3981         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3982
3983 2019-03-05  Tom Tromey  <tromey@adacore.com>
3984
3985         * target.c (the_dummy_target): Move later.  Change type to
3986         "dummy_target".
3987         (initialize_targets): Don't initialize the_dummy_target.
3988
3989 2019-03-05  Tom Tromey  <tromey@adacore.com>
3990
3991         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3992         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3993
3994 2019-03-05  Tom Tromey  <tromey@adacore.com>
3995
3996         * windows-nat.c (windows_nat_target::attach)
3997         (windows_nat_target::detach): Don't call gdb_flush.
3998         * valprint.c (generic_val_print, val_print, val_print_string):
3999         Don't call gdb_flush.
4000         * utils.c (defaulted_query): Don't call gdb_flush.
4001         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4002         * target.c (target_announce_detach): Don't call gdb_flush.
4003         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4004         * remote.c (extended_remote_target::attach): Don't call
4005         gdb_flush.
4006         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4007         * printcmd.c (do_examine): Don't call gdb_flush.
4008         (info_display_command): Don't call gdb_flush.
4009         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4010         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4011         * memattr.c (info_mem_command): Don't call gdb_flush.
4012         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4013         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4014         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4015         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4016         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4017         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4018         (gnu_nat_target::detach): Don't call gdb_flush.
4019         * f-valprint.c (f_val_print): Don't call gdb_flush.
4020         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4021         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4022         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4023         gdb_flush.
4024         * c-valprint.c (c_val_print): Don't call gdb_flush.
4025         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4026
4027 2019-03-05  Tom Tromey  <tromey@adacore.com>
4028
4029         * varobj.c (update_dynamic_varobj_children): Update.
4030         (install_default_visualizer): Use reset, not release.
4031         * value.c (set_internalvar): Update.
4032         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4033         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4034         ATTRIBUTE_UNUSED_RESULT.
4035
4036 2019-03-05  Tom Tromey  <tromey@adacore.com>
4037
4038         * remote.c (class scoped_remote_fd) <release>: Add
4039         ATTRIBUTE_UNUSED_RESULT.
4040
4041 2019-03-05  Tom Tromey  <tromey@adacore.com>
4042
4043         * macroexp.c (struct macro_buffer) <release>: Add
4044         ATTRIBUTE_UNUSED_RESULT.
4045
4046 2019-03-05  Tom Tromey  <tromey@adacore.com>
4047
4048         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4049         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4050         ATTRIBUTE_UNUSED_RESULT.
4051
4052 2019-03-05  Tom Tromey  <tromey@adacore.com>
4053
4054         * common/scoped_fd.h (class scoped_fd) <release>: Add
4055         ATTRIBUTE_UNUSED_RESULT.
4056
4057 2019-03-05  Tom Tromey  <tromey@adacore.com>
4058
4059         * parser-defs.h (struct parser_state) <release>: Add
4060         ATTRIBUTE_UNUSED_RESULT.
4061
4062 2019-03-05  Tom Tromey  <tromey@adacore.com>
4063
4064         * utils.h (class gdb_argv) <release>: Add
4065         ATTRIBUTE_UNUSED_RESULT.
4066         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4067
4068 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4069
4070         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4071         for-loop range, to avoid compiler warnings.
4072
4073         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4074         avoid compiler warnings about unused variables.
4075
4076         * NEWS: Mention end of support for native debugging on MS-Windows
4077         before XP.
4078
4079         PR gdb/24292
4080         * common/netstuff.c:
4081         * gdbserver/gdbreplay.c
4082         * gdbserver/remote-utils.c:
4083         * ser-tcp.c:
4084         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4085         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4086         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4087         'getaddrinfo' and 'freeaddrinfo' were not available before
4088         Windows XP, and mingw.org's MinGW headers by default define
4089         _WIN32_WINNT to 0x500.
4090
4091 2019-03-01  Gary Benson <gbenson@redhat.com>
4092
4093         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4094
4095 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4096             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4097
4098         PR gdb/8527
4099         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4100         set_sigint_trap, clear_sigint_trap.
4101
4102 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4103
4104         * target.c (target_detach): Clear the regcache and the
4105         frame cache.
4106
4107 2019-02-27  Pedro Alves  <palves@redhat.com>
4108
4109         * utils.c (set_screen_size): When we cap the height/width sizes,
4110         tweak the corresponding command variable to show "unlimited":
4111
4112 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4113             Pedro Alves  <palves@redhat.com>
4114
4115         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4116         before calling rl_set_screen_size.
4117
4118 2019-02-27  Tom Tromey  <tromey@adacore.com>
4119
4120         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4121         define.
4122         * python/py-value.c: Remove Python 2.4 workaround.
4123         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4124         workaround.
4125         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4126         Python 2.4 workaround.
4127         * python/python-internal.h: Remove Python 2.4 comment.
4128         (Py_ssize_t): Don't define.
4129         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4130         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4131         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4132         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4133         * python/python.c (do_start_initialization): Remove Python 2.4
4134         workaround.
4135         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4136         (print_children): Remove Python 2.4 workaround.
4137         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4138         workaround.
4139         (CHARBUFFERPROC_NAME): Remove.
4140         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4141         Python 2.4 workaround.
4142
4143 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4144
4145         * NEWS: Note minimum Python version.
4146
4147 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4148
4149         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4150         code from these functions.  Remove corresponding ifdefs.  Use
4151         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4152         Remove gotos and target of gotos.
4153         (infpy_search_memory): Likewise.
4154
4155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4156
4157         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4158         (hppa_gdbarch_init): Don't register deleted functions with
4159         gdbarch.
4160
4161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4162
4163         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4164         (h8300_unwind_sp): Delete.
4165         (h8300_dummy_id): Delete.
4166         (h8300_gdbarch_init): Don't register deleted functions with
4167         gdbarch.
4168
4169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4170
4171         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4172         (ft32_unwind_pc): Delete.
4173         (ft32_unwind_sp): Delete.
4174         (ft32_gdbarch_init): Don't register deleted functions with
4175         gdbarch.
4176
4177 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4178
4179         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4180         (frv_unwind_pc): Delete.
4181         (frv_unwind_sp): Delete.
4182         (frv_gdbarch_init): Don't register deleted functions with
4183         gdbarch.
4184
4185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4186
4187         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4188         (riscv_unwind_pc): Delete.
4189         (riscv_unwind_sp): Delete.
4190         (riscv_gdbarch_init): Don't register deleted functions with
4191         gdbarch.
4192
4193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4196         (csky_unwind_pc): Delete.
4197         (csky_unwind_sp): Delete.
4198         (csky_gdbarch_init): Don't register deleted functions with
4199         gdbarch.
4200
4201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4202
4203         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4204         (cris_unwind_pc): Delete.
4205         (cris_unwind_sp): Delete.
4206         (cris_gdbarch_init): Don't register deleted functions with
4207         gdbarch.
4208
4209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4212         (bfin_unwind_pc): Delete.
4213         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4214
4215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4216
4217         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4218         (arm_unwind_pc): Delete.
4219         (arm_unwind_sp): Delete.
4220         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4221
4222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4225         (arc_unwind_pc): Delete.
4226         (arc_unwind_sp): Delete.
4227         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4228
4229 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4230
4231         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4232         (alpha_unwind_pc): Delete.
4233         (alpha_gdbarch_init): Don't register deleted functions with
4234         gdbarch.
4235
4236 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4237
4238         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4239         (aarch64_unwind_pc): Delete.
4240         (aarch64_unwind_sp): Delete.
4241         (aarch64_gdbarch_init): Don't register deleted functions with
4242         gdbarch.
4243
4244 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4245
4246         * gdbtypes.c (type_align): Don't consider static members when
4247         computing structure alignment.
4248
4249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4252         return 0 for other types.
4253         * arch-utils.c (default_type_align): Always return 0.
4254         * gdbarch.h: Regenerate.
4255         * gdbarch.sh (type_align): Extend comment.
4256         * gdbtypes.c (type_align): Add additional comments, always call
4257         gdbarch_type_align before applying the default rules.
4258         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4259         generic code will then apply a suitable default.
4260         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4261         types, return 0 for other types.
4262
4263 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4264
4265         * NEWS: Create a new section for the next release branch.
4266         Rename the section of the current branch, now that it has
4267         been cut.
4268
4269 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4270
4271         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4272         * version.in: Bump version to 8.3.50.DATE-git.
4273
4274 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4275
4276         * aix-thread.c (ptid_cmp): Remove unused variable.
4277         (get_signaled_thread): Likewise.
4278         (store_regs_user_thread): Likewise.
4279         (store_regs_kernel_thread): Likewise.
4280         (fetch_regs_kernel_thread): Remove shadowed variable.
4281
4282 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * features/riscv/32bit-cpu.xml: Add register numbers.
4285         * features/riscv/32bit-fpu.c: Regenerate.
4286         * features/riscv/32bit-fpu.xml: Add register numbers.
4287         * features/riscv/64bit-cpu.xml: Add register numbers.
4288         * features/riscv/64bit-fpu.c: Regenerate.
4289         * features/riscv/64bit-fpu.xml: Add register numbers.
4290
4291 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4292
4293         * NEWS: Mention two argument form of gdb.Value constructor.
4294         * python/py-value.c (convert_buffer_and_type_to_value): New
4295         function.
4296         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4297         Add support for handling an optional second argument.  Call
4298         convert_buffer_and_type_to_value as appropriate.
4299         * python/python-internal.h (Py_buffer_deleter): New struct.
4300         (Py_buffer_up): New typedef.
4301
4302 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4303
4304         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4305         instead of releasing ownership.
4306
4307 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4308
4309         * dwarf2read.c (open_and_init_dwp_file): Call
4310         elf_numsections instead of bfd_count_sections to initialize
4311         dwp_file->num_sections.
4312
4313 2019-02-25  Tom Tromey  <tromey@adacore.com>
4314
4315         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4316
4317 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4318
4319         * gcore.in: Add '--readnever' option when invoking GDB.
4320
4321 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4322
4323         * MAINTAINERS: Update my email address.
4324
4325 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4326
4327         * build-id.c (build_id_to_debug_bfd_1): New function.
4328         (build_id_to_debug_bfd): Look for separate debug file in
4329         sysroot.
4330
4331 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4332
4333         * gdbarch.sh: Update the copyright year range that is placed into
4334         generated files.
4335
4336 2019-02-22  Keith Seitz  <keiths@redhat.com>
4337
4338         PR symtab/23853
4339         * linespec.c (create_sals_line_offset): Search for the default
4340         symtab's filename instead of its fullname.
4341
4342 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4343
4344         * NEWS: Update style defaults.
4345
4346 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4347
4348         * main.c (captured_main_1): Disable styling in batch mode.
4349
4350 2019-02-20  Tom Tromey  <tom@tromey.com>
4351
4352         * symtab.c (symtab_symbol_info): Fix typos.
4353
4354 2019-02-20  Tom Tromey  <tromey@adacore.com>
4355
4356         * findcmd.c (_initialize_mem_search): Use upper case for
4357         metasyntactic variables.
4358
4359 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4360
4361         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4362         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4363
4364 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4365
4366         * top.h (source_file_name): Change to std::string.
4367         * top.c (source_file_name): Likewise.
4368         (command_line_input): Adjust.
4369         * cli/cli-script.c (script_from_file): Adjust.
4370
4371 2019-02-19  Tom Tromey  <tromey@adacore.com>
4372
4373         * ravenscar-thread.c
4374         (ravenscar_thread_target::update_thread_list): Don't call
4375         ada_build_task_list.
4376         * ada-lang.h (ada_build_task_list): Don't declare.
4377         * ada-tasks.c (struct ada_tasks_inferior_data)
4378         <task_list_valid_p>: Now bool.
4379         (read_known_tasks, ada_task_list_changed)
4380         (ada_tasks_invalidate_inferior_data): Update.
4381         (read_known_tasks_array): Return bool.
4382         (read_known_tasks_list): Likewise.
4383         (read_known_tasks): Return void.
4384         (ada_build_task_list): Now static.
4385
4386 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4387
4388         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4389         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4390
4391 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4392
4393         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4394         variant for ada_tasks_pspace_data_handle and
4395         ada_tasks_inferior_data_handle.
4396         (ada_tasks_pspace_data_cleanup): New function.
4397         (ada_tasks_inferior_data_cleanup): New function.
4398
4399 2019-02-17  Tom Tromey  <tom@tromey.com>
4400
4401         * macrotab.h (macro_source_fullname): Return a std::string.
4402         * macrotab.c (macro_include, check_for_redefinition)
4403         (macro_undef, macro_lookup_definition, foreach_macro)
4404         (foreach_macro_in_scope): Update.
4405         (macro_source_fullname): Return a std::string.
4406         * macrocmd.c (show_pp_source_pos): Update.
4407
4408 2019-02-17  Tom Tromey  <tom@tromey.com>
4409
4410         * macrocmd.c (show_pp_source_pos): Style the file names.
4411
4412 2019-02-17  Tom Tromey  <tom@tromey.com>
4413
4414         PR tui/24197:
4415         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4416
4417 2019-02-17  Tom Tromey  <tom@tromey.com>
4418
4419         * ada-lang.c (user_select_syms): Use filtered printing.
4420         * utils.c (wrap_style): New global.
4421         (desired_style): Remove.
4422         (emit_style_escape): Add stream parameter.
4423         (set_output_style, reset_terminal_style, prompt_for_continue):
4424         Update.
4425         (flush_wrap_buffer): Only flush gdb_stdout.
4426         (wrap_here): Set wrap_style.
4427         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4428         treat escape sequences as a character.  Change when wrap buffer is
4429         flushed.
4430         (fputs_styled): Do not set the output style when the default is
4431         requested.
4432         * ui-style.h (struct ui_file_style) <is_default>: New method.
4433         * source.c (print_source_lines_base): Emit escape sequences in one
4434         piece.
4435
4436 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4437
4438         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4439         integers and enumeration types.
4440
4441 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4442
4443         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4444         instead of lookup_symbol_in_language
4445         (do_exact_match): New function.
4446         (ada_get_symbol_name_matcher): Return do_exact_match when
4447         doing a verbatim match.
4448
4449 2019-02-15  Tom Tromey  <tromey@adacore.com>
4450
4451         * ravenscar-thread.c (ravenscar_thread_target::resume)
4452         (ravenscar_thread_target::wait): Special case wildcard requests.
4453
4454 2019-02-15  Tom Tromey  <tromey@adacore.com>
4455
4456         * ravenscar-thread.c (base_ptid): Remove.
4457         (struct ravenscar_thread_target) <close>: New method.
4458         <m_base_ptid>: New member.
4459         <update_inferior_ptid, active_task, task_is_currently_active,
4460         runtime_initialized>: Declare methods.
4461         <ravenscar_thread_target>: Add constructor.
4462         (ravenscar_thread_target::task_is_currently_active)
4463         (ravenscar_thread_target::update_inferior_ptid)
4464         (ravenscar_runtime_initialized): Rename.  Now methods.
4465         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4466         (ravenscar_thread_target::update_thread_list): Update.
4467         (ravenscar_thread_target::active_task): Now method.
4468         (ravenscar_thread_target::store_registers)
4469         (ravenscar_thread_target::prepare_to_store)
4470         (ravenscar_thread_target::prepare_to_store)
4471         (ravenscar_thread_target::mourn_inferior): Update.
4472         (ravenscar_inferior_created): Use "new" to create target.
4473         (ravenscar_thread_target::get_ada_task_ptid): Update.
4474         (_initialize_ravenscar): Don't initialize base_ptid.
4475         (ravenscar_ops): Remove global.
4476
4477 2019-02-15  Tom Tromey  <tromey@adacore.com>
4478
4479         * target.h (push_target): Declare new overload.
4480         * target.c (push_target): New overload, taking an rvalue reference.
4481         * remote.c (remote_target::open_1): Use push_target overload.
4482         * corelow.c (core_target_open): Use push_target overload.
4483
4484 2019-02-15  Tom Tromey  <tromey@adacore.com>
4485
4486         * ravenscar-thread.c (is_ravenscar_task)
4487         (ravenscar_task_is_currently_active): Return bool.
4488         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4489         (_initialize_ravenscar): Remove "(void)".
4490         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4491         Return bool.
4492
4493 2019-02-15  Tom Tromey  <tromey@adacore.com>
4494
4495         * ravenscar-thread.c (ravenscar_runtime_initializer)
4496         (has_ravenscar_runtime, get_running_thread_id)
4497         (ravenscar_thread_target::resume): Fix indentation.
4498
4499 2019-02-15  Tom Tromey  <tromey@adacore.com>
4500
4501         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4502         from ravenscar_arch_ops.
4503         (sparc_ravenscar_ops::fetch_registers)
4504         (sparc_ravenscar_ops::store_registers): Now methods.
4505         (sparc_ravenscar_prepare_to_store): Remove.
4506         (sparc_ravenscar_ops): Redefine.
4507         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4508         methods and destructor.  Remove members.
4509         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4510         (ravenscar_thread_target::store_registers)
4511         (ravenscar_thread_target::prepare_to_store): Update.
4512         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4513         Remove.
4514         (struct ppc_ravenscar_powerpc_ops): Derive from
4515         ravenscar_arch_ops.
4516         (ppc_ravenscar_powerpc_ops::fetch_registers)
4517         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4518         (ppc_ravenscar_powerpc_ops): Redefine.
4519         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4520         (ppc_ravenscar_e500_ops::fetch_registers)
4521         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4522         (ppc_ravenscar_e500_ops): Redefine.
4523         * aarch64-ravenscar-thread.c
4524         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4525         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4526         (aarch64_ravenscar_fetch_registers)
4527         (aarch64_ravenscar_store_registers): Now methods.
4528         (aarch64_ravenscar_ops): Redefine.
4529
4530 2019-02-15  Tom Tromey  <tromey@adacore.com>
4531
4532         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4533         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4534         (ravenscar_thread_target::stopped_by_watchpoint)
4535         (ravenscar_thread_target::stopped_data_address)
4536         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4537
4538 2019-02-15  Tom Tromey  <tromey@adacore.com>
4539
4540         * ravenscar-thread.c: Fix some typos.
4541
4542 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4543             Tom Tromey  <tromey@adacore.com>
4544
4545         * ada-lang.c (ada_exception_sal): Change addr_string to a
4546         std::string.
4547         (create_ada_exception_catchpoint): Update.
4548
4549 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4550             Tom Tromey  <tromey@adacore.com>
4551
4552         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4553         (bp_location_ops): Remove.
4554         (base_breakpoint_allocate_location): Update.
4555         (free_bp_location): Update.
4556         * ada-lang.c (class ada_catchpoint_location)
4557         <ada_catchpoint_location>: Remove ops parameter.
4558         (ada_catchpoint_location_dtor): Remove.
4559         (ada_catchpoint_location_ops): Remove.
4560         (allocate_location_exception): Update.
4561         * breakpoint.h (struct bp_location_ops): Remove.
4562         (class bp_location) <bp_location>: Remove bp_location_ops
4563         parameter.
4564         <~bp_location>: Add destructor.
4565         <ops>: Remove.
4566
4567 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4568             Pedro Alves  <palves@redhat.com>
4569
4570         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4571         'PATH_MAX'.
4572
4573 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4574             Samuel Thibault  <samuel.thibault@gnu.org>
4575             Thomas Schwinge  <thomas@codesourcery.com>
4576
4577         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4578         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4579
4580 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4581
4582         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4583         (check_empty): Use "const char *".
4584
4585         * gnu-nat.c (gnu_nat_target::detach): Instead of
4586         'detach_inferior (pid)' call
4587         'detach_inferior (find_inferior_pid (pid))'.
4588
4589         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4590         'nat/fork-inferior.o'.
4591         * gnu-nat.c: #include "nat/fork-inferior.h".
4592
4593         * gnu-nat.c (gnu_nat_target::detach): Instead of
4594         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4595         * gnu-nat.h: #include "inf-child.h".
4596         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4597         'i386_gnu_nat_target::fetch_registers'.
4598         (gnu_store_registers): Rename/move to
4599         'i386_gnu_nat_target::store_registers'.
4600
4601         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4602         * gnu-nat.h (mach_thread_info): New function.
4603         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4604
4605         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4606
4607 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4608
4609         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4610
4611 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4612
4613         * windows-nat.c (windows_add_thread): Add new parameter
4614         "main_thread_p" with default value set to false.  Update
4615         function documentation as well as all callers.
4616         (windows_delete_thread): Likewise.
4617         (fake_create_process): Update call to windows_add_thread.
4618         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4619         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4620         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4621         call to windows_delete_thread.
4622
4623 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4624
4625         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4626
4627 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4628
4629         * symfile.c (find_separate_debug_file): Use canonical path of
4630         sysroot with child_path instead of gdb_sysroot if it is valid.
4631
4632 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4633
4634         * symfile.c (find_separate_debug_file): Use child_path to
4635         determine if an object file is under a sysroot.
4636
4637 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4638
4639         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4640         unittests/child-path-selftests.c.
4641         * common/pathstuff.c (child_path): New function.
4642         * common/pathstuff.h (child_path): New prototype.
4643         * unittests/child-path-selftests.c: New file.
4644
4645 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4646
4647         * symfile.c (find_separate_debug_file): Look for separate debug
4648         files in debug directories under the sysroot.
4649
4650 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4651
4652         * symtab.h (struct minimal_symbol data_p): New const method.
4653         (struct minimal_symbol text_p): Likewise.
4654         * symtab.c (output_source_filename): Use file name style
4655         to print file name.
4656         (print_symbol_info): Likewise.
4657         (print_msymbol_info): Use address style to print addresses.
4658         Use function name style to print executable text symbols.
4659         (expand_symtab_containing_pc): Use data_p.
4660         (find_pc_sect_compunit_symtab): Likewise.
4661
4662 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4663
4664         * breakpoint.c (describe_other_breakpoints): Use address style
4665         to print addresses.
4666         (say_where): Likewise.
4667
4668 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4669
4670         * ada-typeprint.c (print_func_type): Print function name
4671         style to print function name.
4672         * c-typeprint.c (c_print_type_1): Likewise.
4673
4674 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4675
4676         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4677         for execve.
4678
4679 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4680
4681         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4682         type_stack.
4683
4684 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4685
4686         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4687         TYPE_CODE_REF types.
4688
4689 2019-02-08  Jim Wilson  <jimw@sifive.com>
4690
4691         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4692         (riscv_linux_fregset): New.
4693         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4694
4695 2019-02-07  Tom Tromey  <tom@tromey.com>
4696
4697         * thread.c (thread_cancel_execution_command): Update.
4698         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4699         methods.
4700         (struct thread_fsm_ops): Remove.
4701         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4702         (thread_fsm_should_stop, thread_fsm_return_value)
4703         (thread_fsm_set_finished, thread_fsm_finished_p)
4704         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4705         Don't declare.
4706         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4707         * infrun.c (clear_proceed_status_thread)
4708         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4709         (print_stop_event): Update.
4710         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4711         Add constructor.
4712         (step_command_fsm_ops): Remove.
4713         (new_step_command_fsm): Remove.
4714         (step_1): Update.
4715         (step_command_fsm::should_stop): Rename from
4716         step_command_fsm_should_stop.
4717         (step_command_fsm::clean_up): Rename from
4718         step_command_fsm_clean_up.
4719         (step_command_fsm::do_async_reply_reason): Rename from
4720         step_command_fsm_async_reply_reason.
4721         (struct until_next_fsm): Inherit from thread_fsm.  Add
4722         constructor.
4723         (until_next_fsm_ops): Remove.
4724         (new_until_next_fsm): Remove.
4725         (until_next_fsm::should_stop): Rename from
4726         until_next_fsm_should_stop.
4727         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4728         (until_next_fsm::do_async_reply_reason): Rename from
4729         until_next_fsm_async_reply_reason.
4730         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4731         constructor.  Change type of breakpoint.
4732         (finish_command_fsm_ops): Remove.
4733         (new_finish_command_fsm): Remove.
4734         (finish_command_fsm::should_stop): Rename from
4735         finish_command_fsm_should_stop.
4736         (finish_command_fsm::clean_up): Rename from
4737         finish_command_fsm_clean_up.
4738         (finish_command_fsm::return_value): Rename from
4739         finish_command_fsm_return_value.
4740         (finish_command_fsm::do_async_reply_reason): Rename from
4741         finish_command_fsm_async_reply_reason.
4742         (finish_command): Update.
4743         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4744         Add constructor.
4745         (call_thread_fsm_ops): Remove.
4746         (call_thread_fsm::call_thread_fsm): Rename from
4747         new_call_thread_fsm.
4748         (call_thread_fsm::should_stop): Rename from
4749         call_thread_fsm_should_stop.
4750         (call_thread_fsm::should_notify_stop): Rename from
4751         call_thread_fsm_should_notify_stop.
4752         (run_inferior_call, call_function_by_hand_dummy): Update.
4753         * cli/cli-interp.c (should_print_stop_to_console): Update.
4754         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4755         Add constructor.  Change type of location_breakpoint,
4756         caller_breakpoint.
4757         (until_break_fsm_ops): Remove.
4758         (new_until_break_fsm): Remove.
4759         (until_break_fsm::should_stop): Rename from
4760         until_break_fsm_should_stop.
4761         (until_break_fsm::clean_up): Rename from
4762         until_break_fsm_clean_up.
4763         (until_break_fsm::do_async_reply_reason): Rename from
4764         until_break_fsm_async_reply_reason.
4765         (until_break_command): Update.
4766         * thread-fsm.c: Remove.
4767         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4768
4769 2019-02-07  Tom Tromey  <tom@tromey.com>
4770
4771         * yy-remap.h: Add include guard.
4772         * xtensa-tdep.h: Add include guard.
4773         * xcoffread.h: Rename include guard.
4774         * varobj-iter.h: Add include guard.
4775         * tui/tui.h: Rename include guard.
4776         * tui/tui-winsource.h: Rename include guard.
4777         * tui/tui-wingeneral.h: Rename include guard.
4778         * tui/tui-windata.h: Rename include guard.
4779         * tui/tui-win.h: Rename include guard.
4780         * tui/tui-stack.h: Rename include guard.
4781         * tui/tui-source.h: Rename include guard.
4782         * tui/tui-regs.h: Rename include guard.
4783         * tui/tui-out.h: Rename include guard.
4784         * tui/tui-layout.h: Rename include guard.
4785         * tui/tui-io.h: Rename include guard.
4786         * tui/tui-hooks.h: Rename include guard.
4787         * tui/tui-file.h: Rename include guard.
4788         * tui/tui-disasm.h: Rename include guard.
4789         * tui/tui-data.h: Rename include guard.
4790         * tui/tui-command.h: Rename include guard.
4791         * tic6x-tdep.h: Add include guard.
4792         * target/waitstatus.h: Rename include guard.
4793         * target/wait.h: Rename include guard.
4794         * target/target.h: Rename include guard.
4795         * target/resume.h: Rename include guard.
4796         * target-float.h: Rename include guard.
4797         * stabsread.h: Add include guard.
4798         * rs6000-tdep.h: Add include guard.
4799         * riscv-fbsd-tdep.h: Add include guard.
4800         * regformats/regdef.h: Rename include guard.
4801         * record.h: Rename include guard.
4802         * python/python.h: Rename include guard.
4803         * python/python-internal.h: Rename include guard.
4804         * python/py-stopevent.h: Rename include guard.
4805         * python/py-ref.h: Rename include guard.
4806         * python/py-record.h: Rename include guard.
4807         * python/py-record-full.h: Rename include guard.
4808         * python/py-record-btrace.h: Rename include guard.
4809         * python/py-instruction.h: Rename include guard.
4810         * python/py-events.h: Rename include guard.
4811         * python/py-event.h: Rename include guard.
4812         * procfs.h: Add include guard.
4813         * proc-utils.h: Add include guard.
4814         * p-lang.h: Add include guard.
4815         * or1k-tdep.h: Rename include guard.
4816         * observable.h: Rename include guard.
4817         * nto-tdep.h: Rename include guard.
4818         * nat/x86-linux.h: Rename include guard.
4819         * nat/x86-linux-dregs.h: Rename include guard.
4820         * nat/x86-gcc-cpuid.h: Add include guard.
4821         * nat/x86-dregs.h: Rename include guard.
4822         * nat/x86-cpuid.h: Rename include guard.
4823         * nat/ppc-linux.h: Rename include guard.
4824         * nat/mips-linux-watch.h: Rename include guard.
4825         * nat/linux-waitpid.h: Rename include guard.
4826         * nat/linux-ptrace.h: Rename include guard.
4827         * nat/linux-procfs.h: Rename include guard.
4828         * nat/linux-osdata.h: Rename include guard.
4829         * nat/linux-nat.h: Rename include guard.
4830         * nat/linux-namespaces.h: Rename include guard.
4831         * nat/linux-btrace.h: Rename include guard.
4832         * nat/glibc_thread_db.h: Rename include guard.
4833         * nat/gdb_thread_db.h: Rename include guard.
4834         * nat/gdb_ptrace.h: Rename include guard.
4835         * nat/fork-inferior.h: Rename include guard.
4836         * nat/amd64-linux-siginfo.h: Rename include guard.
4837         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4838         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4839         * nat/aarch64-linux.h: Rename include guard.
4840         * nat/aarch64-linux-hw-point.h: Rename include guard.
4841         * mn10300-tdep.h: Add include guard.
4842         * mips-linux-tdep.h: Add include guard.
4843         * mi/mi-parse.h: Rename include guard.
4844         * mi/mi-out.h: Rename include guard.
4845         * mi/mi-main.h: Rename include guard.
4846         * mi/mi-interp.h: Rename include guard.
4847         * mi/mi-getopt.h: Rename include guard.
4848         * mi/mi-console.h: Rename include guard.
4849         * mi/mi-common.h: Rename include guard.
4850         * mi/mi-cmds.h: Rename include guard.
4851         * mi/mi-cmd-break.h: Rename include guard.
4852         * m2-lang.h: Add include guard.
4853         * location.h: Rename include guard.
4854         * linux-record.h: Rename include guard.
4855         * linux-nat.h: Add include guard.
4856         * linux-fork.h: Add include guard.
4857         * i386-darwin-tdep.h: Rename include guard.
4858         * hppa-linux-offsets.h: Add include guard.
4859         * guile/guile.h: Rename include guard.
4860         * guile/guile-internal.h: Rename include guard.
4861         * gnu-nat.h: Rename include guard.
4862         * gdb-stabs.h: Rename include guard.
4863         * frv-tdep.h: Add include guard.
4864         * f-lang.h: Add include guard.
4865         * event-loop.h: Add include guard.
4866         * darwin-nat.h: Rename include guard.
4867         * cp-abi.h: Rename include guard.
4868         * config/sparc/nm-sol2.h: Rename include guard.
4869         * config/nm-nto.h: Rename include guard.
4870         * config/nm-linux.h: Add include guard.
4871         * config/i386/nm-i386gnu.h: Rename include guard.
4872         * config/djgpp/nl_types.h: Rename include guard.
4873         * config/djgpp/langinfo.h: Rename include guard.
4874         * compile/gcc-cp-plugin.h: Add include guard.
4875         * compile/gcc-c-plugin.h: Add include guard.
4876         * compile/compile.h: Rename include guard.
4877         * compile/compile-object-run.h: Rename include guard.
4878         * compile/compile-object-load.h: Rename include guard.
4879         * compile/compile-internal.h: Rename include guard.
4880         * compile/compile-cplus.h: Rename include guard.
4881         * compile/compile-c.h: Rename include guard.
4882         * common/xml-utils.h: Rename include guard.
4883         * common/x86-xstate.h: Rename include guard.
4884         * common/version.h: Rename include guard.
4885         * common/vec.h: Rename include guard.
4886         * common/tdesc.h: Rename include guard.
4887         * common/selftest.h: Rename include guard.
4888         * common/scoped_restore.h: Rename include guard.
4889         * common/scoped_mmap.h: Rename include guard.
4890         * common/scoped_fd.h: Rename include guard.
4891         * common/safe-iterator.h: Rename include guard.
4892         * common/run-time-clock.h: Rename include guard.
4893         * common/refcounted-object.h: Rename include guard.
4894         * common/queue.h: Rename include guard.
4895         * common/ptid.h: Rename include guard.
4896         * common/print-utils.h: Rename include guard.
4897         * common/preprocessor.h: Rename include guard.
4898         * common/pathstuff.h: Rename include guard.
4899         * common/observable.h: Rename include guard.
4900         * common/netstuff.h: Rename include guard.
4901         * common/job-control.h: Rename include guard.
4902         * common/host-defs.h: Rename include guard.
4903         * common/gdb_wait.h: Rename include guard.
4904         * common/gdb_vecs.h: Rename include guard.
4905         * common/gdb_unlinker.h: Rename include guard.
4906         * common/gdb_unique_ptr.h: Rename include guard.
4907         * common/gdb_tilde_expand.h: Rename include guard.
4908         * common/gdb_sys_time.h: Rename include guard.
4909         * common/gdb_string_view.h: Rename include guard.
4910         * common/gdb_splay_tree.h: Rename include guard.
4911         * common/gdb_setjmp.h: Rename include guard.
4912         * common/gdb_ref_ptr.h: Rename include guard.
4913         * common/gdb_optional.h: Rename include guard.
4914         * common/gdb_locale.h: Rename include guard.
4915         * common/gdb_assert.h: Rename include guard.
4916         * common/filtered-iterator.h: Rename include guard.
4917         * common/filestuff.h: Rename include guard.
4918         * common/fileio.h: Rename include guard.
4919         * common/environ.h: Rename include guard.
4920         * common/common-utils.h: Rename include guard.
4921         * common/common-types.h: Rename include guard.
4922         * common/common-regcache.h: Rename include guard.
4923         * common/common-inferior.h: Rename include guard.
4924         * common/common-gdbthread.h: Rename include guard.
4925         * common/common-exceptions.h: Rename include guard.
4926         * common/common-defs.h: Rename include guard.
4927         * common/common-debug.h: Rename include guard.
4928         * common/cleanups.h: Rename include guard.
4929         * common/buffer.h: Rename include guard.
4930         * common/btrace-common.h: Rename include guard.
4931         * common/break-common.h: Rename include guard.
4932         * cli/cli-utils.h: Rename include guard.
4933         * cli/cli-style.h: Rename include guard.
4934         * cli/cli-setshow.h: Rename include guard.
4935         * cli/cli-script.h: Rename include guard.
4936         * cli/cli-interp.h: Rename include guard.
4937         * cli/cli-decode.h: Rename include guard.
4938         * cli/cli-cmds.h: Rename include guard.
4939         * charset-list.h: Add include guard.
4940         * buildsym-legacy.h: Rename include guard.
4941         * bfin-tdep.h: Add include guard.
4942         * ax.h: Rename include guard.
4943         * arm-linux-tdep.h: Add include guard.
4944         * arm-fbsd-tdep.h: Add include guard.
4945         * arch/xtensa.h: Rename include guard.
4946         * arch/tic6x.h: Add include guard.
4947         * arch/i386.h: Add include guard.
4948         * arch/arm.h: Rename include guard.
4949         * arch/arm-linux.h: Rename include guard.
4950         * arch/arm-get-next-pcs.h: Rename include guard.
4951         * arch/amd64.h: Add include guard.
4952         * arch/aarch64-insn.h: Rename include guard.
4953         * arch-utils.h: Rename include guard.
4954         * annotate.h: Add include guard.
4955         * amd64-darwin-tdep.h: Rename include guard.
4956         * aarch64-linux-tdep.h: Add include guard.
4957         * aarch64-fbsd-tdep.h: Add include guard.
4958         * aarch32-linux-nat.h: Add include guard.
4959
4960 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4961
4962         * macrotab.c (macro_define_internal): New function that
4963         factorizes macro_define_object_internal and macro_define_function
4964         code.
4965         (macro_define_object_internal): Use macro_define_internal.
4966         (macro_define_function): Likewise.
4967
4968 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4969
4970         * macrocmd.c (extract_identifier): Return
4971         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4972         callers.
4973
4974 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4975
4976         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4977
4978 2019-02-05  Tom Tromey  <tom@tromey.com>
4979
4980         * target.c (target_stack::unpush): Move assertion earlier.
4981
4982 2019-01-30  Tom Tromey  <tom@tromey.com>
4983
4984         PR python/23615:
4985         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4986         (gdbpy_parse_and_eval): Likewise.
4987         * python/python-internal.h (gdbpy_allow_threads): New class.
4988
4989 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4990
4991         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4992         (aarch64_fbsd_fpregmap): Move earlier.
4993         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4994         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4995         instead of individual calls to trad_frame_set_reg_addr.
4996         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4997         earlier.
4998         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4999         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5000         instead of individual calls to trad_frame_set_reg_addr.
5001
5002 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5003
5004         * CONTRIBUTE: Replace contribution list with wiki link.
5005
5006 2019-01-25  Tom Tromey  <tom@tromey.com>
5007
5008         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5009
5010 2019-01-25  Tom Tromey  <tom@tromey.com>
5011
5012         * xtensa-linux-nat.c: Fix common/ includes.
5013         * xml-support.h: Fix common/ includes.
5014         * xml-support.c: Fix common/ includes.
5015         * x86-linux-nat.c: Fix common/ includes.
5016         * windows-nat.c: Fix common/ includes.
5017         * varobj.h: Fix common/ includes.
5018         * varobj.c: Fix common/ includes.
5019         * value.c: Fix common/ includes.
5020         * valops.c: Fix common/ includes.
5021         * utils.c: Fix common/ includes.
5022         * unittests/xml-utils-selftests.c: Fix common/ includes.
5023         * unittests/utils-selftests.c: Fix common/ includes.
5024         * unittests/unpack-selftests.c: Fix common/ includes.
5025         * unittests/tracepoint-selftests.c: Fix common/ includes.
5026         * unittests/style-selftests.c: Fix common/ includes.
5027         * unittests/string_view-selftests.c: Fix common/ includes.
5028         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5029         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5030         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5031         * unittests/rsp-low-selftests.c: Fix common/ includes.
5032         * unittests/parse-connection-spec-selftests.c: Fix common/
5033         includes.
5034         * unittests/optional-selftests.c: Fix common/ includes.
5035         * unittests/offset-type-selftests.c: Fix common/ includes.
5036         * unittests/observable-selftests.c: Fix common/ includes.
5037         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5038         * unittests/memrange-selftests.c: Fix common/ includes.
5039         * unittests/memory-map-selftests.c: Fix common/ includes.
5040         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5041         * unittests/function-view-selftests.c: Fix common/ includes.
5042         * unittests/environ-selftests.c: Fix common/ includes.
5043         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5044         * unittests/common-utils-selftests.c: Fix common/ includes.
5045         * unittests/cli-utils-selftests.c: Fix common/ includes.
5046         * unittests/array-view-selftests.c: Fix common/ includes.
5047         * ui-file.c: Fix common/ includes.
5048         * tui/tui-io.c: Fix common/ includes.
5049         * tracepoint.h: Fix common/ includes.
5050         * tracepoint.c: Fix common/ includes.
5051         * tracefile-tfile.c: Fix common/ includes.
5052         * top.h: Fix common/ includes.
5053         * top.c: Fix common/ includes.
5054         * thread.c: Fix common/ includes.
5055         * target/waitstatus.h: Fix common/ includes.
5056         * target/waitstatus.c: Fix common/ includes.
5057         * target.h: Fix common/ includes.
5058         * target.c: Fix common/ includes.
5059         * target-memory.c: Fix common/ includes.
5060         * target-descriptions.c: Fix common/ includes.
5061         * symtab.h: Fix common/ includes.
5062         * symfile.c: Fix common/ includes.
5063         * stap-probe.c: Fix common/ includes.
5064         * spu-linux-nat.c: Fix common/ includes.
5065         * sparc-nat.c: Fix common/ includes.
5066         * source.c: Fix common/ includes.
5067         * solib.c: Fix common/ includes.
5068         * solib-target.c: Fix common/ includes.
5069         * ser-unix.c: Fix common/ includes.
5070         * ser-tcp.c: Fix common/ includes.
5071         * ser-pipe.c: Fix common/ includes.
5072         * ser-base.c: Fix common/ includes.
5073         * selftest-arch.c: Fix common/ includes.
5074         * s12z-tdep.c: Fix common/ includes.
5075         * rust-exp.y: Fix common/ includes.
5076         * rs6000-aix-tdep.c: Fix common/ includes.
5077         * riscv-tdep.c: Fix common/ includes.
5078         * remote.c: Fix common/ includes.
5079         * remote-notif.h: Fix common/ includes.
5080         * remote-fileio.h: Fix common/ includes.
5081         * remote-fileio.c: Fix common/ includes.
5082         * regcache.h: Fix common/ includes.
5083         * regcache.c: Fix common/ includes.
5084         * record-btrace.c: Fix common/ includes.
5085         * python/python.c: Fix common/ includes.
5086         * python/py-type.c: Fix common/ includes.
5087         * python/py-inferior.c: Fix common/ includes.
5088         * progspace.h: Fix common/ includes.
5089         * producer.c: Fix common/ includes.
5090         * procfs.c: Fix common/ includes.
5091         * proc-api.c: Fix common/ includes.
5092         * printcmd.c: Fix common/ includes.
5093         * ppc-linux-nat.c: Fix common/ includes.
5094         * parser-defs.h: Fix common/ includes.
5095         * osdata.c: Fix common/ includes.
5096         * obsd-nat.c: Fix common/ includes.
5097         * nat/x86-linux.c: Fix common/ includes.
5098         * nat/x86-linux-dregs.c: Fix common/ includes.
5099         * nat/x86-dregs.h: Fix common/ includes.
5100         * nat/x86-dregs.c: Fix common/ includes.
5101         * nat/ppc-linux.c: Fix common/ includes.
5102         * nat/mips-linux-watch.h: Fix common/ includes.
5103         * nat/mips-linux-watch.c: Fix common/ includes.
5104         * nat/linux-waitpid.c: Fix common/ includes.
5105         * nat/linux-ptrace.h: Fix common/ includes.
5106         * nat/linux-ptrace.c: Fix common/ includes.
5107         * nat/linux-procfs.c: Fix common/ includes.
5108         * nat/linux-personality.c: Fix common/ includes.
5109         * nat/linux-osdata.c: Fix common/ includes.
5110         * nat/linux-namespaces.c: Fix common/ includes.
5111         * nat/linux-btrace.h: Fix common/ includes.
5112         * nat/linux-btrace.c: Fix common/ includes.
5113         * nat/fork-inferior.c: Fix common/ includes.
5114         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5115         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5116         * nat/aarch64-linux.c: Fix common/ includes.
5117         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5118         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5119         * namespace.h: Fix common/ includes.
5120         * mips-linux-tdep.c: Fix common/ includes.
5121         * minsyms.c: Fix common/ includes.
5122         * mi/mi-parse.h: Fix common/ includes.
5123         * mi/mi-main.c: Fix common/ includes.
5124         * mi/mi-cmd-env.c: Fix common/ includes.
5125         * memrange.h: Fix common/ includes.
5126         * memattr.c: Fix common/ includes.
5127         * maint.h: Fix common/ includes.
5128         * maint.c: Fix common/ includes.
5129         * main.c: Fix common/ includes.
5130         * machoread.c: Fix common/ includes.
5131         * location.c: Fix common/ includes.
5132         * linux-thread-db.c: Fix common/ includes.
5133         * linux-nat.c: Fix common/ includes.
5134         * linux-fork.c: Fix common/ includes.
5135         * inline-frame.c: Fix common/ includes.
5136         * infrun.c: Fix common/ includes.
5137         * inflow.c: Fix common/ includes.
5138         * inferior.h: Fix common/ includes.
5139         * inferior.c: Fix common/ includes.
5140         * infcmd.c: Fix common/ includes.
5141         * inf-ptrace.c: Fix common/ includes.
5142         * inf-child.c: Fix common/ includes.
5143         * ia64-linux-nat.c: Fix common/ includes.
5144         * i387-tdep.c: Fix common/ includes.
5145         * i386-tdep.c: Fix common/ includes.
5146         * i386-linux-tdep.c: Fix common/ includes.
5147         * i386-linux-nat.c: Fix common/ includes.
5148         * i386-go32-tdep.c: Fix common/ includes.
5149         * i386-fbsd-tdep.c: Fix common/ includes.
5150         * i386-fbsd-nat.c: Fix common/ includes.
5151         * guile/scm-type.c: Fix common/ includes.
5152         * guile/guile.c: Fix common/ includes.
5153         * go32-nat.c: Fix common/ includes.
5154         * gnu-nat.c: Fix common/ includes.
5155         * gdbthread.h: Fix common/ includes.
5156         * gdbarch-selftests.c: Fix common/ includes.
5157         * gdb_usleep.c: Fix common/ includes.
5158         * gdb_select.h: Fix common/ includes.
5159         * gdb_bfd.c: Fix common/ includes.
5160         * gcore.c: Fix common/ includes.
5161         * fork-child.c: Fix common/ includes.
5162         * findvar.c: Fix common/ includes.
5163         * fbsd-nat.c: Fix common/ includes.
5164         * event-top.c: Fix common/ includes.
5165         * event-loop.c: Fix common/ includes.
5166         * dwarf2read.c: Fix common/ includes.
5167         * dwarf2loc.c: Fix common/ includes.
5168         * dwarf2-frame.c: Fix common/ includes.
5169         * dwarf-index-cache.c: Fix common/ includes.
5170         * dtrace-probe.c: Fix common/ includes.
5171         * disasm-selftests.c: Fix common/ includes.
5172         * defs.h: Fix common/ includes.
5173         * csky-tdep.c: Fix common/ includes.
5174         * cp-valprint.c: Fix common/ includes.
5175         * cp-support.h: Fix common/ includes.
5176         * cp-support.c: Fix common/ includes.
5177         * corelow.c: Fix common/ includes.
5178         * completer.h: Fix common/ includes.
5179         * completer.c: Fix common/ includes.
5180         * compile/compile.c: Fix common/ includes.
5181         * compile/compile-loc2c.c: Fix common/ includes.
5182         * compile/compile-cplus-types.c: Fix common/ includes.
5183         * compile/compile-cplus-symbols.c: Fix common/ includes.
5184         * command.h: Fix common/ includes.
5185         * cli/cli-dump.c: Fix common/ includes.
5186         * cli/cli-cmds.c: Fix common/ includes.
5187         * charset.c: Fix common/ includes.
5188         * build-id.c: Fix common/ includes.
5189         * btrace.h: Fix common/ includes.
5190         * btrace.c: Fix common/ includes.
5191         * breakpoint.h: Fix common/ includes.
5192         * breakpoint.c: Fix common/ includes.
5193         * ax.h:
5194         (enum agent_op): Fix common/ includes.
5195         * ax-general.c (struct aop_map): Fix common/ includes.
5196         * ax-gdb.c: Fix common/ includes.
5197         * auxv.c: Fix common/ includes.
5198         * auto-load.c: Fix common/ includes.
5199         * arm-tdep.c: Fix common/ includes.
5200         * arch/riscv.c: Fix common/ includes.
5201         * arch/ppc-linux-common.c: Fix common/ includes.
5202         * arch/i386.c: Fix common/ includes.
5203         * arch/arm.c: Fix common/ includes.
5204         * arch/arm-linux.c: Fix common/ includes.
5205         * arch/arm-get-next-pcs.c: Fix common/ includes.
5206         * arch/amd64.c: Fix common/ includes.
5207         * arch/aarch64.c: Fix common/ includes.
5208         * arch/aarch64-insn.c: Fix common/ includes.
5209         * arch-utils.c: Fix common/ includes.
5210         * amd64-windows-tdep.c: Fix common/ includes.
5211         * amd64-tdep.c: Fix common/ includes.
5212         * amd64-sol2-tdep.c: Fix common/ includes.
5213         * amd64-obsd-tdep.c: Fix common/ includes.
5214         * amd64-nbsd-tdep.c: Fix common/ includes.
5215         * amd64-linux-tdep.c: Fix common/ includes.
5216         * amd64-linux-nat.c: Fix common/ includes.
5217         * amd64-fbsd-tdep.c: Fix common/ includes.
5218         * amd64-fbsd-nat.c: Fix common/ includes.
5219         * amd64-dicos-tdep.c: Fix common/ includes.
5220         * amd64-darwin-tdep.c: Fix common/ includes.
5221         * agent.c: Fix common/ includes.
5222         * ada-lang.h: Fix common/ includes.
5223         * ada-lang.c: Fix common/ includes.
5224         * aarch64-tdep.c: Fix common/ includes.
5225
5226 2019-01-25  Tom Tromey  <tom@tromey.com>
5227
5228         * common/create-version.sh: Use common/version.h.
5229
5230 2019-01-24  Pedro Alves  <palves@redhat.com>
5231
5232         * infrun.c (signal_stop, signal_print, signal_program)
5233         (signal_catch, signal_pass): Now arrays instead of pointers.
5234         (update_signals_program_target, do_target_resume)
5235         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5236         * linux-nat.c (linux_nat_target::pass_signals)
5237         (linux_nat_target::create_inferior, linux_nat_target::attach):
5238         Adjust.
5239         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5240         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5241         * procfs.c (procfs_target::pass_signals): Adjust.
5242         * record-full.c (record_full_target::resume): Adjust.
5243         * remote.c (remote_target::pass_signals)
5244         (remote_target::program_signals): Adjust.
5245         * target-debug.h (target_debug_print_signals): Now takes a
5246         gdb::array_view as parameter.  Adjust.
5247         * target.h (target_ops) <pass_signals, program_signals>: Replace
5248         pointer and length parameters with gdb::array_view.
5249         (target_pass_signals, target_program_signals): Likewise.
5250         * target-delegates.c: Regenerate.
5251
5252 2019-01-24  Pedro Alves  <palves@redhat.com>
5253
5254         * common/forward-scope-exit.h
5255         (forward_scope_exit::forward_scope_exit): Pass arguments to
5256         m_bind_function directly, instead of creating a std::bind and
5257         copying that.
5258
5259 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5260
5261         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5262         for static members.
5263         (pass_in_v_vfp_candidate): Likewise.
5264
5265 2019-01-23  Tom Tromey  <tom@tromey.com>
5266             Pedro Alves  <palves@redhat.com>
5267
5268         * regcache.c (class regcache_invalidator): Remove.
5269         (regcache::raw_write): Use make_scope_exit.
5270
5271 2019-01-23  Tom Tromey  <tom@tromey.com>
5272
5273         * ui-out.h (class ui_out_emit_type): Update comment.
5274
5275 2019-01-23  Tom Tromey  <tom@tromey.com>
5276
5277         * infrun.c (fetch_inferior_event): Update comment.
5278
5279 2019-01-23  Tom Tromey  <tom@tromey.com>
5280             Pedro Alves  <palves@redhat.com>
5281
5282         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5283         parameter.
5284         (fetch_inferior_event): Use SCOPE_EXIT.
5285
5286
5287 2019-01-23  Tom Tromey  <tom@tromey.com>
5288             Pedro Alves  <palves@redhat.com>
5289
5290         * infrun.c (disable_thread_events): Delete.
5291         (stop_all_threads): Use SCOPE_EXIT.
5292
5293 2019-01-23  Tom Tromey  <tom@tromey.com>
5294             Pedro Alves  <palves@redhat.com>
5295
5296         * symfile.c: Include forward-scope-exit.h.
5297         (clear_symtab_users_cleanup): Replace forward declaration with
5298         a FORWARD_SCOPE_EXIT.
5299         (syms_from_objfile_1): Use the forward_scope_exit and
5300         gdb::optional instead of cleanup_function.
5301         (reread_symbols): Use the forward_scope_exit instead of
5302         cleanup_function.
5303         (clear_symtab_users_cleanup): Remove function.
5304
5305 2019-01-23  Tom Tromey  <tom@tromey.com>
5306             Pedro Alves  <palves@redhat.com>
5307
5308         * linux-nat.c: Include scope-exit.h.
5309         (cleanup_target_stop): Remove.
5310         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5311         SCOPE_EXIT.
5312
5313 2019-01-23  Tom Tromey  <tom@tromey.com>
5314             Pedro Alves  <palves@redhat.com>
5315
5316         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5317         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5318
5319 2019-01-23  Tom Tromey  <tom@tromey.com>
5320             Andrew Burgess  <andrew.burgess@embecosm.com>
5321             Pedro Alves  <palves@redhat.com>
5322
5323         * infrun.c (fetch_inferior_event): Use scope_exit.
5324         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5325         * top.c (execute_command): Use scope_exit.
5326         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5327         * utils.c (do_bpstat_clear_actions_cleanup)
5328         (make_bpstat_clear_actions_cleanup): Remove.
5329
5330 2019-01-23  Tom Tromey  <tom@tromey.com>
5331             Pedro Alves  <palves@redhat.com>
5332
5333         * infrun.c: Include "common/scope-exit.h"
5334         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5335         (wait_for_inferior): Use SCOPE_EXIT.
5336         (fetch_inferior_event): Use scope_exit.
5337
5338 2019-01-23  Tom Tromey  <tom@tromey.com>
5339             Pedro Alves  <palves@redhat.com>
5340
5341         * breakpoint.c (create_breakpoint): Remove cleanup.
5342
5343 2019-01-23  Tom Tromey  <tom@tromey.com>
5344             Andrew Burgess  <andrew.burgess@embecosm.com>
5345             Pedro Alves  <palves@redhat.com>
5346
5347 2019-01-23  Pedro Alves  <palves@redhat.com>
5348
5349         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5350
5351 2019-01-23  Pedro Alves  <palves@redhat.com>
5352             Andrew Burgess  <andrew.burgess@embecosm.com>
5353
5354         * gdbthread.h: Include "common/forward-scope-exit.h".
5355         (scoped_finish_thread_state): Redefine custom class in terms of
5356         forward_scope_exit.
5357
5358 2019-01-23  Pedro Alves  <palves@redhat.com>
5359             Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * common/forward-scope-exit.h: New file.
5362
5363 2019-01-23  Pedro Alves  <palves@redhat.com>
5364             Andrew Burgess  <andrew.burgess@embecosm.com>
5365             Tom Tromey  <tom@tromey.com>
5366
5367         * common/scope-exit.h: New file.
5368
5369 2019-01-23  Pedro Alves  <palves@redhat.com>
5370
5371         * common/preprocessor.h (ESC): Rename to ...
5372         (ESC_PARENS): ... this.
5373         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5374         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5375
5376 2019-01-23  Tom Tromey  <tom@tromey.com>
5377
5378         * language.h (class scoped_switch_to_sym_language_if_auto):
5379         Initialize m_lang in both cases.
5380
5381 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5382
5383         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5384         with XCNEW.
5385
5386 2019-01-22  Tom Tromey  <tom@tromey.com>
5387
5388         * corelow.c: Do not include sys/file.h.
5389
5390 2019-01-22  Tom Tromey  <tom@tromey.com>
5391
5392         * tui/tui-wingeneral.h: Include gdb_curses.h.
5393
5394 2019-01-22  Tom Tromey  <tom@tromey.com>
5395
5396         * source-cache.h (class source_cache) <get_source_lines,
5397         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5398
5399 2019-01-22  Tom Tromey  <tom@tromey.com>
5400
5401         * remote-fileio.h (struct remote_target): Declare.
5402
5403 2019-01-22  Tom Tromey  <tom@tromey.com>
5404
5405         * python/py-arch.c: Do not include py-ref.h.
5406         * python/py-bpevent.c: Do not include py-ref.h.
5407         * python/py-cmd.c: Do not include py-ref.h.
5408         * python/py-continueevent.c: Do not include py-ref.h.
5409         * python/py-event.h: Do not include py-ref.h.
5410         * python/py-evtregistry.c: Do not include py-ref.h.
5411         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5412         * python/py-frame.c: Do not include py-ref.h.
5413         * python/py-framefilter.c: Do not include py-ref.h.
5414         * python/py-function.c: Do not include py-ref.h.
5415         * python/py-infevents.c: Do not include py-ref.h.
5416         * python/py-linetable.c: Do not include py-ref.h.
5417         * python/py-objfile.c: Do not include py-ref.h.
5418         * python/py-param.c: Do not include py-ref.h.
5419         * python/py-prettyprint.c: Do not include py-ref.h.
5420         * python/py-progspace.c: Do not include py-ref.h.
5421         * python/py-symbol.c: Do not include py-ref.h.
5422         * python/py-symtab.c: Do not include py-ref.h.
5423         * python/py-type.c: Do not include py-ref.h.
5424         * python/py-unwind.c: Do not include py-ref.h.
5425         * python/py-utils.c: Do not include py-ref.h.
5426         * python/py-value.c: Do not include py-ref.h.
5427         * python/py-varobj.c: Do not include py-ref.h.
5428         * python/py-xmethods.c: Do not include py-ref.h.
5429         * python/python.c: Do not include py-ref.h.
5430         * varobj.c: Do not include py-ref.h.
5431
5432 2019-01-22  Tom Tromey  <tom@tromey.com>
5433
5434         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5435         keyword for bcache.
5436
5437 2019-01-22  Tom Tromey  <tom@tromey.com>
5438
5439         * compile/compile-cplus-types.c: Remove a comment by #include.
5440
5441 2019-01-22  Tom Tromey  <tom@tromey.com>
5442
5443         * compile/gcc-c-plugin.h: Include compile-internal.h.
5444
5445 2019-01-22  Tom Tromey  <tom@tromey.com>
5446
5447         * stabsread.c (EXTERN): Do not define.
5448         (symnum, next_symbol_text_func, processing_gcc_compilation)
5449         (within_function, global_sym_chain, global_stabs)
5450         (previous_stab_code, this_object_header_files)
5451         (n_this_object_header_files)
5452         (n_allocated_this_object_header_files): Define.
5453         * stabsread.h (EXTERN): Never define.  Use "extern".
5454
5455 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5456
5457         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5458         history_value.
5459
5460 2019-01-21  Tom Tromey  <tom@tromey.com>
5461
5462         * ui-out.c: Fix includes.
5463         * tui/tui-source.c: Fix includes.
5464         * target.c: Fix includes.
5465         * remote.c: Fix includes.
5466         * regcache.c: Fix includes.
5467         * python/py-block.c: Fix includes.
5468         * printcmd.c: Fix includes.
5469         * or1k-tdep.c: Fix includes.
5470         * mi/mi-main.c: Fix includes.
5471         * m32r-tdep.c: Fix includes.
5472         * csky-tdep.c: Fix includes.
5473         * compile/compile-cplus-types.c: Fix includes.
5474         * cli/cli-interp.c: Fix includes.
5475
5476 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5477
5478         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5479         for padding.
5480
5481 2019-01-16  Tom Tromey  <tom@tromey.com>
5482
5483         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5484         earlier.
5485         (struct objfile) <msymbols_range>: Move from top level.
5486         <msymbols>: New method.
5487         (class objfile_msymbols): Remove.
5488         * symtab.c (default_collect_symbol_completion_matches_break_on):
5489         Update.
5490         * symmisc.c (dump_msymbols): Update.
5491         * stabsread.c (scan_file_globals): Update.
5492         * objc-lang.c (info_selectors_command, info_classes_command)
5493         (find_methods): Update.
5494         * minsyms.c (find_solib_trampoline_target): Update.
5495         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5496         * coffread.c (coff_symfile_read): Update.
5497         * ada-lang.c (ada_lookup_simple_minsym)
5498         (ada_collect_symbol_completion_matches): Update.
5499
5500 2019-01-16  Tom Tromey  <tom@tromey.com>
5501
5502         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5503         type.  Remove no-argument constructor.
5504         <iterator::operator++>: Simplify.
5505         <begin>: Update.
5506         <end>: Use minimal_symbol_count.
5507
5508 2019-01-16  Tom Tromey  <tom@tromey.com>
5509
5510         * objfiles.h (struct objfile) <psymtabs>: New method.
5511         (class objfile_psymtabs): Remove.
5512         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5513         typedef.
5514         <range>: New method.
5515         (require_partial_symbols): Change return type.
5516         * psymtab.c (require_partial_symbols)
5517         (psym_expand_symtabs_matching): Update.
5518         * mdebugread.c (parse_partial_symbols): Update.
5519         * dbxread.c (dbx_end_psymtab): Update.
5520
5521 2019-01-15  Tom Tromey  <tom@tromey.com>
5522
5523         * symtab.c (lookup_objfile_from_block)
5524         (lookup_symbol_in_objfile_symtabs)
5525         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5526         (find_line_symtab, info_sources_command)
5527         (default_collect_symbol_completion_matches_break_on)
5528         (make_source_files_completion_list): Update.
5529         * symmisc.c (print_objfile_statistics, dump_objfile)
5530         (maintenance_print_symbols, maintenance_info_symtabs)
5531         (maintenance_check_symtabs, maintenance_info_line_tables):
5532         Update.
5533         * source.c (select_source_symtab)
5534         (forget_cached_source_info_for_objfile): Update.
5535         * objfiles.h (class objfile_compunits): Remove.
5536         (struct objfile) <compunits_range>: New typedef.
5537         (compunits): New method.
5538         * objfiles.c (objfile_relocate1): Update.
5539         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5540         * maint.c (count_symtabs_and_blocks): Update.
5541         * linespec.c (iterate_over_all_matching_symtabs): Update.
5542         * cp-support.c (add_symbol_overload_list_qualified): Update.
5543         * coffread.c (coff_symtab_read): Update.
5544         * ada-lang.c (add_nonlocal_symbols)
5545         (ada_collect_symbol_completion_matches)
5546         (ada_add_global_exceptions): Update.
5547
5548 2019-01-15  Tom Tromey  <tom@tromey.com>
5549
5550         * progspace.h (program_space) <objfiles_safe_range>: New
5551         typedef.
5552         <objfiles_safe>: New method.
5553         * objfiles.h (class all_objfiles_safe): Remove.
5554         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5555         * jit.c (jit_inferior_exit_hook): Update.
5556
5557 2019-01-17  Tom Tromey  <tom@tromey.com>
5558
5559         * progspace.h (program_space) <objfiles_range>: New typedef.
5560         <objfiles>: New method.
5561         <objfiles_head>: Rename from objfiles.
5562         (object_files): Update.
5563         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5564         * guile/scm-pretty-print.c
5565         (ppscm_find_pretty_printer_from_objfiles): Update.
5566         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5567         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5568         Update.
5569         * python/py-progspace.c (pspy_get_objfiles): Update.
5570         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5571         Update.
5572         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5573         (objfpy_lookup_objfile_by_build_id): Update.
5574         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5575         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5576         Update.
5577         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5578         (expand_symtab_containing_pc, lookup_objfile_from_block)
5579         (lookup_static_symbol, basic_lookup_transparent_type)
5580         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5581         (find_line_symtab, info_sources_command)
5582         (default_collect_symbol_completion_matches_break_on)
5583         (make_source_files_completion_list, find_main_name): Update.
5584         * symmisc.c (print_symbol_bcache_statistics)
5585         (print_objfile_statistics, maintenance_print_symbols)
5586         (maintenance_print_msymbols, maintenance_print_objfiles)
5587         (maintenance_info_symtabs, maintenance_check_symtabs)
5588         (maintenance_expand_symtabs, maintenance_info_line_tables):
5589         Update.
5590         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5591         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5592         (map_overlay_command, unmap_overlay_command)
5593         (simple_overlay_update, expand_symtabs_matching)
5594         (map_symbol_filenames): Update.
5595         * symfile-debug.c (set_debug_symfile): Update.
5596         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5597         Update.
5598         * source.c (select_source_symtab, forget_cached_source_info):
5599         Update.
5600         * solib.c (solib_read_symbols): Update.
5601         * solib-spu.c (append_ocl_sos): Update.
5602         * psymtab.c (maintenance_print_psymbols)
5603         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5604         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5605         * printcmd.c (info_symbol_command): Update.
5606         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5607         Update.
5608         * objfiles.h (class all_objfiles): Remove.
5609         * objfiles.c (have_partial_symbols, have_full_symbols)
5610         (have_minimal_symbols, qsort_cmp, update_section_map)
5611         (shared_objfile_contains_address_p)
5612         (default_iterate_over_objfiles_in_search_order): Update.
5613         * objc-lang.c (info_selectors_command, info_classes_command)
5614         (find_methods): Update.
5615         * minsyms.c (find_solib_trampoline_target): Update.
5616         * maint.c (maintenance_info_sections)
5617         (maintenance_translate_address, count_symtabs_and_blocks):
5618         Update.
5619         * main.c (captured_main_1): Update.
5620         * linux-thread-db.c (try_thread_db_load_from_pdir)
5621         (has_libpthread): Update.
5622         * linespec.c (iterate_over_all_matching_symtabs)
5623         (search_minsyms_for_name): Update.
5624         * jit.c (jit_find_objf_with_entry_addr): Update.
5625         * hppa-tdep.c (find_unwind_entry)
5626         (hppa_lookup_stub_minimal_symbol): Update.
5627         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5628         Update.
5629         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5630         (elf_gnu_ifunc_resolve_by_got): Update.
5631         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5632         * dwarf-index-write.c (save_gdb_index_command): Update.
5633         * cp-support.c (add_symbol_overload_list_qualified): Update.
5634         * breakpoint.c (create_overlay_event_breakpoint)
5635         (create_longjmp_master_breakpoint)
5636         (create_std_terminate_master_breakpoint)
5637         (create_exception_master_breakpoint): Update.
5638         * blockframe.c (find_pc_partial_function): Update.
5639         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5640         (ada_collect_symbol_completion_matches)
5641         (ada_add_global_exceptions): Update.
5642
5643 2019-01-17  Tom Tromey  <tom@tromey.com>
5644
5645         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5646         declare VEC.
5647         (solib_target_parse_libraries): Change return type.
5648         (library_list_start_segment, library_list_start_section)
5649         (library_list_end_library, library_list_start_library); Update.
5650         (solib_target_free_library_list): Remove.
5651         (solib_target_parse_libraries): Remove cleanup.  Change return
5652         type.
5653         (solib_target_current_sos): Update.
5654
5655 2019-01-17  Tom Tromey  <tromey@bapiya>
5656
5657         * valprint.c: Replace "the the" with "the".
5658         * symtab.c: Replace "the the" with "the".
5659         * solib.c: Replace "the the" with "the".
5660         * solib-dsbt.c: Replace "the the" with "the".
5661         * linespec.c: Replace "the the" with "the".
5662         * dwarf2loc.h: Replace "the the" with "the".
5663         * amd64-windows-tdep.c: Replace "the the" with "the".
5664         * aarch64-tdep.c: Replace "the the" with "the".
5665
5666 2019-01-16  Keith Seitz  <keiths@redhat.com>
5667
5668         PR gdb/23773
5669         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5670         <builder>: Rename to ..
5671         <m_builder>: ... this and make private.
5672         (dwarf2_cu::get_builder): New method.  Change all users of
5673         `builder' to use this method.
5674         (dwarf2_start_symtab): Move to ...
5675         (dwarf2_cu::start_symtab): ... here.  Update all callers
5676         (setup_type_unit_groups): Move to ...
5677         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5678         callers.
5679         (dwarf2_cu::reset_builder): New method.
5680         (process_full_compunit, process_full_type_unit): Use
5681         dwarf2_cu::reset_builder.
5682         (follow_die_offset): Record the ancestor CU if it is different
5683         from the followed DIE's CU.
5684         (follow_die_sig_1): Likewise.
5685
5686 2019-01-15  Tom Tromey  <tom@tromey.com>
5687
5688         * remote.c (class remote_state) <buf>: Now a char_vector.
5689         <buf_size>: Remove.
5690         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5691         parameter.
5692         (remote_target::getpkt_or_notif_sane_1)
5693         (remote_target::getpkt_sane)
5694         (remote_target::getpkt_or_notif_sane): Likewise.
5695         (class remote_target) <putpkt>: New overload.
5696         (remote_target::read_frame): Change type of "buf_p".  Remove
5697         sizeof_p parameter.
5698         (packet_ok): New overload.
5699         (packet_check_result): New overload.
5700         Update all uses.
5701
5702 2019-01-14  Tom Tromey  <tom@tromey.com>
5703
5704         * remote-notif.c (handle_notification, remote_notif_ack)
5705         (remote_notif_parse): Make "buf" const.
5706         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5707         const.
5708         (remote_notif_parse, remote_notif_ack, handle_notification):
5709         Likewise.
5710         * remote.c (remote_notif_stop_parse): Make "buf" const.
5711         (remote_target::remote_parse_stop_reply): Make "buf" const.
5712         (remote_notif_stop_ack): Make "buf" const.
5713
5714 2019-01-14  Tom Tromey  <tom@tromey.com>
5715
5716         * remote.c (remote_console_output): Make parameter const.
5717
5718 2019-01-14  Tom Tromey  <tom@tromey.com>
5719
5720         * target-debug.h (target_debug_print_signals): Constify.
5721         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5722         * procfs.c (procfs_target::pass_signals): Update.
5723         * linux-nat.c (linux_nat_target::pass_signals): Update.
5724         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5725         * target-delegates.c: Rebuild.
5726         * remote.c (remote_target::program_signals): Update.
5727         (remote_target::pass_signals): Update.
5728         * target.c (target_pass_signals): Constify argument.
5729         (target_program_signals): Likewise.
5730         * target.h (struct target_ops) <pass_signals, program_signals>:
5731         Constify argument.
5732         (target_pass_signals, target_program_signals): Constify argument.
5733
5734 2019-01-14  Tom Tromey  <tom@tromey.com>
5735
5736         PR tui/28819:
5737         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5738
5739 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5740
5741         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5742         field.
5743         * rs6000-tdep.c: Include reggroups.h.
5744         (IS_V_ALIAS_PSEUDOREG): Define.
5745         (rs6000_register_name): Return names for the "vX" aliases.
5746         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5747         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5748         aliases.  Call default_register_reggroup_p for all other
5749         pseudo-registers.
5750         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5751         New functions.
5752         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5753         Handle "vX" aliases.
5754         (v_alias_pseudo_register_collect): New function.
5755         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5756         (rs6000_gdbarch_init): Initialize "vX" aliases as
5757         pseudo-registers.  Restore registration of
5758         rs6000_pseudo_register_reggroup_p with
5759         set_tdesc_pseudo_register_reggroup_p.
5760
5761 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5762
5763         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5764         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5765         set_gdbarch_num_pseudo_regs.
5766
5767 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5768
5769         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5770         Remove arg prefixname, add do_set and do_show.
5771         Add member functions set_list and show_list.
5772         * cli/cli-style.c (class cli_style_option): Update accordingly.
5773         (style_set_list): Move to file scope.
5774         (style_show_list): Likewise.
5775         (set_style): Call help_list.
5776         (show_style): Call cmd_show_list.
5777         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5778         Update to use the new macro.
5779
5780 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5781
5782         * ada-lang.c (_initialize_ada_language): Expand the help text
5783         for the "catch exception" command.
5784
5785 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5786
5787         * symtab.c (matching_obj_sections): Initialize obj,
5788         declare it closer to its usage.
5789
5790 2019-01-10  Tom Tromey  <tom@tromey.com>
5791
5792         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5793         (basic_inf_threads_range): Remove.
5794         (inf_threads_range, inf_non_exited_threads_range)
5795         (safe_inf_threads_range): Use next_adapter.
5796
5797 2019-01-10  Keith Seitz  <keiths@redhat.com>
5798
5799         PR gdb/23712
5800         PR symtab/23010
5801         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5802         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5803
5804 2019-01-10  Keith Seitz  <keiths@redhat.com>
5805
5806         PR gdb/23712
5807         PR symtab/23010
5808         * dictionary.c (pending_to_vector): Remove.
5809         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5810         Remove _1 suffix, replacing functions of the same name.  Update
5811         all callers.
5812         (dict_create_hashed, dict_create_hashed_expandable)
5813         (dict_create_linear, dict_create_linear_expandable, dict_free)
5814         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5815         Make functions static.
5816
5817 2019-01-10  Keith Seitz  <keiths@redhat.com>
5818
5819         PR gdb/23712
5820         PR symtab/23010
5821         * dictionary.h (struct dictionary): Replace declaration with
5822         multidictionary.
5823         (dict_create_hashed, dict_create_hashed_expandable)
5824         (dict_create_linear, dict_create_linear_expandable)
5825         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5826         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5827         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5828         taking multidictionary argument.
5829         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5830         * block.h (struct block) <dict>: Change to multidictionary
5831         and rename `multidict'.
5832         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5833         symmisc.c: Update all dictionary references to multidictionary.
5834
5835 2019-01-10  Keith Seitz  <keiths@redhat.com>
5836
5837         PR gdb/23712
5838         PR symtab/23010
5839         * dictionary.c: Include unordered_map.
5840         (pending_to_vector): New function.
5841         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5842         Rewrite the non-"_1" functions to take vector instead
5843         of linked list.
5844         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5845         "new" _1 versions of the same name.
5846         (multidictionary): Define.
5847         (std::hash<enum language): New definition.
5848         (collate_pending_symbols_by_language, mdict_create_hashed)
5849         (mdict_create_hashed_expandable, mdict_create_linear)
5850         (mdict_create_linear_expandable, mdict_free)
5851         (find_language_dictionary, create_new_language_dictionary)
5852         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5853         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5854         (mdict_size, mdict_empty): New functions.
5855         * dictionary.h (mdict_iterator): Define.
5856
5857 2019-01-10  Pedro Alves  <palves@redhat.com>
5858
5859         * breakpoint.c (read_uploaded_action)
5860         (create_tracepoint_from_upload): Adjust to use
5861         gdb::unique_xmalloc_ptr.
5862         * ctf.c (ctf_write_uploaded_tp):
5863         (SET_ARRAY_FIELD): Use emplace_back.
5864         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5865         * tracefile-tfile.c (tfile_write_uploaded_tp):
5866         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5867         gdb::unique_xmalloc_ptr.
5868         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5869         at_string, cond_string, cmd_strings>: Replace char pointers
5870         with gdb::unique_xmalloc_ptr.
5871
5872 2019-01-10  Pedro Alves  <palves@redhat.com>
5873
5874         * solib-target.c (library_list_start_library): Don't xstrdup name.
5875
5876 2019-01-10  Pedro Alves  <palves@redhat.com>
5877
5878         * mdebugread.c (parse_partial_symbols): Use
5879         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5880
5881 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5882
5883         * linux-fork.c (scoped_switch_fork_info)
5884         <~scoped_switch_fork_info>: Fix incorrect variable name.
5885
5886 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5887
5888         * linux-fork.c (scoped_switch_fork_info)
5889         <scoped_switch_fork_info>: Make explicit.
5890         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5891
5892 2019-01-10  Tom Tromey  <tom@tromey.com>
5893
5894         * objfiles.h (objfile::reset_psymtabs): Update.
5895         * objfiles.c (objfile::objfile): Update.
5896         * psymtab.h (psymtab_storage::obstack): Update.
5897         (psymtab_storage::m_obstack): Use gdb::optional.
5898         (class psymtab_storage): Update comment.  Remove objfile
5899         parameter.
5900         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5901
5902 2019-01-10  Tom Tromey  <tom@tromey.com>
5903
5904         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5905         <free_psymtabs>: Now private.
5906         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5907         (allocate_psymtab): Use new method.
5908
5909 2019-01-10  Tom Tromey  <tom@tromey.com>
5910
5911         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5912         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5913         * mdebugread.c (parse_partial_symbols): Use
5914         allocate_dependencies.
5915         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5916         allocate_dependencies.
5917         (process_psymtab_comp_unit_reader)
5918         (build_type_psymtab_dependencies): Likewise.
5919         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5920
5921 2019-01-10  Tom Tromey  <tom@tromey.com>
5922
5923         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5924         PSYMBOL_SET_LANGUAGE.
5925         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5926
5927 2019-01-10  Tom Tromey  <tom@tromey.com>
5928
5929         * psymtab.h (psymtab_storage::obstack): New method.
5930         <m_obstack>: Rename from obstack; now private.
5931         * psymtab.c (psymtab_storage): Update.
5932         * dwarf2read.c (create_addrmap_from_index)
5933         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5934         Update.
5935
5936 2019-01-10  Tom Tromey  <tom@tromey.com>
5937
5938         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5939         * objfiles.h (objfile::reset_psymtabs): New method.
5940
5941 2019-01-10  Tom Tromey  <tom@tromey.com>
5942
5943         * symmisc.c (print_symbol_bcache_statistics): Update.
5944         (print_objfile_statistics): Update.
5945         * symfile.c (reread_symbols): Update.
5946         * psymtab.h (class psymtab_storage): New.
5947         * psymtab.c (psymtab_storage): New constructor.
5948         (~psymtab_storage): New destructor.
5949         (require_partial_symbols): Update.
5950         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5951         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5952         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5953         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5954         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5955         (start_psymtab_common, end_psymtab_common)
5956         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5957         (allocate_psymtab): Update.
5958         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5959         Update.
5960         (dump_psymtab_addrmap, maintenance_print_psymbols)
5961         (maintenance_check_psymtabs): Update.
5962         (class objfile_psymtabs): Move to objfiles.h.
5963         * psympriv.h (discard_psymtab): Now inline.
5964         (psymtab_discarder::psymtab_discarder): Update.
5965         (psymtab_discarder::~psymtab_discarder): Update.
5966         (ALL_OBJFILE_PSYMTABS): Rewrite.
5967         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5968         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5969         Remove fields.
5970         <partial_symtabs>: New field.
5971         (class objfile_psymtabs): Move from psymtab.h.  Update.
5972         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5973         psymbol_cache.
5974         (objfile::~objfile): Don't destroy psymbol_cache.
5975         * mdebugread.c (parse_partial_symbols): Update.
5976         * dwarf2read.c (create_addrmap_from_index)
5977         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5978         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5979         (add_partial_subprogram, dwarf2_ranges_read): Update.
5980         * dwarf-index-write.c (write_address_map)
5981         (write_one_signatured_type, recursively_write_psymbols)
5982         (class debug_names, class debug_names, write_psymtabs_to_index):
5983         Update.
5984
5985 2019-01-10  Tom Tromey  <tom@tromey.com>
5986
5987         * symtab.h (SYMBOL_SET_NAMES): Update.
5988         (symbol_set_names): Update.
5989         (MSYMBOL_SET_NAMES): Update.
5990         * symtab.c (symbol_set_names): Change argument to be an
5991         objfile_per_bfd_storage.
5992         * psymtab.c (add_psymbol_to_bcache): Update.
5993         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5994
5995 2019-01-10  Tom Tromey  <tom@tromey.com>
5996
5997         * symtab.c (create_demangled_names_hash): Change argument to be an
5998         objfile_per_bfd_storage.
5999         (symbol_set_names): Update.
6000
6001 2019-01-10  Tom Tromey  <tom@tromey.com>
6002
6003         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6004         init_psymbol_list.
6005         * psymtab.c (init_psymbol_list): Do nothing if already called.
6006         * psympriv.h (init_psymbol_list): Add comment.
6007         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6008         init_psymbol_list.
6009         * dbxread.c (dbx_symfile_read): Unconditionally call
6010         init_psymbol_list.
6011
6012 2019-01-10  Tom Tromey  <tom@tromey.com>
6013
6014         * xcoffread.c (scan_xcoff_symtab): Update.
6015         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6016         "where".
6017         * mdebugread.c (parse_partial_symbols)
6018         (handle_psymbol_enumerators): Update.
6019         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6020         * dbxread.c (read_dbx_symtab): Update.
6021         * psympriv.h (psymbol_placement): New enum.
6022         (add_psymbol_to_list): Update.
6023
6024 2019-01-10  Tom Tromey  <tom@tromey.com>
6025
6026         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6027         static_psymbols parameters.
6028         (scan_xcoff_symtab): Update.
6029         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6030         static_psymbols parameters.
6031         * psympriv.h (start_psymtab_common): Update.
6032         * mdebugread.c (parse_partial_symbols): Update.
6033         * dwarf2read.c (create_partial_symtab): Update.
6034         * dbxread.c (read_dbx_symtab): Update.
6035         (start_psymtab): Remove global_psymbols and static_psymbols
6036         parameters.
6037
6038 2019-01-10  Tom Tromey  <tom@tromey.com>
6039
6040         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6041         * psymtab.c (allocate_psymtab): Add comment.
6042         * psympriv.h (allocate_psymtab): Add comment.
6043         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6044         initializations.
6045         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6046
6047 2019-01-10  Tom Tromey  <tom@tromey.com>
6048
6049         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6050         Don't declare.
6051         * mipsread.c: Include mdebugread.h.
6052         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6053         Declare.
6054         * elfread.c: Include mdebugread.h.
6055
6056 2019-01-09  Tom Tromey  <tom@tromey.com>
6057
6058         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6059         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6060         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6061         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6062         (psym_lookup_symbol, psym_find_last_source_symtab)
6063         (psym_forget_cached_source_info, psym_print_stats)
6064         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6065         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6066         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6067         (psym_find_compunit_symtab_by_address)
6068         (maintenance_print_psymbols, maintenance_info_psymtabs)
6069         (maintenance_check_psymtabs): Use ranged for.
6070         * psymtab.h (class objfile_psymtabs): New.
6071         (require_partial_symbols): Return objfile_psymtabs.
6072         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6073
6074 2019-01-09  Tom Tromey  <tom@tromey.com>
6075
6076         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6077         (find_pc_mapped_section, list_overlays_command)
6078         (map_overlay_command, unmap_overlay_command)
6079         (simple_overlay_update): Use all_objfiles.
6080         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6081         * printcmd.c (info_symbol_command): Use all_objfiles.
6082         * objfiles.h (ALL_OBJSECTIONS): Remove.
6083         * maint.c (maintenance_translate_address): Use all_objfiles.
6084         * gcore.c (gcore_create_callback): Use all_objfiles.
6085         (objfile_find_memory_regions): Likewise.
6086
6087 2019-01-09  Tom Tromey  <tom@tromey.com>
6088
6089         * symtab.c (find_line_symtab, info_sources_command)
6090         (make_source_files_completion_list): Use objfile_compunits.
6091         * source.c (select_source_symtab): Use objfile_compunits.
6092         * objfiles.h (struct objfile): Update comment.
6093         (ALL_OBJFILES): Remove.
6094         (ALL_FILETABS): Remove.
6095         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6096         objfile_compunits.
6097
6098 2019-01-09  Tom Tromey  <tom@tromey.com>
6099
6100         * symmisc.c (print_objfile_statistics, dump_objfile)
6101         (maintenance_print_symbols): Use compunit_filetabs.
6102         * source.c (forget_cached_source_info_for_objfile): Use
6103         compunit_filetabs.
6104         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6105         (ALL_FILETABS): Use compunit_filetabs.
6106         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6107         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6108
6109 2019-01-09  Tom Tromey  <tom@tromey.com>
6110
6111         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6112         (compunit_filetabs): New.
6113         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6114         compunit_filetabs.
6115         (info_sources_command, make_source_files_completion_list): Remove
6116         declaration.
6117         * symmisc.c (print_objfile_statistics, dump_objfile)
6118         (maintenance_print_symbols): Remove declaration.
6119         (maintenance_info_symtabs): Use compunit_filetabs.
6120         (maintenance_info_line_tables): Likewise.
6121         * source.c (select_source_symtab): Change local variable name.
6122         (forget_cached_source_info_for_objfile): Remove declaration.
6123         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6124         * objfiles.c (objfile_relocate1): Remove declaration.
6125         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6126         declaration.
6127         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6128         * coffread.c (coff_symtab_read): Remove declaration.
6129         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6130         compunit_filetabs.
6131
6132 2019-01-09  Tom Tromey  <tom@tromey.com>
6133
6134         * symtab.c (lookup_objfile_from_block)
6135         (find_pc_sect_compunit_symtab, search_symbols)
6136         (default_collect_symbol_completion_matches_break_on): Use
6137         objfile_compunits.
6138         * objfiles.h (ALL_COMPUNITS): Remove.
6139         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6140         * cp-support.c (add_symbol_overload_list_qualified): Use
6141         objfile_compunits.
6142         * ada-lang.c (ada_collect_symbol_completion_matches)
6143         (ada_add_global_exceptions): Use objfile_compunits.
6144
6145 2019-01-09  Tom Tromey  <tom@tromey.com>
6146
6147         * source.c (select_source_symtab)
6148         (forget_cached_source_info_for_objfile): Remove declaration.
6149         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6150         declaration.
6151         * maint.c (count_symtabs_and_blocks): Remove declaration.
6152         * cp-support.c (add_symbol_overload_list_qualified): Remove
6153         declaration.
6154         * coffread.c (coff_symtab_read): Remove declaration.
6155         * symtab.c (lookup_symbol_in_objfile_symtabs)
6156         (basic_lookup_transparent_type_1): Use objfile_compunits.
6157         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6158         (info_sources_command, search_symbols)
6159         (default_collect_symbol_completion_matches_break_on)
6160         (make_source_files_completion_list): Remove declaration.
6161         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6162         (ada_collect_symbol_completion_matches)
6163         (ada_add_global_exceptions): Remove declaration.
6164         * linespec.c (iterate_over_all_matching_symtabs): Use
6165         objfile_compunits.
6166         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6167         (class objfile_compunits): New.
6168         (ALL_COMPUNITS): Use objfile_compunits.
6169         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6170         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6171         objfile_compunits.
6172         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6173
6174 2019-01-09  Tom Tromey  <tom@tromey.com>
6175
6176         * symtab.c (search_symbols)
6177         (default_collect_symbol_completion_matches_break_on): Use
6178         objfile_msymbols.
6179         * ada-lang.c (ada_lookup_simple_minsym)
6180         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6181         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6182         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6183         objfile_msymbols.
6184         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6185         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6186         * objc-lang.c (find_methods): Use objfile_msymbols.
6187         (info_selectors_command, info_classes_command): Likewise.
6188         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6189         * objfiles.h (class objfile_msymbols): New.
6190         (ALL_OBJFILE_MSYMBOLS): Remove.
6191         (ALL_MSYMBOLS): Remove.
6192
6193 2019-01-09  Tom Tromey  <tom@tromey.com>
6194
6195         * common/next-iterator.h (next_adapter): Add Iterator template
6196         parameter.
6197         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6198         (class all_objfiles_safe): New.
6199         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6200         * objfiles.c (put_objfile_before): Update comment.
6201         (add_separate_debug_objfile): Likewise.
6202         (free_all_objfiles): Use all_objfiles_safe.
6203         (objfile_purge_solibs): Likewise.
6204
6205 2019-01-09  Tom Tromey  <tom@tromey.com>
6206
6207         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6208         (expand_symtab_containing_pc, lookup_static_symbol)
6209         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6210         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6211         all_objfiles.
6212         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6213         * breakpoint.c (create_overlay_event_breakpoint)
6214         (create_longjmp_master_breakpoint)
6215         (create_std_terminate_master_breakpoint)
6216         (create_exception_master_breakpoint): Use all_objfiles.
6217         * linux-thread-db.c (try_thread_db_load_from_pdir)
6218         (has_libpthread): Use all_objfiles.
6219         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6220         * linespec.c (iterate_over_all_matching_symtabs)
6221         (search_minsyms_for_name): Use all_objfiles.
6222         * maint.c (maintenance_info_sections): Use all_objfiles.
6223         * main.c (captured_main_1): Use all_objfiles.
6224         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6225         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6226         * guile/scm-pretty-print.c
6227         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6228         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6229         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6230         (maintenance_print_msymbols): Use all_objfiles.
6231         * source.c (select_source_symtab): Use all_objfiles.
6232         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6233         * symfile.c (remove_symbol_file_command)
6234         (expand_symtabs_matching, map_symbol_filenames): Use
6235         all_objfiles.
6236         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6237         all_objfiles.
6238         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6239         * objc-lang.c (find_methods): Use all_objfiles.
6240         * objfiles.c (have_partial_symbols, have_full_symbols)
6241         (have_minimal_symbols, qsort_cmp)
6242         (default_iterate_over_objfiles_in_search_order): Use
6243         all_objfiles.
6244         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6245         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6246         (maintenance_check_psymtabs): Use all_objfiles.
6247         (ALL_PSYMTABS): Remove.
6248         * compile/compile-object-run.c (do_module_cleanup): Use
6249         all_objfiles.
6250         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6251         * cp-support.c (add_symbol_overload_list_qualified): Use
6252         all_objfiles.
6253         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6254         Use all_objfiles.
6255         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6256         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6257         all_objfiles.
6258         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6259         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6260         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6261         Uses all_objfiles.
6262         * solib.c (solib_read_symbols): Use all_objfiles
6263
6264 2019-01-09  Tom Tromey  <tom@tromey.com>
6265
6266         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6267         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6268         all_objfiles.
6269         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6270         * symmisc.c (print_symbol_bcache_statistics)
6271         (print_objfile_statistics, maintenance_print_objfiles)
6272         (maintenance_info_symtabs, maintenance_check_symtabs)
6273         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6274         all_objfiles.
6275         * source.c (forget_cached_source_info): Use all_objfiles.
6276         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6277         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6278         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6279         * objfiles.c (update_section_map): Use all_objfiles.
6280         (shared_objfile_contains_address_p): Likewise.
6281         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6282         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6283
6284 2019-01-09  Tom Tromey  <tom@tromey.com>
6285
6286         * common/next-iterator.h: New file.
6287         * objfiles.h (class all_objfiles): New.
6288         (struct objfile_iterator): New.
6289
6290 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6291
6292         * NEWS: Move the description of the changed "frame", "select-frame",
6293          and "info frame" commands to the Changed commands section.
6294
6295 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6296
6297         * gdbtypes.c (check_stub_method_group): Remove handling of old
6298         mangling schemes.
6299         * linespec.c (find_methods): Likewise.
6300         * stabsread.c (read_member_functions): Likewise.
6301         * valops.c (search_struct_method): Likewise.
6302         (value_struct_elt_for_reference): Likewise.
6303         * NEWS: Mention this change.
6304
6305 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6306
6307         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6308         print_source_lines.
6309         * source.c (print_source_lines_base): Update line number check.
6310         (print_source_lines): New function.
6311         (source_lines_range::source_lines_range): New function.
6312         * source.h (class source_lines_range): New class.
6313         (print_source_lines): New declaration.
6314
6315 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6316
6317         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6318
6319 2019-01-08  Tom Tromey  <tom@tromey.com>
6320             Simon Marchi  <simon.marchi@ericsson.com>
6321
6322         PR gdb/24060
6323         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6324         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6325         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6326         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6327         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6328         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6329
6330 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6331
6332         * source.c (select_source_symtab): Move header comment to
6333         declaration in source.h.
6334         (forget_cached_source_info_for_objfile): Likewise.
6335         (forget_cached_source_info): Likewise.
6336         (identify_source_line): Likewise.
6337         * source.h (identify_source_line): Move declaration from symtab.h
6338         and add comment from source.c
6339         (print_source_lines): Likewise.
6340         (forget_cached_source_info_for_objfile): Likewise.
6341         (forget_cached_source_info): Likewise.
6342         (select_source_symtab): Likewise.
6343         (enum print_source_lines_flag): Move definition from symtab.h.
6344         * symtab.h (identify_source_line): Move declaration to source.h.
6345         (print_source_lines): Likewise.
6346         (forget_cached_source_info_for_objfile): Likewise.
6347         (forget_cached_source_info): Likewise.
6348         (select_source_symtab): Likewise.
6349         (enum print_source_lines_flag): Move definition to source.h.
6350         * tui/tui-hooks.c: Add 'source.h' include.
6351
6352 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6353
6354         * source.c (print_source_lines_base): Handle requests to print
6355         reverse line number sequences, and guard against empty lines
6356         string.
6357
6358 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * source.c (print_source_lines_base): Fix skip of '\r' if next
6361         character is '\n'.
6362
6363 2019-01-06  Tom Tromey  <tom@tromey.com>
6364
6365         * c-exp.y (struct c_parse_state) <macro_original_text,
6366         expansion_obstack>: New member.
6367         (macro_original_text, expansion_obstack): Remove globals.
6368         (scan_macro_expansion, scanning_macro_expansion)
6369         (finished_macro_expansion): Update.
6370         (scan_macro_cleanup): Remove.
6371         (yylex, c_parse): Update.
6372
6373 2019-01-06  Tom Tromey  <tom@tromey.com>
6374
6375         * c-exp.y (struct c_parse_state) <strings>: New member.
6376         (operator_stoken): Update.
6377
6378 2019-01-06  Tom Tromey  <tom@tromey.com>
6379
6380         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6381         (union type_stack_elt) <typelist_val>: Now a pointer to
6382         std::vector.
6383         (type_stack_cleanup): Don't declare.
6384         (push_typelist): Update.
6385         * parse.c (pop_typelist): Return a std::vector.
6386         (push_typelist): Take a std::vector.
6387         (follow_types): Update.  Do not free args.
6388         (type_stack_cleanup): Remove.
6389         * c-exp.y (struct c_parse_state): New.
6390         (cpstate): New global.
6391         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6392         (nonempty_typelist): Update.
6393         (func_mod): Create a new vector.
6394         (c_parse): Create a c_parse_state.
6395         (check_parameter_typelist): Do not delete params.
6396         (function_method): Update.  Do not delete type_list.
6397
6398 2019-01-06  Tom Tromey  <tom@tromey.com>
6399
6400         PR gdb/28155:
6401         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6402         check_typedef.
6403         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6404         (print_return_value): Likewise.
6405
6406 2019-01-05  Tom Tromey  <tom@tromey.com>
6407
6408         * contrib/cleanup_check.py: Remove.
6409         * contrib/gcc-with-excheck: Remove.
6410         * contrib/exsummary.py: Remove.
6411         * contrib/excheck.py: Remove.
6412
6413 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6414
6415         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6416         NULL. Initialize tpprev to NULL instead of assigning it
6417         to NULL on the next statement.
6418         * windows-nat.c (windows_delete_thread): Remove check for
6419         main_thread_id before printing thread exit notifications.
6420         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6421         Remove thread ID check against main_thread_id.
6422         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6423         windows_delete_thread.
6424         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6425
6426 2019-01-04  Tom Tromey  <tom@tromey.com>
6427
6428         * compile/compile.c (_initialize_compile): Use upper case for
6429         metasyntactic variables.
6430         * symmisc.c (_initialize_symmisc): Use upper case for
6431         metasyntactic variables.
6432         * psymtab.c (_initialize_psymtab): Use upper case for
6433         metasyntactic variables.
6434         * demangle.c (demangle_command): Use upper case for metasyntactic
6435         variables.
6436         (_initialize_demangler): Likewise.
6437         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6438         variables.
6439
6440 2019-01-03  Tom Tromey  <tom@tromey.com>
6441
6442         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6443
6444 2019-01-03  Tom Tromey  <tom@tromey.com>
6445
6446         * python/py-symtab.c (salpy_str): Update.
6447         (struct salpy_sal_object) <symtab>: Now a PyObject.
6448         (salpy_dealloc): Update.
6449         (del_objfile_sal): Use gdbpy_ref.
6450
6451 2019-01-03  Tom Tromey  <tom@tromey.com>
6452
6453         * python/py-type.c (convert_field): Use new_reference.  Return
6454         gdbpy_ref.
6455         (make_fielditem): Return gdbpy_ref.
6456         (typy_fields): Update.
6457         (typy_getitem): Update.
6458         (field_name): Return gdbpy_ref.  Use new_reference.
6459         (typy_iterator_iternext): Update.
6460
6461 2019-01-03  Tom Tromey  <tom@tromey.com>
6462
6463         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6464
6465 2019-01-03  Tom Tromey  <tom@tromey.com>
6466
6467         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6468         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6469         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6470         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6471         (pspy_set_type_printers): Likewise.
6472         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6473         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6474         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6475         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6476         (objfpy_set_type_printers): Likewise.
6477
6478 2019-01-03  Tom Tromey  <tom@tromey.com>
6479
6480         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6481         (gdbpy_print_stack): Use gdbpy_err_fetch.
6482         * python/python-internal.h (class gdbpy_err_fetch): New class.
6483         (class gdbpy_enter) <m_error_type, m_error_value,
6484         m_error_traceback>: Remove.
6485         <m_error>: New member.
6486         (gdbpy_exception_to_string): Don't declare.
6487         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6488         * python/py-value.c (convert_value_from_python): Use
6489         gdbpy_err_fetch.
6490         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6491         gdbpy_exception_to_string.
6492         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6493         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6494         gdbpy_err_fetch.
6495
6496 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * linux-nat.c (delete_lwp_cleanup): Delete.
6499         (struct lwp_deleter): New struct.
6500         (lwp_info_up): New typedef.
6501         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6502         lwp_info_up.
6503
6504 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6505
6506         * linux-fork.c (class scoped_switch_fork_info): New class.
6507         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6508
6509 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * valops.c (find_overload_match): Remove use of null_cleanup, and
6512         calls to do_cleanups.
6513
6514 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * compile/compile-cplus-types.c
6517         (compile_cplus_instance::decl_name): Handle changes to
6518         cp_func_name.
6519         * cp-support.c (cp_func_name): Update header comment, update
6520         return type.
6521         * cp-support.h (cp_func_name): Update return type in declaration.
6522         * valops.c (find_overload_match): Move temp_func local to top
6523         level of function and change its type.  Use temp_func to hold and
6524         delete temporary string obtained from cp_func_name.
6525
6526 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6529         gdb::char_vector, remove cleanup, and update uses of `msg`.
6530
6531 2019-01-03  Jim Wilson  <jimw@sifive.com>
6532
6533         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6534
6535 2019-01-02  Tom Tromey  <tom@tromey.com>
6536
6537         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6538         (tdesc_parse_xml): Remove cleanups.
6539         * target-descriptions.h (make_cleanup_free_target_description):
6540         Don't declare.
6541         (target_desc_deleter): New struct.
6542         (target_desc_up): New typedef.
6543         * target-descriptions.c (target_desc_deleter::operator()): Rename
6544         from free_target_description.
6545         (make_cleanup_free_target_description): Remove.
6546
6547 2019-01-02  Tom Tromey  <tom@tromey.com>
6548
6549         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6550         constructor, destructor.
6551         (linespec_parser): Remove typedef.
6552         (~linespec_parser): Rename from linespec_parser_delete.
6553         (linespec_lex_to_end, linespec_complete_label)
6554         (linespec_complete): Update.
6555         (decode_line_full): Remove cleanups.
6556         (decode_line_1): Update.
6557
6558 2019-01-02  Tom Tromey  <tom@tromey.com>
6559
6560         * python/python-internal.h (inferior_to_inferior_object): Change
6561         return type.
6562         * python/py-exitedevent.c (create_exited_event_object): Update.
6563         * python/py-inferior.c (inferior_to_inferior_object): Return
6564         gdbpy_ref.
6565         (python_new_inferior, python_inferior_deleted)
6566         (thread_to_thread_object, delete_thread_object)
6567         (build_inferior_list, gdbpy_selected_inferior): Update.
6568         * python/py-infthread.c (create_thread_object): Update.  Also fail
6569         if inferior_to_inferior_object fails.
6570
6571 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6572
6573         * inferior.h (class inferior) <displaced_step_state>: New field.
6574         * infrun.h (struct displaced_step_state): Move here from
6575         infrun.c.  Initialize fields, add constructor.
6576         <inf>: Remove field.
6577         <reset>: New method.
6578         * infrun.c (struct displaced_step_inferior_state): Move to
6579         infrun.h.
6580         (displaced_step_inferior_states): Remove.
6581         (get_displaced_stepping_state): Adust.
6582         (displaced_step_in_progress_any_inferior): Adjust.
6583         (displaced_step_in_progress_thread): Adjust.
6584         (displaced_step_in_progress): Adjust.
6585         (add_displaced_stepping_state): Remove.
6586         (get_displaced_step_closure_by_addr): Adjust.
6587         (remove_displaced_stepping_state): Remove.
6588         (infrun_inferior_exit): Call displaced_step_state.reset.
6589         (use_displaced_stepping): Don't check for NULL.
6590         (displaced_step_prepare_throw): Call
6591         get_displaced_stepping_state.
6592         (displaced_step_fixup): Don't check for NULL.
6593         (prepare_for_detach): Don't check for NULL.
6594
6595 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6596
6597         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6598          in case of call that did not complete.
6599
6600 2019-01-02  Andrey Utkin  <autkin@undo.io>
6601
6602         * symfile.c (find_separate_debug_file): Fix search of debug files for
6603         remote debuggee.
6604
6605 2019-01-02  Tom Tromey  <tom@tromey.com>
6606
6607         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6608         indentation.
6609         * python/py-frame.c (frapy_older): Remove cast.
6610         (frapy_newer): Likewise.
6611         * python/py-breakpoint.c (local_setattro): Remove cast.
6612         * python/py-arch.c (archpy_name): Remove local variable.
6613         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6614
6615 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6616
6617         * unittests/basic_string_view/element_access/char/empty.cc:
6618         Fix year range in copyright header.
6619
6620 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6621
6622         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6623         Delete.
6624         <operator==>: Update with for removed field.
6625         <hash>: Likewise.
6626         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6627         <isa_features>: ...this.
6628         <abi_features>: New field.
6629         (riscv_isa_flen): Update comment.
6630         (riscv_abi_xlen): New declaration.
6631         (riscv_abi_flen): New declaration.
6632         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6633         isa_features.
6634         (riscv_abi_xlen): New function.
6635         (riscv_isa_flen): Update to get answer from isa_features.
6636         (riscv_abi_flen): New function.
6637         (riscv_has_fp_abi): Update to get answer from abi_features.
6638         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6639         xlen and flen.
6640         (riscv_call_info) <xlen, flen>: Update comment.
6641         (riscv_call_arg_struct): Remove invalid assertions
6642         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6643         is removed.
6644         (riscv_gdbarch_init): Gather isa features and abi features
6645         separately, ensure both match on the gdbarch when reusing an old
6646         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6647         a target with 64-bit float hardware.
6648
6649 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6650
6651         * source.c (search_command_helper): Stop reverse search
6652         when line 1 has been searched.
6653
6654 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6655
6656         * record-full.c (record_full_base_target::close): Rewrite
6657         record_full_core_buf_list free logic.
6658
6659 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6660
6661         * break-catch-syscall.c (print_one_catch_syscall): xfree
6662         the last text.
6663
6664 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6665
6666         * top.c (print_gdb_version): Update Copyright year in version
6667         message.
6668
6669 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6670
6671         Update copyright year range in all GDB files.
6672
6673 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6674
6675         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6676
6677 For older changes see ChangeLog-2018.
6678 \f
6679 Local Variables:
6680 mode: change-log
6681 left-margin: 8
6682 fill-column: 74
6683 version-control: never
6684 coding: utf-8
6685 End:
6686