gdb/ChangeLog

   1 2019-05-29  Tom Tromey  <tromey@adacore.com>
   2
   3         * inflow.c (struct terminal_info): Add default operator=.
   4         * configure: Rebuild.
   5         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
   6         -Wdeprecated-copy-dtor, -Wredundant-move.
   7
   8 2019-05-29  Tom Tromey  <tromey@adacore.com>
   9
  10         * NEWS: Add entry.
  11         * infcmd.c (print_return_value_1): Handle finish_print
  12         option.
  13         (show_print_finish): New function.
  14         (_initialize_infcmd): Add "set/show print finish" commands.
  15         * valprint.c (user_print_options): Initialize new member.
  16         * valprint.h (struct value_print_options) <finish_print>: New
  17         member.
  18
  19 2019-05-28  Tom Tromey  <tromey@adacore.com>
  20
  21         * ada-lang.c (ada_remove_Xbn_suffix)
  22         (find_old_style_renaming_symbol)
  23         (parse_old_style_renaming): Remove.
  24         (ada_find_renaming_symbol): Don't call
  25         find_old_style_renaming_symbol.
  26         (ada_is_renaming_symbol): Rename from
  27         ada_find_renaming_symbol.  Remove "block" parameter.  Return
  28         bool.  Now static.
  29         (ada_read_var_value): Update and simplify.
  30         * ada-exp.y (write_var_or_type): Remove old code.
  31
  32 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
  33
  34         * event-top.c: Remove include comment.
  35         * inflow.c (class scoped_ignore_sigttou): Move from here...
  36         * inflow.h (class scoped_ignore_sigttou): ...to here.
  37         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
  38         * top.c:  Remove include comment.
  39
  40 2019-05-27  Tom Tromey  <tom@tromey.com>
  41
  42         * NEWS: Fix typo.
  43
  44 2019-05-22  Tom Tromey  <tromey@adacore.com>
  45
  46         * target.c (target_follow_exec): Constify parameter.
  47         * target-delegates.c: Rebuild.
  48         * remote.c (remote_target::follow_exec): Constify parameter.
  49         * infrun.c (follow_exec): Constify parameter.
  50         * target.h (struct target_ops) <follow_exec>: Constify parameter.
  51         (target_follow_exec): Likewise.
  52
  53 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  54
  55         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
  56         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
  57
  58 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  59
  60         * NEWS: Add debugredirect and testsuite sections.
  61
  62 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
  63
  64         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
  65         target descriptions using exclusively floating point register name
  66         aliases.
  67
  68 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  69
  70         PR gdb/18644:
  71         * f-lang.c (build_fortran_types): Handle the case where
  72         gdbarch_floatformat_for_type returns a nullptr.
  73
  74 2019-05-21  Tom de Vries  <tdevries@suse.de>
  75
  76         PR cli/24587
  77         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  78
  79 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  80
  81         PR gdb/18644:
  82         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  83         16-byte floats.
  84         * i386-tdep.c (i386_floatformat_for_type): Use
  85         floatformats_ia64_quad for the 16-byte floating point component
  86         within a fortran 32-byte complex number.
  87
  88 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  91         delete default constructor.
  92         (find_partial_die): Update to return const struct.
  93         (partial_die_parent_scope): Move variable declaration into scope
  94         of its use and change its type to auto.
  95         (guess_partial_die_structure_name): Likewise.
  96         (partial_die_info::fixup): Likewise.
  97
  98 2019-05-17  Tom Tromey  <tromey@adacore.com>
  99
 100         * source.c (find_and_open_source): Remove cast.
 101
 102 2019-05-17  Tom Tromey  <tromey@adacore.com>
 103
 104         * annotate.c (annotate_source): Make "filename" const.
 105         * annotate.h (annotate_source): Use const.
 106
 107 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 108
 109         * disasm.c (set_disassembler_options): Send errors to stderr.
 110
 111 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 112
 113         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 114         (cli_interp_base::set_logging): Check debug_redirect.
 115         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 116         * cli/cli-logging.c (debug_redirect): Add static variable.
 117         (pop_output_files): Add default param.
 118         (handle_redirections): Print debug setting.
 119         (show_logging_command): Likewise.
 120         (_initialize_cli_logging): Add debugredirect command.
 121         * interps.c (current_interp_set_logging): Add debug_redirect
 122         parameter.
 123         * interps.h (set_logging): Add debug_redirect parameter.
 124         (current_interp_set_logging): Likewise.
 125         * mi/mi-common.h: Likewise.
 126         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 127
 128 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 129             Tom Tromey  <tromey@adacore.com>
 130
 131         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 132         directly.
 133         * cli/cli-interp.h (make_logging_output): Remove declaration.
 134         * cli/cli-logging.c (make_logging_output): Remove function.
 135         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 136         directly.
 137         * ui-file.c (tee_file::tee_file): Remove bools.
 138         (tee_file::~tee_file): Remove deletes.
 139         * ui-file.h (tee_file): Remove bools.
 140
 141 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 142
 143         * mi/mi-cmds.h (mi_cmd_complete): New function.
 144         * mi/mi-main.c (mi_cmd_complete): Likewise.
 145         * mi/mi-cmds.c: Define new MI command -complete.
 146         * NEWS: Mention new -complete command.
 147
 148 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 149
 150         * completer.h (complete): New function.
 151         * completer.c (complete): Likewise.
 152         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 153         function defined in completer.h.
 154
 155 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 156
 157        * MAINTAINERS (Write After Approval): Add myself.
 158
 159 2019-05-17  Tom de Vries  <tdevries@suse.de>
 160
 161         PR gdb/24094
 162         * dwarf2read.c (struct cu_partial_die_info): New struct.
 163         (find_partial_die): Return cu_partial_die_info.
 164         (partial_die_parent_scope, guess_partial_die_structure_name)
 165         (partial_die_info::fixup): Handle new return type of find_partial_die.
 166
 167 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 168
 169         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 170         "std::string", simplifying the algorithm.
 171
 172 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 173
 174         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 175         (stap_static_probe_ops::get_probes): Likewise.
 176
 177 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 178
 179         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 180         '-')" and "else if".
 181         (stap_parse_single_operand): Join checks for
 182         "gdbarch_stap_parse_special_token_p" and
 183         "gdbarch_stap_parse_special_token" in the same "if" statement.
 184         Invert check when verifying for operation on register
 185         displacement.
 186
 187 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 188
 189         * stap-probe.c (stap_get_opcode): Update comment.
 190         (stap_get_expected_argument_type): Likewise.
 191         (handle_stap_probe): Likewise.
 192
 193 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 194
 195         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 196         return type to 'bool'.  Adjust comment.  Use 'bool' when
 197         appropriate.
 198         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 199         * stap-probe.c (stap_parse_argument_1): Likewise.
 200         (stap_is_operator): Likewise.
 201         (stap_is_generic_prefix): Likewise.
 202         (stap_is_register_prefix): Likewise.
 203         (stap_is_register_indirection_prefix): Likewise.
 204         (stap_is_integer_prefix): Likewise.
 205         (stap_generic_check_suffix): Likewise.
 206         (stap_check_integer_suffix): Likewise.
 207         (stap_check_register_suffix): Likewise.
 208         (stap_check_register_indirection_suffix): Likewise.
 209         (stap_parse_register_operand): Likewise.
 210         (stap_parse_single_operand): Likewise.
 211         (stap_parse_argument_1): Likewise.
 212         (stap_probe::get_argument_count): Likewise.
 213         (stap_is_operator): Likewise.
 214
 215 2019-05-16  Tom Tromey  <tromey@adacore.com>
 216
 217         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 218         keyword to foreach.
 219
 220 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 221
 222         * linux-thread-db.c (try_thread_db_load_1): Change return type
 223         to bool.
 224         (try_thread_db_load): Likewise.
 225         (try_thread_db_load_from_pdir_1): Likewise.
 226         (try_thread_db_load_from_pdir): Likewise.
 227         (try_thread_db_load_from_sdir): Likewise.
 228         (try_thread_db_load_from_dir): Likewise.
 229         (thread_db_load_search): Likewise.
 230         (has_libpthread): Likewise.
 231         (thread_db_load): Likewise.
 232
 233 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 234
 235         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 236         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 237         NULL, and complain/return if that's the case.
 238
 239 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 240
 241         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 242         (advance, posn, abstract_read_memory): New functions.
 243         [struct mem_read_abstraction]: New struct.
 244         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 245
 246 2019-05-14  Tom Tromey  <tromey@adacore.com>
 247
 248         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 249         value is not lval_memory.
 250
 251 2019-05-14  Tom Tromey  <tromey@adacore.com>
 252
 253         * solib.c (info_sharedlibrary_command): Style the file name.
 254
 255 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 256
 257         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 258         (aarch64_vnv_type): Likewise.
 259         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 260         * common/tdesc.c: Likewise.
 261         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 262         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 263         * features/aarch64-fpu.xml: Add ieee half view.
 264         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 265         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 266         * gdbtypes.h (struct builtin_type): Likewise.
 267         (struct objfile_type): Likewise.
 268
 269 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 270
 271         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 272         typo.
 273         * location.h (string_to_event_location): Likewise.
 274
 275 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 276
 277         GDB 8.3 released.
 278
 279 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 280
 281         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 282         New variable declaration.
 283         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 284         New variable.
 285         (print_one_breakpoint): Use ui_out::test_flags and new global
 286         variable to compute use_fixed_output.
 287         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 288         Remove.
 289         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 290         (mi_multi_location_breakpoint_output_fixed): Remove.
 291         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 292         new variable.
 293         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 294         fix_multi_location_breakpoint_output flag if version >= 3.
 295         * ui-out.h (enum ui_out_flag)
 296         <fix_multi_location_breakpoint_output>: New enumerator.
 297
 298 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 299
 300         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 301
 302 2019-05-10  Tom Tromey  <tromey@adacore.com>
 303
 304         * ada-lang.c (catch_ada_completer): New function.
 305         (_initialize_ada_language): Use it.
 306
 307 2019-05-10  Tom Tromey  <tromey@adacore.com>
 308
 309         * thread.c (print_thread_info): Make "requested_threads" const.
 310         * gdbthread.h (print_thread_info): Make "requested_threads"
 311         const.
 312         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 313         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 314
 315 2019-05-08  Tom Tromey  <tom@tromey.com>
 316
 317         * gdbtypes.c (objfile_type_data): Change type.
 318         (objfile_type, _initialize_gdbtypes): Update.
 319
 320 2019-05-08  Tom Tromey  <tom@tromey.com>
 321
 322         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 323         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 324         (_initialize_dwarf2_frame): Update.
 325
 326 2019-05-08  Tom Tromey  <tom@tromey.com>
 327
 328         * objc-lang.c (objc_objfile_data): Change type.
 329         (find_methods): Update.
 330         (_initialize_objc_lang): Remove.
 331
 332 2019-05-08  Tom Tromey  <tom@tromey.com>
 333
 334         * stabsread.c (rs6000_builtin_type_data): Change type.
 335         (rs6000_builtin_type, _initialize_stabsread): Update.
 336
 337 2019-05-08  Tom Tromey  <tom@tromey.com>
 338
 339         * mips-tdep.c (mips_pdr_data): Remove.
 340         (_initialize_mips_tdep): Update.
 341
 342 2019-05-08  Tom Tromey  <tom@tromey.com>
 343
 344         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 345         (hppa_init_objfile_priv_data, read_unwind_info)
 346         (find_unwind_entry, _initialize_hppa_tdep): Update.
 347
 348 2019-05-08  Tom Tromey  <tom@tromey.com>
 349
 350         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 351         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 352         on obstack.
 353         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 354
 355 2019-05-08  Tom Tromey  <tom@tromey.com>
 356
 357         * mdebugread.c (basic_type_data): Change type.
 358         (basic_type, _initialize_mdebugread): Update.
 359
 360 2019-05-08  Tom Tromey  <tom@tromey.com>
 361
 362         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 363
 364 2019-05-08  Tom Tromey  <tom@tromey.com>
 365
 366         * nto-tdep.c (nto_inferior_data_reg): Change type.
 367         (nto_inferior_data): Update.
 368         (nto_inferior_data_cleanup, nto_new_inferior_data)
 369         (_initialize_nto_tdep): Remove.
 370         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 371
 372 2019-05-08  Tom Tromey  <tom@tromey.com>
 373
 374         * ada-lang.c (struct ada_inferior_data): Add initializers.
 375         (ada_inferior_data): Change type.
 376         (ada_inferior_data_cleanup): Remove.
 377         (get_ada_inferior_data, ada_inferior_exit)
 378         (struct ada_pspace_data): Add initializers, destructor.
 379         (ada_pspace_data_handle): Change type.
 380         (get_ada_pspace_data): Update.
 381         (ada_pspace_data_cleanup): Remove.
 382
 383 2019-05-08  Tom Tromey  <tom@tromey.com>
 384
 385         * coffread.c (struct coff_symfile_info): Add initializers.
 386         (coff_objfile_data_key): Move lower.  Change type.
 387         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 388         Update.
 389         (coff_free_info): Remove.
 390
 391 2019-05-08  Tom Tromey  <tom@tromey.com>
 392
 393         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 394         (fbsd_pspace_data_handle): Move lower.  Change type.
 395         (get_fbsd_pspace_data): Update.
 396         (fbsd_pspace_data_cleanup): Remove.
 397         (_initialize_fbsd_tdep): Update.
 398
 399 2019-05-08  Tom Tromey  <tom@tromey.com>
 400
 401         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 402         (get_ada_tasks_pspace_data): Update.
 403         (ada_tasks_pspace_data_cleanup): Remove.
 404         (_initialize_tasks): Update.
 405         (ada_tasks_inferior_data_handle): Change type.
 406         (get_ada_tasks_inferior_data): Update.
 407         (ada_tasks_inferior_data_cleanup): Remove.
 408         (struct ada_tasks_pspace_data): Add initializers.
 409
 410 2019-05-08  Tom Tromey  <tom@tromey.com>
 411
 412         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 413         * symfile-debug.c (debug_sym_get_probes): Change type.
 414         * stap-probe.c (handle_stap_probe):
 415         (stap_static_probe_ops::get_probes): Change type.
 416         * probe.h (class static_probe_ops) <get_probes>: Change type.
 417         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 418         (parse_probes_in_pspace): Update.
 419         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 420         Update.
 421         (any_static_probe_ops::get_probes): Change type.
 422         * elfread.c (elfread_data): New typedef.
 423         (probe_key): Change type.
 424         (elf_get_probes): Likewise.  Update.
 425         (probe_key_free): Remove.
 426         (_initialize_elfread): Update.
 427         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 428         Change type.
 429         (dtrace_process_dof_probe, dtrace_process_dof)
 430         (dtrace_static_probe_ops::get_probe): Change type.
 431
 432 2019-05-08  Tom Tromey  <tom@tromey.com>
 433
 434         * xcoffread.c (struct xcoff_symfile_info): Rename from
 435         coff_symfile_info.  Add initializers.
 436         (xcoff_objfile_data_key): Move lower.  Change type.
 437         (XCOFF_DATA): Rewrite.
 438         (xcoff_free_info): Remove.
 439         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 440         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 441         (xcoff_initial_scan): Update.
 442
 443 2019-05-08  Tom Tromey  <tom@tromey.com>
 444
 445         * solib-svr4.c (struct svr4_info): Add initializers and
 446         destructor.
 447         <probes_table>: Now an htab_up.
 448         (solib_svr4_pspace_data): Change type.
 449         (free_probes_table): Simplify.
 450         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 451         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 452         (probes_table_remove_objfile_probes, register_solib_event_probe)
 453         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 454         (_initialize_svr4_solib): Update.
 455
 456 2019-05-08  Tom Tromey  <tom@tromey.com>
 457
 458         * remote.c (remote_pspace_data): Change type.
 459         (remote_pspace_data_cleanup): Remove.
 460         (get_remote_exec_file, set_pspace_remote_exec_file)
 461         (_initialize_remote): Update.
 462
 463 2019-05-08  Tom Tromey  <tom@tromey.com>
 464
 465         * breakpoint.c (breakpoint_objfile_key): Change type.
 466         (get_breakpoint_objfile_data): Update.
 467         (free_breakpoint_objfile_data): Remove.
 468         (_initialize_breakpoint): Update.
 469
 470 2019-05-08  Tom Tromey  <tom@tromey.com>
 471
 472         * linux-tdep.c (struct linux_info): Add initializers.
 473         (linux_inferior_data): Move.  Change type.
 474         (invalidate_linux_cache_inf): Update.
 475         (linux_inferior_data_cleanup): Remove.
 476         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 477
 478 2019-05-08  Tom Tromey  <tom@tromey.com>
 479
 480         * auxv.c (auxv_inferior_data): Move.  Change type.
 481         (auxv_inferior_data_cleanup): Remove.
 482         (invalidate_auxv_cache_inf): Rewrite.
 483         (get_auxv_inferior_data, _initialize_auxv): Update.
 484
 485 2019-05-08  Tom Tromey  <tom@tromey.com>
 486
 487         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 488         (symfile_debug_objfile_data_key): Change type.
 489         (symfile_debug_installed, debug_qf_has_symbols)
 490         (debug_qf_find_last_source_symtab)
 491         (debug_qf_forget_cached_source_info)
 492         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 493         (debug_qf_print_stats, debug_qf_dump)
 494         (debug_qf_expand_symtabs_for_function)
 495         (debug_qf_expand_all_symtabs)
 496         (debug_qf_expand_symtabs_with_fullname)
 497         (debug_qf_map_matching_symbols)
 498         (debug_qf_expand_symtabs_matching)
 499         (debug_qf_find_pc_sect_compunit_symtab)
 500         (debug_qf_map_symbol_filenames)
 501         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 502         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 503         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 504         (debug_sym_read_linetable, debug_sym_relocate): Update.
 505         (symfile_debug_free_objfile): Remove.
 506         (install_symfile_debug_logging, _initialize_symfile_debug):
 507         Update.
 508
 509 2019-05-08  Tom Tromey  <tom@tromey.com>
 510
 511         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 512         allocate_on_obstack.
 513         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 514         (get_dwarf2_per_objfile): Update.
 515         (set_dwarf2_per_objfile): Remove.
 516         (dwarf2_has_info, dwarf2_get_section_info): Update.
 517         (dwarf2_free_objfile): Remove.
 518         (_initialize_dwarf2_read): Update.
 519
 520 2019-05-08  Tom Tromey  <tom@tromey.com>
 521
 522         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 523         initializers.
 524         <unsupported_script_warning_printed,
 525         script_not_found_warning_printed>: Now bool.
 526         (auto_load_pspace_data): Change type.
 527         (~auto_load_pspace_info): Rename from
 528         auto_load_pspace_data_cleanup.
 529         (get_auto_load_pspace_data, init_loaded_scripts_info)
 530         (clear_section_scripts, maybe_print_unsupported_script_warning)
 531         (maybe_print_script_not_found_warning, _initialize_auto_load):
 532         Update.
 533
 534 2019-05-08  Tom Tromey  <tom@tromey.com>
 535
 536         * objfiles.c (objfile_pspace_info): Add destructor and
 537         initializers.
 538         (objfiles_pspace_data): Change type.
 539         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 540         (get_objfile_pspace_data): Update.
 541         (objfiles_bfd_data): Change type.
 542         (get_objfile_bfd_data): Update.
 543         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 544
 545 2019-05-08  Tom Tromey  <tom@tromey.com>
 546
 547         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 548         Change type.
 549         (get_catch_syscall_inferior_data): Update.
 550         (catch_syscall_inferior_data_cleanup): Remove.
 551         (_initialize_break_catch_syscall): Update.
 552
 553 2019-05-08  Tom Tromey  <tom@tromey.com>
 554
 555         * inflow.c (struct terminal_info): Add destructor and
 556         initializers.
 557         (inflow_inferior_data): Change type.
 558         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 559         (get_inflow_inferior_data, inflow_inferior_exit)
 560         (swap_terminal_info, _initialize_inflow): Update.
 561
 562 2019-05-08  Tom Tromey  <tom@tromey.com>
 563
 564         * target-dcache.c (target_dcache_cleanup): Remove.
 565         (target_dcache_aspace_key): Change type.
 566         (target_dcache_init_p, target_dcache_invalidate)
 567         (target_dcache_get, target_dcache_get_or_init)
 568         (_initialize_target_dcache): Update.
 569         * dcache.h (struct dcache_deleter): New.
 570
 571 2019-05-08  Tom Tromey  <tom@tromey.com>
 572
 573         * symtab.c (struct symbol_cache): Add destructor and
 574         initializers.
 575         (symbol_cache_key): Move.  Change type.
 576         (make_symbol_cache, free_symbol_cache): Remove.
 577         (get_symbol_cache): Update.
 578         (symbol_cache_cleanup): Remove.
 579         (ALL_PSPACES, symbol_cache_flush)
 580         (maintenance_print_symbol_cache)
 581         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 582         Update.
 583
 584 2019-05-08  Tom Tromey  <tom@tromey.com>
 585
 586         * symtab.c (struct main_info): Add destructor and initializers.
 587         (main_progspace_key): Move.  Change type.
 588         (get_main_info): Update.
 589         (main_info_cleanup): Remove.
 590         (_initialize_symtab): Update.
 591
 592 2019-05-08  Tom Tromey  <tom@tromey.com>
 593
 594         * registry.h (DECLARE_REGISTRY): Define the _key class.
 595
 596 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * NEWS: Merge two 'New commands' sections.
 599
 600 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 601
 602         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 603         parameter and use Ada language definition instead.
 604         (ada_val_print_ptr): Remove unused language parameter.
 605         (ada_val_print_num): Remove language parameter and use Ada language
 606         definition instead.
 607         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 608         parameter.
 609         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 610         parameter and use Ada language definition instead.
 611         (ada_val_print_1): Update all ada_val_print_xxx calls.
 612         Remove language parameter.
 613         (ada_val_print): Update ada_val_print_1 call.
 614
 615 2019-05-08  Tom Tromey  <tromey@adacore.com>
 616
 617         * remote.c (remote_hw_watchpoint_limit)
 618         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 619         Now static.
 620
 621 2019-05-08  Tom Tromey  <tromey@adacore.com>
 622
 623         * maint.c (_initialize_maint_cmds): Move initialization code to
 624         remote.c.
 625         (watchdog, show_watchdog): Move to remote.c.
 626         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 627         "watchdog" static.
 628         (_initialize_remote): Move initialization code from maint.c.
 629         * defs.h (watchdog): Don't declare.
 630
 631 2019-05-08  Tom Tromey  <tromey@adacore.com>
 632
 633         * tui/tui-interp.c: Include main.h.
 634         * interps.c: Include main.h.
 635         * main.h (interpreter_p): Declare.
 636         * defs.h (interpreter_p): Don't declare.
 637
 638 2019-05-08  Tom Tromey  <tromey@adacore.com>
 639
 640         * dwarf2loc.c: Include dwarf2read.h.
 641         * defs.h (read_unsigned_leb128): Don't declare.
 642         * dwarf2read.h (read_unsigned_leb128): Declare.
 643
 644 2019-05-08  Tom Tromey  <tromey@adacore.com>
 645
 646         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 647         method.
 648
 649 2019-05-08  Tom Tromey  <tromey@adacore.com>
 650
 651         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 652         when no wrap column is set.
 653
 654 2019-05-08  Tom Tromey  <tromey@adacore.com>
 655
 656         * c-lang.c (c_get_string): Handle non-C-style arrays.
 657
 658 2019-05-08  Tom Tromey  <tromey@adacore.com>
 659
 660         * typeprint.c (print_offset_data::update): Print the bit offset,
 661         not the number of bits remaining.
 662
 663 2019-05-08  Tom Tromey  <tromey@adacore.com>
 664
 665         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 666         padding at end of comment.
 667
 668 2019-05-08  Tom Tromey  <tromey@adacore.com>
 669
 670         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 671         Compare main types.
 672
 673 2019-05-06  Tom Tromey  <tom@tromey.com>
 674
 675         * common/scoped_mmap.c: Include common-defs.h.
 676         * common/scoped_mmap.h: Don't include config.h.
 677
 678 2019-05-04  Tom Tromey  <tom@tromey.com>
 679
 680         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 681         (struct aarch64_call_info): Add initializers.
 682         <si>: Now a std::vector.
 683         (pass_on_stack, aarch64_push_dummy_call): Update.
 684
 685 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 686             Tom Tromey  <tom@tromey.com>
 687
 688         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 689         (ppc_threads): Now a std::vector.  Now static.
 690         (hwdebug_find_thread_points_by_tid)
 691         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 692         Update.
 693
 694 2019-05-04  Tom Tromey  <tom@tromey.com>
 695
 696         * arc-tdep.c (arc_tdesc_init): Return bool.
 697
 698 2019-05-04  Tom Tromey  <tom@tromey.com>
 699
 700         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 701         Use gdb_assert_not_reached.
 702
 703 2019-05-04  Tom Tromey  <tom@tromey.com>
 704
 705         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 706         "false".
 707
 708 2019-05-04  Tom Tromey  <tom@tromey.com>
 709
 710         * arc-tdep.c (arc_tdesc_init): Use bool.
 711
 712 2019-05-04  Tom Tromey  <tom@tromey.com>
 713
 714         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 715
 716 2019-05-04  Tom Tromey  <tom@tromey.com>
 717
 718         * cli/cli-cmds.c (valid_command_p): Return bool.
 719
 720 2019-05-04  Tom Tromey  <tom@tromey.com>
 721
 722         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 723         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 724
 725 2019-05-04  Raul Tambre  <raul@tambre.ee>
 726
 727         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 728         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 729         operator for comparison.
 730
 731 2019-05-04  Tom Tromey  <tom@tromey.com>
 732
 733         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 734         (lookup_partial_symbol, print_partial_symbols)
 735         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 736         (psymbol_compare): Update.
 737         (add_psymbol_to_bcache): Clear the entire psymbol.
 738         (maintenance_check_psymtabs): Update.
 739         * psympriv.h (struct partial_symbol): Don't derive from
 740         general_symbol_info.
 741         <obj_section, unrelocated_address, address,
 742         set_unrelocated_address>: Update.
 743         <ginfo>: New member.
 744         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 745         (debug_names::write_psymbols): Update.
 746
 747 2019-05-04  Tom de Vries  <tdevries@suse.de>
 748
 749         * contrib/cc-with-tweaks.sh: Support -n arg.
 750
 751 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 752
 753         * corelow.c (core_target::detach): Ensure frame cache and
 754         register caches are cleared.
 755         inferior.c (exit_inferior_1): Likewise.
 756
 757 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 758             Tom Tromey  <tom@tromey.com>
 759
 760         * dictionary.c (collate_pending_symbols_by_language): Remove
 761         "struct" from foreach.
 762         * symtab.c (lookup_global_symbol_from_objfile)
 763         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 764         foreach.
 765         * ser-tcp.c (net_open): Remove "struct" from foreach.
 766         * objfiles.c (objfile_relocate, objfile_rebase)
 767         (objfile_has_symbols): Remove "struct" from foreach.
 768         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 769         from foreach.
 770         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 771         foreach.
 772         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 773         "struct" from foreach.
 774         * ada-lang.c (create_excep_cond_exprs)
 775         (ada_exception_catchpoint_cond_string): Remove "struct" from
 776         foreach.
 777
 778 2019-05-03  Tom Tromey  <tromey@adacore.com>
 779
 780         * ada-exp.y (convert_char_literal): Check suffix of each
 781         enumerator.
 782
 783 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 784
 785         PR ada/21406:
 786         * ada-exp.y (yywrap): Don't define.
 787         * ada-lex.l (%option): Add noyywrap
 788         (yywrap): Remove.
 789
 790 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 791
 792         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 793         _WIN32_WINNT to the XP level, unless already defined to a higher
 794         level.
 795
 796         * unittests/parse-connection-spec-selftests.c:
 797         * ser-tcp.c:
 798         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 799         override.
 800
 801         * symfile.c (find_separate_debug_file): Remove colon from the
 802         drive spec of DOS/Windows file names of the target, so that the
 803         file name produced from DEBUGDIR and the target's directory will
 804         be valid on DOS/Windows systems.
 805
 806 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * rust-lang.c (val_print_struct): Handle printing structures
 809         containing strings.
 810
 811 2019-05-02  Tom Tromey  <tromey@adacore.com>
 812
 813         * valarith.c (_initialize_valarith): Remove.
 814
 815 2019-05-01  Tom Tromey  <tromey@adacore.com>
 816
 817         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 818         bitfields.
 819
 820 2019-05-01  Tom Tromey  <tromey@adacore.com>
 821
 822         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 823         for big-endian copies.
 824
 825 2019-04-30  Ali Tamur  <tamur@google.com>
 826         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 827         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 828         (read_3_bytes): New function.
 829
 830 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 831
 832         * windows-nat.c (main_thread_id): Delete.
 833         (handle_output_debug_string): Replace main_thread_id by
 834         current_event.dwThreadId.
 835         (fake_create_process): Likewise.
 836         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 837         Do not set main_thread_id.
 838         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 839         current_event.dwThreadId.
 840         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 841
 842 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 843
 844         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 845         Use current_event.dwThreadId instead of main_thread_id.
 846
 847 2019-04-30  Tom Tromey  <tromey@adacore.com>
 848
 849         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 850         (create_excep_cond_exprs): Iterate over program spaces.
 851         (ada_exception_catchpoint_cond_string): Examine all minimal
 852         symbols for exception types.
 853
 854 2019-04-30  Tom Tromey  <tromey@adacore.com>
 855
 856         PR c++/24470:
 857         * dwarf2read.c (process_structure_scope): Handle case where type
 858         has template parameters but no symbol was created.
 859
 860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 861             Chris January  <chris.january@arm.com>
 862
 863         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 864         qualifier.
 865         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 866
 867 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * f-typeprint.c (f_print_type): Update rules for printing
 870         whitespace.
 871         (f_type_print_varspec_suffix): Likewise.
 872
 873 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 874             Chris January  <chris.january@arm.com>
 875
 876         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 877         function arguments.
 878
 879 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * f-lang.c (build_fortran_types): Change name of void type to
 882         lower case.
 883         * f-typeprint.c (f_type_print_base): Print the name of the void
 884         type, rather than a fixed string.
 885         * f-valprint.c (f_decorations): Use lower case void string.
 886
 887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 888             Chris January  <chris.january@arm.com>
 889
 890         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 891         types for Fortran.
 892
 893 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 894             Chris January  <chris.january@arm.com>
 895             David Lecomber  <david.lecomber@arm.com>
 896
 897         * f-exp.y (BINOP_INTRINSIC): New token.
 898         (exp): New parser rule handling BINOP_INTRINSIC.
 899         (f77_keywords): Add new builtin procedures.
 900         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 901         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 902         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 903         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 904         (print_unop_subexp_f): New function.
 905         (print_binop_subexp_f): New function.
 906         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 907         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 908         (dump_subexp_body_f): Likewise.
 909         (operator_check_f): Likewise.
 910         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 911         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 912
 913 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 916         UNOP_KIND.
 917         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 918         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 919         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 920         (operator_length_f): New fuction.
 921         (print_subexp_f): New function.
 922         (op_name_f): New function.
 923         (dump_subexp_body_f): New function.
 924         (operator_check_f): New function.
 925         (exp_descriptor_f): Replace standard expression handling functions
 926         with new functions.
 927         * gdb/fortran-operator.def: New file.
 928         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 929         * gdb/std-operator.def: Remove UNOP_KIND.
 930
 931 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * std-operator.def: Remove unbalanced, stray double quote
 934         character.
 935
 936 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 937             Chris January  <chris.january@arm.com>
 938             Daniel Everett  <daniel.everett@arm.com>
 939             Nick Forrington  <nick.forrington@arm.com>
 940             Richard Bunt  <richard.bunt@arm.com>
 941
 942         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 943         of depth when printing anonymous structs or unions.
 944         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 945         Don't print either the top-level value, or the children if the
 946         max-depth is exceeded.
 947         (ppscm_print_children): When printing the key of a map, allow one
 948         extra level of depth.
 949         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 950         print either the top-level value, or the children if the max-depth
 951         is exceeded.
 952         (print_children): When printing the key of a map, allow one extra
 953         level of depth.
 954         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 955         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 956         (user_print_options): Initialise max_depth field.
 957         (val_print_scalar_or_string_type_p): New function.
 958         (val_print): Check to see if the max depth has been reached.
 959         (val_print_check_max_depth): Define new function.
 960         (show_print_max_depth): New function.
 961         (_initialize_valprint): Add 'print max-depth' option.
 962         * valprint.h (struct value_print_options) <max_depth>: New field.
 963         (val_print_check_max_depth): Declare new function.
 964         * NEWS: Document new feature.
 965
 966 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 967
 968         * ada-lang.c (ada_language_defn): Initialise new field.
 969         * c-lang.c (c_is_string_type_p): New function.
 970         (c_language_defn): Initialise new field.
 971         (cplus_language_defn): Initialise new field.
 972         (asm_language_defn): Initialise new field.
 973         (minimal_language_defn): Initialise new field.
 974         * c-lang.h (c_is_string_type_p): Declare new function.
 975         * d-lang.c (d_language_defn): Initialise new field.
 976         * f-lang.c (f_is_string_type_p): New function.
 977         (f_language_defn): Initialise new field.
 978         * go-lang.c (go_is_string_type_p): New function.
 979         (go_language_defn): Initialise new field.
 980         * language.c (default_is_string_type_p): New function.
 981         (unknown_language_defn): Initialise new field.
 982         (auto_language_defn): Initialise new field.
 983         * language.h (struct language_defn) <la_is_string_type_p>: New
 984         member variable.
 985         (default_is_string_type_p): Declare new function.
 986         * m2-lang.c (m2_language_defn): Initialise new field.
 987         * objc-lang.c (objc_language_defn): Initialise new field.
 988         * opencl-lang.c (opencl_language_defn): Initialise new field.
 989         * p-lang.c (pascal_is_string_type_p): New function.
 990         (pascal_language_defn): Initialise new field.
 991         * rust-lang.c (rust_is_string_type_p): New function.
 992         (rust_language_defn): Initialise new field.
 993
 994 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 997         New field.
 998         * ada-lang.c (ada_language_defn): Initialise new field.
 999         * c-lang.c (c_language_defn): Likewise.
1000         (cplus_language_defn): Likewise.
1001         (asm_language_defn): Likewise.
1002         (minimal_language_defn): Likewise.
1003         * d-lang.c (d_language_defn): Likewise.
1004         * f-lang.c (f_language_defn): Likewise.
1005         * go-lang.c (go_language_defn): Likewise.
1006         * language.c (unknown_language_defn): Likewise.
1007         (auto_language_defn): Likewise.
1008         * m2-lang.c (m2_language_defn): Likewise.
1009         * objc-lang.c (objc_language_defn): Likewise.
1010         * opencl-lang.c (opencl_language_defn): Likewise.
1011         * p-lang.c (pascal_language_defn): Likewise.
1012         * rust-lang.c (rust_language_defn): Likewise.
1013
1014 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * ada-lang.c (ada_is_character_type): Change return type to bool.
1017         (ada_is_string_type): Likewise.
1018         * ada-lang.h (ada_is_character_type): Update declaration
1019         (ada_is_string_type): Likewise.
1020
1021 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1022
1023         Support style in 'frame|thread apply'
1024
1025         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1026         * record.c (record_start, record_stop): Update callers of
1027         execute_command_to_string with false.
1028         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1029         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1030         methods.
1031         (class string_file): New constructor with term_out parameter.
1032         Override methods term_out and can_emit_style_escape.  New member
1033         term_out.
1034         (class stdio_file): Override can_emit_style_escape.
1035         (class tee_file): Override term_out and can_emit_style_escape.
1036         * utils.h (can_emit_style_escape): Remove.
1037         * utils.c (can_emit_style_escape): Likewise.
1038         Update all callers of can_emit_style_escape (SOMESTREAM) to
1039         SOMESTREAM->can_emit_style_escape.
1040         * source-cache.c (source_cache::get_source_lines): Likewise.
1041         * stack.c (frame_apply_command_count): Call execute_command_to_string
1042         passing the term_out characteristic of the current gdb_stdout.
1043         * thread.c (thr_try_catch_cmd): Likewise.
1044         * top.c (execute_command_to_string): pass term_out parameter
1045         to construct the string_file for the command output.
1046         * ui-file.c (term_cli_styling): New function (most code moved
1047         from utils.c can_emit_style_escape).
1048         (string_file::string_file, string_file::can_emit_style_escape,
1049         stdio_file::can_emit_style_escape, tee_file::term_out,
1050         tee_file::can_emit_style_escape): New functions.
1051
1052 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1053
1054         * NEWS: Mention the new set|show may-call-functions.
1055         * infcall.c (may_call_functions_p): New variable.
1056         (show_may_call_functions_p): New function.
1057         (call_function_by_hand_dummy): Throws an error if not
1058         may-call-functions.
1059         (_initialize_infcall): Call add_setshow_boolean_cmd for
1060         may-call-functions.
1061
1062 2019-04-25  Keith Seitz  <keiths@redhat.com>
1063
1064         PR c++/24367
1065         * cp-support.c (inspect_type): Don't attempt substitutions
1066         of symbol with the same name.
1067
1068 2019-04-25  Tom Tromey  <tromey@adacore.com>
1069
1070         PR gdb/24475:
1071         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1072         static.
1073
1074 2019-04-25  Tom Tromey  <tromey@adacore.com>
1075
1076         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1077         rvalue reference.
1078         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1079         (gdb_xml_parser::parse): Use std::move.
1080         * python/python-internal.h (gdbpy_convert_exception): Take a const
1081         reference.
1082         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1083         std::move.
1084         * python/py-utils.c (gdbpy_convert_exception): Take a const
1085         reference.
1086         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1087         Use std::move.
1088         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1089         Use std::move.
1090         * mi/mi-main.c (mi_print_exception): Take a const reference.
1091         * main.c (handle_command_errors): Take a const reference.
1092         * linespec.c (parse_linespec): Use std::move.
1093         * infcall.c (run_inferior_call): Use std::move.
1094         (call_function_by_hand_dummy): Use std::move.
1095         * exec.c (try_open_exec_file): Use std::move.
1096         * exceptions.h (exception_print, exception_fprintf)
1097         (exception_print_same): Update.
1098         * exceptions.c (print_exception, exception_print)
1099         (exception_fprintf, exception_print_same): Change parameters to
1100         const reference.
1101         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1102         * common/new-op.c: Use std::move.
1103         * common/common-exceptions.h (struct gdb_exception): Add move
1104         constructor.
1105         (struct gdb_exception_error, struct gdb_exception_quit, struct
1106         gdb_quit_bad_alloc): Change constructor to move constructor.
1107         (throw_exception): Change parameter to rvalue reference.
1108         * common/common-exceptions.c (throw_exception): Take rvalue
1109         reference.
1110         * cli/cli-interp.c (safe_execute_command): Use std::move.
1111         * breakpoint.c (insert_bp_location, location_to_sals): Use
1112         std::move.
1113
1114 2019-04-25  Tom Tromey  <tromey@adacore.com>
1115
1116         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1117         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1118         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1119         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1120         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1121         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1122         guile/scm-value.c: Use unpack.
1123         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1124         gdbscm_gdb_exception.
1125         (gdbscm_throw_gdb_exception): Likewise.
1126         (struct gdbscm_gdb_exception): New.
1127         (unpack): New function.
1128         (gdbscm_wrap): Use unpack.
1129
1130 2019-04-25  Tom Tromey  <tromey@adacore.com>
1131
1132         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1133         (gdb_rl_callback_handler): Use std::move.
1134         * common/common-exceptions.h (struct gdb_exception): Add move
1135         assignment operator.
1136         (throw_exception_sjlj): Change "exception" to const reference.
1137         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1138         (throw_exception_sjlj): Change "exception" to const reference.
1139
1140 2019-04-25  Tom Tromey  <tromey@adacore.com>
1141
1142         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1143         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1144         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1145         Update.
1146         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1147         Update.
1148         * mi/mi-interp.c (mi_interp::exec): Update.
1149         * linespec.c (parse_linespec): Update.
1150         * infcall.c (run_inferior_call): Update.
1151         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1152         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1153         (gdbscm_lookup_global_symbol): Update.
1154         * guile/scm-param.c (gdbscm_parameter_value): Update.
1155         * guile/scm-frame.c (gdbscm_frame_read_register)
1156         (gdbscm_frame_read_var): Update.
1157         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1158         * exec.c (try_open_exec_file): Update.
1159         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1160         (gdb_rl_callback_handler): Update.
1161         * common/common-exceptions.h (exception_none): Don't declare.
1162         * common/common-exceptions.c (exception_none): Don't define.
1163         (struct catcher) <exception>: Update.
1164         * cli/cli-interp.c (safe_execute_command): Update.
1165         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1166
1167 2019-04-25  Ali Tamur  <tamur@google.com>
1168
1169         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1170         (read_attribute_value): Likewise.
1171         (dwarf2_read_addr_index): Update comment.
1172         (read_str_index): Add DW_FORM_strx.
1173         (dwarf2_string_attr): Likewise.
1174         (dwarf2_const_value_attr): Likewise.
1175         (dump_die_shallow): Likewise.
1176         (dwarf2_fetch_constant_bytes): Likewise.
1177         (skip_form_bytes): Likewise.
1178         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1179
1180 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1181
1182         PR corefiles/11608
1183         PR corefiles/18187
1184         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1185         OFFSET.  Verify if current mapping contains an ELF header.
1186         (linux_find_memory_regions_full): Adjust call to
1187         dump_mapping_p.
1188
1189 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1190             Kang Li <kanglictf@gmail.com>
1191
1192         PR gdb/21600
1193
1194         * dwarf2-frame.c (read_initial_length): Be consistent about using
1195         unsigned representation of length.
1196         (decode_frame_entry_1): Likewise.  Check for wraparound of
1197         end pointer as well as buffer overflow.
1198
1199 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1200
1201         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1202         "vq".
1203
1204 2019-04-24  Tom Tromey  <tromey@adacore.com>
1205
1206         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1207
1208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * s12z-tdep.c (s12z_unwind_pc): Delete.
1211         (s12z_unwind_sp): Delete.
1212         (s12z_gdbarch_init): Don't register deleted functions with
1213         gdbarch.
1214
1215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * rl78-tdep.c (rl78_unwind_sp): Delete.
1218         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1219
1220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1223         (xstormy16_unwind_pc): Delete.
1224         (xstormy16_dummy_id): Delete.
1225         (xstormy16_gdbarch_init): Don't register deleted functions with
1226         gdbarch.
1227
1228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1229
1230         * vax-tdep.c (vax_unwind_pc): Delete.
1231         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1232
1233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * v850-tdep.c (v850_unwind_sp): Delete.
1236         (v850_unwind_pc): Delete.
1237         (v850_dummy_id): Delete.
1238         (v850_gdbarch_init): Don't register deleted functions with
1239         gdbarch.
1240
1241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1244         (tilegx_unwind_pc): Delete.
1245         (tilegx_unwind_dummy_id): Delete.
1246         (tilegx_gdbarch_init): Don't register deleted functions with
1247         gdbarch.
1248
1249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1250
1251         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1252         (tic6x_dummy_id): Delete.
1253         (tic6x_gdbarch_init): Don't register deleted functions with
1254         gdbarch.
1255
1256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * sparc-tdep.c (sparc_unwind_pc): Delete.
1259         (sparc32_gdbarch_init): Don't register deleted function with
1260         gdbarch.
1261
1262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * sh-tdep.c (sh_unwind_sp): Delete.
1265         (sh_unwind_pc): Delete.
1266         (sh_dummy_id): Delete.
1267         (sh_gdbarch_init): Don't register deleted functions with
1268         gdbarch.
1269
1270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * score-tdep.c (score_unwind_sp): Delete.
1273         (score_unwind_pc): Delete.
1274         (score_dummy_id): Delete.
1275         (score_gdbarch_init): Don't register deleted functions with
1276         gdbarch.
1277
1278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * rx-tdep.c (rx_unwind_pc): Delete.
1281         (rx_unwind_sp): Delete.
1282         (rx_dummy_id): Delete.
1283         (rx_gdbarch_init): Don't register deleted functions with
1284         gdbarch.  Update comment.
1285
1286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1289         (rs6000_dummy_id): Delete.
1290         (rs6000_gdbarch_init): Don't register deleted functions with
1291         gdbarch.
1292
1293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * or1k-tdep.c (or1k_dummy_id): Delete.
1296         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1297
1298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * nios2-tdep.c (nios2_dummy_id): Delete.
1301         (nios2_unwind_sp): Delete.
1302         (nios2_gdbarch_init): Don't register deleted functions with
1303         gdbarch.
1304
1305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * nds32-tdep.c (nds32_dummy_id): Delete.
1308         (nds32_unwind_pc): Delete.
1309         (nds32_unwind_sp): Delete.
1310         (nds32_gdbarch_init): Don't register deleted functions with
1311         gdbarch.
1312
1313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1314
1315         * msp430-tdep.c (msp430_unwind_pc): Delete.
1316         (msp430_unwind_sp): Delete.
1317         (msp430_dummy_id): Delete.
1318         (msp430_gdbarch_init): Don't register deleted functions with
1319         gdbarch.
1320
1321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1322
1323         * moxie-tdep.c (moxie_unwind_sp): Delete.
1324         (moxie_unwind_pc): Delete.
1325         (moxie_dummy_id): Delete.
1326         (moxie_gdbarch_init): Don't register deleted functions with
1327         gdbarch.
1328
1329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1332         (mn10300_unwind_pc): Delete.
1333         (mn10300_unwind_sp): Delete.
1334         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1335         mn10300_unwind_sp.
1336         (mn10300_frame_unwind_init): Don't register deleted functions with
1337         gdbarch.
1338
1339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1340
1341         * mep-tdep.c (mep_unwind_pc): Delete.
1342         (mep_unwind_sp): Delete.
1343         (mep_dummy_id): Delete.
1344         (mep_gdbarch_init): Don't register deleted functions with
1345         gdbarch.
1346
1347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1350         (m68hc11_unwind_sp): Delete.
1351         (m68hc11_gdbarch_init): Don't register deleted functions with
1352         gdbarch.
1353
1354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * m32r-tdep.c (m32r_unwind_sp): Delete.
1357         (m32r_unwind_pc): Delete.
1358         (m32r_dummy_id): Delete.
1359         (m32r_gdbarch_init): Don't register deleted functions with
1360         gdbarch.
1361
1362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1363
1364         * m32c-tdep.c (m32c_unwind_pc): Delete.
1365         (m32c_unwind_sp): Delete.
1366         (m32c_dummy_id): Delete.
1367         (m32c_gdbarch_init): Don't register deleted functions with
1368         gdbarch.
1369
1370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1371
1372         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1373         (lm32_unwind_pc): Delete.
1374         (lm32_dummy_id): Delete.
1375         (lm32_gdbarch_init): Don't register deleted functions with
1376         gdbarch.
1377
1378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1379
1380         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1381         (iq2000_unwind_pc): Delete.
1382         (iq2000_dummy_id): Delete.
1383         (iq2000_gdbarch_init): Don't register deleted functions with
1384         gdbarch.
1385
1386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1387
1388         * nds32-tdep.c (nds32_type_align): Delete.
1389         (nds32_push_dummy_call): Use type_align instead.
1390
1391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * arm-tdep.c (arm_type_align): Only handle vector override case.
1394         (arm_push_dummy_call): Use type_align.
1395         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1396
1397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1398
1399         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1400         case.
1401         (pass_on_stack): Use type_align.
1402         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1403         function.
1404
1405 2019-04-23  Tom Tromey  <tromey@adacore.com>
1406
1407         * dwarf2read.c (line_header::file_name_at): Remove unused
1408         overload.
1409
1410 2019-04-23  Tom de Vries  <tdevries@suse.de>
1411
1412         PR gdb/24438
1413         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1414         invocation.
1415
1416
1417 2019-03-27  Ali Tamur  <tamur@google.com>
1418
1419         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1420         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1421         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1422         (dwarf_expr_context::get_addr_index): Likewise
1423         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1424         (symbol_needs_eval_context::get_addr_index): Likewise
1425         (disassemble_dwarf_expression): Add DW_OP_addrx
1426         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1427         (read_cutu_die_from_dwo): Update comment
1428         (skip_one_die): Add DW_FORM_addrx
1429         (read_attribute_value): Likewise
1430         (var_decode_location): Add DW_OP_addrx
1431         (dwarf2_const_value_attr): Add DW_FORM_addrx
1432         (dump_die_shallow): Likewise
1433         (dwarf2_fetch_constant_bytes): Likewise
1434         (decode_locdesc): Add DW_OP_addrx
1435         (skip_form_bytes): Add DW_FORM_addrx
1436
1437 2019-04-22  Ali Tamur  <tamur@google.com>
1438
1439         * MAINTAINERS (Write After Approval): Add self.
1440
1441 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1442
1443         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1444         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1445         (open_symbol_file_object): Likewise.
1446         (svr4_default_sos): Add info parameter.
1447         (svr4_read_so_list): Likewise.
1448         (svr4_current_sos_direct): Adjust functions calls to pass down
1449         info.
1450         (svr4_current_sos_1): Add info parameter.
1451         (svr4_current_sos): Call get_svr4_info, pass info down to
1452         svr4_current_sos_1.
1453         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1454         get_svr4_info.
1455         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1456         get_svr4_info.
1457         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1458         to get_svr4_info.
1459         (probes_table_remove_objfile_probes): Likewise.
1460         (register_solib_event_probe): Add info parameter.
1461         (solist_update_incremental): Pass info parameter down to
1462         svr4_read_so_list.
1463         (disable_probes_interface): Add info parameter.
1464         (svr4_handle_solib_event): Pass current_program_space to
1465         get_svr4_info.  Adjust disable_probes_interface cleanup.
1466         (svr4_create_probe_breakpoints): Add info parameter, pass it
1467         down to register_solib_event_probe.
1468         (svr4_create_solib_event_breakpoints): Add info parameter,
1469         pass it down to svr4_create_probe_breakpoints.
1470         (enable_break): Pass info down to
1471         svr4_create_solib_event_breakpoints.
1472         (svr4_solib_create_inferior_hook): Pass current_program_space to
1473         get_svr4_info.
1474         (svr4_clear_solib): Likewise.
1475
1476 2019-04-22  Pedro Alves  <palves@redhat.com>
1477
1478         * solib-svr4.c (svr4_free_objfile_observer): New.
1479         (probe_and_action::objfile): New field.
1480         (probes_table_htab_remove_objfile_probes)
1481         (probes_table_remove_objfile_probes): New functions.
1482         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1483         in the new probe_and_action.  Don't store the probe in 'lookup'.
1484         (svr4_create_probe_breakpoints): Pass objfile to
1485         register_solib_event_probe.
1486         (_initialize_svr4_solib): Register a free_objfile observer.
1487
1488 2019-04-19  Tom Tromey  <tom@tromey.com>
1489
1490         * common/queue.h: Remove.
1491
1492 2019-04-19  Tom Tromey  <tom@tromey.com>
1493
1494         * event-loop.c: Don't include "common/queue.h".
1495
1496 2019-04-19  Tom Tromey  <tom@tromey.com>
1497
1498         * remote.c (remote_target): Use delete.
1499         * remote-notif.h: Include <list>, not "common/queue.h".
1500         (notif_client_p): Remove typedef.
1501         (remote_notif_state): Add constructor, destructor, initializer.
1502         <notif_queue>: Now a std::list.
1503         (remote_notif_state_xfree): Don't declare.
1504         * remote-notif.c (remote_notif_process, handle_notification)
1505         (remote_notif_state_allocate): Update.
1506         (~remote_notif_state): Rename from remote_notif_state_xfree.
1507
1508 2019-04-19  Tom Tromey  <tom@tromey.com>
1509
1510         * symfile.c (reread_symbols): Update.
1511         * objfiles.c (objfile_register_static_link)
1512         (objfile_lookup_static_link): Update
1513         (~objfile) Don't delete static_links.
1514         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1515
1516 2019-04-19  Tom Tromey  <tom@tromey.com>
1517
1518         * type-stack.h (struct type_stack) <insert>: Constify string.
1519         * type-stack.c (type_stack::insert): Constify string.
1520         * gdbtypes.h (lookup_template_type): Update.
1521         (address_space_name_to_int): Update.
1522         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1523         const.
1524         (lookup_template_type): Make name const.
1525         * c-exp.y: Update rules.
1526         (lex_one_token, classify_name, classify_inner_name)
1527         (c_print_token): Update.
1528         * p-exp.y: Update rules.
1529         (yylex): Update.
1530         * f-exp.y: Update rules.
1531         (yylex): Update.
1532         * d-exp.y: Update rules.
1533         (lex_one_token, classify_name, classify_inner_name): Update.
1534         * parse.c (write_dollar_variable, copy_name): Return std::string.
1535         * parser-defs.h (copy_name): Change return type.
1536         * m2-exp.y: Update rules.
1537         (yylex): Update.
1538         * go-exp.y (lex_one_token): Update.
1539         Update rules.
1540         (classify_unsafe_function, classify_packaged_name)
1541         (classify_name, yylex): Update.
1542
1543 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1544
1545         * configure.ac: add --enable-source-highlight switch.
1546         * configure: Regenerate.
1547         * top.c (print_gdb_version): plumb --enable-source-highlight
1548         status to "show configuration".
1549
1550 2019-04-19  Tom Tromey  <tromey@adacore.com>
1551
1552         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1553         Check ADA_TYPE_P.
1554         (empty_record, ada_template_to_fixed_record_type_1)
1555         (template_to_static_fixed_type)
1556         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1557         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1558         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1559         macros.
1560
1561 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1562
1563         PR symtab/24423:
1564         * source.c (print_source_lines_base): Advance "iter" when a
1565         control character is seen.
1566
1567 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1568
1569         * inferior.h (struct infcall_suspend_state_deleter):
1570         Catch exception in destructor to avoid crash.
1571
1572 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1573
1574         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1575         close to the add_com "shell".
1576
1577 2019-04-18  Tom Tromey  <tromey@adacore.com>
1578
1579         * process-stratum-target.h (class process_stratum_target)
1580         <stratum>: Add "final".
1581
1582 2019-04-17  Tom Tromey  <tromey@adacore.com>
1583
1584         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1585         against nullptr before use.
1586
1587 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1588
1589         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1590
1591 2019-04-17  Jim Wilson  <jimw@sifive.com>
1592             Andrew Burgess  <andrew.burgess@embecosm.com>
1593
1594         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1595         code read might fail, assume 4-byte breakpoint in that case.
1596
1597 2019-04-15  Leszek Swirski  <leszeks@google.com>
1598
1599         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1600         rather than a hand-rolled POD check when checking for forced MEMORY
1601         classification.
1602
1603 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1604
1605         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1606         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1607         function.
1608         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1609         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1610         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1611         declaration.
1612
1613 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1614
1615         * aarch64-linux-nat.c
1616         (aarch64_linux_nat_target::thread_architecture): Add override.
1617         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1618         each VQ.
1619
1620 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1621
1622         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1623
1624 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1625
1626         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1627         target types of size 96-bits, add some additional comments, and
1628         check that the builtin type we found was the correct size.
1629
1630 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1631
1632         * utils.c (prompt_for_continue): Don't restore the styling at the
1633         end, as applied_style has the wrong value.  This fixes styling in
1634         long lists of file names that are interrupted by the "Continue?"
1635         prompt.
1636
1637 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1638
1639         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1640         * c-lang.c (c_language_defn): Likewise.
1641         (cplus_language_defn): Likewise.
1642         (asm_language_defn): Likewise.
1643         (minimal_language_defn): Likewise.
1644         * d-lang.c (d_language_defn): Likewise.
1645         * f-lang.c (f_language_defn): Likewise.
1646         * go-lang.c (go_language_defn): Likewise.
1647         * language.c (unknown_language_defn): Likewise.
1648         (auto_language_defn): Likewise.
1649         * language.h (struct language_defn): Remove la_magic field.
1650         (LANG_MAGIC): Delete.
1651         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1652         * objc-lang.c (objc_language_defn): Likewise.
1653         * opencl-lang.c (opencl_language_defn): Likewise.
1654         * p-lang.c (pascal_language_defn): Likewise.
1655         * rust-lang.c (rust_language_defn): Likewise.
1656
1657 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * riscv-tdep.c (riscv_type_align): New function.
1660         (riscv_type_alignment): Delete.
1661         (riscv_arg_location): Use 'type_align'.
1662         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1663
1664 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * gdbtypes.c (type_align): A struct with no non-static fields also
1667         has alignment of 1.
1668
1669 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1672         component to 0.
1673         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1674         member.
1675         (riscv_struct_info::analyse): New implementation using new
1676         analyse_inner member function.
1677         (riscv_struct_info::field_offset): New member function.
1678         (riscv_struct_info::m_offsets): New member variable.
1679         (riscv_struct_info::analyse_inner): New private member function,
1680         takes the old implementation of riscv_struct_info::analyse but
1681         extended to track field offsets.
1682         (riscv_call_arg_struct): Update the struct folding special cases
1683         to handle cases where empty C++ structs, which are non-zero
1684         length, are found.
1685         (riscv_arg_location): Initialise the length of each location, a
1686         non-zero length now indicates the location is in use.
1687         (riscv_push_dummy_call): Allow for the first location having a
1688         non-zero offset when setting up arguments.
1689         (riscv_return_value): Likewise, but for return values.
1690
1691 2019-04-11  Tom Tromey  <tromey@adacore.com>
1692
1693         * utils.c (internal_vproblem): Make "msg" const.
1694
1695 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1696
1697         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1698         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1699         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1700         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1701
1702 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1703
1704         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1705         function.
1706         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1707         of amd64_collect_native_gregset.
1708         (amd64_linux_nat_target::store_registers): Likewise.
1709
1710 2019-04-10  Tom Tromey  <tom@tromey.com>
1711
1712         * symtab.c (lookup_global_symbol_from_objfile)
1713         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1714         * objfiles.h (class separate_debug_iterator): New.
1715         (class separate_debug_range): New.
1716         (struct objfile) <separate_debug_objfiles>: New method.
1717         (objfile_separate_debug_iterate): Don't declare.
1718         * objfiles.c (separate_debug_iterator::operator++): Rename from
1719         objfile_separate_debug_iterate.
1720         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1721         iterator.
1722         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1723         iterator.
1724
1725 2019-04-10  Tom Tromey  <tom@tromey.com>
1726
1727         * symfile.c (reread_symbols): Remove old comment.
1728         * objfiles.c (free_all_objfiles): Fix a typo.
1729
1730 2019-04-10  Tom Tromey  <tom@tromey.com>
1731
1732         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1733         * minsyms.c (lookup_minimal_symbol): Use foreach.
1734         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1735         (lookup_minimal_symbol_solib_trampoline): Likewise.
1736         * symfile.c (reread_symbols): Use foreach.
1737
1738 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1739             Tom Tromey  <tromey@adacore.com>
1740
1741         PR rust/24414:
1742         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1743         (rust_lex_int_test): Change "value" to be LONGEST.
1744         (rust_lex_tests): Add test for long integer literal.
1745
1746 2019-04-09  Tom Tromey  <tromey@adacore.com>
1747
1748         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1749         to bool.
1750         (extended_remote_target::attach): Update.
1751         (remote_target::remote_notice_new_inferior): Update.
1752         (remote_target::add_current_inferior_and_thread): Update.
1753         * inferior.c (exit_inferior_1): Use "false".
1754         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1755
1756 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1757
1758         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1759         the "start" command.
1760
1761 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1762
1763         * python/py-inferior.c (infpy_thread_from_thread_handle):
1764         Adjust comments to reflect renaming of thread_from_thread_handle
1765         to thread_from_handle.  Adjust keywords.  Fix type error message.
1766         (inferior_object_methods): Add thread_from_handle.  Retain
1767         thread_from_thread_handle, but mark it as deprecated.
1768
1769 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1770
1771         * gdbthread.h (find_thread_by_handle): Revise declaration.
1772         * thread.c (find_thread_by_handle): Likewise.  Adjust
1773         implementation too.
1774         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1775         support for buffer objects as handles.
1776
1777 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1778
1779         * python/py-infthread.c (thpy_thread_handle): New function.
1780         (thread_object_methods): Register thpy_thread_handle.
1781
1782 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1783
1784         * gdbthread.h (thread_to_thread_handle): Declare.
1785         * thread.c (gdbtypes.h): Include.
1786         (thread_to_thread_handle): New function.
1787
1788         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1789         (target_thread_info_to_thread_handle): Declare.
1790         * target.c (target_thread_info_to_thread_handle): New function.
1791         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1792         * target-delegates.c: Regenerate.
1793
1794         * linux-thread-db.c (class thread_db_target): Add method
1795         thread_info_to_thread_handle.
1796         (thread_db_target::thread_info_to_thread_handle): Define.
1797         * remote.c (class remote_target): Add new method
1798         thread_info_to_thread_handle.
1799         (remote_target::thread_info_to_thread_handle): Define.
1800
1801 2019-04-08  Pedro Alves  <palves@redhat.com>
1802
1803         * common/common-exceptions.c (throw_exception): Don't create
1804         named object to throw; throw directly.
1805         (throw_it): Likewise.  Don't initialize gdb_exception::message
1806         here, with new; pass FMT and AP to the ctor instead.
1807         * common/common-exceptions.h: Include <string>.
1808         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1809         const char *, va_list)): New ctor.  Use std::make_shared.
1810         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1811         errors)): Delete.
1812         (gdb_exception_error::gdb_exception_error(enum errors, const char
1813         *, va_list)): New.
1814         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1815         Add assertion.
1816         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1817         errors)): Delete.
1818         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1819         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1820         Add assertion.
1821
1822 2019-04-08  Tom Tromey  <tom@tromey.com>
1823
1824         * valops.c (value_rtti_indirect_type): Replace throw_exception
1825         with throw.
1826         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1827         with throw.
1828         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1829         throw.
1830         * target.c (target_translate_tls_address): Replace throw_exception
1831         with throw.
1832         * stack.c (frame_apply_command_count): Replace throw_exception
1833         with throw.
1834         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1835         throw.
1836         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1837         with throw.
1838         * rs6000-tdep.c (rs6000_frame_cache)
1839         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1840         * remote.c: Replace throw_exception with throw.
1841         * record-full.c (record_full_message, record_full_wait_1)
1842         (record_full_restore): Replace throw_exception with throw.
1843         * record-btrace.c:
1844         (get_thread_current_frame_id, record_btrace_start_replaying)
1845         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1846         (cmd_record_btrace_start): Replace throw_exception with throw.
1847         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1848         throw.
1849         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1850         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1851         * linespec.c:
1852         (find_linespec_symbols): Replace throw_exception with throw.
1853         * infrun.c (displaced_step_prepare, resume): Replace
1854         throw_exception with throw.
1855         * infcmd.c (post_create_inferior): Replace throw_exception with
1856         throw.
1857         * inf-loop.c (inferior_event_handler): Replace throw_exception
1858         with throw.
1859         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1860         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1861         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1862         (get_prev_frame_always, get_frame_pc_if_available)
1863         (get_frame_address_in_block_if_available, get_frame_language):
1864         Replace throw_exception with throw.
1865         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1866         throw_exception with throw.
1867         * eval.c (fetch_subexp_value, evaluate_var_value)
1868         (evaluate_funcall, evaluate_subexp_standard): Replace
1869         throw_exception with throw.
1870         * dwarf2loc.c (call_site_find_chain)
1871         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1872         Replace throw_exception with throw.
1873         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1874         with throw.
1875         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1876         throw.
1877         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1878         * completer.c (complete_line_internal): Replace throw_exception
1879         with throw.
1880         * compile/compile-object-run.c (compile_object_run): Replace
1881         throw_exception with throw.
1882         * cli/cli-script.c (process_next_line): Replace throw_exception
1883         with throw.
1884         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1885         (btrace_enable, btrace_maint_update_pt_packets): Replace
1886         throw_exception with throw.
1887         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1888         throw_exception with throw.
1889         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1890         throw_exception with throw.
1891         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1892         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1893         * aarch64-tdep.c (aarch64_make_prologue_cache)
1894         (aarch64_make_stub_cache): Replace throw_exception with throw.
1895
1896 2019-04-08  Tom Tromey  <tom@tromey.com>
1897
1898         * common/common-exceptions.c (throw_exception): Rename from
1899         throw_exception_cxx.  Remove old copy.  Make argument const.
1900         (throw_it): Create and throw exception objects directly.
1901         * common/common-exceptions.h (throw_exception): Make argument
1902         const.
1903         (struct gdb_exception_error): Add constructor.
1904         (struct gdb_exception_quit): Add constructor.
1905
1906 2019-04-08  Tom Tromey  <tom@tromey.com>
1907
1908         * common/common-exceptions.h (exception_rethrow): Don't declare.
1909         (TRY_SJLJ): Update comment.
1910         (TRY, CATCH, END_CATCH): Remove.
1911         * common/common-exceptions.c (exception_rethrow): Remove.
1912
1913 2019-04-08  Tom Tromey  <tom@tromey.com>
1914
1915         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1916         Remove.
1917         (gdb_exception_error): Rename from
1918         gdb_exception_RETURN_MASK_ERROR.
1919         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1920         (gdb_quit_bad_alloc): Update.
1921         * aarch64-tdep.c: Update.
1922         * ada-lang.c: Update.
1923         * ada-typeprint.c: Update.
1924         * ada-valprint.c: Update.
1925         * amd64-tdep.c: Update.
1926         * arch-utils.c: Update.
1927         * break-catch-throw.c: Update.
1928         * breakpoint.c: Update.
1929         * btrace.c: Update.
1930         * c-varobj.c: Update.
1931         * cli/cli-cmds.c: Update.
1932         * cli/cli-interp.c: Update.
1933         * cli/cli-script.c: Update.
1934         * common/common-exceptions.c: Update.
1935         * common/new-op.c: Update.
1936         * common/selftest.c: Update.
1937         * compile/compile-c-symbols.c: Update.
1938         * compile/compile-cplus-symbols.c: Update.
1939         * compile/compile-object-load.c: Update.
1940         * compile/compile-object-run.c: Update.
1941         * completer.c: Update.
1942         * corelow.c: Update.
1943         * cp-abi.c: Update.
1944         * cp-support.c: Update.
1945         * cp-valprint.c: Update.
1946         * darwin-nat.c: Update.
1947         * disasm-selftests.c: Update.
1948         * dtrace-probe.c: Update.
1949         * dwarf-index-cache.c: Update.
1950         * dwarf-index-write.c: Update.
1951         * dwarf2-frame-tailcall.c: Update.
1952         * dwarf2-frame.c: Update.
1953         * dwarf2loc.c: Update.
1954         * dwarf2read.c: Update.
1955         * eval.c: Update.
1956         * event-loop.c: Update.
1957         * event-top.c: Update.
1958         * exec.c: Update.
1959         * f-valprint.c: Update.
1960         * fbsd-tdep.c: Update.
1961         * frame-unwind.c: Update.
1962         * frame.c: Update.
1963         * gdbtypes.c: Update.
1964         * gnu-v3-abi.c: Update.
1965         * guile/guile-internal.h: Update.
1966         * guile/scm-block.c: Update.
1967         * guile/scm-breakpoint.c: Update.
1968         * guile/scm-cmd.c: Update.
1969         * guile/scm-disasm.c: Update.
1970         * guile/scm-frame.c: Update.
1971         * guile/scm-lazy-string.c: Update.
1972         * guile/scm-math.c: Update.
1973         * guile/scm-param.c: Update.
1974         * guile/scm-ports.c: Update.
1975         * guile/scm-pretty-print.c: Update.
1976         * guile/scm-symbol.c: Update.
1977         * guile/scm-symtab.c: Update.
1978         * guile/scm-type.c: Update.
1979         * guile/scm-value.c: Update.
1980         * i386-linux-tdep.c: Update.
1981         * i386-tdep.c: Update.
1982         * inf-loop.c: Update.
1983         * infcall.c: Update.
1984         * infcmd.c: Update.
1985         * infrun.c: Update.
1986         * jit.c: Update.
1987         * language.c: Update.
1988         * linespec.c: Update.
1989         * linux-fork.c: Update.
1990         * linux-nat.c: Update.
1991         * linux-tdep.c: Update.
1992         * linux-thread-db.c: Update.
1993         * main.c: Update.
1994         * mi/mi-cmd-break.c: Update.
1995         * mi/mi-cmd-stack.c: Update.
1996         * mi/mi-interp.c: Update.
1997         * mi/mi-main.c: Update.
1998         * objc-lang.c: Update.
1999         * p-valprint.c: Update.
2000         * parse.c: Update.
2001         * ppc-linux-tdep.c: Update.
2002         * printcmd.c: Update.
2003         * python/py-arch.c: Update.
2004         * python/py-breakpoint.c: Update.
2005         * python/py-cmd.c: Update.
2006         * python/py-finishbreakpoint.c: Update.
2007         * python/py-frame.c: Update.
2008         * python/py-framefilter.c: Update.
2009         * python/py-gdb-readline.c: Update.
2010         * python/py-inferior.c: Update.
2011         * python/py-infthread.c: Update.
2012         * python/py-lazy-string.c: Update.
2013         * python/py-linetable.c: Update.
2014         * python/py-objfile.c: Update.
2015         * python/py-param.c: Update.
2016         * python/py-prettyprint.c: Update.
2017         * python/py-progspace.c: Update.
2018         * python/py-record-btrace.c: Update.
2019         * python/py-record.c: Update.
2020         * python/py-symbol.c: Update.
2021         * python/py-type.c: Update.
2022         * python/py-unwind.c: Update.
2023         * python/py-utils.c: Update.
2024         * python/py-value.c: Update.
2025         * python/python.c: Update.
2026         * record-btrace.c: Update.
2027         * record-full.c: Update.
2028         * remote-fileio.c: Update.
2029         * remote.c: Update.
2030         * riscv-tdep.c: Update.
2031         * rs6000-aix-tdep.c: Update.
2032         * rs6000-tdep.c: Update.
2033         * rust-exp.y: Update.
2034         * rust-lang.c: Update.
2035         * s390-tdep.c: Update.
2036         * selftest-arch.c: Update.
2037         * solib-dsbt.c: Update.
2038         * solib-frv.c: Update.
2039         * solib-spu.c: Update.
2040         * solib-svr4.c: Update.
2041         * solib.c: Update.
2042         * sparc64-linux-tdep.c: Update.
2043         * stack.c: Update.
2044         * symfile-mem.c: Update.
2045         * symmisc.c: Update.
2046         * target.c: Update.
2047         * thread.c: Update.
2048         * top.c: Update.
2049         * tracefile-tfile.c: Update.
2050         * tui/tui.c: Update.
2051         * typeprint.c: Update.
2052         * unittests/cli-utils-selftests.c: Update.
2053         * unittests/parse-connection-spec-selftests.c: Update.
2054         * valops.c: Update.
2055         * valprint.c: Update.
2056         * value.c: Update.
2057         * varobj.c: Update.
2058         * windows-nat.c: Update.
2059         * x86-linux-nat.c: Update.
2060         * xml-support.c: Update.
2061
2062 2019-04-08  Tom Tromey  <tom@tromey.com>
2063
2064         * xml-support.c: Use C++ exception handling.
2065         * x86-linux-nat.c: Use C++ exception handling.
2066         * windows-nat.c: Use C++ exception handling.
2067         * varobj.c: Use C++ exception handling.
2068         * value.c: Use C++ exception handling.
2069         * valprint.c: Use C++ exception handling.
2070         * valops.c: Use C++ exception handling.
2071         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2072         handling.
2073         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2074         * typeprint.c: Use C++ exception handling.
2075         * tui/tui.c: Use C++ exception handling.
2076         * tracefile-tfile.c: Use C++ exception handling.
2077         * top.c: Use C++ exception handling.
2078         * thread.c: Use C++ exception handling.
2079         * target.c: Use C++ exception handling.
2080         * symmisc.c: Use C++ exception handling.
2081         * symfile-mem.c: Use C++ exception handling.
2082         * stack.c: Use C++ exception handling.
2083         * sparc64-linux-tdep.c: Use C++ exception handling.
2084         * solib.c: Use C++ exception handling.
2085         * solib-svr4.c: Use C++ exception handling.
2086         * solib-spu.c: Use C++ exception handling.
2087         * solib-frv.c: Use C++ exception handling.
2088         * solib-dsbt.c: Use C++ exception handling.
2089         * selftest-arch.c: Use C++ exception handling.
2090         * s390-tdep.c: Use C++ exception handling.
2091         * rust-lang.c: Use C++ exception handling.
2092         * rust-exp.y: Use C++ exception handling.
2093         * rs6000-tdep.c: Use C++ exception handling.
2094         * rs6000-aix-tdep.c: Use C++ exception handling.
2095         * riscv-tdep.c: Use C++ exception handling.
2096         * remote.c: Use C++ exception handling.
2097         * remote-fileio.c: Use C++ exception handling.
2098         * record-full.c: Use C++ exception handling.
2099         * record-btrace.c: Use C++ exception handling.
2100         * python/python.c: Use C++ exception handling.
2101         * python/py-value.c: Use C++ exception handling.
2102         * python/py-utils.c: Use C++ exception handling.
2103         * python/py-unwind.c: Use C++ exception handling.
2104         * python/py-type.c: Use C++ exception handling.
2105         * python/py-symbol.c: Use C++ exception handling.
2106         * python/py-record.c: Use C++ exception handling.
2107         * python/py-record-btrace.c: Use C++ exception handling.
2108         * python/py-progspace.c: Use C++ exception handling.
2109         * python/py-prettyprint.c: Use C++ exception handling.
2110         * python/py-param.c: Use C++ exception handling.
2111         * python/py-objfile.c: Use C++ exception handling.
2112         * python/py-linetable.c: Use C++ exception handling.
2113         * python/py-lazy-string.c: Use C++ exception handling.
2114         * python/py-infthread.c: Use C++ exception handling.
2115         * python/py-inferior.c: Use C++ exception handling.
2116         * python/py-gdb-readline.c: Use C++ exception handling.
2117         * python/py-framefilter.c: Use C++ exception handling.
2118         * python/py-frame.c: Use C++ exception handling.
2119         * python/py-finishbreakpoint.c: Use C++ exception handling.
2120         * python/py-cmd.c: Use C++ exception handling.
2121         * python/py-breakpoint.c: Use C++ exception handling.
2122         * python/py-arch.c: Use C++ exception handling.
2123         * printcmd.c: Use C++ exception handling.
2124         * ppc-linux-tdep.c: Use C++ exception handling.
2125         * parse.c: Use C++ exception handling.
2126         * p-valprint.c: Use C++ exception handling.
2127         * objc-lang.c: Use C++ exception handling.
2128         * mi/mi-main.c: Use C++ exception handling.
2129         * mi/mi-interp.c: Use C++ exception handling.
2130         * mi/mi-cmd-stack.c: Use C++ exception handling.
2131         * mi/mi-cmd-break.c: Use C++ exception handling.
2132         * main.c: Use C++ exception handling.
2133         * linux-thread-db.c: Use C++ exception handling.
2134         * linux-tdep.c: Use C++ exception handling.
2135         * linux-nat.c: Use C++ exception handling.
2136         * linux-fork.c: Use C++ exception handling.
2137         * linespec.c: Use C++ exception handling.
2138         * language.c: Use C++ exception handling.
2139         * jit.c: Use C++ exception handling.
2140         * infrun.c: Use C++ exception handling.
2141         * infcmd.c: Use C++ exception handling.
2142         * infcall.c: Use C++ exception handling.
2143         * inf-loop.c: Use C++ exception handling.
2144         * i386-tdep.c: Use C++ exception handling.
2145         * i386-linux-tdep.c: Use C++ exception handling.
2146         * guile/scm-value.c: Use C++ exception handling.
2147         * guile/scm-type.c: Use C++ exception handling.
2148         * guile/scm-symtab.c: Use C++ exception handling.
2149         * guile/scm-symbol.c: Use C++ exception handling.
2150         * guile/scm-pretty-print.c: Use C++ exception handling.
2151         * guile/scm-ports.c: Use C++ exception handling.
2152         * guile/scm-param.c: Use C++ exception handling.
2153         * guile/scm-math.c: Use C++ exception handling.
2154         * guile/scm-lazy-string.c: Use C++ exception handling.
2155         * guile/scm-frame.c: Use C++ exception handling.
2156         * guile/scm-disasm.c: Use C++ exception handling.
2157         * guile/scm-cmd.c: Use C++ exception handling.
2158         * guile/scm-breakpoint.c: Use C++ exception handling.
2159         * guile/scm-block.c: Use C++ exception handling.
2160         * guile/guile-internal.h: Use C++ exception handling.
2161         * gnu-v3-abi.c: Use C++ exception handling.
2162         * gdbtypes.c: Use C++ exception handling.
2163         * frame.c: Use C++ exception handling.
2164         * frame-unwind.c: Use C++ exception handling.
2165         * fbsd-tdep.c: Use C++ exception handling.
2166         * f-valprint.c: Use C++ exception handling.
2167         * exec.c: Use C++ exception handling.
2168         * event-top.c: Use C++ exception handling.
2169         * event-loop.c: Use C++ exception handling.
2170         * eval.c: Use C++ exception handling.
2171         * dwarf2read.c: Use C++ exception handling.
2172         * dwarf2loc.c: Use C++ exception handling.
2173         * dwarf2-frame.c: Use C++ exception handling.
2174         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2175         * dwarf-index-write.c: Use C++ exception handling.
2176         * dwarf-index-cache.c: Use C++ exception handling.
2177         * dtrace-probe.c: Use C++ exception handling.
2178         * disasm-selftests.c: Use C++ exception handling.
2179         * darwin-nat.c: Use C++ exception handling.
2180         * cp-valprint.c: Use C++ exception handling.
2181         * cp-support.c: Use C++ exception handling.
2182         * cp-abi.c: Use C++ exception handling.
2183         * corelow.c: Use C++ exception handling.
2184         * completer.c: Use C++ exception handling.
2185         * compile/compile-object-run.c: Use C++ exception handling.
2186         * compile/compile-object-load.c: Use C++ exception handling.
2187         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2188         * compile/compile-c-symbols.c: Use C++ exception handling.
2189         * common/selftest.c: Use C++ exception handling.
2190         * common/new-op.c: Use C++ exception handling.
2191         * cli/cli-script.c: Use C++ exception handling.
2192         * cli/cli-interp.c: Use C++ exception handling.
2193         * cli/cli-cmds.c: Use C++ exception handling.
2194         * c-varobj.c: Use C++ exception handling.
2195         * btrace.c: Use C++ exception handling.
2196         * breakpoint.c: Use C++ exception handling.
2197         * break-catch-throw.c: Use C++ exception handling.
2198         * arch-utils.c: Use C++ exception handling.
2199         * amd64-tdep.c: Use C++ exception handling.
2200         * ada-valprint.c: Use C++ exception handling.
2201         * ada-typeprint.c: Use C++ exception handling.
2202         * ada-lang.c: Use C++ exception handling.
2203         * aarch64-tdep.c: Use C++ exception handling.
2204
2205 2019-04-08  Tom Tromey  <tom@tromey.com>
2206
2207         * xml-support.c (gdb_xml_parser::parse): Update.
2208         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2209         * value.c (show_convenience): Update.
2210         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2211         (test_parse_flags_qcs): Update.
2212         * thread.c (thr_try_catch_cmd): Update.
2213         * target.c (target_translate_tls_address): Update.
2214         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2215         (info_frame_command_core, frame_apply_command_count): Update.
2216         * rust-exp.y (rust_lex_exception_test): Update.
2217         * riscv-tdep.c (riscv_print_one_register_info): Update.
2218         * remote.c (remote_target::enable_btrace): Update.
2219         * record-btrace.c (record_btrace_enable_warn): Update.
2220         * python/py-utils.c (gdbpy_convert_exception): Update.
2221         * printcmd.c (do_one_display, print_variable_and_value): Update.
2222         * mi/mi-main.c (mi_print_exception): Update.
2223         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2224         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2225         * linux-nat.c (linux_nat_target::attach): Update.
2226         * linux-fork.c (class scoped_switch_fork_info): Update.
2227         * infrun.c (displaced_step_prepare): Update.
2228         * infcall.c (call_function_by_hand_dummy): Update.
2229         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2230         * gnu-v3-abi.c (print_one_vtable): Update.
2231         * frame.c (get_prev_frame_always): Update.
2232         * f-valprint.c (info_common_command_for_block): Update.
2233         * exec.c (try_open_exec_file): Update.
2234         * exceptions.c (print_exception, exception_print)
2235         (exception_fprintf, exception_print_same): Update.
2236         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2237         * dwarf-index-cache.c (index_cache::store)
2238         (index_cache::lookup_gdb_index): Update.
2239         * darwin-nat.c (maybe_cache_shell): Update.
2240         * cp-valprint.c (cp_print_value_fields): Update.
2241         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2242         (gcc_cplus_symbol_address): Update.
2243         * compile/compile-c-symbols.c (gcc_convert_symbol)
2244         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2245         * common/selftest.c: Update.
2246         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2247         a std::string.
2248         (exception_try_scope_entry, exception_try_scope_exit): Don't
2249         declare.
2250         (struct exception_try_scope): Remove.
2251         (TRY): Don't use exception_try_scope.
2252         (struct gdb_exception): Add constructor, operator=.
2253         <what>: New method.
2254         (struct gdb_exception_RETURN_MASK_ALL)
2255         (struct gdb_exception_RETURN_MASK_ERROR)
2256         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2257         (struct gdb_quit_bad_alloc): Update.
2258         * common/common-exceptions.c (exception_none): Change
2259         initializer.
2260         (struct catcher) <state, exception>: Initialize inline.
2261         <prev>: Remove member.
2262         (current_catcher): Remove.
2263         (catchers): New global.
2264         (exceptions_state_mc_init): Simplify.
2265         (catcher_pop): Remove.
2266         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2267         (try_scope_depth, exception_try_scope_entry)
2268         (exception_try_scope_exit): Remove.
2269         (throw_exception_sjlj): Update.
2270         (exception_messages, exception_messages_size): Remove.
2271         (throw_it): Simplify.
2272         (gdb_exception_sliced_copy): Remove.
2273         (throw_exception_cxx): Update.
2274         * cli/cli-script.c (script_from_file): Update.
2275         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2276         Update.
2277         * ada-valprint.c (ada_val_print): Update.
2278         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2279         (create_excep_cond_exprs): Update.
2280
2281 2019-04-08  Tom Tromey  <tom@tromey.com>
2282
2283         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2284         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2285         (TRY, CATCH, END_CATCH): Remove some definitions.
2286         * common/common-exceptions.c: Don't use GDB_XCPT.
2287         (catcher_list_size): Remove.
2288         (throw_exception, throw_it): Simplify.
2289
2290 2019-04-05  Tom Tromey  <tom@tromey.com>
2291
2292         Revert the header-sorting patch.
2293         * ft32-tdep.c: Revert.
2294         * frv-tdep.c: Revert.
2295         * frv-linux-tdep.c: Revert.
2296         * frame.c: Revert.
2297         * frame-unwind.c: Revert.
2298         * frame-base.c: Revert.
2299         * fork-child.c: Revert.
2300         * findvar.c: Revert.
2301         * findcmd.c: Revert.
2302         * filesystem.c: Revert.
2303         * filename-seen-cache.h: Revert.
2304         * filename-seen-cache.c: Revert.
2305         * fbsd-tdep.c: Revert.
2306         * fbsd-nat.h: Revert.
2307         * fbsd-nat.c: Revert.
2308         * f-valprint.c: Revert.
2309         * f-typeprint.c: Revert.
2310         * f-lang.c: Revert.
2311         * extension.h: Revert.
2312         * extension.c: Revert.
2313         * extension-priv.h: Revert.
2314         * expprint.c: Revert.
2315         * exec.h: Revert.
2316         * exec.c: Revert.
2317         * exceptions.c: Revert.
2318         * event-top.c: Revert.
2319         * event-loop.c: Revert.
2320         * eval.c: Revert.
2321         * elfread.c: Revert.
2322         * dwarf2read.h: Revert.
2323         * dwarf2read.c: Revert.
2324         * dwarf2loc.c: Revert.
2325         * dwarf2expr.h: Revert.
2326         * dwarf2expr.c: Revert.
2327         * dwarf2-frame.c: Revert.
2328         * dwarf2-frame-tailcall.c: Revert.
2329         * dwarf-index-write.h: Revert.
2330         * dwarf-index-write.c: Revert.
2331         * dwarf-index-common.c: Revert.
2332         * dwarf-index-cache.h: Revert.
2333         * dwarf-index-cache.c: Revert.
2334         * dummy-frame.c: Revert.
2335         * dtrace-probe.c: Revert.
2336         * disasm.h: Revert.
2337         * disasm.c: Revert.
2338         * disasm-selftests.c: Revert.
2339         * dictionary.c: Revert.
2340         * dicos-tdep.c: Revert.
2341         * demangle.c: Revert.
2342         * dcache.h: Revert.
2343         * dcache.c: Revert.
2344         * darwin-nat.h: Revert.
2345         * darwin-nat.c: Revert.
2346         * darwin-nat-info.c: Revert.
2347         * d-valprint.c: Revert.
2348         * d-namespace.c: Revert.
2349         * d-lang.c: Revert.
2350         * ctf.c: Revert.
2351         * csky-tdep.c: Revert.
2352         * csky-linux-tdep.c: Revert.
2353         * cris-tdep.c: Revert.
2354         * cris-linux-tdep.c: Revert.
2355         * cp-valprint.c: Revert.
2356         * cp-support.c: Revert.
2357         * cp-namespace.c: Revert.
2358         * cp-abi.c: Revert.
2359         * corelow.c: Revert.
2360         * corefile.c: Revert.
2361         * continuations.c: Revert.
2362         * completer.h: Revert.
2363         * completer.c: Revert.
2364         * complaints.c: Revert.
2365         * coffread.c: Revert.
2366         * coff-pe-read.c: Revert.
2367         * cli-out.h: Revert.
2368         * cli-out.c: Revert.
2369         * charset.c: Revert.
2370         * c-varobj.c: Revert.
2371         * c-valprint.c: Revert.
2372         * c-typeprint.c: Revert.
2373         * c-lang.c: Revert.
2374         * buildsym.c: Revert.
2375         * buildsym-legacy.c: Revert.
2376         * build-id.h: Revert.
2377         * build-id.c: Revert.
2378         * btrace.c: Revert.
2379         * bsd-uthread.c: Revert.
2380         * breakpoint.h: Revert.
2381         * breakpoint.c: Revert.
2382         * break-catch-throw.c: Revert.
2383         * break-catch-syscall.c: Revert.
2384         * break-catch-sig.c: Revert.
2385         * blockframe.c: Revert.
2386         * block.c: Revert.
2387         * bfin-tdep.c: Revert.
2388         * bfin-linux-tdep.c: Revert.
2389         * bfd-target.c: Revert.
2390         * bcache.c: Revert.
2391         * ax-general.c: Revert.
2392         * ax-gdb.h: Revert.
2393         * ax-gdb.c: Revert.
2394         * avr-tdep.c: Revert.
2395         * auxv.c: Revert.
2396         * auto-load.c: Revert.
2397         * arm-wince-tdep.c: Revert.
2398         * arm-tdep.c: Revert.
2399         * arm-symbian-tdep.c: Revert.
2400         * arm-pikeos-tdep.c: Revert.
2401         * arm-obsd-tdep.c: Revert.
2402         * arm-nbsd-tdep.c: Revert.
2403         * arm-nbsd-nat.c: Revert.
2404         * arm-linux-tdep.c: Revert.
2405         * arm-linux-nat.c: Revert.
2406         * arm-fbsd-tdep.c: Revert.
2407         * arm-fbsd-nat.c: Revert.
2408         * arm-bsd-tdep.c: Revert.
2409         * arch-utils.c: Revert.
2410         * arc-tdep.c: Revert.
2411         * arc-newlib-tdep.c: Revert.
2412         * annotate.h: Revert.
2413         * annotate.c: Revert.
2414         * amd64-windows-tdep.c: Revert.
2415         * amd64-windows-nat.c: Revert.
2416         * amd64-tdep.c: Revert.
2417         * amd64-sol2-tdep.c: Revert.
2418         * amd64-obsd-tdep.c: Revert.
2419         * amd64-obsd-nat.c: Revert.
2420         * amd64-nbsd-tdep.c: Revert.
2421         * amd64-nbsd-nat.c: Revert.
2422         * amd64-nat.c: Revert.
2423         * amd64-linux-tdep.c: Revert.
2424         * amd64-linux-nat.c: Revert.
2425         * amd64-fbsd-tdep.c: Revert.
2426         * amd64-fbsd-nat.c: Revert.
2427         * amd64-dicos-tdep.c: Revert.
2428         * amd64-darwin-tdep.c: Revert.
2429         * amd64-bsd-nat.c: Revert.
2430         * alpha-tdep.c: Revert.
2431         * alpha-obsd-tdep.c: Revert.
2432         * alpha-nbsd-tdep.c: Revert.
2433         * alpha-mdebug-tdep.c: Revert.
2434         * alpha-linux-tdep.c: Revert.
2435         * alpha-linux-nat.c: Revert.
2436         * alpha-bsd-tdep.c: Revert.
2437         * alpha-bsd-nat.c: Revert.
2438         * aix-thread.c: Revert.
2439         * agent.c: Revert.
2440         * addrmap.c: Revert.
2441         * ada-varobj.c: Revert.
2442         * ada-valprint.c: Revert.
2443         * ada-typeprint.c: Revert.
2444         * ada-tasks.c: Revert.
2445         * ada-lang.c: Revert.
2446         * aarch64-tdep.c: Revert.
2447         * aarch64-ravenscar-thread.c: Revert.
2448         * aarch64-newlib-tdep.c: Revert.
2449         * aarch64-linux-tdep.c: Revert.
2450         * aarch64-linux-nat.c: Revert.
2451         * aarch64-fbsd-tdep.c: Revert.
2452         * aarch64-fbsd-nat.c: Revert.
2453         * aarch32-linux-nat.c: Revert.
2454
2455 2019-04-05  Tom Tromey  <tom@tromey.com>
2456
2457         * ft32-tdep.c: Sort headers.
2458         * frv-tdep.c: Sort headers.
2459         * frv-linux-tdep.c: Sort headers.
2460         * frame.c: Sort headers.
2461         * frame-unwind.c: Sort headers.
2462         * frame-base.c: Sort headers.
2463         * fork-child.c: Sort headers.
2464         * findvar.c: Sort headers.
2465         * findcmd.c: Sort headers.
2466         * filesystem.c: Sort headers.
2467         * filename-seen-cache.h: Sort headers.
2468         * filename-seen-cache.c: Sort headers.
2469         * fbsd-tdep.c: Sort headers.
2470         * fbsd-nat.h: Sort headers.
2471         * fbsd-nat.c: Sort headers.
2472         * f-valprint.c: Sort headers.
2473         * f-typeprint.c: Sort headers.
2474         * f-lang.c: Sort headers.
2475         * extension.h: Sort headers.
2476         * extension.c: Sort headers.
2477         * extension-priv.h: Sort headers.
2478         * expprint.c: Sort headers.
2479         * exec.h: Sort headers.
2480         * exec.c: Sort headers.
2481         * exceptions.c: Sort headers.
2482         * event-top.c: Sort headers.
2483         * event-loop.c: Sort headers.
2484         * eval.c: Sort headers.
2485         * elfread.c: Sort headers.
2486         * dwarf2read.h: Sort headers.
2487         * dwarf2read.c: Sort headers.
2488         * dwarf2loc.c: Sort headers.
2489         * dwarf2expr.h: Sort headers.
2490         * dwarf2expr.c: Sort headers.
2491         * dwarf2-frame.c: Sort headers.
2492         * dwarf2-frame-tailcall.c: Sort headers.
2493         * dwarf-index-write.h: Sort headers.
2494         * dwarf-index-write.c: Sort headers.
2495         * dwarf-index-common.c: Sort headers.
2496         * dwarf-index-cache.h: Sort headers.
2497         * dwarf-index-cache.c: Sort headers.
2498         * dummy-frame.c: Sort headers.
2499         * dtrace-probe.c: Sort headers.
2500         * disasm.h: Sort headers.
2501         * disasm.c: Sort headers.
2502         * disasm-selftests.c: Sort headers.
2503         * dictionary.c: Sort headers.
2504         * dicos-tdep.c: Sort headers.
2505         * demangle.c: Sort headers.
2506         * dcache.h: Sort headers.
2507         * dcache.c: Sort headers.
2508         * darwin-nat.h: Sort headers.
2509         * darwin-nat.c: Sort headers.
2510         * darwin-nat-info.c: Sort headers.
2511         * d-valprint.c: Sort headers.
2512         * d-namespace.c: Sort headers.
2513         * d-lang.c: Sort headers.
2514         * ctf.c: Sort headers.
2515         * csky-tdep.c: Sort headers.
2516         * csky-linux-tdep.c: Sort headers.
2517         * cris-tdep.c: Sort headers.
2518         * cris-linux-tdep.c: Sort headers.
2519         * cp-valprint.c: Sort headers.
2520         * cp-support.c: Sort headers.
2521         * cp-namespace.c: Sort headers.
2522         * cp-abi.c: Sort headers.
2523         * corelow.c: Sort headers.
2524         * corefile.c: Sort headers.
2525         * continuations.c: Sort headers.
2526         * completer.h: Sort headers.
2527         * completer.c: Sort headers.
2528         * complaints.c: Sort headers.
2529         * coffread.c: Sort headers.
2530         * coff-pe-read.c: Sort headers.
2531         * cli-out.h: Sort headers.
2532         * cli-out.c: Sort headers.
2533         * charset.c: Sort headers.
2534         * c-varobj.c: Sort headers.
2535         * c-valprint.c: Sort headers.
2536         * c-typeprint.c: Sort headers.
2537         * c-lang.c: Sort headers.
2538         * buildsym.c: Sort headers.
2539         * buildsym-legacy.c: Sort headers.
2540         * build-id.h: Sort headers.
2541         * build-id.c: Sort headers.
2542         * btrace.c: Sort headers.
2543         * bsd-uthread.c: Sort headers.
2544         * breakpoint.h: Sort headers.
2545         * breakpoint.c: Sort headers.
2546         * break-catch-throw.c: Sort headers.
2547         * break-catch-syscall.c: Sort headers.
2548         * break-catch-sig.c: Sort headers.
2549         * blockframe.c: Sort headers.
2550         * block.c: Sort headers.
2551         * bfin-tdep.c: Sort headers.
2552         * bfin-linux-tdep.c: Sort headers.
2553         * bfd-target.c: Sort headers.
2554         * bcache.c: Sort headers.
2555         * ax-general.c: Sort headers.
2556         * ax-gdb.h: Sort headers.
2557         * ax-gdb.c: Sort headers.
2558         * avr-tdep.c: Sort headers.
2559         * auxv.c: Sort headers.
2560         * auto-load.c: Sort headers.
2561         * arm-wince-tdep.c: Sort headers.
2562         * arm-tdep.c: Sort headers.
2563         * arm-symbian-tdep.c: Sort headers.
2564         * arm-pikeos-tdep.c: Sort headers.
2565         * arm-obsd-tdep.c: Sort headers.
2566         * arm-nbsd-tdep.c: Sort headers.
2567         * arm-nbsd-nat.c: Sort headers.
2568         * arm-linux-tdep.c: Sort headers.
2569         * arm-linux-nat.c: Sort headers.
2570         * arm-fbsd-tdep.c: Sort headers.
2571         * arm-fbsd-nat.c: Sort headers.
2572         * arm-bsd-tdep.c: Sort headers.
2573         * arch-utils.c: Sort headers.
2574         * arc-tdep.c: Sort headers.
2575         * arc-newlib-tdep.c: Sort headers.
2576         * annotate.h: Sort headers.
2577         * annotate.c: Sort headers.
2578         * amd64-windows-tdep.c: Sort headers.
2579         * amd64-windows-nat.c: Sort headers.
2580         * amd64-tdep.c: Sort headers.
2581         * amd64-sol2-tdep.c: Sort headers.
2582         * amd64-obsd-tdep.c: Sort headers.
2583         * amd64-obsd-nat.c: Sort headers.
2584         * amd64-nbsd-tdep.c: Sort headers.
2585         * amd64-nbsd-nat.c: Sort headers.
2586         * amd64-nat.c: Sort headers.
2587         * amd64-linux-tdep.c: Sort headers.
2588         * amd64-linux-nat.c: Sort headers.
2589         * amd64-fbsd-tdep.c: Sort headers.
2590         * amd64-fbsd-nat.c: Sort headers.
2591         * amd64-dicos-tdep.c: Sort headers.
2592         * amd64-darwin-tdep.c: Sort headers.
2593         * amd64-bsd-nat.c: Sort headers.
2594         * alpha-tdep.c: Sort headers.
2595         * alpha-obsd-tdep.c: Sort headers.
2596         * alpha-nbsd-tdep.c: Sort headers.
2597         * alpha-mdebug-tdep.c: Sort headers.
2598         * alpha-linux-tdep.c: Sort headers.
2599         * alpha-linux-nat.c: Sort headers.
2600         * alpha-bsd-tdep.c: Sort headers.
2601         * alpha-bsd-nat.c: Sort headers.
2602         * aix-thread.c: Sort headers.
2603         * agent.c: Sort headers.
2604         * addrmap.c: Sort headers.
2605         * ada-varobj.c: Sort headers.
2606         * ada-valprint.c: Sort headers.
2607         * ada-typeprint.c: Sort headers.
2608         * ada-tasks.c: Sort headers.
2609         * ada-lang.c: Sort headers.
2610         * aarch64-tdep.c: Sort headers.
2611         * aarch64-ravenscar-thread.c: Sort headers.
2612         * aarch64-newlib-tdep.c: Sort headers.
2613         * aarch64-linux-tdep.c: Sort headers.
2614         * aarch64-linux-nat.c: Sort headers.
2615         * aarch64-fbsd-tdep.c: Sort headers.
2616         * aarch64-fbsd-nat.c: Sort headers.
2617         * aarch32-linux-nat.c: Sort headers.
2618
2619 2019-04-04  Tom Tromey  <tom@tromey.com>
2620
2621         * varobj.c (varobj_create): Update.
2622         * rust-exp.y (struct rust_parser) <update_innermost_block,
2623         lookup_symbol>: New methods.
2624         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2625         Rename.
2626         (rust_parser::rust_lookup_type)
2627         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2628         * printcmd.c (display_command, do_one_display): Update.
2629         * parser-defs.h (struct parser_state) <parser_state>: Add
2630         "tracker" parameter.
2631         (block_tracker): New member.
2632         (class innermost_block_tracker) <innermost_block_tracker>: Add
2633         "types" parameter.
2634         <reset>: Remove method.
2635         (innermost_block): Don't declare.
2636         (null_post_parser): Update.
2637         * parse.c (innermost_block): Remove global.
2638         (write_dollar_variable): Update.
2639         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2640         Remove "tracker_types" parameter.
2641         (parse_expression): Add "tracker" parameter.
2642         (parse_expression_for_completion): Update.
2643         (null_post_parser): Add "tracker" parameter.
2644         * p-exp.y: Update rules.
2645         * m2-exp.y: Update rules.
2646         * language.h (struct language_defn) <la_post_parser>: Add
2647         "tracker" parameter.
2648         * go-exp.y: Update rules.
2649         * f-exp.y: Update rules.
2650         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2651         parameter.
2652         * d-exp.y: Update rules.
2653         * c-exp.y: Update rules.
2654         * breakpoint.c (set_breakpoint_condition): Create an
2655         innermost_block_tracker.
2656         (watch_command_1): Likewise.
2657         * ada-lang.c (resolve): Add "tracker" parameter.
2658         (resolve_subexp): Likewise.
2659         * ada-exp.y (write_var_from_sym): Update.
2660
2661 2019-04-04  Tom Tromey  <tom@tromey.com>
2662
2663         * type-stack.h: New file.
2664         * type-stack.c: New file.
2665         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2666         type-stack.h.
2667         (insert_into_type_stack, insert_type, push_type, push_type_int)
2668         (insert_type_address_space, pop_type, pop_type_int)
2669         (pop_typelist, pop_type_stack, append_type_stack)
2670         (push_type_stack, get_type_stack, push_typelist)
2671         (follow_type_instance_flags, follow_types): Don't declare.
2672         * parse.c (type_stack): Remove global.
2673         (parse_exp_in_context): Update.
2674         (insert_into_type_stack, insert_type, push_type, push_type_int)
2675         (insert_type_address_space, pop_type, pop_type_int)
2676         (pop_typelist, pop_type_stack, append_type_stack)
2677         (push_type_stack, get_type_stack, push_typelist)
2678         (follow_type_instance_flags, follow_types): Remove (moved to
2679         type-stack.c).
2680         * f-exp.y (type_stack): New global.
2681         Update rules.
2682         (push_kind_type, f_parse): Update.
2683         * d-exp.y (type_stack): New global.
2684         Update rules.
2685         (d_parse): Update.
2686         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2687         Update rules.
2688         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2689         (HFILES_NO_SRCDIR): Add type-stack.h.
2690
2691 2019-04-04  Tom Tromey  <tom@tromey.com>
2692
2693         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2694         (rust_parser::convert_ast_to_expression, rust_parse)
2695         (rust_lex_test_completion, rust_lex_tests): Update.
2696         * parser-defs.h (struct expr_completion_state): New.
2697         (struct parser_state) <parser_state>: Add completion parameter.
2698         <mark_struct_expression, mark_completion_tag>: New methods.
2699         <parse_completion, m_completion_state>: New members.
2700         (prefixify_expression, null_post_parser): Update.
2701         (mark_struct_expression, mark_completion_tag): Don't declare.
2702         * parse.c (parse_completion, expout_last_struct)
2703         (expout_tag_completion_type, expout_completion_name): Remove
2704         globals.
2705         (parser_state::mark_struct_expression)
2706         (parser_state::mark_completion_tag): Now methods.
2707         (prefixify_expression): Add last_struct parameter.
2708         (prefixify_subexp): Likewise.
2709         (parse_exp_1): Update.
2710         (parse_exp_in_context): Add cstate parameter.  Update.
2711         (parse_expression_for_completion): Create an
2712         expr_completion_state.
2713         (null_post_parser): Add "completion" parameter.
2714         * p-exp.y: Update rules.
2715         (yylex): Update.
2716         * language.h (struct language_defn) <la_post_parser>: Add
2717         "completing" parameter.
2718         * go-exp.y: Update rules.
2719         (lex_one_token): Update.
2720         * expression.h (parse_completion): Don't declare.
2721         * d-exp.y: Update rules.
2722         (lex_one_token): Update rules.
2723         * c-exp.y: Update rules.
2724         (lex_one_token): Update.
2725         * ada-lang.c (resolve): Add "parse_completion" parameter.
2726         (resolve_subexp): Likewise.
2727         (ada_resolve_function): Likewise.
2728
2729 2019-04-04  Tom Tromey  <tom@tromey.com>
2730
2731         * parser-defs.h (struct parser_state) <start_arglist,
2732         end_arglist>: New methods.
2733         <arglist_len, m_funcall_chain>: New members.
2734         (arglist_len, start_arglist, end_arglist): Don't declare.
2735         * parse.c (arglist_len, funcall_chain): Remove global.
2736         (start_arglist, end_arglist): Remove functions.
2737         (parse_exp_in_context): Update.
2738         * p-exp.y: Update rules.
2739         * m2-exp.y: Update rules.
2740         * go-exp.y: Update rules.
2741         * f-exp.y: Update rules.
2742         * d-exp.y: Update rules.
2743         * c-exp.y: Update rules.
2744
2745 2019-04-04  Tom Tromey  <tom@tromey.com>
2746
2747         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2748         lex_operator, push_back>: New methods.
2749         Update all rules.
2750         (rust_parser::lex_hex, lex_escape): Rename and update.
2751         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2752         (rust_parser::lex_operator): Rename and update.
2753         (rust_parser::lex_number, rustyylex, rustyyerror)
2754         (rust_lex_test_init, rust_lex_test_sequence)
2755         (rust_lex_test_push_back, rust_lex_tests): Update.
2756         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2757         parameter.
2758         <lexptr, prev_lexptr>: New members.
2759         (lexptr, prev_lexptr): Don't declare.
2760         * parse.c (lexptr, prev_lexptr): Remove globals.
2761         (parse_exp_in_context): Update.
2762         * p-exp.y (yylex, yyerror): Update.
2763         * m2-exp.y (parse_number, yylex, yyerror): Update.
2764         * go-exp.y (lex_one_token, yyerror): Update.
2765         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2766         * d-exp.y (lex_one_token, yyerror): Update.
2767         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2768         (lex_one_token, yyerror): Update.
2769         * ada-lex.l (YY_INPUT): Update.
2770         (rewind_to_char): Update.
2771         * ada-exp.y (yyerror): Update.
2772
2773 2019-04-04  Tom Tromey  <tom@tromey.com>
2774
2775         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2776         * parser-defs.h (struct parser_state) <parser_state>: Add new
2777         parameter.
2778         <comma_terminates>: New member.
2779         (comma_terminates): Don't declare global.
2780         * parse.c (comma_terminates): Remove global.
2781         (parse_exp_in_context): Update.
2782         * p-exp.y (yylex): Update.
2783         * m2-exp.y (yylex): Update.
2784         * go-exp.y (lex_one_token): Update.
2785         * f-exp.y (yylex): Update.
2786         * d-exp.y (lex_one_token): Update.
2787         * c-exp.y (lex_one_token): Update.
2788         * ada-lex.l: Update.
2789
2790 2019-04-04  Tom Tromey  <tom@tromey.com>
2791
2792         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2793         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2794         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2795         * parser-defs.h (paren_depth): Don't declare.
2796         * parse.c (paren_depth): Remove global.
2797         (parse_exp_in_context): Update.
2798         * p-exp.y (paren_depth): New global.
2799         (pascal_parse): Initialize it.
2800         * m2-exp.y (paren_depth): New global.
2801         (m2_parse): Initialize it.
2802         * go-exp.y (paren_depth): New global.
2803         (go_parse): Initialize it.
2804         * f-exp.y (paren_depth): New global.
2805         (f_parse): Initialize it.
2806         * d-exp.y (paren_depth): New global.
2807         (d_parse): Initialize it.
2808         * c-exp.y (paren_depth): New global.
2809         (c_parse): Initialize it.
2810         * ada-lex.l (paren_depth): New global.
2811         (lexer_init): Initialize it.
2812
2813 2019-04-04  Tom Tromey  <tom@tromey.com>
2814
2815         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2816         (rust_parser::convert_ast_to_type)
2817         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2818         * parser-defs.h (struct parser_state) <parser_state>: Add
2819         parameters.  Initialize new members.
2820         <expression_context_block, expression_context_pc>: New members.
2821         * parse.c (expression_context_block, expression_context_pc):
2822         Remove globals.
2823         (parse_exp_in_context): Update.
2824         * p-exp.y: Update all rules.
2825         (yylex): Update.
2826         * m2-exp.y: Update all rules.
2827         (yylex): Update.
2828         * go-exp.y (yylex): Update.
2829         * f-exp.y (yylex): Update.
2830         * d-exp.y: Update all rules.
2831         (yylex): Update.
2832         * c-exp.y: Update all rules.
2833         (lex_one_token, classify_name, yylex, c_parse): Update.
2834         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2835
2836 2019-04-04  Tom Tromey  <tom@tromey.com>
2837
2838         * gdbarch.h, gdbarch.c: Rebuild.
2839         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2840         * stap-probe.h:
2841         (struct stap_parse_info): Replace "parser_state" with
2842         "expr_builder".
2843         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2844         (parser_state): New class.
2845         * parse.c (expr_builder): Rename.
2846         (expr_builder::release): Rename.
2847         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2848         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2849         (write_exp_elt_longcst, write_exp_elt_floatcst)
2850         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2851         (write_exp_string_vector, write_exp_bitstring)
2852         (write_exp_msymbol, mark_struct_expression)
2853         (write_dollar_variable)
2854         (insert_type_address_space, increase_expout_size): Replace
2855         "parser_state" with "expr_builder".
2856         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2857         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2858         "parser_state" with "expr_builder".
2859
2860 2019-04-04  Tom Tromey  <tom@tromey.com>
2861
2862         * rust-exp.y: Replace "parse_language" with method call.
2863         * p-exp.y:
2864         (yylex): Replace "parse_language" with method call.
2865         * m2-exp.y:
2866         (yylex): Replace "parse_language" with method call.
2867         * go-exp.y (classify_name): Replace "parse_language" with method
2868         call.
2869         * f-exp.y (yylex): Replace "parse_language" with method call.
2870         * d-exp.y (lex_one_token): Replace "parse_language" with method
2871         call.
2872         * c-exp.y:
2873         (lex_one_token, classify_name, yylex): Replace "parse_language"
2874         with method call.
2875         * ada-exp.y (find_primitive_type, type_char)
2876         (type_system_address): Replace "parse_language" with method call.
2877
2878 2019-04-04  Tom Tromey  <tom@tromey.com>
2879
2880         * rust-exp.y: Replace "parse_gdbarch" with method call.
2881         * parse.c (write_dollar_variable, insert_type_address_space):
2882         Replace "parse_gdbarch" with method call.
2883         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2884         call.
2885         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2886         call.
2887         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2888         "parse_gdbarch" with method call.
2889         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2890         with method call.
2891         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2892         "parse_gdbarch" with method call.
2893         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2894         "parse_gdbarch" with method call.
2895         * c-exp.y (parse_type, parse_number, classify_name): Replace
2896         "parse_gdbarch" with method call.
2897         * ada-lex.l: Replace "parse_gdbarch" with method call.
2898         * ada-exp.y (parse_type, find_primitive_type, type_char)
2899         (type_system_address): Replace "parse_gdbarch" with method call.
2900
2901 2019-04-04  Tom Tromey  <tom@tromey.com>
2902
2903         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2904         * stap-probe.c (stap_parse_argument): Update.
2905         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2906         initial_size parameter.
2907         * rust-exp.y (rust_lex_tests): Update.
2908         * parse.c (parser_state): Update.
2909         (parse_exp_in_context): Update.
2910         * parser-defs.h (struct parser_state) <parser_state>: Remove
2911         "initial_size" parameter.
2912
2913 2019-04-04  Tom Tromey  <tom@tromey.com>
2914
2915         * parser-defs.h (increase_expout_size): Don't declare.
2916         * parse.c (increase_expout_size): Now static.
2917
2918 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2919
2920         * gnu-nat.c (gnu_nat_target::wait): Fix
2921         target_waitstatus_to_string call.
2922
2923 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2924
2925         * eval.c (evaluate_subexp_standard): Handle internal functions
2926         during Fortran function call handling.
2927
2928 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2929
2930         * NEWS: Mention new internal functions.
2931         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2932         (read_base_type): Use dwarf2_init_complex_target_type.
2933         * value.c (creal_internal_fn): New function.
2934         (cimag_internal_fn): New function.
2935         (_initialize_values): Register new internal functions.
2936
2937 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2938
2939         * infrun.c (stop_all_threads): If debug_infrun, always
2940         trace the wait status after wait_one, using
2941         target_waitstatus_to_string and target_pid_to_str.
2942         (handle_inferior_event): Replace various trace of
2943         wait status kind by a single trace.
2944         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2945         wait status kind image by target_waitstatus_to_string.
2946         * target/waitstatus.c (target_waitstatus_to_string): Fix
2947         obsolete comment.
2948
2949 2019-04-01  Tom Tromey  <tromey@adacore.com>
2950
2951         PR symtab/23331:
2952         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2953
2954 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2955             Pedro Alves  <palves@redhat.com>
2956
2957         * top.c (quit_force): Call 'finalize_values'.
2958         * value.c (finalize_values): New function.
2959         * value.h (finalize_values): Declare.
2960
2961 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2962
2963         * NEWS: Announce $_gdb_major and $_gdb_minor.
2964
2965         * top.c (init_gdb_version_vars): New function.
2966         (gdb_init): Call init_gdb_version_vars.
2967
2968 2019-03-29  Tom Tromey  <tromey@adacore.com>
2969
2970         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2971         help text.  Remove dead code.
2972
2973 2019-03-29  Keith Seitz  <keiths@redhat.com>
2974
2975         From Siddhesh Poyarekar:
2976         * f-lang.h (f77_get_upperbound): Return LONGEST.
2977         (f77_get_lowerbound): Likewise.
2978         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2979         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2980         print them.
2981         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2982         plongest to format print it.
2983         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2984         (f77_get_upperbound): Likewise.
2985         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2986         LOWER_BOUND to LONGEST.
2987         (f77_create_arrayprint_offset_tbl): Likewise.
2988
2989 2019-03-29  Keith Seitz  <keiths@redhat.com>
2990
2991         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2992         %s/pulongest for TYPE_LENGTH instead of %d in format
2993         strings.
2994         * ada-typerint.c (ada_print_type): Likewise.
2995         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2996         * compile/compile-c-support.c (generate_register_struct): Likewise.
2997         * gdbtypes.c (recursive_dump_type): Likewise.
2998         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2999         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3000         instead of %d in format strings.
3001         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3002         to std::min to ULONGEST.
3003         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3004         instead of %d in format strings.
3005         * tracepoint.c (info_scope_command): Likewise.
3006         * typeprint.c (print_offset_data::update)
3007         (print_offset_data::finish): Likewise.
3008         * xtensa-tdep.c (xtensa_store_return_value)
3009         (xtensa_push_dummy_call): Likewise.
3010
3011 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3012
3013         * windows-nat.c (display_selector): Fixed format specifications
3014         for 64-bit Cygwin.
3015
3016 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3017
3018         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3019
3020 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3021
3022         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3023         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3024         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3025         (nios2_linux_init_abi): Install it.
3026
3027 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3028
3029         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3030
3031 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3032
3033         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3034
3035 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3036             Tom Tromey  <tromey@adacore.com>
3037
3038         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3039
3040 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3041
3042         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3043         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3044         method to compute the bounds of range types. Also print "[evaluated]"
3045         if the bounds' values come from a dynamic evaluation.
3046
3047 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3048
3049         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3050         whitespace when pretty printing is on.
3051
3052 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3053
3054         * ppc-linux-nat.c: Add include.
3055
3056 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3057
3058         * NEWS: Mention AArch64 Pointer Authentication.
3059
3060 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3061
3062         * arm-linux-nat.c: Add include.
3063
3064 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3065
3066         * source-cache.c (source_cache::get_source_lines): Re-read
3067         fullname after calling open_source_file.
3068
3069 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3070
3071         * NEWS: Mention TLS support for FreeBSD.
3072
3073 2019-03-25  Tom Tromey  <tromey@adacore.com>
3074
3075         * minsyms.c (BUNCH_SIZE): Update comment.
3076         (~minimal_symbol_reader): Remove old comment.
3077         (compact_minimal_symbols): Update comment.
3078         (minimal_symbol_reader::install): Remove old comment.  Update
3079         other comments.
3080
3081 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3082
3083         * s390-linux-nat.c: Add include.
3084
3085 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3086
3087         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3088         Call linux_get_hwcap.
3089         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3090         Likewise.
3091         (aarch64_linux_get_hwcap): Remove function.
3092         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3093         declaration.
3094         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3095         linux_get_hwcap.
3096         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3097         * linux-tdep.c (linux_get_hwcap): Add function.
3098         (linux_get_hwcap2): Likewise.
3099         * linux-tdep.h (linux_get_hwcap): Add declaration.
3100         (linux_get_hwcap2): Likewise.
3101         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3102         (ppc_linux_get_hwcap2): Likewise.
3103         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3104         linux_get_hwcap.
3105         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3106         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3107         (ppc_linux_nat_target::read_description): Likewise.
3108         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3109         * s390-linux-nat.c: Likewise.
3110         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3111
3112 2019-03-24  Tom Tromey  <tom@tromey.com>
3113
3114         * ada-lang.c (standard_lookup): Simplify initialization.
3115         (ada_lookup_symbol_nonlocal): Simplify return.
3116         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3117         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3118         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3119         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3120         initialization.
3121         * solib.c (solib_global_lookup): Simplify.
3122         * symtab.c (null_block_symbol): Remove.
3123         (symbol_cache_lookup): Simplify returns.
3124         (lookup_language_this): Simplify returns.
3125         (lookup_symbol_aux): Simplify return.
3126         (lookup_local_symbol): Simplify returns.
3127         (lookup_global_symbol_from_objfile): Simplify return.
3128         (lookup_symbol_in_objfile_symtabs)
3129         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3130         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3131         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3132         * cp-namespace.c (cp_lookup_bare_symbol)
3133         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3134         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3135         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3136         (cp_lookup_symbol_via_imports): Simplify initialization.
3137         (find_symbol_in_baseclass): Likewise.
3138         * symtab.h (null_block_symbol): Remove.
3139         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3140         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3141         (d_lookup_symbol_module): Likewise.
3142         (find_symbol_in_baseclass): Simplify initialization.
3143
3144 2019-03-24  Tom Tromey  <tom@tromey.com>
3145
3146         * expression.h: Don't include symtab.h.
3147         (struct block): Forward declare.
3148
3149 2019-03-24  Tom Tromey  <tom@tromey.com>
3150
3151         * c-exp.y (typebase): Remove casts.
3152         * gdbtypes.c (lookup_unsigned_typename, )
3153         (lookup_signed_typename): Remove cast.
3154         * eval.c (parse_to_comma_and_eval): Remove cast.
3155         * parse.c (write_dollar_variable): Remove cast.
3156         * block.h (struct block) <superblock>: Now const.
3157         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3158         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3159         (map_block): Make "block" const.
3160         * symfile.h (struct quick_symbol_functions)
3161         <map_matching_symbols>: Constify block argument to "callback".
3162         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3163         const.
3164         (find_pc_sect_compunit_symtab): Make "b" const.
3165         (find_symbol_at_address): Likewise.
3166         (search_symbols): Likewise.
3167         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3168         (dw2_debug_names_lookup_symbol): Likewise.
3169         (dw2_map_matching_symbols): Update.
3170         * p-valprint.c (pascal_val_print): Remove "block".
3171         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3172         (aux_add_nonlocal_symbols): Make "block" const.
3173         (resolve_subexp): Remove cast.
3174         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3175         const.
3176         (iterate_over_file_blocks): Likewise.
3177         * f-exp.y (%union) <bval>: Remove.
3178         * coffread.c (patch_opaque_types): Make "b" const.
3179         * spu-tdep.c (spu_catch_start): Make "block" const.
3180         * c-valprint.c (print_unpacked_pointer): Remove "block".
3181         * symmisc.c (dump_symtab_1): Make "b" const.
3182         (block_depth): Make "block" const.
3183         * d-exp.y (%union) <bval>: Remove.
3184         * cp-support.h (cp_lookup_rtti_type): Update.
3185         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3186         * psymtab.c (psym_lookup_symbol): Make "block" const.
3187         (maintenance_check_psymtabs): Make "b" const.
3188         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3189         (enumerate_locals, enumerate_args): Update.
3190         * python/py-symtab.c (stpy_global_block): Make "block" const.
3191         (stpy_static_block): Likewise.
3192         * inline-frame.c (block_starting_point_at): Make "new_block"
3193         const.
3194         * block.c (find_block_in_blockvector): Make return type const.
3195         (blockvector_for_pc_sect): Make "b" const.
3196         (find_block_in_blockvector): Make "b" const.
3197
3198 2019-03-23  Tom Tromey  <tom@tromey.com>
3199
3200         * varobj.c (varobj_create): Update.
3201         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3202         * printcmd.c (display_command, do_one_display): Don't reset
3203         innermost_block.
3204         * parser-defs.h (enum innermost_block_tracker_type): Move to
3205         expression.h.
3206         (innermost_block): Update comment.
3207         * parse.c (parse_exp_1): Add tracker_types parameter.
3208         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3209         tracker_types parameter.  Reset innermost_block.
3210         (parse_exp_in_context): Remove.
3211         (parse_expression_for_completion): Update.
3212         * objfiles.c (~objfile): Don't reset expression_context_block or
3213         innermost_block.
3214         * expression.h (enum innermost_block_tracker_type): Move from
3215         parser-defs.h.
3216         (parse_exp_1): Add tracker_types parameter.
3217         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3218         reset innermost_block.
3219
3220 2019-03-23  Tom Tromey  <tom@tromey.com>
3221
3222         * objfiles.h: Include bcache.h.
3223
3224 2019-03-23  Tom Tromey  <tom@tromey.com>
3225
3226         * linespec.c (get_current_search_block): Use
3227         scoped_restore_current_language.
3228         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3229
3230 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3231             Jiong Wang  <jiong.wang@arm.com>
3232
3233         * aarch64-linux-tdep.c
3234         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3235         section.
3236         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3237
3238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3239             Jiong Wang  <jiong.wang@arm.com>
3240
3241         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3242         instructions.
3243         (aarch64_analyze_prologue_test): Add PACIASP test.
3244         (aarch64_prologue_prev_register): Unmask PC value.
3245
3246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3247             Jiong Wang  <jiong.wang@arm.com>
3248
3249         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3250         (aarch64_dwarf2_prev_register): Unmask PC value.
3251         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3252         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3253         DW_CFA_AARCH64_negate_ra_state.
3254         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3255
3256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3257             Jiong Wang  <jiong.wang@arm.com>
3258
3259         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3260         registers.
3261         (aarch64_pseudo_register_name): Likewise.
3262         (aarch64_pseudo_register_type): Likewise.
3263         (aarch64_pseudo_register_reggroup_p): Likewise.
3264         (aarch64_gdbarch_init): Add pauth registers.
3265         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3266         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3267         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3268         (struct gdbarch_tdep): Add regnum for ra_state.
3269
3270 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3271             Jiong Wang  <jiong.wang@arm.com>
3272
3273         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3274
3275 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3276             Jiong Wang  <jiong.wang@arm.com>
3277
3278         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3279         function.
3280         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3281         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3282         (aarch64_gdbarch_init): Add puth registers.
3283         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3284         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3285         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3286
3287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3288             Jiong Wang  <jiong.wang@arm.com>
3289
3290         * aarch64-linux-nat.c
3291         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3292         * aarch64-linux-tdep.c
3293         (aarch64_linux_core_read_description): Likewise.
3294         (aarch64_linux_get_hwcap): New function.
3295         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3296         (aarch64_linux_get_hwcap): New declaration.
3297
3298 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3299             Jiong Wang  <jiong.wang@arm.com>
3300
3301         * aarch64-linux-nat.c
3302         (aarch64_linux_nat_target::read_description): Add pauth param.
3303         * aarch64-linux-tdep.c
3304         (aarch64_linux_core_read_description): Likewise.
3305         * aarch64-tdep.c (struct target_desc): Add in pauth.
3306         (aarch64_read_description): Add pauth param.
3307         (aarch64_gdbarch_init): Likewise.
3308         * aarch64-tdep.h (aarch64_read_description): Likewise.
3309         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3310         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3311         * features/Makefile: Add new files.
3312         * features/aarch64-pauth.c: New file.
3313         * features/aarch64-pauth.xml: New file.
3314
3315 2019-03-20  Tom Tromey  <tromey@adacore.com>
3316
3317         * infrun.c (handle_inferior_event): Rename from
3318         handle_inferior_event_1.  Create a scoped_value_mark.
3319         (handle_inferior_event): Remove.
3320
3321 2019-03-19  Tom Tromey  <tromey@adacore.com>
3322
3323         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3324         * infrun.h (print_stop_event): Add "displays" parameter.
3325         * infrun.c (print_stop_event): Add "displays" parameter.
3326
3327 2019-03-19  Pedro Alves  <palves@redhat.com>
3328
3329         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3330         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3331         to -1.  Fix TABs vs spaces.
3332         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3333         * tui/tui-out.h (tui_ui_out) Add intro comments.
3334         <m_line, m_start_of_line>: In-class initialize, and add describing
3335         comment.
3336
3337 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3338
3339         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3340         variable names.
3341         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3342
3343 2019-03-18  Pedro Alves  <palves@redhat.com>
3344             Eli Zaretskii <eliz@gnu.org>
3345
3346         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3347         m_line and m_start_of_line.
3348
3349 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3350
3351         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3352         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3353         it returns a newline.  This fixes a regression in TU mode, whereby
3354         the next line is output on the same screen line as the user input.
3355
3356 2019-03-18  Tom Tromey  <tromey@adacore.com>
3357
3358         * minsyms.c (minimal_symbol_reader::install): Remove call to
3359         obstack_blank.
3360
3361 2019-03-18  Pedro Alves  <palves@redhat.com>
3362
3363         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3364         New globals.
3365         (apply_style): New, factored out from ...
3366         (apply_ansi_escape): ... this.  Handle reverse video mode.
3367         (tui_set_reverse_mode): New function.
3368         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3369         * tui/tui-winsource.c (tui_show_source_line): Use
3370         tui_set_reverse_mode instead of setting A_STANDOUT.
3371         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3372         New setter methods.
3373
3374 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3375
3376         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3377         Handle tabs.
3378
3379 2019-03-18  Tom Tromey  <tromey@adacore.com>
3380
3381         * ada-lang.c (empty_array): Add "high" parameter.
3382         (ada_evaluate_subexp): Update.
3383
3384 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3385
3386         * unittests/string_view-selftests.c: Define
3387         _initialize_string_view_selftests unconditionally.
3388
3389 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3390
3391         PR gdb/24350
3392         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3393
3394 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3395
3396         PR gdb/24351
3397         * windows-nat.c (display_selector): Fix format specifiers.
3398
3399 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3400
3401         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3402         tui_refill_source_window instead of tui_refresh_win, to update the
3403         current execution line.  This fixes redisplay of the current line
3404         when stepping through the code with "next" or "step".
3405
3406 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3407
3408         * source-cache.c (source_cache::get_source_lines): Call
3409         find_source_lines to initialize s->nlines.  This fixes vertical
3410         scrolling of TUI source window when the DOWN arrow is pressed.
3411
3412 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3413
3414         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3415         linux-thread-db.c (_initialize_thread_db): Likewise.
3416
3417 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3418
3419         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3420         wclrtoeol in tui_show_source_line".  This reverts changes made in
3421         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3422
3423 2019-03-15  Tom Tromey  <tom@tromey.com>
3424
3425         * symtab.h (struct minimal_symbol): Derive from
3426         general_symbol_info.
3427         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3428         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3429         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3430         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3431         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3432         (MSYMBOL_SEARCH_NAME): Update.
3433         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3434         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3435         * minsyms.c (minimal_symbol_reader::record_full): Update.
3436
3437 2019-03-15  Tom Tromey  <tom@tromey.com>
3438
3439         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3440
3441 2019-03-15  Tom Tromey  <tom@tromey.com>
3442
3443         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3444         unique_xmalloc_ptr.
3445         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3446         Update.
3447         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3448         (build_minimal_symbol_hash_tables)
3449         (minimal_symbol_reader::install): Update.
3450
3451 2019-03-15  Tom Tromey  <tom@tromey.com>
3452
3453         * symtab.c (create_demangled_names_hash): Update.
3454         (symbol_set_names): Update.
3455         * objfiles.h (struct objfile_per_bfd_storage)
3456         <demangled_names_hash>: Now an htab_up.
3457         * objfiles.c (objfile_per_bfd_storage): Simplify.
3458
3459 2019-03-15  Tom Tromey  <tom@tromey.com>
3460
3461         * objfiles.h (struct objfile_per_bfd_storage): Declare
3462         destructor.
3463         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3464         New.
3465         (get_objfile_bfd_data): Use new.  Don't initialize
3466         language_of_main.
3467         (free_objfile_per_bfd_storage): Remove.
3468         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3469
3470 2019-03-15  Tom Tromey  <tom@tromey.com>
3471
3472         * symfile.c (reread_symbols): Update.
3473         * objfiles.c (objfile::objfile): Update.
3474         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3475         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3476         comment.
3477         (minimal_symbol_reader::install): Update.
3478         (terminate_minimal_symbol_table): Remove.
3479         * jit.c (jit_object_close_impl): Update.
3480
3481 2019-03-15  Tom Tromey  <tom@tromey.com>
3482
3483         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3484         initializations.
3485
3486 2019-03-15  Tom Tromey  <tom@tromey.com>
3487
3488         * objfiles.h (struct objfile_per_bfd_storage)
3489         <demangled_hash_languages>: Now a bitset.
3490         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3491         (lookup_minimal_symbol): Update.
3492
3493 2019-03-15  Tom Tromey  <tom@tromey.com>
3494
3495         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3496         Don't return the symbol.
3497         * coffread.c (record_minimal_symbol): Use record_full.
3498
3499 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3500
3501         The MS-Windows port of ncurses fails to switch to a color pair if
3502         one or both of the colors are the implicit default colors.  This
3503         change records the default colors when TUI is initialized, and
3504         then specifies them explicitly when a color pair uses the default
3505         colors.  This allows color styling in TUI mode on MS-Windows.
3506
3507         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3508         ncurses_norm_attr.
3509         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3510         colors in ncurses_norm_attr.
3511         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3512         "none", replace it with the default color recorded in
3513         ncurses_norm_attr.
3514
3515 2019-03-14  Tom Tromey  <tromey@adacore.com>
3516
3517         * source-cache.h (class source_cache) <get_source_lines>: Return
3518         std::string.
3519         * source-cache.c (source_cache::extract_lines): Handle case where
3520         first_pos==npos.  Return std::string.
3521         (source_cache::get_source_lines): Update.
3522
3523 2019-03-14  Tom Tromey  <tromey@adacore.com>
3524
3525         * NEWS: Add item for "style sources" commands.
3526         * source-cache.c (source_cache::get_source_lines): Check
3527         source_styling.
3528         * cli/cli-style.c (source_styling): New global.
3529         (_initialize_cli_style): Add "style sources" commands.
3530         (show_style_sources): New function.
3531         * cli/cli-style.h (source_styling): Declare.
3532
3533 2019-03-14  Pedro Alves  <palves@redhat.com>
3534             Tom Tromey  <tromey@adacore.com>
3535
3536         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3537         * tui/tui-winsource.c (tui_refill_source_window): New function,
3538         from...
3539         (tui_horizontal_source_scroll): ... here.  Move some logic.
3540         * cli/cli-style.c (set_style_enabled): Notify new observable.
3541         * tui/tui-hooks.c (tui_redisplay_source): New function.
3542         (tui_attach_detach_observers): Attach or detach
3543         tui_redisplay_source.
3544         * observable.h (source_styling_changed): New observable.
3545         * observable.c: Define source_styling_changed observable.
3546
3547 2019-03-13  Tom Tromey  <tromey@adacore.com>
3548
3549         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3550         (i386_gnu_nat_target::store_registers): Update.
3551         * target-debug.h (target_debug_print_std_string): New macro.
3552         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3553         * windows-tdep.c (display_one_tib): Update.
3554         * tui/tui-stack.c (tui_make_status_line): Update.
3555         * top.c (print_inferior_quit_action): Update.
3556         * thread.c (thr_try_catch_cmd): Update.
3557         (add_thread_with_info): Update.
3558         (thread_target_id_str): Update.
3559         (thr_try_catch_cmd): Update.
3560         (thread_command): Update.
3561         (thread_find_command): Update.
3562         * record-btrace.c (record_btrace_target::info_record)
3563         (record_btrace_resume_thread, record_btrace_target::resume)
3564         (record_btrace_cancel_resume, record_btrace_step_thread)
3565         (record_btrace_target::wait, record_btrace_target::wait)
3566         (record_btrace_target::wait, record_btrace_target::stop): Update.
3567         * progspace.c (print_program_space): Update.
3568         * process-stratum-target.c
3569         (process_stratum_target::thread_address_space): Update.
3570         * linux-fork.c (linux_fork_mourn_inferior)
3571         (detach_checkpoint_command, info_checkpoints_command)
3572         (linux_fork_context): Update.
3573         (linux_fork_detach): Update.
3574         (class scoped_switch_fork_info): Update.
3575         (delete_checkpoint_command): Update.
3576         * infrun.c (follow_fork_inferior): Update.
3577         (follow_fork_inferior): Update.
3578         (proceed_after_vfork_done): Update.
3579         (handle_vfork_child_exec_or_exit): Update.
3580         (follow_exec): Update.
3581         (displaced_step_prepare_throw): Update.
3582         (displaced_step_restore): Update.
3583         (start_step_over): Update.
3584         (resume_1): Update.
3585         (clear_proceed_status_thread): Update.
3586         (proceed): Update.
3587         (print_target_wait_results): Update.
3588         (do_target_wait): Update.
3589         (context_switch): Update.
3590         (stop_all_threads): Update.
3591         (restart_threads): Update.
3592         (finish_step_over): Update.
3593         (handle_signal_stop): Update.
3594         (switch_back_to_stepped_thread): Update.
3595         (keep_going_pass_signal): Update.
3596         (print_exited_reason): Update.
3597         (normal_stop): Update.
3598         * inferior.c (inferior_pid_to_str): Change return type.
3599         (print_selected_inferior): Update.
3600         (add_inferior): Update.
3601         (detach_inferior): Update.
3602         * dummy-frame.c (fprint_dummy_frames): Update.
3603         * dcache.c (dcache_info_1): Update.
3604         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3605         (btrace_fetch, btrace_clear): Update.
3606         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3607         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3608         type.
3609         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3610         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3611         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3612         * gdbarch.c, gdbarch.h: Rebuild.
3613         * gdbarch.sh (core_pid_to_str): Change return type.
3614         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3615         return type.
3616         (windows_nat_target::pid_to_str): Change return type.
3617         (windows_delete_thread): Update.
3618         (windows_nat_target::attach): Update.
3619         (windows_nat_target::files_info): Update.
3620         * target-delegates.c: Rebuild.
3621         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3622         return type.
3623         (sol_thread_target::pid_to_str): Change return type.
3624         * remote.c (class remote_target) <pid_to_str>: Change return
3625         type.
3626         (remote_target::pid_to_str): Change return type.
3627         (extended_remote_target::attach, remote_target::remote_stop_ns)
3628         (remote_target::remote_notif_remove_queued_reply)
3629         (remote_target::push_stop_reply, remote_target::disable_btrace):
3630         Update.
3631         (extended_remote_target::attach): Update.
3632         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3633         type.
3634         (gdbsim_target::pid_to_str): Change return type.
3635         * ravenscar-thread.c (struct ravenscar_thread_target)
3636         <pid_to_str>: Change return type.
3637         (ravenscar_thread_target::pid_to_str): Change return type.
3638         * procfs.c (class procfs_target) <pid_to_str>: Change return
3639         type.
3640         (procfs_target::pid_to_str): Change return type.
3641         (procfs_target::attach): Update.
3642         (procfs_target::detach): Update.
3643         (procfs_target::fetch_registers): Update.
3644         (procfs_target::store_registers): Update.
3645         (procfs_target::wait): Update.
3646         (procfs_target::files_info): Update.
3647         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3648         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3649         return type.
3650         (nto_procfs_target::pid_to_str): Change return type.
3651         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3652         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3653         return type.
3654         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3655         (exit_lwp): Update.
3656         (attach_proc_task_lwp_callback, get_detach_signal)
3657         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3658         (linux_nat_target::resume, wait_lwp, stop_callback)
3659         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3660         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3661         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3662         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3663         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3664         type.
3665         (inf_ptrace_target::attach): Update.
3666         (inf_ptrace_target::files_info): Update.
3667         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3668         type.
3669         (go32_nat_target::pid_to_str): Change return type.
3670         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3671         (gnu_nat_target::wait): Update.
3672         (gnu_nat_target::wait): Update.
3673         (gnu_nat_target::resume): Update.
3674         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3675         (fbsd_nat_target::wait): Update.
3676         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3677         type.
3678         (darwin_nat_target::attach): Update.
3679         * corelow.c (class core_target) <pid_to_str>: Change return type.
3680         (core_target::pid_to_str): Change return type.
3681         * target.c (normal_pid_to_str): Change return type.
3682         (default_pid_to_str): Likewise.
3683         (target_pid_to_str): Change return type.
3684         (target_translate_tls_address): Update.
3685         (target_announce_detach): Update.
3686         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3687         return type.
3688         (bsd_uthread_target::pid_to_str): Change return type.
3689         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3690         type.
3691         (bsd_kvm_target::pid_to_str): Change return type.
3692         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3693         return type.
3694         (aix_thread_target::pid_to_str): Change return type.
3695         * target.h (struct target_ops) <pid_to_str>: Change return type.
3696         (target_pid_to_str, normal_pid_to_str): Likewise.
3697         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3698         type.
3699         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3700         type.
3701         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3702         return type.
3703         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3704         type.
3705         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3706         type.
3707         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3708         return type.
3709
3710 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3711
3712         * NEWS: Mention that the new default MI version is 3.  Mention
3713         changes to the output of commands and events that deal with
3714         multi-location breakpoints.
3715         * breakpoint.c: Include "mi/mi-out.h".
3716         (print_one_breakpoint): Change output syntax if using MI version
3717         >= 3.
3718         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3719         New.
3720         (mi_multi_location_breakpoint_output_fixed): New.
3721         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3722         (mi_cmd_fix_multi_location_breakpoint_output): New.
3723         (mi_multi_location_breakpoint_output_fixed): New.
3724         * mi/mi-cmds.c (mi_cmds): Register command
3725         -fix-multi-location-breakpoint-output.
3726         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3727         interpreter "mi".
3728
3729 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3730
3731         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3732         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3733         instantiate mi_ui_out based on interpreter name.
3734         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3735         * mi/mi-main.c (mi_load_progress): Likewise.
3736
3737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3738
3739         * NEWS: Combine separate "New targets" sections for 8.3.
3740
3741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3742
3743         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3744         (ppcfbsd_init_abi): Install gdbarch
3745         "fetch_tls_load_module_address" and "get_thread_local_address"
3746         methods.
3747
3748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3749
3750         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3751         (riscv_fbsd_init_abi): Install gdbarch
3752         "fetch_tls_load_module_address" and "get_thread_local_address"
3753         methods.
3754
3755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3756
3757         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3758         (i386fbsd_init_abi): Install gdbarch
3759         "fetch_tls_load_module_address" and "get_thread_local_address"
3760         methods.
3761
3762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3763
3764         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3765         (amd64fbsd_init_abi): Install gdbarch
3766         "fetch_tls_load_module_address" and "get_thread_local_address"
3767         methods.
3768
3769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3770
3771         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3772         (struct fbsd_pspace_data): New type.
3773         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3774         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3775         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3776         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3777         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3778
3779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3780
3781         * gdbtypes.c (lookup_struct_elt): New function.
3782         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3783         * gdbtypes.h (struct struct_elt): New type.
3784         (lookup_struct_elt): New prototype.
3785
3786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3787
3788         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3789         remove disabled code block.
3790
3791 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3792
3793         * gdbarch.sh (get_thread_local_address): New method.
3794         * gdbarch.h, gdbarch.c: Regenerate.
3795         * target.c (target_translate_tls_address): Use
3796         gdbarch_get_thread_local_address if present instead of
3797         target::get_thread_local_address.
3798
3799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3800
3801         * target.h (target::get_thread_local_address): Update comment.
3802
3803 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3804
3805         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3806         objfile->separate_debug_objfile_backlink if not NULL.
3807
3808 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3809
3810         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3811         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3812         (amd64bsd_store_inferior_registers): Likewise.
3813         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3814         Enable segment base registers.
3815         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3816         PT_GETFSBASE and PT_GETGSBASE.
3817         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3818         PT_SETGSBASE.
3819         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3820         segment base registers.
3821         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3822
3823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3824
3825         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3826         Update calls to i386_target_description to add 'segments'
3827         parameter.
3828         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3829         add segment base registers.
3830         * arch/i386.c (i386_create_target_description): Add 'segments'
3831         parameter to enable segment base registers.
3832         * arch/i386.h (i386_create_target_description): Likewise.
3833         * features/i386/32bit-segments.xml: New file.
3834         * features/i386/32bit-segments.c: Generate.
3835         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3836         call to i386_target_description to add 'segments' parameter.
3837         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3838         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3839         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3840         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3841         if feature is present.
3842         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3843         Add 'segments' parameter to call to i386_target_description.
3844         (i386_target_description): Add 'segments' parameter to enable
3845         segment base registers.
3846         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3847         to call to i386_target_description.
3848         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3849         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3850         Define I386_NUM_REGS.
3851         (i386_target_description): Add 'segments' parameter to enable
3852         segment base registers.
3853
3854 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3855
3856         PR/24325
3857         * source-cache.c: #undef open and close, to avoid unresolved
3858         externals during linking.
3859
3860 2019-03-12  Tom Tromey  <tromey@adacore.com>
3861
3862         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3863         const.  Add initializers.
3864         (_initialize_remote): Don't initialize ptid globals.
3865
3866 2019-03-12  Pedro Alves  <palves@redhat.com>
3867
3868         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3869
3870 2019-03-12  Pedro Alves  <palves@redhat.com>
3871
3872         * cp-name-parser.y (main): Remove unused 'len' variable.
3873
3874 2019-03-12  Tom Tromey  <tromey@adacore.com>
3875
3876         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3877         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3878
3879 2019-03-12  Tom Tromey  <tromey@adacore.com>
3880
3881         * linux-nat.c (iterate_over_lwps): Update.
3882         (stop_callback): Remove parameter.
3883         (stop_wait_callback, detach_callback, resume_set_callback)
3884         (select_singlestep_lwp_callback, set_ignore_sigint)
3885         (status_callback, resumed_callback, resume_clear_callback)
3886         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3887         data parameter.
3888         (linux_nat_target::detach, linux_nat_target::resume)
3889         (linux_stop_and_wait_all_lwps, select_event_lwp)
3890         (linux_nat_filter_event, linux_nat_wait_1)
3891         (linux_nat_target::kill, linux_nat_target::stop)
3892         (linux_nat_target::stop): Update.
3893         (linux_nat_resume_callback): Change type.
3894         (resume_stopped_resumed_lwps, count_events_callback)
3895         (select_event_lwp_callback): Likewise.
3896         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3897         * arm-linux-nat.c (struct update_registers_data): Remove.
3898         (update_registers_callback): Change type.
3899         (arm_linux_insert_hw_breakpoint1): Update.
3900         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3901         parameter.
3902         (x86_linux_dr_set_addr): Update.
3903         (x86_linux_dr_set_control): Update.
3904         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3905         (iterate_over_lwps): Use gdb::function_view.
3906         * nat/aarch64-linux-hw-point.c (struct
3907         aarch64_dr_update_callback_param): Remove.
3908         (debug_reg_change_callback): Change type.
3909         (aarch64_notify_debug_reg_change): Update.
3910         * s390-linux-nat.c (s390_refresh_per_info): Update.
3911
3912 2019-03-11  Tom Tromey  <tromey@adacore.com>
3913
3914         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3915         redundant assignment to "this_cu".
3916
3917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3918
3919         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3920
3921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3922
3923         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3924         from...
3925         (rank_one_type): ... this.
3926
3927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3928
3929         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3930         from...
3931         (rank_one_type): ... this.
3932
3933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3934
3935         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3936         from...
3937         (rank_one_type): ... this.
3938
3939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3940
3941         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3942         from...
3943         (rank_one_type): ... this.
3944
3945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3946
3947         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3948         from...
3949         (rank_one_type): ... this.
3950
3951 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3952
3953         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3954         from...
3955         (rank_one_type): ... this.
3956
3957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3958
3959         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3960         from...
3961         (rank_one_type): ... this.
3962
3963 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3964
3965         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3966         from...
3967         (rank_one_type): ... this.
3968
3969 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3970
3971         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3972         from...
3973         (rank_one_type): ... this.
3974
3975 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3976
3977         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3978         from...
3979         (rank_one_type): ... this.
3980
3981 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3982
3983         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3984         from...
3985         (rank_one_type): ... this.
3986
3987 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3988
3989         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3990         from...
3991         (rank_one_type): ... this.
3992
3993 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3994
3995         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3996         inferior-events' shows the example events.
3997
3998 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3999
4000         Support styling on native MS-Windows console
4001
4002         PR/24315
4003         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4004         on MS-Windows if $TERM is not defined.
4005
4006         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4007
4008         * posix-hdep.c (gdb_console_fputs):
4009         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4010         functions.
4011         * ui-file.h (gdb_console_fputs): Add prototype.
4012
4013         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4014         back to fputs only if the former returns zero.
4015
4016 2019-03-07  Tom Tromey  <tom@tromey.com>
4017
4018         * symmisc.c (print_symbol_bcache_statistics): Update.
4019         (print_objfile_statistics): Update.
4020         * symfile.c (allocate_symtab): Update.
4021         * stabsread.c: Don't include bcache.h.
4022         * psymtab.h (struct psymbol_bcache): Don't declare.
4023         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4024         (psymbol_bcache_init, psymbol_bcache_free)
4025         (psymbol_bcache_get_bcache): Don't declare.
4026         * psymtab.c (struct psymbol_bcache): Remove.
4027         (psymtab_storage::psymtab_storage): Update.
4028         (psymtab_storage::~psymtab_storage): Update.
4029         (psymbol_bcache_init, psymbol_bcache_free)
4030         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4031         (add_psymbol_to_bcache): Update.
4032         (allocate_psymtab): Update.
4033         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4034         macro_cache>: No longer pointers.
4035         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4036         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4037         * macrotab.c (macro_bcache): Update.
4038         * macroexp.c: Don't include bcache.h.
4039         * gdbtypes.c (check_types_worklist): Update.
4040         (types_deeply_equal): Remove TRY/CATCH.  Update.
4041         * elfread.c (elf_symtab_read): Update.
4042         * dwarf2read.c: Don't include bcache.h.
4043         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4044         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4045         (print_bcache_statistics, bcache_memory_used): Don't declare.
4046         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4047         methods.  Rename all data members.
4048         * bcache.c (struct bcache): Move to bcache.h.
4049         (bcache::expand_hash_table): Rename from expand_hash_table.
4050         (bcache): Remove.
4051         (bcache::insert): Rename from bcache_full.
4052         (bcache::compare): Rename from bcache_compare.
4053         (bcache_xmalloc): Remove.
4054         (bcache::~bcache): Rename from bcache_xfree.
4055         (bcache::print_statistics): Rename from print_bcache_statistics.
4056         (bcache::memory_used): Rename from bcache_memory_used.
4057
4058 2019-03-07  Pedro Alves  <palves@redhat.com>
4059
4060         * infrun.c (normal_stop): Also check for
4061         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4062
4063 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4064
4065         * f-lang.c (value_from_host_double): Moved to...
4066         * value.c (value_from_host_double): ...here.
4067         * value.h (value_from_host_double): Declare.
4068         * guile/scm-math.c (vlscm_convert_typed_number): Use
4069         value_from_host_double.
4070         (vlscm_convert_number): Likewise.
4071         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4072         * python/py-value.c (convert_value_from_python): Likewise.
4073
4074 2019-03-06  Tom Tromey  <tom@tromey.com>
4075
4076         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4077
4078 2019-03-06  Tom Tromey  <tom@tromey.com>
4079
4080         * utils.h (free_current_contents): Don't declare.
4081         * utils.c (free_current_contents): Remove.
4082
4083 2019-03-06  Tom Tromey  <tom@tromey.com>
4084
4085         * top.c (quit_force): Update.
4086         * main.c (captured_command_loop): Update.
4087         * common/new-op.c (operator new): Update.
4088         * common/common-exceptions.c (struct catcher)
4089         <save_cleanup_chain>: Remove member.
4090         (exceptions_state_mc_init): Update.
4091         (exception_try_scope_entry): Return nullptr.
4092         (exception_try_scope_exit, exception_rethrow)
4093         (throw_exception_sjlj, throw_exception_cxx): Update.
4094         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4095         (all_cleanups, do_cleanups, discard_cleanups)
4096         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4097         (restore_cleanups, restore_final_cleanups): Don't declare.
4098         (do_final_cleanups): Remove parameter.
4099         * common/cleanups.c (cleanup_chain, make_cleanup)
4100         (make_cleanup_dtor, all_cleanups, do_cleanups)
4101         (discard_my_cleanups, discard_cleanups)
4102         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4103         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4104         (null_cleanup): Remove.
4105         (do_final_cleanups): Remove parameter.
4106
4107 2019-03-06  Tom Tromey  <tom@tromey.com>
4108
4109         * remote.c (remote_target::remote_parse_stop_reply): Use
4110         unique_xmalloc_ptr.
4111
4112 2019-03-06  Tom Tromey  <tom@tromey.com>
4113
4114         * stabsread.c (struct stabs_field_info): Rename from field_info.
4115         <list, fnlist>: Add initializers.
4116         <obstack>: New member.
4117         (read_member_functions, read_struct_fields, read_baseclasses):
4118         Allocate on obstack.  Don't use cleanups.
4119         (read_one_struct_field, read_member_functions, read_struct_fields)
4120         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4121         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4122         (read_struct_type): Update.
4123
4124 2019-03-06  Tom Tromey  <tom@tromey.com>
4125
4126         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4127         * common/filestuff.h (make_cleanup_close): Don't declare.
4128         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4129         Remove.
4130
4131 2019-03-06  Tom Tromey  <tom@tromey.com>
4132
4133         * solib-aix.c: Use make_scope_exit.
4134
4135 2019-03-06  Tom Tromey  <tom@tromey.com>
4136
4137         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4138         Use make_scope_exit.
4139
4140 2019-03-06  Tom Tromey  <tom@tromey.com>
4141
4142         * solib-svr4.c (disable_probes_interface): Remove parameter.
4143         (svr4_handle_solib_event): Use make_scope_exit.
4144
4145 2019-03-06  Tom Tromey  <tom@tromey.com>
4146
4147         * remote.c (struct stop_reply_deleter): Remove.
4148         (stop_reply_up): Update.
4149         (struct stop_reply): Derive from notif_event.  Don't typedef.
4150         <regcache>: Now a std::vector.
4151         (stop_reply_xfree): Remove.
4152         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4153         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4154         (remote_target::discard_pending_stop_replies): Use delete.
4155         (remote_target::remote_parse_stop_reply): Update.
4156         (remote_target::process_stop_reply): Update.
4157         * remote-notif.h (struct notif_event): Add virtual destructor.
4158         Remove "dtr" member.
4159         (struct notif_client) <alloc_event>: Return a unique_ptr.
4160         (notif_event_xfree): Don't declare.
4161         (notif_event_up): New typedef.
4162         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4163         (notif_event_xfree, do_notif_event_xfree): Remove.
4164         (remote_notif_state_xfree): Update.
4165
4166 2019-03-06  Tom Tromey  <tom@tromey.com>
4167
4168         * infrun.c (displaced_step_clear_cleanup): Now a
4169         forward_scope_exit type.
4170         (displaced_step_prepare_throw): Update.
4171         (displaced_step_fixup): Update.
4172
4173 2019-03-06  Tom Tromey  <tom@tromey.com>
4174
4175         * inferior.h (class inferior): Update comment.
4176         * gdbthread.h (class thread_info): Update comment.
4177
4178 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4179             Tom Tromey  <tom@tromey.com>
4180
4181         * stabsread.h (struct stab_section_list): Remove.
4182         (coffstab_build_psymtabs): Update.
4183         * dbxread.c (symbuf_sections): Now a std::vector.
4184         (sect_idx): New global.
4185         (fill_symbuf): Update.
4186         (coffstab_build_psymtabs): Change type of stabsects parameter.
4187         Update.
4188         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4189         std::vector.
4190         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4191         (coff_locate_sections): Update.
4192         (coff_symfile_read): Remove cleanups.  Update.
4193         (init_stringtab): Add storage parameter.
4194         (free_stringtab, free_stringtab_cleanup): Remove.
4195         (init_lineno): Add storage parameter.
4196         (free_linetab, free_linetab_cleanup): Remove.
4197
4198 2019-03-06  Pedro Alves  <palves@redhat.com>
4199
4200         * linux-fork.c (fork_info::clobber_regs): Delete.
4201         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4202         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4203         comment.  Adjust.
4204         (scoped_switch_fork_info::scoped_switch_fork_info)
4205         (checkpoint_command, linux_fork_context): Adjust
4206         fork_save_infrun_state calls.
4207
4208 2019-03-06  Pedro Alves  <palves@redhat.com>
4209
4210         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4211         (inf_has_multiple_threads): Return 'bool' and rewrite using
4212         inferior_info::threads().
4213
4214 2019-03-06  Pedro Alves  <palves@redhat.com>
4215
4216         * linux-fork.c: Include <list>.
4217         (fork_list): Now a std::list instance.
4218         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4219         (forks_exist_p, find_last_fork): Adjust.
4220         (new_fork): Delete.
4221         (one_fork_p): New.
4222         (add_fork): Adjust.
4223         (free_fork): Delete, folded into fork_info::~fork_info().
4224         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4225         Adjust.
4226         (init_fork_list): Delete.
4227         (linux_fork_killall, linux_fork_mourn_inferior)
4228         (linux_fork_detach, info_checkpoints_command): Adjust.
4229         (_initialize_linux_fork): No longer call init_fork_list.
4230
4231 2019-03-06  Pedro Alves  <palves@redhat.com>
4232
4233         * linux-fork.c (new_fork): New, split out of ...
4234         (add_fork): ... this.  Return void.  Move "first fork" special
4235         case from here, to ...
4236         (checkpoint_command): ... here.
4237         * linux-linux.h (add_fork): Return void.
4238
4239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4242
4243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4244             Chris January  <chris.january@arm.com>
4245             David Lecomber  <david.lecomber@arm.com>
4246
4247         * f-exp.y: New token, UNOP_INTRINSIC.
4248         (exp): New pattern using UNOP_INTRINSIC token.
4249         (f77_keywords): Add 'abs' keyword.
4250         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4251         (value_from_host_double): New function.
4252         (evaluate_subexp_f): Support UNOP_ABS.
4253
4254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4257         types.
4258
4259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4262         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4263         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4264
4265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4266
4267         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4268
4269 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4270             Chris January  <chris.january@arm.com>
4271
4272         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4273         * f-exp.y: Define 'KIND' token.
4274         (exp): New pattern for KIND expressions.
4275         (ptype): Handle types with a kind extension.
4276         (direct_abs_decl): Extend to spot kind extensions.
4277         (f77_keywords): Add 'kind' to the list.
4278         (push_kind_type): New function.
4279         (convert_to_kind_type): New function.
4280         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4281         * parse.c (operator_length_standard): Likewise.
4282         * parser-defs.h (enum type_pieces): Add tp_kind.
4283         * std-operator.def: Add UNOP_KIND.
4284
4285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * f-exp.y (f_parse): Set yydebug.
4288
4289 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * f-lang.c (evaluate_subexp_f): New function.
4292         (exp_descriptor_f): New global.
4293         (f_language_defn): Use exp_descriptor_f instead of
4294         exp_descriptor_standard.
4295
4296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4297
4298         * f-exp.y (struct token): Add comments.
4299         (dot_ops): Remove uppercase versions and the end marker.
4300         (f77_keywords): Likewise.
4301         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4302         entries in the dot_ops array are case insensitive, and use
4303         strncasecmp to compare strings.  Also some whitespace cleanup in
4304         this area.  Similar for the f77_keywords array, except entries in
4305         this list might be case sensitive.
4306
4307 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4308
4309         * f-exp.y (struct f77_boolean_val): Add comments.
4310         (boolean_values): Remove uppercase versions, and end marker.
4311         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4312         and use strncasecmp to achieve case insensitivity.  Additionally,
4313         perform whitespace cleanup around this code.
4314
4315 2019-03-06  Tom Tromey  <tromey@adacore.com>
4316
4317         * remote-sim.c (gdbsim_target_open): Use result of
4318         gdb_argv::release.
4319
4320 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4321         Dirk Schubert  <dirk.schubert@arm.com>
4322         Chris January  <chris.january@arm.com>
4323
4324         * eval.c (evaluate_subexp_standard): Call Fortran argument
4325         wrapping logic.
4326         * f-lang.c (struct value): A value which can be passed into a
4327         Fortran function call.
4328         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4329         where appropriate.
4330         (struct type): Value ready for a Fortran function call.
4331         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4332         is needed.
4333         * f-lang.h (fortran_argument_convert): Declaration.
4334         (fortran_preserve_arg_pointer): Declaration.
4335         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4336
4337 2019-03-05  Tom Tromey  <tromey@adacore.com>
4338
4339         * python/py-prettyprint.c (print_string_repr): Remove #if.
4340         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4341
4342 2019-03-05  Tom Tromey  <tromey@adacore.com>
4343
4344         * target.c (the_dummy_target): Move later.  Change type to
4345         "dummy_target".
4346         (initialize_targets): Don't initialize the_dummy_target.
4347
4348 2019-03-05  Tom Tromey  <tromey@adacore.com>
4349
4350         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4351         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4352
4353 2019-03-05  Tom Tromey  <tromey@adacore.com>
4354
4355         * windows-nat.c (windows_nat_target::attach)
4356         (windows_nat_target::detach): Don't call gdb_flush.
4357         * valprint.c (generic_val_print, val_print, val_print_string):
4358         Don't call gdb_flush.
4359         * utils.c (defaulted_query): Don't call gdb_flush.
4360         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4361         * target.c (target_announce_detach): Don't call gdb_flush.
4362         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4363         * remote.c (extended_remote_target::attach): Don't call
4364         gdb_flush.
4365         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4366         * printcmd.c (do_examine): Don't call gdb_flush.
4367         (info_display_command): Don't call gdb_flush.
4368         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4369         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4370         * memattr.c (info_mem_command): Don't call gdb_flush.
4371         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4372         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4373         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4374         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4375         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4376         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4377         (gnu_nat_target::detach): Don't call gdb_flush.
4378         * f-valprint.c (f_val_print): Don't call gdb_flush.
4379         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4380         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4381         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4382         gdb_flush.
4383         * c-valprint.c (c_val_print): Don't call gdb_flush.
4384         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4385
4386 2019-03-05  Tom Tromey  <tromey@adacore.com>
4387
4388         * varobj.c (update_dynamic_varobj_children): Update.
4389         (install_default_visualizer): Use reset, not release.
4390         * value.c (set_internalvar): Update.
4391         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4392         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4393         ATTRIBUTE_UNUSED_RESULT.
4394
4395 2019-03-05  Tom Tromey  <tromey@adacore.com>
4396
4397         * remote.c (class scoped_remote_fd) <release>: Add
4398         ATTRIBUTE_UNUSED_RESULT.
4399
4400 2019-03-05  Tom Tromey  <tromey@adacore.com>
4401
4402         * macroexp.c (struct macro_buffer) <release>: Add
4403         ATTRIBUTE_UNUSED_RESULT.
4404
4405 2019-03-05  Tom Tromey  <tromey@adacore.com>
4406
4407         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4408         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4409         ATTRIBUTE_UNUSED_RESULT.
4410
4411 2019-03-05  Tom Tromey  <tromey@adacore.com>
4412
4413         * common/scoped_fd.h (class scoped_fd) <release>: Add
4414         ATTRIBUTE_UNUSED_RESULT.
4415
4416 2019-03-05  Tom Tromey  <tromey@adacore.com>
4417
4418         * parser-defs.h (struct parser_state) <release>: Add
4419         ATTRIBUTE_UNUSED_RESULT.
4420
4421 2019-03-05  Tom Tromey  <tromey@adacore.com>
4422
4423         * utils.h (class gdb_argv) <release>: Add
4424         ATTRIBUTE_UNUSED_RESULT.
4425         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4426
4427 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4428
4429         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4430         for-loop range, to avoid compiler warnings.
4431
4432         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4433         avoid compiler warnings about unused variables.
4434
4435         * NEWS: Mention end of support for native debugging on MS-Windows
4436         before XP.
4437
4438         PR gdb/24292
4439         * common/netstuff.c:
4440         * gdbserver/gdbreplay.c
4441         * gdbserver/remote-utils.c:
4442         * ser-tcp.c:
4443         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4444         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4445         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4446         'getaddrinfo' and 'freeaddrinfo' were not available before
4447         Windows XP, and mingw.org's MinGW headers by default define
4448         _WIN32_WINNT to 0x500.
4449
4450 2019-03-01  Gary Benson <gbenson@redhat.com>
4451
4452         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4453
4454 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4455             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4456
4457         PR gdb/8527
4458         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4459         set_sigint_trap, clear_sigint_trap.
4460
4461 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4462
4463         * target.c (target_detach): Clear the regcache and the
4464         frame cache.
4465
4466 2019-02-27  Pedro Alves  <palves@redhat.com>
4467
4468         * utils.c (set_screen_size): When we cap the height/width sizes,
4469         tweak the corresponding command variable to show "unlimited":
4470
4471 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4472             Pedro Alves  <palves@redhat.com>
4473
4474         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4475         before calling rl_set_screen_size.
4476
4477 2019-02-27  Tom Tromey  <tromey@adacore.com>
4478
4479         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4480         define.
4481         * python/py-value.c: Remove Python 2.4 workaround.
4482         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4483         workaround.
4484         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4485         Python 2.4 workaround.
4486         * python/python-internal.h: Remove Python 2.4 comment.
4487         (Py_ssize_t): Don't define.
4488         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4489         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4490         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4491         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4492         * python/python.c (do_start_initialization): Remove Python 2.4
4493         workaround.
4494         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4495         (print_children): Remove Python 2.4 workaround.
4496         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4497         workaround.
4498         (CHARBUFFERPROC_NAME): Remove.
4499         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4500         Python 2.4 workaround.
4501
4502 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4503
4504         * NEWS: Note minimum Python version.
4505
4506 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4507
4508         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4509         code from these functions.  Remove corresponding ifdefs.  Use
4510         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4511         Remove gotos and target of gotos.
4512         (infpy_search_memory): Likewise.
4513
4514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4515
4516         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4517         (hppa_gdbarch_init): Don't register deleted functions with
4518         gdbarch.
4519
4520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4521
4522         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4523         (h8300_unwind_sp): Delete.
4524         (h8300_dummy_id): Delete.
4525         (h8300_gdbarch_init): Don't register deleted functions with
4526         gdbarch.
4527
4528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4531         (ft32_unwind_pc): Delete.
4532         (ft32_unwind_sp): Delete.
4533         (ft32_gdbarch_init): Don't register deleted functions with
4534         gdbarch.
4535
4536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4539         (frv_unwind_pc): Delete.
4540         (frv_unwind_sp): Delete.
4541         (frv_gdbarch_init): Don't register deleted functions with
4542         gdbarch.
4543
4544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4547         (riscv_unwind_pc): Delete.
4548         (riscv_unwind_sp): Delete.
4549         (riscv_gdbarch_init): Don't register deleted functions with
4550         gdbarch.
4551
4552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4555         (csky_unwind_pc): Delete.
4556         (csky_unwind_sp): Delete.
4557         (csky_gdbarch_init): Don't register deleted functions with
4558         gdbarch.
4559
4560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4563         (cris_unwind_pc): Delete.
4564         (cris_unwind_sp): Delete.
4565         (cris_gdbarch_init): Don't register deleted functions with
4566         gdbarch.
4567
4568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4571         (bfin_unwind_pc): Delete.
4572         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4573
4574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4575
4576         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4577         (arm_unwind_pc): Delete.
4578         (arm_unwind_sp): Delete.
4579         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4580
4581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4584         (arc_unwind_pc): Delete.
4585         (arc_unwind_sp): Delete.
4586         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4587
4588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4591         (alpha_unwind_pc): Delete.
4592         (alpha_gdbarch_init): Don't register deleted functions with
4593         gdbarch.
4594
4595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4596
4597         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4598         (aarch64_unwind_pc): Delete.
4599         (aarch64_unwind_sp): Delete.
4600         (aarch64_gdbarch_init): Don't register deleted functions with
4601         gdbarch.
4602
4603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * gdbtypes.c (type_align): Don't consider static members when
4606         computing structure alignment.
4607
4608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4611         return 0 for other types.
4612         * arch-utils.c (default_type_align): Always return 0.
4613         * gdbarch.h: Regenerate.
4614         * gdbarch.sh (type_align): Extend comment.
4615         * gdbtypes.c (type_align): Add additional comments, always call
4616         gdbarch_type_align before applying the default rules.
4617         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4618         generic code will then apply a suitable default.
4619         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4620         types, return 0 for other types.
4621
4622 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4623
4624         * NEWS: Create a new section for the next release branch.
4625         Rename the section of the current branch, now that it has
4626         been cut.
4627
4628 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4629
4630         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4631         * version.in: Bump version to 8.3.50.DATE-git.
4632
4633 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4634
4635         * aix-thread.c (ptid_cmp): Remove unused variable.
4636         (get_signaled_thread): Likewise.
4637         (store_regs_user_thread): Likewise.
4638         (store_regs_kernel_thread): Likewise.
4639         (fetch_regs_kernel_thread): Remove shadowed variable.
4640
4641 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * features/riscv/32bit-cpu.xml: Add register numbers.
4644         * features/riscv/32bit-fpu.c: Regenerate.
4645         * features/riscv/32bit-fpu.xml: Add register numbers.
4646         * features/riscv/64bit-cpu.xml: Add register numbers.
4647         * features/riscv/64bit-fpu.c: Regenerate.
4648         * features/riscv/64bit-fpu.xml: Add register numbers.
4649
4650 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4651
4652         * NEWS: Mention two argument form of gdb.Value constructor.
4653         * python/py-value.c (convert_buffer_and_type_to_value): New
4654         function.
4655         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4656         Add support for handling an optional second argument.  Call
4657         convert_buffer_and_type_to_value as appropriate.
4658         * python/python-internal.h (Py_buffer_deleter): New struct.
4659         (Py_buffer_up): New typedef.
4660
4661 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4662
4663         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4664         instead of releasing ownership.
4665
4666 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4667
4668         * dwarf2read.c (open_and_init_dwp_file): Call
4669         elf_numsections instead of bfd_count_sections to initialize
4670         dwp_file->num_sections.
4671
4672 2019-02-25  Tom Tromey  <tromey@adacore.com>
4673
4674         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4675
4676 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4677
4678         * gcore.in: Add '--readnever' option when invoking GDB.
4679
4680 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4681
4682         * MAINTAINERS: Update my email address.
4683
4684 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4685
4686         * build-id.c (build_id_to_debug_bfd_1): New function.
4687         (build_id_to_debug_bfd): Look for separate debug file in
4688         sysroot.
4689
4690 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * gdbarch.sh: Update the copyright year range that is placed into
4693         generated files.
4694
4695 2019-02-22  Keith Seitz  <keiths@redhat.com>
4696
4697         PR symtab/23853
4698         * linespec.c (create_sals_line_offset): Search for the default
4699         symtab's filename instead of its fullname.
4700
4701 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4702
4703         * NEWS: Update style defaults.
4704
4705 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4706
4707         * main.c (captured_main_1): Disable styling in batch mode.
4708
4709 2019-02-20  Tom Tromey  <tom@tromey.com>
4710
4711         * symtab.c (symtab_symbol_info): Fix typos.
4712
4713 2019-02-20  Tom Tromey  <tromey@adacore.com>
4714
4715         * findcmd.c (_initialize_mem_search): Use upper case for
4716         metasyntactic variables.
4717
4718 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4719
4720         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4721         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4722
4723 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4724
4725         * top.h (source_file_name): Change to std::string.
4726         * top.c (source_file_name): Likewise.
4727         (command_line_input): Adjust.
4728         * cli/cli-script.c (script_from_file): Adjust.
4729
4730 2019-02-19  Tom Tromey  <tromey@adacore.com>
4731
4732         * ravenscar-thread.c
4733         (ravenscar_thread_target::update_thread_list): Don't call
4734         ada_build_task_list.
4735         * ada-lang.h (ada_build_task_list): Don't declare.
4736         * ada-tasks.c (struct ada_tasks_inferior_data)
4737         <task_list_valid_p>: Now bool.
4738         (read_known_tasks, ada_task_list_changed)
4739         (ada_tasks_invalidate_inferior_data): Update.
4740         (read_known_tasks_array): Return bool.
4741         (read_known_tasks_list): Likewise.
4742         (read_known_tasks): Return void.
4743         (ada_build_task_list): Now static.
4744
4745 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4748         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4749
4750 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4751
4752         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4753         variant for ada_tasks_pspace_data_handle and
4754         ada_tasks_inferior_data_handle.
4755         (ada_tasks_pspace_data_cleanup): New function.
4756         (ada_tasks_inferior_data_cleanup): New function.
4757
4758 2019-02-17  Tom Tromey  <tom@tromey.com>
4759
4760         * macrotab.h (macro_source_fullname): Return a std::string.
4761         * macrotab.c (macro_include, check_for_redefinition)
4762         (macro_undef, macro_lookup_definition, foreach_macro)
4763         (foreach_macro_in_scope): Update.
4764         (macro_source_fullname): Return a std::string.
4765         * macrocmd.c (show_pp_source_pos): Update.
4766
4767 2019-02-17  Tom Tromey  <tom@tromey.com>
4768
4769         * macrocmd.c (show_pp_source_pos): Style the file names.
4770
4771 2019-02-17  Tom Tromey  <tom@tromey.com>
4772
4773         PR tui/24197:
4774         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4775
4776 2019-02-17  Tom Tromey  <tom@tromey.com>
4777
4778         * ada-lang.c (user_select_syms): Use filtered printing.
4779         * utils.c (wrap_style): New global.
4780         (desired_style): Remove.
4781         (emit_style_escape): Add stream parameter.
4782         (set_output_style, reset_terminal_style, prompt_for_continue):
4783         Update.
4784         (flush_wrap_buffer): Only flush gdb_stdout.
4785         (wrap_here): Set wrap_style.
4786         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4787         treat escape sequences as a character.  Change when wrap buffer is
4788         flushed.
4789         (fputs_styled): Do not set the output style when the default is
4790         requested.
4791         * ui-style.h (struct ui_file_style) <is_default>: New method.
4792         * source.c (print_source_lines_base): Emit escape sequences in one
4793         piece.
4794
4795 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4796
4797         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4798         integers and enumeration types.
4799
4800 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4801
4802         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4803         instead of lookup_symbol_in_language
4804         (do_exact_match): New function.
4805         (ada_get_symbol_name_matcher): Return do_exact_match when
4806         doing a verbatim match.
4807
4808 2019-02-15  Tom Tromey  <tromey@adacore.com>
4809
4810         * ravenscar-thread.c (ravenscar_thread_target::resume)
4811         (ravenscar_thread_target::wait): Special case wildcard requests.
4812
4813 2019-02-15  Tom Tromey  <tromey@adacore.com>
4814
4815         * ravenscar-thread.c (base_ptid): Remove.
4816         (struct ravenscar_thread_target) <close>: New method.
4817         <m_base_ptid>: New member.
4818         <update_inferior_ptid, active_task, task_is_currently_active,
4819         runtime_initialized>: Declare methods.
4820         <ravenscar_thread_target>: Add constructor.
4821         (ravenscar_thread_target::task_is_currently_active)
4822         (ravenscar_thread_target::update_inferior_ptid)
4823         (ravenscar_runtime_initialized): Rename.  Now methods.
4824         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4825         (ravenscar_thread_target::update_thread_list): Update.
4826         (ravenscar_thread_target::active_task): Now method.
4827         (ravenscar_thread_target::store_registers)
4828         (ravenscar_thread_target::prepare_to_store)
4829         (ravenscar_thread_target::prepare_to_store)
4830         (ravenscar_thread_target::mourn_inferior): Update.
4831         (ravenscar_inferior_created): Use "new" to create target.
4832         (ravenscar_thread_target::get_ada_task_ptid): Update.
4833         (_initialize_ravenscar): Don't initialize base_ptid.
4834         (ravenscar_ops): Remove global.
4835
4836 2019-02-15  Tom Tromey  <tromey@adacore.com>
4837
4838         * target.h (push_target): Declare new overload.
4839         * target.c (push_target): New overload, taking an rvalue reference.
4840         * remote.c (remote_target::open_1): Use push_target overload.
4841         * corelow.c (core_target_open): Use push_target overload.
4842
4843 2019-02-15  Tom Tromey  <tromey@adacore.com>
4844
4845         * ravenscar-thread.c (is_ravenscar_task)
4846         (ravenscar_task_is_currently_active): Return bool.
4847         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4848         (_initialize_ravenscar): Remove "(void)".
4849         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4850         Return bool.
4851
4852 2019-02-15  Tom Tromey  <tromey@adacore.com>
4853
4854         * ravenscar-thread.c (ravenscar_runtime_initializer)
4855         (has_ravenscar_runtime, get_running_thread_id)
4856         (ravenscar_thread_target::resume): Fix indentation.
4857
4858 2019-02-15  Tom Tromey  <tromey@adacore.com>
4859
4860         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4861         from ravenscar_arch_ops.
4862         (sparc_ravenscar_ops::fetch_registers)
4863         (sparc_ravenscar_ops::store_registers): Now methods.
4864         (sparc_ravenscar_prepare_to_store): Remove.
4865         (sparc_ravenscar_ops): Redefine.
4866         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4867         methods and destructor.  Remove members.
4868         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4869         (ravenscar_thread_target::store_registers)
4870         (ravenscar_thread_target::prepare_to_store): Update.
4871         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4872         Remove.
4873         (struct ppc_ravenscar_powerpc_ops): Derive from
4874         ravenscar_arch_ops.
4875         (ppc_ravenscar_powerpc_ops::fetch_registers)
4876         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4877         (ppc_ravenscar_powerpc_ops): Redefine.
4878         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4879         (ppc_ravenscar_e500_ops::fetch_registers)
4880         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4881         (ppc_ravenscar_e500_ops): Redefine.
4882         * aarch64-ravenscar-thread.c
4883         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4884         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4885         (aarch64_ravenscar_fetch_registers)
4886         (aarch64_ravenscar_store_registers): Now methods.
4887         (aarch64_ravenscar_ops): Redefine.
4888
4889 2019-02-15  Tom Tromey  <tromey@adacore.com>
4890
4891         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4892         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4893         (ravenscar_thread_target::stopped_by_watchpoint)
4894         (ravenscar_thread_target::stopped_data_address)
4895         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4896
4897 2019-02-15  Tom Tromey  <tromey@adacore.com>
4898
4899         * ravenscar-thread.c: Fix some typos.
4900
4901 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4902             Tom Tromey  <tromey@adacore.com>
4903
4904         * ada-lang.c (ada_exception_sal): Change addr_string to a
4905         std::string.
4906         (create_ada_exception_catchpoint): Update.
4907
4908 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4909             Tom Tromey  <tromey@adacore.com>
4910
4911         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4912         (bp_location_ops): Remove.
4913         (base_breakpoint_allocate_location): Update.
4914         (free_bp_location): Update.
4915         * ada-lang.c (class ada_catchpoint_location)
4916         <ada_catchpoint_location>: Remove ops parameter.
4917         (ada_catchpoint_location_dtor): Remove.
4918         (ada_catchpoint_location_ops): Remove.
4919         (allocate_location_exception): Update.
4920         * breakpoint.h (struct bp_location_ops): Remove.
4921         (class bp_location) <bp_location>: Remove bp_location_ops
4922         parameter.
4923         <~bp_location>: Add destructor.
4924         <ops>: Remove.
4925
4926 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4927             Pedro Alves  <palves@redhat.com>
4928
4929         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4930         'PATH_MAX'.
4931
4932 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4933             Samuel Thibault  <samuel.thibault@gnu.org>
4934             Thomas Schwinge  <thomas@codesourcery.com>
4935
4936         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4937         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4938
4939 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4940
4941         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4942         (check_empty): Use "const char *".
4943
4944         * gnu-nat.c (gnu_nat_target::detach): Instead of
4945         'detach_inferior (pid)' call
4946         'detach_inferior (find_inferior_pid (pid))'.
4947
4948         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4949         'nat/fork-inferior.o'.
4950         * gnu-nat.c: #include "nat/fork-inferior.h".
4951
4952         * gnu-nat.c (gnu_nat_target::detach): Instead of
4953         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4954         * gnu-nat.h: #include "inf-child.h".
4955         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4956         'i386_gnu_nat_target::fetch_registers'.
4957         (gnu_store_registers): Rename/move to
4958         'i386_gnu_nat_target::store_registers'.
4959
4960         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4961         * gnu-nat.h (mach_thread_info): New function.
4962         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4963
4964         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4965
4966 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4967
4968         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4969
4970 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4971
4972         * windows-nat.c (windows_add_thread): Add new parameter
4973         "main_thread_p" with default value set to false.  Update
4974         function documentation as well as all callers.
4975         (windows_delete_thread): Likewise.
4976         (fake_create_process): Update call to windows_add_thread.
4977         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4978         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4979         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4980         call to windows_delete_thread.
4981
4982 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4983
4984         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4985
4986 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4987
4988         * symfile.c (find_separate_debug_file): Use canonical path of
4989         sysroot with child_path instead of gdb_sysroot if it is valid.
4990
4991 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4992
4993         * symfile.c (find_separate_debug_file): Use child_path to
4994         determine if an object file is under a sysroot.
4995
4996 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4997
4998         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4999         unittests/child-path-selftests.c.
5000         * common/pathstuff.c (child_path): New function.
5001         * common/pathstuff.h (child_path): New prototype.
5002         * unittests/child-path-selftests.c: New file.
5003
5004 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5005
5006         * symfile.c (find_separate_debug_file): Look for separate debug
5007         files in debug directories under the sysroot.
5008
5009 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5010
5011         * symtab.h (struct minimal_symbol data_p): New const method.
5012         (struct minimal_symbol text_p): Likewise.
5013         * symtab.c (output_source_filename): Use file name style
5014         to print file name.
5015         (print_symbol_info): Likewise.
5016         (print_msymbol_info): Use address style to print addresses.
5017         Use function name style to print executable text symbols.
5018         (expand_symtab_containing_pc): Use data_p.
5019         (find_pc_sect_compunit_symtab): Likewise.
5020
5021 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5022
5023         * breakpoint.c (describe_other_breakpoints): Use address style
5024         to print addresses.
5025         (say_where): Likewise.
5026
5027 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5028
5029         * ada-typeprint.c (print_func_type): Print function name
5030         style to print function name.
5031         * c-typeprint.c (c_print_type_1): Likewise.
5032
5033 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5034
5035         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5036         for execve.
5037
5038 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5039
5040         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5041         type_stack.
5042
5043 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5044
5045         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5046         TYPE_CODE_REF types.
5047
5048 2019-02-08  Jim Wilson  <jimw@sifive.com>
5049
5050         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5051         (riscv_linux_fregset): New.
5052         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5053
5054 2019-02-07  Tom Tromey  <tom@tromey.com>
5055
5056         * thread.c (thread_cancel_execution_command): Update.
5057         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5058         methods.
5059         (struct thread_fsm_ops): Remove.
5060         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5061         (thread_fsm_should_stop, thread_fsm_return_value)
5062         (thread_fsm_set_finished, thread_fsm_finished_p)
5063         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5064         Don't declare.
5065         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5066         * infrun.c (clear_proceed_status_thread)
5067         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5068         (print_stop_event): Update.
5069         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5070         Add constructor.
5071         (step_command_fsm_ops): Remove.
5072         (new_step_command_fsm): Remove.
5073         (step_1): Update.
5074         (step_command_fsm::should_stop): Rename from
5075         step_command_fsm_should_stop.
5076         (step_command_fsm::clean_up): Rename from
5077         step_command_fsm_clean_up.
5078         (step_command_fsm::do_async_reply_reason): Rename from
5079         step_command_fsm_async_reply_reason.
5080         (struct until_next_fsm): Inherit from thread_fsm.  Add
5081         constructor.
5082         (until_next_fsm_ops): Remove.
5083         (new_until_next_fsm): Remove.
5084         (until_next_fsm::should_stop): Rename from
5085         until_next_fsm_should_stop.
5086         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5087         (until_next_fsm::do_async_reply_reason): Rename from
5088         until_next_fsm_async_reply_reason.
5089         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5090         constructor.  Change type of breakpoint.
5091         (finish_command_fsm_ops): Remove.
5092         (new_finish_command_fsm): Remove.
5093         (finish_command_fsm::should_stop): Rename from
5094         finish_command_fsm_should_stop.
5095         (finish_command_fsm::clean_up): Rename from
5096         finish_command_fsm_clean_up.
5097         (finish_command_fsm::return_value): Rename from
5098         finish_command_fsm_return_value.
5099         (finish_command_fsm::do_async_reply_reason): Rename from
5100         finish_command_fsm_async_reply_reason.
5101         (finish_command): Update.
5102         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5103         Add constructor.
5104         (call_thread_fsm_ops): Remove.
5105         (call_thread_fsm::call_thread_fsm): Rename from
5106         new_call_thread_fsm.
5107         (call_thread_fsm::should_stop): Rename from
5108         call_thread_fsm_should_stop.
5109         (call_thread_fsm::should_notify_stop): Rename from
5110         call_thread_fsm_should_notify_stop.
5111         (run_inferior_call, call_function_by_hand_dummy): Update.
5112         * cli/cli-interp.c (should_print_stop_to_console): Update.
5113         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5114         Add constructor.  Change type of location_breakpoint,
5115         caller_breakpoint.
5116         (until_break_fsm_ops): Remove.
5117         (new_until_break_fsm): Remove.
5118         (until_break_fsm::should_stop): Rename from
5119         until_break_fsm_should_stop.
5120         (until_break_fsm::clean_up): Rename from
5121         until_break_fsm_clean_up.
5122         (until_break_fsm::do_async_reply_reason): Rename from
5123         until_break_fsm_async_reply_reason.
5124         (until_break_command): Update.
5125         * thread-fsm.c: Remove.
5126         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5127
5128 2019-02-07  Tom Tromey  <tom@tromey.com>
5129
5130         * yy-remap.h: Add include guard.
5131         * xtensa-tdep.h: Add include guard.
5132         * xcoffread.h: Rename include guard.
5133         * varobj-iter.h: Add include guard.
5134         * tui/tui.h: Rename include guard.
5135         * tui/tui-winsource.h: Rename include guard.
5136         * tui/tui-wingeneral.h: Rename include guard.
5137         * tui/tui-windata.h: Rename include guard.
5138         * tui/tui-win.h: Rename include guard.
5139         * tui/tui-stack.h: Rename include guard.
5140         * tui/tui-source.h: Rename include guard.
5141         * tui/tui-regs.h: Rename include guard.
5142         * tui/tui-out.h: Rename include guard.
5143         * tui/tui-layout.h: Rename include guard.
5144         * tui/tui-io.h: Rename include guard.
5145         * tui/tui-hooks.h: Rename include guard.
5146         * tui/tui-file.h: Rename include guard.
5147         * tui/tui-disasm.h: Rename include guard.
5148         * tui/tui-data.h: Rename include guard.
5149         * tui/tui-command.h: Rename include guard.
5150         * tic6x-tdep.h: Add include guard.
5151         * target/waitstatus.h: Rename include guard.
5152         * target/wait.h: Rename include guard.
5153         * target/target.h: Rename include guard.
5154         * target/resume.h: Rename include guard.
5155         * target-float.h: Rename include guard.
5156         * stabsread.h: Add include guard.
5157         * rs6000-tdep.h: Add include guard.
5158         * riscv-fbsd-tdep.h: Add include guard.
5159         * regformats/regdef.h: Rename include guard.
5160         * record.h: Rename include guard.
5161         * python/python.h: Rename include guard.
5162         * python/python-internal.h: Rename include guard.
5163         * python/py-stopevent.h: Rename include guard.
5164         * python/py-ref.h: Rename include guard.
5165         * python/py-record.h: Rename include guard.
5166         * python/py-record-full.h: Rename include guard.
5167         * python/py-record-btrace.h: Rename include guard.
5168         * python/py-instruction.h: Rename include guard.
5169         * python/py-events.h: Rename include guard.
5170         * python/py-event.h: Rename include guard.
5171         * procfs.h: Add include guard.
5172         * proc-utils.h: Add include guard.
5173         * p-lang.h: Add include guard.
5174         * or1k-tdep.h: Rename include guard.
5175         * observable.h: Rename include guard.
5176         * nto-tdep.h: Rename include guard.
5177         * nat/x86-linux.h: Rename include guard.
5178         * nat/x86-linux-dregs.h: Rename include guard.
5179         * nat/x86-gcc-cpuid.h: Add include guard.
5180         * nat/x86-dregs.h: Rename include guard.
5181         * nat/x86-cpuid.h: Rename include guard.
5182         * nat/ppc-linux.h: Rename include guard.
5183         * nat/mips-linux-watch.h: Rename include guard.
5184         * nat/linux-waitpid.h: Rename include guard.
5185         * nat/linux-ptrace.h: Rename include guard.
5186         * nat/linux-procfs.h: Rename include guard.
5187         * nat/linux-osdata.h: Rename include guard.
5188         * nat/linux-nat.h: Rename include guard.
5189         * nat/linux-namespaces.h: Rename include guard.
5190         * nat/linux-btrace.h: Rename include guard.
5191         * nat/glibc_thread_db.h: Rename include guard.
5192         * nat/gdb_thread_db.h: Rename include guard.
5193         * nat/gdb_ptrace.h: Rename include guard.
5194         * nat/fork-inferior.h: Rename include guard.
5195         * nat/amd64-linux-siginfo.h: Rename include guard.
5196         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5197         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5198         * nat/aarch64-linux.h: Rename include guard.
5199         * nat/aarch64-linux-hw-point.h: Rename include guard.
5200         * mn10300-tdep.h: Add include guard.
5201         * mips-linux-tdep.h: Add include guard.
5202         * mi/mi-parse.h: Rename include guard.
5203         * mi/mi-out.h: Rename include guard.
5204         * mi/mi-main.h: Rename include guard.
5205         * mi/mi-interp.h: Rename include guard.
5206         * mi/mi-getopt.h: Rename include guard.
5207         * mi/mi-console.h: Rename include guard.
5208         * mi/mi-common.h: Rename include guard.
5209         * mi/mi-cmds.h: Rename include guard.
5210         * mi/mi-cmd-break.h: Rename include guard.
5211         * m2-lang.h: Add include guard.
5212         * location.h: Rename include guard.
5213         * linux-record.h: Rename include guard.
5214         * linux-nat.h: Add include guard.
5215         * linux-fork.h: Add include guard.
5216         * i386-darwin-tdep.h: Rename include guard.
5217         * hppa-linux-offsets.h: Add include guard.
5218         * guile/guile.h: Rename include guard.
5219         * guile/guile-internal.h: Rename include guard.
5220         * gnu-nat.h: Rename include guard.
5221         * gdb-stabs.h: Rename include guard.
5222         * frv-tdep.h: Add include guard.
5223         * f-lang.h: Add include guard.
5224         * event-loop.h: Add include guard.
5225         * darwin-nat.h: Rename include guard.
5226         * cp-abi.h: Rename include guard.
5227         * config/sparc/nm-sol2.h: Rename include guard.
5228         * config/nm-nto.h: Rename include guard.
5229         * config/nm-linux.h: Add include guard.
5230         * config/i386/nm-i386gnu.h: Rename include guard.
5231         * config/djgpp/nl_types.h: Rename include guard.
5232         * config/djgpp/langinfo.h: Rename include guard.
5233         * compile/gcc-cp-plugin.h: Add include guard.
5234         * compile/gcc-c-plugin.h: Add include guard.
5235         * compile/compile.h: Rename include guard.
5236         * compile/compile-object-run.h: Rename include guard.
5237         * compile/compile-object-load.h: Rename include guard.
5238         * compile/compile-internal.h: Rename include guard.
5239         * compile/compile-cplus.h: Rename include guard.
5240         * compile/compile-c.h: Rename include guard.
5241         * common/xml-utils.h: Rename include guard.
5242         * common/x86-xstate.h: Rename include guard.
5243         * common/version.h: Rename include guard.
5244         * common/vec.h: Rename include guard.
5245         * common/tdesc.h: Rename include guard.
5246         * common/selftest.h: Rename include guard.
5247         * common/scoped_restore.h: Rename include guard.
5248         * common/scoped_mmap.h: Rename include guard.
5249         * common/scoped_fd.h: Rename include guard.
5250         * common/safe-iterator.h: Rename include guard.
5251         * common/run-time-clock.h: Rename include guard.
5252         * common/refcounted-object.h: Rename include guard.
5253         * common/queue.h: Rename include guard.
5254         * common/ptid.h: Rename include guard.
5255         * common/print-utils.h: Rename include guard.
5256         * common/preprocessor.h: Rename include guard.
5257         * common/pathstuff.h: Rename include guard.
5258         * common/observable.h: Rename include guard.
5259         * common/netstuff.h: Rename include guard.
5260         * common/job-control.h: Rename include guard.
5261         * common/host-defs.h: Rename include guard.
5262         * common/gdb_wait.h: Rename include guard.
5263         * common/gdb_vecs.h: Rename include guard.
5264         * common/gdb_unlinker.h: Rename include guard.
5265         * common/gdb_unique_ptr.h: Rename include guard.
5266         * common/gdb_tilde_expand.h: Rename include guard.
5267         * common/gdb_sys_time.h: Rename include guard.
5268         * common/gdb_string_view.h: Rename include guard.
5269         * common/gdb_splay_tree.h: Rename include guard.
5270         * common/gdb_setjmp.h: Rename include guard.
5271         * common/gdb_ref_ptr.h: Rename include guard.
5272         * common/gdb_optional.h: Rename include guard.
5273         * common/gdb_locale.h: Rename include guard.
5274         * common/gdb_assert.h: Rename include guard.
5275         * common/filtered-iterator.h: Rename include guard.
5276         * common/filestuff.h: Rename include guard.
5277         * common/fileio.h: Rename include guard.
5278         * common/environ.h: Rename include guard.
5279         * common/common-utils.h: Rename include guard.
5280         * common/common-types.h: Rename include guard.
5281         * common/common-regcache.h: Rename include guard.
5282         * common/common-inferior.h: Rename include guard.
5283         * common/common-gdbthread.h: Rename include guard.
5284         * common/common-exceptions.h: Rename include guard.
5285         * common/common-defs.h: Rename include guard.
5286         * common/common-debug.h: Rename include guard.
5287         * common/cleanups.h: Rename include guard.
5288         * common/buffer.h: Rename include guard.
5289         * common/btrace-common.h: Rename include guard.
5290         * common/break-common.h: Rename include guard.
5291         * cli/cli-utils.h: Rename include guard.
5292         * cli/cli-style.h: Rename include guard.
5293         * cli/cli-setshow.h: Rename include guard.
5294         * cli/cli-script.h: Rename include guard.
5295         * cli/cli-interp.h: Rename include guard.
5296         * cli/cli-decode.h: Rename include guard.
5297         * cli/cli-cmds.h: Rename include guard.
5298         * charset-list.h: Add include guard.
5299         * buildsym-legacy.h: Rename include guard.
5300         * bfin-tdep.h: Add include guard.
5301         * ax.h: Rename include guard.
5302         * arm-linux-tdep.h: Add include guard.
5303         * arm-fbsd-tdep.h: Add include guard.
5304         * arch/xtensa.h: Rename include guard.
5305         * arch/tic6x.h: Add include guard.
5306         * arch/i386.h: Add include guard.
5307         * arch/arm.h: Rename include guard.
5308         * arch/arm-linux.h: Rename include guard.
5309         * arch/arm-get-next-pcs.h: Rename include guard.
5310         * arch/amd64.h: Add include guard.
5311         * arch/aarch64-insn.h: Rename include guard.
5312         * arch-utils.h: Rename include guard.
5313         * annotate.h: Add include guard.
5314         * amd64-darwin-tdep.h: Rename include guard.
5315         * aarch64-linux-tdep.h: Add include guard.
5316         * aarch64-fbsd-tdep.h: Add include guard.
5317         * aarch32-linux-nat.h: Add include guard.
5318
5319 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5320
5321         * macrotab.c (macro_define_internal): New function that
5322         factorizes macro_define_object_internal and macro_define_function
5323         code.
5324         (macro_define_object_internal): Use macro_define_internal.
5325         (macro_define_function): Likewise.
5326
5327 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5328
5329         * macrocmd.c (extract_identifier): Return
5330         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5331         callers.
5332
5333 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5334
5335         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5336
5337 2019-02-05  Tom Tromey  <tom@tromey.com>
5338
5339         * target.c (target_stack::unpush): Move assertion earlier.
5340
5341 2019-01-30  Tom Tromey  <tom@tromey.com>
5342
5343         PR python/23615:
5344         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5345         (gdbpy_parse_and_eval): Likewise.
5346         * python/python-internal.h (gdbpy_allow_threads): New class.
5347
5348 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5349
5350         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5351         (aarch64_fbsd_fpregmap): Move earlier.
5352         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5353         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5354         instead of individual calls to trad_frame_set_reg_addr.
5355         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5356         earlier.
5357         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5358         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5359         instead of individual calls to trad_frame_set_reg_addr.
5360
5361 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5362
5363         * CONTRIBUTE: Replace contribution list with wiki link.
5364
5365 2019-01-25  Tom Tromey  <tom@tromey.com>
5366
5367         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5368
5369 2019-01-25  Tom Tromey  <tom@tromey.com>
5370
5371         * xtensa-linux-nat.c: Fix common/ includes.
5372         * xml-support.h: Fix common/ includes.
5373         * xml-support.c: Fix common/ includes.
5374         * x86-linux-nat.c: Fix common/ includes.
5375         * windows-nat.c: Fix common/ includes.
5376         * varobj.h: Fix common/ includes.
5377         * varobj.c: Fix common/ includes.
5378         * value.c: Fix common/ includes.
5379         * valops.c: Fix common/ includes.
5380         * utils.c: Fix common/ includes.
5381         * unittests/xml-utils-selftests.c: Fix common/ includes.
5382         * unittests/utils-selftests.c: Fix common/ includes.
5383         * unittests/unpack-selftests.c: Fix common/ includes.
5384         * unittests/tracepoint-selftests.c: Fix common/ includes.
5385         * unittests/style-selftests.c: Fix common/ includes.
5386         * unittests/string_view-selftests.c: Fix common/ includes.
5387         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5388         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5389         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5390         * unittests/rsp-low-selftests.c: Fix common/ includes.
5391         * unittests/parse-connection-spec-selftests.c: Fix common/
5392         includes.
5393         * unittests/optional-selftests.c: Fix common/ includes.
5394         * unittests/offset-type-selftests.c: Fix common/ includes.
5395         * unittests/observable-selftests.c: Fix common/ includes.
5396         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5397         * unittests/memrange-selftests.c: Fix common/ includes.
5398         * unittests/memory-map-selftests.c: Fix common/ includes.
5399         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5400         * unittests/function-view-selftests.c: Fix common/ includes.
5401         * unittests/environ-selftests.c: Fix common/ includes.
5402         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5403         * unittests/common-utils-selftests.c: Fix common/ includes.
5404         * unittests/cli-utils-selftests.c: Fix common/ includes.
5405         * unittests/array-view-selftests.c: Fix common/ includes.
5406         * ui-file.c: Fix common/ includes.
5407         * tui/tui-io.c: Fix common/ includes.
5408         * tracepoint.h: Fix common/ includes.
5409         * tracepoint.c: Fix common/ includes.
5410         * tracefile-tfile.c: Fix common/ includes.
5411         * top.h: Fix common/ includes.
5412         * top.c: Fix common/ includes.
5413         * thread.c: Fix common/ includes.
5414         * target/waitstatus.h: Fix common/ includes.
5415         * target/waitstatus.c: Fix common/ includes.
5416         * target.h: Fix common/ includes.
5417         * target.c: Fix common/ includes.
5418         * target-memory.c: Fix common/ includes.
5419         * target-descriptions.c: Fix common/ includes.
5420         * symtab.h: Fix common/ includes.
5421         * symfile.c: Fix common/ includes.
5422         * stap-probe.c: Fix common/ includes.
5423         * spu-linux-nat.c: Fix common/ includes.
5424         * sparc-nat.c: Fix common/ includes.
5425         * source.c: Fix common/ includes.
5426         * solib.c: Fix common/ includes.
5427         * solib-target.c: Fix common/ includes.
5428         * ser-unix.c: Fix common/ includes.
5429         * ser-tcp.c: Fix common/ includes.
5430         * ser-pipe.c: Fix common/ includes.
5431         * ser-base.c: Fix common/ includes.
5432         * selftest-arch.c: Fix common/ includes.
5433         * s12z-tdep.c: Fix common/ includes.
5434         * rust-exp.y: Fix common/ includes.
5435         * rs6000-aix-tdep.c: Fix common/ includes.
5436         * riscv-tdep.c: Fix common/ includes.
5437         * remote.c: Fix common/ includes.
5438         * remote-notif.h: Fix common/ includes.
5439         * remote-fileio.h: Fix common/ includes.
5440         * remote-fileio.c: Fix common/ includes.
5441         * regcache.h: Fix common/ includes.
5442         * regcache.c: Fix common/ includes.
5443         * record-btrace.c: Fix common/ includes.
5444         * python/python.c: Fix common/ includes.
5445         * python/py-type.c: Fix common/ includes.
5446         * python/py-inferior.c: Fix common/ includes.
5447         * progspace.h: Fix common/ includes.
5448         * producer.c: Fix common/ includes.
5449         * procfs.c: Fix common/ includes.
5450         * proc-api.c: Fix common/ includes.
5451         * printcmd.c: Fix common/ includes.
5452         * ppc-linux-nat.c: Fix common/ includes.
5453         * parser-defs.h: Fix common/ includes.
5454         * osdata.c: Fix common/ includes.
5455         * obsd-nat.c: Fix common/ includes.
5456         * nat/x86-linux.c: Fix common/ includes.
5457         * nat/x86-linux-dregs.c: Fix common/ includes.
5458         * nat/x86-dregs.h: Fix common/ includes.
5459         * nat/x86-dregs.c: Fix common/ includes.
5460         * nat/ppc-linux.c: Fix common/ includes.
5461         * nat/mips-linux-watch.h: Fix common/ includes.
5462         * nat/mips-linux-watch.c: Fix common/ includes.
5463         * nat/linux-waitpid.c: Fix common/ includes.
5464         * nat/linux-ptrace.h: Fix common/ includes.
5465         * nat/linux-ptrace.c: Fix common/ includes.
5466         * nat/linux-procfs.c: Fix common/ includes.
5467         * nat/linux-personality.c: Fix common/ includes.
5468         * nat/linux-osdata.c: Fix common/ includes.
5469         * nat/linux-namespaces.c: Fix common/ includes.
5470         * nat/linux-btrace.h: Fix common/ includes.
5471         * nat/linux-btrace.c: Fix common/ includes.
5472         * nat/fork-inferior.c: Fix common/ includes.
5473         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5474         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5475         * nat/aarch64-linux.c: Fix common/ includes.
5476         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5477         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5478         * namespace.h: Fix common/ includes.
5479         * mips-linux-tdep.c: Fix common/ includes.
5480         * minsyms.c: Fix common/ includes.
5481         * mi/mi-parse.h: Fix common/ includes.
5482         * mi/mi-main.c: Fix common/ includes.
5483         * mi/mi-cmd-env.c: Fix common/ includes.
5484         * memrange.h: Fix common/ includes.
5485         * memattr.c: Fix common/ includes.
5486         * maint.h: Fix common/ includes.
5487         * maint.c: Fix common/ includes.
5488         * main.c: Fix common/ includes.
5489         * machoread.c: Fix common/ includes.
5490         * location.c: Fix common/ includes.
5491         * linux-thread-db.c: Fix common/ includes.
5492         * linux-nat.c: Fix common/ includes.
5493         * linux-fork.c: Fix common/ includes.
5494         * inline-frame.c: Fix common/ includes.
5495         * infrun.c: Fix common/ includes.
5496         * inflow.c: Fix common/ includes.
5497         * inferior.h: Fix common/ includes.
5498         * inferior.c: Fix common/ includes.
5499         * infcmd.c: Fix common/ includes.
5500         * inf-ptrace.c: Fix common/ includes.
5501         * inf-child.c: Fix common/ includes.
5502         * ia64-linux-nat.c: Fix common/ includes.
5503         * i387-tdep.c: Fix common/ includes.
5504         * i386-tdep.c: Fix common/ includes.
5505         * i386-linux-tdep.c: Fix common/ includes.
5506         * i386-linux-nat.c: Fix common/ includes.
5507         * i386-go32-tdep.c: Fix common/ includes.
5508         * i386-fbsd-tdep.c: Fix common/ includes.
5509         * i386-fbsd-nat.c: Fix common/ includes.
5510         * guile/scm-type.c: Fix common/ includes.
5511         * guile/guile.c: Fix common/ includes.
5512         * go32-nat.c: Fix common/ includes.
5513         * gnu-nat.c: Fix common/ includes.
5514         * gdbthread.h: Fix common/ includes.
5515         * gdbarch-selftests.c: Fix common/ includes.
5516         * gdb_usleep.c: Fix common/ includes.
5517         * gdb_select.h: Fix common/ includes.
5518         * gdb_bfd.c: Fix common/ includes.
5519         * gcore.c: Fix common/ includes.
5520         * fork-child.c: Fix common/ includes.
5521         * findvar.c: Fix common/ includes.
5522         * fbsd-nat.c: Fix common/ includes.
5523         * event-top.c: Fix common/ includes.
5524         * event-loop.c: Fix common/ includes.
5525         * dwarf2read.c: Fix common/ includes.
5526         * dwarf2loc.c: Fix common/ includes.
5527         * dwarf2-frame.c: Fix common/ includes.
5528         * dwarf-index-cache.c: Fix common/ includes.
5529         * dtrace-probe.c: Fix common/ includes.
5530         * disasm-selftests.c: Fix common/ includes.
5531         * defs.h: Fix common/ includes.
5532         * csky-tdep.c: Fix common/ includes.
5533         * cp-valprint.c: Fix common/ includes.
5534         * cp-support.h: Fix common/ includes.
5535         * cp-support.c: Fix common/ includes.
5536         * corelow.c: Fix common/ includes.
5537         * completer.h: Fix common/ includes.
5538         * completer.c: Fix common/ includes.
5539         * compile/compile.c: Fix common/ includes.
5540         * compile/compile-loc2c.c: Fix common/ includes.
5541         * compile/compile-cplus-types.c: Fix common/ includes.
5542         * compile/compile-cplus-symbols.c: Fix common/ includes.
5543         * command.h: Fix common/ includes.
5544         * cli/cli-dump.c: Fix common/ includes.
5545         * cli/cli-cmds.c: Fix common/ includes.
5546         * charset.c: Fix common/ includes.
5547         * build-id.c: Fix common/ includes.
5548         * btrace.h: Fix common/ includes.
5549         * btrace.c: Fix common/ includes.
5550         * breakpoint.h: Fix common/ includes.
5551         * breakpoint.c: Fix common/ includes.
5552         * ax.h:
5553         (enum agent_op): Fix common/ includes.
5554         * ax-general.c (struct aop_map): Fix common/ includes.
5555         * ax-gdb.c: Fix common/ includes.
5556         * auxv.c: Fix common/ includes.
5557         * auto-load.c: Fix common/ includes.
5558         * arm-tdep.c: Fix common/ includes.
5559         * arch/riscv.c: Fix common/ includes.
5560         * arch/ppc-linux-common.c: Fix common/ includes.
5561         * arch/i386.c: Fix common/ includes.
5562         * arch/arm.c: Fix common/ includes.
5563         * arch/arm-linux.c: Fix common/ includes.
5564         * arch/arm-get-next-pcs.c: Fix common/ includes.
5565         * arch/amd64.c: Fix common/ includes.
5566         * arch/aarch64.c: Fix common/ includes.
5567         * arch/aarch64-insn.c: Fix common/ includes.
5568         * arch-utils.c: Fix common/ includes.
5569         * amd64-windows-tdep.c: Fix common/ includes.
5570         * amd64-tdep.c: Fix common/ includes.
5571         * amd64-sol2-tdep.c: Fix common/ includes.
5572         * amd64-obsd-tdep.c: Fix common/ includes.
5573         * amd64-nbsd-tdep.c: Fix common/ includes.
5574         * amd64-linux-tdep.c: Fix common/ includes.
5575         * amd64-linux-nat.c: Fix common/ includes.
5576         * amd64-fbsd-tdep.c: Fix common/ includes.
5577         * amd64-fbsd-nat.c: Fix common/ includes.
5578         * amd64-dicos-tdep.c: Fix common/ includes.
5579         * amd64-darwin-tdep.c: Fix common/ includes.
5580         * agent.c: Fix common/ includes.
5581         * ada-lang.h: Fix common/ includes.
5582         * ada-lang.c: Fix common/ includes.
5583         * aarch64-tdep.c: Fix common/ includes.
5584
5585 2019-01-25  Tom Tromey  <tom@tromey.com>
5586
5587         * common/create-version.sh: Use common/version.h.
5588
5589 2019-01-24  Pedro Alves  <palves@redhat.com>
5590
5591         * infrun.c (signal_stop, signal_print, signal_program)
5592         (signal_catch, signal_pass): Now arrays instead of pointers.
5593         (update_signals_program_target, do_target_resume)
5594         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5595         * linux-nat.c (linux_nat_target::pass_signals)
5596         (linux_nat_target::create_inferior, linux_nat_target::attach):
5597         Adjust.
5598         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5599         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5600         * procfs.c (procfs_target::pass_signals): Adjust.
5601         * record-full.c (record_full_target::resume): Adjust.
5602         * remote.c (remote_target::pass_signals)
5603         (remote_target::program_signals): Adjust.
5604         * target-debug.h (target_debug_print_signals): Now takes a
5605         gdb::array_view as parameter.  Adjust.
5606         * target.h (target_ops) <pass_signals, program_signals>: Replace
5607         pointer and length parameters with gdb::array_view.
5608         (target_pass_signals, target_program_signals): Likewise.
5609         * target-delegates.c: Regenerate.
5610
5611 2019-01-24  Pedro Alves  <palves@redhat.com>
5612
5613         * common/forward-scope-exit.h
5614         (forward_scope_exit::forward_scope_exit): Pass arguments to
5615         m_bind_function directly, instead of creating a std::bind and
5616         copying that.
5617
5618 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5619
5620         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5621         for static members.
5622         (pass_in_v_vfp_candidate): Likewise.
5623
5624 2019-01-23  Tom Tromey  <tom@tromey.com>
5625             Pedro Alves  <palves@redhat.com>
5626
5627         * regcache.c (class regcache_invalidator): Remove.
5628         (regcache::raw_write): Use make_scope_exit.
5629
5630 2019-01-23  Tom Tromey  <tom@tromey.com>
5631
5632         * ui-out.h (class ui_out_emit_type): Update comment.
5633
5634 2019-01-23  Tom Tromey  <tom@tromey.com>
5635
5636         * infrun.c (fetch_inferior_event): Update comment.
5637
5638 2019-01-23  Tom Tromey  <tom@tromey.com>
5639             Pedro Alves  <palves@redhat.com>
5640
5641         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5642         parameter.
5643         (fetch_inferior_event): Use SCOPE_EXIT.
5644
5645
5646 2019-01-23  Tom Tromey  <tom@tromey.com>
5647             Pedro Alves  <palves@redhat.com>
5648
5649         * infrun.c (disable_thread_events): Delete.
5650         (stop_all_threads): Use SCOPE_EXIT.
5651
5652 2019-01-23  Tom Tromey  <tom@tromey.com>
5653             Pedro Alves  <palves@redhat.com>
5654
5655         * symfile.c: Include forward-scope-exit.h.
5656         (clear_symtab_users_cleanup): Replace forward declaration with
5657         a FORWARD_SCOPE_EXIT.
5658         (syms_from_objfile_1): Use the forward_scope_exit and
5659         gdb::optional instead of cleanup_function.
5660         (reread_symbols): Use the forward_scope_exit instead of
5661         cleanup_function.
5662         (clear_symtab_users_cleanup): Remove function.
5663
5664 2019-01-23  Tom Tromey  <tom@tromey.com>
5665             Pedro Alves  <palves@redhat.com>
5666
5667         * linux-nat.c: Include scope-exit.h.
5668         (cleanup_target_stop): Remove.
5669         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5670         SCOPE_EXIT.
5671
5672 2019-01-23  Tom Tromey  <tom@tromey.com>
5673             Pedro Alves  <palves@redhat.com>
5674
5675         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5676         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5677
5678 2019-01-23  Tom Tromey  <tom@tromey.com>
5679             Andrew Burgess  <andrew.burgess@embecosm.com>
5680             Pedro Alves  <palves@redhat.com>
5681
5682         * infrun.c (fetch_inferior_event): Use scope_exit.
5683         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5684         * top.c (execute_command): Use scope_exit.
5685         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5686         * utils.c (do_bpstat_clear_actions_cleanup)
5687         (make_bpstat_clear_actions_cleanup): Remove.
5688
5689 2019-01-23  Tom Tromey  <tom@tromey.com>
5690             Pedro Alves  <palves@redhat.com>
5691
5692         * infrun.c: Include "common/scope-exit.h"
5693         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5694         (wait_for_inferior): Use SCOPE_EXIT.
5695         (fetch_inferior_event): Use scope_exit.
5696
5697 2019-01-23  Tom Tromey  <tom@tromey.com>
5698             Pedro Alves  <palves@redhat.com>
5699
5700         * breakpoint.c (create_breakpoint): Remove cleanup.
5701
5702 2019-01-23  Tom Tromey  <tom@tromey.com>
5703             Andrew Burgess  <andrew.burgess@embecosm.com>
5704             Pedro Alves  <palves@redhat.com>
5705
5706 2019-01-23  Pedro Alves  <palves@redhat.com>
5707
5708         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5709
5710 2019-01-23  Pedro Alves  <palves@redhat.com>
5711             Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * gdbthread.h: Include "common/forward-scope-exit.h".
5714         (scoped_finish_thread_state): Redefine custom class in terms of
5715         forward_scope_exit.
5716
5717 2019-01-23  Pedro Alves  <palves@redhat.com>
5718             Andrew Burgess  <andrew.burgess@embecosm.com>
5719
5720         * common/forward-scope-exit.h: New file.
5721
5722 2019-01-23  Pedro Alves  <palves@redhat.com>
5723             Andrew Burgess  <andrew.burgess@embecosm.com>
5724             Tom Tromey  <tom@tromey.com>
5725
5726         * common/scope-exit.h: New file.
5727
5728 2019-01-23  Pedro Alves  <palves@redhat.com>
5729
5730         * common/preprocessor.h (ESC): Rename to ...
5731         (ESC_PARENS): ... this.
5732         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5733         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5734
5735 2019-01-23  Tom Tromey  <tom@tromey.com>
5736
5737         * language.h (class scoped_switch_to_sym_language_if_auto):
5738         Initialize m_lang in both cases.
5739
5740 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5741
5742         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5743         with XCNEW.
5744
5745 2019-01-22  Tom Tromey  <tom@tromey.com>
5746
5747         * corelow.c: Do not include sys/file.h.
5748
5749 2019-01-22  Tom Tromey  <tom@tromey.com>
5750
5751         * tui/tui-wingeneral.h: Include gdb_curses.h.
5752
5753 2019-01-22  Tom Tromey  <tom@tromey.com>
5754
5755         * source-cache.h (class source_cache) <get_source_lines,
5756         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5757
5758 2019-01-22  Tom Tromey  <tom@tromey.com>
5759
5760         * remote-fileio.h (struct remote_target): Declare.
5761
5762 2019-01-22  Tom Tromey  <tom@tromey.com>
5763
5764         * python/py-arch.c: Do not include py-ref.h.
5765         * python/py-bpevent.c: Do not include py-ref.h.
5766         * python/py-cmd.c: Do not include py-ref.h.
5767         * python/py-continueevent.c: Do not include py-ref.h.
5768         * python/py-event.h: Do not include py-ref.h.
5769         * python/py-evtregistry.c: Do not include py-ref.h.
5770         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5771         * python/py-frame.c: Do not include py-ref.h.
5772         * python/py-framefilter.c: Do not include py-ref.h.
5773         * python/py-function.c: Do not include py-ref.h.
5774         * python/py-infevents.c: Do not include py-ref.h.
5775         * python/py-linetable.c: Do not include py-ref.h.
5776         * python/py-objfile.c: Do not include py-ref.h.
5777         * python/py-param.c: Do not include py-ref.h.
5778         * python/py-prettyprint.c: Do not include py-ref.h.
5779         * python/py-progspace.c: Do not include py-ref.h.
5780         * python/py-symbol.c: Do not include py-ref.h.
5781         * python/py-symtab.c: Do not include py-ref.h.
5782         * python/py-type.c: Do not include py-ref.h.
5783         * python/py-unwind.c: Do not include py-ref.h.
5784         * python/py-utils.c: Do not include py-ref.h.
5785         * python/py-value.c: Do not include py-ref.h.
5786         * python/py-varobj.c: Do not include py-ref.h.
5787         * python/py-xmethods.c: Do not include py-ref.h.
5788         * python/python.c: Do not include py-ref.h.
5789         * varobj.c: Do not include py-ref.h.
5790
5791 2019-01-22  Tom Tromey  <tom@tromey.com>
5792
5793         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5794         keyword for bcache.
5795
5796 2019-01-22  Tom Tromey  <tom@tromey.com>
5797
5798         * compile/compile-cplus-types.c: Remove a comment by #include.
5799
5800 2019-01-22  Tom Tromey  <tom@tromey.com>
5801
5802         * compile/gcc-c-plugin.h: Include compile-internal.h.
5803
5804 2019-01-22  Tom Tromey  <tom@tromey.com>
5805
5806         * stabsread.c (EXTERN): Do not define.
5807         (symnum, next_symbol_text_func, processing_gcc_compilation)
5808         (within_function, global_sym_chain, global_stabs)
5809         (previous_stab_code, this_object_header_files)
5810         (n_this_object_header_files)
5811         (n_allocated_this_object_header_files): Define.
5812         * stabsread.h (EXTERN): Never define.  Use "extern".
5813
5814 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5815
5816         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5817         history_value.
5818
5819 2019-01-21  Tom Tromey  <tom@tromey.com>
5820
5821         * ui-out.c: Fix includes.
5822         * tui/tui-source.c: Fix includes.
5823         * target.c: Fix includes.
5824         * remote.c: Fix includes.
5825         * regcache.c: Fix includes.
5826         * python/py-block.c: Fix includes.
5827         * printcmd.c: Fix includes.
5828         * or1k-tdep.c: Fix includes.
5829         * mi/mi-main.c: Fix includes.
5830         * m32r-tdep.c: Fix includes.
5831         * csky-tdep.c: Fix includes.
5832         * compile/compile-cplus-types.c: Fix includes.
5833         * cli/cli-interp.c: Fix includes.
5834
5835 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5836
5837         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5838         for padding.
5839
5840 2019-01-16  Tom Tromey  <tom@tromey.com>
5841
5842         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5843         earlier.
5844         (struct objfile) <msymbols_range>: Move from top level.
5845         <msymbols>: New method.
5846         (class objfile_msymbols): Remove.
5847         * symtab.c (default_collect_symbol_completion_matches_break_on):
5848         Update.
5849         * symmisc.c (dump_msymbols): Update.
5850         * stabsread.c (scan_file_globals): Update.
5851         * objc-lang.c (info_selectors_command, info_classes_command)
5852         (find_methods): Update.
5853         * minsyms.c (find_solib_trampoline_target): Update.
5854         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5855         * coffread.c (coff_symfile_read): Update.
5856         * ada-lang.c (ada_lookup_simple_minsym)
5857         (ada_collect_symbol_completion_matches): Update.
5858
5859 2019-01-16  Tom Tromey  <tom@tromey.com>
5860
5861         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5862         type.  Remove no-argument constructor.
5863         <iterator::operator++>: Simplify.
5864         <begin>: Update.
5865         <end>: Use minimal_symbol_count.
5866
5867 2019-01-16  Tom Tromey  <tom@tromey.com>
5868
5869         * objfiles.h (struct objfile) <psymtabs>: New method.
5870         (class objfile_psymtabs): Remove.
5871         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5872         typedef.
5873         <range>: New method.
5874         (require_partial_symbols): Change return type.
5875         * psymtab.c (require_partial_symbols)
5876         (psym_expand_symtabs_matching): Update.
5877         * mdebugread.c (parse_partial_symbols): Update.
5878         * dbxread.c (dbx_end_psymtab): Update.
5879
5880 2019-01-15  Tom Tromey  <tom@tromey.com>
5881
5882         * symtab.c (lookup_objfile_from_block)
5883         (lookup_symbol_in_objfile_symtabs)
5884         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5885         (find_line_symtab, info_sources_command)
5886         (default_collect_symbol_completion_matches_break_on)
5887         (make_source_files_completion_list): Update.
5888         * symmisc.c (print_objfile_statistics, dump_objfile)
5889         (maintenance_print_symbols, maintenance_info_symtabs)
5890         (maintenance_check_symtabs, maintenance_info_line_tables):
5891         Update.
5892         * source.c (select_source_symtab)
5893         (forget_cached_source_info_for_objfile): Update.
5894         * objfiles.h (class objfile_compunits): Remove.
5895         (struct objfile) <compunits_range>: New typedef.
5896         (compunits): New method.
5897         * objfiles.c (objfile_relocate1): Update.
5898         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5899         * maint.c (count_symtabs_and_blocks): Update.
5900         * linespec.c (iterate_over_all_matching_symtabs): Update.
5901         * cp-support.c (add_symbol_overload_list_qualified): Update.
5902         * coffread.c (coff_symtab_read): Update.
5903         * ada-lang.c (add_nonlocal_symbols)
5904         (ada_collect_symbol_completion_matches)
5905         (ada_add_global_exceptions): Update.
5906
5907 2019-01-15  Tom Tromey  <tom@tromey.com>
5908
5909         * progspace.h (program_space) <objfiles_safe_range>: New
5910         typedef.
5911         <objfiles_safe>: New method.
5912         * objfiles.h (class all_objfiles_safe): Remove.
5913         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5914         * jit.c (jit_inferior_exit_hook): Update.
5915
5916 2019-01-17  Tom Tromey  <tom@tromey.com>
5917
5918         * progspace.h (program_space) <objfiles_range>: New typedef.
5919         <objfiles>: New method.
5920         <objfiles_head>: Rename from objfiles.
5921         (object_files): Update.
5922         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5923         * guile/scm-pretty-print.c
5924         (ppscm_find_pretty_printer_from_objfiles): Update.
5925         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5926         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5927         Update.
5928         * python/py-progspace.c (pspy_get_objfiles): Update.
5929         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5930         Update.
5931         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5932         (objfpy_lookup_objfile_by_build_id): Update.
5933         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5934         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5935         Update.
5936         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5937         (expand_symtab_containing_pc, lookup_objfile_from_block)
5938         (lookup_static_symbol, basic_lookup_transparent_type)
5939         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5940         (find_line_symtab, info_sources_command)
5941         (default_collect_symbol_completion_matches_break_on)
5942         (make_source_files_completion_list, find_main_name): Update.
5943         * symmisc.c (print_symbol_bcache_statistics)
5944         (print_objfile_statistics, maintenance_print_symbols)
5945         (maintenance_print_msymbols, maintenance_print_objfiles)
5946         (maintenance_info_symtabs, maintenance_check_symtabs)
5947         (maintenance_expand_symtabs, maintenance_info_line_tables):
5948         Update.
5949         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5950         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5951         (map_overlay_command, unmap_overlay_command)
5952         (simple_overlay_update, expand_symtabs_matching)
5953         (map_symbol_filenames): Update.
5954         * symfile-debug.c (set_debug_symfile): Update.
5955         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5956         Update.
5957         * source.c (select_source_symtab, forget_cached_source_info):
5958         Update.
5959         * solib.c (solib_read_symbols): Update.
5960         * solib-spu.c (append_ocl_sos): Update.
5961         * psymtab.c (maintenance_print_psymbols)
5962         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5963         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5964         * printcmd.c (info_symbol_command): Update.
5965         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5966         Update.
5967         * objfiles.h (class all_objfiles): Remove.
5968         * objfiles.c (have_partial_symbols, have_full_symbols)
5969         (have_minimal_symbols, qsort_cmp, update_section_map)
5970         (shared_objfile_contains_address_p)
5971         (default_iterate_over_objfiles_in_search_order): Update.
5972         * objc-lang.c (info_selectors_command, info_classes_command)
5973         (find_methods): Update.
5974         * minsyms.c (find_solib_trampoline_target): Update.
5975         * maint.c (maintenance_info_sections)
5976         (maintenance_translate_address, count_symtabs_and_blocks):
5977         Update.
5978         * main.c (captured_main_1): Update.
5979         * linux-thread-db.c (try_thread_db_load_from_pdir)
5980         (has_libpthread): Update.
5981         * linespec.c (iterate_over_all_matching_symtabs)
5982         (search_minsyms_for_name): Update.
5983         * jit.c (jit_find_objf_with_entry_addr): Update.
5984         * hppa-tdep.c (find_unwind_entry)
5985         (hppa_lookup_stub_minimal_symbol): Update.
5986         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5987         Update.
5988         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5989         (elf_gnu_ifunc_resolve_by_got): Update.
5990         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5991         * dwarf-index-write.c (save_gdb_index_command): Update.
5992         * cp-support.c (add_symbol_overload_list_qualified): Update.
5993         * breakpoint.c (create_overlay_event_breakpoint)
5994         (create_longjmp_master_breakpoint)
5995         (create_std_terminate_master_breakpoint)
5996         (create_exception_master_breakpoint): Update.
5997         * blockframe.c (find_pc_partial_function): Update.
5998         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5999         (ada_collect_symbol_completion_matches)
6000         (ada_add_global_exceptions): Update.
6001
6002 2019-01-17  Tom Tromey  <tom@tromey.com>
6003
6004         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6005         declare VEC.
6006         (solib_target_parse_libraries): Change return type.
6007         (library_list_start_segment, library_list_start_section)
6008         (library_list_end_library, library_list_start_library); Update.
6009         (solib_target_free_library_list): Remove.
6010         (solib_target_parse_libraries): Remove cleanup.  Change return
6011         type.
6012         (solib_target_current_sos): Update.
6013
6014 2019-01-17  Tom Tromey  <tromey@bapiya>
6015
6016         * valprint.c: Replace "the the" with "the".
6017         * symtab.c: Replace "the the" with "the".
6018         * solib.c: Replace "the the" with "the".
6019         * solib-dsbt.c: Replace "the the" with "the".
6020         * linespec.c: Replace "the the" with "the".
6021         * dwarf2loc.h: Replace "the the" with "the".
6022         * amd64-windows-tdep.c: Replace "the the" with "the".
6023         * aarch64-tdep.c: Replace "the the" with "the".
6024
6025 2019-01-16  Keith Seitz  <keiths@redhat.com>
6026
6027         PR gdb/23773
6028         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6029         <builder>: Rename to ..
6030         <m_builder>: ... this and make private.
6031         (dwarf2_cu::get_builder): New method.  Change all users of
6032         `builder' to use this method.
6033         (dwarf2_start_symtab): Move to ...
6034         (dwarf2_cu::start_symtab): ... here.  Update all callers
6035         (setup_type_unit_groups): Move to ...
6036         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6037         callers.
6038         (dwarf2_cu::reset_builder): New method.
6039         (process_full_compunit, process_full_type_unit): Use
6040         dwarf2_cu::reset_builder.
6041         (follow_die_offset): Record the ancestor CU if it is different
6042         from the followed DIE's CU.
6043         (follow_die_sig_1): Likewise.
6044
6045 2019-01-15  Tom Tromey  <tom@tromey.com>
6046
6047         * remote.c (class remote_state) <buf>: Now a char_vector.
6048         <buf_size>: Remove.
6049         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6050         parameter.
6051         (remote_target::getpkt_or_notif_sane_1)
6052         (remote_target::getpkt_sane)
6053         (remote_target::getpkt_or_notif_sane): Likewise.
6054         (class remote_target) <putpkt>: New overload.
6055         (remote_target::read_frame): Change type of "buf_p".  Remove
6056         sizeof_p parameter.
6057         (packet_ok): New overload.
6058         (packet_check_result): New overload.
6059         Update all uses.
6060
6061 2019-01-14  Tom Tromey  <tom@tromey.com>
6062
6063         * remote-notif.c (handle_notification, remote_notif_ack)
6064         (remote_notif_parse): Make "buf" const.
6065         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6066         const.
6067         (remote_notif_parse, remote_notif_ack, handle_notification):
6068         Likewise.
6069         * remote.c (remote_notif_stop_parse): Make "buf" const.
6070         (remote_target::remote_parse_stop_reply): Make "buf" const.
6071         (remote_notif_stop_ack): Make "buf" const.
6072
6073 2019-01-14  Tom Tromey  <tom@tromey.com>
6074
6075         * remote.c (remote_console_output): Make parameter const.
6076
6077 2019-01-14  Tom Tromey  <tom@tromey.com>
6078
6079         * target-debug.h (target_debug_print_signals): Constify.
6080         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6081         * procfs.c (procfs_target::pass_signals): Update.
6082         * linux-nat.c (linux_nat_target::pass_signals): Update.
6083         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6084         * target-delegates.c: Rebuild.
6085         * remote.c (remote_target::program_signals): Update.
6086         (remote_target::pass_signals): Update.
6087         * target.c (target_pass_signals): Constify argument.
6088         (target_program_signals): Likewise.
6089         * target.h (struct target_ops) <pass_signals, program_signals>:
6090         Constify argument.
6091         (target_pass_signals, target_program_signals): Constify argument.
6092
6093 2019-01-14  Tom Tromey  <tom@tromey.com>
6094
6095         PR tui/28819:
6096         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6097
6098 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6099
6100         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6101         field.
6102         * rs6000-tdep.c: Include reggroups.h.
6103         (IS_V_ALIAS_PSEUDOREG): Define.
6104         (rs6000_register_name): Return names for the "vX" aliases.
6105         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6106         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6107         aliases.  Call default_register_reggroup_p for all other
6108         pseudo-registers.
6109         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6110         New functions.
6111         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6112         Handle "vX" aliases.
6113         (v_alias_pseudo_register_collect): New function.
6114         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6115         (rs6000_gdbarch_init): Initialize "vX" aliases as
6116         pseudo-registers.  Restore registration of
6117         rs6000_pseudo_register_reggroup_p with
6118         set_tdesc_pseudo_register_reggroup_p.
6119
6120 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6121
6122         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6123         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6124         set_gdbarch_num_pseudo_regs.
6125
6126 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6127
6128         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6129         Remove arg prefixname, add do_set and do_show.
6130         Add member functions set_list and show_list.
6131         * cli/cli-style.c (class cli_style_option): Update accordingly.
6132         (style_set_list): Move to file scope.
6133         (style_show_list): Likewise.
6134         (set_style): Call help_list.
6135         (show_style): Call cmd_show_list.
6136         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6137         Update to use the new macro.
6138
6139 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6140
6141         * ada-lang.c (_initialize_ada_language): Expand the help text
6142         for the "catch exception" command.
6143
6144 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6145
6146         * symtab.c (matching_obj_sections): Initialize obj,
6147         declare it closer to its usage.
6148
6149 2019-01-10  Tom Tromey  <tom@tromey.com>
6150
6151         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6152         (basic_inf_threads_range): Remove.
6153         (inf_threads_range, inf_non_exited_threads_range)
6154         (safe_inf_threads_range): Use next_adapter.
6155
6156 2019-01-10  Keith Seitz  <keiths@redhat.com>
6157
6158         PR gdb/23712
6159         PR symtab/23010
6160         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6161         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6162
6163 2019-01-10  Keith Seitz  <keiths@redhat.com>
6164
6165         PR gdb/23712
6166         PR symtab/23010
6167         * dictionary.c (pending_to_vector): Remove.
6168         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6169         Remove _1 suffix, replacing functions of the same name.  Update
6170         all callers.
6171         (dict_create_hashed, dict_create_hashed_expandable)
6172         (dict_create_linear, dict_create_linear_expandable, dict_free)
6173         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6174         Make functions static.
6175
6176 2019-01-10  Keith Seitz  <keiths@redhat.com>
6177
6178         PR gdb/23712
6179         PR symtab/23010
6180         * dictionary.h (struct dictionary): Replace declaration with
6181         multidictionary.
6182         (dict_create_hashed, dict_create_hashed_expandable)
6183         (dict_create_linear, dict_create_linear_expandable)
6184         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6185         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6186         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6187         taking multidictionary argument.
6188         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6189         * block.h (struct block) <dict>: Change to multidictionary
6190         and rename `multidict'.
6191         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6192         symmisc.c: Update all dictionary references to multidictionary.
6193
6194 2019-01-10  Keith Seitz  <keiths@redhat.com>
6195
6196         PR gdb/23712
6197         PR symtab/23010
6198         * dictionary.c: Include unordered_map.
6199         (pending_to_vector): New function.
6200         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6201         Rewrite the non-"_1" functions to take vector instead
6202         of linked list.
6203         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6204         "new" _1 versions of the same name.
6205         (multidictionary): Define.
6206         (std::hash<enum language): New definition.
6207         (collate_pending_symbols_by_language, mdict_create_hashed)
6208         (mdict_create_hashed_expandable, mdict_create_linear)
6209         (mdict_create_linear_expandable, mdict_free)
6210         (find_language_dictionary, create_new_language_dictionary)
6211         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6212         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6213         (mdict_size, mdict_empty): New functions.
6214         * dictionary.h (mdict_iterator): Define.
6215
6216 2019-01-10  Pedro Alves  <palves@redhat.com>
6217
6218         * breakpoint.c (read_uploaded_action)
6219         (create_tracepoint_from_upload): Adjust to use
6220         gdb::unique_xmalloc_ptr.
6221         * ctf.c (ctf_write_uploaded_tp):
6222         (SET_ARRAY_FIELD): Use emplace_back.
6223         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6224         * tracefile-tfile.c (tfile_write_uploaded_tp):
6225         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6226         gdb::unique_xmalloc_ptr.
6227         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6228         at_string, cond_string, cmd_strings>: Replace char pointers
6229         with gdb::unique_xmalloc_ptr.
6230
6231 2019-01-10  Pedro Alves  <palves@redhat.com>
6232
6233         * solib-target.c (library_list_start_library): Don't xstrdup name.
6234
6235 2019-01-10  Pedro Alves  <palves@redhat.com>
6236
6237         * mdebugread.c (parse_partial_symbols): Use
6238         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6239
6240 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6241
6242         * linux-fork.c (scoped_switch_fork_info)
6243         <~scoped_switch_fork_info>: Fix incorrect variable name.
6244
6245 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6246
6247         * linux-fork.c (scoped_switch_fork_info)
6248         <scoped_switch_fork_info>: Make explicit.
6249         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6250
6251 2019-01-10  Tom Tromey  <tom@tromey.com>
6252
6253         * objfiles.h (objfile::reset_psymtabs): Update.
6254         * objfiles.c (objfile::objfile): Update.
6255         * psymtab.h (psymtab_storage::obstack): Update.
6256         (psymtab_storage::m_obstack): Use gdb::optional.
6257         (class psymtab_storage): Update comment.  Remove objfile
6258         parameter.
6259         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6260
6261 2019-01-10  Tom Tromey  <tom@tromey.com>
6262
6263         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6264         <free_psymtabs>: Now private.
6265         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6266         (allocate_psymtab): Use new method.
6267
6268 2019-01-10  Tom Tromey  <tom@tromey.com>
6269
6270         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6271         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6272         * mdebugread.c (parse_partial_symbols): Use
6273         allocate_dependencies.
6274         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6275         allocate_dependencies.
6276         (process_psymtab_comp_unit_reader)
6277         (build_type_psymtab_dependencies): Likewise.
6278         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6279
6280 2019-01-10  Tom Tromey  <tom@tromey.com>
6281
6282         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6283         PSYMBOL_SET_LANGUAGE.
6284         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6285
6286 2019-01-10  Tom Tromey  <tom@tromey.com>
6287
6288         * psymtab.h (psymtab_storage::obstack): New method.
6289         <m_obstack>: Rename from obstack; now private.
6290         * psymtab.c (psymtab_storage): Update.
6291         * dwarf2read.c (create_addrmap_from_index)
6292         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6293         Update.
6294
6295 2019-01-10  Tom Tromey  <tom@tromey.com>
6296
6297         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6298         * objfiles.h (objfile::reset_psymtabs): New method.
6299
6300 2019-01-10  Tom Tromey  <tom@tromey.com>
6301
6302         * symmisc.c (print_symbol_bcache_statistics): Update.
6303         (print_objfile_statistics): Update.
6304         * symfile.c (reread_symbols): Update.
6305         * psymtab.h (class psymtab_storage): New.
6306         * psymtab.c (psymtab_storage): New constructor.
6307         (~psymtab_storage): New destructor.
6308         (require_partial_symbols): Update.
6309         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6310         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6311         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6312         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6313         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6314         (start_psymtab_common, end_psymtab_common)
6315         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6316         (allocate_psymtab): Update.
6317         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6318         Update.
6319         (dump_psymtab_addrmap, maintenance_print_psymbols)
6320         (maintenance_check_psymtabs): Update.
6321         (class objfile_psymtabs): Move to objfiles.h.
6322         * psympriv.h (discard_psymtab): Now inline.
6323         (psymtab_discarder::psymtab_discarder): Update.
6324         (psymtab_discarder::~psymtab_discarder): Update.
6325         (ALL_OBJFILE_PSYMTABS): Rewrite.
6326         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6327         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6328         Remove fields.
6329         <partial_symtabs>: New field.
6330         (class objfile_psymtabs): Move from psymtab.h.  Update.
6331         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6332         psymbol_cache.
6333         (objfile::~objfile): Don't destroy psymbol_cache.
6334         * mdebugread.c (parse_partial_symbols): Update.
6335         * dwarf2read.c (create_addrmap_from_index)
6336         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6337         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6338         (add_partial_subprogram, dwarf2_ranges_read): Update.
6339         * dwarf-index-write.c (write_address_map)
6340         (write_one_signatured_type, recursively_write_psymbols)
6341         (class debug_names, class debug_names, write_psymtabs_to_index):
6342         Update.
6343
6344 2019-01-10  Tom Tromey  <tom@tromey.com>
6345
6346         * symtab.h (SYMBOL_SET_NAMES): Update.
6347         (symbol_set_names): Update.
6348         (MSYMBOL_SET_NAMES): Update.
6349         * symtab.c (symbol_set_names): Change argument to be an
6350         objfile_per_bfd_storage.
6351         * psymtab.c (add_psymbol_to_bcache): Update.
6352         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6353
6354 2019-01-10  Tom Tromey  <tom@tromey.com>
6355
6356         * symtab.c (create_demangled_names_hash): Change argument to be an
6357         objfile_per_bfd_storage.
6358         (symbol_set_names): Update.
6359
6360 2019-01-10  Tom Tromey  <tom@tromey.com>
6361
6362         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6363         init_psymbol_list.
6364         * psymtab.c (init_psymbol_list): Do nothing if already called.
6365         * psympriv.h (init_psymbol_list): Add comment.
6366         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6367         init_psymbol_list.
6368         * dbxread.c (dbx_symfile_read): Unconditionally call
6369         init_psymbol_list.
6370
6371 2019-01-10  Tom Tromey  <tom@tromey.com>
6372
6373         * xcoffread.c (scan_xcoff_symtab): Update.
6374         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6375         "where".
6376         * mdebugread.c (parse_partial_symbols)
6377         (handle_psymbol_enumerators): Update.
6378         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6379         * dbxread.c (read_dbx_symtab): Update.
6380         * psympriv.h (psymbol_placement): New enum.
6381         (add_psymbol_to_list): Update.
6382
6383 2019-01-10  Tom Tromey  <tom@tromey.com>
6384
6385         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6386         static_psymbols parameters.
6387         (scan_xcoff_symtab): Update.
6388         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6389         static_psymbols parameters.
6390         * psympriv.h (start_psymtab_common): Update.
6391         * mdebugread.c (parse_partial_symbols): Update.
6392         * dwarf2read.c (create_partial_symtab): Update.
6393         * dbxread.c (read_dbx_symtab): Update.
6394         (start_psymtab): Remove global_psymbols and static_psymbols
6395         parameters.
6396
6397 2019-01-10  Tom Tromey  <tom@tromey.com>
6398
6399         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6400         * psymtab.c (allocate_psymtab): Add comment.
6401         * psympriv.h (allocate_psymtab): Add comment.
6402         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6403         initializations.
6404         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6405
6406 2019-01-10  Tom Tromey  <tom@tromey.com>
6407
6408         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6409         Don't declare.
6410         * mipsread.c: Include mdebugread.h.
6411         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6412         Declare.
6413         * elfread.c: Include mdebugread.h.
6414
6415 2019-01-09  Tom Tromey  <tom@tromey.com>
6416
6417         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6418         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6419         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6420         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6421         (psym_lookup_symbol, psym_find_last_source_symtab)
6422         (psym_forget_cached_source_info, psym_print_stats)
6423         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6424         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6425         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6426         (psym_find_compunit_symtab_by_address)
6427         (maintenance_print_psymbols, maintenance_info_psymtabs)
6428         (maintenance_check_psymtabs): Use ranged for.
6429         * psymtab.h (class objfile_psymtabs): New.
6430         (require_partial_symbols): Return objfile_psymtabs.
6431         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6432
6433 2019-01-09  Tom Tromey  <tom@tromey.com>
6434
6435         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6436         (find_pc_mapped_section, list_overlays_command)
6437         (map_overlay_command, unmap_overlay_command)
6438         (simple_overlay_update): Use all_objfiles.
6439         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6440         * printcmd.c (info_symbol_command): Use all_objfiles.
6441         * objfiles.h (ALL_OBJSECTIONS): Remove.
6442         * maint.c (maintenance_translate_address): Use all_objfiles.
6443         * gcore.c (gcore_create_callback): Use all_objfiles.
6444         (objfile_find_memory_regions): Likewise.
6445
6446 2019-01-09  Tom Tromey  <tom@tromey.com>
6447
6448         * symtab.c (find_line_symtab, info_sources_command)
6449         (make_source_files_completion_list): Use objfile_compunits.
6450         * source.c (select_source_symtab): Use objfile_compunits.
6451         * objfiles.h (struct objfile): Update comment.
6452         (ALL_OBJFILES): Remove.
6453         (ALL_FILETABS): Remove.
6454         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6455         objfile_compunits.
6456
6457 2019-01-09  Tom Tromey  <tom@tromey.com>
6458
6459         * symmisc.c (print_objfile_statistics, dump_objfile)
6460         (maintenance_print_symbols): Use compunit_filetabs.
6461         * source.c (forget_cached_source_info_for_objfile): Use
6462         compunit_filetabs.
6463         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6464         (ALL_FILETABS): Use compunit_filetabs.
6465         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6466         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6467
6468 2019-01-09  Tom Tromey  <tom@tromey.com>
6469
6470         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6471         (compunit_filetabs): New.
6472         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6473         compunit_filetabs.
6474         (info_sources_command, make_source_files_completion_list): Remove
6475         declaration.
6476         * symmisc.c (print_objfile_statistics, dump_objfile)
6477         (maintenance_print_symbols): Remove declaration.
6478         (maintenance_info_symtabs): Use compunit_filetabs.
6479         (maintenance_info_line_tables): Likewise.
6480         * source.c (select_source_symtab): Change local variable name.
6481         (forget_cached_source_info_for_objfile): Remove declaration.
6482         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6483         * objfiles.c (objfile_relocate1): Remove declaration.
6484         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6485         declaration.
6486         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6487         * coffread.c (coff_symtab_read): Remove declaration.
6488         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6489         compunit_filetabs.
6490
6491 2019-01-09  Tom Tromey  <tom@tromey.com>
6492
6493         * symtab.c (lookup_objfile_from_block)
6494         (find_pc_sect_compunit_symtab, search_symbols)
6495         (default_collect_symbol_completion_matches_break_on): Use
6496         objfile_compunits.
6497         * objfiles.h (ALL_COMPUNITS): Remove.
6498         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6499         * cp-support.c (add_symbol_overload_list_qualified): Use
6500         objfile_compunits.
6501         * ada-lang.c (ada_collect_symbol_completion_matches)
6502         (ada_add_global_exceptions): Use objfile_compunits.
6503
6504 2019-01-09  Tom Tromey  <tom@tromey.com>
6505
6506         * source.c (select_source_symtab)
6507         (forget_cached_source_info_for_objfile): Remove declaration.
6508         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6509         declaration.
6510         * maint.c (count_symtabs_and_blocks): Remove declaration.
6511         * cp-support.c (add_symbol_overload_list_qualified): Remove
6512         declaration.
6513         * coffread.c (coff_symtab_read): Remove declaration.
6514         * symtab.c (lookup_symbol_in_objfile_symtabs)
6515         (basic_lookup_transparent_type_1): Use objfile_compunits.
6516         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6517         (info_sources_command, search_symbols)
6518         (default_collect_symbol_completion_matches_break_on)
6519         (make_source_files_completion_list): Remove declaration.
6520         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6521         (ada_collect_symbol_completion_matches)
6522         (ada_add_global_exceptions): Remove declaration.
6523         * linespec.c (iterate_over_all_matching_symtabs): Use
6524         objfile_compunits.
6525         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6526         (class objfile_compunits): New.
6527         (ALL_COMPUNITS): Use objfile_compunits.
6528         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6529         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6530         objfile_compunits.
6531         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6532
6533 2019-01-09  Tom Tromey  <tom@tromey.com>
6534
6535         * symtab.c (search_symbols)
6536         (default_collect_symbol_completion_matches_break_on): Use
6537         objfile_msymbols.
6538         * ada-lang.c (ada_lookup_simple_minsym)
6539         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6540         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6541         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6542         objfile_msymbols.
6543         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6544         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6545         * objc-lang.c (find_methods): Use objfile_msymbols.
6546         (info_selectors_command, info_classes_command): Likewise.
6547         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6548         * objfiles.h (class objfile_msymbols): New.
6549         (ALL_OBJFILE_MSYMBOLS): Remove.
6550         (ALL_MSYMBOLS): Remove.
6551
6552 2019-01-09  Tom Tromey  <tom@tromey.com>
6553
6554         * common/next-iterator.h (next_adapter): Add Iterator template
6555         parameter.
6556         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6557         (class all_objfiles_safe): New.
6558         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6559         * objfiles.c (put_objfile_before): Update comment.
6560         (add_separate_debug_objfile): Likewise.
6561         (free_all_objfiles): Use all_objfiles_safe.
6562         (objfile_purge_solibs): Likewise.
6563
6564 2019-01-09  Tom Tromey  <tom@tromey.com>
6565
6566         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6567         (expand_symtab_containing_pc, lookup_static_symbol)
6568         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6569         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6570         all_objfiles.
6571         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6572         * breakpoint.c (create_overlay_event_breakpoint)
6573         (create_longjmp_master_breakpoint)
6574         (create_std_terminate_master_breakpoint)
6575         (create_exception_master_breakpoint): Use all_objfiles.
6576         * linux-thread-db.c (try_thread_db_load_from_pdir)
6577         (has_libpthread): Use all_objfiles.
6578         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6579         * linespec.c (iterate_over_all_matching_symtabs)
6580         (search_minsyms_for_name): Use all_objfiles.
6581         * maint.c (maintenance_info_sections): Use all_objfiles.
6582         * main.c (captured_main_1): Use all_objfiles.
6583         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6584         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6585         * guile/scm-pretty-print.c
6586         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6587         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6588         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6589         (maintenance_print_msymbols): Use all_objfiles.
6590         * source.c (select_source_symtab): Use all_objfiles.
6591         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6592         * symfile.c (remove_symbol_file_command)
6593         (expand_symtabs_matching, map_symbol_filenames): Use
6594         all_objfiles.
6595         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6596         all_objfiles.
6597         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6598         * objc-lang.c (find_methods): Use all_objfiles.
6599         * objfiles.c (have_partial_symbols, have_full_symbols)
6600         (have_minimal_symbols, qsort_cmp)
6601         (default_iterate_over_objfiles_in_search_order): Use
6602         all_objfiles.
6603         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6604         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6605         (maintenance_check_psymtabs): Use all_objfiles.
6606         (ALL_PSYMTABS): Remove.
6607         * compile/compile-object-run.c (do_module_cleanup): Use
6608         all_objfiles.
6609         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6610         * cp-support.c (add_symbol_overload_list_qualified): Use
6611         all_objfiles.
6612         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6613         Use all_objfiles.
6614         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6615         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6616         all_objfiles.
6617         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6618         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6619         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6620         Uses all_objfiles.
6621         * solib.c (solib_read_symbols): Use all_objfiles
6622
6623 2019-01-09  Tom Tromey  <tom@tromey.com>
6624
6625         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6626         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6627         all_objfiles.
6628         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6629         * symmisc.c (print_symbol_bcache_statistics)
6630         (print_objfile_statistics, maintenance_print_objfiles)
6631         (maintenance_info_symtabs, maintenance_check_symtabs)
6632         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6633         all_objfiles.
6634         * source.c (forget_cached_source_info): Use all_objfiles.
6635         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6636         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6637         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6638         * objfiles.c (update_section_map): Use all_objfiles.
6639         (shared_objfile_contains_address_p): Likewise.
6640         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6641         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6642
6643 2019-01-09  Tom Tromey  <tom@tromey.com>
6644
6645         * common/next-iterator.h: New file.
6646         * objfiles.h (class all_objfiles): New.
6647         (struct objfile_iterator): New.
6648
6649 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6650
6651         * NEWS: Move the description of the changed "frame", "select-frame",
6652          and "info frame" commands to the Changed commands section.
6653
6654 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6655
6656         * gdbtypes.c (check_stub_method_group): Remove handling of old
6657         mangling schemes.
6658         * linespec.c (find_methods): Likewise.
6659         * stabsread.c (read_member_functions): Likewise.
6660         * valops.c (search_struct_method): Likewise.
6661         (value_struct_elt_for_reference): Likewise.
6662         * NEWS: Mention this change.
6663
6664 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6665
6666         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6667         print_source_lines.
6668         * source.c (print_source_lines_base): Update line number check.
6669         (print_source_lines): New function.
6670         (source_lines_range::source_lines_range): New function.
6671         * source.h (class source_lines_range): New class.
6672         (print_source_lines): New declaration.
6673
6674 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6675
6676         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6677
6678 2019-01-08  Tom Tromey  <tom@tromey.com>
6679             Simon Marchi  <simon.marchi@ericsson.com>
6680
6681         PR gdb/24060
6682         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6683         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6684         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6685         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6686         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6687         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6688
6689 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6690
6691         * source.c (select_source_symtab): Move header comment to
6692         declaration in source.h.
6693         (forget_cached_source_info_for_objfile): Likewise.
6694         (forget_cached_source_info): Likewise.
6695         (identify_source_line): Likewise.
6696         * source.h (identify_source_line): Move declaration from symtab.h
6697         and add comment from source.c
6698         (print_source_lines): Likewise.
6699         (forget_cached_source_info_for_objfile): Likewise.
6700         (forget_cached_source_info): Likewise.
6701         (select_source_symtab): Likewise.
6702         (enum print_source_lines_flag): Move definition from symtab.h.
6703         * symtab.h (identify_source_line): Move declaration to source.h.
6704         (print_source_lines): Likewise.
6705         (forget_cached_source_info_for_objfile): Likewise.
6706         (forget_cached_source_info): Likewise.
6707         (select_source_symtab): Likewise.
6708         (enum print_source_lines_flag): Move definition to source.h.
6709         * tui/tui-hooks.c: Add 'source.h' include.
6710
6711 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6712
6713         * source.c (print_source_lines_base): Handle requests to print
6714         reverse line number sequences, and guard against empty lines
6715         string.
6716
6717 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6718
6719         * source.c (print_source_lines_base): Fix skip of '\r' if next
6720         character is '\n'.
6721
6722 2019-01-06  Tom Tromey  <tom@tromey.com>
6723
6724         * c-exp.y (struct c_parse_state) <macro_original_text,
6725         expansion_obstack>: New member.
6726         (macro_original_text, expansion_obstack): Remove globals.
6727         (scan_macro_expansion, scanning_macro_expansion)
6728         (finished_macro_expansion): Update.
6729         (scan_macro_cleanup): Remove.
6730         (yylex, c_parse): Update.
6731
6732 2019-01-06  Tom Tromey  <tom@tromey.com>
6733
6734         * c-exp.y (struct c_parse_state) <strings>: New member.
6735         (operator_stoken): Update.
6736
6737 2019-01-06  Tom Tromey  <tom@tromey.com>
6738
6739         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6740         (union type_stack_elt) <typelist_val>: Now a pointer to
6741         std::vector.
6742         (type_stack_cleanup): Don't declare.
6743         (push_typelist): Update.
6744         * parse.c (pop_typelist): Return a std::vector.
6745         (push_typelist): Take a std::vector.
6746         (follow_types): Update.  Do not free args.
6747         (type_stack_cleanup): Remove.
6748         * c-exp.y (struct c_parse_state): New.
6749         (cpstate): New global.
6750         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6751         (nonempty_typelist): Update.
6752         (func_mod): Create a new vector.
6753         (c_parse): Create a c_parse_state.
6754         (check_parameter_typelist): Do not delete params.
6755         (function_method): Update.  Do not delete type_list.
6756
6757 2019-01-06  Tom Tromey  <tom@tromey.com>
6758
6759         PR gdb/28155:
6760         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6761         check_typedef.
6762         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6763         (print_return_value): Likewise.
6764
6765 2019-01-05  Tom Tromey  <tom@tromey.com>
6766
6767         * contrib/cleanup_check.py: Remove.
6768         * contrib/gcc-with-excheck: Remove.
6769         * contrib/exsummary.py: Remove.
6770         * contrib/excheck.py: Remove.
6771
6772 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6773
6774         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6775         NULL. Initialize tpprev to NULL instead of assigning it
6776         to NULL on the next statement.
6777         * windows-nat.c (windows_delete_thread): Remove check for
6778         main_thread_id before printing thread exit notifications.
6779         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6780         Remove thread ID check against main_thread_id.
6781         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6782         windows_delete_thread.
6783         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6784
6785 2019-01-04  Tom Tromey  <tom@tromey.com>
6786
6787         * compile/compile.c (_initialize_compile): Use upper case for
6788         metasyntactic variables.
6789         * symmisc.c (_initialize_symmisc): Use upper case for
6790         metasyntactic variables.
6791         * psymtab.c (_initialize_psymtab): Use upper case for
6792         metasyntactic variables.
6793         * demangle.c (demangle_command): Use upper case for metasyntactic
6794         variables.
6795         (_initialize_demangler): Likewise.
6796         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6797         variables.
6798
6799 2019-01-03  Tom Tromey  <tom@tromey.com>
6800
6801         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6802
6803 2019-01-03  Tom Tromey  <tom@tromey.com>
6804
6805         * python/py-symtab.c (salpy_str): Update.
6806         (struct salpy_sal_object) <symtab>: Now a PyObject.
6807         (salpy_dealloc): Update.
6808         (del_objfile_sal): Use gdbpy_ref.
6809
6810 2019-01-03  Tom Tromey  <tom@tromey.com>
6811
6812         * python/py-type.c (convert_field): Use new_reference.  Return
6813         gdbpy_ref.
6814         (make_fielditem): Return gdbpy_ref.
6815         (typy_fields): Update.
6816         (typy_getitem): Update.
6817         (field_name): Return gdbpy_ref.  Use new_reference.
6818         (typy_iterator_iternext): Update.
6819
6820 2019-01-03  Tom Tromey  <tom@tromey.com>
6821
6822         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6823
6824 2019-01-03  Tom Tromey  <tom@tromey.com>
6825
6826         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6827         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6828         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6829         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6830         (pspy_set_type_printers): Likewise.
6831         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6832         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6833         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6834         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6835         (objfpy_set_type_printers): Likewise.
6836
6837 2019-01-03  Tom Tromey  <tom@tromey.com>
6838
6839         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6840         (gdbpy_print_stack): Use gdbpy_err_fetch.
6841         * python/python-internal.h (class gdbpy_err_fetch): New class.
6842         (class gdbpy_enter) <m_error_type, m_error_value,
6843         m_error_traceback>: Remove.
6844         <m_error>: New member.
6845         (gdbpy_exception_to_string): Don't declare.
6846         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6847         * python/py-value.c (convert_value_from_python): Use
6848         gdbpy_err_fetch.
6849         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6850         gdbpy_exception_to_string.
6851         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6852         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6853         gdbpy_err_fetch.
6854
6855 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6856
6857         * linux-nat.c (delete_lwp_cleanup): Delete.
6858         (struct lwp_deleter): New struct.
6859         (lwp_info_up): New typedef.
6860         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6861         lwp_info_up.
6862
6863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6864
6865         * linux-fork.c (class scoped_switch_fork_info): New class.
6866         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6867
6868 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6869
6870         * valops.c (find_overload_match): Remove use of null_cleanup, and
6871         calls to do_cleanups.
6872
6873 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6874
6875         * compile/compile-cplus-types.c
6876         (compile_cplus_instance::decl_name): Handle changes to
6877         cp_func_name.
6878         * cp-support.c (cp_func_name): Update header comment, update
6879         return type.
6880         * cp-support.h (cp_func_name): Update return type in declaration.
6881         * valops.c (find_overload_match): Move temp_func local to top
6882         level of function and change its type.  Use temp_func to hold and
6883         delete temporary string obtained from cp_func_name.
6884
6885 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6886
6887         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6888         gdb::char_vector, remove cleanup, and update uses of `msg`.
6889
6890 2019-01-03  Jim Wilson  <jimw@sifive.com>
6891
6892         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6893
6894 2019-01-02  Tom Tromey  <tom@tromey.com>
6895
6896         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6897         (tdesc_parse_xml): Remove cleanups.
6898         * target-descriptions.h (make_cleanup_free_target_description):
6899         Don't declare.
6900         (target_desc_deleter): New struct.
6901         (target_desc_up): New typedef.
6902         * target-descriptions.c (target_desc_deleter::operator()): Rename
6903         from free_target_description.
6904         (make_cleanup_free_target_description): Remove.
6905
6906 2019-01-02  Tom Tromey  <tom@tromey.com>
6907
6908         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6909         constructor, destructor.
6910         (linespec_parser): Remove typedef.
6911         (~linespec_parser): Rename from linespec_parser_delete.
6912         (linespec_lex_to_end, linespec_complete_label)
6913         (linespec_complete): Update.
6914         (decode_line_full): Remove cleanups.
6915         (decode_line_1): Update.
6916
6917 2019-01-02  Tom Tromey  <tom@tromey.com>
6918
6919         * python/python-internal.h (inferior_to_inferior_object): Change
6920         return type.
6921         * python/py-exitedevent.c (create_exited_event_object): Update.
6922         * python/py-inferior.c (inferior_to_inferior_object): Return
6923         gdbpy_ref.
6924         (python_new_inferior, python_inferior_deleted)
6925         (thread_to_thread_object, delete_thread_object)
6926         (build_inferior_list, gdbpy_selected_inferior): Update.
6927         * python/py-infthread.c (create_thread_object): Update.  Also fail
6928         if inferior_to_inferior_object fails.
6929
6930 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6931
6932         * inferior.h (class inferior) <displaced_step_state>: New field.
6933         * infrun.h (struct displaced_step_state): Move here from
6934         infrun.c.  Initialize fields, add constructor.
6935         <inf>: Remove field.
6936         <reset>: New method.
6937         * infrun.c (struct displaced_step_inferior_state): Move to
6938         infrun.h.
6939         (displaced_step_inferior_states): Remove.
6940         (get_displaced_stepping_state): Adust.
6941         (displaced_step_in_progress_any_inferior): Adjust.
6942         (displaced_step_in_progress_thread): Adjust.
6943         (displaced_step_in_progress): Adjust.
6944         (add_displaced_stepping_state): Remove.
6945         (get_displaced_step_closure_by_addr): Adjust.
6946         (remove_displaced_stepping_state): Remove.
6947         (infrun_inferior_exit): Call displaced_step_state.reset.
6948         (use_displaced_stepping): Don't check for NULL.
6949         (displaced_step_prepare_throw): Call
6950         get_displaced_stepping_state.
6951         (displaced_step_fixup): Don't check for NULL.
6952         (prepare_for_detach): Don't check for NULL.
6953
6954 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6955
6956         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6957          in case of call that did not complete.
6958
6959 2019-01-02  Andrey Utkin  <autkin@undo.io>
6960
6961         * symfile.c (find_separate_debug_file): Fix search of debug files for
6962         remote debuggee.
6963
6964 2019-01-02  Tom Tromey  <tom@tromey.com>
6965
6966         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6967         indentation.
6968         * python/py-frame.c (frapy_older): Remove cast.
6969         (frapy_newer): Likewise.
6970         * python/py-breakpoint.c (local_setattro): Remove cast.
6971         * python/py-arch.c (archpy_name): Remove local variable.
6972         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6973
6974 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6975
6976         * unittests/basic_string_view/element_access/char/empty.cc:
6977         Fix year range in copyright header.
6978
6979 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6980
6981         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6982         Delete.
6983         <operator==>: Update with for removed field.
6984         <hash>: Likewise.
6985         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6986         <isa_features>: ...this.
6987         <abi_features>: New field.
6988         (riscv_isa_flen): Update comment.
6989         (riscv_abi_xlen): New declaration.
6990         (riscv_abi_flen): New declaration.
6991         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6992         isa_features.
6993         (riscv_abi_xlen): New function.
6994         (riscv_isa_flen): Update to get answer from isa_features.
6995         (riscv_abi_flen): New function.
6996         (riscv_has_fp_abi): Update to get answer from abi_features.
6997         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6998         xlen and flen.
6999         (riscv_call_info) <xlen, flen>: Update comment.
7000         (riscv_call_arg_struct): Remove invalid assertions
7001         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7002         is removed.
7003         (riscv_gdbarch_init): Gather isa features and abi features
7004         separately, ensure both match on the gdbarch when reusing an old
7005         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7006         a target with 64-bit float hardware.
7007
7008 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7009
7010         * source.c (search_command_helper): Stop reverse search
7011         when line 1 has been searched.
7012
7013 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7014
7015         * record-full.c (record_full_base_target::close): Rewrite
7016         record_full_core_buf_list free logic.
7017
7018 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7019
7020         * break-catch-syscall.c (print_one_catch_syscall): xfree
7021         the last text.
7022
7023 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7024
7025         * top.c (print_gdb_version): Update Copyright year in version
7026         message.
7027
7028 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7029
7030         Update copyright year range in all GDB files.
7031
7032 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7033
7034         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7035
7036 For older changes see ChangeLog-2018.
7037 \f
7038 Local Variables:
7039 mode: change-log
7040 left-margin: 8
7041 fill-column: 74
7042 version-control: never
7043 coding: utf-8
7044 End:
7045