gdb/ChangeLog

   1 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * python/py-progspace.c (pspy_block_for_pc): Return None for all
   4         error paths.
   5
   6 2019-10-23  Tom Tromey  <tom@tromey.com>
   7
   8         * arc-tdep.c: Remove ".." from include.
   9         * frv-tdep.c: Remove ".." from include.
  10         * lm32-tdep.c: Remove ".." from include.
  11         * microblaze-tdep.c: Remove ".." from include.
  12         * or1k-tdep.h: Remove ".." from include.
  13         * s12z-tdep.c: Remove ".." from include.
  14         * Makefile.in (OPCODES_CFLAGS): Add comment.
  15         (TOP_CFLAGS): New variable.
  16         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
  17
  18 2019-10-23  Tom Tromey  <tom@tromey.com>
  19
  20         * Makefile.in (READLINE_DIR): Update.
  21
  22 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  23
  24         * infcall.c (call_function_by_hand_dummy): Fix the function
  25         comment.  And extract out a code section into...
  26         (reserve_stack_space): ...this new function.
  27
  28 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  29
  30         * infcall.c (value_arg_coerce): Remove an unused parameter.
  31         (call_function_by_hand_dummy): Update the call to
  32         'value_arg_coerce'.
  33
  34 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  35
  36         * infcall.c (call_function_by_hand_dummy): Refactor.
  37
  38 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  39
  40         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
  41
  42 2019-10-23  Tom Tromey  <tom@tromey.com>
  43
  44         * configure: Rebuild.
  45         * configure.ac: Don't check for sigprocmask.
  46         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
  47
  48 2019-10-23  Tom Tromey  <tom@tromey.com>
  49
  50         * configure: Rebuild.
  51         * acinclude.m4: Use m4_include, not sinclude.
  52
  53 2019-10-23  Tom de Vries  <tdevries@suse.de>
  54
  55         PR breakpoints/24687
  56         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
  57
  58 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  59
  60         * symtab.c (struct demangled_name_entry) <language>: Change from
  61         bitfield to regular variable.
  62
  63 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  64
  65         * symtab.c (struct demangled_name_entry): Add a constructor.
  66         (free_demangled_name_entry): New function to call the destructor
  67         for demangled_name_entry.
  68         (create_demangled_names_hash): Pass free_demangled_name_entry to
  69         htab_create_alloc.
  70         (symbol_set_names): Call placement new for demangled_name_entry.
  71         * utils.c: No longer include xxhash.h here, now that fast_hash
  72         is inlined in the header.
  73         * utils.h: Instead, include it here.
  74
  75 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  76
  77         * Makefile.in: Link with libxxhash.
  78         * config.in: Regenerate.
  79         * configure: Regenerate.
  80         * configure.ac: Search for libxxhash.
  81         * utils.c (fast_hash): Use xxhash if present.
  82
  83 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  84
  85         * utils.h (fast_hash): New function.
  86         * symtab.c (hash_demangled_name_entry): Call new function
  87         fast_hash.
  88
  89 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  90
  91         * symtab.c (struct demangled_name_entry): Change type of mangled
  92         to gdb::string_view. Also adds a constructor that takes the
  93         mangled name.
  94         (hash_demangled_name_entry): Update.
  95         (eq_demangled_name_entry): Update.
  96         (free_demangled_name_entry): New function to call the destructor
  97         now that this is not a POD anymore.
  98         (create_demangled_names_hash): Pass free_demangled_name_entry to
  99         htab_create_alloc.
 100         (symbol_set_names): Update.
 101
 102 2019-10-21  Ali Tamur  <tamu@google.com>
 103
 104         * dwarf2read.c (dir_index): Change type.
 105         (file_name_index): Likewise.
 106         (line_header::include_dir_at): Change comment and implementation on
 107         whether it is DWARF 5.
 108         (line_header::is_valid_file_index): New function.
 109         (line_header::file_name_at): Change comment and implementation on
 110         whether it is DWARF 5.
 111         (line_header::file_names): Change to private field renamed as
 112         m_file_names and introduce a new accessor method.
 113         (line_header::file_names_size): New method.
 114         (line_header::include_dirs): Change to private field and rename as
 115         m_include_dirs.
 116         (dw2_get_file_names_reader): Define local var at a smaller scope and
 117         reflect API change.
 118         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 119         (process_structure_scope): Likewise.
 120         (line_header::add_include_dir): Change message and reflect renaming.
 121         (line_header::add_file_name): Likewise.
 122         (read_formatted_entries): Handle DW_FORM_data16.
 123         (dwarf_decode_line_header): Fix line header length calculation.
 124         (psymtab_include_file_name): Change comment and API.
 125         (lnp_state_machine::m_file): Update comment and reflect type change.
 126         (lnp_state_machine::record_line): Reflect type change.
 127         (dwarf_decode_lines): Reflect API change.
 128         (file_file_name): Likewise.
 129         (file_full_name): Likewise.
 130
 131 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 132
 133         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 134
 135 2019-10-21  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 138
 139 2019-10-21  Tom Tromey  <tom@tromey.com>
 140
 141         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 142         NM_H.   Use AC_CONFIG_LINKS.
 143         * configure: Rebuild.
 144         * Makefile.in (NM_H): New variable.
 145         (generated_files): Add NM_H.  Remove gcore.
 146         (nm.h, stamp-nmh): New targets.
 147
 148 2019-10-20  Tom Tromey  <tom@tromey.com>
 149
 150         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 151         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 152         obsolete comment.
 153         (put_objfile_before): Now static.
 154
 155 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 156
 157         * gdbsupport/common-utils.h (startswith): Change return type to
 158         bool.
 159
 160 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 161
 162         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 163         * breakpoint.c (bp_locations_compare): Rename to...
 164         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 165         (update_global_location_list): Use std::sort instead of qsort.
 166         * buildsym.c (compare_line_numbers): Rename to...
 167         (lte_is_less_than): ...this, and change to std::sort semantics.
 168         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 169         instead of qsort.
 170         * disasm.c (compare_lines): Rename to...
 171         (line_is_less_than): ...this, and change to std::sort semantics.
 172         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 173         of qsort.
 174         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 175         (fde_is_less_than): ...this, and change to std::sort semantics.
 176         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 177         * mdebugread.c (compare_blocks):
 178         (block_is_less_than): ...this, and change to std::sort semantics.
 179         (sort_blocks): Call std::sort instead of qsort.
 180         * objfiles.c (qsort_cmp): Rename to...
 181         (sort_cmp): ...this, and change to std::sort semantics.
 182         (update_section_map): Call std::sort instead of qsort.
 183         * remote.c (compare_pnums): Remove.
 184         (map_regcache_remote_table): Call std::sort instead of qsort.
 185         * utils.c (compare_positive_ints): Remove.
 186         * utils.h (compare_positive_ints): Remove.
 187         * xcoffread.c (compare_lte): Remove.
 188         (arrange_linetable): Call std::sort instead of qsort.
 189
 190 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 191
 192         * symfile.c (init_entry_point_info): Fix typo.
 193         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 194
 195 2019-10-18  Tom de Vries  <tdevries@suse.de>
 196
 197         * aarch64-tdep.c: Fix typos in comments.
 198         * ada-lang.c: Same.
 199         * ada-tasks.c: Same.
 200         * alpha-tdep.c: Same.
 201         * alpha-tdep.h: Same.
 202         * amd64-nat.c: Same.
 203         * amd64-windows-tdep.c: Same.
 204         * arc-tdep.c: Same.
 205         * arc-tdep.h: Same.
 206         * arch-utils.c: Same.
 207         * arm-nbsd-tdep.c: Same.
 208         * arm-tdep.c: Same.
 209         * ax-gdb.c: Same.
 210         * blockframe.c: Same.
 211         * btrace.c: Same.
 212         * c-varobj.c: Same.
 213         * coff-pe-read.c: Same.
 214         * coffread.c: Same.
 215         * cris-tdep.c: Same.
 216         * darwin-nat.c: Same.
 217         * dbxread.c: Same.
 218         * dcache.c: Same.
 219         * disasm.c: Same.
 220         * dtrace-probe.c: Same.
 221         * dwarf-index-write.c: Same.
 222         * dwarf2-frame-tailcall.c: Same.
 223         * dwarf2-frame.c: Same.
 224         * dwarf2read.c: Same.
 225         * eval.c: Same.
 226         * exceptions.c: Same.
 227         * fbsd-tdep.c: Same.
 228         * findvar.c: Same.
 229         * frame.c: Same.
 230         * frv-tdep.c: Same.
 231         * gnu-v3-abi.c: Same.
 232         * go32-nat.c: Same.
 233         * h8300-tdep.c: Same.
 234         * hppa-tdep.c: Same.
 235         * i386-linux-tdep.c: Same.
 236         * i386-tdep.c: Same.
 237         * ia64-libunwind-tdep.c: Same.
 238         * ia64-tdep.c: Same.
 239         * infcmd.c: Same.
 240         * infrun.c: Same.
 241         * linespec.c: Same.
 242         * linux-nat.c: Same.
 243         * linux-thread-db.c: Same.
 244         * machoread.c: Same.
 245         * mdebugread.c: Same.
 246         * mep-tdep.c: Same.
 247         * mn10300-tdep.c: Same.
 248         * namespace.c: Same.
 249         * objfiles.c: Same.
 250         * opencl-lang.c: Same.
 251         * or1k-tdep.c: Same.
 252         * osabi.c: Same.
 253         * ppc-linux-nat.c: Same.
 254         * ppc-linux-tdep.c: Same.
 255         * ppc-sysv-tdep.c: Same.
 256         * printcmd.c: Same.
 257         * procfs.c: Same.
 258         * record-btrace.c: Same.
 259         * record-full.c: Same.
 260         * remote-fileio.c: Same.
 261         * remote.c: Same.
 262         * rs6000-tdep.c: Same.
 263         * s12z-tdep.c: Same.
 264         * score-tdep.c: Same.
 265         * ser-base.c: Same.
 266         * ser-go32.c: Same.
 267         * skip.c: Same.
 268         * sol-thread.c: Same.
 269         * solib-svr4.c: Same.
 270         * solib.c: Same.
 271         * source.c: Same.
 272         * sparc-nat.c: Same.
 273         * sparc-sol2-tdep.c: Same.
 274         * sparc-tdep.c: Same.
 275         * sparc64-tdep.c: Same.
 276         * stabsread.c: Same.
 277         * stack.c: Same.
 278         * symfile.c: Same.
 279         * symtab.c: Same.
 280         * target-descriptions.c: Same.
 281         * target-float.c: Same.
 282         * thread.c: Same.
 283         * utils.c: Same.
 284         * valops.c: Same.
 285         * valprint.c: Same.
 286         * value.c: Same.
 287         * varobj.c: Same.
 288         * windows-nat.c: Same.
 289         * xcoffread.c: Same.
 290         * xstormy16-tdep.c: Same.
 291         * xtensa-tdep.c: Same.
 292
 293 2019-10-17  Tom Tromey  <tromey@adacore.com>
 294
 295         * configure: Rebuild.
 296         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 297         in AC_CONFIG_FILES invocation.
 298         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 299         new-style config.status invocation.
 300
 301 2019-10-17  Tom de Vries  <tdevries@suse.de>
 302
 303         * arm-nbsd-nat.c: Fix typos in comments.
 304         * arm-tdep.c: Same.
 305         * darwin-nat-info.c: Same.
 306         * dwarf2read.c: Same.
 307         * elfread.c: Same.
 308         * event-top.c: Same.
 309         * findvar.c: Same.
 310         * gdbtypes.c: Same.
 311         * hppa-tdep.c: Same.
 312         * i386-tdep.c: Same.
 313         * jit.c: Same.
 314         * main.c: Same.
 315         * mdebugread.c: Same.
 316         * moxie-tdep.c: Same.
 317         * nto-procfs.c: Same.
 318         * osabi.c: Same.
 319         * ppc-linux-tdep.c: Same.
 320         * remote.c: Same.
 321         * riscv-tdep.c: Same.
 322         * s390-tdep.c: Same.
 323         * sh-tdep.c: Same.
 324         * sparc-linux-tdep.c: Same.
 325         * sparc-nat.c: Same.
 326         * stack.c: Same.
 327         * target-descriptions.c: Same.
 328         * top.c: Same.
 329         * varobj.c: Same.
 330
 331 2019-10-16  Tom Tromey  <tom@tromey.com>
 332
 333         * objfiles.h (struct objfile) <original_name>: Now const.
 334
 335 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 336
 337         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 338         pass on to sigsetjmp's second argument.
 339         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 340
 341 2019-10-16  Keith Seitz  <keiths@redhat.com>
 342
 343         PR gdb/23567
 344         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 345         sections whose size is greater than the file size.
 346
 347 2019-10-16  Jim Wilson  <jimw@sifive.com>
 348
 349         * riscv-tdep.c (riscv_gcc_target_options): New.
 350         (riscv_gnu_triplet_regexp): New.
 351         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 352         set_gdbarch_gnu_triplet_regexp.
 353
 354 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 355
 356         * Makefile.in: Add xml-builtin.h.
 357         * features/feature_to_c.sh: Add an include for xml-builtin.h
 358         to ensure that the compiler checks that the types match.
 359         * xml-builtin.h: New file.
 360         * xml-support.c (fetch_xml_builtin): Add missing const.
 361         * xml-support.h: Remove declaration of xml_builtins.
 362
 363 2019-10-16  Tom de Vries  <tdevries@suse.de>
 364
 365         PR tdep/25096
 366         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 367         (amd64_classify_aggregate): ... here.
 368         (amd64_classify_aggregate_field): Handled fiels of nested structs
 369         recursively.
 370
 371 2019-10-16  Tom de Vries  <tdevries@suse.de>
 372
 373         PR tdep/24104
 374         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 375         that handles 'theclass'.
 376
 377 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 378
 379         * linespec.c (decode_digits_ordinary): Update comment.
 380         * make-target-delegates: No longer need to handle VEC case.
 381         * memrange.c (normalize_mem_ranges): Update comment.
 382         * namespace.c (add_using_directive): Update comment.
 383         * objc-lang.c (uniquify_strings): Update comment.
 384         * ppc-linux-nat.c (struct thread_points): Update comment.
 385         * probe.h (find_probes_in_objfile): Update comment.
 386         * target.h (enum flash_preserve_mode): Update comment.
 387         * varobj.c (varobj_restrict_range): Update comment.
 388         * varobj.h (varobj_list_children): Update comment.
 389
 390 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * Makefile.in: Remove references to vec.h and vec.c.
 393         * aarch64-tdep.c: No longer include vec.h.
 394         * ada-lang.c: Likewise.
 395         * ada-lang.h: Likewise.
 396         * arm-tdep.c: Likewise.
 397         * ax.h: Likewise.
 398         * breakpoint.h: Likewise.
 399         * charset.c: Likewise.
 400         * cp-support.h: Likewise.
 401         * dtrace-probe.c: Likewise.
 402         * dwarf2read.c: Likewise.
 403         * extension.h: Likewise.
 404         * gdb_bfd.c: Likewise.
 405         * gdbsupport/gdb_vecs.h: Likewise.
 406         * gdbsupport/vec.c: Remove.
 407         * gdbsupport/vec.h: Remove.
 408         * gdbthread.h: Likewise.
 409         * guile/scm-type.c: Likewise.
 410         * inline-frame.c: Likewise.
 411         * machoread.c: Likewise.
 412         * memattr.c: Likewise.
 413         * memrange.h: Likewise.
 414         * namespace.h: Likewise.
 415         * nat/linux-btrace.h: Likewise.
 416         * osdata.c: Likewise.
 417         * parser-defs.h: Likewise.
 418         * progspace.h: Likewise.
 419         * python/py-type.c: Likewise.
 420         * record-btrace.c: Likewise.
 421         * rust-exp.y: Likewise.
 422         * solib-target.c: Likewise.
 423         * stap-probe.c: Likewise.
 424         * target-descriptions.c: Likewise.
 425         * target-memory.c: Likewise.
 426         * target.h: Likewise.
 427         * varobj.c: Likewise.
 428         * varobj.h: Likewise.
 429         * xml-support.h: Likewise.
 430
 431 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 434         Update for new std::vector based implementation.
 435         (process_psymtab_comp_unit_reader): Likewise.
 436         (scan_partial_symbols): Likewise.
 437         (recursively_compute_inclusions): Likewise.
 438         (compute_compunit_symtab_includes): Likewise.
 439         (process_imported_unit_die): Likewise.
 440         (queue_and_load_dwo_tu): Likewise.
 441         (follow_die_sig_1): Likewise.
 442         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 443         (typedef dwarf2_per_cu_ptr): Remove.
 444         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 445         function.
 446         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 447         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 448         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 449         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 450         std::vector.
 451
 452 2019-10-15  Tom Tromey  <tromey@adacore.com>
 453
 454         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 455         TID.
 456
 457 2019-10-15  Tom Tromey  <tromey@adacore.com>
 458
 459         * windows-nat.c (windows_nat_target::fetch_registers)
 460         (windows_nat_target::store_registers): Rename "pid" to "tid".
 461
 462 2019-10-15  Tom Tromey  <tromey@adacore.com>
 463
 464         * gdbarch.h, gdbarch.c: Rebuild.
 465         * gdbarch.sh (gcc_target_options): Change return type to
 466         std::string.
 467         * compile/compile.c (get_args): Update.
 468         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 469         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 470         std::string.
 471         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 472         std::string.
 473         * arch-utils.c (default_gcc_target_options): Return std::string.
 474         * arch-utils.h (default_gcc_target_options): Return std::string.
 475         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 476
 477 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 478
 479         * breakpoint.c (breakpoint_chain): Make static.
 480         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 481         of accessing breakpoint_chain.
 482
 483 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 484
 485         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 486         to a gdb::function_view and return value to bool.
 487         * breakpoint.h (iterate_over_breakpoints): Likewise.
 488         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 489         (pop_dummy_frame): Update.
 490         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 491         (gdbscm_breakpoints): Update.
 492         * python/py-breakpoint.c (build_bp_list): Update.
 493         (gdbpy_breakpoints): Update.
 494         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 495         Update.
 496         (bpfinishpy_handle_stop): Update.
 497         (bpfinishpy_handle_exit): Update.
 498         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 499         (svr4_update_solib_event_breakpoints): Update.
 500
 501 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 502
 503         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 504         when unwrapping single-field structs.
 505
 506 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 507
 508         * dwarf2read.c: Remove includes.
 509
 510 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 511
 512         * ui-out.c (ui_out::call_do_message): Silence
 513         -Wformat-nonliteral warning.
 514
 515 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 516
 517         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 518         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 519         include: readline/tilde.h.
 520
 521 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 522
 523         * remote.c (remote_target::get_trace_status): Remove declaration of
 524         trace_regblock_size.
 525
 526 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 527
 528         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 529         (show_user): Remove declaration of cmdlist.
 530         * cli/cli-cmds.h (max_user_call_depth): Declare.
 531         * cli/cli-script.c (execute_user_command): Remove declaration
 532         of max_user_call_depth.
 533
 534 2019-10-11  Jim Wilson  <jimw@sifive.com>
 535
 536         * gdbsupport/print-utils.h (pulongest): Fix comment.
 537         (plongest): Likewise.
 538         (phex): Add missing comment, mention leading zeros.
 539         (phex_nz): Add mention of no leading zeros to comment.
 540
 541         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 542         plongest instead of unsigned long long cast.
 543
 544 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 545
 546         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 547         for external_editor_command and gdbtk_test.
 548
 549 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 550
 551         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 552         * varobj.c (varobjdebug): Move comment to...
 553         * varobj.h (varobjdebug): ...here, and declare.
 554
 555 2019-10-09  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 558         erase_data_content.
 559
 560 2019-10-09  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 563         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 564         * tui/tui-command.c (tui_cmd_window::resize)
 565         (tui_refresh_cmd_win): Update.
 566         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 567         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 568         * tui/tui-data.c (~tui_gen_win_info): Remove.
 569         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 570         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 571         (tui_redisplay_readline, tui_mld_flush)
 572         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 573         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 574         (tui_data_window::erase_data_content)
 575         (tui_data_item_window::rerender)
 576         (tui_data_item_window::refresh_window): Update.
 577         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 578         (box_win, tui_gen_win_info::make_window)
 579         (tui_gen_win_info::make_visible): Update.
 580         (tui_delete_win): Remove.
 581         * tui/tui-winsource.c
 582         (tui_source_window_base::do_erase_source_content): Update.
 583         (tui_show_source_line, tui_source_window_base::update_tab_width)
 584         (tui_source_window_base::update_exec_info): Update.
 585         * tui/tui-data.h (struct curses_deleter): New.
 586         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 587         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 588
 589 2019-10-09  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 592
 593 2019-10-09  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 596         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 597
 598 2019-10-09  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 601         window height directly.
 602         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 603         declare.
 604         * tui/tui-layout.c (tui_default_win_height): Remove.
 605         (tui_default_win_viewport_height): Remove.
 606
 607 2019-10-09  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui.h: Remove comments.
 610
 611 2019-10-09  Tom de Vries  <tdevries@suse.de>
 612
 613         * python/lib/gdb/printer/bound_registers.py: Use
 614         '^builtin_type_bound128' as regexp argument for
 615         add_builtin_pretty_printer.
 616
 617 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 618
 619         * guile/guile.c (guile_extension_script_ops): Remove forward
 620         declaration and mark as static.
 621         (guile_script_ops): Likewise.
 622         (extension_language_guile): Move further down in the file so
 623         it can reference the definitions for guile_{extension_,}script_ops.
 624
 625 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 626
 627         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 628         except SORTL, DFLTCC, and KDSA.
 629
 630 2019-10-08  Tom Tromey  <tromey@adacore.com>
 631
 632         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 633         (struct safe_symbol_file_add_args): Remove.
 634
 635 2019-10-08  Tom Tromey  <tromey@adacore.com>
 636
 637         * windows-nat.c: Don't include buildsym-legacy.h.
 638
 639 2019-10-08  Tom Tromey  <tromey@adacore.com>
 640
 641         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 642
 643 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 644
 645         * gdbtypes.c (overload_debug): Move comment to header.
 646         * gdbtypes.h (overload_debug): Declare.
 647         * valops.c: Remove declaration of overload_debug, instead
 648         include gdbtypes.h.
 649
 650 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 651
 652         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 653         through _().
 654         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 655         move comment...
 656         * language.h (lang_frame_mismatch_warn): ... here. Also add
 657         declaration.
 658         * top.c (lang_frame_mismatch_warn): Remove declaration.
 659         (check_frame_language_change): Pass lang_frame_mismatch_warn
 660         through _().
 661
 662 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 663
 664         * c-lang.h (vtbl_ptr_name): Declare.
 665         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 666         it from the header.
 667         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 668
 669 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 670
 671         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 672         gdb_static_assert.
 673
 674 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 675
 676         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 677         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 678         * ctfread.c: New file.
 679         * ctfread.h: New file.
 680         * elfread.c: Include ctfread.h.
 681         (struct elfinfo text_p): New member ctfsect.
 682         (elf_locate_sections): Mark CTF section.
 683         (elf_symfile_read): Call elfctf_build_psymtabs.
 684         * Makefile.in (LIBCTF): Add.
 685         (CLIBS): Use it.
 686         (CDEPS): Likewise.
 687         (DIST): Add ctfread.c.
 688
 689 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * ctfread.c (struct nextfield): Renamed to ...
 692         (struct ctf_nextfield): ... this.
 693         (struct field_info): Renamed to ...
 694         (strut ctf_field_info): ... this.
 695         (attach_fields_to_type): Update for renamed structures.
 696         (ctf_add_member_cb): Likewise.
 697         (ctf_add_enum_member_cb): Likewise.
 698         (process_struct_members): Likewise.
 699         (process_enum_type): Likewise.
 700
 701 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 702
 703         * tracectf.h: Rename, was ctf.h.
 704         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 705         * tracefile.c: Likewise.
 706         * tracepoint.c: Remove unused include ctf.h.
 707         * mi/mi-main.c: Likewise.
 708         * Makefile.in Replace ctf.c with tracectf.c.
 709
 710 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 711
 712         * version.in: Change version number to "9.0.50.DATE-git".
 713
 714 2019-10-03  Tom Tromey  <tom@tromey.com>
 715
 716         PR rust/24976:
 717         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 718
 719 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 722         cp_search_name_hash.
 723         * NEWS: Add entry about nested function support.
 724
 725 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 726             Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 729         for nested static variables when searchin VAR_DOMAIN.
 730         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 731         global scope, update comment.
 732         (add_partial_subprogram): Call add_partial_subprogram recursively
 733         for nested subroutines when processinng Fortran.
 734         (load_partial_dies): Process the child entities of a subprogram
 735         when processing Fortran.
 736         (partial_die_parent_scope): Handle building scope
 737         for Fortran nested functions.
 738         (process_die): Record that nested functions have a scope.
 739         (new_symbol): Always record Fortran subprograms on the global
 740         symbol list.
 741         (determine_prefix): How to build the prefix for Fortran
 742         subprograms.
 743
 744 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 747         have just sent the thread a SIGSTOP and are waiting for it to
 748         arrive.
 749
 750 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * btrace.c (btrace_add_pc): Remove whitespace before the template
 753         parameter in 'std::vector <...>'.
 754         (parse_xml_btrace_block): Likewise.
 755         (btrace_maint_decode_pt): Likewise.
 756         (btrace_maint_update_packets): Likewise.
 757         (btrace_maint_print_packets): Likewise.
 758         * btrace.h (struct btrace_maint_info): Likewise.
 759         * dwarf2read.c (struct type_unit_group): Likewise.
 760         (build_type_psymtabs_reader): Likewise.
 761         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 762         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 763         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 764
 765 2019-10-03  Tom de Vries  <tdevries@suse.de>
 766
 767         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 768         the first line of the help text for set/show style metadata.
 769
 770 2019-10-02  Tom Tromey  <tromey@adacore.com>
 771
 772         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 773         * gdbsupport/common-inferior.c: New file.
 774         * infcmd.c (startup_with_shell): Don't define.
 775         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 776         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 777         * inferior.h (startup_with_shell): Don't declare.
 778
 779 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 780
 781         * gdbsupport/gdb_assert.h: Include errors.h.
 782         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 783
 784 2019-10-02  Tom Tromey  <tromey@adacore.com>
 785
 786         * NEWS: Add $_ada_exception entry.
 787         * ada-lang.c (struct ada_catchpoint): Add constructor.
 788         <m_kind>: New member.
 789         (allocate_location_exception, re_set_exception): Remove
 790         "ex" parameter.
 791         (should_stop_exception): Compute $_ada_exception.
 792         (check_status_exception, print_it_exception)
 793         (print_one_exception, print_mention_exception): Remove
 794         "ex" parameter.
 795         (allocate_location_catch_exception, re_set_catch_exception)
 796         (check_status_exception, print_it_catch_exception)
 797         (print_one_catch_exception, print_mention_catch_exception)
 798         (print_recreate_catch_exception)
 799         (allocate_location_catch_exception_unhandled)
 800         (re_set_catch_exception_unhandled)
 801         (check_status_exception, print_it_catch_exception_unhandled)
 802         (print_one_catch_exception_unhandled)
 803         (print_mention_catch_exception_unhandled)
 804         (print_recreate_catch_exception_unhandled)
 805         (allocate_location_catch_assert, re_set_catch_assert)
 806         (check_status_assert, print_it_catch_assert)
 807         (print_one_catch_assert, print_mention_catch_assert)
 808         (print_recreate_catch_assert)
 809         (allocate_location_catch_handlers, re_set_catch_handlers)
 810         (check_status_handlers, print_it_catch_handlers)
 811         (print_one_catch_handlers, print_mention_catch_handlers)
 812         (print_recreate_catch_handlers): Remove.
 813         (create_ada_exception_catchpoint): Update.
 814         (initialize_ada_catchpoint_ops): Update.
 815
 816 2019-10-02  Tom Tromey  <tromey@adacore.com>
 817
 818         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 819         (create_excep_cond_exprs): Simplify exception string computation.
 820         (ada_exception_catchpoint_cond_string): Likewise.
 821
 822 2019-10-02  Tom Tromey  <tromey@adacore.com>
 823
 824         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 825         * ada-lang.c (lesseq_defined_than): Handle
 826         LOC_STATIC.
 827         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 828         parameter.
 829         (dwarf2_has_info): Likewise.
 830         (new_symbol): Set maybe_copied on symbol when
 831         appropriate.
 832         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 833         parameter.
 834         <can_copy>: New member.
 835         * elfread.c (record_minimal_symbol): Set maybe_copied
 836         on symbol when appropriate.
 837         (elf_symfile_read): Update call to dwarf2_has_info.
 838         * minsyms.c (lookup_minimal_symbol_linkage): New
 839         function.
 840         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 841         * symtab.c (get_symbol_address, get_msymbol_address):
 842         New functions.
 843         * symtab.h (get_symbol_address, get_msymbol_address):
 844         Declare.
 845         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 846         maybe_copied.
 847         (struct symbol, struct minimal_symbol) <maybe_copied>:
 848         New member.
 849
 850 2019-10-02  Tom Tromey  <tromey@adacore.com>
 851
 852         * source.c (struct current_source_location): New.
 853         (current_source_key): New global.
 854         (current_source_symtab, current_source_line)
 855         (current_source_pspace): Remove.
 856         (get_source_location): New function.
 857         (get_current_source_symtab_and_line)
 858         (set_default_source_symtab_and_line)
 859         (set_current_source_symtab_and_line)
 860         (clear_current_source_symtab_and_line, select_source_symtab)
 861         (info_source_command, print_source_lines_base)
 862         (info_line_command, search_command_helper, _initialize_source):
 863         Update.
 864
 865 2019-10-02  Tom Tromey  <tromey@adacore.com>
 866
 867         * source.c (select_source_symtab): Don't call
 868         decode_line_with_current_source.
 869
 870 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * symtab.c (lookup_global_symbol): Search global block.
 873
 874 2019-10-02  Tom Tromey  <tromey@adacore.com>
 875
 876         * coffread.c (process_coff_symbol): Update.
 877         * dwarf2read.c (var_decode_location, new_symbol): Update.
 878         * mdebugread.c (parse_symbol): Update.
 879         * objfiles.c (relocate_one_symbol): Update.
 880         * stabsread.c (define_symbol, fix_common_block)
 881         (scan_file_globals): Update.
 882         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 883         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 884         * xcoffread.c (process_xcoff_symbol): Update.
 885
 886 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 887
 888         * MAINTAINERS: Update my email address.
 889
 890 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 893         std::vector.
 894         (build_type_psymtabs_reader): Update for std::vector.
 895         (build_type_psymtab_dependencies): Likewise.
 896         * dwarf2read.h: Remove use of DEF_VEC_P.
 897         (typedef sig_type_ptr): Delete.
 898
 899 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 902         to std::vector.
 903         (btrace_maint_decode_pt): Likewise, and move allocation of the
 904         vector outside of the loop.
 905         (btrace_maint_update_packets): Update to handle change from VEC to
 906         std::vector.
 907         (btrace_maint_print_packets): Likewise.
 908         (maint_info_btrace_cmd): Likewise.
 909         * btrace.h: Remove use of DEF_VEC_O.
 910         (typedef btrace_pt_packet_s): Delete.
 911         (struct btrace_maint_info) <packets>: Change fromm VEC to
 912         std::vector.
 913         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 914
 915 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 918         make accesses into the vector constant references.
 919         (btrace_add_pc): Update for std::vector.
 920         (btrace_stitch_bts): Likewise.
 921         (parse_xml_btrace_block): Likewise.
 922         (btrace_maint_update_packets): Likewise.
 923         (btrace_maint_print_packets): Likewise.
 924         (maint_info_btrace_cmd): Likewise.
 925         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 926         std::vector.
 927         (btrace_data::empty): Likewise.
 928         (btrace_data_append): Likewise.
 929         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 930         (typedef btrace_block_s): Delete.
 931         (struct btrace_block): Add constructor.
 932         (struct btrace_data_bts) <blocks>: Change to std::vector.
 933         * nat/linux-btrace.c (perf_event_read_bts): Update for
 934         std::vector.
 935         (linux_read_bts): Likewise.
 936
 937 2019-10-01  Tom Tromey  <tom@tromey.com>
 938
 939         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 940
 941 2019-10-01  Tom Tromey  <tom@tromey.com>
 942
 943         * stack.c (print_frame, info_frame_command_core): Use
 944         styled_string.
 945         * linux-thread-db.c (try_thread_db_load_1)
 946         (try_thread_db_load_from_pdir_1): Use styled_string.
 947         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 948         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 949         (maybe_print_unsupported_script_warning)
 950         (maybe_print_script_not_found_warning): Use styled_string.
 951         * ada-lang.c (user_select_syms): Use styled_string.
 952
 953 2019-10-01  Tom Tromey  <tom@tromey.com>
 954
 955         * p-lang.c (pascal_printstr): Use metadata style.
 956         * value.c (show_convenience): Use metadata style.
 957         * valprint.c (valprint_check_validity, val_print_optimized_out)
 958         (val_print_not_saved, val_print_unavailable)
 959         (val_print_invalid_address, generic_val_print, val_print)
 960         (value_check_printable, val_print_array_elements): Use metadata
 961         style.
 962         * ui-out.h (class ui_out) <field_fmt>: New overload.
 963         <do_field_fmt>: Add style parameter.
 964         * ui-out.c (ui_out::field_fmt): New overload.
 965         * typeprint.c (type_print_unknown_return_type)
 966         (val_print_not_allocated, val_print_not_associated): Use metadata
 967         style.
 968         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 969         parameter.
 970         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 971         * tracepoint.c (tvariables_info_1): Use metadata style.
 972         * stack.c (print_frame_arg, print_frame_info, print_frame)
 973         (info_frame_command_core): Use metadata style.
 974         * skip.c (info_skip_command): Use metadata style.
 975         * rust-lang.c (rust_print_enum): Use metadata style.
 976         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 977         metadata style.
 978         * python/py-framefilter.c (py_print_single_arg): Use metadata
 979         style.
 980         * printcmd.c (do_one_display, print_variable_and_value): Use
 981         metadata style.
 982         * p-valprint.c (pascal_val_print)
 983         (pascal_object_print_value_fields): Use metadata style.
 984         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 985         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 986         parameter.
 987         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 988         * m2-valprint.c (m2_print_long_set): Use metadata style.
 989         * m2-typeprint.c (m2_print_type): Use metadata style.
 990         * infcmd.c (print_return_value_1): Use metadata style.
 991         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 992         * f-valprint.c (info_common_command_for_block): Use metadata
 993         style.
 994         * f-typeprint.c (f_type_print_base): Use metadata style.
 995         * expprint.c (print_subexp_standard): Use metadata style.
 996         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 997         * cli/cli-style.h (class cli_style_option): Add constructor.
 998         (metadata_style): Declare.
 999         * cli/cli-style.c (metadata_style): New global.
1000         (_initialize_cli_style): Register metadata style.
1001         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1002         parameter.
1003         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1004         * c-typeprint.c (c_type_print_base_struct_union)
1005         (c_type_print_base_1): Use metadata style.
1006         * breakpoint.c (watchpoint_value_print)
1007         (print_one_breakpoint_location): Use metadata style.
1008         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1009         style.
1010         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1011         style.
1012         * ada-valprint.c (val_print_packed_array_elements, printstr)
1013         (print_field_values, ada_val_print_ref, ada_val_print): Use
1014         metadata style.
1015         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1016         style.
1017         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1018         style.
1019         * ada-lang.c (user_select_syms): Use metadata style.
1020
1021 2019-10-01  Tom Tromey  <tom@tromey.com>
1022
1023         * cli/cli-cmds.c (pwd_command): Style output.
1024
1025 2019-10-01  Pedro Alves  <palves@redhat.com>
1026             Tom Tromey  <tom@tromey.com>
1027
1028         * symtab.c (print_symbol_info): Use %ps.
1029         (print_msymbol_info): Use %ps.
1030         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1031         * printcmd.c (print_variable_and_value): Use %ps.
1032         * macrocmd.c (show_pp_source_pos): Use %ps.
1033         * infrun.c (print_exited_reason): Use ui_out::message.
1034         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1035         (describe_other_breakpoints): Use ui_out::message and new
1036         formats.
1037         (say_where): Use new formats.
1038         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1039         and new formats.
1040
1041 2019-10-01  Pedro Alves  <palves@redhat.com>
1042             Tom Tromey  <tom@tromey.com>
1043
1044         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1045         (test_gdb_formats): New function.
1046         (run_tests): Call it.
1047         (test_format_specifier): Update.
1048         * utils.h (fputs_filtered): Update comment.
1049         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1050         (fputs_styled_unfiltered): Declare.
1051         * utils.c (fputs_styled_unfiltered): New function.
1052         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1053         (vfprintf_filtered): Update.
1054         (vfprintf_unfiltered, vprintf_filtered): Update.
1055         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1056         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1057         disallow_ui_out_field>: New constants.
1058         (enum class field_kind): New.
1059         (struct base_field_s, struct signed_field_s): New.
1060         (signed_field): New function.
1061         (struct string_field_s): New.
1062         (string_field): New function.
1063         (struct styled_string_s): New.
1064         (styled_string): New function.
1065         (class ui_out) <message>: Add comment.
1066         <vmessage, call_do_message>: New methods.
1067         <do_message>: Add style parameter.
1068         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1069         methods.
1070         (ui_out::message): Rewrite.
1071         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1072         parameter.
1073         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1074         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1075         gdb_extensions parameter.
1076         (class format_piece): Add parameter to constructor.
1077         (n_int_args): New field.
1078         * gdbsupport/format.c (format_pieces::format_pieces): Add
1079         gdb_extensions parameter.  Handle '*'.
1080         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1081         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1082         vfprintf_styled_no_gdbfmt.
1083         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1084         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1085         unfiltered output.
1086         * ui-style.h (struct ui_file_style) <ptr>: New method.
1087
1088 2019-10-01  Tom Tromey  <tom@tromey.com>
1089
1090         * unittests/format_pieces-selftests.c: Update.  Add final format.
1091         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1092         empty literal pieces.
1093
1094 2019-10-01  Tom Tromey  <tom@tromey.com>
1095
1096         * ui-out.h (enum class ui_out_style_kind): Remove.
1097         (class ui_out) <field_string, field_stsream, do_field_string>:
1098         Change type of "style".
1099         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1100         (ui_out::field_string): Update.
1101         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1102         of "style".
1103         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1104         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1105         * stack.c (print_frame_arg, print_frame_info, print_frame):
1106         Update.
1107         * source.c (print_source_lines_base): Update.
1108         * solib.c (info_sharedlibrary_command): Update.
1109         * skip.c (info_skip_command): Update.
1110         * record-btrace.c (btrace_call_history_src_line)
1111         (btrace_call_history): Update.
1112         * python/py-framefilter.c (py_print_frame): Update.
1113         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1114         "style".
1115         * mi/mi-out.c (mi_ui_out::do_table_header)
1116         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1117         (mi_ui_out::do_field_string): Update.
1118         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1119         Update.
1120         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1121         "style".
1122         * cli-out.c (cli_ui_out::do_table_header)
1123         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1124         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1125         (cli_ui_out::do_field_fmt): Update.
1126         * breakpoint.c (print_breakpoint_location): Update.
1127         (update_static_tracepoint): Update.
1128
1129 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1130
1131         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1132         conversion of gdb_datadir.
1133         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1134         remove not needed c_str ().
1135
1136 2019-09-30  Ali Tamur <tamur@google.com>
1137
1138         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1139         (dwarf2_string_attr): Likewise.
1140
1141 2019-09-30  Ali Tamur <tamur@google.com>
1142
1143         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1144         (process_full_type_unit): Likewise.
1145         (dump_die_shallow): Likewise.
1146         (cu_debug_loc_section): Likewise.
1147
1148 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1149
1150         * minsyms.c (compare_minimal_symbols): Rename to...
1151         (minimal_symbol_is_less_than): ...this, and adjust to STL
1152         conventions (return bool, take arguments as references)
1153         (minimal_symbol_reader::install): Call std::sort instead
1154         of qsort.
1155
1156 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1157
1158         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1159         hash and why.
1160         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1161         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1162
1163 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1164
1165         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1166         * psympriv.h (add_psymbol_to_list): Move comment here and update
1167         it.
1168
1169 2019-09-29  Tom de Vries  <tdevries@suse.de>
1170
1171         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1172         Use $tmpdir/$(basename "$output_file").dwz instead of
1173         "${output_file}.dwz".
1174
1175 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1176
1177         PR gdb/25045
1178         * hppa-linux-nat.c: Include gdbarch.h.
1179
1180 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1181
1182         * blockframe.c (find_pc_partial_function): Change return type to bool.
1183         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1184         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1185         (stub_gnu_ifunc_resolve_name): Likewise.
1186         * symtab.c (compare_filenames_for_search): Likewise.
1187         (compare_glob_filenames_for_search): Likewise.
1188         (matching_obj_sections): Likewise.
1189         (symbol_matches_domain): Likewise.
1190         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1191         (find_line_pc): Change return type to bool.
1192         (find_line_pc_range): Likewise.
1193         (producer_is_realview): Likewise.
1194         * symtab.h (symbol_matches_domain): Likewise.
1195         (find_pc_partial_function): Likewise.
1196         (find_pc_line_pc_range): Likewise.
1197         (in_gnu_ifunc_stub): Likewise.
1198         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1199         (find_line_pc): Likewise.
1200         (find_line_pc_range): Likewise.
1201         (matching_obj_sections): Likewise.
1202         (find_line_symtab): Change out parameter to bool.
1203         (producer_is_realview): Change return type to bool.
1204         (compare_filenames_for_search): Likewise.
1205         (compare_glob_filenames_for_search): Likewise.
1206
1207 2019-09-26  Tom Tromey  <tom@tromey.com>
1208
1209         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1210         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1211         * gdb_usleep.h: Remove.
1212         * gdb_usleep.c: Remove.
1213         * utils.c: Don't include gdb_usleep.h.
1214
1215 2019-09-26  Tom Tromey  <tromey@adacore.com>
1216
1217         * python/py-type.c (type_to_type_object): Call check_typedef
1218         for stub types.
1219
1220 2019-09-26  Tom Tromey  <tom@tromey.com>
1221
1222         * utils.h (initialize_utils): Don't declare.
1223         * top.c (gdb_init): Don't call initialize_utils.
1224         * utils.c (initialize_utils): Remove.  Move contents...
1225         (_initialize_utils): ... here.
1226
1227 2019-09-25  Tom Tromey  <tom@tromey.com>
1228
1229         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1230         * utils.h (make_hex_string): Don't declare.
1231         * utils.c (make_hex_string): Remove.
1232
1233 2019-09-24  Tom de Vries  <tdevries@suse.de>
1234
1235         PR gdb/23815
1236         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1237         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1238
1239 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1240
1241         * NEWS: Mention new simulator port for PRU.
1242
1243 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1244
1245         * ada-exp.y (write_object_remaining): Update.
1246         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1247         and eliminate the static buffer.
1248         (ada_decode_symbol): Update.
1249         (ada_la_decode): Update.
1250         (ada_sniff_from_mangled_name): Update.
1251         (is_valid_name_for_wild_match): Update.
1252         (ada_lookup_name_info::matches): Update and simplify.
1253         (name_matches_regex): Update.
1254         (ada_add_global_exceptions): Update.
1255         * ada-lang.h (ada_decode): Update signature.
1256         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1257         * dwarf-index-write.c (debug_names::insert): Update.
1258
1259 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1260
1261         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1262         formatting.
1263
1264 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1265
1266         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1267         Change "nonzero" to "true" in documentation.
1268
1269 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1270
1271         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1272         (_initialize_darwin_solib): Don't set
1273         darwin_so_ops.lookup_lib_global_symbol.
1274         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1275         set_gdbarch_iterate_over_objfiles_in_search_order.
1276         (elf_lookup_lib_symbol): Rename to...
1277         (svr4_iterate_over_objfiles_in_search_order): this, and update
1278         to iterate semantics.
1279         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1280         * solib.c (solib_global_lookup): Remove.
1281         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1282         (solib_global_lookup): Remove.
1283         * symtab.c (lookup_global_or_static_symbol): Remove call to
1284         solib_global_lookup.
1285
1286 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1287
1288         * NEWS: Move entries about default MI version now being
1289         version 3, and about the GDB/MI fix for multi-location
1290         breakpoints to the "since GDB 8.3" section.
1291
1292 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1293
1294         GDB 8.3.1 released.
1295
1296 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1297
1298         * NEWS: Mention that Cell/B.E. debugging support was removed.
1299         * MAINTAINERS: Remove spu target.
1300
1301         * config/djgpp/fnchange.lst: Remove entries for removed files.
1302
1303         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1304         spu-multiarch.o, and spu-tdep.o.
1305         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1306         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1307         spu-multiarch.c, and spu-tdep.c.
1308         * spu-linux-nat.c: Remove file.
1309         * spu-multiarch.c: Remove file.
1310         * spu-tdep.c: Remove file.
1311         * spu-tdep.h: Remove file.
1312         * solib-spu.c: Remove file.
1313         * solib-spu.h: Remove file.
1314
1315         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1316         * configure.nat (spu-linux): Remove.
1317         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1318         solib-multiarch.o from gdb_target_obs.
1319         (spu*-*-*): Remove.
1320
1321         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1322         feature flag.
1323         (ppc_linux_no_features): Update.
1324         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1325         Cell/B.E. support.
1326         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1327         (tdesc_powerpc_cell64l): Likewise.
1328         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1329         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1330         Cell/B.E. support.
1331         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1332         Do not include "features/rs6000/powerpc-cell32l.c" or
1333         "features/rs6000/powerpc-cell64l.c".
1334         (ppc_linux_spu_section): Remove.
1335         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1336         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1337         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1338         (ppc_linux_spe_context_lookup): Remove.
1339         (ppc_linux_spe_context_inferior_created): Remove.
1340         (ppc_linux_spe_context_solib_loaded): Remove.
1341         (ppc_linux_spe_context_solib_unloaded): Remove.
1342         (ppc_linux_spe_context): Remove.
1343         (struct ppu2spu_cache): Remove.
1344         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1345         (struct ppu2spu_data): Remove.
1346         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1347         ppu2spu_unwind): Remove.
1348         (ppc_linux_init_abi): Remove Cell/B.E. support.
1349         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1350
1351         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1352         (rs6000/powerpc-cell64l-expedite): Likewise
1353         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1354         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1355         rs6000/powerpc-cell64l.xml.
1356         * features/rs6000/powerpc-cell32l.xml: Remove.
1357         * features/rs6000/powerpc-cell64l.xml: Likewise.
1358         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1359         * features/rs6000/powerpc-cell64l.c: Likewise.
1360         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1361         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1362         * regformats/reg-spu.dat: Remove.
1363
1364         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1365         * corelow.c (struct spuid_list): Remove.
1366         (add_to_spuid_list): Remove.
1367         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1368         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1369         (remote_protocol_features): Remove associated entries.
1370         (_initialize_remote): No longer initialize them.
1371         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1372         * linux-nat.c (SPUFS_MAGIC): Remove.
1373         (linux_proc_xfer_spu): Remove.
1374         (spu_enumerate_spu_ids): Remove.
1375         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1376         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1377         (linux_make_corefile_notes): No longer call it.
1378
1379         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1380         (cooked_write_test): Likewise.
1381
1382 2019-09-20  Tom Tromey  <tom@tromey.com>
1383
1384         * NEWS: Mention case-sensitivity of TUI commands.
1385         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1386         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1387         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1388
1389 2019-09-20  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-source.c (tui_source_window::set_contents): Use
1392         make_unique_xstrdup.
1393         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1394         make_unique_xstrdup.
1395
1396 2019-09-20  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-data.c: Remove separator comments.
1399         * tui/tui-layout.c: Remove separator comments.
1400         * tui/tui-win.c: Remove separator comments.
1401         * tui/tui-wingeneral.c: Remove separator comments.
1402
1403 2019-09-20  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui.h (strcat_to_buf): Don't declare.
1406         * tui/tui.c (strcat_to_buf): Remove.
1407
1408 2019-09-20  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1411         from "fullname".
1412         * tui/tui-source.c (tui_source_window::set_contents)
1413         (tui_source_window::location_matches_p)
1414         (tui_source_window::maybe_update): Update.
1415
1416 2019-09-20  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1419         Update.
1420         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1421         prefix.
1422         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1423         (tui_data_window::line_from_reg_element_no)
1424         (tui_data_window::first_reg_element_no_inline)
1425         (tui_data_window::show_registers)
1426         (tui_data_window::show_register_group)
1427         (tui_data_window::display_registers_from)
1428         (tui_data_window::display_registers_from_line)
1429         (tui_data_window::first_data_item_displayed)
1430         (tui_data_window::delete_data_content_windows)
1431         (tui_data_window::erase_data_content)
1432         (tui_data_window::do_scroll_vertical)
1433         (tui_data_window::refresh_window)
1434         (tui_data_window::check_register_values): Update.
1435
1436 2019-09-20  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1439         (struct tui_locator_window) <full_name, proc_name>: Now
1440         std::string.
1441         * tui/tui-stack.c (tui_locator_window::make_status_line)
1442         (tui_locator_window::set_locator_fullname)
1443         (tui_locator_window::set_locator_info): Update.
1444         * tui/tui-source.c (tui_source_window::set_contents)
1445         (tui_source_window::showing_source_p): Update.
1446
1447 2019-09-20  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1450         Don't call tui_locator_win_info_ptr.
1451
1452 2019-09-20  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1455
1456 2019-09-20  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1459         height for locator.
1460         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1461         * tui/tui-layout.c (show_source_disasm_command, show_data)
1462         (show_source_or_disasm_and_command): Use 1 as height for locator.
1463
1464 2019-09-20  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui.c (tui_enable): Update.
1467         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1468         Update.
1469         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1470         Update.
1471         * tui/tui-data.c (win_resized): Now bool.
1472         (tui_win_resized): Return bool.
1473         (tui_set_win_resized_to): Accept a bool.
1474
1475 2019-09-20  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1478         Change type of "refresh_values_only".
1479         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1480         type of "refresh_values_only".
1481
1482 2019-09-20  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1485         std::string.
1486         (tui_disassemble): Add "pos" parameter.
1487         (tui_disasm_window::set_contents): Simplify.
1488
1489 2019-09-20  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-winsource.h (struct tui_source_window_base)
1492         <show_source_content>: Now private.
1493         * tui/tui-winsource.c
1494         (tui_source_window_base::show_source_content): Don't handle empty
1495         content case.
1496
1497 2019-09-20  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-layout.c (show_source_disasm_command)
1500         (show_source_or_disasm_and_command): Don't call
1501         show_source_content.
1502
1503 2019-09-20  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1506         Declare.
1507         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1508         from tui_make_status_line.
1509         (tui_locator_window::rerender): Update.
1510
1511 2019-09-20  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1514         (tui_locator_window::rerender): Update.
1515
1516 2019-09-20  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-winsource.h (struct tui_source_window_base)
1519         <~tui_source_window_base>: Don't declare.
1520         <fullname>: Remove.
1521         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1522         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1523         member.
1524         * tui/tui-source.c (tui_source_window::set_contents): Update.
1525         (tui_source_window::location_matches_p)
1526         (tui_source_window::maybe_update): Update.
1527
1528 2019-09-20  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-winsource.h (~tui_source_element): Remove.
1531         (tui_source_element): Update.
1532         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1533         * tui/tui-winsource.c (tui_show_source_line): Update.
1534         * tui/tui-source.c (tui_source_window::set_contents): Update.
1535         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1536
1537 2019-09-20  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1540         declare.
1541         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1542         tui_clear_source_windows_detail.
1543         * tui/tui-winsource.h (struct tui_source_window_base)
1544         <clear_detail>: Don't declare.
1545         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1546         Remove.
1547         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1548
1549 2019-09-20  Tom Tromey  <tromey@adacore.com>
1550
1551         PR ada/24919:
1552         * block.c (contained_in): Fix final return value.
1553
1554 2019-09-20  Alan Modra  <amodra@gmail.com>
1555
1556         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1557         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1558         (read_indirect_string_from_dwz): Use bfd accessor.
1559         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1560         * machoread.c (macho_symfile_read_all_oso): Likewise.
1561         * solib.c (solib_bfd_open): Likewise.
1562
1563 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1564
1565         * eval.c: Move declaration of overload_resolution to...
1566         * value.h: ...here.
1567
1568 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1569
1570         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1571         * arm-linux-tdep.c: Likewise.
1572         * arm-nbsd-nat.c: Likewise.
1573         * arm-tdep.h: Declare arm_apcs_32.
1574         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1575
1576 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1577
1578         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1579         * dwarf2read.h: Declare dwarf_always_disassemble.
1580
1581 2019-09-19  Tom de Vries  <tdevries@suse.de>
1582
1583         PR gdb/25009
1584         * source-cache.c (source_cache::ensure): Catch exception thrown during
1585         construction of the highlighter.
1586
1587 2019-09-18  Alan Modra  <amodra@gmail.com>
1588
1589         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1590         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1591         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1592         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1593         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1594         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1595         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1596         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1597         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1598         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1599         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1600         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1601         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1602         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1603         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1604         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1605         * mi/mi-interp.c: Update throughout for bfd section macro and
1606         function changes.
1607         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1608         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1609
1610 2019-09-18  Tom Tromey  <tom@tromey.com>
1611
1612         * NEWS: Add entry.
1613         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1614         call rl_initialize.
1615         (tui_enable): Do not call rl_initialize.
1616
1617 2019-09-18  Christian Groessler  <chris@groessler.org>
1618
1619         * alpha-linux-nat.c: Include gdbarch.h.
1620
1621 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1622
1623         * ui-file.c: Include cli/cli-style.h.
1624         (term_cli_styling): Remove cli_styling declaration.
1625
1626 2019-09-18  Alan Modra  <amodra@gmail.com>
1627
1628         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1629         to bfd_asymbol_section.
1630
1631 2019-09-18  Alan Modra  <amodra@gmail.com>
1632
1633         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1634         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1635         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1636
1637 2019-09-18  Alan Modra  <amodra@gmail.com>
1638
1639         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1640         * spu-linux-nat.c (spu_bfd_open): Likewise.
1641
1642 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1643
1644         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1645         to bool to match definition in dwarf2read.c.
1646
1647 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1648
1649         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1650         (print_signatures): Likewise.
1651         (trust_pad_over_xvs): Likewise.
1652         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1653         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1654         * arm-linux-nat.c (arm_apcs_32): Likewise.
1655         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1656         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1657         * arm-tdep.c (arm_debug): Likewise.
1658         (arm_apcs_32): Likewise.
1659         * auto-load.c (debug_auto_load): Likewise.
1660         (auto_load_gdb_scripts): Likewise.
1661         (global_auto_load): Likewise.
1662         (auto_load_local_gdbinit): Likewise.
1663         (auto_load_local_gdbinit_loaded): Likewise.
1664         * auto-load.h (global_auto_load): Likewise.
1665         (auto_load_local_gdbinit): Likewise.
1666         (auto_load_local_gdbinit_loaded): Likewise.
1667         * breakpoint.c (disconnected_dprintf): Likewise.
1668         (breakpoint_proceeded): Likewise.
1669         (automatic_hardware_breakpoints): Likewise.
1670         (always_inserted_mode): Likewise.
1671         (target_exact_watchpoints): Likewise.
1672         (_initialize_breakpoint): Update.
1673         * breakpoint.h (target_exact_watchpoints): Change to bool.
1674         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1675         * cli/cli-cmds.c (trace_commands): Likewise.
1676         * cli/cli-cmds.h (trace_commands): Likewise.
1677         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1678         to bool*.
1679         * cli/cli-logging.c (logging_overwrite): Change to bool.
1680         (logging_redirect): Likewise.
1681         (debug_redirect): Likewise.
1682         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1683         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1684         to bool.
1685         <boolean_option_def>: Update.
1686         (struct flag_option_def): Change default type of Context to bool
1687         from int.
1688         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1689         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1690         (get_setshow_command_value_string): Likewise.
1691         * cli/cli-style.c (cli_styling): Change to bool.
1692         (source_styling): Likewise.
1693         * cli/cli-style.h (source_styling): Likewise.
1694         (cli_styling): Likewise.
1695         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1696         to bool.
1697         * command.h (var_types): Update comment.
1698         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1699         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1700         bool.
1701         (debug_compile_cplus_scopes): Likewise.
1702         * compile/compile-internal.h (compile_debug): Likewise.
1703         * compile/compile.c (compile_debug): Likewise.
1704         (struct compile_options) <raw>: Likewise.
1705         * cp-support.c (catch_demangler_crashes): Likewise.
1706         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1707         (usr_cmd_cris_dwarf2_cfi): Likewise.
1708         * csky-tdep.c (csky_debug): Likewise.
1709         * darwin-nat.c (enable_mach_exceptions): Likewise.
1710         * dcache.c (dcache_enabled_p): Likewise.
1711         * defs.h (info_verbose): Likewise.
1712         * demangle.c (demangle): Likewise.
1713         (asm_demangle): Likewise.
1714         * dwarf-index-cache.c (debug_index_cache): Likewise.
1715         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1716         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1717         * dwarf2read.c (check_physname): Likewise.
1718         (use_deprecated_index_sections): Likewise.
1719         (dwarf_always_disassemble): Likewise.
1720         * eval.c (overload_resolution): Likewise.
1721         * event-top.c (set_editing_cmd_var): Likewise.
1722         (exec_done_display_p): Likewise.
1723         * event-top.h (set_editing_cmd_var): Likewise.
1724         (exec_done_display_p): Likewise.
1725         * exec.c (write_files): Likewise.
1726         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1727         (debug_fbsd_nat): Likewise.
1728         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1729         Likewise.
1730         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1731         <backtrace_past_entry> Likewise.
1732         * gdb-demangle.h (demangle): Likewise.
1733         (asm_demangle): Likewise.
1734         * gdb_bfd.c (bfd_sharing): Likewise.
1735         * gdbcore.h (write_files): Likewise.
1736         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1737         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1738         * gdbthread.h (print_thread_events): Likewise.
1739         * gdbtypes.c (opaque_type_resolution): Likewise.
1740         (strict_type_checking): Likewise.
1741         * gnu-nat.c (gnu_debug_flag): Likewise.
1742         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1743         * guile/scm-param.c (pascm_variable): Add boolval.
1744         (add_setshow_generic): Update.
1745         (pascm_param_value): Update.
1746         (pascm_set_param_value_x): Update.
1747         * hppa-tdep.c (hppa_debug): Change to bool..
1748         * infcall.c (may_call_functions_p): Likewise.
1749         (coerce_float_to_double_p): Likewise.
1750         (unwind_on_signal_p): Likewise.
1751         (unwind_on_terminating_exception_p): Likewise.
1752         * infcmd.c (startup_with_shell): Likewise.
1753         * inferior.c (print_inferior_events): Likewise.
1754         * inferior.h (startup_with_shell): Likewise.
1755         (print_inferior_events): Likewise.
1756         * infrun.c (step_stop_if_no_debug): Likewise.
1757         (detach_fork): Likewise.
1758         (debug_displaced): Likewise.
1759         (disable_randomization): Likewise.
1760         (non_stop): Likewise.
1761         (non_stop_1): Likewise.
1762         (observer_mode): Likewise.
1763         (observer_mode_1): Likewise.
1764         (set_observer_mode): Update.
1765         (sched_multi): Change to bool.
1766         * infrun.h (debug_displaced): Likewise.
1767         (sched_multi): Likewise.
1768         (step_stop_if_no_debug): Likewise.
1769         (non_stop): Likewise.
1770         (disable_randomization): Likewise.
1771         * linux-tdep.c (use_coredump_filter): Likewise.
1772         (dump_excluded_mappings): Likewise.
1773         * linux-thread-db.c (auto_load_thread_db): Likewise.
1774         (check_thread_db_on_load): Likewise.
1775         * main.c (captured_main_1): Update.
1776         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1777         xx2_opt, boolean_opt>: Change to bool.
1778         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1779         * maint.c (maintenance_profile_p): Likewise.
1780         (per_command_time): Likewise.
1781         (per_command_space): Likewise.
1782         (per_command_symtab): Likewise.
1783         * memattr.c (inaccessible_by_default): Likewise.
1784         * mi/mi-main.c (mi_async): Likewise.
1785         (mi_async_1): Likewise.
1786         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1787         * nat/fork-inferior.h (startup_with_shell): Likewise.
1788         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1789         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1790         * nios2-tdep.c (nios2_debug): Likewise.
1791         * or1k-tdep.c (or1k_debug): Likewise.
1792         * parse.c (parser_debug): Likewise.
1793         * parser-defs.h (parser_debug): Likewise.
1794         * printcmd.c (print_symbol_filename): Likewise.
1795         * proc-api.c (procfs_trace): Likewise.
1796         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1797         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1798         (set_parameter_value): Update.
1799         (add_setshow_generic): Update.
1800         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1801         to bool*.
1802         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1803         int*.
1804         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1805         * record-btrace.c (record_btrace_target::store_registers): Update.
1806         * record-full.c (record_full_memory_query): Change to bool.
1807         (record_full_stop_at_limit): Likewise.
1808         * record-full.h (record_full_memory_query): Likewise.
1809         * remote-notif.c (notif_debug): Likewise.
1810         * remote-notif.h (notif_debug): Likewise.
1811         * remote.c (use_range_stepping): Likewise.
1812         (interrupt_on_connect): Likewise.
1813         (remote_break): Likewise.
1814         * ser-tcp.c (tcp_auto_retry): Likewise.
1815         * ser-unix.c (serial_hwflow): Likewise.
1816         * skip.c (debug_skip): Likewise.
1817         * solib-aix.c (solib_aix_debug): Likewise.
1818         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1819         (spu_auto_flush_cache_p): Likewise.
1820         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1821         Likewise.
1822         (struct info_print_options) <quiet>: Likewise.
1823         * symfile-debug.c (debug_symfile): Likewise.
1824         * symfile.c (auto_solib_add): Likewise.
1825         (separate_debug_file_debug): Likewise.
1826         * symfile.h (auto_solib_add): Likewise.
1827         (separate_debug_file_debug): Likewise.
1828         * symtab.c (basenames_may_differ): Likewise.
1829         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1830         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1831         (struct info_types_options) <quiet>: Likewise.
1832         * symtab.h (demangle): Likewise.
1833         (basenames_may_differ): Likewise.
1834         * target-dcache.c (stack_cache_enabled_1): Likewise.
1835         (code_cache_enabled_1): Likewise.
1836         * target.c (trust_readonly): Likewise.
1837         (may_write_registers): Likewise.
1838         (may_write_memory): Likewise.
1839         (may_insert_breakpoints): Likewise.
1840         (may_insert_tracepoints): Likewise.
1841         (may_insert_fast_tracepoints): Likewise.
1842         (may_stop): Likewise.
1843         (auto_connect_native_target): Likewise.
1844         (target_stop_and_wait): Update.
1845         (target_async_permitted): Change to bool.
1846         (target_async_permitted_1): Likewise.
1847         (may_write_registers_1): Likewise.
1848         (may_write_memory_1): Likewise.
1849         (may_insert_breakpoints_1): Likewise.
1850         (may_insert_tracepoints_1): Likewise.
1851         (may_insert_fast_tracepoints_1): Likewise.
1852         (may_stop_1): Likewise.
1853         * target.h (target_async_permitted): Likewise.
1854         (may_write_registers): Likewise.
1855         (may_write_memory): Likewise.
1856         (may_insert_breakpoints): Likewise.
1857         (may_insert_tracepoints): Likewise.
1858         (may_insert_fast_tracepoints): Likewise.
1859         (may_stop): Likewise.
1860         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1861         (make_thread_apply_all_options_def_group): Change argument from int*
1862         to bool*.
1863         (thread_apply_all_command): Update.
1864         (print_thread_events): Change to bool.
1865         * top.c (confirm): Likewise.
1866         (command_editing_p): Likewise.
1867         (history_expansion_p): Likewise.
1868         (write_history_p): Likewise.
1869         (info_verbose): Likewise.
1870         * top.h (confirm): Likewise.
1871         (history_expansion_p): Likewise.
1872         * tracepoint.c (disconnected_tracing): Likewise.
1873         (circular_trace_buffer): Likewise.
1874         * typeprint.c (print_methods): Likewise.
1875         (print_typedefs): Likewise.
1876         * utils.c (debug_timestamp): Likewise.
1877         (sevenbit_strings): Likewise.
1878         (pagination_enabled): Likewise.
1879         * utils.h (sevenbit_strings): Likewise.
1880         (pagination_enabled): Likewise.
1881         * valops.c (overload_resolution): Likewise.
1882         * valprint.h (struct value_print_options) <prettyformat_arrays,
1883         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1884         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1885         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1886         Likewise.
1887         * windows-nat.c (new_console): Likewise.
1888         (cygwin_exceptions): Likewise.
1889         (new_group): Likewise.
1890         (debug_exec): Likewise.
1891         (debug_events): Likewise.
1892         (debug_memory): Likewise.
1893         (debug_exceptions): Likewise.
1894         (useshell): Likewise.
1895         * windows-tdep.c (maint_display_all_tib): Likewise.
1896         * xml-support.c (debug_xml): Likewise.
1897
1898 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1899
1900         * source.c (prepare_path_for_appending): New function.
1901         (openp): Make use of new function.
1902         (find_and_open_source): Search for the compilation directory and
1903         source file as a relative path beneath the directory search path.
1904
1905 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * source-cache.c (source_cache::get_line_charpos): Catch
1908         exceptions and return false, this matches the behaviour documented
1909         in the header file.
1910
1911 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1912
1913         * ada-tasks.c (info_task): Remove quoting of the task's name.
1914
1915 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1916
1917         * symfile.c (auto_solib_add): Replace comment with a reference
1918         to the header file.
1919
1920 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1921
1922         * NEWS: Mention that gdb can now be compiled with Python 3
1923         on Windows.
1924
1925 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1926
1927         * maint.c (maint_print_section_data::maint_print_section_data):
1928         Force use of 'float log10 (float)' by casting the argument to
1929         float.
1930
1931 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * maint.c: Add 'cmath' include.
1934         (struct maint_print_section_data): New structure.
1935         (print_section_index): New function.
1936         (print_bfd_section_info): Add header comment, small whitespace
1937         cleanup, and update to call new print_section_index function.
1938         (print_objfile_section_info): Likewise.
1939         (maint_obj_section_from_bfd_section): New function.
1940         (print_bfd_section_info_maybe_relocated): New function.
1941         (maintenance_info_sections): Add header comment, always use
1942         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1943
1944 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1945
1946         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1947         inner scope, add check that the objfile has psymtabs before
1948         checking psymtabs_addrmap.
1949         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1950
1951 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1952
1953         * NEWS: Announce that Ada task names are now shown at more places,
1954         and between quotes (except in info task output).
1955         * gdb/ada-tasks.c (task_to_str): New function.
1956         (display_current_task_id): Call task_to_str.
1957         (task_command_1): Likewise.
1958         (print_ada_task_info): In non-mi mode, Properly align headers and data
1959         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1960
1961 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1962
1963         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1964         prstatus.pr_lwp.pr_info instead of making it up.
1965
1966 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1967
1968         * auto-load.c (auto_load_expand_dir_vars): Update.
1969         * defs.h (gdb_datadir): Change to std::string.
1970         (python_libdir): Likewise.
1971         (relocate_gdb_directory): Change return type to std::string.
1972         * guile/guile.c (gdbscm_data_directory): Update.
1973         (initialize_scheme_side): Update.
1974         * jit.c (jit_reader_dir): Change to std::string.
1975         (jit_reader_load_command): Update.
1976         * main.c (gdb_datadir): Change to std::string.
1977         (python_libdir): Likewise.
1978         (set_gdb_data_directory): Update.
1979         (relocate_path): Change to return std::string.
1980         (relocate_gdb_directory): Change to return std::string.
1981         (relocate_gdbinit_path_maybe_in_datadir): Update.
1982         (captured_main_1): Update.
1983         * python/python.c (do_start_initialization): Update.
1984         * top.c (show_gdb_datadir): Update.
1985         * xml-syscall.c (xml_init_syscalls_info): Update.
1986         (init_syscalls_info): Update.
1987
1988 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1989
1990         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1991         out of get_init_files.
1992         (get_init_files): Update.
1993
1994 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1995
1996         * main.c (get_init_files): Change to use std::string.
1997         (captured_main_1): Update.
1998         (print_gdb_help): Update.
1999
2000 2019-09-11  Ali Tamur  <tamur@google.com>
2001
2002         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2003         implementation.
2004
2005 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2006
2007         * dbxread.c (read_dbx_symtab): Update.
2008         * dwarf2read.c (load_partial_dies): Update.
2009         * mdebugread.c (parse_partial_symbols): Update.
2010         (handle_psymbol_enumerators): Update.
2011         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2012         * psymtab.c (add_psymbol_to_bcache): Likewise.
2013         (add_psymbol_to_list): Likewise.
2014         * symtab.c (symbol_set_names): Likewise.
2015         * symtab.h (symbol_set_names): Likewise.
2016         * xcoffread.c (scan_xcoff_symtab): Update.
2017
2018 2019-09-11  Tom Tromey  <tom@tromey.com>
2019
2020         * symfile-mem.c (symbol_file_add_from_memory): Use
2021         bfd_set_filename.
2022         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2023         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2024
2025 2019-09-10  Tom Tromey  <tromey@adacore.com>
2026
2027         * dwarf-index-write.c (write_psymbols): Extend error message.
2028         (debug_names::insert): Add Ada code.
2029         (debug_names::write_psymbols): Remove Ada check.
2030         (debug_names) <m_string_obstack>: New member.
2031         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2032         (gdb_index_symbol_name_matcher::matches): Remove.
2033         (mapped_index_base::find_name_components_bounds): Add "lang"
2034         parameter.
2035         (mapped_index_base::build_name_components): Also split names
2036         according to Ada syntax.
2037         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2038         type of "match_callback".
2039         (check_match, check_find_bounds_finds)
2040         (dw2_expand_symtabs_matching): Update.
2041         (dw2_debug_names_iterator): Add new constructor.
2042         (dw2_debug_names_map_matching_symbols): New function.
2043         (dw2_debug_names_expand_symtabs_matching): Update.
2044         (dwarf2_debug_names_functions): Use
2045         dw2_debug_names_map_matching_symbols.
2046
2047 2019-09-10  Tom Tromey  <tromey@adacore.com>
2048
2049         * dwarf2read.c (dw2_get_file_names_reader): Add the
2050         CU's file name to the results.
2051
2052 2019-09-10  Tom Tromey  <tromey@adacore.com>
2053
2054         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2055         map_matching_symbols.  Update.
2056         * dwarf2read.c (dw2_map_matching_symbols): Update.
2057         * psymtab.c (match_partial_symbol): Change type; update.
2058         (psym_map_matching_symbols): Likewise.
2059         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2060         type; update.
2061         * symfile.h (struct quick_symbol_functions)
2062         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2063         Remove "match".
2064
2065 2019-09-10  Tom Tromey  <tromey@adacore.com>
2066
2067         * psymtab.c (map_block): Remove.
2068         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2069         * symtab.c (iterate_over_symbols_terminated): New function.
2070         * symtab.c (iterate_over_symbols_terminated): Declare.
2071
2072 2019-09-10  Tom Tromey  <tromey@adacore.com>
2073
2074         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2075         * language.h (struct language_defn) <la_iterate_over_symbols>:
2076         Return bool.
2077         * symtab.c (iterate_over_symbols): Return bool.
2078         * symtab.h (iterate_over_symbols): Return bool.
2079
2080 2019-09-10  Tom Tromey  <tromey@adacore.com>
2081
2082         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2083         (add_nonlocal_symbols): Update.
2084         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2085         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2086         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2087         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2088         Change type of "callback".  Remove "data".
2089
2090
2091 2019-09-09  Ali Tamur  <tamur@google.com>
2092
2093         * dwarf2read.c (comp_unit_head): Update comment.
2094         (dwarf2_dwo_name): New function declaration.
2095         (dwarf_unit_type_name): New function declaration.
2096         (read_comp_unit_head): Add support for new compilation units,
2097         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2098         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2099         (currently named as "signature") in their header. Also clarify error
2100         messages.
2101         (lookup_dwo_id): New function. Returns the dwo id of the given
2102         compile unit.
2103         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2104         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2105         functions.
2106         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2107         (dwarf2_dwo_name): Get the dwo name if present.
2108         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2109         purposes.
2110
2111 2019-09-09  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2114
2115 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2116
2117         * python/python.c (do_start_initialization): Make progname_copy static,
2118         to avoid a leak report.
2119
2120 2019-09-08  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2123
2124 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2125
2126         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2127         Change type to gdb::optional<block_enum>.
2128         (dw2_symtab_iter_init): Change block_index parameter type
2129         to gdb::optional<block_enum>.
2130         (dw2_lookup_symbol): Change block_index parameter
2131         type to block_enum.c
2132         (dw2_debug_names_lookup_symbol): Likewise.
2133         * psymtab.c (psym_lookup_symbol): Likewise.
2134         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2135         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2136         Likewise.
2137
2138 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2139
2140         * defs.h (relocate_gdb_directory): Change int to bool in
2141         signature and rename flag to relocatable.
2142         * main.c (relocate_path): Likewise.
2143         (relocate_gdb_directory): Likewise.
2144
2145 2019-09-06  Alan Modra  <amodra@gmail.com>
2146
2147         * coffread.c (coff_symfile_read): Constify filename variable.
2148         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2149         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2150         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2151         * solib.c (reload_shared_libraries_1): Likewise.
2152         * symfile.c (reread_symbols): Likewise.
2153         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2154         * solib-darwin.c (darwin_bfd_open): Likewise.
2155         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2156
2157 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2160         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2161
2162 2019-09-03  Tom Tromey  <tromey@adacore.com>
2163
2164         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2165         types.
2166         (has_negatives): Unbias a range type bound.
2167         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2168         * gdbtypes.c (operator==): Handle new field.
2169         (create_range_type): Add "bias" parameter.
2170         (create_static_range_type, resolve_dynamic_range): Update.
2171         * gdbtypes.h (struct range_bounds) <bias>: New member.
2172         (create_range_type): Add bias parameter.
2173         * printcmd.c (print_scalar_formatted): Unbias range types.
2174         * value.c (unpack_long): Unbias range types.
2175         (pack_long): Bias range types.
2176
2177 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2178
2179         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2180         probe arguments.
2181
2182 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2183
2184         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2185         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2186         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2187         (compile_probe_arg): Likewise.
2188         * probe.h (get_argument_count): Likewise.
2189         * solib-svr4.c (solib_event_probe_action): Likewise.
2190         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2191
2192 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2193
2194         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2195         code to here...
2196         (svr4_create_solib_event_breakpoints): ...from here.
2197
2198 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2199
2200         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2201         suffix from warning message.
2202
2203 2019-08-30  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-winsource.h (struct tui_source_window_base)
2206         <refresh_all>: Don't declare.
2207         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2208         Remove.
2209         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2210         tui_show_locator_content.
2211         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2212         declare.
2213         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2214         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2215         declare.
2216
2217 2019-08-30  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2220
2221 2019-08-30  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2224         Remove unnecessary forward declarations.
2225
2226 2019-08-30  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2229         rerender.
2230         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2231         tui_show_locator_content.
2232
2233 2019-08-30  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2236         (tui_locator_window::rerender): Rewrite using body of previous
2237         tui_show_locator_content.
2238
2239 2019-08-30  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2242         set_locator_fullname>: New methods.
2243         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2244         Rename from tui_set_locator_fullname.
2245         (tui_locator_window::set_locator_info): Rename from
2246         tui_set_locator_info.  Return bool.
2247         (tui_update_locator_fullname, tui_show_frame_info): Update.
2248
2249 2019-08-30  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2252
2253 2019-08-30  Tom Tromey  <tom@tromey.com>
2254
2255         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2256         call touchwin.
2257
2258 2019-08-30  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-wingeneral.c (box_win): Assume win_info and
2261         win_info->handle cannot be NULL.
2262
2263 2019-08-30  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2266         refresh_window>: Declare.
2267         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2268         resize.
2269         (tui_data_item_window::rerender): Rename from
2270         tui_display_register.
2271         (tui_data_item_window::refresh_window): New method.
2272         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2273         no-op.
2274
2275 2019-08-30  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2278         regs_column_count, current_group>: Move later.  Now private.
2279         <get_current_group>: New method.
2280         * tui/tui-regs.c (tui_reg_command): Update.
2281         * tui/tui-layout.c (tui_set_layout): Update.
2282
2283 2019-08-30  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2286         (tui_data_window::rerender): Don't call
2287         check_and_display_highlight_if_needed.
2288         (tui_data_window::refresh_all): Remove call to
2289         erase_data_content.
2290
2291 2019-08-30  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2294         (tui_data_window::display_registers_from)
2295         (tui_data_window::display_reg_element_at_line)
2296         (tui_data_window::display_registers_from_line): Remove checks of
2297         "empty".
2298
2299 2019-08-30  Tom Tromey  <tom@tromey.com>
2300
2301         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2302         Don't declare.
2303         * tui/tui-regs.c (tui_data_window::show_registers): Call
2304         rerender.
2305         (tui_data_window::rerender): Rename from display_all_data.
2306         (tui_data_window::rerender): Remove old implementation.
2307
2308 2019-08-30  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2311         text.
2312         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2313
2314 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2315             Sergio Durigan Junior  <sergiodj@redhat.com>
2316
2317         PR win32/24284
2318         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2319
2320 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2321
2322         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2323         when searching for types.
2324
2325 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2326
2327         * f-lang.c (f_language_defn): Use f_print_typedef.
2328         * f-lang.h (f_print_typedef): Declare.
2329         * f-typeprint.c (f_print_typedef): Define.
2330
2331 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2332
2333         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2334
2335 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         * cli/cli-utils.c (info_print_options_defs): Delete.
2338         (make_info_print_options_def_group): Delete.
2339         (extract_info_print_options): Delete.
2340         (info_print_command_completer): Delete.
2341         (info_print_args_help): Add extra parameter, and optionally
2342         include text about -n flag.
2343         * cli/cli-utils.h (struct info_print_options): Delete.
2344         (extract_info_print_options): Delete declaration.
2345         (info_print_command_completer): Delete declaration.
2346         (info_print_args_help): Add extra parameter, extend header
2347         comment.
2348         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2349         search_symbols.
2350         * stack.c (struct info_print_options): New type.
2351         (info_print_options_defs): New file scoped variable.
2352         (make_info_print_options_def_group): New static function.
2353         (info_print_command_completer): New static function.
2354         (info_locals_command): Update to use new local functions.
2355         (info_args_command): Likewise.
2356         (_initialize_stack): Add extra parameter to calls to
2357         info_print_args_help.
2358         * symtab.c (search_symbols): Add extra parameter, use this to
2359         possibly excluse non-debug symbols.
2360         (symtab_symbol_info): Add extra parameter, which is passed on to
2361         search_symbols.
2362         (struct info_print_options): New type.
2363         (info_print_options_defs): New file scoped variable.
2364         (make_info_print_options_def_group): New static function.
2365         (info_print_command_completer): New static function.
2366         (info_variables_command): Update to use local functions, and pass
2367         extra parameter through to symtab_symbol_info.
2368         (info_functions_command): Likewise.
2369         (info_types_command): Pass additional argument through to
2370         symtab_symbol_info.
2371         (rbreak_command): Pass extra argument to search_symbols.
2372         (_initialize_symtab): Add extra arguments for calls to
2373         info_print_args_help, and update help text for 'info variables',
2374         'whereis', and 'info functions' commands.
2375         * symtab.h (search_symbols): Add extra argument to declaration.
2376         * NEWS: Mention new flags.
2377
2378 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2379
2380         * symtab.c (lookup_static_symbol): Call the new function (and move
2381         it down to be next to lookup_global_symbol).
2382         (struct global_sym_lookup_data): Add block_enum member and rename to...
2383         (struct global_or_static_sym_lookup_data): ...this.
2384         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2385         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2386         (lookup_symbol_global_or_static_iterator_cb): ...this.
2387         (lookup_global_or_static_symbol): New function.
2388         (lookup_global_symbol): Call new function.
2389
2390 2019-08-26  Tom de Vries  <tdevries@suse.de>
2391
2392         PR c++/24852
2393         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2394         when pc_probe.prob == NULL.
2395
2396 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2397
2398         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2399         variable symbol_linkage to symbol_linkage_.
2400
2401 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2402
2403         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2404         represent whether the symbol is static, dynamic, or we don't
2405         know.
2406
2407 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2408
2409         * gdb/rx-tdep.c (rx_register_names): New.
2410         (rx_register_name): Delete.
2411         (rx_psw_type): Delete.
2412         (rx_fpsw_type): Delete.
2413         (rx_register_type): Delete.
2414         (rx_gdbarch_init): Convert target-descriptions.
2415         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2416         * gdb/features/Makefile: Add rx.xml.
2417         * gdb/features/rx.xml: New.
2418         * gdb/features/rx.c: Generated.
2419         * gdb/NEWS: Mention target description support.
2420
2421 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2422
2423         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2424         *slot_ptr.
2425
2426 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2427
2428         * configure.ac: Don't check for 'dlfcn.h' (moved to
2429         gdbsupport/common.m4).
2430         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2431         'gdbsupport/'.
2432         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2433         * compile/compile-c-support.c: Include
2434         'gdbsupport/gdb-dlfcn.h'.
2435         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2436         * gdb-dlfcn.c: Move to...
2437         * gdbsupport/gdb-dlfcn.c: ... here.
2438         * gdb-dlfcn.h: Move to...
2439         * gdbsupport/gdb-dlfcn.h: ... here.
2440
2441 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2442
2443         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2444         the offset field signed.
2445
2446 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2447
2448         * python/lib/gdb/__init__.py (_execute_file): New function.
2449         * python/python.c (python_run_simple_file): Call gdb._execute_file
2450         on Windows.
2451
2452 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2453
2454         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2455         all uses as this was never set to anything but a zero value.
2456
2457 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2458
2459         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2460
2461 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2462
2463         * tui/tui-data.h (tui_gen_win_info): Add an =default
2464         move constructor, required by some GCC versions.
2465
2466 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2467
2468         * go32-nat.c (go32_sysinfo): Add hygon_p.
2469
2470 2019-08-20  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2473         line_from_reg_element_no, first_reg_element_no_inline,
2474         display_all_data, delete_data_content_windows,
2475         erase_data_content>: Now private.
2476
2477 2019-08-20  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2480         (tui_unhighlight_win, tui_highlight_win)
2481         (tui_win_info::make_window): Update.
2482         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2483
2484 2019-08-20  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2487         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2488         (MAX_PID_WIDTH): Move to tui-stack.c.
2489         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2490         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2491         (MAX_PID_WIDTH): Move from tui-data.h.
2492
2493 2019-08-20  Tom Tromey  <tom@tromey.com>
2494
2495         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2496         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2497         (box_win): Update.
2498         (tui_gen_win_info::make_window): Rename from tui_make_window.
2499         (tui_win_info::make_window): New method.
2500         (tui_gen_win_info::make_visible): Update.
2501         * tui/tui-source.c (tui_source_window::set_contents): Update.
2502         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2503         (tui_data_window::display_registers_from): Update.
2504         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2505         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2506         Declare.
2507         <can_box>: Remove.
2508         <title>: Remove.
2509         (struct tui_win_info) <make_window>: Declare.
2510         <can_box>: Now virtual.
2511         <title>: New member.
2512         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2513         * tui/tui-command.c (tui_cmd_window::resize): Update.
2514
2515 2019-08-20  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2518         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2519         (tui_data_window::check_register_values): Update.
2520
2521 2019-08-20  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-regs.h (struct tui_data_window): Use
2524         DISABLE_COPY_AND_ASSIGN.
2525         <regs_content>: Change type, removing unique_ptr.
2526         <tui_data_window>: Add move constructor.
2527         * tui/tui-regs.c (tui_data_window::show_registers)
2528         (tui_data_window::show_register_group)
2529         (tui_data_window::display_registers_from)
2530         (tui_data_window::display_registers_from)
2531         (tui_data_window::first_data_item_displayed)
2532         (tui_data_window::delete_data_content_windows)
2533         (tui_data_window::rerender, tui_data_window::refresh_window)
2534         (tui_data_window::check_register_values): Update.
2535
2536 2019-08-20  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2539         show_register_group>: Declare.
2540         (tui_show_register_group): Don't declare.
2541         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2542         tui_show_registers.
2543         (tui_data_window::show_register_group): Rename from
2544         tui_show_register_group.
2545         (tui_data_window::check_register_values, tui_reg_command):
2546         Update.
2547         * tui/tui-layout.c (tui_set_layout): Update.
2548
2549 2019-08-20  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2552         Declare.
2553         (tui_check_register_values): Don't declare.
2554         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2555         from tui_check_register_values.
2556         * tui/tui-hooks.c (tui_register_changed): Update.
2557
2558 2019-08-20  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-regs.c (tui_reg_layout): Move later.
2561         (tui_show_registers): Don't enable TUI mode or change layout.
2562
2563 2019-08-20  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-regs.h (struct tui_data_item_window)
2566         <~tui_data_item_window>: Remove.
2567         <content>: Now a unique_xmalloc_ptr.
2568         * tui/tui-regs.c (tui_register_format): Return a
2569         unique_xmalloc_ptr.
2570         (tui_get_register): Update.
2571         (~tui_data_item_window): Remove.
2572         (tui_data_window::display_registers_from, tui_display_register):
2573         Update.
2574         * tui/tui-io.h (tui_expand_tabs): Update.
2575         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2576         Remove "col" parameter.
2577
2578 2019-08-20  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2581         field.
2582         * tui/tui-regs.c (~tui_data_item_window): Update.
2583
2584 2019-08-20  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2587         earlier.
2588
2589 2019-08-20  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2592
2593 2019-08-20  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-source.h (struct tui_source_window): Update.
2596         * tui/tui-regs.c (tui_show_registers): Update.
2597         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2598         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2599         (NO_REGS_STRING): Remove defines.
2600
2601 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2602
2603         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2604         unnecessary thread walk if remote doesn't support the packet.
2605
2606 2019-08-19  Tom Tromey  <tromey@adacore.com>
2607
2608         * python/py-value.c (value_has_field): Fix indentation.
2609
2610 2019-08-19  Tom Tromey  <tromey@adacore.com>
2611
2612         * printcmd.c (do_one_display, info_display_command): Update.
2613         * block.h (contained_in): Return bool.  Add allow_nested
2614         parameter.
2615         * block.c (contained_in): Return bool.  Add allow_nested
2616         parameter.
2617
2618 2019-08-19  Tom Tromey  <tom@tromey.com>
2619
2620         * configure: Rebuild.
2621         * configure.ac: Disallow the combination of -static-libstdc++ and
2622         source highlight.
2623         * source-cache.c (get_language_name): Handle rust.
2624         (source_cache::get_source_lines): Ignore highlighting exceptions.
2625
2626 2019-08-16  Tom Tromey  <tom@tromey.com>
2627
2628         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2629         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2630         (struct tui_source_window_base) <make_visible, refresh_window,
2631         resize>: Remove methods.
2632         <execution_info>: Remove field.
2633         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2634         (tui_show_source_line, tui_source_window_base)
2635         (~tui_source_window_base): Update.
2636         (tui_source_window_base::resize)
2637         (tui_source_window_base::make_visible)
2638         (tui_source_window_base::refresh_window): Remove.
2639         (tui_source_window_base::update_exec_info): Update.
2640         * tui/tui-source.c (tui_source_window::set_contents): Update.
2641         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2642
2643 2019-08-16  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2646         deprecated_query_hook.
2647
2648 2019-08-16  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2651         (tui_update_source_windows_with_line): Update.
2652         * tui/tui-source.h (struct tui_source_window)
2653         <show_symtab_source>: Declare.
2654         (tui_show_symtab_source): Don't declare.
2655         * tui/tui-source.c (tui_show_symtab_source): Rename from
2656         tui_show_symtab_source.
2657
2658 2019-08-16  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-winsource.h (struct tui_source_window_base)
2661         <set_contents>: Declare.
2662         * tui/tui-winsource.c
2663         (tui_source_window_base::update_source_window_as_is): Update.
2664         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2665         Declare.
2666         (tui_set_source_content): Don't declare.
2667         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2668         tui_set_source_content.
2669         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2670         Declare.
2671         (tui_set_disassem_content): Don't declare.
2672         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2673         tui_set_disassem_content.
2674
2675 2019-08-16  Tom Tromey  <tom@tromey.com>
2676
2677         * tui/tui-winsource.h (struct tui_source_window_base)
2678         <update_breakpoint_info>: Declare.
2679         (tui_update_breakpoint_info): Don't declare.
2680         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2681         (tui_update_all_breakpoint_info): Update.
2682         (tui_source_window_base::update_breakpoint_info): Rename from
2683         tui_update_breakpoint_info.
2684         (tui_source_window_base::update_exec_info): Update.
2685
2686 2019-08-16  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-winsource.h (struct tui_source_window_base)
2689         <update_source_window>: Declare.
2690         (tui_update_source_window): Don't declare.
2691         * tui/tui-winsource.c
2692         (tui_source_window_base::update_source_window): Rename from
2693         tui_update_source_window.
2694         (tui_source_window_base::rerender): Update.
2695         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2696         * tui/tui-disasm.c (tui_show_disassem)
2697         (tui_show_disassem_and_update_source)
2698         (tui_disasm_window::maybe_update): Update.
2699
2700 2019-08-16  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-winsource.h (struct tui_source_window_base)
2703         <update_source_window_as_is>: Declare.
2704         (tui_update_source_window_as_is): Don't declare.
2705         * tui/tui-winsource.c (tui_update_source_window): Update
2706         (tui_source_window_base::update_source_window_as_is): Rename from
2707         tui_update_source_window_as_is.
2708         (tui_source_window_base::refill): Update.
2709         * tui/tui-source.c (tui_show_symtab_source): Update.
2710         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2711         Update.
2712
2713 2019-08-16  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui-winsource.h (tui_update_source_window)
2716         (tui_update_source_window_as_is): Remove "noerror" parameter.
2717         * tui/tui-winsource.c (tui_update_source_window)
2718         (tui_update_source_window_as_is): Remove "noerror" parameter.
2719         (tui_update_source_windows_with_addr)
2720         (tui_update_source_windows_with_line)
2721         (tui_source_window_base::rerender)
2722         (tui_source_window_base::refill): Update.
2723         * tui/tui-source.h (tui_set_source_content)
2724         (tui_show_symtab_source): Remove "noerror" parameter.
2725         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2726         parameter.
2727         (tui_show_symtab_source): Likewise.
2728         (tui_source_window::maybe_update): Update.
2729         * tui/tui-disasm.c (tui_show_disassem)
2730         (tui_show_disassem_and_update_source)
2731         (tui_disasm_window::do_scroll_vertical)
2732         (tui_disasm_window::maybe_update): Update.
2733
2734 2019-08-16  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui.c (tui_is_window_visible): Update.
2737         * tui/tui-wingeneral.c (tui_make_window)
2738         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2739         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2740         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2741         (tui_set_win_height_command, parse_scrolling_args): Update.
2742         * tui/tui-source.c (tui_source_window::style_changed): Update.
2743         * tui/tui-regs.c (tui_show_registers)
2744         (tui_data_window::first_data_item_displayed)
2745         (tui_data_window::delete_data_content_windows)
2746         (tui_check_register_values, tui_reg_command): Update.
2747         * tui/tui-disasm.c (tui_show_disassem): Update.
2748         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2749         method.
2750         <is_visible>: Remove field.
2751         * tui/tui-data.c (tui_next_win, tui_prev_win)
2752         (tui_delete_invisible_windows): Update.
2753
2754 2019-08-16  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-winsource.h (struct tui_source_window_base)
2757         <m_has_locator>: Remove.
2758         * tui/tui-layout.c (show_source_disasm_command, show_data)
2759         (show_source_or_disasm_and_command): Update.
2760
2761 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2762
2763         * NEWS (Other MI changes): New subsection.
2764         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2765         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2766         * arch-utils.c (default_get_pc_address_flags): New function.
2767         * arch-utils.h (default_get_pc_address_flags): New declaration.
2768         * gdbarch.sh: Add get_pc_address_flags.
2769         * gdbarch.c: Regenerate.
2770         * gdbarch.h: Likewise.
2771         * stack.c (print_pc): New function.
2772         (print_frame_info) (print_frame): Call print_pc.
2773
2774 2019-08-16  Tom de Vries  <tdevries@suse.de>
2775
2776         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2777         print_objfile_section_info.
2778
2779 2019-08-15  Tom Tromey  <tom@tromey.com>
2780
2781         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2782         calling update_cmdwin_start_line.
2783         * tui/tui-winsource.h (struct tui_source_window_base)
2784         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2785         <rerender>: Declare.
2786         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2787         Call rerender.
2788         (tui_source_window_base::set_new_height): Remove.
2789         (tui_source_window_base::rerender): Rename from
2790         do_make_visible_with_new_height.
2791         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2792         resize method.
2793         (tui_win_info::make_invisible_and_set_new_height)
2794         (tui_win_info::make_visible_with_new_height): Remove.
2795         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2796         Declare.
2797         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2798         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2799         do_make_visible_with_new_height>: Don't declare.
2800         <rerender>: Declare.
2801         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2802         set_new_height.
2803         (tui_data_window::do_make_visible_with_new_height): Remove.
2804         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2805         call tui_show_locator_content.
2806         (tui_gen_win_info::resize): Call rerender.
2807         (show_source_or_disasm_and_command): Don't call
2808         tui_show_locator_content.
2809         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2810         method.
2811         (struct tui_win_info) <rerender>: Declare.
2812         <set_new_height, make_invisible_and_set_new_height,
2813         make_visible_with_new_height>: Don't declare.
2814         * tui/tui-data.c (tui_win_list::rerender): New method.
2815         * tui/tui-command.h (struct tui_cmd_window)
2816         <do_make_visible_with_new_height>: Don't declare.
2817         * tui/tui-command.c
2818         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2819
2820 2019-08-15  Tom Tromey  <tromey@adacore.com>
2821
2822         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2823         * ada-lang.c (ada_enum_name): Likewise.
2824
2825 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2826
2827         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2828         leading underscore.
2829         (GdbOutputErrorFile): Likewise.
2830         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2831         accordingly.
2832         (execute_unwinders): Rename to have a leading underscore.
2833         (auto_load_packages): Likewise.
2834         (global scope): Adjust call to auto_load_packages accordingly.
2835         (GdbSetPythonDirectory): Likewise.
2836         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2837         instead of execute_unwinders.
2838
2839 2019-08-15  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2842         (show_data): Don't change window visibility.
2843         (tui_gen_win_info::resize): Remove special case for command
2844         window.  Use wresize, when available.
2845         (show_source_or_disasm_and_command): Don't change window
2846         visibility.
2847         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2848         <make_visible>: New method.
2849         * tui/tui-command.c (tui_cmd_window::resize): New method.
2850
2851 2019-08-15  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2854         (struct tui_source_windows): New.
2855         * tui/tui-winsource.c (tui_display_main): Update.
2856         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2857         (new_height_ok, parse_scrolling_args): Update.
2858         * tui/tui-layout.c (show_layout, show_data): Update.
2859         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2860         (tui_add_to_source_windows): Don't declare.
2861         * tui/tui-data.c (source_windows, tui_source_windows)
2862         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2863
2864 2019-08-15  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2867         Rename from reset.
2868         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2869         * tui/tui-layout.c (show_source_disasm_command, show_data):
2870         Update.
2871         (tui_gen_win_info::resize): Rename.
2872         (show_source_or_disasm_and_command): Update.
2873         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2874         reset.
2875
2876 2019-08-15  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2879         * tui/tui-interp.c (tui_interp::init): Don't call
2880         tui_initialize_static_data.
2881         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2882
2883 2019-08-15  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2886         examine tui_win_list.
2887
2888 2019-08-15  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2891         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2892         tui_clear_source_content.
2893         (tui_clear_source_content): Remove.
2894         (tui_source_window_base::do_erase_source_content): Hoist call to
2895         content.clear().
2896         * tui/tui-stack.c (tui_show_frame_info): Don't call
2897         tui_clear_source_content.
2898
2899 2019-08-15  Tom Tromey  <tom@tromey.com>
2900
2901         * tui/tui-winsource.h (struct tui_source_window_base)
2902         <do_erase_source_content>: New method.
2903         <erase_source_content>: New method.
2904         (tui_erase_source_content): Don't declare.
2905         * tui/tui-winsource.c (tui_clear_source_content): Update.
2906         (tui_source_window_base::do_erase_source_content): Rename from
2907         tui_erase_source_content.
2908         (tui_source_window_base::show_source_content): Update.
2909         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2910         * tui/tui-source.h (struct tui_source_window)
2911         <erase_source_content>: New method.
2912         * tui/tui-disasm.h (struct tui_disasm_window)
2913         <erase_source_content>: New method.
2914
2915 2019-08-15  Tom Tromey  <tom@tromey.com>
2916
2917         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2918         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2919         constructor.
2920         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2921         * tui/tui-source.c (tui_set_source_content): Update.
2922         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2923
2924 2019-08-15  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2927         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2928         tui-source.c.
2929         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2930         Declare.
2931         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2932         method.
2933         (tui_source_window::maybe_update): Update.
2934
2935 2019-08-15  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2938         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2939         tui-disasm.c.
2940         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2941         Declare.
2942         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2943         method.
2944         (tui_disasm_window::maybe_update): Update.
2945
2946 2019-08-15  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-winsource.h (struct tui_source_window_base)
2949         <maybe_update>: Declare.
2950         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2951         method.
2952         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2953         Declare.
2954         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2955         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2956         Declare.
2957         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2958
2959 2019-08-15  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2962
2963 2019-08-15  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-wingeneral.c: Include tui-stack.h.
2966         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2967         (struct tui_locator_window): Move from tui-data.h.
2968         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2969         (tui_initialize_static_data): Move from tui-data.c.
2970         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2971         (struct tui_locator_window): Move to tui-stack.c.
2972         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2973         (tui_initialize_static_data): Move to tui-stack.c.
2974
2975 2019-08-15  Tom Tromey  <tom@tromey.com>
2976
2977         * tui/tui-layout.c (show_source_disasm_command)
2978         (show_source_or_disasm_and_command): Use make_visible method, not
2979         tui_make_window.
2980         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2981         Remove.
2982
2983 2019-08-15  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-wingeneral.h (tui_make_window): Update.
2986         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2987         parameter.
2988         (tui_gen_win_info::make_visible): Update.
2989         * tui/tui-regs.c (tui_data_window::display_registers_from):
2990         Update.
2991         * tui/tui-layout.c (show_source_disasm_command)
2992         (show_source_or_disasm_and_command): Update.
2993         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2994         (enum tui_box): Remove.
2995         (struct tui_win_info) <can_box>: New method.
2996         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2997         method.
2998
2999 2019-08-15  Tom de Vries  <tdevries@suse.de>
3000
3001         * linux-nat-trad.c: Include gdbarch.h.
3002
3003 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3004
3005         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3006         register sizes.
3007
3008 2019-08-14  Tom Tromey  <tromey@adacore.com>
3009
3010         * darwin-nat.c: Include gdbarch.h.
3011         * darwin-nat-info.c: Include gdbarch.h.
3012
3013 2019-08-13  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3016         Remove.
3017         * tui/tui-data.c (tui_initialize_static_data): Update.
3018
3019 2019-08-13  Tom Tromey  <tom@tromey.com>
3020
3021         * tui/tui-winsource.h (struct tui_exec_info_window)
3022         <~tui_exec_info_window, maybe_allocate_content, get_content,
3023         m_content>: Remove.
3024         (struct tui_source_window_base) <set_exec_info_content,
3025         show_exec_info_content>: Don't declare.
3026         * tui/tui-winsource.c
3027         (tui_exec_info_window::maybe_allocate_content): Remove.
3028         (tui_source_window_base::update_exec_info): Rename from
3029         set_exec_info_content.
3030         (tui_source_window_base::show_exec_info_content)
3031         (tui_source_window_base::update_exec_info): Remove.
3032
3033 2019-08-13  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3036         declare.
3037         * tui/tui-winsource.c (tui_update_source_window_as_is)
3038         (tui_update_source_windows_with_addr, tui_erase_source_content):
3039         Update.
3040         (tui_clear_exec_info_content): Remove.
3041
3042 2019-08-13  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3045         declare.
3046         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3047         call tui_erase_exec_info_content.
3048         (tui_clear_exec_info_content): Rename from
3049         tui_erase_exec_info_content.
3050         (tui_clear_exec_info_content): Delete.
3051
3052 2019-08-13  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-winsource.h (struct tui_source_window_base)
3055         <show_exec_info_content>: Declare.
3056         (tui_show_exec_info_content): Don't declare.
3057         * tui/tui-winsource.c
3058         (tui_source_window_base::show_exec_info_content): Rename from
3059         tui_show_exec_info_content.
3060         (tui_source_window_base::update_exec_info): Update.
3061
3062 2019-08-13  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3065         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3066         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3067         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3068         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3069         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3070         ... here.
3071
3072 2019-08-13  Tom Tromey  <tom@tromey.com>
3073
3074         * tui/tui-winsource.h (struct tui_source_window_base)
3075         <update_exec_info>: Declare.
3076         (tui_update_exec_info): Don't declare.
3077         * tui/tui-winsource.c (tui_update_source_window_as_is)
3078         (tui_source_window_base::refresh_all)
3079         (tui_update_all_breakpoint_info): Update.
3080         (tui_source_window_base::update_exec_info): Rename from
3081         tui_update_exec_info.
3082         * tui/tui-stack.c (tui_show_frame_info): Update.
3083
3084 2019-08-13  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-winsource.h (struct tui_source_window_base)
3087         <set_exec_info_content>: Declare.
3088         (tui_set_exec_info_content): Don't declare.
3089         * tui/tui-winsource.c
3090         (tui_source_window_base::set_exec_info_content): Rename from
3091         tui_set_exec_info_content.
3092         (tui_update_exec_info): Update.
3093
3094 2019-08-13  Tom Tromey  <tom@tromey.com>
3095
3096         * tui/tui-winsource.h (struct tui_source_window_base)
3097         <show_source_content>: Declare.
3098         (tui_show_source_content): Don't declare.
3099         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3100         (tui_source_window_base::show_source_content): Rename from
3101         tui_show_source_content.
3102         (tui_source_window_base::refresh_all): Update.
3103         * tui/tui-layout.c (show_source_disasm_command)
3104         (show_source_or_disasm_and_command): Update.
3105
3106 2019-08-13  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-winsource.c (tui_erase_source_content)
3109         (tui_show_source_content, tui_source_window_base::refresh_all):
3110         Update.
3111         * tui/tui-wingeneral.h
3112         (tui_check_and_display_highlight_if_needed): Don't declare.
3113         * tui/tui-wingeneral.c
3114         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3115         check_and_display_highlight_if_needed.
3116         * tui/tui-win.c (tui_rehighlight_all)
3117         (tui_win_info::make_visible_with_new_height): Update.
3118         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3119         (tui_data_window::erase_data_content)
3120         (tui_data_window::display_all_data): Update.
3121         * tui/tui-data.h (struct tui_win_info)
3122         <check_and_display_highlight_if_needed>: Declare.
3123
3124 2019-08-13  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-win.c (tui_resize_all): Call
3127         tui_delete_invisible_windows.
3128         * tui/tui-layout.c (show_layout): Call
3129         tui_delete_invisible_windows.
3130         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3131         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3132
3133 2019-08-13  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3136         tui_add_win_to_layout.
3137
3138 2019-08-13  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3141         * tui/tui-layout.c (tui_default_win_height): Now static.
3142
3143 2019-08-13  Tom Tromey  <tom@tromey.com>
3144
3145         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3146         single switch.
3147         (show_source_disasm_command, show_source_or_disasm_and_command):
3148         Don't check current layout.
3149
3150 2019-08-13  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-wingeneral.c (make_all_visible): Remove.
3153         (tui_make_all_invisible): Simplify.
3154         * tui/tui-layout.c (tui_make_all_invisible): Move from
3155         tui-wingeneral.c; simplify.
3156         (show_layout): Hoist call to tui_make_all_invisible.
3157         (show_data): Don't call tui_make_all_invisible.
3158
3159 2019-08-13  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3162         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3163
3164 2019-08-13  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3167         tui-data.c.
3168         (show_source_disasm_command, show_data)
3169         (show_source_or_disasm_and_command): Don't use
3170         tui_set_current_layout_to.
3171         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3172         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3173         tui-layout.c.
3174         (tui_set_current_layout_to): Remove.
3175
3176 2019-08-13  Tom Tromey  <tom@tromey.com>
3177
3178         * tui/tui-layout.c (tui_set_layout): Update.
3179         * tui/tui-data.h (struct tui_layout_def): Remove.
3180         (tui_layout_def): Don't declare.
3181         * tui/tui-data.c (layout_def): Remove.
3182         (tui_layout_def): Remove.
3183
3184 2019-08-13  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-winsource.h (struct tui_source_window_base)
3187         <clear_detail>: No longer "override".
3188         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3189         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3190         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3191         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3192         Remove.
3193         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3194
3195 2019-08-13  Tom Tromey  <tromey@adacore.com>
3196
3197         * tracepoint.c: Don't include readline.h or history.h.
3198
3199 2019-08-12  Tom Tromey  <tom@tromey.com>
3200
3201         * configure: Rebuild.
3202         * configure.ac: Check for readline 7.
3203         * NEWS: Mention readline 7 requirement.
3204         * README: Update.
3205
3206 2019-08-12  Tom Tromey  <tom@tromey.com>
3207
3208         * mingw-hdep.c (gdb_select): Remove readline hack.
3209
3210 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3211
3212         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3213         when the function fails.
3214
3215 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3216
3217         * s390-tdep.c (s390_type_align): New function.
3218         (s390_gdbarch_init): Set it as type_align gdbarch method.
3219
3220 2019-08-09  Tom de Vries  <tdevries@suse.de>
3221
3222         PR gdb/24591
3223         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3224         pc_low with relocation offset.
3225
3226 2019-08-07  Tom Tromey  <tromey@adacore.com>
3227
3228         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3229         (print_frame_args): Update.
3230         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3231         Update.
3232         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3233         * frame.h (struct frame_arg): Add initializers.
3234         <error>: Now a unique_xmalloc_ptr.
3235
3236 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3237
3238         * NEWS: Expand the Pointer Authentication entry.
3239         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3240         (aarch64_frame_unmask_lr): ... to this.
3241         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3242         Call aarch64_frame_unmask_lr.
3243         * frame.c (struct frame_info): Add "masked" variable.
3244         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3245         (fprint_frame): Check for masked pc.
3246         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3247         declarations.
3248         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3249         * stack.c (print_frame): Check for masked pc.
3250
3251 2019-08-06  Tom Tromey  <tom@tromey.com>
3252
3253         * stabsread.c (patch_block_stabs, read_one_struct_field)
3254         (read_enum_type): Use obstack_strndup.
3255         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3256         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3257         * dwarf2read.c (guess_full_die_structure_name)
3258         (anonymous_struct_prefix): Use obstack_strndup.
3259         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3260         * c-exp.y (yylex): Use obstack_strndup.
3261         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3262         (write_var_or_type): Use obstack_strndup.
3263
3264 2019-08-06  Tom Tromey  <tom@tromey.com>
3265
3266         * symfile.c (reread_symbols): Use obstack_strdup.
3267         * stabsread.c (read_type): Use obstack_strdup.
3268         * gdb_obstack.h (obstack_strdup): New overload.
3269         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3270         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3271         (dwarf2_canonicalize_name): Use obstack_strdup.
3272         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3273         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3274         Use obstack_strdup.
3275
3276 2019-08-06  Tom Tromey  <tom@tromey.com>
3277
3278         * gdb_obstack.h (obstack_strdup): Define.
3279         * gdb_obstack.c (obstack_strdup): Don't define.
3280
3281 2019-08-06  Tom Tromey  <tom@tromey.com>
3282
3283         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3284         obstack_strdup.
3285         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3286         obstack_strdup.
3287         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3288         * stabsread.c (common_block_start): Use obstack_strdup.
3289         * objfiles.c (set_objfile_main_name, objfile): Use
3290         obstack_strdup.
3291         * namespace.c (add_using_directive): Use obstack_strdup.
3292         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3293         * jit.c (finalize_symtab): Use obstack_strdup.
3294         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3295         (guess_partial_die_structure_name, partial_die_info::fixup)
3296         (dwarf2_name): Use obstack_strdup.
3297         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3298         obstack_strdup.
3299         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3300         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3301         obstack_strdup.
3302         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3303
3304 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3305
3306         * unittests/help-doc-selftests.c: New file.
3307         * Makefile.in: Add the new file.
3308
3309 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3310
3311         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3312         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3313         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3314         the trailing '.' is not output, and the first character is uppercased.
3315         (print_help_for_command): Update call to print_doc_line.
3316         (print_doc_of_command): Likewise.
3317         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3318         * cli/cli-option.c (append_indented_doc): Do not append newline.
3319         (build_help_option): Append newline after first appended_indented_doc
3320         only if a second call is done.
3321         (build_help): Append 2 new lines before each option, except the first
3322         one.
3323         * compile/compile.c (_initialize_compile): Add new lines after
3324         %OPTIONS%, when not at the end of the help.
3325         Change help doc or code
3326         producing the help doc to respect the invariants.
3327         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3328         Also removed the new line after 'Options:', as all other commands
3329         do not put an empty line between 'Options:' and the first option.
3330         * printcmd.c (_initialize_printcmd): Likewise.
3331         * stack.c (_initialize_stack): Likewise.
3332         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3333         incorrectly telling COMMAND is optional.
3334         * ada-lang.c (_initialize_ada_language): Change help doc or code
3335         producing the help doc to respect the invariants.
3336         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3337         * breakpoint.c (_initialize_breakpoint): Likewise.
3338         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3339         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3340         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3341         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3342         _initialize_cli_style): Likewise.
3343         * corelow.c (core_target_info): Likewise.
3344         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3345         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3346         * filesystem.c (_initialize_filesystem): Likewise.
3347         * frame.c (_initialize_frame): Likewise.
3348         * gnu-nat.c (add_task_commands): Likewise.
3349         * infcall.c (_initialize_infcall): Likewise.
3350         * infcmd.c (_initialize_infcmd): Likewise.
3351         * interps.c (_initialize_interpreter): Likewise.
3352         * language.c (_initialize_language): Likewise.
3353         * linux-fork.c (_initialize_linux_fork): Likewise.
3354         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3355         * maint.c (_initialize_maint_cmds): Likewise.
3356         * memattr.c (_initialize_mem): Likewise.
3357         * printcmd.c (_initialize_printcmd): Likewise.
3358         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3359         _RegEx): Likewise.
3360         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3361         * record-btrace.c (_initialize_record_btrace): Likewise.
3362         * record-full.c (_initialize_record_full): Likewise.
3363         * record.c (_initialize_record): Likewise.
3364         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3365         * regcache.c (_initialize_regcache): Likewise.
3366         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3367         _initialize_remote): Likewise.
3368         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3369         * serial.c (_initialize_serial): Likewise.
3370         * skip.c (_initialize_step_skip): Likewise.
3371         * source.c (_initialize_source): Likewise.
3372         * stack.c (_initialize_stack): Likewise.
3373         * symfile.c (_initialize_symfile): Likewise.
3374         * symtab.c (_initialize_symtab): Likewise.
3375         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3376         * top.c (init_main): Likewise.
3377         * tracefile-tfile.c (tfile_target_info): Likewise.
3378         * tracepoint.c (_initialize_tracepoint): Likewise.
3379         * tui/tui-win.c (_initialize_tui_win): Likewise.
3380         * utils.c (add_internal_problem_command): Likewise.
3381         * valprint.c (value_print_option_defs): Likewise.
3382
3383 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3384
3385         PR build/24886
3386         * configure.ac: Drop enable-libmcheck support.
3387         * configure, config.in: Rebuild.
3388         * libmcheck.m4: Remove.
3389         * acinclude.m4: Don't include it.
3390         * Makefile.in: Don't distribute it.
3391         * top.c (print_gdb_configuration): Don't mention it.
3392
3393 2019-08-06  Tom Tromey  <tom@tromey.com>
3394
3395         * utils.c (set_output_style): Sometimes pass stream to
3396         emit_style_escape.
3397         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3398         * record-btrace.c (btrace_insn_history): Update.
3399         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3400         method.
3401         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3402         Update initializers.
3403         <m_uiout>: New field.
3404         <m_di>: Move lower.
3405         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3406         Remove "uiout" parameter.
3407         (dump_insns): Update.
3408         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3409         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3410
3411 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3412
3413         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3414         (error_in_psymtab_expansion): Likewise.
3415         (lookup_symbol_via_quick_fns): Likewise.
3416         (basic_lookup_transparent_type_quick): Likewise.
3417         (basic_lookup_transparent_type_1): Likewise.
3418
3419 2019-08-06  Tom Tromey  <tromey@adacore.com>
3420
3421         * source.c (last_source_error): Now bool.
3422         (print_source_lines_base): Make "noprint" bool.  Only open
3423         source file when last_source_visited changes.
3424
3425 2019-08-06  Tom Tromey  <tromey@adacore.com>
3426
3427         * annotate.c (annotate_source_line): Use g_source_cache.
3428         * source-cache.c (source_cache::get_plain_source_lines): Change
3429         parameters.  Populate m_offset_cache.
3430         (source_cache::ensure): New method.
3431         (source_cache::get_line_charpos): New method.
3432         (extract_lines): Move lower.  Change parameters.
3433         (source_cache::get_source_lines): Move lower.
3434         * source-cache.h (class source_cache): Update comment.
3435         <get_line_charpos>: New method.
3436         <get_source_lines>: Update comment.
3437         <clear>: Clear m_offset_cache.
3438         <get_plain_source_lines>: Change parameters.
3439         <ensure>: New method
3440         <m_offset_cache>: New member.
3441         * source.c (forget_cached_source_info_for_objfile): Update.
3442         (info_source_command): Use g_source_cache.
3443         (find_source_lines, open_source_file_with_line_charpos): Remove.
3444         (print_source_lines_base, search_command_helper): Use g_source_cache.
3445         * source.h (open_source_file_with_line_charpos): Don't declare.
3446         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3447         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3448         Use g_source_cache.
3449
3450 2019-08-06  Tom Tromey  <tromey@adacore.com>
3451
3452         * source-cache.c (source_cache::get_plain_source_lines):
3453         Remove "first_line" and "last_line" parameters.
3454         (source_cache::get_source_lines): Cache plain text.
3455         * source-cache.h (class source_cache)
3456         <get_plain_source_lines>: Update.
3457
3458 2019-08-06  Tom Tromey  <tromey@adacore.com>
3459
3460         * source-cache.c (extract_lines): No longer a method.
3461         Changed type of parameter.  Include final newline.
3462         (selftests::extract_lines_test): New function.
3463         (_initialize_source_cache): Likewise.
3464         * source-cache.h (class source_cache)
3465         <extract_lines>: Don't declare.
3466
3467 2019-08-06  Tom Tromey  <tromey@adacore.com>
3468
3469         * breakpoint.c (init_breakpoint_sal): Update.
3470         (breakpoint): Update.
3471         * breakpoint.h (struct breakpoint) <filter>: Now a
3472         unique_xmalloc_ptr.
3473
3474 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3475
3476         * NEWS: Mention dictionary access on blocks.
3477         * python/py-block.c (blpy_getitem): New function.
3478         (block_object_as_mapping): New struct.
3479         (block_object_type): Use new struct for tp_as_mapping field.
3480
3481 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3482
3483         * objfiles.h (objfile): Add a comment describing partial symbols.
3484
3485 2019-08-05  Tom Tromey  <tromey@adacore.com>
3486
3487         * compile/compile.c (_initialize_compile): Use _(), not N_().
3488         * thread.c (_initialize_thread): Use _(), not N_().
3489         * stack.c (_initialize_stack): Use _(), not N_().
3490         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3491
3492 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3493
3494         * dwarf2read.c (struct dw2_symtab_iterator):
3495         <want_specific_block>: Remove.
3496         <block_index>: Change type to gdb::optional.
3497         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3498         change type of BLOCK_INDEX parameter to gdb::optional.
3499         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3500         (dw2_lookup_symbol): Don't pass argument for
3501         WANT_SPECIFIC_BLOCK.
3502         (dw2_expand_symtabs_for_function): Don't pass argument for
3503         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3504         (class dw2_debug_names_iterator)
3505         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3506         parameter, change BLOCK_INDEX type to gdb::optional.
3507         <m_want_specific_block>: Remove.
3508         <m_block_index>: Change type to gdb::optional.
3509         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3510         gdb::optional.  Re-write in function of gdb::optional.
3511         (dw2_debug_names_lookup_symbol): Don't pass argument for
3512         WANT_SPECIFIC_BLOCK.
3513         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3514         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3515         BLOCK_INDEX.
3516
3517 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3518
3519         * NEWS: Mention changes to "info sources" command.
3520
3521 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3522
3523         * symtab.c (filename_partial_match_opts): New struct type.
3524         (struct output_source_filename_data): New members
3525         regexp, c_regexp, partial_match.
3526         (output_source_filename): Use new members to decide to print file.
3527         (info_sources_option_defs): New variable.
3528         (make_info_sources_options_def_group, print_info_sources_header,
3529         info_sources_command_completer):
3530         New functions.
3531         (info_sources_command): Read new optional arguments.
3532         (_initialize_symtab): Update info sources help.
3533
3534 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3535
3536         * ada-lang.c (exception_support_info_v0): Renamed from...
3537         (default_exception_support_info): ... this.  Create new
3538         definition for v1.
3539         (ada_has_this_exception_support): Look up catch_handlers_sym.
3540         (ada_exception_support_info_sniffer): Try v0 after default.
3541
3542 2019-08-01  Tom Tromey  <tromey@adacore.com>
3543
3544         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3545         gdbarch.h.
3546
3547 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3548
3549         * s12z-tdep.c: Fix include path for s12z-opc.h.
3550
3551 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3552
3553         * NEWS: Require GNU make 3.82.
3554
3555 2019-07-16  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3558         declare.
3559
3560 2019-07-30  Tom Tromey  <tromey@adacore.com>
3561
3562         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3563
3564 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3565
3566         * printcmd.c (print_address_symbolic): Print negative offsets.
3567         (build_address_symbolic): Force signed arithmetic when computing
3568         offset.
3569
3570 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3571
3572         PR/24474: Add a function to lookup static variables.
3573         * NEWS: Mention this new function.
3574         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3575         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3576         * python/python.c (python_GdbMethods): Add new function.
3577
3578 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3579
3580         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3581         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3582         (objfpy_lookup_static_symbol): New function.
3583         (objfile_object_methods): Add new functions.
3584
3585 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3586
3587         * NEWS: Mention 'set|show print frame-info'.  Mention new
3588         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3589         backtrace argument.  Mention that python frame filtering code
3590         is now consistent with what 'backtrace' command prints.
3591
3592 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3593
3594         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3595         comments.
3596         (print_frame_info_auto, print_frame_info_source_line,
3597         print_frame_info_location, print_frame_info_source_and_location,
3598         print_frame_info_location_and_address, print_frame_info_short_location):
3599         New declarations.
3600         (struct frame_print_options): New member print_frame_info.
3601         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3602         * stack.h (get_user_print_what_frame_info): New declaration.
3603         (frame_show_address): New declaration.
3604         * stack.c (print_frame_arguments_choices): New value 'presence'.
3605         (print_frame_info_auto, print_frame_info_source_line,
3606         print_frame_info_location, print_frame_info_source_and_location,
3607         print_frame_info_location_and_address, print_frame_info_short_location,
3608         print_frame_info_choices, print_frame_info_print_what): New definitions.
3609         (print_frame_args): Only print dots for args if print frame-arguments
3610         is 'presence'.
3611         (frame_print_option_defs): New element for "frame-info".
3612         (get_user_print_what_frame_info): New function.
3613         (frame_show_address): Make non static.  Move comment to stack.h.
3614         (print_frame_info_to_print_what): New function.
3615         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3616         to decide what to print.
3617         (backtrace_command_1): Handle the new print_frame_arguments_presence
3618         value.
3619         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3620         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3621         (py_print_frame): In non-mi mode, use LOCATION as default for
3622         print_what, similarly to frame information printed directly by
3623         backtrace command. Handle frame-info user option in non MI mode.
3624
3625 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3626
3627         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3628         Add case for debugging 32-bit target on 64-bit host.  Revise
3629         comment.
3630
3631 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3632
3633         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3634         instead of find_function_entry_range_from_pc.
3635
3636 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3637
3638         * stack.c (find_frame_funname): Remove code which preferred
3639         minsym over symtab sym in "certain pathological cases".
3640
3641         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3642         parameter.  Change type of "do_demangle" to bool.
3643         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3644         Pass suitable "prefer_sym_over_minsym" flag to
3645         build_address_symbolic().  Don't output "+" for negative offsets.
3646         * printcmd.c (print_address_symbolic): Update invocation of
3647         build_address_symbolic to include a "prefer_sym_over_minsym"
3648         flag.
3649         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3650         Restrict cases in which use of minimal symbol is preferred to that
3651         of a found symbol.  Update comments.
3652
3653         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3654         for entry pc when entry pc is out of range for that FDE.
3655
3656 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3657
3658         PR gdb/24839:
3659         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3660         type.
3661
3662 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3663
3664         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3665         this function's Python signature.
3666
3667
3668 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3669
3670         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3671         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3672         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3673         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3674         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3675
3676
3677 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3678
3679         * h8300-tdep.c (h8300_register_name_common): New.
3680         h8300_register_name): Use h8300_register_name_common.
3681         (h8300s_register_name): Likewise.
3682         (h8300sx_register_name): Likewise.
3683         (h8300h_register_nam): New.
3684         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3685
3686
3687 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3688
3689         * arm-tdep.c (arm_skip_cmse_entry): New function.
3690         (arm_is_sgstubs_section): New function.
3691         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3692
3693 2019-07-22  Tom Tromey  <tom@tromey.com>
3694
3695         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3696         Don't self-assign.
3697
3698 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3701         type_print.
3702
3703 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3704
3705         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3706         so that GDB doesn't match any msymbols when searching in the
3707         TYPES_DOMAIN.
3708         (print_symbol_info): Print using typedef_print or type_print based
3709         on the type of the symbol.  Add updated FIXME comment moved from...
3710         (_initialize_symtab): ... move and update FIXME comment to above.
3711
3712 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * NEWS: Mention adding -q option to "info types".
3715         * symtab.c (struct info_types_options): New struct.
3716         (info_types_options_defs): New variable.
3717         (make_info_types_options_def_group): New function.
3718         (info_types_command): Use gdb::option framework to parse options.
3719         (info_types_command_completer): New function.
3720         (_initialize_symtab): Extend the help text on "info types" and
3721         register command completer.
3722
3723 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3724
3725         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3726         (lookup_symbol_in_objfile): Change int to block_enum and add a
3727         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3728
3729 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3730
3731         * MAINTAINERS (Write After Approval): Add self.
3732
3733 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3736         instruction to the dummy code region.
3737
3738 2019-07-19  Tom Tromey  <tromey@adacore.com>
3739
3740         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3741         (ARGSUSED, PARAMS, __func__): Remove rules.
3742
3743 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3744
3745         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3746         * features/arm/arm-with-iwmmxt.c: Remove.
3747         * features/arm/arm-with-iwmmxt.xml: Remove.
3748         * features/arm/arm-with-m-fpa-layout.c: Remove.
3749         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3750         * features/arm/arm-with-m-vfp-d16.c: Remove.
3751         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3752         * features/arm/arm-with-m.c: Remove.
3753         * features/arm/arm-with-m.xml: Remove.
3754         * features/arm/arm-with-neon.c: Remove.
3755         * features/arm/arm-with-neon.xml: Remove.
3756         * features/arm/arm-with-vfpv2.c: Remove.
3757         * features/arm/arm-with-vfpv2.xml: Remove.
3758         * features/arm/arm-with-vfpv3.c: Remove.
3759         * features/arm/arm-with-vfpv3.xml: Remove.
3760
3761 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3762
3763         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3764
3765 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3766
3767         * arch/aarch32.c (aarch32_create_target_description): Create
3768         target descriptions using features.
3769         * arch/arm.c (arm_create_target_description)
3770         (arm_create_mprofile_target_description): Likewise.
3771         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3772
3773 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3774
3775         * Makefile.in: Add new files.
3776         * aarch32-tdep.c: New file.
3777         * aarch32-tdep.h: New file.
3778         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3779         Call aarch32_read_description.
3780         * arch/aarch32.c: New file.
3781         * arch/aarch32.h: New file.
3782         * arch/arm.c (arm_create_target_description)
3783         (arm_create_mprofile_target_description): New function.
3784         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3785         (arm_create_target_description)
3786         (arm_create_mprofile_target_description): New declaration.
3787         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3788         read_description functions.
3789         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3790         Likewise.
3791         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3792         * arm-tdep.c (tdesc_arm_list): New variable.
3793         (arm_register_g_packet_guesses): Call create description functions.
3794         (arm_read_description) (arm_read_mprofile_description): New
3795         function.
3796         * arm-tdep.h (arm_read_description)
3797         (arm_read_mprofile_description): Add declaration.
3798         * configure.tgt: Add new files.
3799
3800 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3801
3802         * top.c (new_ui_command): Open specified terminal just once.
3803
3804 2019-07-18  Tom Tromey  <tromey@adacore.com>
3805
3806         * symtab.c (main_name): Constify return type.
3807         * symfile.c (set_initial_language): Update.
3808         * symtab.h (main_name): Constify return type.
3809
3810 2019-07-17  Tom Tromey  <tom@tromey.com>
3811
3812         * tui/tui-winsource.c (tui_update_source_window)
3813         (tui_update_source_window_as_is)
3814         (tui_update_source_windows_with_line): Remove return.
3815         * tui/tui-disasm.c (tui_show_disassem)
3816         (tui_show_disassem_and_update_source): Remove return.
3817         * tui/tui.c (tui_reset): Remove return.
3818         * tui/tui-wingeneral.c
3819         (tui_check_and_display_highlight_if_needed): Remove return.
3820
3821 2019-07-17  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3824
3825 2019-07-17  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-winsource.h (struct tui_exec_info_window)
3828         (struct tui_source_window_base): Move from tui-data.h.
3829         * tui/tui-winsource.c: Move many method definitions from
3830         elsewhere.  Remove "structuring" comments.
3831         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3832         (tui_source_window_base::refresh_window): Move to
3833         tui-winsource.c.
3834         * tui/tui-win.c (tui_source_window_base::refresh_all)
3835         (tui_source_window_base::update_tab_width)
3836         (tui_source_window_base::set_new_height)
3837         (tui_source_window_base::do_make_visible_with_new_height): Move to
3838         tui-winsource.c.
3839         * tui/tui-source.h: Update.
3840         * tui/tui-source.c (tui_source_window_base::reset): Move to
3841         tui-winsource.c.
3842         * tui/tui-disasm.h: Update.
3843         * tui/tui-data.h (struct tui_exec_info_window): Move to
3844         tui-winsource.h.
3845         (struct tui_source_window_base): Likewise.
3846         * tui/tui-data.c (tui_source_window_base::clear_detail)
3847         (tui_source_window_base, ~tui_source_window_base): Move to
3848         tui-winsource.c.
3849
3850 2019-07-17  Tom Tromey  <tom@tromey.com>
3851
3852         * tui/tui-win.c (tui_resize_all)
3853         (tui_source_window_base::update_tab_width)
3854         (tui_adjust_win_heights): Update.
3855         (tui_win_info::make_invisible_and_set_new_height): Rename from
3856         make_invisible_and_set_new_height.
3857         * tui/tui-data.h (struct tui_win_info)
3858         <make_invisible_and_set_new_height>: New method.
3859
3860 2019-07-17  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui.c: Update.
3863         * tui/tui-source.h (struct tui_source_window): Move from
3864         tui-data.h.
3865         * tui/tui-layout.c: Update.
3866         * tui/tui-disasm.c: Update.
3867         * tui/tui-data.h (struct tui_source_window): Move to
3868         tui-source.h.
3869
3870 2019-07-17  Tom Tromey  <tom@tromey.com>
3871
3872         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3873         tui-data.h.
3874         * tui/tui-data.h (struct tui_disasm_window): Move to
3875         tui-disasm.h.
3876
3877 2019-07-17  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-regs.h (struct tui_data_item_window): Move from
3880         tui-data.h.
3881         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3882         * tui/tui-data.h (struct tui_data_item_window): Move to
3883         tui-regs.h.
3884         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3885
3886 2019-07-17  Tom Tromey  <tom@tromey.com>
3887
3888         * tui/tui.c: Update.
3889         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3890         (tui_cmd_window::max_height): Move to tui-command.c.
3891         * tui/tui-layout.c: Update.
3892         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3893         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3894         tui-command.c.
3895         * tui/tui-command.h (struct tui_cmd_window): Move from
3896         tui-data.h.
3897         * tui/tui-command.c: Remove "structuring" comments.
3898         (tui_cmd_window::clear_detail)
3899         (tui_cmd_window::do_make_visible_with_new_height)
3900         (tui_cmd_window::max_height): Move from elsewhere.
3901
3902 2019-07-17  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3905         Now static.
3906         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3907         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3908
3909 2019-07-17  Tom Tromey  <tom@tromey.com>
3910
3911         * tui/tui.c: Update.
3912         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3913         tui-regs.c.
3914         * tui/tui-windata.h: Remove file.
3915         * tui/tui-windata.c: Remove file.
3916         * tui/tui-win.c (tui_data_window::set_new_height)
3917         (tui_data_window::do_make_visible_with_new_height): Move to
3918         tui-regs.c.
3919         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3920         * tui/tui-regs.c: Remove "structuring" comments.
3921         (tui_data_window::first_data_item_displayed)
3922         (tui_data_window::delete_data_content_windows)
3923         (tui_data_window::erase_data_content)
3924         (tui_data_window::display_all_data)
3925         (tui_data_window::refresh_all)
3926         (tui_data_window::do_scroll_vertical)
3927         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3928         (tui_data_window::do_make_visible_with_new_height)
3929         (tui_data_window::refresh_window): Move from elsewhere.
3930         (_initialize_tui_regs): Move to end of file.
3931         * tui/tui-layout.c: Update.
3932         * tui/tui-hooks.c: Update.
3933         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3934         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3935         tui-regs.c.
3936         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3937
3938 2019-07-17  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3941         seen.
3942
3943 2019-07-17  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-win.c (tui_source_window_base::set_new_height)
3946         (tui_source_window_base::do_make_visible_with_new_height): Use
3947         m_has_locator field directly.
3948         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3949         method.
3950         (struct tui_source_window_base) <has_locator>: Likewise.
3951
3952 2019-07-17  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3955         Don't declare.
3956         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3957         Remove.
3958         * tui/tui-win.c (tui_source_window_base::set_new_height)
3959         (tui_source_window_base::set_new_height)
3960         (make_invisible_and_set_new_height)
3961         (tui_source_window_base::do_make_visible_with_new_height)
3962         (tui_source_window_base::do_make_visible_with_new_height):
3963         Update.
3964         * tui/tui-layout.c (show_source_disasm_command, show_data)
3965         (show_source_or_disasm_and_command): Update.
3966         * tui/tui-layout.c (show_layout): Update.
3967
3968 2019-07-17  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-layout.c (make_data_window): Remove.
3971         (show_data): Unify creation and re-initialization cases.
3972
3973 2019-07-17  Tom Tromey  <tom@tromey.com>
3974
3975         * tui/tui-layout.c (make_source_window, make_disasm_window):
3976         Remove.
3977         (show_data): Unify creation and re-initialization cases.
3978
3979 2019-07-17  Tom Tromey  <tom@tromey.com>
3980
3981         * tui/tui-layout.c (make_command_window): Remove.
3982         (show_source_disasm_command, show_source_or_disasm_and_command):
3983         Unify creation and re-initialization cases.
3984
3985 2019-07-17  Tom Tromey  <tom@tromey.com>
3986
3987         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3988         creation and re-initialization cases.
3989
3990 2019-07-17  Tom Tromey  <tom@tromey.com>
3991
3992         * tui/tui-regs.c (tui_get_register): Return void.
3993
3994 2019-07-17  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3997         Simplify.
3998
3999 2019-07-17  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4002         resetting.
4003
4004 2019-07-17  Tom Tromey  <tom@tromey.com>
4005
4006         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4007         * tui/tui-regs.c (tui_reg_layout): New function.
4008         (tui_show_registers, tui_reg_command): Use it.
4009         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4010         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4011         parameters.
4012         (tui_layout_command): Remove.
4013
4014 2019-07-17  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-layout.h (tui/tui-layout): Return void.
4017         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4018
4019 2019-07-17  Tom Tromey  <tom@tromey.com>
4020
4021         * tui/tui-layout.c (show_source_disasm_command, show_data):
4022         Update.
4023         (reset_locator): Remove.
4024         (show_source_or_disasm_and_command): Update.
4025
4026 2019-07-17  Tom Tromey  <tom@tromey.com>
4027
4028         * tui/tui-source.c (tui_source_window_base::reset): Remove
4029         win_type parameter.
4030         * tui/tui-layout.c (make_command_window, make_source_window)
4031         (make_disasm_window, make_data_window)
4032         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4033         (reset_locator, show_source_or_disasm_and_command): Update.
4034         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4035         win_type parameter.
4036         (struct tui_source_window_base) <reset>: Likewise.
4037
4038 2019-07-17  Tom Tromey  <tom@tromey.com>
4039
4040         * tui/tui-layout.c (show_source_disasm_command): Use
4041         reset_locator.
4042         (reset_locator): New function.
4043         (init_and_make_win): Remove.
4044         (show_source_or_disasm_and_command): Use reset_locator.
4045
4046 2019-07-17  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4049         condition.
4050         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4051         Remove condition.
4052         * tui/tui-source.c (tui_source_window_base::reset): New method.
4053         * tui/tui-layout.c (make_command_window): Don't call
4054         init_and_make_win.
4055         (make_source_window, make_disasm_window): Don't call
4056         make_source_or_disasm_window.
4057         (make_data_window): Don't call init_and_make_win.  Change calling
4058         convention.
4059         (show_source_disasm_command, show_data): Simplify.
4060         (make_source_or_disasm_window): Remove.
4061         (show_source_or_disasm_and_command): Simplify.
4062         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4063         (struct tui_source_window_base) <reset>: Likewise.
4064         <execution_info>: Remove initializer.
4065         * tui/tui-data.c (tui_source_window_base): Initialize
4066         execution_info.
4067
4068 2019-07-17  Tom Tromey  <tom@tromey.com>
4069
4070         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4071         variable.
4072
4073 2019-07-17  Tom Tromey  <tom@tromey.com>
4074
4075         * tui/tui.c (tui_rl_other_window): Update.
4076         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4077         superclass method first.  Always iterate over regs_content.
4078         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4079         method.
4080         * tui/tui-win.c (tui_set_focus_command): Update.
4081
4082 2019-07-17  Tom Tromey  <tom@tromey.com>
4083
4084         * tui/tui-win.c (tui_set_focus_command): Rename from
4085         tui_set_focus.  Call tui_enable.
4086         (tui_set_focus_command): Remove.
4087
4088 2019-07-17  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4091         refresh_window.
4092         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4093         touchwin.
4094         (tui_data_window::refresh_window): Call refresh_window on data
4095         items.  Always call superclass refresh_window.
4096         (tui_win_info::refresh): Remove.
4097         (tui_source_window_base::refresh_window): Update.
4098         (tui_refresh_all): Update.
4099         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4100         refresh_window.
4101         (show_source_or_disasm_and_command): Likewise.
4102         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4103         (struct tui_source_window_base) <refresh>: Likewise.
4104
4105 2019-07-17  Tom Tromey  <tom@tromey.com>
4106
4107         * tui/tui-winsource.c (tui_clear_source_content)
4108         (tui_show_source_content): Update.
4109         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4110         whether content is empty.
4111         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4112         Remove.
4113
4114 2019-07-17  Tom Tromey  <tom@tromey.com>
4115
4116         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4117         window's contents.
4118         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4119         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4120
4121 2019-07-17  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4124         (struct tui_data_item_window): Update.
4125
4126 2019-07-17  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4129         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4130         defines.
4131
4132 2019-07-17  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-winsource.h (tui_erase_source_content)
4135         (tui_clear_source_content): Remove "display_prompt" parameter.
4136         * tui/tui-winsource.c (tui_update_source_window_as_is)
4137         (tui_update_source_windows_with_addr): Update.
4138         (tui_clear_source_content): Remove "display_prompt" parameter.
4139         (tui_erase_source_content): Likewise.  Simplify.
4140         (tui_show_source_content): Update.
4141         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4142         * tui/tui-stack.c (tui_show_frame_info): Update.
4143         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4144         Remove defines.
4145
4146 2019-07-17  Tom Tromey  <tom@tromey.com>
4147
4148         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4149         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4150         parameter.
4151         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4152         parameter.
4153
4154 2019-07-17  Tom Tromey  <tom@tromey.com>
4155
4156         * tui/tui-winsource.c (tui_clear_source_content)
4157         (tui_show_source_content, tui_show_exec_info_content)
4158         (tui_clear_exec_info_content): Update.
4159         * tui/tui-stack.c (tui_show_locator_content): Update.
4160         (tui_show_frame_info): Update.
4161         * tui/tui-source.h (tui_source_window): Don't declare.
4162         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4163         from tui_source_is_displayed.
4164         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4165         Remove field.
4166         (struct tui_source_window_base) <content_in_use>: New field.  Now
4167         bool.
4168         (struct tui_source_window) <showing_source_p>: New method.
4169         (TUI_SRC_WIN): Change cast.
4170         * tui/tui-data.c (tui_initialize_static_data): Update.
4171
4172 2019-07-17  Tom Tromey  <tom@tromey.com>
4173
4174         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4175         location_matches_p.
4176         * tui/tui-source.c (tui_source_window::location_matches_p): New
4177         method.
4178         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4179         method.
4180         * tui/tui-data.h (struct tui_source_window_base)
4181         <location_matches_p>: New method.
4182         (struct tui_source_window, struct tui_disasm_window)
4183         <location_matches_p>: Likewise.
4184
4185 2019-07-17  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-win.c (tui_set_win_height_command): Rename from
4188         tui_set_win_height.
4189         (tui_set_win_height_command): Remove.
4190
4191 2019-07-17  Tom Tromey  <tom@tromey.com>
4192
4193         * tui/tui-source.c (tui_source_window): New constructor.  Add
4194         observer.
4195         (~tui_source_window): New destructor.
4196         (tui_source_window::style_changed): New method.
4197         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4198         (tui_attach_detach_observers): Update.
4199         * tui/tui-data.h (struct tui_source_window): Make constructor not
4200         inline.  Add destructor.
4201         (struct tui_source_window) <style_changed>: New method.
4202         <m_observable>: New member.
4203
4204 2019-07-17  Tom Tromey  <tom@tromey.com>
4205
4206         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4207         * tui/tui-win.c (tui_resize_all): Fix typo.
4208
4209 2019-07-17  Tom Tromey  <tom@tromey.com>
4210
4211         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4212         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4213         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4214         * tui/tui-win.c (window_name_completer): Use foreach.
4215         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4216         (update_tab_width): Likewise.
4217         * tui/tui-layout.c (show_layout): Update.
4218         * tui/tui-data.h (class tui_window_iterator): New.
4219         (struct all_tui_windows): New.
4220         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4221
4222 2019-07-17  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4225         parameter.  Don't reference globals.
4226         (tui_reg_command): Update.
4227
4228 2019-07-17  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-regs.c (tui_show_registers): Simplify.
4231
4232 2019-07-17  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-regs.c (tui_show_registers): Update.
4235         (tui_show_register_group): Add win_info parameter.
4236
4237 2019-07-17  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4240         Rename from tui_display_reg_element_at_line.
4241         (tui_data_window::display_registers_from_line): Update.
4242         * tui/tui-data.h (struct tui_data_window)
4243         <display_reg_element_at_line>: New method.
4244
4245 2019-07-17  Tom Tromey  <tom@tromey.com>
4246
4247         * tui/tui-regs.h (tui_display_registers_from)
4248         (tui_display_registers_from_line): Don't declare.
4249         * tui/tui-windata.c (tui_data_window::display_all_data)
4250         (tui_data_window::refresh_all)
4251         (tui_data_window::do_scroll_vertical): Update.
4252         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4253         from tui_display_registers_from.
4254         (tui_display_reg_element_at_line): Update.
4255         (tui_data_window::display_registers_from_line): Rename from
4256         tui_display_registers_from_line.
4257         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4258         display_registers_from_line>: New methods.
4259
4260 2019-07-17  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4263         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4264         from tui_erase_data_content.
4265         (tui_data_window::display_all_data)
4266         (tui_data_window::refresh_all)
4267         (tui_data_window::do_scroll_vertical): Update.
4268         * tui/tui-regs.c (tui_show_registers): Update.
4269         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4270         New method.
4271
4272 2019-07-17  Tom Tromey  <tom@tromey.com>
4273
4274         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4275         declare.
4276         * tui/tui-windata.c
4277         (tui_data_window::delete_data_content_windows): Rename from
4278         tui_delete_data_content_windows.
4279         (tui_data_window::display_all_data)
4280         (tui_data_window::do_scroll_vertical): Update.
4281         * tui/tui-data.h (struct tui_data_window)
4282         <delete_data_content_windows>: New method.
4283
4284 2019-07-17  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4287         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4288
4289 2019-07-17  Tom Tromey  <tom@tromey.com>
4290
4291         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4292         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4293         from tui_display_all_data.
4294         * tui/tui-win.c
4295         (tui_data_window::do_make_visible_with_new_height): Update.
4296         * tui/tui-regs.c (tui_show_registers): Update.
4297         * tui/tui-layout.c (tui_set_layout): Update.
4298         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4299         method.
4300
4301 2019-07-17  Tom Tromey  <tom@tromey.com>
4302
4303         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4304         * tui/tui-windata.c (tui_display_data_from): Remove.
4305         (tui_data_window::refresh_all): Update.
4306
4307 2019-07-17  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4310         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4311         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4312         tui_display_registers_from_line.
4313         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4314         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4315         "force_display" parameter.
4316
4317 2019-07-17  Tom Tromey  <tom@tromey.com>
4318
4319         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4320         declare.
4321         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4322         Rename from tui_first_reg_element_no_inline.
4323         (tui_display_reg_element_at_line)
4324         (tui_display_registers_from_line): Update.
4325         * tui/tui-data.h (struct tui_data_window)
4326         <first_reg_element_no_inline>: New method.
4327
4328 2019-07-17  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-windata.c (tui_display_data_from)
4331         (tui_data_window::do_scroll_vertical): Update.
4332         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4333         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4334         Rename from tui_line_from_reg_element_no.
4335         (tui_display_registers_from_line): Update.
4336         * tui/tui-data.h (struct tui_data_window)
4337         <line_from_reg_element_no>: New method.
4338
4339 2019-07-17  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4342         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4343         tui_last_regs_line_no.
4344         (tui_display_reg_element_at_line)
4345         (tui_display_registers_from_line): Update.
4346         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4347         method.
4348
4349 2019-07-17  Tom Tromey  <tom@tromey.com>
4350
4351         PR tui/24722:
4352         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4353         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4354         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4355         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4356         (tui_update_breakpoint_info): Likewise.
4357         * tui/tui-hooks.c (tui_event_create_breakpoint)
4358         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4359         Update.
4360
4361 2019-07-17  Tom Tromey  <tom@tromey.com>
4362
4363         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4364
4365 2019-07-17  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-winsource.c (tui_update_source_window_as_is)
4368         (tui_update_source_windows_with_addr): Update.
4369         * tui/tui-source.h (tui_set_source_content)
4370         (tui_show_symtab_source): Add "win_info" parameter.
4371         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4372         parameter.
4373         (tui_show_symtab_source): Likewise.
4374
4375 2019-07-17  Tom Tromey  <tom@tromey.com>
4376
4377         * tui/tui-wingeneral.c
4378         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4379
4380 2019-07-17  Tom Tromey  <tom@tromey.com>
4381
4382         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4383         (struct tui_cmd_window) <can_scroll>: New method.
4384         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4385         method.
4386
4387 2019-07-17  Tom Tromey  <tromey@adacore.com>
4388
4389         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4390         do_field_signed>: Rename.  Change type of "value".
4391         * ui-out.c (ui_out::field_signed): Rename from field_int.
4392         Change type of "value".
4393         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4394         type of "value".
4395         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4396         do_field_int.  Change type of "value".
4397         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4398         do_field_int.  Change type of "value".
4399         * tracepoint.c (trace_status_mi, tfind_1)
4400         (print_one_static_tracepoint_marker): Update.
4401         * thread.c (print_thread_info_1, print_selected_thread_frame):
4402         Update.
4403         * stack.c (print_frame, print_frame_info): Update.
4404         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4405         Update.
4406         * source.c (print_source_lines_base): Update.
4407         * skip.c (info_skip_command): Update.
4408         * record-btrace.c (btrace_ui_out_decode_error)
4409         (btrace_call_history_src_line): Update.
4410         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4411         Update.
4412         * progspace.c (print_program_space): Update.
4413         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4414         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4415         do_field_int.  Change type of "value".
4416         * mi/mi-out.c (mi_ui_out::do_table_begin)
4417         (mi_ui_out::do_table_header): Update.
4418         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4419         type of "value".
4420         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4421         (mi_cmd_data_list_changed_registers, output_register)
4422         (mi_cmd_data_read_memory, mi_load_progress)
4423         (mi_cmd_trace_frame_collected): Update.
4424         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4425         Update.
4426         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4427         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4428         (mi_cmd_var_list_children, varobj_update_one): Update.
4429         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4430         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4431         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4432         * inferior.c (print_inferior): Update.
4433         * gdb_bfd.c (print_one_bfd): Update.
4434         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4435         Update.
4436         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4437         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4438         do_field_int.  Change type of "value".
4439         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4440         do_field_int.  Change type of "value".
4441         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4442         (print_one_breakpoint_location, print_it_catch_fork)
4443         (print_one_catch_fork, print_it_catch_vfork)
4444         (print_one_catch_vfork, print_it_catch_solib)
4445         (print_it_catch_exec, print_it_ranged_breakpoint)
4446         (print_mention_watchpoint, print_mention_masked_watchpoint)
4447         (bkpt_print_it, update_static_tracepoint): Update.
4448         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4449         * break-catch-syscall.c (print_it_catch_syscall): Update.
4450         * ada-tasks.c (print_ada_task_info): Update.
4451         * ada-lang.c (print_it_exception, print_mention_exception):
4452         Update.
4453
4454 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         PR breakpoints/24541
4457         * gdbarch.c: Regenerate.
4458         * gdbarch.h: Regenerate.
4459         * gdbarch.sh: Adjust return type and parameter types for
4460         'stap_adjust_register'.
4461         (i386_stap_adjust_register): Adjust signature and return new
4462         register name.
4463         * stap-probe.c (stap_parse_register_operand): Adjust use of
4464         'gdbarch_stap_adjust_register'.
4465
4466 2019-07-17  Tom Tromey  <tromey@adacore.com>
4467
4468         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4469         declare VEC.
4470         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4471         std::vector.
4472         (struct s390_process_info): Add initializers.
4473         (s390_add_process): Use new.
4474         (s390_linux_nat_target::low_forget_process): Use delete.
4475         (s390_linux_nat_target::low_new_fork)
4476         (s390_linux_nat_target::stopped_by_watchpoint)
4477         (s390_linux_nat_target::low_prepare_to_resume)
4478         (s390_linux_nat_target::insert_watchpoint)
4479         (s390_linux_nat_target::insert_hw_breakpoint)
4480         (s390_linux_nat_target::remove_watchpoint)
4481         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4482
4483 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4484
4485         * aarch64-fbsd-nat.c: Include regcache.h.
4486         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4487         argument.
4488         (aarch64_fbsd_nat_target::fetch_registers)
4489         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4490         variable.
4491         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4492
4493 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4494
4495         * fbsd-nat.c: Include gdbarch.h.
4496
4497 2019-07-15  Tom Tromey  <tromey@adacore.com>
4498
4499         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4500
4501 2019-07-15  Tom Tromey  <tromey@adacore.com>
4502
4503         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4504         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4505         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4506         * cli-out.c (cli_ui_out::do_field_int): New method.
4507         * ui-out.c (ui_out::field_unsigned): New method.
4508         * symfile.c (generic_load): Use field_unsigned.
4509         (print_transfer_performance): Likewise.
4510         * record-btrace.c (ui_out_field_uint): Remove.
4511         (btrace_call_history_insn_range, btrace_call_history): Use
4512         field_unsigned.
4513         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4514         field_unsigned.
4515         * ui-out.h (class ui_out) <field_unsigned>: New method.
4516         <do_field_unsigned>: Likewise.
4517
4518 2019-07-15  Tom Tromey  <tromey@adacore.com>
4519
4520         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4521         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4522         * target.c (flash_erase_command): Use field_string.
4523         * infrun.c (print_signal_received_reason): Use field_string.
4524         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4525         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4526         field_string.
4527         * ada-tasks.c (print_ada_task_info): Use field_string.
4528
4529 2019-07-15  Tom Tromey  <tromey@adacore.com>
4530
4531         * target.c (flash_erase_command): Use field_core_addr.
4532         * symfile.c (generic_load): Use field_core_addr.
4533         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4534         Use field_core_addr.
4535         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4536         field_core_addr.
4537
4538 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4541         value if its desired type is smaller than a CORE_ADDR and signed.
4542
4543 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4544
4545         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4546         of changes to field names, and use new is_reference field to
4547         decide if a property is a reference or not.
4548         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4549         field.
4550         (struct dwarf2_property_baton): Update header comment, rename
4551         'referenced_type' to 'property_type' and update comments.
4552         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4553         default property type, store in property baton, update to take
4554         accound of renamed field.
4555         (read_func_scope): Update call to attr_to_dynamic_prop.
4556         (read_array_type): Likewise.
4557         (dwarf2_per_cu_addr_sized_int_type): New function.
4558         (read_subrange_index_type): Move type finding code to
4559         dwarf2_per_cu_addr_sized_int_type.
4560         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4561         (dwarf2_per_cu_addr_type): New function.
4562         (set_die_type): Update calls to attr_to_dynamic_prop.
4563
4564 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * dwarf2read.c (read_subrange_index_type): New function.
4567         (read_subrange_type): Move code into new function and call it.
4568         * gdbtypes.c (create_range_type): Add some asserts.
4569
4570 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4571
4572         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4573         update return statements.
4574         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4575         declaration, and update comment to match.
4576         * gdbtypes.c (resolve_dynamic_array): Update call to
4577         dwarf2_evaluate_property to match new return type.
4578
4579 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * valarith.c (value_subscripted_rvalue): Change lowerbound
4582         parameter type from int to LONGEST.
4583         * value.h (value_subscripted_rvalue): Likewise in declaration.
4584
4585 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * cli/cli-utils.c (info_print_command_completer): New function.
4588         * cli/cli-utils.h: Add 'completer.h' include, and forward
4589         declaration for 'struct cmd_list_element'.
4590         (info_print_command_completer): Declare.
4591         * stack.c (_initialize_stack): Add completer for 'info locals' and
4592         'info args'.
4593         * symtab.c (_initialize_symtab): Add completer for 'info
4594         variables' and 'info functions'.
4595         * NEWS: Mention completion for additional info commands.
4596
4597 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4598
4599         * cli/cli-utils.c (extract_info_print_args): Delete.
4600         (extract_arg_maybe_quoted): Delete.
4601         (info_print_options_defs): New variable.
4602         (make_info_print_options_def_group): New function.
4603         (extract_info_print_options): Define new function.
4604         * cli/cli-utils.h (extract_info_print_args): Delete.
4605         (struct info_print_options): New structure.
4606         (extract_info_print_options): Declare new function.
4607         * stack.c (info_locals_command): Update to use new
4608         extract_info_print_options, also add a header comment.
4609         (info_args_command): Likewise.
4610         * symtab.c (info_variables_command): Likewise.
4611         (info_functions_command): Likewise.
4612
4613 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4616         to extract string arguments.
4617         * common/common-utils.c (extract_string_maybe_quoted): New function.
4618         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4619
4620 2019-07-11  Tom Tromey  <tromey@adacore.com>
4621
4622         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4623         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4624         * top.h (gdbinit): Don't declare.
4625         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4626         into...
4627         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4628         * top.c (gdb_init): Don't call init_cli_cmds.
4629         (gdbinit): Remove.
4630         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4631
4632 2019-07-11  Tom Tromey  <tromey@adacore.com>
4633
4634         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4635         after it has been moved.
4636
4637 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4638
4639         * valops.c (value_must_coerce_to_target): Change return type to
4640         bool.
4641         * value.h (value_must_coerce_to_target): Likewise.
4642
4643 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4644
4645         * breakpoint.c (is_hardware_watchpoint): Remove
4646         forward-declaration.
4647         (is_masked_watchpoint): Change return type to bool.
4648         (is_tracepoint): Likewise.
4649         (is_breakpoint): Likewise.
4650         (is_hardware_watchpoint): Likewise.
4651         (is_watchpoint): Likewise.
4652         (is_no_memory_software_watchpoint): Likewise.
4653         (is_catchpoint): Likewise.
4654         (breakpoint_1): Make FILTER parameter's return type bool.
4655         is_masked_watchpoint): Change return type to bool.
4656         (save_breakpoints): Make FILTER parameter's return type bool.
4657         * breakpoint.h (is_breakpoint): Change return type to bool.
4658         (is_watchpoint): Likewise.
4659         (is_catchpoint): Likewise.
4660         (is_tracepoint): Likewise.
4661
4662 2019-07-10  Tom Tromey  <tom@tromey.com>
4663
4664         * defs.h: Don't include gdbarch.h.
4665         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4666         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4667         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4668         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4669         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4670         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4671         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4672         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4673         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4674         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4675         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4676         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4677         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4678         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4679         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4680         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4681         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4682         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4683         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4684         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4685         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4686         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4687         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4688         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4689         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4690         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4691         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4692
4693 2019-07-10  Tom Tromey  <tromey@adacore.com>
4694
4695         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4696         * breakpoint.c (init_ada_exception_breakpoint): Register as
4697         bp_catchpoint.
4698         (print_one_breakpoint_location, print_one_breakpoint): Use
4699         is_ada_exception_catchpoint.
4700         * ada-lang.c (class ada_catchpoint_location): Pass
4701         bp_loc_software_breakpoint to bp_location constructor.
4702         (is_ada_exception_catchpoint): New function.
4703
4704 2019-07-10  Tom Tromey  <tromey@adacore.com>
4705
4706         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4707         VEC.
4708         (struct arm_exidx_entry): New method operator<.
4709         (struct arm_exidx_data) <section_maps>: Change type.
4710         (arm_exidx_data_free): Remove.
4711         (arm_exidx_data_key): Change type.  Move lower.
4712         (arm_exidx_new_objfile): Update.
4713         (arm_compare_exidx_entries): Remove.
4714         (arm_find_exidx_entry, _initialize_arm_tdep)
4715
4716 2019-07-10  Tom Tromey  <tromey@adacore.com>
4717
4718         * solib-spu.c (ocl_program_data_key): Change type.
4719         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4720         Update.
4721
4722 2019-07-10  Tom Tromey  <tromey@adacore.com>
4723
4724         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4725         (struct solib_aix_inferior_data) <library_list>: Change type.
4726         (solib_aix_inferior_data_handle): Change type.
4727         (get_solib_aix_inferior_data): Update.
4728         (solib_aix_free_library_list): Remove.
4729         (library_list_start_library): Update.
4730         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4731         return type.
4732         (solib_aix_get_library_list)
4733         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4734         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4735
4736 2019-07-10  Tom Tromey  <tromey@adacore.com>
4737
4738         * solib-dsbt.c (struct dsbt_info): Add initializers.
4739         (solib_dsbt_pspace_data): Change type.
4740         (dsbt_pspace_data_cleanup): Remove.
4741         (get_dsbt_info, _initialize_dsbt_solib): Update.
4742
4743 2019-07-10  Tom Tromey  <tromey@adacore.com>
4744
4745         * spu-tdep.c (spu_overlay_data): Change type.
4746         (spu_get_overlay_table, spu_overlay_new_objfile)
4747         (_initialize_spu_tdep): Update.
4748
4749 2019-07-10  Tom Tromey  <tromey@adacore.com>
4750
4751         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4752         destructor.
4753         (dbx_objfile_data_key): Change type and declare later.
4754         (DBX_SYMFILE_INFO): Rewrite.
4755         * dbxread.c (dbx_objfile_data_key): Change type.
4756         (dbx_symfile_init): Update.
4757         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4758         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4759         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4760
4761 2019-07-10  Tom Tromey  <tromey@adacore.com>
4762
4763         * jit.c (jit_program_space_key): Change type.  Move lower.
4764         (get_jit_program_space_data): Update.
4765         (jit_program_space_data_cleanup): Remove.
4766         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4767         Update.
4768         (struct jit_program_space_data): Add initializers.
4769
4770 2019-07-10  Tom Tromey  <tromey@adacore.com>
4771
4772         * solib-darwin.c (struct darwin_info): Add initializers.
4773         (solib_darwin_pspace_data): Change type.
4774         (darwin_pspace_data_cleanup): Remove.
4775         (get_darwin_info, _initialize_darwin_solib): Update.
4776
4777 2019-07-10  Tom Tromey  <tromey@adacore.com>
4778
4779         * remote-sim.c (struct sim_inferior_data): Add initializers,
4780         constructor, and destructor.
4781         (sim_inferior_data_key): Change type.  Move lower.
4782         (check_for_duplicate_sim_descriptor): Update.
4783         (get_sim_inferior_data): Use new.  Update.
4784         (~sim_inferior_data_cleanup): Rename from
4785         sim_inferior_data_cleanup.  Simplify.
4786         (gdbsim_close_inferior, simulator_command)
4787         (sim_command_completer, _initialize_remote_sim): Update.
4788         (next_pid, INITIAL_PID): Move earlier.
4789
4790 2019-07-10  Tom Tromey  <tromey@adacore.com>
4791
4792         * python/python-internal.h (create_thread_object): Return
4793         gdbpy_ref.
4794         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4795         * python/py-inferior.c (struct threadlist_entry): Add
4796         constructor.
4797         <thread_obj>: Now a gdbpy_ref.
4798         (thread_to_thread_object): Update.
4799         (add_thread_object): Use new.
4800         (delete_thread_object): Use delete.
4801         (infpy_threads): Update.
4802         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4803         GIL.
4804
4805 2019-07-10  Tom Tromey  <tromey@adacore.com>
4806
4807         * valops.c (value_cast): Specialize error message for Ada.
4808
4809 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4810
4811         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4812
4813 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4814
4815         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4816         bpstat_should_step): Return bool, adjust comments.
4817         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4818         bpstat_should_step): Likewise.
4819
4820 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4821
4822         * features/Makefile: Use feature target descriptions for Arm.
4823         * features/arm/arm-core.c: Generate new file.
4824         * features/arm/arm-fpa.c: Likewise.
4825         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4826         * features/arm/arm-m-profile.c: Likewise.
4827         * features/arm/arm-vfpv2.c: Likewise.
4828         * features/arm/arm-vfpv3.c: Likewise.
4829         * features/arm/xscale-iwmmxt.c: Likewise.
4830         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4831
4832 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4833
4834         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4835         ptrace earlier.
4836
4837 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4838
4839         * features/aarch64-pauth.c: Regenerate.
4840
4841 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4842
4843         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4844         bool.
4845         (bpstat_what): Use false instead of 0.
4846
4847 2019-07-09  Pedro Alves  <palves@redhat.com>
4848
4849         * break-catch-throw.c (is_exception_catchpoint): New.
4850         * breakpoint.c (print_one_breakpoint_location): New parameter
4851         'raw_loc'.  Handle it.  Use
4852         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4853         looking at the breakpoint's type.
4854         (print_one_breakpoint): If handling "maint info breakpoints", also
4855         print locations of exception catchpoints.
4856         * breakpoint.h (is_exception_catchpoint): Declare.
4857
4858 2019-07-09  Pedro Alves  <palves@redhat.com>
4859
4860         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4861         "addr" field.
4862         (allocate_location_exception_catchpoint): New.
4863         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4864         (initialize_throw_catchpoint_ops): Install
4865         allocate_location_exception_catchpoint as allocate_location
4866         method.
4867         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4868         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4869         bp_loc_other.
4870         (breakpoint_address_is_meaningful): Delete.
4871         (bl_address_is_meaningful): New.
4872         (breakpoint_locations_match): Adjust comment.
4873         (bp_location_from_bp_type): New, factored out of...
4874         (bp_location::bp_location(breakpoint *)): ... this.
4875         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4876         factored out of...
4877         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4878         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4879         breakpoint_address_is_meaningful.
4880         (bp_locations_compare): Adjust comment.
4881         (update_global_location_list): Use bl_address_is_meaningful
4882         instead of breakpoint_address_is_meaningful.
4883         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4884         explicit.
4885         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4886         * python/py-breakpoint.c (bppy_get_location): No longer check
4887         whether location is null.
4888
4889 2019-07-09  Pedro Alves  <palves@redhat.com>
4890
4891         PR c++/15468
4892         * breakpoint.c (print_one_breakpoint_location): Remove
4893         single-location assert.
4894
4895 2019-07-09  Tom Tromey  <tom@tromey.com>
4896
4897         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4898         * configure: Rebuild.
4899         * configure.ac: Change common to gdbsupport.
4900         * gdbsupport: Rename from common.
4901         * acinclude.m4: Change common to gdbsupport.
4902         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4903         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4904         gdbsupport.
4905         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4906         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4907         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4908         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4909         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4910         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4911         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4912         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4913         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4914         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4915         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4916         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4917         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4918         coff-pe-read.c, command.h, compile/compile-c-support.c,
4919         compile/compile-c.h, compile/compile-cplus-symbols.c,
4920         compile/compile-cplus-types.c, compile/compile-cplus.h,
4921         compile/compile-loc2c.c, compile/compile.c, completer.c,
4922         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4923         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4924         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4925         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4926         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4927         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4928         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4929         features/aarch64-core.c, features/aarch64-fpu.c,
4930         features/aarch64-pauth.c, features/aarch64-sve.c,
4931         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4932         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4933         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4934         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4935         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4936         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4937         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4938         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4939         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4940         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4941         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4942         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4943         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4944         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4945         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4946         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4947         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4948         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4949         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4950         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4951         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4952         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4953         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4954         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4955         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4956         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4957         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4958         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4959         minsyms.c, mips-linux-tdep.c, namespace.h,
4960         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4961         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4962         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4963         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4964         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4965         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4966         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4967         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4968         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4969         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4970         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4971         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4972         procfs.c, producer.c, progspace.h, psymtab.h,
4973         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4974         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4975         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4976         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4977         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4978         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4979         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4980         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4981         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4982         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4983         target-memory.c, target.c, target.h, target/waitstatus.c,
4984         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4985         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4986         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4987         unittests/array-view-selftests.c,
4988         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4989         unittests/common-utils-selftests.c,
4990         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4991         unittests/format_pieces-selftests.c,
4992         unittests/function-view-selftests.c,
4993         unittests/lookup_name_info-selftests.c,
4994         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4995         unittests/mkdir-recursive-selftests.c,
4996         unittests/observable-selftests.c,
4997         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4998         unittests/parse-connection-spec-selftests.c,
4999         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5000         unittests/scoped_fd-selftests.c,
5001         unittests/scoped_mmap-selftests.c,
5002         unittests/scoped_restore-selftests.c,
5003         unittests/string_view-selftests.c, unittests/style-selftests.c,
5004         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5005         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5006         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5007         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5008         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5009         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5010
5011 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5014         bool value.
5015         (decode_digits_ordinary): Set explicit_line field in sal.
5016         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5017         symtab_and_line that was set on an explicit line number in
5018         assembler code.  Do always update the recorded symtab and line if
5019         we do skip the prologue.
5020
5021 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5022
5023         * breakpoint.c (set_breakpoint_location_function): Remove
5024         explicit_loc parameter.
5025         (momentary_breakpoint_from_master): Update call to
5026         set_breakpoint_location_function.
5027         (add_location_to_breakpoint): Likewise.
5028
5029 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5030
5031         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5032         required features based on default bfd type when no specific bfd
5033         is present.
5034
5035 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5036
5037         * NEWS: Mention that GDB printf and eval commands can now print
5038         C-style and Ada-style convenience var strings without
5039         calling the inferior.
5040         * printcmd.c (printf_c_string): Locally print GDB internal var
5041         instead of transiting via the inferior.
5042         (printf_wide_c_string): Likewise.
5043
5044 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5045
5046         PR breakpoints/25011
5047         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5048
5049 2019-07-04  Tom Tromey  <tom@tromey.com>
5050
5051         PR tui/24724:
5052         * tui/tui-winsource.c (tui_clear_source_content): Update.
5053         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5054         (tui_update_breakpoint_info): Update.
5055         (tui_set_exec_info_content): Update.
5056         * tui/tui-source.c (tui_set_source_content_nil): Update.
5057         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5058         has_break.
5059         * tui/tui-data.h (enum tui_bp_flag): New.
5060         (tui_bp_flags): New enum flags type.
5061         (struct tui_source_element) <break_mode>: Change type.  Rename
5062         from has_break.
5063         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5064         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5065         constants.
5066         * tui/tui-winsource.h: Fix comment.
5067
5068 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5069
5070         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5071         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5072         (store_fpregs_to_thread)
5073         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5074         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5075         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5076         (IWMMXT_REGS_SIZE): Add define.
5077         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5078         (fetch_vfp_regs, store_vfp_regs)
5079         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5080         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5081
5082 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5083
5084         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5085         defines.
5086         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5087         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5088         (ARM_INT_REGISTER_SIZE): ...to this.
5089         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5090         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5091         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5092         (arm_linux_collect_gregset, supply_nwfpe_register)
5093         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5094         defines.
5095         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5096         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5097         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5098         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5099         (arm_return_in_memory, arm_store_return_value)
5100         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5101         (arm_record_ld_st_multiple): Likewise.
5102         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5103         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5104
5105 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5106
5107         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5108         AARCH64_DISPLACED_MODIFIED_INSNS.
5109         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5110         (aarch64_displaced_step_copy_insn): Likewise.
5111         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5112         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5113         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5114         ARM_DISPLACED_MODIFIED_INSNS.
5115         * arm-tdep.c (arm_gdbarch_init): Likewise.
5116         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5117         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5118         (struct arm_displaced_step_closure): Use
5119         ARM_DISPLACED_MODIFIED_INSNS.
5120
5121 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5122
5123         * features/Makefile: Remove unused xml files.
5124         * features/aarch64.xml: Remove.
5125         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5126         * features/i386/amd64-avx-avx512.xml: Remove.
5127         * features/i386/amd64-avx-linux.xml: Remove.
5128         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5129         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5130         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5131         * features/i386/amd64-avx-mpx.xml: Remove.
5132         * features/i386/amd64-avx.xml: Remove.
5133         * features/i386/amd64-linux.xml: Remove.
5134         * features/i386/amd64-mpx-linux.xml: Remove.
5135         * features/i386/amd64-mpx.xml: Remove.
5136         * features/i386/amd64.xml: Remove.
5137         * features/i386/i386-avx-avx512-linux.xml: Remove.
5138         * features/i386/i386-avx-avx512.xml: Remove.
5139         * features/i386/i386-avx-linux.xml: Remove.
5140         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5141         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5142         * features/i386/i386-avx-mpx-linux.xml: Remove.
5143         * features/i386/i386-avx-mpx.xml: Remove.
5144         * features/i386/i386-avx.xml: Remove.
5145         * features/i386/i386-linux.xml: Remove.
5146         * features/i386/i386-mmx-linux.xml: Remove.
5147         * features/i386/i386-mmx.xml: Remove.
5148         * features/i386/i386-mpx-linux.xml: Remove.
5149         * features/i386/i386-mpx.xml: Remove.
5150         * features/i386/i386.xml: Remove.
5151         * features/i386/x32-avx-avx512-linux.xml: Remove.
5152         * features/i386/x32-avx-linux.xml: Remove.
5153         * features/i386/x32-linux.xml: Remove.
5154
5155 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5156
5157         * regformats/aarch64.dat: Remove.
5158         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5159         * regformats/i386/amd64-avx-linux.dat: Remove.
5160         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5161         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5162         * regformats/i386/amd64-linux.dat: Remove.
5163         * regformats/i386/amd64-mpx-linux.dat: Remove.
5164         * regformats/i386/amd64.dat: Remove.
5165         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5166         * regformats/i386/i386-avx-linux.dat: Remove.
5167         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5168         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5169         * regformats/i386/i386-linux.dat: Remove.
5170         * regformats/i386/i386-mmx-linux.dat: Remove.
5171         * regformats/i386/i386-mpx-linux.dat: Remove.
5172         * regformats/i386/i386.dat: Remove.
5173         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5174         * regformats/i386/x32-avx-linux.dat: Remove.
5175         * regformats/i386/x32-linux.dat: Remove.
5176
5177 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5178
5179         * aarch64-tdep.c: Remove xml self tests.
5180         * amd64-linux-tdep.c: Likewise.
5181         * amd64-tdep.c: Likewise.
5182         * i386-linux-tdep.c: Likewise.
5183         * i386-tdep.c: Likewise.
5184
5185 2019-07-03  Pedro Alves  <palves@redhat.com>
5186
5187         PR cli/24732
5188         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5189         (pipe_cmd_option_defs): New.
5190         (make_pipe_cmd_options_def_group): New.
5191         (pipe_command): Use gdb::option::process_options.
5192         (pipe_command_completer): New function.
5193         (_initialize_cli_cmds): Install completer for "pipe" command.
5194
5195 2019-07-03  Pedro Alves  <palves@redhat.com>
5196
5197         * cli/cli-option.c (union option_value) <string>: New field.
5198         (struct option_def_and_value): Add ctor, move ctor, dtor and
5199         use DISABLE_COPY_AND_ASSIGN.
5200         (option_def_and_value::clear_value): New.
5201         (parse_option, save_option_value_in_ctx, get_val_type_str)
5202         (add_setshow_cmds_for_options): Handle var_string.
5203         * cli-option.h (union option_def::var_address) <string>: New
5204         field.
5205         (struct string_option_def): New.
5206         * maint-test-options.c (struct test_options_opts): Add default
5207         ctor and use DISABLE_COPY_AND_ASSIGN.
5208         <string_opt>: New field.
5209         (test_options_opts::~test_options_opts): New.
5210         (test_options_opts::dump): Also dump "-string".
5211         (test_options_option_defs): Install "string.
5212
5213 2019-07-03  Pedro Alves  <palves@redhat.com>
5214
5215         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5216         option_value with a null enumeration.
5217         (complete_options): Save the option values in the context.
5218         (save_option_value_in_ctx): New, factored out from ...
5219         (process_options): ... here.
5220         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5221         of the function.
5222         * maint-test-options.c (test_options_opts::dump): New, factored
5223         out from ...
5224         (maintenance_test_options_command_mode): ... here.
5225         (maintenance_test_options_command_completion_result): Delete.
5226         (maintenance_test_options_command_completion_text): Update
5227         comment.
5228         (maintenance_show_test_options_completion_result): Change
5229         prototype.  Just print
5230         maintenance_test_options_command_completion_text.
5231         (save_completion_result): New.
5232         (maintenance_test_options_completer_mode): Pass options context to
5233         complete_options, and then save a dump.
5234         (_initialize_maint_test_options): Use add_cmd to install "maint
5235         show test-options-completion-result".
5236
5237 2019-07-03  Pedro Alves  <palves@redhat.com>
5238
5239         * NEWS (New commands): Mention "with" and "maint with".
5240         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5241         (with_command, with_command_completer): New.
5242         (pipe_command): Adjust to new repeat_previous
5243         interface.
5244         (_initialize_cli_cmds): Install the "with" command and its "w"
5245         alias.
5246         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5247         declarations.
5248         * cli/cli-setshow.c (parse_cli_var_uinteger)
5249         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5250         argument strings for all var_types.
5251         (get_setshow_command_value_string): New, factored out from ...
5252         (do_show_command): ... this.
5253         * cli/cli-setshow.h: Include <string>.
5254         (get_setshow_command_value_string): Declare.
5255         * command.h (repeat_previous): Now returns const char *.  Adjust
5256         comment.
5257         * maint.c: Include "cli/cli-cmds.h".
5258         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5259         (_initialize_maint_cmds): Register the "maintenance with" command.
5260         * top.c (repeat_previous): Move bits from pipe_command here:
5261         Return the saved command line, if any; error out if there's no
5262         command to relaunch.
5263
5264 2019-07-03  Pedro Alves  <palves@redhat.com>
5265
5266         * NEWS (New commands): Mention "maint set/show test-settings"
5267         instead of "maint test-settings".
5268         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5269         (maintenance_test_settings_set_list): Rename to ...
5270         (maintenance_set_test_settings_list): ... this.
5271         (maintenance_test_settings_show_list): Rename to  ...
5272         (maintenance_show_test_settings_list): ... this.
5273         (maintenance_test_settings_cmd): Delete.
5274         (maintenance_test_settings_set_cmd): ...
5275         (maintenance_set_test_settings_cmd): ... this.
5276         (maintenance_test_settings_show_cmd): ...
5277         (maintenance_show_test_settings_cmd): ... this.
5278         (maintenance_test_settings_show_value_cmd):
5279         (maintenance_show_test_settings_value_cmd): ... this.
5280         (_initialize_maint_test_settings): No longer install the "maint
5281         test-settings" prefix command.  Rename "maint test-settings set"
5282         to "maint set test-settings", and "maint test-settings show" to
5283         "maint show test-settings".  Adjust all subcommands.
5284
5285 2019-07-03  Pedro Alves  <palves@redhat.com>
5286
5287         * maint-test-settings.c: Fix file's intro comment.  Replace all
5288         references to "test-options" with references to "test-settings",
5289         in comments.
5290
5291 2019-07-03  Pedro Alves  <palves@redhat.com>
5292
5293         * maint-test-settings.c (maintenance_test_settings_xxx)
5294         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5295         New.
5296         (maintenance_test_settings_enums): Use them.
5297         (maintenance_test_settings_enum): Default to
5298         maintenance_test_settings_xxx.
5299         (_initialize_maint_test_settings): Initialize
5300         MAINTENANCE_TEST_SETTINGS_FILENAME.
5301
5302 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5303
5304         * breakpoint.h (remove_breakpoints_inf): Change return type to
5305         void, move function documentation here.
5306         * breakpoint.c (remove_breakpoints_inf): Change return type to
5307         void, move function documentation to header.
5308
5309 2019-07-02  Pedro Alves  <palves@redhat.com>
5310
5311         * NEWS (Completion improvements): Mention "info threads".
5312         * thread.c (struct info_threads_opts, info_threads_option_defs)
5313         (make_info_threads_options_def_group): New.
5314         (info_threads_command): Use gdb::option::process_options.
5315         (info_threads_command_completer): New.
5316         (_initialize_thread): Use gdb::option::build_help to build the
5317         help text for "info threads".
5318
5319 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5320
5321         * defs.h (generic_load): Move from here...
5322         * symfile.h (generic_load): ... to here.  Rename name parameter
5323         to args.
5324         * symfile.c (generic_load): Add comment.
5325
5326 2019-07-01  Tom Tromey  <tromey@adacore.com>
5327
5328         * dwarf2read.c
5329         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5330         declaration of without_params.  Fix formatting.
5331
5332 2019-07-01  Tom Tromey  <tromey@adacore.com>
5333
5334         * ada-exp.y (find_primitive_type): Update.
5335         * ada-lang.h (ada_lookup_symbol): Update.
5336         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5337         parameter.
5338         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5339
5340 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5341
5342         PR breakpoints/24541
5343         * gdbarch.c: Regenerate.
5344         * gdbarch.h: Regenerate.
5345         * gdbarch.sh: Add 'stap_adjust_register'.
5346         * i386-tdep.c: Include '<unordered_set>'.
5347         (i386_stap_adjust_register): New function.
5348         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5349         * stap-probe.c (stap_parse_register_operand): Call
5350         'gdbarch_stap_adjust_register'.
5351
5352 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5353
5354         PR python/24742
5355         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5356         * python/python.c (do_start_initialization): Use 'xmalloc'
5357         instead of 'PyMem_Malloc'.
5358
5359 2019-06-28  Tom Tromey  <tromey@adacore.com>
5360
5361         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5362         for Ada.
5363
5364 2019-06-27  Tom Tromey  <tromey@adacore.com>
5365
5366         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5367         objfile_key.
5368         (arm_find_mapping_symbol, arm_record_special_symbol)
5369         (_initialize_arm_tdep): Update.
5370         (arm_objfile_data_free): Remove.
5371
5372 2019-06-27  Tom Tromey  <tromey@adacore.com>
5373
5374         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5375         to cp_print_static_field.
5376
5377 2019-06-26  Tom Tromey  <tromey@adacore.com>
5378
5379         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5380         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5381         declare.
5382
5383 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5384
5385         * features/aarch64-core.c (create_feature_aarch64_core):
5386         Regenerate.
5387         * features/aarch64-core.xml: Add cpsr flags.
5388
5389 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5390
5391         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5392         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5393
5394 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5395
5396         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5397         field.
5398         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5399         use.
5400         (arm_record_special_symbol): Don't insert new symbol in sorted
5401         position, push it at the end.
5402
5403 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5404
5405         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5406         (arm_mapping_symbol_s): Remove.
5407         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5408         (arm_mapping_symbol_vec): New typedef.
5409         (struct arm_per_objfile): Add constructor.
5410         <section_maps>: Change type to
5411         std::unique_ptr<arm_mapping_symbol_vec[]>.
5412         (arm_compare_mapping_symbols): Remove.
5413         (arm_find_mapping_symbol): Adjust to section_maps type change.
5414         (arm_objfile_data_free): Call delete on arm_per_objfile.
5415         (arm_record_special_symbol): Adjust to section_maps type change.
5416         Allocate arm_per_objfile with new.
5417
5418 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5419
5420         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5421         with the command prefix.
5422
5423 2019-06-25  Tom Tromey  <tom@tromey.com>
5424
5425         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5426         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5427
5428 2019-06-25  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5431         type.
5432         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5433         protected.
5434
5435 2019-06-25  Tom Tromey  <tom@tromey.com>
5436
5437         * tui/tui-winsource.c
5438         (tui_source_window_base::set_is_exec_point_at): Add check against
5439         LOA_ADDRESS.
5440
5441 2019-06-25  Tom Tromey  <tom@tromey.com>
5442
5443         * tui/tui-source.c (tui_set_source_content): Don't check before
5444         xfree.
5445         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5446
5447 2019-06-25  Tom Tromey  <tom@tromey.com>
5448
5449         * tui/tui-winsource.h (tui_update_source_window_as_is)
5450         (tui_alloc_source_buffer, tui_line_is_displayed)
5451         (tui_addr_is_displayed): Change type of win_info.
5452         * tui/tui-winsource.c (tui_update_source_window_as_is)
5453         (tui_clear_source_content, tui_show_source_line)
5454         (tui_show_source_content, tui_source_window_base::refill)
5455         (tui_source_window_base::set_is_exec_point_at)
5456         (tui_source_window_base::set_is_exec_point_at)
5457         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5458         (tui_alloc_source_buffer, tui_line_is_displayed)
5459         (tui_addr_is_displayed): Change type of win_info.  Update.
5460         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5461         (tui_source_window_base::do_make_visible_with_new_height):
5462         Update.
5463         * tui/tui-source.c (tui_set_source_content)
5464         (tui_set_source_content_nil)
5465         (tui_source_window::do_scroll_vertical): Update.
5466         * tui/tui-layout.c (show_layout): Update.
5467         * tui/tui-disasm.c (tui_set_disassem_content)
5468         (tui_disasm_window::do_scroll_vertical): Update.
5469         * tui/tui-data.h (tui_win_content): Remove.
5470         (struct tui_gen_win_info) <content, content_size>: Remove.
5471         (struct tui_source_element): Add initializers and destructor.
5472         (union tui_which_element, struct tui_win_element): Remove.
5473         (struct tui_source_window_base) <content>: New field.
5474         (struct tui_data_window): Remove destructor.
5475         (tui_alloc_content, tui_free_win_content)
5476         (tui_free_all_source_wins_content): Don't declare.
5477         * tui/tui-data.c (tui_initialize_static_data): Update.
5478         (init_content_element, tui_alloc_content): Remove.
5479         (~tui_gen_win_info): Update.
5480         (~tui_data_window, tui_free_all_source_wins_content)
5481         (tui_free_win_content, free_content, free_content_elements):
5482         Remove.
5483
5484 2019-06-25  Tom Tromey  <tom@tromey.com>
5485
5486         * tui/tui-winsource.h (tui_clear_source_content)
5487         (tui_erase_source_content, tui_show_source_content): Change type
5488         of win_info.
5489         * tui/tui-winsource.c (tui_clear_source_content)
5490         (tui_erase_source_content, tui_show_source_content): Change type
5491         of win_info.
5492         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5493         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5494         win_info.
5495         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5496         win_info.
5497         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5498
5499 2019-06-25  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui-winsource.c (tui_clear_source_content)
5502         (tui_source_window_base::set_is_exec_point_at): Update.
5503         * tui/tui-source.c (tui_set_source_content_nil): Update.
5504         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5505         a bool.
5506         * tui/tui-data.c (init_content_element): Update.
5507
5508 2019-06-25  Tom Tromey  <tom@tromey.com>
5509
5510         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5511         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5512         * tui/tui-layout.c (init_and_make_win): Update.
5513         * tui/tui.h (enum tui_win_type): Update.
5514         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5515         tui_win_is_auxillary.
5516         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5517         tui_win_is_auxillary.
5518
5519 2019-06-25  Tom Tromey  <tom@tromey.com>
5520
5521         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5522         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5523         (tui_delete_data_content_windows, tui_display_all_data)
5524         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5525         Update.
5526         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5527         * tui/tui-regs.c (tui_last_regs_line_no)
5528         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5529         (tui_show_registers): Update.
5530         (tui_show_register_group): Return void.  Update.
5531         (tui_display_registers_from, tui_display_reg_element_at_line)
5532         (tui_display_registers_from_line, tui_check_register_values):
5533         Update.
5534         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5535         member.
5536         (struct tui_data_window) <regs_content>: Now a std::vector.
5537         <regs_content_count>: Remove.
5538         (tui_add_content_elements, tui_free_data_content): Don't declare.
5539         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5540         (init_content_element): Remove DATA_WIN case.  Add assert.
5541         (tui_add_content_elements): Remove.
5542         (tui_data_window): Update.
5543         (tui_free_data_content): Remove.
5544         (free_content_elements): Remove DATA_WIN case.
5545
5546 2019-06-25  Tom Tromey  <tom@tromey.com>
5547
5548         * tui/tui-data.c (tui_data_item_window): Update.
5549         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5550         * tui/tui-windata.c (tui_display_all_data)
5551         (tui_display_data_from_line): Update.
5552         (tui_check_data_values): Remove.
5553         * tui/tui-regs.c (tui_show_register_group)
5554         (tui_display_reg_element_at_line): Update.
5555         * tui/tui-hooks.c (tui_register_changed)
5556         (tui_refresh_frame_and_register_information): Call
5557         tui_check_register_values.
5558         * tui/tui-data.h (struct tui_data_window) <data_content,
5559         data_content_count, data_type>: Remove.
5560         (enum tui_data_type): Remove.
5561
5562         * tui/tui-data.c (tui_data_window::clear_detail)
5563         (~tui_data_window): Update.
5564
5565 2019-06-25  Tom Tromey  <tom@tromey.com>
5566
5567         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5568         declare.
5569         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5570         Rename from tui_first_data_item_displayed.  Update.
5571         (tui_data_window::refresh_all)
5572         (tui_data_window::do_scroll_vertical): Update.
5573         * tui/tui-data.h (struct tui_data_window)
5574         <first_data_item_displayed>: Declare new method.
5575
5576 2019-06-25  Tom Tromey  <tom@tromey.com>
5577
5578         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5579         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5580         contents...
5581         (tui_initialize_static_data): ...here.
5582
5583 2019-06-25  Tom Tromey  <tom@tromey.com>
5584
5585         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5586         (tui_display_registers_from, tui_check_register_values): Update.
5587         (tui_display_register): Remove win_info parameter; update.
5588         (tui_get_register): Change type of parameters.
5589         * tui/tui-data.h (struct tui_data_element): Remove.
5590         (union tui_which_element) <data>: Remove.
5591         <data_window>: Change type.
5592         (struct tui_data_item_window): New.
5593         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5594         case.  Add assert.
5595         (~tui_data_item_window): New destructor.
5596         (free_content_elements): Remove DATA_ITEM_WIN case.
5597
5598 2019-06-25  Tom Tromey  <tom@tromey.com>
5599
5600         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5601         Remove.
5602
5603 2019-06-25  Tom Tromey  <tom@tromey.com>
5604
5605         * tui/tui-data.h (struct tui_command_element): Remove.
5606         (union tui_which_element) <command>: Remove.
5607         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5608         assert.
5609         (free_content_elements): Remove CMD_WIN case.
5610
5611 2019-06-25  Tom Tromey  <tom@tromey.com>
5612
5613         * tui/tui-layout.c (tui_set_layout): Update.
5614         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5615         * tui/tui-data.c (layout_def): Update.
5616
5617 2019-06-25  Tom Tromey  <tom@tromey.com>
5618
5619         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5620         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5621         (tui_source_window_base::set_new_height): Update.
5622         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5623         Update.
5624         (tui_set_locator_fullname, tui_set_locator_info)
5625         (tui_show_frame_info): Update.
5626         * tui/tui-source.c (tui_set_source_content)
5627         (tui_source_is_displayed): Update.
5628         * tui/tui-layout.c (show_source_disasm_command, show_data)
5629         (show_source_or_disasm_and_command): Update.
5630         * tui/tui-disasm.c (tui_set_disassem_content)
5631         (tui_get_begin_asm_address): Update.
5632         * tui/tui-data.h (struct tui_locator_element): Remove.
5633         (union tui_which_element) <locator>: Remove.
5634         (struct tui_locator_window): New.
5635         (tui_locator_win_info_ptr): Change return type.
5636         * tui/tui-data.c (_locator): Change type.
5637         (tui_locator_win_info_ptr): Change return type.
5638         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5639         (tui_alloc_content): Add assert.
5640
5641 2019-06-25  Tom Tromey  <tom@tromey.com>
5642
5643         * tui/tui-winsource.c
5644         (tui_exec_info_window::maybe_allocate_content): New method.
5645         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5646         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5647         (make_source_or_disasm_window): Add cast.
5648         * tui/tui-data.h (union tui_which_element) <simple_string>:
5649         Remove.
5650         (struct tui_source_info): New.
5651         (struct tui_source_window_base) <execution_info>: Change type.
5652         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5653         case, and add assert.
5654         (tui_alloc_content): Add assert.
5655
5656 2019-06-25  Tom Tromey  <tom@tromey.com>
5657
5658         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5659         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5660         * tui/tui-data.c (tui_alloc_win_info): Remove.
5661
5662 2019-06-25  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5665         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5666         can_highlight.
5667
5668 2019-06-25  Tom Tromey  <tom@tromey.com>
5669
5670         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5671         make_visible_with_new_height method.
5672         (tui_win_info::make_visible_with_new_height): New method.
5673         (tui_source_window_base::do_make_visible_with_new_height)
5674         (tui_data_window::do_make_visible_with_new_height)
5675         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5676         (make_visible_with_new_height): Remove.
5677         (tui_resize_all, tui_adjust_win_heights): Use
5678         make_visible_with_new_height method.
5679         * tui/tui-data.h (struct tui_win_info)
5680         <do_make_visible_with_new_height, make_visible_with_new_height>:
5681         New methods.
5682         (struct tui_source_window_base, struct tui_data_window)
5683         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5684         methods.
5685
5686 2019-06-25  Tom Tromey  <tom@tromey.com>
5687
5688         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5689         method.
5690         (update_tab_width): Call update_tab_width method.
5691         * tui/tui-data.h (struct tui_win_info)
5692         (struct tui_source_window_base) <update_tab_width>: New methods.
5693
5694 2019-06-25  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5697         parameter.
5698         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5699         parameter.
5700         (tui_gen_win_info::make_visible): Update.
5701         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5702         parameter.
5703         * tui/tui-data.h (enum tui_box): New enum.
5704         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5705
5706 2019-06-25  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5709         init_and_make_win for EXEC_INFO_WIN.
5710         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5711         longer inline.
5712         (struct tui_win_info) <~tui_win_info>: Inline.
5713         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5714         Don't declare.
5715         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5716         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5717         Remove.
5718         (tui_initialize_static_data): Update.
5719         (~tui_gen_win_info): Handle more cleanup here.
5720         (~tui_source_window_base): Delete "execution_info".
5721         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5722
5723 2019-06-25  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-layout.c (make_command_window): Don't set
5726         can_highlight.
5727         (show_source_disasm_command): Call the reset method.
5728         (show_data): Don't set can_highlight.  Call the reset method.
5729         (tui_gen_win_info::reset): Rename from init_gen_win_info
5730         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5731         (show_source_or_disasm_and_command): Call the reset method.
5732         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5733         (struct tui_cmd_window): Set can_highlight.
5734
5735 2019-06-25  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5738         from make_visible.
5739         (tui_make_visible, tui_make_invisible): Rewrite.
5740         (tui_win_info::make_visible): Remove.
5741         (tui_source_window_base::make_visible): Update.
5742         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5743         method.  Moved from...
5744         (struct tui_win_info) <make_visible>: ...here.
5745
5746 2019-06-25  Tom Tromey  <tom@tromey.com>
5747
5748         * tui/tui-winsource.c
5749         (tui_source_window_base::do_scroll_horizontal): Remove direction
5750         parameter.
5751         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5752         direction parameter.
5753         * tui/tui-win.c (tui_win_info::forward_scroll)
5754         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5755         (tui_win_info::right_scroll): Update.
5756         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5757         direction parameter.
5758         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5759         direction parameter.
5760         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5761         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5762         Remove direction parameter.
5763         (struct tui_source_window_base, struct tui_source_window)
5764         (struct tui_disasm_window, struct tui_data_window)
5765         (struct tui_cmd_window): Update.
5766
5767 2019-06-25  Tom Tromey  <tom@tromey.com>
5768
5769         * tui/tui-winsource.h (tui_set_exec_info_content)
5770         (tui_show_exec_info_content, tui_erase_exec_info_content)
5771         (tui_clear_exec_info_content, tui_update_exec_info): Change
5772         argument to tui_source_window_base.
5773         * tui/tui-winsource.c (tui_set_exec_info_content)
5774         (tui_show_exec_info_content, tui_erase_exec_info_content)
5775         (tui_clear_exec_info_content, tui_update_exec_info): Change
5776         argument to tui_source_window_base.
5777
5778 2019-06-25  Tom Tromey  <tom@tromey.com>
5779
5780         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5781         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5782
5783 2019-06-25  Tom Tromey  <tom@tromey.com>
5784
5785         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5786         check.
5787
5788 2019-06-25  Tom Tromey  <tom@tromey.com>
5789
5790         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5791         type to void.
5792         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5793         type to void.
5794         * tui/tui-source.c (tui_set_source_content): Update.
5795         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5796
5797 2019-06-25  Tom Tromey  <tom@tromey.com>
5798
5799         * tui/tui-win.c (window_name_completer, tui_set_focus)
5800         (tui_all_windows_info): Use name method.
5801         * tui/tui-data.h (struct tui_gen_win_info)
5802         (struct tui_source_window, struct tui_disasm_window)
5803         (struct tui_data_window, struct tui_cmd_window) <name>: New
5804         method.
5805         (tui_win_name): Don't declare.
5806         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5807         (tui_win_name): Remove.
5808
5809 2019-06-25  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-winsource.h (tui_update_source_window)
5812         (tui_update_source_window_as_is): Change parameter type.
5813         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5814         to be a tui_source_window_base.
5815         (tui_update_source_window_as_is): Likewise.
5816         * tui/tui-win.c (make_visible_with_new_height): Update.
5817
5818 2019-06-25  Tom Tromey  <tom@tromey.com>
5819
5820         * tui/tui-winsource.c (tui_erase_source_content)
5821         (tui_show_source_content, tui_show_exec_info_content)
5822         (tui_erase_exec_info_content): Use refresh_window method.
5823         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5824         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5825         from tui_refresh_win.
5826         (tui_data_window::refresh_window): New method.
5827         (tui_win_info::refresh, tui_source_window_base::refresh)
5828         (tui_refresh_all): Use refresh_window method.
5829         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5830         method.
5831         * tui/tui-regs.c (tui_display_register): Call refresh_window
5832         method.
5833         * tui/tui-layout.c (show_source_disasm_command)
5834         (show_source_or_disasm_and_command): Call refresh_window method.
5835         * tui/tui-data.h (struct tui_gen_win_info)
5836         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5837         New method.
5838
5839 2019-06-25  Tom Tromey  <tom@tromey.com>
5840
5841         * tui/tui.c (tui_rl_other_window, tui_enable)
5842         (tui_is_window_visible, tui_get_command_dimension): Update.
5843         * tui/tui-winsource.c (tui_update_source_window_as_is)
5844         (tui_clear_source_content, tui_erase_source_content)
5845         (tui_show_source_line, tui_source_window_base::refill)
5846         (tui_source_window_base::do_scroll_horizontal)
5847         (tui_source_window_base::set_is_exec_point_at)
5848         (tui_update_breakpoint_info, tui_set_exec_info_content)
5849         (tui_alloc_source_buffer, tui_line_is_displayed)
5850         (tui_addr_is_displayed): Update.
5851         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5852         (tui_check_and_display_highlight_if_needed)
5853         (tui_win_info::make_visible, tui_win_info::refresh)
5854         (tui_refresh_all): Update.
5855         * tui/tui-windata.c (tui_first_data_item_displayed)
5856         (tui_delete_data_content_windows, tui_erase_data_content)
5857         (tui_display_all_data, tui_data_window::refresh_all)
5858         (tui_check_data_values): Update.
5859         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5860         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5861         (tui_win_info::backward_scroll, tui_refresh_all_win)
5862         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5863         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5864         (tui_source_window_base::set_new_height)
5865         (tui_data_window::set_new_height)
5866         (make_invisible_and_set_new_height)
5867         (make_visible_with_new_height, new_height_ok)
5868         (parse_scrolling_args): Update.
5869         * tui/tui-stack.c (tui_show_frame_info): Update.
5870         * tui/tui-source.c (tui_set_source_content)
5871         (tui_set_source_content_nil, tui_source_is_displayed)
5872         (tui_source_window::do_scroll_vertical): Update.
5873         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5874         (tui_display_registers_from, tui_display_reg_element_at_line)
5875         (tui_check_register_values, tui_reg_command): Update.
5876         * tui/tui-layout.c (tui_default_win_height)
5877         (show_source_disasm_command, show_data, init_and_make_win)
5878         (show_source_or_disasm_and_command): Update.
5879         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5880         (tui_redisplay_readline, tui_mld_flush)
5881         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5882         (tui_getc): Update.
5883         * tui/tui-disasm.c (tui_set_disassem_content)
5884         (tui_disasm_window::do_scroll_vertical): Update.
5885         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5886         Now virtual.
5887         (struct tui_win_info): Derive from tui_gen_win_info.
5888         <~tui_win_info>: Mark as override.
5889         <generic>: Remove member.
5890         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5891         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5892         (~tui_data_window, ~tui_win_info)
5893         (tui_free_all_source_wins_content): Update.
5894         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5895
5896 2019-06-25  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-layout.c (init_and_make_win): Use new.
5899         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5900         destructor, initializers.
5901         (tui_alloc_generic_win_info): Don't declare.
5902         * tui/tui-data.c (_locator): Add argument to constructor.
5903         (source_win, disasm_win): New globals.
5904         (exec_info): Remove.
5905         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5906         Update.
5907         (tui_alloc_generic_win_info): Remove.
5908         (init_content_element): Use new.
5909         (tui_win_info::tui_win_info): Update.
5910         (free_content_elements) <case DATA_WIN>: Use delete.
5911
5912 2019-06-25  Tom Tromey  <tom@tromey.com>
5913
5914         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5915         * tui/tui-windata.c (tui_first_data_item_displayed)
5916         (tui_delete_data_content_windows): Update.
5917         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5918         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5919         (tui_display_registers_from, tui_check_register_values): Update.
5920         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5921         pointer.
5922         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5923         window.
5924         (tui_free_data_content): Update.
5925         (free_content_elements) <case DATA_WIN>: Free the window.
5926
5927 2019-06-25  Tom Tromey  <tom@tromey.com>
5928
5929         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5930         Update.
5931         * tui/tui-layout.c (make_command_window)
5932         (show_source_disasm_command, show_data, init_and_make_win)
5933         (show_source_or_disasm_and_command): Update.
5934         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5935         method.
5936         <can_highight, is_highlighted>: Now bool.
5937         (tui_set_win_highlight): Don't declare.
5938         * tui/tui-data.c (tui_set_win_highlight): Remove.
5939
5940 2019-06-25  Tom Tromey  <tom@tromey.com>
5941
5942         * tui/tui-wingeneral.c (make_visible): Remove check of window
5943         type.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui-win.c (tui_win_info::max_height)
5948         (tui_cmd_window::max_height): New methods.
5949         (new_height_ok): Call max_height.
5950         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5951         <max_height>: New method.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-win.c (tui_source_window_base::set_new_height)
5956         (tui_data_window::set_new_height): New methods.
5957         (make_invisible_and_set_new_height): Call set_new_height method.
5958         * tui/tui-data.h (struct tui_win_info)
5959         (struct tui_source_window_base, struct tui_data_window)
5960         <set_new_height>: New method.
5961
5962 2019-06-25  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5965         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5966         tui_refresh_data_win.
5967         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5968         method.
5969         (tui_refresh_all_win): Call the refresh_all method.
5970         (tui_set_focus): Likewise.
5971         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5972         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5973         Likewise.
5974
5975 2019-06-25  Tom Tromey  <tom@tromey.com>
5976
5977         * tui/tui-winsource.h (tui_refill_source_window)
5978         (tui_set_is_exec_point_at): Don't declare.
5979         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5980         (tui_source_window_base::refill): Rename from
5981         tui_refill_source_window.
5982         (tui_source_window_base::do_scroll_horizontal): Update.
5983         (tui_source_window_base::set_is_exec_point_at): Rename from
5984         tui_set_is_exec_point_at.
5985         (tui_update_all_breakpoint_info): Update.
5986         * tui/tui-stack.c (tui_show_frame_info): Update.
5987         * tui/tui-layout.c (show_data): Add cast.
5988         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5989         * tui/tui-data.h (struct tui_source_window_base) <refill,
5990         set_is_exec_point_at>: New methods.
5991         (tui_source_windows, tui_add_to_source_windows): Update types.
5992         (tui_add_to_source_windows): Remove redundant declaration.
5993         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5994         (tui_source_windows): Change return type.
5995         (tui_clear_source_windows_detail): Update.
5996         (tui_add_to_source_windows): Change type of parameter.
5997         (tui_free_all_source_wins_content): Update.
5998
5999 2019-06-25  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-wingeneral.c (tui_win_info::refresh)
6002         (tui_source_window_base::refresh): New methods.
6003         (tui_refresh_all): Call the refresh method.
6004         * tui/tui-data.h (struct tui_win_info)
6005         (struct tui_source_window_base) <refresh>: New method.
6006
6007 2019-06-25  Tom Tromey  <tom@tromey.com>
6008
6009         * tui/tui.h (tui_is_window_visible): Return bool.
6010         * tui/tui.c (tui_is_window_visible): Return bool.
6011         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6012         (tui_make_visible, tui_make_invisible)
6013         (tui_win_info::make_visible)
6014         (tui_source_window_base::make_visible, make_all_visible)
6015         (tui_make_all_visible, tui_make_all_invisible): Update.
6016         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6017         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6018         bool.
6019         (struct tui_win_info, struct tui_source_window_base)
6020         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6021         * tui/tui-data.c (tui_init_generic_part): Update.
6022
6023 2019-06-25  Tom Tromey  <tom@tromey.com>
6024
6025         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6026         (tui_source_window_base::make_visible): New methods.
6027         (make_all_visible): Make method call.
6028         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6029         (struct tui_source_window_base, struct tui_cmd_window): Override
6030         make_visible.
6031         (tui_win_is_source_type): Don't declare.
6032         * tui/tui-data.c (tui_win_is_source_type): Remove.
6033
6034 2019-06-25  Tom Tromey  <tom@tromey.com>
6035
6036         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6037         NULL check.
6038
6039 2019-06-25  Tom Tromey  <tom@tromey.com>
6040
6041         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6042         Inline constructor.  Add initializers for members.
6043         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6044         constructors; now inline in class.
6045
6046 2019-06-25  Tom Tromey  <tom@tromey.com>
6047
6048         * tui/tui-regs.c (tui_show_registers): Update.
6049         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6050         bool.
6051         * tui/tui-data.c (tui_data_window::clear_detail)
6052         (tui_data_window): Update.
6053
6054 2019-06-25  Tom Tromey  <tom@tromey.com>
6055
6056         * tui/tui-windata.c (tui_display_all_data)
6057         (tui_display_data_from_line, tui_display_data_from)
6058         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6059         Update.
6060         * tui/tui-regs.c (tui_last_regs_line_no)
6061         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6062         (tui_show_registers, tui_show_register_group)
6063         (tui_display_registers_from, tui_display_reg_element_at_line)
6064         (tui_display_registers_from_line, tui_check_register_values)
6065         (tui_reg_next, tui_reg_prev): Update.
6066         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6067         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6068         tui_data_window.
6069         (struct tui_win_info) <detail>: Remove.  Add new fields from
6070         tui_data_info.
6071         (TUI_DATA_WIN): Add cast.
6072         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6073         (~tui_data_window): Simplify.
6074
6075 2019-06-25  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-layout.c (show_source_disasm_command)
6078         (show_source_or_disasm_and_command): Update.
6079         * tui/tui-io.c (update_cmdwin_start_line)
6080         (tui_redisplay_readline): Update.
6081         * tui/tui-data.h (struct tui_command_info): Remove.
6082         (struct tui_win_info) <detail>: Remove command_info member.
6083         (struct tui_data_window) <start_line>: New member, from
6084         tui_command_info.
6085         (TUI_CMD_WIN): Add casts.
6086
6087 2019-06-25  Tom Tromey  <tom@tromey.com>
6088
6089         * tui/tui-winsource.c (tui_update_source_window)
6090         (tui_refill_source_window)
6091         (tui_source_window_base::do_scroll_horizontal)
6092         (tui_update_breakpoint_info, tui_set_exec_info_content)
6093         (tui_show_exec_info_content, tui_erase_exec_info_content)
6094         (tui_clear_exec_info_content): Update.
6095         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6096         Update.
6097         * tui/tui-win.c (make_invisible_and_set_new_height)
6098         (make_visible_with_new_height): Update.
6099         * tui/tui-source.c (tui_set_source_content)
6100         (tui_show_symtab_source): Update.
6101         * tui/tui-layout.c (extract_display_start_addr)
6102         (show_source_disasm_command, show_data)
6103         (make_source_or_disasm_window)
6104         (show_source_or_disasm_and_command): Update.
6105         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6106         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6107         "gdbarch".
6108         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6109         to tui_source_window_base.
6110         (struct tui_win_info) <detail>: Remove source_info member.
6111         (struct tui_source_window_base) <has_locator>: Inline.
6112         Move contents from tui_source_info; rename has_locator member to
6113         m_has_locator.
6114         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6115         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6116         header file.
6117         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6118         Simplify.
6119         (tui_free_all_source_wins_content): Cast to
6120         tui_source_window_base.
6121
6122 2019-06-25  Tom Tromey  <tom@tromey.com>
6123
6124         * tui/tui-win.c (make_invisible_and_set_new_height)
6125         (make_visible_with_new_height): Call has_locator method.
6126         * tui/tui-layout.c (show_source_disasm_command, show_data)
6127         (show_source_or_disasm_and_command): Update for bool change.
6128         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6129         (tui_win_info) <has_locator>: New method.
6130         (struct tui_source_window_base) <has_locator>: New method.
6131         (tui_win_has_locator): Don't declare.
6132         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6133         from tui_win_has_locator.
6134         (tui_source_window_base): Use false, not FALSE.
6135
6136 2019-06-25  Tom Tromey  <tom@tromey.com>
6137
6138         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6139         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6140         clear_detail method directly.
6141         (tui_clear_win_detail): Remove.
6142
6143 2019-06-25  Tom Tromey  <tom@tromey.com>
6144
6145         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6146         "this", not TUI_DISASM_WIN.
6147
6148 2019-06-25  Tom Tromey  <tom@tromey.com>
6149
6150         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6151         declare.
6152         * tui/tui-winsource.c
6153         (tui_source_window_base::do_scroll_horizontal): Rename from
6154         tui_horizontal_source_scroll.
6155         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6156         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6157         from tui_vertical_data_scroll.
6158         * tui/tui-win.h (tui_scroll): Don't declare.
6159         * tui/tui-win.c (tui_win_info::forward_scroll)
6160         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6161         (tui_win_info::right_scroll): Rename and update.
6162         (tui_scroll_forward_command, tui_scroll_backward_command)
6163         (tui_scroll_left_command, tui_scroll_right_command): Update.
6164         (tui_scroll): Remove.
6165         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6166         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6167         from tui_vertical_source_scroll.
6168         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6169         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6170         from tui_vertical_disassem_scroll.
6171         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6172         do_scroll_horizontal>: New methods.
6173         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6174         Likewise.
6175         (struct tui_source_window_base): Add do_scroll_horizontal.
6176         (struct tui_source_window, struct tui_disasm_window): Add
6177         do_scroll_vertical.
6178         (struct tui_data_window, struct tui_cmd_window): Add
6179         do_scroll_horizontal and do_scroll_vertical.
6180         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6181
6182 2019-06-25  Tom Tromey  <tom@tromey.com>
6183
6184         * tui/tui-data.h (struct tui_source_window_base): New struct.
6185         (struct tui_source_window): Derive from tui_source_window_base.
6186         (struct tui_disasm_window): New struct.
6187         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6188         from tui_source_window::clear_detail.
6189         (tui_source_window_base): Rename from tui_source_window.
6190         (~tui_source_window_base): Rename from ~tui_source_window.
6191         (tui_alloc_win_info): Create a tui_disasm_window.
6192
6193 2019-06-25  Tom Tromey  <tom@tromey.com>
6194
6195         * tui/tui-data.h (struct tui_source_window)
6196         (struct tui_data_window): Declare destructors.
6197         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6198         destructors.
6199         (tui_win_info): Simplify.
6200
6201 2019-06-25  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-winsource.c (tui_display_main)
6204         (tui_update_source_windows_with_addr)
6205         (tui_update_all_breakpoint_info): Update.
6206         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6207         (new_height_ok, parse_scrolling_args): Update.
6208         * tui/tui-stack.c (tui_show_frame_info): Update.
6209         * tui/tui-data.h (struct tui_list): Remove.
6210         (tui_source_windows): Return a reference to a std::vector.
6211         * tui/tui-data.c (source_windows): Now a std::vector.
6212         (tui_source_windows): Change return type.
6213         (tui_clear_source_windows): Rewrite.
6214         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6215         (tui_free_all_source_wins_content): Rewrite.
6216
6217 2019-06-25  Tom Tromey  <tom@tromey.com>
6218
6219         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6220         (struct tui_data_window, struct tui_cmd_window): Declare
6221         clear_detail method.
6222         * tui/tui-data.c (tui_source_window::clear_detail)
6223         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6224         methods.
6225         (tui_clear_win_detail): Simplify.
6226
6227 2019-06-25  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui-layout.c (make_source_window, make_disasm_window)
6230         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6231         Return the new window.
6232         (show_source_disasm_command, show_data)
6233         (show_source_or_disasm_and_command): Update.
6234
6235 2019-06-25  Tom Tromey  <tom@tromey.com>
6236
6237         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6238         parameter.  Return the new window.
6239         (show_source_disasm_command): Update and remove NULL check.
6240         (show_source_or_disasm_and_command): Update.
6241
6242 2019-06-25  Tom Tromey  <tom@tromey.com>
6243
6244         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6245
6246 2019-06-25  Tom Tromey  <tom@tromey.com>
6247
6248         * tui/tui-data.h (struct tui_win_info): Make constructor
6249         protected.  Make destructor virtual.  Add initializers.
6250         (tui_source_window, tui_data_window, tui_cmd_window): New
6251         classes.
6252         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6253         constructor.  Add "type" parameter.
6254         (tui_source_window, tui_data_window, tui_cmd_window): New
6255         constructors.
6256         (tui_alloc_win_info): Instantiate the appropriate subclass.
6257
6258 2019-06-25  Tom Tromey  <tom@tromey.com>
6259
6260         * tui/tui-win.c (tui_resize_all): Use delete.
6261         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6262         destructor.
6263         (tui_free_window): Don't declare.
6264         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6265         Update.
6266
6267 2019-06-25  Tom Tromey  <tom@tromey.com>
6268
6269         * tui/tui-data.h (struct tui_win_info): Add constructor.
6270         * tui/tui-data.c (tui_alloc_win_info): Use new.
6271         (tui_free_window): Use delete.
6272
6273 2019-06-22  Tom Tromey  <tom@tromey.com>
6274
6275         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6276         declare.
6277         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6278
6279 2019-06-22  Tom Tromey  <tom@tromey.com>
6280
6281         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6282         declare.
6283         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6284
6285 2019-06-22  Tom de Vries  <tdevries@suse.de>
6286
6287         * dwarf2read.c (create_addrmap_from_aranges)
6288         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6289         instead of '%zu'.
6290
6291 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6292
6293         * dwarf2read.h (dwarf2_section_info_def): Remove.
6294         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6295         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6296         std::vector<dwarf2_section_info>.
6297         (struct dwo_file) <~dwo_file>: Remove.
6298         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6299         types field.
6300         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6301         (dwarf2_read_debug_names): Likewise.
6302         (create_debug_types_hash_table): Change parameter type to
6303         array_view, adjust code accordingly.
6304         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6305         (partial_die_info::fixup): Likewise.
6306         (determine_prefix): Likewise.
6307         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6308
6309 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6310
6311         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6312         gdb_bfd_ref_ptr.
6313         <~dwo_file>: Remove call to gdb_bfd_unref.
6314         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6315         gdb_bfd_ref_ptr::get.
6316
6317 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6318
6319         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6320         type to htab_up.
6321         * dwarf2read.c (struct dwo_file): Initialize fields.
6322         <~dwo_file>: New.
6323         (free_dwo_file): Remove, move content to ~dwo_file.
6324         (struct dwo_file_deleter): Remove.
6325         (dwo_file_up>: Remove custom deleter.
6326         (free_dwo_files): Remove.
6327         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6328         dwo_files.
6329         (process_skeletonless_type_units): Call unique_ptr::get.
6330         (allocate_dwo_file_hash_table): Add deleter to created hash
6331         table.  Change return type to htab_up.
6332         (lookup_dwo_file_slot): Don't memset dwo_file, call
6333         unique_ptr::get.
6334         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6335         (create_dwo_unit_in_dwp_v2): Likewise.
6336         (open_and_init_dwo_file): Likewise.
6337         (free_dwo_file_from_slot): Remove.
6338
6339 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6340
6341         * dwarf2read.h (struct dwarf2_section_info) <readin,
6342         is_virtual>: Change type to bool.
6343         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6344         true instead of 1.
6345
6346 2019-06-19  Tom Tromey  <tom@tromey.com>
6347
6348         * tui/tui-data.h (tui_init_content_element): Don't declare.
6349
6350 2019-06-19  Tom Tromey  <tom@tromey.com>
6351
6352         * tui/tui-data.h (tui_init_win_info): Don't declare.
6353
6354 2019-06-19  Tom de Vries  <tdevries@suse.de>
6355
6356         * dwarf2read.h (abstract_to_concrete): Change type to
6357         std::unordered_map<sect_offset, std::vector<sect_offset>,
6358         gdb::hash_enum<sect_offset>>.
6359
6360 2019-06-19  Tom Tromey  <tromey@adacore.com>
6361
6362         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6363         EVAL_AVOID_SIDE_EFFECTS specially.
6364
6365 2019-06-19  Tom Tromey  <tromey@adacore.com>
6366
6367         * source-cache.c (highlighter): New global.
6368         (source_cache::get_source_lines): Create a highlighter on demand.
6369
6370 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * defs.h (deprecated_interactive_hook): Delete declaration.
6373         * interps.c (clear_interpreter_hooks): Remove use of
6374         deprecated_interactive_hook.
6375         * top.c (deprecated_interactive_hook): Delete definition.
6376         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6377
6378 2019-06-18  Tom de Vries  <tdevries@suse.de>
6379
6380         PR gdb/24515
6381         * dwarf2read.h (abstract_to_concrete): Change type from
6382         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6383         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6384         * dwarf2read.c (read_variable): Update.
6385         (dwarf2_fetch_die_loc_sect_off): Update.
6386
6387 2019-06-17  Tom de Vries  <tdevries@suse.de>
6388
6389         PR gdb/24617
6390         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6391         accessing parent[parent_len - 1].
6392
6393 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6394
6395         PR gdb/24364
6396         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6397         call dtrace_process_dof with NULL dof.
6398
6399 2019-06-16  Tom de Vries  <tdevries@suse.de>
6400
6401         PR gdb/24445
6402         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6403
6404 2019-06-16  Tom Tromey  <tom@tromey.com>
6405
6406         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6407         (make_all_visible): Use address of member.
6408
6409 2019-06-16  Tom Tromey  <tom@tromey.com>
6410
6411         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6412         (tui_free_window, free_content, free_content_elements): Remove
6413         unnecessary cast.
6414         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6415         cast.
6416         * tui/tui-regs.c (tui_show_register_group)
6417         (tui_display_registers_from, tui_display_reg_element_at_line):
6418         Remove unnecessary cast.
6419
6420 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6421
6422         * linux-nat.c (normal_mask): Delete.
6423         (_initialize_linux_nat): Don't initialise normal_mask.
6424
6425 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6426
6427         PR gdb/24445
6428         * dwarf-index-write.h (write_psymtabs_to_index): Add
6429         dwz_basename parameter.
6430         * dwarf-index-write.c (write_gdbindex): Move file writing to
6431         write_gdbindex_1.  Change return type void.
6432         (assert_file_size): Move up, remove filename parameter.
6433         (write_gdbindex_1): New function.
6434         (write_debug_names): Change return type to void, call
6435         assert_file_size.
6436         (struct index_wip_file): New struct.
6437         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6438         file logic to index_wip_file.  Write index for dwz file if
6439         needed.
6440         (save_gdb_index_command): Pass basename of dwz file, if present.
6441         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6442         build-id of dwz file, if present.
6443         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6444         (dwarf2_get_dwz_file): Likewise.
6445         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6446         (dwarf2_get_dwz_file): Likewise.
6447
6448 2019-06-16  Tom Tromey  <tom@tromey.com>
6449
6450         * coffread.c (process_coff_symbol): Use xstrdup.
6451         * value.c (create_internalvar): Use xstrdup.
6452
6453 2019-06-16  Tom Tromey  <tom@tromey.com>
6454
6455         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6456         * breakpoint.c (stopin_command, stopat_command)
6457         (until_break_command, decode_location_default): Remove unnecessary
6458         cast.
6459         * utils.c (subset_compare): Remove unnecessary cast.
6460         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6461         cast.
6462         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6463         cast.
6464         * infcmd.c (path_command): Remove unnecessary cast.
6465         * coffread.c (decode_type): Remove unnecessary cast.
6466         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6467         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6468         * tui/tui-stack.c (tui_show_locator_content)
6469         (tui_show_frame_info): Remove unnecessary cast.
6470         * tui/tui-win.c (tui_scroll_forward_command)
6471         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6472         (parse_scrolling_args): Remove unnecessary cast.
6473         * tui/tui-data.c (init_win_info, tui_del_window)
6474         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6475         (free_content_elements): Remove unnecessary cast.
6476         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6477         unnecessary cast.
6478         * tui/tui-source.c (tui_set_source_content)
6479         (tui_vertical_source_scroll): Remove unnecessary cast.
6480         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6481         cast.
6482         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6483         * tui/tui-regs.c (tui_display_registers_from)
6484         (tui_display_register): Remove unnecessary cast.
6485         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6486         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6487         (make_visible): Remove unnecessary cast.
6488         * tui/tui-winsource.c (tui_erase_source_content)
6489         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6490         unnecessary cast.
6491         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6492         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6493         * stabsread.c (read_type, read_array_type, read_range_type):
6494         Remove unnecessary cast.
6495         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6496         (parse_symbol, parse_type, upgrade_type, parse_external)
6497         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6498         unnecessary cast.
6499         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6500
6501 2019-06-16  Tom Tromey  <tom@tromey.com>
6502
6503         * tui/tui-data.c (tui_alloc_generic_win_info)
6504         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6505         checks.
6506
6507 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6508             Andrew Burgess  <andrew.burgess@embecosm.com>
6509
6510         * f-typeprint.c (f_print_type): Don't return early for not
6511         associated or not allocated types.
6512         (f_type_print_varspec_suffix): Add print_rank parameter and print
6513         ranks of array types in case they dangling.
6514         (f_type_print_base): Add print_rank parameter.
6515
6516 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6517
6518         * NEWS: Mention new MI commands.
6519         * break-catch-throw.c (enum exception_event_kind): Move to
6520         breakpoint.h.
6521         (print_mention_exception_catchpoint): Output text as a single
6522         message.
6523         (catch_exception_command_1): Rename to...
6524         (catch_exception_event): ...this, make non-static, update header
6525         command, and change some parameter types.
6526         (catch_catch_command): Update for changes to
6527         catch_exception_command_1.
6528         (catch_throw_command): Likewise.
6529         (catch_rethrow_command): Likewise.
6530         * breakpoint.c (enum exception_event_kind): Delete.
6531         * breakpoint.h (enum exception_event_kind): Moved here from
6532         break-catch-throw.c.
6533         (catch_exception_event): Declare.
6534         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6535         (mi_cmd_catch_throw): New function.
6536         (mi_cmd_catch_rethrow): New function.
6537         (mi_cmd_catch_catch): New function.
6538         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6539         'catch-catch' entries.
6540         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6541         (mi_cmd_catch_rethrow): Declare.
6542         (mi_cmd_catch_catch): Declare.
6543
6544 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6545
6546         * annotate.c (annotate_source_line): Change return type to void,
6547         update implementation to match.
6548         * annotate.h (annotate_source_line): Change return type to void,
6549         update header comment.
6550         * stack.c (print_frame_info): Don't change what frame information
6551         is printed based on whether annotations are on or not.
6552
6553 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6554
6555         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6556         (annotate_source): Make static.
6557         (annotate_source_line): Moved from source.c and renamed from
6558         identify_source_line.  Update the return type.
6559         * annotate.h (annotate_source): Delete declaration.
6560         (annotate_source_line): Declaration moved from source.h, and
6561         renamed from identify_source_line.  Return type updated.
6562         * source.c (identify_source_line): Moved to annotate.c and renamed
6563         to annotate_source_line.
6564         (info_line_command): Remove check of annotation_level.
6565         * source.h (identify_source_line): Move declaration to annotate.h
6566         and rename to annotate_source_line.
6567         * stack.c: Add 'annotate.h' include.
6568         (print_frame_info): Remove check of annotation_level before
6569         calling annotate_source_line.
6570
6571 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * source-cache.c (source_cache::get_plain_source_lines): Use
6574         open_source_file_with_line_charpos instead of just
6575         open_source_file, remove call to find_source_lines.
6576         (source_cache::get_source_lines): Likewise.
6577         * source.c (find_source_lines): Make static.
6578         (get_filename_and_charpos): Renamed into...
6579         (open_source_file_with_line_charpos): ..this along with changes to
6580         return a scoped_fd, and some other minor clean ups.
6581         (identify_source_line): Use open_source_file_with_line_charpos.
6582         (search_command_helper): Use open_source_file_with_line_charpos
6583         instead of just open_source_file, remove call to
6584         find_source_lines.
6585         * source.h (open_source_file_with_line_charpos): Declare new
6586         function.
6587         (find_source_lines): Delete declaration.
6588
6589 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6590
6591         * source.c (get_filename_and_charpos): Remove fullname
6592         parameter.
6593         (identify_source_line): Update call to get_filename_and_charpos.
6594
6595 2019-06-14  Tom Tromey  <tromey@adacore.com>
6596
6597         PR gdb/24502:
6598         * ui-style.h (skip_ansi_escape): Update comment.
6599         * ui-file.h (class no_terminal_escape_file): New class.
6600         * ui-file.c (no_terminal_escape_file::write)
6601         (no_terminal_escape_file::puts): New methods.
6602         * cli/cli-logging.c (handle_redirections): Use
6603         no_terminal_escape_file.
6604
6605 2019-06-14  Tom Tromey  <tromey@adacore.com>
6606
6607         * NEWS: Move convenience variable news above Python news.
6608
6609 2019-06-14  Tom Tromey  <tom@tromey.com>
6610
6611         * gnulib: Move directory to top-level.
6612         * configure.ac: Don't configure gnulib.
6613         * configure: Rebuild.
6614         * common/common-defs.h: Use new path to gnulib.
6615         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6616         (GNULIB_H): Remove.
6617         (INCGNU): Look in new gnulib location.
6618         (HFILES_NO_SRCDIR): Remove gnulib files.
6619         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6620         (generated_files): Remove GNULIB_H.
6621         ($(LIBGNU), all-lib): Remove targets.
6622         (distclean): Don't mention GNULIB_BUILDDIR.
6623         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6624
6625 2019-06-14  Tom Tromey  <tromey@adacore.com>
6626
6627         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6628         Warn if symbol file does not provide any symbols.
6629
6630 2019-06-14  Tom Tromey  <tromey@adacore.com>
6631
6632         * source.c (find_and_open_source): Respect basenames_may_differ.
6633
6634 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6635
6636         * annotate.c (annotate_breakpoints_invalid): Make use of
6637         scoped_restore_terminal_state.
6638         (annotate_frames_invalid): Likewise.
6639
6640 2019-06-14  Tom Tromey  <tromey@adacore.com>
6641
6642         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6643         allow assignment to an internalvar.
6644
6645 2019-06-14  Tom Tromey  <tromey@adacore.com>
6646
6647         * ada-lex.l: Allow "_" in attribute names.
6648
6649 2019-06-14  Tom Tromey  <tromey@adacore.com>
6650
6651         PR gdb/24653:
6652         * regcache.c (registers_changed): Don't call alloca.
6653         * top.c (execute_command): Don't call alloca.
6654
6655 2019-06-13  Pedro Alves  <palves@redhat.com>
6656
6657         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6658         'expression'.  When parsing an expression, error out if there's
6659         junk after "unlimited".
6660         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6661         (do_set_command): Adjust calls to is_unlimited_literal.
6662
6663 2019-06-13  Pedro Alves  <palves@redhat.com>
6664
6665         * compile/compile.c (make_compile_options_def_group): Add braces
6666         around array_view initializer.
6667         * thread.c (make_thread_apply_all_options_def_group)
6668         (make_thread_apply_all_options_def_group): Likewise.
6669
6670 2019-06-13  Pedro Alves  <palves@redhat.com>
6671
6672         * NEWS (New commands): Mention "maint test-options
6673         require-delimiter", "maint test-options unknown-is-error", "maint
6674         test-options unknown-is-operand" and "maint show
6675         test-options-completion-result".
6676         (New command options, command completion): New section.
6677         (Completion improvements): New section.
6678         Mention that you can abbreviate "unlimited".
6679
6680 2019-06-13  Pedro Alves  <palves@redhat.com>
6681
6682         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6683         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6684         * unittests/cli-utils-selftests.c (test_parse_flags)
6685         (test_parse_flags_qcs): Delete.
6686         (test_cli_utils): Don't call deleted functions.
6687
6688 2019-06-13  Pedro Alves  <palves@redhat.com>
6689
6690         * thread.c: Include "cli/cli-option.h".
6691         (tp_array_compar_ascending): Global.
6692         (tp_array_compar): Delete function.
6693         (tp_array_compar_ascending, tp_array_compar_descending): New
6694         functions.
6695         (ascending_option_def, qcs_flag_option_def)
6696         (thr_qcs_flags_option_defs)
6697         (make_thread_apply_all_options_def_group)
6698         (make_thread_apply_options_def_group): New.
6699         (thread_apply_all_command): Use gdb::option::process_options.
6700         (thread_apply_command_completer)
6701         (thread_apply_all_command_completer): New.
6702         (thread_apply_command): Use gdb::option::process_options.
6703         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6704         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6705         to generate help text of "thread apply".  Adjust "taas"'s help.
6706         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6707         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6708
6709 2019-06-13  Pedro Alves  <palves@redhat.com>
6710
6711         * thread.c (thread_apply_command): Check for invalid TID with
6712         isdigit instead of !isalpha.
6713
6714 2019-06-13  Pedro Alves  <palves@redhat.com>
6715
6716         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6717         (validate_flags_qcs): New.
6718         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6719         (validate_flags_qcs): Declare.
6720         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6721         (make_frame_apply_options_def_group): New.
6722         (frame_apply_command_count): Process options with
6723         gdb::option::process_options.
6724         (frame_apply_completer): New.
6725         (frame_apply_level_completer, frame_apply_all_completer)
6726         (frame_apply_completer): New.
6727         (_initialize_stack): Update help of "frame apply", "frame apply
6728         level", "frame apply all" and "faas" to mention supported options
6729         and install command completers.
6730         * stack.h (frame_apply_all_completer): Declare.
6731         * thread.c: Include "stack.h".
6732         (tfaas_command): Add "--".
6733         (_initialize_thread): Update help "tfaas" to mention supported
6734         options and install command completer.
6735
6736 2019-06-13  Pedro Alves  <palves@redhat.com>
6737
6738         * completer.c (complete_nested_command_line): New.
6739         (gdb_completion_word_break_characters_throw): Add assertion.
6740         * completer.h (complete_nested_command_line): Declare.
6741
6742 2019-06-13  Pedro Alves  <palves@redhat.com>
6743
6744         * stack.c (parse_backtrace_qualifiers): New.
6745         (backtrace_command): Use it.
6746         (backtrace_command_completer): Complete on qualifiers.
6747
6748 2019-06-13  Pedro Alves  <palves@redhat.com>
6749
6750         * frame.c: Include "cli/cli-option.h.
6751         (user_set_backtrace_options): New.
6752         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6753         Delete.
6754         (get_prev_frame): Adjust.
6755         (boolean_option_def, uinteger_option_def)
6756         (set_backtrace_option_defs): New.
6757         (_initialize_frame): Adjust and use
6758         gdb::option::add_setshow_cmds_for_options to install "set
6759         backtrace past-main" and "set backtrace past-entry".
6760         * frame.h: Include "cli/cli-option.h".
6761         (struct frame_print_options): Forward declare.
6762         (print_frame_arguments_all, print_frame_arguments_scalars)
6763         (print_frame_arguments_none): Declare.
6764         (print_entry_values): Delete declaration.
6765         (struct frame_print_options, user_frame_print_options): New.
6766         (struct set_backtrace_options): New.
6767         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6768         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6769         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6770         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6771         (list_args_or_locals): Add frame_print_options parameter.
6772         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6773         * python/py-framefilter.c (enumerate_args): Pass down
6774         USER_FRAME_PRINT_OPTIONS.
6775         * stack.c: Include "cli/cli-option.h".
6776         (print_frame_arguments_all, print_frame_arguments_scalars)
6777         (print_frame_arguments_none): Declare.
6778         (print_raw_frame_arguments, print_entry_values): Delete.
6779         (user_frame_print_options): New.
6780         (boolean_option_def, enum_option_def, frame_print_option_defs):
6781         New.
6782         (struct backtrace_cmd_options): New.
6783         (bt_flag_option_def): New.
6784         (backtrace_command_option_defs): New.
6785         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6786         (print_frame_arg, read_frame_arg, print_frame_args)
6787         (print_frame_info, print_frame): Add frame_print_options parameter
6788         and use it.
6789         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6790         (backtrace_command_1): Add frame_print_options and
6791         backtrace_cmd_options parameters and use them.
6792         (make_backtrace_options_def_group): New.
6793         (backtrace_command): Process command options with
6794         gdb::option::process_options.
6795         (backtrace_command_completer): New.
6796         (_initialize_stack): Extend "backtrace"'s help to mention
6797         supported options.  Install completer for "backtrace".
6798         Install some settings commands with add_setshow_cmds_for_options.
6799
6800 2019-06-13  Pedro Alves  <palves@redhat.com>
6801
6802         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6803         and that "set/show print raw frame-arguments" are now deprecated.
6804
6805         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6806         command.
6807         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6808         * stack.c (_initialize_stack): Install "set/show print
6809         raw-frame-arguments", and deprecate "set/show print raw
6810         frame-arguments".
6811         * valprint.c (_initialize_valprint): Deprecate "set/show print
6812         raw".
6813
6814 2019-06-13  Pedro Alves  <palves@redhat.com>
6815
6816         * compile/compile.c (struct compile_options): New.
6817         (compile_flag_option_def, compile_command_option_defs)
6818         (make_compile_options_def_group): New.
6819         (compile_file_command): Handle options with
6820         gdb::option::process_options.
6821         (compile_file_command_completer): New function.
6822         (compile_code_command): Handle options with
6823         gdb::option::process_options.
6824         (compile_code_command_completer): New function.
6825         (_initialize_compiler): Install completers for "compile code" and
6826         "compile file".  Mention available options in "compile code" and
6827         "compile code"'s help.
6828         * completer.c (advance_to_completion_word): New, factored out from
6829         ...
6830         (advance_to_expression_complete_word_point): ... this.
6831         (advance_to_filename_complete_word_point): New.
6832         * completer.h (advance_to_filename_complete_word_point): New
6833         declaration.
6834
6835 2019-06-13  Pedro Alves  <palves@redhat.com>
6836
6837         * compile/compile.c: Include "cli/cli-option.h".
6838         (compile_print_value): Scope data pointer is now a
6839         value_print_options pointer; adjust.
6840         (compile_print_command): Process options.  Scope data pointer is
6841         now a value_print_options pointer; adjust.
6842         (_initialize_compile): Update "compile print"'s help to include
6843         supported options.  Install a completer for "compile print".
6844         * cp-valprint.c (show_vtblprint, show_objectprint)
6845         (show_static_field_print): Delete.
6846         (_initialize_cp_valprint): Don't install "set print
6847         static-members", "set print vtbl", "set print object" here.
6848         * printcmd.c: Include "cli/cli-option.h" and
6849         "common/gdb_optional.h".
6850         (print_command_parse_format): Rework to fill in a
6851         value_print_options instead of a format_data.
6852         (print_value): Change parameter type from format_data pointer to
6853         value_print_options reference.  Adjust.
6854         (print_command_1): Process options.  Adjust to pass down a
6855         value_print_options.
6856         (print_command_completer): New.
6857         (_initialize_printcmd): Install print_command_completer as
6858         handle_brkchars completer for the "print" command.  Update
6859         "print"'s help to include supported options.
6860         * valprint.c: Include "cli/cli-option.h".
6861         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6862         here from cp-valprint.c.
6863         (boolean_option_def, uinteger_option_def)
6864         (value_print_option_defs, make_value_print_options_def_group):
6865         New.  Use gdb::option::add_setshow_cmds_for_options to install
6866         "set print elements", "set print null-stop", "set print repeats",
6867         "set print pretty", "set print union", "set print array", "set
6868         print address", "set print symbol", "set print array-indexes".
6869         * valprint.h: Include <string> and "cli/cli-option.h".
6870         (make_value_print_options_def_group): Declare.
6871         (print_value): Change parameter type from format_data pointer to
6872         value_print_options reference.
6873         (print_command_completer): Declare.
6874
6875 2019-06-13  Pedro Alves  <palves@redhat.com>
6876
6877         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6878         (COMMON_SFILES): Add maint-test-settings.c.
6879         * cli/cli-decode.c (boolean_enums): New global, factored out from
6880         ...
6881         (add_setshow_boolean_cmd): ... here.
6882         * cli/cli-decode.h (boolean_enums): Declare.
6883         * cli/cli-option.c: New file.
6884         * cli/cli-option.h: New file.
6885         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6886         factored out from ...
6887         (parse_cli_boolean_value(const char *)): ... this.
6888         (is_unlimited_literal): Change parameter type to pointer to
6889         pointer.  Adjust and advance ARG pointer.
6890         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6891         (parse_cli_var_enum): New, factored out from ...
6892         (do_set_command): ... this.  Adjust.
6893         * cli/cli-setshow.h (parse_cli_boolean_value)
6894         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6895         (parse_cli_var_enum): Declare.
6896         * cli/cli-utils.c: Include "cli/cli-option.h".
6897         (get_ulongest): New.
6898         * cli/cli-utils.h (get_ulongest): Declare.
6899         (check_for_argument): New overloads.
6900         * maint-test-options.c: New file.
6901
6902 2019-06-13  Pedro Alves  <palves@redhat.com>
6903
6904         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6905         parse a range if "-" is at the end of the string.
6906
6907 2019-06-13  Pedro Alves  <palves@redhat.com>
6908
6909         * cli/cli-setshow.c (parse_auto_binary_operation)
6910         (parse_cli_boolean_value): Don't allow "o".
6911
6912 2019-06-13  Pedro Alves  <palves@redhat.com>
6913
6914         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6915         * NEWS: Mention maint test-settings KIND.
6916         * maint-test-settings.c: New file.
6917
6918 2019-06-13  Pedro Alves  <palves@redhat.com>
6919
6920         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6921         completer.
6922         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6923         "set" completers.
6924
6925 2019-06-13  Pedro Alves  <palves@redhat.com>
6926
6927         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6928         after item.
6929
6930 2019-06-13  Pedro Alves  <palves@redhat.com>
6931
6932         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6933
6934 2019-06-13  Pedro Alves <palves@redhat.com>
6935
6936         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6937         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6938         call.
6939         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6940         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6941         calls.
6942         (check_for_argument): Skip spaces after argument.
6943
6944 2019-06-13  Pedro Alves  <palves@redhat.com>
6945
6946         * thread.c (thread_apply_command): Adjust TID parsing.
6947         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6948         detected before end of string.
6949         (tid_is_in_list): Error out if LIST is invalid.
6950
6951 2019-06-13  Pedro Alves  <palves@redhat.com>
6952
6953         * completer.c (complete_line_internal_1): Rewind completion word
6954         point.
6955         (completion_tracker::advance_custom_word_point_by): Change
6956         parameter type to int.
6957         * completer.h (completion_tracker::advance_custom_word_point_by):
6958         Likewise.
6959
6960 2019-06-13  Pedro Alves  <palves@redhat.com>
6961
6962         * completer.c (advance_to_completion_word): Handle delimiters.
6963
6964 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6965
6966         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6967
6968 2019-06-11  Tom Tromey  <tom@tromey.com>
6969
6970         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6971         (xmalloc_failed): Move to alloc.c.
6972         * alloc.c: New file.
6973         * Makefile.in (COMMON_SFILES): Add alloc.c.
6974
6975 2019-06-11  Tom Tromey  <tom@tromey.com>
6976
6977         * nat/linux-waitpid.c: Don't include server.h.
6978         (linux_debug): Remove.
6979         (my_waitpid): Update.
6980
6981 2019-06-11  Tom Tromey  <tromey@adacore.com>
6982
6983         * infcall.c (_initialize_infcall): Remove trailing newline from
6984         help.
6985         * user-regs.c (_initialize_user_regs): Remove trailing newline
6986         from help.
6987         * typeprint.c (_initialize_typeprint): Remove trailing newline
6988         from help.
6989         * reverse.c (_initialize_reverse): Remove trailing newlines from
6990         help.
6991         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6992         from help.
6993         * language.c (add_set_language_command): Remove trailing newline
6994         from help.
6995         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6996         help.
6997         * disasm.c (_initialize_disasm): Remove trailing newline from
6998         help.
6999         * top.c (init_main): Remove trailing newline from help.
7000         * interps.c (_initialize_interpreter): Remove trailing newline
7001         from help.
7002         * btrace.c (_initialize_btrace): Remove trailing newlines from
7003         help.
7004         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7005         from help.
7006         * python/python.c (_initialize_python): Remove trailing newline
7007         from help.
7008         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7009         help.
7010         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7011         from help.  Reformat some text.
7012         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7013         from help.
7014         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7015         newline from help.
7016
7017 2019-06-11  Tom Tromey  <tromey@adacore.com>
7018
7019         * darwin-nat.c (darwin_decode_exception_message)
7020         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7021
7022 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7023
7024         * valops.c (value_slice): Check for not allocated or not
7025         associated values.
7026
7027 2019-06-10  Tom de Vries  <tdevries@suse.de>
7028
7029         PR gdb/24618
7030         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7031         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7032         invalid.
7033
7034 2019-06-10  Tom de Vries  <tdevries@suse.de>
7035
7036         PR gdb/24611
7037         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7038         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7039
7040 2019-06-10  Tom de Vries  <tdevries@suse.de>
7041
7042         PR symtab/24545
7043         * symtab.c (struct demangled_name_entry): Add language field.
7044         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7045         static minimal symbol".  Set and use language field.
7046
7047 2019-06-10  Tom Tromey  <tromey@adacore.com>
7048
7049         * ada-lang.c (_initialize_ada_language): Update help text.
7050
7051 2019-06-10  Tom Tromey  <tromey@adacore.com>
7052
7053         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7054         with a newline.
7055         * guile/guile.c (handle_boot_error): Don't end warning with a
7056         newline.
7057         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7058         warning with a newline.
7059         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7060         newline.
7061         (s12z_frame_cache): Likewise.
7062         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7063         a newline.
7064         * solib-svr4.c (disable_probes_interface): Don't end warning with
7065         a newline.
7066         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7067         newline.
7068         * python/python.c (do_finish_initialization): Don't end warning
7069         with a newline.
7070
7071 2019-06-10  Tom Tromey  <tom@tromey.com>
7072
7073         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7074         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7075         gdbpy_enter.
7076
7077 2019-06-10  Tom Tromey  <tromey@adacore.com>
7078
7079         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7080         data.
7081         (elf_new_init): Don't call stabsread_new_init.
7082         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7083         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7084         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7085
7086 2019-06-10  Tom de Vries  <tdevries@suse.de>
7087
7088         PR symtab/16264
7089         PR symtab/24517
7090         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7091
7092 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7093
7094         * source.c (find_and_open_source): Also rewrite relative file
7095         names.
7096
7097 2019-04-26  Amos Bird  <amosbird@gmail.com>
7098
7099         * annotate.c (annotate_thread_exited): Add "thread-exited"
7100         annotation.
7101
7102 2019-06-06  Tom Tromey  <tromey@adacore.com>
7103
7104         * maint.h (class scoped_command_stats): Use
7105         DISABLE_COPY_AND_ASSIGN.
7106         <print_time>: New method.
7107         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7108         print_time.
7109         (scoped_command_stats::print_time): New method.
7110
7111 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7112
7113         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7114         instructions of lengths 6 or 8 bytes.
7115
7116 2019-06-04  Pedro Alves  <palves@redhat.com>
7117
7118         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7119
7120         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7121         * breakpoint.c (condition_completer): Likewise.
7122         * cli/cli-dump.c (scan_expression): Likewise.
7123         * common/filestuff.c (mkdir_recursive): Likewise.
7124         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7125         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7126         (gdb_abspath): Likewise.
7127         * compile/compile-cplus-types.c
7128         (compile_cplus_instance::decl_name): Likewise.
7129         * completer.c (complete_explicit_location):
7130         (signal_completer, reg_or_group_completer_1): Likewise.
7131         * cp-support.c (cp_remove_params_if_any): Likewise.
7132         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7133         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7134         * infcmd.c (strip_bg_char): Likewise.
7135         * linespec.c (copy_token_string): Likewise.
7136         * mi/mi-main.c (output_cores): Likewise.
7137         * psymtab.c (psymtab_search_name):
7138         * symfile.c (test_set_ext_lang_command): Likewise.
7139         * target.c (target_fileio_read_stralloc): Likewise.
7140         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7141         * value.c (complete_internalvar): Likewise.
7142
7143 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7144
7145         Add objfile property to gdb.Type.
7146         * NEWS: Mention Python API addition.
7147         * python/py-type.c (typy_get_objfile): New method.
7148
7149 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7150
7151         * NEWS: Mention the new set|show style [title|highlight].
7152         Mention changes to "show style", "help" and "apropos".
7153
7154 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7155
7156         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7157         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7158         instead of print_help_for_command.
7159         (print_doc_of_command): New function.
7160         (help_list): Add 'apropos -v word' suggestion.
7161         (print_help_for_command): Style the command name using title style.
7162         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7163         (_initialize_cli_cmds): Describe -v in apropos_command help.
7164
7165 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7166
7167         * cli/cli-style.h (cli_style_option): Add name in constructor,
7168         add m_name class member, add constructor with intensity,
7169         add name class function.
7170         (cli_style_option::add_setshow_commands): Remove name argument.
7171         (highlight_style, title_style): New styles.
7172         * cli/cli-style.c (do_show): New function that shows a style
7173         characteristic styling the style name with itself.
7174         (set_style_name): New function.
7175         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7176         Update all callers according to the changes in cli/cli-style.h.
7177         * utils.h (fputs_highlighted): New function.
7178         * utils.c (fputs_highlighted): Likewise.
7179
7180 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7181
7182         * NEWS: Mention new pipe command and new convenience variables.
7183
7184 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7185
7186         * cli/cli-cmds.c (pipe_command): New function.
7187         (_initialize_cli_cmds): Call add_com for pipe_command.
7188         Define | as an alias for pipe.
7189         (exit_status_set_internal_vars): New function.
7190         (shell_escape): Call exit_status_set_internal_vars.
7191         cli/cli-decode.c (find_command_name_length): Recognize | as
7192         a single character command.
7193
7194 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7195
7196         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7197         top.c (execute_command_to_ui_file): New function, mostly a copy
7198         of execute_command_to_string.
7199         (execute_command_to_string): Implement by calling
7200         execute_command_to_ui_file.
7201
7202 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7203
7204         * top.h (saved_command_line): Remove declaration.
7205         * top.c (previous_saved_command_line, previous_repeat_arguments):
7206         New variables.
7207         (saved_command_line): Make static, define together with other
7208         'repeat variables'.
7209         (dont_repeat): Clear repeat_arguments.
7210         (repeat_previous, get_saved_command_line, save_command_line):
7211         New functions.
7212         (gdb_init): Initialize saved_command_line
7213         and previous_saved_command_line.
7214         * main.c (captured_main_1): Remove saved_command_line initialization.
7215         * event-top.c (handle_line_of_input): Update to use
7216         the new 'repeat' related functions instead of direct access to
7217         saved_command_line.
7218         * command.h (repeat_previous, get_saved_command_line,
7219         save_command_line): New declarations.
7220         (dont_repeat): Add comment.
7221
7222 2019-05-30  Tom Tromey  <tromey@adacore.com>
7223
7224         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7225         Fix comment.
7226         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7227
7228 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7229
7230         PR cli/24587
7231         * completer.c (complete): Initialize variable word.
7232
7233 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7234
7235         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7236         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7237         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7238         'body' is NULL to the outter 'if', protecting the '!is_define'
7239         situation as well.
7240
7241 2019-05-29  Tom Tromey  <tromey@adacore.com>
7242
7243         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7244         (dwarf_unknown): New function.
7245         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7246         (dwarf_type_encoding_name): Use dwarf_unknown.
7247
7248 2019-05-29  Tom Tromey  <tromey@adacore.com>
7249
7250         PR c++/20020:
7251         * cp-valprint.c (cp_print_value_fields): Call
7252         cp_print_static_field inside "try".
7253
7254 2019-05-29  Tom Tromey  <tromey@adacore.com>
7255
7256         * inflow.c (struct terminal_info): Add default operator=.
7257         * configure: Rebuild.
7258         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7259         -Wdeprecated-copy-dtor, -Wredundant-move.
7260
7261 2019-05-29  Tom Tromey  <tromey@adacore.com>
7262
7263         * NEWS: Add entry.
7264         * infcmd.c (print_return_value_1): Handle finish_print
7265         option.
7266         (show_print_finish): New function.
7267         (_initialize_infcmd): Add "set/show print finish" commands.
7268         * valprint.c (user_print_options): Initialize new member.
7269         * valprint.h (struct value_print_options) <finish_print>: New
7270         member.
7271
7272 2019-05-28  Tom Tromey  <tromey@adacore.com>
7273
7274         * ada-lang.c (ada_remove_Xbn_suffix)
7275         (find_old_style_renaming_symbol)
7276         (parse_old_style_renaming): Remove.
7277         (ada_find_renaming_symbol): Don't call
7278         find_old_style_renaming_symbol.
7279         (ada_is_renaming_symbol): Rename from
7280         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7281         bool.  Now static.
7282         (ada_read_var_value): Update and simplify.
7283         * ada-exp.y (write_var_or_type): Remove old code.
7284
7285 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7286
7287         PR gdb/25010
7288         * event-top.c: Remove include comment.
7289         * inflow.c (class scoped_ignore_sigttou): Move from here...
7290         * inflow.h (class scoped_ignore_sigttou): ...to here.
7291         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7292         * top.c:  Remove include comment.
7293
7294 2019-05-27  Tom Tromey  <tom@tromey.com>
7295
7296         * NEWS: Fix typo.
7297
7298 2019-05-22  Tom Tromey  <tromey@adacore.com>
7299
7300         * target.c (target_follow_exec): Constify parameter.
7301         * target-delegates.c: Rebuild.
7302         * remote.c (remote_target::follow_exec): Constify parameter.
7303         * infrun.c (follow_exec): Constify parameter.
7304         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7305         (target_follow_exec): Likewise.
7306
7307 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7308
7309         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7310         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7311
7312 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7313
7314         * NEWS: Add debugredirect and testsuite sections.
7315
7316 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7317
7318         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7319         target descriptions using exclusively floating point register name
7320         aliases.
7321
7322 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7323
7324         PR gdb/18644:
7325         * f-lang.c (build_fortran_types): Handle the case where
7326         gdbarch_floatformat_for_type returns a nullptr.
7327
7328 2019-05-21  Tom de Vries  <tdevries@suse.de>
7329
7330         PR cli/24587
7331         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7332
7333 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         PR gdb/18644:
7336         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7337         16-byte floats.
7338         * i386-tdep.c (i386_floatformat_for_type): Use
7339         floatformats_ia64_quad for the 16-byte floating point component
7340         within a fortran 32-byte complex number.
7341
7342 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7343
7344         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7345         delete default constructor.
7346         (find_partial_die): Update to return const struct.
7347         (partial_die_parent_scope): Move variable declaration into scope
7348         of its use and change its type to auto.
7349         (guess_partial_die_structure_name): Likewise.
7350         (partial_die_info::fixup): Likewise.
7351
7352 2019-05-17  Tom Tromey  <tromey@adacore.com>
7353
7354         * source.c (find_and_open_source): Remove cast.
7355
7356 2019-05-17  Tom Tromey  <tromey@adacore.com>
7357
7358         * annotate.c (annotate_source): Make "filename" const.
7359         * annotate.h (annotate_source): Use const.
7360
7361 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7362
7363         * disasm.c (set_disassembler_options): Send errors to stderr.
7364
7365 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7366
7367         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7368         (cli_interp_base::set_logging): Check debug_redirect.
7369         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7370         * cli/cli-logging.c (debug_redirect): Add static variable.
7371         (pop_output_files): Add default param.
7372         (handle_redirections): Print debug setting.
7373         (show_logging_command): Likewise.
7374         (_initialize_cli_logging): Add debugredirect command.
7375         * interps.c (current_interp_set_logging): Add debug_redirect
7376         parameter.
7377         * interps.h (set_logging): Add debug_redirect parameter.
7378         (current_interp_set_logging): Likewise.
7379         * mi/mi-common.h: Likewise.
7380         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7381
7382 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7383             Tom Tromey  <tromey@adacore.com>
7384
7385         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7386         directly.
7387         * cli/cli-interp.h (make_logging_output): Remove declaration.
7388         * cli/cli-logging.c (make_logging_output): Remove function.
7389         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7390         directly.
7391         * ui-file.c (tee_file::tee_file): Remove bools.
7392         (tee_file::~tee_file): Remove deletes.
7393         * ui-file.h (tee_file): Remove bools.
7394
7395 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7396
7397         * mi/mi-cmds.h (mi_cmd_complete): New function.
7398         * mi/mi-main.c (mi_cmd_complete): Likewise.
7399         * mi/mi-cmds.c: Define new MI command -complete.
7400         * NEWS: Mention new -complete command.
7401
7402 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7403
7404         * completer.h (complete): New function.
7405         * completer.c (complete): Likewise.
7406         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7407         function defined in completer.h.
7408
7409 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7410
7411         * MAINTAINERS (Write After Approval): Add myself.
7412
7413 2019-05-17  Tom de Vries  <tdevries@suse.de>
7414
7415         PR gdb/24094
7416         * dwarf2read.c (struct cu_partial_die_info): New struct.
7417         (find_partial_die): Return cu_partial_die_info.
7418         (partial_die_parent_scope, guess_partial_die_structure_name)
7419         (partial_die_info::fixup): Handle new return type of find_partial_die.
7420
7421 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7422
7423         PR breakpoints/24541
7424         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7425         "std::string", simplifying the algorithm.
7426
7427 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7428
7429         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7430         (stap_static_probe_ops::get_probes): Likewise.
7431
7432 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7433
7434         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7435         '-')" and "else if".
7436         (stap_parse_single_operand): Join checks for
7437         "gdbarch_stap_parse_special_token_p" and
7438         "gdbarch_stap_parse_special_token" in the same "if" statement.
7439         Invert check when verifying for operation on register
7440         displacement.
7441
7442 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7443
7444         * stap-probe.c (stap_get_opcode): Update comment.
7445         (stap_get_expected_argument_type): Likewise.
7446         (handle_stap_probe): Likewise.
7447
7448 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7449
7450         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7451         return type to 'bool'.  Adjust comment.  Use 'bool' when
7452         appropriate.
7453         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7454         * stap-probe.c (stap_parse_argument_1): Likewise.
7455         (stap_is_operator): Likewise.
7456         (stap_is_generic_prefix): Likewise.
7457         (stap_is_register_prefix): Likewise.
7458         (stap_is_register_indirection_prefix): Likewise.
7459         (stap_is_integer_prefix): Likewise.
7460         (stap_generic_check_suffix): Likewise.
7461         (stap_check_integer_suffix): Likewise.
7462         (stap_check_register_suffix): Likewise.
7463         (stap_check_register_indirection_suffix): Likewise.
7464         (stap_parse_register_operand): Likewise.
7465         (stap_parse_single_operand): Likewise.
7466         (stap_parse_argument_1): Likewise.
7467         (stap_probe::get_argument_count): Likewise.
7468         (stap_is_operator): Likewise.
7469
7470 2019-05-16  Tom Tromey  <tromey@adacore.com>
7471
7472         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7473         keyword to foreach.
7474
7475 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7476
7477         * linux-thread-db.c (try_thread_db_load_1): Change return type
7478         to bool.
7479         (try_thread_db_load): Likewise.
7480         (try_thread_db_load_from_pdir_1): Likewise.
7481         (try_thread_db_load_from_pdir): Likewise.
7482         (try_thread_db_load_from_sdir): Likewise.
7483         (try_thread_db_load_from_dir): Likewise.
7484         (thread_db_load_search): Likewise.
7485         (has_libpthread): Likewise.
7486         (thread_db_load): Likewise.
7487
7488 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7489
7490         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7491         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7492         NULL, and complain/return if that's the case.
7493
7494 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7495
7496         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7497         (advance, posn, abstract_read_memory): New functions.
7498         [struct mem_read_abstraction]: New struct.
7499         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7500
7501 2019-05-14  Tom Tromey  <tromey@adacore.com>
7502
7503         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7504         value is not lval_memory.
7505
7506 2019-05-14  Tom Tromey  <tromey@adacore.com>
7507
7508         * solib.c (info_sharedlibrary_command): Style the file name.
7509
7510 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7511
7512         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7513         (aarch64_vnv_type): Likewise.
7514         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7515         * common/tdesc.c: Likewise.
7516         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7517         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7518         * features/aarch64-fpu.xml: Add ieee half view.
7519         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7520         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7521         * gdbtypes.h (struct builtin_type): Likewise.
7522         (struct objfile_type): Likewise.
7523
7524 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7525
7526         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7527         typo.
7528         * location.h (string_to_event_location): Likewise.
7529
7530 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7531
7532         GDB 8.3 released.
7533
7534 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7535
7536         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7537         New variable declaration.
7538         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7539         New variable.
7540         (print_one_breakpoint): Use ui_out::test_flags and new global
7541         variable to compute use_fixed_output.
7542         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7543         Remove.
7544         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7545         (mi_multi_location_breakpoint_output_fixed): Remove.
7546         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7547         new variable.
7548         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7549         fix_multi_location_breakpoint_output flag if version >= 3.
7550         * ui-out.h (enum ui_out_flag)
7551         <fix_multi_location_breakpoint_output>: New enumerator.
7552
7553 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7554
7555         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7556
7557 2019-05-10  Tom Tromey  <tromey@adacore.com>
7558
7559         * ada-lang.c (catch_ada_completer): New function.
7560         (_initialize_ada_language): Use it.
7561
7562 2019-05-10  Tom Tromey  <tromey@adacore.com>
7563
7564         * thread.c (print_thread_info): Make "requested_threads" const.
7565         * gdbthread.h (print_thread_info): Make "requested_threads"
7566         const.
7567         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7568         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7569
7570 2019-05-08  Tom Tromey  <tom@tromey.com>
7571
7572         * gdbtypes.c (objfile_type_data): Change type.
7573         (objfile_type, _initialize_gdbtypes): Update.
7574
7575 2019-05-08  Tom Tromey  <tom@tromey.com>
7576
7577         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7578         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7579         (_initialize_dwarf2_frame): Update.
7580
7581 2019-05-08  Tom Tromey  <tom@tromey.com>
7582
7583         * objc-lang.c (objc_objfile_data): Change type.
7584         (find_methods): Update.
7585         (_initialize_objc_lang): Remove.
7586
7587 2019-05-08  Tom Tromey  <tom@tromey.com>
7588
7589         * stabsread.c (rs6000_builtin_type_data): Change type.
7590         (rs6000_builtin_type, _initialize_stabsread): Update.
7591
7592 2019-05-08  Tom Tromey  <tom@tromey.com>
7593
7594         * mips-tdep.c (mips_pdr_data): Remove.
7595         (_initialize_mips_tdep): Update.
7596
7597 2019-05-08  Tom Tromey  <tom@tromey.com>
7598
7599         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7600         (hppa_init_objfile_priv_data, read_unwind_info)
7601         (find_unwind_entry, _initialize_hppa_tdep): Update.
7602
7603 2019-05-08  Tom Tromey  <tom@tromey.com>
7604
7605         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7606         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7607         on obstack.
7608         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7609
7610 2019-05-08  Tom Tromey  <tom@tromey.com>
7611
7612         * mdebugread.c (basic_type_data): Change type.
7613         (basic_type, _initialize_mdebugread): Update.
7614
7615 2019-05-08  Tom Tromey  <tom@tromey.com>
7616
7617         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7618
7619 2019-05-08  Tom Tromey  <tom@tromey.com>
7620
7621         * nto-tdep.c (nto_inferior_data_reg): Change type.
7622         (nto_inferior_data): Update.
7623         (nto_inferior_data_cleanup, nto_new_inferior_data)
7624         (_initialize_nto_tdep): Remove.
7625         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7626
7627 2019-05-08  Tom Tromey  <tom@tromey.com>
7628
7629         * ada-lang.c (struct ada_inferior_data): Add initializers.
7630         (ada_inferior_data): Change type.
7631         (ada_inferior_data_cleanup): Remove.
7632         (get_ada_inferior_data, ada_inferior_exit)
7633         (struct ada_pspace_data): Add initializers, destructor.
7634         (ada_pspace_data_handle): Change type.
7635         (get_ada_pspace_data): Update.
7636         (ada_pspace_data_cleanup): Remove.
7637
7638 2019-05-08  Tom Tromey  <tom@tromey.com>
7639
7640         * coffread.c (struct coff_symfile_info): Add initializers.
7641         (coff_objfile_data_key): Move lower.  Change type.
7642         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7643         Update.
7644         (coff_free_info): Remove.
7645
7646 2019-05-08  Tom Tromey  <tom@tromey.com>
7647
7648         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7649         (fbsd_pspace_data_handle): Move lower.  Change type.
7650         (get_fbsd_pspace_data): Update.
7651         (fbsd_pspace_data_cleanup): Remove.
7652         (_initialize_fbsd_tdep): Update.
7653
7654 2019-05-08  Tom Tromey  <tom@tromey.com>
7655
7656         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7657         (get_ada_tasks_pspace_data): Update.
7658         (ada_tasks_pspace_data_cleanup): Remove.
7659         (_initialize_tasks): Update.
7660         (ada_tasks_inferior_data_handle): Change type.
7661         (get_ada_tasks_inferior_data): Update.
7662         (ada_tasks_inferior_data_cleanup): Remove.
7663         (struct ada_tasks_pspace_data): Add initializers.
7664
7665 2019-05-08  Tom Tromey  <tom@tromey.com>
7666
7667         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7668         * symfile-debug.c (debug_sym_get_probes): Change type.
7669         * stap-probe.c (handle_stap_probe):
7670         (stap_static_probe_ops::get_probes): Change type.
7671         * probe.h (class static_probe_ops) <get_probes>: Change type.
7672         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7673         (parse_probes_in_pspace): Update.
7674         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7675         Update.
7676         (any_static_probe_ops::get_probes): Change type.
7677         * elfread.c (elfread_data): New typedef.
7678         (probe_key): Change type.
7679         (elf_get_probes): Likewise.  Update.
7680         (probe_key_free): Remove.
7681         (_initialize_elfread): Update.
7682         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7683         Change type.
7684         (dtrace_process_dof_probe, dtrace_process_dof)
7685         (dtrace_static_probe_ops::get_probe): Change type.
7686
7687 2019-05-08  Tom Tromey  <tom@tromey.com>
7688
7689         * xcoffread.c (struct xcoff_symfile_info): Rename from
7690         coff_symfile_info.  Add initializers.
7691         (xcoff_objfile_data_key): Move lower.  Change type.
7692         (XCOFF_DATA): Rewrite.
7693         (xcoff_free_info): Remove.
7694         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7695         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7696         (xcoff_initial_scan): Update.
7697
7698 2019-05-08  Tom Tromey  <tom@tromey.com>
7699
7700         * solib-svr4.c (struct svr4_info): Add initializers and
7701         destructor.
7702         <probes_table>: Now an htab_up.
7703         (solib_svr4_pspace_data): Change type.
7704         (free_probes_table): Simplify.
7705         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7706         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7707         (probes_table_remove_objfile_probes, register_solib_event_probe)
7708         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7709         (_initialize_svr4_solib): Update.
7710
7711 2019-05-08  Tom Tromey  <tom@tromey.com>
7712
7713         * remote.c (remote_pspace_data): Change type.
7714         (remote_pspace_data_cleanup): Remove.
7715         (get_remote_exec_file, set_pspace_remote_exec_file)
7716         (_initialize_remote): Update.
7717
7718 2019-05-08  Tom Tromey  <tom@tromey.com>
7719
7720         * breakpoint.c (breakpoint_objfile_key): Change type.
7721         (get_breakpoint_objfile_data): Update.
7722         (free_breakpoint_objfile_data): Remove.
7723         (_initialize_breakpoint): Update.
7724
7725 2019-05-08  Tom Tromey  <tom@tromey.com>
7726
7727         * linux-tdep.c (struct linux_info): Add initializers.
7728         (linux_inferior_data): Move.  Change type.
7729         (invalidate_linux_cache_inf): Update.
7730         (linux_inferior_data_cleanup): Remove.
7731         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7732
7733 2019-05-08  Tom Tromey  <tom@tromey.com>
7734
7735         * auxv.c (auxv_inferior_data): Move.  Change type.
7736         (auxv_inferior_data_cleanup): Remove.
7737         (invalidate_auxv_cache_inf): Rewrite.
7738         (get_auxv_inferior_data, _initialize_auxv): Update.
7739
7740 2019-05-08  Tom Tromey  <tom@tromey.com>
7741
7742         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7743         (symfile_debug_objfile_data_key): Change type.
7744         (symfile_debug_installed, debug_qf_has_symbols)
7745         (debug_qf_find_last_source_symtab)
7746         (debug_qf_forget_cached_source_info)
7747         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7748         (debug_qf_print_stats, debug_qf_dump)
7749         (debug_qf_expand_symtabs_for_function)
7750         (debug_qf_expand_all_symtabs)
7751         (debug_qf_expand_symtabs_with_fullname)
7752         (debug_qf_map_matching_symbols)
7753         (debug_qf_expand_symtabs_matching)
7754         (debug_qf_find_pc_sect_compunit_symtab)
7755         (debug_qf_map_symbol_filenames)
7756         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7757         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7758         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7759         (debug_sym_read_linetable, debug_sym_relocate): Update.
7760         (symfile_debug_free_objfile): Remove.
7761         (install_symfile_debug_logging, _initialize_symfile_debug):
7762         Update.
7763
7764 2019-05-08  Tom Tromey  <tom@tromey.com>
7765
7766         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7767         allocate_on_obstack.
7768         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7769         (get_dwarf2_per_objfile): Update.
7770         (set_dwarf2_per_objfile): Remove.
7771         (dwarf2_has_info, dwarf2_get_section_info): Update.
7772         (dwarf2_free_objfile): Remove.
7773         (_initialize_dwarf2_read): Update.
7774
7775 2019-05-08  Tom Tromey  <tom@tromey.com>
7776
7777         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7778         initializers.
7779         <unsupported_script_warning_printed,
7780         script_not_found_warning_printed>: Now bool.
7781         (auto_load_pspace_data): Change type.
7782         (~auto_load_pspace_info): Rename from
7783         auto_load_pspace_data_cleanup.
7784         (get_auto_load_pspace_data, init_loaded_scripts_info)
7785         (clear_section_scripts, maybe_print_unsupported_script_warning)
7786         (maybe_print_script_not_found_warning, _initialize_auto_load):
7787         Update.
7788
7789 2019-05-08  Tom Tromey  <tom@tromey.com>
7790
7791         * objfiles.c (objfile_pspace_info): Add destructor and
7792         initializers.
7793         (objfiles_pspace_data): Change type.
7794         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7795         (get_objfile_pspace_data): Update.
7796         (objfiles_bfd_data): Change type.
7797         (get_objfile_bfd_data): Update.
7798         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7799
7800 2019-05-08  Tom Tromey  <tom@tromey.com>
7801
7802         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7803         Change type.
7804         (get_catch_syscall_inferior_data): Update.
7805         (catch_syscall_inferior_data_cleanup): Remove.
7806         (_initialize_break_catch_syscall): Update.
7807
7808 2019-05-08  Tom Tromey  <tom@tromey.com>
7809
7810         * inflow.c (struct terminal_info): Add destructor and
7811         initializers.
7812         (inflow_inferior_data): Change type.
7813         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7814         (get_inflow_inferior_data, inflow_inferior_exit)
7815         (swap_terminal_info, _initialize_inflow): Update.
7816
7817 2019-05-08  Tom Tromey  <tom@tromey.com>
7818
7819         * target-dcache.c (target_dcache_cleanup): Remove.
7820         (target_dcache_aspace_key): Change type.
7821         (target_dcache_init_p, target_dcache_invalidate)
7822         (target_dcache_get, target_dcache_get_or_init)
7823         (_initialize_target_dcache): Update.
7824         * dcache.h (struct dcache_deleter): New.
7825
7826 2019-05-08  Tom Tromey  <tom@tromey.com>
7827
7828         * symtab.c (struct symbol_cache): Add destructor and
7829         initializers.
7830         (symbol_cache_key): Move.  Change type.
7831         (make_symbol_cache, free_symbol_cache): Remove.
7832         (get_symbol_cache): Update.
7833         (symbol_cache_cleanup): Remove.
7834         (ALL_PSPACES, symbol_cache_flush)
7835         (maintenance_print_symbol_cache)
7836         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7837         Update.
7838
7839 2019-05-08  Tom Tromey  <tom@tromey.com>
7840
7841         * symtab.c (struct main_info): Add destructor and initializers.
7842         (main_progspace_key): Move.  Change type.
7843         (get_main_info): Update.
7844         (main_info_cleanup): Remove.
7845         (_initialize_symtab): Update.
7846
7847 2019-05-08  Tom Tromey  <tom@tromey.com>
7848
7849         * registry.h (DECLARE_REGISTRY): Define the _key class.
7850
7851 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * NEWS: Merge two 'New commands' sections.
7854
7855 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7856
7857         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7858         parameter and use Ada language definition instead.
7859         (ada_val_print_ptr): Remove unused language parameter.
7860         (ada_val_print_num): Remove language parameter and use Ada language
7861         definition instead.
7862         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7863         parameter.
7864         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7865         parameter and use Ada language definition instead.
7866         (ada_val_print_1): Update all ada_val_print_xxx calls.
7867         Remove language parameter.
7868         (ada_val_print): Update ada_val_print_1 call.
7869
7870 2019-05-08  Tom Tromey  <tromey@adacore.com>
7871
7872         * remote.c (remote_hw_watchpoint_limit)
7873         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7874         Now static.
7875
7876 2019-05-08  Tom Tromey  <tromey@adacore.com>
7877
7878         * maint.c (_initialize_maint_cmds): Move initialization code to
7879         remote.c.
7880         (watchdog, show_watchdog): Move to remote.c.
7881         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7882         "watchdog" static.
7883         (_initialize_remote): Move initialization code from maint.c.
7884         * defs.h (watchdog): Don't declare.
7885
7886 2019-05-08  Tom Tromey  <tromey@adacore.com>
7887
7888         * tui/tui-interp.c: Include main.h.
7889         * interps.c: Include main.h.
7890         * main.h (interpreter_p): Declare.
7891         * defs.h (interpreter_p): Don't declare.
7892
7893 2019-05-08  Tom Tromey  <tromey@adacore.com>
7894
7895         * dwarf2loc.c: Include dwarf2read.h.
7896         * defs.h (read_unsigned_leb128): Don't declare.
7897         * dwarf2read.h (read_unsigned_leb128): Declare.
7898
7899 2019-05-08  Tom Tromey  <tromey@adacore.com>
7900
7901         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7902         method.
7903
7904 2019-05-08  Tom Tromey  <tromey@adacore.com>
7905
7906         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7907         when no wrap column is set.
7908
7909 2019-05-08  Tom Tromey  <tromey@adacore.com>
7910
7911         * c-lang.c (c_get_string): Handle non-C-style arrays.
7912
7913 2019-05-08  Tom Tromey  <tromey@adacore.com>
7914
7915         * typeprint.c (print_offset_data::update): Print the bit offset,
7916         not the number of bits remaining.
7917
7918 2019-05-08  Tom Tromey  <tromey@adacore.com>
7919
7920         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7921         padding at end of comment.
7922
7923 2019-05-08  Tom Tromey  <tromey@adacore.com>
7924
7925         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7926         Compare main types.
7927
7928 2019-05-06  Tom Tromey  <tom@tromey.com>
7929
7930         * common/scoped_mmap.c: Include common-defs.h.
7931         * common/scoped_mmap.h: Don't include config.h.
7932
7933 2019-05-04  Tom Tromey  <tom@tromey.com>
7934
7935         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7936         (struct aarch64_call_info): Add initializers.
7937         <si>: Now a std::vector.
7938         (pass_on_stack, aarch64_push_dummy_call): Update.
7939
7940 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7941             Tom Tromey  <tom@tromey.com>
7942
7943         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7944         (ppc_threads): Now a std::vector.  Now static.
7945         (hwdebug_find_thread_points_by_tid)
7946         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7947         Update.
7948
7949 2019-05-04  Tom Tromey  <tom@tromey.com>
7950
7951         * arc-tdep.c (arc_tdesc_init): Return bool.
7952
7953 2019-05-04  Tom Tromey  <tom@tromey.com>
7954
7955         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7956         Use gdb_assert_not_reached.
7957
7958 2019-05-04  Tom Tromey  <tom@tromey.com>
7959
7960         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7961         "false".
7962
7963 2019-05-04  Tom Tromey  <tom@tromey.com>
7964
7965         * arc-tdep.c (arc_tdesc_init): Use bool.
7966
7967 2019-05-04  Tom Tromey  <tom@tromey.com>
7968
7969         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7970
7971 2019-05-04  Tom Tromey  <tom@tromey.com>
7972
7973         * cli/cli-cmds.c (valid_command_p): Return bool.
7974
7975 2019-05-04  Tom Tromey  <tom@tromey.com>
7976
7977         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7978         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7979
7980 2019-05-04  Raul Tambre  <raul@tambre.ee>
7981
7982         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7983         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7984         operator for comparison.
7985
7986 2019-05-04  Tom Tromey  <tom@tromey.com>
7987
7988         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7989         (lookup_partial_symbol, print_partial_symbols)
7990         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7991         (psymbol_compare): Update.
7992         (add_psymbol_to_bcache): Clear the entire psymbol.
7993         (maintenance_check_psymtabs): Update.
7994         * psympriv.h (struct partial_symbol): Don't derive from
7995         general_symbol_info.
7996         <obj_section, unrelocated_address, address,
7997         set_unrelocated_address>: Update.
7998         <ginfo>: New member.
7999         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8000         (debug_names::write_psymbols): Update.
8001
8002 2019-05-04  Tom de Vries  <tdevries@suse.de>
8003
8004         * contrib/cc-with-tweaks.sh: Support -n arg.
8005
8006 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8007
8008         * corelow.c (core_target::detach): Ensure frame cache and
8009         register caches are cleared.
8010         inferior.c (exit_inferior_1): Likewise.
8011
8012 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8013             Tom Tromey  <tom@tromey.com>
8014
8015         * dictionary.c (collate_pending_symbols_by_language): Remove
8016         "struct" from foreach.
8017         * symtab.c (lookup_global_symbol_from_objfile)
8018         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8019         foreach.
8020         * ser-tcp.c (net_open): Remove "struct" from foreach.
8021         * objfiles.c (objfile_relocate, objfile_rebase)
8022         (objfile_has_symbols): Remove "struct" from foreach.
8023         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8024         from foreach.
8025         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8026         foreach.
8027         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8028         "struct" from foreach.
8029         * ada-lang.c (create_excep_cond_exprs)
8030         (ada_exception_catchpoint_cond_string): Remove "struct" from
8031         foreach.
8032
8033 2019-05-03  Tom Tromey  <tromey@adacore.com>
8034
8035         * ada-exp.y (convert_char_literal): Check suffix of each
8036         enumerator.
8037
8038 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8039
8040         PR ada/21406:
8041         * ada-exp.y (yywrap): Don't define.
8042         * ada-lex.l (%option): Add noyywrap
8043         (yywrap): Remove.
8044
8045 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8046
8047         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8048         _WIN32_WINNT to the XP level, unless already defined to a higher
8049         level.
8050
8051         * unittests/parse-connection-spec-selftests.c:
8052         * ser-tcp.c:
8053         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8054         override.
8055
8056         * symfile.c (find_separate_debug_file): Remove colon from the
8057         drive spec of DOS/Windows file names of the target, so that the
8058         file name produced from DEBUGDIR and the target's directory will
8059         be valid on DOS/Windows systems.
8060
8061 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8062
8063         * rust-lang.c (val_print_struct): Handle printing structures
8064         containing strings.
8065
8066 2019-05-02  Tom Tromey  <tromey@adacore.com>
8067
8068         * valarith.c (_initialize_valarith): Remove.
8069
8070 2019-05-01  Tom Tromey  <tromey@adacore.com>
8071
8072         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8073         bitfields.
8074
8075 2019-05-01  Tom Tromey  <tromey@adacore.com>
8076
8077         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8078         for big-endian copies.
8079
8080 2019-04-30  Ali Tamur  <tamur@google.com>
8081         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8082         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8083         (read_3_bytes): New function.
8084
8085 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8086
8087         * windows-nat.c (main_thread_id): Delete.
8088         (handle_output_debug_string): Replace main_thread_id by
8089         current_event.dwThreadId.
8090         (fake_create_process): Likewise.
8091         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8092         Do not set main_thread_id.
8093         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8094         current_event.dwThreadId.
8095         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8096
8097 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8098
8099         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8100         Use current_event.dwThreadId instead of main_thread_id.
8101
8102 2019-04-30  Tom Tromey  <tromey@adacore.com>
8103
8104         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8105         (create_excep_cond_exprs): Iterate over program spaces.
8106         (ada_exception_catchpoint_cond_string): Examine all minimal
8107         symbols for exception types.
8108
8109 2019-04-30  Tom Tromey  <tromey@adacore.com>
8110
8111         PR c++/24470:
8112         * dwarf2read.c (process_structure_scope): Handle case where type
8113         has template parameters but no symbol was created.
8114
8115 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8116             Chris January  <chris.january@arm.com>
8117
8118         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8119         qualifier.
8120         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8121
8122 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8123
8124         * f-typeprint.c (f_print_type): Update rules for printing
8125         whitespace.
8126         (f_type_print_varspec_suffix): Likewise.
8127
8128 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8129             Chris January  <chris.january@arm.com>
8130
8131         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8132         function arguments.
8133
8134 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * f-lang.c (build_fortran_types): Change name of void type to
8137         lower case.
8138         * f-typeprint.c (f_type_print_base): Print the name of the void
8139         type, rather than a fixed string.
8140         * f-valprint.c (f_decorations): Use lower case void string.
8141
8142 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8143             Chris January  <chris.january@arm.com>
8144
8145         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8146         types for Fortran.
8147
8148 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8149             Chris January  <chris.january@arm.com>
8150             David Lecomber  <david.lecomber@arm.com>
8151
8152         * f-exp.y (BINOP_INTRINSIC): New token.
8153         (exp): New parser rule handling BINOP_INTRINSIC.
8154         (f77_keywords): Add new builtin procedures.
8155         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8156         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8157         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8158         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8159         (print_unop_subexp_f): New function.
8160         (print_binop_subexp_f): New function.
8161         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8162         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8163         (dump_subexp_body_f): Likewise.
8164         (operator_check_f): Likewise.
8165         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8166         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8167
8168 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8169
8170         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8171         UNOP_KIND.
8172         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8173         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8174         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8175         (operator_length_f): New fuction.
8176         (print_subexp_f): New function.
8177         (op_name_f): New function.
8178         (dump_subexp_body_f): New function.
8179         (operator_check_f): New function.
8180         (exp_descriptor_f): Replace standard expression handling functions
8181         with new functions.
8182         * gdb/fortran-operator.def: New file.
8183         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8184         * gdb/std-operator.def: Remove UNOP_KIND.
8185
8186 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8187
8188         * std-operator.def: Remove unbalanced, stray double quote
8189         character.
8190
8191 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8192             Chris January  <chris.january@arm.com>
8193             Daniel Everett  <daniel.everett@arm.com>
8194             Nick Forrington  <nick.forrington@arm.com>
8195             Richard Bunt  <richard.bunt@arm.com>
8196
8197         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8198         of depth when printing anonymous structs or unions.
8199         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8200         Don't print either the top-level value, or the children if the
8201         max-depth is exceeded.
8202         (ppscm_print_children): When printing the key of a map, allow one
8203         extra level of depth.
8204         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8205         print either the top-level value, or the children if the max-depth
8206         is exceeded.
8207         (print_children): When printing the key of a map, allow one extra
8208         level of depth.
8209         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8210         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8211         (user_print_options): Initialise max_depth field.
8212         (val_print_scalar_or_string_type_p): New function.
8213         (val_print): Check to see if the max depth has been reached.
8214         (val_print_check_max_depth): Define new function.
8215         (show_print_max_depth): New function.
8216         (_initialize_valprint): Add 'print max-depth' option.
8217         * valprint.h (struct value_print_options) <max_depth>: New field.
8218         (val_print_check_max_depth): Declare new function.
8219         * NEWS: Document new feature.
8220
8221 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8222
8223         * ada-lang.c (ada_language_defn): Initialise new field.
8224         * c-lang.c (c_is_string_type_p): New function.
8225         (c_language_defn): Initialise new field.
8226         (cplus_language_defn): Initialise new field.
8227         (asm_language_defn): Initialise new field.
8228         (minimal_language_defn): Initialise new field.
8229         * c-lang.h (c_is_string_type_p): Declare new function.
8230         * d-lang.c (d_language_defn): Initialise new field.
8231         * f-lang.c (f_is_string_type_p): New function.
8232         (f_language_defn): Initialise new field.
8233         * go-lang.c (go_is_string_type_p): New function.
8234         (go_language_defn): Initialise new field.
8235         * language.c (default_is_string_type_p): New function.
8236         (unknown_language_defn): Initialise new field.
8237         (auto_language_defn): Initialise new field.
8238         * language.h (struct language_defn) <la_is_string_type_p>: New
8239         member variable.
8240         (default_is_string_type_p): Declare new function.
8241         * m2-lang.c (m2_language_defn): Initialise new field.
8242         * objc-lang.c (objc_language_defn): Initialise new field.
8243         * opencl-lang.c (opencl_language_defn): Initialise new field.
8244         * p-lang.c (pascal_is_string_type_p): New function.
8245         (pascal_language_defn): Initialise new field.
8246         * rust-lang.c (rust_is_string_type_p): New function.
8247         (rust_language_defn): Initialise new field.
8248
8249 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8250
8251         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8252         New field.
8253         * ada-lang.c (ada_language_defn): Initialise new field.
8254         * c-lang.c (c_language_defn): Likewise.
8255         (cplus_language_defn): Likewise.
8256         (asm_language_defn): Likewise.
8257         (minimal_language_defn): Likewise.
8258         * d-lang.c (d_language_defn): Likewise.
8259         * f-lang.c (f_language_defn): Likewise.
8260         * go-lang.c (go_language_defn): Likewise.
8261         * language.c (unknown_language_defn): Likewise.
8262         (auto_language_defn): Likewise.
8263         * m2-lang.c (m2_language_defn): Likewise.
8264         * objc-lang.c (objc_language_defn): Likewise.
8265         * opencl-lang.c (opencl_language_defn): Likewise.
8266         * p-lang.c (pascal_language_defn): Likewise.
8267         * rust-lang.c (rust_language_defn): Likewise.
8268
8269 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8270
8271         * ada-lang.c (ada_is_character_type): Change return type to bool.
8272         (ada_is_string_type): Likewise.
8273         * ada-lang.h (ada_is_character_type): Update declaration
8274         (ada_is_string_type): Likewise.
8275
8276 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8277
8278         Support style in 'frame|thread apply'
8279
8280         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8281         * record.c (record_start, record_stop): Update callers of
8282         execute_command_to_string with false.
8283         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8284         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8285         methods.
8286         (class string_file): New constructor with term_out parameter.
8287         Override methods term_out and can_emit_style_escape.  New member
8288         term_out.
8289         (class stdio_file): Override can_emit_style_escape.
8290         (class tee_file): Override term_out and can_emit_style_escape.
8291         * utils.h (can_emit_style_escape): Remove.
8292         * utils.c (can_emit_style_escape): Likewise.
8293         Update all callers of can_emit_style_escape (SOMESTREAM) to
8294         SOMESTREAM->can_emit_style_escape.
8295         * source-cache.c (source_cache::get_source_lines): Likewise.
8296         * stack.c (frame_apply_command_count): Call execute_command_to_string
8297         passing the term_out characteristic of the current gdb_stdout.
8298         * thread.c (thr_try_catch_cmd): Likewise.
8299         * top.c (execute_command_to_string): pass term_out parameter
8300         to construct the string_file for the command output.
8301         * ui-file.c (term_cli_styling): New function (most code moved
8302         from utils.c can_emit_style_escape).
8303         (string_file::string_file, string_file::can_emit_style_escape,
8304         stdio_file::can_emit_style_escape, tee_file::term_out,
8305         tee_file::can_emit_style_escape): New functions.
8306
8307 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8308
8309         * NEWS: Mention the new set|show may-call-functions.
8310         * infcall.c (may_call_functions_p): New variable.
8311         (show_may_call_functions_p): New function.
8312         (call_function_by_hand_dummy): Throws an error if not
8313         may-call-functions.
8314         (_initialize_infcall): Call add_setshow_boolean_cmd for
8315         may-call-functions.
8316
8317 2019-04-25  Keith Seitz  <keiths@redhat.com>
8318
8319         PR c++/24367
8320         * cp-support.c (inspect_type): Don't attempt substitutions
8321         of symbol with the same name.
8322
8323 2019-04-25  Tom Tromey  <tromey@adacore.com>
8324
8325         PR gdb/24475:
8326         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8327         static.
8328
8329 2019-04-25  Tom Tromey  <tromey@adacore.com>
8330
8331         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8332         rvalue reference.
8333         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8334         (gdb_xml_parser::parse): Use std::move.
8335         * python/python-internal.h (gdbpy_convert_exception): Take a const
8336         reference.
8337         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8338         std::move.
8339         * python/py-utils.c (gdbpy_convert_exception): Take a const
8340         reference.
8341         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8342         Use std::move.
8343         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8344         Use std::move.
8345         * mi/mi-main.c (mi_print_exception): Take a const reference.
8346         * main.c (handle_command_errors): Take a const reference.
8347         * linespec.c (parse_linespec): Use std::move.
8348         * infcall.c (run_inferior_call): Use std::move.
8349         (call_function_by_hand_dummy): Use std::move.
8350         * exec.c (try_open_exec_file): Use std::move.
8351         * exceptions.h (exception_print, exception_fprintf)
8352         (exception_print_same): Update.
8353         * exceptions.c (print_exception, exception_print)
8354         (exception_fprintf, exception_print_same): Change parameters to
8355         const reference.
8356         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8357         * common/new-op.c: Use std::move.
8358         * common/common-exceptions.h (struct gdb_exception): Add move
8359         constructor.
8360         (struct gdb_exception_error, struct gdb_exception_quit, struct
8361         gdb_quit_bad_alloc): Change constructor to move constructor.
8362         (throw_exception): Change parameter to rvalue reference.
8363         * common/common-exceptions.c (throw_exception): Take rvalue
8364         reference.
8365         * cli/cli-interp.c (safe_execute_command): Use std::move.
8366         * breakpoint.c (insert_bp_location, location_to_sals): Use
8367         std::move.
8368
8369 2019-04-25  Tom Tromey  <tromey@adacore.com>
8370
8371         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8372         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8373         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8374         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8375         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8376         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8377         guile/scm-value.c: Use unpack.
8378         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8379         gdbscm_gdb_exception.
8380         (gdbscm_throw_gdb_exception): Likewise.
8381         (struct gdbscm_gdb_exception): New.
8382         (unpack): New function.
8383         (gdbscm_wrap): Use unpack.
8384
8385 2019-04-25  Tom Tromey  <tromey@adacore.com>
8386
8387         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8388         (gdb_rl_callback_handler): Use std::move.
8389         * common/common-exceptions.h (struct gdb_exception): Add move
8390         assignment operator.
8391         (throw_exception_sjlj): Change "exception" to const reference.
8392         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8393         (throw_exception_sjlj): Change "exception" to const reference.
8394
8395 2019-04-25  Tom Tromey  <tromey@adacore.com>
8396
8397         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8398         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8399         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8400         Update.
8401         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8402         Update.
8403         * mi/mi-interp.c (mi_interp::exec): Update.
8404         * linespec.c (parse_linespec): Update.
8405         * infcall.c (run_inferior_call): Update.
8406         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8407         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8408         (gdbscm_lookup_global_symbol): Update.
8409         * guile/scm-param.c (gdbscm_parameter_value): Update.
8410         * guile/scm-frame.c (gdbscm_frame_read_register)
8411         (gdbscm_frame_read_var): Update.
8412         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8413         * exec.c (try_open_exec_file): Update.
8414         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8415         (gdb_rl_callback_handler): Update.
8416         * common/common-exceptions.h (exception_none): Don't declare.
8417         * common/common-exceptions.c (exception_none): Don't define.
8418         (struct catcher) <exception>: Update.
8419         * cli/cli-interp.c (safe_execute_command): Update.
8420         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8421
8422 2019-04-25  Ali Tamur  <tamur@google.com>
8423
8424         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8425         (read_attribute_value): Likewise.
8426         (dwarf2_read_addr_index): Update comment.
8427         (read_str_index): Add DW_FORM_strx.
8428         (dwarf2_string_attr): Likewise.
8429         (dwarf2_const_value_attr): Likewise.
8430         (dump_die_shallow): Likewise.
8431         (dwarf2_fetch_constant_bytes): Likewise.
8432         (skip_form_bytes): Likewise.
8433         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8434
8435 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8436
8437         PR corefiles/11608
8438         PR corefiles/18187
8439         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8440         OFFSET.  Verify if current mapping contains an ELF header.
8441         (linux_find_memory_regions_full): Adjust call to
8442         dump_mapping_p.
8443
8444 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8445             Kang Li <kanglictf@gmail.com>
8446
8447         PR gdb/21600
8448
8449         * dwarf2-frame.c (read_initial_length): Be consistent about using
8450         unsigned representation of length.
8451         (decode_frame_entry_1): Likewise.  Check for wraparound of
8452         end pointer as well as buffer overflow.
8453
8454 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8455
8456         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8457         "vq".
8458
8459 2019-04-24  Tom Tromey  <tromey@adacore.com>
8460
8461         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8462
8463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8464
8465         * s12z-tdep.c (s12z_unwind_pc): Delete.
8466         (s12z_unwind_sp): Delete.
8467         (s12z_gdbarch_init): Don't register deleted functions with
8468         gdbarch.
8469
8470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8471
8472         * rl78-tdep.c (rl78_unwind_sp): Delete.
8473         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8474
8475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8476
8477         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8478         (xstormy16_unwind_pc): Delete.
8479         (xstormy16_dummy_id): Delete.
8480         (xstormy16_gdbarch_init): Don't register deleted functions with
8481         gdbarch.
8482
8483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8484
8485         * vax-tdep.c (vax_unwind_pc): Delete.
8486         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8487
8488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8489
8490         * v850-tdep.c (v850_unwind_sp): Delete.
8491         (v850_unwind_pc): Delete.
8492         (v850_dummy_id): Delete.
8493         (v850_gdbarch_init): Don't register deleted functions with
8494         gdbarch.
8495
8496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8497
8498         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8499         (tilegx_unwind_pc): Delete.
8500         (tilegx_unwind_dummy_id): Delete.
8501         (tilegx_gdbarch_init): Don't register deleted functions with
8502         gdbarch.
8503
8504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8505
8506         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8507         (tic6x_dummy_id): Delete.
8508         (tic6x_gdbarch_init): Don't register deleted functions with
8509         gdbarch.
8510
8511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8512
8513         * sparc-tdep.c (sparc_unwind_pc): Delete.
8514         (sparc32_gdbarch_init): Don't register deleted function with
8515         gdbarch.
8516
8517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8518
8519         * sh-tdep.c (sh_unwind_sp): Delete.
8520         (sh_unwind_pc): Delete.
8521         (sh_dummy_id): Delete.
8522         (sh_gdbarch_init): Don't register deleted functions with
8523         gdbarch.
8524
8525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8526
8527         * score-tdep.c (score_unwind_sp): Delete.
8528         (score_unwind_pc): Delete.
8529         (score_dummy_id): Delete.
8530         (score_gdbarch_init): Don't register deleted functions with
8531         gdbarch.
8532
8533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8534
8535         * rx-tdep.c (rx_unwind_pc): Delete.
8536         (rx_unwind_sp): Delete.
8537         (rx_dummy_id): Delete.
8538         (rx_gdbarch_init): Don't register deleted functions with
8539         gdbarch.  Update comment.
8540
8541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8542
8543         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8544         (rs6000_dummy_id): Delete.
8545         (rs6000_gdbarch_init): Don't register deleted functions with
8546         gdbarch.
8547
8548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8549
8550         * or1k-tdep.c (or1k_dummy_id): Delete.
8551         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8552
8553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8554
8555         * nios2-tdep.c (nios2_dummy_id): Delete.
8556         (nios2_unwind_sp): Delete.
8557         (nios2_gdbarch_init): Don't register deleted functions with
8558         gdbarch.
8559
8560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8561
8562         * nds32-tdep.c (nds32_dummy_id): Delete.
8563         (nds32_unwind_pc): Delete.
8564         (nds32_unwind_sp): Delete.
8565         (nds32_gdbarch_init): Don't register deleted functions with
8566         gdbarch.
8567
8568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8569
8570         * msp430-tdep.c (msp430_unwind_pc): Delete.
8571         (msp430_unwind_sp): Delete.
8572         (msp430_dummy_id): Delete.
8573         (msp430_gdbarch_init): Don't register deleted functions with
8574         gdbarch.
8575
8576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8577
8578         * moxie-tdep.c (moxie_unwind_sp): Delete.
8579         (moxie_unwind_pc): Delete.
8580         (moxie_dummy_id): Delete.
8581         (moxie_gdbarch_init): Don't register deleted functions with
8582         gdbarch.
8583
8584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8585
8586         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8587         (mn10300_unwind_pc): Delete.
8588         (mn10300_unwind_sp): Delete.
8589         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8590         mn10300_unwind_sp.
8591         (mn10300_frame_unwind_init): Don't register deleted functions with
8592         gdbarch.
8593
8594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8595
8596         * mep-tdep.c (mep_unwind_pc): Delete.
8597         (mep_unwind_sp): Delete.
8598         (mep_dummy_id): Delete.
8599         (mep_gdbarch_init): Don't register deleted functions with
8600         gdbarch.
8601
8602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8603
8604         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8605         (m68hc11_unwind_sp): Delete.
8606         (m68hc11_gdbarch_init): Don't register deleted functions with
8607         gdbarch.
8608
8609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8610
8611         * m32r-tdep.c (m32r_unwind_sp): Delete.
8612         (m32r_unwind_pc): Delete.
8613         (m32r_dummy_id): Delete.
8614         (m32r_gdbarch_init): Don't register deleted functions with
8615         gdbarch.
8616
8617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8618
8619         * m32c-tdep.c (m32c_unwind_pc): Delete.
8620         (m32c_unwind_sp): Delete.
8621         (m32c_dummy_id): Delete.
8622         (m32c_gdbarch_init): Don't register deleted functions with
8623         gdbarch.
8624
8625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8626
8627         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8628         (lm32_unwind_pc): Delete.
8629         (lm32_dummy_id): Delete.
8630         (lm32_gdbarch_init): Don't register deleted functions with
8631         gdbarch.
8632
8633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8634
8635         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8636         (iq2000_unwind_pc): Delete.
8637         (iq2000_dummy_id): Delete.
8638         (iq2000_gdbarch_init): Don't register deleted functions with
8639         gdbarch.
8640
8641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8642
8643         * nds32-tdep.c (nds32_type_align): Delete.
8644         (nds32_push_dummy_call): Use type_align instead.
8645
8646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8647
8648         * arm-tdep.c (arm_type_align): Only handle vector override case.
8649         (arm_push_dummy_call): Use type_align.
8650         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8651
8652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8653
8654         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8655         case.
8656         (pass_on_stack): Use type_align.
8657         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8658         function.
8659
8660 2019-04-23  Tom Tromey  <tromey@adacore.com>
8661
8662         * dwarf2read.c (line_header::file_name_at): Remove unused
8663         overload.
8664
8665 2019-04-23  Tom de Vries  <tdevries@suse.de>
8666
8667         PR gdb/24438
8668         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8669         invocation.
8670
8671
8672 2019-03-27  Ali Tamur  <tamur@google.com>
8673
8674         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8675         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8676         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8677         (dwarf_expr_context::get_addr_index): Likewise
8678         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8679         (symbol_needs_eval_context::get_addr_index): Likewise
8680         (disassemble_dwarf_expression): Add DW_OP_addrx
8681         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8682         (read_cutu_die_from_dwo): Update comment
8683         (skip_one_die): Add DW_FORM_addrx
8684         (read_attribute_value): Likewise
8685         (var_decode_location): Add DW_OP_addrx
8686         (dwarf2_const_value_attr): Add DW_FORM_addrx
8687         (dump_die_shallow): Likewise
8688         (dwarf2_fetch_constant_bytes): Likewise
8689         (decode_locdesc): Add DW_OP_addrx
8690         (skip_form_bytes): Add DW_FORM_addrx
8691
8692 2019-04-22  Ali Tamur  <tamur@google.com>
8693
8694         * MAINTAINERS (Write After Approval): Add self.
8695
8696 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8697
8698         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8699         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8700         (open_symbol_file_object): Likewise.
8701         (svr4_default_sos): Add info parameter.
8702         (svr4_read_so_list): Likewise.
8703         (svr4_current_sos_direct): Adjust functions calls to pass down
8704         info.
8705         (svr4_current_sos_1): Add info parameter.
8706         (svr4_current_sos): Call get_svr4_info, pass info down to
8707         svr4_current_sos_1.
8708         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8709         get_svr4_info.
8710         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8711         get_svr4_info.
8712         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8713         to get_svr4_info.
8714         (probes_table_remove_objfile_probes): Likewise.
8715         (register_solib_event_probe): Add info parameter.
8716         (solist_update_incremental): Pass info parameter down to
8717         svr4_read_so_list.
8718         (disable_probes_interface): Add info parameter.
8719         (svr4_handle_solib_event): Pass current_program_space to
8720         get_svr4_info.  Adjust disable_probes_interface cleanup.
8721         (svr4_create_probe_breakpoints): Add info parameter, pass it
8722         down to register_solib_event_probe.
8723         (svr4_create_solib_event_breakpoints): Add info parameter,
8724         pass it down to svr4_create_probe_breakpoints.
8725         (enable_break): Pass info down to
8726         svr4_create_solib_event_breakpoints.
8727         (svr4_solib_create_inferior_hook): Pass current_program_space to
8728         get_svr4_info.
8729         (svr4_clear_solib): Likewise.
8730
8731 2019-04-22  Pedro Alves  <palves@redhat.com>
8732
8733         * solib-svr4.c (svr4_free_objfile_observer): New.
8734         (probe_and_action::objfile): New field.
8735         (probes_table_htab_remove_objfile_probes)
8736         (probes_table_remove_objfile_probes): New functions.
8737         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8738         in the new probe_and_action.  Don't store the probe in 'lookup'.
8739         (svr4_create_probe_breakpoints): Pass objfile to
8740         register_solib_event_probe.
8741         (_initialize_svr4_solib): Register a free_objfile observer.
8742
8743 2019-04-19  Tom Tromey  <tom@tromey.com>
8744
8745         * common/queue.h: Remove.
8746
8747 2019-04-19  Tom Tromey  <tom@tromey.com>
8748
8749         * event-loop.c: Don't include "common/queue.h".
8750
8751 2019-04-19  Tom Tromey  <tom@tromey.com>
8752
8753         * remote.c (remote_target): Use delete.
8754         * remote-notif.h: Include <list>, not "common/queue.h".
8755         (notif_client_p): Remove typedef.
8756         (remote_notif_state): Add constructor, destructor, initializer.
8757         <notif_queue>: Now a std::list.
8758         (remote_notif_state_xfree): Don't declare.
8759         * remote-notif.c (remote_notif_process, handle_notification)
8760         (remote_notif_state_allocate): Update.
8761         (~remote_notif_state): Rename from remote_notif_state_xfree.
8762
8763 2019-04-19  Tom Tromey  <tom@tromey.com>
8764
8765         * symfile.c (reread_symbols): Update.
8766         * objfiles.c (objfile_register_static_link)
8767         (objfile_lookup_static_link): Update
8768         (~objfile) Don't delete static_links.
8769         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8770
8771 2019-04-19  Tom Tromey  <tom@tromey.com>
8772
8773         * type-stack.h (struct type_stack) <insert>: Constify string.
8774         * type-stack.c (type_stack::insert): Constify string.
8775         * gdbtypes.h (lookup_template_type): Update.
8776         (address_space_name_to_int): Update.
8777         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8778         const.
8779         (lookup_template_type): Make name const.
8780         * c-exp.y: Update rules.
8781         (lex_one_token, classify_name, classify_inner_name)
8782         (c_print_token): Update.
8783         * p-exp.y: Update rules.
8784         (yylex): Update.
8785         * f-exp.y: Update rules.
8786         (yylex): Update.
8787         * d-exp.y: Update rules.
8788         (lex_one_token, classify_name, classify_inner_name): Update.
8789         * parse.c (write_dollar_variable, copy_name): Return std::string.
8790         * parser-defs.h (copy_name): Change return type.
8791         * m2-exp.y: Update rules.
8792         (yylex): Update.
8793         * go-exp.y (lex_one_token): Update.
8794         Update rules.
8795         (classify_unsafe_function, classify_packaged_name)
8796         (classify_name, yylex): Update.
8797
8798 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8799
8800         * configure.ac: add --enable-source-highlight switch.
8801         * configure: Regenerate.
8802         * top.c (print_gdb_version): plumb --enable-source-highlight
8803         status to "show configuration".
8804
8805 2019-04-19  Tom Tromey  <tromey@adacore.com>
8806
8807         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8808         Check ADA_TYPE_P.
8809         (empty_record, ada_template_to_fixed_record_type_1)
8810         (template_to_static_fixed_type)
8811         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8812         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8813         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8814         macros.
8815
8816 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8817
8818         PR symtab/24423:
8819         * source.c (print_source_lines_base): Advance "iter" when a
8820         control character is seen.
8821
8822 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8823
8824         * inferior.h (struct infcall_suspend_state_deleter):
8825         Catch exception in destructor to avoid crash.
8826
8827 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8828
8829         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8830         close to the add_com "shell".
8831
8832 2019-04-18  Tom Tromey  <tromey@adacore.com>
8833
8834         * process-stratum-target.h (class process_stratum_target)
8835         <stratum>: Add "final".
8836
8837 2019-04-17  Tom Tromey  <tromey@adacore.com>
8838
8839         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8840         against nullptr before use.
8841
8842 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8843
8844         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8845
8846 2019-04-17  Jim Wilson  <jimw@sifive.com>
8847             Andrew Burgess  <andrew.burgess@embecosm.com>
8848
8849         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8850         code read might fail, assume 4-byte breakpoint in that case.
8851
8852 2019-04-15  Leszek Swirski  <leszeks@google.com>
8853
8854         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8855         rather than a hand-rolled POD check when checking for forced MEMORY
8856         classification.
8857
8858 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8859
8860         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8861         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8862         function.
8863         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8864         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8865         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8866         declaration.
8867
8868 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8869
8870         * aarch64-linux-nat.c
8871         (aarch64_linux_nat_target::thread_architecture): Add override.
8872         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8873         each VQ.
8874
8875 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8876
8877         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8878
8879 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8880
8881         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8882         target types of size 96-bits, add some additional comments, and
8883         check that the builtin type we found was the correct size.
8884
8885 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8886
8887         * utils.c (prompt_for_continue): Don't restore the styling at the
8888         end, as applied_style has the wrong value.  This fixes styling in
8889         long lists of file names that are interrupted by the "Continue?"
8890         prompt.
8891
8892 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8893
8894         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8895         * c-lang.c (c_language_defn): Likewise.
8896         (cplus_language_defn): Likewise.
8897         (asm_language_defn): Likewise.
8898         (minimal_language_defn): Likewise.
8899         * d-lang.c (d_language_defn): Likewise.
8900         * f-lang.c (f_language_defn): Likewise.
8901         * go-lang.c (go_language_defn): Likewise.
8902         * language.c (unknown_language_defn): Likewise.
8903         (auto_language_defn): Likewise.
8904         * language.h (struct language_defn): Remove la_magic field.
8905         (LANG_MAGIC): Delete.
8906         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8907         * objc-lang.c (objc_language_defn): Likewise.
8908         * opencl-lang.c (opencl_language_defn): Likewise.
8909         * p-lang.c (pascal_language_defn): Likewise.
8910         * rust-lang.c (rust_language_defn): Likewise.
8911
8912 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * riscv-tdep.c (riscv_type_align): New function.
8915         (riscv_type_alignment): Delete.
8916         (riscv_arg_location): Use 'type_align'.
8917         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8918
8919 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8920
8921         * gdbtypes.c (type_align): A struct with no non-static fields also
8922         has alignment of 1.
8923
8924 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8927         component to 0.
8928         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8929         member.
8930         (riscv_struct_info::analyse): New implementation using new
8931         analyse_inner member function.
8932         (riscv_struct_info::field_offset): New member function.
8933         (riscv_struct_info::m_offsets): New member variable.
8934         (riscv_struct_info::analyse_inner): New private member function,
8935         takes the old implementation of riscv_struct_info::analyse but
8936         extended to track field offsets.
8937         (riscv_call_arg_struct): Update the struct folding special cases
8938         to handle cases where empty C++ structs, which are non-zero
8939         length, are found.
8940         (riscv_arg_location): Initialise the length of each location, a
8941         non-zero length now indicates the location is in use.
8942         (riscv_push_dummy_call): Allow for the first location having a
8943         non-zero offset when setting up arguments.
8944         (riscv_return_value): Likewise, but for return values.
8945
8946 2019-04-11  Tom Tromey  <tromey@adacore.com>
8947
8948         * utils.c (internal_vproblem): Make "msg" const.
8949
8950 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8951
8952         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8953         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8954         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8955         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8956
8957 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8958
8959         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8960         function.
8961         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8962         of amd64_collect_native_gregset.
8963         (amd64_linux_nat_target::store_registers): Likewise.
8964
8965 2019-04-10  Tom Tromey  <tom@tromey.com>
8966
8967         * symtab.c (lookup_global_symbol_from_objfile)
8968         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8969         * objfiles.h (class separate_debug_iterator): New.
8970         (class separate_debug_range): New.
8971         (struct objfile) <separate_debug_objfiles>: New method.
8972         (objfile_separate_debug_iterate): Don't declare.
8973         * objfiles.c (separate_debug_iterator::operator++): Rename from
8974         objfile_separate_debug_iterate.
8975         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8976         iterator.
8977         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8978         iterator.
8979
8980 2019-04-10  Tom Tromey  <tom@tromey.com>
8981
8982         * symfile.c (reread_symbols): Remove old comment.
8983         * objfiles.c (free_all_objfiles): Fix a typo.
8984
8985 2019-04-10  Tom Tromey  <tom@tromey.com>
8986
8987         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8988         * minsyms.c (lookup_minimal_symbol): Use foreach.
8989         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8990         (lookup_minimal_symbol_solib_trampoline): Likewise.
8991         * symfile.c (reread_symbols): Use foreach.
8992
8993 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8994             Tom Tromey  <tromey@adacore.com>
8995
8996         PR rust/24414:
8997         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8998         (rust_lex_int_test): Change "value" to be LONGEST.
8999         (rust_lex_tests): Add test for long integer literal.
9000
9001 2019-04-09  Tom Tromey  <tromey@adacore.com>
9002
9003         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9004         to bool.
9005         (extended_remote_target::attach): Update.
9006         (remote_target::remote_notice_new_inferior): Update.
9007         (remote_target::add_current_inferior_and_thread): Update.
9008         * inferior.c (exit_inferior_1): Use "false".
9009         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9010
9011 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9012
9013         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9014         the "start" command.
9015
9016 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9017
9018         * python/py-inferior.c (infpy_thread_from_thread_handle):
9019         Adjust comments to reflect renaming of thread_from_thread_handle
9020         to thread_from_handle.  Adjust keywords.  Fix type error message.
9021         (inferior_object_methods): Add thread_from_handle.  Retain
9022         thread_from_thread_handle, but mark it as deprecated.
9023
9024 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9025
9026         * gdbthread.h (find_thread_by_handle): Revise declaration.
9027         * thread.c (find_thread_by_handle): Likewise.  Adjust
9028         implementation too.
9029         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9030         support for buffer objects as handles.
9031
9032 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9033
9034         * python/py-infthread.c (thpy_thread_handle): New function.
9035         (thread_object_methods): Register thpy_thread_handle.
9036
9037 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9038
9039         * gdbthread.h (thread_to_thread_handle): Declare.
9040         * thread.c (gdbtypes.h): Include.
9041         (thread_to_thread_handle): New function.
9042
9043         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9044         (target_thread_info_to_thread_handle): Declare.
9045         * target.c (target_thread_info_to_thread_handle): New function.
9046         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9047         * target-delegates.c: Regenerate.
9048
9049         * linux-thread-db.c (class thread_db_target): Add method
9050         thread_info_to_thread_handle.
9051         (thread_db_target::thread_info_to_thread_handle): Define.
9052         * remote.c (class remote_target): Add new method
9053         thread_info_to_thread_handle.
9054         (remote_target::thread_info_to_thread_handle): Define.
9055
9056 2019-04-08  Pedro Alves  <palves@redhat.com>
9057
9058         * common/common-exceptions.c (throw_exception): Don't create
9059         named object to throw; throw directly.
9060         (throw_it): Likewise.  Don't initialize gdb_exception::message
9061         here, with new; pass FMT and AP to the ctor instead.
9062         * common/common-exceptions.h: Include <string>.
9063         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9064         const char *, va_list)): New ctor.  Use std::make_shared.
9065         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9066         errors)): Delete.
9067         (gdb_exception_error::gdb_exception_error(enum errors, const char
9068         *, va_list)): New.
9069         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9070         Add assertion.
9071         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9072         errors)): Delete.
9073         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9074         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9075         Add assertion.
9076
9077 2019-04-08  Tom Tromey  <tom@tromey.com>
9078
9079         * valops.c (value_rtti_indirect_type): Replace throw_exception
9080         with throw.
9081         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9082         with throw.
9083         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9084         throw.
9085         * target.c (target_translate_tls_address): Replace throw_exception
9086         with throw.
9087         * stack.c (frame_apply_command_count): Replace throw_exception
9088         with throw.
9089         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9090         throw.
9091         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9092         with throw.
9093         * rs6000-tdep.c (rs6000_frame_cache)
9094         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9095         * remote.c: Replace throw_exception with throw.
9096         * record-full.c (record_full_message, record_full_wait_1)
9097         (record_full_restore): Replace throw_exception with throw.
9098         * record-btrace.c:
9099         (get_thread_current_frame_id, record_btrace_start_replaying)
9100         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9101         (cmd_record_btrace_start): Replace throw_exception with throw.
9102         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9103         throw.
9104         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9105         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9106         * linespec.c:
9107         (find_linespec_symbols): Replace throw_exception with throw.
9108         * infrun.c (displaced_step_prepare, resume): Replace
9109         throw_exception with throw.
9110         * infcmd.c (post_create_inferior): Replace throw_exception with
9111         throw.
9112         * inf-loop.c (inferior_event_handler): Replace throw_exception
9113         with throw.
9114         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9115         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9116         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9117         (get_prev_frame_always, get_frame_pc_if_available)
9118         (get_frame_address_in_block_if_available, get_frame_language):
9119         Replace throw_exception with throw.
9120         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9121         throw_exception with throw.
9122         * eval.c (fetch_subexp_value, evaluate_var_value)
9123         (evaluate_funcall, evaluate_subexp_standard): Replace
9124         throw_exception with throw.
9125         * dwarf2loc.c (call_site_find_chain)
9126         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9127         Replace throw_exception with throw.
9128         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9129         with throw.
9130         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9131         throw.
9132         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9133         * completer.c (complete_line_internal): Replace throw_exception
9134         with throw.
9135         * compile/compile-object-run.c (compile_object_run): Replace
9136         throw_exception with throw.
9137         * cli/cli-script.c (process_next_line): Replace throw_exception
9138         with throw.
9139         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9140         (btrace_enable, btrace_maint_update_pt_packets): Replace
9141         throw_exception with throw.
9142         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9143         throw_exception with throw.
9144         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9145         throw_exception with throw.
9146         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9147         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9148         * aarch64-tdep.c (aarch64_make_prologue_cache)
9149         (aarch64_make_stub_cache): Replace throw_exception with throw.
9150
9151 2019-04-08  Tom Tromey  <tom@tromey.com>
9152
9153         * common/common-exceptions.c (throw_exception): Rename from
9154         throw_exception_cxx.  Remove old copy.  Make argument const.
9155         (throw_it): Create and throw exception objects directly.
9156         * common/common-exceptions.h (throw_exception): Make argument
9157         const.
9158         (struct gdb_exception_error): Add constructor.
9159         (struct gdb_exception_quit): Add constructor.
9160
9161 2019-04-08  Tom Tromey  <tom@tromey.com>
9162
9163         * common/common-exceptions.h (exception_rethrow): Don't declare.
9164         (TRY_SJLJ): Update comment.
9165         (TRY, CATCH, END_CATCH): Remove.
9166         * common/common-exceptions.c (exception_rethrow): Remove.
9167
9168 2019-04-08  Tom Tromey  <tom@tromey.com>
9169
9170         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9171         Remove.
9172         (gdb_exception_error): Rename from
9173         gdb_exception_RETURN_MASK_ERROR.
9174         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9175         (gdb_quit_bad_alloc): Update.
9176         * aarch64-tdep.c: Update.
9177         * ada-lang.c: Update.
9178         * ada-typeprint.c: Update.
9179         * ada-valprint.c: Update.
9180         * amd64-tdep.c: Update.
9181         * arch-utils.c: Update.
9182         * break-catch-throw.c: Update.
9183         * breakpoint.c: Update.
9184         * btrace.c: Update.
9185         * c-varobj.c: Update.
9186         * cli/cli-cmds.c: Update.
9187         * cli/cli-interp.c: Update.
9188         * cli/cli-script.c: Update.
9189         * common/common-exceptions.c: Update.
9190         * common/new-op.c: Update.
9191         * common/selftest.c: Update.
9192         * compile/compile-c-symbols.c: Update.
9193         * compile/compile-cplus-symbols.c: Update.
9194         * compile/compile-object-load.c: Update.
9195         * compile/compile-object-run.c: Update.
9196         * completer.c: Update.
9197         * corelow.c: Update.
9198         * cp-abi.c: Update.
9199         * cp-support.c: Update.
9200         * cp-valprint.c: Update.
9201         * darwin-nat.c: Update.
9202         * disasm-selftests.c: Update.
9203         * dtrace-probe.c: Update.
9204         * dwarf-index-cache.c: Update.
9205         * dwarf-index-write.c: Update.
9206         * dwarf2-frame-tailcall.c: Update.
9207         * dwarf2-frame.c: Update.
9208         * dwarf2loc.c: Update.
9209         * dwarf2read.c: Update.
9210         * eval.c: Update.
9211         * event-loop.c: Update.
9212         * event-top.c: Update.
9213         * exec.c: Update.
9214         * f-valprint.c: Update.
9215         * fbsd-tdep.c: Update.
9216         * frame-unwind.c: Update.
9217         * frame.c: Update.
9218         * gdbtypes.c: Update.
9219         * gnu-v3-abi.c: Update.
9220         * guile/guile-internal.h: Update.
9221         * guile/scm-block.c: Update.
9222         * guile/scm-breakpoint.c: Update.
9223         * guile/scm-cmd.c: Update.
9224         * guile/scm-disasm.c: Update.
9225         * guile/scm-frame.c: Update.
9226         * guile/scm-lazy-string.c: Update.
9227         * guile/scm-math.c: Update.
9228         * guile/scm-param.c: Update.
9229         * guile/scm-ports.c: Update.
9230         * guile/scm-pretty-print.c: Update.
9231         * guile/scm-symbol.c: Update.
9232         * guile/scm-symtab.c: Update.
9233         * guile/scm-type.c: Update.
9234         * guile/scm-value.c: Update.
9235         * i386-linux-tdep.c: Update.
9236         * i386-tdep.c: Update.
9237         * inf-loop.c: Update.
9238         * infcall.c: Update.
9239         * infcmd.c: Update.
9240         * infrun.c: Update.
9241         * jit.c: Update.
9242         * language.c: Update.
9243         * linespec.c: Update.
9244         * linux-fork.c: Update.
9245         * linux-nat.c: Update.
9246         * linux-tdep.c: Update.
9247         * linux-thread-db.c: Update.
9248         * main.c: Update.
9249         * mi/mi-cmd-break.c: Update.
9250         * mi/mi-cmd-stack.c: Update.
9251         * mi/mi-interp.c: Update.
9252         * mi/mi-main.c: Update.
9253         * objc-lang.c: Update.
9254         * p-valprint.c: Update.
9255         * parse.c: Update.
9256         * ppc-linux-tdep.c: Update.
9257         * printcmd.c: Update.
9258         * python/py-arch.c: Update.
9259         * python/py-breakpoint.c: Update.
9260         * python/py-cmd.c: Update.
9261         * python/py-finishbreakpoint.c: Update.
9262         * python/py-frame.c: Update.
9263         * python/py-framefilter.c: Update.
9264         * python/py-gdb-readline.c: Update.
9265         * python/py-inferior.c: Update.
9266         * python/py-infthread.c: Update.
9267         * python/py-lazy-string.c: Update.
9268         * python/py-linetable.c: Update.
9269         * python/py-objfile.c: Update.
9270         * python/py-param.c: Update.
9271         * python/py-prettyprint.c: Update.
9272         * python/py-progspace.c: Update.
9273         * python/py-record-btrace.c: Update.
9274         * python/py-record.c: Update.
9275         * python/py-symbol.c: Update.
9276         * python/py-type.c: Update.
9277         * python/py-unwind.c: Update.
9278         * python/py-utils.c: Update.
9279         * python/py-value.c: Update.
9280         * python/python.c: Update.
9281         * record-btrace.c: Update.
9282         * record-full.c: Update.
9283         * remote-fileio.c: Update.
9284         * remote.c: Update.
9285         * riscv-tdep.c: Update.
9286         * rs6000-aix-tdep.c: Update.
9287         * rs6000-tdep.c: Update.
9288         * rust-exp.y: Update.
9289         * rust-lang.c: Update.
9290         * s390-tdep.c: Update.
9291         * selftest-arch.c: Update.
9292         * solib-dsbt.c: Update.
9293         * solib-frv.c: Update.
9294         * solib-spu.c: Update.
9295         * solib-svr4.c: Update.
9296         * solib.c: Update.
9297         * sparc64-linux-tdep.c: Update.
9298         * stack.c: Update.
9299         * symfile-mem.c: Update.
9300         * symmisc.c: Update.
9301         * target.c: Update.
9302         * thread.c: Update.
9303         * top.c: Update.
9304         * tracefile-tfile.c: Update.
9305         * tui/tui.c: Update.
9306         * typeprint.c: Update.
9307         * unittests/cli-utils-selftests.c: Update.
9308         * unittests/parse-connection-spec-selftests.c: Update.
9309         * valops.c: Update.
9310         * valprint.c: Update.
9311         * value.c: Update.
9312         * varobj.c: Update.
9313         * windows-nat.c: Update.
9314         * x86-linux-nat.c: Update.
9315         * xml-support.c: Update.
9316
9317 2019-04-08  Tom Tromey  <tom@tromey.com>
9318
9319         * xml-support.c: Use C++ exception handling.
9320         * x86-linux-nat.c: Use C++ exception handling.
9321         * windows-nat.c: Use C++ exception handling.
9322         * varobj.c: Use C++ exception handling.
9323         * value.c: Use C++ exception handling.
9324         * valprint.c: Use C++ exception handling.
9325         * valops.c: Use C++ exception handling.
9326         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9327         handling.
9328         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9329         * typeprint.c: Use C++ exception handling.
9330         * tui/tui.c: Use C++ exception handling.
9331         * tracefile-tfile.c: Use C++ exception handling.
9332         * top.c: Use C++ exception handling.
9333         * thread.c: Use C++ exception handling.
9334         * target.c: Use C++ exception handling.
9335         * symmisc.c: Use C++ exception handling.
9336         * symfile-mem.c: Use C++ exception handling.
9337         * stack.c: Use C++ exception handling.
9338         * sparc64-linux-tdep.c: Use C++ exception handling.
9339         * solib.c: Use C++ exception handling.
9340         * solib-svr4.c: Use C++ exception handling.
9341         * solib-spu.c: Use C++ exception handling.
9342         * solib-frv.c: Use C++ exception handling.
9343         * solib-dsbt.c: Use C++ exception handling.
9344         * selftest-arch.c: Use C++ exception handling.
9345         * s390-tdep.c: Use C++ exception handling.
9346         * rust-lang.c: Use C++ exception handling.
9347         * rust-exp.y: Use C++ exception handling.
9348         * rs6000-tdep.c: Use C++ exception handling.
9349         * rs6000-aix-tdep.c: Use C++ exception handling.
9350         * riscv-tdep.c: Use C++ exception handling.
9351         * remote.c: Use C++ exception handling.
9352         * remote-fileio.c: Use C++ exception handling.
9353         * record-full.c: Use C++ exception handling.
9354         * record-btrace.c: Use C++ exception handling.
9355         * python/python.c: Use C++ exception handling.
9356         * python/py-value.c: Use C++ exception handling.
9357         * python/py-utils.c: Use C++ exception handling.
9358         * python/py-unwind.c: Use C++ exception handling.
9359         * python/py-type.c: Use C++ exception handling.
9360         * python/py-symbol.c: Use C++ exception handling.
9361         * python/py-record.c: Use C++ exception handling.
9362         * python/py-record-btrace.c: Use C++ exception handling.
9363         * python/py-progspace.c: Use C++ exception handling.
9364         * python/py-prettyprint.c: Use C++ exception handling.
9365         * python/py-param.c: Use C++ exception handling.
9366         * python/py-objfile.c: Use C++ exception handling.
9367         * python/py-linetable.c: Use C++ exception handling.
9368         * python/py-lazy-string.c: Use C++ exception handling.
9369         * python/py-infthread.c: Use C++ exception handling.
9370         * python/py-inferior.c: Use C++ exception handling.
9371         * python/py-gdb-readline.c: Use C++ exception handling.
9372         * python/py-framefilter.c: Use C++ exception handling.
9373         * python/py-frame.c: Use C++ exception handling.
9374         * python/py-finishbreakpoint.c: Use C++ exception handling.
9375         * python/py-cmd.c: Use C++ exception handling.
9376         * python/py-breakpoint.c: Use C++ exception handling.
9377         * python/py-arch.c: Use C++ exception handling.
9378         * printcmd.c: Use C++ exception handling.
9379         * ppc-linux-tdep.c: Use C++ exception handling.
9380         * parse.c: Use C++ exception handling.
9381         * p-valprint.c: Use C++ exception handling.
9382         * objc-lang.c: Use C++ exception handling.
9383         * mi/mi-main.c: Use C++ exception handling.
9384         * mi/mi-interp.c: Use C++ exception handling.
9385         * mi/mi-cmd-stack.c: Use C++ exception handling.
9386         * mi/mi-cmd-break.c: Use C++ exception handling.
9387         * main.c: Use C++ exception handling.
9388         * linux-thread-db.c: Use C++ exception handling.
9389         * linux-tdep.c: Use C++ exception handling.
9390         * linux-nat.c: Use C++ exception handling.
9391         * linux-fork.c: Use C++ exception handling.
9392         * linespec.c: Use C++ exception handling.
9393         * language.c: Use C++ exception handling.
9394         * jit.c: Use C++ exception handling.
9395         * infrun.c: Use C++ exception handling.
9396         * infcmd.c: Use C++ exception handling.
9397         * infcall.c: Use C++ exception handling.
9398         * inf-loop.c: Use C++ exception handling.
9399         * i386-tdep.c: Use C++ exception handling.
9400         * i386-linux-tdep.c: Use C++ exception handling.
9401         * guile/scm-value.c: Use C++ exception handling.
9402         * guile/scm-type.c: Use C++ exception handling.
9403         * guile/scm-symtab.c: Use C++ exception handling.
9404         * guile/scm-symbol.c: Use C++ exception handling.
9405         * guile/scm-pretty-print.c: Use C++ exception handling.
9406         * guile/scm-ports.c: Use C++ exception handling.
9407         * guile/scm-param.c: Use C++ exception handling.
9408         * guile/scm-math.c: Use C++ exception handling.
9409         * guile/scm-lazy-string.c: Use C++ exception handling.
9410         * guile/scm-frame.c: Use C++ exception handling.
9411         * guile/scm-disasm.c: Use C++ exception handling.
9412         * guile/scm-cmd.c: Use C++ exception handling.
9413         * guile/scm-breakpoint.c: Use C++ exception handling.
9414         * guile/scm-block.c: Use C++ exception handling.
9415         * guile/guile-internal.h: Use C++ exception handling.
9416         * gnu-v3-abi.c: Use C++ exception handling.
9417         * gdbtypes.c: Use C++ exception handling.
9418         * frame.c: Use C++ exception handling.
9419         * frame-unwind.c: Use C++ exception handling.
9420         * fbsd-tdep.c: Use C++ exception handling.
9421         * f-valprint.c: Use C++ exception handling.
9422         * exec.c: Use C++ exception handling.
9423         * event-top.c: Use C++ exception handling.
9424         * event-loop.c: Use C++ exception handling.
9425         * eval.c: Use C++ exception handling.
9426         * dwarf2read.c: Use C++ exception handling.
9427         * dwarf2loc.c: Use C++ exception handling.
9428         * dwarf2-frame.c: Use C++ exception handling.
9429         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9430         * dwarf-index-write.c: Use C++ exception handling.
9431         * dwarf-index-cache.c: Use C++ exception handling.
9432         * dtrace-probe.c: Use C++ exception handling.
9433         * disasm-selftests.c: Use C++ exception handling.
9434         * darwin-nat.c: Use C++ exception handling.
9435         * cp-valprint.c: Use C++ exception handling.
9436         * cp-support.c: Use C++ exception handling.
9437         * cp-abi.c: Use C++ exception handling.
9438         * corelow.c: Use C++ exception handling.
9439         * completer.c: Use C++ exception handling.
9440         * compile/compile-object-run.c: Use C++ exception handling.
9441         * compile/compile-object-load.c: Use C++ exception handling.
9442         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9443         * compile/compile-c-symbols.c: Use C++ exception handling.
9444         * common/selftest.c: Use C++ exception handling.
9445         * common/new-op.c: Use C++ exception handling.
9446         * cli/cli-script.c: Use C++ exception handling.
9447         * cli/cli-interp.c: Use C++ exception handling.
9448         * cli/cli-cmds.c: Use C++ exception handling.
9449         * c-varobj.c: Use C++ exception handling.
9450         * btrace.c: Use C++ exception handling.
9451         * breakpoint.c: Use C++ exception handling.
9452         * break-catch-throw.c: Use C++ exception handling.
9453         * arch-utils.c: Use C++ exception handling.
9454         * amd64-tdep.c: Use C++ exception handling.
9455         * ada-valprint.c: Use C++ exception handling.
9456         * ada-typeprint.c: Use C++ exception handling.
9457         * ada-lang.c: Use C++ exception handling.
9458         * aarch64-tdep.c: Use C++ exception handling.
9459
9460 2019-04-08  Tom Tromey  <tom@tromey.com>
9461
9462         * xml-support.c (gdb_xml_parser::parse): Update.
9463         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9464         * value.c (show_convenience): Update.
9465         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9466         (test_parse_flags_qcs): Update.
9467         * thread.c (thr_try_catch_cmd): Update.
9468         * target.c (target_translate_tls_address): Update.
9469         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9470         (info_frame_command_core, frame_apply_command_count): Update.
9471         * rust-exp.y (rust_lex_exception_test): Update.
9472         * riscv-tdep.c (riscv_print_one_register_info): Update.
9473         * remote.c (remote_target::enable_btrace): Update.
9474         * record-btrace.c (record_btrace_enable_warn): Update.
9475         * python/py-utils.c (gdbpy_convert_exception): Update.
9476         * printcmd.c (do_one_display, print_variable_and_value): Update.
9477         * mi/mi-main.c (mi_print_exception): Update.
9478         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9479         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9480         * linux-nat.c (linux_nat_target::attach): Update.
9481         * linux-fork.c (class scoped_switch_fork_info): Update.
9482         * infrun.c (displaced_step_prepare): Update.
9483         * infcall.c (call_function_by_hand_dummy): Update.
9484         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9485         * gnu-v3-abi.c (print_one_vtable): Update.
9486         * frame.c (get_prev_frame_always): Update.
9487         * f-valprint.c (info_common_command_for_block): Update.
9488         * exec.c (try_open_exec_file): Update.
9489         * exceptions.c (print_exception, exception_print)
9490         (exception_fprintf, exception_print_same): Update.
9491         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9492         * dwarf-index-cache.c (index_cache::store)
9493         (index_cache::lookup_gdb_index): Update.
9494         * darwin-nat.c (maybe_cache_shell): Update.
9495         * cp-valprint.c (cp_print_value_fields): Update.
9496         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9497         (gcc_cplus_symbol_address): Update.
9498         * compile/compile-c-symbols.c (gcc_convert_symbol)
9499         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9500         * common/selftest.c: Update.
9501         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9502         a std::string.
9503         (exception_try_scope_entry, exception_try_scope_exit): Don't
9504         declare.
9505         (struct exception_try_scope): Remove.
9506         (TRY): Don't use exception_try_scope.
9507         (struct gdb_exception): Add constructor, operator=.
9508         <what>: New method.
9509         (struct gdb_exception_RETURN_MASK_ALL)
9510         (struct gdb_exception_RETURN_MASK_ERROR)
9511         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9512         (struct gdb_quit_bad_alloc): Update.
9513         * common/common-exceptions.c (exception_none): Change
9514         initializer.
9515         (struct catcher) <state, exception>: Initialize inline.
9516         <prev>: Remove member.
9517         (current_catcher): Remove.
9518         (catchers): New global.
9519         (exceptions_state_mc_init): Simplify.
9520         (catcher_pop): Remove.
9521         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9522         (try_scope_depth, exception_try_scope_entry)
9523         (exception_try_scope_exit): Remove.
9524         (throw_exception_sjlj): Update.
9525         (exception_messages, exception_messages_size): Remove.
9526         (throw_it): Simplify.
9527         (gdb_exception_sliced_copy): Remove.
9528         (throw_exception_cxx): Update.
9529         * cli/cli-script.c (script_from_file): Update.
9530         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9531         Update.
9532         * ada-valprint.c (ada_val_print): Update.
9533         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9534         (create_excep_cond_exprs): Update.
9535
9536 2019-04-08  Tom Tromey  <tom@tromey.com>
9537
9538         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9539         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9540         (TRY, CATCH, END_CATCH): Remove some definitions.
9541         * common/common-exceptions.c: Don't use GDB_XCPT.
9542         (catcher_list_size): Remove.
9543         (throw_exception, throw_it): Simplify.
9544
9545 2019-04-05  Tom Tromey  <tom@tromey.com>
9546
9547         Revert the header-sorting patch.
9548         * ft32-tdep.c: Revert.
9549         * frv-tdep.c: Revert.
9550         * frv-linux-tdep.c: Revert.
9551         * frame.c: Revert.
9552         * frame-unwind.c: Revert.
9553         * frame-base.c: Revert.
9554         * fork-child.c: Revert.
9555         * findvar.c: Revert.
9556         * findcmd.c: Revert.
9557         * filesystem.c: Revert.
9558         * filename-seen-cache.h: Revert.
9559         * filename-seen-cache.c: Revert.
9560         * fbsd-tdep.c: Revert.
9561         * fbsd-nat.h: Revert.
9562         * fbsd-nat.c: Revert.
9563         * f-valprint.c: Revert.
9564         * f-typeprint.c: Revert.
9565         * f-lang.c: Revert.
9566         * extension.h: Revert.
9567         * extension.c: Revert.
9568         * extension-priv.h: Revert.
9569         * expprint.c: Revert.
9570         * exec.h: Revert.
9571         * exec.c: Revert.
9572         * exceptions.c: Revert.
9573         * event-top.c: Revert.
9574         * event-loop.c: Revert.
9575         * eval.c: Revert.
9576         * elfread.c: Revert.
9577         * dwarf2read.h: Revert.
9578         * dwarf2read.c: Revert.
9579         * dwarf2loc.c: Revert.
9580         * dwarf2expr.h: Revert.
9581         * dwarf2expr.c: Revert.
9582         * dwarf2-frame.c: Revert.
9583         * dwarf2-frame-tailcall.c: Revert.
9584         * dwarf-index-write.h: Revert.
9585         * dwarf-index-write.c: Revert.
9586         * dwarf-index-common.c: Revert.
9587         * dwarf-index-cache.h: Revert.
9588         * dwarf-index-cache.c: Revert.
9589         * dummy-frame.c: Revert.
9590         * dtrace-probe.c: Revert.
9591         * disasm.h: Revert.
9592         * disasm.c: Revert.
9593         * disasm-selftests.c: Revert.
9594         * dictionary.c: Revert.
9595         * dicos-tdep.c: Revert.
9596         * demangle.c: Revert.
9597         * dcache.h: Revert.
9598         * dcache.c: Revert.
9599         * darwin-nat.h: Revert.
9600         * darwin-nat.c: Revert.
9601         * darwin-nat-info.c: Revert.
9602         * d-valprint.c: Revert.
9603         * d-namespace.c: Revert.
9604         * d-lang.c: Revert.
9605         * ctf.c: Revert.
9606         * csky-tdep.c: Revert.
9607         * csky-linux-tdep.c: Revert.
9608         * cris-tdep.c: Revert.
9609         * cris-linux-tdep.c: Revert.
9610         * cp-valprint.c: Revert.
9611         * cp-support.c: Revert.
9612         * cp-namespace.c: Revert.
9613         * cp-abi.c: Revert.
9614         * corelow.c: Revert.
9615         * corefile.c: Revert.
9616         * continuations.c: Revert.
9617         * completer.h: Revert.
9618         * completer.c: Revert.
9619         * complaints.c: Revert.
9620         * coffread.c: Revert.
9621         * coff-pe-read.c: Revert.
9622         * cli-out.h: Revert.
9623         * cli-out.c: Revert.
9624         * charset.c: Revert.
9625         * c-varobj.c: Revert.
9626         * c-valprint.c: Revert.
9627         * c-typeprint.c: Revert.
9628         * c-lang.c: Revert.
9629         * buildsym.c: Revert.
9630         * buildsym-legacy.c: Revert.
9631         * build-id.h: Revert.
9632         * build-id.c: Revert.
9633         * btrace.c: Revert.
9634         * bsd-uthread.c: Revert.
9635         * breakpoint.h: Revert.
9636         * breakpoint.c: Revert.
9637         * break-catch-throw.c: Revert.
9638         * break-catch-syscall.c: Revert.
9639         * break-catch-sig.c: Revert.
9640         * blockframe.c: Revert.
9641         * block.c: Revert.
9642         * bfin-tdep.c: Revert.
9643         * bfin-linux-tdep.c: Revert.
9644         * bfd-target.c: Revert.
9645         * bcache.c: Revert.
9646         * ax-general.c: Revert.
9647         * ax-gdb.h: Revert.
9648         * ax-gdb.c: Revert.
9649         * avr-tdep.c: Revert.
9650         * auxv.c: Revert.
9651         * auto-load.c: Revert.
9652         * arm-wince-tdep.c: Revert.
9653         * arm-tdep.c: Revert.
9654         * arm-symbian-tdep.c: Revert.
9655         * arm-pikeos-tdep.c: Revert.
9656         * arm-obsd-tdep.c: Revert.
9657         * arm-nbsd-tdep.c: Revert.
9658         * arm-nbsd-nat.c: Revert.
9659         * arm-linux-tdep.c: Revert.
9660         * arm-linux-nat.c: Revert.
9661         * arm-fbsd-tdep.c: Revert.
9662         * arm-fbsd-nat.c: Revert.
9663         * arm-bsd-tdep.c: Revert.
9664         * arch-utils.c: Revert.
9665         * arc-tdep.c: Revert.
9666         * arc-newlib-tdep.c: Revert.
9667         * annotate.h: Revert.
9668         * annotate.c: Revert.
9669         * amd64-windows-tdep.c: Revert.
9670         * amd64-windows-nat.c: Revert.
9671         * amd64-tdep.c: Revert.
9672         * amd64-sol2-tdep.c: Revert.
9673         * amd64-obsd-tdep.c: Revert.
9674         * amd64-obsd-nat.c: Revert.
9675         * amd64-nbsd-tdep.c: Revert.
9676         * amd64-nbsd-nat.c: Revert.
9677         * amd64-nat.c: Revert.
9678         * amd64-linux-tdep.c: Revert.
9679         * amd64-linux-nat.c: Revert.
9680         * amd64-fbsd-tdep.c: Revert.
9681         * amd64-fbsd-nat.c: Revert.
9682         * amd64-dicos-tdep.c: Revert.
9683         * amd64-darwin-tdep.c: Revert.
9684         * amd64-bsd-nat.c: Revert.
9685         * alpha-tdep.c: Revert.
9686         * alpha-obsd-tdep.c: Revert.
9687         * alpha-nbsd-tdep.c: Revert.
9688         * alpha-mdebug-tdep.c: Revert.
9689         * alpha-linux-tdep.c: Revert.
9690         * alpha-linux-nat.c: Revert.
9691         * alpha-bsd-tdep.c: Revert.
9692         * alpha-bsd-nat.c: Revert.
9693         * aix-thread.c: Revert.
9694         * agent.c: Revert.
9695         * addrmap.c: Revert.
9696         * ada-varobj.c: Revert.
9697         * ada-valprint.c: Revert.
9698         * ada-typeprint.c: Revert.
9699         * ada-tasks.c: Revert.
9700         * ada-lang.c: Revert.
9701         * aarch64-tdep.c: Revert.
9702         * aarch64-ravenscar-thread.c: Revert.
9703         * aarch64-newlib-tdep.c: Revert.
9704         * aarch64-linux-tdep.c: Revert.
9705         * aarch64-linux-nat.c: Revert.
9706         * aarch64-fbsd-tdep.c: Revert.
9707         * aarch64-fbsd-nat.c: Revert.
9708         * aarch32-linux-nat.c: Revert.
9709
9710 2019-04-05  Tom Tromey  <tom@tromey.com>
9711
9712         * ft32-tdep.c: Sort headers.
9713         * frv-tdep.c: Sort headers.
9714         * frv-linux-tdep.c: Sort headers.
9715         * frame.c: Sort headers.
9716         * frame-unwind.c: Sort headers.
9717         * frame-base.c: Sort headers.
9718         * fork-child.c: Sort headers.
9719         * findvar.c: Sort headers.
9720         * findcmd.c: Sort headers.
9721         * filesystem.c: Sort headers.
9722         * filename-seen-cache.h: Sort headers.
9723         * filename-seen-cache.c: Sort headers.
9724         * fbsd-tdep.c: Sort headers.
9725         * fbsd-nat.h: Sort headers.
9726         * fbsd-nat.c: Sort headers.
9727         * f-valprint.c: Sort headers.
9728         * f-typeprint.c: Sort headers.
9729         * f-lang.c: Sort headers.
9730         * extension.h: Sort headers.
9731         * extension.c: Sort headers.
9732         * extension-priv.h: Sort headers.
9733         * expprint.c: Sort headers.
9734         * exec.h: Sort headers.
9735         * exec.c: Sort headers.
9736         * exceptions.c: Sort headers.
9737         * event-top.c: Sort headers.
9738         * event-loop.c: Sort headers.
9739         * eval.c: Sort headers.
9740         * elfread.c: Sort headers.
9741         * dwarf2read.h: Sort headers.
9742         * dwarf2read.c: Sort headers.
9743         * dwarf2loc.c: Sort headers.
9744         * dwarf2expr.h: Sort headers.
9745         * dwarf2expr.c: Sort headers.
9746         * dwarf2-frame.c: Sort headers.
9747         * dwarf2-frame-tailcall.c: Sort headers.
9748         * dwarf-index-write.h: Sort headers.
9749         * dwarf-index-write.c: Sort headers.
9750         * dwarf-index-common.c: Sort headers.
9751         * dwarf-index-cache.h: Sort headers.
9752         * dwarf-index-cache.c: Sort headers.
9753         * dummy-frame.c: Sort headers.
9754         * dtrace-probe.c: Sort headers.
9755         * disasm.h: Sort headers.
9756         * disasm.c: Sort headers.
9757         * disasm-selftests.c: Sort headers.
9758         * dictionary.c: Sort headers.
9759         * dicos-tdep.c: Sort headers.
9760         * demangle.c: Sort headers.
9761         * dcache.h: Sort headers.
9762         * dcache.c: Sort headers.
9763         * darwin-nat.h: Sort headers.
9764         * darwin-nat.c: Sort headers.
9765         * darwin-nat-info.c: Sort headers.
9766         * d-valprint.c: Sort headers.
9767         * d-namespace.c: Sort headers.
9768         * d-lang.c: Sort headers.
9769         * ctf.c: Sort headers.
9770         * csky-tdep.c: Sort headers.
9771         * csky-linux-tdep.c: Sort headers.
9772         * cris-tdep.c: Sort headers.
9773         * cris-linux-tdep.c: Sort headers.
9774         * cp-valprint.c: Sort headers.
9775         * cp-support.c: Sort headers.
9776         * cp-namespace.c: Sort headers.
9777         * cp-abi.c: Sort headers.
9778         * corelow.c: Sort headers.
9779         * corefile.c: Sort headers.
9780         * continuations.c: Sort headers.
9781         * completer.h: Sort headers.
9782         * completer.c: Sort headers.
9783         * complaints.c: Sort headers.
9784         * coffread.c: Sort headers.
9785         * coff-pe-read.c: Sort headers.
9786         * cli-out.h: Sort headers.
9787         * cli-out.c: Sort headers.
9788         * charset.c: Sort headers.
9789         * c-varobj.c: Sort headers.
9790         * c-valprint.c: Sort headers.
9791         * c-typeprint.c: Sort headers.
9792         * c-lang.c: Sort headers.
9793         * buildsym.c: Sort headers.
9794         * buildsym-legacy.c: Sort headers.
9795         * build-id.h: Sort headers.
9796         * build-id.c: Sort headers.
9797         * btrace.c: Sort headers.
9798         * bsd-uthread.c: Sort headers.
9799         * breakpoint.h: Sort headers.
9800         * breakpoint.c: Sort headers.
9801         * break-catch-throw.c: Sort headers.
9802         * break-catch-syscall.c: Sort headers.
9803         * break-catch-sig.c: Sort headers.
9804         * blockframe.c: Sort headers.
9805         * block.c: Sort headers.
9806         * bfin-tdep.c: Sort headers.
9807         * bfin-linux-tdep.c: Sort headers.
9808         * bfd-target.c: Sort headers.
9809         * bcache.c: Sort headers.
9810         * ax-general.c: Sort headers.
9811         * ax-gdb.h: Sort headers.
9812         * ax-gdb.c: Sort headers.
9813         * avr-tdep.c: Sort headers.
9814         * auxv.c: Sort headers.
9815         * auto-load.c: Sort headers.
9816         * arm-wince-tdep.c: Sort headers.
9817         * arm-tdep.c: Sort headers.
9818         * arm-symbian-tdep.c: Sort headers.
9819         * arm-pikeos-tdep.c: Sort headers.
9820         * arm-obsd-tdep.c: Sort headers.
9821         * arm-nbsd-tdep.c: Sort headers.
9822         * arm-nbsd-nat.c: Sort headers.
9823         * arm-linux-tdep.c: Sort headers.
9824         * arm-linux-nat.c: Sort headers.
9825         * arm-fbsd-tdep.c: Sort headers.
9826         * arm-fbsd-nat.c: Sort headers.
9827         * arm-bsd-tdep.c: Sort headers.
9828         * arch-utils.c: Sort headers.
9829         * arc-tdep.c: Sort headers.
9830         * arc-newlib-tdep.c: Sort headers.
9831         * annotate.h: Sort headers.
9832         * annotate.c: Sort headers.
9833         * amd64-windows-tdep.c: Sort headers.
9834         * amd64-windows-nat.c: Sort headers.
9835         * amd64-tdep.c: Sort headers.
9836         * amd64-sol2-tdep.c: Sort headers.
9837         * amd64-obsd-tdep.c: Sort headers.
9838         * amd64-obsd-nat.c: Sort headers.
9839         * amd64-nbsd-tdep.c: Sort headers.
9840         * amd64-nbsd-nat.c: Sort headers.
9841         * amd64-nat.c: Sort headers.
9842         * amd64-linux-tdep.c: Sort headers.
9843         * amd64-linux-nat.c: Sort headers.
9844         * amd64-fbsd-tdep.c: Sort headers.
9845         * amd64-fbsd-nat.c: Sort headers.
9846         * amd64-dicos-tdep.c: Sort headers.
9847         * amd64-darwin-tdep.c: Sort headers.
9848         * amd64-bsd-nat.c: Sort headers.
9849         * alpha-tdep.c: Sort headers.
9850         * alpha-obsd-tdep.c: Sort headers.
9851         * alpha-nbsd-tdep.c: Sort headers.
9852         * alpha-mdebug-tdep.c: Sort headers.
9853         * alpha-linux-tdep.c: Sort headers.
9854         * alpha-linux-nat.c: Sort headers.
9855         * alpha-bsd-tdep.c: Sort headers.
9856         * alpha-bsd-nat.c: Sort headers.
9857         * aix-thread.c: Sort headers.
9858         * agent.c: Sort headers.
9859         * addrmap.c: Sort headers.
9860         * ada-varobj.c: Sort headers.
9861         * ada-valprint.c: Sort headers.
9862         * ada-typeprint.c: Sort headers.
9863         * ada-tasks.c: Sort headers.
9864         * ada-lang.c: Sort headers.
9865         * aarch64-tdep.c: Sort headers.
9866         * aarch64-ravenscar-thread.c: Sort headers.
9867         * aarch64-newlib-tdep.c: Sort headers.
9868         * aarch64-linux-tdep.c: Sort headers.
9869         * aarch64-linux-nat.c: Sort headers.
9870         * aarch64-fbsd-tdep.c: Sort headers.
9871         * aarch64-fbsd-nat.c: Sort headers.
9872         * aarch32-linux-nat.c: Sort headers.
9873
9874 2019-04-04  Tom Tromey  <tom@tromey.com>
9875
9876         * varobj.c (varobj_create): Update.
9877         * rust-exp.y (struct rust_parser) <update_innermost_block,
9878         lookup_symbol>: New methods.
9879         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9880         Rename.
9881         (rust_parser::rust_lookup_type)
9882         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9883         * printcmd.c (display_command, do_one_display): Update.
9884         * parser-defs.h (struct parser_state) <parser_state>: Add
9885         "tracker" parameter.
9886         (block_tracker): New member.
9887         (class innermost_block_tracker) <innermost_block_tracker>: Add
9888         "types" parameter.
9889         <reset>: Remove method.
9890         (innermost_block): Don't declare.
9891         (null_post_parser): Update.
9892         * parse.c (innermost_block): Remove global.
9893         (write_dollar_variable): Update.
9894         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9895         Remove "tracker_types" parameter.
9896         (parse_expression): Add "tracker" parameter.
9897         (parse_expression_for_completion): Update.
9898         (null_post_parser): Add "tracker" parameter.
9899         * p-exp.y: Update rules.
9900         * m2-exp.y: Update rules.
9901         * language.h (struct language_defn) <la_post_parser>: Add
9902         "tracker" parameter.
9903         * go-exp.y: Update rules.
9904         * f-exp.y: Update rules.
9905         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9906         parameter.
9907         * d-exp.y: Update rules.
9908         * c-exp.y: Update rules.
9909         * breakpoint.c (set_breakpoint_condition): Create an
9910         innermost_block_tracker.
9911         (watch_command_1): Likewise.
9912         * ada-lang.c (resolve): Add "tracker" parameter.
9913         (resolve_subexp): Likewise.
9914         * ada-exp.y (write_var_from_sym): Update.
9915
9916 2019-04-04  Tom Tromey  <tom@tromey.com>
9917
9918         * type-stack.h: New file.
9919         * type-stack.c: New file.
9920         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9921         type-stack.h.
9922         (insert_into_type_stack, insert_type, push_type, push_type_int)
9923         (insert_type_address_space, pop_type, pop_type_int)
9924         (pop_typelist, pop_type_stack, append_type_stack)
9925         (push_type_stack, get_type_stack, push_typelist)
9926         (follow_type_instance_flags, follow_types): Don't declare.
9927         * parse.c (type_stack): Remove global.
9928         (parse_exp_in_context): Update.
9929         (insert_into_type_stack, insert_type, push_type, push_type_int)
9930         (insert_type_address_space, pop_type, pop_type_int)
9931         (pop_typelist, pop_type_stack, append_type_stack)
9932         (push_type_stack, get_type_stack, push_typelist)
9933         (follow_type_instance_flags, follow_types): Remove (moved to
9934         type-stack.c).
9935         * f-exp.y (type_stack): New global.
9936         Update rules.
9937         (push_kind_type, f_parse): Update.
9938         * d-exp.y (type_stack): New global.
9939         Update rules.
9940         (d_parse): Update.
9941         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9942         Update rules.
9943         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9944         (HFILES_NO_SRCDIR): Add type-stack.h.
9945
9946 2019-04-04  Tom Tromey  <tom@tromey.com>
9947
9948         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9949         (rust_parser::convert_ast_to_expression, rust_parse)
9950         (rust_lex_test_completion, rust_lex_tests): Update.
9951         * parser-defs.h (struct expr_completion_state): New.
9952         (struct parser_state) <parser_state>: Add completion parameter.
9953         <mark_struct_expression, mark_completion_tag>: New methods.
9954         <parse_completion, m_completion_state>: New members.
9955         (prefixify_expression, null_post_parser): Update.
9956         (mark_struct_expression, mark_completion_tag): Don't declare.
9957         * parse.c (parse_completion, expout_last_struct)
9958         (expout_tag_completion_type, expout_completion_name): Remove
9959         globals.
9960         (parser_state::mark_struct_expression)
9961         (parser_state::mark_completion_tag): Now methods.
9962         (prefixify_expression): Add last_struct parameter.
9963         (prefixify_subexp): Likewise.
9964         (parse_exp_1): Update.
9965         (parse_exp_in_context): Add cstate parameter.  Update.
9966         (parse_expression_for_completion): Create an
9967         expr_completion_state.
9968         (null_post_parser): Add "completion" parameter.
9969         * p-exp.y: Update rules.
9970         (yylex): Update.
9971         * language.h (struct language_defn) <la_post_parser>: Add
9972         "completing" parameter.
9973         * go-exp.y: Update rules.
9974         (lex_one_token): Update.
9975         * expression.h (parse_completion): Don't declare.
9976         * d-exp.y: Update rules.
9977         (lex_one_token): Update rules.
9978         * c-exp.y: Update rules.
9979         (lex_one_token): Update.
9980         * ada-lang.c (resolve): Add "parse_completion" parameter.
9981         (resolve_subexp): Likewise.
9982         (ada_resolve_function): Likewise.
9983
9984 2019-04-04  Tom Tromey  <tom@tromey.com>
9985
9986         * parser-defs.h (struct parser_state) <start_arglist,
9987         end_arglist>: New methods.
9988         <arglist_len, m_funcall_chain>: New members.
9989         (arglist_len, start_arglist, end_arglist): Don't declare.
9990         * parse.c (arglist_len, funcall_chain): Remove global.
9991         (start_arglist, end_arglist): Remove functions.
9992         (parse_exp_in_context): Update.
9993         * p-exp.y: Update rules.
9994         * m2-exp.y: Update rules.
9995         * go-exp.y: Update rules.
9996         * f-exp.y: Update rules.
9997         * d-exp.y: Update rules.
9998         * c-exp.y: Update rules.
9999
10000 2019-04-04  Tom Tromey  <tom@tromey.com>
10001
10002         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10003         lex_operator, push_back>: New methods.
10004         Update all rules.
10005         (rust_parser::lex_hex, lex_escape): Rename and update.
10006         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10007         (rust_parser::lex_operator): Rename and update.
10008         (rust_parser::lex_number, rustyylex, rustyyerror)
10009         (rust_lex_test_init, rust_lex_test_sequence)
10010         (rust_lex_test_push_back, rust_lex_tests): Update.
10011         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10012         parameter.
10013         <lexptr, prev_lexptr>: New members.
10014         (lexptr, prev_lexptr): Don't declare.
10015         * parse.c (lexptr, prev_lexptr): Remove globals.
10016         (parse_exp_in_context): Update.
10017         * p-exp.y (yylex, yyerror): Update.
10018         * m2-exp.y (parse_number, yylex, yyerror): Update.
10019         * go-exp.y (lex_one_token, yyerror): Update.
10020         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10021         * d-exp.y (lex_one_token, yyerror): Update.
10022         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10023         (lex_one_token, yyerror): Update.
10024         * ada-lex.l (YY_INPUT): Update.
10025         (rewind_to_char): Update.
10026         * ada-exp.y (yyerror): Update.
10027
10028 2019-04-04  Tom Tromey  <tom@tromey.com>
10029
10030         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10031         * parser-defs.h (struct parser_state) <parser_state>: Add new
10032         parameter.
10033         <comma_terminates>: New member.
10034         (comma_terminates): Don't declare global.
10035         * parse.c (comma_terminates): Remove global.
10036         (parse_exp_in_context): Update.
10037         * p-exp.y (yylex): Update.
10038         * m2-exp.y (yylex): Update.
10039         * go-exp.y (lex_one_token): Update.
10040         * f-exp.y (yylex): Update.
10041         * d-exp.y (lex_one_token): Update.
10042         * c-exp.y (lex_one_token): Update.
10043         * ada-lex.l: Update.
10044
10045 2019-04-04  Tom Tromey  <tom@tromey.com>
10046
10047         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10048         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10049         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10050         * parser-defs.h (paren_depth): Don't declare.
10051         * parse.c (paren_depth): Remove global.
10052         (parse_exp_in_context): Update.
10053         * p-exp.y (paren_depth): New global.
10054         (pascal_parse): Initialize it.
10055         * m2-exp.y (paren_depth): New global.
10056         (m2_parse): Initialize it.
10057         * go-exp.y (paren_depth): New global.
10058         (go_parse): Initialize it.
10059         * f-exp.y (paren_depth): New global.
10060         (f_parse): Initialize it.
10061         * d-exp.y (paren_depth): New global.
10062         (d_parse): Initialize it.
10063         * c-exp.y (paren_depth): New global.
10064         (c_parse): Initialize it.
10065         * ada-lex.l (paren_depth): New global.
10066         (lexer_init): Initialize it.
10067
10068 2019-04-04  Tom Tromey  <tom@tromey.com>
10069
10070         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10071         (rust_parser::convert_ast_to_type)
10072         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10073         * parser-defs.h (struct parser_state) <parser_state>: Add
10074         parameters.  Initialize new members.
10075         <expression_context_block, expression_context_pc>: New members.
10076         * parse.c (expression_context_block, expression_context_pc):
10077         Remove globals.
10078         (parse_exp_in_context): Update.
10079         * p-exp.y: Update all rules.
10080         (yylex): Update.
10081         * m2-exp.y: Update all rules.
10082         (yylex): Update.
10083         * go-exp.y (yylex): Update.
10084         * f-exp.y (yylex): Update.
10085         * d-exp.y: Update all rules.
10086         (yylex): Update.
10087         * c-exp.y: Update all rules.
10088         (lex_one_token, classify_name, yylex, c_parse): Update.
10089         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10090
10091 2019-04-04  Tom Tromey  <tom@tromey.com>
10092
10093         * gdbarch.h, gdbarch.c: Rebuild.
10094         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10095         * stap-probe.h:
10096         (struct stap_parse_info): Replace "parser_state" with
10097         "expr_builder".
10098         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10099         (parser_state): New class.
10100         * parse.c (expr_builder): Rename.
10101         (expr_builder::release): Rename.
10102         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10103         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10104         (write_exp_elt_longcst, write_exp_elt_floatcst)
10105         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10106         (write_exp_string_vector, write_exp_bitstring)
10107         (write_exp_msymbol, mark_struct_expression)
10108         (write_dollar_variable)
10109         (insert_type_address_space, increase_expout_size): Replace
10110         "parser_state" with "expr_builder".
10111         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10112         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10113         "parser_state" with "expr_builder".
10114
10115 2019-04-04  Tom Tromey  <tom@tromey.com>
10116
10117         * rust-exp.y: Replace "parse_language" with method call.
10118         * p-exp.y:
10119         (yylex): Replace "parse_language" with method call.
10120         * m2-exp.y:
10121         (yylex): Replace "parse_language" with method call.
10122         * go-exp.y (classify_name): Replace "parse_language" with method
10123         call.
10124         * f-exp.y (yylex): Replace "parse_language" with method call.
10125         * d-exp.y (lex_one_token): Replace "parse_language" with method
10126         call.
10127         * c-exp.y:
10128         (lex_one_token, classify_name, yylex): Replace "parse_language"
10129         with method call.
10130         * ada-exp.y (find_primitive_type, type_char)
10131         (type_system_address): Replace "parse_language" with method call.
10132
10133 2019-04-04  Tom Tromey  <tom@tromey.com>
10134
10135         * rust-exp.y: Replace "parse_gdbarch" with method call.
10136         * parse.c (write_dollar_variable, insert_type_address_space):
10137         Replace "parse_gdbarch" with method call.
10138         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10139         call.
10140         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10141         call.
10142         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10143         "parse_gdbarch" with method call.
10144         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10145         with method call.
10146         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10147         "parse_gdbarch" with method call.
10148         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10149         "parse_gdbarch" with method call.
10150         * c-exp.y (parse_type, parse_number, classify_name): Replace
10151         "parse_gdbarch" with method call.
10152         * ada-lex.l: Replace "parse_gdbarch" with method call.
10153         * ada-exp.y (parse_type, find_primitive_type, type_char)
10154         (type_system_address): Replace "parse_gdbarch" with method call.
10155
10156 2019-04-04  Tom Tromey  <tom@tromey.com>
10157
10158         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10159         * stap-probe.c (stap_parse_argument): Update.
10160         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10161         initial_size parameter.
10162         * rust-exp.y (rust_lex_tests): Update.
10163         * parse.c (parser_state): Update.
10164         (parse_exp_in_context): Update.
10165         * parser-defs.h (struct parser_state) <parser_state>: Remove
10166         "initial_size" parameter.
10167
10168 2019-04-04  Tom Tromey  <tom@tromey.com>
10169
10170         * parser-defs.h (increase_expout_size): Don't declare.
10171         * parse.c (increase_expout_size): Now static.
10172
10173 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10174
10175         * gnu-nat.c (gnu_nat_target::wait): Fix
10176         target_waitstatus_to_string call.
10177
10178 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10179
10180         * eval.c (evaluate_subexp_standard): Handle internal functions
10181         during Fortran function call handling.
10182
10183 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10184
10185         * NEWS: Mention new internal functions.
10186         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10187         (read_base_type): Use dwarf2_init_complex_target_type.
10188         * value.c (creal_internal_fn): New function.
10189         (cimag_internal_fn): New function.
10190         (_initialize_values): Register new internal functions.
10191
10192 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10193
10194         * infrun.c (stop_all_threads): If debug_infrun, always
10195         trace the wait status after wait_one, using
10196         target_waitstatus_to_string and target_pid_to_str.
10197         (handle_inferior_event): Replace various trace of
10198         wait status kind by a single trace.
10199         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10200         wait status kind image by target_waitstatus_to_string.
10201         * target/waitstatus.c (target_waitstatus_to_string): Fix
10202         obsolete comment.
10203
10204 2019-04-01  Tom Tromey  <tromey@adacore.com>
10205
10206         PR symtab/23331:
10207         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10208
10209 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10210             Pedro Alves  <palves@redhat.com>
10211
10212         * top.c (quit_force): Call 'finalize_values'.
10213         * value.c (finalize_values): New function.
10214         * value.h (finalize_values): Declare.
10215
10216 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10217
10218         * NEWS: Announce $_gdb_major and $_gdb_minor.
10219
10220         * top.c (init_gdb_version_vars): New function.
10221         (gdb_init): Call init_gdb_version_vars.
10222
10223 2019-03-29  Tom Tromey  <tromey@adacore.com>
10224
10225         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10226         help text.  Remove dead code.
10227
10228 2019-03-29  Keith Seitz  <keiths@redhat.com>
10229
10230         From Siddhesh Poyarekar:
10231         * f-lang.h (f77_get_upperbound): Return LONGEST.
10232         (f77_get_lowerbound): Likewise.
10233         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10234         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10235         print them.
10236         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10237         plongest to format print it.
10238         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10239         (f77_get_upperbound): Likewise.
10240         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10241         LOWER_BOUND to LONGEST.
10242         (f77_create_arrayprint_offset_tbl): Likewise.
10243
10244 2019-03-29  Keith Seitz  <keiths@redhat.com>
10245
10246         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10247         %s/pulongest for TYPE_LENGTH instead of %d in format
10248         strings.
10249         * ada-typerint.c (ada_print_type): Likewise.
10250         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10251         * compile/compile-c-support.c (generate_register_struct): Likewise.
10252         * gdbtypes.c (recursive_dump_type): Likewise.
10253         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10254         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10255         instead of %d in format strings.
10256         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10257         to std::min to ULONGEST.
10258         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10259         instead of %d in format strings.
10260         * tracepoint.c (info_scope_command): Likewise.
10261         * typeprint.c (print_offset_data::update)
10262         (print_offset_data::finish): Likewise.
10263         * xtensa-tdep.c (xtensa_store_return_value)
10264         (xtensa_push_dummy_call): Likewise.
10265
10266 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10267
10268         * windows-nat.c (display_selector): Fixed format specifications
10269         for 64-bit Cygwin.
10270
10271 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10272
10273         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10274
10275 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10276
10277         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10278         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10279         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10280         (nios2_linux_init_abi): Install it.
10281
10282 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10283
10284         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10285
10286 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10287
10288         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10289
10290 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10291             Tom Tromey  <tromey@adacore.com>
10292
10293         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10294
10295 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10296
10297         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10298         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10299         method to compute the bounds of range types. Also print "[evaluated]"
10300         if the bounds' values come from a dynamic evaluation.
10301
10302 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10303
10304         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10305         whitespace when pretty printing is on.
10306
10307 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10308
10309         * ppc-linux-nat.c: Add include.
10310
10311 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10312
10313         * NEWS: Mention AArch64 Pointer Authentication.
10314
10315 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10316
10317         * arm-linux-nat.c: Add include.
10318
10319 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10320
10321         * source-cache.c (source_cache::get_source_lines): Re-read
10322         fullname after calling open_source_file.
10323
10324 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10325
10326         * NEWS: Mention TLS support for FreeBSD.
10327
10328 2019-03-25  Tom Tromey  <tromey@adacore.com>
10329
10330         * minsyms.c (BUNCH_SIZE): Update comment.
10331         (~minimal_symbol_reader): Remove old comment.
10332         (compact_minimal_symbols): Update comment.
10333         (minimal_symbol_reader::install): Remove old comment.  Update
10334         other comments.
10335
10336 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10337
10338         * s390-linux-nat.c: Add include.
10339
10340 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10341
10342         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10343         Call linux_get_hwcap.
10344         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10345         Likewise.
10346         (aarch64_linux_get_hwcap): Remove function.
10347         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10348         declaration.
10349         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10350         linux_get_hwcap.
10351         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10352         * linux-tdep.c (linux_get_hwcap): Add function.
10353         (linux_get_hwcap2): Likewise.
10354         * linux-tdep.h (linux_get_hwcap): Add declaration.
10355         (linux_get_hwcap2): Likewise.
10356         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10357         (ppc_linux_get_hwcap2): Likewise.
10358         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10359         linux_get_hwcap.
10360         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10361         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10362         (ppc_linux_nat_target::read_description): Likewise.
10363         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10364         * s390-linux-nat.c: Likewise.
10365         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10366
10367 2019-03-24  Tom Tromey  <tom@tromey.com>
10368
10369         * ada-lang.c (standard_lookup): Simplify initialization.
10370         (ada_lookup_symbol_nonlocal): Simplify return.
10371         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10372         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10373         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10374         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10375         initialization.
10376         * solib.c (solib_global_lookup): Simplify.
10377         * symtab.c (null_block_symbol): Remove.
10378         (symbol_cache_lookup): Simplify returns.
10379         (lookup_language_this): Simplify returns.
10380         (lookup_symbol_aux): Simplify return.
10381         (lookup_local_symbol): Simplify returns.
10382         (lookup_global_symbol_from_objfile): Simplify return.
10383         (lookup_symbol_in_objfile_symtabs)
10384         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10385         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10386         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10387         * cp-namespace.c (cp_lookup_bare_symbol)
10388         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10389         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10390         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10391         (cp_lookup_symbol_via_imports): Simplify initialization.
10392         (find_symbol_in_baseclass): Likewise.
10393         * symtab.h (null_block_symbol): Remove.
10394         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10395         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10396         (d_lookup_symbol_module): Likewise.
10397         (find_symbol_in_baseclass): Simplify initialization.
10398
10399 2019-03-24  Tom Tromey  <tom@tromey.com>
10400
10401         * expression.h: Don't include symtab.h.
10402         (struct block): Forward declare.
10403
10404 2019-03-24  Tom Tromey  <tom@tromey.com>
10405
10406         * c-exp.y (typebase): Remove casts.
10407         * gdbtypes.c (lookup_unsigned_typename, )
10408         (lookup_signed_typename): Remove cast.
10409         * eval.c (parse_to_comma_and_eval): Remove cast.
10410         * parse.c (write_dollar_variable): Remove cast.
10411         * block.h (struct block) <superblock>: Now const.
10412         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10413         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10414         (map_block): Make "block" const.
10415         * symfile.h (struct quick_symbol_functions)
10416         <map_matching_symbols>: Constify block argument to "callback".
10417         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10418         const.
10419         (find_pc_sect_compunit_symtab): Make "b" const.
10420         (find_symbol_at_address): Likewise.
10421         (search_symbols): Likewise.
10422         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10423         (dw2_debug_names_lookup_symbol): Likewise.
10424         (dw2_map_matching_symbols): Update.
10425         * p-valprint.c (pascal_val_print): Remove "block".
10426         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10427         (aux_add_nonlocal_symbols): Make "block" const.
10428         (resolve_subexp): Remove cast.
10429         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10430         const.
10431         (iterate_over_file_blocks): Likewise.
10432         * f-exp.y (%union) <bval>: Remove.
10433         * coffread.c (patch_opaque_types): Make "b" const.
10434         * spu-tdep.c (spu_catch_start): Make "block" const.
10435         * c-valprint.c (print_unpacked_pointer): Remove "block".
10436         * symmisc.c (dump_symtab_1): Make "b" const.
10437         (block_depth): Make "block" const.
10438         * d-exp.y (%union) <bval>: Remove.
10439         * cp-support.h (cp_lookup_rtti_type): Update.
10440         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10441         * psymtab.c (psym_lookup_symbol): Make "block" const.
10442         (maintenance_check_psymtabs): Make "b" const.
10443         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10444         (enumerate_locals, enumerate_args): Update.
10445         * python/py-symtab.c (stpy_global_block): Make "block" const.
10446         (stpy_static_block): Likewise.
10447         * inline-frame.c (block_starting_point_at): Make "new_block"
10448         const.
10449         * block.c (find_block_in_blockvector): Make return type const.
10450         (blockvector_for_pc_sect): Make "b" const.
10451         (find_block_in_blockvector): Make "b" const.
10452
10453 2019-03-23  Tom Tromey  <tom@tromey.com>
10454
10455         * varobj.c (varobj_create): Update.
10456         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10457         * printcmd.c (display_command, do_one_display): Don't reset
10458         innermost_block.
10459         * parser-defs.h (enum innermost_block_tracker_type): Move to
10460         expression.h.
10461         (innermost_block): Update comment.
10462         * parse.c (parse_exp_1): Add tracker_types parameter.
10463         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10464         tracker_types parameter.  Reset innermost_block.
10465         (parse_exp_in_context): Remove.
10466         (parse_expression_for_completion): Update.
10467         * objfiles.c (~objfile): Don't reset expression_context_block or
10468         innermost_block.
10469         * expression.h (enum innermost_block_tracker_type): Move from
10470         parser-defs.h.
10471         (parse_exp_1): Add tracker_types parameter.
10472         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10473         reset innermost_block.
10474
10475 2019-03-23  Tom Tromey  <tom@tromey.com>
10476
10477         * objfiles.h: Include bcache.h.
10478
10479 2019-03-23  Tom Tromey  <tom@tromey.com>
10480
10481         * linespec.c (get_current_search_block): Use
10482         scoped_restore_current_language.
10483         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10484
10485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10486             Jiong Wang  <jiong.wang@arm.com>
10487
10488         * aarch64-linux-tdep.c
10489         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10490         section.
10491         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10492
10493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10494             Jiong Wang  <jiong.wang@arm.com>
10495
10496         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10497         instructions.
10498         (aarch64_analyze_prologue_test): Add PACIASP test.
10499         (aarch64_prologue_prev_register): Unmask PC value.
10500
10501 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10502             Jiong Wang  <jiong.wang@arm.com>
10503
10504         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10505         (aarch64_dwarf2_prev_register): Unmask PC value.
10506         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10507         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10508         DW_CFA_AARCH64_negate_ra_state.
10509         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10510
10511 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10512             Jiong Wang  <jiong.wang@arm.com>
10513
10514         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10515         registers.
10516         (aarch64_pseudo_register_name): Likewise.
10517         (aarch64_pseudo_register_type): Likewise.
10518         (aarch64_pseudo_register_reggroup_p): Likewise.
10519         (aarch64_gdbarch_init): Add pauth registers.
10520         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10521         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10522         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10523         (struct gdbarch_tdep): Add regnum for ra_state.
10524
10525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10526             Jiong Wang  <jiong.wang@arm.com>
10527
10528         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10529
10530 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10531             Jiong Wang  <jiong.wang@arm.com>
10532
10533         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10534         function.
10535         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10536         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10537         (aarch64_gdbarch_init): Add puth registers.
10538         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10539         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10540         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10541
10542 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10543             Jiong Wang  <jiong.wang@arm.com>
10544
10545         * aarch64-linux-nat.c
10546         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10547         * aarch64-linux-tdep.c
10548         (aarch64_linux_core_read_description): Likewise.
10549         (aarch64_linux_get_hwcap): New function.
10550         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10551         (aarch64_linux_get_hwcap): New declaration.
10552
10553 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10554             Jiong Wang  <jiong.wang@arm.com>
10555
10556         * aarch64-linux-nat.c
10557         (aarch64_linux_nat_target::read_description): Add pauth param.
10558         * aarch64-linux-tdep.c
10559         (aarch64_linux_core_read_description): Likewise.
10560         * aarch64-tdep.c (struct target_desc): Add in pauth.
10561         (aarch64_read_description): Add pauth param.
10562         (aarch64_gdbarch_init): Likewise.
10563         * aarch64-tdep.h (aarch64_read_description): Likewise.
10564         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10565         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10566         * features/Makefile: Add new files.
10567         * features/aarch64-pauth.c: New file.
10568         * features/aarch64-pauth.xml: New file.
10569
10570 2019-03-20  Tom Tromey  <tromey@adacore.com>
10571
10572         * infrun.c (handle_inferior_event): Rename from
10573         handle_inferior_event_1.  Create a scoped_value_mark.
10574         (handle_inferior_event): Remove.
10575
10576 2019-03-19  Tom Tromey  <tromey@adacore.com>
10577
10578         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10579         * infrun.h (print_stop_event): Add "displays" parameter.
10580         * infrun.c (print_stop_event): Add "displays" parameter.
10581
10582 2019-03-19  Pedro Alves  <palves@redhat.com>
10583
10584         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10585         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10586         to -1.  Fix TABs vs spaces.
10587         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10588         * tui/tui-out.h (tui_ui_out) Add intro comments.
10589         <m_line, m_start_of_line>: In-class initialize, and add describing
10590         comment.
10591
10592 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10593
10594         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10595         variable names.
10596         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10597
10598 2019-03-18  Pedro Alves  <palves@redhat.com>
10599             Eli Zaretskii <eliz@gnu.org>
10600
10601         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10602         m_line and m_start_of_line.
10603
10604 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10605
10606         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10607         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10608         it returns a newline.  This fixes a regression in TU mode, whereby
10609         the next line is output on the same screen line as the user input.
10610
10611 2019-03-18  Tom Tromey  <tromey@adacore.com>
10612
10613         * minsyms.c (minimal_symbol_reader::install): Remove call to
10614         obstack_blank.
10615
10616 2019-03-18  Pedro Alves  <palves@redhat.com>
10617
10618         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10619         New globals.
10620         (apply_style): New, factored out from ...
10621         (apply_ansi_escape): ... this.  Handle reverse video mode.
10622         (tui_set_reverse_mode): New function.
10623         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10624         * tui/tui-winsource.c (tui_show_source_line): Use
10625         tui_set_reverse_mode instead of setting A_STANDOUT.
10626         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10627         New setter methods.
10628
10629 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10630
10631         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10632         Handle tabs.
10633
10634 2019-03-18  Tom Tromey  <tromey@adacore.com>
10635
10636         * ada-lang.c (empty_array): Add "high" parameter.
10637         (ada_evaluate_subexp): Update.
10638
10639 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10640
10641         * unittests/string_view-selftests.c: Define
10642         _initialize_string_view_selftests unconditionally.
10643
10644 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10645
10646         PR gdb/24350
10647         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10648
10649 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10650
10651         PR gdb/24351
10652         * windows-nat.c (display_selector): Fix format specifiers.
10653
10654 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10655
10656         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10657         tui_refill_source_window instead of tui_refresh_win, to update the
10658         current execution line.  This fixes redisplay of the current line
10659         when stepping through the code with "next" or "step".
10660
10661 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10662
10663         * source-cache.c (source_cache::get_source_lines): Call
10664         find_source_lines to initialize s->nlines.  This fixes vertical
10665         scrolling of TUI source window when the DOWN arrow is pressed.
10666
10667 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10668
10669         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10670         linux-thread-db.c (_initialize_thread_db): Likewise.
10671
10672 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10673
10674         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10675         wclrtoeol in tui_show_source_line".  This reverts changes made in
10676         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10677
10678 2019-03-15  Tom Tromey  <tom@tromey.com>
10679
10680         * symtab.h (struct minimal_symbol): Derive from
10681         general_symbol_info.
10682         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10683         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10684         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10685         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10686         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10687         (MSYMBOL_SEARCH_NAME): Update.
10688         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10689         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10690         * minsyms.c (minimal_symbol_reader::record_full): Update.
10691
10692 2019-03-15  Tom Tromey  <tom@tromey.com>
10693
10694         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10695
10696 2019-03-15  Tom Tromey  <tom@tromey.com>
10697
10698         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10699         unique_xmalloc_ptr.
10700         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10701         Update.
10702         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10703         (build_minimal_symbol_hash_tables)
10704         (minimal_symbol_reader::install): Update.
10705
10706 2019-03-15  Tom Tromey  <tom@tromey.com>
10707
10708         * symtab.c (create_demangled_names_hash): Update.
10709         (symbol_set_names): Update.
10710         * objfiles.h (struct objfile_per_bfd_storage)
10711         <demangled_names_hash>: Now an htab_up.
10712         * objfiles.c (objfile_per_bfd_storage): Simplify.
10713
10714 2019-03-15  Tom Tromey  <tom@tromey.com>
10715
10716         * objfiles.h (struct objfile_per_bfd_storage): Declare
10717         destructor.
10718         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10719         New.
10720         (get_objfile_bfd_data): Use new.  Don't initialize
10721         language_of_main.
10722         (free_objfile_per_bfd_storage): Remove.
10723         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10724
10725 2019-03-15  Tom Tromey  <tom@tromey.com>
10726
10727         * symfile.c (reread_symbols): Update.
10728         * objfiles.c (objfile::objfile): Update.
10729         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10730         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10731         comment.
10732         (minimal_symbol_reader::install): Update.
10733         (terminate_minimal_symbol_table): Remove.
10734         * jit.c (jit_object_close_impl): Update.
10735
10736 2019-03-15  Tom Tromey  <tom@tromey.com>
10737
10738         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10739         initializations.
10740
10741 2019-03-15  Tom Tromey  <tom@tromey.com>
10742
10743         * objfiles.h (struct objfile_per_bfd_storage)
10744         <demangled_hash_languages>: Now a bitset.
10745         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10746         (lookup_minimal_symbol): Update.
10747
10748 2019-03-15  Tom Tromey  <tom@tromey.com>
10749
10750         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10751         Don't return the symbol.
10752         * coffread.c (record_minimal_symbol): Use record_full.
10753
10754 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10755
10756         The MS-Windows port of ncurses fails to switch to a color pair if
10757         one or both of the colors are the implicit default colors.  This
10758         change records the default colors when TUI is initialized, and
10759         then specifies them explicitly when a color pair uses the default
10760         colors.  This allows color styling in TUI mode on MS-Windows.
10761
10762         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10763         ncurses_norm_attr.
10764         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10765         colors in ncurses_norm_attr.
10766         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10767         "none", replace it with the default color recorded in
10768         ncurses_norm_attr.
10769
10770 2019-03-14  Tom Tromey  <tromey@adacore.com>
10771
10772         * source-cache.h (class source_cache) <get_source_lines>: Return
10773         std::string.
10774         * source-cache.c (source_cache::extract_lines): Handle case where
10775         first_pos==npos.  Return std::string.
10776         (source_cache::get_source_lines): Update.
10777
10778 2019-03-14  Tom Tromey  <tromey@adacore.com>
10779
10780         * NEWS: Add item for "style sources" commands.
10781         * source-cache.c (source_cache::get_source_lines): Check
10782         source_styling.
10783         * cli/cli-style.c (source_styling): New global.
10784         (_initialize_cli_style): Add "style sources" commands.
10785         (show_style_sources): New function.
10786         * cli/cli-style.h (source_styling): Declare.
10787
10788 2019-03-14  Pedro Alves  <palves@redhat.com>
10789             Tom Tromey  <tromey@adacore.com>
10790
10791         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10792         * tui/tui-winsource.c (tui_refill_source_window): New function,
10793         from...
10794         (tui_horizontal_source_scroll): ... here.  Move some logic.
10795         * cli/cli-style.c (set_style_enabled): Notify new observable.
10796         * tui/tui-hooks.c (tui_redisplay_source): New function.
10797         (tui_attach_detach_observers): Attach or detach
10798         tui_redisplay_source.
10799         * observable.h (source_styling_changed): New observable.
10800         * observable.c: Define source_styling_changed observable.
10801
10802 2019-03-13  Tom Tromey  <tromey@adacore.com>
10803
10804         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10805         (i386_gnu_nat_target::store_registers): Update.
10806         * target-debug.h (target_debug_print_std_string): New macro.
10807         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10808         * windows-tdep.c (display_one_tib): Update.
10809         * tui/tui-stack.c (tui_make_status_line): Update.
10810         * top.c (print_inferior_quit_action): Update.
10811         * thread.c (thr_try_catch_cmd): Update.
10812         (add_thread_with_info): Update.
10813         (thread_target_id_str): Update.
10814         (thr_try_catch_cmd): Update.
10815         (thread_command): Update.
10816         (thread_find_command): Update.
10817         * record-btrace.c (record_btrace_target::info_record)
10818         (record_btrace_resume_thread, record_btrace_target::resume)
10819         (record_btrace_cancel_resume, record_btrace_step_thread)
10820         (record_btrace_target::wait, record_btrace_target::wait)
10821         (record_btrace_target::wait, record_btrace_target::stop): Update.
10822         * progspace.c (print_program_space): Update.
10823         * process-stratum-target.c
10824         (process_stratum_target::thread_address_space): Update.
10825         * linux-fork.c (linux_fork_mourn_inferior)
10826         (detach_checkpoint_command, info_checkpoints_command)
10827         (linux_fork_context): Update.
10828         (linux_fork_detach): Update.
10829         (class scoped_switch_fork_info): Update.
10830         (delete_checkpoint_command): Update.
10831         * infrun.c (follow_fork_inferior): Update.
10832         (follow_fork_inferior): Update.
10833         (proceed_after_vfork_done): Update.
10834         (handle_vfork_child_exec_or_exit): Update.
10835         (follow_exec): Update.
10836         (displaced_step_prepare_throw): Update.
10837         (displaced_step_restore): Update.
10838         (start_step_over): Update.
10839         (resume_1): Update.
10840         (clear_proceed_status_thread): Update.
10841         (proceed): Update.
10842         (print_target_wait_results): Update.
10843         (do_target_wait): Update.
10844         (context_switch): Update.
10845         (stop_all_threads): Update.
10846         (restart_threads): Update.
10847         (finish_step_over): Update.
10848         (handle_signal_stop): Update.
10849         (switch_back_to_stepped_thread): Update.
10850         (keep_going_pass_signal): Update.
10851         (print_exited_reason): Update.
10852         (normal_stop): Update.
10853         * inferior.c (inferior_pid_to_str): Change return type.
10854         (print_selected_inferior): Update.
10855         (add_inferior): Update.
10856         (detach_inferior): Update.
10857         * dummy-frame.c (fprint_dummy_frames): Update.
10858         * dcache.c (dcache_info_1): Update.
10859         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10860         (btrace_fetch, btrace_clear): Update.
10861         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10862         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10863         type.
10864         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10865         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10866         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10867         * gdbarch.c, gdbarch.h: Rebuild.
10868         * gdbarch.sh (core_pid_to_str): Change return type.
10869         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10870         return type.
10871         (windows_nat_target::pid_to_str): Change return type.
10872         (windows_delete_thread): Update.
10873         (windows_nat_target::attach): Update.
10874         (windows_nat_target::files_info): Update.
10875         * target-delegates.c: Rebuild.
10876         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10877         return type.
10878         (sol_thread_target::pid_to_str): Change return type.
10879         * remote.c (class remote_target) <pid_to_str>: Change return
10880         type.
10881         (remote_target::pid_to_str): Change return type.
10882         (extended_remote_target::attach, remote_target::remote_stop_ns)
10883         (remote_target::remote_notif_remove_queued_reply)
10884         (remote_target::push_stop_reply, remote_target::disable_btrace):
10885         Update.
10886         (extended_remote_target::attach): Update.
10887         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10888         type.
10889         (gdbsim_target::pid_to_str): Change return type.
10890         * ravenscar-thread.c (struct ravenscar_thread_target)
10891         <pid_to_str>: Change return type.
10892         (ravenscar_thread_target::pid_to_str): Change return type.
10893         * procfs.c (class procfs_target) <pid_to_str>: Change return
10894         type.
10895         (procfs_target::pid_to_str): Change return type.
10896         (procfs_target::attach): Update.
10897         (procfs_target::detach): Update.
10898         (procfs_target::fetch_registers): Update.
10899         (procfs_target::store_registers): Update.
10900         (procfs_target::wait): Update.
10901         (procfs_target::files_info): Update.
10902         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10903         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10904         return type.
10905         (nto_procfs_target::pid_to_str): Change return type.
10906         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10907         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10908         return type.
10909         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10910         (exit_lwp): Update.
10911         (attach_proc_task_lwp_callback, get_detach_signal)
10912         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10913         (linux_nat_target::resume, wait_lwp, stop_callback)
10914         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10915         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10916         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10917         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10918         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10919         type.
10920         (inf_ptrace_target::attach): Update.
10921         (inf_ptrace_target::files_info): Update.
10922         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10923         type.
10924         (go32_nat_target::pid_to_str): Change return type.
10925         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10926         (gnu_nat_target::wait): Update.
10927         (gnu_nat_target::wait): Update.
10928         (gnu_nat_target::resume): Update.
10929         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10930         (fbsd_nat_target::wait): Update.
10931         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10932         type.
10933         (darwin_nat_target::attach): Update.
10934         * corelow.c (class core_target) <pid_to_str>: Change return type.
10935         (core_target::pid_to_str): Change return type.
10936         * target.c (normal_pid_to_str): Change return type.
10937         (default_pid_to_str): Likewise.
10938         (target_pid_to_str): Change return type.
10939         (target_translate_tls_address): Update.
10940         (target_announce_detach): Update.
10941         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10942         return type.
10943         (bsd_uthread_target::pid_to_str): Change return type.
10944         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10945         type.
10946         (bsd_kvm_target::pid_to_str): Change return type.
10947         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10948         return type.
10949         (aix_thread_target::pid_to_str): Change return type.
10950         * target.h (struct target_ops) <pid_to_str>: Change return type.
10951         (target_pid_to_str, normal_pid_to_str): Likewise.
10952         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10953         type.
10954         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10955         type.
10956         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10957         return type.
10958         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10959         type.
10960         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10961         type.
10962         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10963         return type.
10964
10965 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10966
10967         * NEWS: Mention that the new default MI version is 3.  Mention
10968         changes to the output of commands and events that deal with
10969         multi-location breakpoints.
10970         * breakpoint.c: Include "mi/mi-out.h".
10971         (print_one_breakpoint): Change output syntax if using MI version
10972         >= 3.
10973         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10974         New.
10975         (mi_multi_location_breakpoint_output_fixed): New.
10976         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10977         (mi_cmd_fix_multi_location_breakpoint_output): New.
10978         (mi_multi_location_breakpoint_output_fixed): New.
10979         * mi/mi-cmds.c (mi_cmds): Register command
10980         -fix-multi-location-breakpoint-output.
10981         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10982         interpreter "mi".
10983
10984 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10985
10986         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10987         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10988         instantiate mi_ui_out based on interpreter name.
10989         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10990         * mi/mi-main.c (mi_load_progress): Likewise.
10991
10992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10993
10994         * NEWS: Combine separate "New targets" sections for 8.3.
10995
10996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10997
10998         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10999         (ppcfbsd_init_abi): Install gdbarch
11000         "fetch_tls_load_module_address" and "get_thread_local_address"
11001         methods.
11002
11003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11004
11005         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11006         (riscv_fbsd_init_abi): Install gdbarch
11007         "fetch_tls_load_module_address" and "get_thread_local_address"
11008         methods.
11009
11010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11011
11012         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11013         (i386fbsd_init_abi): Install gdbarch
11014         "fetch_tls_load_module_address" and "get_thread_local_address"
11015         methods.
11016
11017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11018
11019         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11020         (amd64fbsd_init_abi): Install gdbarch
11021         "fetch_tls_load_module_address" and "get_thread_local_address"
11022         methods.
11023
11024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11025
11026         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11027         (struct fbsd_pspace_data): New type.
11028         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11029         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11030         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11031         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11032         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11033
11034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11035
11036         * gdbtypes.c (lookup_struct_elt): New function.
11037         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11038         * gdbtypes.h (struct struct_elt): New type.
11039         (lookup_struct_elt): New prototype.
11040
11041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11042
11043         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11044         remove disabled code block.
11045
11046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11047
11048         * gdbarch.sh (get_thread_local_address): New method.
11049         * gdbarch.h, gdbarch.c: Regenerate.
11050         * target.c (target_translate_tls_address): Use
11051         gdbarch_get_thread_local_address if present instead of
11052         target::get_thread_local_address.
11053
11054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11055
11056         * target.h (target::get_thread_local_address): Update comment.
11057
11058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11059
11060         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11061         objfile->separate_debug_objfile_backlink if not NULL.
11062
11063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11064
11065         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11066         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11067         (amd64bsd_store_inferior_registers): Likewise.
11068         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11069         Enable segment base registers.
11070         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11071         PT_GETFSBASE and PT_GETGSBASE.
11072         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11073         PT_SETGSBASE.
11074         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11075         segment base registers.
11076         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11077
11078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11079
11080         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11081         Update calls to i386_target_description to add 'segments'
11082         parameter.
11083         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11084         add segment base registers.
11085         * arch/i386.c (i386_create_target_description): Add 'segments'
11086         parameter to enable segment base registers.
11087         * arch/i386.h (i386_create_target_description): Likewise.
11088         * features/i386/32bit-segments.xml: New file.
11089         * features/i386/32bit-segments.c: Generate.
11090         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11091         call to i386_target_description to add 'segments' parameter.
11092         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11093         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11094         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11095         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11096         if feature is present.
11097         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11098         Add 'segments' parameter to call to i386_target_description.
11099         (i386_target_description): Add 'segments' parameter to enable
11100         segment base registers.
11101         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11102         to call to i386_target_description.
11103         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11104         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11105         Define I386_NUM_REGS.
11106         (i386_target_description): Add 'segments' parameter to enable
11107         segment base registers.
11108
11109 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11110
11111         PR/24325
11112         * source-cache.c: #undef open and close, to avoid unresolved
11113         externals during linking.
11114
11115 2019-03-12  Tom Tromey  <tromey@adacore.com>
11116
11117         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11118         const.  Add initializers.
11119         (_initialize_remote): Don't initialize ptid globals.
11120
11121 2019-03-12  Pedro Alves  <palves@redhat.com>
11122
11123         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11124
11125 2019-03-12  Pedro Alves  <palves@redhat.com>
11126
11127         * cp-name-parser.y (main): Remove unused 'len' variable.
11128
11129 2019-03-12  Tom Tromey  <tromey@adacore.com>
11130
11131         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11132         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11133
11134 2019-03-12  Tom Tromey  <tromey@adacore.com>
11135
11136         * linux-nat.c (iterate_over_lwps): Update.
11137         (stop_callback): Remove parameter.
11138         (stop_wait_callback, detach_callback, resume_set_callback)
11139         (select_singlestep_lwp_callback, set_ignore_sigint)
11140         (status_callback, resumed_callback, resume_clear_callback)
11141         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11142         data parameter.
11143         (linux_nat_target::detach, linux_nat_target::resume)
11144         (linux_stop_and_wait_all_lwps, select_event_lwp)
11145         (linux_nat_filter_event, linux_nat_wait_1)
11146         (linux_nat_target::kill, linux_nat_target::stop)
11147         (linux_nat_target::stop): Update.
11148         (linux_nat_resume_callback): Change type.
11149         (resume_stopped_resumed_lwps, count_events_callback)
11150         (select_event_lwp_callback): Likewise.
11151         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11152         * arm-linux-nat.c (struct update_registers_data): Remove.
11153         (update_registers_callback): Change type.
11154         (arm_linux_insert_hw_breakpoint1): Update.
11155         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11156         parameter.
11157         (x86_linux_dr_set_addr): Update.
11158         (x86_linux_dr_set_control): Update.
11159         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11160         (iterate_over_lwps): Use gdb::function_view.
11161         * nat/aarch64-linux-hw-point.c (struct
11162         aarch64_dr_update_callback_param): Remove.
11163         (debug_reg_change_callback): Change type.
11164         (aarch64_notify_debug_reg_change): Update.
11165         * s390-linux-nat.c (s390_refresh_per_info): Update.
11166
11167 2019-03-11  Tom Tromey  <tromey@adacore.com>
11168
11169         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11170         redundant assignment to "this_cu".
11171
11172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11173
11174         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11175
11176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11177
11178         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11179         from...
11180         (rank_one_type): ... this.
11181
11182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11183
11184         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11185         from...
11186         (rank_one_type): ... this.
11187
11188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11189
11190         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11191         from...
11192         (rank_one_type): ... this.
11193
11194 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11195
11196         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11197         from...
11198         (rank_one_type): ... this.
11199
11200 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11201
11202         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11203         from...
11204         (rank_one_type): ... this.
11205
11206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11207
11208         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11209         from...
11210         (rank_one_type): ... this.
11211
11212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11213
11214         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11215         from...
11216         (rank_one_type): ... this.
11217
11218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11219
11220         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11221         from...
11222         (rank_one_type): ... this.
11223
11224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11225
11226         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11227         from...
11228         (rank_one_type): ... this.
11229
11230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11231
11232         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11233         from...
11234         (rank_one_type): ... this.
11235
11236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11237
11238         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11239         from...
11240         (rank_one_type): ... this.
11241
11242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11243
11244         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11245         from...
11246         (rank_one_type): ... this.
11247
11248 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11249
11250         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11251         inferior-events' shows the example events.
11252
11253 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11254
11255         Support styling on native MS-Windows console
11256
11257         PR/24315
11258         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11259         on MS-Windows if $TERM is not defined.
11260
11261         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11262
11263         * posix-hdep.c (gdb_console_fputs):
11264         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11265         functions.
11266         * ui-file.h (gdb_console_fputs): Add prototype.
11267
11268         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11269         back to fputs only if the former returns zero.
11270
11271 2019-03-07  Tom Tromey  <tom@tromey.com>
11272
11273         * symmisc.c (print_symbol_bcache_statistics): Update.
11274         (print_objfile_statistics): Update.
11275         * symfile.c (allocate_symtab): Update.
11276         * stabsread.c: Don't include bcache.h.
11277         * psymtab.h (struct psymbol_bcache): Don't declare.
11278         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11279         (psymbol_bcache_init, psymbol_bcache_free)
11280         (psymbol_bcache_get_bcache): Don't declare.
11281         * psymtab.c (struct psymbol_bcache): Remove.
11282         (psymtab_storage::psymtab_storage): Update.
11283         (psymtab_storage::~psymtab_storage): Update.
11284         (psymbol_bcache_init, psymbol_bcache_free)
11285         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11286         (add_psymbol_to_bcache): Update.
11287         (allocate_psymtab): Update.
11288         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11289         macro_cache>: No longer pointers.
11290         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11291         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11292         * macrotab.c (macro_bcache): Update.
11293         * macroexp.c: Don't include bcache.h.
11294         * gdbtypes.c (check_types_worklist): Update.
11295         (types_deeply_equal): Remove TRY/CATCH.  Update.
11296         * elfread.c (elf_symtab_read): Update.
11297         * dwarf2read.c: Don't include bcache.h.
11298         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11299         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11300         (print_bcache_statistics, bcache_memory_used): Don't declare.
11301         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11302         methods.  Rename all data members.
11303         * bcache.c (struct bcache): Move to bcache.h.
11304         (bcache::expand_hash_table): Rename from expand_hash_table.
11305         (bcache): Remove.
11306         (bcache::insert): Rename from bcache_full.
11307         (bcache::compare): Rename from bcache_compare.
11308         (bcache_xmalloc): Remove.
11309         (bcache::~bcache): Rename from bcache_xfree.
11310         (bcache::print_statistics): Rename from print_bcache_statistics.
11311         (bcache::memory_used): Rename from bcache_memory_used.
11312
11313 2019-03-07  Pedro Alves  <palves@redhat.com>
11314
11315         * infrun.c (normal_stop): Also check for
11316         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11317
11318 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11319
11320         * f-lang.c (value_from_host_double): Moved to...
11321         * value.c (value_from_host_double): ...here.
11322         * value.h (value_from_host_double): Declare.
11323         * guile/scm-math.c (vlscm_convert_typed_number): Use
11324         value_from_host_double.
11325         (vlscm_convert_number): Likewise.
11326         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11327         * python/py-value.c (convert_value_from_python): Likewise.
11328
11329 2019-03-06  Tom Tromey  <tom@tromey.com>
11330
11331         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11332
11333 2019-03-06  Tom Tromey  <tom@tromey.com>
11334
11335         * utils.h (free_current_contents): Don't declare.
11336         * utils.c (free_current_contents): Remove.
11337
11338 2019-03-06  Tom Tromey  <tom@tromey.com>
11339
11340         * top.c (quit_force): Update.
11341         * main.c (captured_command_loop): Update.
11342         * common/new-op.c (operator new): Update.
11343         * common/common-exceptions.c (struct catcher)
11344         <save_cleanup_chain>: Remove member.
11345         (exceptions_state_mc_init): Update.
11346         (exception_try_scope_entry): Return nullptr.
11347         (exception_try_scope_exit, exception_rethrow)
11348         (throw_exception_sjlj, throw_exception_cxx): Update.
11349         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11350         (all_cleanups, do_cleanups, discard_cleanups)
11351         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11352         (restore_cleanups, restore_final_cleanups): Don't declare.
11353         (do_final_cleanups): Remove parameter.
11354         * common/cleanups.c (cleanup_chain, make_cleanup)
11355         (make_cleanup_dtor, all_cleanups, do_cleanups)
11356         (discard_my_cleanups, discard_cleanups)
11357         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11358         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11359         (null_cleanup): Remove.
11360         (do_final_cleanups): Remove parameter.
11361
11362 2019-03-06  Tom Tromey  <tom@tromey.com>
11363
11364         * remote.c (remote_target::remote_parse_stop_reply): Use
11365         unique_xmalloc_ptr.
11366
11367 2019-03-06  Tom Tromey  <tom@tromey.com>
11368
11369         * stabsread.c (struct stabs_field_info): Rename from field_info.
11370         <list, fnlist>: Add initializers.
11371         <obstack>: New member.
11372         (read_member_functions, read_struct_fields, read_baseclasses):
11373         Allocate on obstack.  Don't use cleanups.
11374         (read_one_struct_field, read_member_functions, read_struct_fields)
11375         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11376         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11377         (read_struct_type): Update.
11378
11379 2019-03-06  Tom Tromey  <tom@tromey.com>
11380
11381         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11382         * common/filestuff.h (make_cleanup_close): Don't declare.
11383         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11384         Remove.
11385
11386 2019-03-06  Tom Tromey  <tom@tromey.com>
11387
11388         * solib-aix.c: Use make_scope_exit.
11389
11390 2019-03-06  Tom Tromey  <tom@tromey.com>
11391
11392         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11393         Use make_scope_exit.
11394
11395 2019-03-06  Tom Tromey  <tom@tromey.com>
11396
11397         * solib-svr4.c (disable_probes_interface): Remove parameter.
11398         (svr4_handle_solib_event): Use make_scope_exit.
11399
11400 2019-03-06  Tom Tromey  <tom@tromey.com>
11401
11402         * remote.c (struct stop_reply_deleter): Remove.
11403         (stop_reply_up): Update.
11404         (struct stop_reply): Derive from notif_event.  Don't typedef.
11405         <regcache>: Now a std::vector.
11406         (stop_reply_xfree): Remove.
11407         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11408         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11409         (remote_target::discard_pending_stop_replies): Use delete.
11410         (remote_target::remote_parse_stop_reply): Update.
11411         (remote_target::process_stop_reply): Update.
11412         * remote-notif.h (struct notif_event): Add virtual destructor.
11413         Remove "dtr" member.
11414         (struct notif_client) <alloc_event>: Return a unique_ptr.
11415         (notif_event_xfree): Don't declare.
11416         (notif_event_up): New typedef.
11417         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11418         (notif_event_xfree, do_notif_event_xfree): Remove.
11419         (remote_notif_state_xfree): Update.
11420
11421 2019-03-06  Tom Tromey  <tom@tromey.com>
11422
11423         * infrun.c (displaced_step_clear_cleanup): Now a
11424         forward_scope_exit type.
11425         (displaced_step_prepare_throw): Update.
11426         (displaced_step_fixup): Update.
11427
11428 2019-03-06  Tom Tromey  <tom@tromey.com>
11429
11430         * inferior.h (class inferior): Update comment.
11431         * gdbthread.h (class thread_info): Update comment.
11432
11433 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11434             Tom Tromey  <tom@tromey.com>
11435
11436         * stabsread.h (struct stab_section_list): Remove.
11437         (coffstab_build_psymtabs): Update.
11438         * dbxread.c (symbuf_sections): Now a std::vector.
11439         (sect_idx): New global.
11440         (fill_symbuf): Update.
11441         (coffstab_build_psymtabs): Change type of stabsects parameter.
11442         Update.
11443         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11444         std::vector.
11445         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11446         (coff_locate_sections): Update.
11447         (coff_symfile_read): Remove cleanups.  Update.
11448         (init_stringtab): Add storage parameter.
11449         (free_stringtab, free_stringtab_cleanup): Remove.
11450         (init_lineno): Add storage parameter.
11451         (free_linetab, free_linetab_cleanup): Remove.
11452
11453 2019-03-06  Pedro Alves  <palves@redhat.com>
11454
11455         * linux-fork.c (fork_info::clobber_regs): Delete.
11456         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11457         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11458         comment.  Adjust.
11459         (scoped_switch_fork_info::scoped_switch_fork_info)
11460         (checkpoint_command, linux_fork_context): Adjust
11461         fork_save_infrun_state calls.
11462
11463 2019-03-06  Pedro Alves  <palves@redhat.com>
11464
11465         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11466         (inf_has_multiple_threads): Return 'bool' and rewrite using
11467         inferior_info::threads().
11468
11469 2019-03-06  Pedro Alves  <palves@redhat.com>
11470
11471         * linux-fork.c: Include <list>.
11472         (fork_list): Now a std::list instance.
11473         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11474         (forks_exist_p, find_last_fork): Adjust.
11475         (new_fork): Delete.
11476         (one_fork_p): New.
11477         (add_fork): Adjust.
11478         (free_fork): Delete, folded into fork_info::~fork_info().
11479         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11480         Adjust.
11481         (init_fork_list): Delete.
11482         (linux_fork_killall, linux_fork_mourn_inferior)
11483         (linux_fork_detach, info_checkpoints_command): Adjust.
11484         (_initialize_linux_fork): No longer call init_fork_list.
11485
11486 2019-03-06  Pedro Alves  <palves@redhat.com>
11487
11488         * linux-fork.c (new_fork): New, split out of ...
11489         (add_fork): ... this.  Return void.  Move "first fork" special
11490         case from here, to ...
11491         (checkpoint_command): ... here.
11492         * linux-linux.h (add_fork): Return void.
11493
11494 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11495
11496         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11497
11498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11499             Chris January  <chris.january@arm.com>
11500             David Lecomber  <david.lecomber@arm.com>
11501
11502         * f-exp.y: New token, UNOP_INTRINSIC.
11503         (exp): New pattern using UNOP_INTRINSIC token.
11504         (f77_keywords): Add 'abs' keyword.
11505         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11506         (value_from_host_double): New function.
11507         (evaluate_subexp_f): Support UNOP_ABS.
11508
11509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11510
11511         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11512         types.
11513
11514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11515
11516         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11517         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11518         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11519
11520 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11521
11522         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11523
11524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11525             Chris January  <chris.january@arm.com>
11526
11527         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11528         * f-exp.y: Define 'KIND' token.
11529         (exp): New pattern for KIND expressions.
11530         (ptype): Handle types with a kind extension.
11531         (direct_abs_decl): Extend to spot kind extensions.
11532         (f77_keywords): Add 'kind' to the list.
11533         (push_kind_type): New function.
11534         (convert_to_kind_type): New function.
11535         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11536         * parse.c (operator_length_standard): Likewise.
11537         * parser-defs.h (enum type_pieces): Add tp_kind.
11538         * std-operator.def: Add UNOP_KIND.
11539
11540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11541
11542         * f-exp.y (f_parse): Set yydebug.
11543
11544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11545
11546         * f-lang.c (evaluate_subexp_f): New function.
11547         (exp_descriptor_f): New global.
11548         (f_language_defn): Use exp_descriptor_f instead of
11549         exp_descriptor_standard.
11550
11551 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11552
11553         * f-exp.y (struct token): Add comments.
11554         (dot_ops): Remove uppercase versions and the end marker.
11555         (f77_keywords): Likewise.
11556         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11557         entries in the dot_ops array are case insensitive, and use
11558         strncasecmp to compare strings.  Also some whitespace cleanup in
11559         this area.  Similar for the f77_keywords array, except entries in
11560         this list might be case sensitive.
11561
11562 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11563
11564         * f-exp.y (struct f77_boolean_val): Add comments.
11565         (boolean_values): Remove uppercase versions, and end marker.
11566         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11567         and use strncasecmp to achieve case insensitivity.  Additionally,
11568         perform whitespace cleanup around this code.
11569
11570 2019-03-06  Tom Tromey  <tromey@adacore.com>
11571
11572         * remote-sim.c (gdbsim_target_open): Use result of
11573         gdb_argv::release.
11574
11575 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11576         Dirk Schubert  <dirk.schubert@arm.com>
11577         Chris January  <chris.january@arm.com>
11578
11579         * eval.c (evaluate_subexp_standard): Call Fortran argument
11580         wrapping logic.
11581         * f-lang.c (struct value): A value which can be passed into a
11582         Fortran function call.
11583         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11584         where appropriate.
11585         (struct type): Value ready for a Fortran function call.
11586         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11587         is needed.
11588         * f-lang.h (fortran_argument_convert): Declaration.
11589         (fortran_preserve_arg_pointer): Declaration.
11590         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11591
11592 2019-03-05  Tom Tromey  <tromey@adacore.com>
11593
11594         * python/py-prettyprint.c (print_string_repr): Remove #if.
11595         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11596
11597 2019-03-05  Tom Tromey  <tromey@adacore.com>
11598
11599         * target.c (the_dummy_target): Move later.  Change type to
11600         "dummy_target".
11601         (initialize_targets): Don't initialize the_dummy_target.
11602
11603 2019-03-05  Tom Tromey  <tromey@adacore.com>
11604
11605         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11606         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11607
11608 2019-03-05  Tom Tromey  <tromey@adacore.com>
11609
11610         * windows-nat.c (windows_nat_target::attach)
11611         (windows_nat_target::detach): Don't call gdb_flush.
11612         * valprint.c (generic_val_print, val_print, val_print_string):
11613         Don't call gdb_flush.
11614         * utils.c (defaulted_query): Don't call gdb_flush.
11615         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11616         * target.c (target_announce_detach): Don't call gdb_flush.
11617         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11618         * remote.c (extended_remote_target::attach): Don't call
11619         gdb_flush.
11620         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11621         * printcmd.c (do_examine): Don't call gdb_flush.
11622         (info_display_command): Don't call gdb_flush.
11623         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11624         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11625         * memattr.c (info_mem_command): Don't call gdb_flush.
11626         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11627         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11628         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11629         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11630         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11631         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11632         (gnu_nat_target::detach): Don't call gdb_flush.
11633         * f-valprint.c (f_val_print): Don't call gdb_flush.
11634         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11635         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11636         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11637         gdb_flush.
11638         * c-valprint.c (c_val_print): Don't call gdb_flush.
11639         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11640
11641 2019-03-05  Tom Tromey  <tromey@adacore.com>
11642
11643         * varobj.c (update_dynamic_varobj_children): Update.
11644         (install_default_visualizer): Use reset, not release.
11645         * value.c (set_internalvar): Update.
11646         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11647         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11648         ATTRIBUTE_UNUSED_RESULT.
11649
11650 2019-03-05  Tom Tromey  <tromey@adacore.com>
11651
11652         * remote.c (class scoped_remote_fd) <release>: Add
11653         ATTRIBUTE_UNUSED_RESULT.
11654
11655 2019-03-05  Tom Tromey  <tromey@adacore.com>
11656
11657         * macroexp.c (struct macro_buffer) <release>: Add
11658         ATTRIBUTE_UNUSED_RESULT.
11659
11660 2019-03-05  Tom Tromey  <tromey@adacore.com>
11661
11662         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11663         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11664         ATTRIBUTE_UNUSED_RESULT.
11665
11666 2019-03-05  Tom Tromey  <tromey@adacore.com>
11667
11668         * common/scoped_fd.h (class scoped_fd) <release>: Add
11669         ATTRIBUTE_UNUSED_RESULT.
11670
11671 2019-03-05  Tom Tromey  <tromey@adacore.com>
11672
11673         * parser-defs.h (struct parser_state) <release>: Add
11674         ATTRIBUTE_UNUSED_RESULT.
11675
11676 2019-03-05  Tom Tromey  <tromey@adacore.com>
11677
11678         * utils.h (class gdb_argv) <release>: Add
11679         ATTRIBUTE_UNUSED_RESULT.
11680         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11681
11682 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11683
11684         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11685         for-loop range, to avoid compiler warnings.
11686
11687         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11688         avoid compiler warnings about unused variables.
11689
11690         * NEWS: Mention end of support for native debugging on MS-Windows
11691         before XP.
11692
11693         PR gdb/24292
11694         * common/netstuff.c:
11695         * gdbserver/gdbreplay.c
11696         * gdbserver/remote-utils.c:
11697         * ser-tcp.c:
11698         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11699         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11700         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11701         'getaddrinfo' and 'freeaddrinfo' were not available before
11702         Windows XP, and mingw.org's MinGW headers by default define
11703         _WIN32_WINNT to 0x500.
11704
11705 2019-03-01  Gary Benson <gbenson@redhat.com>
11706
11707         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11708
11709 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11710             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11711
11712         PR gdb/8527
11713         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11714         set_sigint_trap, clear_sigint_trap.
11715
11716 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11717
11718         * target.c (target_detach): Clear the regcache and the
11719         frame cache.
11720
11721 2019-02-27  Pedro Alves  <palves@redhat.com>
11722
11723         * utils.c (set_screen_size): When we cap the height/width sizes,
11724         tweak the corresponding command variable to show "unlimited":
11725
11726 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11727             Pedro Alves  <palves@redhat.com>
11728
11729         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11730         before calling rl_set_screen_size.
11731
11732 2019-02-27  Tom Tromey  <tromey@adacore.com>
11733
11734         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11735         define.
11736         * python/py-value.c: Remove Python 2.4 workaround.
11737         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11738         workaround.
11739         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11740         Python 2.4 workaround.
11741         * python/python-internal.h: Remove Python 2.4 comment.
11742         (Py_ssize_t): Don't define.
11743         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11744         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11745         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11746         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11747         * python/python.c (do_start_initialization): Remove Python 2.4
11748         workaround.
11749         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11750         (print_children): Remove Python 2.4 workaround.
11751         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11752         workaround.
11753         (CHARBUFFERPROC_NAME): Remove.
11754         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11755         Python 2.4 workaround.
11756
11757 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11758
11759         * NEWS: Note minimum Python version.
11760
11761 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11762
11763         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11764         code from these functions.  Remove corresponding ifdefs.  Use
11765         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11766         Remove gotos and target of gotos.
11767         (infpy_search_memory): Likewise.
11768
11769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11770
11771         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11772         (hppa_gdbarch_init): Don't register deleted functions with
11773         gdbarch.
11774
11775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11776
11777         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11778         (h8300_unwind_sp): Delete.
11779         (h8300_dummy_id): Delete.
11780         (h8300_gdbarch_init): Don't register deleted functions with
11781         gdbarch.
11782
11783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11784
11785         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11786         (ft32_unwind_pc): Delete.
11787         (ft32_unwind_sp): Delete.
11788         (ft32_gdbarch_init): Don't register deleted functions with
11789         gdbarch.
11790
11791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11792
11793         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11794         (frv_unwind_pc): Delete.
11795         (frv_unwind_sp): Delete.
11796         (frv_gdbarch_init): Don't register deleted functions with
11797         gdbarch.
11798
11799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11800
11801         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11802         (riscv_unwind_pc): Delete.
11803         (riscv_unwind_sp): Delete.
11804         (riscv_gdbarch_init): Don't register deleted functions with
11805         gdbarch.
11806
11807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11808
11809         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11810         (csky_unwind_pc): Delete.
11811         (csky_unwind_sp): Delete.
11812         (csky_gdbarch_init): Don't register deleted functions with
11813         gdbarch.
11814
11815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11816
11817         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11818         (cris_unwind_pc): Delete.
11819         (cris_unwind_sp): Delete.
11820         (cris_gdbarch_init): Don't register deleted functions with
11821         gdbarch.
11822
11823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11824
11825         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11826         (bfin_unwind_pc): Delete.
11827         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11828
11829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11830
11831         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11832         (arm_unwind_pc): Delete.
11833         (arm_unwind_sp): Delete.
11834         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11835
11836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11837
11838         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11839         (arc_unwind_pc): Delete.
11840         (arc_unwind_sp): Delete.
11841         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11842
11843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11844
11845         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11846         (alpha_unwind_pc): Delete.
11847         (alpha_gdbarch_init): Don't register deleted functions with
11848         gdbarch.
11849
11850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11851
11852         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11853         (aarch64_unwind_pc): Delete.
11854         (aarch64_unwind_sp): Delete.
11855         (aarch64_gdbarch_init): Don't register deleted functions with
11856         gdbarch.
11857
11858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11859
11860         * gdbtypes.c (type_align): Don't consider static members when
11861         computing structure alignment.
11862
11863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11864
11865         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11866         return 0 for other types.
11867         * arch-utils.c (default_type_align): Always return 0.
11868         * gdbarch.h: Regenerate.
11869         * gdbarch.sh (type_align): Extend comment.
11870         * gdbtypes.c (type_align): Add additional comments, always call
11871         gdbarch_type_align before applying the default rules.
11872         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11873         generic code will then apply a suitable default.
11874         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11875         types, return 0 for other types.
11876
11877 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11878
11879         * NEWS: Create a new section for the next release branch.
11880         Rename the section of the current branch, now that it has
11881         been cut.
11882
11883 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11884
11885         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11886         * version.in: Bump version to 8.3.50.DATE-git.
11887
11888 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11889
11890         * aix-thread.c (ptid_cmp): Remove unused variable.
11891         (get_signaled_thread): Likewise.
11892         (store_regs_user_thread): Likewise.
11893         (store_regs_kernel_thread): Likewise.
11894         (fetch_regs_kernel_thread): Remove shadowed variable.
11895
11896 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11897
11898         * features/riscv/32bit-cpu.xml: Add register numbers.
11899         * features/riscv/32bit-fpu.c: Regenerate.
11900         * features/riscv/32bit-fpu.xml: Add register numbers.
11901         * features/riscv/64bit-cpu.xml: Add register numbers.
11902         * features/riscv/64bit-fpu.c: Regenerate.
11903         * features/riscv/64bit-fpu.xml: Add register numbers.
11904
11905 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11906
11907         * NEWS: Mention two argument form of gdb.Value constructor.
11908         * python/py-value.c (convert_buffer_and_type_to_value): New
11909         function.
11910         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11911         Add support for handling an optional second argument.  Call
11912         convert_buffer_and_type_to_value as appropriate.
11913         * python/python-internal.h (Py_buffer_deleter): New struct.
11914         (Py_buffer_up): New typedef.
11915
11916 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11917
11918         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11919         instead of releasing ownership.
11920
11921 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11922
11923         * dwarf2read.c (open_and_init_dwp_file): Call
11924         elf_numsections instead of bfd_count_sections to initialize
11925         dwp_file->num_sections.
11926
11927 2019-02-25  Tom Tromey  <tromey@adacore.com>
11928
11929         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11930
11931 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11932
11933         * gcore.in: Add '--readnever' option when invoking GDB.
11934
11935 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11936
11937         * MAINTAINERS: Update my email address.
11938
11939 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11940
11941         * build-id.c (build_id_to_debug_bfd_1): New function.
11942         (build_id_to_debug_bfd): Look for separate debug file in
11943         sysroot.
11944
11945 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11946
11947         * gdbarch.sh: Update the copyright year range that is placed into
11948         generated files.
11949
11950 2019-02-22  Keith Seitz  <keiths@redhat.com>
11951
11952         PR symtab/23853
11953         * linespec.c (create_sals_line_offset): Search for the default
11954         symtab's filename instead of its fullname.
11955
11956 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11957
11958         * NEWS: Update style defaults.
11959
11960 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11961
11962         * main.c (captured_main_1): Disable styling in batch mode.
11963
11964 2019-02-20  Tom Tromey  <tom@tromey.com>
11965
11966         * symtab.c (symtab_symbol_info): Fix typos.
11967
11968 2019-02-20  Tom Tromey  <tromey@adacore.com>
11969
11970         * findcmd.c (_initialize_mem_search): Use upper case for
11971         metasyntactic variables.
11972
11973 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11974
11975         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11976         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11977
11978 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11979
11980         * top.h (source_file_name): Change to std::string.
11981         * top.c (source_file_name): Likewise.
11982         (command_line_input): Adjust.
11983         * cli/cli-script.c (script_from_file): Adjust.
11984
11985 2019-02-19  Tom Tromey  <tromey@adacore.com>
11986
11987         * ravenscar-thread.c
11988         (ravenscar_thread_target::update_thread_list): Don't call
11989         ada_build_task_list.
11990         * ada-lang.h (ada_build_task_list): Don't declare.
11991         * ada-tasks.c (struct ada_tasks_inferior_data)
11992         <task_list_valid_p>: Now bool.
11993         (read_known_tasks, ada_task_list_changed)
11994         (ada_tasks_invalidate_inferior_data): Update.
11995         (read_known_tasks_array): Return bool.
11996         (read_known_tasks_list): Likewise.
11997         (read_known_tasks): Return void.
11998         (ada_build_task_list): Now static.
11999
12000 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12001
12002         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12003         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12004
12005 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12006
12007         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12008         variant for ada_tasks_pspace_data_handle and
12009         ada_tasks_inferior_data_handle.
12010         (ada_tasks_pspace_data_cleanup): New function.
12011         (ada_tasks_inferior_data_cleanup): New function.
12012
12013 2019-02-17  Tom Tromey  <tom@tromey.com>
12014
12015         * macrotab.h (macro_source_fullname): Return a std::string.
12016         * macrotab.c (macro_include, check_for_redefinition)
12017         (macro_undef, macro_lookup_definition, foreach_macro)
12018         (foreach_macro_in_scope): Update.
12019         (macro_source_fullname): Return a std::string.
12020         * macrocmd.c (show_pp_source_pos): Update.
12021
12022 2019-02-17  Tom Tromey  <tom@tromey.com>
12023
12024         * macrocmd.c (show_pp_source_pos): Style the file names.
12025
12026 2019-02-17  Tom Tromey  <tom@tromey.com>
12027
12028         PR tui/24197:
12029         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12030
12031 2019-02-17  Tom Tromey  <tom@tromey.com>
12032
12033         * ada-lang.c (user_select_syms): Use filtered printing.
12034         * utils.c (wrap_style): New global.
12035         (desired_style): Remove.
12036         (emit_style_escape): Add stream parameter.
12037         (set_output_style, reset_terminal_style, prompt_for_continue):
12038         Update.
12039         (flush_wrap_buffer): Only flush gdb_stdout.
12040         (wrap_here): Set wrap_style.
12041         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12042         treat escape sequences as a character.  Change when wrap buffer is
12043         flushed.
12044         (fputs_styled): Do not set the output style when the default is
12045         requested.
12046         * ui-style.h (struct ui_file_style) <is_default>: New method.
12047         * source.c (print_source_lines_base): Emit escape sequences in one
12048         piece.
12049
12050 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12051
12052         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12053         integers and enumeration types.
12054
12055 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12056
12057         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12058         instead of lookup_symbol_in_language
12059         (do_exact_match): New function.
12060         (ada_get_symbol_name_matcher): Return do_exact_match when
12061         doing a verbatim match.
12062
12063 2019-02-15  Tom Tromey  <tromey@adacore.com>
12064
12065         * ravenscar-thread.c (ravenscar_thread_target::resume)
12066         (ravenscar_thread_target::wait): Special case wildcard requests.
12067
12068 2019-02-15  Tom Tromey  <tromey@adacore.com>
12069
12070         * ravenscar-thread.c (base_ptid): Remove.
12071         (struct ravenscar_thread_target) <close>: New method.
12072         <m_base_ptid>: New member.
12073         <update_inferior_ptid, active_task, task_is_currently_active,
12074         runtime_initialized>: Declare methods.
12075         <ravenscar_thread_target>: Add constructor.
12076         (ravenscar_thread_target::task_is_currently_active)
12077         (ravenscar_thread_target::update_inferior_ptid)
12078         (ravenscar_runtime_initialized): Rename.  Now methods.
12079         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12080         (ravenscar_thread_target::update_thread_list): Update.
12081         (ravenscar_thread_target::active_task): Now method.
12082         (ravenscar_thread_target::store_registers)
12083         (ravenscar_thread_target::prepare_to_store)
12084         (ravenscar_thread_target::prepare_to_store)
12085         (ravenscar_thread_target::mourn_inferior): Update.
12086         (ravenscar_inferior_created): Use "new" to create target.
12087         (ravenscar_thread_target::get_ada_task_ptid): Update.
12088         (_initialize_ravenscar): Don't initialize base_ptid.
12089         (ravenscar_ops): Remove global.
12090
12091 2019-02-15  Tom Tromey  <tromey@adacore.com>
12092
12093         * target.h (push_target): Declare new overload.
12094         * target.c (push_target): New overload, taking an rvalue reference.
12095         * remote.c (remote_target::open_1): Use push_target overload.
12096         * corelow.c (core_target_open): Use push_target overload.
12097
12098 2019-02-15  Tom Tromey  <tromey@adacore.com>
12099
12100         * ravenscar-thread.c (is_ravenscar_task)
12101         (ravenscar_task_is_currently_active): Return bool.
12102         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12103         (_initialize_ravenscar): Remove "(void)".
12104         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12105         Return bool.
12106
12107 2019-02-15  Tom Tromey  <tromey@adacore.com>
12108
12109         * ravenscar-thread.c (ravenscar_runtime_initializer)
12110         (has_ravenscar_runtime, get_running_thread_id)
12111         (ravenscar_thread_target::resume): Fix indentation.
12112
12113 2019-02-15  Tom Tromey  <tromey@adacore.com>
12114
12115         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12116         from ravenscar_arch_ops.
12117         (sparc_ravenscar_ops::fetch_registers)
12118         (sparc_ravenscar_ops::store_registers): Now methods.
12119         (sparc_ravenscar_prepare_to_store): Remove.
12120         (sparc_ravenscar_ops): Redefine.
12121         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12122         methods and destructor.  Remove members.
12123         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12124         (ravenscar_thread_target::store_registers)
12125         (ravenscar_thread_target::prepare_to_store): Update.
12126         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12127         Remove.
12128         (struct ppc_ravenscar_powerpc_ops): Derive from
12129         ravenscar_arch_ops.
12130         (ppc_ravenscar_powerpc_ops::fetch_registers)
12131         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12132         (ppc_ravenscar_powerpc_ops): Redefine.
12133         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12134         (ppc_ravenscar_e500_ops::fetch_registers)
12135         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12136         (ppc_ravenscar_e500_ops): Redefine.
12137         * aarch64-ravenscar-thread.c
12138         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12139         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12140         (aarch64_ravenscar_fetch_registers)
12141         (aarch64_ravenscar_store_registers): Now methods.
12142         (aarch64_ravenscar_ops): Redefine.
12143
12144 2019-02-15  Tom Tromey  <tromey@adacore.com>
12145
12146         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12147         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12148         (ravenscar_thread_target::stopped_by_watchpoint)
12149         (ravenscar_thread_target::stopped_data_address)
12150         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12151
12152 2019-02-15  Tom Tromey  <tromey@adacore.com>
12153
12154         * ravenscar-thread.c: Fix some typos.
12155
12156 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12157             Tom Tromey  <tromey@adacore.com>
12158
12159         * ada-lang.c (ada_exception_sal): Change addr_string to a
12160         std::string.
12161         (create_ada_exception_catchpoint): Update.
12162
12163 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12164             Tom Tromey  <tromey@adacore.com>
12165
12166         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12167         (bp_location_ops): Remove.
12168         (base_breakpoint_allocate_location): Update.
12169         (free_bp_location): Update.
12170         * ada-lang.c (class ada_catchpoint_location)
12171         <ada_catchpoint_location>: Remove ops parameter.
12172         (ada_catchpoint_location_dtor): Remove.
12173         (ada_catchpoint_location_ops): Remove.
12174         (allocate_location_exception): Update.
12175         * breakpoint.h (struct bp_location_ops): Remove.
12176         (class bp_location) <bp_location>: Remove bp_location_ops
12177         parameter.
12178         <~bp_location>: Add destructor.
12179         <ops>: Remove.
12180
12181 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12182             Pedro Alves  <palves@redhat.com>
12183
12184         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12185         'PATH_MAX'.
12186
12187 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12188             Samuel Thibault  <samuel.thibault@gnu.org>
12189             Thomas Schwinge  <thomas@codesourcery.com>
12190
12191         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12192         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12193
12194 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12195
12196         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12197         (check_empty): Use "const char *".
12198
12199         * gnu-nat.c (gnu_nat_target::detach): Instead of
12200         'detach_inferior (pid)' call
12201         'detach_inferior (find_inferior_pid (pid))'.
12202
12203         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12204         'nat/fork-inferior.o'.
12205         * gnu-nat.c: #include "nat/fork-inferior.h".
12206
12207         * gnu-nat.c (gnu_nat_target::detach): Instead of
12208         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12209         * gnu-nat.h: #include "inf-child.h".
12210         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12211         'i386_gnu_nat_target::fetch_registers'.
12212         (gnu_store_registers): Rename/move to
12213         'i386_gnu_nat_target::store_registers'.
12214
12215         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12216         * gnu-nat.h (mach_thread_info): New function.
12217         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12218
12219         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12220
12221 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12222
12223         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12224
12225 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12226
12227         * windows-nat.c (windows_add_thread): Add new parameter
12228         "main_thread_p" with default value set to false.  Update
12229         function documentation as well as all callers.
12230         (windows_delete_thread): Likewise.
12231         (fake_create_process): Update call to windows_add_thread.
12232         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12233         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12234         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12235         call to windows_delete_thread.
12236
12237 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12238
12239         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12240
12241 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12242
12243         * symfile.c (find_separate_debug_file): Use canonical path of
12244         sysroot with child_path instead of gdb_sysroot if it is valid.
12245
12246 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12247
12248         * symfile.c (find_separate_debug_file): Use child_path to
12249         determine if an object file is under a sysroot.
12250
12251 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12252
12253         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12254         unittests/child-path-selftests.c.
12255         * common/pathstuff.c (child_path): New function.
12256         * common/pathstuff.h (child_path): New prototype.
12257         * unittests/child-path-selftests.c: New file.
12258
12259 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12260
12261         * symfile.c (find_separate_debug_file): Look for separate debug
12262         files in debug directories under the sysroot.
12263
12264 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12265
12266         * symtab.h (struct minimal_symbol data_p): New const method.
12267         (struct minimal_symbol text_p): Likewise.
12268         * symtab.c (output_source_filename): Use file name style
12269         to print file name.
12270         (print_symbol_info): Likewise.
12271         (print_msymbol_info): Use address style to print addresses.
12272         Use function name style to print executable text symbols.
12273         (expand_symtab_containing_pc): Use data_p.
12274         (find_pc_sect_compunit_symtab): Likewise.
12275
12276 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12277
12278         * breakpoint.c (describe_other_breakpoints): Use address style
12279         to print addresses.
12280         (say_where): Likewise.
12281
12282 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12283
12284         * ada-typeprint.c (print_func_type): Print function name
12285         style to print function name.
12286         * c-typeprint.c (c_print_type_1): Likewise.
12287
12288 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12289
12290         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12291         for execve.
12292
12293 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12294
12295         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12296         type_stack.
12297
12298 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12299
12300         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12301         TYPE_CODE_REF types.
12302
12303 2019-02-08  Jim Wilson  <jimw@sifive.com>
12304
12305         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12306         (riscv_linux_fregset): New.
12307         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12308
12309 2019-02-07  Tom Tromey  <tom@tromey.com>
12310
12311         * thread.c (thread_cancel_execution_command): Update.
12312         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12313         methods.
12314         (struct thread_fsm_ops): Remove.
12315         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12316         (thread_fsm_should_stop, thread_fsm_return_value)
12317         (thread_fsm_set_finished, thread_fsm_finished_p)
12318         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12319         Don't declare.
12320         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12321         * infrun.c (clear_proceed_status_thread)
12322         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12323         (print_stop_event): Update.
12324         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12325         Add constructor.
12326         (step_command_fsm_ops): Remove.
12327         (new_step_command_fsm): Remove.
12328         (step_1): Update.
12329         (step_command_fsm::should_stop): Rename from
12330         step_command_fsm_should_stop.
12331         (step_command_fsm::clean_up): Rename from
12332         step_command_fsm_clean_up.
12333         (step_command_fsm::do_async_reply_reason): Rename from
12334         step_command_fsm_async_reply_reason.
12335         (struct until_next_fsm): Inherit from thread_fsm.  Add
12336         constructor.
12337         (until_next_fsm_ops): Remove.
12338         (new_until_next_fsm): Remove.
12339         (until_next_fsm::should_stop): Rename from
12340         until_next_fsm_should_stop.
12341         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12342         (until_next_fsm::do_async_reply_reason): Rename from
12343         until_next_fsm_async_reply_reason.
12344         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12345         constructor.  Change type of breakpoint.
12346         (finish_command_fsm_ops): Remove.
12347         (new_finish_command_fsm): Remove.
12348         (finish_command_fsm::should_stop): Rename from
12349         finish_command_fsm_should_stop.
12350         (finish_command_fsm::clean_up): Rename from
12351         finish_command_fsm_clean_up.
12352         (finish_command_fsm::return_value): Rename from
12353         finish_command_fsm_return_value.
12354         (finish_command_fsm::do_async_reply_reason): Rename from
12355         finish_command_fsm_async_reply_reason.
12356         (finish_command): Update.
12357         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12358         Add constructor.
12359         (call_thread_fsm_ops): Remove.
12360         (call_thread_fsm::call_thread_fsm): Rename from
12361         new_call_thread_fsm.
12362         (call_thread_fsm::should_stop): Rename from
12363         call_thread_fsm_should_stop.
12364         (call_thread_fsm::should_notify_stop): Rename from
12365         call_thread_fsm_should_notify_stop.
12366         (run_inferior_call, call_function_by_hand_dummy): Update.
12367         * cli/cli-interp.c (should_print_stop_to_console): Update.
12368         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12369         Add constructor.  Change type of location_breakpoint,
12370         caller_breakpoint.
12371         (until_break_fsm_ops): Remove.
12372         (new_until_break_fsm): Remove.
12373         (until_break_fsm::should_stop): Rename from
12374         until_break_fsm_should_stop.
12375         (until_break_fsm::clean_up): Rename from
12376         until_break_fsm_clean_up.
12377         (until_break_fsm::do_async_reply_reason): Rename from
12378         until_break_fsm_async_reply_reason.
12379         (until_break_command): Update.
12380         * thread-fsm.c: Remove.
12381         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12382
12383 2019-02-07  Tom Tromey  <tom@tromey.com>
12384
12385         * yy-remap.h: Add include guard.
12386         * xtensa-tdep.h: Add include guard.
12387         * xcoffread.h: Rename include guard.
12388         * varobj-iter.h: Add include guard.
12389         * tui/tui.h: Rename include guard.
12390         * tui/tui-winsource.h: Rename include guard.
12391         * tui/tui-wingeneral.h: Rename include guard.
12392         * tui/tui-windata.h: Rename include guard.
12393         * tui/tui-win.h: Rename include guard.
12394         * tui/tui-stack.h: Rename include guard.
12395         * tui/tui-source.h: Rename include guard.
12396         * tui/tui-regs.h: Rename include guard.
12397         * tui/tui-out.h: Rename include guard.
12398         * tui/tui-layout.h: Rename include guard.
12399         * tui/tui-io.h: Rename include guard.
12400         * tui/tui-hooks.h: Rename include guard.
12401         * tui/tui-file.h: Rename include guard.
12402         * tui/tui-disasm.h: Rename include guard.
12403         * tui/tui-data.h: Rename include guard.
12404         * tui/tui-command.h: Rename include guard.
12405         * tic6x-tdep.h: Add include guard.
12406         * target/waitstatus.h: Rename include guard.
12407         * target/wait.h: Rename include guard.
12408         * target/target.h: Rename include guard.
12409         * target/resume.h: Rename include guard.
12410         * target-float.h: Rename include guard.
12411         * stabsread.h: Add include guard.
12412         * rs6000-tdep.h: Add include guard.
12413         * riscv-fbsd-tdep.h: Add include guard.
12414         * regformats/regdef.h: Rename include guard.
12415         * record.h: Rename include guard.
12416         * python/python.h: Rename include guard.
12417         * python/python-internal.h: Rename include guard.
12418         * python/py-stopevent.h: Rename include guard.
12419         * python/py-ref.h: Rename include guard.
12420         * python/py-record.h: Rename include guard.
12421         * python/py-record-full.h: Rename include guard.
12422         * python/py-record-btrace.h: Rename include guard.
12423         * python/py-instruction.h: Rename include guard.
12424         * python/py-events.h: Rename include guard.
12425         * python/py-event.h: Rename include guard.
12426         * procfs.h: Add include guard.
12427         * proc-utils.h: Add include guard.
12428         * p-lang.h: Add include guard.
12429         * or1k-tdep.h: Rename include guard.
12430         * observable.h: Rename include guard.
12431         * nto-tdep.h: Rename include guard.
12432         * nat/x86-linux.h: Rename include guard.
12433         * nat/x86-linux-dregs.h: Rename include guard.
12434         * nat/x86-gcc-cpuid.h: Add include guard.
12435         * nat/x86-dregs.h: Rename include guard.
12436         * nat/x86-cpuid.h: Rename include guard.
12437         * nat/ppc-linux.h: Rename include guard.
12438         * nat/mips-linux-watch.h: Rename include guard.
12439         * nat/linux-waitpid.h: Rename include guard.
12440         * nat/linux-ptrace.h: Rename include guard.
12441         * nat/linux-procfs.h: Rename include guard.
12442         * nat/linux-osdata.h: Rename include guard.
12443         * nat/linux-nat.h: Rename include guard.
12444         * nat/linux-namespaces.h: Rename include guard.
12445         * nat/linux-btrace.h: Rename include guard.
12446         * nat/glibc_thread_db.h: Rename include guard.
12447         * nat/gdb_thread_db.h: Rename include guard.
12448         * nat/gdb_ptrace.h: Rename include guard.
12449         * nat/fork-inferior.h: Rename include guard.
12450         * nat/amd64-linux-siginfo.h: Rename include guard.
12451         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12452         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12453         * nat/aarch64-linux.h: Rename include guard.
12454         * nat/aarch64-linux-hw-point.h: Rename include guard.
12455         * mn10300-tdep.h: Add include guard.
12456         * mips-linux-tdep.h: Add include guard.
12457         * mi/mi-parse.h: Rename include guard.
12458         * mi/mi-out.h: Rename include guard.
12459         * mi/mi-main.h: Rename include guard.
12460         * mi/mi-interp.h: Rename include guard.
12461         * mi/mi-getopt.h: Rename include guard.
12462         * mi/mi-console.h: Rename include guard.
12463         * mi/mi-common.h: Rename include guard.
12464         * mi/mi-cmds.h: Rename include guard.
12465         * mi/mi-cmd-break.h: Rename include guard.
12466         * m2-lang.h: Add include guard.
12467         * location.h: Rename include guard.
12468         * linux-record.h: Rename include guard.
12469         * linux-nat.h: Add include guard.
12470         * linux-fork.h: Add include guard.
12471         * i386-darwin-tdep.h: Rename include guard.
12472         * hppa-linux-offsets.h: Add include guard.
12473         * guile/guile.h: Rename include guard.
12474         * guile/guile-internal.h: Rename include guard.
12475         * gnu-nat.h: Rename include guard.
12476         * gdb-stabs.h: Rename include guard.
12477         * frv-tdep.h: Add include guard.
12478         * f-lang.h: Add include guard.
12479         * event-loop.h: Add include guard.
12480         * darwin-nat.h: Rename include guard.
12481         * cp-abi.h: Rename include guard.
12482         * config/sparc/nm-sol2.h: Rename include guard.
12483         * config/nm-nto.h: Rename include guard.
12484         * config/nm-linux.h: Add include guard.
12485         * config/i386/nm-i386gnu.h: Rename include guard.
12486         * config/djgpp/nl_types.h: Rename include guard.
12487         * config/djgpp/langinfo.h: Rename include guard.
12488         * compile/gcc-cp-plugin.h: Add include guard.
12489         * compile/gcc-c-plugin.h: Add include guard.
12490         * compile/compile.h: Rename include guard.
12491         * compile/compile-object-run.h: Rename include guard.
12492         * compile/compile-object-load.h: Rename include guard.
12493         * compile/compile-internal.h: Rename include guard.
12494         * compile/compile-cplus.h: Rename include guard.
12495         * compile/compile-c.h: Rename include guard.
12496         * common/xml-utils.h: Rename include guard.
12497         * common/x86-xstate.h: Rename include guard.
12498         * common/version.h: Rename include guard.
12499         * common/vec.h: Rename include guard.
12500         * common/tdesc.h: Rename include guard.
12501         * common/selftest.h: Rename include guard.
12502         * common/scoped_restore.h: Rename include guard.
12503         * common/scoped_mmap.h: Rename include guard.
12504         * common/scoped_fd.h: Rename include guard.
12505         * common/safe-iterator.h: Rename include guard.
12506         * common/run-time-clock.h: Rename include guard.
12507         * common/refcounted-object.h: Rename include guard.
12508         * common/queue.h: Rename include guard.
12509         * common/ptid.h: Rename include guard.
12510         * common/print-utils.h: Rename include guard.
12511         * common/preprocessor.h: Rename include guard.
12512         * common/pathstuff.h: Rename include guard.
12513         * common/observable.h: Rename include guard.
12514         * common/netstuff.h: Rename include guard.
12515         * common/job-control.h: Rename include guard.
12516         * common/host-defs.h: Rename include guard.
12517         * common/gdb_wait.h: Rename include guard.
12518         * common/gdb_vecs.h: Rename include guard.
12519         * common/gdb_unlinker.h: Rename include guard.
12520         * common/gdb_unique_ptr.h: Rename include guard.
12521         * common/gdb_tilde_expand.h: Rename include guard.
12522         * common/gdb_sys_time.h: Rename include guard.
12523         * common/gdb_string_view.h: Rename include guard.
12524         * common/gdb_splay_tree.h: Rename include guard.
12525         * common/gdb_setjmp.h: Rename include guard.
12526         * common/gdb_ref_ptr.h: Rename include guard.
12527         * common/gdb_optional.h: Rename include guard.
12528         * common/gdb_locale.h: Rename include guard.
12529         * common/gdb_assert.h: Rename include guard.
12530         * common/filtered-iterator.h: Rename include guard.
12531         * common/filestuff.h: Rename include guard.
12532         * common/fileio.h: Rename include guard.
12533         * common/environ.h: Rename include guard.
12534         * common/common-utils.h: Rename include guard.
12535         * common/common-types.h: Rename include guard.
12536         * common/common-regcache.h: Rename include guard.
12537         * common/common-inferior.h: Rename include guard.
12538         * common/common-gdbthread.h: Rename include guard.
12539         * common/common-exceptions.h: Rename include guard.
12540         * common/common-defs.h: Rename include guard.
12541         * common/common-debug.h: Rename include guard.
12542         * common/cleanups.h: Rename include guard.
12543         * common/buffer.h: Rename include guard.
12544         * common/btrace-common.h: Rename include guard.
12545         * common/break-common.h: Rename include guard.
12546         * cli/cli-utils.h: Rename include guard.
12547         * cli/cli-style.h: Rename include guard.
12548         * cli/cli-setshow.h: Rename include guard.
12549         * cli/cli-script.h: Rename include guard.
12550         * cli/cli-interp.h: Rename include guard.
12551         * cli/cli-decode.h: Rename include guard.
12552         * cli/cli-cmds.h: Rename include guard.
12553         * charset-list.h: Add include guard.
12554         * buildsym-legacy.h: Rename include guard.
12555         * bfin-tdep.h: Add include guard.
12556         * ax.h: Rename include guard.
12557         * arm-linux-tdep.h: Add include guard.
12558         * arm-fbsd-tdep.h: Add include guard.
12559         * arch/xtensa.h: Rename include guard.
12560         * arch/tic6x.h: Add include guard.
12561         * arch/i386.h: Add include guard.
12562         * arch/arm.h: Rename include guard.
12563         * arch/arm-linux.h: Rename include guard.
12564         * arch/arm-get-next-pcs.h: Rename include guard.
12565         * arch/amd64.h: Add include guard.
12566         * arch/aarch64-insn.h: Rename include guard.
12567         * arch-utils.h: Rename include guard.
12568         * annotate.h: Add include guard.
12569         * amd64-darwin-tdep.h: Rename include guard.
12570         * aarch64-linux-tdep.h: Add include guard.
12571         * aarch64-fbsd-tdep.h: Add include guard.
12572         * aarch32-linux-nat.h: Add include guard.
12573
12574 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12575
12576         * macrotab.c (macro_define_internal): New function that
12577         factorizes macro_define_object_internal and macro_define_function
12578         code.
12579         (macro_define_object_internal): Use macro_define_internal.
12580         (macro_define_function): Likewise.
12581
12582 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12583
12584         * macrocmd.c (extract_identifier): Return
12585         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12586         callers.
12587
12588 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12589
12590         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12591
12592 2019-02-05  Tom Tromey  <tom@tromey.com>
12593
12594         * target.c (target_stack::unpush): Move assertion earlier.
12595
12596 2019-01-30  Tom Tromey  <tom@tromey.com>
12597
12598         PR python/23615:
12599         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12600         (gdbpy_parse_and_eval): Likewise.
12601         * python/python-internal.h (gdbpy_allow_threads): New class.
12602
12603 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12604
12605         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12606         (aarch64_fbsd_fpregmap): Move earlier.
12607         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12608         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12609         instead of individual calls to trad_frame_set_reg_addr.
12610         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12611         earlier.
12612         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12613         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12614         instead of individual calls to trad_frame_set_reg_addr.
12615
12616 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12617
12618         * CONTRIBUTE: Replace contribution list with wiki link.
12619
12620 2019-01-25  Tom Tromey  <tom@tromey.com>
12621
12622         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12623
12624 2019-01-25  Tom Tromey  <tom@tromey.com>
12625
12626         * xtensa-linux-nat.c: Fix common/ includes.
12627         * xml-support.h: Fix common/ includes.
12628         * xml-support.c: Fix common/ includes.
12629         * x86-linux-nat.c: Fix common/ includes.
12630         * windows-nat.c: Fix common/ includes.
12631         * varobj.h: Fix common/ includes.
12632         * varobj.c: Fix common/ includes.
12633         * value.c: Fix common/ includes.
12634         * valops.c: Fix common/ includes.
12635         * utils.c: Fix common/ includes.
12636         * unittests/xml-utils-selftests.c: Fix common/ includes.
12637         * unittests/utils-selftests.c: Fix common/ includes.
12638         * unittests/unpack-selftests.c: Fix common/ includes.
12639         * unittests/tracepoint-selftests.c: Fix common/ includes.
12640         * unittests/style-selftests.c: Fix common/ includes.
12641         * unittests/string_view-selftests.c: Fix common/ includes.
12642         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12643         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12644         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12645         * unittests/rsp-low-selftests.c: Fix common/ includes.
12646         * unittests/parse-connection-spec-selftests.c: Fix common/
12647         includes.
12648         * unittests/optional-selftests.c: Fix common/ includes.
12649         * unittests/offset-type-selftests.c: Fix common/ includes.
12650         * unittests/observable-selftests.c: Fix common/ includes.
12651         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12652         * unittests/memrange-selftests.c: Fix common/ includes.
12653         * unittests/memory-map-selftests.c: Fix common/ includes.
12654         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12655         * unittests/function-view-selftests.c: Fix common/ includes.
12656         * unittests/environ-selftests.c: Fix common/ includes.
12657         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12658         * unittests/common-utils-selftests.c: Fix common/ includes.
12659         * unittests/cli-utils-selftests.c: Fix common/ includes.
12660         * unittests/array-view-selftests.c: Fix common/ includes.
12661         * ui-file.c: Fix common/ includes.
12662         * tui/tui-io.c: Fix common/ includes.
12663         * tracepoint.h: Fix common/ includes.
12664         * tracepoint.c: Fix common/ includes.
12665         * tracefile-tfile.c: Fix common/ includes.
12666         * top.h: Fix common/ includes.
12667         * top.c: Fix common/ includes.
12668         * thread.c: Fix common/ includes.
12669         * target/waitstatus.h: Fix common/ includes.
12670         * target/waitstatus.c: Fix common/ includes.
12671         * target.h: Fix common/ includes.
12672         * target.c: Fix common/ includes.
12673         * target-memory.c: Fix common/ includes.
12674         * target-descriptions.c: Fix common/ includes.
12675         * symtab.h: Fix common/ includes.
12676         * symfile.c: Fix common/ includes.
12677         * stap-probe.c: Fix common/ includes.
12678         * spu-linux-nat.c: Fix common/ includes.
12679         * sparc-nat.c: Fix common/ includes.
12680         * source.c: Fix common/ includes.
12681         * solib.c: Fix common/ includes.
12682         * solib-target.c: Fix common/ includes.
12683         * ser-unix.c: Fix common/ includes.
12684         * ser-tcp.c: Fix common/ includes.
12685         * ser-pipe.c: Fix common/ includes.
12686         * ser-base.c: Fix common/ includes.
12687         * selftest-arch.c: Fix common/ includes.
12688         * s12z-tdep.c: Fix common/ includes.
12689         * rust-exp.y: Fix common/ includes.
12690         * rs6000-aix-tdep.c: Fix common/ includes.
12691         * riscv-tdep.c: Fix common/ includes.
12692         * remote.c: Fix common/ includes.
12693         * remote-notif.h: Fix common/ includes.
12694         * remote-fileio.h: Fix common/ includes.
12695         * remote-fileio.c: Fix common/ includes.
12696         * regcache.h: Fix common/ includes.
12697         * regcache.c: Fix common/ includes.
12698         * record-btrace.c: Fix common/ includes.
12699         * python/python.c: Fix common/ includes.
12700         * python/py-type.c: Fix common/ includes.
12701         * python/py-inferior.c: Fix common/ includes.
12702         * progspace.h: Fix common/ includes.
12703         * producer.c: Fix common/ includes.
12704         * procfs.c: Fix common/ includes.
12705         * proc-api.c: Fix common/ includes.
12706         * printcmd.c: Fix common/ includes.
12707         * ppc-linux-nat.c: Fix common/ includes.
12708         * parser-defs.h: Fix common/ includes.
12709         * osdata.c: Fix common/ includes.
12710         * obsd-nat.c: Fix common/ includes.
12711         * nat/x86-linux.c: Fix common/ includes.
12712         * nat/x86-linux-dregs.c: Fix common/ includes.
12713         * nat/x86-dregs.h: Fix common/ includes.
12714         * nat/x86-dregs.c: Fix common/ includes.
12715         * nat/ppc-linux.c: Fix common/ includes.
12716         * nat/mips-linux-watch.h: Fix common/ includes.
12717         * nat/mips-linux-watch.c: Fix common/ includes.
12718         * nat/linux-waitpid.c: Fix common/ includes.
12719         * nat/linux-ptrace.h: Fix common/ includes.
12720         * nat/linux-ptrace.c: Fix common/ includes.
12721         * nat/linux-procfs.c: Fix common/ includes.
12722         * nat/linux-personality.c: Fix common/ includes.
12723         * nat/linux-osdata.c: Fix common/ includes.
12724         * nat/linux-namespaces.c: Fix common/ includes.
12725         * nat/linux-btrace.h: Fix common/ includes.
12726         * nat/linux-btrace.c: Fix common/ includes.
12727         * nat/fork-inferior.c: Fix common/ includes.
12728         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12729         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12730         * nat/aarch64-linux.c: Fix common/ includes.
12731         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12732         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12733         * namespace.h: Fix common/ includes.
12734         * mips-linux-tdep.c: Fix common/ includes.
12735         * minsyms.c: Fix common/ includes.
12736         * mi/mi-parse.h: Fix common/ includes.
12737         * mi/mi-main.c: Fix common/ includes.
12738         * mi/mi-cmd-env.c: Fix common/ includes.
12739         * memrange.h: Fix common/ includes.
12740         * memattr.c: Fix common/ includes.
12741         * maint.h: Fix common/ includes.
12742         * maint.c: Fix common/ includes.
12743         * main.c: Fix common/ includes.
12744         * machoread.c: Fix common/ includes.
12745         * location.c: Fix common/ includes.
12746         * linux-thread-db.c: Fix common/ includes.
12747         * linux-nat.c: Fix common/ includes.
12748         * linux-fork.c: Fix common/ includes.
12749         * inline-frame.c: Fix common/ includes.
12750         * infrun.c: Fix common/ includes.
12751         * inflow.c: Fix common/ includes.
12752         * inferior.h: Fix common/ includes.
12753         * inferior.c: Fix common/ includes.
12754         * infcmd.c: Fix common/ includes.
12755         * inf-ptrace.c: Fix common/ includes.
12756         * inf-child.c: Fix common/ includes.
12757         * ia64-linux-nat.c: Fix common/ includes.
12758         * i387-tdep.c: Fix common/ includes.
12759         * i386-tdep.c: Fix common/ includes.
12760         * i386-linux-tdep.c: Fix common/ includes.
12761         * i386-linux-nat.c: Fix common/ includes.
12762         * i386-go32-tdep.c: Fix common/ includes.
12763         * i386-fbsd-tdep.c: Fix common/ includes.
12764         * i386-fbsd-nat.c: Fix common/ includes.
12765         * guile/scm-type.c: Fix common/ includes.
12766         * guile/guile.c: Fix common/ includes.
12767         * go32-nat.c: Fix common/ includes.
12768         * gnu-nat.c: Fix common/ includes.
12769         * gdbthread.h: Fix common/ includes.
12770         * gdbarch-selftests.c: Fix common/ includes.
12771         * gdb_usleep.c: Fix common/ includes.
12772         * gdb_select.h: Fix common/ includes.
12773         * gdb_bfd.c: Fix common/ includes.
12774         * gcore.c: Fix common/ includes.
12775         * fork-child.c: Fix common/ includes.
12776         * findvar.c: Fix common/ includes.
12777         * fbsd-nat.c: Fix common/ includes.
12778         * event-top.c: Fix common/ includes.
12779         * event-loop.c: Fix common/ includes.
12780         * dwarf2read.c: Fix common/ includes.
12781         * dwarf2loc.c: Fix common/ includes.
12782         * dwarf2-frame.c: Fix common/ includes.
12783         * dwarf-index-cache.c: Fix common/ includes.
12784         * dtrace-probe.c: Fix common/ includes.
12785         * disasm-selftests.c: Fix common/ includes.
12786         * defs.h: Fix common/ includes.
12787         * csky-tdep.c: Fix common/ includes.
12788         * cp-valprint.c: Fix common/ includes.
12789         * cp-support.h: Fix common/ includes.
12790         * cp-support.c: Fix common/ includes.
12791         * corelow.c: Fix common/ includes.
12792         * completer.h: Fix common/ includes.
12793         * completer.c: Fix common/ includes.
12794         * compile/compile.c: Fix common/ includes.
12795         * compile/compile-loc2c.c: Fix common/ includes.
12796         * compile/compile-cplus-types.c: Fix common/ includes.
12797         * compile/compile-cplus-symbols.c: Fix common/ includes.
12798         * command.h: Fix common/ includes.
12799         * cli/cli-dump.c: Fix common/ includes.
12800         * cli/cli-cmds.c: Fix common/ includes.
12801         * charset.c: Fix common/ includes.
12802         * build-id.c: Fix common/ includes.
12803         * btrace.h: Fix common/ includes.
12804         * btrace.c: Fix common/ includes.
12805         * breakpoint.h: Fix common/ includes.
12806         * breakpoint.c: Fix common/ includes.
12807         * ax.h:
12808         (enum agent_op): Fix common/ includes.
12809         * ax-general.c (struct aop_map): Fix common/ includes.
12810         * ax-gdb.c: Fix common/ includes.
12811         * auxv.c: Fix common/ includes.
12812         * auto-load.c: Fix common/ includes.
12813         * arm-tdep.c: Fix common/ includes.
12814         * arch/riscv.c: Fix common/ includes.
12815         * arch/ppc-linux-common.c: Fix common/ includes.
12816         * arch/i386.c: Fix common/ includes.
12817         * arch/arm.c: Fix common/ includes.
12818         * arch/arm-linux.c: Fix common/ includes.
12819         * arch/arm-get-next-pcs.c: Fix common/ includes.
12820         * arch/amd64.c: Fix common/ includes.
12821         * arch/aarch64.c: Fix common/ includes.
12822         * arch/aarch64-insn.c: Fix common/ includes.
12823         * arch-utils.c: Fix common/ includes.
12824         * amd64-windows-tdep.c: Fix common/ includes.
12825         * amd64-tdep.c: Fix common/ includes.
12826         * amd64-sol2-tdep.c: Fix common/ includes.
12827         * amd64-obsd-tdep.c: Fix common/ includes.
12828         * amd64-nbsd-tdep.c: Fix common/ includes.
12829         * amd64-linux-tdep.c: Fix common/ includes.
12830         * amd64-linux-nat.c: Fix common/ includes.
12831         * amd64-fbsd-tdep.c: Fix common/ includes.
12832         * amd64-fbsd-nat.c: Fix common/ includes.
12833         * amd64-dicos-tdep.c: Fix common/ includes.
12834         * amd64-darwin-tdep.c: Fix common/ includes.
12835         * agent.c: Fix common/ includes.
12836         * ada-lang.h: Fix common/ includes.
12837         * ada-lang.c: Fix common/ includes.
12838         * aarch64-tdep.c: Fix common/ includes.
12839
12840 2019-01-25  Tom Tromey  <tom@tromey.com>
12841
12842         * common/create-version.sh: Use common/version.h.
12843
12844 2019-01-24  Pedro Alves  <palves@redhat.com>
12845
12846         * infrun.c (signal_stop, signal_print, signal_program)
12847         (signal_catch, signal_pass): Now arrays instead of pointers.
12848         (update_signals_program_target, do_target_resume)
12849         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12850         * linux-nat.c (linux_nat_target::pass_signals)
12851         (linux_nat_target::create_inferior, linux_nat_target::attach):
12852         Adjust.
12853         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12854         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12855         * procfs.c (procfs_target::pass_signals): Adjust.
12856         * record-full.c (record_full_target::resume): Adjust.
12857         * remote.c (remote_target::pass_signals)
12858         (remote_target::program_signals): Adjust.
12859         * target-debug.h (target_debug_print_signals): Now takes a
12860         gdb::array_view as parameter.  Adjust.
12861         * target.h (target_ops) <pass_signals, program_signals>: Replace
12862         pointer and length parameters with gdb::array_view.
12863         (target_pass_signals, target_program_signals): Likewise.
12864         * target-delegates.c: Regenerate.
12865
12866 2019-01-24  Pedro Alves  <palves@redhat.com>
12867
12868         * common/forward-scope-exit.h
12869         (forward_scope_exit::forward_scope_exit): Pass arguments to
12870         m_bind_function directly, instead of creating a std::bind and
12871         copying that.
12872
12873 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12874
12875         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12876         for static members.
12877         (pass_in_v_vfp_candidate): Likewise.
12878
12879 2019-01-23  Tom Tromey  <tom@tromey.com>
12880             Pedro Alves  <palves@redhat.com>
12881
12882         * regcache.c (class regcache_invalidator): Remove.
12883         (regcache::raw_write): Use make_scope_exit.
12884
12885 2019-01-23  Tom Tromey  <tom@tromey.com>
12886
12887         * ui-out.h (class ui_out_emit_type): Update comment.
12888
12889 2019-01-23  Tom Tromey  <tom@tromey.com>
12890
12891         * infrun.c (fetch_inferior_event): Update comment.
12892
12893 2019-01-23  Tom Tromey  <tom@tromey.com>
12894             Pedro Alves  <palves@redhat.com>
12895
12896         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12897         parameter.
12898         (fetch_inferior_event): Use SCOPE_EXIT.
12899
12900
12901 2019-01-23  Tom Tromey  <tom@tromey.com>
12902             Pedro Alves  <palves@redhat.com>
12903
12904         * infrun.c (disable_thread_events): Delete.
12905         (stop_all_threads): Use SCOPE_EXIT.
12906
12907 2019-01-23  Tom Tromey  <tom@tromey.com>
12908             Pedro Alves  <palves@redhat.com>
12909
12910         * symfile.c: Include forward-scope-exit.h.
12911         (clear_symtab_users_cleanup): Replace forward declaration with
12912         a FORWARD_SCOPE_EXIT.
12913         (syms_from_objfile_1): Use the forward_scope_exit and
12914         gdb::optional instead of cleanup_function.
12915         (reread_symbols): Use the forward_scope_exit instead of
12916         cleanup_function.
12917         (clear_symtab_users_cleanup): Remove function.
12918
12919 2019-01-23  Tom Tromey  <tom@tromey.com>
12920             Pedro Alves  <palves@redhat.com>
12921
12922         * linux-nat.c: Include scope-exit.h.
12923         (cleanup_target_stop): Remove.
12924         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12925         SCOPE_EXIT.
12926
12927 2019-01-23  Tom Tromey  <tom@tromey.com>
12928             Pedro Alves  <palves@redhat.com>
12929
12930         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12931         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12932
12933 2019-01-23  Tom Tromey  <tom@tromey.com>
12934             Andrew Burgess  <andrew.burgess@embecosm.com>
12935             Pedro Alves  <palves@redhat.com>
12936
12937         * infrun.c (fetch_inferior_event): Use scope_exit.
12938         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12939         * top.c (execute_command): Use scope_exit.
12940         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12941         * utils.c (do_bpstat_clear_actions_cleanup)
12942         (make_bpstat_clear_actions_cleanup): Remove.
12943
12944 2019-01-23  Tom Tromey  <tom@tromey.com>
12945             Pedro Alves  <palves@redhat.com>
12946
12947         * infrun.c: Include "common/scope-exit.h"
12948         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12949         (wait_for_inferior): Use SCOPE_EXIT.
12950         (fetch_inferior_event): Use scope_exit.
12951
12952 2019-01-23  Tom Tromey  <tom@tromey.com>
12953             Pedro Alves  <palves@redhat.com>
12954
12955         * breakpoint.c (create_breakpoint): Remove cleanup.
12956
12957 2019-01-23  Tom Tromey  <tom@tromey.com>
12958             Andrew Burgess  <andrew.burgess@embecosm.com>
12959             Pedro Alves  <palves@redhat.com>
12960
12961 2019-01-23  Pedro Alves  <palves@redhat.com>
12962
12963         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12964
12965 2019-01-23  Pedro Alves  <palves@redhat.com>
12966             Andrew Burgess  <andrew.burgess@embecosm.com>
12967
12968         * gdbthread.h: Include "common/forward-scope-exit.h".
12969         (scoped_finish_thread_state): Redefine custom class in terms of
12970         forward_scope_exit.
12971
12972 2019-01-23  Pedro Alves  <palves@redhat.com>
12973             Andrew Burgess  <andrew.burgess@embecosm.com>
12974
12975         * common/forward-scope-exit.h: New file.
12976
12977 2019-01-23  Pedro Alves  <palves@redhat.com>
12978             Andrew Burgess  <andrew.burgess@embecosm.com>
12979             Tom Tromey  <tom@tromey.com>
12980
12981         * common/scope-exit.h: New file.
12982
12983 2019-01-23  Pedro Alves  <palves@redhat.com>
12984
12985         * common/preprocessor.h (ESC): Rename to ...
12986         (ESC_PARENS): ... this.
12987         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12988         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12989
12990 2019-01-23  Tom Tromey  <tom@tromey.com>
12991
12992         * language.h (class scoped_switch_to_sym_language_if_auto):
12993         Initialize m_lang in both cases.
12994
12995 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12996
12997         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12998         with XCNEW.
12999
13000 2019-01-22  Tom Tromey  <tom@tromey.com>
13001
13002         * corelow.c: Do not include sys/file.h.
13003
13004 2019-01-22  Tom Tromey  <tom@tromey.com>
13005
13006         * tui/tui-wingeneral.h: Include gdb_curses.h.
13007
13008 2019-01-22  Tom Tromey  <tom@tromey.com>
13009
13010         * source-cache.h (class source_cache) <get_source_lines,
13011         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13012
13013 2019-01-22  Tom Tromey  <tom@tromey.com>
13014
13015         * remote-fileio.h (struct remote_target): Declare.
13016
13017 2019-01-22  Tom Tromey  <tom@tromey.com>
13018
13019         * python/py-arch.c: Do not include py-ref.h.
13020         * python/py-bpevent.c: Do not include py-ref.h.
13021         * python/py-cmd.c: Do not include py-ref.h.
13022         * python/py-continueevent.c: Do not include py-ref.h.
13023         * python/py-event.h: Do not include py-ref.h.
13024         * python/py-evtregistry.c: Do not include py-ref.h.
13025         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13026         * python/py-frame.c: Do not include py-ref.h.
13027         * python/py-framefilter.c: Do not include py-ref.h.
13028         * python/py-function.c: Do not include py-ref.h.
13029         * python/py-infevents.c: Do not include py-ref.h.
13030         * python/py-linetable.c: Do not include py-ref.h.
13031         * python/py-objfile.c: Do not include py-ref.h.
13032         * python/py-param.c: Do not include py-ref.h.
13033         * python/py-prettyprint.c: Do not include py-ref.h.
13034         * python/py-progspace.c: Do not include py-ref.h.
13035         * python/py-symbol.c: Do not include py-ref.h.
13036         * python/py-symtab.c: Do not include py-ref.h.
13037         * python/py-type.c: Do not include py-ref.h.
13038         * python/py-unwind.c: Do not include py-ref.h.
13039         * python/py-utils.c: Do not include py-ref.h.
13040         * python/py-value.c: Do not include py-ref.h.
13041         * python/py-varobj.c: Do not include py-ref.h.
13042         * python/py-xmethods.c: Do not include py-ref.h.
13043         * python/python.c: Do not include py-ref.h.
13044         * varobj.c: Do not include py-ref.h.
13045
13046 2019-01-22  Tom Tromey  <tom@tromey.com>
13047
13048         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13049         keyword for bcache.
13050
13051 2019-01-22  Tom Tromey  <tom@tromey.com>
13052
13053         * compile/compile-cplus-types.c: Remove a comment by #include.
13054
13055 2019-01-22  Tom Tromey  <tom@tromey.com>
13056
13057         * compile/gcc-c-plugin.h: Include compile-internal.h.
13058
13059 2019-01-22  Tom Tromey  <tom@tromey.com>
13060
13061         * stabsread.c (EXTERN): Do not define.
13062         (symnum, next_symbol_text_func, processing_gcc_compilation)
13063         (within_function, global_sym_chain, global_stabs)
13064         (previous_stab_code, this_object_header_files)
13065         (n_this_object_header_files)
13066         (n_allocated_this_object_header_files): Define.
13067         * stabsread.h (EXTERN): Never define.  Use "extern".
13068
13069 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13070
13071         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13072         history_value.
13073
13074 2019-01-21  Tom Tromey  <tom@tromey.com>
13075
13076         * ui-out.c: Fix includes.
13077         * tui/tui-source.c: Fix includes.
13078         * target.c: Fix includes.
13079         * remote.c: Fix includes.
13080         * regcache.c: Fix includes.
13081         * python/py-block.c: Fix includes.
13082         * printcmd.c: Fix includes.
13083         * or1k-tdep.c: Fix includes.
13084         * mi/mi-main.c: Fix includes.
13085         * m32r-tdep.c: Fix includes.
13086         * csky-tdep.c: Fix includes.
13087         * compile/compile-cplus-types.c: Fix includes.
13088         * cli/cli-interp.c: Fix includes.
13089
13090 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13091
13092         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13093         for padding.
13094
13095 2019-01-16  Tom Tromey  <tom@tromey.com>
13096
13097         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13098         earlier.
13099         (struct objfile) <msymbols_range>: Move from top level.
13100         <msymbols>: New method.
13101         (class objfile_msymbols): Remove.
13102         * symtab.c (default_collect_symbol_completion_matches_break_on):
13103         Update.
13104         * symmisc.c (dump_msymbols): Update.
13105         * stabsread.c (scan_file_globals): Update.
13106         * objc-lang.c (info_selectors_command, info_classes_command)
13107         (find_methods): Update.
13108         * minsyms.c (find_solib_trampoline_target): Update.
13109         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13110         * coffread.c (coff_symfile_read): Update.
13111         * ada-lang.c (ada_lookup_simple_minsym)
13112         (ada_collect_symbol_completion_matches): Update.
13113
13114 2019-01-16  Tom Tromey  <tom@tromey.com>
13115
13116         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13117         type.  Remove no-argument constructor.
13118         <iterator::operator++>: Simplify.
13119         <begin>: Update.
13120         <end>: Use minimal_symbol_count.
13121
13122 2019-01-16  Tom Tromey  <tom@tromey.com>
13123
13124         * objfiles.h (struct objfile) <psymtabs>: New method.
13125         (class objfile_psymtabs): Remove.
13126         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13127         typedef.
13128         <range>: New method.
13129         (require_partial_symbols): Change return type.
13130         * psymtab.c (require_partial_symbols)
13131         (psym_expand_symtabs_matching): Update.
13132         * mdebugread.c (parse_partial_symbols): Update.
13133         * dbxread.c (dbx_end_psymtab): Update.
13134
13135 2019-01-15  Tom Tromey  <tom@tromey.com>
13136
13137         * symtab.c (lookup_objfile_from_block)
13138         (lookup_symbol_in_objfile_symtabs)
13139         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13140         (find_line_symtab, info_sources_command)
13141         (default_collect_symbol_completion_matches_break_on)
13142         (make_source_files_completion_list): Update.
13143         * symmisc.c (print_objfile_statistics, dump_objfile)
13144         (maintenance_print_symbols, maintenance_info_symtabs)
13145         (maintenance_check_symtabs, maintenance_info_line_tables):
13146         Update.
13147         * source.c (select_source_symtab)
13148         (forget_cached_source_info_for_objfile): Update.
13149         * objfiles.h (class objfile_compunits): Remove.
13150         (struct objfile) <compunits_range>: New typedef.
13151         (compunits): New method.
13152         * objfiles.c (objfile_relocate1): Update.
13153         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13154         * maint.c (count_symtabs_and_blocks): Update.
13155         * linespec.c (iterate_over_all_matching_symtabs): Update.
13156         * cp-support.c (add_symbol_overload_list_qualified): Update.
13157         * coffread.c (coff_symtab_read): Update.
13158         * ada-lang.c (add_nonlocal_symbols)
13159         (ada_collect_symbol_completion_matches)
13160         (ada_add_global_exceptions): Update.
13161
13162 2019-01-15  Tom Tromey  <tom@tromey.com>
13163
13164         * progspace.h (program_space) <objfiles_safe_range>: New
13165         typedef.
13166         <objfiles_safe>: New method.
13167         * objfiles.h (class all_objfiles_safe): Remove.
13168         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13169         * jit.c (jit_inferior_exit_hook): Update.
13170
13171 2019-01-17  Tom Tromey  <tom@tromey.com>
13172
13173         * progspace.h (program_space) <objfiles_range>: New typedef.
13174         <objfiles>: New method.
13175         <objfiles_head>: Rename from objfiles.
13176         (object_files): Update.
13177         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13178         * guile/scm-pretty-print.c
13179         (ppscm_find_pretty_printer_from_objfiles): Update.
13180         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13181         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13182         Update.
13183         * python/py-progspace.c (pspy_get_objfiles): Update.
13184         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13185         Update.
13186         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13187         (objfpy_lookup_objfile_by_build_id): Update.
13188         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13189         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13190         Update.
13191         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13192         (expand_symtab_containing_pc, lookup_objfile_from_block)
13193         (lookup_static_symbol, basic_lookup_transparent_type)
13194         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13195         (find_line_symtab, info_sources_command)
13196         (default_collect_symbol_completion_matches_break_on)
13197         (make_source_files_completion_list, find_main_name): Update.
13198         * symmisc.c (print_symbol_bcache_statistics)
13199         (print_objfile_statistics, maintenance_print_symbols)
13200         (maintenance_print_msymbols, maintenance_print_objfiles)
13201         (maintenance_info_symtabs, maintenance_check_symtabs)
13202         (maintenance_expand_symtabs, maintenance_info_line_tables):
13203         Update.
13204         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13205         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13206         (map_overlay_command, unmap_overlay_command)
13207         (simple_overlay_update, expand_symtabs_matching)
13208         (map_symbol_filenames): Update.
13209         * symfile-debug.c (set_debug_symfile): Update.
13210         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13211         Update.
13212         * source.c (select_source_symtab, forget_cached_source_info):
13213         Update.
13214         * solib.c (solib_read_symbols): Update.
13215         * solib-spu.c (append_ocl_sos): Update.
13216         * psymtab.c (maintenance_print_psymbols)
13217         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13218         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13219         * printcmd.c (info_symbol_command): Update.
13220         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13221         Update.
13222         * objfiles.h (class all_objfiles): Remove.
13223         * objfiles.c (have_partial_symbols, have_full_symbols)
13224         (have_minimal_symbols, qsort_cmp, update_section_map)
13225         (shared_objfile_contains_address_p)
13226         (default_iterate_over_objfiles_in_search_order): Update.
13227         * objc-lang.c (info_selectors_command, info_classes_command)
13228         (find_methods): Update.
13229         * minsyms.c (find_solib_trampoline_target): Update.
13230         * maint.c (maintenance_info_sections)
13231         (maintenance_translate_address, count_symtabs_and_blocks):
13232         Update.
13233         * main.c (captured_main_1): Update.
13234         * linux-thread-db.c (try_thread_db_load_from_pdir)
13235         (has_libpthread): Update.
13236         * linespec.c (iterate_over_all_matching_symtabs)
13237         (search_minsyms_for_name): Update.
13238         * jit.c (jit_find_objf_with_entry_addr): Update.
13239         * hppa-tdep.c (find_unwind_entry)
13240         (hppa_lookup_stub_minimal_symbol): Update.
13241         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13242         Update.
13243         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13244         (elf_gnu_ifunc_resolve_by_got): Update.
13245         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13246         * dwarf-index-write.c (save_gdb_index_command): Update.
13247         * cp-support.c (add_symbol_overload_list_qualified): Update.
13248         * breakpoint.c (create_overlay_event_breakpoint)
13249         (create_longjmp_master_breakpoint)
13250         (create_std_terminate_master_breakpoint)
13251         (create_exception_master_breakpoint): Update.
13252         * blockframe.c (find_pc_partial_function): Update.
13253         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13254         (ada_collect_symbol_completion_matches)
13255         (ada_add_global_exceptions): Update.
13256
13257 2019-01-17  Tom Tromey  <tom@tromey.com>
13258
13259         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13260         declare VEC.
13261         (solib_target_parse_libraries): Change return type.
13262         (library_list_start_segment, library_list_start_section)
13263         (library_list_end_library, library_list_start_library); Update.
13264         (solib_target_free_library_list): Remove.
13265         (solib_target_parse_libraries): Remove cleanup.  Change return
13266         type.
13267         (solib_target_current_sos): Update.
13268
13269 2019-01-17  Tom Tromey  <tromey@bapiya>
13270
13271         * valprint.c: Replace "the the" with "the".
13272         * symtab.c: Replace "the the" with "the".
13273         * solib.c: Replace "the the" with "the".
13274         * solib-dsbt.c: Replace "the the" with "the".
13275         * linespec.c: Replace "the the" with "the".
13276         * dwarf2loc.h: Replace "the the" with "the".
13277         * amd64-windows-tdep.c: Replace "the the" with "the".
13278         * aarch64-tdep.c: Replace "the the" with "the".
13279
13280 2019-01-16  Keith Seitz  <keiths@redhat.com>
13281
13282         PR gdb/23773
13283         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13284         <builder>: Rename to ..
13285         <m_builder>: ... this and make private.
13286         (dwarf2_cu::get_builder): New method.  Change all users of
13287         `builder' to use this method.
13288         (dwarf2_start_symtab): Move to ...
13289         (dwarf2_cu::start_symtab): ... here.  Update all callers
13290         (setup_type_unit_groups): Move to ...
13291         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13292         callers.
13293         (dwarf2_cu::reset_builder): New method.
13294         (process_full_compunit, process_full_type_unit): Use
13295         dwarf2_cu::reset_builder.
13296         (follow_die_offset): Record the ancestor CU if it is different
13297         from the followed DIE's CU.
13298         (follow_die_sig_1): Likewise.
13299
13300 2019-01-15  Tom Tromey  <tom@tromey.com>
13301
13302         * remote.c (class remote_state) <buf>: Now a char_vector.
13303         <buf_size>: Remove.
13304         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13305         parameter.
13306         (remote_target::getpkt_or_notif_sane_1)
13307         (remote_target::getpkt_sane)
13308         (remote_target::getpkt_or_notif_sane): Likewise.
13309         (class remote_target) <putpkt>: New overload.
13310         (remote_target::read_frame): Change type of "buf_p".  Remove
13311         sizeof_p parameter.
13312         (packet_ok): New overload.
13313         (packet_check_result): New overload.
13314         Update all uses.
13315
13316 2019-01-14  Tom Tromey  <tom@tromey.com>
13317
13318         * remote-notif.c (handle_notification, remote_notif_ack)
13319         (remote_notif_parse): Make "buf" const.
13320         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13321         const.
13322         (remote_notif_parse, remote_notif_ack, handle_notification):
13323         Likewise.
13324         * remote.c (remote_notif_stop_parse): Make "buf" const.
13325         (remote_target::remote_parse_stop_reply): Make "buf" const.
13326         (remote_notif_stop_ack): Make "buf" const.
13327
13328 2019-01-14  Tom Tromey  <tom@tromey.com>
13329
13330         * remote.c (remote_console_output): Make parameter const.
13331
13332 2019-01-14  Tom Tromey  <tom@tromey.com>
13333
13334         * target-debug.h (target_debug_print_signals): Constify.
13335         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13336         * procfs.c (procfs_target::pass_signals): Update.
13337         * linux-nat.c (linux_nat_target::pass_signals): Update.
13338         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13339         * target-delegates.c: Rebuild.
13340         * remote.c (remote_target::program_signals): Update.
13341         (remote_target::pass_signals): Update.
13342         * target.c (target_pass_signals): Constify argument.
13343         (target_program_signals): Likewise.
13344         * target.h (struct target_ops) <pass_signals, program_signals>:
13345         Constify argument.
13346         (target_pass_signals, target_program_signals): Constify argument.
13347
13348 2019-01-14  Tom Tromey  <tom@tromey.com>
13349
13350         PR tui/28819:
13351         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13352
13353 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13354
13355         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13356         field.
13357         * rs6000-tdep.c: Include reggroups.h.
13358         (IS_V_ALIAS_PSEUDOREG): Define.
13359         (rs6000_register_name): Return names for the "vX" aliases.
13360         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13361         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13362         aliases.  Call default_register_reggroup_p for all other
13363         pseudo-registers.
13364         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13365         New functions.
13366         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13367         Handle "vX" aliases.
13368         (v_alias_pseudo_register_collect): New function.
13369         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13370         (rs6000_gdbarch_init): Initialize "vX" aliases as
13371         pseudo-registers.  Restore registration of
13372         rs6000_pseudo_register_reggroup_p with
13373         set_tdesc_pseudo_register_reggroup_p.
13374
13375 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13376
13377         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13378         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13379         set_gdbarch_num_pseudo_regs.
13380
13381 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13382
13383         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13384         Remove arg prefixname, add do_set and do_show.
13385         Add member functions set_list and show_list.
13386         * cli/cli-style.c (class cli_style_option): Update accordingly.
13387         (style_set_list): Move to file scope.
13388         (style_show_list): Likewise.
13389         (set_style): Call help_list.
13390         (show_style): Call cmd_show_list.
13391         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13392         Update to use the new macro.
13393
13394 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13395
13396         * ada-lang.c (_initialize_ada_language): Expand the help text
13397         for the "catch exception" command.
13398
13399 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13400
13401         * symtab.c (matching_obj_sections): Initialize obj,
13402         declare it closer to its usage.
13403
13404 2019-01-10  Tom Tromey  <tom@tromey.com>
13405
13406         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13407         (basic_inf_threads_range): Remove.
13408         (inf_threads_range, inf_non_exited_threads_range)
13409         (safe_inf_threads_range): Use next_adapter.
13410
13411 2019-01-10  Keith Seitz  <keiths@redhat.com>
13412
13413         PR gdb/23712
13414         PR symtab/23010
13415         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13416         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13417
13418 2019-01-10  Keith Seitz  <keiths@redhat.com>
13419
13420         PR gdb/23712
13421         PR symtab/23010
13422         * dictionary.c (pending_to_vector): Remove.
13423         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13424         Remove _1 suffix, replacing functions of the same name.  Update
13425         all callers.
13426         (dict_create_hashed, dict_create_hashed_expandable)
13427         (dict_create_linear, dict_create_linear_expandable, dict_free)
13428         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13429         Make functions static.
13430
13431 2019-01-10  Keith Seitz  <keiths@redhat.com>
13432
13433         PR gdb/23712
13434         PR symtab/23010
13435         * dictionary.h (struct dictionary): Replace declaration with
13436         multidictionary.
13437         (dict_create_hashed, dict_create_hashed_expandable)
13438         (dict_create_linear, dict_create_linear_expandable)
13439         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13440         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13441         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13442         taking multidictionary argument.
13443         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13444         * block.h (struct block) <dict>: Change to multidictionary
13445         and rename `multidict'.
13446         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13447         symmisc.c: Update all dictionary references to multidictionary.
13448
13449 2019-01-10  Keith Seitz  <keiths@redhat.com>
13450
13451         PR gdb/23712
13452         PR symtab/23010
13453         * dictionary.c: Include unordered_map.
13454         (pending_to_vector): New function.
13455         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13456         Rewrite the non-"_1" functions to take vector instead
13457         of linked list.
13458         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13459         "new" _1 versions of the same name.
13460         (multidictionary): Define.
13461         (std::hash<enum language): New definition.
13462         (collate_pending_symbols_by_language, mdict_create_hashed)
13463         (mdict_create_hashed_expandable, mdict_create_linear)
13464         (mdict_create_linear_expandable, mdict_free)
13465         (find_language_dictionary, create_new_language_dictionary)
13466         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13467         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13468         (mdict_size, mdict_empty): New functions.
13469         * dictionary.h (mdict_iterator): Define.
13470
13471 2019-01-10  Pedro Alves  <palves@redhat.com>
13472
13473         * breakpoint.c (read_uploaded_action)
13474         (create_tracepoint_from_upload): Adjust to use
13475         gdb::unique_xmalloc_ptr.
13476         * ctf.c (ctf_write_uploaded_tp):
13477         (SET_ARRAY_FIELD): Use emplace_back.
13478         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13479         * tracefile-tfile.c (tfile_write_uploaded_tp):
13480         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13481         gdb::unique_xmalloc_ptr.
13482         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13483         at_string, cond_string, cmd_strings>: Replace char pointers
13484         with gdb::unique_xmalloc_ptr.
13485
13486 2019-01-10  Pedro Alves  <palves@redhat.com>
13487
13488         * solib-target.c (library_list_start_library): Don't xstrdup name.
13489
13490 2019-01-10  Pedro Alves  <palves@redhat.com>
13491
13492         * mdebugread.c (parse_partial_symbols): Use
13493         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13494
13495 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13496
13497         * linux-fork.c (scoped_switch_fork_info)
13498         <~scoped_switch_fork_info>: Fix incorrect variable name.
13499
13500 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13501
13502         * linux-fork.c (scoped_switch_fork_info)
13503         <scoped_switch_fork_info>: Make explicit.
13504         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13505
13506 2019-01-10  Tom Tromey  <tom@tromey.com>
13507
13508         * objfiles.h (objfile::reset_psymtabs): Update.
13509         * objfiles.c (objfile::objfile): Update.
13510         * psymtab.h (psymtab_storage::obstack): Update.
13511         (psymtab_storage::m_obstack): Use gdb::optional.
13512         (class psymtab_storage): Update comment.  Remove objfile
13513         parameter.
13514         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13515
13516 2019-01-10  Tom Tromey  <tom@tromey.com>
13517
13518         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13519         <free_psymtabs>: Now private.
13520         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13521         (allocate_psymtab): Use new method.
13522
13523 2019-01-10  Tom Tromey  <tom@tromey.com>
13524
13525         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13526         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13527         * mdebugread.c (parse_partial_symbols): Use
13528         allocate_dependencies.
13529         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13530         allocate_dependencies.
13531         (process_psymtab_comp_unit_reader)
13532         (build_type_psymtab_dependencies): Likewise.
13533         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13534
13535 2019-01-10  Tom Tromey  <tom@tromey.com>
13536
13537         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13538         PSYMBOL_SET_LANGUAGE.
13539         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13540
13541 2019-01-10  Tom Tromey  <tom@tromey.com>
13542
13543         * psymtab.h (psymtab_storage::obstack): New method.
13544         <m_obstack>: Rename from obstack; now private.
13545         * psymtab.c (psymtab_storage): Update.
13546         * dwarf2read.c (create_addrmap_from_index)
13547         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13548         Update.
13549
13550 2019-01-10  Tom Tromey  <tom@tromey.com>
13551
13552         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13553         * objfiles.h (objfile::reset_psymtabs): New method.
13554
13555 2019-01-10  Tom Tromey  <tom@tromey.com>
13556
13557         * symmisc.c (print_symbol_bcache_statistics): Update.
13558         (print_objfile_statistics): Update.
13559         * symfile.c (reread_symbols): Update.
13560         * psymtab.h (class psymtab_storage): New.
13561         * psymtab.c (psymtab_storage): New constructor.
13562         (~psymtab_storage): New destructor.
13563         (require_partial_symbols): Update.
13564         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13565         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13566         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13567         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13568         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13569         (start_psymtab_common, end_psymtab_common)
13570         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13571         (allocate_psymtab): Update.
13572         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13573         Update.
13574         (dump_psymtab_addrmap, maintenance_print_psymbols)
13575         (maintenance_check_psymtabs): Update.
13576         (class objfile_psymtabs): Move to objfiles.h.
13577         * psympriv.h (discard_psymtab): Now inline.
13578         (psymtab_discarder::psymtab_discarder): Update.
13579         (psymtab_discarder::~psymtab_discarder): Update.
13580         (ALL_OBJFILE_PSYMTABS): Rewrite.
13581         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13582         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13583         Remove fields.
13584         <partial_symtabs>: New field.
13585         (class objfile_psymtabs): Move from psymtab.h.  Update.
13586         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13587         psymbol_cache.
13588         (objfile::~objfile): Don't destroy psymbol_cache.
13589         * mdebugread.c (parse_partial_symbols): Update.
13590         * dwarf2read.c (create_addrmap_from_index)
13591         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13592         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13593         (add_partial_subprogram, dwarf2_ranges_read): Update.
13594         * dwarf-index-write.c (write_address_map)
13595         (write_one_signatured_type, recursively_write_psymbols)
13596         (class debug_names, class debug_names, write_psymtabs_to_index):
13597         Update.
13598
13599 2019-01-10  Tom Tromey  <tom@tromey.com>
13600
13601         * symtab.h (SYMBOL_SET_NAMES): Update.
13602         (symbol_set_names): Update.
13603         (MSYMBOL_SET_NAMES): Update.
13604         * symtab.c (symbol_set_names): Change argument to be an
13605         objfile_per_bfd_storage.
13606         * psymtab.c (add_psymbol_to_bcache): Update.
13607         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13608
13609 2019-01-10  Tom Tromey  <tom@tromey.com>
13610
13611         * symtab.c (create_demangled_names_hash): Change argument to be an
13612         objfile_per_bfd_storage.
13613         (symbol_set_names): Update.
13614
13615 2019-01-10  Tom Tromey  <tom@tromey.com>
13616
13617         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13618         init_psymbol_list.
13619         * psymtab.c (init_psymbol_list): Do nothing if already called.
13620         * psympriv.h (init_psymbol_list): Add comment.
13621         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13622         init_psymbol_list.
13623         * dbxread.c (dbx_symfile_read): Unconditionally call
13624         init_psymbol_list.
13625
13626 2019-01-10  Tom Tromey  <tom@tromey.com>
13627
13628         * xcoffread.c (scan_xcoff_symtab): Update.
13629         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13630         "where".
13631         * mdebugread.c (parse_partial_symbols)
13632         (handle_psymbol_enumerators): Update.
13633         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13634         * dbxread.c (read_dbx_symtab): Update.
13635         * psympriv.h (psymbol_placement): New enum.
13636         (add_psymbol_to_list): Update.
13637
13638 2019-01-10  Tom Tromey  <tom@tromey.com>
13639
13640         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13641         static_psymbols parameters.
13642         (scan_xcoff_symtab): Update.
13643         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13644         static_psymbols parameters.
13645         * psympriv.h (start_psymtab_common): Update.
13646         * mdebugread.c (parse_partial_symbols): Update.
13647         * dwarf2read.c (create_partial_symtab): Update.
13648         * dbxread.c (read_dbx_symtab): Update.
13649         (start_psymtab): Remove global_psymbols and static_psymbols
13650         parameters.
13651
13652 2019-01-10  Tom Tromey  <tom@tromey.com>
13653
13654         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13655         * psymtab.c (allocate_psymtab): Add comment.
13656         * psympriv.h (allocate_psymtab): Add comment.
13657         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13658         initializations.
13659         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13660
13661 2019-01-10  Tom Tromey  <tom@tromey.com>
13662
13663         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13664         Don't declare.
13665         * mipsread.c: Include mdebugread.h.
13666         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13667         Declare.
13668         * elfread.c: Include mdebugread.h.
13669
13670 2019-01-09  Tom Tromey  <tom@tromey.com>
13671
13672         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13673         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13674         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13675         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13676         (psym_lookup_symbol, psym_find_last_source_symtab)
13677         (psym_forget_cached_source_info, psym_print_stats)
13678         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13679         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13680         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13681         (psym_find_compunit_symtab_by_address)
13682         (maintenance_print_psymbols, maintenance_info_psymtabs)
13683         (maintenance_check_psymtabs): Use ranged for.
13684         * psymtab.h (class objfile_psymtabs): New.
13685         (require_partial_symbols): Return objfile_psymtabs.
13686         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13687
13688 2019-01-09  Tom Tromey  <tom@tromey.com>
13689
13690         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13691         (find_pc_mapped_section, list_overlays_command)
13692         (map_overlay_command, unmap_overlay_command)
13693         (simple_overlay_update): Use all_objfiles.
13694         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13695         * printcmd.c (info_symbol_command): Use all_objfiles.
13696         * objfiles.h (ALL_OBJSECTIONS): Remove.
13697         * maint.c (maintenance_translate_address): Use all_objfiles.
13698         * gcore.c (gcore_create_callback): Use all_objfiles.
13699         (objfile_find_memory_regions): Likewise.
13700
13701 2019-01-09  Tom Tromey  <tom@tromey.com>
13702
13703         * symtab.c (find_line_symtab, info_sources_command)
13704         (make_source_files_completion_list): Use objfile_compunits.
13705         * source.c (select_source_symtab): Use objfile_compunits.
13706         * objfiles.h (struct objfile): Update comment.
13707         (ALL_OBJFILES): Remove.
13708         (ALL_FILETABS): Remove.
13709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13710         objfile_compunits.
13711
13712 2019-01-09  Tom Tromey  <tom@tromey.com>
13713
13714         * symmisc.c (print_objfile_statistics, dump_objfile)
13715         (maintenance_print_symbols): Use compunit_filetabs.
13716         * source.c (forget_cached_source_info_for_objfile): Use
13717         compunit_filetabs.
13718         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13719         (ALL_FILETABS): Use compunit_filetabs.
13720         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13721         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13722
13723 2019-01-09  Tom Tromey  <tom@tromey.com>
13724
13725         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13726         (compunit_filetabs): New.
13727         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13728         compunit_filetabs.
13729         (info_sources_command, make_source_files_completion_list): Remove
13730         declaration.
13731         * symmisc.c (print_objfile_statistics, dump_objfile)
13732         (maintenance_print_symbols): Remove declaration.
13733         (maintenance_info_symtabs): Use compunit_filetabs.
13734         (maintenance_info_line_tables): Likewise.
13735         * source.c (select_source_symtab): Change local variable name.
13736         (forget_cached_source_info_for_objfile): Remove declaration.
13737         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13738         * objfiles.c (objfile_relocate1): Remove declaration.
13739         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13740         declaration.
13741         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13742         * coffread.c (coff_symtab_read): Remove declaration.
13743         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13744         compunit_filetabs.
13745
13746 2019-01-09  Tom Tromey  <tom@tromey.com>
13747
13748         * symtab.c (lookup_objfile_from_block)
13749         (find_pc_sect_compunit_symtab, search_symbols)
13750         (default_collect_symbol_completion_matches_break_on): Use
13751         objfile_compunits.
13752         * objfiles.h (ALL_COMPUNITS): Remove.
13753         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13754         * cp-support.c (add_symbol_overload_list_qualified): Use
13755         objfile_compunits.
13756         * ada-lang.c (ada_collect_symbol_completion_matches)
13757         (ada_add_global_exceptions): Use objfile_compunits.
13758
13759 2019-01-09  Tom Tromey  <tom@tromey.com>
13760
13761         * source.c (select_source_symtab)
13762         (forget_cached_source_info_for_objfile): Remove declaration.
13763         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13764         declaration.
13765         * maint.c (count_symtabs_and_blocks): Remove declaration.
13766         * cp-support.c (add_symbol_overload_list_qualified): Remove
13767         declaration.
13768         * coffread.c (coff_symtab_read): Remove declaration.
13769         * symtab.c (lookup_symbol_in_objfile_symtabs)
13770         (basic_lookup_transparent_type_1): Use objfile_compunits.
13771         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13772         (info_sources_command, search_symbols)
13773         (default_collect_symbol_completion_matches_break_on)
13774         (make_source_files_completion_list): Remove declaration.
13775         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13776         (ada_collect_symbol_completion_matches)
13777         (ada_add_global_exceptions): Remove declaration.
13778         * linespec.c (iterate_over_all_matching_symtabs): Use
13779         objfile_compunits.
13780         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13781         (class objfile_compunits): New.
13782         (ALL_COMPUNITS): Use objfile_compunits.
13783         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13784         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13785         objfile_compunits.
13786         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13787
13788 2019-01-09  Tom Tromey  <tom@tromey.com>
13789
13790         * symtab.c (search_symbols)
13791         (default_collect_symbol_completion_matches_break_on): Use
13792         objfile_msymbols.
13793         * ada-lang.c (ada_lookup_simple_minsym)
13794         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13795         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13796         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13797         objfile_msymbols.
13798         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13799         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13800         * objc-lang.c (find_methods): Use objfile_msymbols.
13801         (info_selectors_command, info_classes_command): Likewise.
13802         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13803         * objfiles.h (class objfile_msymbols): New.
13804         (ALL_OBJFILE_MSYMBOLS): Remove.
13805         (ALL_MSYMBOLS): Remove.
13806
13807 2019-01-09  Tom Tromey  <tom@tromey.com>
13808
13809         * common/next-iterator.h (next_adapter): Add Iterator template
13810         parameter.
13811         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13812         (class all_objfiles_safe): New.
13813         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13814         * objfiles.c (put_objfile_before): Update comment.
13815         (add_separate_debug_objfile): Likewise.
13816         (free_all_objfiles): Use all_objfiles_safe.
13817         (objfile_purge_solibs): Likewise.
13818
13819 2019-01-09  Tom Tromey  <tom@tromey.com>
13820
13821         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13822         (expand_symtab_containing_pc, lookup_static_symbol)
13823         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13824         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13825         all_objfiles.
13826         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13827         * breakpoint.c (create_overlay_event_breakpoint)
13828         (create_longjmp_master_breakpoint)
13829         (create_std_terminate_master_breakpoint)
13830         (create_exception_master_breakpoint): Use all_objfiles.
13831         * linux-thread-db.c (try_thread_db_load_from_pdir)
13832         (has_libpthread): Use all_objfiles.
13833         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13834         * linespec.c (iterate_over_all_matching_symtabs)
13835         (search_minsyms_for_name): Use all_objfiles.
13836         * maint.c (maintenance_info_sections): Use all_objfiles.
13837         * main.c (captured_main_1): Use all_objfiles.
13838         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13839         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13840         * guile/scm-pretty-print.c
13841         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13842         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13843         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13844         (maintenance_print_msymbols): Use all_objfiles.
13845         * source.c (select_source_symtab): Use all_objfiles.
13846         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13847         * symfile.c (remove_symbol_file_command)
13848         (expand_symtabs_matching, map_symbol_filenames): Use
13849         all_objfiles.
13850         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13851         all_objfiles.
13852         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13853         * objc-lang.c (find_methods): Use all_objfiles.
13854         * objfiles.c (have_partial_symbols, have_full_symbols)
13855         (have_minimal_symbols, qsort_cmp)
13856         (default_iterate_over_objfiles_in_search_order): Use
13857         all_objfiles.
13858         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13859         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13860         (maintenance_check_psymtabs): Use all_objfiles.
13861         (ALL_PSYMTABS): Remove.
13862         * compile/compile-object-run.c (do_module_cleanup): Use
13863         all_objfiles.
13864         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13865         * cp-support.c (add_symbol_overload_list_qualified): Use
13866         all_objfiles.
13867         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13868         Use all_objfiles.
13869         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13870         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13871         all_objfiles.
13872         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13873         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13874         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13875         Uses all_objfiles.
13876         * solib.c (solib_read_symbols): Use all_objfiles
13877
13878 2019-01-09  Tom Tromey  <tom@tromey.com>
13879
13880         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13881         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13882         all_objfiles.
13883         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13884         * symmisc.c (print_symbol_bcache_statistics)
13885         (print_objfile_statistics, maintenance_print_objfiles)
13886         (maintenance_info_symtabs, maintenance_check_symtabs)
13887         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13888         all_objfiles.
13889         * source.c (forget_cached_source_info): Use all_objfiles.
13890         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13891         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13892         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13893         * objfiles.c (update_section_map): Use all_objfiles.
13894         (shared_objfile_contains_address_p): Likewise.
13895         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13896         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13897
13898 2019-01-09  Tom Tromey  <tom@tromey.com>
13899
13900         * common/next-iterator.h: New file.
13901         * objfiles.h (class all_objfiles): New.
13902         (struct objfile_iterator): New.
13903
13904 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13905
13906         * NEWS: Move the description of the changed "frame", "select-frame",
13907          and "info frame" commands to the Changed commands section.
13908
13909 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13910
13911         * gdbtypes.c (check_stub_method_group): Remove handling of old
13912         mangling schemes.
13913         * linespec.c (find_methods): Likewise.
13914         * stabsread.c (read_member_functions): Likewise.
13915         * valops.c (search_struct_method): Likewise.
13916         (value_struct_elt_for_reference): Likewise.
13917         * NEWS: Mention this change.
13918
13919 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13920
13921         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13922         print_source_lines.
13923         * source.c (print_source_lines_base): Update line number check.
13924         (print_source_lines): New function.
13925         (source_lines_range::source_lines_range): New function.
13926         * source.h (class source_lines_range): New class.
13927         (print_source_lines): New declaration.
13928
13929 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13930
13931         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13932
13933 2019-01-08  Tom Tromey  <tom@tromey.com>
13934             Simon Marchi  <simon.marchi@ericsson.com>
13935
13936         PR gdb/24060
13937         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13938         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13939         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13940         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13941         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13942         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13943
13944 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13945
13946         * source.c (select_source_symtab): Move header comment to
13947         declaration in source.h.
13948         (forget_cached_source_info_for_objfile): Likewise.
13949         (forget_cached_source_info): Likewise.
13950         (identify_source_line): Likewise.
13951         * source.h (identify_source_line): Move declaration from symtab.h
13952         and add comment from source.c
13953         (print_source_lines): Likewise.
13954         (forget_cached_source_info_for_objfile): Likewise.
13955         (forget_cached_source_info): Likewise.
13956         (select_source_symtab): Likewise.
13957         (enum print_source_lines_flag): Move definition from symtab.h.
13958         * symtab.h (identify_source_line): Move declaration to source.h.
13959         (print_source_lines): Likewise.
13960         (forget_cached_source_info_for_objfile): Likewise.
13961         (forget_cached_source_info): Likewise.
13962         (select_source_symtab): Likewise.
13963         (enum print_source_lines_flag): Move definition to source.h.
13964         * tui/tui-hooks.c: Add 'source.h' include.
13965
13966 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13967
13968         * source.c (print_source_lines_base): Handle requests to print
13969         reverse line number sequences, and guard against empty lines
13970         string.
13971
13972 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13973
13974         * source.c (print_source_lines_base): Fix skip of '\r' if next
13975         character is '\n'.
13976
13977 2019-01-06  Tom Tromey  <tom@tromey.com>
13978
13979         * c-exp.y (struct c_parse_state) <macro_original_text,
13980         expansion_obstack>: New member.
13981         (macro_original_text, expansion_obstack): Remove globals.
13982         (scan_macro_expansion, scanning_macro_expansion)
13983         (finished_macro_expansion): Update.
13984         (scan_macro_cleanup): Remove.
13985         (yylex, c_parse): Update.
13986
13987 2019-01-06  Tom Tromey  <tom@tromey.com>
13988
13989         * c-exp.y (struct c_parse_state) <strings>: New member.
13990         (operator_stoken): Update.
13991
13992 2019-01-06  Tom Tromey  <tom@tromey.com>
13993
13994         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13995         (union type_stack_elt) <typelist_val>: Now a pointer to
13996         std::vector.
13997         (type_stack_cleanup): Don't declare.
13998         (push_typelist): Update.
13999         * parse.c (pop_typelist): Return a std::vector.
14000         (push_typelist): Take a std::vector.
14001         (follow_types): Update.  Do not free args.
14002         (type_stack_cleanup): Remove.
14003         * c-exp.y (struct c_parse_state): New.
14004         (cpstate): New global.
14005         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14006         (nonempty_typelist): Update.
14007         (func_mod): Create a new vector.
14008         (c_parse): Create a c_parse_state.
14009         (check_parameter_typelist): Do not delete params.
14010         (function_method): Update.  Do not delete type_list.
14011
14012 2019-01-06  Tom Tromey  <tom@tromey.com>
14013
14014         PR gdb/28155:
14015         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14016         check_typedef.
14017         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14018         (print_return_value): Likewise.
14019
14020 2019-01-05  Tom Tromey  <tom@tromey.com>
14021
14022         * contrib/cleanup_check.py: Remove.
14023         * contrib/gcc-with-excheck: Remove.
14024         * contrib/exsummary.py: Remove.
14025         * contrib/excheck.py: Remove.
14026
14027 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14028
14029         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14030         NULL. Initialize tpprev to NULL instead of assigning it
14031         to NULL on the next statement.
14032         * windows-nat.c (windows_delete_thread): Remove check for
14033         main_thread_id before printing thread exit notifications.
14034         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14035         Remove thread ID check against main_thread_id.
14036         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14037         windows_delete_thread.
14038         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14039
14040 2019-01-04  Tom Tromey  <tom@tromey.com>
14041
14042         * compile/compile.c (_initialize_compile): Use upper case for
14043         metasyntactic variables.
14044         * symmisc.c (_initialize_symmisc): Use upper case for
14045         metasyntactic variables.
14046         * psymtab.c (_initialize_psymtab): Use upper case for
14047         metasyntactic variables.
14048         * demangle.c (demangle_command): Use upper case for metasyntactic
14049         variables.
14050         (_initialize_demangler): Likewise.
14051         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14052         variables.
14053
14054 2019-01-03  Tom Tromey  <tom@tromey.com>
14055
14056         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14057
14058 2019-01-03  Tom Tromey  <tom@tromey.com>
14059
14060         * python/py-symtab.c (salpy_str): Update.
14061         (struct salpy_sal_object) <symtab>: Now a PyObject.
14062         (salpy_dealloc): Update.
14063         (del_objfile_sal): Use gdbpy_ref.
14064
14065 2019-01-03  Tom Tromey  <tom@tromey.com>
14066
14067         * python/py-type.c (convert_field): Use new_reference.  Return
14068         gdbpy_ref.
14069         (make_fielditem): Return gdbpy_ref.
14070         (typy_fields): Update.
14071         (typy_getitem): Update.
14072         (field_name): Return gdbpy_ref.  Use new_reference.
14073         (typy_iterator_iternext): Update.
14074
14075 2019-01-03  Tom Tromey  <tom@tromey.com>
14076
14077         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14078
14079 2019-01-03  Tom Tromey  <tom@tromey.com>
14080
14081         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14082         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14083         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14084         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14085         (pspy_set_type_printers): Likewise.
14086         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14087         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14088         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14089         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14090         (objfpy_set_type_printers): Likewise.
14091
14092 2019-01-03  Tom Tromey  <tom@tromey.com>
14093
14094         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14095         (gdbpy_print_stack): Use gdbpy_err_fetch.
14096         * python/python-internal.h (class gdbpy_err_fetch): New class.
14097         (class gdbpy_enter) <m_error_type, m_error_value,
14098         m_error_traceback>: Remove.
14099         <m_error>: New member.
14100         (gdbpy_exception_to_string): Don't declare.
14101         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14102         * python/py-value.c (convert_value_from_python): Use
14103         gdbpy_err_fetch.
14104         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14105         gdbpy_exception_to_string.
14106         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14107         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14108         gdbpy_err_fetch.
14109
14110 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14111
14112         * linux-nat.c (delete_lwp_cleanup): Delete.
14113         (struct lwp_deleter): New struct.
14114         (lwp_info_up): New typedef.
14115         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14116         lwp_info_up.
14117
14118 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14119
14120         * linux-fork.c (class scoped_switch_fork_info): New class.
14121         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14122
14123 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14124
14125         * valops.c (find_overload_match): Remove use of null_cleanup, and
14126         calls to do_cleanups.
14127
14128 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14129
14130         * compile/compile-cplus-types.c
14131         (compile_cplus_instance::decl_name): Handle changes to
14132         cp_func_name.
14133         * cp-support.c (cp_func_name): Update header comment, update
14134         return type.
14135         * cp-support.h (cp_func_name): Update return type in declaration.
14136         * valops.c (find_overload_match): Move temp_func local to top
14137         level of function and change its type.  Use temp_func to hold and
14138         delete temporary string obtained from cp_func_name.
14139
14140 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14141
14142         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14143         gdb::char_vector, remove cleanup, and update uses of `msg`.
14144
14145 2019-01-03  Jim Wilson  <jimw@sifive.com>
14146
14147         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14148
14149 2019-01-02  Tom Tromey  <tom@tromey.com>
14150
14151         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14152         (tdesc_parse_xml): Remove cleanups.
14153         * target-descriptions.h (make_cleanup_free_target_description):
14154         Don't declare.
14155         (target_desc_deleter): New struct.
14156         (target_desc_up): New typedef.
14157         * target-descriptions.c (target_desc_deleter::operator()): Rename
14158         from free_target_description.
14159         (make_cleanup_free_target_description): Remove.
14160
14161 2019-01-02  Tom Tromey  <tom@tromey.com>
14162
14163         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14164         constructor, destructor.
14165         (linespec_parser): Remove typedef.
14166         (~linespec_parser): Rename from linespec_parser_delete.
14167         (linespec_lex_to_end, linespec_complete_label)
14168         (linespec_complete): Update.
14169         (decode_line_full): Remove cleanups.
14170         (decode_line_1): Update.
14171
14172 2019-01-02  Tom Tromey  <tom@tromey.com>
14173
14174         * python/python-internal.h (inferior_to_inferior_object): Change
14175         return type.
14176         * python/py-exitedevent.c (create_exited_event_object): Update.
14177         * python/py-inferior.c (inferior_to_inferior_object): Return
14178         gdbpy_ref.
14179         (python_new_inferior, python_inferior_deleted)
14180         (thread_to_thread_object, delete_thread_object)
14181         (build_inferior_list, gdbpy_selected_inferior): Update.
14182         * python/py-infthread.c (create_thread_object): Update.  Also fail
14183         if inferior_to_inferior_object fails.
14184
14185 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14186
14187         * inferior.h (class inferior) <displaced_step_state>: New field.
14188         * infrun.h (struct displaced_step_state): Move here from
14189         infrun.c.  Initialize fields, add constructor.
14190         <inf>: Remove field.
14191         <reset>: New method.
14192         * infrun.c (struct displaced_step_inferior_state): Move to
14193         infrun.h.
14194         (displaced_step_inferior_states): Remove.
14195         (get_displaced_stepping_state): Adust.
14196         (displaced_step_in_progress_any_inferior): Adjust.
14197         (displaced_step_in_progress_thread): Adjust.
14198         (displaced_step_in_progress): Adjust.
14199         (add_displaced_stepping_state): Remove.
14200         (get_displaced_step_closure_by_addr): Adjust.
14201         (remove_displaced_stepping_state): Remove.
14202         (infrun_inferior_exit): Call displaced_step_state.reset.
14203         (use_displaced_stepping): Don't check for NULL.
14204         (displaced_step_prepare_throw): Call
14205         get_displaced_stepping_state.
14206         (displaced_step_fixup): Don't check for NULL.
14207         (prepare_for_detach): Don't check for NULL.
14208
14209 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14210
14211         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14212          in case of call that did not complete.
14213
14214 2019-01-02  Andrey Utkin  <autkin@undo.io>
14215
14216         * symfile.c (find_separate_debug_file): Fix search of debug files for
14217         remote debuggee.
14218
14219 2019-01-02  Tom Tromey  <tom@tromey.com>
14220
14221         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14222         indentation.
14223         * python/py-frame.c (frapy_older): Remove cast.
14224         (frapy_newer): Likewise.
14225         * python/py-breakpoint.c (local_setattro): Remove cast.
14226         * python/py-arch.c (archpy_name): Remove local variable.
14227         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14228
14229 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14230
14231         * unittests/basic_string_view/element_access/char/empty.cc:
14232         Fix year range in copyright header.
14233
14234 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14235
14236         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14237         Delete.
14238         <operator==>: Update with for removed field.
14239         <hash>: Likewise.
14240         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14241         <isa_features>: ...this.
14242         <abi_features>: New field.
14243         (riscv_isa_flen): Update comment.
14244         (riscv_abi_xlen): New declaration.
14245         (riscv_abi_flen): New declaration.
14246         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14247         isa_features.
14248         (riscv_abi_xlen): New function.
14249         (riscv_isa_flen): Update to get answer from isa_features.
14250         (riscv_abi_flen): New function.
14251         (riscv_has_fp_abi): Update to get answer from abi_features.
14252         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14253         xlen and flen.
14254         (riscv_call_info) <xlen, flen>: Update comment.
14255         (riscv_call_arg_struct): Remove invalid assertions
14256         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14257         is removed.
14258         (riscv_gdbarch_init): Gather isa features and abi features
14259         separately, ensure both match on the gdbarch when reusing an old
14260         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14261         a target with 64-bit float hardware.
14262
14263 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14264
14265         * source.c (search_command_helper): Stop reverse search
14266         when line 1 has been searched.
14267
14268 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14269
14270         * record-full.c (record_full_base_target::close): Rewrite
14271         record_full_core_buf_list free logic.
14272
14273 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14274
14275         * break-catch-syscall.c (print_one_catch_syscall): xfree
14276         the last text.
14277
14278 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14279
14280         * top.c (print_gdb_version): Update Copyright year in version
14281         message.
14282
14283 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14284
14285         Update copyright year range in all GDB files.
14286
14287 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14288
14289         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14290
14291 For older changes see ChangeLog-2018.
14292 \f
14293 Local Variables:
14294 mode: change-log
14295 left-margin: 8
14296 fill-column: 74
14297 version-control: never
14298 coding: utf-8
14299 End:
14300