gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * target-dcache.c (target_dcache_cleanup): Remove.
   4         (target_dcache_aspace_key): Change type.
   5         (target_dcache_init_p, target_dcache_invalidate)
   6         (target_dcache_get, target_dcache_get_or_init)
   7         (_initialize_target_dcache): Update.
   8         * dcache.h (struct dcache_deleter): New.
   9
  10 2019-05-08  Tom Tromey  <tom@tromey.com>
  11
  12         * symtab.c (struct symbol_cache): Add destructor and
  13         initializers.
  14         (symbol_cache_key): Move.  Change type.
  15         (make_symbol_cache, free_symbol_cache): Remove.
  16         (get_symbol_cache): Update.
  17         (symbol_cache_cleanup): Remove.
  18         (ALL_PSPACES, symbol_cache_flush)
  19         (maintenance_print_symbol_cache)
  20         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
  21         Update.
  22
  23 2019-05-08  Tom Tromey  <tom@tromey.com>
  24
  25         * symtab.c (struct main_info): Add destructor and initializers.
  26         (main_progspace_key): Move.  Change type.
  27         (get_main_info): Update.
  28         (main_info_cleanup): Remove.
  29         (_initialize_symtab): Update.
  30
  31 2019-05-08  Tom Tromey  <tom@tromey.com>
  32
  33         * registry.h (DECLARE_REGISTRY): Define the _key class.
  34
  35 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * NEWS: Merge two 'New commands' sections.
  38
  39 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
  40
  41         * ada-valprint.c (ada_val_print_gnat_array): Remove language
  42         parameter and use Ada language definition instead.
  43         (ada_val_print_ptr): Remove unused language parameter.
  44         (ada_val_print_num): Remove language parameter and use Ada language
  45         definition instead.
  46         (ada_val_print_enum, ada_val_print_flt): Remove unused language
  47         parameter.
  48         (ada_val_print_struct_union, ada_val_print_ref): Remove language
  49         parameter and use Ada language definition instead.
  50         (ada_val_print_1): Update all ada_val_print_xxx calls.
  51         Remove language parameter.
  52         (ada_val_print): Update ada_val_print_1 call.
  53
  54 2019-05-08  Tom Tromey  <tromey@adacore.com>
  55
  56         * remote.c (remote_hw_watchpoint_limit)
  57         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
  58         Now static.
  59
  60 2019-05-08  Tom Tromey  <tromey@adacore.com>
  61
  62         * maint.c (_initialize_maint_cmds): Move initialization code to
  63         remote.c.
  64         (watchdog, show_watchdog): Move to remote.c.
  65         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
  66         "watchdog" static.
  67         (_initialize_remote): Move initialization code from maint.c.
  68         * defs.h (watchdog): Don't declare.
  69
  70 2019-05-08  Tom Tromey  <tromey@adacore.com>
  71
  72         * tui/tui-interp.c: Include main.h.
  73         * interps.c: Include main.h.
  74         * main.h (interpreter_p): Declare.
  75         * defs.h (interpreter_p): Don't declare.
  76
  77 2019-05-08  Tom Tromey  <tromey@adacore.com>
  78
  79         * dwarf2loc.c: Include dwarf2read.h.
  80         * defs.h (read_unsigned_leb128): Don't declare.
  81         * dwarf2read.h (read_unsigned_leb128): Declare.
  82
  83 2019-05-08  Tom Tromey  <tromey@adacore.com>
  84
  85         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
  86         method.
  87
  88 2019-05-08  Tom Tromey  <tromey@adacore.com>
  89
  90         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  91         when no wrap column is set.
  92
  93 2019-05-08  Tom Tromey  <tromey@adacore.com>
  94
  95         * c-lang.c (c_get_string): Handle non-C-style arrays.
  96
  97 2019-05-08  Tom Tromey  <tromey@adacore.com>
  98
  99         * typeprint.c (print_offset_data::update): Print the bit offset,
 100         not the number of bits remaining.
 101
 102 2019-05-08  Tom Tromey  <tromey@adacore.com>
 103
 104         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 105         padding at end of comment.
 106
 107 2019-05-08  Tom Tromey  <tromey@adacore.com>
 108
 109         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 110         Compare main types.
 111
 112 2019-05-06  Tom Tromey  <tom@tromey.com>
 113
 114         * common/scoped_mmap.c: Include common-defs.h.
 115         * common/scoped_mmap.h: Don't include config.h.
 116
 117 2019-05-04  Tom Tromey  <tom@tromey.com>
 118
 119         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 120         (struct aarch64_call_info): Add initializers.
 121         <si>: Now a std::vector.
 122         (pass_on_stack, aarch64_push_dummy_call): Update.
 123
 124 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 125             Tom Tromey  <tom@tromey.com>
 126
 127         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 128         (ppc_threads): Now a std::vector.  Now static.
 129         (hwdebug_find_thread_points_by_tid)
 130         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 131         Update.
 132
 133 2019-05-04  Tom Tromey  <tom@tromey.com>
 134
 135         * arc-tdep.c (arc_tdesc_init): Return bool.
 136
 137 2019-05-04  Tom Tromey  <tom@tromey.com>
 138
 139         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 140         Use gdb_assert_not_reached.
 141
 142 2019-05-04  Tom Tromey  <tom@tromey.com>
 143
 144         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 145         "false".
 146
 147 2019-05-04  Tom Tromey  <tom@tromey.com>
 148
 149         * arc-tdep.c (arc_tdesc_init): Use bool.
 150
 151 2019-05-04  Tom Tromey  <tom@tromey.com>
 152
 153         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 154
 155 2019-05-04  Tom Tromey  <tom@tromey.com>
 156
 157         * cli/cli-cmds.c (valid_command_p): Return bool.
 158
 159 2019-05-04  Tom Tromey  <tom@tromey.com>
 160
 161         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 162         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 163
 164 2019-05-04  Raul Tambre  <raul@tambre.ee>
 165
 166         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 167         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 168         operator for comparison.
 169
 170 2019-05-04  Tom Tromey  <tom@tromey.com>
 171
 172         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 173         (lookup_partial_symbol, print_partial_symbols)
 174         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 175         (psymbol_compare): Update.
 176         (add_psymbol_to_bcache): Clear the entire psymbol.
 177         (maintenance_check_psymtabs): Update.
 178         * psympriv.h (struct partial_symbol): Don't derive from
 179         general_symbol_info.
 180         <obj_section, unrelocated_address, address,
 181         set_unrelocated_address>: Update.
 182         <ginfo>: New member.
 183         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 184         (debug_names::write_psymbols): Update.
 185
 186 2019-05-04  Tom de Vries  <tdevries@suse.de>
 187
 188         * contrib/cc-with-tweaks.sh: Support -n arg.
 189
 190 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 191
 192         * corelow.c (core_target::detach): Ensure frame cache and
 193         register caches are cleared.
 194         inferior.c (exit_inferior_1): Likewise.
 195
 196 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 197             Tom Tromey  <tom@tromey.com>
 198
 199         * dictionary.c (collate_pending_symbols_by_language): Remove
 200         "struct" from foreach.
 201         * symtab.c (lookup_global_symbol_from_objfile)
 202         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 203         foreach.
 204         * ser-tcp.c (net_open): Remove "struct" from foreach.
 205         * objfiles.c (objfile_relocate, objfile_rebase)
 206         (objfile_has_symbols): Remove "struct" from foreach.
 207         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 208         from foreach.
 209         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 210         foreach.
 211         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 212         "struct" from foreach.
 213         * ada-lang.c (create_excep_cond_exprs)
 214         (ada_exception_catchpoint_cond_string): Remove "struct" from
 215         foreach.
 216
 217 2019-05-03  Tom Tromey  <tromey@adacore.com>
 218
 219         * ada-exp.y (convert_char_literal): Check suffix of each
 220         enumerator.
 221
 222 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 223
 224         PR ada/21406:
 225         * ada-exp.y (yywrap): Don't define.
 226         * ada-lex.l (%option): Add noyywrap
 227         (yywrap): Remove.
 228
 229 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 230
 231         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 232         _WIN32_WINNT to the XP level, unless already defined to a higher
 233         level.
 234
 235         * unittests/parse-connection-spec-selftests.c:
 236         * ser-tcp.c:
 237         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 238         override.
 239
 240         * symfile.c (find_separate_debug_file): Remove colon from the
 241         drive spec of DOS/Windows file names of the target, so that the
 242         file name produced from DEBUGDIR and the target's directory will
 243         be valid on DOS/Windows systems.
 244
 245 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 246
 247         * rust-lang.c (val_print_struct): Handle printing structures
 248         containing strings.
 249
 250 2019-05-02  Tom Tromey  <tromey@adacore.com>
 251
 252         * valarith.c (_initialize_valarith): Remove.
 253
 254 2019-05-01  Tom Tromey  <tromey@adacore.com>
 255
 256         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 257         bitfields.
 258
 259 2019-05-01  Tom Tromey  <tromey@adacore.com>
 260
 261         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 262         for big-endian copies.
 263
 264 2019-04-30  Ali Tamur  <tamur@google.com>
 265         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 266         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 267         (read_3_bytes): New function.
 268
 269 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 270
 271         * windows-nat.c (main_thread_id): Delete.
 272         (handle_output_debug_string): Replace main_thread_id by
 273         current_event.dwThreadId.
 274         (fake_create_process): Likewise.
 275         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 276         Do not set main_thread_id.
 277         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 278         current_event.dwThreadId.
 279         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 280
 281 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 282
 283         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 284         Use current_event.dwThreadId instead of main_thread_id.
 285
 286 2019-04-30  Tom Tromey  <tromey@adacore.com>
 287
 288         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 289         (create_excep_cond_exprs): Iterate over program spaces.
 290         (ada_exception_catchpoint_cond_string): Examine all minimal
 291         symbols for exception types.
 292
 293 2019-04-30  Tom Tromey  <tromey@adacore.com>
 294
 295         PR c++/24470:
 296         * dwarf2read.c (process_structure_scope): Handle case where type
 297         has template parameters but no symbol was created.
 298
 299 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 300             Chris January  <chris.january@arm.com>
 301
 302         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 303         qualifier.
 304         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 305
 306 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         * f-typeprint.c (f_print_type): Update rules for printing
 309         whitespace.
 310         (f_type_print_varspec_suffix): Likewise.
 311
 312 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 313             Chris January  <chris.january@arm.com>
 314
 315         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 316         function arguments.
 317
 318 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 319
 320         * f-lang.c (build_fortran_types): Change name of void type to
 321         lower case.
 322         * f-typeprint.c (f_type_print_base): Print the name of the void
 323         type, rather than a fixed string.
 324         * f-valprint.c (f_decorations): Use lower case void string.
 325
 326 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 327             Chris January  <chris.january@arm.com>
 328
 329         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 330         types for Fortran.
 331
 332 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 333             Chris January  <chris.january@arm.com>
 334             David Lecomber  <david.lecomber@arm.com>
 335
 336         * f-exp.y (BINOP_INTRINSIC): New token.
 337         (exp): New parser rule handling BINOP_INTRINSIC.
 338         (f77_keywords): Add new builtin procedures.
 339         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 340         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 341         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 342         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 343         (print_unop_subexp_f): New function.
 344         (print_binop_subexp_f): New function.
 345         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 346         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 347         (dump_subexp_body_f): Likewise.
 348         (operator_check_f): Likewise.
 349         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 350         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 351
 352 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 353
 354         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 355         UNOP_KIND.
 356         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 357         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 358         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 359         (operator_length_f): New fuction.
 360         (print_subexp_f): New function.
 361         (op_name_f): New function.
 362         (dump_subexp_body_f): New function.
 363         (operator_check_f): New function.
 364         (exp_descriptor_f): Replace standard expression handling functions
 365         with new functions.
 366         * gdb/fortran-operator.def: New file.
 367         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 368         * gdb/std-operator.def: Remove UNOP_KIND.
 369
 370 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 371
 372         * std-operator.def: Remove unbalanced, stray double quote
 373         character.
 374
 375 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 376             Chris January  <chris.january@arm.com>
 377             Daniel Everett  <daniel.everett@arm.com>
 378             Nick Forrington  <nick.forrington@arm.com>
 379             Richard Bunt  <richard.bunt@arm.com>
 380
 381         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 382         of depth when printing anonymous structs or unions.
 383         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 384         Don't print either the top-level value, or the children if the
 385         max-depth is exceeded.
 386         (ppscm_print_children): When printing the key of a map, allow one
 387         extra level of depth.
 388         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 389         print either the top-level value, or the children if the max-depth
 390         is exceeded.
 391         (print_children): When printing the key of a map, allow one extra
 392         level of depth.
 393         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 394         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 395         (user_print_options): Initialise max_depth field.
 396         (val_print_scalar_or_string_type_p): New function.
 397         (val_print): Check to see if the max depth has been reached.
 398         (val_print_check_max_depth): Define new function.
 399         (show_print_max_depth): New function.
 400         (_initialize_valprint): Add 'print max-depth' option.
 401         * valprint.h (struct value_print_options) <max_depth>: New field.
 402         (val_print_check_max_depth): Declare new function.
 403         * NEWS: Document new feature.
 404
 405 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 406
 407         * ada-lang.c (ada_language_defn): Initialise new field.
 408         * c-lang.c (c_is_string_type_p): New function.
 409         (c_language_defn): Initialise new field.
 410         (cplus_language_defn): Initialise new field.
 411         (asm_language_defn): Initialise new field.
 412         (minimal_language_defn): Initialise new field.
 413         * c-lang.h (c_is_string_type_p): Declare new function.
 414         * d-lang.c (d_language_defn): Initialise new field.
 415         * f-lang.c (f_is_string_type_p): New function.
 416         (f_language_defn): Initialise new field.
 417         * go-lang.c (go_is_string_type_p): New function.
 418         (go_language_defn): Initialise new field.
 419         * language.c (default_is_string_type_p): New function.
 420         (unknown_language_defn): Initialise new field.
 421         (auto_language_defn): Initialise new field.
 422         * language.h (struct language_defn) <la_is_string_type_p>: New
 423         member variable.
 424         (default_is_string_type_p): Declare new function.
 425         * m2-lang.c (m2_language_defn): Initialise new field.
 426         * objc-lang.c (objc_language_defn): Initialise new field.
 427         * opencl-lang.c (opencl_language_defn): Initialise new field.
 428         * p-lang.c (pascal_is_string_type_p): New function.
 429         (pascal_language_defn): Initialise new field.
 430         * rust-lang.c (rust_is_string_type_p): New function.
 431         (rust_language_defn): Initialise new field.
 432
 433 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 434
 435         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 436         New field.
 437         * ada-lang.c (ada_language_defn): Initialise new field.
 438         * c-lang.c (c_language_defn): Likewise.
 439         (cplus_language_defn): Likewise.
 440         (asm_language_defn): Likewise.
 441         (minimal_language_defn): Likewise.
 442         * d-lang.c (d_language_defn): Likewise.
 443         * f-lang.c (f_language_defn): Likewise.
 444         * go-lang.c (go_language_defn): Likewise.
 445         * language.c (unknown_language_defn): Likewise.
 446         (auto_language_defn): Likewise.
 447         * m2-lang.c (m2_language_defn): Likewise.
 448         * objc-lang.c (objc_language_defn): Likewise.
 449         * opencl-lang.c (opencl_language_defn): Likewise.
 450         * p-lang.c (pascal_language_defn): Likewise.
 451         * rust-lang.c (rust_language_defn): Likewise.
 452
 453 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 454
 455         * ada-lang.c (ada_is_character_type): Change return type to bool.
 456         (ada_is_string_type): Likewise.
 457         * ada-lang.h (ada_is_character_type): Update declaration
 458         (ada_is_string_type): Likewise.
 459
 460 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 461
 462         Support style in 'frame|thread apply'
 463
 464         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 465         * record.c (record_start, record_stop): Update callers of
 466         execute_command_to_string with false.
 467         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 468         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 469         methods.
 470         (class string_file): New constructor with term_out parameter.
 471         Override methods term_out and can_emit_style_escape.  New member
 472         term_out.
 473         (class stdio_file): Override can_emit_style_escape.
 474         (class tee_file): Override term_out and can_emit_style_escape.
 475         * utils.h (can_emit_style_escape): Remove.
 476         * utils.c (can_emit_style_escape): Likewise.
 477         Update all callers of can_emit_style_escape (SOMESTREAM) to
 478         SOMESTREAM->can_emit_style_escape.
 479         * source-cache.c (source_cache::get_source_lines): Likewise.
 480         * stack.c (frame_apply_command_count): Call execute_command_to_string
 481         passing the term_out characteristic of the current gdb_stdout.
 482         * thread.c (thr_try_catch_cmd): Likewise.
 483         * top.c (execute_command_to_string): pass term_out parameter
 484         to construct the string_file for the command output.
 485         * ui-file.c (term_cli_styling): New function (most code moved
 486         from utils.c can_emit_style_escape).
 487         (string_file::string_file, string_file::can_emit_style_escape,
 488         stdio_file::can_emit_style_escape, tee_file::term_out,
 489         tee_file::can_emit_style_escape): New functions.
 490
 491 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 492
 493         * NEWS: Mention the new set|show may-call-functions.
 494         * infcall.c (may_call_functions_p): New variable.
 495         (show_may_call_functions_p): New function.
 496         (call_function_by_hand_dummy): Throws an error if not
 497         may-call-functions.
 498         (_initialize_infcall): Call add_setshow_boolean_cmd for
 499         may-call-functions.
 500
 501 2019-04-25  Keith Seitz  <keiths@redhat.com>
 502
 503         PR c++/24367
 504         * cp-support.c (inspect_type): Don't attempt substitutions
 505         of symbol with the same name.
 506
 507 2019-04-25  Tom Tromey  <tromey@adacore.com>
 508
 509         PR gdb/24475:
 510         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 511         static.
 512
 513 2019-04-25  Tom Tromey  <tromey@adacore.com>
 514
 515         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 516         rvalue reference.
 517         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 518         (gdb_xml_parser::parse): Use std::move.
 519         * python/python-internal.h (gdbpy_convert_exception): Take a const
 520         reference.
 521         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 522         std::move.
 523         * python/py-utils.c (gdbpy_convert_exception): Take a const
 524         reference.
 525         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 526         Use std::move.
 527         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 528         Use std::move.
 529         * mi/mi-main.c (mi_print_exception): Take a const reference.
 530         * main.c (handle_command_errors): Take a const reference.
 531         * linespec.c (parse_linespec): Use std::move.
 532         * infcall.c (run_inferior_call): Use std::move.
 533         (call_function_by_hand_dummy): Use std::move.
 534         * exec.c (try_open_exec_file): Use std::move.
 535         * exceptions.h (exception_print, exception_fprintf)
 536         (exception_print_same): Update.
 537         * exceptions.c (print_exception, exception_print)
 538         (exception_fprintf, exception_print_same): Change parameters to
 539         const reference.
 540         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 541         * common/new-op.c: Use std::move.
 542         * common/common-exceptions.h (struct gdb_exception): Add move
 543         constructor.
 544         (struct gdb_exception_error, struct gdb_exception_quit, struct
 545         gdb_quit_bad_alloc): Change constructor to move constructor.
 546         (throw_exception): Change parameter to rvalue reference.
 547         * common/common-exceptions.c (throw_exception): Take rvalue
 548         reference.
 549         * cli/cli-interp.c (safe_execute_command): Use std::move.
 550         * breakpoint.c (insert_bp_location, location_to_sals): Use
 551         std::move.
 552
 553 2019-04-25  Tom Tromey  <tromey@adacore.com>
 554
 555         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 556         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 557         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 558         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 559         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 560         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 561         guile/scm-value.c: Use unpack.
 562         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 563         gdbscm_gdb_exception.
 564         (gdbscm_throw_gdb_exception): Likewise.
 565         (struct gdbscm_gdb_exception): New.
 566         (unpack): New function.
 567         (gdbscm_wrap): Use unpack.
 568
 569 2019-04-25  Tom Tromey  <tromey@adacore.com>
 570
 571         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 572         (gdb_rl_callback_handler): Use std::move.
 573         * common/common-exceptions.h (struct gdb_exception): Add move
 574         assignment operator.
 575         (throw_exception_sjlj): Change "exception" to const reference.
 576         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 577         (throw_exception_sjlj): Change "exception" to const reference.
 578
 579 2019-04-25  Tom Tromey  <tromey@adacore.com>
 580
 581         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 582         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 583         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 584         Update.
 585         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 586         Update.
 587         * mi/mi-interp.c (mi_interp::exec): Update.
 588         * linespec.c (parse_linespec): Update.
 589         * infcall.c (run_inferior_call): Update.
 590         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 591         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 592         (gdbscm_lookup_global_symbol): Update.
 593         * guile/scm-param.c (gdbscm_parameter_value): Update.
 594         * guile/scm-frame.c (gdbscm_frame_read_register)
 595         (gdbscm_frame_read_var): Update.
 596         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 597         * exec.c (try_open_exec_file): Update.
 598         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 599         (gdb_rl_callback_handler): Update.
 600         * common/common-exceptions.h (exception_none): Don't declare.
 601         * common/common-exceptions.c (exception_none): Don't define.
 602         (struct catcher) <exception>: Update.
 603         * cli/cli-interp.c (safe_execute_command): Update.
 604         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 605
 606 2019-04-25  Ali Tamur  <tamur@google.com>
 607
 608         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 609         (read_attribute_value): Likewise.
 610         (dwarf2_read_addr_index): Update comment.
 611         (read_str_index): Add DW_FORM_strx.
 612         (dwarf2_string_attr): Likewise.
 613         (dwarf2_const_value_attr): Likewise.
 614         (dump_die_shallow): Likewise.
 615         (dwarf2_fetch_constant_bytes): Likewise.
 616         (skip_form_bytes): Likewise.
 617         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 618
 619 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 620
 621         PR corefiles/11608
 622         PR corefiles/18187
 623         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 624         OFFSET.  Verify if current mapping contains an ELF header.
 625         (linux_find_memory_regions_full): Adjust call to
 626         dump_mapping_p.
 627
 628 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 629             Kang Li <kanglictf@gmail.com>
 630
 631         PR gdb/21600
 632
 633         * dwarf2-frame.c (read_initial_length): Be consistent about using
 634         unsigned representation of length.
 635         (decode_frame_entry_1): Likewise.  Check for wraparound of
 636         end pointer as well as buffer overflow.
 637
 638 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 639
 640         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 641         "vq".
 642
 643 2019-04-24  Tom Tromey  <tromey@adacore.com>
 644
 645         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 646
 647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * s12z-tdep.c (s12z_unwind_pc): Delete.
 650         (s12z_unwind_sp): Delete.
 651         (s12z_gdbarch_init): Don't register deleted functions with
 652         gdbarch.
 653
 654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 655
 656         * rl78-tdep.c (rl78_unwind_sp): Delete.
 657         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 658
 659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 660
 661         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 662         (xstormy16_unwind_pc): Delete.
 663         (xstormy16_dummy_id): Delete.
 664         (xstormy16_gdbarch_init): Don't register deleted functions with
 665         gdbarch.
 666
 667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * vax-tdep.c (vax_unwind_pc): Delete.
 670         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 671
 672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 673
 674         * v850-tdep.c (v850_unwind_sp): Delete.
 675         (v850_unwind_pc): Delete.
 676         (v850_dummy_id): Delete.
 677         (v850_gdbarch_init): Don't register deleted functions with
 678         gdbarch.
 679
 680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 681
 682         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 683         (tilegx_unwind_pc): Delete.
 684         (tilegx_unwind_dummy_id): Delete.
 685         (tilegx_gdbarch_init): Don't register deleted functions with
 686         gdbarch.
 687
 688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 689
 690         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 691         (tic6x_dummy_id): Delete.
 692         (tic6x_gdbarch_init): Don't register deleted functions with
 693         gdbarch.
 694
 695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * sparc-tdep.c (sparc_unwind_pc): Delete.
 698         (sparc32_gdbarch_init): Don't register deleted function with
 699         gdbarch.
 700
 701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 702
 703         * sh-tdep.c (sh_unwind_sp): Delete.
 704         (sh_unwind_pc): Delete.
 705         (sh_dummy_id): Delete.
 706         (sh_gdbarch_init): Don't register deleted functions with
 707         gdbarch.
 708
 709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * score-tdep.c (score_unwind_sp): Delete.
 712         (score_unwind_pc): Delete.
 713         (score_dummy_id): Delete.
 714         (score_gdbarch_init): Don't register deleted functions with
 715         gdbarch.
 716
 717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 718
 719         * rx-tdep.c (rx_unwind_pc): Delete.
 720         (rx_unwind_sp): Delete.
 721         (rx_dummy_id): Delete.
 722         (rx_gdbarch_init): Don't register deleted functions with
 723         gdbarch.  Update comment.
 724
 725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 726
 727         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 728         (rs6000_dummy_id): Delete.
 729         (rs6000_gdbarch_init): Don't register deleted functions with
 730         gdbarch.
 731
 732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 733
 734         * or1k-tdep.c (or1k_dummy_id): Delete.
 735         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 736
 737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * nios2-tdep.c (nios2_dummy_id): Delete.
 740         (nios2_unwind_sp): Delete.
 741         (nios2_gdbarch_init): Don't register deleted functions with
 742         gdbarch.
 743
 744 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * nds32-tdep.c (nds32_dummy_id): Delete.
 747         (nds32_unwind_pc): Delete.
 748         (nds32_unwind_sp): Delete.
 749         (nds32_gdbarch_init): Don't register deleted functions with
 750         gdbarch.
 751
 752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 753
 754         * msp430-tdep.c (msp430_unwind_pc): Delete.
 755         (msp430_unwind_sp): Delete.
 756         (msp430_dummy_id): Delete.
 757         (msp430_gdbarch_init): Don't register deleted functions with
 758         gdbarch.
 759
 760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 761
 762         * moxie-tdep.c (moxie_unwind_sp): Delete.
 763         (moxie_unwind_pc): Delete.
 764         (moxie_dummy_id): Delete.
 765         (moxie_gdbarch_init): Don't register deleted functions with
 766         gdbarch.
 767
 768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 769
 770         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 771         (mn10300_unwind_pc): Delete.
 772         (mn10300_unwind_sp): Delete.
 773         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 774         mn10300_unwind_sp.
 775         (mn10300_frame_unwind_init): Don't register deleted functions with
 776         gdbarch.
 777
 778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * mep-tdep.c (mep_unwind_pc): Delete.
 781         (mep_unwind_sp): Delete.
 782         (mep_dummy_id): Delete.
 783         (mep_gdbarch_init): Don't register deleted functions with
 784         gdbarch.
 785
 786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 789         (m68hc11_unwind_sp): Delete.
 790         (m68hc11_gdbarch_init): Don't register deleted functions with
 791         gdbarch.
 792
 793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * m32r-tdep.c (m32r_unwind_sp): Delete.
 796         (m32r_unwind_pc): Delete.
 797         (m32r_dummy_id): Delete.
 798         (m32r_gdbarch_init): Don't register deleted functions with
 799         gdbarch.
 800
 801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 802
 803         * m32c-tdep.c (m32c_unwind_pc): Delete.
 804         (m32c_unwind_sp): Delete.
 805         (m32c_dummy_id): Delete.
 806         (m32c_gdbarch_init): Don't register deleted functions with
 807         gdbarch.
 808
 809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 810
 811         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 812         (lm32_unwind_pc): Delete.
 813         (lm32_dummy_id): Delete.
 814         (lm32_gdbarch_init): Don't register deleted functions with
 815         gdbarch.
 816
 817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 818
 819         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 820         (iq2000_unwind_pc): Delete.
 821         (iq2000_dummy_id): Delete.
 822         (iq2000_gdbarch_init): Don't register deleted functions with
 823         gdbarch.
 824
 825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * nds32-tdep.c (nds32_type_align): Delete.
 828         (nds32_push_dummy_call): Use type_align instead.
 829
 830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 831
 832         * arm-tdep.c (arm_type_align): Only handle vector override case.
 833         (arm_push_dummy_call): Use type_align.
 834         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 835
 836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 839         case.
 840         (pass_on_stack): Use type_align.
 841         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 842         function.
 843
 844 2019-04-23  Tom Tromey  <tromey@adacore.com>
 845
 846         * dwarf2read.c (line_header::file_name_at): Remove unused
 847         overload.
 848
 849 2019-04-23  Tom de Vries  <tdevries@suse.de>
 850
 851         PR gdb/24438
 852         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 853         invocation.
 854
 855
 856 2019-03-27  Ali Tamur  <tamur@google.com>
 857
 858         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 859         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 860         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 861         (dwarf_expr_context::get_addr_index): Likewise
 862         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 863         (symbol_needs_eval_context::get_addr_index): Likewise
 864         (disassemble_dwarf_expression): Add DW_OP_addrx
 865         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 866         (read_cutu_die_from_dwo): Update comment
 867         (skip_one_die): Add DW_FORM_addrx
 868         (read_attribute_value): Likewise
 869         (var_decode_location): Add DW_OP_addrx
 870         (dwarf2_const_value_attr): Add DW_FORM_addrx
 871         (dump_die_shallow): Likewise
 872         (dwarf2_fetch_constant_bytes): Likewise
 873         (decode_locdesc): Add DW_OP_addrx
 874         (skip_form_bytes): Add DW_FORM_addrx
 875
 876 2019-04-22  Ali Tamur  <tamur@google.com>
 877
 878         * MAINTAINERS (Write After Approval): Add self.
 879
 880 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 881
 882         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 883         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 884         (open_symbol_file_object): Likewise.
 885         (svr4_default_sos): Add info parameter.
 886         (svr4_read_so_list): Likewise.
 887         (svr4_current_sos_direct): Adjust functions calls to pass down
 888         info.
 889         (svr4_current_sos_1): Add info parameter.
 890         (svr4_current_sos): Call get_svr4_info, pass info down to
 891         svr4_current_sos_1.
 892         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 893         get_svr4_info.
 894         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 895         get_svr4_info.
 896         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 897         to get_svr4_info.
 898         (probes_table_remove_objfile_probes): Likewise.
 899         (register_solib_event_probe): Add info parameter.
 900         (solist_update_incremental): Pass info parameter down to
 901         svr4_read_so_list.
 902         (disable_probes_interface): Add info parameter.
 903         (svr4_handle_solib_event): Pass current_program_space to
 904         get_svr4_info.  Adjust disable_probes_interface cleanup.
 905         (svr4_create_probe_breakpoints): Add info parameter, pass it
 906         down to register_solib_event_probe.
 907         (svr4_create_solib_event_breakpoints): Add info parameter,
 908         pass it down to svr4_create_probe_breakpoints.
 909         (enable_break): Pass info down to
 910         svr4_create_solib_event_breakpoints.
 911         (svr4_solib_create_inferior_hook): Pass current_program_space to
 912         get_svr4_info.
 913         (svr4_clear_solib): Likewise.
 914
 915 2019-04-22  Pedro Alves  <palves@redhat.com>
 916
 917         * solib-svr4.c (svr4_free_objfile_observer): New.
 918         (probe_and_action::objfile): New field.
 919         (probes_table_htab_remove_objfile_probes)
 920         (probes_table_remove_objfile_probes): New functions.
 921         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 922         in the new probe_and_action.  Don't store the probe in 'lookup'.
 923         (svr4_create_probe_breakpoints): Pass objfile to
 924         register_solib_event_probe.
 925         (_initialize_svr4_solib): Register a free_objfile observer.
 926
 927 2019-04-19  Tom Tromey  <tom@tromey.com>
 928
 929         * common/queue.h: Remove.
 930
 931 2019-04-19  Tom Tromey  <tom@tromey.com>
 932
 933         * event-loop.c: Don't include "common/queue.h".
 934
 935 2019-04-19  Tom Tromey  <tom@tromey.com>
 936
 937         * remote.c (remote_target): Use delete.
 938         * remote-notif.h: Include <list>, not "common/queue.h".
 939         (notif_client_p): Remove typedef.
 940         (remote_notif_state): Add constructor, destructor, initializer.
 941         <notif_queue>: Now a std::list.
 942         (remote_notif_state_xfree): Don't declare.
 943         * remote-notif.c (remote_notif_process, handle_notification)
 944         (remote_notif_state_allocate): Update.
 945         (~remote_notif_state): Rename from remote_notif_state_xfree.
 946
 947 2019-04-19  Tom Tromey  <tom@tromey.com>
 948
 949         * symfile.c (reread_symbols): Update.
 950         * objfiles.c (objfile_register_static_link)
 951         (objfile_lookup_static_link): Update
 952         (~objfile) Don't delete static_links.
 953         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 954
 955 2019-04-19  Tom Tromey  <tom@tromey.com>
 956
 957         * type-stack.h (struct type_stack) <insert>: Constify string.
 958         * type-stack.c (type_stack::insert): Constify string.
 959         * gdbtypes.h (lookup_template_type): Update.
 960         (address_space_name_to_int): Update.
 961         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 962         const.
 963         (lookup_template_type): Make name const.
 964         * c-exp.y: Update rules.
 965         (lex_one_token, classify_name, classify_inner_name)
 966         (c_print_token): Update.
 967         * p-exp.y: Update rules.
 968         (yylex): Update.
 969         * f-exp.y: Update rules.
 970         (yylex): Update.
 971         * d-exp.y: Update rules.
 972         (lex_one_token, classify_name, classify_inner_name): Update.
 973         * parse.c (write_dollar_variable, copy_name): Return std::string.
 974         * parser-defs.h (copy_name): Change return type.
 975         * m2-exp.y: Update rules.
 976         (yylex): Update.
 977         * go-exp.y (lex_one_token): Update.
 978         Update rules.
 979         (classify_unsafe_function, classify_packaged_name)
 980         (classify_name, yylex): Update.
 981
 982 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 983
 984         * configure.ac: add --enable-source-highlight switch.
 985         * configure: Regenerate.
 986         * top.c (print_gdb_version): plumb --enable-source-highlight
 987         status to "show configuration".
 988
 989 2019-04-19  Tom Tromey  <tromey@adacore.com>
 990
 991         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 992         Check ADA_TYPE_P.
 993         (empty_record, ada_template_to_fixed_record_type_1)
 994         (template_to_static_fixed_type)
 995         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 996         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 997         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 998         macros.
 999
1000 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1001
1002         PR symtab/24423:
1003         * source.c (print_source_lines_base): Advance "iter" when a
1004         control character is seen.
1005
1006 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1007
1008         * inferior.h (struct infcall_suspend_state_deleter):
1009         Catch exception in destructor to avoid crash.
1010
1011 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1012
1013         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1014         close to the add_com "shell".
1015
1016 2019-04-18  Tom Tromey  <tromey@adacore.com>
1017
1018         * process-stratum-target.h (class process_stratum_target)
1019         <stratum>: Add "final".
1020
1021 2019-04-17  Tom Tromey  <tromey@adacore.com>
1022
1023         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1024         against nullptr before use.
1025
1026 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1027
1028         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1029
1030 2019-04-17  Jim Wilson  <jimw@sifive.com>
1031             Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1034         code read might fail, assume 4-byte breakpoint in that case.
1035
1036 2019-04-15  Leszek Swirski  <leszeks@google.com>
1037
1038         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1039         rather than a hand-rolled POD check when checking for forced MEMORY
1040         classification.
1041
1042 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1043
1044         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1045         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1046         function.
1047         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1048         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1049         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1050         declaration.
1051
1052 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1053
1054         * aarch64-linux-nat.c
1055         (aarch64_linux_nat_target::thread_architecture): Add override.
1056         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1057         each VQ.
1058
1059 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1060
1061         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1062
1063 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1064
1065         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1066         target types of size 96-bits, add some additional comments, and
1067         check that the builtin type we found was the correct size.
1068
1069 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1070
1071         * utils.c (prompt_for_continue): Don't restore the styling at the
1072         end, as applied_style has the wrong value.  This fixes styling in
1073         long lists of file names that are interrupted by the "Continue?"
1074         prompt.
1075
1076 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1079         * c-lang.c (c_language_defn): Likewise.
1080         (cplus_language_defn): Likewise.
1081         (asm_language_defn): Likewise.
1082         (minimal_language_defn): Likewise.
1083         * d-lang.c (d_language_defn): Likewise.
1084         * f-lang.c (f_language_defn): Likewise.
1085         * go-lang.c (go_language_defn): Likewise.
1086         * language.c (unknown_language_defn): Likewise.
1087         (auto_language_defn): Likewise.
1088         * language.h (struct language_defn): Remove la_magic field.
1089         (LANG_MAGIC): Delete.
1090         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1091         * objc-lang.c (objc_language_defn): Likewise.
1092         * opencl-lang.c (opencl_language_defn): Likewise.
1093         * p-lang.c (pascal_language_defn): Likewise.
1094         * rust-lang.c (rust_language_defn): Likewise.
1095
1096 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * riscv-tdep.c (riscv_type_align): New function.
1099         (riscv_type_alignment): Delete.
1100         (riscv_arg_location): Use 'type_align'.
1101         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1102
1103 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * gdbtypes.c (type_align): A struct with no non-static fields also
1106         has alignment of 1.
1107
1108 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1111         component to 0.
1112         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1113         member.
1114         (riscv_struct_info::analyse): New implementation using new
1115         analyse_inner member function.
1116         (riscv_struct_info::field_offset): New member function.
1117         (riscv_struct_info::m_offsets): New member variable.
1118         (riscv_struct_info::analyse_inner): New private member function,
1119         takes the old implementation of riscv_struct_info::analyse but
1120         extended to track field offsets.
1121         (riscv_call_arg_struct): Update the struct folding special cases
1122         to handle cases where empty C++ structs, which are non-zero
1123         length, are found.
1124         (riscv_arg_location): Initialise the length of each location, a
1125         non-zero length now indicates the location is in use.
1126         (riscv_push_dummy_call): Allow for the first location having a
1127         non-zero offset when setting up arguments.
1128         (riscv_return_value): Likewise, but for return values.
1129
1130 2019-04-11  Tom Tromey  <tromey@adacore.com>
1131
1132         * utils.c (internal_vproblem): Make "msg" const.
1133
1134 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1135
1136         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1137         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1138         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1139         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1140
1141 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1142
1143         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1144         function.
1145         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1146         of amd64_collect_native_gregset.
1147         (amd64_linux_nat_target::store_registers): Likewise.
1148
1149 2019-04-10  Tom Tromey  <tom@tromey.com>
1150
1151         * symtab.c (lookup_global_symbol_from_objfile)
1152         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1153         * objfiles.h (class separate_debug_iterator): New.
1154         (class separate_debug_range): New.
1155         (struct objfile) <separate_debug_objfiles>: New method.
1156         (objfile_separate_debug_iterate): Don't declare.
1157         * objfiles.c (separate_debug_iterator::operator++): Rename from
1158         objfile_separate_debug_iterate.
1159         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1160         iterator.
1161         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1162         iterator.
1163
1164 2019-04-10  Tom Tromey  <tom@tromey.com>
1165
1166         * symfile.c (reread_symbols): Remove old comment.
1167         * objfiles.c (free_all_objfiles): Fix a typo.
1168
1169 2019-04-10  Tom Tromey  <tom@tromey.com>
1170
1171         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1172         * minsyms.c (lookup_minimal_symbol): Use foreach.
1173         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1174         (lookup_minimal_symbol_solib_trampoline): Likewise.
1175         * symfile.c (reread_symbols): Use foreach.
1176
1177 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1178             Tom Tromey  <tromey@adacore.com>
1179
1180         PR rust/24414:
1181         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1182         (rust_lex_int_test): Change "value" to be LONGEST.
1183         (rust_lex_tests): Add test for long integer literal.
1184
1185 2019-04-09  Tom Tromey  <tromey@adacore.com>
1186
1187         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1188         to bool.
1189         (extended_remote_target::attach): Update.
1190         (remote_target::remote_notice_new_inferior): Update.
1191         (remote_target::add_current_inferior_and_thread): Update.
1192         * inferior.c (exit_inferior_1): Use "false".
1193         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1194
1195 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1196
1197         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1198         the "start" command.
1199
1200 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1201
1202         * python/py-inferior.c (infpy_thread_from_thread_handle):
1203         Adjust comments to reflect renaming of thread_from_thread_handle
1204         to thread_from_handle.  Adjust keywords.  Fix type error message.
1205         (inferior_object_methods): Add thread_from_handle.  Retain
1206         thread_from_thread_handle, but mark it as deprecated.
1207
1208 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1209
1210         * gdbthread.h (find_thread_by_handle): Revise declaration.
1211         * thread.c (find_thread_by_handle): Likewise.  Adjust
1212         implementation too.
1213         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1214         support for buffer objects as handles.
1215
1216 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1217
1218         * python/py-infthread.c (thpy_thread_handle): New function.
1219         (thread_object_methods): Register thpy_thread_handle.
1220
1221 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1222
1223         * gdbthread.h (thread_to_thread_handle): Declare.
1224         * thread.c (gdbtypes.h): Include.
1225         (thread_to_thread_handle): New function.
1226
1227         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1228         (target_thread_info_to_thread_handle): Declare.
1229         * target.c (target_thread_info_to_thread_handle): New function.
1230         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1231         * target-delegates.c: Regenerate.
1232
1233         * linux-thread-db.c (class thread_db_target): Add method
1234         thread_info_to_thread_handle.
1235         (thread_db_target::thread_info_to_thread_handle): Define.
1236         * remote.c (class remote_target): Add new method
1237         thread_info_to_thread_handle.
1238         (remote_target::thread_info_to_thread_handle): Define.
1239
1240 2019-04-08  Pedro Alves  <palves@redhat.com>
1241
1242         * common/common-exceptions.c (throw_exception): Don't create
1243         named object to throw; throw directly.
1244         (throw_it): Likewise.  Don't initialize gdb_exception::message
1245         here, with new; pass FMT and AP to the ctor instead.
1246         * common/common-exceptions.h: Include <string>.
1247         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1248         const char *, va_list)): New ctor.  Use std::make_shared.
1249         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1250         errors)): Delete.
1251         (gdb_exception_error::gdb_exception_error(enum errors, const char
1252         *, va_list)): New.
1253         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1254         Add assertion.
1255         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1256         errors)): Delete.
1257         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1258         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1259         Add assertion.
1260
1261 2019-04-08  Tom Tromey  <tom@tromey.com>
1262
1263         * valops.c (value_rtti_indirect_type): Replace throw_exception
1264         with throw.
1265         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1266         with throw.
1267         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1268         throw.
1269         * target.c (target_translate_tls_address): Replace throw_exception
1270         with throw.
1271         * stack.c (frame_apply_command_count): Replace throw_exception
1272         with throw.
1273         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1274         throw.
1275         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1276         with throw.
1277         * rs6000-tdep.c (rs6000_frame_cache)
1278         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1279         * remote.c: Replace throw_exception with throw.
1280         * record-full.c (record_full_message, record_full_wait_1)
1281         (record_full_restore): Replace throw_exception with throw.
1282         * record-btrace.c:
1283         (get_thread_current_frame_id, record_btrace_start_replaying)
1284         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1285         (cmd_record_btrace_start): Replace throw_exception with throw.
1286         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1287         throw.
1288         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1289         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1290         * linespec.c:
1291         (find_linespec_symbols): Replace throw_exception with throw.
1292         * infrun.c (displaced_step_prepare, resume): Replace
1293         throw_exception with throw.
1294         * infcmd.c (post_create_inferior): Replace throw_exception with
1295         throw.
1296         * inf-loop.c (inferior_event_handler): Replace throw_exception
1297         with throw.
1298         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1299         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1300         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1301         (get_prev_frame_always, get_frame_pc_if_available)
1302         (get_frame_address_in_block_if_available, get_frame_language):
1303         Replace throw_exception with throw.
1304         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1305         throw_exception with throw.
1306         * eval.c (fetch_subexp_value, evaluate_var_value)
1307         (evaluate_funcall, evaluate_subexp_standard): Replace
1308         throw_exception with throw.
1309         * dwarf2loc.c (call_site_find_chain)
1310         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1311         Replace throw_exception with throw.
1312         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1313         with throw.
1314         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1315         throw.
1316         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1317         * completer.c (complete_line_internal): Replace throw_exception
1318         with throw.
1319         * compile/compile-object-run.c (compile_object_run): Replace
1320         throw_exception with throw.
1321         * cli/cli-script.c (process_next_line): Replace throw_exception
1322         with throw.
1323         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1324         (btrace_enable, btrace_maint_update_pt_packets): Replace
1325         throw_exception with throw.
1326         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1327         throw_exception with throw.
1328         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1329         throw_exception with throw.
1330         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1331         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1332         * aarch64-tdep.c (aarch64_make_prologue_cache)
1333         (aarch64_make_stub_cache): Replace throw_exception with throw.
1334
1335 2019-04-08  Tom Tromey  <tom@tromey.com>
1336
1337         * common/common-exceptions.c (throw_exception): Rename from
1338         throw_exception_cxx.  Remove old copy.  Make argument const.
1339         (throw_it): Create and throw exception objects directly.
1340         * common/common-exceptions.h (throw_exception): Make argument
1341         const.
1342         (struct gdb_exception_error): Add constructor.
1343         (struct gdb_exception_quit): Add constructor.
1344
1345 2019-04-08  Tom Tromey  <tom@tromey.com>
1346
1347         * common/common-exceptions.h (exception_rethrow): Don't declare.
1348         (TRY_SJLJ): Update comment.
1349         (TRY, CATCH, END_CATCH): Remove.
1350         * common/common-exceptions.c (exception_rethrow): Remove.
1351
1352 2019-04-08  Tom Tromey  <tom@tromey.com>
1353
1354         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1355         Remove.
1356         (gdb_exception_error): Rename from
1357         gdb_exception_RETURN_MASK_ERROR.
1358         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1359         (gdb_quit_bad_alloc): Update.
1360         * aarch64-tdep.c: Update.
1361         * ada-lang.c: Update.
1362         * ada-typeprint.c: Update.
1363         * ada-valprint.c: Update.
1364         * amd64-tdep.c: Update.
1365         * arch-utils.c: Update.
1366         * break-catch-throw.c: Update.
1367         * breakpoint.c: Update.
1368         * btrace.c: Update.
1369         * c-varobj.c: Update.
1370         * cli/cli-cmds.c: Update.
1371         * cli/cli-interp.c: Update.
1372         * cli/cli-script.c: Update.
1373         * common/common-exceptions.c: Update.
1374         * common/new-op.c: Update.
1375         * common/selftest.c: Update.
1376         * compile/compile-c-symbols.c: Update.
1377         * compile/compile-cplus-symbols.c: Update.
1378         * compile/compile-object-load.c: Update.
1379         * compile/compile-object-run.c: Update.
1380         * completer.c: Update.
1381         * corelow.c: Update.
1382         * cp-abi.c: Update.
1383         * cp-support.c: Update.
1384         * cp-valprint.c: Update.
1385         * darwin-nat.c: Update.
1386         * disasm-selftests.c: Update.
1387         * dtrace-probe.c: Update.
1388         * dwarf-index-cache.c: Update.
1389         * dwarf-index-write.c: Update.
1390         * dwarf2-frame-tailcall.c: Update.
1391         * dwarf2-frame.c: Update.
1392         * dwarf2loc.c: Update.
1393         * dwarf2read.c: Update.
1394         * eval.c: Update.
1395         * event-loop.c: Update.
1396         * event-top.c: Update.
1397         * exec.c: Update.
1398         * f-valprint.c: Update.
1399         * fbsd-tdep.c: Update.
1400         * frame-unwind.c: Update.
1401         * frame.c: Update.
1402         * gdbtypes.c: Update.
1403         * gnu-v3-abi.c: Update.
1404         * guile/guile-internal.h: Update.
1405         * guile/scm-block.c: Update.
1406         * guile/scm-breakpoint.c: Update.
1407         * guile/scm-cmd.c: Update.
1408         * guile/scm-disasm.c: Update.
1409         * guile/scm-frame.c: Update.
1410         * guile/scm-lazy-string.c: Update.
1411         * guile/scm-math.c: Update.
1412         * guile/scm-param.c: Update.
1413         * guile/scm-ports.c: Update.
1414         * guile/scm-pretty-print.c: Update.
1415         * guile/scm-symbol.c: Update.
1416         * guile/scm-symtab.c: Update.
1417         * guile/scm-type.c: Update.
1418         * guile/scm-value.c: Update.
1419         * i386-linux-tdep.c: Update.
1420         * i386-tdep.c: Update.
1421         * inf-loop.c: Update.
1422         * infcall.c: Update.
1423         * infcmd.c: Update.
1424         * infrun.c: Update.
1425         * jit.c: Update.
1426         * language.c: Update.
1427         * linespec.c: Update.
1428         * linux-fork.c: Update.
1429         * linux-nat.c: Update.
1430         * linux-tdep.c: Update.
1431         * linux-thread-db.c: Update.
1432         * main.c: Update.
1433         * mi/mi-cmd-break.c: Update.
1434         * mi/mi-cmd-stack.c: Update.
1435         * mi/mi-interp.c: Update.
1436         * mi/mi-main.c: Update.
1437         * objc-lang.c: Update.
1438         * p-valprint.c: Update.
1439         * parse.c: Update.
1440         * ppc-linux-tdep.c: Update.
1441         * printcmd.c: Update.
1442         * python/py-arch.c: Update.
1443         * python/py-breakpoint.c: Update.
1444         * python/py-cmd.c: Update.
1445         * python/py-finishbreakpoint.c: Update.
1446         * python/py-frame.c: Update.
1447         * python/py-framefilter.c: Update.
1448         * python/py-gdb-readline.c: Update.
1449         * python/py-inferior.c: Update.
1450         * python/py-infthread.c: Update.
1451         * python/py-lazy-string.c: Update.
1452         * python/py-linetable.c: Update.
1453         * python/py-objfile.c: Update.
1454         * python/py-param.c: Update.
1455         * python/py-prettyprint.c: Update.
1456         * python/py-progspace.c: Update.
1457         * python/py-record-btrace.c: Update.
1458         * python/py-record.c: Update.
1459         * python/py-symbol.c: Update.
1460         * python/py-type.c: Update.
1461         * python/py-unwind.c: Update.
1462         * python/py-utils.c: Update.
1463         * python/py-value.c: Update.
1464         * python/python.c: Update.
1465         * record-btrace.c: Update.
1466         * record-full.c: Update.
1467         * remote-fileio.c: Update.
1468         * remote.c: Update.
1469         * riscv-tdep.c: Update.
1470         * rs6000-aix-tdep.c: Update.
1471         * rs6000-tdep.c: Update.
1472         * rust-exp.y: Update.
1473         * rust-lang.c: Update.
1474         * s390-tdep.c: Update.
1475         * selftest-arch.c: Update.
1476         * solib-dsbt.c: Update.
1477         * solib-frv.c: Update.
1478         * solib-spu.c: Update.
1479         * solib-svr4.c: Update.
1480         * solib.c: Update.
1481         * sparc64-linux-tdep.c: Update.
1482         * stack.c: Update.
1483         * symfile-mem.c: Update.
1484         * symmisc.c: Update.
1485         * target.c: Update.
1486         * thread.c: Update.
1487         * top.c: Update.
1488         * tracefile-tfile.c: Update.
1489         * tui/tui.c: Update.
1490         * typeprint.c: Update.
1491         * unittests/cli-utils-selftests.c: Update.
1492         * unittests/parse-connection-spec-selftests.c: Update.
1493         * valops.c: Update.
1494         * valprint.c: Update.
1495         * value.c: Update.
1496         * varobj.c: Update.
1497         * windows-nat.c: Update.
1498         * x86-linux-nat.c: Update.
1499         * xml-support.c: Update.
1500
1501 2019-04-08  Tom Tromey  <tom@tromey.com>
1502
1503         * xml-support.c: Use C++ exception handling.
1504         * x86-linux-nat.c: Use C++ exception handling.
1505         * windows-nat.c: Use C++ exception handling.
1506         * varobj.c: Use C++ exception handling.
1507         * value.c: Use C++ exception handling.
1508         * valprint.c: Use C++ exception handling.
1509         * valops.c: Use C++ exception handling.
1510         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1511         handling.
1512         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1513         * typeprint.c: Use C++ exception handling.
1514         * tui/tui.c: Use C++ exception handling.
1515         * tracefile-tfile.c: Use C++ exception handling.
1516         * top.c: Use C++ exception handling.
1517         * thread.c: Use C++ exception handling.
1518         * target.c: Use C++ exception handling.
1519         * symmisc.c: Use C++ exception handling.
1520         * symfile-mem.c: Use C++ exception handling.
1521         * stack.c: Use C++ exception handling.
1522         * sparc64-linux-tdep.c: Use C++ exception handling.
1523         * solib.c: Use C++ exception handling.
1524         * solib-svr4.c: Use C++ exception handling.
1525         * solib-spu.c: Use C++ exception handling.
1526         * solib-frv.c: Use C++ exception handling.
1527         * solib-dsbt.c: Use C++ exception handling.
1528         * selftest-arch.c: Use C++ exception handling.
1529         * s390-tdep.c: Use C++ exception handling.
1530         * rust-lang.c: Use C++ exception handling.
1531         * rust-exp.y: Use C++ exception handling.
1532         * rs6000-tdep.c: Use C++ exception handling.
1533         * rs6000-aix-tdep.c: Use C++ exception handling.
1534         * riscv-tdep.c: Use C++ exception handling.
1535         * remote.c: Use C++ exception handling.
1536         * remote-fileio.c: Use C++ exception handling.
1537         * record-full.c: Use C++ exception handling.
1538         * record-btrace.c: Use C++ exception handling.
1539         * python/python.c: Use C++ exception handling.
1540         * python/py-value.c: Use C++ exception handling.
1541         * python/py-utils.c: Use C++ exception handling.
1542         * python/py-unwind.c: Use C++ exception handling.
1543         * python/py-type.c: Use C++ exception handling.
1544         * python/py-symbol.c: Use C++ exception handling.
1545         * python/py-record.c: Use C++ exception handling.
1546         * python/py-record-btrace.c: Use C++ exception handling.
1547         * python/py-progspace.c: Use C++ exception handling.
1548         * python/py-prettyprint.c: Use C++ exception handling.
1549         * python/py-param.c: Use C++ exception handling.
1550         * python/py-objfile.c: Use C++ exception handling.
1551         * python/py-linetable.c: Use C++ exception handling.
1552         * python/py-lazy-string.c: Use C++ exception handling.
1553         * python/py-infthread.c: Use C++ exception handling.
1554         * python/py-inferior.c: Use C++ exception handling.
1555         * python/py-gdb-readline.c: Use C++ exception handling.
1556         * python/py-framefilter.c: Use C++ exception handling.
1557         * python/py-frame.c: Use C++ exception handling.
1558         * python/py-finishbreakpoint.c: Use C++ exception handling.
1559         * python/py-cmd.c: Use C++ exception handling.
1560         * python/py-breakpoint.c: Use C++ exception handling.
1561         * python/py-arch.c: Use C++ exception handling.
1562         * printcmd.c: Use C++ exception handling.
1563         * ppc-linux-tdep.c: Use C++ exception handling.
1564         * parse.c: Use C++ exception handling.
1565         * p-valprint.c: Use C++ exception handling.
1566         * objc-lang.c: Use C++ exception handling.
1567         * mi/mi-main.c: Use C++ exception handling.
1568         * mi/mi-interp.c: Use C++ exception handling.
1569         * mi/mi-cmd-stack.c: Use C++ exception handling.
1570         * mi/mi-cmd-break.c: Use C++ exception handling.
1571         * main.c: Use C++ exception handling.
1572         * linux-thread-db.c: Use C++ exception handling.
1573         * linux-tdep.c: Use C++ exception handling.
1574         * linux-nat.c: Use C++ exception handling.
1575         * linux-fork.c: Use C++ exception handling.
1576         * linespec.c: Use C++ exception handling.
1577         * language.c: Use C++ exception handling.
1578         * jit.c: Use C++ exception handling.
1579         * infrun.c: Use C++ exception handling.
1580         * infcmd.c: Use C++ exception handling.
1581         * infcall.c: Use C++ exception handling.
1582         * inf-loop.c: Use C++ exception handling.
1583         * i386-tdep.c: Use C++ exception handling.
1584         * i386-linux-tdep.c: Use C++ exception handling.
1585         * guile/scm-value.c: Use C++ exception handling.
1586         * guile/scm-type.c: Use C++ exception handling.
1587         * guile/scm-symtab.c: Use C++ exception handling.
1588         * guile/scm-symbol.c: Use C++ exception handling.
1589         * guile/scm-pretty-print.c: Use C++ exception handling.
1590         * guile/scm-ports.c: Use C++ exception handling.
1591         * guile/scm-param.c: Use C++ exception handling.
1592         * guile/scm-math.c: Use C++ exception handling.
1593         * guile/scm-lazy-string.c: Use C++ exception handling.
1594         * guile/scm-frame.c: Use C++ exception handling.
1595         * guile/scm-disasm.c: Use C++ exception handling.
1596         * guile/scm-cmd.c: Use C++ exception handling.
1597         * guile/scm-breakpoint.c: Use C++ exception handling.
1598         * guile/scm-block.c: Use C++ exception handling.
1599         * guile/guile-internal.h: Use C++ exception handling.
1600         * gnu-v3-abi.c: Use C++ exception handling.
1601         * gdbtypes.c: Use C++ exception handling.
1602         * frame.c: Use C++ exception handling.
1603         * frame-unwind.c: Use C++ exception handling.
1604         * fbsd-tdep.c: Use C++ exception handling.
1605         * f-valprint.c: Use C++ exception handling.
1606         * exec.c: Use C++ exception handling.
1607         * event-top.c: Use C++ exception handling.
1608         * event-loop.c: Use C++ exception handling.
1609         * eval.c: Use C++ exception handling.
1610         * dwarf2read.c: Use C++ exception handling.
1611         * dwarf2loc.c: Use C++ exception handling.
1612         * dwarf2-frame.c: Use C++ exception handling.
1613         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1614         * dwarf-index-write.c: Use C++ exception handling.
1615         * dwarf-index-cache.c: Use C++ exception handling.
1616         * dtrace-probe.c: Use C++ exception handling.
1617         * disasm-selftests.c: Use C++ exception handling.
1618         * darwin-nat.c: Use C++ exception handling.
1619         * cp-valprint.c: Use C++ exception handling.
1620         * cp-support.c: Use C++ exception handling.
1621         * cp-abi.c: Use C++ exception handling.
1622         * corelow.c: Use C++ exception handling.
1623         * completer.c: Use C++ exception handling.
1624         * compile/compile-object-run.c: Use C++ exception handling.
1625         * compile/compile-object-load.c: Use C++ exception handling.
1626         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1627         * compile/compile-c-symbols.c: Use C++ exception handling.
1628         * common/selftest.c: Use C++ exception handling.
1629         * common/new-op.c: Use C++ exception handling.
1630         * cli/cli-script.c: Use C++ exception handling.
1631         * cli/cli-interp.c: Use C++ exception handling.
1632         * cli/cli-cmds.c: Use C++ exception handling.
1633         * c-varobj.c: Use C++ exception handling.
1634         * btrace.c: Use C++ exception handling.
1635         * breakpoint.c: Use C++ exception handling.
1636         * break-catch-throw.c: Use C++ exception handling.
1637         * arch-utils.c: Use C++ exception handling.
1638         * amd64-tdep.c: Use C++ exception handling.
1639         * ada-valprint.c: Use C++ exception handling.
1640         * ada-typeprint.c: Use C++ exception handling.
1641         * ada-lang.c: Use C++ exception handling.
1642         * aarch64-tdep.c: Use C++ exception handling.
1643
1644 2019-04-08  Tom Tromey  <tom@tromey.com>
1645
1646         * xml-support.c (gdb_xml_parser::parse): Update.
1647         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1648         * value.c (show_convenience): Update.
1649         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1650         (test_parse_flags_qcs): Update.
1651         * thread.c (thr_try_catch_cmd): Update.
1652         * target.c (target_translate_tls_address): Update.
1653         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1654         (info_frame_command_core, frame_apply_command_count): Update.
1655         * rust-exp.y (rust_lex_exception_test): Update.
1656         * riscv-tdep.c (riscv_print_one_register_info): Update.
1657         * remote.c (remote_target::enable_btrace): Update.
1658         * record-btrace.c (record_btrace_enable_warn): Update.
1659         * python/py-utils.c (gdbpy_convert_exception): Update.
1660         * printcmd.c (do_one_display, print_variable_and_value): Update.
1661         * mi/mi-main.c (mi_print_exception): Update.
1662         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1663         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1664         * linux-nat.c (linux_nat_target::attach): Update.
1665         * linux-fork.c (class scoped_switch_fork_info): Update.
1666         * infrun.c (displaced_step_prepare): Update.
1667         * infcall.c (call_function_by_hand_dummy): Update.
1668         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1669         * gnu-v3-abi.c (print_one_vtable): Update.
1670         * frame.c (get_prev_frame_always): Update.
1671         * f-valprint.c (info_common_command_for_block): Update.
1672         * exec.c (try_open_exec_file): Update.
1673         * exceptions.c (print_exception, exception_print)
1674         (exception_fprintf, exception_print_same): Update.
1675         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1676         * dwarf-index-cache.c (index_cache::store)
1677         (index_cache::lookup_gdb_index): Update.
1678         * darwin-nat.c (maybe_cache_shell): Update.
1679         * cp-valprint.c (cp_print_value_fields): Update.
1680         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1681         (gcc_cplus_symbol_address): Update.
1682         * compile/compile-c-symbols.c (gcc_convert_symbol)
1683         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1684         * common/selftest.c: Update.
1685         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1686         a std::string.
1687         (exception_try_scope_entry, exception_try_scope_exit): Don't
1688         declare.
1689         (struct exception_try_scope): Remove.
1690         (TRY): Don't use exception_try_scope.
1691         (struct gdb_exception): Add constructor, operator=.
1692         <what>: New method.
1693         (struct gdb_exception_RETURN_MASK_ALL)
1694         (struct gdb_exception_RETURN_MASK_ERROR)
1695         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1696         (struct gdb_quit_bad_alloc): Update.
1697         * common/common-exceptions.c (exception_none): Change
1698         initializer.
1699         (struct catcher) <state, exception>: Initialize inline.
1700         <prev>: Remove member.
1701         (current_catcher): Remove.
1702         (catchers): New global.
1703         (exceptions_state_mc_init): Simplify.
1704         (catcher_pop): Remove.
1705         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1706         (try_scope_depth, exception_try_scope_entry)
1707         (exception_try_scope_exit): Remove.
1708         (throw_exception_sjlj): Update.
1709         (exception_messages, exception_messages_size): Remove.
1710         (throw_it): Simplify.
1711         (gdb_exception_sliced_copy): Remove.
1712         (throw_exception_cxx): Update.
1713         * cli/cli-script.c (script_from_file): Update.
1714         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1715         Update.
1716         * ada-valprint.c (ada_val_print): Update.
1717         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1718         (create_excep_cond_exprs): Update.
1719
1720 2019-04-08  Tom Tromey  <tom@tromey.com>
1721
1722         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1723         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1724         (TRY, CATCH, END_CATCH): Remove some definitions.
1725         * common/common-exceptions.c: Don't use GDB_XCPT.
1726         (catcher_list_size): Remove.
1727         (throw_exception, throw_it): Simplify.
1728
1729 2019-04-05  Tom Tromey  <tom@tromey.com>
1730
1731         Revert the header-sorting patch.
1732         * ft32-tdep.c: Revert.
1733         * frv-tdep.c: Revert.
1734         * frv-linux-tdep.c: Revert.
1735         * frame.c: Revert.
1736         * frame-unwind.c: Revert.
1737         * frame-base.c: Revert.
1738         * fork-child.c: Revert.
1739         * findvar.c: Revert.
1740         * findcmd.c: Revert.
1741         * filesystem.c: Revert.
1742         * filename-seen-cache.h: Revert.
1743         * filename-seen-cache.c: Revert.
1744         * fbsd-tdep.c: Revert.
1745         * fbsd-nat.h: Revert.
1746         * fbsd-nat.c: Revert.
1747         * f-valprint.c: Revert.
1748         * f-typeprint.c: Revert.
1749         * f-lang.c: Revert.
1750         * extension.h: Revert.
1751         * extension.c: Revert.
1752         * extension-priv.h: Revert.
1753         * expprint.c: Revert.
1754         * exec.h: Revert.
1755         * exec.c: Revert.
1756         * exceptions.c: Revert.
1757         * event-top.c: Revert.
1758         * event-loop.c: Revert.
1759         * eval.c: Revert.
1760         * elfread.c: Revert.
1761         * dwarf2read.h: Revert.
1762         * dwarf2read.c: Revert.
1763         * dwarf2loc.c: Revert.
1764         * dwarf2expr.h: Revert.
1765         * dwarf2expr.c: Revert.
1766         * dwarf2-frame.c: Revert.
1767         * dwarf2-frame-tailcall.c: Revert.
1768         * dwarf-index-write.h: Revert.
1769         * dwarf-index-write.c: Revert.
1770         * dwarf-index-common.c: Revert.
1771         * dwarf-index-cache.h: Revert.
1772         * dwarf-index-cache.c: Revert.
1773         * dummy-frame.c: Revert.
1774         * dtrace-probe.c: Revert.
1775         * disasm.h: Revert.
1776         * disasm.c: Revert.
1777         * disasm-selftests.c: Revert.
1778         * dictionary.c: Revert.
1779         * dicos-tdep.c: Revert.
1780         * demangle.c: Revert.
1781         * dcache.h: Revert.
1782         * dcache.c: Revert.
1783         * darwin-nat.h: Revert.
1784         * darwin-nat.c: Revert.
1785         * darwin-nat-info.c: Revert.
1786         * d-valprint.c: Revert.
1787         * d-namespace.c: Revert.
1788         * d-lang.c: Revert.
1789         * ctf.c: Revert.
1790         * csky-tdep.c: Revert.
1791         * csky-linux-tdep.c: Revert.
1792         * cris-tdep.c: Revert.
1793         * cris-linux-tdep.c: Revert.
1794         * cp-valprint.c: Revert.
1795         * cp-support.c: Revert.
1796         * cp-namespace.c: Revert.
1797         * cp-abi.c: Revert.
1798         * corelow.c: Revert.
1799         * corefile.c: Revert.
1800         * continuations.c: Revert.
1801         * completer.h: Revert.
1802         * completer.c: Revert.
1803         * complaints.c: Revert.
1804         * coffread.c: Revert.
1805         * coff-pe-read.c: Revert.
1806         * cli-out.h: Revert.
1807         * cli-out.c: Revert.
1808         * charset.c: Revert.
1809         * c-varobj.c: Revert.
1810         * c-valprint.c: Revert.
1811         * c-typeprint.c: Revert.
1812         * c-lang.c: Revert.
1813         * buildsym.c: Revert.
1814         * buildsym-legacy.c: Revert.
1815         * build-id.h: Revert.
1816         * build-id.c: Revert.
1817         * btrace.c: Revert.
1818         * bsd-uthread.c: Revert.
1819         * breakpoint.h: Revert.
1820         * breakpoint.c: Revert.
1821         * break-catch-throw.c: Revert.
1822         * break-catch-syscall.c: Revert.
1823         * break-catch-sig.c: Revert.
1824         * blockframe.c: Revert.
1825         * block.c: Revert.
1826         * bfin-tdep.c: Revert.
1827         * bfin-linux-tdep.c: Revert.
1828         * bfd-target.c: Revert.
1829         * bcache.c: Revert.
1830         * ax-general.c: Revert.
1831         * ax-gdb.h: Revert.
1832         * ax-gdb.c: Revert.
1833         * avr-tdep.c: Revert.
1834         * auxv.c: Revert.
1835         * auto-load.c: Revert.
1836         * arm-wince-tdep.c: Revert.
1837         * arm-tdep.c: Revert.
1838         * arm-symbian-tdep.c: Revert.
1839         * arm-pikeos-tdep.c: Revert.
1840         * arm-obsd-tdep.c: Revert.
1841         * arm-nbsd-tdep.c: Revert.
1842         * arm-nbsd-nat.c: Revert.
1843         * arm-linux-tdep.c: Revert.
1844         * arm-linux-nat.c: Revert.
1845         * arm-fbsd-tdep.c: Revert.
1846         * arm-fbsd-nat.c: Revert.
1847         * arm-bsd-tdep.c: Revert.
1848         * arch-utils.c: Revert.
1849         * arc-tdep.c: Revert.
1850         * arc-newlib-tdep.c: Revert.
1851         * annotate.h: Revert.
1852         * annotate.c: Revert.
1853         * amd64-windows-tdep.c: Revert.
1854         * amd64-windows-nat.c: Revert.
1855         * amd64-tdep.c: Revert.
1856         * amd64-sol2-tdep.c: Revert.
1857         * amd64-obsd-tdep.c: Revert.
1858         * amd64-obsd-nat.c: Revert.
1859         * amd64-nbsd-tdep.c: Revert.
1860         * amd64-nbsd-nat.c: Revert.
1861         * amd64-nat.c: Revert.
1862         * amd64-linux-tdep.c: Revert.
1863         * amd64-linux-nat.c: Revert.
1864         * amd64-fbsd-tdep.c: Revert.
1865         * amd64-fbsd-nat.c: Revert.
1866         * amd64-dicos-tdep.c: Revert.
1867         * amd64-darwin-tdep.c: Revert.
1868         * amd64-bsd-nat.c: Revert.
1869         * alpha-tdep.c: Revert.
1870         * alpha-obsd-tdep.c: Revert.
1871         * alpha-nbsd-tdep.c: Revert.
1872         * alpha-mdebug-tdep.c: Revert.
1873         * alpha-linux-tdep.c: Revert.
1874         * alpha-linux-nat.c: Revert.
1875         * alpha-bsd-tdep.c: Revert.
1876         * alpha-bsd-nat.c: Revert.
1877         * aix-thread.c: Revert.
1878         * agent.c: Revert.
1879         * addrmap.c: Revert.
1880         * ada-varobj.c: Revert.
1881         * ada-valprint.c: Revert.
1882         * ada-typeprint.c: Revert.
1883         * ada-tasks.c: Revert.
1884         * ada-lang.c: Revert.
1885         * aarch64-tdep.c: Revert.
1886         * aarch64-ravenscar-thread.c: Revert.
1887         * aarch64-newlib-tdep.c: Revert.
1888         * aarch64-linux-tdep.c: Revert.
1889         * aarch64-linux-nat.c: Revert.
1890         * aarch64-fbsd-tdep.c: Revert.
1891         * aarch64-fbsd-nat.c: Revert.
1892         * aarch32-linux-nat.c: Revert.
1893
1894 2019-04-05  Tom Tromey  <tom@tromey.com>
1895
1896         * ft32-tdep.c: Sort headers.
1897         * frv-tdep.c: Sort headers.
1898         * frv-linux-tdep.c: Sort headers.
1899         * frame.c: Sort headers.
1900         * frame-unwind.c: Sort headers.
1901         * frame-base.c: Sort headers.
1902         * fork-child.c: Sort headers.
1903         * findvar.c: Sort headers.
1904         * findcmd.c: Sort headers.
1905         * filesystem.c: Sort headers.
1906         * filename-seen-cache.h: Sort headers.
1907         * filename-seen-cache.c: Sort headers.
1908         * fbsd-tdep.c: Sort headers.
1909         * fbsd-nat.h: Sort headers.
1910         * fbsd-nat.c: Sort headers.
1911         * f-valprint.c: Sort headers.
1912         * f-typeprint.c: Sort headers.
1913         * f-lang.c: Sort headers.
1914         * extension.h: Sort headers.
1915         * extension.c: Sort headers.
1916         * extension-priv.h: Sort headers.
1917         * expprint.c: Sort headers.
1918         * exec.h: Sort headers.
1919         * exec.c: Sort headers.
1920         * exceptions.c: Sort headers.
1921         * event-top.c: Sort headers.
1922         * event-loop.c: Sort headers.
1923         * eval.c: Sort headers.
1924         * elfread.c: Sort headers.
1925         * dwarf2read.h: Sort headers.
1926         * dwarf2read.c: Sort headers.
1927         * dwarf2loc.c: Sort headers.
1928         * dwarf2expr.h: Sort headers.
1929         * dwarf2expr.c: Sort headers.
1930         * dwarf2-frame.c: Sort headers.
1931         * dwarf2-frame-tailcall.c: Sort headers.
1932         * dwarf-index-write.h: Sort headers.
1933         * dwarf-index-write.c: Sort headers.
1934         * dwarf-index-common.c: Sort headers.
1935         * dwarf-index-cache.h: Sort headers.
1936         * dwarf-index-cache.c: Sort headers.
1937         * dummy-frame.c: Sort headers.
1938         * dtrace-probe.c: Sort headers.
1939         * disasm.h: Sort headers.
1940         * disasm.c: Sort headers.
1941         * disasm-selftests.c: Sort headers.
1942         * dictionary.c: Sort headers.
1943         * dicos-tdep.c: Sort headers.
1944         * demangle.c: Sort headers.
1945         * dcache.h: Sort headers.
1946         * dcache.c: Sort headers.
1947         * darwin-nat.h: Sort headers.
1948         * darwin-nat.c: Sort headers.
1949         * darwin-nat-info.c: Sort headers.
1950         * d-valprint.c: Sort headers.
1951         * d-namespace.c: Sort headers.
1952         * d-lang.c: Sort headers.
1953         * ctf.c: Sort headers.
1954         * csky-tdep.c: Sort headers.
1955         * csky-linux-tdep.c: Sort headers.
1956         * cris-tdep.c: Sort headers.
1957         * cris-linux-tdep.c: Sort headers.
1958         * cp-valprint.c: Sort headers.
1959         * cp-support.c: Sort headers.
1960         * cp-namespace.c: Sort headers.
1961         * cp-abi.c: Sort headers.
1962         * corelow.c: Sort headers.
1963         * corefile.c: Sort headers.
1964         * continuations.c: Sort headers.
1965         * completer.h: Sort headers.
1966         * completer.c: Sort headers.
1967         * complaints.c: Sort headers.
1968         * coffread.c: Sort headers.
1969         * coff-pe-read.c: Sort headers.
1970         * cli-out.h: Sort headers.
1971         * cli-out.c: Sort headers.
1972         * charset.c: Sort headers.
1973         * c-varobj.c: Sort headers.
1974         * c-valprint.c: Sort headers.
1975         * c-typeprint.c: Sort headers.
1976         * c-lang.c: Sort headers.
1977         * buildsym.c: Sort headers.
1978         * buildsym-legacy.c: Sort headers.
1979         * build-id.h: Sort headers.
1980         * build-id.c: Sort headers.
1981         * btrace.c: Sort headers.
1982         * bsd-uthread.c: Sort headers.
1983         * breakpoint.h: Sort headers.
1984         * breakpoint.c: Sort headers.
1985         * break-catch-throw.c: Sort headers.
1986         * break-catch-syscall.c: Sort headers.
1987         * break-catch-sig.c: Sort headers.
1988         * blockframe.c: Sort headers.
1989         * block.c: Sort headers.
1990         * bfin-tdep.c: Sort headers.
1991         * bfin-linux-tdep.c: Sort headers.
1992         * bfd-target.c: Sort headers.
1993         * bcache.c: Sort headers.
1994         * ax-general.c: Sort headers.
1995         * ax-gdb.h: Sort headers.
1996         * ax-gdb.c: Sort headers.
1997         * avr-tdep.c: Sort headers.
1998         * auxv.c: Sort headers.
1999         * auto-load.c: Sort headers.
2000         * arm-wince-tdep.c: Sort headers.
2001         * arm-tdep.c: Sort headers.
2002         * arm-symbian-tdep.c: Sort headers.
2003         * arm-pikeos-tdep.c: Sort headers.
2004         * arm-obsd-tdep.c: Sort headers.
2005         * arm-nbsd-tdep.c: Sort headers.
2006         * arm-nbsd-nat.c: Sort headers.
2007         * arm-linux-tdep.c: Sort headers.
2008         * arm-linux-nat.c: Sort headers.
2009         * arm-fbsd-tdep.c: Sort headers.
2010         * arm-fbsd-nat.c: Sort headers.
2011         * arm-bsd-tdep.c: Sort headers.
2012         * arch-utils.c: Sort headers.
2013         * arc-tdep.c: Sort headers.
2014         * arc-newlib-tdep.c: Sort headers.
2015         * annotate.h: Sort headers.
2016         * annotate.c: Sort headers.
2017         * amd64-windows-tdep.c: Sort headers.
2018         * amd64-windows-nat.c: Sort headers.
2019         * amd64-tdep.c: Sort headers.
2020         * amd64-sol2-tdep.c: Sort headers.
2021         * amd64-obsd-tdep.c: Sort headers.
2022         * amd64-obsd-nat.c: Sort headers.
2023         * amd64-nbsd-tdep.c: Sort headers.
2024         * amd64-nbsd-nat.c: Sort headers.
2025         * amd64-nat.c: Sort headers.
2026         * amd64-linux-tdep.c: Sort headers.
2027         * amd64-linux-nat.c: Sort headers.
2028         * amd64-fbsd-tdep.c: Sort headers.
2029         * amd64-fbsd-nat.c: Sort headers.
2030         * amd64-dicos-tdep.c: Sort headers.
2031         * amd64-darwin-tdep.c: Sort headers.
2032         * amd64-bsd-nat.c: Sort headers.
2033         * alpha-tdep.c: Sort headers.
2034         * alpha-obsd-tdep.c: Sort headers.
2035         * alpha-nbsd-tdep.c: Sort headers.
2036         * alpha-mdebug-tdep.c: Sort headers.
2037         * alpha-linux-tdep.c: Sort headers.
2038         * alpha-linux-nat.c: Sort headers.
2039         * alpha-bsd-tdep.c: Sort headers.
2040         * alpha-bsd-nat.c: Sort headers.
2041         * aix-thread.c: Sort headers.
2042         * agent.c: Sort headers.
2043         * addrmap.c: Sort headers.
2044         * ada-varobj.c: Sort headers.
2045         * ada-valprint.c: Sort headers.
2046         * ada-typeprint.c: Sort headers.
2047         * ada-tasks.c: Sort headers.
2048         * ada-lang.c: Sort headers.
2049         * aarch64-tdep.c: Sort headers.
2050         * aarch64-ravenscar-thread.c: Sort headers.
2051         * aarch64-newlib-tdep.c: Sort headers.
2052         * aarch64-linux-tdep.c: Sort headers.
2053         * aarch64-linux-nat.c: Sort headers.
2054         * aarch64-fbsd-tdep.c: Sort headers.
2055         * aarch64-fbsd-nat.c: Sort headers.
2056         * aarch32-linux-nat.c: Sort headers.
2057
2058 2019-04-04  Tom Tromey  <tom@tromey.com>
2059
2060         * varobj.c (varobj_create): Update.
2061         * rust-exp.y (struct rust_parser) <update_innermost_block,
2062         lookup_symbol>: New methods.
2063         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2064         Rename.
2065         (rust_parser::rust_lookup_type)
2066         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2067         * printcmd.c (display_command, do_one_display): Update.
2068         * parser-defs.h (struct parser_state) <parser_state>: Add
2069         "tracker" parameter.
2070         (block_tracker): New member.
2071         (class innermost_block_tracker) <innermost_block_tracker>: Add
2072         "types" parameter.
2073         <reset>: Remove method.
2074         (innermost_block): Don't declare.
2075         (null_post_parser): Update.
2076         * parse.c (innermost_block): Remove global.
2077         (write_dollar_variable): Update.
2078         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2079         Remove "tracker_types" parameter.
2080         (parse_expression): Add "tracker" parameter.
2081         (parse_expression_for_completion): Update.
2082         (null_post_parser): Add "tracker" parameter.
2083         * p-exp.y: Update rules.
2084         * m2-exp.y: Update rules.
2085         * language.h (struct language_defn) <la_post_parser>: Add
2086         "tracker" parameter.
2087         * go-exp.y: Update rules.
2088         * f-exp.y: Update rules.
2089         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2090         parameter.
2091         * d-exp.y: Update rules.
2092         * c-exp.y: Update rules.
2093         * breakpoint.c (set_breakpoint_condition): Create an
2094         innermost_block_tracker.
2095         (watch_command_1): Likewise.
2096         * ada-lang.c (resolve): Add "tracker" parameter.
2097         (resolve_subexp): Likewise.
2098         * ada-exp.y (write_var_from_sym): Update.
2099
2100 2019-04-04  Tom Tromey  <tom@tromey.com>
2101
2102         * type-stack.h: New file.
2103         * type-stack.c: New file.
2104         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2105         type-stack.h.
2106         (insert_into_type_stack, insert_type, push_type, push_type_int)
2107         (insert_type_address_space, pop_type, pop_type_int)
2108         (pop_typelist, pop_type_stack, append_type_stack)
2109         (push_type_stack, get_type_stack, push_typelist)
2110         (follow_type_instance_flags, follow_types): Don't declare.
2111         * parse.c (type_stack): Remove global.
2112         (parse_exp_in_context): Update.
2113         (insert_into_type_stack, insert_type, push_type, push_type_int)
2114         (insert_type_address_space, pop_type, pop_type_int)
2115         (pop_typelist, pop_type_stack, append_type_stack)
2116         (push_type_stack, get_type_stack, push_typelist)
2117         (follow_type_instance_flags, follow_types): Remove (moved to
2118         type-stack.c).
2119         * f-exp.y (type_stack): New global.
2120         Update rules.
2121         (push_kind_type, f_parse): Update.
2122         * d-exp.y (type_stack): New global.
2123         Update rules.
2124         (d_parse): Update.
2125         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2126         Update rules.
2127         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2128         (HFILES_NO_SRCDIR): Add type-stack.h.
2129
2130 2019-04-04  Tom Tromey  <tom@tromey.com>
2131
2132         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2133         (rust_parser::convert_ast_to_expression, rust_parse)
2134         (rust_lex_test_completion, rust_lex_tests): Update.
2135         * parser-defs.h (struct expr_completion_state): New.
2136         (struct parser_state) <parser_state>: Add completion parameter.
2137         <mark_struct_expression, mark_completion_tag>: New methods.
2138         <parse_completion, m_completion_state>: New members.
2139         (prefixify_expression, null_post_parser): Update.
2140         (mark_struct_expression, mark_completion_tag): Don't declare.
2141         * parse.c (parse_completion, expout_last_struct)
2142         (expout_tag_completion_type, expout_completion_name): Remove
2143         globals.
2144         (parser_state::mark_struct_expression)
2145         (parser_state::mark_completion_tag): Now methods.
2146         (prefixify_expression): Add last_struct parameter.
2147         (prefixify_subexp): Likewise.
2148         (parse_exp_1): Update.
2149         (parse_exp_in_context): Add cstate parameter.  Update.
2150         (parse_expression_for_completion): Create an
2151         expr_completion_state.
2152         (null_post_parser): Add "completion" parameter.
2153         * p-exp.y: Update rules.
2154         (yylex): Update.
2155         * language.h (struct language_defn) <la_post_parser>: Add
2156         "completing" parameter.
2157         * go-exp.y: Update rules.
2158         (lex_one_token): Update.
2159         * expression.h (parse_completion): Don't declare.
2160         * d-exp.y: Update rules.
2161         (lex_one_token): Update rules.
2162         * c-exp.y: Update rules.
2163         (lex_one_token): Update.
2164         * ada-lang.c (resolve): Add "parse_completion" parameter.
2165         (resolve_subexp): Likewise.
2166         (ada_resolve_function): Likewise.
2167
2168 2019-04-04  Tom Tromey  <tom@tromey.com>
2169
2170         * parser-defs.h (struct parser_state) <start_arglist,
2171         end_arglist>: New methods.
2172         <arglist_len, m_funcall_chain>: New members.
2173         (arglist_len, start_arglist, end_arglist): Don't declare.
2174         * parse.c (arglist_len, funcall_chain): Remove global.
2175         (start_arglist, end_arglist): Remove functions.
2176         (parse_exp_in_context): Update.
2177         * p-exp.y: Update rules.
2178         * m2-exp.y: Update rules.
2179         * go-exp.y: Update rules.
2180         * f-exp.y: Update rules.
2181         * d-exp.y: Update rules.
2182         * c-exp.y: Update rules.
2183
2184 2019-04-04  Tom Tromey  <tom@tromey.com>
2185
2186         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2187         lex_operator, push_back>: New methods.
2188         Update all rules.
2189         (rust_parser::lex_hex, lex_escape): Rename and update.
2190         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2191         (rust_parser::lex_operator): Rename and update.
2192         (rust_parser::lex_number, rustyylex, rustyyerror)
2193         (rust_lex_test_init, rust_lex_test_sequence)
2194         (rust_lex_test_push_back, rust_lex_tests): Update.
2195         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2196         parameter.
2197         <lexptr, prev_lexptr>: New members.
2198         (lexptr, prev_lexptr): Don't declare.
2199         * parse.c (lexptr, prev_lexptr): Remove globals.
2200         (parse_exp_in_context): Update.
2201         * p-exp.y (yylex, yyerror): Update.
2202         * m2-exp.y (parse_number, yylex, yyerror): Update.
2203         * go-exp.y (lex_one_token, yyerror): Update.
2204         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2205         * d-exp.y (lex_one_token, yyerror): Update.
2206         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2207         (lex_one_token, yyerror): Update.
2208         * ada-lex.l (YY_INPUT): Update.
2209         (rewind_to_char): Update.
2210         * ada-exp.y (yyerror): Update.
2211
2212 2019-04-04  Tom Tromey  <tom@tromey.com>
2213
2214         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2215         * parser-defs.h (struct parser_state) <parser_state>: Add new
2216         parameter.
2217         <comma_terminates>: New member.
2218         (comma_terminates): Don't declare global.
2219         * parse.c (comma_terminates): Remove global.
2220         (parse_exp_in_context): Update.
2221         * p-exp.y (yylex): Update.
2222         * m2-exp.y (yylex): Update.
2223         * go-exp.y (lex_one_token): Update.
2224         * f-exp.y (yylex): Update.
2225         * d-exp.y (lex_one_token): Update.
2226         * c-exp.y (lex_one_token): Update.
2227         * ada-lex.l: Update.
2228
2229 2019-04-04  Tom Tromey  <tom@tromey.com>
2230
2231         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2232         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2233         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2234         * parser-defs.h (paren_depth): Don't declare.
2235         * parse.c (paren_depth): Remove global.
2236         (parse_exp_in_context): Update.
2237         * p-exp.y (paren_depth): New global.
2238         (pascal_parse): Initialize it.
2239         * m2-exp.y (paren_depth): New global.
2240         (m2_parse): Initialize it.
2241         * go-exp.y (paren_depth): New global.
2242         (go_parse): Initialize it.
2243         * f-exp.y (paren_depth): New global.
2244         (f_parse): Initialize it.
2245         * d-exp.y (paren_depth): New global.
2246         (d_parse): Initialize it.
2247         * c-exp.y (paren_depth): New global.
2248         (c_parse): Initialize it.
2249         * ada-lex.l (paren_depth): New global.
2250         (lexer_init): Initialize it.
2251
2252 2019-04-04  Tom Tromey  <tom@tromey.com>
2253
2254         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2255         (rust_parser::convert_ast_to_type)
2256         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2257         * parser-defs.h (struct parser_state) <parser_state>: Add
2258         parameters.  Initialize new members.
2259         <expression_context_block, expression_context_pc>: New members.
2260         * parse.c (expression_context_block, expression_context_pc):
2261         Remove globals.
2262         (parse_exp_in_context): Update.
2263         * p-exp.y: Update all rules.
2264         (yylex): Update.
2265         * m2-exp.y: Update all rules.
2266         (yylex): Update.
2267         * go-exp.y (yylex): Update.
2268         * f-exp.y (yylex): Update.
2269         * d-exp.y: Update all rules.
2270         (yylex): Update.
2271         * c-exp.y: Update all rules.
2272         (lex_one_token, classify_name, yylex, c_parse): Update.
2273         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2274
2275 2019-04-04  Tom Tromey  <tom@tromey.com>
2276
2277         * gdbarch.h, gdbarch.c: Rebuild.
2278         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2279         * stap-probe.h:
2280         (struct stap_parse_info): Replace "parser_state" with
2281         "expr_builder".
2282         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2283         (parser_state): New class.
2284         * parse.c (expr_builder): Rename.
2285         (expr_builder::release): Rename.
2286         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2287         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2288         (write_exp_elt_longcst, write_exp_elt_floatcst)
2289         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2290         (write_exp_string_vector, write_exp_bitstring)
2291         (write_exp_msymbol, mark_struct_expression)
2292         (write_dollar_variable)
2293         (insert_type_address_space, increase_expout_size): Replace
2294         "parser_state" with "expr_builder".
2295         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2296         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2297         "parser_state" with "expr_builder".
2298
2299 2019-04-04  Tom Tromey  <tom@tromey.com>
2300
2301         * rust-exp.y: Replace "parse_language" with method call.
2302         * p-exp.y:
2303         (yylex): Replace "parse_language" with method call.
2304         * m2-exp.y:
2305         (yylex): Replace "parse_language" with method call.
2306         * go-exp.y (classify_name): Replace "parse_language" with method
2307         call.
2308         * f-exp.y (yylex): Replace "parse_language" with method call.
2309         * d-exp.y (lex_one_token): Replace "parse_language" with method
2310         call.
2311         * c-exp.y:
2312         (lex_one_token, classify_name, yylex): Replace "parse_language"
2313         with method call.
2314         * ada-exp.y (find_primitive_type, type_char)
2315         (type_system_address): Replace "parse_language" with method call.
2316
2317 2019-04-04  Tom Tromey  <tom@tromey.com>
2318
2319         * rust-exp.y: Replace "parse_gdbarch" with method call.
2320         * parse.c (write_dollar_variable, insert_type_address_space):
2321         Replace "parse_gdbarch" with method call.
2322         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2323         call.
2324         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2325         call.
2326         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2327         "parse_gdbarch" with method call.
2328         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2329         with method call.
2330         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2331         "parse_gdbarch" with method call.
2332         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2333         "parse_gdbarch" with method call.
2334         * c-exp.y (parse_type, parse_number, classify_name): Replace
2335         "parse_gdbarch" with method call.
2336         * ada-lex.l: Replace "parse_gdbarch" with method call.
2337         * ada-exp.y (parse_type, find_primitive_type, type_char)
2338         (type_system_address): Replace "parse_gdbarch" with method call.
2339
2340 2019-04-04  Tom Tromey  <tom@tromey.com>
2341
2342         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2343         * stap-probe.c (stap_parse_argument): Update.
2344         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2345         initial_size parameter.
2346         * rust-exp.y (rust_lex_tests): Update.
2347         * parse.c (parser_state): Update.
2348         (parse_exp_in_context): Update.
2349         * parser-defs.h (struct parser_state) <parser_state>: Remove
2350         "initial_size" parameter.
2351
2352 2019-04-04  Tom Tromey  <tom@tromey.com>
2353
2354         * parser-defs.h (increase_expout_size): Don't declare.
2355         * parse.c (increase_expout_size): Now static.
2356
2357 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2358
2359         * gnu-nat.c (gnu_nat_target::wait): Fix
2360         target_waitstatus_to_string call.
2361
2362 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * eval.c (evaluate_subexp_standard): Handle internal functions
2365         during Fortran function call handling.
2366
2367 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * NEWS: Mention new internal functions.
2370         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2371         (read_base_type): Use dwarf2_init_complex_target_type.
2372         * value.c (creal_internal_fn): New function.
2373         (cimag_internal_fn): New function.
2374         (_initialize_values): Register new internal functions.
2375
2376 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2377
2378         * infrun.c (stop_all_threads): If debug_infrun, always
2379         trace the wait status after wait_one, using
2380         target_waitstatus_to_string and target_pid_to_str.
2381         (handle_inferior_event): Replace various trace of
2382         wait status kind by a single trace.
2383         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2384         wait status kind image by target_waitstatus_to_string.
2385         * target/waitstatus.c (target_waitstatus_to_string): Fix
2386         obsolete comment.
2387
2388 2019-04-01  Tom Tromey  <tromey@adacore.com>
2389
2390         PR symtab/23331:
2391         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2392
2393 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2394             Pedro Alves  <palves@redhat.com>
2395
2396         * top.c (quit_force): Call 'finalize_values'.
2397         * value.c (finalize_values): New function.
2398         * value.h (finalize_values): Declare.
2399
2400 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2401
2402         * NEWS: Announce $_gdb_major and $_gdb_minor.
2403
2404         * top.c (init_gdb_version_vars): New function.
2405         (gdb_init): Call init_gdb_version_vars.
2406
2407 2019-03-29  Tom Tromey  <tromey@adacore.com>
2408
2409         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2410         help text.  Remove dead code.
2411
2412 2019-03-29  Keith Seitz  <keiths@redhat.com>
2413
2414         From Siddhesh Poyarekar:
2415         * f-lang.h (f77_get_upperbound): Return LONGEST.
2416         (f77_get_lowerbound): Likewise.
2417         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2418         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2419         print them.
2420         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2421         plongest to format print it.
2422         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2423         (f77_get_upperbound): Likewise.
2424         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2425         LOWER_BOUND to LONGEST.
2426         (f77_create_arrayprint_offset_tbl): Likewise.
2427
2428 2019-03-29  Keith Seitz  <keiths@redhat.com>
2429
2430         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2431         %s/pulongest for TYPE_LENGTH instead of %d in format
2432         strings.
2433         * ada-typerint.c (ada_print_type): Likewise.
2434         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2435         * compile/compile-c-support.c (generate_register_struct): Likewise.
2436         * gdbtypes.c (recursive_dump_type): Likewise.
2437         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2438         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2439         instead of %d in format strings.
2440         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2441         to std::min to ULONGEST.
2442         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2443         instead of %d in format strings.
2444         * tracepoint.c (info_scope_command): Likewise.
2445         * typeprint.c (print_offset_data::update)
2446         (print_offset_data::finish): Likewise.
2447         * xtensa-tdep.c (xtensa_store_return_value)
2448         (xtensa_push_dummy_call): Likewise.
2449
2450 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2451
2452         * windows-nat.c (display_selector): Fixed format specifications
2453         for 64-bit Cygwin.
2454
2455 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2456
2457         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2458
2459 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2460
2461         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2462         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2463         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2464         (nios2_linux_init_abi): Install it.
2465
2466 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2467
2468         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2469
2470 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2471
2472         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2473
2474 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2475             Tom Tromey  <tromey@adacore.com>
2476
2477         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2478
2479 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2480
2481         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2482         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2483         method to compute the bounds of range types. Also print "[evaluated]"
2484         if the bounds' values come from a dynamic evaluation.
2485
2486 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2489         whitespace when pretty printing is on.
2490
2491 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2492
2493         * ppc-linux-nat.c: Add include.
2494
2495 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2496
2497         * NEWS: Mention AArch64 Pointer Authentication.
2498
2499 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2500
2501         * arm-linux-nat.c: Add include.
2502
2503 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2504
2505         * source-cache.c (source_cache::get_source_lines): Re-read
2506         fullname after calling open_source_file.
2507
2508 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2509
2510         * NEWS: Mention TLS support for FreeBSD.
2511
2512 2019-03-25  Tom Tromey  <tromey@adacore.com>
2513
2514         * minsyms.c (BUNCH_SIZE): Update comment.
2515         (~minimal_symbol_reader): Remove old comment.
2516         (compact_minimal_symbols): Update comment.
2517         (minimal_symbol_reader::install): Remove old comment.  Update
2518         other comments.
2519
2520 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2521
2522         * s390-linux-nat.c: Add include.
2523
2524 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2525
2526         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2527         Call linux_get_hwcap.
2528         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2529         Likewise.
2530         (aarch64_linux_get_hwcap): Remove function.
2531         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2532         declaration.
2533         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2534         linux_get_hwcap.
2535         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2536         * linux-tdep.c (linux_get_hwcap): Add function.
2537         (linux_get_hwcap2): Likewise.
2538         * linux-tdep.h (linux_get_hwcap): Add declaration.
2539         (linux_get_hwcap2): Likewise.
2540         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2541         (ppc_linux_get_hwcap2): Likewise.
2542         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2543         linux_get_hwcap.
2544         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2545         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2546         (ppc_linux_nat_target::read_description): Likewise.
2547         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2548         * s390-linux-nat.c: Likewise.
2549         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2550
2551 2019-03-24  Tom Tromey  <tom@tromey.com>
2552
2553         * ada-lang.c (standard_lookup): Simplify initialization.
2554         (ada_lookup_symbol_nonlocal): Simplify return.
2555         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2556         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2557         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2558         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2559         initialization.
2560         * solib.c (solib_global_lookup): Simplify.
2561         * symtab.c (null_block_symbol): Remove.
2562         (symbol_cache_lookup): Simplify returns.
2563         (lookup_language_this): Simplify returns.
2564         (lookup_symbol_aux): Simplify return.
2565         (lookup_local_symbol): Simplify returns.
2566         (lookup_global_symbol_from_objfile): Simplify return.
2567         (lookup_symbol_in_objfile_symtabs)
2568         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2569         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2570         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2571         * cp-namespace.c (cp_lookup_bare_symbol)
2572         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2573         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2574         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2575         (cp_lookup_symbol_via_imports): Simplify initialization.
2576         (find_symbol_in_baseclass): Likewise.
2577         * symtab.h (null_block_symbol): Remove.
2578         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2579         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2580         (d_lookup_symbol_module): Likewise.
2581         (find_symbol_in_baseclass): Simplify initialization.
2582
2583 2019-03-24  Tom Tromey  <tom@tromey.com>
2584
2585         * expression.h: Don't include symtab.h.
2586         (struct block): Forward declare.
2587
2588 2019-03-24  Tom Tromey  <tom@tromey.com>
2589
2590         * c-exp.y (typebase): Remove casts.
2591         * gdbtypes.c (lookup_unsigned_typename, )
2592         (lookup_signed_typename): Remove cast.
2593         * eval.c (parse_to_comma_and_eval): Remove cast.
2594         * parse.c (write_dollar_variable): Remove cast.
2595         * block.h (struct block) <superblock>: Now const.
2596         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2597         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2598         (map_block): Make "block" const.
2599         * symfile.h (struct quick_symbol_functions)
2600         <map_matching_symbols>: Constify block argument to "callback".
2601         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2602         const.
2603         (find_pc_sect_compunit_symtab): Make "b" const.
2604         (find_symbol_at_address): Likewise.
2605         (search_symbols): Likewise.
2606         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2607         (dw2_debug_names_lookup_symbol): Likewise.
2608         (dw2_map_matching_symbols): Update.
2609         * p-valprint.c (pascal_val_print): Remove "block".
2610         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2611         (aux_add_nonlocal_symbols): Make "block" const.
2612         (resolve_subexp): Remove cast.
2613         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2614         const.
2615         (iterate_over_file_blocks): Likewise.
2616         * f-exp.y (%union) <bval>: Remove.
2617         * coffread.c (patch_opaque_types): Make "b" const.
2618         * spu-tdep.c (spu_catch_start): Make "block" const.
2619         * c-valprint.c (print_unpacked_pointer): Remove "block".
2620         * symmisc.c (dump_symtab_1): Make "b" const.
2621         (block_depth): Make "block" const.
2622         * d-exp.y (%union) <bval>: Remove.
2623         * cp-support.h (cp_lookup_rtti_type): Update.
2624         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2625         * psymtab.c (psym_lookup_symbol): Make "block" const.
2626         (maintenance_check_psymtabs): Make "b" const.
2627         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2628         (enumerate_locals, enumerate_args): Update.
2629         * python/py-symtab.c (stpy_global_block): Make "block" const.
2630         (stpy_static_block): Likewise.
2631         * inline-frame.c (block_starting_point_at): Make "new_block"
2632         const.
2633         * block.c (find_block_in_blockvector): Make return type const.
2634         (blockvector_for_pc_sect): Make "b" const.
2635         (find_block_in_blockvector): Make "b" const.
2636
2637 2019-03-23  Tom Tromey  <tom@tromey.com>
2638
2639         * varobj.c (varobj_create): Update.
2640         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2641         * printcmd.c (display_command, do_one_display): Don't reset
2642         innermost_block.
2643         * parser-defs.h (enum innermost_block_tracker_type): Move to
2644         expression.h.
2645         (innermost_block): Update comment.
2646         * parse.c (parse_exp_1): Add tracker_types parameter.
2647         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2648         tracker_types parameter.  Reset innermost_block.
2649         (parse_exp_in_context): Remove.
2650         (parse_expression_for_completion): Update.
2651         * objfiles.c (~objfile): Don't reset expression_context_block or
2652         innermost_block.
2653         * expression.h (enum innermost_block_tracker_type): Move from
2654         parser-defs.h.
2655         (parse_exp_1): Add tracker_types parameter.
2656         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2657         reset innermost_block.
2658
2659 2019-03-23  Tom Tromey  <tom@tromey.com>
2660
2661         * objfiles.h: Include bcache.h.
2662
2663 2019-03-23  Tom Tromey  <tom@tromey.com>
2664
2665         * linespec.c (get_current_search_block): Use
2666         scoped_restore_current_language.
2667         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2668
2669 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2670             Jiong Wang  <jiong.wang@arm.com>
2671
2672         * aarch64-linux-tdep.c
2673         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2674         section.
2675         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2676
2677 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2678             Jiong Wang  <jiong.wang@arm.com>
2679
2680         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2681         instructions.
2682         (aarch64_analyze_prologue_test): Add PACIASP test.
2683         (aarch64_prologue_prev_register): Unmask PC value.
2684
2685 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2686             Jiong Wang  <jiong.wang@arm.com>
2687
2688         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2689         (aarch64_dwarf2_prev_register): Unmask PC value.
2690         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2691         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2692         DW_CFA_AARCH64_negate_ra_state.
2693         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2694
2695 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2696             Jiong Wang  <jiong.wang@arm.com>
2697
2698         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2699         registers.
2700         (aarch64_pseudo_register_name): Likewise.
2701         (aarch64_pseudo_register_type): Likewise.
2702         (aarch64_pseudo_register_reggroup_p): Likewise.
2703         (aarch64_gdbarch_init): Add pauth registers.
2704         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2705         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2706         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2707         (struct gdbarch_tdep): Add regnum for ra_state.
2708
2709 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2710             Jiong Wang  <jiong.wang@arm.com>
2711
2712         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2713
2714 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2715             Jiong Wang  <jiong.wang@arm.com>
2716
2717         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2718         function.
2719         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2720         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2721         (aarch64_gdbarch_init): Add puth registers.
2722         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2723         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2724         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2725
2726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2727             Jiong Wang  <jiong.wang@arm.com>
2728
2729         * aarch64-linux-nat.c
2730         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2731         * aarch64-linux-tdep.c
2732         (aarch64_linux_core_read_description): Likewise.
2733         (aarch64_linux_get_hwcap): New function.
2734         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2735         (aarch64_linux_get_hwcap): New declaration.
2736
2737 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2738             Jiong Wang  <jiong.wang@arm.com>
2739
2740         * aarch64-linux-nat.c
2741         (aarch64_linux_nat_target::read_description): Add pauth param.
2742         * aarch64-linux-tdep.c
2743         (aarch64_linux_core_read_description): Likewise.
2744         * aarch64-tdep.c (struct target_desc): Add in pauth.
2745         (aarch64_read_description): Add pauth param.
2746         (aarch64_gdbarch_init): Likewise.
2747         * aarch64-tdep.h (aarch64_read_description): Likewise.
2748         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2749         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2750         * features/Makefile: Add new files.
2751         * features/aarch64-pauth.c: New file.
2752         * features/aarch64-pauth.xml: New file.
2753
2754 2019-03-20  Tom Tromey  <tromey@adacore.com>
2755
2756         * infrun.c (handle_inferior_event): Rename from
2757         handle_inferior_event_1.  Create a scoped_value_mark.
2758         (handle_inferior_event): Remove.
2759
2760 2019-03-19  Tom Tromey  <tromey@adacore.com>
2761
2762         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2763         * infrun.h (print_stop_event): Add "displays" parameter.
2764         * infrun.c (print_stop_event): Add "displays" parameter.
2765
2766 2019-03-19  Pedro Alves  <palves@redhat.com>
2767
2768         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2769         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2770         to -1.  Fix TABs vs spaces.
2771         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2772         * tui/tui-out.h (tui_ui_out) Add intro comments.
2773         <m_line, m_start_of_line>: In-class initialize, and add describing
2774         comment.
2775
2776 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2777
2778         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2779         variable names.
2780         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2781
2782 2019-03-18  Pedro Alves  <palves@redhat.com>
2783             Eli Zaretskii <eliz@gnu.org>
2784
2785         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2786         m_line and m_start_of_line.
2787
2788 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2789
2790         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2791         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2792         it returns a newline.  This fixes a regression in TU mode, whereby
2793         the next line is output on the same screen line as the user input.
2794
2795 2019-03-18  Tom Tromey  <tromey@adacore.com>
2796
2797         * minsyms.c (minimal_symbol_reader::install): Remove call to
2798         obstack_blank.
2799
2800 2019-03-18  Pedro Alves  <palves@redhat.com>
2801
2802         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2803         New globals.
2804         (apply_style): New, factored out from ...
2805         (apply_ansi_escape): ... this.  Handle reverse video mode.
2806         (tui_set_reverse_mode): New function.
2807         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2808         * tui/tui-winsource.c (tui_show_source_line): Use
2809         tui_set_reverse_mode instead of setting A_STANDOUT.
2810         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2811         New setter methods.
2812
2813 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2814
2815         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2816         Handle tabs.
2817
2818 2019-03-18  Tom Tromey  <tromey@adacore.com>
2819
2820         * ada-lang.c (empty_array): Add "high" parameter.
2821         (ada_evaluate_subexp): Update.
2822
2823 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2824
2825         * unittests/string_view-selftests.c: Define
2826         _initialize_string_view_selftests unconditionally.
2827
2828 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2829
2830         PR gdb/24350
2831         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2832
2833 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2834
2835         PR gdb/24351
2836         * windows-nat.c (display_selector): Fix format specifiers.
2837
2838 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2839
2840         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2841         tui_refill_source_window instead of tui_refresh_win, to update the
2842         current execution line.  This fixes redisplay of the current line
2843         when stepping through the code with "next" or "step".
2844
2845 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2846
2847         * source-cache.c (source_cache::get_source_lines): Call
2848         find_source_lines to initialize s->nlines.  This fixes vertical
2849         scrolling of TUI source window when the DOWN arrow is pressed.
2850
2851 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2852
2853         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2854         linux-thread-db.c (_initialize_thread_db): Likewise.
2855
2856 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2857
2858         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2859         wclrtoeol in tui_show_source_line".  This reverts changes made in
2860         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2861
2862 2019-03-15  Tom Tromey  <tom@tromey.com>
2863
2864         * symtab.h (struct minimal_symbol): Derive from
2865         general_symbol_info.
2866         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2867         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2868         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2869         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2870         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2871         (MSYMBOL_SEARCH_NAME): Update.
2872         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2873         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2874         * minsyms.c (minimal_symbol_reader::record_full): Update.
2875
2876 2019-03-15  Tom Tromey  <tom@tromey.com>
2877
2878         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2879
2880 2019-03-15  Tom Tromey  <tom@tromey.com>
2881
2882         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2883         unique_xmalloc_ptr.
2884         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2885         Update.
2886         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2887         (build_minimal_symbol_hash_tables)
2888         (minimal_symbol_reader::install): Update.
2889
2890 2019-03-15  Tom Tromey  <tom@tromey.com>
2891
2892         * symtab.c (create_demangled_names_hash): Update.
2893         (symbol_set_names): Update.
2894         * objfiles.h (struct objfile_per_bfd_storage)
2895         <demangled_names_hash>: Now an htab_up.
2896         * objfiles.c (objfile_per_bfd_storage): Simplify.
2897
2898 2019-03-15  Tom Tromey  <tom@tromey.com>
2899
2900         * objfiles.h (struct objfile_per_bfd_storage): Declare
2901         destructor.
2902         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2903         New.
2904         (get_objfile_bfd_data): Use new.  Don't initialize
2905         language_of_main.
2906         (free_objfile_per_bfd_storage): Remove.
2907         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2908
2909 2019-03-15  Tom Tromey  <tom@tromey.com>
2910
2911         * symfile.c (reread_symbols): Update.
2912         * objfiles.c (objfile::objfile): Update.
2913         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2914         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2915         comment.
2916         (minimal_symbol_reader::install): Update.
2917         (terminate_minimal_symbol_table): Remove.
2918         * jit.c (jit_object_close_impl): Update.
2919
2920 2019-03-15  Tom Tromey  <tom@tromey.com>
2921
2922         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2923         initializations.
2924
2925 2019-03-15  Tom Tromey  <tom@tromey.com>
2926
2927         * objfiles.h (struct objfile_per_bfd_storage)
2928         <demangled_hash_languages>: Now a bitset.
2929         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2930         (lookup_minimal_symbol): Update.
2931
2932 2019-03-15  Tom Tromey  <tom@tromey.com>
2933
2934         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2935         Don't return the symbol.
2936         * coffread.c (record_minimal_symbol): Use record_full.
2937
2938 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2939
2940         The MS-Windows port of ncurses fails to switch to a color pair if
2941         one or both of the colors are the implicit default colors.  This
2942         change records the default colors when TUI is initialized, and
2943         then specifies them explicitly when a color pair uses the default
2944         colors.  This allows color styling in TUI mode on MS-Windows.
2945
2946         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2947         ncurses_norm_attr.
2948         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2949         colors in ncurses_norm_attr.
2950         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2951         "none", replace it with the default color recorded in
2952         ncurses_norm_attr.
2953
2954 2019-03-14  Tom Tromey  <tromey@adacore.com>
2955
2956         * source-cache.h (class source_cache) <get_source_lines>: Return
2957         std::string.
2958         * source-cache.c (source_cache::extract_lines): Handle case where
2959         first_pos==npos.  Return std::string.
2960         (source_cache::get_source_lines): Update.
2961
2962 2019-03-14  Tom Tromey  <tromey@adacore.com>
2963
2964         * NEWS: Add item for "style sources" commands.
2965         * source-cache.c (source_cache::get_source_lines): Check
2966         source_styling.
2967         * cli/cli-style.c (source_styling): New global.
2968         (_initialize_cli_style): Add "style sources" commands.
2969         (show_style_sources): New function.
2970         * cli/cli-style.h (source_styling): Declare.
2971
2972 2019-03-14  Pedro Alves  <palves@redhat.com>
2973             Tom Tromey  <tromey@adacore.com>
2974
2975         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2976         * tui/tui-winsource.c (tui_refill_source_window): New function,
2977         from...
2978         (tui_horizontal_source_scroll): ... here.  Move some logic.
2979         * cli/cli-style.c (set_style_enabled): Notify new observable.
2980         * tui/tui-hooks.c (tui_redisplay_source): New function.
2981         (tui_attach_detach_observers): Attach or detach
2982         tui_redisplay_source.
2983         * observable.h (source_styling_changed): New observable.
2984         * observable.c: Define source_styling_changed observable.
2985
2986 2019-03-13  Tom Tromey  <tromey@adacore.com>
2987
2988         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2989         (i386_gnu_nat_target::store_registers): Update.
2990         * target-debug.h (target_debug_print_std_string): New macro.
2991         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2992         * windows-tdep.c (display_one_tib): Update.
2993         * tui/tui-stack.c (tui_make_status_line): Update.
2994         * top.c (print_inferior_quit_action): Update.
2995         * thread.c (thr_try_catch_cmd): Update.
2996         (add_thread_with_info): Update.
2997         (thread_target_id_str): Update.
2998         (thr_try_catch_cmd): Update.
2999         (thread_command): Update.
3000         (thread_find_command): Update.
3001         * record-btrace.c (record_btrace_target::info_record)
3002         (record_btrace_resume_thread, record_btrace_target::resume)
3003         (record_btrace_cancel_resume, record_btrace_step_thread)
3004         (record_btrace_target::wait, record_btrace_target::wait)
3005         (record_btrace_target::wait, record_btrace_target::stop): Update.
3006         * progspace.c (print_program_space): Update.
3007         * process-stratum-target.c
3008         (process_stratum_target::thread_address_space): Update.
3009         * linux-fork.c (linux_fork_mourn_inferior)
3010         (detach_checkpoint_command, info_checkpoints_command)
3011         (linux_fork_context): Update.
3012         (linux_fork_detach): Update.
3013         (class scoped_switch_fork_info): Update.
3014         (delete_checkpoint_command): Update.
3015         * infrun.c (follow_fork_inferior): Update.
3016         (follow_fork_inferior): Update.
3017         (proceed_after_vfork_done): Update.
3018         (handle_vfork_child_exec_or_exit): Update.
3019         (follow_exec): Update.
3020         (displaced_step_prepare_throw): Update.
3021         (displaced_step_restore): Update.
3022         (start_step_over): Update.
3023         (resume_1): Update.
3024         (clear_proceed_status_thread): Update.
3025         (proceed): Update.
3026         (print_target_wait_results): Update.
3027         (do_target_wait): Update.
3028         (context_switch): Update.
3029         (stop_all_threads): Update.
3030         (restart_threads): Update.
3031         (finish_step_over): Update.
3032         (handle_signal_stop): Update.
3033         (switch_back_to_stepped_thread): Update.
3034         (keep_going_pass_signal): Update.
3035         (print_exited_reason): Update.
3036         (normal_stop): Update.
3037         * inferior.c (inferior_pid_to_str): Change return type.
3038         (print_selected_inferior): Update.
3039         (add_inferior): Update.
3040         (detach_inferior): Update.
3041         * dummy-frame.c (fprint_dummy_frames): Update.
3042         * dcache.c (dcache_info_1): Update.
3043         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3044         (btrace_fetch, btrace_clear): Update.
3045         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3046         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3047         type.
3048         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3049         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3050         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3051         * gdbarch.c, gdbarch.h: Rebuild.
3052         * gdbarch.sh (core_pid_to_str): Change return type.
3053         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3054         return type.
3055         (windows_nat_target::pid_to_str): Change return type.
3056         (windows_delete_thread): Update.
3057         (windows_nat_target::attach): Update.
3058         (windows_nat_target::files_info): Update.
3059         * target-delegates.c: Rebuild.
3060         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3061         return type.
3062         (sol_thread_target::pid_to_str): Change return type.
3063         * remote.c (class remote_target) <pid_to_str>: Change return
3064         type.
3065         (remote_target::pid_to_str): Change return type.
3066         (extended_remote_target::attach, remote_target::remote_stop_ns)
3067         (remote_target::remote_notif_remove_queued_reply)
3068         (remote_target::push_stop_reply, remote_target::disable_btrace):
3069         Update.
3070         (extended_remote_target::attach): Update.
3071         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3072         type.
3073         (gdbsim_target::pid_to_str): Change return type.
3074         * ravenscar-thread.c (struct ravenscar_thread_target)
3075         <pid_to_str>: Change return type.
3076         (ravenscar_thread_target::pid_to_str): Change return type.
3077         * procfs.c (class procfs_target) <pid_to_str>: Change return
3078         type.
3079         (procfs_target::pid_to_str): Change return type.
3080         (procfs_target::attach): Update.
3081         (procfs_target::detach): Update.
3082         (procfs_target::fetch_registers): Update.
3083         (procfs_target::store_registers): Update.
3084         (procfs_target::wait): Update.
3085         (procfs_target::files_info): Update.
3086         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3087         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3088         return type.
3089         (nto_procfs_target::pid_to_str): Change return type.
3090         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3091         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3092         return type.
3093         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3094         (exit_lwp): Update.
3095         (attach_proc_task_lwp_callback, get_detach_signal)
3096         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3097         (linux_nat_target::resume, wait_lwp, stop_callback)
3098         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3099         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3100         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3101         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3102         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3103         type.
3104         (inf_ptrace_target::attach): Update.
3105         (inf_ptrace_target::files_info): Update.
3106         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3107         type.
3108         (go32_nat_target::pid_to_str): Change return type.
3109         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3110         (gnu_nat_target::wait): Update.
3111         (gnu_nat_target::wait): Update.
3112         (gnu_nat_target::resume): Update.
3113         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3114         (fbsd_nat_target::wait): Update.
3115         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3116         type.
3117         (darwin_nat_target::attach): Update.
3118         * corelow.c (class core_target) <pid_to_str>: Change return type.
3119         (core_target::pid_to_str): Change return type.
3120         * target.c (normal_pid_to_str): Change return type.
3121         (default_pid_to_str): Likewise.
3122         (target_pid_to_str): Change return type.
3123         (target_translate_tls_address): Update.
3124         (target_announce_detach): Update.
3125         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3126         return type.
3127         (bsd_uthread_target::pid_to_str): Change return type.
3128         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3129         type.
3130         (bsd_kvm_target::pid_to_str): Change return type.
3131         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3132         return type.
3133         (aix_thread_target::pid_to_str): Change return type.
3134         * target.h (struct target_ops) <pid_to_str>: Change return type.
3135         (target_pid_to_str, normal_pid_to_str): Likewise.
3136         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3137         type.
3138         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3139         type.
3140         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3141         return type.
3142         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3143         type.
3144         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3145         type.
3146         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3147         return type.
3148
3149 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3150
3151         * NEWS: Mention that the new default MI version is 3.  Mention
3152         changes to the output of commands and events that deal with
3153         multi-location breakpoints.
3154         * breakpoint.c: Include "mi/mi-out.h".
3155         (print_one_breakpoint): Change output syntax if using MI version
3156         >= 3.
3157         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3158         New.
3159         (mi_multi_location_breakpoint_output_fixed): New.
3160         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3161         (mi_cmd_fix_multi_location_breakpoint_output): New.
3162         (mi_multi_location_breakpoint_output_fixed): New.
3163         * mi/mi-cmds.c (mi_cmds): Register command
3164         -fix-multi-location-breakpoint-output.
3165         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3166         interpreter "mi".
3167
3168 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3169
3170         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3171         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3172         instantiate mi_ui_out based on interpreter name.
3173         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3174         * mi/mi-main.c (mi_load_progress): Likewise.
3175
3176 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3177
3178         * NEWS: Combine separate "New targets" sections for 8.3.
3179
3180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3181
3182         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3183         (ppcfbsd_init_abi): Install gdbarch
3184         "fetch_tls_load_module_address" and "get_thread_local_address"
3185         methods.
3186
3187 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3188
3189         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3190         (riscv_fbsd_init_abi): Install gdbarch
3191         "fetch_tls_load_module_address" and "get_thread_local_address"
3192         methods.
3193
3194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3195
3196         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3197         (i386fbsd_init_abi): Install gdbarch
3198         "fetch_tls_load_module_address" and "get_thread_local_address"
3199         methods.
3200
3201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3202
3203         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3204         (amd64fbsd_init_abi): Install gdbarch
3205         "fetch_tls_load_module_address" and "get_thread_local_address"
3206         methods.
3207
3208 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3209
3210         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3211         (struct fbsd_pspace_data): New type.
3212         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3213         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3214         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3215         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3216         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3217
3218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3219
3220         * gdbtypes.c (lookup_struct_elt): New function.
3221         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3222         * gdbtypes.h (struct struct_elt): New type.
3223         (lookup_struct_elt): New prototype.
3224
3225 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3226
3227         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3228         remove disabled code block.
3229
3230 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3231
3232         * gdbarch.sh (get_thread_local_address): New method.
3233         * gdbarch.h, gdbarch.c: Regenerate.
3234         * target.c (target_translate_tls_address): Use
3235         gdbarch_get_thread_local_address if present instead of
3236         target::get_thread_local_address.
3237
3238 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3239
3240         * target.h (target::get_thread_local_address): Update comment.
3241
3242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3243
3244         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3245         objfile->separate_debug_objfile_backlink if not NULL.
3246
3247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3248
3249         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3250         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3251         (amd64bsd_store_inferior_registers): Likewise.
3252         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3253         Enable segment base registers.
3254         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3255         PT_GETFSBASE and PT_GETGSBASE.
3256         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3257         PT_SETGSBASE.
3258         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3259         segment base registers.
3260         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3261
3262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3263
3264         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3265         Update calls to i386_target_description to add 'segments'
3266         parameter.
3267         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3268         add segment base registers.
3269         * arch/i386.c (i386_create_target_description): Add 'segments'
3270         parameter to enable segment base registers.
3271         * arch/i386.h (i386_create_target_description): Likewise.
3272         * features/i386/32bit-segments.xml: New file.
3273         * features/i386/32bit-segments.c: Generate.
3274         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3275         call to i386_target_description to add 'segments' parameter.
3276         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3277         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3278         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3279         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3280         if feature is present.
3281         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3282         Add 'segments' parameter to call to i386_target_description.
3283         (i386_target_description): Add 'segments' parameter to enable
3284         segment base registers.
3285         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3286         to call to i386_target_description.
3287         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3288         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3289         Define I386_NUM_REGS.
3290         (i386_target_description): Add 'segments' parameter to enable
3291         segment base registers.
3292
3293 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3294
3295         PR/24325
3296         * source-cache.c: #undef open and close, to avoid unresolved
3297         externals during linking.
3298
3299 2019-03-12  Tom Tromey  <tromey@adacore.com>
3300
3301         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3302         const.  Add initializers.
3303         (_initialize_remote): Don't initialize ptid globals.
3304
3305 2019-03-12  Pedro Alves  <palves@redhat.com>
3306
3307         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3308
3309 2019-03-12  Pedro Alves  <palves@redhat.com>
3310
3311         * cp-name-parser.y (main): Remove unused 'len' variable.
3312
3313 2019-03-12  Tom Tromey  <tromey@adacore.com>
3314
3315         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3316         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3317
3318 2019-03-12  Tom Tromey  <tromey@adacore.com>
3319
3320         * linux-nat.c (iterate_over_lwps): Update.
3321         (stop_callback): Remove parameter.
3322         (stop_wait_callback, detach_callback, resume_set_callback)
3323         (select_singlestep_lwp_callback, set_ignore_sigint)
3324         (status_callback, resumed_callback, resume_clear_callback)
3325         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3326         data parameter.
3327         (linux_nat_target::detach, linux_nat_target::resume)
3328         (linux_stop_and_wait_all_lwps, select_event_lwp)
3329         (linux_nat_filter_event, linux_nat_wait_1)
3330         (linux_nat_target::kill, linux_nat_target::stop)
3331         (linux_nat_target::stop): Update.
3332         (linux_nat_resume_callback): Change type.
3333         (resume_stopped_resumed_lwps, count_events_callback)
3334         (select_event_lwp_callback): Likewise.
3335         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3336         * arm-linux-nat.c (struct update_registers_data): Remove.
3337         (update_registers_callback): Change type.
3338         (arm_linux_insert_hw_breakpoint1): Update.
3339         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3340         parameter.
3341         (x86_linux_dr_set_addr): Update.
3342         (x86_linux_dr_set_control): Update.
3343         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3344         (iterate_over_lwps): Use gdb::function_view.
3345         * nat/aarch64-linux-hw-point.c (struct
3346         aarch64_dr_update_callback_param): Remove.
3347         (debug_reg_change_callback): Change type.
3348         (aarch64_notify_debug_reg_change): Update.
3349         * s390-linux-nat.c (s390_refresh_per_info): Update.
3350
3351 2019-03-11  Tom Tromey  <tromey@adacore.com>
3352
3353         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3354         redundant assignment to "this_cu".
3355
3356 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3357
3358         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3359
3360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3361
3362         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3363         from...
3364         (rank_one_type): ... this.
3365
3366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3367
3368         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3369         from...
3370         (rank_one_type): ... this.
3371
3372 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3373
3374         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3375         from...
3376         (rank_one_type): ... this.
3377
3378 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3379
3380         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3381         from...
3382         (rank_one_type): ... this.
3383
3384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3385
3386         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3387         from...
3388         (rank_one_type): ... this.
3389
3390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3391
3392         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3393         from...
3394         (rank_one_type): ... this.
3395
3396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3397
3398         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3399         from...
3400         (rank_one_type): ... this.
3401
3402 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3403
3404         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3405         from...
3406         (rank_one_type): ... this.
3407
3408 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3409
3410         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3411         from...
3412         (rank_one_type): ... this.
3413
3414 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3415
3416         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3417         from...
3418         (rank_one_type): ... this.
3419
3420 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3421
3422         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3423         from...
3424         (rank_one_type): ... this.
3425
3426 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3427
3428         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3429         from...
3430         (rank_one_type): ... this.
3431
3432 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3433
3434         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3435         inferior-events' shows the example events.
3436
3437 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3438
3439         Support styling on native MS-Windows console
3440
3441         PR/24315
3442         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3443         on MS-Windows if $TERM is not defined.
3444
3445         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3446
3447         * posix-hdep.c (gdb_console_fputs):
3448         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3449         functions.
3450         * ui-file.h (gdb_console_fputs): Add prototype.
3451
3452         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3453         back to fputs only if the former returns zero.
3454
3455 2019-03-07  Tom Tromey  <tom@tromey.com>
3456
3457         * symmisc.c (print_symbol_bcache_statistics): Update.
3458         (print_objfile_statistics): Update.
3459         * symfile.c (allocate_symtab): Update.
3460         * stabsread.c: Don't include bcache.h.
3461         * psymtab.h (struct psymbol_bcache): Don't declare.
3462         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3463         (psymbol_bcache_init, psymbol_bcache_free)
3464         (psymbol_bcache_get_bcache): Don't declare.
3465         * psymtab.c (struct psymbol_bcache): Remove.
3466         (psymtab_storage::psymtab_storage): Update.
3467         (psymtab_storage::~psymtab_storage): Update.
3468         (psymbol_bcache_init, psymbol_bcache_free)
3469         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3470         (add_psymbol_to_bcache): Update.
3471         (allocate_psymtab): Update.
3472         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3473         macro_cache>: No longer pointers.
3474         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3475         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3476         * macrotab.c (macro_bcache): Update.
3477         * macroexp.c: Don't include bcache.h.
3478         * gdbtypes.c (check_types_worklist): Update.
3479         (types_deeply_equal): Remove TRY/CATCH.  Update.
3480         * elfread.c (elf_symtab_read): Update.
3481         * dwarf2read.c: Don't include bcache.h.
3482         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3483         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3484         (print_bcache_statistics, bcache_memory_used): Don't declare.
3485         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3486         methods.  Rename all data members.
3487         * bcache.c (struct bcache): Move to bcache.h.
3488         (bcache::expand_hash_table): Rename from expand_hash_table.
3489         (bcache): Remove.
3490         (bcache::insert): Rename from bcache_full.
3491         (bcache::compare): Rename from bcache_compare.
3492         (bcache_xmalloc): Remove.
3493         (bcache::~bcache): Rename from bcache_xfree.
3494         (bcache::print_statistics): Rename from print_bcache_statistics.
3495         (bcache::memory_used): Rename from bcache_memory_used.
3496
3497 2019-03-07  Pedro Alves  <palves@redhat.com>
3498
3499         * infrun.c (normal_stop): Also check for
3500         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3501
3502 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * f-lang.c (value_from_host_double): Moved to...
3505         * value.c (value_from_host_double): ...here.
3506         * value.h (value_from_host_double): Declare.
3507         * guile/scm-math.c (vlscm_convert_typed_number): Use
3508         value_from_host_double.
3509         (vlscm_convert_number): Likewise.
3510         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3511         * python/py-value.c (convert_value_from_python): Likewise.
3512
3513 2019-03-06  Tom Tromey  <tom@tromey.com>
3514
3515         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3516
3517 2019-03-06  Tom Tromey  <tom@tromey.com>
3518
3519         * utils.h (free_current_contents): Don't declare.
3520         * utils.c (free_current_contents): Remove.
3521
3522 2019-03-06  Tom Tromey  <tom@tromey.com>
3523
3524         * top.c (quit_force): Update.
3525         * main.c (captured_command_loop): Update.
3526         * common/new-op.c (operator new): Update.
3527         * common/common-exceptions.c (struct catcher)
3528         <save_cleanup_chain>: Remove member.
3529         (exceptions_state_mc_init): Update.
3530         (exception_try_scope_entry): Return nullptr.
3531         (exception_try_scope_exit, exception_rethrow)
3532         (throw_exception_sjlj, throw_exception_cxx): Update.
3533         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3534         (all_cleanups, do_cleanups, discard_cleanups)
3535         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3536         (restore_cleanups, restore_final_cleanups): Don't declare.
3537         (do_final_cleanups): Remove parameter.
3538         * common/cleanups.c (cleanup_chain, make_cleanup)
3539         (make_cleanup_dtor, all_cleanups, do_cleanups)
3540         (discard_my_cleanups, discard_cleanups)
3541         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3542         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3543         (null_cleanup): Remove.
3544         (do_final_cleanups): Remove parameter.
3545
3546 2019-03-06  Tom Tromey  <tom@tromey.com>
3547
3548         * remote.c (remote_target::remote_parse_stop_reply): Use
3549         unique_xmalloc_ptr.
3550
3551 2019-03-06  Tom Tromey  <tom@tromey.com>
3552
3553         * stabsread.c (struct stabs_field_info): Rename from field_info.
3554         <list, fnlist>: Add initializers.
3555         <obstack>: New member.
3556         (read_member_functions, read_struct_fields, read_baseclasses):
3557         Allocate on obstack.  Don't use cleanups.
3558         (read_one_struct_field, read_member_functions, read_struct_fields)
3559         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3560         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3561         (read_struct_type): Update.
3562
3563 2019-03-06  Tom Tromey  <tom@tromey.com>
3564
3565         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3566         * common/filestuff.h (make_cleanup_close): Don't declare.
3567         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3568         Remove.
3569
3570 2019-03-06  Tom Tromey  <tom@tromey.com>
3571
3572         * solib-aix.c: Use make_scope_exit.
3573
3574 2019-03-06  Tom Tromey  <tom@tromey.com>
3575
3576         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3577         Use make_scope_exit.
3578
3579 2019-03-06  Tom Tromey  <tom@tromey.com>
3580
3581         * solib-svr4.c (disable_probes_interface): Remove parameter.
3582         (svr4_handle_solib_event): Use make_scope_exit.
3583
3584 2019-03-06  Tom Tromey  <tom@tromey.com>
3585
3586         * remote.c (struct stop_reply_deleter): Remove.
3587         (stop_reply_up): Update.
3588         (struct stop_reply): Derive from notif_event.  Don't typedef.
3589         <regcache>: Now a std::vector.
3590         (stop_reply_xfree): Remove.
3591         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3592         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3593         (remote_target::discard_pending_stop_replies): Use delete.
3594         (remote_target::remote_parse_stop_reply): Update.
3595         (remote_target::process_stop_reply): Update.
3596         * remote-notif.h (struct notif_event): Add virtual destructor.
3597         Remove "dtr" member.
3598         (struct notif_client) <alloc_event>: Return a unique_ptr.
3599         (notif_event_xfree): Don't declare.
3600         (notif_event_up): New typedef.
3601         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3602         (notif_event_xfree, do_notif_event_xfree): Remove.
3603         (remote_notif_state_xfree): Update.
3604
3605 2019-03-06  Tom Tromey  <tom@tromey.com>
3606
3607         * infrun.c (displaced_step_clear_cleanup): Now a
3608         forward_scope_exit type.
3609         (displaced_step_prepare_throw): Update.
3610         (displaced_step_fixup): Update.
3611
3612 2019-03-06  Tom Tromey  <tom@tromey.com>
3613
3614         * inferior.h (class inferior): Update comment.
3615         * gdbthread.h (class thread_info): Update comment.
3616
3617 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3618             Tom Tromey  <tom@tromey.com>
3619
3620         * stabsread.h (struct stab_section_list): Remove.
3621         (coffstab_build_psymtabs): Update.
3622         * dbxread.c (symbuf_sections): Now a std::vector.
3623         (sect_idx): New global.
3624         (fill_symbuf): Update.
3625         (coffstab_build_psymtabs): Change type of stabsects parameter.
3626         Update.
3627         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3628         std::vector.
3629         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3630         (coff_locate_sections): Update.
3631         (coff_symfile_read): Remove cleanups.  Update.
3632         (init_stringtab): Add storage parameter.
3633         (free_stringtab, free_stringtab_cleanup): Remove.
3634         (init_lineno): Add storage parameter.
3635         (free_linetab, free_linetab_cleanup): Remove.
3636
3637 2019-03-06  Pedro Alves  <palves@redhat.com>
3638
3639         * linux-fork.c (fork_info::clobber_regs): Delete.
3640         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3641         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3642         comment.  Adjust.
3643         (scoped_switch_fork_info::scoped_switch_fork_info)
3644         (checkpoint_command, linux_fork_context): Adjust
3645         fork_save_infrun_state calls.
3646
3647 2019-03-06  Pedro Alves  <palves@redhat.com>
3648
3649         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3650         (inf_has_multiple_threads): Return 'bool' and rewrite using
3651         inferior_info::threads().
3652
3653 2019-03-06  Pedro Alves  <palves@redhat.com>
3654
3655         * linux-fork.c: Include <list>.
3656         (fork_list): Now a std::list instance.
3657         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3658         (forks_exist_p, find_last_fork): Adjust.
3659         (new_fork): Delete.
3660         (one_fork_p): New.
3661         (add_fork): Adjust.
3662         (free_fork): Delete, folded into fork_info::~fork_info().
3663         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3664         Adjust.
3665         (init_fork_list): Delete.
3666         (linux_fork_killall, linux_fork_mourn_inferior)
3667         (linux_fork_detach, info_checkpoints_command): Adjust.
3668         (_initialize_linux_fork): No longer call init_fork_list.
3669
3670 2019-03-06  Pedro Alves  <palves@redhat.com>
3671
3672         * linux-fork.c (new_fork): New, split out of ...
3673         (add_fork): ... this.  Return void.  Move "first fork" special
3674         case from here, to ...
3675         (checkpoint_command): ... here.
3676         * linux-linux.h (add_fork): Return void.
3677
3678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3679
3680         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3681
3682 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3683             Chris January  <chris.january@arm.com>
3684             David Lecomber  <david.lecomber@arm.com>
3685
3686         * f-exp.y: New token, UNOP_INTRINSIC.
3687         (exp): New pattern using UNOP_INTRINSIC token.
3688         (f77_keywords): Add 'abs' keyword.
3689         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3690         (value_from_host_double): New function.
3691         (evaluate_subexp_f): Support UNOP_ABS.
3692
3693 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3694
3695         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3696         types.
3697
3698 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3701         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3702         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3703
3704 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3707
3708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3709             Chris January  <chris.january@arm.com>
3710
3711         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3712         * f-exp.y: Define 'KIND' token.
3713         (exp): New pattern for KIND expressions.
3714         (ptype): Handle types with a kind extension.
3715         (direct_abs_decl): Extend to spot kind extensions.
3716         (f77_keywords): Add 'kind' to the list.
3717         (push_kind_type): New function.
3718         (convert_to_kind_type): New function.
3719         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3720         * parse.c (operator_length_standard): Likewise.
3721         * parser-defs.h (enum type_pieces): Add tp_kind.
3722         * std-operator.def: Add UNOP_KIND.
3723
3724 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3725
3726         * f-exp.y (f_parse): Set yydebug.
3727
3728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * f-lang.c (evaluate_subexp_f): New function.
3731         (exp_descriptor_f): New global.
3732         (f_language_defn): Use exp_descriptor_f instead of
3733         exp_descriptor_standard.
3734
3735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3736
3737         * f-exp.y (struct token): Add comments.
3738         (dot_ops): Remove uppercase versions and the end marker.
3739         (f77_keywords): Likewise.
3740         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3741         entries in the dot_ops array are case insensitive, and use
3742         strncasecmp to compare strings.  Also some whitespace cleanup in
3743         this area.  Similar for the f77_keywords array, except entries in
3744         this list might be case sensitive.
3745
3746 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * f-exp.y (struct f77_boolean_val): Add comments.
3749         (boolean_values): Remove uppercase versions, and end marker.
3750         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3751         and use strncasecmp to achieve case insensitivity.  Additionally,
3752         perform whitespace cleanup around this code.
3753
3754 2019-03-06  Tom Tromey  <tromey@adacore.com>
3755
3756         * remote-sim.c (gdbsim_target_open): Use result of
3757         gdb_argv::release.
3758
3759 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3760         Dirk Schubert  <dirk.schubert@arm.com>
3761         Chris January  <chris.january@arm.com>
3762
3763         * eval.c (evaluate_subexp_standard): Call Fortran argument
3764         wrapping logic.
3765         * f-lang.c (struct value): A value which can be passed into a
3766         Fortran function call.
3767         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3768         where appropriate.
3769         (struct type): Value ready for a Fortran function call.
3770         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3771         is needed.
3772         * f-lang.h (fortran_argument_convert): Declaration.
3773         (fortran_preserve_arg_pointer): Declaration.
3774         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3775
3776 2019-03-05  Tom Tromey  <tromey@adacore.com>
3777
3778         * python/py-prettyprint.c (print_string_repr): Remove #if.
3779         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3780
3781 2019-03-05  Tom Tromey  <tromey@adacore.com>
3782
3783         * target.c (the_dummy_target): Move later.  Change type to
3784         "dummy_target".
3785         (initialize_targets): Don't initialize the_dummy_target.
3786
3787 2019-03-05  Tom Tromey  <tromey@adacore.com>
3788
3789         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3790         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3791
3792 2019-03-05  Tom Tromey  <tromey@adacore.com>
3793
3794         * windows-nat.c (windows_nat_target::attach)
3795         (windows_nat_target::detach): Don't call gdb_flush.
3796         * valprint.c (generic_val_print, val_print, val_print_string):
3797         Don't call gdb_flush.
3798         * utils.c (defaulted_query): Don't call gdb_flush.
3799         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3800         * target.c (target_announce_detach): Don't call gdb_flush.
3801         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3802         * remote.c (extended_remote_target::attach): Don't call
3803         gdb_flush.
3804         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3805         * printcmd.c (do_examine): Don't call gdb_flush.
3806         (info_display_command): Don't call gdb_flush.
3807         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3808         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3809         * memattr.c (info_mem_command): Don't call gdb_flush.
3810         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3811         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3812         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3813         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3814         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3815         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3816         (gnu_nat_target::detach): Don't call gdb_flush.
3817         * f-valprint.c (f_val_print): Don't call gdb_flush.
3818         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3819         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3820         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3821         gdb_flush.
3822         * c-valprint.c (c_val_print): Don't call gdb_flush.
3823         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3824
3825 2019-03-05  Tom Tromey  <tromey@adacore.com>
3826
3827         * varobj.c (update_dynamic_varobj_children): Update.
3828         (install_default_visualizer): Use reset, not release.
3829         * value.c (set_internalvar): Update.
3830         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3831         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3832         ATTRIBUTE_UNUSED_RESULT.
3833
3834 2019-03-05  Tom Tromey  <tromey@adacore.com>
3835
3836         * remote.c (class scoped_remote_fd) <release>: Add
3837         ATTRIBUTE_UNUSED_RESULT.
3838
3839 2019-03-05  Tom Tromey  <tromey@adacore.com>
3840
3841         * macroexp.c (struct macro_buffer) <release>: Add
3842         ATTRIBUTE_UNUSED_RESULT.
3843
3844 2019-03-05  Tom Tromey  <tromey@adacore.com>
3845
3846         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3847         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3848         ATTRIBUTE_UNUSED_RESULT.
3849
3850 2019-03-05  Tom Tromey  <tromey@adacore.com>
3851
3852         * common/scoped_fd.h (class scoped_fd) <release>: Add
3853         ATTRIBUTE_UNUSED_RESULT.
3854
3855 2019-03-05  Tom Tromey  <tromey@adacore.com>
3856
3857         * parser-defs.h (struct parser_state) <release>: Add
3858         ATTRIBUTE_UNUSED_RESULT.
3859
3860 2019-03-05  Tom Tromey  <tromey@adacore.com>
3861
3862         * utils.h (class gdb_argv) <release>: Add
3863         ATTRIBUTE_UNUSED_RESULT.
3864         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3865
3866 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3867
3868         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3869         for-loop range, to avoid compiler warnings.
3870
3871         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3872         avoid compiler warnings about unused variables.
3873
3874         * NEWS: Mention end of support for native debugging on MS-Windows
3875         before XP.
3876
3877         PR gdb/24292
3878         * common/netstuff.c:
3879         * gdbserver/gdbreplay.c
3880         * gdbserver/remote-utils.c:
3881         * ser-tcp.c:
3882         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3883         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3884         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3885         'getaddrinfo' and 'freeaddrinfo' were not available before
3886         Windows XP, and mingw.org's MinGW headers by default define
3887         _WIN32_WINNT to 0x500.
3888
3889 2019-03-01  Gary Benson <gbenson@redhat.com>
3890
3891         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3892
3893 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3894             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3895
3896         PR gdb/8527
3897         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3898         set_sigint_trap, clear_sigint_trap.
3899
3900 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3901
3902         * target.c (target_detach): Clear the regcache and the
3903         frame cache.
3904
3905 2019-02-27  Pedro Alves  <palves@redhat.com>
3906
3907         * utils.c (set_screen_size): When we cap the height/width sizes,
3908         tweak the corresponding command variable to show "unlimited":
3909
3910 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3911             Pedro Alves  <palves@redhat.com>
3912
3913         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3914         before calling rl_set_screen_size.
3915
3916 2019-02-27  Tom Tromey  <tromey@adacore.com>
3917
3918         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3919         define.
3920         * python/py-value.c: Remove Python 2.4 workaround.
3921         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3922         workaround.
3923         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3924         Python 2.4 workaround.
3925         * python/python-internal.h: Remove Python 2.4 comment.
3926         (Py_ssize_t): Don't define.
3927         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3928         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3929         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3930         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3931         * python/python.c (do_start_initialization): Remove Python 2.4
3932         workaround.
3933         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3934         (print_children): Remove Python 2.4 workaround.
3935         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3936         workaround.
3937         (CHARBUFFERPROC_NAME): Remove.
3938         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3939         Python 2.4 workaround.
3940
3941 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3942
3943         * NEWS: Note minimum Python version.
3944
3945 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3946
3947         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3948         code from these functions.  Remove corresponding ifdefs.  Use
3949         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3950         Remove gotos and target of gotos.
3951         (infpy_search_memory): Likewise.
3952
3953 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3956         (hppa_gdbarch_init): Don't register deleted functions with
3957         gdbarch.
3958
3959 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3962         (h8300_unwind_sp): Delete.
3963         (h8300_dummy_id): Delete.
3964         (h8300_gdbarch_init): Don't register deleted functions with
3965         gdbarch.
3966
3967 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3968
3969         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3970         (ft32_unwind_pc): Delete.
3971         (ft32_unwind_sp): Delete.
3972         (ft32_gdbarch_init): Don't register deleted functions with
3973         gdbarch.
3974
3975 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3978         (frv_unwind_pc): Delete.
3979         (frv_unwind_sp): Delete.
3980         (frv_gdbarch_init): Don't register deleted functions with
3981         gdbarch.
3982
3983 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3986         (riscv_unwind_pc): Delete.
3987         (riscv_unwind_sp): Delete.
3988         (riscv_gdbarch_init): Don't register deleted functions with
3989         gdbarch.
3990
3991 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3994         (csky_unwind_pc): Delete.
3995         (csky_unwind_sp): Delete.
3996         (csky_gdbarch_init): Don't register deleted functions with
3997         gdbarch.
3998
3999 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4000
4001         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4002         (cris_unwind_pc): Delete.
4003         (cris_unwind_sp): Delete.
4004         (cris_gdbarch_init): Don't register deleted functions with
4005         gdbarch.
4006
4007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4010         (bfin_unwind_pc): Delete.
4011         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4012
4013 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4014
4015         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4016         (arm_unwind_pc): Delete.
4017         (arm_unwind_sp): Delete.
4018         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4019
4020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4021
4022         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4023         (arc_unwind_pc): Delete.
4024         (arc_unwind_sp): Delete.
4025         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4026
4027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4028
4029         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4030         (alpha_unwind_pc): Delete.
4031         (alpha_gdbarch_init): Don't register deleted functions with
4032         gdbarch.
4033
4034 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4035
4036         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4037         (aarch64_unwind_pc): Delete.
4038         (aarch64_unwind_sp): Delete.
4039         (aarch64_gdbarch_init): Don't register deleted functions with
4040         gdbarch.
4041
4042 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4043
4044         * gdbtypes.c (type_align): Don't consider static members when
4045         computing structure alignment.
4046
4047 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4048
4049         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4050         return 0 for other types.
4051         * arch-utils.c (default_type_align): Always return 0.
4052         * gdbarch.h: Regenerate.
4053         * gdbarch.sh (type_align): Extend comment.
4054         * gdbtypes.c (type_align): Add additional comments, always call
4055         gdbarch_type_align before applying the default rules.
4056         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4057         generic code will then apply a suitable default.
4058         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4059         types, return 0 for other types.
4060
4061 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4062
4063         * NEWS: Create a new section for the next release branch.
4064         Rename the section of the current branch, now that it has
4065         been cut.
4066
4067 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4068
4069         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4070         * version.in: Bump version to 8.3.50.DATE-git.
4071
4072 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4073
4074         * aix-thread.c (ptid_cmp): Remove unused variable.
4075         (get_signaled_thread): Likewise.
4076         (store_regs_user_thread): Likewise.
4077         (store_regs_kernel_thread): Likewise.
4078         (fetch_regs_kernel_thread): Remove shadowed variable.
4079
4080 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4081
4082         * features/riscv/32bit-cpu.xml: Add register numbers.
4083         * features/riscv/32bit-fpu.c: Regenerate.
4084         * features/riscv/32bit-fpu.xml: Add register numbers.
4085         * features/riscv/64bit-cpu.xml: Add register numbers.
4086         * features/riscv/64bit-fpu.c: Regenerate.
4087         * features/riscv/64bit-fpu.xml: Add register numbers.
4088
4089 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4090
4091         * NEWS: Mention two argument form of gdb.Value constructor.
4092         * python/py-value.c (convert_buffer_and_type_to_value): New
4093         function.
4094         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4095         Add support for handling an optional second argument.  Call
4096         convert_buffer_and_type_to_value as appropriate.
4097         * python/python-internal.h (Py_buffer_deleter): New struct.
4098         (Py_buffer_up): New typedef.
4099
4100 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4101
4102         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4103         instead of releasing ownership.
4104
4105 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4106
4107         * dwarf2read.c (open_and_init_dwp_file): Call
4108         elf_numsections instead of bfd_count_sections to initialize
4109         dwp_file->num_sections.
4110
4111 2019-02-25  Tom Tromey  <tromey@adacore.com>
4112
4113         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4114
4115 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4116
4117         * gcore.in: Add '--readnever' option when invoking GDB.
4118
4119 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4120
4121         * MAINTAINERS: Update my email address.
4122
4123 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4124
4125         * build-id.c (build_id_to_debug_bfd_1): New function.
4126         (build_id_to_debug_bfd): Look for separate debug file in
4127         sysroot.
4128
4129 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4130
4131         * gdbarch.sh: Update the copyright year range that is placed into
4132         generated files.
4133
4134 2019-02-22  Keith Seitz  <keiths@redhat.com>
4135
4136         PR symtab/23853
4137         * linespec.c (create_sals_line_offset): Search for the default
4138         symtab's filename instead of its fullname.
4139
4140 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4141
4142         * NEWS: Update style defaults.
4143
4144 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4145
4146         * main.c (captured_main_1): Disable styling in batch mode.
4147
4148 2019-02-20  Tom Tromey  <tom@tromey.com>
4149
4150         * symtab.c (symtab_symbol_info): Fix typos.
4151
4152 2019-02-20  Tom Tromey  <tromey@adacore.com>
4153
4154         * findcmd.c (_initialize_mem_search): Use upper case for
4155         metasyntactic variables.
4156
4157 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4158
4159         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4160         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4161
4162 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4163
4164         * top.h (source_file_name): Change to std::string.
4165         * top.c (source_file_name): Likewise.
4166         (command_line_input): Adjust.
4167         * cli/cli-script.c (script_from_file): Adjust.
4168
4169 2019-02-19  Tom Tromey  <tromey@adacore.com>
4170
4171         * ravenscar-thread.c
4172         (ravenscar_thread_target::update_thread_list): Don't call
4173         ada_build_task_list.
4174         * ada-lang.h (ada_build_task_list): Don't declare.
4175         * ada-tasks.c (struct ada_tasks_inferior_data)
4176         <task_list_valid_p>: Now bool.
4177         (read_known_tasks, ada_task_list_changed)
4178         (ada_tasks_invalidate_inferior_data): Update.
4179         (read_known_tasks_array): Return bool.
4180         (read_known_tasks_list): Likewise.
4181         (read_known_tasks): Return void.
4182         (ada_build_task_list): Now static.
4183
4184 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4185
4186         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4187         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4188
4189 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4190
4191         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4192         variant for ada_tasks_pspace_data_handle and
4193         ada_tasks_inferior_data_handle.
4194         (ada_tasks_pspace_data_cleanup): New function.
4195         (ada_tasks_inferior_data_cleanup): New function.
4196
4197 2019-02-17  Tom Tromey  <tom@tromey.com>
4198
4199         * macrotab.h (macro_source_fullname): Return a std::string.
4200         * macrotab.c (macro_include, check_for_redefinition)
4201         (macro_undef, macro_lookup_definition, foreach_macro)
4202         (foreach_macro_in_scope): Update.
4203         (macro_source_fullname): Return a std::string.
4204         * macrocmd.c (show_pp_source_pos): Update.
4205
4206 2019-02-17  Tom Tromey  <tom@tromey.com>
4207
4208         * macrocmd.c (show_pp_source_pos): Style the file names.
4209
4210 2019-02-17  Tom Tromey  <tom@tromey.com>
4211
4212         PR tui/24197:
4213         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4214
4215 2019-02-17  Tom Tromey  <tom@tromey.com>
4216
4217         * ada-lang.c (user_select_syms): Use filtered printing.
4218         * utils.c (wrap_style): New global.
4219         (desired_style): Remove.
4220         (emit_style_escape): Add stream parameter.
4221         (set_output_style, reset_terminal_style, prompt_for_continue):
4222         Update.
4223         (flush_wrap_buffer): Only flush gdb_stdout.
4224         (wrap_here): Set wrap_style.
4225         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4226         treat escape sequences as a character.  Change when wrap buffer is
4227         flushed.
4228         (fputs_styled): Do not set the output style when the default is
4229         requested.
4230         * ui-style.h (struct ui_file_style) <is_default>: New method.
4231         * source.c (print_source_lines_base): Emit escape sequences in one
4232         piece.
4233
4234 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4235
4236         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4237         integers and enumeration types.
4238
4239 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4240
4241         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4242         instead of lookup_symbol_in_language
4243         (do_exact_match): New function.
4244         (ada_get_symbol_name_matcher): Return do_exact_match when
4245         doing a verbatim match.
4246
4247 2019-02-15  Tom Tromey  <tromey@adacore.com>
4248
4249         * ravenscar-thread.c (ravenscar_thread_target::resume)
4250         (ravenscar_thread_target::wait): Special case wildcard requests.
4251
4252 2019-02-15  Tom Tromey  <tromey@adacore.com>
4253
4254         * ravenscar-thread.c (base_ptid): Remove.
4255         (struct ravenscar_thread_target) <close>: New method.
4256         <m_base_ptid>: New member.
4257         <update_inferior_ptid, active_task, task_is_currently_active,
4258         runtime_initialized>: Declare methods.
4259         <ravenscar_thread_target>: Add constructor.
4260         (ravenscar_thread_target::task_is_currently_active)
4261         (ravenscar_thread_target::update_inferior_ptid)
4262         (ravenscar_runtime_initialized): Rename.  Now methods.
4263         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4264         (ravenscar_thread_target::update_thread_list): Update.
4265         (ravenscar_thread_target::active_task): Now method.
4266         (ravenscar_thread_target::store_registers)
4267         (ravenscar_thread_target::prepare_to_store)
4268         (ravenscar_thread_target::prepare_to_store)
4269         (ravenscar_thread_target::mourn_inferior): Update.
4270         (ravenscar_inferior_created): Use "new" to create target.
4271         (ravenscar_thread_target::get_ada_task_ptid): Update.
4272         (_initialize_ravenscar): Don't initialize base_ptid.
4273         (ravenscar_ops): Remove global.
4274
4275 2019-02-15  Tom Tromey  <tromey@adacore.com>
4276
4277         * target.h (push_target): Declare new overload.
4278         * target.c (push_target): New overload, taking an rvalue reference.
4279         * remote.c (remote_target::open_1): Use push_target overload.
4280         * corelow.c (core_target_open): Use push_target overload.
4281
4282 2019-02-15  Tom Tromey  <tromey@adacore.com>
4283
4284         * ravenscar-thread.c (is_ravenscar_task)
4285         (ravenscar_task_is_currently_active): Return bool.
4286         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4287         (_initialize_ravenscar): Remove "(void)".
4288         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4289         Return bool.
4290
4291 2019-02-15  Tom Tromey  <tromey@adacore.com>
4292
4293         * ravenscar-thread.c (ravenscar_runtime_initializer)
4294         (has_ravenscar_runtime, get_running_thread_id)
4295         (ravenscar_thread_target::resume): Fix indentation.
4296
4297 2019-02-15  Tom Tromey  <tromey@adacore.com>
4298
4299         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4300         from ravenscar_arch_ops.
4301         (sparc_ravenscar_ops::fetch_registers)
4302         (sparc_ravenscar_ops::store_registers): Now methods.
4303         (sparc_ravenscar_prepare_to_store): Remove.
4304         (sparc_ravenscar_ops): Redefine.
4305         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4306         methods and destructor.  Remove members.
4307         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4308         (ravenscar_thread_target::store_registers)
4309         (ravenscar_thread_target::prepare_to_store): Update.
4310         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4311         Remove.
4312         (struct ppc_ravenscar_powerpc_ops): Derive from
4313         ravenscar_arch_ops.
4314         (ppc_ravenscar_powerpc_ops::fetch_registers)
4315         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4316         (ppc_ravenscar_powerpc_ops): Redefine.
4317         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4318         (ppc_ravenscar_e500_ops::fetch_registers)
4319         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4320         (ppc_ravenscar_e500_ops): Redefine.
4321         * aarch64-ravenscar-thread.c
4322         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4323         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4324         (aarch64_ravenscar_fetch_registers)
4325         (aarch64_ravenscar_store_registers): Now methods.
4326         (aarch64_ravenscar_ops): Redefine.
4327
4328 2019-02-15  Tom Tromey  <tromey@adacore.com>
4329
4330         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4331         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4332         (ravenscar_thread_target::stopped_by_watchpoint)
4333         (ravenscar_thread_target::stopped_data_address)
4334         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4335
4336 2019-02-15  Tom Tromey  <tromey@adacore.com>
4337
4338         * ravenscar-thread.c: Fix some typos.
4339
4340 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4341             Tom Tromey  <tromey@adacore.com>
4342
4343         * ada-lang.c (ada_exception_sal): Change addr_string to a
4344         std::string.
4345         (create_ada_exception_catchpoint): Update.
4346
4347 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4348             Tom Tromey  <tromey@adacore.com>
4349
4350         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4351         (bp_location_ops): Remove.
4352         (base_breakpoint_allocate_location): Update.
4353         (free_bp_location): Update.
4354         * ada-lang.c (class ada_catchpoint_location)
4355         <ada_catchpoint_location>: Remove ops parameter.
4356         (ada_catchpoint_location_dtor): Remove.
4357         (ada_catchpoint_location_ops): Remove.
4358         (allocate_location_exception): Update.
4359         * breakpoint.h (struct bp_location_ops): Remove.
4360         (class bp_location) <bp_location>: Remove bp_location_ops
4361         parameter.
4362         <~bp_location>: Add destructor.
4363         <ops>: Remove.
4364
4365 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4366             Pedro Alves  <palves@redhat.com>
4367
4368         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4369         'PATH_MAX'.
4370
4371 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4372             Samuel Thibault  <samuel.thibault@gnu.org>
4373             Thomas Schwinge  <thomas@codesourcery.com>
4374
4375         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4376         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4377
4378 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4379
4380         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4381         (check_empty): Use "const char *".
4382
4383         * gnu-nat.c (gnu_nat_target::detach): Instead of
4384         'detach_inferior (pid)' call
4385         'detach_inferior (find_inferior_pid (pid))'.
4386
4387         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4388         'nat/fork-inferior.o'.
4389         * gnu-nat.c: #include "nat/fork-inferior.h".
4390
4391         * gnu-nat.c (gnu_nat_target::detach): Instead of
4392         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4393         * gnu-nat.h: #include "inf-child.h".
4394         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4395         'i386_gnu_nat_target::fetch_registers'.
4396         (gnu_store_registers): Rename/move to
4397         'i386_gnu_nat_target::store_registers'.
4398
4399         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4400         * gnu-nat.h (mach_thread_info): New function.
4401         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4402
4403         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4404
4405 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4406
4407         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4408
4409 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4410
4411         * windows-nat.c (windows_add_thread): Add new parameter
4412         "main_thread_p" with default value set to false.  Update
4413         function documentation as well as all callers.
4414         (windows_delete_thread): Likewise.
4415         (fake_create_process): Update call to windows_add_thread.
4416         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4417         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4418         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4419         call to windows_delete_thread.
4420
4421 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4422
4423         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4424
4425 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4426
4427         * symfile.c (find_separate_debug_file): Use canonical path of
4428         sysroot with child_path instead of gdb_sysroot if it is valid.
4429
4430 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4431
4432         * symfile.c (find_separate_debug_file): Use child_path to
4433         determine if an object file is under a sysroot.
4434
4435 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4436
4437         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4438         unittests/child-path-selftests.c.
4439         * common/pathstuff.c (child_path): New function.
4440         * common/pathstuff.h (child_path): New prototype.
4441         * unittests/child-path-selftests.c: New file.
4442
4443 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4444
4445         * symfile.c (find_separate_debug_file): Look for separate debug
4446         files in debug directories under the sysroot.
4447
4448 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4449
4450         * symtab.h (struct minimal_symbol data_p): New const method.
4451         (struct minimal_symbol text_p): Likewise.
4452         * symtab.c (output_source_filename): Use file name style
4453         to print file name.
4454         (print_symbol_info): Likewise.
4455         (print_msymbol_info): Use address style to print addresses.
4456         Use function name style to print executable text symbols.
4457         (expand_symtab_containing_pc): Use data_p.
4458         (find_pc_sect_compunit_symtab): Likewise.
4459
4460 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4461
4462         * breakpoint.c (describe_other_breakpoints): Use address style
4463         to print addresses.
4464         (say_where): Likewise.
4465
4466 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4467
4468         * ada-typeprint.c (print_func_type): Print function name
4469         style to print function name.
4470         * c-typeprint.c (c_print_type_1): Likewise.
4471
4472 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4473
4474         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4475         for execve.
4476
4477 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4478
4479         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4480         type_stack.
4481
4482 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4483
4484         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4485         TYPE_CODE_REF types.
4486
4487 2019-02-08  Jim Wilson  <jimw@sifive.com>
4488
4489         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4490         (riscv_linux_fregset): New.
4491         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4492
4493 2019-02-07  Tom Tromey  <tom@tromey.com>
4494
4495         * thread.c (thread_cancel_execution_command): Update.
4496         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4497         methods.
4498         (struct thread_fsm_ops): Remove.
4499         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4500         (thread_fsm_should_stop, thread_fsm_return_value)
4501         (thread_fsm_set_finished, thread_fsm_finished_p)
4502         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4503         Don't declare.
4504         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4505         * infrun.c (clear_proceed_status_thread)
4506         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4507         (print_stop_event): Update.
4508         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4509         Add constructor.
4510         (step_command_fsm_ops): Remove.
4511         (new_step_command_fsm): Remove.
4512         (step_1): Update.
4513         (step_command_fsm::should_stop): Rename from
4514         step_command_fsm_should_stop.
4515         (step_command_fsm::clean_up): Rename from
4516         step_command_fsm_clean_up.
4517         (step_command_fsm::do_async_reply_reason): Rename from
4518         step_command_fsm_async_reply_reason.
4519         (struct until_next_fsm): Inherit from thread_fsm.  Add
4520         constructor.
4521         (until_next_fsm_ops): Remove.
4522         (new_until_next_fsm): Remove.
4523         (until_next_fsm::should_stop): Rename from
4524         until_next_fsm_should_stop.
4525         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4526         (until_next_fsm::do_async_reply_reason): Rename from
4527         until_next_fsm_async_reply_reason.
4528         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4529         constructor.  Change type of breakpoint.
4530         (finish_command_fsm_ops): Remove.
4531         (new_finish_command_fsm): Remove.
4532         (finish_command_fsm::should_stop): Rename from
4533         finish_command_fsm_should_stop.
4534         (finish_command_fsm::clean_up): Rename from
4535         finish_command_fsm_clean_up.
4536         (finish_command_fsm::return_value): Rename from
4537         finish_command_fsm_return_value.
4538         (finish_command_fsm::do_async_reply_reason): Rename from
4539         finish_command_fsm_async_reply_reason.
4540         (finish_command): Update.
4541         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4542         Add constructor.
4543         (call_thread_fsm_ops): Remove.
4544         (call_thread_fsm::call_thread_fsm): Rename from
4545         new_call_thread_fsm.
4546         (call_thread_fsm::should_stop): Rename from
4547         call_thread_fsm_should_stop.
4548         (call_thread_fsm::should_notify_stop): Rename from
4549         call_thread_fsm_should_notify_stop.
4550         (run_inferior_call, call_function_by_hand_dummy): Update.
4551         * cli/cli-interp.c (should_print_stop_to_console): Update.
4552         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4553         Add constructor.  Change type of location_breakpoint,
4554         caller_breakpoint.
4555         (until_break_fsm_ops): Remove.
4556         (new_until_break_fsm): Remove.
4557         (until_break_fsm::should_stop): Rename from
4558         until_break_fsm_should_stop.
4559         (until_break_fsm::clean_up): Rename from
4560         until_break_fsm_clean_up.
4561         (until_break_fsm::do_async_reply_reason): Rename from
4562         until_break_fsm_async_reply_reason.
4563         (until_break_command): Update.
4564         * thread-fsm.c: Remove.
4565         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4566
4567 2019-02-07  Tom Tromey  <tom@tromey.com>
4568
4569         * yy-remap.h: Add include guard.
4570         * xtensa-tdep.h: Add include guard.
4571         * xcoffread.h: Rename include guard.
4572         * varobj-iter.h: Add include guard.
4573         * tui/tui.h: Rename include guard.
4574         * tui/tui-winsource.h: Rename include guard.
4575         * tui/tui-wingeneral.h: Rename include guard.
4576         * tui/tui-windata.h: Rename include guard.
4577         * tui/tui-win.h: Rename include guard.
4578         * tui/tui-stack.h: Rename include guard.
4579         * tui/tui-source.h: Rename include guard.
4580         * tui/tui-regs.h: Rename include guard.
4581         * tui/tui-out.h: Rename include guard.
4582         * tui/tui-layout.h: Rename include guard.
4583         * tui/tui-io.h: Rename include guard.
4584         * tui/tui-hooks.h: Rename include guard.
4585         * tui/tui-file.h: Rename include guard.
4586         * tui/tui-disasm.h: Rename include guard.
4587         * tui/tui-data.h: Rename include guard.
4588         * tui/tui-command.h: Rename include guard.
4589         * tic6x-tdep.h: Add include guard.
4590         * target/waitstatus.h: Rename include guard.
4591         * target/wait.h: Rename include guard.
4592         * target/target.h: Rename include guard.
4593         * target/resume.h: Rename include guard.
4594         * target-float.h: Rename include guard.
4595         * stabsread.h: Add include guard.
4596         * rs6000-tdep.h: Add include guard.
4597         * riscv-fbsd-tdep.h: Add include guard.
4598         * regformats/regdef.h: Rename include guard.
4599         * record.h: Rename include guard.
4600         * python/python.h: Rename include guard.
4601         * python/python-internal.h: Rename include guard.
4602         * python/py-stopevent.h: Rename include guard.
4603         * python/py-ref.h: Rename include guard.
4604         * python/py-record.h: Rename include guard.
4605         * python/py-record-full.h: Rename include guard.
4606         * python/py-record-btrace.h: Rename include guard.
4607         * python/py-instruction.h: Rename include guard.
4608         * python/py-events.h: Rename include guard.
4609         * python/py-event.h: Rename include guard.
4610         * procfs.h: Add include guard.
4611         * proc-utils.h: Add include guard.
4612         * p-lang.h: Add include guard.
4613         * or1k-tdep.h: Rename include guard.
4614         * observable.h: Rename include guard.
4615         * nto-tdep.h: Rename include guard.
4616         * nat/x86-linux.h: Rename include guard.
4617         * nat/x86-linux-dregs.h: Rename include guard.
4618         * nat/x86-gcc-cpuid.h: Add include guard.
4619         * nat/x86-dregs.h: Rename include guard.
4620         * nat/x86-cpuid.h: Rename include guard.
4621         * nat/ppc-linux.h: Rename include guard.
4622         * nat/mips-linux-watch.h: Rename include guard.
4623         * nat/linux-waitpid.h: Rename include guard.
4624         * nat/linux-ptrace.h: Rename include guard.
4625         * nat/linux-procfs.h: Rename include guard.
4626         * nat/linux-osdata.h: Rename include guard.
4627         * nat/linux-nat.h: Rename include guard.
4628         * nat/linux-namespaces.h: Rename include guard.
4629         * nat/linux-btrace.h: Rename include guard.
4630         * nat/glibc_thread_db.h: Rename include guard.
4631         * nat/gdb_thread_db.h: Rename include guard.
4632         * nat/gdb_ptrace.h: Rename include guard.
4633         * nat/fork-inferior.h: Rename include guard.
4634         * nat/amd64-linux-siginfo.h: Rename include guard.
4635         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4636         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4637         * nat/aarch64-linux.h: Rename include guard.
4638         * nat/aarch64-linux-hw-point.h: Rename include guard.
4639         * mn10300-tdep.h: Add include guard.
4640         * mips-linux-tdep.h: Add include guard.
4641         * mi/mi-parse.h: Rename include guard.
4642         * mi/mi-out.h: Rename include guard.
4643         * mi/mi-main.h: Rename include guard.
4644         * mi/mi-interp.h: Rename include guard.
4645         * mi/mi-getopt.h: Rename include guard.
4646         * mi/mi-console.h: Rename include guard.
4647         * mi/mi-common.h: Rename include guard.
4648         * mi/mi-cmds.h: Rename include guard.
4649         * mi/mi-cmd-break.h: Rename include guard.
4650         * m2-lang.h: Add include guard.
4651         * location.h: Rename include guard.
4652         * linux-record.h: Rename include guard.
4653         * linux-nat.h: Add include guard.
4654         * linux-fork.h: Add include guard.
4655         * i386-darwin-tdep.h: Rename include guard.
4656         * hppa-linux-offsets.h: Add include guard.
4657         * guile/guile.h: Rename include guard.
4658         * guile/guile-internal.h: Rename include guard.
4659         * gnu-nat.h: Rename include guard.
4660         * gdb-stabs.h: Rename include guard.
4661         * frv-tdep.h: Add include guard.
4662         * f-lang.h: Add include guard.
4663         * event-loop.h: Add include guard.
4664         * darwin-nat.h: Rename include guard.
4665         * cp-abi.h: Rename include guard.
4666         * config/sparc/nm-sol2.h: Rename include guard.
4667         * config/nm-nto.h: Rename include guard.
4668         * config/nm-linux.h: Add include guard.
4669         * config/i386/nm-i386gnu.h: Rename include guard.
4670         * config/djgpp/nl_types.h: Rename include guard.
4671         * config/djgpp/langinfo.h: Rename include guard.
4672         * compile/gcc-cp-plugin.h: Add include guard.
4673         * compile/gcc-c-plugin.h: Add include guard.
4674         * compile/compile.h: Rename include guard.
4675         * compile/compile-object-run.h: Rename include guard.
4676         * compile/compile-object-load.h: Rename include guard.
4677         * compile/compile-internal.h: Rename include guard.
4678         * compile/compile-cplus.h: Rename include guard.
4679         * compile/compile-c.h: Rename include guard.
4680         * common/xml-utils.h: Rename include guard.
4681         * common/x86-xstate.h: Rename include guard.
4682         * common/version.h: Rename include guard.
4683         * common/vec.h: Rename include guard.
4684         * common/tdesc.h: Rename include guard.
4685         * common/selftest.h: Rename include guard.
4686         * common/scoped_restore.h: Rename include guard.
4687         * common/scoped_mmap.h: Rename include guard.
4688         * common/scoped_fd.h: Rename include guard.
4689         * common/safe-iterator.h: Rename include guard.
4690         * common/run-time-clock.h: Rename include guard.
4691         * common/refcounted-object.h: Rename include guard.
4692         * common/queue.h: Rename include guard.
4693         * common/ptid.h: Rename include guard.
4694         * common/print-utils.h: Rename include guard.
4695         * common/preprocessor.h: Rename include guard.
4696         * common/pathstuff.h: Rename include guard.
4697         * common/observable.h: Rename include guard.
4698         * common/netstuff.h: Rename include guard.
4699         * common/job-control.h: Rename include guard.
4700         * common/host-defs.h: Rename include guard.
4701         * common/gdb_wait.h: Rename include guard.
4702         * common/gdb_vecs.h: Rename include guard.
4703         * common/gdb_unlinker.h: Rename include guard.
4704         * common/gdb_unique_ptr.h: Rename include guard.
4705         * common/gdb_tilde_expand.h: Rename include guard.
4706         * common/gdb_sys_time.h: Rename include guard.
4707         * common/gdb_string_view.h: Rename include guard.
4708         * common/gdb_splay_tree.h: Rename include guard.
4709         * common/gdb_setjmp.h: Rename include guard.
4710         * common/gdb_ref_ptr.h: Rename include guard.
4711         * common/gdb_optional.h: Rename include guard.
4712         * common/gdb_locale.h: Rename include guard.
4713         * common/gdb_assert.h: Rename include guard.
4714         * common/filtered-iterator.h: Rename include guard.
4715         * common/filestuff.h: Rename include guard.
4716         * common/fileio.h: Rename include guard.
4717         * common/environ.h: Rename include guard.
4718         * common/common-utils.h: Rename include guard.
4719         * common/common-types.h: Rename include guard.
4720         * common/common-regcache.h: Rename include guard.
4721         * common/common-inferior.h: Rename include guard.
4722         * common/common-gdbthread.h: Rename include guard.
4723         * common/common-exceptions.h: Rename include guard.
4724         * common/common-defs.h: Rename include guard.
4725         * common/common-debug.h: Rename include guard.
4726         * common/cleanups.h: Rename include guard.
4727         * common/buffer.h: Rename include guard.
4728         * common/btrace-common.h: Rename include guard.
4729         * common/break-common.h: Rename include guard.
4730         * cli/cli-utils.h: Rename include guard.
4731         * cli/cli-style.h: Rename include guard.
4732         * cli/cli-setshow.h: Rename include guard.
4733         * cli/cli-script.h: Rename include guard.
4734         * cli/cli-interp.h: Rename include guard.
4735         * cli/cli-decode.h: Rename include guard.
4736         * cli/cli-cmds.h: Rename include guard.
4737         * charset-list.h: Add include guard.
4738         * buildsym-legacy.h: Rename include guard.
4739         * bfin-tdep.h: Add include guard.
4740         * ax.h: Rename include guard.
4741         * arm-linux-tdep.h: Add include guard.
4742         * arm-fbsd-tdep.h: Add include guard.
4743         * arch/xtensa.h: Rename include guard.
4744         * arch/tic6x.h: Add include guard.
4745         * arch/i386.h: Add include guard.
4746         * arch/arm.h: Rename include guard.
4747         * arch/arm-linux.h: Rename include guard.
4748         * arch/arm-get-next-pcs.h: Rename include guard.
4749         * arch/amd64.h: Add include guard.
4750         * arch/aarch64-insn.h: Rename include guard.
4751         * arch-utils.h: Rename include guard.
4752         * annotate.h: Add include guard.
4753         * amd64-darwin-tdep.h: Rename include guard.
4754         * aarch64-linux-tdep.h: Add include guard.
4755         * aarch64-fbsd-tdep.h: Add include guard.
4756         * aarch32-linux-nat.h: Add include guard.
4757
4758 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4759
4760         * macrotab.c (macro_define_internal): New function that
4761         factorizes macro_define_object_internal and macro_define_function
4762         code.
4763         (macro_define_object_internal): Use macro_define_internal.
4764         (macro_define_function): Likewise.
4765
4766 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4767
4768         * macrocmd.c (extract_identifier): Return
4769         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4770         callers.
4771
4772 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4773
4774         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4775
4776 2019-02-05  Tom Tromey  <tom@tromey.com>
4777
4778         * target.c (target_stack::unpush): Move assertion earlier.
4779
4780 2019-01-30  Tom Tromey  <tom@tromey.com>
4781
4782         PR python/23615:
4783         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4784         (gdbpy_parse_and_eval): Likewise.
4785         * python/python-internal.h (gdbpy_allow_threads): New class.
4786
4787 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4788
4789         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4790         (aarch64_fbsd_fpregmap): Move earlier.
4791         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4792         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4793         instead of individual calls to trad_frame_set_reg_addr.
4794         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4795         earlier.
4796         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4797         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4798         instead of individual calls to trad_frame_set_reg_addr.
4799
4800 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4801
4802         * CONTRIBUTE: Replace contribution list with wiki link.
4803
4804 2019-01-25  Tom Tromey  <tom@tromey.com>
4805
4806         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4807
4808 2019-01-25  Tom Tromey  <tom@tromey.com>
4809
4810         * xtensa-linux-nat.c: Fix common/ includes.
4811         * xml-support.h: Fix common/ includes.
4812         * xml-support.c: Fix common/ includes.
4813         * x86-linux-nat.c: Fix common/ includes.
4814         * windows-nat.c: Fix common/ includes.
4815         * varobj.h: Fix common/ includes.
4816         * varobj.c: Fix common/ includes.
4817         * value.c: Fix common/ includes.
4818         * valops.c: Fix common/ includes.
4819         * utils.c: Fix common/ includes.
4820         * unittests/xml-utils-selftests.c: Fix common/ includes.
4821         * unittests/utils-selftests.c: Fix common/ includes.
4822         * unittests/unpack-selftests.c: Fix common/ includes.
4823         * unittests/tracepoint-selftests.c: Fix common/ includes.
4824         * unittests/style-selftests.c: Fix common/ includes.
4825         * unittests/string_view-selftests.c: Fix common/ includes.
4826         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4827         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4828         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4829         * unittests/rsp-low-selftests.c: Fix common/ includes.
4830         * unittests/parse-connection-spec-selftests.c: Fix common/
4831         includes.
4832         * unittests/optional-selftests.c: Fix common/ includes.
4833         * unittests/offset-type-selftests.c: Fix common/ includes.
4834         * unittests/observable-selftests.c: Fix common/ includes.
4835         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4836         * unittests/memrange-selftests.c: Fix common/ includes.
4837         * unittests/memory-map-selftests.c: Fix common/ includes.
4838         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4839         * unittests/function-view-selftests.c: Fix common/ includes.
4840         * unittests/environ-selftests.c: Fix common/ includes.
4841         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4842         * unittests/common-utils-selftests.c: Fix common/ includes.
4843         * unittests/cli-utils-selftests.c: Fix common/ includes.
4844         * unittests/array-view-selftests.c: Fix common/ includes.
4845         * ui-file.c: Fix common/ includes.
4846         * tui/tui-io.c: Fix common/ includes.
4847         * tracepoint.h: Fix common/ includes.
4848         * tracepoint.c: Fix common/ includes.
4849         * tracefile-tfile.c: Fix common/ includes.
4850         * top.h: Fix common/ includes.
4851         * top.c: Fix common/ includes.
4852         * thread.c: Fix common/ includes.
4853         * target/waitstatus.h: Fix common/ includes.
4854         * target/waitstatus.c: Fix common/ includes.
4855         * target.h: Fix common/ includes.
4856         * target.c: Fix common/ includes.
4857         * target-memory.c: Fix common/ includes.
4858         * target-descriptions.c: Fix common/ includes.
4859         * symtab.h: Fix common/ includes.
4860         * symfile.c: Fix common/ includes.
4861         * stap-probe.c: Fix common/ includes.
4862         * spu-linux-nat.c: Fix common/ includes.
4863         * sparc-nat.c: Fix common/ includes.
4864         * source.c: Fix common/ includes.
4865         * solib.c: Fix common/ includes.
4866         * solib-target.c: Fix common/ includes.
4867         * ser-unix.c: Fix common/ includes.
4868         * ser-tcp.c: Fix common/ includes.
4869         * ser-pipe.c: Fix common/ includes.
4870         * ser-base.c: Fix common/ includes.
4871         * selftest-arch.c: Fix common/ includes.
4872         * s12z-tdep.c: Fix common/ includes.
4873         * rust-exp.y: Fix common/ includes.
4874         * rs6000-aix-tdep.c: Fix common/ includes.
4875         * riscv-tdep.c: Fix common/ includes.
4876         * remote.c: Fix common/ includes.
4877         * remote-notif.h: Fix common/ includes.
4878         * remote-fileio.h: Fix common/ includes.
4879         * remote-fileio.c: Fix common/ includes.
4880         * regcache.h: Fix common/ includes.
4881         * regcache.c: Fix common/ includes.
4882         * record-btrace.c: Fix common/ includes.
4883         * python/python.c: Fix common/ includes.
4884         * python/py-type.c: Fix common/ includes.
4885         * python/py-inferior.c: Fix common/ includes.
4886         * progspace.h: Fix common/ includes.
4887         * producer.c: Fix common/ includes.
4888         * procfs.c: Fix common/ includes.
4889         * proc-api.c: Fix common/ includes.
4890         * printcmd.c: Fix common/ includes.
4891         * ppc-linux-nat.c: Fix common/ includes.
4892         * parser-defs.h: Fix common/ includes.
4893         * osdata.c: Fix common/ includes.
4894         * obsd-nat.c: Fix common/ includes.
4895         * nat/x86-linux.c: Fix common/ includes.
4896         * nat/x86-linux-dregs.c: Fix common/ includes.
4897         * nat/x86-dregs.h: Fix common/ includes.
4898         * nat/x86-dregs.c: Fix common/ includes.
4899         * nat/ppc-linux.c: Fix common/ includes.
4900         * nat/mips-linux-watch.h: Fix common/ includes.
4901         * nat/mips-linux-watch.c: Fix common/ includes.
4902         * nat/linux-waitpid.c: Fix common/ includes.
4903         * nat/linux-ptrace.h: Fix common/ includes.
4904         * nat/linux-ptrace.c: Fix common/ includes.
4905         * nat/linux-procfs.c: Fix common/ includes.
4906         * nat/linux-personality.c: Fix common/ includes.
4907         * nat/linux-osdata.c: Fix common/ includes.
4908         * nat/linux-namespaces.c: Fix common/ includes.
4909         * nat/linux-btrace.h: Fix common/ includes.
4910         * nat/linux-btrace.c: Fix common/ includes.
4911         * nat/fork-inferior.c: Fix common/ includes.
4912         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4913         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4914         * nat/aarch64-linux.c: Fix common/ includes.
4915         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4916         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4917         * namespace.h: Fix common/ includes.
4918         * mips-linux-tdep.c: Fix common/ includes.
4919         * minsyms.c: Fix common/ includes.
4920         * mi/mi-parse.h: Fix common/ includes.
4921         * mi/mi-main.c: Fix common/ includes.
4922         * mi/mi-cmd-env.c: Fix common/ includes.
4923         * memrange.h: Fix common/ includes.
4924         * memattr.c: Fix common/ includes.
4925         * maint.h: Fix common/ includes.
4926         * maint.c: Fix common/ includes.
4927         * main.c: Fix common/ includes.
4928         * machoread.c: Fix common/ includes.
4929         * location.c: Fix common/ includes.
4930         * linux-thread-db.c: Fix common/ includes.
4931         * linux-nat.c: Fix common/ includes.
4932         * linux-fork.c: Fix common/ includes.
4933         * inline-frame.c: Fix common/ includes.
4934         * infrun.c: Fix common/ includes.
4935         * inflow.c: Fix common/ includes.
4936         * inferior.h: Fix common/ includes.
4937         * inferior.c: Fix common/ includes.
4938         * infcmd.c: Fix common/ includes.
4939         * inf-ptrace.c: Fix common/ includes.
4940         * inf-child.c: Fix common/ includes.
4941         * ia64-linux-nat.c: Fix common/ includes.
4942         * i387-tdep.c: Fix common/ includes.
4943         * i386-tdep.c: Fix common/ includes.
4944         * i386-linux-tdep.c: Fix common/ includes.
4945         * i386-linux-nat.c: Fix common/ includes.
4946         * i386-go32-tdep.c: Fix common/ includes.
4947         * i386-fbsd-tdep.c: Fix common/ includes.
4948         * i386-fbsd-nat.c: Fix common/ includes.
4949         * guile/scm-type.c: Fix common/ includes.
4950         * guile/guile.c: Fix common/ includes.
4951         * go32-nat.c: Fix common/ includes.
4952         * gnu-nat.c: Fix common/ includes.
4953         * gdbthread.h: Fix common/ includes.
4954         * gdbarch-selftests.c: Fix common/ includes.
4955         * gdb_usleep.c: Fix common/ includes.
4956         * gdb_select.h: Fix common/ includes.
4957         * gdb_bfd.c: Fix common/ includes.
4958         * gcore.c: Fix common/ includes.
4959         * fork-child.c: Fix common/ includes.
4960         * findvar.c: Fix common/ includes.
4961         * fbsd-nat.c: Fix common/ includes.
4962         * event-top.c: Fix common/ includes.
4963         * event-loop.c: Fix common/ includes.
4964         * dwarf2read.c: Fix common/ includes.
4965         * dwarf2loc.c: Fix common/ includes.
4966         * dwarf2-frame.c: Fix common/ includes.
4967         * dwarf-index-cache.c: Fix common/ includes.
4968         * dtrace-probe.c: Fix common/ includes.
4969         * disasm-selftests.c: Fix common/ includes.
4970         * defs.h: Fix common/ includes.
4971         * csky-tdep.c: Fix common/ includes.
4972         * cp-valprint.c: Fix common/ includes.
4973         * cp-support.h: Fix common/ includes.
4974         * cp-support.c: Fix common/ includes.
4975         * corelow.c: Fix common/ includes.
4976         * completer.h: Fix common/ includes.
4977         * completer.c: Fix common/ includes.
4978         * compile/compile.c: Fix common/ includes.
4979         * compile/compile-loc2c.c: Fix common/ includes.
4980         * compile/compile-cplus-types.c: Fix common/ includes.
4981         * compile/compile-cplus-symbols.c: Fix common/ includes.
4982         * command.h: Fix common/ includes.
4983         * cli/cli-dump.c: Fix common/ includes.
4984         * cli/cli-cmds.c: Fix common/ includes.
4985         * charset.c: Fix common/ includes.
4986         * build-id.c: Fix common/ includes.
4987         * btrace.h: Fix common/ includes.
4988         * btrace.c: Fix common/ includes.
4989         * breakpoint.h: Fix common/ includes.
4990         * breakpoint.c: Fix common/ includes.
4991         * ax.h:
4992         (enum agent_op): Fix common/ includes.
4993         * ax-general.c (struct aop_map): Fix common/ includes.
4994         * ax-gdb.c: Fix common/ includes.
4995         * auxv.c: Fix common/ includes.
4996         * auto-load.c: Fix common/ includes.
4997         * arm-tdep.c: Fix common/ includes.
4998         * arch/riscv.c: Fix common/ includes.
4999         * arch/ppc-linux-common.c: Fix common/ includes.
5000         * arch/i386.c: Fix common/ includes.
5001         * arch/arm.c: Fix common/ includes.
5002         * arch/arm-linux.c: Fix common/ includes.
5003         * arch/arm-get-next-pcs.c: Fix common/ includes.
5004         * arch/amd64.c: Fix common/ includes.
5005         * arch/aarch64.c: Fix common/ includes.
5006         * arch/aarch64-insn.c: Fix common/ includes.
5007         * arch-utils.c: Fix common/ includes.
5008         * amd64-windows-tdep.c: Fix common/ includes.
5009         * amd64-tdep.c: Fix common/ includes.
5010         * amd64-sol2-tdep.c: Fix common/ includes.
5011         * amd64-obsd-tdep.c: Fix common/ includes.
5012         * amd64-nbsd-tdep.c: Fix common/ includes.
5013         * amd64-linux-tdep.c: Fix common/ includes.
5014         * amd64-linux-nat.c: Fix common/ includes.
5015         * amd64-fbsd-tdep.c: Fix common/ includes.
5016         * amd64-fbsd-nat.c: Fix common/ includes.
5017         * amd64-dicos-tdep.c: Fix common/ includes.
5018         * amd64-darwin-tdep.c: Fix common/ includes.
5019         * agent.c: Fix common/ includes.
5020         * ada-lang.h: Fix common/ includes.
5021         * ada-lang.c: Fix common/ includes.
5022         * aarch64-tdep.c: Fix common/ includes.
5023
5024 2019-01-25  Tom Tromey  <tom@tromey.com>
5025
5026         * common/create-version.sh: Use common/version.h.
5027
5028 2019-01-24  Pedro Alves  <palves@redhat.com>
5029
5030         * infrun.c (signal_stop, signal_print, signal_program)
5031         (signal_catch, signal_pass): Now arrays instead of pointers.
5032         (update_signals_program_target, do_target_resume)
5033         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5034         * linux-nat.c (linux_nat_target::pass_signals)
5035         (linux_nat_target::create_inferior, linux_nat_target::attach):
5036         Adjust.
5037         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5038         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5039         * procfs.c (procfs_target::pass_signals): Adjust.
5040         * record-full.c (record_full_target::resume): Adjust.
5041         * remote.c (remote_target::pass_signals)
5042         (remote_target::program_signals): Adjust.
5043         * target-debug.h (target_debug_print_signals): Now takes a
5044         gdb::array_view as parameter.  Adjust.
5045         * target.h (target_ops) <pass_signals, program_signals>: Replace
5046         pointer and length parameters with gdb::array_view.
5047         (target_pass_signals, target_program_signals): Likewise.
5048         * target-delegates.c: Regenerate.
5049
5050 2019-01-24  Pedro Alves  <palves@redhat.com>
5051
5052         * common/forward-scope-exit.h
5053         (forward_scope_exit::forward_scope_exit): Pass arguments to
5054         m_bind_function directly, instead of creating a std::bind and
5055         copying that.
5056
5057 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5058
5059         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5060         for static members.
5061         (pass_in_v_vfp_candidate): Likewise.
5062
5063 2019-01-23  Tom Tromey  <tom@tromey.com>
5064             Pedro Alves  <palves@redhat.com>
5065
5066         * regcache.c (class regcache_invalidator): Remove.
5067         (regcache::raw_write): Use make_scope_exit.
5068
5069 2019-01-23  Tom Tromey  <tom@tromey.com>
5070
5071         * ui-out.h (class ui_out_emit_type): Update comment.
5072
5073 2019-01-23  Tom Tromey  <tom@tromey.com>
5074
5075         * infrun.c (fetch_inferior_event): Update comment.
5076
5077 2019-01-23  Tom Tromey  <tom@tromey.com>
5078             Pedro Alves  <palves@redhat.com>
5079
5080         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5081         parameter.
5082         (fetch_inferior_event): Use SCOPE_EXIT.
5083
5084
5085 2019-01-23  Tom Tromey  <tom@tromey.com>
5086             Pedro Alves  <palves@redhat.com>
5087
5088         * infrun.c (disable_thread_events): Delete.
5089         (stop_all_threads): Use SCOPE_EXIT.
5090
5091 2019-01-23  Tom Tromey  <tom@tromey.com>
5092             Pedro Alves  <palves@redhat.com>
5093
5094         * symfile.c: Include forward-scope-exit.h.
5095         (clear_symtab_users_cleanup): Replace forward declaration with
5096         a FORWARD_SCOPE_EXIT.
5097         (syms_from_objfile_1): Use the forward_scope_exit and
5098         gdb::optional instead of cleanup_function.
5099         (reread_symbols): Use the forward_scope_exit instead of
5100         cleanup_function.
5101         (clear_symtab_users_cleanup): Remove function.
5102
5103 2019-01-23  Tom Tromey  <tom@tromey.com>
5104             Pedro Alves  <palves@redhat.com>
5105
5106         * linux-nat.c: Include scope-exit.h.
5107         (cleanup_target_stop): Remove.
5108         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5109         SCOPE_EXIT.
5110
5111 2019-01-23  Tom Tromey  <tom@tromey.com>
5112             Pedro Alves  <palves@redhat.com>
5113
5114         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5115         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5116
5117 2019-01-23  Tom Tromey  <tom@tromey.com>
5118             Andrew Burgess  <andrew.burgess@embecosm.com>
5119             Pedro Alves  <palves@redhat.com>
5120
5121         * infrun.c (fetch_inferior_event): Use scope_exit.
5122         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5123         * top.c (execute_command): Use scope_exit.
5124         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5125         * utils.c (do_bpstat_clear_actions_cleanup)
5126         (make_bpstat_clear_actions_cleanup): Remove.
5127
5128 2019-01-23  Tom Tromey  <tom@tromey.com>
5129             Pedro Alves  <palves@redhat.com>
5130
5131         * infrun.c: Include "common/scope-exit.h"
5132         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5133         (wait_for_inferior): Use SCOPE_EXIT.
5134         (fetch_inferior_event): Use scope_exit.
5135
5136 2019-01-23  Tom Tromey  <tom@tromey.com>
5137             Pedro Alves  <palves@redhat.com>
5138
5139         * breakpoint.c (create_breakpoint): Remove cleanup.
5140
5141 2019-01-23  Tom Tromey  <tom@tromey.com>
5142             Andrew Burgess  <andrew.burgess@embecosm.com>
5143             Pedro Alves  <palves@redhat.com>
5144
5145 2019-01-23  Pedro Alves  <palves@redhat.com>
5146
5147         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5148
5149 2019-01-23  Pedro Alves  <palves@redhat.com>
5150             Andrew Burgess  <andrew.burgess@embecosm.com>
5151
5152         * gdbthread.h: Include "common/forward-scope-exit.h".
5153         (scoped_finish_thread_state): Redefine custom class in terms of
5154         forward_scope_exit.
5155
5156 2019-01-23  Pedro Alves  <palves@redhat.com>
5157             Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * common/forward-scope-exit.h: New file.
5160
5161 2019-01-23  Pedro Alves  <palves@redhat.com>
5162             Andrew Burgess  <andrew.burgess@embecosm.com>
5163             Tom Tromey  <tom@tromey.com>
5164
5165         * common/scope-exit.h: New file.
5166
5167 2019-01-23  Pedro Alves  <palves@redhat.com>
5168
5169         * common/preprocessor.h (ESC): Rename to ...
5170         (ESC_PARENS): ... this.
5171         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5172         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5173
5174 2019-01-23  Tom Tromey  <tom@tromey.com>
5175
5176         * language.h (class scoped_switch_to_sym_language_if_auto):
5177         Initialize m_lang in both cases.
5178
5179 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5180
5181         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5182         with XCNEW.
5183
5184 2019-01-22  Tom Tromey  <tom@tromey.com>
5185
5186         * corelow.c: Do not include sys/file.h.
5187
5188 2019-01-22  Tom Tromey  <tom@tromey.com>
5189
5190         * tui/tui-wingeneral.h: Include gdb_curses.h.
5191
5192 2019-01-22  Tom Tromey  <tom@tromey.com>
5193
5194         * source-cache.h (class source_cache) <get_source_lines,
5195         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5196
5197 2019-01-22  Tom Tromey  <tom@tromey.com>
5198
5199         * remote-fileio.h (struct remote_target): Declare.
5200
5201 2019-01-22  Tom Tromey  <tom@tromey.com>
5202
5203         * python/py-arch.c: Do not include py-ref.h.
5204         * python/py-bpevent.c: Do not include py-ref.h.
5205         * python/py-cmd.c: Do not include py-ref.h.
5206         * python/py-continueevent.c: Do not include py-ref.h.
5207         * python/py-event.h: Do not include py-ref.h.
5208         * python/py-evtregistry.c: Do not include py-ref.h.
5209         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5210         * python/py-frame.c: Do not include py-ref.h.
5211         * python/py-framefilter.c: Do not include py-ref.h.
5212         * python/py-function.c: Do not include py-ref.h.
5213         * python/py-infevents.c: Do not include py-ref.h.
5214         * python/py-linetable.c: Do not include py-ref.h.
5215         * python/py-objfile.c: Do not include py-ref.h.
5216         * python/py-param.c: Do not include py-ref.h.
5217         * python/py-prettyprint.c: Do not include py-ref.h.
5218         * python/py-progspace.c: Do not include py-ref.h.
5219         * python/py-symbol.c: Do not include py-ref.h.
5220         * python/py-symtab.c: Do not include py-ref.h.
5221         * python/py-type.c: Do not include py-ref.h.
5222         * python/py-unwind.c: Do not include py-ref.h.
5223         * python/py-utils.c: Do not include py-ref.h.
5224         * python/py-value.c: Do not include py-ref.h.
5225         * python/py-varobj.c: Do not include py-ref.h.
5226         * python/py-xmethods.c: Do not include py-ref.h.
5227         * python/python.c: Do not include py-ref.h.
5228         * varobj.c: Do not include py-ref.h.
5229
5230 2019-01-22  Tom Tromey  <tom@tromey.com>
5231
5232         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5233         keyword for bcache.
5234
5235 2019-01-22  Tom Tromey  <tom@tromey.com>
5236
5237         * compile/compile-cplus-types.c: Remove a comment by #include.
5238
5239 2019-01-22  Tom Tromey  <tom@tromey.com>
5240
5241         * compile/gcc-c-plugin.h: Include compile-internal.h.
5242
5243 2019-01-22  Tom Tromey  <tom@tromey.com>
5244
5245         * stabsread.c (EXTERN): Do not define.
5246         (symnum, next_symbol_text_func, processing_gcc_compilation)
5247         (within_function, global_sym_chain, global_stabs)
5248         (previous_stab_code, this_object_header_files)
5249         (n_this_object_header_files)
5250         (n_allocated_this_object_header_files): Define.
5251         * stabsread.h (EXTERN): Never define.  Use "extern".
5252
5253 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5254
5255         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5256         history_value.
5257
5258 2019-01-21  Tom Tromey  <tom@tromey.com>
5259
5260         * ui-out.c: Fix includes.
5261         * tui/tui-source.c: Fix includes.
5262         * target.c: Fix includes.
5263         * remote.c: Fix includes.
5264         * regcache.c: Fix includes.
5265         * python/py-block.c: Fix includes.
5266         * printcmd.c: Fix includes.
5267         * or1k-tdep.c: Fix includes.
5268         * mi/mi-main.c: Fix includes.
5269         * m32r-tdep.c: Fix includes.
5270         * csky-tdep.c: Fix includes.
5271         * compile/compile-cplus-types.c: Fix includes.
5272         * cli/cli-interp.c: Fix includes.
5273
5274 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5275
5276         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5277         for padding.
5278
5279 2019-01-16  Tom Tromey  <tom@tromey.com>
5280
5281         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5282         earlier.
5283         (struct objfile) <msymbols_range>: Move from top level.
5284         <msymbols>: New method.
5285         (class objfile_msymbols): Remove.
5286         * symtab.c (default_collect_symbol_completion_matches_break_on):
5287         Update.
5288         * symmisc.c (dump_msymbols): Update.
5289         * stabsread.c (scan_file_globals): Update.
5290         * objc-lang.c (info_selectors_command, info_classes_command)
5291         (find_methods): Update.
5292         * minsyms.c (find_solib_trampoline_target): Update.
5293         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5294         * coffread.c (coff_symfile_read): Update.
5295         * ada-lang.c (ada_lookup_simple_minsym)
5296         (ada_collect_symbol_completion_matches): Update.
5297
5298 2019-01-16  Tom Tromey  <tom@tromey.com>
5299
5300         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5301         type.  Remove no-argument constructor.
5302         <iterator::operator++>: Simplify.
5303         <begin>: Update.
5304         <end>: Use minimal_symbol_count.
5305
5306 2019-01-16  Tom Tromey  <tom@tromey.com>
5307
5308         * objfiles.h (struct objfile) <psymtabs>: New method.
5309         (class objfile_psymtabs): Remove.
5310         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5311         typedef.
5312         <range>: New method.
5313         (require_partial_symbols): Change return type.
5314         * psymtab.c (require_partial_symbols)
5315         (psym_expand_symtabs_matching): Update.
5316         * mdebugread.c (parse_partial_symbols): Update.
5317         * dbxread.c (dbx_end_psymtab): Update.
5318
5319 2019-01-15  Tom Tromey  <tom@tromey.com>
5320
5321         * symtab.c (lookup_objfile_from_block)
5322         (lookup_symbol_in_objfile_symtabs)
5323         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5324         (find_line_symtab, info_sources_command)
5325         (default_collect_symbol_completion_matches_break_on)
5326         (make_source_files_completion_list): Update.
5327         * symmisc.c (print_objfile_statistics, dump_objfile)
5328         (maintenance_print_symbols, maintenance_info_symtabs)
5329         (maintenance_check_symtabs, maintenance_info_line_tables):
5330         Update.
5331         * source.c (select_source_symtab)
5332         (forget_cached_source_info_for_objfile): Update.
5333         * objfiles.h (class objfile_compunits): Remove.
5334         (struct objfile) <compunits_range>: New typedef.
5335         (compunits): New method.
5336         * objfiles.c (objfile_relocate1): Update.
5337         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5338         * maint.c (count_symtabs_and_blocks): Update.
5339         * linespec.c (iterate_over_all_matching_symtabs): Update.
5340         * cp-support.c (add_symbol_overload_list_qualified): Update.
5341         * coffread.c (coff_symtab_read): Update.
5342         * ada-lang.c (add_nonlocal_symbols)
5343         (ada_collect_symbol_completion_matches)
5344         (ada_add_global_exceptions): Update.
5345
5346 2019-01-15  Tom Tromey  <tom@tromey.com>
5347
5348         * progspace.h (program_space) <objfiles_safe_range>: New
5349         typedef.
5350         <objfiles_safe>: New method.
5351         * objfiles.h (class all_objfiles_safe): Remove.
5352         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5353         * jit.c (jit_inferior_exit_hook): Update.
5354
5355 2019-01-17  Tom Tromey  <tom@tromey.com>
5356
5357         * progspace.h (program_space) <objfiles_range>: New typedef.
5358         <objfiles>: New method.
5359         <objfiles_head>: Rename from objfiles.
5360         (object_files): Update.
5361         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5362         * guile/scm-pretty-print.c
5363         (ppscm_find_pretty_printer_from_objfiles): Update.
5364         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5365         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5366         Update.
5367         * python/py-progspace.c (pspy_get_objfiles): Update.
5368         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5369         Update.
5370         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5371         (objfpy_lookup_objfile_by_build_id): Update.
5372         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5373         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5374         Update.
5375         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5376         (expand_symtab_containing_pc, lookup_objfile_from_block)
5377         (lookup_static_symbol, basic_lookup_transparent_type)
5378         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5379         (find_line_symtab, info_sources_command)
5380         (default_collect_symbol_completion_matches_break_on)
5381         (make_source_files_completion_list, find_main_name): Update.
5382         * symmisc.c (print_symbol_bcache_statistics)
5383         (print_objfile_statistics, maintenance_print_symbols)
5384         (maintenance_print_msymbols, maintenance_print_objfiles)
5385         (maintenance_info_symtabs, maintenance_check_symtabs)
5386         (maintenance_expand_symtabs, maintenance_info_line_tables):
5387         Update.
5388         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5389         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5390         (map_overlay_command, unmap_overlay_command)
5391         (simple_overlay_update, expand_symtabs_matching)
5392         (map_symbol_filenames): Update.
5393         * symfile-debug.c (set_debug_symfile): Update.
5394         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5395         Update.
5396         * source.c (select_source_symtab, forget_cached_source_info):
5397         Update.
5398         * solib.c (solib_read_symbols): Update.
5399         * solib-spu.c (append_ocl_sos): Update.
5400         * psymtab.c (maintenance_print_psymbols)
5401         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5402         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5403         * printcmd.c (info_symbol_command): Update.
5404         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5405         Update.
5406         * objfiles.h (class all_objfiles): Remove.
5407         * objfiles.c (have_partial_symbols, have_full_symbols)
5408         (have_minimal_symbols, qsort_cmp, update_section_map)
5409         (shared_objfile_contains_address_p)
5410         (default_iterate_over_objfiles_in_search_order): Update.
5411         * objc-lang.c (info_selectors_command, info_classes_command)
5412         (find_methods): Update.
5413         * minsyms.c (find_solib_trampoline_target): Update.
5414         * maint.c (maintenance_info_sections)
5415         (maintenance_translate_address, count_symtabs_and_blocks):
5416         Update.
5417         * main.c (captured_main_1): Update.
5418         * linux-thread-db.c (try_thread_db_load_from_pdir)
5419         (has_libpthread): Update.
5420         * linespec.c (iterate_over_all_matching_symtabs)
5421         (search_minsyms_for_name): Update.
5422         * jit.c (jit_find_objf_with_entry_addr): Update.
5423         * hppa-tdep.c (find_unwind_entry)
5424         (hppa_lookup_stub_minimal_symbol): Update.
5425         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5426         Update.
5427         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5428         (elf_gnu_ifunc_resolve_by_got): Update.
5429         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5430         * dwarf-index-write.c (save_gdb_index_command): Update.
5431         * cp-support.c (add_symbol_overload_list_qualified): Update.
5432         * breakpoint.c (create_overlay_event_breakpoint)
5433         (create_longjmp_master_breakpoint)
5434         (create_std_terminate_master_breakpoint)
5435         (create_exception_master_breakpoint): Update.
5436         * blockframe.c (find_pc_partial_function): Update.
5437         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5438         (ada_collect_symbol_completion_matches)
5439         (ada_add_global_exceptions): Update.
5440
5441 2019-01-17  Tom Tromey  <tom@tromey.com>
5442
5443         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5444         declare VEC.
5445         (solib_target_parse_libraries): Change return type.
5446         (library_list_start_segment, library_list_start_section)
5447         (library_list_end_library, library_list_start_library); Update.
5448         (solib_target_free_library_list): Remove.
5449         (solib_target_parse_libraries): Remove cleanup.  Change return
5450         type.
5451         (solib_target_current_sos): Update.
5452
5453 2019-01-17  Tom Tromey  <tromey@bapiya>
5454
5455         * valprint.c: Replace "the the" with "the".
5456         * symtab.c: Replace "the the" with "the".
5457         * solib.c: Replace "the the" with "the".
5458         * solib-dsbt.c: Replace "the the" with "the".
5459         * linespec.c: Replace "the the" with "the".
5460         * dwarf2loc.h: Replace "the the" with "the".
5461         * amd64-windows-tdep.c: Replace "the the" with "the".
5462         * aarch64-tdep.c: Replace "the the" with "the".
5463
5464 2019-01-16  Keith Seitz  <keiths@redhat.com>
5465
5466         PR gdb/23773
5467         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5468         <builder>: Rename to ..
5469         <m_builder>: ... this and make private.
5470         (dwarf2_cu::get_builder): New method.  Change all users of
5471         `builder' to use this method.
5472         (dwarf2_start_symtab): Move to ...
5473         (dwarf2_cu::start_symtab): ... here.  Update all callers
5474         (setup_type_unit_groups): Move to ...
5475         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5476         callers.
5477         (dwarf2_cu::reset_builder): New method.
5478         (process_full_compunit, process_full_type_unit): Use
5479         dwarf2_cu::reset_builder.
5480         (follow_die_offset): Record the ancestor CU if it is different
5481         from the followed DIE's CU.
5482         (follow_die_sig_1): Likewise.
5483
5484 2019-01-15  Tom Tromey  <tom@tromey.com>
5485
5486         * remote.c (class remote_state) <buf>: Now a char_vector.
5487         <buf_size>: Remove.
5488         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5489         parameter.
5490         (remote_target::getpkt_or_notif_sane_1)
5491         (remote_target::getpkt_sane)
5492         (remote_target::getpkt_or_notif_sane): Likewise.
5493         (class remote_target) <putpkt>: New overload.
5494         (remote_target::read_frame): Change type of "buf_p".  Remove
5495         sizeof_p parameter.
5496         (packet_ok): New overload.
5497         (packet_check_result): New overload.
5498         Update all uses.
5499
5500 2019-01-14  Tom Tromey  <tom@tromey.com>
5501
5502         * remote-notif.c (handle_notification, remote_notif_ack)
5503         (remote_notif_parse): Make "buf" const.
5504         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5505         const.
5506         (remote_notif_parse, remote_notif_ack, handle_notification):
5507         Likewise.
5508         * remote.c (remote_notif_stop_parse): Make "buf" const.
5509         (remote_target::remote_parse_stop_reply): Make "buf" const.
5510         (remote_notif_stop_ack): Make "buf" const.
5511
5512 2019-01-14  Tom Tromey  <tom@tromey.com>
5513
5514         * remote.c (remote_console_output): Make parameter const.
5515
5516 2019-01-14  Tom Tromey  <tom@tromey.com>
5517
5518         * target-debug.h (target_debug_print_signals): Constify.
5519         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5520         * procfs.c (procfs_target::pass_signals): Update.
5521         * linux-nat.c (linux_nat_target::pass_signals): Update.
5522         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5523         * target-delegates.c: Rebuild.
5524         * remote.c (remote_target::program_signals): Update.
5525         (remote_target::pass_signals): Update.
5526         * target.c (target_pass_signals): Constify argument.
5527         (target_program_signals): Likewise.
5528         * target.h (struct target_ops) <pass_signals, program_signals>:
5529         Constify argument.
5530         (target_pass_signals, target_program_signals): Constify argument.
5531
5532 2019-01-14  Tom Tromey  <tom@tromey.com>
5533
5534         PR tui/28819:
5535         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5536
5537 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5538
5539         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5540         field.
5541         * rs6000-tdep.c: Include reggroups.h.
5542         (IS_V_ALIAS_PSEUDOREG): Define.
5543         (rs6000_register_name): Return names for the "vX" aliases.
5544         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5545         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5546         aliases.  Call default_register_reggroup_p for all other
5547         pseudo-registers.
5548         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5549         New functions.
5550         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5551         Handle "vX" aliases.
5552         (v_alias_pseudo_register_collect): New function.
5553         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5554         (rs6000_gdbarch_init): Initialize "vX" aliases as
5555         pseudo-registers.  Restore registration of
5556         rs6000_pseudo_register_reggroup_p with
5557         set_tdesc_pseudo_register_reggroup_p.
5558
5559 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5560
5561         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5562         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5563         set_gdbarch_num_pseudo_regs.
5564
5565 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5566
5567         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5568         Remove arg prefixname, add do_set and do_show.
5569         Add member functions set_list and show_list.
5570         * cli/cli-style.c (class cli_style_option): Update accordingly.
5571         (style_set_list): Move to file scope.
5572         (style_show_list): Likewise.
5573         (set_style): Call help_list.
5574         (show_style): Call cmd_show_list.
5575         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5576         Update to use the new macro.
5577
5578 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5579
5580         * ada-lang.c (_initialize_ada_language): Expand the help text
5581         for the "catch exception" command.
5582
5583 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5584
5585         * symtab.c (matching_obj_sections): Initialize obj,
5586         declare it closer to its usage.
5587
5588 2019-01-10  Tom Tromey  <tom@tromey.com>
5589
5590         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5591         (basic_inf_threads_range): Remove.
5592         (inf_threads_range, inf_non_exited_threads_range)
5593         (safe_inf_threads_range): Use next_adapter.
5594
5595 2019-01-10  Keith Seitz  <keiths@redhat.com>
5596
5597         PR gdb/23712
5598         PR symtab/23010
5599         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5600         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5601
5602 2019-01-10  Keith Seitz  <keiths@redhat.com>
5603
5604         PR gdb/23712
5605         PR symtab/23010
5606         * dictionary.c (pending_to_vector): Remove.
5607         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5608         Remove _1 suffix, replacing functions of the same name.  Update
5609         all callers.
5610         (dict_create_hashed, dict_create_hashed_expandable)
5611         (dict_create_linear, dict_create_linear_expandable, dict_free)
5612         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5613         Make functions static.
5614
5615 2019-01-10  Keith Seitz  <keiths@redhat.com>
5616
5617         PR gdb/23712
5618         PR symtab/23010
5619         * dictionary.h (struct dictionary): Replace declaration with
5620         multidictionary.
5621         (dict_create_hashed, dict_create_hashed_expandable)
5622         (dict_create_linear, dict_create_linear_expandable)
5623         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5624         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5625         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5626         taking multidictionary argument.
5627         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5628         * block.h (struct block) <dict>: Change to multidictionary
5629         and rename `multidict'.
5630         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5631         symmisc.c: Update all dictionary references to multidictionary.
5632
5633 2019-01-10  Keith Seitz  <keiths@redhat.com>
5634
5635         PR gdb/23712
5636         PR symtab/23010
5637         * dictionary.c: Include unordered_map.
5638         (pending_to_vector): New function.
5639         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5640         Rewrite the non-"_1" functions to take vector instead
5641         of linked list.
5642         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5643         "new" _1 versions of the same name.
5644         (multidictionary): Define.
5645         (std::hash<enum language): New definition.
5646         (collate_pending_symbols_by_language, mdict_create_hashed)
5647         (mdict_create_hashed_expandable, mdict_create_linear)
5648         (mdict_create_linear_expandable, mdict_free)
5649         (find_language_dictionary, create_new_language_dictionary)
5650         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5651         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5652         (mdict_size, mdict_empty): New functions.
5653         * dictionary.h (mdict_iterator): Define.
5654
5655 2019-01-10  Pedro Alves  <palves@redhat.com>
5656
5657         * breakpoint.c (read_uploaded_action)
5658         (create_tracepoint_from_upload): Adjust to use
5659         gdb::unique_xmalloc_ptr.
5660         * ctf.c (ctf_write_uploaded_tp):
5661         (SET_ARRAY_FIELD): Use emplace_back.
5662         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5663         * tracefile-tfile.c (tfile_write_uploaded_tp):
5664         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5665         gdb::unique_xmalloc_ptr.
5666         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5667         at_string, cond_string, cmd_strings>: Replace char pointers
5668         with gdb::unique_xmalloc_ptr.
5669
5670 2019-01-10  Pedro Alves  <palves@redhat.com>
5671
5672         * solib-target.c (library_list_start_library): Don't xstrdup name.
5673
5674 2019-01-10  Pedro Alves  <palves@redhat.com>
5675
5676         * mdebugread.c (parse_partial_symbols): Use
5677         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5678
5679 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5680
5681         * linux-fork.c (scoped_switch_fork_info)
5682         <~scoped_switch_fork_info>: Fix incorrect variable name.
5683
5684 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5685
5686         * linux-fork.c (scoped_switch_fork_info)
5687         <scoped_switch_fork_info>: Make explicit.
5688         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5689
5690 2019-01-10  Tom Tromey  <tom@tromey.com>
5691
5692         * objfiles.h (objfile::reset_psymtabs): Update.
5693         * objfiles.c (objfile::objfile): Update.
5694         * psymtab.h (psymtab_storage::obstack): Update.
5695         (psymtab_storage::m_obstack): Use gdb::optional.
5696         (class psymtab_storage): Update comment.  Remove objfile
5697         parameter.
5698         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5699
5700 2019-01-10  Tom Tromey  <tom@tromey.com>
5701
5702         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5703         <free_psymtabs>: Now private.
5704         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5705         (allocate_psymtab): Use new method.
5706
5707 2019-01-10  Tom Tromey  <tom@tromey.com>
5708
5709         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5710         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5711         * mdebugread.c (parse_partial_symbols): Use
5712         allocate_dependencies.
5713         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5714         allocate_dependencies.
5715         (process_psymtab_comp_unit_reader)
5716         (build_type_psymtab_dependencies): Likewise.
5717         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5718
5719 2019-01-10  Tom Tromey  <tom@tromey.com>
5720
5721         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5722         PSYMBOL_SET_LANGUAGE.
5723         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5724
5725 2019-01-10  Tom Tromey  <tom@tromey.com>
5726
5727         * psymtab.h (psymtab_storage::obstack): New method.
5728         <m_obstack>: Rename from obstack; now private.
5729         * psymtab.c (psymtab_storage): Update.
5730         * dwarf2read.c (create_addrmap_from_index)
5731         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5732         Update.
5733
5734 2019-01-10  Tom Tromey  <tom@tromey.com>
5735
5736         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5737         * objfiles.h (objfile::reset_psymtabs): New method.
5738
5739 2019-01-10  Tom Tromey  <tom@tromey.com>
5740
5741         * symmisc.c (print_symbol_bcache_statistics): Update.
5742         (print_objfile_statistics): Update.
5743         * symfile.c (reread_symbols): Update.
5744         * psymtab.h (class psymtab_storage): New.
5745         * psymtab.c (psymtab_storage): New constructor.
5746         (~psymtab_storage): New destructor.
5747         (require_partial_symbols): Update.
5748         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5749         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5750         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5751         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5752         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5753         (start_psymtab_common, end_psymtab_common)
5754         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5755         (allocate_psymtab): Update.
5756         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5757         Update.
5758         (dump_psymtab_addrmap, maintenance_print_psymbols)
5759         (maintenance_check_psymtabs): Update.
5760         (class objfile_psymtabs): Move to objfiles.h.
5761         * psympriv.h (discard_psymtab): Now inline.
5762         (psymtab_discarder::psymtab_discarder): Update.
5763         (psymtab_discarder::~psymtab_discarder): Update.
5764         (ALL_OBJFILE_PSYMTABS): Rewrite.
5765         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5766         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5767         Remove fields.
5768         <partial_symtabs>: New field.
5769         (class objfile_psymtabs): Move from psymtab.h.  Update.
5770         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5771         psymbol_cache.
5772         (objfile::~objfile): Don't destroy psymbol_cache.
5773         * mdebugread.c (parse_partial_symbols): Update.
5774         * dwarf2read.c (create_addrmap_from_index)
5775         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5776         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5777         (add_partial_subprogram, dwarf2_ranges_read): Update.
5778         * dwarf-index-write.c (write_address_map)
5779         (write_one_signatured_type, recursively_write_psymbols)
5780         (class debug_names, class debug_names, write_psymtabs_to_index):
5781         Update.
5782
5783 2019-01-10  Tom Tromey  <tom@tromey.com>
5784
5785         * symtab.h (SYMBOL_SET_NAMES): Update.
5786         (symbol_set_names): Update.
5787         (MSYMBOL_SET_NAMES): Update.
5788         * symtab.c (symbol_set_names): Change argument to be an
5789         objfile_per_bfd_storage.
5790         * psymtab.c (add_psymbol_to_bcache): Update.
5791         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5792
5793 2019-01-10  Tom Tromey  <tom@tromey.com>
5794
5795         * symtab.c (create_demangled_names_hash): Change argument to be an
5796         objfile_per_bfd_storage.
5797         (symbol_set_names): Update.
5798
5799 2019-01-10  Tom Tromey  <tom@tromey.com>
5800
5801         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5802         init_psymbol_list.
5803         * psymtab.c (init_psymbol_list): Do nothing if already called.
5804         * psympriv.h (init_psymbol_list): Add comment.
5805         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5806         init_psymbol_list.
5807         * dbxread.c (dbx_symfile_read): Unconditionally call
5808         init_psymbol_list.
5809
5810 2019-01-10  Tom Tromey  <tom@tromey.com>
5811
5812         * xcoffread.c (scan_xcoff_symtab): Update.
5813         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5814         "where".
5815         * mdebugread.c (parse_partial_symbols)
5816         (handle_psymbol_enumerators): Update.
5817         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5818         * dbxread.c (read_dbx_symtab): Update.
5819         * psympriv.h (psymbol_placement): New enum.
5820         (add_psymbol_to_list): Update.
5821
5822 2019-01-10  Tom Tromey  <tom@tromey.com>
5823
5824         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5825         static_psymbols parameters.
5826         (scan_xcoff_symtab): Update.
5827         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5828         static_psymbols parameters.
5829         * psympriv.h (start_psymtab_common): Update.
5830         * mdebugread.c (parse_partial_symbols): Update.
5831         * dwarf2read.c (create_partial_symtab): Update.
5832         * dbxread.c (read_dbx_symtab): Update.
5833         (start_psymtab): Remove global_psymbols and static_psymbols
5834         parameters.
5835
5836 2019-01-10  Tom Tromey  <tom@tromey.com>
5837
5838         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5839         * psymtab.c (allocate_psymtab): Add comment.
5840         * psympriv.h (allocate_psymtab): Add comment.
5841         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5842         initializations.
5843         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5844
5845 2019-01-10  Tom Tromey  <tom@tromey.com>
5846
5847         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5848         Don't declare.
5849         * mipsread.c: Include mdebugread.h.
5850         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5851         Declare.
5852         * elfread.c: Include mdebugread.h.
5853
5854 2019-01-09  Tom Tromey  <tom@tromey.com>
5855
5856         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5857         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5858         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5859         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5860         (psym_lookup_symbol, psym_find_last_source_symtab)
5861         (psym_forget_cached_source_info, psym_print_stats)
5862         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5863         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5864         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5865         (psym_find_compunit_symtab_by_address)
5866         (maintenance_print_psymbols, maintenance_info_psymtabs)
5867         (maintenance_check_psymtabs): Use ranged for.
5868         * psymtab.h (class objfile_psymtabs): New.
5869         (require_partial_symbols): Return objfile_psymtabs.
5870         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5871
5872 2019-01-09  Tom Tromey  <tom@tromey.com>
5873
5874         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5875         (find_pc_mapped_section, list_overlays_command)
5876         (map_overlay_command, unmap_overlay_command)
5877         (simple_overlay_update): Use all_objfiles.
5878         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5879         * printcmd.c (info_symbol_command): Use all_objfiles.
5880         * objfiles.h (ALL_OBJSECTIONS): Remove.
5881         * maint.c (maintenance_translate_address): Use all_objfiles.
5882         * gcore.c (gcore_create_callback): Use all_objfiles.
5883         (objfile_find_memory_regions): Likewise.
5884
5885 2019-01-09  Tom Tromey  <tom@tromey.com>
5886
5887         * symtab.c (find_line_symtab, info_sources_command)
5888         (make_source_files_completion_list): Use objfile_compunits.
5889         * source.c (select_source_symtab): Use objfile_compunits.
5890         * objfiles.h (struct objfile): Update comment.
5891         (ALL_OBJFILES): Remove.
5892         (ALL_FILETABS): Remove.
5893         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5894         objfile_compunits.
5895
5896 2019-01-09  Tom Tromey  <tom@tromey.com>
5897
5898         * symmisc.c (print_objfile_statistics, dump_objfile)
5899         (maintenance_print_symbols): Use compunit_filetabs.
5900         * source.c (forget_cached_source_info_for_objfile): Use
5901         compunit_filetabs.
5902         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5903         (ALL_FILETABS): Use compunit_filetabs.
5904         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5905         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5906
5907 2019-01-09  Tom Tromey  <tom@tromey.com>
5908
5909         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5910         (compunit_filetabs): New.
5911         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5912         compunit_filetabs.
5913         (info_sources_command, make_source_files_completion_list): Remove
5914         declaration.
5915         * symmisc.c (print_objfile_statistics, dump_objfile)
5916         (maintenance_print_symbols): Remove declaration.
5917         (maintenance_info_symtabs): Use compunit_filetabs.
5918         (maintenance_info_line_tables): Likewise.
5919         * source.c (select_source_symtab): Change local variable name.
5920         (forget_cached_source_info_for_objfile): Remove declaration.
5921         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5922         * objfiles.c (objfile_relocate1): Remove declaration.
5923         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5924         declaration.
5925         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5926         * coffread.c (coff_symtab_read): Remove declaration.
5927         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5928         compunit_filetabs.
5929
5930 2019-01-09  Tom Tromey  <tom@tromey.com>
5931
5932         * symtab.c (lookup_objfile_from_block)
5933         (find_pc_sect_compunit_symtab, search_symbols)
5934         (default_collect_symbol_completion_matches_break_on): Use
5935         objfile_compunits.
5936         * objfiles.h (ALL_COMPUNITS): Remove.
5937         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5938         * cp-support.c (add_symbol_overload_list_qualified): Use
5939         objfile_compunits.
5940         * ada-lang.c (ada_collect_symbol_completion_matches)
5941         (ada_add_global_exceptions): Use objfile_compunits.
5942
5943 2019-01-09  Tom Tromey  <tom@tromey.com>
5944
5945         * source.c (select_source_symtab)
5946         (forget_cached_source_info_for_objfile): Remove declaration.
5947         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5948         declaration.
5949         * maint.c (count_symtabs_and_blocks): Remove declaration.
5950         * cp-support.c (add_symbol_overload_list_qualified): Remove
5951         declaration.
5952         * coffread.c (coff_symtab_read): Remove declaration.
5953         * symtab.c (lookup_symbol_in_objfile_symtabs)
5954         (basic_lookup_transparent_type_1): Use objfile_compunits.
5955         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5956         (info_sources_command, search_symbols)
5957         (default_collect_symbol_completion_matches_break_on)
5958         (make_source_files_completion_list): Remove declaration.
5959         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5960         (ada_collect_symbol_completion_matches)
5961         (ada_add_global_exceptions): Remove declaration.
5962         * linespec.c (iterate_over_all_matching_symtabs): Use
5963         objfile_compunits.
5964         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5965         (class objfile_compunits): New.
5966         (ALL_COMPUNITS): Use objfile_compunits.
5967         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5968         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5969         objfile_compunits.
5970         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5971
5972 2019-01-09  Tom Tromey  <tom@tromey.com>
5973
5974         * symtab.c (search_symbols)
5975         (default_collect_symbol_completion_matches_break_on): Use
5976         objfile_msymbols.
5977         * ada-lang.c (ada_lookup_simple_minsym)
5978         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5979         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5980         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5981         objfile_msymbols.
5982         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5983         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5984         * objc-lang.c (find_methods): Use objfile_msymbols.
5985         (info_selectors_command, info_classes_command): Likewise.
5986         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5987         * objfiles.h (class objfile_msymbols): New.
5988         (ALL_OBJFILE_MSYMBOLS): Remove.
5989         (ALL_MSYMBOLS): Remove.
5990
5991 2019-01-09  Tom Tromey  <tom@tromey.com>
5992
5993         * common/next-iterator.h (next_adapter): Add Iterator template
5994         parameter.
5995         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5996         (class all_objfiles_safe): New.
5997         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5998         * objfiles.c (put_objfile_before): Update comment.
5999         (add_separate_debug_objfile): Likewise.
6000         (free_all_objfiles): Use all_objfiles_safe.
6001         (objfile_purge_solibs): Likewise.
6002
6003 2019-01-09  Tom Tromey  <tom@tromey.com>
6004
6005         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6006         (expand_symtab_containing_pc, lookup_static_symbol)
6007         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6008         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6009         all_objfiles.
6010         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6011         * breakpoint.c (create_overlay_event_breakpoint)
6012         (create_longjmp_master_breakpoint)
6013         (create_std_terminate_master_breakpoint)
6014         (create_exception_master_breakpoint): Use all_objfiles.
6015         * linux-thread-db.c (try_thread_db_load_from_pdir)
6016         (has_libpthread): Use all_objfiles.
6017         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6018         * linespec.c (iterate_over_all_matching_symtabs)
6019         (search_minsyms_for_name): Use all_objfiles.
6020         * maint.c (maintenance_info_sections): Use all_objfiles.
6021         * main.c (captured_main_1): Use all_objfiles.
6022         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6023         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6024         * guile/scm-pretty-print.c
6025         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6026         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6027         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6028         (maintenance_print_msymbols): Use all_objfiles.
6029         * source.c (select_source_symtab): Use all_objfiles.
6030         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6031         * symfile.c (remove_symbol_file_command)
6032         (expand_symtabs_matching, map_symbol_filenames): Use
6033         all_objfiles.
6034         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6035         all_objfiles.
6036         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6037         * objc-lang.c (find_methods): Use all_objfiles.
6038         * objfiles.c (have_partial_symbols, have_full_symbols)
6039         (have_minimal_symbols, qsort_cmp)
6040         (default_iterate_over_objfiles_in_search_order): Use
6041         all_objfiles.
6042         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6043         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6044         (maintenance_check_psymtabs): Use all_objfiles.
6045         (ALL_PSYMTABS): Remove.
6046         * compile/compile-object-run.c (do_module_cleanup): Use
6047         all_objfiles.
6048         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6049         * cp-support.c (add_symbol_overload_list_qualified): Use
6050         all_objfiles.
6051         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6052         Use all_objfiles.
6053         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6054         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6055         all_objfiles.
6056         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6057         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6058         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6059         Uses all_objfiles.
6060         * solib.c (solib_read_symbols): Use all_objfiles
6061
6062 2019-01-09  Tom Tromey  <tom@tromey.com>
6063
6064         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6065         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6066         all_objfiles.
6067         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6068         * symmisc.c (print_symbol_bcache_statistics)
6069         (print_objfile_statistics, maintenance_print_objfiles)
6070         (maintenance_info_symtabs, maintenance_check_symtabs)
6071         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6072         all_objfiles.
6073         * source.c (forget_cached_source_info): Use all_objfiles.
6074         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6075         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6076         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6077         * objfiles.c (update_section_map): Use all_objfiles.
6078         (shared_objfile_contains_address_p): Likewise.
6079         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6080         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6081
6082 2019-01-09  Tom Tromey  <tom@tromey.com>
6083
6084         * common/next-iterator.h: New file.
6085         * objfiles.h (class all_objfiles): New.
6086         (struct objfile_iterator): New.
6087
6088 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6089
6090         * NEWS: Move the description of the changed "frame", "select-frame",
6091          and "info frame" commands to the Changed commands section.
6092
6093 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6094
6095         * gdbtypes.c (check_stub_method_group): Remove handling of old
6096         mangling schemes.
6097         * linespec.c (find_methods): Likewise.
6098         * stabsread.c (read_member_functions): Likewise.
6099         * valops.c (search_struct_method): Likewise.
6100         (value_struct_elt_for_reference): Likewise.
6101         * NEWS: Mention this change.
6102
6103 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6104
6105         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6106         print_source_lines.
6107         * source.c (print_source_lines_base): Update line number check.
6108         (print_source_lines): New function.
6109         (source_lines_range::source_lines_range): New function.
6110         * source.h (class source_lines_range): New class.
6111         (print_source_lines): New declaration.
6112
6113 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6114
6115         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6116
6117 2019-01-08  Tom Tromey  <tom@tromey.com>
6118             Simon Marchi  <simon.marchi@ericsson.com>
6119
6120         PR gdb/24060
6121         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6122         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6123         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6124         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6125         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6126         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6127
6128 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6129
6130         * source.c (select_source_symtab): Move header comment to
6131         declaration in source.h.
6132         (forget_cached_source_info_for_objfile): Likewise.
6133         (forget_cached_source_info): Likewise.
6134         (identify_source_line): Likewise.
6135         * source.h (identify_source_line): Move declaration from symtab.h
6136         and add comment from source.c
6137         (print_source_lines): Likewise.
6138         (forget_cached_source_info_for_objfile): Likewise.
6139         (forget_cached_source_info): Likewise.
6140         (select_source_symtab): Likewise.
6141         (enum print_source_lines_flag): Move definition from symtab.h.
6142         * symtab.h (identify_source_line): Move declaration to source.h.
6143         (print_source_lines): Likewise.
6144         (forget_cached_source_info_for_objfile): Likewise.
6145         (forget_cached_source_info): Likewise.
6146         (select_source_symtab): Likewise.
6147         (enum print_source_lines_flag): Move definition to source.h.
6148         * tui/tui-hooks.c: Add 'source.h' include.
6149
6150 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6151
6152         * source.c (print_source_lines_base): Handle requests to print
6153         reverse line number sequences, and guard against empty lines
6154         string.
6155
6156 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * source.c (print_source_lines_base): Fix skip of '\r' if next
6159         character is '\n'.
6160
6161 2019-01-06  Tom Tromey  <tom@tromey.com>
6162
6163         * c-exp.y (struct c_parse_state) <macro_original_text,
6164         expansion_obstack>: New member.
6165         (macro_original_text, expansion_obstack): Remove globals.
6166         (scan_macro_expansion, scanning_macro_expansion)
6167         (finished_macro_expansion): Update.
6168         (scan_macro_cleanup): Remove.
6169         (yylex, c_parse): Update.
6170
6171 2019-01-06  Tom Tromey  <tom@tromey.com>
6172
6173         * c-exp.y (struct c_parse_state) <strings>: New member.
6174         (operator_stoken): Update.
6175
6176 2019-01-06  Tom Tromey  <tom@tromey.com>
6177
6178         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6179         (union type_stack_elt) <typelist_val>: Now a pointer to
6180         std::vector.
6181         (type_stack_cleanup): Don't declare.
6182         (push_typelist): Update.
6183         * parse.c (pop_typelist): Return a std::vector.
6184         (push_typelist): Take a std::vector.
6185         (follow_types): Update.  Do not free args.
6186         (type_stack_cleanup): Remove.
6187         * c-exp.y (struct c_parse_state): New.
6188         (cpstate): New global.
6189         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6190         (nonempty_typelist): Update.
6191         (func_mod): Create a new vector.
6192         (c_parse): Create a c_parse_state.
6193         (check_parameter_typelist): Do not delete params.
6194         (function_method): Update.  Do not delete type_list.
6195
6196 2019-01-06  Tom Tromey  <tom@tromey.com>
6197
6198         PR gdb/28155:
6199         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6200         check_typedef.
6201         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6202         (print_return_value): Likewise.
6203
6204 2019-01-05  Tom Tromey  <tom@tromey.com>
6205
6206         * contrib/cleanup_check.py: Remove.
6207         * contrib/gcc-with-excheck: Remove.
6208         * contrib/exsummary.py: Remove.
6209         * contrib/excheck.py: Remove.
6210
6211 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6212
6213         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6214         NULL. Initialize tpprev to NULL instead of assigning it
6215         to NULL on the next statement.
6216         * windows-nat.c (windows_delete_thread): Remove check for
6217         main_thread_id before printing thread exit notifications.
6218         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6219         Remove thread ID check against main_thread_id.
6220         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6221         windows_delete_thread.
6222         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6223
6224 2019-01-04  Tom Tromey  <tom@tromey.com>
6225
6226         * compile/compile.c (_initialize_compile): Use upper case for
6227         metasyntactic variables.
6228         * symmisc.c (_initialize_symmisc): Use upper case for
6229         metasyntactic variables.
6230         * psymtab.c (_initialize_psymtab): Use upper case for
6231         metasyntactic variables.
6232         * demangle.c (demangle_command): Use upper case for metasyntactic
6233         variables.
6234         (_initialize_demangler): Likewise.
6235         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6236         variables.
6237
6238 2019-01-03  Tom Tromey  <tom@tromey.com>
6239
6240         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6241
6242 2019-01-03  Tom Tromey  <tom@tromey.com>
6243
6244         * python/py-symtab.c (salpy_str): Update.
6245         (struct salpy_sal_object) <symtab>: Now a PyObject.
6246         (salpy_dealloc): Update.
6247         (del_objfile_sal): Use gdbpy_ref.
6248
6249 2019-01-03  Tom Tromey  <tom@tromey.com>
6250
6251         * python/py-type.c (convert_field): Use new_reference.  Return
6252         gdbpy_ref.
6253         (make_fielditem): Return gdbpy_ref.
6254         (typy_fields): Update.
6255         (typy_getitem): Update.
6256         (field_name): Return gdbpy_ref.  Use new_reference.
6257         (typy_iterator_iternext): Update.
6258
6259 2019-01-03  Tom Tromey  <tom@tromey.com>
6260
6261         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6262
6263 2019-01-03  Tom Tromey  <tom@tromey.com>
6264
6265         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6266         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6267         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6268         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6269         (pspy_set_type_printers): Likewise.
6270         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6271         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6272         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6273         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6274         (objfpy_set_type_printers): Likewise.
6275
6276 2019-01-03  Tom Tromey  <tom@tromey.com>
6277
6278         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6279         (gdbpy_print_stack): Use gdbpy_err_fetch.
6280         * python/python-internal.h (class gdbpy_err_fetch): New class.
6281         (class gdbpy_enter) <m_error_type, m_error_value,
6282         m_error_traceback>: Remove.
6283         <m_error>: New member.
6284         (gdbpy_exception_to_string): Don't declare.
6285         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6286         * python/py-value.c (convert_value_from_python): Use
6287         gdbpy_err_fetch.
6288         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6289         gdbpy_exception_to_string.
6290         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6291         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6292         gdbpy_err_fetch.
6293
6294 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6295
6296         * linux-nat.c (delete_lwp_cleanup): Delete.
6297         (struct lwp_deleter): New struct.
6298         (lwp_info_up): New typedef.
6299         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6300         lwp_info_up.
6301
6302 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * linux-fork.c (class scoped_switch_fork_info): New class.
6305         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6306
6307 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6308
6309         * valops.c (find_overload_match): Remove use of null_cleanup, and
6310         calls to do_cleanups.
6311
6312 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * compile/compile-cplus-types.c
6315         (compile_cplus_instance::decl_name): Handle changes to
6316         cp_func_name.
6317         * cp-support.c (cp_func_name): Update header comment, update
6318         return type.
6319         * cp-support.h (cp_func_name): Update return type in declaration.
6320         * valops.c (find_overload_match): Move temp_func local to top
6321         level of function and change its type.  Use temp_func to hold and
6322         delete temporary string obtained from cp_func_name.
6323
6324 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6327         gdb::char_vector, remove cleanup, and update uses of `msg`.
6328
6329 2019-01-03  Jim Wilson  <jimw@sifive.com>
6330
6331         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6332
6333 2019-01-02  Tom Tromey  <tom@tromey.com>
6334
6335         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6336         (tdesc_parse_xml): Remove cleanups.
6337         * target-descriptions.h (make_cleanup_free_target_description):
6338         Don't declare.
6339         (target_desc_deleter): New struct.
6340         (target_desc_up): New typedef.
6341         * target-descriptions.c (target_desc_deleter::operator()): Rename
6342         from free_target_description.
6343         (make_cleanup_free_target_description): Remove.
6344
6345 2019-01-02  Tom Tromey  <tom@tromey.com>
6346
6347         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6348         constructor, destructor.
6349         (linespec_parser): Remove typedef.
6350         (~linespec_parser): Rename from linespec_parser_delete.
6351         (linespec_lex_to_end, linespec_complete_label)
6352         (linespec_complete): Update.
6353         (decode_line_full): Remove cleanups.
6354         (decode_line_1): Update.
6355
6356 2019-01-02  Tom Tromey  <tom@tromey.com>
6357
6358         * python/python-internal.h (inferior_to_inferior_object): Change
6359         return type.
6360         * python/py-exitedevent.c (create_exited_event_object): Update.
6361         * python/py-inferior.c (inferior_to_inferior_object): Return
6362         gdbpy_ref.
6363         (python_new_inferior, python_inferior_deleted)
6364         (thread_to_thread_object, delete_thread_object)
6365         (build_inferior_list, gdbpy_selected_inferior): Update.
6366         * python/py-infthread.c (create_thread_object): Update.  Also fail
6367         if inferior_to_inferior_object fails.
6368
6369 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6370
6371         * inferior.h (class inferior) <displaced_step_state>: New field.
6372         * infrun.h (struct displaced_step_state): Move here from
6373         infrun.c.  Initialize fields, add constructor.
6374         <inf>: Remove field.
6375         <reset>: New method.
6376         * infrun.c (struct displaced_step_inferior_state): Move to
6377         infrun.h.
6378         (displaced_step_inferior_states): Remove.
6379         (get_displaced_stepping_state): Adust.
6380         (displaced_step_in_progress_any_inferior): Adjust.
6381         (displaced_step_in_progress_thread): Adjust.
6382         (displaced_step_in_progress): Adjust.
6383         (add_displaced_stepping_state): Remove.
6384         (get_displaced_step_closure_by_addr): Adjust.
6385         (remove_displaced_stepping_state): Remove.
6386         (infrun_inferior_exit): Call displaced_step_state.reset.
6387         (use_displaced_stepping): Don't check for NULL.
6388         (displaced_step_prepare_throw): Call
6389         get_displaced_stepping_state.
6390         (displaced_step_fixup): Don't check for NULL.
6391         (prepare_for_detach): Don't check for NULL.
6392
6393 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6394
6395         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6396          in case of call that did not complete.
6397
6398 2019-01-02  Andrey Utkin  <autkin@undo.io>
6399
6400         * symfile.c (find_separate_debug_file): Fix search of debug files for
6401         remote debuggee.
6402
6403 2019-01-02  Tom Tromey  <tom@tromey.com>
6404
6405         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6406         indentation.
6407         * python/py-frame.c (frapy_older): Remove cast.
6408         (frapy_newer): Likewise.
6409         * python/py-breakpoint.c (local_setattro): Remove cast.
6410         * python/py-arch.c (archpy_name): Remove local variable.
6411         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6412
6413 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6414
6415         * unittests/basic_string_view/element_access/char/empty.cc:
6416         Fix year range in copyright header.
6417
6418 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6419
6420         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6421         Delete.
6422         <operator==>: Update with for removed field.
6423         <hash>: Likewise.
6424         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6425         <isa_features>: ...this.
6426         <abi_features>: New field.
6427         (riscv_isa_flen): Update comment.
6428         (riscv_abi_xlen): New declaration.
6429         (riscv_abi_flen): New declaration.
6430         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6431         isa_features.
6432         (riscv_abi_xlen): New function.
6433         (riscv_isa_flen): Update to get answer from isa_features.
6434         (riscv_abi_flen): New function.
6435         (riscv_has_fp_abi): Update to get answer from abi_features.
6436         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6437         xlen and flen.
6438         (riscv_call_info) <xlen, flen>: Update comment.
6439         (riscv_call_arg_struct): Remove invalid assertions
6440         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6441         is removed.
6442         (riscv_gdbarch_init): Gather isa features and abi features
6443         separately, ensure both match on the gdbarch when reusing an old
6444         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6445         a target with 64-bit float hardware.
6446
6447 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6448
6449         * source.c (search_command_helper): Stop reverse search
6450         when line 1 has been searched.
6451
6452 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6453
6454         * record-full.c (record_full_base_target::close): Rewrite
6455         record_full_core_buf_list free logic.
6456
6457 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6458
6459         * break-catch-syscall.c (print_one_catch_syscall): xfree
6460         the last text.
6461
6462 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6463
6464         * top.c (print_gdb_version): Update Copyright year in version
6465         message.
6466
6467 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6468
6469         Update copyright year range in all GDB files.
6470
6471 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6472
6473         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6474
6475 For older changes see ChangeLog-2018.
6476 \f
6477 Local Variables:
6478 mode: change-log
6479 left-margin: 8
6480 fill-column: 74
6481 version-control: never
6482 coding: utf-8
6483 End:
6484