gdb/ChangeLog

   1 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * symtab.c (struct demangled_name_entry) <language>: Change from
   4         bitfield to regular variable.
   5
   6 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
   7
   8         * symtab.c (struct demangled_name_entry): Add a constructor.
   9         (free_demangled_name_entry): New function to call the destructor
  10         for demangled_name_entry.
  11         (create_demangled_names_hash): Pass free_demangled_name_entry to
  12         htab_create_alloc.
  13         (symbol_set_names): Call placement new for demangled_name_entry.
  14         * utils.c: No longer include xxhash.h here, now that fast_hash
  15         is inlined in the header.
  16         * utils.h: Instead, include it here.
  17
  18 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * Makefile.in: Link with libxxhash.
  21         * config.in: Regenerate.
  22         * configure: Regenerate.
  23         * configure.ac: Search for libxxhash.
  24         * utils.c (fast_hash): Use xxhash if present.
  25
  26 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  27
  28         * utils.h (fast_hash): New function.
  29         * symtab.c (hash_demangled_name_entry): Call new function
  30         fast_hash.
  31
  32 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  33
  34         * symtab.c (struct demangled_name_entry): Change type of mangled
  35         to gdb::string_view. Also adds a constructor that takes the
  36         mangled name.
  37         (hash_demangled_name_entry): Update.
  38         (eq_demangled_name_entry): Update.
  39         (free_demangled_name_entry): New function to call the destructor
  40         now that this is not a POD anymore.
  41         (create_demangled_names_hash): Pass free_demangled_name_entry to
  42         htab_create_alloc.
  43         (symbol_set_names): Update.
  44
  45 2019-10-21  Ali Tamur  <tamu@google.com>
  46
  47         * dwarf2read.c (dir_index): Change type.
  48         (file_name_index): Likewise.
  49         (line_header::include_dir_at): Change comment and implementation on
  50         whether it is DWARF 5.
  51         (line_header::is_valid_file_index): New function.
  52         (line_header::file_name_at): Change comment and implementation on
  53         whether it is DWARF 5.
  54         (line_header::file_names): Change to private field renamed as
  55         m_file_names and introduce a new accessor method.
  56         (line_header::file_names_size): New method.
  57         (line_header::include_dirs): Change to private field and rename as
  58         m_include_dirs.
  59         (dw2_get_file_names_reader): Define local var at a smaller scope and
  60         reflect API change.
  61         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
  62         (process_structure_scope): Likewise.
  63         (line_header::add_include_dir): Change message and reflect renaming.
  64         (line_header::add_file_name): Likewise.
  65         (read_formatted_entries): Handle DW_FORM_data16.
  66         (dwarf_decode_line_header): Fix line header length calculation.
  67         (psymtab_include_file_name): Change comment and API.
  68         (lnp_state_machine::m_file): Update comment and reflect type change.
  69         (lnp_state_machine::record_line): Reflect type change.
  70         (dwarf_decode_lines): Reflect API change.
  71         (file_file_name): Likewise.
  72         (file_full_name): Likewise.
  73
  74 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
  77
  78 2019-10-21  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
  81
  82 2019-10-21  Tom Tromey  <tom@tromey.com>
  83
  84         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
  85         NM_H.   Use AC_CONFIG_LINKS.
  86         * configure: Rebuild.
  87         * Makefile.in (NM_H): New variable.
  88         (generated_files): Add NM_H.  Remove gcore.
  89         (nm.h, stamp-nmh): New targets.
  90
  91 2019-10-20  Tom Tromey  <tom@tromey.com>
  92
  93         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
  94         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
  95         obsolete comment.
  96         (put_objfile_before): Now static.
  97
  98 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
  99
 100         * gdbsupport/common-utils.h (startswith): Change return type to
 101         bool.
 102
 103 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 106         * breakpoint.c (bp_locations_compare): Rename to...
 107         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 108         (update_global_location_list): Use std::sort instead of qsort.
 109         * buildsym.c (compare_line_numbers): Rename to...
 110         (lte_is_less_than): ...this, and change to std::sort semantics.
 111         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 112         instead of qsort.
 113         * disasm.c (compare_lines): Rename to...
 114         (line_is_less_than): ...this, and change to std::sort semantics.
 115         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 116         of qsort.
 117         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 118         (fde_is_less_than): ...this, and change to std::sort semantics.
 119         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 120         * mdebugread.c (compare_blocks):
 121         (block_is_less_than): ...this, and change to std::sort semantics.
 122         (sort_blocks): Call std::sort instead of qsort.
 123         * objfiles.c (qsort_cmp): Rename to...
 124         (sort_cmp): ...this, and change to std::sort semantics.
 125         (update_section_map): Call std::sort instead of qsort.
 126         * remote.c (compare_pnums): Remove.
 127         (map_regcache_remote_table): Call std::sort instead of qsort.
 128         * utils.c (compare_positive_ints): Remove.
 129         * utils.h (compare_positive_ints): Remove.
 130         * xcoffread.c (compare_lte): Remove.
 131         (arrange_linetable): Call std::sort instead of qsort.
 132
 133 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 134
 135         * symfile.c (init_entry_point_info): Fix typo.
 136         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 137
 138 2019-10-18  Tom de Vries  <tdevries@suse.de>
 139
 140         * aarch64-tdep.c: Fix typos in comments.
 141         * ada-lang.c: Same.
 142         * ada-tasks.c: Same.
 143         * alpha-tdep.c: Same.
 144         * alpha-tdep.h: Same.
 145         * amd64-nat.c: Same.
 146         * amd64-windows-tdep.c: Same.
 147         * arc-tdep.c: Same.
 148         * arc-tdep.h: Same.
 149         * arch-utils.c: Same.
 150         * arm-nbsd-tdep.c: Same.
 151         * arm-tdep.c: Same.
 152         * ax-gdb.c: Same.
 153         * blockframe.c: Same.
 154         * btrace.c: Same.
 155         * c-varobj.c: Same.
 156         * coff-pe-read.c: Same.
 157         * coffread.c: Same.
 158         * cris-tdep.c: Same.
 159         * darwin-nat.c: Same.
 160         * dbxread.c: Same.
 161         * dcache.c: Same.
 162         * disasm.c: Same.
 163         * dtrace-probe.c: Same.
 164         * dwarf-index-write.c: Same.
 165         * dwarf2-frame-tailcall.c: Same.
 166         * dwarf2-frame.c: Same.
 167         * dwarf2read.c: Same.
 168         * eval.c: Same.
 169         * exceptions.c: Same.
 170         * fbsd-tdep.c: Same.
 171         * findvar.c: Same.
 172         * frame.c: Same.
 173         * frv-tdep.c: Same.
 174         * gnu-v3-abi.c: Same.
 175         * go32-nat.c: Same.
 176         * h8300-tdep.c: Same.
 177         * hppa-tdep.c: Same.
 178         * i386-linux-tdep.c: Same.
 179         * i386-tdep.c: Same.
 180         * ia64-libunwind-tdep.c: Same.
 181         * ia64-tdep.c: Same.
 182         * infcmd.c: Same.
 183         * infrun.c: Same.
 184         * linespec.c: Same.
 185         * linux-nat.c: Same.
 186         * linux-thread-db.c: Same.
 187         * machoread.c: Same.
 188         * mdebugread.c: Same.
 189         * mep-tdep.c: Same.
 190         * mn10300-tdep.c: Same.
 191         * namespace.c: Same.
 192         * objfiles.c: Same.
 193         * opencl-lang.c: Same.
 194         * or1k-tdep.c: Same.
 195         * osabi.c: Same.
 196         * ppc-linux-nat.c: Same.
 197         * ppc-linux-tdep.c: Same.
 198         * ppc-sysv-tdep.c: Same.
 199         * printcmd.c: Same.
 200         * procfs.c: Same.
 201         * record-btrace.c: Same.
 202         * record-full.c: Same.
 203         * remote-fileio.c: Same.
 204         * remote.c: Same.
 205         * rs6000-tdep.c: Same.
 206         * s12z-tdep.c: Same.
 207         * score-tdep.c: Same.
 208         * ser-base.c: Same.
 209         * ser-go32.c: Same.
 210         * skip.c: Same.
 211         * sol-thread.c: Same.
 212         * solib-svr4.c: Same.
 213         * solib.c: Same.
 214         * source.c: Same.
 215         * sparc-nat.c: Same.
 216         * sparc-sol2-tdep.c: Same.
 217         * sparc-tdep.c: Same.
 218         * sparc64-tdep.c: Same.
 219         * stabsread.c: Same.
 220         * stack.c: Same.
 221         * symfile.c: Same.
 222         * symtab.c: Same.
 223         * target-descriptions.c: Same.
 224         * target-float.c: Same.
 225         * thread.c: Same.
 226         * utils.c: Same.
 227         * valops.c: Same.
 228         * valprint.c: Same.
 229         * value.c: Same.
 230         * varobj.c: Same.
 231         * windows-nat.c: Same.
 232         * xcoffread.c: Same.
 233         * xstormy16-tdep.c: Same.
 234         * xtensa-tdep.c: Same.
 235
 236 2019-10-17  Tom Tromey  <tromey@adacore.com>
 237
 238         * configure: Rebuild.
 239         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 240         in AC_CONFIG_FILES invocation.
 241         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 242         new-style config.status invocation.
 243
 244 2019-10-17  Tom de Vries  <tdevries@suse.de>
 245
 246         * arm-nbsd-nat.c: Fix typos in comments.
 247         * arm-tdep.c: Same.
 248         * darwin-nat-info.c: Same.
 249         * dwarf2read.c: Same.
 250         * elfread.c: Same.
 251         * event-top.c: Same.
 252         * findvar.c: Same.
 253         * gdbtypes.c: Same.
 254         * hppa-tdep.c: Same.
 255         * i386-tdep.c: Same.
 256         * jit.c: Same.
 257         * main.c: Same.
 258         * mdebugread.c: Same.
 259         * moxie-tdep.c: Same.
 260         * nto-procfs.c: Same.
 261         * osabi.c: Same.
 262         * ppc-linux-tdep.c: Same.
 263         * remote.c: Same.
 264         * riscv-tdep.c: Same.
 265         * s390-tdep.c: Same.
 266         * sh-tdep.c: Same.
 267         * sparc-linux-tdep.c: Same.
 268         * sparc-nat.c: Same.
 269         * stack.c: Same.
 270         * target-descriptions.c: Same.
 271         * top.c: Same.
 272         * varobj.c: Same.
 273
 274 2019-10-16  Tom Tromey  <tom@tromey.com>
 275
 276         * objfiles.h (struct objfile) <original_name>: Now const.
 277
 278 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 279
 280         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 281         pass on to sigsetjmp's second argument.
 282         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 283
 284 2019-10-16  Keith Seitz  <keiths@redhat.com>
 285
 286         PR gdb/23567
 287         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 288         sections whose size is greater than the file size.
 289
 290 2019-10-16  Jim Wilson  <jimw@sifive.com>
 291
 292         * riscv-tdep.c (riscv_gcc_target_options): New.
 293         (riscv_gnu_triplet_regexp): New.
 294         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 295         set_gdbarch_gnu_triplet_regexp.
 296
 297 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 298
 299         * Makefile.in: Add xml-builtin.h.
 300         * features/feature_to_c.sh: Add an include for xml-builtin.h
 301         to ensure that the compiler checks that the types match.
 302         * xml-builtin.h: New file.
 303         * xml-support.c (fetch_xml_builtin): Add missing const.
 304         * xml-support.h: Remove declaration of xml_builtins.
 305
 306 2019-10-16  Tom de Vries  <tdevries@suse.de>
 307
 308         PR tdep/25096
 309         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 310         (amd64_classify_aggregate): ... here.
 311         (amd64_classify_aggregate_field): Handled fiels of nested structs
 312         recursively.
 313
 314 2019-10-16  Tom de Vries  <tdevries@suse.de>
 315
 316         PR tdep/24104
 317         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 318         that handles 'theclass'.
 319
 320 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 321
 322         * linespec.c (decode_digits_ordinary): Update comment.
 323         * make-target-delegates: No longer need to handle VEC case.
 324         * memrange.c (normalize_mem_ranges): Update comment.
 325         * namespace.c (add_using_directive): Update comment.
 326         * objc-lang.c (uniquify_strings): Update comment.
 327         * ppc-linux-nat.c (struct thread_points): Update comment.
 328         * probe.h (find_probes_in_objfile): Update comment.
 329         * target.h (enum flash_preserve_mode): Update comment.
 330         * varobj.c (varobj_restrict_range): Update comment.
 331         * varobj.h (varobj_list_children): Update comment.
 332
 333 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 334
 335         * Makefile.in: Remove references to vec.h and vec.c.
 336         * aarch64-tdep.c: No longer include vec.h.
 337         * ada-lang.c: Likewise.
 338         * ada-lang.h: Likewise.
 339         * arm-tdep.c: Likewise.
 340         * ax.h: Likewise.
 341         * breakpoint.h: Likewise.
 342         * charset.c: Likewise.
 343         * cp-support.h: Likewise.
 344         * dtrace-probe.c: Likewise.
 345         * dwarf2read.c: Likewise.
 346         * extension.h: Likewise.
 347         * gdb_bfd.c: Likewise.
 348         * gdbsupport/gdb_vecs.h: Likewise.
 349         * gdbsupport/vec.c: Remove.
 350         * gdbsupport/vec.h: Remove.
 351         * gdbthread.h: Likewise.
 352         * guile/scm-type.c: Likewise.
 353         * inline-frame.c: Likewise.
 354         * machoread.c: Likewise.
 355         * memattr.c: Likewise.
 356         * memrange.h: Likewise.
 357         * namespace.h: Likewise.
 358         * nat/linux-btrace.h: Likewise.
 359         * osdata.c: Likewise.
 360         * parser-defs.h: Likewise.
 361         * progspace.h: Likewise.
 362         * python/py-type.c: Likewise.
 363         * record-btrace.c: Likewise.
 364         * rust-exp.y: Likewise.
 365         * solib-target.c: Likewise.
 366         * stap-probe.c: Likewise.
 367         * target-descriptions.c: Likewise.
 368         * target-memory.c: Likewise.
 369         * target.h: Likewise.
 370         * varobj.c: Likewise.
 371         * varobj.h: Likewise.
 372         * xml-support.h: Likewise.
 373
 374 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 375
 376         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 377         Update for new std::vector based implementation.
 378         (process_psymtab_comp_unit_reader): Likewise.
 379         (scan_partial_symbols): Likewise.
 380         (recursively_compute_inclusions): Likewise.
 381         (compute_compunit_symtab_includes): Likewise.
 382         (process_imported_unit_die): Likewise.
 383         (queue_and_load_dwo_tu): Likewise.
 384         (follow_die_sig_1): Likewise.
 385         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 386         (typedef dwarf2_per_cu_ptr): Remove.
 387         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 388         function.
 389         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 390         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 391         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 392         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 393         std::vector.
 394
 395 2019-10-15  Tom Tromey  <tromey@adacore.com>
 396
 397         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 398         TID.
 399
 400 2019-10-15  Tom Tromey  <tromey@adacore.com>
 401
 402         * windows-nat.c (windows_nat_target::fetch_registers)
 403         (windows_nat_target::store_registers): Rename "pid" to "tid".
 404
 405 2019-10-15  Tom Tromey  <tromey@adacore.com>
 406
 407         * gdbarch.h, gdbarch.c: Rebuild.
 408         * gdbarch.sh (gcc_target_options): Change return type to
 409         std::string.
 410         * compile/compile.c (get_args): Update.
 411         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 412         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 413         std::string.
 414         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 415         std::string.
 416         * arch-utils.c (default_gcc_target_options): Return std::string.
 417         * arch-utils.h (default_gcc_target_options): Return std::string.
 418         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 419
 420 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 421
 422         * breakpoint.c (breakpoint_chain): Make static.
 423         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 424         of accessing breakpoint_chain.
 425
 426 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 427
 428         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 429         to a gdb::function_view and return value to bool.
 430         * breakpoint.h (iterate_over_breakpoints): Likewise.
 431         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 432         (pop_dummy_frame): Update.
 433         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 434         (gdbscm_breakpoints): Update.
 435         * python/py-breakpoint.c (build_bp_list): Update.
 436         (gdbpy_breakpoints): Update.
 437         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 438         Update.
 439         (bpfinishpy_handle_stop): Update.
 440         (bpfinishpy_handle_exit): Update.
 441         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 442         (svr4_update_solib_event_breakpoints): Update.
 443
 444 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 445
 446         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 447         when unwrapping single-field structs.
 448
 449 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 450
 451         * dwarf2read.c: Remove includes.
 452
 453 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 454
 455         * ui-out.c (ui_out::call_do_message): Silence
 456         -Wformat-nonliteral warning.
 457
 458 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 459
 460         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 461         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 462         include: readline/tilde.h.
 463
 464 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 465
 466         * remote.c (remote_target::get_trace_status): Remove declaration of
 467         trace_regblock_size.
 468
 469 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 470
 471         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 472         (show_user): Remove declaration of cmdlist.
 473         * cli/cli-cmds.h (max_user_call_depth): Declare.
 474         * cli/cli-script.c (execute_user_command): Remove declaration
 475         of max_user_call_depth.
 476
 477 2019-10-11  Jim Wilson  <jimw@sifive.com>
 478
 479         * gdbsupport/print-utils.h (pulongest): Fix comment.
 480         (plongest): Likewise.
 481         (phex): Add missing comment, mention leading zeros.
 482         (phex_nz): Add mention of no leading zeros to comment.
 483
 484         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 485         plongest instead of unsigned long long cast.
 486
 487 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 488
 489         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 490         for external_editor_command and gdbtk_test.
 491
 492 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 493
 494         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 495         * varobj.c (varobjdebug): Move comment to...
 496         * varobj.h (varobjdebug): ...here, and declare.
 497
 498 2019-10-09  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 501         erase_data_content.
 502
 503 2019-10-09  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 506         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 507         * tui/tui-command.c (tui_cmd_window::resize)
 508         (tui_refresh_cmd_win): Update.
 509         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 510         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 511         * tui/tui-data.c (~tui_gen_win_info): Remove.
 512         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 513         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 514         (tui_redisplay_readline, tui_mld_flush)
 515         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 516         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 517         (tui_data_window::erase_data_content)
 518         (tui_data_item_window::rerender)
 519         (tui_data_item_window::refresh_window): Update.
 520         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 521         (box_win, tui_gen_win_info::make_window)
 522         (tui_gen_win_info::make_visible): Update.
 523         (tui_delete_win): Remove.
 524         * tui/tui-winsource.c
 525         (tui_source_window_base::do_erase_source_content): Update.
 526         (tui_show_source_line, tui_source_window_base::update_tab_width)
 527         (tui_source_window_base::update_exec_info): Update.
 528         * tui/tui-data.h (struct curses_deleter): New.
 529         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 530         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 531
 532 2019-10-09  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 535
 536 2019-10-09  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 539         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 540
 541 2019-10-09  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 544         window height directly.
 545         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 546         declare.
 547         * tui/tui-layout.c (tui_default_win_height): Remove.
 548         (tui_default_win_viewport_height): Remove.
 549
 550 2019-10-09  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui.h: Remove comments.
 553
 554 2019-10-09  Tom de Vries  <tdevries@suse.de>
 555
 556         * python/lib/gdb/printer/bound_registers.py: Use
 557         '^builtin_type_bound128' as regexp argument for
 558         add_builtin_pretty_printer.
 559
 560 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 561
 562         * guile/guile.c (guile_extension_script_ops): Remove forward
 563         declaration and mark as static.
 564         (guile_script_ops): Likewise.
 565         (extension_language_guile): Move further down in the file so
 566         it can reference the definitions for guile_{extension_,}script_ops.
 567
 568 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 569
 570         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 571         except SORTL, DFLTCC, and KDSA.
 572
 573 2019-10-08  Tom Tromey  <tromey@adacore.com>
 574
 575         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 576         (struct safe_symbol_file_add_args): Remove.
 577
 578 2019-10-08  Tom Tromey  <tromey@adacore.com>
 579
 580         * windows-nat.c: Don't include buildsym-legacy.h.
 581
 582 2019-10-08  Tom Tromey  <tromey@adacore.com>
 583
 584         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 585
 586 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 587
 588         * gdbtypes.c (overload_debug): Move comment to header.
 589         * gdbtypes.h (overload_debug): Declare.
 590         * valops.c: Remove declaration of overload_debug, instead
 591         include gdbtypes.h.
 592
 593 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 594
 595         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 596         through _().
 597         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 598         move comment...
 599         * language.h (lang_frame_mismatch_warn): ... here. Also add
 600         declaration.
 601         * top.c (lang_frame_mismatch_warn): Remove declaration.
 602         (check_frame_language_change): Pass lang_frame_mismatch_warn
 603         through _().
 604
 605 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 606
 607         * c-lang.h (vtbl_ptr_name): Declare.
 608         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 609         it from the header.
 610         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 611
 612 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 613
 614         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 615         gdb_static_assert.
 616
 617 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 618
 619         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 620         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 621         * ctfread.c: New file.
 622         * ctfread.h: New file.
 623         * elfread.c: Include ctfread.h.
 624         (struct elfinfo text_p): New member ctfsect.
 625         (elf_locate_sections): Mark CTF section.
 626         (elf_symfile_read): Call elfctf_build_psymtabs.
 627         * Makefile.in (LIBCTF): Add.
 628         (CLIBS): Use it.
 629         (CDEPS): Likewise.
 630         (DIST): Add ctfread.c.
 631
 632 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         * ctfread.c (struct nextfield): Renamed to ...
 635         (struct ctf_nextfield): ... this.
 636         (struct field_info): Renamed to ...
 637         (strut ctf_field_info): ... this.
 638         (attach_fields_to_type): Update for renamed structures.
 639         (ctf_add_member_cb): Likewise.
 640         (ctf_add_enum_member_cb): Likewise.
 641         (process_struct_members): Likewise.
 642         (process_enum_type): Likewise.
 643
 644 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 645
 646         * tracectf.h: Rename, was ctf.h.
 647         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 648         * tracefile.c: Likewise.
 649         * tracepoint.c: Remove unused include ctf.h.
 650         * mi/mi-main.c: Likewise.
 651         * Makefile.in Replace ctf.c with tracectf.c.
 652
 653 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 654
 655         * version.in: Change version number to "9.0.50.DATE-git".
 656
 657 2019-10-03  Tom Tromey  <tom@tromey.com>
 658
 659         PR rust/24976:
 660         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 661
 662 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 665         cp_search_name_hash.
 666         * NEWS: Add entry about nested function support.
 667
 668 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 669             Andrew Burgess  <andrew.burgess@embecosm.com>
 670
 671         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 672         for nested static variables when searchin VAR_DOMAIN.
 673         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 674         global scope, update comment.
 675         (add_partial_subprogram): Call add_partial_subprogram recursively
 676         for nested subroutines when processinng Fortran.
 677         (load_partial_dies): Process the child entities of a subprogram
 678         when processing Fortran.
 679         (partial_die_parent_scope): Handle building scope
 680         for Fortran nested functions.
 681         (process_die): Record that nested functions have a scope.
 682         (new_symbol): Always record Fortran subprograms on the global
 683         symbol list.
 684         (determine_prefix): How to build the prefix for Fortran
 685         subprograms.
 686
 687 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 688
 689         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 690         have just sent the thread a SIGSTOP and are waiting for it to
 691         arrive.
 692
 693 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 694
 695         * btrace.c (btrace_add_pc): Remove whitespace before the template
 696         parameter in 'std::vector <...>'.
 697         (parse_xml_btrace_block): Likewise.
 698         (btrace_maint_decode_pt): Likewise.
 699         (btrace_maint_update_packets): Likewise.
 700         (btrace_maint_print_packets): Likewise.
 701         * btrace.h (struct btrace_maint_info): Likewise.
 702         * dwarf2read.c (struct type_unit_group): Likewise.
 703         (build_type_psymtabs_reader): Likewise.
 704         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 705         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 706         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 707
 708 2019-10-03  Tom de Vries  <tdevries@suse.de>
 709
 710         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 711         the first line of the help text for set/show style metadata.
 712
 713 2019-10-02  Tom Tromey  <tromey@adacore.com>
 714
 715         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 716         * gdbsupport/common-inferior.c: New file.
 717         * infcmd.c (startup_with_shell): Don't define.
 718         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 719         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 720         * inferior.h (startup_with_shell): Don't declare.
 721
 722 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 723
 724         * gdbsupport/gdb_assert.h: Include errors.h.
 725         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 726
 727 2019-10-02  Tom Tromey  <tromey@adacore.com>
 728
 729         * NEWS: Add $_ada_exception entry.
 730         * ada-lang.c (struct ada_catchpoint): Add constructor.
 731         <m_kind>: New member.
 732         (allocate_location_exception, re_set_exception): Remove
 733         "ex" parameter.
 734         (should_stop_exception): Compute $_ada_exception.
 735         (check_status_exception, print_it_exception)
 736         (print_one_exception, print_mention_exception): Remove
 737         "ex" parameter.
 738         (allocate_location_catch_exception, re_set_catch_exception)
 739         (check_status_exception, print_it_catch_exception)
 740         (print_one_catch_exception, print_mention_catch_exception)
 741         (print_recreate_catch_exception)
 742         (allocate_location_catch_exception_unhandled)
 743         (re_set_catch_exception_unhandled)
 744         (check_status_exception, print_it_catch_exception_unhandled)
 745         (print_one_catch_exception_unhandled)
 746         (print_mention_catch_exception_unhandled)
 747         (print_recreate_catch_exception_unhandled)
 748         (allocate_location_catch_assert, re_set_catch_assert)
 749         (check_status_assert, print_it_catch_assert)
 750         (print_one_catch_assert, print_mention_catch_assert)
 751         (print_recreate_catch_assert)
 752         (allocate_location_catch_handlers, re_set_catch_handlers)
 753         (check_status_handlers, print_it_catch_handlers)
 754         (print_one_catch_handlers, print_mention_catch_handlers)
 755         (print_recreate_catch_handlers): Remove.
 756         (create_ada_exception_catchpoint): Update.
 757         (initialize_ada_catchpoint_ops): Update.
 758
 759 2019-10-02  Tom Tromey  <tromey@adacore.com>
 760
 761         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 762         (create_excep_cond_exprs): Simplify exception string computation.
 763         (ada_exception_catchpoint_cond_string): Likewise.
 764
 765 2019-10-02  Tom Tromey  <tromey@adacore.com>
 766
 767         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 768         * ada-lang.c (lesseq_defined_than): Handle
 769         LOC_STATIC.
 770         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 771         parameter.
 772         (dwarf2_has_info): Likewise.
 773         (new_symbol): Set maybe_copied on symbol when
 774         appropriate.
 775         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 776         parameter.
 777         <can_copy>: New member.
 778         * elfread.c (record_minimal_symbol): Set maybe_copied
 779         on symbol when appropriate.
 780         (elf_symfile_read): Update call to dwarf2_has_info.
 781         * minsyms.c (lookup_minimal_symbol_linkage): New
 782         function.
 783         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 784         * symtab.c (get_symbol_address, get_msymbol_address):
 785         New functions.
 786         * symtab.h (get_symbol_address, get_msymbol_address):
 787         Declare.
 788         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 789         maybe_copied.
 790         (struct symbol, struct minimal_symbol) <maybe_copied>:
 791         New member.
 792
 793 2019-10-02  Tom Tromey  <tromey@adacore.com>
 794
 795         * source.c (struct current_source_location): New.
 796         (current_source_key): New global.
 797         (current_source_symtab, current_source_line)
 798         (current_source_pspace): Remove.
 799         (get_source_location): New function.
 800         (get_current_source_symtab_and_line)
 801         (set_default_source_symtab_and_line)
 802         (set_current_source_symtab_and_line)
 803         (clear_current_source_symtab_and_line, select_source_symtab)
 804         (info_source_command, print_source_lines_base)
 805         (info_line_command, search_command_helper, _initialize_source):
 806         Update.
 807
 808 2019-10-02  Tom Tromey  <tromey@adacore.com>
 809
 810         * source.c (select_source_symtab): Don't call
 811         decode_line_with_current_source.
 812
 813 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 814
 815         * symtab.c (lookup_global_symbol): Search global block.
 816
 817 2019-10-02  Tom Tromey  <tromey@adacore.com>
 818
 819         * coffread.c (process_coff_symbol): Update.
 820         * dwarf2read.c (var_decode_location, new_symbol): Update.
 821         * mdebugread.c (parse_symbol): Update.
 822         * objfiles.c (relocate_one_symbol): Update.
 823         * stabsread.c (define_symbol, fix_common_block)
 824         (scan_file_globals): Update.
 825         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 826         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 827         * xcoffread.c (process_xcoff_symbol): Update.
 828
 829 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 830
 831         * MAINTAINERS: Update my email address.
 832
 833 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 836         std::vector.
 837         (build_type_psymtabs_reader): Update for std::vector.
 838         (build_type_psymtab_dependencies): Likewise.
 839         * dwarf2read.h: Remove use of DEF_VEC_P.
 840         (typedef sig_type_ptr): Delete.
 841
 842 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 843
 844         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 845         to std::vector.
 846         (btrace_maint_decode_pt): Likewise, and move allocation of the
 847         vector outside of the loop.
 848         (btrace_maint_update_packets): Update to handle change from VEC to
 849         std::vector.
 850         (btrace_maint_print_packets): Likewise.
 851         (maint_info_btrace_cmd): Likewise.
 852         * btrace.h: Remove use of DEF_VEC_O.
 853         (typedef btrace_pt_packet_s): Delete.
 854         (struct btrace_maint_info) <packets>: Change fromm VEC to
 855         std::vector.
 856         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 857
 858 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 859
 860         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 861         make accesses into the vector constant references.
 862         (btrace_add_pc): Update for std::vector.
 863         (btrace_stitch_bts): Likewise.
 864         (parse_xml_btrace_block): Likewise.
 865         (btrace_maint_update_packets): Likewise.
 866         (btrace_maint_print_packets): Likewise.
 867         (maint_info_btrace_cmd): Likewise.
 868         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 869         std::vector.
 870         (btrace_data::empty): Likewise.
 871         (btrace_data_append): Likewise.
 872         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 873         (typedef btrace_block_s): Delete.
 874         (struct btrace_block): Add constructor.
 875         (struct btrace_data_bts) <blocks>: Change to std::vector.
 876         * nat/linux-btrace.c (perf_event_read_bts): Update for
 877         std::vector.
 878         (linux_read_bts): Likewise.
 879
 880 2019-10-01  Tom Tromey  <tom@tromey.com>
 881
 882         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 883
 884 2019-10-01  Tom Tromey  <tom@tromey.com>
 885
 886         * stack.c (print_frame, info_frame_command_core): Use
 887         styled_string.
 888         * linux-thread-db.c (try_thread_db_load_1)
 889         (try_thread_db_load_from_pdir_1): Use styled_string.
 890         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 891         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 892         (maybe_print_unsupported_script_warning)
 893         (maybe_print_script_not_found_warning): Use styled_string.
 894         * ada-lang.c (user_select_syms): Use styled_string.
 895
 896 2019-10-01  Tom Tromey  <tom@tromey.com>
 897
 898         * p-lang.c (pascal_printstr): Use metadata style.
 899         * value.c (show_convenience): Use metadata style.
 900         * valprint.c (valprint_check_validity, val_print_optimized_out)
 901         (val_print_not_saved, val_print_unavailable)
 902         (val_print_invalid_address, generic_val_print, val_print)
 903         (value_check_printable, val_print_array_elements): Use metadata
 904         style.
 905         * ui-out.h (class ui_out) <field_fmt>: New overload.
 906         <do_field_fmt>: Add style parameter.
 907         * ui-out.c (ui_out::field_fmt): New overload.
 908         * typeprint.c (type_print_unknown_return_type)
 909         (val_print_not_allocated, val_print_not_associated): Use metadata
 910         style.
 911         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 912         parameter.
 913         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 914         * tracepoint.c (tvariables_info_1): Use metadata style.
 915         * stack.c (print_frame_arg, print_frame_info, print_frame)
 916         (info_frame_command_core): Use metadata style.
 917         * skip.c (info_skip_command): Use metadata style.
 918         * rust-lang.c (rust_print_enum): Use metadata style.
 919         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 920         metadata style.
 921         * python/py-framefilter.c (py_print_single_arg): Use metadata
 922         style.
 923         * printcmd.c (do_one_display, print_variable_and_value): Use
 924         metadata style.
 925         * p-valprint.c (pascal_val_print)
 926         (pascal_object_print_value_fields): Use metadata style.
 927         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 928         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 929         parameter.
 930         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 931         * m2-valprint.c (m2_print_long_set): Use metadata style.
 932         * m2-typeprint.c (m2_print_type): Use metadata style.
 933         * infcmd.c (print_return_value_1): Use metadata style.
 934         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 935         * f-valprint.c (info_common_command_for_block): Use metadata
 936         style.
 937         * f-typeprint.c (f_type_print_base): Use metadata style.
 938         * expprint.c (print_subexp_standard): Use metadata style.
 939         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 940         * cli/cli-style.h (class cli_style_option): Add constructor.
 941         (metadata_style): Declare.
 942         * cli/cli-style.c (metadata_style): New global.
 943         (_initialize_cli_style): Register metadata style.
 944         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 945         parameter.
 946         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 947         * c-typeprint.c (c_type_print_base_struct_union)
 948         (c_type_print_base_1): Use metadata style.
 949         * breakpoint.c (watchpoint_value_print)
 950         (print_one_breakpoint_location): Use metadata style.
 951         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 952         style.
 953         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 954         style.
 955         * ada-valprint.c (val_print_packed_array_elements, printstr)
 956         (print_field_values, ada_val_print_ref, ada_val_print): Use
 957         metadata style.
 958         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 959         style.
 960         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 961         style.
 962         * ada-lang.c (user_select_syms): Use metadata style.
 963
 964 2019-10-01  Tom Tromey  <tom@tromey.com>
 965
 966         * cli/cli-cmds.c (pwd_command): Style output.
 967
 968 2019-10-01  Pedro Alves  <palves@redhat.com>
 969             Tom Tromey  <tom@tromey.com>
 970
 971         * symtab.c (print_symbol_info): Use %ps.
 972         (print_msymbol_info): Use %ps.
 973         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 974         * printcmd.c (print_variable_and_value): Use %ps.
 975         * macrocmd.c (show_pp_source_pos): Use %ps.
 976         * infrun.c (print_exited_reason): Use ui_out::message.
 977         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 978         (describe_other_breakpoints): Use ui_out::message and new
 979         formats.
 980         (say_where): Use new formats.
 981         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 982         and new formats.
 983
 984 2019-10-01  Pedro Alves  <palves@redhat.com>
 985             Tom Tromey  <tom@tromey.com>
 986
 987         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 988         (test_gdb_formats): New function.
 989         (run_tests): Call it.
 990         (test_format_specifier): Update.
 991         * utils.h (fputs_filtered): Update comment.
 992         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 993         (fputs_styled_unfiltered): Declare.
 994         * utils.c (fputs_styled_unfiltered): New function.
 995         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 996         (vfprintf_filtered): Update.
 997         (vfprintf_unfiltered, vprintf_filtered): Update.
 998         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 999         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1000         disallow_ui_out_field>: New constants.
1001         (enum class field_kind): New.
1002         (struct base_field_s, struct signed_field_s): New.
1003         (signed_field): New function.
1004         (struct string_field_s): New.
1005         (string_field): New function.
1006         (struct styled_string_s): New.
1007         (styled_string): New function.
1008         (class ui_out) <message>: Add comment.
1009         <vmessage, call_do_message>: New methods.
1010         <do_message>: Add style parameter.
1011         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1012         methods.
1013         (ui_out::message): Rewrite.
1014         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1015         parameter.
1016         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1017         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1018         gdb_extensions parameter.
1019         (class format_piece): Add parameter to constructor.
1020         (n_int_args): New field.
1021         * gdbsupport/format.c (format_pieces::format_pieces): Add
1022         gdb_extensions parameter.  Handle '*'.
1023         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1024         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1025         vfprintf_styled_no_gdbfmt.
1026         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1027         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1028         unfiltered output.
1029         * ui-style.h (struct ui_file_style) <ptr>: New method.
1030
1031 2019-10-01  Tom Tromey  <tom@tromey.com>
1032
1033         * unittests/format_pieces-selftests.c: Update.  Add final format.
1034         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1035         empty literal pieces.
1036
1037 2019-10-01  Tom Tromey  <tom@tromey.com>
1038
1039         * ui-out.h (enum class ui_out_style_kind): Remove.
1040         (class ui_out) <field_string, field_stsream, do_field_string>:
1041         Change type of "style".
1042         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1043         (ui_out::field_string): Update.
1044         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1045         of "style".
1046         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1047         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1048         * stack.c (print_frame_arg, print_frame_info, print_frame):
1049         Update.
1050         * source.c (print_source_lines_base): Update.
1051         * solib.c (info_sharedlibrary_command): Update.
1052         * skip.c (info_skip_command): Update.
1053         * record-btrace.c (btrace_call_history_src_line)
1054         (btrace_call_history): Update.
1055         * python/py-framefilter.c (py_print_frame): Update.
1056         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1057         "style".
1058         * mi/mi-out.c (mi_ui_out::do_table_header)
1059         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1060         (mi_ui_out::do_field_string): Update.
1061         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1062         Update.
1063         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1064         "style".
1065         * cli-out.c (cli_ui_out::do_table_header)
1066         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1067         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1068         (cli_ui_out::do_field_fmt): Update.
1069         * breakpoint.c (print_breakpoint_location): Update.
1070         (update_static_tracepoint): Update.
1071
1072 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1073
1074         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1075         conversion of gdb_datadir.
1076         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1077         remove not needed c_str ().
1078
1079 2019-09-30  Ali Tamur <tamur@google.com>
1080
1081         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1082         (dwarf2_string_attr): Likewise.
1083
1084 2019-09-30  Ali Tamur <tamur@google.com>
1085
1086         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1087         (process_full_type_unit): Likewise.
1088         (dump_die_shallow): Likewise.
1089         (cu_debug_loc_section): Likewise.
1090
1091 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1092
1093         * minsyms.c (compare_minimal_symbols): Rename to...
1094         (minimal_symbol_is_less_than): ...this, and adjust to STL
1095         conventions (return bool, take arguments as references)
1096         (minimal_symbol_reader::install): Call std::sort instead
1097         of qsort.
1098
1099 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1100
1101         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1102         hash and why.
1103         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1104         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1105
1106 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1107
1108         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1109         * psympriv.h (add_psymbol_to_list): Move comment here and update
1110         it.
1111
1112 2019-09-29  Tom de Vries  <tdevries@suse.de>
1113
1114         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1115         Use $tmpdir/$(basename "$output_file").dwz instead of
1116         "${output_file}.dwz".
1117
1118 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1119
1120         PR gdb/25045
1121         * hppa-linux-nat.c: Include gdbarch.h.
1122
1123 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1124
1125         * blockframe.c (find_pc_partial_function): Change return type to bool.
1126         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1127         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1128         (stub_gnu_ifunc_resolve_name): Likewise.
1129         * symtab.c (compare_filenames_for_search): Likewise.
1130         (compare_glob_filenames_for_search): Likewise.
1131         (matching_obj_sections): Likewise.
1132         (symbol_matches_domain): Likewise.
1133         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1134         (find_line_pc): Change return type to bool.
1135         (find_line_pc_range): Likewise.
1136         (producer_is_realview): Likewise.
1137         * symtab.h (symbol_matches_domain): Likewise.
1138         (find_pc_partial_function): Likewise.
1139         (find_pc_line_pc_range): Likewise.
1140         (in_gnu_ifunc_stub): Likewise.
1141         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1142         (find_line_pc): Likewise.
1143         (find_line_pc_range): Likewise.
1144         (matching_obj_sections): Likewise.
1145         (find_line_symtab): Change out parameter to bool.
1146         (producer_is_realview): Change return type to bool.
1147         (compare_filenames_for_search): Likewise.
1148         (compare_glob_filenames_for_search): Likewise.
1149
1150 2019-09-26  Tom Tromey  <tom@tromey.com>
1151
1152         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1153         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1154         * gdb_usleep.h: Remove.
1155         * gdb_usleep.c: Remove.
1156         * utils.c: Don't include gdb_usleep.h.
1157
1158 2019-09-26  Tom Tromey  <tromey@adacore.com>
1159
1160         * python/py-type.c (type_to_type_object): Call check_typedef
1161         for stub types.
1162
1163 2019-09-26  Tom Tromey  <tom@tromey.com>
1164
1165         * utils.h (initialize_utils): Don't declare.
1166         * top.c (gdb_init): Don't call initialize_utils.
1167         * utils.c (initialize_utils): Remove.  Move contents...
1168         (_initialize_utils): ... here.
1169
1170 2019-09-25  Tom Tromey  <tom@tromey.com>
1171
1172         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1173         * utils.h (make_hex_string): Don't declare.
1174         * utils.c (make_hex_string): Remove.
1175
1176 2019-09-24  Tom de Vries  <tdevries@suse.de>
1177
1178         PR gdb/23815
1179         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1180         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1181
1182 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1183
1184         * NEWS: Mention new simulator port for PRU.
1185
1186 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1187
1188         * ada-exp.y (write_object_remaining): Update.
1189         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1190         and eliminate the static buffer.
1191         (ada_decode_symbol): Update.
1192         (ada_la_decode): Update.
1193         (ada_sniff_from_mangled_name): Update.
1194         (is_valid_name_for_wild_match): Update.
1195         (ada_lookup_name_info::matches): Update and simplify.
1196         (name_matches_regex): Update.
1197         (ada_add_global_exceptions): Update.
1198         * ada-lang.h (ada_decode): Update signature.
1199         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1200         * dwarf-index-write.c (debug_names::insert): Update.
1201
1202 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1203
1204         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1205         formatting.
1206
1207 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1208
1209         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1210         Change "nonzero" to "true" in documentation.
1211
1212 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1213
1214         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1215         (_initialize_darwin_solib): Don't set
1216         darwin_so_ops.lookup_lib_global_symbol.
1217         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1218         set_gdbarch_iterate_over_objfiles_in_search_order.
1219         (elf_lookup_lib_symbol): Rename to...
1220         (svr4_iterate_over_objfiles_in_search_order): this, and update
1221         to iterate semantics.
1222         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1223         * solib.c (solib_global_lookup): Remove.
1224         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1225         (solib_global_lookup): Remove.
1226         * symtab.c (lookup_global_or_static_symbol): Remove call to
1227         solib_global_lookup.
1228
1229 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1230
1231         * NEWS: Move entries about default MI version now being
1232         version 3, and about the GDB/MI fix for multi-location
1233         breakpoints to the "since GDB 8.3" section.
1234
1235 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1236
1237         GDB 8.3.1 released.
1238
1239 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1240
1241         * NEWS: Mention that Cell/B.E. debugging support was removed.
1242         * MAINTAINERS: Remove spu target.
1243
1244         * config/djgpp/fnchange.lst: Remove entries for removed files.
1245
1246         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1247         spu-multiarch.o, and spu-tdep.o.
1248         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1249         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1250         spu-multiarch.c, and spu-tdep.c.
1251         * spu-linux-nat.c: Remove file.
1252         * spu-multiarch.c: Remove file.
1253         * spu-tdep.c: Remove file.
1254         * spu-tdep.h: Remove file.
1255         * solib-spu.c: Remove file.
1256         * solib-spu.h: Remove file.
1257
1258         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1259         * configure.nat (spu-linux): Remove.
1260         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1261         solib-multiarch.o from gdb_target_obs.
1262         (spu*-*-*): Remove.
1263
1264         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1265         feature flag.
1266         (ppc_linux_no_features): Update.
1267         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1268         Cell/B.E. support.
1269         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1270         (tdesc_powerpc_cell64l): Likewise.
1271         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1272         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1273         Cell/B.E. support.
1274         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1275         Do not include "features/rs6000/powerpc-cell32l.c" or
1276         "features/rs6000/powerpc-cell64l.c".
1277         (ppc_linux_spu_section): Remove.
1278         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1279         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1280         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1281         (ppc_linux_spe_context_lookup): Remove.
1282         (ppc_linux_spe_context_inferior_created): Remove.
1283         (ppc_linux_spe_context_solib_loaded): Remove.
1284         (ppc_linux_spe_context_solib_unloaded): Remove.
1285         (ppc_linux_spe_context): Remove.
1286         (struct ppu2spu_cache): Remove.
1287         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1288         (struct ppu2spu_data): Remove.
1289         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1290         ppu2spu_unwind): Remove.
1291         (ppc_linux_init_abi): Remove Cell/B.E. support.
1292         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1293
1294         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1295         (rs6000/powerpc-cell64l-expedite): Likewise
1296         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1297         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1298         rs6000/powerpc-cell64l.xml.
1299         * features/rs6000/powerpc-cell32l.xml: Remove.
1300         * features/rs6000/powerpc-cell64l.xml: Likewise.
1301         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1302         * features/rs6000/powerpc-cell64l.c: Likewise.
1303         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1304         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1305         * regformats/reg-spu.dat: Remove.
1306
1307         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1308         * corelow.c (struct spuid_list): Remove.
1309         (add_to_spuid_list): Remove.
1310         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1311         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1312         (remote_protocol_features): Remove associated entries.
1313         (_initialize_remote): No longer initialize them.
1314         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1315         * linux-nat.c (SPUFS_MAGIC): Remove.
1316         (linux_proc_xfer_spu): Remove.
1317         (spu_enumerate_spu_ids): Remove.
1318         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1319         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1320         (linux_make_corefile_notes): No longer call it.
1321
1322         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1323         (cooked_write_test): Likewise.
1324
1325 2019-09-20  Tom Tromey  <tom@tromey.com>
1326
1327         * NEWS: Mention case-sensitivity of TUI commands.
1328         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1329         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1330         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1331
1332 2019-09-20  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-source.c (tui_source_window::set_contents): Use
1335         make_unique_xstrdup.
1336         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1337         make_unique_xstrdup.
1338
1339 2019-09-20  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-data.c: Remove separator comments.
1342         * tui/tui-layout.c: Remove separator comments.
1343         * tui/tui-win.c: Remove separator comments.
1344         * tui/tui-wingeneral.c: Remove separator comments.
1345
1346 2019-09-20  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui.h (strcat_to_buf): Don't declare.
1349         * tui/tui.c (strcat_to_buf): Remove.
1350
1351 2019-09-20  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1354         from "fullname".
1355         * tui/tui-source.c (tui_source_window::set_contents)
1356         (tui_source_window::location_matches_p)
1357         (tui_source_window::maybe_update): Update.
1358
1359 2019-09-20  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1362         Update.
1363         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1364         prefix.
1365         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1366         (tui_data_window::line_from_reg_element_no)
1367         (tui_data_window::first_reg_element_no_inline)
1368         (tui_data_window::show_registers)
1369         (tui_data_window::show_register_group)
1370         (tui_data_window::display_registers_from)
1371         (tui_data_window::display_registers_from_line)
1372         (tui_data_window::first_data_item_displayed)
1373         (tui_data_window::delete_data_content_windows)
1374         (tui_data_window::erase_data_content)
1375         (tui_data_window::do_scroll_vertical)
1376         (tui_data_window::refresh_window)
1377         (tui_data_window::check_register_values): Update.
1378
1379 2019-09-20  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1382         (struct tui_locator_window) <full_name, proc_name>: Now
1383         std::string.
1384         * tui/tui-stack.c (tui_locator_window::make_status_line)
1385         (tui_locator_window::set_locator_fullname)
1386         (tui_locator_window::set_locator_info): Update.
1387         * tui/tui-source.c (tui_source_window::set_contents)
1388         (tui_source_window::showing_source_p): Update.
1389
1390 2019-09-20  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1393         Don't call tui_locator_win_info_ptr.
1394
1395 2019-09-20  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1398
1399 2019-09-20  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1402         height for locator.
1403         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1404         * tui/tui-layout.c (show_source_disasm_command, show_data)
1405         (show_source_or_disasm_and_command): Use 1 as height for locator.
1406
1407 2019-09-20  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui.c (tui_enable): Update.
1410         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1411         Update.
1412         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1413         Update.
1414         * tui/tui-data.c (win_resized): Now bool.
1415         (tui_win_resized): Return bool.
1416         (tui_set_win_resized_to): Accept a bool.
1417
1418 2019-09-20  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1421         Change type of "refresh_values_only".
1422         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1423         type of "refresh_values_only".
1424
1425 2019-09-20  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1428         std::string.
1429         (tui_disassemble): Add "pos" parameter.
1430         (tui_disasm_window::set_contents): Simplify.
1431
1432 2019-09-20  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-winsource.h (struct tui_source_window_base)
1435         <show_source_content>: Now private.
1436         * tui/tui-winsource.c
1437         (tui_source_window_base::show_source_content): Don't handle empty
1438         content case.
1439
1440 2019-09-20  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-layout.c (show_source_disasm_command)
1443         (show_source_or_disasm_and_command): Don't call
1444         show_source_content.
1445
1446 2019-09-20  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1449         Declare.
1450         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1451         from tui_make_status_line.
1452         (tui_locator_window::rerender): Update.
1453
1454 2019-09-20  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1457         (tui_locator_window::rerender): Update.
1458
1459 2019-09-20  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-winsource.h (struct tui_source_window_base)
1462         <~tui_source_window_base>: Don't declare.
1463         <fullname>: Remove.
1464         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1465         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1466         member.
1467         * tui/tui-source.c (tui_source_window::set_contents): Update.
1468         (tui_source_window::location_matches_p)
1469         (tui_source_window::maybe_update): Update.
1470
1471 2019-09-20  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-winsource.h (~tui_source_element): Remove.
1474         (tui_source_element): Update.
1475         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1476         * tui/tui-winsource.c (tui_show_source_line): Update.
1477         * tui/tui-source.c (tui_source_window::set_contents): Update.
1478         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1479
1480 2019-09-20  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1483         declare.
1484         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1485         tui_clear_source_windows_detail.
1486         * tui/tui-winsource.h (struct tui_source_window_base)
1487         <clear_detail>: Don't declare.
1488         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1489         Remove.
1490         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1491
1492 2019-09-20  Tom Tromey  <tromey@adacore.com>
1493
1494         PR ada/24919:
1495         * block.c (contained_in): Fix final return value.
1496
1497 2019-09-20  Alan Modra  <amodra@gmail.com>
1498
1499         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1500         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1501         (read_indirect_string_from_dwz): Use bfd accessor.
1502         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1503         * machoread.c (macho_symfile_read_all_oso): Likewise.
1504         * solib.c (solib_bfd_open): Likewise.
1505
1506 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1507
1508         * eval.c: Move declaration of overload_resolution to...
1509         * value.h: ...here.
1510
1511 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1512
1513         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1514         * arm-linux-tdep.c: Likewise.
1515         * arm-nbsd-nat.c: Likewise.
1516         * arm-tdep.h: Declare arm_apcs_32.
1517         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1518
1519 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1520
1521         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1522         * dwarf2read.h: Declare dwarf_always_disassemble.
1523
1524 2019-09-19  Tom de Vries  <tdevries@suse.de>
1525
1526         PR gdb/25009
1527         * source-cache.c (source_cache::ensure): Catch exception thrown during
1528         construction of the highlighter.
1529
1530 2019-09-18  Alan Modra  <amodra@gmail.com>
1531
1532         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1533         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1534         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1535         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1536         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1537         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1538         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1539         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1540         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1541         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1542         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1543         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1544         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1545         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1546         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1547         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1548         * mi/mi-interp.c: Update throughout for bfd section macro and
1549         function changes.
1550         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1551         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1552
1553 2019-09-18  Tom Tromey  <tom@tromey.com>
1554
1555         * NEWS: Add entry.
1556         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1557         call rl_initialize.
1558         (tui_enable): Do not call rl_initialize.
1559
1560 2019-09-18  Christian Groessler  <chris@groessler.org>
1561
1562         * alpha-linux-nat.c: Include gdbarch.h.
1563
1564 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1565
1566         * ui-file.c: Include cli/cli-style.h.
1567         (term_cli_styling): Remove cli_styling declaration.
1568
1569 2019-09-18  Alan Modra  <amodra@gmail.com>
1570
1571         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1572         to bfd_asymbol_section.
1573
1574 2019-09-18  Alan Modra  <amodra@gmail.com>
1575
1576         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1577         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1578         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1579
1580 2019-09-18  Alan Modra  <amodra@gmail.com>
1581
1582         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1583         * spu-linux-nat.c (spu_bfd_open): Likewise.
1584
1585 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1586
1587         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1588         to bool to match definition in dwarf2read.c.
1589
1590 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1591
1592         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1593         (print_signatures): Likewise.
1594         (trust_pad_over_xvs): Likewise.
1595         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1596         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1597         * arm-linux-nat.c (arm_apcs_32): Likewise.
1598         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1599         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1600         * arm-tdep.c (arm_debug): Likewise.
1601         (arm_apcs_32): Likewise.
1602         * auto-load.c (debug_auto_load): Likewise.
1603         (auto_load_gdb_scripts): Likewise.
1604         (global_auto_load): Likewise.
1605         (auto_load_local_gdbinit): Likewise.
1606         (auto_load_local_gdbinit_loaded): Likewise.
1607         * auto-load.h (global_auto_load): Likewise.
1608         (auto_load_local_gdbinit): Likewise.
1609         (auto_load_local_gdbinit_loaded): Likewise.
1610         * breakpoint.c (disconnected_dprintf): Likewise.
1611         (breakpoint_proceeded): Likewise.
1612         (automatic_hardware_breakpoints): Likewise.
1613         (always_inserted_mode): Likewise.
1614         (target_exact_watchpoints): Likewise.
1615         (_initialize_breakpoint): Update.
1616         * breakpoint.h (target_exact_watchpoints): Change to bool.
1617         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1618         * cli/cli-cmds.c (trace_commands): Likewise.
1619         * cli/cli-cmds.h (trace_commands): Likewise.
1620         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1621         to bool*.
1622         * cli/cli-logging.c (logging_overwrite): Change to bool.
1623         (logging_redirect): Likewise.
1624         (debug_redirect): Likewise.
1625         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1626         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1627         to bool.
1628         <boolean_option_def>: Update.
1629         (struct flag_option_def): Change default type of Context to bool
1630         from int.
1631         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1632         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1633         (get_setshow_command_value_string): Likewise.
1634         * cli/cli-style.c (cli_styling): Change to bool.
1635         (source_styling): Likewise.
1636         * cli/cli-style.h (source_styling): Likewise.
1637         (cli_styling): Likewise.
1638         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1639         to bool.
1640         * command.h (var_types): Update comment.
1641         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1642         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1643         bool.
1644         (debug_compile_cplus_scopes): Likewise.
1645         * compile/compile-internal.h (compile_debug): Likewise.
1646         * compile/compile.c (compile_debug): Likewise.
1647         (struct compile_options) <raw>: Likewise.
1648         * cp-support.c (catch_demangler_crashes): Likewise.
1649         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1650         (usr_cmd_cris_dwarf2_cfi): Likewise.
1651         * csky-tdep.c (csky_debug): Likewise.
1652         * darwin-nat.c (enable_mach_exceptions): Likewise.
1653         * dcache.c (dcache_enabled_p): Likewise.
1654         * defs.h (info_verbose): Likewise.
1655         * demangle.c (demangle): Likewise.
1656         (asm_demangle): Likewise.
1657         * dwarf-index-cache.c (debug_index_cache): Likewise.
1658         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1659         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1660         * dwarf2read.c (check_physname): Likewise.
1661         (use_deprecated_index_sections): Likewise.
1662         (dwarf_always_disassemble): Likewise.
1663         * eval.c (overload_resolution): Likewise.
1664         * event-top.c (set_editing_cmd_var): Likewise.
1665         (exec_done_display_p): Likewise.
1666         * event-top.h (set_editing_cmd_var): Likewise.
1667         (exec_done_display_p): Likewise.
1668         * exec.c (write_files): Likewise.
1669         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1670         (debug_fbsd_nat): Likewise.
1671         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1672         Likewise.
1673         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1674         <backtrace_past_entry> Likewise.
1675         * gdb-demangle.h (demangle): Likewise.
1676         (asm_demangle): Likewise.
1677         * gdb_bfd.c (bfd_sharing): Likewise.
1678         * gdbcore.h (write_files): Likewise.
1679         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1680         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1681         * gdbthread.h (print_thread_events): Likewise.
1682         * gdbtypes.c (opaque_type_resolution): Likewise.
1683         (strict_type_checking): Likewise.
1684         * gnu-nat.c (gnu_debug_flag): Likewise.
1685         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1686         * guile/scm-param.c (pascm_variable): Add boolval.
1687         (add_setshow_generic): Update.
1688         (pascm_param_value): Update.
1689         (pascm_set_param_value_x): Update.
1690         * hppa-tdep.c (hppa_debug): Change to bool..
1691         * infcall.c (may_call_functions_p): Likewise.
1692         (coerce_float_to_double_p): Likewise.
1693         (unwind_on_signal_p): Likewise.
1694         (unwind_on_terminating_exception_p): Likewise.
1695         * infcmd.c (startup_with_shell): Likewise.
1696         * inferior.c (print_inferior_events): Likewise.
1697         * inferior.h (startup_with_shell): Likewise.
1698         (print_inferior_events): Likewise.
1699         * infrun.c (step_stop_if_no_debug): Likewise.
1700         (detach_fork): Likewise.
1701         (debug_displaced): Likewise.
1702         (disable_randomization): Likewise.
1703         (non_stop): Likewise.
1704         (non_stop_1): Likewise.
1705         (observer_mode): Likewise.
1706         (observer_mode_1): Likewise.
1707         (set_observer_mode): Update.
1708         (sched_multi): Change to bool.
1709         * infrun.h (debug_displaced): Likewise.
1710         (sched_multi): Likewise.
1711         (step_stop_if_no_debug): Likewise.
1712         (non_stop): Likewise.
1713         (disable_randomization): Likewise.
1714         * linux-tdep.c (use_coredump_filter): Likewise.
1715         (dump_excluded_mappings): Likewise.
1716         * linux-thread-db.c (auto_load_thread_db): Likewise.
1717         (check_thread_db_on_load): Likewise.
1718         * main.c (captured_main_1): Update.
1719         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1720         xx2_opt, boolean_opt>: Change to bool.
1721         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1722         * maint.c (maintenance_profile_p): Likewise.
1723         (per_command_time): Likewise.
1724         (per_command_space): Likewise.
1725         (per_command_symtab): Likewise.
1726         * memattr.c (inaccessible_by_default): Likewise.
1727         * mi/mi-main.c (mi_async): Likewise.
1728         (mi_async_1): Likewise.
1729         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1730         * nat/fork-inferior.h (startup_with_shell): Likewise.
1731         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1732         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1733         * nios2-tdep.c (nios2_debug): Likewise.
1734         * or1k-tdep.c (or1k_debug): Likewise.
1735         * parse.c (parser_debug): Likewise.
1736         * parser-defs.h (parser_debug): Likewise.
1737         * printcmd.c (print_symbol_filename): Likewise.
1738         * proc-api.c (procfs_trace): Likewise.
1739         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1740         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1741         (set_parameter_value): Update.
1742         (add_setshow_generic): Update.
1743         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1744         to bool*.
1745         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1746         int*.
1747         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1748         * record-btrace.c (record_btrace_target::store_registers): Update.
1749         * record-full.c (record_full_memory_query): Change to bool.
1750         (record_full_stop_at_limit): Likewise.
1751         * record-full.h (record_full_memory_query): Likewise.
1752         * remote-notif.c (notif_debug): Likewise.
1753         * remote-notif.h (notif_debug): Likewise.
1754         * remote.c (use_range_stepping): Likewise.
1755         (interrupt_on_connect): Likewise.
1756         (remote_break): Likewise.
1757         * ser-tcp.c (tcp_auto_retry): Likewise.
1758         * ser-unix.c (serial_hwflow): Likewise.
1759         * skip.c (debug_skip): Likewise.
1760         * solib-aix.c (solib_aix_debug): Likewise.
1761         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1762         (spu_auto_flush_cache_p): Likewise.
1763         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1764         Likewise.
1765         (struct info_print_options) <quiet>: Likewise.
1766         * symfile-debug.c (debug_symfile): Likewise.
1767         * symfile.c (auto_solib_add): Likewise.
1768         (separate_debug_file_debug): Likewise.
1769         * symfile.h (auto_solib_add): Likewise.
1770         (separate_debug_file_debug): Likewise.
1771         * symtab.c (basenames_may_differ): Likewise.
1772         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1773         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1774         (struct info_types_options) <quiet>: Likewise.
1775         * symtab.h (demangle): Likewise.
1776         (basenames_may_differ): Likewise.
1777         * target-dcache.c (stack_cache_enabled_1): Likewise.
1778         (code_cache_enabled_1): Likewise.
1779         * target.c (trust_readonly): Likewise.
1780         (may_write_registers): Likewise.
1781         (may_write_memory): Likewise.
1782         (may_insert_breakpoints): Likewise.
1783         (may_insert_tracepoints): Likewise.
1784         (may_insert_fast_tracepoints): Likewise.
1785         (may_stop): Likewise.
1786         (auto_connect_native_target): Likewise.
1787         (target_stop_and_wait): Update.
1788         (target_async_permitted): Change to bool.
1789         (target_async_permitted_1): Likewise.
1790         (may_write_registers_1): Likewise.
1791         (may_write_memory_1): Likewise.
1792         (may_insert_breakpoints_1): Likewise.
1793         (may_insert_tracepoints_1): Likewise.
1794         (may_insert_fast_tracepoints_1): Likewise.
1795         (may_stop_1): Likewise.
1796         * target.h (target_async_permitted): Likewise.
1797         (may_write_registers): Likewise.
1798         (may_write_memory): Likewise.
1799         (may_insert_breakpoints): Likewise.
1800         (may_insert_tracepoints): Likewise.
1801         (may_insert_fast_tracepoints): Likewise.
1802         (may_stop): Likewise.
1803         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1804         (make_thread_apply_all_options_def_group): Change argument from int*
1805         to bool*.
1806         (thread_apply_all_command): Update.
1807         (print_thread_events): Change to bool.
1808         * top.c (confirm): Likewise.
1809         (command_editing_p): Likewise.
1810         (history_expansion_p): Likewise.
1811         (write_history_p): Likewise.
1812         (info_verbose): Likewise.
1813         * top.h (confirm): Likewise.
1814         (history_expansion_p): Likewise.
1815         * tracepoint.c (disconnected_tracing): Likewise.
1816         (circular_trace_buffer): Likewise.
1817         * typeprint.c (print_methods): Likewise.
1818         (print_typedefs): Likewise.
1819         * utils.c (debug_timestamp): Likewise.
1820         (sevenbit_strings): Likewise.
1821         (pagination_enabled): Likewise.
1822         * utils.h (sevenbit_strings): Likewise.
1823         (pagination_enabled): Likewise.
1824         * valops.c (overload_resolution): Likewise.
1825         * valprint.h (struct value_print_options) <prettyformat_arrays,
1826         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1827         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1828         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1829         Likewise.
1830         * windows-nat.c (new_console): Likewise.
1831         (cygwin_exceptions): Likewise.
1832         (new_group): Likewise.
1833         (debug_exec): Likewise.
1834         (debug_events): Likewise.
1835         (debug_memory): Likewise.
1836         (debug_exceptions): Likewise.
1837         (useshell): Likewise.
1838         * windows-tdep.c (maint_display_all_tib): Likewise.
1839         * xml-support.c (debug_xml): Likewise.
1840
1841 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1842
1843         * source.c (prepare_path_for_appending): New function.
1844         (openp): Make use of new function.
1845         (find_and_open_source): Search for the compilation directory and
1846         source file as a relative path beneath the directory search path.
1847
1848 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1849
1850         * source-cache.c (source_cache::get_line_charpos): Catch
1851         exceptions and return false, this matches the behaviour documented
1852         in the header file.
1853
1854 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1855
1856         * ada-tasks.c (info_task): Remove quoting of the task's name.
1857
1858 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1859
1860         * symfile.c (auto_solib_add): Replace comment with a reference
1861         to the header file.
1862
1863 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1864
1865         * NEWS: Mention that gdb can now be compiled with Python 3
1866         on Windows.
1867
1868 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1869
1870         * maint.c (maint_print_section_data::maint_print_section_data):
1871         Force use of 'float log10 (float)' by casting the argument to
1872         float.
1873
1874 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1875
1876         * maint.c: Add 'cmath' include.
1877         (struct maint_print_section_data): New structure.
1878         (print_section_index): New function.
1879         (print_bfd_section_info): Add header comment, small whitespace
1880         cleanup, and update to call new print_section_index function.
1881         (print_objfile_section_info): Likewise.
1882         (maint_obj_section_from_bfd_section): New function.
1883         (print_bfd_section_info_maybe_relocated): New function.
1884         (maintenance_info_sections): Add header comment, always use
1885         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1886
1887 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1888
1889         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1890         inner scope, add check that the objfile has psymtabs before
1891         checking psymtabs_addrmap.
1892         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1893
1894 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1895
1896         * NEWS: Announce that Ada task names are now shown at more places,
1897         and between quotes (except in info task output).
1898         * gdb/ada-tasks.c (task_to_str): New function.
1899         (display_current_task_id): Call task_to_str.
1900         (task_command_1): Likewise.
1901         (print_ada_task_info): In non-mi mode, Properly align headers and data
1902         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1903
1904 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1905
1906         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1907         prstatus.pr_lwp.pr_info instead of making it up.
1908
1909 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1910
1911         * auto-load.c (auto_load_expand_dir_vars): Update.
1912         * defs.h (gdb_datadir): Change to std::string.
1913         (python_libdir): Likewise.
1914         (relocate_gdb_directory): Change return type to std::string.
1915         * guile/guile.c (gdbscm_data_directory): Update.
1916         (initialize_scheme_side): Update.
1917         * jit.c (jit_reader_dir): Change to std::string.
1918         (jit_reader_load_command): Update.
1919         * main.c (gdb_datadir): Change to std::string.
1920         (python_libdir): Likewise.
1921         (set_gdb_data_directory): Update.
1922         (relocate_path): Change to return std::string.
1923         (relocate_gdb_directory): Change to return std::string.
1924         (relocate_gdbinit_path_maybe_in_datadir): Update.
1925         (captured_main_1): Update.
1926         * python/python.c (do_start_initialization): Update.
1927         * top.c (show_gdb_datadir): Update.
1928         * xml-syscall.c (xml_init_syscalls_info): Update.
1929         (init_syscalls_info): Update.
1930
1931 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1932
1933         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1934         out of get_init_files.
1935         (get_init_files): Update.
1936
1937 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1938
1939         * main.c (get_init_files): Change to use std::string.
1940         (captured_main_1): Update.
1941         (print_gdb_help): Update.
1942
1943 2019-09-11  Ali Tamur  <tamur@google.com>
1944
1945         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1946         implementation.
1947
1948 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1949
1950         * dbxread.c (read_dbx_symtab): Update.
1951         * dwarf2read.c (load_partial_dies): Update.
1952         * mdebugread.c (parse_partial_symbols): Update.
1953         (handle_psymbol_enumerators): Update.
1954         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1955         * psymtab.c (add_psymbol_to_bcache): Likewise.
1956         (add_psymbol_to_list): Likewise.
1957         * symtab.c (symbol_set_names): Likewise.
1958         * symtab.h (symbol_set_names): Likewise.
1959         * xcoffread.c (scan_xcoff_symtab): Update.
1960
1961 2019-09-11  Tom Tromey  <tom@tromey.com>
1962
1963         * symfile-mem.c (symbol_file_add_from_memory): Use
1964         bfd_set_filename.
1965         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1966         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1967
1968 2019-09-10  Tom Tromey  <tromey@adacore.com>
1969
1970         * dwarf-index-write.c (write_psymbols): Extend error message.
1971         (debug_names::insert): Add Ada code.
1972         (debug_names::write_psymbols): Remove Ada check.
1973         (debug_names) <m_string_obstack>: New member.
1974         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1975         (gdb_index_symbol_name_matcher::matches): Remove.
1976         (mapped_index_base::find_name_components_bounds): Add "lang"
1977         parameter.
1978         (mapped_index_base::build_name_components): Also split names
1979         according to Ada syntax.
1980         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1981         type of "match_callback".
1982         (check_match, check_find_bounds_finds)
1983         (dw2_expand_symtabs_matching): Update.
1984         (dw2_debug_names_iterator): Add new constructor.
1985         (dw2_debug_names_map_matching_symbols): New function.
1986         (dw2_debug_names_expand_symtabs_matching): Update.
1987         (dwarf2_debug_names_functions): Use
1988         dw2_debug_names_map_matching_symbols.
1989
1990 2019-09-10  Tom Tromey  <tromey@adacore.com>
1991
1992         * dwarf2read.c (dw2_get_file_names_reader): Add the
1993         CU's file name to the results.
1994
1995 2019-09-10  Tom Tromey  <tromey@adacore.com>
1996
1997         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1998         map_matching_symbols.  Update.
1999         * dwarf2read.c (dw2_map_matching_symbols): Update.
2000         * psymtab.c (match_partial_symbol): Change type; update.
2001         (psym_map_matching_symbols): Likewise.
2002         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2003         type; update.
2004         * symfile.h (struct quick_symbol_functions)
2005         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2006         Remove "match".
2007
2008 2019-09-10  Tom Tromey  <tromey@adacore.com>
2009
2010         * psymtab.c (map_block): Remove.
2011         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2012         * symtab.c (iterate_over_symbols_terminated): New function.
2013         * symtab.c (iterate_over_symbols_terminated): Declare.
2014
2015 2019-09-10  Tom Tromey  <tromey@adacore.com>
2016
2017         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2018         * language.h (struct language_defn) <la_iterate_over_symbols>:
2019         Return bool.
2020         * symtab.c (iterate_over_symbols): Return bool.
2021         * symtab.h (iterate_over_symbols): Return bool.
2022
2023 2019-09-10  Tom Tromey  <tromey@adacore.com>
2024
2025         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2026         (add_nonlocal_symbols): Update.
2027         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2028         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2029         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2030         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2031         Change type of "callback".  Remove "data".
2032
2033
2034 2019-09-09  Ali Tamur  <tamur@google.com>
2035
2036         * dwarf2read.c (comp_unit_head): Update comment.
2037         (dwarf2_dwo_name): New function declaration.
2038         (dwarf_unit_type_name): New function declaration.
2039         (read_comp_unit_head): Add support for new compilation units,
2040         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2041         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2042         (currently named as "signature") in their header. Also clarify error
2043         messages.
2044         (lookup_dwo_id): New function. Returns the dwo id of the given
2045         compile unit.
2046         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2047         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2048         functions.
2049         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2050         (dwarf2_dwo_name): Get the dwo name if present.
2051         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2052         purposes.
2053
2054 2019-09-09  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2057
2058 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2059
2060         * python/python.c (do_start_initialization): Make progname_copy static,
2061         to avoid a leak report.
2062
2063 2019-09-08  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2066
2067 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2068
2069         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2070         Change type to gdb::optional<block_enum>.
2071         (dw2_symtab_iter_init): Change block_index parameter type
2072         to gdb::optional<block_enum>.
2073         (dw2_lookup_symbol): Change block_index parameter
2074         type to block_enum.c
2075         (dw2_debug_names_lookup_symbol): Likewise.
2076         * psymtab.c (psym_lookup_symbol): Likewise.
2077         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2078         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2079         Likewise.
2080
2081 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2082
2083         * defs.h (relocate_gdb_directory): Change int to bool in
2084         signature and rename flag to relocatable.
2085         * main.c (relocate_path): Likewise.
2086         (relocate_gdb_directory): Likewise.
2087
2088 2019-09-06  Alan Modra  <amodra@gmail.com>
2089
2090         * coffread.c (coff_symfile_read): Constify filename variable.
2091         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2092         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2093         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2094         * solib.c (reload_shared_libraries_1): Likewise.
2095         * symfile.c (reread_symbols): Likewise.
2096         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2097         * solib-darwin.c (darwin_bfd_open): Likewise.
2098         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2099
2100 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2101
2102         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2103         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2104
2105 2019-09-03  Tom Tromey  <tromey@adacore.com>
2106
2107         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2108         types.
2109         (has_negatives): Unbias a range type bound.
2110         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2111         * gdbtypes.c (operator==): Handle new field.
2112         (create_range_type): Add "bias" parameter.
2113         (create_static_range_type, resolve_dynamic_range): Update.
2114         * gdbtypes.h (struct range_bounds) <bias>: New member.
2115         (create_range_type): Add bias parameter.
2116         * printcmd.c (print_scalar_formatted): Unbias range types.
2117         * value.c (unpack_long): Unbias range types.
2118         (pack_long): Bias range types.
2119
2120 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2121
2122         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2123         probe arguments.
2124
2125 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2126
2127         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2128         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2129         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2130         (compile_probe_arg): Likewise.
2131         * probe.h (get_argument_count): Likewise.
2132         * solib-svr4.c (solib_event_probe_action): Likewise.
2133         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2134
2135 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2136
2137         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2138         code to here...
2139         (svr4_create_solib_event_breakpoints): ...from here.
2140
2141 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2142
2143         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2144         suffix from warning message.
2145
2146 2019-08-30  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-winsource.h (struct tui_source_window_base)
2149         <refresh_all>: Don't declare.
2150         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2151         Remove.
2152         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2153         tui_show_locator_content.
2154         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2155         declare.
2156         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2157         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2158         declare.
2159
2160 2019-08-30  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2163
2164 2019-08-30  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2167         Remove unnecessary forward declarations.
2168
2169 2019-08-30  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2172         rerender.
2173         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2174         tui_show_locator_content.
2175
2176 2019-08-30  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2179         (tui_locator_window::rerender): Rewrite using body of previous
2180         tui_show_locator_content.
2181
2182 2019-08-30  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2185         set_locator_fullname>: New methods.
2186         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2187         Rename from tui_set_locator_fullname.
2188         (tui_locator_window::set_locator_info): Rename from
2189         tui_set_locator_info.  Return bool.
2190         (tui_update_locator_fullname, tui_show_frame_info): Update.
2191
2192 2019-08-30  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2195
2196 2019-08-30  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2199         call touchwin.
2200
2201 2019-08-30  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-wingeneral.c (box_win): Assume win_info and
2204         win_info->handle cannot be NULL.
2205
2206 2019-08-30  Tom Tromey  <tom@tromey.com>
2207
2208         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2209         refresh_window>: Declare.
2210         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2211         resize.
2212         (tui_data_item_window::rerender): Rename from
2213         tui_display_register.
2214         (tui_data_item_window::refresh_window): New method.
2215         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2216         no-op.
2217
2218 2019-08-30  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2221         regs_column_count, current_group>: Move later.  Now private.
2222         <get_current_group>: New method.
2223         * tui/tui-regs.c (tui_reg_command): Update.
2224         * tui/tui-layout.c (tui_set_layout): Update.
2225
2226 2019-08-30  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2229         (tui_data_window::rerender): Don't call
2230         check_and_display_highlight_if_needed.
2231         (tui_data_window::refresh_all): Remove call to
2232         erase_data_content.
2233
2234 2019-08-30  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2237         (tui_data_window::display_registers_from)
2238         (tui_data_window::display_reg_element_at_line)
2239         (tui_data_window::display_registers_from_line): Remove checks of
2240         "empty".
2241
2242 2019-08-30  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2245         Don't declare.
2246         * tui/tui-regs.c (tui_data_window::show_registers): Call
2247         rerender.
2248         (tui_data_window::rerender): Rename from display_all_data.
2249         (tui_data_window::rerender): Remove old implementation.
2250
2251 2019-08-30  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2254         text.
2255         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2256
2257 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2258             Sergio Durigan Junior  <sergiodj@redhat.com>
2259
2260         PR win32/24284
2261         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2262
2263 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2264
2265         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2266         when searching for types.
2267
2268 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * f-lang.c (f_language_defn): Use f_print_typedef.
2271         * f-lang.h (f_print_typedef): Declare.
2272         * f-typeprint.c (f_print_typedef): Define.
2273
2274 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2275
2276         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2277
2278 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * cli/cli-utils.c (info_print_options_defs): Delete.
2281         (make_info_print_options_def_group): Delete.
2282         (extract_info_print_options): Delete.
2283         (info_print_command_completer): Delete.
2284         (info_print_args_help): Add extra parameter, and optionally
2285         include text about -n flag.
2286         * cli/cli-utils.h (struct info_print_options): Delete.
2287         (extract_info_print_options): Delete declaration.
2288         (info_print_command_completer): Delete declaration.
2289         (info_print_args_help): Add extra parameter, extend header
2290         comment.
2291         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2292         search_symbols.
2293         * stack.c (struct info_print_options): New type.
2294         (info_print_options_defs): New file scoped variable.
2295         (make_info_print_options_def_group): New static function.
2296         (info_print_command_completer): New static function.
2297         (info_locals_command): Update to use new local functions.
2298         (info_args_command): Likewise.
2299         (_initialize_stack): Add extra parameter to calls to
2300         info_print_args_help.
2301         * symtab.c (search_symbols): Add extra parameter, use this to
2302         possibly excluse non-debug symbols.
2303         (symtab_symbol_info): Add extra parameter, which is passed on to
2304         search_symbols.
2305         (struct info_print_options): New type.
2306         (info_print_options_defs): New file scoped variable.
2307         (make_info_print_options_def_group): New static function.
2308         (info_print_command_completer): New static function.
2309         (info_variables_command): Update to use local functions, and pass
2310         extra parameter through to symtab_symbol_info.
2311         (info_functions_command): Likewise.
2312         (info_types_command): Pass additional argument through to
2313         symtab_symbol_info.
2314         (rbreak_command): Pass extra argument to search_symbols.
2315         (_initialize_symtab): Add extra arguments for calls to
2316         info_print_args_help, and update help text for 'info variables',
2317         'whereis', and 'info functions' commands.
2318         * symtab.h (search_symbols): Add extra argument to declaration.
2319         * NEWS: Mention new flags.
2320
2321 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2322
2323         * symtab.c (lookup_static_symbol): Call the new function (and move
2324         it down to be next to lookup_global_symbol).
2325         (struct global_sym_lookup_data): Add block_enum member and rename to...
2326         (struct global_or_static_sym_lookup_data): ...this.
2327         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2328         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2329         (lookup_symbol_global_or_static_iterator_cb): ...this.
2330         (lookup_global_or_static_symbol): New function.
2331         (lookup_global_symbol): Call new function.
2332
2333 2019-08-26  Tom de Vries  <tdevries@suse.de>
2334
2335         PR c++/24852
2336         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2337         when pc_probe.prob == NULL.
2338
2339 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2340
2341         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2342         variable symbol_linkage to symbol_linkage_.
2343
2344 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2345
2346         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2347         represent whether the symbol is static, dynamic, or we don't
2348         know.
2349
2350 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2351
2352         * gdb/rx-tdep.c (rx_register_names): New.
2353         (rx_register_name): Delete.
2354         (rx_psw_type): Delete.
2355         (rx_fpsw_type): Delete.
2356         (rx_register_type): Delete.
2357         (rx_gdbarch_init): Convert target-descriptions.
2358         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2359         * gdb/features/Makefile: Add rx.xml.
2360         * gdb/features/rx.xml: New.
2361         * gdb/features/rx.c: Generated.
2362         * gdb/NEWS: Mention target description support.
2363
2364 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2365
2366         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2367         *slot_ptr.
2368
2369 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2370
2371         * configure.ac: Don't check for 'dlfcn.h' (moved to
2372         gdbsupport/common.m4).
2373         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2374         'gdbsupport/'.
2375         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2376         * compile/compile-c-support.c: Include
2377         'gdbsupport/gdb-dlfcn.h'.
2378         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2379         * gdb-dlfcn.c: Move to...
2380         * gdbsupport/gdb-dlfcn.c: ... here.
2381         * gdb-dlfcn.h: Move to...
2382         * gdbsupport/gdb-dlfcn.h: ... here.
2383
2384 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2385
2386         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2387         the offset field signed.
2388
2389 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2390
2391         * python/lib/gdb/__init__.py (_execute_file): New function.
2392         * python/python.c (python_run_simple_file): Call gdb._execute_file
2393         on Windows.
2394
2395 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2398         all uses as this was never set to anything but a zero value.
2399
2400 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2401
2402         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2403
2404 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2405
2406         * tui/tui-data.h (tui_gen_win_info): Add an =default
2407         move constructor, required by some GCC versions.
2408
2409 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2410
2411         * go32-nat.c (go32_sysinfo): Add hygon_p.
2412
2413 2019-08-20  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2416         line_from_reg_element_no, first_reg_element_no_inline,
2417         display_all_data, delete_data_content_windows,
2418         erase_data_content>: Now private.
2419
2420 2019-08-20  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2423         (tui_unhighlight_win, tui_highlight_win)
2424         (tui_win_info::make_window): Update.
2425         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2426
2427 2019-08-20  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2430         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2431         (MAX_PID_WIDTH): Move to tui-stack.c.
2432         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2433         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2434         (MAX_PID_WIDTH): Move from tui-data.h.
2435
2436 2019-08-20  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2439         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2440         (box_win): Update.
2441         (tui_gen_win_info::make_window): Rename from tui_make_window.
2442         (tui_win_info::make_window): New method.
2443         (tui_gen_win_info::make_visible): Update.
2444         * tui/tui-source.c (tui_source_window::set_contents): Update.
2445         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2446         (tui_data_window::display_registers_from): Update.
2447         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2448         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2449         Declare.
2450         <can_box>: Remove.
2451         <title>: Remove.
2452         (struct tui_win_info) <make_window>: Declare.
2453         <can_box>: Now virtual.
2454         <title>: New member.
2455         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2456         * tui/tui-command.c (tui_cmd_window::resize): Update.
2457
2458 2019-08-20  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2461         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2462         (tui_data_window::check_register_values): Update.
2463
2464 2019-08-20  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-regs.h (struct tui_data_window): Use
2467         DISABLE_COPY_AND_ASSIGN.
2468         <regs_content>: Change type, removing unique_ptr.
2469         <tui_data_window>: Add move constructor.
2470         * tui/tui-regs.c (tui_data_window::show_registers)
2471         (tui_data_window::show_register_group)
2472         (tui_data_window::display_registers_from)
2473         (tui_data_window::display_registers_from)
2474         (tui_data_window::first_data_item_displayed)
2475         (tui_data_window::delete_data_content_windows)
2476         (tui_data_window::rerender, tui_data_window::refresh_window)
2477         (tui_data_window::check_register_values): Update.
2478
2479 2019-08-20  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2482         show_register_group>: Declare.
2483         (tui_show_register_group): Don't declare.
2484         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2485         tui_show_registers.
2486         (tui_data_window::show_register_group): Rename from
2487         tui_show_register_group.
2488         (tui_data_window::check_register_values, tui_reg_command):
2489         Update.
2490         * tui/tui-layout.c (tui_set_layout): Update.
2491
2492 2019-08-20  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2495         Declare.
2496         (tui_check_register_values): Don't declare.
2497         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2498         from tui_check_register_values.
2499         * tui/tui-hooks.c (tui_register_changed): Update.
2500
2501 2019-08-20  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-regs.c (tui_reg_layout): Move later.
2504         (tui_show_registers): Don't enable TUI mode or change layout.
2505
2506 2019-08-20  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-regs.h (struct tui_data_item_window)
2509         <~tui_data_item_window>: Remove.
2510         <content>: Now a unique_xmalloc_ptr.
2511         * tui/tui-regs.c (tui_register_format): Return a
2512         unique_xmalloc_ptr.
2513         (tui_get_register): Update.
2514         (~tui_data_item_window): Remove.
2515         (tui_data_window::display_registers_from, tui_display_register):
2516         Update.
2517         * tui/tui-io.h (tui_expand_tabs): Update.
2518         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2519         Remove "col" parameter.
2520
2521 2019-08-20  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2524         field.
2525         * tui/tui-regs.c (~tui_data_item_window): Update.
2526
2527 2019-08-20  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2530         earlier.
2531
2532 2019-08-20  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2535
2536 2019-08-20  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-source.h (struct tui_source_window): Update.
2539         * tui/tui-regs.c (tui_show_registers): Update.
2540         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2541         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2542         (NO_REGS_STRING): Remove defines.
2543
2544 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2545
2546         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2547         unnecessary thread walk if remote doesn't support the packet.
2548
2549 2019-08-19  Tom Tromey  <tromey@adacore.com>
2550
2551         * python/py-value.c (value_has_field): Fix indentation.
2552
2553 2019-08-19  Tom Tromey  <tromey@adacore.com>
2554
2555         * printcmd.c (do_one_display, info_display_command): Update.
2556         * block.h (contained_in): Return bool.  Add allow_nested
2557         parameter.
2558         * block.c (contained_in): Return bool.  Add allow_nested
2559         parameter.
2560
2561 2019-08-19  Tom Tromey  <tom@tromey.com>
2562
2563         * configure: Rebuild.
2564         * configure.ac: Disallow the combination of -static-libstdc++ and
2565         source highlight.
2566         * source-cache.c (get_language_name): Handle rust.
2567         (source_cache::get_source_lines): Ignore highlighting exceptions.
2568
2569 2019-08-16  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2572         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2573         (struct tui_source_window_base) <make_visible, refresh_window,
2574         resize>: Remove methods.
2575         <execution_info>: Remove field.
2576         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2577         (tui_show_source_line, tui_source_window_base)
2578         (~tui_source_window_base): Update.
2579         (tui_source_window_base::resize)
2580         (tui_source_window_base::make_visible)
2581         (tui_source_window_base::refresh_window): Remove.
2582         (tui_source_window_base::update_exec_info): Update.
2583         * tui/tui-source.c (tui_source_window::set_contents): Update.
2584         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2585
2586 2019-08-16  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2589         deprecated_query_hook.
2590
2591 2019-08-16  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2594         (tui_update_source_windows_with_line): Update.
2595         * tui/tui-source.h (struct tui_source_window)
2596         <show_symtab_source>: Declare.
2597         (tui_show_symtab_source): Don't declare.
2598         * tui/tui-source.c (tui_show_symtab_source): Rename from
2599         tui_show_symtab_source.
2600
2601 2019-08-16  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-winsource.h (struct tui_source_window_base)
2604         <set_contents>: Declare.
2605         * tui/tui-winsource.c
2606         (tui_source_window_base::update_source_window_as_is): Update.
2607         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2608         Declare.
2609         (tui_set_source_content): Don't declare.
2610         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2611         tui_set_source_content.
2612         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2613         Declare.
2614         (tui_set_disassem_content): Don't declare.
2615         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2616         tui_set_disassem_content.
2617
2618 2019-08-16  Tom Tromey  <tom@tromey.com>
2619
2620         * tui/tui-winsource.h (struct tui_source_window_base)
2621         <update_breakpoint_info>: Declare.
2622         (tui_update_breakpoint_info): Don't declare.
2623         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2624         (tui_update_all_breakpoint_info): Update.
2625         (tui_source_window_base::update_breakpoint_info): Rename from
2626         tui_update_breakpoint_info.
2627         (tui_source_window_base::update_exec_info): Update.
2628
2629 2019-08-16  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-winsource.h (struct tui_source_window_base)
2632         <update_source_window>: Declare.
2633         (tui_update_source_window): Don't declare.
2634         * tui/tui-winsource.c
2635         (tui_source_window_base::update_source_window): Rename from
2636         tui_update_source_window.
2637         (tui_source_window_base::rerender): Update.
2638         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2639         * tui/tui-disasm.c (tui_show_disassem)
2640         (tui_show_disassem_and_update_source)
2641         (tui_disasm_window::maybe_update): Update.
2642
2643 2019-08-16  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-winsource.h (struct tui_source_window_base)
2646         <update_source_window_as_is>: Declare.
2647         (tui_update_source_window_as_is): Don't declare.
2648         * tui/tui-winsource.c (tui_update_source_window): Update
2649         (tui_source_window_base::update_source_window_as_is): Rename from
2650         tui_update_source_window_as_is.
2651         (tui_source_window_base::refill): Update.
2652         * tui/tui-source.c (tui_show_symtab_source): Update.
2653         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2654         Update.
2655
2656 2019-08-16  Tom Tromey  <tom@tromey.com>
2657
2658         * tui/tui-winsource.h (tui_update_source_window)
2659         (tui_update_source_window_as_is): Remove "noerror" parameter.
2660         * tui/tui-winsource.c (tui_update_source_window)
2661         (tui_update_source_window_as_is): Remove "noerror" parameter.
2662         (tui_update_source_windows_with_addr)
2663         (tui_update_source_windows_with_line)
2664         (tui_source_window_base::rerender)
2665         (tui_source_window_base::refill): Update.
2666         * tui/tui-source.h (tui_set_source_content)
2667         (tui_show_symtab_source): Remove "noerror" parameter.
2668         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2669         parameter.
2670         (tui_show_symtab_source): Likewise.
2671         (tui_source_window::maybe_update): Update.
2672         * tui/tui-disasm.c (tui_show_disassem)
2673         (tui_show_disassem_and_update_source)
2674         (tui_disasm_window::do_scroll_vertical)
2675         (tui_disasm_window::maybe_update): Update.
2676
2677 2019-08-16  Tom Tromey  <tom@tromey.com>
2678
2679         * tui/tui.c (tui_is_window_visible): Update.
2680         * tui/tui-wingeneral.c (tui_make_window)
2681         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2682         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2683         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2684         (tui_set_win_height_command, parse_scrolling_args): Update.
2685         * tui/tui-source.c (tui_source_window::style_changed): Update.
2686         * tui/tui-regs.c (tui_show_registers)
2687         (tui_data_window::first_data_item_displayed)
2688         (tui_data_window::delete_data_content_windows)
2689         (tui_check_register_values, tui_reg_command): Update.
2690         * tui/tui-disasm.c (tui_show_disassem): Update.
2691         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2692         method.
2693         <is_visible>: Remove field.
2694         * tui/tui-data.c (tui_next_win, tui_prev_win)
2695         (tui_delete_invisible_windows): Update.
2696
2697 2019-08-16  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-winsource.h (struct tui_source_window_base)
2700         <m_has_locator>: Remove.
2701         * tui/tui-layout.c (show_source_disasm_command, show_data)
2702         (show_source_or_disasm_and_command): Update.
2703
2704 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2705
2706         * NEWS (Other MI changes): New subsection.
2707         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2708         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2709         * arch-utils.c (default_get_pc_address_flags): New function.
2710         * arch-utils.h (default_get_pc_address_flags): New declaration.
2711         * gdbarch.sh: Add get_pc_address_flags.
2712         * gdbarch.c: Regenerate.
2713         * gdbarch.h: Likewise.
2714         * stack.c (print_pc): New function.
2715         (print_frame_info) (print_frame): Call print_pc.
2716
2717 2019-08-16  Tom de Vries  <tdevries@suse.de>
2718
2719         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2720         print_objfile_section_info.
2721
2722 2019-08-15  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2725         calling update_cmdwin_start_line.
2726         * tui/tui-winsource.h (struct tui_source_window_base)
2727         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2728         <rerender>: Declare.
2729         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2730         Call rerender.
2731         (tui_source_window_base::set_new_height): Remove.
2732         (tui_source_window_base::rerender): Rename from
2733         do_make_visible_with_new_height.
2734         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2735         resize method.
2736         (tui_win_info::make_invisible_and_set_new_height)
2737         (tui_win_info::make_visible_with_new_height): Remove.
2738         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2739         Declare.
2740         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2741         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2742         do_make_visible_with_new_height>: Don't declare.
2743         <rerender>: Declare.
2744         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2745         set_new_height.
2746         (tui_data_window::do_make_visible_with_new_height): Remove.
2747         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2748         call tui_show_locator_content.
2749         (tui_gen_win_info::resize): Call rerender.
2750         (show_source_or_disasm_and_command): Don't call
2751         tui_show_locator_content.
2752         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2753         method.
2754         (struct tui_win_info) <rerender>: Declare.
2755         <set_new_height, make_invisible_and_set_new_height,
2756         make_visible_with_new_height>: Don't declare.
2757         * tui/tui-data.c (tui_win_list::rerender): New method.
2758         * tui/tui-command.h (struct tui_cmd_window)
2759         <do_make_visible_with_new_height>: Don't declare.
2760         * tui/tui-command.c
2761         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2762
2763 2019-08-15  Tom Tromey  <tromey@adacore.com>
2764
2765         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2766         * ada-lang.c (ada_enum_name): Likewise.
2767
2768 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2769
2770         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2771         leading underscore.
2772         (GdbOutputErrorFile): Likewise.
2773         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2774         accordingly.
2775         (execute_unwinders): Rename to have a leading underscore.
2776         (auto_load_packages): Likewise.
2777         (global scope): Adjust call to auto_load_packages accordingly.
2778         (GdbSetPythonDirectory): Likewise.
2779         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2780         instead of execute_unwinders.
2781
2782 2019-08-15  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2785         (show_data): Don't change window visibility.
2786         (tui_gen_win_info::resize): Remove special case for command
2787         window.  Use wresize, when available.
2788         (show_source_or_disasm_and_command): Don't change window
2789         visibility.
2790         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2791         <make_visible>: New method.
2792         * tui/tui-command.c (tui_cmd_window::resize): New method.
2793
2794 2019-08-15  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2797         (struct tui_source_windows): New.
2798         * tui/tui-winsource.c (tui_display_main): Update.
2799         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2800         (new_height_ok, parse_scrolling_args): Update.
2801         * tui/tui-layout.c (show_layout, show_data): Update.
2802         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2803         (tui_add_to_source_windows): Don't declare.
2804         * tui/tui-data.c (source_windows, tui_source_windows)
2805         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2806
2807 2019-08-15  Tom Tromey  <tom@tromey.com>
2808
2809         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2810         Rename from reset.
2811         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2812         * tui/tui-layout.c (show_source_disasm_command, show_data):
2813         Update.
2814         (tui_gen_win_info::resize): Rename.
2815         (show_source_or_disasm_and_command): Update.
2816         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2817         reset.
2818
2819 2019-08-15  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2822         * tui/tui-interp.c (tui_interp::init): Don't call
2823         tui_initialize_static_data.
2824         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2825
2826 2019-08-15  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2829         examine tui_win_list.
2830
2831 2019-08-15  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2834         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2835         tui_clear_source_content.
2836         (tui_clear_source_content): Remove.
2837         (tui_source_window_base::do_erase_source_content): Hoist call to
2838         content.clear().
2839         * tui/tui-stack.c (tui_show_frame_info): Don't call
2840         tui_clear_source_content.
2841
2842 2019-08-15  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-winsource.h (struct tui_source_window_base)
2845         <do_erase_source_content>: New method.
2846         <erase_source_content>: New method.
2847         (tui_erase_source_content): Don't declare.
2848         * tui/tui-winsource.c (tui_clear_source_content): Update.
2849         (tui_source_window_base::do_erase_source_content): Rename from
2850         tui_erase_source_content.
2851         (tui_source_window_base::show_source_content): Update.
2852         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2853         * tui/tui-source.h (struct tui_source_window)
2854         <erase_source_content>: New method.
2855         * tui/tui-disasm.h (struct tui_disasm_window)
2856         <erase_source_content>: New method.
2857
2858 2019-08-15  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2861         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2862         constructor.
2863         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2864         * tui/tui-source.c (tui_set_source_content): Update.
2865         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2866
2867 2019-08-15  Tom Tromey  <tom@tromey.com>
2868
2869         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2870         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2871         tui-source.c.
2872         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2873         Declare.
2874         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2875         method.
2876         (tui_source_window::maybe_update): Update.
2877
2878 2019-08-15  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2881         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2882         tui-disasm.c.
2883         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2884         Declare.
2885         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2886         method.
2887         (tui_disasm_window::maybe_update): Update.
2888
2889 2019-08-15  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui-winsource.h (struct tui_source_window_base)
2892         <maybe_update>: Declare.
2893         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2894         method.
2895         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2896         Declare.
2897         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2898         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2899         Declare.
2900         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2901
2902 2019-08-15  Tom Tromey  <tom@tromey.com>
2903
2904         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2905
2906 2019-08-15  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-wingeneral.c: Include tui-stack.h.
2909         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2910         (struct tui_locator_window): Move from tui-data.h.
2911         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2912         (tui_initialize_static_data): Move from tui-data.c.
2913         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2914         (struct tui_locator_window): Move to tui-stack.c.
2915         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2916         (tui_initialize_static_data): Move to tui-stack.c.
2917
2918 2019-08-15  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-layout.c (show_source_disasm_command)
2921         (show_source_or_disasm_and_command): Use make_visible method, not
2922         tui_make_window.
2923         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2924         Remove.
2925
2926 2019-08-15  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-wingeneral.h (tui_make_window): Update.
2929         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2930         parameter.
2931         (tui_gen_win_info::make_visible): Update.
2932         * tui/tui-regs.c (tui_data_window::display_registers_from):
2933         Update.
2934         * tui/tui-layout.c (show_source_disasm_command)
2935         (show_source_or_disasm_and_command): Update.
2936         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2937         (enum tui_box): Remove.
2938         (struct tui_win_info) <can_box>: New method.
2939         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2940         method.
2941
2942 2019-08-15  Tom de Vries  <tdevries@suse.de>
2943
2944         * linux-nat-trad.c: Include gdbarch.h.
2945
2946 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2947
2948         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2949         register sizes.
2950
2951 2019-08-14  Tom Tromey  <tromey@adacore.com>
2952
2953         * darwin-nat.c: Include gdbarch.h.
2954         * darwin-nat-info.c: Include gdbarch.h.
2955
2956 2019-08-13  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2959         Remove.
2960         * tui/tui-data.c (tui_initialize_static_data): Update.
2961
2962 2019-08-13  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-winsource.h (struct tui_exec_info_window)
2965         <~tui_exec_info_window, maybe_allocate_content, get_content,
2966         m_content>: Remove.
2967         (struct tui_source_window_base) <set_exec_info_content,
2968         show_exec_info_content>: Don't declare.
2969         * tui/tui-winsource.c
2970         (tui_exec_info_window::maybe_allocate_content): Remove.
2971         (tui_source_window_base::update_exec_info): Rename from
2972         set_exec_info_content.
2973         (tui_source_window_base::show_exec_info_content)
2974         (tui_source_window_base::update_exec_info): Remove.
2975
2976 2019-08-13  Tom Tromey  <tom@tromey.com>
2977
2978         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2979         declare.
2980         * tui/tui-winsource.c (tui_update_source_window_as_is)
2981         (tui_update_source_windows_with_addr, tui_erase_source_content):
2982         Update.
2983         (tui_clear_exec_info_content): Remove.
2984
2985 2019-08-13  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2988         declare.
2989         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2990         call tui_erase_exec_info_content.
2991         (tui_clear_exec_info_content): Rename from
2992         tui_erase_exec_info_content.
2993         (tui_clear_exec_info_content): Delete.
2994
2995 2019-08-13  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-winsource.h (struct tui_source_window_base)
2998         <show_exec_info_content>: Declare.
2999         (tui_show_exec_info_content): Don't declare.
3000         * tui/tui-winsource.c
3001         (tui_source_window_base::show_exec_info_content): Rename from
3002         tui_show_exec_info_content.
3003         (tui_source_window_base::update_exec_info): Update.
3004
3005 2019-08-13  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3008         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3009         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3010         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3011         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3012         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3013         ... here.
3014
3015 2019-08-13  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-winsource.h (struct tui_source_window_base)
3018         <update_exec_info>: Declare.
3019         (tui_update_exec_info): Don't declare.
3020         * tui/tui-winsource.c (tui_update_source_window_as_is)
3021         (tui_source_window_base::refresh_all)
3022         (tui_update_all_breakpoint_info): Update.
3023         (tui_source_window_base::update_exec_info): Rename from
3024         tui_update_exec_info.
3025         * tui/tui-stack.c (tui_show_frame_info): Update.
3026
3027 2019-08-13  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-winsource.h (struct tui_source_window_base)
3030         <set_exec_info_content>: Declare.
3031         (tui_set_exec_info_content): Don't declare.
3032         * tui/tui-winsource.c
3033         (tui_source_window_base::set_exec_info_content): Rename from
3034         tui_set_exec_info_content.
3035         (tui_update_exec_info): Update.
3036
3037 2019-08-13  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-winsource.h (struct tui_source_window_base)
3040         <show_source_content>: Declare.
3041         (tui_show_source_content): Don't declare.
3042         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3043         (tui_source_window_base::show_source_content): Rename from
3044         tui_show_source_content.
3045         (tui_source_window_base::refresh_all): Update.
3046         * tui/tui-layout.c (show_source_disasm_command)
3047         (show_source_or_disasm_and_command): Update.
3048
3049 2019-08-13  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-winsource.c (tui_erase_source_content)
3052         (tui_show_source_content, tui_source_window_base::refresh_all):
3053         Update.
3054         * tui/tui-wingeneral.h
3055         (tui_check_and_display_highlight_if_needed): Don't declare.
3056         * tui/tui-wingeneral.c
3057         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3058         check_and_display_highlight_if_needed.
3059         * tui/tui-win.c (tui_rehighlight_all)
3060         (tui_win_info::make_visible_with_new_height): Update.
3061         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3062         (tui_data_window::erase_data_content)
3063         (tui_data_window::display_all_data): Update.
3064         * tui/tui-data.h (struct tui_win_info)
3065         <check_and_display_highlight_if_needed>: Declare.
3066
3067 2019-08-13  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-win.c (tui_resize_all): Call
3070         tui_delete_invisible_windows.
3071         * tui/tui-layout.c (show_layout): Call
3072         tui_delete_invisible_windows.
3073         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3074         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3075
3076 2019-08-13  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3079         tui_add_win_to_layout.
3080
3081 2019-08-13  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3084         * tui/tui-layout.c (tui_default_win_height): Now static.
3085
3086 2019-08-13  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3089         single switch.
3090         (show_source_disasm_command, show_source_or_disasm_and_command):
3091         Don't check current layout.
3092
3093 2019-08-13  Tom Tromey  <tom@tromey.com>
3094
3095         * tui/tui-wingeneral.c (make_all_visible): Remove.
3096         (tui_make_all_invisible): Simplify.
3097         * tui/tui-layout.c (tui_make_all_invisible): Move from
3098         tui-wingeneral.c; simplify.
3099         (show_layout): Hoist call to tui_make_all_invisible.
3100         (show_data): Don't call tui_make_all_invisible.
3101
3102 2019-08-13  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3105         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3106
3107 2019-08-13  Tom Tromey  <tom@tromey.com>
3108
3109         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3110         tui-data.c.
3111         (show_source_disasm_command, show_data)
3112         (show_source_or_disasm_and_command): Don't use
3113         tui_set_current_layout_to.
3114         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3115         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3116         tui-layout.c.
3117         (tui_set_current_layout_to): Remove.
3118
3119 2019-08-13  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-layout.c (tui_set_layout): Update.
3122         * tui/tui-data.h (struct tui_layout_def): Remove.
3123         (tui_layout_def): Don't declare.
3124         * tui/tui-data.c (layout_def): Remove.
3125         (tui_layout_def): Remove.
3126
3127 2019-08-13  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-winsource.h (struct tui_source_window_base)
3130         <clear_detail>: No longer "override".
3131         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3132         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3133         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3134         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3135         Remove.
3136         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3137
3138 2019-08-13  Tom Tromey  <tromey@adacore.com>
3139
3140         * tracepoint.c: Don't include readline.h or history.h.
3141
3142 2019-08-12  Tom Tromey  <tom@tromey.com>
3143
3144         * configure: Rebuild.
3145         * configure.ac: Check for readline 7.
3146         * NEWS: Mention readline 7 requirement.
3147         * README: Update.
3148
3149 2019-08-12  Tom Tromey  <tom@tromey.com>
3150
3151         * mingw-hdep.c (gdb_select): Remove readline hack.
3152
3153 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3154
3155         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3156         when the function fails.
3157
3158 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3159
3160         * s390-tdep.c (s390_type_align): New function.
3161         (s390_gdbarch_init): Set it as type_align gdbarch method.
3162
3163 2019-08-09  Tom de Vries  <tdevries@suse.de>
3164
3165         PR gdb/24591
3166         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3167         pc_low with relocation offset.
3168
3169 2019-08-07  Tom Tromey  <tromey@adacore.com>
3170
3171         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3172         (print_frame_args): Update.
3173         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3174         Update.
3175         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3176         * frame.h (struct frame_arg): Add initializers.
3177         <error>: Now a unique_xmalloc_ptr.
3178
3179 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3180
3181         * NEWS: Expand the Pointer Authentication entry.
3182         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3183         (aarch64_frame_unmask_lr): ... to this.
3184         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3185         Call aarch64_frame_unmask_lr.
3186         * frame.c (struct frame_info): Add "masked" variable.
3187         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3188         (fprint_frame): Check for masked pc.
3189         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3190         declarations.
3191         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3192         * stack.c (print_frame): Check for masked pc.
3193
3194 2019-08-06  Tom Tromey  <tom@tromey.com>
3195
3196         * stabsread.c (patch_block_stabs, read_one_struct_field)
3197         (read_enum_type): Use obstack_strndup.
3198         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3199         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3200         * dwarf2read.c (guess_full_die_structure_name)
3201         (anonymous_struct_prefix): Use obstack_strndup.
3202         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3203         * c-exp.y (yylex): Use obstack_strndup.
3204         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3205         (write_var_or_type): Use obstack_strndup.
3206
3207 2019-08-06  Tom Tromey  <tom@tromey.com>
3208
3209         * symfile.c (reread_symbols): Use obstack_strdup.
3210         * stabsread.c (read_type): Use obstack_strdup.
3211         * gdb_obstack.h (obstack_strdup): New overload.
3212         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3213         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3214         (dwarf2_canonicalize_name): Use obstack_strdup.
3215         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3216         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3217         Use obstack_strdup.
3218
3219 2019-08-06  Tom Tromey  <tom@tromey.com>
3220
3221         * gdb_obstack.h (obstack_strdup): Define.
3222         * gdb_obstack.c (obstack_strdup): Don't define.
3223
3224 2019-08-06  Tom Tromey  <tom@tromey.com>
3225
3226         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3227         obstack_strdup.
3228         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3229         obstack_strdup.
3230         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3231         * stabsread.c (common_block_start): Use obstack_strdup.
3232         * objfiles.c (set_objfile_main_name, objfile): Use
3233         obstack_strdup.
3234         * namespace.c (add_using_directive): Use obstack_strdup.
3235         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3236         * jit.c (finalize_symtab): Use obstack_strdup.
3237         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3238         (guess_partial_die_structure_name, partial_die_info::fixup)
3239         (dwarf2_name): Use obstack_strdup.
3240         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3241         obstack_strdup.
3242         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3243         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3244         obstack_strdup.
3245         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3246
3247 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3248
3249         * unittests/help-doc-selftests.c: New file.
3250         * Makefile.in: Add the new file.
3251
3252 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3253
3254         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3255         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3256         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3257         the trailing '.' is not output, and the first character is uppercased.
3258         (print_help_for_command): Update call to print_doc_line.
3259         (print_doc_of_command): Likewise.
3260         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3261         * cli/cli-option.c (append_indented_doc): Do not append newline.
3262         (build_help_option): Append newline after first appended_indented_doc
3263         only if a second call is done.
3264         (build_help): Append 2 new lines before each option, except the first
3265         one.
3266         * compile/compile.c (_initialize_compile): Add new lines after
3267         %OPTIONS%, when not at the end of the help.
3268         Change help doc or code
3269         producing the help doc to respect the invariants.
3270         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3271         Also removed the new line after 'Options:', as all other commands
3272         do not put an empty line between 'Options:' and the first option.
3273         * printcmd.c (_initialize_printcmd): Likewise.
3274         * stack.c (_initialize_stack): Likewise.
3275         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3276         incorrectly telling COMMAND is optional.
3277         * ada-lang.c (_initialize_ada_language): Change help doc or code
3278         producing the help doc to respect the invariants.
3279         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3280         * breakpoint.c (_initialize_breakpoint): Likewise.
3281         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3282         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3283         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3284         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3285         _initialize_cli_style): Likewise.
3286         * corelow.c (core_target_info): Likewise.
3287         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3288         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3289         * filesystem.c (_initialize_filesystem): Likewise.
3290         * frame.c (_initialize_frame): Likewise.
3291         * gnu-nat.c (add_task_commands): Likewise.
3292         * infcall.c (_initialize_infcall): Likewise.
3293         * infcmd.c (_initialize_infcmd): Likewise.
3294         * interps.c (_initialize_interpreter): Likewise.
3295         * language.c (_initialize_language): Likewise.
3296         * linux-fork.c (_initialize_linux_fork): Likewise.
3297         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3298         * maint.c (_initialize_maint_cmds): Likewise.
3299         * memattr.c (_initialize_mem): Likewise.
3300         * printcmd.c (_initialize_printcmd): Likewise.
3301         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3302         _RegEx): Likewise.
3303         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3304         * record-btrace.c (_initialize_record_btrace): Likewise.
3305         * record-full.c (_initialize_record_full): Likewise.
3306         * record.c (_initialize_record): Likewise.
3307         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3308         * regcache.c (_initialize_regcache): Likewise.
3309         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3310         _initialize_remote): Likewise.
3311         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3312         * serial.c (_initialize_serial): Likewise.
3313         * skip.c (_initialize_step_skip): Likewise.
3314         * source.c (_initialize_source): Likewise.
3315         * stack.c (_initialize_stack): Likewise.
3316         * symfile.c (_initialize_symfile): Likewise.
3317         * symtab.c (_initialize_symtab): Likewise.
3318         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3319         * top.c (init_main): Likewise.
3320         * tracefile-tfile.c (tfile_target_info): Likewise.
3321         * tracepoint.c (_initialize_tracepoint): Likewise.
3322         * tui/tui-win.c (_initialize_tui_win): Likewise.
3323         * utils.c (add_internal_problem_command): Likewise.
3324         * valprint.c (value_print_option_defs): Likewise.
3325
3326 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3327
3328         PR build/24886
3329         * configure.ac: Drop enable-libmcheck support.
3330         * configure, config.in: Rebuild.
3331         * libmcheck.m4: Remove.
3332         * acinclude.m4: Don't include it.
3333         * Makefile.in: Don't distribute it.
3334         * top.c (print_gdb_configuration): Don't mention it.
3335
3336 2019-08-06  Tom Tromey  <tom@tromey.com>
3337
3338         * utils.c (set_output_style): Sometimes pass stream to
3339         emit_style_escape.
3340         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3341         * record-btrace.c (btrace_insn_history): Update.
3342         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3343         method.
3344         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3345         Update initializers.
3346         <m_uiout>: New field.
3347         <m_di>: Move lower.
3348         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3349         Remove "uiout" parameter.
3350         (dump_insns): Update.
3351         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3352         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3353
3354 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3355
3356         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3357         (error_in_psymtab_expansion): Likewise.
3358         (lookup_symbol_via_quick_fns): Likewise.
3359         (basic_lookup_transparent_type_quick): Likewise.
3360         (basic_lookup_transparent_type_1): Likewise.
3361
3362 2019-08-06  Tom Tromey  <tromey@adacore.com>
3363
3364         * source.c (last_source_error): Now bool.
3365         (print_source_lines_base): Make "noprint" bool.  Only open
3366         source file when last_source_visited changes.
3367
3368 2019-08-06  Tom Tromey  <tromey@adacore.com>
3369
3370         * annotate.c (annotate_source_line): Use g_source_cache.
3371         * source-cache.c (source_cache::get_plain_source_lines): Change
3372         parameters.  Populate m_offset_cache.
3373         (source_cache::ensure): New method.
3374         (source_cache::get_line_charpos): New method.
3375         (extract_lines): Move lower.  Change parameters.
3376         (source_cache::get_source_lines): Move lower.
3377         * source-cache.h (class source_cache): Update comment.
3378         <get_line_charpos>: New method.
3379         <get_source_lines>: Update comment.
3380         <clear>: Clear m_offset_cache.
3381         <get_plain_source_lines>: Change parameters.
3382         <ensure>: New method
3383         <m_offset_cache>: New member.
3384         * source.c (forget_cached_source_info_for_objfile): Update.
3385         (info_source_command): Use g_source_cache.
3386         (find_source_lines, open_source_file_with_line_charpos): Remove.
3387         (print_source_lines_base, search_command_helper): Use g_source_cache.
3388         * source.h (open_source_file_with_line_charpos): Don't declare.
3389         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3390         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3391         Use g_source_cache.
3392
3393 2019-08-06  Tom Tromey  <tromey@adacore.com>
3394
3395         * source-cache.c (source_cache::get_plain_source_lines):
3396         Remove "first_line" and "last_line" parameters.
3397         (source_cache::get_source_lines): Cache plain text.
3398         * source-cache.h (class source_cache)
3399         <get_plain_source_lines>: Update.
3400
3401 2019-08-06  Tom Tromey  <tromey@adacore.com>
3402
3403         * source-cache.c (extract_lines): No longer a method.
3404         Changed type of parameter.  Include final newline.
3405         (selftests::extract_lines_test): New function.
3406         (_initialize_source_cache): Likewise.
3407         * source-cache.h (class source_cache)
3408         <extract_lines>: Don't declare.
3409
3410 2019-08-06  Tom Tromey  <tromey@adacore.com>
3411
3412         * breakpoint.c (init_breakpoint_sal): Update.
3413         (breakpoint): Update.
3414         * breakpoint.h (struct breakpoint) <filter>: Now a
3415         unique_xmalloc_ptr.
3416
3417 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3418
3419         * NEWS: Mention dictionary access on blocks.
3420         * python/py-block.c (blpy_getitem): New function.
3421         (block_object_as_mapping): New struct.
3422         (block_object_type): Use new struct for tp_as_mapping field.
3423
3424 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3425
3426         * objfiles.h (objfile): Add a comment describing partial symbols.
3427
3428 2019-08-05  Tom Tromey  <tromey@adacore.com>
3429
3430         * compile/compile.c (_initialize_compile): Use _(), not N_().
3431         * thread.c (_initialize_thread): Use _(), not N_().
3432         * stack.c (_initialize_stack): Use _(), not N_().
3433         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3434
3435 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3436
3437         * dwarf2read.c (struct dw2_symtab_iterator):
3438         <want_specific_block>: Remove.
3439         <block_index>: Change type to gdb::optional.
3440         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3441         change type of BLOCK_INDEX parameter to gdb::optional.
3442         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3443         (dw2_lookup_symbol): Don't pass argument for
3444         WANT_SPECIFIC_BLOCK.
3445         (dw2_expand_symtabs_for_function): Don't pass argument for
3446         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3447         (class dw2_debug_names_iterator)
3448         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3449         parameter, change BLOCK_INDEX type to gdb::optional.
3450         <m_want_specific_block>: Remove.
3451         <m_block_index>: Change type to gdb::optional.
3452         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3453         gdb::optional.  Re-write in function of gdb::optional.
3454         (dw2_debug_names_lookup_symbol): Don't pass argument for
3455         WANT_SPECIFIC_BLOCK.
3456         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3457         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3458         BLOCK_INDEX.
3459
3460 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3461
3462         * NEWS: Mention changes to "info sources" command.
3463
3464 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3465
3466         * symtab.c (filename_partial_match_opts): New struct type.
3467         (struct output_source_filename_data): New members
3468         regexp, c_regexp, partial_match.
3469         (output_source_filename): Use new members to decide to print file.
3470         (info_sources_option_defs): New variable.
3471         (make_info_sources_options_def_group, print_info_sources_header,
3472         info_sources_command_completer):
3473         New functions.
3474         (info_sources_command): Read new optional arguments.
3475         (_initialize_symtab): Update info sources help.
3476
3477 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3478
3479         * ada-lang.c (exception_support_info_v0): Renamed from...
3480         (default_exception_support_info): ... this.  Create new
3481         definition for v1.
3482         (ada_has_this_exception_support): Look up catch_handlers_sym.
3483         (ada_exception_support_info_sniffer): Try v0 after default.
3484
3485 2019-08-01  Tom Tromey  <tromey@adacore.com>
3486
3487         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3488         gdbarch.h.
3489
3490 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3491
3492         * s12z-tdep.c: Fix include path for s12z-opc.h.
3493
3494 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3495
3496         * NEWS: Require GNU make 3.82.
3497
3498 2019-07-16  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3501         declare.
3502
3503 2019-07-30  Tom Tromey  <tromey@adacore.com>
3504
3505         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3506
3507 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3508
3509         * printcmd.c (print_address_symbolic): Print negative offsets.
3510         (build_address_symbolic): Force signed arithmetic when computing
3511         offset.
3512
3513 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3514
3515         PR/24474: Add a function to lookup static variables.
3516         * NEWS: Mention this new function.
3517         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3518         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3519         * python/python.c (python_GdbMethods): Add new function.
3520
3521 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3522
3523         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3524         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3525         (objfpy_lookup_static_symbol): New function.
3526         (objfile_object_methods): Add new functions.
3527
3528 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * NEWS: Mention 'set|show print frame-info'.  Mention new
3531         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3532         backtrace argument.  Mention that python frame filtering code
3533         is now consistent with what 'backtrace' command prints.
3534
3535 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3536
3537         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3538         comments.
3539         (print_frame_info_auto, print_frame_info_source_line,
3540         print_frame_info_location, print_frame_info_source_and_location,
3541         print_frame_info_location_and_address, print_frame_info_short_location):
3542         New declarations.
3543         (struct frame_print_options): New member print_frame_info.
3544         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3545         * stack.h (get_user_print_what_frame_info): New declaration.
3546         (frame_show_address): New declaration.
3547         * stack.c (print_frame_arguments_choices): New value 'presence'.
3548         (print_frame_info_auto, print_frame_info_source_line,
3549         print_frame_info_location, print_frame_info_source_and_location,
3550         print_frame_info_location_and_address, print_frame_info_short_location,
3551         print_frame_info_choices, print_frame_info_print_what): New definitions.
3552         (print_frame_args): Only print dots for args if print frame-arguments
3553         is 'presence'.
3554         (frame_print_option_defs): New element for "frame-info".
3555         (get_user_print_what_frame_info): New function.
3556         (frame_show_address): Make non static.  Move comment to stack.h.
3557         (print_frame_info_to_print_what): New function.
3558         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3559         to decide what to print.
3560         (backtrace_command_1): Handle the new print_frame_arguments_presence
3561         value.
3562         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3563         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3564         (py_print_frame): In non-mi mode, use LOCATION as default for
3565         print_what, similarly to frame information printed directly by
3566         backtrace command. Handle frame-info user option in non MI mode.
3567
3568 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3569
3570         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3571         Add case for debugging 32-bit target on 64-bit host.  Revise
3572         comment.
3573
3574 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3575
3576         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3577         instead of find_function_entry_range_from_pc.
3578
3579 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3580
3581         * stack.c (find_frame_funname): Remove code which preferred
3582         minsym over symtab sym in "certain pathological cases".
3583
3584         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3585         parameter.  Change type of "do_demangle" to bool.
3586         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3587         Pass suitable "prefer_sym_over_minsym" flag to
3588         build_address_symbolic().  Don't output "+" for negative offsets.
3589         * printcmd.c (print_address_symbolic): Update invocation of
3590         build_address_symbolic to include a "prefer_sym_over_minsym"
3591         flag.
3592         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3593         Restrict cases in which use of minimal symbol is preferred to that
3594         of a found symbol.  Update comments.
3595
3596         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3597         for entry pc when entry pc is out of range for that FDE.
3598
3599 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3600
3601         PR gdb/24839:
3602         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3603         type.
3604
3605 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3606
3607         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3608         this function's Python signature.
3609
3610
3611 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3612
3613         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3614         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3615         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3616         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3617         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3618
3619
3620 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3621
3622         * h8300-tdep.c (h8300_register_name_common): New.
3623         h8300_register_name): Use h8300_register_name_common.
3624         (h8300s_register_name): Likewise.
3625         (h8300sx_register_name): Likewise.
3626         (h8300h_register_nam): New.
3627         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3628
3629
3630 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3631
3632         * arm-tdep.c (arm_skip_cmse_entry): New function.
3633         (arm_is_sgstubs_section): New function.
3634         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3635
3636 2019-07-22  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3639         Don't self-assign.
3640
3641 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3642
3643         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3644         type_print.
3645
3646 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3647
3648         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3649         so that GDB doesn't match any msymbols when searching in the
3650         TYPES_DOMAIN.
3651         (print_symbol_info): Print using typedef_print or type_print based
3652         on the type of the symbol.  Add updated FIXME comment moved from...
3653         (_initialize_symtab): ... move and update FIXME comment to above.
3654
3655 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         * NEWS: Mention adding -q option to "info types".
3658         * symtab.c (struct info_types_options): New struct.
3659         (info_types_options_defs): New variable.
3660         (make_info_types_options_def_group): New function.
3661         (info_types_command): Use gdb::option framework to parse options.
3662         (info_types_command_completer): New function.
3663         (_initialize_symtab): Extend the help text on "info types" and
3664         register command completer.
3665
3666 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3667
3668         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3669         (lookup_symbol_in_objfile): Change int to block_enum and add a
3670         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3671
3672 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3673
3674         * MAINTAINERS (Write After Approval): Add self.
3675
3676 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3679         instruction to the dummy code region.
3680
3681 2019-07-19  Tom Tromey  <tromey@adacore.com>
3682
3683         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3684         (ARGSUSED, PARAMS, __func__): Remove rules.
3685
3686 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3687
3688         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3689         * features/arm/arm-with-iwmmxt.c: Remove.
3690         * features/arm/arm-with-iwmmxt.xml: Remove.
3691         * features/arm/arm-with-m-fpa-layout.c: Remove.
3692         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3693         * features/arm/arm-with-m-vfp-d16.c: Remove.
3694         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3695         * features/arm/arm-with-m.c: Remove.
3696         * features/arm/arm-with-m.xml: Remove.
3697         * features/arm/arm-with-neon.c: Remove.
3698         * features/arm/arm-with-neon.xml: Remove.
3699         * features/arm/arm-with-vfpv2.c: Remove.
3700         * features/arm/arm-with-vfpv2.xml: Remove.
3701         * features/arm/arm-with-vfpv3.c: Remove.
3702         * features/arm/arm-with-vfpv3.xml: Remove.
3703
3704 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3705
3706         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3707
3708 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3709
3710         * arch/aarch32.c (aarch32_create_target_description): Create
3711         target descriptions using features.
3712         * arch/arm.c (arm_create_target_description)
3713         (arm_create_mprofile_target_description): Likewise.
3714         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3715
3716 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3717
3718         * Makefile.in: Add new files.
3719         * aarch32-tdep.c: New file.
3720         * aarch32-tdep.h: New file.
3721         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3722         Call aarch32_read_description.
3723         * arch/aarch32.c: New file.
3724         * arch/aarch32.h: New file.
3725         * arch/arm.c (arm_create_target_description)
3726         (arm_create_mprofile_target_description): New function.
3727         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3728         (arm_create_target_description)
3729         (arm_create_mprofile_target_description): New declaration.
3730         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3731         read_description functions.
3732         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3733         Likewise.
3734         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3735         * arm-tdep.c (tdesc_arm_list): New variable.
3736         (arm_register_g_packet_guesses): Call create description functions.
3737         (arm_read_description) (arm_read_mprofile_description): New
3738         function.
3739         * arm-tdep.h (arm_read_description)
3740         (arm_read_mprofile_description): Add declaration.
3741         * configure.tgt: Add new files.
3742
3743 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3744
3745         * top.c (new_ui_command): Open specified terminal just once.
3746
3747 2019-07-18  Tom Tromey  <tromey@adacore.com>
3748
3749         * symtab.c (main_name): Constify return type.
3750         * symfile.c (set_initial_language): Update.
3751         * symtab.h (main_name): Constify return type.
3752
3753 2019-07-17  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-winsource.c (tui_update_source_window)
3756         (tui_update_source_window_as_is)
3757         (tui_update_source_windows_with_line): Remove return.
3758         * tui/tui-disasm.c (tui_show_disassem)
3759         (tui_show_disassem_and_update_source): Remove return.
3760         * tui/tui.c (tui_reset): Remove return.
3761         * tui/tui-wingeneral.c
3762         (tui_check_and_display_highlight_if_needed): Remove return.
3763
3764 2019-07-17  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3767
3768 2019-07-17  Tom Tromey  <tom@tromey.com>
3769
3770         * tui/tui-winsource.h (struct tui_exec_info_window)
3771         (struct tui_source_window_base): Move from tui-data.h.
3772         * tui/tui-winsource.c: Move many method definitions from
3773         elsewhere.  Remove "structuring" comments.
3774         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3775         (tui_source_window_base::refresh_window): Move to
3776         tui-winsource.c.
3777         * tui/tui-win.c (tui_source_window_base::refresh_all)
3778         (tui_source_window_base::update_tab_width)
3779         (tui_source_window_base::set_new_height)
3780         (tui_source_window_base::do_make_visible_with_new_height): Move to
3781         tui-winsource.c.
3782         * tui/tui-source.h: Update.
3783         * tui/tui-source.c (tui_source_window_base::reset): Move to
3784         tui-winsource.c.
3785         * tui/tui-disasm.h: Update.
3786         * tui/tui-data.h (struct tui_exec_info_window): Move to
3787         tui-winsource.h.
3788         (struct tui_source_window_base): Likewise.
3789         * tui/tui-data.c (tui_source_window_base::clear_detail)
3790         (tui_source_window_base, ~tui_source_window_base): Move to
3791         tui-winsource.c.
3792
3793 2019-07-17  Tom Tromey  <tom@tromey.com>
3794
3795         * tui/tui-win.c (tui_resize_all)
3796         (tui_source_window_base::update_tab_width)
3797         (tui_adjust_win_heights): Update.
3798         (tui_win_info::make_invisible_and_set_new_height): Rename from
3799         make_invisible_and_set_new_height.
3800         * tui/tui-data.h (struct tui_win_info)
3801         <make_invisible_and_set_new_height>: New method.
3802
3803 2019-07-17  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui.c: Update.
3806         * tui/tui-source.h (struct tui_source_window): Move from
3807         tui-data.h.
3808         * tui/tui-layout.c: Update.
3809         * tui/tui-disasm.c: Update.
3810         * tui/tui-data.h (struct tui_source_window): Move to
3811         tui-source.h.
3812
3813 2019-07-17  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3816         tui-data.h.
3817         * tui/tui-data.h (struct tui_disasm_window): Move to
3818         tui-disasm.h.
3819
3820 2019-07-17  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-regs.h (struct tui_data_item_window): Move from
3823         tui-data.h.
3824         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3825         * tui/tui-data.h (struct tui_data_item_window): Move to
3826         tui-regs.h.
3827         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3828
3829 2019-07-17  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui.c: Update.
3832         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3833         (tui_cmd_window::max_height): Move to tui-command.c.
3834         * tui/tui-layout.c: Update.
3835         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3836         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3837         tui-command.c.
3838         * tui/tui-command.h (struct tui_cmd_window): Move from
3839         tui-data.h.
3840         * tui/tui-command.c: Remove "structuring" comments.
3841         (tui_cmd_window::clear_detail)
3842         (tui_cmd_window::do_make_visible_with_new_height)
3843         (tui_cmd_window::max_height): Move from elsewhere.
3844
3845 2019-07-17  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3848         Now static.
3849         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3850         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3851
3852 2019-07-17  Tom Tromey  <tom@tromey.com>
3853
3854         * tui/tui.c: Update.
3855         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3856         tui-regs.c.
3857         * tui/tui-windata.h: Remove file.
3858         * tui/tui-windata.c: Remove file.
3859         * tui/tui-win.c (tui_data_window::set_new_height)
3860         (tui_data_window::do_make_visible_with_new_height): Move to
3861         tui-regs.c.
3862         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3863         * tui/tui-regs.c: Remove "structuring" comments.
3864         (tui_data_window::first_data_item_displayed)
3865         (tui_data_window::delete_data_content_windows)
3866         (tui_data_window::erase_data_content)
3867         (tui_data_window::display_all_data)
3868         (tui_data_window::refresh_all)
3869         (tui_data_window::do_scroll_vertical)
3870         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3871         (tui_data_window::do_make_visible_with_new_height)
3872         (tui_data_window::refresh_window): Move from elsewhere.
3873         (_initialize_tui_regs): Move to end of file.
3874         * tui/tui-layout.c: Update.
3875         * tui/tui-hooks.c: Update.
3876         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3877         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3878         tui-regs.c.
3879         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3880
3881 2019-07-17  Tom Tromey  <tom@tromey.com>
3882
3883         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3884         seen.
3885
3886 2019-07-17  Tom Tromey  <tom@tromey.com>
3887
3888         * tui/tui-win.c (tui_source_window_base::set_new_height)
3889         (tui_source_window_base::do_make_visible_with_new_height): Use
3890         m_has_locator field directly.
3891         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3892         method.
3893         (struct tui_source_window_base) <has_locator>: Likewise.
3894
3895 2019-07-17  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3898         Don't declare.
3899         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3900         Remove.
3901         * tui/tui-win.c (tui_source_window_base::set_new_height)
3902         (tui_source_window_base::set_new_height)
3903         (make_invisible_and_set_new_height)
3904         (tui_source_window_base::do_make_visible_with_new_height)
3905         (tui_source_window_base::do_make_visible_with_new_height):
3906         Update.
3907         * tui/tui-layout.c (show_source_disasm_command, show_data)
3908         (show_source_or_disasm_and_command): Update.
3909         * tui/tui-layout.c (show_layout): Update.
3910
3911 2019-07-17  Tom Tromey  <tom@tromey.com>
3912
3913         * tui/tui-layout.c (make_data_window): Remove.
3914         (show_data): Unify creation and re-initialization cases.
3915
3916 2019-07-17  Tom Tromey  <tom@tromey.com>
3917
3918         * tui/tui-layout.c (make_source_window, make_disasm_window):
3919         Remove.
3920         (show_data): Unify creation and re-initialization cases.
3921
3922 2019-07-17  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui-layout.c (make_command_window): Remove.
3925         (show_source_disasm_command, show_source_or_disasm_and_command):
3926         Unify creation and re-initialization cases.
3927
3928 2019-07-17  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3931         creation and re-initialization cases.
3932
3933 2019-07-17  Tom Tromey  <tom@tromey.com>
3934
3935         * tui/tui-regs.c (tui_get_register): Return void.
3936
3937 2019-07-17  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3940         Simplify.
3941
3942 2019-07-17  Tom Tromey  <tom@tromey.com>
3943
3944         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3945         resetting.
3946
3947 2019-07-17  Tom Tromey  <tom@tromey.com>
3948
3949         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3950         * tui/tui-regs.c (tui_reg_layout): New function.
3951         (tui_show_registers, tui_reg_command): Use it.
3952         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3953         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3954         parameters.
3955         (tui_layout_command): Remove.
3956
3957 2019-07-17  Tom Tromey  <tom@tromey.com>
3958
3959         * tui/tui-layout.h (tui/tui-layout): Return void.
3960         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3961
3962 2019-07-17  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui-layout.c (show_source_disasm_command, show_data):
3965         Update.
3966         (reset_locator): Remove.
3967         (show_source_or_disasm_and_command): Update.
3968
3969 2019-07-17  Tom Tromey  <tom@tromey.com>
3970
3971         * tui/tui-source.c (tui_source_window_base::reset): Remove
3972         win_type parameter.
3973         * tui/tui-layout.c (make_command_window, make_source_window)
3974         (make_disasm_window, make_data_window)
3975         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3976         (reset_locator, show_source_or_disasm_and_command): Update.
3977         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3978         win_type parameter.
3979         (struct tui_source_window_base) <reset>: Likewise.
3980
3981 2019-07-17  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-layout.c (show_source_disasm_command): Use
3984         reset_locator.
3985         (reset_locator): New function.
3986         (init_and_make_win): Remove.
3987         (show_source_or_disasm_and_command): Use reset_locator.
3988
3989 2019-07-17  Tom Tromey  <tom@tromey.com>
3990
3991         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3992         condition.
3993         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3994         Remove condition.
3995         * tui/tui-source.c (tui_source_window_base::reset): New method.
3996         * tui/tui-layout.c (make_command_window): Don't call
3997         init_and_make_win.
3998         (make_source_window, make_disasm_window): Don't call
3999         make_source_or_disasm_window.
4000         (make_data_window): Don't call init_and_make_win.  Change calling
4001         convention.
4002         (show_source_disasm_command, show_data): Simplify.
4003         (make_source_or_disasm_window): Remove.
4004         (show_source_or_disasm_and_command): Simplify.
4005         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4006         (struct tui_source_window_base) <reset>: Likewise.
4007         <execution_info>: Remove initializer.
4008         * tui/tui-data.c (tui_source_window_base): Initialize
4009         execution_info.
4010
4011 2019-07-17  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4014         variable.
4015
4016 2019-07-17  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui.c (tui_rl_other_window): Update.
4019         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4020         superclass method first.  Always iterate over regs_content.
4021         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4022         method.
4023         * tui/tui-win.c (tui_set_focus_command): Update.
4024
4025 2019-07-17  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-win.c (tui_set_focus_command): Rename from
4028         tui_set_focus.  Call tui_enable.
4029         (tui_set_focus_command): Remove.
4030
4031 2019-07-17  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4034         refresh_window.
4035         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4036         touchwin.
4037         (tui_data_window::refresh_window): Call refresh_window on data
4038         items.  Always call superclass refresh_window.
4039         (tui_win_info::refresh): Remove.
4040         (tui_source_window_base::refresh_window): Update.
4041         (tui_refresh_all): Update.
4042         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4043         refresh_window.
4044         (show_source_or_disasm_and_command): Likewise.
4045         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4046         (struct tui_source_window_base) <refresh>: Likewise.
4047
4048 2019-07-17  Tom Tromey  <tom@tromey.com>
4049
4050         * tui/tui-winsource.c (tui_clear_source_content)
4051         (tui_show_source_content): Update.
4052         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4053         whether content is empty.
4054         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4055         Remove.
4056
4057 2019-07-17  Tom Tromey  <tom@tromey.com>
4058
4059         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4060         window's contents.
4061         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4062         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4063
4064 2019-07-17  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4067         (struct tui_data_item_window): Update.
4068
4069 2019-07-17  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4072         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4073         defines.
4074
4075 2019-07-17  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-winsource.h (tui_erase_source_content)
4078         (tui_clear_source_content): Remove "display_prompt" parameter.
4079         * tui/tui-winsource.c (tui_update_source_window_as_is)
4080         (tui_update_source_windows_with_addr): Update.
4081         (tui_clear_source_content): Remove "display_prompt" parameter.
4082         (tui_erase_source_content): Likewise.  Simplify.
4083         (tui_show_source_content): Update.
4084         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4085         * tui/tui-stack.c (tui_show_frame_info): Update.
4086         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4087         Remove defines.
4088
4089 2019-07-17  Tom Tromey  <tom@tromey.com>
4090
4091         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4092         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4093         parameter.
4094         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4095         parameter.
4096
4097 2019-07-17  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-winsource.c (tui_clear_source_content)
4100         (tui_show_source_content, tui_show_exec_info_content)
4101         (tui_clear_exec_info_content): Update.
4102         * tui/tui-stack.c (tui_show_locator_content): Update.
4103         (tui_show_frame_info): Update.
4104         * tui/tui-source.h (tui_source_window): Don't declare.
4105         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4106         from tui_source_is_displayed.
4107         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4108         Remove field.
4109         (struct tui_source_window_base) <content_in_use>: New field.  Now
4110         bool.
4111         (struct tui_source_window) <showing_source_p>: New method.
4112         (TUI_SRC_WIN): Change cast.
4113         * tui/tui-data.c (tui_initialize_static_data): Update.
4114
4115 2019-07-17  Tom Tromey  <tom@tromey.com>
4116
4117         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4118         location_matches_p.
4119         * tui/tui-source.c (tui_source_window::location_matches_p): New
4120         method.
4121         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4122         method.
4123         * tui/tui-data.h (struct tui_source_window_base)
4124         <location_matches_p>: New method.
4125         (struct tui_source_window, struct tui_disasm_window)
4126         <location_matches_p>: Likewise.
4127
4128 2019-07-17  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-win.c (tui_set_win_height_command): Rename from
4131         tui_set_win_height.
4132         (tui_set_win_height_command): Remove.
4133
4134 2019-07-17  Tom Tromey  <tom@tromey.com>
4135
4136         * tui/tui-source.c (tui_source_window): New constructor.  Add
4137         observer.
4138         (~tui_source_window): New destructor.
4139         (tui_source_window::style_changed): New method.
4140         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4141         (tui_attach_detach_observers): Update.
4142         * tui/tui-data.h (struct tui_source_window): Make constructor not
4143         inline.  Add destructor.
4144         (struct tui_source_window) <style_changed>: New method.
4145         <m_observable>: New member.
4146
4147 2019-07-17  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4150         * tui/tui-win.c (tui_resize_all): Fix typo.
4151
4152 2019-07-17  Tom Tromey  <tom@tromey.com>
4153
4154         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4155         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4156         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4157         * tui/tui-win.c (window_name_completer): Use foreach.
4158         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4159         (update_tab_width): Likewise.
4160         * tui/tui-layout.c (show_layout): Update.
4161         * tui/tui-data.h (class tui_window_iterator): New.
4162         (struct all_tui_windows): New.
4163         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4164
4165 2019-07-17  Tom Tromey  <tom@tromey.com>
4166
4167         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4168         parameter.  Don't reference globals.
4169         (tui_reg_command): Update.
4170
4171 2019-07-17  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-regs.c (tui_show_registers): Simplify.
4174
4175 2019-07-17  Tom Tromey  <tom@tromey.com>
4176
4177         * tui/tui-regs.c (tui_show_registers): Update.
4178         (tui_show_register_group): Add win_info parameter.
4179
4180 2019-07-17  Tom Tromey  <tom@tromey.com>
4181
4182         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4183         Rename from tui_display_reg_element_at_line.
4184         (tui_data_window::display_registers_from_line): Update.
4185         * tui/tui-data.h (struct tui_data_window)
4186         <display_reg_element_at_line>: New method.
4187
4188 2019-07-17  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-regs.h (tui_display_registers_from)
4191         (tui_display_registers_from_line): Don't declare.
4192         * tui/tui-windata.c (tui_data_window::display_all_data)
4193         (tui_data_window::refresh_all)
4194         (tui_data_window::do_scroll_vertical): Update.
4195         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4196         from tui_display_registers_from.
4197         (tui_display_reg_element_at_line): Update.
4198         (tui_data_window::display_registers_from_line): Rename from
4199         tui_display_registers_from_line.
4200         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4201         display_registers_from_line>: New methods.
4202
4203 2019-07-17  Tom Tromey  <tom@tromey.com>
4204
4205         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4206         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4207         from tui_erase_data_content.
4208         (tui_data_window::display_all_data)
4209         (tui_data_window::refresh_all)
4210         (tui_data_window::do_scroll_vertical): Update.
4211         * tui/tui-regs.c (tui_show_registers): Update.
4212         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4213         New method.
4214
4215 2019-07-17  Tom Tromey  <tom@tromey.com>
4216
4217         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4218         declare.
4219         * tui/tui-windata.c
4220         (tui_data_window::delete_data_content_windows): Rename from
4221         tui_delete_data_content_windows.
4222         (tui_data_window::display_all_data)
4223         (tui_data_window::do_scroll_vertical): Update.
4224         * tui/tui-data.h (struct tui_data_window)
4225         <delete_data_content_windows>: New method.
4226
4227 2019-07-17  Tom Tromey  <tom@tromey.com>
4228
4229         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4230         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4231
4232 2019-07-17  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4235         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4236         from tui_display_all_data.
4237         * tui/tui-win.c
4238         (tui_data_window::do_make_visible_with_new_height): Update.
4239         * tui/tui-regs.c (tui_show_registers): Update.
4240         * tui/tui-layout.c (tui_set_layout): Update.
4241         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4242         method.
4243
4244 2019-07-17  Tom Tromey  <tom@tromey.com>
4245
4246         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4247         * tui/tui-windata.c (tui_display_data_from): Remove.
4248         (tui_data_window::refresh_all): Update.
4249
4250 2019-07-17  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4253         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4254         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4255         tui_display_registers_from_line.
4256         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4257         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4258         "force_display" parameter.
4259
4260 2019-07-17  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4263         declare.
4264         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4265         Rename from tui_first_reg_element_no_inline.
4266         (tui_display_reg_element_at_line)
4267         (tui_display_registers_from_line): Update.
4268         * tui/tui-data.h (struct tui_data_window)
4269         <first_reg_element_no_inline>: New method.
4270
4271 2019-07-17  Tom Tromey  <tom@tromey.com>
4272
4273         * tui/tui-windata.c (tui_display_data_from)
4274         (tui_data_window::do_scroll_vertical): Update.
4275         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4276         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4277         Rename from tui_line_from_reg_element_no.
4278         (tui_display_registers_from_line): Update.
4279         * tui/tui-data.h (struct tui_data_window)
4280         <line_from_reg_element_no>: New method.
4281
4282 2019-07-17  Tom Tromey  <tom@tromey.com>
4283
4284         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4285         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4286         tui_last_regs_line_no.
4287         (tui_display_reg_element_at_line)
4288         (tui_display_registers_from_line): Update.
4289         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4290         method.
4291
4292 2019-07-17  Tom Tromey  <tom@tromey.com>
4293
4294         PR tui/24722:
4295         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4296         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4297         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4298         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4299         (tui_update_breakpoint_info): Likewise.
4300         * tui/tui-hooks.c (tui_event_create_breakpoint)
4301         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4302         Update.
4303
4304 2019-07-17  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4307
4308 2019-07-17  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-winsource.c (tui_update_source_window_as_is)
4311         (tui_update_source_windows_with_addr): Update.
4312         * tui/tui-source.h (tui_set_source_content)
4313         (tui_show_symtab_source): Add "win_info" parameter.
4314         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4315         parameter.
4316         (tui_show_symtab_source): Likewise.
4317
4318 2019-07-17  Tom Tromey  <tom@tromey.com>
4319
4320         * tui/tui-wingeneral.c
4321         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4322
4323 2019-07-17  Tom Tromey  <tom@tromey.com>
4324
4325         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4326         (struct tui_cmd_window) <can_scroll>: New method.
4327         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4328         method.
4329
4330 2019-07-17  Tom Tromey  <tromey@adacore.com>
4331
4332         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4333         do_field_signed>: Rename.  Change type of "value".
4334         * ui-out.c (ui_out::field_signed): Rename from field_int.
4335         Change type of "value".
4336         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4337         type of "value".
4338         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4339         do_field_int.  Change type of "value".
4340         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4341         do_field_int.  Change type of "value".
4342         * tracepoint.c (trace_status_mi, tfind_1)
4343         (print_one_static_tracepoint_marker): Update.
4344         * thread.c (print_thread_info_1, print_selected_thread_frame):
4345         Update.
4346         * stack.c (print_frame, print_frame_info): Update.
4347         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4348         Update.
4349         * source.c (print_source_lines_base): Update.
4350         * skip.c (info_skip_command): Update.
4351         * record-btrace.c (btrace_ui_out_decode_error)
4352         (btrace_call_history_src_line): Update.
4353         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4354         Update.
4355         * progspace.c (print_program_space): Update.
4356         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4357         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4358         do_field_int.  Change type of "value".
4359         * mi/mi-out.c (mi_ui_out::do_table_begin)
4360         (mi_ui_out::do_table_header): Update.
4361         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4362         type of "value".
4363         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4364         (mi_cmd_data_list_changed_registers, output_register)
4365         (mi_cmd_data_read_memory, mi_load_progress)
4366         (mi_cmd_trace_frame_collected): Update.
4367         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4368         Update.
4369         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4370         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4371         (mi_cmd_var_list_children, varobj_update_one): Update.
4372         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4373         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4375         * inferior.c (print_inferior): Update.
4376         * gdb_bfd.c (print_one_bfd): Update.
4377         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4378         Update.
4379         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4380         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4381         do_field_int.  Change type of "value".
4382         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4383         do_field_int.  Change type of "value".
4384         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4385         (print_one_breakpoint_location, print_it_catch_fork)
4386         (print_one_catch_fork, print_it_catch_vfork)
4387         (print_one_catch_vfork, print_it_catch_solib)
4388         (print_it_catch_exec, print_it_ranged_breakpoint)
4389         (print_mention_watchpoint, print_mention_masked_watchpoint)
4390         (bkpt_print_it, update_static_tracepoint): Update.
4391         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4392         * break-catch-syscall.c (print_it_catch_syscall): Update.
4393         * ada-tasks.c (print_ada_task_info): Update.
4394         * ada-lang.c (print_it_exception, print_mention_exception):
4395         Update.
4396
4397 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         PR breakpoints/24541
4400         * gdbarch.c: Regenerate.
4401         * gdbarch.h: Regenerate.
4402         * gdbarch.sh: Adjust return type and parameter types for
4403         'stap_adjust_register'.
4404         (i386_stap_adjust_register): Adjust signature and return new
4405         register name.
4406         * stap-probe.c (stap_parse_register_operand): Adjust use of
4407         'gdbarch_stap_adjust_register'.
4408
4409 2019-07-17  Tom Tromey  <tromey@adacore.com>
4410
4411         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4412         declare VEC.
4413         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4414         std::vector.
4415         (struct s390_process_info): Add initializers.
4416         (s390_add_process): Use new.
4417         (s390_linux_nat_target::low_forget_process): Use delete.
4418         (s390_linux_nat_target::low_new_fork)
4419         (s390_linux_nat_target::stopped_by_watchpoint)
4420         (s390_linux_nat_target::low_prepare_to_resume)
4421         (s390_linux_nat_target::insert_watchpoint)
4422         (s390_linux_nat_target::insert_hw_breakpoint)
4423         (s390_linux_nat_target::remove_watchpoint)
4424         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4425
4426 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4427
4428         * aarch64-fbsd-nat.c: Include regcache.h.
4429         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4430         argument.
4431         (aarch64_fbsd_nat_target::fetch_registers)
4432         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4433         variable.
4434         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4435
4436 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4437
4438         * fbsd-nat.c: Include gdbarch.h.
4439
4440 2019-07-15  Tom Tromey  <tromey@adacore.com>
4441
4442         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4443
4444 2019-07-15  Tom Tromey  <tromey@adacore.com>
4445
4446         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4447         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4448         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4449         * cli-out.c (cli_ui_out::do_field_int): New method.
4450         * ui-out.c (ui_out::field_unsigned): New method.
4451         * symfile.c (generic_load): Use field_unsigned.
4452         (print_transfer_performance): Likewise.
4453         * record-btrace.c (ui_out_field_uint): Remove.
4454         (btrace_call_history_insn_range, btrace_call_history): Use
4455         field_unsigned.
4456         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4457         field_unsigned.
4458         * ui-out.h (class ui_out) <field_unsigned>: New method.
4459         <do_field_unsigned>: Likewise.
4460
4461 2019-07-15  Tom Tromey  <tromey@adacore.com>
4462
4463         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4464         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4465         * target.c (flash_erase_command): Use field_string.
4466         * infrun.c (print_signal_received_reason): Use field_string.
4467         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4468         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4469         field_string.
4470         * ada-tasks.c (print_ada_task_info): Use field_string.
4471
4472 2019-07-15  Tom Tromey  <tromey@adacore.com>
4473
4474         * target.c (flash_erase_command): Use field_core_addr.
4475         * symfile.c (generic_load): Use field_core_addr.
4476         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4477         Use field_core_addr.
4478         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4479         field_core_addr.
4480
4481 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4484         value if its desired type is smaller than a CORE_ADDR and signed.
4485
4486 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4489         of changes to field names, and use new is_reference field to
4490         decide if a property is a reference or not.
4491         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4492         field.
4493         (struct dwarf2_property_baton): Update header comment, rename
4494         'referenced_type' to 'property_type' and update comments.
4495         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4496         default property type, store in property baton, update to take
4497         accound of renamed field.
4498         (read_func_scope): Update call to attr_to_dynamic_prop.
4499         (read_array_type): Likewise.
4500         (dwarf2_per_cu_addr_sized_int_type): New function.
4501         (read_subrange_index_type): Move type finding code to
4502         dwarf2_per_cu_addr_sized_int_type.
4503         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4504         (dwarf2_per_cu_addr_type): New function.
4505         (set_die_type): Update calls to attr_to_dynamic_prop.
4506
4507 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * dwarf2read.c (read_subrange_index_type): New function.
4510         (read_subrange_type): Move code into new function and call it.
4511         * gdbtypes.c (create_range_type): Add some asserts.
4512
4513 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4516         update return statements.
4517         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4518         declaration, and update comment to match.
4519         * gdbtypes.c (resolve_dynamic_array): Update call to
4520         dwarf2_evaluate_property to match new return type.
4521
4522 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4523
4524         * valarith.c (value_subscripted_rvalue): Change lowerbound
4525         parameter type from int to LONGEST.
4526         * value.h (value_subscripted_rvalue): Likewise in declaration.
4527
4528 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * cli/cli-utils.c (info_print_command_completer): New function.
4531         * cli/cli-utils.h: Add 'completer.h' include, and forward
4532         declaration for 'struct cmd_list_element'.
4533         (info_print_command_completer): Declare.
4534         * stack.c (_initialize_stack): Add completer for 'info locals' and
4535         'info args'.
4536         * symtab.c (_initialize_symtab): Add completer for 'info
4537         variables' and 'info functions'.
4538         * NEWS: Mention completion for additional info commands.
4539
4540 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4541
4542         * cli/cli-utils.c (extract_info_print_args): Delete.
4543         (extract_arg_maybe_quoted): Delete.
4544         (info_print_options_defs): New variable.
4545         (make_info_print_options_def_group): New function.
4546         (extract_info_print_options): Define new function.
4547         * cli/cli-utils.h (extract_info_print_args): Delete.
4548         (struct info_print_options): New structure.
4549         (extract_info_print_options): Declare new function.
4550         * stack.c (info_locals_command): Update to use new
4551         extract_info_print_options, also add a header comment.
4552         (info_args_command): Likewise.
4553         * symtab.c (info_variables_command): Likewise.
4554         (info_functions_command): Likewise.
4555
4556 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4559         to extract string arguments.
4560         * common/common-utils.c (extract_string_maybe_quoted): New function.
4561         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4562
4563 2019-07-11  Tom Tromey  <tromey@adacore.com>
4564
4565         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4566         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4567         * top.h (gdbinit): Don't declare.
4568         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4569         into...
4570         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4571         * top.c (gdb_init): Don't call init_cli_cmds.
4572         (gdbinit): Remove.
4573         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4574
4575 2019-07-11  Tom Tromey  <tromey@adacore.com>
4576
4577         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4578         after it has been moved.
4579
4580 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4581
4582         * valops.c (value_must_coerce_to_target): Change return type to
4583         bool.
4584         * value.h (value_must_coerce_to_target): Likewise.
4585
4586 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4587
4588         * breakpoint.c (is_hardware_watchpoint): Remove
4589         forward-declaration.
4590         (is_masked_watchpoint): Change return type to bool.
4591         (is_tracepoint): Likewise.
4592         (is_breakpoint): Likewise.
4593         (is_hardware_watchpoint): Likewise.
4594         (is_watchpoint): Likewise.
4595         (is_no_memory_software_watchpoint): Likewise.
4596         (is_catchpoint): Likewise.
4597         (breakpoint_1): Make FILTER parameter's return type bool.
4598         is_masked_watchpoint): Change return type to bool.
4599         (save_breakpoints): Make FILTER parameter's return type bool.
4600         * breakpoint.h (is_breakpoint): Change return type to bool.
4601         (is_watchpoint): Likewise.
4602         (is_catchpoint): Likewise.
4603         (is_tracepoint): Likewise.
4604
4605 2019-07-10  Tom Tromey  <tom@tromey.com>
4606
4607         * defs.h: Don't include gdbarch.h.
4608         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4609         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4610         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4611         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4612         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4613         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4614         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4615         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4616         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4617         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4618         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4619         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4620         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4621         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4622         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4623         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4624         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4625         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4626         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4627         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4628         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4629         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4630         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4631         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4632         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4633         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4634         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4635
4636 2019-07-10  Tom Tromey  <tromey@adacore.com>
4637
4638         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4639         * breakpoint.c (init_ada_exception_breakpoint): Register as
4640         bp_catchpoint.
4641         (print_one_breakpoint_location, print_one_breakpoint): Use
4642         is_ada_exception_catchpoint.
4643         * ada-lang.c (class ada_catchpoint_location): Pass
4644         bp_loc_software_breakpoint to bp_location constructor.
4645         (is_ada_exception_catchpoint): New function.
4646
4647 2019-07-10  Tom Tromey  <tromey@adacore.com>
4648
4649         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4650         VEC.
4651         (struct arm_exidx_entry): New method operator<.
4652         (struct arm_exidx_data) <section_maps>: Change type.
4653         (arm_exidx_data_free): Remove.
4654         (arm_exidx_data_key): Change type.  Move lower.
4655         (arm_exidx_new_objfile): Update.
4656         (arm_compare_exidx_entries): Remove.
4657         (arm_find_exidx_entry, _initialize_arm_tdep)
4658
4659 2019-07-10  Tom Tromey  <tromey@adacore.com>
4660
4661         * solib-spu.c (ocl_program_data_key): Change type.
4662         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4663         Update.
4664
4665 2019-07-10  Tom Tromey  <tromey@adacore.com>
4666
4667         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4668         (struct solib_aix_inferior_data) <library_list>: Change type.
4669         (solib_aix_inferior_data_handle): Change type.
4670         (get_solib_aix_inferior_data): Update.
4671         (solib_aix_free_library_list): Remove.
4672         (library_list_start_library): Update.
4673         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4674         return type.
4675         (solib_aix_get_library_list)
4676         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4677         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4678
4679 2019-07-10  Tom Tromey  <tromey@adacore.com>
4680
4681         * solib-dsbt.c (struct dsbt_info): Add initializers.
4682         (solib_dsbt_pspace_data): Change type.
4683         (dsbt_pspace_data_cleanup): Remove.
4684         (get_dsbt_info, _initialize_dsbt_solib): Update.
4685
4686 2019-07-10  Tom Tromey  <tromey@adacore.com>
4687
4688         * spu-tdep.c (spu_overlay_data): Change type.
4689         (spu_get_overlay_table, spu_overlay_new_objfile)
4690         (_initialize_spu_tdep): Update.
4691
4692 2019-07-10  Tom Tromey  <tromey@adacore.com>
4693
4694         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4695         destructor.
4696         (dbx_objfile_data_key): Change type and declare later.
4697         (DBX_SYMFILE_INFO): Rewrite.
4698         * dbxread.c (dbx_objfile_data_key): Change type.
4699         (dbx_symfile_init): Update.
4700         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4701         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4702         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4703
4704 2019-07-10  Tom Tromey  <tromey@adacore.com>
4705
4706         * jit.c (jit_program_space_key): Change type.  Move lower.
4707         (get_jit_program_space_data): Update.
4708         (jit_program_space_data_cleanup): Remove.
4709         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4710         Update.
4711         (struct jit_program_space_data): Add initializers.
4712
4713 2019-07-10  Tom Tromey  <tromey@adacore.com>
4714
4715         * solib-darwin.c (struct darwin_info): Add initializers.
4716         (solib_darwin_pspace_data): Change type.
4717         (darwin_pspace_data_cleanup): Remove.
4718         (get_darwin_info, _initialize_darwin_solib): Update.
4719
4720 2019-07-10  Tom Tromey  <tromey@adacore.com>
4721
4722         * remote-sim.c (struct sim_inferior_data): Add initializers,
4723         constructor, and destructor.
4724         (sim_inferior_data_key): Change type.  Move lower.
4725         (check_for_duplicate_sim_descriptor): Update.
4726         (get_sim_inferior_data): Use new.  Update.
4727         (~sim_inferior_data_cleanup): Rename from
4728         sim_inferior_data_cleanup.  Simplify.
4729         (gdbsim_close_inferior, simulator_command)
4730         (sim_command_completer, _initialize_remote_sim): Update.
4731         (next_pid, INITIAL_PID): Move earlier.
4732
4733 2019-07-10  Tom Tromey  <tromey@adacore.com>
4734
4735         * python/python-internal.h (create_thread_object): Return
4736         gdbpy_ref.
4737         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4738         * python/py-inferior.c (struct threadlist_entry): Add
4739         constructor.
4740         <thread_obj>: Now a gdbpy_ref.
4741         (thread_to_thread_object): Update.
4742         (add_thread_object): Use new.
4743         (delete_thread_object): Use delete.
4744         (infpy_threads): Update.
4745         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4746         GIL.
4747
4748 2019-07-10  Tom Tromey  <tromey@adacore.com>
4749
4750         * valops.c (value_cast): Specialize error message for Ada.
4751
4752 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4753
4754         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4755
4756 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4757
4758         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4759         bpstat_should_step): Return bool, adjust comments.
4760         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4761         bpstat_should_step): Likewise.
4762
4763 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4764
4765         * features/Makefile: Use feature target descriptions for Arm.
4766         * features/arm/arm-core.c: Generate new file.
4767         * features/arm/arm-fpa.c: Likewise.
4768         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4769         * features/arm/arm-m-profile.c: Likewise.
4770         * features/arm/arm-vfpv2.c: Likewise.
4771         * features/arm/arm-vfpv3.c: Likewise.
4772         * features/arm/xscale-iwmmxt.c: Likewise.
4773         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4774
4775 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4776
4777         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4778         ptrace earlier.
4779
4780 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4781
4782         * features/aarch64-pauth.c: Regenerate.
4783
4784 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4785
4786         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4787         bool.
4788         (bpstat_what): Use false instead of 0.
4789
4790 2019-07-09  Pedro Alves  <palves@redhat.com>
4791
4792         * break-catch-throw.c (is_exception_catchpoint): New.
4793         * breakpoint.c (print_one_breakpoint_location): New parameter
4794         'raw_loc'.  Handle it.  Use
4795         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4796         looking at the breakpoint's type.
4797         (print_one_breakpoint): If handling "maint info breakpoints", also
4798         print locations of exception catchpoints.
4799         * breakpoint.h (is_exception_catchpoint): Declare.
4800
4801 2019-07-09  Pedro Alves  <palves@redhat.com>
4802
4803         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4804         "addr" field.
4805         (allocate_location_exception_catchpoint): New.
4806         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4807         (initialize_throw_catchpoint_ops): Install
4808         allocate_location_exception_catchpoint as allocate_location
4809         method.
4810         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4811         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4812         bp_loc_other.
4813         (breakpoint_address_is_meaningful): Delete.
4814         (bl_address_is_meaningful): New.
4815         (breakpoint_locations_match): Adjust comment.
4816         (bp_location_from_bp_type): New, factored out of...
4817         (bp_location::bp_location(breakpoint *)): ... this.
4818         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4819         factored out of...
4820         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4821         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4822         breakpoint_address_is_meaningful.
4823         (bp_locations_compare): Adjust comment.
4824         (update_global_location_list): Use bl_address_is_meaningful
4825         instead of breakpoint_address_is_meaningful.
4826         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4827         explicit.
4828         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4829         * python/py-breakpoint.c (bppy_get_location): No longer check
4830         whether location is null.
4831
4832 2019-07-09  Pedro Alves  <palves@redhat.com>
4833
4834         PR c++/15468
4835         * breakpoint.c (print_one_breakpoint_location): Remove
4836         single-location assert.
4837
4838 2019-07-09  Tom Tromey  <tom@tromey.com>
4839
4840         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4841         * configure: Rebuild.
4842         * configure.ac: Change common to gdbsupport.
4843         * gdbsupport: Rename from common.
4844         * acinclude.m4: Change common to gdbsupport.
4845         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4846         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4847         gdbsupport.
4848         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4849         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4850         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4851         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4852         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4853         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4854         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4855         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4856         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4857         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4858         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4859         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4860         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4861         coff-pe-read.c, command.h, compile/compile-c-support.c,
4862         compile/compile-c.h, compile/compile-cplus-symbols.c,
4863         compile/compile-cplus-types.c, compile/compile-cplus.h,
4864         compile/compile-loc2c.c, compile/compile.c, completer.c,
4865         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4866         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4867         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4868         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4869         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4870         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4871         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4872         features/aarch64-core.c, features/aarch64-fpu.c,
4873         features/aarch64-pauth.c, features/aarch64-sve.c,
4874         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4875         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4876         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4877         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4878         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4879         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4880         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4881         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4882         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4883         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4884         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4885         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4886         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4887         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4888         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4889         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4890         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4891         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4892         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4893         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4894         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4895         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4896         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4897         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4898         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4899         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4900         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4901         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4902         minsyms.c, mips-linux-tdep.c, namespace.h,
4903         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4904         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4905         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4906         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4907         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4908         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4909         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4910         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4911         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4912         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4913         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4914         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4915         procfs.c, producer.c, progspace.h, psymtab.h,
4916         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4917         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4918         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4919         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4920         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4921         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4922         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4923         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4924         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4925         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4926         target-memory.c, target.c, target.h, target/waitstatus.c,
4927         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4928         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4929         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4930         unittests/array-view-selftests.c,
4931         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4932         unittests/common-utils-selftests.c,
4933         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4934         unittests/format_pieces-selftests.c,
4935         unittests/function-view-selftests.c,
4936         unittests/lookup_name_info-selftests.c,
4937         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4938         unittests/mkdir-recursive-selftests.c,
4939         unittests/observable-selftests.c,
4940         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4941         unittests/parse-connection-spec-selftests.c,
4942         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4943         unittests/scoped_fd-selftests.c,
4944         unittests/scoped_mmap-selftests.c,
4945         unittests/scoped_restore-selftests.c,
4946         unittests/string_view-selftests.c, unittests/style-selftests.c,
4947         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4948         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4949         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4950         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4951         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4952         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4953
4954 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4957         bool value.
4958         (decode_digits_ordinary): Set explicit_line field in sal.
4959         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4960         symtab_and_line that was set on an explicit line number in
4961         assembler code.  Do always update the recorded symtab and line if
4962         we do skip the prologue.
4963
4964 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4965
4966         * breakpoint.c (set_breakpoint_location_function): Remove
4967         explicit_loc parameter.
4968         (momentary_breakpoint_from_master): Update call to
4969         set_breakpoint_location_function.
4970         (add_location_to_breakpoint): Likewise.
4971
4972 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4975         required features based on default bfd type when no specific bfd
4976         is present.
4977
4978 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4979
4980         * NEWS: Mention that GDB printf and eval commands can now print
4981         C-style and Ada-style convenience var strings without
4982         calling the inferior.
4983         * printcmd.c (printf_c_string): Locally print GDB internal var
4984         instead of transiting via the inferior.
4985         (printf_wide_c_string): Likewise.
4986
4987 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4988
4989         PR breakpoints/25011
4990         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4991
4992 2019-07-04  Tom Tromey  <tom@tromey.com>
4993
4994         PR tui/24724:
4995         * tui/tui-winsource.c (tui_clear_source_content): Update.
4996         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4997         (tui_update_breakpoint_info): Update.
4998         (tui_set_exec_info_content): Update.
4999         * tui/tui-source.c (tui_set_source_content_nil): Update.
5000         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5001         has_break.
5002         * tui/tui-data.h (enum tui_bp_flag): New.
5003         (tui_bp_flags): New enum flags type.
5004         (struct tui_source_element) <break_mode>: Change type.  Rename
5005         from has_break.
5006         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5007         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5008         constants.
5009         * tui/tui-winsource.h: Fix comment.
5010
5011 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5012
5013         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5014         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5015         (store_fpregs_to_thread)
5016         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5017         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5018         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5019         (IWMMXT_REGS_SIZE): Add define.
5020         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5021         (fetch_vfp_regs, store_vfp_regs)
5022         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5023         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5024
5025 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5026
5027         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5028         defines.
5029         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5030         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5031         (ARM_INT_REGISTER_SIZE): ...to this.
5032         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5033         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5034         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5035         (arm_linux_collect_gregset, supply_nwfpe_register)
5036         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5037         defines.
5038         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5039         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5040         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5041         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5042         (arm_return_in_memory, arm_store_return_value)
5043         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5044         (arm_record_ld_st_multiple): Likewise.
5045         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5046         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5047
5048 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5049
5050         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5051         AARCH64_DISPLACED_MODIFIED_INSNS.
5052         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5053         (aarch64_displaced_step_copy_insn): Likewise.
5054         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5055         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5056         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5057         ARM_DISPLACED_MODIFIED_INSNS.
5058         * arm-tdep.c (arm_gdbarch_init): Likewise.
5059         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5060         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5061         (struct arm_displaced_step_closure): Use
5062         ARM_DISPLACED_MODIFIED_INSNS.
5063
5064 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5065
5066         * features/Makefile: Remove unused xml files.
5067         * features/aarch64.xml: Remove.
5068         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5069         * features/i386/amd64-avx-avx512.xml: Remove.
5070         * features/i386/amd64-avx-linux.xml: Remove.
5071         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5072         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5073         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5074         * features/i386/amd64-avx-mpx.xml: Remove.
5075         * features/i386/amd64-avx.xml: Remove.
5076         * features/i386/amd64-linux.xml: Remove.
5077         * features/i386/amd64-mpx-linux.xml: Remove.
5078         * features/i386/amd64-mpx.xml: Remove.
5079         * features/i386/amd64.xml: Remove.
5080         * features/i386/i386-avx-avx512-linux.xml: Remove.
5081         * features/i386/i386-avx-avx512.xml: Remove.
5082         * features/i386/i386-avx-linux.xml: Remove.
5083         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5084         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5085         * features/i386/i386-avx-mpx-linux.xml: Remove.
5086         * features/i386/i386-avx-mpx.xml: Remove.
5087         * features/i386/i386-avx.xml: Remove.
5088         * features/i386/i386-linux.xml: Remove.
5089         * features/i386/i386-mmx-linux.xml: Remove.
5090         * features/i386/i386-mmx.xml: Remove.
5091         * features/i386/i386-mpx-linux.xml: Remove.
5092         * features/i386/i386-mpx.xml: Remove.
5093         * features/i386/i386.xml: Remove.
5094         * features/i386/x32-avx-avx512-linux.xml: Remove.
5095         * features/i386/x32-avx-linux.xml: Remove.
5096         * features/i386/x32-linux.xml: Remove.
5097
5098 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5099
5100         * regformats/aarch64.dat: Remove.
5101         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5102         * regformats/i386/amd64-avx-linux.dat: Remove.
5103         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5104         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5105         * regformats/i386/amd64-linux.dat: Remove.
5106         * regformats/i386/amd64-mpx-linux.dat: Remove.
5107         * regformats/i386/amd64.dat: Remove.
5108         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5109         * regformats/i386/i386-avx-linux.dat: Remove.
5110         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5111         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5112         * regformats/i386/i386-linux.dat: Remove.
5113         * regformats/i386/i386-mmx-linux.dat: Remove.
5114         * regformats/i386/i386-mpx-linux.dat: Remove.
5115         * regformats/i386/i386.dat: Remove.
5116         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5117         * regformats/i386/x32-avx-linux.dat: Remove.
5118         * regformats/i386/x32-linux.dat: Remove.
5119
5120 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5121
5122         * aarch64-tdep.c: Remove xml self tests.
5123         * amd64-linux-tdep.c: Likewise.
5124         * amd64-tdep.c: Likewise.
5125         * i386-linux-tdep.c: Likewise.
5126         * i386-tdep.c: Likewise.
5127
5128 2019-07-03  Pedro Alves  <palves@redhat.com>
5129
5130         PR cli/24732
5131         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5132         (pipe_cmd_option_defs): New.
5133         (make_pipe_cmd_options_def_group): New.
5134         (pipe_command): Use gdb::option::process_options.
5135         (pipe_command_completer): New function.
5136         (_initialize_cli_cmds): Install completer for "pipe" command.
5137
5138 2019-07-03  Pedro Alves  <palves@redhat.com>
5139
5140         * cli/cli-option.c (union option_value) <string>: New field.
5141         (struct option_def_and_value): Add ctor, move ctor, dtor and
5142         use DISABLE_COPY_AND_ASSIGN.
5143         (option_def_and_value::clear_value): New.
5144         (parse_option, save_option_value_in_ctx, get_val_type_str)
5145         (add_setshow_cmds_for_options): Handle var_string.
5146         * cli-option.h (union option_def::var_address) <string>: New
5147         field.
5148         (struct string_option_def): New.
5149         * maint-test-options.c (struct test_options_opts): Add default
5150         ctor and use DISABLE_COPY_AND_ASSIGN.
5151         <string_opt>: New field.
5152         (test_options_opts::~test_options_opts): New.
5153         (test_options_opts::dump): Also dump "-string".
5154         (test_options_option_defs): Install "string.
5155
5156 2019-07-03  Pedro Alves  <palves@redhat.com>
5157
5158         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5159         option_value with a null enumeration.
5160         (complete_options): Save the option values in the context.
5161         (save_option_value_in_ctx): New, factored out from ...
5162         (process_options): ... here.
5163         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5164         of the function.
5165         * maint-test-options.c (test_options_opts::dump): New, factored
5166         out from ...
5167         (maintenance_test_options_command_mode): ... here.
5168         (maintenance_test_options_command_completion_result): Delete.
5169         (maintenance_test_options_command_completion_text): Update
5170         comment.
5171         (maintenance_show_test_options_completion_result): Change
5172         prototype.  Just print
5173         maintenance_test_options_command_completion_text.
5174         (save_completion_result): New.
5175         (maintenance_test_options_completer_mode): Pass options context to
5176         complete_options, and then save a dump.
5177         (_initialize_maint_test_options): Use add_cmd to install "maint
5178         show test-options-completion-result".
5179
5180 2019-07-03  Pedro Alves  <palves@redhat.com>
5181
5182         * NEWS (New commands): Mention "with" and "maint with".
5183         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5184         (with_command, with_command_completer): New.
5185         (pipe_command): Adjust to new repeat_previous
5186         interface.
5187         (_initialize_cli_cmds): Install the "with" command and its "w"
5188         alias.
5189         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5190         declarations.
5191         * cli/cli-setshow.c (parse_cli_var_uinteger)
5192         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5193         argument strings for all var_types.
5194         (get_setshow_command_value_string): New, factored out from ...
5195         (do_show_command): ... this.
5196         * cli/cli-setshow.h: Include <string>.
5197         (get_setshow_command_value_string): Declare.
5198         * command.h (repeat_previous): Now returns const char *.  Adjust
5199         comment.
5200         * maint.c: Include "cli/cli-cmds.h".
5201         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5202         (_initialize_maint_cmds): Register the "maintenance with" command.
5203         * top.c (repeat_previous): Move bits from pipe_command here:
5204         Return the saved command line, if any; error out if there's no
5205         command to relaunch.
5206
5207 2019-07-03  Pedro Alves  <palves@redhat.com>
5208
5209         * NEWS (New commands): Mention "maint set/show test-settings"
5210         instead of "maint test-settings".
5211         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5212         (maintenance_test_settings_set_list): Rename to ...
5213         (maintenance_set_test_settings_list): ... this.
5214         (maintenance_test_settings_show_list): Rename to  ...
5215         (maintenance_show_test_settings_list): ... this.
5216         (maintenance_test_settings_cmd): Delete.
5217         (maintenance_test_settings_set_cmd): ...
5218         (maintenance_set_test_settings_cmd): ... this.
5219         (maintenance_test_settings_show_cmd): ...
5220         (maintenance_show_test_settings_cmd): ... this.
5221         (maintenance_test_settings_show_value_cmd):
5222         (maintenance_show_test_settings_value_cmd): ... this.
5223         (_initialize_maint_test_settings): No longer install the "maint
5224         test-settings" prefix command.  Rename "maint test-settings set"
5225         to "maint set test-settings", and "maint test-settings show" to
5226         "maint show test-settings".  Adjust all subcommands.
5227
5228 2019-07-03  Pedro Alves  <palves@redhat.com>
5229
5230         * maint-test-settings.c: Fix file's intro comment.  Replace all
5231         references to "test-options" with references to "test-settings",
5232         in comments.
5233
5234 2019-07-03  Pedro Alves  <palves@redhat.com>
5235
5236         * maint-test-settings.c (maintenance_test_settings_xxx)
5237         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5238         New.
5239         (maintenance_test_settings_enums): Use them.
5240         (maintenance_test_settings_enum): Default to
5241         maintenance_test_settings_xxx.
5242         (_initialize_maint_test_settings): Initialize
5243         MAINTENANCE_TEST_SETTINGS_FILENAME.
5244
5245 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5246
5247         * breakpoint.h (remove_breakpoints_inf): Change return type to
5248         void, move function documentation here.
5249         * breakpoint.c (remove_breakpoints_inf): Change return type to
5250         void, move function documentation to header.
5251
5252 2019-07-02  Pedro Alves  <palves@redhat.com>
5253
5254         * NEWS (Completion improvements): Mention "info threads".
5255         * thread.c (struct info_threads_opts, info_threads_option_defs)
5256         (make_info_threads_options_def_group): New.
5257         (info_threads_command): Use gdb::option::process_options.
5258         (info_threads_command_completer): New.
5259         (_initialize_thread): Use gdb::option::build_help to build the
5260         help text for "info threads".
5261
5262 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5263
5264         * defs.h (generic_load): Move from here...
5265         * symfile.h (generic_load): ... to here.  Rename name parameter
5266         to args.
5267         * symfile.c (generic_load): Add comment.
5268
5269 2019-07-01  Tom Tromey  <tromey@adacore.com>
5270
5271         * dwarf2read.c
5272         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5273         declaration of without_params.  Fix formatting.
5274
5275 2019-07-01  Tom Tromey  <tromey@adacore.com>
5276
5277         * ada-exp.y (find_primitive_type): Update.
5278         * ada-lang.h (ada_lookup_symbol): Update.
5279         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5280         parameter.
5281         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5282
5283 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5284
5285         PR breakpoints/24541
5286         * gdbarch.c: Regenerate.
5287         * gdbarch.h: Regenerate.
5288         * gdbarch.sh: Add 'stap_adjust_register'.
5289         * i386-tdep.c: Include '<unordered_set>'.
5290         (i386_stap_adjust_register): New function.
5291         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5292         * stap-probe.c (stap_parse_register_operand): Call
5293         'gdbarch_stap_adjust_register'.
5294
5295 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5296
5297         PR python/24742
5298         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5299         * python/python.c (do_start_initialization): Use 'xmalloc'
5300         instead of 'PyMem_Malloc'.
5301
5302 2019-06-28  Tom Tromey  <tromey@adacore.com>
5303
5304         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5305         for Ada.
5306
5307 2019-06-27  Tom Tromey  <tromey@adacore.com>
5308
5309         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5310         objfile_key.
5311         (arm_find_mapping_symbol, arm_record_special_symbol)
5312         (_initialize_arm_tdep): Update.
5313         (arm_objfile_data_free): Remove.
5314
5315 2019-06-27  Tom Tromey  <tromey@adacore.com>
5316
5317         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5318         to cp_print_static_field.
5319
5320 2019-06-26  Tom Tromey  <tromey@adacore.com>
5321
5322         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5323         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5324         declare.
5325
5326 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5327
5328         * features/aarch64-core.c (create_feature_aarch64_core):
5329         Regenerate.
5330         * features/aarch64-core.xml: Add cpsr flags.
5331
5332 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5333
5334         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5335         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5336
5337 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5338
5339         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5340         field.
5341         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5342         use.
5343         (arm_record_special_symbol): Don't insert new symbol in sorted
5344         position, push it at the end.
5345
5346 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5347
5348         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5349         (arm_mapping_symbol_s): Remove.
5350         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5351         (arm_mapping_symbol_vec): New typedef.
5352         (struct arm_per_objfile): Add constructor.
5353         <section_maps>: Change type to
5354         std::unique_ptr<arm_mapping_symbol_vec[]>.
5355         (arm_compare_mapping_symbols): Remove.
5356         (arm_find_mapping_symbol): Adjust to section_maps type change.
5357         (arm_objfile_data_free): Call delete on arm_per_objfile.
5358         (arm_record_special_symbol): Adjust to section_maps type change.
5359         Allocate arm_per_objfile with new.
5360
5361 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5362
5363         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5364         with the command prefix.
5365
5366 2019-06-25  Tom Tromey  <tom@tromey.com>
5367
5368         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5369         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5370
5371 2019-06-25  Tom Tromey  <tom@tromey.com>
5372
5373         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5374         type.
5375         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5376         protected.
5377
5378 2019-06-25  Tom Tromey  <tom@tromey.com>
5379
5380         * tui/tui-winsource.c
5381         (tui_source_window_base::set_is_exec_point_at): Add check against
5382         LOA_ADDRESS.
5383
5384 2019-06-25  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui-source.c (tui_set_source_content): Don't check before
5387         xfree.
5388         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5389
5390 2019-06-25  Tom Tromey  <tom@tromey.com>
5391
5392         * tui/tui-winsource.h (tui_update_source_window_as_is)
5393         (tui_alloc_source_buffer, tui_line_is_displayed)
5394         (tui_addr_is_displayed): Change type of win_info.
5395         * tui/tui-winsource.c (tui_update_source_window_as_is)
5396         (tui_clear_source_content, tui_show_source_line)
5397         (tui_show_source_content, tui_source_window_base::refill)
5398         (tui_source_window_base::set_is_exec_point_at)
5399         (tui_source_window_base::set_is_exec_point_at)
5400         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5401         (tui_alloc_source_buffer, tui_line_is_displayed)
5402         (tui_addr_is_displayed): Change type of win_info.  Update.
5403         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5404         (tui_source_window_base::do_make_visible_with_new_height):
5405         Update.
5406         * tui/tui-source.c (tui_set_source_content)
5407         (tui_set_source_content_nil)
5408         (tui_source_window::do_scroll_vertical): Update.
5409         * tui/tui-layout.c (show_layout): Update.
5410         * tui/tui-disasm.c (tui_set_disassem_content)
5411         (tui_disasm_window::do_scroll_vertical): Update.
5412         * tui/tui-data.h (tui_win_content): Remove.
5413         (struct tui_gen_win_info) <content, content_size>: Remove.
5414         (struct tui_source_element): Add initializers and destructor.
5415         (union tui_which_element, struct tui_win_element): Remove.
5416         (struct tui_source_window_base) <content>: New field.
5417         (struct tui_data_window): Remove destructor.
5418         (tui_alloc_content, tui_free_win_content)
5419         (tui_free_all_source_wins_content): Don't declare.
5420         * tui/tui-data.c (tui_initialize_static_data): Update.
5421         (init_content_element, tui_alloc_content): Remove.
5422         (~tui_gen_win_info): Update.
5423         (~tui_data_window, tui_free_all_source_wins_content)
5424         (tui_free_win_content, free_content, free_content_elements):
5425         Remove.
5426
5427 2019-06-25  Tom Tromey  <tom@tromey.com>
5428
5429         * tui/tui-winsource.h (tui_clear_source_content)
5430         (tui_erase_source_content, tui_show_source_content): Change type
5431         of win_info.
5432         * tui/tui-winsource.c (tui_clear_source_content)
5433         (tui_erase_source_content, tui_show_source_content): Change type
5434         of win_info.
5435         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5436         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5437         win_info.
5438         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5439         win_info.
5440         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5441
5442 2019-06-25  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-winsource.c (tui_clear_source_content)
5445         (tui_source_window_base::set_is_exec_point_at): Update.
5446         * tui/tui-source.c (tui_set_source_content_nil): Update.
5447         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5448         a bool.
5449         * tui/tui-data.c (init_content_element): Update.
5450
5451 2019-06-25  Tom Tromey  <tom@tromey.com>
5452
5453         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5454         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5455         * tui/tui-layout.c (init_and_make_win): Update.
5456         * tui/tui.h (enum tui_win_type): Update.
5457         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5458         tui_win_is_auxillary.
5459         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5460         tui_win_is_auxillary.
5461
5462 2019-06-25  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5465         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5466         (tui_delete_data_content_windows, tui_display_all_data)
5467         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5468         Update.
5469         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5470         * tui/tui-regs.c (tui_last_regs_line_no)
5471         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5472         (tui_show_registers): Update.
5473         (tui_show_register_group): Return void.  Update.
5474         (tui_display_registers_from, tui_display_reg_element_at_line)
5475         (tui_display_registers_from_line, tui_check_register_values):
5476         Update.
5477         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5478         member.
5479         (struct tui_data_window) <regs_content>: Now a std::vector.
5480         <regs_content_count>: Remove.
5481         (tui_add_content_elements, tui_free_data_content): Don't declare.
5482         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5483         (init_content_element): Remove DATA_WIN case.  Add assert.
5484         (tui_add_content_elements): Remove.
5485         (tui_data_window): Update.
5486         (tui_free_data_content): Remove.
5487         (free_content_elements): Remove DATA_WIN case.
5488
5489 2019-06-25  Tom Tromey  <tom@tromey.com>
5490
5491         * tui/tui-data.c (tui_data_item_window): Update.
5492         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5493         * tui/tui-windata.c (tui_display_all_data)
5494         (tui_display_data_from_line): Update.
5495         (tui_check_data_values): Remove.
5496         * tui/tui-regs.c (tui_show_register_group)
5497         (tui_display_reg_element_at_line): Update.
5498         * tui/tui-hooks.c (tui_register_changed)
5499         (tui_refresh_frame_and_register_information): Call
5500         tui_check_register_values.
5501         * tui/tui-data.h (struct tui_data_window) <data_content,
5502         data_content_count, data_type>: Remove.
5503         (enum tui_data_type): Remove.
5504
5505         * tui/tui-data.c (tui_data_window::clear_detail)
5506         (~tui_data_window): Update.
5507
5508 2019-06-25  Tom Tromey  <tom@tromey.com>
5509
5510         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5511         declare.
5512         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5513         Rename from tui_first_data_item_displayed.  Update.
5514         (tui_data_window::refresh_all)
5515         (tui_data_window::do_scroll_vertical): Update.
5516         * tui/tui-data.h (struct tui_data_window)
5517         <first_data_item_displayed>: Declare new method.
5518
5519 2019-06-25  Tom Tromey  <tom@tromey.com>
5520
5521         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5522         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5523         contents...
5524         (tui_initialize_static_data): ...here.
5525
5526 2019-06-25  Tom Tromey  <tom@tromey.com>
5527
5528         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5529         (tui_display_registers_from, tui_check_register_values): Update.
5530         (tui_display_register): Remove win_info parameter; update.
5531         (tui_get_register): Change type of parameters.
5532         * tui/tui-data.h (struct tui_data_element): Remove.
5533         (union tui_which_element) <data>: Remove.
5534         <data_window>: Change type.
5535         (struct tui_data_item_window): New.
5536         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5537         case.  Add assert.
5538         (~tui_data_item_window): New destructor.
5539         (free_content_elements): Remove DATA_ITEM_WIN case.
5540
5541 2019-06-25  Tom Tromey  <tom@tromey.com>
5542
5543         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5544         Remove.
5545
5546 2019-06-25  Tom Tromey  <tom@tromey.com>
5547
5548         * tui/tui-data.h (struct tui_command_element): Remove.
5549         (union tui_which_element) <command>: Remove.
5550         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5551         assert.
5552         (free_content_elements): Remove CMD_WIN case.
5553
5554 2019-06-25  Tom Tromey  <tom@tromey.com>
5555
5556         * tui/tui-layout.c (tui_set_layout): Update.
5557         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5558         * tui/tui-data.c (layout_def): Update.
5559
5560 2019-06-25  Tom Tromey  <tom@tromey.com>
5561
5562         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5563         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5564         (tui_source_window_base::set_new_height): Update.
5565         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5566         Update.
5567         (tui_set_locator_fullname, tui_set_locator_info)
5568         (tui_show_frame_info): Update.
5569         * tui/tui-source.c (tui_set_source_content)
5570         (tui_source_is_displayed): Update.
5571         * tui/tui-layout.c (show_source_disasm_command, show_data)
5572         (show_source_or_disasm_and_command): Update.
5573         * tui/tui-disasm.c (tui_set_disassem_content)
5574         (tui_get_begin_asm_address): Update.
5575         * tui/tui-data.h (struct tui_locator_element): Remove.
5576         (union tui_which_element) <locator>: Remove.
5577         (struct tui_locator_window): New.
5578         (tui_locator_win_info_ptr): Change return type.
5579         * tui/tui-data.c (_locator): Change type.
5580         (tui_locator_win_info_ptr): Change return type.
5581         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5582         (tui_alloc_content): Add assert.
5583
5584 2019-06-25  Tom Tromey  <tom@tromey.com>
5585
5586         * tui/tui-winsource.c
5587         (tui_exec_info_window::maybe_allocate_content): New method.
5588         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5589         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5590         (make_source_or_disasm_window): Add cast.
5591         * tui/tui-data.h (union tui_which_element) <simple_string>:
5592         Remove.
5593         (struct tui_source_info): New.
5594         (struct tui_source_window_base) <execution_info>: Change type.
5595         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5596         case, and add assert.
5597         (tui_alloc_content): Add assert.
5598
5599 2019-06-25  Tom Tromey  <tom@tromey.com>
5600
5601         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5602         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5603         * tui/tui-data.c (tui_alloc_win_info): Remove.
5604
5605 2019-06-25  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5608         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5609         can_highlight.
5610
5611 2019-06-25  Tom Tromey  <tom@tromey.com>
5612
5613         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5614         make_visible_with_new_height method.
5615         (tui_win_info::make_visible_with_new_height): New method.
5616         (tui_source_window_base::do_make_visible_with_new_height)
5617         (tui_data_window::do_make_visible_with_new_height)
5618         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5619         (make_visible_with_new_height): Remove.
5620         (tui_resize_all, tui_adjust_win_heights): Use
5621         make_visible_with_new_height method.
5622         * tui/tui-data.h (struct tui_win_info)
5623         <do_make_visible_with_new_height, make_visible_with_new_height>:
5624         New methods.
5625         (struct tui_source_window_base, struct tui_data_window)
5626         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5627         methods.
5628
5629 2019-06-25  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5632         method.
5633         (update_tab_width): Call update_tab_width method.
5634         * tui/tui-data.h (struct tui_win_info)
5635         (struct tui_source_window_base) <update_tab_width>: New methods.
5636
5637 2019-06-25  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5640         parameter.
5641         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5642         parameter.
5643         (tui_gen_win_info::make_visible): Update.
5644         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5645         parameter.
5646         * tui/tui-data.h (enum tui_box): New enum.
5647         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5648
5649 2019-06-25  Tom Tromey  <tom@tromey.com>
5650
5651         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5652         init_and_make_win for EXEC_INFO_WIN.
5653         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5654         longer inline.
5655         (struct tui_win_info) <~tui_win_info>: Inline.
5656         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5657         Don't declare.
5658         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5659         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5660         Remove.
5661         (tui_initialize_static_data): Update.
5662         (~tui_gen_win_info): Handle more cleanup here.
5663         (~tui_source_window_base): Delete "execution_info".
5664         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5665
5666 2019-06-25  Tom Tromey  <tom@tromey.com>
5667
5668         * tui/tui-layout.c (make_command_window): Don't set
5669         can_highlight.
5670         (show_source_disasm_command): Call the reset method.
5671         (show_data): Don't set can_highlight.  Call the reset method.
5672         (tui_gen_win_info::reset): Rename from init_gen_win_info
5673         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5674         (show_source_or_disasm_and_command): Call the reset method.
5675         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5676         (struct tui_cmd_window): Set can_highlight.
5677
5678 2019-06-25  Tom Tromey  <tom@tromey.com>
5679
5680         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5681         from make_visible.
5682         (tui_make_visible, tui_make_invisible): Rewrite.
5683         (tui_win_info::make_visible): Remove.
5684         (tui_source_window_base::make_visible): Update.
5685         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5686         method.  Moved from...
5687         (struct tui_win_info) <make_visible>: ...here.
5688
5689 2019-06-25  Tom Tromey  <tom@tromey.com>
5690
5691         * tui/tui-winsource.c
5692         (tui_source_window_base::do_scroll_horizontal): Remove direction
5693         parameter.
5694         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5695         direction parameter.
5696         * tui/tui-win.c (tui_win_info::forward_scroll)
5697         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5698         (tui_win_info::right_scroll): Update.
5699         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5700         direction parameter.
5701         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5702         direction parameter.
5703         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5704         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5705         Remove direction parameter.
5706         (struct tui_source_window_base, struct tui_source_window)
5707         (struct tui_disasm_window, struct tui_data_window)
5708         (struct tui_cmd_window): Update.
5709
5710 2019-06-25  Tom Tromey  <tom@tromey.com>
5711
5712         * tui/tui-winsource.h (tui_set_exec_info_content)
5713         (tui_show_exec_info_content, tui_erase_exec_info_content)
5714         (tui_clear_exec_info_content, tui_update_exec_info): Change
5715         argument to tui_source_window_base.
5716         * tui/tui-winsource.c (tui_set_exec_info_content)
5717         (tui_show_exec_info_content, tui_erase_exec_info_content)
5718         (tui_clear_exec_info_content, tui_update_exec_info): Change
5719         argument to tui_source_window_base.
5720
5721 2019-06-25  Tom Tromey  <tom@tromey.com>
5722
5723         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5724         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5725
5726 2019-06-25  Tom Tromey  <tom@tromey.com>
5727
5728         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5729         check.
5730
5731 2019-06-25  Tom Tromey  <tom@tromey.com>
5732
5733         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5734         type to void.
5735         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5736         type to void.
5737         * tui/tui-source.c (tui_set_source_content): Update.
5738         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5739
5740 2019-06-25  Tom Tromey  <tom@tromey.com>
5741
5742         * tui/tui-win.c (window_name_completer, tui_set_focus)
5743         (tui_all_windows_info): Use name method.
5744         * tui/tui-data.h (struct tui_gen_win_info)
5745         (struct tui_source_window, struct tui_disasm_window)
5746         (struct tui_data_window, struct tui_cmd_window) <name>: New
5747         method.
5748         (tui_win_name): Don't declare.
5749         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5750         (tui_win_name): Remove.
5751
5752 2019-06-25  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-winsource.h (tui_update_source_window)
5755         (tui_update_source_window_as_is): Change parameter type.
5756         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5757         to be a tui_source_window_base.
5758         (tui_update_source_window_as_is): Likewise.
5759         * tui/tui-win.c (make_visible_with_new_height): Update.
5760
5761 2019-06-25  Tom Tromey  <tom@tromey.com>
5762
5763         * tui/tui-winsource.c (tui_erase_source_content)
5764         (tui_show_source_content, tui_show_exec_info_content)
5765         (tui_erase_exec_info_content): Use refresh_window method.
5766         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5767         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5768         from tui_refresh_win.
5769         (tui_data_window::refresh_window): New method.
5770         (tui_win_info::refresh, tui_source_window_base::refresh)
5771         (tui_refresh_all): Use refresh_window method.
5772         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5773         method.
5774         * tui/tui-regs.c (tui_display_register): Call refresh_window
5775         method.
5776         * tui/tui-layout.c (show_source_disasm_command)
5777         (show_source_or_disasm_and_command): Call refresh_window method.
5778         * tui/tui-data.h (struct tui_gen_win_info)
5779         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5780         New method.
5781
5782 2019-06-25  Tom Tromey  <tom@tromey.com>
5783
5784         * tui/tui.c (tui_rl_other_window, tui_enable)
5785         (tui_is_window_visible, tui_get_command_dimension): Update.
5786         * tui/tui-winsource.c (tui_update_source_window_as_is)
5787         (tui_clear_source_content, tui_erase_source_content)
5788         (tui_show_source_line, tui_source_window_base::refill)
5789         (tui_source_window_base::do_scroll_horizontal)
5790         (tui_source_window_base::set_is_exec_point_at)
5791         (tui_update_breakpoint_info, tui_set_exec_info_content)
5792         (tui_alloc_source_buffer, tui_line_is_displayed)
5793         (tui_addr_is_displayed): Update.
5794         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5795         (tui_check_and_display_highlight_if_needed)
5796         (tui_win_info::make_visible, tui_win_info::refresh)
5797         (tui_refresh_all): Update.
5798         * tui/tui-windata.c (tui_first_data_item_displayed)
5799         (tui_delete_data_content_windows, tui_erase_data_content)
5800         (tui_display_all_data, tui_data_window::refresh_all)
5801         (tui_check_data_values): Update.
5802         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5803         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5804         (tui_win_info::backward_scroll, tui_refresh_all_win)
5805         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5806         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5807         (tui_source_window_base::set_new_height)
5808         (tui_data_window::set_new_height)
5809         (make_invisible_and_set_new_height)
5810         (make_visible_with_new_height, new_height_ok)
5811         (parse_scrolling_args): Update.
5812         * tui/tui-stack.c (tui_show_frame_info): Update.
5813         * tui/tui-source.c (tui_set_source_content)
5814         (tui_set_source_content_nil, tui_source_is_displayed)
5815         (tui_source_window::do_scroll_vertical): Update.
5816         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5817         (tui_display_registers_from, tui_display_reg_element_at_line)
5818         (tui_check_register_values, tui_reg_command): Update.
5819         * tui/tui-layout.c (tui_default_win_height)
5820         (show_source_disasm_command, show_data, init_and_make_win)
5821         (show_source_or_disasm_and_command): Update.
5822         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5823         (tui_redisplay_readline, tui_mld_flush)
5824         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5825         (tui_getc): Update.
5826         * tui/tui-disasm.c (tui_set_disassem_content)
5827         (tui_disasm_window::do_scroll_vertical): Update.
5828         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5829         Now virtual.
5830         (struct tui_win_info): Derive from tui_gen_win_info.
5831         <~tui_win_info>: Mark as override.
5832         <generic>: Remove member.
5833         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5834         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5835         (~tui_data_window, ~tui_win_info)
5836         (tui_free_all_source_wins_content): Update.
5837         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5838
5839 2019-06-25  Tom Tromey  <tom@tromey.com>
5840
5841         * tui/tui-layout.c (init_and_make_win): Use new.
5842         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5843         destructor, initializers.
5844         (tui_alloc_generic_win_info): Don't declare.
5845         * tui/tui-data.c (_locator): Add argument to constructor.
5846         (source_win, disasm_win): New globals.
5847         (exec_info): Remove.
5848         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5849         Update.
5850         (tui_alloc_generic_win_info): Remove.
5851         (init_content_element): Use new.
5852         (tui_win_info::tui_win_info): Update.
5853         (free_content_elements) <case DATA_WIN>: Use delete.
5854
5855 2019-06-25  Tom Tromey  <tom@tromey.com>
5856
5857         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5858         * tui/tui-windata.c (tui_first_data_item_displayed)
5859         (tui_delete_data_content_windows): Update.
5860         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5861         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5862         (tui_display_registers_from, tui_check_register_values): Update.
5863         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5864         pointer.
5865         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5866         window.
5867         (tui_free_data_content): Update.
5868         (free_content_elements) <case DATA_WIN>: Free the window.
5869
5870 2019-06-25  Tom Tromey  <tom@tromey.com>
5871
5872         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5873         Update.
5874         * tui/tui-layout.c (make_command_window)
5875         (show_source_disasm_command, show_data, init_and_make_win)
5876         (show_source_or_disasm_and_command): Update.
5877         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5878         method.
5879         <can_highight, is_highlighted>: Now bool.
5880         (tui_set_win_highlight): Don't declare.
5881         * tui/tui-data.c (tui_set_win_highlight): Remove.
5882
5883 2019-06-25  Tom Tromey  <tom@tromey.com>
5884
5885         * tui/tui-wingeneral.c (make_visible): Remove check of window
5886         type.
5887
5888 2019-06-25  Tom Tromey  <tom@tromey.com>
5889
5890         * tui/tui-win.c (tui_win_info::max_height)
5891         (tui_cmd_window::max_height): New methods.
5892         (new_height_ok): Call max_height.
5893         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5894         <max_height>: New method.
5895
5896 2019-06-25  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-win.c (tui_source_window_base::set_new_height)
5899         (tui_data_window::set_new_height): New methods.
5900         (make_invisible_and_set_new_height): Call set_new_height method.
5901         * tui/tui-data.h (struct tui_win_info)
5902         (struct tui_source_window_base, struct tui_data_window)
5903         <set_new_height>: New method.
5904
5905 2019-06-25  Tom Tromey  <tom@tromey.com>
5906
5907         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5908         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5909         tui_refresh_data_win.
5910         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5911         method.
5912         (tui_refresh_all_win): Call the refresh_all method.
5913         (tui_set_focus): Likewise.
5914         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5915         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5916         Likewise.
5917
5918 2019-06-25  Tom Tromey  <tom@tromey.com>
5919
5920         * tui/tui-winsource.h (tui_refill_source_window)
5921         (tui_set_is_exec_point_at): Don't declare.
5922         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5923         (tui_source_window_base::refill): Rename from
5924         tui_refill_source_window.
5925         (tui_source_window_base::do_scroll_horizontal): Update.
5926         (tui_source_window_base::set_is_exec_point_at): Rename from
5927         tui_set_is_exec_point_at.
5928         (tui_update_all_breakpoint_info): Update.
5929         * tui/tui-stack.c (tui_show_frame_info): Update.
5930         * tui/tui-layout.c (show_data): Add cast.
5931         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5932         * tui/tui-data.h (struct tui_source_window_base) <refill,
5933         set_is_exec_point_at>: New methods.
5934         (tui_source_windows, tui_add_to_source_windows): Update types.
5935         (tui_add_to_source_windows): Remove redundant declaration.
5936         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5937         (tui_source_windows): Change return type.
5938         (tui_clear_source_windows_detail): Update.
5939         (tui_add_to_source_windows): Change type of parameter.
5940         (tui_free_all_source_wins_content): Update.
5941
5942 2019-06-25  Tom Tromey  <tom@tromey.com>
5943
5944         * tui/tui-wingeneral.c (tui_win_info::refresh)
5945         (tui_source_window_base::refresh): New methods.
5946         (tui_refresh_all): Call the refresh method.
5947         * tui/tui-data.h (struct tui_win_info)
5948         (struct tui_source_window_base) <refresh>: New method.
5949
5950 2019-06-25  Tom Tromey  <tom@tromey.com>
5951
5952         * tui/tui.h (tui_is_window_visible): Return bool.
5953         * tui/tui.c (tui_is_window_visible): Return bool.
5954         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5955         (tui_make_visible, tui_make_invisible)
5956         (tui_win_info::make_visible)
5957         (tui_source_window_base::make_visible, make_all_visible)
5958         (tui_make_all_visible, tui_make_all_invisible): Update.
5959         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5960         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5961         bool.
5962         (struct tui_win_info, struct tui_source_window_base)
5963         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5964         * tui/tui-data.c (tui_init_generic_part): Update.
5965
5966 2019-06-25  Tom Tromey  <tom@tromey.com>
5967
5968         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5969         (tui_source_window_base::make_visible): New methods.
5970         (make_all_visible): Make method call.
5971         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5972         (struct tui_source_window_base, struct tui_cmd_window): Override
5973         make_visible.
5974         (tui_win_is_source_type): Don't declare.
5975         * tui/tui-data.c (tui_win_is_source_type): Remove.
5976
5977 2019-06-25  Tom Tromey  <tom@tromey.com>
5978
5979         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5980         NULL check.
5981
5982 2019-06-25  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5985         Inline constructor.  Add initializers for members.
5986         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5987         constructors; now inline in class.
5988
5989 2019-06-25  Tom Tromey  <tom@tromey.com>
5990
5991         * tui/tui-regs.c (tui_show_registers): Update.
5992         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5993         bool.
5994         * tui/tui-data.c (tui_data_window::clear_detail)
5995         (tui_data_window): Update.
5996
5997 2019-06-25  Tom Tromey  <tom@tromey.com>
5998
5999         * tui/tui-windata.c (tui_display_all_data)
6000         (tui_display_data_from_line, tui_display_data_from)
6001         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6002         Update.
6003         * tui/tui-regs.c (tui_last_regs_line_no)
6004         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6005         (tui_show_registers, tui_show_register_group)
6006         (tui_display_registers_from, tui_display_reg_element_at_line)
6007         (tui_display_registers_from_line, tui_check_register_values)
6008         (tui_reg_next, tui_reg_prev): Update.
6009         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6010         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6011         tui_data_window.
6012         (struct tui_win_info) <detail>: Remove.  Add new fields from
6013         tui_data_info.
6014         (TUI_DATA_WIN): Add cast.
6015         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6016         (~tui_data_window): Simplify.
6017
6018 2019-06-25  Tom Tromey  <tom@tromey.com>
6019
6020         * tui/tui-layout.c (show_source_disasm_command)
6021         (show_source_or_disasm_and_command): Update.
6022         * tui/tui-io.c (update_cmdwin_start_line)
6023         (tui_redisplay_readline): Update.
6024         * tui/tui-data.h (struct tui_command_info): Remove.
6025         (struct tui_win_info) <detail>: Remove command_info member.
6026         (struct tui_data_window) <start_line>: New member, from
6027         tui_command_info.
6028         (TUI_CMD_WIN): Add casts.
6029
6030 2019-06-25  Tom Tromey  <tom@tromey.com>
6031
6032         * tui/tui-winsource.c (tui_update_source_window)
6033         (tui_refill_source_window)
6034         (tui_source_window_base::do_scroll_horizontal)
6035         (tui_update_breakpoint_info, tui_set_exec_info_content)
6036         (tui_show_exec_info_content, tui_erase_exec_info_content)
6037         (tui_clear_exec_info_content): Update.
6038         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6039         Update.
6040         * tui/tui-win.c (make_invisible_and_set_new_height)
6041         (make_visible_with_new_height): Update.
6042         * tui/tui-source.c (tui_set_source_content)
6043         (tui_show_symtab_source): Update.
6044         * tui/tui-layout.c (extract_display_start_addr)
6045         (show_source_disasm_command, show_data)
6046         (make_source_or_disasm_window)
6047         (show_source_or_disasm_and_command): Update.
6048         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6049         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6050         "gdbarch".
6051         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6052         to tui_source_window_base.
6053         (struct tui_win_info) <detail>: Remove source_info member.
6054         (struct tui_source_window_base) <has_locator>: Inline.
6055         Move contents from tui_source_info; rename has_locator member to
6056         m_has_locator.
6057         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6058         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6059         header file.
6060         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6061         Simplify.
6062         (tui_free_all_source_wins_content): Cast to
6063         tui_source_window_base.
6064
6065 2019-06-25  Tom Tromey  <tom@tromey.com>
6066
6067         * tui/tui-win.c (make_invisible_and_set_new_height)
6068         (make_visible_with_new_height): Call has_locator method.
6069         * tui/tui-layout.c (show_source_disasm_command, show_data)
6070         (show_source_or_disasm_and_command): Update for bool change.
6071         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6072         (tui_win_info) <has_locator>: New method.
6073         (struct tui_source_window_base) <has_locator>: New method.
6074         (tui_win_has_locator): Don't declare.
6075         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6076         from tui_win_has_locator.
6077         (tui_source_window_base): Use false, not FALSE.
6078
6079 2019-06-25  Tom Tromey  <tom@tromey.com>
6080
6081         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6082         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6083         clear_detail method directly.
6084         (tui_clear_win_detail): Remove.
6085
6086 2019-06-25  Tom Tromey  <tom@tromey.com>
6087
6088         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6089         "this", not TUI_DISASM_WIN.
6090
6091 2019-06-25  Tom Tromey  <tom@tromey.com>
6092
6093         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6094         declare.
6095         * tui/tui-winsource.c
6096         (tui_source_window_base::do_scroll_horizontal): Rename from
6097         tui_horizontal_source_scroll.
6098         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6099         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6100         from tui_vertical_data_scroll.
6101         * tui/tui-win.h (tui_scroll): Don't declare.
6102         * tui/tui-win.c (tui_win_info::forward_scroll)
6103         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6104         (tui_win_info::right_scroll): Rename and update.
6105         (tui_scroll_forward_command, tui_scroll_backward_command)
6106         (tui_scroll_left_command, tui_scroll_right_command): Update.
6107         (tui_scroll): Remove.
6108         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6109         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6110         from tui_vertical_source_scroll.
6111         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6112         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6113         from tui_vertical_disassem_scroll.
6114         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6115         do_scroll_horizontal>: New methods.
6116         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6117         Likewise.
6118         (struct tui_source_window_base): Add do_scroll_horizontal.
6119         (struct tui_source_window, struct tui_disasm_window): Add
6120         do_scroll_vertical.
6121         (struct tui_data_window, struct tui_cmd_window): Add
6122         do_scroll_horizontal and do_scroll_vertical.
6123         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6124
6125 2019-06-25  Tom Tromey  <tom@tromey.com>
6126
6127         * tui/tui-data.h (struct tui_source_window_base): New struct.
6128         (struct tui_source_window): Derive from tui_source_window_base.
6129         (struct tui_disasm_window): New struct.
6130         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6131         from tui_source_window::clear_detail.
6132         (tui_source_window_base): Rename from tui_source_window.
6133         (~tui_source_window_base): Rename from ~tui_source_window.
6134         (tui_alloc_win_info): Create a tui_disasm_window.
6135
6136 2019-06-25  Tom Tromey  <tom@tromey.com>
6137
6138         * tui/tui-data.h (struct tui_source_window)
6139         (struct tui_data_window): Declare destructors.
6140         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6141         destructors.
6142         (tui_win_info): Simplify.
6143
6144 2019-06-25  Tom Tromey  <tom@tromey.com>
6145
6146         * tui/tui-winsource.c (tui_display_main)
6147         (tui_update_source_windows_with_addr)
6148         (tui_update_all_breakpoint_info): Update.
6149         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6150         (new_height_ok, parse_scrolling_args): Update.
6151         * tui/tui-stack.c (tui_show_frame_info): Update.
6152         * tui/tui-data.h (struct tui_list): Remove.
6153         (tui_source_windows): Return a reference to a std::vector.
6154         * tui/tui-data.c (source_windows): Now a std::vector.
6155         (tui_source_windows): Change return type.
6156         (tui_clear_source_windows): Rewrite.
6157         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6158         (tui_free_all_source_wins_content): Rewrite.
6159
6160 2019-06-25  Tom Tromey  <tom@tromey.com>
6161
6162         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6163         (struct tui_data_window, struct tui_cmd_window): Declare
6164         clear_detail method.
6165         * tui/tui-data.c (tui_source_window::clear_detail)
6166         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6167         methods.
6168         (tui_clear_win_detail): Simplify.
6169
6170 2019-06-25  Tom Tromey  <tom@tromey.com>
6171
6172         * tui/tui-layout.c (make_source_window, make_disasm_window)
6173         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6174         Return the new window.
6175         (show_source_disasm_command, show_data)
6176         (show_source_or_disasm_and_command): Update.
6177
6178 2019-06-25  Tom Tromey  <tom@tromey.com>
6179
6180         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6181         parameter.  Return the new window.
6182         (show_source_disasm_command): Update and remove NULL check.
6183         (show_source_or_disasm_and_command): Update.
6184
6185 2019-06-25  Tom Tromey  <tom@tromey.com>
6186
6187         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6188
6189 2019-06-25  Tom Tromey  <tom@tromey.com>
6190
6191         * tui/tui-data.h (struct tui_win_info): Make constructor
6192         protected.  Make destructor virtual.  Add initializers.
6193         (tui_source_window, tui_data_window, tui_cmd_window): New
6194         classes.
6195         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6196         constructor.  Add "type" parameter.
6197         (tui_source_window, tui_data_window, tui_cmd_window): New
6198         constructors.
6199         (tui_alloc_win_info): Instantiate the appropriate subclass.
6200
6201 2019-06-25  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-win.c (tui_resize_all): Use delete.
6204         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6205         destructor.
6206         (tui_free_window): Don't declare.
6207         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6208         Update.
6209
6210 2019-06-25  Tom Tromey  <tom@tromey.com>
6211
6212         * tui/tui-data.h (struct tui_win_info): Add constructor.
6213         * tui/tui-data.c (tui_alloc_win_info): Use new.
6214         (tui_free_window): Use delete.
6215
6216 2019-06-22  Tom Tromey  <tom@tromey.com>
6217
6218         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6219         declare.
6220         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6221
6222 2019-06-22  Tom Tromey  <tom@tromey.com>
6223
6224         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6225         declare.
6226         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6227
6228 2019-06-22  Tom de Vries  <tdevries@suse.de>
6229
6230         * dwarf2read.c (create_addrmap_from_aranges)
6231         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6232         instead of '%zu'.
6233
6234 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6235
6236         * dwarf2read.h (dwarf2_section_info_def): Remove.
6237         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6238         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6239         std::vector<dwarf2_section_info>.
6240         (struct dwo_file) <~dwo_file>: Remove.
6241         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6242         types field.
6243         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6244         (dwarf2_read_debug_names): Likewise.
6245         (create_debug_types_hash_table): Change parameter type to
6246         array_view, adjust code accordingly.
6247         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6248         (partial_die_info::fixup): Likewise.
6249         (determine_prefix): Likewise.
6250         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6251
6252 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6253
6254         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6255         gdb_bfd_ref_ptr.
6256         <~dwo_file>: Remove call to gdb_bfd_unref.
6257         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6258         gdb_bfd_ref_ptr::get.
6259
6260 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6261
6262         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6263         type to htab_up.
6264         * dwarf2read.c (struct dwo_file): Initialize fields.
6265         <~dwo_file>: New.
6266         (free_dwo_file): Remove, move content to ~dwo_file.
6267         (struct dwo_file_deleter): Remove.
6268         (dwo_file_up>: Remove custom deleter.
6269         (free_dwo_files): Remove.
6270         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6271         dwo_files.
6272         (process_skeletonless_type_units): Call unique_ptr::get.
6273         (allocate_dwo_file_hash_table): Add deleter to created hash
6274         table.  Change return type to htab_up.
6275         (lookup_dwo_file_slot): Don't memset dwo_file, call
6276         unique_ptr::get.
6277         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6278         (create_dwo_unit_in_dwp_v2): Likewise.
6279         (open_and_init_dwo_file): Likewise.
6280         (free_dwo_file_from_slot): Remove.
6281
6282 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6283
6284         * dwarf2read.h (struct dwarf2_section_info) <readin,
6285         is_virtual>: Change type to bool.
6286         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6287         true instead of 1.
6288
6289 2019-06-19  Tom Tromey  <tom@tromey.com>
6290
6291         * tui/tui-data.h (tui_init_content_element): Don't declare.
6292
6293 2019-06-19  Tom Tromey  <tom@tromey.com>
6294
6295         * tui/tui-data.h (tui_init_win_info): Don't declare.
6296
6297 2019-06-19  Tom de Vries  <tdevries@suse.de>
6298
6299         * dwarf2read.h (abstract_to_concrete): Change type to
6300         std::unordered_map<sect_offset, std::vector<sect_offset>,
6301         gdb::hash_enum<sect_offset>>.
6302
6303 2019-06-19  Tom Tromey  <tromey@adacore.com>
6304
6305         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6306         EVAL_AVOID_SIDE_EFFECTS specially.
6307
6308 2019-06-19  Tom Tromey  <tromey@adacore.com>
6309
6310         * source-cache.c (highlighter): New global.
6311         (source_cache::get_source_lines): Create a highlighter on demand.
6312
6313 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6314
6315         * defs.h (deprecated_interactive_hook): Delete declaration.
6316         * interps.c (clear_interpreter_hooks): Remove use of
6317         deprecated_interactive_hook.
6318         * top.c (deprecated_interactive_hook): Delete definition.
6319         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6320
6321 2019-06-18  Tom de Vries  <tdevries@suse.de>
6322
6323         PR gdb/24515
6324         * dwarf2read.h (abstract_to_concrete): Change type from
6325         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6326         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6327         * dwarf2read.c (read_variable): Update.
6328         (dwarf2_fetch_die_loc_sect_off): Update.
6329
6330 2019-06-17  Tom de Vries  <tdevries@suse.de>
6331
6332         PR gdb/24617
6333         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6334         accessing parent[parent_len - 1].
6335
6336 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6337
6338         PR gdb/24364
6339         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6340         call dtrace_process_dof with NULL dof.
6341
6342 2019-06-16  Tom de Vries  <tdevries@suse.de>
6343
6344         PR gdb/24445
6345         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6346
6347 2019-06-16  Tom Tromey  <tom@tromey.com>
6348
6349         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6350         (make_all_visible): Use address of member.
6351
6352 2019-06-16  Tom Tromey  <tom@tromey.com>
6353
6354         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6355         (tui_free_window, free_content, free_content_elements): Remove
6356         unnecessary cast.
6357         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6358         cast.
6359         * tui/tui-regs.c (tui_show_register_group)
6360         (tui_display_registers_from, tui_display_reg_element_at_line):
6361         Remove unnecessary cast.
6362
6363 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6364
6365         * linux-nat.c (normal_mask): Delete.
6366         (_initialize_linux_nat): Don't initialise normal_mask.
6367
6368 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6369
6370         PR gdb/24445
6371         * dwarf-index-write.h (write_psymtabs_to_index): Add
6372         dwz_basename parameter.
6373         * dwarf-index-write.c (write_gdbindex): Move file writing to
6374         write_gdbindex_1.  Change return type void.
6375         (assert_file_size): Move up, remove filename parameter.
6376         (write_gdbindex_1): New function.
6377         (write_debug_names): Change return type to void, call
6378         assert_file_size.
6379         (struct index_wip_file): New struct.
6380         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6381         file logic to index_wip_file.  Write index for dwz file if
6382         needed.
6383         (save_gdb_index_command): Pass basename of dwz file, if present.
6384         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6385         build-id of dwz file, if present.
6386         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6387         (dwarf2_get_dwz_file): Likewise.
6388         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6389         (dwarf2_get_dwz_file): Likewise.
6390
6391 2019-06-16  Tom Tromey  <tom@tromey.com>
6392
6393         * coffread.c (process_coff_symbol): Use xstrdup.
6394         * value.c (create_internalvar): Use xstrdup.
6395
6396 2019-06-16  Tom Tromey  <tom@tromey.com>
6397
6398         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6399         * breakpoint.c (stopin_command, stopat_command)
6400         (until_break_command, decode_location_default): Remove unnecessary
6401         cast.
6402         * utils.c (subset_compare): Remove unnecessary cast.
6403         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6404         cast.
6405         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6406         cast.
6407         * infcmd.c (path_command): Remove unnecessary cast.
6408         * coffread.c (decode_type): Remove unnecessary cast.
6409         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6410         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6411         * tui/tui-stack.c (tui_show_locator_content)
6412         (tui_show_frame_info): Remove unnecessary cast.
6413         * tui/tui-win.c (tui_scroll_forward_command)
6414         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6415         (parse_scrolling_args): Remove unnecessary cast.
6416         * tui/tui-data.c (init_win_info, tui_del_window)
6417         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6418         (free_content_elements): Remove unnecessary cast.
6419         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6420         unnecessary cast.
6421         * tui/tui-source.c (tui_set_source_content)
6422         (tui_vertical_source_scroll): Remove unnecessary cast.
6423         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6424         cast.
6425         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6426         * tui/tui-regs.c (tui_display_registers_from)
6427         (tui_display_register): Remove unnecessary cast.
6428         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6429         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6430         (make_visible): Remove unnecessary cast.
6431         * tui/tui-winsource.c (tui_erase_source_content)
6432         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6433         unnecessary cast.
6434         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6435         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6436         * stabsread.c (read_type, read_array_type, read_range_type):
6437         Remove unnecessary cast.
6438         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6439         (parse_symbol, parse_type, upgrade_type, parse_external)
6440         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6441         unnecessary cast.
6442         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6443
6444 2019-06-16  Tom Tromey  <tom@tromey.com>
6445
6446         * tui/tui-data.c (tui_alloc_generic_win_info)
6447         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6448         checks.
6449
6450 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6451             Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * f-typeprint.c (f_print_type): Don't return early for not
6454         associated or not allocated types.
6455         (f_type_print_varspec_suffix): Add print_rank parameter and print
6456         ranks of array types in case they dangling.
6457         (f_type_print_base): Add print_rank parameter.
6458
6459 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * NEWS: Mention new MI commands.
6462         * break-catch-throw.c (enum exception_event_kind): Move to
6463         breakpoint.h.
6464         (print_mention_exception_catchpoint): Output text as a single
6465         message.
6466         (catch_exception_command_1): Rename to...
6467         (catch_exception_event): ...this, make non-static, update header
6468         command, and change some parameter types.
6469         (catch_catch_command): Update for changes to
6470         catch_exception_command_1.
6471         (catch_throw_command): Likewise.
6472         (catch_rethrow_command): Likewise.
6473         * breakpoint.c (enum exception_event_kind): Delete.
6474         * breakpoint.h (enum exception_event_kind): Moved here from
6475         break-catch-throw.c.
6476         (catch_exception_event): Declare.
6477         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6478         (mi_cmd_catch_throw): New function.
6479         (mi_cmd_catch_rethrow): New function.
6480         (mi_cmd_catch_catch): New function.
6481         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6482         'catch-catch' entries.
6483         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6484         (mi_cmd_catch_rethrow): Declare.
6485         (mi_cmd_catch_catch): Declare.
6486
6487 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6488
6489         * annotate.c (annotate_source_line): Change return type to void,
6490         update implementation to match.
6491         * annotate.h (annotate_source_line): Change return type to void,
6492         update header comment.
6493         * stack.c (print_frame_info): Don't change what frame information
6494         is printed based on whether annotations are on or not.
6495
6496 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6499         (annotate_source): Make static.
6500         (annotate_source_line): Moved from source.c and renamed from
6501         identify_source_line.  Update the return type.
6502         * annotate.h (annotate_source): Delete declaration.
6503         (annotate_source_line): Declaration moved from source.h, and
6504         renamed from identify_source_line.  Return type updated.
6505         * source.c (identify_source_line): Moved to annotate.c and renamed
6506         to annotate_source_line.
6507         (info_line_command): Remove check of annotation_level.
6508         * source.h (identify_source_line): Move declaration to annotate.h
6509         and rename to annotate_source_line.
6510         * stack.c: Add 'annotate.h' include.
6511         (print_frame_info): Remove check of annotation_level before
6512         calling annotate_source_line.
6513
6514 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * source-cache.c (source_cache::get_plain_source_lines): Use
6517         open_source_file_with_line_charpos instead of just
6518         open_source_file, remove call to find_source_lines.
6519         (source_cache::get_source_lines): Likewise.
6520         * source.c (find_source_lines): Make static.
6521         (get_filename_and_charpos): Renamed into...
6522         (open_source_file_with_line_charpos): ..this along with changes to
6523         return a scoped_fd, and some other minor clean ups.
6524         (identify_source_line): Use open_source_file_with_line_charpos.
6525         (search_command_helper): Use open_source_file_with_line_charpos
6526         instead of just open_source_file, remove call to
6527         find_source_lines.
6528         * source.h (open_source_file_with_line_charpos): Declare new
6529         function.
6530         (find_source_lines): Delete declaration.
6531
6532 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6533
6534         * source.c (get_filename_and_charpos): Remove fullname
6535         parameter.
6536         (identify_source_line): Update call to get_filename_and_charpos.
6537
6538 2019-06-14  Tom Tromey  <tromey@adacore.com>
6539
6540         PR gdb/24502:
6541         * ui-style.h (skip_ansi_escape): Update comment.
6542         * ui-file.h (class no_terminal_escape_file): New class.
6543         * ui-file.c (no_terminal_escape_file::write)
6544         (no_terminal_escape_file::puts): New methods.
6545         * cli/cli-logging.c (handle_redirections): Use
6546         no_terminal_escape_file.
6547
6548 2019-06-14  Tom Tromey  <tromey@adacore.com>
6549
6550         * NEWS: Move convenience variable news above Python news.
6551
6552 2019-06-14  Tom Tromey  <tom@tromey.com>
6553
6554         * gnulib: Move directory to top-level.
6555         * configure.ac: Don't configure gnulib.
6556         * configure: Rebuild.
6557         * common/common-defs.h: Use new path to gnulib.
6558         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6559         (GNULIB_H): Remove.
6560         (INCGNU): Look in new gnulib location.
6561         (HFILES_NO_SRCDIR): Remove gnulib files.
6562         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6563         (generated_files): Remove GNULIB_H.
6564         ($(LIBGNU), all-lib): Remove targets.
6565         (distclean): Don't mention GNULIB_BUILDDIR.
6566         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6567
6568 2019-06-14  Tom Tromey  <tromey@adacore.com>
6569
6570         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6571         Warn if symbol file does not provide any symbols.
6572
6573 2019-06-14  Tom Tromey  <tromey@adacore.com>
6574
6575         * source.c (find_and_open_source): Respect basenames_may_differ.
6576
6577 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6578
6579         * annotate.c (annotate_breakpoints_invalid): Make use of
6580         scoped_restore_terminal_state.
6581         (annotate_frames_invalid): Likewise.
6582
6583 2019-06-14  Tom Tromey  <tromey@adacore.com>
6584
6585         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6586         allow assignment to an internalvar.
6587
6588 2019-06-14  Tom Tromey  <tromey@adacore.com>
6589
6590         * ada-lex.l: Allow "_" in attribute names.
6591
6592 2019-06-14  Tom Tromey  <tromey@adacore.com>
6593
6594         PR gdb/24653:
6595         * regcache.c (registers_changed): Don't call alloca.
6596         * top.c (execute_command): Don't call alloca.
6597
6598 2019-06-13  Pedro Alves  <palves@redhat.com>
6599
6600         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6601         'expression'.  When parsing an expression, error out if there's
6602         junk after "unlimited".
6603         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6604         (do_set_command): Adjust calls to is_unlimited_literal.
6605
6606 2019-06-13  Pedro Alves  <palves@redhat.com>
6607
6608         * compile/compile.c (make_compile_options_def_group): Add braces
6609         around array_view initializer.
6610         * thread.c (make_thread_apply_all_options_def_group)
6611         (make_thread_apply_all_options_def_group): Likewise.
6612
6613 2019-06-13  Pedro Alves  <palves@redhat.com>
6614
6615         * NEWS (New commands): Mention "maint test-options
6616         require-delimiter", "maint test-options unknown-is-error", "maint
6617         test-options unknown-is-operand" and "maint show
6618         test-options-completion-result".
6619         (New command options, command completion): New section.
6620         (Completion improvements): New section.
6621         Mention that you can abbreviate "unlimited".
6622
6623 2019-06-13  Pedro Alves  <palves@redhat.com>
6624
6625         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6626         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6627         * unittests/cli-utils-selftests.c (test_parse_flags)
6628         (test_parse_flags_qcs): Delete.
6629         (test_cli_utils): Don't call deleted functions.
6630
6631 2019-06-13  Pedro Alves  <palves@redhat.com>
6632
6633         * thread.c: Include "cli/cli-option.h".
6634         (tp_array_compar_ascending): Global.
6635         (tp_array_compar): Delete function.
6636         (tp_array_compar_ascending, tp_array_compar_descending): New
6637         functions.
6638         (ascending_option_def, qcs_flag_option_def)
6639         (thr_qcs_flags_option_defs)
6640         (make_thread_apply_all_options_def_group)
6641         (make_thread_apply_options_def_group): New.
6642         (thread_apply_all_command): Use gdb::option::process_options.
6643         (thread_apply_command_completer)
6644         (thread_apply_all_command_completer): New.
6645         (thread_apply_command): Use gdb::option::process_options.
6646         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6647         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6648         to generate help text of "thread apply".  Adjust "taas"'s help.
6649         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6650         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6651
6652 2019-06-13  Pedro Alves  <palves@redhat.com>
6653
6654         * thread.c (thread_apply_command): Check for invalid TID with
6655         isdigit instead of !isalpha.
6656
6657 2019-06-13  Pedro Alves  <palves@redhat.com>
6658
6659         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6660         (validate_flags_qcs): New.
6661         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6662         (validate_flags_qcs): Declare.
6663         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6664         (make_frame_apply_options_def_group): New.
6665         (frame_apply_command_count): Process options with
6666         gdb::option::process_options.
6667         (frame_apply_completer): New.
6668         (frame_apply_level_completer, frame_apply_all_completer)
6669         (frame_apply_completer): New.
6670         (_initialize_stack): Update help of "frame apply", "frame apply
6671         level", "frame apply all" and "faas" to mention supported options
6672         and install command completers.
6673         * stack.h (frame_apply_all_completer): Declare.
6674         * thread.c: Include "stack.h".
6675         (tfaas_command): Add "--".
6676         (_initialize_thread): Update help "tfaas" to mention supported
6677         options and install command completer.
6678
6679 2019-06-13  Pedro Alves  <palves@redhat.com>
6680
6681         * completer.c (complete_nested_command_line): New.
6682         (gdb_completion_word_break_characters_throw): Add assertion.
6683         * completer.h (complete_nested_command_line): Declare.
6684
6685 2019-06-13  Pedro Alves  <palves@redhat.com>
6686
6687         * stack.c (parse_backtrace_qualifiers): New.
6688         (backtrace_command): Use it.
6689         (backtrace_command_completer): Complete on qualifiers.
6690
6691 2019-06-13  Pedro Alves  <palves@redhat.com>
6692
6693         * frame.c: Include "cli/cli-option.h.
6694         (user_set_backtrace_options): New.
6695         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6696         Delete.
6697         (get_prev_frame): Adjust.
6698         (boolean_option_def, uinteger_option_def)
6699         (set_backtrace_option_defs): New.
6700         (_initialize_frame): Adjust and use
6701         gdb::option::add_setshow_cmds_for_options to install "set
6702         backtrace past-main" and "set backtrace past-entry".
6703         * frame.h: Include "cli/cli-option.h".
6704         (struct frame_print_options): Forward declare.
6705         (print_frame_arguments_all, print_frame_arguments_scalars)
6706         (print_frame_arguments_none): Declare.
6707         (print_entry_values): Delete declaration.
6708         (struct frame_print_options, user_frame_print_options): New.
6709         (struct set_backtrace_options): New.
6710         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6711         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6712         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6713         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6714         (list_args_or_locals): Add frame_print_options parameter.
6715         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6716         * python/py-framefilter.c (enumerate_args): Pass down
6717         USER_FRAME_PRINT_OPTIONS.
6718         * stack.c: Include "cli/cli-option.h".
6719         (print_frame_arguments_all, print_frame_arguments_scalars)
6720         (print_frame_arguments_none): Declare.
6721         (print_raw_frame_arguments, print_entry_values): Delete.
6722         (user_frame_print_options): New.
6723         (boolean_option_def, enum_option_def, frame_print_option_defs):
6724         New.
6725         (struct backtrace_cmd_options): New.
6726         (bt_flag_option_def): New.
6727         (backtrace_command_option_defs): New.
6728         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6729         (print_frame_arg, read_frame_arg, print_frame_args)
6730         (print_frame_info, print_frame): Add frame_print_options parameter
6731         and use it.
6732         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6733         (backtrace_command_1): Add frame_print_options and
6734         backtrace_cmd_options parameters and use them.
6735         (make_backtrace_options_def_group): New.
6736         (backtrace_command): Process command options with
6737         gdb::option::process_options.
6738         (backtrace_command_completer): New.
6739         (_initialize_stack): Extend "backtrace"'s help to mention
6740         supported options.  Install completer for "backtrace".
6741         Install some settings commands with add_setshow_cmds_for_options.
6742
6743 2019-06-13  Pedro Alves  <palves@redhat.com>
6744
6745         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6746         and that "set/show print raw frame-arguments" are now deprecated.
6747
6748         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6749         command.
6750         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6751         * stack.c (_initialize_stack): Install "set/show print
6752         raw-frame-arguments", and deprecate "set/show print raw
6753         frame-arguments".
6754         * valprint.c (_initialize_valprint): Deprecate "set/show print
6755         raw".
6756
6757 2019-06-13  Pedro Alves  <palves@redhat.com>
6758
6759         * compile/compile.c (struct compile_options): New.
6760         (compile_flag_option_def, compile_command_option_defs)
6761         (make_compile_options_def_group): New.
6762         (compile_file_command): Handle options with
6763         gdb::option::process_options.
6764         (compile_file_command_completer): New function.
6765         (compile_code_command): Handle options with
6766         gdb::option::process_options.
6767         (compile_code_command_completer): New function.
6768         (_initialize_compiler): Install completers for "compile code" and
6769         "compile file".  Mention available options in "compile code" and
6770         "compile code"'s help.
6771         * completer.c (advance_to_completion_word): New, factored out from
6772         ...
6773         (advance_to_expression_complete_word_point): ... this.
6774         (advance_to_filename_complete_word_point): New.
6775         * completer.h (advance_to_filename_complete_word_point): New
6776         declaration.
6777
6778 2019-06-13  Pedro Alves  <palves@redhat.com>
6779
6780         * compile/compile.c: Include "cli/cli-option.h".
6781         (compile_print_value): Scope data pointer is now a
6782         value_print_options pointer; adjust.
6783         (compile_print_command): Process options.  Scope data pointer is
6784         now a value_print_options pointer; adjust.
6785         (_initialize_compile): Update "compile print"'s help to include
6786         supported options.  Install a completer for "compile print".
6787         * cp-valprint.c (show_vtblprint, show_objectprint)
6788         (show_static_field_print): Delete.
6789         (_initialize_cp_valprint): Don't install "set print
6790         static-members", "set print vtbl", "set print object" here.
6791         * printcmd.c: Include "cli/cli-option.h" and
6792         "common/gdb_optional.h".
6793         (print_command_parse_format): Rework to fill in a
6794         value_print_options instead of a format_data.
6795         (print_value): Change parameter type from format_data pointer to
6796         value_print_options reference.  Adjust.
6797         (print_command_1): Process options.  Adjust to pass down a
6798         value_print_options.
6799         (print_command_completer): New.
6800         (_initialize_printcmd): Install print_command_completer as
6801         handle_brkchars completer for the "print" command.  Update
6802         "print"'s help to include supported options.
6803         * valprint.c: Include "cli/cli-option.h".
6804         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6805         here from cp-valprint.c.
6806         (boolean_option_def, uinteger_option_def)
6807         (value_print_option_defs, make_value_print_options_def_group):
6808         New.  Use gdb::option::add_setshow_cmds_for_options to install
6809         "set print elements", "set print null-stop", "set print repeats",
6810         "set print pretty", "set print union", "set print array", "set
6811         print address", "set print symbol", "set print array-indexes".
6812         * valprint.h: Include <string> and "cli/cli-option.h".
6813         (make_value_print_options_def_group): Declare.
6814         (print_value): Change parameter type from format_data pointer to
6815         value_print_options reference.
6816         (print_command_completer): Declare.
6817
6818 2019-06-13  Pedro Alves  <palves@redhat.com>
6819
6820         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6821         (COMMON_SFILES): Add maint-test-settings.c.
6822         * cli/cli-decode.c (boolean_enums): New global, factored out from
6823         ...
6824         (add_setshow_boolean_cmd): ... here.
6825         * cli/cli-decode.h (boolean_enums): Declare.
6826         * cli/cli-option.c: New file.
6827         * cli/cli-option.h: New file.
6828         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6829         factored out from ...
6830         (parse_cli_boolean_value(const char *)): ... this.
6831         (is_unlimited_literal): Change parameter type to pointer to
6832         pointer.  Adjust and advance ARG pointer.
6833         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6834         (parse_cli_var_enum): New, factored out from ...
6835         (do_set_command): ... this.  Adjust.
6836         * cli/cli-setshow.h (parse_cli_boolean_value)
6837         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6838         (parse_cli_var_enum): Declare.
6839         * cli/cli-utils.c: Include "cli/cli-option.h".
6840         (get_ulongest): New.
6841         * cli/cli-utils.h (get_ulongest): Declare.
6842         (check_for_argument): New overloads.
6843         * maint-test-options.c: New file.
6844
6845 2019-06-13  Pedro Alves  <palves@redhat.com>
6846
6847         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6848         parse a range if "-" is at the end of the string.
6849
6850 2019-06-13  Pedro Alves  <palves@redhat.com>
6851
6852         * cli/cli-setshow.c (parse_auto_binary_operation)
6853         (parse_cli_boolean_value): Don't allow "o".
6854
6855 2019-06-13  Pedro Alves  <palves@redhat.com>
6856
6857         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6858         * NEWS: Mention maint test-settings KIND.
6859         * maint-test-settings.c: New file.
6860
6861 2019-06-13  Pedro Alves  <palves@redhat.com>
6862
6863         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6864         completer.
6865         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6866         "set" completers.
6867
6868 2019-06-13  Pedro Alves  <palves@redhat.com>
6869
6870         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6871         after item.
6872
6873 2019-06-13  Pedro Alves  <palves@redhat.com>
6874
6875         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6876
6877 2019-06-13  Pedro Alves <palves@redhat.com>
6878
6879         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6880         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6881         call.
6882         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6883         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6884         calls.
6885         (check_for_argument): Skip spaces after argument.
6886
6887 2019-06-13  Pedro Alves  <palves@redhat.com>
6888
6889         * thread.c (thread_apply_command): Adjust TID parsing.
6890         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6891         detected before end of string.
6892         (tid_is_in_list): Error out if LIST is invalid.
6893
6894 2019-06-13  Pedro Alves  <palves@redhat.com>
6895
6896         * completer.c (complete_line_internal_1): Rewind completion word
6897         point.
6898         (completion_tracker::advance_custom_word_point_by): Change
6899         parameter type to int.
6900         * completer.h (completion_tracker::advance_custom_word_point_by):
6901         Likewise.
6902
6903 2019-06-13  Pedro Alves  <palves@redhat.com>
6904
6905         * completer.c (advance_to_completion_word): Handle delimiters.
6906
6907 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6908
6909         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6910
6911 2019-06-11  Tom Tromey  <tom@tromey.com>
6912
6913         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6914         (xmalloc_failed): Move to alloc.c.
6915         * alloc.c: New file.
6916         * Makefile.in (COMMON_SFILES): Add alloc.c.
6917
6918 2019-06-11  Tom Tromey  <tom@tromey.com>
6919
6920         * nat/linux-waitpid.c: Don't include server.h.
6921         (linux_debug): Remove.
6922         (my_waitpid): Update.
6923
6924 2019-06-11  Tom Tromey  <tromey@adacore.com>
6925
6926         * infcall.c (_initialize_infcall): Remove trailing newline from
6927         help.
6928         * user-regs.c (_initialize_user_regs): Remove trailing newline
6929         from help.
6930         * typeprint.c (_initialize_typeprint): Remove trailing newline
6931         from help.
6932         * reverse.c (_initialize_reverse): Remove trailing newlines from
6933         help.
6934         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6935         from help.
6936         * language.c (add_set_language_command): Remove trailing newline
6937         from help.
6938         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6939         help.
6940         * disasm.c (_initialize_disasm): Remove trailing newline from
6941         help.
6942         * top.c (init_main): Remove trailing newline from help.
6943         * interps.c (_initialize_interpreter): Remove trailing newline
6944         from help.
6945         * btrace.c (_initialize_btrace): Remove trailing newlines from
6946         help.
6947         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6948         from help.
6949         * python/python.c (_initialize_python): Remove trailing newline
6950         from help.
6951         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6952         help.
6953         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6954         from help.  Reformat some text.
6955         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6956         from help.
6957         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6958         newline from help.
6959
6960 2019-06-11  Tom Tromey  <tromey@adacore.com>
6961
6962         * darwin-nat.c (darwin_decode_exception_message)
6963         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6964
6965 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6966
6967         * valops.c (value_slice): Check for not allocated or not
6968         associated values.
6969
6970 2019-06-10  Tom de Vries  <tdevries@suse.de>
6971
6972         PR gdb/24618
6973         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6974         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6975         invalid.
6976
6977 2019-06-10  Tom de Vries  <tdevries@suse.de>
6978
6979         PR gdb/24611
6980         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6981         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6982
6983 2019-06-10  Tom de Vries  <tdevries@suse.de>
6984
6985         PR symtab/24545
6986         * symtab.c (struct demangled_name_entry): Add language field.
6987         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6988         static minimal symbol".  Set and use language field.
6989
6990 2019-06-10  Tom Tromey  <tromey@adacore.com>
6991
6992         * ada-lang.c (_initialize_ada_language): Update help text.
6993
6994 2019-06-10  Tom Tromey  <tromey@adacore.com>
6995
6996         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6997         with a newline.
6998         * guile/guile.c (handle_boot_error): Don't end warning with a
6999         newline.
7000         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7001         warning with a newline.
7002         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7003         newline.
7004         (s12z_frame_cache): Likewise.
7005         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7006         a newline.
7007         * solib-svr4.c (disable_probes_interface): Don't end warning with
7008         a newline.
7009         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7010         newline.
7011         * python/python.c (do_finish_initialization): Don't end warning
7012         with a newline.
7013
7014 2019-06-10  Tom Tromey  <tom@tromey.com>
7015
7016         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7017         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7018         gdbpy_enter.
7019
7020 2019-06-10  Tom Tromey  <tromey@adacore.com>
7021
7022         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7023         data.
7024         (elf_new_init): Don't call stabsread_new_init.
7025         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7026         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7027         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7028
7029 2019-06-10  Tom de Vries  <tdevries@suse.de>
7030
7031         PR symtab/16264
7032         PR symtab/24517
7033         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7034
7035 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7036
7037         * source.c (find_and_open_source): Also rewrite relative file
7038         names.
7039
7040 2019-04-26  Amos Bird  <amosbird@gmail.com>
7041
7042         * annotate.c (annotate_thread_exited): Add "thread-exited"
7043         annotation.
7044
7045 2019-06-06  Tom Tromey  <tromey@adacore.com>
7046
7047         * maint.h (class scoped_command_stats): Use
7048         DISABLE_COPY_AND_ASSIGN.
7049         <print_time>: New method.
7050         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7051         print_time.
7052         (scoped_command_stats::print_time): New method.
7053
7054 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7055
7056         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7057         instructions of lengths 6 or 8 bytes.
7058
7059 2019-06-04  Pedro Alves  <palves@redhat.com>
7060
7061         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7062
7063         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7064         * breakpoint.c (condition_completer): Likewise.
7065         * cli/cli-dump.c (scan_expression): Likewise.
7066         * common/filestuff.c (mkdir_recursive): Likewise.
7067         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7068         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7069         (gdb_abspath): Likewise.
7070         * compile/compile-cplus-types.c
7071         (compile_cplus_instance::decl_name): Likewise.
7072         * completer.c (complete_explicit_location):
7073         (signal_completer, reg_or_group_completer_1): Likewise.
7074         * cp-support.c (cp_remove_params_if_any): Likewise.
7075         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7076         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7077         * infcmd.c (strip_bg_char): Likewise.
7078         * linespec.c (copy_token_string): Likewise.
7079         * mi/mi-main.c (output_cores): Likewise.
7080         * psymtab.c (psymtab_search_name):
7081         * symfile.c (test_set_ext_lang_command): Likewise.
7082         * target.c (target_fileio_read_stralloc): Likewise.
7083         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7084         * value.c (complete_internalvar): Likewise.
7085
7086 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7087
7088         Add objfile property to gdb.Type.
7089         * NEWS: Mention Python API addition.
7090         * python/py-type.c (typy_get_objfile): New method.
7091
7092 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7093
7094         * NEWS: Mention the new set|show style [title|highlight].
7095         Mention changes to "show style", "help" and "apropos".
7096
7097 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7098
7099         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7100         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7101         instead of print_help_for_command.
7102         (print_doc_of_command): New function.
7103         (help_list): Add 'apropos -v word' suggestion.
7104         (print_help_for_command): Style the command name using title style.
7105         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7106         (_initialize_cli_cmds): Describe -v in apropos_command help.
7107
7108 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7109
7110         * cli/cli-style.h (cli_style_option): Add name in constructor,
7111         add m_name class member, add constructor with intensity,
7112         add name class function.
7113         (cli_style_option::add_setshow_commands): Remove name argument.
7114         (highlight_style, title_style): New styles.
7115         * cli/cli-style.c (do_show): New function that shows a style
7116         characteristic styling the style name with itself.
7117         (set_style_name): New function.
7118         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7119         Update all callers according to the changes in cli/cli-style.h.
7120         * utils.h (fputs_highlighted): New function.
7121         * utils.c (fputs_highlighted): Likewise.
7122
7123 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7124
7125         * NEWS: Mention new pipe command and new convenience variables.
7126
7127 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7128
7129         * cli/cli-cmds.c (pipe_command): New function.
7130         (_initialize_cli_cmds): Call add_com for pipe_command.
7131         Define | as an alias for pipe.
7132         (exit_status_set_internal_vars): New function.
7133         (shell_escape): Call exit_status_set_internal_vars.
7134         cli/cli-decode.c (find_command_name_length): Recognize | as
7135         a single character command.
7136
7137 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7138
7139         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7140         top.c (execute_command_to_ui_file): New function, mostly a copy
7141         of execute_command_to_string.
7142         (execute_command_to_string): Implement by calling
7143         execute_command_to_ui_file.
7144
7145 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7146
7147         * top.h (saved_command_line): Remove declaration.
7148         * top.c (previous_saved_command_line, previous_repeat_arguments):
7149         New variables.
7150         (saved_command_line): Make static, define together with other
7151         'repeat variables'.
7152         (dont_repeat): Clear repeat_arguments.
7153         (repeat_previous, get_saved_command_line, save_command_line):
7154         New functions.
7155         (gdb_init): Initialize saved_command_line
7156         and previous_saved_command_line.
7157         * main.c (captured_main_1): Remove saved_command_line initialization.
7158         * event-top.c (handle_line_of_input): Update to use
7159         the new 'repeat' related functions instead of direct access to
7160         saved_command_line.
7161         * command.h (repeat_previous, get_saved_command_line,
7162         save_command_line): New declarations.
7163         (dont_repeat): Add comment.
7164
7165 2019-05-30  Tom Tromey  <tromey@adacore.com>
7166
7167         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7168         Fix comment.
7169         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7170
7171 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7172
7173         PR cli/24587
7174         * completer.c (complete): Initialize variable word.
7175
7176 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7177
7178         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7179         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7180         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7181         'body' is NULL to the outter 'if', protecting the '!is_define'
7182         situation as well.
7183
7184 2019-05-29  Tom Tromey  <tromey@adacore.com>
7185
7186         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7187         (dwarf_unknown): New function.
7188         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7189         (dwarf_type_encoding_name): Use dwarf_unknown.
7190
7191 2019-05-29  Tom Tromey  <tromey@adacore.com>
7192
7193         PR c++/20020:
7194         * cp-valprint.c (cp_print_value_fields): Call
7195         cp_print_static_field inside "try".
7196
7197 2019-05-29  Tom Tromey  <tromey@adacore.com>
7198
7199         * inflow.c (struct terminal_info): Add default operator=.
7200         * configure: Rebuild.
7201         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7202         -Wdeprecated-copy-dtor, -Wredundant-move.
7203
7204 2019-05-29  Tom Tromey  <tromey@adacore.com>
7205
7206         * NEWS: Add entry.
7207         * infcmd.c (print_return_value_1): Handle finish_print
7208         option.
7209         (show_print_finish): New function.
7210         (_initialize_infcmd): Add "set/show print finish" commands.
7211         * valprint.c (user_print_options): Initialize new member.
7212         * valprint.h (struct value_print_options) <finish_print>: New
7213         member.
7214
7215 2019-05-28  Tom Tromey  <tromey@adacore.com>
7216
7217         * ada-lang.c (ada_remove_Xbn_suffix)
7218         (find_old_style_renaming_symbol)
7219         (parse_old_style_renaming): Remove.
7220         (ada_find_renaming_symbol): Don't call
7221         find_old_style_renaming_symbol.
7222         (ada_is_renaming_symbol): Rename from
7223         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7224         bool.  Now static.
7225         (ada_read_var_value): Update and simplify.
7226         * ada-exp.y (write_var_or_type): Remove old code.
7227
7228 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7229
7230         PR gdb/25010
7231         * event-top.c: Remove include comment.
7232         * inflow.c (class scoped_ignore_sigttou): Move from here...
7233         * inflow.h (class scoped_ignore_sigttou): ...to here.
7234         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7235         * top.c:  Remove include comment.
7236
7237 2019-05-27  Tom Tromey  <tom@tromey.com>
7238
7239         * NEWS: Fix typo.
7240
7241 2019-05-22  Tom Tromey  <tromey@adacore.com>
7242
7243         * target.c (target_follow_exec): Constify parameter.
7244         * target-delegates.c: Rebuild.
7245         * remote.c (remote_target::follow_exec): Constify parameter.
7246         * infrun.c (follow_exec): Constify parameter.
7247         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7248         (target_follow_exec): Likewise.
7249
7250 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7251
7252         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7253         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7254
7255 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7256
7257         * NEWS: Add debugredirect and testsuite sections.
7258
7259 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7260
7261         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7262         target descriptions using exclusively floating point register name
7263         aliases.
7264
7265 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7266
7267         PR gdb/18644:
7268         * f-lang.c (build_fortran_types): Handle the case where
7269         gdbarch_floatformat_for_type returns a nullptr.
7270
7271 2019-05-21  Tom de Vries  <tdevries@suse.de>
7272
7273         PR cli/24587
7274         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7275
7276 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         PR gdb/18644:
7279         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7280         16-byte floats.
7281         * i386-tdep.c (i386_floatformat_for_type): Use
7282         floatformats_ia64_quad for the 16-byte floating point component
7283         within a fortran 32-byte complex number.
7284
7285 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7286
7287         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7288         delete default constructor.
7289         (find_partial_die): Update to return const struct.
7290         (partial_die_parent_scope): Move variable declaration into scope
7291         of its use and change its type to auto.
7292         (guess_partial_die_structure_name): Likewise.
7293         (partial_die_info::fixup): Likewise.
7294
7295 2019-05-17  Tom Tromey  <tromey@adacore.com>
7296
7297         * source.c (find_and_open_source): Remove cast.
7298
7299 2019-05-17  Tom Tromey  <tromey@adacore.com>
7300
7301         * annotate.c (annotate_source): Make "filename" const.
7302         * annotate.h (annotate_source): Use const.
7303
7304 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7305
7306         * disasm.c (set_disassembler_options): Send errors to stderr.
7307
7308 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7309
7310         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7311         (cli_interp_base::set_logging): Check debug_redirect.
7312         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7313         * cli/cli-logging.c (debug_redirect): Add static variable.
7314         (pop_output_files): Add default param.
7315         (handle_redirections): Print debug setting.
7316         (show_logging_command): Likewise.
7317         (_initialize_cli_logging): Add debugredirect command.
7318         * interps.c (current_interp_set_logging): Add debug_redirect
7319         parameter.
7320         * interps.h (set_logging): Add debug_redirect parameter.
7321         (current_interp_set_logging): Likewise.
7322         * mi/mi-common.h: Likewise.
7323         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7324
7325 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7326             Tom Tromey  <tromey@adacore.com>
7327
7328         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7329         directly.
7330         * cli/cli-interp.h (make_logging_output): Remove declaration.
7331         * cli/cli-logging.c (make_logging_output): Remove function.
7332         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7333         directly.
7334         * ui-file.c (tee_file::tee_file): Remove bools.
7335         (tee_file::~tee_file): Remove deletes.
7336         * ui-file.h (tee_file): Remove bools.
7337
7338 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7339
7340         * mi/mi-cmds.h (mi_cmd_complete): New function.
7341         * mi/mi-main.c (mi_cmd_complete): Likewise.
7342         * mi/mi-cmds.c: Define new MI command -complete.
7343         * NEWS: Mention new -complete command.
7344
7345 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7346
7347         * completer.h (complete): New function.
7348         * completer.c (complete): Likewise.
7349         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7350         function defined in completer.h.
7351
7352 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7353
7354         * MAINTAINERS (Write After Approval): Add myself.
7355
7356 2019-05-17  Tom de Vries  <tdevries@suse.de>
7357
7358         PR gdb/24094
7359         * dwarf2read.c (struct cu_partial_die_info): New struct.
7360         (find_partial_die): Return cu_partial_die_info.
7361         (partial_die_parent_scope, guess_partial_die_structure_name)
7362         (partial_die_info::fixup): Handle new return type of find_partial_die.
7363
7364 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7365
7366         PR breakpoints/24541
7367         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7368         "std::string", simplifying the algorithm.
7369
7370 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7371
7372         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7373         (stap_static_probe_ops::get_probes): Likewise.
7374
7375 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7376
7377         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7378         '-')" and "else if".
7379         (stap_parse_single_operand): Join checks for
7380         "gdbarch_stap_parse_special_token_p" and
7381         "gdbarch_stap_parse_special_token" in the same "if" statement.
7382         Invert check when verifying for operation on register
7383         displacement.
7384
7385 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7386
7387         * stap-probe.c (stap_get_opcode): Update comment.
7388         (stap_get_expected_argument_type): Likewise.
7389         (handle_stap_probe): Likewise.
7390
7391 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7392
7393         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7394         return type to 'bool'.  Adjust comment.  Use 'bool' when
7395         appropriate.
7396         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7397         * stap-probe.c (stap_parse_argument_1): Likewise.
7398         (stap_is_operator): Likewise.
7399         (stap_is_generic_prefix): Likewise.
7400         (stap_is_register_prefix): Likewise.
7401         (stap_is_register_indirection_prefix): Likewise.
7402         (stap_is_integer_prefix): Likewise.
7403         (stap_generic_check_suffix): Likewise.
7404         (stap_check_integer_suffix): Likewise.
7405         (stap_check_register_suffix): Likewise.
7406         (stap_check_register_indirection_suffix): Likewise.
7407         (stap_parse_register_operand): Likewise.
7408         (stap_parse_single_operand): Likewise.
7409         (stap_parse_argument_1): Likewise.
7410         (stap_probe::get_argument_count): Likewise.
7411         (stap_is_operator): Likewise.
7412
7413 2019-05-16  Tom Tromey  <tromey@adacore.com>
7414
7415         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7416         keyword to foreach.
7417
7418 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7419
7420         * linux-thread-db.c (try_thread_db_load_1): Change return type
7421         to bool.
7422         (try_thread_db_load): Likewise.
7423         (try_thread_db_load_from_pdir_1): Likewise.
7424         (try_thread_db_load_from_pdir): Likewise.
7425         (try_thread_db_load_from_sdir): Likewise.
7426         (try_thread_db_load_from_dir): Likewise.
7427         (thread_db_load_search): Likewise.
7428         (has_libpthread): Likewise.
7429         (thread_db_load): Likewise.
7430
7431 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7432
7433         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7434         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7435         NULL, and complain/return if that's the case.
7436
7437 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7438
7439         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7440         (advance, posn, abstract_read_memory): New functions.
7441         [struct mem_read_abstraction]: New struct.
7442         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7443
7444 2019-05-14  Tom Tromey  <tromey@adacore.com>
7445
7446         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7447         value is not lval_memory.
7448
7449 2019-05-14  Tom Tromey  <tromey@adacore.com>
7450
7451         * solib.c (info_sharedlibrary_command): Style the file name.
7452
7453 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7454
7455         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7456         (aarch64_vnv_type): Likewise.
7457         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7458         * common/tdesc.c: Likewise.
7459         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7460         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7461         * features/aarch64-fpu.xml: Add ieee half view.
7462         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7463         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7464         * gdbtypes.h (struct builtin_type): Likewise.
7465         (struct objfile_type): Likewise.
7466
7467 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7468
7469         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7470         typo.
7471         * location.h (string_to_event_location): Likewise.
7472
7473 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7474
7475         GDB 8.3 released.
7476
7477 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7478
7479         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7480         New variable declaration.
7481         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7482         New variable.
7483         (print_one_breakpoint): Use ui_out::test_flags and new global
7484         variable to compute use_fixed_output.
7485         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7486         Remove.
7487         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7488         (mi_multi_location_breakpoint_output_fixed): Remove.
7489         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7490         new variable.
7491         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7492         fix_multi_location_breakpoint_output flag if version >= 3.
7493         * ui-out.h (enum ui_out_flag)
7494         <fix_multi_location_breakpoint_output>: New enumerator.
7495
7496 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7497
7498         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7499
7500 2019-05-10  Tom Tromey  <tromey@adacore.com>
7501
7502         * ada-lang.c (catch_ada_completer): New function.
7503         (_initialize_ada_language): Use it.
7504
7505 2019-05-10  Tom Tromey  <tromey@adacore.com>
7506
7507         * thread.c (print_thread_info): Make "requested_threads" const.
7508         * gdbthread.h (print_thread_info): Make "requested_threads"
7509         const.
7510         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7511         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7512
7513 2019-05-08  Tom Tromey  <tom@tromey.com>
7514
7515         * gdbtypes.c (objfile_type_data): Change type.
7516         (objfile_type, _initialize_gdbtypes): Update.
7517
7518 2019-05-08  Tom Tromey  <tom@tromey.com>
7519
7520         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7521         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7522         (_initialize_dwarf2_frame): Update.
7523
7524 2019-05-08  Tom Tromey  <tom@tromey.com>
7525
7526         * objc-lang.c (objc_objfile_data): Change type.
7527         (find_methods): Update.
7528         (_initialize_objc_lang): Remove.
7529
7530 2019-05-08  Tom Tromey  <tom@tromey.com>
7531
7532         * stabsread.c (rs6000_builtin_type_data): Change type.
7533         (rs6000_builtin_type, _initialize_stabsread): Update.
7534
7535 2019-05-08  Tom Tromey  <tom@tromey.com>
7536
7537         * mips-tdep.c (mips_pdr_data): Remove.
7538         (_initialize_mips_tdep): Update.
7539
7540 2019-05-08  Tom Tromey  <tom@tromey.com>
7541
7542         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7543         (hppa_init_objfile_priv_data, read_unwind_info)
7544         (find_unwind_entry, _initialize_hppa_tdep): Update.
7545
7546 2019-05-08  Tom Tromey  <tom@tromey.com>
7547
7548         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7549         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7550         on obstack.
7551         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7552
7553 2019-05-08  Tom Tromey  <tom@tromey.com>
7554
7555         * mdebugread.c (basic_type_data): Change type.
7556         (basic_type, _initialize_mdebugread): Update.
7557
7558 2019-05-08  Tom Tromey  <tom@tromey.com>
7559
7560         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7561
7562 2019-05-08  Tom Tromey  <tom@tromey.com>
7563
7564         * nto-tdep.c (nto_inferior_data_reg): Change type.
7565         (nto_inferior_data): Update.
7566         (nto_inferior_data_cleanup, nto_new_inferior_data)
7567         (_initialize_nto_tdep): Remove.
7568         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7569
7570 2019-05-08  Tom Tromey  <tom@tromey.com>
7571
7572         * ada-lang.c (struct ada_inferior_data): Add initializers.
7573         (ada_inferior_data): Change type.
7574         (ada_inferior_data_cleanup): Remove.
7575         (get_ada_inferior_data, ada_inferior_exit)
7576         (struct ada_pspace_data): Add initializers, destructor.
7577         (ada_pspace_data_handle): Change type.
7578         (get_ada_pspace_data): Update.
7579         (ada_pspace_data_cleanup): Remove.
7580
7581 2019-05-08  Tom Tromey  <tom@tromey.com>
7582
7583         * coffread.c (struct coff_symfile_info): Add initializers.
7584         (coff_objfile_data_key): Move lower.  Change type.
7585         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7586         Update.
7587         (coff_free_info): Remove.
7588
7589 2019-05-08  Tom Tromey  <tom@tromey.com>
7590
7591         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7592         (fbsd_pspace_data_handle): Move lower.  Change type.
7593         (get_fbsd_pspace_data): Update.
7594         (fbsd_pspace_data_cleanup): Remove.
7595         (_initialize_fbsd_tdep): Update.
7596
7597 2019-05-08  Tom Tromey  <tom@tromey.com>
7598
7599         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7600         (get_ada_tasks_pspace_data): Update.
7601         (ada_tasks_pspace_data_cleanup): Remove.
7602         (_initialize_tasks): Update.
7603         (ada_tasks_inferior_data_handle): Change type.
7604         (get_ada_tasks_inferior_data): Update.
7605         (ada_tasks_inferior_data_cleanup): Remove.
7606         (struct ada_tasks_pspace_data): Add initializers.
7607
7608 2019-05-08  Tom Tromey  <tom@tromey.com>
7609
7610         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7611         * symfile-debug.c (debug_sym_get_probes): Change type.
7612         * stap-probe.c (handle_stap_probe):
7613         (stap_static_probe_ops::get_probes): Change type.
7614         * probe.h (class static_probe_ops) <get_probes>: Change type.
7615         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7616         (parse_probes_in_pspace): Update.
7617         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7618         Update.
7619         (any_static_probe_ops::get_probes): Change type.
7620         * elfread.c (elfread_data): New typedef.
7621         (probe_key): Change type.
7622         (elf_get_probes): Likewise.  Update.
7623         (probe_key_free): Remove.
7624         (_initialize_elfread): Update.
7625         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7626         Change type.
7627         (dtrace_process_dof_probe, dtrace_process_dof)
7628         (dtrace_static_probe_ops::get_probe): Change type.
7629
7630 2019-05-08  Tom Tromey  <tom@tromey.com>
7631
7632         * xcoffread.c (struct xcoff_symfile_info): Rename from
7633         coff_symfile_info.  Add initializers.
7634         (xcoff_objfile_data_key): Move lower.  Change type.
7635         (XCOFF_DATA): Rewrite.
7636         (xcoff_free_info): Remove.
7637         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7638         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7639         (xcoff_initial_scan): Update.
7640
7641 2019-05-08  Tom Tromey  <tom@tromey.com>
7642
7643         * solib-svr4.c (struct svr4_info): Add initializers and
7644         destructor.
7645         <probes_table>: Now an htab_up.
7646         (solib_svr4_pspace_data): Change type.
7647         (free_probes_table): Simplify.
7648         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7649         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7650         (probes_table_remove_objfile_probes, register_solib_event_probe)
7651         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7652         (_initialize_svr4_solib): Update.
7653
7654 2019-05-08  Tom Tromey  <tom@tromey.com>
7655
7656         * remote.c (remote_pspace_data): Change type.
7657         (remote_pspace_data_cleanup): Remove.
7658         (get_remote_exec_file, set_pspace_remote_exec_file)
7659         (_initialize_remote): Update.
7660
7661 2019-05-08  Tom Tromey  <tom@tromey.com>
7662
7663         * breakpoint.c (breakpoint_objfile_key): Change type.
7664         (get_breakpoint_objfile_data): Update.
7665         (free_breakpoint_objfile_data): Remove.
7666         (_initialize_breakpoint): Update.
7667
7668 2019-05-08  Tom Tromey  <tom@tromey.com>
7669
7670         * linux-tdep.c (struct linux_info): Add initializers.
7671         (linux_inferior_data): Move.  Change type.
7672         (invalidate_linux_cache_inf): Update.
7673         (linux_inferior_data_cleanup): Remove.
7674         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7675
7676 2019-05-08  Tom Tromey  <tom@tromey.com>
7677
7678         * auxv.c (auxv_inferior_data): Move.  Change type.
7679         (auxv_inferior_data_cleanup): Remove.
7680         (invalidate_auxv_cache_inf): Rewrite.
7681         (get_auxv_inferior_data, _initialize_auxv): Update.
7682
7683 2019-05-08  Tom Tromey  <tom@tromey.com>
7684
7685         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7686         (symfile_debug_objfile_data_key): Change type.
7687         (symfile_debug_installed, debug_qf_has_symbols)
7688         (debug_qf_find_last_source_symtab)
7689         (debug_qf_forget_cached_source_info)
7690         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7691         (debug_qf_print_stats, debug_qf_dump)
7692         (debug_qf_expand_symtabs_for_function)
7693         (debug_qf_expand_all_symtabs)
7694         (debug_qf_expand_symtabs_with_fullname)
7695         (debug_qf_map_matching_symbols)
7696         (debug_qf_expand_symtabs_matching)
7697         (debug_qf_find_pc_sect_compunit_symtab)
7698         (debug_qf_map_symbol_filenames)
7699         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7700         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7701         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7702         (debug_sym_read_linetable, debug_sym_relocate): Update.
7703         (symfile_debug_free_objfile): Remove.
7704         (install_symfile_debug_logging, _initialize_symfile_debug):
7705         Update.
7706
7707 2019-05-08  Tom Tromey  <tom@tromey.com>
7708
7709         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7710         allocate_on_obstack.
7711         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7712         (get_dwarf2_per_objfile): Update.
7713         (set_dwarf2_per_objfile): Remove.
7714         (dwarf2_has_info, dwarf2_get_section_info): Update.
7715         (dwarf2_free_objfile): Remove.
7716         (_initialize_dwarf2_read): Update.
7717
7718 2019-05-08  Tom Tromey  <tom@tromey.com>
7719
7720         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7721         initializers.
7722         <unsupported_script_warning_printed,
7723         script_not_found_warning_printed>: Now bool.
7724         (auto_load_pspace_data): Change type.
7725         (~auto_load_pspace_info): Rename from
7726         auto_load_pspace_data_cleanup.
7727         (get_auto_load_pspace_data, init_loaded_scripts_info)
7728         (clear_section_scripts, maybe_print_unsupported_script_warning)
7729         (maybe_print_script_not_found_warning, _initialize_auto_load):
7730         Update.
7731
7732 2019-05-08  Tom Tromey  <tom@tromey.com>
7733
7734         * objfiles.c (objfile_pspace_info): Add destructor and
7735         initializers.
7736         (objfiles_pspace_data): Change type.
7737         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7738         (get_objfile_pspace_data): Update.
7739         (objfiles_bfd_data): Change type.
7740         (get_objfile_bfd_data): Update.
7741         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7742
7743 2019-05-08  Tom Tromey  <tom@tromey.com>
7744
7745         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7746         Change type.
7747         (get_catch_syscall_inferior_data): Update.
7748         (catch_syscall_inferior_data_cleanup): Remove.
7749         (_initialize_break_catch_syscall): Update.
7750
7751 2019-05-08  Tom Tromey  <tom@tromey.com>
7752
7753         * inflow.c (struct terminal_info): Add destructor and
7754         initializers.
7755         (inflow_inferior_data): Change type.
7756         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7757         (get_inflow_inferior_data, inflow_inferior_exit)
7758         (swap_terminal_info, _initialize_inflow): Update.
7759
7760 2019-05-08  Tom Tromey  <tom@tromey.com>
7761
7762         * target-dcache.c (target_dcache_cleanup): Remove.
7763         (target_dcache_aspace_key): Change type.
7764         (target_dcache_init_p, target_dcache_invalidate)
7765         (target_dcache_get, target_dcache_get_or_init)
7766         (_initialize_target_dcache): Update.
7767         * dcache.h (struct dcache_deleter): New.
7768
7769 2019-05-08  Tom Tromey  <tom@tromey.com>
7770
7771         * symtab.c (struct symbol_cache): Add destructor and
7772         initializers.
7773         (symbol_cache_key): Move.  Change type.
7774         (make_symbol_cache, free_symbol_cache): Remove.
7775         (get_symbol_cache): Update.
7776         (symbol_cache_cleanup): Remove.
7777         (ALL_PSPACES, symbol_cache_flush)
7778         (maintenance_print_symbol_cache)
7779         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7780         Update.
7781
7782 2019-05-08  Tom Tromey  <tom@tromey.com>
7783
7784         * symtab.c (struct main_info): Add destructor and initializers.
7785         (main_progspace_key): Move.  Change type.
7786         (get_main_info): Update.
7787         (main_info_cleanup): Remove.
7788         (_initialize_symtab): Update.
7789
7790 2019-05-08  Tom Tromey  <tom@tromey.com>
7791
7792         * registry.h (DECLARE_REGISTRY): Define the _key class.
7793
7794 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * NEWS: Merge two 'New commands' sections.
7797
7798 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7799
7800         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7801         parameter and use Ada language definition instead.
7802         (ada_val_print_ptr): Remove unused language parameter.
7803         (ada_val_print_num): Remove language parameter and use Ada language
7804         definition instead.
7805         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7806         parameter.
7807         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7808         parameter and use Ada language definition instead.
7809         (ada_val_print_1): Update all ada_val_print_xxx calls.
7810         Remove language parameter.
7811         (ada_val_print): Update ada_val_print_1 call.
7812
7813 2019-05-08  Tom Tromey  <tromey@adacore.com>
7814
7815         * remote.c (remote_hw_watchpoint_limit)
7816         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7817         Now static.
7818
7819 2019-05-08  Tom Tromey  <tromey@adacore.com>
7820
7821         * maint.c (_initialize_maint_cmds): Move initialization code to
7822         remote.c.
7823         (watchdog, show_watchdog): Move to remote.c.
7824         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7825         "watchdog" static.
7826         (_initialize_remote): Move initialization code from maint.c.
7827         * defs.h (watchdog): Don't declare.
7828
7829 2019-05-08  Tom Tromey  <tromey@adacore.com>
7830
7831         * tui/tui-interp.c: Include main.h.
7832         * interps.c: Include main.h.
7833         * main.h (interpreter_p): Declare.
7834         * defs.h (interpreter_p): Don't declare.
7835
7836 2019-05-08  Tom Tromey  <tromey@adacore.com>
7837
7838         * dwarf2loc.c: Include dwarf2read.h.
7839         * defs.h (read_unsigned_leb128): Don't declare.
7840         * dwarf2read.h (read_unsigned_leb128): Declare.
7841
7842 2019-05-08  Tom Tromey  <tromey@adacore.com>
7843
7844         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7845         method.
7846
7847 2019-05-08  Tom Tromey  <tromey@adacore.com>
7848
7849         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7850         when no wrap column is set.
7851
7852 2019-05-08  Tom Tromey  <tromey@adacore.com>
7853
7854         * c-lang.c (c_get_string): Handle non-C-style arrays.
7855
7856 2019-05-08  Tom Tromey  <tromey@adacore.com>
7857
7858         * typeprint.c (print_offset_data::update): Print the bit offset,
7859         not the number of bits remaining.
7860
7861 2019-05-08  Tom Tromey  <tromey@adacore.com>
7862
7863         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7864         padding at end of comment.
7865
7866 2019-05-08  Tom Tromey  <tromey@adacore.com>
7867
7868         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7869         Compare main types.
7870
7871 2019-05-06  Tom Tromey  <tom@tromey.com>
7872
7873         * common/scoped_mmap.c: Include common-defs.h.
7874         * common/scoped_mmap.h: Don't include config.h.
7875
7876 2019-05-04  Tom Tromey  <tom@tromey.com>
7877
7878         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7879         (struct aarch64_call_info): Add initializers.
7880         <si>: Now a std::vector.
7881         (pass_on_stack, aarch64_push_dummy_call): Update.
7882
7883 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7884             Tom Tromey  <tom@tromey.com>
7885
7886         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7887         (ppc_threads): Now a std::vector.  Now static.
7888         (hwdebug_find_thread_points_by_tid)
7889         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7890         Update.
7891
7892 2019-05-04  Tom Tromey  <tom@tromey.com>
7893
7894         * arc-tdep.c (arc_tdesc_init): Return bool.
7895
7896 2019-05-04  Tom Tromey  <tom@tromey.com>
7897
7898         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7899         Use gdb_assert_not_reached.
7900
7901 2019-05-04  Tom Tromey  <tom@tromey.com>
7902
7903         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7904         "false".
7905
7906 2019-05-04  Tom Tromey  <tom@tromey.com>
7907
7908         * arc-tdep.c (arc_tdesc_init): Use bool.
7909
7910 2019-05-04  Tom Tromey  <tom@tromey.com>
7911
7912         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7913
7914 2019-05-04  Tom Tromey  <tom@tromey.com>
7915
7916         * cli/cli-cmds.c (valid_command_p): Return bool.
7917
7918 2019-05-04  Tom Tromey  <tom@tromey.com>
7919
7920         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7921         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7922
7923 2019-05-04  Raul Tambre  <raul@tambre.ee>
7924
7925         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7926         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7927         operator for comparison.
7928
7929 2019-05-04  Tom Tromey  <tom@tromey.com>
7930
7931         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7932         (lookup_partial_symbol, print_partial_symbols)
7933         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7934         (psymbol_compare): Update.
7935         (add_psymbol_to_bcache): Clear the entire psymbol.
7936         (maintenance_check_psymtabs): Update.
7937         * psympriv.h (struct partial_symbol): Don't derive from
7938         general_symbol_info.
7939         <obj_section, unrelocated_address, address,
7940         set_unrelocated_address>: Update.
7941         <ginfo>: New member.
7942         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7943         (debug_names::write_psymbols): Update.
7944
7945 2019-05-04  Tom de Vries  <tdevries@suse.de>
7946
7947         * contrib/cc-with-tweaks.sh: Support -n arg.
7948
7949 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7950
7951         * corelow.c (core_target::detach): Ensure frame cache and
7952         register caches are cleared.
7953         inferior.c (exit_inferior_1): Likewise.
7954
7955 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7956             Tom Tromey  <tom@tromey.com>
7957
7958         * dictionary.c (collate_pending_symbols_by_language): Remove
7959         "struct" from foreach.
7960         * symtab.c (lookup_global_symbol_from_objfile)
7961         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7962         foreach.
7963         * ser-tcp.c (net_open): Remove "struct" from foreach.
7964         * objfiles.c (objfile_relocate, objfile_rebase)
7965         (objfile_has_symbols): Remove "struct" from foreach.
7966         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7967         from foreach.
7968         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7969         foreach.
7970         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7971         "struct" from foreach.
7972         * ada-lang.c (create_excep_cond_exprs)
7973         (ada_exception_catchpoint_cond_string): Remove "struct" from
7974         foreach.
7975
7976 2019-05-03  Tom Tromey  <tromey@adacore.com>
7977
7978         * ada-exp.y (convert_char_literal): Check suffix of each
7979         enumerator.
7980
7981 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7982
7983         PR ada/21406:
7984         * ada-exp.y (yywrap): Don't define.
7985         * ada-lex.l (%option): Add noyywrap
7986         (yywrap): Remove.
7987
7988 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7989
7990         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7991         _WIN32_WINNT to the XP level, unless already defined to a higher
7992         level.
7993
7994         * unittests/parse-connection-spec-selftests.c:
7995         * ser-tcp.c:
7996         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7997         override.
7998
7999         * symfile.c (find_separate_debug_file): Remove colon from the
8000         drive spec of DOS/Windows file names of the target, so that the
8001         file name produced from DEBUGDIR and the target's directory will
8002         be valid on DOS/Windows systems.
8003
8004 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8005
8006         * rust-lang.c (val_print_struct): Handle printing structures
8007         containing strings.
8008
8009 2019-05-02  Tom Tromey  <tromey@adacore.com>
8010
8011         * valarith.c (_initialize_valarith): Remove.
8012
8013 2019-05-01  Tom Tromey  <tromey@adacore.com>
8014
8015         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8016         bitfields.
8017
8018 2019-05-01  Tom Tromey  <tromey@adacore.com>
8019
8020         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8021         for big-endian copies.
8022
8023 2019-04-30  Ali Tamur  <tamur@google.com>
8024         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8025         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8026         (read_3_bytes): New function.
8027
8028 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8029
8030         * windows-nat.c (main_thread_id): Delete.
8031         (handle_output_debug_string): Replace main_thread_id by
8032         current_event.dwThreadId.
8033         (fake_create_process): Likewise.
8034         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8035         Do not set main_thread_id.
8036         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8037         current_event.dwThreadId.
8038         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8039
8040 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8041
8042         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8043         Use current_event.dwThreadId instead of main_thread_id.
8044
8045 2019-04-30  Tom Tromey  <tromey@adacore.com>
8046
8047         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8048         (create_excep_cond_exprs): Iterate over program spaces.
8049         (ada_exception_catchpoint_cond_string): Examine all minimal
8050         symbols for exception types.
8051
8052 2019-04-30  Tom Tromey  <tromey@adacore.com>
8053
8054         PR c++/24470:
8055         * dwarf2read.c (process_structure_scope): Handle case where type
8056         has template parameters but no symbol was created.
8057
8058 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8059             Chris January  <chris.january@arm.com>
8060
8061         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8062         qualifier.
8063         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8064
8065 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8066
8067         * f-typeprint.c (f_print_type): Update rules for printing
8068         whitespace.
8069         (f_type_print_varspec_suffix): Likewise.
8070
8071 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8072             Chris January  <chris.january@arm.com>
8073
8074         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8075         function arguments.
8076
8077 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8078
8079         * f-lang.c (build_fortran_types): Change name of void type to
8080         lower case.
8081         * f-typeprint.c (f_type_print_base): Print the name of the void
8082         type, rather than a fixed string.
8083         * f-valprint.c (f_decorations): Use lower case void string.
8084
8085 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8086             Chris January  <chris.january@arm.com>
8087
8088         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8089         types for Fortran.
8090
8091 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8092             Chris January  <chris.january@arm.com>
8093             David Lecomber  <david.lecomber@arm.com>
8094
8095         * f-exp.y (BINOP_INTRINSIC): New token.
8096         (exp): New parser rule handling BINOP_INTRINSIC.
8097         (f77_keywords): Add new builtin procedures.
8098         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8099         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8100         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8101         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8102         (print_unop_subexp_f): New function.
8103         (print_binop_subexp_f): New function.
8104         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8105         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8106         (dump_subexp_body_f): Likewise.
8107         (operator_check_f): Likewise.
8108         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8109         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8110
8111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8112
8113         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8114         UNOP_KIND.
8115         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8116         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8117         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8118         (operator_length_f): New fuction.
8119         (print_subexp_f): New function.
8120         (op_name_f): New function.
8121         (dump_subexp_body_f): New function.
8122         (operator_check_f): New function.
8123         (exp_descriptor_f): Replace standard expression handling functions
8124         with new functions.
8125         * gdb/fortran-operator.def: New file.
8126         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8127         * gdb/std-operator.def: Remove UNOP_KIND.
8128
8129 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8130
8131         * std-operator.def: Remove unbalanced, stray double quote
8132         character.
8133
8134 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8135             Chris January  <chris.january@arm.com>
8136             Daniel Everett  <daniel.everett@arm.com>
8137             Nick Forrington  <nick.forrington@arm.com>
8138             Richard Bunt  <richard.bunt@arm.com>
8139
8140         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8141         of depth when printing anonymous structs or unions.
8142         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8143         Don't print either the top-level value, or the children if the
8144         max-depth is exceeded.
8145         (ppscm_print_children): When printing the key of a map, allow one
8146         extra level of depth.
8147         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8148         print either the top-level value, or the children if the max-depth
8149         is exceeded.
8150         (print_children): When printing the key of a map, allow one extra
8151         level of depth.
8152         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8153         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8154         (user_print_options): Initialise max_depth field.
8155         (val_print_scalar_or_string_type_p): New function.
8156         (val_print): Check to see if the max depth has been reached.
8157         (val_print_check_max_depth): Define new function.
8158         (show_print_max_depth): New function.
8159         (_initialize_valprint): Add 'print max-depth' option.
8160         * valprint.h (struct value_print_options) <max_depth>: New field.
8161         (val_print_check_max_depth): Declare new function.
8162         * NEWS: Document new feature.
8163
8164 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * ada-lang.c (ada_language_defn): Initialise new field.
8167         * c-lang.c (c_is_string_type_p): New function.
8168         (c_language_defn): Initialise new field.
8169         (cplus_language_defn): Initialise new field.
8170         (asm_language_defn): Initialise new field.
8171         (minimal_language_defn): Initialise new field.
8172         * c-lang.h (c_is_string_type_p): Declare new function.
8173         * d-lang.c (d_language_defn): Initialise new field.
8174         * f-lang.c (f_is_string_type_p): New function.
8175         (f_language_defn): Initialise new field.
8176         * go-lang.c (go_is_string_type_p): New function.
8177         (go_language_defn): Initialise new field.
8178         * language.c (default_is_string_type_p): New function.
8179         (unknown_language_defn): Initialise new field.
8180         (auto_language_defn): Initialise new field.
8181         * language.h (struct language_defn) <la_is_string_type_p>: New
8182         member variable.
8183         (default_is_string_type_p): Declare new function.
8184         * m2-lang.c (m2_language_defn): Initialise new field.
8185         * objc-lang.c (objc_language_defn): Initialise new field.
8186         * opencl-lang.c (opencl_language_defn): Initialise new field.
8187         * p-lang.c (pascal_is_string_type_p): New function.
8188         (pascal_language_defn): Initialise new field.
8189         * rust-lang.c (rust_is_string_type_p): New function.
8190         (rust_language_defn): Initialise new field.
8191
8192 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8193
8194         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8195         New field.
8196         * ada-lang.c (ada_language_defn): Initialise new field.
8197         * c-lang.c (c_language_defn): Likewise.
8198         (cplus_language_defn): Likewise.
8199         (asm_language_defn): Likewise.
8200         (minimal_language_defn): Likewise.
8201         * d-lang.c (d_language_defn): Likewise.
8202         * f-lang.c (f_language_defn): Likewise.
8203         * go-lang.c (go_language_defn): Likewise.
8204         * language.c (unknown_language_defn): Likewise.
8205         (auto_language_defn): Likewise.
8206         * m2-lang.c (m2_language_defn): Likewise.
8207         * objc-lang.c (objc_language_defn): Likewise.
8208         * opencl-lang.c (opencl_language_defn): Likewise.
8209         * p-lang.c (pascal_language_defn): Likewise.
8210         * rust-lang.c (rust_language_defn): Likewise.
8211
8212 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8213
8214         * ada-lang.c (ada_is_character_type): Change return type to bool.
8215         (ada_is_string_type): Likewise.
8216         * ada-lang.h (ada_is_character_type): Update declaration
8217         (ada_is_string_type): Likewise.
8218
8219 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8220
8221         Support style in 'frame|thread apply'
8222
8223         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8224         * record.c (record_start, record_stop): Update callers of
8225         execute_command_to_string with false.
8226         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8227         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8228         methods.
8229         (class string_file): New constructor with term_out parameter.
8230         Override methods term_out and can_emit_style_escape.  New member
8231         term_out.
8232         (class stdio_file): Override can_emit_style_escape.
8233         (class tee_file): Override term_out and can_emit_style_escape.
8234         * utils.h (can_emit_style_escape): Remove.
8235         * utils.c (can_emit_style_escape): Likewise.
8236         Update all callers of can_emit_style_escape (SOMESTREAM) to
8237         SOMESTREAM->can_emit_style_escape.
8238         * source-cache.c (source_cache::get_source_lines): Likewise.
8239         * stack.c (frame_apply_command_count): Call execute_command_to_string
8240         passing the term_out characteristic of the current gdb_stdout.
8241         * thread.c (thr_try_catch_cmd): Likewise.
8242         * top.c (execute_command_to_string): pass term_out parameter
8243         to construct the string_file for the command output.
8244         * ui-file.c (term_cli_styling): New function (most code moved
8245         from utils.c can_emit_style_escape).
8246         (string_file::string_file, string_file::can_emit_style_escape,
8247         stdio_file::can_emit_style_escape, tee_file::term_out,
8248         tee_file::can_emit_style_escape): New functions.
8249
8250 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8251
8252         * NEWS: Mention the new set|show may-call-functions.
8253         * infcall.c (may_call_functions_p): New variable.
8254         (show_may_call_functions_p): New function.
8255         (call_function_by_hand_dummy): Throws an error if not
8256         may-call-functions.
8257         (_initialize_infcall): Call add_setshow_boolean_cmd for
8258         may-call-functions.
8259
8260 2019-04-25  Keith Seitz  <keiths@redhat.com>
8261
8262         PR c++/24367
8263         * cp-support.c (inspect_type): Don't attempt substitutions
8264         of symbol with the same name.
8265
8266 2019-04-25  Tom Tromey  <tromey@adacore.com>
8267
8268         PR gdb/24475:
8269         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8270         static.
8271
8272 2019-04-25  Tom Tromey  <tromey@adacore.com>
8273
8274         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8275         rvalue reference.
8276         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8277         (gdb_xml_parser::parse): Use std::move.
8278         * python/python-internal.h (gdbpy_convert_exception): Take a const
8279         reference.
8280         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8281         std::move.
8282         * python/py-utils.c (gdbpy_convert_exception): Take a const
8283         reference.
8284         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8285         Use std::move.
8286         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8287         Use std::move.
8288         * mi/mi-main.c (mi_print_exception): Take a const reference.
8289         * main.c (handle_command_errors): Take a const reference.
8290         * linespec.c (parse_linespec): Use std::move.
8291         * infcall.c (run_inferior_call): Use std::move.
8292         (call_function_by_hand_dummy): Use std::move.
8293         * exec.c (try_open_exec_file): Use std::move.
8294         * exceptions.h (exception_print, exception_fprintf)
8295         (exception_print_same): Update.
8296         * exceptions.c (print_exception, exception_print)
8297         (exception_fprintf, exception_print_same): Change parameters to
8298         const reference.
8299         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8300         * common/new-op.c: Use std::move.
8301         * common/common-exceptions.h (struct gdb_exception): Add move
8302         constructor.
8303         (struct gdb_exception_error, struct gdb_exception_quit, struct
8304         gdb_quit_bad_alloc): Change constructor to move constructor.
8305         (throw_exception): Change parameter to rvalue reference.
8306         * common/common-exceptions.c (throw_exception): Take rvalue
8307         reference.
8308         * cli/cli-interp.c (safe_execute_command): Use std::move.
8309         * breakpoint.c (insert_bp_location, location_to_sals): Use
8310         std::move.
8311
8312 2019-04-25  Tom Tromey  <tromey@adacore.com>
8313
8314         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8315         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8316         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8317         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8318         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8319         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8320         guile/scm-value.c: Use unpack.
8321         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8322         gdbscm_gdb_exception.
8323         (gdbscm_throw_gdb_exception): Likewise.
8324         (struct gdbscm_gdb_exception): New.
8325         (unpack): New function.
8326         (gdbscm_wrap): Use unpack.
8327
8328 2019-04-25  Tom Tromey  <tromey@adacore.com>
8329
8330         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8331         (gdb_rl_callback_handler): Use std::move.
8332         * common/common-exceptions.h (struct gdb_exception): Add move
8333         assignment operator.
8334         (throw_exception_sjlj): Change "exception" to const reference.
8335         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8336         (throw_exception_sjlj): Change "exception" to const reference.
8337
8338 2019-04-25  Tom Tromey  <tromey@adacore.com>
8339
8340         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8341         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8342         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8343         Update.
8344         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8345         Update.
8346         * mi/mi-interp.c (mi_interp::exec): Update.
8347         * linespec.c (parse_linespec): Update.
8348         * infcall.c (run_inferior_call): Update.
8349         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8350         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8351         (gdbscm_lookup_global_symbol): Update.
8352         * guile/scm-param.c (gdbscm_parameter_value): Update.
8353         * guile/scm-frame.c (gdbscm_frame_read_register)
8354         (gdbscm_frame_read_var): Update.
8355         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8356         * exec.c (try_open_exec_file): Update.
8357         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8358         (gdb_rl_callback_handler): Update.
8359         * common/common-exceptions.h (exception_none): Don't declare.
8360         * common/common-exceptions.c (exception_none): Don't define.
8361         (struct catcher) <exception>: Update.
8362         * cli/cli-interp.c (safe_execute_command): Update.
8363         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8364
8365 2019-04-25  Ali Tamur  <tamur@google.com>
8366
8367         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8368         (read_attribute_value): Likewise.
8369         (dwarf2_read_addr_index): Update comment.
8370         (read_str_index): Add DW_FORM_strx.
8371         (dwarf2_string_attr): Likewise.
8372         (dwarf2_const_value_attr): Likewise.
8373         (dump_die_shallow): Likewise.
8374         (dwarf2_fetch_constant_bytes): Likewise.
8375         (skip_form_bytes): Likewise.
8376         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8377
8378 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8379
8380         PR corefiles/11608
8381         PR corefiles/18187
8382         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8383         OFFSET.  Verify if current mapping contains an ELF header.
8384         (linux_find_memory_regions_full): Adjust call to
8385         dump_mapping_p.
8386
8387 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8388             Kang Li <kanglictf@gmail.com>
8389
8390         PR gdb/21600
8391
8392         * dwarf2-frame.c (read_initial_length): Be consistent about using
8393         unsigned representation of length.
8394         (decode_frame_entry_1): Likewise.  Check for wraparound of
8395         end pointer as well as buffer overflow.
8396
8397 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8398
8399         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8400         "vq".
8401
8402 2019-04-24  Tom Tromey  <tromey@adacore.com>
8403
8404         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8405
8406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8407
8408         * s12z-tdep.c (s12z_unwind_pc): Delete.
8409         (s12z_unwind_sp): Delete.
8410         (s12z_gdbarch_init): Don't register deleted functions with
8411         gdbarch.
8412
8413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8414
8415         * rl78-tdep.c (rl78_unwind_sp): Delete.
8416         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8417
8418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8419
8420         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8421         (xstormy16_unwind_pc): Delete.
8422         (xstormy16_dummy_id): Delete.
8423         (xstormy16_gdbarch_init): Don't register deleted functions with
8424         gdbarch.
8425
8426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8427
8428         * vax-tdep.c (vax_unwind_pc): Delete.
8429         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8430
8431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8432
8433         * v850-tdep.c (v850_unwind_sp): Delete.
8434         (v850_unwind_pc): Delete.
8435         (v850_dummy_id): Delete.
8436         (v850_gdbarch_init): Don't register deleted functions with
8437         gdbarch.
8438
8439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8440
8441         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8442         (tilegx_unwind_pc): Delete.
8443         (tilegx_unwind_dummy_id): Delete.
8444         (tilegx_gdbarch_init): Don't register deleted functions with
8445         gdbarch.
8446
8447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8448
8449         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8450         (tic6x_dummy_id): Delete.
8451         (tic6x_gdbarch_init): Don't register deleted functions with
8452         gdbarch.
8453
8454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8455
8456         * sparc-tdep.c (sparc_unwind_pc): Delete.
8457         (sparc32_gdbarch_init): Don't register deleted function with
8458         gdbarch.
8459
8460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8461
8462         * sh-tdep.c (sh_unwind_sp): Delete.
8463         (sh_unwind_pc): Delete.
8464         (sh_dummy_id): Delete.
8465         (sh_gdbarch_init): Don't register deleted functions with
8466         gdbarch.
8467
8468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8469
8470         * score-tdep.c (score_unwind_sp): Delete.
8471         (score_unwind_pc): Delete.
8472         (score_dummy_id): Delete.
8473         (score_gdbarch_init): Don't register deleted functions with
8474         gdbarch.
8475
8476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * rx-tdep.c (rx_unwind_pc): Delete.
8479         (rx_unwind_sp): Delete.
8480         (rx_dummy_id): Delete.
8481         (rx_gdbarch_init): Don't register deleted functions with
8482         gdbarch.  Update comment.
8483
8484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8485
8486         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8487         (rs6000_dummy_id): Delete.
8488         (rs6000_gdbarch_init): Don't register deleted functions with
8489         gdbarch.
8490
8491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8492
8493         * or1k-tdep.c (or1k_dummy_id): Delete.
8494         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8495
8496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8497
8498         * nios2-tdep.c (nios2_dummy_id): Delete.
8499         (nios2_unwind_sp): Delete.
8500         (nios2_gdbarch_init): Don't register deleted functions with
8501         gdbarch.
8502
8503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8504
8505         * nds32-tdep.c (nds32_dummy_id): Delete.
8506         (nds32_unwind_pc): Delete.
8507         (nds32_unwind_sp): Delete.
8508         (nds32_gdbarch_init): Don't register deleted functions with
8509         gdbarch.
8510
8511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8512
8513         * msp430-tdep.c (msp430_unwind_pc): Delete.
8514         (msp430_unwind_sp): Delete.
8515         (msp430_dummy_id): Delete.
8516         (msp430_gdbarch_init): Don't register deleted functions with
8517         gdbarch.
8518
8519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8520
8521         * moxie-tdep.c (moxie_unwind_sp): Delete.
8522         (moxie_unwind_pc): Delete.
8523         (moxie_dummy_id): Delete.
8524         (moxie_gdbarch_init): Don't register deleted functions with
8525         gdbarch.
8526
8527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8528
8529         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8530         (mn10300_unwind_pc): Delete.
8531         (mn10300_unwind_sp): Delete.
8532         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8533         mn10300_unwind_sp.
8534         (mn10300_frame_unwind_init): Don't register deleted functions with
8535         gdbarch.
8536
8537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8538
8539         * mep-tdep.c (mep_unwind_pc): Delete.
8540         (mep_unwind_sp): Delete.
8541         (mep_dummy_id): Delete.
8542         (mep_gdbarch_init): Don't register deleted functions with
8543         gdbarch.
8544
8545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8546
8547         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8548         (m68hc11_unwind_sp): Delete.
8549         (m68hc11_gdbarch_init): Don't register deleted functions with
8550         gdbarch.
8551
8552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8553
8554         * m32r-tdep.c (m32r_unwind_sp): Delete.
8555         (m32r_unwind_pc): Delete.
8556         (m32r_dummy_id): Delete.
8557         (m32r_gdbarch_init): Don't register deleted functions with
8558         gdbarch.
8559
8560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8561
8562         * m32c-tdep.c (m32c_unwind_pc): Delete.
8563         (m32c_unwind_sp): Delete.
8564         (m32c_dummy_id): Delete.
8565         (m32c_gdbarch_init): Don't register deleted functions with
8566         gdbarch.
8567
8568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8569
8570         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8571         (lm32_unwind_pc): Delete.
8572         (lm32_dummy_id): Delete.
8573         (lm32_gdbarch_init): Don't register deleted functions with
8574         gdbarch.
8575
8576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8577
8578         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8579         (iq2000_unwind_pc): Delete.
8580         (iq2000_dummy_id): Delete.
8581         (iq2000_gdbarch_init): Don't register deleted functions with
8582         gdbarch.
8583
8584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8585
8586         * nds32-tdep.c (nds32_type_align): Delete.
8587         (nds32_push_dummy_call): Use type_align instead.
8588
8589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8590
8591         * arm-tdep.c (arm_type_align): Only handle vector override case.
8592         (arm_push_dummy_call): Use type_align.
8593         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8594
8595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8596
8597         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8598         case.
8599         (pass_on_stack): Use type_align.
8600         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8601         function.
8602
8603 2019-04-23  Tom Tromey  <tromey@adacore.com>
8604
8605         * dwarf2read.c (line_header::file_name_at): Remove unused
8606         overload.
8607
8608 2019-04-23  Tom de Vries  <tdevries@suse.de>
8609
8610         PR gdb/24438
8611         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8612         invocation.
8613
8614
8615 2019-03-27  Ali Tamur  <tamur@google.com>
8616
8617         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8618         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8619         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8620         (dwarf_expr_context::get_addr_index): Likewise
8621         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8622         (symbol_needs_eval_context::get_addr_index): Likewise
8623         (disassemble_dwarf_expression): Add DW_OP_addrx
8624         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8625         (read_cutu_die_from_dwo): Update comment
8626         (skip_one_die): Add DW_FORM_addrx
8627         (read_attribute_value): Likewise
8628         (var_decode_location): Add DW_OP_addrx
8629         (dwarf2_const_value_attr): Add DW_FORM_addrx
8630         (dump_die_shallow): Likewise
8631         (dwarf2_fetch_constant_bytes): Likewise
8632         (decode_locdesc): Add DW_OP_addrx
8633         (skip_form_bytes): Add DW_FORM_addrx
8634
8635 2019-04-22  Ali Tamur  <tamur@google.com>
8636
8637         * MAINTAINERS (Write After Approval): Add self.
8638
8639 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8640
8641         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8642         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8643         (open_symbol_file_object): Likewise.
8644         (svr4_default_sos): Add info parameter.
8645         (svr4_read_so_list): Likewise.
8646         (svr4_current_sos_direct): Adjust functions calls to pass down
8647         info.
8648         (svr4_current_sos_1): Add info parameter.
8649         (svr4_current_sos): Call get_svr4_info, pass info down to
8650         svr4_current_sos_1.
8651         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8652         get_svr4_info.
8653         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8654         get_svr4_info.
8655         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8656         to get_svr4_info.
8657         (probes_table_remove_objfile_probes): Likewise.
8658         (register_solib_event_probe): Add info parameter.
8659         (solist_update_incremental): Pass info parameter down to
8660         svr4_read_so_list.
8661         (disable_probes_interface): Add info parameter.
8662         (svr4_handle_solib_event): Pass current_program_space to
8663         get_svr4_info.  Adjust disable_probes_interface cleanup.
8664         (svr4_create_probe_breakpoints): Add info parameter, pass it
8665         down to register_solib_event_probe.
8666         (svr4_create_solib_event_breakpoints): Add info parameter,
8667         pass it down to svr4_create_probe_breakpoints.
8668         (enable_break): Pass info down to
8669         svr4_create_solib_event_breakpoints.
8670         (svr4_solib_create_inferior_hook): Pass current_program_space to
8671         get_svr4_info.
8672         (svr4_clear_solib): Likewise.
8673
8674 2019-04-22  Pedro Alves  <palves@redhat.com>
8675
8676         * solib-svr4.c (svr4_free_objfile_observer): New.
8677         (probe_and_action::objfile): New field.
8678         (probes_table_htab_remove_objfile_probes)
8679         (probes_table_remove_objfile_probes): New functions.
8680         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8681         in the new probe_and_action.  Don't store the probe in 'lookup'.
8682         (svr4_create_probe_breakpoints): Pass objfile to
8683         register_solib_event_probe.
8684         (_initialize_svr4_solib): Register a free_objfile observer.
8685
8686 2019-04-19  Tom Tromey  <tom@tromey.com>
8687
8688         * common/queue.h: Remove.
8689
8690 2019-04-19  Tom Tromey  <tom@tromey.com>
8691
8692         * event-loop.c: Don't include "common/queue.h".
8693
8694 2019-04-19  Tom Tromey  <tom@tromey.com>
8695
8696         * remote.c (remote_target): Use delete.
8697         * remote-notif.h: Include <list>, not "common/queue.h".
8698         (notif_client_p): Remove typedef.
8699         (remote_notif_state): Add constructor, destructor, initializer.
8700         <notif_queue>: Now a std::list.
8701         (remote_notif_state_xfree): Don't declare.
8702         * remote-notif.c (remote_notif_process, handle_notification)
8703         (remote_notif_state_allocate): Update.
8704         (~remote_notif_state): Rename from remote_notif_state_xfree.
8705
8706 2019-04-19  Tom Tromey  <tom@tromey.com>
8707
8708         * symfile.c (reread_symbols): Update.
8709         * objfiles.c (objfile_register_static_link)
8710         (objfile_lookup_static_link): Update
8711         (~objfile) Don't delete static_links.
8712         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8713
8714 2019-04-19  Tom Tromey  <tom@tromey.com>
8715
8716         * type-stack.h (struct type_stack) <insert>: Constify string.
8717         * type-stack.c (type_stack::insert): Constify string.
8718         * gdbtypes.h (lookup_template_type): Update.
8719         (address_space_name_to_int): Update.
8720         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8721         const.
8722         (lookup_template_type): Make name const.
8723         * c-exp.y: Update rules.
8724         (lex_one_token, classify_name, classify_inner_name)
8725         (c_print_token): Update.
8726         * p-exp.y: Update rules.
8727         (yylex): Update.
8728         * f-exp.y: Update rules.
8729         (yylex): Update.
8730         * d-exp.y: Update rules.
8731         (lex_one_token, classify_name, classify_inner_name): Update.
8732         * parse.c (write_dollar_variable, copy_name): Return std::string.
8733         * parser-defs.h (copy_name): Change return type.
8734         * m2-exp.y: Update rules.
8735         (yylex): Update.
8736         * go-exp.y (lex_one_token): Update.
8737         Update rules.
8738         (classify_unsafe_function, classify_packaged_name)
8739         (classify_name, yylex): Update.
8740
8741 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8742
8743         * configure.ac: add --enable-source-highlight switch.
8744         * configure: Regenerate.
8745         * top.c (print_gdb_version): plumb --enable-source-highlight
8746         status to "show configuration".
8747
8748 2019-04-19  Tom Tromey  <tromey@adacore.com>
8749
8750         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8751         Check ADA_TYPE_P.
8752         (empty_record, ada_template_to_fixed_record_type_1)
8753         (template_to_static_fixed_type)
8754         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8755         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8756         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8757         macros.
8758
8759 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8760
8761         PR symtab/24423:
8762         * source.c (print_source_lines_base): Advance "iter" when a
8763         control character is seen.
8764
8765 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8766
8767         * inferior.h (struct infcall_suspend_state_deleter):
8768         Catch exception in destructor to avoid crash.
8769
8770 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8771
8772         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8773         close to the add_com "shell".
8774
8775 2019-04-18  Tom Tromey  <tromey@adacore.com>
8776
8777         * process-stratum-target.h (class process_stratum_target)
8778         <stratum>: Add "final".
8779
8780 2019-04-17  Tom Tromey  <tromey@adacore.com>
8781
8782         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8783         against nullptr before use.
8784
8785 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8786
8787         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8788
8789 2019-04-17  Jim Wilson  <jimw@sifive.com>
8790             Andrew Burgess  <andrew.burgess@embecosm.com>
8791
8792         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8793         code read might fail, assume 4-byte breakpoint in that case.
8794
8795 2019-04-15  Leszek Swirski  <leszeks@google.com>
8796
8797         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8798         rather than a hand-rolled POD check when checking for forced MEMORY
8799         classification.
8800
8801 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8802
8803         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8804         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8805         function.
8806         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8807         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8808         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8809         declaration.
8810
8811 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8812
8813         * aarch64-linux-nat.c
8814         (aarch64_linux_nat_target::thread_architecture): Add override.
8815         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8816         each VQ.
8817
8818 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8819
8820         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8821
8822 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8825         target types of size 96-bits, add some additional comments, and
8826         check that the builtin type we found was the correct size.
8827
8828 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8829
8830         * utils.c (prompt_for_continue): Don't restore the styling at the
8831         end, as applied_style has the wrong value.  This fixes styling in
8832         long lists of file names that are interrupted by the "Continue?"
8833         prompt.
8834
8835 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8836
8837         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8838         * c-lang.c (c_language_defn): Likewise.
8839         (cplus_language_defn): Likewise.
8840         (asm_language_defn): Likewise.
8841         (minimal_language_defn): Likewise.
8842         * d-lang.c (d_language_defn): Likewise.
8843         * f-lang.c (f_language_defn): Likewise.
8844         * go-lang.c (go_language_defn): Likewise.
8845         * language.c (unknown_language_defn): Likewise.
8846         (auto_language_defn): Likewise.
8847         * language.h (struct language_defn): Remove la_magic field.
8848         (LANG_MAGIC): Delete.
8849         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8850         * objc-lang.c (objc_language_defn): Likewise.
8851         * opencl-lang.c (opencl_language_defn): Likewise.
8852         * p-lang.c (pascal_language_defn): Likewise.
8853         * rust-lang.c (rust_language_defn): Likewise.
8854
8855 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8856
8857         * riscv-tdep.c (riscv_type_align): New function.
8858         (riscv_type_alignment): Delete.
8859         (riscv_arg_location): Use 'type_align'.
8860         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8861
8862 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8863
8864         * gdbtypes.c (type_align): A struct with no non-static fields also
8865         has alignment of 1.
8866
8867 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8868
8869         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8870         component to 0.
8871         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8872         member.
8873         (riscv_struct_info::analyse): New implementation using new
8874         analyse_inner member function.
8875         (riscv_struct_info::field_offset): New member function.
8876         (riscv_struct_info::m_offsets): New member variable.
8877         (riscv_struct_info::analyse_inner): New private member function,
8878         takes the old implementation of riscv_struct_info::analyse but
8879         extended to track field offsets.
8880         (riscv_call_arg_struct): Update the struct folding special cases
8881         to handle cases where empty C++ structs, which are non-zero
8882         length, are found.
8883         (riscv_arg_location): Initialise the length of each location, a
8884         non-zero length now indicates the location is in use.
8885         (riscv_push_dummy_call): Allow for the first location having a
8886         non-zero offset when setting up arguments.
8887         (riscv_return_value): Likewise, but for return values.
8888
8889 2019-04-11  Tom Tromey  <tromey@adacore.com>
8890
8891         * utils.c (internal_vproblem): Make "msg" const.
8892
8893 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8894
8895         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8896         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8897         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8898         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8899
8900 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8901
8902         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8903         function.
8904         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8905         of amd64_collect_native_gregset.
8906         (amd64_linux_nat_target::store_registers): Likewise.
8907
8908 2019-04-10  Tom Tromey  <tom@tromey.com>
8909
8910         * symtab.c (lookup_global_symbol_from_objfile)
8911         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8912         * objfiles.h (class separate_debug_iterator): New.
8913         (class separate_debug_range): New.
8914         (struct objfile) <separate_debug_objfiles>: New method.
8915         (objfile_separate_debug_iterate): Don't declare.
8916         * objfiles.c (separate_debug_iterator::operator++): Rename from
8917         objfile_separate_debug_iterate.
8918         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8919         iterator.
8920         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8921         iterator.
8922
8923 2019-04-10  Tom Tromey  <tom@tromey.com>
8924
8925         * symfile.c (reread_symbols): Remove old comment.
8926         * objfiles.c (free_all_objfiles): Fix a typo.
8927
8928 2019-04-10  Tom Tromey  <tom@tromey.com>
8929
8930         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8931         * minsyms.c (lookup_minimal_symbol): Use foreach.
8932         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8933         (lookup_minimal_symbol_solib_trampoline): Likewise.
8934         * symfile.c (reread_symbols): Use foreach.
8935
8936 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8937             Tom Tromey  <tromey@adacore.com>
8938
8939         PR rust/24414:
8940         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8941         (rust_lex_int_test): Change "value" to be LONGEST.
8942         (rust_lex_tests): Add test for long integer literal.
8943
8944 2019-04-09  Tom Tromey  <tromey@adacore.com>
8945
8946         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8947         to bool.
8948         (extended_remote_target::attach): Update.
8949         (remote_target::remote_notice_new_inferior): Update.
8950         (remote_target::add_current_inferior_and_thread): Update.
8951         * inferior.c (exit_inferior_1): Use "false".
8952         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8953
8954 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8955
8956         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8957         the "start" command.
8958
8959 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8960
8961         * python/py-inferior.c (infpy_thread_from_thread_handle):
8962         Adjust comments to reflect renaming of thread_from_thread_handle
8963         to thread_from_handle.  Adjust keywords.  Fix type error message.
8964         (inferior_object_methods): Add thread_from_handle.  Retain
8965         thread_from_thread_handle, but mark it as deprecated.
8966
8967 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8968
8969         * gdbthread.h (find_thread_by_handle): Revise declaration.
8970         * thread.c (find_thread_by_handle): Likewise.  Adjust
8971         implementation too.
8972         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8973         support for buffer objects as handles.
8974
8975 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8976
8977         * python/py-infthread.c (thpy_thread_handle): New function.
8978         (thread_object_methods): Register thpy_thread_handle.
8979
8980 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8981
8982         * gdbthread.h (thread_to_thread_handle): Declare.
8983         * thread.c (gdbtypes.h): Include.
8984         (thread_to_thread_handle): New function.
8985
8986         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8987         (target_thread_info_to_thread_handle): Declare.
8988         * target.c (target_thread_info_to_thread_handle): New function.
8989         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8990         * target-delegates.c: Regenerate.
8991
8992         * linux-thread-db.c (class thread_db_target): Add method
8993         thread_info_to_thread_handle.
8994         (thread_db_target::thread_info_to_thread_handle): Define.
8995         * remote.c (class remote_target): Add new method
8996         thread_info_to_thread_handle.
8997         (remote_target::thread_info_to_thread_handle): Define.
8998
8999 2019-04-08  Pedro Alves  <palves@redhat.com>
9000
9001         * common/common-exceptions.c (throw_exception): Don't create
9002         named object to throw; throw directly.
9003         (throw_it): Likewise.  Don't initialize gdb_exception::message
9004         here, with new; pass FMT and AP to the ctor instead.
9005         * common/common-exceptions.h: Include <string>.
9006         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9007         const char *, va_list)): New ctor.  Use std::make_shared.
9008         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9009         errors)): Delete.
9010         (gdb_exception_error::gdb_exception_error(enum errors, const char
9011         *, va_list)): New.
9012         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9013         Add assertion.
9014         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9015         errors)): Delete.
9016         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9017         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9018         Add assertion.
9019
9020 2019-04-08  Tom Tromey  <tom@tromey.com>
9021
9022         * valops.c (value_rtti_indirect_type): Replace throw_exception
9023         with throw.
9024         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9025         with throw.
9026         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9027         throw.
9028         * target.c (target_translate_tls_address): Replace throw_exception
9029         with throw.
9030         * stack.c (frame_apply_command_count): Replace throw_exception
9031         with throw.
9032         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9033         throw.
9034         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9035         with throw.
9036         * rs6000-tdep.c (rs6000_frame_cache)
9037         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9038         * remote.c: Replace throw_exception with throw.
9039         * record-full.c (record_full_message, record_full_wait_1)
9040         (record_full_restore): Replace throw_exception with throw.
9041         * record-btrace.c:
9042         (get_thread_current_frame_id, record_btrace_start_replaying)
9043         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9044         (cmd_record_btrace_start): Replace throw_exception with throw.
9045         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9046         throw.
9047         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9048         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9049         * linespec.c:
9050         (find_linespec_symbols): Replace throw_exception with throw.
9051         * infrun.c (displaced_step_prepare, resume): Replace
9052         throw_exception with throw.
9053         * infcmd.c (post_create_inferior): Replace throw_exception with
9054         throw.
9055         * inf-loop.c (inferior_event_handler): Replace throw_exception
9056         with throw.
9057         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9058         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9059         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9060         (get_prev_frame_always, get_frame_pc_if_available)
9061         (get_frame_address_in_block_if_available, get_frame_language):
9062         Replace throw_exception with throw.
9063         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9064         throw_exception with throw.
9065         * eval.c (fetch_subexp_value, evaluate_var_value)
9066         (evaluate_funcall, evaluate_subexp_standard): Replace
9067         throw_exception with throw.
9068         * dwarf2loc.c (call_site_find_chain)
9069         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9070         Replace throw_exception with throw.
9071         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9072         with throw.
9073         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9074         throw.
9075         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9076         * completer.c (complete_line_internal): Replace throw_exception
9077         with throw.
9078         * compile/compile-object-run.c (compile_object_run): Replace
9079         throw_exception with throw.
9080         * cli/cli-script.c (process_next_line): Replace throw_exception
9081         with throw.
9082         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9083         (btrace_enable, btrace_maint_update_pt_packets): Replace
9084         throw_exception with throw.
9085         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9086         throw_exception with throw.
9087         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9088         throw_exception with throw.
9089         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9090         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9091         * aarch64-tdep.c (aarch64_make_prologue_cache)
9092         (aarch64_make_stub_cache): Replace throw_exception with throw.
9093
9094 2019-04-08  Tom Tromey  <tom@tromey.com>
9095
9096         * common/common-exceptions.c (throw_exception): Rename from
9097         throw_exception_cxx.  Remove old copy.  Make argument const.
9098         (throw_it): Create and throw exception objects directly.
9099         * common/common-exceptions.h (throw_exception): Make argument
9100         const.
9101         (struct gdb_exception_error): Add constructor.
9102         (struct gdb_exception_quit): Add constructor.
9103
9104 2019-04-08  Tom Tromey  <tom@tromey.com>
9105
9106         * common/common-exceptions.h (exception_rethrow): Don't declare.
9107         (TRY_SJLJ): Update comment.
9108         (TRY, CATCH, END_CATCH): Remove.
9109         * common/common-exceptions.c (exception_rethrow): Remove.
9110
9111 2019-04-08  Tom Tromey  <tom@tromey.com>
9112
9113         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9114         Remove.
9115         (gdb_exception_error): Rename from
9116         gdb_exception_RETURN_MASK_ERROR.
9117         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9118         (gdb_quit_bad_alloc): Update.
9119         * aarch64-tdep.c: Update.
9120         * ada-lang.c: Update.
9121         * ada-typeprint.c: Update.
9122         * ada-valprint.c: Update.
9123         * amd64-tdep.c: Update.
9124         * arch-utils.c: Update.
9125         * break-catch-throw.c: Update.
9126         * breakpoint.c: Update.
9127         * btrace.c: Update.
9128         * c-varobj.c: Update.
9129         * cli/cli-cmds.c: Update.
9130         * cli/cli-interp.c: Update.
9131         * cli/cli-script.c: Update.
9132         * common/common-exceptions.c: Update.
9133         * common/new-op.c: Update.
9134         * common/selftest.c: Update.
9135         * compile/compile-c-symbols.c: Update.
9136         * compile/compile-cplus-symbols.c: Update.
9137         * compile/compile-object-load.c: Update.
9138         * compile/compile-object-run.c: Update.
9139         * completer.c: Update.
9140         * corelow.c: Update.
9141         * cp-abi.c: Update.
9142         * cp-support.c: Update.
9143         * cp-valprint.c: Update.
9144         * darwin-nat.c: Update.
9145         * disasm-selftests.c: Update.
9146         * dtrace-probe.c: Update.
9147         * dwarf-index-cache.c: Update.
9148         * dwarf-index-write.c: Update.
9149         * dwarf2-frame-tailcall.c: Update.
9150         * dwarf2-frame.c: Update.
9151         * dwarf2loc.c: Update.
9152         * dwarf2read.c: Update.
9153         * eval.c: Update.
9154         * event-loop.c: Update.
9155         * event-top.c: Update.
9156         * exec.c: Update.
9157         * f-valprint.c: Update.
9158         * fbsd-tdep.c: Update.
9159         * frame-unwind.c: Update.
9160         * frame.c: Update.
9161         * gdbtypes.c: Update.
9162         * gnu-v3-abi.c: Update.
9163         * guile/guile-internal.h: Update.
9164         * guile/scm-block.c: Update.
9165         * guile/scm-breakpoint.c: Update.
9166         * guile/scm-cmd.c: Update.
9167         * guile/scm-disasm.c: Update.
9168         * guile/scm-frame.c: Update.
9169         * guile/scm-lazy-string.c: Update.
9170         * guile/scm-math.c: Update.
9171         * guile/scm-param.c: Update.
9172         * guile/scm-ports.c: Update.
9173         * guile/scm-pretty-print.c: Update.
9174         * guile/scm-symbol.c: Update.
9175         * guile/scm-symtab.c: Update.
9176         * guile/scm-type.c: Update.
9177         * guile/scm-value.c: Update.
9178         * i386-linux-tdep.c: Update.
9179         * i386-tdep.c: Update.
9180         * inf-loop.c: Update.
9181         * infcall.c: Update.
9182         * infcmd.c: Update.
9183         * infrun.c: Update.
9184         * jit.c: Update.
9185         * language.c: Update.
9186         * linespec.c: Update.
9187         * linux-fork.c: Update.
9188         * linux-nat.c: Update.
9189         * linux-tdep.c: Update.
9190         * linux-thread-db.c: Update.
9191         * main.c: Update.
9192         * mi/mi-cmd-break.c: Update.
9193         * mi/mi-cmd-stack.c: Update.
9194         * mi/mi-interp.c: Update.
9195         * mi/mi-main.c: Update.
9196         * objc-lang.c: Update.
9197         * p-valprint.c: Update.
9198         * parse.c: Update.
9199         * ppc-linux-tdep.c: Update.
9200         * printcmd.c: Update.
9201         * python/py-arch.c: Update.
9202         * python/py-breakpoint.c: Update.
9203         * python/py-cmd.c: Update.
9204         * python/py-finishbreakpoint.c: Update.
9205         * python/py-frame.c: Update.
9206         * python/py-framefilter.c: Update.
9207         * python/py-gdb-readline.c: Update.
9208         * python/py-inferior.c: Update.
9209         * python/py-infthread.c: Update.
9210         * python/py-lazy-string.c: Update.
9211         * python/py-linetable.c: Update.
9212         * python/py-objfile.c: Update.
9213         * python/py-param.c: Update.
9214         * python/py-prettyprint.c: Update.
9215         * python/py-progspace.c: Update.
9216         * python/py-record-btrace.c: Update.
9217         * python/py-record.c: Update.
9218         * python/py-symbol.c: Update.
9219         * python/py-type.c: Update.
9220         * python/py-unwind.c: Update.
9221         * python/py-utils.c: Update.
9222         * python/py-value.c: Update.
9223         * python/python.c: Update.
9224         * record-btrace.c: Update.
9225         * record-full.c: Update.
9226         * remote-fileio.c: Update.
9227         * remote.c: Update.
9228         * riscv-tdep.c: Update.
9229         * rs6000-aix-tdep.c: Update.
9230         * rs6000-tdep.c: Update.
9231         * rust-exp.y: Update.
9232         * rust-lang.c: Update.
9233         * s390-tdep.c: Update.
9234         * selftest-arch.c: Update.
9235         * solib-dsbt.c: Update.
9236         * solib-frv.c: Update.
9237         * solib-spu.c: Update.
9238         * solib-svr4.c: Update.
9239         * solib.c: Update.
9240         * sparc64-linux-tdep.c: Update.
9241         * stack.c: Update.
9242         * symfile-mem.c: Update.
9243         * symmisc.c: Update.
9244         * target.c: Update.
9245         * thread.c: Update.
9246         * top.c: Update.
9247         * tracefile-tfile.c: Update.
9248         * tui/tui.c: Update.
9249         * typeprint.c: Update.
9250         * unittests/cli-utils-selftests.c: Update.
9251         * unittests/parse-connection-spec-selftests.c: Update.
9252         * valops.c: Update.
9253         * valprint.c: Update.
9254         * value.c: Update.
9255         * varobj.c: Update.
9256         * windows-nat.c: Update.
9257         * x86-linux-nat.c: Update.
9258         * xml-support.c: Update.
9259
9260 2019-04-08  Tom Tromey  <tom@tromey.com>
9261
9262         * xml-support.c: Use C++ exception handling.
9263         * x86-linux-nat.c: Use C++ exception handling.
9264         * windows-nat.c: Use C++ exception handling.
9265         * varobj.c: Use C++ exception handling.
9266         * value.c: Use C++ exception handling.
9267         * valprint.c: Use C++ exception handling.
9268         * valops.c: Use C++ exception handling.
9269         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9270         handling.
9271         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9272         * typeprint.c: Use C++ exception handling.
9273         * tui/tui.c: Use C++ exception handling.
9274         * tracefile-tfile.c: Use C++ exception handling.
9275         * top.c: Use C++ exception handling.
9276         * thread.c: Use C++ exception handling.
9277         * target.c: Use C++ exception handling.
9278         * symmisc.c: Use C++ exception handling.
9279         * symfile-mem.c: Use C++ exception handling.
9280         * stack.c: Use C++ exception handling.
9281         * sparc64-linux-tdep.c: Use C++ exception handling.
9282         * solib.c: Use C++ exception handling.
9283         * solib-svr4.c: Use C++ exception handling.
9284         * solib-spu.c: Use C++ exception handling.
9285         * solib-frv.c: Use C++ exception handling.
9286         * solib-dsbt.c: Use C++ exception handling.
9287         * selftest-arch.c: Use C++ exception handling.
9288         * s390-tdep.c: Use C++ exception handling.
9289         * rust-lang.c: Use C++ exception handling.
9290         * rust-exp.y: Use C++ exception handling.
9291         * rs6000-tdep.c: Use C++ exception handling.
9292         * rs6000-aix-tdep.c: Use C++ exception handling.
9293         * riscv-tdep.c: Use C++ exception handling.
9294         * remote.c: Use C++ exception handling.
9295         * remote-fileio.c: Use C++ exception handling.
9296         * record-full.c: Use C++ exception handling.
9297         * record-btrace.c: Use C++ exception handling.
9298         * python/python.c: Use C++ exception handling.
9299         * python/py-value.c: Use C++ exception handling.
9300         * python/py-utils.c: Use C++ exception handling.
9301         * python/py-unwind.c: Use C++ exception handling.
9302         * python/py-type.c: Use C++ exception handling.
9303         * python/py-symbol.c: Use C++ exception handling.
9304         * python/py-record.c: Use C++ exception handling.
9305         * python/py-record-btrace.c: Use C++ exception handling.
9306         * python/py-progspace.c: Use C++ exception handling.
9307         * python/py-prettyprint.c: Use C++ exception handling.
9308         * python/py-param.c: Use C++ exception handling.
9309         * python/py-objfile.c: Use C++ exception handling.
9310         * python/py-linetable.c: Use C++ exception handling.
9311         * python/py-lazy-string.c: Use C++ exception handling.
9312         * python/py-infthread.c: Use C++ exception handling.
9313         * python/py-inferior.c: Use C++ exception handling.
9314         * python/py-gdb-readline.c: Use C++ exception handling.
9315         * python/py-framefilter.c: Use C++ exception handling.
9316         * python/py-frame.c: Use C++ exception handling.
9317         * python/py-finishbreakpoint.c: Use C++ exception handling.
9318         * python/py-cmd.c: Use C++ exception handling.
9319         * python/py-breakpoint.c: Use C++ exception handling.
9320         * python/py-arch.c: Use C++ exception handling.
9321         * printcmd.c: Use C++ exception handling.
9322         * ppc-linux-tdep.c: Use C++ exception handling.
9323         * parse.c: Use C++ exception handling.
9324         * p-valprint.c: Use C++ exception handling.
9325         * objc-lang.c: Use C++ exception handling.
9326         * mi/mi-main.c: Use C++ exception handling.
9327         * mi/mi-interp.c: Use C++ exception handling.
9328         * mi/mi-cmd-stack.c: Use C++ exception handling.
9329         * mi/mi-cmd-break.c: Use C++ exception handling.
9330         * main.c: Use C++ exception handling.
9331         * linux-thread-db.c: Use C++ exception handling.
9332         * linux-tdep.c: Use C++ exception handling.
9333         * linux-nat.c: Use C++ exception handling.
9334         * linux-fork.c: Use C++ exception handling.
9335         * linespec.c: Use C++ exception handling.
9336         * language.c: Use C++ exception handling.
9337         * jit.c: Use C++ exception handling.
9338         * infrun.c: Use C++ exception handling.
9339         * infcmd.c: Use C++ exception handling.
9340         * infcall.c: Use C++ exception handling.
9341         * inf-loop.c: Use C++ exception handling.
9342         * i386-tdep.c: Use C++ exception handling.
9343         * i386-linux-tdep.c: Use C++ exception handling.
9344         * guile/scm-value.c: Use C++ exception handling.
9345         * guile/scm-type.c: Use C++ exception handling.
9346         * guile/scm-symtab.c: Use C++ exception handling.
9347         * guile/scm-symbol.c: Use C++ exception handling.
9348         * guile/scm-pretty-print.c: Use C++ exception handling.
9349         * guile/scm-ports.c: Use C++ exception handling.
9350         * guile/scm-param.c: Use C++ exception handling.
9351         * guile/scm-math.c: Use C++ exception handling.
9352         * guile/scm-lazy-string.c: Use C++ exception handling.
9353         * guile/scm-frame.c: Use C++ exception handling.
9354         * guile/scm-disasm.c: Use C++ exception handling.
9355         * guile/scm-cmd.c: Use C++ exception handling.
9356         * guile/scm-breakpoint.c: Use C++ exception handling.
9357         * guile/scm-block.c: Use C++ exception handling.
9358         * guile/guile-internal.h: Use C++ exception handling.
9359         * gnu-v3-abi.c: Use C++ exception handling.
9360         * gdbtypes.c: Use C++ exception handling.
9361         * frame.c: Use C++ exception handling.
9362         * frame-unwind.c: Use C++ exception handling.
9363         * fbsd-tdep.c: Use C++ exception handling.
9364         * f-valprint.c: Use C++ exception handling.
9365         * exec.c: Use C++ exception handling.
9366         * event-top.c: Use C++ exception handling.
9367         * event-loop.c: Use C++ exception handling.
9368         * eval.c: Use C++ exception handling.
9369         * dwarf2read.c: Use C++ exception handling.
9370         * dwarf2loc.c: Use C++ exception handling.
9371         * dwarf2-frame.c: Use C++ exception handling.
9372         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9373         * dwarf-index-write.c: Use C++ exception handling.
9374         * dwarf-index-cache.c: Use C++ exception handling.
9375         * dtrace-probe.c: Use C++ exception handling.
9376         * disasm-selftests.c: Use C++ exception handling.
9377         * darwin-nat.c: Use C++ exception handling.
9378         * cp-valprint.c: Use C++ exception handling.
9379         * cp-support.c: Use C++ exception handling.
9380         * cp-abi.c: Use C++ exception handling.
9381         * corelow.c: Use C++ exception handling.
9382         * completer.c: Use C++ exception handling.
9383         * compile/compile-object-run.c: Use C++ exception handling.
9384         * compile/compile-object-load.c: Use C++ exception handling.
9385         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9386         * compile/compile-c-symbols.c: Use C++ exception handling.
9387         * common/selftest.c: Use C++ exception handling.
9388         * common/new-op.c: Use C++ exception handling.
9389         * cli/cli-script.c: Use C++ exception handling.
9390         * cli/cli-interp.c: Use C++ exception handling.
9391         * cli/cli-cmds.c: Use C++ exception handling.
9392         * c-varobj.c: Use C++ exception handling.
9393         * btrace.c: Use C++ exception handling.
9394         * breakpoint.c: Use C++ exception handling.
9395         * break-catch-throw.c: Use C++ exception handling.
9396         * arch-utils.c: Use C++ exception handling.
9397         * amd64-tdep.c: Use C++ exception handling.
9398         * ada-valprint.c: Use C++ exception handling.
9399         * ada-typeprint.c: Use C++ exception handling.
9400         * ada-lang.c: Use C++ exception handling.
9401         * aarch64-tdep.c: Use C++ exception handling.
9402
9403 2019-04-08  Tom Tromey  <tom@tromey.com>
9404
9405         * xml-support.c (gdb_xml_parser::parse): Update.
9406         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9407         * value.c (show_convenience): Update.
9408         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9409         (test_parse_flags_qcs): Update.
9410         * thread.c (thr_try_catch_cmd): Update.
9411         * target.c (target_translate_tls_address): Update.
9412         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9413         (info_frame_command_core, frame_apply_command_count): Update.
9414         * rust-exp.y (rust_lex_exception_test): Update.
9415         * riscv-tdep.c (riscv_print_one_register_info): Update.
9416         * remote.c (remote_target::enable_btrace): Update.
9417         * record-btrace.c (record_btrace_enable_warn): Update.
9418         * python/py-utils.c (gdbpy_convert_exception): Update.
9419         * printcmd.c (do_one_display, print_variable_and_value): Update.
9420         * mi/mi-main.c (mi_print_exception): Update.
9421         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9422         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9423         * linux-nat.c (linux_nat_target::attach): Update.
9424         * linux-fork.c (class scoped_switch_fork_info): Update.
9425         * infrun.c (displaced_step_prepare): Update.
9426         * infcall.c (call_function_by_hand_dummy): Update.
9427         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9428         * gnu-v3-abi.c (print_one_vtable): Update.
9429         * frame.c (get_prev_frame_always): Update.
9430         * f-valprint.c (info_common_command_for_block): Update.
9431         * exec.c (try_open_exec_file): Update.
9432         * exceptions.c (print_exception, exception_print)
9433         (exception_fprintf, exception_print_same): Update.
9434         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9435         * dwarf-index-cache.c (index_cache::store)
9436         (index_cache::lookup_gdb_index): Update.
9437         * darwin-nat.c (maybe_cache_shell): Update.
9438         * cp-valprint.c (cp_print_value_fields): Update.
9439         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9440         (gcc_cplus_symbol_address): Update.
9441         * compile/compile-c-symbols.c (gcc_convert_symbol)
9442         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9443         * common/selftest.c: Update.
9444         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9445         a std::string.
9446         (exception_try_scope_entry, exception_try_scope_exit): Don't
9447         declare.
9448         (struct exception_try_scope): Remove.
9449         (TRY): Don't use exception_try_scope.
9450         (struct gdb_exception): Add constructor, operator=.
9451         <what>: New method.
9452         (struct gdb_exception_RETURN_MASK_ALL)
9453         (struct gdb_exception_RETURN_MASK_ERROR)
9454         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9455         (struct gdb_quit_bad_alloc): Update.
9456         * common/common-exceptions.c (exception_none): Change
9457         initializer.
9458         (struct catcher) <state, exception>: Initialize inline.
9459         <prev>: Remove member.
9460         (current_catcher): Remove.
9461         (catchers): New global.
9462         (exceptions_state_mc_init): Simplify.
9463         (catcher_pop): Remove.
9464         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9465         (try_scope_depth, exception_try_scope_entry)
9466         (exception_try_scope_exit): Remove.
9467         (throw_exception_sjlj): Update.
9468         (exception_messages, exception_messages_size): Remove.
9469         (throw_it): Simplify.
9470         (gdb_exception_sliced_copy): Remove.
9471         (throw_exception_cxx): Update.
9472         * cli/cli-script.c (script_from_file): Update.
9473         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9474         Update.
9475         * ada-valprint.c (ada_val_print): Update.
9476         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9477         (create_excep_cond_exprs): Update.
9478
9479 2019-04-08  Tom Tromey  <tom@tromey.com>
9480
9481         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9482         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9483         (TRY, CATCH, END_CATCH): Remove some definitions.
9484         * common/common-exceptions.c: Don't use GDB_XCPT.
9485         (catcher_list_size): Remove.
9486         (throw_exception, throw_it): Simplify.
9487
9488 2019-04-05  Tom Tromey  <tom@tromey.com>
9489
9490         Revert the header-sorting patch.
9491         * ft32-tdep.c: Revert.
9492         * frv-tdep.c: Revert.
9493         * frv-linux-tdep.c: Revert.
9494         * frame.c: Revert.
9495         * frame-unwind.c: Revert.
9496         * frame-base.c: Revert.
9497         * fork-child.c: Revert.
9498         * findvar.c: Revert.
9499         * findcmd.c: Revert.
9500         * filesystem.c: Revert.
9501         * filename-seen-cache.h: Revert.
9502         * filename-seen-cache.c: Revert.
9503         * fbsd-tdep.c: Revert.
9504         * fbsd-nat.h: Revert.
9505         * fbsd-nat.c: Revert.
9506         * f-valprint.c: Revert.
9507         * f-typeprint.c: Revert.
9508         * f-lang.c: Revert.
9509         * extension.h: Revert.
9510         * extension.c: Revert.
9511         * extension-priv.h: Revert.
9512         * expprint.c: Revert.
9513         * exec.h: Revert.
9514         * exec.c: Revert.
9515         * exceptions.c: Revert.
9516         * event-top.c: Revert.
9517         * event-loop.c: Revert.
9518         * eval.c: Revert.
9519         * elfread.c: Revert.
9520         * dwarf2read.h: Revert.
9521         * dwarf2read.c: Revert.
9522         * dwarf2loc.c: Revert.
9523         * dwarf2expr.h: Revert.
9524         * dwarf2expr.c: Revert.
9525         * dwarf2-frame.c: Revert.
9526         * dwarf2-frame-tailcall.c: Revert.
9527         * dwarf-index-write.h: Revert.
9528         * dwarf-index-write.c: Revert.
9529         * dwarf-index-common.c: Revert.
9530         * dwarf-index-cache.h: Revert.
9531         * dwarf-index-cache.c: Revert.
9532         * dummy-frame.c: Revert.
9533         * dtrace-probe.c: Revert.
9534         * disasm.h: Revert.
9535         * disasm.c: Revert.
9536         * disasm-selftests.c: Revert.
9537         * dictionary.c: Revert.
9538         * dicos-tdep.c: Revert.
9539         * demangle.c: Revert.
9540         * dcache.h: Revert.
9541         * dcache.c: Revert.
9542         * darwin-nat.h: Revert.
9543         * darwin-nat.c: Revert.
9544         * darwin-nat-info.c: Revert.
9545         * d-valprint.c: Revert.
9546         * d-namespace.c: Revert.
9547         * d-lang.c: Revert.
9548         * ctf.c: Revert.
9549         * csky-tdep.c: Revert.
9550         * csky-linux-tdep.c: Revert.
9551         * cris-tdep.c: Revert.
9552         * cris-linux-tdep.c: Revert.
9553         * cp-valprint.c: Revert.
9554         * cp-support.c: Revert.
9555         * cp-namespace.c: Revert.
9556         * cp-abi.c: Revert.
9557         * corelow.c: Revert.
9558         * corefile.c: Revert.
9559         * continuations.c: Revert.
9560         * completer.h: Revert.
9561         * completer.c: Revert.
9562         * complaints.c: Revert.
9563         * coffread.c: Revert.
9564         * coff-pe-read.c: Revert.
9565         * cli-out.h: Revert.
9566         * cli-out.c: Revert.
9567         * charset.c: Revert.
9568         * c-varobj.c: Revert.
9569         * c-valprint.c: Revert.
9570         * c-typeprint.c: Revert.
9571         * c-lang.c: Revert.
9572         * buildsym.c: Revert.
9573         * buildsym-legacy.c: Revert.
9574         * build-id.h: Revert.
9575         * build-id.c: Revert.
9576         * btrace.c: Revert.
9577         * bsd-uthread.c: Revert.
9578         * breakpoint.h: Revert.
9579         * breakpoint.c: Revert.
9580         * break-catch-throw.c: Revert.
9581         * break-catch-syscall.c: Revert.
9582         * break-catch-sig.c: Revert.
9583         * blockframe.c: Revert.
9584         * block.c: Revert.
9585         * bfin-tdep.c: Revert.
9586         * bfin-linux-tdep.c: Revert.
9587         * bfd-target.c: Revert.
9588         * bcache.c: Revert.
9589         * ax-general.c: Revert.
9590         * ax-gdb.h: Revert.
9591         * ax-gdb.c: Revert.
9592         * avr-tdep.c: Revert.
9593         * auxv.c: Revert.
9594         * auto-load.c: Revert.
9595         * arm-wince-tdep.c: Revert.
9596         * arm-tdep.c: Revert.
9597         * arm-symbian-tdep.c: Revert.
9598         * arm-pikeos-tdep.c: Revert.
9599         * arm-obsd-tdep.c: Revert.
9600         * arm-nbsd-tdep.c: Revert.
9601         * arm-nbsd-nat.c: Revert.
9602         * arm-linux-tdep.c: Revert.
9603         * arm-linux-nat.c: Revert.
9604         * arm-fbsd-tdep.c: Revert.
9605         * arm-fbsd-nat.c: Revert.
9606         * arm-bsd-tdep.c: Revert.
9607         * arch-utils.c: Revert.
9608         * arc-tdep.c: Revert.
9609         * arc-newlib-tdep.c: Revert.
9610         * annotate.h: Revert.
9611         * annotate.c: Revert.
9612         * amd64-windows-tdep.c: Revert.
9613         * amd64-windows-nat.c: Revert.
9614         * amd64-tdep.c: Revert.
9615         * amd64-sol2-tdep.c: Revert.
9616         * amd64-obsd-tdep.c: Revert.
9617         * amd64-obsd-nat.c: Revert.
9618         * amd64-nbsd-tdep.c: Revert.
9619         * amd64-nbsd-nat.c: Revert.
9620         * amd64-nat.c: Revert.
9621         * amd64-linux-tdep.c: Revert.
9622         * amd64-linux-nat.c: Revert.
9623         * amd64-fbsd-tdep.c: Revert.
9624         * amd64-fbsd-nat.c: Revert.
9625         * amd64-dicos-tdep.c: Revert.
9626         * amd64-darwin-tdep.c: Revert.
9627         * amd64-bsd-nat.c: Revert.
9628         * alpha-tdep.c: Revert.
9629         * alpha-obsd-tdep.c: Revert.
9630         * alpha-nbsd-tdep.c: Revert.
9631         * alpha-mdebug-tdep.c: Revert.
9632         * alpha-linux-tdep.c: Revert.
9633         * alpha-linux-nat.c: Revert.
9634         * alpha-bsd-tdep.c: Revert.
9635         * alpha-bsd-nat.c: Revert.
9636         * aix-thread.c: Revert.
9637         * agent.c: Revert.
9638         * addrmap.c: Revert.
9639         * ada-varobj.c: Revert.
9640         * ada-valprint.c: Revert.
9641         * ada-typeprint.c: Revert.
9642         * ada-tasks.c: Revert.
9643         * ada-lang.c: Revert.
9644         * aarch64-tdep.c: Revert.
9645         * aarch64-ravenscar-thread.c: Revert.
9646         * aarch64-newlib-tdep.c: Revert.
9647         * aarch64-linux-tdep.c: Revert.
9648         * aarch64-linux-nat.c: Revert.
9649         * aarch64-fbsd-tdep.c: Revert.
9650         * aarch64-fbsd-nat.c: Revert.
9651         * aarch32-linux-nat.c: Revert.
9652
9653 2019-04-05  Tom Tromey  <tom@tromey.com>
9654
9655         * ft32-tdep.c: Sort headers.
9656         * frv-tdep.c: Sort headers.
9657         * frv-linux-tdep.c: Sort headers.
9658         * frame.c: Sort headers.
9659         * frame-unwind.c: Sort headers.
9660         * frame-base.c: Sort headers.
9661         * fork-child.c: Sort headers.
9662         * findvar.c: Sort headers.
9663         * findcmd.c: Sort headers.
9664         * filesystem.c: Sort headers.
9665         * filename-seen-cache.h: Sort headers.
9666         * filename-seen-cache.c: Sort headers.
9667         * fbsd-tdep.c: Sort headers.
9668         * fbsd-nat.h: Sort headers.
9669         * fbsd-nat.c: Sort headers.
9670         * f-valprint.c: Sort headers.
9671         * f-typeprint.c: Sort headers.
9672         * f-lang.c: Sort headers.
9673         * extension.h: Sort headers.
9674         * extension.c: Sort headers.
9675         * extension-priv.h: Sort headers.
9676         * expprint.c: Sort headers.
9677         * exec.h: Sort headers.
9678         * exec.c: Sort headers.
9679         * exceptions.c: Sort headers.
9680         * event-top.c: Sort headers.
9681         * event-loop.c: Sort headers.
9682         * eval.c: Sort headers.
9683         * elfread.c: Sort headers.
9684         * dwarf2read.h: Sort headers.
9685         * dwarf2read.c: Sort headers.
9686         * dwarf2loc.c: Sort headers.
9687         * dwarf2expr.h: Sort headers.
9688         * dwarf2expr.c: Sort headers.
9689         * dwarf2-frame.c: Sort headers.
9690         * dwarf2-frame-tailcall.c: Sort headers.
9691         * dwarf-index-write.h: Sort headers.
9692         * dwarf-index-write.c: Sort headers.
9693         * dwarf-index-common.c: Sort headers.
9694         * dwarf-index-cache.h: Sort headers.
9695         * dwarf-index-cache.c: Sort headers.
9696         * dummy-frame.c: Sort headers.
9697         * dtrace-probe.c: Sort headers.
9698         * disasm.h: Sort headers.
9699         * disasm.c: Sort headers.
9700         * disasm-selftests.c: Sort headers.
9701         * dictionary.c: Sort headers.
9702         * dicos-tdep.c: Sort headers.
9703         * demangle.c: Sort headers.
9704         * dcache.h: Sort headers.
9705         * dcache.c: Sort headers.
9706         * darwin-nat.h: Sort headers.
9707         * darwin-nat.c: Sort headers.
9708         * darwin-nat-info.c: Sort headers.
9709         * d-valprint.c: Sort headers.
9710         * d-namespace.c: Sort headers.
9711         * d-lang.c: Sort headers.
9712         * ctf.c: Sort headers.
9713         * csky-tdep.c: Sort headers.
9714         * csky-linux-tdep.c: Sort headers.
9715         * cris-tdep.c: Sort headers.
9716         * cris-linux-tdep.c: Sort headers.
9717         * cp-valprint.c: Sort headers.
9718         * cp-support.c: Sort headers.
9719         * cp-namespace.c: Sort headers.
9720         * cp-abi.c: Sort headers.
9721         * corelow.c: Sort headers.
9722         * corefile.c: Sort headers.
9723         * continuations.c: Sort headers.
9724         * completer.h: Sort headers.
9725         * completer.c: Sort headers.
9726         * complaints.c: Sort headers.
9727         * coffread.c: Sort headers.
9728         * coff-pe-read.c: Sort headers.
9729         * cli-out.h: Sort headers.
9730         * cli-out.c: Sort headers.
9731         * charset.c: Sort headers.
9732         * c-varobj.c: Sort headers.
9733         * c-valprint.c: Sort headers.
9734         * c-typeprint.c: Sort headers.
9735         * c-lang.c: Sort headers.
9736         * buildsym.c: Sort headers.
9737         * buildsym-legacy.c: Sort headers.
9738         * build-id.h: Sort headers.
9739         * build-id.c: Sort headers.
9740         * btrace.c: Sort headers.
9741         * bsd-uthread.c: Sort headers.
9742         * breakpoint.h: Sort headers.
9743         * breakpoint.c: Sort headers.
9744         * break-catch-throw.c: Sort headers.
9745         * break-catch-syscall.c: Sort headers.
9746         * break-catch-sig.c: Sort headers.
9747         * blockframe.c: Sort headers.
9748         * block.c: Sort headers.
9749         * bfin-tdep.c: Sort headers.
9750         * bfin-linux-tdep.c: Sort headers.
9751         * bfd-target.c: Sort headers.
9752         * bcache.c: Sort headers.
9753         * ax-general.c: Sort headers.
9754         * ax-gdb.h: Sort headers.
9755         * ax-gdb.c: Sort headers.
9756         * avr-tdep.c: Sort headers.
9757         * auxv.c: Sort headers.
9758         * auto-load.c: Sort headers.
9759         * arm-wince-tdep.c: Sort headers.
9760         * arm-tdep.c: Sort headers.
9761         * arm-symbian-tdep.c: Sort headers.
9762         * arm-pikeos-tdep.c: Sort headers.
9763         * arm-obsd-tdep.c: Sort headers.
9764         * arm-nbsd-tdep.c: Sort headers.
9765         * arm-nbsd-nat.c: Sort headers.
9766         * arm-linux-tdep.c: Sort headers.
9767         * arm-linux-nat.c: Sort headers.
9768         * arm-fbsd-tdep.c: Sort headers.
9769         * arm-fbsd-nat.c: Sort headers.
9770         * arm-bsd-tdep.c: Sort headers.
9771         * arch-utils.c: Sort headers.
9772         * arc-tdep.c: Sort headers.
9773         * arc-newlib-tdep.c: Sort headers.
9774         * annotate.h: Sort headers.
9775         * annotate.c: Sort headers.
9776         * amd64-windows-tdep.c: Sort headers.
9777         * amd64-windows-nat.c: Sort headers.
9778         * amd64-tdep.c: Sort headers.
9779         * amd64-sol2-tdep.c: Sort headers.
9780         * amd64-obsd-tdep.c: Sort headers.
9781         * amd64-obsd-nat.c: Sort headers.
9782         * amd64-nbsd-tdep.c: Sort headers.
9783         * amd64-nbsd-nat.c: Sort headers.
9784         * amd64-nat.c: Sort headers.
9785         * amd64-linux-tdep.c: Sort headers.
9786         * amd64-linux-nat.c: Sort headers.
9787         * amd64-fbsd-tdep.c: Sort headers.
9788         * amd64-fbsd-nat.c: Sort headers.
9789         * amd64-dicos-tdep.c: Sort headers.
9790         * amd64-darwin-tdep.c: Sort headers.
9791         * amd64-bsd-nat.c: Sort headers.
9792         * alpha-tdep.c: Sort headers.
9793         * alpha-obsd-tdep.c: Sort headers.
9794         * alpha-nbsd-tdep.c: Sort headers.
9795         * alpha-mdebug-tdep.c: Sort headers.
9796         * alpha-linux-tdep.c: Sort headers.
9797         * alpha-linux-nat.c: Sort headers.
9798         * alpha-bsd-tdep.c: Sort headers.
9799         * alpha-bsd-nat.c: Sort headers.
9800         * aix-thread.c: Sort headers.
9801         * agent.c: Sort headers.
9802         * addrmap.c: Sort headers.
9803         * ada-varobj.c: Sort headers.
9804         * ada-valprint.c: Sort headers.
9805         * ada-typeprint.c: Sort headers.
9806         * ada-tasks.c: Sort headers.
9807         * ada-lang.c: Sort headers.
9808         * aarch64-tdep.c: Sort headers.
9809         * aarch64-ravenscar-thread.c: Sort headers.
9810         * aarch64-newlib-tdep.c: Sort headers.
9811         * aarch64-linux-tdep.c: Sort headers.
9812         * aarch64-linux-nat.c: Sort headers.
9813         * aarch64-fbsd-tdep.c: Sort headers.
9814         * aarch64-fbsd-nat.c: Sort headers.
9815         * aarch32-linux-nat.c: Sort headers.
9816
9817 2019-04-04  Tom Tromey  <tom@tromey.com>
9818
9819         * varobj.c (varobj_create): Update.
9820         * rust-exp.y (struct rust_parser) <update_innermost_block,
9821         lookup_symbol>: New methods.
9822         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9823         Rename.
9824         (rust_parser::rust_lookup_type)
9825         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9826         * printcmd.c (display_command, do_one_display): Update.
9827         * parser-defs.h (struct parser_state) <parser_state>: Add
9828         "tracker" parameter.
9829         (block_tracker): New member.
9830         (class innermost_block_tracker) <innermost_block_tracker>: Add
9831         "types" parameter.
9832         <reset>: Remove method.
9833         (innermost_block): Don't declare.
9834         (null_post_parser): Update.
9835         * parse.c (innermost_block): Remove global.
9836         (write_dollar_variable): Update.
9837         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9838         Remove "tracker_types" parameter.
9839         (parse_expression): Add "tracker" parameter.
9840         (parse_expression_for_completion): Update.
9841         (null_post_parser): Add "tracker" parameter.
9842         * p-exp.y: Update rules.
9843         * m2-exp.y: Update rules.
9844         * language.h (struct language_defn) <la_post_parser>: Add
9845         "tracker" parameter.
9846         * go-exp.y: Update rules.
9847         * f-exp.y: Update rules.
9848         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9849         parameter.
9850         * d-exp.y: Update rules.
9851         * c-exp.y: Update rules.
9852         * breakpoint.c (set_breakpoint_condition): Create an
9853         innermost_block_tracker.
9854         (watch_command_1): Likewise.
9855         * ada-lang.c (resolve): Add "tracker" parameter.
9856         (resolve_subexp): Likewise.
9857         * ada-exp.y (write_var_from_sym): Update.
9858
9859 2019-04-04  Tom Tromey  <tom@tromey.com>
9860
9861         * type-stack.h: New file.
9862         * type-stack.c: New file.
9863         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9864         type-stack.h.
9865         (insert_into_type_stack, insert_type, push_type, push_type_int)
9866         (insert_type_address_space, pop_type, pop_type_int)
9867         (pop_typelist, pop_type_stack, append_type_stack)
9868         (push_type_stack, get_type_stack, push_typelist)
9869         (follow_type_instance_flags, follow_types): Don't declare.
9870         * parse.c (type_stack): Remove global.
9871         (parse_exp_in_context): Update.
9872         (insert_into_type_stack, insert_type, push_type, push_type_int)
9873         (insert_type_address_space, pop_type, pop_type_int)
9874         (pop_typelist, pop_type_stack, append_type_stack)
9875         (push_type_stack, get_type_stack, push_typelist)
9876         (follow_type_instance_flags, follow_types): Remove (moved to
9877         type-stack.c).
9878         * f-exp.y (type_stack): New global.
9879         Update rules.
9880         (push_kind_type, f_parse): Update.
9881         * d-exp.y (type_stack): New global.
9882         Update rules.
9883         (d_parse): Update.
9884         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9885         Update rules.
9886         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9887         (HFILES_NO_SRCDIR): Add type-stack.h.
9888
9889 2019-04-04  Tom Tromey  <tom@tromey.com>
9890
9891         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9892         (rust_parser::convert_ast_to_expression, rust_parse)
9893         (rust_lex_test_completion, rust_lex_tests): Update.
9894         * parser-defs.h (struct expr_completion_state): New.
9895         (struct parser_state) <parser_state>: Add completion parameter.
9896         <mark_struct_expression, mark_completion_tag>: New methods.
9897         <parse_completion, m_completion_state>: New members.
9898         (prefixify_expression, null_post_parser): Update.
9899         (mark_struct_expression, mark_completion_tag): Don't declare.
9900         * parse.c (parse_completion, expout_last_struct)
9901         (expout_tag_completion_type, expout_completion_name): Remove
9902         globals.
9903         (parser_state::mark_struct_expression)
9904         (parser_state::mark_completion_tag): Now methods.
9905         (prefixify_expression): Add last_struct parameter.
9906         (prefixify_subexp): Likewise.
9907         (parse_exp_1): Update.
9908         (parse_exp_in_context): Add cstate parameter.  Update.
9909         (parse_expression_for_completion): Create an
9910         expr_completion_state.
9911         (null_post_parser): Add "completion" parameter.
9912         * p-exp.y: Update rules.
9913         (yylex): Update.
9914         * language.h (struct language_defn) <la_post_parser>: Add
9915         "completing" parameter.
9916         * go-exp.y: Update rules.
9917         (lex_one_token): Update.
9918         * expression.h (parse_completion): Don't declare.
9919         * d-exp.y: Update rules.
9920         (lex_one_token): Update rules.
9921         * c-exp.y: Update rules.
9922         (lex_one_token): Update.
9923         * ada-lang.c (resolve): Add "parse_completion" parameter.
9924         (resolve_subexp): Likewise.
9925         (ada_resolve_function): Likewise.
9926
9927 2019-04-04  Tom Tromey  <tom@tromey.com>
9928
9929         * parser-defs.h (struct parser_state) <start_arglist,
9930         end_arglist>: New methods.
9931         <arglist_len, m_funcall_chain>: New members.
9932         (arglist_len, start_arglist, end_arglist): Don't declare.
9933         * parse.c (arglist_len, funcall_chain): Remove global.
9934         (start_arglist, end_arglist): Remove functions.
9935         (parse_exp_in_context): Update.
9936         * p-exp.y: Update rules.
9937         * m2-exp.y: Update rules.
9938         * go-exp.y: Update rules.
9939         * f-exp.y: Update rules.
9940         * d-exp.y: Update rules.
9941         * c-exp.y: Update rules.
9942
9943 2019-04-04  Tom Tromey  <tom@tromey.com>
9944
9945         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9946         lex_operator, push_back>: New methods.
9947         Update all rules.
9948         (rust_parser::lex_hex, lex_escape): Rename and update.
9949         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9950         (rust_parser::lex_operator): Rename and update.
9951         (rust_parser::lex_number, rustyylex, rustyyerror)
9952         (rust_lex_test_init, rust_lex_test_sequence)
9953         (rust_lex_test_push_back, rust_lex_tests): Update.
9954         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9955         parameter.
9956         <lexptr, prev_lexptr>: New members.
9957         (lexptr, prev_lexptr): Don't declare.
9958         * parse.c (lexptr, prev_lexptr): Remove globals.
9959         (parse_exp_in_context): Update.
9960         * p-exp.y (yylex, yyerror): Update.
9961         * m2-exp.y (parse_number, yylex, yyerror): Update.
9962         * go-exp.y (lex_one_token, yyerror): Update.
9963         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9964         * d-exp.y (lex_one_token, yyerror): Update.
9965         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9966         (lex_one_token, yyerror): Update.
9967         * ada-lex.l (YY_INPUT): Update.
9968         (rewind_to_char): Update.
9969         * ada-exp.y (yyerror): Update.
9970
9971 2019-04-04  Tom Tromey  <tom@tromey.com>
9972
9973         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9974         * parser-defs.h (struct parser_state) <parser_state>: Add new
9975         parameter.
9976         <comma_terminates>: New member.
9977         (comma_terminates): Don't declare global.
9978         * parse.c (comma_terminates): Remove global.
9979         (parse_exp_in_context): Update.
9980         * p-exp.y (yylex): Update.
9981         * m2-exp.y (yylex): Update.
9982         * go-exp.y (lex_one_token): Update.
9983         * f-exp.y (yylex): Update.
9984         * d-exp.y (lex_one_token): Update.
9985         * c-exp.y (lex_one_token): Update.
9986         * ada-lex.l: Update.
9987
9988 2019-04-04  Tom Tromey  <tom@tromey.com>
9989
9990         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9991         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9992         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9993         * parser-defs.h (paren_depth): Don't declare.
9994         * parse.c (paren_depth): Remove global.
9995         (parse_exp_in_context): Update.
9996         * p-exp.y (paren_depth): New global.
9997         (pascal_parse): Initialize it.
9998         * m2-exp.y (paren_depth): New global.
9999         (m2_parse): Initialize it.
10000         * go-exp.y (paren_depth): New global.
10001         (go_parse): Initialize it.
10002         * f-exp.y (paren_depth): New global.
10003         (f_parse): Initialize it.
10004         * d-exp.y (paren_depth): New global.
10005         (d_parse): Initialize it.
10006         * c-exp.y (paren_depth): New global.
10007         (c_parse): Initialize it.
10008         * ada-lex.l (paren_depth): New global.
10009         (lexer_init): Initialize it.
10010
10011 2019-04-04  Tom Tromey  <tom@tromey.com>
10012
10013         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10014         (rust_parser::convert_ast_to_type)
10015         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10016         * parser-defs.h (struct parser_state) <parser_state>: Add
10017         parameters.  Initialize new members.
10018         <expression_context_block, expression_context_pc>: New members.
10019         * parse.c (expression_context_block, expression_context_pc):
10020         Remove globals.
10021         (parse_exp_in_context): Update.
10022         * p-exp.y: Update all rules.
10023         (yylex): Update.
10024         * m2-exp.y: Update all rules.
10025         (yylex): Update.
10026         * go-exp.y (yylex): Update.
10027         * f-exp.y (yylex): Update.
10028         * d-exp.y: Update all rules.
10029         (yylex): Update.
10030         * c-exp.y: Update all rules.
10031         (lex_one_token, classify_name, yylex, c_parse): Update.
10032         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10033
10034 2019-04-04  Tom Tromey  <tom@tromey.com>
10035
10036         * gdbarch.h, gdbarch.c: Rebuild.
10037         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10038         * stap-probe.h:
10039         (struct stap_parse_info): Replace "parser_state" with
10040         "expr_builder".
10041         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10042         (parser_state): New class.
10043         * parse.c (expr_builder): Rename.
10044         (expr_builder::release): Rename.
10045         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10046         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10047         (write_exp_elt_longcst, write_exp_elt_floatcst)
10048         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10049         (write_exp_string_vector, write_exp_bitstring)
10050         (write_exp_msymbol, mark_struct_expression)
10051         (write_dollar_variable)
10052         (insert_type_address_space, increase_expout_size): Replace
10053         "parser_state" with "expr_builder".
10054         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10055         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10056         "parser_state" with "expr_builder".
10057
10058 2019-04-04  Tom Tromey  <tom@tromey.com>
10059
10060         * rust-exp.y: Replace "parse_language" with method call.
10061         * p-exp.y:
10062         (yylex): Replace "parse_language" with method call.
10063         * m2-exp.y:
10064         (yylex): Replace "parse_language" with method call.
10065         * go-exp.y (classify_name): Replace "parse_language" with method
10066         call.
10067         * f-exp.y (yylex): Replace "parse_language" with method call.
10068         * d-exp.y (lex_one_token): Replace "parse_language" with method
10069         call.
10070         * c-exp.y:
10071         (lex_one_token, classify_name, yylex): Replace "parse_language"
10072         with method call.
10073         * ada-exp.y (find_primitive_type, type_char)
10074         (type_system_address): Replace "parse_language" with method call.
10075
10076 2019-04-04  Tom Tromey  <tom@tromey.com>
10077
10078         * rust-exp.y: Replace "parse_gdbarch" with method call.
10079         * parse.c (write_dollar_variable, insert_type_address_space):
10080         Replace "parse_gdbarch" with method call.
10081         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10082         call.
10083         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10084         call.
10085         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10086         "parse_gdbarch" with method call.
10087         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10088         with method call.
10089         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10090         "parse_gdbarch" with method call.
10091         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10092         "parse_gdbarch" with method call.
10093         * c-exp.y (parse_type, parse_number, classify_name): Replace
10094         "parse_gdbarch" with method call.
10095         * ada-lex.l: Replace "parse_gdbarch" with method call.
10096         * ada-exp.y (parse_type, find_primitive_type, type_char)
10097         (type_system_address): Replace "parse_gdbarch" with method call.
10098
10099 2019-04-04  Tom Tromey  <tom@tromey.com>
10100
10101         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10102         * stap-probe.c (stap_parse_argument): Update.
10103         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10104         initial_size parameter.
10105         * rust-exp.y (rust_lex_tests): Update.
10106         * parse.c (parser_state): Update.
10107         (parse_exp_in_context): Update.
10108         * parser-defs.h (struct parser_state) <parser_state>: Remove
10109         "initial_size" parameter.
10110
10111 2019-04-04  Tom Tromey  <tom@tromey.com>
10112
10113         * parser-defs.h (increase_expout_size): Don't declare.
10114         * parse.c (increase_expout_size): Now static.
10115
10116 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10117
10118         * gnu-nat.c (gnu_nat_target::wait): Fix
10119         target_waitstatus_to_string call.
10120
10121 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10122
10123         * eval.c (evaluate_subexp_standard): Handle internal functions
10124         during Fortran function call handling.
10125
10126 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10127
10128         * NEWS: Mention new internal functions.
10129         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10130         (read_base_type): Use dwarf2_init_complex_target_type.
10131         * value.c (creal_internal_fn): New function.
10132         (cimag_internal_fn): New function.
10133         (_initialize_values): Register new internal functions.
10134
10135 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10136
10137         * infrun.c (stop_all_threads): If debug_infrun, always
10138         trace the wait status after wait_one, using
10139         target_waitstatus_to_string and target_pid_to_str.
10140         (handle_inferior_event): Replace various trace of
10141         wait status kind by a single trace.
10142         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10143         wait status kind image by target_waitstatus_to_string.
10144         * target/waitstatus.c (target_waitstatus_to_string): Fix
10145         obsolete comment.
10146
10147 2019-04-01  Tom Tromey  <tromey@adacore.com>
10148
10149         PR symtab/23331:
10150         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10151
10152 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10153             Pedro Alves  <palves@redhat.com>
10154
10155         * top.c (quit_force): Call 'finalize_values'.
10156         * value.c (finalize_values): New function.
10157         * value.h (finalize_values): Declare.
10158
10159 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10160
10161         * NEWS: Announce $_gdb_major and $_gdb_minor.
10162
10163         * top.c (init_gdb_version_vars): New function.
10164         (gdb_init): Call init_gdb_version_vars.
10165
10166 2019-03-29  Tom Tromey  <tromey@adacore.com>
10167
10168         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10169         help text.  Remove dead code.
10170
10171 2019-03-29  Keith Seitz  <keiths@redhat.com>
10172
10173         From Siddhesh Poyarekar:
10174         * f-lang.h (f77_get_upperbound): Return LONGEST.
10175         (f77_get_lowerbound): Likewise.
10176         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10177         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10178         print them.
10179         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10180         plongest to format print it.
10181         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10182         (f77_get_upperbound): Likewise.
10183         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10184         LOWER_BOUND to LONGEST.
10185         (f77_create_arrayprint_offset_tbl): Likewise.
10186
10187 2019-03-29  Keith Seitz  <keiths@redhat.com>
10188
10189         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10190         %s/pulongest for TYPE_LENGTH instead of %d in format
10191         strings.
10192         * ada-typerint.c (ada_print_type): Likewise.
10193         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10194         * compile/compile-c-support.c (generate_register_struct): Likewise.
10195         * gdbtypes.c (recursive_dump_type): Likewise.
10196         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10197         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10198         instead of %d in format strings.
10199         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10200         to std::min to ULONGEST.
10201         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10202         instead of %d in format strings.
10203         * tracepoint.c (info_scope_command): Likewise.
10204         * typeprint.c (print_offset_data::update)
10205         (print_offset_data::finish): Likewise.
10206         * xtensa-tdep.c (xtensa_store_return_value)
10207         (xtensa_push_dummy_call): Likewise.
10208
10209 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10210
10211         * windows-nat.c (display_selector): Fixed format specifications
10212         for 64-bit Cygwin.
10213
10214 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10215
10216         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10217
10218 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10219
10220         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10221         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10222         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10223         (nios2_linux_init_abi): Install it.
10224
10225 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10226
10227         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10228
10229 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10230
10231         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10232
10233 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10234             Tom Tromey  <tromey@adacore.com>
10235
10236         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10237
10238 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10239
10240         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10241         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10242         method to compute the bounds of range types. Also print "[evaluated]"
10243         if the bounds' values come from a dynamic evaluation.
10244
10245 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10246
10247         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10248         whitespace when pretty printing is on.
10249
10250 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10251
10252         * ppc-linux-nat.c: Add include.
10253
10254 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10255
10256         * NEWS: Mention AArch64 Pointer Authentication.
10257
10258 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10259
10260         * arm-linux-nat.c: Add include.
10261
10262 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10263
10264         * source-cache.c (source_cache::get_source_lines): Re-read
10265         fullname after calling open_source_file.
10266
10267 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10268
10269         * NEWS: Mention TLS support for FreeBSD.
10270
10271 2019-03-25  Tom Tromey  <tromey@adacore.com>
10272
10273         * minsyms.c (BUNCH_SIZE): Update comment.
10274         (~minimal_symbol_reader): Remove old comment.
10275         (compact_minimal_symbols): Update comment.
10276         (minimal_symbol_reader::install): Remove old comment.  Update
10277         other comments.
10278
10279 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10280
10281         * s390-linux-nat.c: Add include.
10282
10283 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10284
10285         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10286         Call linux_get_hwcap.
10287         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10288         Likewise.
10289         (aarch64_linux_get_hwcap): Remove function.
10290         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10291         declaration.
10292         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10293         linux_get_hwcap.
10294         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10295         * linux-tdep.c (linux_get_hwcap): Add function.
10296         (linux_get_hwcap2): Likewise.
10297         * linux-tdep.h (linux_get_hwcap): Add declaration.
10298         (linux_get_hwcap2): Likewise.
10299         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10300         (ppc_linux_get_hwcap2): Likewise.
10301         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10302         linux_get_hwcap.
10303         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10304         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10305         (ppc_linux_nat_target::read_description): Likewise.
10306         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10307         * s390-linux-nat.c: Likewise.
10308         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10309
10310 2019-03-24  Tom Tromey  <tom@tromey.com>
10311
10312         * ada-lang.c (standard_lookup): Simplify initialization.
10313         (ada_lookup_symbol_nonlocal): Simplify return.
10314         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10315         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10316         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10317         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10318         initialization.
10319         * solib.c (solib_global_lookup): Simplify.
10320         * symtab.c (null_block_symbol): Remove.
10321         (symbol_cache_lookup): Simplify returns.
10322         (lookup_language_this): Simplify returns.
10323         (lookup_symbol_aux): Simplify return.
10324         (lookup_local_symbol): Simplify returns.
10325         (lookup_global_symbol_from_objfile): Simplify return.
10326         (lookup_symbol_in_objfile_symtabs)
10327         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10328         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10329         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10330         * cp-namespace.c (cp_lookup_bare_symbol)
10331         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10332         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10333         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10334         (cp_lookup_symbol_via_imports): Simplify initialization.
10335         (find_symbol_in_baseclass): Likewise.
10336         * symtab.h (null_block_symbol): Remove.
10337         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10338         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10339         (d_lookup_symbol_module): Likewise.
10340         (find_symbol_in_baseclass): Simplify initialization.
10341
10342 2019-03-24  Tom Tromey  <tom@tromey.com>
10343
10344         * expression.h: Don't include symtab.h.
10345         (struct block): Forward declare.
10346
10347 2019-03-24  Tom Tromey  <tom@tromey.com>
10348
10349         * c-exp.y (typebase): Remove casts.
10350         * gdbtypes.c (lookup_unsigned_typename, )
10351         (lookup_signed_typename): Remove cast.
10352         * eval.c (parse_to_comma_and_eval): Remove cast.
10353         * parse.c (write_dollar_variable): Remove cast.
10354         * block.h (struct block) <superblock>: Now const.
10355         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10356         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10357         (map_block): Make "block" const.
10358         * symfile.h (struct quick_symbol_functions)
10359         <map_matching_symbols>: Constify block argument to "callback".
10360         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10361         const.
10362         (find_pc_sect_compunit_symtab): Make "b" const.
10363         (find_symbol_at_address): Likewise.
10364         (search_symbols): Likewise.
10365         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10366         (dw2_debug_names_lookup_symbol): Likewise.
10367         (dw2_map_matching_symbols): Update.
10368         * p-valprint.c (pascal_val_print): Remove "block".
10369         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10370         (aux_add_nonlocal_symbols): Make "block" const.
10371         (resolve_subexp): Remove cast.
10372         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10373         const.
10374         (iterate_over_file_blocks): Likewise.
10375         * f-exp.y (%union) <bval>: Remove.
10376         * coffread.c (patch_opaque_types): Make "b" const.
10377         * spu-tdep.c (spu_catch_start): Make "block" const.
10378         * c-valprint.c (print_unpacked_pointer): Remove "block".
10379         * symmisc.c (dump_symtab_1): Make "b" const.
10380         (block_depth): Make "block" const.
10381         * d-exp.y (%union) <bval>: Remove.
10382         * cp-support.h (cp_lookup_rtti_type): Update.
10383         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10384         * psymtab.c (psym_lookup_symbol): Make "block" const.
10385         (maintenance_check_psymtabs): Make "b" const.
10386         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10387         (enumerate_locals, enumerate_args): Update.
10388         * python/py-symtab.c (stpy_global_block): Make "block" const.
10389         (stpy_static_block): Likewise.
10390         * inline-frame.c (block_starting_point_at): Make "new_block"
10391         const.
10392         * block.c (find_block_in_blockvector): Make return type const.
10393         (blockvector_for_pc_sect): Make "b" const.
10394         (find_block_in_blockvector): Make "b" const.
10395
10396 2019-03-23  Tom Tromey  <tom@tromey.com>
10397
10398         * varobj.c (varobj_create): Update.
10399         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10400         * printcmd.c (display_command, do_one_display): Don't reset
10401         innermost_block.
10402         * parser-defs.h (enum innermost_block_tracker_type): Move to
10403         expression.h.
10404         (innermost_block): Update comment.
10405         * parse.c (parse_exp_1): Add tracker_types parameter.
10406         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10407         tracker_types parameter.  Reset innermost_block.
10408         (parse_exp_in_context): Remove.
10409         (parse_expression_for_completion): Update.
10410         * objfiles.c (~objfile): Don't reset expression_context_block or
10411         innermost_block.
10412         * expression.h (enum innermost_block_tracker_type): Move from
10413         parser-defs.h.
10414         (parse_exp_1): Add tracker_types parameter.
10415         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10416         reset innermost_block.
10417
10418 2019-03-23  Tom Tromey  <tom@tromey.com>
10419
10420         * objfiles.h: Include bcache.h.
10421
10422 2019-03-23  Tom Tromey  <tom@tromey.com>
10423
10424         * linespec.c (get_current_search_block): Use
10425         scoped_restore_current_language.
10426         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10427
10428 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10429             Jiong Wang  <jiong.wang@arm.com>
10430
10431         * aarch64-linux-tdep.c
10432         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10433         section.
10434         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10435
10436 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10437             Jiong Wang  <jiong.wang@arm.com>
10438
10439         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10440         instructions.
10441         (aarch64_analyze_prologue_test): Add PACIASP test.
10442         (aarch64_prologue_prev_register): Unmask PC value.
10443
10444 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10445             Jiong Wang  <jiong.wang@arm.com>
10446
10447         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10448         (aarch64_dwarf2_prev_register): Unmask PC value.
10449         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10450         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10451         DW_CFA_AARCH64_negate_ra_state.
10452         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10453
10454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10455             Jiong Wang  <jiong.wang@arm.com>
10456
10457         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10458         registers.
10459         (aarch64_pseudo_register_name): Likewise.
10460         (aarch64_pseudo_register_type): Likewise.
10461         (aarch64_pseudo_register_reggroup_p): Likewise.
10462         (aarch64_gdbarch_init): Add pauth registers.
10463         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10464         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10465         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10466         (struct gdbarch_tdep): Add regnum for ra_state.
10467
10468 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10469             Jiong Wang  <jiong.wang@arm.com>
10470
10471         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10472
10473 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10474             Jiong Wang  <jiong.wang@arm.com>
10475
10476         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10477         function.
10478         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10479         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10480         (aarch64_gdbarch_init): Add puth registers.
10481         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10482         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10483         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10484
10485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10486             Jiong Wang  <jiong.wang@arm.com>
10487
10488         * aarch64-linux-nat.c
10489         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10490         * aarch64-linux-tdep.c
10491         (aarch64_linux_core_read_description): Likewise.
10492         (aarch64_linux_get_hwcap): New function.
10493         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10494         (aarch64_linux_get_hwcap): New declaration.
10495
10496 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10497             Jiong Wang  <jiong.wang@arm.com>
10498
10499         * aarch64-linux-nat.c
10500         (aarch64_linux_nat_target::read_description): Add pauth param.
10501         * aarch64-linux-tdep.c
10502         (aarch64_linux_core_read_description): Likewise.
10503         * aarch64-tdep.c (struct target_desc): Add in pauth.
10504         (aarch64_read_description): Add pauth param.
10505         (aarch64_gdbarch_init): Likewise.
10506         * aarch64-tdep.h (aarch64_read_description): Likewise.
10507         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10508         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10509         * features/Makefile: Add new files.
10510         * features/aarch64-pauth.c: New file.
10511         * features/aarch64-pauth.xml: New file.
10512
10513 2019-03-20  Tom Tromey  <tromey@adacore.com>
10514
10515         * infrun.c (handle_inferior_event): Rename from
10516         handle_inferior_event_1.  Create a scoped_value_mark.
10517         (handle_inferior_event): Remove.
10518
10519 2019-03-19  Tom Tromey  <tromey@adacore.com>
10520
10521         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10522         * infrun.h (print_stop_event): Add "displays" parameter.
10523         * infrun.c (print_stop_event): Add "displays" parameter.
10524
10525 2019-03-19  Pedro Alves  <palves@redhat.com>
10526
10527         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10528         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10529         to -1.  Fix TABs vs spaces.
10530         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10531         * tui/tui-out.h (tui_ui_out) Add intro comments.
10532         <m_line, m_start_of_line>: In-class initialize, and add describing
10533         comment.
10534
10535 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10536
10537         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10538         variable names.
10539         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10540
10541 2019-03-18  Pedro Alves  <palves@redhat.com>
10542             Eli Zaretskii <eliz@gnu.org>
10543
10544         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10545         m_line and m_start_of_line.
10546
10547 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10548
10549         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10550         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10551         it returns a newline.  This fixes a regression in TU mode, whereby
10552         the next line is output on the same screen line as the user input.
10553
10554 2019-03-18  Tom Tromey  <tromey@adacore.com>
10555
10556         * minsyms.c (minimal_symbol_reader::install): Remove call to
10557         obstack_blank.
10558
10559 2019-03-18  Pedro Alves  <palves@redhat.com>
10560
10561         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10562         New globals.
10563         (apply_style): New, factored out from ...
10564         (apply_ansi_escape): ... this.  Handle reverse video mode.
10565         (tui_set_reverse_mode): New function.
10566         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10567         * tui/tui-winsource.c (tui_show_source_line): Use
10568         tui_set_reverse_mode instead of setting A_STANDOUT.
10569         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10570         New setter methods.
10571
10572 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10573
10574         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10575         Handle tabs.
10576
10577 2019-03-18  Tom Tromey  <tromey@adacore.com>
10578
10579         * ada-lang.c (empty_array): Add "high" parameter.
10580         (ada_evaluate_subexp): Update.
10581
10582 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10583
10584         * unittests/string_view-selftests.c: Define
10585         _initialize_string_view_selftests unconditionally.
10586
10587 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10588
10589         PR gdb/24350
10590         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10591
10592 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10593
10594         PR gdb/24351
10595         * windows-nat.c (display_selector): Fix format specifiers.
10596
10597 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10598
10599         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10600         tui_refill_source_window instead of tui_refresh_win, to update the
10601         current execution line.  This fixes redisplay of the current line
10602         when stepping through the code with "next" or "step".
10603
10604 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10605
10606         * source-cache.c (source_cache::get_source_lines): Call
10607         find_source_lines to initialize s->nlines.  This fixes vertical
10608         scrolling of TUI source window when the DOWN arrow is pressed.
10609
10610 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10611
10612         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10613         linux-thread-db.c (_initialize_thread_db): Likewise.
10614
10615 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10616
10617         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10618         wclrtoeol in tui_show_source_line".  This reverts changes made in
10619         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10620
10621 2019-03-15  Tom Tromey  <tom@tromey.com>
10622
10623         * symtab.h (struct minimal_symbol): Derive from
10624         general_symbol_info.
10625         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10626         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10627         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10628         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10629         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10630         (MSYMBOL_SEARCH_NAME): Update.
10631         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10632         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10633         * minsyms.c (minimal_symbol_reader::record_full): Update.
10634
10635 2019-03-15  Tom Tromey  <tom@tromey.com>
10636
10637         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10638
10639 2019-03-15  Tom Tromey  <tom@tromey.com>
10640
10641         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10642         unique_xmalloc_ptr.
10643         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10644         Update.
10645         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10646         (build_minimal_symbol_hash_tables)
10647         (minimal_symbol_reader::install): Update.
10648
10649 2019-03-15  Tom Tromey  <tom@tromey.com>
10650
10651         * symtab.c (create_demangled_names_hash): Update.
10652         (symbol_set_names): Update.
10653         * objfiles.h (struct objfile_per_bfd_storage)
10654         <demangled_names_hash>: Now an htab_up.
10655         * objfiles.c (objfile_per_bfd_storage): Simplify.
10656
10657 2019-03-15  Tom Tromey  <tom@tromey.com>
10658
10659         * objfiles.h (struct objfile_per_bfd_storage): Declare
10660         destructor.
10661         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10662         New.
10663         (get_objfile_bfd_data): Use new.  Don't initialize
10664         language_of_main.
10665         (free_objfile_per_bfd_storage): Remove.
10666         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10667
10668 2019-03-15  Tom Tromey  <tom@tromey.com>
10669
10670         * symfile.c (reread_symbols): Update.
10671         * objfiles.c (objfile::objfile): Update.
10672         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10673         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10674         comment.
10675         (minimal_symbol_reader::install): Update.
10676         (terminate_minimal_symbol_table): Remove.
10677         * jit.c (jit_object_close_impl): Update.
10678
10679 2019-03-15  Tom Tromey  <tom@tromey.com>
10680
10681         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10682         initializations.
10683
10684 2019-03-15  Tom Tromey  <tom@tromey.com>
10685
10686         * objfiles.h (struct objfile_per_bfd_storage)
10687         <demangled_hash_languages>: Now a bitset.
10688         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10689         (lookup_minimal_symbol): Update.
10690
10691 2019-03-15  Tom Tromey  <tom@tromey.com>
10692
10693         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10694         Don't return the symbol.
10695         * coffread.c (record_minimal_symbol): Use record_full.
10696
10697 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10698
10699         The MS-Windows port of ncurses fails to switch to a color pair if
10700         one or both of the colors are the implicit default colors.  This
10701         change records the default colors when TUI is initialized, and
10702         then specifies them explicitly when a color pair uses the default
10703         colors.  This allows color styling in TUI mode on MS-Windows.
10704
10705         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10706         ncurses_norm_attr.
10707         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10708         colors in ncurses_norm_attr.
10709         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10710         "none", replace it with the default color recorded in
10711         ncurses_norm_attr.
10712
10713 2019-03-14  Tom Tromey  <tromey@adacore.com>
10714
10715         * source-cache.h (class source_cache) <get_source_lines>: Return
10716         std::string.
10717         * source-cache.c (source_cache::extract_lines): Handle case where
10718         first_pos==npos.  Return std::string.
10719         (source_cache::get_source_lines): Update.
10720
10721 2019-03-14  Tom Tromey  <tromey@adacore.com>
10722
10723         * NEWS: Add item for "style sources" commands.
10724         * source-cache.c (source_cache::get_source_lines): Check
10725         source_styling.
10726         * cli/cli-style.c (source_styling): New global.
10727         (_initialize_cli_style): Add "style sources" commands.
10728         (show_style_sources): New function.
10729         * cli/cli-style.h (source_styling): Declare.
10730
10731 2019-03-14  Pedro Alves  <palves@redhat.com>
10732             Tom Tromey  <tromey@adacore.com>
10733
10734         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10735         * tui/tui-winsource.c (tui_refill_source_window): New function,
10736         from...
10737         (tui_horizontal_source_scroll): ... here.  Move some logic.
10738         * cli/cli-style.c (set_style_enabled): Notify new observable.
10739         * tui/tui-hooks.c (tui_redisplay_source): New function.
10740         (tui_attach_detach_observers): Attach or detach
10741         tui_redisplay_source.
10742         * observable.h (source_styling_changed): New observable.
10743         * observable.c: Define source_styling_changed observable.
10744
10745 2019-03-13  Tom Tromey  <tromey@adacore.com>
10746
10747         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10748         (i386_gnu_nat_target::store_registers): Update.
10749         * target-debug.h (target_debug_print_std_string): New macro.
10750         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10751         * windows-tdep.c (display_one_tib): Update.
10752         * tui/tui-stack.c (tui_make_status_line): Update.
10753         * top.c (print_inferior_quit_action): Update.
10754         * thread.c (thr_try_catch_cmd): Update.
10755         (add_thread_with_info): Update.
10756         (thread_target_id_str): Update.
10757         (thr_try_catch_cmd): Update.
10758         (thread_command): Update.
10759         (thread_find_command): Update.
10760         * record-btrace.c (record_btrace_target::info_record)
10761         (record_btrace_resume_thread, record_btrace_target::resume)
10762         (record_btrace_cancel_resume, record_btrace_step_thread)
10763         (record_btrace_target::wait, record_btrace_target::wait)
10764         (record_btrace_target::wait, record_btrace_target::stop): Update.
10765         * progspace.c (print_program_space): Update.
10766         * process-stratum-target.c
10767         (process_stratum_target::thread_address_space): Update.
10768         * linux-fork.c (linux_fork_mourn_inferior)
10769         (detach_checkpoint_command, info_checkpoints_command)
10770         (linux_fork_context): Update.
10771         (linux_fork_detach): Update.
10772         (class scoped_switch_fork_info): Update.
10773         (delete_checkpoint_command): Update.
10774         * infrun.c (follow_fork_inferior): Update.
10775         (follow_fork_inferior): Update.
10776         (proceed_after_vfork_done): Update.
10777         (handle_vfork_child_exec_or_exit): Update.
10778         (follow_exec): Update.
10779         (displaced_step_prepare_throw): Update.
10780         (displaced_step_restore): Update.
10781         (start_step_over): Update.
10782         (resume_1): Update.
10783         (clear_proceed_status_thread): Update.
10784         (proceed): Update.
10785         (print_target_wait_results): Update.
10786         (do_target_wait): Update.
10787         (context_switch): Update.
10788         (stop_all_threads): Update.
10789         (restart_threads): Update.
10790         (finish_step_over): Update.
10791         (handle_signal_stop): Update.
10792         (switch_back_to_stepped_thread): Update.
10793         (keep_going_pass_signal): Update.
10794         (print_exited_reason): Update.
10795         (normal_stop): Update.
10796         * inferior.c (inferior_pid_to_str): Change return type.
10797         (print_selected_inferior): Update.
10798         (add_inferior): Update.
10799         (detach_inferior): Update.
10800         * dummy-frame.c (fprint_dummy_frames): Update.
10801         * dcache.c (dcache_info_1): Update.
10802         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10803         (btrace_fetch, btrace_clear): Update.
10804         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10805         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10806         type.
10807         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10808         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10809         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10810         * gdbarch.c, gdbarch.h: Rebuild.
10811         * gdbarch.sh (core_pid_to_str): Change return type.
10812         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10813         return type.
10814         (windows_nat_target::pid_to_str): Change return type.
10815         (windows_delete_thread): Update.
10816         (windows_nat_target::attach): Update.
10817         (windows_nat_target::files_info): Update.
10818         * target-delegates.c: Rebuild.
10819         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10820         return type.
10821         (sol_thread_target::pid_to_str): Change return type.
10822         * remote.c (class remote_target) <pid_to_str>: Change return
10823         type.
10824         (remote_target::pid_to_str): Change return type.
10825         (extended_remote_target::attach, remote_target::remote_stop_ns)
10826         (remote_target::remote_notif_remove_queued_reply)
10827         (remote_target::push_stop_reply, remote_target::disable_btrace):
10828         Update.
10829         (extended_remote_target::attach): Update.
10830         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10831         type.
10832         (gdbsim_target::pid_to_str): Change return type.
10833         * ravenscar-thread.c (struct ravenscar_thread_target)
10834         <pid_to_str>: Change return type.
10835         (ravenscar_thread_target::pid_to_str): Change return type.
10836         * procfs.c (class procfs_target) <pid_to_str>: Change return
10837         type.
10838         (procfs_target::pid_to_str): Change return type.
10839         (procfs_target::attach): Update.
10840         (procfs_target::detach): Update.
10841         (procfs_target::fetch_registers): Update.
10842         (procfs_target::store_registers): Update.
10843         (procfs_target::wait): Update.
10844         (procfs_target::files_info): Update.
10845         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10846         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10847         return type.
10848         (nto_procfs_target::pid_to_str): Change return type.
10849         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10850         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10851         return type.
10852         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10853         (exit_lwp): Update.
10854         (attach_proc_task_lwp_callback, get_detach_signal)
10855         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10856         (linux_nat_target::resume, wait_lwp, stop_callback)
10857         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10858         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10859         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10860         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10861         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10862         type.
10863         (inf_ptrace_target::attach): Update.
10864         (inf_ptrace_target::files_info): Update.
10865         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10866         type.
10867         (go32_nat_target::pid_to_str): Change return type.
10868         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10869         (gnu_nat_target::wait): Update.
10870         (gnu_nat_target::wait): Update.
10871         (gnu_nat_target::resume): Update.
10872         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10873         (fbsd_nat_target::wait): Update.
10874         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10875         type.
10876         (darwin_nat_target::attach): Update.
10877         * corelow.c (class core_target) <pid_to_str>: Change return type.
10878         (core_target::pid_to_str): Change return type.
10879         * target.c (normal_pid_to_str): Change return type.
10880         (default_pid_to_str): Likewise.
10881         (target_pid_to_str): Change return type.
10882         (target_translate_tls_address): Update.
10883         (target_announce_detach): Update.
10884         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10885         return type.
10886         (bsd_uthread_target::pid_to_str): Change return type.
10887         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10888         type.
10889         (bsd_kvm_target::pid_to_str): Change return type.
10890         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10891         return type.
10892         (aix_thread_target::pid_to_str): Change return type.
10893         * target.h (struct target_ops) <pid_to_str>: Change return type.
10894         (target_pid_to_str, normal_pid_to_str): Likewise.
10895         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10896         type.
10897         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10898         type.
10899         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10900         return type.
10901         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10902         type.
10903         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10904         type.
10905         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10906         return type.
10907
10908 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10909
10910         * NEWS: Mention that the new default MI version is 3.  Mention
10911         changes to the output of commands and events that deal with
10912         multi-location breakpoints.
10913         * breakpoint.c: Include "mi/mi-out.h".
10914         (print_one_breakpoint): Change output syntax if using MI version
10915         >= 3.
10916         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10917         New.
10918         (mi_multi_location_breakpoint_output_fixed): New.
10919         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10920         (mi_cmd_fix_multi_location_breakpoint_output): New.
10921         (mi_multi_location_breakpoint_output_fixed): New.
10922         * mi/mi-cmds.c (mi_cmds): Register command
10923         -fix-multi-location-breakpoint-output.
10924         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10925         interpreter "mi".
10926
10927 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10928
10929         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10930         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10931         instantiate mi_ui_out based on interpreter name.
10932         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10933         * mi/mi-main.c (mi_load_progress): Likewise.
10934
10935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10936
10937         * NEWS: Combine separate "New targets" sections for 8.3.
10938
10939 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10940
10941         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10942         (ppcfbsd_init_abi): Install gdbarch
10943         "fetch_tls_load_module_address" and "get_thread_local_address"
10944         methods.
10945
10946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10947
10948         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10949         (riscv_fbsd_init_abi): Install gdbarch
10950         "fetch_tls_load_module_address" and "get_thread_local_address"
10951         methods.
10952
10953 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10954
10955         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10956         (i386fbsd_init_abi): Install gdbarch
10957         "fetch_tls_load_module_address" and "get_thread_local_address"
10958         methods.
10959
10960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10961
10962         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10963         (amd64fbsd_init_abi): Install gdbarch
10964         "fetch_tls_load_module_address" and "get_thread_local_address"
10965         methods.
10966
10967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10968
10969         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10970         (struct fbsd_pspace_data): New type.
10971         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10972         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10973         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10974         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10975         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10976
10977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10978
10979         * gdbtypes.c (lookup_struct_elt): New function.
10980         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10981         * gdbtypes.h (struct struct_elt): New type.
10982         (lookup_struct_elt): New prototype.
10983
10984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10985
10986         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10987         remove disabled code block.
10988
10989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10990
10991         * gdbarch.sh (get_thread_local_address): New method.
10992         * gdbarch.h, gdbarch.c: Regenerate.
10993         * target.c (target_translate_tls_address): Use
10994         gdbarch_get_thread_local_address if present instead of
10995         target::get_thread_local_address.
10996
10997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10998
10999         * target.h (target::get_thread_local_address): Update comment.
11000
11001 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11002
11003         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11004         objfile->separate_debug_objfile_backlink if not NULL.
11005
11006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11007
11008         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11009         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11010         (amd64bsd_store_inferior_registers): Likewise.
11011         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11012         Enable segment base registers.
11013         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11014         PT_GETFSBASE and PT_GETGSBASE.
11015         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11016         PT_SETGSBASE.
11017         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11018         segment base registers.
11019         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11020
11021 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11022
11023         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11024         Update calls to i386_target_description to add 'segments'
11025         parameter.
11026         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11027         add segment base registers.
11028         * arch/i386.c (i386_create_target_description): Add 'segments'
11029         parameter to enable segment base registers.
11030         * arch/i386.h (i386_create_target_description): Likewise.
11031         * features/i386/32bit-segments.xml: New file.
11032         * features/i386/32bit-segments.c: Generate.
11033         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11034         call to i386_target_description to add 'segments' parameter.
11035         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11036         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11037         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11038         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11039         if feature is present.
11040         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11041         Add 'segments' parameter to call to i386_target_description.
11042         (i386_target_description): Add 'segments' parameter to enable
11043         segment base registers.
11044         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11045         to call to i386_target_description.
11046         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11047         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11048         Define I386_NUM_REGS.
11049         (i386_target_description): Add 'segments' parameter to enable
11050         segment base registers.
11051
11052 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11053
11054         PR/24325
11055         * source-cache.c: #undef open and close, to avoid unresolved
11056         externals during linking.
11057
11058 2019-03-12  Tom Tromey  <tromey@adacore.com>
11059
11060         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11061         const.  Add initializers.
11062         (_initialize_remote): Don't initialize ptid globals.
11063
11064 2019-03-12  Pedro Alves  <palves@redhat.com>
11065
11066         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11067
11068 2019-03-12  Pedro Alves  <palves@redhat.com>
11069
11070         * cp-name-parser.y (main): Remove unused 'len' variable.
11071
11072 2019-03-12  Tom Tromey  <tromey@adacore.com>
11073
11074         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11075         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11076
11077 2019-03-12  Tom Tromey  <tromey@adacore.com>
11078
11079         * linux-nat.c (iterate_over_lwps): Update.
11080         (stop_callback): Remove parameter.
11081         (stop_wait_callback, detach_callback, resume_set_callback)
11082         (select_singlestep_lwp_callback, set_ignore_sigint)
11083         (status_callback, resumed_callback, resume_clear_callback)
11084         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11085         data parameter.
11086         (linux_nat_target::detach, linux_nat_target::resume)
11087         (linux_stop_and_wait_all_lwps, select_event_lwp)
11088         (linux_nat_filter_event, linux_nat_wait_1)
11089         (linux_nat_target::kill, linux_nat_target::stop)
11090         (linux_nat_target::stop): Update.
11091         (linux_nat_resume_callback): Change type.
11092         (resume_stopped_resumed_lwps, count_events_callback)
11093         (select_event_lwp_callback): Likewise.
11094         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11095         * arm-linux-nat.c (struct update_registers_data): Remove.
11096         (update_registers_callback): Change type.
11097         (arm_linux_insert_hw_breakpoint1): Update.
11098         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11099         parameter.
11100         (x86_linux_dr_set_addr): Update.
11101         (x86_linux_dr_set_control): Update.
11102         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11103         (iterate_over_lwps): Use gdb::function_view.
11104         * nat/aarch64-linux-hw-point.c (struct
11105         aarch64_dr_update_callback_param): Remove.
11106         (debug_reg_change_callback): Change type.
11107         (aarch64_notify_debug_reg_change): Update.
11108         * s390-linux-nat.c (s390_refresh_per_info): Update.
11109
11110 2019-03-11  Tom Tromey  <tromey@adacore.com>
11111
11112         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11113         redundant assignment to "this_cu".
11114
11115 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11116
11117         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11118
11119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11120
11121         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11122         from...
11123         (rank_one_type): ... this.
11124
11125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11126
11127         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11128         from...
11129         (rank_one_type): ... this.
11130
11131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11132
11133         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11134         from...
11135         (rank_one_type): ... this.
11136
11137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11138
11139         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11140         from...
11141         (rank_one_type): ... this.
11142
11143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11144
11145         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11146         from...
11147         (rank_one_type): ... this.
11148
11149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11150
11151         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11152         from...
11153         (rank_one_type): ... this.
11154
11155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11156
11157         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11158         from...
11159         (rank_one_type): ... this.
11160
11161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11162
11163         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11164         from...
11165         (rank_one_type): ... this.
11166
11167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11168
11169         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11170         from...
11171         (rank_one_type): ... this.
11172
11173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11174
11175         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11176         from...
11177         (rank_one_type): ... this.
11178
11179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11180
11181         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11182         from...
11183         (rank_one_type): ... this.
11184
11185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11186
11187         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11188         from...
11189         (rank_one_type): ... this.
11190
11191 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11192
11193         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11194         inferior-events' shows the example events.
11195
11196 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11197
11198         Support styling on native MS-Windows console
11199
11200         PR/24315
11201         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11202         on MS-Windows if $TERM is not defined.
11203
11204         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11205
11206         * posix-hdep.c (gdb_console_fputs):
11207         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11208         functions.
11209         * ui-file.h (gdb_console_fputs): Add prototype.
11210
11211         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11212         back to fputs only if the former returns zero.
11213
11214 2019-03-07  Tom Tromey  <tom@tromey.com>
11215
11216         * symmisc.c (print_symbol_bcache_statistics): Update.
11217         (print_objfile_statistics): Update.
11218         * symfile.c (allocate_symtab): Update.
11219         * stabsread.c: Don't include bcache.h.
11220         * psymtab.h (struct psymbol_bcache): Don't declare.
11221         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11222         (psymbol_bcache_init, psymbol_bcache_free)
11223         (psymbol_bcache_get_bcache): Don't declare.
11224         * psymtab.c (struct psymbol_bcache): Remove.
11225         (psymtab_storage::psymtab_storage): Update.
11226         (psymtab_storage::~psymtab_storage): Update.
11227         (psymbol_bcache_init, psymbol_bcache_free)
11228         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11229         (add_psymbol_to_bcache): Update.
11230         (allocate_psymtab): Update.
11231         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11232         macro_cache>: No longer pointers.
11233         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11234         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11235         * macrotab.c (macro_bcache): Update.
11236         * macroexp.c: Don't include bcache.h.
11237         * gdbtypes.c (check_types_worklist): Update.
11238         (types_deeply_equal): Remove TRY/CATCH.  Update.
11239         * elfread.c (elf_symtab_read): Update.
11240         * dwarf2read.c: Don't include bcache.h.
11241         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11242         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11243         (print_bcache_statistics, bcache_memory_used): Don't declare.
11244         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11245         methods.  Rename all data members.
11246         * bcache.c (struct bcache): Move to bcache.h.
11247         (bcache::expand_hash_table): Rename from expand_hash_table.
11248         (bcache): Remove.
11249         (bcache::insert): Rename from bcache_full.
11250         (bcache::compare): Rename from bcache_compare.
11251         (bcache_xmalloc): Remove.
11252         (bcache::~bcache): Rename from bcache_xfree.
11253         (bcache::print_statistics): Rename from print_bcache_statistics.
11254         (bcache::memory_used): Rename from bcache_memory_used.
11255
11256 2019-03-07  Pedro Alves  <palves@redhat.com>
11257
11258         * infrun.c (normal_stop): Also check for
11259         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11260
11261 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11262
11263         * f-lang.c (value_from_host_double): Moved to...
11264         * value.c (value_from_host_double): ...here.
11265         * value.h (value_from_host_double): Declare.
11266         * guile/scm-math.c (vlscm_convert_typed_number): Use
11267         value_from_host_double.
11268         (vlscm_convert_number): Likewise.
11269         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11270         * python/py-value.c (convert_value_from_python): Likewise.
11271
11272 2019-03-06  Tom Tromey  <tom@tromey.com>
11273
11274         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11275
11276 2019-03-06  Tom Tromey  <tom@tromey.com>
11277
11278         * utils.h (free_current_contents): Don't declare.
11279         * utils.c (free_current_contents): Remove.
11280
11281 2019-03-06  Tom Tromey  <tom@tromey.com>
11282
11283         * top.c (quit_force): Update.
11284         * main.c (captured_command_loop): Update.
11285         * common/new-op.c (operator new): Update.
11286         * common/common-exceptions.c (struct catcher)
11287         <save_cleanup_chain>: Remove member.
11288         (exceptions_state_mc_init): Update.
11289         (exception_try_scope_entry): Return nullptr.
11290         (exception_try_scope_exit, exception_rethrow)
11291         (throw_exception_sjlj, throw_exception_cxx): Update.
11292         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11293         (all_cleanups, do_cleanups, discard_cleanups)
11294         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11295         (restore_cleanups, restore_final_cleanups): Don't declare.
11296         (do_final_cleanups): Remove parameter.
11297         * common/cleanups.c (cleanup_chain, make_cleanup)
11298         (make_cleanup_dtor, all_cleanups, do_cleanups)
11299         (discard_my_cleanups, discard_cleanups)
11300         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11301         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11302         (null_cleanup): Remove.
11303         (do_final_cleanups): Remove parameter.
11304
11305 2019-03-06  Tom Tromey  <tom@tromey.com>
11306
11307         * remote.c (remote_target::remote_parse_stop_reply): Use
11308         unique_xmalloc_ptr.
11309
11310 2019-03-06  Tom Tromey  <tom@tromey.com>
11311
11312         * stabsread.c (struct stabs_field_info): Rename from field_info.
11313         <list, fnlist>: Add initializers.
11314         <obstack>: New member.
11315         (read_member_functions, read_struct_fields, read_baseclasses):
11316         Allocate on obstack.  Don't use cleanups.
11317         (read_one_struct_field, read_member_functions, read_struct_fields)
11318         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11319         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11320         (read_struct_type): Update.
11321
11322 2019-03-06  Tom Tromey  <tom@tromey.com>
11323
11324         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11325         * common/filestuff.h (make_cleanup_close): Don't declare.
11326         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11327         Remove.
11328
11329 2019-03-06  Tom Tromey  <tom@tromey.com>
11330
11331         * solib-aix.c: Use make_scope_exit.
11332
11333 2019-03-06  Tom Tromey  <tom@tromey.com>
11334
11335         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11336         Use make_scope_exit.
11337
11338 2019-03-06  Tom Tromey  <tom@tromey.com>
11339
11340         * solib-svr4.c (disable_probes_interface): Remove parameter.
11341         (svr4_handle_solib_event): Use make_scope_exit.
11342
11343 2019-03-06  Tom Tromey  <tom@tromey.com>
11344
11345         * remote.c (struct stop_reply_deleter): Remove.
11346         (stop_reply_up): Update.
11347         (struct stop_reply): Derive from notif_event.  Don't typedef.
11348         <regcache>: Now a std::vector.
11349         (stop_reply_xfree): Remove.
11350         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11351         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11352         (remote_target::discard_pending_stop_replies): Use delete.
11353         (remote_target::remote_parse_stop_reply): Update.
11354         (remote_target::process_stop_reply): Update.
11355         * remote-notif.h (struct notif_event): Add virtual destructor.
11356         Remove "dtr" member.
11357         (struct notif_client) <alloc_event>: Return a unique_ptr.
11358         (notif_event_xfree): Don't declare.
11359         (notif_event_up): New typedef.
11360         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11361         (notif_event_xfree, do_notif_event_xfree): Remove.
11362         (remote_notif_state_xfree): Update.
11363
11364 2019-03-06  Tom Tromey  <tom@tromey.com>
11365
11366         * infrun.c (displaced_step_clear_cleanup): Now a
11367         forward_scope_exit type.
11368         (displaced_step_prepare_throw): Update.
11369         (displaced_step_fixup): Update.
11370
11371 2019-03-06  Tom Tromey  <tom@tromey.com>
11372
11373         * inferior.h (class inferior): Update comment.
11374         * gdbthread.h (class thread_info): Update comment.
11375
11376 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11377             Tom Tromey  <tom@tromey.com>
11378
11379         * stabsread.h (struct stab_section_list): Remove.
11380         (coffstab_build_psymtabs): Update.
11381         * dbxread.c (symbuf_sections): Now a std::vector.
11382         (sect_idx): New global.
11383         (fill_symbuf): Update.
11384         (coffstab_build_psymtabs): Change type of stabsects parameter.
11385         Update.
11386         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11387         std::vector.
11388         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11389         (coff_locate_sections): Update.
11390         (coff_symfile_read): Remove cleanups.  Update.
11391         (init_stringtab): Add storage parameter.
11392         (free_stringtab, free_stringtab_cleanup): Remove.
11393         (init_lineno): Add storage parameter.
11394         (free_linetab, free_linetab_cleanup): Remove.
11395
11396 2019-03-06  Pedro Alves  <palves@redhat.com>
11397
11398         * linux-fork.c (fork_info::clobber_regs): Delete.
11399         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11400         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11401         comment.  Adjust.
11402         (scoped_switch_fork_info::scoped_switch_fork_info)
11403         (checkpoint_command, linux_fork_context): Adjust
11404         fork_save_infrun_state calls.
11405
11406 2019-03-06  Pedro Alves  <palves@redhat.com>
11407
11408         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11409         (inf_has_multiple_threads): Return 'bool' and rewrite using
11410         inferior_info::threads().
11411
11412 2019-03-06  Pedro Alves  <palves@redhat.com>
11413
11414         * linux-fork.c: Include <list>.
11415         (fork_list): Now a std::list instance.
11416         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11417         (forks_exist_p, find_last_fork): Adjust.
11418         (new_fork): Delete.
11419         (one_fork_p): New.
11420         (add_fork): Adjust.
11421         (free_fork): Delete, folded into fork_info::~fork_info().
11422         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11423         Adjust.
11424         (init_fork_list): Delete.
11425         (linux_fork_killall, linux_fork_mourn_inferior)
11426         (linux_fork_detach, info_checkpoints_command): Adjust.
11427         (_initialize_linux_fork): No longer call init_fork_list.
11428
11429 2019-03-06  Pedro Alves  <palves@redhat.com>
11430
11431         * linux-fork.c (new_fork): New, split out of ...
11432         (add_fork): ... this.  Return void.  Move "first fork" special
11433         case from here, to ...
11434         (checkpoint_command): ... here.
11435         * linux-linux.h (add_fork): Return void.
11436
11437 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11438
11439         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11440
11441 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11442             Chris January  <chris.january@arm.com>
11443             David Lecomber  <david.lecomber@arm.com>
11444
11445         * f-exp.y: New token, UNOP_INTRINSIC.
11446         (exp): New pattern using UNOP_INTRINSIC token.
11447         (f77_keywords): Add 'abs' keyword.
11448         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11449         (value_from_host_double): New function.
11450         (evaluate_subexp_f): Support UNOP_ABS.
11451
11452 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11453
11454         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11455         types.
11456
11457 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11458
11459         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11460         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11461         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11462
11463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11464
11465         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11466
11467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11468             Chris January  <chris.january@arm.com>
11469
11470         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11471         * f-exp.y: Define 'KIND' token.
11472         (exp): New pattern for KIND expressions.
11473         (ptype): Handle types with a kind extension.
11474         (direct_abs_decl): Extend to spot kind extensions.
11475         (f77_keywords): Add 'kind' to the list.
11476         (push_kind_type): New function.
11477         (convert_to_kind_type): New function.
11478         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11479         * parse.c (operator_length_standard): Likewise.
11480         * parser-defs.h (enum type_pieces): Add tp_kind.
11481         * std-operator.def: Add UNOP_KIND.
11482
11483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11484
11485         * f-exp.y (f_parse): Set yydebug.
11486
11487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11488
11489         * f-lang.c (evaluate_subexp_f): New function.
11490         (exp_descriptor_f): New global.
11491         (f_language_defn): Use exp_descriptor_f instead of
11492         exp_descriptor_standard.
11493
11494 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11495
11496         * f-exp.y (struct token): Add comments.
11497         (dot_ops): Remove uppercase versions and the end marker.
11498         (f77_keywords): Likewise.
11499         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11500         entries in the dot_ops array are case insensitive, and use
11501         strncasecmp to compare strings.  Also some whitespace cleanup in
11502         this area.  Similar for the f77_keywords array, except entries in
11503         this list might be case sensitive.
11504
11505 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11506
11507         * f-exp.y (struct f77_boolean_val): Add comments.
11508         (boolean_values): Remove uppercase versions, and end marker.
11509         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11510         and use strncasecmp to achieve case insensitivity.  Additionally,
11511         perform whitespace cleanup around this code.
11512
11513 2019-03-06  Tom Tromey  <tromey@adacore.com>
11514
11515         * remote-sim.c (gdbsim_target_open): Use result of
11516         gdb_argv::release.
11517
11518 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11519         Dirk Schubert  <dirk.schubert@arm.com>
11520         Chris January  <chris.january@arm.com>
11521
11522         * eval.c (evaluate_subexp_standard): Call Fortran argument
11523         wrapping logic.
11524         * f-lang.c (struct value): A value which can be passed into a
11525         Fortran function call.
11526         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11527         where appropriate.
11528         (struct type): Value ready for a Fortran function call.
11529         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11530         is needed.
11531         * f-lang.h (fortran_argument_convert): Declaration.
11532         (fortran_preserve_arg_pointer): Declaration.
11533         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11534
11535 2019-03-05  Tom Tromey  <tromey@adacore.com>
11536
11537         * python/py-prettyprint.c (print_string_repr): Remove #if.
11538         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11539
11540 2019-03-05  Tom Tromey  <tromey@adacore.com>
11541
11542         * target.c (the_dummy_target): Move later.  Change type to
11543         "dummy_target".
11544         (initialize_targets): Don't initialize the_dummy_target.
11545
11546 2019-03-05  Tom Tromey  <tromey@adacore.com>
11547
11548         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11549         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11550
11551 2019-03-05  Tom Tromey  <tromey@adacore.com>
11552
11553         * windows-nat.c (windows_nat_target::attach)
11554         (windows_nat_target::detach): Don't call gdb_flush.
11555         * valprint.c (generic_val_print, val_print, val_print_string):
11556         Don't call gdb_flush.
11557         * utils.c (defaulted_query): Don't call gdb_flush.
11558         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11559         * target.c (target_announce_detach): Don't call gdb_flush.
11560         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11561         * remote.c (extended_remote_target::attach): Don't call
11562         gdb_flush.
11563         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11564         * printcmd.c (do_examine): Don't call gdb_flush.
11565         (info_display_command): Don't call gdb_flush.
11566         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11567         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11568         * memattr.c (info_mem_command): Don't call gdb_flush.
11569         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11570         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11571         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11572         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11573         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11574         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11575         (gnu_nat_target::detach): Don't call gdb_flush.
11576         * f-valprint.c (f_val_print): Don't call gdb_flush.
11577         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11578         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11579         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11580         gdb_flush.
11581         * c-valprint.c (c_val_print): Don't call gdb_flush.
11582         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11583
11584 2019-03-05  Tom Tromey  <tromey@adacore.com>
11585
11586         * varobj.c (update_dynamic_varobj_children): Update.
11587         (install_default_visualizer): Use reset, not release.
11588         * value.c (set_internalvar): Update.
11589         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11590         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11591         ATTRIBUTE_UNUSED_RESULT.
11592
11593 2019-03-05  Tom Tromey  <tromey@adacore.com>
11594
11595         * remote.c (class scoped_remote_fd) <release>: Add
11596         ATTRIBUTE_UNUSED_RESULT.
11597
11598 2019-03-05  Tom Tromey  <tromey@adacore.com>
11599
11600         * macroexp.c (struct macro_buffer) <release>: Add
11601         ATTRIBUTE_UNUSED_RESULT.
11602
11603 2019-03-05  Tom Tromey  <tromey@adacore.com>
11604
11605         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11606         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11607         ATTRIBUTE_UNUSED_RESULT.
11608
11609 2019-03-05  Tom Tromey  <tromey@adacore.com>
11610
11611         * common/scoped_fd.h (class scoped_fd) <release>: Add
11612         ATTRIBUTE_UNUSED_RESULT.
11613
11614 2019-03-05  Tom Tromey  <tromey@adacore.com>
11615
11616         * parser-defs.h (struct parser_state) <release>: Add
11617         ATTRIBUTE_UNUSED_RESULT.
11618
11619 2019-03-05  Tom Tromey  <tromey@adacore.com>
11620
11621         * utils.h (class gdb_argv) <release>: Add
11622         ATTRIBUTE_UNUSED_RESULT.
11623         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11624
11625 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11626
11627         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11628         for-loop range, to avoid compiler warnings.
11629
11630         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11631         avoid compiler warnings about unused variables.
11632
11633         * NEWS: Mention end of support for native debugging on MS-Windows
11634         before XP.
11635
11636         PR gdb/24292
11637         * common/netstuff.c:
11638         * gdbserver/gdbreplay.c
11639         * gdbserver/remote-utils.c:
11640         * ser-tcp.c:
11641         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11642         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11643         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11644         'getaddrinfo' and 'freeaddrinfo' were not available before
11645         Windows XP, and mingw.org's MinGW headers by default define
11646         _WIN32_WINNT to 0x500.
11647
11648 2019-03-01  Gary Benson <gbenson@redhat.com>
11649
11650         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11651
11652 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11653             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11654
11655         PR gdb/8527
11656         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11657         set_sigint_trap, clear_sigint_trap.
11658
11659 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11660
11661         * target.c (target_detach): Clear the regcache and the
11662         frame cache.
11663
11664 2019-02-27  Pedro Alves  <palves@redhat.com>
11665
11666         * utils.c (set_screen_size): When we cap the height/width sizes,
11667         tweak the corresponding command variable to show "unlimited":
11668
11669 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11670             Pedro Alves  <palves@redhat.com>
11671
11672         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11673         before calling rl_set_screen_size.
11674
11675 2019-02-27  Tom Tromey  <tromey@adacore.com>
11676
11677         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11678         define.
11679         * python/py-value.c: Remove Python 2.4 workaround.
11680         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11681         workaround.
11682         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11683         Python 2.4 workaround.
11684         * python/python-internal.h: Remove Python 2.4 comment.
11685         (Py_ssize_t): Don't define.
11686         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11687         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11688         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11689         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11690         * python/python.c (do_start_initialization): Remove Python 2.4
11691         workaround.
11692         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11693         (print_children): Remove Python 2.4 workaround.
11694         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11695         workaround.
11696         (CHARBUFFERPROC_NAME): Remove.
11697         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11698         Python 2.4 workaround.
11699
11700 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11701
11702         * NEWS: Note minimum Python version.
11703
11704 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11705
11706         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11707         code from these functions.  Remove corresponding ifdefs.  Use
11708         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11709         Remove gotos and target of gotos.
11710         (infpy_search_memory): Likewise.
11711
11712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11713
11714         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11715         (hppa_gdbarch_init): Don't register deleted functions with
11716         gdbarch.
11717
11718 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11719
11720         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11721         (h8300_unwind_sp): Delete.
11722         (h8300_dummy_id): Delete.
11723         (h8300_gdbarch_init): Don't register deleted functions with
11724         gdbarch.
11725
11726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11727
11728         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11729         (ft32_unwind_pc): Delete.
11730         (ft32_unwind_sp): Delete.
11731         (ft32_gdbarch_init): Don't register deleted functions with
11732         gdbarch.
11733
11734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11735
11736         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11737         (frv_unwind_pc): Delete.
11738         (frv_unwind_sp): Delete.
11739         (frv_gdbarch_init): Don't register deleted functions with
11740         gdbarch.
11741
11742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11743
11744         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11745         (riscv_unwind_pc): Delete.
11746         (riscv_unwind_sp): Delete.
11747         (riscv_gdbarch_init): Don't register deleted functions with
11748         gdbarch.
11749
11750 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11751
11752         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11753         (csky_unwind_pc): Delete.
11754         (csky_unwind_sp): Delete.
11755         (csky_gdbarch_init): Don't register deleted functions with
11756         gdbarch.
11757
11758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11759
11760         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11761         (cris_unwind_pc): Delete.
11762         (cris_unwind_sp): Delete.
11763         (cris_gdbarch_init): Don't register deleted functions with
11764         gdbarch.
11765
11766 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11767
11768         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11769         (bfin_unwind_pc): Delete.
11770         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11771
11772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11773
11774         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11775         (arm_unwind_pc): Delete.
11776         (arm_unwind_sp): Delete.
11777         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11778
11779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11780
11781         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11782         (arc_unwind_pc): Delete.
11783         (arc_unwind_sp): Delete.
11784         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11785
11786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11787
11788         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11789         (alpha_unwind_pc): Delete.
11790         (alpha_gdbarch_init): Don't register deleted functions with
11791         gdbarch.
11792
11793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11794
11795         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11796         (aarch64_unwind_pc): Delete.
11797         (aarch64_unwind_sp): Delete.
11798         (aarch64_gdbarch_init): Don't register deleted functions with
11799         gdbarch.
11800
11801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11802
11803         * gdbtypes.c (type_align): Don't consider static members when
11804         computing structure alignment.
11805
11806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11807
11808         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11809         return 0 for other types.
11810         * arch-utils.c (default_type_align): Always return 0.
11811         * gdbarch.h: Regenerate.
11812         * gdbarch.sh (type_align): Extend comment.
11813         * gdbtypes.c (type_align): Add additional comments, always call
11814         gdbarch_type_align before applying the default rules.
11815         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11816         generic code will then apply a suitable default.
11817         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11818         types, return 0 for other types.
11819
11820 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11821
11822         * NEWS: Create a new section for the next release branch.
11823         Rename the section of the current branch, now that it has
11824         been cut.
11825
11826 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11827
11828         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11829         * version.in: Bump version to 8.3.50.DATE-git.
11830
11831 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11832
11833         * aix-thread.c (ptid_cmp): Remove unused variable.
11834         (get_signaled_thread): Likewise.
11835         (store_regs_user_thread): Likewise.
11836         (store_regs_kernel_thread): Likewise.
11837         (fetch_regs_kernel_thread): Remove shadowed variable.
11838
11839 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11840
11841         * features/riscv/32bit-cpu.xml: Add register numbers.
11842         * features/riscv/32bit-fpu.c: Regenerate.
11843         * features/riscv/32bit-fpu.xml: Add register numbers.
11844         * features/riscv/64bit-cpu.xml: Add register numbers.
11845         * features/riscv/64bit-fpu.c: Regenerate.
11846         * features/riscv/64bit-fpu.xml: Add register numbers.
11847
11848 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11849
11850         * NEWS: Mention two argument form of gdb.Value constructor.
11851         * python/py-value.c (convert_buffer_and_type_to_value): New
11852         function.
11853         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11854         Add support for handling an optional second argument.  Call
11855         convert_buffer_and_type_to_value as appropriate.
11856         * python/python-internal.h (Py_buffer_deleter): New struct.
11857         (Py_buffer_up): New typedef.
11858
11859 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11860
11861         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11862         instead of releasing ownership.
11863
11864 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11865
11866         * dwarf2read.c (open_and_init_dwp_file): Call
11867         elf_numsections instead of bfd_count_sections to initialize
11868         dwp_file->num_sections.
11869
11870 2019-02-25  Tom Tromey  <tromey@adacore.com>
11871
11872         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11873
11874 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11875
11876         * gcore.in: Add '--readnever' option when invoking GDB.
11877
11878 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11879
11880         * MAINTAINERS: Update my email address.
11881
11882 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11883
11884         * build-id.c (build_id_to_debug_bfd_1): New function.
11885         (build_id_to_debug_bfd): Look for separate debug file in
11886         sysroot.
11887
11888 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11889
11890         * gdbarch.sh: Update the copyright year range that is placed into
11891         generated files.
11892
11893 2019-02-22  Keith Seitz  <keiths@redhat.com>
11894
11895         PR symtab/23853
11896         * linespec.c (create_sals_line_offset): Search for the default
11897         symtab's filename instead of its fullname.
11898
11899 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11900
11901         * NEWS: Update style defaults.
11902
11903 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11904
11905         * main.c (captured_main_1): Disable styling in batch mode.
11906
11907 2019-02-20  Tom Tromey  <tom@tromey.com>
11908
11909         * symtab.c (symtab_symbol_info): Fix typos.
11910
11911 2019-02-20  Tom Tromey  <tromey@adacore.com>
11912
11913         * findcmd.c (_initialize_mem_search): Use upper case for
11914         metasyntactic variables.
11915
11916 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11917
11918         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11919         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11920
11921 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11922
11923         * top.h (source_file_name): Change to std::string.
11924         * top.c (source_file_name): Likewise.
11925         (command_line_input): Adjust.
11926         * cli/cli-script.c (script_from_file): Adjust.
11927
11928 2019-02-19  Tom Tromey  <tromey@adacore.com>
11929
11930         * ravenscar-thread.c
11931         (ravenscar_thread_target::update_thread_list): Don't call
11932         ada_build_task_list.
11933         * ada-lang.h (ada_build_task_list): Don't declare.
11934         * ada-tasks.c (struct ada_tasks_inferior_data)
11935         <task_list_valid_p>: Now bool.
11936         (read_known_tasks, ada_task_list_changed)
11937         (ada_tasks_invalidate_inferior_data): Update.
11938         (read_known_tasks_array): Return bool.
11939         (read_known_tasks_list): Likewise.
11940         (read_known_tasks): Return void.
11941         (ada_build_task_list): Now static.
11942
11943 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11944
11945         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11946         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11947
11948 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11949
11950         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11951         variant for ada_tasks_pspace_data_handle and
11952         ada_tasks_inferior_data_handle.
11953         (ada_tasks_pspace_data_cleanup): New function.
11954         (ada_tasks_inferior_data_cleanup): New function.
11955
11956 2019-02-17  Tom Tromey  <tom@tromey.com>
11957
11958         * macrotab.h (macro_source_fullname): Return a std::string.
11959         * macrotab.c (macro_include, check_for_redefinition)
11960         (macro_undef, macro_lookup_definition, foreach_macro)
11961         (foreach_macro_in_scope): Update.
11962         (macro_source_fullname): Return a std::string.
11963         * macrocmd.c (show_pp_source_pos): Update.
11964
11965 2019-02-17  Tom Tromey  <tom@tromey.com>
11966
11967         * macrocmd.c (show_pp_source_pos): Style the file names.
11968
11969 2019-02-17  Tom Tromey  <tom@tromey.com>
11970
11971         PR tui/24197:
11972         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11973
11974 2019-02-17  Tom Tromey  <tom@tromey.com>
11975
11976         * ada-lang.c (user_select_syms): Use filtered printing.
11977         * utils.c (wrap_style): New global.
11978         (desired_style): Remove.
11979         (emit_style_escape): Add stream parameter.
11980         (set_output_style, reset_terminal_style, prompt_for_continue):
11981         Update.
11982         (flush_wrap_buffer): Only flush gdb_stdout.
11983         (wrap_here): Set wrap_style.
11984         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11985         treat escape sequences as a character.  Change when wrap buffer is
11986         flushed.
11987         (fputs_styled): Do not set the output style when the default is
11988         requested.
11989         * ui-style.h (struct ui_file_style) <is_default>: New method.
11990         * source.c (print_source_lines_base): Emit escape sequences in one
11991         piece.
11992
11993 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11994
11995         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11996         integers and enumeration types.
11997
11998 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11999
12000         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12001         instead of lookup_symbol_in_language
12002         (do_exact_match): New function.
12003         (ada_get_symbol_name_matcher): Return do_exact_match when
12004         doing a verbatim match.
12005
12006 2019-02-15  Tom Tromey  <tromey@adacore.com>
12007
12008         * ravenscar-thread.c (ravenscar_thread_target::resume)
12009         (ravenscar_thread_target::wait): Special case wildcard requests.
12010
12011 2019-02-15  Tom Tromey  <tromey@adacore.com>
12012
12013         * ravenscar-thread.c (base_ptid): Remove.
12014         (struct ravenscar_thread_target) <close>: New method.
12015         <m_base_ptid>: New member.
12016         <update_inferior_ptid, active_task, task_is_currently_active,
12017         runtime_initialized>: Declare methods.
12018         <ravenscar_thread_target>: Add constructor.
12019         (ravenscar_thread_target::task_is_currently_active)
12020         (ravenscar_thread_target::update_inferior_ptid)
12021         (ravenscar_runtime_initialized): Rename.  Now methods.
12022         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12023         (ravenscar_thread_target::update_thread_list): Update.
12024         (ravenscar_thread_target::active_task): Now method.
12025         (ravenscar_thread_target::store_registers)
12026         (ravenscar_thread_target::prepare_to_store)
12027         (ravenscar_thread_target::prepare_to_store)
12028         (ravenscar_thread_target::mourn_inferior): Update.
12029         (ravenscar_inferior_created): Use "new" to create target.
12030         (ravenscar_thread_target::get_ada_task_ptid): Update.
12031         (_initialize_ravenscar): Don't initialize base_ptid.
12032         (ravenscar_ops): Remove global.
12033
12034 2019-02-15  Tom Tromey  <tromey@adacore.com>
12035
12036         * target.h (push_target): Declare new overload.
12037         * target.c (push_target): New overload, taking an rvalue reference.
12038         * remote.c (remote_target::open_1): Use push_target overload.
12039         * corelow.c (core_target_open): Use push_target overload.
12040
12041 2019-02-15  Tom Tromey  <tromey@adacore.com>
12042
12043         * ravenscar-thread.c (is_ravenscar_task)
12044         (ravenscar_task_is_currently_active): Return bool.
12045         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12046         (_initialize_ravenscar): Remove "(void)".
12047         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12048         Return bool.
12049
12050 2019-02-15  Tom Tromey  <tromey@adacore.com>
12051
12052         * ravenscar-thread.c (ravenscar_runtime_initializer)
12053         (has_ravenscar_runtime, get_running_thread_id)
12054         (ravenscar_thread_target::resume): Fix indentation.
12055
12056 2019-02-15  Tom Tromey  <tromey@adacore.com>
12057
12058         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12059         from ravenscar_arch_ops.
12060         (sparc_ravenscar_ops::fetch_registers)
12061         (sparc_ravenscar_ops::store_registers): Now methods.
12062         (sparc_ravenscar_prepare_to_store): Remove.
12063         (sparc_ravenscar_ops): Redefine.
12064         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12065         methods and destructor.  Remove members.
12066         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12067         (ravenscar_thread_target::store_registers)
12068         (ravenscar_thread_target::prepare_to_store): Update.
12069         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12070         Remove.
12071         (struct ppc_ravenscar_powerpc_ops): Derive from
12072         ravenscar_arch_ops.
12073         (ppc_ravenscar_powerpc_ops::fetch_registers)
12074         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12075         (ppc_ravenscar_powerpc_ops): Redefine.
12076         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12077         (ppc_ravenscar_e500_ops::fetch_registers)
12078         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12079         (ppc_ravenscar_e500_ops): Redefine.
12080         * aarch64-ravenscar-thread.c
12081         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12082         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12083         (aarch64_ravenscar_fetch_registers)
12084         (aarch64_ravenscar_store_registers): Now methods.
12085         (aarch64_ravenscar_ops): Redefine.
12086
12087 2019-02-15  Tom Tromey  <tromey@adacore.com>
12088
12089         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12090         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12091         (ravenscar_thread_target::stopped_by_watchpoint)
12092         (ravenscar_thread_target::stopped_data_address)
12093         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12094
12095 2019-02-15  Tom Tromey  <tromey@adacore.com>
12096
12097         * ravenscar-thread.c: Fix some typos.
12098
12099 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12100             Tom Tromey  <tromey@adacore.com>
12101
12102         * ada-lang.c (ada_exception_sal): Change addr_string to a
12103         std::string.
12104         (create_ada_exception_catchpoint): Update.
12105
12106 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12107             Tom Tromey  <tromey@adacore.com>
12108
12109         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12110         (bp_location_ops): Remove.
12111         (base_breakpoint_allocate_location): Update.
12112         (free_bp_location): Update.
12113         * ada-lang.c (class ada_catchpoint_location)
12114         <ada_catchpoint_location>: Remove ops parameter.
12115         (ada_catchpoint_location_dtor): Remove.
12116         (ada_catchpoint_location_ops): Remove.
12117         (allocate_location_exception): Update.
12118         * breakpoint.h (struct bp_location_ops): Remove.
12119         (class bp_location) <bp_location>: Remove bp_location_ops
12120         parameter.
12121         <~bp_location>: Add destructor.
12122         <ops>: Remove.
12123
12124 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12125             Pedro Alves  <palves@redhat.com>
12126
12127         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12128         'PATH_MAX'.
12129
12130 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12131             Samuel Thibault  <samuel.thibault@gnu.org>
12132             Thomas Schwinge  <thomas@codesourcery.com>
12133
12134         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12135         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12136
12137 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12138
12139         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12140         (check_empty): Use "const char *".
12141
12142         * gnu-nat.c (gnu_nat_target::detach): Instead of
12143         'detach_inferior (pid)' call
12144         'detach_inferior (find_inferior_pid (pid))'.
12145
12146         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12147         'nat/fork-inferior.o'.
12148         * gnu-nat.c: #include "nat/fork-inferior.h".
12149
12150         * gnu-nat.c (gnu_nat_target::detach): Instead of
12151         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12152         * gnu-nat.h: #include "inf-child.h".
12153         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12154         'i386_gnu_nat_target::fetch_registers'.
12155         (gnu_store_registers): Rename/move to
12156         'i386_gnu_nat_target::store_registers'.
12157
12158         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12159         * gnu-nat.h (mach_thread_info): New function.
12160         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12161
12162         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12163
12164 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12165
12166         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12167
12168 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12169
12170         * windows-nat.c (windows_add_thread): Add new parameter
12171         "main_thread_p" with default value set to false.  Update
12172         function documentation as well as all callers.
12173         (windows_delete_thread): Likewise.
12174         (fake_create_process): Update call to windows_add_thread.
12175         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12176         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12177         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12178         call to windows_delete_thread.
12179
12180 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12181
12182         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12183
12184 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12185
12186         * symfile.c (find_separate_debug_file): Use canonical path of
12187         sysroot with child_path instead of gdb_sysroot if it is valid.
12188
12189 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12190
12191         * symfile.c (find_separate_debug_file): Use child_path to
12192         determine if an object file is under a sysroot.
12193
12194 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12195
12196         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12197         unittests/child-path-selftests.c.
12198         * common/pathstuff.c (child_path): New function.
12199         * common/pathstuff.h (child_path): New prototype.
12200         * unittests/child-path-selftests.c: New file.
12201
12202 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12203
12204         * symfile.c (find_separate_debug_file): Look for separate debug
12205         files in debug directories under the sysroot.
12206
12207 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12208
12209         * symtab.h (struct minimal_symbol data_p): New const method.
12210         (struct minimal_symbol text_p): Likewise.
12211         * symtab.c (output_source_filename): Use file name style
12212         to print file name.
12213         (print_symbol_info): Likewise.
12214         (print_msymbol_info): Use address style to print addresses.
12215         Use function name style to print executable text symbols.
12216         (expand_symtab_containing_pc): Use data_p.
12217         (find_pc_sect_compunit_symtab): Likewise.
12218
12219 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12220
12221         * breakpoint.c (describe_other_breakpoints): Use address style
12222         to print addresses.
12223         (say_where): Likewise.
12224
12225 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12226
12227         * ada-typeprint.c (print_func_type): Print function name
12228         style to print function name.
12229         * c-typeprint.c (c_print_type_1): Likewise.
12230
12231 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12232
12233         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12234         for execve.
12235
12236 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12237
12238         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12239         type_stack.
12240
12241 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12242
12243         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12244         TYPE_CODE_REF types.
12245
12246 2019-02-08  Jim Wilson  <jimw@sifive.com>
12247
12248         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12249         (riscv_linux_fregset): New.
12250         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12251
12252 2019-02-07  Tom Tromey  <tom@tromey.com>
12253
12254         * thread.c (thread_cancel_execution_command): Update.
12255         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12256         methods.
12257         (struct thread_fsm_ops): Remove.
12258         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12259         (thread_fsm_should_stop, thread_fsm_return_value)
12260         (thread_fsm_set_finished, thread_fsm_finished_p)
12261         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12262         Don't declare.
12263         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12264         * infrun.c (clear_proceed_status_thread)
12265         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12266         (print_stop_event): Update.
12267         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12268         Add constructor.
12269         (step_command_fsm_ops): Remove.
12270         (new_step_command_fsm): Remove.
12271         (step_1): Update.
12272         (step_command_fsm::should_stop): Rename from
12273         step_command_fsm_should_stop.
12274         (step_command_fsm::clean_up): Rename from
12275         step_command_fsm_clean_up.
12276         (step_command_fsm::do_async_reply_reason): Rename from
12277         step_command_fsm_async_reply_reason.
12278         (struct until_next_fsm): Inherit from thread_fsm.  Add
12279         constructor.
12280         (until_next_fsm_ops): Remove.
12281         (new_until_next_fsm): Remove.
12282         (until_next_fsm::should_stop): Rename from
12283         until_next_fsm_should_stop.
12284         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12285         (until_next_fsm::do_async_reply_reason): Rename from
12286         until_next_fsm_async_reply_reason.
12287         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12288         constructor.  Change type of breakpoint.
12289         (finish_command_fsm_ops): Remove.
12290         (new_finish_command_fsm): Remove.
12291         (finish_command_fsm::should_stop): Rename from
12292         finish_command_fsm_should_stop.
12293         (finish_command_fsm::clean_up): Rename from
12294         finish_command_fsm_clean_up.
12295         (finish_command_fsm::return_value): Rename from
12296         finish_command_fsm_return_value.
12297         (finish_command_fsm::do_async_reply_reason): Rename from
12298         finish_command_fsm_async_reply_reason.
12299         (finish_command): Update.
12300         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12301         Add constructor.
12302         (call_thread_fsm_ops): Remove.
12303         (call_thread_fsm::call_thread_fsm): Rename from
12304         new_call_thread_fsm.
12305         (call_thread_fsm::should_stop): Rename from
12306         call_thread_fsm_should_stop.
12307         (call_thread_fsm::should_notify_stop): Rename from
12308         call_thread_fsm_should_notify_stop.
12309         (run_inferior_call, call_function_by_hand_dummy): Update.
12310         * cli/cli-interp.c (should_print_stop_to_console): Update.
12311         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12312         Add constructor.  Change type of location_breakpoint,
12313         caller_breakpoint.
12314         (until_break_fsm_ops): Remove.
12315         (new_until_break_fsm): Remove.
12316         (until_break_fsm::should_stop): Rename from
12317         until_break_fsm_should_stop.
12318         (until_break_fsm::clean_up): Rename from
12319         until_break_fsm_clean_up.
12320         (until_break_fsm::do_async_reply_reason): Rename from
12321         until_break_fsm_async_reply_reason.
12322         (until_break_command): Update.
12323         * thread-fsm.c: Remove.
12324         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12325
12326 2019-02-07  Tom Tromey  <tom@tromey.com>
12327
12328         * yy-remap.h: Add include guard.
12329         * xtensa-tdep.h: Add include guard.
12330         * xcoffread.h: Rename include guard.
12331         * varobj-iter.h: Add include guard.
12332         * tui/tui.h: Rename include guard.
12333         * tui/tui-winsource.h: Rename include guard.
12334         * tui/tui-wingeneral.h: Rename include guard.
12335         * tui/tui-windata.h: Rename include guard.
12336         * tui/tui-win.h: Rename include guard.
12337         * tui/tui-stack.h: Rename include guard.
12338         * tui/tui-source.h: Rename include guard.
12339         * tui/tui-regs.h: Rename include guard.
12340         * tui/tui-out.h: Rename include guard.
12341         * tui/tui-layout.h: Rename include guard.
12342         * tui/tui-io.h: Rename include guard.
12343         * tui/tui-hooks.h: Rename include guard.
12344         * tui/tui-file.h: Rename include guard.
12345         * tui/tui-disasm.h: Rename include guard.
12346         * tui/tui-data.h: Rename include guard.
12347         * tui/tui-command.h: Rename include guard.
12348         * tic6x-tdep.h: Add include guard.
12349         * target/waitstatus.h: Rename include guard.
12350         * target/wait.h: Rename include guard.
12351         * target/target.h: Rename include guard.
12352         * target/resume.h: Rename include guard.
12353         * target-float.h: Rename include guard.
12354         * stabsread.h: Add include guard.
12355         * rs6000-tdep.h: Add include guard.
12356         * riscv-fbsd-tdep.h: Add include guard.
12357         * regformats/regdef.h: Rename include guard.
12358         * record.h: Rename include guard.
12359         * python/python.h: Rename include guard.
12360         * python/python-internal.h: Rename include guard.
12361         * python/py-stopevent.h: Rename include guard.
12362         * python/py-ref.h: Rename include guard.
12363         * python/py-record.h: Rename include guard.
12364         * python/py-record-full.h: Rename include guard.
12365         * python/py-record-btrace.h: Rename include guard.
12366         * python/py-instruction.h: Rename include guard.
12367         * python/py-events.h: Rename include guard.
12368         * python/py-event.h: Rename include guard.
12369         * procfs.h: Add include guard.
12370         * proc-utils.h: Add include guard.
12371         * p-lang.h: Add include guard.
12372         * or1k-tdep.h: Rename include guard.
12373         * observable.h: Rename include guard.
12374         * nto-tdep.h: Rename include guard.
12375         * nat/x86-linux.h: Rename include guard.
12376         * nat/x86-linux-dregs.h: Rename include guard.
12377         * nat/x86-gcc-cpuid.h: Add include guard.
12378         * nat/x86-dregs.h: Rename include guard.
12379         * nat/x86-cpuid.h: Rename include guard.
12380         * nat/ppc-linux.h: Rename include guard.
12381         * nat/mips-linux-watch.h: Rename include guard.
12382         * nat/linux-waitpid.h: Rename include guard.
12383         * nat/linux-ptrace.h: Rename include guard.
12384         * nat/linux-procfs.h: Rename include guard.
12385         * nat/linux-osdata.h: Rename include guard.
12386         * nat/linux-nat.h: Rename include guard.
12387         * nat/linux-namespaces.h: Rename include guard.
12388         * nat/linux-btrace.h: Rename include guard.
12389         * nat/glibc_thread_db.h: Rename include guard.
12390         * nat/gdb_thread_db.h: Rename include guard.
12391         * nat/gdb_ptrace.h: Rename include guard.
12392         * nat/fork-inferior.h: Rename include guard.
12393         * nat/amd64-linux-siginfo.h: Rename include guard.
12394         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12395         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12396         * nat/aarch64-linux.h: Rename include guard.
12397         * nat/aarch64-linux-hw-point.h: Rename include guard.
12398         * mn10300-tdep.h: Add include guard.
12399         * mips-linux-tdep.h: Add include guard.
12400         * mi/mi-parse.h: Rename include guard.
12401         * mi/mi-out.h: Rename include guard.
12402         * mi/mi-main.h: Rename include guard.
12403         * mi/mi-interp.h: Rename include guard.
12404         * mi/mi-getopt.h: Rename include guard.
12405         * mi/mi-console.h: Rename include guard.
12406         * mi/mi-common.h: Rename include guard.
12407         * mi/mi-cmds.h: Rename include guard.
12408         * mi/mi-cmd-break.h: Rename include guard.
12409         * m2-lang.h: Add include guard.
12410         * location.h: Rename include guard.
12411         * linux-record.h: Rename include guard.
12412         * linux-nat.h: Add include guard.
12413         * linux-fork.h: Add include guard.
12414         * i386-darwin-tdep.h: Rename include guard.
12415         * hppa-linux-offsets.h: Add include guard.
12416         * guile/guile.h: Rename include guard.
12417         * guile/guile-internal.h: Rename include guard.
12418         * gnu-nat.h: Rename include guard.
12419         * gdb-stabs.h: Rename include guard.
12420         * frv-tdep.h: Add include guard.
12421         * f-lang.h: Add include guard.
12422         * event-loop.h: Add include guard.
12423         * darwin-nat.h: Rename include guard.
12424         * cp-abi.h: Rename include guard.
12425         * config/sparc/nm-sol2.h: Rename include guard.
12426         * config/nm-nto.h: Rename include guard.
12427         * config/nm-linux.h: Add include guard.
12428         * config/i386/nm-i386gnu.h: Rename include guard.
12429         * config/djgpp/nl_types.h: Rename include guard.
12430         * config/djgpp/langinfo.h: Rename include guard.
12431         * compile/gcc-cp-plugin.h: Add include guard.
12432         * compile/gcc-c-plugin.h: Add include guard.
12433         * compile/compile.h: Rename include guard.
12434         * compile/compile-object-run.h: Rename include guard.
12435         * compile/compile-object-load.h: Rename include guard.
12436         * compile/compile-internal.h: Rename include guard.
12437         * compile/compile-cplus.h: Rename include guard.
12438         * compile/compile-c.h: Rename include guard.
12439         * common/xml-utils.h: Rename include guard.
12440         * common/x86-xstate.h: Rename include guard.
12441         * common/version.h: Rename include guard.
12442         * common/vec.h: Rename include guard.
12443         * common/tdesc.h: Rename include guard.
12444         * common/selftest.h: Rename include guard.
12445         * common/scoped_restore.h: Rename include guard.
12446         * common/scoped_mmap.h: Rename include guard.
12447         * common/scoped_fd.h: Rename include guard.
12448         * common/safe-iterator.h: Rename include guard.
12449         * common/run-time-clock.h: Rename include guard.
12450         * common/refcounted-object.h: Rename include guard.
12451         * common/queue.h: Rename include guard.
12452         * common/ptid.h: Rename include guard.
12453         * common/print-utils.h: Rename include guard.
12454         * common/preprocessor.h: Rename include guard.
12455         * common/pathstuff.h: Rename include guard.
12456         * common/observable.h: Rename include guard.
12457         * common/netstuff.h: Rename include guard.
12458         * common/job-control.h: Rename include guard.
12459         * common/host-defs.h: Rename include guard.
12460         * common/gdb_wait.h: Rename include guard.
12461         * common/gdb_vecs.h: Rename include guard.
12462         * common/gdb_unlinker.h: Rename include guard.
12463         * common/gdb_unique_ptr.h: Rename include guard.
12464         * common/gdb_tilde_expand.h: Rename include guard.
12465         * common/gdb_sys_time.h: Rename include guard.
12466         * common/gdb_string_view.h: Rename include guard.
12467         * common/gdb_splay_tree.h: Rename include guard.
12468         * common/gdb_setjmp.h: Rename include guard.
12469         * common/gdb_ref_ptr.h: Rename include guard.
12470         * common/gdb_optional.h: Rename include guard.
12471         * common/gdb_locale.h: Rename include guard.
12472         * common/gdb_assert.h: Rename include guard.
12473         * common/filtered-iterator.h: Rename include guard.
12474         * common/filestuff.h: Rename include guard.
12475         * common/fileio.h: Rename include guard.
12476         * common/environ.h: Rename include guard.
12477         * common/common-utils.h: Rename include guard.
12478         * common/common-types.h: Rename include guard.
12479         * common/common-regcache.h: Rename include guard.
12480         * common/common-inferior.h: Rename include guard.
12481         * common/common-gdbthread.h: Rename include guard.
12482         * common/common-exceptions.h: Rename include guard.
12483         * common/common-defs.h: Rename include guard.
12484         * common/common-debug.h: Rename include guard.
12485         * common/cleanups.h: Rename include guard.
12486         * common/buffer.h: Rename include guard.
12487         * common/btrace-common.h: Rename include guard.
12488         * common/break-common.h: Rename include guard.
12489         * cli/cli-utils.h: Rename include guard.
12490         * cli/cli-style.h: Rename include guard.
12491         * cli/cli-setshow.h: Rename include guard.
12492         * cli/cli-script.h: Rename include guard.
12493         * cli/cli-interp.h: Rename include guard.
12494         * cli/cli-decode.h: Rename include guard.
12495         * cli/cli-cmds.h: Rename include guard.
12496         * charset-list.h: Add include guard.
12497         * buildsym-legacy.h: Rename include guard.
12498         * bfin-tdep.h: Add include guard.
12499         * ax.h: Rename include guard.
12500         * arm-linux-tdep.h: Add include guard.
12501         * arm-fbsd-tdep.h: Add include guard.
12502         * arch/xtensa.h: Rename include guard.
12503         * arch/tic6x.h: Add include guard.
12504         * arch/i386.h: Add include guard.
12505         * arch/arm.h: Rename include guard.
12506         * arch/arm-linux.h: Rename include guard.
12507         * arch/arm-get-next-pcs.h: Rename include guard.
12508         * arch/amd64.h: Add include guard.
12509         * arch/aarch64-insn.h: Rename include guard.
12510         * arch-utils.h: Rename include guard.
12511         * annotate.h: Add include guard.
12512         * amd64-darwin-tdep.h: Rename include guard.
12513         * aarch64-linux-tdep.h: Add include guard.
12514         * aarch64-fbsd-tdep.h: Add include guard.
12515         * aarch32-linux-nat.h: Add include guard.
12516
12517 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12518
12519         * macrotab.c (macro_define_internal): New function that
12520         factorizes macro_define_object_internal and macro_define_function
12521         code.
12522         (macro_define_object_internal): Use macro_define_internal.
12523         (macro_define_function): Likewise.
12524
12525 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12526
12527         * macrocmd.c (extract_identifier): Return
12528         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12529         callers.
12530
12531 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12532
12533         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12534
12535 2019-02-05  Tom Tromey  <tom@tromey.com>
12536
12537         * target.c (target_stack::unpush): Move assertion earlier.
12538
12539 2019-01-30  Tom Tromey  <tom@tromey.com>
12540
12541         PR python/23615:
12542         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12543         (gdbpy_parse_and_eval): Likewise.
12544         * python/python-internal.h (gdbpy_allow_threads): New class.
12545
12546 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12547
12548         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12549         (aarch64_fbsd_fpregmap): Move earlier.
12550         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12551         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12552         instead of individual calls to trad_frame_set_reg_addr.
12553         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12554         earlier.
12555         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12556         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12557         instead of individual calls to trad_frame_set_reg_addr.
12558
12559 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12560
12561         * CONTRIBUTE: Replace contribution list with wiki link.
12562
12563 2019-01-25  Tom Tromey  <tom@tromey.com>
12564
12565         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12566
12567 2019-01-25  Tom Tromey  <tom@tromey.com>
12568
12569         * xtensa-linux-nat.c: Fix common/ includes.
12570         * xml-support.h: Fix common/ includes.
12571         * xml-support.c: Fix common/ includes.
12572         * x86-linux-nat.c: Fix common/ includes.
12573         * windows-nat.c: Fix common/ includes.
12574         * varobj.h: Fix common/ includes.
12575         * varobj.c: Fix common/ includes.
12576         * value.c: Fix common/ includes.
12577         * valops.c: Fix common/ includes.
12578         * utils.c: Fix common/ includes.
12579         * unittests/xml-utils-selftests.c: Fix common/ includes.
12580         * unittests/utils-selftests.c: Fix common/ includes.
12581         * unittests/unpack-selftests.c: Fix common/ includes.
12582         * unittests/tracepoint-selftests.c: Fix common/ includes.
12583         * unittests/style-selftests.c: Fix common/ includes.
12584         * unittests/string_view-selftests.c: Fix common/ includes.
12585         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12586         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12587         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12588         * unittests/rsp-low-selftests.c: Fix common/ includes.
12589         * unittests/parse-connection-spec-selftests.c: Fix common/
12590         includes.
12591         * unittests/optional-selftests.c: Fix common/ includes.
12592         * unittests/offset-type-selftests.c: Fix common/ includes.
12593         * unittests/observable-selftests.c: Fix common/ includes.
12594         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12595         * unittests/memrange-selftests.c: Fix common/ includes.
12596         * unittests/memory-map-selftests.c: Fix common/ includes.
12597         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12598         * unittests/function-view-selftests.c: Fix common/ includes.
12599         * unittests/environ-selftests.c: Fix common/ includes.
12600         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12601         * unittests/common-utils-selftests.c: Fix common/ includes.
12602         * unittests/cli-utils-selftests.c: Fix common/ includes.
12603         * unittests/array-view-selftests.c: Fix common/ includes.
12604         * ui-file.c: Fix common/ includes.
12605         * tui/tui-io.c: Fix common/ includes.
12606         * tracepoint.h: Fix common/ includes.
12607         * tracepoint.c: Fix common/ includes.
12608         * tracefile-tfile.c: Fix common/ includes.
12609         * top.h: Fix common/ includes.
12610         * top.c: Fix common/ includes.
12611         * thread.c: Fix common/ includes.
12612         * target/waitstatus.h: Fix common/ includes.
12613         * target/waitstatus.c: Fix common/ includes.
12614         * target.h: Fix common/ includes.
12615         * target.c: Fix common/ includes.
12616         * target-memory.c: Fix common/ includes.
12617         * target-descriptions.c: Fix common/ includes.
12618         * symtab.h: Fix common/ includes.
12619         * symfile.c: Fix common/ includes.
12620         * stap-probe.c: Fix common/ includes.
12621         * spu-linux-nat.c: Fix common/ includes.
12622         * sparc-nat.c: Fix common/ includes.
12623         * source.c: Fix common/ includes.
12624         * solib.c: Fix common/ includes.
12625         * solib-target.c: Fix common/ includes.
12626         * ser-unix.c: Fix common/ includes.
12627         * ser-tcp.c: Fix common/ includes.
12628         * ser-pipe.c: Fix common/ includes.
12629         * ser-base.c: Fix common/ includes.
12630         * selftest-arch.c: Fix common/ includes.
12631         * s12z-tdep.c: Fix common/ includes.
12632         * rust-exp.y: Fix common/ includes.
12633         * rs6000-aix-tdep.c: Fix common/ includes.
12634         * riscv-tdep.c: Fix common/ includes.
12635         * remote.c: Fix common/ includes.
12636         * remote-notif.h: Fix common/ includes.
12637         * remote-fileio.h: Fix common/ includes.
12638         * remote-fileio.c: Fix common/ includes.
12639         * regcache.h: Fix common/ includes.
12640         * regcache.c: Fix common/ includes.
12641         * record-btrace.c: Fix common/ includes.
12642         * python/python.c: Fix common/ includes.
12643         * python/py-type.c: Fix common/ includes.
12644         * python/py-inferior.c: Fix common/ includes.
12645         * progspace.h: Fix common/ includes.
12646         * producer.c: Fix common/ includes.
12647         * procfs.c: Fix common/ includes.
12648         * proc-api.c: Fix common/ includes.
12649         * printcmd.c: Fix common/ includes.
12650         * ppc-linux-nat.c: Fix common/ includes.
12651         * parser-defs.h: Fix common/ includes.
12652         * osdata.c: Fix common/ includes.
12653         * obsd-nat.c: Fix common/ includes.
12654         * nat/x86-linux.c: Fix common/ includes.
12655         * nat/x86-linux-dregs.c: Fix common/ includes.
12656         * nat/x86-dregs.h: Fix common/ includes.
12657         * nat/x86-dregs.c: Fix common/ includes.
12658         * nat/ppc-linux.c: Fix common/ includes.
12659         * nat/mips-linux-watch.h: Fix common/ includes.
12660         * nat/mips-linux-watch.c: Fix common/ includes.
12661         * nat/linux-waitpid.c: Fix common/ includes.
12662         * nat/linux-ptrace.h: Fix common/ includes.
12663         * nat/linux-ptrace.c: Fix common/ includes.
12664         * nat/linux-procfs.c: Fix common/ includes.
12665         * nat/linux-personality.c: Fix common/ includes.
12666         * nat/linux-osdata.c: Fix common/ includes.
12667         * nat/linux-namespaces.c: Fix common/ includes.
12668         * nat/linux-btrace.h: Fix common/ includes.
12669         * nat/linux-btrace.c: Fix common/ includes.
12670         * nat/fork-inferior.c: Fix common/ includes.
12671         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12672         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12673         * nat/aarch64-linux.c: Fix common/ includes.
12674         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12675         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12676         * namespace.h: Fix common/ includes.
12677         * mips-linux-tdep.c: Fix common/ includes.
12678         * minsyms.c: Fix common/ includes.
12679         * mi/mi-parse.h: Fix common/ includes.
12680         * mi/mi-main.c: Fix common/ includes.
12681         * mi/mi-cmd-env.c: Fix common/ includes.
12682         * memrange.h: Fix common/ includes.
12683         * memattr.c: Fix common/ includes.
12684         * maint.h: Fix common/ includes.
12685         * maint.c: Fix common/ includes.
12686         * main.c: Fix common/ includes.
12687         * machoread.c: Fix common/ includes.
12688         * location.c: Fix common/ includes.
12689         * linux-thread-db.c: Fix common/ includes.
12690         * linux-nat.c: Fix common/ includes.
12691         * linux-fork.c: Fix common/ includes.
12692         * inline-frame.c: Fix common/ includes.
12693         * infrun.c: Fix common/ includes.
12694         * inflow.c: Fix common/ includes.
12695         * inferior.h: Fix common/ includes.
12696         * inferior.c: Fix common/ includes.
12697         * infcmd.c: Fix common/ includes.
12698         * inf-ptrace.c: Fix common/ includes.
12699         * inf-child.c: Fix common/ includes.
12700         * ia64-linux-nat.c: Fix common/ includes.
12701         * i387-tdep.c: Fix common/ includes.
12702         * i386-tdep.c: Fix common/ includes.
12703         * i386-linux-tdep.c: Fix common/ includes.
12704         * i386-linux-nat.c: Fix common/ includes.
12705         * i386-go32-tdep.c: Fix common/ includes.
12706         * i386-fbsd-tdep.c: Fix common/ includes.
12707         * i386-fbsd-nat.c: Fix common/ includes.
12708         * guile/scm-type.c: Fix common/ includes.
12709         * guile/guile.c: Fix common/ includes.
12710         * go32-nat.c: Fix common/ includes.
12711         * gnu-nat.c: Fix common/ includes.
12712         * gdbthread.h: Fix common/ includes.
12713         * gdbarch-selftests.c: Fix common/ includes.
12714         * gdb_usleep.c: Fix common/ includes.
12715         * gdb_select.h: Fix common/ includes.
12716         * gdb_bfd.c: Fix common/ includes.
12717         * gcore.c: Fix common/ includes.
12718         * fork-child.c: Fix common/ includes.
12719         * findvar.c: Fix common/ includes.
12720         * fbsd-nat.c: Fix common/ includes.
12721         * event-top.c: Fix common/ includes.
12722         * event-loop.c: Fix common/ includes.
12723         * dwarf2read.c: Fix common/ includes.
12724         * dwarf2loc.c: Fix common/ includes.
12725         * dwarf2-frame.c: Fix common/ includes.
12726         * dwarf-index-cache.c: Fix common/ includes.
12727         * dtrace-probe.c: Fix common/ includes.
12728         * disasm-selftests.c: Fix common/ includes.
12729         * defs.h: Fix common/ includes.
12730         * csky-tdep.c: Fix common/ includes.
12731         * cp-valprint.c: Fix common/ includes.
12732         * cp-support.h: Fix common/ includes.
12733         * cp-support.c: Fix common/ includes.
12734         * corelow.c: Fix common/ includes.
12735         * completer.h: Fix common/ includes.
12736         * completer.c: Fix common/ includes.
12737         * compile/compile.c: Fix common/ includes.
12738         * compile/compile-loc2c.c: Fix common/ includes.
12739         * compile/compile-cplus-types.c: Fix common/ includes.
12740         * compile/compile-cplus-symbols.c: Fix common/ includes.
12741         * command.h: Fix common/ includes.
12742         * cli/cli-dump.c: Fix common/ includes.
12743         * cli/cli-cmds.c: Fix common/ includes.
12744         * charset.c: Fix common/ includes.
12745         * build-id.c: Fix common/ includes.
12746         * btrace.h: Fix common/ includes.
12747         * btrace.c: Fix common/ includes.
12748         * breakpoint.h: Fix common/ includes.
12749         * breakpoint.c: Fix common/ includes.
12750         * ax.h:
12751         (enum agent_op): Fix common/ includes.
12752         * ax-general.c (struct aop_map): Fix common/ includes.
12753         * ax-gdb.c: Fix common/ includes.
12754         * auxv.c: Fix common/ includes.
12755         * auto-load.c: Fix common/ includes.
12756         * arm-tdep.c: Fix common/ includes.
12757         * arch/riscv.c: Fix common/ includes.
12758         * arch/ppc-linux-common.c: Fix common/ includes.
12759         * arch/i386.c: Fix common/ includes.
12760         * arch/arm.c: Fix common/ includes.
12761         * arch/arm-linux.c: Fix common/ includes.
12762         * arch/arm-get-next-pcs.c: Fix common/ includes.
12763         * arch/amd64.c: Fix common/ includes.
12764         * arch/aarch64.c: Fix common/ includes.
12765         * arch/aarch64-insn.c: Fix common/ includes.
12766         * arch-utils.c: Fix common/ includes.
12767         * amd64-windows-tdep.c: Fix common/ includes.
12768         * amd64-tdep.c: Fix common/ includes.
12769         * amd64-sol2-tdep.c: Fix common/ includes.
12770         * amd64-obsd-tdep.c: Fix common/ includes.
12771         * amd64-nbsd-tdep.c: Fix common/ includes.
12772         * amd64-linux-tdep.c: Fix common/ includes.
12773         * amd64-linux-nat.c: Fix common/ includes.
12774         * amd64-fbsd-tdep.c: Fix common/ includes.
12775         * amd64-fbsd-nat.c: Fix common/ includes.
12776         * amd64-dicos-tdep.c: Fix common/ includes.
12777         * amd64-darwin-tdep.c: Fix common/ includes.
12778         * agent.c: Fix common/ includes.
12779         * ada-lang.h: Fix common/ includes.
12780         * ada-lang.c: Fix common/ includes.
12781         * aarch64-tdep.c: Fix common/ includes.
12782
12783 2019-01-25  Tom Tromey  <tom@tromey.com>
12784
12785         * common/create-version.sh: Use common/version.h.
12786
12787 2019-01-24  Pedro Alves  <palves@redhat.com>
12788
12789         * infrun.c (signal_stop, signal_print, signal_program)
12790         (signal_catch, signal_pass): Now arrays instead of pointers.
12791         (update_signals_program_target, do_target_resume)
12792         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12793         * linux-nat.c (linux_nat_target::pass_signals)
12794         (linux_nat_target::create_inferior, linux_nat_target::attach):
12795         Adjust.
12796         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12797         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12798         * procfs.c (procfs_target::pass_signals): Adjust.
12799         * record-full.c (record_full_target::resume): Adjust.
12800         * remote.c (remote_target::pass_signals)
12801         (remote_target::program_signals): Adjust.
12802         * target-debug.h (target_debug_print_signals): Now takes a
12803         gdb::array_view as parameter.  Adjust.
12804         * target.h (target_ops) <pass_signals, program_signals>: Replace
12805         pointer and length parameters with gdb::array_view.
12806         (target_pass_signals, target_program_signals): Likewise.
12807         * target-delegates.c: Regenerate.
12808
12809 2019-01-24  Pedro Alves  <palves@redhat.com>
12810
12811         * common/forward-scope-exit.h
12812         (forward_scope_exit::forward_scope_exit): Pass arguments to
12813         m_bind_function directly, instead of creating a std::bind and
12814         copying that.
12815
12816 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12817
12818         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12819         for static members.
12820         (pass_in_v_vfp_candidate): Likewise.
12821
12822 2019-01-23  Tom Tromey  <tom@tromey.com>
12823             Pedro Alves  <palves@redhat.com>
12824
12825         * regcache.c (class regcache_invalidator): Remove.
12826         (regcache::raw_write): Use make_scope_exit.
12827
12828 2019-01-23  Tom Tromey  <tom@tromey.com>
12829
12830         * ui-out.h (class ui_out_emit_type): Update comment.
12831
12832 2019-01-23  Tom Tromey  <tom@tromey.com>
12833
12834         * infrun.c (fetch_inferior_event): Update comment.
12835
12836 2019-01-23  Tom Tromey  <tom@tromey.com>
12837             Pedro Alves  <palves@redhat.com>
12838
12839         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12840         parameter.
12841         (fetch_inferior_event): Use SCOPE_EXIT.
12842
12843
12844 2019-01-23  Tom Tromey  <tom@tromey.com>
12845             Pedro Alves  <palves@redhat.com>
12846
12847         * infrun.c (disable_thread_events): Delete.
12848         (stop_all_threads): Use SCOPE_EXIT.
12849
12850 2019-01-23  Tom Tromey  <tom@tromey.com>
12851             Pedro Alves  <palves@redhat.com>
12852
12853         * symfile.c: Include forward-scope-exit.h.
12854         (clear_symtab_users_cleanup): Replace forward declaration with
12855         a FORWARD_SCOPE_EXIT.
12856         (syms_from_objfile_1): Use the forward_scope_exit and
12857         gdb::optional instead of cleanup_function.
12858         (reread_symbols): Use the forward_scope_exit instead of
12859         cleanup_function.
12860         (clear_symtab_users_cleanup): Remove function.
12861
12862 2019-01-23  Tom Tromey  <tom@tromey.com>
12863             Pedro Alves  <palves@redhat.com>
12864
12865         * linux-nat.c: Include scope-exit.h.
12866         (cleanup_target_stop): Remove.
12867         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12868         SCOPE_EXIT.
12869
12870 2019-01-23  Tom Tromey  <tom@tromey.com>
12871             Pedro Alves  <palves@redhat.com>
12872
12873         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12874         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12875
12876 2019-01-23  Tom Tromey  <tom@tromey.com>
12877             Andrew Burgess  <andrew.burgess@embecosm.com>
12878             Pedro Alves  <palves@redhat.com>
12879
12880         * infrun.c (fetch_inferior_event): Use scope_exit.
12881         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12882         * top.c (execute_command): Use scope_exit.
12883         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12884         * utils.c (do_bpstat_clear_actions_cleanup)
12885         (make_bpstat_clear_actions_cleanup): Remove.
12886
12887 2019-01-23  Tom Tromey  <tom@tromey.com>
12888             Pedro Alves  <palves@redhat.com>
12889
12890         * infrun.c: Include "common/scope-exit.h"
12891         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12892         (wait_for_inferior): Use SCOPE_EXIT.
12893         (fetch_inferior_event): Use scope_exit.
12894
12895 2019-01-23  Tom Tromey  <tom@tromey.com>
12896             Pedro Alves  <palves@redhat.com>
12897
12898         * breakpoint.c (create_breakpoint): Remove cleanup.
12899
12900 2019-01-23  Tom Tromey  <tom@tromey.com>
12901             Andrew Burgess  <andrew.burgess@embecosm.com>
12902             Pedro Alves  <palves@redhat.com>
12903
12904 2019-01-23  Pedro Alves  <palves@redhat.com>
12905
12906         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12907
12908 2019-01-23  Pedro Alves  <palves@redhat.com>
12909             Andrew Burgess  <andrew.burgess@embecosm.com>
12910
12911         * gdbthread.h: Include "common/forward-scope-exit.h".
12912         (scoped_finish_thread_state): Redefine custom class in terms of
12913         forward_scope_exit.
12914
12915 2019-01-23  Pedro Alves  <palves@redhat.com>
12916             Andrew Burgess  <andrew.burgess@embecosm.com>
12917
12918         * common/forward-scope-exit.h: New file.
12919
12920 2019-01-23  Pedro Alves  <palves@redhat.com>
12921             Andrew Burgess  <andrew.burgess@embecosm.com>
12922             Tom Tromey  <tom@tromey.com>
12923
12924         * common/scope-exit.h: New file.
12925
12926 2019-01-23  Pedro Alves  <palves@redhat.com>
12927
12928         * common/preprocessor.h (ESC): Rename to ...
12929         (ESC_PARENS): ... this.
12930         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12931         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12932
12933 2019-01-23  Tom Tromey  <tom@tromey.com>
12934
12935         * language.h (class scoped_switch_to_sym_language_if_auto):
12936         Initialize m_lang in both cases.
12937
12938 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12939
12940         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12941         with XCNEW.
12942
12943 2019-01-22  Tom Tromey  <tom@tromey.com>
12944
12945         * corelow.c: Do not include sys/file.h.
12946
12947 2019-01-22  Tom Tromey  <tom@tromey.com>
12948
12949         * tui/tui-wingeneral.h: Include gdb_curses.h.
12950
12951 2019-01-22  Tom Tromey  <tom@tromey.com>
12952
12953         * source-cache.h (class source_cache) <get_source_lines,
12954         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12955
12956 2019-01-22  Tom Tromey  <tom@tromey.com>
12957
12958         * remote-fileio.h (struct remote_target): Declare.
12959
12960 2019-01-22  Tom Tromey  <tom@tromey.com>
12961
12962         * python/py-arch.c: Do not include py-ref.h.
12963         * python/py-bpevent.c: Do not include py-ref.h.
12964         * python/py-cmd.c: Do not include py-ref.h.
12965         * python/py-continueevent.c: Do not include py-ref.h.
12966         * python/py-event.h: Do not include py-ref.h.
12967         * python/py-evtregistry.c: Do not include py-ref.h.
12968         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12969         * python/py-frame.c: Do not include py-ref.h.
12970         * python/py-framefilter.c: Do not include py-ref.h.
12971         * python/py-function.c: Do not include py-ref.h.
12972         * python/py-infevents.c: Do not include py-ref.h.
12973         * python/py-linetable.c: Do not include py-ref.h.
12974         * python/py-objfile.c: Do not include py-ref.h.
12975         * python/py-param.c: Do not include py-ref.h.
12976         * python/py-prettyprint.c: Do not include py-ref.h.
12977         * python/py-progspace.c: Do not include py-ref.h.
12978         * python/py-symbol.c: Do not include py-ref.h.
12979         * python/py-symtab.c: Do not include py-ref.h.
12980         * python/py-type.c: Do not include py-ref.h.
12981         * python/py-unwind.c: Do not include py-ref.h.
12982         * python/py-utils.c: Do not include py-ref.h.
12983         * python/py-value.c: Do not include py-ref.h.
12984         * python/py-varobj.c: Do not include py-ref.h.
12985         * python/py-xmethods.c: Do not include py-ref.h.
12986         * python/python.c: Do not include py-ref.h.
12987         * varobj.c: Do not include py-ref.h.
12988
12989 2019-01-22  Tom Tromey  <tom@tromey.com>
12990
12991         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12992         keyword for bcache.
12993
12994 2019-01-22  Tom Tromey  <tom@tromey.com>
12995
12996         * compile/compile-cplus-types.c: Remove a comment by #include.
12997
12998 2019-01-22  Tom Tromey  <tom@tromey.com>
12999
13000         * compile/gcc-c-plugin.h: Include compile-internal.h.
13001
13002 2019-01-22  Tom Tromey  <tom@tromey.com>
13003
13004         * stabsread.c (EXTERN): Do not define.
13005         (symnum, next_symbol_text_func, processing_gcc_compilation)
13006         (within_function, global_sym_chain, global_stabs)
13007         (previous_stab_code, this_object_header_files)
13008         (n_this_object_header_files)
13009         (n_allocated_this_object_header_files): Define.
13010         * stabsread.h (EXTERN): Never define.  Use "extern".
13011
13012 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13013
13014         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13015         history_value.
13016
13017 2019-01-21  Tom Tromey  <tom@tromey.com>
13018
13019         * ui-out.c: Fix includes.
13020         * tui/tui-source.c: Fix includes.
13021         * target.c: Fix includes.
13022         * remote.c: Fix includes.
13023         * regcache.c: Fix includes.
13024         * python/py-block.c: Fix includes.
13025         * printcmd.c: Fix includes.
13026         * or1k-tdep.c: Fix includes.
13027         * mi/mi-main.c: Fix includes.
13028         * m32r-tdep.c: Fix includes.
13029         * csky-tdep.c: Fix includes.
13030         * compile/compile-cplus-types.c: Fix includes.
13031         * cli/cli-interp.c: Fix includes.
13032
13033 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13034
13035         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13036         for padding.
13037
13038 2019-01-16  Tom Tromey  <tom@tromey.com>
13039
13040         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13041         earlier.
13042         (struct objfile) <msymbols_range>: Move from top level.
13043         <msymbols>: New method.
13044         (class objfile_msymbols): Remove.
13045         * symtab.c (default_collect_symbol_completion_matches_break_on):
13046         Update.
13047         * symmisc.c (dump_msymbols): Update.
13048         * stabsread.c (scan_file_globals): Update.
13049         * objc-lang.c (info_selectors_command, info_classes_command)
13050         (find_methods): Update.
13051         * minsyms.c (find_solib_trampoline_target): Update.
13052         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13053         * coffread.c (coff_symfile_read): Update.
13054         * ada-lang.c (ada_lookup_simple_minsym)
13055         (ada_collect_symbol_completion_matches): Update.
13056
13057 2019-01-16  Tom Tromey  <tom@tromey.com>
13058
13059         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13060         type.  Remove no-argument constructor.
13061         <iterator::operator++>: Simplify.
13062         <begin>: Update.
13063         <end>: Use minimal_symbol_count.
13064
13065 2019-01-16  Tom Tromey  <tom@tromey.com>
13066
13067         * objfiles.h (struct objfile) <psymtabs>: New method.
13068         (class objfile_psymtabs): Remove.
13069         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13070         typedef.
13071         <range>: New method.
13072         (require_partial_symbols): Change return type.
13073         * psymtab.c (require_partial_symbols)
13074         (psym_expand_symtabs_matching): Update.
13075         * mdebugread.c (parse_partial_symbols): Update.
13076         * dbxread.c (dbx_end_psymtab): Update.
13077
13078 2019-01-15  Tom Tromey  <tom@tromey.com>
13079
13080         * symtab.c (lookup_objfile_from_block)
13081         (lookup_symbol_in_objfile_symtabs)
13082         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13083         (find_line_symtab, info_sources_command)
13084         (default_collect_symbol_completion_matches_break_on)
13085         (make_source_files_completion_list): Update.
13086         * symmisc.c (print_objfile_statistics, dump_objfile)
13087         (maintenance_print_symbols, maintenance_info_symtabs)
13088         (maintenance_check_symtabs, maintenance_info_line_tables):
13089         Update.
13090         * source.c (select_source_symtab)
13091         (forget_cached_source_info_for_objfile): Update.
13092         * objfiles.h (class objfile_compunits): Remove.
13093         (struct objfile) <compunits_range>: New typedef.
13094         (compunits): New method.
13095         * objfiles.c (objfile_relocate1): Update.
13096         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13097         * maint.c (count_symtabs_and_blocks): Update.
13098         * linespec.c (iterate_over_all_matching_symtabs): Update.
13099         * cp-support.c (add_symbol_overload_list_qualified): Update.
13100         * coffread.c (coff_symtab_read): Update.
13101         * ada-lang.c (add_nonlocal_symbols)
13102         (ada_collect_symbol_completion_matches)
13103         (ada_add_global_exceptions): Update.
13104
13105 2019-01-15  Tom Tromey  <tom@tromey.com>
13106
13107         * progspace.h (program_space) <objfiles_safe_range>: New
13108         typedef.
13109         <objfiles_safe>: New method.
13110         * objfiles.h (class all_objfiles_safe): Remove.
13111         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13112         * jit.c (jit_inferior_exit_hook): Update.
13113
13114 2019-01-17  Tom Tromey  <tom@tromey.com>
13115
13116         * progspace.h (program_space) <objfiles_range>: New typedef.
13117         <objfiles>: New method.
13118         <objfiles_head>: Rename from objfiles.
13119         (object_files): Update.
13120         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13121         * guile/scm-pretty-print.c
13122         (ppscm_find_pretty_printer_from_objfiles): Update.
13123         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13124         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13125         Update.
13126         * python/py-progspace.c (pspy_get_objfiles): Update.
13127         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13128         Update.
13129         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13130         (objfpy_lookup_objfile_by_build_id): Update.
13131         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13132         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13133         Update.
13134         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13135         (expand_symtab_containing_pc, lookup_objfile_from_block)
13136         (lookup_static_symbol, basic_lookup_transparent_type)
13137         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13138         (find_line_symtab, info_sources_command)
13139         (default_collect_symbol_completion_matches_break_on)
13140         (make_source_files_completion_list, find_main_name): Update.
13141         * symmisc.c (print_symbol_bcache_statistics)
13142         (print_objfile_statistics, maintenance_print_symbols)
13143         (maintenance_print_msymbols, maintenance_print_objfiles)
13144         (maintenance_info_symtabs, maintenance_check_symtabs)
13145         (maintenance_expand_symtabs, maintenance_info_line_tables):
13146         Update.
13147         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13148         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13149         (map_overlay_command, unmap_overlay_command)
13150         (simple_overlay_update, expand_symtabs_matching)
13151         (map_symbol_filenames): Update.
13152         * symfile-debug.c (set_debug_symfile): Update.
13153         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13154         Update.
13155         * source.c (select_source_symtab, forget_cached_source_info):
13156         Update.
13157         * solib.c (solib_read_symbols): Update.
13158         * solib-spu.c (append_ocl_sos): Update.
13159         * psymtab.c (maintenance_print_psymbols)
13160         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13161         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13162         * printcmd.c (info_symbol_command): Update.
13163         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13164         Update.
13165         * objfiles.h (class all_objfiles): Remove.
13166         * objfiles.c (have_partial_symbols, have_full_symbols)
13167         (have_minimal_symbols, qsort_cmp, update_section_map)
13168         (shared_objfile_contains_address_p)
13169         (default_iterate_over_objfiles_in_search_order): Update.
13170         * objc-lang.c (info_selectors_command, info_classes_command)
13171         (find_methods): Update.
13172         * minsyms.c (find_solib_trampoline_target): Update.
13173         * maint.c (maintenance_info_sections)
13174         (maintenance_translate_address, count_symtabs_and_blocks):
13175         Update.
13176         * main.c (captured_main_1): Update.
13177         * linux-thread-db.c (try_thread_db_load_from_pdir)
13178         (has_libpthread): Update.
13179         * linespec.c (iterate_over_all_matching_symtabs)
13180         (search_minsyms_for_name): Update.
13181         * jit.c (jit_find_objf_with_entry_addr): Update.
13182         * hppa-tdep.c (find_unwind_entry)
13183         (hppa_lookup_stub_minimal_symbol): Update.
13184         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13185         Update.
13186         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13187         (elf_gnu_ifunc_resolve_by_got): Update.
13188         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13189         * dwarf-index-write.c (save_gdb_index_command): Update.
13190         * cp-support.c (add_symbol_overload_list_qualified): Update.
13191         * breakpoint.c (create_overlay_event_breakpoint)
13192         (create_longjmp_master_breakpoint)
13193         (create_std_terminate_master_breakpoint)
13194         (create_exception_master_breakpoint): Update.
13195         * blockframe.c (find_pc_partial_function): Update.
13196         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13197         (ada_collect_symbol_completion_matches)
13198         (ada_add_global_exceptions): Update.
13199
13200 2019-01-17  Tom Tromey  <tom@tromey.com>
13201
13202         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13203         declare VEC.
13204         (solib_target_parse_libraries): Change return type.
13205         (library_list_start_segment, library_list_start_section)
13206         (library_list_end_library, library_list_start_library); Update.
13207         (solib_target_free_library_list): Remove.
13208         (solib_target_parse_libraries): Remove cleanup.  Change return
13209         type.
13210         (solib_target_current_sos): Update.
13211
13212 2019-01-17  Tom Tromey  <tromey@bapiya>
13213
13214         * valprint.c: Replace "the the" with "the".
13215         * symtab.c: Replace "the the" with "the".
13216         * solib.c: Replace "the the" with "the".
13217         * solib-dsbt.c: Replace "the the" with "the".
13218         * linespec.c: Replace "the the" with "the".
13219         * dwarf2loc.h: Replace "the the" with "the".
13220         * amd64-windows-tdep.c: Replace "the the" with "the".
13221         * aarch64-tdep.c: Replace "the the" with "the".
13222
13223 2019-01-16  Keith Seitz  <keiths@redhat.com>
13224
13225         PR gdb/23773
13226         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13227         <builder>: Rename to ..
13228         <m_builder>: ... this and make private.
13229         (dwarf2_cu::get_builder): New method.  Change all users of
13230         `builder' to use this method.
13231         (dwarf2_start_symtab): Move to ...
13232         (dwarf2_cu::start_symtab): ... here.  Update all callers
13233         (setup_type_unit_groups): Move to ...
13234         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13235         callers.
13236         (dwarf2_cu::reset_builder): New method.
13237         (process_full_compunit, process_full_type_unit): Use
13238         dwarf2_cu::reset_builder.
13239         (follow_die_offset): Record the ancestor CU if it is different
13240         from the followed DIE's CU.
13241         (follow_die_sig_1): Likewise.
13242
13243 2019-01-15  Tom Tromey  <tom@tromey.com>
13244
13245         * remote.c (class remote_state) <buf>: Now a char_vector.
13246         <buf_size>: Remove.
13247         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13248         parameter.
13249         (remote_target::getpkt_or_notif_sane_1)
13250         (remote_target::getpkt_sane)
13251         (remote_target::getpkt_or_notif_sane): Likewise.
13252         (class remote_target) <putpkt>: New overload.
13253         (remote_target::read_frame): Change type of "buf_p".  Remove
13254         sizeof_p parameter.
13255         (packet_ok): New overload.
13256         (packet_check_result): New overload.
13257         Update all uses.
13258
13259 2019-01-14  Tom Tromey  <tom@tromey.com>
13260
13261         * remote-notif.c (handle_notification, remote_notif_ack)
13262         (remote_notif_parse): Make "buf" const.
13263         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13264         const.
13265         (remote_notif_parse, remote_notif_ack, handle_notification):
13266         Likewise.
13267         * remote.c (remote_notif_stop_parse): Make "buf" const.
13268         (remote_target::remote_parse_stop_reply): Make "buf" const.
13269         (remote_notif_stop_ack): Make "buf" const.
13270
13271 2019-01-14  Tom Tromey  <tom@tromey.com>
13272
13273         * remote.c (remote_console_output): Make parameter const.
13274
13275 2019-01-14  Tom Tromey  <tom@tromey.com>
13276
13277         * target-debug.h (target_debug_print_signals): Constify.
13278         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13279         * procfs.c (procfs_target::pass_signals): Update.
13280         * linux-nat.c (linux_nat_target::pass_signals): Update.
13281         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13282         * target-delegates.c: Rebuild.
13283         * remote.c (remote_target::program_signals): Update.
13284         (remote_target::pass_signals): Update.
13285         * target.c (target_pass_signals): Constify argument.
13286         (target_program_signals): Likewise.
13287         * target.h (struct target_ops) <pass_signals, program_signals>:
13288         Constify argument.
13289         (target_pass_signals, target_program_signals): Constify argument.
13290
13291 2019-01-14  Tom Tromey  <tom@tromey.com>
13292
13293         PR tui/28819:
13294         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13295
13296 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13297
13298         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13299         field.
13300         * rs6000-tdep.c: Include reggroups.h.
13301         (IS_V_ALIAS_PSEUDOREG): Define.
13302         (rs6000_register_name): Return names for the "vX" aliases.
13303         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13304         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13305         aliases.  Call default_register_reggroup_p for all other
13306         pseudo-registers.
13307         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13308         New functions.
13309         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13310         Handle "vX" aliases.
13311         (v_alias_pseudo_register_collect): New function.
13312         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13313         (rs6000_gdbarch_init): Initialize "vX" aliases as
13314         pseudo-registers.  Restore registration of
13315         rs6000_pseudo_register_reggroup_p with
13316         set_tdesc_pseudo_register_reggroup_p.
13317
13318 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13319
13320         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13321         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13322         set_gdbarch_num_pseudo_regs.
13323
13324 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13325
13326         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13327         Remove arg prefixname, add do_set and do_show.
13328         Add member functions set_list and show_list.
13329         * cli/cli-style.c (class cli_style_option): Update accordingly.
13330         (style_set_list): Move to file scope.
13331         (style_show_list): Likewise.
13332         (set_style): Call help_list.
13333         (show_style): Call cmd_show_list.
13334         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13335         Update to use the new macro.
13336
13337 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13338
13339         * ada-lang.c (_initialize_ada_language): Expand the help text
13340         for the "catch exception" command.
13341
13342 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13343
13344         * symtab.c (matching_obj_sections): Initialize obj,
13345         declare it closer to its usage.
13346
13347 2019-01-10  Tom Tromey  <tom@tromey.com>
13348
13349         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13350         (basic_inf_threads_range): Remove.
13351         (inf_threads_range, inf_non_exited_threads_range)
13352         (safe_inf_threads_range): Use next_adapter.
13353
13354 2019-01-10  Keith Seitz  <keiths@redhat.com>
13355
13356         PR gdb/23712
13357         PR symtab/23010
13358         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13359         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13360
13361 2019-01-10  Keith Seitz  <keiths@redhat.com>
13362
13363         PR gdb/23712
13364         PR symtab/23010
13365         * dictionary.c (pending_to_vector): Remove.
13366         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13367         Remove _1 suffix, replacing functions of the same name.  Update
13368         all callers.
13369         (dict_create_hashed, dict_create_hashed_expandable)
13370         (dict_create_linear, dict_create_linear_expandable, dict_free)
13371         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13372         Make functions static.
13373
13374 2019-01-10  Keith Seitz  <keiths@redhat.com>
13375
13376         PR gdb/23712
13377         PR symtab/23010
13378         * dictionary.h (struct dictionary): Replace declaration with
13379         multidictionary.
13380         (dict_create_hashed, dict_create_hashed_expandable)
13381         (dict_create_linear, dict_create_linear_expandable)
13382         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13383         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13384         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13385         taking multidictionary argument.
13386         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13387         * block.h (struct block) <dict>: Change to multidictionary
13388         and rename `multidict'.
13389         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13390         symmisc.c: Update all dictionary references to multidictionary.
13391
13392 2019-01-10  Keith Seitz  <keiths@redhat.com>
13393
13394         PR gdb/23712
13395         PR symtab/23010
13396         * dictionary.c: Include unordered_map.
13397         (pending_to_vector): New function.
13398         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13399         Rewrite the non-"_1" functions to take vector instead
13400         of linked list.
13401         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13402         "new" _1 versions of the same name.
13403         (multidictionary): Define.
13404         (std::hash<enum language): New definition.
13405         (collate_pending_symbols_by_language, mdict_create_hashed)
13406         (mdict_create_hashed_expandable, mdict_create_linear)
13407         (mdict_create_linear_expandable, mdict_free)
13408         (find_language_dictionary, create_new_language_dictionary)
13409         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13410         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13411         (mdict_size, mdict_empty): New functions.
13412         * dictionary.h (mdict_iterator): Define.
13413
13414 2019-01-10  Pedro Alves  <palves@redhat.com>
13415
13416         * breakpoint.c (read_uploaded_action)
13417         (create_tracepoint_from_upload): Adjust to use
13418         gdb::unique_xmalloc_ptr.
13419         * ctf.c (ctf_write_uploaded_tp):
13420         (SET_ARRAY_FIELD): Use emplace_back.
13421         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13422         * tracefile-tfile.c (tfile_write_uploaded_tp):
13423         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13424         gdb::unique_xmalloc_ptr.
13425         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13426         at_string, cond_string, cmd_strings>: Replace char pointers
13427         with gdb::unique_xmalloc_ptr.
13428
13429 2019-01-10  Pedro Alves  <palves@redhat.com>
13430
13431         * solib-target.c (library_list_start_library): Don't xstrdup name.
13432
13433 2019-01-10  Pedro Alves  <palves@redhat.com>
13434
13435         * mdebugread.c (parse_partial_symbols): Use
13436         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13437
13438 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13439
13440         * linux-fork.c (scoped_switch_fork_info)
13441         <~scoped_switch_fork_info>: Fix incorrect variable name.
13442
13443 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13444
13445         * linux-fork.c (scoped_switch_fork_info)
13446         <scoped_switch_fork_info>: Make explicit.
13447         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13448
13449 2019-01-10  Tom Tromey  <tom@tromey.com>
13450
13451         * objfiles.h (objfile::reset_psymtabs): Update.
13452         * objfiles.c (objfile::objfile): Update.
13453         * psymtab.h (psymtab_storage::obstack): Update.
13454         (psymtab_storage::m_obstack): Use gdb::optional.
13455         (class psymtab_storage): Update comment.  Remove objfile
13456         parameter.
13457         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13458
13459 2019-01-10  Tom Tromey  <tom@tromey.com>
13460
13461         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13462         <free_psymtabs>: Now private.
13463         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13464         (allocate_psymtab): Use new method.
13465
13466 2019-01-10  Tom Tromey  <tom@tromey.com>
13467
13468         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13469         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13470         * mdebugread.c (parse_partial_symbols): Use
13471         allocate_dependencies.
13472         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13473         allocate_dependencies.
13474         (process_psymtab_comp_unit_reader)
13475         (build_type_psymtab_dependencies): Likewise.
13476         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13477
13478 2019-01-10  Tom Tromey  <tom@tromey.com>
13479
13480         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13481         PSYMBOL_SET_LANGUAGE.
13482         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13483
13484 2019-01-10  Tom Tromey  <tom@tromey.com>
13485
13486         * psymtab.h (psymtab_storage::obstack): New method.
13487         <m_obstack>: Rename from obstack; now private.
13488         * psymtab.c (psymtab_storage): Update.
13489         * dwarf2read.c (create_addrmap_from_index)
13490         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13491         Update.
13492
13493 2019-01-10  Tom Tromey  <tom@tromey.com>
13494
13495         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13496         * objfiles.h (objfile::reset_psymtabs): New method.
13497
13498 2019-01-10  Tom Tromey  <tom@tromey.com>
13499
13500         * symmisc.c (print_symbol_bcache_statistics): Update.
13501         (print_objfile_statistics): Update.
13502         * symfile.c (reread_symbols): Update.
13503         * psymtab.h (class psymtab_storage): New.
13504         * psymtab.c (psymtab_storage): New constructor.
13505         (~psymtab_storage): New destructor.
13506         (require_partial_symbols): Update.
13507         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13508         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13509         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13510         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13511         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13512         (start_psymtab_common, end_psymtab_common)
13513         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13514         (allocate_psymtab): Update.
13515         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13516         Update.
13517         (dump_psymtab_addrmap, maintenance_print_psymbols)
13518         (maintenance_check_psymtabs): Update.
13519         (class objfile_psymtabs): Move to objfiles.h.
13520         * psympriv.h (discard_psymtab): Now inline.
13521         (psymtab_discarder::psymtab_discarder): Update.
13522         (psymtab_discarder::~psymtab_discarder): Update.
13523         (ALL_OBJFILE_PSYMTABS): Rewrite.
13524         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13525         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13526         Remove fields.
13527         <partial_symtabs>: New field.
13528         (class objfile_psymtabs): Move from psymtab.h.  Update.
13529         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13530         psymbol_cache.
13531         (objfile::~objfile): Don't destroy psymbol_cache.
13532         * mdebugread.c (parse_partial_symbols): Update.
13533         * dwarf2read.c (create_addrmap_from_index)
13534         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13535         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13536         (add_partial_subprogram, dwarf2_ranges_read): Update.
13537         * dwarf-index-write.c (write_address_map)
13538         (write_one_signatured_type, recursively_write_psymbols)
13539         (class debug_names, class debug_names, write_psymtabs_to_index):
13540         Update.
13541
13542 2019-01-10  Tom Tromey  <tom@tromey.com>
13543
13544         * symtab.h (SYMBOL_SET_NAMES): Update.
13545         (symbol_set_names): Update.
13546         (MSYMBOL_SET_NAMES): Update.
13547         * symtab.c (symbol_set_names): Change argument to be an
13548         objfile_per_bfd_storage.
13549         * psymtab.c (add_psymbol_to_bcache): Update.
13550         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13551
13552 2019-01-10  Tom Tromey  <tom@tromey.com>
13553
13554         * symtab.c (create_demangled_names_hash): Change argument to be an
13555         objfile_per_bfd_storage.
13556         (symbol_set_names): Update.
13557
13558 2019-01-10  Tom Tromey  <tom@tromey.com>
13559
13560         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13561         init_psymbol_list.
13562         * psymtab.c (init_psymbol_list): Do nothing if already called.
13563         * psympriv.h (init_psymbol_list): Add comment.
13564         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13565         init_psymbol_list.
13566         * dbxread.c (dbx_symfile_read): Unconditionally call
13567         init_psymbol_list.
13568
13569 2019-01-10  Tom Tromey  <tom@tromey.com>
13570
13571         * xcoffread.c (scan_xcoff_symtab): Update.
13572         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13573         "where".
13574         * mdebugread.c (parse_partial_symbols)
13575         (handle_psymbol_enumerators): Update.
13576         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13577         * dbxread.c (read_dbx_symtab): Update.
13578         * psympriv.h (psymbol_placement): New enum.
13579         (add_psymbol_to_list): Update.
13580
13581 2019-01-10  Tom Tromey  <tom@tromey.com>
13582
13583         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13584         static_psymbols parameters.
13585         (scan_xcoff_symtab): Update.
13586         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13587         static_psymbols parameters.
13588         * psympriv.h (start_psymtab_common): Update.
13589         * mdebugread.c (parse_partial_symbols): Update.
13590         * dwarf2read.c (create_partial_symtab): Update.
13591         * dbxread.c (read_dbx_symtab): Update.
13592         (start_psymtab): Remove global_psymbols and static_psymbols
13593         parameters.
13594
13595 2019-01-10  Tom Tromey  <tom@tromey.com>
13596
13597         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13598         * psymtab.c (allocate_psymtab): Add comment.
13599         * psympriv.h (allocate_psymtab): Add comment.
13600         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13601         initializations.
13602         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13603
13604 2019-01-10  Tom Tromey  <tom@tromey.com>
13605
13606         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13607         Don't declare.
13608         * mipsread.c: Include mdebugread.h.
13609         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13610         Declare.
13611         * elfread.c: Include mdebugread.h.
13612
13613 2019-01-09  Tom Tromey  <tom@tromey.com>
13614
13615         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13616         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13617         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13618         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13619         (psym_lookup_symbol, psym_find_last_source_symtab)
13620         (psym_forget_cached_source_info, psym_print_stats)
13621         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13622         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13623         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13624         (psym_find_compunit_symtab_by_address)
13625         (maintenance_print_psymbols, maintenance_info_psymtabs)
13626         (maintenance_check_psymtabs): Use ranged for.
13627         * psymtab.h (class objfile_psymtabs): New.
13628         (require_partial_symbols): Return objfile_psymtabs.
13629         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13630
13631 2019-01-09  Tom Tromey  <tom@tromey.com>
13632
13633         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13634         (find_pc_mapped_section, list_overlays_command)
13635         (map_overlay_command, unmap_overlay_command)
13636         (simple_overlay_update): Use all_objfiles.
13637         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13638         * printcmd.c (info_symbol_command): Use all_objfiles.
13639         * objfiles.h (ALL_OBJSECTIONS): Remove.
13640         * maint.c (maintenance_translate_address): Use all_objfiles.
13641         * gcore.c (gcore_create_callback): Use all_objfiles.
13642         (objfile_find_memory_regions): Likewise.
13643
13644 2019-01-09  Tom Tromey  <tom@tromey.com>
13645
13646         * symtab.c (find_line_symtab, info_sources_command)
13647         (make_source_files_completion_list): Use objfile_compunits.
13648         * source.c (select_source_symtab): Use objfile_compunits.
13649         * objfiles.h (struct objfile): Update comment.
13650         (ALL_OBJFILES): Remove.
13651         (ALL_FILETABS): Remove.
13652         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13653         objfile_compunits.
13654
13655 2019-01-09  Tom Tromey  <tom@tromey.com>
13656
13657         * symmisc.c (print_objfile_statistics, dump_objfile)
13658         (maintenance_print_symbols): Use compunit_filetabs.
13659         * source.c (forget_cached_source_info_for_objfile): Use
13660         compunit_filetabs.
13661         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13662         (ALL_FILETABS): Use compunit_filetabs.
13663         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13664         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13665
13666 2019-01-09  Tom Tromey  <tom@tromey.com>
13667
13668         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13669         (compunit_filetabs): New.
13670         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13671         compunit_filetabs.
13672         (info_sources_command, make_source_files_completion_list): Remove
13673         declaration.
13674         * symmisc.c (print_objfile_statistics, dump_objfile)
13675         (maintenance_print_symbols): Remove declaration.
13676         (maintenance_info_symtabs): Use compunit_filetabs.
13677         (maintenance_info_line_tables): Likewise.
13678         * source.c (select_source_symtab): Change local variable name.
13679         (forget_cached_source_info_for_objfile): Remove declaration.
13680         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13681         * objfiles.c (objfile_relocate1): Remove declaration.
13682         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13683         declaration.
13684         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13685         * coffread.c (coff_symtab_read): Remove declaration.
13686         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13687         compunit_filetabs.
13688
13689 2019-01-09  Tom Tromey  <tom@tromey.com>
13690
13691         * symtab.c (lookup_objfile_from_block)
13692         (find_pc_sect_compunit_symtab, search_symbols)
13693         (default_collect_symbol_completion_matches_break_on): Use
13694         objfile_compunits.
13695         * objfiles.h (ALL_COMPUNITS): Remove.
13696         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13697         * cp-support.c (add_symbol_overload_list_qualified): Use
13698         objfile_compunits.
13699         * ada-lang.c (ada_collect_symbol_completion_matches)
13700         (ada_add_global_exceptions): Use objfile_compunits.
13701
13702 2019-01-09  Tom Tromey  <tom@tromey.com>
13703
13704         * source.c (select_source_symtab)
13705         (forget_cached_source_info_for_objfile): Remove declaration.
13706         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13707         declaration.
13708         * maint.c (count_symtabs_and_blocks): Remove declaration.
13709         * cp-support.c (add_symbol_overload_list_qualified): Remove
13710         declaration.
13711         * coffread.c (coff_symtab_read): Remove declaration.
13712         * symtab.c (lookup_symbol_in_objfile_symtabs)
13713         (basic_lookup_transparent_type_1): Use objfile_compunits.
13714         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13715         (info_sources_command, search_symbols)
13716         (default_collect_symbol_completion_matches_break_on)
13717         (make_source_files_completion_list): Remove declaration.
13718         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13719         (ada_collect_symbol_completion_matches)
13720         (ada_add_global_exceptions): Remove declaration.
13721         * linespec.c (iterate_over_all_matching_symtabs): Use
13722         objfile_compunits.
13723         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13724         (class objfile_compunits): New.
13725         (ALL_COMPUNITS): Use objfile_compunits.
13726         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13727         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13728         objfile_compunits.
13729         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13730
13731 2019-01-09  Tom Tromey  <tom@tromey.com>
13732
13733         * symtab.c (search_symbols)
13734         (default_collect_symbol_completion_matches_break_on): Use
13735         objfile_msymbols.
13736         * ada-lang.c (ada_lookup_simple_minsym)
13737         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13738         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13739         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13740         objfile_msymbols.
13741         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13742         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13743         * objc-lang.c (find_methods): Use objfile_msymbols.
13744         (info_selectors_command, info_classes_command): Likewise.
13745         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13746         * objfiles.h (class objfile_msymbols): New.
13747         (ALL_OBJFILE_MSYMBOLS): Remove.
13748         (ALL_MSYMBOLS): Remove.
13749
13750 2019-01-09  Tom Tromey  <tom@tromey.com>
13751
13752         * common/next-iterator.h (next_adapter): Add Iterator template
13753         parameter.
13754         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13755         (class all_objfiles_safe): New.
13756         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13757         * objfiles.c (put_objfile_before): Update comment.
13758         (add_separate_debug_objfile): Likewise.
13759         (free_all_objfiles): Use all_objfiles_safe.
13760         (objfile_purge_solibs): Likewise.
13761
13762 2019-01-09  Tom Tromey  <tom@tromey.com>
13763
13764         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13765         (expand_symtab_containing_pc, lookup_static_symbol)
13766         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13767         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13768         all_objfiles.
13769         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13770         * breakpoint.c (create_overlay_event_breakpoint)
13771         (create_longjmp_master_breakpoint)
13772         (create_std_terminate_master_breakpoint)
13773         (create_exception_master_breakpoint): Use all_objfiles.
13774         * linux-thread-db.c (try_thread_db_load_from_pdir)
13775         (has_libpthread): Use all_objfiles.
13776         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13777         * linespec.c (iterate_over_all_matching_symtabs)
13778         (search_minsyms_for_name): Use all_objfiles.
13779         * maint.c (maintenance_info_sections): Use all_objfiles.
13780         * main.c (captured_main_1): Use all_objfiles.
13781         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13782         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13783         * guile/scm-pretty-print.c
13784         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13785         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13786         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13787         (maintenance_print_msymbols): Use all_objfiles.
13788         * source.c (select_source_symtab): Use all_objfiles.
13789         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13790         * symfile.c (remove_symbol_file_command)
13791         (expand_symtabs_matching, map_symbol_filenames): Use
13792         all_objfiles.
13793         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13794         all_objfiles.
13795         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13796         * objc-lang.c (find_methods): Use all_objfiles.
13797         * objfiles.c (have_partial_symbols, have_full_symbols)
13798         (have_minimal_symbols, qsort_cmp)
13799         (default_iterate_over_objfiles_in_search_order): Use
13800         all_objfiles.
13801         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13802         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13803         (maintenance_check_psymtabs): Use all_objfiles.
13804         (ALL_PSYMTABS): Remove.
13805         * compile/compile-object-run.c (do_module_cleanup): Use
13806         all_objfiles.
13807         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13808         * cp-support.c (add_symbol_overload_list_qualified): Use
13809         all_objfiles.
13810         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13811         Use all_objfiles.
13812         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13813         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13814         all_objfiles.
13815         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13816         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13817         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13818         Uses all_objfiles.
13819         * solib.c (solib_read_symbols): Use all_objfiles
13820
13821 2019-01-09  Tom Tromey  <tom@tromey.com>
13822
13823         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13824         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13825         all_objfiles.
13826         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13827         * symmisc.c (print_symbol_bcache_statistics)
13828         (print_objfile_statistics, maintenance_print_objfiles)
13829         (maintenance_info_symtabs, maintenance_check_symtabs)
13830         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13831         all_objfiles.
13832         * source.c (forget_cached_source_info): Use all_objfiles.
13833         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13834         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13835         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13836         * objfiles.c (update_section_map): Use all_objfiles.
13837         (shared_objfile_contains_address_p): Likewise.
13838         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13839         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13840
13841 2019-01-09  Tom Tromey  <tom@tromey.com>
13842
13843         * common/next-iterator.h: New file.
13844         * objfiles.h (class all_objfiles): New.
13845         (struct objfile_iterator): New.
13846
13847 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13848
13849         * NEWS: Move the description of the changed "frame", "select-frame",
13850          and "info frame" commands to the Changed commands section.
13851
13852 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13853
13854         * gdbtypes.c (check_stub_method_group): Remove handling of old
13855         mangling schemes.
13856         * linespec.c (find_methods): Likewise.
13857         * stabsread.c (read_member_functions): Likewise.
13858         * valops.c (search_struct_method): Likewise.
13859         (value_struct_elt_for_reference): Likewise.
13860         * NEWS: Mention this change.
13861
13862 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13863
13864         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13865         print_source_lines.
13866         * source.c (print_source_lines_base): Update line number check.
13867         (print_source_lines): New function.
13868         (source_lines_range::source_lines_range): New function.
13869         * source.h (class source_lines_range): New class.
13870         (print_source_lines): New declaration.
13871
13872 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13873
13874         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13875
13876 2019-01-08  Tom Tromey  <tom@tromey.com>
13877             Simon Marchi  <simon.marchi@ericsson.com>
13878
13879         PR gdb/24060
13880         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13881         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13882         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13883         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13884         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13885         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13886
13887 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13888
13889         * source.c (select_source_symtab): Move header comment to
13890         declaration in source.h.
13891         (forget_cached_source_info_for_objfile): Likewise.
13892         (forget_cached_source_info): Likewise.
13893         (identify_source_line): Likewise.
13894         * source.h (identify_source_line): Move declaration from symtab.h
13895         and add comment from source.c
13896         (print_source_lines): Likewise.
13897         (forget_cached_source_info_for_objfile): Likewise.
13898         (forget_cached_source_info): Likewise.
13899         (select_source_symtab): Likewise.
13900         (enum print_source_lines_flag): Move definition from symtab.h.
13901         * symtab.h (identify_source_line): Move declaration to source.h.
13902         (print_source_lines): Likewise.
13903         (forget_cached_source_info_for_objfile): Likewise.
13904         (forget_cached_source_info): Likewise.
13905         (select_source_symtab): Likewise.
13906         (enum print_source_lines_flag): Move definition to source.h.
13907         * tui/tui-hooks.c: Add 'source.h' include.
13908
13909 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13910
13911         * source.c (print_source_lines_base): Handle requests to print
13912         reverse line number sequences, and guard against empty lines
13913         string.
13914
13915 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13916
13917         * source.c (print_source_lines_base): Fix skip of '\r' if next
13918         character is '\n'.
13919
13920 2019-01-06  Tom Tromey  <tom@tromey.com>
13921
13922         * c-exp.y (struct c_parse_state) <macro_original_text,
13923         expansion_obstack>: New member.
13924         (macro_original_text, expansion_obstack): Remove globals.
13925         (scan_macro_expansion, scanning_macro_expansion)
13926         (finished_macro_expansion): Update.
13927         (scan_macro_cleanup): Remove.
13928         (yylex, c_parse): Update.
13929
13930 2019-01-06  Tom Tromey  <tom@tromey.com>
13931
13932         * c-exp.y (struct c_parse_state) <strings>: New member.
13933         (operator_stoken): Update.
13934
13935 2019-01-06  Tom Tromey  <tom@tromey.com>
13936
13937         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13938         (union type_stack_elt) <typelist_val>: Now a pointer to
13939         std::vector.
13940         (type_stack_cleanup): Don't declare.
13941         (push_typelist): Update.
13942         * parse.c (pop_typelist): Return a std::vector.
13943         (push_typelist): Take a std::vector.
13944         (follow_types): Update.  Do not free args.
13945         (type_stack_cleanup): Remove.
13946         * c-exp.y (struct c_parse_state): New.
13947         (cpstate): New global.
13948         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13949         (nonempty_typelist): Update.
13950         (func_mod): Create a new vector.
13951         (c_parse): Create a c_parse_state.
13952         (check_parameter_typelist): Do not delete params.
13953         (function_method): Update.  Do not delete type_list.
13954
13955 2019-01-06  Tom Tromey  <tom@tromey.com>
13956
13957         PR gdb/28155:
13958         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13959         check_typedef.
13960         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13961         (print_return_value): Likewise.
13962
13963 2019-01-05  Tom Tromey  <tom@tromey.com>
13964
13965         * contrib/cleanup_check.py: Remove.
13966         * contrib/gcc-with-excheck: Remove.
13967         * contrib/exsummary.py: Remove.
13968         * contrib/excheck.py: Remove.
13969
13970 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13971
13972         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13973         NULL. Initialize tpprev to NULL instead of assigning it
13974         to NULL on the next statement.
13975         * windows-nat.c (windows_delete_thread): Remove check for
13976         main_thread_id before printing thread exit notifications.
13977         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13978         Remove thread ID check against main_thread_id.
13979         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13980         windows_delete_thread.
13981         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13982
13983 2019-01-04  Tom Tromey  <tom@tromey.com>
13984
13985         * compile/compile.c (_initialize_compile): Use upper case for
13986         metasyntactic variables.
13987         * symmisc.c (_initialize_symmisc): Use upper case for
13988         metasyntactic variables.
13989         * psymtab.c (_initialize_psymtab): Use upper case for
13990         metasyntactic variables.
13991         * demangle.c (demangle_command): Use upper case for metasyntactic
13992         variables.
13993         (_initialize_demangler): Likewise.
13994         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13995         variables.
13996
13997 2019-01-03  Tom Tromey  <tom@tromey.com>
13998
13999         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14000
14001 2019-01-03  Tom Tromey  <tom@tromey.com>
14002
14003         * python/py-symtab.c (salpy_str): Update.
14004         (struct salpy_sal_object) <symtab>: Now a PyObject.
14005         (salpy_dealloc): Update.
14006         (del_objfile_sal): Use gdbpy_ref.
14007
14008 2019-01-03  Tom Tromey  <tom@tromey.com>
14009
14010         * python/py-type.c (convert_field): Use new_reference.  Return
14011         gdbpy_ref.
14012         (make_fielditem): Return gdbpy_ref.
14013         (typy_fields): Update.
14014         (typy_getitem): Update.
14015         (field_name): Return gdbpy_ref.  Use new_reference.
14016         (typy_iterator_iternext): Update.
14017
14018 2019-01-03  Tom Tromey  <tom@tromey.com>
14019
14020         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14021
14022 2019-01-03  Tom Tromey  <tom@tromey.com>
14023
14024         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14025         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14026         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14027         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14028         (pspy_set_type_printers): Likewise.
14029         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14030         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14031         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14032         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14033         (objfpy_set_type_printers): Likewise.
14034
14035 2019-01-03  Tom Tromey  <tom@tromey.com>
14036
14037         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14038         (gdbpy_print_stack): Use gdbpy_err_fetch.
14039         * python/python-internal.h (class gdbpy_err_fetch): New class.
14040         (class gdbpy_enter) <m_error_type, m_error_value,
14041         m_error_traceback>: Remove.
14042         <m_error>: New member.
14043         (gdbpy_exception_to_string): Don't declare.
14044         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14045         * python/py-value.c (convert_value_from_python): Use
14046         gdbpy_err_fetch.
14047         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14048         gdbpy_exception_to_string.
14049         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14050         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14051         gdbpy_err_fetch.
14052
14053 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14054
14055         * linux-nat.c (delete_lwp_cleanup): Delete.
14056         (struct lwp_deleter): New struct.
14057         (lwp_info_up): New typedef.
14058         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14059         lwp_info_up.
14060
14061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14062
14063         * linux-fork.c (class scoped_switch_fork_info): New class.
14064         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14065
14066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14067
14068         * valops.c (find_overload_match): Remove use of null_cleanup, and
14069         calls to do_cleanups.
14070
14071 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14072
14073         * compile/compile-cplus-types.c
14074         (compile_cplus_instance::decl_name): Handle changes to
14075         cp_func_name.
14076         * cp-support.c (cp_func_name): Update header comment, update
14077         return type.
14078         * cp-support.h (cp_func_name): Update return type in declaration.
14079         * valops.c (find_overload_match): Move temp_func local to top
14080         level of function and change its type.  Use temp_func to hold and
14081         delete temporary string obtained from cp_func_name.
14082
14083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14084
14085         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14086         gdb::char_vector, remove cleanup, and update uses of `msg`.
14087
14088 2019-01-03  Jim Wilson  <jimw@sifive.com>
14089
14090         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14091
14092 2019-01-02  Tom Tromey  <tom@tromey.com>
14093
14094         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14095         (tdesc_parse_xml): Remove cleanups.
14096         * target-descriptions.h (make_cleanup_free_target_description):
14097         Don't declare.
14098         (target_desc_deleter): New struct.
14099         (target_desc_up): New typedef.
14100         * target-descriptions.c (target_desc_deleter::operator()): Rename
14101         from free_target_description.
14102         (make_cleanup_free_target_description): Remove.
14103
14104 2019-01-02  Tom Tromey  <tom@tromey.com>
14105
14106         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14107         constructor, destructor.
14108         (linespec_parser): Remove typedef.
14109         (~linespec_parser): Rename from linespec_parser_delete.
14110         (linespec_lex_to_end, linespec_complete_label)
14111         (linespec_complete): Update.
14112         (decode_line_full): Remove cleanups.
14113         (decode_line_1): Update.
14114
14115 2019-01-02  Tom Tromey  <tom@tromey.com>
14116
14117         * python/python-internal.h (inferior_to_inferior_object): Change
14118         return type.
14119         * python/py-exitedevent.c (create_exited_event_object): Update.
14120         * python/py-inferior.c (inferior_to_inferior_object): Return
14121         gdbpy_ref.
14122         (python_new_inferior, python_inferior_deleted)
14123         (thread_to_thread_object, delete_thread_object)
14124         (build_inferior_list, gdbpy_selected_inferior): Update.
14125         * python/py-infthread.c (create_thread_object): Update.  Also fail
14126         if inferior_to_inferior_object fails.
14127
14128 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14129
14130         * inferior.h (class inferior) <displaced_step_state>: New field.
14131         * infrun.h (struct displaced_step_state): Move here from
14132         infrun.c.  Initialize fields, add constructor.
14133         <inf>: Remove field.
14134         <reset>: New method.
14135         * infrun.c (struct displaced_step_inferior_state): Move to
14136         infrun.h.
14137         (displaced_step_inferior_states): Remove.
14138         (get_displaced_stepping_state): Adust.
14139         (displaced_step_in_progress_any_inferior): Adjust.
14140         (displaced_step_in_progress_thread): Adjust.
14141         (displaced_step_in_progress): Adjust.
14142         (add_displaced_stepping_state): Remove.
14143         (get_displaced_step_closure_by_addr): Adjust.
14144         (remove_displaced_stepping_state): Remove.
14145         (infrun_inferior_exit): Call displaced_step_state.reset.
14146         (use_displaced_stepping): Don't check for NULL.
14147         (displaced_step_prepare_throw): Call
14148         get_displaced_stepping_state.
14149         (displaced_step_fixup): Don't check for NULL.
14150         (prepare_for_detach): Don't check for NULL.
14151
14152 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14153
14154         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14155          in case of call that did not complete.
14156
14157 2019-01-02  Andrey Utkin  <autkin@undo.io>
14158
14159         * symfile.c (find_separate_debug_file): Fix search of debug files for
14160         remote debuggee.
14161
14162 2019-01-02  Tom Tromey  <tom@tromey.com>
14163
14164         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14165         indentation.
14166         * python/py-frame.c (frapy_older): Remove cast.
14167         (frapy_newer): Likewise.
14168         * python/py-breakpoint.c (local_setattro): Remove cast.
14169         * python/py-arch.c (archpy_name): Remove local variable.
14170         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14171
14172 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14173
14174         * unittests/basic_string_view/element_access/char/empty.cc:
14175         Fix year range in copyright header.
14176
14177 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14178
14179         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14180         Delete.
14181         <operator==>: Update with for removed field.
14182         <hash>: Likewise.
14183         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14184         <isa_features>: ...this.
14185         <abi_features>: New field.
14186         (riscv_isa_flen): Update comment.
14187         (riscv_abi_xlen): New declaration.
14188         (riscv_abi_flen): New declaration.
14189         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14190         isa_features.
14191         (riscv_abi_xlen): New function.
14192         (riscv_isa_flen): Update to get answer from isa_features.
14193         (riscv_abi_flen): New function.
14194         (riscv_has_fp_abi): Update to get answer from abi_features.
14195         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14196         xlen and flen.
14197         (riscv_call_info) <xlen, flen>: Update comment.
14198         (riscv_call_arg_struct): Remove invalid assertions
14199         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14200         is removed.
14201         (riscv_gdbarch_init): Gather isa features and abi features
14202         separately, ensure both match on the gdbarch when reusing an old
14203         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14204         a target with 64-bit float hardware.
14205
14206 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14207
14208         * source.c (search_command_helper): Stop reverse search
14209         when line 1 has been searched.
14210
14211 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14212
14213         * record-full.c (record_full_base_target::close): Rewrite
14214         record_full_core_buf_list free logic.
14215
14216 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14217
14218         * break-catch-syscall.c (print_one_catch_syscall): xfree
14219         the last text.
14220
14221 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14222
14223         * top.c (print_gdb_version): Update Copyright year in version
14224         message.
14225
14226 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14227
14228         Update copyright year range in all GDB files.
14229
14230 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14231
14232         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14233
14234 For older changes see ChangeLog-2018.
14235 \f
14236 Local Variables:
14237 mode: change-log
14238 left-margin: 8
14239 fill-column: 74
14240 version-control: never
14241 coding: utf-8
14242 End:
14243