gdb/ChangeLog

   1 2019-10-17  Tom de Vries  <tdevries@suse.de>
   2
   3         * arm-nbsd-nat.c: Fix typos in comments.
   4         * arm-tdep.c: Same.
   5         * darwin-nat-info.c: Same.
   6         * dwarf2read.c: Same.
   7         * elfread.c: Same.
   8         * event-top.c: Same.
   9         * findvar.c: Same.
  10         * gdbtypes.c: Same.
  11         * hppa-tdep.c: Same.
  12         * i386-tdep.c: Same.
  13         * jit.c: Same.
  14         * main.c: Same.
  15         * mdebugread.c: Same.
  16         * moxie-tdep.c: Same.
  17         * nto-procfs.c: Same.
  18         * osabi.c: Same.
  19         * ppc-linux-tdep.c: Same.
  20         * remote.c: Same.
  21         * riscv-tdep.c: Same.
  22         * s390-tdep.c: Same.
  23         * sh-tdep.c: Same.
  24         * sparc-linux-tdep.c: Same.
  25         * sparc-nat.c: Same.
  26         * stack.c: Same.
  27         * target-descriptions.c: Same.
  28         * top.c: Same.
  29         * varobj.c: Same.
  30
  31 2019-10-16  Tom Tromey  <tom@tromey.com>
  32
  33         * objfiles.h (struct objfile) <original_name>: Now const.
  34
  35 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
  36
  37         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
  38         pass on to sigsetjmp's second argument.
  39         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
  40
  41 2019-10-16  Keith Seitz  <keiths@redhat.com>
  42
  43         PR gdb/23567
  44         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
  45         sections whose size is greater than the file size.
  46
  47 2019-10-16  Jim Wilson  <jimw@sifive.com>
  48
  49         * riscv-tdep.c (riscv_gcc_target_options): New.
  50         (riscv_gnu_triplet_regexp): New.
  51         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
  52         set_gdbarch_gnu_triplet_regexp.
  53
  54 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
  55
  56         * Makefile.in: Add xml-builtin.h.
  57         * features/feature_to_c.sh: Add an include for xml-builtin.h
  58         to ensure that the compiler checks that the types match.
  59         * xml-builtin.h: New file.
  60         * xml-support.c (fetch_xml_builtin): Add missing const.
  61         * xml-support.h: Remove declaration of xml_builtins.
  62
  63 2019-10-16  Tom de Vries  <tdevries@suse.de>
  64
  65         PR tdep/25096
  66         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
  67         (amd64_classify_aggregate): ... here.
  68         (amd64_classify_aggregate_field): Handled fiels of nested structs
  69         recursively.
  70
  71 2019-10-16  Tom de Vries  <tdevries@suse.de>
  72
  73         PR tdep/24104
  74         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
  75         that handles 'theclass'.
  76
  77 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  78
  79         * linespec.c (decode_digits_ordinary): Update comment.
  80         * make-target-delegates: No longer need to handle VEC case.
  81         * memrange.c (normalize_mem_ranges): Update comment.
  82         * namespace.c (add_using_directive): Update comment.
  83         * objc-lang.c (uniquify_strings): Update comment.
  84         * ppc-linux-nat.c (struct thread_points): Update comment.
  85         * probe.h (find_probes_in_objfile): Update comment.
  86         * target.h (enum flash_preserve_mode): Update comment.
  87         * varobj.c (varobj_restrict_range): Update comment.
  88         * varobj.h (varobj_list_children): Update comment.
  89
  90 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         * Makefile.in: Remove references to vec.h and vec.c.
  93         * aarch64-tdep.c: No longer include vec.h.
  94         * ada-lang.c: Likewise.
  95         * ada-lang.h: Likewise.
  96         * arm-tdep.c: Likewise.
  97         * ax.h: Likewise.
  98         * breakpoint.h: Likewise.
  99         * charset.c: Likewise.
 100         * cp-support.h: Likewise.
 101         * dtrace-probe.c: Likewise.
 102         * dwarf2read.c: Likewise.
 103         * extension.h: Likewise.
 104         * gdb_bfd.c: Likewise.
 105         * gdbsupport/gdb_vecs.h: Likewise.
 106         * gdbsupport/vec.c: Remove.
 107         * gdbsupport/vec.h: Remove.
 108         * gdbthread.h: Likewise.
 109         * guile/scm-type.c: Likewise.
 110         * inline-frame.c: Likewise.
 111         * machoread.c: Likewise.
 112         * memattr.c: Likewise.
 113         * memrange.h: Likewise.
 114         * namespace.h: Likewise.
 115         * nat/linux-btrace.h: Likewise.
 116         * osdata.c: Likewise.
 117         * parser-defs.h: Likewise.
 118         * progspace.h: Likewise.
 119         * python/py-type.c: Likewise.
 120         * record-btrace.c: Likewise.
 121         * rust-exp.y: Likewise.
 122         * solib-target.c: Likewise.
 123         * stap-probe.c: Likewise.
 124         * target-descriptions.c: Likewise.
 125         * target-memory.c: Likewise.
 126         * target.h: Likewise.
 127         * varobj.c: Likewise.
 128         * varobj.h: Likewise.
 129         * xml-support.h: Likewise.
 130
 131 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 132
 133         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 134         Update for new std::vector based implementation.
 135         (process_psymtab_comp_unit_reader): Likewise.
 136         (scan_partial_symbols): Likewise.
 137         (recursively_compute_inclusions): Likewise.
 138         (compute_compunit_symtab_includes): Likewise.
 139         (process_imported_unit_die): Likewise.
 140         (queue_and_load_dwo_tu): Likewise.
 141         (follow_die_sig_1): Likewise.
 142         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 143         (typedef dwarf2_per_cu_ptr): Remove.
 144         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 145         function.
 146         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 147         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 148         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 149         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 150         std::vector.
 151
 152 2019-10-15  Tom Tromey  <tromey@adacore.com>
 153
 154         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 155         TID.
 156
 157 2019-10-15  Tom Tromey  <tromey@adacore.com>
 158
 159         * windows-nat.c (windows_nat_target::fetch_registers)
 160         (windows_nat_target::store_registers): Rename "pid" to "tid".
 161
 162 2019-10-15  Tom Tromey  <tromey@adacore.com>
 163
 164         * gdbarch.h, gdbarch.c: Rebuild.
 165         * gdbarch.sh (gcc_target_options): Change return type to
 166         std::string.
 167         * compile/compile.c (get_args): Update.
 168         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 169         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 170         std::string.
 171         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 172         std::string.
 173         * arch-utils.c (default_gcc_target_options): Return std::string.
 174         * arch-utils.h (default_gcc_target_options): Return std::string.
 175         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 176
 177 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 178
 179         * breakpoint.c (breakpoint_chain): Make static.
 180         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 181         of accessing breakpoint_chain.
 182
 183 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 184
 185         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 186         to a gdb::function_view and return value to bool.
 187         * breakpoint.h (iterate_over_breakpoints): Likewise.
 188         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 189         (pop_dummy_frame): Update.
 190         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 191         (gdbscm_breakpoints): Update.
 192         * python/py-breakpoint.c (build_bp_list): Update.
 193         (gdbpy_breakpoints): Update.
 194         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 195         Update.
 196         (bpfinishpy_handle_stop): Update.
 197         (bpfinishpy_handle_exit): Update.
 198         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 199         (svr4_update_solib_event_breakpoints): Update.
 200
 201 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 202
 203         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 204         when unwrapping single-field structs.
 205
 206 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 207
 208         * dwarf2read.c: Remove includes.
 209
 210 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 211
 212         * ui-out.c (ui_out::call_do_message): Silence
 213         -Wformat-nonliteral warning.
 214
 215 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 216
 217         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 218         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 219         include: readline/tilde.h.
 220
 221 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 222
 223         * remote.c (remote_target::get_trace_status): Remove declaration of
 224         trace_regblock_size.
 225
 226 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 227
 228         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 229         (show_user): Remove declaration of cmdlist.
 230         * cli/cli-cmds.h (max_user_call_depth): Declare.
 231         * cli/cli-script.c (execute_user_command): Remove declaration
 232         of max_user_call_depth.
 233
 234 2019-10-11  Jim Wilson  <jimw@sifive.com>
 235
 236         * gdbsupport/print-utils.h (pulongest): Fix comment.
 237         (plongest): Likewise.
 238         (phex): Add missing comment, mention leading zeros.
 239         (phex_nz): Add mention of no leading zeros to comment.
 240
 241         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 242         plongest instead of unsigned long long cast.
 243
 244 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 245
 246         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 247         for external_editor_command and gdbtk_test.
 248
 249 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 252         * varobj.c (varobjdebug): Move comment to...
 253         * varobj.h (varobjdebug): ...here, and declare.
 254
 255 2019-10-09  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 258         erase_data_content.
 259
 260 2019-10-09  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 263         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 264         * tui/tui-command.c (tui_cmd_window::resize)
 265         (tui_refresh_cmd_win): Update.
 266         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 267         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 268         * tui/tui-data.c (~tui_gen_win_info): Remove.
 269         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 270         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 271         (tui_redisplay_readline, tui_mld_flush)
 272         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 273         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 274         (tui_data_window::erase_data_content)
 275         (tui_data_item_window::rerender)
 276         (tui_data_item_window::refresh_window): Update.
 277         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 278         (box_win, tui_gen_win_info::make_window)
 279         (tui_gen_win_info::make_visible): Update.
 280         (tui_delete_win): Remove.
 281         * tui/tui-winsource.c
 282         (tui_source_window_base::do_erase_source_content): Update.
 283         (tui_show_source_line, tui_source_window_base::update_tab_width)
 284         (tui_source_window_base::update_exec_info): Update.
 285         * tui/tui-data.h (struct curses_deleter): New.
 286         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 287         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 288
 289 2019-10-09  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 292
 293 2019-10-09  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 296         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 297
 298 2019-10-09  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 301         window height directly.
 302         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 303         declare.
 304         * tui/tui-layout.c (tui_default_win_height): Remove.
 305         (tui_default_win_viewport_height): Remove.
 306
 307 2019-10-09  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui.h: Remove comments.
 310
 311 2019-10-09  Tom de Vries  <tdevries@suse.de>
 312
 313         * python/lib/gdb/printer/bound_registers.py: Use
 314         '^builtin_type_bound128' as regexp argument for
 315         add_builtin_pretty_printer.
 316
 317 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 318
 319         * guile/guile.c (guile_extension_script_ops): Remove forward
 320         declaration and mark as static.
 321         (guile_script_ops): Likewise.
 322         (extension_language_guile): Move further down in the file so
 323         it can reference the definitions for guile_{extension_,}script_ops.
 324
 325 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 326
 327         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 328         except SORTL, DFLTCC, and KDSA.
 329
 330 2019-10-08  Tom Tromey  <tromey@adacore.com>
 331
 332         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 333         (struct safe_symbol_file_add_args): Remove.
 334
 335 2019-10-08  Tom Tromey  <tromey@adacore.com>
 336
 337         * windows-nat.c: Don't include buildsym-legacy.h.
 338
 339 2019-10-08  Tom Tromey  <tromey@adacore.com>
 340
 341         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 342
 343 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 344
 345         * gdbtypes.c (overload_debug): Move comment to header.
 346         * gdbtypes.h (overload_debug): Declare.
 347         * valops.c: Remove declaration of overload_debug, instead
 348         include gdbtypes.h.
 349
 350 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 351
 352         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 353         through _().
 354         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 355         move comment...
 356         * language.h (lang_frame_mismatch_warn): ... here. Also add
 357         declaration.
 358         * top.c (lang_frame_mismatch_warn): Remove declaration.
 359         (check_frame_language_change): Pass lang_frame_mismatch_warn
 360         through _().
 361
 362 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 363
 364         * c-lang.h (vtbl_ptr_name): Declare.
 365         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 366         it from the header.
 367         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 368
 369 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 370
 371         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 372         gdb_static_assert.
 373
 374 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 375
 376         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 377         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 378         * ctfread.c: New file.
 379         * ctfread.h: New file.
 380         * elfread.c: Include ctfread.h.
 381         (struct elfinfo text_p): New member ctfsect.
 382         (elf_locate_sections): Mark CTF section.
 383         (elf_symfile_read): Call elfctf_build_psymtabs.
 384         * Makefile.in (LIBCTF): Add.
 385         (CLIBS): Use it.
 386         (CDEPS): Likewise.
 387         (DIST): Add ctfread.c.
 388
 389 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 390
 391         * ctfread.c (struct nextfield): Renamed to ...
 392         (struct ctf_nextfield): ... this.
 393         (struct field_info): Renamed to ...
 394         (strut ctf_field_info): ... this.
 395         (attach_fields_to_type): Update for renamed structures.
 396         (ctf_add_member_cb): Likewise.
 397         (ctf_add_enum_member_cb): Likewise.
 398         (process_struct_members): Likewise.
 399         (process_enum_type): Likewise.
 400
 401 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 402
 403         * tracectf.h: Rename, was ctf.h.
 404         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 405         * tracefile.c: Likewise.
 406         * tracepoint.c: Remove unused include ctf.h.
 407         * mi/mi-main.c: Likewise.
 408         * Makefile.in Replace ctf.c with tracectf.c.
 409
 410 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 411
 412         * version.in: Change version number to "9.0.50.DATE-git".
 413
 414 2019-10-03  Tom Tromey  <tom@tromey.com>
 415
 416         PR rust/24976:
 417         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 418
 419 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 422         cp_search_name_hash.
 423         * NEWS: Add entry about nested function support.
 424
 425 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 426             Andrew Burgess  <andrew.burgess@embecosm.com>
 427
 428         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 429         for nested static variables when searchin VAR_DOMAIN.
 430         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 431         global scope, update comment.
 432         (add_partial_subprogram): Call add_partial_subprogram recursively
 433         for nested subroutines when processinng Fortran.
 434         (load_partial_dies): Process the child entities of a subprogram
 435         when processing Fortran.
 436         (partial_die_parent_scope): Handle building scope
 437         for Fortran nested functions.
 438         (process_die): Record that nested functions have a scope.
 439         (new_symbol): Always record Fortran subprograms on the global
 440         symbol list.
 441         (determine_prefix): How to build the prefix for Fortran
 442         subprograms.
 443
 444 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 447         have just sent the thread a SIGSTOP and are waiting for it to
 448         arrive.
 449
 450 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 451
 452         * btrace.c (btrace_add_pc): Remove whitespace before the template
 453         parameter in 'std::vector <...>'.
 454         (parse_xml_btrace_block): Likewise.
 455         (btrace_maint_decode_pt): Likewise.
 456         (btrace_maint_update_packets): Likewise.
 457         (btrace_maint_print_packets): Likewise.
 458         * btrace.h (struct btrace_maint_info): Likewise.
 459         * dwarf2read.c (struct type_unit_group): Likewise.
 460         (build_type_psymtabs_reader): Likewise.
 461         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 462         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 463         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 464
 465 2019-10-03  Tom de Vries  <tdevries@suse.de>
 466
 467         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 468         the first line of the help text for set/show style metadata.
 469
 470 2019-10-02  Tom Tromey  <tromey@adacore.com>
 471
 472         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 473         * gdbsupport/common-inferior.c: New file.
 474         * infcmd.c (startup_with_shell): Don't define.
 475         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 476         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 477         * inferior.h (startup_with_shell): Don't declare.
 478
 479 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * gdbsupport/gdb_assert.h: Include errors.h.
 482         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 483
 484 2019-10-02  Tom Tromey  <tromey@adacore.com>
 485
 486         * NEWS: Add $_ada_exception entry.
 487         * ada-lang.c (struct ada_catchpoint): Add constructor.
 488         <m_kind>: New member.
 489         (allocate_location_exception, re_set_exception): Remove
 490         "ex" parameter.
 491         (should_stop_exception): Compute $_ada_exception.
 492         (check_status_exception, print_it_exception)
 493         (print_one_exception, print_mention_exception): Remove
 494         "ex" parameter.
 495         (allocate_location_catch_exception, re_set_catch_exception)
 496         (check_status_exception, print_it_catch_exception)
 497         (print_one_catch_exception, print_mention_catch_exception)
 498         (print_recreate_catch_exception)
 499         (allocate_location_catch_exception_unhandled)
 500         (re_set_catch_exception_unhandled)
 501         (check_status_exception, print_it_catch_exception_unhandled)
 502         (print_one_catch_exception_unhandled)
 503         (print_mention_catch_exception_unhandled)
 504         (print_recreate_catch_exception_unhandled)
 505         (allocate_location_catch_assert, re_set_catch_assert)
 506         (check_status_assert, print_it_catch_assert)
 507         (print_one_catch_assert, print_mention_catch_assert)
 508         (print_recreate_catch_assert)
 509         (allocate_location_catch_handlers, re_set_catch_handlers)
 510         (check_status_handlers, print_it_catch_handlers)
 511         (print_one_catch_handlers, print_mention_catch_handlers)
 512         (print_recreate_catch_handlers): Remove.
 513         (create_ada_exception_catchpoint): Update.
 514         (initialize_ada_catchpoint_ops): Update.
 515
 516 2019-10-02  Tom Tromey  <tromey@adacore.com>
 517
 518         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 519         (create_excep_cond_exprs): Simplify exception string computation.
 520         (ada_exception_catchpoint_cond_string): Likewise.
 521
 522 2019-10-02  Tom Tromey  <tromey@adacore.com>
 523
 524         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 525         * ada-lang.c (lesseq_defined_than): Handle
 526         LOC_STATIC.
 527         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 528         parameter.
 529         (dwarf2_has_info): Likewise.
 530         (new_symbol): Set maybe_copied on symbol when
 531         appropriate.
 532         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 533         parameter.
 534         <can_copy>: New member.
 535         * elfread.c (record_minimal_symbol): Set maybe_copied
 536         on symbol when appropriate.
 537         (elf_symfile_read): Update call to dwarf2_has_info.
 538         * minsyms.c (lookup_minimal_symbol_linkage): New
 539         function.
 540         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 541         * symtab.c (get_symbol_address, get_msymbol_address):
 542         New functions.
 543         * symtab.h (get_symbol_address, get_msymbol_address):
 544         Declare.
 545         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 546         maybe_copied.
 547         (struct symbol, struct minimal_symbol) <maybe_copied>:
 548         New member.
 549
 550 2019-10-02  Tom Tromey  <tromey@adacore.com>
 551
 552         * source.c (struct current_source_location): New.
 553         (current_source_key): New global.
 554         (current_source_symtab, current_source_line)
 555         (current_source_pspace): Remove.
 556         (get_source_location): New function.
 557         (get_current_source_symtab_and_line)
 558         (set_default_source_symtab_and_line)
 559         (set_current_source_symtab_and_line)
 560         (clear_current_source_symtab_and_line, select_source_symtab)
 561         (info_source_command, print_source_lines_base)
 562         (info_line_command, search_command_helper, _initialize_source):
 563         Update.
 564
 565 2019-10-02  Tom Tromey  <tromey@adacore.com>
 566
 567         * source.c (select_source_symtab): Don't call
 568         decode_line_with_current_source.
 569
 570 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 571
 572         * symtab.c (lookup_global_symbol): Search global block.
 573
 574 2019-10-02  Tom Tromey  <tromey@adacore.com>
 575
 576         * coffread.c (process_coff_symbol): Update.
 577         * dwarf2read.c (var_decode_location, new_symbol): Update.
 578         * mdebugread.c (parse_symbol): Update.
 579         * objfiles.c (relocate_one_symbol): Update.
 580         * stabsread.c (define_symbol, fix_common_block)
 581         (scan_file_globals): Update.
 582         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 583         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 584         * xcoffread.c (process_xcoff_symbol): Update.
 585
 586 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 587
 588         * MAINTAINERS: Update my email address.
 589
 590 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 591
 592         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 593         std::vector.
 594         (build_type_psymtabs_reader): Update for std::vector.
 595         (build_type_psymtab_dependencies): Likewise.
 596         * dwarf2read.h: Remove use of DEF_VEC_P.
 597         (typedef sig_type_ptr): Delete.
 598
 599 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 602         to std::vector.
 603         (btrace_maint_decode_pt): Likewise, and move allocation of the
 604         vector outside of the loop.
 605         (btrace_maint_update_packets): Update to handle change from VEC to
 606         std::vector.
 607         (btrace_maint_print_packets): Likewise.
 608         (maint_info_btrace_cmd): Likewise.
 609         * btrace.h: Remove use of DEF_VEC_O.
 610         (typedef btrace_pt_packet_s): Delete.
 611         (struct btrace_maint_info) <packets>: Change fromm VEC to
 612         std::vector.
 613         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 614
 615 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 616
 617         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 618         make accesses into the vector constant references.
 619         (btrace_add_pc): Update for std::vector.
 620         (btrace_stitch_bts): Likewise.
 621         (parse_xml_btrace_block): Likewise.
 622         (btrace_maint_update_packets): Likewise.
 623         (btrace_maint_print_packets): Likewise.
 624         (maint_info_btrace_cmd): Likewise.
 625         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 626         std::vector.
 627         (btrace_data::empty): Likewise.
 628         (btrace_data_append): Likewise.
 629         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 630         (typedef btrace_block_s): Delete.
 631         (struct btrace_block): Add constructor.
 632         (struct btrace_data_bts) <blocks>: Change to std::vector.
 633         * nat/linux-btrace.c (perf_event_read_bts): Update for
 634         std::vector.
 635         (linux_read_bts): Likewise.
 636
 637 2019-10-01  Tom Tromey  <tom@tromey.com>
 638
 639         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 640
 641 2019-10-01  Tom Tromey  <tom@tromey.com>
 642
 643         * stack.c (print_frame, info_frame_command_core): Use
 644         styled_string.
 645         * linux-thread-db.c (try_thread_db_load_1)
 646         (try_thread_db_load_from_pdir_1): Use styled_string.
 647         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 648         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 649         (maybe_print_unsupported_script_warning)
 650         (maybe_print_script_not_found_warning): Use styled_string.
 651         * ada-lang.c (user_select_syms): Use styled_string.
 652
 653 2019-10-01  Tom Tromey  <tom@tromey.com>
 654
 655         * p-lang.c (pascal_printstr): Use metadata style.
 656         * value.c (show_convenience): Use metadata style.
 657         * valprint.c (valprint_check_validity, val_print_optimized_out)
 658         (val_print_not_saved, val_print_unavailable)
 659         (val_print_invalid_address, generic_val_print, val_print)
 660         (value_check_printable, val_print_array_elements): Use metadata
 661         style.
 662         * ui-out.h (class ui_out) <field_fmt>: New overload.
 663         <do_field_fmt>: Add style parameter.
 664         * ui-out.c (ui_out::field_fmt): New overload.
 665         * typeprint.c (type_print_unknown_return_type)
 666         (val_print_not_allocated, val_print_not_associated): Use metadata
 667         style.
 668         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 669         parameter.
 670         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 671         * tracepoint.c (tvariables_info_1): Use metadata style.
 672         * stack.c (print_frame_arg, print_frame_info, print_frame)
 673         (info_frame_command_core): Use metadata style.
 674         * skip.c (info_skip_command): Use metadata style.
 675         * rust-lang.c (rust_print_enum): Use metadata style.
 676         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 677         metadata style.
 678         * python/py-framefilter.c (py_print_single_arg): Use metadata
 679         style.
 680         * printcmd.c (do_one_display, print_variable_and_value): Use
 681         metadata style.
 682         * p-valprint.c (pascal_val_print)
 683         (pascal_object_print_value_fields): Use metadata style.
 684         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 685         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 686         parameter.
 687         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 688         * m2-valprint.c (m2_print_long_set): Use metadata style.
 689         * m2-typeprint.c (m2_print_type): Use metadata style.
 690         * infcmd.c (print_return_value_1): Use metadata style.
 691         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 692         * f-valprint.c (info_common_command_for_block): Use metadata
 693         style.
 694         * f-typeprint.c (f_type_print_base): Use metadata style.
 695         * expprint.c (print_subexp_standard): Use metadata style.
 696         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 697         * cli/cli-style.h (class cli_style_option): Add constructor.
 698         (metadata_style): Declare.
 699         * cli/cli-style.c (metadata_style): New global.
 700         (_initialize_cli_style): Register metadata style.
 701         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 702         parameter.
 703         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 704         * c-typeprint.c (c_type_print_base_struct_union)
 705         (c_type_print_base_1): Use metadata style.
 706         * breakpoint.c (watchpoint_value_print)
 707         (print_one_breakpoint_location): Use metadata style.
 708         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 709         style.
 710         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 711         style.
 712         * ada-valprint.c (val_print_packed_array_elements, printstr)
 713         (print_field_values, ada_val_print_ref, ada_val_print): Use
 714         metadata style.
 715         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 716         style.
 717         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 718         style.
 719         * ada-lang.c (user_select_syms): Use metadata style.
 720
 721 2019-10-01  Tom Tromey  <tom@tromey.com>
 722
 723         * cli/cli-cmds.c (pwd_command): Style output.
 724
 725 2019-10-01  Pedro Alves  <palves@redhat.com>
 726             Tom Tromey  <tom@tromey.com>
 727
 728         * symtab.c (print_symbol_info): Use %ps.
 729         (print_msymbol_info): Use %ps.
 730         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 731         * printcmd.c (print_variable_and_value): Use %ps.
 732         * macrocmd.c (show_pp_source_pos): Use %ps.
 733         * infrun.c (print_exited_reason): Use ui_out::message.
 734         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 735         (describe_other_breakpoints): Use ui_out::message and new
 736         formats.
 737         (say_where): Use new formats.
 738         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 739         and new formats.
 740
 741 2019-10-01  Pedro Alves  <palves@redhat.com>
 742             Tom Tromey  <tom@tromey.com>
 743
 744         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 745         (test_gdb_formats): New function.
 746         (run_tests): Call it.
 747         (test_format_specifier): Update.
 748         * utils.h (fputs_filtered): Update comment.
 749         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 750         (fputs_styled_unfiltered): Declare.
 751         * utils.c (fputs_styled_unfiltered): New function.
 752         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 753         (vfprintf_filtered): Update.
 754         (vfprintf_unfiltered, vprintf_filtered): Update.
 755         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 756         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 757         disallow_ui_out_field>: New constants.
 758         (enum class field_kind): New.
 759         (struct base_field_s, struct signed_field_s): New.
 760         (signed_field): New function.
 761         (struct string_field_s): New.
 762         (string_field): New function.
 763         (struct styled_string_s): New.
 764         (styled_string): New function.
 765         (class ui_out) <message>: Add comment.
 766         <vmessage, call_do_message>: New methods.
 767         <do_message>: Add style parameter.
 768         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 769         methods.
 770         (ui_out::message): Rewrite.
 771         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 772         parameter.
 773         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 774         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 775         gdb_extensions parameter.
 776         (class format_piece): Add parameter to constructor.
 777         (n_int_args): New field.
 778         * gdbsupport/format.c (format_pieces::format_pieces): Add
 779         gdb_extensions parameter.  Handle '*'.
 780         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 781         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 782         vfprintf_styled_no_gdbfmt.
 783         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 784         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 785         unfiltered output.
 786         * ui-style.h (struct ui_file_style) <ptr>: New method.
 787
 788 2019-10-01  Tom Tromey  <tom@tromey.com>
 789
 790         * unittests/format_pieces-selftests.c: Update.  Add final format.
 791         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 792         empty literal pieces.
 793
 794 2019-10-01  Tom Tromey  <tom@tromey.com>
 795
 796         * ui-out.h (enum class ui_out_style_kind): Remove.
 797         (class ui_out) <field_string, field_stsream, do_field_string>:
 798         Change type of "style".
 799         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 800         (ui_out::field_string): Update.
 801         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 802         of "style".
 803         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 804         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 805         * stack.c (print_frame_arg, print_frame_info, print_frame):
 806         Update.
 807         * source.c (print_source_lines_base): Update.
 808         * solib.c (info_sharedlibrary_command): Update.
 809         * skip.c (info_skip_command): Update.
 810         * record-btrace.c (btrace_call_history_src_line)
 811         (btrace_call_history): Update.
 812         * python/py-framefilter.c (py_print_frame): Update.
 813         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 814         "style".
 815         * mi/mi-out.c (mi_ui_out::do_table_header)
 816         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 817         (mi_ui_out::do_field_string): Update.
 818         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 819         Update.
 820         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 821         "style".
 822         * cli-out.c (cli_ui_out::do_table_header)
 823         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 824         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 825         (cli_ui_out::do_field_fmt): Update.
 826         * breakpoint.c (print_breakpoint_location): Update.
 827         (update_static_tracepoint): Update.
 828
 829 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 830
 831         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 832         conversion of gdb_datadir.
 833         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 834         remove not needed c_str ().
 835
 836 2019-09-30  Ali Tamur <tamur@google.com>
 837
 838         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 839         (dwarf2_string_attr): Likewise.
 840
 841 2019-09-30  Ali Tamur <tamur@google.com>
 842
 843         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 844         (process_full_type_unit): Likewise.
 845         (dump_die_shallow): Likewise.
 846         (cu_debug_loc_section): Likewise.
 847
 848 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 849
 850         * minsyms.c (compare_minimal_symbols): Rename to...
 851         (minimal_symbol_is_less_than): ...this, and adjust to STL
 852         conventions (return bool, take arguments as references)
 853         (minimal_symbol_reader::install): Call std::sort instead
 854         of qsort.
 855
 856 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 857
 858         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 859         hash and why.
 860         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 861         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 862
 863 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 864
 865         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 866         * psympriv.h (add_psymbol_to_list): Move comment here and update
 867         it.
 868
 869 2019-09-29  Tom de Vries  <tdevries@suse.de>
 870
 871         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 872         Use $tmpdir/$(basename "$output_file").dwz instead of
 873         "${output_file}.dwz".
 874
 875 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 876
 877         PR gdb/25045
 878         * hppa-linux-nat.c: Include gdbarch.h.
 879
 880 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 881
 882         * blockframe.c (find_pc_partial_function): Change return type to bool.
 883         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 884         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 885         (stub_gnu_ifunc_resolve_name): Likewise.
 886         * symtab.c (compare_filenames_for_search): Likewise.
 887         (compare_glob_filenames_for_search): Likewise.
 888         (matching_obj_sections): Likewise.
 889         (symbol_matches_domain): Likewise.
 890         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 891         (find_line_pc): Change return type to bool.
 892         (find_line_pc_range): Likewise.
 893         (producer_is_realview): Likewise.
 894         * symtab.h (symbol_matches_domain): Likewise.
 895         (find_pc_partial_function): Likewise.
 896         (find_pc_line_pc_range): Likewise.
 897         (in_gnu_ifunc_stub): Likewise.
 898         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 899         (find_line_pc): Likewise.
 900         (find_line_pc_range): Likewise.
 901         (matching_obj_sections): Likewise.
 902         (find_line_symtab): Change out parameter to bool.
 903         (producer_is_realview): Change return type to bool.
 904         (compare_filenames_for_search): Likewise.
 905         (compare_glob_filenames_for_search): Likewise.
 906
 907 2019-09-26  Tom Tromey  <tom@tromey.com>
 908
 909         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 910         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 911         * gdb_usleep.h: Remove.
 912         * gdb_usleep.c: Remove.
 913         * utils.c: Don't include gdb_usleep.h.
 914
 915 2019-09-26  Tom Tromey  <tromey@adacore.com>
 916
 917         * python/py-type.c (type_to_type_object): Call check_typedef
 918         for stub types.
 919
 920 2019-09-26  Tom Tromey  <tom@tromey.com>
 921
 922         * utils.h (initialize_utils): Don't declare.
 923         * top.c (gdb_init): Don't call initialize_utils.
 924         * utils.c (initialize_utils): Remove.  Move contents...
 925         (_initialize_utils): ... here.
 926
 927 2019-09-25  Tom Tromey  <tom@tromey.com>
 928
 929         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 930         * utils.h (make_hex_string): Don't declare.
 931         * utils.c (make_hex_string): Remove.
 932
 933 2019-09-24  Tom de Vries  <tdevries@suse.de>
 934
 935         PR gdb/23815
 936         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 937         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 938
 939 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 940
 941         * NEWS: Mention new simulator port for PRU.
 942
 943 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 944
 945         * ada-exp.y (write_object_remaining): Update.
 946         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 947         and eliminate the static buffer.
 948         (ada_decode_symbol): Update.
 949         (ada_la_decode): Update.
 950         (ada_sniff_from_mangled_name): Update.
 951         (is_valid_name_for_wild_match): Update.
 952         (ada_lookup_name_info::matches): Update and simplify.
 953         (name_matches_regex): Update.
 954         (ada_add_global_exceptions): Update.
 955         * ada-lang.h (ada_decode): Update signature.
 956         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 957         * dwarf-index-write.c (debug_names::insert): Update.
 958
 959 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 960
 961         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 962         formatting.
 963
 964 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 965
 966         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 967         Change "nonzero" to "true" in documentation.
 968
 969 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 970
 971         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 972         (_initialize_darwin_solib): Don't set
 973         darwin_so_ops.lookup_lib_global_symbol.
 974         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 975         set_gdbarch_iterate_over_objfiles_in_search_order.
 976         (elf_lookup_lib_symbol): Rename to...
 977         (svr4_iterate_over_objfiles_in_search_order): this, and update
 978         to iterate semantics.
 979         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 980         * solib.c (solib_global_lookup): Remove.
 981         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 982         (solib_global_lookup): Remove.
 983         * symtab.c (lookup_global_or_static_symbol): Remove call to
 984         solib_global_lookup.
 985
 986 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 987
 988         * NEWS: Move entries about default MI version now being
 989         version 3, and about the GDB/MI fix for multi-location
 990         breakpoints to the "since GDB 8.3" section.
 991
 992 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 993
 994         GDB 8.3.1 released.
 995
 996 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 997
 998         * NEWS: Mention that Cell/B.E. debugging support was removed.
 999         * MAINTAINERS: Remove spu target.
1000
1001         * config/djgpp/fnchange.lst: Remove entries for removed files.
1002
1003         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1004         spu-multiarch.o, and spu-tdep.o.
1005         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1006         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1007         spu-multiarch.c, and spu-tdep.c.
1008         * spu-linux-nat.c: Remove file.
1009         * spu-multiarch.c: Remove file.
1010         * spu-tdep.c: Remove file.
1011         * spu-tdep.h: Remove file.
1012         * solib-spu.c: Remove file.
1013         * solib-spu.h: Remove file.
1014
1015         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1016         * configure.nat (spu-linux): Remove.
1017         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1018         solib-multiarch.o from gdb_target_obs.
1019         (spu*-*-*): Remove.
1020
1021         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1022         feature flag.
1023         (ppc_linux_no_features): Update.
1024         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1025         Cell/B.E. support.
1026         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1027         (tdesc_powerpc_cell64l): Likewise.
1028         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1029         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1030         Cell/B.E. support.
1031         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1032         Do not include "features/rs6000/powerpc-cell32l.c" or
1033         "features/rs6000/powerpc-cell64l.c".
1034         (ppc_linux_spu_section): Remove.
1035         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1036         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1037         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1038         (ppc_linux_spe_context_lookup): Remove.
1039         (ppc_linux_spe_context_inferior_created): Remove.
1040         (ppc_linux_spe_context_solib_loaded): Remove.
1041         (ppc_linux_spe_context_solib_unloaded): Remove.
1042         (ppc_linux_spe_context): Remove.
1043         (struct ppu2spu_cache): Remove.
1044         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1045         (struct ppu2spu_data): Remove.
1046         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1047         ppu2spu_unwind): Remove.
1048         (ppc_linux_init_abi): Remove Cell/B.E. support.
1049         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1050
1051         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1052         (rs6000/powerpc-cell64l-expedite): Likewise
1053         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1054         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1055         rs6000/powerpc-cell64l.xml.
1056         * features/rs6000/powerpc-cell32l.xml: Remove.
1057         * features/rs6000/powerpc-cell64l.xml: Likewise.
1058         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1059         * features/rs6000/powerpc-cell64l.c: Likewise.
1060         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1061         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1062         * regformats/reg-spu.dat: Remove.
1063
1064         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1065         * corelow.c (struct spuid_list): Remove.
1066         (add_to_spuid_list): Remove.
1067         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1068         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1069         (remote_protocol_features): Remove associated entries.
1070         (_initialize_remote): No longer initialize them.
1071         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1072         * linux-nat.c (SPUFS_MAGIC): Remove.
1073         (linux_proc_xfer_spu): Remove.
1074         (spu_enumerate_spu_ids): Remove.
1075         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1076         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1077         (linux_make_corefile_notes): No longer call it.
1078
1079         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1080         (cooked_write_test): Likewise.
1081
1082 2019-09-20  Tom Tromey  <tom@tromey.com>
1083
1084         * NEWS: Mention case-sensitivity of TUI commands.
1085         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1086         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1087         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1088
1089 2019-09-20  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-source.c (tui_source_window::set_contents): Use
1092         make_unique_xstrdup.
1093         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1094         make_unique_xstrdup.
1095
1096 2019-09-20  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-data.c: Remove separator comments.
1099         * tui/tui-layout.c: Remove separator comments.
1100         * tui/tui-win.c: Remove separator comments.
1101         * tui/tui-wingeneral.c: Remove separator comments.
1102
1103 2019-09-20  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui.h (strcat_to_buf): Don't declare.
1106         * tui/tui.c (strcat_to_buf): Remove.
1107
1108 2019-09-20  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1111         from "fullname".
1112         * tui/tui-source.c (tui_source_window::set_contents)
1113         (tui_source_window::location_matches_p)
1114         (tui_source_window::maybe_update): Update.
1115
1116 2019-09-20  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1119         Update.
1120         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1121         prefix.
1122         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1123         (tui_data_window::line_from_reg_element_no)
1124         (tui_data_window::first_reg_element_no_inline)
1125         (tui_data_window::show_registers)
1126         (tui_data_window::show_register_group)
1127         (tui_data_window::display_registers_from)
1128         (tui_data_window::display_registers_from_line)
1129         (tui_data_window::first_data_item_displayed)
1130         (tui_data_window::delete_data_content_windows)
1131         (tui_data_window::erase_data_content)
1132         (tui_data_window::do_scroll_vertical)
1133         (tui_data_window::refresh_window)
1134         (tui_data_window::check_register_values): Update.
1135
1136 2019-09-20  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1139         (struct tui_locator_window) <full_name, proc_name>: Now
1140         std::string.
1141         * tui/tui-stack.c (tui_locator_window::make_status_line)
1142         (tui_locator_window::set_locator_fullname)
1143         (tui_locator_window::set_locator_info): Update.
1144         * tui/tui-source.c (tui_source_window::set_contents)
1145         (tui_source_window::showing_source_p): Update.
1146
1147 2019-09-20  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1150         Don't call tui_locator_win_info_ptr.
1151
1152 2019-09-20  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1155
1156 2019-09-20  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1159         height for locator.
1160         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1161         * tui/tui-layout.c (show_source_disasm_command, show_data)
1162         (show_source_or_disasm_and_command): Use 1 as height for locator.
1163
1164 2019-09-20  Tom Tromey  <tom@tromey.com>
1165
1166         * tui/tui.c (tui_enable): Update.
1167         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1168         Update.
1169         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1170         Update.
1171         * tui/tui-data.c (win_resized): Now bool.
1172         (tui_win_resized): Return bool.
1173         (tui_set_win_resized_to): Accept a bool.
1174
1175 2019-09-20  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1178         Change type of "refresh_values_only".
1179         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1180         type of "refresh_values_only".
1181
1182 2019-09-20  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1185         std::string.
1186         (tui_disassemble): Add "pos" parameter.
1187         (tui_disasm_window::set_contents): Simplify.
1188
1189 2019-09-20  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-winsource.h (struct tui_source_window_base)
1192         <show_source_content>: Now private.
1193         * tui/tui-winsource.c
1194         (tui_source_window_base::show_source_content): Don't handle empty
1195         content case.
1196
1197 2019-09-20  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-layout.c (show_source_disasm_command)
1200         (show_source_or_disasm_and_command): Don't call
1201         show_source_content.
1202
1203 2019-09-20  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1206         Declare.
1207         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1208         from tui_make_status_line.
1209         (tui_locator_window::rerender): Update.
1210
1211 2019-09-20  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1214         (tui_locator_window::rerender): Update.
1215
1216 2019-09-20  Tom Tromey  <tom@tromey.com>
1217
1218         * tui/tui-winsource.h (struct tui_source_window_base)
1219         <~tui_source_window_base>: Don't declare.
1220         <fullname>: Remove.
1221         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1222         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1223         member.
1224         * tui/tui-source.c (tui_source_window::set_contents): Update.
1225         (tui_source_window::location_matches_p)
1226         (tui_source_window::maybe_update): Update.
1227
1228 2019-09-20  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-winsource.h (~tui_source_element): Remove.
1231         (tui_source_element): Update.
1232         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1233         * tui/tui-winsource.c (tui_show_source_line): Update.
1234         * tui/tui-source.c (tui_source_window::set_contents): Update.
1235         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1236
1237 2019-09-20  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1240         declare.
1241         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1242         tui_clear_source_windows_detail.
1243         * tui/tui-winsource.h (struct tui_source_window_base)
1244         <clear_detail>: Don't declare.
1245         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1246         Remove.
1247         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1248
1249 2019-09-20  Tom Tromey  <tromey@adacore.com>
1250
1251         PR ada/24919:
1252         * block.c (contained_in): Fix final return value.
1253
1254 2019-09-20  Alan Modra  <amodra@gmail.com>
1255
1256         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1257         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1258         (read_indirect_string_from_dwz): Use bfd accessor.
1259         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1260         * machoread.c (macho_symfile_read_all_oso): Likewise.
1261         * solib.c (solib_bfd_open): Likewise.
1262
1263 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1264
1265         * eval.c: Move declaration of overload_resolution to...
1266         * value.h: ...here.
1267
1268 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1269
1270         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1271         * arm-linux-tdep.c: Likewise.
1272         * arm-nbsd-nat.c: Likewise.
1273         * arm-tdep.h: Declare arm_apcs_32.
1274         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1275
1276 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1277
1278         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1279         * dwarf2read.h: Declare dwarf_always_disassemble.
1280
1281 2019-09-19  Tom de Vries  <tdevries@suse.de>
1282
1283         PR gdb/25009
1284         * source-cache.c (source_cache::ensure): Catch exception thrown during
1285         construction of the highlighter.
1286
1287 2019-09-18  Alan Modra  <amodra@gmail.com>
1288
1289         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1290         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1291         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1292         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1293         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1294         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1295         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1296         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1297         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1298         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1299         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1300         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1301         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1302         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1303         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1304         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1305         * mi/mi-interp.c: Update throughout for bfd section macro and
1306         function changes.
1307         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1308         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1309
1310 2019-09-18  Tom Tromey  <tom@tromey.com>
1311
1312         * NEWS: Add entry.
1313         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1314         call rl_initialize.
1315         (tui_enable): Do not call rl_initialize.
1316
1317 2019-09-18  Christian Groessler  <chris@groessler.org>
1318
1319         * alpha-linux-nat.c: Include gdbarch.h.
1320
1321 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1322
1323         * ui-file.c: Include cli/cli-style.h.
1324         (term_cli_styling): Remove cli_styling declaration.
1325
1326 2019-09-18  Alan Modra  <amodra@gmail.com>
1327
1328         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1329         to bfd_asymbol_section.
1330
1331 2019-09-18  Alan Modra  <amodra@gmail.com>
1332
1333         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1334         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1335         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1336
1337 2019-09-18  Alan Modra  <amodra@gmail.com>
1338
1339         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1340         * spu-linux-nat.c (spu_bfd_open): Likewise.
1341
1342 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1343
1344         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1345         to bool to match definition in dwarf2read.c.
1346
1347 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1348
1349         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1350         (print_signatures): Likewise.
1351         (trust_pad_over_xvs): Likewise.
1352         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1353         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1354         * arm-linux-nat.c (arm_apcs_32): Likewise.
1355         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1356         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1357         * arm-tdep.c (arm_debug): Likewise.
1358         (arm_apcs_32): Likewise.
1359         * auto-load.c (debug_auto_load): Likewise.
1360         (auto_load_gdb_scripts): Likewise.
1361         (global_auto_load): Likewise.
1362         (auto_load_local_gdbinit): Likewise.
1363         (auto_load_local_gdbinit_loaded): Likewise.
1364         * auto-load.h (global_auto_load): Likewise.
1365         (auto_load_local_gdbinit): Likewise.
1366         (auto_load_local_gdbinit_loaded): Likewise.
1367         * breakpoint.c (disconnected_dprintf): Likewise.
1368         (breakpoint_proceeded): Likewise.
1369         (automatic_hardware_breakpoints): Likewise.
1370         (always_inserted_mode): Likewise.
1371         (target_exact_watchpoints): Likewise.
1372         (_initialize_breakpoint): Update.
1373         * breakpoint.h (target_exact_watchpoints): Change to bool.
1374         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1375         * cli/cli-cmds.c (trace_commands): Likewise.
1376         * cli/cli-cmds.h (trace_commands): Likewise.
1377         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1378         to bool*.
1379         * cli/cli-logging.c (logging_overwrite): Change to bool.
1380         (logging_redirect): Likewise.
1381         (debug_redirect): Likewise.
1382         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1383         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1384         to bool.
1385         <boolean_option_def>: Update.
1386         (struct flag_option_def): Change default type of Context to bool
1387         from int.
1388         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1389         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1390         (get_setshow_command_value_string): Likewise.
1391         * cli/cli-style.c (cli_styling): Change to bool.
1392         (source_styling): Likewise.
1393         * cli/cli-style.h (source_styling): Likewise.
1394         (cli_styling): Likewise.
1395         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1396         to bool.
1397         * command.h (var_types): Update comment.
1398         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1399         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1400         bool.
1401         (debug_compile_cplus_scopes): Likewise.
1402         * compile/compile-internal.h (compile_debug): Likewise.
1403         * compile/compile.c (compile_debug): Likewise.
1404         (struct compile_options) <raw>: Likewise.
1405         * cp-support.c (catch_demangler_crashes): Likewise.
1406         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1407         (usr_cmd_cris_dwarf2_cfi): Likewise.
1408         * csky-tdep.c (csky_debug): Likewise.
1409         * darwin-nat.c (enable_mach_exceptions): Likewise.
1410         * dcache.c (dcache_enabled_p): Likewise.
1411         * defs.h (info_verbose): Likewise.
1412         * demangle.c (demangle): Likewise.
1413         (asm_demangle): Likewise.
1414         * dwarf-index-cache.c (debug_index_cache): Likewise.
1415         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1416         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1417         * dwarf2read.c (check_physname): Likewise.
1418         (use_deprecated_index_sections): Likewise.
1419         (dwarf_always_disassemble): Likewise.
1420         * eval.c (overload_resolution): Likewise.
1421         * event-top.c (set_editing_cmd_var): Likewise.
1422         (exec_done_display_p): Likewise.
1423         * event-top.h (set_editing_cmd_var): Likewise.
1424         (exec_done_display_p): Likewise.
1425         * exec.c (write_files): Likewise.
1426         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1427         (debug_fbsd_nat): Likewise.
1428         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1429         Likewise.
1430         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1431         <backtrace_past_entry> Likewise.
1432         * gdb-demangle.h (demangle): Likewise.
1433         (asm_demangle): Likewise.
1434         * gdb_bfd.c (bfd_sharing): Likewise.
1435         * gdbcore.h (write_files): Likewise.
1436         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1437         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1438         * gdbthread.h (print_thread_events): Likewise.
1439         * gdbtypes.c (opaque_type_resolution): Likewise.
1440         (strict_type_checking): Likewise.
1441         * gnu-nat.c (gnu_debug_flag): Likewise.
1442         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1443         * guile/scm-param.c (pascm_variable): Add boolval.
1444         (add_setshow_generic): Update.
1445         (pascm_param_value): Update.
1446         (pascm_set_param_value_x): Update.
1447         * hppa-tdep.c (hppa_debug): Change to bool..
1448         * infcall.c (may_call_functions_p): Likewise.
1449         (coerce_float_to_double_p): Likewise.
1450         (unwind_on_signal_p): Likewise.
1451         (unwind_on_terminating_exception_p): Likewise.
1452         * infcmd.c (startup_with_shell): Likewise.
1453         * inferior.c (print_inferior_events): Likewise.
1454         * inferior.h (startup_with_shell): Likewise.
1455         (print_inferior_events): Likewise.
1456         * infrun.c (step_stop_if_no_debug): Likewise.
1457         (detach_fork): Likewise.
1458         (debug_displaced): Likewise.
1459         (disable_randomization): Likewise.
1460         (non_stop): Likewise.
1461         (non_stop_1): Likewise.
1462         (observer_mode): Likewise.
1463         (observer_mode_1): Likewise.
1464         (set_observer_mode): Update.
1465         (sched_multi): Change to bool.
1466         * infrun.h (debug_displaced): Likewise.
1467         (sched_multi): Likewise.
1468         (step_stop_if_no_debug): Likewise.
1469         (non_stop): Likewise.
1470         (disable_randomization): Likewise.
1471         * linux-tdep.c (use_coredump_filter): Likewise.
1472         (dump_excluded_mappings): Likewise.
1473         * linux-thread-db.c (auto_load_thread_db): Likewise.
1474         (check_thread_db_on_load): Likewise.
1475         * main.c (captured_main_1): Update.
1476         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1477         xx2_opt, boolean_opt>: Change to bool.
1478         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1479         * maint.c (maintenance_profile_p): Likewise.
1480         (per_command_time): Likewise.
1481         (per_command_space): Likewise.
1482         (per_command_symtab): Likewise.
1483         * memattr.c (inaccessible_by_default): Likewise.
1484         * mi/mi-main.c (mi_async): Likewise.
1485         (mi_async_1): Likewise.
1486         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1487         * nat/fork-inferior.h (startup_with_shell): Likewise.
1488         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1489         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1490         * nios2-tdep.c (nios2_debug): Likewise.
1491         * or1k-tdep.c (or1k_debug): Likewise.
1492         * parse.c (parser_debug): Likewise.
1493         * parser-defs.h (parser_debug): Likewise.
1494         * printcmd.c (print_symbol_filename): Likewise.
1495         * proc-api.c (procfs_trace): Likewise.
1496         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1497         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1498         (set_parameter_value): Update.
1499         (add_setshow_generic): Update.
1500         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1501         to bool*.
1502         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1503         int*.
1504         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1505         * record-btrace.c (record_btrace_target::store_registers): Update.
1506         * record-full.c (record_full_memory_query): Change to bool.
1507         (record_full_stop_at_limit): Likewise.
1508         * record-full.h (record_full_memory_query): Likewise.
1509         * remote-notif.c (notif_debug): Likewise.
1510         * remote-notif.h (notif_debug): Likewise.
1511         * remote.c (use_range_stepping): Likewise.
1512         (interrupt_on_connect): Likewise.
1513         (remote_break): Likewise.
1514         * ser-tcp.c (tcp_auto_retry): Likewise.
1515         * ser-unix.c (serial_hwflow): Likewise.
1516         * skip.c (debug_skip): Likewise.
1517         * solib-aix.c (solib_aix_debug): Likewise.
1518         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1519         (spu_auto_flush_cache_p): Likewise.
1520         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1521         Likewise.
1522         (struct info_print_options) <quiet>: Likewise.
1523         * symfile-debug.c (debug_symfile): Likewise.
1524         * symfile.c (auto_solib_add): Likewise.
1525         (separate_debug_file_debug): Likewise.
1526         * symfile.h (auto_solib_add): Likewise.
1527         (separate_debug_file_debug): Likewise.
1528         * symtab.c (basenames_may_differ): Likewise.
1529         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1530         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1531         (struct info_types_options) <quiet>: Likewise.
1532         * symtab.h (demangle): Likewise.
1533         (basenames_may_differ): Likewise.
1534         * target-dcache.c (stack_cache_enabled_1): Likewise.
1535         (code_cache_enabled_1): Likewise.
1536         * target.c (trust_readonly): Likewise.
1537         (may_write_registers): Likewise.
1538         (may_write_memory): Likewise.
1539         (may_insert_breakpoints): Likewise.
1540         (may_insert_tracepoints): Likewise.
1541         (may_insert_fast_tracepoints): Likewise.
1542         (may_stop): Likewise.
1543         (auto_connect_native_target): Likewise.
1544         (target_stop_and_wait): Update.
1545         (target_async_permitted): Change to bool.
1546         (target_async_permitted_1): Likewise.
1547         (may_write_registers_1): Likewise.
1548         (may_write_memory_1): Likewise.
1549         (may_insert_breakpoints_1): Likewise.
1550         (may_insert_tracepoints_1): Likewise.
1551         (may_insert_fast_tracepoints_1): Likewise.
1552         (may_stop_1): Likewise.
1553         * target.h (target_async_permitted): Likewise.
1554         (may_write_registers): Likewise.
1555         (may_write_memory): Likewise.
1556         (may_insert_breakpoints): Likewise.
1557         (may_insert_tracepoints): Likewise.
1558         (may_insert_fast_tracepoints): Likewise.
1559         (may_stop): Likewise.
1560         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1561         (make_thread_apply_all_options_def_group): Change argument from int*
1562         to bool*.
1563         (thread_apply_all_command): Update.
1564         (print_thread_events): Change to bool.
1565         * top.c (confirm): Likewise.
1566         (command_editing_p): Likewise.
1567         (history_expansion_p): Likewise.
1568         (write_history_p): Likewise.
1569         (info_verbose): Likewise.
1570         * top.h (confirm): Likewise.
1571         (history_expansion_p): Likewise.
1572         * tracepoint.c (disconnected_tracing): Likewise.
1573         (circular_trace_buffer): Likewise.
1574         * typeprint.c (print_methods): Likewise.
1575         (print_typedefs): Likewise.
1576         * utils.c (debug_timestamp): Likewise.
1577         (sevenbit_strings): Likewise.
1578         (pagination_enabled): Likewise.
1579         * utils.h (sevenbit_strings): Likewise.
1580         (pagination_enabled): Likewise.
1581         * valops.c (overload_resolution): Likewise.
1582         * valprint.h (struct value_print_options) <prettyformat_arrays,
1583         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1584         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1585         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1586         Likewise.
1587         * windows-nat.c (new_console): Likewise.
1588         (cygwin_exceptions): Likewise.
1589         (new_group): Likewise.
1590         (debug_exec): Likewise.
1591         (debug_events): Likewise.
1592         (debug_memory): Likewise.
1593         (debug_exceptions): Likewise.
1594         (useshell): Likewise.
1595         * windows-tdep.c (maint_display_all_tib): Likewise.
1596         * xml-support.c (debug_xml): Likewise.
1597
1598 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1599
1600         * source.c (prepare_path_for_appending): New function.
1601         (openp): Make use of new function.
1602         (find_and_open_source): Search for the compilation directory and
1603         source file as a relative path beneath the directory search path.
1604
1605 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * source-cache.c (source_cache::get_line_charpos): Catch
1608         exceptions and return false, this matches the behaviour documented
1609         in the header file.
1610
1611 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1612
1613         * ada-tasks.c (info_task): Remove quoting of the task's name.
1614
1615 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1616
1617         * symfile.c (auto_solib_add): Replace comment with a reference
1618         to the header file.
1619
1620 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1621
1622         * NEWS: Mention that gdb can now be compiled with Python 3
1623         on Windows.
1624
1625 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * maint.c (maint_print_section_data::maint_print_section_data):
1628         Force use of 'float log10 (float)' by casting the argument to
1629         float.
1630
1631 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * maint.c: Add 'cmath' include.
1634         (struct maint_print_section_data): New structure.
1635         (print_section_index): New function.
1636         (print_bfd_section_info): Add header comment, small whitespace
1637         cleanup, and update to call new print_section_index function.
1638         (print_objfile_section_info): Likewise.
1639         (maint_obj_section_from_bfd_section): New function.
1640         (print_bfd_section_info_maybe_relocated): New function.
1641         (maintenance_info_sections): Add header comment, always use
1642         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1643
1644 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1645
1646         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1647         inner scope, add check that the objfile has psymtabs before
1648         checking psymtabs_addrmap.
1649         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1650
1651 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1652
1653         * NEWS: Announce that Ada task names are now shown at more places,
1654         and between quotes (except in info task output).
1655         * gdb/ada-tasks.c (task_to_str): New function.
1656         (display_current_task_id): Call task_to_str.
1657         (task_command_1): Likewise.
1658         (print_ada_task_info): In non-mi mode, Properly align headers and data
1659         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1660
1661 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1662
1663         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1664         prstatus.pr_lwp.pr_info instead of making it up.
1665
1666 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1667
1668         * auto-load.c (auto_load_expand_dir_vars): Update.
1669         * defs.h (gdb_datadir): Change to std::string.
1670         (python_libdir): Likewise.
1671         (relocate_gdb_directory): Change return type to std::string.
1672         * guile/guile.c (gdbscm_data_directory): Update.
1673         (initialize_scheme_side): Update.
1674         * jit.c (jit_reader_dir): Change to std::string.
1675         (jit_reader_load_command): Update.
1676         * main.c (gdb_datadir): Change to std::string.
1677         (python_libdir): Likewise.
1678         (set_gdb_data_directory): Update.
1679         (relocate_path): Change to return std::string.
1680         (relocate_gdb_directory): Change to return std::string.
1681         (relocate_gdbinit_path_maybe_in_datadir): Update.
1682         (captured_main_1): Update.
1683         * python/python.c (do_start_initialization): Update.
1684         * top.c (show_gdb_datadir): Update.
1685         * xml-syscall.c (xml_init_syscalls_info): Update.
1686         (init_syscalls_info): Update.
1687
1688 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1689
1690         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1691         out of get_init_files.
1692         (get_init_files): Update.
1693
1694 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1695
1696         * main.c (get_init_files): Change to use std::string.
1697         (captured_main_1): Update.
1698         (print_gdb_help): Update.
1699
1700 2019-09-11  Ali Tamur  <tamur@google.com>
1701
1702         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1703         implementation.
1704
1705 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1706
1707         * dbxread.c (read_dbx_symtab): Update.
1708         * dwarf2read.c (load_partial_dies): Update.
1709         * mdebugread.c (parse_partial_symbols): Update.
1710         (handle_psymbol_enumerators): Update.
1711         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1712         * psymtab.c (add_psymbol_to_bcache): Likewise.
1713         (add_psymbol_to_list): Likewise.
1714         * symtab.c (symbol_set_names): Likewise.
1715         * symtab.h (symbol_set_names): Likewise.
1716         * xcoffread.c (scan_xcoff_symtab): Update.
1717
1718 2019-09-11  Tom Tromey  <tom@tromey.com>
1719
1720         * symfile-mem.c (symbol_file_add_from_memory): Use
1721         bfd_set_filename.
1722         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1723         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1724
1725 2019-09-10  Tom Tromey  <tromey@adacore.com>
1726
1727         * dwarf-index-write.c (write_psymbols): Extend error message.
1728         (debug_names::insert): Add Ada code.
1729         (debug_names::write_psymbols): Remove Ada check.
1730         (debug_names) <m_string_obstack>: New member.
1731         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1732         (gdb_index_symbol_name_matcher::matches): Remove.
1733         (mapped_index_base::find_name_components_bounds): Add "lang"
1734         parameter.
1735         (mapped_index_base::build_name_components): Also split names
1736         according to Ada syntax.
1737         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1738         type of "match_callback".
1739         (check_match, check_find_bounds_finds)
1740         (dw2_expand_symtabs_matching): Update.
1741         (dw2_debug_names_iterator): Add new constructor.
1742         (dw2_debug_names_map_matching_symbols): New function.
1743         (dw2_debug_names_expand_symtabs_matching): Update.
1744         (dwarf2_debug_names_functions): Use
1745         dw2_debug_names_map_matching_symbols.
1746
1747 2019-09-10  Tom Tromey  <tromey@adacore.com>
1748
1749         * dwarf2read.c (dw2_get_file_names_reader): Add the
1750         CU's file name to the results.
1751
1752 2019-09-10  Tom Tromey  <tromey@adacore.com>
1753
1754         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1755         map_matching_symbols.  Update.
1756         * dwarf2read.c (dw2_map_matching_symbols): Update.
1757         * psymtab.c (match_partial_symbol): Change type; update.
1758         (psym_map_matching_symbols): Likewise.
1759         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1760         type; update.
1761         * symfile.h (struct quick_symbol_functions)
1762         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1763         Remove "match".
1764
1765 2019-09-10  Tom Tromey  <tromey@adacore.com>
1766
1767         * psymtab.c (map_block): Remove.
1768         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1769         * symtab.c (iterate_over_symbols_terminated): New function.
1770         * symtab.c (iterate_over_symbols_terminated): Declare.
1771
1772 2019-09-10  Tom Tromey  <tromey@adacore.com>
1773
1774         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1775         * language.h (struct language_defn) <la_iterate_over_symbols>:
1776         Return bool.
1777         * symtab.c (iterate_over_symbols): Return bool.
1778         * symtab.h (iterate_over_symbols): Return bool.
1779
1780 2019-09-10  Tom Tromey  <tromey@adacore.com>
1781
1782         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1783         (add_nonlocal_symbols): Update.
1784         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1785         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1786         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1787         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1788         Change type of "callback".  Remove "data".
1789
1790
1791 2019-09-09  Ali Tamur  <tamur@google.com>
1792
1793         * dwarf2read.c (comp_unit_head): Update comment.
1794         (dwarf2_dwo_name): New function declaration.
1795         (dwarf_unit_type_name): New function declaration.
1796         (read_comp_unit_head): Add support for new compilation units,
1797         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1798         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1799         (currently named as "signature") in their header. Also clarify error
1800         messages.
1801         (lookup_dwo_id): New function. Returns the dwo id of the given
1802         compile unit.
1803         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1804         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1805         functions.
1806         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1807         (dwarf2_dwo_name): Get the dwo name if present.
1808         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1809         purposes.
1810
1811 2019-09-09  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1814
1815 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1816
1817         * python/python.c (do_start_initialization): Make progname_copy static,
1818         to avoid a leak report.
1819
1820 2019-09-08  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1823
1824 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1825
1826         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1827         Change type to gdb::optional<block_enum>.
1828         (dw2_symtab_iter_init): Change block_index parameter type
1829         to gdb::optional<block_enum>.
1830         (dw2_lookup_symbol): Change block_index parameter
1831         type to block_enum.c
1832         (dw2_debug_names_lookup_symbol): Likewise.
1833         * psymtab.c (psym_lookup_symbol): Likewise.
1834         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1835         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1836         Likewise.
1837
1838 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1839
1840         * defs.h (relocate_gdb_directory): Change int to bool in
1841         signature and rename flag to relocatable.
1842         * main.c (relocate_path): Likewise.
1843         (relocate_gdb_directory): Likewise.
1844
1845 2019-09-06  Alan Modra  <amodra@gmail.com>
1846
1847         * coffread.c (coff_symfile_read): Constify filename variable.
1848         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1849         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1850         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1851         * solib.c (reload_shared_libraries_1): Likewise.
1852         * symfile.c (reread_symbols): Likewise.
1853         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1854         * solib-darwin.c (darwin_bfd_open): Likewise.
1855         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1856
1857 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1858
1859         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1860         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1861
1862 2019-09-03  Tom Tromey  <tromey@adacore.com>
1863
1864         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1865         types.
1866         (has_negatives): Unbias a range type bound.
1867         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1868         * gdbtypes.c (operator==): Handle new field.
1869         (create_range_type): Add "bias" parameter.
1870         (create_static_range_type, resolve_dynamic_range): Update.
1871         * gdbtypes.h (struct range_bounds) <bias>: New member.
1872         (create_range_type): Add bias parameter.
1873         * printcmd.c (print_scalar_formatted): Unbias range types.
1874         * value.c (unpack_long): Unbias range types.
1875         (pack_long): Bias range types.
1876
1877 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1878
1879         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1880         probe arguments.
1881
1882 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1883
1884         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1885         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1886         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1887         (compile_probe_arg): Likewise.
1888         * probe.h (get_argument_count): Likewise.
1889         * solib-svr4.c (solib_event_probe_action): Likewise.
1890         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1891
1892 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1893
1894         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1895         code to here...
1896         (svr4_create_solib_event_breakpoints): ...from here.
1897
1898 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1899
1900         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1901         suffix from warning message.
1902
1903 2019-08-30  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-winsource.h (struct tui_source_window_base)
1906         <refresh_all>: Don't declare.
1907         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1908         Remove.
1909         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1910         tui_show_locator_content.
1911         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1912         declare.
1913         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1914         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1915         declare.
1916
1917 2019-08-30  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1920
1921 2019-08-30  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1924         Remove unnecessary forward declarations.
1925
1926 2019-08-30  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1929         rerender.
1930         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1931         tui_show_locator_content.
1932
1933 2019-08-30  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1936         (tui_locator_window::rerender): Rewrite using body of previous
1937         tui_show_locator_content.
1938
1939 2019-08-30  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1942         set_locator_fullname>: New methods.
1943         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1944         Rename from tui_set_locator_fullname.
1945         (tui_locator_window::set_locator_info): Rename from
1946         tui_set_locator_info.  Return bool.
1947         (tui_update_locator_fullname, tui_show_frame_info): Update.
1948
1949 2019-08-30  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1952
1953 2019-08-30  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1956         call touchwin.
1957
1958 2019-08-30  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-wingeneral.c (box_win): Assume win_info and
1961         win_info->handle cannot be NULL.
1962
1963 2019-08-30  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1966         refresh_window>: Declare.
1967         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1968         resize.
1969         (tui_data_item_window::rerender): Rename from
1970         tui_display_register.
1971         (tui_data_item_window::refresh_window): New method.
1972         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1973         no-op.
1974
1975 2019-08-30  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1978         regs_column_count, current_group>: Move later.  Now private.
1979         <get_current_group>: New method.
1980         * tui/tui-regs.c (tui_reg_command): Update.
1981         * tui/tui-layout.c (tui_set_layout): Update.
1982
1983 2019-08-30  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1986         (tui_data_window::rerender): Don't call
1987         check_and_display_highlight_if_needed.
1988         (tui_data_window::refresh_all): Remove call to
1989         erase_data_content.
1990
1991 2019-08-30  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1994         (tui_data_window::display_registers_from)
1995         (tui_data_window::display_reg_element_at_line)
1996         (tui_data_window::display_registers_from_line): Remove checks of
1997         "empty".
1998
1999 2019-08-30  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2002         Don't declare.
2003         * tui/tui-regs.c (tui_data_window::show_registers): Call
2004         rerender.
2005         (tui_data_window::rerender): Rename from display_all_data.
2006         (tui_data_window::rerender): Remove old implementation.
2007
2008 2019-08-30  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2011         text.
2012         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2013
2014 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2015             Sergio Durigan Junior  <sergiodj@redhat.com>
2016
2017         PR win32/24284
2018         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2019
2020 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2021
2022         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2023         when searching for types.
2024
2025 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2026
2027         * f-lang.c (f_language_defn): Use f_print_typedef.
2028         * f-lang.h (f_print_typedef): Declare.
2029         * f-typeprint.c (f_print_typedef): Define.
2030
2031 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2032
2033         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2034
2035 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2036
2037         * cli/cli-utils.c (info_print_options_defs): Delete.
2038         (make_info_print_options_def_group): Delete.
2039         (extract_info_print_options): Delete.
2040         (info_print_command_completer): Delete.
2041         (info_print_args_help): Add extra parameter, and optionally
2042         include text about -n flag.
2043         * cli/cli-utils.h (struct info_print_options): Delete.
2044         (extract_info_print_options): Delete declaration.
2045         (info_print_command_completer): Delete declaration.
2046         (info_print_args_help): Add extra parameter, extend header
2047         comment.
2048         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2049         search_symbols.
2050         * stack.c (struct info_print_options): New type.
2051         (info_print_options_defs): New file scoped variable.
2052         (make_info_print_options_def_group): New static function.
2053         (info_print_command_completer): New static function.
2054         (info_locals_command): Update to use new local functions.
2055         (info_args_command): Likewise.
2056         (_initialize_stack): Add extra parameter to calls to
2057         info_print_args_help.
2058         * symtab.c (search_symbols): Add extra parameter, use this to
2059         possibly excluse non-debug symbols.
2060         (symtab_symbol_info): Add extra parameter, which is passed on to
2061         search_symbols.
2062         (struct info_print_options): New type.
2063         (info_print_options_defs): New file scoped variable.
2064         (make_info_print_options_def_group): New static function.
2065         (info_print_command_completer): New static function.
2066         (info_variables_command): Update to use local functions, and pass
2067         extra parameter through to symtab_symbol_info.
2068         (info_functions_command): Likewise.
2069         (info_types_command): Pass additional argument through to
2070         symtab_symbol_info.
2071         (rbreak_command): Pass extra argument to search_symbols.
2072         (_initialize_symtab): Add extra arguments for calls to
2073         info_print_args_help, and update help text for 'info variables',
2074         'whereis', and 'info functions' commands.
2075         * symtab.h (search_symbols): Add extra argument to declaration.
2076         * NEWS: Mention new flags.
2077
2078 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2079
2080         * symtab.c (lookup_static_symbol): Call the new function (and move
2081         it down to be next to lookup_global_symbol).
2082         (struct global_sym_lookup_data): Add block_enum member and rename to...
2083         (struct global_or_static_sym_lookup_data): ...this.
2084         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2085         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2086         (lookup_symbol_global_or_static_iterator_cb): ...this.
2087         (lookup_global_or_static_symbol): New function.
2088         (lookup_global_symbol): Call new function.
2089
2090 2019-08-26  Tom de Vries  <tdevries@suse.de>
2091
2092         PR c++/24852
2093         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2094         when pc_probe.prob == NULL.
2095
2096 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2097
2098         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2099         variable symbol_linkage to symbol_linkage_.
2100
2101 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2102
2103         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2104         represent whether the symbol is static, dynamic, or we don't
2105         know.
2106
2107 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2108
2109         * gdb/rx-tdep.c (rx_register_names): New.
2110         (rx_register_name): Delete.
2111         (rx_psw_type): Delete.
2112         (rx_fpsw_type): Delete.
2113         (rx_register_type): Delete.
2114         (rx_gdbarch_init): Convert target-descriptions.
2115         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2116         * gdb/features/Makefile: Add rx.xml.
2117         * gdb/features/rx.xml: New.
2118         * gdb/features/rx.c: Generated.
2119         * gdb/NEWS: Mention target description support.
2120
2121 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2122
2123         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2124         *slot_ptr.
2125
2126 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2127
2128         * configure.ac: Don't check for 'dlfcn.h' (moved to
2129         gdbsupport/common.m4).
2130         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2131         'gdbsupport/'.
2132         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2133         * compile/compile-c-support.c: Include
2134         'gdbsupport/gdb-dlfcn.h'.
2135         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2136         * gdb-dlfcn.c: Move to...
2137         * gdbsupport/gdb-dlfcn.c: ... here.
2138         * gdb-dlfcn.h: Move to...
2139         * gdbsupport/gdb-dlfcn.h: ... here.
2140
2141 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2142
2143         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2144         the offset field signed.
2145
2146 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2147
2148         * python/lib/gdb/__init__.py (_execute_file): New function.
2149         * python/python.c (python_run_simple_file): Call gdb._execute_file
2150         on Windows.
2151
2152 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2153
2154         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2155         all uses as this was never set to anything but a zero value.
2156
2157 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2158
2159         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2160
2161 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2162
2163         * tui/tui-data.h (tui_gen_win_info): Add an =default
2164         move constructor, required by some GCC versions.
2165
2166 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2167
2168         * go32-nat.c (go32_sysinfo): Add hygon_p.
2169
2170 2019-08-20  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2173         line_from_reg_element_no, first_reg_element_no_inline,
2174         display_all_data, delete_data_content_windows,
2175         erase_data_content>: Now private.
2176
2177 2019-08-20  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2180         (tui_unhighlight_win, tui_highlight_win)
2181         (tui_win_info::make_window): Update.
2182         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2183
2184 2019-08-20  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2187         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2188         (MAX_PID_WIDTH): Move to tui-stack.c.
2189         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2190         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2191         (MAX_PID_WIDTH): Move from tui-data.h.
2192
2193 2019-08-20  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2196         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2197         (box_win): Update.
2198         (tui_gen_win_info::make_window): Rename from tui_make_window.
2199         (tui_win_info::make_window): New method.
2200         (tui_gen_win_info::make_visible): Update.
2201         * tui/tui-source.c (tui_source_window::set_contents): Update.
2202         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2203         (tui_data_window::display_registers_from): Update.
2204         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2205         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2206         Declare.
2207         <can_box>: Remove.
2208         <title>: Remove.
2209         (struct tui_win_info) <make_window>: Declare.
2210         <can_box>: Now virtual.
2211         <title>: New member.
2212         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2213         * tui/tui-command.c (tui_cmd_window::resize): Update.
2214
2215 2019-08-20  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2218         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2219         (tui_data_window::check_register_values): Update.
2220
2221 2019-08-20  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-regs.h (struct tui_data_window): Use
2224         DISABLE_COPY_AND_ASSIGN.
2225         <regs_content>: Change type, removing unique_ptr.
2226         <tui_data_window>: Add move constructor.
2227         * tui/tui-regs.c (tui_data_window::show_registers)
2228         (tui_data_window::show_register_group)
2229         (tui_data_window::display_registers_from)
2230         (tui_data_window::display_registers_from)
2231         (tui_data_window::first_data_item_displayed)
2232         (tui_data_window::delete_data_content_windows)
2233         (tui_data_window::rerender, tui_data_window::refresh_window)
2234         (tui_data_window::check_register_values): Update.
2235
2236 2019-08-20  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2239         show_register_group>: Declare.
2240         (tui_show_register_group): Don't declare.
2241         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2242         tui_show_registers.
2243         (tui_data_window::show_register_group): Rename from
2244         tui_show_register_group.
2245         (tui_data_window::check_register_values, tui_reg_command):
2246         Update.
2247         * tui/tui-layout.c (tui_set_layout): Update.
2248
2249 2019-08-20  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2252         Declare.
2253         (tui_check_register_values): Don't declare.
2254         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2255         from tui_check_register_values.
2256         * tui/tui-hooks.c (tui_register_changed): Update.
2257
2258 2019-08-20  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-regs.c (tui_reg_layout): Move later.
2261         (tui_show_registers): Don't enable TUI mode or change layout.
2262
2263 2019-08-20  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-regs.h (struct tui_data_item_window)
2266         <~tui_data_item_window>: Remove.
2267         <content>: Now a unique_xmalloc_ptr.
2268         * tui/tui-regs.c (tui_register_format): Return a
2269         unique_xmalloc_ptr.
2270         (tui_get_register): Update.
2271         (~tui_data_item_window): Remove.
2272         (tui_data_window::display_registers_from, tui_display_register):
2273         Update.
2274         * tui/tui-io.h (tui_expand_tabs): Update.
2275         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2276         Remove "col" parameter.
2277
2278 2019-08-20  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2281         field.
2282         * tui/tui-regs.c (~tui_data_item_window): Update.
2283
2284 2019-08-20  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2287         earlier.
2288
2289 2019-08-20  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2292
2293 2019-08-20  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-source.h (struct tui_source_window): Update.
2296         * tui/tui-regs.c (tui_show_registers): Update.
2297         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2298         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2299         (NO_REGS_STRING): Remove defines.
2300
2301 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2302
2303         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2304         unnecessary thread walk if remote doesn't support the packet.
2305
2306 2019-08-19  Tom Tromey  <tromey@adacore.com>
2307
2308         * python/py-value.c (value_has_field): Fix indentation.
2309
2310 2019-08-19  Tom Tromey  <tromey@adacore.com>
2311
2312         * printcmd.c (do_one_display, info_display_command): Update.
2313         * block.h (contained_in): Return bool.  Add allow_nested
2314         parameter.
2315         * block.c (contained_in): Return bool.  Add allow_nested
2316         parameter.
2317
2318 2019-08-19  Tom Tromey  <tom@tromey.com>
2319
2320         * configure: Rebuild.
2321         * configure.ac: Disallow the combination of -static-libstdc++ and
2322         source highlight.
2323         * source-cache.c (get_language_name): Handle rust.
2324         (source_cache::get_source_lines): Ignore highlighting exceptions.
2325
2326 2019-08-16  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2329         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2330         (struct tui_source_window_base) <make_visible, refresh_window,
2331         resize>: Remove methods.
2332         <execution_info>: Remove field.
2333         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2334         (tui_show_source_line, tui_source_window_base)
2335         (~tui_source_window_base): Update.
2336         (tui_source_window_base::resize)
2337         (tui_source_window_base::make_visible)
2338         (tui_source_window_base::refresh_window): Remove.
2339         (tui_source_window_base::update_exec_info): Update.
2340         * tui/tui-source.c (tui_source_window::set_contents): Update.
2341         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2342
2343 2019-08-16  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2346         deprecated_query_hook.
2347
2348 2019-08-16  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2351         (tui_update_source_windows_with_line): Update.
2352         * tui/tui-source.h (struct tui_source_window)
2353         <show_symtab_source>: Declare.
2354         (tui_show_symtab_source): Don't declare.
2355         * tui/tui-source.c (tui_show_symtab_source): Rename from
2356         tui_show_symtab_source.
2357
2358 2019-08-16  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-winsource.h (struct tui_source_window_base)
2361         <set_contents>: Declare.
2362         * tui/tui-winsource.c
2363         (tui_source_window_base::update_source_window_as_is): Update.
2364         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2365         Declare.
2366         (tui_set_source_content): Don't declare.
2367         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2368         tui_set_source_content.
2369         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2370         Declare.
2371         (tui_set_disassem_content): Don't declare.
2372         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2373         tui_set_disassem_content.
2374
2375 2019-08-16  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-winsource.h (struct tui_source_window_base)
2378         <update_breakpoint_info>: Declare.
2379         (tui_update_breakpoint_info): Don't declare.
2380         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2381         (tui_update_all_breakpoint_info): Update.
2382         (tui_source_window_base::update_breakpoint_info): Rename from
2383         tui_update_breakpoint_info.
2384         (tui_source_window_base::update_exec_info): Update.
2385
2386 2019-08-16  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-winsource.h (struct tui_source_window_base)
2389         <update_source_window>: Declare.
2390         (tui_update_source_window): Don't declare.
2391         * tui/tui-winsource.c
2392         (tui_source_window_base::update_source_window): Rename from
2393         tui_update_source_window.
2394         (tui_source_window_base::rerender): Update.
2395         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2396         * tui/tui-disasm.c (tui_show_disassem)
2397         (tui_show_disassem_and_update_source)
2398         (tui_disasm_window::maybe_update): Update.
2399
2400 2019-08-16  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-winsource.h (struct tui_source_window_base)
2403         <update_source_window_as_is>: Declare.
2404         (tui_update_source_window_as_is): Don't declare.
2405         * tui/tui-winsource.c (tui_update_source_window): Update
2406         (tui_source_window_base::update_source_window_as_is): Rename from
2407         tui_update_source_window_as_is.
2408         (tui_source_window_base::refill): Update.
2409         * tui/tui-source.c (tui_show_symtab_source): Update.
2410         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2411         Update.
2412
2413 2019-08-16  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-winsource.h (tui_update_source_window)
2416         (tui_update_source_window_as_is): Remove "noerror" parameter.
2417         * tui/tui-winsource.c (tui_update_source_window)
2418         (tui_update_source_window_as_is): Remove "noerror" parameter.
2419         (tui_update_source_windows_with_addr)
2420         (tui_update_source_windows_with_line)
2421         (tui_source_window_base::rerender)
2422         (tui_source_window_base::refill): Update.
2423         * tui/tui-source.h (tui_set_source_content)
2424         (tui_show_symtab_source): Remove "noerror" parameter.
2425         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2426         parameter.
2427         (tui_show_symtab_source): Likewise.
2428         (tui_source_window::maybe_update): Update.
2429         * tui/tui-disasm.c (tui_show_disassem)
2430         (tui_show_disassem_and_update_source)
2431         (tui_disasm_window::do_scroll_vertical)
2432         (tui_disasm_window::maybe_update): Update.
2433
2434 2019-08-16  Tom Tromey  <tom@tromey.com>
2435
2436         * tui/tui.c (tui_is_window_visible): Update.
2437         * tui/tui-wingeneral.c (tui_make_window)
2438         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2439         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2440         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2441         (tui_set_win_height_command, parse_scrolling_args): Update.
2442         * tui/tui-source.c (tui_source_window::style_changed): Update.
2443         * tui/tui-regs.c (tui_show_registers)
2444         (tui_data_window::first_data_item_displayed)
2445         (tui_data_window::delete_data_content_windows)
2446         (tui_check_register_values, tui_reg_command): Update.
2447         * tui/tui-disasm.c (tui_show_disassem): Update.
2448         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2449         method.
2450         <is_visible>: Remove field.
2451         * tui/tui-data.c (tui_next_win, tui_prev_win)
2452         (tui_delete_invisible_windows): Update.
2453
2454 2019-08-16  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-winsource.h (struct tui_source_window_base)
2457         <m_has_locator>: Remove.
2458         * tui/tui-layout.c (show_source_disasm_command, show_data)
2459         (show_source_or_disasm_and_command): Update.
2460
2461 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2462
2463         * NEWS (Other MI changes): New subsection.
2464         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2465         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2466         * arch-utils.c (default_get_pc_address_flags): New function.
2467         * arch-utils.h (default_get_pc_address_flags): New declaration.
2468         * gdbarch.sh: Add get_pc_address_flags.
2469         * gdbarch.c: Regenerate.
2470         * gdbarch.h: Likewise.
2471         * stack.c (print_pc): New function.
2472         (print_frame_info) (print_frame): Call print_pc.
2473
2474 2019-08-16  Tom de Vries  <tdevries@suse.de>
2475
2476         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2477         print_objfile_section_info.
2478
2479 2019-08-15  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2482         calling update_cmdwin_start_line.
2483         * tui/tui-winsource.h (struct tui_source_window_base)
2484         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2485         <rerender>: Declare.
2486         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2487         Call rerender.
2488         (tui_source_window_base::set_new_height): Remove.
2489         (tui_source_window_base::rerender): Rename from
2490         do_make_visible_with_new_height.
2491         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2492         resize method.
2493         (tui_win_info::make_invisible_and_set_new_height)
2494         (tui_win_info::make_visible_with_new_height): Remove.
2495         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2496         Declare.
2497         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2498         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2499         do_make_visible_with_new_height>: Don't declare.
2500         <rerender>: Declare.
2501         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2502         set_new_height.
2503         (tui_data_window::do_make_visible_with_new_height): Remove.
2504         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2505         call tui_show_locator_content.
2506         (tui_gen_win_info::resize): Call rerender.
2507         (show_source_or_disasm_and_command): Don't call
2508         tui_show_locator_content.
2509         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2510         method.
2511         (struct tui_win_info) <rerender>: Declare.
2512         <set_new_height, make_invisible_and_set_new_height,
2513         make_visible_with_new_height>: Don't declare.
2514         * tui/tui-data.c (tui_win_list::rerender): New method.
2515         * tui/tui-command.h (struct tui_cmd_window)
2516         <do_make_visible_with_new_height>: Don't declare.
2517         * tui/tui-command.c
2518         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2519
2520 2019-08-15  Tom Tromey  <tromey@adacore.com>
2521
2522         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2523         * ada-lang.c (ada_enum_name): Likewise.
2524
2525 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2526
2527         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2528         leading underscore.
2529         (GdbOutputErrorFile): Likewise.
2530         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2531         accordingly.
2532         (execute_unwinders): Rename to have a leading underscore.
2533         (auto_load_packages): Likewise.
2534         (global scope): Adjust call to auto_load_packages accordingly.
2535         (GdbSetPythonDirectory): Likewise.
2536         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2537         instead of execute_unwinders.
2538
2539 2019-08-15  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2542         (show_data): Don't change window visibility.
2543         (tui_gen_win_info::resize): Remove special case for command
2544         window.  Use wresize, when available.
2545         (show_source_or_disasm_and_command): Don't change window
2546         visibility.
2547         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2548         <make_visible>: New method.
2549         * tui/tui-command.c (tui_cmd_window::resize): New method.
2550
2551 2019-08-15  Tom Tromey  <tom@tromey.com>
2552
2553         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2554         (struct tui_source_windows): New.
2555         * tui/tui-winsource.c (tui_display_main): Update.
2556         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2557         (new_height_ok, parse_scrolling_args): Update.
2558         * tui/tui-layout.c (show_layout, show_data): Update.
2559         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2560         (tui_add_to_source_windows): Don't declare.
2561         * tui/tui-data.c (source_windows, tui_source_windows)
2562         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2563
2564 2019-08-15  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2567         Rename from reset.
2568         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2569         * tui/tui-layout.c (show_source_disasm_command, show_data):
2570         Update.
2571         (tui_gen_win_info::resize): Rename.
2572         (show_source_or_disasm_and_command): Update.
2573         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2574         reset.
2575
2576 2019-08-15  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2579         * tui/tui-interp.c (tui_interp::init): Don't call
2580         tui_initialize_static_data.
2581         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2582
2583 2019-08-15  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2586         examine tui_win_list.
2587
2588 2019-08-15  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2591         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2592         tui_clear_source_content.
2593         (tui_clear_source_content): Remove.
2594         (tui_source_window_base::do_erase_source_content): Hoist call to
2595         content.clear().
2596         * tui/tui-stack.c (tui_show_frame_info): Don't call
2597         tui_clear_source_content.
2598
2599 2019-08-15  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-winsource.h (struct tui_source_window_base)
2602         <do_erase_source_content>: New method.
2603         <erase_source_content>: New method.
2604         (tui_erase_source_content): Don't declare.
2605         * tui/tui-winsource.c (tui_clear_source_content): Update.
2606         (tui_source_window_base::do_erase_source_content): Rename from
2607         tui_erase_source_content.
2608         (tui_source_window_base::show_source_content): Update.
2609         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2610         * tui/tui-source.h (struct tui_source_window)
2611         <erase_source_content>: New method.
2612         * tui/tui-disasm.h (struct tui_disasm_window)
2613         <erase_source_content>: New method.
2614
2615 2019-08-15  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2618         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2619         constructor.
2620         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2621         * tui/tui-source.c (tui_set_source_content): Update.
2622         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2623
2624 2019-08-15  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2627         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2628         tui-source.c.
2629         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2630         Declare.
2631         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2632         method.
2633         (tui_source_window::maybe_update): Update.
2634
2635 2019-08-15  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2638         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2639         tui-disasm.c.
2640         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2641         Declare.
2642         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2643         method.
2644         (tui_disasm_window::maybe_update): Update.
2645
2646 2019-08-15  Tom Tromey  <tom@tromey.com>
2647
2648         * tui/tui-winsource.h (struct tui_source_window_base)
2649         <maybe_update>: Declare.
2650         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2651         method.
2652         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2653         Declare.
2654         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2655         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2656         Declare.
2657         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2658
2659 2019-08-15  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2662
2663 2019-08-15  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-wingeneral.c: Include tui-stack.h.
2666         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2667         (struct tui_locator_window): Move from tui-data.h.
2668         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2669         (tui_initialize_static_data): Move from tui-data.c.
2670         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2671         (struct tui_locator_window): Move to tui-stack.c.
2672         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2673         (tui_initialize_static_data): Move to tui-stack.c.
2674
2675 2019-08-15  Tom Tromey  <tom@tromey.com>
2676
2677         * tui/tui-layout.c (show_source_disasm_command)
2678         (show_source_or_disasm_and_command): Use make_visible method, not
2679         tui_make_window.
2680         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2681         Remove.
2682
2683 2019-08-15  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-wingeneral.h (tui_make_window): Update.
2686         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2687         parameter.
2688         (tui_gen_win_info::make_visible): Update.
2689         * tui/tui-regs.c (tui_data_window::display_registers_from):
2690         Update.
2691         * tui/tui-layout.c (show_source_disasm_command)
2692         (show_source_or_disasm_and_command): Update.
2693         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2694         (enum tui_box): Remove.
2695         (struct tui_win_info) <can_box>: New method.
2696         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2697         method.
2698
2699 2019-08-15  Tom de Vries  <tdevries@suse.de>
2700
2701         * linux-nat-trad.c: Include gdbarch.h.
2702
2703 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2704
2705         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2706         register sizes.
2707
2708 2019-08-14  Tom Tromey  <tromey@adacore.com>
2709
2710         * darwin-nat.c: Include gdbarch.h.
2711         * darwin-nat-info.c: Include gdbarch.h.
2712
2713 2019-08-13  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2716         Remove.
2717         * tui/tui-data.c (tui_initialize_static_data): Update.
2718
2719 2019-08-13  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-winsource.h (struct tui_exec_info_window)
2722         <~tui_exec_info_window, maybe_allocate_content, get_content,
2723         m_content>: Remove.
2724         (struct tui_source_window_base) <set_exec_info_content,
2725         show_exec_info_content>: Don't declare.
2726         * tui/tui-winsource.c
2727         (tui_exec_info_window::maybe_allocate_content): Remove.
2728         (tui_source_window_base::update_exec_info): Rename from
2729         set_exec_info_content.
2730         (tui_source_window_base::show_exec_info_content)
2731         (tui_source_window_base::update_exec_info): Remove.
2732
2733 2019-08-13  Tom Tromey  <tom@tromey.com>
2734
2735         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2736         declare.
2737         * tui/tui-winsource.c (tui_update_source_window_as_is)
2738         (tui_update_source_windows_with_addr, tui_erase_source_content):
2739         Update.
2740         (tui_clear_exec_info_content): Remove.
2741
2742 2019-08-13  Tom Tromey  <tom@tromey.com>
2743
2744         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2745         declare.
2746         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2747         call tui_erase_exec_info_content.
2748         (tui_clear_exec_info_content): Rename from
2749         tui_erase_exec_info_content.
2750         (tui_clear_exec_info_content): Delete.
2751
2752 2019-08-13  Tom Tromey  <tom@tromey.com>
2753
2754         * tui/tui-winsource.h (struct tui_source_window_base)
2755         <show_exec_info_content>: Declare.
2756         (tui_show_exec_info_content): Don't declare.
2757         * tui/tui-winsource.c
2758         (tui_source_window_base::show_exec_info_content): Rename from
2759         tui_show_exec_info_content.
2760         (tui_source_window_base::update_exec_info): Update.
2761
2762 2019-08-13  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2765         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2766         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2767         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2768         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2769         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2770         ... here.
2771
2772 2019-08-13  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-winsource.h (struct tui_source_window_base)
2775         <update_exec_info>: Declare.
2776         (tui_update_exec_info): Don't declare.
2777         * tui/tui-winsource.c (tui_update_source_window_as_is)
2778         (tui_source_window_base::refresh_all)
2779         (tui_update_all_breakpoint_info): Update.
2780         (tui_source_window_base::update_exec_info): Rename from
2781         tui_update_exec_info.
2782         * tui/tui-stack.c (tui_show_frame_info): Update.
2783
2784 2019-08-13  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-winsource.h (struct tui_source_window_base)
2787         <set_exec_info_content>: Declare.
2788         (tui_set_exec_info_content): Don't declare.
2789         * tui/tui-winsource.c
2790         (tui_source_window_base::set_exec_info_content): Rename from
2791         tui_set_exec_info_content.
2792         (tui_update_exec_info): Update.
2793
2794 2019-08-13  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-winsource.h (struct tui_source_window_base)
2797         <show_source_content>: Declare.
2798         (tui_show_source_content): Don't declare.
2799         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2800         (tui_source_window_base::show_source_content): Rename from
2801         tui_show_source_content.
2802         (tui_source_window_base::refresh_all): Update.
2803         * tui/tui-layout.c (show_source_disasm_command)
2804         (show_source_or_disasm_and_command): Update.
2805
2806 2019-08-13  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-winsource.c (tui_erase_source_content)
2809         (tui_show_source_content, tui_source_window_base::refresh_all):
2810         Update.
2811         * tui/tui-wingeneral.h
2812         (tui_check_and_display_highlight_if_needed): Don't declare.
2813         * tui/tui-wingeneral.c
2814         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2815         check_and_display_highlight_if_needed.
2816         * tui/tui-win.c (tui_rehighlight_all)
2817         (tui_win_info::make_visible_with_new_height): Update.
2818         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2819         (tui_data_window::erase_data_content)
2820         (tui_data_window::display_all_data): Update.
2821         * tui/tui-data.h (struct tui_win_info)
2822         <check_and_display_highlight_if_needed>: Declare.
2823
2824 2019-08-13  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-win.c (tui_resize_all): Call
2827         tui_delete_invisible_windows.
2828         * tui/tui-layout.c (show_layout): Call
2829         tui_delete_invisible_windows.
2830         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2831         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2832
2833 2019-08-13  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2836         tui_add_win_to_layout.
2837
2838 2019-08-13  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2841         * tui/tui-layout.c (tui_default_win_height): Now static.
2842
2843 2019-08-13  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2846         single switch.
2847         (show_source_disasm_command, show_source_or_disasm_and_command):
2848         Don't check current layout.
2849
2850 2019-08-13  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-wingeneral.c (make_all_visible): Remove.
2853         (tui_make_all_invisible): Simplify.
2854         * tui/tui-layout.c (tui_make_all_invisible): Move from
2855         tui-wingeneral.c; simplify.
2856         (show_layout): Hoist call to tui_make_all_invisible.
2857         (show_data): Don't call tui_make_all_invisible.
2858
2859 2019-08-13  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2862         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2863
2864 2019-08-13  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2867         tui-data.c.
2868         (show_source_disasm_command, show_data)
2869         (show_source_or_disasm_and_command): Don't use
2870         tui_set_current_layout_to.
2871         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2872         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2873         tui-layout.c.
2874         (tui_set_current_layout_to): Remove.
2875
2876 2019-08-13  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui-layout.c (tui_set_layout): Update.
2879         * tui/tui-data.h (struct tui_layout_def): Remove.
2880         (tui_layout_def): Don't declare.
2881         * tui/tui-data.c (layout_def): Remove.
2882         (tui_layout_def): Remove.
2883
2884 2019-08-13  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-winsource.h (struct tui_source_window_base)
2887         <clear_detail>: No longer "override".
2888         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2889         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2890         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2891         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2892         Remove.
2893         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2894
2895 2019-08-13  Tom Tromey  <tromey@adacore.com>
2896
2897         * tracepoint.c: Don't include readline.h or history.h.
2898
2899 2019-08-12  Tom Tromey  <tom@tromey.com>
2900
2901         * configure: Rebuild.
2902         * configure.ac: Check for readline 7.
2903         * NEWS: Mention readline 7 requirement.
2904         * README: Update.
2905
2906 2019-08-12  Tom Tromey  <tom@tromey.com>
2907
2908         * mingw-hdep.c (gdb_select): Remove readline hack.
2909
2910 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2911
2912         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2913         when the function fails.
2914
2915 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2916
2917         * s390-tdep.c (s390_type_align): New function.
2918         (s390_gdbarch_init): Set it as type_align gdbarch method.
2919
2920 2019-08-09  Tom de Vries  <tdevries@suse.de>
2921
2922         PR gdb/24591
2923         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2924         pc_low with relocation offset.
2925
2926 2019-08-07  Tom Tromey  <tromey@adacore.com>
2927
2928         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2929         (print_frame_args): Update.
2930         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2931         Update.
2932         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2933         * frame.h (struct frame_arg): Add initializers.
2934         <error>: Now a unique_xmalloc_ptr.
2935
2936 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2937
2938         * NEWS: Expand the Pointer Authentication entry.
2939         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2940         (aarch64_frame_unmask_lr): ... to this.
2941         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2942         Call aarch64_frame_unmask_lr.
2943         * frame.c (struct frame_info): Add "masked" variable.
2944         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2945         (fprint_frame): Check for masked pc.
2946         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2947         declarations.
2948         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2949         * stack.c (print_frame): Check for masked pc.
2950
2951 2019-08-06  Tom Tromey  <tom@tromey.com>
2952
2953         * stabsread.c (patch_block_stabs, read_one_struct_field)
2954         (read_enum_type): Use obstack_strndup.
2955         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2956         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2957         * dwarf2read.c (guess_full_die_structure_name)
2958         (anonymous_struct_prefix): Use obstack_strndup.
2959         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2960         * c-exp.y (yylex): Use obstack_strndup.
2961         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2962         (write_var_or_type): Use obstack_strndup.
2963
2964 2019-08-06  Tom Tromey  <tom@tromey.com>
2965
2966         * symfile.c (reread_symbols): Use obstack_strdup.
2967         * stabsread.c (read_type): Use obstack_strdup.
2968         * gdb_obstack.h (obstack_strdup): New overload.
2969         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2970         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2971         (dwarf2_canonicalize_name): Use obstack_strdup.
2972         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2973         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2974         Use obstack_strdup.
2975
2976 2019-08-06  Tom Tromey  <tom@tromey.com>
2977
2978         * gdb_obstack.h (obstack_strdup): Define.
2979         * gdb_obstack.c (obstack_strdup): Don't define.
2980
2981 2019-08-06  Tom Tromey  <tom@tromey.com>
2982
2983         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2984         obstack_strdup.
2985         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2986         obstack_strdup.
2987         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2988         * stabsread.c (common_block_start): Use obstack_strdup.
2989         * objfiles.c (set_objfile_main_name, objfile): Use
2990         obstack_strdup.
2991         * namespace.c (add_using_directive): Use obstack_strdup.
2992         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2993         * jit.c (finalize_symtab): Use obstack_strdup.
2994         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2995         (guess_partial_die_structure_name, partial_die_info::fixup)
2996         (dwarf2_name): Use obstack_strdup.
2997         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2998         obstack_strdup.
2999         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3000         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3001         obstack_strdup.
3002         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3003
3004 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3005
3006         * unittests/help-doc-selftests.c: New file.
3007         * Makefile.in: Add the new file.
3008
3009 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3010
3011         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3012         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3013         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3014         the trailing '.' is not output, and the first character is uppercased.
3015         (print_help_for_command): Update call to print_doc_line.
3016         (print_doc_of_command): Likewise.
3017         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3018         * cli/cli-option.c (append_indented_doc): Do not append newline.
3019         (build_help_option): Append newline after first appended_indented_doc
3020         only if a second call is done.
3021         (build_help): Append 2 new lines before each option, except the first
3022         one.
3023         * compile/compile.c (_initialize_compile): Add new lines after
3024         %OPTIONS%, when not at the end of the help.
3025         Change help doc or code
3026         producing the help doc to respect the invariants.
3027         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3028         Also removed the new line after 'Options:', as all other commands
3029         do not put an empty line between 'Options:' and the first option.
3030         * printcmd.c (_initialize_printcmd): Likewise.
3031         * stack.c (_initialize_stack): Likewise.
3032         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3033         incorrectly telling COMMAND is optional.
3034         * ada-lang.c (_initialize_ada_language): Change help doc or code
3035         producing the help doc to respect the invariants.
3036         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3037         * breakpoint.c (_initialize_breakpoint): Likewise.
3038         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3039         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3040         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3041         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3042         _initialize_cli_style): Likewise.
3043         * corelow.c (core_target_info): Likewise.
3044         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3045         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3046         * filesystem.c (_initialize_filesystem): Likewise.
3047         * frame.c (_initialize_frame): Likewise.
3048         * gnu-nat.c (add_task_commands): Likewise.
3049         * infcall.c (_initialize_infcall): Likewise.
3050         * infcmd.c (_initialize_infcmd): Likewise.
3051         * interps.c (_initialize_interpreter): Likewise.
3052         * language.c (_initialize_language): Likewise.
3053         * linux-fork.c (_initialize_linux_fork): Likewise.
3054         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3055         * maint.c (_initialize_maint_cmds): Likewise.
3056         * memattr.c (_initialize_mem): Likewise.
3057         * printcmd.c (_initialize_printcmd): Likewise.
3058         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3059         _RegEx): Likewise.
3060         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3061         * record-btrace.c (_initialize_record_btrace): Likewise.
3062         * record-full.c (_initialize_record_full): Likewise.
3063         * record.c (_initialize_record): Likewise.
3064         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3065         * regcache.c (_initialize_regcache): Likewise.
3066         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3067         _initialize_remote): Likewise.
3068         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3069         * serial.c (_initialize_serial): Likewise.
3070         * skip.c (_initialize_step_skip): Likewise.
3071         * source.c (_initialize_source): Likewise.
3072         * stack.c (_initialize_stack): Likewise.
3073         * symfile.c (_initialize_symfile): Likewise.
3074         * symtab.c (_initialize_symtab): Likewise.
3075         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3076         * top.c (init_main): Likewise.
3077         * tracefile-tfile.c (tfile_target_info): Likewise.
3078         * tracepoint.c (_initialize_tracepoint): Likewise.
3079         * tui/tui-win.c (_initialize_tui_win): Likewise.
3080         * utils.c (add_internal_problem_command): Likewise.
3081         * valprint.c (value_print_option_defs): Likewise.
3082
3083 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3084
3085         PR build/24886
3086         * configure.ac: Drop enable-libmcheck support.
3087         * configure, config.in: Rebuild.
3088         * libmcheck.m4: Remove.
3089         * acinclude.m4: Don't include it.
3090         * Makefile.in: Don't distribute it.
3091         * top.c (print_gdb_configuration): Don't mention it.
3092
3093 2019-08-06  Tom Tromey  <tom@tromey.com>
3094
3095         * utils.c (set_output_style): Sometimes pass stream to
3096         emit_style_escape.
3097         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3098         * record-btrace.c (btrace_insn_history): Update.
3099         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3100         method.
3101         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3102         Update initializers.
3103         <m_uiout>: New field.
3104         <m_di>: Move lower.
3105         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3106         Remove "uiout" parameter.
3107         (dump_insns): Update.
3108         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3109         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3110
3111 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3112
3113         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3114         (error_in_psymtab_expansion): Likewise.
3115         (lookup_symbol_via_quick_fns): Likewise.
3116         (basic_lookup_transparent_type_quick): Likewise.
3117         (basic_lookup_transparent_type_1): Likewise.
3118
3119 2019-08-06  Tom Tromey  <tromey@adacore.com>
3120
3121         * source.c (last_source_error): Now bool.
3122         (print_source_lines_base): Make "noprint" bool.  Only open
3123         source file when last_source_visited changes.
3124
3125 2019-08-06  Tom Tromey  <tromey@adacore.com>
3126
3127         * annotate.c (annotate_source_line): Use g_source_cache.
3128         * source-cache.c (source_cache::get_plain_source_lines): Change
3129         parameters.  Populate m_offset_cache.
3130         (source_cache::ensure): New method.
3131         (source_cache::get_line_charpos): New method.
3132         (extract_lines): Move lower.  Change parameters.
3133         (source_cache::get_source_lines): Move lower.
3134         * source-cache.h (class source_cache): Update comment.
3135         <get_line_charpos>: New method.
3136         <get_source_lines>: Update comment.
3137         <clear>: Clear m_offset_cache.
3138         <get_plain_source_lines>: Change parameters.
3139         <ensure>: New method
3140         <m_offset_cache>: New member.
3141         * source.c (forget_cached_source_info_for_objfile): Update.
3142         (info_source_command): Use g_source_cache.
3143         (find_source_lines, open_source_file_with_line_charpos): Remove.
3144         (print_source_lines_base, search_command_helper): Use g_source_cache.
3145         * source.h (open_source_file_with_line_charpos): Don't declare.
3146         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3147         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3148         Use g_source_cache.
3149
3150 2019-08-06  Tom Tromey  <tromey@adacore.com>
3151
3152         * source-cache.c (source_cache::get_plain_source_lines):
3153         Remove "first_line" and "last_line" parameters.
3154         (source_cache::get_source_lines): Cache plain text.
3155         * source-cache.h (class source_cache)
3156         <get_plain_source_lines>: Update.
3157
3158 2019-08-06  Tom Tromey  <tromey@adacore.com>
3159
3160         * source-cache.c (extract_lines): No longer a method.
3161         Changed type of parameter.  Include final newline.
3162         (selftests::extract_lines_test): New function.
3163         (_initialize_source_cache): Likewise.
3164         * source-cache.h (class source_cache)
3165         <extract_lines>: Don't declare.
3166
3167 2019-08-06  Tom Tromey  <tromey@adacore.com>
3168
3169         * breakpoint.c (init_breakpoint_sal): Update.
3170         (breakpoint): Update.
3171         * breakpoint.h (struct breakpoint) <filter>: Now a
3172         unique_xmalloc_ptr.
3173
3174 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3175
3176         * NEWS: Mention dictionary access on blocks.
3177         * python/py-block.c (blpy_getitem): New function.
3178         (block_object_as_mapping): New struct.
3179         (block_object_type): Use new struct for tp_as_mapping field.
3180
3181 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3182
3183         * objfiles.h (objfile): Add a comment describing partial symbols.
3184
3185 2019-08-05  Tom Tromey  <tromey@adacore.com>
3186
3187         * compile/compile.c (_initialize_compile): Use _(), not N_().
3188         * thread.c (_initialize_thread): Use _(), not N_().
3189         * stack.c (_initialize_stack): Use _(), not N_().
3190         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3191
3192 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3193
3194         * dwarf2read.c (struct dw2_symtab_iterator):
3195         <want_specific_block>: Remove.
3196         <block_index>: Change type to gdb::optional.
3197         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3198         change type of BLOCK_INDEX parameter to gdb::optional.
3199         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3200         (dw2_lookup_symbol): Don't pass argument for
3201         WANT_SPECIFIC_BLOCK.
3202         (dw2_expand_symtabs_for_function): Don't pass argument for
3203         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3204         (class dw2_debug_names_iterator)
3205         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3206         parameter, change BLOCK_INDEX type to gdb::optional.
3207         <m_want_specific_block>: Remove.
3208         <m_block_index>: Change type to gdb::optional.
3209         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3210         gdb::optional.  Re-write in function of gdb::optional.
3211         (dw2_debug_names_lookup_symbol): Don't pass argument for
3212         WANT_SPECIFIC_BLOCK.
3213         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3214         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3215         BLOCK_INDEX.
3216
3217 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3218
3219         * NEWS: Mention changes to "info sources" command.
3220
3221 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3222
3223         * symtab.c (filename_partial_match_opts): New struct type.
3224         (struct output_source_filename_data): New members
3225         regexp, c_regexp, partial_match.
3226         (output_source_filename): Use new members to decide to print file.
3227         (info_sources_option_defs): New variable.
3228         (make_info_sources_options_def_group, print_info_sources_header,
3229         info_sources_command_completer):
3230         New functions.
3231         (info_sources_command): Read new optional arguments.
3232         (_initialize_symtab): Update info sources help.
3233
3234 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3235
3236         * ada-lang.c (exception_support_info_v0): Renamed from...
3237         (default_exception_support_info): ... this.  Create new
3238         definition for v1.
3239         (ada_has_this_exception_support): Look up catch_handlers_sym.
3240         (ada_exception_support_info_sniffer): Try v0 after default.
3241
3242 2019-08-01  Tom Tromey  <tromey@adacore.com>
3243
3244         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3245         gdbarch.h.
3246
3247 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3248
3249         * s12z-tdep.c: Fix include path for s12z-opc.h.
3250
3251 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3252
3253         * NEWS: Require GNU make 3.82.
3254
3255 2019-07-16  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3258         declare.
3259
3260 2019-07-30  Tom Tromey  <tromey@adacore.com>
3261
3262         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3263
3264 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3265
3266         * printcmd.c (print_address_symbolic): Print negative offsets.
3267         (build_address_symbolic): Force signed arithmetic when computing
3268         offset.
3269
3270 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3271
3272         PR/24474: Add a function to lookup static variables.
3273         * NEWS: Mention this new function.
3274         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3275         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3276         * python/python.c (python_GdbMethods): Add new function.
3277
3278 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3279
3280         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3281         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3282         (objfpy_lookup_static_symbol): New function.
3283         (objfile_object_methods): Add new functions.
3284
3285 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3286
3287         * NEWS: Mention 'set|show print frame-info'.  Mention new
3288         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3289         backtrace argument.  Mention that python frame filtering code
3290         is now consistent with what 'backtrace' command prints.
3291
3292 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3293
3294         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3295         comments.
3296         (print_frame_info_auto, print_frame_info_source_line,
3297         print_frame_info_location, print_frame_info_source_and_location,
3298         print_frame_info_location_and_address, print_frame_info_short_location):
3299         New declarations.
3300         (struct frame_print_options): New member print_frame_info.
3301         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3302         * stack.h (get_user_print_what_frame_info): New declaration.
3303         (frame_show_address): New declaration.
3304         * stack.c (print_frame_arguments_choices): New value 'presence'.
3305         (print_frame_info_auto, print_frame_info_source_line,
3306         print_frame_info_location, print_frame_info_source_and_location,
3307         print_frame_info_location_and_address, print_frame_info_short_location,
3308         print_frame_info_choices, print_frame_info_print_what): New definitions.
3309         (print_frame_args): Only print dots for args if print frame-arguments
3310         is 'presence'.
3311         (frame_print_option_defs): New element for "frame-info".
3312         (get_user_print_what_frame_info): New function.
3313         (frame_show_address): Make non static.  Move comment to stack.h.
3314         (print_frame_info_to_print_what): New function.
3315         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3316         to decide what to print.
3317         (backtrace_command_1): Handle the new print_frame_arguments_presence
3318         value.
3319         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3320         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3321         (py_print_frame): In non-mi mode, use LOCATION as default for
3322         print_what, similarly to frame information printed directly by
3323         backtrace command. Handle frame-info user option in non MI mode.
3324
3325 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3326
3327         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3328         Add case for debugging 32-bit target on 64-bit host.  Revise
3329         comment.
3330
3331 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3332
3333         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3334         instead of find_function_entry_range_from_pc.
3335
3336 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3337
3338         * stack.c (find_frame_funname): Remove code which preferred
3339         minsym over symtab sym in "certain pathological cases".
3340
3341         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3342         parameter.  Change type of "do_demangle" to bool.
3343         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3344         Pass suitable "prefer_sym_over_minsym" flag to
3345         build_address_symbolic().  Don't output "+" for negative offsets.
3346         * printcmd.c (print_address_symbolic): Update invocation of
3347         build_address_symbolic to include a "prefer_sym_over_minsym"
3348         flag.
3349         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3350         Restrict cases in which use of minimal symbol is preferred to that
3351         of a found symbol.  Update comments.
3352
3353         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3354         for entry pc when entry pc is out of range for that FDE.
3355
3356 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3357
3358         PR gdb/24839:
3359         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3360         type.
3361
3362 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3363
3364         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3365         this function's Python signature.
3366
3367
3368 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3369
3370         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3371         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3372         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3373         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3374         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3375
3376
3377 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3378
3379         * h8300-tdep.c (h8300_register_name_common): New.
3380         h8300_register_name): Use h8300_register_name_common.
3381         (h8300s_register_name): Likewise.
3382         (h8300sx_register_name): Likewise.
3383         (h8300h_register_nam): New.
3384         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3385
3386
3387 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3388
3389         * arm-tdep.c (arm_skip_cmse_entry): New function.
3390         (arm_is_sgstubs_section): New function.
3391         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3392
3393 2019-07-22  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3396         Don't self-assign.
3397
3398 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3401         type_print.
3402
3403 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3406         so that GDB doesn't match any msymbols when searching in the
3407         TYPES_DOMAIN.
3408         (print_symbol_info): Print using typedef_print or type_print based
3409         on the type of the symbol.  Add updated FIXME comment moved from...
3410         (_initialize_symtab): ... move and update FIXME comment to above.
3411
3412 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3413
3414         * NEWS: Mention adding -q option to "info types".
3415         * symtab.c (struct info_types_options): New struct.
3416         (info_types_options_defs): New variable.
3417         (make_info_types_options_def_group): New function.
3418         (info_types_command): Use gdb::option framework to parse options.
3419         (info_types_command_completer): New function.
3420         (_initialize_symtab): Extend the help text on "info types" and
3421         register command completer.
3422
3423 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3424
3425         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3426         (lookup_symbol_in_objfile): Change int to block_enum and add a
3427         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3428
3429 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3430
3431         * MAINTAINERS (Write After Approval): Add self.
3432
3433 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3434
3435         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3436         instruction to the dummy code region.
3437
3438 2019-07-19  Tom Tromey  <tromey@adacore.com>
3439
3440         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3441         (ARGSUSED, PARAMS, __func__): Remove rules.
3442
3443 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3444
3445         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3446         * features/arm/arm-with-iwmmxt.c: Remove.
3447         * features/arm/arm-with-iwmmxt.xml: Remove.
3448         * features/arm/arm-with-m-fpa-layout.c: Remove.
3449         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3450         * features/arm/arm-with-m-vfp-d16.c: Remove.
3451         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3452         * features/arm/arm-with-m.c: Remove.
3453         * features/arm/arm-with-m.xml: Remove.
3454         * features/arm/arm-with-neon.c: Remove.
3455         * features/arm/arm-with-neon.xml: Remove.
3456         * features/arm/arm-with-vfpv2.c: Remove.
3457         * features/arm/arm-with-vfpv2.xml: Remove.
3458         * features/arm/arm-with-vfpv3.c: Remove.
3459         * features/arm/arm-with-vfpv3.xml: Remove.
3460
3461 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3462
3463         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3464
3465 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3466
3467         * arch/aarch32.c (aarch32_create_target_description): Create
3468         target descriptions using features.
3469         * arch/arm.c (arm_create_target_description)
3470         (arm_create_mprofile_target_description): Likewise.
3471         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3472
3473 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3474
3475         * Makefile.in: Add new files.
3476         * aarch32-tdep.c: New file.
3477         * aarch32-tdep.h: New file.
3478         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3479         Call aarch32_read_description.
3480         * arch/aarch32.c: New file.
3481         * arch/aarch32.h: New file.
3482         * arch/arm.c (arm_create_target_description)
3483         (arm_create_mprofile_target_description): New function.
3484         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3485         (arm_create_target_description)
3486         (arm_create_mprofile_target_description): New declaration.
3487         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3488         read_description functions.
3489         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3490         Likewise.
3491         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3492         * arm-tdep.c (tdesc_arm_list): New variable.
3493         (arm_register_g_packet_guesses): Call create description functions.
3494         (arm_read_description) (arm_read_mprofile_description): New
3495         function.
3496         * arm-tdep.h (arm_read_description)
3497         (arm_read_mprofile_description): Add declaration.
3498         * configure.tgt: Add new files.
3499
3500 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3501
3502         * top.c (new_ui_command): Open specified terminal just once.
3503
3504 2019-07-18  Tom Tromey  <tromey@adacore.com>
3505
3506         * symtab.c (main_name): Constify return type.
3507         * symfile.c (set_initial_language): Update.
3508         * symtab.h (main_name): Constify return type.
3509
3510 2019-07-17  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-winsource.c (tui_update_source_window)
3513         (tui_update_source_window_as_is)
3514         (tui_update_source_windows_with_line): Remove return.
3515         * tui/tui-disasm.c (tui_show_disassem)
3516         (tui_show_disassem_and_update_source): Remove return.
3517         * tui/tui.c (tui_reset): Remove return.
3518         * tui/tui-wingeneral.c
3519         (tui_check_and_display_highlight_if_needed): Remove return.
3520
3521 2019-07-17  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3524
3525 2019-07-17  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-winsource.h (struct tui_exec_info_window)
3528         (struct tui_source_window_base): Move from tui-data.h.
3529         * tui/tui-winsource.c: Move many method definitions from
3530         elsewhere.  Remove "structuring" comments.
3531         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3532         (tui_source_window_base::refresh_window): Move to
3533         tui-winsource.c.
3534         * tui/tui-win.c (tui_source_window_base::refresh_all)
3535         (tui_source_window_base::update_tab_width)
3536         (tui_source_window_base::set_new_height)
3537         (tui_source_window_base::do_make_visible_with_new_height): Move to
3538         tui-winsource.c.
3539         * tui/tui-source.h: Update.
3540         * tui/tui-source.c (tui_source_window_base::reset): Move to
3541         tui-winsource.c.
3542         * tui/tui-disasm.h: Update.
3543         * tui/tui-data.h (struct tui_exec_info_window): Move to
3544         tui-winsource.h.
3545         (struct tui_source_window_base): Likewise.
3546         * tui/tui-data.c (tui_source_window_base::clear_detail)
3547         (tui_source_window_base, ~tui_source_window_base): Move to
3548         tui-winsource.c.
3549
3550 2019-07-17  Tom Tromey  <tom@tromey.com>
3551
3552         * tui/tui-win.c (tui_resize_all)
3553         (tui_source_window_base::update_tab_width)
3554         (tui_adjust_win_heights): Update.
3555         (tui_win_info::make_invisible_and_set_new_height): Rename from
3556         make_invisible_and_set_new_height.
3557         * tui/tui-data.h (struct tui_win_info)
3558         <make_invisible_and_set_new_height>: New method.
3559
3560 2019-07-17  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui.c: Update.
3563         * tui/tui-source.h (struct tui_source_window): Move from
3564         tui-data.h.
3565         * tui/tui-layout.c: Update.
3566         * tui/tui-disasm.c: Update.
3567         * tui/tui-data.h (struct tui_source_window): Move to
3568         tui-source.h.
3569
3570 2019-07-17  Tom Tromey  <tom@tromey.com>
3571
3572         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3573         tui-data.h.
3574         * tui/tui-data.h (struct tui_disasm_window): Move to
3575         tui-disasm.h.
3576
3577 2019-07-17  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-regs.h (struct tui_data_item_window): Move from
3580         tui-data.h.
3581         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3582         * tui/tui-data.h (struct tui_data_item_window): Move to
3583         tui-regs.h.
3584         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3585
3586 2019-07-17  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui.c: Update.
3589         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3590         (tui_cmd_window::max_height): Move to tui-command.c.
3591         * tui/tui-layout.c: Update.
3592         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3593         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3594         tui-command.c.
3595         * tui/tui-command.h (struct tui_cmd_window): Move from
3596         tui-data.h.
3597         * tui/tui-command.c: Remove "structuring" comments.
3598         (tui_cmd_window::clear_detail)
3599         (tui_cmd_window::do_make_visible_with_new_height)
3600         (tui_cmd_window::max_height): Move from elsewhere.
3601
3602 2019-07-17  Tom Tromey  <tom@tromey.com>
3603
3604         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3605         Now static.
3606         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3607         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3608
3609 2019-07-17  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui.c: Update.
3612         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3613         tui-regs.c.
3614         * tui/tui-windata.h: Remove file.
3615         * tui/tui-windata.c: Remove file.
3616         * tui/tui-win.c (tui_data_window::set_new_height)
3617         (tui_data_window::do_make_visible_with_new_height): Move to
3618         tui-regs.c.
3619         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3620         * tui/tui-regs.c: Remove "structuring" comments.
3621         (tui_data_window::first_data_item_displayed)
3622         (tui_data_window::delete_data_content_windows)
3623         (tui_data_window::erase_data_content)
3624         (tui_data_window::display_all_data)
3625         (tui_data_window::refresh_all)
3626         (tui_data_window::do_scroll_vertical)
3627         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3628         (tui_data_window::do_make_visible_with_new_height)
3629         (tui_data_window::refresh_window): Move from elsewhere.
3630         (_initialize_tui_regs): Move to end of file.
3631         * tui/tui-layout.c: Update.
3632         * tui/tui-hooks.c: Update.
3633         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3634         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3635         tui-regs.c.
3636         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3637
3638 2019-07-17  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3641         seen.
3642
3643 2019-07-17  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-win.c (tui_source_window_base::set_new_height)
3646         (tui_source_window_base::do_make_visible_with_new_height): Use
3647         m_has_locator field directly.
3648         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3649         method.
3650         (struct tui_source_window_base) <has_locator>: Likewise.
3651
3652 2019-07-17  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3655         Don't declare.
3656         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3657         Remove.
3658         * tui/tui-win.c (tui_source_window_base::set_new_height)
3659         (tui_source_window_base::set_new_height)
3660         (make_invisible_and_set_new_height)
3661         (tui_source_window_base::do_make_visible_with_new_height)
3662         (tui_source_window_base::do_make_visible_with_new_height):
3663         Update.
3664         * tui/tui-layout.c (show_source_disasm_command, show_data)
3665         (show_source_or_disasm_and_command): Update.
3666         * tui/tui-layout.c (show_layout): Update.
3667
3668 2019-07-17  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-layout.c (make_data_window): Remove.
3671         (show_data): Unify creation and re-initialization cases.
3672
3673 2019-07-17  Tom Tromey  <tom@tromey.com>
3674
3675         * tui/tui-layout.c (make_source_window, make_disasm_window):
3676         Remove.
3677         (show_data): Unify creation and re-initialization cases.
3678
3679 2019-07-17  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-layout.c (make_command_window): Remove.
3682         (show_source_disasm_command, show_source_or_disasm_and_command):
3683         Unify creation and re-initialization cases.
3684
3685 2019-07-17  Tom Tromey  <tom@tromey.com>
3686
3687         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3688         creation and re-initialization cases.
3689
3690 2019-07-17  Tom Tromey  <tom@tromey.com>
3691
3692         * tui/tui-regs.c (tui_get_register): Return void.
3693
3694 2019-07-17  Tom Tromey  <tom@tromey.com>
3695
3696         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3697         Simplify.
3698
3699 2019-07-17  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3702         resetting.
3703
3704 2019-07-17  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3707         * tui/tui-regs.c (tui_reg_layout): New function.
3708         (tui_show_registers, tui_reg_command): Use it.
3709         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3710         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3711         parameters.
3712         (tui_layout_command): Remove.
3713
3714 2019-07-17  Tom Tromey  <tom@tromey.com>
3715
3716         * tui/tui-layout.h (tui/tui-layout): Return void.
3717         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3718
3719 2019-07-17  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-layout.c (show_source_disasm_command, show_data):
3722         Update.
3723         (reset_locator): Remove.
3724         (show_source_or_disasm_and_command): Update.
3725
3726 2019-07-17  Tom Tromey  <tom@tromey.com>
3727
3728         * tui/tui-source.c (tui_source_window_base::reset): Remove
3729         win_type parameter.
3730         * tui/tui-layout.c (make_command_window, make_source_window)
3731         (make_disasm_window, make_data_window)
3732         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3733         (reset_locator, show_source_or_disasm_and_command): Update.
3734         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3735         win_type parameter.
3736         (struct tui_source_window_base) <reset>: Likewise.
3737
3738 2019-07-17  Tom Tromey  <tom@tromey.com>
3739
3740         * tui/tui-layout.c (show_source_disasm_command): Use
3741         reset_locator.
3742         (reset_locator): New function.
3743         (init_and_make_win): Remove.
3744         (show_source_or_disasm_and_command): Use reset_locator.
3745
3746 2019-07-17  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3749         condition.
3750         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3751         Remove condition.
3752         * tui/tui-source.c (tui_source_window_base::reset): New method.
3753         * tui/tui-layout.c (make_command_window): Don't call
3754         init_and_make_win.
3755         (make_source_window, make_disasm_window): Don't call
3756         make_source_or_disasm_window.
3757         (make_data_window): Don't call init_and_make_win.  Change calling
3758         convention.
3759         (show_source_disasm_command, show_data): Simplify.
3760         (make_source_or_disasm_window): Remove.
3761         (show_source_or_disasm_and_command): Simplify.
3762         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3763         (struct tui_source_window_base) <reset>: Likewise.
3764         <execution_info>: Remove initializer.
3765         * tui/tui-data.c (tui_source_window_base): Initialize
3766         execution_info.
3767
3768 2019-07-17  Tom Tromey  <tom@tromey.com>
3769
3770         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3771         variable.
3772
3773 2019-07-17  Tom Tromey  <tom@tromey.com>
3774
3775         * tui/tui.c (tui_rl_other_window): Update.
3776         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3777         superclass method first.  Always iterate over regs_content.
3778         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3779         method.
3780         * tui/tui-win.c (tui_set_focus_command): Update.
3781
3782 2019-07-17  Tom Tromey  <tom@tromey.com>
3783
3784         * tui/tui-win.c (tui_set_focus_command): Rename from
3785         tui_set_focus.  Call tui_enable.
3786         (tui_set_focus_command): Remove.
3787
3788 2019-07-17  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3791         refresh_window.
3792         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3793         touchwin.
3794         (tui_data_window::refresh_window): Call refresh_window on data
3795         items.  Always call superclass refresh_window.
3796         (tui_win_info::refresh): Remove.
3797         (tui_source_window_base::refresh_window): Update.
3798         (tui_refresh_all): Update.
3799         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3800         refresh_window.
3801         (show_source_or_disasm_and_command): Likewise.
3802         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3803         (struct tui_source_window_base) <refresh>: Likewise.
3804
3805 2019-07-17  Tom Tromey  <tom@tromey.com>
3806
3807         * tui/tui-winsource.c (tui_clear_source_content)
3808         (tui_show_source_content): Update.
3809         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3810         whether content is empty.
3811         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3812         Remove.
3813
3814 2019-07-17  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3817         window's contents.
3818         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3819         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3820
3821 2019-07-17  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3824         (struct tui_data_item_window): Update.
3825
3826 2019-07-17  Tom Tromey  <tom@tromey.com>
3827
3828         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3829         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3830         defines.
3831
3832 2019-07-17  Tom Tromey  <tom@tromey.com>
3833
3834         * tui/tui-winsource.h (tui_erase_source_content)
3835         (tui_clear_source_content): Remove "display_prompt" parameter.
3836         * tui/tui-winsource.c (tui_update_source_window_as_is)
3837         (tui_update_source_windows_with_addr): Update.
3838         (tui_clear_source_content): Remove "display_prompt" parameter.
3839         (tui_erase_source_content): Likewise.  Simplify.
3840         (tui_show_source_content): Update.
3841         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3842         * tui/tui-stack.c (tui_show_frame_info): Update.
3843         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3844         Remove defines.
3845
3846 2019-07-17  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3849         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3850         parameter.
3851         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3852         parameter.
3853
3854 2019-07-17  Tom Tromey  <tom@tromey.com>
3855
3856         * tui/tui-winsource.c (tui_clear_source_content)
3857         (tui_show_source_content, tui_show_exec_info_content)
3858         (tui_clear_exec_info_content): Update.
3859         * tui/tui-stack.c (tui_show_locator_content): Update.
3860         (tui_show_frame_info): Update.
3861         * tui/tui-source.h (tui_source_window): Don't declare.
3862         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3863         from tui_source_is_displayed.
3864         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3865         Remove field.
3866         (struct tui_source_window_base) <content_in_use>: New field.  Now
3867         bool.
3868         (struct tui_source_window) <showing_source_p>: New method.
3869         (TUI_SRC_WIN): Change cast.
3870         * tui/tui-data.c (tui_initialize_static_data): Update.
3871
3872 2019-07-17  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3875         location_matches_p.
3876         * tui/tui-source.c (tui_source_window::location_matches_p): New
3877         method.
3878         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3879         method.
3880         * tui/tui-data.h (struct tui_source_window_base)
3881         <location_matches_p>: New method.
3882         (struct tui_source_window, struct tui_disasm_window)
3883         <location_matches_p>: Likewise.
3884
3885 2019-07-17  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-win.c (tui_set_win_height_command): Rename from
3888         tui_set_win_height.
3889         (tui_set_win_height_command): Remove.
3890
3891 2019-07-17  Tom Tromey  <tom@tromey.com>
3892
3893         * tui/tui-source.c (tui_source_window): New constructor.  Add
3894         observer.
3895         (~tui_source_window): New destructor.
3896         (tui_source_window::style_changed): New method.
3897         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3898         (tui_attach_detach_observers): Update.
3899         * tui/tui-data.h (struct tui_source_window): Make constructor not
3900         inline.  Add destructor.
3901         (struct tui_source_window) <style_changed>: New method.
3902         <m_observable>: New member.
3903
3904 2019-07-17  Tom Tromey  <tom@tromey.com>
3905
3906         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3907         * tui/tui-win.c (tui_resize_all): Fix typo.
3908
3909 2019-07-17  Tom Tromey  <tom@tromey.com>
3910
3911         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3912         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3913         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3914         * tui/tui-win.c (window_name_completer): Use foreach.
3915         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3916         (update_tab_width): Likewise.
3917         * tui/tui-layout.c (show_layout): Update.
3918         * tui/tui-data.h (class tui_window_iterator): New.
3919         (struct all_tui_windows): New.
3920         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3921
3922 2019-07-17  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3925         parameter.  Don't reference globals.
3926         (tui_reg_command): Update.
3927
3928 2019-07-17  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-regs.c (tui_show_registers): Simplify.
3931
3932 2019-07-17  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-regs.c (tui_show_registers): Update.
3935         (tui_show_register_group): Add win_info parameter.
3936
3937 2019-07-17  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3940         Rename from tui_display_reg_element_at_line.
3941         (tui_data_window::display_registers_from_line): Update.
3942         * tui/tui-data.h (struct tui_data_window)
3943         <display_reg_element_at_line>: New method.
3944
3945 2019-07-17  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-regs.h (tui_display_registers_from)
3948         (tui_display_registers_from_line): Don't declare.
3949         * tui/tui-windata.c (tui_data_window::display_all_data)
3950         (tui_data_window::refresh_all)
3951         (tui_data_window::do_scroll_vertical): Update.
3952         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3953         from tui_display_registers_from.
3954         (tui_display_reg_element_at_line): Update.
3955         (tui_data_window::display_registers_from_line): Rename from
3956         tui_display_registers_from_line.
3957         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3958         display_registers_from_line>: New methods.
3959
3960 2019-07-17  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3963         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3964         from tui_erase_data_content.
3965         (tui_data_window::display_all_data)
3966         (tui_data_window::refresh_all)
3967         (tui_data_window::do_scroll_vertical): Update.
3968         * tui/tui-regs.c (tui_show_registers): Update.
3969         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3970         New method.
3971
3972 2019-07-17  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3975         declare.
3976         * tui/tui-windata.c
3977         (tui_data_window::delete_data_content_windows): Rename from
3978         tui_delete_data_content_windows.
3979         (tui_data_window::display_all_data)
3980         (tui_data_window::do_scroll_vertical): Update.
3981         * tui/tui-data.h (struct tui_data_window)
3982         <delete_data_content_windows>: New method.
3983
3984 2019-07-17  Tom Tromey  <tom@tromey.com>
3985
3986         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3987         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3988
3989 2019-07-17  Tom Tromey  <tom@tromey.com>
3990
3991         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3992         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3993         from tui_display_all_data.
3994         * tui/tui-win.c
3995         (tui_data_window::do_make_visible_with_new_height): Update.
3996         * tui/tui-regs.c (tui_show_registers): Update.
3997         * tui/tui-layout.c (tui_set_layout): Update.
3998         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3999         method.
4000
4001 2019-07-17  Tom Tromey  <tom@tromey.com>
4002
4003         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4004         * tui/tui-windata.c (tui_display_data_from): Remove.
4005         (tui_data_window::refresh_all): Update.
4006
4007 2019-07-17  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4010         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4011         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4012         tui_display_registers_from_line.
4013         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4014         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4015         "force_display" parameter.
4016
4017 2019-07-17  Tom Tromey  <tom@tromey.com>
4018
4019         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4020         declare.
4021         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4022         Rename from tui_first_reg_element_no_inline.
4023         (tui_display_reg_element_at_line)
4024         (tui_display_registers_from_line): Update.
4025         * tui/tui-data.h (struct tui_data_window)
4026         <first_reg_element_no_inline>: New method.
4027
4028 2019-07-17  Tom Tromey  <tom@tromey.com>
4029
4030         * tui/tui-windata.c (tui_display_data_from)
4031         (tui_data_window::do_scroll_vertical): Update.
4032         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4033         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4034         Rename from tui_line_from_reg_element_no.
4035         (tui_display_registers_from_line): Update.
4036         * tui/tui-data.h (struct tui_data_window)
4037         <line_from_reg_element_no>: New method.
4038
4039 2019-07-17  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4042         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4043         tui_last_regs_line_no.
4044         (tui_display_reg_element_at_line)
4045         (tui_display_registers_from_line): Update.
4046         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4047         method.
4048
4049 2019-07-17  Tom Tromey  <tom@tromey.com>
4050
4051         PR tui/24722:
4052         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4053         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4054         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4055         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4056         (tui_update_breakpoint_info): Likewise.
4057         * tui/tui-hooks.c (tui_event_create_breakpoint)
4058         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4059         Update.
4060
4061 2019-07-17  Tom Tromey  <tom@tromey.com>
4062
4063         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4064
4065 2019-07-17  Tom Tromey  <tom@tromey.com>
4066
4067         * tui/tui-winsource.c (tui_update_source_window_as_is)
4068         (tui_update_source_windows_with_addr): Update.
4069         * tui/tui-source.h (tui_set_source_content)
4070         (tui_show_symtab_source): Add "win_info" parameter.
4071         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4072         parameter.
4073         (tui_show_symtab_source): Likewise.
4074
4075 2019-07-17  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-wingeneral.c
4078         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4079
4080 2019-07-17  Tom Tromey  <tom@tromey.com>
4081
4082         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4083         (struct tui_cmd_window) <can_scroll>: New method.
4084         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4085         method.
4086
4087 2019-07-17  Tom Tromey  <tromey@adacore.com>
4088
4089         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4090         do_field_signed>: Rename.  Change type of "value".
4091         * ui-out.c (ui_out::field_signed): Rename from field_int.
4092         Change type of "value".
4093         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4094         type of "value".
4095         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4096         do_field_int.  Change type of "value".
4097         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4098         do_field_int.  Change type of "value".
4099         * tracepoint.c (trace_status_mi, tfind_1)
4100         (print_one_static_tracepoint_marker): Update.
4101         * thread.c (print_thread_info_1, print_selected_thread_frame):
4102         Update.
4103         * stack.c (print_frame, print_frame_info): Update.
4104         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4105         Update.
4106         * source.c (print_source_lines_base): Update.
4107         * skip.c (info_skip_command): Update.
4108         * record-btrace.c (btrace_ui_out_decode_error)
4109         (btrace_call_history_src_line): Update.
4110         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4111         Update.
4112         * progspace.c (print_program_space): Update.
4113         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4114         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4115         do_field_int.  Change type of "value".
4116         * mi/mi-out.c (mi_ui_out::do_table_begin)
4117         (mi_ui_out::do_table_header): Update.
4118         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4119         type of "value".
4120         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4121         (mi_cmd_data_list_changed_registers, output_register)
4122         (mi_cmd_data_read_memory, mi_load_progress)
4123         (mi_cmd_trace_frame_collected): Update.
4124         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4125         Update.
4126         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4127         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4128         (mi_cmd_var_list_children, varobj_update_one): Update.
4129         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4130         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4131         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4132         * inferior.c (print_inferior): Update.
4133         * gdb_bfd.c (print_one_bfd): Update.
4134         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4135         Update.
4136         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4137         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4138         do_field_int.  Change type of "value".
4139         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4140         do_field_int.  Change type of "value".
4141         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4142         (print_one_breakpoint_location, print_it_catch_fork)
4143         (print_one_catch_fork, print_it_catch_vfork)
4144         (print_one_catch_vfork, print_it_catch_solib)
4145         (print_it_catch_exec, print_it_ranged_breakpoint)
4146         (print_mention_watchpoint, print_mention_masked_watchpoint)
4147         (bkpt_print_it, update_static_tracepoint): Update.
4148         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4149         * break-catch-syscall.c (print_it_catch_syscall): Update.
4150         * ada-tasks.c (print_ada_task_info): Update.
4151         * ada-lang.c (print_it_exception, print_mention_exception):
4152         Update.
4153
4154 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4155
4156         PR breakpoints/24541
4157         * gdbarch.c: Regenerate.
4158         * gdbarch.h: Regenerate.
4159         * gdbarch.sh: Adjust return type and parameter types for
4160         'stap_adjust_register'.
4161         (i386_stap_adjust_register): Adjust signature and return new
4162         register name.
4163         * stap-probe.c (stap_parse_register_operand): Adjust use of
4164         'gdbarch_stap_adjust_register'.
4165
4166 2019-07-17  Tom Tromey  <tromey@adacore.com>
4167
4168         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4169         declare VEC.
4170         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4171         std::vector.
4172         (struct s390_process_info): Add initializers.
4173         (s390_add_process): Use new.
4174         (s390_linux_nat_target::low_forget_process): Use delete.
4175         (s390_linux_nat_target::low_new_fork)
4176         (s390_linux_nat_target::stopped_by_watchpoint)
4177         (s390_linux_nat_target::low_prepare_to_resume)
4178         (s390_linux_nat_target::insert_watchpoint)
4179         (s390_linux_nat_target::insert_hw_breakpoint)
4180         (s390_linux_nat_target::remove_watchpoint)
4181         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4182
4183 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4184
4185         * aarch64-fbsd-nat.c: Include regcache.h.
4186         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4187         argument.
4188         (aarch64_fbsd_nat_target::fetch_registers)
4189         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4190         variable.
4191         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4192
4193 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4194
4195         * fbsd-nat.c: Include gdbarch.h.
4196
4197 2019-07-15  Tom Tromey  <tromey@adacore.com>
4198
4199         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4200
4201 2019-07-15  Tom Tromey  <tromey@adacore.com>
4202
4203         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4204         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4205         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4206         * cli-out.c (cli_ui_out::do_field_int): New method.
4207         * ui-out.c (ui_out::field_unsigned): New method.
4208         * symfile.c (generic_load): Use field_unsigned.
4209         (print_transfer_performance): Likewise.
4210         * record-btrace.c (ui_out_field_uint): Remove.
4211         (btrace_call_history_insn_range, btrace_call_history): Use
4212         field_unsigned.
4213         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4214         field_unsigned.
4215         * ui-out.h (class ui_out) <field_unsigned>: New method.
4216         <do_field_unsigned>: Likewise.
4217
4218 2019-07-15  Tom Tromey  <tromey@adacore.com>
4219
4220         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4221         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4222         * target.c (flash_erase_command): Use field_string.
4223         * infrun.c (print_signal_received_reason): Use field_string.
4224         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4225         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4226         field_string.
4227         * ada-tasks.c (print_ada_task_info): Use field_string.
4228
4229 2019-07-15  Tom Tromey  <tromey@adacore.com>
4230
4231         * target.c (flash_erase_command): Use field_core_addr.
4232         * symfile.c (generic_load): Use field_core_addr.
4233         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4234         Use field_core_addr.
4235         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4236         field_core_addr.
4237
4238 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4239
4240         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4241         value if its desired type is smaller than a CORE_ADDR and signed.
4242
4243 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4246         of changes to field names, and use new is_reference field to
4247         decide if a property is a reference or not.
4248         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4249         field.
4250         (struct dwarf2_property_baton): Update header comment, rename
4251         'referenced_type' to 'property_type' and update comments.
4252         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4253         default property type, store in property baton, update to take
4254         accound of renamed field.
4255         (read_func_scope): Update call to attr_to_dynamic_prop.
4256         (read_array_type): Likewise.
4257         (dwarf2_per_cu_addr_sized_int_type): New function.
4258         (read_subrange_index_type): Move type finding code to
4259         dwarf2_per_cu_addr_sized_int_type.
4260         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4261         (dwarf2_per_cu_addr_type): New function.
4262         (set_die_type): Update calls to attr_to_dynamic_prop.
4263
4264 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * dwarf2read.c (read_subrange_index_type): New function.
4267         (read_subrange_type): Move code into new function and call it.
4268         * gdbtypes.c (create_range_type): Add some asserts.
4269
4270 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4273         update return statements.
4274         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4275         declaration, and update comment to match.
4276         * gdbtypes.c (resolve_dynamic_array): Update call to
4277         dwarf2_evaluate_property to match new return type.
4278
4279 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         * valarith.c (value_subscripted_rvalue): Change lowerbound
4282         parameter type from int to LONGEST.
4283         * value.h (value_subscripted_rvalue): Likewise in declaration.
4284
4285 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * cli/cli-utils.c (info_print_command_completer): New function.
4288         * cli/cli-utils.h: Add 'completer.h' include, and forward
4289         declaration for 'struct cmd_list_element'.
4290         (info_print_command_completer): Declare.
4291         * stack.c (_initialize_stack): Add completer for 'info locals' and
4292         'info args'.
4293         * symtab.c (_initialize_symtab): Add completer for 'info
4294         variables' and 'info functions'.
4295         * NEWS: Mention completion for additional info commands.
4296
4297 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4298
4299         * cli/cli-utils.c (extract_info_print_args): Delete.
4300         (extract_arg_maybe_quoted): Delete.
4301         (info_print_options_defs): New variable.
4302         (make_info_print_options_def_group): New function.
4303         (extract_info_print_options): Define new function.
4304         * cli/cli-utils.h (extract_info_print_args): Delete.
4305         (struct info_print_options): New structure.
4306         (extract_info_print_options): Declare new function.
4307         * stack.c (info_locals_command): Update to use new
4308         extract_info_print_options, also add a header comment.
4309         (info_args_command): Likewise.
4310         * symtab.c (info_variables_command): Likewise.
4311         (info_functions_command): Likewise.
4312
4313 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4314
4315         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4316         to extract string arguments.
4317         * common/common-utils.c (extract_string_maybe_quoted): New function.
4318         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4319
4320 2019-07-11  Tom Tromey  <tromey@adacore.com>
4321
4322         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4323         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4324         * top.h (gdbinit): Don't declare.
4325         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4326         into...
4327         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4328         * top.c (gdb_init): Don't call init_cli_cmds.
4329         (gdbinit): Remove.
4330         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4331
4332 2019-07-11  Tom Tromey  <tromey@adacore.com>
4333
4334         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4335         after it has been moved.
4336
4337 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4338
4339         * valops.c (value_must_coerce_to_target): Change return type to
4340         bool.
4341         * value.h (value_must_coerce_to_target): Likewise.
4342
4343 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4344
4345         * breakpoint.c (is_hardware_watchpoint): Remove
4346         forward-declaration.
4347         (is_masked_watchpoint): Change return type to bool.
4348         (is_tracepoint): Likewise.
4349         (is_breakpoint): Likewise.
4350         (is_hardware_watchpoint): Likewise.
4351         (is_watchpoint): Likewise.
4352         (is_no_memory_software_watchpoint): Likewise.
4353         (is_catchpoint): Likewise.
4354         (breakpoint_1): Make FILTER parameter's return type bool.
4355         is_masked_watchpoint): Change return type to bool.
4356         (save_breakpoints): Make FILTER parameter's return type bool.
4357         * breakpoint.h (is_breakpoint): Change return type to bool.
4358         (is_watchpoint): Likewise.
4359         (is_catchpoint): Likewise.
4360         (is_tracepoint): Likewise.
4361
4362 2019-07-10  Tom Tromey  <tom@tromey.com>
4363
4364         * defs.h: Don't include gdbarch.h.
4365         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4366         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4367         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4368         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4369         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4370         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4371         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4372         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4373         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4374         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4375         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4376         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4377         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4378         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4379         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4380         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4381         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4382         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4383         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4384         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4385         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4386         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4387         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4388         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4389         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4390         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4391         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4392
4393 2019-07-10  Tom Tromey  <tromey@adacore.com>
4394
4395         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4396         * breakpoint.c (init_ada_exception_breakpoint): Register as
4397         bp_catchpoint.
4398         (print_one_breakpoint_location, print_one_breakpoint): Use
4399         is_ada_exception_catchpoint.
4400         * ada-lang.c (class ada_catchpoint_location): Pass
4401         bp_loc_software_breakpoint to bp_location constructor.
4402         (is_ada_exception_catchpoint): New function.
4403
4404 2019-07-10  Tom Tromey  <tromey@adacore.com>
4405
4406         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4407         VEC.
4408         (struct arm_exidx_entry): New method operator<.
4409         (struct arm_exidx_data) <section_maps>: Change type.
4410         (arm_exidx_data_free): Remove.
4411         (arm_exidx_data_key): Change type.  Move lower.
4412         (arm_exidx_new_objfile): Update.
4413         (arm_compare_exidx_entries): Remove.
4414         (arm_find_exidx_entry, _initialize_arm_tdep)
4415
4416 2019-07-10  Tom Tromey  <tromey@adacore.com>
4417
4418         * solib-spu.c (ocl_program_data_key): Change type.
4419         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4420         Update.
4421
4422 2019-07-10  Tom Tromey  <tromey@adacore.com>
4423
4424         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4425         (struct solib_aix_inferior_data) <library_list>: Change type.
4426         (solib_aix_inferior_data_handle): Change type.
4427         (get_solib_aix_inferior_data): Update.
4428         (solib_aix_free_library_list): Remove.
4429         (library_list_start_library): Update.
4430         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4431         return type.
4432         (solib_aix_get_library_list)
4433         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4434         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4435
4436 2019-07-10  Tom Tromey  <tromey@adacore.com>
4437
4438         * solib-dsbt.c (struct dsbt_info): Add initializers.
4439         (solib_dsbt_pspace_data): Change type.
4440         (dsbt_pspace_data_cleanup): Remove.
4441         (get_dsbt_info, _initialize_dsbt_solib): Update.
4442
4443 2019-07-10  Tom Tromey  <tromey@adacore.com>
4444
4445         * spu-tdep.c (spu_overlay_data): Change type.
4446         (spu_get_overlay_table, spu_overlay_new_objfile)
4447         (_initialize_spu_tdep): Update.
4448
4449 2019-07-10  Tom Tromey  <tromey@adacore.com>
4450
4451         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4452         destructor.
4453         (dbx_objfile_data_key): Change type and declare later.
4454         (DBX_SYMFILE_INFO): Rewrite.
4455         * dbxread.c (dbx_objfile_data_key): Change type.
4456         (dbx_symfile_init): Update.
4457         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4458         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4459         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4460
4461 2019-07-10  Tom Tromey  <tromey@adacore.com>
4462
4463         * jit.c (jit_program_space_key): Change type.  Move lower.
4464         (get_jit_program_space_data): Update.
4465         (jit_program_space_data_cleanup): Remove.
4466         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4467         Update.
4468         (struct jit_program_space_data): Add initializers.
4469
4470 2019-07-10  Tom Tromey  <tromey@adacore.com>
4471
4472         * solib-darwin.c (struct darwin_info): Add initializers.
4473         (solib_darwin_pspace_data): Change type.
4474         (darwin_pspace_data_cleanup): Remove.
4475         (get_darwin_info, _initialize_darwin_solib): Update.
4476
4477 2019-07-10  Tom Tromey  <tromey@adacore.com>
4478
4479         * remote-sim.c (struct sim_inferior_data): Add initializers,
4480         constructor, and destructor.
4481         (sim_inferior_data_key): Change type.  Move lower.
4482         (check_for_duplicate_sim_descriptor): Update.
4483         (get_sim_inferior_data): Use new.  Update.
4484         (~sim_inferior_data_cleanup): Rename from
4485         sim_inferior_data_cleanup.  Simplify.
4486         (gdbsim_close_inferior, simulator_command)
4487         (sim_command_completer, _initialize_remote_sim): Update.
4488         (next_pid, INITIAL_PID): Move earlier.
4489
4490 2019-07-10  Tom Tromey  <tromey@adacore.com>
4491
4492         * python/python-internal.h (create_thread_object): Return
4493         gdbpy_ref.
4494         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4495         * python/py-inferior.c (struct threadlist_entry): Add
4496         constructor.
4497         <thread_obj>: Now a gdbpy_ref.
4498         (thread_to_thread_object): Update.
4499         (add_thread_object): Use new.
4500         (delete_thread_object): Use delete.
4501         (infpy_threads): Update.
4502         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4503         GIL.
4504
4505 2019-07-10  Tom Tromey  <tromey@adacore.com>
4506
4507         * valops.c (value_cast): Specialize error message for Ada.
4508
4509 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4510
4511         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4512
4513 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4514
4515         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4516         bpstat_should_step): Return bool, adjust comments.
4517         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4518         bpstat_should_step): Likewise.
4519
4520 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4521
4522         * features/Makefile: Use feature target descriptions for Arm.
4523         * features/arm/arm-core.c: Generate new file.
4524         * features/arm/arm-fpa.c: Likewise.
4525         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4526         * features/arm/arm-m-profile.c: Likewise.
4527         * features/arm/arm-vfpv2.c: Likewise.
4528         * features/arm/arm-vfpv3.c: Likewise.
4529         * features/arm/xscale-iwmmxt.c: Likewise.
4530         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4531
4532 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4533
4534         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4535         ptrace earlier.
4536
4537 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4538
4539         * features/aarch64-pauth.c: Regenerate.
4540
4541 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4542
4543         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4544         bool.
4545         (bpstat_what): Use false instead of 0.
4546
4547 2019-07-09  Pedro Alves  <palves@redhat.com>
4548
4549         * break-catch-throw.c (is_exception_catchpoint): New.
4550         * breakpoint.c (print_one_breakpoint_location): New parameter
4551         'raw_loc'.  Handle it.  Use
4552         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4553         looking at the breakpoint's type.
4554         (print_one_breakpoint): If handling "maint info breakpoints", also
4555         print locations of exception catchpoints.
4556         * breakpoint.h (is_exception_catchpoint): Declare.
4557
4558 2019-07-09  Pedro Alves  <palves@redhat.com>
4559
4560         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4561         "addr" field.
4562         (allocate_location_exception_catchpoint): New.
4563         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4564         (initialize_throw_catchpoint_ops): Install
4565         allocate_location_exception_catchpoint as allocate_location
4566         method.
4567         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4568         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4569         bp_loc_other.
4570         (breakpoint_address_is_meaningful): Delete.
4571         (bl_address_is_meaningful): New.
4572         (breakpoint_locations_match): Adjust comment.
4573         (bp_location_from_bp_type): New, factored out of...
4574         (bp_location::bp_location(breakpoint *)): ... this.
4575         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4576         factored out of...
4577         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4578         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4579         breakpoint_address_is_meaningful.
4580         (bp_locations_compare): Adjust comment.
4581         (update_global_location_list): Use bl_address_is_meaningful
4582         instead of breakpoint_address_is_meaningful.
4583         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4584         explicit.
4585         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4586         * python/py-breakpoint.c (bppy_get_location): No longer check
4587         whether location is null.
4588
4589 2019-07-09  Pedro Alves  <palves@redhat.com>
4590
4591         PR c++/15468
4592         * breakpoint.c (print_one_breakpoint_location): Remove
4593         single-location assert.
4594
4595 2019-07-09  Tom Tromey  <tom@tromey.com>
4596
4597         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4598         * configure: Rebuild.
4599         * configure.ac: Change common to gdbsupport.
4600         * gdbsupport: Rename from common.
4601         * acinclude.m4: Change common to gdbsupport.
4602         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4603         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4604         gdbsupport.
4605         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4606         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4607         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4608         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4609         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4610         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4611         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4612         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4613         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4614         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4615         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4616         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4617         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4618         coff-pe-read.c, command.h, compile/compile-c-support.c,
4619         compile/compile-c.h, compile/compile-cplus-symbols.c,
4620         compile/compile-cplus-types.c, compile/compile-cplus.h,
4621         compile/compile-loc2c.c, compile/compile.c, completer.c,
4622         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4623         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4624         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4625         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4626         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4627         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4628         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4629         features/aarch64-core.c, features/aarch64-fpu.c,
4630         features/aarch64-pauth.c, features/aarch64-sve.c,
4631         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4632         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4633         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4634         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4635         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4636         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4637         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4638         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4639         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4640         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4641         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4642         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4643         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4644         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4645         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4646         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4647         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4648         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4649         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4650         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4651         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4652         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4653         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4654         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4655         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4656         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4657         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4658         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4659         minsyms.c, mips-linux-tdep.c, namespace.h,
4660         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4661         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4662         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4663         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4664         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4665         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4666         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4667         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4668         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4669         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4670         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4671         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4672         procfs.c, producer.c, progspace.h, psymtab.h,
4673         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4674         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4675         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4676         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4677         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4678         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4679         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4680         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4681         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4682         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4683         target-memory.c, target.c, target.h, target/waitstatus.c,
4684         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4685         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4686         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4687         unittests/array-view-selftests.c,
4688         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4689         unittests/common-utils-selftests.c,
4690         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4691         unittests/format_pieces-selftests.c,
4692         unittests/function-view-selftests.c,
4693         unittests/lookup_name_info-selftests.c,
4694         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4695         unittests/mkdir-recursive-selftests.c,
4696         unittests/observable-selftests.c,
4697         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4698         unittests/parse-connection-spec-selftests.c,
4699         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4700         unittests/scoped_fd-selftests.c,
4701         unittests/scoped_mmap-selftests.c,
4702         unittests/scoped_restore-selftests.c,
4703         unittests/string_view-selftests.c, unittests/style-selftests.c,
4704         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4705         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4706         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4707         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4708         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4709         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4710
4711 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4712
4713         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4714         bool value.
4715         (decode_digits_ordinary): Set explicit_line field in sal.
4716         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4717         symtab_and_line that was set on an explicit line number in
4718         assembler code.  Do always update the recorded symtab and line if
4719         we do skip the prologue.
4720
4721 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * breakpoint.c (set_breakpoint_location_function): Remove
4724         explicit_loc parameter.
4725         (momentary_breakpoint_from_master): Update call to
4726         set_breakpoint_location_function.
4727         (add_location_to_breakpoint): Likewise.
4728
4729 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4732         required features based on default bfd type when no specific bfd
4733         is present.
4734
4735 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4736
4737         * NEWS: Mention that GDB printf and eval commands can now print
4738         C-style and Ada-style convenience var strings without
4739         calling the inferior.
4740         * printcmd.c (printf_c_string): Locally print GDB internal var
4741         instead of transiting via the inferior.
4742         (printf_wide_c_string): Likewise.
4743
4744 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4745
4746         PR breakpoints/25011
4747         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4748
4749 2019-07-04  Tom Tromey  <tom@tromey.com>
4750
4751         PR tui/24724:
4752         * tui/tui-winsource.c (tui_clear_source_content): Update.
4753         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4754         (tui_update_breakpoint_info): Update.
4755         (tui_set_exec_info_content): Update.
4756         * tui/tui-source.c (tui_set_source_content_nil): Update.
4757         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4758         has_break.
4759         * tui/tui-data.h (enum tui_bp_flag): New.
4760         (tui_bp_flags): New enum flags type.
4761         (struct tui_source_element) <break_mode>: Change type.  Rename
4762         from has_break.
4763         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4764         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4765         constants.
4766         * tui/tui-winsource.h: Fix comment.
4767
4768 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4769
4770         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4771         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4772         (store_fpregs_to_thread)
4773         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4774         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4775         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4776         (IWMMXT_REGS_SIZE): Add define.
4777         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4778         (fetch_vfp_regs, store_vfp_regs)
4779         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4780         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4781
4782 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4783
4784         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4785         defines.
4786         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4787         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4788         (ARM_INT_REGISTER_SIZE): ...to this.
4789         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4790         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4791         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4792         (arm_linux_collect_gregset, supply_nwfpe_register)
4793         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4794         defines.
4795         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4796         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4797         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4798         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4799         (arm_return_in_memory, arm_store_return_value)
4800         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4801         (arm_record_ld_st_multiple): Likewise.
4802         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4803         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4804
4805 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4806
4807         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4808         AARCH64_DISPLACED_MODIFIED_INSNS.
4809         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4810         (aarch64_displaced_step_copy_insn): Likewise.
4811         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4812         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4813         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4814         ARM_DISPLACED_MODIFIED_INSNS.
4815         * arm-tdep.c (arm_gdbarch_init): Likewise.
4816         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4817         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4818         (struct arm_displaced_step_closure): Use
4819         ARM_DISPLACED_MODIFIED_INSNS.
4820
4821 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4822
4823         * features/Makefile: Remove unused xml files.
4824         * features/aarch64.xml: Remove.
4825         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4826         * features/i386/amd64-avx-avx512.xml: Remove.
4827         * features/i386/amd64-avx-linux.xml: Remove.
4828         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4829         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4830         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4831         * features/i386/amd64-avx-mpx.xml: Remove.
4832         * features/i386/amd64-avx.xml: Remove.
4833         * features/i386/amd64-linux.xml: Remove.
4834         * features/i386/amd64-mpx-linux.xml: Remove.
4835         * features/i386/amd64-mpx.xml: Remove.
4836         * features/i386/amd64.xml: Remove.
4837         * features/i386/i386-avx-avx512-linux.xml: Remove.
4838         * features/i386/i386-avx-avx512.xml: Remove.
4839         * features/i386/i386-avx-linux.xml: Remove.
4840         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4841         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4842         * features/i386/i386-avx-mpx-linux.xml: Remove.
4843         * features/i386/i386-avx-mpx.xml: Remove.
4844         * features/i386/i386-avx.xml: Remove.
4845         * features/i386/i386-linux.xml: Remove.
4846         * features/i386/i386-mmx-linux.xml: Remove.
4847         * features/i386/i386-mmx.xml: Remove.
4848         * features/i386/i386-mpx-linux.xml: Remove.
4849         * features/i386/i386-mpx.xml: Remove.
4850         * features/i386/i386.xml: Remove.
4851         * features/i386/x32-avx-avx512-linux.xml: Remove.
4852         * features/i386/x32-avx-linux.xml: Remove.
4853         * features/i386/x32-linux.xml: Remove.
4854
4855 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4856
4857         * regformats/aarch64.dat: Remove.
4858         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4859         * regformats/i386/amd64-avx-linux.dat: Remove.
4860         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4861         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4862         * regformats/i386/amd64-linux.dat: Remove.
4863         * regformats/i386/amd64-mpx-linux.dat: Remove.
4864         * regformats/i386/amd64.dat: Remove.
4865         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4866         * regformats/i386/i386-avx-linux.dat: Remove.
4867         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4868         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4869         * regformats/i386/i386-linux.dat: Remove.
4870         * regformats/i386/i386-mmx-linux.dat: Remove.
4871         * regformats/i386/i386-mpx-linux.dat: Remove.
4872         * regformats/i386/i386.dat: Remove.
4873         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4874         * regformats/i386/x32-avx-linux.dat: Remove.
4875         * regformats/i386/x32-linux.dat: Remove.
4876
4877 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4878
4879         * aarch64-tdep.c: Remove xml self tests.
4880         * amd64-linux-tdep.c: Likewise.
4881         * amd64-tdep.c: Likewise.
4882         * i386-linux-tdep.c: Likewise.
4883         * i386-tdep.c: Likewise.
4884
4885 2019-07-03  Pedro Alves  <palves@redhat.com>
4886
4887         PR cli/24732
4888         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4889         (pipe_cmd_option_defs): New.
4890         (make_pipe_cmd_options_def_group): New.
4891         (pipe_command): Use gdb::option::process_options.
4892         (pipe_command_completer): New function.
4893         (_initialize_cli_cmds): Install completer for "pipe" command.
4894
4895 2019-07-03  Pedro Alves  <palves@redhat.com>
4896
4897         * cli/cli-option.c (union option_value) <string>: New field.
4898         (struct option_def_and_value): Add ctor, move ctor, dtor and
4899         use DISABLE_COPY_AND_ASSIGN.
4900         (option_def_and_value::clear_value): New.
4901         (parse_option, save_option_value_in_ctx, get_val_type_str)
4902         (add_setshow_cmds_for_options): Handle var_string.
4903         * cli-option.h (union option_def::var_address) <string>: New
4904         field.
4905         (struct string_option_def): New.
4906         * maint-test-options.c (struct test_options_opts): Add default
4907         ctor and use DISABLE_COPY_AND_ASSIGN.
4908         <string_opt>: New field.
4909         (test_options_opts::~test_options_opts): New.
4910         (test_options_opts::dump): Also dump "-string".
4911         (test_options_option_defs): Install "string.
4912
4913 2019-07-03  Pedro Alves  <palves@redhat.com>
4914
4915         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4916         option_value with a null enumeration.
4917         (complete_options): Save the option values in the context.
4918         (save_option_value_in_ctx): New, factored out from ...
4919         (process_options): ... here.
4920         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4921         of the function.
4922         * maint-test-options.c (test_options_opts::dump): New, factored
4923         out from ...
4924         (maintenance_test_options_command_mode): ... here.
4925         (maintenance_test_options_command_completion_result): Delete.
4926         (maintenance_test_options_command_completion_text): Update
4927         comment.
4928         (maintenance_show_test_options_completion_result): Change
4929         prototype.  Just print
4930         maintenance_test_options_command_completion_text.
4931         (save_completion_result): New.
4932         (maintenance_test_options_completer_mode): Pass options context to
4933         complete_options, and then save a dump.
4934         (_initialize_maint_test_options): Use add_cmd to install "maint
4935         show test-options-completion-result".
4936
4937 2019-07-03  Pedro Alves  <palves@redhat.com>
4938
4939         * NEWS (New commands): Mention "with" and "maint with".
4940         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4941         (with_command, with_command_completer): New.
4942         (pipe_command): Adjust to new repeat_previous
4943         interface.
4944         (_initialize_cli_cmds): Install the "with" command and its "w"
4945         alias.
4946         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4947         declarations.
4948         * cli/cli-setshow.c (parse_cli_var_uinteger)
4949         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4950         argument strings for all var_types.
4951         (get_setshow_command_value_string): New, factored out from ...
4952         (do_show_command): ... this.
4953         * cli/cli-setshow.h: Include <string>.
4954         (get_setshow_command_value_string): Declare.
4955         * command.h (repeat_previous): Now returns const char *.  Adjust
4956         comment.
4957         * maint.c: Include "cli/cli-cmds.h".
4958         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4959         (_initialize_maint_cmds): Register the "maintenance with" command.
4960         * top.c (repeat_previous): Move bits from pipe_command here:
4961         Return the saved command line, if any; error out if there's no
4962         command to relaunch.
4963
4964 2019-07-03  Pedro Alves  <palves@redhat.com>
4965
4966         * NEWS (New commands): Mention "maint set/show test-settings"
4967         instead of "maint test-settings".
4968         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4969         (maintenance_test_settings_set_list): Rename to ...
4970         (maintenance_set_test_settings_list): ... this.
4971         (maintenance_test_settings_show_list): Rename to  ...
4972         (maintenance_show_test_settings_list): ... this.
4973         (maintenance_test_settings_cmd): Delete.
4974         (maintenance_test_settings_set_cmd): ...
4975         (maintenance_set_test_settings_cmd): ... this.
4976         (maintenance_test_settings_show_cmd): ...
4977         (maintenance_show_test_settings_cmd): ... this.
4978         (maintenance_test_settings_show_value_cmd):
4979         (maintenance_show_test_settings_value_cmd): ... this.
4980         (_initialize_maint_test_settings): No longer install the "maint
4981         test-settings" prefix command.  Rename "maint test-settings set"
4982         to "maint set test-settings", and "maint test-settings show" to
4983         "maint show test-settings".  Adjust all subcommands.
4984
4985 2019-07-03  Pedro Alves  <palves@redhat.com>
4986
4987         * maint-test-settings.c: Fix file's intro comment.  Replace all
4988         references to "test-options" with references to "test-settings",
4989         in comments.
4990
4991 2019-07-03  Pedro Alves  <palves@redhat.com>
4992
4993         * maint-test-settings.c (maintenance_test_settings_xxx)
4994         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4995         New.
4996         (maintenance_test_settings_enums): Use them.
4997         (maintenance_test_settings_enum): Default to
4998         maintenance_test_settings_xxx.
4999         (_initialize_maint_test_settings): Initialize
5000         MAINTENANCE_TEST_SETTINGS_FILENAME.
5001
5002 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5003
5004         * breakpoint.h (remove_breakpoints_inf): Change return type to
5005         void, move function documentation here.
5006         * breakpoint.c (remove_breakpoints_inf): Change return type to
5007         void, move function documentation to header.
5008
5009 2019-07-02  Pedro Alves  <palves@redhat.com>
5010
5011         * NEWS (Completion improvements): Mention "info threads".
5012         * thread.c (struct info_threads_opts, info_threads_option_defs)
5013         (make_info_threads_options_def_group): New.
5014         (info_threads_command): Use gdb::option::process_options.
5015         (info_threads_command_completer): New.
5016         (_initialize_thread): Use gdb::option::build_help to build the
5017         help text for "info threads".
5018
5019 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5020
5021         * defs.h (generic_load): Move from here...
5022         * symfile.h (generic_load): ... to here.  Rename name parameter
5023         to args.
5024         * symfile.c (generic_load): Add comment.
5025
5026 2019-07-01  Tom Tromey  <tromey@adacore.com>
5027
5028         * dwarf2read.c
5029         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5030         declaration of without_params.  Fix formatting.
5031
5032 2019-07-01  Tom Tromey  <tromey@adacore.com>
5033
5034         * ada-exp.y (find_primitive_type): Update.
5035         * ada-lang.h (ada_lookup_symbol): Update.
5036         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5037         parameter.
5038         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5039
5040 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5041
5042         PR breakpoints/24541
5043         * gdbarch.c: Regenerate.
5044         * gdbarch.h: Regenerate.
5045         * gdbarch.sh: Add 'stap_adjust_register'.
5046         * i386-tdep.c: Include '<unordered_set>'.
5047         (i386_stap_adjust_register): New function.
5048         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5049         * stap-probe.c (stap_parse_register_operand): Call
5050         'gdbarch_stap_adjust_register'.
5051
5052 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5053
5054         PR python/24742
5055         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5056         * python/python.c (do_start_initialization): Use 'xmalloc'
5057         instead of 'PyMem_Malloc'.
5058
5059 2019-06-28  Tom Tromey  <tromey@adacore.com>
5060
5061         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5062         for Ada.
5063
5064 2019-06-27  Tom Tromey  <tromey@adacore.com>
5065
5066         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5067         objfile_key.
5068         (arm_find_mapping_symbol, arm_record_special_symbol)
5069         (_initialize_arm_tdep): Update.
5070         (arm_objfile_data_free): Remove.
5071
5072 2019-06-27  Tom Tromey  <tromey@adacore.com>
5073
5074         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5075         to cp_print_static_field.
5076
5077 2019-06-26  Tom Tromey  <tromey@adacore.com>
5078
5079         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5080         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5081         declare.
5082
5083 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5084
5085         * features/aarch64-core.c (create_feature_aarch64_core):
5086         Regenerate.
5087         * features/aarch64-core.xml: Add cpsr flags.
5088
5089 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5090
5091         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5092         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5093
5094 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5095
5096         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5097         field.
5098         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5099         use.
5100         (arm_record_special_symbol): Don't insert new symbol in sorted
5101         position, push it at the end.
5102
5103 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5104
5105         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5106         (arm_mapping_symbol_s): Remove.
5107         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5108         (arm_mapping_symbol_vec): New typedef.
5109         (struct arm_per_objfile): Add constructor.
5110         <section_maps>: Change type to
5111         std::unique_ptr<arm_mapping_symbol_vec[]>.
5112         (arm_compare_mapping_symbols): Remove.
5113         (arm_find_mapping_symbol): Adjust to section_maps type change.
5114         (arm_objfile_data_free): Call delete on arm_per_objfile.
5115         (arm_record_special_symbol): Adjust to section_maps type change.
5116         Allocate arm_per_objfile with new.
5117
5118 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5119
5120         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5121         with the command prefix.
5122
5123 2019-06-25  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5126         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5127
5128 2019-06-25  Tom Tromey  <tom@tromey.com>
5129
5130         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5131         type.
5132         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5133         protected.
5134
5135 2019-06-25  Tom Tromey  <tom@tromey.com>
5136
5137         * tui/tui-winsource.c
5138         (tui_source_window_base::set_is_exec_point_at): Add check against
5139         LOA_ADDRESS.
5140
5141 2019-06-25  Tom Tromey  <tom@tromey.com>
5142
5143         * tui/tui-source.c (tui_set_source_content): Don't check before
5144         xfree.
5145         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5146
5147 2019-06-25  Tom Tromey  <tom@tromey.com>
5148
5149         * tui/tui-winsource.h (tui_update_source_window_as_is)
5150         (tui_alloc_source_buffer, tui_line_is_displayed)
5151         (tui_addr_is_displayed): Change type of win_info.
5152         * tui/tui-winsource.c (tui_update_source_window_as_is)
5153         (tui_clear_source_content, tui_show_source_line)
5154         (tui_show_source_content, tui_source_window_base::refill)
5155         (tui_source_window_base::set_is_exec_point_at)
5156         (tui_source_window_base::set_is_exec_point_at)
5157         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5158         (tui_alloc_source_buffer, tui_line_is_displayed)
5159         (tui_addr_is_displayed): Change type of win_info.  Update.
5160         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5161         (tui_source_window_base::do_make_visible_with_new_height):
5162         Update.
5163         * tui/tui-source.c (tui_set_source_content)
5164         (tui_set_source_content_nil)
5165         (tui_source_window::do_scroll_vertical): Update.
5166         * tui/tui-layout.c (show_layout): Update.
5167         * tui/tui-disasm.c (tui_set_disassem_content)
5168         (tui_disasm_window::do_scroll_vertical): Update.
5169         * tui/tui-data.h (tui_win_content): Remove.
5170         (struct tui_gen_win_info) <content, content_size>: Remove.
5171         (struct tui_source_element): Add initializers and destructor.
5172         (union tui_which_element, struct tui_win_element): Remove.
5173         (struct tui_source_window_base) <content>: New field.
5174         (struct tui_data_window): Remove destructor.
5175         (tui_alloc_content, tui_free_win_content)
5176         (tui_free_all_source_wins_content): Don't declare.
5177         * tui/tui-data.c (tui_initialize_static_data): Update.
5178         (init_content_element, tui_alloc_content): Remove.
5179         (~tui_gen_win_info): Update.
5180         (~tui_data_window, tui_free_all_source_wins_content)
5181         (tui_free_win_content, free_content, free_content_elements):
5182         Remove.
5183
5184 2019-06-25  Tom Tromey  <tom@tromey.com>
5185
5186         * tui/tui-winsource.h (tui_clear_source_content)
5187         (tui_erase_source_content, tui_show_source_content): Change type
5188         of win_info.
5189         * tui/tui-winsource.c (tui_clear_source_content)
5190         (tui_erase_source_content, tui_show_source_content): Change type
5191         of win_info.
5192         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5193         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5194         win_info.
5195         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5196         win_info.
5197         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5198
5199 2019-06-25  Tom Tromey  <tom@tromey.com>
5200
5201         * tui/tui-winsource.c (tui_clear_source_content)
5202         (tui_source_window_base::set_is_exec_point_at): Update.
5203         * tui/tui-source.c (tui_set_source_content_nil): Update.
5204         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5205         a bool.
5206         * tui/tui-data.c (init_content_element): Update.
5207
5208 2019-06-25  Tom Tromey  <tom@tromey.com>
5209
5210         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5211         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5212         * tui/tui-layout.c (init_and_make_win): Update.
5213         * tui/tui.h (enum tui_win_type): Update.
5214         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5215         tui_win_is_auxillary.
5216         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5217         tui_win_is_auxillary.
5218
5219 2019-06-25  Tom Tromey  <tom@tromey.com>
5220
5221         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5222         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5223         (tui_delete_data_content_windows, tui_display_all_data)
5224         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5225         Update.
5226         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5227         * tui/tui-regs.c (tui_last_regs_line_no)
5228         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5229         (tui_show_registers): Update.
5230         (tui_show_register_group): Return void.  Update.
5231         (tui_display_registers_from, tui_display_reg_element_at_line)
5232         (tui_display_registers_from_line, tui_check_register_values):
5233         Update.
5234         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5235         member.
5236         (struct tui_data_window) <regs_content>: Now a std::vector.
5237         <regs_content_count>: Remove.
5238         (tui_add_content_elements, tui_free_data_content): Don't declare.
5239         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5240         (init_content_element): Remove DATA_WIN case.  Add assert.
5241         (tui_add_content_elements): Remove.
5242         (tui_data_window): Update.
5243         (tui_free_data_content): Remove.
5244         (free_content_elements): Remove DATA_WIN case.
5245
5246 2019-06-25  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-data.c (tui_data_item_window): Update.
5249         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5250         * tui/tui-windata.c (tui_display_all_data)
5251         (tui_display_data_from_line): Update.
5252         (tui_check_data_values): Remove.
5253         * tui/tui-regs.c (tui_show_register_group)
5254         (tui_display_reg_element_at_line): Update.
5255         * tui/tui-hooks.c (tui_register_changed)
5256         (tui_refresh_frame_and_register_information): Call
5257         tui_check_register_values.
5258         * tui/tui-data.h (struct tui_data_window) <data_content,
5259         data_content_count, data_type>: Remove.
5260         (enum tui_data_type): Remove.
5261
5262         * tui/tui-data.c (tui_data_window::clear_detail)
5263         (~tui_data_window): Update.
5264
5265 2019-06-25  Tom Tromey  <tom@tromey.com>
5266
5267         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5268         declare.
5269         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5270         Rename from tui_first_data_item_displayed.  Update.
5271         (tui_data_window::refresh_all)
5272         (tui_data_window::do_scroll_vertical): Update.
5273         * tui/tui-data.h (struct tui_data_window)
5274         <first_data_item_displayed>: Declare new method.
5275
5276 2019-06-25  Tom Tromey  <tom@tromey.com>
5277
5278         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5279         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5280         contents...
5281         (tui_initialize_static_data): ...here.
5282
5283 2019-06-25  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5286         (tui_display_registers_from, tui_check_register_values): Update.
5287         (tui_display_register): Remove win_info parameter; update.
5288         (tui_get_register): Change type of parameters.
5289         * tui/tui-data.h (struct tui_data_element): Remove.
5290         (union tui_which_element) <data>: Remove.
5291         <data_window>: Change type.
5292         (struct tui_data_item_window): New.
5293         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5294         case.  Add assert.
5295         (~tui_data_item_window): New destructor.
5296         (free_content_elements): Remove DATA_ITEM_WIN case.
5297
5298 2019-06-25  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5301         Remove.
5302
5303 2019-06-25  Tom Tromey  <tom@tromey.com>
5304
5305         * tui/tui-data.h (struct tui_command_element): Remove.
5306         (union tui_which_element) <command>: Remove.
5307         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5308         assert.
5309         (free_content_elements): Remove CMD_WIN case.
5310
5311 2019-06-25  Tom Tromey  <tom@tromey.com>
5312
5313         * tui/tui-layout.c (tui_set_layout): Update.
5314         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5315         * tui/tui-data.c (layout_def): Update.
5316
5317 2019-06-25  Tom Tromey  <tom@tromey.com>
5318
5319         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5320         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5321         (tui_source_window_base::set_new_height): Update.
5322         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5323         Update.
5324         (tui_set_locator_fullname, tui_set_locator_info)
5325         (tui_show_frame_info): Update.
5326         * tui/tui-source.c (tui_set_source_content)
5327         (tui_source_is_displayed): Update.
5328         * tui/tui-layout.c (show_source_disasm_command, show_data)
5329         (show_source_or_disasm_and_command): Update.
5330         * tui/tui-disasm.c (tui_set_disassem_content)
5331         (tui_get_begin_asm_address): Update.
5332         * tui/tui-data.h (struct tui_locator_element): Remove.
5333         (union tui_which_element) <locator>: Remove.
5334         (struct tui_locator_window): New.
5335         (tui_locator_win_info_ptr): Change return type.
5336         * tui/tui-data.c (_locator): Change type.
5337         (tui_locator_win_info_ptr): Change return type.
5338         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5339         (tui_alloc_content): Add assert.
5340
5341 2019-06-25  Tom Tromey  <tom@tromey.com>
5342
5343         * tui/tui-winsource.c
5344         (tui_exec_info_window::maybe_allocate_content): New method.
5345         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5346         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5347         (make_source_or_disasm_window): Add cast.
5348         * tui/tui-data.h (union tui_which_element) <simple_string>:
5349         Remove.
5350         (struct tui_source_info): New.
5351         (struct tui_source_window_base) <execution_info>: Change type.
5352         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5353         case, and add assert.
5354         (tui_alloc_content): Add assert.
5355
5356 2019-06-25  Tom Tromey  <tom@tromey.com>
5357
5358         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5359         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5360         * tui/tui-data.c (tui_alloc_win_info): Remove.
5361
5362 2019-06-25  Tom Tromey  <tom@tromey.com>
5363
5364         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5365         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5366         can_highlight.
5367
5368 2019-06-25  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5371         make_visible_with_new_height method.
5372         (tui_win_info::make_visible_with_new_height): New method.
5373         (tui_source_window_base::do_make_visible_with_new_height)
5374         (tui_data_window::do_make_visible_with_new_height)
5375         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5376         (make_visible_with_new_height): Remove.
5377         (tui_resize_all, tui_adjust_win_heights): Use
5378         make_visible_with_new_height method.
5379         * tui/tui-data.h (struct tui_win_info)
5380         <do_make_visible_with_new_height, make_visible_with_new_height>:
5381         New methods.
5382         (struct tui_source_window_base, struct tui_data_window)
5383         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5384         methods.
5385
5386 2019-06-25  Tom Tromey  <tom@tromey.com>
5387
5388         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5389         method.
5390         (update_tab_width): Call update_tab_width method.
5391         * tui/tui-data.h (struct tui_win_info)
5392         (struct tui_source_window_base) <update_tab_width>: New methods.
5393
5394 2019-06-25  Tom Tromey  <tom@tromey.com>
5395
5396         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5397         parameter.
5398         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5399         parameter.
5400         (tui_gen_win_info::make_visible): Update.
5401         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5402         parameter.
5403         * tui/tui-data.h (enum tui_box): New enum.
5404         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5405
5406 2019-06-25  Tom Tromey  <tom@tromey.com>
5407
5408         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5409         init_and_make_win for EXEC_INFO_WIN.
5410         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5411         longer inline.
5412         (struct tui_win_info) <~tui_win_info>: Inline.
5413         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5414         Don't declare.
5415         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5416         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5417         Remove.
5418         (tui_initialize_static_data): Update.
5419         (~tui_gen_win_info): Handle more cleanup here.
5420         (~tui_source_window_base): Delete "execution_info".
5421         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5422
5423 2019-06-25  Tom Tromey  <tom@tromey.com>
5424
5425         * tui/tui-layout.c (make_command_window): Don't set
5426         can_highlight.
5427         (show_source_disasm_command): Call the reset method.
5428         (show_data): Don't set can_highlight.  Call the reset method.
5429         (tui_gen_win_info::reset): Rename from init_gen_win_info
5430         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5431         (show_source_or_disasm_and_command): Call the reset method.
5432         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5433         (struct tui_cmd_window): Set can_highlight.
5434
5435 2019-06-25  Tom Tromey  <tom@tromey.com>
5436
5437         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5438         from make_visible.
5439         (tui_make_visible, tui_make_invisible): Rewrite.
5440         (tui_win_info::make_visible): Remove.
5441         (tui_source_window_base::make_visible): Update.
5442         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5443         method.  Moved from...
5444         (struct tui_win_info) <make_visible>: ...here.
5445
5446 2019-06-25  Tom Tromey  <tom@tromey.com>
5447
5448         * tui/tui-winsource.c
5449         (tui_source_window_base::do_scroll_horizontal): Remove direction
5450         parameter.
5451         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5452         direction parameter.
5453         * tui/tui-win.c (tui_win_info::forward_scroll)
5454         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5455         (tui_win_info::right_scroll): Update.
5456         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5457         direction parameter.
5458         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5459         direction parameter.
5460         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5461         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5462         Remove direction parameter.
5463         (struct tui_source_window_base, struct tui_source_window)
5464         (struct tui_disasm_window, struct tui_data_window)
5465         (struct tui_cmd_window): Update.
5466
5467 2019-06-25  Tom Tromey  <tom@tromey.com>
5468
5469         * tui/tui-winsource.h (tui_set_exec_info_content)
5470         (tui_show_exec_info_content, tui_erase_exec_info_content)
5471         (tui_clear_exec_info_content, tui_update_exec_info): Change
5472         argument to tui_source_window_base.
5473         * tui/tui-winsource.c (tui_set_exec_info_content)
5474         (tui_show_exec_info_content, tui_erase_exec_info_content)
5475         (tui_clear_exec_info_content, tui_update_exec_info): Change
5476         argument to tui_source_window_base.
5477
5478 2019-06-25  Tom Tromey  <tom@tromey.com>
5479
5480         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5481         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5482
5483 2019-06-25  Tom Tromey  <tom@tromey.com>
5484
5485         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5486         check.
5487
5488 2019-06-25  Tom Tromey  <tom@tromey.com>
5489
5490         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5491         type to void.
5492         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5493         type to void.
5494         * tui/tui-source.c (tui_set_source_content): Update.
5495         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5496
5497 2019-06-25  Tom Tromey  <tom@tromey.com>
5498
5499         * tui/tui-win.c (window_name_completer, tui_set_focus)
5500         (tui_all_windows_info): Use name method.
5501         * tui/tui-data.h (struct tui_gen_win_info)
5502         (struct tui_source_window, struct tui_disasm_window)
5503         (struct tui_data_window, struct tui_cmd_window) <name>: New
5504         method.
5505         (tui_win_name): Don't declare.
5506         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5507         (tui_win_name): Remove.
5508
5509 2019-06-25  Tom Tromey  <tom@tromey.com>
5510
5511         * tui/tui-winsource.h (tui_update_source_window)
5512         (tui_update_source_window_as_is): Change parameter type.
5513         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5514         to be a tui_source_window_base.
5515         (tui_update_source_window_as_is): Likewise.
5516         * tui/tui-win.c (make_visible_with_new_height): Update.
5517
5518 2019-06-25  Tom Tromey  <tom@tromey.com>
5519
5520         * tui/tui-winsource.c (tui_erase_source_content)
5521         (tui_show_source_content, tui_show_exec_info_content)
5522         (tui_erase_exec_info_content): Use refresh_window method.
5523         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5524         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5525         from tui_refresh_win.
5526         (tui_data_window::refresh_window): New method.
5527         (tui_win_info::refresh, tui_source_window_base::refresh)
5528         (tui_refresh_all): Use refresh_window method.
5529         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5530         method.
5531         * tui/tui-regs.c (tui_display_register): Call refresh_window
5532         method.
5533         * tui/tui-layout.c (show_source_disasm_command)
5534         (show_source_or_disasm_and_command): Call refresh_window method.
5535         * tui/tui-data.h (struct tui_gen_win_info)
5536         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5537         New method.
5538
5539 2019-06-25  Tom Tromey  <tom@tromey.com>
5540
5541         * tui/tui.c (tui_rl_other_window, tui_enable)
5542         (tui_is_window_visible, tui_get_command_dimension): Update.
5543         * tui/tui-winsource.c (tui_update_source_window_as_is)
5544         (tui_clear_source_content, tui_erase_source_content)
5545         (tui_show_source_line, tui_source_window_base::refill)
5546         (tui_source_window_base::do_scroll_horizontal)
5547         (tui_source_window_base::set_is_exec_point_at)
5548         (tui_update_breakpoint_info, tui_set_exec_info_content)
5549         (tui_alloc_source_buffer, tui_line_is_displayed)
5550         (tui_addr_is_displayed): Update.
5551         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5552         (tui_check_and_display_highlight_if_needed)
5553         (tui_win_info::make_visible, tui_win_info::refresh)
5554         (tui_refresh_all): Update.
5555         * tui/tui-windata.c (tui_first_data_item_displayed)
5556         (tui_delete_data_content_windows, tui_erase_data_content)
5557         (tui_display_all_data, tui_data_window::refresh_all)
5558         (tui_check_data_values): Update.
5559         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5560         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5561         (tui_win_info::backward_scroll, tui_refresh_all_win)
5562         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5563         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5564         (tui_source_window_base::set_new_height)
5565         (tui_data_window::set_new_height)
5566         (make_invisible_and_set_new_height)
5567         (make_visible_with_new_height, new_height_ok)
5568         (parse_scrolling_args): Update.
5569         * tui/tui-stack.c (tui_show_frame_info): Update.
5570         * tui/tui-source.c (tui_set_source_content)
5571         (tui_set_source_content_nil, tui_source_is_displayed)
5572         (tui_source_window::do_scroll_vertical): Update.
5573         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5574         (tui_display_registers_from, tui_display_reg_element_at_line)
5575         (tui_check_register_values, tui_reg_command): Update.
5576         * tui/tui-layout.c (tui_default_win_height)
5577         (show_source_disasm_command, show_data, init_and_make_win)
5578         (show_source_or_disasm_and_command): Update.
5579         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5580         (tui_redisplay_readline, tui_mld_flush)
5581         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5582         (tui_getc): Update.
5583         * tui/tui-disasm.c (tui_set_disassem_content)
5584         (tui_disasm_window::do_scroll_vertical): Update.
5585         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5586         Now virtual.
5587         (struct tui_win_info): Derive from tui_gen_win_info.
5588         <~tui_win_info>: Mark as override.
5589         <generic>: Remove member.
5590         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5591         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5592         (~tui_data_window, ~tui_win_info)
5593         (tui_free_all_source_wins_content): Update.
5594         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5595
5596 2019-06-25  Tom Tromey  <tom@tromey.com>
5597
5598         * tui/tui-layout.c (init_and_make_win): Use new.
5599         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5600         destructor, initializers.
5601         (tui_alloc_generic_win_info): Don't declare.
5602         * tui/tui-data.c (_locator): Add argument to constructor.
5603         (source_win, disasm_win): New globals.
5604         (exec_info): Remove.
5605         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5606         Update.
5607         (tui_alloc_generic_win_info): Remove.
5608         (init_content_element): Use new.
5609         (tui_win_info::tui_win_info): Update.
5610         (free_content_elements) <case DATA_WIN>: Use delete.
5611
5612 2019-06-25  Tom Tromey  <tom@tromey.com>
5613
5614         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5615         * tui/tui-windata.c (tui_first_data_item_displayed)
5616         (tui_delete_data_content_windows): Update.
5617         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5618         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5619         (tui_display_registers_from, tui_check_register_values): Update.
5620         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5621         pointer.
5622         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5623         window.
5624         (tui_free_data_content): Update.
5625         (free_content_elements) <case DATA_WIN>: Free the window.
5626
5627 2019-06-25  Tom Tromey  <tom@tromey.com>
5628
5629         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5630         Update.
5631         * tui/tui-layout.c (make_command_window)
5632         (show_source_disasm_command, show_data, init_and_make_win)
5633         (show_source_or_disasm_and_command): Update.
5634         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5635         method.
5636         <can_highight, is_highlighted>: Now bool.
5637         (tui_set_win_highlight): Don't declare.
5638         * tui/tui-data.c (tui_set_win_highlight): Remove.
5639
5640 2019-06-25  Tom Tromey  <tom@tromey.com>
5641
5642         * tui/tui-wingeneral.c (make_visible): Remove check of window
5643         type.
5644
5645 2019-06-25  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-win.c (tui_win_info::max_height)
5648         (tui_cmd_window::max_height): New methods.
5649         (new_height_ok): Call max_height.
5650         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5651         <max_height>: New method.
5652
5653 2019-06-25  Tom Tromey  <tom@tromey.com>
5654
5655         * tui/tui-win.c (tui_source_window_base::set_new_height)
5656         (tui_data_window::set_new_height): New methods.
5657         (make_invisible_and_set_new_height): Call set_new_height method.
5658         * tui/tui-data.h (struct tui_win_info)
5659         (struct tui_source_window_base, struct tui_data_window)
5660         <set_new_height>: New method.
5661
5662 2019-06-25  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5665         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5666         tui_refresh_data_win.
5667         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5668         method.
5669         (tui_refresh_all_win): Call the refresh_all method.
5670         (tui_set_focus): Likewise.
5671         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5672         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5673         Likewise.
5674
5675 2019-06-25  Tom Tromey  <tom@tromey.com>
5676
5677         * tui/tui-winsource.h (tui_refill_source_window)
5678         (tui_set_is_exec_point_at): Don't declare.
5679         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5680         (tui_source_window_base::refill): Rename from
5681         tui_refill_source_window.
5682         (tui_source_window_base::do_scroll_horizontal): Update.
5683         (tui_source_window_base::set_is_exec_point_at): Rename from
5684         tui_set_is_exec_point_at.
5685         (tui_update_all_breakpoint_info): Update.
5686         * tui/tui-stack.c (tui_show_frame_info): Update.
5687         * tui/tui-layout.c (show_data): Add cast.
5688         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5689         * tui/tui-data.h (struct tui_source_window_base) <refill,
5690         set_is_exec_point_at>: New methods.
5691         (tui_source_windows, tui_add_to_source_windows): Update types.
5692         (tui_add_to_source_windows): Remove redundant declaration.
5693         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5694         (tui_source_windows): Change return type.
5695         (tui_clear_source_windows_detail): Update.
5696         (tui_add_to_source_windows): Change type of parameter.
5697         (tui_free_all_source_wins_content): Update.
5698
5699 2019-06-25  Tom Tromey  <tom@tromey.com>
5700
5701         * tui/tui-wingeneral.c (tui_win_info::refresh)
5702         (tui_source_window_base::refresh): New methods.
5703         (tui_refresh_all): Call the refresh method.
5704         * tui/tui-data.h (struct tui_win_info)
5705         (struct tui_source_window_base) <refresh>: New method.
5706
5707 2019-06-25  Tom Tromey  <tom@tromey.com>
5708
5709         * tui/tui.h (tui_is_window_visible): Return bool.
5710         * tui/tui.c (tui_is_window_visible): Return bool.
5711         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5712         (tui_make_visible, tui_make_invisible)
5713         (tui_win_info::make_visible)
5714         (tui_source_window_base::make_visible, make_all_visible)
5715         (tui_make_all_visible, tui_make_all_invisible): Update.
5716         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5717         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5718         bool.
5719         (struct tui_win_info, struct tui_source_window_base)
5720         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5721         * tui/tui-data.c (tui_init_generic_part): Update.
5722
5723 2019-06-25  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5726         (tui_source_window_base::make_visible): New methods.
5727         (make_all_visible): Make method call.
5728         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5729         (struct tui_source_window_base, struct tui_cmd_window): Override
5730         make_visible.
5731         (tui_win_is_source_type): Don't declare.
5732         * tui/tui-data.c (tui_win_is_source_type): Remove.
5733
5734 2019-06-25  Tom Tromey  <tom@tromey.com>
5735
5736         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5737         NULL check.
5738
5739 2019-06-25  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5742         Inline constructor.  Add initializers for members.
5743         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5744         constructors; now inline in class.
5745
5746 2019-06-25  Tom Tromey  <tom@tromey.com>
5747
5748         * tui/tui-regs.c (tui_show_registers): Update.
5749         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5750         bool.
5751         * tui/tui-data.c (tui_data_window::clear_detail)
5752         (tui_data_window): Update.
5753
5754 2019-06-25  Tom Tromey  <tom@tromey.com>
5755
5756         * tui/tui-windata.c (tui_display_all_data)
5757         (tui_display_data_from_line, tui_display_data_from)
5758         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5759         Update.
5760         * tui/tui-regs.c (tui_last_regs_line_no)
5761         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5762         (tui_show_registers, tui_show_register_group)
5763         (tui_display_registers_from, tui_display_reg_element_at_line)
5764         (tui_display_registers_from_line, tui_check_register_values)
5765         (tui_reg_next, tui_reg_prev): Update.
5766         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5767         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5768         tui_data_window.
5769         (struct tui_win_info) <detail>: Remove.  Add new fields from
5770         tui_data_info.
5771         (TUI_DATA_WIN): Add cast.
5772         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5773         (~tui_data_window): Simplify.
5774
5775 2019-06-25  Tom Tromey  <tom@tromey.com>
5776
5777         * tui/tui-layout.c (show_source_disasm_command)
5778         (show_source_or_disasm_and_command): Update.
5779         * tui/tui-io.c (update_cmdwin_start_line)
5780         (tui_redisplay_readline): Update.
5781         * tui/tui-data.h (struct tui_command_info): Remove.
5782         (struct tui_win_info) <detail>: Remove command_info member.
5783         (struct tui_data_window) <start_line>: New member, from
5784         tui_command_info.
5785         (TUI_CMD_WIN): Add casts.
5786
5787 2019-06-25  Tom Tromey  <tom@tromey.com>
5788
5789         * tui/tui-winsource.c (tui_update_source_window)
5790         (tui_refill_source_window)
5791         (tui_source_window_base::do_scroll_horizontal)
5792         (tui_update_breakpoint_info, tui_set_exec_info_content)
5793         (tui_show_exec_info_content, tui_erase_exec_info_content)
5794         (tui_clear_exec_info_content): Update.
5795         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5796         Update.
5797         * tui/tui-win.c (make_invisible_and_set_new_height)
5798         (make_visible_with_new_height): Update.
5799         * tui/tui-source.c (tui_set_source_content)
5800         (tui_show_symtab_source): Update.
5801         * tui/tui-layout.c (extract_display_start_addr)
5802         (show_source_disasm_command, show_data)
5803         (make_source_or_disasm_window)
5804         (show_source_or_disasm_and_command): Update.
5805         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5806         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5807         "gdbarch".
5808         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5809         to tui_source_window_base.
5810         (struct tui_win_info) <detail>: Remove source_info member.
5811         (struct tui_source_window_base) <has_locator>: Inline.
5812         Move contents from tui_source_info; rename has_locator member to
5813         m_has_locator.
5814         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5815         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5816         header file.
5817         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5818         Simplify.
5819         (tui_free_all_source_wins_content): Cast to
5820         tui_source_window_base.
5821
5822 2019-06-25  Tom Tromey  <tom@tromey.com>
5823
5824         * tui/tui-win.c (make_invisible_and_set_new_height)
5825         (make_visible_with_new_height): Call has_locator method.
5826         * tui/tui-layout.c (show_source_disasm_command, show_data)
5827         (show_source_or_disasm_and_command): Update for bool change.
5828         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5829         (tui_win_info) <has_locator>: New method.
5830         (struct tui_source_window_base) <has_locator>: New method.
5831         (tui_win_has_locator): Don't declare.
5832         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5833         from tui_win_has_locator.
5834         (tui_source_window_base): Use false, not FALSE.
5835
5836 2019-06-25  Tom Tromey  <tom@tromey.com>
5837
5838         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5839         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5840         clear_detail method directly.
5841         (tui_clear_win_detail): Remove.
5842
5843 2019-06-25  Tom Tromey  <tom@tromey.com>
5844
5845         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5846         "this", not TUI_DISASM_WIN.
5847
5848 2019-06-25  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5851         declare.
5852         * tui/tui-winsource.c
5853         (tui_source_window_base::do_scroll_horizontal): Rename from
5854         tui_horizontal_source_scroll.
5855         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5856         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5857         from tui_vertical_data_scroll.
5858         * tui/tui-win.h (tui_scroll): Don't declare.
5859         * tui/tui-win.c (tui_win_info::forward_scroll)
5860         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5861         (tui_win_info::right_scroll): Rename and update.
5862         (tui_scroll_forward_command, tui_scroll_backward_command)
5863         (tui_scroll_left_command, tui_scroll_right_command): Update.
5864         (tui_scroll): Remove.
5865         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5866         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5867         from tui_vertical_source_scroll.
5868         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5869         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5870         from tui_vertical_disassem_scroll.
5871         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5872         do_scroll_horizontal>: New methods.
5873         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5874         Likewise.
5875         (struct tui_source_window_base): Add do_scroll_horizontal.
5876         (struct tui_source_window, struct tui_disasm_window): Add
5877         do_scroll_vertical.
5878         (struct tui_data_window, struct tui_cmd_window): Add
5879         do_scroll_horizontal and do_scroll_vertical.
5880         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5881
5882 2019-06-25  Tom Tromey  <tom@tromey.com>
5883
5884         * tui/tui-data.h (struct tui_source_window_base): New struct.
5885         (struct tui_source_window): Derive from tui_source_window_base.
5886         (struct tui_disasm_window): New struct.
5887         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5888         from tui_source_window::clear_detail.
5889         (tui_source_window_base): Rename from tui_source_window.
5890         (~tui_source_window_base): Rename from ~tui_source_window.
5891         (tui_alloc_win_info): Create a tui_disasm_window.
5892
5893 2019-06-25  Tom Tromey  <tom@tromey.com>
5894
5895         * tui/tui-data.h (struct tui_source_window)
5896         (struct tui_data_window): Declare destructors.
5897         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5898         destructors.
5899         (tui_win_info): Simplify.
5900
5901 2019-06-25  Tom Tromey  <tom@tromey.com>
5902
5903         * tui/tui-winsource.c (tui_display_main)
5904         (tui_update_source_windows_with_addr)
5905         (tui_update_all_breakpoint_info): Update.
5906         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5907         (new_height_ok, parse_scrolling_args): Update.
5908         * tui/tui-stack.c (tui_show_frame_info): Update.
5909         * tui/tui-data.h (struct tui_list): Remove.
5910         (tui_source_windows): Return a reference to a std::vector.
5911         * tui/tui-data.c (source_windows): Now a std::vector.
5912         (tui_source_windows): Change return type.
5913         (tui_clear_source_windows): Rewrite.
5914         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5915         (tui_free_all_source_wins_content): Rewrite.
5916
5917 2019-06-25  Tom Tromey  <tom@tromey.com>
5918
5919         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5920         (struct tui_data_window, struct tui_cmd_window): Declare
5921         clear_detail method.
5922         * tui/tui-data.c (tui_source_window::clear_detail)
5923         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5924         methods.
5925         (tui_clear_win_detail): Simplify.
5926
5927 2019-06-25  Tom Tromey  <tom@tromey.com>
5928
5929         * tui/tui-layout.c (make_source_window, make_disasm_window)
5930         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5931         Return the new window.
5932         (show_source_disasm_command, show_data)
5933         (show_source_or_disasm_and_command): Update.
5934
5935 2019-06-25  Tom Tromey  <tom@tromey.com>
5936
5937         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5938         parameter.  Return the new window.
5939         (show_source_disasm_command): Update and remove NULL check.
5940         (show_source_or_disasm_and_command): Update.
5941
5942 2019-06-25  Tom Tromey  <tom@tromey.com>
5943
5944         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5945
5946 2019-06-25  Tom Tromey  <tom@tromey.com>
5947
5948         * tui/tui-data.h (struct tui_win_info): Make constructor
5949         protected.  Make destructor virtual.  Add initializers.
5950         (tui_source_window, tui_data_window, tui_cmd_window): New
5951         classes.
5952         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5953         constructor.  Add "type" parameter.
5954         (tui_source_window, tui_data_window, tui_cmd_window): New
5955         constructors.
5956         (tui_alloc_win_info): Instantiate the appropriate subclass.
5957
5958 2019-06-25  Tom Tromey  <tom@tromey.com>
5959
5960         * tui/tui-win.c (tui_resize_all): Use delete.
5961         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5962         destructor.
5963         (tui_free_window): Don't declare.
5964         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5965         Update.
5966
5967 2019-06-25  Tom Tromey  <tom@tromey.com>
5968
5969         * tui/tui-data.h (struct tui_win_info): Add constructor.
5970         * tui/tui-data.c (tui_alloc_win_info): Use new.
5971         (tui_free_window): Use delete.
5972
5973 2019-06-22  Tom Tromey  <tom@tromey.com>
5974
5975         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5976         declare.
5977         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5978
5979 2019-06-22  Tom Tromey  <tom@tromey.com>
5980
5981         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5982         declare.
5983         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5984
5985 2019-06-22  Tom de Vries  <tdevries@suse.de>
5986
5987         * dwarf2read.c (create_addrmap_from_aranges)
5988         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5989         instead of '%zu'.
5990
5991 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5992
5993         * dwarf2read.h (dwarf2_section_info_def): Remove.
5994         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5995         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5996         std::vector<dwarf2_section_info>.
5997         (struct dwo_file) <~dwo_file>: Remove.
5998         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5999         types field.
6000         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6001         (dwarf2_read_debug_names): Likewise.
6002         (create_debug_types_hash_table): Change parameter type to
6003         array_view, adjust code accordingly.
6004         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6005         (partial_die_info::fixup): Likewise.
6006         (determine_prefix): Likewise.
6007         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6008
6009 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6010
6011         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6012         gdb_bfd_ref_ptr.
6013         <~dwo_file>: Remove call to gdb_bfd_unref.
6014         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6015         gdb_bfd_ref_ptr::get.
6016
6017 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6018
6019         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6020         type to htab_up.
6021         * dwarf2read.c (struct dwo_file): Initialize fields.
6022         <~dwo_file>: New.
6023         (free_dwo_file): Remove, move content to ~dwo_file.
6024         (struct dwo_file_deleter): Remove.
6025         (dwo_file_up>: Remove custom deleter.
6026         (free_dwo_files): Remove.
6027         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6028         dwo_files.
6029         (process_skeletonless_type_units): Call unique_ptr::get.
6030         (allocate_dwo_file_hash_table): Add deleter to created hash
6031         table.  Change return type to htab_up.
6032         (lookup_dwo_file_slot): Don't memset dwo_file, call
6033         unique_ptr::get.
6034         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6035         (create_dwo_unit_in_dwp_v2): Likewise.
6036         (open_and_init_dwo_file): Likewise.
6037         (free_dwo_file_from_slot): Remove.
6038
6039 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6040
6041         * dwarf2read.h (struct dwarf2_section_info) <readin,
6042         is_virtual>: Change type to bool.
6043         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6044         true instead of 1.
6045
6046 2019-06-19  Tom Tromey  <tom@tromey.com>
6047
6048         * tui/tui-data.h (tui_init_content_element): Don't declare.
6049
6050 2019-06-19  Tom Tromey  <tom@tromey.com>
6051
6052         * tui/tui-data.h (tui_init_win_info): Don't declare.
6053
6054 2019-06-19  Tom de Vries  <tdevries@suse.de>
6055
6056         * dwarf2read.h (abstract_to_concrete): Change type to
6057         std::unordered_map<sect_offset, std::vector<sect_offset>,
6058         gdb::hash_enum<sect_offset>>.
6059
6060 2019-06-19  Tom Tromey  <tromey@adacore.com>
6061
6062         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6063         EVAL_AVOID_SIDE_EFFECTS specially.
6064
6065 2019-06-19  Tom Tromey  <tromey@adacore.com>
6066
6067         * source-cache.c (highlighter): New global.
6068         (source_cache::get_source_lines): Create a highlighter on demand.
6069
6070 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6071
6072         * defs.h (deprecated_interactive_hook): Delete declaration.
6073         * interps.c (clear_interpreter_hooks): Remove use of
6074         deprecated_interactive_hook.
6075         * top.c (deprecated_interactive_hook): Delete definition.
6076         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6077
6078 2019-06-18  Tom de Vries  <tdevries@suse.de>
6079
6080         PR gdb/24515
6081         * dwarf2read.h (abstract_to_concrete): Change type from
6082         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6083         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6084         * dwarf2read.c (read_variable): Update.
6085         (dwarf2_fetch_die_loc_sect_off): Update.
6086
6087 2019-06-17  Tom de Vries  <tdevries@suse.de>
6088
6089         PR gdb/24617
6090         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6091         accessing parent[parent_len - 1].
6092
6093 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6094
6095         PR gdb/24364
6096         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6097         call dtrace_process_dof with NULL dof.
6098
6099 2019-06-16  Tom de Vries  <tdevries@suse.de>
6100
6101         PR gdb/24445
6102         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6103
6104 2019-06-16  Tom Tromey  <tom@tromey.com>
6105
6106         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6107         (make_all_visible): Use address of member.
6108
6109 2019-06-16  Tom Tromey  <tom@tromey.com>
6110
6111         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6112         (tui_free_window, free_content, free_content_elements): Remove
6113         unnecessary cast.
6114         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6115         cast.
6116         * tui/tui-regs.c (tui_show_register_group)
6117         (tui_display_registers_from, tui_display_reg_element_at_line):
6118         Remove unnecessary cast.
6119
6120 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6121
6122         * linux-nat.c (normal_mask): Delete.
6123         (_initialize_linux_nat): Don't initialise normal_mask.
6124
6125 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6126
6127         PR gdb/24445
6128         * dwarf-index-write.h (write_psymtabs_to_index): Add
6129         dwz_basename parameter.
6130         * dwarf-index-write.c (write_gdbindex): Move file writing to
6131         write_gdbindex_1.  Change return type void.
6132         (assert_file_size): Move up, remove filename parameter.
6133         (write_gdbindex_1): New function.
6134         (write_debug_names): Change return type to void, call
6135         assert_file_size.
6136         (struct index_wip_file): New struct.
6137         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6138         file logic to index_wip_file.  Write index for dwz file if
6139         needed.
6140         (save_gdb_index_command): Pass basename of dwz file, if present.
6141         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6142         build-id of dwz file, if present.
6143         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6144         (dwarf2_get_dwz_file): Likewise.
6145         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6146         (dwarf2_get_dwz_file): Likewise.
6147
6148 2019-06-16  Tom Tromey  <tom@tromey.com>
6149
6150         * coffread.c (process_coff_symbol): Use xstrdup.
6151         * value.c (create_internalvar): Use xstrdup.
6152
6153 2019-06-16  Tom Tromey  <tom@tromey.com>
6154
6155         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6156         * breakpoint.c (stopin_command, stopat_command)
6157         (until_break_command, decode_location_default): Remove unnecessary
6158         cast.
6159         * utils.c (subset_compare): Remove unnecessary cast.
6160         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6161         cast.
6162         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6163         cast.
6164         * infcmd.c (path_command): Remove unnecessary cast.
6165         * coffread.c (decode_type): Remove unnecessary cast.
6166         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6167         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6168         * tui/tui-stack.c (tui_show_locator_content)
6169         (tui_show_frame_info): Remove unnecessary cast.
6170         * tui/tui-win.c (tui_scroll_forward_command)
6171         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6172         (parse_scrolling_args): Remove unnecessary cast.
6173         * tui/tui-data.c (init_win_info, tui_del_window)
6174         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6175         (free_content_elements): Remove unnecessary cast.
6176         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6177         unnecessary cast.
6178         * tui/tui-source.c (tui_set_source_content)
6179         (tui_vertical_source_scroll): Remove unnecessary cast.
6180         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6181         cast.
6182         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6183         * tui/tui-regs.c (tui_display_registers_from)
6184         (tui_display_register): Remove unnecessary cast.
6185         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6186         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6187         (make_visible): Remove unnecessary cast.
6188         * tui/tui-winsource.c (tui_erase_source_content)
6189         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6190         unnecessary cast.
6191         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6192         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6193         * stabsread.c (read_type, read_array_type, read_range_type):
6194         Remove unnecessary cast.
6195         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6196         (parse_symbol, parse_type, upgrade_type, parse_external)
6197         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6198         unnecessary cast.
6199         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6200
6201 2019-06-16  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-data.c (tui_alloc_generic_win_info)
6204         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6205         checks.
6206
6207 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6208             Andrew Burgess  <andrew.burgess@embecosm.com>
6209
6210         * f-typeprint.c (f_print_type): Don't return early for not
6211         associated or not allocated types.
6212         (f_type_print_varspec_suffix): Add print_rank parameter and print
6213         ranks of array types in case they dangling.
6214         (f_type_print_base): Add print_rank parameter.
6215
6216 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6217
6218         * NEWS: Mention new MI commands.
6219         * break-catch-throw.c (enum exception_event_kind): Move to
6220         breakpoint.h.
6221         (print_mention_exception_catchpoint): Output text as a single
6222         message.
6223         (catch_exception_command_1): Rename to...
6224         (catch_exception_event): ...this, make non-static, update header
6225         command, and change some parameter types.
6226         (catch_catch_command): Update for changes to
6227         catch_exception_command_1.
6228         (catch_throw_command): Likewise.
6229         (catch_rethrow_command): Likewise.
6230         * breakpoint.c (enum exception_event_kind): Delete.
6231         * breakpoint.h (enum exception_event_kind): Moved here from
6232         break-catch-throw.c.
6233         (catch_exception_event): Declare.
6234         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6235         (mi_cmd_catch_throw): New function.
6236         (mi_cmd_catch_rethrow): New function.
6237         (mi_cmd_catch_catch): New function.
6238         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6239         'catch-catch' entries.
6240         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6241         (mi_cmd_catch_rethrow): Declare.
6242         (mi_cmd_catch_catch): Declare.
6243
6244 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6245
6246         * annotate.c (annotate_source_line): Change return type to void,
6247         update implementation to match.
6248         * annotate.h (annotate_source_line): Change return type to void,
6249         update header comment.
6250         * stack.c (print_frame_info): Don't change what frame information
6251         is printed based on whether annotations are on or not.
6252
6253 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6256         (annotate_source): Make static.
6257         (annotate_source_line): Moved from source.c and renamed from
6258         identify_source_line.  Update the return type.
6259         * annotate.h (annotate_source): Delete declaration.
6260         (annotate_source_line): Declaration moved from source.h, and
6261         renamed from identify_source_line.  Return type updated.
6262         * source.c (identify_source_line): Moved to annotate.c and renamed
6263         to annotate_source_line.
6264         (info_line_command): Remove check of annotation_level.
6265         * source.h (identify_source_line): Move declaration to annotate.h
6266         and rename to annotate_source_line.
6267         * stack.c: Add 'annotate.h' include.
6268         (print_frame_info): Remove check of annotation_level before
6269         calling annotate_source_line.
6270
6271 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6272
6273         * source-cache.c (source_cache::get_plain_source_lines): Use
6274         open_source_file_with_line_charpos instead of just
6275         open_source_file, remove call to find_source_lines.
6276         (source_cache::get_source_lines): Likewise.
6277         * source.c (find_source_lines): Make static.
6278         (get_filename_and_charpos): Renamed into...
6279         (open_source_file_with_line_charpos): ..this along with changes to
6280         return a scoped_fd, and some other minor clean ups.
6281         (identify_source_line): Use open_source_file_with_line_charpos.
6282         (search_command_helper): Use open_source_file_with_line_charpos
6283         instead of just open_source_file, remove call to
6284         find_source_lines.
6285         * source.h (open_source_file_with_line_charpos): Declare new
6286         function.
6287         (find_source_lines): Delete declaration.
6288
6289 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6290
6291         * source.c (get_filename_and_charpos): Remove fullname
6292         parameter.
6293         (identify_source_line): Update call to get_filename_and_charpos.
6294
6295 2019-06-14  Tom Tromey  <tromey@adacore.com>
6296
6297         PR gdb/24502:
6298         * ui-style.h (skip_ansi_escape): Update comment.
6299         * ui-file.h (class no_terminal_escape_file): New class.
6300         * ui-file.c (no_terminal_escape_file::write)
6301         (no_terminal_escape_file::puts): New methods.
6302         * cli/cli-logging.c (handle_redirections): Use
6303         no_terminal_escape_file.
6304
6305 2019-06-14  Tom Tromey  <tromey@adacore.com>
6306
6307         * NEWS: Move convenience variable news above Python news.
6308
6309 2019-06-14  Tom Tromey  <tom@tromey.com>
6310
6311         * gnulib: Move directory to top-level.
6312         * configure.ac: Don't configure gnulib.
6313         * configure: Rebuild.
6314         * common/common-defs.h: Use new path to gnulib.
6315         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6316         (GNULIB_H): Remove.
6317         (INCGNU): Look in new gnulib location.
6318         (HFILES_NO_SRCDIR): Remove gnulib files.
6319         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6320         (generated_files): Remove GNULIB_H.
6321         ($(LIBGNU), all-lib): Remove targets.
6322         (distclean): Don't mention GNULIB_BUILDDIR.
6323         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6324
6325 2019-06-14  Tom Tromey  <tromey@adacore.com>
6326
6327         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6328         Warn if symbol file does not provide any symbols.
6329
6330 2019-06-14  Tom Tromey  <tromey@adacore.com>
6331
6332         * source.c (find_and_open_source): Respect basenames_may_differ.
6333
6334 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6335
6336         * annotate.c (annotate_breakpoints_invalid): Make use of
6337         scoped_restore_terminal_state.
6338         (annotate_frames_invalid): Likewise.
6339
6340 2019-06-14  Tom Tromey  <tromey@adacore.com>
6341
6342         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6343         allow assignment to an internalvar.
6344
6345 2019-06-14  Tom Tromey  <tromey@adacore.com>
6346
6347         * ada-lex.l: Allow "_" in attribute names.
6348
6349 2019-06-14  Tom Tromey  <tromey@adacore.com>
6350
6351         PR gdb/24653:
6352         * regcache.c (registers_changed): Don't call alloca.
6353         * top.c (execute_command): Don't call alloca.
6354
6355 2019-06-13  Pedro Alves  <palves@redhat.com>
6356
6357         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6358         'expression'.  When parsing an expression, error out if there's
6359         junk after "unlimited".
6360         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6361         (do_set_command): Adjust calls to is_unlimited_literal.
6362
6363 2019-06-13  Pedro Alves  <palves@redhat.com>
6364
6365         * compile/compile.c (make_compile_options_def_group): Add braces
6366         around array_view initializer.
6367         * thread.c (make_thread_apply_all_options_def_group)
6368         (make_thread_apply_all_options_def_group): Likewise.
6369
6370 2019-06-13  Pedro Alves  <palves@redhat.com>
6371
6372         * NEWS (New commands): Mention "maint test-options
6373         require-delimiter", "maint test-options unknown-is-error", "maint
6374         test-options unknown-is-operand" and "maint show
6375         test-options-completion-result".
6376         (New command options, command completion): New section.
6377         (Completion improvements): New section.
6378         Mention that you can abbreviate "unlimited".
6379
6380 2019-06-13  Pedro Alves  <palves@redhat.com>
6381
6382         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6383         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6384         * unittests/cli-utils-selftests.c (test_parse_flags)
6385         (test_parse_flags_qcs): Delete.
6386         (test_cli_utils): Don't call deleted functions.
6387
6388 2019-06-13  Pedro Alves  <palves@redhat.com>
6389
6390         * thread.c: Include "cli/cli-option.h".
6391         (tp_array_compar_ascending): Global.
6392         (tp_array_compar): Delete function.
6393         (tp_array_compar_ascending, tp_array_compar_descending): New
6394         functions.
6395         (ascending_option_def, qcs_flag_option_def)
6396         (thr_qcs_flags_option_defs)
6397         (make_thread_apply_all_options_def_group)
6398         (make_thread_apply_options_def_group): New.
6399         (thread_apply_all_command): Use gdb::option::process_options.
6400         (thread_apply_command_completer)
6401         (thread_apply_all_command_completer): New.
6402         (thread_apply_command): Use gdb::option::process_options.
6403         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6404         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6405         to generate help text of "thread apply".  Adjust "taas"'s help.
6406         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6407         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6408
6409 2019-06-13  Pedro Alves  <palves@redhat.com>
6410
6411         * thread.c (thread_apply_command): Check for invalid TID with
6412         isdigit instead of !isalpha.
6413
6414 2019-06-13  Pedro Alves  <palves@redhat.com>
6415
6416         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6417         (validate_flags_qcs): New.
6418         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6419         (validate_flags_qcs): Declare.
6420         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6421         (make_frame_apply_options_def_group): New.
6422         (frame_apply_command_count): Process options with
6423         gdb::option::process_options.
6424         (frame_apply_completer): New.
6425         (frame_apply_level_completer, frame_apply_all_completer)
6426         (frame_apply_completer): New.
6427         (_initialize_stack): Update help of "frame apply", "frame apply
6428         level", "frame apply all" and "faas" to mention supported options
6429         and install command completers.
6430         * stack.h (frame_apply_all_completer): Declare.
6431         * thread.c: Include "stack.h".
6432         (tfaas_command): Add "--".
6433         (_initialize_thread): Update help "tfaas" to mention supported
6434         options and install command completer.
6435
6436 2019-06-13  Pedro Alves  <palves@redhat.com>
6437
6438         * completer.c (complete_nested_command_line): New.
6439         (gdb_completion_word_break_characters_throw): Add assertion.
6440         * completer.h (complete_nested_command_line): Declare.
6441
6442 2019-06-13  Pedro Alves  <palves@redhat.com>
6443
6444         * stack.c (parse_backtrace_qualifiers): New.
6445         (backtrace_command): Use it.
6446         (backtrace_command_completer): Complete on qualifiers.
6447
6448 2019-06-13  Pedro Alves  <palves@redhat.com>
6449
6450         * frame.c: Include "cli/cli-option.h.
6451         (user_set_backtrace_options): New.
6452         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6453         Delete.
6454         (get_prev_frame): Adjust.
6455         (boolean_option_def, uinteger_option_def)
6456         (set_backtrace_option_defs): New.
6457         (_initialize_frame): Adjust and use
6458         gdb::option::add_setshow_cmds_for_options to install "set
6459         backtrace past-main" and "set backtrace past-entry".
6460         * frame.h: Include "cli/cli-option.h".
6461         (struct frame_print_options): Forward declare.
6462         (print_frame_arguments_all, print_frame_arguments_scalars)
6463         (print_frame_arguments_none): Declare.
6464         (print_entry_values): Delete declaration.
6465         (struct frame_print_options, user_frame_print_options): New.
6466         (struct set_backtrace_options): New.
6467         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6468         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6469         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6470         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6471         (list_args_or_locals): Add frame_print_options parameter.
6472         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6473         * python/py-framefilter.c (enumerate_args): Pass down
6474         USER_FRAME_PRINT_OPTIONS.
6475         * stack.c: Include "cli/cli-option.h".
6476         (print_frame_arguments_all, print_frame_arguments_scalars)
6477         (print_frame_arguments_none): Declare.
6478         (print_raw_frame_arguments, print_entry_values): Delete.
6479         (user_frame_print_options): New.
6480         (boolean_option_def, enum_option_def, frame_print_option_defs):
6481         New.
6482         (struct backtrace_cmd_options): New.
6483         (bt_flag_option_def): New.
6484         (backtrace_command_option_defs): New.
6485         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6486         (print_frame_arg, read_frame_arg, print_frame_args)
6487         (print_frame_info, print_frame): Add frame_print_options parameter
6488         and use it.
6489         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6490         (backtrace_command_1): Add frame_print_options and
6491         backtrace_cmd_options parameters and use them.
6492         (make_backtrace_options_def_group): New.
6493         (backtrace_command): Process command options with
6494         gdb::option::process_options.
6495         (backtrace_command_completer): New.
6496         (_initialize_stack): Extend "backtrace"'s help to mention
6497         supported options.  Install completer for "backtrace".
6498         Install some settings commands with add_setshow_cmds_for_options.
6499
6500 2019-06-13  Pedro Alves  <palves@redhat.com>
6501
6502         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6503         and that "set/show print raw frame-arguments" are now deprecated.
6504
6505         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6506         command.
6507         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6508         * stack.c (_initialize_stack): Install "set/show print
6509         raw-frame-arguments", and deprecate "set/show print raw
6510         frame-arguments".
6511         * valprint.c (_initialize_valprint): Deprecate "set/show print
6512         raw".
6513
6514 2019-06-13  Pedro Alves  <palves@redhat.com>
6515
6516         * compile/compile.c (struct compile_options): New.
6517         (compile_flag_option_def, compile_command_option_defs)
6518         (make_compile_options_def_group): New.
6519         (compile_file_command): Handle options with
6520         gdb::option::process_options.
6521         (compile_file_command_completer): New function.
6522         (compile_code_command): Handle options with
6523         gdb::option::process_options.
6524         (compile_code_command_completer): New function.
6525         (_initialize_compiler): Install completers for "compile code" and
6526         "compile file".  Mention available options in "compile code" and
6527         "compile code"'s help.
6528         * completer.c (advance_to_completion_word): New, factored out from
6529         ...
6530         (advance_to_expression_complete_word_point): ... this.
6531         (advance_to_filename_complete_word_point): New.
6532         * completer.h (advance_to_filename_complete_word_point): New
6533         declaration.
6534
6535 2019-06-13  Pedro Alves  <palves@redhat.com>
6536
6537         * compile/compile.c: Include "cli/cli-option.h".
6538         (compile_print_value): Scope data pointer is now a
6539         value_print_options pointer; adjust.
6540         (compile_print_command): Process options.  Scope data pointer is
6541         now a value_print_options pointer; adjust.
6542         (_initialize_compile): Update "compile print"'s help to include
6543         supported options.  Install a completer for "compile print".
6544         * cp-valprint.c (show_vtblprint, show_objectprint)
6545         (show_static_field_print): Delete.
6546         (_initialize_cp_valprint): Don't install "set print
6547         static-members", "set print vtbl", "set print object" here.
6548         * printcmd.c: Include "cli/cli-option.h" and
6549         "common/gdb_optional.h".
6550         (print_command_parse_format): Rework to fill in a
6551         value_print_options instead of a format_data.
6552         (print_value): Change parameter type from format_data pointer to
6553         value_print_options reference.  Adjust.
6554         (print_command_1): Process options.  Adjust to pass down a
6555         value_print_options.
6556         (print_command_completer): New.
6557         (_initialize_printcmd): Install print_command_completer as
6558         handle_brkchars completer for the "print" command.  Update
6559         "print"'s help to include supported options.
6560         * valprint.c: Include "cli/cli-option.h".
6561         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6562         here from cp-valprint.c.
6563         (boolean_option_def, uinteger_option_def)
6564         (value_print_option_defs, make_value_print_options_def_group):
6565         New.  Use gdb::option::add_setshow_cmds_for_options to install
6566         "set print elements", "set print null-stop", "set print repeats",
6567         "set print pretty", "set print union", "set print array", "set
6568         print address", "set print symbol", "set print array-indexes".
6569         * valprint.h: Include <string> and "cli/cli-option.h".
6570         (make_value_print_options_def_group): Declare.
6571         (print_value): Change parameter type from format_data pointer to
6572         value_print_options reference.
6573         (print_command_completer): Declare.
6574
6575 2019-06-13  Pedro Alves  <palves@redhat.com>
6576
6577         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6578         (COMMON_SFILES): Add maint-test-settings.c.
6579         * cli/cli-decode.c (boolean_enums): New global, factored out from
6580         ...
6581         (add_setshow_boolean_cmd): ... here.
6582         * cli/cli-decode.h (boolean_enums): Declare.
6583         * cli/cli-option.c: New file.
6584         * cli/cli-option.h: New file.
6585         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6586         factored out from ...
6587         (parse_cli_boolean_value(const char *)): ... this.
6588         (is_unlimited_literal): Change parameter type to pointer to
6589         pointer.  Adjust and advance ARG pointer.
6590         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6591         (parse_cli_var_enum): New, factored out from ...
6592         (do_set_command): ... this.  Adjust.
6593         * cli/cli-setshow.h (parse_cli_boolean_value)
6594         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6595         (parse_cli_var_enum): Declare.
6596         * cli/cli-utils.c: Include "cli/cli-option.h".
6597         (get_ulongest): New.
6598         * cli/cli-utils.h (get_ulongest): Declare.
6599         (check_for_argument): New overloads.
6600         * maint-test-options.c: New file.
6601
6602 2019-06-13  Pedro Alves  <palves@redhat.com>
6603
6604         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6605         parse a range if "-" is at the end of the string.
6606
6607 2019-06-13  Pedro Alves  <palves@redhat.com>
6608
6609         * cli/cli-setshow.c (parse_auto_binary_operation)
6610         (parse_cli_boolean_value): Don't allow "o".
6611
6612 2019-06-13  Pedro Alves  <palves@redhat.com>
6613
6614         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6615         * NEWS: Mention maint test-settings KIND.
6616         * maint-test-settings.c: New file.
6617
6618 2019-06-13  Pedro Alves  <palves@redhat.com>
6619
6620         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6621         completer.
6622         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6623         "set" completers.
6624
6625 2019-06-13  Pedro Alves  <palves@redhat.com>
6626
6627         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6628         after item.
6629
6630 2019-06-13  Pedro Alves  <palves@redhat.com>
6631
6632         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6633
6634 2019-06-13  Pedro Alves <palves@redhat.com>
6635
6636         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6637         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6638         call.
6639         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6640         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6641         calls.
6642         (check_for_argument): Skip spaces after argument.
6643
6644 2019-06-13  Pedro Alves  <palves@redhat.com>
6645
6646         * thread.c (thread_apply_command): Adjust TID parsing.
6647         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6648         detected before end of string.
6649         (tid_is_in_list): Error out if LIST is invalid.
6650
6651 2019-06-13  Pedro Alves  <palves@redhat.com>
6652
6653         * completer.c (complete_line_internal_1): Rewind completion word
6654         point.
6655         (completion_tracker::advance_custom_word_point_by): Change
6656         parameter type to int.
6657         * completer.h (completion_tracker::advance_custom_word_point_by):
6658         Likewise.
6659
6660 2019-06-13  Pedro Alves  <palves@redhat.com>
6661
6662         * completer.c (advance_to_completion_word): Handle delimiters.
6663
6664 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6665
6666         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6667
6668 2019-06-11  Tom Tromey  <tom@tromey.com>
6669
6670         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6671         (xmalloc_failed): Move to alloc.c.
6672         * alloc.c: New file.
6673         * Makefile.in (COMMON_SFILES): Add alloc.c.
6674
6675 2019-06-11  Tom Tromey  <tom@tromey.com>
6676
6677         * nat/linux-waitpid.c: Don't include server.h.
6678         (linux_debug): Remove.
6679         (my_waitpid): Update.
6680
6681 2019-06-11  Tom Tromey  <tromey@adacore.com>
6682
6683         * infcall.c (_initialize_infcall): Remove trailing newline from
6684         help.
6685         * user-regs.c (_initialize_user_regs): Remove trailing newline
6686         from help.
6687         * typeprint.c (_initialize_typeprint): Remove trailing newline
6688         from help.
6689         * reverse.c (_initialize_reverse): Remove trailing newlines from
6690         help.
6691         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6692         from help.
6693         * language.c (add_set_language_command): Remove trailing newline
6694         from help.
6695         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6696         help.
6697         * disasm.c (_initialize_disasm): Remove trailing newline from
6698         help.
6699         * top.c (init_main): Remove trailing newline from help.
6700         * interps.c (_initialize_interpreter): Remove trailing newline
6701         from help.
6702         * btrace.c (_initialize_btrace): Remove trailing newlines from
6703         help.
6704         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6705         from help.
6706         * python/python.c (_initialize_python): Remove trailing newline
6707         from help.
6708         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6709         help.
6710         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6711         from help.  Reformat some text.
6712         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6713         from help.
6714         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6715         newline from help.
6716
6717 2019-06-11  Tom Tromey  <tromey@adacore.com>
6718
6719         * darwin-nat.c (darwin_decode_exception_message)
6720         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6721
6722 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6723
6724         * valops.c (value_slice): Check for not allocated or not
6725         associated values.
6726
6727 2019-06-10  Tom de Vries  <tdevries@suse.de>
6728
6729         PR gdb/24618
6730         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6731         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6732         invalid.
6733
6734 2019-06-10  Tom de Vries  <tdevries@suse.de>
6735
6736         PR gdb/24611
6737         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6738         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6739
6740 2019-06-10  Tom de Vries  <tdevries@suse.de>
6741
6742         PR symtab/24545
6743         * symtab.c (struct demangled_name_entry): Add language field.
6744         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6745         static minimal symbol".  Set and use language field.
6746
6747 2019-06-10  Tom Tromey  <tromey@adacore.com>
6748
6749         * ada-lang.c (_initialize_ada_language): Update help text.
6750
6751 2019-06-10  Tom Tromey  <tromey@adacore.com>
6752
6753         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6754         with a newline.
6755         * guile/guile.c (handle_boot_error): Don't end warning with a
6756         newline.
6757         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6758         warning with a newline.
6759         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6760         newline.
6761         (s12z_frame_cache): Likewise.
6762         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6763         a newline.
6764         * solib-svr4.c (disable_probes_interface): Don't end warning with
6765         a newline.
6766         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6767         newline.
6768         * python/python.c (do_finish_initialization): Don't end warning
6769         with a newline.
6770
6771 2019-06-10  Tom Tromey  <tom@tromey.com>
6772
6773         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6774         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6775         gdbpy_enter.
6776
6777 2019-06-10  Tom Tromey  <tromey@adacore.com>
6778
6779         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6780         data.
6781         (elf_new_init): Don't call stabsread_new_init.
6782         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6783         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6784         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6785
6786 2019-06-10  Tom de Vries  <tdevries@suse.de>
6787
6788         PR symtab/16264
6789         PR symtab/24517
6790         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6791
6792 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6793
6794         * source.c (find_and_open_source): Also rewrite relative file
6795         names.
6796
6797 2019-04-26  Amos Bird  <amosbird@gmail.com>
6798
6799         * annotate.c (annotate_thread_exited): Add "thread-exited"
6800         annotation.
6801
6802 2019-06-06  Tom Tromey  <tromey@adacore.com>
6803
6804         * maint.h (class scoped_command_stats): Use
6805         DISABLE_COPY_AND_ASSIGN.
6806         <print_time>: New method.
6807         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6808         print_time.
6809         (scoped_command_stats::print_time): New method.
6810
6811 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6812
6813         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6814         instructions of lengths 6 or 8 bytes.
6815
6816 2019-06-04  Pedro Alves  <palves@redhat.com>
6817
6818         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6819
6820         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6821         * breakpoint.c (condition_completer): Likewise.
6822         * cli/cli-dump.c (scan_expression): Likewise.
6823         * common/filestuff.c (mkdir_recursive): Likewise.
6824         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6825         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6826         (gdb_abspath): Likewise.
6827         * compile/compile-cplus-types.c
6828         (compile_cplus_instance::decl_name): Likewise.
6829         * completer.c (complete_explicit_location):
6830         (signal_completer, reg_or_group_completer_1): Likewise.
6831         * cp-support.c (cp_remove_params_if_any): Likewise.
6832         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6833         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6834         * infcmd.c (strip_bg_char): Likewise.
6835         * linespec.c (copy_token_string): Likewise.
6836         * mi/mi-main.c (output_cores): Likewise.
6837         * psymtab.c (psymtab_search_name):
6838         * symfile.c (test_set_ext_lang_command): Likewise.
6839         * target.c (target_fileio_read_stralloc): Likewise.
6840         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6841         * value.c (complete_internalvar): Likewise.
6842
6843 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6844
6845         Add objfile property to gdb.Type.
6846         * NEWS: Mention Python API addition.
6847         * python/py-type.c (typy_get_objfile): New method.
6848
6849 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6850
6851         * NEWS: Mention the new set|show style [title|highlight].
6852         Mention changes to "show style", "help" and "apropos".
6853
6854 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6855
6856         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6857         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6858         instead of print_help_for_command.
6859         (print_doc_of_command): New function.
6860         (help_list): Add 'apropos -v word' suggestion.
6861         (print_help_for_command): Style the command name using title style.
6862         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6863         (_initialize_cli_cmds): Describe -v in apropos_command help.
6864
6865 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6866
6867         * cli/cli-style.h (cli_style_option): Add name in constructor,
6868         add m_name class member, add constructor with intensity,
6869         add name class function.
6870         (cli_style_option::add_setshow_commands): Remove name argument.
6871         (highlight_style, title_style): New styles.
6872         * cli/cli-style.c (do_show): New function that shows a style
6873         characteristic styling the style name with itself.
6874         (set_style_name): New function.
6875         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6876         Update all callers according to the changes in cli/cli-style.h.
6877         * utils.h (fputs_highlighted): New function.
6878         * utils.c (fputs_highlighted): Likewise.
6879
6880 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6881
6882         * NEWS: Mention new pipe command and new convenience variables.
6883
6884 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6885
6886         * cli/cli-cmds.c (pipe_command): New function.
6887         (_initialize_cli_cmds): Call add_com for pipe_command.
6888         Define | as an alias for pipe.
6889         (exit_status_set_internal_vars): New function.
6890         (shell_escape): Call exit_status_set_internal_vars.
6891         cli/cli-decode.c (find_command_name_length): Recognize | as
6892         a single character command.
6893
6894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6895
6896         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6897         top.c (execute_command_to_ui_file): New function, mostly a copy
6898         of execute_command_to_string.
6899         (execute_command_to_string): Implement by calling
6900         execute_command_to_ui_file.
6901
6902 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6903
6904         * top.h (saved_command_line): Remove declaration.
6905         * top.c (previous_saved_command_line, previous_repeat_arguments):
6906         New variables.
6907         (saved_command_line): Make static, define together with other
6908         'repeat variables'.
6909         (dont_repeat): Clear repeat_arguments.
6910         (repeat_previous, get_saved_command_line, save_command_line):
6911         New functions.
6912         (gdb_init): Initialize saved_command_line
6913         and previous_saved_command_line.
6914         * main.c (captured_main_1): Remove saved_command_line initialization.
6915         * event-top.c (handle_line_of_input): Update to use
6916         the new 'repeat' related functions instead of direct access to
6917         saved_command_line.
6918         * command.h (repeat_previous, get_saved_command_line,
6919         save_command_line): New declarations.
6920         (dont_repeat): Add comment.
6921
6922 2019-05-30  Tom Tromey  <tromey@adacore.com>
6923
6924         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6925         Fix comment.
6926         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6927
6928 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6929
6930         PR cli/24587
6931         * completer.c (complete): Initialize variable word.
6932
6933 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6934
6935         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6936         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6937         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6938         'body' is NULL to the outter 'if', protecting the '!is_define'
6939         situation as well.
6940
6941 2019-05-29  Tom Tromey  <tromey@adacore.com>
6942
6943         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6944         (dwarf_unknown): New function.
6945         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6946         (dwarf_type_encoding_name): Use dwarf_unknown.
6947
6948 2019-05-29  Tom Tromey  <tromey@adacore.com>
6949
6950         PR c++/20020:
6951         * cp-valprint.c (cp_print_value_fields): Call
6952         cp_print_static_field inside "try".
6953
6954 2019-05-29  Tom Tromey  <tromey@adacore.com>
6955
6956         * inflow.c (struct terminal_info): Add default operator=.
6957         * configure: Rebuild.
6958         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6959         -Wdeprecated-copy-dtor, -Wredundant-move.
6960
6961 2019-05-29  Tom Tromey  <tromey@adacore.com>
6962
6963         * NEWS: Add entry.
6964         * infcmd.c (print_return_value_1): Handle finish_print
6965         option.
6966         (show_print_finish): New function.
6967         (_initialize_infcmd): Add "set/show print finish" commands.
6968         * valprint.c (user_print_options): Initialize new member.
6969         * valprint.h (struct value_print_options) <finish_print>: New
6970         member.
6971
6972 2019-05-28  Tom Tromey  <tromey@adacore.com>
6973
6974         * ada-lang.c (ada_remove_Xbn_suffix)
6975         (find_old_style_renaming_symbol)
6976         (parse_old_style_renaming): Remove.
6977         (ada_find_renaming_symbol): Don't call
6978         find_old_style_renaming_symbol.
6979         (ada_is_renaming_symbol): Rename from
6980         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6981         bool.  Now static.
6982         (ada_read_var_value): Update and simplify.
6983         * ada-exp.y (write_var_or_type): Remove old code.
6984
6985 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6986
6987         PR gdb/25010
6988         * event-top.c: Remove include comment.
6989         * inflow.c (class scoped_ignore_sigttou): Move from here...
6990         * inflow.h (class scoped_ignore_sigttou): ...to here.
6991         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6992         * top.c:  Remove include comment.
6993
6994 2019-05-27  Tom Tromey  <tom@tromey.com>
6995
6996         * NEWS: Fix typo.
6997
6998 2019-05-22  Tom Tromey  <tromey@adacore.com>
6999
7000         * target.c (target_follow_exec): Constify parameter.
7001         * target-delegates.c: Rebuild.
7002         * remote.c (remote_target::follow_exec): Constify parameter.
7003         * infrun.c (follow_exec): Constify parameter.
7004         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7005         (target_follow_exec): Likewise.
7006
7007 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7008
7009         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7010         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7011
7012 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7013
7014         * NEWS: Add debugredirect and testsuite sections.
7015
7016 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7017
7018         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7019         target descriptions using exclusively floating point register name
7020         aliases.
7021
7022 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7023
7024         PR gdb/18644:
7025         * f-lang.c (build_fortran_types): Handle the case where
7026         gdbarch_floatformat_for_type returns a nullptr.
7027
7028 2019-05-21  Tom de Vries  <tdevries@suse.de>
7029
7030         PR cli/24587
7031         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7032
7033 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7034
7035         PR gdb/18644:
7036         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7037         16-byte floats.
7038         * i386-tdep.c (i386_floatformat_for_type): Use
7039         floatformats_ia64_quad for the 16-byte floating point component
7040         within a fortran 32-byte complex number.
7041
7042 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7043
7044         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7045         delete default constructor.
7046         (find_partial_die): Update to return const struct.
7047         (partial_die_parent_scope): Move variable declaration into scope
7048         of its use and change its type to auto.
7049         (guess_partial_die_structure_name): Likewise.
7050         (partial_die_info::fixup): Likewise.
7051
7052 2019-05-17  Tom Tromey  <tromey@adacore.com>
7053
7054         * source.c (find_and_open_source): Remove cast.
7055
7056 2019-05-17  Tom Tromey  <tromey@adacore.com>
7057
7058         * annotate.c (annotate_source): Make "filename" const.
7059         * annotate.h (annotate_source): Use const.
7060
7061 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7062
7063         * disasm.c (set_disassembler_options): Send errors to stderr.
7064
7065 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7066
7067         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7068         (cli_interp_base::set_logging): Check debug_redirect.
7069         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7070         * cli/cli-logging.c (debug_redirect): Add static variable.
7071         (pop_output_files): Add default param.
7072         (handle_redirections): Print debug setting.
7073         (show_logging_command): Likewise.
7074         (_initialize_cli_logging): Add debugredirect command.
7075         * interps.c (current_interp_set_logging): Add debug_redirect
7076         parameter.
7077         * interps.h (set_logging): Add debug_redirect parameter.
7078         (current_interp_set_logging): Likewise.
7079         * mi/mi-common.h: Likewise.
7080         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7081
7082 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7083             Tom Tromey  <tromey@adacore.com>
7084
7085         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7086         directly.
7087         * cli/cli-interp.h (make_logging_output): Remove declaration.
7088         * cli/cli-logging.c (make_logging_output): Remove function.
7089         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7090         directly.
7091         * ui-file.c (tee_file::tee_file): Remove bools.
7092         (tee_file::~tee_file): Remove deletes.
7093         * ui-file.h (tee_file): Remove bools.
7094
7095 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7096
7097         * mi/mi-cmds.h (mi_cmd_complete): New function.
7098         * mi/mi-main.c (mi_cmd_complete): Likewise.
7099         * mi/mi-cmds.c: Define new MI command -complete.
7100         * NEWS: Mention new -complete command.
7101
7102 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7103
7104         * completer.h (complete): New function.
7105         * completer.c (complete): Likewise.
7106         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7107         function defined in completer.h.
7108
7109 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7110
7111         * MAINTAINERS (Write After Approval): Add myself.
7112
7113 2019-05-17  Tom de Vries  <tdevries@suse.de>
7114
7115         PR gdb/24094
7116         * dwarf2read.c (struct cu_partial_die_info): New struct.
7117         (find_partial_die): Return cu_partial_die_info.
7118         (partial_die_parent_scope, guess_partial_die_structure_name)
7119         (partial_die_info::fixup): Handle new return type of find_partial_die.
7120
7121 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7122
7123         PR breakpoints/24541
7124         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7125         "std::string", simplifying the algorithm.
7126
7127 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7128
7129         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7130         (stap_static_probe_ops::get_probes): Likewise.
7131
7132 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7133
7134         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7135         '-')" and "else if".
7136         (stap_parse_single_operand): Join checks for
7137         "gdbarch_stap_parse_special_token_p" and
7138         "gdbarch_stap_parse_special_token" in the same "if" statement.
7139         Invert check when verifying for operation on register
7140         displacement.
7141
7142 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7143
7144         * stap-probe.c (stap_get_opcode): Update comment.
7145         (stap_get_expected_argument_type): Likewise.
7146         (handle_stap_probe): Likewise.
7147
7148 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7149
7150         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7151         return type to 'bool'.  Adjust comment.  Use 'bool' when
7152         appropriate.
7153         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7154         * stap-probe.c (stap_parse_argument_1): Likewise.
7155         (stap_is_operator): Likewise.
7156         (stap_is_generic_prefix): Likewise.
7157         (stap_is_register_prefix): Likewise.
7158         (stap_is_register_indirection_prefix): Likewise.
7159         (stap_is_integer_prefix): Likewise.
7160         (stap_generic_check_suffix): Likewise.
7161         (stap_check_integer_suffix): Likewise.
7162         (stap_check_register_suffix): Likewise.
7163         (stap_check_register_indirection_suffix): Likewise.
7164         (stap_parse_register_operand): Likewise.
7165         (stap_parse_single_operand): Likewise.
7166         (stap_parse_argument_1): Likewise.
7167         (stap_probe::get_argument_count): Likewise.
7168         (stap_is_operator): Likewise.
7169
7170 2019-05-16  Tom Tromey  <tromey@adacore.com>
7171
7172         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7173         keyword to foreach.
7174
7175 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7176
7177         * linux-thread-db.c (try_thread_db_load_1): Change return type
7178         to bool.
7179         (try_thread_db_load): Likewise.
7180         (try_thread_db_load_from_pdir_1): Likewise.
7181         (try_thread_db_load_from_pdir): Likewise.
7182         (try_thread_db_load_from_sdir): Likewise.
7183         (try_thread_db_load_from_dir): Likewise.
7184         (thread_db_load_search): Likewise.
7185         (has_libpthread): Likewise.
7186         (thread_db_load): Likewise.
7187
7188 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7189
7190         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7191         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7192         NULL, and complain/return if that's the case.
7193
7194 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7195
7196         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7197         (advance, posn, abstract_read_memory): New functions.
7198         [struct mem_read_abstraction]: New struct.
7199         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7200
7201 2019-05-14  Tom Tromey  <tromey@adacore.com>
7202
7203         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7204         value is not lval_memory.
7205
7206 2019-05-14  Tom Tromey  <tromey@adacore.com>
7207
7208         * solib.c (info_sharedlibrary_command): Style the file name.
7209
7210 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7211
7212         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7213         (aarch64_vnv_type): Likewise.
7214         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7215         * common/tdesc.c: Likewise.
7216         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7217         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7218         * features/aarch64-fpu.xml: Add ieee half view.
7219         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7220         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7221         * gdbtypes.h (struct builtin_type): Likewise.
7222         (struct objfile_type): Likewise.
7223
7224 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7225
7226         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7227         typo.
7228         * location.h (string_to_event_location): Likewise.
7229
7230 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7231
7232         GDB 8.3 released.
7233
7234 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7235
7236         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7237         New variable declaration.
7238         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7239         New variable.
7240         (print_one_breakpoint): Use ui_out::test_flags and new global
7241         variable to compute use_fixed_output.
7242         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7243         Remove.
7244         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7245         (mi_multi_location_breakpoint_output_fixed): Remove.
7246         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7247         new variable.
7248         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7249         fix_multi_location_breakpoint_output flag if version >= 3.
7250         * ui-out.h (enum ui_out_flag)
7251         <fix_multi_location_breakpoint_output>: New enumerator.
7252
7253 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7254
7255         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7256
7257 2019-05-10  Tom Tromey  <tromey@adacore.com>
7258
7259         * ada-lang.c (catch_ada_completer): New function.
7260         (_initialize_ada_language): Use it.
7261
7262 2019-05-10  Tom Tromey  <tromey@adacore.com>
7263
7264         * thread.c (print_thread_info): Make "requested_threads" const.
7265         * gdbthread.h (print_thread_info): Make "requested_threads"
7266         const.
7267         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7268         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7269
7270 2019-05-08  Tom Tromey  <tom@tromey.com>
7271
7272         * gdbtypes.c (objfile_type_data): Change type.
7273         (objfile_type, _initialize_gdbtypes): Update.
7274
7275 2019-05-08  Tom Tromey  <tom@tromey.com>
7276
7277         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7278         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7279         (_initialize_dwarf2_frame): Update.
7280
7281 2019-05-08  Tom Tromey  <tom@tromey.com>
7282
7283         * objc-lang.c (objc_objfile_data): Change type.
7284         (find_methods): Update.
7285         (_initialize_objc_lang): Remove.
7286
7287 2019-05-08  Tom Tromey  <tom@tromey.com>
7288
7289         * stabsread.c (rs6000_builtin_type_data): Change type.
7290         (rs6000_builtin_type, _initialize_stabsread): Update.
7291
7292 2019-05-08  Tom Tromey  <tom@tromey.com>
7293
7294         * mips-tdep.c (mips_pdr_data): Remove.
7295         (_initialize_mips_tdep): Update.
7296
7297 2019-05-08  Tom Tromey  <tom@tromey.com>
7298
7299         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7300         (hppa_init_objfile_priv_data, read_unwind_info)
7301         (find_unwind_entry, _initialize_hppa_tdep): Update.
7302
7303 2019-05-08  Tom Tromey  <tom@tromey.com>
7304
7305         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7306         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7307         on obstack.
7308         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7309
7310 2019-05-08  Tom Tromey  <tom@tromey.com>
7311
7312         * mdebugread.c (basic_type_data): Change type.
7313         (basic_type, _initialize_mdebugread): Update.
7314
7315 2019-05-08  Tom Tromey  <tom@tromey.com>
7316
7317         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7318
7319 2019-05-08  Tom Tromey  <tom@tromey.com>
7320
7321         * nto-tdep.c (nto_inferior_data_reg): Change type.
7322         (nto_inferior_data): Update.
7323         (nto_inferior_data_cleanup, nto_new_inferior_data)
7324         (_initialize_nto_tdep): Remove.
7325         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7326
7327 2019-05-08  Tom Tromey  <tom@tromey.com>
7328
7329         * ada-lang.c (struct ada_inferior_data): Add initializers.
7330         (ada_inferior_data): Change type.
7331         (ada_inferior_data_cleanup): Remove.
7332         (get_ada_inferior_data, ada_inferior_exit)
7333         (struct ada_pspace_data): Add initializers, destructor.
7334         (ada_pspace_data_handle): Change type.
7335         (get_ada_pspace_data): Update.
7336         (ada_pspace_data_cleanup): Remove.
7337
7338 2019-05-08  Tom Tromey  <tom@tromey.com>
7339
7340         * coffread.c (struct coff_symfile_info): Add initializers.
7341         (coff_objfile_data_key): Move lower.  Change type.
7342         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7343         Update.
7344         (coff_free_info): Remove.
7345
7346 2019-05-08  Tom Tromey  <tom@tromey.com>
7347
7348         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7349         (fbsd_pspace_data_handle): Move lower.  Change type.
7350         (get_fbsd_pspace_data): Update.
7351         (fbsd_pspace_data_cleanup): Remove.
7352         (_initialize_fbsd_tdep): Update.
7353
7354 2019-05-08  Tom Tromey  <tom@tromey.com>
7355
7356         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7357         (get_ada_tasks_pspace_data): Update.
7358         (ada_tasks_pspace_data_cleanup): Remove.
7359         (_initialize_tasks): Update.
7360         (ada_tasks_inferior_data_handle): Change type.
7361         (get_ada_tasks_inferior_data): Update.
7362         (ada_tasks_inferior_data_cleanup): Remove.
7363         (struct ada_tasks_pspace_data): Add initializers.
7364
7365 2019-05-08  Tom Tromey  <tom@tromey.com>
7366
7367         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7368         * symfile-debug.c (debug_sym_get_probes): Change type.
7369         * stap-probe.c (handle_stap_probe):
7370         (stap_static_probe_ops::get_probes): Change type.
7371         * probe.h (class static_probe_ops) <get_probes>: Change type.
7372         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7373         (parse_probes_in_pspace): Update.
7374         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7375         Update.
7376         (any_static_probe_ops::get_probes): Change type.
7377         * elfread.c (elfread_data): New typedef.
7378         (probe_key): Change type.
7379         (elf_get_probes): Likewise.  Update.
7380         (probe_key_free): Remove.
7381         (_initialize_elfread): Update.
7382         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7383         Change type.
7384         (dtrace_process_dof_probe, dtrace_process_dof)
7385         (dtrace_static_probe_ops::get_probe): Change type.
7386
7387 2019-05-08  Tom Tromey  <tom@tromey.com>
7388
7389         * xcoffread.c (struct xcoff_symfile_info): Rename from
7390         coff_symfile_info.  Add initializers.
7391         (xcoff_objfile_data_key): Move lower.  Change type.
7392         (XCOFF_DATA): Rewrite.
7393         (xcoff_free_info): Remove.
7394         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7395         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7396         (xcoff_initial_scan): Update.
7397
7398 2019-05-08  Tom Tromey  <tom@tromey.com>
7399
7400         * solib-svr4.c (struct svr4_info): Add initializers and
7401         destructor.
7402         <probes_table>: Now an htab_up.
7403         (solib_svr4_pspace_data): Change type.
7404         (free_probes_table): Simplify.
7405         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7406         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7407         (probes_table_remove_objfile_probes, register_solib_event_probe)
7408         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7409         (_initialize_svr4_solib): Update.
7410
7411 2019-05-08  Tom Tromey  <tom@tromey.com>
7412
7413         * remote.c (remote_pspace_data): Change type.
7414         (remote_pspace_data_cleanup): Remove.
7415         (get_remote_exec_file, set_pspace_remote_exec_file)
7416         (_initialize_remote): Update.
7417
7418 2019-05-08  Tom Tromey  <tom@tromey.com>
7419
7420         * breakpoint.c (breakpoint_objfile_key): Change type.
7421         (get_breakpoint_objfile_data): Update.
7422         (free_breakpoint_objfile_data): Remove.
7423         (_initialize_breakpoint): Update.
7424
7425 2019-05-08  Tom Tromey  <tom@tromey.com>
7426
7427         * linux-tdep.c (struct linux_info): Add initializers.
7428         (linux_inferior_data): Move.  Change type.
7429         (invalidate_linux_cache_inf): Update.
7430         (linux_inferior_data_cleanup): Remove.
7431         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7432
7433 2019-05-08  Tom Tromey  <tom@tromey.com>
7434
7435         * auxv.c (auxv_inferior_data): Move.  Change type.
7436         (auxv_inferior_data_cleanup): Remove.
7437         (invalidate_auxv_cache_inf): Rewrite.
7438         (get_auxv_inferior_data, _initialize_auxv): Update.
7439
7440 2019-05-08  Tom Tromey  <tom@tromey.com>
7441
7442         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7443         (symfile_debug_objfile_data_key): Change type.
7444         (symfile_debug_installed, debug_qf_has_symbols)
7445         (debug_qf_find_last_source_symtab)
7446         (debug_qf_forget_cached_source_info)
7447         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7448         (debug_qf_print_stats, debug_qf_dump)
7449         (debug_qf_expand_symtabs_for_function)
7450         (debug_qf_expand_all_symtabs)
7451         (debug_qf_expand_symtabs_with_fullname)
7452         (debug_qf_map_matching_symbols)
7453         (debug_qf_expand_symtabs_matching)
7454         (debug_qf_find_pc_sect_compunit_symtab)
7455         (debug_qf_map_symbol_filenames)
7456         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7457         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7458         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7459         (debug_sym_read_linetable, debug_sym_relocate): Update.
7460         (symfile_debug_free_objfile): Remove.
7461         (install_symfile_debug_logging, _initialize_symfile_debug):
7462         Update.
7463
7464 2019-05-08  Tom Tromey  <tom@tromey.com>
7465
7466         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7467         allocate_on_obstack.
7468         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7469         (get_dwarf2_per_objfile): Update.
7470         (set_dwarf2_per_objfile): Remove.
7471         (dwarf2_has_info, dwarf2_get_section_info): Update.
7472         (dwarf2_free_objfile): Remove.
7473         (_initialize_dwarf2_read): Update.
7474
7475 2019-05-08  Tom Tromey  <tom@tromey.com>
7476
7477         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7478         initializers.
7479         <unsupported_script_warning_printed,
7480         script_not_found_warning_printed>: Now bool.
7481         (auto_load_pspace_data): Change type.
7482         (~auto_load_pspace_info): Rename from
7483         auto_load_pspace_data_cleanup.
7484         (get_auto_load_pspace_data, init_loaded_scripts_info)
7485         (clear_section_scripts, maybe_print_unsupported_script_warning)
7486         (maybe_print_script_not_found_warning, _initialize_auto_load):
7487         Update.
7488
7489 2019-05-08  Tom Tromey  <tom@tromey.com>
7490
7491         * objfiles.c (objfile_pspace_info): Add destructor and
7492         initializers.
7493         (objfiles_pspace_data): Change type.
7494         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7495         (get_objfile_pspace_data): Update.
7496         (objfiles_bfd_data): Change type.
7497         (get_objfile_bfd_data): Update.
7498         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7499
7500 2019-05-08  Tom Tromey  <tom@tromey.com>
7501
7502         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7503         Change type.
7504         (get_catch_syscall_inferior_data): Update.
7505         (catch_syscall_inferior_data_cleanup): Remove.
7506         (_initialize_break_catch_syscall): Update.
7507
7508 2019-05-08  Tom Tromey  <tom@tromey.com>
7509
7510         * inflow.c (struct terminal_info): Add destructor and
7511         initializers.
7512         (inflow_inferior_data): Change type.
7513         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7514         (get_inflow_inferior_data, inflow_inferior_exit)
7515         (swap_terminal_info, _initialize_inflow): Update.
7516
7517 2019-05-08  Tom Tromey  <tom@tromey.com>
7518
7519         * target-dcache.c (target_dcache_cleanup): Remove.
7520         (target_dcache_aspace_key): Change type.
7521         (target_dcache_init_p, target_dcache_invalidate)
7522         (target_dcache_get, target_dcache_get_or_init)
7523         (_initialize_target_dcache): Update.
7524         * dcache.h (struct dcache_deleter): New.
7525
7526 2019-05-08  Tom Tromey  <tom@tromey.com>
7527
7528         * symtab.c (struct symbol_cache): Add destructor and
7529         initializers.
7530         (symbol_cache_key): Move.  Change type.
7531         (make_symbol_cache, free_symbol_cache): Remove.
7532         (get_symbol_cache): Update.
7533         (symbol_cache_cleanup): Remove.
7534         (ALL_PSPACES, symbol_cache_flush)
7535         (maintenance_print_symbol_cache)
7536         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7537         Update.
7538
7539 2019-05-08  Tom Tromey  <tom@tromey.com>
7540
7541         * symtab.c (struct main_info): Add destructor and initializers.
7542         (main_progspace_key): Move.  Change type.
7543         (get_main_info): Update.
7544         (main_info_cleanup): Remove.
7545         (_initialize_symtab): Update.
7546
7547 2019-05-08  Tom Tromey  <tom@tromey.com>
7548
7549         * registry.h (DECLARE_REGISTRY): Define the _key class.
7550
7551 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7552
7553         * NEWS: Merge two 'New commands' sections.
7554
7555 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7556
7557         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7558         parameter and use Ada language definition instead.
7559         (ada_val_print_ptr): Remove unused language parameter.
7560         (ada_val_print_num): Remove language parameter and use Ada language
7561         definition instead.
7562         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7563         parameter.
7564         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7565         parameter and use Ada language definition instead.
7566         (ada_val_print_1): Update all ada_val_print_xxx calls.
7567         Remove language parameter.
7568         (ada_val_print): Update ada_val_print_1 call.
7569
7570 2019-05-08  Tom Tromey  <tromey@adacore.com>
7571
7572         * remote.c (remote_hw_watchpoint_limit)
7573         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7574         Now static.
7575
7576 2019-05-08  Tom Tromey  <tromey@adacore.com>
7577
7578         * maint.c (_initialize_maint_cmds): Move initialization code to
7579         remote.c.
7580         (watchdog, show_watchdog): Move to remote.c.
7581         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7582         "watchdog" static.
7583         (_initialize_remote): Move initialization code from maint.c.
7584         * defs.h (watchdog): Don't declare.
7585
7586 2019-05-08  Tom Tromey  <tromey@adacore.com>
7587
7588         * tui/tui-interp.c: Include main.h.
7589         * interps.c: Include main.h.
7590         * main.h (interpreter_p): Declare.
7591         * defs.h (interpreter_p): Don't declare.
7592
7593 2019-05-08  Tom Tromey  <tromey@adacore.com>
7594
7595         * dwarf2loc.c: Include dwarf2read.h.
7596         * defs.h (read_unsigned_leb128): Don't declare.
7597         * dwarf2read.h (read_unsigned_leb128): Declare.
7598
7599 2019-05-08  Tom Tromey  <tromey@adacore.com>
7600
7601         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7602         method.
7603
7604 2019-05-08  Tom Tromey  <tromey@adacore.com>
7605
7606         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7607         when no wrap column is set.
7608
7609 2019-05-08  Tom Tromey  <tromey@adacore.com>
7610
7611         * c-lang.c (c_get_string): Handle non-C-style arrays.
7612
7613 2019-05-08  Tom Tromey  <tromey@adacore.com>
7614
7615         * typeprint.c (print_offset_data::update): Print the bit offset,
7616         not the number of bits remaining.
7617
7618 2019-05-08  Tom Tromey  <tromey@adacore.com>
7619
7620         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7621         padding at end of comment.
7622
7623 2019-05-08  Tom Tromey  <tromey@adacore.com>
7624
7625         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7626         Compare main types.
7627
7628 2019-05-06  Tom Tromey  <tom@tromey.com>
7629
7630         * common/scoped_mmap.c: Include common-defs.h.
7631         * common/scoped_mmap.h: Don't include config.h.
7632
7633 2019-05-04  Tom Tromey  <tom@tromey.com>
7634
7635         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7636         (struct aarch64_call_info): Add initializers.
7637         <si>: Now a std::vector.
7638         (pass_on_stack, aarch64_push_dummy_call): Update.
7639
7640 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7641             Tom Tromey  <tom@tromey.com>
7642
7643         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7644         (ppc_threads): Now a std::vector.  Now static.
7645         (hwdebug_find_thread_points_by_tid)
7646         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7647         Update.
7648
7649 2019-05-04  Tom Tromey  <tom@tromey.com>
7650
7651         * arc-tdep.c (arc_tdesc_init): Return bool.
7652
7653 2019-05-04  Tom Tromey  <tom@tromey.com>
7654
7655         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7656         Use gdb_assert_not_reached.
7657
7658 2019-05-04  Tom Tromey  <tom@tromey.com>
7659
7660         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7661         "false".
7662
7663 2019-05-04  Tom Tromey  <tom@tromey.com>
7664
7665         * arc-tdep.c (arc_tdesc_init): Use bool.
7666
7667 2019-05-04  Tom Tromey  <tom@tromey.com>
7668
7669         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7670
7671 2019-05-04  Tom Tromey  <tom@tromey.com>
7672
7673         * cli/cli-cmds.c (valid_command_p): Return bool.
7674
7675 2019-05-04  Tom Tromey  <tom@tromey.com>
7676
7677         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7678         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7679
7680 2019-05-04  Raul Tambre  <raul@tambre.ee>
7681
7682         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7683         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7684         operator for comparison.
7685
7686 2019-05-04  Tom Tromey  <tom@tromey.com>
7687
7688         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7689         (lookup_partial_symbol, print_partial_symbols)
7690         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7691         (psymbol_compare): Update.
7692         (add_psymbol_to_bcache): Clear the entire psymbol.
7693         (maintenance_check_psymtabs): Update.
7694         * psympriv.h (struct partial_symbol): Don't derive from
7695         general_symbol_info.
7696         <obj_section, unrelocated_address, address,
7697         set_unrelocated_address>: Update.
7698         <ginfo>: New member.
7699         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7700         (debug_names::write_psymbols): Update.
7701
7702 2019-05-04  Tom de Vries  <tdevries@suse.de>
7703
7704         * contrib/cc-with-tweaks.sh: Support -n arg.
7705
7706 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7707
7708         * corelow.c (core_target::detach): Ensure frame cache and
7709         register caches are cleared.
7710         inferior.c (exit_inferior_1): Likewise.
7711
7712 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7713             Tom Tromey  <tom@tromey.com>
7714
7715         * dictionary.c (collate_pending_symbols_by_language): Remove
7716         "struct" from foreach.
7717         * symtab.c (lookup_global_symbol_from_objfile)
7718         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7719         foreach.
7720         * ser-tcp.c (net_open): Remove "struct" from foreach.
7721         * objfiles.c (objfile_relocate, objfile_rebase)
7722         (objfile_has_symbols): Remove "struct" from foreach.
7723         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7724         from foreach.
7725         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7726         foreach.
7727         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7728         "struct" from foreach.
7729         * ada-lang.c (create_excep_cond_exprs)
7730         (ada_exception_catchpoint_cond_string): Remove "struct" from
7731         foreach.
7732
7733 2019-05-03  Tom Tromey  <tromey@adacore.com>
7734
7735         * ada-exp.y (convert_char_literal): Check suffix of each
7736         enumerator.
7737
7738 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7739
7740         PR ada/21406:
7741         * ada-exp.y (yywrap): Don't define.
7742         * ada-lex.l (%option): Add noyywrap
7743         (yywrap): Remove.
7744
7745 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7746
7747         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7748         _WIN32_WINNT to the XP level, unless already defined to a higher
7749         level.
7750
7751         * unittests/parse-connection-spec-selftests.c:
7752         * ser-tcp.c:
7753         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7754         override.
7755
7756         * symfile.c (find_separate_debug_file): Remove colon from the
7757         drive spec of DOS/Windows file names of the target, so that the
7758         file name produced from DEBUGDIR and the target's directory will
7759         be valid on DOS/Windows systems.
7760
7761 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7762
7763         * rust-lang.c (val_print_struct): Handle printing structures
7764         containing strings.
7765
7766 2019-05-02  Tom Tromey  <tromey@adacore.com>
7767
7768         * valarith.c (_initialize_valarith): Remove.
7769
7770 2019-05-01  Tom Tromey  <tromey@adacore.com>
7771
7772         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7773         bitfields.
7774
7775 2019-05-01  Tom Tromey  <tromey@adacore.com>
7776
7777         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7778         for big-endian copies.
7779
7780 2019-04-30  Ali Tamur  <tamur@google.com>
7781         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7782         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7783         (read_3_bytes): New function.
7784
7785 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7786
7787         * windows-nat.c (main_thread_id): Delete.
7788         (handle_output_debug_string): Replace main_thread_id by
7789         current_event.dwThreadId.
7790         (fake_create_process): Likewise.
7791         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7792         Do not set main_thread_id.
7793         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7794         current_event.dwThreadId.
7795         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7796
7797 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7798
7799         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7800         Use current_event.dwThreadId instead of main_thread_id.
7801
7802 2019-04-30  Tom Tromey  <tromey@adacore.com>
7803
7804         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7805         (create_excep_cond_exprs): Iterate over program spaces.
7806         (ada_exception_catchpoint_cond_string): Examine all minimal
7807         symbols for exception types.
7808
7809 2019-04-30  Tom Tromey  <tromey@adacore.com>
7810
7811         PR c++/24470:
7812         * dwarf2read.c (process_structure_scope): Handle case where type
7813         has template parameters but no symbol was created.
7814
7815 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7816             Chris January  <chris.january@arm.com>
7817
7818         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7819         qualifier.
7820         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7821
7822 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * f-typeprint.c (f_print_type): Update rules for printing
7825         whitespace.
7826         (f_type_print_varspec_suffix): Likewise.
7827
7828 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7829             Chris January  <chris.january@arm.com>
7830
7831         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7832         function arguments.
7833
7834 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7835
7836         * f-lang.c (build_fortran_types): Change name of void type to
7837         lower case.
7838         * f-typeprint.c (f_type_print_base): Print the name of the void
7839         type, rather than a fixed string.
7840         * f-valprint.c (f_decorations): Use lower case void string.
7841
7842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7843             Chris January  <chris.january@arm.com>
7844
7845         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7846         types for Fortran.
7847
7848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7849             Chris January  <chris.january@arm.com>
7850             David Lecomber  <david.lecomber@arm.com>
7851
7852         * f-exp.y (BINOP_INTRINSIC): New token.
7853         (exp): New parser rule handling BINOP_INTRINSIC.
7854         (f77_keywords): Add new builtin procedures.
7855         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7856         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7857         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7858         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7859         (print_unop_subexp_f): New function.
7860         (print_binop_subexp_f): New function.
7861         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7862         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7863         (dump_subexp_body_f): Likewise.
7864         (operator_check_f): Likewise.
7865         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7866         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7867
7868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7869
7870         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7871         UNOP_KIND.
7872         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7873         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7874         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7875         (operator_length_f): New fuction.
7876         (print_subexp_f): New function.
7877         (op_name_f): New function.
7878         (dump_subexp_body_f): New function.
7879         (operator_check_f): New function.
7880         (exp_descriptor_f): Replace standard expression handling functions
7881         with new functions.
7882         * gdb/fortran-operator.def: New file.
7883         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7884         * gdb/std-operator.def: Remove UNOP_KIND.
7885
7886 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7887
7888         * std-operator.def: Remove unbalanced, stray double quote
7889         character.
7890
7891 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7892             Chris January  <chris.january@arm.com>
7893             Daniel Everett  <daniel.everett@arm.com>
7894             Nick Forrington  <nick.forrington@arm.com>
7895             Richard Bunt  <richard.bunt@arm.com>
7896
7897         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7898         of depth when printing anonymous structs or unions.
7899         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7900         Don't print either the top-level value, or the children if the
7901         max-depth is exceeded.
7902         (ppscm_print_children): When printing the key of a map, allow one
7903         extra level of depth.
7904         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7905         print either the top-level value, or the children if the max-depth
7906         is exceeded.
7907         (print_children): When printing the key of a map, allow one extra
7908         level of depth.
7909         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7910         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7911         (user_print_options): Initialise max_depth field.
7912         (val_print_scalar_or_string_type_p): New function.
7913         (val_print): Check to see if the max depth has been reached.
7914         (val_print_check_max_depth): Define new function.
7915         (show_print_max_depth): New function.
7916         (_initialize_valprint): Add 'print max-depth' option.
7917         * valprint.h (struct value_print_options) <max_depth>: New field.
7918         (val_print_check_max_depth): Declare new function.
7919         * NEWS: Document new feature.
7920
7921 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7922
7923         * ada-lang.c (ada_language_defn): Initialise new field.
7924         * c-lang.c (c_is_string_type_p): New function.
7925         (c_language_defn): Initialise new field.
7926         (cplus_language_defn): Initialise new field.
7927         (asm_language_defn): Initialise new field.
7928         (minimal_language_defn): Initialise new field.
7929         * c-lang.h (c_is_string_type_p): Declare new function.
7930         * d-lang.c (d_language_defn): Initialise new field.
7931         * f-lang.c (f_is_string_type_p): New function.
7932         (f_language_defn): Initialise new field.
7933         * go-lang.c (go_is_string_type_p): New function.
7934         (go_language_defn): Initialise new field.
7935         * language.c (default_is_string_type_p): New function.
7936         (unknown_language_defn): Initialise new field.
7937         (auto_language_defn): Initialise new field.
7938         * language.h (struct language_defn) <la_is_string_type_p>: New
7939         member variable.
7940         (default_is_string_type_p): Declare new function.
7941         * m2-lang.c (m2_language_defn): Initialise new field.
7942         * objc-lang.c (objc_language_defn): Initialise new field.
7943         * opencl-lang.c (opencl_language_defn): Initialise new field.
7944         * p-lang.c (pascal_is_string_type_p): New function.
7945         (pascal_language_defn): Initialise new field.
7946         * rust-lang.c (rust_is_string_type_p): New function.
7947         (rust_language_defn): Initialise new field.
7948
7949 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7950
7951         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7952         New field.
7953         * ada-lang.c (ada_language_defn): Initialise new field.
7954         * c-lang.c (c_language_defn): Likewise.
7955         (cplus_language_defn): Likewise.
7956         (asm_language_defn): Likewise.
7957         (minimal_language_defn): Likewise.
7958         * d-lang.c (d_language_defn): Likewise.
7959         * f-lang.c (f_language_defn): Likewise.
7960         * go-lang.c (go_language_defn): Likewise.
7961         * language.c (unknown_language_defn): Likewise.
7962         (auto_language_defn): Likewise.
7963         * m2-lang.c (m2_language_defn): Likewise.
7964         * objc-lang.c (objc_language_defn): Likewise.
7965         * opencl-lang.c (opencl_language_defn): Likewise.
7966         * p-lang.c (pascal_language_defn): Likewise.
7967         * rust-lang.c (rust_language_defn): Likewise.
7968
7969 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7970
7971         * ada-lang.c (ada_is_character_type): Change return type to bool.
7972         (ada_is_string_type): Likewise.
7973         * ada-lang.h (ada_is_character_type): Update declaration
7974         (ada_is_string_type): Likewise.
7975
7976 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7977
7978         Support style in 'frame|thread apply'
7979
7980         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7981         * record.c (record_start, record_stop): Update callers of
7982         execute_command_to_string with false.
7983         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7984         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7985         methods.
7986         (class string_file): New constructor with term_out parameter.
7987         Override methods term_out and can_emit_style_escape.  New member
7988         term_out.
7989         (class stdio_file): Override can_emit_style_escape.
7990         (class tee_file): Override term_out and can_emit_style_escape.
7991         * utils.h (can_emit_style_escape): Remove.
7992         * utils.c (can_emit_style_escape): Likewise.
7993         Update all callers of can_emit_style_escape (SOMESTREAM) to
7994         SOMESTREAM->can_emit_style_escape.
7995         * source-cache.c (source_cache::get_source_lines): Likewise.
7996         * stack.c (frame_apply_command_count): Call execute_command_to_string
7997         passing the term_out characteristic of the current gdb_stdout.
7998         * thread.c (thr_try_catch_cmd): Likewise.
7999         * top.c (execute_command_to_string): pass term_out parameter
8000         to construct the string_file for the command output.
8001         * ui-file.c (term_cli_styling): New function (most code moved
8002         from utils.c can_emit_style_escape).
8003         (string_file::string_file, string_file::can_emit_style_escape,
8004         stdio_file::can_emit_style_escape, tee_file::term_out,
8005         tee_file::can_emit_style_escape): New functions.
8006
8007 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8008
8009         * NEWS: Mention the new set|show may-call-functions.
8010         * infcall.c (may_call_functions_p): New variable.
8011         (show_may_call_functions_p): New function.
8012         (call_function_by_hand_dummy): Throws an error if not
8013         may-call-functions.
8014         (_initialize_infcall): Call add_setshow_boolean_cmd for
8015         may-call-functions.
8016
8017 2019-04-25  Keith Seitz  <keiths@redhat.com>
8018
8019         PR c++/24367
8020         * cp-support.c (inspect_type): Don't attempt substitutions
8021         of symbol with the same name.
8022
8023 2019-04-25  Tom Tromey  <tromey@adacore.com>
8024
8025         PR gdb/24475:
8026         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8027         static.
8028
8029 2019-04-25  Tom Tromey  <tromey@adacore.com>
8030
8031         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8032         rvalue reference.
8033         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8034         (gdb_xml_parser::parse): Use std::move.
8035         * python/python-internal.h (gdbpy_convert_exception): Take a const
8036         reference.
8037         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8038         std::move.
8039         * python/py-utils.c (gdbpy_convert_exception): Take a const
8040         reference.
8041         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8042         Use std::move.
8043         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8044         Use std::move.
8045         * mi/mi-main.c (mi_print_exception): Take a const reference.
8046         * main.c (handle_command_errors): Take a const reference.
8047         * linespec.c (parse_linespec): Use std::move.
8048         * infcall.c (run_inferior_call): Use std::move.
8049         (call_function_by_hand_dummy): Use std::move.
8050         * exec.c (try_open_exec_file): Use std::move.
8051         * exceptions.h (exception_print, exception_fprintf)
8052         (exception_print_same): Update.
8053         * exceptions.c (print_exception, exception_print)
8054         (exception_fprintf, exception_print_same): Change parameters to
8055         const reference.
8056         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8057         * common/new-op.c: Use std::move.
8058         * common/common-exceptions.h (struct gdb_exception): Add move
8059         constructor.
8060         (struct gdb_exception_error, struct gdb_exception_quit, struct
8061         gdb_quit_bad_alloc): Change constructor to move constructor.
8062         (throw_exception): Change parameter to rvalue reference.
8063         * common/common-exceptions.c (throw_exception): Take rvalue
8064         reference.
8065         * cli/cli-interp.c (safe_execute_command): Use std::move.
8066         * breakpoint.c (insert_bp_location, location_to_sals): Use
8067         std::move.
8068
8069 2019-04-25  Tom Tromey  <tromey@adacore.com>
8070
8071         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8072         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8073         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8074         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8075         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8076         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8077         guile/scm-value.c: Use unpack.
8078         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8079         gdbscm_gdb_exception.
8080         (gdbscm_throw_gdb_exception): Likewise.
8081         (struct gdbscm_gdb_exception): New.
8082         (unpack): New function.
8083         (gdbscm_wrap): Use unpack.
8084
8085 2019-04-25  Tom Tromey  <tromey@adacore.com>
8086
8087         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8088         (gdb_rl_callback_handler): Use std::move.
8089         * common/common-exceptions.h (struct gdb_exception): Add move
8090         assignment operator.
8091         (throw_exception_sjlj): Change "exception" to const reference.
8092         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8093         (throw_exception_sjlj): Change "exception" to const reference.
8094
8095 2019-04-25  Tom Tromey  <tromey@adacore.com>
8096
8097         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8098         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8099         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8100         Update.
8101         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8102         Update.
8103         * mi/mi-interp.c (mi_interp::exec): Update.
8104         * linespec.c (parse_linespec): Update.
8105         * infcall.c (run_inferior_call): Update.
8106         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8107         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8108         (gdbscm_lookup_global_symbol): Update.
8109         * guile/scm-param.c (gdbscm_parameter_value): Update.
8110         * guile/scm-frame.c (gdbscm_frame_read_register)
8111         (gdbscm_frame_read_var): Update.
8112         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8113         * exec.c (try_open_exec_file): Update.
8114         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8115         (gdb_rl_callback_handler): Update.
8116         * common/common-exceptions.h (exception_none): Don't declare.
8117         * common/common-exceptions.c (exception_none): Don't define.
8118         (struct catcher) <exception>: Update.
8119         * cli/cli-interp.c (safe_execute_command): Update.
8120         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8121
8122 2019-04-25  Ali Tamur  <tamur@google.com>
8123
8124         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8125         (read_attribute_value): Likewise.
8126         (dwarf2_read_addr_index): Update comment.
8127         (read_str_index): Add DW_FORM_strx.
8128         (dwarf2_string_attr): Likewise.
8129         (dwarf2_const_value_attr): Likewise.
8130         (dump_die_shallow): Likewise.
8131         (dwarf2_fetch_constant_bytes): Likewise.
8132         (skip_form_bytes): Likewise.
8133         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8134
8135 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8136
8137         PR corefiles/11608
8138         PR corefiles/18187
8139         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8140         OFFSET.  Verify if current mapping contains an ELF header.
8141         (linux_find_memory_regions_full): Adjust call to
8142         dump_mapping_p.
8143
8144 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8145             Kang Li <kanglictf@gmail.com>
8146
8147         PR gdb/21600
8148
8149         * dwarf2-frame.c (read_initial_length): Be consistent about using
8150         unsigned representation of length.
8151         (decode_frame_entry_1): Likewise.  Check for wraparound of
8152         end pointer as well as buffer overflow.
8153
8154 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8155
8156         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8157         "vq".
8158
8159 2019-04-24  Tom Tromey  <tromey@adacore.com>
8160
8161         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8162
8163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8164
8165         * s12z-tdep.c (s12z_unwind_pc): Delete.
8166         (s12z_unwind_sp): Delete.
8167         (s12z_gdbarch_init): Don't register deleted functions with
8168         gdbarch.
8169
8170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8171
8172         * rl78-tdep.c (rl78_unwind_sp): Delete.
8173         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8174
8175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8176
8177         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8178         (xstormy16_unwind_pc): Delete.
8179         (xstormy16_dummy_id): Delete.
8180         (xstormy16_gdbarch_init): Don't register deleted functions with
8181         gdbarch.
8182
8183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8184
8185         * vax-tdep.c (vax_unwind_pc): Delete.
8186         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8187
8188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8189
8190         * v850-tdep.c (v850_unwind_sp): Delete.
8191         (v850_unwind_pc): Delete.
8192         (v850_dummy_id): Delete.
8193         (v850_gdbarch_init): Don't register deleted functions with
8194         gdbarch.
8195
8196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8197
8198         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8199         (tilegx_unwind_pc): Delete.
8200         (tilegx_unwind_dummy_id): Delete.
8201         (tilegx_gdbarch_init): Don't register deleted functions with
8202         gdbarch.
8203
8204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8205
8206         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8207         (tic6x_dummy_id): Delete.
8208         (tic6x_gdbarch_init): Don't register deleted functions with
8209         gdbarch.
8210
8211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8212
8213         * sparc-tdep.c (sparc_unwind_pc): Delete.
8214         (sparc32_gdbarch_init): Don't register deleted function with
8215         gdbarch.
8216
8217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8218
8219         * sh-tdep.c (sh_unwind_sp): Delete.
8220         (sh_unwind_pc): Delete.
8221         (sh_dummy_id): Delete.
8222         (sh_gdbarch_init): Don't register deleted functions with
8223         gdbarch.
8224
8225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8226
8227         * score-tdep.c (score_unwind_sp): Delete.
8228         (score_unwind_pc): Delete.
8229         (score_dummy_id): Delete.
8230         (score_gdbarch_init): Don't register deleted functions with
8231         gdbarch.
8232
8233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8234
8235         * rx-tdep.c (rx_unwind_pc): Delete.
8236         (rx_unwind_sp): Delete.
8237         (rx_dummy_id): Delete.
8238         (rx_gdbarch_init): Don't register deleted functions with
8239         gdbarch.  Update comment.
8240
8241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8242
8243         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8244         (rs6000_dummy_id): Delete.
8245         (rs6000_gdbarch_init): Don't register deleted functions with
8246         gdbarch.
8247
8248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8249
8250         * or1k-tdep.c (or1k_dummy_id): Delete.
8251         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8252
8253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8254
8255         * nios2-tdep.c (nios2_dummy_id): Delete.
8256         (nios2_unwind_sp): Delete.
8257         (nios2_gdbarch_init): Don't register deleted functions with
8258         gdbarch.
8259
8260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8261
8262         * nds32-tdep.c (nds32_dummy_id): Delete.
8263         (nds32_unwind_pc): Delete.
8264         (nds32_unwind_sp): Delete.
8265         (nds32_gdbarch_init): Don't register deleted functions with
8266         gdbarch.
8267
8268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8269
8270         * msp430-tdep.c (msp430_unwind_pc): Delete.
8271         (msp430_unwind_sp): Delete.
8272         (msp430_dummy_id): Delete.
8273         (msp430_gdbarch_init): Don't register deleted functions with
8274         gdbarch.
8275
8276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8277
8278         * moxie-tdep.c (moxie_unwind_sp): Delete.
8279         (moxie_unwind_pc): Delete.
8280         (moxie_dummy_id): Delete.
8281         (moxie_gdbarch_init): Don't register deleted functions with
8282         gdbarch.
8283
8284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8285
8286         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8287         (mn10300_unwind_pc): Delete.
8288         (mn10300_unwind_sp): Delete.
8289         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8290         mn10300_unwind_sp.
8291         (mn10300_frame_unwind_init): Don't register deleted functions with
8292         gdbarch.
8293
8294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8295
8296         * mep-tdep.c (mep_unwind_pc): Delete.
8297         (mep_unwind_sp): Delete.
8298         (mep_dummy_id): Delete.
8299         (mep_gdbarch_init): Don't register deleted functions with
8300         gdbarch.
8301
8302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8303
8304         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8305         (m68hc11_unwind_sp): Delete.
8306         (m68hc11_gdbarch_init): Don't register deleted functions with
8307         gdbarch.
8308
8309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * m32r-tdep.c (m32r_unwind_sp): Delete.
8312         (m32r_unwind_pc): Delete.
8313         (m32r_dummy_id): Delete.
8314         (m32r_gdbarch_init): Don't register deleted functions with
8315         gdbarch.
8316
8317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8318
8319         * m32c-tdep.c (m32c_unwind_pc): Delete.
8320         (m32c_unwind_sp): Delete.
8321         (m32c_dummy_id): Delete.
8322         (m32c_gdbarch_init): Don't register deleted functions with
8323         gdbarch.
8324
8325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8326
8327         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8328         (lm32_unwind_pc): Delete.
8329         (lm32_dummy_id): Delete.
8330         (lm32_gdbarch_init): Don't register deleted functions with
8331         gdbarch.
8332
8333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8334
8335         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8336         (iq2000_unwind_pc): Delete.
8337         (iq2000_dummy_id): Delete.
8338         (iq2000_gdbarch_init): Don't register deleted functions with
8339         gdbarch.
8340
8341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8342
8343         * nds32-tdep.c (nds32_type_align): Delete.
8344         (nds32_push_dummy_call): Use type_align instead.
8345
8346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8347
8348         * arm-tdep.c (arm_type_align): Only handle vector override case.
8349         (arm_push_dummy_call): Use type_align.
8350         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8351
8352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8353
8354         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8355         case.
8356         (pass_on_stack): Use type_align.
8357         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8358         function.
8359
8360 2019-04-23  Tom Tromey  <tromey@adacore.com>
8361
8362         * dwarf2read.c (line_header::file_name_at): Remove unused
8363         overload.
8364
8365 2019-04-23  Tom de Vries  <tdevries@suse.de>
8366
8367         PR gdb/24438
8368         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8369         invocation.
8370
8371
8372 2019-03-27  Ali Tamur  <tamur@google.com>
8373
8374         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8375         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8376         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8377         (dwarf_expr_context::get_addr_index): Likewise
8378         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8379         (symbol_needs_eval_context::get_addr_index): Likewise
8380         (disassemble_dwarf_expression): Add DW_OP_addrx
8381         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8382         (read_cutu_die_from_dwo): Update comment
8383         (skip_one_die): Add DW_FORM_addrx
8384         (read_attribute_value): Likewise
8385         (var_decode_location): Add DW_OP_addrx
8386         (dwarf2_const_value_attr): Add DW_FORM_addrx
8387         (dump_die_shallow): Likewise
8388         (dwarf2_fetch_constant_bytes): Likewise
8389         (decode_locdesc): Add DW_OP_addrx
8390         (skip_form_bytes): Add DW_FORM_addrx
8391
8392 2019-04-22  Ali Tamur  <tamur@google.com>
8393
8394         * MAINTAINERS (Write After Approval): Add self.
8395
8396 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8397
8398         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8399         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8400         (open_symbol_file_object): Likewise.
8401         (svr4_default_sos): Add info parameter.
8402         (svr4_read_so_list): Likewise.
8403         (svr4_current_sos_direct): Adjust functions calls to pass down
8404         info.
8405         (svr4_current_sos_1): Add info parameter.
8406         (svr4_current_sos): Call get_svr4_info, pass info down to
8407         svr4_current_sos_1.
8408         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8409         get_svr4_info.
8410         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8411         get_svr4_info.
8412         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8413         to get_svr4_info.
8414         (probes_table_remove_objfile_probes): Likewise.
8415         (register_solib_event_probe): Add info parameter.
8416         (solist_update_incremental): Pass info parameter down to
8417         svr4_read_so_list.
8418         (disable_probes_interface): Add info parameter.
8419         (svr4_handle_solib_event): Pass current_program_space to
8420         get_svr4_info.  Adjust disable_probes_interface cleanup.
8421         (svr4_create_probe_breakpoints): Add info parameter, pass it
8422         down to register_solib_event_probe.
8423         (svr4_create_solib_event_breakpoints): Add info parameter,
8424         pass it down to svr4_create_probe_breakpoints.
8425         (enable_break): Pass info down to
8426         svr4_create_solib_event_breakpoints.
8427         (svr4_solib_create_inferior_hook): Pass current_program_space to
8428         get_svr4_info.
8429         (svr4_clear_solib): Likewise.
8430
8431 2019-04-22  Pedro Alves  <palves@redhat.com>
8432
8433         * solib-svr4.c (svr4_free_objfile_observer): New.
8434         (probe_and_action::objfile): New field.
8435         (probes_table_htab_remove_objfile_probes)
8436         (probes_table_remove_objfile_probes): New functions.
8437         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8438         in the new probe_and_action.  Don't store the probe in 'lookup'.
8439         (svr4_create_probe_breakpoints): Pass objfile to
8440         register_solib_event_probe.
8441         (_initialize_svr4_solib): Register a free_objfile observer.
8442
8443 2019-04-19  Tom Tromey  <tom@tromey.com>
8444
8445         * common/queue.h: Remove.
8446
8447 2019-04-19  Tom Tromey  <tom@tromey.com>
8448
8449         * event-loop.c: Don't include "common/queue.h".
8450
8451 2019-04-19  Tom Tromey  <tom@tromey.com>
8452
8453         * remote.c (remote_target): Use delete.
8454         * remote-notif.h: Include <list>, not "common/queue.h".
8455         (notif_client_p): Remove typedef.
8456         (remote_notif_state): Add constructor, destructor, initializer.
8457         <notif_queue>: Now a std::list.
8458         (remote_notif_state_xfree): Don't declare.
8459         * remote-notif.c (remote_notif_process, handle_notification)
8460         (remote_notif_state_allocate): Update.
8461         (~remote_notif_state): Rename from remote_notif_state_xfree.
8462
8463 2019-04-19  Tom Tromey  <tom@tromey.com>
8464
8465         * symfile.c (reread_symbols): Update.
8466         * objfiles.c (objfile_register_static_link)
8467         (objfile_lookup_static_link): Update
8468         (~objfile) Don't delete static_links.
8469         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8470
8471 2019-04-19  Tom Tromey  <tom@tromey.com>
8472
8473         * type-stack.h (struct type_stack) <insert>: Constify string.
8474         * type-stack.c (type_stack::insert): Constify string.
8475         * gdbtypes.h (lookup_template_type): Update.
8476         (address_space_name_to_int): Update.
8477         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8478         const.
8479         (lookup_template_type): Make name const.
8480         * c-exp.y: Update rules.
8481         (lex_one_token, classify_name, classify_inner_name)
8482         (c_print_token): Update.
8483         * p-exp.y: Update rules.
8484         (yylex): Update.
8485         * f-exp.y: Update rules.
8486         (yylex): Update.
8487         * d-exp.y: Update rules.
8488         (lex_one_token, classify_name, classify_inner_name): Update.
8489         * parse.c (write_dollar_variable, copy_name): Return std::string.
8490         * parser-defs.h (copy_name): Change return type.
8491         * m2-exp.y: Update rules.
8492         (yylex): Update.
8493         * go-exp.y (lex_one_token): Update.
8494         Update rules.
8495         (classify_unsafe_function, classify_packaged_name)
8496         (classify_name, yylex): Update.
8497
8498 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8499
8500         * configure.ac: add --enable-source-highlight switch.
8501         * configure: Regenerate.
8502         * top.c (print_gdb_version): plumb --enable-source-highlight
8503         status to "show configuration".
8504
8505 2019-04-19  Tom Tromey  <tromey@adacore.com>
8506
8507         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8508         Check ADA_TYPE_P.
8509         (empty_record, ada_template_to_fixed_record_type_1)
8510         (template_to_static_fixed_type)
8511         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8512         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8513         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8514         macros.
8515
8516 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8517
8518         PR symtab/24423:
8519         * source.c (print_source_lines_base): Advance "iter" when a
8520         control character is seen.
8521
8522 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8523
8524         * inferior.h (struct infcall_suspend_state_deleter):
8525         Catch exception in destructor to avoid crash.
8526
8527 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8528
8529         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8530         close to the add_com "shell".
8531
8532 2019-04-18  Tom Tromey  <tromey@adacore.com>
8533
8534         * process-stratum-target.h (class process_stratum_target)
8535         <stratum>: Add "final".
8536
8537 2019-04-17  Tom Tromey  <tromey@adacore.com>
8538
8539         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8540         against nullptr before use.
8541
8542 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8543
8544         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8545
8546 2019-04-17  Jim Wilson  <jimw@sifive.com>
8547             Andrew Burgess  <andrew.burgess@embecosm.com>
8548
8549         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8550         code read might fail, assume 4-byte breakpoint in that case.
8551
8552 2019-04-15  Leszek Swirski  <leszeks@google.com>
8553
8554         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8555         rather than a hand-rolled POD check when checking for forced MEMORY
8556         classification.
8557
8558 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8559
8560         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8561         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8562         function.
8563         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8564         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8565         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8566         declaration.
8567
8568 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8569
8570         * aarch64-linux-nat.c
8571         (aarch64_linux_nat_target::thread_architecture): Add override.
8572         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8573         each VQ.
8574
8575 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8576
8577         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8578
8579 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8580
8581         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8582         target types of size 96-bits, add some additional comments, and
8583         check that the builtin type we found was the correct size.
8584
8585 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8586
8587         * utils.c (prompt_for_continue): Don't restore the styling at the
8588         end, as applied_style has the wrong value.  This fixes styling in
8589         long lists of file names that are interrupted by the "Continue?"
8590         prompt.
8591
8592 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8593
8594         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8595         * c-lang.c (c_language_defn): Likewise.
8596         (cplus_language_defn): Likewise.
8597         (asm_language_defn): Likewise.
8598         (minimal_language_defn): Likewise.
8599         * d-lang.c (d_language_defn): Likewise.
8600         * f-lang.c (f_language_defn): Likewise.
8601         * go-lang.c (go_language_defn): Likewise.
8602         * language.c (unknown_language_defn): Likewise.
8603         (auto_language_defn): Likewise.
8604         * language.h (struct language_defn): Remove la_magic field.
8605         (LANG_MAGIC): Delete.
8606         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8607         * objc-lang.c (objc_language_defn): Likewise.
8608         * opencl-lang.c (opencl_language_defn): Likewise.
8609         * p-lang.c (pascal_language_defn): Likewise.
8610         * rust-lang.c (rust_language_defn): Likewise.
8611
8612 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8613
8614         * riscv-tdep.c (riscv_type_align): New function.
8615         (riscv_type_alignment): Delete.
8616         (riscv_arg_location): Use 'type_align'.
8617         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8618
8619 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8620
8621         * gdbtypes.c (type_align): A struct with no non-static fields also
8622         has alignment of 1.
8623
8624 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8625
8626         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8627         component to 0.
8628         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8629         member.
8630         (riscv_struct_info::analyse): New implementation using new
8631         analyse_inner member function.
8632         (riscv_struct_info::field_offset): New member function.
8633         (riscv_struct_info::m_offsets): New member variable.
8634         (riscv_struct_info::analyse_inner): New private member function,
8635         takes the old implementation of riscv_struct_info::analyse but
8636         extended to track field offsets.
8637         (riscv_call_arg_struct): Update the struct folding special cases
8638         to handle cases where empty C++ structs, which are non-zero
8639         length, are found.
8640         (riscv_arg_location): Initialise the length of each location, a
8641         non-zero length now indicates the location is in use.
8642         (riscv_push_dummy_call): Allow for the first location having a
8643         non-zero offset when setting up arguments.
8644         (riscv_return_value): Likewise, but for return values.
8645
8646 2019-04-11  Tom Tromey  <tromey@adacore.com>
8647
8648         * utils.c (internal_vproblem): Make "msg" const.
8649
8650 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8651
8652         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8653         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8654         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8655         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8656
8657 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8658
8659         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8660         function.
8661         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8662         of amd64_collect_native_gregset.
8663         (amd64_linux_nat_target::store_registers): Likewise.
8664
8665 2019-04-10  Tom Tromey  <tom@tromey.com>
8666
8667         * symtab.c (lookup_global_symbol_from_objfile)
8668         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8669         * objfiles.h (class separate_debug_iterator): New.
8670         (class separate_debug_range): New.
8671         (struct objfile) <separate_debug_objfiles>: New method.
8672         (objfile_separate_debug_iterate): Don't declare.
8673         * objfiles.c (separate_debug_iterator::operator++): Rename from
8674         objfile_separate_debug_iterate.
8675         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8676         iterator.
8677         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8678         iterator.
8679
8680 2019-04-10  Tom Tromey  <tom@tromey.com>
8681
8682         * symfile.c (reread_symbols): Remove old comment.
8683         * objfiles.c (free_all_objfiles): Fix a typo.
8684
8685 2019-04-10  Tom Tromey  <tom@tromey.com>
8686
8687         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8688         * minsyms.c (lookup_minimal_symbol): Use foreach.
8689         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8690         (lookup_minimal_symbol_solib_trampoline): Likewise.
8691         * symfile.c (reread_symbols): Use foreach.
8692
8693 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8694             Tom Tromey  <tromey@adacore.com>
8695
8696         PR rust/24414:
8697         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8698         (rust_lex_int_test): Change "value" to be LONGEST.
8699         (rust_lex_tests): Add test for long integer literal.
8700
8701 2019-04-09  Tom Tromey  <tromey@adacore.com>
8702
8703         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8704         to bool.
8705         (extended_remote_target::attach): Update.
8706         (remote_target::remote_notice_new_inferior): Update.
8707         (remote_target::add_current_inferior_and_thread): Update.
8708         * inferior.c (exit_inferior_1): Use "false".
8709         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8710
8711 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8712
8713         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8714         the "start" command.
8715
8716 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8717
8718         * python/py-inferior.c (infpy_thread_from_thread_handle):
8719         Adjust comments to reflect renaming of thread_from_thread_handle
8720         to thread_from_handle.  Adjust keywords.  Fix type error message.
8721         (inferior_object_methods): Add thread_from_handle.  Retain
8722         thread_from_thread_handle, but mark it as deprecated.
8723
8724 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8725
8726         * gdbthread.h (find_thread_by_handle): Revise declaration.
8727         * thread.c (find_thread_by_handle): Likewise.  Adjust
8728         implementation too.
8729         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8730         support for buffer objects as handles.
8731
8732 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8733
8734         * python/py-infthread.c (thpy_thread_handle): New function.
8735         (thread_object_methods): Register thpy_thread_handle.
8736
8737 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8738
8739         * gdbthread.h (thread_to_thread_handle): Declare.
8740         * thread.c (gdbtypes.h): Include.
8741         (thread_to_thread_handle): New function.
8742
8743         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8744         (target_thread_info_to_thread_handle): Declare.
8745         * target.c (target_thread_info_to_thread_handle): New function.
8746         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8747         * target-delegates.c: Regenerate.
8748
8749         * linux-thread-db.c (class thread_db_target): Add method
8750         thread_info_to_thread_handle.
8751         (thread_db_target::thread_info_to_thread_handle): Define.
8752         * remote.c (class remote_target): Add new method
8753         thread_info_to_thread_handle.
8754         (remote_target::thread_info_to_thread_handle): Define.
8755
8756 2019-04-08  Pedro Alves  <palves@redhat.com>
8757
8758         * common/common-exceptions.c (throw_exception): Don't create
8759         named object to throw; throw directly.
8760         (throw_it): Likewise.  Don't initialize gdb_exception::message
8761         here, with new; pass FMT and AP to the ctor instead.
8762         * common/common-exceptions.h: Include <string>.
8763         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8764         const char *, va_list)): New ctor.  Use std::make_shared.
8765         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8766         errors)): Delete.
8767         (gdb_exception_error::gdb_exception_error(enum errors, const char
8768         *, va_list)): New.
8769         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8770         Add assertion.
8771         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8772         errors)): Delete.
8773         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8774         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8775         Add assertion.
8776
8777 2019-04-08  Tom Tromey  <tom@tromey.com>
8778
8779         * valops.c (value_rtti_indirect_type): Replace throw_exception
8780         with throw.
8781         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8782         with throw.
8783         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8784         throw.
8785         * target.c (target_translate_tls_address): Replace throw_exception
8786         with throw.
8787         * stack.c (frame_apply_command_count): Replace throw_exception
8788         with throw.
8789         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8790         throw.
8791         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8792         with throw.
8793         * rs6000-tdep.c (rs6000_frame_cache)
8794         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8795         * remote.c: Replace throw_exception with throw.
8796         * record-full.c (record_full_message, record_full_wait_1)
8797         (record_full_restore): Replace throw_exception with throw.
8798         * record-btrace.c:
8799         (get_thread_current_frame_id, record_btrace_start_replaying)
8800         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8801         (cmd_record_btrace_start): Replace throw_exception with throw.
8802         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8803         throw.
8804         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8805         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8806         * linespec.c:
8807         (find_linespec_symbols): Replace throw_exception with throw.
8808         * infrun.c (displaced_step_prepare, resume): Replace
8809         throw_exception with throw.
8810         * infcmd.c (post_create_inferior): Replace throw_exception with
8811         throw.
8812         * inf-loop.c (inferior_event_handler): Replace throw_exception
8813         with throw.
8814         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8815         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8816         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8817         (get_prev_frame_always, get_frame_pc_if_available)
8818         (get_frame_address_in_block_if_available, get_frame_language):
8819         Replace throw_exception with throw.
8820         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8821         throw_exception with throw.
8822         * eval.c (fetch_subexp_value, evaluate_var_value)
8823         (evaluate_funcall, evaluate_subexp_standard): Replace
8824         throw_exception with throw.
8825         * dwarf2loc.c (call_site_find_chain)
8826         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8827         Replace throw_exception with throw.
8828         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8829         with throw.
8830         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8831         throw.
8832         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8833         * completer.c (complete_line_internal): Replace throw_exception
8834         with throw.
8835         * compile/compile-object-run.c (compile_object_run): Replace
8836         throw_exception with throw.
8837         * cli/cli-script.c (process_next_line): Replace throw_exception
8838         with throw.
8839         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8840         (btrace_enable, btrace_maint_update_pt_packets): Replace
8841         throw_exception with throw.
8842         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8843         throw_exception with throw.
8844         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8845         throw_exception with throw.
8846         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8847         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8848         * aarch64-tdep.c (aarch64_make_prologue_cache)
8849         (aarch64_make_stub_cache): Replace throw_exception with throw.
8850
8851 2019-04-08  Tom Tromey  <tom@tromey.com>
8852
8853         * common/common-exceptions.c (throw_exception): Rename from
8854         throw_exception_cxx.  Remove old copy.  Make argument const.
8855         (throw_it): Create and throw exception objects directly.
8856         * common/common-exceptions.h (throw_exception): Make argument
8857         const.
8858         (struct gdb_exception_error): Add constructor.
8859         (struct gdb_exception_quit): Add constructor.
8860
8861 2019-04-08  Tom Tromey  <tom@tromey.com>
8862
8863         * common/common-exceptions.h (exception_rethrow): Don't declare.
8864         (TRY_SJLJ): Update comment.
8865         (TRY, CATCH, END_CATCH): Remove.
8866         * common/common-exceptions.c (exception_rethrow): Remove.
8867
8868 2019-04-08  Tom Tromey  <tom@tromey.com>
8869
8870         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8871         Remove.
8872         (gdb_exception_error): Rename from
8873         gdb_exception_RETURN_MASK_ERROR.
8874         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8875         (gdb_quit_bad_alloc): Update.
8876         * aarch64-tdep.c: Update.
8877         * ada-lang.c: Update.
8878         * ada-typeprint.c: Update.
8879         * ada-valprint.c: Update.
8880         * amd64-tdep.c: Update.
8881         * arch-utils.c: Update.
8882         * break-catch-throw.c: Update.
8883         * breakpoint.c: Update.
8884         * btrace.c: Update.
8885         * c-varobj.c: Update.
8886         * cli/cli-cmds.c: Update.
8887         * cli/cli-interp.c: Update.
8888         * cli/cli-script.c: Update.
8889         * common/common-exceptions.c: Update.
8890         * common/new-op.c: Update.
8891         * common/selftest.c: Update.
8892         * compile/compile-c-symbols.c: Update.
8893         * compile/compile-cplus-symbols.c: Update.
8894         * compile/compile-object-load.c: Update.
8895         * compile/compile-object-run.c: Update.
8896         * completer.c: Update.
8897         * corelow.c: Update.
8898         * cp-abi.c: Update.
8899         * cp-support.c: Update.
8900         * cp-valprint.c: Update.
8901         * darwin-nat.c: Update.
8902         * disasm-selftests.c: Update.
8903         * dtrace-probe.c: Update.
8904         * dwarf-index-cache.c: Update.
8905         * dwarf-index-write.c: Update.
8906         * dwarf2-frame-tailcall.c: Update.
8907         * dwarf2-frame.c: Update.
8908         * dwarf2loc.c: Update.
8909         * dwarf2read.c: Update.
8910         * eval.c: Update.
8911         * event-loop.c: Update.
8912         * event-top.c: Update.
8913         * exec.c: Update.
8914         * f-valprint.c: Update.
8915         * fbsd-tdep.c: Update.
8916         * frame-unwind.c: Update.
8917         * frame.c: Update.
8918         * gdbtypes.c: Update.
8919         * gnu-v3-abi.c: Update.
8920         * guile/guile-internal.h: Update.
8921         * guile/scm-block.c: Update.
8922         * guile/scm-breakpoint.c: Update.
8923         * guile/scm-cmd.c: Update.
8924         * guile/scm-disasm.c: Update.
8925         * guile/scm-frame.c: Update.
8926         * guile/scm-lazy-string.c: Update.
8927         * guile/scm-math.c: Update.
8928         * guile/scm-param.c: Update.
8929         * guile/scm-ports.c: Update.
8930         * guile/scm-pretty-print.c: Update.
8931         * guile/scm-symbol.c: Update.
8932         * guile/scm-symtab.c: Update.
8933         * guile/scm-type.c: Update.
8934         * guile/scm-value.c: Update.
8935         * i386-linux-tdep.c: Update.
8936         * i386-tdep.c: Update.
8937         * inf-loop.c: Update.
8938         * infcall.c: Update.
8939         * infcmd.c: Update.
8940         * infrun.c: Update.
8941         * jit.c: Update.
8942         * language.c: Update.
8943         * linespec.c: Update.
8944         * linux-fork.c: Update.
8945         * linux-nat.c: Update.
8946         * linux-tdep.c: Update.
8947         * linux-thread-db.c: Update.
8948         * main.c: Update.
8949         * mi/mi-cmd-break.c: Update.
8950         * mi/mi-cmd-stack.c: Update.
8951         * mi/mi-interp.c: Update.
8952         * mi/mi-main.c: Update.
8953         * objc-lang.c: Update.
8954         * p-valprint.c: Update.
8955         * parse.c: Update.
8956         * ppc-linux-tdep.c: Update.
8957         * printcmd.c: Update.
8958         * python/py-arch.c: Update.
8959         * python/py-breakpoint.c: Update.
8960         * python/py-cmd.c: Update.
8961         * python/py-finishbreakpoint.c: Update.
8962         * python/py-frame.c: Update.
8963         * python/py-framefilter.c: Update.
8964         * python/py-gdb-readline.c: Update.
8965         * python/py-inferior.c: Update.
8966         * python/py-infthread.c: Update.
8967         * python/py-lazy-string.c: Update.
8968         * python/py-linetable.c: Update.
8969         * python/py-objfile.c: Update.
8970         * python/py-param.c: Update.
8971         * python/py-prettyprint.c: Update.
8972         * python/py-progspace.c: Update.
8973         * python/py-record-btrace.c: Update.
8974         * python/py-record.c: Update.
8975         * python/py-symbol.c: Update.
8976         * python/py-type.c: Update.
8977         * python/py-unwind.c: Update.
8978         * python/py-utils.c: Update.
8979         * python/py-value.c: Update.
8980         * python/python.c: Update.
8981         * record-btrace.c: Update.
8982         * record-full.c: Update.
8983         * remote-fileio.c: Update.
8984         * remote.c: Update.
8985         * riscv-tdep.c: Update.
8986         * rs6000-aix-tdep.c: Update.
8987         * rs6000-tdep.c: Update.
8988         * rust-exp.y: Update.
8989         * rust-lang.c: Update.
8990         * s390-tdep.c: Update.
8991         * selftest-arch.c: Update.
8992         * solib-dsbt.c: Update.
8993         * solib-frv.c: Update.
8994         * solib-spu.c: Update.
8995         * solib-svr4.c: Update.
8996         * solib.c: Update.
8997         * sparc64-linux-tdep.c: Update.
8998         * stack.c: Update.
8999         * symfile-mem.c: Update.
9000         * symmisc.c: Update.
9001         * target.c: Update.
9002         * thread.c: Update.
9003         * top.c: Update.
9004         * tracefile-tfile.c: Update.
9005         * tui/tui.c: Update.
9006         * typeprint.c: Update.
9007         * unittests/cli-utils-selftests.c: Update.
9008         * unittests/parse-connection-spec-selftests.c: Update.
9009         * valops.c: Update.
9010         * valprint.c: Update.
9011         * value.c: Update.
9012         * varobj.c: Update.
9013         * windows-nat.c: Update.
9014         * x86-linux-nat.c: Update.
9015         * xml-support.c: Update.
9016
9017 2019-04-08  Tom Tromey  <tom@tromey.com>
9018
9019         * xml-support.c: Use C++ exception handling.
9020         * x86-linux-nat.c: Use C++ exception handling.
9021         * windows-nat.c: Use C++ exception handling.
9022         * varobj.c: Use C++ exception handling.
9023         * value.c: Use C++ exception handling.
9024         * valprint.c: Use C++ exception handling.
9025         * valops.c: Use C++ exception handling.
9026         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9027         handling.
9028         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9029         * typeprint.c: Use C++ exception handling.
9030         * tui/tui.c: Use C++ exception handling.
9031         * tracefile-tfile.c: Use C++ exception handling.
9032         * top.c: Use C++ exception handling.
9033         * thread.c: Use C++ exception handling.
9034         * target.c: Use C++ exception handling.
9035         * symmisc.c: Use C++ exception handling.
9036         * symfile-mem.c: Use C++ exception handling.
9037         * stack.c: Use C++ exception handling.
9038         * sparc64-linux-tdep.c: Use C++ exception handling.
9039         * solib.c: Use C++ exception handling.
9040         * solib-svr4.c: Use C++ exception handling.
9041         * solib-spu.c: Use C++ exception handling.
9042         * solib-frv.c: Use C++ exception handling.
9043         * solib-dsbt.c: Use C++ exception handling.
9044         * selftest-arch.c: Use C++ exception handling.
9045         * s390-tdep.c: Use C++ exception handling.
9046         * rust-lang.c: Use C++ exception handling.
9047         * rust-exp.y: Use C++ exception handling.
9048         * rs6000-tdep.c: Use C++ exception handling.
9049         * rs6000-aix-tdep.c: Use C++ exception handling.
9050         * riscv-tdep.c: Use C++ exception handling.
9051         * remote.c: Use C++ exception handling.
9052         * remote-fileio.c: Use C++ exception handling.
9053         * record-full.c: Use C++ exception handling.
9054         * record-btrace.c: Use C++ exception handling.
9055         * python/python.c: Use C++ exception handling.
9056         * python/py-value.c: Use C++ exception handling.
9057         * python/py-utils.c: Use C++ exception handling.
9058         * python/py-unwind.c: Use C++ exception handling.
9059         * python/py-type.c: Use C++ exception handling.
9060         * python/py-symbol.c: Use C++ exception handling.
9061         * python/py-record.c: Use C++ exception handling.
9062         * python/py-record-btrace.c: Use C++ exception handling.
9063         * python/py-progspace.c: Use C++ exception handling.
9064         * python/py-prettyprint.c: Use C++ exception handling.
9065         * python/py-param.c: Use C++ exception handling.
9066         * python/py-objfile.c: Use C++ exception handling.
9067         * python/py-linetable.c: Use C++ exception handling.
9068         * python/py-lazy-string.c: Use C++ exception handling.
9069         * python/py-infthread.c: Use C++ exception handling.
9070         * python/py-inferior.c: Use C++ exception handling.
9071         * python/py-gdb-readline.c: Use C++ exception handling.
9072         * python/py-framefilter.c: Use C++ exception handling.
9073         * python/py-frame.c: Use C++ exception handling.
9074         * python/py-finishbreakpoint.c: Use C++ exception handling.
9075         * python/py-cmd.c: Use C++ exception handling.
9076         * python/py-breakpoint.c: Use C++ exception handling.
9077         * python/py-arch.c: Use C++ exception handling.
9078         * printcmd.c: Use C++ exception handling.
9079         * ppc-linux-tdep.c: Use C++ exception handling.
9080         * parse.c: Use C++ exception handling.
9081         * p-valprint.c: Use C++ exception handling.
9082         * objc-lang.c: Use C++ exception handling.
9083         * mi/mi-main.c: Use C++ exception handling.
9084         * mi/mi-interp.c: Use C++ exception handling.
9085         * mi/mi-cmd-stack.c: Use C++ exception handling.
9086         * mi/mi-cmd-break.c: Use C++ exception handling.
9087         * main.c: Use C++ exception handling.
9088         * linux-thread-db.c: Use C++ exception handling.
9089         * linux-tdep.c: Use C++ exception handling.
9090         * linux-nat.c: Use C++ exception handling.
9091         * linux-fork.c: Use C++ exception handling.
9092         * linespec.c: Use C++ exception handling.
9093         * language.c: Use C++ exception handling.
9094         * jit.c: Use C++ exception handling.
9095         * infrun.c: Use C++ exception handling.
9096         * infcmd.c: Use C++ exception handling.
9097         * infcall.c: Use C++ exception handling.
9098         * inf-loop.c: Use C++ exception handling.
9099         * i386-tdep.c: Use C++ exception handling.
9100         * i386-linux-tdep.c: Use C++ exception handling.
9101         * guile/scm-value.c: Use C++ exception handling.
9102         * guile/scm-type.c: Use C++ exception handling.
9103         * guile/scm-symtab.c: Use C++ exception handling.
9104         * guile/scm-symbol.c: Use C++ exception handling.
9105         * guile/scm-pretty-print.c: Use C++ exception handling.
9106         * guile/scm-ports.c: Use C++ exception handling.
9107         * guile/scm-param.c: Use C++ exception handling.
9108         * guile/scm-math.c: Use C++ exception handling.
9109         * guile/scm-lazy-string.c: Use C++ exception handling.
9110         * guile/scm-frame.c: Use C++ exception handling.
9111         * guile/scm-disasm.c: Use C++ exception handling.
9112         * guile/scm-cmd.c: Use C++ exception handling.
9113         * guile/scm-breakpoint.c: Use C++ exception handling.
9114         * guile/scm-block.c: Use C++ exception handling.
9115         * guile/guile-internal.h: Use C++ exception handling.
9116         * gnu-v3-abi.c: Use C++ exception handling.
9117         * gdbtypes.c: Use C++ exception handling.
9118         * frame.c: Use C++ exception handling.
9119         * frame-unwind.c: Use C++ exception handling.
9120         * fbsd-tdep.c: Use C++ exception handling.
9121         * f-valprint.c: Use C++ exception handling.
9122         * exec.c: Use C++ exception handling.
9123         * event-top.c: Use C++ exception handling.
9124         * event-loop.c: Use C++ exception handling.
9125         * eval.c: Use C++ exception handling.
9126         * dwarf2read.c: Use C++ exception handling.
9127         * dwarf2loc.c: Use C++ exception handling.
9128         * dwarf2-frame.c: Use C++ exception handling.
9129         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9130         * dwarf-index-write.c: Use C++ exception handling.
9131         * dwarf-index-cache.c: Use C++ exception handling.
9132         * dtrace-probe.c: Use C++ exception handling.
9133         * disasm-selftests.c: Use C++ exception handling.
9134         * darwin-nat.c: Use C++ exception handling.
9135         * cp-valprint.c: Use C++ exception handling.
9136         * cp-support.c: Use C++ exception handling.
9137         * cp-abi.c: Use C++ exception handling.
9138         * corelow.c: Use C++ exception handling.
9139         * completer.c: Use C++ exception handling.
9140         * compile/compile-object-run.c: Use C++ exception handling.
9141         * compile/compile-object-load.c: Use C++ exception handling.
9142         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9143         * compile/compile-c-symbols.c: Use C++ exception handling.
9144         * common/selftest.c: Use C++ exception handling.
9145         * common/new-op.c: Use C++ exception handling.
9146         * cli/cli-script.c: Use C++ exception handling.
9147         * cli/cli-interp.c: Use C++ exception handling.
9148         * cli/cli-cmds.c: Use C++ exception handling.
9149         * c-varobj.c: Use C++ exception handling.
9150         * btrace.c: Use C++ exception handling.
9151         * breakpoint.c: Use C++ exception handling.
9152         * break-catch-throw.c: Use C++ exception handling.
9153         * arch-utils.c: Use C++ exception handling.
9154         * amd64-tdep.c: Use C++ exception handling.
9155         * ada-valprint.c: Use C++ exception handling.
9156         * ada-typeprint.c: Use C++ exception handling.
9157         * ada-lang.c: Use C++ exception handling.
9158         * aarch64-tdep.c: Use C++ exception handling.
9159
9160 2019-04-08  Tom Tromey  <tom@tromey.com>
9161
9162         * xml-support.c (gdb_xml_parser::parse): Update.
9163         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9164         * value.c (show_convenience): Update.
9165         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9166         (test_parse_flags_qcs): Update.
9167         * thread.c (thr_try_catch_cmd): Update.
9168         * target.c (target_translate_tls_address): Update.
9169         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9170         (info_frame_command_core, frame_apply_command_count): Update.
9171         * rust-exp.y (rust_lex_exception_test): Update.
9172         * riscv-tdep.c (riscv_print_one_register_info): Update.
9173         * remote.c (remote_target::enable_btrace): Update.
9174         * record-btrace.c (record_btrace_enable_warn): Update.
9175         * python/py-utils.c (gdbpy_convert_exception): Update.
9176         * printcmd.c (do_one_display, print_variable_and_value): Update.
9177         * mi/mi-main.c (mi_print_exception): Update.
9178         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9179         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9180         * linux-nat.c (linux_nat_target::attach): Update.
9181         * linux-fork.c (class scoped_switch_fork_info): Update.
9182         * infrun.c (displaced_step_prepare): Update.
9183         * infcall.c (call_function_by_hand_dummy): Update.
9184         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9185         * gnu-v3-abi.c (print_one_vtable): Update.
9186         * frame.c (get_prev_frame_always): Update.
9187         * f-valprint.c (info_common_command_for_block): Update.
9188         * exec.c (try_open_exec_file): Update.
9189         * exceptions.c (print_exception, exception_print)
9190         (exception_fprintf, exception_print_same): Update.
9191         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9192         * dwarf-index-cache.c (index_cache::store)
9193         (index_cache::lookup_gdb_index): Update.
9194         * darwin-nat.c (maybe_cache_shell): Update.
9195         * cp-valprint.c (cp_print_value_fields): Update.
9196         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9197         (gcc_cplus_symbol_address): Update.
9198         * compile/compile-c-symbols.c (gcc_convert_symbol)
9199         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9200         * common/selftest.c: Update.
9201         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9202         a std::string.
9203         (exception_try_scope_entry, exception_try_scope_exit): Don't
9204         declare.
9205         (struct exception_try_scope): Remove.
9206         (TRY): Don't use exception_try_scope.
9207         (struct gdb_exception): Add constructor, operator=.
9208         <what>: New method.
9209         (struct gdb_exception_RETURN_MASK_ALL)
9210         (struct gdb_exception_RETURN_MASK_ERROR)
9211         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9212         (struct gdb_quit_bad_alloc): Update.
9213         * common/common-exceptions.c (exception_none): Change
9214         initializer.
9215         (struct catcher) <state, exception>: Initialize inline.
9216         <prev>: Remove member.
9217         (current_catcher): Remove.
9218         (catchers): New global.
9219         (exceptions_state_mc_init): Simplify.
9220         (catcher_pop): Remove.
9221         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9222         (try_scope_depth, exception_try_scope_entry)
9223         (exception_try_scope_exit): Remove.
9224         (throw_exception_sjlj): Update.
9225         (exception_messages, exception_messages_size): Remove.
9226         (throw_it): Simplify.
9227         (gdb_exception_sliced_copy): Remove.
9228         (throw_exception_cxx): Update.
9229         * cli/cli-script.c (script_from_file): Update.
9230         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9231         Update.
9232         * ada-valprint.c (ada_val_print): Update.
9233         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9234         (create_excep_cond_exprs): Update.
9235
9236 2019-04-08  Tom Tromey  <tom@tromey.com>
9237
9238         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9239         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9240         (TRY, CATCH, END_CATCH): Remove some definitions.
9241         * common/common-exceptions.c: Don't use GDB_XCPT.
9242         (catcher_list_size): Remove.
9243         (throw_exception, throw_it): Simplify.
9244
9245 2019-04-05  Tom Tromey  <tom@tromey.com>
9246
9247         Revert the header-sorting patch.
9248         * ft32-tdep.c: Revert.
9249         * frv-tdep.c: Revert.
9250         * frv-linux-tdep.c: Revert.
9251         * frame.c: Revert.
9252         * frame-unwind.c: Revert.
9253         * frame-base.c: Revert.
9254         * fork-child.c: Revert.
9255         * findvar.c: Revert.
9256         * findcmd.c: Revert.
9257         * filesystem.c: Revert.
9258         * filename-seen-cache.h: Revert.
9259         * filename-seen-cache.c: Revert.
9260         * fbsd-tdep.c: Revert.
9261         * fbsd-nat.h: Revert.
9262         * fbsd-nat.c: Revert.
9263         * f-valprint.c: Revert.
9264         * f-typeprint.c: Revert.
9265         * f-lang.c: Revert.
9266         * extension.h: Revert.
9267         * extension.c: Revert.
9268         * extension-priv.h: Revert.
9269         * expprint.c: Revert.
9270         * exec.h: Revert.
9271         * exec.c: Revert.
9272         * exceptions.c: Revert.
9273         * event-top.c: Revert.
9274         * event-loop.c: Revert.
9275         * eval.c: Revert.
9276         * elfread.c: Revert.
9277         * dwarf2read.h: Revert.
9278         * dwarf2read.c: Revert.
9279         * dwarf2loc.c: Revert.
9280         * dwarf2expr.h: Revert.
9281         * dwarf2expr.c: Revert.
9282         * dwarf2-frame.c: Revert.
9283         * dwarf2-frame-tailcall.c: Revert.
9284         * dwarf-index-write.h: Revert.
9285         * dwarf-index-write.c: Revert.
9286         * dwarf-index-common.c: Revert.
9287         * dwarf-index-cache.h: Revert.
9288         * dwarf-index-cache.c: Revert.
9289         * dummy-frame.c: Revert.
9290         * dtrace-probe.c: Revert.
9291         * disasm.h: Revert.
9292         * disasm.c: Revert.
9293         * disasm-selftests.c: Revert.
9294         * dictionary.c: Revert.
9295         * dicos-tdep.c: Revert.
9296         * demangle.c: Revert.
9297         * dcache.h: Revert.
9298         * dcache.c: Revert.
9299         * darwin-nat.h: Revert.
9300         * darwin-nat.c: Revert.
9301         * darwin-nat-info.c: Revert.
9302         * d-valprint.c: Revert.
9303         * d-namespace.c: Revert.
9304         * d-lang.c: Revert.
9305         * ctf.c: Revert.
9306         * csky-tdep.c: Revert.
9307         * csky-linux-tdep.c: Revert.
9308         * cris-tdep.c: Revert.
9309         * cris-linux-tdep.c: Revert.
9310         * cp-valprint.c: Revert.
9311         * cp-support.c: Revert.
9312         * cp-namespace.c: Revert.
9313         * cp-abi.c: Revert.
9314         * corelow.c: Revert.
9315         * corefile.c: Revert.
9316         * continuations.c: Revert.
9317         * completer.h: Revert.
9318         * completer.c: Revert.
9319         * complaints.c: Revert.
9320         * coffread.c: Revert.
9321         * coff-pe-read.c: Revert.
9322         * cli-out.h: Revert.
9323         * cli-out.c: Revert.
9324         * charset.c: Revert.
9325         * c-varobj.c: Revert.
9326         * c-valprint.c: Revert.
9327         * c-typeprint.c: Revert.
9328         * c-lang.c: Revert.
9329         * buildsym.c: Revert.
9330         * buildsym-legacy.c: Revert.
9331         * build-id.h: Revert.
9332         * build-id.c: Revert.
9333         * btrace.c: Revert.
9334         * bsd-uthread.c: Revert.
9335         * breakpoint.h: Revert.
9336         * breakpoint.c: Revert.
9337         * break-catch-throw.c: Revert.
9338         * break-catch-syscall.c: Revert.
9339         * break-catch-sig.c: Revert.
9340         * blockframe.c: Revert.
9341         * block.c: Revert.
9342         * bfin-tdep.c: Revert.
9343         * bfin-linux-tdep.c: Revert.
9344         * bfd-target.c: Revert.
9345         * bcache.c: Revert.
9346         * ax-general.c: Revert.
9347         * ax-gdb.h: Revert.
9348         * ax-gdb.c: Revert.
9349         * avr-tdep.c: Revert.
9350         * auxv.c: Revert.
9351         * auto-load.c: Revert.
9352         * arm-wince-tdep.c: Revert.
9353         * arm-tdep.c: Revert.
9354         * arm-symbian-tdep.c: Revert.
9355         * arm-pikeos-tdep.c: Revert.
9356         * arm-obsd-tdep.c: Revert.
9357         * arm-nbsd-tdep.c: Revert.
9358         * arm-nbsd-nat.c: Revert.
9359         * arm-linux-tdep.c: Revert.
9360         * arm-linux-nat.c: Revert.
9361         * arm-fbsd-tdep.c: Revert.
9362         * arm-fbsd-nat.c: Revert.
9363         * arm-bsd-tdep.c: Revert.
9364         * arch-utils.c: Revert.
9365         * arc-tdep.c: Revert.
9366         * arc-newlib-tdep.c: Revert.
9367         * annotate.h: Revert.
9368         * annotate.c: Revert.
9369         * amd64-windows-tdep.c: Revert.
9370         * amd64-windows-nat.c: Revert.
9371         * amd64-tdep.c: Revert.
9372         * amd64-sol2-tdep.c: Revert.
9373         * amd64-obsd-tdep.c: Revert.
9374         * amd64-obsd-nat.c: Revert.
9375         * amd64-nbsd-tdep.c: Revert.
9376         * amd64-nbsd-nat.c: Revert.
9377         * amd64-nat.c: Revert.
9378         * amd64-linux-tdep.c: Revert.
9379         * amd64-linux-nat.c: Revert.
9380         * amd64-fbsd-tdep.c: Revert.
9381         * amd64-fbsd-nat.c: Revert.
9382         * amd64-dicos-tdep.c: Revert.
9383         * amd64-darwin-tdep.c: Revert.
9384         * amd64-bsd-nat.c: Revert.
9385         * alpha-tdep.c: Revert.
9386         * alpha-obsd-tdep.c: Revert.
9387         * alpha-nbsd-tdep.c: Revert.
9388         * alpha-mdebug-tdep.c: Revert.
9389         * alpha-linux-tdep.c: Revert.
9390         * alpha-linux-nat.c: Revert.
9391         * alpha-bsd-tdep.c: Revert.
9392         * alpha-bsd-nat.c: Revert.
9393         * aix-thread.c: Revert.
9394         * agent.c: Revert.
9395         * addrmap.c: Revert.
9396         * ada-varobj.c: Revert.
9397         * ada-valprint.c: Revert.
9398         * ada-typeprint.c: Revert.
9399         * ada-tasks.c: Revert.
9400         * ada-lang.c: Revert.
9401         * aarch64-tdep.c: Revert.
9402         * aarch64-ravenscar-thread.c: Revert.
9403         * aarch64-newlib-tdep.c: Revert.
9404         * aarch64-linux-tdep.c: Revert.
9405         * aarch64-linux-nat.c: Revert.
9406         * aarch64-fbsd-tdep.c: Revert.
9407         * aarch64-fbsd-nat.c: Revert.
9408         * aarch32-linux-nat.c: Revert.
9409
9410 2019-04-05  Tom Tromey  <tom@tromey.com>
9411
9412         * ft32-tdep.c: Sort headers.
9413         * frv-tdep.c: Sort headers.
9414         * frv-linux-tdep.c: Sort headers.
9415         * frame.c: Sort headers.
9416         * frame-unwind.c: Sort headers.
9417         * frame-base.c: Sort headers.
9418         * fork-child.c: Sort headers.
9419         * findvar.c: Sort headers.
9420         * findcmd.c: Sort headers.
9421         * filesystem.c: Sort headers.
9422         * filename-seen-cache.h: Sort headers.
9423         * filename-seen-cache.c: Sort headers.
9424         * fbsd-tdep.c: Sort headers.
9425         * fbsd-nat.h: Sort headers.
9426         * fbsd-nat.c: Sort headers.
9427         * f-valprint.c: Sort headers.
9428         * f-typeprint.c: Sort headers.
9429         * f-lang.c: Sort headers.
9430         * extension.h: Sort headers.
9431         * extension.c: Sort headers.
9432         * extension-priv.h: Sort headers.
9433         * expprint.c: Sort headers.
9434         * exec.h: Sort headers.
9435         * exec.c: Sort headers.
9436         * exceptions.c: Sort headers.
9437         * event-top.c: Sort headers.
9438         * event-loop.c: Sort headers.
9439         * eval.c: Sort headers.
9440         * elfread.c: Sort headers.
9441         * dwarf2read.h: Sort headers.
9442         * dwarf2read.c: Sort headers.
9443         * dwarf2loc.c: Sort headers.
9444         * dwarf2expr.h: Sort headers.
9445         * dwarf2expr.c: Sort headers.
9446         * dwarf2-frame.c: Sort headers.
9447         * dwarf2-frame-tailcall.c: Sort headers.
9448         * dwarf-index-write.h: Sort headers.
9449         * dwarf-index-write.c: Sort headers.
9450         * dwarf-index-common.c: Sort headers.
9451         * dwarf-index-cache.h: Sort headers.
9452         * dwarf-index-cache.c: Sort headers.
9453         * dummy-frame.c: Sort headers.
9454         * dtrace-probe.c: Sort headers.
9455         * disasm.h: Sort headers.
9456         * disasm.c: Sort headers.
9457         * disasm-selftests.c: Sort headers.
9458         * dictionary.c: Sort headers.
9459         * dicos-tdep.c: Sort headers.
9460         * demangle.c: Sort headers.
9461         * dcache.h: Sort headers.
9462         * dcache.c: Sort headers.
9463         * darwin-nat.h: Sort headers.
9464         * darwin-nat.c: Sort headers.
9465         * darwin-nat-info.c: Sort headers.
9466         * d-valprint.c: Sort headers.
9467         * d-namespace.c: Sort headers.
9468         * d-lang.c: Sort headers.
9469         * ctf.c: Sort headers.
9470         * csky-tdep.c: Sort headers.
9471         * csky-linux-tdep.c: Sort headers.
9472         * cris-tdep.c: Sort headers.
9473         * cris-linux-tdep.c: Sort headers.
9474         * cp-valprint.c: Sort headers.
9475         * cp-support.c: Sort headers.
9476         * cp-namespace.c: Sort headers.
9477         * cp-abi.c: Sort headers.
9478         * corelow.c: Sort headers.
9479         * corefile.c: Sort headers.
9480         * continuations.c: Sort headers.
9481         * completer.h: Sort headers.
9482         * completer.c: Sort headers.
9483         * complaints.c: Sort headers.
9484         * coffread.c: Sort headers.
9485         * coff-pe-read.c: Sort headers.
9486         * cli-out.h: Sort headers.
9487         * cli-out.c: Sort headers.
9488         * charset.c: Sort headers.
9489         * c-varobj.c: Sort headers.
9490         * c-valprint.c: Sort headers.
9491         * c-typeprint.c: Sort headers.
9492         * c-lang.c: Sort headers.
9493         * buildsym.c: Sort headers.
9494         * buildsym-legacy.c: Sort headers.
9495         * build-id.h: Sort headers.
9496         * build-id.c: Sort headers.
9497         * btrace.c: Sort headers.
9498         * bsd-uthread.c: Sort headers.
9499         * breakpoint.h: Sort headers.
9500         * breakpoint.c: Sort headers.
9501         * break-catch-throw.c: Sort headers.
9502         * break-catch-syscall.c: Sort headers.
9503         * break-catch-sig.c: Sort headers.
9504         * blockframe.c: Sort headers.
9505         * block.c: Sort headers.
9506         * bfin-tdep.c: Sort headers.
9507         * bfin-linux-tdep.c: Sort headers.
9508         * bfd-target.c: Sort headers.
9509         * bcache.c: Sort headers.
9510         * ax-general.c: Sort headers.
9511         * ax-gdb.h: Sort headers.
9512         * ax-gdb.c: Sort headers.
9513         * avr-tdep.c: Sort headers.
9514         * auxv.c: Sort headers.
9515         * auto-load.c: Sort headers.
9516         * arm-wince-tdep.c: Sort headers.
9517         * arm-tdep.c: Sort headers.
9518         * arm-symbian-tdep.c: Sort headers.
9519         * arm-pikeos-tdep.c: Sort headers.
9520         * arm-obsd-tdep.c: Sort headers.
9521         * arm-nbsd-tdep.c: Sort headers.
9522         * arm-nbsd-nat.c: Sort headers.
9523         * arm-linux-tdep.c: Sort headers.
9524         * arm-linux-nat.c: Sort headers.
9525         * arm-fbsd-tdep.c: Sort headers.
9526         * arm-fbsd-nat.c: Sort headers.
9527         * arm-bsd-tdep.c: Sort headers.
9528         * arch-utils.c: Sort headers.
9529         * arc-tdep.c: Sort headers.
9530         * arc-newlib-tdep.c: Sort headers.
9531         * annotate.h: Sort headers.
9532         * annotate.c: Sort headers.
9533         * amd64-windows-tdep.c: Sort headers.
9534         * amd64-windows-nat.c: Sort headers.
9535         * amd64-tdep.c: Sort headers.
9536         * amd64-sol2-tdep.c: Sort headers.
9537         * amd64-obsd-tdep.c: Sort headers.
9538         * amd64-obsd-nat.c: Sort headers.
9539         * amd64-nbsd-tdep.c: Sort headers.
9540         * amd64-nbsd-nat.c: Sort headers.
9541         * amd64-nat.c: Sort headers.
9542         * amd64-linux-tdep.c: Sort headers.
9543         * amd64-linux-nat.c: Sort headers.
9544         * amd64-fbsd-tdep.c: Sort headers.
9545         * amd64-fbsd-nat.c: Sort headers.
9546         * amd64-dicos-tdep.c: Sort headers.
9547         * amd64-darwin-tdep.c: Sort headers.
9548         * amd64-bsd-nat.c: Sort headers.
9549         * alpha-tdep.c: Sort headers.
9550         * alpha-obsd-tdep.c: Sort headers.
9551         * alpha-nbsd-tdep.c: Sort headers.
9552         * alpha-mdebug-tdep.c: Sort headers.
9553         * alpha-linux-tdep.c: Sort headers.
9554         * alpha-linux-nat.c: Sort headers.
9555         * alpha-bsd-tdep.c: Sort headers.
9556         * alpha-bsd-nat.c: Sort headers.
9557         * aix-thread.c: Sort headers.
9558         * agent.c: Sort headers.
9559         * addrmap.c: Sort headers.
9560         * ada-varobj.c: Sort headers.
9561         * ada-valprint.c: Sort headers.
9562         * ada-typeprint.c: Sort headers.
9563         * ada-tasks.c: Sort headers.
9564         * ada-lang.c: Sort headers.
9565         * aarch64-tdep.c: Sort headers.
9566         * aarch64-ravenscar-thread.c: Sort headers.
9567         * aarch64-newlib-tdep.c: Sort headers.
9568         * aarch64-linux-tdep.c: Sort headers.
9569         * aarch64-linux-nat.c: Sort headers.
9570         * aarch64-fbsd-tdep.c: Sort headers.
9571         * aarch64-fbsd-nat.c: Sort headers.
9572         * aarch32-linux-nat.c: Sort headers.
9573
9574 2019-04-04  Tom Tromey  <tom@tromey.com>
9575
9576         * varobj.c (varobj_create): Update.
9577         * rust-exp.y (struct rust_parser) <update_innermost_block,
9578         lookup_symbol>: New methods.
9579         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9580         Rename.
9581         (rust_parser::rust_lookup_type)
9582         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9583         * printcmd.c (display_command, do_one_display): Update.
9584         * parser-defs.h (struct parser_state) <parser_state>: Add
9585         "tracker" parameter.
9586         (block_tracker): New member.
9587         (class innermost_block_tracker) <innermost_block_tracker>: Add
9588         "types" parameter.
9589         <reset>: Remove method.
9590         (innermost_block): Don't declare.
9591         (null_post_parser): Update.
9592         * parse.c (innermost_block): Remove global.
9593         (write_dollar_variable): Update.
9594         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9595         Remove "tracker_types" parameter.
9596         (parse_expression): Add "tracker" parameter.
9597         (parse_expression_for_completion): Update.
9598         (null_post_parser): Add "tracker" parameter.
9599         * p-exp.y: Update rules.
9600         * m2-exp.y: Update rules.
9601         * language.h (struct language_defn) <la_post_parser>: Add
9602         "tracker" parameter.
9603         * go-exp.y: Update rules.
9604         * f-exp.y: Update rules.
9605         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9606         parameter.
9607         * d-exp.y: Update rules.
9608         * c-exp.y: Update rules.
9609         * breakpoint.c (set_breakpoint_condition): Create an
9610         innermost_block_tracker.
9611         (watch_command_1): Likewise.
9612         * ada-lang.c (resolve): Add "tracker" parameter.
9613         (resolve_subexp): Likewise.
9614         * ada-exp.y (write_var_from_sym): Update.
9615
9616 2019-04-04  Tom Tromey  <tom@tromey.com>
9617
9618         * type-stack.h: New file.
9619         * type-stack.c: New file.
9620         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9621         type-stack.h.
9622         (insert_into_type_stack, insert_type, push_type, push_type_int)
9623         (insert_type_address_space, pop_type, pop_type_int)
9624         (pop_typelist, pop_type_stack, append_type_stack)
9625         (push_type_stack, get_type_stack, push_typelist)
9626         (follow_type_instance_flags, follow_types): Don't declare.
9627         * parse.c (type_stack): Remove global.
9628         (parse_exp_in_context): Update.
9629         (insert_into_type_stack, insert_type, push_type, push_type_int)
9630         (insert_type_address_space, pop_type, pop_type_int)
9631         (pop_typelist, pop_type_stack, append_type_stack)
9632         (push_type_stack, get_type_stack, push_typelist)
9633         (follow_type_instance_flags, follow_types): Remove (moved to
9634         type-stack.c).
9635         * f-exp.y (type_stack): New global.
9636         Update rules.
9637         (push_kind_type, f_parse): Update.
9638         * d-exp.y (type_stack): New global.
9639         Update rules.
9640         (d_parse): Update.
9641         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9642         Update rules.
9643         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9644         (HFILES_NO_SRCDIR): Add type-stack.h.
9645
9646 2019-04-04  Tom Tromey  <tom@tromey.com>
9647
9648         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9649         (rust_parser::convert_ast_to_expression, rust_parse)
9650         (rust_lex_test_completion, rust_lex_tests): Update.
9651         * parser-defs.h (struct expr_completion_state): New.
9652         (struct parser_state) <parser_state>: Add completion parameter.
9653         <mark_struct_expression, mark_completion_tag>: New methods.
9654         <parse_completion, m_completion_state>: New members.
9655         (prefixify_expression, null_post_parser): Update.
9656         (mark_struct_expression, mark_completion_tag): Don't declare.
9657         * parse.c (parse_completion, expout_last_struct)
9658         (expout_tag_completion_type, expout_completion_name): Remove
9659         globals.
9660         (parser_state::mark_struct_expression)
9661         (parser_state::mark_completion_tag): Now methods.
9662         (prefixify_expression): Add last_struct parameter.
9663         (prefixify_subexp): Likewise.
9664         (parse_exp_1): Update.
9665         (parse_exp_in_context): Add cstate parameter.  Update.
9666         (parse_expression_for_completion): Create an
9667         expr_completion_state.
9668         (null_post_parser): Add "completion" parameter.
9669         * p-exp.y: Update rules.
9670         (yylex): Update.
9671         * language.h (struct language_defn) <la_post_parser>: Add
9672         "completing" parameter.
9673         * go-exp.y: Update rules.
9674         (lex_one_token): Update.
9675         * expression.h (parse_completion): Don't declare.
9676         * d-exp.y: Update rules.
9677         (lex_one_token): Update rules.
9678         * c-exp.y: Update rules.
9679         (lex_one_token): Update.
9680         * ada-lang.c (resolve): Add "parse_completion" parameter.
9681         (resolve_subexp): Likewise.
9682         (ada_resolve_function): Likewise.
9683
9684 2019-04-04  Tom Tromey  <tom@tromey.com>
9685
9686         * parser-defs.h (struct parser_state) <start_arglist,
9687         end_arglist>: New methods.
9688         <arglist_len, m_funcall_chain>: New members.
9689         (arglist_len, start_arglist, end_arglist): Don't declare.
9690         * parse.c (arglist_len, funcall_chain): Remove global.
9691         (start_arglist, end_arglist): Remove functions.
9692         (parse_exp_in_context): Update.
9693         * p-exp.y: Update rules.
9694         * m2-exp.y: Update rules.
9695         * go-exp.y: Update rules.
9696         * f-exp.y: Update rules.
9697         * d-exp.y: Update rules.
9698         * c-exp.y: Update rules.
9699
9700 2019-04-04  Tom Tromey  <tom@tromey.com>
9701
9702         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9703         lex_operator, push_back>: New methods.
9704         Update all rules.
9705         (rust_parser::lex_hex, lex_escape): Rename and update.
9706         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9707         (rust_parser::lex_operator): Rename and update.
9708         (rust_parser::lex_number, rustyylex, rustyyerror)
9709         (rust_lex_test_init, rust_lex_test_sequence)
9710         (rust_lex_test_push_back, rust_lex_tests): Update.
9711         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9712         parameter.
9713         <lexptr, prev_lexptr>: New members.
9714         (lexptr, prev_lexptr): Don't declare.
9715         * parse.c (lexptr, prev_lexptr): Remove globals.
9716         (parse_exp_in_context): Update.
9717         * p-exp.y (yylex, yyerror): Update.
9718         * m2-exp.y (parse_number, yylex, yyerror): Update.
9719         * go-exp.y (lex_one_token, yyerror): Update.
9720         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9721         * d-exp.y (lex_one_token, yyerror): Update.
9722         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9723         (lex_one_token, yyerror): Update.
9724         * ada-lex.l (YY_INPUT): Update.
9725         (rewind_to_char): Update.
9726         * ada-exp.y (yyerror): Update.
9727
9728 2019-04-04  Tom Tromey  <tom@tromey.com>
9729
9730         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9731         * parser-defs.h (struct parser_state) <parser_state>: Add new
9732         parameter.
9733         <comma_terminates>: New member.
9734         (comma_terminates): Don't declare global.
9735         * parse.c (comma_terminates): Remove global.
9736         (parse_exp_in_context): Update.
9737         * p-exp.y (yylex): Update.
9738         * m2-exp.y (yylex): Update.
9739         * go-exp.y (lex_one_token): Update.
9740         * f-exp.y (yylex): Update.
9741         * d-exp.y (lex_one_token): Update.
9742         * c-exp.y (lex_one_token): Update.
9743         * ada-lex.l: Update.
9744
9745 2019-04-04  Tom Tromey  <tom@tromey.com>
9746
9747         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9748         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9749         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9750         * parser-defs.h (paren_depth): Don't declare.
9751         * parse.c (paren_depth): Remove global.
9752         (parse_exp_in_context): Update.
9753         * p-exp.y (paren_depth): New global.
9754         (pascal_parse): Initialize it.
9755         * m2-exp.y (paren_depth): New global.
9756         (m2_parse): Initialize it.
9757         * go-exp.y (paren_depth): New global.
9758         (go_parse): Initialize it.
9759         * f-exp.y (paren_depth): New global.
9760         (f_parse): Initialize it.
9761         * d-exp.y (paren_depth): New global.
9762         (d_parse): Initialize it.
9763         * c-exp.y (paren_depth): New global.
9764         (c_parse): Initialize it.
9765         * ada-lex.l (paren_depth): New global.
9766         (lexer_init): Initialize it.
9767
9768 2019-04-04  Tom Tromey  <tom@tromey.com>
9769
9770         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9771         (rust_parser::convert_ast_to_type)
9772         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9773         * parser-defs.h (struct parser_state) <parser_state>: Add
9774         parameters.  Initialize new members.
9775         <expression_context_block, expression_context_pc>: New members.
9776         * parse.c (expression_context_block, expression_context_pc):
9777         Remove globals.
9778         (parse_exp_in_context): Update.
9779         * p-exp.y: Update all rules.
9780         (yylex): Update.
9781         * m2-exp.y: Update all rules.
9782         (yylex): Update.
9783         * go-exp.y (yylex): Update.
9784         * f-exp.y (yylex): Update.
9785         * d-exp.y: Update all rules.
9786         (yylex): Update.
9787         * c-exp.y: Update all rules.
9788         (lex_one_token, classify_name, yylex, c_parse): Update.
9789         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9790
9791 2019-04-04  Tom Tromey  <tom@tromey.com>
9792
9793         * gdbarch.h, gdbarch.c: Rebuild.
9794         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9795         * stap-probe.h:
9796         (struct stap_parse_info): Replace "parser_state" with
9797         "expr_builder".
9798         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9799         (parser_state): New class.
9800         * parse.c (expr_builder): Rename.
9801         (expr_builder::release): Rename.
9802         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9803         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9804         (write_exp_elt_longcst, write_exp_elt_floatcst)
9805         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9806         (write_exp_string_vector, write_exp_bitstring)
9807         (write_exp_msymbol, mark_struct_expression)
9808         (write_dollar_variable)
9809         (insert_type_address_space, increase_expout_size): Replace
9810         "parser_state" with "expr_builder".
9811         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9812         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9813         "parser_state" with "expr_builder".
9814
9815 2019-04-04  Tom Tromey  <tom@tromey.com>
9816
9817         * rust-exp.y: Replace "parse_language" with method call.
9818         * p-exp.y:
9819         (yylex): Replace "parse_language" with method call.
9820         * m2-exp.y:
9821         (yylex): Replace "parse_language" with method call.
9822         * go-exp.y (classify_name): Replace "parse_language" with method
9823         call.
9824         * f-exp.y (yylex): Replace "parse_language" with method call.
9825         * d-exp.y (lex_one_token): Replace "parse_language" with method
9826         call.
9827         * c-exp.y:
9828         (lex_one_token, classify_name, yylex): Replace "parse_language"
9829         with method call.
9830         * ada-exp.y (find_primitive_type, type_char)
9831         (type_system_address): Replace "parse_language" with method call.
9832
9833 2019-04-04  Tom Tromey  <tom@tromey.com>
9834
9835         * rust-exp.y: Replace "parse_gdbarch" with method call.
9836         * parse.c (write_dollar_variable, insert_type_address_space):
9837         Replace "parse_gdbarch" with method call.
9838         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9839         call.
9840         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9841         call.
9842         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9843         "parse_gdbarch" with method call.
9844         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9845         with method call.
9846         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9847         "parse_gdbarch" with method call.
9848         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9849         "parse_gdbarch" with method call.
9850         * c-exp.y (parse_type, parse_number, classify_name): Replace
9851         "parse_gdbarch" with method call.
9852         * ada-lex.l: Replace "parse_gdbarch" with method call.
9853         * ada-exp.y (parse_type, find_primitive_type, type_char)
9854         (type_system_address): Replace "parse_gdbarch" with method call.
9855
9856 2019-04-04  Tom Tromey  <tom@tromey.com>
9857
9858         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9859         * stap-probe.c (stap_parse_argument): Update.
9860         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9861         initial_size parameter.
9862         * rust-exp.y (rust_lex_tests): Update.
9863         * parse.c (parser_state): Update.
9864         (parse_exp_in_context): Update.
9865         * parser-defs.h (struct parser_state) <parser_state>: Remove
9866         "initial_size" parameter.
9867
9868 2019-04-04  Tom Tromey  <tom@tromey.com>
9869
9870         * parser-defs.h (increase_expout_size): Don't declare.
9871         * parse.c (increase_expout_size): Now static.
9872
9873 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9874
9875         * gnu-nat.c (gnu_nat_target::wait): Fix
9876         target_waitstatus_to_string call.
9877
9878 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9879
9880         * eval.c (evaluate_subexp_standard): Handle internal functions
9881         during Fortran function call handling.
9882
9883 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9884
9885         * NEWS: Mention new internal functions.
9886         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9887         (read_base_type): Use dwarf2_init_complex_target_type.
9888         * value.c (creal_internal_fn): New function.
9889         (cimag_internal_fn): New function.
9890         (_initialize_values): Register new internal functions.
9891
9892 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9893
9894         * infrun.c (stop_all_threads): If debug_infrun, always
9895         trace the wait status after wait_one, using
9896         target_waitstatus_to_string and target_pid_to_str.
9897         (handle_inferior_event): Replace various trace of
9898         wait status kind by a single trace.
9899         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9900         wait status kind image by target_waitstatus_to_string.
9901         * target/waitstatus.c (target_waitstatus_to_string): Fix
9902         obsolete comment.
9903
9904 2019-04-01  Tom Tromey  <tromey@adacore.com>
9905
9906         PR symtab/23331:
9907         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9908
9909 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9910             Pedro Alves  <palves@redhat.com>
9911
9912         * top.c (quit_force): Call 'finalize_values'.
9913         * value.c (finalize_values): New function.
9914         * value.h (finalize_values): Declare.
9915
9916 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9917
9918         * NEWS: Announce $_gdb_major and $_gdb_minor.
9919
9920         * top.c (init_gdb_version_vars): New function.
9921         (gdb_init): Call init_gdb_version_vars.
9922
9923 2019-03-29  Tom Tromey  <tromey@adacore.com>
9924
9925         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9926         help text.  Remove dead code.
9927
9928 2019-03-29  Keith Seitz  <keiths@redhat.com>
9929
9930         From Siddhesh Poyarekar:
9931         * f-lang.h (f77_get_upperbound): Return LONGEST.
9932         (f77_get_lowerbound): Likewise.
9933         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9934         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9935         print them.
9936         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9937         plongest to format print it.
9938         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9939         (f77_get_upperbound): Likewise.
9940         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9941         LOWER_BOUND to LONGEST.
9942         (f77_create_arrayprint_offset_tbl): Likewise.
9943
9944 2019-03-29  Keith Seitz  <keiths@redhat.com>
9945
9946         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9947         %s/pulongest for TYPE_LENGTH instead of %d in format
9948         strings.
9949         * ada-typerint.c (ada_print_type): Likewise.
9950         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9951         * compile/compile-c-support.c (generate_register_struct): Likewise.
9952         * gdbtypes.c (recursive_dump_type): Likewise.
9953         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9954         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9955         instead of %d in format strings.
9956         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9957         to std::min to ULONGEST.
9958         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9959         instead of %d in format strings.
9960         * tracepoint.c (info_scope_command): Likewise.
9961         * typeprint.c (print_offset_data::update)
9962         (print_offset_data::finish): Likewise.
9963         * xtensa-tdep.c (xtensa_store_return_value)
9964         (xtensa_push_dummy_call): Likewise.
9965
9966 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9967
9968         * windows-nat.c (display_selector): Fixed format specifications
9969         for 64-bit Cygwin.
9970
9971 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9972
9973         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9974
9975 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9976
9977         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9978         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9979         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9980         (nios2_linux_init_abi): Install it.
9981
9982 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9983
9984         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9985
9986 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9987
9988         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9989
9990 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9991             Tom Tromey  <tromey@adacore.com>
9992
9993         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9994
9995 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9996
9997         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9998         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9999         method to compute the bounds of range types. Also print "[evaluated]"
10000         if the bounds' values come from a dynamic evaluation.
10001
10002 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10003
10004         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10005         whitespace when pretty printing is on.
10006
10007 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10008
10009         * ppc-linux-nat.c: Add include.
10010
10011 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10012
10013         * NEWS: Mention AArch64 Pointer Authentication.
10014
10015 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10016
10017         * arm-linux-nat.c: Add include.
10018
10019 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10020
10021         * source-cache.c (source_cache::get_source_lines): Re-read
10022         fullname after calling open_source_file.
10023
10024 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10025
10026         * NEWS: Mention TLS support for FreeBSD.
10027
10028 2019-03-25  Tom Tromey  <tromey@adacore.com>
10029
10030         * minsyms.c (BUNCH_SIZE): Update comment.
10031         (~minimal_symbol_reader): Remove old comment.
10032         (compact_minimal_symbols): Update comment.
10033         (minimal_symbol_reader::install): Remove old comment.  Update
10034         other comments.
10035
10036 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10037
10038         * s390-linux-nat.c: Add include.
10039
10040 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10041
10042         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10043         Call linux_get_hwcap.
10044         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10045         Likewise.
10046         (aarch64_linux_get_hwcap): Remove function.
10047         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10048         declaration.
10049         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10050         linux_get_hwcap.
10051         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10052         * linux-tdep.c (linux_get_hwcap): Add function.
10053         (linux_get_hwcap2): Likewise.
10054         * linux-tdep.h (linux_get_hwcap): Add declaration.
10055         (linux_get_hwcap2): Likewise.
10056         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10057         (ppc_linux_get_hwcap2): Likewise.
10058         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10059         linux_get_hwcap.
10060         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10061         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10062         (ppc_linux_nat_target::read_description): Likewise.
10063         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10064         * s390-linux-nat.c: Likewise.
10065         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10066
10067 2019-03-24  Tom Tromey  <tom@tromey.com>
10068
10069         * ada-lang.c (standard_lookup): Simplify initialization.
10070         (ada_lookup_symbol_nonlocal): Simplify return.
10071         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10072         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10073         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10074         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10075         initialization.
10076         * solib.c (solib_global_lookup): Simplify.
10077         * symtab.c (null_block_symbol): Remove.
10078         (symbol_cache_lookup): Simplify returns.
10079         (lookup_language_this): Simplify returns.
10080         (lookup_symbol_aux): Simplify return.
10081         (lookup_local_symbol): Simplify returns.
10082         (lookup_global_symbol_from_objfile): Simplify return.
10083         (lookup_symbol_in_objfile_symtabs)
10084         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10085         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10086         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10087         * cp-namespace.c (cp_lookup_bare_symbol)
10088         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10089         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10090         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10091         (cp_lookup_symbol_via_imports): Simplify initialization.
10092         (find_symbol_in_baseclass): Likewise.
10093         * symtab.h (null_block_symbol): Remove.
10094         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10095         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10096         (d_lookup_symbol_module): Likewise.
10097         (find_symbol_in_baseclass): Simplify initialization.
10098
10099 2019-03-24  Tom Tromey  <tom@tromey.com>
10100
10101         * expression.h: Don't include symtab.h.
10102         (struct block): Forward declare.
10103
10104 2019-03-24  Tom Tromey  <tom@tromey.com>
10105
10106         * c-exp.y (typebase): Remove casts.
10107         * gdbtypes.c (lookup_unsigned_typename, )
10108         (lookup_signed_typename): Remove cast.
10109         * eval.c (parse_to_comma_and_eval): Remove cast.
10110         * parse.c (write_dollar_variable): Remove cast.
10111         * block.h (struct block) <superblock>: Now const.
10112         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10113         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10114         (map_block): Make "block" const.
10115         * symfile.h (struct quick_symbol_functions)
10116         <map_matching_symbols>: Constify block argument to "callback".
10117         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10118         const.
10119         (find_pc_sect_compunit_symtab): Make "b" const.
10120         (find_symbol_at_address): Likewise.
10121         (search_symbols): Likewise.
10122         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10123         (dw2_debug_names_lookup_symbol): Likewise.
10124         (dw2_map_matching_symbols): Update.
10125         * p-valprint.c (pascal_val_print): Remove "block".
10126         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10127         (aux_add_nonlocal_symbols): Make "block" const.
10128         (resolve_subexp): Remove cast.
10129         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10130         const.
10131         (iterate_over_file_blocks): Likewise.
10132         * f-exp.y (%union) <bval>: Remove.
10133         * coffread.c (patch_opaque_types): Make "b" const.
10134         * spu-tdep.c (spu_catch_start): Make "block" const.
10135         * c-valprint.c (print_unpacked_pointer): Remove "block".
10136         * symmisc.c (dump_symtab_1): Make "b" const.
10137         (block_depth): Make "block" const.
10138         * d-exp.y (%union) <bval>: Remove.
10139         * cp-support.h (cp_lookup_rtti_type): Update.
10140         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10141         * psymtab.c (psym_lookup_symbol): Make "block" const.
10142         (maintenance_check_psymtabs): Make "b" const.
10143         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10144         (enumerate_locals, enumerate_args): Update.
10145         * python/py-symtab.c (stpy_global_block): Make "block" const.
10146         (stpy_static_block): Likewise.
10147         * inline-frame.c (block_starting_point_at): Make "new_block"
10148         const.
10149         * block.c (find_block_in_blockvector): Make return type const.
10150         (blockvector_for_pc_sect): Make "b" const.
10151         (find_block_in_blockvector): Make "b" const.
10152
10153 2019-03-23  Tom Tromey  <tom@tromey.com>
10154
10155         * varobj.c (varobj_create): Update.
10156         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10157         * printcmd.c (display_command, do_one_display): Don't reset
10158         innermost_block.
10159         * parser-defs.h (enum innermost_block_tracker_type): Move to
10160         expression.h.
10161         (innermost_block): Update comment.
10162         * parse.c (parse_exp_1): Add tracker_types parameter.
10163         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10164         tracker_types parameter.  Reset innermost_block.
10165         (parse_exp_in_context): Remove.
10166         (parse_expression_for_completion): Update.
10167         * objfiles.c (~objfile): Don't reset expression_context_block or
10168         innermost_block.
10169         * expression.h (enum innermost_block_tracker_type): Move from
10170         parser-defs.h.
10171         (parse_exp_1): Add tracker_types parameter.
10172         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10173         reset innermost_block.
10174
10175 2019-03-23  Tom Tromey  <tom@tromey.com>
10176
10177         * objfiles.h: Include bcache.h.
10178
10179 2019-03-23  Tom Tromey  <tom@tromey.com>
10180
10181         * linespec.c (get_current_search_block): Use
10182         scoped_restore_current_language.
10183         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10184
10185 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10186             Jiong Wang  <jiong.wang@arm.com>
10187
10188         * aarch64-linux-tdep.c
10189         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10190         section.
10191         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10192
10193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10194             Jiong Wang  <jiong.wang@arm.com>
10195
10196         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10197         instructions.
10198         (aarch64_analyze_prologue_test): Add PACIASP test.
10199         (aarch64_prologue_prev_register): Unmask PC value.
10200
10201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10202             Jiong Wang  <jiong.wang@arm.com>
10203
10204         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10205         (aarch64_dwarf2_prev_register): Unmask PC value.
10206         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10207         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10208         DW_CFA_AARCH64_negate_ra_state.
10209         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10210
10211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10212             Jiong Wang  <jiong.wang@arm.com>
10213
10214         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10215         registers.
10216         (aarch64_pseudo_register_name): Likewise.
10217         (aarch64_pseudo_register_type): Likewise.
10218         (aarch64_pseudo_register_reggroup_p): Likewise.
10219         (aarch64_gdbarch_init): Add pauth registers.
10220         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10221         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10222         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10223         (struct gdbarch_tdep): Add regnum for ra_state.
10224
10225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10226             Jiong Wang  <jiong.wang@arm.com>
10227
10228         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10229
10230 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10231             Jiong Wang  <jiong.wang@arm.com>
10232
10233         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10234         function.
10235         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10236         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10237         (aarch64_gdbarch_init): Add puth registers.
10238         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10239         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10240         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10241
10242 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10243             Jiong Wang  <jiong.wang@arm.com>
10244
10245         * aarch64-linux-nat.c
10246         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10247         * aarch64-linux-tdep.c
10248         (aarch64_linux_core_read_description): Likewise.
10249         (aarch64_linux_get_hwcap): New function.
10250         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10251         (aarch64_linux_get_hwcap): New declaration.
10252
10253 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10254             Jiong Wang  <jiong.wang@arm.com>
10255
10256         * aarch64-linux-nat.c
10257         (aarch64_linux_nat_target::read_description): Add pauth param.
10258         * aarch64-linux-tdep.c
10259         (aarch64_linux_core_read_description): Likewise.
10260         * aarch64-tdep.c (struct target_desc): Add in pauth.
10261         (aarch64_read_description): Add pauth param.
10262         (aarch64_gdbarch_init): Likewise.
10263         * aarch64-tdep.h (aarch64_read_description): Likewise.
10264         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10265         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10266         * features/Makefile: Add new files.
10267         * features/aarch64-pauth.c: New file.
10268         * features/aarch64-pauth.xml: New file.
10269
10270 2019-03-20  Tom Tromey  <tromey@adacore.com>
10271
10272         * infrun.c (handle_inferior_event): Rename from
10273         handle_inferior_event_1.  Create a scoped_value_mark.
10274         (handle_inferior_event): Remove.
10275
10276 2019-03-19  Tom Tromey  <tromey@adacore.com>
10277
10278         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10279         * infrun.h (print_stop_event): Add "displays" parameter.
10280         * infrun.c (print_stop_event): Add "displays" parameter.
10281
10282 2019-03-19  Pedro Alves  <palves@redhat.com>
10283
10284         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10285         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10286         to -1.  Fix TABs vs spaces.
10287         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10288         * tui/tui-out.h (tui_ui_out) Add intro comments.
10289         <m_line, m_start_of_line>: In-class initialize, and add describing
10290         comment.
10291
10292 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10293
10294         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10295         variable names.
10296         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10297
10298 2019-03-18  Pedro Alves  <palves@redhat.com>
10299             Eli Zaretskii <eliz@gnu.org>
10300
10301         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10302         m_line and m_start_of_line.
10303
10304 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10305
10306         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10307         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10308         it returns a newline.  This fixes a regression in TU mode, whereby
10309         the next line is output on the same screen line as the user input.
10310
10311 2019-03-18  Tom Tromey  <tromey@adacore.com>
10312
10313         * minsyms.c (minimal_symbol_reader::install): Remove call to
10314         obstack_blank.
10315
10316 2019-03-18  Pedro Alves  <palves@redhat.com>
10317
10318         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10319         New globals.
10320         (apply_style): New, factored out from ...
10321         (apply_ansi_escape): ... this.  Handle reverse video mode.
10322         (tui_set_reverse_mode): New function.
10323         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10324         * tui/tui-winsource.c (tui_show_source_line): Use
10325         tui_set_reverse_mode instead of setting A_STANDOUT.
10326         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10327         New setter methods.
10328
10329 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10330
10331         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10332         Handle tabs.
10333
10334 2019-03-18  Tom Tromey  <tromey@adacore.com>
10335
10336         * ada-lang.c (empty_array): Add "high" parameter.
10337         (ada_evaluate_subexp): Update.
10338
10339 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10340
10341         * unittests/string_view-selftests.c: Define
10342         _initialize_string_view_selftests unconditionally.
10343
10344 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10345
10346         PR gdb/24350
10347         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10348
10349 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10350
10351         PR gdb/24351
10352         * windows-nat.c (display_selector): Fix format specifiers.
10353
10354 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10355
10356         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10357         tui_refill_source_window instead of tui_refresh_win, to update the
10358         current execution line.  This fixes redisplay of the current line
10359         when stepping through the code with "next" or "step".
10360
10361 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10362
10363         * source-cache.c (source_cache::get_source_lines): Call
10364         find_source_lines to initialize s->nlines.  This fixes vertical
10365         scrolling of TUI source window when the DOWN arrow is pressed.
10366
10367 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10368
10369         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10370         linux-thread-db.c (_initialize_thread_db): Likewise.
10371
10372 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10373
10374         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10375         wclrtoeol in tui_show_source_line".  This reverts changes made in
10376         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10377
10378 2019-03-15  Tom Tromey  <tom@tromey.com>
10379
10380         * symtab.h (struct minimal_symbol): Derive from
10381         general_symbol_info.
10382         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10383         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10384         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10385         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10386         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10387         (MSYMBOL_SEARCH_NAME): Update.
10388         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10389         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10390         * minsyms.c (minimal_symbol_reader::record_full): Update.
10391
10392 2019-03-15  Tom Tromey  <tom@tromey.com>
10393
10394         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10395
10396 2019-03-15  Tom Tromey  <tom@tromey.com>
10397
10398         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10399         unique_xmalloc_ptr.
10400         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10401         Update.
10402         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10403         (build_minimal_symbol_hash_tables)
10404         (minimal_symbol_reader::install): Update.
10405
10406 2019-03-15  Tom Tromey  <tom@tromey.com>
10407
10408         * symtab.c (create_demangled_names_hash): Update.
10409         (symbol_set_names): Update.
10410         * objfiles.h (struct objfile_per_bfd_storage)
10411         <demangled_names_hash>: Now an htab_up.
10412         * objfiles.c (objfile_per_bfd_storage): Simplify.
10413
10414 2019-03-15  Tom Tromey  <tom@tromey.com>
10415
10416         * objfiles.h (struct objfile_per_bfd_storage): Declare
10417         destructor.
10418         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10419         New.
10420         (get_objfile_bfd_data): Use new.  Don't initialize
10421         language_of_main.
10422         (free_objfile_per_bfd_storage): Remove.
10423         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10424
10425 2019-03-15  Tom Tromey  <tom@tromey.com>
10426
10427         * symfile.c (reread_symbols): Update.
10428         * objfiles.c (objfile::objfile): Update.
10429         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10430         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10431         comment.
10432         (minimal_symbol_reader::install): Update.
10433         (terminate_minimal_symbol_table): Remove.
10434         * jit.c (jit_object_close_impl): Update.
10435
10436 2019-03-15  Tom Tromey  <tom@tromey.com>
10437
10438         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10439         initializations.
10440
10441 2019-03-15  Tom Tromey  <tom@tromey.com>
10442
10443         * objfiles.h (struct objfile_per_bfd_storage)
10444         <demangled_hash_languages>: Now a bitset.
10445         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10446         (lookup_minimal_symbol): Update.
10447
10448 2019-03-15  Tom Tromey  <tom@tromey.com>
10449
10450         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10451         Don't return the symbol.
10452         * coffread.c (record_minimal_symbol): Use record_full.
10453
10454 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10455
10456         The MS-Windows port of ncurses fails to switch to a color pair if
10457         one or both of the colors are the implicit default colors.  This
10458         change records the default colors when TUI is initialized, and
10459         then specifies them explicitly when a color pair uses the default
10460         colors.  This allows color styling in TUI mode on MS-Windows.
10461
10462         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10463         ncurses_norm_attr.
10464         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10465         colors in ncurses_norm_attr.
10466         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10467         "none", replace it with the default color recorded in
10468         ncurses_norm_attr.
10469
10470 2019-03-14  Tom Tromey  <tromey@adacore.com>
10471
10472         * source-cache.h (class source_cache) <get_source_lines>: Return
10473         std::string.
10474         * source-cache.c (source_cache::extract_lines): Handle case where
10475         first_pos==npos.  Return std::string.
10476         (source_cache::get_source_lines): Update.
10477
10478 2019-03-14  Tom Tromey  <tromey@adacore.com>
10479
10480         * NEWS: Add item for "style sources" commands.
10481         * source-cache.c (source_cache::get_source_lines): Check
10482         source_styling.
10483         * cli/cli-style.c (source_styling): New global.
10484         (_initialize_cli_style): Add "style sources" commands.
10485         (show_style_sources): New function.
10486         * cli/cli-style.h (source_styling): Declare.
10487
10488 2019-03-14  Pedro Alves  <palves@redhat.com>
10489             Tom Tromey  <tromey@adacore.com>
10490
10491         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10492         * tui/tui-winsource.c (tui_refill_source_window): New function,
10493         from...
10494         (tui_horizontal_source_scroll): ... here.  Move some logic.
10495         * cli/cli-style.c (set_style_enabled): Notify new observable.
10496         * tui/tui-hooks.c (tui_redisplay_source): New function.
10497         (tui_attach_detach_observers): Attach or detach
10498         tui_redisplay_source.
10499         * observable.h (source_styling_changed): New observable.
10500         * observable.c: Define source_styling_changed observable.
10501
10502 2019-03-13  Tom Tromey  <tromey@adacore.com>
10503
10504         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10505         (i386_gnu_nat_target::store_registers): Update.
10506         * target-debug.h (target_debug_print_std_string): New macro.
10507         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10508         * windows-tdep.c (display_one_tib): Update.
10509         * tui/tui-stack.c (tui_make_status_line): Update.
10510         * top.c (print_inferior_quit_action): Update.
10511         * thread.c (thr_try_catch_cmd): Update.
10512         (add_thread_with_info): Update.
10513         (thread_target_id_str): Update.
10514         (thr_try_catch_cmd): Update.
10515         (thread_command): Update.
10516         (thread_find_command): Update.
10517         * record-btrace.c (record_btrace_target::info_record)
10518         (record_btrace_resume_thread, record_btrace_target::resume)
10519         (record_btrace_cancel_resume, record_btrace_step_thread)
10520         (record_btrace_target::wait, record_btrace_target::wait)
10521         (record_btrace_target::wait, record_btrace_target::stop): Update.
10522         * progspace.c (print_program_space): Update.
10523         * process-stratum-target.c
10524         (process_stratum_target::thread_address_space): Update.
10525         * linux-fork.c (linux_fork_mourn_inferior)
10526         (detach_checkpoint_command, info_checkpoints_command)
10527         (linux_fork_context): Update.
10528         (linux_fork_detach): Update.
10529         (class scoped_switch_fork_info): Update.
10530         (delete_checkpoint_command): Update.
10531         * infrun.c (follow_fork_inferior): Update.
10532         (follow_fork_inferior): Update.
10533         (proceed_after_vfork_done): Update.
10534         (handle_vfork_child_exec_or_exit): Update.
10535         (follow_exec): Update.
10536         (displaced_step_prepare_throw): Update.
10537         (displaced_step_restore): Update.
10538         (start_step_over): Update.
10539         (resume_1): Update.
10540         (clear_proceed_status_thread): Update.
10541         (proceed): Update.
10542         (print_target_wait_results): Update.
10543         (do_target_wait): Update.
10544         (context_switch): Update.
10545         (stop_all_threads): Update.
10546         (restart_threads): Update.
10547         (finish_step_over): Update.
10548         (handle_signal_stop): Update.
10549         (switch_back_to_stepped_thread): Update.
10550         (keep_going_pass_signal): Update.
10551         (print_exited_reason): Update.
10552         (normal_stop): Update.
10553         * inferior.c (inferior_pid_to_str): Change return type.
10554         (print_selected_inferior): Update.
10555         (add_inferior): Update.
10556         (detach_inferior): Update.
10557         * dummy-frame.c (fprint_dummy_frames): Update.
10558         * dcache.c (dcache_info_1): Update.
10559         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10560         (btrace_fetch, btrace_clear): Update.
10561         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10562         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10563         type.
10564         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10565         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10566         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10567         * gdbarch.c, gdbarch.h: Rebuild.
10568         * gdbarch.sh (core_pid_to_str): Change return type.
10569         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10570         return type.
10571         (windows_nat_target::pid_to_str): Change return type.
10572         (windows_delete_thread): Update.
10573         (windows_nat_target::attach): Update.
10574         (windows_nat_target::files_info): Update.
10575         * target-delegates.c: Rebuild.
10576         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10577         return type.
10578         (sol_thread_target::pid_to_str): Change return type.
10579         * remote.c (class remote_target) <pid_to_str>: Change return
10580         type.
10581         (remote_target::pid_to_str): Change return type.
10582         (extended_remote_target::attach, remote_target::remote_stop_ns)
10583         (remote_target::remote_notif_remove_queued_reply)
10584         (remote_target::push_stop_reply, remote_target::disable_btrace):
10585         Update.
10586         (extended_remote_target::attach): Update.
10587         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10588         type.
10589         (gdbsim_target::pid_to_str): Change return type.
10590         * ravenscar-thread.c (struct ravenscar_thread_target)
10591         <pid_to_str>: Change return type.
10592         (ravenscar_thread_target::pid_to_str): Change return type.
10593         * procfs.c (class procfs_target) <pid_to_str>: Change return
10594         type.
10595         (procfs_target::pid_to_str): Change return type.
10596         (procfs_target::attach): Update.
10597         (procfs_target::detach): Update.
10598         (procfs_target::fetch_registers): Update.
10599         (procfs_target::store_registers): Update.
10600         (procfs_target::wait): Update.
10601         (procfs_target::files_info): Update.
10602         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10603         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10604         return type.
10605         (nto_procfs_target::pid_to_str): Change return type.
10606         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10607         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10608         return type.
10609         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10610         (exit_lwp): Update.
10611         (attach_proc_task_lwp_callback, get_detach_signal)
10612         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10613         (linux_nat_target::resume, wait_lwp, stop_callback)
10614         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10615         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10616         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10617         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10618         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10619         type.
10620         (inf_ptrace_target::attach): Update.
10621         (inf_ptrace_target::files_info): Update.
10622         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10623         type.
10624         (go32_nat_target::pid_to_str): Change return type.
10625         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10626         (gnu_nat_target::wait): Update.
10627         (gnu_nat_target::wait): Update.
10628         (gnu_nat_target::resume): Update.
10629         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10630         (fbsd_nat_target::wait): Update.
10631         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10632         type.
10633         (darwin_nat_target::attach): Update.
10634         * corelow.c (class core_target) <pid_to_str>: Change return type.
10635         (core_target::pid_to_str): Change return type.
10636         * target.c (normal_pid_to_str): Change return type.
10637         (default_pid_to_str): Likewise.
10638         (target_pid_to_str): Change return type.
10639         (target_translate_tls_address): Update.
10640         (target_announce_detach): Update.
10641         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10642         return type.
10643         (bsd_uthread_target::pid_to_str): Change return type.
10644         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10645         type.
10646         (bsd_kvm_target::pid_to_str): Change return type.
10647         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10648         return type.
10649         (aix_thread_target::pid_to_str): Change return type.
10650         * target.h (struct target_ops) <pid_to_str>: Change return type.
10651         (target_pid_to_str, normal_pid_to_str): Likewise.
10652         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10653         type.
10654         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10655         type.
10656         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10657         return type.
10658         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10659         type.
10660         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10661         type.
10662         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10663         return type.
10664
10665 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10666
10667         * NEWS: Mention that the new default MI version is 3.  Mention
10668         changes to the output of commands and events that deal with
10669         multi-location breakpoints.
10670         * breakpoint.c: Include "mi/mi-out.h".
10671         (print_one_breakpoint): Change output syntax if using MI version
10672         >= 3.
10673         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10674         New.
10675         (mi_multi_location_breakpoint_output_fixed): New.
10676         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10677         (mi_cmd_fix_multi_location_breakpoint_output): New.
10678         (mi_multi_location_breakpoint_output_fixed): New.
10679         * mi/mi-cmds.c (mi_cmds): Register command
10680         -fix-multi-location-breakpoint-output.
10681         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10682         interpreter "mi".
10683
10684 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10685
10686         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10687         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10688         instantiate mi_ui_out based on interpreter name.
10689         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10690         * mi/mi-main.c (mi_load_progress): Likewise.
10691
10692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10693
10694         * NEWS: Combine separate "New targets" sections for 8.3.
10695
10696 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10697
10698         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10699         (ppcfbsd_init_abi): Install gdbarch
10700         "fetch_tls_load_module_address" and "get_thread_local_address"
10701         methods.
10702
10703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10704
10705         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10706         (riscv_fbsd_init_abi): Install gdbarch
10707         "fetch_tls_load_module_address" and "get_thread_local_address"
10708         methods.
10709
10710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10711
10712         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10713         (i386fbsd_init_abi): Install gdbarch
10714         "fetch_tls_load_module_address" and "get_thread_local_address"
10715         methods.
10716
10717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10718
10719         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10720         (amd64fbsd_init_abi): Install gdbarch
10721         "fetch_tls_load_module_address" and "get_thread_local_address"
10722         methods.
10723
10724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10725
10726         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10727         (struct fbsd_pspace_data): New type.
10728         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10729         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10730         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10731         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10732         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10733
10734 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10735
10736         * gdbtypes.c (lookup_struct_elt): New function.
10737         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10738         * gdbtypes.h (struct struct_elt): New type.
10739         (lookup_struct_elt): New prototype.
10740
10741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10742
10743         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10744         remove disabled code block.
10745
10746 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10747
10748         * gdbarch.sh (get_thread_local_address): New method.
10749         * gdbarch.h, gdbarch.c: Regenerate.
10750         * target.c (target_translate_tls_address): Use
10751         gdbarch_get_thread_local_address if present instead of
10752         target::get_thread_local_address.
10753
10754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10755
10756         * target.h (target::get_thread_local_address): Update comment.
10757
10758 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10759
10760         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10761         objfile->separate_debug_objfile_backlink if not NULL.
10762
10763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10764
10765         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10766         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10767         (amd64bsd_store_inferior_registers): Likewise.
10768         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10769         Enable segment base registers.
10770         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10771         PT_GETFSBASE and PT_GETGSBASE.
10772         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10773         PT_SETGSBASE.
10774         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10775         segment base registers.
10776         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10777
10778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10779
10780         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10781         Update calls to i386_target_description to add 'segments'
10782         parameter.
10783         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10784         add segment base registers.
10785         * arch/i386.c (i386_create_target_description): Add 'segments'
10786         parameter to enable segment base registers.
10787         * arch/i386.h (i386_create_target_description): Likewise.
10788         * features/i386/32bit-segments.xml: New file.
10789         * features/i386/32bit-segments.c: Generate.
10790         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10791         call to i386_target_description to add 'segments' parameter.
10792         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10793         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10794         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10795         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10796         if feature is present.
10797         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10798         Add 'segments' parameter to call to i386_target_description.
10799         (i386_target_description): Add 'segments' parameter to enable
10800         segment base registers.
10801         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10802         to call to i386_target_description.
10803         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10804         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10805         Define I386_NUM_REGS.
10806         (i386_target_description): Add 'segments' parameter to enable
10807         segment base registers.
10808
10809 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10810
10811         PR/24325
10812         * source-cache.c: #undef open and close, to avoid unresolved
10813         externals during linking.
10814
10815 2019-03-12  Tom Tromey  <tromey@adacore.com>
10816
10817         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10818         const.  Add initializers.
10819         (_initialize_remote): Don't initialize ptid globals.
10820
10821 2019-03-12  Pedro Alves  <palves@redhat.com>
10822
10823         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10824
10825 2019-03-12  Pedro Alves  <palves@redhat.com>
10826
10827         * cp-name-parser.y (main): Remove unused 'len' variable.
10828
10829 2019-03-12  Tom Tromey  <tromey@adacore.com>
10830
10831         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10832         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10833
10834 2019-03-12  Tom Tromey  <tromey@adacore.com>
10835
10836         * linux-nat.c (iterate_over_lwps): Update.
10837         (stop_callback): Remove parameter.
10838         (stop_wait_callback, detach_callback, resume_set_callback)
10839         (select_singlestep_lwp_callback, set_ignore_sigint)
10840         (status_callback, resumed_callback, resume_clear_callback)
10841         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10842         data parameter.
10843         (linux_nat_target::detach, linux_nat_target::resume)
10844         (linux_stop_and_wait_all_lwps, select_event_lwp)
10845         (linux_nat_filter_event, linux_nat_wait_1)
10846         (linux_nat_target::kill, linux_nat_target::stop)
10847         (linux_nat_target::stop): Update.
10848         (linux_nat_resume_callback): Change type.
10849         (resume_stopped_resumed_lwps, count_events_callback)
10850         (select_event_lwp_callback): Likewise.
10851         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10852         * arm-linux-nat.c (struct update_registers_data): Remove.
10853         (update_registers_callback): Change type.
10854         (arm_linux_insert_hw_breakpoint1): Update.
10855         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10856         parameter.
10857         (x86_linux_dr_set_addr): Update.
10858         (x86_linux_dr_set_control): Update.
10859         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10860         (iterate_over_lwps): Use gdb::function_view.
10861         * nat/aarch64-linux-hw-point.c (struct
10862         aarch64_dr_update_callback_param): Remove.
10863         (debug_reg_change_callback): Change type.
10864         (aarch64_notify_debug_reg_change): Update.
10865         * s390-linux-nat.c (s390_refresh_per_info): Update.
10866
10867 2019-03-11  Tom Tromey  <tromey@adacore.com>
10868
10869         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10870         redundant assignment to "this_cu".
10871
10872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10873
10874         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10875
10876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10877
10878         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10879         from...
10880         (rank_one_type): ... this.
10881
10882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10883
10884         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10885         from...
10886         (rank_one_type): ... this.
10887
10888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10889
10890         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10891         from...
10892         (rank_one_type): ... this.
10893
10894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10895
10896         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10897         from...
10898         (rank_one_type): ... this.
10899
10900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10901
10902         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10903         from...
10904         (rank_one_type): ... this.
10905
10906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10907
10908         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10909         from...
10910         (rank_one_type): ... this.
10911
10912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10913
10914         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10915         from...
10916         (rank_one_type): ... this.
10917
10918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10919
10920         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10921         from...
10922         (rank_one_type): ... this.
10923
10924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10925
10926         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10927         from...
10928         (rank_one_type): ... this.
10929
10930 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10931
10932         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10933         from...
10934         (rank_one_type): ... this.
10935
10936 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10937
10938         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10939         from...
10940         (rank_one_type): ... this.
10941
10942 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10943
10944         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10945         from...
10946         (rank_one_type): ... this.
10947
10948 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10949
10950         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10951         inferior-events' shows the example events.
10952
10953 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10954
10955         Support styling on native MS-Windows console
10956
10957         PR/24315
10958         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10959         on MS-Windows if $TERM is not defined.
10960
10961         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10962
10963         * posix-hdep.c (gdb_console_fputs):
10964         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10965         functions.
10966         * ui-file.h (gdb_console_fputs): Add prototype.
10967
10968         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10969         back to fputs only if the former returns zero.
10970
10971 2019-03-07  Tom Tromey  <tom@tromey.com>
10972
10973         * symmisc.c (print_symbol_bcache_statistics): Update.
10974         (print_objfile_statistics): Update.
10975         * symfile.c (allocate_symtab): Update.
10976         * stabsread.c: Don't include bcache.h.
10977         * psymtab.h (struct psymbol_bcache): Don't declare.
10978         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10979         (psymbol_bcache_init, psymbol_bcache_free)
10980         (psymbol_bcache_get_bcache): Don't declare.
10981         * psymtab.c (struct psymbol_bcache): Remove.
10982         (psymtab_storage::psymtab_storage): Update.
10983         (psymtab_storage::~psymtab_storage): Update.
10984         (psymbol_bcache_init, psymbol_bcache_free)
10985         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10986         (add_psymbol_to_bcache): Update.
10987         (allocate_psymtab): Update.
10988         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10989         macro_cache>: No longer pointers.
10990         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10991         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10992         * macrotab.c (macro_bcache): Update.
10993         * macroexp.c: Don't include bcache.h.
10994         * gdbtypes.c (check_types_worklist): Update.
10995         (types_deeply_equal): Remove TRY/CATCH.  Update.
10996         * elfread.c (elf_symtab_read): Update.
10997         * dwarf2read.c: Don't include bcache.h.
10998         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10999         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11000         (print_bcache_statistics, bcache_memory_used): Don't declare.
11001         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11002         methods.  Rename all data members.
11003         * bcache.c (struct bcache): Move to bcache.h.
11004         (bcache::expand_hash_table): Rename from expand_hash_table.
11005         (bcache): Remove.
11006         (bcache::insert): Rename from bcache_full.
11007         (bcache::compare): Rename from bcache_compare.
11008         (bcache_xmalloc): Remove.
11009         (bcache::~bcache): Rename from bcache_xfree.
11010         (bcache::print_statistics): Rename from print_bcache_statistics.
11011         (bcache::memory_used): Rename from bcache_memory_used.
11012
11013 2019-03-07  Pedro Alves  <palves@redhat.com>
11014
11015         * infrun.c (normal_stop): Also check for
11016         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11017
11018 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11019
11020         * f-lang.c (value_from_host_double): Moved to...
11021         * value.c (value_from_host_double): ...here.
11022         * value.h (value_from_host_double): Declare.
11023         * guile/scm-math.c (vlscm_convert_typed_number): Use
11024         value_from_host_double.
11025         (vlscm_convert_number): Likewise.
11026         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11027         * python/py-value.c (convert_value_from_python): Likewise.
11028
11029 2019-03-06  Tom Tromey  <tom@tromey.com>
11030
11031         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11032
11033 2019-03-06  Tom Tromey  <tom@tromey.com>
11034
11035         * utils.h (free_current_contents): Don't declare.
11036         * utils.c (free_current_contents): Remove.
11037
11038 2019-03-06  Tom Tromey  <tom@tromey.com>
11039
11040         * top.c (quit_force): Update.
11041         * main.c (captured_command_loop): Update.
11042         * common/new-op.c (operator new): Update.
11043         * common/common-exceptions.c (struct catcher)
11044         <save_cleanup_chain>: Remove member.
11045         (exceptions_state_mc_init): Update.
11046         (exception_try_scope_entry): Return nullptr.
11047         (exception_try_scope_exit, exception_rethrow)
11048         (throw_exception_sjlj, throw_exception_cxx): Update.
11049         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11050         (all_cleanups, do_cleanups, discard_cleanups)
11051         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11052         (restore_cleanups, restore_final_cleanups): Don't declare.
11053         (do_final_cleanups): Remove parameter.
11054         * common/cleanups.c (cleanup_chain, make_cleanup)
11055         (make_cleanup_dtor, all_cleanups, do_cleanups)
11056         (discard_my_cleanups, discard_cleanups)
11057         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11058         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11059         (null_cleanup): Remove.
11060         (do_final_cleanups): Remove parameter.
11061
11062 2019-03-06  Tom Tromey  <tom@tromey.com>
11063
11064         * remote.c (remote_target::remote_parse_stop_reply): Use
11065         unique_xmalloc_ptr.
11066
11067 2019-03-06  Tom Tromey  <tom@tromey.com>
11068
11069         * stabsread.c (struct stabs_field_info): Rename from field_info.
11070         <list, fnlist>: Add initializers.
11071         <obstack>: New member.
11072         (read_member_functions, read_struct_fields, read_baseclasses):
11073         Allocate on obstack.  Don't use cleanups.
11074         (read_one_struct_field, read_member_functions, read_struct_fields)
11075         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11076         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11077         (read_struct_type): Update.
11078
11079 2019-03-06  Tom Tromey  <tom@tromey.com>
11080
11081         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11082         * common/filestuff.h (make_cleanup_close): Don't declare.
11083         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11084         Remove.
11085
11086 2019-03-06  Tom Tromey  <tom@tromey.com>
11087
11088         * solib-aix.c: Use make_scope_exit.
11089
11090 2019-03-06  Tom Tromey  <tom@tromey.com>
11091
11092         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11093         Use make_scope_exit.
11094
11095 2019-03-06  Tom Tromey  <tom@tromey.com>
11096
11097         * solib-svr4.c (disable_probes_interface): Remove parameter.
11098         (svr4_handle_solib_event): Use make_scope_exit.
11099
11100 2019-03-06  Tom Tromey  <tom@tromey.com>
11101
11102         * remote.c (struct stop_reply_deleter): Remove.
11103         (stop_reply_up): Update.
11104         (struct stop_reply): Derive from notif_event.  Don't typedef.
11105         <regcache>: Now a std::vector.
11106         (stop_reply_xfree): Remove.
11107         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11108         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11109         (remote_target::discard_pending_stop_replies): Use delete.
11110         (remote_target::remote_parse_stop_reply): Update.
11111         (remote_target::process_stop_reply): Update.
11112         * remote-notif.h (struct notif_event): Add virtual destructor.
11113         Remove "dtr" member.
11114         (struct notif_client) <alloc_event>: Return a unique_ptr.
11115         (notif_event_xfree): Don't declare.
11116         (notif_event_up): New typedef.
11117         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11118         (notif_event_xfree, do_notif_event_xfree): Remove.
11119         (remote_notif_state_xfree): Update.
11120
11121 2019-03-06  Tom Tromey  <tom@tromey.com>
11122
11123         * infrun.c (displaced_step_clear_cleanup): Now a
11124         forward_scope_exit type.
11125         (displaced_step_prepare_throw): Update.
11126         (displaced_step_fixup): Update.
11127
11128 2019-03-06  Tom Tromey  <tom@tromey.com>
11129
11130         * inferior.h (class inferior): Update comment.
11131         * gdbthread.h (class thread_info): Update comment.
11132
11133 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11134             Tom Tromey  <tom@tromey.com>
11135
11136         * stabsread.h (struct stab_section_list): Remove.
11137         (coffstab_build_psymtabs): Update.
11138         * dbxread.c (symbuf_sections): Now a std::vector.
11139         (sect_idx): New global.
11140         (fill_symbuf): Update.
11141         (coffstab_build_psymtabs): Change type of stabsects parameter.
11142         Update.
11143         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11144         std::vector.
11145         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11146         (coff_locate_sections): Update.
11147         (coff_symfile_read): Remove cleanups.  Update.
11148         (init_stringtab): Add storage parameter.
11149         (free_stringtab, free_stringtab_cleanup): Remove.
11150         (init_lineno): Add storage parameter.
11151         (free_linetab, free_linetab_cleanup): Remove.
11152
11153 2019-03-06  Pedro Alves  <palves@redhat.com>
11154
11155         * linux-fork.c (fork_info::clobber_regs): Delete.
11156         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11157         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11158         comment.  Adjust.
11159         (scoped_switch_fork_info::scoped_switch_fork_info)
11160         (checkpoint_command, linux_fork_context): Adjust
11161         fork_save_infrun_state calls.
11162
11163 2019-03-06  Pedro Alves  <palves@redhat.com>
11164
11165         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11166         (inf_has_multiple_threads): Return 'bool' and rewrite using
11167         inferior_info::threads().
11168
11169 2019-03-06  Pedro Alves  <palves@redhat.com>
11170
11171         * linux-fork.c: Include <list>.
11172         (fork_list): Now a std::list instance.
11173         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11174         (forks_exist_p, find_last_fork): Adjust.
11175         (new_fork): Delete.
11176         (one_fork_p): New.
11177         (add_fork): Adjust.
11178         (free_fork): Delete, folded into fork_info::~fork_info().
11179         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11180         Adjust.
11181         (init_fork_list): Delete.
11182         (linux_fork_killall, linux_fork_mourn_inferior)
11183         (linux_fork_detach, info_checkpoints_command): Adjust.
11184         (_initialize_linux_fork): No longer call init_fork_list.
11185
11186 2019-03-06  Pedro Alves  <palves@redhat.com>
11187
11188         * linux-fork.c (new_fork): New, split out of ...
11189         (add_fork): ... this.  Return void.  Move "first fork" special
11190         case from here, to ...
11191         (checkpoint_command): ... here.
11192         * linux-linux.h (add_fork): Return void.
11193
11194 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11195
11196         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11197
11198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11199             Chris January  <chris.january@arm.com>
11200             David Lecomber  <david.lecomber@arm.com>
11201
11202         * f-exp.y: New token, UNOP_INTRINSIC.
11203         (exp): New pattern using UNOP_INTRINSIC token.
11204         (f77_keywords): Add 'abs' keyword.
11205         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11206         (value_from_host_double): New function.
11207         (evaluate_subexp_f): Support UNOP_ABS.
11208
11209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11210
11211         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11212         types.
11213
11214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11215
11216         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11217         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11218         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11219
11220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11221
11222         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11223
11224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11225             Chris January  <chris.january@arm.com>
11226
11227         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11228         * f-exp.y: Define 'KIND' token.
11229         (exp): New pattern for KIND expressions.
11230         (ptype): Handle types with a kind extension.
11231         (direct_abs_decl): Extend to spot kind extensions.
11232         (f77_keywords): Add 'kind' to the list.
11233         (push_kind_type): New function.
11234         (convert_to_kind_type): New function.
11235         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11236         * parse.c (operator_length_standard): Likewise.
11237         * parser-defs.h (enum type_pieces): Add tp_kind.
11238         * std-operator.def: Add UNOP_KIND.
11239
11240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11241
11242         * f-exp.y (f_parse): Set yydebug.
11243
11244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11245
11246         * f-lang.c (evaluate_subexp_f): New function.
11247         (exp_descriptor_f): New global.
11248         (f_language_defn): Use exp_descriptor_f instead of
11249         exp_descriptor_standard.
11250
11251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11252
11253         * f-exp.y (struct token): Add comments.
11254         (dot_ops): Remove uppercase versions and the end marker.
11255         (f77_keywords): Likewise.
11256         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11257         entries in the dot_ops array are case insensitive, and use
11258         strncasecmp to compare strings.  Also some whitespace cleanup in
11259         this area.  Similar for the f77_keywords array, except entries in
11260         this list might be case sensitive.
11261
11262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11263
11264         * f-exp.y (struct f77_boolean_val): Add comments.
11265         (boolean_values): Remove uppercase versions, and end marker.
11266         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11267         and use strncasecmp to achieve case insensitivity.  Additionally,
11268         perform whitespace cleanup around this code.
11269
11270 2019-03-06  Tom Tromey  <tromey@adacore.com>
11271
11272         * remote-sim.c (gdbsim_target_open): Use result of
11273         gdb_argv::release.
11274
11275 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11276         Dirk Schubert  <dirk.schubert@arm.com>
11277         Chris January  <chris.january@arm.com>
11278
11279         * eval.c (evaluate_subexp_standard): Call Fortran argument
11280         wrapping logic.
11281         * f-lang.c (struct value): A value which can be passed into a
11282         Fortran function call.
11283         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11284         where appropriate.
11285         (struct type): Value ready for a Fortran function call.
11286         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11287         is needed.
11288         * f-lang.h (fortran_argument_convert): Declaration.
11289         (fortran_preserve_arg_pointer): Declaration.
11290         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11291
11292 2019-03-05  Tom Tromey  <tromey@adacore.com>
11293
11294         * python/py-prettyprint.c (print_string_repr): Remove #if.
11295         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11296
11297 2019-03-05  Tom Tromey  <tromey@adacore.com>
11298
11299         * target.c (the_dummy_target): Move later.  Change type to
11300         "dummy_target".
11301         (initialize_targets): Don't initialize the_dummy_target.
11302
11303 2019-03-05  Tom Tromey  <tromey@adacore.com>
11304
11305         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11306         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11307
11308 2019-03-05  Tom Tromey  <tromey@adacore.com>
11309
11310         * windows-nat.c (windows_nat_target::attach)
11311         (windows_nat_target::detach): Don't call gdb_flush.
11312         * valprint.c (generic_val_print, val_print, val_print_string):
11313         Don't call gdb_flush.
11314         * utils.c (defaulted_query): Don't call gdb_flush.
11315         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11316         * target.c (target_announce_detach): Don't call gdb_flush.
11317         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11318         * remote.c (extended_remote_target::attach): Don't call
11319         gdb_flush.
11320         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11321         * printcmd.c (do_examine): Don't call gdb_flush.
11322         (info_display_command): Don't call gdb_flush.
11323         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11324         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11325         * memattr.c (info_mem_command): Don't call gdb_flush.
11326         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11327         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11328         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11329         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11330         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11331         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11332         (gnu_nat_target::detach): Don't call gdb_flush.
11333         * f-valprint.c (f_val_print): Don't call gdb_flush.
11334         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11335         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11336         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11337         gdb_flush.
11338         * c-valprint.c (c_val_print): Don't call gdb_flush.
11339         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11340
11341 2019-03-05  Tom Tromey  <tromey@adacore.com>
11342
11343         * varobj.c (update_dynamic_varobj_children): Update.
11344         (install_default_visualizer): Use reset, not release.
11345         * value.c (set_internalvar): Update.
11346         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11347         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11348         ATTRIBUTE_UNUSED_RESULT.
11349
11350 2019-03-05  Tom Tromey  <tromey@adacore.com>
11351
11352         * remote.c (class scoped_remote_fd) <release>: Add
11353         ATTRIBUTE_UNUSED_RESULT.
11354
11355 2019-03-05  Tom Tromey  <tromey@adacore.com>
11356
11357         * macroexp.c (struct macro_buffer) <release>: Add
11358         ATTRIBUTE_UNUSED_RESULT.
11359
11360 2019-03-05  Tom Tromey  <tromey@adacore.com>
11361
11362         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11363         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11364         ATTRIBUTE_UNUSED_RESULT.
11365
11366 2019-03-05  Tom Tromey  <tromey@adacore.com>
11367
11368         * common/scoped_fd.h (class scoped_fd) <release>: Add
11369         ATTRIBUTE_UNUSED_RESULT.
11370
11371 2019-03-05  Tom Tromey  <tromey@adacore.com>
11372
11373         * parser-defs.h (struct parser_state) <release>: Add
11374         ATTRIBUTE_UNUSED_RESULT.
11375
11376 2019-03-05  Tom Tromey  <tromey@adacore.com>
11377
11378         * utils.h (class gdb_argv) <release>: Add
11379         ATTRIBUTE_UNUSED_RESULT.
11380         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11381
11382 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11383
11384         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11385         for-loop range, to avoid compiler warnings.
11386
11387         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11388         avoid compiler warnings about unused variables.
11389
11390         * NEWS: Mention end of support for native debugging on MS-Windows
11391         before XP.
11392
11393         PR gdb/24292
11394         * common/netstuff.c:
11395         * gdbserver/gdbreplay.c
11396         * gdbserver/remote-utils.c:
11397         * ser-tcp.c:
11398         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11399         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11400         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11401         'getaddrinfo' and 'freeaddrinfo' were not available before
11402         Windows XP, and mingw.org's MinGW headers by default define
11403         _WIN32_WINNT to 0x500.
11404
11405 2019-03-01  Gary Benson <gbenson@redhat.com>
11406
11407         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11408
11409 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11410             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11411
11412         PR gdb/8527
11413         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11414         set_sigint_trap, clear_sigint_trap.
11415
11416 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11417
11418         * target.c (target_detach): Clear the regcache and the
11419         frame cache.
11420
11421 2019-02-27  Pedro Alves  <palves@redhat.com>
11422
11423         * utils.c (set_screen_size): When we cap the height/width sizes,
11424         tweak the corresponding command variable to show "unlimited":
11425
11426 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11427             Pedro Alves  <palves@redhat.com>
11428
11429         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11430         before calling rl_set_screen_size.
11431
11432 2019-02-27  Tom Tromey  <tromey@adacore.com>
11433
11434         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11435         define.
11436         * python/py-value.c: Remove Python 2.4 workaround.
11437         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11438         workaround.
11439         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11440         Python 2.4 workaround.
11441         * python/python-internal.h: Remove Python 2.4 comment.
11442         (Py_ssize_t): Don't define.
11443         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11444         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11445         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11446         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11447         * python/python.c (do_start_initialization): Remove Python 2.4
11448         workaround.
11449         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11450         (print_children): Remove Python 2.4 workaround.
11451         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11452         workaround.
11453         (CHARBUFFERPROC_NAME): Remove.
11454         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11455         Python 2.4 workaround.
11456
11457 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11458
11459         * NEWS: Note minimum Python version.
11460
11461 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11462
11463         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11464         code from these functions.  Remove corresponding ifdefs.  Use
11465         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11466         Remove gotos and target of gotos.
11467         (infpy_search_memory): Likewise.
11468
11469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11470
11471         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11472         (hppa_gdbarch_init): Don't register deleted functions with
11473         gdbarch.
11474
11475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11476
11477         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11478         (h8300_unwind_sp): Delete.
11479         (h8300_dummy_id): Delete.
11480         (h8300_gdbarch_init): Don't register deleted functions with
11481         gdbarch.
11482
11483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11484
11485         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11486         (ft32_unwind_pc): Delete.
11487         (ft32_unwind_sp): Delete.
11488         (ft32_gdbarch_init): Don't register deleted functions with
11489         gdbarch.
11490
11491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11492
11493         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11494         (frv_unwind_pc): Delete.
11495         (frv_unwind_sp): Delete.
11496         (frv_gdbarch_init): Don't register deleted functions with
11497         gdbarch.
11498
11499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11500
11501         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11502         (riscv_unwind_pc): Delete.
11503         (riscv_unwind_sp): Delete.
11504         (riscv_gdbarch_init): Don't register deleted functions with
11505         gdbarch.
11506
11507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11508
11509         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11510         (csky_unwind_pc): Delete.
11511         (csky_unwind_sp): Delete.
11512         (csky_gdbarch_init): Don't register deleted functions with
11513         gdbarch.
11514
11515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11516
11517         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11518         (cris_unwind_pc): Delete.
11519         (cris_unwind_sp): Delete.
11520         (cris_gdbarch_init): Don't register deleted functions with
11521         gdbarch.
11522
11523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11524
11525         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11526         (bfin_unwind_pc): Delete.
11527         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11528
11529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11530
11531         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11532         (arm_unwind_pc): Delete.
11533         (arm_unwind_sp): Delete.
11534         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11535
11536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11537
11538         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11539         (arc_unwind_pc): Delete.
11540         (arc_unwind_sp): Delete.
11541         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11542
11543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11544
11545         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11546         (alpha_unwind_pc): Delete.
11547         (alpha_gdbarch_init): Don't register deleted functions with
11548         gdbarch.
11549
11550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11551
11552         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11553         (aarch64_unwind_pc): Delete.
11554         (aarch64_unwind_sp): Delete.
11555         (aarch64_gdbarch_init): Don't register deleted functions with
11556         gdbarch.
11557
11558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11559
11560         * gdbtypes.c (type_align): Don't consider static members when
11561         computing structure alignment.
11562
11563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11564
11565         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11566         return 0 for other types.
11567         * arch-utils.c (default_type_align): Always return 0.
11568         * gdbarch.h: Regenerate.
11569         * gdbarch.sh (type_align): Extend comment.
11570         * gdbtypes.c (type_align): Add additional comments, always call
11571         gdbarch_type_align before applying the default rules.
11572         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11573         generic code will then apply a suitable default.
11574         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11575         types, return 0 for other types.
11576
11577 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11578
11579         * NEWS: Create a new section for the next release branch.
11580         Rename the section of the current branch, now that it has
11581         been cut.
11582
11583 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11584
11585         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11586         * version.in: Bump version to 8.3.50.DATE-git.
11587
11588 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11589
11590         * aix-thread.c (ptid_cmp): Remove unused variable.
11591         (get_signaled_thread): Likewise.
11592         (store_regs_user_thread): Likewise.
11593         (store_regs_kernel_thread): Likewise.
11594         (fetch_regs_kernel_thread): Remove shadowed variable.
11595
11596 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11597
11598         * features/riscv/32bit-cpu.xml: Add register numbers.
11599         * features/riscv/32bit-fpu.c: Regenerate.
11600         * features/riscv/32bit-fpu.xml: Add register numbers.
11601         * features/riscv/64bit-cpu.xml: Add register numbers.
11602         * features/riscv/64bit-fpu.c: Regenerate.
11603         * features/riscv/64bit-fpu.xml: Add register numbers.
11604
11605 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11606
11607         * NEWS: Mention two argument form of gdb.Value constructor.
11608         * python/py-value.c (convert_buffer_and_type_to_value): New
11609         function.
11610         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11611         Add support for handling an optional second argument.  Call
11612         convert_buffer_and_type_to_value as appropriate.
11613         * python/python-internal.h (Py_buffer_deleter): New struct.
11614         (Py_buffer_up): New typedef.
11615
11616 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11617
11618         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11619         instead of releasing ownership.
11620
11621 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11622
11623         * dwarf2read.c (open_and_init_dwp_file): Call
11624         elf_numsections instead of bfd_count_sections to initialize
11625         dwp_file->num_sections.
11626
11627 2019-02-25  Tom Tromey  <tromey@adacore.com>
11628
11629         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11630
11631 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11632
11633         * gcore.in: Add '--readnever' option when invoking GDB.
11634
11635 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11636
11637         * MAINTAINERS: Update my email address.
11638
11639 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11640
11641         * build-id.c (build_id_to_debug_bfd_1): New function.
11642         (build_id_to_debug_bfd): Look for separate debug file in
11643         sysroot.
11644
11645 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11646
11647         * gdbarch.sh: Update the copyright year range that is placed into
11648         generated files.
11649
11650 2019-02-22  Keith Seitz  <keiths@redhat.com>
11651
11652         PR symtab/23853
11653         * linespec.c (create_sals_line_offset): Search for the default
11654         symtab's filename instead of its fullname.
11655
11656 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11657
11658         * NEWS: Update style defaults.
11659
11660 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11661
11662         * main.c (captured_main_1): Disable styling in batch mode.
11663
11664 2019-02-20  Tom Tromey  <tom@tromey.com>
11665
11666         * symtab.c (symtab_symbol_info): Fix typos.
11667
11668 2019-02-20  Tom Tromey  <tromey@adacore.com>
11669
11670         * findcmd.c (_initialize_mem_search): Use upper case for
11671         metasyntactic variables.
11672
11673 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11674
11675         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11676         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11677
11678 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11679
11680         * top.h (source_file_name): Change to std::string.
11681         * top.c (source_file_name): Likewise.
11682         (command_line_input): Adjust.
11683         * cli/cli-script.c (script_from_file): Adjust.
11684
11685 2019-02-19  Tom Tromey  <tromey@adacore.com>
11686
11687         * ravenscar-thread.c
11688         (ravenscar_thread_target::update_thread_list): Don't call
11689         ada_build_task_list.
11690         * ada-lang.h (ada_build_task_list): Don't declare.
11691         * ada-tasks.c (struct ada_tasks_inferior_data)
11692         <task_list_valid_p>: Now bool.
11693         (read_known_tasks, ada_task_list_changed)
11694         (ada_tasks_invalidate_inferior_data): Update.
11695         (read_known_tasks_array): Return bool.
11696         (read_known_tasks_list): Likewise.
11697         (read_known_tasks): Return void.
11698         (ada_build_task_list): Now static.
11699
11700 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11701
11702         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11703         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11704
11705 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11706
11707         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11708         variant for ada_tasks_pspace_data_handle and
11709         ada_tasks_inferior_data_handle.
11710         (ada_tasks_pspace_data_cleanup): New function.
11711         (ada_tasks_inferior_data_cleanup): New function.
11712
11713 2019-02-17  Tom Tromey  <tom@tromey.com>
11714
11715         * macrotab.h (macro_source_fullname): Return a std::string.
11716         * macrotab.c (macro_include, check_for_redefinition)
11717         (macro_undef, macro_lookup_definition, foreach_macro)
11718         (foreach_macro_in_scope): Update.
11719         (macro_source_fullname): Return a std::string.
11720         * macrocmd.c (show_pp_source_pos): Update.
11721
11722 2019-02-17  Tom Tromey  <tom@tromey.com>
11723
11724         * macrocmd.c (show_pp_source_pos): Style the file names.
11725
11726 2019-02-17  Tom Tromey  <tom@tromey.com>
11727
11728         PR tui/24197:
11729         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11730
11731 2019-02-17  Tom Tromey  <tom@tromey.com>
11732
11733         * ada-lang.c (user_select_syms): Use filtered printing.
11734         * utils.c (wrap_style): New global.
11735         (desired_style): Remove.
11736         (emit_style_escape): Add stream parameter.
11737         (set_output_style, reset_terminal_style, prompt_for_continue):
11738         Update.
11739         (flush_wrap_buffer): Only flush gdb_stdout.
11740         (wrap_here): Set wrap_style.
11741         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11742         treat escape sequences as a character.  Change when wrap buffer is
11743         flushed.
11744         (fputs_styled): Do not set the output style when the default is
11745         requested.
11746         * ui-style.h (struct ui_file_style) <is_default>: New method.
11747         * source.c (print_source_lines_base): Emit escape sequences in one
11748         piece.
11749
11750 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11751
11752         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11753         integers and enumeration types.
11754
11755 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11756
11757         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11758         instead of lookup_symbol_in_language
11759         (do_exact_match): New function.
11760         (ada_get_symbol_name_matcher): Return do_exact_match when
11761         doing a verbatim match.
11762
11763 2019-02-15  Tom Tromey  <tromey@adacore.com>
11764
11765         * ravenscar-thread.c (ravenscar_thread_target::resume)
11766         (ravenscar_thread_target::wait): Special case wildcard requests.
11767
11768 2019-02-15  Tom Tromey  <tromey@adacore.com>
11769
11770         * ravenscar-thread.c (base_ptid): Remove.
11771         (struct ravenscar_thread_target) <close>: New method.
11772         <m_base_ptid>: New member.
11773         <update_inferior_ptid, active_task, task_is_currently_active,
11774         runtime_initialized>: Declare methods.
11775         <ravenscar_thread_target>: Add constructor.
11776         (ravenscar_thread_target::task_is_currently_active)
11777         (ravenscar_thread_target::update_inferior_ptid)
11778         (ravenscar_runtime_initialized): Rename.  Now methods.
11779         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11780         (ravenscar_thread_target::update_thread_list): Update.
11781         (ravenscar_thread_target::active_task): Now method.
11782         (ravenscar_thread_target::store_registers)
11783         (ravenscar_thread_target::prepare_to_store)
11784         (ravenscar_thread_target::prepare_to_store)
11785         (ravenscar_thread_target::mourn_inferior): Update.
11786         (ravenscar_inferior_created): Use "new" to create target.
11787         (ravenscar_thread_target::get_ada_task_ptid): Update.
11788         (_initialize_ravenscar): Don't initialize base_ptid.
11789         (ravenscar_ops): Remove global.
11790
11791 2019-02-15  Tom Tromey  <tromey@adacore.com>
11792
11793         * target.h (push_target): Declare new overload.
11794         * target.c (push_target): New overload, taking an rvalue reference.
11795         * remote.c (remote_target::open_1): Use push_target overload.
11796         * corelow.c (core_target_open): Use push_target overload.
11797
11798 2019-02-15  Tom Tromey  <tromey@adacore.com>
11799
11800         * ravenscar-thread.c (is_ravenscar_task)
11801         (ravenscar_task_is_currently_active): Return bool.
11802         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11803         (_initialize_ravenscar): Remove "(void)".
11804         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11805         Return bool.
11806
11807 2019-02-15  Tom Tromey  <tromey@adacore.com>
11808
11809         * ravenscar-thread.c (ravenscar_runtime_initializer)
11810         (has_ravenscar_runtime, get_running_thread_id)
11811         (ravenscar_thread_target::resume): Fix indentation.
11812
11813 2019-02-15  Tom Tromey  <tromey@adacore.com>
11814
11815         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11816         from ravenscar_arch_ops.
11817         (sparc_ravenscar_ops::fetch_registers)
11818         (sparc_ravenscar_ops::store_registers): Now methods.
11819         (sparc_ravenscar_prepare_to_store): Remove.
11820         (sparc_ravenscar_ops): Redefine.
11821         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11822         methods and destructor.  Remove members.
11823         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11824         (ravenscar_thread_target::store_registers)
11825         (ravenscar_thread_target::prepare_to_store): Update.
11826         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11827         Remove.
11828         (struct ppc_ravenscar_powerpc_ops): Derive from
11829         ravenscar_arch_ops.
11830         (ppc_ravenscar_powerpc_ops::fetch_registers)
11831         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11832         (ppc_ravenscar_powerpc_ops): Redefine.
11833         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11834         (ppc_ravenscar_e500_ops::fetch_registers)
11835         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11836         (ppc_ravenscar_e500_ops): Redefine.
11837         * aarch64-ravenscar-thread.c
11838         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11839         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11840         (aarch64_ravenscar_fetch_registers)
11841         (aarch64_ravenscar_store_registers): Now methods.
11842         (aarch64_ravenscar_ops): Redefine.
11843
11844 2019-02-15  Tom Tromey  <tromey@adacore.com>
11845
11846         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11847         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11848         (ravenscar_thread_target::stopped_by_watchpoint)
11849         (ravenscar_thread_target::stopped_data_address)
11850         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11851
11852 2019-02-15  Tom Tromey  <tromey@adacore.com>
11853
11854         * ravenscar-thread.c: Fix some typos.
11855
11856 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11857             Tom Tromey  <tromey@adacore.com>
11858
11859         * ada-lang.c (ada_exception_sal): Change addr_string to a
11860         std::string.
11861         (create_ada_exception_catchpoint): Update.
11862
11863 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11864             Tom Tromey  <tromey@adacore.com>
11865
11866         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11867         (bp_location_ops): Remove.
11868         (base_breakpoint_allocate_location): Update.
11869         (free_bp_location): Update.
11870         * ada-lang.c (class ada_catchpoint_location)
11871         <ada_catchpoint_location>: Remove ops parameter.
11872         (ada_catchpoint_location_dtor): Remove.
11873         (ada_catchpoint_location_ops): Remove.
11874         (allocate_location_exception): Update.
11875         * breakpoint.h (struct bp_location_ops): Remove.
11876         (class bp_location) <bp_location>: Remove bp_location_ops
11877         parameter.
11878         <~bp_location>: Add destructor.
11879         <ops>: Remove.
11880
11881 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11882             Pedro Alves  <palves@redhat.com>
11883
11884         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11885         'PATH_MAX'.
11886
11887 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11888             Samuel Thibault  <samuel.thibault@gnu.org>
11889             Thomas Schwinge  <thomas@codesourcery.com>
11890
11891         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11892         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11893
11894 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11895
11896         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11897         (check_empty): Use "const char *".
11898
11899         * gnu-nat.c (gnu_nat_target::detach): Instead of
11900         'detach_inferior (pid)' call
11901         'detach_inferior (find_inferior_pid (pid))'.
11902
11903         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11904         'nat/fork-inferior.o'.
11905         * gnu-nat.c: #include "nat/fork-inferior.h".
11906
11907         * gnu-nat.c (gnu_nat_target::detach): Instead of
11908         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11909         * gnu-nat.h: #include "inf-child.h".
11910         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11911         'i386_gnu_nat_target::fetch_registers'.
11912         (gnu_store_registers): Rename/move to
11913         'i386_gnu_nat_target::store_registers'.
11914
11915         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11916         * gnu-nat.h (mach_thread_info): New function.
11917         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11918
11919         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11920
11921 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11922
11923         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11924
11925 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11926
11927         * windows-nat.c (windows_add_thread): Add new parameter
11928         "main_thread_p" with default value set to false.  Update
11929         function documentation as well as all callers.
11930         (windows_delete_thread): Likewise.
11931         (fake_create_process): Update call to windows_add_thread.
11932         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11933         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11934         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11935         call to windows_delete_thread.
11936
11937 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11938
11939         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11940
11941 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11942
11943         * symfile.c (find_separate_debug_file): Use canonical path of
11944         sysroot with child_path instead of gdb_sysroot if it is valid.
11945
11946 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11947
11948         * symfile.c (find_separate_debug_file): Use child_path to
11949         determine if an object file is under a sysroot.
11950
11951 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11952
11953         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11954         unittests/child-path-selftests.c.
11955         * common/pathstuff.c (child_path): New function.
11956         * common/pathstuff.h (child_path): New prototype.
11957         * unittests/child-path-selftests.c: New file.
11958
11959 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11960
11961         * symfile.c (find_separate_debug_file): Look for separate debug
11962         files in debug directories under the sysroot.
11963
11964 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11965
11966         * symtab.h (struct minimal_symbol data_p): New const method.
11967         (struct minimal_symbol text_p): Likewise.
11968         * symtab.c (output_source_filename): Use file name style
11969         to print file name.
11970         (print_symbol_info): Likewise.
11971         (print_msymbol_info): Use address style to print addresses.
11972         Use function name style to print executable text symbols.
11973         (expand_symtab_containing_pc): Use data_p.
11974         (find_pc_sect_compunit_symtab): Likewise.
11975
11976 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11977
11978         * breakpoint.c (describe_other_breakpoints): Use address style
11979         to print addresses.
11980         (say_where): Likewise.
11981
11982 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11983
11984         * ada-typeprint.c (print_func_type): Print function name
11985         style to print function name.
11986         * c-typeprint.c (c_print_type_1): Likewise.
11987
11988 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11989
11990         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11991         for execve.
11992
11993 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11994
11995         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11996         type_stack.
11997
11998 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11999
12000         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12001         TYPE_CODE_REF types.
12002
12003 2019-02-08  Jim Wilson  <jimw@sifive.com>
12004
12005         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12006         (riscv_linux_fregset): New.
12007         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12008
12009 2019-02-07  Tom Tromey  <tom@tromey.com>
12010
12011         * thread.c (thread_cancel_execution_command): Update.
12012         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12013         methods.
12014         (struct thread_fsm_ops): Remove.
12015         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12016         (thread_fsm_should_stop, thread_fsm_return_value)
12017         (thread_fsm_set_finished, thread_fsm_finished_p)
12018         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12019         Don't declare.
12020         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12021         * infrun.c (clear_proceed_status_thread)
12022         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12023         (print_stop_event): Update.
12024         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12025         Add constructor.
12026         (step_command_fsm_ops): Remove.
12027         (new_step_command_fsm): Remove.
12028         (step_1): Update.
12029         (step_command_fsm::should_stop): Rename from
12030         step_command_fsm_should_stop.
12031         (step_command_fsm::clean_up): Rename from
12032         step_command_fsm_clean_up.
12033         (step_command_fsm::do_async_reply_reason): Rename from
12034         step_command_fsm_async_reply_reason.
12035         (struct until_next_fsm): Inherit from thread_fsm.  Add
12036         constructor.
12037         (until_next_fsm_ops): Remove.
12038         (new_until_next_fsm): Remove.
12039         (until_next_fsm::should_stop): Rename from
12040         until_next_fsm_should_stop.
12041         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12042         (until_next_fsm::do_async_reply_reason): Rename from
12043         until_next_fsm_async_reply_reason.
12044         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12045         constructor.  Change type of breakpoint.
12046         (finish_command_fsm_ops): Remove.
12047         (new_finish_command_fsm): Remove.
12048         (finish_command_fsm::should_stop): Rename from
12049         finish_command_fsm_should_stop.
12050         (finish_command_fsm::clean_up): Rename from
12051         finish_command_fsm_clean_up.
12052         (finish_command_fsm::return_value): Rename from
12053         finish_command_fsm_return_value.
12054         (finish_command_fsm::do_async_reply_reason): Rename from
12055         finish_command_fsm_async_reply_reason.
12056         (finish_command): Update.
12057         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12058         Add constructor.
12059         (call_thread_fsm_ops): Remove.
12060         (call_thread_fsm::call_thread_fsm): Rename from
12061         new_call_thread_fsm.
12062         (call_thread_fsm::should_stop): Rename from
12063         call_thread_fsm_should_stop.
12064         (call_thread_fsm::should_notify_stop): Rename from
12065         call_thread_fsm_should_notify_stop.
12066         (run_inferior_call, call_function_by_hand_dummy): Update.
12067         * cli/cli-interp.c (should_print_stop_to_console): Update.
12068         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12069         Add constructor.  Change type of location_breakpoint,
12070         caller_breakpoint.
12071         (until_break_fsm_ops): Remove.
12072         (new_until_break_fsm): Remove.
12073         (until_break_fsm::should_stop): Rename from
12074         until_break_fsm_should_stop.
12075         (until_break_fsm::clean_up): Rename from
12076         until_break_fsm_clean_up.
12077         (until_break_fsm::do_async_reply_reason): Rename from
12078         until_break_fsm_async_reply_reason.
12079         (until_break_command): Update.
12080         * thread-fsm.c: Remove.
12081         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12082
12083 2019-02-07  Tom Tromey  <tom@tromey.com>
12084
12085         * yy-remap.h: Add include guard.
12086         * xtensa-tdep.h: Add include guard.
12087         * xcoffread.h: Rename include guard.
12088         * varobj-iter.h: Add include guard.
12089         * tui/tui.h: Rename include guard.
12090         * tui/tui-winsource.h: Rename include guard.
12091         * tui/tui-wingeneral.h: Rename include guard.
12092         * tui/tui-windata.h: Rename include guard.
12093         * tui/tui-win.h: Rename include guard.
12094         * tui/tui-stack.h: Rename include guard.
12095         * tui/tui-source.h: Rename include guard.
12096         * tui/tui-regs.h: Rename include guard.
12097         * tui/tui-out.h: Rename include guard.
12098         * tui/tui-layout.h: Rename include guard.
12099         * tui/tui-io.h: Rename include guard.
12100         * tui/tui-hooks.h: Rename include guard.
12101         * tui/tui-file.h: Rename include guard.
12102         * tui/tui-disasm.h: Rename include guard.
12103         * tui/tui-data.h: Rename include guard.
12104         * tui/tui-command.h: Rename include guard.
12105         * tic6x-tdep.h: Add include guard.
12106         * target/waitstatus.h: Rename include guard.
12107         * target/wait.h: Rename include guard.
12108         * target/target.h: Rename include guard.
12109         * target/resume.h: Rename include guard.
12110         * target-float.h: Rename include guard.
12111         * stabsread.h: Add include guard.
12112         * rs6000-tdep.h: Add include guard.
12113         * riscv-fbsd-tdep.h: Add include guard.
12114         * regformats/regdef.h: Rename include guard.
12115         * record.h: Rename include guard.
12116         * python/python.h: Rename include guard.
12117         * python/python-internal.h: Rename include guard.
12118         * python/py-stopevent.h: Rename include guard.
12119         * python/py-ref.h: Rename include guard.
12120         * python/py-record.h: Rename include guard.
12121         * python/py-record-full.h: Rename include guard.
12122         * python/py-record-btrace.h: Rename include guard.
12123         * python/py-instruction.h: Rename include guard.
12124         * python/py-events.h: Rename include guard.
12125         * python/py-event.h: Rename include guard.
12126         * procfs.h: Add include guard.
12127         * proc-utils.h: Add include guard.
12128         * p-lang.h: Add include guard.
12129         * or1k-tdep.h: Rename include guard.
12130         * observable.h: Rename include guard.
12131         * nto-tdep.h: Rename include guard.
12132         * nat/x86-linux.h: Rename include guard.
12133         * nat/x86-linux-dregs.h: Rename include guard.
12134         * nat/x86-gcc-cpuid.h: Add include guard.
12135         * nat/x86-dregs.h: Rename include guard.
12136         * nat/x86-cpuid.h: Rename include guard.
12137         * nat/ppc-linux.h: Rename include guard.
12138         * nat/mips-linux-watch.h: Rename include guard.
12139         * nat/linux-waitpid.h: Rename include guard.
12140         * nat/linux-ptrace.h: Rename include guard.
12141         * nat/linux-procfs.h: Rename include guard.
12142         * nat/linux-osdata.h: Rename include guard.
12143         * nat/linux-nat.h: Rename include guard.
12144         * nat/linux-namespaces.h: Rename include guard.
12145         * nat/linux-btrace.h: Rename include guard.
12146         * nat/glibc_thread_db.h: Rename include guard.
12147         * nat/gdb_thread_db.h: Rename include guard.
12148         * nat/gdb_ptrace.h: Rename include guard.
12149         * nat/fork-inferior.h: Rename include guard.
12150         * nat/amd64-linux-siginfo.h: Rename include guard.
12151         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12152         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12153         * nat/aarch64-linux.h: Rename include guard.
12154         * nat/aarch64-linux-hw-point.h: Rename include guard.
12155         * mn10300-tdep.h: Add include guard.
12156         * mips-linux-tdep.h: Add include guard.
12157         * mi/mi-parse.h: Rename include guard.
12158         * mi/mi-out.h: Rename include guard.
12159         * mi/mi-main.h: Rename include guard.
12160         * mi/mi-interp.h: Rename include guard.
12161         * mi/mi-getopt.h: Rename include guard.
12162         * mi/mi-console.h: Rename include guard.
12163         * mi/mi-common.h: Rename include guard.
12164         * mi/mi-cmds.h: Rename include guard.
12165         * mi/mi-cmd-break.h: Rename include guard.
12166         * m2-lang.h: Add include guard.
12167         * location.h: Rename include guard.
12168         * linux-record.h: Rename include guard.
12169         * linux-nat.h: Add include guard.
12170         * linux-fork.h: Add include guard.
12171         * i386-darwin-tdep.h: Rename include guard.
12172         * hppa-linux-offsets.h: Add include guard.
12173         * guile/guile.h: Rename include guard.
12174         * guile/guile-internal.h: Rename include guard.
12175         * gnu-nat.h: Rename include guard.
12176         * gdb-stabs.h: Rename include guard.
12177         * frv-tdep.h: Add include guard.
12178         * f-lang.h: Add include guard.
12179         * event-loop.h: Add include guard.
12180         * darwin-nat.h: Rename include guard.
12181         * cp-abi.h: Rename include guard.
12182         * config/sparc/nm-sol2.h: Rename include guard.
12183         * config/nm-nto.h: Rename include guard.
12184         * config/nm-linux.h: Add include guard.
12185         * config/i386/nm-i386gnu.h: Rename include guard.
12186         * config/djgpp/nl_types.h: Rename include guard.
12187         * config/djgpp/langinfo.h: Rename include guard.
12188         * compile/gcc-cp-plugin.h: Add include guard.
12189         * compile/gcc-c-plugin.h: Add include guard.
12190         * compile/compile.h: Rename include guard.
12191         * compile/compile-object-run.h: Rename include guard.
12192         * compile/compile-object-load.h: Rename include guard.
12193         * compile/compile-internal.h: Rename include guard.
12194         * compile/compile-cplus.h: Rename include guard.
12195         * compile/compile-c.h: Rename include guard.
12196         * common/xml-utils.h: Rename include guard.
12197         * common/x86-xstate.h: Rename include guard.
12198         * common/version.h: Rename include guard.
12199         * common/vec.h: Rename include guard.
12200         * common/tdesc.h: Rename include guard.
12201         * common/selftest.h: Rename include guard.
12202         * common/scoped_restore.h: Rename include guard.
12203         * common/scoped_mmap.h: Rename include guard.
12204         * common/scoped_fd.h: Rename include guard.
12205         * common/safe-iterator.h: Rename include guard.
12206         * common/run-time-clock.h: Rename include guard.
12207         * common/refcounted-object.h: Rename include guard.
12208         * common/queue.h: Rename include guard.
12209         * common/ptid.h: Rename include guard.
12210         * common/print-utils.h: Rename include guard.
12211         * common/preprocessor.h: Rename include guard.
12212         * common/pathstuff.h: Rename include guard.
12213         * common/observable.h: Rename include guard.
12214         * common/netstuff.h: Rename include guard.
12215         * common/job-control.h: Rename include guard.
12216         * common/host-defs.h: Rename include guard.
12217         * common/gdb_wait.h: Rename include guard.
12218         * common/gdb_vecs.h: Rename include guard.
12219         * common/gdb_unlinker.h: Rename include guard.
12220         * common/gdb_unique_ptr.h: Rename include guard.
12221         * common/gdb_tilde_expand.h: Rename include guard.
12222         * common/gdb_sys_time.h: Rename include guard.
12223         * common/gdb_string_view.h: Rename include guard.
12224         * common/gdb_splay_tree.h: Rename include guard.
12225         * common/gdb_setjmp.h: Rename include guard.
12226         * common/gdb_ref_ptr.h: Rename include guard.
12227         * common/gdb_optional.h: Rename include guard.
12228         * common/gdb_locale.h: Rename include guard.
12229         * common/gdb_assert.h: Rename include guard.
12230         * common/filtered-iterator.h: Rename include guard.
12231         * common/filestuff.h: Rename include guard.
12232         * common/fileio.h: Rename include guard.
12233         * common/environ.h: Rename include guard.
12234         * common/common-utils.h: Rename include guard.
12235         * common/common-types.h: Rename include guard.
12236         * common/common-regcache.h: Rename include guard.
12237         * common/common-inferior.h: Rename include guard.
12238         * common/common-gdbthread.h: Rename include guard.
12239         * common/common-exceptions.h: Rename include guard.
12240         * common/common-defs.h: Rename include guard.
12241         * common/common-debug.h: Rename include guard.
12242         * common/cleanups.h: Rename include guard.
12243         * common/buffer.h: Rename include guard.
12244         * common/btrace-common.h: Rename include guard.
12245         * common/break-common.h: Rename include guard.
12246         * cli/cli-utils.h: Rename include guard.
12247         * cli/cli-style.h: Rename include guard.
12248         * cli/cli-setshow.h: Rename include guard.
12249         * cli/cli-script.h: Rename include guard.
12250         * cli/cli-interp.h: Rename include guard.
12251         * cli/cli-decode.h: Rename include guard.
12252         * cli/cli-cmds.h: Rename include guard.
12253         * charset-list.h: Add include guard.
12254         * buildsym-legacy.h: Rename include guard.
12255         * bfin-tdep.h: Add include guard.
12256         * ax.h: Rename include guard.
12257         * arm-linux-tdep.h: Add include guard.
12258         * arm-fbsd-tdep.h: Add include guard.
12259         * arch/xtensa.h: Rename include guard.
12260         * arch/tic6x.h: Add include guard.
12261         * arch/i386.h: Add include guard.
12262         * arch/arm.h: Rename include guard.
12263         * arch/arm-linux.h: Rename include guard.
12264         * arch/arm-get-next-pcs.h: Rename include guard.
12265         * arch/amd64.h: Add include guard.
12266         * arch/aarch64-insn.h: Rename include guard.
12267         * arch-utils.h: Rename include guard.
12268         * annotate.h: Add include guard.
12269         * amd64-darwin-tdep.h: Rename include guard.
12270         * aarch64-linux-tdep.h: Add include guard.
12271         * aarch64-fbsd-tdep.h: Add include guard.
12272         * aarch32-linux-nat.h: Add include guard.
12273
12274 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12275
12276         * macrotab.c (macro_define_internal): New function that
12277         factorizes macro_define_object_internal and macro_define_function
12278         code.
12279         (macro_define_object_internal): Use macro_define_internal.
12280         (macro_define_function): Likewise.
12281
12282 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12283
12284         * macrocmd.c (extract_identifier): Return
12285         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12286         callers.
12287
12288 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12289
12290         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12291
12292 2019-02-05  Tom Tromey  <tom@tromey.com>
12293
12294         * target.c (target_stack::unpush): Move assertion earlier.
12295
12296 2019-01-30  Tom Tromey  <tom@tromey.com>
12297
12298         PR python/23615:
12299         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12300         (gdbpy_parse_and_eval): Likewise.
12301         * python/python-internal.h (gdbpy_allow_threads): New class.
12302
12303 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12304
12305         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12306         (aarch64_fbsd_fpregmap): Move earlier.
12307         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12308         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12309         instead of individual calls to trad_frame_set_reg_addr.
12310         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12311         earlier.
12312         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12313         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12314         instead of individual calls to trad_frame_set_reg_addr.
12315
12316 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12317
12318         * CONTRIBUTE: Replace contribution list with wiki link.
12319
12320 2019-01-25  Tom Tromey  <tom@tromey.com>
12321
12322         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12323
12324 2019-01-25  Tom Tromey  <tom@tromey.com>
12325
12326         * xtensa-linux-nat.c: Fix common/ includes.
12327         * xml-support.h: Fix common/ includes.
12328         * xml-support.c: Fix common/ includes.
12329         * x86-linux-nat.c: Fix common/ includes.
12330         * windows-nat.c: Fix common/ includes.
12331         * varobj.h: Fix common/ includes.
12332         * varobj.c: Fix common/ includes.
12333         * value.c: Fix common/ includes.
12334         * valops.c: Fix common/ includes.
12335         * utils.c: Fix common/ includes.
12336         * unittests/xml-utils-selftests.c: Fix common/ includes.
12337         * unittests/utils-selftests.c: Fix common/ includes.
12338         * unittests/unpack-selftests.c: Fix common/ includes.
12339         * unittests/tracepoint-selftests.c: Fix common/ includes.
12340         * unittests/style-selftests.c: Fix common/ includes.
12341         * unittests/string_view-selftests.c: Fix common/ includes.
12342         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12343         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12344         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12345         * unittests/rsp-low-selftests.c: Fix common/ includes.
12346         * unittests/parse-connection-spec-selftests.c: Fix common/
12347         includes.
12348         * unittests/optional-selftests.c: Fix common/ includes.
12349         * unittests/offset-type-selftests.c: Fix common/ includes.
12350         * unittests/observable-selftests.c: Fix common/ includes.
12351         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12352         * unittests/memrange-selftests.c: Fix common/ includes.
12353         * unittests/memory-map-selftests.c: Fix common/ includes.
12354         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12355         * unittests/function-view-selftests.c: Fix common/ includes.
12356         * unittests/environ-selftests.c: Fix common/ includes.
12357         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12358         * unittests/common-utils-selftests.c: Fix common/ includes.
12359         * unittests/cli-utils-selftests.c: Fix common/ includes.
12360         * unittests/array-view-selftests.c: Fix common/ includes.
12361         * ui-file.c: Fix common/ includes.
12362         * tui/tui-io.c: Fix common/ includes.
12363         * tracepoint.h: Fix common/ includes.
12364         * tracepoint.c: Fix common/ includes.
12365         * tracefile-tfile.c: Fix common/ includes.
12366         * top.h: Fix common/ includes.
12367         * top.c: Fix common/ includes.
12368         * thread.c: Fix common/ includes.
12369         * target/waitstatus.h: Fix common/ includes.
12370         * target/waitstatus.c: Fix common/ includes.
12371         * target.h: Fix common/ includes.
12372         * target.c: Fix common/ includes.
12373         * target-memory.c: Fix common/ includes.
12374         * target-descriptions.c: Fix common/ includes.
12375         * symtab.h: Fix common/ includes.
12376         * symfile.c: Fix common/ includes.
12377         * stap-probe.c: Fix common/ includes.
12378         * spu-linux-nat.c: Fix common/ includes.
12379         * sparc-nat.c: Fix common/ includes.
12380         * source.c: Fix common/ includes.
12381         * solib.c: Fix common/ includes.
12382         * solib-target.c: Fix common/ includes.
12383         * ser-unix.c: Fix common/ includes.
12384         * ser-tcp.c: Fix common/ includes.
12385         * ser-pipe.c: Fix common/ includes.
12386         * ser-base.c: Fix common/ includes.
12387         * selftest-arch.c: Fix common/ includes.
12388         * s12z-tdep.c: Fix common/ includes.
12389         * rust-exp.y: Fix common/ includes.
12390         * rs6000-aix-tdep.c: Fix common/ includes.
12391         * riscv-tdep.c: Fix common/ includes.
12392         * remote.c: Fix common/ includes.
12393         * remote-notif.h: Fix common/ includes.
12394         * remote-fileio.h: Fix common/ includes.
12395         * remote-fileio.c: Fix common/ includes.
12396         * regcache.h: Fix common/ includes.
12397         * regcache.c: Fix common/ includes.
12398         * record-btrace.c: Fix common/ includes.
12399         * python/python.c: Fix common/ includes.
12400         * python/py-type.c: Fix common/ includes.
12401         * python/py-inferior.c: Fix common/ includes.
12402         * progspace.h: Fix common/ includes.
12403         * producer.c: Fix common/ includes.
12404         * procfs.c: Fix common/ includes.
12405         * proc-api.c: Fix common/ includes.
12406         * printcmd.c: Fix common/ includes.
12407         * ppc-linux-nat.c: Fix common/ includes.
12408         * parser-defs.h: Fix common/ includes.
12409         * osdata.c: Fix common/ includes.
12410         * obsd-nat.c: Fix common/ includes.
12411         * nat/x86-linux.c: Fix common/ includes.
12412         * nat/x86-linux-dregs.c: Fix common/ includes.
12413         * nat/x86-dregs.h: Fix common/ includes.
12414         * nat/x86-dregs.c: Fix common/ includes.
12415         * nat/ppc-linux.c: Fix common/ includes.
12416         * nat/mips-linux-watch.h: Fix common/ includes.
12417         * nat/mips-linux-watch.c: Fix common/ includes.
12418         * nat/linux-waitpid.c: Fix common/ includes.
12419         * nat/linux-ptrace.h: Fix common/ includes.
12420         * nat/linux-ptrace.c: Fix common/ includes.
12421         * nat/linux-procfs.c: Fix common/ includes.
12422         * nat/linux-personality.c: Fix common/ includes.
12423         * nat/linux-osdata.c: Fix common/ includes.
12424         * nat/linux-namespaces.c: Fix common/ includes.
12425         * nat/linux-btrace.h: Fix common/ includes.
12426         * nat/linux-btrace.c: Fix common/ includes.
12427         * nat/fork-inferior.c: Fix common/ includes.
12428         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12429         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12430         * nat/aarch64-linux.c: Fix common/ includes.
12431         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12432         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12433         * namespace.h: Fix common/ includes.
12434         * mips-linux-tdep.c: Fix common/ includes.
12435         * minsyms.c: Fix common/ includes.
12436         * mi/mi-parse.h: Fix common/ includes.
12437         * mi/mi-main.c: Fix common/ includes.
12438         * mi/mi-cmd-env.c: Fix common/ includes.
12439         * memrange.h: Fix common/ includes.
12440         * memattr.c: Fix common/ includes.
12441         * maint.h: Fix common/ includes.
12442         * maint.c: Fix common/ includes.
12443         * main.c: Fix common/ includes.
12444         * machoread.c: Fix common/ includes.
12445         * location.c: Fix common/ includes.
12446         * linux-thread-db.c: Fix common/ includes.
12447         * linux-nat.c: Fix common/ includes.
12448         * linux-fork.c: Fix common/ includes.
12449         * inline-frame.c: Fix common/ includes.
12450         * infrun.c: Fix common/ includes.
12451         * inflow.c: Fix common/ includes.
12452         * inferior.h: Fix common/ includes.
12453         * inferior.c: Fix common/ includes.
12454         * infcmd.c: Fix common/ includes.
12455         * inf-ptrace.c: Fix common/ includes.
12456         * inf-child.c: Fix common/ includes.
12457         * ia64-linux-nat.c: Fix common/ includes.
12458         * i387-tdep.c: Fix common/ includes.
12459         * i386-tdep.c: Fix common/ includes.
12460         * i386-linux-tdep.c: Fix common/ includes.
12461         * i386-linux-nat.c: Fix common/ includes.
12462         * i386-go32-tdep.c: Fix common/ includes.
12463         * i386-fbsd-tdep.c: Fix common/ includes.
12464         * i386-fbsd-nat.c: Fix common/ includes.
12465         * guile/scm-type.c: Fix common/ includes.
12466         * guile/guile.c: Fix common/ includes.
12467         * go32-nat.c: Fix common/ includes.
12468         * gnu-nat.c: Fix common/ includes.
12469         * gdbthread.h: Fix common/ includes.
12470         * gdbarch-selftests.c: Fix common/ includes.
12471         * gdb_usleep.c: Fix common/ includes.
12472         * gdb_select.h: Fix common/ includes.
12473         * gdb_bfd.c: Fix common/ includes.
12474         * gcore.c: Fix common/ includes.
12475         * fork-child.c: Fix common/ includes.
12476         * findvar.c: Fix common/ includes.
12477         * fbsd-nat.c: Fix common/ includes.
12478         * event-top.c: Fix common/ includes.
12479         * event-loop.c: Fix common/ includes.
12480         * dwarf2read.c: Fix common/ includes.
12481         * dwarf2loc.c: Fix common/ includes.
12482         * dwarf2-frame.c: Fix common/ includes.
12483         * dwarf-index-cache.c: Fix common/ includes.
12484         * dtrace-probe.c: Fix common/ includes.
12485         * disasm-selftests.c: Fix common/ includes.
12486         * defs.h: Fix common/ includes.
12487         * csky-tdep.c: Fix common/ includes.
12488         * cp-valprint.c: Fix common/ includes.
12489         * cp-support.h: Fix common/ includes.
12490         * cp-support.c: Fix common/ includes.
12491         * corelow.c: Fix common/ includes.
12492         * completer.h: Fix common/ includes.
12493         * completer.c: Fix common/ includes.
12494         * compile/compile.c: Fix common/ includes.
12495         * compile/compile-loc2c.c: Fix common/ includes.
12496         * compile/compile-cplus-types.c: Fix common/ includes.
12497         * compile/compile-cplus-symbols.c: Fix common/ includes.
12498         * command.h: Fix common/ includes.
12499         * cli/cli-dump.c: Fix common/ includes.
12500         * cli/cli-cmds.c: Fix common/ includes.
12501         * charset.c: Fix common/ includes.
12502         * build-id.c: Fix common/ includes.
12503         * btrace.h: Fix common/ includes.
12504         * btrace.c: Fix common/ includes.
12505         * breakpoint.h: Fix common/ includes.
12506         * breakpoint.c: Fix common/ includes.
12507         * ax.h:
12508         (enum agent_op): Fix common/ includes.
12509         * ax-general.c (struct aop_map): Fix common/ includes.
12510         * ax-gdb.c: Fix common/ includes.
12511         * auxv.c: Fix common/ includes.
12512         * auto-load.c: Fix common/ includes.
12513         * arm-tdep.c: Fix common/ includes.
12514         * arch/riscv.c: Fix common/ includes.
12515         * arch/ppc-linux-common.c: Fix common/ includes.
12516         * arch/i386.c: Fix common/ includes.
12517         * arch/arm.c: Fix common/ includes.
12518         * arch/arm-linux.c: Fix common/ includes.
12519         * arch/arm-get-next-pcs.c: Fix common/ includes.
12520         * arch/amd64.c: Fix common/ includes.
12521         * arch/aarch64.c: Fix common/ includes.
12522         * arch/aarch64-insn.c: Fix common/ includes.
12523         * arch-utils.c: Fix common/ includes.
12524         * amd64-windows-tdep.c: Fix common/ includes.
12525         * amd64-tdep.c: Fix common/ includes.
12526         * amd64-sol2-tdep.c: Fix common/ includes.
12527         * amd64-obsd-tdep.c: Fix common/ includes.
12528         * amd64-nbsd-tdep.c: Fix common/ includes.
12529         * amd64-linux-tdep.c: Fix common/ includes.
12530         * amd64-linux-nat.c: Fix common/ includes.
12531         * amd64-fbsd-tdep.c: Fix common/ includes.
12532         * amd64-fbsd-nat.c: Fix common/ includes.
12533         * amd64-dicos-tdep.c: Fix common/ includes.
12534         * amd64-darwin-tdep.c: Fix common/ includes.
12535         * agent.c: Fix common/ includes.
12536         * ada-lang.h: Fix common/ includes.
12537         * ada-lang.c: Fix common/ includes.
12538         * aarch64-tdep.c: Fix common/ includes.
12539
12540 2019-01-25  Tom Tromey  <tom@tromey.com>
12541
12542         * common/create-version.sh: Use common/version.h.
12543
12544 2019-01-24  Pedro Alves  <palves@redhat.com>
12545
12546         * infrun.c (signal_stop, signal_print, signal_program)
12547         (signal_catch, signal_pass): Now arrays instead of pointers.
12548         (update_signals_program_target, do_target_resume)
12549         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12550         * linux-nat.c (linux_nat_target::pass_signals)
12551         (linux_nat_target::create_inferior, linux_nat_target::attach):
12552         Adjust.
12553         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12554         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12555         * procfs.c (procfs_target::pass_signals): Adjust.
12556         * record-full.c (record_full_target::resume): Adjust.
12557         * remote.c (remote_target::pass_signals)
12558         (remote_target::program_signals): Adjust.
12559         * target-debug.h (target_debug_print_signals): Now takes a
12560         gdb::array_view as parameter.  Adjust.
12561         * target.h (target_ops) <pass_signals, program_signals>: Replace
12562         pointer and length parameters with gdb::array_view.
12563         (target_pass_signals, target_program_signals): Likewise.
12564         * target-delegates.c: Regenerate.
12565
12566 2019-01-24  Pedro Alves  <palves@redhat.com>
12567
12568         * common/forward-scope-exit.h
12569         (forward_scope_exit::forward_scope_exit): Pass arguments to
12570         m_bind_function directly, instead of creating a std::bind and
12571         copying that.
12572
12573 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12574
12575         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12576         for static members.
12577         (pass_in_v_vfp_candidate): Likewise.
12578
12579 2019-01-23  Tom Tromey  <tom@tromey.com>
12580             Pedro Alves  <palves@redhat.com>
12581
12582         * regcache.c (class regcache_invalidator): Remove.
12583         (regcache::raw_write): Use make_scope_exit.
12584
12585 2019-01-23  Tom Tromey  <tom@tromey.com>
12586
12587         * ui-out.h (class ui_out_emit_type): Update comment.
12588
12589 2019-01-23  Tom Tromey  <tom@tromey.com>
12590
12591         * infrun.c (fetch_inferior_event): Update comment.
12592
12593 2019-01-23  Tom Tromey  <tom@tromey.com>
12594             Pedro Alves  <palves@redhat.com>
12595
12596         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12597         parameter.
12598         (fetch_inferior_event): Use SCOPE_EXIT.
12599
12600
12601 2019-01-23  Tom Tromey  <tom@tromey.com>
12602             Pedro Alves  <palves@redhat.com>
12603
12604         * infrun.c (disable_thread_events): Delete.
12605         (stop_all_threads): Use SCOPE_EXIT.
12606
12607 2019-01-23  Tom Tromey  <tom@tromey.com>
12608             Pedro Alves  <palves@redhat.com>
12609
12610         * symfile.c: Include forward-scope-exit.h.
12611         (clear_symtab_users_cleanup): Replace forward declaration with
12612         a FORWARD_SCOPE_EXIT.
12613         (syms_from_objfile_1): Use the forward_scope_exit and
12614         gdb::optional instead of cleanup_function.
12615         (reread_symbols): Use the forward_scope_exit instead of
12616         cleanup_function.
12617         (clear_symtab_users_cleanup): Remove function.
12618
12619 2019-01-23  Tom Tromey  <tom@tromey.com>
12620             Pedro Alves  <palves@redhat.com>
12621
12622         * linux-nat.c: Include scope-exit.h.
12623         (cleanup_target_stop): Remove.
12624         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12625         SCOPE_EXIT.
12626
12627 2019-01-23  Tom Tromey  <tom@tromey.com>
12628             Pedro Alves  <palves@redhat.com>
12629
12630         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12631         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12632
12633 2019-01-23  Tom Tromey  <tom@tromey.com>
12634             Andrew Burgess  <andrew.burgess@embecosm.com>
12635             Pedro Alves  <palves@redhat.com>
12636
12637         * infrun.c (fetch_inferior_event): Use scope_exit.
12638         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12639         * top.c (execute_command): Use scope_exit.
12640         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12641         * utils.c (do_bpstat_clear_actions_cleanup)
12642         (make_bpstat_clear_actions_cleanup): Remove.
12643
12644 2019-01-23  Tom Tromey  <tom@tromey.com>
12645             Pedro Alves  <palves@redhat.com>
12646
12647         * infrun.c: Include "common/scope-exit.h"
12648         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12649         (wait_for_inferior): Use SCOPE_EXIT.
12650         (fetch_inferior_event): Use scope_exit.
12651
12652 2019-01-23  Tom Tromey  <tom@tromey.com>
12653             Pedro Alves  <palves@redhat.com>
12654
12655         * breakpoint.c (create_breakpoint): Remove cleanup.
12656
12657 2019-01-23  Tom Tromey  <tom@tromey.com>
12658             Andrew Burgess  <andrew.burgess@embecosm.com>
12659             Pedro Alves  <palves@redhat.com>
12660
12661 2019-01-23  Pedro Alves  <palves@redhat.com>
12662
12663         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12664
12665 2019-01-23  Pedro Alves  <palves@redhat.com>
12666             Andrew Burgess  <andrew.burgess@embecosm.com>
12667
12668         * gdbthread.h: Include "common/forward-scope-exit.h".
12669         (scoped_finish_thread_state): Redefine custom class in terms of
12670         forward_scope_exit.
12671
12672 2019-01-23  Pedro Alves  <palves@redhat.com>
12673             Andrew Burgess  <andrew.burgess@embecosm.com>
12674
12675         * common/forward-scope-exit.h: New file.
12676
12677 2019-01-23  Pedro Alves  <palves@redhat.com>
12678             Andrew Burgess  <andrew.burgess@embecosm.com>
12679             Tom Tromey  <tom@tromey.com>
12680
12681         * common/scope-exit.h: New file.
12682
12683 2019-01-23  Pedro Alves  <palves@redhat.com>
12684
12685         * common/preprocessor.h (ESC): Rename to ...
12686         (ESC_PARENS): ... this.
12687         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12688         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12689
12690 2019-01-23  Tom Tromey  <tom@tromey.com>
12691
12692         * language.h (class scoped_switch_to_sym_language_if_auto):
12693         Initialize m_lang in both cases.
12694
12695 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12696
12697         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12698         with XCNEW.
12699
12700 2019-01-22  Tom Tromey  <tom@tromey.com>
12701
12702         * corelow.c: Do not include sys/file.h.
12703
12704 2019-01-22  Tom Tromey  <tom@tromey.com>
12705
12706         * tui/tui-wingeneral.h: Include gdb_curses.h.
12707
12708 2019-01-22  Tom Tromey  <tom@tromey.com>
12709
12710         * source-cache.h (class source_cache) <get_source_lines,
12711         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12712
12713 2019-01-22  Tom Tromey  <tom@tromey.com>
12714
12715         * remote-fileio.h (struct remote_target): Declare.
12716
12717 2019-01-22  Tom Tromey  <tom@tromey.com>
12718
12719         * python/py-arch.c: Do not include py-ref.h.
12720         * python/py-bpevent.c: Do not include py-ref.h.
12721         * python/py-cmd.c: Do not include py-ref.h.
12722         * python/py-continueevent.c: Do not include py-ref.h.
12723         * python/py-event.h: Do not include py-ref.h.
12724         * python/py-evtregistry.c: Do not include py-ref.h.
12725         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12726         * python/py-frame.c: Do not include py-ref.h.
12727         * python/py-framefilter.c: Do not include py-ref.h.
12728         * python/py-function.c: Do not include py-ref.h.
12729         * python/py-infevents.c: Do not include py-ref.h.
12730         * python/py-linetable.c: Do not include py-ref.h.
12731         * python/py-objfile.c: Do not include py-ref.h.
12732         * python/py-param.c: Do not include py-ref.h.
12733         * python/py-prettyprint.c: Do not include py-ref.h.
12734         * python/py-progspace.c: Do not include py-ref.h.
12735         * python/py-symbol.c: Do not include py-ref.h.
12736         * python/py-symtab.c: Do not include py-ref.h.
12737         * python/py-type.c: Do not include py-ref.h.
12738         * python/py-unwind.c: Do not include py-ref.h.
12739         * python/py-utils.c: Do not include py-ref.h.
12740         * python/py-value.c: Do not include py-ref.h.
12741         * python/py-varobj.c: Do not include py-ref.h.
12742         * python/py-xmethods.c: Do not include py-ref.h.
12743         * python/python.c: Do not include py-ref.h.
12744         * varobj.c: Do not include py-ref.h.
12745
12746 2019-01-22  Tom Tromey  <tom@tromey.com>
12747
12748         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12749         keyword for bcache.
12750
12751 2019-01-22  Tom Tromey  <tom@tromey.com>
12752
12753         * compile/compile-cplus-types.c: Remove a comment by #include.
12754
12755 2019-01-22  Tom Tromey  <tom@tromey.com>
12756
12757         * compile/gcc-c-plugin.h: Include compile-internal.h.
12758
12759 2019-01-22  Tom Tromey  <tom@tromey.com>
12760
12761         * stabsread.c (EXTERN): Do not define.
12762         (symnum, next_symbol_text_func, processing_gcc_compilation)
12763         (within_function, global_sym_chain, global_stabs)
12764         (previous_stab_code, this_object_header_files)
12765         (n_this_object_header_files)
12766         (n_allocated_this_object_header_files): Define.
12767         * stabsread.h (EXTERN): Never define.  Use "extern".
12768
12769 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12770
12771         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12772         history_value.
12773
12774 2019-01-21  Tom Tromey  <tom@tromey.com>
12775
12776         * ui-out.c: Fix includes.
12777         * tui/tui-source.c: Fix includes.
12778         * target.c: Fix includes.
12779         * remote.c: Fix includes.
12780         * regcache.c: Fix includes.
12781         * python/py-block.c: Fix includes.
12782         * printcmd.c: Fix includes.
12783         * or1k-tdep.c: Fix includes.
12784         * mi/mi-main.c: Fix includes.
12785         * m32r-tdep.c: Fix includes.
12786         * csky-tdep.c: Fix includes.
12787         * compile/compile-cplus-types.c: Fix includes.
12788         * cli/cli-interp.c: Fix includes.
12789
12790 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12791
12792         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12793         for padding.
12794
12795 2019-01-16  Tom Tromey  <tom@tromey.com>
12796
12797         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12798         earlier.
12799         (struct objfile) <msymbols_range>: Move from top level.
12800         <msymbols>: New method.
12801         (class objfile_msymbols): Remove.
12802         * symtab.c (default_collect_symbol_completion_matches_break_on):
12803         Update.
12804         * symmisc.c (dump_msymbols): Update.
12805         * stabsread.c (scan_file_globals): Update.
12806         * objc-lang.c (info_selectors_command, info_classes_command)
12807         (find_methods): Update.
12808         * minsyms.c (find_solib_trampoline_target): Update.
12809         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12810         * coffread.c (coff_symfile_read): Update.
12811         * ada-lang.c (ada_lookup_simple_minsym)
12812         (ada_collect_symbol_completion_matches): Update.
12813
12814 2019-01-16  Tom Tromey  <tom@tromey.com>
12815
12816         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12817         type.  Remove no-argument constructor.
12818         <iterator::operator++>: Simplify.
12819         <begin>: Update.
12820         <end>: Use minimal_symbol_count.
12821
12822 2019-01-16  Tom Tromey  <tom@tromey.com>
12823
12824         * objfiles.h (struct objfile) <psymtabs>: New method.
12825         (class objfile_psymtabs): Remove.
12826         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12827         typedef.
12828         <range>: New method.
12829         (require_partial_symbols): Change return type.
12830         * psymtab.c (require_partial_symbols)
12831         (psym_expand_symtabs_matching): Update.
12832         * mdebugread.c (parse_partial_symbols): Update.
12833         * dbxread.c (dbx_end_psymtab): Update.
12834
12835 2019-01-15  Tom Tromey  <tom@tromey.com>
12836
12837         * symtab.c (lookup_objfile_from_block)
12838         (lookup_symbol_in_objfile_symtabs)
12839         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12840         (find_line_symtab, info_sources_command)
12841         (default_collect_symbol_completion_matches_break_on)
12842         (make_source_files_completion_list): Update.
12843         * symmisc.c (print_objfile_statistics, dump_objfile)
12844         (maintenance_print_symbols, maintenance_info_symtabs)
12845         (maintenance_check_symtabs, maintenance_info_line_tables):
12846         Update.
12847         * source.c (select_source_symtab)
12848         (forget_cached_source_info_for_objfile): Update.
12849         * objfiles.h (class objfile_compunits): Remove.
12850         (struct objfile) <compunits_range>: New typedef.
12851         (compunits): New method.
12852         * objfiles.c (objfile_relocate1): Update.
12853         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12854         * maint.c (count_symtabs_and_blocks): Update.
12855         * linespec.c (iterate_over_all_matching_symtabs): Update.
12856         * cp-support.c (add_symbol_overload_list_qualified): Update.
12857         * coffread.c (coff_symtab_read): Update.
12858         * ada-lang.c (add_nonlocal_symbols)
12859         (ada_collect_symbol_completion_matches)
12860         (ada_add_global_exceptions): Update.
12861
12862 2019-01-15  Tom Tromey  <tom@tromey.com>
12863
12864         * progspace.h (program_space) <objfiles_safe_range>: New
12865         typedef.
12866         <objfiles_safe>: New method.
12867         * objfiles.h (class all_objfiles_safe): Remove.
12868         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12869         * jit.c (jit_inferior_exit_hook): Update.
12870
12871 2019-01-17  Tom Tromey  <tom@tromey.com>
12872
12873         * progspace.h (program_space) <objfiles_range>: New typedef.
12874         <objfiles>: New method.
12875         <objfiles_head>: Rename from objfiles.
12876         (object_files): Update.
12877         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12878         * guile/scm-pretty-print.c
12879         (ppscm_find_pretty_printer_from_objfiles): Update.
12880         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12881         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12882         Update.
12883         * python/py-progspace.c (pspy_get_objfiles): Update.
12884         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12885         Update.
12886         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12887         (objfpy_lookup_objfile_by_build_id): Update.
12888         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12889         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12890         Update.
12891         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12892         (expand_symtab_containing_pc, lookup_objfile_from_block)
12893         (lookup_static_symbol, basic_lookup_transparent_type)
12894         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12895         (find_line_symtab, info_sources_command)
12896         (default_collect_symbol_completion_matches_break_on)
12897         (make_source_files_completion_list, find_main_name): Update.
12898         * symmisc.c (print_symbol_bcache_statistics)
12899         (print_objfile_statistics, maintenance_print_symbols)
12900         (maintenance_print_msymbols, maintenance_print_objfiles)
12901         (maintenance_info_symtabs, maintenance_check_symtabs)
12902         (maintenance_expand_symtabs, maintenance_info_line_tables):
12903         Update.
12904         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12905         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12906         (map_overlay_command, unmap_overlay_command)
12907         (simple_overlay_update, expand_symtabs_matching)
12908         (map_symbol_filenames): Update.
12909         * symfile-debug.c (set_debug_symfile): Update.
12910         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12911         Update.
12912         * source.c (select_source_symtab, forget_cached_source_info):
12913         Update.
12914         * solib.c (solib_read_symbols): Update.
12915         * solib-spu.c (append_ocl_sos): Update.
12916         * psymtab.c (maintenance_print_psymbols)
12917         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12918         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12919         * printcmd.c (info_symbol_command): Update.
12920         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12921         Update.
12922         * objfiles.h (class all_objfiles): Remove.
12923         * objfiles.c (have_partial_symbols, have_full_symbols)
12924         (have_minimal_symbols, qsort_cmp, update_section_map)
12925         (shared_objfile_contains_address_p)
12926         (default_iterate_over_objfiles_in_search_order): Update.
12927         * objc-lang.c (info_selectors_command, info_classes_command)
12928         (find_methods): Update.
12929         * minsyms.c (find_solib_trampoline_target): Update.
12930         * maint.c (maintenance_info_sections)
12931         (maintenance_translate_address, count_symtabs_and_blocks):
12932         Update.
12933         * main.c (captured_main_1): Update.
12934         * linux-thread-db.c (try_thread_db_load_from_pdir)
12935         (has_libpthread): Update.
12936         * linespec.c (iterate_over_all_matching_symtabs)
12937         (search_minsyms_for_name): Update.
12938         * jit.c (jit_find_objf_with_entry_addr): Update.
12939         * hppa-tdep.c (find_unwind_entry)
12940         (hppa_lookup_stub_minimal_symbol): Update.
12941         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12942         Update.
12943         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12944         (elf_gnu_ifunc_resolve_by_got): Update.
12945         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12946         * dwarf-index-write.c (save_gdb_index_command): Update.
12947         * cp-support.c (add_symbol_overload_list_qualified): Update.
12948         * breakpoint.c (create_overlay_event_breakpoint)
12949         (create_longjmp_master_breakpoint)
12950         (create_std_terminate_master_breakpoint)
12951         (create_exception_master_breakpoint): Update.
12952         * blockframe.c (find_pc_partial_function): Update.
12953         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12954         (ada_collect_symbol_completion_matches)
12955         (ada_add_global_exceptions): Update.
12956
12957 2019-01-17  Tom Tromey  <tom@tromey.com>
12958
12959         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12960         declare VEC.
12961         (solib_target_parse_libraries): Change return type.
12962         (library_list_start_segment, library_list_start_section)
12963         (library_list_end_library, library_list_start_library); Update.
12964         (solib_target_free_library_list): Remove.
12965         (solib_target_parse_libraries): Remove cleanup.  Change return
12966         type.
12967         (solib_target_current_sos): Update.
12968
12969 2019-01-17  Tom Tromey  <tromey@bapiya>
12970
12971         * valprint.c: Replace "the the" with "the".
12972         * symtab.c: Replace "the the" with "the".
12973         * solib.c: Replace "the the" with "the".
12974         * solib-dsbt.c: Replace "the the" with "the".
12975         * linespec.c: Replace "the the" with "the".
12976         * dwarf2loc.h: Replace "the the" with "the".
12977         * amd64-windows-tdep.c: Replace "the the" with "the".
12978         * aarch64-tdep.c: Replace "the the" with "the".
12979
12980 2019-01-16  Keith Seitz  <keiths@redhat.com>
12981
12982         PR gdb/23773
12983         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12984         <builder>: Rename to ..
12985         <m_builder>: ... this and make private.
12986         (dwarf2_cu::get_builder): New method.  Change all users of
12987         `builder' to use this method.
12988         (dwarf2_start_symtab): Move to ...
12989         (dwarf2_cu::start_symtab): ... here.  Update all callers
12990         (setup_type_unit_groups): Move to ...
12991         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12992         callers.
12993         (dwarf2_cu::reset_builder): New method.
12994         (process_full_compunit, process_full_type_unit): Use
12995         dwarf2_cu::reset_builder.
12996         (follow_die_offset): Record the ancestor CU if it is different
12997         from the followed DIE's CU.
12998         (follow_die_sig_1): Likewise.
12999
13000 2019-01-15  Tom Tromey  <tom@tromey.com>
13001
13002         * remote.c (class remote_state) <buf>: Now a char_vector.
13003         <buf_size>: Remove.
13004         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13005         parameter.
13006         (remote_target::getpkt_or_notif_sane_1)
13007         (remote_target::getpkt_sane)
13008         (remote_target::getpkt_or_notif_sane): Likewise.
13009         (class remote_target) <putpkt>: New overload.
13010         (remote_target::read_frame): Change type of "buf_p".  Remove
13011         sizeof_p parameter.
13012         (packet_ok): New overload.
13013         (packet_check_result): New overload.
13014         Update all uses.
13015
13016 2019-01-14  Tom Tromey  <tom@tromey.com>
13017
13018         * remote-notif.c (handle_notification, remote_notif_ack)
13019         (remote_notif_parse): Make "buf" const.
13020         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13021         const.
13022         (remote_notif_parse, remote_notif_ack, handle_notification):
13023         Likewise.
13024         * remote.c (remote_notif_stop_parse): Make "buf" const.
13025         (remote_target::remote_parse_stop_reply): Make "buf" const.
13026         (remote_notif_stop_ack): Make "buf" const.
13027
13028 2019-01-14  Tom Tromey  <tom@tromey.com>
13029
13030         * remote.c (remote_console_output): Make parameter const.
13031
13032 2019-01-14  Tom Tromey  <tom@tromey.com>
13033
13034         * target-debug.h (target_debug_print_signals): Constify.
13035         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13036         * procfs.c (procfs_target::pass_signals): Update.
13037         * linux-nat.c (linux_nat_target::pass_signals): Update.
13038         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13039         * target-delegates.c: Rebuild.
13040         * remote.c (remote_target::program_signals): Update.
13041         (remote_target::pass_signals): Update.
13042         * target.c (target_pass_signals): Constify argument.
13043         (target_program_signals): Likewise.
13044         * target.h (struct target_ops) <pass_signals, program_signals>:
13045         Constify argument.
13046         (target_pass_signals, target_program_signals): Constify argument.
13047
13048 2019-01-14  Tom Tromey  <tom@tromey.com>
13049
13050         PR tui/28819:
13051         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13052
13053 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13054
13055         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13056         field.
13057         * rs6000-tdep.c: Include reggroups.h.
13058         (IS_V_ALIAS_PSEUDOREG): Define.
13059         (rs6000_register_name): Return names for the "vX" aliases.
13060         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13061         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13062         aliases.  Call default_register_reggroup_p for all other
13063         pseudo-registers.
13064         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13065         New functions.
13066         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13067         Handle "vX" aliases.
13068         (v_alias_pseudo_register_collect): New function.
13069         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13070         (rs6000_gdbarch_init): Initialize "vX" aliases as
13071         pseudo-registers.  Restore registration of
13072         rs6000_pseudo_register_reggroup_p with
13073         set_tdesc_pseudo_register_reggroup_p.
13074
13075 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13076
13077         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13078         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13079         set_gdbarch_num_pseudo_regs.
13080
13081 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13082
13083         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13084         Remove arg prefixname, add do_set and do_show.
13085         Add member functions set_list and show_list.
13086         * cli/cli-style.c (class cli_style_option): Update accordingly.
13087         (style_set_list): Move to file scope.
13088         (style_show_list): Likewise.
13089         (set_style): Call help_list.
13090         (show_style): Call cmd_show_list.
13091         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13092         Update to use the new macro.
13093
13094 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13095
13096         * ada-lang.c (_initialize_ada_language): Expand the help text
13097         for the "catch exception" command.
13098
13099 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13100
13101         * symtab.c (matching_obj_sections): Initialize obj,
13102         declare it closer to its usage.
13103
13104 2019-01-10  Tom Tromey  <tom@tromey.com>
13105
13106         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13107         (basic_inf_threads_range): Remove.
13108         (inf_threads_range, inf_non_exited_threads_range)
13109         (safe_inf_threads_range): Use next_adapter.
13110
13111 2019-01-10  Keith Seitz  <keiths@redhat.com>
13112
13113         PR gdb/23712
13114         PR symtab/23010
13115         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13116         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13117
13118 2019-01-10  Keith Seitz  <keiths@redhat.com>
13119
13120         PR gdb/23712
13121         PR symtab/23010
13122         * dictionary.c (pending_to_vector): Remove.
13123         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13124         Remove _1 suffix, replacing functions of the same name.  Update
13125         all callers.
13126         (dict_create_hashed, dict_create_hashed_expandable)
13127         (dict_create_linear, dict_create_linear_expandable, dict_free)
13128         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13129         Make functions static.
13130
13131 2019-01-10  Keith Seitz  <keiths@redhat.com>
13132
13133         PR gdb/23712
13134         PR symtab/23010
13135         * dictionary.h (struct dictionary): Replace declaration with
13136         multidictionary.
13137         (dict_create_hashed, dict_create_hashed_expandable)
13138         (dict_create_linear, dict_create_linear_expandable)
13139         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13140         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13141         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13142         taking multidictionary argument.
13143         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13144         * block.h (struct block) <dict>: Change to multidictionary
13145         and rename `multidict'.
13146         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13147         symmisc.c: Update all dictionary references to multidictionary.
13148
13149 2019-01-10  Keith Seitz  <keiths@redhat.com>
13150
13151         PR gdb/23712
13152         PR symtab/23010
13153         * dictionary.c: Include unordered_map.
13154         (pending_to_vector): New function.
13155         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13156         Rewrite the non-"_1" functions to take vector instead
13157         of linked list.
13158         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13159         "new" _1 versions of the same name.
13160         (multidictionary): Define.
13161         (std::hash<enum language): New definition.
13162         (collate_pending_symbols_by_language, mdict_create_hashed)
13163         (mdict_create_hashed_expandable, mdict_create_linear)
13164         (mdict_create_linear_expandable, mdict_free)
13165         (find_language_dictionary, create_new_language_dictionary)
13166         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13167         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13168         (mdict_size, mdict_empty): New functions.
13169         * dictionary.h (mdict_iterator): Define.
13170
13171 2019-01-10  Pedro Alves  <palves@redhat.com>
13172
13173         * breakpoint.c (read_uploaded_action)
13174         (create_tracepoint_from_upload): Adjust to use
13175         gdb::unique_xmalloc_ptr.
13176         * ctf.c (ctf_write_uploaded_tp):
13177         (SET_ARRAY_FIELD): Use emplace_back.
13178         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13179         * tracefile-tfile.c (tfile_write_uploaded_tp):
13180         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13181         gdb::unique_xmalloc_ptr.
13182         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13183         at_string, cond_string, cmd_strings>: Replace char pointers
13184         with gdb::unique_xmalloc_ptr.
13185
13186 2019-01-10  Pedro Alves  <palves@redhat.com>
13187
13188         * solib-target.c (library_list_start_library): Don't xstrdup name.
13189
13190 2019-01-10  Pedro Alves  <palves@redhat.com>
13191
13192         * mdebugread.c (parse_partial_symbols): Use
13193         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13194
13195 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13196
13197         * linux-fork.c (scoped_switch_fork_info)
13198         <~scoped_switch_fork_info>: Fix incorrect variable name.
13199
13200 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13201
13202         * linux-fork.c (scoped_switch_fork_info)
13203         <scoped_switch_fork_info>: Make explicit.
13204         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13205
13206 2019-01-10  Tom Tromey  <tom@tromey.com>
13207
13208         * objfiles.h (objfile::reset_psymtabs): Update.
13209         * objfiles.c (objfile::objfile): Update.
13210         * psymtab.h (psymtab_storage::obstack): Update.
13211         (psymtab_storage::m_obstack): Use gdb::optional.
13212         (class psymtab_storage): Update comment.  Remove objfile
13213         parameter.
13214         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13215
13216 2019-01-10  Tom Tromey  <tom@tromey.com>
13217
13218         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13219         <free_psymtabs>: Now private.
13220         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13221         (allocate_psymtab): Use new method.
13222
13223 2019-01-10  Tom Tromey  <tom@tromey.com>
13224
13225         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13226         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13227         * mdebugread.c (parse_partial_symbols): Use
13228         allocate_dependencies.
13229         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13230         allocate_dependencies.
13231         (process_psymtab_comp_unit_reader)
13232         (build_type_psymtab_dependencies): Likewise.
13233         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13234
13235 2019-01-10  Tom Tromey  <tom@tromey.com>
13236
13237         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13238         PSYMBOL_SET_LANGUAGE.
13239         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13240
13241 2019-01-10  Tom Tromey  <tom@tromey.com>
13242
13243         * psymtab.h (psymtab_storage::obstack): New method.
13244         <m_obstack>: Rename from obstack; now private.
13245         * psymtab.c (psymtab_storage): Update.
13246         * dwarf2read.c (create_addrmap_from_index)
13247         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13248         Update.
13249
13250 2019-01-10  Tom Tromey  <tom@tromey.com>
13251
13252         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13253         * objfiles.h (objfile::reset_psymtabs): New method.
13254
13255 2019-01-10  Tom Tromey  <tom@tromey.com>
13256
13257         * symmisc.c (print_symbol_bcache_statistics): Update.
13258         (print_objfile_statistics): Update.
13259         * symfile.c (reread_symbols): Update.
13260         * psymtab.h (class psymtab_storage): New.
13261         * psymtab.c (psymtab_storage): New constructor.
13262         (~psymtab_storage): New destructor.
13263         (require_partial_symbols): Update.
13264         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13265         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13266         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13267         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13268         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13269         (start_psymtab_common, end_psymtab_common)
13270         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13271         (allocate_psymtab): Update.
13272         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13273         Update.
13274         (dump_psymtab_addrmap, maintenance_print_psymbols)
13275         (maintenance_check_psymtabs): Update.
13276         (class objfile_psymtabs): Move to objfiles.h.
13277         * psympriv.h (discard_psymtab): Now inline.
13278         (psymtab_discarder::psymtab_discarder): Update.
13279         (psymtab_discarder::~psymtab_discarder): Update.
13280         (ALL_OBJFILE_PSYMTABS): Rewrite.
13281         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13282         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13283         Remove fields.
13284         <partial_symtabs>: New field.
13285         (class objfile_psymtabs): Move from psymtab.h.  Update.
13286         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13287         psymbol_cache.
13288         (objfile::~objfile): Don't destroy psymbol_cache.
13289         * mdebugread.c (parse_partial_symbols): Update.
13290         * dwarf2read.c (create_addrmap_from_index)
13291         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13292         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13293         (add_partial_subprogram, dwarf2_ranges_read): Update.
13294         * dwarf-index-write.c (write_address_map)
13295         (write_one_signatured_type, recursively_write_psymbols)
13296         (class debug_names, class debug_names, write_psymtabs_to_index):
13297         Update.
13298
13299 2019-01-10  Tom Tromey  <tom@tromey.com>
13300
13301         * symtab.h (SYMBOL_SET_NAMES): Update.
13302         (symbol_set_names): Update.
13303         (MSYMBOL_SET_NAMES): Update.
13304         * symtab.c (symbol_set_names): Change argument to be an
13305         objfile_per_bfd_storage.
13306         * psymtab.c (add_psymbol_to_bcache): Update.
13307         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13308
13309 2019-01-10  Tom Tromey  <tom@tromey.com>
13310
13311         * symtab.c (create_demangled_names_hash): Change argument to be an
13312         objfile_per_bfd_storage.
13313         (symbol_set_names): Update.
13314
13315 2019-01-10  Tom Tromey  <tom@tromey.com>
13316
13317         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13318         init_psymbol_list.
13319         * psymtab.c (init_psymbol_list): Do nothing if already called.
13320         * psympriv.h (init_psymbol_list): Add comment.
13321         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13322         init_psymbol_list.
13323         * dbxread.c (dbx_symfile_read): Unconditionally call
13324         init_psymbol_list.
13325
13326 2019-01-10  Tom Tromey  <tom@tromey.com>
13327
13328         * xcoffread.c (scan_xcoff_symtab): Update.
13329         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13330         "where".
13331         * mdebugread.c (parse_partial_symbols)
13332         (handle_psymbol_enumerators): Update.
13333         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13334         * dbxread.c (read_dbx_symtab): Update.
13335         * psympriv.h (psymbol_placement): New enum.
13336         (add_psymbol_to_list): Update.
13337
13338 2019-01-10  Tom Tromey  <tom@tromey.com>
13339
13340         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13341         static_psymbols parameters.
13342         (scan_xcoff_symtab): Update.
13343         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13344         static_psymbols parameters.
13345         * psympriv.h (start_psymtab_common): Update.
13346         * mdebugread.c (parse_partial_symbols): Update.
13347         * dwarf2read.c (create_partial_symtab): Update.
13348         * dbxread.c (read_dbx_symtab): Update.
13349         (start_psymtab): Remove global_psymbols and static_psymbols
13350         parameters.
13351
13352 2019-01-10  Tom Tromey  <tom@tromey.com>
13353
13354         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13355         * psymtab.c (allocate_psymtab): Add comment.
13356         * psympriv.h (allocate_psymtab): Add comment.
13357         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13358         initializations.
13359         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13360
13361 2019-01-10  Tom Tromey  <tom@tromey.com>
13362
13363         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13364         Don't declare.
13365         * mipsread.c: Include mdebugread.h.
13366         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13367         Declare.
13368         * elfread.c: Include mdebugread.h.
13369
13370 2019-01-09  Tom Tromey  <tom@tromey.com>
13371
13372         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13373         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13374         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13375         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13376         (psym_lookup_symbol, psym_find_last_source_symtab)
13377         (psym_forget_cached_source_info, psym_print_stats)
13378         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13379         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13380         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13381         (psym_find_compunit_symtab_by_address)
13382         (maintenance_print_psymbols, maintenance_info_psymtabs)
13383         (maintenance_check_psymtabs): Use ranged for.
13384         * psymtab.h (class objfile_psymtabs): New.
13385         (require_partial_symbols): Return objfile_psymtabs.
13386         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13387
13388 2019-01-09  Tom Tromey  <tom@tromey.com>
13389
13390         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13391         (find_pc_mapped_section, list_overlays_command)
13392         (map_overlay_command, unmap_overlay_command)
13393         (simple_overlay_update): Use all_objfiles.
13394         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13395         * printcmd.c (info_symbol_command): Use all_objfiles.
13396         * objfiles.h (ALL_OBJSECTIONS): Remove.
13397         * maint.c (maintenance_translate_address): Use all_objfiles.
13398         * gcore.c (gcore_create_callback): Use all_objfiles.
13399         (objfile_find_memory_regions): Likewise.
13400
13401 2019-01-09  Tom Tromey  <tom@tromey.com>
13402
13403         * symtab.c (find_line_symtab, info_sources_command)
13404         (make_source_files_completion_list): Use objfile_compunits.
13405         * source.c (select_source_symtab): Use objfile_compunits.
13406         * objfiles.h (struct objfile): Update comment.
13407         (ALL_OBJFILES): Remove.
13408         (ALL_FILETABS): Remove.
13409         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13410         objfile_compunits.
13411
13412 2019-01-09  Tom Tromey  <tom@tromey.com>
13413
13414         * symmisc.c (print_objfile_statistics, dump_objfile)
13415         (maintenance_print_symbols): Use compunit_filetabs.
13416         * source.c (forget_cached_source_info_for_objfile): Use
13417         compunit_filetabs.
13418         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13419         (ALL_FILETABS): Use compunit_filetabs.
13420         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13421         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13422
13423 2019-01-09  Tom Tromey  <tom@tromey.com>
13424
13425         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13426         (compunit_filetabs): New.
13427         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13428         compunit_filetabs.
13429         (info_sources_command, make_source_files_completion_list): Remove
13430         declaration.
13431         * symmisc.c (print_objfile_statistics, dump_objfile)
13432         (maintenance_print_symbols): Remove declaration.
13433         (maintenance_info_symtabs): Use compunit_filetabs.
13434         (maintenance_info_line_tables): Likewise.
13435         * source.c (select_source_symtab): Change local variable name.
13436         (forget_cached_source_info_for_objfile): Remove declaration.
13437         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13438         * objfiles.c (objfile_relocate1): Remove declaration.
13439         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13440         declaration.
13441         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13442         * coffread.c (coff_symtab_read): Remove declaration.
13443         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13444         compunit_filetabs.
13445
13446 2019-01-09  Tom Tromey  <tom@tromey.com>
13447
13448         * symtab.c (lookup_objfile_from_block)
13449         (find_pc_sect_compunit_symtab, search_symbols)
13450         (default_collect_symbol_completion_matches_break_on): Use
13451         objfile_compunits.
13452         * objfiles.h (ALL_COMPUNITS): Remove.
13453         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13454         * cp-support.c (add_symbol_overload_list_qualified): Use
13455         objfile_compunits.
13456         * ada-lang.c (ada_collect_symbol_completion_matches)
13457         (ada_add_global_exceptions): Use objfile_compunits.
13458
13459 2019-01-09  Tom Tromey  <tom@tromey.com>
13460
13461         * source.c (select_source_symtab)
13462         (forget_cached_source_info_for_objfile): Remove declaration.
13463         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13464         declaration.
13465         * maint.c (count_symtabs_and_blocks): Remove declaration.
13466         * cp-support.c (add_symbol_overload_list_qualified): Remove
13467         declaration.
13468         * coffread.c (coff_symtab_read): Remove declaration.
13469         * symtab.c (lookup_symbol_in_objfile_symtabs)
13470         (basic_lookup_transparent_type_1): Use objfile_compunits.
13471         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13472         (info_sources_command, search_symbols)
13473         (default_collect_symbol_completion_matches_break_on)
13474         (make_source_files_completion_list): Remove declaration.
13475         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13476         (ada_collect_symbol_completion_matches)
13477         (ada_add_global_exceptions): Remove declaration.
13478         * linespec.c (iterate_over_all_matching_symtabs): Use
13479         objfile_compunits.
13480         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13481         (class objfile_compunits): New.
13482         (ALL_COMPUNITS): Use objfile_compunits.
13483         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13484         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13485         objfile_compunits.
13486         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13487
13488 2019-01-09  Tom Tromey  <tom@tromey.com>
13489
13490         * symtab.c (search_symbols)
13491         (default_collect_symbol_completion_matches_break_on): Use
13492         objfile_msymbols.
13493         * ada-lang.c (ada_lookup_simple_minsym)
13494         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13495         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13496         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13497         objfile_msymbols.
13498         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13499         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13500         * objc-lang.c (find_methods): Use objfile_msymbols.
13501         (info_selectors_command, info_classes_command): Likewise.
13502         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13503         * objfiles.h (class objfile_msymbols): New.
13504         (ALL_OBJFILE_MSYMBOLS): Remove.
13505         (ALL_MSYMBOLS): Remove.
13506
13507 2019-01-09  Tom Tromey  <tom@tromey.com>
13508
13509         * common/next-iterator.h (next_adapter): Add Iterator template
13510         parameter.
13511         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13512         (class all_objfiles_safe): New.
13513         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13514         * objfiles.c (put_objfile_before): Update comment.
13515         (add_separate_debug_objfile): Likewise.
13516         (free_all_objfiles): Use all_objfiles_safe.
13517         (objfile_purge_solibs): Likewise.
13518
13519 2019-01-09  Tom Tromey  <tom@tromey.com>
13520
13521         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13522         (expand_symtab_containing_pc, lookup_static_symbol)
13523         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13524         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13525         all_objfiles.
13526         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13527         * breakpoint.c (create_overlay_event_breakpoint)
13528         (create_longjmp_master_breakpoint)
13529         (create_std_terminate_master_breakpoint)
13530         (create_exception_master_breakpoint): Use all_objfiles.
13531         * linux-thread-db.c (try_thread_db_load_from_pdir)
13532         (has_libpthread): Use all_objfiles.
13533         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13534         * linespec.c (iterate_over_all_matching_symtabs)
13535         (search_minsyms_for_name): Use all_objfiles.
13536         * maint.c (maintenance_info_sections): Use all_objfiles.
13537         * main.c (captured_main_1): Use all_objfiles.
13538         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13539         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13540         * guile/scm-pretty-print.c
13541         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13542         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13543         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13544         (maintenance_print_msymbols): Use all_objfiles.
13545         * source.c (select_source_symtab): Use all_objfiles.
13546         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13547         * symfile.c (remove_symbol_file_command)
13548         (expand_symtabs_matching, map_symbol_filenames): Use
13549         all_objfiles.
13550         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13551         all_objfiles.
13552         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13553         * objc-lang.c (find_methods): Use all_objfiles.
13554         * objfiles.c (have_partial_symbols, have_full_symbols)
13555         (have_minimal_symbols, qsort_cmp)
13556         (default_iterate_over_objfiles_in_search_order): Use
13557         all_objfiles.
13558         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13559         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13560         (maintenance_check_psymtabs): Use all_objfiles.
13561         (ALL_PSYMTABS): Remove.
13562         * compile/compile-object-run.c (do_module_cleanup): Use
13563         all_objfiles.
13564         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13565         * cp-support.c (add_symbol_overload_list_qualified): Use
13566         all_objfiles.
13567         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13568         Use all_objfiles.
13569         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13570         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13571         all_objfiles.
13572         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13573         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13574         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13575         Uses all_objfiles.
13576         * solib.c (solib_read_symbols): Use all_objfiles
13577
13578 2019-01-09  Tom Tromey  <tom@tromey.com>
13579
13580         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13581         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13582         all_objfiles.
13583         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13584         * symmisc.c (print_symbol_bcache_statistics)
13585         (print_objfile_statistics, maintenance_print_objfiles)
13586         (maintenance_info_symtabs, maintenance_check_symtabs)
13587         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13588         all_objfiles.
13589         * source.c (forget_cached_source_info): Use all_objfiles.
13590         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13591         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13592         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13593         * objfiles.c (update_section_map): Use all_objfiles.
13594         (shared_objfile_contains_address_p): Likewise.
13595         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13596         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13597
13598 2019-01-09  Tom Tromey  <tom@tromey.com>
13599
13600         * common/next-iterator.h: New file.
13601         * objfiles.h (class all_objfiles): New.
13602         (struct objfile_iterator): New.
13603
13604 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13605
13606         * NEWS: Move the description of the changed "frame", "select-frame",
13607          and "info frame" commands to the Changed commands section.
13608
13609 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13610
13611         * gdbtypes.c (check_stub_method_group): Remove handling of old
13612         mangling schemes.
13613         * linespec.c (find_methods): Likewise.
13614         * stabsread.c (read_member_functions): Likewise.
13615         * valops.c (search_struct_method): Likewise.
13616         (value_struct_elt_for_reference): Likewise.
13617         * NEWS: Mention this change.
13618
13619 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13620
13621         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13622         print_source_lines.
13623         * source.c (print_source_lines_base): Update line number check.
13624         (print_source_lines): New function.
13625         (source_lines_range::source_lines_range): New function.
13626         * source.h (class source_lines_range): New class.
13627         (print_source_lines): New declaration.
13628
13629 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13630
13631         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13632
13633 2019-01-08  Tom Tromey  <tom@tromey.com>
13634             Simon Marchi  <simon.marchi@ericsson.com>
13635
13636         PR gdb/24060
13637         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13638         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13639         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13640         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13641         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13642         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13643
13644 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13645
13646         * source.c (select_source_symtab): Move header comment to
13647         declaration in source.h.
13648         (forget_cached_source_info_for_objfile): Likewise.
13649         (forget_cached_source_info): Likewise.
13650         (identify_source_line): Likewise.
13651         * source.h (identify_source_line): Move declaration from symtab.h
13652         and add comment from source.c
13653         (print_source_lines): Likewise.
13654         (forget_cached_source_info_for_objfile): Likewise.
13655         (forget_cached_source_info): Likewise.
13656         (select_source_symtab): Likewise.
13657         (enum print_source_lines_flag): Move definition from symtab.h.
13658         * symtab.h (identify_source_line): Move declaration to source.h.
13659         (print_source_lines): Likewise.
13660         (forget_cached_source_info_for_objfile): Likewise.
13661         (forget_cached_source_info): Likewise.
13662         (select_source_symtab): Likewise.
13663         (enum print_source_lines_flag): Move definition to source.h.
13664         * tui/tui-hooks.c: Add 'source.h' include.
13665
13666 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13667
13668         * source.c (print_source_lines_base): Handle requests to print
13669         reverse line number sequences, and guard against empty lines
13670         string.
13671
13672 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13673
13674         * source.c (print_source_lines_base): Fix skip of '\r' if next
13675         character is '\n'.
13676
13677 2019-01-06  Tom Tromey  <tom@tromey.com>
13678
13679         * c-exp.y (struct c_parse_state) <macro_original_text,
13680         expansion_obstack>: New member.
13681         (macro_original_text, expansion_obstack): Remove globals.
13682         (scan_macro_expansion, scanning_macro_expansion)
13683         (finished_macro_expansion): Update.
13684         (scan_macro_cleanup): Remove.
13685         (yylex, c_parse): Update.
13686
13687 2019-01-06  Tom Tromey  <tom@tromey.com>
13688
13689         * c-exp.y (struct c_parse_state) <strings>: New member.
13690         (operator_stoken): Update.
13691
13692 2019-01-06  Tom Tromey  <tom@tromey.com>
13693
13694         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13695         (union type_stack_elt) <typelist_val>: Now a pointer to
13696         std::vector.
13697         (type_stack_cleanup): Don't declare.
13698         (push_typelist): Update.
13699         * parse.c (pop_typelist): Return a std::vector.
13700         (push_typelist): Take a std::vector.
13701         (follow_types): Update.  Do not free args.
13702         (type_stack_cleanup): Remove.
13703         * c-exp.y (struct c_parse_state): New.
13704         (cpstate): New global.
13705         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13706         (nonempty_typelist): Update.
13707         (func_mod): Create a new vector.
13708         (c_parse): Create a c_parse_state.
13709         (check_parameter_typelist): Do not delete params.
13710         (function_method): Update.  Do not delete type_list.
13711
13712 2019-01-06  Tom Tromey  <tom@tromey.com>
13713
13714         PR gdb/28155:
13715         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13716         check_typedef.
13717         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13718         (print_return_value): Likewise.
13719
13720 2019-01-05  Tom Tromey  <tom@tromey.com>
13721
13722         * contrib/cleanup_check.py: Remove.
13723         * contrib/gcc-with-excheck: Remove.
13724         * contrib/exsummary.py: Remove.
13725         * contrib/excheck.py: Remove.
13726
13727 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13728
13729         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13730         NULL. Initialize tpprev to NULL instead of assigning it
13731         to NULL on the next statement.
13732         * windows-nat.c (windows_delete_thread): Remove check for
13733         main_thread_id before printing thread exit notifications.
13734         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13735         Remove thread ID check against main_thread_id.
13736         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13737         windows_delete_thread.
13738         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13739
13740 2019-01-04  Tom Tromey  <tom@tromey.com>
13741
13742         * compile/compile.c (_initialize_compile): Use upper case for
13743         metasyntactic variables.
13744         * symmisc.c (_initialize_symmisc): Use upper case for
13745         metasyntactic variables.
13746         * psymtab.c (_initialize_psymtab): Use upper case for
13747         metasyntactic variables.
13748         * demangle.c (demangle_command): Use upper case for metasyntactic
13749         variables.
13750         (_initialize_demangler): Likewise.
13751         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13752         variables.
13753
13754 2019-01-03  Tom Tromey  <tom@tromey.com>
13755
13756         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13757
13758 2019-01-03  Tom Tromey  <tom@tromey.com>
13759
13760         * python/py-symtab.c (salpy_str): Update.
13761         (struct salpy_sal_object) <symtab>: Now a PyObject.
13762         (salpy_dealloc): Update.
13763         (del_objfile_sal): Use gdbpy_ref.
13764
13765 2019-01-03  Tom Tromey  <tom@tromey.com>
13766
13767         * python/py-type.c (convert_field): Use new_reference.  Return
13768         gdbpy_ref.
13769         (make_fielditem): Return gdbpy_ref.
13770         (typy_fields): Update.
13771         (typy_getitem): Update.
13772         (field_name): Return gdbpy_ref.  Use new_reference.
13773         (typy_iterator_iternext): Update.
13774
13775 2019-01-03  Tom Tromey  <tom@tromey.com>
13776
13777         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13778
13779 2019-01-03  Tom Tromey  <tom@tromey.com>
13780
13781         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13782         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13783         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13784         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13785         (pspy_set_type_printers): Likewise.
13786         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13787         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13788         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13789         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13790         (objfpy_set_type_printers): Likewise.
13791
13792 2019-01-03  Tom Tromey  <tom@tromey.com>
13793
13794         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13795         (gdbpy_print_stack): Use gdbpy_err_fetch.
13796         * python/python-internal.h (class gdbpy_err_fetch): New class.
13797         (class gdbpy_enter) <m_error_type, m_error_value,
13798         m_error_traceback>: Remove.
13799         <m_error>: New member.
13800         (gdbpy_exception_to_string): Don't declare.
13801         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13802         * python/py-value.c (convert_value_from_python): Use
13803         gdbpy_err_fetch.
13804         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13805         gdbpy_exception_to_string.
13806         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13807         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13808         gdbpy_err_fetch.
13809
13810 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13811
13812         * linux-nat.c (delete_lwp_cleanup): Delete.
13813         (struct lwp_deleter): New struct.
13814         (lwp_info_up): New typedef.
13815         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13816         lwp_info_up.
13817
13818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13819
13820         * linux-fork.c (class scoped_switch_fork_info): New class.
13821         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13822
13823 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13824
13825         * valops.c (find_overload_match): Remove use of null_cleanup, and
13826         calls to do_cleanups.
13827
13828 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13829
13830         * compile/compile-cplus-types.c
13831         (compile_cplus_instance::decl_name): Handle changes to
13832         cp_func_name.
13833         * cp-support.c (cp_func_name): Update header comment, update
13834         return type.
13835         * cp-support.h (cp_func_name): Update return type in declaration.
13836         * valops.c (find_overload_match): Move temp_func local to top
13837         level of function and change its type.  Use temp_func to hold and
13838         delete temporary string obtained from cp_func_name.
13839
13840 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13841
13842         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13843         gdb::char_vector, remove cleanup, and update uses of `msg`.
13844
13845 2019-01-03  Jim Wilson  <jimw@sifive.com>
13846
13847         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13848
13849 2019-01-02  Tom Tromey  <tom@tromey.com>
13850
13851         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13852         (tdesc_parse_xml): Remove cleanups.
13853         * target-descriptions.h (make_cleanup_free_target_description):
13854         Don't declare.
13855         (target_desc_deleter): New struct.
13856         (target_desc_up): New typedef.
13857         * target-descriptions.c (target_desc_deleter::operator()): Rename
13858         from free_target_description.
13859         (make_cleanup_free_target_description): Remove.
13860
13861 2019-01-02  Tom Tromey  <tom@tromey.com>
13862
13863         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13864         constructor, destructor.
13865         (linespec_parser): Remove typedef.
13866         (~linespec_parser): Rename from linespec_parser_delete.
13867         (linespec_lex_to_end, linespec_complete_label)
13868         (linespec_complete): Update.
13869         (decode_line_full): Remove cleanups.
13870         (decode_line_1): Update.
13871
13872 2019-01-02  Tom Tromey  <tom@tromey.com>
13873
13874         * python/python-internal.h (inferior_to_inferior_object): Change
13875         return type.
13876         * python/py-exitedevent.c (create_exited_event_object): Update.
13877         * python/py-inferior.c (inferior_to_inferior_object): Return
13878         gdbpy_ref.
13879         (python_new_inferior, python_inferior_deleted)
13880         (thread_to_thread_object, delete_thread_object)
13881         (build_inferior_list, gdbpy_selected_inferior): Update.
13882         * python/py-infthread.c (create_thread_object): Update.  Also fail
13883         if inferior_to_inferior_object fails.
13884
13885 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13886
13887         * inferior.h (class inferior) <displaced_step_state>: New field.
13888         * infrun.h (struct displaced_step_state): Move here from
13889         infrun.c.  Initialize fields, add constructor.
13890         <inf>: Remove field.
13891         <reset>: New method.
13892         * infrun.c (struct displaced_step_inferior_state): Move to
13893         infrun.h.
13894         (displaced_step_inferior_states): Remove.
13895         (get_displaced_stepping_state): Adust.
13896         (displaced_step_in_progress_any_inferior): Adjust.
13897         (displaced_step_in_progress_thread): Adjust.
13898         (displaced_step_in_progress): Adjust.
13899         (add_displaced_stepping_state): Remove.
13900         (get_displaced_step_closure_by_addr): Adjust.
13901         (remove_displaced_stepping_state): Remove.
13902         (infrun_inferior_exit): Call displaced_step_state.reset.
13903         (use_displaced_stepping): Don't check for NULL.
13904         (displaced_step_prepare_throw): Call
13905         get_displaced_stepping_state.
13906         (displaced_step_fixup): Don't check for NULL.
13907         (prepare_for_detach): Don't check for NULL.
13908
13909 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13910
13911         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13912          in case of call that did not complete.
13913
13914 2019-01-02  Andrey Utkin  <autkin@undo.io>
13915
13916         * symfile.c (find_separate_debug_file): Fix search of debug files for
13917         remote debuggee.
13918
13919 2019-01-02  Tom Tromey  <tom@tromey.com>
13920
13921         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13922         indentation.
13923         * python/py-frame.c (frapy_older): Remove cast.
13924         (frapy_newer): Likewise.
13925         * python/py-breakpoint.c (local_setattro): Remove cast.
13926         * python/py-arch.c (archpy_name): Remove local variable.
13927         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13928
13929 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13930
13931         * unittests/basic_string_view/element_access/char/empty.cc:
13932         Fix year range in copyright header.
13933
13934 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13935
13936         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13937         Delete.
13938         <operator==>: Update with for removed field.
13939         <hash>: Likewise.
13940         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13941         <isa_features>: ...this.
13942         <abi_features>: New field.
13943         (riscv_isa_flen): Update comment.
13944         (riscv_abi_xlen): New declaration.
13945         (riscv_abi_flen): New declaration.
13946         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13947         isa_features.
13948         (riscv_abi_xlen): New function.
13949         (riscv_isa_flen): Update to get answer from isa_features.
13950         (riscv_abi_flen): New function.
13951         (riscv_has_fp_abi): Update to get answer from abi_features.
13952         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13953         xlen and flen.
13954         (riscv_call_info) <xlen, flen>: Update comment.
13955         (riscv_call_arg_struct): Remove invalid assertions
13956         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13957         is removed.
13958         (riscv_gdbarch_init): Gather isa features and abi features
13959         separately, ensure both match on the gdbarch when reusing an old
13960         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13961         a target with 64-bit float hardware.
13962
13963 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13964
13965         * source.c (search_command_helper): Stop reverse search
13966         when line 1 has been searched.
13967
13968 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13969
13970         * record-full.c (record_full_base_target::close): Rewrite
13971         record_full_core_buf_list free logic.
13972
13973 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13974
13975         * break-catch-syscall.c (print_one_catch_syscall): xfree
13976         the last text.
13977
13978 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13979
13980         * top.c (print_gdb_version): Update Copyright year in version
13981         message.
13982
13983 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13984
13985         Update copyright year range in all GDB files.
13986
13987 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13988
13989         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13990
13991 For older changes see ChangeLog-2018.
13992 \f
13993 Local Variables:
13994 mode: change-log
13995 left-margin: 8
13996 fill-column: 74
13997 version-control: never
13998 coding: utf-8
13999 End:
14000