1 Fri Jun 13 10:28:09 1997 Fred Fish <fnf@cygnus.com>
3 * config/i386/nm-linux.h: Enable prototypes that were #ifdef out.
4 * config/tm-sysv4.h (in_plt_section): Add prototype.
6 * maint.c (maintenance_translate_address): Avoid assignment
7 inside if, per GNU coding standards.
8 * symfile.c (simple_read_overlay_table): Avoid assignments inside if, per
11 * monitor.c (parse_register_dump): Is really a void function.
13 (monitor_read_memory): Remove unused variable "name".
14 (monitor_read_memory): Remove unused variable "regbuf".
15 (monitor_open): Remove unused variable "i".
16 (get_hex_word): Apparently unused, #if away for now.
19 * i386v4-nat.c (supply_fpregset): Remove unused variable "regi".
20 (fill_fpregset): Remove unused variables "regi", "to", "from" and
23 * remote-e7000.c (ctype.h): Include.
24 (e7000_insert_breakpoint): #if away unused arg used by unused expr.
25 * frame.h (generic_get_saved_register): Add prototype.
26 (enum lval_type): Add partial forward decl.
27 * dsrec.c (make_srec): Remove unused variable "type_code".
28 * remote-sim.c (gdbsim_wait): Handle sim_running and sim_polling
29 cases by just ignoring them.
32 * java-exp.y (parse_number): Remove unused variable "unsigned_p".
33 * java-lang.c (gdbcore.h): Include for prototypes.
34 (type_from_class): Remove unused variable "ftype".
35 (type_from_class): Remove unused variable "name_length".
36 (evaluate_subexp_java): Add default case to handle remaining
38 * java-valprint.c (c-lang.h): Include for prototypes.
40 * symfile.c (simple_read_overlay_region_table): #if away
42 (simple_free_overlay_region_table): Ditto.
43 (overlay_is_mapped): Add default case to switch.
44 (simple_read_overlay_region_table): Ditto.
45 (simple_read_overlay_region_table): Add prototype.
47 * symtab.c (fixup_symbol_section): Remove unused msym variable.
48 (fixup_psymbol_section): Ditto.
49 (find_pc_sect_symtab): Make distance a CORE_ADDR.
51 * utils.c: Add comment about t_addr being either unsigned long or
53 (paddr): Change formats to match actual types args are cast to.
58 * defs.h (perror_with_name): Is a NORETURN function.
59 * utils.c (perror_with_name): Is a NORETURN function.
60 (error): Is NORETURN independently of ANSI_PROTOTYPES.
62 * symtab.c (fixup_symbol_section): Remove prototype.
63 * symtab.h: (fixup_symbol_section): Add prototype.
64 * m32r-rom.c (report_transfer_performance): Add prototype.
65 * sparclet-rom.c: Ditto.
68 * c-exp.y (parse_number): Cast args to float* or double* as
69 appropriate for conversion format.
70 * java-exp.y (parse_number): Ditto.
72 * Makefile.in (c-exp.tab.c): Remove #line lines that refer
73 to nonexistant y.tab.c file.
74 (java-exp.tab.c): Ditto.
76 (m2-exp.tab.c): Ditto.
79 * gdbtk.c (gdbtk_init): Make truth value test explicit.
80 Remove unused static variable "Gdbtk_Library".
83 * sh-tdep.c (symfile.h): Include.
84 (gdb_string.h): Include.
85 (sh_fix_call_dummy): Ifdef away, currently unused.
86 * config/sh/tm-sh.h (pop_frame): Add prototype.
87 * config/sh/tm-sh.h (sh_set_processor_type): Add prototype.
89 Sat Jun 7 02:34:19 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
92 * gdbtk.c (gdb_get_breakpoint_info): Add string for new
93 enumeration del_at_next_stop to bpdisp array.
96 * eval.c (evaluate_subexp_for_sizeof): Handle dereferencing
97 of non-pointer values.
99 * symtab.c (gdb_mangle_name): Improve mangling of nested types,
100 their physical names already include the class name.
102 * valops.c (value_cast): Handle upcast of a class pointer.
104 From Andreas Schwab (schwab@issan.informatik.uni-dortmund.de):
105 * corelow.c (get_core_registers): Make secname big enough.
107 Fri Jun 6 14:43:23 1997 Keith Seitz <keiths@pizza.cygnus.com>
109 * config/sh/tm-sh.h: add define for FPSCR_REGNUM
110 * sh-tdep.c (sh_show_regs): print out all registers for
111 the current processor
113 Fri Jun 6 13:01:55 1997 Andrew Cagney <cagney@b1.cygnus.com>
115 * remote-sim.c (gdbsim_kill): Remove call to depreciated function
118 Thu Jun 5 11:39:03 1997 Ian Lance Taylor <ian@cygnus.com>
120 Fixes for recent correction to PE format:
121 * coffread.c (pe_file): New static variable.
122 (struct find_targ_sec_arg): Change resultp from pointer to int to
123 pointer to pointer to asection.
124 (find_targ_sec): Just store the section in args->resultp, not the
125 section offset value.
126 (cs_to_section): Compute the section offset value from the
128 (cs_section_address): New static function.
129 (coff_symfile_read): Set pe_file.
130 (read_one_sym): When reading a PE file, adjust the symbol value to
131 include the section address if the symbol has an appropriate
135 Tue Jun 3 16:24:46 1997 Michael Snyder (msnyder@cleaver.cygnus.com)
137 * configure.tgt: add mipsr3900-elf target
138 * config/mips/r3900.mt r3900l.mt tm-r3900.h tm-r3900l.h: ditto
142 Tue Jun 3 15:46:51 1997 Tom Tromey <tromey@cygnus.com>
144 * Makefile.in (LIB_RUNTIME_DIR): New variable.
147 Tue May 27 10:34:11 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
149 * dbxread.c: Check malloc's return for null, prevent segv.
151 Fri May 23 14:45:02 1997 Bob Manson <manson@charmed.cygnus.com>
153 * infcmd.c (jump_command): Don't try to dereference sfn if it's
156 Fri May 23 13:51:57 1997 Andrew Cagney <cagney@b1.cygnus.com>
158 * top.c (init_cmd_lists): Always initialize endianlist.
159 (init_main): Always define endian commands.
160 (set_endian_big): Issue warning if endian not selectable.
161 (set_endian_little): Ditto.
162 (set_endian_auto): Ditto.
164 Thu May 22 11:53:21 1997 Andrew Cagney <cagney@b1.cygnus.com>
166 * remote-sim.c (simulator_command): Restrict access to the
167 simulator to periods when the simulator is open.
169 Wed May 21 16:03:25 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
171 * procfs.c (init_procinfo): new function, abstracts some code
172 shared by create_procinfo and do_attach;
173 (procfs_set_inferior_syscall_traps): new function, abstracts
174 some code needed by procfs_init_inferior, do_attach, and
175 procfs_lwp_creation_handler; (procfs_first_available): new
176 function, find any LWP that's runnable; (procfs_thread_alive):
177 replace stub function with real implementation;
178 (procfs_lwp_creation_handler): fix bug starting new child
179 threads; (info_proc): bug fixes and enhancements for the
180 "INFO PROCESSES" command; (close_procinfo_file): call new
181 function "delete_thread" to cleanup GDB's thread database;
182 (proc_init_failed): add new argument "kill", to control whether
183 process is killed (so this function can be shared by
184 create_procinfo and do_attach); (procfs_exit_handler): handle
185 exit from an attached process, and cleanup procinfo handles
186 when the process exits; (procfs_resume, procfs_wait): cleanup
187 after a thread when it exits; (do_attach, do_detach): handle
188 attached processes with multiple threads; plus some general
189 improvements in the diagnostic output.
190 * sol-thread.c (sol_thread_alive): replace stub with real
191 implementation; (thread_to_lwp, lwp_to_thread): enhance to
192 handle threads that may have exited; (sol_thread_attach): add
193 startup setup stuff; (sol_thread_detach): add unpush_target
194 call; (sol_thread_mourn_inferior): add unpush_target call;
195 (sol_thread_wait, sol_thread_resume): enhance to deal with
196 thread exit cleanly; (sol_thread_new_objfile,
197 sol_thread_pid_to_str): detect unsuccessful startup and
198 don't crash; plus some general cleanup.
199 * thread.c (delete_thread): new function, allows targets to
200 notify gdb when a thread is no longer valid.
201 * infrun.c (wait_for_inferior): don't try to detect a new
202 thread on receiving a TARGET_EXITED event.
204 Tue May 20 09:32:02 1997 Andrew Cagney <cagney@b1.cygnus.com>
206 * remote-sim.c (gdbsim_open): Pass callback struct.
207 (init_callbacks): Remove call to sim_set_callbacks.
209 Thu May 15 07:56:50 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
211 * config/rs6000/tm-rs6000.h (SIG_FRAME_LR_OFFSET): Define.
212 * rs6000-tdep.c (frameless_function_invocation): Mark frames
213 with a zero PC as frameless to improve backtraces from core dumps
214 caused by dereferencing a NULL function pointer.
215 (frameless_function_invocation, frame_saved_pc, rs6000_frame_chain):
216 Handle frameless functions interrupted by a signal.
218 * sparc-tdep.c (sparc_init_extra_frame_info, sparc_frame_saved_pc):
219 Handle frameless functions interrupted by a signal.
221 Wed May 14 08:58:55 1997 Jeffrey A Law (law@cygnus.com)
223 * mn10200-tdep.c (mn10200_analyze_prologue): Update prologue comments
224 to reflect current reality. Gross attempt at handling out of
227 * mn10200-tdep.c (mn10200_skip_prologue): Don't look at the debug
228 symbols to find the end of the prologue.
229 * mn10300-tdep.c (mn10300_skip_prologue): Likewise.
232 Wed May 14 12:04:49 1997 Andrew Cagney <cagney@b1.cygnus.com>
234 * config/tic80/tm-tic80.h (NUM_REGS): 38 not 37.
238 Mon May 12 11:35:04 1997 Mark Alexander <marka@cygnus.com>
240 * tic80-tdep.c, config/tic80/tm-tic80.h: First cut at getting
241 basic C80 features working.
244 Thu May 8 08:42:47 1997 Andrew Cagney <cagney@b1.cygnus.com>
246 * configure.in (AC_TYPE_SIGNAL): Add
247 * configure: Re-generate.
248 * remote-sim.c: Signal returns RETSIGTYPE.
251 Wed May 7 19:10:19 1997 Andrew Cagney <cagney@b1.cygnus.com>
253 * gdbtk.c (wrapped_call): New function - make actual call to tk
255 (call_wrapper): Rewrite to use top.c:catch_errors.
257 * gdbtk.c (gdb_stop): If No target_stop set quit flag and hope for
261 Wed May 7 20:05:07 1997 Andrew Cagney <cagney@b1.cygnus.com>
263 * target.h (target_stop): Drop argument so it can be tested for
266 Sat May 3 20:51:48 1997 Mark Alexander <marka@cygnus.com>
268 * utils.c (floatformat_from_doublest): Handle infinity properly.
270 Thu May 1 11:44:46 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
272 * Finalize merge from Hurd folk.
273 Mon Oct 30 16:41:04 1995 Miles Bader <miles@gnu.ai.mit.edu>
274 * thread.c (thread_apply_command, thread_apply_all_command,
275 thread_command): Make sure TP is alive.
276 (thread_alive): New function.
277 Tue Nov 14 14:31:03 1995 Miles Bader <miles@gnu.ai.mit.edu>
278 * infrun.c (sig_print_info): Deal better with long signal names.
279 Wed Nov 22 15:23:35 1995 Miles Bader <miles@gnu.ai.mit.edu>
280 * thread.c (thread_id_to_pid): New function.
281 Fri Dec 1 13:25:25 1995 Miles Bader <miles@gnu.ai.mit.edu>
282 * gnu-nat.c: (set_thread_cmd_list, show_thread_cmd_list,
283 set_thread_default_cmd_list, show_thread_default_cmd_list):
284 New variables. (set_thread_cmd, show_thread_cmd,
285 set_thread_default_cmd, show_thread_default_cmd): New functions.
286 Fri Apr 18 15:20:16 1997 Miles Bader <miles@gnu.ai.mit.edu>
287 * gnu-nat.c (inf_startup): remove TASK parameter.
288 (inf_set_task): replace with new function (inf_set_pid).
289 * gdbthread.h: Add extern decl for thread_cmd_list.
291 Thu May 1 02:28:21 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
293 * printcmd.c (disassemble_command): Adjust low function bound
294 by FUNCTION_START_OFFSET.
297 Wed Apr 30 15:23:02 1997 Andrew Cagney <cagney@b1.cygnus.com>
299 * config/tic80/tm-tic80.h (BREAKPOINT): Set it to trap 73.
302 Mon Apr 28 21:25:32 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
304 * Makefile.in: Add rule for gnu-nat.o and i386gnu-nat.o (Gnu Hurd)
305 * config/i386/i386gnu.mh: remove rules for [i386]gnu-nat.o, now
306 in Makefile.in (as for other targets); add NATDEPFILE corelow.o to
307 satisfy symbol dependancy in solib.c (core_ops).
308 * target.[ch] conditionalize Mach-specific signals so that they
309 won't show up in non-Mach gdb's!
310 * thread.c: change name of static function "thread_switch" to
311 "switch_to_thread", to avoid conflict with Mach global symbol;
312 move thread_cmd_list to global scope so targets can add their
314 * infrun.c: sig_print_info: allow for long signal names.
315 * gnu-nat.[ch]: tidying up comments.
316 * gnu-nat.c: remove calls to prune_threads and renumber_threads;
317 gnu_wait must not return -1 when inferior exits;
318 attach_to_child will modify inferior_pid in a way that allows
319 fork_inferior to remain unchanged; remove extra arg from
320 startup_inferior; move Mach thread commands here from thread.c.
322 Mon Apr 28 18:21:20 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
324 * symtab.c: decode_line_1, replace the assignment to
325 values.sals[0].pc which I accidentally left out on 4/3/97.
327 Mon Apr 28 17:27:40 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
329 * c-exp.y, java-exp.y: make parse_number reject "123DEADBEEF".
331 * top.c: change "to enable to enable" to "to enable" in a couple
334 Mon Apr 28 09:01:59 1997 Mark Alexander <marka@cygnus.com>
336 * breakpoint.c (remove_breakpoint): Pass correct type to
337 target_remove_watchpoint.
338 * target.h: Improve comment for target_{remove,insert}_breakpoint.
340 Sat Apr 26 03:38:02 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
342 * alpha-tdep.c (heuristic_proc_desc): Increase search limit
343 for return address register, handle `ret' instruction.
345 * corelow.c (get_core_registers): Initialize cf.
347 * procfs.c: Minor changes to make pre-ANSI compilers happy.
348 (procfs_notice_signals): Copy traced signal set back to
350 (unconditionally_kill_inferior): If PR_DEAD is defined,
351 rerun inferior after killing it.
353 Fri Apr 25 00:10:18 1997 Jeffrey A Law (law@cygnus.com)
355 * config/mn10300/tm-mn10300.h (EXTRACT_STRUCT_VALUE_ADDRESS): The
356 structure value address is found in $a0 now.
357 * config/mn10200/tm-mn10200.h (EXTRACT_STRUCT_VALUE_ADDRESS): Likewise.
359 Thu Apr 24 13:31:10 1997 Jeffrey A Law (law@cygnus.com)
361 * config/mn10300/tm-mn10300.h (STORE_RETURN_VALUE): Pointers are
363 (EXTRACT_RETURN_VALUE): Likewise.
365 * mn10300-tdep.c (mn10300_analyze_prologue): Check for a return
366 insn at "pc", not "fi->pc".
369 Thu Apr 24 16:11:47 1997 Andrew Cagney <cagney@b1.cygnus.com>
371 * config/tic80/tm-tic80.h (NUM_REGS): Four 64bit accumulators.
372 (REGISTER_BYTE, REGISTER_RAW_SIZE, REGISTER_SIZE,
373 MAX_REGISTER_RAW_SIZE, REGISTER_VIRTUAL_TYPE): Adjust.
374 (NPC_REGNUM): Tic80 has a delay slot.
375 (R0_REGNUM, Rn_REGNUM, An_REGNUM): For sim, provide base/bound for
379 Wed Apr 23 11:18:45 1997 Jeffrey A Law (law@cygnus.com)
381 * config/mn10200/tm-mn10200.h (STORE_RETURN_VALUE): Pointers are
383 (EXTRACT_RETURN_VALUE): Likewise.
385 Tue Apr 22 11:58:15 1997 Fred Fish <fnf@cygnus.com>
387 * config/arm/tm-arm.h (TARGET_DOUBLE_FORMAT): Define to use
388 floatformat_ieee_double_littlebyte_bigword for little endian
390 * utils.c (floatformat_to_doublest): Create local preswapped
391 copy of input for floatformat_littlebyte_bigword formats.
392 (get_field, put_field): Treat floatformat_littlebyte_bigword
393 the same as floatformat_little.
394 (floatformat_from_doublest): Postswap output words for
395 the floatformat_littlebyte_bigwords format.
398 Mon Apr 21 22:44:47 1997 Andrew Cagney <cagney@b1.cygnus.com>
400 * config/tic80/tic80.mt (SIM): Link in simulator.
403 Tue Apr 22 09:02:10 1997 Stu Grossman (grossman@critters.cygnus.com)
405 * config/alpha/alpha-osf3.mh config/i386/{i386gnu linux}.mh
406 config/mips/{embed embed64 embedl embedl64 vr4300 vr4300el vr5000
407 vr5000el}.mt config/powerpc/{aix aix4}.mh config/rs6000/{aix
408 aix4}.mh config/sh/sh.mt config/sparc/sp64sim.mt:
412 Remove -lm. That's now handled by configure.
414 * Makefile.in (maintainer-clean): Add distclean to dependencies.
415 Remove duplicate rm's of files.
418 Mon Apr 21 14:00:08 1997 Doug Evans <dje@canuck.cygnus.com>
420 * gdbtk.c (gdb_disassemble): Store endian-ness in `di'.
423 Mon Apr 21 09:49:25 1997 Stu Grossman (grossman@critters.cygnus.com)
425 * remote-pa.c: Remove. It's broken and no longer necessary.
427 Sat Apr 19 11:56:10 1997 Per Bothner <bothner@deneb.cygnus.com>
429 * java-exp.y: Combine TRUE and FALSE into BOOLEAN_LITERAL.
430 (Avoids name clash with broken AIX header files.)
432 Sat Apr 19 01:49:37 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
434 * serial.c (serial_log_command): Fix fputs_unfiltered calls.
436 * config/powerpc/tm-ppc-aix4.h, config/rs6000/tm-rs6000-aix4.h
437 (DONT_RELOCATE_SYMFILE_OBJFILE): Removed.
438 * xcoffsolib.h (struct vmap): Add new members tvma, toffs and dvma,
440 * exec.c (bfdsec_to_vmap): Initialize new vmap members, initialize
441 tstart and dstart with section VMA.
442 * rs6000-nat.c (vmap_symtab): Relocate relative to the VMA in the
444 (vmap_ldinfo, xcoff_relocate_core): Adjust tstart by section offset
445 of the text section, remove DONT_RELOCATE_SYMFILE_OBJFILE hack.
446 (vmap_exec): Relocate relative to the VMA in the object file,
447 relocate .bss section as well.
448 (xcoff_relocate_core): No longer adjust section addresses by VMA.
449 * rs6000-tdep.c (find_toc_address): Change type of tocbase
451 * xcoffread.c (secnum_to_bfd_section): New routine to get
452 BFD section from CS section number.
453 (scan_xcoff_symtab): Make toc_offset section relative.
455 * symtab.c (total_number_of_methods): Avoid core dump if
456 baseclass type is still undefined.
458 Fri Apr 18 17:25:10 1997 Stu Grossman (grossman@critters.cygnus.com)
460 * Makefile.in (SUBDIRS): Add mswin so that make cleanup cleans up
462 * defs.h utils.c (error warning): Make message be const.
463 * main.c (fputs_unfiltered): Only send gdb_stdout and gdb_stderr
464 to hook. Otherwise send it to fputs.
465 * monitor.c monitor.h (monitor_get_dev_name): New function. Does
467 * remote-e7000.c: Remove debugify stuff. Change printf, fprintf
468 to _filtered forms to make output appear in GUIs. Replace all
469 uses of SERIAL_READCHAR with readchar, which has better error
471 * (e7000_parse_device): Add prototype.
472 (readchar): Improve doc. Handle random serial errors.
473 (expect): Disable notice_quit code. It's busted. Remove
474 serial error handling (it's now handled in readchar). Remove
475 remote_debug echoing. That's handled in readchar as well.
476 (e7000_parse_device): Remove serial_flag arg. It's not
478 (e7000_open): Split into two pieces. Second part is
479 e7000_start_remote, and is error protected. Now, when we connect
480 to the target, we setup the initial frame and registers so that
481 the user gets an immediate indication of where the target is.
482 (gch): Remove debug output. That's handled by readchar.
483 (e7000_read_inferior_memory): Handle errors better.
484 (_initialize_remote_e7000): Get rid of `<xxx>' things from
485 command names. They show up when doing completion and confuse
487 * ser-e7kpc.c: Get rid of the DLL's since we can access the device
488 directly from Win32s and Win95. Get rid of debugify crud.
489 * serial.c: Remove debugify cruft.
490 * (serial_logchar serial_log_command serial_write serial_readchar
491 serial_send_break serial_close): Merge common functionality into
492 serial_logchar. Clean up rest of routines.
493 * sparclet-rom.c: Disembowel. Leave only download routine.
494 Download routine now switches to remote target automatically.
495 * top.c (disconnect): Only define if SIGHUP is defined. Cleans
496 up MSVC/Win32 problem.
497 * utils.c (gdb_flush): Don't call hook unless it's for gdb_stdout
499 * config/sh/tm-sh.h: Define TARGET_SH for WinGDB.
500 * config/sparc/tm-sparclet.h: Remove override for prompt.
502 Fri Apr 18 13:38:19 1997 Doug Evans <dje@canuck.cygnus.com>
504 * remote-sim.c (gdbsim_open): Only pass -E to sim_open if
505 TARGET_BYTE ORDER_SELECTABLE.
507 Fri Apr 18 16:52:41 1997 Andrew Cagney <cagney@b1.cygnus.com>
509 * remote-sim.c (init_callbacks): Initialize poll_quit and magic
510 fields of gdb_callback.
511 (gdbsim_stop): Add gdbsim_stop to list of supported client
513 (gdbsim_wait, gdbsim_resume): Move call to sim_resume into
514 sim_wait where gdb is in a position to handle a long running
516 (gdbsim_cntrl_c): New function. Wrap the sim_resume call in a
518 (gdb_os_poll_quit): New function. Check for a quit pending on the
522 Wed Apr 16 12:33:06 1997 Andrew Cagney <cagney@b1.cygnus.com>
524 * Makefile.in (install-only): Make list of gdbtcl files to install
525 explicit - was picking up files such as ChangeLog etc.
526 (install-only): Don't blindly create the directory.
529 Thu Apr 17 14:30:04 1997 Per Bothner <bothner@deneb.cygnus.com>
531 * defs.h (enum language): Add language_java.
532 * java-exp.y, java-lang.c, java-lang.h, java-valprint.c: New files.
533 * Makefile.in: Update for new files.
534 * objfiles.c (allocate_objfile): Allow NULL bfd argument.
535 * symfile.c (deduce_language_from_filename): Recognize .java.
537 Thu Apr 17 02:20:23 1997 Doug Evans <dje@canuck.cygnus.com>
539 * m32r-stub.c (stash_registers): Rewrite.
540 (restore_registers): Renamed to restore_and_return.
541 (cleanup_stash): New function.
542 (process_exception): New function.
543 (_catchException*): Rewrite.
545 * remote-sim.c (gdbsim_load): Update call to sim_load.
546 (gdbsim_create_inferior): No longer pass start_address to
548 (gdbsim_open): Pass endian indicator as arg.
550 Tue Apr 15 15:31:09 1997 Stan Shebs <shebs@andros.cygnus.com>
552 * remote.c (get_offsets): Don't use scanf for interpreting
553 response to qOffsets.
555 Tue Apr 15 14:51:04 1997 Ian Lance Taylor <ian@cygnus.com>
557 * gdbserver/Makefile.in (INSTALL_XFORM): Remove.
558 (INSTALL_XFORM1): Remove.
559 (install-only): Use $(program_transform_name) directly, rather
560 than using $(INSTALL_XFORM) and $(INSTALL_XFORM1).
561 (uninstall): Transform name.
563 Mon Apr 14 17:06:27 1997 Mark Alexander <marka@cygnus.com>
565 * remote-mips.c (mips_load): Ensure that PC gets updated
566 after a load on LSI target.
568 Mon Apr 14 15:54:51 1997 Geoffrey Noer <noer@pizza.cygnus.com>
570 * procfs.c (notice_signals): fix typo
572 Mon Apr 14 16:25:10 1997 Ian Lance Taylor <ian@cygnus.com>
574 * gdbserver/Makefile.in (INSTALL): Change install.sh to
577 Mon Apr 14 11:55:27 1997 Geoffrey Noer <noer@pizza.cygnus.com>
579 * config/i386/cygwin32.mh: remove -lkernel32 from XM_CLIBS
580 since gcc automatically includes it
582 Thu Apr 10 13:20:53 1997 Geoffrey Noer <noer@cygnus.com>
584 * procfs.c: Substantial (but incomplete) changes to support
585 sysv4.2mp procfs as implemented in UnixWare 2.1. The procinfo
586 struct now has substructs like struct flt_ctl instead of
587 just a fltset_t and has a ctl_fd, status_fd, as_fd, and
588 map_fd instead of a single fd. Non-sysv4.2mp procfs models
589 still have the structs and multiple fds, but don't use the
590 entire struct and the four fds all point to the same thing.
591 We use PROCFS_USE_READ_WRITE to decide whether to talk to
592 procfs with reads/writes or use ioctl instead. We use
593 HAVE_MULTIPLE_PROC_FDS to determine whether procfs really has
594 multiple fds or not. PROC_NAME_FMT is split out into
595 CTL_PROC_NAME_FMT, AS_PROC_NAME_FMT, MAP_PROC_NAME_FMT,
596 STATUS_PROC_NAME_FMT.
598 (procfs_notice_signals): now a necessary wrapper around
599 (notice_signals): which are the new guts for noticing signals
600 (open_proc_file): gets a new flag arg used in sysv4.2mp to
601 determine whether or not to attempt to open the ctl_fd.
602 (procfs_read_status): new local function, reads procfs status
603 (procfs_write_pcwstop): new local function, writes a PCWSTOP
604 (procfs_write_pckill): new local function, writes a PCKILL
605 (unconditionally_kill_inferior): remove signo since we now
606 just call procfs_write_pckill().
607 (procfs_xfer_memory): call lseek with SEEK_SET rather than 0
608 (proc_iterate_over_mappings): the whole function is ifdefed
609 on UNIXWARE to keep things readable.
611 Expanded the syscall_table to include new potential sysv4.2mp
612 members. Note that all ifdefs of UNIXWARE should be eliminated
613 if possible or renamed to describe what's being selected for a
614 bit better. Sysv4.2mp and IRIX both have SYS_sproc so the
615 IRIX specific code now also checks it's not UNIXWARE.
617 * config/i386/tm-i386v42mp.h: also define HAVE_PSTATUS_T,
618 HAVE_NO_PRRUN_T, PROCFS_USE_READ_WRITE, and UNIXWARE
619 * config/mips/nm-irix4.h: set CTL_PROC_NAME_FMT et al to
620 "/debug/%d" as PROC_NAME_FMT used to be
622 Wed Apr 9 11:36:14 1997 Jeffrey A Law (law@cygnus.com)
624 * mn10300-tdep.c: Almost completely rewritten based on mn10200
626 * config/mn10300/tm-mn10300.h: Likewise.
628 Tue Apr 8 10:45:24 1997 Stu Grossman (grossman@critters.cygnus.com)
630 * config/pa/{hppabsd.mt hppahpux.mt hppaosf.mt}: Remove
631 remote-pa.o from TDEPFILES. Nobody uses it, and besides, it's a
632 lousy out-of-date clone of remote.c.
634 Fri Apr 4 08:21:21 1997 Stu Grossman (grossman@critters.cygnus.com)
636 * remote.c: Fix problems realized while showering.
637 * (hexnumlen): Add prototype. Use max, not min.
638 * (remote_write_bytes remote_read_bytes): Fix max packet size
639 calculations to properly account for packet overhead. Also handle
640 (probably rare) case where remote_register_buf_size isn't set.
642 * remote.c: Fix doc for `C' and `S' commands to indicate full
644 * (remote_ops extended_remote_ops remote_desc remote_write_size):
646 * (remote_fetch_registers remote_write_bytes remote_read_bytes):
647 Record size of response to fetch registers command, use this to
648 limit size of memory read and write commands.
649 * (push_remote_target): New function to make it possible to have
650 another target switch to the remote target.
651 * target.h: Add prototype for push_remote_target.
652 * sh-tdep.c (sh_frame_find_saved_regs): Fix sign extension bugs
653 for hosts which default to unsigned chars (such as SGI's).
654 * (_initialize_sh_tdep): Don't set remote_write_size. It's now
655 handled automatically in remote.c.
657 Thu Apr 3 15:10:30 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
659 * blockframe.c: blockvector_for_pc_sect(), block_for_pc_sect(),
660 find_pc_sect_function(), find_pc_sect_partial_function(): new
661 functions for debugging overlays; pc without section is ambiguous.
662 * breakpoint.[ch]: add section pointer to breakpoint struct;
663 add section argument to check_duplicates(); check section as well
664 as pc in [breakpoint_here_p(), breakpoint_inserted_here_p(),
665 breakpoint_thread_match(), bpstat_stop_status()];
666 add section argument to describe_other_breakpoints();
667 use INIT_SAL() macro to zero-out new sal structures;
668 make resolve_sal_pc() fix up the sal's section as well as its pc;
669 match on section + pc in clear_command() and delete_breakpoint();
670 account for overlay sections in insert_breakpoints(),
671 remove_breakpoint() and breakpoint_re_set_one();
672 all this to support overlays where a PC is not unique.
673 * exec.c: change xfer_memory() to handle overlay sections.
674 * findvar.c: change read_var_value() to handle overlay sections.
675 * frame.h: declaration for block_for_pc_sect() [blockframe.c].
676 * infcmd.c: jump_command() warns against jumping into an overlay
677 that's not in memory. Also use INIT_SAL() to initialize sals.
678 * infrun.c: wait_for_inferior() sets a flag to invalidate cached
679 overlay state information; Also use INIT_SAL() to init sals.
680 * m32r-rom.c: modify load routines to use LMA instead of VMA.
681 * m32r-stub.c: mask exit value down to 8 bits; screen out any
682 memory read/writes in the range 600000 to a00000, and ff680000
683 to ff800000 (hangs because nothing is mapped there); fix strcpy().
684 * maint.c: maintenance command "translate-address" supports overlays.
685 * minsyms.c: lookup_minimal_symbol_by_pc_sect() supports overlays.
686 * objfiles.[ch]: add ovly_mapped field to the obj_section struct;
687 this constitutes gdb's internal overlay mapping table. Add macro
688 ALL_OBJSECTIONS() to loop thru the obj_structs and look at overlays.
689 Add function find_pc_sect_section().
690 * printcmd.c: modify print_address_symbolic() with overlay smarts;
691 modify address_info() with overlay smarts; add function sym_info()
692 to support the INFO SYMBOL command (translate address to symbol(s));
693 modify disassemble_command() to work on unmapped overlays.
694 * source.c: use INIT_SAL() to initialize sals.
695 * symfile.[ch]: change generic_load() to use section's LMA address
696 instead of VMA address, for overlay sections.
697 Add numerous functions for finding a PC's section / overlay,
698 translating between VMA and LMA address ranges, determining if an
699 overlay section is mapped, etc. Add several user commands for
700 overlay debugging. Add support for a "generic" form of automatically
701 reading overlay mapping info from the inferior (based on the default
702 (simple) overlay manager which Cygnus provides as an example).
703 * symtab.[ch]: add functions find_pc_sect_symtab(),
704 find_pc_sect_psymtab(), find_pc_sect_psymbol(), find_pc_sect_line()
705 for lookup; modify lookup_symbol and decode_line_1() to use them;
706 modify find_function_start_sal() to account for overlay sections;
707 add macro INIT_SAL() for initializing struct symtab_and_line.
708 * target.c: fix a comment in the declaration of target_ops.
710 Thu Apr 3 10:31:12 1997 Mark Alexander <marka@cygnus.com>
712 * mips-tdep.c (mips_in_call_stub, mips_in_return_stub,
713 mips_skip_stub, mips_ignore_helper): New functions for dealing
714 with MIPS16 call/return thunks.
715 (mips_init_frame_pc_first): New function to implement
716 INIT_FRAME_PC_FIRST macro; includes code from old macro plus
717 new code to skip over MIPS16 thunks.
718 (mips_frame_chain): Skip over MIPS16 thunks.
719 * config/mips/tm-mips.h (mips_in_call_stub, mips_in_return_stub,
720 mips_skip_stub, mips_ignore_helper): Declare.
721 (IN_SOLIB_CALL_TRAMPOLINE, IN_SOLIB_RETURN_TRAMPOLINE,
722 SKIP_TRAMPOLINE_CODE, IGNORE_HELPER_CALL): New macros that invoke
724 (INIT_FRAME_PC_FIRST): Change to invoke mips_init_frame_pc.
725 (mips_init_frame_pc): Declare.
726 * infrun.c (wait_for_inferior): Use new IGNORE_HELPER_CALL macro
727 to decide if certain library function calls should be ignored.
729 Wed Apr 2 14:16:51 1997 Doug Evans <dje@canuck.cygnus.com>
731 * remote-sim.c (gdbsim_open): Check return code from sim_open.
732 Update call to sim_open (new arg SIM_OPEN_DEBUG).
735 Tue Apr 1 15:04:21 1997 Jason Molenda (crash@godzilla.cygnus.co.jp)
737 * configure.in (gdbtcl): Create soft-link for gdbtcl/ directory instead
741 Mon Mar 31 14:55:53 1997 Ian Lance Taylor <ian@cygnus.com>
743 * gdbinit.in: New file.
745 * configure.in: Generate .gdbinit from gdbinit.in.
746 * configure: Rebuild.
749 Sun Mar 30 12:28:24 1997 Fred Fish <fnf@cygnus.com>
751 * config/tic80/tic80.mt: Disable using the simulator
755 Sat Mar 29 13:57:20 1997 Fred Fish <fnf@cygnus.com>
757 * COPYING: Install new version of file from FSF.
758 * copying.c (show_copying_command): Update FSF address.
760 Fri Mar 28 18:33:41 1997 Ian Lance Taylor <ian@cygnus.com>
762 * Makefile.in (distclean): Remove .gdbinit.
765 Fri Mar 28 15:37:30 1997 Fred Fish <fnf@ninemoons.com>
767 * config/tic80/tm-tic80.h (NAMES_HAVE_UNDERSCORE): Define.
770 Fri Mar 28 15:38:04 1997 Mike Meissner <meissner@cygnus.com>
772 * remote-sim.c (gdb_os_{,e}vprintf_filtered): Change stdarg type
773 to va_list from void *, since va_list might not be a pointer
777 Fri Mar 28 17:04:02 1997 Jason Molenda (crash@godzilla.cygnus.co.jp)
779 * Makefile.in (gdbtk.o): look for GDBTK_LIBRARY in $(datadir) by
780 default, not $(srcdir).
783 Thu Mar 27 14:21:46 1997 Mark Alexander <marka@cygnus.com>
785 * remote-mips.c: Clean up comment and extraneous semicolon
786 for mips_monitor_prompt variable.
788 Thu Mar 27 12:46:58 1997 Mark Alexander <marka@cygnus.com>
790 * remote-mips.c: Add `set monitor-prompt' command.
792 Wed Mar 26 06:47:44 1997 Mark Alexander <marka@cygnus.com>
794 Fix from Peter Schauer:
795 * mdebugread.c (parse_procedure): Set address of procedure to
796 block start; this fixes problems with shared libraries introduced
799 Mon Mar 24 19:43:16 1997 Geoffrey Noer <noer@cygnus.com>
801 * symtab.c (find_pc_symtab): change to support the case
802 where the objfile is reordered and contains both coff and
803 stabs debugging info (continue on if a psymtab isn't found).
805 Sun Mar 23 16:19:20 1997 Mark Alexander <marka@cygnus.com>
807 Fixes from Peter Schauer:
808 * config/mips/tm-mips.h (REGISTER_CONVERT_TO_TYPE,
809 REGISTER_CONVERT_FROM_TYPE): Swap words if target, not host,
810 is big-endian and if registers are 32 bits.
811 * mips-tdep.c (mips_print_register, mips_extract_return_value,
812 mips_store_return_value): Fix floating-point word-order problems on
813 little-endian targets introduced by changes of Mar 21.
815 Sun Mar 23 15:43:27 1997 Stan Shebs <shebs@andros.cygnus.com>
817 * remote.c (target_resume_hook, target_wait_loop_hook): New
819 (remote_resume, remote_wait): Use them.
820 * d10v-tdep.c: Set the above hooks.
821 (tracesource): New GDB variable, controls source display in
823 (display_trace): Find and display source line if requested.
824 (trace_info): Mention empty trace buffer if appropriate.
825 (tdisassemble_command): Robustify argument handling.
827 * configure.host: Remove extra bogus Linux case.
829 Sat Mar 22 16:41:35 1997 Fred Fish <fnf@cygnus.com>
831 * remote-sim.c (simulator_command): Add comment about dealing with
834 * Makefile.in (tic80-tdep.o): Add target.
835 * configure.tgt: Add tic80 case.
836 * tic80-tdep.c: New file.
837 * config/tic80/{tic80.mt, tm-tic80.h}: New files.
840 Sat Mar 22 02:48:11 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
842 * c-exp.y (yylex): Handle nested template parameter lists.
843 * symtab.c (decode_line_2): Fix test for valid choice number.
845 Fri Mar 21 19:10:05 1997 Mark Alexander <marka@cygnus.com>
847 * mips-tdep.c (mips_push_arguments): On non-EABI architectures,
848 copy first two floating point arguments to general registers, so that
849 MIPS16 functions will receive the arguments correctly.
850 (mips_print_register): Print double registers correctly on
852 (mips_extract_return_value): Return double values correctly
853 on little-endian hosts.
855 * mdebugread.c (parse_procedure): Adjust address of procedure relative
856 to address in file descriptor record; this accounts for constant
857 strings that may precede functions in the text section. Remove
858 now-useless lowest_pdr_addr from argument list and all calls.
860 Fri Mar 21 15:36:25 1997 Michael Meissner <meissner@cygnus.com>
862 * configure.tgt (powerpc*-{eabi,linux,sysv,elf}*): Determine
863 whether the simulator will be built by whether the Makefile in the
864 simulator directory was built.
866 * configure.in (--enable-sim-powerpc): Delete switch.
867 * configure: Regenerate.
869 Thu Mar 20 20:52:04 1997 Jeffrey A Law (law@cygnus.com)
871 * mn10200-tdep.c (mn10200_analyze_prologue): Look for save of "a1"
874 * remote-sim.c (gdb_os_vprintf_filtered): Fix to work with non-ANSI
876 (gdb_os_evprintf_filtered): Similarly.
878 Wed Mar 19 16:13:22 1997 Geoffrey Noer <noer@pizza.cygnus.com>
880 New UnixWare 2.1 configuration
881 * config/i386/i386v42mp.mt: new
882 * config/i386/i386v42mp.mh: new
883 * config/i386/tm-i386v42mp.h: new
884 * config/i386/nm-i386v42mp.h: new
885 * configure.tgt: added new entries
886 * configure.host: added new entries
889 Wed Mar 19 15:16:17 1997 Martin M. Hunt <hunt@onions.cygnus.com>
891 * Makefile.in: Install gdbtcl dir instead of gdbtk.tcl.
893 * gdbtk.c: Added some ifdefs for Windows. Changed GDBTK_FILENAME
894 to GDBTK_LIBRARY, which is now a path to search.
895 (gdb_path_conv): New function. Convert Cygwin32 pathname to
898 * {aclocal.m4,configure.in}: Changes for Windows builds.
900 * configure: Rebuilt.
903 Mon Mar 17 17:52:00 1997 J.T. Conklin <jtc@cygnus.com>
905 * dsrec.c (load_srec): Print leading zeroes when printing section
908 Mon Mar 17 15:00:16 1997 Andrew Cagney <cagney@kremvax.cygnus.com>
910 * remote-sim.h: Delete - moved to ../include/remote-sim.h.
912 * Makefile.in (remote_utils_h): Update path to remote-sim.h.
914 Fri Mar 7 20:55:28 1997 Andrew Cagney <cagney@kremvax.cygnus.com>
916 * remote-sim.c (flush_stdout, write_stderr, flush_stderr,
917 vprintf_filtered, evprintf_filtered): Callbacks that accept
920 Sat Mar 15 00:50:46 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
922 * breakpoint.c (insert_breakpoints, watchpoint_check,
923 bpstat_stop_status): Do not disable watchpoints going out of scope.
924 (insert_breakpoints): Make sure that the current frame is valid
925 before calling find_frame_addr_in_frame_chain.
927 * top.c (setup_user_args): Handle quotes and backslashes.
928 (print_gdb_version): Update copyright year.
930 Fri Mar 14 15:44:03 1997 Ian Lance Taylor <ian@cygnus.com>
932 * Makefile.in (elfread.o): Depend upon elf-bfd.h and elf/mips.h.
935 Fri Mar 14 10:01:29 1997 Tom Tromey <tromey@cygnus.com>
937 * configure: Regenerated.
938 * configure.in (LIBS): Re-reverse order of TCL_LIBS and TK_LIBS.
941 Thu Mar 13 22:51:00 1997 Dawn Perchik <dawn@cygnus.com>
943 * utils.c (pollquit, notice_quit): If _WIN32, limit test for
945 (initialize_utils): If _WIN32, don't call ScreenRows and ScreenCols
946 except under wingdb. (Contributed by Martin Hunt).
948 Thu Mar 13 12:40:49 1997 Tom Tromey <tromey@cygnus.com>
950 * configure: Regenerated.
951 * configure.in: Run AC_CONFIG_AUX_DIR before AC_CANONICAL_SYSTEM.
953 Thu Mar 13 11:00:22 1997 Doug Evans <dje@canuck.cygnus.com>
955 * remote-sim.h (sim_state, SIM_DESC): New types.
956 (sim_open): Return a `descriptor' as result.
957 (*): New argument of descriptor result from sim_open.
958 * remote-sim.c (gdbsim_desc): Renamed from gdbsim_open_p.
959 (gdbsim_open): Record result of sim_open in gdbsim_desc.
960 Pass argv list to sim_open, argv[0] = pseudo program name.
961 (*): Pass gdbsim_desc to sim_foo fns.
963 Wed Mar 12 14:40:06 1997 Tom Tromey <tromey@cygnus.com>
965 * config.in: Regenerated.
967 * acconfig.h (START_INFERIOR_TRAPS_EXPECTED, sys_quotactl,
968 HAVE_HPUX_THREAD_SUPPORT): Define.
971 Wed Mar 12 14:29:52 1997 Tom Tromey <tromey@cygnus.com>
973 * gdbtk.c (x_event): Use Tcl_DoOneEvent, TCL_DONT_WAIT,
976 * configure: Regenerated.
977 * configure.in (ENABLE_GDBTK): Put TCL_LIBS after TK_LIBS in
981 Tue Mar 11 07:25:27 1997 Mark Alexander <marka@cygnus.com>
983 First cut at supporting simulators in gdbserver:
985 * configure, configure.in: Allow gdbserver to be configured
986 for cross-target environments.
987 * gdbserver/Makefile.in: Add simulator support.
988 * gdbserver/configure.in: Eliminate assumption that host == target.
989 Simplify using gdb/configure.tgt and gdb/configure.host.
990 Fix other minor configuration errors.
991 * gdbserver/low-sparc.c: Fix compile error.
992 * gdbserver/remote-utils.c: Eliminate assumption that registers
993 and addresses are four bytes. Fix minor compile errors and warnings.
994 * gdbserver/server.c: Rewrite numerous instances of identical code
995 for starting inferior processes to call new function start_inferior.
996 Eliminate assumption that registers and addresses are four bytes.
997 * gdbserver/server.h: Add missing prototypes to eliminate compiler
999 * gdbserver/low-sim.c: New file to mate gdbserver with simulators.
1000 * config/mips/vr5000.mt: Add Vr5000 simulator support to gdbserver.
1001 * config/i386/linux.mh: Eliminate gdbserver support as a first step
1002 in moving such support from host to target makefile fragments.
1003 * config/i386/linux.mt: Move gdbserver support here from linux.mh.
1005 Mon Mar 10 12:27:47 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
1007 * symtab.h (INIT_SAL): New macro to initialize symtab_and_line,
1008 to insure consistant initialization of unused fields to zero.
1009 * symtab.c: replace initializations of sals with new macro INIT_SAL.
1010 * breakpoint.c: ditto.
1013 * source.c: add call to INIT_SAL macro.
1015 Sat Mar 8 00:16:37 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
1017 * sparc-tdep.c (isbranch): Always handle v9 branch instructions,
1018 they might get used on 32 bit targets as well.
1020 Wed Mar 5 19:34:09 1997 Bob Manson <manson@charmed.cygnus.com>
1022 * remote-mips.c (mips_exit_debug): Some IDT boards don't
1023 send the full exit string.
1025 Wed Mar 5 12:59:27 1997 Jeffrey A Law (law@cygnus.com)
1027 * mn10200-tdep.c (mn10200_push_arguments): Handle new calling
1029 (mn10200_store_struct_return): Likewise.
1031 Tue Mar 4 10:31:02 1997 Mark Alexander <marka@cygnus.com>
1033 * mips-tdep.c (mips_fetch_instruction): New function; replace
1034 common code throughout with calls to it.
1035 (mips_find_saved_regs): Examine MIPS16 entry instruction to determine
1036 correct saved addresses of $s0 and $s1.
1037 (mips_find_saved_regs, mips16_heuristic_proc_desc): Use MIPS_REGSIZE
1038 instead of hardcoded 4.
1039 (mips16_skip_prologue): Handle extended instructions correctly.
1041 Mon Mar 3 12:29:20 1997 Doug Evans <dje@canuck.cygnus.com>
1043 * defs.h (LONGEST): Move #ifndef LONGEST to outside.
1044 Try BFD_HOST_64_BIT if ! CC_HAS_LONG_LONG.
1046 Thu Feb 27 18:54:11 1997 Mark Alexander <marka@cygnus.com>
1048 * mips-tdep.c (IS_MIPS16_ADDR, MAKE_MIPS16_ADDR, UNMAKE_MIPS16_ADDR):
1049 New macros for testing, setting, and clearing bit 0 of addresses.
1050 Change numerous bits of code where bit 0 was being manipulated
1051 to use these macros.
1053 Thu Feb 27 14:12:41 1997 Mark Alexander <marka@cygnus.com>
1055 * remote-mips.c: Put back the form feeds.
1057 Thu Feb 27 12:04:24 1997 Mark Alexander <marka@cygnus.com>
1059 * remote-mips.c: Remove form feeds (^L) from source.
1060 (mips_initialize): LSI PMON doesn't support 'set regsize' command.
1061 (pmon_wait): Don't need to exit and re-enter debug mode on LSI
1062 PMON after a continue; it causes target program misbehavior.
1063 (mips_fetch_register): Don't fetch unsupported registers; this
1064 cuts down on wasted serial traffic.
1066 Thu Feb 27 09:38:16 1997 Stu Grossman (grossman@critters.cygnus.com)
1068 * configure.in configure (HPUX/OSF thread support): Enable this
1069 only when running GCC, since HP's thread header files use ANSI C
1070 which is not supported by their default compiler.
1072 * configure.host (i[3456]86-*-windows): Disable long long
1073 support for WinGDB. Add mswin to configdirs.
1074 * configure.in configure: Move calls to configure.host and
1075 configure.tgt to the top of configure.in to allow them to set
1076 config variables before they are referenced.
1078 Tue Feb 25 20:21:52 1997 Stan Shebs <shebs@andros.cygnus.com>
1080 * configure.tgt (mips*-*-lnews*): New target.
1082 Mon Feb 24 16:35:00 1997 Jeffrey A Law (law@cygnus.com)
1084 * mn10200-tdep.c (mn10200_analyze_prologue): Don't fix fi->frame
1085 if we're not the innermost frame. Fix minor typos.
1087 Sat Feb 22 03:39:50 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
1089 * stabsread.c (read_type): Fix handling of template names
1090 with template parameters containing `::'.
1092 * valops.c (search_struct_field, search_struct_method):
1093 Pass correct valaddr parameter to baseclass_offset.
1094 Prevent gdb crashes by making sure that the virtual base pointer
1095 from an user object still points to accessible memory.
1097 Tue Feb 18 13:36:34 1997 Mark Alexander <marka@cygnus.com>
1099 * maint.c: Eliminate -Wall warnings by including some header files.
1101 Tue Feb 18 13:06:30 1997 Mark Alexander <marka@cygnus.com>
1103 * remote-sim.c (init_callbacks): Undo previous change.
1105 Tue Feb 18 11:13:00 1997 Dawn Perchik <dawn@cygnus.com>
1107 * maint.c: Fix dereference of pointer.
1108 * remote-sim.c: Fix reference of structure member "last_error".
1109 * debugify.c: Include config.h to get ANSI definitions.
1111 Sat Feb 15 17:43:46 1997 Stu Grossman (grossman@critters.cygnus.com)
1113 * remote-vx.c (vx_attach): Remove code added by kung. It made no
1116 Fri Feb 14 13:00:07 1997 Ian Lance Taylor <ian@cygnus.com>
1118 * main.c (print_gdb_help): Make static to match declaration.
1120 Thu Feb 13 18:18:18 1997 Dawn Perchik <dawn@cygnus.com>
1122 * remote-e7000.c, ser-e7kpc.c, serial.c: Remove // comments.
1124 Wed Feb 12 15:58:00 1997 Dawn Perchik <dawn@cygnus.com>
1126 * debugify.c, debugify.h: Make safe for non-ansi compilers.
1128 Wed Feb 12 15:30:00 1997 Dawn Perchik <dawn@cygnus.com>
1130 * defs.h: Fix prototypes for new cleanup functions.
1132 Wed Feb 12 15:08:47 1997 Dawn Perchik <dawn@cygnus.com>
1134 * debugify.c, debugify.h: Fix for general gnu use. Remove C++
1135 comment, add PARAMS, add license info and fix indentation.
1137 Wed Feb 12 14:42:47 1997 Dawn Perchik <dawn@cygnus.com>
1139 * debugify.c, debugify.h: New files. Provide common macros
1140 for writing debug info to a log file or stdio.
1142 Wed Feb 12 02:44:39 1997 Dawn Perchik <dawn@cygnus.com>
1144 * c-valprint.c (c_val_print): Fix printing for arrays defined
1147 Tue Feb 11 22:24:39 1997 Dawn Perchik <dawn@cygnus.com>
1149 * defs.h: Fix cntl-C to read from the Windows message queue.
1150 Add prototypes for make_final_cleanup (and the other cleanup
1152 * remote-e7000.c: Fix sync code to timeout if unable to sync.
1153 Change sync code to report status while trying to sync-up
1154 with hardware. Add debugging output and document.
1155 * ser-e7kpc.c: Swap order of len & offset to match implementation.
1156 Add debugging output and document.
1157 * serial.c: Add debugging output.
1158 * top.c: Add call to do_final_cleanups.
1159 Remove conditionals preventing Win32 from getting SIGQUIT.
1160 * utils.c: (*_cleanup): Modify cleanup routines to accept a cleanup
1161 chain as a parameter. Extract this generic code from the cleanup
1162 routines into separate funtions (*_my_cleanup). Keep old
1163 functionality by passing "cleanup_chain" to the new funtions.
1164 Define the cleanup chain "final_cleanup_chain" to be a cleanup
1165 chain which will be executed only when gdb exits. Add functions
1166 (*_final_cleanup) to match the original (*_cleanup) functions.
1167 (pollquit, quit, notice_quit): Fix to read cntl-C from the
1168 Windows message queue.
1170 Tue Feb 11 15:36:31 1997 Doug Evans <dje@canuck.cygnus.com>
1172 * m32r-rom.c: #include <sys/types.h>.
1173 #ifdef out new load support if wingdb.
1174 * m32r/tm-m32r.h (TARGET_M32R): Define, for wingdb.
1176 Tue Feb 11 12:28:09 1997 Jeffrey A Law (law@cygnus.com)
1179 * config/mn10200/tm-mn10200.h (STORE_STRUCT_RETURN): Fix.
1180 * mn10200-tdep.c (mn10200_store_struct_return): New function.
1182 * config/mn10200/tm-mn10200.h (EXTRACT_RETURN_VALUE): Fix case when
1183 extracting a return value from a register pair.
1185 * mn10200-tdep.c (mn10200_push_arguments): Stack only needs to
1186 be two byte aligned. Round argument sizes up to two byte boundary.
1187 Write out args in two byte hunks.
1188 (mn10200_push_return_address): Implement.
1189 * config/mn10200/tm-mn10200.h (EXTRACT_RETURN_VALUE): Abort for
1190 structures > 8 bytes (temporary).
1191 (STORE_RETURN_VALUE): Likewise.
1192 (CALL_DUMMY): No longer undefine.
1193 (USE_STRUCT_CONVENTION): Use for args > 8 bytes.
1194 (REG_STRUCT_HAS_ADDR): Define.
1196 start-sanitize-r5900
1197 Fri Feb 07 09:04:37 1997 Gavin Koch <gavin@cygnus.com>
1199 * configure.tgt: added r5900.
1202 Mon Feb 10 18:35:55 1997 Mark Alexander <marka@cygnus.com>
1204 * mips-tdep.c (non_heuristic_proc_desc): New function.
1205 (find_proc_desc): Move non-heuristic proc search code into separate
1207 (gdb_print_insn_mips): Use non-heuristic method to find procedure
1208 descriptor, to avoid prologue examination when disassembling.
1209 * remote-mips.c: Add support for new "lsi" target (LSI MiniRISC
1210 aka MicroMeteor board).
1211 (mips_exit_debug): Prevent protocol reinitialization if an error
1212 occurs while exiting debug mode.
1214 Mon Feb 10 16:11:57 1997 Jeffrey A Law (law@cygnus.com)
1216 * mn10200-tdep.c: Remove lots of debugging printfs, update/improve
1217 comments, formatting, etc. Plus other minor fixes for problems
1218 I found during my first pass over the mn10200 port.
1219 (mn10200_analyze_prologue): New function.
1220 (mn10200_frame_chain, mn10200_init_extra_frame_info): Use it.
1221 * config/mn10200/tm-mn10200.h: Lots of updates/improvements to
1222 comments, formatting, etc. Minor fixes for problems I found during
1223 my first pass over the mn10200 port.
1224 (TARGET_*_BIT): Define appropriately for ints, long longs, doubles and
1226 (REGISTER_VIRTUAL_TYPE): Define as a long.
1227 (EXTRACT_RETURN_VALUE): Rework to deal with long ints living
1229 (STORE_RETURN_VALUE): Similarly.
1231 * blockframe.c (generic_get_saved_regs): Remove unused variable
1233 * breakpoint.c (frame_in_dummy): Move struct breakpoint *b decl
1234 inside #ifdef CALL_DUMMY.
1235 (watch_command_1): Initialize target_resources_ok.
1236 * command.c (do_setshow_command): Provide dummy initialization
1238 * valops.c (find_function_addr): Move function & prototype inside
1240 (value_arg_coerce): Similarly.
1241 (value_of_variable): Provide dummy initialization of "frame".
1243 start-sanitize-gdbtk
1244 Mon Feb 10 13:50:53 1997 Stu Grossman (grossman@critters.cygnus.com)
1246 * gdbtk.c (call_wrapper): Clear running_now if an error occurs.
1249 Mon Feb 10 07:54:26 1997 Fred Fish <fnf@cygnus.com>
1251 * xcoffread.c (RECORD_MINIMAL_SYMBOL): Add NULL asection* parameter
1252 to prim_record_minimal_symbol_and_info call that was missed in Jan 3
1254 (scan_xcoff_symtab): Ditto.
1256 Sun Feb 09 09:23:26 1997 Mark Alexander <marka@cygnus.com>
1258 * remote-mips.c (common_breakpoint): Prevent 64-bit addresses
1259 from being sent to 32-bit targets by masking off upper bits.
1260 * mips-tdep.c (heuristic_proc_start): Mask off upper 32 bits
1261 of PC on 32-bit targets.
1262 (mips16_heuristic_proc_desc): Recognize 'addiu s1,sp,n' as a
1263 frame setup instruction.
1264 (mips32_heuristic_proc_desc): Fix warning found by gcc -Wall.
1265 (mips16_skip_prologue): Recognize 'addiu s1,sp,n' as a valid
1266 prologue instruction. Fix warnings and bugs found by gcc -Wall.
1267 * buildsym.c (finish_block): Improve handling of overlapping blocks;
1268 fixes problem on MIPS16 printing function arguments.
1270 Sat Feb 8 01:14:43 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
1272 * dwarf2read.c (dwarf2_linkage_name): New function to get
1273 the linkage name of a die from DW_AT_MIPS_linkage_name or
1275 (read_func_scope, dwarf2_add_field, dwarf2_add_member_fn,
1276 new_symbol): Use it instead of accessing DW_AT_name.
1277 (read_partial_die): Use DW_AT_MIPS_linkage name as name of the
1278 partial die if present.
1279 (dwarf2_add_member_fn): Make a copy of physname on the type obstack.
1281 Fri Feb 7 10:06:22 1997 Jeffrey A Law (law@cygnus.com)
1283 * blockframe.c (generic_frame_chain_valid): If the new frame
1284 is not INNER_THAN the old frame, then it's not valid.
1286 Tue Feb 04 09:04:37 1997 Mark Alexander <marka@cygnus.com>
1288 * mips-tdep.c (mips16_get_imm): Fix calculation of extended immediate.
1289 (mips16_heuristic_proc_desc): Recognize jal(x) instruction.
1291 Mon Feb 03 17:57:58 1997 Mark Alexander <marka@cygnus.com>
1293 * mips-tdep.c (mips16_decode_reg_save): Distinguish between
1294 sd and sw instructions correctly.
1295 (heuristic_proc_start): Add support for MIPS16.
1296 (mips16_get_imm, mips16_heuristic_proc_desc,
1297 mips32_heuristic_proc_desc): New helper functions for
1298 heuristic_proc_desc.
1299 (heuristic_proc_desc): Rewrite and reorganize to support MIPS16.
1300 (mips_push_arguments): Don't align small arguments in EABI.
1301 (mips32_skip_prologue): Attempt to shrink code size a little.
1303 Mon Feb 3 11:06:05 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
1305 * m32r-stub.c: New -- remote protocol support for M32R cpu.
1306 * m32r-rom.c: Several experiments with improved download time.
1308 Fri Jan 31 08:26:39 1997 Mark Alexander <marka@cygnus.com>
1310 * mips-tdep.c (MIPS16_INSTLEN): Define.
1311 (mips_find_saved_regs): Replace hardcoded 2's with MIPS16_INSTLEN.
1312 (heuristic_proc_start): Recognize 'entry' pseudo-op as a start
1313 of function on MIPS16.
1314 (mips32_skip_prologue, mips16_skip_prologue): New helper functions
1315 for mips_skip_prologue.
1316 (mips_skip_prologue): Recognize both 16- and 32-bit prologues.
1318 Wed Jan 29 12:45:54 1997 Michael Meissner <meissner@tiktok.cygnus.com>
1320 * config/powerpc/ppc{,le}-sim.mt (SIM): Remove the library
1321 ../sim/common/libcommon.a.
1323 Tue Jan 28 15:54:13 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
1325 * blockframe.c: fix a null pointer ref in generic_get_saved_register
1327 Tue Jan 28 15:39:50 1997 Geoffrey Noer <noer@cygnus.com>
1329 * mn10200-tdep.c (mn10200_frame_chain): Get basic backtracing
1332 Mon Jan 27 14:31:52 1997 Mark Alexander <marka@cygnus.com>
1334 First set of changes for mips16:
1335 * config/mips/tm-mips.h (MIPS16_BIG_BREAKPOINT,
1336 MIPS16_LITTLE_BREAKPOINT, BREAKPOINT_FROM_PC): Define.
1337 (ABOUT_TO_RETURN): Call new function mips_about_to_return.
1338 (mips_breakpoint_from_pc, mips_about_to_return): Declare.
1339 * mem-break.c (memory_breakpoint_from_pc): New function.
1340 (memory_insert_breakpoint, memory_remove_breakpoint): Use
1341 memory_breakpoint_from_pc to determine breakpoint contents and size.
1342 * target.h (memory_breakpoint_from_pc): Declare.
1343 * monitor.c (monitor_insert_breakpoint): Use memory_breakpoint_from_pc
1344 to determine size of breakpoint instruction.
1345 * mips-tdep.c (mips32_decode_reg_save, mips16_decode_reg_save):
1346 New helper functions for mips_find_saved_regs.
1347 (mips_find_saved_regs): Recognize mips16 prologues.
1348 (mips_addr_bits_remove): Strip off upper 32 bits of address
1349 when target CPU is 32 bits but CORE_ADDR is 64 bits.
1350 (mips_step_skips_delay): No branch delay slot on mips16.
1351 (gdb_print_insn_mips): Disassemble mips16 code.
1352 (mips_breakpoint_from_pc, mips_about_to_return): New functions.
1354 Mon Jan 27 10:34:03 1997 Jeffrey A Law (law@cygnus.com)
1356 * tm-mn10200.h (NUM_REGS): Decrease to 12.
1357 (REGISTER_NAMES): Elimination registers not found on the mn10200.
1358 (PC_REGNUM, MDR_REGNUM, PSW_REGNUM): Corresponding changes.
1359 (LIR_REGNUM, LAR_REGNUM): Delete. They don't exist on the mn10200.
1361 Sat Jan 25 00:07:59 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
1363 * dwarf2read.c: Replace integral tag, name and form fields in
1364 internal structure definitions with the corresponding enumeration
1365 types from dwarf2.h. Add default cases to switches on enumerations
1367 Make quoting of string arguments in complaint messages consistent.
1368 Check for NULL returns from DW_STRING.
1369 (struct partial_die_info): Add sibling and has_type fields, remove
1371 (DW_*): Move access macro definitions near the definition of the
1372 attribute structure.
1373 (struct field_info): New structure to pass information about fields
1374 and member functions between die processing routines.
1375 (dwarf2_build_psymtabs_hard): Set cu_header_offset.
1376 (scan_partial_symbols): Do not enter DW_TAG_subprogram dies into
1377 the partial symbol table if the DW_AT_*_pc attributes are missing.
1378 Add file scope base type definitions to the partial symbol table.
1379 Skip over child dies if the die has a sibling attribute.
1380 (add_partial_symbol): Enter global variables with type attributes
1381 and without location descriptors into the partial symbol table.
1382 Store value of DW_TAG_variable dies in the partial symbol table.
1383 Do not enter global variables into the minimal symbol table.
1384 Add base type definitions to the partial symbol table.
1385 (psymtab_to_symtab_1): Use dwarf2_get_pc_bounds to determine highpc.
1386 (process_die): Move check for DW_AT_low_pc to read_func_scope.
1387 Add a typedef symbol for base type definitions to the symbol table.
1388 Ignore DW_TAG_inlined_subroutine tags for now.
1389 (read_file_scope): Use dwarf2_get_pc_bounds to determine pc bounds.
1390 (read_func_scope, read_lexical_block_scope): Use dwarf2_get_pc_bounds
1391 to determine pc bounds, ignore dies with invalid bounds.
1392 (dwarf2_get_pc_bounds): New routine to extract and validate the
1393 DW_AT_*_pc attributes of a die.
1394 (dwarf2_add_field, dwarf2_attach_fields_to_type, skip_member_fn_name,
1395 dwarf2_add_member_fn, dwarf2_attach_fn_fields_to_type):
1396 New functions to handle fields and member functions.
1397 (read_structure_scope): Rewritten to use them.
1398 (read_array_type): Renamed from dwarf_read_array_type.
1399 Default upper array bound to describe an array with unspecified
1401 Create array types in backwards order, as dwarf2 puts out the array
1402 dimensions from left to right.
1403 (read_subroutine_type): Handle DW_TAG_unspecified_parameters,
1404 DW_AT_artificial and DW_AT_prototyped.
1405 (read_base_type): Make an unsigned type for DW_ATE_boolean.
1406 Pass objfile to dwarf_base_type.
1407 (read_partial_die): Use read_attribute to read in the attributes.
1408 Handle DW_AT_sibling and DW_AT_type.
1409 Follow references when determining DW_AT_name and DW_AT_external
1410 attributes of the die.
1411 Validate DW_AT_*_pc attributes.
1412 (read_full_die): Use read_attribute to read in the attributes.
1413 (read_attribute): New function to read an attribute described
1414 by an abbreviated attribute.
1415 (new_symbol): Relocate symbol value for DW_TAG_label with baseaddr.
1416 Do not set SYMBOL_VALUE_ADDRESS for DW_TAG_subprogram,
1417 SYMBOL_BLOCK_VALUE for the symbol will be set later by finish_block.
1418 Change symbol class for global variables with a zero valued location
1419 descriptor to LOC_UNRESOLVED.
1420 Handle DW_AT_const_value attributes for DW_TAG_variable,
1421 DW_TAG_formal_parameter and DW_TAG_enumerator.
1422 Build a typedef symbol for DW_TAG_base_type.
1423 (dwarf2_const_value): New routine to copy a constant value from an
1424 attribute to a symbol.
1425 (dwarf_base_type): Use passed in objfile, not current_objfile
1426 when calling dwarf2_fundamental_type.
1427 (dump_die): Use DW_* accessor macros to access values of attributes.
1428 (decode_locdesc): Handle DW_OP_plus_uconst.
1430 Wed Jan 22 01:31:16 1997 Geoffrey Noer <noer@cygnus.com>
1432 * mn10200-tdep.c: New file.
1433 * config/mn10200/tm-mn10200.h: New, REGISTER_SIZE is 24 bits not 32,
1434 SP_REGNUM and FP_REGNUM are different, also no lar or lir.
1435 * config/mn10200/mn10200.mt: New file.
1436 * configure.tgt: add mn10200 entry.
1438 Tue Jan 21 18:32:23 1997 Stu Grossman (grossman@lisa.cygnus.com)
1440 * configure.in configure: Check if host has libdl if doing
1443 Tue Jan 21 17:03:26 1997 Geoffrey Noer <noer@cygnus.com>
1445 * mn10300-tdep.c: Wrote/fixed implementations of
1446 mn10300_frame_chain, mn10300_init_extra_frame_info,
1447 mn10300_frame_saved_pc
1448 * config/mn10300/tm-mn10300.h: Redefine INIT_EXTRA_FRAME_INFO
1449 and INIT_FRAME_PC macros.
1451 Tue Jan 21 17:01:20 1997 Stu Grossman (grossman@lisa.cygnus.com)
1453 * configure.in configure: Check if host has libm. Make sure we
1454 are using gcc when using the -export-dynamic option. Fixes a
1455 problem with building under Solaris/SunPro cc.
1457 Mon Jan 20 13:52:13 1997 Mark Alexander <marka@cygnus.com>
1459 * config/mips/{embed,embed64,embedl,embedl64}.mt:
1460 Link in simulator on MIPS embedded targets.
1462 Sat Jan 18 02:31:29 1997 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
1464 * blockframe.c (frameless_look_for_prologue): Mark frames
1465 with a zero PC as frameless to improve backtraces from core dumps
1466 caused by dereferencing a NULL function pointer.
1468 Thu Jan 16 14:10:41 1997 Geoffrey Noer <noer@cygnus.com>
1470 * config/mn10300/tm-mn10300.h: fix BREAKPOINT definition.
1472 Tue Jan 14 16:01:06 1997 Geoffrey Noer <noer@cygnus.com>
1474 * mn10300-tdep.c: made a lot more generic, ripping out code
1475 from copied target (no more mn10300_scan_prologue,
1476 init_extra_frame_info, and mn10300_fix_call_dummy calls)
1477 * config/mn10300/tm-mn10300.h: undefine INIT_EXTRA_FRAME_INFO
1478 and INIT_FRAME_PC macros
1480 Thu Jan 9 11:44:40 1997 Michael Snyder <msnyder@cleaver.cygnus.com>
1482 * sparc-tdep.c (sparc_frame_find_saved_regs): Don't use
1483 FP_REGISTER_BYTES to compute offsets into the saved frame,
1484 since it fails for SPARC targets configured without any
1485 FP regs. Instead, use DUMMY_STACK_REG_BUF_SIZE.
1487 Mon Jan 6 11:15:14 1997 Stu Grossman (grossman@critters.cygnus.com)
1489 * symtab.c (fixup_symbol_section): Handle NULL symbols without
1492 Fri Jan 3 12:08:16 1997 Stu Grossman (grossman@critters.cygnus.com)
1494 * Makefile.in configure configure.in: Remove ENABLE_CLIBS,
1495 ENABLE_OBS, and THREAD_DB_OBS. These are consolidated into LIBS
1497 * configure configure.in: Clean up test cases around thread support.
1499 * configure.tgt (v850-*-*): Include v850ice.o and v850.lib if
1502 * c-valprint.c ch-valprint.c cp-valprint.c eval.c expprint.c
1503 printcmd.c valops.c value.h values.c: Add bfd_section arg to
1504 value_at and value_at_lazy.
1505 * coffread.c dbxread.c elfread.c mdebugread.c minsyms.c symtab.h:
1506 Add bfd_section arg to prim_record_minimal_symbol_and_info.
1507 * corefile.c gdbcore.h printcmd.c valops.c: Use read_memory_section
1508 instead of read_memory. It takes a bfd_section arg.
1509 * coffread.c dbxread.c elfread.c gdb-stabs.h objfiles.h: Remove
1510 unnecessary cast for assignment of struct dbx_symfile_info.
1511 Struct objfile now uses a real pointer instead of PTR for this
1513 * dbxread.c (dbx_symfile_init): Stash bfd section pointers for
1514 text, data and bss into dbx_symfile_info.
1515 * exec.c (xfer_memory): Handle transfers for user-specified
1517 * findvar.c (read_var_value locate_var_value): Copy bfd section
1518 from the symbol to the value.
1519 * gdb-stabs.h: Add section pointers for text, data and bss
1521 * maint.c (translate address command): Add test code for overlay
1522 address translation.
1523 * printcmd.c (do_examine do_one_display): Now takes a bfd section
1525 * (print_formatted x_command): Record current section along with
1526 current address for repeated commands.
1527 * sparc-nat.c (fetch_inferior_registers): Change
1528 target_xfer_memory to target_{read write}_memory to allow changes
1529 to target_xfer_memory interface for section info.
1530 * symmisc.c (dump_msymbols print_symbol): Print section
1531 assocaited with symbol.
1532 * symtab.c (fixup_symbol_section): New routine to
1533 add section info to symbols returned by lookup_symbol.
1534 * symtab.h (struct general_symbol_info): Add bfd section to
1536 * target.c target.h (target_xfer_memory): Add bfd section to
1538 * (target_read_memory_section): New routine to read data from a
1540 * (target_memory_bfd_section): New global variable to pass bfd
1541 section in to targets.
1542 * valarith.c (value_add value_addr value_array): Preserve bfd
1543 section when computing new value.
1544 * value.h (struct value): Add bfd section to values.
1545 * values.c (allocate_value value_copy): Initialize/preserve bfd
1547 * (unpack_double): Clean up _MSC_VER conditionals to remove
1550 * v850ice.c: New module to support communication with NEC's
1552 * config/v850/tm-v850.h (REGISTER_NAMES): Replace sp, gp, fp, and
1553 ep names with rxx names. sp and fp are renamed via a different
1557 Fri Jan 3 14:20:05 1997 Geoffrey Noer <noer@cygnus.com>
1559 * mn10300-tdep.c (mn10300_push_arguments): rewrote,
1560 also removed code elsewhere that made use of RP_REGNUM.
1561 * config/mn10300/tm-mn10300.h: ripped out RP_REGNUM, V0_REGNUM,
1562 ARG0_REGNUM, ARGLAST_REGNUM (all not appropriate for mn10300
1563 arch.), redefined SAVED_PC_AFTER_CALL, EXTRACT_RETURN_VALUE,
1564 EXTRACT_STRUCT_VALUE_ADDRESS, STORE_RETURN_VALUE.
1566 For older changes see ChangeLog-96
1572 version-control: never