gdb/ChangeLog

   1 2019-06-14  Tom Tromey  <tromey@adacore.com>
   2
   3         * NEWS: Move convenience variable news above Python news.
   4
   5 2019-06-14  Tom Tromey  <tom@tromey.com>
   6
   7         * gnulib: Move directory to top-level.
   8         * configure.ac: Don't configure gnulib.
   9         * configure: Rebuild.
  10         * common/common-defs.h: Use new path to gnulib.
  11         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
  12         (GNULIB_H): Remove.
  13         (INCGNU): Look in new gnulib location.
  14         (HFILES_NO_SRCDIR): Remove gnulib files.
  15         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
  16         (generated_files): Remove GNULIB_H.
  17         ($(LIBGNU), all-lib): Remove targets.
  18         (distclean): Don't mention GNULIB_BUILDDIR.
  19         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
  20
  21 2019-06-14  Tom Tromey  <tromey@adacore.com>
  22
  23         * symfile.c (add_symbol_file_command): Remove obsolete comment.
  24         Warn if symbol file does not provide any symbols.
  25
  26 2019-06-14  Tom Tromey  <tromey@adacore.com>
  27
  28         * source.c (find_and_open_source): Respect basenames_may_differ.
  29
  30 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
  31
  32         * annotate.c (annotate_breakpoints_invalid): Make use of
  33         scoped_restore_terminal_state.
  34         (annotate_frames_invalid): Likewise.
  35
  36 2019-06-14  Tom Tromey  <tromey@adacore.com>
  37
  38         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
  39         allow assignment to an internalvar.
  40
  41 2019-06-14  Tom Tromey  <tromey@adacore.com>
  42
  43         * ada-lex.l: Allow "_" in attribute names.
  44
  45 2019-06-14  Tom Tromey  <tromey@adacore.com>
  46
  47         PR gdb/24653:
  48         * regcache.c (registers_changed): Don't call alloca.
  49         * top.c (execute_command): Don't call alloca.
  50
  51 2019-06-13  Pedro Alves  <palves@redhat.com>
  52
  53         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
  54         'expression'.  When parsing an expression, error out if there's
  55         junk after "unlimited".
  56         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  57         (do_set_command): Adjust calls to is_unlimited_literal.
  58
  59 2019-06-13  Pedro Alves  <palves@redhat.com>
  60
  61         * compile/compile.c (make_compile_options_def_group): Add braces
  62         around array_view initializer.
  63         * thread.c (make_thread_apply_all_options_def_group)
  64         (make_thread_apply_all_options_def_group): Likewise.
  65
  66 2019-06-13  Pedro Alves  <palves@redhat.com>
  67
  68         * NEWS (New commands): Mention "maint test-options
  69         require-delimiter", "maint test-options unknown-is-error", "maint
  70         test-options unknown-is-operand" and "maint show
  71         test-options-completion-result".
  72         (New command options, command completion): New section.
  73         (Completion improvements): New section.
  74         Mention that you can abbreviate "unlimited".
  75
  76 2019-06-13  Pedro Alves  <palves@redhat.com>
  77
  78         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
  79         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
  80         * unittests/cli-utils-selftests.c (test_parse_flags)
  81         (test_parse_flags_qcs): Delete.
  82         (test_cli_utils): Don't call deleted functions.
  83
  84 2019-06-13  Pedro Alves  <palves@redhat.com>
  85
  86         * thread.c: Include "cli/cli-option.h".
  87         (tp_array_compar_ascending): Global.
  88         (tp_array_compar): Delete function.
  89         (tp_array_compar_ascending, tp_array_compar_descending): New
  90         functions.
  91         (ascending_option_def, qcs_flag_option_def)
  92         (thr_qcs_flags_option_defs)
  93         (make_thread_apply_all_options_def_group)
  94         (make_thread_apply_options_def_group): New.
  95         (thread_apply_all_command): Use gdb::option::process_options.
  96         (thread_apply_command_completer)
  97         (thread_apply_all_command_completer): New.
  98         (thread_apply_command): Use gdb::option::process_options.
  99         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 100         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 101         to generate help text of "thread apply".  Adjust "taas"'s help.
 102         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 103         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 104
 105 2019-06-13  Pedro Alves  <palves@redhat.com>
 106
 107         * thread.c (thread_apply_command): Check for invalid TID with
 108         isdigit instead of !isalpha.
 109
 110 2019-06-13  Pedro Alves  <palves@redhat.com>
 111
 112         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 113         (validate_flags_qcs): New.
 114         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 115         (validate_flags_qcs): Declare.
 116         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 117         (make_frame_apply_options_def_group): New.
 118         (frame_apply_command_count): Process options with
 119         gdb::option::process_options.
 120         (frame_apply_completer): New.
 121         (frame_apply_level_completer, frame_apply_all_completer)
 122         (frame_apply_completer): New.
 123         (_initialize_stack): Update help of "frame apply", "frame apply
 124         level", "frame apply all" and "faas" to mention supported options
 125         and install command completers.
 126         * stack.h (frame_apply_all_completer): Declare.
 127         * thread.c: Include "stack.h".
 128         (tfaas_command): Add "--".
 129         (_initialize_thread): Update help "tfaas" to mention supported
 130         options and install command completer.
 131
 132 2019-06-13  Pedro Alves  <palves@redhat.com>
 133
 134         * completer.c (complete_nested_command_line): New.
 135         (gdb_completion_word_break_characters_throw): Add assertion.
 136         * completer.h (complete_nested_command_line): Declare.
 137
 138 2019-06-13  Pedro Alves  <palves@redhat.com>
 139
 140         * stack.c (parse_backtrace_qualifiers): New.
 141         (backtrace_command): Use it.
 142         (backtrace_command_completer): Complete on qualifiers.
 143
 144 2019-06-13  Pedro Alves  <palves@redhat.com>
 145
 146         * frame.c: Include "cli/cli-option.h.
 147         (user_set_backtrace_options): New.
 148         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 149         Delete.
 150         (get_prev_frame): Adjust.
 151         (boolean_option_def, uinteger_option_def)
 152         (set_backtrace_option_defs): New.
 153         (_initialize_frame): Adjust and use
 154         gdb::option::add_setshow_cmds_for_options to install "set
 155         backtrace past-main" and "set backtrace past-entry".
 156         * frame.h: Include "cli/cli-option.h".
 157         (struct frame_print_options): Forward declare.
 158         (print_frame_arguments_all, print_frame_arguments_scalars)
 159         (print_frame_arguments_none): Declare.
 160         (print_entry_values): Delete declaration.
 161         (struct frame_print_options, user_frame_print_options): New.
 162         (struct set_backtrace_options): New.
 163         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 164         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 165         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 166         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 167         (list_args_or_locals): Add frame_print_options parameter.
 168         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 169         * python/py-framefilter.c (enumerate_args): Pass down
 170         USER_FRAME_PRINT_OPTIONS.
 171         * stack.c: Include "cli/cli-option.h".
 172         (print_frame_arguments_all, print_frame_arguments_scalars)
 173         (print_frame_arguments_none): Declare.
 174         (print_raw_frame_arguments, print_entry_values): Delete.
 175         (user_frame_print_options): New.
 176         (boolean_option_def, enum_option_def, frame_print_option_defs):
 177         New.
 178         (struct backtrace_cmd_options): New.
 179         (bt_flag_option_def): New.
 180         (backtrace_command_option_defs): New.
 181         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 182         (print_frame_arg, read_frame_arg, print_frame_args)
 183         (print_frame_info, print_frame): Add frame_print_options parameter
 184         and use it.
 185         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 186         (backtrace_command_1): Add frame_print_options and
 187         backtrace_cmd_options parameters and use them.
 188         (make_backtrace_options_def_group): New.
 189         (backtrace_command): Process command options with
 190         gdb::option::process_options.
 191         (backtrace_command_completer): New.
 192         (_initialize_stack): Extend "backtrace"'s help to mention
 193         supported options.  Install completer for "backtrace".
 194         Install some settings commands with add_setshow_cmds_for_options.
 195
 196 2019-06-13  Pedro Alves  <palves@redhat.com>
 197
 198         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 199         and that "set/show print raw frame-arguments" are now deprecated.
 200
 201         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 202         command.
 203         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 204         * stack.c (_initialize_stack): Install "set/show print
 205         raw-frame-arguments", and deprecate "set/show print raw
 206         frame-arguments".
 207         * valprint.c (_initialize_valprint): Deprecate "set/show print
 208         raw".
 209
 210 2019-06-13  Pedro Alves  <palves@redhat.com>
 211
 212         * compile/compile.c (struct compile_options): New.
 213         (compile_flag_option_def, compile_command_option_defs)
 214         (make_compile_options_def_group): New.
 215         (compile_file_command): Handle options with
 216         gdb::option::process_options.
 217         (compile_file_command_completer): New function.
 218         (compile_code_command): Handle options with
 219         gdb::option::process_options.
 220         (compile_code_command_completer): New function.
 221         (_initialize_compiler): Install completers for "compile code" and
 222         "compile file".  Mention available options in "compile code" and
 223         "compile code"'s help.
 224         * completer.c (advance_to_completion_word): New, factored out from
 225         ...
 226         (advance_to_expression_complete_word_point): ... this.
 227         (advance_to_filename_complete_word_point): New.
 228         * completer.h (advance_to_filename_complete_word_point): New
 229         declaration.
 230
 231 2019-06-13  Pedro Alves  <palves@redhat.com>
 232
 233         * compile/compile.c: Include "cli/cli-option.h".
 234         (compile_print_value): Scope data pointer is now a
 235         value_print_options pointer; adjust.
 236         (compile_print_command): Process options.  Scope data pointer is
 237         now a value_print_options pointer; adjust.
 238         (_initialize_compile): Update "compile print"'s help to include
 239         supported options.  Install a completer for "compile print".
 240         * cp-valprint.c (show_vtblprint, show_objectprint)
 241         (show_static_field_print): Delete.
 242         (_initialize_cp_valprint): Don't install "set print
 243         static-members", "set print vtbl", "set print object" here.
 244         * printcmd.c: Include "cli/cli-option.h" and
 245         "common/gdb_optional.h".
 246         (print_command_parse_format): Rework to fill in a
 247         value_print_options instead of a format_data.
 248         (print_value): Change parameter type from format_data pointer to
 249         value_print_options reference.  Adjust.
 250         (print_command_1): Process options.  Adjust to pass down a
 251         value_print_options.
 252         (print_command_completer): New.
 253         (_initialize_printcmd): Install print_command_completer as
 254         handle_brkchars completer for the "print" command.  Update
 255         "print"'s help to include supported options.
 256         * valprint.c: Include "cli/cli-option.h".
 257         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 258         here from cp-valprint.c.
 259         (boolean_option_def, uinteger_option_def)
 260         (value_print_option_defs, make_value_print_options_def_group):
 261         New.  Use gdb::option::add_setshow_cmds_for_options to install
 262         "set print elements", "set print null-stop", "set print repeats",
 263         "set print pretty", "set print union", "set print array", "set
 264         print address", "set print symbol", "set print array-indexes".
 265         * valprint.h: Include <string> and "cli/cli-option.h".
 266         (make_value_print_options_def_group): Declare.
 267         (print_value): Change parameter type from format_data pointer to
 268         value_print_options reference.
 269         (print_command_completer): Declare.
 270
 271 2019-06-13  Pedro Alves  <palves@redhat.com>
 272
 273         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 274         (COMMON_SFILES): Add maint-test-settings.c.
 275         * cli/cli-decode.c (boolean_enums): New global, factored out from
 276         ...
 277         (add_setshow_boolean_cmd): ... here.
 278         * cli/cli-decode.h (boolean_enums): Declare.
 279         * cli/cli-option.c: New file.
 280         * cli/cli-option.h: New file.
 281         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 282         factored out from ...
 283         (parse_cli_boolean_value(const char *)): ... this.
 284         (is_unlimited_literal): Change parameter type to pointer to
 285         pointer.  Adjust and advance ARG pointer.
 286         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 287         (parse_cli_var_enum): New, factored out from ...
 288         (do_set_command): ... this.  Adjust.
 289         * cli/cli-setshow.h (parse_cli_boolean_value)
 290         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 291         (parse_cli_var_enum): Declare.
 292         * cli/cli-utils.c: Include "cli/cli-option.h".
 293         (get_ulongest): New.
 294         * cli/cli-utils.h (get_ulongest): Declare.
 295         (check_for_argument): New overloads.
 296         * maint-test-options.c: New file.
 297
 298 2019-06-13  Pedro Alves  <palves@redhat.com>
 299
 300         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 301         parse a range if "-" is at the end of the string.
 302
 303 2019-06-13  Pedro Alves  <palves@redhat.com>
 304
 305         * cli/cli-setshow.c (parse_auto_binary_operation)
 306         (parse_cli_boolean_value): Don't allow "o".
 307
 308 2019-06-13  Pedro Alves  <palves@redhat.com>
 309
 310         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 311         * NEWS: Mention maint test-settings KIND.
 312         * maint-test-settings.c: New file.
 313
 314 2019-06-13  Pedro Alves  <palves@redhat.com>
 315
 316         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 317         completer.
 318         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 319         "set" completers.
 320
 321 2019-06-13  Pedro Alves  <palves@redhat.com>
 322
 323         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 324         after item.
 325
 326 2019-06-13  Pedro Alves  <palves@redhat.com>
 327
 328         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 329
 330 2019-06-13  Pedro Alves <palves@redhat.com>
 331
 332         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 333         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 334         call.
 335         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 336         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 337         calls.
 338         (check_for_argument): Skip spaces after argument.
 339
 340 2019-06-13  Pedro Alves  <palves@redhat.com>
 341
 342         * thread.c (thread_apply_command): Adjust TID parsing.
 343         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 344         detected before end of string.
 345         (tid_is_in_list): Error out if LIST is invalid.
 346
 347 2019-06-13  Pedro Alves  <palves@redhat.com>
 348
 349         * completer.c (complete_line_internal_1): Rewind completion word
 350         point.
 351         (completion_tracker::advance_custom_word_point_by): Change
 352         parameter type to int.
 353         * completer.h (completion_tracker::advance_custom_word_point_by):
 354         Likewise.
 355
 356 2019-06-13  Pedro Alves  <palves@redhat.com>
 357
 358         * completer.c (advance_to_completion_word): Handle delimiters.
 359
 360 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 361
 362         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 363
 364 2019-06-11  Tom Tromey  <tom@tromey.com>
 365
 366         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 367         (xmalloc_failed): Move to alloc.c.
 368         * alloc.c: New file.
 369         * Makefile.in (COMMON_SFILES): Add alloc.c.
 370
 371 2019-06-11  Tom Tromey  <tom@tromey.com>
 372
 373         * nat/linux-waitpid.c: Don't include server.h.
 374         (linux_debug): Remove.
 375         (my_waitpid): Update.
 376
 377 2019-06-11  Tom Tromey  <tromey@adacore.com>
 378
 379         * infcall.c (_initialize_infcall): Remove trailing newline from
 380         help.
 381         * user-regs.c (_initialize_user_regs): Remove trailing newline
 382         from help.
 383         * typeprint.c (_initialize_typeprint): Remove trailing newline
 384         from help.
 385         * reverse.c (_initialize_reverse): Remove trailing newlines from
 386         help.
 387         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 388         from help.
 389         * language.c (add_set_language_command): Remove trailing newline
 390         from help.
 391         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 392         help.
 393         * disasm.c (_initialize_disasm): Remove trailing newline from
 394         help.
 395         * top.c (init_main): Remove trailing newline from help.
 396         * interps.c (_initialize_interpreter): Remove trailing newline
 397         from help.
 398         * btrace.c (_initialize_btrace): Remove trailing newlines from
 399         help.
 400         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 401         from help.
 402         * python/python.c (_initialize_python): Remove trailing newline
 403         from help.
 404         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 405         help.
 406         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 407         from help.  Reformat some text.
 408         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 409         from help.
 410         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 411         newline from help.
 412
 413 2019-06-11  Tom Tromey  <tromey@adacore.com>
 414
 415         * darwin-nat.c (darwin_decode_exception_message)
 416         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 417
 418 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 419
 420         * valops.c (value_slice): Check for not allocated or not
 421         associated values.
 422
 423 2019-06-10  Tom de Vries  <tdevries@suse.de>
 424
 425         PR gdb/24618
 426         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 427         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 428         invalid.
 429
 430 2019-06-10  Tom de Vries  <tdevries@suse.de>
 431
 432         PR gdb/24611
 433         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 434         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 435
 436 2019-06-10  Tom de Vries  <tdevries@suse.de>
 437
 438         PR symtab/24545
 439         * symtab.c (struct demangled_name_entry): Add language field.
 440         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 441         static minimal symbol".  Set and use language field.
 442
 443 2019-06-10  Tom Tromey  <tromey@adacore.com>
 444
 445         * ada-lang.c (_initialize_ada_language): Update help text.
 446
 447 2019-06-10  Tom Tromey  <tromey@adacore.com>
 448
 449         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 450         with a newline.
 451         * guile/guile.c (handle_boot_error): Don't end warning with a
 452         newline.
 453         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 454         warning with a newline.
 455         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 456         newline.
 457         (s12z_frame_cache): Likewise.
 458         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 459         a newline.
 460         * solib-svr4.c (disable_probes_interface): Don't end warning with
 461         a newline.
 462         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 463         newline.
 464         * python/python.c (do_finish_initialization): Don't end warning
 465         with a newline.
 466
 467 2019-06-10  Tom Tromey  <tom@tromey.com>
 468
 469         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 470         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 471         gdbpy_enter.
 472
 473 2019-06-10  Tom Tromey  <tromey@adacore.com>
 474
 475         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 476         data.
 477         (elf_new_init): Don't call stabsread_new_init.
 478         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 479         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 480         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 481
 482 2019-06-10  Tom de Vries  <tdevries@suse.de>
 483
 484         PR symtab/16264
 485         PR symtab/24517
 486         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 487
 488 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 489
 490         * source.c (find_and_open_source): Also rewrite relative file
 491         names.
 492
 493 2019-04-26  Amos Bird  <amosbird@gmail.com>
 494
 495         * annotate.c (annotate_thread_exited): Add "thread-exited"
 496         annotation.
 497
 498 2019-06-06  Tom Tromey  <tromey@adacore.com>
 499
 500         * maint.h (class scoped_command_stats): Use
 501         DISABLE_COPY_AND_ASSIGN.
 502         <print_time>: New method.
 503         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 504         print_time.
 505         (scoped_command_stats::print_time): New method.
 506
 507 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 508
 509         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 510         instructions of lengths 6 or 8 bytes.
 511
 512 2019-06-04  Pedro Alves  <palves@redhat.com>
 513
 514         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 515
 516         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 517         * breakpoint.c (condition_completer): Likewise.
 518         * cli/cli-dump.c (scan_expression): Likewise.
 519         * common/filestuff.c (mkdir_recursive): Likewise.
 520         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 521         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 522         (gdb_abspath): Likewise.
 523         * compile/compile-cplus-types.c
 524         (compile_cplus_instance::decl_name): Likewise.
 525         * completer.c (complete_explicit_location):
 526         (signal_completer, reg_or_group_completer_1): Likewise.
 527         * cp-support.c (cp_remove_params_if_any): Likewise.
 528         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 529         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 530         * infcmd.c (strip_bg_char): Likewise.
 531         * linespec.c (copy_token_string): Likewise.
 532         * mi/mi-main.c (output_cores): Likewise.
 533         * psymtab.c (psymtab_search_name):
 534         * symfile.c (test_set_ext_lang_command): Likewise.
 535         * target.c (target_fileio_read_stralloc): Likewise.
 536         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 537         * value.c (complete_internalvar): Likewise.
 538
 539 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 540
 541         Add objfile property to gdb.Type.
 542         * NEWS: Mention Python API addition.
 543         * python/py-type.c (typy_get_objfile): New method.
 544
 545 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 546
 547         * NEWS: Mention the new set|show style [title|highlight].
 548         Mention changes to "show style", "help" and "apropos".
 549
 550 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 551
 552         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 553         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 554         instead of print_help_for_command.
 555         (print_doc_of_command): New function.
 556         (help_list): Add 'apropos -v word' suggestion.
 557         (print_help_for_command): Style the command name using title style.
 558         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 559         (_initialize_cli_cmds): Describe -v in apropos_command help.
 560
 561 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 562
 563         * cli/cli-style.h (cli_style_option): Add name in constructor,
 564         add m_name class member, add constructor with intensity,
 565         add name class function.
 566         (cli_style_option::add_setshow_commands): Remove name argument.
 567         (highlight_style, title_style): New styles.
 568         * cli/cli-style.c (do_show): New function that shows a style
 569         characteristic styling the style name with itself.
 570         (set_style_name): New function.
 571         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 572         Update all callers according to the changes in cli/cli-style.h.
 573         * utils.h (fputs_highlighted): New function.
 574         * utils.c (fputs_highlighted): Likewise.
 575
 576 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 577
 578         * NEWS: Mention new pipe command and new convenience variables.
 579
 580 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 581
 582         * cli/cli-cmds.c (pipe_command): New function.
 583         (_initialize_cli_cmds): Call add_com for pipe_command.
 584         Define | as an alias for pipe.
 585         (exit_status_set_internal_vars): New function.
 586         (shell_escape): Call exit_status_set_internal_vars.
 587         cli/cli-decode.c (find_command_name_length): Recognize | as
 588         a single character command.
 589
 590 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 591
 592         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 593         top.c (execute_command_to_ui_file): New function, mostly a copy
 594         of execute_command_to_string.
 595         (execute_command_to_string): Implement by calling
 596         execute_command_to_ui_file.
 597
 598 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 599
 600         * top.h (saved_command_line): Remove declaration.
 601         * top.c (previous_saved_command_line, previous_repeat_arguments):
 602         New variables.
 603         (saved_command_line): Make static, define together with other
 604         'repeat variables'.
 605         (dont_repeat): Clear repeat_arguments.
 606         (repeat_previous, get_saved_command_line, save_command_line):
 607         New functions.
 608         (gdb_init): Initialize saved_command_line
 609         and previous_saved_command_line.
 610         * main.c (captured_main_1): Remove saved_command_line initialization.
 611         * event-top.c (handle_line_of_input): Update to use
 612         the new 'repeat' related functions instead of direct access to
 613         saved_command_line.
 614         * command.h (repeat_previous, get_saved_command_line,
 615         save_command_line): New declarations.
 616         (dont_repeat): Add comment.
 617
 618 2019-05-30  Tom Tromey  <tromey@adacore.com>
 619
 620         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 621         Fix comment.
 622         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 623
 624 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 625
 626         PR cli/24587
 627         * completer.c (complete): Initialize variable word.
 628
 629 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 630
 631         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 632         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 633         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 634         'body' is NULL to the outter 'if', protecting the '!is_define'
 635         situation as well.
 636
 637 2019-05-29  Tom Tromey  <tromey@adacore.com>
 638
 639         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 640         (dwarf_unknown): New function.
 641         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 642         (dwarf_type_encoding_name): Use dwarf_unknown.
 643
 644 2019-05-29  Tom Tromey  <tromey@adacore.com>
 645
 646         PR c++/20020:
 647         * cp-valprint.c (cp_print_value_fields): Call
 648         cp_print_static_field inside "try".
 649
 650 2019-05-29  Tom Tromey  <tromey@adacore.com>
 651
 652         * inflow.c (struct terminal_info): Add default operator=.
 653         * configure: Rebuild.
 654         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 655         -Wdeprecated-copy-dtor, -Wredundant-move.
 656
 657 2019-05-29  Tom Tromey  <tromey@adacore.com>
 658
 659         * NEWS: Add entry.
 660         * infcmd.c (print_return_value_1): Handle finish_print
 661         option.
 662         (show_print_finish): New function.
 663         (_initialize_infcmd): Add "set/show print finish" commands.
 664         * valprint.c (user_print_options): Initialize new member.
 665         * valprint.h (struct value_print_options) <finish_print>: New
 666         member.
 667
 668 2019-05-28  Tom Tromey  <tromey@adacore.com>
 669
 670         * ada-lang.c (ada_remove_Xbn_suffix)
 671         (find_old_style_renaming_symbol)
 672         (parse_old_style_renaming): Remove.
 673         (ada_find_renaming_symbol): Don't call
 674         find_old_style_renaming_symbol.
 675         (ada_is_renaming_symbol): Rename from
 676         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 677         bool.  Now static.
 678         (ada_read_var_value): Update and simplify.
 679         * ada-exp.y (write_var_or_type): Remove old code.
 680
 681 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 682
 683         * event-top.c: Remove include comment.
 684         * inflow.c (class scoped_ignore_sigttou): Move from here...
 685         * inflow.h (class scoped_ignore_sigttou): ...to here.
 686         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 687         * top.c:  Remove include comment.
 688
 689 2019-05-27  Tom Tromey  <tom@tromey.com>
 690
 691         * NEWS: Fix typo.
 692
 693 2019-05-22  Tom Tromey  <tromey@adacore.com>
 694
 695         * target.c (target_follow_exec): Constify parameter.
 696         * target-delegates.c: Rebuild.
 697         * remote.c (remote_target::follow_exec): Constify parameter.
 698         * infrun.c (follow_exec): Constify parameter.
 699         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 700         (target_follow_exec): Likewise.
 701
 702 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 703
 704         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 705         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 706
 707 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 708
 709         * NEWS: Add debugredirect and testsuite sections.
 710
 711 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 712
 713         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 714         target descriptions using exclusively floating point register name
 715         aliases.
 716
 717 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 718
 719         PR gdb/18644:
 720         * f-lang.c (build_fortran_types): Handle the case where
 721         gdbarch_floatformat_for_type returns a nullptr.
 722
 723 2019-05-21  Tom de Vries  <tdevries@suse.de>
 724
 725         PR cli/24587
 726         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 727
 728 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 729
 730         PR gdb/18644:
 731         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 732         16-byte floats.
 733         * i386-tdep.c (i386_floatformat_for_type): Use
 734         floatformats_ia64_quad for the 16-byte floating point component
 735         within a fortran 32-byte complex number.
 736
 737 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 740         delete default constructor.
 741         (find_partial_die): Update to return const struct.
 742         (partial_die_parent_scope): Move variable declaration into scope
 743         of its use and change its type to auto.
 744         (guess_partial_die_structure_name): Likewise.
 745         (partial_die_info::fixup): Likewise.
 746
 747 2019-05-17  Tom Tromey  <tromey@adacore.com>
 748
 749         * source.c (find_and_open_source): Remove cast.
 750
 751 2019-05-17  Tom Tromey  <tromey@adacore.com>
 752
 753         * annotate.c (annotate_source): Make "filename" const.
 754         * annotate.h (annotate_source): Use const.
 755
 756 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 757
 758         * disasm.c (set_disassembler_options): Send errors to stderr.
 759
 760 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 761
 762         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 763         (cli_interp_base::set_logging): Check debug_redirect.
 764         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 765         * cli/cli-logging.c (debug_redirect): Add static variable.
 766         (pop_output_files): Add default param.
 767         (handle_redirections): Print debug setting.
 768         (show_logging_command): Likewise.
 769         (_initialize_cli_logging): Add debugredirect command.
 770         * interps.c (current_interp_set_logging): Add debug_redirect
 771         parameter.
 772         * interps.h (set_logging): Add debug_redirect parameter.
 773         (current_interp_set_logging): Likewise.
 774         * mi/mi-common.h: Likewise.
 775         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 776
 777 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 778             Tom Tromey  <tromey@adacore.com>
 779
 780         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 781         directly.
 782         * cli/cli-interp.h (make_logging_output): Remove declaration.
 783         * cli/cli-logging.c (make_logging_output): Remove function.
 784         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 785         directly.
 786         * ui-file.c (tee_file::tee_file): Remove bools.
 787         (tee_file::~tee_file): Remove deletes.
 788         * ui-file.h (tee_file): Remove bools.
 789
 790 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 791
 792         * mi/mi-cmds.h (mi_cmd_complete): New function.
 793         * mi/mi-main.c (mi_cmd_complete): Likewise.
 794         * mi/mi-cmds.c: Define new MI command -complete.
 795         * NEWS: Mention new -complete command.
 796
 797 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 798
 799         * completer.h (complete): New function.
 800         * completer.c (complete): Likewise.
 801         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 802         function defined in completer.h.
 803
 804 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 805
 806        * MAINTAINERS (Write After Approval): Add myself.
 807
 808 2019-05-17  Tom de Vries  <tdevries@suse.de>
 809
 810         PR gdb/24094
 811         * dwarf2read.c (struct cu_partial_die_info): New struct.
 812         (find_partial_die): Return cu_partial_die_info.
 813         (partial_die_parent_scope, guess_partial_die_structure_name)
 814         (partial_die_info::fixup): Handle new return type of find_partial_die.
 815
 816 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 817
 818         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 819         "std::string", simplifying the algorithm.
 820
 821 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 822
 823         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 824         (stap_static_probe_ops::get_probes): Likewise.
 825
 826 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 827
 828         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 829         '-')" and "else if".
 830         (stap_parse_single_operand): Join checks for
 831         "gdbarch_stap_parse_special_token_p" and
 832         "gdbarch_stap_parse_special_token" in the same "if" statement.
 833         Invert check when verifying for operation on register
 834         displacement.
 835
 836 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 837
 838         * stap-probe.c (stap_get_opcode): Update comment.
 839         (stap_get_expected_argument_type): Likewise.
 840         (handle_stap_probe): Likewise.
 841
 842 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 843
 844         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 845         return type to 'bool'.  Adjust comment.  Use 'bool' when
 846         appropriate.
 847         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 848         * stap-probe.c (stap_parse_argument_1): Likewise.
 849         (stap_is_operator): Likewise.
 850         (stap_is_generic_prefix): Likewise.
 851         (stap_is_register_prefix): Likewise.
 852         (stap_is_register_indirection_prefix): Likewise.
 853         (stap_is_integer_prefix): Likewise.
 854         (stap_generic_check_suffix): Likewise.
 855         (stap_check_integer_suffix): Likewise.
 856         (stap_check_register_suffix): Likewise.
 857         (stap_check_register_indirection_suffix): Likewise.
 858         (stap_parse_register_operand): Likewise.
 859         (stap_parse_single_operand): Likewise.
 860         (stap_parse_argument_1): Likewise.
 861         (stap_probe::get_argument_count): Likewise.
 862         (stap_is_operator): Likewise.
 863
 864 2019-05-16  Tom Tromey  <tromey@adacore.com>
 865
 866         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 867         keyword to foreach.
 868
 869 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 870
 871         * linux-thread-db.c (try_thread_db_load_1): Change return type
 872         to bool.
 873         (try_thread_db_load): Likewise.
 874         (try_thread_db_load_from_pdir_1): Likewise.
 875         (try_thread_db_load_from_pdir): Likewise.
 876         (try_thread_db_load_from_sdir): Likewise.
 877         (try_thread_db_load_from_dir): Likewise.
 878         (thread_db_load_search): Likewise.
 879         (has_libpthread): Likewise.
 880         (thread_db_load): Likewise.
 881
 882 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 883
 884         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 885         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 886         NULL, and complain/return if that's the case.
 887
 888 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 889
 890         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 891         (advance, posn, abstract_read_memory): New functions.
 892         [struct mem_read_abstraction]: New struct.
 893         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 894
 895 2019-05-14  Tom Tromey  <tromey@adacore.com>
 896
 897         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 898         value is not lval_memory.
 899
 900 2019-05-14  Tom Tromey  <tromey@adacore.com>
 901
 902         * solib.c (info_sharedlibrary_command): Style the file name.
 903
 904 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 905
 906         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 907         (aarch64_vnv_type): Likewise.
 908         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 909         * common/tdesc.c: Likewise.
 910         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 911         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 912         * features/aarch64-fpu.xml: Add ieee half view.
 913         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 914         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 915         * gdbtypes.h (struct builtin_type): Likewise.
 916         (struct objfile_type): Likewise.
 917
 918 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 919
 920         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 921         typo.
 922         * location.h (string_to_event_location): Likewise.
 923
 924 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 925
 926         GDB 8.3 released.
 927
 928 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 929
 930         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 931         New variable declaration.
 932         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 933         New variable.
 934         (print_one_breakpoint): Use ui_out::test_flags and new global
 935         variable to compute use_fixed_output.
 936         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 937         Remove.
 938         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 939         (mi_multi_location_breakpoint_output_fixed): Remove.
 940         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 941         new variable.
 942         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 943         fix_multi_location_breakpoint_output flag if version >= 3.
 944         * ui-out.h (enum ui_out_flag)
 945         <fix_multi_location_breakpoint_output>: New enumerator.
 946
 947 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 948
 949         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 950
 951 2019-05-10  Tom Tromey  <tromey@adacore.com>
 952
 953         * ada-lang.c (catch_ada_completer): New function.
 954         (_initialize_ada_language): Use it.
 955
 956 2019-05-10  Tom Tromey  <tromey@adacore.com>
 957
 958         * thread.c (print_thread_info): Make "requested_threads" const.
 959         * gdbthread.h (print_thread_info): Make "requested_threads"
 960         const.
 961         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 962         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 963
 964 2019-05-08  Tom Tromey  <tom@tromey.com>
 965
 966         * gdbtypes.c (objfile_type_data): Change type.
 967         (objfile_type, _initialize_gdbtypes): Update.
 968
 969 2019-05-08  Tom Tromey  <tom@tromey.com>
 970
 971         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 972         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 973         (_initialize_dwarf2_frame): Update.
 974
 975 2019-05-08  Tom Tromey  <tom@tromey.com>
 976
 977         * objc-lang.c (objc_objfile_data): Change type.
 978         (find_methods): Update.
 979         (_initialize_objc_lang): Remove.
 980
 981 2019-05-08  Tom Tromey  <tom@tromey.com>
 982
 983         * stabsread.c (rs6000_builtin_type_data): Change type.
 984         (rs6000_builtin_type, _initialize_stabsread): Update.
 985
 986 2019-05-08  Tom Tromey  <tom@tromey.com>
 987
 988         * mips-tdep.c (mips_pdr_data): Remove.
 989         (_initialize_mips_tdep): Update.
 990
 991 2019-05-08  Tom Tromey  <tom@tromey.com>
 992
 993         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 994         (hppa_init_objfile_priv_data, read_unwind_info)
 995         (find_unwind_entry, _initialize_hppa_tdep): Update.
 996
 997 2019-05-08  Tom Tromey  <tom@tromey.com>
 998
 999         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1000         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1001         on obstack.
1002         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1003
1004 2019-05-08  Tom Tromey  <tom@tromey.com>
1005
1006         * mdebugread.c (basic_type_data): Change type.
1007         (basic_type, _initialize_mdebugread): Update.
1008
1009 2019-05-08  Tom Tromey  <tom@tromey.com>
1010
1011         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1012
1013 2019-05-08  Tom Tromey  <tom@tromey.com>
1014
1015         * nto-tdep.c (nto_inferior_data_reg): Change type.
1016         (nto_inferior_data): Update.
1017         (nto_inferior_data_cleanup, nto_new_inferior_data)
1018         (_initialize_nto_tdep): Remove.
1019         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1020
1021 2019-05-08  Tom Tromey  <tom@tromey.com>
1022
1023         * ada-lang.c (struct ada_inferior_data): Add initializers.
1024         (ada_inferior_data): Change type.
1025         (ada_inferior_data_cleanup): Remove.
1026         (get_ada_inferior_data, ada_inferior_exit)
1027         (struct ada_pspace_data): Add initializers, destructor.
1028         (ada_pspace_data_handle): Change type.
1029         (get_ada_pspace_data): Update.
1030         (ada_pspace_data_cleanup): Remove.
1031
1032 2019-05-08  Tom Tromey  <tom@tromey.com>
1033
1034         * coffread.c (struct coff_symfile_info): Add initializers.
1035         (coff_objfile_data_key): Move lower.  Change type.
1036         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1037         Update.
1038         (coff_free_info): Remove.
1039
1040 2019-05-08  Tom Tromey  <tom@tromey.com>
1041
1042         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1043         (fbsd_pspace_data_handle): Move lower.  Change type.
1044         (get_fbsd_pspace_data): Update.
1045         (fbsd_pspace_data_cleanup): Remove.
1046         (_initialize_fbsd_tdep): Update.
1047
1048 2019-05-08  Tom Tromey  <tom@tromey.com>
1049
1050         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1051         (get_ada_tasks_pspace_data): Update.
1052         (ada_tasks_pspace_data_cleanup): Remove.
1053         (_initialize_tasks): Update.
1054         (ada_tasks_inferior_data_handle): Change type.
1055         (get_ada_tasks_inferior_data): Update.
1056         (ada_tasks_inferior_data_cleanup): Remove.
1057         (struct ada_tasks_pspace_data): Add initializers.
1058
1059 2019-05-08  Tom Tromey  <tom@tromey.com>
1060
1061         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1062         * symfile-debug.c (debug_sym_get_probes): Change type.
1063         * stap-probe.c (handle_stap_probe):
1064         (stap_static_probe_ops::get_probes): Change type.
1065         * probe.h (class static_probe_ops) <get_probes>: Change type.
1066         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1067         (parse_probes_in_pspace): Update.
1068         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1069         Update.
1070         (any_static_probe_ops::get_probes): Change type.
1071         * elfread.c (elfread_data): New typedef.
1072         (probe_key): Change type.
1073         (elf_get_probes): Likewise.  Update.
1074         (probe_key_free): Remove.
1075         (_initialize_elfread): Update.
1076         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1077         Change type.
1078         (dtrace_process_dof_probe, dtrace_process_dof)
1079         (dtrace_static_probe_ops::get_probe): Change type.
1080
1081 2019-05-08  Tom Tromey  <tom@tromey.com>
1082
1083         * xcoffread.c (struct xcoff_symfile_info): Rename from
1084         coff_symfile_info.  Add initializers.
1085         (xcoff_objfile_data_key): Move lower.  Change type.
1086         (XCOFF_DATA): Rewrite.
1087         (xcoff_free_info): Remove.
1088         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1089         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1090         (xcoff_initial_scan): Update.
1091
1092 2019-05-08  Tom Tromey  <tom@tromey.com>
1093
1094         * solib-svr4.c (struct svr4_info): Add initializers and
1095         destructor.
1096         <probes_table>: Now an htab_up.
1097         (solib_svr4_pspace_data): Change type.
1098         (free_probes_table): Simplify.
1099         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1100         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1101         (probes_table_remove_objfile_probes, register_solib_event_probe)
1102         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1103         (_initialize_svr4_solib): Update.
1104
1105 2019-05-08  Tom Tromey  <tom@tromey.com>
1106
1107         * remote.c (remote_pspace_data): Change type.
1108         (remote_pspace_data_cleanup): Remove.
1109         (get_remote_exec_file, set_pspace_remote_exec_file)
1110         (_initialize_remote): Update.
1111
1112 2019-05-08  Tom Tromey  <tom@tromey.com>
1113
1114         * breakpoint.c (breakpoint_objfile_key): Change type.
1115         (get_breakpoint_objfile_data): Update.
1116         (free_breakpoint_objfile_data): Remove.
1117         (_initialize_breakpoint): Update.
1118
1119 2019-05-08  Tom Tromey  <tom@tromey.com>
1120
1121         * linux-tdep.c (struct linux_info): Add initializers.
1122         (linux_inferior_data): Move.  Change type.
1123         (invalidate_linux_cache_inf): Update.
1124         (linux_inferior_data_cleanup): Remove.
1125         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1126
1127 2019-05-08  Tom Tromey  <tom@tromey.com>
1128
1129         * auxv.c (auxv_inferior_data): Move.  Change type.
1130         (auxv_inferior_data_cleanup): Remove.
1131         (invalidate_auxv_cache_inf): Rewrite.
1132         (get_auxv_inferior_data, _initialize_auxv): Update.
1133
1134 2019-05-08  Tom Tromey  <tom@tromey.com>
1135
1136         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1137         (symfile_debug_objfile_data_key): Change type.
1138         (symfile_debug_installed, debug_qf_has_symbols)
1139         (debug_qf_find_last_source_symtab)
1140         (debug_qf_forget_cached_source_info)
1141         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1142         (debug_qf_print_stats, debug_qf_dump)
1143         (debug_qf_expand_symtabs_for_function)
1144         (debug_qf_expand_all_symtabs)
1145         (debug_qf_expand_symtabs_with_fullname)
1146         (debug_qf_map_matching_symbols)
1147         (debug_qf_expand_symtabs_matching)
1148         (debug_qf_find_pc_sect_compunit_symtab)
1149         (debug_qf_map_symbol_filenames)
1150         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1151         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1152         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1153         (debug_sym_read_linetable, debug_sym_relocate): Update.
1154         (symfile_debug_free_objfile): Remove.
1155         (install_symfile_debug_logging, _initialize_symfile_debug):
1156         Update.
1157
1158 2019-05-08  Tom Tromey  <tom@tromey.com>
1159
1160         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1161         allocate_on_obstack.
1162         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1163         (get_dwarf2_per_objfile): Update.
1164         (set_dwarf2_per_objfile): Remove.
1165         (dwarf2_has_info, dwarf2_get_section_info): Update.
1166         (dwarf2_free_objfile): Remove.
1167         (_initialize_dwarf2_read): Update.
1168
1169 2019-05-08  Tom Tromey  <tom@tromey.com>
1170
1171         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1172         initializers.
1173         <unsupported_script_warning_printed,
1174         script_not_found_warning_printed>: Now bool.
1175         (auto_load_pspace_data): Change type.
1176         (~auto_load_pspace_info): Rename from
1177         auto_load_pspace_data_cleanup.
1178         (get_auto_load_pspace_data, init_loaded_scripts_info)
1179         (clear_section_scripts, maybe_print_unsupported_script_warning)
1180         (maybe_print_script_not_found_warning, _initialize_auto_load):
1181         Update.
1182
1183 2019-05-08  Tom Tromey  <tom@tromey.com>
1184
1185         * objfiles.c (objfile_pspace_info): Add destructor and
1186         initializers.
1187         (objfiles_pspace_data): Change type.
1188         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1189         (get_objfile_pspace_data): Update.
1190         (objfiles_bfd_data): Change type.
1191         (get_objfile_bfd_data): Update.
1192         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1193
1194 2019-05-08  Tom Tromey  <tom@tromey.com>
1195
1196         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1197         Change type.
1198         (get_catch_syscall_inferior_data): Update.
1199         (catch_syscall_inferior_data_cleanup): Remove.
1200         (_initialize_break_catch_syscall): Update.
1201
1202 2019-05-08  Tom Tromey  <tom@tromey.com>
1203
1204         * inflow.c (struct terminal_info): Add destructor and
1205         initializers.
1206         (inflow_inferior_data): Change type.
1207         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1208         (get_inflow_inferior_data, inflow_inferior_exit)
1209         (swap_terminal_info, _initialize_inflow): Update.
1210
1211 2019-05-08  Tom Tromey  <tom@tromey.com>
1212
1213         * target-dcache.c (target_dcache_cleanup): Remove.
1214         (target_dcache_aspace_key): Change type.
1215         (target_dcache_init_p, target_dcache_invalidate)
1216         (target_dcache_get, target_dcache_get_or_init)
1217         (_initialize_target_dcache): Update.
1218         * dcache.h (struct dcache_deleter): New.
1219
1220 2019-05-08  Tom Tromey  <tom@tromey.com>
1221
1222         * symtab.c (struct symbol_cache): Add destructor and
1223         initializers.
1224         (symbol_cache_key): Move.  Change type.
1225         (make_symbol_cache, free_symbol_cache): Remove.
1226         (get_symbol_cache): Update.
1227         (symbol_cache_cleanup): Remove.
1228         (ALL_PSPACES, symbol_cache_flush)
1229         (maintenance_print_symbol_cache)
1230         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1231         Update.
1232
1233 2019-05-08  Tom Tromey  <tom@tromey.com>
1234
1235         * symtab.c (struct main_info): Add destructor and initializers.
1236         (main_progspace_key): Move.  Change type.
1237         (get_main_info): Update.
1238         (main_info_cleanup): Remove.
1239         (_initialize_symtab): Update.
1240
1241 2019-05-08  Tom Tromey  <tom@tromey.com>
1242
1243         * registry.h (DECLARE_REGISTRY): Define the _key class.
1244
1245 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * NEWS: Merge two 'New commands' sections.
1248
1249 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1250
1251         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1252         parameter and use Ada language definition instead.
1253         (ada_val_print_ptr): Remove unused language parameter.
1254         (ada_val_print_num): Remove language parameter and use Ada language
1255         definition instead.
1256         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1257         parameter.
1258         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1259         parameter and use Ada language definition instead.
1260         (ada_val_print_1): Update all ada_val_print_xxx calls.
1261         Remove language parameter.
1262         (ada_val_print): Update ada_val_print_1 call.
1263
1264 2019-05-08  Tom Tromey  <tromey@adacore.com>
1265
1266         * remote.c (remote_hw_watchpoint_limit)
1267         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1268         Now static.
1269
1270 2019-05-08  Tom Tromey  <tromey@adacore.com>
1271
1272         * maint.c (_initialize_maint_cmds): Move initialization code to
1273         remote.c.
1274         (watchdog, show_watchdog): Move to remote.c.
1275         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1276         "watchdog" static.
1277         (_initialize_remote): Move initialization code from maint.c.
1278         * defs.h (watchdog): Don't declare.
1279
1280 2019-05-08  Tom Tromey  <tromey@adacore.com>
1281
1282         * tui/tui-interp.c: Include main.h.
1283         * interps.c: Include main.h.
1284         * main.h (interpreter_p): Declare.
1285         * defs.h (interpreter_p): Don't declare.
1286
1287 2019-05-08  Tom Tromey  <tromey@adacore.com>
1288
1289         * dwarf2loc.c: Include dwarf2read.h.
1290         * defs.h (read_unsigned_leb128): Don't declare.
1291         * dwarf2read.h (read_unsigned_leb128): Declare.
1292
1293 2019-05-08  Tom Tromey  <tromey@adacore.com>
1294
1295         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1296         method.
1297
1298 2019-05-08  Tom Tromey  <tromey@adacore.com>
1299
1300         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1301         when no wrap column is set.
1302
1303 2019-05-08  Tom Tromey  <tromey@adacore.com>
1304
1305         * c-lang.c (c_get_string): Handle non-C-style arrays.
1306
1307 2019-05-08  Tom Tromey  <tromey@adacore.com>
1308
1309         * typeprint.c (print_offset_data::update): Print the bit offset,
1310         not the number of bits remaining.
1311
1312 2019-05-08  Tom Tromey  <tromey@adacore.com>
1313
1314         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1315         padding at end of comment.
1316
1317 2019-05-08  Tom Tromey  <tromey@adacore.com>
1318
1319         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1320         Compare main types.
1321
1322 2019-05-06  Tom Tromey  <tom@tromey.com>
1323
1324         * common/scoped_mmap.c: Include common-defs.h.
1325         * common/scoped_mmap.h: Don't include config.h.
1326
1327 2019-05-04  Tom Tromey  <tom@tromey.com>
1328
1329         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1330         (struct aarch64_call_info): Add initializers.
1331         <si>: Now a std::vector.
1332         (pass_on_stack, aarch64_push_dummy_call): Update.
1333
1334 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1335             Tom Tromey  <tom@tromey.com>
1336
1337         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1338         (ppc_threads): Now a std::vector.  Now static.
1339         (hwdebug_find_thread_points_by_tid)
1340         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1341         Update.
1342
1343 2019-05-04  Tom Tromey  <tom@tromey.com>
1344
1345         * arc-tdep.c (arc_tdesc_init): Return bool.
1346
1347 2019-05-04  Tom Tromey  <tom@tromey.com>
1348
1349         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1350         Use gdb_assert_not_reached.
1351
1352 2019-05-04  Tom Tromey  <tom@tromey.com>
1353
1354         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1355         "false".
1356
1357 2019-05-04  Tom Tromey  <tom@tromey.com>
1358
1359         * arc-tdep.c (arc_tdesc_init): Use bool.
1360
1361 2019-05-04  Tom Tromey  <tom@tromey.com>
1362
1363         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1364
1365 2019-05-04  Tom Tromey  <tom@tromey.com>
1366
1367         * cli/cli-cmds.c (valid_command_p): Return bool.
1368
1369 2019-05-04  Tom Tromey  <tom@tromey.com>
1370
1371         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1372         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1373
1374 2019-05-04  Raul Tambre  <raul@tambre.ee>
1375
1376         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1377         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1378         operator for comparison.
1379
1380 2019-05-04  Tom Tromey  <tom@tromey.com>
1381
1382         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1383         (lookup_partial_symbol, print_partial_symbols)
1384         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1385         (psymbol_compare): Update.
1386         (add_psymbol_to_bcache): Clear the entire psymbol.
1387         (maintenance_check_psymtabs): Update.
1388         * psympriv.h (struct partial_symbol): Don't derive from
1389         general_symbol_info.
1390         <obj_section, unrelocated_address, address,
1391         set_unrelocated_address>: Update.
1392         <ginfo>: New member.
1393         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1394         (debug_names::write_psymbols): Update.
1395
1396 2019-05-04  Tom de Vries  <tdevries@suse.de>
1397
1398         * contrib/cc-with-tweaks.sh: Support -n arg.
1399
1400 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1401
1402         * corelow.c (core_target::detach): Ensure frame cache and
1403         register caches are cleared.
1404         inferior.c (exit_inferior_1): Likewise.
1405
1406 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1407             Tom Tromey  <tom@tromey.com>
1408
1409         * dictionary.c (collate_pending_symbols_by_language): Remove
1410         "struct" from foreach.
1411         * symtab.c (lookup_global_symbol_from_objfile)
1412         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1413         foreach.
1414         * ser-tcp.c (net_open): Remove "struct" from foreach.
1415         * objfiles.c (objfile_relocate, objfile_rebase)
1416         (objfile_has_symbols): Remove "struct" from foreach.
1417         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1418         from foreach.
1419         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1420         foreach.
1421         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1422         "struct" from foreach.
1423         * ada-lang.c (create_excep_cond_exprs)
1424         (ada_exception_catchpoint_cond_string): Remove "struct" from
1425         foreach.
1426
1427 2019-05-03  Tom Tromey  <tromey@adacore.com>
1428
1429         * ada-exp.y (convert_char_literal): Check suffix of each
1430         enumerator.
1431
1432 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1433
1434         PR ada/21406:
1435         * ada-exp.y (yywrap): Don't define.
1436         * ada-lex.l (%option): Add noyywrap
1437         (yywrap): Remove.
1438
1439 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1440
1441         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1442         _WIN32_WINNT to the XP level, unless already defined to a higher
1443         level.
1444
1445         * unittests/parse-connection-spec-selftests.c:
1446         * ser-tcp.c:
1447         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1448         override.
1449
1450         * symfile.c (find_separate_debug_file): Remove colon from the
1451         drive spec of DOS/Windows file names of the target, so that the
1452         file name produced from DEBUGDIR and the target's directory will
1453         be valid on DOS/Windows systems.
1454
1455 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1456
1457         * rust-lang.c (val_print_struct): Handle printing structures
1458         containing strings.
1459
1460 2019-05-02  Tom Tromey  <tromey@adacore.com>
1461
1462         * valarith.c (_initialize_valarith): Remove.
1463
1464 2019-05-01  Tom Tromey  <tromey@adacore.com>
1465
1466         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1467         bitfields.
1468
1469 2019-05-01  Tom Tromey  <tromey@adacore.com>
1470
1471         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1472         for big-endian copies.
1473
1474 2019-04-30  Ali Tamur  <tamur@google.com>
1475         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1476         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1477         (read_3_bytes): New function.
1478
1479 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1480
1481         * windows-nat.c (main_thread_id): Delete.
1482         (handle_output_debug_string): Replace main_thread_id by
1483         current_event.dwThreadId.
1484         (fake_create_process): Likewise.
1485         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1486         Do not set main_thread_id.
1487         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1488         current_event.dwThreadId.
1489         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1490
1491 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1492
1493         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1494         Use current_event.dwThreadId instead of main_thread_id.
1495
1496 2019-04-30  Tom Tromey  <tromey@adacore.com>
1497
1498         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1499         (create_excep_cond_exprs): Iterate over program spaces.
1500         (ada_exception_catchpoint_cond_string): Examine all minimal
1501         symbols for exception types.
1502
1503 2019-04-30  Tom Tromey  <tromey@adacore.com>
1504
1505         PR c++/24470:
1506         * dwarf2read.c (process_structure_scope): Handle case where type
1507         has template parameters but no symbol was created.
1508
1509 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1510             Chris January  <chris.january@arm.com>
1511
1512         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1513         qualifier.
1514         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1515
1516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1517
1518         * f-typeprint.c (f_print_type): Update rules for printing
1519         whitespace.
1520         (f_type_print_varspec_suffix): Likewise.
1521
1522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1523             Chris January  <chris.january@arm.com>
1524
1525         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1526         function arguments.
1527
1528 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1529
1530         * f-lang.c (build_fortran_types): Change name of void type to
1531         lower case.
1532         * f-typeprint.c (f_type_print_base): Print the name of the void
1533         type, rather than a fixed string.
1534         * f-valprint.c (f_decorations): Use lower case void string.
1535
1536 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1537             Chris January  <chris.january@arm.com>
1538
1539         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1540         types for Fortran.
1541
1542 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1543             Chris January  <chris.january@arm.com>
1544             David Lecomber  <david.lecomber@arm.com>
1545
1546         * f-exp.y (BINOP_INTRINSIC): New token.
1547         (exp): New parser rule handling BINOP_INTRINSIC.
1548         (f77_keywords): Add new builtin procedures.
1549         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1550         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1551         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1552         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1553         (print_unop_subexp_f): New function.
1554         (print_binop_subexp_f): New function.
1555         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1556         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1557         (dump_subexp_body_f): Likewise.
1558         (operator_check_f): Likewise.
1559         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1560         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1561
1562 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1565         UNOP_KIND.
1566         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1567         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1568         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1569         (operator_length_f): New fuction.
1570         (print_subexp_f): New function.
1571         (op_name_f): New function.
1572         (dump_subexp_body_f): New function.
1573         (operator_check_f): New function.
1574         (exp_descriptor_f): Replace standard expression handling functions
1575         with new functions.
1576         * gdb/fortran-operator.def: New file.
1577         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1578         * gdb/std-operator.def: Remove UNOP_KIND.
1579
1580 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * std-operator.def: Remove unbalanced, stray double quote
1583         character.
1584
1585 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1586             Chris January  <chris.january@arm.com>
1587             Daniel Everett  <daniel.everett@arm.com>
1588             Nick Forrington  <nick.forrington@arm.com>
1589             Richard Bunt  <richard.bunt@arm.com>
1590
1591         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1592         of depth when printing anonymous structs or unions.
1593         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1594         Don't print either the top-level value, or the children if the
1595         max-depth is exceeded.
1596         (ppscm_print_children): When printing the key of a map, allow one
1597         extra level of depth.
1598         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1599         print either the top-level value, or the children if the max-depth
1600         is exceeded.
1601         (print_children): When printing the key of a map, allow one extra
1602         level of depth.
1603         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1604         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1605         (user_print_options): Initialise max_depth field.
1606         (val_print_scalar_or_string_type_p): New function.
1607         (val_print): Check to see if the max depth has been reached.
1608         (val_print_check_max_depth): Define new function.
1609         (show_print_max_depth): New function.
1610         (_initialize_valprint): Add 'print max-depth' option.
1611         * valprint.h (struct value_print_options) <max_depth>: New field.
1612         (val_print_check_max_depth): Declare new function.
1613         * NEWS: Document new feature.
1614
1615 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * ada-lang.c (ada_language_defn): Initialise new field.
1618         * c-lang.c (c_is_string_type_p): New function.
1619         (c_language_defn): Initialise new field.
1620         (cplus_language_defn): Initialise new field.
1621         (asm_language_defn): Initialise new field.
1622         (minimal_language_defn): Initialise new field.
1623         * c-lang.h (c_is_string_type_p): Declare new function.
1624         * d-lang.c (d_language_defn): Initialise new field.
1625         * f-lang.c (f_is_string_type_p): New function.
1626         (f_language_defn): Initialise new field.
1627         * go-lang.c (go_is_string_type_p): New function.
1628         (go_language_defn): Initialise new field.
1629         * language.c (default_is_string_type_p): New function.
1630         (unknown_language_defn): Initialise new field.
1631         (auto_language_defn): Initialise new field.
1632         * language.h (struct language_defn) <la_is_string_type_p>: New
1633         member variable.
1634         (default_is_string_type_p): Declare new function.
1635         * m2-lang.c (m2_language_defn): Initialise new field.
1636         * objc-lang.c (objc_language_defn): Initialise new field.
1637         * opencl-lang.c (opencl_language_defn): Initialise new field.
1638         * p-lang.c (pascal_is_string_type_p): New function.
1639         (pascal_language_defn): Initialise new field.
1640         * rust-lang.c (rust_is_string_type_p): New function.
1641         (rust_language_defn): Initialise new field.
1642
1643 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1646         New field.
1647         * ada-lang.c (ada_language_defn): Initialise new field.
1648         * c-lang.c (c_language_defn): Likewise.
1649         (cplus_language_defn): Likewise.
1650         (asm_language_defn): Likewise.
1651         (minimal_language_defn): Likewise.
1652         * d-lang.c (d_language_defn): Likewise.
1653         * f-lang.c (f_language_defn): Likewise.
1654         * go-lang.c (go_language_defn): Likewise.
1655         * language.c (unknown_language_defn): Likewise.
1656         (auto_language_defn): Likewise.
1657         * m2-lang.c (m2_language_defn): Likewise.
1658         * objc-lang.c (objc_language_defn): Likewise.
1659         * opencl-lang.c (opencl_language_defn): Likewise.
1660         * p-lang.c (pascal_language_defn): Likewise.
1661         * rust-lang.c (rust_language_defn): Likewise.
1662
1663 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1664
1665         * ada-lang.c (ada_is_character_type): Change return type to bool.
1666         (ada_is_string_type): Likewise.
1667         * ada-lang.h (ada_is_character_type): Update declaration
1668         (ada_is_string_type): Likewise.
1669
1670 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1671
1672         Support style in 'frame|thread apply'
1673
1674         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1675         * record.c (record_start, record_stop): Update callers of
1676         execute_command_to_string with false.
1677         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1678         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1679         methods.
1680         (class string_file): New constructor with term_out parameter.
1681         Override methods term_out and can_emit_style_escape.  New member
1682         term_out.
1683         (class stdio_file): Override can_emit_style_escape.
1684         (class tee_file): Override term_out and can_emit_style_escape.
1685         * utils.h (can_emit_style_escape): Remove.
1686         * utils.c (can_emit_style_escape): Likewise.
1687         Update all callers of can_emit_style_escape (SOMESTREAM) to
1688         SOMESTREAM->can_emit_style_escape.
1689         * source-cache.c (source_cache::get_source_lines): Likewise.
1690         * stack.c (frame_apply_command_count): Call execute_command_to_string
1691         passing the term_out characteristic of the current gdb_stdout.
1692         * thread.c (thr_try_catch_cmd): Likewise.
1693         * top.c (execute_command_to_string): pass term_out parameter
1694         to construct the string_file for the command output.
1695         * ui-file.c (term_cli_styling): New function (most code moved
1696         from utils.c can_emit_style_escape).
1697         (string_file::string_file, string_file::can_emit_style_escape,
1698         stdio_file::can_emit_style_escape, tee_file::term_out,
1699         tee_file::can_emit_style_escape): New functions.
1700
1701 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1702
1703         * NEWS: Mention the new set|show may-call-functions.
1704         * infcall.c (may_call_functions_p): New variable.
1705         (show_may_call_functions_p): New function.
1706         (call_function_by_hand_dummy): Throws an error if not
1707         may-call-functions.
1708         (_initialize_infcall): Call add_setshow_boolean_cmd for
1709         may-call-functions.
1710
1711 2019-04-25  Keith Seitz  <keiths@redhat.com>
1712
1713         PR c++/24367
1714         * cp-support.c (inspect_type): Don't attempt substitutions
1715         of symbol with the same name.
1716
1717 2019-04-25  Tom Tromey  <tromey@adacore.com>
1718
1719         PR gdb/24475:
1720         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1721         static.
1722
1723 2019-04-25  Tom Tromey  <tromey@adacore.com>
1724
1725         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1726         rvalue reference.
1727         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1728         (gdb_xml_parser::parse): Use std::move.
1729         * python/python-internal.h (gdbpy_convert_exception): Take a const
1730         reference.
1731         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1732         std::move.
1733         * python/py-utils.c (gdbpy_convert_exception): Take a const
1734         reference.
1735         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1736         Use std::move.
1737         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1738         Use std::move.
1739         * mi/mi-main.c (mi_print_exception): Take a const reference.
1740         * main.c (handle_command_errors): Take a const reference.
1741         * linespec.c (parse_linespec): Use std::move.
1742         * infcall.c (run_inferior_call): Use std::move.
1743         (call_function_by_hand_dummy): Use std::move.
1744         * exec.c (try_open_exec_file): Use std::move.
1745         * exceptions.h (exception_print, exception_fprintf)
1746         (exception_print_same): Update.
1747         * exceptions.c (print_exception, exception_print)
1748         (exception_fprintf, exception_print_same): Change parameters to
1749         const reference.
1750         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1751         * common/new-op.c: Use std::move.
1752         * common/common-exceptions.h (struct gdb_exception): Add move
1753         constructor.
1754         (struct gdb_exception_error, struct gdb_exception_quit, struct
1755         gdb_quit_bad_alloc): Change constructor to move constructor.
1756         (throw_exception): Change parameter to rvalue reference.
1757         * common/common-exceptions.c (throw_exception): Take rvalue
1758         reference.
1759         * cli/cli-interp.c (safe_execute_command): Use std::move.
1760         * breakpoint.c (insert_bp_location, location_to_sals): Use
1761         std::move.
1762
1763 2019-04-25  Tom Tromey  <tromey@adacore.com>
1764
1765         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1766         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1767         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1768         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1769         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1770         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1771         guile/scm-value.c: Use unpack.
1772         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1773         gdbscm_gdb_exception.
1774         (gdbscm_throw_gdb_exception): Likewise.
1775         (struct gdbscm_gdb_exception): New.
1776         (unpack): New function.
1777         (gdbscm_wrap): Use unpack.
1778
1779 2019-04-25  Tom Tromey  <tromey@adacore.com>
1780
1781         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1782         (gdb_rl_callback_handler): Use std::move.
1783         * common/common-exceptions.h (struct gdb_exception): Add move
1784         assignment operator.
1785         (throw_exception_sjlj): Change "exception" to const reference.
1786         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1787         (throw_exception_sjlj): Change "exception" to const reference.
1788
1789 2019-04-25  Tom Tromey  <tromey@adacore.com>
1790
1791         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1792         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1793         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1794         Update.
1795         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1796         Update.
1797         * mi/mi-interp.c (mi_interp::exec): Update.
1798         * linespec.c (parse_linespec): Update.
1799         * infcall.c (run_inferior_call): Update.
1800         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1801         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1802         (gdbscm_lookup_global_symbol): Update.
1803         * guile/scm-param.c (gdbscm_parameter_value): Update.
1804         * guile/scm-frame.c (gdbscm_frame_read_register)
1805         (gdbscm_frame_read_var): Update.
1806         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1807         * exec.c (try_open_exec_file): Update.
1808         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1809         (gdb_rl_callback_handler): Update.
1810         * common/common-exceptions.h (exception_none): Don't declare.
1811         * common/common-exceptions.c (exception_none): Don't define.
1812         (struct catcher) <exception>: Update.
1813         * cli/cli-interp.c (safe_execute_command): Update.
1814         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1815
1816 2019-04-25  Ali Tamur  <tamur@google.com>
1817
1818         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1819         (read_attribute_value): Likewise.
1820         (dwarf2_read_addr_index): Update comment.
1821         (read_str_index): Add DW_FORM_strx.
1822         (dwarf2_string_attr): Likewise.
1823         (dwarf2_const_value_attr): Likewise.
1824         (dump_die_shallow): Likewise.
1825         (dwarf2_fetch_constant_bytes): Likewise.
1826         (skip_form_bytes): Likewise.
1827         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1828
1829 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1830
1831         PR corefiles/11608
1832         PR corefiles/18187
1833         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1834         OFFSET.  Verify if current mapping contains an ELF header.
1835         (linux_find_memory_regions_full): Adjust call to
1836         dump_mapping_p.
1837
1838 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1839             Kang Li <kanglictf@gmail.com>
1840
1841         PR gdb/21600
1842
1843         * dwarf2-frame.c (read_initial_length): Be consistent about using
1844         unsigned representation of length.
1845         (decode_frame_entry_1): Likewise.  Check for wraparound of
1846         end pointer as well as buffer overflow.
1847
1848 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1849
1850         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1851         "vq".
1852
1853 2019-04-24  Tom Tromey  <tromey@adacore.com>
1854
1855         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1856
1857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1858
1859         * s12z-tdep.c (s12z_unwind_pc): Delete.
1860         (s12z_unwind_sp): Delete.
1861         (s12z_gdbarch_init): Don't register deleted functions with
1862         gdbarch.
1863
1864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1865
1866         * rl78-tdep.c (rl78_unwind_sp): Delete.
1867         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1868
1869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1872         (xstormy16_unwind_pc): Delete.
1873         (xstormy16_dummy_id): Delete.
1874         (xstormy16_gdbarch_init): Don't register deleted functions with
1875         gdbarch.
1876
1877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1878
1879         * vax-tdep.c (vax_unwind_pc): Delete.
1880         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1881
1882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1883
1884         * v850-tdep.c (v850_unwind_sp): Delete.
1885         (v850_unwind_pc): Delete.
1886         (v850_dummy_id): Delete.
1887         (v850_gdbarch_init): Don't register deleted functions with
1888         gdbarch.
1889
1890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1893         (tilegx_unwind_pc): Delete.
1894         (tilegx_unwind_dummy_id): Delete.
1895         (tilegx_gdbarch_init): Don't register deleted functions with
1896         gdbarch.
1897
1898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1901         (tic6x_dummy_id): Delete.
1902         (tic6x_gdbarch_init): Don't register deleted functions with
1903         gdbarch.
1904
1905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * sparc-tdep.c (sparc_unwind_pc): Delete.
1908         (sparc32_gdbarch_init): Don't register deleted function with
1909         gdbarch.
1910
1911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1912
1913         * sh-tdep.c (sh_unwind_sp): Delete.
1914         (sh_unwind_pc): Delete.
1915         (sh_dummy_id): Delete.
1916         (sh_gdbarch_init): Don't register deleted functions with
1917         gdbarch.
1918
1919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         * score-tdep.c (score_unwind_sp): Delete.
1922         (score_unwind_pc): Delete.
1923         (score_dummy_id): Delete.
1924         (score_gdbarch_init): Don't register deleted functions with
1925         gdbarch.
1926
1927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1928
1929         * rx-tdep.c (rx_unwind_pc): Delete.
1930         (rx_unwind_sp): Delete.
1931         (rx_dummy_id): Delete.
1932         (rx_gdbarch_init): Don't register deleted functions with
1933         gdbarch.  Update comment.
1934
1935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1936
1937         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1938         (rs6000_dummy_id): Delete.
1939         (rs6000_gdbarch_init): Don't register deleted functions with
1940         gdbarch.
1941
1942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1943
1944         * or1k-tdep.c (or1k_dummy_id): Delete.
1945         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1946
1947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1948
1949         * nios2-tdep.c (nios2_dummy_id): Delete.
1950         (nios2_unwind_sp): Delete.
1951         (nios2_gdbarch_init): Don't register deleted functions with
1952         gdbarch.
1953
1954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1955
1956         * nds32-tdep.c (nds32_dummy_id): Delete.
1957         (nds32_unwind_pc): Delete.
1958         (nds32_unwind_sp): Delete.
1959         (nds32_gdbarch_init): Don't register deleted functions with
1960         gdbarch.
1961
1962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1963
1964         * msp430-tdep.c (msp430_unwind_pc): Delete.
1965         (msp430_unwind_sp): Delete.
1966         (msp430_dummy_id): Delete.
1967         (msp430_gdbarch_init): Don't register deleted functions with
1968         gdbarch.
1969
1970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * moxie-tdep.c (moxie_unwind_sp): Delete.
1973         (moxie_unwind_pc): Delete.
1974         (moxie_dummy_id): Delete.
1975         (moxie_gdbarch_init): Don't register deleted functions with
1976         gdbarch.
1977
1978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1981         (mn10300_unwind_pc): Delete.
1982         (mn10300_unwind_sp): Delete.
1983         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1984         mn10300_unwind_sp.
1985         (mn10300_frame_unwind_init): Don't register deleted functions with
1986         gdbarch.
1987
1988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * mep-tdep.c (mep_unwind_pc): Delete.
1991         (mep_unwind_sp): Delete.
1992         (mep_dummy_id): Delete.
1993         (mep_gdbarch_init): Don't register deleted functions with
1994         gdbarch.
1995
1996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1997
1998         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1999         (m68hc11_unwind_sp): Delete.
2000         (m68hc11_gdbarch_init): Don't register deleted functions with
2001         gdbarch.
2002
2003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * m32r-tdep.c (m32r_unwind_sp): Delete.
2006         (m32r_unwind_pc): Delete.
2007         (m32r_dummy_id): Delete.
2008         (m32r_gdbarch_init): Don't register deleted functions with
2009         gdbarch.
2010
2011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * m32c-tdep.c (m32c_unwind_pc): Delete.
2014         (m32c_unwind_sp): Delete.
2015         (m32c_dummy_id): Delete.
2016         (m32c_gdbarch_init): Don't register deleted functions with
2017         gdbarch.
2018
2019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2022         (lm32_unwind_pc): Delete.
2023         (lm32_dummy_id): Delete.
2024         (lm32_gdbarch_init): Don't register deleted functions with
2025         gdbarch.
2026
2027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2028
2029         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2030         (iq2000_unwind_pc): Delete.
2031         (iq2000_dummy_id): Delete.
2032         (iq2000_gdbarch_init): Don't register deleted functions with
2033         gdbarch.
2034
2035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2036
2037         * nds32-tdep.c (nds32_type_align): Delete.
2038         (nds32_push_dummy_call): Use type_align instead.
2039
2040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2041
2042         * arm-tdep.c (arm_type_align): Only handle vector override case.
2043         (arm_push_dummy_call): Use type_align.
2044         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2045
2046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2047
2048         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2049         case.
2050         (pass_on_stack): Use type_align.
2051         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2052         function.
2053
2054 2019-04-23  Tom Tromey  <tromey@adacore.com>
2055
2056         * dwarf2read.c (line_header::file_name_at): Remove unused
2057         overload.
2058
2059 2019-04-23  Tom de Vries  <tdevries@suse.de>
2060
2061         PR gdb/24438
2062         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2063         invocation.
2064
2065
2066 2019-03-27  Ali Tamur  <tamur@google.com>
2067
2068         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2069         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2070         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2071         (dwarf_expr_context::get_addr_index): Likewise
2072         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2073         (symbol_needs_eval_context::get_addr_index): Likewise
2074         (disassemble_dwarf_expression): Add DW_OP_addrx
2075         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2076         (read_cutu_die_from_dwo): Update comment
2077         (skip_one_die): Add DW_FORM_addrx
2078         (read_attribute_value): Likewise
2079         (var_decode_location): Add DW_OP_addrx
2080         (dwarf2_const_value_attr): Add DW_FORM_addrx
2081         (dump_die_shallow): Likewise
2082         (dwarf2_fetch_constant_bytes): Likewise
2083         (decode_locdesc): Add DW_OP_addrx
2084         (skip_form_bytes): Add DW_FORM_addrx
2085
2086 2019-04-22  Ali Tamur  <tamur@google.com>
2087
2088         * MAINTAINERS (Write After Approval): Add self.
2089
2090 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2091
2092         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2093         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2094         (open_symbol_file_object): Likewise.
2095         (svr4_default_sos): Add info parameter.
2096         (svr4_read_so_list): Likewise.
2097         (svr4_current_sos_direct): Adjust functions calls to pass down
2098         info.
2099         (svr4_current_sos_1): Add info parameter.
2100         (svr4_current_sos): Call get_svr4_info, pass info down to
2101         svr4_current_sos_1.
2102         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2103         get_svr4_info.
2104         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2105         get_svr4_info.
2106         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2107         to get_svr4_info.
2108         (probes_table_remove_objfile_probes): Likewise.
2109         (register_solib_event_probe): Add info parameter.
2110         (solist_update_incremental): Pass info parameter down to
2111         svr4_read_so_list.
2112         (disable_probes_interface): Add info parameter.
2113         (svr4_handle_solib_event): Pass current_program_space to
2114         get_svr4_info.  Adjust disable_probes_interface cleanup.
2115         (svr4_create_probe_breakpoints): Add info parameter, pass it
2116         down to register_solib_event_probe.
2117         (svr4_create_solib_event_breakpoints): Add info parameter,
2118         pass it down to svr4_create_probe_breakpoints.
2119         (enable_break): Pass info down to
2120         svr4_create_solib_event_breakpoints.
2121         (svr4_solib_create_inferior_hook): Pass current_program_space to
2122         get_svr4_info.
2123         (svr4_clear_solib): Likewise.
2124
2125 2019-04-22  Pedro Alves  <palves@redhat.com>
2126
2127         * solib-svr4.c (svr4_free_objfile_observer): New.
2128         (probe_and_action::objfile): New field.
2129         (probes_table_htab_remove_objfile_probes)
2130         (probes_table_remove_objfile_probes): New functions.
2131         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2132         in the new probe_and_action.  Don't store the probe in 'lookup'.
2133         (svr4_create_probe_breakpoints): Pass objfile to
2134         register_solib_event_probe.
2135         (_initialize_svr4_solib): Register a free_objfile observer.
2136
2137 2019-04-19  Tom Tromey  <tom@tromey.com>
2138
2139         * common/queue.h: Remove.
2140
2141 2019-04-19  Tom Tromey  <tom@tromey.com>
2142
2143         * event-loop.c: Don't include "common/queue.h".
2144
2145 2019-04-19  Tom Tromey  <tom@tromey.com>
2146
2147         * remote.c (remote_target): Use delete.
2148         * remote-notif.h: Include <list>, not "common/queue.h".
2149         (notif_client_p): Remove typedef.
2150         (remote_notif_state): Add constructor, destructor, initializer.
2151         <notif_queue>: Now a std::list.
2152         (remote_notif_state_xfree): Don't declare.
2153         * remote-notif.c (remote_notif_process, handle_notification)
2154         (remote_notif_state_allocate): Update.
2155         (~remote_notif_state): Rename from remote_notif_state_xfree.
2156
2157 2019-04-19  Tom Tromey  <tom@tromey.com>
2158
2159         * symfile.c (reread_symbols): Update.
2160         * objfiles.c (objfile_register_static_link)
2161         (objfile_lookup_static_link): Update
2162         (~objfile) Don't delete static_links.
2163         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2164
2165 2019-04-19  Tom Tromey  <tom@tromey.com>
2166
2167         * type-stack.h (struct type_stack) <insert>: Constify string.
2168         * type-stack.c (type_stack::insert): Constify string.
2169         * gdbtypes.h (lookup_template_type): Update.
2170         (address_space_name_to_int): Update.
2171         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2172         const.
2173         (lookup_template_type): Make name const.
2174         * c-exp.y: Update rules.
2175         (lex_one_token, classify_name, classify_inner_name)
2176         (c_print_token): Update.
2177         * p-exp.y: Update rules.
2178         (yylex): Update.
2179         * f-exp.y: Update rules.
2180         (yylex): Update.
2181         * d-exp.y: Update rules.
2182         (lex_one_token, classify_name, classify_inner_name): Update.
2183         * parse.c (write_dollar_variable, copy_name): Return std::string.
2184         * parser-defs.h (copy_name): Change return type.
2185         * m2-exp.y: Update rules.
2186         (yylex): Update.
2187         * go-exp.y (lex_one_token): Update.
2188         Update rules.
2189         (classify_unsafe_function, classify_packaged_name)
2190         (classify_name, yylex): Update.
2191
2192 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2193
2194         * configure.ac: add --enable-source-highlight switch.
2195         * configure: Regenerate.
2196         * top.c (print_gdb_version): plumb --enable-source-highlight
2197         status to "show configuration".
2198
2199 2019-04-19  Tom Tromey  <tromey@adacore.com>
2200
2201         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2202         Check ADA_TYPE_P.
2203         (empty_record, ada_template_to_fixed_record_type_1)
2204         (template_to_static_fixed_type)
2205         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2206         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2207         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2208         macros.
2209
2210 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2211
2212         PR symtab/24423:
2213         * source.c (print_source_lines_base): Advance "iter" when a
2214         control character is seen.
2215
2216 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2217
2218         * inferior.h (struct infcall_suspend_state_deleter):
2219         Catch exception in destructor to avoid crash.
2220
2221 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2222
2223         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2224         close to the add_com "shell".
2225
2226 2019-04-18  Tom Tromey  <tromey@adacore.com>
2227
2228         * process-stratum-target.h (class process_stratum_target)
2229         <stratum>: Add "final".
2230
2231 2019-04-17  Tom Tromey  <tromey@adacore.com>
2232
2233         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2234         against nullptr before use.
2235
2236 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2237
2238         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2239
2240 2019-04-17  Jim Wilson  <jimw@sifive.com>
2241             Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2244         code read might fail, assume 4-byte breakpoint in that case.
2245
2246 2019-04-15  Leszek Swirski  <leszeks@google.com>
2247
2248         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2249         rather than a hand-rolled POD check when checking for forced MEMORY
2250         classification.
2251
2252 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2253
2254         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2255         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2256         function.
2257         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2258         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2259         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2260         declaration.
2261
2262 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2263
2264         * aarch64-linux-nat.c
2265         (aarch64_linux_nat_target::thread_architecture): Add override.
2266         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2267         each VQ.
2268
2269 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2270
2271         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2272
2273 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2276         target types of size 96-bits, add some additional comments, and
2277         check that the builtin type we found was the correct size.
2278
2279 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2280
2281         * utils.c (prompt_for_continue): Don't restore the styling at the
2282         end, as applied_style has the wrong value.  This fixes styling in
2283         long lists of file names that are interrupted by the "Continue?"
2284         prompt.
2285
2286 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2289         * c-lang.c (c_language_defn): Likewise.
2290         (cplus_language_defn): Likewise.
2291         (asm_language_defn): Likewise.
2292         (minimal_language_defn): Likewise.
2293         * d-lang.c (d_language_defn): Likewise.
2294         * f-lang.c (f_language_defn): Likewise.
2295         * go-lang.c (go_language_defn): Likewise.
2296         * language.c (unknown_language_defn): Likewise.
2297         (auto_language_defn): Likewise.
2298         * language.h (struct language_defn): Remove la_magic field.
2299         (LANG_MAGIC): Delete.
2300         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2301         * objc-lang.c (objc_language_defn): Likewise.
2302         * opencl-lang.c (opencl_language_defn): Likewise.
2303         * p-lang.c (pascal_language_defn): Likewise.
2304         * rust-lang.c (rust_language_defn): Likewise.
2305
2306 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * riscv-tdep.c (riscv_type_align): New function.
2309         (riscv_type_alignment): Delete.
2310         (riscv_arg_location): Use 'type_align'.
2311         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2312
2313 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * gdbtypes.c (type_align): A struct with no non-static fields also
2316         has alignment of 1.
2317
2318 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2321         component to 0.
2322         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2323         member.
2324         (riscv_struct_info::analyse): New implementation using new
2325         analyse_inner member function.
2326         (riscv_struct_info::field_offset): New member function.
2327         (riscv_struct_info::m_offsets): New member variable.
2328         (riscv_struct_info::analyse_inner): New private member function,
2329         takes the old implementation of riscv_struct_info::analyse but
2330         extended to track field offsets.
2331         (riscv_call_arg_struct): Update the struct folding special cases
2332         to handle cases where empty C++ structs, which are non-zero
2333         length, are found.
2334         (riscv_arg_location): Initialise the length of each location, a
2335         non-zero length now indicates the location is in use.
2336         (riscv_push_dummy_call): Allow for the first location having a
2337         non-zero offset when setting up arguments.
2338         (riscv_return_value): Likewise, but for return values.
2339
2340 2019-04-11  Tom Tromey  <tromey@adacore.com>
2341
2342         * utils.c (internal_vproblem): Make "msg" const.
2343
2344 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2345
2346         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2347         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2348         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2349         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2350
2351 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2352
2353         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2354         function.
2355         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2356         of amd64_collect_native_gregset.
2357         (amd64_linux_nat_target::store_registers): Likewise.
2358
2359 2019-04-10  Tom Tromey  <tom@tromey.com>
2360
2361         * symtab.c (lookup_global_symbol_from_objfile)
2362         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2363         * objfiles.h (class separate_debug_iterator): New.
2364         (class separate_debug_range): New.
2365         (struct objfile) <separate_debug_objfiles>: New method.
2366         (objfile_separate_debug_iterate): Don't declare.
2367         * objfiles.c (separate_debug_iterator::operator++): Rename from
2368         objfile_separate_debug_iterate.
2369         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2370         iterator.
2371         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2372         iterator.
2373
2374 2019-04-10  Tom Tromey  <tom@tromey.com>
2375
2376         * symfile.c (reread_symbols): Remove old comment.
2377         * objfiles.c (free_all_objfiles): Fix a typo.
2378
2379 2019-04-10  Tom Tromey  <tom@tromey.com>
2380
2381         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2382         * minsyms.c (lookup_minimal_symbol): Use foreach.
2383         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2384         (lookup_minimal_symbol_solib_trampoline): Likewise.
2385         * symfile.c (reread_symbols): Use foreach.
2386
2387 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2388             Tom Tromey  <tromey@adacore.com>
2389
2390         PR rust/24414:
2391         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2392         (rust_lex_int_test): Change "value" to be LONGEST.
2393         (rust_lex_tests): Add test for long integer literal.
2394
2395 2019-04-09  Tom Tromey  <tromey@adacore.com>
2396
2397         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2398         to bool.
2399         (extended_remote_target::attach): Update.
2400         (remote_target::remote_notice_new_inferior): Update.
2401         (remote_target::add_current_inferior_and_thread): Update.
2402         * inferior.c (exit_inferior_1): Use "false".
2403         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2404
2405 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2406
2407         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2408         the "start" command.
2409
2410 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2411
2412         * python/py-inferior.c (infpy_thread_from_thread_handle):
2413         Adjust comments to reflect renaming of thread_from_thread_handle
2414         to thread_from_handle.  Adjust keywords.  Fix type error message.
2415         (inferior_object_methods): Add thread_from_handle.  Retain
2416         thread_from_thread_handle, but mark it as deprecated.
2417
2418 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2419
2420         * gdbthread.h (find_thread_by_handle): Revise declaration.
2421         * thread.c (find_thread_by_handle): Likewise.  Adjust
2422         implementation too.
2423         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2424         support for buffer objects as handles.
2425
2426 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2427
2428         * python/py-infthread.c (thpy_thread_handle): New function.
2429         (thread_object_methods): Register thpy_thread_handle.
2430
2431 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2432
2433         * gdbthread.h (thread_to_thread_handle): Declare.
2434         * thread.c (gdbtypes.h): Include.
2435         (thread_to_thread_handle): New function.
2436
2437         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2438         (target_thread_info_to_thread_handle): Declare.
2439         * target.c (target_thread_info_to_thread_handle): New function.
2440         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2441         * target-delegates.c: Regenerate.
2442
2443         * linux-thread-db.c (class thread_db_target): Add method
2444         thread_info_to_thread_handle.
2445         (thread_db_target::thread_info_to_thread_handle): Define.
2446         * remote.c (class remote_target): Add new method
2447         thread_info_to_thread_handle.
2448         (remote_target::thread_info_to_thread_handle): Define.
2449
2450 2019-04-08  Pedro Alves  <palves@redhat.com>
2451
2452         * common/common-exceptions.c (throw_exception): Don't create
2453         named object to throw; throw directly.
2454         (throw_it): Likewise.  Don't initialize gdb_exception::message
2455         here, with new; pass FMT and AP to the ctor instead.
2456         * common/common-exceptions.h: Include <string>.
2457         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2458         const char *, va_list)): New ctor.  Use std::make_shared.
2459         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2460         errors)): Delete.
2461         (gdb_exception_error::gdb_exception_error(enum errors, const char
2462         *, va_list)): New.
2463         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2464         Add assertion.
2465         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2466         errors)): Delete.
2467         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2468         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2469         Add assertion.
2470
2471 2019-04-08  Tom Tromey  <tom@tromey.com>
2472
2473         * valops.c (value_rtti_indirect_type): Replace throw_exception
2474         with throw.
2475         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2476         with throw.
2477         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2478         throw.
2479         * target.c (target_translate_tls_address): Replace throw_exception
2480         with throw.
2481         * stack.c (frame_apply_command_count): Replace throw_exception
2482         with throw.
2483         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2484         throw.
2485         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2486         with throw.
2487         * rs6000-tdep.c (rs6000_frame_cache)
2488         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2489         * remote.c: Replace throw_exception with throw.
2490         * record-full.c (record_full_message, record_full_wait_1)
2491         (record_full_restore): Replace throw_exception with throw.
2492         * record-btrace.c:
2493         (get_thread_current_frame_id, record_btrace_start_replaying)
2494         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2495         (cmd_record_btrace_start): Replace throw_exception with throw.
2496         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2497         throw.
2498         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2499         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2500         * linespec.c:
2501         (find_linespec_symbols): Replace throw_exception with throw.
2502         * infrun.c (displaced_step_prepare, resume): Replace
2503         throw_exception with throw.
2504         * infcmd.c (post_create_inferior): Replace throw_exception with
2505         throw.
2506         * inf-loop.c (inferior_event_handler): Replace throw_exception
2507         with throw.
2508         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2509         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2510         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2511         (get_prev_frame_always, get_frame_pc_if_available)
2512         (get_frame_address_in_block_if_available, get_frame_language):
2513         Replace throw_exception with throw.
2514         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2515         throw_exception with throw.
2516         * eval.c (fetch_subexp_value, evaluate_var_value)
2517         (evaluate_funcall, evaluate_subexp_standard): Replace
2518         throw_exception with throw.
2519         * dwarf2loc.c (call_site_find_chain)
2520         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2521         Replace throw_exception with throw.
2522         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2523         with throw.
2524         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2525         throw.
2526         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2527         * completer.c (complete_line_internal): Replace throw_exception
2528         with throw.
2529         * compile/compile-object-run.c (compile_object_run): Replace
2530         throw_exception with throw.
2531         * cli/cli-script.c (process_next_line): Replace throw_exception
2532         with throw.
2533         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2534         (btrace_enable, btrace_maint_update_pt_packets): Replace
2535         throw_exception with throw.
2536         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2537         throw_exception with throw.
2538         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2539         throw_exception with throw.
2540         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2541         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2542         * aarch64-tdep.c (aarch64_make_prologue_cache)
2543         (aarch64_make_stub_cache): Replace throw_exception with throw.
2544
2545 2019-04-08  Tom Tromey  <tom@tromey.com>
2546
2547         * common/common-exceptions.c (throw_exception): Rename from
2548         throw_exception_cxx.  Remove old copy.  Make argument const.
2549         (throw_it): Create and throw exception objects directly.
2550         * common/common-exceptions.h (throw_exception): Make argument
2551         const.
2552         (struct gdb_exception_error): Add constructor.
2553         (struct gdb_exception_quit): Add constructor.
2554
2555 2019-04-08  Tom Tromey  <tom@tromey.com>
2556
2557         * common/common-exceptions.h (exception_rethrow): Don't declare.
2558         (TRY_SJLJ): Update comment.
2559         (TRY, CATCH, END_CATCH): Remove.
2560         * common/common-exceptions.c (exception_rethrow): Remove.
2561
2562 2019-04-08  Tom Tromey  <tom@tromey.com>
2563
2564         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2565         Remove.
2566         (gdb_exception_error): Rename from
2567         gdb_exception_RETURN_MASK_ERROR.
2568         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2569         (gdb_quit_bad_alloc): Update.
2570         * aarch64-tdep.c: Update.
2571         * ada-lang.c: Update.
2572         * ada-typeprint.c: Update.
2573         * ada-valprint.c: Update.
2574         * amd64-tdep.c: Update.
2575         * arch-utils.c: Update.
2576         * break-catch-throw.c: Update.
2577         * breakpoint.c: Update.
2578         * btrace.c: Update.
2579         * c-varobj.c: Update.
2580         * cli/cli-cmds.c: Update.
2581         * cli/cli-interp.c: Update.
2582         * cli/cli-script.c: Update.
2583         * common/common-exceptions.c: Update.
2584         * common/new-op.c: Update.
2585         * common/selftest.c: Update.
2586         * compile/compile-c-symbols.c: Update.
2587         * compile/compile-cplus-symbols.c: Update.
2588         * compile/compile-object-load.c: Update.
2589         * compile/compile-object-run.c: Update.
2590         * completer.c: Update.
2591         * corelow.c: Update.
2592         * cp-abi.c: Update.
2593         * cp-support.c: Update.
2594         * cp-valprint.c: Update.
2595         * darwin-nat.c: Update.
2596         * disasm-selftests.c: Update.
2597         * dtrace-probe.c: Update.
2598         * dwarf-index-cache.c: Update.
2599         * dwarf-index-write.c: Update.
2600         * dwarf2-frame-tailcall.c: Update.
2601         * dwarf2-frame.c: Update.
2602         * dwarf2loc.c: Update.
2603         * dwarf2read.c: Update.
2604         * eval.c: Update.
2605         * event-loop.c: Update.
2606         * event-top.c: Update.
2607         * exec.c: Update.
2608         * f-valprint.c: Update.
2609         * fbsd-tdep.c: Update.
2610         * frame-unwind.c: Update.
2611         * frame.c: Update.
2612         * gdbtypes.c: Update.
2613         * gnu-v3-abi.c: Update.
2614         * guile/guile-internal.h: Update.
2615         * guile/scm-block.c: Update.
2616         * guile/scm-breakpoint.c: Update.
2617         * guile/scm-cmd.c: Update.
2618         * guile/scm-disasm.c: Update.
2619         * guile/scm-frame.c: Update.
2620         * guile/scm-lazy-string.c: Update.
2621         * guile/scm-math.c: Update.
2622         * guile/scm-param.c: Update.
2623         * guile/scm-ports.c: Update.
2624         * guile/scm-pretty-print.c: Update.
2625         * guile/scm-symbol.c: Update.
2626         * guile/scm-symtab.c: Update.
2627         * guile/scm-type.c: Update.
2628         * guile/scm-value.c: Update.
2629         * i386-linux-tdep.c: Update.
2630         * i386-tdep.c: Update.
2631         * inf-loop.c: Update.
2632         * infcall.c: Update.
2633         * infcmd.c: Update.
2634         * infrun.c: Update.
2635         * jit.c: Update.
2636         * language.c: Update.
2637         * linespec.c: Update.
2638         * linux-fork.c: Update.
2639         * linux-nat.c: Update.
2640         * linux-tdep.c: Update.
2641         * linux-thread-db.c: Update.
2642         * main.c: Update.
2643         * mi/mi-cmd-break.c: Update.
2644         * mi/mi-cmd-stack.c: Update.
2645         * mi/mi-interp.c: Update.
2646         * mi/mi-main.c: Update.
2647         * objc-lang.c: Update.
2648         * p-valprint.c: Update.
2649         * parse.c: Update.
2650         * ppc-linux-tdep.c: Update.
2651         * printcmd.c: Update.
2652         * python/py-arch.c: Update.
2653         * python/py-breakpoint.c: Update.
2654         * python/py-cmd.c: Update.
2655         * python/py-finishbreakpoint.c: Update.
2656         * python/py-frame.c: Update.
2657         * python/py-framefilter.c: Update.
2658         * python/py-gdb-readline.c: Update.
2659         * python/py-inferior.c: Update.
2660         * python/py-infthread.c: Update.
2661         * python/py-lazy-string.c: Update.
2662         * python/py-linetable.c: Update.
2663         * python/py-objfile.c: Update.
2664         * python/py-param.c: Update.
2665         * python/py-prettyprint.c: Update.
2666         * python/py-progspace.c: Update.
2667         * python/py-record-btrace.c: Update.
2668         * python/py-record.c: Update.
2669         * python/py-symbol.c: Update.
2670         * python/py-type.c: Update.
2671         * python/py-unwind.c: Update.
2672         * python/py-utils.c: Update.
2673         * python/py-value.c: Update.
2674         * python/python.c: Update.
2675         * record-btrace.c: Update.
2676         * record-full.c: Update.
2677         * remote-fileio.c: Update.
2678         * remote.c: Update.
2679         * riscv-tdep.c: Update.
2680         * rs6000-aix-tdep.c: Update.
2681         * rs6000-tdep.c: Update.
2682         * rust-exp.y: Update.
2683         * rust-lang.c: Update.
2684         * s390-tdep.c: Update.
2685         * selftest-arch.c: Update.
2686         * solib-dsbt.c: Update.
2687         * solib-frv.c: Update.
2688         * solib-spu.c: Update.
2689         * solib-svr4.c: Update.
2690         * solib.c: Update.
2691         * sparc64-linux-tdep.c: Update.
2692         * stack.c: Update.
2693         * symfile-mem.c: Update.
2694         * symmisc.c: Update.
2695         * target.c: Update.
2696         * thread.c: Update.
2697         * top.c: Update.
2698         * tracefile-tfile.c: Update.
2699         * tui/tui.c: Update.
2700         * typeprint.c: Update.
2701         * unittests/cli-utils-selftests.c: Update.
2702         * unittests/parse-connection-spec-selftests.c: Update.
2703         * valops.c: Update.
2704         * valprint.c: Update.
2705         * value.c: Update.
2706         * varobj.c: Update.
2707         * windows-nat.c: Update.
2708         * x86-linux-nat.c: Update.
2709         * xml-support.c: Update.
2710
2711 2019-04-08  Tom Tromey  <tom@tromey.com>
2712
2713         * xml-support.c: Use C++ exception handling.
2714         * x86-linux-nat.c: Use C++ exception handling.
2715         * windows-nat.c: Use C++ exception handling.
2716         * varobj.c: Use C++ exception handling.
2717         * value.c: Use C++ exception handling.
2718         * valprint.c: Use C++ exception handling.
2719         * valops.c: Use C++ exception handling.
2720         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2721         handling.
2722         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2723         * typeprint.c: Use C++ exception handling.
2724         * tui/tui.c: Use C++ exception handling.
2725         * tracefile-tfile.c: Use C++ exception handling.
2726         * top.c: Use C++ exception handling.
2727         * thread.c: Use C++ exception handling.
2728         * target.c: Use C++ exception handling.
2729         * symmisc.c: Use C++ exception handling.
2730         * symfile-mem.c: Use C++ exception handling.
2731         * stack.c: Use C++ exception handling.
2732         * sparc64-linux-tdep.c: Use C++ exception handling.
2733         * solib.c: Use C++ exception handling.
2734         * solib-svr4.c: Use C++ exception handling.
2735         * solib-spu.c: Use C++ exception handling.
2736         * solib-frv.c: Use C++ exception handling.
2737         * solib-dsbt.c: Use C++ exception handling.
2738         * selftest-arch.c: Use C++ exception handling.
2739         * s390-tdep.c: Use C++ exception handling.
2740         * rust-lang.c: Use C++ exception handling.
2741         * rust-exp.y: Use C++ exception handling.
2742         * rs6000-tdep.c: Use C++ exception handling.
2743         * rs6000-aix-tdep.c: Use C++ exception handling.
2744         * riscv-tdep.c: Use C++ exception handling.
2745         * remote.c: Use C++ exception handling.
2746         * remote-fileio.c: Use C++ exception handling.
2747         * record-full.c: Use C++ exception handling.
2748         * record-btrace.c: Use C++ exception handling.
2749         * python/python.c: Use C++ exception handling.
2750         * python/py-value.c: Use C++ exception handling.
2751         * python/py-utils.c: Use C++ exception handling.
2752         * python/py-unwind.c: Use C++ exception handling.
2753         * python/py-type.c: Use C++ exception handling.
2754         * python/py-symbol.c: Use C++ exception handling.
2755         * python/py-record.c: Use C++ exception handling.
2756         * python/py-record-btrace.c: Use C++ exception handling.
2757         * python/py-progspace.c: Use C++ exception handling.
2758         * python/py-prettyprint.c: Use C++ exception handling.
2759         * python/py-param.c: Use C++ exception handling.
2760         * python/py-objfile.c: Use C++ exception handling.
2761         * python/py-linetable.c: Use C++ exception handling.
2762         * python/py-lazy-string.c: Use C++ exception handling.
2763         * python/py-infthread.c: Use C++ exception handling.
2764         * python/py-inferior.c: Use C++ exception handling.
2765         * python/py-gdb-readline.c: Use C++ exception handling.
2766         * python/py-framefilter.c: Use C++ exception handling.
2767         * python/py-frame.c: Use C++ exception handling.
2768         * python/py-finishbreakpoint.c: Use C++ exception handling.
2769         * python/py-cmd.c: Use C++ exception handling.
2770         * python/py-breakpoint.c: Use C++ exception handling.
2771         * python/py-arch.c: Use C++ exception handling.
2772         * printcmd.c: Use C++ exception handling.
2773         * ppc-linux-tdep.c: Use C++ exception handling.
2774         * parse.c: Use C++ exception handling.
2775         * p-valprint.c: Use C++ exception handling.
2776         * objc-lang.c: Use C++ exception handling.
2777         * mi/mi-main.c: Use C++ exception handling.
2778         * mi/mi-interp.c: Use C++ exception handling.
2779         * mi/mi-cmd-stack.c: Use C++ exception handling.
2780         * mi/mi-cmd-break.c: Use C++ exception handling.
2781         * main.c: Use C++ exception handling.
2782         * linux-thread-db.c: Use C++ exception handling.
2783         * linux-tdep.c: Use C++ exception handling.
2784         * linux-nat.c: Use C++ exception handling.
2785         * linux-fork.c: Use C++ exception handling.
2786         * linespec.c: Use C++ exception handling.
2787         * language.c: Use C++ exception handling.
2788         * jit.c: Use C++ exception handling.
2789         * infrun.c: Use C++ exception handling.
2790         * infcmd.c: Use C++ exception handling.
2791         * infcall.c: Use C++ exception handling.
2792         * inf-loop.c: Use C++ exception handling.
2793         * i386-tdep.c: Use C++ exception handling.
2794         * i386-linux-tdep.c: Use C++ exception handling.
2795         * guile/scm-value.c: Use C++ exception handling.
2796         * guile/scm-type.c: Use C++ exception handling.
2797         * guile/scm-symtab.c: Use C++ exception handling.
2798         * guile/scm-symbol.c: Use C++ exception handling.
2799         * guile/scm-pretty-print.c: Use C++ exception handling.
2800         * guile/scm-ports.c: Use C++ exception handling.
2801         * guile/scm-param.c: Use C++ exception handling.
2802         * guile/scm-math.c: Use C++ exception handling.
2803         * guile/scm-lazy-string.c: Use C++ exception handling.
2804         * guile/scm-frame.c: Use C++ exception handling.
2805         * guile/scm-disasm.c: Use C++ exception handling.
2806         * guile/scm-cmd.c: Use C++ exception handling.
2807         * guile/scm-breakpoint.c: Use C++ exception handling.
2808         * guile/scm-block.c: Use C++ exception handling.
2809         * guile/guile-internal.h: Use C++ exception handling.
2810         * gnu-v3-abi.c: Use C++ exception handling.
2811         * gdbtypes.c: Use C++ exception handling.
2812         * frame.c: Use C++ exception handling.
2813         * frame-unwind.c: Use C++ exception handling.
2814         * fbsd-tdep.c: Use C++ exception handling.
2815         * f-valprint.c: Use C++ exception handling.
2816         * exec.c: Use C++ exception handling.
2817         * event-top.c: Use C++ exception handling.
2818         * event-loop.c: Use C++ exception handling.
2819         * eval.c: Use C++ exception handling.
2820         * dwarf2read.c: Use C++ exception handling.
2821         * dwarf2loc.c: Use C++ exception handling.
2822         * dwarf2-frame.c: Use C++ exception handling.
2823         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2824         * dwarf-index-write.c: Use C++ exception handling.
2825         * dwarf-index-cache.c: Use C++ exception handling.
2826         * dtrace-probe.c: Use C++ exception handling.
2827         * disasm-selftests.c: Use C++ exception handling.
2828         * darwin-nat.c: Use C++ exception handling.
2829         * cp-valprint.c: Use C++ exception handling.
2830         * cp-support.c: Use C++ exception handling.
2831         * cp-abi.c: Use C++ exception handling.
2832         * corelow.c: Use C++ exception handling.
2833         * completer.c: Use C++ exception handling.
2834         * compile/compile-object-run.c: Use C++ exception handling.
2835         * compile/compile-object-load.c: Use C++ exception handling.
2836         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2837         * compile/compile-c-symbols.c: Use C++ exception handling.
2838         * common/selftest.c: Use C++ exception handling.
2839         * common/new-op.c: Use C++ exception handling.
2840         * cli/cli-script.c: Use C++ exception handling.
2841         * cli/cli-interp.c: Use C++ exception handling.
2842         * cli/cli-cmds.c: Use C++ exception handling.
2843         * c-varobj.c: Use C++ exception handling.
2844         * btrace.c: Use C++ exception handling.
2845         * breakpoint.c: Use C++ exception handling.
2846         * break-catch-throw.c: Use C++ exception handling.
2847         * arch-utils.c: Use C++ exception handling.
2848         * amd64-tdep.c: Use C++ exception handling.
2849         * ada-valprint.c: Use C++ exception handling.
2850         * ada-typeprint.c: Use C++ exception handling.
2851         * ada-lang.c: Use C++ exception handling.
2852         * aarch64-tdep.c: Use C++ exception handling.
2853
2854 2019-04-08  Tom Tromey  <tom@tromey.com>
2855
2856         * xml-support.c (gdb_xml_parser::parse): Update.
2857         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2858         * value.c (show_convenience): Update.
2859         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2860         (test_parse_flags_qcs): Update.
2861         * thread.c (thr_try_catch_cmd): Update.
2862         * target.c (target_translate_tls_address): Update.
2863         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2864         (info_frame_command_core, frame_apply_command_count): Update.
2865         * rust-exp.y (rust_lex_exception_test): Update.
2866         * riscv-tdep.c (riscv_print_one_register_info): Update.
2867         * remote.c (remote_target::enable_btrace): Update.
2868         * record-btrace.c (record_btrace_enable_warn): Update.
2869         * python/py-utils.c (gdbpy_convert_exception): Update.
2870         * printcmd.c (do_one_display, print_variable_and_value): Update.
2871         * mi/mi-main.c (mi_print_exception): Update.
2872         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2873         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2874         * linux-nat.c (linux_nat_target::attach): Update.
2875         * linux-fork.c (class scoped_switch_fork_info): Update.
2876         * infrun.c (displaced_step_prepare): Update.
2877         * infcall.c (call_function_by_hand_dummy): Update.
2878         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2879         * gnu-v3-abi.c (print_one_vtable): Update.
2880         * frame.c (get_prev_frame_always): Update.
2881         * f-valprint.c (info_common_command_for_block): Update.
2882         * exec.c (try_open_exec_file): Update.
2883         * exceptions.c (print_exception, exception_print)
2884         (exception_fprintf, exception_print_same): Update.
2885         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2886         * dwarf-index-cache.c (index_cache::store)
2887         (index_cache::lookup_gdb_index): Update.
2888         * darwin-nat.c (maybe_cache_shell): Update.
2889         * cp-valprint.c (cp_print_value_fields): Update.
2890         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2891         (gcc_cplus_symbol_address): Update.
2892         * compile/compile-c-symbols.c (gcc_convert_symbol)
2893         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2894         * common/selftest.c: Update.
2895         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2896         a std::string.
2897         (exception_try_scope_entry, exception_try_scope_exit): Don't
2898         declare.
2899         (struct exception_try_scope): Remove.
2900         (TRY): Don't use exception_try_scope.
2901         (struct gdb_exception): Add constructor, operator=.
2902         <what>: New method.
2903         (struct gdb_exception_RETURN_MASK_ALL)
2904         (struct gdb_exception_RETURN_MASK_ERROR)
2905         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2906         (struct gdb_quit_bad_alloc): Update.
2907         * common/common-exceptions.c (exception_none): Change
2908         initializer.
2909         (struct catcher) <state, exception>: Initialize inline.
2910         <prev>: Remove member.
2911         (current_catcher): Remove.
2912         (catchers): New global.
2913         (exceptions_state_mc_init): Simplify.
2914         (catcher_pop): Remove.
2915         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2916         (try_scope_depth, exception_try_scope_entry)
2917         (exception_try_scope_exit): Remove.
2918         (throw_exception_sjlj): Update.
2919         (exception_messages, exception_messages_size): Remove.
2920         (throw_it): Simplify.
2921         (gdb_exception_sliced_copy): Remove.
2922         (throw_exception_cxx): Update.
2923         * cli/cli-script.c (script_from_file): Update.
2924         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2925         Update.
2926         * ada-valprint.c (ada_val_print): Update.
2927         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2928         (create_excep_cond_exprs): Update.
2929
2930 2019-04-08  Tom Tromey  <tom@tromey.com>
2931
2932         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2933         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2934         (TRY, CATCH, END_CATCH): Remove some definitions.
2935         * common/common-exceptions.c: Don't use GDB_XCPT.
2936         (catcher_list_size): Remove.
2937         (throw_exception, throw_it): Simplify.
2938
2939 2019-04-05  Tom Tromey  <tom@tromey.com>
2940
2941         Revert the header-sorting patch.
2942         * ft32-tdep.c: Revert.
2943         * frv-tdep.c: Revert.
2944         * frv-linux-tdep.c: Revert.
2945         * frame.c: Revert.
2946         * frame-unwind.c: Revert.
2947         * frame-base.c: Revert.
2948         * fork-child.c: Revert.
2949         * findvar.c: Revert.
2950         * findcmd.c: Revert.
2951         * filesystem.c: Revert.
2952         * filename-seen-cache.h: Revert.
2953         * filename-seen-cache.c: Revert.
2954         * fbsd-tdep.c: Revert.
2955         * fbsd-nat.h: Revert.
2956         * fbsd-nat.c: Revert.
2957         * f-valprint.c: Revert.
2958         * f-typeprint.c: Revert.
2959         * f-lang.c: Revert.
2960         * extension.h: Revert.
2961         * extension.c: Revert.
2962         * extension-priv.h: Revert.
2963         * expprint.c: Revert.
2964         * exec.h: Revert.
2965         * exec.c: Revert.
2966         * exceptions.c: Revert.
2967         * event-top.c: Revert.
2968         * event-loop.c: Revert.
2969         * eval.c: Revert.
2970         * elfread.c: Revert.
2971         * dwarf2read.h: Revert.
2972         * dwarf2read.c: Revert.
2973         * dwarf2loc.c: Revert.
2974         * dwarf2expr.h: Revert.
2975         * dwarf2expr.c: Revert.
2976         * dwarf2-frame.c: Revert.
2977         * dwarf2-frame-tailcall.c: Revert.
2978         * dwarf-index-write.h: Revert.
2979         * dwarf-index-write.c: Revert.
2980         * dwarf-index-common.c: Revert.
2981         * dwarf-index-cache.h: Revert.
2982         * dwarf-index-cache.c: Revert.
2983         * dummy-frame.c: Revert.
2984         * dtrace-probe.c: Revert.
2985         * disasm.h: Revert.
2986         * disasm.c: Revert.
2987         * disasm-selftests.c: Revert.
2988         * dictionary.c: Revert.
2989         * dicos-tdep.c: Revert.
2990         * demangle.c: Revert.
2991         * dcache.h: Revert.
2992         * dcache.c: Revert.
2993         * darwin-nat.h: Revert.
2994         * darwin-nat.c: Revert.
2995         * darwin-nat-info.c: Revert.
2996         * d-valprint.c: Revert.
2997         * d-namespace.c: Revert.
2998         * d-lang.c: Revert.
2999         * ctf.c: Revert.
3000         * csky-tdep.c: Revert.
3001         * csky-linux-tdep.c: Revert.
3002         * cris-tdep.c: Revert.
3003         * cris-linux-tdep.c: Revert.
3004         * cp-valprint.c: Revert.
3005         * cp-support.c: Revert.
3006         * cp-namespace.c: Revert.
3007         * cp-abi.c: Revert.
3008         * corelow.c: Revert.
3009         * corefile.c: Revert.
3010         * continuations.c: Revert.
3011         * completer.h: Revert.
3012         * completer.c: Revert.
3013         * complaints.c: Revert.
3014         * coffread.c: Revert.
3015         * coff-pe-read.c: Revert.
3016         * cli-out.h: Revert.
3017         * cli-out.c: Revert.
3018         * charset.c: Revert.
3019         * c-varobj.c: Revert.
3020         * c-valprint.c: Revert.
3021         * c-typeprint.c: Revert.
3022         * c-lang.c: Revert.
3023         * buildsym.c: Revert.
3024         * buildsym-legacy.c: Revert.
3025         * build-id.h: Revert.
3026         * build-id.c: Revert.
3027         * btrace.c: Revert.
3028         * bsd-uthread.c: Revert.
3029         * breakpoint.h: Revert.
3030         * breakpoint.c: Revert.
3031         * break-catch-throw.c: Revert.
3032         * break-catch-syscall.c: Revert.
3033         * break-catch-sig.c: Revert.
3034         * blockframe.c: Revert.
3035         * block.c: Revert.
3036         * bfin-tdep.c: Revert.
3037         * bfin-linux-tdep.c: Revert.
3038         * bfd-target.c: Revert.
3039         * bcache.c: Revert.
3040         * ax-general.c: Revert.
3041         * ax-gdb.h: Revert.
3042         * ax-gdb.c: Revert.
3043         * avr-tdep.c: Revert.
3044         * auxv.c: Revert.
3045         * auto-load.c: Revert.
3046         * arm-wince-tdep.c: Revert.
3047         * arm-tdep.c: Revert.
3048         * arm-symbian-tdep.c: Revert.
3049         * arm-pikeos-tdep.c: Revert.
3050         * arm-obsd-tdep.c: Revert.
3051         * arm-nbsd-tdep.c: Revert.
3052         * arm-nbsd-nat.c: Revert.
3053         * arm-linux-tdep.c: Revert.
3054         * arm-linux-nat.c: Revert.
3055         * arm-fbsd-tdep.c: Revert.
3056         * arm-fbsd-nat.c: Revert.
3057         * arm-bsd-tdep.c: Revert.
3058         * arch-utils.c: Revert.
3059         * arc-tdep.c: Revert.
3060         * arc-newlib-tdep.c: Revert.
3061         * annotate.h: Revert.
3062         * annotate.c: Revert.
3063         * amd64-windows-tdep.c: Revert.
3064         * amd64-windows-nat.c: Revert.
3065         * amd64-tdep.c: Revert.
3066         * amd64-sol2-tdep.c: Revert.
3067         * amd64-obsd-tdep.c: Revert.
3068         * amd64-obsd-nat.c: Revert.
3069         * amd64-nbsd-tdep.c: Revert.
3070         * amd64-nbsd-nat.c: Revert.
3071         * amd64-nat.c: Revert.
3072         * amd64-linux-tdep.c: Revert.
3073         * amd64-linux-nat.c: Revert.
3074         * amd64-fbsd-tdep.c: Revert.
3075         * amd64-fbsd-nat.c: Revert.
3076         * amd64-dicos-tdep.c: Revert.
3077         * amd64-darwin-tdep.c: Revert.
3078         * amd64-bsd-nat.c: Revert.
3079         * alpha-tdep.c: Revert.
3080         * alpha-obsd-tdep.c: Revert.
3081         * alpha-nbsd-tdep.c: Revert.
3082         * alpha-mdebug-tdep.c: Revert.
3083         * alpha-linux-tdep.c: Revert.
3084         * alpha-linux-nat.c: Revert.
3085         * alpha-bsd-tdep.c: Revert.
3086         * alpha-bsd-nat.c: Revert.
3087         * aix-thread.c: Revert.
3088         * agent.c: Revert.
3089         * addrmap.c: Revert.
3090         * ada-varobj.c: Revert.
3091         * ada-valprint.c: Revert.
3092         * ada-typeprint.c: Revert.
3093         * ada-tasks.c: Revert.
3094         * ada-lang.c: Revert.
3095         * aarch64-tdep.c: Revert.
3096         * aarch64-ravenscar-thread.c: Revert.
3097         * aarch64-newlib-tdep.c: Revert.
3098         * aarch64-linux-tdep.c: Revert.
3099         * aarch64-linux-nat.c: Revert.
3100         * aarch64-fbsd-tdep.c: Revert.
3101         * aarch64-fbsd-nat.c: Revert.
3102         * aarch32-linux-nat.c: Revert.
3103
3104 2019-04-05  Tom Tromey  <tom@tromey.com>
3105
3106         * ft32-tdep.c: Sort headers.
3107         * frv-tdep.c: Sort headers.
3108         * frv-linux-tdep.c: Sort headers.
3109         * frame.c: Sort headers.
3110         * frame-unwind.c: Sort headers.
3111         * frame-base.c: Sort headers.
3112         * fork-child.c: Sort headers.
3113         * findvar.c: Sort headers.
3114         * findcmd.c: Sort headers.
3115         * filesystem.c: Sort headers.
3116         * filename-seen-cache.h: Sort headers.
3117         * filename-seen-cache.c: Sort headers.
3118         * fbsd-tdep.c: Sort headers.
3119         * fbsd-nat.h: Sort headers.
3120         * fbsd-nat.c: Sort headers.
3121         * f-valprint.c: Sort headers.
3122         * f-typeprint.c: Sort headers.
3123         * f-lang.c: Sort headers.
3124         * extension.h: Sort headers.
3125         * extension.c: Sort headers.
3126         * extension-priv.h: Sort headers.
3127         * expprint.c: Sort headers.
3128         * exec.h: Sort headers.
3129         * exec.c: Sort headers.
3130         * exceptions.c: Sort headers.
3131         * event-top.c: Sort headers.
3132         * event-loop.c: Sort headers.
3133         * eval.c: Sort headers.
3134         * elfread.c: Sort headers.
3135         * dwarf2read.h: Sort headers.
3136         * dwarf2read.c: Sort headers.
3137         * dwarf2loc.c: Sort headers.
3138         * dwarf2expr.h: Sort headers.
3139         * dwarf2expr.c: Sort headers.
3140         * dwarf2-frame.c: Sort headers.
3141         * dwarf2-frame-tailcall.c: Sort headers.
3142         * dwarf-index-write.h: Sort headers.
3143         * dwarf-index-write.c: Sort headers.
3144         * dwarf-index-common.c: Sort headers.
3145         * dwarf-index-cache.h: Sort headers.
3146         * dwarf-index-cache.c: Sort headers.
3147         * dummy-frame.c: Sort headers.
3148         * dtrace-probe.c: Sort headers.
3149         * disasm.h: Sort headers.
3150         * disasm.c: Sort headers.
3151         * disasm-selftests.c: Sort headers.
3152         * dictionary.c: Sort headers.
3153         * dicos-tdep.c: Sort headers.
3154         * demangle.c: Sort headers.
3155         * dcache.h: Sort headers.
3156         * dcache.c: Sort headers.
3157         * darwin-nat.h: Sort headers.
3158         * darwin-nat.c: Sort headers.
3159         * darwin-nat-info.c: Sort headers.
3160         * d-valprint.c: Sort headers.
3161         * d-namespace.c: Sort headers.
3162         * d-lang.c: Sort headers.
3163         * ctf.c: Sort headers.
3164         * csky-tdep.c: Sort headers.
3165         * csky-linux-tdep.c: Sort headers.
3166         * cris-tdep.c: Sort headers.
3167         * cris-linux-tdep.c: Sort headers.
3168         * cp-valprint.c: Sort headers.
3169         * cp-support.c: Sort headers.
3170         * cp-namespace.c: Sort headers.
3171         * cp-abi.c: Sort headers.
3172         * corelow.c: Sort headers.
3173         * corefile.c: Sort headers.
3174         * continuations.c: Sort headers.
3175         * completer.h: Sort headers.
3176         * completer.c: Sort headers.
3177         * complaints.c: Sort headers.
3178         * coffread.c: Sort headers.
3179         * coff-pe-read.c: Sort headers.
3180         * cli-out.h: Sort headers.
3181         * cli-out.c: Sort headers.
3182         * charset.c: Sort headers.
3183         * c-varobj.c: Sort headers.
3184         * c-valprint.c: Sort headers.
3185         * c-typeprint.c: Sort headers.
3186         * c-lang.c: Sort headers.
3187         * buildsym.c: Sort headers.
3188         * buildsym-legacy.c: Sort headers.
3189         * build-id.h: Sort headers.
3190         * build-id.c: Sort headers.
3191         * btrace.c: Sort headers.
3192         * bsd-uthread.c: Sort headers.
3193         * breakpoint.h: Sort headers.
3194         * breakpoint.c: Sort headers.
3195         * break-catch-throw.c: Sort headers.
3196         * break-catch-syscall.c: Sort headers.
3197         * break-catch-sig.c: Sort headers.
3198         * blockframe.c: Sort headers.
3199         * block.c: Sort headers.
3200         * bfin-tdep.c: Sort headers.
3201         * bfin-linux-tdep.c: Sort headers.
3202         * bfd-target.c: Sort headers.
3203         * bcache.c: Sort headers.
3204         * ax-general.c: Sort headers.
3205         * ax-gdb.h: Sort headers.
3206         * ax-gdb.c: Sort headers.
3207         * avr-tdep.c: Sort headers.
3208         * auxv.c: Sort headers.
3209         * auto-load.c: Sort headers.
3210         * arm-wince-tdep.c: Sort headers.
3211         * arm-tdep.c: Sort headers.
3212         * arm-symbian-tdep.c: Sort headers.
3213         * arm-pikeos-tdep.c: Sort headers.
3214         * arm-obsd-tdep.c: Sort headers.
3215         * arm-nbsd-tdep.c: Sort headers.
3216         * arm-nbsd-nat.c: Sort headers.
3217         * arm-linux-tdep.c: Sort headers.
3218         * arm-linux-nat.c: Sort headers.
3219         * arm-fbsd-tdep.c: Sort headers.
3220         * arm-fbsd-nat.c: Sort headers.
3221         * arm-bsd-tdep.c: Sort headers.
3222         * arch-utils.c: Sort headers.
3223         * arc-tdep.c: Sort headers.
3224         * arc-newlib-tdep.c: Sort headers.
3225         * annotate.h: Sort headers.
3226         * annotate.c: Sort headers.
3227         * amd64-windows-tdep.c: Sort headers.
3228         * amd64-windows-nat.c: Sort headers.
3229         * amd64-tdep.c: Sort headers.
3230         * amd64-sol2-tdep.c: Sort headers.
3231         * amd64-obsd-tdep.c: Sort headers.
3232         * amd64-obsd-nat.c: Sort headers.
3233         * amd64-nbsd-tdep.c: Sort headers.
3234         * amd64-nbsd-nat.c: Sort headers.
3235         * amd64-nat.c: Sort headers.
3236         * amd64-linux-tdep.c: Sort headers.
3237         * amd64-linux-nat.c: Sort headers.
3238         * amd64-fbsd-tdep.c: Sort headers.
3239         * amd64-fbsd-nat.c: Sort headers.
3240         * amd64-dicos-tdep.c: Sort headers.
3241         * amd64-darwin-tdep.c: Sort headers.
3242         * amd64-bsd-nat.c: Sort headers.
3243         * alpha-tdep.c: Sort headers.
3244         * alpha-obsd-tdep.c: Sort headers.
3245         * alpha-nbsd-tdep.c: Sort headers.
3246         * alpha-mdebug-tdep.c: Sort headers.
3247         * alpha-linux-tdep.c: Sort headers.
3248         * alpha-linux-nat.c: Sort headers.
3249         * alpha-bsd-tdep.c: Sort headers.
3250         * alpha-bsd-nat.c: Sort headers.
3251         * aix-thread.c: Sort headers.
3252         * agent.c: Sort headers.
3253         * addrmap.c: Sort headers.
3254         * ada-varobj.c: Sort headers.
3255         * ada-valprint.c: Sort headers.
3256         * ada-typeprint.c: Sort headers.
3257         * ada-tasks.c: Sort headers.
3258         * ada-lang.c: Sort headers.
3259         * aarch64-tdep.c: Sort headers.
3260         * aarch64-ravenscar-thread.c: Sort headers.
3261         * aarch64-newlib-tdep.c: Sort headers.
3262         * aarch64-linux-tdep.c: Sort headers.
3263         * aarch64-linux-nat.c: Sort headers.
3264         * aarch64-fbsd-tdep.c: Sort headers.
3265         * aarch64-fbsd-nat.c: Sort headers.
3266         * aarch32-linux-nat.c: Sort headers.
3267
3268 2019-04-04  Tom Tromey  <tom@tromey.com>
3269
3270         * varobj.c (varobj_create): Update.
3271         * rust-exp.y (struct rust_parser) <update_innermost_block,
3272         lookup_symbol>: New methods.
3273         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3274         Rename.
3275         (rust_parser::rust_lookup_type)
3276         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3277         * printcmd.c (display_command, do_one_display): Update.
3278         * parser-defs.h (struct parser_state) <parser_state>: Add
3279         "tracker" parameter.
3280         (block_tracker): New member.
3281         (class innermost_block_tracker) <innermost_block_tracker>: Add
3282         "types" parameter.
3283         <reset>: Remove method.
3284         (innermost_block): Don't declare.
3285         (null_post_parser): Update.
3286         * parse.c (innermost_block): Remove global.
3287         (write_dollar_variable): Update.
3288         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3289         Remove "tracker_types" parameter.
3290         (parse_expression): Add "tracker" parameter.
3291         (parse_expression_for_completion): Update.
3292         (null_post_parser): Add "tracker" parameter.
3293         * p-exp.y: Update rules.
3294         * m2-exp.y: Update rules.
3295         * language.h (struct language_defn) <la_post_parser>: Add
3296         "tracker" parameter.
3297         * go-exp.y: Update rules.
3298         * f-exp.y: Update rules.
3299         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3300         parameter.
3301         * d-exp.y: Update rules.
3302         * c-exp.y: Update rules.
3303         * breakpoint.c (set_breakpoint_condition): Create an
3304         innermost_block_tracker.
3305         (watch_command_1): Likewise.
3306         * ada-lang.c (resolve): Add "tracker" parameter.
3307         (resolve_subexp): Likewise.
3308         * ada-exp.y (write_var_from_sym): Update.
3309
3310 2019-04-04  Tom Tromey  <tom@tromey.com>
3311
3312         * type-stack.h: New file.
3313         * type-stack.c: New file.
3314         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3315         type-stack.h.
3316         (insert_into_type_stack, insert_type, push_type, push_type_int)
3317         (insert_type_address_space, pop_type, pop_type_int)
3318         (pop_typelist, pop_type_stack, append_type_stack)
3319         (push_type_stack, get_type_stack, push_typelist)
3320         (follow_type_instance_flags, follow_types): Don't declare.
3321         * parse.c (type_stack): Remove global.
3322         (parse_exp_in_context): Update.
3323         (insert_into_type_stack, insert_type, push_type, push_type_int)
3324         (insert_type_address_space, pop_type, pop_type_int)
3325         (pop_typelist, pop_type_stack, append_type_stack)
3326         (push_type_stack, get_type_stack, push_typelist)
3327         (follow_type_instance_flags, follow_types): Remove (moved to
3328         type-stack.c).
3329         * f-exp.y (type_stack): New global.
3330         Update rules.
3331         (push_kind_type, f_parse): Update.
3332         * d-exp.y (type_stack): New global.
3333         Update rules.
3334         (d_parse): Update.
3335         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3336         Update rules.
3337         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3338         (HFILES_NO_SRCDIR): Add type-stack.h.
3339
3340 2019-04-04  Tom Tromey  <tom@tromey.com>
3341
3342         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3343         (rust_parser::convert_ast_to_expression, rust_parse)
3344         (rust_lex_test_completion, rust_lex_tests): Update.
3345         * parser-defs.h (struct expr_completion_state): New.
3346         (struct parser_state) <parser_state>: Add completion parameter.
3347         <mark_struct_expression, mark_completion_tag>: New methods.
3348         <parse_completion, m_completion_state>: New members.
3349         (prefixify_expression, null_post_parser): Update.
3350         (mark_struct_expression, mark_completion_tag): Don't declare.
3351         * parse.c (parse_completion, expout_last_struct)
3352         (expout_tag_completion_type, expout_completion_name): Remove
3353         globals.
3354         (parser_state::mark_struct_expression)
3355         (parser_state::mark_completion_tag): Now methods.
3356         (prefixify_expression): Add last_struct parameter.
3357         (prefixify_subexp): Likewise.
3358         (parse_exp_1): Update.
3359         (parse_exp_in_context): Add cstate parameter.  Update.
3360         (parse_expression_for_completion): Create an
3361         expr_completion_state.
3362         (null_post_parser): Add "completion" parameter.
3363         * p-exp.y: Update rules.
3364         (yylex): Update.
3365         * language.h (struct language_defn) <la_post_parser>: Add
3366         "completing" parameter.
3367         * go-exp.y: Update rules.
3368         (lex_one_token): Update.
3369         * expression.h (parse_completion): Don't declare.
3370         * d-exp.y: Update rules.
3371         (lex_one_token): Update rules.
3372         * c-exp.y: Update rules.
3373         (lex_one_token): Update.
3374         * ada-lang.c (resolve): Add "parse_completion" parameter.
3375         (resolve_subexp): Likewise.
3376         (ada_resolve_function): Likewise.
3377
3378 2019-04-04  Tom Tromey  <tom@tromey.com>
3379
3380         * parser-defs.h (struct parser_state) <start_arglist,
3381         end_arglist>: New methods.
3382         <arglist_len, m_funcall_chain>: New members.
3383         (arglist_len, start_arglist, end_arglist): Don't declare.
3384         * parse.c (arglist_len, funcall_chain): Remove global.
3385         (start_arglist, end_arglist): Remove functions.
3386         (parse_exp_in_context): Update.
3387         * p-exp.y: Update rules.
3388         * m2-exp.y: Update rules.
3389         * go-exp.y: Update rules.
3390         * f-exp.y: Update rules.
3391         * d-exp.y: Update rules.
3392         * c-exp.y: Update rules.
3393
3394 2019-04-04  Tom Tromey  <tom@tromey.com>
3395
3396         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3397         lex_operator, push_back>: New methods.
3398         Update all rules.
3399         (rust_parser::lex_hex, lex_escape): Rename and update.
3400         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3401         (rust_parser::lex_operator): Rename and update.
3402         (rust_parser::lex_number, rustyylex, rustyyerror)
3403         (rust_lex_test_init, rust_lex_test_sequence)
3404         (rust_lex_test_push_back, rust_lex_tests): Update.
3405         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3406         parameter.
3407         <lexptr, prev_lexptr>: New members.
3408         (lexptr, prev_lexptr): Don't declare.
3409         * parse.c (lexptr, prev_lexptr): Remove globals.
3410         (parse_exp_in_context): Update.
3411         * p-exp.y (yylex, yyerror): Update.
3412         * m2-exp.y (parse_number, yylex, yyerror): Update.
3413         * go-exp.y (lex_one_token, yyerror): Update.
3414         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3415         * d-exp.y (lex_one_token, yyerror): Update.
3416         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3417         (lex_one_token, yyerror): Update.
3418         * ada-lex.l (YY_INPUT): Update.
3419         (rewind_to_char): Update.
3420         * ada-exp.y (yyerror): Update.
3421
3422 2019-04-04  Tom Tromey  <tom@tromey.com>
3423
3424         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3425         * parser-defs.h (struct parser_state) <parser_state>: Add new
3426         parameter.
3427         <comma_terminates>: New member.
3428         (comma_terminates): Don't declare global.
3429         * parse.c (comma_terminates): Remove global.
3430         (parse_exp_in_context): Update.
3431         * p-exp.y (yylex): Update.
3432         * m2-exp.y (yylex): Update.
3433         * go-exp.y (lex_one_token): Update.
3434         * f-exp.y (yylex): Update.
3435         * d-exp.y (lex_one_token): Update.
3436         * c-exp.y (lex_one_token): Update.
3437         * ada-lex.l: Update.
3438
3439 2019-04-04  Tom Tromey  <tom@tromey.com>
3440
3441         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3442         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3443         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3444         * parser-defs.h (paren_depth): Don't declare.
3445         * parse.c (paren_depth): Remove global.
3446         (parse_exp_in_context): Update.
3447         * p-exp.y (paren_depth): New global.
3448         (pascal_parse): Initialize it.
3449         * m2-exp.y (paren_depth): New global.
3450         (m2_parse): Initialize it.
3451         * go-exp.y (paren_depth): New global.
3452         (go_parse): Initialize it.
3453         * f-exp.y (paren_depth): New global.
3454         (f_parse): Initialize it.
3455         * d-exp.y (paren_depth): New global.
3456         (d_parse): Initialize it.
3457         * c-exp.y (paren_depth): New global.
3458         (c_parse): Initialize it.
3459         * ada-lex.l (paren_depth): New global.
3460         (lexer_init): Initialize it.
3461
3462 2019-04-04  Tom Tromey  <tom@tromey.com>
3463
3464         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3465         (rust_parser::convert_ast_to_type)
3466         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3467         * parser-defs.h (struct parser_state) <parser_state>: Add
3468         parameters.  Initialize new members.
3469         <expression_context_block, expression_context_pc>: New members.
3470         * parse.c (expression_context_block, expression_context_pc):
3471         Remove globals.
3472         (parse_exp_in_context): Update.
3473         * p-exp.y: Update all rules.
3474         (yylex): Update.
3475         * m2-exp.y: Update all rules.
3476         (yylex): Update.
3477         * go-exp.y (yylex): Update.
3478         * f-exp.y (yylex): Update.
3479         * d-exp.y: Update all rules.
3480         (yylex): Update.
3481         * c-exp.y: Update all rules.
3482         (lex_one_token, classify_name, yylex, c_parse): Update.
3483         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3484
3485 2019-04-04  Tom Tromey  <tom@tromey.com>
3486
3487         * gdbarch.h, gdbarch.c: Rebuild.
3488         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3489         * stap-probe.h:
3490         (struct stap_parse_info): Replace "parser_state" with
3491         "expr_builder".
3492         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3493         (parser_state): New class.
3494         * parse.c (expr_builder): Rename.
3495         (expr_builder::release): Rename.
3496         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3497         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3498         (write_exp_elt_longcst, write_exp_elt_floatcst)
3499         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3500         (write_exp_string_vector, write_exp_bitstring)
3501         (write_exp_msymbol, mark_struct_expression)
3502         (write_dollar_variable)
3503         (insert_type_address_space, increase_expout_size): Replace
3504         "parser_state" with "expr_builder".
3505         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3506         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3507         "parser_state" with "expr_builder".
3508
3509 2019-04-04  Tom Tromey  <tom@tromey.com>
3510
3511         * rust-exp.y: Replace "parse_language" with method call.
3512         * p-exp.y:
3513         (yylex): Replace "parse_language" with method call.
3514         * m2-exp.y:
3515         (yylex): Replace "parse_language" with method call.
3516         * go-exp.y (classify_name): Replace "parse_language" with method
3517         call.
3518         * f-exp.y (yylex): Replace "parse_language" with method call.
3519         * d-exp.y (lex_one_token): Replace "parse_language" with method
3520         call.
3521         * c-exp.y:
3522         (lex_one_token, classify_name, yylex): Replace "parse_language"
3523         with method call.
3524         * ada-exp.y (find_primitive_type, type_char)
3525         (type_system_address): Replace "parse_language" with method call.
3526
3527 2019-04-04  Tom Tromey  <tom@tromey.com>
3528
3529         * rust-exp.y: Replace "parse_gdbarch" with method call.
3530         * parse.c (write_dollar_variable, insert_type_address_space):
3531         Replace "parse_gdbarch" with method call.
3532         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3533         call.
3534         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3535         call.
3536         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3537         "parse_gdbarch" with method call.
3538         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3539         with method call.
3540         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3541         "parse_gdbarch" with method call.
3542         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3543         "parse_gdbarch" with method call.
3544         * c-exp.y (parse_type, parse_number, classify_name): Replace
3545         "parse_gdbarch" with method call.
3546         * ada-lex.l: Replace "parse_gdbarch" with method call.
3547         * ada-exp.y (parse_type, find_primitive_type, type_char)
3548         (type_system_address): Replace "parse_gdbarch" with method call.
3549
3550 2019-04-04  Tom Tromey  <tom@tromey.com>
3551
3552         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3553         * stap-probe.c (stap_parse_argument): Update.
3554         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3555         initial_size parameter.
3556         * rust-exp.y (rust_lex_tests): Update.
3557         * parse.c (parser_state): Update.
3558         (parse_exp_in_context): Update.
3559         * parser-defs.h (struct parser_state) <parser_state>: Remove
3560         "initial_size" parameter.
3561
3562 2019-04-04  Tom Tromey  <tom@tromey.com>
3563
3564         * parser-defs.h (increase_expout_size): Don't declare.
3565         * parse.c (increase_expout_size): Now static.
3566
3567 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3568
3569         * gnu-nat.c (gnu_nat_target::wait): Fix
3570         target_waitstatus_to_string call.
3571
3572 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * eval.c (evaluate_subexp_standard): Handle internal functions
3575         during Fortran function call handling.
3576
3577 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * NEWS: Mention new internal functions.
3580         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3581         (read_base_type): Use dwarf2_init_complex_target_type.
3582         * value.c (creal_internal_fn): New function.
3583         (cimag_internal_fn): New function.
3584         (_initialize_values): Register new internal functions.
3585
3586 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3587
3588         * infrun.c (stop_all_threads): If debug_infrun, always
3589         trace the wait status after wait_one, using
3590         target_waitstatus_to_string and target_pid_to_str.
3591         (handle_inferior_event): Replace various trace of
3592         wait status kind by a single trace.
3593         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3594         wait status kind image by target_waitstatus_to_string.
3595         * target/waitstatus.c (target_waitstatus_to_string): Fix
3596         obsolete comment.
3597
3598 2019-04-01  Tom Tromey  <tromey@adacore.com>
3599
3600         PR symtab/23331:
3601         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3602
3603 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3604             Pedro Alves  <palves@redhat.com>
3605
3606         * top.c (quit_force): Call 'finalize_values'.
3607         * value.c (finalize_values): New function.
3608         * value.h (finalize_values): Declare.
3609
3610 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3611
3612         * NEWS: Announce $_gdb_major and $_gdb_minor.
3613
3614         * top.c (init_gdb_version_vars): New function.
3615         (gdb_init): Call init_gdb_version_vars.
3616
3617 2019-03-29  Tom Tromey  <tromey@adacore.com>
3618
3619         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3620         help text.  Remove dead code.
3621
3622 2019-03-29  Keith Seitz  <keiths@redhat.com>
3623
3624         From Siddhesh Poyarekar:
3625         * f-lang.h (f77_get_upperbound): Return LONGEST.
3626         (f77_get_lowerbound): Likewise.
3627         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3628         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3629         print them.
3630         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3631         plongest to format print it.
3632         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3633         (f77_get_upperbound): Likewise.
3634         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3635         LOWER_BOUND to LONGEST.
3636         (f77_create_arrayprint_offset_tbl): Likewise.
3637
3638 2019-03-29  Keith Seitz  <keiths@redhat.com>
3639
3640         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3641         %s/pulongest for TYPE_LENGTH instead of %d in format
3642         strings.
3643         * ada-typerint.c (ada_print_type): Likewise.
3644         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3645         * compile/compile-c-support.c (generate_register_struct): Likewise.
3646         * gdbtypes.c (recursive_dump_type): Likewise.
3647         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3648         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3649         instead of %d in format strings.
3650         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3651         to std::min to ULONGEST.
3652         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3653         instead of %d in format strings.
3654         * tracepoint.c (info_scope_command): Likewise.
3655         * typeprint.c (print_offset_data::update)
3656         (print_offset_data::finish): Likewise.
3657         * xtensa-tdep.c (xtensa_store_return_value)
3658         (xtensa_push_dummy_call): Likewise.
3659
3660 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3661
3662         * windows-nat.c (display_selector): Fixed format specifications
3663         for 64-bit Cygwin.
3664
3665 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3666
3667         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3668
3669 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3670
3671         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3672         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3673         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3674         (nios2_linux_init_abi): Install it.
3675
3676 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3677
3678         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3679
3680 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3681
3682         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3683
3684 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3685             Tom Tromey  <tromey@adacore.com>
3686
3687         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3688
3689 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3690
3691         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3692         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3693         method to compute the bounds of range types. Also print "[evaluated]"
3694         if the bounds' values come from a dynamic evaluation.
3695
3696 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3699         whitespace when pretty printing is on.
3700
3701 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3702
3703         * ppc-linux-nat.c: Add include.
3704
3705 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3706
3707         * NEWS: Mention AArch64 Pointer Authentication.
3708
3709 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3710
3711         * arm-linux-nat.c: Add include.
3712
3713 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3714
3715         * source-cache.c (source_cache::get_source_lines): Re-read
3716         fullname after calling open_source_file.
3717
3718 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3719
3720         * NEWS: Mention TLS support for FreeBSD.
3721
3722 2019-03-25  Tom Tromey  <tromey@adacore.com>
3723
3724         * minsyms.c (BUNCH_SIZE): Update comment.
3725         (~minimal_symbol_reader): Remove old comment.
3726         (compact_minimal_symbols): Update comment.
3727         (minimal_symbol_reader::install): Remove old comment.  Update
3728         other comments.
3729
3730 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3731
3732         * s390-linux-nat.c: Add include.
3733
3734 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3735
3736         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3737         Call linux_get_hwcap.
3738         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3739         Likewise.
3740         (aarch64_linux_get_hwcap): Remove function.
3741         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3742         declaration.
3743         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3744         linux_get_hwcap.
3745         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3746         * linux-tdep.c (linux_get_hwcap): Add function.
3747         (linux_get_hwcap2): Likewise.
3748         * linux-tdep.h (linux_get_hwcap): Add declaration.
3749         (linux_get_hwcap2): Likewise.
3750         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3751         (ppc_linux_get_hwcap2): Likewise.
3752         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3753         linux_get_hwcap.
3754         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3755         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3756         (ppc_linux_nat_target::read_description): Likewise.
3757         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3758         * s390-linux-nat.c: Likewise.
3759         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3760
3761 2019-03-24  Tom Tromey  <tom@tromey.com>
3762
3763         * ada-lang.c (standard_lookup): Simplify initialization.
3764         (ada_lookup_symbol_nonlocal): Simplify return.
3765         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3766         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3767         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3768         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3769         initialization.
3770         * solib.c (solib_global_lookup): Simplify.
3771         * symtab.c (null_block_symbol): Remove.
3772         (symbol_cache_lookup): Simplify returns.
3773         (lookup_language_this): Simplify returns.
3774         (lookup_symbol_aux): Simplify return.
3775         (lookup_local_symbol): Simplify returns.
3776         (lookup_global_symbol_from_objfile): Simplify return.
3777         (lookup_symbol_in_objfile_symtabs)
3778         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3779         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3780         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3781         * cp-namespace.c (cp_lookup_bare_symbol)
3782         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3783         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3784         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3785         (cp_lookup_symbol_via_imports): Simplify initialization.
3786         (find_symbol_in_baseclass): Likewise.
3787         * symtab.h (null_block_symbol): Remove.
3788         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3789         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3790         (d_lookup_symbol_module): Likewise.
3791         (find_symbol_in_baseclass): Simplify initialization.
3792
3793 2019-03-24  Tom Tromey  <tom@tromey.com>
3794
3795         * expression.h: Don't include symtab.h.
3796         (struct block): Forward declare.
3797
3798 2019-03-24  Tom Tromey  <tom@tromey.com>
3799
3800         * c-exp.y (typebase): Remove casts.
3801         * gdbtypes.c (lookup_unsigned_typename, )
3802         (lookup_signed_typename): Remove cast.
3803         * eval.c (parse_to_comma_and_eval): Remove cast.
3804         * parse.c (write_dollar_variable): Remove cast.
3805         * block.h (struct block) <superblock>: Now const.
3806         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3807         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3808         (map_block): Make "block" const.
3809         * symfile.h (struct quick_symbol_functions)
3810         <map_matching_symbols>: Constify block argument to "callback".
3811         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3812         const.
3813         (find_pc_sect_compunit_symtab): Make "b" const.
3814         (find_symbol_at_address): Likewise.
3815         (search_symbols): Likewise.
3816         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3817         (dw2_debug_names_lookup_symbol): Likewise.
3818         (dw2_map_matching_symbols): Update.
3819         * p-valprint.c (pascal_val_print): Remove "block".
3820         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3821         (aux_add_nonlocal_symbols): Make "block" const.
3822         (resolve_subexp): Remove cast.
3823         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3824         const.
3825         (iterate_over_file_blocks): Likewise.
3826         * f-exp.y (%union) <bval>: Remove.
3827         * coffread.c (patch_opaque_types): Make "b" const.
3828         * spu-tdep.c (spu_catch_start): Make "block" const.
3829         * c-valprint.c (print_unpacked_pointer): Remove "block".
3830         * symmisc.c (dump_symtab_1): Make "b" const.
3831         (block_depth): Make "block" const.
3832         * d-exp.y (%union) <bval>: Remove.
3833         * cp-support.h (cp_lookup_rtti_type): Update.
3834         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3835         * psymtab.c (psym_lookup_symbol): Make "block" const.
3836         (maintenance_check_psymtabs): Make "b" const.
3837         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3838         (enumerate_locals, enumerate_args): Update.
3839         * python/py-symtab.c (stpy_global_block): Make "block" const.
3840         (stpy_static_block): Likewise.
3841         * inline-frame.c (block_starting_point_at): Make "new_block"
3842         const.
3843         * block.c (find_block_in_blockvector): Make return type const.
3844         (blockvector_for_pc_sect): Make "b" const.
3845         (find_block_in_blockvector): Make "b" const.
3846
3847 2019-03-23  Tom Tromey  <tom@tromey.com>
3848
3849         * varobj.c (varobj_create): Update.
3850         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3851         * printcmd.c (display_command, do_one_display): Don't reset
3852         innermost_block.
3853         * parser-defs.h (enum innermost_block_tracker_type): Move to
3854         expression.h.
3855         (innermost_block): Update comment.
3856         * parse.c (parse_exp_1): Add tracker_types parameter.
3857         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3858         tracker_types parameter.  Reset innermost_block.
3859         (parse_exp_in_context): Remove.
3860         (parse_expression_for_completion): Update.
3861         * objfiles.c (~objfile): Don't reset expression_context_block or
3862         innermost_block.
3863         * expression.h (enum innermost_block_tracker_type): Move from
3864         parser-defs.h.
3865         (parse_exp_1): Add tracker_types parameter.
3866         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3867         reset innermost_block.
3868
3869 2019-03-23  Tom Tromey  <tom@tromey.com>
3870
3871         * objfiles.h: Include bcache.h.
3872
3873 2019-03-23  Tom Tromey  <tom@tromey.com>
3874
3875         * linespec.c (get_current_search_block): Use
3876         scoped_restore_current_language.
3877         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3878
3879 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3880             Jiong Wang  <jiong.wang@arm.com>
3881
3882         * aarch64-linux-tdep.c
3883         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3884         section.
3885         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3886
3887 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3888             Jiong Wang  <jiong.wang@arm.com>
3889
3890         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3891         instructions.
3892         (aarch64_analyze_prologue_test): Add PACIASP test.
3893         (aarch64_prologue_prev_register): Unmask PC value.
3894
3895 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3896             Jiong Wang  <jiong.wang@arm.com>
3897
3898         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3899         (aarch64_dwarf2_prev_register): Unmask PC value.
3900         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3901         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3902         DW_CFA_AARCH64_negate_ra_state.
3903         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3904
3905 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3906             Jiong Wang  <jiong.wang@arm.com>
3907
3908         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3909         registers.
3910         (aarch64_pseudo_register_name): Likewise.
3911         (aarch64_pseudo_register_type): Likewise.
3912         (aarch64_pseudo_register_reggroup_p): Likewise.
3913         (aarch64_gdbarch_init): Add pauth registers.
3914         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3915         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3916         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3917         (struct gdbarch_tdep): Add regnum for ra_state.
3918
3919 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3920             Jiong Wang  <jiong.wang@arm.com>
3921
3922         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3923
3924 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3925             Jiong Wang  <jiong.wang@arm.com>
3926
3927         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3928         function.
3929         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3930         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3931         (aarch64_gdbarch_init): Add puth registers.
3932         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3933         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3934         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3935
3936 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3937             Jiong Wang  <jiong.wang@arm.com>
3938
3939         * aarch64-linux-nat.c
3940         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3941         * aarch64-linux-tdep.c
3942         (aarch64_linux_core_read_description): Likewise.
3943         (aarch64_linux_get_hwcap): New function.
3944         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3945         (aarch64_linux_get_hwcap): New declaration.
3946
3947 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3948             Jiong Wang  <jiong.wang@arm.com>
3949
3950         * aarch64-linux-nat.c
3951         (aarch64_linux_nat_target::read_description): Add pauth param.
3952         * aarch64-linux-tdep.c
3953         (aarch64_linux_core_read_description): Likewise.
3954         * aarch64-tdep.c (struct target_desc): Add in pauth.
3955         (aarch64_read_description): Add pauth param.
3956         (aarch64_gdbarch_init): Likewise.
3957         * aarch64-tdep.h (aarch64_read_description): Likewise.
3958         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3959         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3960         * features/Makefile: Add new files.
3961         * features/aarch64-pauth.c: New file.
3962         * features/aarch64-pauth.xml: New file.
3963
3964 2019-03-20  Tom Tromey  <tromey@adacore.com>
3965
3966         * infrun.c (handle_inferior_event): Rename from
3967         handle_inferior_event_1.  Create a scoped_value_mark.
3968         (handle_inferior_event): Remove.
3969
3970 2019-03-19  Tom Tromey  <tromey@adacore.com>
3971
3972         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3973         * infrun.h (print_stop_event): Add "displays" parameter.
3974         * infrun.c (print_stop_event): Add "displays" parameter.
3975
3976 2019-03-19  Pedro Alves  <palves@redhat.com>
3977
3978         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3979         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3980         to -1.  Fix TABs vs spaces.
3981         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3982         * tui/tui-out.h (tui_ui_out) Add intro comments.
3983         <m_line, m_start_of_line>: In-class initialize, and add describing
3984         comment.
3985
3986 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3987
3988         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3989         variable names.
3990         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3991
3992 2019-03-18  Pedro Alves  <palves@redhat.com>
3993             Eli Zaretskii <eliz@gnu.org>
3994
3995         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3996         m_line and m_start_of_line.
3997
3998 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3999
4000         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4001         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4002         it returns a newline.  This fixes a regression in TU mode, whereby
4003         the next line is output on the same screen line as the user input.
4004
4005 2019-03-18  Tom Tromey  <tromey@adacore.com>
4006
4007         * minsyms.c (minimal_symbol_reader::install): Remove call to
4008         obstack_blank.
4009
4010 2019-03-18  Pedro Alves  <palves@redhat.com>
4011
4012         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4013         New globals.
4014         (apply_style): New, factored out from ...
4015         (apply_ansi_escape): ... this.  Handle reverse video mode.
4016         (tui_set_reverse_mode): New function.
4017         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4018         * tui/tui-winsource.c (tui_show_source_line): Use
4019         tui_set_reverse_mode instead of setting A_STANDOUT.
4020         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4021         New setter methods.
4022
4023 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4024
4025         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4026         Handle tabs.
4027
4028 2019-03-18  Tom Tromey  <tromey@adacore.com>
4029
4030         * ada-lang.c (empty_array): Add "high" parameter.
4031         (ada_evaluate_subexp): Update.
4032
4033 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4034
4035         * unittests/string_view-selftests.c: Define
4036         _initialize_string_view_selftests unconditionally.
4037
4038 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4039
4040         PR gdb/24350
4041         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4042
4043 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4044
4045         PR gdb/24351
4046         * windows-nat.c (display_selector): Fix format specifiers.
4047
4048 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4049
4050         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4051         tui_refill_source_window instead of tui_refresh_win, to update the
4052         current execution line.  This fixes redisplay of the current line
4053         when stepping through the code with "next" or "step".
4054
4055 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4056
4057         * source-cache.c (source_cache::get_source_lines): Call
4058         find_source_lines to initialize s->nlines.  This fixes vertical
4059         scrolling of TUI source window when the DOWN arrow is pressed.
4060
4061 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4062
4063         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4064         linux-thread-db.c (_initialize_thread_db): Likewise.
4065
4066 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4067
4068         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4069         wclrtoeol in tui_show_source_line".  This reverts changes made in
4070         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4071
4072 2019-03-15  Tom Tromey  <tom@tromey.com>
4073
4074         * symtab.h (struct minimal_symbol): Derive from
4075         general_symbol_info.
4076         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4077         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4078         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4079         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4080         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4081         (MSYMBOL_SEARCH_NAME): Update.
4082         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4083         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4084         * minsyms.c (minimal_symbol_reader::record_full): Update.
4085
4086 2019-03-15  Tom Tromey  <tom@tromey.com>
4087
4088         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4089
4090 2019-03-15  Tom Tromey  <tom@tromey.com>
4091
4092         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4093         unique_xmalloc_ptr.
4094         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4095         Update.
4096         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4097         (build_minimal_symbol_hash_tables)
4098         (minimal_symbol_reader::install): Update.
4099
4100 2019-03-15  Tom Tromey  <tom@tromey.com>
4101
4102         * symtab.c (create_demangled_names_hash): Update.
4103         (symbol_set_names): Update.
4104         * objfiles.h (struct objfile_per_bfd_storage)
4105         <demangled_names_hash>: Now an htab_up.
4106         * objfiles.c (objfile_per_bfd_storage): Simplify.
4107
4108 2019-03-15  Tom Tromey  <tom@tromey.com>
4109
4110         * objfiles.h (struct objfile_per_bfd_storage): Declare
4111         destructor.
4112         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4113         New.
4114         (get_objfile_bfd_data): Use new.  Don't initialize
4115         language_of_main.
4116         (free_objfile_per_bfd_storage): Remove.
4117         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4118
4119 2019-03-15  Tom Tromey  <tom@tromey.com>
4120
4121         * symfile.c (reread_symbols): Update.
4122         * objfiles.c (objfile::objfile): Update.
4123         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4124         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4125         comment.
4126         (minimal_symbol_reader::install): Update.
4127         (terminate_minimal_symbol_table): Remove.
4128         * jit.c (jit_object_close_impl): Update.
4129
4130 2019-03-15  Tom Tromey  <tom@tromey.com>
4131
4132         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4133         initializations.
4134
4135 2019-03-15  Tom Tromey  <tom@tromey.com>
4136
4137         * objfiles.h (struct objfile_per_bfd_storage)
4138         <demangled_hash_languages>: Now a bitset.
4139         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4140         (lookup_minimal_symbol): Update.
4141
4142 2019-03-15  Tom Tromey  <tom@tromey.com>
4143
4144         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4145         Don't return the symbol.
4146         * coffread.c (record_minimal_symbol): Use record_full.
4147
4148 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4149
4150         The MS-Windows port of ncurses fails to switch to a color pair if
4151         one or both of the colors are the implicit default colors.  This
4152         change records the default colors when TUI is initialized, and
4153         then specifies them explicitly when a color pair uses the default
4154         colors.  This allows color styling in TUI mode on MS-Windows.
4155
4156         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4157         ncurses_norm_attr.
4158         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4159         colors in ncurses_norm_attr.
4160         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4161         "none", replace it with the default color recorded in
4162         ncurses_norm_attr.
4163
4164 2019-03-14  Tom Tromey  <tromey@adacore.com>
4165
4166         * source-cache.h (class source_cache) <get_source_lines>: Return
4167         std::string.
4168         * source-cache.c (source_cache::extract_lines): Handle case where
4169         first_pos==npos.  Return std::string.
4170         (source_cache::get_source_lines): Update.
4171
4172 2019-03-14  Tom Tromey  <tromey@adacore.com>
4173
4174         * NEWS: Add item for "style sources" commands.
4175         * source-cache.c (source_cache::get_source_lines): Check
4176         source_styling.
4177         * cli/cli-style.c (source_styling): New global.
4178         (_initialize_cli_style): Add "style sources" commands.
4179         (show_style_sources): New function.
4180         * cli/cli-style.h (source_styling): Declare.
4181
4182 2019-03-14  Pedro Alves  <palves@redhat.com>
4183             Tom Tromey  <tromey@adacore.com>
4184
4185         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4186         * tui/tui-winsource.c (tui_refill_source_window): New function,
4187         from...
4188         (tui_horizontal_source_scroll): ... here.  Move some logic.
4189         * cli/cli-style.c (set_style_enabled): Notify new observable.
4190         * tui/tui-hooks.c (tui_redisplay_source): New function.
4191         (tui_attach_detach_observers): Attach or detach
4192         tui_redisplay_source.
4193         * observable.h (source_styling_changed): New observable.
4194         * observable.c: Define source_styling_changed observable.
4195
4196 2019-03-13  Tom Tromey  <tromey@adacore.com>
4197
4198         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4199         (i386_gnu_nat_target::store_registers): Update.
4200         * target-debug.h (target_debug_print_std_string): New macro.
4201         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4202         * windows-tdep.c (display_one_tib): Update.
4203         * tui/tui-stack.c (tui_make_status_line): Update.
4204         * top.c (print_inferior_quit_action): Update.
4205         * thread.c (thr_try_catch_cmd): Update.
4206         (add_thread_with_info): Update.
4207         (thread_target_id_str): Update.
4208         (thr_try_catch_cmd): Update.
4209         (thread_command): Update.
4210         (thread_find_command): Update.
4211         * record-btrace.c (record_btrace_target::info_record)
4212         (record_btrace_resume_thread, record_btrace_target::resume)
4213         (record_btrace_cancel_resume, record_btrace_step_thread)
4214         (record_btrace_target::wait, record_btrace_target::wait)
4215         (record_btrace_target::wait, record_btrace_target::stop): Update.
4216         * progspace.c (print_program_space): Update.
4217         * process-stratum-target.c
4218         (process_stratum_target::thread_address_space): Update.
4219         * linux-fork.c (linux_fork_mourn_inferior)
4220         (detach_checkpoint_command, info_checkpoints_command)
4221         (linux_fork_context): Update.
4222         (linux_fork_detach): Update.
4223         (class scoped_switch_fork_info): Update.
4224         (delete_checkpoint_command): Update.
4225         * infrun.c (follow_fork_inferior): Update.
4226         (follow_fork_inferior): Update.
4227         (proceed_after_vfork_done): Update.
4228         (handle_vfork_child_exec_or_exit): Update.
4229         (follow_exec): Update.
4230         (displaced_step_prepare_throw): Update.
4231         (displaced_step_restore): Update.
4232         (start_step_over): Update.
4233         (resume_1): Update.
4234         (clear_proceed_status_thread): Update.
4235         (proceed): Update.
4236         (print_target_wait_results): Update.
4237         (do_target_wait): Update.
4238         (context_switch): Update.
4239         (stop_all_threads): Update.
4240         (restart_threads): Update.
4241         (finish_step_over): Update.
4242         (handle_signal_stop): Update.
4243         (switch_back_to_stepped_thread): Update.
4244         (keep_going_pass_signal): Update.
4245         (print_exited_reason): Update.
4246         (normal_stop): Update.
4247         * inferior.c (inferior_pid_to_str): Change return type.
4248         (print_selected_inferior): Update.
4249         (add_inferior): Update.
4250         (detach_inferior): Update.
4251         * dummy-frame.c (fprint_dummy_frames): Update.
4252         * dcache.c (dcache_info_1): Update.
4253         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4254         (btrace_fetch, btrace_clear): Update.
4255         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4256         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4257         type.
4258         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4259         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4260         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4261         * gdbarch.c, gdbarch.h: Rebuild.
4262         * gdbarch.sh (core_pid_to_str): Change return type.
4263         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4264         return type.
4265         (windows_nat_target::pid_to_str): Change return type.
4266         (windows_delete_thread): Update.
4267         (windows_nat_target::attach): Update.
4268         (windows_nat_target::files_info): Update.
4269         * target-delegates.c: Rebuild.
4270         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4271         return type.
4272         (sol_thread_target::pid_to_str): Change return type.
4273         * remote.c (class remote_target) <pid_to_str>: Change return
4274         type.
4275         (remote_target::pid_to_str): Change return type.
4276         (extended_remote_target::attach, remote_target::remote_stop_ns)
4277         (remote_target::remote_notif_remove_queued_reply)
4278         (remote_target::push_stop_reply, remote_target::disable_btrace):
4279         Update.
4280         (extended_remote_target::attach): Update.
4281         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4282         type.
4283         (gdbsim_target::pid_to_str): Change return type.
4284         * ravenscar-thread.c (struct ravenscar_thread_target)
4285         <pid_to_str>: Change return type.
4286         (ravenscar_thread_target::pid_to_str): Change return type.
4287         * procfs.c (class procfs_target) <pid_to_str>: Change return
4288         type.
4289         (procfs_target::pid_to_str): Change return type.
4290         (procfs_target::attach): Update.
4291         (procfs_target::detach): Update.
4292         (procfs_target::fetch_registers): Update.
4293         (procfs_target::store_registers): Update.
4294         (procfs_target::wait): Update.
4295         (procfs_target::files_info): Update.
4296         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4297         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4298         return type.
4299         (nto_procfs_target::pid_to_str): Change return type.
4300         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4301         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4302         return type.
4303         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4304         (exit_lwp): Update.
4305         (attach_proc_task_lwp_callback, get_detach_signal)
4306         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4307         (linux_nat_target::resume, wait_lwp, stop_callback)
4308         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4309         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4310         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4311         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4312         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4313         type.
4314         (inf_ptrace_target::attach): Update.
4315         (inf_ptrace_target::files_info): Update.
4316         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4317         type.
4318         (go32_nat_target::pid_to_str): Change return type.
4319         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4320         (gnu_nat_target::wait): Update.
4321         (gnu_nat_target::wait): Update.
4322         (gnu_nat_target::resume): Update.
4323         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4324         (fbsd_nat_target::wait): Update.
4325         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4326         type.
4327         (darwin_nat_target::attach): Update.
4328         * corelow.c (class core_target) <pid_to_str>: Change return type.
4329         (core_target::pid_to_str): Change return type.
4330         * target.c (normal_pid_to_str): Change return type.
4331         (default_pid_to_str): Likewise.
4332         (target_pid_to_str): Change return type.
4333         (target_translate_tls_address): Update.
4334         (target_announce_detach): Update.
4335         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4336         return type.
4337         (bsd_uthread_target::pid_to_str): Change return type.
4338         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4339         type.
4340         (bsd_kvm_target::pid_to_str): Change return type.
4341         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4342         return type.
4343         (aix_thread_target::pid_to_str): Change return type.
4344         * target.h (struct target_ops) <pid_to_str>: Change return type.
4345         (target_pid_to_str, normal_pid_to_str): Likewise.
4346         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4347         type.
4348         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4349         type.
4350         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4351         return type.
4352         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4353         type.
4354         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4355         type.
4356         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4357         return type.
4358
4359 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4360
4361         * NEWS: Mention that the new default MI version is 3.  Mention
4362         changes to the output of commands and events that deal with
4363         multi-location breakpoints.
4364         * breakpoint.c: Include "mi/mi-out.h".
4365         (print_one_breakpoint): Change output syntax if using MI version
4366         >= 3.
4367         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4368         New.
4369         (mi_multi_location_breakpoint_output_fixed): New.
4370         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4371         (mi_cmd_fix_multi_location_breakpoint_output): New.
4372         (mi_multi_location_breakpoint_output_fixed): New.
4373         * mi/mi-cmds.c (mi_cmds): Register command
4374         -fix-multi-location-breakpoint-output.
4375         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4376         interpreter "mi".
4377
4378 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4379
4380         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4381         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4382         instantiate mi_ui_out based on interpreter name.
4383         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4384         * mi/mi-main.c (mi_load_progress): Likewise.
4385
4386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4387
4388         * NEWS: Combine separate "New targets" sections for 8.3.
4389
4390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4391
4392         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4393         (ppcfbsd_init_abi): Install gdbarch
4394         "fetch_tls_load_module_address" and "get_thread_local_address"
4395         methods.
4396
4397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4398
4399         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4400         (riscv_fbsd_init_abi): Install gdbarch
4401         "fetch_tls_load_module_address" and "get_thread_local_address"
4402         methods.
4403
4404 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4405
4406         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4407         (i386fbsd_init_abi): Install gdbarch
4408         "fetch_tls_load_module_address" and "get_thread_local_address"
4409         methods.
4410
4411 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4412
4413         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4414         (amd64fbsd_init_abi): Install gdbarch
4415         "fetch_tls_load_module_address" and "get_thread_local_address"
4416         methods.
4417
4418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4419
4420         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4421         (struct fbsd_pspace_data): New type.
4422         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4423         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4424         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4425         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4426         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4427
4428 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4429
4430         * gdbtypes.c (lookup_struct_elt): New function.
4431         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4432         * gdbtypes.h (struct struct_elt): New type.
4433         (lookup_struct_elt): New prototype.
4434
4435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4436
4437         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4438         remove disabled code block.
4439
4440 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4441
4442         * gdbarch.sh (get_thread_local_address): New method.
4443         * gdbarch.h, gdbarch.c: Regenerate.
4444         * target.c (target_translate_tls_address): Use
4445         gdbarch_get_thread_local_address if present instead of
4446         target::get_thread_local_address.
4447
4448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4449
4450         * target.h (target::get_thread_local_address): Update comment.
4451
4452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4453
4454         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4455         objfile->separate_debug_objfile_backlink if not NULL.
4456
4457 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4458
4459         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4460         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4461         (amd64bsd_store_inferior_registers): Likewise.
4462         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4463         Enable segment base registers.
4464         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4465         PT_GETFSBASE and PT_GETGSBASE.
4466         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4467         PT_SETGSBASE.
4468         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4469         segment base registers.
4470         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4471
4472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4473
4474         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4475         Update calls to i386_target_description to add 'segments'
4476         parameter.
4477         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4478         add segment base registers.
4479         * arch/i386.c (i386_create_target_description): Add 'segments'
4480         parameter to enable segment base registers.
4481         * arch/i386.h (i386_create_target_description): Likewise.
4482         * features/i386/32bit-segments.xml: New file.
4483         * features/i386/32bit-segments.c: Generate.
4484         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4485         call to i386_target_description to add 'segments' parameter.
4486         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4487         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4488         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4489         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4490         if feature is present.
4491         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4492         Add 'segments' parameter to call to i386_target_description.
4493         (i386_target_description): Add 'segments' parameter to enable
4494         segment base registers.
4495         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4496         to call to i386_target_description.
4497         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4498         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4499         Define I386_NUM_REGS.
4500         (i386_target_description): Add 'segments' parameter to enable
4501         segment base registers.
4502
4503 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4504
4505         PR/24325
4506         * source-cache.c: #undef open and close, to avoid unresolved
4507         externals during linking.
4508
4509 2019-03-12  Tom Tromey  <tromey@adacore.com>
4510
4511         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4512         const.  Add initializers.
4513         (_initialize_remote): Don't initialize ptid globals.
4514
4515 2019-03-12  Pedro Alves  <palves@redhat.com>
4516
4517         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4518
4519 2019-03-12  Pedro Alves  <palves@redhat.com>
4520
4521         * cp-name-parser.y (main): Remove unused 'len' variable.
4522
4523 2019-03-12  Tom Tromey  <tromey@adacore.com>
4524
4525         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4526         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4527
4528 2019-03-12  Tom Tromey  <tromey@adacore.com>
4529
4530         * linux-nat.c (iterate_over_lwps): Update.
4531         (stop_callback): Remove parameter.
4532         (stop_wait_callback, detach_callback, resume_set_callback)
4533         (select_singlestep_lwp_callback, set_ignore_sigint)
4534         (status_callback, resumed_callback, resume_clear_callback)
4535         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4536         data parameter.
4537         (linux_nat_target::detach, linux_nat_target::resume)
4538         (linux_stop_and_wait_all_lwps, select_event_lwp)
4539         (linux_nat_filter_event, linux_nat_wait_1)
4540         (linux_nat_target::kill, linux_nat_target::stop)
4541         (linux_nat_target::stop): Update.
4542         (linux_nat_resume_callback): Change type.
4543         (resume_stopped_resumed_lwps, count_events_callback)
4544         (select_event_lwp_callback): Likewise.
4545         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4546         * arm-linux-nat.c (struct update_registers_data): Remove.
4547         (update_registers_callback): Change type.
4548         (arm_linux_insert_hw_breakpoint1): Update.
4549         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4550         parameter.
4551         (x86_linux_dr_set_addr): Update.
4552         (x86_linux_dr_set_control): Update.
4553         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4554         (iterate_over_lwps): Use gdb::function_view.
4555         * nat/aarch64-linux-hw-point.c (struct
4556         aarch64_dr_update_callback_param): Remove.
4557         (debug_reg_change_callback): Change type.
4558         (aarch64_notify_debug_reg_change): Update.
4559         * s390-linux-nat.c (s390_refresh_per_info): Update.
4560
4561 2019-03-11  Tom Tromey  <tromey@adacore.com>
4562
4563         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4564         redundant assignment to "this_cu".
4565
4566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4567
4568         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4569
4570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4571
4572         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4573         from...
4574         (rank_one_type): ... this.
4575
4576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4577
4578         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4579         from...
4580         (rank_one_type): ... this.
4581
4582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4583
4584         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4585         from...
4586         (rank_one_type): ... this.
4587
4588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4589
4590         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4591         from...
4592         (rank_one_type): ... this.
4593
4594 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4595
4596         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4597         from...
4598         (rank_one_type): ... this.
4599
4600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4601
4602         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4603         from...
4604         (rank_one_type): ... this.
4605
4606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4607
4608         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4609         from...
4610         (rank_one_type): ... this.
4611
4612 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4613
4614         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4615         from...
4616         (rank_one_type): ... this.
4617
4618 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4619
4620         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4621         from...
4622         (rank_one_type): ... this.
4623
4624 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4625
4626         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4627         from...
4628         (rank_one_type): ... this.
4629
4630 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4631
4632         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4633         from...
4634         (rank_one_type): ... this.
4635
4636 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4637
4638         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4639         from...
4640         (rank_one_type): ... this.
4641
4642 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4643
4644         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4645         inferior-events' shows the example events.
4646
4647 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4648
4649         Support styling on native MS-Windows console
4650
4651         PR/24315
4652         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4653         on MS-Windows if $TERM is not defined.
4654
4655         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4656
4657         * posix-hdep.c (gdb_console_fputs):
4658         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4659         functions.
4660         * ui-file.h (gdb_console_fputs): Add prototype.
4661
4662         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4663         back to fputs only if the former returns zero.
4664
4665 2019-03-07  Tom Tromey  <tom@tromey.com>
4666
4667         * symmisc.c (print_symbol_bcache_statistics): Update.
4668         (print_objfile_statistics): Update.
4669         * symfile.c (allocate_symtab): Update.
4670         * stabsread.c: Don't include bcache.h.
4671         * psymtab.h (struct psymbol_bcache): Don't declare.
4672         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4673         (psymbol_bcache_init, psymbol_bcache_free)
4674         (psymbol_bcache_get_bcache): Don't declare.
4675         * psymtab.c (struct psymbol_bcache): Remove.
4676         (psymtab_storage::psymtab_storage): Update.
4677         (psymtab_storage::~psymtab_storage): Update.
4678         (psymbol_bcache_init, psymbol_bcache_free)
4679         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4680         (add_psymbol_to_bcache): Update.
4681         (allocate_psymtab): Update.
4682         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4683         macro_cache>: No longer pointers.
4684         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4685         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4686         * macrotab.c (macro_bcache): Update.
4687         * macroexp.c: Don't include bcache.h.
4688         * gdbtypes.c (check_types_worklist): Update.
4689         (types_deeply_equal): Remove TRY/CATCH.  Update.
4690         * elfread.c (elf_symtab_read): Update.
4691         * dwarf2read.c: Don't include bcache.h.
4692         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4693         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4694         (print_bcache_statistics, bcache_memory_used): Don't declare.
4695         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4696         methods.  Rename all data members.
4697         * bcache.c (struct bcache): Move to bcache.h.
4698         (bcache::expand_hash_table): Rename from expand_hash_table.
4699         (bcache): Remove.
4700         (bcache::insert): Rename from bcache_full.
4701         (bcache::compare): Rename from bcache_compare.
4702         (bcache_xmalloc): Remove.
4703         (bcache::~bcache): Rename from bcache_xfree.
4704         (bcache::print_statistics): Rename from print_bcache_statistics.
4705         (bcache::memory_used): Rename from bcache_memory_used.
4706
4707 2019-03-07  Pedro Alves  <palves@redhat.com>
4708
4709         * infrun.c (normal_stop): Also check for
4710         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4711
4712 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4713
4714         * f-lang.c (value_from_host_double): Moved to...
4715         * value.c (value_from_host_double): ...here.
4716         * value.h (value_from_host_double): Declare.
4717         * guile/scm-math.c (vlscm_convert_typed_number): Use
4718         value_from_host_double.
4719         (vlscm_convert_number): Likewise.
4720         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4721         * python/py-value.c (convert_value_from_python): Likewise.
4722
4723 2019-03-06  Tom Tromey  <tom@tromey.com>
4724
4725         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4726
4727 2019-03-06  Tom Tromey  <tom@tromey.com>
4728
4729         * utils.h (free_current_contents): Don't declare.
4730         * utils.c (free_current_contents): Remove.
4731
4732 2019-03-06  Tom Tromey  <tom@tromey.com>
4733
4734         * top.c (quit_force): Update.
4735         * main.c (captured_command_loop): Update.
4736         * common/new-op.c (operator new): Update.
4737         * common/common-exceptions.c (struct catcher)
4738         <save_cleanup_chain>: Remove member.
4739         (exceptions_state_mc_init): Update.
4740         (exception_try_scope_entry): Return nullptr.
4741         (exception_try_scope_exit, exception_rethrow)
4742         (throw_exception_sjlj, throw_exception_cxx): Update.
4743         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4744         (all_cleanups, do_cleanups, discard_cleanups)
4745         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4746         (restore_cleanups, restore_final_cleanups): Don't declare.
4747         (do_final_cleanups): Remove parameter.
4748         * common/cleanups.c (cleanup_chain, make_cleanup)
4749         (make_cleanup_dtor, all_cleanups, do_cleanups)
4750         (discard_my_cleanups, discard_cleanups)
4751         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4752         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4753         (null_cleanup): Remove.
4754         (do_final_cleanups): Remove parameter.
4755
4756 2019-03-06  Tom Tromey  <tom@tromey.com>
4757
4758         * remote.c (remote_target::remote_parse_stop_reply): Use
4759         unique_xmalloc_ptr.
4760
4761 2019-03-06  Tom Tromey  <tom@tromey.com>
4762
4763         * stabsread.c (struct stabs_field_info): Rename from field_info.
4764         <list, fnlist>: Add initializers.
4765         <obstack>: New member.
4766         (read_member_functions, read_struct_fields, read_baseclasses):
4767         Allocate on obstack.  Don't use cleanups.
4768         (read_one_struct_field, read_member_functions, read_struct_fields)
4769         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4770         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4771         (read_struct_type): Update.
4772
4773 2019-03-06  Tom Tromey  <tom@tromey.com>
4774
4775         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4776         * common/filestuff.h (make_cleanup_close): Don't declare.
4777         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4778         Remove.
4779
4780 2019-03-06  Tom Tromey  <tom@tromey.com>
4781
4782         * solib-aix.c: Use make_scope_exit.
4783
4784 2019-03-06  Tom Tromey  <tom@tromey.com>
4785
4786         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4787         Use make_scope_exit.
4788
4789 2019-03-06  Tom Tromey  <tom@tromey.com>
4790
4791         * solib-svr4.c (disable_probes_interface): Remove parameter.
4792         (svr4_handle_solib_event): Use make_scope_exit.
4793
4794 2019-03-06  Tom Tromey  <tom@tromey.com>
4795
4796         * remote.c (struct stop_reply_deleter): Remove.
4797         (stop_reply_up): Update.
4798         (struct stop_reply): Derive from notif_event.  Don't typedef.
4799         <regcache>: Now a std::vector.
4800         (stop_reply_xfree): Remove.
4801         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4802         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4803         (remote_target::discard_pending_stop_replies): Use delete.
4804         (remote_target::remote_parse_stop_reply): Update.
4805         (remote_target::process_stop_reply): Update.
4806         * remote-notif.h (struct notif_event): Add virtual destructor.
4807         Remove "dtr" member.
4808         (struct notif_client) <alloc_event>: Return a unique_ptr.
4809         (notif_event_xfree): Don't declare.
4810         (notif_event_up): New typedef.
4811         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4812         (notif_event_xfree, do_notif_event_xfree): Remove.
4813         (remote_notif_state_xfree): Update.
4814
4815 2019-03-06  Tom Tromey  <tom@tromey.com>
4816
4817         * infrun.c (displaced_step_clear_cleanup): Now a
4818         forward_scope_exit type.
4819         (displaced_step_prepare_throw): Update.
4820         (displaced_step_fixup): Update.
4821
4822 2019-03-06  Tom Tromey  <tom@tromey.com>
4823
4824         * inferior.h (class inferior): Update comment.
4825         * gdbthread.h (class thread_info): Update comment.
4826
4827 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4828             Tom Tromey  <tom@tromey.com>
4829
4830         * stabsread.h (struct stab_section_list): Remove.
4831         (coffstab_build_psymtabs): Update.
4832         * dbxread.c (symbuf_sections): Now a std::vector.
4833         (sect_idx): New global.
4834         (fill_symbuf): Update.
4835         (coffstab_build_psymtabs): Change type of stabsects parameter.
4836         Update.
4837         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4838         std::vector.
4839         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4840         (coff_locate_sections): Update.
4841         (coff_symfile_read): Remove cleanups.  Update.
4842         (init_stringtab): Add storage parameter.
4843         (free_stringtab, free_stringtab_cleanup): Remove.
4844         (init_lineno): Add storage parameter.
4845         (free_linetab, free_linetab_cleanup): Remove.
4846
4847 2019-03-06  Pedro Alves  <palves@redhat.com>
4848
4849         * linux-fork.c (fork_info::clobber_regs): Delete.
4850         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4851         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4852         comment.  Adjust.
4853         (scoped_switch_fork_info::scoped_switch_fork_info)
4854         (checkpoint_command, linux_fork_context): Adjust
4855         fork_save_infrun_state calls.
4856
4857 2019-03-06  Pedro Alves  <palves@redhat.com>
4858
4859         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4860         (inf_has_multiple_threads): Return 'bool' and rewrite using
4861         inferior_info::threads().
4862
4863 2019-03-06  Pedro Alves  <palves@redhat.com>
4864
4865         * linux-fork.c: Include <list>.
4866         (fork_list): Now a std::list instance.
4867         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4868         (forks_exist_p, find_last_fork): Adjust.
4869         (new_fork): Delete.
4870         (one_fork_p): New.
4871         (add_fork): Adjust.
4872         (free_fork): Delete, folded into fork_info::~fork_info().
4873         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4874         Adjust.
4875         (init_fork_list): Delete.
4876         (linux_fork_killall, linux_fork_mourn_inferior)
4877         (linux_fork_detach, info_checkpoints_command): Adjust.
4878         (_initialize_linux_fork): No longer call init_fork_list.
4879
4880 2019-03-06  Pedro Alves  <palves@redhat.com>
4881
4882         * linux-fork.c (new_fork): New, split out of ...
4883         (add_fork): ... this.  Return void.  Move "first fork" special
4884         case from here, to ...
4885         (checkpoint_command): ... here.
4886         * linux-linux.h (add_fork): Return void.
4887
4888 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4891
4892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4893             Chris January  <chris.january@arm.com>
4894             David Lecomber  <david.lecomber@arm.com>
4895
4896         * f-exp.y: New token, UNOP_INTRINSIC.
4897         (exp): New pattern using UNOP_INTRINSIC token.
4898         (f77_keywords): Add 'abs' keyword.
4899         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4900         (value_from_host_double): New function.
4901         (evaluate_subexp_f): Support UNOP_ABS.
4902
4903 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4904
4905         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4906         types.
4907
4908 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4911         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4912         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4913
4914 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4917
4918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4919             Chris January  <chris.january@arm.com>
4920
4921         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4922         * f-exp.y: Define 'KIND' token.
4923         (exp): New pattern for KIND expressions.
4924         (ptype): Handle types with a kind extension.
4925         (direct_abs_decl): Extend to spot kind extensions.
4926         (f77_keywords): Add 'kind' to the list.
4927         (push_kind_type): New function.
4928         (convert_to_kind_type): New function.
4929         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4930         * parse.c (operator_length_standard): Likewise.
4931         * parser-defs.h (enum type_pieces): Add tp_kind.
4932         * std-operator.def: Add UNOP_KIND.
4933
4934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * f-exp.y (f_parse): Set yydebug.
4937
4938 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * f-lang.c (evaluate_subexp_f): New function.
4941         (exp_descriptor_f): New global.
4942         (f_language_defn): Use exp_descriptor_f instead of
4943         exp_descriptor_standard.
4944
4945 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4946
4947         * f-exp.y (struct token): Add comments.
4948         (dot_ops): Remove uppercase versions and the end marker.
4949         (f77_keywords): Likewise.
4950         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4951         entries in the dot_ops array are case insensitive, and use
4952         strncasecmp to compare strings.  Also some whitespace cleanup in
4953         this area.  Similar for the f77_keywords array, except entries in
4954         this list might be case sensitive.
4955
4956 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4957
4958         * f-exp.y (struct f77_boolean_val): Add comments.
4959         (boolean_values): Remove uppercase versions, and end marker.
4960         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4961         and use strncasecmp to achieve case insensitivity.  Additionally,
4962         perform whitespace cleanup around this code.
4963
4964 2019-03-06  Tom Tromey  <tromey@adacore.com>
4965
4966         * remote-sim.c (gdbsim_target_open): Use result of
4967         gdb_argv::release.
4968
4969 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4970         Dirk Schubert  <dirk.schubert@arm.com>
4971         Chris January  <chris.january@arm.com>
4972
4973         * eval.c (evaluate_subexp_standard): Call Fortran argument
4974         wrapping logic.
4975         * f-lang.c (struct value): A value which can be passed into a
4976         Fortran function call.
4977         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4978         where appropriate.
4979         (struct type): Value ready for a Fortran function call.
4980         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4981         is needed.
4982         * f-lang.h (fortran_argument_convert): Declaration.
4983         (fortran_preserve_arg_pointer): Declaration.
4984         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4985
4986 2019-03-05  Tom Tromey  <tromey@adacore.com>
4987
4988         * python/py-prettyprint.c (print_string_repr): Remove #if.
4989         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4990
4991 2019-03-05  Tom Tromey  <tromey@adacore.com>
4992
4993         * target.c (the_dummy_target): Move later.  Change type to
4994         "dummy_target".
4995         (initialize_targets): Don't initialize the_dummy_target.
4996
4997 2019-03-05  Tom Tromey  <tromey@adacore.com>
4998
4999         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5000         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5001
5002 2019-03-05  Tom Tromey  <tromey@adacore.com>
5003
5004         * windows-nat.c (windows_nat_target::attach)
5005         (windows_nat_target::detach): Don't call gdb_flush.
5006         * valprint.c (generic_val_print, val_print, val_print_string):
5007         Don't call gdb_flush.
5008         * utils.c (defaulted_query): Don't call gdb_flush.
5009         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5010         * target.c (target_announce_detach): Don't call gdb_flush.
5011         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5012         * remote.c (extended_remote_target::attach): Don't call
5013         gdb_flush.
5014         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5015         * printcmd.c (do_examine): Don't call gdb_flush.
5016         (info_display_command): Don't call gdb_flush.
5017         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5018         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5019         * memattr.c (info_mem_command): Don't call gdb_flush.
5020         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5021         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5022         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5023         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5024         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5025         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5026         (gnu_nat_target::detach): Don't call gdb_flush.
5027         * f-valprint.c (f_val_print): Don't call gdb_flush.
5028         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5029         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5030         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5031         gdb_flush.
5032         * c-valprint.c (c_val_print): Don't call gdb_flush.
5033         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5034
5035 2019-03-05  Tom Tromey  <tromey@adacore.com>
5036
5037         * varobj.c (update_dynamic_varobj_children): Update.
5038         (install_default_visualizer): Use reset, not release.
5039         * value.c (set_internalvar): Update.
5040         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5041         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5042         ATTRIBUTE_UNUSED_RESULT.
5043
5044 2019-03-05  Tom Tromey  <tromey@adacore.com>
5045
5046         * remote.c (class scoped_remote_fd) <release>: Add
5047         ATTRIBUTE_UNUSED_RESULT.
5048
5049 2019-03-05  Tom Tromey  <tromey@adacore.com>
5050
5051         * macroexp.c (struct macro_buffer) <release>: Add
5052         ATTRIBUTE_UNUSED_RESULT.
5053
5054 2019-03-05  Tom Tromey  <tromey@adacore.com>
5055
5056         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5057         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5058         ATTRIBUTE_UNUSED_RESULT.
5059
5060 2019-03-05  Tom Tromey  <tromey@adacore.com>
5061
5062         * common/scoped_fd.h (class scoped_fd) <release>: Add
5063         ATTRIBUTE_UNUSED_RESULT.
5064
5065 2019-03-05  Tom Tromey  <tromey@adacore.com>
5066
5067         * parser-defs.h (struct parser_state) <release>: Add
5068         ATTRIBUTE_UNUSED_RESULT.
5069
5070 2019-03-05  Tom Tromey  <tromey@adacore.com>
5071
5072         * utils.h (class gdb_argv) <release>: Add
5073         ATTRIBUTE_UNUSED_RESULT.
5074         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5075
5076 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5077
5078         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5079         for-loop range, to avoid compiler warnings.
5080
5081         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5082         avoid compiler warnings about unused variables.
5083
5084         * NEWS: Mention end of support for native debugging on MS-Windows
5085         before XP.
5086
5087         PR gdb/24292
5088         * common/netstuff.c:
5089         * gdbserver/gdbreplay.c
5090         * gdbserver/remote-utils.c:
5091         * ser-tcp.c:
5092         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5093         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5094         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5095         'getaddrinfo' and 'freeaddrinfo' were not available before
5096         Windows XP, and mingw.org's MinGW headers by default define
5097         _WIN32_WINNT to 0x500.
5098
5099 2019-03-01  Gary Benson <gbenson@redhat.com>
5100
5101         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5102
5103 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5104             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5105
5106         PR gdb/8527
5107         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5108         set_sigint_trap, clear_sigint_trap.
5109
5110 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5111
5112         * target.c (target_detach): Clear the regcache and the
5113         frame cache.
5114
5115 2019-02-27  Pedro Alves  <palves@redhat.com>
5116
5117         * utils.c (set_screen_size): When we cap the height/width sizes,
5118         tweak the corresponding command variable to show "unlimited":
5119
5120 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5121             Pedro Alves  <palves@redhat.com>
5122
5123         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5124         before calling rl_set_screen_size.
5125
5126 2019-02-27  Tom Tromey  <tromey@adacore.com>
5127
5128         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5129         define.
5130         * python/py-value.c: Remove Python 2.4 workaround.
5131         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5132         workaround.
5133         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5134         Python 2.4 workaround.
5135         * python/python-internal.h: Remove Python 2.4 comment.
5136         (Py_ssize_t): Don't define.
5137         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5138         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5139         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5140         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5141         * python/python.c (do_start_initialization): Remove Python 2.4
5142         workaround.
5143         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5144         (print_children): Remove Python 2.4 workaround.
5145         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5146         workaround.
5147         (CHARBUFFERPROC_NAME): Remove.
5148         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5149         Python 2.4 workaround.
5150
5151 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5152
5153         * NEWS: Note minimum Python version.
5154
5155 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5156
5157         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5158         code from these functions.  Remove corresponding ifdefs.  Use
5159         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5160         Remove gotos and target of gotos.
5161         (infpy_search_memory): Likewise.
5162
5163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5166         (hppa_gdbarch_init): Don't register deleted functions with
5167         gdbarch.
5168
5169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5172         (h8300_unwind_sp): Delete.
5173         (h8300_dummy_id): Delete.
5174         (h8300_gdbarch_init): Don't register deleted functions with
5175         gdbarch.
5176
5177 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5180         (ft32_unwind_pc): Delete.
5181         (ft32_unwind_sp): Delete.
5182         (ft32_gdbarch_init): Don't register deleted functions with
5183         gdbarch.
5184
5185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5188         (frv_unwind_pc): Delete.
5189         (frv_unwind_sp): Delete.
5190         (frv_gdbarch_init): Don't register deleted functions with
5191         gdbarch.
5192
5193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5196         (riscv_unwind_pc): Delete.
5197         (riscv_unwind_sp): Delete.
5198         (riscv_gdbarch_init): Don't register deleted functions with
5199         gdbarch.
5200
5201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5202
5203         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5204         (csky_unwind_pc): Delete.
5205         (csky_unwind_sp): Delete.
5206         (csky_gdbarch_init): Don't register deleted functions with
5207         gdbarch.
5208
5209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5210
5211         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5212         (cris_unwind_pc): Delete.
5213         (cris_unwind_sp): Delete.
5214         (cris_gdbarch_init): Don't register deleted functions with
5215         gdbarch.
5216
5217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5220         (bfin_unwind_pc): Delete.
5221         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5222
5223 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5224
5225         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5226         (arm_unwind_pc): Delete.
5227         (arm_unwind_sp): Delete.
5228         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5229
5230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5233         (arc_unwind_pc): Delete.
5234         (arc_unwind_sp): Delete.
5235         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5236
5237 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5238
5239         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5240         (alpha_unwind_pc): Delete.
5241         (alpha_gdbarch_init): Don't register deleted functions with
5242         gdbarch.
5243
5244 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5247         (aarch64_unwind_pc): Delete.
5248         (aarch64_unwind_sp): Delete.
5249         (aarch64_gdbarch_init): Don't register deleted functions with
5250         gdbarch.
5251
5252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         * gdbtypes.c (type_align): Don't consider static members when
5255         computing structure alignment.
5256
5257 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5258
5259         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5260         return 0 for other types.
5261         * arch-utils.c (default_type_align): Always return 0.
5262         * gdbarch.h: Regenerate.
5263         * gdbarch.sh (type_align): Extend comment.
5264         * gdbtypes.c (type_align): Add additional comments, always call
5265         gdbarch_type_align before applying the default rules.
5266         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5267         generic code will then apply a suitable default.
5268         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5269         types, return 0 for other types.
5270
5271 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5272
5273         * NEWS: Create a new section for the next release branch.
5274         Rename the section of the current branch, now that it has
5275         been cut.
5276
5277 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5278
5279         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5280         * version.in: Bump version to 8.3.50.DATE-git.
5281
5282 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5283
5284         * aix-thread.c (ptid_cmp): Remove unused variable.
5285         (get_signaled_thread): Likewise.
5286         (store_regs_user_thread): Likewise.
5287         (store_regs_kernel_thread): Likewise.
5288         (fetch_regs_kernel_thread): Remove shadowed variable.
5289
5290 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * features/riscv/32bit-cpu.xml: Add register numbers.
5293         * features/riscv/32bit-fpu.c: Regenerate.
5294         * features/riscv/32bit-fpu.xml: Add register numbers.
5295         * features/riscv/64bit-cpu.xml: Add register numbers.
5296         * features/riscv/64bit-fpu.c: Regenerate.
5297         * features/riscv/64bit-fpu.xml: Add register numbers.
5298
5299 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5300
5301         * NEWS: Mention two argument form of gdb.Value constructor.
5302         * python/py-value.c (convert_buffer_and_type_to_value): New
5303         function.
5304         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5305         Add support for handling an optional second argument.  Call
5306         convert_buffer_and_type_to_value as appropriate.
5307         * python/python-internal.h (Py_buffer_deleter): New struct.
5308         (Py_buffer_up): New typedef.
5309
5310 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5311
5312         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5313         instead of releasing ownership.
5314
5315 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5316
5317         * dwarf2read.c (open_and_init_dwp_file): Call
5318         elf_numsections instead of bfd_count_sections to initialize
5319         dwp_file->num_sections.
5320
5321 2019-02-25  Tom Tromey  <tromey@adacore.com>
5322
5323         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5324
5325 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5326
5327         * gcore.in: Add '--readnever' option when invoking GDB.
5328
5329 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5330
5331         * MAINTAINERS: Update my email address.
5332
5333 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5334
5335         * build-id.c (build_id_to_debug_bfd_1): New function.
5336         (build_id_to_debug_bfd): Look for separate debug file in
5337         sysroot.
5338
5339 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5340
5341         * gdbarch.sh: Update the copyright year range that is placed into
5342         generated files.
5343
5344 2019-02-22  Keith Seitz  <keiths@redhat.com>
5345
5346         PR symtab/23853
5347         * linespec.c (create_sals_line_offset): Search for the default
5348         symtab's filename instead of its fullname.
5349
5350 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5351
5352         * NEWS: Update style defaults.
5353
5354 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5355
5356         * main.c (captured_main_1): Disable styling in batch mode.
5357
5358 2019-02-20  Tom Tromey  <tom@tromey.com>
5359
5360         * symtab.c (symtab_symbol_info): Fix typos.
5361
5362 2019-02-20  Tom Tromey  <tromey@adacore.com>
5363
5364         * findcmd.c (_initialize_mem_search): Use upper case for
5365         metasyntactic variables.
5366
5367 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5368
5369         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5370         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5371
5372 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5373
5374         * top.h (source_file_name): Change to std::string.
5375         * top.c (source_file_name): Likewise.
5376         (command_line_input): Adjust.
5377         * cli/cli-script.c (script_from_file): Adjust.
5378
5379 2019-02-19  Tom Tromey  <tromey@adacore.com>
5380
5381         * ravenscar-thread.c
5382         (ravenscar_thread_target::update_thread_list): Don't call
5383         ada_build_task_list.
5384         * ada-lang.h (ada_build_task_list): Don't declare.
5385         * ada-tasks.c (struct ada_tasks_inferior_data)
5386         <task_list_valid_p>: Now bool.
5387         (read_known_tasks, ada_task_list_changed)
5388         (ada_tasks_invalidate_inferior_data): Update.
5389         (read_known_tasks_array): Return bool.
5390         (read_known_tasks_list): Likewise.
5391         (read_known_tasks): Return void.
5392         (ada_build_task_list): Now static.
5393
5394 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5395
5396         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5397         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5398
5399 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5400
5401         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5402         variant for ada_tasks_pspace_data_handle and
5403         ada_tasks_inferior_data_handle.
5404         (ada_tasks_pspace_data_cleanup): New function.
5405         (ada_tasks_inferior_data_cleanup): New function.
5406
5407 2019-02-17  Tom Tromey  <tom@tromey.com>
5408
5409         * macrotab.h (macro_source_fullname): Return a std::string.
5410         * macrotab.c (macro_include, check_for_redefinition)
5411         (macro_undef, macro_lookup_definition, foreach_macro)
5412         (foreach_macro_in_scope): Update.
5413         (macro_source_fullname): Return a std::string.
5414         * macrocmd.c (show_pp_source_pos): Update.
5415
5416 2019-02-17  Tom Tromey  <tom@tromey.com>
5417
5418         * macrocmd.c (show_pp_source_pos): Style the file names.
5419
5420 2019-02-17  Tom Tromey  <tom@tromey.com>
5421
5422         PR tui/24197:
5423         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5424
5425 2019-02-17  Tom Tromey  <tom@tromey.com>
5426
5427         * ada-lang.c (user_select_syms): Use filtered printing.
5428         * utils.c (wrap_style): New global.
5429         (desired_style): Remove.
5430         (emit_style_escape): Add stream parameter.
5431         (set_output_style, reset_terminal_style, prompt_for_continue):
5432         Update.
5433         (flush_wrap_buffer): Only flush gdb_stdout.
5434         (wrap_here): Set wrap_style.
5435         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5436         treat escape sequences as a character.  Change when wrap buffer is
5437         flushed.
5438         (fputs_styled): Do not set the output style when the default is
5439         requested.
5440         * ui-style.h (struct ui_file_style) <is_default>: New method.
5441         * source.c (print_source_lines_base): Emit escape sequences in one
5442         piece.
5443
5444 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5445
5446         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5447         integers and enumeration types.
5448
5449 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5450
5451         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5452         instead of lookup_symbol_in_language
5453         (do_exact_match): New function.
5454         (ada_get_symbol_name_matcher): Return do_exact_match when
5455         doing a verbatim match.
5456
5457 2019-02-15  Tom Tromey  <tromey@adacore.com>
5458
5459         * ravenscar-thread.c (ravenscar_thread_target::resume)
5460         (ravenscar_thread_target::wait): Special case wildcard requests.
5461
5462 2019-02-15  Tom Tromey  <tromey@adacore.com>
5463
5464         * ravenscar-thread.c (base_ptid): Remove.
5465         (struct ravenscar_thread_target) <close>: New method.
5466         <m_base_ptid>: New member.
5467         <update_inferior_ptid, active_task, task_is_currently_active,
5468         runtime_initialized>: Declare methods.
5469         <ravenscar_thread_target>: Add constructor.
5470         (ravenscar_thread_target::task_is_currently_active)
5471         (ravenscar_thread_target::update_inferior_ptid)
5472         (ravenscar_runtime_initialized): Rename.  Now methods.
5473         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5474         (ravenscar_thread_target::update_thread_list): Update.
5475         (ravenscar_thread_target::active_task): Now method.
5476         (ravenscar_thread_target::store_registers)
5477         (ravenscar_thread_target::prepare_to_store)
5478         (ravenscar_thread_target::prepare_to_store)
5479         (ravenscar_thread_target::mourn_inferior): Update.
5480         (ravenscar_inferior_created): Use "new" to create target.
5481         (ravenscar_thread_target::get_ada_task_ptid): Update.
5482         (_initialize_ravenscar): Don't initialize base_ptid.
5483         (ravenscar_ops): Remove global.
5484
5485 2019-02-15  Tom Tromey  <tromey@adacore.com>
5486
5487         * target.h (push_target): Declare new overload.
5488         * target.c (push_target): New overload, taking an rvalue reference.
5489         * remote.c (remote_target::open_1): Use push_target overload.
5490         * corelow.c (core_target_open): Use push_target overload.
5491
5492 2019-02-15  Tom Tromey  <tromey@adacore.com>
5493
5494         * ravenscar-thread.c (is_ravenscar_task)
5495         (ravenscar_task_is_currently_active): Return bool.
5496         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5497         (_initialize_ravenscar): Remove "(void)".
5498         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5499         Return bool.
5500
5501 2019-02-15  Tom Tromey  <tromey@adacore.com>
5502
5503         * ravenscar-thread.c (ravenscar_runtime_initializer)
5504         (has_ravenscar_runtime, get_running_thread_id)
5505         (ravenscar_thread_target::resume): Fix indentation.
5506
5507 2019-02-15  Tom Tromey  <tromey@adacore.com>
5508
5509         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5510         from ravenscar_arch_ops.
5511         (sparc_ravenscar_ops::fetch_registers)
5512         (sparc_ravenscar_ops::store_registers): Now methods.
5513         (sparc_ravenscar_prepare_to_store): Remove.
5514         (sparc_ravenscar_ops): Redefine.
5515         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5516         methods and destructor.  Remove members.
5517         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5518         (ravenscar_thread_target::store_registers)
5519         (ravenscar_thread_target::prepare_to_store): Update.
5520         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5521         Remove.
5522         (struct ppc_ravenscar_powerpc_ops): Derive from
5523         ravenscar_arch_ops.
5524         (ppc_ravenscar_powerpc_ops::fetch_registers)
5525         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5526         (ppc_ravenscar_powerpc_ops): Redefine.
5527         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5528         (ppc_ravenscar_e500_ops::fetch_registers)
5529         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5530         (ppc_ravenscar_e500_ops): Redefine.
5531         * aarch64-ravenscar-thread.c
5532         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5533         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5534         (aarch64_ravenscar_fetch_registers)
5535         (aarch64_ravenscar_store_registers): Now methods.
5536         (aarch64_ravenscar_ops): Redefine.
5537
5538 2019-02-15  Tom Tromey  <tromey@adacore.com>
5539
5540         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5541         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5542         (ravenscar_thread_target::stopped_by_watchpoint)
5543         (ravenscar_thread_target::stopped_data_address)
5544         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5545
5546 2019-02-15  Tom Tromey  <tromey@adacore.com>
5547
5548         * ravenscar-thread.c: Fix some typos.
5549
5550 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5551             Tom Tromey  <tromey@adacore.com>
5552
5553         * ada-lang.c (ada_exception_sal): Change addr_string to a
5554         std::string.
5555         (create_ada_exception_catchpoint): Update.
5556
5557 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5558             Tom Tromey  <tromey@adacore.com>
5559
5560         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5561         (bp_location_ops): Remove.
5562         (base_breakpoint_allocate_location): Update.
5563         (free_bp_location): Update.
5564         * ada-lang.c (class ada_catchpoint_location)
5565         <ada_catchpoint_location>: Remove ops parameter.
5566         (ada_catchpoint_location_dtor): Remove.
5567         (ada_catchpoint_location_ops): Remove.
5568         (allocate_location_exception): Update.
5569         * breakpoint.h (struct bp_location_ops): Remove.
5570         (class bp_location) <bp_location>: Remove bp_location_ops
5571         parameter.
5572         <~bp_location>: Add destructor.
5573         <ops>: Remove.
5574
5575 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5576             Pedro Alves  <palves@redhat.com>
5577
5578         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5579         'PATH_MAX'.
5580
5581 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5582             Samuel Thibault  <samuel.thibault@gnu.org>
5583             Thomas Schwinge  <thomas@codesourcery.com>
5584
5585         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5586         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5587
5588 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5589
5590         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5591         (check_empty): Use "const char *".
5592
5593         * gnu-nat.c (gnu_nat_target::detach): Instead of
5594         'detach_inferior (pid)' call
5595         'detach_inferior (find_inferior_pid (pid))'.
5596
5597         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5598         'nat/fork-inferior.o'.
5599         * gnu-nat.c: #include "nat/fork-inferior.h".
5600
5601         * gnu-nat.c (gnu_nat_target::detach): Instead of
5602         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5603         * gnu-nat.h: #include "inf-child.h".
5604         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5605         'i386_gnu_nat_target::fetch_registers'.
5606         (gnu_store_registers): Rename/move to
5607         'i386_gnu_nat_target::store_registers'.
5608
5609         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5610         * gnu-nat.h (mach_thread_info): New function.
5611         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5612
5613         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5614
5615 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5616
5617         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5618
5619 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5620
5621         * windows-nat.c (windows_add_thread): Add new parameter
5622         "main_thread_p" with default value set to false.  Update
5623         function documentation as well as all callers.
5624         (windows_delete_thread): Likewise.
5625         (fake_create_process): Update call to windows_add_thread.
5626         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5627         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5628         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5629         call to windows_delete_thread.
5630
5631 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5632
5633         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5634
5635 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5636
5637         * symfile.c (find_separate_debug_file): Use canonical path of
5638         sysroot with child_path instead of gdb_sysroot if it is valid.
5639
5640 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5641
5642         * symfile.c (find_separate_debug_file): Use child_path to
5643         determine if an object file is under a sysroot.
5644
5645 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5646
5647         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5648         unittests/child-path-selftests.c.
5649         * common/pathstuff.c (child_path): New function.
5650         * common/pathstuff.h (child_path): New prototype.
5651         * unittests/child-path-selftests.c: New file.
5652
5653 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5654
5655         * symfile.c (find_separate_debug_file): Look for separate debug
5656         files in debug directories under the sysroot.
5657
5658 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5659
5660         * symtab.h (struct minimal_symbol data_p): New const method.
5661         (struct minimal_symbol text_p): Likewise.
5662         * symtab.c (output_source_filename): Use file name style
5663         to print file name.
5664         (print_symbol_info): Likewise.
5665         (print_msymbol_info): Use address style to print addresses.
5666         Use function name style to print executable text symbols.
5667         (expand_symtab_containing_pc): Use data_p.
5668         (find_pc_sect_compunit_symtab): Likewise.
5669
5670 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5671
5672         * breakpoint.c (describe_other_breakpoints): Use address style
5673         to print addresses.
5674         (say_where): Likewise.
5675
5676 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5677
5678         * ada-typeprint.c (print_func_type): Print function name
5679         style to print function name.
5680         * c-typeprint.c (c_print_type_1): Likewise.
5681
5682 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5683
5684         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5685         for execve.
5686
5687 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5688
5689         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5690         type_stack.
5691
5692 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5693
5694         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5695         TYPE_CODE_REF types.
5696
5697 2019-02-08  Jim Wilson  <jimw@sifive.com>
5698
5699         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5700         (riscv_linux_fregset): New.
5701         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5702
5703 2019-02-07  Tom Tromey  <tom@tromey.com>
5704
5705         * thread.c (thread_cancel_execution_command): Update.
5706         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5707         methods.
5708         (struct thread_fsm_ops): Remove.
5709         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5710         (thread_fsm_should_stop, thread_fsm_return_value)
5711         (thread_fsm_set_finished, thread_fsm_finished_p)
5712         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5713         Don't declare.
5714         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5715         * infrun.c (clear_proceed_status_thread)
5716         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5717         (print_stop_event): Update.
5718         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5719         Add constructor.
5720         (step_command_fsm_ops): Remove.
5721         (new_step_command_fsm): Remove.
5722         (step_1): Update.
5723         (step_command_fsm::should_stop): Rename from
5724         step_command_fsm_should_stop.
5725         (step_command_fsm::clean_up): Rename from
5726         step_command_fsm_clean_up.
5727         (step_command_fsm::do_async_reply_reason): Rename from
5728         step_command_fsm_async_reply_reason.
5729         (struct until_next_fsm): Inherit from thread_fsm.  Add
5730         constructor.
5731         (until_next_fsm_ops): Remove.
5732         (new_until_next_fsm): Remove.
5733         (until_next_fsm::should_stop): Rename from
5734         until_next_fsm_should_stop.
5735         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5736         (until_next_fsm::do_async_reply_reason): Rename from
5737         until_next_fsm_async_reply_reason.
5738         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5739         constructor.  Change type of breakpoint.
5740         (finish_command_fsm_ops): Remove.
5741         (new_finish_command_fsm): Remove.
5742         (finish_command_fsm::should_stop): Rename from
5743         finish_command_fsm_should_stop.
5744         (finish_command_fsm::clean_up): Rename from
5745         finish_command_fsm_clean_up.
5746         (finish_command_fsm::return_value): Rename from
5747         finish_command_fsm_return_value.
5748         (finish_command_fsm::do_async_reply_reason): Rename from
5749         finish_command_fsm_async_reply_reason.
5750         (finish_command): Update.
5751         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5752         Add constructor.
5753         (call_thread_fsm_ops): Remove.
5754         (call_thread_fsm::call_thread_fsm): Rename from
5755         new_call_thread_fsm.
5756         (call_thread_fsm::should_stop): Rename from
5757         call_thread_fsm_should_stop.
5758         (call_thread_fsm::should_notify_stop): Rename from
5759         call_thread_fsm_should_notify_stop.
5760         (run_inferior_call, call_function_by_hand_dummy): Update.
5761         * cli/cli-interp.c (should_print_stop_to_console): Update.
5762         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5763         Add constructor.  Change type of location_breakpoint,
5764         caller_breakpoint.
5765         (until_break_fsm_ops): Remove.
5766         (new_until_break_fsm): Remove.
5767         (until_break_fsm::should_stop): Rename from
5768         until_break_fsm_should_stop.
5769         (until_break_fsm::clean_up): Rename from
5770         until_break_fsm_clean_up.
5771         (until_break_fsm::do_async_reply_reason): Rename from
5772         until_break_fsm_async_reply_reason.
5773         (until_break_command): Update.
5774         * thread-fsm.c: Remove.
5775         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5776
5777 2019-02-07  Tom Tromey  <tom@tromey.com>
5778
5779         * yy-remap.h: Add include guard.
5780         * xtensa-tdep.h: Add include guard.
5781         * xcoffread.h: Rename include guard.
5782         * varobj-iter.h: Add include guard.
5783         * tui/tui.h: Rename include guard.
5784         * tui/tui-winsource.h: Rename include guard.
5785         * tui/tui-wingeneral.h: Rename include guard.
5786         * tui/tui-windata.h: Rename include guard.
5787         * tui/tui-win.h: Rename include guard.
5788         * tui/tui-stack.h: Rename include guard.
5789         * tui/tui-source.h: Rename include guard.
5790         * tui/tui-regs.h: Rename include guard.
5791         * tui/tui-out.h: Rename include guard.
5792         * tui/tui-layout.h: Rename include guard.
5793         * tui/tui-io.h: Rename include guard.
5794         * tui/tui-hooks.h: Rename include guard.
5795         * tui/tui-file.h: Rename include guard.
5796         * tui/tui-disasm.h: Rename include guard.
5797         * tui/tui-data.h: Rename include guard.
5798         * tui/tui-command.h: Rename include guard.
5799         * tic6x-tdep.h: Add include guard.
5800         * target/waitstatus.h: Rename include guard.
5801         * target/wait.h: Rename include guard.
5802         * target/target.h: Rename include guard.
5803         * target/resume.h: Rename include guard.
5804         * target-float.h: Rename include guard.
5805         * stabsread.h: Add include guard.
5806         * rs6000-tdep.h: Add include guard.
5807         * riscv-fbsd-tdep.h: Add include guard.
5808         * regformats/regdef.h: Rename include guard.
5809         * record.h: Rename include guard.
5810         * python/python.h: Rename include guard.
5811         * python/python-internal.h: Rename include guard.
5812         * python/py-stopevent.h: Rename include guard.
5813         * python/py-ref.h: Rename include guard.
5814         * python/py-record.h: Rename include guard.
5815         * python/py-record-full.h: Rename include guard.
5816         * python/py-record-btrace.h: Rename include guard.
5817         * python/py-instruction.h: Rename include guard.
5818         * python/py-events.h: Rename include guard.
5819         * python/py-event.h: Rename include guard.
5820         * procfs.h: Add include guard.
5821         * proc-utils.h: Add include guard.
5822         * p-lang.h: Add include guard.
5823         * or1k-tdep.h: Rename include guard.
5824         * observable.h: Rename include guard.
5825         * nto-tdep.h: Rename include guard.
5826         * nat/x86-linux.h: Rename include guard.
5827         * nat/x86-linux-dregs.h: Rename include guard.
5828         * nat/x86-gcc-cpuid.h: Add include guard.
5829         * nat/x86-dregs.h: Rename include guard.
5830         * nat/x86-cpuid.h: Rename include guard.
5831         * nat/ppc-linux.h: Rename include guard.
5832         * nat/mips-linux-watch.h: Rename include guard.
5833         * nat/linux-waitpid.h: Rename include guard.
5834         * nat/linux-ptrace.h: Rename include guard.
5835         * nat/linux-procfs.h: Rename include guard.
5836         * nat/linux-osdata.h: Rename include guard.
5837         * nat/linux-nat.h: Rename include guard.
5838         * nat/linux-namespaces.h: Rename include guard.
5839         * nat/linux-btrace.h: Rename include guard.
5840         * nat/glibc_thread_db.h: Rename include guard.
5841         * nat/gdb_thread_db.h: Rename include guard.
5842         * nat/gdb_ptrace.h: Rename include guard.
5843         * nat/fork-inferior.h: Rename include guard.
5844         * nat/amd64-linux-siginfo.h: Rename include guard.
5845         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5846         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5847         * nat/aarch64-linux.h: Rename include guard.
5848         * nat/aarch64-linux-hw-point.h: Rename include guard.
5849         * mn10300-tdep.h: Add include guard.
5850         * mips-linux-tdep.h: Add include guard.
5851         * mi/mi-parse.h: Rename include guard.
5852         * mi/mi-out.h: Rename include guard.
5853         * mi/mi-main.h: Rename include guard.
5854         * mi/mi-interp.h: Rename include guard.
5855         * mi/mi-getopt.h: Rename include guard.
5856         * mi/mi-console.h: Rename include guard.
5857         * mi/mi-common.h: Rename include guard.
5858         * mi/mi-cmds.h: Rename include guard.
5859         * mi/mi-cmd-break.h: Rename include guard.
5860         * m2-lang.h: Add include guard.
5861         * location.h: Rename include guard.
5862         * linux-record.h: Rename include guard.
5863         * linux-nat.h: Add include guard.
5864         * linux-fork.h: Add include guard.
5865         * i386-darwin-tdep.h: Rename include guard.
5866         * hppa-linux-offsets.h: Add include guard.
5867         * guile/guile.h: Rename include guard.
5868         * guile/guile-internal.h: Rename include guard.
5869         * gnu-nat.h: Rename include guard.
5870         * gdb-stabs.h: Rename include guard.
5871         * frv-tdep.h: Add include guard.
5872         * f-lang.h: Add include guard.
5873         * event-loop.h: Add include guard.
5874         * darwin-nat.h: Rename include guard.
5875         * cp-abi.h: Rename include guard.
5876         * config/sparc/nm-sol2.h: Rename include guard.
5877         * config/nm-nto.h: Rename include guard.
5878         * config/nm-linux.h: Add include guard.
5879         * config/i386/nm-i386gnu.h: Rename include guard.
5880         * config/djgpp/nl_types.h: Rename include guard.
5881         * config/djgpp/langinfo.h: Rename include guard.
5882         * compile/gcc-cp-plugin.h: Add include guard.
5883         * compile/gcc-c-plugin.h: Add include guard.
5884         * compile/compile.h: Rename include guard.
5885         * compile/compile-object-run.h: Rename include guard.
5886         * compile/compile-object-load.h: Rename include guard.
5887         * compile/compile-internal.h: Rename include guard.
5888         * compile/compile-cplus.h: Rename include guard.
5889         * compile/compile-c.h: Rename include guard.
5890         * common/xml-utils.h: Rename include guard.
5891         * common/x86-xstate.h: Rename include guard.
5892         * common/version.h: Rename include guard.
5893         * common/vec.h: Rename include guard.
5894         * common/tdesc.h: Rename include guard.
5895         * common/selftest.h: Rename include guard.
5896         * common/scoped_restore.h: Rename include guard.
5897         * common/scoped_mmap.h: Rename include guard.
5898         * common/scoped_fd.h: Rename include guard.
5899         * common/safe-iterator.h: Rename include guard.
5900         * common/run-time-clock.h: Rename include guard.
5901         * common/refcounted-object.h: Rename include guard.
5902         * common/queue.h: Rename include guard.
5903         * common/ptid.h: Rename include guard.
5904         * common/print-utils.h: Rename include guard.
5905         * common/preprocessor.h: Rename include guard.
5906         * common/pathstuff.h: Rename include guard.
5907         * common/observable.h: Rename include guard.
5908         * common/netstuff.h: Rename include guard.
5909         * common/job-control.h: Rename include guard.
5910         * common/host-defs.h: Rename include guard.
5911         * common/gdb_wait.h: Rename include guard.
5912         * common/gdb_vecs.h: Rename include guard.
5913         * common/gdb_unlinker.h: Rename include guard.
5914         * common/gdb_unique_ptr.h: Rename include guard.
5915         * common/gdb_tilde_expand.h: Rename include guard.
5916         * common/gdb_sys_time.h: Rename include guard.
5917         * common/gdb_string_view.h: Rename include guard.
5918         * common/gdb_splay_tree.h: Rename include guard.
5919         * common/gdb_setjmp.h: Rename include guard.
5920         * common/gdb_ref_ptr.h: Rename include guard.
5921         * common/gdb_optional.h: Rename include guard.
5922         * common/gdb_locale.h: Rename include guard.
5923         * common/gdb_assert.h: Rename include guard.
5924         * common/filtered-iterator.h: Rename include guard.
5925         * common/filestuff.h: Rename include guard.
5926         * common/fileio.h: Rename include guard.
5927         * common/environ.h: Rename include guard.
5928         * common/common-utils.h: Rename include guard.
5929         * common/common-types.h: Rename include guard.
5930         * common/common-regcache.h: Rename include guard.
5931         * common/common-inferior.h: Rename include guard.
5932         * common/common-gdbthread.h: Rename include guard.
5933         * common/common-exceptions.h: Rename include guard.
5934         * common/common-defs.h: Rename include guard.
5935         * common/common-debug.h: Rename include guard.
5936         * common/cleanups.h: Rename include guard.
5937         * common/buffer.h: Rename include guard.
5938         * common/btrace-common.h: Rename include guard.
5939         * common/break-common.h: Rename include guard.
5940         * cli/cli-utils.h: Rename include guard.
5941         * cli/cli-style.h: Rename include guard.
5942         * cli/cli-setshow.h: Rename include guard.
5943         * cli/cli-script.h: Rename include guard.
5944         * cli/cli-interp.h: Rename include guard.
5945         * cli/cli-decode.h: Rename include guard.
5946         * cli/cli-cmds.h: Rename include guard.
5947         * charset-list.h: Add include guard.
5948         * buildsym-legacy.h: Rename include guard.
5949         * bfin-tdep.h: Add include guard.
5950         * ax.h: Rename include guard.
5951         * arm-linux-tdep.h: Add include guard.
5952         * arm-fbsd-tdep.h: Add include guard.
5953         * arch/xtensa.h: Rename include guard.
5954         * arch/tic6x.h: Add include guard.
5955         * arch/i386.h: Add include guard.
5956         * arch/arm.h: Rename include guard.
5957         * arch/arm-linux.h: Rename include guard.
5958         * arch/arm-get-next-pcs.h: Rename include guard.
5959         * arch/amd64.h: Add include guard.
5960         * arch/aarch64-insn.h: Rename include guard.
5961         * arch-utils.h: Rename include guard.
5962         * annotate.h: Add include guard.
5963         * amd64-darwin-tdep.h: Rename include guard.
5964         * aarch64-linux-tdep.h: Add include guard.
5965         * aarch64-fbsd-tdep.h: Add include guard.
5966         * aarch32-linux-nat.h: Add include guard.
5967
5968 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5969
5970         * macrotab.c (macro_define_internal): New function that
5971         factorizes macro_define_object_internal and macro_define_function
5972         code.
5973         (macro_define_object_internal): Use macro_define_internal.
5974         (macro_define_function): Likewise.
5975
5976 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5977
5978         * macrocmd.c (extract_identifier): Return
5979         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5980         callers.
5981
5982 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5983
5984         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5985
5986 2019-02-05  Tom Tromey  <tom@tromey.com>
5987
5988         * target.c (target_stack::unpush): Move assertion earlier.
5989
5990 2019-01-30  Tom Tromey  <tom@tromey.com>
5991
5992         PR python/23615:
5993         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5994         (gdbpy_parse_and_eval): Likewise.
5995         * python/python-internal.h (gdbpy_allow_threads): New class.
5996
5997 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5998
5999         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6000         (aarch64_fbsd_fpregmap): Move earlier.
6001         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6002         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6003         instead of individual calls to trad_frame_set_reg_addr.
6004         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6005         earlier.
6006         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6007         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6008         instead of individual calls to trad_frame_set_reg_addr.
6009
6010 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6011
6012         * CONTRIBUTE: Replace contribution list with wiki link.
6013
6014 2019-01-25  Tom Tromey  <tom@tromey.com>
6015
6016         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6017
6018 2019-01-25  Tom Tromey  <tom@tromey.com>
6019
6020         * xtensa-linux-nat.c: Fix common/ includes.
6021         * xml-support.h: Fix common/ includes.
6022         * xml-support.c: Fix common/ includes.
6023         * x86-linux-nat.c: Fix common/ includes.
6024         * windows-nat.c: Fix common/ includes.
6025         * varobj.h: Fix common/ includes.
6026         * varobj.c: Fix common/ includes.
6027         * value.c: Fix common/ includes.
6028         * valops.c: Fix common/ includes.
6029         * utils.c: Fix common/ includes.
6030         * unittests/xml-utils-selftests.c: Fix common/ includes.
6031         * unittests/utils-selftests.c: Fix common/ includes.
6032         * unittests/unpack-selftests.c: Fix common/ includes.
6033         * unittests/tracepoint-selftests.c: Fix common/ includes.
6034         * unittests/style-selftests.c: Fix common/ includes.
6035         * unittests/string_view-selftests.c: Fix common/ includes.
6036         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6037         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6038         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6039         * unittests/rsp-low-selftests.c: Fix common/ includes.
6040         * unittests/parse-connection-spec-selftests.c: Fix common/
6041         includes.
6042         * unittests/optional-selftests.c: Fix common/ includes.
6043         * unittests/offset-type-selftests.c: Fix common/ includes.
6044         * unittests/observable-selftests.c: Fix common/ includes.
6045         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6046         * unittests/memrange-selftests.c: Fix common/ includes.
6047         * unittests/memory-map-selftests.c: Fix common/ includes.
6048         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6049         * unittests/function-view-selftests.c: Fix common/ includes.
6050         * unittests/environ-selftests.c: Fix common/ includes.
6051         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6052         * unittests/common-utils-selftests.c: Fix common/ includes.
6053         * unittests/cli-utils-selftests.c: Fix common/ includes.
6054         * unittests/array-view-selftests.c: Fix common/ includes.
6055         * ui-file.c: Fix common/ includes.
6056         * tui/tui-io.c: Fix common/ includes.
6057         * tracepoint.h: Fix common/ includes.
6058         * tracepoint.c: Fix common/ includes.
6059         * tracefile-tfile.c: Fix common/ includes.
6060         * top.h: Fix common/ includes.
6061         * top.c: Fix common/ includes.
6062         * thread.c: Fix common/ includes.
6063         * target/waitstatus.h: Fix common/ includes.
6064         * target/waitstatus.c: Fix common/ includes.
6065         * target.h: Fix common/ includes.
6066         * target.c: Fix common/ includes.
6067         * target-memory.c: Fix common/ includes.
6068         * target-descriptions.c: Fix common/ includes.
6069         * symtab.h: Fix common/ includes.
6070         * symfile.c: Fix common/ includes.
6071         * stap-probe.c: Fix common/ includes.
6072         * spu-linux-nat.c: Fix common/ includes.
6073         * sparc-nat.c: Fix common/ includes.
6074         * source.c: Fix common/ includes.
6075         * solib.c: Fix common/ includes.
6076         * solib-target.c: Fix common/ includes.
6077         * ser-unix.c: Fix common/ includes.
6078         * ser-tcp.c: Fix common/ includes.
6079         * ser-pipe.c: Fix common/ includes.
6080         * ser-base.c: Fix common/ includes.
6081         * selftest-arch.c: Fix common/ includes.
6082         * s12z-tdep.c: Fix common/ includes.
6083         * rust-exp.y: Fix common/ includes.
6084         * rs6000-aix-tdep.c: Fix common/ includes.
6085         * riscv-tdep.c: Fix common/ includes.
6086         * remote.c: Fix common/ includes.
6087         * remote-notif.h: Fix common/ includes.
6088         * remote-fileio.h: Fix common/ includes.
6089         * remote-fileio.c: Fix common/ includes.
6090         * regcache.h: Fix common/ includes.
6091         * regcache.c: Fix common/ includes.
6092         * record-btrace.c: Fix common/ includes.
6093         * python/python.c: Fix common/ includes.
6094         * python/py-type.c: Fix common/ includes.
6095         * python/py-inferior.c: Fix common/ includes.
6096         * progspace.h: Fix common/ includes.
6097         * producer.c: Fix common/ includes.
6098         * procfs.c: Fix common/ includes.
6099         * proc-api.c: Fix common/ includes.
6100         * printcmd.c: Fix common/ includes.
6101         * ppc-linux-nat.c: Fix common/ includes.
6102         * parser-defs.h: Fix common/ includes.
6103         * osdata.c: Fix common/ includes.
6104         * obsd-nat.c: Fix common/ includes.
6105         * nat/x86-linux.c: Fix common/ includes.
6106         * nat/x86-linux-dregs.c: Fix common/ includes.
6107         * nat/x86-dregs.h: Fix common/ includes.
6108         * nat/x86-dregs.c: Fix common/ includes.
6109         * nat/ppc-linux.c: Fix common/ includes.
6110         * nat/mips-linux-watch.h: Fix common/ includes.
6111         * nat/mips-linux-watch.c: Fix common/ includes.
6112         * nat/linux-waitpid.c: Fix common/ includes.
6113         * nat/linux-ptrace.h: Fix common/ includes.
6114         * nat/linux-ptrace.c: Fix common/ includes.
6115         * nat/linux-procfs.c: Fix common/ includes.
6116         * nat/linux-personality.c: Fix common/ includes.
6117         * nat/linux-osdata.c: Fix common/ includes.
6118         * nat/linux-namespaces.c: Fix common/ includes.
6119         * nat/linux-btrace.h: Fix common/ includes.
6120         * nat/linux-btrace.c: Fix common/ includes.
6121         * nat/fork-inferior.c: Fix common/ includes.
6122         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6123         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6124         * nat/aarch64-linux.c: Fix common/ includes.
6125         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6126         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6127         * namespace.h: Fix common/ includes.
6128         * mips-linux-tdep.c: Fix common/ includes.
6129         * minsyms.c: Fix common/ includes.
6130         * mi/mi-parse.h: Fix common/ includes.
6131         * mi/mi-main.c: Fix common/ includes.
6132         * mi/mi-cmd-env.c: Fix common/ includes.
6133         * memrange.h: Fix common/ includes.
6134         * memattr.c: Fix common/ includes.
6135         * maint.h: Fix common/ includes.
6136         * maint.c: Fix common/ includes.
6137         * main.c: Fix common/ includes.
6138         * machoread.c: Fix common/ includes.
6139         * location.c: Fix common/ includes.
6140         * linux-thread-db.c: Fix common/ includes.
6141         * linux-nat.c: Fix common/ includes.
6142         * linux-fork.c: Fix common/ includes.
6143         * inline-frame.c: Fix common/ includes.
6144         * infrun.c: Fix common/ includes.
6145         * inflow.c: Fix common/ includes.
6146         * inferior.h: Fix common/ includes.
6147         * inferior.c: Fix common/ includes.
6148         * infcmd.c: Fix common/ includes.
6149         * inf-ptrace.c: Fix common/ includes.
6150         * inf-child.c: Fix common/ includes.
6151         * ia64-linux-nat.c: Fix common/ includes.
6152         * i387-tdep.c: Fix common/ includes.
6153         * i386-tdep.c: Fix common/ includes.
6154         * i386-linux-tdep.c: Fix common/ includes.
6155         * i386-linux-nat.c: Fix common/ includes.
6156         * i386-go32-tdep.c: Fix common/ includes.
6157         * i386-fbsd-tdep.c: Fix common/ includes.
6158         * i386-fbsd-nat.c: Fix common/ includes.
6159         * guile/scm-type.c: Fix common/ includes.
6160         * guile/guile.c: Fix common/ includes.
6161         * go32-nat.c: Fix common/ includes.
6162         * gnu-nat.c: Fix common/ includes.
6163         * gdbthread.h: Fix common/ includes.
6164         * gdbarch-selftests.c: Fix common/ includes.
6165         * gdb_usleep.c: Fix common/ includes.
6166         * gdb_select.h: Fix common/ includes.
6167         * gdb_bfd.c: Fix common/ includes.
6168         * gcore.c: Fix common/ includes.
6169         * fork-child.c: Fix common/ includes.
6170         * findvar.c: Fix common/ includes.
6171         * fbsd-nat.c: Fix common/ includes.
6172         * event-top.c: Fix common/ includes.
6173         * event-loop.c: Fix common/ includes.
6174         * dwarf2read.c: Fix common/ includes.
6175         * dwarf2loc.c: Fix common/ includes.
6176         * dwarf2-frame.c: Fix common/ includes.
6177         * dwarf-index-cache.c: Fix common/ includes.
6178         * dtrace-probe.c: Fix common/ includes.
6179         * disasm-selftests.c: Fix common/ includes.
6180         * defs.h: Fix common/ includes.
6181         * csky-tdep.c: Fix common/ includes.
6182         * cp-valprint.c: Fix common/ includes.
6183         * cp-support.h: Fix common/ includes.
6184         * cp-support.c: Fix common/ includes.
6185         * corelow.c: Fix common/ includes.
6186         * completer.h: Fix common/ includes.
6187         * completer.c: Fix common/ includes.
6188         * compile/compile.c: Fix common/ includes.
6189         * compile/compile-loc2c.c: Fix common/ includes.
6190         * compile/compile-cplus-types.c: Fix common/ includes.
6191         * compile/compile-cplus-symbols.c: Fix common/ includes.
6192         * command.h: Fix common/ includes.
6193         * cli/cli-dump.c: Fix common/ includes.
6194         * cli/cli-cmds.c: Fix common/ includes.
6195         * charset.c: Fix common/ includes.
6196         * build-id.c: Fix common/ includes.
6197         * btrace.h: Fix common/ includes.
6198         * btrace.c: Fix common/ includes.
6199         * breakpoint.h: Fix common/ includes.
6200         * breakpoint.c: Fix common/ includes.
6201         * ax.h:
6202         (enum agent_op): Fix common/ includes.
6203         * ax-general.c (struct aop_map): Fix common/ includes.
6204         * ax-gdb.c: Fix common/ includes.
6205         * auxv.c: Fix common/ includes.
6206         * auto-load.c: Fix common/ includes.
6207         * arm-tdep.c: Fix common/ includes.
6208         * arch/riscv.c: Fix common/ includes.
6209         * arch/ppc-linux-common.c: Fix common/ includes.
6210         * arch/i386.c: Fix common/ includes.
6211         * arch/arm.c: Fix common/ includes.
6212         * arch/arm-linux.c: Fix common/ includes.
6213         * arch/arm-get-next-pcs.c: Fix common/ includes.
6214         * arch/amd64.c: Fix common/ includes.
6215         * arch/aarch64.c: Fix common/ includes.
6216         * arch/aarch64-insn.c: Fix common/ includes.
6217         * arch-utils.c: Fix common/ includes.
6218         * amd64-windows-tdep.c: Fix common/ includes.
6219         * amd64-tdep.c: Fix common/ includes.
6220         * amd64-sol2-tdep.c: Fix common/ includes.
6221         * amd64-obsd-tdep.c: Fix common/ includes.
6222         * amd64-nbsd-tdep.c: Fix common/ includes.
6223         * amd64-linux-tdep.c: Fix common/ includes.
6224         * amd64-linux-nat.c: Fix common/ includes.
6225         * amd64-fbsd-tdep.c: Fix common/ includes.
6226         * amd64-fbsd-nat.c: Fix common/ includes.
6227         * amd64-dicos-tdep.c: Fix common/ includes.
6228         * amd64-darwin-tdep.c: Fix common/ includes.
6229         * agent.c: Fix common/ includes.
6230         * ada-lang.h: Fix common/ includes.
6231         * ada-lang.c: Fix common/ includes.
6232         * aarch64-tdep.c: Fix common/ includes.
6233
6234 2019-01-25  Tom Tromey  <tom@tromey.com>
6235
6236         * common/create-version.sh: Use common/version.h.
6237
6238 2019-01-24  Pedro Alves  <palves@redhat.com>
6239
6240         * infrun.c (signal_stop, signal_print, signal_program)
6241         (signal_catch, signal_pass): Now arrays instead of pointers.
6242         (update_signals_program_target, do_target_resume)
6243         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6244         * linux-nat.c (linux_nat_target::pass_signals)
6245         (linux_nat_target::create_inferior, linux_nat_target::attach):
6246         Adjust.
6247         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6248         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6249         * procfs.c (procfs_target::pass_signals): Adjust.
6250         * record-full.c (record_full_target::resume): Adjust.
6251         * remote.c (remote_target::pass_signals)
6252         (remote_target::program_signals): Adjust.
6253         * target-debug.h (target_debug_print_signals): Now takes a
6254         gdb::array_view as parameter.  Adjust.
6255         * target.h (target_ops) <pass_signals, program_signals>: Replace
6256         pointer and length parameters with gdb::array_view.
6257         (target_pass_signals, target_program_signals): Likewise.
6258         * target-delegates.c: Regenerate.
6259
6260 2019-01-24  Pedro Alves  <palves@redhat.com>
6261
6262         * common/forward-scope-exit.h
6263         (forward_scope_exit::forward_scope_exit): Pass arguments to
6264         m_bind_function directly, instead of creating a std::bind and
6265         copying that.
6266
6267 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6268
6269         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6270         for static members.
6271         (pass_in_v_vfp_candidate): Likewise.
6272
6273 2019-01-23  Tom Tromey  <tom@tromey.com>
6274             Pedro Alves  <palves@redhat.com>
6275
6276         * regcache.c (class regcache_invalidator): Remove.
6277         (regcache::raw_write): Use make_scope_exit.
6278
6279 2019-01-23  Tom Tromey  <tom@tromey.com>
6280
6281         * ui-out.h (class ui_out_emit_type): Update comment.
6282
6283 2019-01-23  Tom Tromey  <tom@tromey.com>
6284
6285         * infrun.c (fetch_inferior_event): Update comment.
6286
6287 2019-01-23  Tom Tromey  <tom@tromey.com>
6288             Pedro Alves  <palves@redhat.com>
6289
6290         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6291         parameter.
6292         (fetch_inferior_event): Use SCOPE_EXIT.
6293
6294
6295 2019-01-23  Tom Tromey  <tom@tromey.com>
6296             Pedro Alves  <palves@redhat.com>
6297
6298         * infrun.c (disable_thread_events): Delete.
6299         (stop_all_threads): Use SCOPE_EXIT.
6300
6301 2019-01-23  Tom Tromey  <tom@tromey.com>
6302             Pedro Alves  <palves@redhat.com>
6303
6304         * symfile.c: Include forward-scope-exit.h.
6305         (clear_symtab_users_cleanup): Replace forward declaration with
6306         a FORWARD_SCOPE_EXIT.
6307         (syms_from_objfile_1): Use the forward_scope_exit and
6308         gdb::optional instead of cleanup_function.
6309         (reread_symbols): Use the forward_scope_exit instead of
6310         cleanup_function.
6311         (clear_symtab_users_cleanup): Remove function.
6312
6313 2019-01-23  Tom Tromey  <tom@tromey.com>
6314             Pedro Alves  <palves@redhat.com>
6315
6316         * linux-nat.c: Include scope-exit.h.
6317         (cleanup_target_stop): Remove.
6318         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6319         SCOPE_EXIT.
6320
6321 2019-01-23  Tom Tromey  <tom@tromey.com>
6322             Pedro Alves  <palves@redhat.com>
6323
6324         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6325         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6326
6327 2019-01-23  Tom Tromey  <tom@tromey.com>
6328             Andrew Burgess  <andrew.burgess@embecosm.com>
6329             Pedro Alves  <palves@redhat.com>
6330
6331         * infrun.c (fetch_inferior_event): Use scope_exit.
6332         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6333         * top.c (execute_command): Use scope_exit.
6334         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6335         * utils.c (do_bpstat_clear_actions_cleanup)
6336         (make_bpstat_clear_actions_cleanup): Remove.
6337
6338 2019-01-23  Tom Tromey  <tom@tromey.com>
6339             Pedro Alves  <palves@redhat.com>
6340
6341         * infrun.c: Include "common/scope-exit.h"
6342         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6343         (wait_for_inferior): Use SCOPE_EXIT.
6344         (fetch_inferior_event): Use scope_exit.
6345
6346 2019-01-23  Tom Tromey  <tom@tromey.com>
6347             Pedro Alves  <palves@redhat.com>
6348
6349         * breakpoint.c (create_breakpoint): Remove cleanup.
6350
6351 2019-01-23  Tom Tromey  <tom@tromey.com>
6352             Andrew Burgess  <andrew.burgess@embecosm.com>
6353             Pedro Alves  <palves@redhat.com>
6354
6355 2019-01-23  Pedro Alves  <palves@redhat.com>
6356
6357         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6358
6359 2019-01-23  Pedro Alves  <palves@redhat.com>
6360             Andrew Burgess  <andrew.burgess@embecosm.com>
6361
6362         * gdbthread.h: Include "common/forward-scope-exit.h".
6363         (scoped_finish_thread_state): Redefine custom class in terms of
6364         forward_scope_exit.
6365
6366 2019-01-23  Pedro Alves  <palves@redhat.com>
6367             Andrew Burgess  <andrew.burgess@embecosm.com>
6368
6369         * common/forward-scope-exit.h: New file.
6370
6371 2019-01-23  Pedro Alves  <palves@redhat.com>
6372             Andrew Burgess  <andrew.burgess@embecosm.com>
6373             Tom Tromey  <tom@tromey.com>
6374
6375         * common/scope-exit.h: New file.
6376
6377 2019-01-23  Pedro Alves  <palves@redhat.com>
6378
6379         * common/preprocessor.h (ESC): Rename to ...
6380         (ESC_PARENS): ... this.
6381         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6382         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6383
6384 2019-01-23  Tom Tromey  <tom@tromey.com>
6385
6386         * language.h (class scoped_switch_to_sym_language_if_auto):
6387         Initialize m_lang in both cases.
6388
6389 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6390
6391         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6392         with XCNEW.
6393
6394 2019-01-22  Tom Tromey  <tom@tromey.com>
6395
6396         * corelow.c: Do not include sys/file.h.
6397
6398 2019-01-22  Tom Tromey  <tom@tromey.com>
6399
6400         * tui/tui-wingeneral.h: Include gdb_curses.h.
6401
6402 2019-01-22  Tom Tromey  <tom@tromey.com>
6403
6404         * source-cache.h (class source_cache) <get_source_lines,
6405         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6406
6407 2019-01-22  Tom Tromey  <tom@tromey.com>
6408
6409         * remote-fileio.h (struct remote_target): Declare.
6410
6411 2019-01-22  Tom Tromey  <tom@tromey.com>
6412
6413         * python/py-arch.c: Do not include py-ref.h.
6414         * python/py-bpevent.c: Do not include py-ref.h.
6415         * python/py-cmd.c: Do not include py-ref.h.
6416         * python/py-continueevent.c: Do not include py-ref.h.
6417         * python/py-event.h: Do not include py-ref.h.
6418         * python/py-evtregistry.c: Do not include py-ref.h.
6419         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6420         * python/py-frame.c: Do not include py-ref.h.
6421         * python/py-framefilter.c: Do not include py-ref.h.
6422         * python/py-function.c: Do not include py-ref.h.
6423         * python/py-infevents.c: Do not include py-ref.h.
6424         * python/py-linetable.c: Do not include py-ref.h.
6425         * python/py-objfile.c: Do not include py-ref.h.
6426         * python/py-param.c: Do not include py-ref.h.
6427         * python/py-prettyprint.c: Do not include py-ref.h.
6428         * python/py-progspace.c: Do not include py-ref.h.
6429         * python/py-symbol.c: Do not include py-ref.h.
6430         * python/py-symtab.c: Do not include py-ref.h.
6431         * python/py-type.c: Do not include py-ref.h.
6432         * python/py-unwind.c: Do not include py-ref.h.
6433         * python/py-utils.c: Do not include py-ref.h.
6434         * python/py-value.c: Do not include py-ref.h.
6435         * python/py-varobj.c: Do not include py-ref.h.
6436         * python/py-xmethods.c: Do not include py-ref.h.
6437         * python/python.c: Do not include py-ref.h.
6438         * varobj.c: Do not include py-ref.h.
6439
6440 2019-01-22  Tom Tromey  <tom@tromey.com>
6441
6442         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6443         keyword for bcache.
6444
6445 2019-01-22  Tom Tromey  <tom@tromey.com>
6446
6447         * compile/compile-cplus-types.c: Remove a comment by #include.
6448
6449 2019-01-22  Tom Tromey  <tom@tromey.com>
6450
6451         * compile/gcc-c-plugin.h: Include compile-internal.h.
6452
6453 2019-01-22  Tom Tromey  <tom@tromey.com>
6454
6455         * stabsread.c (EXTERN): Do not define.
6456         (symnum, next_symbol_text_func, processing_gcc_compilation)
6457         (within_function, global_sym_chain, global_stabs)
6458         (previous_stab_code, this_object_header_files)
6459         (n_this_object_header_files)
6460         (n_allocated_this_object_header_files): Define.
6461         * stabsread.h (EXTERN): Never define.  Use "extern".
6462
6463 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6464
6465         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6466         history_value.
6467
6468 2019-01-21  Tom Tromey  <tom@tromey.com>
6469
6470         * ui-out.c: Fix includes.
6471         * tui/tui-source.c: Fix includes.
6472         * target.c: Fix includes.
6473         * remote.c: Fix includes.
6474         * regcache.c: Fix includes.
6475         * python/py-block.c: Fix includes.
6476         * printcmd.c: Fix includes.
6477         * or1k-tdep.c: Fix includes.
6478         * mi/mi-main.c: Fix includes.
6479         * m32r-tdep.c: Fix includes.
6480         * csky-tdep.c: Fix includes.
6481         * compile/compile-cplus-types.c: Fix includes.
6482         * cli/cli-interp.c: Fix includes.
6483
6484 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6485
6486         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6487         for padding.
6488
6489 2019-01-16  Tom Tromey  <tom@tromey.com>
6490
6491         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6492         earlier.
6493         (struct objfile) <msymbols_range>: Move from top level.
6494         <msymbols>: New method.
6495         (class objfile_msymbols): Remove.
6496         * symtab.c (default_collect_symbol_completion_matches_break_on):
6497         Update.
6498         * symmisc.c (dump_msymbols): Update.
6499         * stabsread.c (scan_file_globals): Update.
6500         * objc-lang.c (info_selectors_command, info_classes_command)
6501         (find_methods): Update.
6502         * minsyms.c (find_solib_trampoline_target): Update.
6503         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6504         * coffread.c (coff_symfile_read): Update.
6505         * ada-lang.c (ada_lookup_simple_minsym)
6506         (ada_collect_symbol_completion_matches): Update.
6507
6508 2019-01-16  Tom Tromey  <tom@tromey.com>
6509
6510         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6511         type.  Remove no-argument constructor.
6512         <iterator::operator++>: Simplify.
6513         <begin>: Update.
6514         <end>: Use minimal_symbol_count.
6515
6516 2019-01-16  Tom Tromey  <tom@tromey.com>
6517
6518         * objfiles.h (struct objfile) <psymtabs>: New method.
6519         (class objfile_psymtabs): Remove.
6520         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6521         typedef.
6522         <range>: New method.
6523         (require_partial_symbols): Change return type.
6524         * psymtab.c (require_partial_symbols)
6525         (psym_expand_symtabs_matching): Update.
6526         * mdebugread.c (parse_partial_symbols): Update.
6527         * dbxread.c (dbx_end_psymtab): Update.
6528
6529 2019-01-15  Tom Tromey  <tom@tromey.com>
6530
6531         * symtab.c (lookup_objfile_from_block)
6532         (lookup_symbol_in_objfile_symtabs)
6533         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6534         (find_line_symtab, info_sources_command)
6535         (default_collect_symbol_completion_matches_break_on)
6536         (make_source_files_completion_list): Update.
6537         * symmisc.c (print_objfile_statistics, dump_objfile)
6538         (maintenance_print_symbols, maintenance_info_symtabs)
6539         (maintenance_check_symtabs, maintenance_info_line_tables):
6540         Update.
6541         * source.c (select_source_symtab)
6542         (forget_cached_source_info_for_objfile): Update.
6543         * objfiles.h (class objfile_compunits): Remove.
6544         (struct objfile) <compunits_range>: New typedef.
6545         (compunits): New method.
6546         * objfiles.c (objfile_relocate1): Update.
6547         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6548         * maint.c (count_symtabs_and_blocks): Update.
6549         * linespec.c (iterate_over_all_matching_symtabs): Update.
6550         * cp-support.c (add_symbol_overload_list_qualified): Update.
6551         * coffread.c (coff_symtab_read): Update.
6552         * ada-lang.c (add_nonlocal_symbols)
6553         (ada_collect_symbol_completion_matches)
6554         (ada_add_global_exceptions): Update.
6555
6556 2019-01-15  Tom Tromey  <tom@tromey.com>
6557
6558         * progspace.h (program_space) <objfiles_safe_range>: New
6559         typedef.
6560         <objfiles_safe>: New method.
6561         * objfiles.h (class all_objfiles_safe): Remove.
6562         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6563         * jit.c (jit_inferior_exit_hook): Update.
6564
6565 2019-01-17  Tom Tromey  <tom@tromey.com>
6566
6567         * progspace.h (program_space) <objfiles_range>: New typedef.
6568         <objfiles>: New method.
6569         <objfiles_head>: Rename from objfiles.
6570         (object_files): Update.
6571         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6572         * guile/scm-pretty-print.c
6573         (ppscm_find_pretty_printer_from_objfiles): Update.
6574         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6575         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6576         Update.
6577         * python/py-progspace.c (pspy_get_objfiles): Update.
6578         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6579         Update.
6580         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6581         (objfpy_lookup_objfile_by_build_id): Update.
6582         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6583         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6584         Update.
6585         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6586         (expand_symtab_containing_pc, lookup_objfile_from_block)
6587         (lookup_static_symbol, basic_lookup_transparent_type)
6588         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6589         (find_line_symtab, info_sources_command)
6590         (default_collect_symbol_completion_matches_break_on)
6591         (make_source_files_completion_list, find_main_name): Update.
6592         * symmisc.c (print_symbol_bcache_statistics)
6593         (print_objfile_statistics, maintenance_print_symbols)
6594         (maintenance_print_msymbols, maintenance_print_objfiles)
6595         (maintenance_info_symtabs, maintenance_check_symtabs)
6596         (maintenance_expand_symtabs, maintenance_info_line_tables):
6597         Update.
6598         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6599         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6600         (map_overlay_command, unmap_overlay_command)
6601         (simple_overlay_update, expand_symtabs_matching)
6602         (map_symbol_filenames): Update.
6603         * symfile-debug.c (set_debug_symfile): Update.
6604         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6605         Update.
6606         * source.c (select_source_symtab, forget_cached_source_info):
6607         Update.
6608         * solib.c (solib_read_symbols): Update.
6609         * solib-spu.c (append_ocl_sos): Update.
6610         * psymtab.c (maintenance_print_psymbols)
6611         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6612         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6613         * printcmd.c (info_symbol_command): Update.
6614         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6615         Update.
6616         * objfiles.h (class all_objfiles): Remove.
6617         * objfiles.c (have_partial_symbols, have_full_symbols)
6618         (have_minimal_symbols, qsort_cmp, update_section_map)
6619         (shared_objfile_contains_address_p)
6620         (default_iterate_over_objfiles_in_search_order): Update.
6621         * objc-lang.c (info_selectors_command, info_classes_command)
6622         (find_methods): Update.
6623         * minsyms.c (find_solib_trampoline_target): Update.
6624         * maint.c (maintenance_info_sections)
6625         (maintenance_translate_address, count_symtabs_and_blocks):
6626         Update.
6627         * main.c (captured_main_1): Update.
6628         * linux-thread-db.c (try_thread_db_load_from_pdir)
6629         (has_libpthread): Update.
6630         * linespec.c (iterate_over_all_matching_symtabs)
6631         (search_minsyms_for_name): Update.
6632         * jit.c (jit_find_objf_with_entry_addr): Update.
6633         * hppa-tdep.c (find_unwind_entry)
6634         (hppa_lookup_stub_minimal_symbol): Update.
6635         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6636         Update.
6637         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6638         (elf_gnu_ifunc_resolve_by_got): Update.
6639         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6640         * dwarf-index-write.c (save_gdb_index_command): Update.
6641         * cp-support.c (add_symbol_overload_list_qualified): Update.
6642         * breakpoint.c (create_overlay_event_breakpoint)
6643         (create_longjmp_master_breakpoint)
6644         (create_std_terminate_master_breakpoint)
6645         (create_exception_master_breakpoint): Update.
6646         * blockframe.c (find_pc_partial_function): Update.
6647         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6648         (ada_collect_symbol_completion_matches)
6649         (ada_add_global_exceptions): Update.
6650
6651 2019-01-17  Tom Tromey  <tom@tromey.com>
6652
6653         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6654         declare VEC.
6655         (solib_target_parse_libraries): Change return type.
6656         (library_list_start_segment, library_list_start_section)
6657         (library_list_end_library, library_list_start_library); Update.
6658         (solib_target_free_library_list): Remove.
6659         (solib_target_parse_libraries): Remove cleanup.  Change return
6660         type.
6661         (solib_target_current_sos): Update.
6662
6663 2019-01-17  Tom Tromey  <tromey@bapiya>
6664
6665         * valprint.c: Replace "the the" with "the".
6666         * symtab.c: Replace "the the" with "the".
6667         * solib.c: Replace "the the" with "the".
6668         * solib-dsbt.c: Replace "the the" with "the".
6669         * linespec.c: Replace "the the" with "the".
6670         * dwarf2loc.h: Replace "the the" with "the".
6671         * amd64-windows-tdep.c: Replace "the the" with "the".
6672         * aarch64-tdep.c: Replace "the the" with "the".
6673
6674 2019-01-16  Keith Seitz  <keiths@redhat.com>
6675
6676         PR gdb/23773
6677         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6678         <builder>: Rename to ..
6679         <m_builder>: ... this and make private.
6680         (dwarf2_cu::get_builder): New method.  Change all users of
6681         `builder' to use this method.
6682         (dwarf2_start_symtab): Move to ...
6683         (dwarf2_cu::start_symtab): ... here.  Update all callers
6684         (setup_type_unit_groups): Move to ...
6685         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6686         callers.
6687         (dwarf2_cu::reset_builder): New method.
6688         (process_full_compunit, process_full_type_unit): Use
6689         dwarf2_cu::reset_builder.
6690         (follow_die_offset): Record the ancestor CU if it is different
6691         from the followed DIE's CU.
6692         (follow_die_sig_1): Likewise.
6693
6694 2019-01-15  Tom Tromey  <tom@tromey.com>
6695
6696         * remote.c (class remote_state) <buf>: Now a char_vector.
6697         <buf_size>: Remove.
6698         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6699         parameter.
6700         (remote_target::getpkt_or_notif_sane_1)
6701         (remote_target::getpkt_sane)
6702         (remote_target::getpkt_or_notif_sane): Likewise.
6703         (class remote_target) <putpkt>: New overload.
6704         (remote_target::read_frame): Change type of "buf_p".  Remove
6705         sizeof_p parameter.
6706         (packet_ok): New overload.
6707         (packet_check_result): New overload.
6708         Update all uses.
6709
6710 2019-01-14  Tom Tromey  <tom@tromey.com>
6711
6712         * remote-notif.c (handle_notification, remote_notif_ack)
6713         (remote_notif_parse): Make "buf" const.
6714         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6715         const.
6716         (remote_notif_parse, remote_notif_ack, handle_notification):
6717         Likewise.
6718         * remote.c (remote_notif_stop_parse): Make "buf" const.
6719         (remote_target::remote_parse_stop_reply): Make "buf" const.
6720         (remote_notif_stop_ack): Make "buf" const.
6721
6722 2019-01-14  Tom Tromey  <tom@tromey.com>
6723
6724         * remote.c (remote_console_output): Make parameter const.
6725
6726 2019-01-14  Tom Tromey  <tom@tromey.com>
6727
6728         * target-debug.h (target_debug_print_signals): Constify.
6729         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6730         * procfs.c (procfs_target::pass_signals): Update.
6731         * linux-nat.c (linux_nat_target::pass_signals): Update.
6732         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6733         * target-delegates.c: Rebuild.
6734         * remote.c (remote_target::program_signals): Update.
6735         (remote_target::pass_signals): Update.
6736         * target.c (target_pass_signals): Constify argument.
6737         (target_program_signals): Likewise.
6738         * target.h (struct target_ops) <pass_signals, program_signals>:
6739         Constify argument.
6740         (target_pass_signals, target_program_signals): Constify argument.
6741
6742 2019-01-14  Tom Tromey  <tom@tromey.com>
6743
6744         PR tui/28819:
6745         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6746
6747 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6748
6749         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6750         field.
6751         * rs6000-tdep.c: Include reggroups.h.
6752         (IS_V_ALIAS_PSEUDOREG): Define.
6753         (rs6000_register_name): Return names for the "vX" aliases.
6754         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6755         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6756         aliases.  Call default_register_reggroup_p for all other
6757         pseudo-registers.
6758         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6759         New functions.
6760         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6761         Handle "vX" aliases.
6762         (v_alias_pseudo_register_collect): New function.
6763         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6764         (rs6000_gdbarch_init): Initialize "vX" aliases as
6765         pseudo-registers.  Restore registration of
6766         rs6000_pseudo_register_reggroup_p with
6767         set_tdesc_pseudo_register_reggroup_p.
6768
6769 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6770
6771         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6772         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6773         set_gdbarch_num_pseudo_regs.
6774
6775 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6776
6777         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6778         Remove arg prefixname, add do_set and do_show.
6779         Add member functions set_list and show_list.
6780         * cli/cli-style.c (class cli_style_option): Update accordingly.
6781         (style_set_list): Move to file scope.
6782         (style_show_list): Likewise.
6783         (set_style): Call help_list.
6784         (show_style): Call cmd_show_list.
6785         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6786         Update to use the new macro.
6787
6788 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6789
6790         * ada-lang.c (_initialize_ada_language): Expand the help text
6791         for the "catch exception" command.
6792
6793 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6794
6795         * symtab.c (matching_obj_sections): Initialize obj,
6796         declare it closer to its usage.
6797
6798 2019-01-10  Tom Tromey  <tom@tromey.com>
6799
6800         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6801         (basic_inf_threads_range): Remove.
6802         (inf_threads_range, inf_non_exited_threads_range)
6803         (safe_inf_threads_range): Use next_adapter.
6804
6805 2019-01-10  Keith Seitz  <keiths@redhat.com>
6806
6807         PR gdb/23712
6808         PR symtab/23010
6809         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6810         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6811
6812 2019-01-10  Keith Seitz  <keiths@redhat.com>
6813
6814         PR gdb/23712
6815         PR symtab/23010
6816         * dictionary.c (pending_to_vector): Remove.
6817         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6818         Remove _1 suffix, replacing functions of the same name.  Update
6819         all callers.
6820         (dict_create_hashed, dict_create_hashed_expandable)
6821         (dict_create_linear, dict_create_linear_expandable, dict_free)
6822         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6823         Make functions static.
6824
6825 2019-01-10  Keith Seitz  <keiths@redhat.com>
6826
6827         PR gdb/23712
6828         PR symtab/23010
6829         * dictionary.h (struct dictionary): Replace declaration with
6830         multidictionary.
6831         (dict_create_hashed, dict_create_hashed_expandable)
6832         (dict_create_linear, dict_create_linear_expandable)
6833         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6834         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6835         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6836         taking multidictionary argument.
6837         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6838         * block.h (struct block) <dict>: Change to multidictionary
6839         and rename `multidict'.
6840         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6841         symmisc.c: Update all dictionary references to multidictionary.
6842
6843 2019-01-10  Keith Seitz  <keiths@redhat.com>
6844
6845         PR gdb/23712
6846         PR symtab/23010
6847         * dictionary.c: Include unordered_map.
6848         (pending_to_vector): New function.
6849         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6850         Rewrite the non-"_1" functions to take vector instead
6851         of linked list.
6852         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6853         "new" _1 versions of the same name.
6854         (multidictionary): Define.
6855         (std::hash<enum language): New definition.
6856         (collate_pending_symbols_by_language, mdict_create_hashed)
6857         (mdict_create_hashed_expandable, mdict_create_linear)
6858         (mdict_create_linear_expandable, mdict_free)
6859         (find_language_dictionary, create_new_language_dictionary)
6860         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6861         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6862         (mdict_size, mdict_empty): New functions.
6863         * dictionary.h (mdict_iterator): Define.
6864
6865 2019-01-10  Pedro Alves  <palves@redhat.com>
6866
6867         * breakpoint.c (read_uploaded_action)
6868         (create_tracepoint_from_upload): Adjust to use
6869         gdb::unique_xmalloc_ptr.
6870         * ctf.c (ctf_write_uploaded_tp):
6871         (SET_ARRAY_FIELD): Use emplace_back.
6872         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6873         * tracefile-tfile.c (tfile_write_uploaded_tp):
6874         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6875         gdb::unique_xmalloc_ptr.
6876         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6877         at_string, cond_string, cmd_strings>: Replace char pointers
6878         with gdb::unique_xmalloc_ptr.
6879
6880 2019-01-10  Pedro Alves  <palves@redhat.com>
6881
6882         * solib-target.c (library_list_start_library): Don't xstrdup name.
6883
6884 2019-01-10  Pedro Alves  <palves@redhat.com>
6885
6886         * mdebugread.c (parse_partial_symbols): Use
6887         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6888
6889 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6890
6891         * linux-fork.c (scoped_switch_fork_info)
6892         <~scoped_switch_fork_info>: Fix incorrect variable name.
6893
6894 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * linux-fork.c (scoped_switch_fork_info)
6897         <scoped_switch_fork_info>: Make explicit.
6898         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6899
6900 2019-01-10  Tom Tromey  <tom@tromey.com>
6901
6902         * objfiles.h (objfile::reset_psymtabs): Update.
6903         * objfiles.c (objfile::objfile): Update.
6904         * psymtab.h (psymtab_storage::obstack): Update.
6905         (psymtab_storage::m_obstack): Use gdb::optional.
6906         (class psymtab_storage): Update comment.  Remove objfile
6907         parameter.
6908         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6909
6910 2019-01-10  Tom Tromey  <tom@tromey.com>
6911
6912         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6913         <free_psymtabs>: Now private.
6914         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6915         (allocate_psymtab): Use new method.
6916
6917 2019-01-10  Tom Tromey  <tom@tromey.com>
6918
6919         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6920         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6921         * mdebugread.c (parse_partial_symbols): Use
6922         allocate_dependencies.
6923         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6924         allocate_dependencies.
6925         (process_psymtab_comp_unit_reader)
6926         (build_type_psymtab_dependencies): Likewise.
6927         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6928
6929 2019-01-10  Tom Tromey  <tom@tromey.com>
6930
6931         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6932         PSYMBOL_SET_LANGUAGE.
6933         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6934
6935 2019-01-10  Tom Tromey  <tom@tromey.com>
6936
6937         * psymtab.h (psymtab_storage::obstack): New method.
6938         <m_obstack>: Rename from obstack; now private.
6939         * psymtab.c (psymtab_storage): Update.
6940         * dwarf2read.c (create_addrmap_from_index)
6941         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6942         Update.
6943
6944 2019-01-10  Tom Tromey  <tom@tromey.com>
6945
6946         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6947         * objfiles.h (objfile::reset_psymtabs): New method.
6948
6949 2019-01-10  Tom Tromey  <tom@tromey.com>
6950
6951         * symmisc.c (print_symbol_bcache_statistics): Update.
6952         (print_objfile_statistics): Update.
6953         * symfile.c (reread_symbols): Update.
6954         * psymtab.h (class psymtab_storage): New.
6955         * psymtab.c (psymtab_storage): New constructor.
6956         (~psymtab_storage): New destructor.
6957         (require_partial_symbols): Update.
6958         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6959         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6960         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6961         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6962         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6963         (start_psymtab_common, end_psymtab_common)
6964         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6965         (allocate_psymtab): Update.
6966         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6967         Update.
6968         (dump_psymtab_addrmap, maintenance_print_psymbols)
6969         (maintenance_check_psymtabs): Update.
6970         (class objfile_psymtabs): Move to objfiles.h.
6971         * psympriv.h (discard_psymtab): Now inline.
6972         (psymtab_discarder::psymtab_discarder): Update.
6973         (psymtab_discarder::~psymtab_discarder): Update.
6974         (ALL_OBJFILE_PSYMTABS): Rewrite.
6975         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6976         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6977         Remove fields.
6978         <partial_symtabs>: New field.
6979         (class objfile_psymtabs): Move from psymtab.h.  Update.
6980         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6981         psymbol_cache.
6982         (objfile::~objfile): Don't destroy psymbol_cache.
6983         * mdebugread.c (parse_partial_symbols): Update.
6984         * dwarf2read.c (create_addrmap_from_index)
6985         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6986         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6987         (add_partial_subprogram, dwarf2_ranges_read): Update.
6988         * dwarf-index-write.c (write_address_map)
6989         (write_one_signatured_type, recursively_write_psymbols)
6990         (class debug_names, class debug_names, write_psymtabs_to_index):
6991         Update.
6992
6993 2019-01-10  Tom Tromey  <tom@tromey.com>
6994
6995         * symtab.h (SYMBOL_SET_NAMES): Update.
6996         (symbol_set_names): Update.
6997         (MSYMBOL_SET_NAMES): Update.
6998         * symtab.c (symbol_set_names): Change argument to be an
6999         objfile_per_bfd_storage.
7000         * psymtab.c (add_psymbol_to_bcache): Update.
7001         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7002
7003 2019-01-10  Tom Tromey  <tom@tromey.com>
7004
7005         * symtab.c (create_demangled_names_hash): Change argument to be an
7006         objfile_per_bfd_storage.
7007         (symbol_set_names): Update.
7008
7009 2019-01-10  Tom Tromey  <tom@tromey.com>
7010
7011         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7012         init_psymbol_list.
7013         * psymtab.c (init_psymbol_list): Do nothing if already called.
7014         * psympriv.h (init_psymbol_list): Add comment.
7015         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7016         init_psymbol_list.
7017         * dbxread.c (dbx_symfile_read): Unconditionally call
7018         init_psymbol_list.
7019
7020 2019-01-10  Tom Tromey  <tom@tromey.com>
7021
7022         * xcoffread.c (scan_xcoff_symtab): Update.
7023         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7024         "where".
7025         * mdebugread.c (parse_partial_symbols)
7026         (handle_psymbol_enumerators): Update.
7027         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7028         * dbxread.c (read_dbx_symtab): Update.
7029         * psympriv.h (psymbol_placement): New enum.
7030         (add_psymbol_to_list): Update.
7031
7032 2019-01-10  Tom Tromey  <tom@tromey.com>
7033
7034         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7035         static_psymbols parameters.
7036         (scan_xcoff_symtab): Update.
7037         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7038         static_psymbols parameters.
7039         * psympriv.h (start_psymtab_common): Update.
7040         * mdebugread.c (parse_partial_symbols): Update.
7041         * dwarf2read.c (create_partial_symtab): Update.
7042         * dbxread.c (read_dbx_symtab): Update.
7043         (start_psymtab): Remove global_psymbols and static_psymbols
7044         parameters.
7045
7046 2019-01-10  Tom Tromey  <tom@tromey.com>
7047
7048         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7049         * psymtab.c (allocate_psymtab): Add comment.
7050         * psympriv.h (allocate_psymtab): Add comment.
7051         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7052         initializations.
7053         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7054
7055 2019-01-10  Tom Tromey  <tom@tromey.com>
7056
7057         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7058         Don't declare.
7059         * mipsread.c: Include mdebugread.h.
7060         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7061         Declare.
7062         * elfread.c: Include mdebugread.h.
7063
7064 2019-01-09  Tom Tromey  <tom@tromey.com>
7065
7066         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7067         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7068         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7069         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7070         (psym_lookup_symbol, psym_find_last_source_symtab)
7071         (psym_forget_cached_source_info, psym_print_stats)
7072         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7073         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7074         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7075         (psym_find_compunit_symtab_by_address)
7076         (maintenance_print_psymbols, maintenance_info_psymtabs)
7077         (maintenance_check_psymtabs): Use ranged for.
7078         * psymtab.h (class objfile_psymtabs): New.
7079         (require_partial_symbols): Return objfile_psymtabs.
7080         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7081
7082 2019-01-09  Tom Tromey  <tom@tromey.com>
7083
7084         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7085         (find_pc_mapped_section, list_overlays_command)
7086         (map_overlay_command, unmap_overlay_command)
7087         (simple_overlay_update): Use all_objfiles.
7088         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7089         * printcmd.c (info_symbol_command): Use all_objfiles.
7090         * objfiles.h (ALL_OBJSECTIONS): Remove.
7091         * maint.c (maintenance_translate_address): Use all_objfiles.
7092         * gcore.c (gcore_create_callback): Use all_objfiles.
7093         (objfile_find_memory_regions): Likewise.
7094
7095 2019-01-09  Tom Tromey  <tom@tromey.com>
7096
7097         * symtab.c (find_line_symtab, info_sources_command)
7098         (make_source_files_completion_list): Use objfile_compunits.
7099         * source.c (select_source_symtab): Use objfile_compunits.
7100         * objfiles.h (struct objfile): Update comment.
7101         (ALL_OBJFILES): Remove.
7102         (ALL_FILETABS): Remove.
7103         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7104         objfile_compunits.
7105
7106 2019-01-09  Tom Tromey  <tom@tromey.com>
7107
7108         * symmisc.c (print_objfile_statistics, dump_objfile)
7109         (maintenance_print_symbols): Use compunit_filetabs.
7110         * source.c (forget_cached_source_info_for_objfile): Use
7111         compunit_filetabs.
7112         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7113         (ALL_FILETABS): Use compunit_filetabs.
7114         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7115         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7116
7117 2019-01-09  Tom Tromey  <tom@tromey.com>
7118
7119         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7120         (compunit_filetabs): New.
7121         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7122         compunit_filetabs.
7123         (info_sources_command, make_source_files_completion_list): Remove
7124         declaration.
7125         * symmisc.c (print_objfile_statistics, dump_objfile)
7126         (maintenance_print_symbols): Remove declaration.
7127         (maintenance_info_symtabs): Use compunit_filetabs.
7128         (maintenance_info_line_tables): Likewise.
7129         * source.c (select_source_symtab): Change local variable name.
7130         (forget_cached_source_info_for_objfile): Remove declaration.
7131         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7132         * objfiles.c (objfile_relocate1): Remove declaration.
7133         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7134         declaration.
7135         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7136         * coffread.c (coff_symtab_read): Remove declaration.
7137         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7138         compunit_filetabs.
7139
7140 2019-01-09  Tom Tromey  <tom@tromey.com>
7141
7142         * symtab.c (lookup_objfile_from_block)
7143         (find_pc_sect_compunit_symtab, search_symbols)
7144         (default_collect_symbol_completion_matches_break_on): Use
7145         objfile_compunits.
7146         * objfiles.h (ALL_COMPUNITS): Remove.
7147         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7148         * cp-support.c (add_symbol_overload_list_qualified): Use
7149         objfile_compunits.
7150         * ada-lang.c (ada_collect_symbol_completion_matches)
7151         (ada_add_global_exceptions): Use objfile_compunits.
7152
7153 2019-01-09  Tom Tromey  <tom@tromey.com>
7154
7155         * source.c (select_source_symtab)
7156         (forget_cached_source_info_for_objfile): Remove declaration.
7157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7158         declaration.
7159         * maint.c (count_symtabs_and_blocks): Remove declaration.
7160         * cp-support.c (add_symbol_overload_list_qualified): Remove
7161         declaration.
7162         * coffread.c (coff_symtab_read): Remove declaration.
7163         * symtab.c (lookup_symbol_in_objfile_symtabs)
7164         (basic_lookup_transparent_type_1): Use objfile_compunits.
7165         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7166         (info_sources_command, search_symbols)
7167         (default_collect_symbol_completion_matches_break_on)
7168         (make_source_files_completion_list): Remove declaration.
7169         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7170         (ada_collect_symbol_completion_matches)
7171         (ada_add_global_exceptions): Remove declaration.
7172         * linespec.c (iterate_over_all_matching_symtabs): Use
7173         objfile_compunits.
7174         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7175         (class objfile_compunits): New.
7176         (ALL_COMPUNITS): Use objfile_compunits.
7177         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7178         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7179         objfile_compunits.
7180         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7181
7182 2019-01-09  Tom Tromey  <tom@tromey.com>
7183
7184         * symtab.c (search_symbols)
7185         (default_collect_symbol_completion_matches_break_on): Use
7186         objfile_msymbols.
7187         * ada-lang.c (ada_lookup_simple_minsym)
7188         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7189         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7190         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7191         objfile_msymbols.
7192         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7193         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7194         * objc-lang.c (find_methods): Use objfile_msymbols.
7195         (info_selectors_command, info_classes_command): Likewise.
7196         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7197         * objfiles.h (class objfile_msymbols): New.
7198         (ALL_OBJFILE_MSYMBOLS): Remove.
7199         (ALL_MSYMBOLS): Remove.
7200
7201 2019-01-09  Tom Tromey  <tom@tromey.com>
7202
7203         * common/next-iterator.h (next_adapter): Add Iterator template
7204         parameter.
7205         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7206         (class all_objfiles_safe): New.
7207         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7208         * objfiles.c (put_objfile_before): Update comment.
7209         (add_separate_debug_objfile): Likewise.
7210         (free_all_objfiles): Use all_objfiles_safe.
7211         (objfile_purge_solibs): Likewise.
7212
7213 2019-01-09  Tom Tromey  <tom@tromey.com>
7214
7215         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7216         (expand_symtab_containing_pc, lookup_static_symbol)
7217         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7218         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7219         all_objfiles.
7220         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7221         * breakpoint.c (create_overlay_event_breakpoint)
7222         (create_longjmp_master_breakpoint)
7223         (create_std_terminate_master_breakpoint)
7224         (create_exception_master_breakpoint): Use all_objfiles.
7225         * linux-thread-db.c (try_thread_db_load_from_pdir)
7226         (has_libpthread): Use all_objfiles.
7227         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7228         * linespec.c (iterate_over_all_matching_symtabs)
7229         (search_minsyms_for_name): Use all_objfiles.
7230         * maint.c (maintenance_info_sections): Use all_objfiles.
7231         * main.c (captured_main_1): Use all_objfiles.
7232         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7233         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7234         * guile/scm-pretty-print.c
7235         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7236         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7237         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7238         (maintenance_print_msymbols): Use all_objfiles.
7239         * source.c (select_source_symtab): Use all_objfiles.
7240         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7241         * symfile.c (remove_symbol_file_command)
7242         (expand_symtabs_matching, map_symbol_filenames): Use
7243         all_objfiles.
7244         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7245         all_objfiles.
7246         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7247         * objc-lang.c (find_methods): Use all_objfiles.
7248         * objfiles.c (have_partial_symbols, have_full_symbols)
7249         (have_minimal_symbols, qsort_cmp)
7250         (default_iterate_over_objfiles_in_search_order): Use
7251         all_objfiles.
7252         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7253         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7254         (maintenance_check_psymtabs): Use all_objfiles.
7255         (ALL_PSYMTABS): Remove.
7256         * compile/compile-object-run.c (do_module_cleanup): Use
7257         all_objfiles.
7258         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7259         * cp-support.c (add_symbol_overload_list_qualified): Use
7260         all_objfiles.
7261         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7262         Use all_objfiles.
7263         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7264         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7265         all_objfiles.
7266         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7267         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7268         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7269         Uses all_objfiles.
7270         * solib.c (solib_read_symbols): Use all_objfiles
7271
7272 2019-01-09  Tom Tromey  <tom@tromey.com>
7273
7274         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7275         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7276         all_objfiles.
7277         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7278         * symmisc.c (print_symbol_bcache_statistics)
7279         (print_objfile_statistics, maintenance_print_objfiles)
7280         (maintenance_info_symtabs, maintenance_check_symtabs)
7281         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7282         all_objfiles.
7283         * source.c (forget_cached_source_info): Use all_objfiles.
7284         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7285         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7286         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7287         * objfiles.c (update_section_map): Use all_objfiles.
7288         (shared_objfile_contains_address_p): Likewise.
7289         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7290         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7291
7292 2019-01-09  Tom Tromey  <tom@tromey.com>
7293
7294         * common/next-iterator.h: New file.
7295         * objfiles.h (class all_objfiles): New.
7296         (struct objfile_iterator): New.
7297
7298 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7299
7300         * NEWS: Move the description of the changed "frame", "select-frame",
7301          and "info frame" commands to the Changed commands section.
7302
7303 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7304
7305         * gdbtypes.c (check_stub_method_group): Remove handling of old
7306         mangling schemes.
7307         * linespec.c (find_methods): Likewise.
7308         * stabsread.c (read_member_functions): Likewise.
7309         * valops.c (search_struct_method): Likewise.
7310         (value_struct_elt_for_reference): Likewise.
7311         * NEWS: Mention this change.
7312
7313 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7314
7315         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7316         print_source_lines.
7317         * source.c (print_source_lines_base): Update line number check.
7318         (print_source_lines): New function.
7319         (source_lines_range::source_lines_range): New function.
7320         * source.h (class source_lines_range): New class.
7321         (print_source_lines): New declaration.
7322
7323 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7324
7325         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7326
7327 2019-01-08  Tom Tromey  <tom@tromey.com>
7328             Simon Marchi  <simon.marchi@ericsson.com>
7329
7330         PR gdb/24060
7331         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7332         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7333         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7334         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7335         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7336         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7337
7338 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * source.c (select_source_symtab): Move header comment to
7341         declaration in source.h.
7342         (forget_cached_source_info_for_objfile): Likewise.
7343         (forget_cached_source_info): Likewise.
7344         (identify_source_line): Likewise.
7345         * source.h (identify_source_line): Move declaration from symtab.h
7346         and add comment from source.c
7347         (print_source_lines): Likewise.
7348         (forget_cached_source_info_for_objfile): Likewise.
7349         (forget_cached_source_info): Likewise.
7350         (select_source_symtab): Likewise.
7351         (enum print_source_lines_flag): Move definition from symtab.h.
7352         * symtab.h (identify_source_line): Move declaration to source.h.
7353         (print_source_lines): Likewise.
7354         (forget_cached_source_info_for_objfile): Likewise.
7355         (forget_cached_source_info): Likewise.
7356         (select_source_symtab): Likewise.
7357         (enum print_source_lines_flag): Move definition to source.h.
7358         * tui/tui-hooks.c: Add 'source.h' include.
7359
7360 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7361
7362         * source.c (print_source_lines_base): Handle requests to print
7363         reverse line number sequences, and guard against empty lines
7364         string.
7365
7366 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7367
7368         * source.c (print_source_lines_base): Fix skip of '\r' if next
7369         character is '\n'.
7370
7371 2019-01-06  Tom Tromey  <tom@tromey.com>
7372
7373         * c-exp.y (struct c_parse_state) <macro_original_text,
7374         expansion_obstack>: New member.
7375         (macro_original_text, expansion_obstack): Remove globals.
7376         (scan_macro_expansion, scanning_macro_expansion)
7377         (finished_macro_expansion): Update.
7378         (scan_macro_cleanup): Remove.
7379         (yylex, c_parse): Update.
7380
7381 2019-01-06  Tom Tromey  <tom@tromey.com>
7382
7383         * c-exp.y (struct c_parse_state) <strings>: New member.
7384         (operator_stoken): Update.
7385
7386 2019-01-06  Tom Tromey  <tom@tromey.com>
7387
7388         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7389         (union type_stack_elt) <typelist_val>: Now a pointer to
7390         std::vector.
7391         (type_stack_cleanup): Don't declare.
7392         (push_typelist): Update.
7393         * parse.c (pop_typelist): Return a std::vector.
7394         (push_typelist): Take a std::vector.
7395         (follow_types): Update.  Do not free args.
7396         (type_stack_cleanup): Remove.
7397         * c-exp.y (struct c_parse_state): New.
7398         (cpstate): New global.
7399         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7400         (nonempty_typelist): Update.
7401         (func_mod): Create a new vector.
7402         (c_parse): Create a c_parse_state.
7403         (check_parameter_typelist): Do not delete params.
7404         (function_method): Update.  Do not delete type_list.
7405
7406 2019-01-06  Tom Tromey  <tom@tromey.com>
7407
7408         PR gdb/28155:
7409         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7410         check_typedef.
7411         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7412         (print_return_value): Likewise.
7413
7414 2019-01-05  Tom Tromey  <tom@tromey.com>
7415
7416         * contrib/cleanup_check.py: Remove.
7417         * contrib/gcc-with-excheck: Remove.
7418         * contrib/exsummary.py: Remove.
7419         * contrib/excheck.py: Remove.
7420
7421 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7422
7423         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7424         NULL. Initialize tpprev to NULL instead of assigning it
7425         to NULL on the next statement.
7426         * windows-nat.c (windows_delete_thread): Remove check for
7427         main_thread_id before printing thread exit notifications.
7428         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7429         Remove thread ID check against main_thread_id.
7430         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7431         windows_delete_thread.
7432         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7433
7434 2019-01-04  Tom Tromey  <tom@tromey.com>
7435
7436         * compile/compile.c (_initialize_compile): Use upper case for
7437         metasyntactic variables.
7438         * symmisc.c (_initialize_symmisc): Use upper case for
7439         metasyntactic variables.
7440         * psymtab.c (_initialize_psymtab): Use upper case for
7441         metasyntactic variables.
7442         * demangle.c (demangle_command): Use upper case for metasyntactic
7443         variables.
7444         (_initialize_demangler): Likewise.
7445         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7446         variables.
7447
7448 2019-01-03  Tom Tromey  <tom@tromey.com>
7449
7450         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7451
7452 2019-01-03  Tom Tromey  <tom@tromey.com>
7453
7454         * python/py-symtab.c (salpy_str): Update.
7455         (struct salpy_sal_object) <symtab>: Now a PyObject.
7456         (salpy_dealloc): Update.
7457         (del_objfile_sal): Use gdbpy_ref.
7458
7459 2019-01-03  Tom Tromey  <tom@tromey.com>
7460
7461         * python/py-type.c (convert_field): Use new_reference.  Return
7462         gdbpy_ref.
7463         (make_fielditem): Return gdbpy_ref.
7464         (typy_fields): Update.
7465         (typy_getitem): Update.
7466         (field_name): Return gdbpy_ref.  Use new_reference.
7467         (typy_iterator_iternext): Update.
7468
7469 2019-01-03  Tom Tromey  <tom@tromey.com>
7470
7471         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7472
7473 2019-01-03  Tom Tromey  <tom@tromey.com>
7474
7475         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7476         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7477         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7478         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7479         (pspy_set_type_printers): Likewise.
7480         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7481         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7482         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7483         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7484         (objfpy_set_type_printers): Likewise.
7485
7486 2019-01-03  Tom Tromey  <tom@tromey.com>
7487
7488         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7489         (gdbpy_print_stack): Use gdbpy_err_fetch.
7490         * python/python-internal.h (class gdbpy_err_fetch): New class.
7491         (class gdbpy_enter) <m_error_type, m_error_value,
7492         m_error_traceback>: Remove.
7493         <m_error>: New member.
7494         (gdbpy_exception_to_string): Don't declare.
7495         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7496         * python/py-value.c (convert_value_from_python): Use
7497         gdbpy_err_fetch.
7498         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7499         gdbpy_exception_to_string.
7500         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7501         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7502         gdbpy_err_fetch.
7503
7504 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7505
7506         * linux-nat.c (delete_lwp_cleanup): Delete.
7507         (struct lwp_deleter): New struct.
7508         (lwp_info_up): New typedef.
7509         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7510         lwp_info_up.
7511
7512 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7513
7514         * linux-fork.c (class scoped_switch_fork_info): New class.
7515         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7516
7517 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7518
7519         * valops.c (find_overload_match): Remove use of null_cleanup, and
7520         calls to do_cleanups.
7521
7522 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * compile/compile-cplus-types.c
7525         (compile_cplus_instance::decl_name): Handle changes to
7526         cp_func_name.
7527         * cp-support.c (cp_func_name): Update header comment, update
7528         return type.
7529         * cp-support.h (cp_func_name): Update return type in declaration.
7530         * valops.c (find_overload_match): Move temp_func local to top
7531         level of function and change its type.  Use temp_func to hold and
7532         delete temporary string obtained from cp_func_name.
7533
7534 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7537         gdb::char_vector, remove cleanup, and update uses of `msg`.
7538
7539 2019-01-03  Jim Wilson  <jimw@sifive.com>
7540
7541         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7542
7543 2019-01-02  Tom Tromey  <tom@tromey.com>
7544
7545         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7546         (tdesc_parse_xml): Remove cleanups.
7547         * target-descriptions.h (make_cleanup_free_target_description):
7548         Don't declare.
7549         (target_desc_deleter): New struct.
7550         (target_desc_up): New typedef.
7551         * target-descriptions.c (target_desc_deleter::operator()): Rename
7552         from free_target_description.
7553         (make_cleanup_free_target_description): Remove.
7554
7555 2019-01-02  Tom Tromey  <tom@tromey.com>
7556
7557         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7558         constructor, destructor.
7559         (linespec_parser): Remove typedef.
7560         (~linespec_parser): Rename from linespec_parser_delete.
7561         (linespec_lex_to_end, linespec_complete_label)
7562         (linespec_complete): Update.
7563         (decode_line_full): Remove cleanups.
7564         (decode_line_1): Update.
7565
7566 2019-01-02  Tom Tromey  <tom@tromey.com>
7567
7568         * python/python-internal.h (inferior_to_inferior_object): Change
7569         return type.
7570         * python/py-exitedevent.c (create_exited_event_object): Update.
7571         * python/py-inferior.c (inferior_to_inferior_object): Return
7572         gdbpy_ref.
7573         (python_new_inferior, python_inferior_deleted)
7574         (thread_to_thread_object, delete_thread_object)
7575         (build_inferior_list, gdbpy_selected_inferior): Update.
7576         * python/py-infthread.c (create_thread_object): Update.  Also fail
7577         if inferior_to_inferior_object fails.
7578
7579 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7580
7581         * inferior.h (class inferior) <displaced_step_state>: New field.
7582         * infrun.h (struct displaced_step_state): Move here from
7583         infrun.c.  Initialize fields, add constructor.
7584         <inf>: Remove field.
7585         <reset>: New method.
7586         * infrun.c (struct displaced_step_inferior_state): Move to
7587         infrun.h.
7588         (displaced_step_inferior_states): Remove.
7589         (get_displaced_stepping_state): Adust.
7590         (displaced_step_in_progress_any_inferior): Adjust.
7591         (displaced_step_in_progress_thread): Adjust.
7592         (displaced_step_in_progress): Adjust.
7593         (add_displaced_stepping_state): Remove.
7594         (get_displaced_step_closure_by_addr): Adjust.
7595         (remove_displaced_stepping_state): Remove.
7596         (infrun_inferior_exit): Call displaced_step_state.reset.
7597         (use_displaced_stepping): Don't check for NULL.
7598         (displaced_step_prepare_throw): Call
7599         get_displaced_stepping_state.
7600         (displaced_step_fixup): Don't check for NULL.
7601         (prepare_for_detach): Don't check for NULL.
7602
7603 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7604
7605         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7606          in case of call that did not complete.
7607
7608 2019-01-02  Andrey Utkin  <autkin@undo.io>
7609
7610         * symfile.c (find_separate_debug_file): Fix search of debug files for
7611         remote debuggee.
7612
7613 2019-01-02  Tom Tromey  <tom@tromey.com>
7614
7615         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7616         indentation.
7617         * python/py-frame.c (frapy_older): Remove cast.
7618         (frapy_newer): Likewise.
7619         * python/py-breakpoint.c (local_setattro): Remove cast.
7620         * python/py-arch.c (archpy_name): Remove local variable.
7621         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7622
7623 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7624
7625         * unittests/basic_string_view/element_access/char/empty.cc:
7626         Fix year range in copyright header.
7627
7628 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7629
7630         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7631         Delete.
7632         <operator==>: Update with for removed field.
7633         <hash>: Likewise.
7634         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7635         <isa_features>: ...this.
7636         <abi_features>: New field.
7637         (riscv_isa_flen): Update comment.
7638         (riscv_abi_xlen): New declaration.
7639         (riscv_abi_flen): New declaration.
7640         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7641         isa_features.
7642         (riscv_abi_xlen): New function.
7643         (riscv_isa_flen): Update to get answer from isa_features.
7644         (riscv_abi_flen): New function.
7645         (riscv_has_fp_abi): Update to get answer from abi_features.
7646         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7647         xlen and flen.
7648         (riscv_call_info) <xlen, flen>: Update comment.
7649         (riscv_call_arg_struct): Remove invalid assertions
7650         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7651         is removed.
7652         (riscv_gdbarch_init): Gather isa features and abi features
7653         separately, ensure both match on the gdbarch when reusing an old
7654         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7655         a target with 64-bit float hardware.
7656
7657 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7658
7659         * source.c (search_command_helper): Stop reverse search
7660         when line 1 has been searched.
7661
7662 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7663
7664         * record-full.c (record_full_base_target::close): Rewrite
7665         record_full_core_buf_list free logic.
7666
7667 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7668
7669         * break-catch-syscall.c (print_one_catch_syscall): xfree
7670         the last text.
7671
7672 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7673
7674         * top.c (print_gdb_version): Update Copyright year in version
7675         message.
7676
7677 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7678
7679         Update copyright year range in all GDB files.
7680
7681 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7682
7683         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7684
7685 For older changes see ChangeLog-2018.
7686 \f
7687 Local Variables:
7688 mode: change-log
7689 left-margin: 8
7690 fill-column: 74
7691 version-control: never
7692 coding: utf-8
7693 End:
7694