gdb/ChangeLog

   1 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * corelow.c (core_target::detach): Ensure frame cache and
   4         register caches are cleared.
   5         inferior.c (exit_inferior_1): Likewise.
   6
   7 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
   8             Tom Tromey  <tom@tromey.com>
   9
  10         * dictionary.c (collate_pending_symbols_by_language): Remove
  11         "struct" from foreach.
  12         * symtab.c (lookup_global_symbol_from_objfile)
  13         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  14         foreach.
  15         * ser-tcp.c (net_open): Remove "struct" from foreach.
  16         * objfiles.c (objfile_relocate, objfile_rebase)
  17         (objfile_has_symbols): Remove "struct" from foreach.
  18         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  19         from foreach.
  20         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  21         foreach.
  22         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  23         "struct" from foreach.
  24         * ada-lang.c (create_excep_cond_exprs)
  25         (ada_exception_catchpoint_cond_string): Remove "struct" from
  26         foreach.
  27
  28 2019-05-03  Tom Tromey  <tromey@adacore.com>
  29
  30         * ada-exp.y (convert_char_literal): Check suffix of each
  31         enumerator.
  32
  33 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
  34
  35         PR ada/21406:
  36         * ada-exp.y (yywrap): Don't define.
  37         * ada-lex.l (%option): Add noyywrap
  38         (yywrap): Remove.
  39
  40 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  41
  42         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  43         _WIN32_WINNT to the XP level, unless already defined to a higher
  44         level.
  45
  46         * unittests/parse-connection-spec-selftests.c:
  47         * ser-tcp.c:
  48         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  49         override.
  50
  51         * symfile.c (find_separate_debug_file): Remove colon from the
  52         drive spec of DOS/Windows file names of the target, so that the
  53         file name produced from DEBUGDIR and the target's directory will
  54         be valid on DOS/Windows systems.
  55
  56 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  57
  58         * rust-lang.c (val_print_struct): Handle printing structures
  59         containing strings.
  60
  61 2019-05-02  Tom Tromey  <tromey@adacore.com>
  62
  63         * valarith.c (_initialize_valarith): Remove.
  64
  65 2019-05-01  Tom Tromey  <tromey@adacore.com>
  66
  67         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  68         bitfields.
  69
  70 2019-05-01  Tom Tromey  <tromey@adacore.com>
  71
  72         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  73         for big-endian copies.
  74
  75 2019-04-30  Ali Tamur  <tamur@google.com>
  76         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  77         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  78         (read_3_bytes): New function.
  79
  80 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  81
  82         * windows-nat.c (main_thread_id): Delete.
  83         (handle_output_debug_string): Replace main_thread_id by
  84         current_event.dwThreadId.
  85         (fake_create_process): Likewise.
  86         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  87         Do not set main_thread_id.
  88         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  89         current_event.dwThreadId.
  90         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  91
  92 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  93
  94         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  95         Use current_event.dwThreadId instead of main_thread_id.
  96
  97 2019-04-30  Tom Tromey  <tromey@adacore.com>
  98
  99         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 100         (create_excep_cond_exprs): Iterate over program spaces.
 101         (ada_exception_catchpoint_cond_string): Examine all minimal
 102         symbols for exception types.
 103
 104 2019-04-30  Tom Tromey  <tromey@adacore.com>
 105
 106         PR c++/24470:
 107         * dwarf2read.c (process_structure_scope): Handle case where type
 108         has template parameters but no symbol was created.
 109
 110 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 111             Chris January  <chris.january@arm.com>
 112
 113         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 114         qualifier.
 115         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 116
 117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 118
 119         * f-typeprint.c (f_print_type): Update rules for printing
 120         whitespace.
 121         (f_type_print_varspec_suffix): Likewise.
 122
 123 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 124             Chris January  <chris.january@arm.com>
 125
 126         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 127         function arguments.
 128
 129 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 130
 131         * f-lang.c (build_fortran_types): Change name of void type to
 132         lower case.
 133         * f-typeprint.c (f_type_print_base): Print the name of the void
 134         type, rather than a fixed string.
 135         * f-valprint.c (f_decorations): Use lower case void string.
 136
 137 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 138             Chris January  <chris.january@arm.com>
 139
 140         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 141         types for Fortran.
 142
 143 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 144             Chris January  <chris.january@arm.com>
 145             David Lecomber  <david.lecomber@arm.com>
 146
 147         * f-exp.y (BINOP_INTRINSIC): New token.
 148         (exp): New parser rule handling BINOP_INTRINSIC.
 149         (f77_keywords): Add new builtin procedures.
 150         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 151         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 152         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 153         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 154         (print_unop_subexp_f): New function.
 155         (print_binop_subexp_f): New function.
 156         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 157         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 158         (dump_subexp_body_f): Likewise.
 159         (operator_check_f): Likewise.
 160         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 161         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 162
 163 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 166         UNOP_KIND.
 167         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 168         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 169         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 170         (operator_length_f): New fuction.
 171         (print_subexp_f): New function.
 172         (op_name_f): New function.
 173         (dump_subexp_body_f): New function.
 174         (operator_check_f): New function.
 175         (exp_descriptor_f): Replace standard expression handling functions
 176         with new functions.
 177         * gdb/fortran-operator.def: New file.
 178         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 179         * gdb/std-operator.def: Remove UNOP_KIND.
 180
 181 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 182
 183         * std-operator.def: Remove unbalanced, stray double quote
 184         character.
 185
 186 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 187             Chris January  <chris.january@arm.com>
 188             Daniel Everett  <daniel.everett@arm.com>
 189             Nick Forrington  <nick.forrington@arm.com>
 190             Richard Bunt  <richard.bunt@arm.com>
 191
 192         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 193         of depth when printing anonymous structs or unions.
 194         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 195         Don't print either the top-level value, or the children if the
 196         max-depth is exceeded.
 197         (ppscm_print_children): When printing the key of a map, allow one
 198         extra level of depth.
 199         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 200         print either the top-level value, or the children if the max-depth
 201         is exceeded.
 202         (print_children): When printing the key of a map, allow one extra
 203         level of depth.
 204         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 205         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 206         (user_print_options): Initialise max_depth field.
 207         (val_print_scalar_or_string_type_p): New function.
 208         (val_print): Check to see if the max depth has been reached.
 209         (val_print_check_max_depth): Define new function.
 210         (show_print_max_depth): New function.
 211         (_initialize_valprint): Add 'print max-depth' option.
 212         * valprint.h (struct value_print_options) <max_depth>: New field.
 213         (val_print_check_max_depth): Declare new function.
 214         * NEWS: Document new feature.
 215
 216 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 217
 218         * ada-lang.c (ada_language_defn): Initialise new field.
 219         * c-lang.c (c_is_string_type_p): New function.
 220         (c_language_defn): Initialise new field.
 221         (cplus_language_defn): Initialise new field.
 222         (asm_language_defn): Initialise new field.
 223         (minimal_language_defn): Initialise new field.
 224         * c-lang.h (c_is_string_type_p): Declare new function.
 225         * d-lang.c (d_language_defn): Initialise new field.
 226         * f-lang.c (f_is_string_type_p): New function.
 227         (f_language_defn): Initialise new field.
 228         * go-lang.c (go_is_string_type_p): New function.
 229         (go_language_defn): Initialise new field.
 230         * language.c (default_is_string_type_p): New function.
 231         (unknown_language_defn): Initialise new field.
 232         (auto_language_defn): Initialise new field.
 233         * language.h (struct language_defn) <la_is_string_type_p>: New
 234         member variable.
 235         (default_is_string_type_p): Declare new function.
 236         * m2-lang.c (m2_language_defn): Initialise new field.
 237         * objc-lang.c (objc_language_defn): Initialise new field.
 238         * opencl-lang.c (opencl_language_defn): Initialise new field.
 239         * p-lang.c (pascal_is_string_type_p): New function.
 240         (pascal_language_defn): Initialise new field.
 241         * rust-lang.c (rust_is_string_type_p): New function.
 242         (rust_language_defn): Initialise new field.
 243
 244 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 245
 246         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 247         New field.
 248         * ada-lang.c (ada_language_defn): Initialise new field.
 249         * c-lang.c (c_language_defn): Likewise.
 250         (cplus_language_defn): Likewise.
 251         (asm_language_defn): Likewise.
 252         (minimal_language_defn): Likewise.
 253         * d-lang.c (d_language_defn): Likewise.
 254         * f-lang.c (f_language_defn): Likewise.
 255         * go-lang.c (go_language_defn): Likewise.
 256         * language.c (unknown_language_defn): Likewise.
 257         (auto_language_defn): Likewise.
 258         * m2-lang.c (m2_language_defn): Likewise.
 259         * objc-lang.c (objc_language_defn): Likewise.
 260         * opencl-lang.c (opencl_language_defn): Likewise.
 261         * p-lang.c (pascal_language_defn): Likewise.
 262         * rust-lang.c (rust_language_defn): Likewise.
 263
 264 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * ada-lang.c (ada_is_character_type): Change return type to bool.
 267         (ada_is_string_type): Likewise.
 268         * ada-lang.h (ada_is_character_type): Update declaration
 269         (ada_is_string_type): Likewise.
 270
 271 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 272
 273         Support style in 'frame|thread apply'
 274
 275         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 276         * record.c (record_start, record_stop): Update callers of
 277         execute_command_to_string with false.
 278         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 279         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 280         methods.
 281         (class string_file): New constructor with term_out parameter.
 282         Override methods term_out and can_emit_style_escape.  New member
 283         term_out.
 284         (class stdio_file): Override can_emit_style_escape.
 285         (class tee_file): Override term_out and can_emit_style_escape.
 286         * utils.h (can_emit_style_escape): Remove.
 287         * utils.c (can_emit_style_escape): Likewise.
 288         Update all callers of can_emit_style_escape (SOMESTREAM) to
 289         SOMESTREAM->can_emit_style_escape.
 290         * source-cache.c (source_cache::get_source_lines): Likewise.
 291         * stack.c (frame_apply_command_count): Call execute_command_to_string
 292         passing the term_out characteristic of the current gdb_stdout.
 293         * thread.c (thr_try_catch_cmd): Likewise.
 294         * top.c (execute_command_to_string): pass term_out parameter
 295         to construct the string_file for the command output.
 296         * ui-file.c (term_cli_styling): New function (most code moved
 297         from utils.c can_emit_style_escape).
 298         (string_file::string_file, string_file::can_emit_style_escape,
 299         stdio_file::can_emit_style_escape, tee_file::term_out,
 300         tee_file::can_emit_style_escape): New functions.
 301
 302 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 303
 304         * NEWS: Mention the new set|show may-call-functions.
 305         * infcall.c (may_call_functions_p): New variable.
 306         (show_may_call_functions_p): New function.
 307         (call_function_by_hand_dummy): Throws an error if not
 308         may-call-functions.
 309         (_initialize_infcall): Call add_setshow_boolean_cmd for
 310         may-call-functions.
 311
 312 2019-04-25  Keith Seitz  <keiths@redhat.com>
 313
 314         PR c++/24367
 315         * cp-support.c (inspect_type): Don't attempt substitutions
 316         of symbol with the same name.
 317
 318 2019-04-25  Tom Tromey  <tromey@adacore.com>
 319
 320         PR gdb/24475:
 321         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 322         static.
 323
 324 2019-04-25  Tom Tromey  <tromey@adacore.com>
 325
 326         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 327         rvalue reference.
 328         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 329         (gdb_xml_parser::parse): Use std::move.
 330         * python/python-internal.h (gdbpy_convert_exception): Take a const
 331         reference.
 332         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 333         std::move.
 334         * python/py-utils.c (gdbpy_convert_exception): Take a const
 335         reference.
 336         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 337         Use std::move.
 338         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 339         Use std::move.
 340         * mi/mi-main.c (mi_print_exception): Take a const reference.
 341         * main.c (handle_command_errors): Take a const reference.
 342         * linespec.c (parse_linespec): Use std::move.
 343         * infcall.c (run_inferior_call): Use std::move.
 344         (call_function_by_hand_dummy): Use std::move.
 345         * exec.c (try_open_exec_file): Use std::move.
 346         * exceptions.h (exception_print, exception_fprintf)
 347         (exception_print_same): Update.
 348         * exceptions.c (print_exception, exception_print)
 349         (exception_fprintf, exception_print_same): Change parameters to
 350         const reference.
 351         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 352         * common/new-op.c: Use std::move.
 353         * common/common-exceptions.h (struct gdb_exception): Add move
 354         constructor.
 355         (struct gdb_exception_error, struct gdb_exception_quit, struct
 356         gdb_quit_bad_alloc): Change constructor to move constructor.
 357         (throw_exception): Change parameter to rvalue reference.
 358         * common/common-exceptions.c (throw_exception): Take rvalue
 359         reference.
 360         * cli/cli-interp.c (safe_execute_command): Use std::move.
 361         * breakpoint.c (insert_bp_location, location_to_sals): Use
 362         std::move.
 363
 364 2019-04-25  Tom Tromey  <tromey@adacore.com>
 365
 366         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 367         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 368         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 369         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 370         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 371         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 372         guile/scm-value.c: Use unpack.
 373         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 374         gdbscm_gdb_exception.
 375         (gdbscm_throw_gdb_exception): Likewise.
 376         (struct gdbscm_gdb_exception): New.
 377         (unpack): New function.
 378         (gdbscm_wrap): Use unpack.
 379
 380 2019-04-25  Tom Tromey  <tromey@adacore.com>
 381
 382         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 383         (gdb_rl_callback_handler): Use std::move.
 384         * common/common-exceptions.h (struct gdb_exception): Add move
 385         assignment operator.
 386         (throw_exception_sjlj): Change "exception" to const reference.
 387         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 388         (throw_exception_sjlj): Change "exception" to const reference.
 389
 390 2019-04-25  Tom Tromey  <tromey@adacore.com>
 391
 392         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 393         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 394         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 395         Update.
 396         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 397         Update.
 398         * mi/mi-interp.c (mi_interp::exec): Update.
 399         * linespec.c (parse_linespec): Update.
 400         * infcall.c (run_inferior_call): Update.
 401         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 402         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 403         (gdbscm_lookup_global_symbol): Update.
 404         * guile/scm-param.c (gdbscm_parameter_value): Update.
 405         * guile/scm-frame.c (gdbscm_frame_read_register)
 406         (gdbscm_frame_read_var): Update.
 407         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 408         * exec.c (try_open_exec_file): Update.
 409         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 410         (gdb_rl_callback_handler): Update.
 411         * common/common-exceptions.h (exception_none): Don't declare.
 412         * common/common-exceptions.c (exception_none): Don't define.
 413         (struct catcher) <exception>: Update.
 414         * cli/cli-interp.c (safe_execute_command): Update.
 415         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 416
 417 2019-04-25  Ali Tamur  <tamur@google.com>
 418
 419         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 420         (read_attribute_value): Likewise.
 421         (dwarf2_read_addr_index): Update comment.
 422         (read_str_index): Add DW_FORM_strx.
 423         (dwarf2_string_attr): Likewise.
 424         (dwarf2_const_value_attr): Likewise.
 425         (dump_die_shallow): Likewise.
 426         (dwarf2_fetch_constant_bytes): Likewise.
 427         (skip_form_bytes): Likewise.
 428         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 429
 430 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 431
 432         PR corefiles/11608
 433         PR corefiles/18187
 434         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 435         OFFSET.  Verify if current mapping contains an ELF header.
 436         (linux_find_memory_regions_full): Adjust call to
 437         dump_mapping_p.
 438
 439 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 440             Kang Li <kanglictf@gmail.com>
 441
 442         PR gdb/21600
 443
 444         * dwarf2-frame.c (read_initial_length): Be consistent about using
 445         unsigned representation of length.
 446         (decode_frame_entry_1): Likewise.  Check for wraparound of
 447         end pointer as well as buffer overflow.
 448
 449 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 450
 451         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 452         "vq".
 453
 454 2019-04-24  Tom Tromey  <tromey@adacore.com>
 455
 456         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 457
 458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         * s12z-tdep.c (s12z_unwind_pc): Delete.
 461         (s12z_unwind_sp): Delete.
 462         (s12z_gdbarch_init): Don't register deleted functions with
 463         gdbarch.
 464
 465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 466
 467         * rl78-tdep.c (rl78_unwind_sp): Delete.
 468         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 469
 470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 473         (xstormy16_unwind_pc): Delete.
 474         (xstormy16_dummy_id): Delete.
 475         (xstormy16_gdbarch_init): Don't register deleted functions with
 476         gdbarch.
 477
 478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 479
 480         * vax-tdep.c (vax_unwind_pc): Delete.
 481         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 482
 483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * v850-tdep.c (v850_unwind_sp): Delete.
 486         (v850_unwind_pc): Delete.
 487         (v850_dummy_id): Delete.
 488         (v850_gdbarch_init): Don't register deleted functions with
 489         gdbarch.
 490
 491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 492
 493         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 494         (tilegx_unwind_pc): Delete.
 495         (tilegx_unwind_dummy_id): Delete.
 496         (tilegx_gdbarch_init): Don't register deleted functions with
 497         gdbarch.
 498
 499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 500
 501         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 502         (tic6x_dummy_id): Delete.
 503         (tic6x_gdbarch_init): Don't register deleted functions with
 504         gdbarch.
 505
 506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * sparc-tdep.c (sparc_unwind_pc): Delete.
 509         (sparc32_gdbarch_init): Don't register deleted function with
 510         gdbarch.
 511
 512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 513
 514         * sh-tdep.c (sh_unwind_sp): Delete.
 515         (sh_unwind_pc): Delete.
 516         (sh_dummy_id): Delete.
 517         (sh_gdbarch_init): Don't register deleted functions with
 518         gdbarch.
 519
 520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 521
 522         * score-tdep.c (score_unwind_sp): Delete.
 523         (score_unwind_pc): Delete.
 524         (score_dummy_id): Delete.
 525         (score_gdbarch_init): Don't register deleted functions with
 526         gdbarch.
 527
 528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 529
 530         * rx-tdep.c (rx_unwind_pc): Delete.
 531         (rx_unwind_sp): Delete.
 532         (rx_dummy_id): Delete.
 533         (rx_gdbarch_init): Don't register deleted functions with
 534         gdbarch.  Update comment.
 535
 536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 537
 538         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 539         (rs6000_dummy_id): Delete.
 540         (rs6000_gdbarch_init): Don't register deleted functions with
 541         gdbarch.
 542
 543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 544
 545         * or1k-tdep.c (or1k_dummy_id): Delete.
 546         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 547
 548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * nios2-tdep.c (nios2_dummy_id): Delete.
 551         (nios2_unwind_sp): Delete.
 552         (nios2_gdbarch_init): Don't register deleted functions with
 553         gdbarch.
 554
 555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 556
 557         * nds32-tdep.c (nds32_dummy_id): Delete.
 558         (nds32_unwind_pc): Delete.
 559         (nds32_unwind_sp): Delete.
 560         (nds32_gdbarch_init): Don't register deleted functions with
 561         gdbarch.
 562
 563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * msp430-tdep.c (msp430_unwind_pc): Delete.
 566         (msp430_unwind_sp): Delete.
 567         (msp430_dummy_id): Delete.
 568         (msp430_gdbarch_init): Don't register deleted functions with
 569         gdbarch.
 570
 571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * moxie-tdep.c (moxie_unwind_sp): Delete.
 574         (moxie_unwind_pc): Delete.
 575         (moxie_dummy_id): Delete.
 576         (moxie_gdbarch_init): Don't register deleted functions with
 577         gdbarch.
 578
 579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 582         (mn10300_unwind_pc): Delete.
 583         (mn10300_unwind_sp): Delete.
 584         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 585         mn10300_unwind_sp.
 586         (mn10300_frame_unwind_init): Don't register deleted functions with
 587         gdbarch.
 588
 589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 590
 591         * mep-tdep.c (mep_unwind_pc): Delete.
 592         (mep_unwind_sp): Delete.
 593         (mep_dummy_id): Delete.
 594         (mep_gdbarch_init): Don't register deleted functions with
 595         gdbarch.
 596
 597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 598
 599         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 600         (m68hc11_unwind_sp): Delete.
 601         (m68hc11_gdbarch_init): Don't register deleted functions with
 602         gdbarch.
 603
 604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 605
 606         * m32r-tdep.c (m32r_unwind_sp): Delete.
 607         (m32r_unwind_pc): Delete.
 608         (m32r_dummy_id): Delete.
 609         (m32r_gdbarch_init): Don't register deleted functions with
 610         gdbarch.
 611
 612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 613
 614         * m32c-tdep.c (m32c_unwind_pc): Delete.
 615         (m32c_unwind_sp): Delete.
 616         (m32c_dummy_id): Delete.
 617         (m32c_gdbarch_init): Don't register deleted functions with
 618         gdbarch.
 619
 620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 621
 622         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 623         (lm32_unwind_pc): Delete.
 624         (lm32_dummy_id): Delete.
 625         (lm32_gdbarch_init): Don't register deleted functions with
 626         gdbarch.
 627
 628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 631         (iq2000_unwind_pc): Delete.
 632         (iq2000_dummy_id): Delete.
 633         (iq2000_gdbarch_init): Don't register deleted functions with
 634         gdbarch.
 635
 636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 637
 638         * nds32-tdep.c (nds32_type_align): Delete.
 639         (nds32_push_dummy_call): Use type_align instead.
 640
 641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * arm-tdep.c (arm_type_align): Only handle vector override case.
 644         (arm_push_dummy_call): Use type_align.
 645         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 646
 647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 650         case.
 651         (pass_on_stack): Use type_align.
 652         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 653         function.
 654
 655 2019-04-23  Tom Tromey  <tromey@adacore.com>
 656
 657         * dwarf2read.c (line_header::file_name_at): Remove unused
 658         overload.
 659
 660 2019-04-23  Tom de Vries  <tdevries@suse.de>
 661
 662         PR gdb/24438
 663         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 664         invocation.
 665
 666
 667 2019-03-27  Ali Tamur  <tamur@google.com>
 668
 669         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 670         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 671         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 672         (dwarf_expr_context::get_addr_index): Likewise
 673         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 674         (symbol_needs_eval_context::get_addr_index): Likewise
 675         (disassemble_dwarf_expression): Add DW_OP_addrx
 676         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 677         (read_cutu_die_from_dwo): Update comment
 678         (skip_one_die): Add DW_FORM_addrx
 679         (read_attribute_value): Likewise
 680         (var_decode_location): Add DW_OP_addrx
 681         (dwarf2_const_value_attr): Add DW_FORM_addrx
 682         (dump_die_shallow): Likewise
 683         (dwarf2_fetch_constant_bytes): Likewise
 684         (decode_locdesc): Add DW_OP_addrx
 685         (skip_form_bytes): Add DW_FORM_addrx
 686
 687 2019-04-22  Ali Tamur  <tamur@google.com>
 688
 689         * MAINTAINERS (Write After Approval): Add self.
 690
 691 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 692
 693         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 694         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 695         (open_symbol_file_object): Likewise.
 696         (svr4_default_sos): Add info parameter.
 697         (svr4_read_so_list): Likewise.
 698         (svr4_current_sos_direct): Adjust functions calls to pass down
 699         info.
 700         (svr4_current_sos_1): Add info parameter.
 701         (svr4_current_sos): Call get_svr4_info, pass info down to
 702         svr4_current_sos_1.
 703         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 704         get_svr4_info.
 705         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 706         get_svr4_info.
 707         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 708         to get_svr4_info.
 709         (probes_table_remove_objfile_probes): Likewise.
 710         (register_solib_event_probe): Add info parameter.
 711         (solist_update_incremental): Pass info parameter down to
 712         svr4_read_so_list.
 713         (disable_probes_interface): Add info parameter.
 714         (svr4_handle_solib_event): Pass current_program_space to
 715         get_svr4_info.  Adjust disable_probes_interface cleanup.
 716         (svr4_create_probe_breakpoints): Add info parameter, pass it
 717         down to register_solib_event_probe.
 718         (svr4_create_solib_event_breakpoints): Add info parameter,
 719         pass it down to svr4_create_probe_breakpoints.
 720         (enable_break): Pass info down to
 721         svr4_create_solib_event_breakpoints.
 722         (svr4_solib_create_inferior_hook): Pass current_program_space to
 723         get_svr4_info.
 724         (svr4_clear_solib): Likewise.
 725
 726 2019-04-22  Pedro Alves  <palves@redhat.com>
 727
 728         * solib-svr4.c (svr4_free_objfile_observer): New.
 729         (probe_and_action::objfile): New field.
 730         (probes_table_htab_remove_objfile_probes)
 731         (probes_table_remove_objfile_probes): New functions.
 732         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 733         in the new probe_and_action.  Don't store the probe in 'lookup'.
 734         (svr4_create_probe_breakpoints): Pass objfile to
 735         register_solib_event_probe.
 736         (_initialize_svr4_solib): Register a free_objfile observer.
 737
 738 2019-04-19  Tom Tromey  <tom@tromey.com>
 739
 740         * common/queue.h: Remove.
 741
 742 2019-04-19  Tom Tromey  <tom@tromey.com>
 743
 744         * event-loop.c: Don't include "common/queue.h".
 745
 746 2019-04-19  Tom Tromey  <tom@tromey.com>
 747
 748         * remote.c (remote_target): Use delete.
 749         * remote-notif.h: Include <list>, not "common/queue.h".
 750         (notif_client_p): Remove typedef.
 751         (remote_notif_state): Add constructor, destructor, initializer.
 752         <notif_queue>: Now a std::list.
 753         (remote_notif_state_xfree): Don't declare.
 754         * remote-notif.c (remote_notif_process, handle_notification)
 755         (remote_notif_state_allocate): Update.
 756         (~remote_notif_state): Rename from remote_notif_state_xfree.
 757
 758 2019-04-19  Tom Tromey  <tom@tromey.com>
 759
 760         * symfile.c (reread_symbols): Update.
 761         * objfiles.c (objfile_register_static_link)
 762         (objfile_lookup_static_link): Update
 763         (~objfile) Don't delete static_links.
 764         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 765
 766 2019-04-19  Tom Tromey  <tom@tromey.com>
 767
 768         * type-stack.h (struct type_stack) <insert>: Constify string.
 769         * type-stack.c (type_stack::insert): Constify string.
 770         * gdbtypes.h (lookup_template_type): Update.
 771         (address_space_name_to_int): Update.
 772         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 773         const.
 774         (lookup_template_type): Make name const.
 775         * c-exp.y: Update rules.
 776         (lex_one_token, classify_name, classify_inner_name)
 777         (c_print_token): Update.
 778         * p-exp.y: Update rules.
 779         (yylex): Update.
 780         * f-exp.y: Update rules.
 781         (yylex): Update.
 782         * d-exp.y: Update rules.
 783         (lex_one_token, classify_name, classify_inner_name): Update.
 784         * parse.c (write_dollar_variable, copy_name): Return std::string.
 785         * parser-defs.h (copy_name): Change return type.
 786         * m2-exp.y: Update rules.
 787         (yylex): Update.
 788         * go-exp.y (lex_one_token): Update.
 789         Update rules.
 790         (classify_unsafe_function, classify_packaged_name)
 791         (classify_name, yylex): Update.
 792
 793 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 794
 795         * configure.ac: add --enable-source-highlight switch.
 796         * configure: Regenerate.
 797         * top.c (print_gdb_version): plumb --enable-source-highlight
 798         status to "show configuration".
 799
 800 2019-04-19  Tom Tromey  <tromey@adacore.com>
 801
 802         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 803         Check ADA_TYPE_P.
 804         (empty_record, ada_template_to_fixed_record_type_1)
 805         (template_to_static_fixed_type)
 806         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 807         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 808         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 809         macros.
 810
 811 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 812
 813         PR symtab/24423:
 814         * source.c (print_source_lines_base): Advance "iter" when a
 815         control character is seen.
 816
 817 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 818
 819         * inferior.h (struct infcall_suspend_state_deleter):
 820         Catch exception in destructor to avoid crash.
 821
 822 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 823
 824         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 825         close to the add_com "shell".
 826
 827 2019-04-18  Tom Tromey  <tromey@adacore.com>
 828
 829         * process-stratum-target.h (class process_stratum_target)
 830         <stratum>: Add "final".
 831
 832 2019-04-17  Tom Tromey  <tromey@adacore.com>
 833
 834         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 835         against nullptr before use.
 836
 837 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 838
 839         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 840
 841 2019-04-17  Jim Wilson  <jimw@sifive.com>
 842             Andrew Burgess  <andrew.burgess@embecosm.com>
 843
 844         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 845         code read might fail, assume 4-byte breakpoint in that case.
 846
 847 2019-04-15  Leszek Swirski  <leszeks@google.com>
 848
 849         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 850         rather than a hand-rolled POD check when checking for forced MEMORY
 851         classification.
 852
 853 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 854
 855         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 856         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 857         function.
 858         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 859         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 860         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 861         declaration.
 862
 863 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 864
 865         * aarch64-linux-nat.c
 866         (aarch64_linux_nat_target::thread_architecture): Add override.
 867         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 868         each VQ.
 869
 870 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 871
 872         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 873
 874 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 877         target types of size 96-bits, add some additional comments, and
 878         check that the builtin type we found was the correct size.
 879
 880 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 881
 882         * utils.c (prompt_for_continue): Don't restore the styling at the
 883         end, as applied_style has the wrong value.  This fixes styling in
 884         long lists of file names that are interrupted by the "Continue?"
 885         prompt.
 886
 887 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 890         * c-lang.c (c_language_defn): Likewise.
 891         (cplus_language_defn): Likewise.
 892         (asm_language_defn): Likewise.
 893         (minimal_language_defn): Likewise.
 894         * d-lang.c (d_language_defn): Likewise.
 895         * f-lang.c (f_language_defn): Likewise.
 896         * go-lang.c (go_language_defn): Likewise.
 897         * language.c (unknown_language_defn): Likewise.
 898         (auto_language_defn): Likewise.
 899         * language.h (struct language_defn): Remove la_magic field.
 900         (LANG_MAGIC): Delete.
 901         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 902         * objc-lang.c (objc_language_defn): Likewise.
 903         * opencl-lang.c (opencl_language_defn): Likewise.
 904         * p-lang.c (pascal_language_defn): Likewise.
 905         * rust-lang.c (rust_language_defn): Likewise.
 906
 907 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * riscv-tdep.c (riscv_type_align): New function.
 910         (riscv_type_alignment): Delete.
 911         (riscv_arg_location): Use 'type_align'.
 912         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 913
 914 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * gdbtypes.c (type_align): A struct with no non-static fields also
 917         has alignment of 1.
 918
 919 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 920
 921         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 922         component to 0.
 923         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 924         member.
 925         (riscv_struct_info::analyse): New implementation using new
 926         analyse_inner member function.
 927         (riscv_struct_info::field_offset): New member function.
 928         (riscv_struct_info::m_offsets): New member variable.
 929         (riscv_struct_info::analyse_inner): New private member function,
 930         takes the old implementation of riscv_struct_info::analyse but
 931         extended to track field offsets.
 932         (riscv_call_arg_struct): Update the struct folding special cases
 933         to handle cases where empty C++ structs, which are non-zero
 934         length, are found.
 935         (riscv_arg_location): Initialise the length of each location, a
 936         non-zero length now indicates the location is in use.
 937         (riscv_push_dummy_call): Allow for the first location having a
 938         non-zero offset when setting up arguments.
 939         (riscv_return_value): Likewise, but for return values.
 940
 941 2019-04-11  Tom Tromey  <tromey@adacore.com>
 942
 943         * utils.c (internal_vproblem): Make "msg" const.
 944
 945 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 946
 947         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 948         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 949         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 950         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 951
 952 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 953
 954         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 955         function.
 956         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 957         of amd64_collect_native_gregset.
 958         (amd64_linux_nat_target::store_registers): Likewise.
 959
 960 2019-04-10  Tom Tromey  <tom@tromey.com>
 961
 962         * symtab.c (lookup_global_symbol_from_objfile)
 963         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 964         * objfiles.h (class separate_debug_iterator): New.
 965         (class separate_debug_range): New.
 966         (struct objfile) <separate_debug_objfiles>: New method.
 967         (objfile_separate_debug_iterate): Don't declare.
 968         * objfiles.c (separate_debug_iterator::operator++): Rename from
 969         objfile_separate_debug_iterate.
 970         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 971         iterator.
 972         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 973         iterator.
 974
 975 2019-04-10  Tom Tromey  <tom@tromey.com>
 976
 977         * symfile.c (reread_symbols): Remove old comment.
 978         * objfiles.c (free_all_objfiles): Fix a typo.
 979
 980 2019-04-10  Tom Tromey  <tom@tromey.com>
 981
 982         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 983         * minsyms.c (lookup_minimal_symbol): Use foreach.
 984         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 985         (lookup_minimal_symbol_solib_trampoline): Likewise.
 986         * symfile.c (reread_symbols): Use foreach.
 987
 988 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 989             Tom Tromey  <tromey@adacore.com>
 990
 991         PR rust/24414:
 992         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 993         (rust_lex_int_test): Change "value" to be LONGEST.
 994         (rust_lex_tests): Add test for long integer literal.
 995
 996 2019-04-09  Tom Tromey  <tromey@adacore.com>
 997
 998         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 999         to bool.
1000         (extended_remote_target::attach): Update.
1001         (remote_target::remote_notice_new_inferior): Update.
1002         (remote_target::add_current_inferior_and_thread): Update.
1003         * inferior.c (exit_inferior_1): Use "false".
1004         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1005
1006 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1007
1008         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1009         the "start" command.
1010
1011 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1012
1013         * python/py-inferior.c (infpy_thread_from_thread_handle):
1014         Adjust comments to reflect renaming of thread_from_thread_handle
1015         to thread_from_handle.  Adjust keywords.  Fix type error message.
1016         (inferior_object_methods): Add thread_from_handle.  Retain
1017         thread_from_thread_handle, but mark it as deprecated.
1018
1019 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1020
1021         * gdbthread.h (find_thread_by_handle): Revise declaration.
1022         * thread.c (find_thread_by_handle): Likewise.  Adjust
1023         implementation too.
1024         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1025         support for buffer objects as handles.
1026
1027 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1028
1029         * python/py-infthread.c (thpy_thread_handle): New function.
1030         (thread_object_methods): Register thpy_thread_handle.
1031
1032 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1033
1034         * gdbthread.h (thread_to_thread_handle): Declare.
1035         * thread.c (gdbtypes.h): Include.
1036         (thread_to_thread_handle): New function.
1037
1038         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1039         (target_thread_info_to_thread_handle): Declare.
1040         * target.c (target_thread_info_to_thread_handle): New function.
1041         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1042         * target-delegates.c: Regenerate.
1043
1044         * linux-thread-db.c (class thread_db_target): Add method
1045         thread_info_to_thread_handle.
1046         (thread_db_target::thread_info_to_thread_handle): Define.
1047         * remote.c (class remote_target): Add new method
1048         thread_info_to_thread_handle.
1049         (remote_target::thread_info_to_thread_handle): Define.
1050
1051 2019-04-08  Pedro Alves  <palves@redhat.com>
1052
1053         * common/common-exceptions.c (throw_exception): Don't create
1054         named object to throw; throw directly.
1055         (throw_it): Likewise.  Don't initialize gdb_exception::message
1056         here, with new; pass FMT and AP to the ctor instead.
1057         * common/common-exceptions.h: Include <string>.
1058         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1059         const char *, va_list)): New ctor.  Use std::make_shared.
1060         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1061         errors)): Delete.
1062         (gdb_exception_error::gdb_exception_error(enum errors, const char
1063         *, va_list)): New.
1064         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1065         Add assertion.
1066         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1067         errors)): Delete.
1068         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1069         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1070         Add assertion.
1071
1072 2019-04-08  Tom Tromey  <tom@tromey.com>
1073
1074         * valops.c (value_rtti_indirect_type): Replace throw_exception
1075         with throw.
1076         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1077         with throw.
1078         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1079         throw.
1080         * target.c (target_translate_tls_address): Replace throw_exception
1081         with throw.
1082         * stack.c (frame_apply_command_count): Replace throw_exception
1083         with throw.
1084         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1085         throw.
1086         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1087         with throw.
1088         * rs6000-tdep.c (rs6000_frame_cache)
1089         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1090         * remote.c: Replace throw_exception with throw.
1091         * record-full.c (record_full_message, record_full_wait_1)
1092         (record_full_restore): Replace throw_exception with throw.
1093         * record-btrace.c:
1094         (get_thread_current_frame_id, record_btrace_start_replaying)
1095         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1096         (cmd_record_btrace_start): Replace throw_exception with throw.
1097         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1098         throw.
1099         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1100         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1101         * linespec.c:
1102         (find_linespec_symbols): Replace throw_exception with throw.
1103         * infrun.c (displaced_step_prepare, resume): Replace
1104         throw_exception with throw.
1105         * infcmd.c (post_create_inferior): Replace throw_exception with
1106         throw.
1107         * inf-loop.c (inferior_event_handler): Replace throw_exception
1108         with throw.
1109         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1110         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1111         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1112         (get_prev_frame_always, get_frame_pc_if_available)
1113         (get_frame_address_in_block_if_available, get_frame_language):
1114         Replace throw_exception with throw.
1115         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1116         throw_exception with throw.
1117         * eval.c (fetch_subexp_value, evaluate_var_value)
1118         (evaluate_funcall, evaluate_subexp_standard): Replace
1119         throw_exception with throw.
1120         * dwarf2loc.c (call_site_find_chain)
1121         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1122         Replace throw_exception with throw.
1123         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1124         with throw.
1125         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1126         throw.
1127         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1128         * completer.c (complete_line_internal): Replace throw_exception
1129         with throw.
1130         * compile/compile-object-run.c (compile_object_run): Replace
1131         throw_exception with throw.
1132         * cli/cli-script.c (process_next_line): Replace throw_exception
1133         with throw.
1134         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1135         (btrace_enable, btrace_maint_update_pt_packets): Replace
1136         throw_exception with throw.
1137         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1138         throw_exception with throw.
1139         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1140         throw_exception with throw.
1141         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1142         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1143         * aarch64-tdep.c (aarch64_make_prologue_cache)
1144         (aarch64_make_stub_cache): Replace throw_exception with throw.
1145
1146 2019-04-08  Tom Tromey  <tom@tromey.com>
1147
1148         * common/common-exceptions.c (throw_exception): Rename from
1149         throw_exception_cxx.  Remove old copy.  Make argument const.
1150         (throw_it): Create and throw exception objects directly.
1151         * common/common-exceptions.h (throw_exception): Make argument
1152         const.
1153         (struct gdb_exception_error): Add constructor.
1154         (struct gdb_exception_quit): Add constructor.
1155
1156 2019-04-08  Tom Tromey  <tom@tromey.com>
1157
1158         * common/common-exceptions.h (exception_rethrow): Don't declare.
1159         (TRY_SJLJ): Update comment.
1160         (TRY, CATCH, END_CATCH): Remove.
1161         * common/common-exceptions.c (exception_rethrow): Remove.
1162
1163 2019-04-08  Tom Tromey  <tom@tromey.com>
1164
1165         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1166         Remove.
1167         (gdb_exception_error): Rename from
1168         gdb_exception_RETURN_MASK_ERROR.
1169         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1170         (gdb_quit_bad_alloc): Update.
1171         * aarch64-tdep.c: Update.
1172         * ada-lang.c: Update.
1173         * ada-typeprint.c: Update.
1174         * ada-valprint.c: Update.
1175         * amd64-tdep.c: Update.
1176         * arch-utils.c: Update.
1177         * break-catch-throw.c: Update.
1178         * breakpoint.c: Update.
1179         * btrace.c: Update.
1180         * c-varobj.c: Update.
1181         * cli/cli-cmds.c: Update.
1182         * cli/cli-interp.c: Update.
1183         * cli/cli-script.c: Update.
1184         * common/common-exceptions.c: Update.
1185         * common/new-op.c: Update.
1186         * common/selftest.c: Update.
1187         * compile/compile-c-symbols.c: Update.
1188         * compile/compile-cplus-symbols.c: Update.
1189         * compile/compile-object-load.c: Update.
1190         * compile/compile-object-run.c: Update.
1191         * completer.c: Update.
1192         * corelow.c: Update.
1193         * cp-abi.c: Update.
1194         * cp-support.c: Update.
1195         * cp-valprint.c: Update.
1196         * darwin-nat.c: Update.
1197         * disasm-selftests.c: Update.
1198         * dtrace-probe.c: Update.
1199         * dwarf-index-cache.c: Update.
1200         * dwarf-index-write.c: Update.
1201         * dwarf2-frame-tailcall.c: Update.
1202         * dwarf2-frame.c: Update.
1203         * dwarf2loc.c: Update.
1204         * dwarf2read.c: Update.
1205         * eval.c: Update.
1206         * event-loop.c: Update.
1207         * event-top.c: Update.
1208         * exec.c: Update.
1209         * f-valprint.c: Update.
1210         * fbsd-tdep.c: Update.
1211         * frame-unwind.c: Update.
1212         * frame.c: Update.
1213         * gdbtypes.c: Update.
1214         * gnu-v3-abi.c: Update.
1215         * guile/guile-internal.h: Update.
1216         * guile/scm-block.c: Update.
1217         * guile/scm-breakpoint.c: Update.
1218         * guile/scm-cmd.c: Update.
1219         * guile/scm-disasm.c: Update.
1220         * guile/scm-frame.c: Update.
1221         * guile/scm-lazy-string.c: Update.
1222         * guile/scm-math.c: Update.
1223         * guile/scm-param.c: Update.
1224         * guile/scm-ports.c: Update.
1225         * guile/scm-pretty-print.c: Update.
1226         * guile/scm-symbol.c: Update.
1227         * guile/scm-symtab.c: Update.
1228         * guile/scm-type.c: Update.
1229         * guile/scm-value.c: Update.
1230         * i386-linux-tdep.c: Update.
1231         * i386-tdep.c: Update.
1232         * inf-loop.c: Update.
1233         * infcall.c: Update.
1234         * infcmd.c: Update.
1235         * infrun.c: Update.
1236         * jit.c: Update.
1237         * language.c: Update.
1238         * linespec.c: Update.
1239         * linux-fork.c: Update.
1240         * linux-nat.c: Update.
1241         * linux-tdep.c: Update.
1242         * linux-thread-db.c: Update.
1243         * main.c: Update.
1244         * mi/mi-cmd-break.c: Update.
1245         * mi/mi-cmd-stack.c: Update.
1246         * mi/mi-interp.c: Update.
1247         * mi/mi-main.c: Update.
1248         * objc-lang.c: Update.
1249         * p-valprint.c: Update.
1250         * parse.c: Update.
1251         * ppc-linux-tdep.c: Update.
1252         * printcmd.c: Update.
1253         * python/py-arch.c: Update.
1254         * python/py-breakpoint.c: Update.
1255         * python/py-cmd.c: Update.
1256         * python/py-finishbreakpoint.c: Update.
1257         * python/py-frame.c: Update.
1258         * python/py-framefilter.c: Update.
1259         * python/py-gdb-readline.c: Update.
1260         * python/py-inferior.c: Update.
1261         * python/py-infthread.c: Update.
1262         * python/py-lazy-string.c: Update.
1263         * python/py-linetable.c: Update.
1264         * python/py-objfile.c: Update.
1265         * python/py-param.c: Update.
1266         * python/py-prettyprint.c: Update.
1267         * python/py-progspace.c: Update.
1268         * python/py-record-btrace.c: Update.
1269         * python/py-record.c: Update.
1270         * python/py-symbol.c: Update.
1271         * python/py-type.c: Update.
1272         * python/py-unwind.c: Update.
1273         * python/py-utils.c: Update.
1274         * python/py-value.c: Update.
1275         * python/python.c: Update.
1276         * record-btrace.c: Update.
1277         * record-full.c: Update.
1278         * remote-fileio.c: Update.
1279         * remote.c: Update.
1280         * riscv-tdep.c: Update.
1281         * rs6000-aix-tdep.c: Update.
1282         * rs6000-tdep.c: Update.
1283         * rust-exp.y: Update.
1284         * rust-lang.c: Update.
1285         * s390-tdep.c: Update.
1286         * selftest-arch.c: Update.
1287         * solib-dsbt.c: Update.
1288         * solib-frv.c: Update.
1289         * solib-spu.c: Update.
1290         * solib-svr4.c: Update.
1291         * solib.c: Update.
1292         * sparc64-linux-tdep.c: Update.
1293         * stack.c: Update.
1294         * symfile-mem.c: Update.
1295         * symmisc.c: Update.
1296         * target.c: Update.
1297         * thread.c: Update.
1298         * top.c: Update.
1299         * tracefile-tfile.c: Update.
1300         * tui/tui.c: Update.
1301         * typeprint.c: Update.
1302         * unittests/cli-utils-selftests.c: Update.
1303         * unittests/parse-connection-spec-selftests.c: Update.
1304         * valops.c: Update.
1305         * valprint.c: Update.
1306         * value.c: Update.
1307         * varobj.c: Update.
1308         * windows-nat.c: Update.
1309         * x86-linux-nat.c: Update.
1310         * xml-support.c: Update.
1311
1312 2019-04-08  Tom Tromey  <tom@tromey.com>
1313
1314         * xml-support.c: Use C++ exception handling.
1315         * x86-linux-nat.c: Use C++ exception handling.
1316         * windows-nat.c: Use C++ exception handling.
1317         * varobj.c: Use C++ exception handling.
1318         * value.c: Use C++ exception handling.
1319         * valprint.c: Use C++ exception handling.
1320         * valops.c: Use C++ exception handling.
1321         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1322         handling.
1323         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1324         * typeprint.c: Use C++ exception handling.
1325         * tui/tui.c: Use C++ exception handling.
1326         * tracefile-tfile.c: Use C++ exception handling.
1327         * top.c: Use C++ exception handling.
1328         * thread.c: Use C++ exception handling.
1329         * target.c: Use C++ exception handling.
1330         * symmisc.c: Use C++ exception handling.
1331         * symfile-mem.c: Use C++ exception handling.
1332         * stack.c: Use C++ exception handling.
1333         * sparc64-linux-tdep.c: Use C++ exception handling.
1334         * solib.c: Use C++ exception handling.
1335         * solib-svr4.c: Use C++ exception handling.
1336         * solib-spu.c: Use C++ exception handling.
1337         * solib-frv.c: Use C++ exception handling.
1338         * solib-dsbt.c: Use C++ exception handling.
1339         * selftest-arch.c: Use C++ exception handling.
1340         * s390-tdep.c: Use C++ exception handling.
1341         * rust-lang.c: Use C++ exception handling.
1342         * rust-exp.y: Use C++ exception handling.
1343         * rs6000-tdep.c: Use C++ exception handling.
1344         * rs6000-aix-tdep.c: Use C++ exception handling.
1345         * riscv-tdep.c: Use C++ exception handling.
1346         * remote.c: Use C++ exception handling.
1347         * remote-fileio.c: Use C++ exception handling.
1348         * record-full.c: Use C++ exception handling.
1349         * record-btrace.c: Use C++ exception handling.
1350         * python/python.c: Use C++ exception handling.
1351         * python/py-value.c: Use C++ exception handling.
1352         * python/py-utils.c: Use C++ exception handling.
1353         * python/py-unwind.c: Use C++ exception handling.
1354         * python/py-type.c: Use C++ exception handling.
1355         * python/py-symbol.c: Use C++ exception handling.
1356         * python/py-record.c: Use C++ exception handling.
1357         * python/py-record-btrace.c: Use C++ exception handling.
1358         * python/py-progspace.c: Use C++ exception handling.
1359         * python/py-prettyprint.c: Use C++ exception handling.
1360         * python/py-param.c: Use C++ exception handling.
1361         * python/py-objfile.c: Use C++ exception handling.
1362         * python/py-linetable.c: Use C++ exception handling.
1363         * python/py-lazy-string.c: Use C++ exception handling.
1364         * python/py-infthread.c: Use C++ exception handling.
1365         * python/py-inferior.c: Use C++ exception handling.
1366         * python/py-gdb-readline.c: Use C++ exception handling.
1367         * python/py-framefilter.c: Use C++ exception handling.
1368         * python/py-frame.c: Use C++ exception handling.
1369         * python/py-finishbreakpoint.c: Use C++ exception handling.
1370         * python/py-cmd.c: Use C++ exception handling.
1371         * python/py-breakpoint.c: Use C++ exception handling.
1372         * python/py-arch.c: Use C++ exception handling.
1373         * printcmd.c: Use C++ exception handling.
1374         * ppc-linux-tdep.c: Use C++ exception handling.
1375         * parse.c: Use C++ exception handling.
1376         * p-valprint.c: Use C++ exception handling.
1377         * objc-lang.c: Use C++ exception handling.
1378         * mi/mi-main.c: Use C++ exception handling.
1379         * mi/mi-interp.c: Use C++ exception handling.
1380         * mi/mi-cmd-stack.c: Use C++ exception handling.
1381         * mi/mi-cmd-break.c: Use C++ exception handling.
1382         * main.c: Use C++ exception handling.
1383         * linux-thread-db.c: Use C++ exception handling.
1384         * linux-tdep.c: Use C++ exception handling.
1385         * linux-nat.c: Use C++ exception handling.
1386         * linux-fork.c: Use C++ exception handling.
1387         * linespec.c: Use C++ exception handling.
1388         * language.c: Use C++ exception handling.
1389         * jit.c: Use C++ exception handling.
1390         * infrun.c: Use C++ exception handling.
1391         * infcmd.c: Use C++ exception handling.
1392         * infcall.c: Use C++ exception handling.
1393         * inf-loop.c: Use C++ exception handling.
1394         * i386-tdep.c: Use C++ exception handling.
1395         * i386-linux-tdep.c: Use C++ exception handling.
1396         * guile/scm-value.c: Use C++ exception handling.
1397         * guile/scm-type.c: Use C++ exception handling.
1398         * guile/scm-symtab.c: Use C++ exception handling.
1399         * guile/scm-symbol.c: Use C++ exception handling.
1400         * guile/scm-pretty-print.c: Use C++ exception handling.
1401         * guile/scm-ports.c: Use C++ exception handling.
1402         * guile/scm-param.c: Use C++ exception handling.
1403         * guile/scm-math.c: Use C++ exception handling.
1404         * guile/scm-lazy-string.c: Use C++ exception handling.
1405         * guile/scm-frame.c: Use C++ exception handling.
1406         * guile/scm-disasm.c: Use C++ exception handling.
1407         * guile/scm-cmd.c: Use C++ exception handling.
1408         * guile/scm-breakpoint.c: Use C++ exception handling.
1409         * guile/scm-block.c: Use C++ exception handling.
1410         * guile/guile-internal.h: Use C++ exception handling.
1411         * gnu-v3-abi.c: Use C++ exception handling.
1412         * gdbtypes.c: Use C++ exception handling.
1413         * frame.c: Use C++ exception handling.
1414         * frame-unwind.c: Use C++ exception handling.
1415         * fbsd-tdep.c: Use C++ exception handling.
1416         * f-valprint.c: Use C++ exception handling.
1417         * exec.c: Use C++ exception handling.
1418         * event-top.c: Use C++ exception handling.
1419         * event-loop.c: Use C++ exception handling.
1420         * eval.c: Use C++ exception handling.
1421         * dwarf2read.c: Use C++ exception handling.
1422         * dwarf2loc.c: Use C++ exception handling.
1423         * dwarf2-frame.c: Use C++ exception handling.
1424         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1425         * dwarf-index-write.c: Use C++ exception handling.
1426         * dwarf-index-cache.c: Use C++ exception handling.
1427         * dtrace-probe.c: Use C++ exception handling.
1428         * disasm-selftests.c: Use C++ exception handling.
1429         * darwin-nat.c: Use C++ exception handling.
1430         * cp-valprint.c: Use C++ exception handling.
1431         * cp-support.c: Use C++ exception handling.
1432         * cp-abi.c: Use C++ exception handling.
1433         * corelow.c: Use C++ exception handling.
1434         * completer.c: Use C++ exception handling.
1435         * compile/compile-object-run.c: Use C++ exception handling.
1436         * compile/compile-object-load.c: Use C++ exception handling.
1437         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1438         * compile/compile-c-symbols.c: Use C++ exception handling.
1439         * common/selftest.c: Use C++ exception handling.
1440         * common/new-op.c: Use C++ exception handling.
1441         * cli/cli-script.c: Use C++ exception handling.
1442         * cli/cli-interp.c: Use C++ exception handling.
1443         * cli/cli-cmds.c: Use C++ exception handling.
1444         * c-varobj.c: Use C++ exception handling.
1445         * btrace.c: Use C++ exception handling.
1446         * breakpoint.c: Use C++ exception handling.
1447         * break-catch-throw.c: Use C++ exception handling.
1448         * arch-utils.c: Use C++ exception handling.
1449         * amd64-tdep.c: Use C++ exception handling.
1450         * ada-valprint.c: Use C++ exception handling.
1451         * ada-typeprint.c: Use C++ exception handling.
1452         * ada-lang.c: Use C++ exception handling.
1453         * aarch64-tdep.c: Use C++ exception handling.
1454
1455 2019-04-08  Tom Tromey  <tom@tromey.com>
1456
1457         * xml-support.c (gdb_xml_parser::parse): Update.
1458         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1459         * value.c (show_convenience): Update.
1460         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1461         (test_parse_flags_qcs): Update.
1462         * thread.c (thr_try_catch_cmd): Update.
1463         * target.c (target_translate_tls_address): Update.
1464         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1465         (info_frame_command_core, frame_apply_command_count): Update.
1466         * rust-exp.y (rust_lex_exception_test): Update.
1467         * riscv-tdep.c (riscv_print_one_register_info): Update.
1468         * remote.c (remote_target::enable_btrace): Update.
1469         * record-btrace.c (record_btrace_enable_warn): Update.
1470         * python/py-utils.c (gdbpy_convert_exception): Update.
1471         * printcmd.c (do_one_display, print_variable_and_value): Update.
1472         * mi/mi-main.c (mi_print_exception): Update.
1473         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1474         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1475         * linux-nat.c (linux_nat_target::attach): Update.
1476         * linux-fork.c (class scoped_switch_fork_info): Update.
1477         * infrun.c (displaced_step_prepare): Update.
1478         * infcall.c (call_function_by_hand_dummy): Update.
1479         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1480         * gnu-v3-abi.c (print_one_vtable): Update.
1481         * frame.c (get_prev_frame_always): Update.
1482         * f-valprint.c (info_common_command_for_block): Update.
1483         * exec.c (try_open_exec_file): Update.
1484         * exceptions.c (print_exception, exception_print)
1485         (exception_fprintf, exception_print_same): Update.
1486         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1487         * dwarf-index-cache.c (index_cache::store)
1488         (index_cache::lookup_gdb_index): Update.
1489         * darwin-nat.c (maybe_cache_shell): Update.
1490         * cp-valprint.c (cp_print_value_fields): Update.
1491         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1492         (gcc_cplus_symbol_address): Update.
1493         * compile/compile-c-symbols.c (gcc_convert_symbol)
1494         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1495         * common/selftest.c: Update.
1496         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1497         a std::string.
1498         (exception_try_scope_entry, exception_try_scope_exit): Don't
1499         declare.
1500         (struct exception_try_scope): Remove.
1501         (TRY): Don't use exception_try_scope.
1502         (struct gdb_exception): Add constructor, operator=.
1503         <what>: New method.
1504         (struct gdb_exception_RETURN_MASK_ALL)
1505         (struct gdb_exception_RETURN_MASK_ERROR)
1506         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1507         (struct gdb_quit_bad_alloc): Update.
1508         * common/common-exceptions.c (exception_none): Change
1509         initializer.
1510         (struct catcher) <state, exception>: Initialize inline.
1511         <prev>: Remove member.
1512         (current_catcher): Remove.
1513         (catchers): New global.
1514         (exceptions_state_mc_init): Simplify.
1515         (catcher_pop): Remove.
1516         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1517         (try_scope_depth, exception_try_scope_entry)
1518         (exception_try_scope_exit): Remove.
1519         (throw_exception_sjlj): Update.
1520         (exception_messages, exception_messages_size): Remove.
1521         (throw_it): Simplify.
1522         (gdb_exception_sliced_copy): Remove.
1523         (throw_exception_cxx): Update.
1524         * cli/cli-script.c (script_from_file): Update.
1525         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1526         Update.
1527         * ada-valprint.c (ada_val_print): Update.
1528         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1529         (create_excep_cond_exprs): Update.
1530
1531 2019-04-08  Tom Tromey  <tom@tromey.com>
1532
1533         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1534         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1535         (TRY, CATCH, END_CATCH): Remove some definitions.
1536         * common/common-exceptions.c: Don't use GDB_XCPT.
1537         (catcher_list_size): Remove.
1538         (throw_exception, throw_it): Simplify.
1539
1540 2019-04-05  Tom Tromey  <tom@tromey.com>
1541
1542         Revert the header-sorting patch.
1543         * ft32-tdep.c: Revert.
1544         * frv-tdep.c: Revert.
1545         * frv-linux-tdep.c: Revert.
1546         * frame.c: Revert.
1547         * frame-unwind.c: Revert.
1548         * frame-base.c: Revert.
1549         * fork-child.c: Revert.
1550         * findvar.c: Revert.
1551         * findcmd.c: Revert.
1552         * filesystem.c: Revert.
1553         * filename-seen-cache.h: Revert.
1554         * filename-seen-cache.c: Revert.
1555         * fbsd-tdep.c: Revert.
1556         * fbsd-nat.h: Revert.
1557         * fbsd-nat.c: Revert.
1558         * f-valprint.c: Revert.
1559         * f-typeprint.c: Revert.
1560         * f-lang.c: Revert.
1561         * extension.h: Revert.
1562         * extension.c: Revert.
1563         * extension-priv.h: Revert.
1564         * expprint.c: Revert.
1565         * exec.h: Revert.
1566         * exec.c: Revert.
1567         * exceptions.c: Revert.
1568         * event-top.c: Revert.
1569         * event-loop.c: Revert.
1570         * eval.c: Revert.
1571         * elfread.c: Revert.
1572         * dwarf2read.h: Revert.
1573         * dwarf2read.c: Revert.
1574         * dwarf2loc.c: Revert.
1575         * dwarf2expr.h: Revert.
1576         * dwarf2expr.c: Revert.
1577         * dwarf2-frame.c: Revert.
1578         * dwarf2-frame-tailcall.c: Revert.
1579         * dwarf-index-write.h: Revert.
1580         * dwarf-index-write.c: Revert.
1581         * dwarf-index-common.c: Revert.
1582         * dwarf-index-cache.h: Revert.
1583         * dwarf-index-cache.c: Revert.
1584         * dummy-frame.c: Revert.
1585         * dtrace-probe.c: Revert.
1586         * disasm.h: Revert.
1587         * disasm.c: Revert.
1588         * disasm-selftests.c: Revert.
1589         * dictionary.c: Revert.
1590         * dicos-tdep.c: Revert.
1591         * demangle.c: Revert.
1592         * dcache.h: Revert.
1593         * dcache.c: Revert.
1594         * darwin-nat.h: Revert.
1595         * darwin-nat.c: Revert.
1596         * darwin-nat-info.c: Revert.
1597         * d-valprint.c: Revert.
1598         * d-namespace.c: Revert.
1599         * d-lang.c: Revert.
1600         * ctf.c: Revert.
1601         * csky-tdep.c: Revert.
1602         * csky-linux-tdep.c: Revert.
1603         * cris-tdep.c: Revert.
1604         * cris-linux-tdep.c: Revert.
1605         * cp-valprint.c: Revert.
1606         * cp-support.c: Revert.
1607         * cp-namespace.c: Revert.
1608         * cp-abi.c: Revert.
1609         * corelow.c: Revert.
1610         * corefile.c: Revert.
1611         * continuations.c: Revert.
1612         * completer.h: Revert.
1613         * completer.c: Revert.
1614         * complaints.c: Revert.
1615         * coffread.c: Revert.
1616         * coff-pe-read.c: Revert.
1617         * cli-out.h: Revert.
1618         * cli-out.c: Revert.
1619         * charset.c: Revert.
1620         * c-varobj.c: Revert.
1621         * c-valprint.c: Revert.
1622         * c-typeprint.c: Revert.
1623         * c-lang.c: Revert.
1624         * buildsym.c: Revert.
1625         * buildsym-legacy.c: Revert.
1626         * build-id.h: Revert.
1627         * build-id.c: Revert.
1628         * btrace.c: Revert.
1629         * bsd-uthread.c: Revert.
1630         * breakpoint.h: Revert.
1631         * breakpoint.c: Revert.
1632         * break-catch-throw.c: Revert.
1633         * break-catch-syscall.c: Revert.
1634         * break-catch-sig.c: Revert.
1635         * blockframe.c: Revert.
1636         * block.c: Revert.
1637         * bfin-tdep.c: Revert.
1638         * bfin-linux-tdep.c: Revert.
1639         * bfd-target.c: Revert.
1640         * bcache.c: Revert.
1641         * ax-general.c: Revert.
1642         * ax-gdb.h: Revert.
1643         * ax-gdb.c: Revert.
1644         * avr-tdep.c: Revert.
1645         * auxv.c: Revert.
1646         * auto-load.c: Revert.
1647         * arm-wince-tdep.c: Revert.
1648         * arm-tdep.c: Revert.
1649         * arm-symbian-tdep.c: Revert.
1650         * arm-pikeos-tdep.c: Revert.
1651         * arm-obsd-tdep.c: Revert.
1652         * arm-nbsd-tdep.c: Revert.
1653         * arm-nbsd-nat.c: Revert.
1654         * arm-linux-tdep.c: Revert.
1655         * arm-linux-nat.c: Revert.
1656         * arm-fbsd-tdep.c: Revert.
1657         * arm-fbsd-nat.c: Revert.
1658         * arm-bsd-tdep.c: Revert.
1659         * arch-utils.c: Revert.
1660         * arc-tdep.c: Revert.
1661         * arc-newlib-tdep.c: Revert.
1662         * annotate.h: Revert.
1663         * annotate.c: Revert.
1664         * amd64-windows-tdep.c: Revert.
1665         * amd64-windows-nat.c: Revert.
1666         * amd64-tdep.c: Revert.
1667         * amd64-sol2-tdep.c: Revert.
1668         * amd64-obsd-tdep.c: Revert.
1669         * amd64-obsd-nat.c: Revert.
1670         * amd64-nbsd-tdep.c: Revert.
1671         * amd64-nbsd-nat.c: Revert.
1672         * amd64-nat.c: Revert.
1673         * amd64-linux-tdep.c: Revert.
1674         * amd64-linux-nat.c: Revert.
1675         * amd64-fbsd-tdep.c: Revert.
1676         * amd64-fbsd-nat.c: Revert.
1677         * amd64-dicos-tdep.c: Revert.
1678         * amd64-darwin-tdep.c: Revert.
1679         * amd64-bsd-nat.c: Revert.
1680         * alpha-tdep.c: Revert.
1681         * alpha-obsd-tdep.c: Revert.
1682         * alpha-nbsd-tdep.c: Revert.
1683         * alpha-mdebug-tdep.c: Revert.
1684         * alpha-linux-tdep.c: Revert.
1685         * alpha-linux-nat.c: Revert.
1686         * alpha-bsd-tdep.c: Revert.
1687         * alpha-bsd-nat.c: Revert.
1688         * aix-thread.c: Revert.
1689         * agent.c: Revert.
1690         * addrmap.c: Revert.
1691         * ada-varobj.c: Revert.
1692         * ada-valprint.c: Revert.
1693         * ada-typeprint.c: Revert.
1694         * ada-tasks.c: Revert.
1695         * ada-lang.c: Revert.
1696         * aarch64-tdep.c: Revert.
1697         * aarch64-ravenscar-thread.c: Revert.
1698         * aarch64-newlib-tdep.c: Revert.
1699         * aarch64-linux-tdep.c: Revert.
1700         * aarch64-linux-nat.c: Revert.
1701         * aarch64-fbsd-tdep.c: Revert.
1702         * aarch64-fbsd-nat.c: Revert.
1703         * aarch32-linux-nat.c: Revert.
1704
1705 2019-04-05  Tom Tromey  <tom@tromey.com>
1706
1707         * ft32-tdep.c: Sort headers.
1708         * frv-tdep.c: Sort headers.
1709         * frv-linux-tdep.c: Sort headers.
1710         * frame.c: Sort headers.
1711         * frame-unwind.c: Sort headers.
1712         * frame-base.c: Sort headers.
1713         * fork-child.c: Sort headers.
1714         * findvar.c: Sort headers.
1715         * findcmd.c: Sort headers.
1716         * filesystem.c: Sort headers.
1717         * filename-seen-cache.h: Sort headers.
1718         * filename-seen-cache.c: Sort headers.
1719         * fbsd-tdep.c: Sort headers.
1720         * fbsd-nat.h: Sort headers.
1721         * fbsd-nat.c: Sort headers.
1722         * f-valprint.c: Sort headers.
1723         * f-typeprint.c: Sort headers.
1724         * f-lang.c: Sort headers.
1725         * extension.h: Sort headers.
1726         * extension.c: Sort headers.
1727         * extension-priv.h: Sort headers.
1728         * expprint.c: Sort headers.
1729         * exec.h: Sort headers.
1730         * exec.c: Sort headers.
1731         * exceptions.c: Sort headers.
1732         * event-top.c: Sort headers.
1733         * event-loop.c: Sort headers.
1734         * eval.c: Sort headers.
1735         * elfread.c: Sort headers.
1736         * dwarf2read.h: Sort headers.
1737         * dwarf2read.c: Sort headers.
1738         * dwarf2loc.c: Sort headers.
1739         * dwarf2expr.h: Sort headers.
1740         * dwarf2expr.c: Sort headers.
1741         * dwarf2-frame.c: Sort headers.
1742         * dwarf2-frame-tailcall.c: Sort headers.
1743         * dwarf-index-write.h: Sort headers.
1744         * dwarf-index-write.c: Sort headers.
1745         * dwarf-index-common.c: Sort headers.
1746         * dwarf-index-cache.h: Sort headers.
1747         * dwarf-index-cache.c: Sort headers.
1748         * dummy-frame.c: Sort headers.
1749         * dtrace-probe.c: Sort headers.
1750         * disasm.h: Sort headers.
1751         * disasm.c: Sort headers.
1752         * disasm-selftests.c: Sort headers.
1753         * dictionary.c: Sort headers.
1754         * dicos-tdep.c: Sort headers.
1755         * demangle.c: Sort headers.
1756         * dcache.h: Sort headers.
1757         * dcache.c: Sort headers.
1758         * darwin-nat.h: Sort headers.
1759         * darwin-nat.c: Sort headers.
1760         * darwin-nat-info.c: Sort headers.
1761         * d-valprint.c: Sort headers.
1762         * d-namespace.c: Sort headers.
1763         * d-lang.c: Sort headers.
1764         * ctf.c: Sort headers.
1765         * csky-tdep.c: Sort headers.
1766         * csky-linux-tdep.c: Sort headers.
1767         * cris-tdep.c: Sort headers.
1768         * cris-linux-tdep.c: Sort headers.
1769         * cp-valprint.c: Sort headers.
1770         * cp-support.c: Sort headers.
1771         * cp-namespace.c: Sort headers.
1772         * cp-abi.c: Sort headers.
1773         * corelow.c: Sort headers.
1774         * corefile.c: Sort headers.
1775         * continuations.c: Sort headers.
1776         * completer.h: Sort headers.
1777         * completer.c: Sort headers.
1778         * complaints.c: Sort headers.
1779         * coffread.c: Sort headers.
1780         * coff-pe-read.c: Sort headers.
1781         * cli-out.h: Sort headers.
1782         * cli-out.c: Sort headers.
1783         * charset.c: Sort headers.
1784         * c-varobj.c: Sort headers.
1785         * c-valprint.c: Sort headers.
1786         * c-typeprint.c: Sort headers.
1787         * c-lang.c: Sort headers.
1788         * buildsym.c: Sort headers.
1789         * buildsym-legacy.c: Sort headers.
1790         * build-id.h: Sort headers.
1791         * build-id.c: Sort headers.
1792         * btrace.c: Sort headers.
1793         * bsd-uthread.c: Sort headers.
1794         * breakpoint.h: Sort headers.
1795         * breakpoint.c: Sort headers.
1796         * break-catch-throw.c: Sort headers.
1797         * break-catch-syscall.c: Sort headers.
1798         * break-catch-sig.c: Sort headers.
1799         * blockframe.c: Sort headers.
1800         * block.c: Sort headers.
1801         * bfin-tdep.c: Sort headers.
1802         * bfin-linux-tdep.c: Sort headers.
1803         * bfd-target.c: Sort headers.
1804         * bcache.c: Sort headers.
1805         * ax-general.c: Sort headers.
1806         * ax-gdb.h: Sort headers.
1807         * ax-gdb.c: Sort headers.
1808         * avr-tdep.c: Sort headers.
1809         * auxv.c: Sort headers.
1810         * auto-load.c: Sort headers.
1811         * arm-wince-tdep.c: Sort headers.
1812         * arm-tdep.c: Sort headers.
1813         * arm-symbian-tdep.c: Sort headers.
1814         * arm-pikeos-tdep.c: Sort headers.
1815         * arm-obsd-tdep.c: Sort headers.
1816         * arm-nbsd-tdep.c: Sort headers.
1817         * arm-nbsd-nat.c: Sort headers.
1818         * arm-linux-tdep.c: Sort headers.
1819         * arm-linux-nat.c: Sort headers.
1820         * arm-fbsd-tdep.c: Sort headers.
1821         * arm-fbsd-nat.c: Sort headers.
1822         * arm-bsd-tdep.c: Sort headers.
1823         * arch-utils.c: Sort headers.
1824         * arc-tdep.c: Sort headers.
1825         * arc-newlib-tdep.c: Sort headers.
1826         * annotate.h: Sort headers.
1827         * annotate.c: Sort headers.
1828         * amd64-windows-tdep.c: Sort headers.
1829         * amd64-windows-nat.c: Sort headers.
1830         * amd64-tdep.c: Sort headers.
1831         * amd64-sol2-tdep.c: Sort headers.
1832         * amd64-obsd-tdep.c: Sort headers.
1833         * amd64-obsd-nat.c: Sort headers.
1834         * amd64-nbsd-tdep.c: Sort headers.
1835         * amd64-nbsd-nat.c: Sort headers.
1836         * amd64-nat.c: Sort headers.
1837         * amd64-linux-tdep.c: Sort headers.
1838         * amd64-linux-nat.c: Sort headers.
1839         * amd64-fbsd-tdep.c: Sort headers.
1840         * amd64-fbsd-nat.c: Sort headers.
1841         * amd64-dicos-tdep.c: Sort headers.
1842         * amd64-darwin-tdep.c: Sort headers.
1843         * amd64-bsd-nat.c: Sort headers.
1844         * alpha-tdep.c: Sort headers.
1845         * alpha-obsd-tdep.c: Sort headers.
1846         * alpha-nbsd-tdep.c: Sort headers.
1847         * alpha-mdebug-tdep.c: Sort headers.
1848         * alpha-linux-tdep.c: Sort headers.
1849         * alpha-linux-nat.c: Sort headers.
1850         * alpha-bsd-tdep.c: Sort headers.
1851         * alpha-bsd-nat.c: Sort headers.
1852         * aix-thread.c: Sort headers.
1853         * agent.c: Sort headers.
1854         * addrmap.c: Sort headers.
1855         * ada-varobj.c: Sort headers.
1856         * ada-valprint.c: Sort headers.
1857         * ada-typeprint.c: Sort headers.
1858         * ada-tasks.c: Sort headers.
1859         * ada-lang.c: Sort headers.
1860         * aarch64-tdep.c: Sort headers.
1861         * aarch64-ravenscar-thread.c: Sort headers.
1862         * aarch64-newlib-tdep.c: Sort headers.
1863         * aarch64-linux-tdep.c: Sort headers.
1864         * aarch64-linux-nat.c: Sort headers.
1865         * aarch64-fbsd-tdep.c: Sort headers.
1866         * aarch64-fbsd-nat.c: Sort headers.
1867         * aarch32-linux-nat.c: Sort headers.
1868
1869 2019-04-04  Tom Tromey  <tom@tromey.com>
1870
1871         * varobj.c (varobj_create): Update.
1872         * rust-exp.y (struct rust_parser) <update_innermost_block,
1873         lookup_symbol>: New methods.
1874         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1875         Rename.
1876         (rust_parser::rust_lookup_type)
1877         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1878         * printcmd.c (display_command, do_one_display): Update.
1879         * parser-defs.h (struct parser_state) <parser_state>: Add
1880         "tracker" parameter.
1881         (block_tracker): New member.
1882         (class innermost_block_tracker) <innermost_block_tracker>: Add
1883         "types" parameter.
1884         <reset>: Remove method.
1885         (innermost_block): Don't declare.
1886         (null_post_parser): Update.
1887         * parse.c (innermost_block): Remove global.
1888         (write_dollar_variable): Update.
1889         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1890         Remove "tracker_types" parameter.
1891         (parse_expression): Add "tracker" parameter.
1892         (parse_expression_for_completion): Update.
1893         (null_post_parser): Add "tracker" parameter.
1894         * p-exp.y: Update rules.
1895         * m2-exp.y: Update rules.
1896         * language.h (struct language_defn) <la_post_parser>: Add
1897         "tracker" parameter.
1898         * go-exp.y: Update rules.
1899         * f-exp.y: Update rules.
1900         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1901         parameter.
1902         * d-exp.y: Update rules.
1903         * c-exp.y: Update rules.
1904         * breakpoint.c (set_breakpoint_condition): Create an
1905         innermost_block_tracker.
1906         (watch_command_1): Likewise.
1907         * ada-lang.c (resolve): Add "tracker" parameter.
1908         (resolve_subexp): Likewise.
1909         * ada-exp.y (write_var_from_sym): Update.
1910
1911 2019-04-04  Tom Tromey  <tom@tromey.com>
1912
1913         * type-stack.h: New file.
1914         * type-stack.c: New file.
1915         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1916         type-stack.h.
1917         (insert_into_type_stack, insert_type, push_type, push_type_int)
1918         (insert_type_address_space, pop_type, pop_type_int)
1919         (pop_typelist, pop_type_stack, append_type_stack)
1920         (push_type_stack, get_type_stack, push_typelist)
1921         (follow_type_instance_flags, follow_types): Don't declare.
1922         * parse.c (type_stack): Remove global.
1923         (parse_exp_in_context): Update.
1924         (insert_into_type_stack, insert_type, push_type, push_type_int)
1925         (insert_type_address_space, pop_type, pop_type_int)
1926         (pop_typelist, pop_type_stack, append_type_stack)
1927         (push_type_stack, get_type_stack, push_typelist)
1928         (follow_type_instance_flags, follow_types): Remove (moved to
1929         type-stack.c).
1930         * f-exp.y (type_stack): New global.
1931         Update rules.
1932         (push_kind_type, f_parse): Update.
1933         * d-exp.y (type_stack): New global.
1934         Update rules.
1935         (d_parse): Update.
1936         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1937         Update rules.
1938         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1939         (HFILES_NO_SRCDIR): Add type-stack.h.
1940
1941 2019-04-04  Tom Tromey  <tom@tromey.com>
1942
1943         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1944         (rust_parser::convert_ast_to_expression, rust_parse)
1945         (rust_lex_test_completion, rust_lex_tests): Update.
1946         * parser-defs.h (struct expr_completion_state): New.
1947         (struct parser_state) <parser_state>: Add completion parameter.
1948         <mark_struct_expression, mark_completion_tag>: New methods.
1949         <parse_completion, m_completion_state>: New members.
1950         (prefixify_expression, null_post_parser): Update.
1951         (mark_struct_expression, mark_completion_tag): Don't declare.
1952         * parse.c (parse_completion, expout_last_struct)
1953         (expout_tag_completion_type, expout_completion_name): Remove
1954         globals.
1955         (parser_state::mark_struct_expression)
1956         (parser_state::mark_completion_tag): Now methods.
1957         (prefixify_expression): Add last_struct parameter.
1958         (prefixify_subexp): Likewise.
1959         (parse_exp_1): Update.
1960         (parse_exp_in_context): Add cstate parameter.  Update.
1961         (parse_expression_for_completion): Create an
1962         expr_completion_state.
1963         (null_post_parser): Add "completion" parameter.
1964         * p-exp.y: Update rules.
1965         (yylex): Update.
1966         * language.h (struct language_defn) <la_post_parser>: Add
1967         "completing" parameter.
1968         * go-exp.y: Update rules.
1969         (lex_one_token): Update.
1970         * expression.h (parse_completion): Don't declare.
1971         * d-exp.y: Update rules.
1972         (lex_one_token): Update rules.
1973         * c-exp.y: Update rules.
1974         (lex_one_token): Update.
1975         * ada-lang.c (resolve): Add "parse_completion" parameter.
1976         (resolve_subexp): Likewise.
1977         (ada_resolve_function): Likewise.
1978
1979 2019-04-04  Tom Tromey  <tom@tromey.com>
1980
1981         * parser-defs.h (struct parser_state) <start_arglist,
1982         end_arglist>: New methods.
1983         <arglist_len, m_funcall_chain>: New members.
1984         (arglist_len, start_arglist, end_arglist): Don't declare.
1985         * parse.c (arglist_len, funcall_chain): Remove global.
1986         (start_arglist, end_arglist): Remove functions.
1987         (parse_exp_in_context): Update.
1988         * p-exp.y: Update rules.
1989         * m2-exp.y: Update rules.
1990         * go-exp.y: Update rules.
1991         * f-exp.y: Update rules.
1992         * d-exp.y: Update rules.
1993         * c-exp.y: Update rules.
1994
1995 2019-04-04  Tom Tromey  <tom@tromey.com>
1996
1997         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1998         lex_operator, push_back>: New methods.
1999         Update all rules.
2000         (rust_parser::lex_hex, lex_escape): Rename and update.
2001         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2002         (rust_parser::lex_operator): Rename and update.
2003         (rust_parser::lex_number, rustyylex, rustyyerror)
2004         (rust_lex_test_init, rust_lex_test_sequence)
2005         (rust_lex_test_push_back, rust_lex_tests): Update.
2006         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2007         parameter.
2008         <lexptr, prev_lexptr>: New members.
2009         (lexptr, prev_lexptr): Don't declare.
2010         * parse.c (lexptr, prev_lexptr): Remove globals.
2011         (parse_exp_in_context): Update.
2012         * p-exp.y (yylex, yyerror): Update.
2013         * m2-exp.y (parse_number, yylex, yyerror): Update.
2014         * go-exp.y (lex_one_token, yyerror): Update.
2015         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2016         * d-exp.y (lex_one_token, yyerror): Update.
2017         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2018         (lex_one_token, yyerror): Update.
2019         * ada-lex.l (YY_INPUT): Update.
2020         (rewind_to_char): Update.
2021         * ada-exp.y (yyerror): Update.
2022
2023 2019-04-04  Tom Tromey  <tom@tromey.com>
2024
2025         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2026         * parser-defs.h (struct parser_state) <parser_state>: Add new
2027         parameter.
2028         <comma_terminates>: New member.
2029         (comma_terminates): Don't declare global.
2030         * parse.c (comma_terminates): Remove global.
2031         (parse_exp_in_context): Update.
2032         * p-exp.y (yylex): Update.
2033         * m2-exp.y (yylex): Update.
2034         * go-exp.y (lex_one_token): Update.
2035         * f-exp.y (yylex): Update.
2036         * d-exp.y (lex_one_token): Update.
2037         * c-exp.y (lex_one_token): Update.
2038         * ada-lex.l: Update.
2039
2040 2019-04-04  Tom Tromey  <tom@tromey.com>
2041
2042         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2043         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2044         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2045         * parser-defs.h (paren_depth): Don't declare.
2046         * parse.c (paren_depth): Remove global.
2047         (parse_exp_in_context): Update.
2048         * p-exp.y (paren_depth): New global.
2049         (pascal_parse): Initialize it.
2050         * m2-exp.y (paren_depth): New global.
2051         (m2_parse): Initialize it.
2052         * go-exp.y (paren_depth): New global.
2053         (go_parse): Initialize it.
2054         * f-exp.y (paren_depth): New global.
2055         (f_parse): Initialize it.
2056         * d-exp.y (paren_depth): New global.
2057         (d_parse): Initialize it.
2058         * c-exp.y (paren_depth): New global.
2059         (c_parse): Initialize it.
2060         * ada-lex.l (paren_depth): New global.
2061         (lexer_init): Initialize it.
2062
2063 2019-04-04  Tom Tromey  <tom@tromey.com>
2064
2065         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2066         (rust_parser::convert_ast_to_type)
2067         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2068         * parser-defs.h (struct parser_state) <parser_state>: Add
2069         parameters.  Initialize new members.
2070         <expression_context_block, expression_context_pc>: New members.
2071         * parse.c (expression_context_block, expression_context_pc):
2072         Remove globals.
2073         (parse_exp_in_context): Update.
2074         * p-exp.y: Update all rules.
2075         (yylex): Update.
2076         * m2-exp.y: Update all rules.
2077         (yylex): Update.
2078         * go-exp.y (yylex): Update.
2079         * f-exp.y (yylex): Update.
2080         * d-exp.y: Update all rules.
2081         (yylex): Update.
2082         * c-exp.y: Update all rules.
2083         (lex_one_token, classify_name, yylex, c_parse): Update.
2084         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2085
2086 2019-04-04  Tom Tromey  <tom@tromey.com>
2087
2088         * gdbarch.h, gdbarch.c: Rebuild.
2089         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2090         * stap-probe.h:
2091         (struct stap_parse_info): Replace "parser_state" with
2092         "expr_builder".
2093         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2094         (parser_state): New class.
2095         * parse.c (expr_builder): Rename.
2096         (expr_builder::release): Rename.
2097         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2098         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2099         (write_exp_elt_longcst, write_exp_elt_floatcst)
2100         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2101         (write_exp_string_vector, write_exp_bitstring)
2102         (write_exp_msymbol, mark_struct_expression)
2103         (write_dollar_variable)
2104         (insert_type_address_space, increase_expout_size): Replace
2105         "parser_state" with "expr_builder".
2106         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2107         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2108         "parser_state" with "expr_builder".
2109
2110 2019-04-04  Tom Tromey  <tom@tromey.com>
2111
2112         * rust-exp.y: Replace "parse_language" with method call.
2113         * p-exp.y:
2114         (yylex): Replace "parse_language" with method call.
2115         * m2-exp.y:
2116         (yylex): Replace "parse_language" with method call.
2117         * go-exp.y (classify_name): Replace "parse_language" with method
2118         call.
2119         * f-exp.y (yylex): Replace "parse_language" with method call.
2120         * d-exp.y (lex_one_token): Replace "parse_language" with method
2121         call.
2122         * c-exp.y:
2123         (lex_one_token, classify_name, yylex): Replace "parse_language"
2124         with method call.
2125         * ada-exp.y (find_primitive_type, type_char)
2126         (type_system_address): Replace "parse_language" with method call.
2127
2128 2019-04-04  Tom Tromey  <tom@tromey.com>
2129
2130         * rust-exp.y: Replace "parse_gdbarch" with method call.
2131         * parse.c (write_dollar_variable, insert_type_address_space):
2132         Replace "parse_gdbarch" with method call.
2133         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2134         call.
2135         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2136         call.
2137         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2138         "parse_gdbarch" with method call.
2139         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2140         with method call.
2141         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2142         "parse_gdbarch" with method call.
2143         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2144         "parse_gdbarch" with method call.
2145         * c-exp.y (parse_type, parse_number, classify_name): Replace
2146         "parse_gdbarch" with method call.
2147         * ada-lex.l: Replace "parse_gdbarch" with method call.
2148         * ada-exp.y (parse_type, find_primitive_type, type_char)
2149         (type_system_address): Replace "parse_gdbarch" with method call.
2150
2151 2019-04-04  Tom Tromey  <tom@tromey.com>
2152
2153         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2154         * stap-probe.c (stap_parse_argument): Update.
2155         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2156         initial_size parameter.
2157         * rust-exp.y (rust_lex_tests): Update.
2158         * parse.c (parser_state): Update.
2159         (parse_exp_in_context): Update.
2160         * parser-defs.h (struct parser_state) <parser_state>: Remove
2161         "initial_size" parameter.
2162
2163 2019-04-04  Tom Tromey  <tom@tromey.com>
2164
2165         * parser-defs.h (increase_expout_size): Don't declare.
2166         * parse.c (increase_expout_size): Now static.
2167
2168 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2169
2170         * gnu-nat.c (gnu_nat_target::wait): Fix
2171         target_waitstatus_to_string call.
2172
2173 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * eval.c (evaluate_subexp_standard): Handle internal functions
2176         during Fortran function call handling.
2177
2178 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * NEWS: Mention new internal functions.
2181         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2182         (read_base_type): Use dwarf2_init_complex_target_type.
2183         * value.c (creal_internal_fn): New function.
2184         (cimag_internal_fn): New function.
2185         (_initialize_values): Register new internal functions.
2186
2187 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2188
2189         * infrun.c (stop_all_threads): If debug_infrun, always
2190         trace the wait status after wait_one, using
2191         target_waitstatus_to_string and target_pid_to_str.
2192         (handle_inferior_event): Replace various trace of
2193         wait status kind by a single trace.
2194         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2195         wait status kind image by target_waitstatus_to_string.
2196         * target/waitstatus.c (target_waitstatus_to_string): Fix
2197         obsolete comment.
2198
2199 2019-04-01  Tom Tromey  <tromey@adacore.com>
2200
2201         PR symtab/23331:
2202         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2203
2204 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2205             Pedro Alves  <palves@redhat.com>
2206
2207         * top.c (quit_force): Call 'finalize_values'.
2208         * value.c (finalize_values): New function.
2209         * value.h (finalize_values): Declare.
2210
2211 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2212
2213         * NEWS: Announce $_gdb_major and $_gdb_minor.
2214
2215         * top.c (init_gdb_version_vars): New function.
2216         (gdb_init): Call init_gdb_version_vars.
2217
2218 2019-03-29  Tom Tromey  <tromey@adacore.com>
2219
2220         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2221         help text.  Remove dead code.
2222
2223 2019-03-29  Keith Seitz  <keiths@redhat.com>
2224
2225         From Siddhesh Poyarekar:
2226         * f-lang.h (f77_get_upperbound): Return LONGEST.
2227         (f77_get_lowerbound): Likewise.
2228         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2229         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2230         print them.
2231         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2232         plongest to format print it.
2233         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2234         (f77_get_upperbound): Likewise.
2235         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2236         LOWER_BOUND to LONGEST.
2237         (f77_create_arrayprint_offset_tbl): Likewise.
2238
2239 2019-03-29  Keith Seitz  <keiths@redhat.com>
2240
2241         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2242         %s/pulongest for TYPE_LENGTH instead of %d in format
2243         strings.
2244         * ada-typerint.c (ada_print_type): Likewise.
2245         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2246         * compile/compile-c-support.c (generate_register_struct): Likewise.
2247         * gdbtypes.c (recursive_dump_type): Likewise.
2248         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2249         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2250         instead of %d in format strings.
2251         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2252         to std::min to ULONGEST.
2253         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2254         instead of %d in format strings.
2255         * tracepoint.c (info_scope_command): Likewise.
2256         * typeprint.c (print_offset_data::update)
2257         (print_offset_data::finish): Likewise.
2258         * xtensa-tdep.c (xtensa_store_return_value)
2259         (xtensa_push_dummy_call): Likewise.
2260
2261 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2262
2263         * windows-nat.c (display_selector): Fixed format specifications
2264         for 64-bit Cygwin.
2265
2266 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2267
2268         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2269
2270 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2271
2272         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2273         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2274         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2275         (nios2_linux_init_abi): Install it.
2276
2277 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2278
2279         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2280
2281 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2282
2283         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2284
2285 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2286             Tom Tromey  <tromey@adacore.com>
2287
2288         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2289
2290 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2291
2292         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2293         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2294         method to compute the bounds of range types. Also print "[evaluated]"
2295         if the bounds' values come from a dynamic evaluation.
2296
2297 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2300         whitespace when pretty printing is on.
2301
2302 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2303
2304         * ppc-linux-nat.c: Add include.
2305
2306 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2307
2308         * NEWS: Mention AArch64 Pointer Authentication.
2309
2310 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2311
2312         * arm-linux-nat.c: Add include.
2313
2314 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2315
2316         * source-cache.c (source_cache::get_source_lines): Re-read
2317         fullname after calling open_source_file.
2318
2319 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2320
2321         * NEWS: Mention TLS support for FreeBSD.
2322
2323 2019-03-25  Tom Tromey  <tromey@adacore.com>
2324
2325         * minsyms.c (BUNCH_SIZE): Update comment.
2326         (~minimal_symbol_reader): Remove old comment.
2327         (compact_minimal_symbols): Update comment.
2328         (minimal_symbol_reader::install): Remove old comment.  Update
2329         other comments.
2330
2331 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2332
2333         * s390-linux-nat.c: Add include.
2334
2335 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2336
2337         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2338         Call linux_get_hwcap.
2339         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2340         Likewise.
2341         (aarch64_linux_get_hwcap): Remove function.
2342         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2343         declaration.
2344         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2345         linux_get_hwcap.
2346         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2347         * linux-tdep.c (linux_get_hwcap): Add function.
2348         (linux_get_hwcap2): Likewise.
2349         * linux-tdep.h (linux_get_hwcap): Add declaration.
2350         (linux_get_hwcap2): Likewise.
2351         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2352         (ppc_linux_get_hwcap2): Likewise.
2353         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2354         linux_get_hwcap.
2355         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2356         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2357         (ppc_linux_nat_target::read_description): Likewise.
2358         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2359         * s390-linux-nat.c: Likewise.
2360         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2361
2362 2019-03-24  Tom Tromey  <tom@tromey.com>
2363
2364         * ada-lang.c (standard_lookup): Simplify initialization.
2365         (ada_lookup_symbol_nonlocal): Simplify return.
2366         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2367         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2368         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2369         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2370         initialization.
2371         * solib.c (solib_global_lookup): Simplify.
2372         * symtab.c (null_block_symbol): Remove.
2373         (symbol_cache_lookup): Simplify returns.
2374         (lookup_language_this): Simplify returns.
2375         (lookup_symbol_aux): Simplify return.
2376         (lookup_local_symbol): Simplify returns.
2377         (lookup_global_symbol_from_objfile): Simplify return.
2378         (lookup_symbol_in_objfile_symtabs)
2379         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2380         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2381         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2382         * cp-namespace.c (cp_lookup_bare_symbol)
2383         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2384         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2385         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2386         (cp_lookup_symbol_via_imports): Simplify initialization.
2387         (find_symbol_in_baseclass): Likewise.
2388         * symtab.h (null_block_symbol): Remove.
2389         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2390         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2391         (d_lookup_symbol_module): Likewise.
2392         (find_symbol_in_baseclass): Simplify initialization.
2393
2394 2019-03-24  Tom Tromey  <tom@tromey.com>
2395
2396         * expression.h: Don't include symtab.h.
2397         (struct block): Forward declare.
2398
2399 2019-03-24  Tom Tromey  <tom@tromey.com>
2400
2401         * c-exp.y (typebase): Remove casts.
2402         * gdbtypes.c (lookup_unsigned_typename, )
2403         (lookup_signed_typename): Remove cast.
2404         * eval.c (parse_to_comma_and_eval): Remove cast.
2405         * parse.c (write_dollar_variable): Remove cast.
2406         * block.h (struct block) <superblock>: Now const.
2407         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2408         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2409         (map_block): Make "block" const.
2410         * symfile.h (struct quick_symbol_functions)
2411         <map_matching_symbols>: Constify block argument to "callback".
2412         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2413         const.
2414         (find_pc_sect_compunit_symtab): Make "b" const.
2415         (find_symbol_at_address): Likewise.
2416         (search_symbols): Likewise.
2417         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2418         (dw2_debug_names_lookup_symbol): Likewise.
2419         (dw2_map_matching_symbols): Update.
2420         * p-valprint.c (pascal_val_print): Remove "block".
2421         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2422         (aux_add_nonlocal_symbols): Make "block" const.
2423         (resolve_subexp): Remove cast.
2424         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2425         const.
2426         (iterate_over_file_blocks): Likewise.
2427         * f-exp.y (%union) <bval>: Remove.
2428         * coffread.c (patch_opaque_types): Make "b" const.
2429         * spu-tdep.c (spu_catch_start): Make "block" const.
2430         * c-valprint.c (print_unpacked_pointer): Remove "block".
2431         * symmisc.c (dump_symtab_1): Make "b" const.
2432         (block_depth): Make "block" const.
2433         * d-exp.y (%union) <bval>: Remove.
2434         * cp-support.h (cp_lookup_rtti_type): Update.
2435         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2436         * psymtab.c (psym_lookup_symbol): Make "block" const.
2437         (maintenance_check_psymtabs): Make "b" const.
2438         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2439         (enumerate_locals, enumerate_args): Update.
2440         * python/py-symtab.c (stpy_global_block): Make "block" const.
2441         (stpy_static_block): Likewise.
2442         * inline-frame.c (block_starting_point_at): Make "new_block"
2443         const.
2444         * block.c (find_block_in_blockvector): Make return type const.
2445         (blockvector_for_pc_sect): Make "b" const.
2446         (find_block_in_blockvector): Make "b" const.
2447
2448 2019-03-23  Tom Tromey  <tom@tromey.com>
2449
2450         * varobj.c (varobj_create): Update.
2451         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2452         * printcmd.c (display_command, do_one_display): Don't reset
2453         innermost_block.
2454         * parser-defs.h (enum innermost_block_tracker_type): Move to
2455         expression.h.
2456         (innermost_block): Update comment.
2457         * parse.c (parse_exp_1): Add tracker_types parameter.
2458         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2459         tracker_types parameter.  Reset innermost_block.
2460         (parse_exp_in_context): Remove.
2461         (parse_expression_for_completion): Update.
2462         * objfiles.c (~objfile): Don't reset expression_context_block or
2463         innermost_block.
2464         * expression.h (enum innermost_block_tracker_type): Move from
2465         parser-defs.h.
2466         (parse_exp_1): Add tracker_types parameter.
2467         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2468         reset innermost_block.
2469
2470 2019-03-23  Tom Tromey  <tom@tromey.com>
2471
2472         * objfiles.h: Include bcache.h.
2473
2474 2019-03-23  Tom Tromey  <tom@tromey.com>
2475
2476         * linespec.c (get_current_search_block): Use
2477         scoped_restore_current_language.
2478         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2479
2480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2481             Jiong Wang  <jiong.wang@arm.com>
2482
2483         * aarch64-linux-tdep.c
2484         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2485         section.
2486         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2487
2488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2489             Jiong Wang  <jiong.wang@arm.com>
2490
2491         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2492         instructions.
2493         (aarch64_analyze_prologue_test): Add PACIASP test.
2494         (aarch64_prologue_prev_register): Unmask PC value.
2495
2496 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2497             Jiong Wang  <jiong.wang@arm.com>
2498
2499         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2500         (aarch64_dwarf2_prev_register): Unmask PC value.
2501         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2502         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2503         DW_CFA_AARCH64_negate_ra_state.
2504         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2505
2506 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2507             Jiong Wang  <jiong.wang@arm.com>
2508
2509         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2510         registers.
2511         (aarch64_pseudo_register_name): Likewise.
2512         (aarch64_pseudo_register_type): Likewise.
2513         (aarch64_pseudo_register_reggroup_p): Likewise.
2514         (aarch64_gdbarch_init): Add pauth registers.
2515         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2516         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2517         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2518         (struct gdbarch_tdep): Add regnum for ra_state.
2519
2520 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2521             Jiong Wang  <jiong.wang@arm.com>
2522
2523         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2524
2525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2526             Jiong Wang  <jiong.wang@arm.com>
2527
2528         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2529         function.
2530         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2531         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2532         (aarch64_gdbarch_init): Add puth registers.
2533         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2534         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2535         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2536
2537 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2538             Jiong Wang  <jiong.wang@arm.com>
2539
2540         * aarch64-linux-nat.c
2541         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2542         * aarch64-linux-tdep.c
2543         (aarch64_linux_core_read_description): Likewise.
2544         (aarch64_linux_get_hwcap): New function.
2545         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2546         (aarch64_linux_get_hwcap): New declaration.
2547
2548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2549             Jiong Wang  <jiong.wang@arm.com>
2550
2551         * aarch64-linux-nat.c
2552         (aarch64_linux_nat_target::read_description): Add pauth param.
2553         * aarch64-linux-tdep.c
2554         (aarch64_linux_core_read_description): Likewise.
2555         * aarch64-tdep.c (struct target_desc): Add in pauth.
2556         (aarch64_read_description): Add pauth param.
2557         (aarch64_gdbarch_init): Likewise.
2558         * aarch64-tdep.h (aarch64_read_description): Likewise.
2559         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2560         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2561         * features/Makefile: Add new files.
2562         * features/aarch64-pauth.c: New file.
2563         * features/aarch64-pauth.xml: New file.
2564
2565 2019-03-20  Tom Tromey  <tromey@adacore.com>
2566
2567         * infrun.c (handle_inferior_event): Rename from
2568         handle_inferior_event_1.  Create a scoped_value_mark.
2569         (handle_inferior_event): Remove.
2570
2571 2019-03-19  Tom Tromey  <tromey@adacore.com>
2572
2573         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2574         * infrun.h (print_stop_event): Add "displays" parameter.
2575         * infrun.c (print_stop_event): Add "displays" parameter.
2576
2577 2019-03-19  Pedro Alves  <palves@redhat.com>
2578
2579         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2580         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2581         to -1.  Fix TABs vs spaces.
2582         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2583         * tui/tui-out.h (tui_ui_out) Add intro comments.
2584         <m_line, m_start_of_line>: In-class initialize, and add describing
2585         comment.
2586
2587 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2588
2589         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2590         variable names.
2591         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2592
2593 2019-03-18  Pedro Alves  <palves@redhat.com>
2594             Eli Zaretskii <eliz@gnu.org>
2595
2596         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2597         m_line and m_start_of_line.
2598
2599 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2600
2601         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2602         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2603         it returns a newline.  This fixes a regression in TU mode, whereby
2604         the next line is output on the same screen line as the user input.
2605
2606 2019-03-18  Tom Tromey  <tromey@adacore.com>
2607
2608         * minsyms.c (minimal_symbol_reader::install): Remove call to
2609         obstack_blank.
2610
2611 2019-03-18  Pedro Alves  <palves@redhat.com>
2612
2613         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2614         New globals.
2615         (apply_style): New, factored out from ...
2616         (apply_ansi_escape): ... this.  Handle reverse video mode.
2617         (tui_set_reverse_mode): New function.
2618         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2619         * tui/tui-winsource.c (tui_show_source_line): Use
2620         tui_set_reverse_mode instead of setting A_STANDOUT.
2621         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2622         New setter methods.
2623
2624 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2625
2626         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2627         Handle tabs.
2628
2629 2019-03-18  Tom Tromey  <tromey@adacore.com>
2630
2631         * ada-lang.c (empty_array): Add "high" parameter.
2632         (ada_evaluate_subexp): Update.
2633
2634 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2635
2636         * unittests/string_view-selftests.c: Define
2637         _initialize_string_view_selftests unconditionally.
2638
2639 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2640
2641         PR gdb/24350
2642         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2643
2644 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2645
2646         PR gdb/24351
2647         * windows-nat.c (display_selector): Fix format specifiers.
2648
2649 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2650
2651         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2652         tui_refill_source_window instead of tui_refresh_win, to update the
2653         current execution line.  This fixes redisplay of the current line
2654         when stepping through the code with "next" or "step".
2655
2656 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2657
2658         * source-cache.c (source_cache::get_source_lines): Call
2659         find_source_lines to initialize s->nlines.  This fixes vertical
2660         scrolling of TUI source window when the DOWN arrow is pressed.
2661
2662 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2663
2664         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2665         linux-thread-db.c (_initialize_thread_db): Likewise.
2666
2667 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2668
2669         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2670         wclrtoeol in tui_show_source_line".  This reverts changes made in
2671         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2672
2673 2019-03-15  Tom Tromey  <tom@tromey.com>
2674
2675         * symtab.h (struct minimal_symbol): Derive from
2676         general_symbol_info.
2677         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2678         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2679         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2680         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2681         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2682         (MSYMBOL_SEARCH_NAME): Update.
2683         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2684         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2685         * minsyms.c (minimal_symbol_reader::record_full): Update.
2686
2687 2019-03-15  Tom Tromey  <tom@tromey.com>
2688
2689         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2690
2691 2019-03-15  Tom Tromey  <tom@tromey.com>
2692
2693         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2694         unique_xmalloc_ptr.
2695         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2696         Update.
2697         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2698         (build_minimal_symbol_hash_tables)
2699         (minimal_symbol_reader::install): Update.
2700
2701 2019-03-15  Tom Tromey  <tom@tromey.com>
2702
2703         * symtab.c (create_demangled_names_hash): Update.
2704         (symbol_set_names): Update.
2705         * objfiles.h (struct objfile_per_bfd_storage)
2706         <demangled_names_hash>: Now an htab_up.
2707         * objfiles.c (objfile_per_bfd_storage): Simplify.
2708
2709 2019-03-15  Tom Tromey  <tom@tromey.com>
2710
2711         * objfiles.h (struct objfile_per_bfd_storage): Declare
2712         destructor.
2713         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2714         New.
2715         (get_objfile_bfd_data): Use new.  Don't initialize
2716         language_of_main.
2717         (free_objfile_per_bfd_storage): Remove.
2718         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2719
2720 2019-03-15  Tom Tromey  <tom@tromey.com>
2721
2722         * symfile.c (reread_symbols): Update.
2723         * objfiles.c (objfile::objfile): Update.
2724         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2725         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2726         comment.
2727         (minimal_symbol_reader::install): Update.
2728         (terminate_minimal_symbol_table): Remove.
2729         * jit.c (jit_object_close_impl): Update.
2730
2731 2019-03-15  Tom Tromey  <tom@tromey.com>
2732
2733         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2734         initializations.
2735
2736 2019-03-15  Tom Tromey  <tom@tromey.com>
2737
2738         * objfiles.h (struct objfile_per_bfd_storage)
2739         <demangled_hash_languages>: Now a bitset.
2740         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2741         (lookup_minimal_symbol): Update.
2742
2743 2019-03-15  Tom Tromey  <tom@tromey.com>
2744
2745         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2746         Don't return the symbol.
2747         * coffread.c (record_minimal_symbol): Use record_full.
2748
2749 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2750
2751         The MS-Windows port of ncurses fails to switch to a color pair if
2752         one or both of the colors are the implicit default colors.  This
2753         change records the default colors when TUI is initialized, and
2754         then specifies them explicitly when a color pair uses the default
2755         colors.  This allows color styling in TUI mode on MS-Windows.
2756
2757         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2758         ncurses_norm_attr.
2759         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2760         colors in ncurses_norm_attr.
2761         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2762         "none", replace it with the default color recorded in
2763         ncurses_norm_attr.
2764
2765 2019-03-14  Tom Tromey  <tromey@adacore.com>
2766
2767         * source-cache.h (class source_cache) <get_source_lines>: Return
2768         std::string.
2769         * source-cache.c (source_cache::extract_lines): Handle case where
2770         first_pos==npos.  Return std::string.
2771         (source_cache::get_source_lines): Update.
2772
2773 2019-03-14  Tom Tromey  <tromey@adacore.com>
2774
2775         * NEWS: Add item for "style sources" commands.
2776         * source-cache.c (source_cache::get_source_lines): Check
2777         source_styling.
2778         * cli/cli-style.c (source_styling): New global.
2779         (_initialize_cli_style): Add "style sources" commands.
2780         (show_style_sources): New function.
2781         * cli/cli-style.h (source_styling): Declare.
2782
2783 2019-03-14  Pedro Alves  <palves@redhat.com>
2784             Tom Tromey  <tromey@adacore.com>
2785
2786         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2787         * tui/tui-winsource.c (tui_refill_source_window): New function,
2788         from...
2789         (tui_horizontal_source_scroll): ... here.  Move some logic.
2790         * cli/cli-style.c (set_style_enabled): Notify new observable.
2791         * tui/tui-hooks.c (tui_redisplay_source): New function.
2792         (tui_attach_detach_observers): Attach or detach
2793         tui_redisplay_source.
2794         * observable.h (source_styling_changed): New observable.
2795         * observable.c: Define source_styling_changed observable.
2796
2797 2019-03-13  Tom Tromey  <tromey@adacore.com>
2798
2799         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2800         (i386_gnu_nat_target::store_registers): Update.
2801         * target-debug.h (target_debug_print_std_string): New macro.
2802         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2803         * windows-tdep.c (display_one_tib): Update.
2804         * tui/tui-stack.c (tui_make_status_line): Update.
2805         * top.c (print_inferior_quit_action): Update.
2806         * thread.c (thr_try_catch_cmd): Update.
2807         (add_thread_with_info): Update.
2808         (thread_target_id_str): Update.
2809         (thr_try_catch_cmd): Update.
2810         (thread_command): Update.
2811         (thread_find_command): Update.
2812         * record-btrace.c (record_btrace_target::info_record)
2813         (record_btrace_resume_thread, record_btrace_target::resume)
2814         (record_btrace_cancel_resume, record_btrace_step_thread)
2815         (record_btrace_target::wait, record_btrace_target::wait)
2816         (record_btrace_target::wait, record_btrace_target::stop): Update.
2817         * progspace.c (print_program_space): Update.
2818         * process-stratum-target.c
2819         (process_stratum_target::thread_address_space): Update.
2820         * linux-fork.c (linux_fork_mourn_inferior)
2821         (detach_checkpoint_command, info_checkpoints_command)
2822         (linux_fork_context): Update.
2823         (linux_fork_detach): Update.
2824         (class scoped_switch_fork_info): Update.
2825         (delete_checkpoint_command): Update.
2826         * infrun.c (follow_fork_inferior): Update.
2827         (follow_fork_inferior): Update.
2828         (proceed_after_vfork_done): Update.
2829         (handle_vfork_child_exec_or_exit): Update.
2830         (follow_exec): Update.
2831         (displaced_step_prepare_throw): Update.
2832         (displaced_step_restore): Update.
2833         (start_step_over): Update.
2834         (resume_1): Update.
2835         (clear_proceed_status_thread): Update.
2836         (proceed): Update.
2837         (print_target_wait_results): Update.
2838         (do_target_wait): Update.
2839         (context_switch): Update.
2840         (stop_all_threads): Update.
2841         (restart_threads): Update.
2842         (finish_step_over): Update.
2843         (handle_signal_stop): Update.
2844         (switch_back_to_stepped_thread): Update.
2845         (keep_going_pass_signal): Update.
2846         (print_exited_reason): Update.
2847         (normal_stop): Update.
2848         * inferior.c (inferior_pid_to_str): Change return type.
2849         (print_selected_inferior): Update.
2850         (add_inferior): Update.
2851         (detach_inferior): Update.
2852         * dummy-frame.c (fprint_dummy_frames): Update.
2853         * dcache.c (dcache_info_1): Update.
2854         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2855         (btrace_fetch, btrace_clear): Update.
2856         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2857         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2858         type.
2859         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2860         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2861         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2862         * gdbarch.c, gdbarch.h: Rebuild.
2863         * gdbarch.sh (core_pid_to_str): Change return type.
2864         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2865         return type.
2866         (windows_nat_target::pid_to_str): Change return type.
2867         (windows_delete_thread): Update.
2868         (windows_nat_target::attach): Update.
2869         (windows_nat_target::files_info): Update.
2870         * target-delegates.c: Rebuild.
2871         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2872         return type.
2873         (sol_thread_target::pid_to_str): Change return type.
2874         * remote.c (class remote_target) <pid_to_str>: Change return
2875         type.
2876         (remote_target::pid_to_str): Change return type.
2877         (extended_remote_target::attach, remote_target::remote_stop_ns)
2878         (remote_target::remote_notif_remove_queued_reply)
2879         (remote_target::push_stop_reply, remote_target::disable_btrace):
2880         Update.
2881         (extended_remote_target::attach): Update.
2882         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2883         type.
2884         (gdbsim_target::pid_to_str): Change return type.
2885         * ravenscar-thread.c (struct ravenscar_thread_target)
2886         <pid_to_str>: Change return type.
2887         (ravenscar_thread_target::pid_to_str): Change return type.
2888         * procfs.c (class procfs_target) <pid_to_str>: Change return
2889         type.
2890         (procfs_target::pid_to_str): Change return type.
2891         (procfs_target::attach): Update.
2892         (procfs_target::detach): Update.
2893         (procfs_target::fetch_registers): Update.
2894         (procfs_target::store_registers): Update.
2895         (procfs_target::wait): Update.
2896         (procfs_target::files_info): Update.
2897         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2898         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2899         return type.
2900         (nto_procfs_target::pid_to_str): Change return type.
2901         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2902         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2903         return type.
2904         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2905         (exit_lwp): Update.
2906         (attach_proc_task_lwp_callback, get_detach_signal)
2907         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2908         (linux_nat_target::resume, wait_lwp, stop_callback)
2909         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2910         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2911         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2912         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2913         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2914         type.
2915         (inf_ptrace_target::attach): Update.
2916         (inf_ptrace_target::files_info): Update.
2917         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2918         type.
2919         (go32_nat_target::pid_to_str): Change return type.
2920         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2921         (gnu_nat_target::wait): Update.
2922         (gnu_nat_target::wait): Update.
2923         (gnu_nat_target::resume): Update.
2924         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2925         (fbsd_nat_target::wait): Update.
2926         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2927         type.
2928         (darwin_nat_target::attach): Update.
2929         * corelow.c (class core_target) <pid_to_str>: Change return type.
2930         (core_target::pid_to_str): Change return type.
2931         * target.c (normal_pid_to_str): Change return type.
2932         (default_pid_to_str): Likewise.
2933         (target_pid_to_str): Change return type.
2934         (target_translate_tls_address): Update.
2935         (target_announce_detach): Update.
2936         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2937         return type.
2938         (bsd_uthread_target::pid_to_str): Change return type.
2939         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2940         type.
2941         (bsd_kvm_target::pid_to_str): Change return type.
2942         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2943         return type.
2944         (aix_thread_target::pid_to_str): Change return type.
2945         * target.h (struct target_ops) <pid_to_str>: Change return type.
2946         (target_pid_to_str, normal_pid_to_str): Likewise.
2947         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2948         type.
2949         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2950         type.
2951         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2952         return type.
2953         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2954         type.
2955         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2956         type.
2957         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2958         return type.
2959
2960 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2961
2962         * NEWS: Mention that the new default MI version is 3.  Mention
2963         changes to the output of commands and events that deal with
2964         multi-location breakpoints.
2965         * breakpoint.c: Include "mi/mi-out.h".
2966         (print_one_breakpoint): Change output syntax if using MI version
2967         >= 3.
2968         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2969         New.
2970         (mi_multi_location_breakpoint_output_fixed): New.
2971         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2972         (mi_cmd_fix_multi_location_breakpoint_output): New.
2973         (mi_multi_location_breakpoint_output_fixed): New.
2974         * mi/mi-cmds.c (mi_cmds): Register command
2975         -fix-multi-location-breakpoint-output.
2976         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2977         interpreter "mi".
2978
2979 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2980
2981         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2982         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2983         instantiate mi_ui_out based on interpreter name.
2984         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2985         * mi/mi-main.c (mi_load_progress): Likewise.
2986
2987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2988
2989         * NEWS: Combine separate "New targets" sections for 8.3.
2990
2991 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2992
2993         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2994         (ppcfbsd_init_abi): Install gdbarch
2995         "fetch_tls_load_module_address" and "get_thread_local_address"
2996         methods.
2997
2998 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2999
3000         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3001         (riscv_fbsd_init_abi): Install gdbarch
3002         "fetch_tls_load_module_address" and "get_thread_local_address"
3003         methods.
3004
3005 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3006
3007         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3008         (i386fbsd_init_abi): Install gdbarch
3009         "fetch_tls_load_module_address" and "get_thread_local_address"
3010         methods.
3011
3012 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3013
3014         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3015         (amd64fbsd_init_abi): Install gdbarch
3016         "fetch_tls_load_module_address" and "get_thread_local_address"
3017         methods.
3018
3019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3020
3021         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3022         (struct fbsd_pspace_data): New type.
3023         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3024         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3025         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3026         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3027         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3028
3029 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3030
3031         * gdbtypes.c (lookup_struct_elt): New function.
3032         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3033         * gdbtypes.h (struct struct_elt): New type.
3034         (lookup_struct_elt): New prototype.
3035
3036 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3037
3038         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3039         remove disabled code block.
3040
3041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3042
3043         * gdbarch.sh (get_thread_local_address): New method.
3044         * gdbarch.h, gdbarch.c: Regenerate.
3045         * target.c (target_translate_tls_address): Use
3046         gdbarch_get_thread_local_address if present instead of
3047         target::get_thread_local_address.
3048
3049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3050
3051         * target.h (target::get_thread_local_address): Update comment.
3052
3053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3054
3055         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3056         objfile->separate_debug_objfile_backlink if not NULL.
3057
3058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3059
3060         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3061         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3062         (amd64bsd_store_inferior_registers): Likewise.
3063         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3064         Enable segment base registers.
3065         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3066         PT_GETFSBASE and PT_GETGSBASE.
3067         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3068         PT_SETGSBASE.
3069         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3070         segment base registers.
3071         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3072
3073 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3074
3075         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3076         Update calls to i386_target_description to add 'segments'
3077         parameter.
3078         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3079         add segment base registers.
3080         * arch/i386.c (i386_create_target_description): Add 'segments'
3081         parameter to enable segment base registers.
3082         * arch/i386.h (i386_create_target_description): Likewise.
3083         * features/i386/32bit-segments.xml: New file.
3084         * features/i386/32bit-segments.c: Generate.
3085         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3086         call to i386_target_description to add 'segments' parameter.
3087         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3088         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3089         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3090         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3091         if feature is present.
3092         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3093         Add 'segments' parameter to call to i386_target_description.
3094         (i386_target_description): Add 'segments' parameter to enable
3095         segment base registers.
3096         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3097         to call to i386_target_description.
3098         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3099         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3100         Define I386_NUM_REGS.
3101         (i386_target_description): Add 'segments' parameter to enable
3102         segment base registers.
3103
3104 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3105
3106         PR/24325
3107         * source-cache.c: #undef open and close, to avoid unresolved
3108         externals during linking.
3109
3110 2019-03-12  Tom Tromey  <tromey@adacore.com>
3111
3112         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3113         const.  Add initializers.
3114         (_initialize_remote): Don't initialize ptid globals.
3115
3116 2019-03-12  Pedro Alves  <palves@redhat.com>
3117
3118         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3119
3120 2019-03-12  Pedro Alves  <palves@redhat.com>
3121
3122         * cp-name-parser.y (main): Remove unused 'len' variable.
3123
3124 2019-03-12  Tom Tromey  <tromey@adacore.com>
3125
3126         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3127         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3128
3129 2019-03-12  Tom Tromey  <tromey@adacore.com>
3130
3131         * linux-nat.c (iterate_over_lwps): Update.
3132         (stop_callback): Remove parameter.
3133         (stop_wait_callback, detach_callback, resume_set_callback)
3134         (select_singlestep_lwp_callback, set_ignore_sigint)
3135         (status_callback, resumed_callback, resume_clear_callback)
3136         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3137         data parameter.
3138         (linux_nat_target::detach, linux_nat_target::resume)
3139         (linux_stop_and_wait_all_lwps, select_event_lwp)
3140         (linux_nat_filter_event, linux_nat_wait_1)
3141         (linux_nat_target::kill, linux_nat_target::stop)
3142         (linux_nat_target::stop): Update.
3143         (linux_nat_resume_callback): Change type.
3144         (resume_stopped_resumed_lwps, count_events_callback)
3145         (select_event_lwp_callback): Likewise.
3146         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3147         * arm-linux-nat.c (struct update_registers_data): Remove.
3148         (update_registers_callback): Change type.
3149         (arm_linux_insert_hw_breakpoint1): Update.
3150         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3151         parameter.
3152         (x86_linux_dr_set_addr): Update.
3153         (x86_linux_dr_set_control): Update.
3154         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3155         (iterate_over_lwps): Use gdb::function_view.
3156         * nat/aarch64-linux-hw-point.c (struct
3157         aarch64_dr_update_callback_param): Remove.
3158         (debug_reg_change_callback): Change type.
3159         (aarch64_notify_debug_reg_change): Update.
3160         * s390-linux-nat.c (s390_refresh_per_info): Update.
3161
3162 2019-03-11  Tom Tromey  <tromey@adacore.com>
3163
3164         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3165         redundant assignment to "this_cu".
3166
3167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3168
3169         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3170
3171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3172
3173         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3174         from...
3175         (rank_one_type): ... this.
3176
3177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3178
3179         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3180         from...
3181         (rank_one_type): ... this.
3182
3183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3184
3185         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3186         from...
3187         (rank_one_type): ... this.
3188
3189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3190
3191         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3192         from...
3193         (rank_one_type): ... this.
3194
3195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3196
3197         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3198         from...
3199         (rank_one_type): ... this.
3200
3201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3202
3203         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3204         from...
3205         (rank_one_type): ... this.
3206
3207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3208
3209         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3210         from...
3211         (rank_one_type): ... this.
3212
3213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3214
3215         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3216         from...
3217         (rank_one_type): ... this.
3218
3219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3220
3221         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3222         from...
3223         (rank_one_type): ... this.
3224
3225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3226
3227         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3228         from...
3229         (rank_one_type): ... this.
3230
3231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3232
3233         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3234         from...
3235         (rank_one_type): ... this.
3236
3237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3238
3239         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3240         from...
3241         (rank_one_type): ... this.
3242
3243 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3244
3245         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3246         inferior-events' shows the example events.
3247
3248 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3249
3250         Support styling on native MS-Windows console
3251
3252         PR/24315
3253         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3254         on MS-Windows if $TERM is not defined.
3255
3256         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3257
3258         * posix-hdep.c (gdb_console_fputs):
3259         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3260         functions.
3261         * ui-file.h (gdb_console_fputs): Add prototype.
3262
3263         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3264         back to fputs only if the former returns zero.
3265
3266 2019-03-07  Tom Tromey  <tom@tromey.com>
3267
3268         * symmisc.c (print_symbol_bcache_statistics): Update.
3269         (print_objfile_statistics): Update.
3270         * symfile.c (allocate_symtab): Update.
3271         * stabsread.c: Don't include bcache.h.
3272         * psymtab.h (struct psymbol_bcache): Don't declare.
3273         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3274         (psymbol_bcache_init, psymbol_bcache_free)
3275         (psymbol_bcache_get_bcache): Don't declare.
3276         * psymtab.c (struct psymbol_bcache): Remove.
3277         (psymtab_storage::psymtab_storage): Update.
3278         (psymtab_storage::~psymtab_storage): Update.
3279         (psymbol_bcache_init, psymbol_bcache_free)
3280         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3281         (add_psymbol_to_bcache): Update.
3282         (allocate_psymtab): Update.
3283         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3284         macro_cache>: No longer pointers.
3285         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3286         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3287         * macrotab.c (macro_bcache): Update.
3288         * macroexp.c: Don't include bcache.h.
3289         * gdbtypes.c (check_types_worklist): Update.
3290         (types_deeply_equal): Remove TRY/CATCH.  Update.
3291         * elfread.c (elf_symtab_read): Update.
3292         * dwarf2read.c: Don't include bcache.h.
3293         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3294         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3295         (print_bcache_statistics, bcache_memory_used): Don't declare.
3296         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3297         methods.  Rename all data members.
3298         * bcache.c (struct bcache): Move to bcache.h.
3299         (bcache::expand_hash_table): Rename from expand_hash_table.
3300         (bcache): Remove.
3301         (bcache::insert): Rename from bcache_full.
3302         (bcache::compare): Rename from bcache_compare.
3303         (bcache_xmalloc): Remove.
3304         (bcache::~bcache): Rename from bcache_xfree.
3305         (bcache::print_statistics): Rename from print_bcache_statistics.
3306         (bcache::memory_used): Rename from bcache_memory_used.
3307
3308 2019-03-07  Pedro Alves  <palves@redhat.com>
3309
3310         * infrun.c (normal_stop): Also check for
3311         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3312
3313 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         * f-lang.c (value_from_host_double): Moved to...
3316         * value.c (value_from_host_double): ...here.
3317         * value.h (value_from_host_double): Declare.
3318         * guile/scm-math.c (vlscm_convert_typed_number): Use
3319         value_from_host_double.
3320         (vlscm_convert_number): Likewise.
3321         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3322         * python/py-value.c (convert_value_from_python): Likewise.
3323
3324 2019-03-06  Tom Tromey  <tom@tromey.com>
3325
3326         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3327
3328 2019-03-06  Tom Tromey  <tom@tromey.com>
3329
3330         * utils.h (free_current_contents): Don't declare.
3331         * utils.c (free_current_contents): Remove.
3332
3333 2019-03-06  Tom Tromey  <tom@tromey.com>
3334
3335         * top.c (quit_force): Update.
3336         * main.c (captured_command_loop): Update.
3337         * common/new-op.c (operator new): Update.
3338         * common/common-exceptions.c (struct catcher)
3339         <save_cleanup_chain>: Remove member.
3340         (exceptions_state_mc_init): Update.
3341         (exception_try_scope_entry): Return nullptr.
3342         (exception_try_scope_exit, exception_rethrow)
3343         (throw_exception_sjlj, throw_exception_cxx): Update.
3344         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3345         (all_cleanups, do_cleanups, discard_cleanups)
3346         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3347         (restore_cleanups, restore_final_cleanups): Don't declare.
3348         (do_final_cleanups): Remove parameter.
3349         * common/cleanups.c (cleanup_chain, make_cleanup)
3350         (make_cleanup_dtor, all_cleanups, do_cleanups)
3351         (discard_my_cleanups, discard_cleanups)
3352         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3353         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3354         (null_cleanup): Remove.
3355         (do_final_cleanups): Remove parameter.
3356
3357 2019-03-06  Tom Tromey  <tom@tromey.com>
3358
3359         * remote.c (remote_target::remote_parse_stop_reply): Use
3360         unique_xmalloc_ptr.
3361
3362 2019-03-06  Tom Tromey  <tom@tromey.com>
3363
3364         * stabsread.c (struct stabs_field_info): Rename from field_info.
3365         <list, fnlist>: Add initializers.
3366         <obstack>: New member.
3367         (read_member_functions, read_struct_fields, read_baseclasses):
3368         Allocate on obstack.  Don't use cleanups.
3369         (read_one_struct_field, read_member_functions, read_struct_fields)
3370         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3371         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3372         (read_struct_type): Update.
3373
3374 2019-03-06  Tom Tromey  <tom@tromey.com>
3375
3376         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3377         * common/filestuff.h (make_cleanup_close): Don't declare.
3378         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3379         Remove.
3380
3381 2019-03-06  Tom Tromey  <tom@tromey.com>
3382
3383         * solib-aix.c: Use make_scope_exit.
3384
3385 2019-03-06  Tom Tromey  <tom@tromey.com>
3386
3387         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3388         Use make_scope_exit.
3389
3390 2019-03-06  Tom Tromey  <tom@tromey.com>
3391
3392         * solib-svr4.c (disable_probes_interface): Remove parameter.
3393         (svr4_handle_solib_event): Use make_scope_exit.
3394
3395 2019-03-06  Tom Tromey  <tom@tromey.com>
3396
3397         * remote.c (struct stop_reply_deleter): Remove.
3398         (stop_reply_up): Update.
3399         (struct stop_reply): Derive from notif_event.  Don't typedef.
3400         <regcache>: Now a std::vector.
3401         (stop_reply_xfree): Remove.
3402         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3403         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3404         (remote_target::discard_pending_stop_replies): Use delete.
3405         (remote_target::remote_parse_stop_reply): Update.
3406         (remote_target::process_stop_reply): Update.
3407         * remote-notif.h (struct notif_event): Add virtual destructor.
3408         Remove "dtr" member.
3409         (struct notif_client) <alloc_event>: Return a unique_ptr.
3410         (notif_event_xfree): Don't declare.
3411         (notif_event_up): New typedef.
3412         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3413         (notif_event_xfree, do_notif_event_xfree): Remove.
3414         (remote_notif_state_xfree): Update.
3415
3416 2019-03-06  Tom Tromey  <tom@tromey.com>
3417
3418         * infrun.c (displaced_step_clear_cleanup): Now a
3419         forward_scope_exit type.
3420         (displaced_step_prepare_throw): Update.
3421         (displaced_step_fixup): Update.
3422
3423 2019-03-06  Tom Tromey  <tom@tromey.com>
3424
3425         * inferior.h (class inferior): Update comment.
3426         * gdbthread.h (class thread_info): Update comment.
3427
3428 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3429             Tom Tromey  <tom@tromey.com>
3430
3431         * stabsread.h (struct stab_section_list): Remove.
3432         (coffstab_build_psymtabs): Update.
3433         * dbxread.c (symbuf_sections): Now a std::vector.
3434         (sect_idx): New global.
3435         (fill_symbuf): Update.
3436         (coffstab_build_psymtabs): Change type of stabsects parameter.
3437         Update.
3438         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3439         std::vector.
3440         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3441         (coff_locate_sections): Update.
3442         (coff_symfile_read): Remove cleanups.  Update.
3443         (init_stringtab): Add storage parameter.
3444         (free_stringtab, free_stringtab_cleanup): Remove.
3445         (init_lineno): Add storage parameter.
3446         (free_linetab, free_linetab_cleanup): Remove.
3447
3448 2019-03-06  Pedro Alves  <palves@redhat.com>
3449
3450         * linux-fork.c (fork_info::clobber_regs): Delete.
3451         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3452         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3453         comment.  Adjust.
3454         (scoped_switch_fork_info::scoped_switch_fork_info)
3455         (checkpoint_command, linux_fork_context): Adjust
3456         fork_save_infrun_state calls.
3457
3458 2019-03-06  Pedro Alves  <palves@redhat.com>
3459
3460         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3461         (inf_has_multiple_threads): Return 'bool' and rewrite using
3462         inferior_info::threads().
3463
3464 2019-03-06  Pedro Alves  <palves@redhat.com>
3465
3466         * linux-fork.c: Include <list>.
3467         (fork_list): Now a std::list instance.
3468         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3469         (forks_exist_p, find_last_fork): Adjust.
3470         (new_fork): Delete.
3471         (one_fork_p): New.
3472         (add_fork): Adjust.
3473         (free_fork): Delete, folded into fork_info::~fork_info().
3474         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3475         Adjust.
3476         (init_fork_list): Delete.
3477         (linux_fork_killall, linux_fork_mourn_inferior)
3478         (linux_fork_detach, info_checkpoints_command): Adjust.
3479         (_initialize_linux_fork): No longer call init_fork_list.
3480
3481 2019-03-06  Pedro Alves  <palves@redhat.com>
3482
3483         * linux-fork.c (new_fork): New, split out of ...
3484         (add_fork): ... this.  Return void.  Move "first fork" special
3485         case from here, to ...
3486         (checkpoint_command): ... here.
3487         * linux-linux.h (add_fork): Return void.
3488
3489 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3490
3491         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3492
3493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3494             Chris January  <chris.january@arm.com>
3495             David Lecomber  <david.lecomber@arm.com>
3496
3497         * f-exp.y: New token, UNOP_INTRINSIC.
3498         (exp): New pattern using UNOP_INTRINSIC token.
3499         (f77_keywords): Add 'abs' keyword.
3500         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3501         (value_from_host_double): New function.
3502         (evaluate_subexp_f): Support UNOP_ABS.
3503
3504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3505
3506         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3507         types.
3508
3509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3510
3511         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3512         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3513         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3514
3515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3516
3517         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3518
3519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3520             Chris January  <chris.january@arm.com>
3521
3522         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3523         * f-exp.y: Define 'KIND' token.
3524         (exp): New pattern for KIND expressions.
3525         (ptype): Handle types with a kind extension.
3526         (direct_abs_decl): Extend to spot kind extensions.
3527         (f77_keywords): Add 'kind' to the list.
3528         (push_kind_type): New function.
3529         (convert_to_kind_type): New function.
3530         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3531         * parse.c (operator_length_standard): Likewise.
3532         * parser-defs.h (enum type_pieces): Add tp_kind.
3533         * std-operator.def: Add UNOP_KIND.
3534
3535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * f-exp.y (f_parse): Set yydebug.
3538
3539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3540
3541         * f-lang.c (evaluate_subexp_f): New function.
3542         (exp_descriptor_f): New global.
3543         (f_language_defn): Use exp_descriptor_f instead of
3544         exp_descriptor_standard.
3545
3546 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3547
3548         * f-exp.y (struct token): Add comments.
3549         (dot_ops): Remove uppercase versions and the end marker.
3550         (f77_keywords): Likewise.
3551         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3552         entries in the dot_ops array are case insensitive, and use
3553         strncasecmp to compare strings.  Also some whitespace cleanup in
3554         this area.  Similar for the f77_keywords array, except entries in
3555         this list might be case sensitive.
3556
3557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3558
3559         * f-exp.y (struct f77_boolean_val): Add comments.
3560         (boolean_values): Remove uppercase versions, and end marker.
3561         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3562         and use strncasecmp to achieve case insensitivity.  Additionally,
3563         perform whitespace cleanup around this code.
3564
3565 2019-03-06  Tom Tromey  <tromey@adacore.com>
3566
3567         * remote-sim.c (gdbsim_target_open): Use result of
3568         gdb_argv::release.
3569
3570 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3571         Dirk Schubert  <dirk.schubert@arm.com>
3572         Chris January  <chris.january@arm.com>
3573
3574         * eval.c (evaluate_subexp_standard): Call Fortran argument
3575         wrapping logic.
3576         * f-lang.c (struct value): A value which can be passed into a
3577         Fortran function call.
3578         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3579         where appropriate.
3580         (struct type): Value ready for a Fortran function call.
3581         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3582         is needed.
3583         * f-lang.h (fortran_argument_convert): Declaration.
3584         (fortran_preserve_arg_pointer): Declaration.
3585         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3586
3587 2019-03-05  Tom Tromey  <tromey@adacore.com>
3588
3589         * python/py-prettyprint.c (print_string_repr): Remove #if.
3590         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3591
3592 2019-03-05  Tom Tromey  <tromey@adacore.com>
3593
3594         * target.c (the_dummy_target): Move later.  Change type to
3595         "dummy_target".
3596         (initialize_targets): Don't initialize the_dummy_target.
3597
3598 2019-03-05  Tom Tromey  <tromey@adacore.com>
3599
3600         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3601         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3602
3603 2019-03-05  Tom Tromey  <tromey@adacore.com>
3604
3605         * windows-nat.c (windows_nat_target::attach)
3606         (windows_nat_target::detach): Don't call gdb_flush.
3607         * valprint.c (generic_val_print, val_print, val_print_string):
3608         Don't call gdb_flush.
3609         * utils.c (defaulted_query): Don't call gdb_flush.
3610         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3611         * target.c (target_announce_detach): Don't call gdb_flush.
3612         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3613         * remote.c (extended_remote_target::attach): Don't call
3614         gdb_flush.
3615         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3616         * printcmd.c (do_examine): Don't call gdb_flush.
3617         (info_display_command): Don't call gdb_flush.
3618         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3619         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3620         * memattr.c (info_mem_command): Don't call gdb_flush.
3621         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3622         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3623         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3624         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3625         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3626         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3627         (gnu_nat_target::detach): Don't call gdb_flush.
3628         * f-valprint.c (f_val_print): Don't call gdb_flush.
3629         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3630         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3631         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3632         gdb_flush.
3633         * c-valprint.c (c_val_print): Don't call gdb_flush.
3634         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3635
3636 2019-03-05  Tom Tromey  <tromey@adacore.com>
3637
3638         * varobj.c (update_dynamic_varobj_children): Update.
3639         (install_default_visualizer): Use reset, not release.
3640         * value.c (set_internalvar): Update.
3641         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3642         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3643         ATTRIBUTE_UNUSED_RESULT.
3644
3645 2019-03-05  Tom Tromey  <tromey@adacore.com>
3646
3647         * remote.c (class scoped_remote_fd) <release>: Add
3648         ATTRIBUTE_UNUSED_RESULT.
3649
3650 2019-03-05  Tom Tromey  <tromey@adacore.com>
3651
3652         * macroexp.c (struct macro_buffer) <release>: Add
3653         ATTRIBUTE_UNUSED_RESULT.
3654
3655 2019-03-05  Tom Tromey  <tromey@adacore.com>
3656
3657         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3658         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3659         ATTRIBUTE_UNUSED_RESULT.
3660
3661 2019-03-05  Tom Tromey  <tromey@adacore.com>
3662
3663         * common/scoped_fd.h (class scoped_fd) <release>: Add
3664         ATTRIBUTE_UNUSED_RESULT.
3665
3666 2019-03-05  Tom Tromey  <tromey@adacore.com>
3667
3668         * parser-defs.h (struct parser_state) <release>: Add
3669         ATTRIBUTE_UNUSED_RESULT.
3670
3671 2019-03-05  Tom Tromey  <tromey@adacore.com>
3672
3673         * utils.h (class gdb_argv) <release>: Add
3674         ATTRIBUTE_UNUSED_RESULT.
3675         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3676
3677 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3678
3679         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3680         for-loop range, to avoid compiler warnings.
3681
3682         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3683         avoid compiler warnings about unused variables.
3684
3685         * NEWS: Mention end of support for native debugging on MS-Windows
3686         before XP.
3687
3688         PR gdb/24292
3689         * common/netstuff.c:
3690         * gdbserver/gdbreplay.c
3691         * gdbserver/remote-utils.c:
3692         * ser-tcp.c:
3693         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3694         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3695         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3696         'getaddrinfo' and 'freeaddrinfo' were not available before
3697         Windows XP, and mingw.org's MinGW headers by default define
3698         _WIN32_WINNT to 0x500.
3699
3700 2019-03-01  Gary Benson <gbenson@redhat.com>
3701
3702         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3703
3704 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3705             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3706
3707         PR gdb/8527
3708         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3709         set_sigint_trap, clear_sigint_trap.
3710
3711 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3712
3713         * target.c (target_detach): Clear the regcache and the
3714         frame cache.
3715
3716 2019-02-27  Pedro Alves  <palves@redhat.com>
3717
3718         * utils.c (set_screen_size): When we cap the height/width sizes,
3719         tweak the corresponding command variable to show "unlimited":
3720
3721 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3722             Pedro Alves  <palves@redhat.com>
3723
3724         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3725         before calling rl_set_screen_size.
3726
3727 2019-02-27  Tom Tromey  <tromey@adacore.com>
3728
3729         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3730         define.
3731         * python/py-value.c: Remove Python 2.4 workaround.
3732         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3733         workaround.
3734         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3735         Python 2.4 workaround.
3736         * python/python-internal.h: Remove Python 2.4 comment.
3737         (Py_ssize_t): Don't define.
3738         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3739         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3740         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3741         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3742         * python/python.c (do_start_initialization): Remove Python 2.4
3743         workaround.
3744         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3745         (print_children): Remove Python 2.4 workaround.
3746         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3747         workaround.
3748         (CHARBUFFERPROC_NAME): Remove.
3749         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3750         Python 2.4 workaround.
3751
3752 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3753
3754         * NEWS: Note minimum Python version.
3755
3756 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3757
3758         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3759         code from these functions.  Remove corresponding ifdefs.  Use
3760         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3761         Remove gotos and target of gotos.
3762         (infpy_search_memory): Likewise.
3763
3764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3767         (hppa_gdbarch_init): Don't register deleted functions with
3768         gdbarch.
3769
3770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3773         (h8300_unwind_sp): Delete.
3774         (h8300_dummy_id): Delete.
3775         (h8300_gdbarch_init): Don't register deleted functions with
3776         gdbarch.
3777
3778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3779
3780         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3781         (ft32_unwind_pc): Delete.
3782         (ft32_unwind_sp): Delete.
3783         (ft32_gdbarch_init): Don't register deleted functions with
3784         gdbarch.
3785
3786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3789         (frv_unwind_pc): Delete.
3790         (frv_unwind_sp): Delete.
3791         (frv_gdbarch_init): Don't register deleted functions with
3792         gdbarch.
3793
3794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3797         (riscv_unwind_pc): Delete.
3798         (riscv_unwind_sp): Delete.
3799         (riscv_gdbarch_init): Don't register deleted functions with
3800         gdbarch.
3801
3802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3805         (csky_unwind_pc): Delete.
3806         (csky_unwind_sp): Delete.
3807         (csky_gdbarch_init): Don't register deleted functions with
3808         gdbarch.
3809
3810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3813         (cris_unwind_pc): Delete.
3814         (cris_unwind_sp): Delete.
3815         (cris_gdbarch_init): Don't register deleted functions with
3816         gdbarch.
3817
3818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3821         (bfin_unwind_pc): Delete.
3822         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3823
3824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3825
3826         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3827         (arm_unwind_pc): Delete.
3828         (arm_unwind_sp): Delete.
3829         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3830
3831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3834         (arc_unwind_pc): Delete.
3835         (arc_unwind_sp): Delete.
3836         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3837
3838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3841         (alpha_unwind_pc): Delete.
3842         (alpha_gdbarch_init): Don't register deleted functions with
3843         gdbarch.
3844
3845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3846
3847         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3848         (aarch64_unwind_pc): Delete.
3849         (aarch64_unwind_sp): Delete.
3850         (aarch64_gdbarch_init): Don't register deleted functions with
3851         gdbarch.
3852
3853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * gdbtypes.c (type_align): Don't consider static members when
3856         computing structure alignment.
3857
3858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3861         return 0 for other types.
3862         * arch-utils.c (default_type_align): Always return 0.
3863         * gdbarch.h: Regenerate.
3864         * gdbarch.sh (type_align): Extend comment.
3865         * gdbtypes.c (type_align): Add additional comments, always call
3866         gdbarch_type_align before applying the default rules.
3867         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3868         generic code will then apply a suitable default.
3869         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3870         types, return 0 for other types.
3871
3872 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3873
3874         * NEWS: Create a new section for the next release branch.
3875         Rename the section of the current branch, now that it has
3876         been cut.
3877
3878 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3879
3880         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3881         * version.in: Bump version to 8.3.50.DATE-git.
3882
3883 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3884
3885         * aix-thread.c (ptid_cmp): Remove unused variable.
3886         (get_signaled_thread): Likewise.
3887         (store_regs_user_thread): Likewise.
3888         (store_regs_kernel_thread): Likewise.
3889         (fetch_regs_kernel_thread): Remove shadowed variable.
3890
3891 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * features/riscv/32bit-cpu.xml: Add register numbers.
3894         * features/riscv/32bit-fpu.c: Regenerate.
3895         * features/riscv/32bit-fpu.xml: Add register numbers.
3896         * features/riscv/64bit-cpu.xml: Add register numbers.
3897         * features/riscv/64bit-fpu.c: Regenerate.
3898         * features/riscv/64bit-fpu.xml: Add register numbers.
3899
3900 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3901
3902         * NEWS: Mention two argument form of gdb.Value constructor.
3903         * python/py-value.c (convert_buffer_and_type_to_value): New
3904         function.
3905         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3906         Add support for handling an optional second argument.  Call
3907         convert_buffer_and_type_to_value as appropriate.
3908         * python/python-internal.h (Py_buffer_deleter): New struct.
3909         (Py_buffer_up): New typedef.
3910
3911 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3912
3913         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3914         instead of releasing ownership.
3915
3916 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3917
3918         * dwarf2read.c (open_and_init_dwp_file): Call
3919         elf_numsections instead of bfd_count_sections to initialize
3920         dwp_file->num_sections.
3921
3922 2019-02-25  Tom Tromey  <tromey@adacore.com>
3923
3924         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3925
3926 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3927
3928         * gcore.in: Add '--readnever' option when invoking GDB.
3929
3930 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3931
3932         * MAINTAINERS: Update my email address.
3933
3934 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3935
3936         * build-id.c (build_id_to_debug_bfd_1): New function.
3937         (build_id_to_debug_bfd): Look for separate debug file in
3938         sysroot.
3939
3940 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * gdbarch.sh: Update the copyright year range that is placed into
3943         generated files.
3944
3945 2019-02-22  Keith Seitz  <keiths@redhat.com>
3946
3947         PR symtab/23853
3948         * linespec.c (create_sals_line_offset): Search for the default
3949         symtab's filename instead of its fullname.
3950
3951 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3952
3953         * NEWS: Update style defaults.
3954
3955 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3956
3957         * main.c (captured_main_1): Disable styling in batch mode.
3958
3959 2019-02-20  Tom Tromey  <tom@tromey.com>
3960
3961         * symtab.c (symtab_symbol_info): Fix typos.
3962
3963 2019-02-20  Tom Tromey  <tromey@adacore.com>
3964
3965         * findcmd.c (_initialize_mem_search): Use upper case for
3966         metasyntactic variables.
3967
3968 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3969
3970         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3971         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3972
3973 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3974
3975         * top.h (source_file_name): Change to std::string.
3976         * top.c (source_file_name): Likewise.
3977         (command_line_input): Adjust.
3978         * cli/cli-script.c (script_from_file): Adjust.
3979
3980 2019-02-19  Tom Tromey  <tromey@adacore.com>
3981
3982         * ravenscar-thread.c
3983         (ravenscar_thread_target::update_thread_list): Don't call
3984         ada_build_task_list.
3985         * ada-lang.h (ada_build_task_list): Don't declare.
3986         * ada-tasks.c (struct ada_tasks_inferior_data)
3987         <task_list_valid_p>: Now bool.
3988         (read_known_tasks, ada_task_list_changed)
3989         (ada_tasks_invalidate_inferior_data): Update.
3990         (read_known_tasks_array): Return bool.
3991         (read_known_tasks_list): Likewise.
3992         (read_known_tasks): Return void.
3993         (ada_build_task_list): Now static.
3994
3995 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3998         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3999
4000 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4001
4002         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4003         variant for ada_tasks_pspace_data_handle and
4004         ada_tasks_inferior_data_handle.
4005         (ada_tasks_pspace_data_cleanup): New function.
4006         (ada_tasks_inferior_data_cleanup): New function.
4007
4008 2019-02-17  Tom Tromey  <tom@tromey.com>
4009
4010         * macrotab.h (macro_source_fullname): Return a std::string.
4011         * macrotab.c (macro_include, check_for_redefinition)
4012         (macro_undef, macro_lookup_definition, foreach_macro)
4013         (foreach_macro_in_scope): Update.
4014         (macro_source_fullname): Return a std::string.
4015         * macrocmd.c (show_pp_source_pos): Update.
4016
4017 2019-02-17  Tom Tromey  <tom@tromey.com>
4018
4019         * macrocmd.c (show_pp_source_pos): Style the file names.
4020
4021 2019-02-17  Tom Tromey  <tom@tromey.com>
4022
4023         PR tui/24197:
4024         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4025
4026 2019-02-17  Tom Tromey  <tom@tromey.com>
4027
4028         * ada-lang.c (user_select_syms): Use filtered printing.
4029         * utils.c (wrap_style): New global.
4030         (desired_style): Remove.
4031         (emit_style_escape): Add stream parameter.
4032         (set_output_style, reset_terminal_style, prompt_for_continue):
4033         Update.
4034         (flush_wrap_buffer): Only flush gdb_stdout.
4035         (wrap_here): Set wrap_style.
4036         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4037         treat escape sequences as a character.  Change when wrap buffer is
4038         flushed.
4039         (fputs_styled): Do not set the output style when the default is
4040         requested.
4041         * ui-style.h (struct ui_file_style) <is_default>: New method.
4042         * source.c (print_source_lines_base): Emit escape sequences in one
4043         piece.
4044
4045 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4046
4047         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4048         integers and enumeration types.
4049
4050 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4051
4052         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4053         instead of lookup_symbol_in_language
4054         (do_exact_match): New function.
4055         (ada_get_symbol_name_matcher): Return do_exact_match when
4056         doing a verbatim match.
4057
4058 2019-02-15  Tom Tromey  <tromey@adacore.com>
4059
4060         * ravenscar-thread.c (ravenscar_thread_target::resume)
4061         (ravenscar_thread_target::wait): Special case wildcard requests.
4062
4063 2019-02-15  Tom Tromey  <tromey@adacore.com>
4064
4065         * ravenscar-thread.c (base_ptid): Remove.
4066         (struct ravenscar_thread_target) <close>: New method.
4067         <m_base_ptid>: New member.
4068         <update_inferior_ptid, active_task, task_is_currently_active,
4069         runtime_initialized>: Declare methods.
4070         <ravenscar_thread_target>: Add constructor.
4071         (ravenscar_thread_target::task_is_currently_active)
4072         (ravenscar_thread_target::update_inferior_ptid)
4073         (ravenscar_runtime_initialized): Rename.  Now methods.
4074         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4075         (ravenscar_thread_target::update_thread_list): Update.
4076         (ravenscar_thread_target::active_task): Now method.
4077         (ravenscar_thread_target::store_registers)
4078         (ravenscar_thread_target::prepare_to_store)
4079         (ravenscar_thread_target::prepare_to_store)
4080         (ravenscar_thread_target::mourn_inferior): Update.
4081         (ravenscar_inferior_created): Use "new" to create target.
4082         (ravenscar_thread_target::get_ada_task_ptid): Update.
4083         (_initialize_ravenscar): Don't initialize base_ptid.
4084         (ravenscar_ops): Remove global.
4085
4086 2019-02-15  Tom Tromey  <tromey@adacore.com>
4087
4088         * target.h (push_target): Declare new overload.
4089         * target.c (push_target): New overload, taking an rvalue reference.
4090         * remote.c (remote_target::open_1): Use push_target overload.
4091         * corelow.c (core_target_open): Use push_target overload.
4092
4093 2019-02-15  Tom Tromey  <tromey@adacore.com>
4094
4095         * ravenscar-thread.c (is_ravenscar_task)
4096         (ravenscar_task_is_currently_active): Return bool.
4097         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4098         (_initialize_ravenscar): Remove "(void)".
4099         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4100         Return bool.
4101
4102 2019-02-15  Tom Tromey  <tromey@adacore.com>
4103
4104         * ravenscar-thread.c (ravenscar_runtime_initializer)
4105         (has_ravenscar_runtime, get_running_thread_id)
4106         (ravenscar_thread_target::resume): Fix indentation.
4107
4108 2019-02-15  Tom Tromey  <tromey@adacore.com>
4109
4110         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4111         from ravenscar_arch_ops.
4112         (sparc_ravenscar_ops::fetch_registers)
4113         (sparc_ravenscar_ops::store_registers): Now methods.
4114         (sparc_ravenscar_prepare_to_store): Remove.
4115         (sparc_ravenscar_ops): Redefine.
4116         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4117         methods and destructor.  Remove members.
4118         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4119         (ravenscar_thread_target::store_registers)
4120         (ravenscar_thread_target::prepare_to_store): Update.
4121         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4122         Remove.
4123         (struct ppc_ravenscar_powerpc_ops): Derive from
4124         ravenscar_arch_ops.
4125         (ppc_ravenscar_powerpc_ops::fetch_registers)
4126         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4127         (ppc_ravenscar_powerpc_ops): Redefine.
4128         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4129         (ppc_ravenscar_e500_ops::fetch_registers)
4130         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4131         (ppc_ravenscar_e500_ops): Redefine.
4132         * aarch64-ravenscar-thread.c
4133         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4134         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4135         (aarch64_ravenscar_fetch_registers)
4136         (aarch64_ravenscar_store_registers): Now methods.
4137         (aarch64_ravenscar_ops): Redefine.
4138
4139 2019-02-15  Tom Tromey  <tromey@adacore.com>
4140
4141         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4142         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4143         (ravenscar_thread_target::stopped_by_watchpoint)
4144         (ravenscar_thread_target::stopped_data_address)
4145         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4146
4147 2019-02-15  Tom Tromey  <tromey@adacore.com>
4148
4149         * ravenscar-thread.c: Fix some typos.
4150
4151 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4152             Tom Tromey  <tromey@adacore.com>
4153
4154         * ada-lang.c (ada_exception_sal): Change addr_string to a
4155         std::string.
4156         (create_ada_exception_catchpoint): Update.
4157
4158 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4159             Tom Tromey  <tromey@adacore.com>
4160
4161         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4162         (bp_location_ops): Remove.
4163         (base_breakpoint_allocate_location): Update.
4164         (free_bp_location): Update.
4165         * ada-lang.c (class ada_catchpoint_location)
4166         <ada_catchpoint_location>: Remove ops parameter.
4167         (ada_catchpoint_location_dtor): Remove.
4168         (ada_catchpoint_location_ops): Remove.
4169         (allocate_location_exception): Update.
4170         * breakpoint.h (struct bp_location_ops): Remove.
4171         (class bp_location) <bp_location>: Remove bp_location_ops
4172         parameter.
4173         <~bp_location>: Add destructor.
4174         <ops>: Remove.
4175
4176 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4177             Pedro Alves  <palves@redhat.com>
4178
4179         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4180         'PATH_MAX'.
4181
4182 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4183             Samuel Thibault  <samuel.thibault@gnu.org>
4184             Thomas Schwinge  <thomas@codesourcery.com>
4185
4186         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4187         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4188
4189 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4190
4191         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4192         (check_empty): Use "const char *".
4193
4194         * gnu-nat.c (gnu_nat_target::detach): Instead of
4195         'detach_inferior (pid)' call
4196         'detach_inferior (find_inferior_pid (pid))'.
4197
4198         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4199         'nat/fork-inferior.o'.
4200         * gnu-nat.c: #include "nat/fork-inferior.h".
4201
4202         * gnu-nat.c (gnu_nat_target::detach): Instead of
4203         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4204         * gnu-nat.h: #include "inf-child.h".
4205         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4206         'i386_gnu_nat_target::fetch_registers'.
4207         (gnu_store_registers): Rename/move to
4208         'i386_gnu_nat_target::store_registers'.
4209
4210         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4211         * gnu-nat.h (mach_thread_info): New function.
4212         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4213
4214         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4215
4216 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4217
4218         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4219
4220 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4221
4222         * windows-nat.c (windows_add_thread): Add new parameter
4223         "main_thread_p" with default value set to false.  Update
4224         function documentation as well as all callers.
4225         (windows_delete_thread): Likewise.
4226         (fake_create_process): Update call to windows_add_thread.
4227         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4228         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4229         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4230         call to windows_delete_thread.
4231
4232 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4233
4234         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4235
4236 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4237
4238         * symfile.c (find_separate_debug_file): Use canonical path of
4239         sysroot with child_path instead of gdb_sysroot if it is valid.
4240
4241 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4242
4243         * symfile.c (find_separate_debug_file): Use child_path to
4244         determine if an object file is under a sysroot.
4245
4246 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4247
4248         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4249         unittests/child-path-selftests.c.
4250         * common/pathstuff.c (child_path): New function.
4251         * common/pathstuff.h (child_path): New prototype.
4252         * unittests/child-path-selftests.c: New file.
4253
4254 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4255
4256         * symfile.c (find_separate_debug_file): Look for separate debug
4257         files in debug directories under the sysroot.
4258
4259 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4260
4261         * symtab.h (struct minimal_symbol data_p): New const method.
4262         (struct minimal_symbol text_p): Likewise.
4263         * symtab.c (output_source_filename): Use file name style
4264         to print file name.
4265         (print_symbol_info): Likewise.
4266         (print_msymbol_info): Use address style to print addresses.
4267         Use function name style to print executable text symbols.
4268         (expand_symtab_containing_pc): Use data_p.
4269         (find_pc_sect_compunit_symtab): Likewise.
4270
4271 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4272
4273         * breakpoint.c (describe_other_breakpoints): Use address style
4274         to print addresses.
4275         (say_where): Likewise.
4276
4277 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4278
4279         * ada-typeprint.c (print_func_type): Print function name
4280         style to print function name.
4281         * c-typeprint.c (c_print_type_1): Likewise.
4282
4283 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4284
4285         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4286         for execve.
4287
4288 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4289
4290         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4291         type_stack.
4292
4293 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4294
4295         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4296         TYPE_CODE_REF types.
4297
4298 2019-02-08  Jim Wilson  <jimw@sifive.com>
4299
4300         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4301         (riscv_linux_fregset): New.
4302         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4303
4304 2019-02-07  Tom Tromey  <tom@tromey.com>
4305
4306         * thread.c (thread_cancel_execution_command): Update.
4307         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4308         methods.
4309         (struct thread_fsm_ops): Remove.
4310         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4311         (thread_fsm_should_stop, thread_fsm_return_value)
4312         (thread_fsm_set_finished, thread_fsm_finished_p)
4313         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4314         Don't declare.
4315         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4316         * infrun.c (clear_proceed_status_thread)
4317         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4318         (print_stop_event): Update.
4319         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4320         Add constructor.
4321         (step_command_fsm_ops): Remove.
4322         (new_step_command_fsm): Remove.
4323         (step_1): Update.
4324         (step_command_fsm::should_stop): Rename from
4325         step_command_fsm_should_stop.
4326         (step_command_fsm::clean_up): Rename from
4327         step_command_fsm_clean_up.
4328         (step_command_fsm::do_async_reply_reason): Rename from
4329         step_command_fsm_async_reply_reason.
4330         (struct until_next_fsm): Inherit from thread_fsm.  Add
4331         constructor.
4332         (until_next_fsm_ops): Remove.
4333         (new_until_next_fsm): Remove.
4334         (until_next_fsm::should_stop): Rename from
4335         until_next_fsm_should_stop.
4336         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4337         (until_next_fsm::do_async_reply_reason): Rename from
4338         until_next_fsm_async_reply_reason.
4339         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4340         constructor.  Change type of breakpoint.
4341         (finish_command_fsm_ops): Remove.
4342         (new_finish_command_fsm): Remove.
4343         (finish_command_fsm::should_stop): Rename from
4344         finish_command_fsm_should_stop.
4345         (finish_command_fsm::clean_up): Rename from
4346         finish_command_fsm_clean_up.
4347         (finish_command_fsm::return_value): Rename from
4348         finish_command_fsm_return_value.
4349         (finish_command_fsm::do_async_reply_reason): Rename from
4350         finish_command_fsm_async_reply_reason.
4351         (finish_command): Update.
4352         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4353         Add constructor.
4354         (call_thread_fsm_ops): Remove.
4355         (call_thread_fsm::call_thread_fsm): Rename from
4356         new_call_thread_fsm.
4357         (call_thread_fsm::should_stop): Rename from
4358         call_thread_fsm_should_stop.
4359         (call_thread_fsm::should_notify_stop): Rename from
4360         call_thread_fsm_should_notify_stop.
4361         (run_inferior_call, call_function_by_hand_dummy): Update.
4362         * cli/cli-interp.c (should_print_stop_to_console): Update.
4363         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4364         Add constructor.  Change type of location_breakpoint,
4365         caller_breakpoint.
4366         (until_break_fsm_ops): Remove.
4367         (new_until_break_fsm): Remove.
4368         (until_break_fsm::should_stop): Rename from
4369         until_break_fsm_should_stop.
4370         (until_break_fsm::clean_up): Rename from
4371         until_break_fsm_clean_up.
4372         (until_break_fsm::do_async_reply_reason): Rename from
4373         until_break_fsm_async_reply_reason.
4374         (until_break_command): Update.
4375         * thread-fsm.c: Remove.
4376         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4377
4378 2019-02-07  Tom Tromey  <tom@tromey.com>
4379
4380         * yy-remap.h: Add include guard.
4381         * xtensa-tdep.h: Add include guard.
4382         * xcoffread.h: Rename include guard.
4383         * varobj-iter.h: Add include guard.
4384         * tui/tui.h: Rename include guard.
4385         * tui/tui-winsource.h: Rename include guard.
4386         * tui/tui-wingeneral.h: Rename include guard.
4387         * tui/tui-windata.h: Rename include guard.
4388         * tui/tui-win.h: Rename include guard.
4389         * tui/tui-stack.h: Rename include guard.
4390         * tui/tui-source.h: Rename include guard.
4391         * tui/tui-regs.h: Rename include guard.
4392         * tui/tui-out.h: Rename include guard.
4393         * tui/tui-layout.h: Rename include guard.
4394         * tui/tui-io.h: Rename include guard.
4395         * tui/tui-hooks.h: Rename include guard.
4396         * tui/tui-file.h: Rename include guard.
4397         * tui/tui-disasm.h: Rename include guard.
4398         * tui/tui-data.h: Rename include guard.
4399         * tui/tui-command.h: Rename include guard.
4400         * tic6x-tdep.h: Add include guard.
4401         * target/waitstatus.h: Rename include guard.
4402         * target/wait.h: Rename include guard.
4403         * target/target.h: Rename include guard.
4404         * target/resume.h: Rename include guard.
4405         * target-float.h: Rename include guard.
4406         * stabsread.h: Add include guard.
4407         * rs6000-tdep.h: Add include guard.
4408         * riscv-fbsd-tdep.h: Add include guard.
4409         * regformats/regdef.h: Rename include guard.
4410         * record.h: Rename include guard.
4411         * python/python.h: Rename include guard.
4412         * python/python-internal.h: Rename include guard.
4413         * python/py-stopevent.h: Rename include guard.
4414         * python/py-ref.h: Rename include guard.
4415         * python/py-record.h: Rename include guard.
4416         * python/py-record-full.h: Rename include guard.
4417         * python/py-record-btrace.h: Rename include guard.
4418         * python/py-instruction.h: Rename include guard.
4419         * python/py-events.h: Rename include guard.
4420         * python/py-event.h: Rename include guard.
4421         * procfs.h: Add include guard.
4422         * proc-utils.h: Add include guard.
4423         * p-lang.h: Add include guard.
4424         * or1k-tdep.h: Rename include guard.
4425         * observable.h: Rename include guard.
4426         * nto-tdep.h: Rename include guard.
4427         * nat/x86-linux.h: Rename include guard.
4428         * nat/x86-linux-dregs.h: Rename include guard.
4429         * nat/x86-gcc-cpuid.h: Add include guard.
4430         * nat/x86-dregs.h: Rename include guard.
4431         * nat/x86-cpuid.h: Rename include guard.
4432         * nat/ppc-linux.h: Rename include guard.
4433         * nat/mips-linux-watch.h: Rename include guard.
4434         * nat/linux-waitpid.h: Rename include guard.
4435         * nat/linux-ptrace.h: Rename include guard.
4436         * nat/linux-procfs.h: Rename include guard.
4437         * nat/linux-osdata.h: Rename include guard.
4438         * nat/linux-nat.h: Rename include guard.
4439         * nat/linux-namespaces.h: Rename include guard.
4440         * nat/linux-btrace.h: Rename include guard.
4441         * nat/glibc_thread_db.h: Rename include guard.
4442         * nat/gdb_thread_db.h: Rename include guard.
4443         * nat/gdb_ptrace.h: Rename include guard.
4444         * nat/fork-inferior.h: Rename include guard.
4445         * nat/amd64-linux-siginfo.h: Rename include guard.
4446         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4447         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4448         * nat/aarch64-linux.h: Rename include guard.
4449         * nat/aarch64-linux-hw-point.h: Rename include guard.
4450         * mn10300-tdep.h: Add include guard.
4451         * mips-linux-tdep.h: Add include guard.
4452         * mi/mi-parse.h: Rename include guard.
4453         * mi/mi-out.h: Rename include guard.
4454         * mi/mi-main.h: Rename include guard.
4455         * mi/mi-interp.h: Rename include guard.
4456         * mi/mi-getopt.h: Rename include guard.
4457         * mi/mi-console.h: Rename include guard.
4458         * mi/mi-common.h: Rename include guard.
4459         * mi/mi-cmds.h: Rename include guard.
4460         * mi/mi-cmd-break.h: Rename include guard.
4461         * m2-lang.h: Add include guard.
4462         * location.h: Rename include guard.
4463         * linux-record.h: Rename include guard.
4464         * linux-nat.h: Add include guard.
4465         * linux-fork.h: Add include guard.
4466         * i386-darwin-tdep.h: Rename include guard.
4467         * hppa-linux-offsets.h: Add include guard.
4468         * guile/guile.h: Rename include guard.
4469         * guile/guile-internal.h: Rename include guard.
4470         * gnu-nat.h: Rename include guard.
4471         * gdb-stabs.h: Rename include guard.
4472         * frv-tdep.h: Add include guard.
4473         * f-lang.h: Add include guard.
4474         * event-loop.h: Add include guard.
4475         * darwin-nat.h: Rename include guard.
4476         * cp-abi.h: Rename include guard.
4477         * config/sparc/nm-sol2.h: Rename include guard.
4478         * config/nm-nto.h: Rename include guard.
4479         * config/nm-linux.h: Add include guard.
4480         * config/i386/nm-i386gnu.h: Rename include guard.
4481         * config/djgpp/nl_types.h: Rename include guard.
4482         * config/djgpp/langinfo.h: Rename include guard.
4483         * compile/gcc-cp-plugin.h: Add include guard.
4484         * compile/gcc-c-plugin.h: Add include guard.
4485         * compile/compile.h: Rename include guard.
4486         * compile/compile-object-run.h: Rename include guard.
4487         * compile/compile-object-load.h: Rename include guard.
4488         * compile/compile-internal.h: Rename include guard.
4489         * compile/compile-cplus.h: Rename include guard.
4490         * compile/compile-c.h: Rename include guard.
4491         * common/xml-utils.h: Rename include guard.
4492         * common/x86-xstate.h: Rename include guard.
4493         * common/version.h: Rename include guard.
4494         * common/vec.h: Rename include guard.
4495         * common/tdesc.h: Rename include guard.
4496         * common/selftest.h: Rename include guard.
4497         * common/scoped_restore.h: Rename include guard.
4498         * common/scoped_mmap.h: Rename include guard.
4499         * common/scoped_fd.h: Rename include guard.
4500         * common/safe-iterator.h: Rename include guard.
4501         * common/run-time-clock.h: Rename include guard.
4502         * common/refcounted-object.h: Rename include guard.
4503         * common/queue.h: Rename include guard.
4504         * common/ptid.h: Rename include guard.
4505         * common/print-utils.h: Rename include guard.
4506         * common/preprocessor.h: Rename include guard.
4507         * common/pathstuff.h: Rename include guard.
4508         * common/observable.h: Rename include guard.
4509         * common/netstuff.h: Rename include guard.
4510         * common/job-control.h: Rename include guard.
4511         * common/host-defs.h: Rename include guard.
4512         * common/gdb_wait.h: Rename include guard.
4513         * common/gdb_vecs.h: Rename include guard.
4514         * common/gdb_unlinker.h: Rename include guard.
4515         * common/gdb_unique_ptr.h: Rename include guard.
4516         * common/gdb_tilde_expand.h: Rename include guard.
4517         * common/gdb_sys_time.h: Rename include guard.
4518         * common/gdb_string_view.h: Rename include guard.
4519         * common/gdb_splay_tree.h: Rename include guard.
4520         * common/gdb_setjmp.h: Rename include guard.
4521         * common/gdb_ref_ptr.h: Rename include guard.
4522         * common/gdb_optional.h: Rename include guard.
4523         * common/gdb_locale.h: Rename include guard.
4524         * common/gdb_assert.h: Rename include guard.
4525         * common/filtered-iterator.h: Rename include guard.
4526         * common/filestuff.h: Rename include guard.
4527         * common/fileio.h: Rename include guard.
4528         * common/environ.h: Rename include guard.
4529         * common/common-utils.h: Rename include guard.
4530         * common/common-types.h: Rename include guard.
4531         * common/common-regcache.h: Rename include guard.
4532         * common/common-inferior.h: Rename include guard.
4533         * common/common-gdbthread.h: Rename include guard.
4534         * common/common-exceptions.h: Rename include guard.
4535         * common/common-defs.h: Rename include guard.
4536         * common/common-debug.h: Rename include guard.
4537         * common/cleanups.h: Rename include guard.
4538         * common/buffer.h: Rename include guard.
4539         * common/btrace-common.h: Rename include guard.
4540         * common/break-common.h: Rename include guard.
4541         * cli/cli-utils.h: Rename include guard.
4542         * cli/cli-style.h: Rename include guard.
4543         * cli/cli-setshow.h: Rename include guard.
4544         * cli/cli-script.h: Rename include guard.
4545         * cli/cli-interp.h: Rename include guard.
4546         * cli/cli-decode.h: Rename include guard.
4547         * cli/cli-cmds.h: Rename include guard.
4548         * charset-list.h: Add include guard.
4549         * buildsym-legacy.h: Rename include guard.
4550         * bfin-tdep.h: Add include guard.
4551         * ax.h: Rename include guard.
4552         * arm-linux-tdep.h: Add include guard.
4553         * arm-fbsd-tdep.h: Add include guard.
4554         * arch/xtensa.h: Rename include guard.
4555         * arch/tic6x.h: Add include guard.
4556         * arch/i386.h: Add include guard.
4557         * arch/arm.h: Rename include guard.
4558         * arch/arm-linux.h: Rename include guard.
4559         * arch/arm-get-next-pcs.h: Rename include guard.
4560         * arch/amd64.h: Add include guard.
4561         * arch/aarch64-insn.h: Rename include guard.
4562         * arch-utils.h: Rename include guard.
4563         * annotate.h: Add include guard.
4564         * amd64-darwin-tdep.h: Rename include guard.
4565         * aarch64-linux-tdep.h: Add include guard.
4566         * aarch64-fbsd-tdep.h: Add include guard.
4567         * aarch32-linux-nat.h: Add include guard.
4568
4569 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4570
4571         * macrotab.c (macro_define_internal): New function that
4572         factorizes macro_define_object_internal and macro_define_function
4573         code.
4574         (macro_define_object_internal): Use macro_define_internal.
4575         (macro_define_function): Likewise.
4576
4577 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4578
4579         * macrocmd.c (extract_identifier): Return
4580         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4581         callers.
4582
4583 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4584
4585         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4586
4587 2019-02-05  Tom Tromey  <tom@tromey.com>
4588
4589         * target.c (target_stack::unpush): Move assertion earlier.
4590
4591 2019-01-30  Tom Tromey  <tom@tromey.com>
4592
4593         PR python/23615:
4594         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4595         (gdbpy_parse_and_eval): Likewise.
4596         * python/python-internal.h (gdbpy_allow_threads): New class.
4597
4598 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4599
4600         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4601         (aarch64_fbsd_fpregmap): Move earlier.
4602         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4603         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4604         instead of individual calls to trad_frame_set_reg_addr.
4605         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4606         earlier.
4607         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4608         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4609         instead of individual calls to trad_frame_set_reg_addr.
4610
4611 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4612
4613         * CONTRIBUTE: Replace contribution list with wiki link.
4614
4615 2019-01-25  Tom Tromey  <tom@tromey.com>
4616
4617         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4618
4619 2019-01-25  Tom Tromey  <tom@tromey.com>
4620
4621         * xtensa-linux-nat.c: Fix common/ includes.
4622         * xml-support.h: Fix common/ includes.
4623         * xml-support.c: Fix common/ includes.
4624         * x86-linux-nat.c: Fix common/ includes.
4625         * windows-nat.c: Fix common/ includes.
4626         * varobj.h: Fix common/ includes.
4627         * varobj.c: Fix common/ includes.
4628         * value.c: Fix common/ includes.
4629         * valops.c: Fix common/ includes.
4630         * utils.c: Fix common/ includes.
4631         * unittests/xml-utils-selftests.c: Fix common/ includes.
4632         * unittests/utils-selftests.c: Fix common/ includes.
4633         * unittests/unpack-selftests.c: Fix common/ includes.
4634         * unittests/tracepoint-selftests.c: Fix common/ includes.
4635         * unittests/style-selftests.c: Fix common/ includes.
4636         * unittests/string_view-selftests.c: Fix common/ includes.
4637         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4638         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4639         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4640         * unittests/rsp-low-selftests.c: Fix common/ includes.
4641         * unittests/parse-connection-spec-selftests.c: Fix common/
4642         includes.
4643         * unittests/optional-selftests.c: Fix common/ includes.
4644         * unittests/offset-type-selftests.c: Fix common/ includes.
4645         * unittests/observable-selftests.c: Fix common/ includes.
4646         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4647         * unittests/memrange-selftests.c: Fix common/ includes.
4648         * unittests/memory-map-selftests.c: Fix common/ includes.
4649         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4650         * unittests/function-view-selftests.c: Fix common/ includes.
4651         * unittests/environ-selftests.c: Fix common/ includes.
4652         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4653         * unittests/common-utils-selftests.c: Fix common/ includes.
4654         * unittests/cli-utils-selftests.c: Fix common/ includes.
4655         * unittests/array-view-selftests.c: Fix common/ includes.
4656         * ui-file.c: Fix common/ includes.
4657         * tui/tui-io.c: Fix common/ includes.
4658         * tracepoint.h: Fix common/ includes.
4659         * tracepoint.c: Fix common/ includes.
4660         * tracefile-tfile.c: Fix common/ includes.
4661         * top.h: Fix common/ includes.
4662         * top.c: Fix common/ includes.
4663         * thread.c: Fix common/ includes.
4664         * target/waitstatus.h: Fix common/ includes.
4665         * target/waitstatus.c: Fix common/ includes.
4666         * target.h: Fix common/ includes.
4667         * target.c: Fix common/ includes.
4668         * target-memory.c: Fix common/ includes.
4669         * target-descriptions.c: Fix common/ includes.
4670         * symtab.h: Fix common/ includes.
4671         * symfile.c: Fix common/ includes.
4672         * stap-probe.c: Fix common/ includes.
4673         * spu-linux-nat.c: Fix common/ includes.
4674         * sparc-nat.c: Fix common/ includes.
4675         * source.c: Fix common/ includes.
4676         * solib.c: Fix common/ includes.
4677         * solib-target.c: Fix common/ includes.
4678         * ser-unix.c: Fix common/ includes.
4679         * ser-tcp.c: Fix common/ includes.
4680         * ser-pipe.c: Fix common/ includes.
4681         * ser-base.c: Fix common/ includes.
4682         * selftest-arch.c: Fix common/ includes.
4683         * s12z-tdep.c: Fix common/ includes.
4684         * rust-exp.y: Fix common/ includes.
4685         * rs6000-aix-tdep.c: Fix common/ includes.
4686         * riscv-tdep.c: Fix common/ includes.
4687         * remote.c: Fix common/ includes.
4688         * remote-notif.h: Fix common/ includes.
4689         * remote-fileio.h: Fix common/ includes.
4690         * remote-fileio.c: Fix common/ includes.
4691         * regcache.h: Fix common/ includes.
4692         * regcache.c: Fix common/ includes.
4693         * record-btrace.c: Fix common/ includes.
4694         * python/python.c: Fix common/ includes.
4695         * python/py-type.c: Fix common/ includes.
4696         * python/py-inferior.c: Fix common/ includes.
4697         * progspace.h: Fix common/ includes.
4698         * producer.c: Fix common/ includes.
4699         * procfs.c: Fix common/ includes.
4700         * proc-api.c: Fix common/ includes.
4701         * printcmd.c: Fix common/ includes.
4702         * ppc-linux-nat.c: Fix common/ includes.
4703         * parser-defs.h: Fix common/ includes.
4704         * osdata.c: Fix common/ includes.
4705         * obsd-nat.c: Fix common/ includes.
4706         * nat/x86-linux.c: Fix common/ includes.
4707         * nat/x86-linux-dregs.c: Fix common/ includes.
4708         * nat/x86-dregs.h: Fix common/ includes.
4709         * nat/x86-dregs.c: Fix common/ includes.
4710         * nat/ppc-linux.c: Fix common/ includes.
4711         * nat/mips-linux-watch.h: Fix common/ includes.
4712         * nat/mips-linux-watch.c: Fix common/ includes.
4713         * nat/linux-waitpid.c: Fix common/ includes.
4714         * nat/linux-ptrace.h: Fix common/ includes.
4715         * nat/linux-ptrace.c: Fix common/ includes.
4716         * nat/linux-procfs.c: Fix common/ includes.
4717         * nat/linux-personality.c: Fix common/ includes.
4718         * nat/linux-osdata.c: Fix common/ includes.
4719         * nat/linux-namespaces.c: Fix common/ includes.
4720         * nat/linux-btrace.h: Fix common/ includes.
4721         * nat/linux-btrace.c: Fix common/ includes.
4722         * nat/fork-inferior.c: Fix common/ includes.
4723         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4724         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4725         * nat/aarch64-linux.c: Fix common/ includes.
4726         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4727         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4728         * namespace.h: Fix common/ includes.
4729         * mips-linux-tdep.c: Fix common/ includes.
4730         * minsyms.c: Fix common/ includes.
4731         * mi/mi-parse.h: Fix common/ includes.
4732         * mi/mi-main.c: Fix common/ includes.
4733         * mi/mi-cmd-env.c: Fix common/ includes.
4734         * memrange.h: Fix common/ includes.
4735         * memattr.c: Fix common/ includes.
4736         * maint.h: Fix common/ includes.
4737         * maint.c: Fix common/ includes.
4738         * main.c: Fix common/ includes.
4739         * machoread.c: Fix common/ includes.
4740         * location.c: Fix common/ includes.
4741         * linux-thread-db.c: Fix common/ includes.
4742         * linux-nat.c: Fix common/ includes.
4743         * linux-fork.c: Fix common/ includes.
4744         * inline-frame.c: Fix common/ includes.
4745         * infrun.c: Fix common/ includes.
4746         * inflow.c: Fix common/ includes.
4747         * inferior.h: Fix common/ includes.
4748         * inferior.c: Fix common/ includes.
4749         * infcmd.c: Fix common/ includes.
4750         * inf-ptrace.c: Fix common/ includes.
4751         * inf-child.c: Fix common/ includes.
4752         * ia64-linux-nat.c: Fix common/ includes.
4753         * i387-tdep.c: Fix common/ includes.
4754         * i386-tdep.c: Fix common/ includes.
4755         * i386-linux-tdep.c: Fix common/ includes.
4756         * i386-linux-nat.c: Fix common/ includes.
4757         * i386-go32-tdep.c: Fix common/ includes.
4758         * i386-fbsd-tdep.c: Fix common/ includes.
4759         * i386-fbsd-nat.c: Fix common/ includes.
4760         * guile/scm-type.c: Fix common/ includes.
4761         * guile/guile.c: Fix common/ includes.
4762         * go32-nat.c: Fix common/ includes.
4763         * gnu-nat.c: Fix common/ includes.
4764         * gdbthread.h: Fix common/ includes.
4765         * gdbarch-selftests.c: Fix common/ includes.
4766         * gdb_usleep.c: Fix common/ includes.
4767         * gdb_select.h: Fix common/ includes.
4768         * gdb_bfd.c: Fix common/ includes.
4769         * gcore.c: Fix common/ includes.
4770         * fork-child.c: Fix common/ includes.
4771         * findvar.c: Fix common/ includes.
4772         * fbsd-nat.c: Fix common/ includes.
4773         * event-top.c: Fix common/ includes.
4774         * event-loop.c: Fix common/ includes.
4775         * dwarf2read.c: Fix common/ includes.
4776         * dwarf2loc.c: Fix common/ includes.
4777         * dwarf2-frame.c: Fix common/ includes.
4778         * dwarf-index-cache.c: Fix common/ includes.
4779         * dtrace-probe.c: Fix common/ includes.
4780         * disasm-selftests.c: Fix common/ includes.
4781         * defs.h: Fix common/ includes.
4782         * csky-tdep.c: Fix common/ includes.
4783         * cp-valprint.c: Fix common/ includes.
4784         * cp-support.h: Fix common/ includes.
4785         * cp-support.c: Fix common/ includes.
4786         * corelow.c: Fix common/ includes.
4787         * completer.h: Fix common/ includes.
4788         * completer.c: Fix common/ includes.
4789         * compile/compile.c: Fix common/ includes.
4790         * compile/compile-loc2c.c: Fix common/ includes.
4791         * compile/compile-cplus-types.c: Fix common/ includes.
4792         * compile/compile-cplus-symbols.c: Fix common/ includes.
4793         * command.h: Fix common/ includes.
4794         * cli/cli-dump.c: Fix common/ includes.
4795         * cli/cli-cmds.c: Fix common/ includes.
4796         * charset.c: Fix common/ includes.
4797         * build-id.c: Fix common/ includes.
4798         * btrace.h: Fix common/ includes.
4799         * btrace.c: Fix common/ includes.
4800         * breakpoint.h: Fix common/ includes.
4801         * breakpoint.c: Fix common/ includes.
4802         * ax.h:
4803         (enum agent_op): Fix common/ includes.
4804         * ax-general.c (struct aop_map): Fix common/ includes.
4805         * ax-gdb.c: Fix common/ includes.
4806         * auxv.c: Fix common/ includes.
4807         * auto-load.c: Fix common/ includes.
4808         * arm-tdep.c: Fix common/ includes.
4809         * arch/riscv.c: Fix common/ includes.
4810         * arch/ppc-linux-common.c: Fix common/ includes.
4811         * arch/i386.c: Fix common/ includes.
4812         * arch/arm.c: Fix common/ includes.
4813         * arch/arm-linux.c: Fix common/ includes.
4814         * arch/arm-get-next-pcs.c: Fix common/ includes.
4815         * arch/amd64.c: Fix common/ includes.
4816         * arch/aarch64.c: Fix common/ includes.
4817         * arch/aarch64-insn.c: Fix common/ includes.
4818         * arch-utils.c: Fix common/ includes.
4819         * amd64-windows-tdep.c: Fix common/ includes.
4820         * amd64-tdep.c: Fix common/ includes.
4821         * amd64-sol2-tdep.c: Fix common/ includes.
4822         * amd64-obsd-tdep.c: Fix common/ includes.
4823         * amd64-nbsd-tdep.c: Fix common/ includes.
4824         * amd64-linux-tdep.c: Fix common/ includes.
4825         * amd64-linux-nat.c: Fix common/ includes.
4826         * amd64-fbsd-tdep.c: Fix common/ includes.
4827         * amd64-fbsd-nat.c: Fix common/ includes.
4828         * amd64-dicos-tdep.c: Fix common/ includes.
4829         * amd64-darwin-tdep.c: Fix common/ includes.
4830         * agent.c: Fix common/ includes.
4831         * ada-lang.h: Fix common/ includes.
4832         * ada-lang.c: Fix common/ includes.
4833         * aarch64-tdep.c: Fix common/ includes.
4834
4835 2019-01-25  Tom Tromey  <tom@tromey.com>
4836
4837         * common/create-version.sh: Use common/version.h.
4838
4839 2019-01-24  Pedro Alves  <palves@redhat.com>
4840
4841         * infrun.c (signal_stop, signal_print, signal_program)
4842         (signal_catch, signal_pass): Now arrays instead of pointers.
4843         (update_signals_program_target, do_target_resume)
4844         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4845         * linux-nat.c (linux_nat_target::pass_signals)
4846         (linux_nat_target::create_inferior, linux_nat_target::attach):
4847         Adjust.
4848         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4849         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4850         * procfs.c (procfs_target::pass_signals): Adjust.
4851         * record-full.c (record_full_target::resume): Adjust.
4852         * remote.c (remote_target::pass_signals)
4853         (remote_target::program_signals): Adjust.
4854         * target-debug.h (target_debug_print_signals): Now takes a
4855         gdb::array_view as parameter.  Adjust.
4856         * target.h (target_ops) <pass_signals, program_signals>: Replace
4857         pointer and length parameters with gdb::array_view.
4858         (target_pass_signals, target_program_signals): Likewise.
4859         * target-delegates.c: Regenerate.
4860
4861 2019-01-24  Pedro Alves  <palves@redhat.com>
4862
4863         * common/forward-scope-exit.h
4864         (forward_scope_exit::forward_scope_exit): Pass arguments to
4865         m_bind_function directly, instead of creating a std::bind and
4866         copying that.
4867
4868 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4869
4870         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4871         for static members.
4872         (pass_in_v_vfp_candidate): Likewise.
4873
4874 2019-01-23  Tom Tromey  <tom@tromey.com>
4875             Pedro Alves  <palves@redhat.com>
4876
4877         * regcache.c (class regcache_invalidator): Remove.
4878         (regcache::raw_write): Use make_scope_exit.
4879
4880 2019-01-23  Tom Tromey  <tom@tromey.com>
4881
4882         * ui-out.h (class ui_out_emit_type): Update comment.
4883
4884 2019-01-23  Tom Tromey  <tom@tromey.com>
4885
4886         * infrun.c (fetch_inferior_event): Update comment.
4887
4888 2019-01-23  Tom Tromey  <tom@tromey.com>
4889             Pedro Alves  <palves@redhat.com>
4890
4891         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4892         parameter.
4893         (fetch_inferior_event): Use SCOPE_EXIT.
4894
4895
4896 2019-01-23  Tom Tromey  <tom@tromey.com>
4897             Pedro Alves  <palves@redhat.com>
4898
4899         * infrun.c (disable_thread_events): Delete.
4900         (stop_all_threads): Use SCOPE_EXIT.
4901
4902 2019-01-23  Tom Tromey  <tom@tromey.com>
4903             Pedro Alves  <palves@redhat.com>
4904
4905         * symfile.c: Include forward-scope-exit.h.
4906         (clear_symtab_users_cleanup): Replace forward declaration with
4907         a FORWARD_SCOPE_EXIT.
4908         (syms_from_objfile_1): Use the forward_scope_exit and
4909         gdb::optional instead of cleanup_function.
4910         (reread_symbols): Use the forward_scope_exit instead of
4911         cleanup_function.
4912         (clear_symtab_users_cleanup): Remove function.
4913
4914 2019-01-23  Tom Tromey  <tom@tromey.com>
4915             Pedro Alves  <palves@redhat.com>
4916
4917         * linux-nat.c: Include scope-exit.h.
4918         (cleanup_target_stop): Remove.
4919         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4920         SCOPE_EXIT.
4921
4922 2019-01-23  Tom Tromey  <tom@tromey.com>
4923             Pedro Alves  <palves@redhat.com>
4924
4925         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4926         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4927
4928 2019-01-23  Tom Tromey  <tom@tromey.com>
4929             Andrew Burgess  <andrew.burgess@embecosm.com>
4930             Pedro Alves  <palves@redhat.com>
4931
4932         * infrun.c (fetch_inferior_event): Use scope_exit.
4933         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4934         * top.c (execute_command): Use scope_exit.
4935         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4936         * utils.c (do_bpstat_clear_actions_cleanup)
4937         (make_bpstat_clear_actions_cleanup): Remove.
4938
4939 2019-01-23  Tom Tromey  <tom@tromey.com>
4940             Pedro Alves  <palves@redhat.com>
4941
4942         * infrun.c: Include "common/scope-exit.h"
4943         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4944         (wait_for_inferior): Use SCOPE_EXIT.
4945         (fetch_inferior_event): Use scope_exit.
4946
4947 2019-01-23  Tom Tromey  <tom@tromey.com>
4948             Pedro Alves  <palves@redhat.com>
4949
4950         * breakpoint.c (create_breakpoint): Remove cleanup.
4951
4952 2019-01-23  Tom Tromey  <tom@tromey.com>
4953             Andrew Burgess  <andrew.burgess@embecosm.com>
4954             Pedro Alves  <palves@redhat.com>
4955
4956 2019-01-23  Pedro Alves  <palves@redhat.com>
4957
4958         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4959
4960 2019-01-23  Pedro Alves  <palves@redhat.com>
4961             Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * gdbthread.h: Include "common/forward-scope-exit.h".
4964         (scoped_finish_thread_state): Redefine custom class in terms of
4965         forward_scope_exit.
4966
4967 2019-01-23  Pedro Alves  <palves@redhat.com>
4968             Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * common/forward-scope-exit.h: New file.
4971
4972 2019-01-23  Pedro Alves  <palves@redhat.com>
4973             Andrew Burgess  <andrew.burgess@embecosm.com>
4974             Tom Tromey  <tom@tromey.com>
4975
4976         * common/scope-exit.h: New file.
4977
4978 2019-01-23  Pedro Alves  <palves@redhat.com>
4979
4980         * common/preprocessor.h (ESC): Rename to ...
4981         (ESC_PARENS): ... this.
4982         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4983         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4984
4985 2019-01-23  Tom Tromey  <tom@tromey.com>
4986
4987         * language.h (class scoped_switch_to_sym_language_if_auto):
4988         Initialize m_lang in both cases.
4989
4990 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4991
4992         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4993         with XCNEW.
4994
4995 2019-01-22  Tom Tromey  <tom@tromey.com>
4996
4997         * corelow.c: Do not include sys/file.h.
4998
4999 2019-01-22  Tom Tromey  <tom@tromey.com>
5000
5001         * tui/tui-wingeneral.h: Include gdb_curses.h.
5002
5003 2019-01-22  Tom Tromey  <tom@tromey.com>
5004
5005         * source-cache.h (class source_cache) <get_source_lines,
5006         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5007
5008 2019-01-22  Tom Tromey  <tom@tromey.com>
5009
5010         * remote-fileio.h (struct remote_target): Declare.
5011
5012 2019-01-22  Tom Tromey  <tom@tromey.com>
5013
5014         * python/py-arch.c: Do not include py-ref.h.
5015         * python/py-bpevent.c: Do not include py-ref.h.
5016         * python/py-cmd.c: Do not include py-ref.h.
5017         * python/py-continueevent.c: Do not include py-ref.h.
5018         * python/py-event.h: Do not include py-ref.h.
5019         * python/py-evtregistry.c: Do not include py-ref.h.
5020         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5021         * python/py-frame.c: Do not include py-ref.h.
5022         * python/py-framefilter.c: Do not include py-ref.h.
5023         * python/py-function.c: Do not include py-ref.h.
5024         * python/py-infevents.c: Do not include py-ref.h.
5025         * python/py-linetable.c: Do not include py-ref.h.
5026         * python/py-objfile.c: Do not include py-ref.h.
5027         * python/py-param.c: Do not include py-ref.h.
5028         * python/py-prettyprint.c: Do not include py-ref.h.
5029         * python/py-progspace.c: Do not include py-ref.h.
5030         * python/py-symbol.c: Do not include py-ref.h.
5031         * python/py-symtab.c: Do not include py-ref.h.
5032         * python/py-type.c: Do not include py-ref.h.
5033         * python/py-unwind.c: Do not include py-ref.h.
5034         * python/py-utils.c: Do not include py-ref.h.
5035         * python/py-value.c: Do not include py-ref.h.
5036         * python/py-varobj.c: Do not include py-ref.h.
5037         * python/py-xmethods.c: Do not include py-ref.h.
5038         * python/python.c: Do not include py-ref.h.
5039         * varobj.c: Do not include py-ref.h.
5040
5041 2019-01-22  Tom Tromey  <tom@tromey.com>
5042
5043         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5044         keyword for bcache.
5045
5046 2019-01-22  Tom Tromey  <tom@tromey.com>
5047
5048         * compile/compile-cplus-types.c: Remove a comment by #include.
5049
5050 2019-01-22  Tom Tromey  <tom@tromey.com>
5051
5052         * compile/gcc-c-plugin.h: Include compile-internal.h.
5053
5054 2019-01-22  Tom Tromey  <tom@tromey.com>
5055
5056         * stabsread.c (EXTERN): Do not define.
5057         (symnum, next_symbol_text_func, processing_gcc_compilation)
5058         (within_function, global_sym_chain, global_stabs)
5059         (previous_stab_code, this_object_header_files)
5060         (n_this_object_header_files)
5061         (n_allocated_this_object_header_files): Define.
5062         * stabsread.h (EXTERN): Never define.  Use "extern".
5063
5064 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5065
5066         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5067         history_value.
5068
5069 2019-01-21  Tom Tromey  <tom@tromey.com>
5070
5071         * ui-out.c: Fix includes.
5072         * tui/tui-source.c: Fix includes.
5073         * target.c: Fix includes.
5074         * remote.c: Fix includes.
5075         * regcache.c: Fix includes.
5076         * python/py-block.c: Fix includes.
5077         * printcmd.c: Fix includes.
5078         * or1k-tdep.c: Fix includes.
5079         * mi/mi-main.c: Fix includes.
5080         * m32r-tdep.c: Fix includes.
5081         * csky-tdep.c: Fix includes.
5082         * compile/compile-cplus-types.c: Fix includes.
5083         * cli/cli-interp.c: Fix includes.
5084
5085 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5086
5087         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5088         for padding.
5089
5090 2019-01-16  Tom Tromey  <tom@tromey.com>
5091
5092         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5093         earlier.
5094         (struct objfile) <msymbols_range>: Move from top level.
5095         <msymbols>: New method.
5096         (class objfile_msymbols): Remove.
5097         * symtab.c (default_collect_symbol_completion_matches_break_on):
5098         Update.
5099         * symmisc.c (dump_msymbols): Update.
5100         * stabsread.c (scan_file_globals): Update.
5101         * objc-lang.c (info_selectors_command, info_classes_command)
5102         (find_methods): Update.
5103         * minsyms.c (find_solib_trampoline_target): Update.
5104         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5105         * coffread.c (coff_symfile_read): Update.
5106         * ada-lang.c (ada_lookup_simple_minsym)
5107         (ada_collect_symbol_completion_matches): Update.
5108
5109 2019-01-16  Tom Tromey  <tom@tromey.com>
5110
5111         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5112         type.  Remove no-argument constructor.
5113         <iterator::operator++>: Simplify.
5114         <begin>: Update.
5115         <end>: Use minimal_symbol_count.
5116
5117 2019-01-16  Tom Tromey  <tom@tromey.com>
5118
5119         * objfiles.h (struct objfile) <psymtabs>: New method.
5120         (class objfile_psymtabs): Remove.
5121         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5122         typedef.
5123         <range>: New method.
5124         (require_partial_symbols): Change return type.
5125         * psymtab.c (require_partial_symbols)
5126         (psym_expand_symtabs_matching): Update.
5127         * mdebugread.c (parse_partial_symbols): Update.
5128         * dbxread.c (dbx_end_psymtab): Update.
5129
5130 2019-01-15  Tom Tromey  <tom@tromey.com>
5131
5132         * symtab.c (lookup_objfile_from_block)
5133         (lookup_symbol_in_objfile_symtabs)
5134         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5135         (find_line_symtab, info_sources_command)
5136         (default_collect_symbol_completion_matches_break_on)
5137         (make_source_files_completion_list): Update.
5138         * symmisc.c (print_objfile_statistics, dump_objfile)
5139         (maintenance_print_symbols, maintenance_info_symtabs)
5140         (maintenance_check_symtabs, maintenance_info_line_tables):
5141         Update.
5142         * source.c (select_source_symtab)
5143         (forget_cached_source_info_for_objfile): Update.
5144         * objfiles.h (class objfile_compunits): Remove.
5145         (struct objfile) <compunits_range>: New typedef.
5146         (compunits): New method.
5147         * objfiles.c (objfile_relocate1): Update.
5148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5149         * maint.c (count_symtabs_and_blocks): Update.
5150         * linespec.c (iterate_over_all_matching_symtabs): Update.
5151         * cp-support.c (add_symbol_overload_list_qualified): Update.
5152         * coffread.c (coff_symtab_read): Update.
5153         * ada-lang.c (add_nonlocal_symbols)
5154         (ada_collect_symbol_completion_matches)
5155         (ada_add_global_exceptions): Update.
5156
5157 2019-01-15  Tom Tromey  <tom@tromey.com>
5158
5159         * progspace.h (program_space) <objfiles_safe_range>: New
5160         typedef.
5161         <objfiles_safe>: New method.
5162         * objfiles.h (class all_objfiles_safe): Remove.
5163         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5164         * jit.c (jit_inferior_exit_hook): Update.
5165
5166 2019-01-17  Tom Tromey  <tom@tromey.com>
5167
5168         * progspace.h (program_space) <objfiles_range>: New typedef.
5169         <objfiles>: New method.
5170         <objfiles_head>: Rename from objfiles.
5171         (object_files): Update.
5172         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5173         * guile/scm-pretty-print.c
5174         (ppscm_find_pretty_printer_from_objfiles): Update.
5175         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5176         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5177         Update.
5178         * python/py-progspace.c (pspy_get_objfiles): Update.
5179         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5180         Update.
5181         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5182         (objfpy_lookup_objfile_by_build_id): Update.
5183         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5184         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5185         Update.
5186         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5187         (expand_symtab_containing_pc, lookup_objfile_from_block)
5188         (lookup_static_symbol, basic_lookup_transparent_type)
5189         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5190         (find_line_symtab, info_sources_command)
5191         (default_collect_symbol_completion_matches_break_on)
5192         (make_source_files_completion_list, find_main_name): Update.
5193         * symmisc.c (print_symbol_bcache_statistics)
5194         (print_objfile_statistics, maintenance_print_symbols)
5195         (maintenance_print_msymbols, maintenance_print_objfiles)
5196         (maintenance_info_symtabs, maintenance_check_symtabs)
5197         (maintenance_expand_symtabs, maintenance_info_line_tables):
5198         Update.
5199         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5200         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5201         (map_overlay_command, unmap_overlay_command)
5202         (simple_overlay_update, expand_symtabs_matching)
5203         (map_symbol_filenames): Update.
5204         * symfile-debug.c (set_debug_symfile): Update.
5205         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5206         Update.
5207         * source.c (select_source_symtab, forget_cached_source_info):
5208         Update.
5209         * solib.c (solib_read_symbols): Update.
5210         * solib-spu.c (append_ocl_sos): Update.
5211         * psymtab.c (maintenance_print_psymbols)
5212         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5213         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5214         * printcmd.c (info_symbol_command): Update.
5215         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5216         Update.
5217         * objfiles.h (class all_objfiles): Remove.
5218         * objfiles.c (have_partial_symbols, have_full_symbols)
5219         (have_minimal_symbols, qsort_cmp, update_section_map)
5220         (shared_objfile_contains_address_p)
5221         (default_iterate_over_objfiles_in_search_order): Update.
5222         * objc-lang.c (info_selectors_command, info_classes_command)
5223         (find_methods): Update.
5224         * minsyms.c (find_solib_trampoline_target): Update.
5225         * maint.c (maintenance_info_sections)
5226         (maintenance_translate_address, count_symtabs_and_blocks):
5227         Update.
5228         * main.c (captured_main_1): Update.
5229         * linux-thread-db.c (try_thread_db_load_from_pdir)
5230         (has_libpthread): Update.
5231         * linespec.c (iterate_over_all_matching_symtabs)
5232         (search_minsyms_for_name): Update.
5233         * jit.c (jit_find_objf_with_entry_addr): Update.
5234         * hppa-tdep.c (find_unwind_entry)
5235         (hppa_lookup_stub_minimal_symbol): Update.
5236         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5237         Update.
5238         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5239         (elf_gnu_ifunc_resolve_by_got): Update.
5240         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5241         * dwarf-index-write.c (save_gdb_index_command): Update.
5242         * cp-support.c (add_symbol_overload_list_qualified): Update.
5243         * breakpoint.c (create_overlay_event_breakpoint)
5244         (create_longjmp_master_breakpoint)
5245         (create_std_terminate_master_breakpoint)
5246         (create_exception_master_breakpoint): Update.
5247         * blockframe.c (find_pc_partial_function): Update.
5248         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5249         (ada_collect_symbol_completion_matches)
5250         (ada_add_global_exceptions): Update.
5251
5252 2019-01-17  Tom Tromey  <tom@tromey.com>
5253
5254         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5255         declare VEC.
5256         (solib_target_parse_libraries): Change return type.
5257         (library_list_start_segment, library_list_start_section)
5258         (library_list_end_library, library_list_start_library); Update.
5259         (solib_target_free_library_list): Remove.
5260         (solib_target_parse_libraries): Remove cleanup.  Change return
5261         type.
5262         (solib_target_current_sos): Update.
5263
5264 2019-01-17  Tom Tromey  <tromey@bapiya>
5265
5266         * valprint.c: Replace "the the" with "the".
5267         * symtab.c: Replace "the the" with "the".
5268         * solib.c: Replace "the the" with "the".
5269         * solib-dsbt.c: Replace "the the" with "the".
5270         * linespec.c: Replace "the the" with "the".
5271         * dwarf2loc.h: Replace "the the" with "the".
5272         * amd64-windows-tdep.c: Replace "the the" with "the".
5273         * aarch64-tdep.c: Replace "the the" with "the".
5274
5275 2019-01-16  Keith Seitz  <keiths@redhat.com>
5276
5277         PR gdb/23773
5278         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5279         <builder>: Rename to ..
5280         <m_builder>: ... this and make private.
5281         (dwarf2_cu::get_builder): New method.  Change all users of
5282         `builder' to use this method.
5283         (dwarf2_start_symtab): Move to ...
5284         (dwarf2_cu::start_symtab): ... here.  Update all callers
5285         (setup_type_unit_groups): Move to ...
5286         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5287         callers.
5288         (dwarf2_cu::reset_builder): New method.
5289         (process_full_compunit, process_full_type_unit): Use
5290         dwarf2_cu::reset_builder.
5291         (follow_die_offset): Record the ancestor CU if it is different
5292         from the followed DIE's CU.
5293         (follow_die_sig_1): Likewise.
5294
5295 2019-01-15  Tom Tromey  <tom@tromey.com>
5296
5297         * remote.c (class remote_state) <buf>: Now a char_vector.
5298         <buf_size>: Remove.
5299         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5300         parameter.
5301         (remote_target::getpkt_or_notif_sane_1)
5302         (remote_target::getpkt_sane)
5303         (remote_target::getpkt_or_notif_sane): Likewise.
5304         (class remote_target) <putpkt>: New overload.
5305         (remote_target::read_frame): Change type of "buf_p".  Remove
5306         sizeof_p parameter.
5307         (packet_ok): New overload.
5308         (packet_check_result): New overload.
5309         Update all uses.
5310
5311 2019-01-14  Tom Tromey  <tom@tromey.com>
5312
5313         * remote-notif.c (handle_notification, remote_notif_ack)
5314         (remote_notif_parse): Make "buf" const.
5315         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5316         const.
5317         (remote_notif_parse, remote_notif_ack, handle_notification):
5318         Likewise.
5319         * remote.c (remote_notif_stop_parse): Make "buf" const.
5320         (remote_target::remote_parse_stop_reply): Make "buf" const.
5321         (remote_notif_stop_ack): Make "buf" const.
5322
5323 2019-01-14  Tom Tromey  <tom@tromey.com>
5324
5325         * remote.c (remote_console_output): Make parameter const.
5326
5327 2019-01-14  Tom Tromey  <tom@tromey.com>
5328
5329         * target-debug.h (target_debug_print_signals): Constify.
5330         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5331         * procfs.c (procfs_target::pass_signals): Update.
5332         * linux-nat.c (linux_nat_target::pass_signals): Update.
5333         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5334         * target-delegates.c: Rebuild.
5335         * remote.c (remote_target::program_signals): Update.
5336         (remote_target::pass_signals): Update.
5337         * target.c (target_pass_signals): Constify argument.
5338         (target_program_signals): Likewise.
5339         * target.h (struct target_ops) <pass_signals, program_signals>:
5340         Constify argument.
5341         (target_pass_signals, target_program_signals): Constify argument.
5342
5343 2019-01-14  Tom Tromey  <tom@tromey.com>
5344
5345         PR tui/28819:
5346         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5347
5348 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5349
5350         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5351         field.
5352         * rs6000-tdep.c: Include reggroups.h.
5353         (IS_V_ALIAS_PSEUDOREG): Define.
5354         (rs6000_register_name): Return names for the "vX" aliases.
5355         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5356         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5357         aliases.  Call default_register_reggroup_p for all other
5358         pseudo-registers.
5359         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5360         New functions.
5361         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5362         Handle "vX" aliases.
5363         (v_alias_pseudo_register_collect): New function.
5364         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5365         (rs6000_gdbarch_init): Initialize "vX" aliases as
5366         pseudo-registers.  Restore registration of
5367         rs6000_pseudo_register_reggroup_p with
5368         set_tdesc_pseudo_register_reggroup_p.
5369
5370 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5371
5372         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5373         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5374         set_gdbarch_num_pseudo_regs.
5375
5376 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5377
5378         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5379         Remove arg prefixname, add do_set and do_show.
5380         Add member functions set_list and show_list.
5381         * cli/cli-style.c (class cli_style_option): Update accordingly.
5382         (style_set_list): Move to file scope.
5383         (style_show_list): Likewise.
5384         (set_style): Call help_list.
5385         (show_style): Call cmd_show_list.
5386         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5387         Update to use the new macro.
5388
5389 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5390
5391         * ada-lang.c (_initialize_ada_language): Expand the help text
5392         for the "catch exception" command.
5393
5394 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5395
5396         * symtab.c (matching_obj_sections): Initialize obj,
5397         declare it closer to its usage.
5398
5399 2019-01-10  Tom Tromey  <tom@tromey.com>
5400
5401         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5402         (basic_inf_threads_range): Remove.
5403         (inf_threads_range, inf_non_exited_threads_range)
5404         (safe_inf_threads_range): Use next_adapter.
5405
5406 2019-01-10  Keith Seitz  <keiths@redhat.com>
5407
5408         PR gdb/23712
5409         PR symtab/23010
5410         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5411         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5412
5413 2019-01-10  Keith Seitz  <keiths@redhat.com>
5414
5415         PR gdb/23712
5416         PR symtab/23010
5417         * dictionary.c (pending_to_vector): Remove.
5418         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5419         Remove _1 suffix, replacing functions of the same name.  Update
5420         all callers.
5421         (dict_create_hashed, dict_create_hashed_expandable)
5422         (dict_create_linear, dict_create_linear_expandable, dict_free)
5423         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5424         Make functions static.
5425
5426 2019-01-10  Keith Seitz  <keiths@redhat.com>
5427
5428         PR gdb/23712
5429         PR symtab/23010
5430         * dictionary.h (struct dictionary): Replace declaration with
5431         multidictionary.
5432         (dict_create_hashed, dict_create_hashed_expandable)
5433         (dict_create_linear, dict_create_linear_expandable)
5434         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5435         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5436         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5437         taking multidictionary argument.
5438         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5439         * block.h (struct block) <dict>: Change to multidictionary
5440         and rename `multidict'.
5441         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5442         symmisc.c: Update all dictionary references to multidictionary.
5443
5444 2019-01-10  Keith Seitz  <keiths@redhat.com>
5445
5446         PR gdb/23712
5447         PR symtab/23010
5448         * dictionary.c: Include unordered_map.
5449         (pending_to_vector): New function.
5450         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5451         Rewrite the non-"_1" functions to take vector instead
5452         of linked list.
5453         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5454         "new" _1 versions of the same name.
5455         (multidictionary): Define.
5456         (std::hash<enum language): New definition.
5457         (collate_pending_symbols_by_language, mdict_create_hashed)
5458         (mdict_create_hashed_expandable, mdict_create_linear)
5459         (mdict_create_linear_expandable, mdict_free)
5460         (find_language_dictionary, create_new_language_dictionary)
5461         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5462         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5463         (mdict_size, mdict_empty): New functions.
5464         * dictionary.h (mdict_iterator): Define.
5465
5466 2019-01-10  Pedro Alves  <palves@redhat.com>
5467
5468         * breakpoint.c (read_uploaded_action)
5469         (create_tracepoint_from_upload): Adjust to use
5470         gdb::unique_xmalloc_ptr.
5471         * ctf.c (ctf_write_uploaded_tp):
5472         (SET_ARRAY_FIELD): Use emplace_back.
5473         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5474         * tracefile-tfile.c (tfile_write_uploaded_tp):
5475         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5476         gdb::unique_xmalloc_ptr.
5477         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5478         at_string, cond_string, cmd_strings>: Replace char pointers
5479         with gdb::unique_xmalloc_ptr.
5480
5481 2019-01-10  Pedro Alves  <palves@redhat.com>
5482
5483         * solib-target.c (library_list_start_library): Don't xstrdup name.
5484
5485 2019-01-10  Pedro Alves  <palves@redhat.com>
5486
5487         * mdebugread.c (parse_partial_symbols): Use
5488         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5489
5490 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5491
5492         * linux-fork.c (scoped_switch_fork_info)
5493         <~scoped_switch_fork_info>: Fix incorrect variable name.
5494
5495 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5496
5497         * linux-fork.c (scoped_switch_fork_info)
5498         <scoped_switch_fork_info>: Make explicit.
5499         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5500
5501 2019-01-10  Tom Tromey  <tom@tromey.com>
5502
5503         * objfiles.h (objfile::reset_psymtabs): Update.
5504         * objfiles.c (objfile::objfile): Update.
5505         * psymtab.h (psymtab_storage::obstack): Update.
5506         (psymtab_storage::m_obstack): Use gdb::optional.
5507         (class psymtab_storage): Update comment.  Remove objfile
5508         parameter.
5509         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5510
5511 2019-01-10  Tom Tromey  <tom@tromey.com>
5512
5513         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5514         <free_psymtabs>: Now private.
5515         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5516         (allocate_psymtab): Use new method.
5517
5518 2019-01-10  Tom Tromey  <tom@tromey.com>
5519
5520         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5521         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5522         * mdebugread.c (parse_partial_symbols): Use
5523         allocate_dependencies.
5524         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5525         allocate_dependencies.
5526         (process_psymtab_comp_unit_reader)
5527         (build_type_psymtab_dependencies): Likewise.
5528         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5529
5530 2019-01-10  Tom Tromey  <tom@tromey.com>
5531
5532         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5533         PSYMBOL_SET_LANGUAGE.
5534         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5535
5536 2019-01-10  Tom Tromey  <tom@tromey.com>
5537
5538         * psymtab.h (psymtab_storage::obstack): New method.
5539         <m_obstack>: Rename from obstack; now private.
5540         * psymtab.c (psymtab_storage): Update.
5541         * dwarf2read.c (create_addrmap_from_index)
5542         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5543         Update.
5544
5545 2019-01-10  Tom Tromey  <tom@tromey.com>
5546
5547         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5548         * objfiles.h (objfile::reset_psymtabs): New method.
5549
5550 2019-01-10  Tom Tromey  <tom@tromey.com>
5551
5552         * symmisc.c (print_symbol_bcache_statistics): Update.
5553         (print_objfile_statistics): Update.
5554         * symfile.c (reread_symbols): Update.
5555         * psymtab.h (class psymtab_storage): New.
5556         * psymtab.c (psymtab_storage): New constructor.
5557         (~psymtab_storage): New destructor.
5558         (require_partial_symbols): Update.
5559         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5560         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5561         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5562         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5563         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5564         (start_psymtab_common, end_psymtab_common)
5565         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5566         (allocate_psymtab): Update.
5567         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5568         Update.
5569         (dump_psymtab_addrmap, maintenance_print_psymbols)
5570         (maintenance_check_psymtabs): Update.
5571         (class objfile_psymtabs): Move to objfiles.h.
5572         * psympriv.h (discard_psymtab): Now inline.
5573         (psymtab_discarder::psymtab_discarder): Update.
5574         (psymtab_discarder::~psymtab_discarder): Update.
5575         (ALL_OBJFILE_PSYMTABS): Rewrite.
5576         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5577         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5578         Remove fields.
5579         <partial_symtabs>: New field.
5580         (class objfile_psymtabs): Move from psymtab.h.  Update.
5581         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5582         psymbol_cache.
5583         (objfile::~objfile): Don't destroy psymbol_cache.
5584         * mdebugread.c (parse_partial_symbols): Update.
5585         * dwarf2read.c (create_addrmap_from_index)
5586         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5587         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5588         (add_partial_subprogram, dwarf2_ranges_read): Update.
5589         * dwarf-index-write.c (write_address_map)
5590         (write_one_signatured_type, recursively_write_psymbols)
5591         (class debug_names, class debug_names, write_psymtabs_to_index):
5592         Update.
5593
5594 2019-01-10  Tom Tromey  <tom@tromey.com>
5595
5596         * symtab.h (SYMBOL_SET_NAMES): Update.
5597         (symbol_set_names): Update.
5598         (MSYMBOL_SET_NAMES): Update.
5599         * symtab.c (symbol_set_names): Change argument to be an
5600         objfile_per_bfd_storage.
5601         * psymtab.c (add_psymbol_to_bcache): Update.
5602         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5603
5604 2019-01-10  Tom Tromey  <tom@tromey.com>
5605
5606         * symtab.c (create_demangled_names_hash): Change argument to be an
5607         objfile_per_bfd_storage.
5608         (symbol_set_names): Update.
5609
5610 2019-01-10  Tom Tromey  <tom@tromey.com>
5611
5612         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5613         init_psymbol_list.
5614         * psymtab.c (init_psymbol_list): Do nothing if already called.
5615         * psympriv.h (init_psymbol_list): Add comment.
5616         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5617         init_psymbol_list.
5618         * dbxread.c (dbx_symfile_read): Unconditionally call
5619         init_psymbol_list.
5620
5621 2019-01-10  Tom Tromey  <tom@tromey.com>
5622
5623         * xcoffread.c (scan_xcoff_symtab): Update.
5624         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5625         "where".
5626         * mdebugread.c (parse_partial_symbols)
5627         (handle_psymbol_enumerators): Update.
5628         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5629         * dbxread.c (read_dbx_symtab): Update.
5630         * psympriv.h (psymbol_placement): New enum.
5631         (add_psymbol_to_list): Update.
5632
5633 2019-01-10  Tom Tromey  <tom@tromey.com>
5634
5635         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5636         static_psymbols parameters.
5637         (scan_xcoff_symtab): Update.
5638         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5639         static_psymbols parameters.
5640         * psympriv.h (start_psymtab_common): Update.
5641         * mdebugread.c (parse_partial_symbols): Update.
5642         * dwarf2read.c (create_partial_symtab): Update.
5643         * dbxread.c (read_dbx_symtab): Update.
5644         (start_psymtab): Remove global_psymbols and static_psymbols
5645         parameters.
5646
5647 2019-01-10  Tom Tromey  <tom@tromey.com>
5648
5649         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5650         * psymtab.c (allocate_psymtab): Add comment.
5651         * psympriv.h (allocate_psymtab): Add comment.
5652         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5653         initializations.
5654         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5655
5656 2019-01-10  Tom Tromey  <tom@tromey.com>
5657
5658         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5659         Don't declare.
5660         * mipsread.c: Include mdebugread.h.
5661         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5662         Declare.
5663         * elfread.c: Include mdebugread.h.
5664
5665 2019-01-09  Tom Tromey  <tom@tromey.com>
5666
5667         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5668         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5669         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5670         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5671         (psym_lookup_symbol, psym_find_last_source_symtab)
5672         (psym_forget_cached_source_info, psym_print_stats)
5673         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5674         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5675         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5676         (psym_find_compunit_symtab_by_address)
5677         (maintenance_print_psymbols, maintenance_info_psymtabs)
5678         (maintenance_check_psymtabs): Use ranged for.
5679         * psymtab.h (class objfile_psymtabs): New.
5680         (require_partial_symbols): Return objfile_psymtabs.
5681         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5682
5683 2019-01-09  Tom Tromey  <tom@tromey.com>
5684
5685         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5686         (find_pc_mapped_section, list_overlays_command)
5687         (map_overlay_command, unmap_overlay_command)
5688         (simple_overlay_update): Use all_objfiles.
5689         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5690         * printcmd.c (info_symbol_command): Use all_objfiles.
5691         * objfiles.h (ALL_OBJSECTIONS): Remove.
5692         * maint.c (maintenance_translate_address): Use all_objfiles.
5693         * gcore.c (gcore_create_callback): Use all_objfiles.
5694         (objfile_find_memory_regions): Likewise.
5695
5696 2019-01-09  Tom Tromey  <tom@tromey.com>
5697
5698         * symtab.c (find_line_symtab, info_sources_command)
5699         (make_source_files_completion_list): Use objfile_compunits.
5700         * source.c (select_source_symtab): Use objfile_compunits.
5701         * objfiles.h (struct objfile): Update comment.
5702         (ALL_OBJFILES): Remove.
5703         (ALL_FILETABS): Remove.
5704         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5705         objfile_compunits.
5706
5707 2019-01-09  Tom Tromey  <tom@tromey.com>
5708
5709         * symmisc.c (print_objfile_statistics, dump_objfile)
5710         (maintenance_print_symbols): Use compunit_filetabs.
5711         * source.c (forget_cached_source_info_for_objfile): Use
5712         compunit_filetabs.
5713         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5714         (ALL_FILETABS): Use compunit_filetabs.
5715         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5716         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5717
5718 2019-01-09  Tom Tromey  <tom@tromey.com>
5719
5720         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5721         (compunit_filetabs): New.
5722         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5723         compunit_filetabs.
5724         (info_sources_command, make_source_files_completion_list): Remove
5725         declaration.
5726         * symmisc.c (print_objfile_statistics, dump_objfile)
5727         (maintenance_print_symbols): Remove declaration.
5728         (maintenance_info_symtabs): Use compunit_filetabs.
5729         (maintenance_info_line_tables): Likewise.
5730         * source.c (select_source_symtab): Change local variable name.
5731         (forget_cached_source_info_for_objfile): Remove declaration.
5732         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5733         * objfiles.c (objfile_relocate1): Remove declaration.
5734         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5735         declaration.
5736         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5737         * coffread.c (coff_symtab_read): Remove declaration.
5738         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5739         compunit_filetabs.
5740
5741 2019-01-09  Tom Tromey  <tom@tromey.com>
5742
5743         * symtab.c (lookup_objfile_from_block)
5744         (find_pc_sect_compunit_symtab, search_symbols)
5745         (default_collect_symbol_completion_matches_break_on): Use
5746         objfile_compunits.
5747         * objfiles.h (ALL_COMPUNITS): Remove.
5748         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5749         * cp-support.c (add_symbol_overload_list_qualified): Use
5750         objfile_compunits.
5751         * ada-lang.c (ada_collect_symbol_completion_matches)
5752         (ada_add_global_exceptions): Use objfile_compunits.
5753
5754 2019-01-09  Tom Tromey  <tom@tromey.com>
5755
5756         * source.c (select_source_symtab)
5757         (forget_cached_source_info_for_objfile): Remove declaration.
5758         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5759         declaration.
5760         * maint.c (count_symtabs_and_blocks): Remove declaration.
5761         * cp-support.c (add_symbol_overload_list_qualified): Remove
5762         declaration.
5763         * coffread.c (coff_symtab_read): Remove declaration.
5764         * symtab.c (lookup_symbol_in_objfile_symtabs)
5765         (basic_lookup_transparent_type_1): Use objfile_compunits.
5766         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5767         (info_sources_command, search_symbols)
5768         (default_collect_symbol_completion_matches_break_on)
5769         (make_source_files_completion_list): Remove declaration.
5770         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5771         (ada_collect_symbol_completion_matches)
5772         (ada_add_global_exceptions): Remove declaration.
5773         * linespec.c (iterate_over_all_matching_symtabs): Use
5774         objfile_compunits.
5775         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5776         (class objfile_compunits): New.
5777         (ALL_COMPUNITS): Use objfile_compunits.
5778         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5779         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5780         objfile_compunits.
5781         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5782
5783 2019-01-09  Tom Tromey  <tom@tromey.com>
5784
5785         * symtab.c (search_symbols)
5786         (default_collect_symbol_completion_matches_break_on): Use
5787         objfile_msymbols.
5788         * ada-lang.c (ada_lookup_simple_minsym)
5789         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5790         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5791         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5792         objfile_msymbols.
5793         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5794         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5795         * objc-lang.c (find_methods): Use objfile_msymbols.
5796         (info_selectors_command, info_classes_command): Likewise.
5797         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5798         * objfiles.h (class objfile_msymbols): New.
5799         (ALL_OBJFILE_MSYMBOLS): Remove.
5800         (ALL_MSYMBOLS): Remove.
5801
5802 2019-01-09  Tom Tromey  <tom@tromey.com>
5803
5804         * common/next-iterator.h (next_adapter): Add Iterator template
5805         parameter.
5806         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5807         (class all_objfiles_safe): New.
5808         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5809         * objfiles.c (put_objfile_before): Update comment.
5810         (add_separate_debug_objfile): Likewise.
5811         (free_all_objfiles): Use all_objfiles_safe.
5812         (objfile_purge_solibs): Likewise.
5813
5814 2019-01-09  Tom Tromey  <tom@tromey.com>
5815
5816         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5817         (expand_symtab_containing_pc, lookup_static_symbol)
5818         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5819         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5820         all_objfiles.
5821         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5822         * breakpoint.c (create_overlay_event_breakpoint)
5823         (create_longjmp_master_breakpoint)
5824         (create_std_terminate_master_breakpoint)
5825         (create_exception_master_breakpoint): Use all_objfiles.
5826         * linux-thread-db.c (try_thread_db_load_from_pdir)
5827         (has_libpthread): Use all_objfiles.
5828         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5829         * linespec.c (iterate_over_all_matching_symtabs)
5830         (search_minsyms_for_name): Use all_objfiles.
5831         * maint.c (maintenance_info_sections): Use all_objfiles.
5832         * main.c (captured_main_1): Use all_objfiles.
5833         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5834         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5835         * guile/scm-pretty-print.c
5836         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5837         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5838         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5839         (maintenance_print_msymbols): Use all_objfiles.
5840         * source.c (select_source_symtab): Use all_objfiles.
5841         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5842         * symfile.c (remove_symbol_file_command)
5843         (expand_symtabs_matching, map_symbol_filenames): Use
5844         all_objfiles.
5845         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5846         all_objfiles.
5847         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5848         * objc-lang.c (find_methods): Use all_objfiles.
5849         * objfiles.c (have_partial_symbols, have_full_symbols)
5850         (have_minimal_symbols, qsort_cmp)
5851         (default_iterate_over_objfiles_in_search_order): Use
5852         all_objfiles.
5853         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5854         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5855         (maintenance_check_psymtabs): Use all_objfiles.
5856         (ALL_PSYMTABS): Remove.
5857         * compile/compile-object-run.c (do_module_cleanup): Use
5858         all_objfiles.
5859         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5860         * cp-support.c (add_symbol_overload_list_qualified): Use
5861         all_objfiles.
5862         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5863         Use all_objfiles.
5864         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5865         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5866         all_objfiles.
5867         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5868         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5869         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5870         Uses all_objfiles.
5871         * solib.c (solib_read_symbols): Use all_objfiles
5872
5873 2019-01-09  Tom Tromey  <tom@tromey.com>
5874
5875         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5876         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5877         all_objfiles.
5878         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5879         * symmisc.c (print_symbol_bcache_statistics)
5880         (print_objfile_statistics, maintenance_print_objfiles)
5881         (maintenance_info_symtabs, maintenance_check_symtabs)
5882         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5883         all_objfiles.
5884         * source.c (forget_cached_source_info): Use all_objfiles.
5885         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5886         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5887         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5888         * objfiles.c (update_section_map): Use all_objfiles.
5889         (shared_objfile_contains_address_p): Likewise.
5890         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5891         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5892
5893 2019-01-09  Tom Tromey  <tom@tromey.com>
5894
5895         * common/next-iterator.h: New file.
5896         * objfiles.h (class all_objfiles): New.
5897         (struct objfile_iterator): New.
5898
5899 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5900
5901         * NEWS: Move the description of the changed "frame", "select-frame",
5902          and "info frame" commands to the Changed commands section.
5903
5904 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5905
5906         * gdbtypes.c (check_stub_method_group): Remove handling of old
5907         mangling schemes.
5908         * linespec.c (find_methods): Likewise.
5909         * stabsread.c (read_member_functions): Likewise.
5910         * valops.c (search_struct_method): Likewise.
5911         (value_struct_elt_for_reference): Likewise.
5912         * NEWS: Mention this change.
5913
5914 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5915
5916         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5917         print_source_lines.
5918         * source.c (print_source_lines_base): Update line number check.
5919         (print_source_lines): New function.
5920         (source_lines_range::source_lines_range): New function.
5921         * source.h (class source_lines_range): New class.
5922         (print_source_lines): New declaration.
5923
5924 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5925
5926         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5927
5928 2019-01-08  Tom Tromey  <tom@tromey.com>
5929             Simon Marchi  <simon.marchi@ericsson.com>
5930
5931         PR gdb/24060
5932         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5933         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5934         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5935         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5936         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5937         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5938
5939 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * source.c (select_source_symtab): Move header comment to
5942         declaration in source.h.
5943         (forget_cached_source_info_for_objfile): Likewise.
5944         (forget_cached_source_info): Likewise.
5945         (identify_source_line): Likewise.
5946         * source.h (identify_source_line): Move declaration from symtab.h
5947         and add comment from source.c
5948         (print_source_lines): Likewise.
5949         (forget_cached_source_info_for_objfile): Likewise.
5950         (forget_cached_source_info): Likewise.
5951         (select_source_symtab): Likewise.
5952         (enum print_source_lines_flag): Move definition from symtab.h.
5953         * symtab.h (identify_source_line): Move declaration to source.h.
5954         (print_source_lines): Likewise.
5955         (forget_cached_source_info_for_objfile): Likewise.
5956         (forget_cached_source_info): Likewise.
5957         (select_source_symtab): Likewise.
5958         (enum print_source_lines_flag): Move definition to source.h.
5959         * tui/tui-hooks.c: Add 'source.h' include.
5960
5961 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5962
5963         * source.c (print_source_lines_base): Handle requests to print
5964         reverse line number sequences, and guard against empty lines
5965         string.
5966
5967 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5968
5969         * source.c (print_source_lines_base): Fix skip of '\r' if next
5970         character is '\n'.
5971
5972 2019-01-06  Tom Tromey  <tom@tromey.com>
5973
5974         * c-exp.y (struct c_parse_state) <macro_original_text,
5975         expansion_obstack>: New member.
5976         (macro_original_text, expansion_obstack): Remove globals.
5977         (scan_macro_expansion, scanning_macro_expansion)
5978         (finished_macro_expansion): Update.
5979         (scan_macro_cleanup): Remove.
5980         (yylex, c_parse): Update.
5981
5982 2019-01-06  Tom Tromey  <tom@tromey.com>
5983
5984         * c-exp.y (struct c_parse_state) <strings>: New member.
5985         (operator_stoken): Update.
5986
5987 2019-01-06  Tom Tromey  <tom@tromey.com>
5988
5989         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5990         (union type_stack_elt) <typelist_val>: Now a pointer to
5991         std::vector.
5992         (type_stack_cleanup): Don't declare.
5993         (push_typelist): Update.
5994         * parse.c (pop_typelist): Return a std::vector.
5995         (push_typelist): Take a std::vector.
5996         (follow_types): Update.  Do not free args.
5997         (type_stack_cleanup): Remove.
5998         * c-exp.y (struct c_parse_state): New.
5999         (cpstate): New global.
6000         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6001         (nonempty_typelist): Update.
6002         (func_mod): Create a new vector.
6003         (c_parse): Create a c_parse_state.
6004         (check_parameter_typelist): Do not delete params.
6005         (function_method): Update.  Do not delete type_list.
6006
6007 2019-01-06  Tom Tromey  <tom@tromey.com>
6008
6009         PR gdb/28155:
6010         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6011         check_typedef.
6012         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6013         (print_return_value): Likewise.
6014
6015 2019-01-05  Tom Tromey  <tom@tromey.com>
6016
6017         * contrib/cleanup_check.py: Remove.
6018         * contrib/gcc-with-excheck: Remove.
6019         * contrib/exsummary.py: Remove.
6020         * contrib/excheck.py: Remove.
6021
6022 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6023
6024         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6025         NULL. Initialize tpprev to NULL instead of assigning it
6026         to NULL on the next statement.
6027         * windows-nat.c (windows_delete_thread): Remove check for
6028         main_thread_id before printing thread exit notifications.
6029         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6030         Remove thread ID check against main_thread_id.
6031         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6032         windows_delete_thread.
6033         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6034
6035 2019-01-04  Tom Tromey  <tom@tromey.com>
6036
6037         * compile/compile.c (_initialize_compile): Use upper case for
6038         metasyntactic variables.
6039         * symmisc.c (_initialize_symmisc): Use upper case for
6040         metasyntactic variables.
6041         * psymtab.c (_initialize_psymtab): Use upper case for
6042         metasyntactic variables.
6043         * demangle.c (demangle_command): Use upper case for metasyntactic
6044         variables.
6045         (_initialize_demangler): Likewise.
6046         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6047         variables.
6048
6049 2019-01-03  Tom Tromey  <tom@tromey.com>
6050
6051         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6052
6053 2019-01-03  Tom Tromey  <tom@tromey.com>
6054
6055         * python/py-symtab.c (salpy_str): Update.
6056         (struct salpy_sal_object) <symtab>: Now a PyObject.
6057         (salpy_dealloc): Update.
6058         (del_objfile_sal): Use gdbpy_ref.
6059
6060 2019-01-03  Tom Tromey  <tom@tromey.com>
6061
6062         * python/py-type.c (convert_field): Use new_reference.  Return
6063         gdbpy_ref.
6064         (make_fielditem): Return gdbpy_ref.
6065         (typy_fields): Update.
6066         (typy_getitem): Update.
6067         (field_name): Return gdbpy_ref.  Use new_reference.
6068         (typy_iterator_iternext): Update.
6069
6070 2019-01-03  Tom Tromey  <tom@tromey.com>
6071
6072         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6073
6074 2019-01-03  Tom Tromey  <tom@tromey.com>
6075
6076         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6077         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6078         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6079         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6080         (pspy_set_type_printers): Likewise.
6081         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6082         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6083         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6084         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6085         (objfpy_set_type_printers): Likewise.
6086
6087 2019-01-03  Tom Tromey  <tom@tromey.com>
6088
6089         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6090         (gdbpy_print_stack): Use gdbpy_err_fetch.
6091         * python/python-internal.h (class gdbpy_err_fetch): New class.
6092         (class gdbpy_enter) <m_error_type, m_error_value,
6093         m_error_traceback>: Remove.
6094         <m_error>: New member.
6095         (gdbpy_exception_to_string): Don't declare.
6096         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6097         * python/py-value.c (convert_value_from_python): Use
6098         gdbpy_err_fetch.
6099         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6100         gdbpy_exception_to_string.
6101         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6102         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6103         gdbpy_err_fetch.
6104
6105 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         * linux-nat.c (delete_lwp_cleanup): Delete.
6108         (struct lwp_deleter): New struct.
6109         (lwp_info_up): New typedef.
6110         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6111         lwp_info_up.
6112
6113 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6114
6115         * linux-fork.c (class scoped_switch_fork_info): New class.
6116         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6117
6118 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6119
6120         * valops.c (find_overload_match): Remove use of null_cleanup, and
6121         calls to do_cleanups.
6122
6123 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6124
6125         * compile/compile-cplus-types.c
6126         (compile_cplus_instance::decl_name): Handle changes to
6127         cp_func_name.
6128         * cp-support.c (cp_func_name): Update header comment, update
6129         return type.
6130         * cp-support.h (cp_func_name): Update return type in declaration.
6131         * valops.c (find_overload_match): Move temp_func local to top
6132         level of function and change its type.  Use temp_func to hold and
6133         delete temporary string obtained from cp_func_name.
6134
6135 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6136
6137         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6138         gdb::char_vector, remove cleanup, and update uses of `msg`.
6139
6140 2019-01-03  Jim Wilson  <jimw@sifive.com>
6141
6142         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6143
6144 2019-01-02  Tom Tromey  <tom@tromey.com>
6145
6146         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6147         (tdesc_parse_xml): Remove cleanups.
6148         * target-descriptions.h (make_cleanup_free_target_description):
6149         Don't declare.
6150         (target_desc_deleter): New struct.
6151         (target_desc_up): New typedef.
6152         * target-descriptions.c (target_desc_deleter::operator()): Rename
6153         from free_target_description.
6154         (make_cleanup_free_target_description): Remove.
6155
6156 2019-01-02  Tom Tromey  <tom@tromey.com>
6157
6158         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6159         constructor, destructor.
6160         (linespec_parser): Remove typedef.
6161         (~linespec_parser): Rename from linespec_parser_delete.
6162         (linespec_lex_to_end, linespec_complete_label)
6163         (linespec_complete): Update.
6164         (decode_line_full): Remove cleanups.
6165         (decode_line_1): Update.
6166
6167 2019-01-02  Tom Tromey  <tom@tromey.com>
6168
6169         * python/python-internal.h (inferior_to_inferior_object): Change
6170         return type.
6171         * python/py-exitedevent.c (create_exited_event_object): Update.
6172         * python/py-inferior.c (inferior_to_inferior_object): Return
6173         gdbpy_ref.
6174         (python_new_inferior, python_inferior_deleted)
6175         (thread_to_thread_object, delete_thread_object)
6176         (build_inferior_list, gdbpy_selected_inferior): Update.
6177         * python/py-infthread.c (create_thread_object): Update.  Also fail
6178         if inferior_to_inferior_object fails.
6179
6180 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6181
6182         * inferior.h (class inferior) <displaced_step_state>: New field.
6183         * infrun.h (struct displaced_step_state): Move here from
6184         infrun.c.  Initialize fields, add constructor.
6185         <inf>: Remove field.
6186         <reset>: New method.
6187         * infrun.c (struct displaced_step_inferior_state): Move to
6188         infrun.h.
6189         (displaced_step_inferior_states): Remove.
6190         (get_displaced_stepping_state): Adust.
6191         (displaced_step_in_progress_any_inferior): Adjust.
6192         (displaced_step_in_progress_thread): Adjust.
6193         (displaced_step_in_progress): Adjust.
6194         (add_displaced_stepping_state): Remove.
6195         (get_displaced_step_closure_by_addr): Adjust.
6196         (remove_displaced_stepping_state): Remove.
6197         (infrun_inferior_exit): Call displaced_step_state.reset.
6198         (use_displaced_stepping): Don't check for NULL.
6199         (displaced_step_prepare_throw): Call
6200         get_displaced_stepping_state.
6201         (displaced_step_fixup): Don't check for NULL.
6202         (prepare_for_detach): Don't check for NULL.
6203
6204 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6205
6206         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6207          in case of call that did not complete.
6208
6209 2019-01-02  Andrey Utkin  <autkin@undo.io>
6210
6211         * symfile.c (find_separate_debug_file): Fix search of debug files for
6212         remote debuggee.
6213
6214 2019-01-02  Tom Tromey  <tom@tromey.com>
6215
6216         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6217         indentation.
6218         * python/py-frame.c (frapy_older): Remove cast.
6219         (frapy_newer): Likewise.
6220         * python/py-breakpoint.c (local_setattro): Remove cast.
6221         * python/py-arch.c (archpy_name): Remove local variable.
6222         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6223
6224 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6225
6226         * unittests/basic_string_view/element_access/char/empty.cc:
6227         Fix year range in copyright header.
6228
6229 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6230
6231         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6232         Delete.
6233         <operator==>: Update with for removed field.
6234         <hash>: Likewise.
6235         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6236         <isa_features>: ...this.
6237         <abi_features>: New field.
6238         (riscv_isa_flen): Update comment.
6239         (riscv_abi_xlen): New declaration.
6240         (riscv_abi_flen): New declaration.
6241         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6242         isa_features.
6243         (riscv_abi_xlen): New function.
6244         (riscv_isa_flen): Update to get answer from isa_features.
6245         (riscv_abi_flen): New function.
6246         (riscv_has_fp_abi): Update to get answer from abi_features.
6247         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6248         xlen and flen.
6249         (riscv_call_info) <xlen, flen>: Update comment.
6250         (riscv_call_arg_struct): Remove invalid assertions
6251         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6252         is removed.
6253         (riscv_gdbarch_init): Gather isa features and abi features
6254         separately, ensure both match on the gdbarch when reusing an old
6255         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6256         a target with 64-bit float hardware.
6257
6258 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6259
6260         * source.c (search_command_helper): Stop reverse search
6261         when line 1 has been searched.
6262
6263 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6264
6265         * record-full.c (record_full_base_target::close): Rewrite
6266         record_full_core_buf_list free logic.
6267
6268 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6269
6270         * break-catch-syscall.c (print_one_catch_syscall): xfree
6271         the last text.
6272
6273 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6274
6275         * top.c (print_gdb_version): Update Copyright year in version
6276         message.
6277
6278 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6279
6280         Update copyright year range in all GDB files.
6281
6282 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6283
6284         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6285
6286 For older changes see ChangeLog-2018.
6287 \f
6288 Local Variables:
6289 mode: change-log
6290 left-margin: 8
6291 fill-column: 74
6292 version-control: never
6293 coding: utf-8
6294 End:
6295