gdb/ChangeLog

   1 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * top.h (saved_command_line): Remove declaration.
   4         * top.c (previous_saved_command_line, previous_repeat_arguments):
   5         New variables.
   6         (saved_command_line): Make static, define together with other
   7         'repeat variables'.
   8         (dont_repeat): Clear repeat_arguments.
   9         (repeat_previous, get_saved_command_line, save_command_line):
  10         New functions.
  11         (gdb_init): Initialize saved_command_line
  12         and previous_saved_command_line.
  13         * main.c (captured_main_1): Remove saved_command_line initialization.
  14         * event-top.c (handle_line_of_input): Update to use
  15         the new 'repeat' related functions instead of direct access to
  16         saved_command_line.
  17         * command.h (repeat_previous, get_saved_command_line,
  18         save_command_line): New declarations.
  19         (dont_repeat): Add comment.
  20
  21 2019-05-30  Tom Tromey  <tromey@adacore.com>
  22
  23         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
  24         Fix comment.
  25         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
  26
  27 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
  28
  29         PR cli/24587
  30         * completer.c (complete): Initialize variable word.
  31
  32 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
  33
  34         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
  35         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
  36         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
  37         'body' is NULL to the outter 'if', protecting the '!is_define'
  38         situation as well.
  39
  40 2019-05-29  Tom Tromey  <tromey@adacore.com>
  41
  42         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
  43         (dwarf_unknown): New function.
  44         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
  45         (dwarf_type_encoding_name): Use dwarf_unknown.
  46
  47 2019-05-29  Tom Tromey  <tromey@adacore.com>
  48
  49         PR c++/20020:
  50         * cp-valprint.c (cp_print_value_fields): Call
  51         cp_print_static_field inside "try".
  52
  53 2019-05-29  Tom Tromey  <tromey@adacore.com>
  54
  55         * inflow.c (struct terminal_info): Add default operator=.
  56         * configure: Rebuild.
  57         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
  58         -Wdeprecated-copy-dtor, -Wredundant-move.
  59
  60 2019-05-29  Tom Tromey  <tromey@adacore.com>
  61
  62         * NEWS: Add entry.
  63         * infcmd.c (print_return_value_1): Handle finish_print
  64         option.
  65         (show_print_finish): New function.
  66         (_initialize_infcmd): Add "set/show print finish" commands.
  67         * valprint.c (user_print_options): Initialize new member.
  68         * valprint.h (struct value_print_options) <finish_print>: New
  69         member.
  70
  71 2019-05-28  Tom Tromey  <tromey@adacore.com>
  72
  73         * ada-lang.c (ada_remove_Xbn_suffix)
  74         (find_old_style_renaming_symbol)
  75         (parse_old_style_renaming): Remove.
  76         (ada_find_renaming_symbol): Don't call
  77         find_old_style_renaming_symbol.
  78         (ada_is_renaming_symbol): Rename from
  79         ada_find_renaming_symbol.  Remove "block" parameter.  Return
  80         bool.  Now static.
  81         (ada_read_var_value): Update and simplify.
  82         * ada-exp.y (write_var_or_type): Remove old code.
  83
  84 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
  85
  86         * event-top.c: Remove include comment.
  87         * inflow.c (class scoped_ignore_sigttou): Move from here...
  88         * inflow.h (class scoped_ignore_sigttou): ...to here.
  89         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
  90         * top.c:  Remove include comment.
  91
  92 2019-05-27  Tom Tromey  <tom@tromey.com>
  93
  94         * NEWS: Fix typo.
  95
  96 2019-05-22  Tom Tromey  <tromey@adacore.com>
  97
  98         * target.c (target_follow_exec): Constify parameter.
  99         * target-delegates.c: Rebuild.
 100         * remote.c (remote_target::follow_exec): Constify parameter.
 101         * infrun.c (follow_exec): Constify parameter.
 102         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 103         (target_follow_exec): Likewise.
 104
 105 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 106
 107         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 108         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 109
 110 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 111
 112         * NEWS: Add debugredirect and testsuite sections.
 113
 114 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 115
 116         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 117         target descriptions using exclusively floating point register name
 118         aliases.
 119
 120 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 121
 122         PR gdb/18644:
 123         * f-lang.c (build_fortran_types): Handle the case where
 124         gdbarch_floatformat_for_type returns a nullptr.
 125
 126 2019-05-21  Tom de Vries  <tdevries@suse.de>
 127
 128         PR cli/24587
 129         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 130
 131 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 132
 133         PR gdb/18644:
 134         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 135         16-byte floats.
 136         * i386-tdep.c (i386_floatformat_for_type): Use
 137         floatformats_ia64_quad for the 16-byte floating point component
 138         within a fortran 32-byte complex number.
 139
 140 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 141
 142         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 143         delete default constructor.
 144         (find_partial_die): Update to return const struct.
 145         (partial_die_parent_scope): Move variable declaration into scope
 146         of its use and change its type to auto.
 147         (guess_partial_die_structure_name): Likewise.
 148         (partial_die_info::fixup): Likewise.
 149
 150 2019-05-17  Tom Tromey  <tromey@adacore.com>
 151
 152         * source.c (find_and_open_source): Remove cast.
 153
 154 2019-05-17  Tom Tromey  <tromey@adacore.com>
 155
 156         * annotate.c (annotate_source): Make "filename" const.
 157         * annotate.h (annotate_source): Use const.
 158
 159 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 160
 161         * disasm.c (set_disassembler_options): Send errors to stderr.
 162
 163 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 164
 165         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 166         (cli_interp_base::set_logging): Check debug_redirect.
 167         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 168         * cli/cli-logging.c (debug_redirect): Add static variable.
 169         (pop_output_files): Add default param.
 170         (handle_redirections): Print debug setting.
 171         (show_logging_command): Likewise.
 172         (_initialize_cli_logging): Add debugredirect command.
 173         * interps.c (current_interp_set_logging): Add debug_redirect
 174         parameter.
 175         * interps.h (set_logging): Add debug_redirect parameter.
 176         (current_interp_set_logging): Likewise.
 177         * mi/mi-common.h: Likewise.
 178         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 179
 180 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 181             Tom Tromey  <tromey@adacore.com>
 182
 183         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 184         directly.
 185         * cli/cli-interp.h (make_logging_output): Remove declaration.
 186         * cli/cli-logging.c (make_logging_output): Remove function.
 187         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 188         directly.
 189         * ui-file.c (tee_file::tee_file): Remove bools.
 190         (tee_file::~tee_file): Remove deletes.
 191         * ui-file.h (tee_file): Remove bools.
 192
 193 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 194
 195         * mi/mi-cmds.h (mi_cmd_complete): New function.
 196         * mi/mi-main.c (mi_cmd_complete): Likewise.
 197         * mi/mi-cmds.c: Define new MI command -complete.
 198         * NEWS: Mention new -complete command.
 199
 200 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 201
 202         * completer.h (complete): New function.
 203         * completer.c (complete): Likewise.
 204         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 205         function defined in completer.h.
 206
 207 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 208
 209        * MAINTAINERS (Write After Approval): Add myself.
 210
 211 2019-05-17  Tom de Vries  <tdevries@suse.de>
 212
 213         PR gdb/24094
 214         * dwarf2read.c (struct cu_partial_die_info): New struct.
 215         (find_partial_die): Return cu_partial_die_info.
 216         (partial_die_parent_scope, guess_partial_die_structure_name)
 217         (partial_die_info::fixup): Handle new return type of find_partial_die.
 218
 219 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 220
 221         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 222         "std::string", simplifying the algorithm.
 223
 224 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 225
 226         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 227         (stap_static_probe_ops::get_probes): Likewise.
 228
 229 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 230
 231         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 232         '-')" and "else if".
 233         (stap_parse_single_operand): Join checks for
 234         "gdbarch_stap_parse_special_token_p" and
 235         "gdbarch_stap_parse_special_token" in the same "if" statement.
 236         Invert check when verifying for operation on register
 237         displacement.
 238
 239 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 240
 241         * stap-probe.c (stap_get_opcode): Update comment.
 242         (stap_get_expected_argument_type): Likewise.
 243         (handle_stap_probe): Likewise.
 244
 245 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 246
 247         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 248         return type to 'bool'.  Adjust comment.  Use 'bool' when
 249         appropriate.
 250         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 251         * stap-probe.c (stap_parse_argument_1): Likewise.
 252         (stap_is_operator): Likewise.
 253         (stap_is_generic_prefix): Likewise.
 254         (stap_is_register_prefix): Likewise.
 255         (stap_is_register_indirection_prefix): Likewise.
 256         (stap_is_integer_prefix): Likewise.
 257         (stap_generic_check_suffix): Likewise.
 258         (stap_check_integer_suffix): Likewise.
 259         (stap_check_register_suffix): Likewise.
 260         (stap_check_register_indirection_suffix): Likewise.
 261         (stap_parse_register_operand): Likewise.
 262         (stap_parse_single_operand): Likewise.
 263         (stap_parse_argument_1): Likewise.
 264         (stap_probe::get_argument_count): Likewise.
 265         (stap_is_operator): Likewise.
 266
 267 2019-05-16  Tom Tromey  <tromey@adacore.com>
 268
 269         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 270         keyword to foreach.
 271
 272 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 273
 274         * linux-thread-db.c (try_thread_db_load_1): Change return type
 275         to bool.
 276         (try_thread_db_load): Likewise.
 277         (try_thread_db_load_from_pdir_1): Likewise.
 278         (try_thread_db_load_from_pdir): Likewise.
 279         (try_thread_db_load_from_sdir): Likewise.
 280         (try_thread_db_load_from_dir): Likewise.
 281         (thread_db_load_search): Likewise.
 282         (has_libpthread): Likewise.
 283         (thread_db_load): Likewise.
 284
 285 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 286
 287         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 288         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 289         NULL, and complain/return if that's the case.
 290
 291 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 292
 293         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 294         (advance, posn, abstract_read_memory): New functions.
 295         [struct mem_read_abstraction]: New struct.
 296         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 297
 298 2019-05-14  Tom Tromey  <tromey@adacore.com>
 299
 300         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 301         value is not lval_memory.
 302
 303 2019-05-14  Tom Tromey  <tromey@adacore.com>
 304
 305         * solib.c (info_sharedlibrary_command): Style the file name.
 306
 307 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 308
 309         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 310         (aarch64_vnv_type): Likewise.
 311         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 312         * common/tdesc.c: Likewise.
 313         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 314         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 315         * features/aarch64-fpu.xml: Add ieee half view.
 316         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 317         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 318         * gdbtypes.h (struct builtin_type): Likewise.
 319         (struct objfile_type): Likewise.
 320
 321 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 322
 323         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 324         typo.
 325         * location.h (string_to_event_location): Likewise.
 326
 327 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 328
 329         GDB 8.3 released.
 330
 331 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 332
 333         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 334         New variable declaration.
 335         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 336         New variable.
 337         (print_one_breakpoint): Use ui_out::test_flags and new global
 338         variable to compute use_fixed_output.
 339         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 340         Remove.
 341         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 342         (mi_multi_location_breakpoint_output_fixed): Remove.
 343         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 344         new variable.
 345         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 346         fix_multi_location_breakpoint_output flag if version >= 3.
 347         * ui-out.h (enum ui_out_flag)
 348         <fix_multi_location_breakpoint_output>: New enumerator.
 349
 350 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 351
 352         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 353
 354 2019-05-10  Tom Tromey  <tromey@adacore.com>
 355
 356         * ada-lang.c (catch_ada_completer): New function.
 357         (_initialize_ada_language): Use it.
 358
 359 2019-05-10  Tom Tromey  <tromey@adacore.com>
 360
 361         * thread.c (print_thread_info): Make "requested_threads" const.
 362         * gdbthread.h (print_thread_info): Make "requested_threads"
 363         const.
 364         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 365         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 366
 367 2019-05-08  Tom Tromey  <tom@tromey.com>
 368
 369         * gdbtypes.c (objfile_type_data): Change type.
 370         (objfile_type, _initialize_gdbtypes): Update.
 371
 372 2019-05-08  Tom Tromey  <tom@tromey.com>
 373
 374         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 375         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 376         (_initialize_dwarf2_frame): Update.
 377
 378 2019-05-08  Tom Tromey  <tom@tromey.com>
 379
 380         * objc-lang.c (objc_objfile_data): Change type.
 381         (find_methods): Update.
 382         (_initialize_objc_lang): Remove.
 383
 384 2019-05-08  Tom Tromey  <tom@tromey.com>
 385
 386         * stabsread.c (rs6000_builtin_type_data): Change type.
 387         (rs6000_builtin_type, _initialize_stabsread): Update.
 388
 389 2019-05-08  Tom Tromey  <tom@tromey.com>
 390
 391         * mips-tdep.c (mips_pdr_data): Remove.
 392         (_initialize_mips_tdep): Update.
 393
 394 2019-05-08  Tom Tromey  <tom@tromey.com>
 395
 396         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 397         (hppa_init_objfile_priv_data, read_unwind_info)
 398         (find_unwind_entry, _initialize_hppa_tdep): Update.
 399
 400 2019-05-08  Tom Tromey  <tom@tromey.com>
 401
 402         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 403         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 404         on obstack.
 405         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 406
 407 2019-05-08  Tom Tromey  <tom@tromey.com>
 408
 409         * mdebugread.c (basic_type_data): Change type.
 410         (basic_type, _initialize_mdebugread): Update.
 411
 412 2019-05-08  Tom Tromey  <tom@tromey.com>
 413
 414         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 415
 416 2019-05-08  Tom Tromey  <tom@tromey.com>
 417
 418         * nto-tdep.c (nto_inferior_data_reg): Change type.
 419         (nto_inferior_data): Update.
 420         (nto_inferior_data_cleanup, nto_new_inferior_data)
 421         (_initialize_nto_tdep): Remove.
 422         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 423
 424 2019-05-08  Tom Tromey  <tom@tromey.com>
 425
 426         * ada-lang.c (struct ada_inferior_data): Add initializers.
 427         (ada_inferior_data): Change type.
 428         (ada_inferior_data_cleanup): Remove.
 429         (get_ada_inferior_data, ada_inferior_exit)
 430         (struct ada_pspace_data): Add initializers, destructor.
 431         (ada_pspace_data_handle): Change type.
 432         (get_ada_pspace_data): Update.
 433         (ada_pspace_data_cleanup): Remove.
 434
 435 2019-05-08  Tom Tromey  <tom@tromey.com>
 436
 437         * coffread.c (struct coff_symfile_info): Add initializers.
 438         (coff_objfile_data_key): Move lower.  Change type.
 439         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 440         Update.
 441         (coff_free_info): Remove.
 442
 443 2019-05-08  Tom Tromey  <tom@tromey.com>
 444
 445         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 446         (fbsd_pspace_data_handle): Move lower.  Change type.
 447         (get_fbsd_pspace_data): Update.
 448         (fbsd_pspace_data_cleanup): Remove.
 449         (_initialize_fbsd_tdep): Update.
 450
 451 2019-05-08  Tom Tromey  <tom@tromey.com>
 452
 453         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 454         (get_ada_tasks_pspace_data): Update.
 455         (ada_tasks_pspace_data_cleanup): Remove.
 456         (_initialize_tasks): Update.
 457         (ada_tasks_inferior_data_handle): Change type.
 458         (get_ada_tasks_inferior_data): Update.
 459         (ada_tasks_inferior_data_cleanup): Remove.
 460         (struct ada_tasks_pspace_data): Add initializers.
 461
 462 2019-05-08  Tom Tromey  <tom@tromey.com>
 463
 464         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 465         * symfile-debug.c (debug_sym_get_probes): Change type.
 466         * stap-probe.c (handle_stap_probe):
 467         (stap_static_probe_ops::get_probes): Change type.
 468         * probe.h (class static_probe_ops) <get_probes>: Change type.
 469         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 470         (parse_probes_in_pspace): Update.
 471         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 472         Update.
 473         (any_static_probe_ops::get_probes): Change type.
 474         * elfread.c (elfread_data): New typedef.
 475         (probe_key): Change type.
 476         (elf_get_probes): Likewise.  Update.
 477         (probe_key_free): Remove.
 478         (_initialize_elfread): Update.
 479         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 480         Change type.
 481         (dtrace_process_dof_probe, dtrace_process_dof)
 482         (dtrace_static_probe_ops::get_probe): Change type.
 483
 484 2019-05-08  Tom Tromey  <tom@tromey.com>
 485
 486         * xcoffread.c (struct xcoff_symfile_info): Rename from
 487         coff_symfile_info.  Add initializers.
 488         (xcoff_objfile_data_key): Move lower.  Change type.
 489         (XCOFF_DATA): Rewrite.
 490         (xcoff_free_info): Remove.
 491         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 492         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 493         (xcoff_initial_scan): Update.
 494
 495 2019-05-08  Tom Tromey  <tom@tromey.com>
 496
 497         * solib-svr4.c (struct svr4_info): Add initializers and
 498         destructor.
 499         <probes_table>: Now an htab_up.
 500         (solib_svr4_pspace_data): Change type.
 501         (free_probes_table): Simplify.
 502         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 503         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 504         (probes_table_remove_objfile_probes, register_solib_event_probe)
 505         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 506         (_initialize_svr4_solib): Update.
 507
 508 2019-05-08  Tom Tromey  <tom@tromey.com>
 509
 510         * remote.c (remote_pspace_data): Change type.
 511         (remote_pspace_data_cleanup): Remove.
 512         (get_remote_exec_file, set_pspace_remote_exec_file)
 513         (_initialize_remote): Update.
 514
 515 2019-05-08  Tom Tromey  <tom@tromey.com>
 516
 517         * breakpoint.c (breakpoint_objfile_key): Change type.
 518         (get_breakpoint_objfile_data): Update.
 519         (free_breakpoint_objfile_data): Remove.
 520         (_initialize_breakpoint): Update.
 521
 522 2019-05-08  Tom Tromey  <tom@tromey.com>
 523
 524         * linux-tdep.c (struct linux_info): Add initializers.
 525         (linux_inferior_data): Move.  Change type.
 526         (invalidate_linux_cache_inf): Update.
 527         (linux_inferior_data_cleanup): Remove.
 528         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 529
 530 2019-05-08  Tom Tromey  <tom@tromey.com>
 531
 532         * auxv.c (auxv_inferior_data): Move.  Change type.
 533         (auxv_inferior_data_cleanup): Remove.
 534         (invalidate_auxv_cache_inf): Rewrite.
 535         (get_auxv_inferior_data, _initialize_auxv): Update.
 536
 537 2019-05-08  Tom Tromey  <tom@tromey.com>
 538
 539         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 540         (symfile_debug_objfile_data_key): Change type.
 541         (symfile_debug_installed, debug_qf_has_symbols)
 542         (debug_qf_find_last_source_symtab)
 543         (debug_qf_forget_cached_source_info)
 544         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 545         (debug_qf_print_stats, debug_qf_dump)
 546         (debug_qf_expand_symtabs_for_function)
 547         (debug_qf_expand_all_symtabs)
 548         (debug_qf_expand_symtabs_with_fullname)
 549         (debug_qf_map_matching_symbols)
 550         (debug_qf_expand_symtabs_matching)
 551         (debug_qf_find_pc_sect_compunit_symtab)
 552         (debug_qf_map_symbol_filenames)
 553         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 554         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 555         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 556         (debug_sym_read_linetable, debug_sym_relocate): Update.
 557         (symfile_debug_free_objfile): Remove.
 558         (install_symfile_debug_logging, _initialize_symfile_debug):
 559         Update.
 560
 561 2019-05-08  Tom Tromey  <tom@tromey.com>
 562
 563         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 564         allocate_on_obstack.
 565         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 566         (get_dwarf2_per_objfile): Update.
 567         (set_dwarf2_per_objfile): Remove.
 568         (dwarf2_has_info, dwarf2_get_section_info): Update.
 569         (dwarf2_free_objfile): Remove.
 570         (_initialize_dwarf2_read): Update.
 571
 572 2019-05-08  Tom Tromey  <tom@tromey.com>
 573
 574         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 575         initializers.
 576         <unsupported_script_warning_printed,
 577         script_not_found_warning_printed>: Now bool.
 578         (auto_load_pspace_data): Change type.
 579         (~auto_load_pspace_info): Rename from
 580         auto_load_pspace_data_cleanup.
 581         (get_auto_load_pspace_data, init_loaded_scripts_info)
 582         (clear_section_scripts, maybe_print_unsupported_script_warning)
 583         (maybe_print_script_not_found_warning, _initialize_auto_load):
 584         Update.
 585
 586 2019-05-08  Tom Tromey  <tom@tromey.com>
 587
 588         * objfiles.c (objfile_pspace_info): Add destructor and
 589         initializers.
 590         (objfiles_pspace_data): Change type.
 591         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 592         (get_objfile_pspace_data): Update.
 593         (objfiles_bfd_data): Change type.
 594         (get_objfile_bfd_data): Update.
 595         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 596
 597 2019-05-08  Tom Tromey  <tom@tromey.com>
 598
 599         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 600         Change type.
 601         (get_catch_syscall_inferior_data): Update.
 602         (catch_syscall_inferior_data_cleanup): Remove.
 603         (_initialize_break_catch_syscall): Update.
 604
 605 2019-05-08  Tom Tromey  <tom@tromey.com>
 606
 607         * inflow.c (struct terminal_info): Add destructor and
 608         initializers.
 609         (inflow_inferior_data): Change type.
 610         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 611         (get_inflow_inferior_data, inflow_inferior_exit)
 612         (swap_terminal_info, _initialize_inflow): Update.
 613
 614 2019-05-08  Tom Tromey  <tom@tromey.com>
 615
 616         * target-dcache.c (target_dcache_cleanup): Remove.
 617         (target_dcache_aspace_key): Change type.
 618         (target_dcache_init_p, target_dcache_invalidate)
 619         (target_dcache_get, target_dcache_get_or_init)
 620         (_initialize_target_dcache): Update.
 621         * dcache.h (struct dcache_deleter): New.
 622
 623 2019-05-08  Tom Tromey  <tom@tromey.com>
 624
 625         * symtab.c (struct symbol_cache): Add destructor and
 626         initializers.
 627         (symbol_cache_key): Move.  Change type.
 628         (make_symbol_cache, free_symbol_cache): Remove.
 629         (get_symbol_cache): Update.
 630         (symbol_cache_cleanup): Remove.
 631         (ALL_PSPACES, symbol_cache_flush)
 632         (maintenance_print_symbol_cache)
 633         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 634         Update.
 635
 636 2019-05-08  Tom Tromey  <tom@tromey.com>
 637
 638         * symtab.c (struct main_info): Add destructor and initializers.
 639         (main_progspace_key): Move.  Change type.
 640         (get_main_info): Update.
 641         (main_info_cleanup): Remove.
 642         (_initialize_symtab): Update.
 643
 644 2019-05-08  Tom Tromey  <tom@tromey.com>
 645
 646         * registry.h (DECLARE_REGISTRY): Define the _key class.
 647
 648 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 649
 650         * NEWS: Merge two 'New commands' sections.
 651
 652 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 653
 654         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 655         parameter and use Ada language definition instead.
 656         (ada_val_print_ptr): Remove unused language parameter.
 657         (ada_val_print_num): Remove language parameter and use Ada language
 658         definition instead.
 659         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 660         parameter.
 661         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 662         parameter and use Ada language definition instead.
 663         (ada_val_print_1): Update all ada_val_print_xxx calls.
 664         Remove language parameter.
 665         (ada_val_print): Update ada_val_print_1 call.
 666
 667 2019-05-08  Tom Tromey  <tromey@adacore.com>
 668
 669         * remote.c (remote_hw_watchpoint_limit)
 670         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 671         Now static.
 672
 673 2019-05-08  Tom Tromey  <tromey@adacore.com>
 674
 675         * maint.c (_initialize_maint_cmds): Move initialization code to
 676         remote.c.
 677         (watchdog, show_watchdog): Move to remote.c.
 678         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 679         "watchdog" static.
 680         (_initialize_remote): Move initialization code from maint.c.
 681         * defs.h (watchdog): Don't declare.
 682
 683 2019-05-08  Tom Tromey  <tromey@adacore.com>
 684
 685         * tui/tui-interp.c: Include main.h.
 686         * interps.c: Include main.h.
 687         * main.h (interpreter_p): Declare.
 688         * defs.h (interpreter_p): Don't declare.
 689
 690 2019-05-08  Tom Tromey  <tromey@adacore.com>
 691
 692         * dwarf2loc.c: Include dwarf2read.h.
 693         * defs.h (read_unsigned_leb128): Don't declare.
 694         * dwarf2read.h (read_unsigned_leb128): Declare.
 695
 696 2019-05-08  Tom Tromey  <tromey@adacore.com>
 697
 698         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 699         method.
 700
 701 2019-05-08  Tom Tromey  <tromey@adacore.com>
 702
 703         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 704         when no wrap column is set.
 705
 706 2019-05-08  Tom Tromey  <tromey@adacore.com>
 707
 708         * c-lang.c (c_get_string): Handle non-C-style arrays.
 709
 710 2019-05-08  Tom Tromey  <tromey@adacore.com>
 711
 712         * typeprint.c (print_offset_data::update): Print the bit offset,
 713         not the number of bits remaining.
 714
 715 2019-05-08  Tom Tromey  <tromey@adacore.com>
 716
 717         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 718         padding at end of comment.
 719
 720 2019-05-08  Tom Tromey  <tromey@adacore.com>
 721
 722         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 723         Compare main types.
 724
 725 2019-05-06  Tom Tromey  <tom@tromey.com>
 726
 727         * common/scoped_mmap.c: Include common-defs.h.
 728         * common/scoped_mmap.h: Don't include config.h.
 729
 730 2019-05-04  Tom Tromey  <tom@tromey.com>
 731
 732         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 733         (struct aarch64_call_info): Add initializers.
 734         <si>: Now a std::vector.
 735         (pass_on_stack, aarch64_push_dummy_call): Update.
 736
 737 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 738             Tom Tromey  <tom@tromey.com>
 739
 740         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 741         (ppc_threads): Now a std::vector.  Now static.
 742         (hwdebug_find_thread_points_by_tid)
 743         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 744         Update.
 745
 746 2019-05-04  Tom Tromey  <tom@tromey.com>
 747
 748         * arc-tdep.c (arc_tdesc_init): Return bool.
 749
 750 2019-05-04  Tom Tromey  <tom@tromey.com>
 751
 752         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 753         Use gdb_assert_not_reached.
 754
 755 2019-05-04  Tom Tromey  <tom@tromey.com>
 756
 757         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 758         "false".
 759
 760 2019-05-04  Tom Tromey  <tom@tromey.com>
 761
 762         * arc-tdep.c (arc_tdesc_init): Use bool.
 763
 764 2019-05-04  Tom Tromey  <tom@tromey.com>
 765
 766         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 767
 768 2019-05-04  Tom Tromey  <tom@tromey.com>
 769
 770         * cli/cli-cmds.c (valid_command_p): Return bool.
 771
 772 2019-05-04  Tom Tromey  <tom@tromey.com>
 773
 774         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 775         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 776
 777 2019-05-04  Raul Tambre  <raul@tambre.ee>
 778
 779         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 780         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 781         operator for comparison.
 782
 783 2019-05-04  Tom Tromey  <tom@tromey.com>
 784
 785         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 786         (lookup_partial_symbol, print_partial_symbols)
 787         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 788         (psymbol_compare): Update.
 789         (add_psymbol_to_bcache): Clear the entire psymbol.
 790         (maintenance_check_psymtabs): Update.
 791         * psympriv.h (struct partial_symbol): Don't derive from
 792         general_symbol_info.
 793         <obj_section, unrelocated_address, address,
 794         set_unrelocated_address>: Update.
 795         <ginfo>: New member.
 796         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 797         (debug_names::write_psymbols): Update.
 798
 799 2019-05-04  Tom de Vries  <tdevries@suse.de>
 800
 801         * contrib/cc-with-tweaks.sh: Support -n arg.
 802
 803 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 804
 805         * corelow.c (core_target::detach): Ensure frame cache and
 806         register caches are cleared.
 807         inferior.c (exit_inferior_1): Likewise.
 808
 809 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 810             Tom Tromey  <tom@tromey.com>
 811
 812         * dictionary.c (collate_pending_symbols_by_language): Remove
 813         "struct" from foreach.
 814         * symtab.c (lookup_global_symbol_from_objfile)
 815         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 816         foreach.
 817         * ser-tcp.c (net_open): Remove "struct" from foreach.
 818         * objfiles.c (objfile_relocate, objfile_rebase)
 819         (objfile_has_symbols): Remove "struct" from foreach.
 820         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 821         from foreach.
 822         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 823         foreach.
 824         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 825         "struct" from foreach.
 826         * ada-lang.c (create_excep_cond_exprs)
 827         (ada_exception_catchpoint_cond_string): Remove "struct" from
 828         foreach.
 829
 830 2019-05-03  Tom Tromey  <tromey@adacore.com>
 831
 832         * ada-exp.y (convert_char_literal): Check suffix of each
 833         enumerator.
 834
 835 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 836
 837         PR ada/21406:
 838         * ada-exp.y (yywrap): Don't define.
 839         * ada-lex.l (%option): Add noyywrap
 840         (yywrap): Remove.
 841
 842 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 843
 844         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 845         _WIN32_WINNT to the XP level, unless already defined to a higher
 846         level.
 847
 848         * unittests/parse-connection-spec-selftests.c:
 849         * ser-tcp.c:
 850         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 851         override.
 852
 853         * symfile.c (find_separate_debug_file): Remove colon from the
 854         drive spec of DOS/Windows file names of the target, so that the
 855         file name produced from DEBUGDIR and the target's directory will
 856         be valid on DOS/Windows systems.
 857
 858 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 859
 860         * rust-lang.c (val_print_struct): Handle printing structures
 861         containing strings.
 862
 863 2019-05-02  Tom Tromey  <tromey@adacore.com>
 864
 865         * valarith.c (_initialize_valarith): Remove.
 866
 867 2019-05-01  Tom Tromey  <tromey@adacore.com>
 868
 869         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 870         bitfields.
 871
 872 2019-05-01  Tom Tromey  <tromey@adacore.com>
 873
 874         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 875         for big-endian copies.
 876
 877 2019-04-30  Ali Tamur  <tamur@google.com>
 878         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 879         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 880         (read_3_bytes): New function.
 881
 882 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 883
 884         * windows-nat.c (main_thread_id): Delete.
 885         (handle_output_debug_string): Replace main_thread_id by
 886         current_event.dwThreadId.
 887         (fake_create_process): Likewise.
 888         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 889         Do not set main_thread_id.
 890         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 891         current_event.dwThreadId.
 892         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 893
 894 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 895
 896         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 897         Use current_event.dwThreadId instead of main_thread_id.
 898
 899 2019-04-30  Tom Tromey  <tromey@adacore.com>
 900
 901         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 902         (create_excep_cond_exprs): Iterate over program spaces.
 903         (ada_exception_catchpoint_cond_string): Examine all minimal
 904         symbols for exception types.
 905
 906 2019-04-30  Tom Tromey  <tromey@adacore.com>
 907
 908         PR c++/24470:
 909         * dwarf2read.c (process_structure_scope): Handle case where type
 910         has template parameters but no symbol was created.
 911
 912 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 913             Chris January  <chris.january@arm.com>
 914
 915         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 916         qualifier.
 917         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 918
 919 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 920
 921         * f-typeprint.c (f_print_type): Update rules for printing
 922         whitespace.
 923         (f_type_print_varspec_suffix): Likewise.
 924
 925 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 926             Chris January  <chris.january@arm.com>
 927
 928         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 929         function arguments.
 930
 931 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * f-lang.c (build_fortran_types): Change name of void type to
 934         lower case.
 935         * f-typeprint.c (f_type_print_base): Print the name of the void
 936         type, rather than a fixed string.
 937         * f-valprint.c (f_decorations): Use lower case void string.
 938
 939 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 940             Chris January  <chris.january@arm.com>
 941
 942         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 943         types for Fortran.
 944
 945 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 946             Chris January  <chris.january@arm.com>
 947             David Lecomber  <david.lecomber@arm.com>
 948
 949         * f-exp.y (BINOP_INTRINSIC): New token.
 950         (exp): New parser rule handling BINOP_INTRINSIC.
 951         (f77_keywords): Add new builtin procedures.
 952         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 953         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 954         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 955         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 956         (print_unop_subexp_f): New function.
 957         (print_binop_subexp_f): New function.
 958         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 959         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 960         (dump_subexp_body_f): Likewise.
 961         (operator_check_f): Likewise.
 962         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 963         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 964
 965 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 968         UNOP_KIND.
 969         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 970         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 971         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 972         (operator_length_f): New fuction.
 973         (print_subexp_f): New function.
 974         (op_name_f): New function.
 975         (dump_subexp_body_f): New function.
 976         (operator_check_f): New function.
 977         (exp_descriptor_f): Replace standard expression handling functions
 978         with new functions.
 979         * gdb/fortran-operator.def: New file.
 980         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 981         * gdb/std-operator.def: Remove UNOP_KIND.
 982
 983 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * std-operator.def: Remove unbalanced, stray double quote
 986         character.
 987
 988 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 989             Chris January  <chris.january@arm.com>
 990             Daniel Everett  <daniel.everett@arm.com>
 991             Nick Forrington  <nick.forrington@arm.com>
 992             Richard Bunt  <richard.bunt@arm.com>
 993
 994         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 995         of depth when printing anonymous structs or unions.
 996         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 997         Don't print either the top-level value, or the children if the
 998         max-depth is exceeded.
 999         (ppscm_print_children): When printing the key of a map, allow one
1000         extra level of depth.
1001         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1002         print either the top-level value, or the children if the max-depth
1003         is exceeded.
1004         (print_children): When printing the key of a map, allow one extra
1005         level of depth.
1006         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1007         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1008         (user_print_options): Initialise max_depth field.
1009         (val_print_scalar_or_string_type_p): New function.
1010         (val_print): Check to see if the max depth has been reached.
1011         (val_print_check_max_depth): Define new function.
1012         (show_print_max_depth): New function.
1013         (_initialize_valprint): Add 'print max-depth' option.
1014         * valprint.h (struct value_print_options) <max_depth>: New field.
1015         (val_print_check_max_depth): Declare new function.
1016         * NEWS: Document new feature.
1017
1018 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * ada-lang.c (ada_language_defn): Initialise new field.
1021         * c-lang.c (c_is_string_type_p): New function.
1022         (c_language_defn): Initialise new field.
1023         (cplus_language_defn): Initialise new field.
1024         (asm_language_defn): Initialise new field.
1025         (minimal_language_defn): Initialise new field.
1026         * c-lang.h (c_is_string_type_p): Declare new function.
1027         * d-lang.c (d_language_defn): Initialise new field.
1028         * f-lang.c (f_is_string_type_p): New function.
1029         (f_language_defn): Initialise new field.
1030         * go-lang.c (go_is_string_type_p): New function.
1031         (go_language_defn): Initialise new field.
1032         * language.c (default_is_string_type_p): New function.
1033         (unknown_language_defn): Initialise new field.
1034         (auto_language_defn): Initialise new field.
1035         * language.h (struct language_defn) <la_is_string_type_p>: New
1036         member variable.
1037         (default_is_string_type_p): Declare new function.
1038         * m2-lang.c (m2_language_defn): Initialise new field.
1039         * objc-lang.c (objc_language_defn): Initialise new field.
1040         * opencl-lang.c (opencl_language_defn): Initialise new field.
1041         * p-lang.c (pascal_is_string_type_p): New function.
1042         (pascal_language_defn): Initialise new field.
1043         * rust-lang.c (rust_is_string_type_p): New function.
1044         (rust_language_defn): Initialise new field.
1045
1046 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1049         New field.
1050         * ada-lang.c (ada_language_defn): Initialise new field.
1051         * c-lang.c (c_language_defn): Likewise.
1052         (cplus_language_defn): Likewise.
1053         (asm_language_defn): Likewise.
1054         (minimal_language_defn): Likewise.
1055         * d-lang.c (d_language_defn): Likewise.
1056         * f-lang.c (f_language_defn): Likewise.
1057         * go-lang.c (go_language_defn): Likewise.
1058         * language.c (unknown_language_defn): Likewise.
1059         (auto_language_defn): Likewise.
1060         * m2-lang.c (m2_language_defn): Likewise.
1061         * objc-lang.c (objc_language_defn): Likewise.
1062         * opencl-lang.c (opencl_language_defn): Likewise.
1063         * p-lang.c (pascal_language_defn): Likewise.
1064         * rust-lang.c (rust_language_defn): Likewise.
1065
1066 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         * ada-lang.c (ada_is_character_type): Change return type to bool.
1069         (ada_is_string_type): Likewise.
1070         * ada-lang.h (ada_is_character_type): Update declaration
1071         (ada_is_string_type): Likewise.
1072
1073 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1074
1075         Support style in 'frame|thread apply'
1076
1077         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1078         * record.c (record_start, record_stop): Update callers of
1079         execute_command_to_string with false.
1080         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1081         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1082         methods.
1083         (class string_file): New constructor with term_out parameter.
1084         Override methods term_out and can_emit_style_escape.  New member
1085         term_out.
1086         (class stdio_file): Override can_emit_style_escape.
1087         (class tee_file): Override term_out and can_emit_style_escape.
1088         * utils.h (can_emit_style_escape): Remove.
1089         * utils.c (can_emit_style_escape): Likewise.
1090         Update all callers of can_emit_style_escape (SOMESTREAM) to
1091         SOMESTREAM->can_emit_style_escape.
1092         * source-cache.c (source_cache::get_source_lines): Likewise.
1093         * stack.c (frame_apply_command_count): Call execute_command_to_string
1094         passing the term_out characteristic of the current gdb_stdout.
1095         * thread.c (thr_try_catch_cmd): Likewise.
1096         * top.c (execute_command_to_string): pass term_out parameter
1097         to construct the string_file for the command output.
1098         * ui-file.c (term_cli_styling): New function (most code moved
1099         from utils.c can_emit_style_escape).
1100         (string_file::string_file, string_file::can_emit_style_escape,
1101         stdio_file::can_emit_style_escape, tee_file::term_out,
1102         tee_file::can_emit_style_escape): New functions.
1103
1104 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1105
1106         * NEWS: Mention the new set|show may-call-functions.
1107         * infcall.c (may_call_functions_p): New variable.
1108         (show_may_call_functions_p): New function.
1109         (call_function_by_hand_dummy): Throws an error if not
1110         may-call-functions.
1111         (_initialize_infcall): Call add_setshow_boolean_cmd for
1112         may-call-functions.
1113
1114 2019-04-25  Keith Seitz  <keiths@redhat.com>
1115
1116         PR c++/24367
1117         * cp-support.c (inspect_type): Don't attempt substitutions
1118         of symbol with the same name.
1119
1120 2019-04-25  Tom Tromey  <tromey@adacore.com>
1121
1122         PR gdb/24475:
1123         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1124         static.
1125
1126 2019-04-25  Tom Tromey  <tromey@adacore.com>
1127
1128         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1129         rvalue reference.
1130         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1131         (gdb_xml_parser::parse): Use std::move.
1132         * python/python-internal.h (gdbpy_convert_exception): Take a const
1133         reference.
1134         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1135         std::move.
1136         * python/py-utils.c (gdbpy_convert_exception): Take a const
1137         reference.
1138         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1139         Use std::move.
1140         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1141         Use std::move.
1142         * mi/mi-main.c (mi_print_exception): Take a const reference.
1143         * main.c (handle_command_errors): Take a const reference.
1144         * linespec.c (parse_linespec): Use std::move.
1145         * infcall.c (run_inferior_call): Use std::move.
1146         (call_function_by_hand_dummy): Use std::move.
1147         * exec.c (try_open_exec_file): Use std::move.
1148         * exceptions.h (exception_print, exception_fprintf)
1149         (exception_print_same): Update.
1150         * exceptions.c (print_exception, exception_print)
1151         (exception_fprintf, exception_print_same): Change parameters to
1152         const reference.
1153         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1154         * common/new-op.c: Use std::move.
1155         * common/common-exceptions.h (struct gdb_exception): Add move
1156         constructor.
1157         (struct gdb_exception_error, struct gdb_exception_quit, struct
1158         gdb_quit_bad_alloc): Change constructor to move constructor.
1159         (throw_exception): Change parameter to rvalue reference.
1160         * common/common-exceptions.c (throw_exception): Take rvalue
1161         reference.
1162         * cli/cli-interp.c (safe_execute_command): Use std::move.
1163         * breakpoint.c (insert_bp_location, location_to_sals): Use
1164         std::move.
1165
1166 2019-04-25  Tom Tromey  <tromey@adacore.com>
1167
1168         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1169         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1170         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1171         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1172         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1173         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1174         guile/scm-value.c: Use unpack.
1175         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1176         gdbscm_gdb_exception.
1177         (gdbscm_throw_gdb_exception): Likewise.
1178         (struct gdbscm_gdb_exception): New.
1179         (unpack): New function.
1180         (gdbscm_wrap): Use unpack.
1181
1182 2019-04-25  Tom Tromey  <tromey@adacore.com>
1183
1184         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1185         (gdb_rl_callback_handler): Use std::move.
1186         * common/common-exceptions.h (struct gdb_exception): Add move
1187         assignment operator.
1188         (throw_exception_sjlj): Change "exception" to const reference.
1189         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1190         (throw_exception_sjlj): Change "exception" to const reference.
1191
1192 2019-04-25  Tom Tromey  <tromey@adacore.com>
1193
1194         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1195         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1196         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1197         Update.
1198         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1199         Update.
1200         * mi/mi-interp.c (mi_interp::exec): Update.
1201         * linespec.c (parse_linespec): Update.
1202         * infcall.c (run_inferior_call): Update.
1203         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1204         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1205         (gdbscm_lookup_global_symbol): Update.
1206         * guile/scm-param.c (gdbscm_parameter_value): Update.
1207         * guile/scm-frame.c (gdbscm_frame_read_register)
1208         (gdbscm_frame_read_var): Update.
1209         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1210         * exec.c (try_open_exec_file): Update.
1211         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1212         (gdb_rl_callback_handler): Update.
1213         * common/common-exceptions.h (exception_none): Don't declare.
1214         * common/common-exceptions.c (exception_none): Don't define.
1215         (struct catcher) <exception>: Update.
1216         * cli/cli-interp.c (safe_execute_command): Update.
1217         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1218
1219 2019-04-25  Ali Tamur  <tamur@google.com>
1220
1221         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1222         (read_attribute_value): Likewise.
1223         (dwarf2_read_addr_index): Update comment.
1224         (read_str_index): Add DW_FORM_strx.
1225         (dwarf2_string_attr): Likewise.
1226         (dwarf2_const_value_attr): Likewise.
1227         (dump_die_shallow): Likewise.
1228         (dwarf2_fetch_constant_bytes): Likewise.
1229         (skip_form_bytes): Likewise.
1230         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1231
1232 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1233
1234         PR corefiles/11608
1235         PR corefiles/18187
1236         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1237         OFFSET.  Verify if current mapping contains an ELF header.
1238         (linux_find_memory_regions_full): Adjust call to
1239         dump_mapping_p.
1240
1241 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1242             Kang Li <kanglictf@gmail.com>
1243
1244         PR gdb/21600
1245
1246         * dwarf2-frame.c (read_initial_length): Be consistent about using
1247         unsigned representation of length.
1248         (decode_frame_entry_1): Likewise.  Check for wraparound of
1249         end pointer as well as buffer overflow.
1250
1251 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1252
1253         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1254         "vq".
1255
1256 2019-04-24  Tom Tromey  <tromey@adacore.com>
1257
1258         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1259
1260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * s12z-tdep.c (s12z_unwind_pc): Delete.
1263         (s12z_unwind_sp): Delete.
1264         (s12z_gdbarch_init): Don't register deleted functions with
1265         gdbarch.
1266
1267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * rl78-tdep.c (rl78_unwind_sp): Delete.
1270         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1271
1272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1273
1274         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1275         (xstormy16_unwind_pc): Delete.
1276         (xstormy16_dummy_id): Delete.
1277         (xstormy16_gdbarch_init): Don't register deleted functions with
1278         gdbarch.
1279
1280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1281
1282         * vax-tdep.c (vax_unwind_pc): Delete.
1283         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1284
1285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1286
1287         * v850-tdep.c (v850_unwind_sp): Delete.
1288         (v850_unwind_pc): Delete.
1289         (v850_dummy_id): Delete.
1290         (v850_gdbarch_init): Don't register deleted functions with
1291         gdbarch.
1292
1293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1296         (tilegx_unwind_pc): Delete.
1297         (tilegx_unwind_dummy_id): Delete.
1298         (tilegx_gdbarch_init): Don't register deleted functions with
1299         gdbarch.
1300
1301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1304         (tic6x_dummy_id): Delete.
1305         (tic6x_gdbarch_init): Don't register deleted functions with
1306         gdbarch.
1307
1308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * sparc-tdep.c (sparc_unwind_pc): Delete.
1311         (sparc32_gdbarch_init): Don't register deleted function with
1312         gdbarch.
1313
1314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1315
1316         * sh-tdep.c (sh_unwind_sp): Delete.
1317         (sh_unwind_pc): Delete.
1318         (sh_dummy_id): Delete.
1319         (sh_gdbarch_init): Don't register deleted functions with
1320         gdbarch.
1321
1322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * score-tdep.c (score_unwind_sp): Delete.
1325         (score_unwind_pc): Delete.
1326         (score_dummy_id): Delete.
1327         (score_gdbarch_init): Don't register deleted functions with
1328         gdbarch.
1329
1330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1331
1332         * rx-tdep.c (rx_unwind_pc): Delete.
1333         (rx_unwind_sp): Delete.
1334         (rx_dummy_id): Delete.
1335         (rx_gdbarch_init): Don't register deleted functions with
1336         gdbarch.  Update comment.
1337
1338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1341         (rs6000_dummy_id): Delete.
1342         (rs6000_gdbarch_init): Don't register deleted functions with
1343         gdbarch.
1344
1345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * or1k-tdep.c (or1k_dummy_id): Delete.
1348         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1349
1350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * nios2-tdep.c (nios2_dummy_id): Delete.
1353         (nios2_unwind_sp): Delete.
1354         (nios2_gdbarch_init): Don't register deleted functions with
1355         gdbarch.
1356
1357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1358
1359         * nds32-tdep.c (nds32_dummy_id): Delete.
1360         (nds32_unwind_pc): Delete.
1361         (nds32_unwind_sp): Delete.
1362         (nds32_gdbarch_init): Don't register deleted functions with
1363         gdbarch.
1364
1365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1366
1367         * msp430-tdep.c (msp430_unwind_pc): Delete.
1368         (msp430_unwind_sp): Delete.
1369         (msp430_dummy_id): Delete.
1370         (msp430_gdbarch_init): Don't register deleted functions with
1371         gdbarch.
1372
1373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * moxie-tdep.c (moxie_unwind_sp): Delete.
1376         (moxie_unwind_pc): Delete.
1377         (moxie_dummy_id): Delete.
1378         (moxie_gdbarch_init): Don't register deleted functions with
1379         gdbarch.
1380
1381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1382
1383         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1384         (mn10300_unwind_pc): Delete.
1385         (mn10300_unwind_sp): Delete.
1386         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1387         mn10300_unwind_sp.
1388         (mn10300_frame_unwind_init): Don't register deleted functions with
1389         gdbarch.
1390
1391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * mep-tdep.c (mep_unwind_pc): Delete.
1394         (mep_unwind_sp): Delete.
1395         (mep_dummy_id): Delete.
1396         (mep_gdbarch_init): Don't register deleted functions with
1397         gdbarch.
1398
1399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1402         (m68hc11_unwind_sp): Delete.
1403         (m68hc11_gdbarch_init): Don't register deleted functions with
1404         gdbarch.
1405
1406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * m32r-tdep.c (m32r_unwind_sp): Delete.
1409         (m32r_unwind_pc): Delete.
1410         (m32r_dummy_id): Delete.
1411         (m32r_gdbarch_init): Don't register deleted functions with
1412         gdbarch.
1413
1414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1415
1416         * m32c-tdep.c (m32c_unwind_pc): Delete.
1417         (m32c_unwind_sp): Delete.
1418         (m32c_dummy_id): Delete.
1419         (m32c_gdbarch_init): Don't register deleted functions with
1420         gdbarch.
1421
1422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1423
1424         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1425         (lm32_unwind_pc): Delete.
1426         (lm32_dummy_id): Delete.
1427         (lm32_gdbarch_init): Don't register deleted functions with
1428         gdbarch.
1429
1430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1433         (iq2000_unwind_pc): Delete.
1434         (iq2000_dummy_id): Delete.
1435         (iq2000_gdbarch_init): Don't register deleted functions with
1436         gdbarch.
1437
1438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * nds32-tdep.c (nds32_type_align): Delete.
1441         (nds32_push_dummy_call): Use type_align instead.
1442
1443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1444
1445         * arm-tdep.c (arm_type_align): Only handle vector override case.
1446         (arm_push_dummy_call): Use type_align.
1447         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1448
1449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1450
1451         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1452         case.
1453         (pass_on_stack): Use type_align.
1454         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1455         function.
1456
1457 2019-04-23  Tom Tromey  <tromey@adacore.com>
1458
1459         * dwarf2read.c (line_header::file_name_at): Remove unused
1460         overload.
1461
1462 2019-04-23  Tom de Vries  <tdevries@suse.de>
1463
1464         PR gdb/24438
1465         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1466         invocation.
1467
1468
1469 2019-03-27  Ali Tamur  <tamur@google.com>
1470
1471         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1472         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1473         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1474         (dwarf_expr_context::get_addr_index): Likewise
1475         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1476         (symbol_needs_eval_context::get_addr_index): Likewise
1477         (disassemble_dwarf_expression): Add DW_OP_addrx
1478         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1479         (read_cutu_die_from_dwo): Update comment
1480         (skip_one_die): Add DW_FORM_addrx
1481         (read_attribute_value): Likewise
1482         (var_decode_location): Add DW_OP_addrx
1483         (dwarf2_const_value_attr): Add DW_FORM_addrx
1484         (dump_die_shallow): Likewise
1485         (dwarf2_fetch_constant_bytes): Likewise
1486         (decode_locdesc): Add DW_OP_addrx
1487         (skip_form_bytes): Add DW_FORM_addrx
1488
1489 2019-04-22  Ali Tamur  <tamur@google.com>
1490
1491         * MAINTAINERS (Write After Approval): Add self.
1492
1493 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1494
1495         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1496         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1497         (open_symbol_file_object): Likewise.
1498         (svr4_default_sos): Add info parameter.
1499         (svr4_read_so_list): Likewise.
1500         (svr4_current_sos_direct): Adjust functions calls to pass down
1501         info.
1502         (svr4_current_sos_1): Add info parameter.
1503         (svr4_current_sos): Call get_svr4_info, pass info down to
1504         svr4_current_sos_1.
1505         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1506         get_svr4_info.
1507         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1508         get_svr4_info.
1509         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1510         to get_svr4_info.
1511         (probes_table_remove_objfile_probes): Likewise.
1512         (register_solib_event_probe): Add info parameter.
1513         (solist_update_incremental): Pass info parameter down to
1514         svr4_read_so_list.
1515         (disable_probes_interface): Add info parameter.
1516         (svr4_handle_solib_event): Pass current_program_space to
1517         get_svr4_info.  Adjust disable_probes_interface cleanup.
1518         (svr4_create_probe_breakpoints): Add info parameter, pass it
1519         down to register_solib_event_probe.
1520         (svr4_create_solib_event_breakpoints): Add info parameter,
1521         pass it down to svr4_create_probe_breakpoints.
1522         (enable_break): Pass info down to
1523         svr4_create_solib_event_breakpoints.
1524         (svr4_solib_create_inferior_hook): Pass current_program_space to
1525         get_svr4_info.
1526         (svr4_clear_solib): Likewise.
1527
1528 2019-04-22  Pedro Alves  <palves@redhat.com>
1529
1530         * solib-svr4.c (svr4_free_objfile_observer): New.
1531         (probe_and_action::objfile): New field.
1532         (probes_table_htab_remove_objfile_probes)
1533         (probes_table_remove_objfile_probes): New functions.
1534         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1535         in the new probe_and_action.  Don't store the probe in 'lookup'.
1536         (svr4_create_probe_breakpoints): Pass objfile to
1537         register_solib_event_probe.
1538         (_initialize_svr4_solib): Register a free_objfile observer.
1539
1540 2019-04-19  Tom Tromey  <tom@tromey.com>
1541
1542         * common/queue.h: Remove.
1543
1544 2019-04-19  Tom Tromey  <tom@tromey.com>
1545
1546         * event-loop.c: Don't include "common/queue.h".
1547
1548 2019-04-19  Tom Tromey  <tom@tromey.com>
1549
1550         * remote.c (remote_target): Use delete.
1551         * remote-notif.h: Include <list>, not "common/queue.h".
1552         (notif_client_p): Remove typedef.
1553         (remote_notif_state): Add constructor, destructor, initializer.
1554         <notif_queue>: Now a std::list.
1555         (remote_notif_state_xfree): Don't declare.
1556         * remote-notif.c (remote_notif_process, handle_notification)
1557         (remote_notif_state_allocate): Update.
1558         (~remote_notif_state): Rename from remote_notif_state_xfree.
1559
1560 2019-04-19  Tom Tromey  <tom@tromey.com>
1561
1562         * symfile.c (reread_symbols): Update.
1563         * objfiles.c (objfile_register_static_link)
1564         (objfile_lookup_static_link): Update
1565         (~objfile) Don't delete static_links.
1566         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1567
1568 2019-04-19  Tom Tromey  <tom@tromey.com>
1569
1570         * type-stack.h (struct type_stack) <insert>: Constify string.
1571         * type-stack.c (type_stack::insert): Constify string.
1572         * gdbtypes.h (lookup_template_type): Update.
1573         (address_space_name_to_int): Update.
1574         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1575         const.
1576         (lookup_template_type): Make name const.
1577         * c-exp.y: Update rules.
1578         (lex_one_token, classify_name, classify_inner_name)
1579         (c_print_token): Update.
1580         * p-exp.y: Update rules.
1581         (yylex): Update.
1582         * f-exp.y: Update rules.
1583         (yylex): Update.
1584         * d-exp.y: Update rules.
1585         (lex_one_token, classify_name, classify_inner_name): Update.
1586         * parse.c (write_dollar_variable, copy_name): Return std::string.
1587         * parser-defs.h (copy_name): Change return type.
1588         * m2-exp.y: Update rules.
1589         (yylex): Update.
1590         * go-exp.y (lex_one_token): Update.
1591         Update rules.
1592         (classify_unsafe_function, classify_packaged_name)
1593         (classify_name, yylex): Update.
1594
1595 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1596
1597         * configure.ac: add --enable-source-highlight switch.
1598         * configure: Regenerate.
1599         * top.c (print_gdb_version): plumb --enable-source-highlight
1600         status to "show configuration".
1601
1602 2019-04-19  Tom Tromey  <tromey@adacore.com>
1603
1604         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1605         Check ADA_TYPE_P.
1606         (empty_record, ada_template_to_fixed_record_type_1)
1607         (template_to_static_fixed_type)
1608         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1609         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1610         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1611         macros.
1612
1613 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1614
1615         PR symtab/24423:
1616         * source.c (print_source_lines_base): Advance "iter" when a
1617         control character is seen.
1618
1619 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1620
1621         * inferior.h (struct infcall_suspend_state_deleter):
1622         Catch exception in destructor to avoid crash.
1623
1624 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1625
1626         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1627         close to the add_com "shell".
1628
1629 2019-04-18  Tom Tromey  <tromey@adacore.com>
1630
1631         * process-stratum-target.h (class process_stratum_target)
1632         <stratum>: Add "final".
1633
1634 2019-04-17  Tom Tromey  <tromey@adacore.com>
1635
1636         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1637         against nullptr before use.
1638
1639 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1640
1641         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1642
1643 2019-04-17  Jim Wilson  <jimw@sifive.com>
1644             Andrew Burgess  <andrew.burgess@embecosm.com>
1645
1646         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1647         code read might fail, assume 4-byte breakpoint in that case.
1648
1649 2019-04-15  Leszek Swirski  <leszeks@google.com>
1650
1651         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1652         rather than a hand-rolled POD check when checking for forced MEMORY
1653         classification.
1654
1655 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1656
1657         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1658         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1659         function.
1660         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1661         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1662         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1663         declaration.
1664
1665 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1666
1667         * aarch64-linux-nat.c
1668         (aarch64_linux_nat_target::thread_architecture): Add override.
1669         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1670         each VQ.
1671
1672 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1673
1674         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1675
1676 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1677
1678         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1679         target types of size 96-bits, add some additional comments, and
1680         check that the builtin type we found was the correct size.
1681
1682 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1683
1684         * utils.c (prompt_for_continue): Don't restore the styling at the
1685         end, as applied_style has the wrong value.  This fixes styling in
1686         long lists of file names that are interrupted by the "Continue?"
1687         prompt.
1688
1689 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1690
1691         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1692         * c-lang.c (c_language_defn): Likewise.
1693         (cplus_language_defn): Likewise.
1694         (asm_language_defn): Likewise.
1695         (minimal_language_defn): Likewise.
1696         * d-lang.c (d_language_defn): Likewise.
1697         * f-lang.c (f_language_defn): Likewise.
1698         * go-lang.c (go_language_defn): Likewise.
1699         * language.c (unknown_language_defn): Likewise.
1700         (auto_language_defn): Likewise.
1701         * language.h (struct language_defn): Remove la_magic field.
1702         (LANG_MAGIC): Delete.
1703         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1704         * objc-lang.c (objc_language_defn): Likewise.
1705         * opencl-lang.c (opencl_language_defn): Likewise.
1706         * p-lang.c (pascal_language_defn): Likewise.
1707         * rust-lang.c (rust_language_defn): Likewise.
1708
1709 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1710
1711         * riscv-tdep.c (riscv_type_align): New function.
1712         (riscv_type_alignment): Delete.
1713         (riscv_arg_location): Use 'type_align'.
1714         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1715
1716 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1717
1718         * gdbtypes.c (type_align): A struct with no non-static fields also
1719         has alignment of 1.
1720
1721 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1722
1723         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1724         component to 0.
1725         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1726         member.
1727         (riscv_struct_info::analyse): New implementation using new
1728         analyse_inner member function.
1729         (riscv_struct_info::field_offset): New member function.
1730         (riscv_struct_info::m_offsets): New member variable.
1731         (riscv_struct_info::analyse_inner): New private member function,
1732         takes the old implementation of riscv_struct_info::analyse but
1733         extended to track field offsets.
1734         (riscv_call_arg_struct): Update the struct folding special cases
1735         to handle cases where empty C++ structs, which are non-zero
1736         length, are found.
1737         (riscv_arg_location): Initialise the length of each location, a
1738         non-zero length now indicates the location is in use.
1739         (riscv_push_dummy_call): Allow for the first location having a
1740         non-zero offset when setting up arguments.
1741         (riscv_return_value): Likewise, but for return values.
1742
1743 2019-04-11  Tom Tromey  <tromey@adacore.com>
1744
1745         * utils.c (internal_vproblem): Make "msg" const.
1746
1747 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1748
1749         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1750         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1751         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1752         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1753
1754 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1755
1756         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1757         function.
1758         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1759         of amd64_collect_native_gregset.
1760         (amd64_linux_nat_target::store_registers): Likewise.
1761
1762 2019-04-10  Tom Tromey  <tom@tromey.com>
1763
1764         * symtab.c (lookup_global_symbol_from_objfile)
1765         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1766         * objfiles.h (class separate_debug_iterator): New.
1767         (class separate_debug_range): New.
1768         (struct objfile) <separate_debug_objfiles>: New method.
1769         (objfile_separate_debug_iterate): Don't declare.
1770         * objfiles.c (separate_debug_iterator::operator++): Rename from
1771         objfile_separate_debug_iterate.
1772         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1773         iterator.
1774         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1775         iterator.
1776
1777 2019-04-10  Tom Tromey  <tom@tromey.com>
1778
1779         * symfile.c (reread_symbols): Remove old comment.
1780         * objfiles.c (free_all_objfiles): Fix a typo.
1781
1782 2019-04-10  Tom Tromey  <tom@tromey.com>
1783
1784         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1785         * minsyms.c (lookup_minimal_symbol): Use foreach.
1786         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1787         (lookup_minimal_symbol_solib_trampoline): Likewise.
1788         * symfile.c (reread_symbols): Use foreach.
1789
1790 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1791             Tom Tromey  <tromey@adacore.com>
1792
1793         PR rust/24414:
1794         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1795         (rust_lex_int_test): Change "value" to be LONGEST.
1796         (rust_lex_tests): Add test for long integer literal.
1797
1798 2019-04-09  Tom Tromey  <tromey@adacore.com>
1799
1800         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1801         to bool.
1802         (extended_remote_target::attach): Update.
1803         (remote_target::remote_notice_new_inferior): Update.
1804         (remote_target::add_current_inferior_and_thread): Update.
1805         * inferior.c (exit_inferior_1): Use "false".
1806         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1807
1808 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1809
1810         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1811         the "start" command.
1812
1813 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1814
1815         * python/py-inferior.c (infpy_thread_from_thread_handle):
1816         Adjust comments to reflect renaming of thread_from_thread_handle
1817         to thread_from_handle.  Adjust keywords.  Fix type error message.
1818         (inferior_object_methods): Add thread_from_handle.  Retain
1819         thread_from_thread_handle, but mark it as deprecated.
1820
1821 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1822
1823         * gdbthread.h (find_thread_by_handle): Revise declaration.
1824         * thread.c (find_thread_by_handle): Likewise.  Adjust
1825         implementation too.
1826         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1827         support for buffer objects as handles.
1828
1829 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1830
1831         * python/py-infthread.c (thpy_thread_handle): New function.
1832         (thread_object_methods): Register thpy_thread_handle.
1833
1834 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1835
1836         * gdbthread.h (thread_to_thread_handle): Declare.
1837         * thread.c (gdbtypes.h): Include.
1838         (thread_to_thread_handle): New function.
1839
1840         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1841         (target_thread_info_to_thread_handle): Declare.
1842         * target.c (target_thread_info_to_thread_handle): New function.
1843         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1844         * target-delegates.c: Regenerate.
1845
1846         * linux-thread-db.c (class thread_db_target): Add method
1847         thread_info_to_thread_handle.
1848         (thread_db_target::thread_info_to_thread_handle): Define.
1849         * remote.c (class remote_target): Add new method
1850         thread_info_to_thread_handle.
1851         (remote_target::thread_info_to_thread_handle): Define.
1852
1853 2019-04-08  Pedro Alves  <palves@redhat.com>
1854
1855         * common/common-exceptions.c (throw_exception): Don't create
1856         named object to throw; throw directly.
1857         (throw_it): Likewise.  Don't initialize gdb_exception::message
1858         here, with new; pass FMT and AP to the ctor instead.
1859         * common/common-exceptions.h: Include <string>.
1860         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1861         const char *, va_list)): New ctor.  Use std::make_shared.
1862         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1863         errors)): Delete.
1864         (gdb_exception_error::gdb_exception_error(enum errors, const char
1865         *, va_list)): New.
1866         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1867         Add assertion.
1868         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1869         errors)): Delete.
1870         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1871         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1872         Add assertion.
1873
1874 2019-04-08  Tom Tromey  <tom@tromey.com>
1875
1876         * valops.c (value_rtti_indirect_type): Replace throw_exception
1877         with throw.
1878         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1879         with throw.
1880         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1881         throw.
1882         * target.c (target_translate_tls_address): Replace throw_exception
1883         with throw.
1884         * stack.c (frame_apply_command_count): Replace throw_exception
1885         with throw.
1886         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1887         throw.
1888         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1889         with throw.
1890         * rs6000-tdep.c (rs6000_frame_cache)
1891         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1892         * remote.c: Replace throw_exception with throw.
1893         * record-full.c (record_full_message, record_full_wait_1)
1894         (record_full_restore): Replace throw_exception with throw.
1895         * record-btrace.c:
1896         (get_thread_current_frame_id, record_btrace_start_replaying)
1897         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1898         (cmd_record_btrace_start): Replace throw_exception with throw.
1899         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1900         throw.
1901         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1902         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1903         * linespec.c:
1904         (find_linespec_symbols): Replace throw_exception with throw.
1905         * infrun.c (displaced_step_prepare, resume): Replace
1906         throw_exception with throw.
1907         * infcmd.c (post_create_inferior): Replace throw_exception with
1908         throw.
1909         * inf-loop.c (inferior_event_handler): Replace throw_exception
1910         with throw.
1911         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1912         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1913         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1914         (get_prev_frame_always, get_frame_pc_if_available)
1915         (get_frame_address_in_block_if_available, get_frame_language):
1916         Replace throw_exception with throw.
1917         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1918         throw_exception with throw.
1919         * eval.c (fetch_subexp_value, evaluate_var_value)
1920         (evaluate_funcall, evaluate_subexp_standard): Replace
1921         throw_exception with throw.
1922         * dwarf2loc.c (call_site_find_chain)
1923         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1924         Replace throw_exception with throw.
1925         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1926         with throw.
1927         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1928         throw.
1929         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1930         * completer.c (complete_line_internal): Replace throw_exception
1931         with throw.
1932         * compile/compile-object-run.c (compile_object_run): Replace
1933         throw_exception with throw.
1934         * cli/cli-script.c (process_next_line): Replace throw_exception
1935         with throw.
1936         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1937         (btrace_enable, btrace_maint_update_pt_packets): Replace
1938         throw_exception with throw.
1939         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1940         throw_exception with throw.
1941         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1942         throw_exception with throw.
1943         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1944         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1945         * aarch64-tdep.c (aarch64_make_prologue_cache)
1946         (aarch64_make_stub_cache): Replace throw_exception with throw.
1947
1948 2019-04-08  Tom Tromey  <tom@tromey.com>
1949
1950         * common/common-exceptions.c (throw_exception): Rename from
1951         throw_exception_cxx.  Remove old copy.  Make argument const.
1952         (throw_it): Create and throw exception objects directly.
1953         * common/common-exceptions.h (throw_exception): Make argument
1954         const.
1955         (struct gdb_exception_error): Add constructor.
1956         (struct gdb_exception_quit): Add constructor.
1957
1958 2019-04-08  Tom Tromey  <tom@tromey.com>
1959
1960         * common/common-exceptions.h (exception_rethrow): Don't declare.
1961         (TRY_SJLJ): Update comment.
1962         (TRY, CATCH, END_CATCH): Remove.
1963         * common/common-exceptions.c (exception_rethrow): Remove.
1964
1965 2019-04-08  Tom Tromey  <tom@tromey.com>
1966
1967         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1968         Remove.
1969         (gdb_exception_error): Rename from
1970         gdb_exception_RETURN_MASK_ERROR.
1971         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1972         (gdb_quit_bad_alloc): Update.
1973         * aarch64-tdep.c: Update.
1974         * ada-lang.c: Update.
1975         * ada-typeprint.c: Update.
1976         * ada-valprint.c: Update.
1977         * amd64-tdep.c: Update.
1978         * arch-utils.c: Update.
1979         * break-catch-throw.c: Update.
1980         * breakpoint.c: Update.
1981         * btrace.c: Update.
1982         * c-varobj.c: Update.
1983         * cli/cli-cmds.c: Update.
1984         * cli/cli-interp.c: Update.
1985         * cli/cli-script.c: Update.
1986         * common/common-exceptions.c: Update.
1987         * common/new-op.c: Update.
1988         * common/selftest.c: Update.
1989         * compile/compile-c-symbols.c: Update.
1990         * compile/compile-cplus-symbols.c: Update.
1991         * compile/compile-object-load.c: Update.
1992         * compile/compile-object-run.c: Update.
1993         * completer.c: Update.
1994         * corelow.c: Update.
1995         * cp-abi.c: Update.
1996         * cp-support.c: Update.
1997         * cp-valprint.c: Update.
1998         * darwin-nat.c: Update.
1999         * disasm-selftests.c: Update.
2000         * dtrace-probe.c: Update.
2001         * dwarf-index-cache.c: Update.
2002         * dwarf-index-write.c: Update.
2003         * dwarf2-frame-tailcall.c: Update.
2004         * dwarf2-frame.c: Update.
2005         * dwarf2loc.c: Update.
2006         * dwarf2read.c: Update.
2007         * eval.c: Update.
2008         * event-loop.c: Update.
2009         * event-top.c: Update.
2010         * exec.c: Update.
2011         * f-valprint.c: Update.
2012         * fbsd-tdep.c: Update.
2013         * frame-unwind.c: Update.
2014         * frame.c: Update.
2015         * gdbtypes.c: Update.
2016         * gnu-v3-abi.c: Update.
2017         * guile/guile-internal.h: Update.
2018         * guile/scm-block.c: Update.
2019         * guile/scm-breakpoint.c: Update.
2020         * guile/scm-cmd.c: Update.
2021         * guile/scm-disasm.c: Update.
2022         * guile/scm-frame.c: Update.
2023         * guile/scm-lazy-string.c: Update.
2024         * guile/scm-math.c: Update.
2025         * guile/scm-param.c: Update.
2026         * guile/scm-ports.c: Update.
2027         * guile/scm-pretty-print.c: Update.
2028         * guile/scm-symbol.c: Update.
2029         * guile/scm-symtab.c: Update.
2030         * guile/scm-type.c: Update.
2031         * guile/scm-value.c: Update.
2032         * i386-linux-tdep.c: Update.
2033         * i386-tdep.c: Update.
2034         * inf-loop.c: Update.
2035         * infcall.c: Update.
2036         * infcmd.c: Update.
2037         * infrun.c: Update.
2038         * jit.c: Update.
2039         * language.c: Update.
2040         * linespec.c: Update.
2041         * linux-fork.c: Update.
2042         * linux-nat.c: Update.
2043         * linux-tdep.c: Update.
2044         * linux-thread-db.c: Update.
2045         * main.c: Update.
2046         * mi/mi-cmd-break.c: Update.
2047         * mi/mi-cmd-stack.c: Update.
2048         * mi/mi-interp.c: Update.
2049         * mi/mi-main.c: Update.
2050         * objc-lang.c: Update.
2051         * p-valprint.c: Update.
2052         * parse.c: Update.
2053         * ppc-linux-tdep.c: Update.
2054         * printcmd.c: Update.
2055         * python/py-arch.c: Update.
2056         * python/py-breakpoint.c: Update.
2057         * python/py-cmd.c: Update.
2058         * python/py-finishbreakpoint.c: Update.
2059         * python/py-frame.c: Update.
2060         * python/py-framefilter.c: Update.
2061         * python/py-gdb-readline.c: Update.
2062         * python/py-inferior.c: Update.
2063         * python/py-infthread.c: Update.
2064         * python/py-lazy-string.c: Update.
2065         * python/py-linetable.c: Update.
2066         * python/py-objfile.c: Update.
2067         * python/py-param.c: Update.
2068         * python/py-prettyprint.c: Update.
2069         * python/py-progspace.c: Update.
2070         * python/py-record-btrace.c: Update.
2071         * python/py-record.c: Update.
2072         * python/py-symbol.c: Update.
2073         * python/py-type.c: Update.
2074         * python/py-unwind.c: Update.
2075         * python/py-utils.c: Update.
2076         * python/py-value.c: Update.
2077         * python/python.c: Update.
2078         * record-btrace.c: Update.
2079         * record-full.c: Update.
2080         * remote-fileio.c: Update.
2081         * remote.c: Update.
2082         * riscv-tdep.c: Update.
2083         * rs6000-aix-tdep.c: Update.
2084         * rs6000-tdep.c: Update.
2085         * rust-exp.y: Update.
2086         * rust-lang.c: Update.
2087         * s390-tdep.c: Update.
2088         * selftest-arch.c: Update.
2089         * solib-dsbt.c: Update.
2090         * solib-frv.c: Update.
2091         * solib-spu.c: Update.
2092         * solib-svr4.c: Update.
2093         * solib.c: Update.
2094         * sparc64-linux-tdep.c: Update.
2095         * stack.c: Update.
2096         * symfile-mem.c: Update.
2097         * symmisc.c: Update.
2098         * target.c: Update.
2099         * thread.c: Update.
2100         * top.c: Update.
2101         * tracefile-tfile.c: Update.
2102         * tui/tui.c: Update.
2103         * typeprint.c: Update.
2104         * unittests/cli-utils-selftests.c: Update.
2105         * unittests/parse-connection-spec-selftests.c: Update.
2106         * valops.c: Update.
2107         * valprint.c: Update.
2108         * value.c: Update.
2109         * varobj.c: Update.
2110         * windows-nat.c: Update.
2111         * x86-linux-nat.c: Update.
2112         * xml-support.c: Update.
2113
2114 2019-04-08  Tom Tromey  <tom@tromey.com>
2115
2116         * xml-support.c: Use C++ exception handling.
2117         * x86-linux-nat.c: Use C++ exception handling.
2118         * windows-nat.c: Use C++ exception handling.
2119         * varobj.c: Use C++ exception handling.
2120         * value.c: Use C++ exception handling.
2121         * valprint.c: Use C++ exception handling.
2122         * valops.c: Use C++ exception handling.
2123         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2124         handling.
2125         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2126         * typeprint.c: Use C++ exception handling.
2127         * tui/tui.c: Use C++ exception handling.
2128         * tracefile-tfile.c: Use C++ exception handling.
2129         * top.c: Use C++ exception handling.
2130         * thread.c: Use C++ exception handling.
2131         * target.c: Use C++ exception handling.
2132         * symmisc.c: Use C++ exception handling.
2133         * symfile-mem.c: Use C++ exception handling.
2134         * stack.c: Use C++ exception handling.
2135         * sparc64-linux-tdep.c: Use C++ exception handling.
2136         * solib.c: Use C++ exception handling.
2137         * solib-svr4.c: Use C++ exception handling.
2138         * solib-spu.c: Use C++ exception handling.
2139         * solib-frv.c: Use C++ exception handling.
2140         * solib-dsbt.c: Use C++ exception handling.
2141         * selftest-arch.c: Use C++ exception handling.
2142         * s390-tdep.c: Use C++ exception handling.
2143         * rust-lang.c: Use C++ exception handling.
2144         * rust-exp.y: Use C++ exception handling.
2145         * rs6000-tdep.c: Use C++ exception handling.
2146         * rs6000-aix-tdep.c: Use C++ exception handling.
2147         * riscv-tdep.c: Use C++ exception handling.
2148         * remote.c: Use C++ exception handling.
2149         * remote-fileio.c: Use C++ exception handling.
2150         * record-full.c: Use C++ exception handling.
2151         * record-btrace.c: Use C++ exception handling.
2152         * python/python.c: Use C++ exception handling.
2153         * python/py-value.c: Use C++ exception handling.
2154         * python/py-utils.c: Use C++ exception handling.
2155         * python/py-unwind.c: Use C++ exception handling.
2156         * python/py-type.c: Use C++ exception handling.
2157         * python/py-symbol.c: Use C++ exception handling.
2158         * python/py-record.c: Use C++ exception handling.
2159         * python/py-record-btrace.c: Use C++ exception handling.
2160         * python/py-progspace.c: Use C++ exception handling.
2161         * python/py-prettyprint.c: Use C++ exception handling.
2162         * python/py-param.c: Use C++ exception handling.
2163         * python/py-objfile.c: Use C++ exception handling.
2164         * python/py-linetable.c: Use C++ exception handling.
2165         * python/py-lazy-string.c: Use C++ exception handling.
2166         * python/py-infthread.c: Use C++ exception handling.
2167         * python/py-inferior.c: Use C++ exception handling.
2168         * python/py-gdb-readline.c: Use C++ exception handling.
2169         * python/py-framefilter.c: Use C++ exception handling.
2170         * python/py-frame.c: Use C++ exception handling.
2171         * python/py-finishbreakpoint.c: Use C++ exception handling.
2172         * python/py-cmd.c: Use C++ exception handling.
2173         * python/py-breakpoint.c: Use C++ exception handling.
2174         * python/py-arch.c: Use C++ exception handling.
2175         * printcmd.c: Use C++ exception handling.
2176         * ppc-linux-tdep.c: Use C++ exception handling.
2177         * parse.c: Use C++ exception handling.
2178         * p-valprint.c: Use C++ exception handling.
2179         * objc-lang.c: Use C++ exception handling.
2180         * mi/mi-main.c: Use C++ exception handling.
2181         * mi/mi-interp.c: Use C++ exception handling.
2182         * mi/mi-cmd-stack.c: Use C++ exception handling.
2183         * mi/mi-cmd-break.c: Use C++ exception handling.
2184         * main.c: Use C++ exception handling.
2185         * linux-thread-db.c: Use C++ exception handling.
2186         * linux-tdep.c: Use C++ exception handling.
2187         * linux-nat.c: Use C++ exception handling.
2188         * linux-fork.c: Use C++ exception handling.
2189         * linespec.c: Use C++ exception handling.
2190         * language.c: Use C++ exception handling.
2191         * jit.c: Use C++ exception handling.
2192         * infrun.c: Use C++ exception handling.
2193         * infcmd.c: Use C++ exception handling.
2194         * infcall.c: Use C++ exception handling.
2195         * inf-loop.c: Use C++ exception handling.
2196         * i386-tdep.c: Use C++ exception handling.
2197         * i386-linux-tdep.c: Use C++ exception handling.
2198         * guile/scm-value.c: Use C++ exception handling.
2199         * guile/scm-type.c: Use C++ exception handling.
2200         * guile/scm-symtab.c: Use C++ exception handling.
2201         * guile/scm-symbol.c: Use C++ exception handling.
2202         * guile/scm-pretty-print.c: Use C++ exception handling.
2203         * guile/scm-ports.c: Use C++ exception handling.
2204         * guile/scm-param.c: Use C++ exception handling.
2205         * guile/scm-math.c: Use C++ exception handling.
2206         * guile/scm-lazy-string.c: Use C++ exception handling.
2207         * guile/scm-frame.c: Use C++ exception handling.
2208         * guile/scm-disasm.c: Use C++ exception handling.
2209         * guile/scm-cmd.c: Use C++ exception handling.
2210         * guile/scm-breakpoint.c: Use C++ exception handling.
2211         * guile/scm-block.c: Use C++ exception handling.
2212         * guile/guile-internal.h: Use C++ exception handling.
2213         * gnu-v3-abi.c: Use C++ exception handling.
2214         * gdbtypes.c: Use C++ exception handling.
2215         * frame.c: Use C++ exception handling.
2216         * frame-unwind.c: Use C++ exception handling.
2217         * fbsd-tdep.c: Use C++ exception handling.
2218         * f-valprint.c: Use C++ exception handling.
2219         * exec.c: Use C++ exception handling.
2220         * event-top.c: Use C++ exception handling.
2221         * event-loop.c: Use C++ exception handling.
2222         * eval.c: Use C++ exception handling.
2223         * dwarf2read.c: Use C++ exception handling.
2224         * dwarf2loc.c: Use C++ exception handling.
2225         * dwarf2-frame.c: Use C++ exception handling.
2226         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2227         * dwarf-index-write.c: Use C++ exception handling.
2228         * dwarf-index-cache.c: Use C++ exception handling.
2229         * dtrace-probe.c: Use C++ exception handling.
2230         * disasm-selftests.c: Use C++ exception handling.
2231         * darwin-nat.c: Use C++ exception handling.
2232         * cp-valprint.c: Use C++ exception handling.
2233         * cp-support.c: Use C++ exception handling.
2234         * cp-abi.c: Use C++ exception handling.
2235         * corelow.c: Use C++ exception handling.
2236         * completer.c: Use C++ exception handling.
2237         * compile/compile-object-run.c: Use C++ exception handling.
2238         * compile/compile-object-load.c: Use C++ exception handling.
2239         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2240         * compile/compile-c-symbols.c: Use C++ exception handling.
2241         * common/selftest.c: Use C++ exception handling.
2242         * common/new-op.c: Use C++ exception handling.
2243         * cli/cli-script.c: Use C++ exception handling.
2244         * cli/cli-interp.c: Use C++ exception handling.
2245         * cli/cli-cmds.c: Use C++ exception handling.
2246         * c-varobj.c: Use C++ exception handling.
2247         * btrace.c: Use C++ exception handling.
2248         * breakpoint.c: Use C++ exception handling.
2249         * break-catch-throw.c: Use C++ exception handling.
2250         * arch-utils.c: Use C++ exception handling.
2251         * amd64-tdep.c: Use C++ exception handling.
2252         * ada-valprint.c: Use C++ exception handling.
2253         * ada-typeprint.c: Use C++ exception handling.
2254         * ada-lang.c: Use C++ exception handling.
2255         * aarch64-tdep.c: Use C++ exception handling.
2256
2257 2019-04-08  Tom Tromey  <tom@tromey.com>
2258
2259         * xml-support.c (gdb_xml_parser::parse): Update.
2260         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2261         * value.c (show_convenience): Update.
2262         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2263         (test_parse_flags_qcs): Update.
2264         * thread.c (thr_try_catch_cmd): Update.
2265         * target.c (target_translate_tls_address): Update.
2266         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2267         (info_frame_command_core, frame_apply_command_count): Update.
2268         * rust-exp.y (rust_lex_exception_test): Update.
2269         * riscv-tdep.c (riscv_print_one_register_info): Update.
2270         * remote.c (remote_target::enable_btrace): Update.
2271         * record-btrace.c (record_btrace_enable_warn): Update.
2272         * python/py-utils.c (gdbpy_convert_exception): Update.
2273         * printcmd.c (do_one_display, print_variable_and_value): Update.
2274         * mi/mi-main.c (mi_print_exception): Update.
2275         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2276         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2277         * linux-nat.c (linux_nat_target::attach): Update.
2278         * linux-fork.c (class scoped_switch_fork_info): Update.
2279         * infrun.c (displaced_step_prepare): Update.
2280         * infcall.c (call_function_by_hand_dummy): Update.
2281         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2282         * gnu-v3-abi.c (print_one_vtable): Update.
2283         * frame.c (get_prev_frame_always): Update.
2284         * f-valprint.c (info_common_command_for_block): Update.
2285         * exec.c (try_open_exec_file): Update.
2286         * exceptions.c (print_exception, exception_print)
2287         (exception_fprintf, exception_print_same): Update.
2288         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2289         * dwarf-index-cache.c (index_cache::store)
2290         (index_cache::lookup_gdb_index): Update.
2291         * darwin-nat.c (maybe_cache_shell): Update.
2292         * cp-valprint.c (cp_print_value_fields): Update.
2293         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2294         (gcc_cplus_symbol_address): Update.
2295         * compile/compile-c-symbols.c (gcc_convert_symbol)
2296         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2297         * common/selftest.c: Update.
2298         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2299         a std::string.
2300         (exception_try_scope_entry, exception_try_scope_exit): Don't
2301         declare.
2302         (struct exception_try_scope): Remove.
2303         (TRY): Don't use exception_try_scope.
2304         (struct gdb_exception): Add constructor, operator=.
2305         <what>: New method.
2306         (struct gdb_exception_RETURN_MASK_ALL)
2307         (struct gdb_exception_RETURN_MASK_ERROR)
2308         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2309         (struct gdb_quit_bad_alloc): Update.
2310         * common/common-exceptions.c (exception_none): Change
2311         initializer.
2312         (struct catcher) <state, exception>: Initialize inline.
2313         <prev>: Remove member.
2314         (current_catcher): Remove.
2315         (catchers): New global.
2316         (exceptions_state_mc_init): Simplify.
2317         (catcher_pop): Remove.
2318         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2319         (try_scope_depth, exception_try_scope_entry)
2320         (exception_try_scope_exit): Remove.
2321         (throw_exception_sjlj): Update.
2322         (exception_messages, exception_messages_size): Remove.
2323         (throw_it): Simplify.
2324         (gdb_exception_sliced_copy): Remove.
2325         (throw_exception_cxx): Update.
2326         * cli/cli-script.c (script_from_file): Update.
2327         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2328         Update.
2329         * ada-valprint.c (ada_val_print): Update.
2330         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2331         (create_excep_cond_exprs): Update.
2332
2333 2019-04-08  Tom Tromey  <tom@tromey.com>
2334
2335         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2336         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2337         (TRY, CATCH, END_CATCH): Remove some definitions.
2338         * common/common-exceptions.c: Don't use GDB_XCPT.
2339         (catcher_list_size): Remove.
2340         (throw_exception, throw_it): Simplify.
2341
2342 2019-04-05  Tom Tromey  <tom@tromey.com>
2343
2344         Revert the header-sorting patch.
2345         * ft32-tdep.c: Revert.
2346         * frv-tdep.c: Revert.
2347         * frv-linux-tdep.c: Revert.
2348         * frame.c: Revert.
2349         * frame-unwind.c: Revert.
2350         * frame-base.c: Revert.
2351         * fork-child.c: Revert.
2352         * findvar.c: Revert.
2353         * findcmd.c: Revert.
2354         * filesystem.c: Revert.
2355         * filename-seen-cache.h: Revert.
2356         * filename-seen-cache.c: Revert.
2357         * fbsd-tdep.c: Revert.
2358         * fbsd-nat.h: Revert.
2359         * fbsd-nat.c: Revert.
2360         * f-valprint.c: Revert.
2361         * f-typeprint.c: Revert.
2362         * f-lang.c: Revert.
2363         * extension.h: Revert.
2364         * extension.c: Revert.
2365         * extension-priv.h: Revert.
2366         * expprint.c: Revert.
2367         * exec.h: Revert.
2368         * exec.c: Revert.
2369         * exceptions.c: Revert.
2370         * event-top.c: Revert.
2371         * event-loop.c: Revert.
2372         * eval.c: Revert.
2373         * elfread.c: Revert.
2374         * dwarf2read.h: Revert.
2375         * dwarf2read.c: Revert.
2376         * dwarf2loc.c: Revert.
2377         * dwarf2expr.h: Revert.
2378         * dwarf2expr.c: Revert.
2379         * dwarf2-frame.c: Revert.
2380         * dwarf2-frame-tailcall.c: Revert.
2381         * dwarf-index-write.h: Revert.
2382         * dwarf-index-write.c: Revert.
2383         * dwarf-index-common.c: Revert.
2384         * dwarf-index-cache.h: Revert.
2385         * dwarf-index-cache.c: Revert.
2386         * dummy-frame.c: Revert.
2387         * dtrace-probe.c: Revert.
2388         * disasm.h: Revert.
2389         * disasm.c: Revert.
2390         * disasm-selftests.c: Revert.
2391         * dictionary.c: Revert.
2392         * dicos-tdep.c: Revert.
2393         * demangle.c: Revert.
2394         * dcache.h: Revert.
2395         * dcache.c: Revert.
2396         * darwin-nat.h: Revert.
2397         * darwin-nat.c: Revert.
2398         * darwin-nat-info.c: Revert.
2399         * d-valprint.c: Revert.
2400         * d-namespace.c: Revert.
2401         * d-lang.c: Revert.
2402         * ctf.c: Revert.
2403         * csky-tdep.c: Revert.
2404         * csky-linux-tdep.c: Revert.
2405         * cris-tdep.c: Revert.
2406         * cris-linux-tdep.c: Revert.
2407         * cp-valprint.c: Revert.
2408         * cp-support.c: Revert.
2409         * cp-namespace.c: Revert.
2410         * cp-abi.c: Revert.
2411         * corelow.c: Revert.
2412         * corefile.c: Revert.
2413         * continuations.c: Revert.
2414         * completer.h: Revert.
2415         * completer.c: Revert.
2416         * complaints.c: Revert.
2417         * coffread.c: Revert.
2418         * coff-pe-read.c: Revert.
2419         * cli-out.h: Revert.
2420         * cli-out.c: Revert.
2421         * charset.c: Revert.
2422         * c-varobj.c: Revert.
2423         * c-valprint.c: Revert.
2424         * c-typeprint.c: Revert.
2425         * c-lang.c: Revert.
2426         * buildsym.c: Revert.
2427         * buildsym-legacy.c: Revert.
2428         * build-id.h: Revert.
2429         * build-id.c: Revert.
2430         * btrace.c: Revert.
2431         * bsd-uthread.c: Revert.
2432         * breakpoint.h: Revert.
2433         * breakpoint.c: Revert.
2434         * break-catch-throw.c: Revert.
2435         * break-catch-syscall.c: Revert.
2436         * break-catch-sig.c: Revert.
2437         * blockframe.c: Revert.
2438         * block.c: Revert.
2439         * bfin-tdep.c: Revert.
2440         * bfin-linux-tdep.c: Revert.
2441         * bfd-target.c: Revert.
2442         * bcache.c: Revert.
2443         * ax-general.c: Revert.
2444         * ax-gdb.h: Revert.
2445         * ax-gdb.c: Revert.
2446         * avr-tdep.c: Revert.
2447         * auxv.c: Revert.
2448         * auto-load.c: Revert.
2449         * arm-wince-tdep.c: Revert.
2450         * arm-tdep.c: Revert.
2451         * arm-symbian-tdep.c: Revert.
2452         * arm-pikeos-tdep.c: Revert.
2453         * arm-obsd-tdep.c: Revert.
2454         * arm-nbsd-tdep.c: Revert.
2455         * arm-nbsd-nat.c: Revert.
2456         * arm-linux-tdep.c: Revert.
2457         * arm-linux-nat.c: Revert.
2458         * arm-fbsd-tdep.c: Revert.
2459         * arm-fbsd-nat.c: Revert.
2460         * arm-bsd-tdep.c: Revert.
2461         * arch-utils.c: Revert.
2462         * arc-tdep.c: Revert.
2463         * arc-newlib-tdep.c: Revert.
2464         * annotate.h: Revert.
2465         * annotate.c: Revert.
2466         * amd64-windows-tdep.c: Revert.
2467         * amd64-windows-nat.c: Revert.
2468         * amd64-tdep.c: Revert.
2469         * amd64-sol2-tdep.c: Revert.
2470         * amd64-obsd-tdep.c: Revert.
2471         * amd64-obsd-nat.c: Revert.
2472         * amd64-nbsd-tdep.c: Revert.
2473         * amd64-nbsd-nat.c: Revert.
2474         * amd64-nat.c: Revert.
2475         * amd64-linux-tdep.c: Revert.
2476         * amd64-linux-nat.c: Revert.
2477         * amd64-fbsd-tdep.c: Revert.
2478         * amd64-fbsd-nat.c: Revert.
2479         * amd64-dicos-tdep.c: Revert.
2480         * amd64-darwin-tdep.c: Revert.
2481         * amd64-bsd-nat.c: Revert.
2482         * alpha-tdep.c: Revert.
2483         * alpha-obsd-tdep.c: Revert.
2484         * alpha-nbsd-tdep.c: Revert.
2485         * alpha-mdebug-tdep.c: Revert.
2486         * alpha-linux-tdep.c: Revert.
2487         * alpha-linux-nat.c: Revert.
2488         * alpha-bsd-tdep.c: Revert.
2489         * alpha-bsd-nat.c: Revert.
2490         * aix-thread.c: Revert.
2491         * agent.c: Revert.
2492         * addrmap.c: Revert.
2493         * ada-varobj.c: Revert.
2494         * ada-valprint.c: Revert.
2495         * ada-typeprint.c: Revert.
2496         * ada-tasks.c: Revert.
2497         * ada-lang.c: Revert.
2498         * aarch64-tdep.c: Revert.
2499         * aarch64-ravenscar-thread.c: Revert.
2500         * aarch64-newlib-tdep.c: Revert.
2501         * aarch64-linux-tdep.c: Revert.
2502         * aarch64-linux-nat.c: Revert.
2503         * aarch64-fbsd-tdep.c: Revert.
2504         * aarch64-fbsd-nat.c: Revert.
2505         * aarch32-linux-nat.c: Revert.
2506
2507 2019-04-05  Tom Tromey  <tom@tromey.com>
2508
2509         * ft32-tdep.c: Sort headers.
2510         * frv-tdep.c: Sort headers.
2511         * frv-linux-tdep.c: Sort headers.
2512         * frame.c: Sort headers.
2513         * frame-unwind.c: Sort headers.
2514         * frame-base.c: Sort headers.
2515         * fork-child.c: Sort headers.
2516         * findvar.c: Sort headers.
2517         * findcmd.c: Sort headers.
2518         * filesystem.c: Sort headers.
2519         * filename-seen-cache.h: Sort headers.
2520         * filename-seen-cache.c: Sort headers.
2521         * fbsd-tdep.c: Sort headers.
2522         * fbsd-nat.h: Sort headers.
2523         * fbsd-nat.c: Sort headers.
2524         * f-valprint.c: Sort headers.
2525         * f-typeprint.c: Sort headers.
2526         * f-lang.c: Sort headers.
2527         * extension.h: Sort headers.
2528         * extension.c: Sort headers.
2529         * extension-priv.h: Sort headers.
2530         * expprint.c: Sort headers.
2531         * exec.h: Sort headers.
2532         * exec.c: Sort headers.
2533         * exceptions.c: Sort headers.
2534         * event-top.c: Sort headers.
2535         * event-loop.c: Sort headers.
2536         * eval.c: Sort headers.
2537         * elfread.c: Sort headers.
2538         * dwarf2read.h: Sort headers.
2539         * dwarf2read.c: Sort headers.
2540         * dwarf2loc.c: Sort headers.
2541         * dwarf2expr.h: Sort headers.
2542         * dwarf2expr.c: Sort headers.
2543         * dwarf2-frame.c: Sort headers.
2544         * dwarf2-frame-tailcall.c: Sort headers.
2545         * dwarf-index-write.h: Sort headers.
2546         * dwarf-index-write.c: Sort headers.
2547         * dwarf-index-common.c: Sort headers.
2548         * dwarf-index-cache.h: Sort headers.
2549         * dwarf-index-cache.c: Sort headers.
2550         * dummy-frame.c: Sort headers.
2551         * dtrace-probe.c: Sort headers.
2552         * disasm.h: Sort headers.
2553         * disasm.c: Sort headers.
2554         * disasm-selftests.c: Sort headers.
2555         * dictionary.c: Sort headers.
2556         * dicos-tdep.c: Sort headers.
2557         * demangle.c: Sort headers.
2558         * dcache.h: Sort headers.
2559         * dcache.c: Sort headers.
2560         * darwin-nat.h: Sort headers.
2561         * darwin-nat.c: Sort headers.
2562         * darwin-nat-info.c: Sort headers.
2563         * d-valprint.c: Sort headers.
2564         * d-namespace.c: Sort headers.
2565         * d-lang.c: Sort headers.
2566         * ctf.c: Sort headers.
2567         * csky-tdep.c: Sort headers.
2568         * csky-linux-tdep.c: Sort headers.
2569         * cris-tdep.c: Sort headers.
2570         * cris-linux-tdep.c: Sort headers.
2571         * cp-valprint.c: Sort headers.
2572         * cp-support.c: Sort headers.
2573         * cp-namespace.c: Sort headers.
2574         * cp-abi.c: Sort headers.
2575         * corelow.c: Sort headers.
2576         * corefile.c: Sort headers.
2577         * continuations.c: Sort headers.
2578         * completer.h: Sort headers.
2579         * completer.c: Sort headers.
2580         * complaints.c: Sort headers.
2581         * coffread.c: Sort headers.
2582         * coff-pe-read.c: Sort headers.
2583         * cli-out.h: Sort headers.
2584         * cli-out.c: Sort headers.
2585         * charset.c: Sort headers.
2586         * c-varobj.c: Sort headers.
2587         * c-valprint.c: Sort headers.
2588         * c-typeprint.c: Sort headers.
2589         * c-lang.c: Sort headers.
2590         * buildsym.c: Sort headers.
2591         * buildsym-legacy.c: Sort headers.
2592         * build-id.h: Sort headers.
2593         * build-id.c: Sort headers.
2594         * btrace.c: Sort headers.
2595         * bsd-uthread.c: Sort headers.
2596         * breakpoint.h: Sort headers.
2597         * breakpoint.c: Sort headers.
2598         * break-catch-throw.c: Sort headers.
2599         * break-catch-syscall.c: Sort headers.
2600         * break-catch-sig.c: Sort headers.
2601         * blockframe.c: Sort headers.
2602         * block.c: Sort headers.
2603         * bfin-tdep.c: Sort headers.
2604         * bfin-linux-tdep.c: Sort headers.
2605         * bfd-target.c: Sort headers.
2606         * bcache.c: Sort headers.
2607         * ax-general.c: Sort headers.
2608         * ax-gdb.h: Sort headers.
2609         * ax-gdb.c: Sort headers.
2610         * avr-tdep.c: Sort headers.
2611         * auxv.c: Sort headers.
2612         * auto-load.c: Sort headers.
2613         * arm-wince-tdep.c: Sort headers.
2614         * arm-tdep.c: Sort headers.
2615         * arm-symbian-tdep.c: Sort headers.
2616         * arm-pikeos-tdep.c: Sort headers.
2617         * arm-obsd-tdep.c: Sort headers.
2618         * arm-nbsd-tdep.c: Sort headers.
2619         * arm-nbsd-nat.c: Sort headers.
2620         * arm-linux-tdep.c: Sort headers.
2621         * arm-linux-nat.c: Sort headers.
2622         * arm-fbsd-tdep.c: Sort headers.
2623         * arm-fbsd-nat.c: Sort headers.
2624         * arm-bsd-tdep.c: Sort headers.
2625         * arch-utils.c: Sort headers.
2626         * arc-tdep.c: Sort headers.
2627         * arc-newlib-tdep.c: Sort headers.
2628         * annotate.h: Sort headers.
2629         * annotate.c: Sort headers.
2630         * amd64-windows-tdep.c: Sort headers.
2631         * amd64-windows-nat.c: Sort headers.
2632         * amd64-tdep.c: Sort headers.
2633         * amd64-sol2-tdep.c: Sort headers.
2634         * amd64-obsd-tdep.c: Sort headers.
2635         * amd64-obsd-nat.c: Sort headers.
2636         * amd64-nbsd-tdep.c: Sort headers.
2637         * amd64-nbsd-nat.c: Sort headers.
2638         * amd64-nat.c: Sort headers.
2639         * amd64-linux-tdep.c: Sort headers.
2640         * amd64-linux-nat.c: Sort headers.
2641         * amd64-fbsd-tdep.c: Sort headers.
2642         * amd64-fbsd-nat.c: Sort headers.
2643         * amd64-dicos-tdep.c: Sort headers.
2644         * amd64-darwin-tdep.c: Sort headers.
2645         * amd64-bsd-nat.c: Sort headers.
2646         * alpha-tdep.c: Sort headers.
2647         * alpha-obsd-tdep.c: Sort headers.
2648         * alpha-nbsd-tdep.c: Sort headers.
2649         * alpha-mdebug-tdep.c: Sort headers.
2650         * alpha-linux-tdep.c: Sort headers.
2651         * alpha-linux-nat.c: Sort headers.
2652         * alpha-bsd-tdep.c: Sort headers.
2653         * alpha-bsd-nat.c: Sort headers.
2654         * aix-thread.c: Sort headers.
2655         * agent.c: Sort headers.
2656         * addrmap.c: Sort headers.
2657         * ada-varobj.c: Sort headers.
2658         * ada-valprint.c: Sort headers.
2659         * ada-typeprint.c: Sort headers.
2660         * ada-tasks.c: Sort headers.
2661         * ada-lang.c: Sort headers.
2662         * aarch64-tdep.c: Sort headers.
2663         * aarch64-ravenscar-thread.c: Sort headers.
2664         * aarch64-newlib-tdep.c: Sort headers.
2665         * aarch64-linux-tdep.c: Sort headers.
2666         * aarch64-linux-nat.c: Sort headers.
2667         * aarch64-fbsd-tdep.c: Sort headers.
2668         * aarch64-fbsd-nat.c: Sort headers.
2669         * aarch32-linux-nat.c: Sort headers.
2670
2671 2019-04-04  Tom Tromey  <tom@tromey.com>
2672
2673         * varobj.c (varobj_create): Update.
2674         * rust-exp.y (struct rust_parser) <update_innermost_block,
2675         lookup_symbol>: New methods.
2676         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2677         Rename.
2678         (rust_parser::rust_lookup_type)
2679         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2680         * printcmd.c (display_command, do_one_display): Update.
2681         * parser-defs.h (struct parser_state) <parser_state>: Add
2682         "tracker" parameter.
2683         (block_tracker): New member.
2684         (class innermost_block_tracker) <innermost_block_tracker>: Add
2685         "types" parameter.
2686         <reset>: Remove method.
2687         (innermost_block): Don't declare.
2688         (null_post_parser): Update.
2689         * parse.c (innermost_block): Remove global.
2690         (write_dollar_variable): Update.
2691         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2692         Remove "tracker_types" parameter.
2693         (parse_expression): Add "tracker" parameter.
2694         (parse_expression_for_completion): Update.
2695         (null_post_parser): Add "tracker" parameter.
2696         * p-exp.y: Update rules.
2697         * m2-exp.y: Update rules.
2698         * language.h (struct language_defn) <la_post_parser>: Add
2699         "tracker" parameter.
2700         * go-exp.y: Update rules.
2701         * f-exp.y: Update rules.
2702         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2703         parameter.
2704         * d-exp.y: Update rules.
2705         * c-exp.y: Update rules.
2706         * breakpoint.c (set_breakpoint_condition): Create an
2707         innermost_block_tracker.
2708         (watch_command_1): Likewise.
2709         * ada-lang.c (resolve): Add "tracker" parameter.
2710         (resolve_subexp): Likewise.
2711         * ada-exp.y (write_var_from_sym): Update.
2712
2713 2019-04-04  Tom Tromey  <tom@tromey.com>
2714
2715         * type-stack.h: New file.
2716         * type-stack.c: New file.
2717         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2718         type-stack.h.
2719         (insert_into_type_stack, insert_type, push_type, push_type_int)
2720         (insert_type_address_space, pop_type, pop_type_int)
2721         (pop_typelist, pop_type_stack, append_type_stack)
2722         (push_type_stack, get_type_stack, push_typelist)
2723         (follow_type_instance_flags, follow_types): Don't declare.
2724         * parse.c (type_stack): Remove global.
2725         (parse_exp_in_context): Update.
2726         (insert_into_type_stack, insert_type, push_type, push_type_int)
2727         (insert_type_address_space, pop_type, pop_type_int)
2728         (pop_typelist, pop_type_stack, append_type_stack)
2729         (push_type_stack, get_type_stack, push_typelist)
2730         (follow_type_instance_flags, follow_types): Remove (moved to
2731         type-stack.c).
2732         * f-exp.y (type_stack): New global.
2733         Update rules.
2734         (push_kind_type, f_parse): Update.
2735         * d-exp.y (type_stack): New global.
2736         Update rules.
2737         (d_parse): Update.
2738         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2739         Update rules.
2740         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2741         (HFILES_NO_SRCDIR): Add type-stack.h.
2742
2743 2019-04-04  Tom Tromey  <tom@tromey.com>
2744
2745         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2746         (rust_parser::convert_ast_to_expression, rust_parse)
2747         (rust_lex_test_completion, rust_lex_tests): Update.
2748         * parser-defs.h (struct expr_completion_state): New.
2749         (struct parser_state) <parser_state>: Add completion parameter.
2750         <mark_struct_expression, mark_completion_tag>: New methods.
2751         <parse_completion, m_completion_state>: New members.
2752         (prefixify_expression, null_post_parser): Update.
2753         (mark_struct_expression, mark_completion_tag): Don't declare.
2754         * parse.c (parse_completion, expout_last_struct)
2755         (expout_tag_completion_type, expout_completion_name): Remove
2756         globals.
2757         (parser_state::mark_struct_expression)
2758         (parser_state::mark_completion_tag): Now methods.
2759         (prefixify_expression): Add last_struct parameter.
2760         (prefixify_subexp): Likewise.
2761         (parse_exp_1): Update.
2762         (parse_exp_in_context): Add cstate parameter.  Update.
2763         (parse_expression_for_completion): Create an
2764         expr_completion_state.
2765         (null_post_parser): Add "completion" parameter.
2766         * p-exp.y: Update rules.
2767         (yylex): Update.
2768         * language.h (struct language_defn) <la_post_parser>: Add
2769         "completing" parameter.
2770         * go-exp.y: Update rules.
2771         (lex_one_token): Update.
2772         * expression.h (parse_completion): Don't declare.
2773         * d-exp.y: Update rules.
2774         (lex_one_token): Update rules.
2775         * c-exp.y: Update rules.
2776         (lex_one_token): Update.
2777         * ada-lang.c (resolve): Add "parse_completion" parameter.
2778         (resolve_subexp): Likewise.
2779         (ada_resolve_function): Likewise.
2780
2781 2019-04-04  Tom Tromey  <tom@tromey.com>
2782
2783         * parser-defs.h (struct parser_state) <start_arglist,
2784         end_arglist>: New methods.
2785         <arglist_len, m_funcall_chain>: New members.
2786         (arglist_len, start_arglist, end_arglist): Don't declare.
2787         * parse.c (arglist_len, funcall_chain): Remove global.
2788         (start_arglist, end_arglist): Remove functions.
2789         (parse_exp_in_context): Update.
2790         * p-exp.y: Update rules.
2791         * m2-exp.y: Update rules.
2792         * go-exp.y: Update rules.
2793         * f-exp.y: Update rules.
2794         * d-exp.y: Update rules.
2795         * c-exp.y: Update rules.
2796
2797 2019-04-04  Tom Tromey  <tom@tromey.com>
2798
2799         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2800         lex_operator, push_back>: New methods.
2801         Update all rules.
2802         (rust_parser::lex_hex, lex_escape): Rename and update.
2803         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2804         (rust_parser::lex_operator): Rename and update.
2805         (rust_parser::lex_number, rustyylex, rustyyerror)
2806         (rust_lex_test_init, rust_lex_test_sequence)
2807         (rust_lex_test_push_back, rust_lex_tests): Update.
2808         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2809         parameter.
2810         <lexptr, prev_lexptr>: New members.
2811         (lexptr, prev_lexptr): Don't declare.
2812         * parse.c (lexptr, prev_lexptr): Remove globals.
2813         (parse_exp_in_context): Update.
2814         * p-exp.y (yylex, yyerror): Update.
2815         * m2-exp.y (parse_number, yylex, yyerror): Update.
2816         * go-exp.y (lex_one_token, yyerror): Update.
2817         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2818         * d-exp.y (lex_one_token, yyerror): Update.
2819         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2820         (lex_one_token, yyerror): Update.
2821         * ada-lex.l (YY_INPUT): Update.
2822         (rewind_to_char): Update.
2823         * ada-exp.y (yyerror): Update.
2824
2825 2019-04-04  Tom Tromey  <tom@tromey.com>
2826
2827         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2828         * parser-defs.h (struct parser_state) <parser_state>: Add new
2829         parameter.
2830         <comma_terminates>: New member.
2831         (comma_terminates): Don't declare global.
2832         * parse.c (comma_terminates): Remove global.
2833         (parse_exp_in_context): Update.
2834         * p-exp.y (yylex): Update.
2835         * m2-exp.y (yylex): Update.
2836         * go-exp.y (lex_one_token): Update.
2837         * f-exp.y (yylex): Update.
2838         * d-exp.y (lex_one_token): Update.
2839         * c-exp.y (lex_one_token): Update.
2840         * ada-lex.l: Update.
2841
2842 2019-04-04  Tom Tromey  <tom@tromey.com>
2843
2844         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2845         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2846         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2847         * parser-defs.h (paren_depth): Don't declare.
2848         * parse.c (paren_depth): Remove global.
2849         (parse_exp_in_context): Update.
2850         * p-exp.y (paren_depth): New global.
2851         (pascal_parse): Initialize it.
2852         * m2-exp.y (paren_depth): New global.
2853         (m2_parse): Initialize it.
2854         * go-exp.y (paren_depth): New global.
2855         (go_parse): Initialize it.
2856         * f-exp.y (paren_depth): New global.
2857         (f_parse): Initialize it.
2858         * d-exp.y (paren_depth): New global.
2859         (d_parse): Initialize it.
2860         * c-exp.y (paren_depth): New global.
2861         (c_parse): Initialize it.
2862         * ada-lex.l (paren_depth): New global.
2863         (lexer_init): Initialize it.
2864
2865 2019-04-04  Tom Tromey  <tom@tromey.com>
2866
2867         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2868         (rust_parser::convert_ast_to_type)
2869         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2870         * parser-defs.h (struct parser_state) <parser_state>: Add
2871         parameters.  Initialize new members.
2872         <expression_context_block, expression_context_pc>: New members.
2873         * parse.c (expression_context_block, expression_context_pc):
2874         Remove globals.
2875         (parse_exp_in_context): Update.
2876         * p-exp.y: Update all rules.
2877         (yylex): Update.
2878         * m2-exp.y: Update all rules.
2879         (yylex): Update.
2880         * go-exp.y (yylex): Update.
2881         * f-exp.y (yylex): Update.
2882         * d-exp.y: Update all rules.
2883         (yylex): Update.
2884         * c-exp.y: Update all rules.
2885         (lex_one_token, classify_name, yylex, c_parse): Update.
2886         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2887
2888 2019-04-04  Tom Tromey  <tom@tromey.com>
2889
2890         * gdbarch.h, gdbarch.c: Rebuild.
2891         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2892         * stap-probe.h:
2893         (struct stap_parse_info): Replace "parser_state" with
2894         "expr_builder".
2895         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2896         (parser_state): New class.
2897         * parse.c (expr_builder): Rename.
2898         (expr_builder::release): Rename.
2899         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2900         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2901         (write_exp_elt_longcst, write_exp_elt_floatcst)
2902         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2903         (write_exp_string_vector, write_exp_bitstring)
2904         (write_exp_msymbol, mark_struct_expression)
2905         (write_dollar_variable)
2906         (insert_type_address_space, increase_expout_size): Replace
2907         "parser_state" with "expr_builder".
2908         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2909         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2910         "parser_state" with "expr_builder".
2911
2912 2019-04-04  Tom Tromey  <tom@tromey.com>
2913
2914         * rust-exp.y: Replace "parse_language" with method call.
2915         * p-exp.y:
2916         (yylex): Replace "parse_language" with method call.
2917         * m2-exp.y:
2918         (yylex): Replace "parse_language" with method call.
2919         * go-exp.y (classify_name): Replace "parse_language" with method
2920         call.
2921         * f-exp.y (yylex): Replace "parse_language" with method call.
2922         * d-exp.y (lex_one_token): Replace "parse_language" with method
2923         call.
2924         * c-exp.y:
2925         (lex_one_token, classify_name, yylex): Replace "parse_language"
2926         with method call.
2927         * ada-exp.y (find_primitive_type, type_char)
2928         (type_system_address): Replace "parse_language" with method call.
2929
2930 2019-04-04  Tom Tromey  <tom@tromey.com>
2931
2932         * rust-exp.y: Replace "parse_gdbarch" with method call.
2933         * parse.c (write_dollar_variable, insert_type_address_space):
2934         Replace "parse_gdbarch" with method call.
2935         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2936         call.
2937         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2938         call.
2939         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2940         "parse_gdbarch" with method call.
2941         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2942         with method call.
2943         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2944         "parse_gdbarch" with method call.
2945         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2946         "parse_gdbarch" with method call.
2947         * c-exp.y (parse_type, parse_number, classify_name): Replace
2948         "parse_gdbarch" with method call.
2949         * ada-lex.l: Replace "parse_gdbarch" with method call.
2950         * ada-exp.y (parse_type, find_primitive_type, type_char)
2951         (type_system_address): Replace "parse_gdbarch" with method call.
2952
2953 2019-04-04  Tom Tromey  <tom@tromey.com>
2954
2955         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2956         * stap-probe.c (stap_parse_argument): Update.
2957         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2958         initial_size parameter.
2959         * rust-exp.y (rust_lex_tests): Update.
2960         * parse.c (parser_state): Update.
2961         (parse_exp_in_context): Update.
2962         * parser-defs.h (struct parser_state) <parser_state>: Remove
2963         "initial_size" parameter.
2964
2965 2019-04-04  Tom Tromey  <tom@tromey.com>
2966
2967         * parser-defs.h (increase_expout_size): Don't declare.
2968         * parse.c (increase_expout_size): Now static.
2969
2970 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2971
2972         * gnu-nat.c (gnu_nat_target::wait): Fix
2973         target_waitstatus_to_string call.
2974
2975 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2976
2977         * eval.c (evaluate_subexp_standard): Handle internal functions
2978         during Fortran function call handling.
2979
2980 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * NEWS: Mention new internal functions.
2983         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2984         (read_base_type): Use dwarf2_init_complex_target_type.
2985         * value.c (creal_internal_fn): New function.
2986         (cimag_internal_fn): New function.
2987         (_initialize_values): Register new internal functions.
2988
2989 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2990
2991         * infrun.c (stop_all_threads): If debug_infrun, always
2992         trace the wait status after wait_one, using
2993         target_waitstatus_to_string and target_pid_to_str.
2994         (handle_inferior_event): Replace various trace of
2995         wait status kind by a single trace.
2996         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2997         wait status kind image by target_waitstatus_to_string.
2998         * target/waitstatus.c (target_waitstatus_to_string): Fix
2999         obsolete comment.
3000
3001 2019-04-01  Tom Tromey  <tromey@adacore.com>
3002
3003         PR symtab/23331:
3004         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3005
3006 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3007             Pedro Alves  <palves@redhat.com>
3008
3009         * top.c (quit_force): Call 'finalize_values'.
3010         * value.c (finalize_values): New function.
3011         * value.h (finalize_values): Declare.
3012
3013 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3014
3015         * NEWS: Announce $_gdb_major and $_gdb_minor.
3016
3017         * top.c (init_gdb_version_vars): New function.
3018         (gdb_init): Call init_gdb_version_vars.
3019
3020 2019-03-29  Tom Tromey  <tromey@adacore.com>
3021
3022         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3023         help text.  Remove dead code.
3024
3025 2019-03-29  Keith Seitz  <keiths@redhat.com>
3026
3027         From Siddhesh Poyarekar:
3028         * f-lang.h (f77_get_upperbound): Return LONGEST.
3029         (f77_get_lowerbound): Likewise.
3030         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3031         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3032         print them.
3033         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3034         plongest to format print it.
3035         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3036         (f77_get_upperbound): Likewise.
3037         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3038         LOWER_BOUND to LONGEST.
3039         (f77_create_arrayprint_offset_tbl): Likewise.
3040
3041 2019-03-29  Keith Seitz  <keiths@redhat.com>
3042
3043         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3044         %s/pulongest for TYPE_LENGTH instead of %d in format
3045         strings.
3046         * ada-typerint.c (ada_print_type): Likewise.
3047         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3048         * compile/compile-c-support.c (generate_register_struct): Likewise.
3049         * gdbtypes.c (recursive_dump_type): Likewise.
3050         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3051         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3052         instead of %d in format strings.
3053         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3054         to std::min to ULONGEST.
3055         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3056         instead of %d in format strings.
3057         * tracepoint.c (info_scope_command): Likewise.
3058         * typeprint.c (print_offset_data::update)
3059         (print_offset_data::finish): Likewise.
3060         * xtensa-tdep.c (xtensa_store_return_value)
3061         (xtensa_push_dummy_call): Likewise.
3062
3063 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3064
3065         * windows-nat.c (display_selector): Fixed format specifications
3066         for 64-bit Cygwin.
3067
3068 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3069
3070         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3071
3072 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3073
3074         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3075         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3076         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3077         (nios2_linux_init_abi): Install it.
3078
3079 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3080
3081         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3082
3083 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3084
3085         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3086
3087 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3088             Tom Tromey  <tromey@adacore.com>
3089
3090         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3091
3092 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3093
3094         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3095         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3096         method to compute the bounds of range types. Also print "[evaluated]"
3097         if the bounds' values come from a dynamic evaluation.
3098
3099 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3102         whitespace when pretty printing is on.
3103
3104 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3105
3106         * ppc-linux-nat.c: Add include.
3107
3108 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3109
3110         * NEWS: Mention AArch64 Pointer Authentication.
3111
3112 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3113
3114         * arm-linux-nat.c: Add include.
3115
3116 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3117
3118         * source-cache.c (source_cache::get_source_lines): Re-read
3119         fullname after calling open_source_file.
3120
3121 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3122
3123         * NEWS: Mention TLS support for FreeBSD.
3124
3125 2019-03-25  Tom Tromey  <tromey@adacore.com>
3126
3127         * minsyms.c (BUNCH_SIZE): Update comment.
3128         (~minimal_symbol_reader): Remove old comment.
3129         (compact_minimal_symbols): Update comment.
3130         (minimal_symbol_reader::install): Remove old comment.  Update
3131         other comments.
3132
3133 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3134
3135         * s390-linux-nat.c: Add include.
3136
3137 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3138
3139         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3140         Call linux_get_hwcap.
3141         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3142         Likewise.
3143         (aarch64_linux_get_hwcap): Remove function.
3144         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3145         declaration.
3146         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3147         linux_get_hwcap.
3148         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3149         * linux-tdep.c (linux_get_hwcap): Add function.
3150         (linux_get_hwcap2): Likewise.
3151         * linux-tdep.h (linux_get_hwcap): Add declaration.
3152         (linux_get_hwcap2): Likewise.
3153         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3154         (ppc_linux_get_hwcap2): Likewise.
3155         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3156         linux_get_hwcap.
3157         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3158         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3159         (ppc_linux_nat_target::read_description): Likewise.
3160         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3161         * s390-linux-nat.c: Likewise.
3162         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3163
3164 2019-03-24  Tom Tromey  <tom@tromey.com>
3165
3166         * ada-lang.c (standard_lookup): Simplify initialization.
3167         (ada_lookup_symbol_nonlocal): Simplify return.
3168         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3169         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3170         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3171         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3172         initialization.
3173         * solib.c (solib_global_lookup): Simplify.
3174         * symtab.c (null_block_symbol): Remove.
3175         (symbol_cache_lookup): Simplify returns.
3176         (lookup_language_this): Simplify returns.
3177         (lookup_symbol_aux): Simplify return.
3178         (lookup_local_symbol): Simplify returns.
3179         (lookup_global_symbol_from_objfile): Simplify return.
3180         (lookup_symbol_in_objfile_symtabs)
3181         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3182         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3183         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3184         * cp-namespace.c (cp_lookup_bare_symbol)
3185         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3186         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3187         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3188         (cp_lookup_symbol_via_imports): Simplify initialization.
3189         (find_symbol_in_baseclass): Likewise.
3190         * symtab.h (null_block_symbol): Remove.
3191         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3192         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3193         (d_lookup_symbol_module): Likewise.
3194         (find_symbol_in_baseclass): Simplify initialization.
3195
3196 2019-03-24  Tom Tromey  <tom@tromey.com>
3197
3198         * expression.h: Don't include symtab.h.
3199         (struct block): Forward declare.
3200
3201 2019-03-24  Tom Tromey  <tom@tromey.com>
3202
3203         * c-exp.y (typebase): Remove casts.
3204         * gdbtypes.c (lookup_unsigned_typename, )
3205         (lookup_signed_typename): Remove cast.
3206         * eval.c (parse_to_comma_and_eval): Remove cast.
3207         * parse.c (write_dollar_variable): Remove cast.
3208         * block.h (struct block) <superblock>: Now const.
3209         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3210         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3211         (map_block): Make "block" const.
3212         * symfile.h (struct quick_symbol_functions)
3213         <map_matching_symbols>: Constify block argument to "callback".
3214         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3215         const.
3216         (find_pc_sect_compunit_symtab): Make "b" const.
3217         (find_symbol_at_address): Likewise.
3218         (search_symbols): Likewise.
3219         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3220         (dw2_debug_names_lookup_symbol): Likewise.
3221         (dw2_map_matching_symbols): Update.
3222         * p-valprint.c (pascal_val_print): Remove "block".
3223         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3224         (aux_add_nonlocal_symbols): Make "block" const.
3225         (resolve_subexp): Remove cast.
3226         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3227         const.
3228         (iterate_over_file_blocks): Likewise.
3229         * f-exp.y (%union) <bval>: Remove.
3230         * coffread.c (patch_opaque_types): Make "b" const.
3231         * spu-tdep.c (spu_catch_start): Make "block" const.
3232         * c-valprint.c (print_unpacked_pointer): Remove "block".
3233         * symmisc.c (dump_symtab_1): Make "b" const.
3234         (block_depth): Make "block" const.
3235         * d-exp.y (%union) <bval>: Remove.
3236         * cp-support.h (cp_lookup_rtti_type): Update.
3237         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3238         * psymtab.c (psym_lookup_symbol): Make "block" const.
3239         (maintenance_check_psymtabs): Make "b" const.
3240         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3241         (enumerate_locals, enumerate_args): Update.
3242         * python/py-symtab.c (stpy_global_block): Make "block" const.
3243         (stpy_static_block): Likewise.
3244         * inline-frame.c (block_starting_point_at): Make "new_block"
3245         const.
3246         * block.c (find_block_in_blockvector): Make return type const.
3247         (blockvector_for_pc_sect): Make "b" const.
3248         (find_block_in_blockvector): Make "b" const.
3249
3250 2019-03-23  Tom Tromey  <tom@tromey.com>
3251
3252         * varobj.c (varobj_create): Update.
3253         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3254         * printcmd.c (display_command, do_one_display): Don't reset
3255         innermost_block.
3256         * parser-defs.h (enum innermost_block_tracker_type): Move to
3257         expression.h.
3258         (innermost_block): Update comment.
3259         * parse.c (parse_exp_1): Add tracker_types parameter.
3260         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3261         tracker_types parameter.  Reset innermost_block.
3262         (parse_exp_in_context): Remove.
3263         (parse_expression_for_completion): Update.
3264         * objfiles.c (~objfile): Don't reset expression_context_block or
3265         innermost_block.
3266         * expression.h (enum innermost_block_tracker_type): Move from
3267         parser-defs.h.
3268         (parse_exp_1): Add tracker_types parameter.
3269         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3270         reset innermost_block.
3271
3272 2019-03-23  Tom Tromey  <tom@tromey.com>
3273
3274         * objfiles.h: Include bcache.h.
3275
3276 2019-03-23  Tom Tromey  <tom@tromey.com>
3277
3278         * linespec.c (get_current_search_block): Use
3279         scoped_restore_current_language.
3280         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3281
3282 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3283             Jiong Wang  <jiong.wang@arm.com>
3284
3285         * aarch64-linux-tdep.c
3286         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3287         section.
3288         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3289
3290 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3291             Jiong Wang  <jiong.wang@arm.com>
3292
3293         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3294         instructions.
3295         (aarch64_analyze_prologue_test): Add PACIASP test.
3296         (aarch64_prologue_prev_register): Unmask PC value.
3297
3298 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3299             Jiong Wang  <jiong.wang@arm.com>
3300
3301         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3302         (aarch64_dwarf2_prev_register): Unmask PC value.
3303         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3304         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3305         DW_CFA_AARCH64_negate_ra_state.
3306         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3307
3308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3309             Jiong Wang  <jiong.wang@arm.com>
3310
3311         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3312         registers.
3313         (aarch64_pseudo_register_name): Likewise.
3314         (aarch64_pseudo_register_type): Likewise.
3315         (aarch64_pseudo_register_reggroup_p): Likewise.
3316         (aarch64_gdbarch_init): Add pauth registers.
3317         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3318         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3319         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3320         (struct gdbarch_tdep): Add regnum for ra_state.
3321
3322 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3323             Jiong Wang  <jiong.wang@arm.com>
3324
3325         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3326
3327 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3328             Jiong Wang  <jiong.wang@arm.com>
3329
3330         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3331         function.
3332         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3333         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3334         (aarch64_gdbarch_init): Add puth registers.
3335         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3336         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3337         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3338
3339 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3340             Jiong Wang  <jiong.wang@arm.com>
3341
3342         * aarch64-linux-nat.c
3343         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3344         * aarch64-linux-tdep.c
3345         (aarch64_linux_core_read_description): Likewise.
3346         (aarch64_linux_get_hwcap): New function.
3347         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3348         (aarch64_linux_get_hwcap): New declaration.
3349
3350 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3351             Jiong Wang  <jiong.wang@arm.com>
3352
3353         * aarch64-linux-nat.c
3354         (aarch64_linux_nat_target::read_description): Add pauth param.
3355         * aarch64-linux-tdep.c
3356         (aarch64_linux_core_read_description): Likewise.
3357         * aarch64-tdep.c (struct target_desc): Add in pauth.
3358         (aarch64_read_description): Add pauth param.
3359         (aarch64_gdbarch_init): Likewise.
3360         * aarch64-tdep.h (aarch64_read_description): Likewise.
3361         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3362         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3363         * features/Makefile: Add new files.
3364         * features/aarch64-pauth.c: New file.
3365         * features/aarch64-pauth.xml: New file.
3366
3367 2019-03-20  Tom Tromey  <tromey@adacore.com>
3368
3369         * infrun.c (handle_inferior_event): Rename from
3370         handle_inferior_event_1.  Create a scoped_value_mark.
3371         (handle_inferior_event): Remove.
3372
3373 2019-03-19  Tom Tromey  <tromey@adacore.com>
3374
3375         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3376         * infrun.h (print_stop_event): Add "displays" parameter.
3377         * infrun.c (print_stop_event): Add "displays" parameter.
3378
3379 2019-03-19  Pedro Alves  <palves@redhat.com>
3380
3381         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3382         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3383         to -1.  Fix TABs vs spaces.
3384         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3385         * tui/tui-out.h (tui_ui_out) Add intro comments.
3386         <m_line, m_start_of_line>: In-class initialize, and add describing
3387         comment.
3388
3389 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3390
3391         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3392         variable names.
3393         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3394
3395 2019-03-18  Pedro Alves  <palves@redhat.com>
3396             Eli Zaretskii <eliz@gnu.org>
3397
3398         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3399         m_line and m_start_of_line.
3400
3401 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3402
3403         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3404         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3405         it returns a newline.  This fixes a regression in TU mode, whereby
3406         the next line is output on the same screen line as the user input.
3407
3408 2019-03-18  Tom Tromey  <tromey@adacore.com>
3409
3410         * minsyms.c (minimal_symbol_reader::install): Remove call to
3411         obstack_blank.
3412
3413 2019-03-18  Pedro Alves  <palves@redhat.com>
3414
3415         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3416         New globals.
3417         (apply_style): New, factored out from ...
3418         (apply_ansi_escape): ... this.  Handle reverse video mode.
3419         (tui_set_reverse_mode): New function.
3420         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3421         * tui/tui-winsource.c (tui_show_source_line): Use
3422         tui_set_reverse_mode instead of setting A_STANDOUT.
3423         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3424         New setter methods.
3425
3426 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3427
3428         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3429         Handle tabs.
3430
3431 2019-03-18  Tom Tromey  <tromey@adacore.com>
3432
3433         * ada-lang.c (empty_array): Add "high" parameter.
3434         (ada_evaluate_subexp): Update.
3435
3436 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3437
3438         * unittests/string_view-selftests.c: Define
3439         _initialize_string_view_selftests unconditionally.
3440
3441 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3442
3443         PR gdb/24350
3444         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3445
3446 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3447
3448         PR gdb/24351
3449         * windows-nat.c (display_selector): Fix format specifiers.
3450
3451 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3452
3453         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3454         tui_refill_source_window instead of tui_refresh_win, to update the
3455         current execution line.  This fixes redisplay of the current line
3456         when stepping through the code with "next" or "step".
3457
3458 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3459
3460         * source-cache.c (source_cache::get_source_lines): Call
3461         find_source_lines to initialize s->nlines.  This fixes vertical
3462         scrolling of TUI source window when the DOWN arrow is pressed.
3463
3464 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3465
3466         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3467         linux-thread-db.c (_initialize_thread_db): Likewise.
3468
3469 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3470
3471         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3472         wclrtoeol in tui_show_source_line".  This reverts changes made in
3473         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3474
3475 2019-03-15  Tom Tromey  <tom@tromey.com>
3476
3477         * symtab.h (struct minimal_symbol): Derive from
3478         general_symbol_info.
3479         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3480         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3481         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3482         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3483         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3484         (MSYMBOL_SEARCH_NAME): Update.
3485         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3486         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3487         * minsyms.c (minimal_symbol_reader::record_full): Update.
3488
3489 2019-03-15  Tom Tromey  <tom@tromey.com>
3490
3491         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3492
3493 2019-03-15  Tom Tromey  <tom@tromey.com>
3494
3495         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3496         unique_xmalloc_ptr.
3497         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3498         Update.
3499         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3500         (build_minimal_symbol_hash_tables)
3501         (minimal_symbol_reader::install): Update.
3502
3503 2019-03-15  Tom Tromey  <tom@tromey.com>
3504
3505         * symtab.c (create_demangled_names_hash): Update.
3506         (symbol_set_names): Update.
3507         * objfiles.h (struct objfile_per_bfd_storage)
3508         <demangled_names_hash>: Now an htab_up.
3509         * objfiles.c (objfile_per_bfd_storage): Simplify.
3510
3511 2019-03-15  Tom Tromey  <tom@tromey.com>
3512
3513         * objfiles.h (struct objfile_per_bfd_storage): Declare
3514         destructor.
3515         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3516         New.
3517         (get_objfile_bfd_data): Use new.  Don't initialize
3518         language_of_main.
3519         (free_objfile_per_bfd_storage): Remove.
3520         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3521
3522 2019-03-15  Tom Tromey  <tom@tromey.com>
3523
3524         * symfile.c (reread_symbols): Update.
3525         * objfiles.c (objfile::objfile): Update.
3526         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3527         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3528         comment.
3529         (minimal_symbol_reader::install): Update.
3530         (terminate_minimal_symbol_table): Remove.
3531         * jit.c (jit_object_close_impl): Update.
3532
3533 2019-03-15  Tom Tromey  <tom@tromey.com>
3534
3535         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3536         initializations.
3537
3538 2019-03-15  Tom Tromey  <tom@tromey.com>
3539
3540         * objfiles.h (struct objfile_per_bfd_storage)
3541         <demangled_hash_languages>: Now a bitset.
3542         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3543         (lookup_minimal_symbol): Update.
3544
3545 2019-03-15  Tom Tromey  <tom@tromey.com>
3546
3547         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3548         Don't return the symbol.
3549         * coffread.c (record_minimal_symbol): Use record_full.
3550
3551 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3552
3553         The MS-Windows port of ncurses fails to switch to a color pair if
3554         one or both of the colors are the implicit default colors.  This
3555         change records the default colors when TUI is initialized, and
3556         then specifies them explicitly when a color pair uses the default
3557         colors.  This allows color styling in TUI mode on MS-Windows.
3558
3559         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3560         ncurses_norm_attr.
3561         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3562         colors in ncurses_norm_attr.
3563         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3564         "none", replace it with the default color recorded in
3565         ncurses_norm_attr.
3566
3567 2019-03-14  Tom Tromey  <tromey@adacore.com>
3568
3569         * source-cache.h (class source_cache) <get_source_lines>: Return
3570         std::string.
3571         * source-cache.c (source_cache::extract_lines): Handle case where
3572         first_pos==npos.  Return std::string.
3573         (source_cache::get_source_lines): Update.
3574
3575 2019-03-14  Tom Tromey  <tromey@adacore.com>
3576
3577         * NEWS: Add item for "style sources" commands.
3578         * source-cache.c (source_cache::get_source_lines): Check
3579         source_styling.
3580         * cli/cli-style.c (source_styling): New global.
3581         (_initialize_cli_style): Add "style sources" commands.
3582         (show_style_sources): New function.
3583         * cli/cli-style.h (source_styling): Declare.
3584
3585 2019-03-14  Pedro Alves  <palves@redhat.com>
3586             Tom Tromey  <tromey@adacore.com>
3587
3588         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3589         * tui/tui-winsource.c (tui_refill_source_window): New function,
3590         from...
3591         (tui_horizontal_source_scroll): ... here.  Move some logic.
3592         * cli/cli-style.c (set_style_enabled): Notify new observable.
3593         * tui/tui-hooks.c (tui_redisplay_source): New function.
3594         (tui_attach_detach_observers): Attach or detach
3595         tui_redisplay_source.
3596         * observable.h (source_styling_changed): New observable.
3597         * observable.c: Define source_styling_changed observable.
3598
3599 2019-03-13  Tom Tromey  <tromey@adacore.com>
3600
3601         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3602         (i386_gnu_nat_target::store_registers): Update.
3603         * target-debug.h (target_debug_print_std_string): New macro.
3604         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3605         * windows-tdep.c (display_one_tib): Update.
3606         * tui/tui-stack.c (tui_make_status_line): Update.
3607         * top.c (print_inferior_quit_action): Update.
3608         * thread.c (thr_try_catch_cmd): Update.
3609         (add_thread_with_info): Update.
3610         (thread_target_id_str): Update.
3611         (thr_try_catch_cmd): Update.
3612         (thread_command): Update.
3613         (thread_find_command): Update.
3614         * record-btrace.c (record_btrace_target::info_record)
3615         (record_btrace_resume_thread, record_btrace_target::resume)
3616         (record_btrace_cancel_resume, record_btrace_step_thread)
3617         (record_btrace_target::wait, record_btrace_target::wait)
3618         (record_btrace_target::wait, record_btrace_target::stop): Update.
3619         * progspace.c (print_program_space): Update.
3620         * process-stratum-target.c
3621         (process_stratum_target::thread_address_space): Update.
3622         * linux-fork.c (linux_fork_mourn_inferior)
3623         (detach_checkpoint_command, info_checkpoints_command)
3624         (linux_fork_context): Update.
3625         (linux_fork_detach): Update.
3626         (class scoped_switch_fork_info): Update.
3627         (delete_checkpoint_command): Update.
3628         * infrun.c (follow_fork_inferior): Update.
3629         (follow_fork_inferior): Update.
3630         (proceed_after_vfork_done): Update.
3631         (handle_vfork_child_exec_or_exit): Update.
3632         (follow_exec): Update.
3633         (displaced_step_prepare_throw): Update.
3634         (displaced_step_restore): Update.
3635         (start_step_over): Update.
3636         (resume_1): Update.
3637         (clear_proceed_status_thread): Update.
3638         (proceed): Update.
3639         (print_target_wait_results): Update.
3640         (do_target_wait): Update.
3641         (context_switch): Update.
3642         (stop_all_threads): Update.
3643         (restart_threads): Update.
3644         (finish_step_over): Update.
3645         (handle_signal_stop): Update.
3646         (switch_back_to_stepped_thread): Update.
3647         (keep_going_pass_signal): Update.
3648         (print_exited_reason): Update.
3649         (normal_stop): Update.
3650         * inferior.c (inferior_pid_to_str): Change return type.
3651         (print_selected_inferior): Update.
3652         (add_inferior): Update.
3653         (detach_inferior): Update.
3654         * dummy-frame.c (fprint_dummy_frames): Update.
3655         * dcache.c (dcache_info_1): Update.
3656         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3657         (btrace_fetch, btrace_clear): Update.
3658         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3659         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3660         type.
3661         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3662         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3663         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3664         * gdbarch.c, gdbarch.h: Rebuild.
3665         * gdbarch.sh (core_pid_to_str): Change return type.
3666         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3667         return type.
3668         (windows_nat_target::pid_to_str): Change return type.
3669         (windows_delete_thread): Update.
3670         (windows_nat_target::attach): Update.
3671         (windows_nat_target::files_info): Update.
3672         * target-delegates.c: Rebuild.
3673         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3674         return type.
3675         (sol_thread_target::pid_to_str): Change return type.
3676         * remote.c (class remote_target) <pid_to_str>: Change return
3677         type.
3678         (remote_target::pid_to_str): Change return type.
3679         (extended_remote_target::attach, remote_target::remote_stop_ns)
3680         (remote_target::remote_notif_remove_queued_reply)
3681         (remote_target::push_stop_reply, remote_target::disable_btrace):
3682         Update.
3683         (extended_remote_target::attach): Update.
3684         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3685         type.
3686         (gdbsim_target::pid_to_str): Change return type.
3687         * ravenscar-thread.c (struct ravenscar_thread_target)
3688         <pid_to_str>: Change return type.
3689         (ravenscar_thread_target::pid_to_str): Change return type.
3690         * procfs.c (class procfs_target) <pid_to_str>: Change return
3691         type.
3692         (procfs_target::pid_to_str): Change return type.
3693         (procfs_target::attach): Update.
3694         (procfs_target::detach): Update.
3695         (procfs_target::fetch_registers): Update.
3696         (procfs_target::store_registers): Update.
3697         (procfs_target::wait): Update.
3698         (procfs_target::files_info): Update.
3699         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3700         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3701         return type.
3702         (nto_procfs_target::pid_to_str): Change return type.
3703         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3704         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3705         return type.
3706         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3707         (exit_lwp): Update.
3708         (attach_proc_task_lwp_callback, get_detach_signal)
3709         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3710         (linux_nat_target::resume, wait_lwp, stop_callback)
3711         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3712         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3713         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3714         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3715         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3716         type.
3717         (inf_ptrace_target::attach): Update.
3718         (inf_ptrace_target::files_info): Update.
3719         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3720         type.
3721         (go32_nat_target::pid_to_str): Change return type.
3722         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3723         (gnu_nat_target::wait): Update.
3724         (gnu_nat_target::wait): Update.
3725         (gnu_nat_target::resume): Update.
3726         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3727         (fbsd_nat_target::wait): Update.
3728         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3729         type.
3730         (darwin_nat_target::attach): Update.
3731         * corelow.c (class core_target) <pid_to_str>: Change return type.
3732         (core_target::pid_to_str): Change return type.
3733         * target.c (normal_pid_to_str): Change return type.
3734         (default_pid_to_str): Likewise.
3735         (target_pid_to_str): Change return type.
3736         (target_translate_tls_address): Update.
3737         (target_announce_detach): Update.
3738         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3739         return type.
3740         (bsd_uthread_target::pid_to_str): Change return type.
3741         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3742         type.
3743         (bsd_kvm_target::pid_to_str): Change return type.
3744         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3745         return type.
3746         (aix_thread_target::pid_to_str): Change return type.
3747         * target.h (struct target_ops) <pid_to_str>: Change return type.
3748         (target_pid_to_str, normal_pid_to_str): Likewise.
3749         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3750         type.
3751         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3752         type.
3753         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3754         return type.
3755         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3756         type.
3757         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3758         type.
3759         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3760         return type.
3761
3762 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3763
3764         * NEWS: Mention that the new default MI version is 3.  Mention
3765         changes to the output of commands and events that deal with
3766         multi-location breakpoints.
3767         * breakpoint.c: Include "mi/mi-out.h".
3768         (print_one_breakpoint): Change output syntax if using MI version
3769         >= 3.
3770         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3771         New.
3772         (mi_multi_location_breakpoint_output_fixed): New.
3773         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3774         (mi_cmd_fix_multi_location_breakpoint_output): New.
3775         (mi_multi_location_breakpoint_output_fixed): New.
3776         * mi/mi-cmds.c (mi_cmds): Register command
3777         -fix-multi-location-breakpoint-output.
3778         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3779         interpreter "mi".
3780
3781 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3782
3783         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3784         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3785         instantiate mi_ui_out based on interpreter name.
3786         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3787         * mi/mi-main.c (mi_load_progress): Likewise.
3788
3789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3790
3791         * NEWS: Combine separate "New targets" sections for 8.3.
3792
3793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3794
3795         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3796         (ppcfbsd_init_abi): Install gdbarch
3797         "fetch_tls_load_module_address" and "get_thread_local_address"
3798         methods.
3799
3800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3801
3802         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3803         (riscv_fbsd_init_abi): Install gdbarch
3804         "fetch_tls_load_module_address" and "get_thread_local_address"
3805         methods.
3806
3807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3808
3809         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3810         (i386fbsd_init_abi): Install gdbarch
3811         "fetch_tls_load_module_address" and "get_thread_local_address"
3812         methods.
3813
3814 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3815
3816         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3817         (amd64fbsd_init_abi): Install gdbarch
3818         "fetch_tls_load_module_address" and "get_thread_local_address"
3819         methods.
3820
3821 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3822
3823         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3824         (struct fbsd_pspace_data): New type.
3825         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3826         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3827         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3828         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3829         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3830
3831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3832
3833         * gdbtypes.c (lookup_struct_elt): New function.
3834         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3835         * gdbtypes.h (struct struct_elt): New type.
3836         (lookup_struct_elt): New prototype.
3837
3838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3839
3840         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3841         remove disabled code block.
3842
3843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3844
3845         * gdbarch.sh (get_thread_local_address): New method.
3846         * gdbarch.h, gdbarch.c: Regenerate.
3847         * target.c (target_translate_tls_address): Use
3848         gdbarch_get_thread_local_address if present instead of
3849         target::get_thread_local_address.
3850
3851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3852
3853         * target.h (target::get_thread_local_address): Update comment.
3854
3855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3856
3857         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3858         objfile->separate_debug_objfile_backlink if not NULL.
3859
3860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3861
3862         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3863         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3864         (amd64bsd_store_inferior_registers): Likewise.
3865         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3866         Enable segment base registers.
3867         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3868         PT_GETFSBASE and PT_GETGSBASE.
3869         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3870         PT_SETGSBASE.
3871         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3872         segment base registers.
3873         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3874
3875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3876
3877         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3878         Update calls to i386_target_description to add 'segments'
3879         parameter.
3880         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3881         add segment base registers.
3882         * arch/i386.c (i386_create_target_description): Add 'segments'
3883         parameter to enable segment base registers.
3884         * arch/i386.h (i386_create_target_description): Likewise.
3885         * features/i386/32bit-segments.xml: New file.
3886         * features/i386/32bit-segments.c: Generate.
3887         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3888         call to i386_target_description to add 'segments' parameter.
3889         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3890         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3891         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3892         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3893         if feature is present.
3894         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3895         Add 'segments' parameter to call to i386_target_description.
3896         (i386_target_description): Add 'segments' parameter to enable
3897         segment base registers.
3898         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3899         to call to i386_target_description.
3900         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3901         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3902         Define I386_NUM_REGS.
3903         (i386_target_description): Add 'segments' parameter to enable
3904         segment base registers.
3905
3906 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3907
3908         PR/24325
3909         * source-cache.c: #undef open and close, to avoid unresolved
3910         externals during linking.
3911
3912 2019-03-12  Tom Tromey  <tromey@adacore.com>
3913
3914         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3915         const.  Add initializers.
3916         (_initialize_remote): Don't initialize ptid globals.
3917
3918 2019-03-12  Pedro Alves  <palves@redhat.com>
3919
3920         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3921
3922 2019-03-12  Pedro Alves  <palves@redhat.com>
3923
3924         * cp-name-parser.y (main): Remove unused 'len' variable.
3925
3926 2019-03-12  Tom Tromey  <tromey@adacore.com>
3927
3928         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3929         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3930
3931 2019-03-12  Tom Tromey  <tromey@adacore.com>
3932
3933         * linux-nat.c (iterate_over_lwps): Update.
3934         (stop_callback): Remove parameter.
3935         (stop_wait_callback, detach_callback, resume_set_callback)
3936         (select_singlestep_lwp_callback, set_ignore_sigint)
3937         (status_callback, resumed_callback, resume_clear_callback)
3938         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3939         data parameter.
3940         (linux_nat_target::detach, linux_nat_target::resume)
3941         (linux_stop_and_wait_all_lwps, select_event_lwp)
3942         (linux_nat_filter_event, linux_nat_wait_1)
3943         (linux_nat_target::kill, linux_nat_target::stop)
3944         (linux_nat_target::stop): Update.
3945         (linux_nat_resume_callback): Change type.
3946         (resume_stopped_resumed_lwps, count_events_callback)
3947         (select_event_lwp_callback): Likewise.
3948         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3949         * arm-linux-nat.c (struct update_registers_data): Remove.
3950         (update_registers_callback): Change type.
3951         (arm_linux_insert_hw_breakpoint1): Update.
3952         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3953         parameter.
3954         (x86_linux_dr_set_addr): Update.
3955         (x86_linux_dr_set_control): Update.
3956         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3957         (iterate_over_lwps): Use gdb::function_view.
3958         * nat/aarch64-linux-hw-point.c (struct
3959         aarch64_dr_update_callback_param): Remove.
3960         (debug_reg_change_callback): Change type.
3961         (aarch64_notify_debug_reg_change): Update.
3962         * s390-linux-nat.c (s390_refresh_per_info): Update.
3963
3964 2019-03-11  Tom Tromey  <tromey@adacore.com>
3965
3966         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3967         redundant assignment to "this_cu".
3968
3969 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3970
3971         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3972
3973 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3974
3975         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3976         from...
3977         (rank_one_type): ... this.
3978
3979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3980
3981         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3982         from...
3983         (rank_one_type): ... this.
3984
3985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3986
3987         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3988         from...
3989         (rank_one_type): ... this.
3990
3991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3992
3993         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3994         from...
3995         (rank_one_type): ... this.
3996
3997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3998
3999         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4000         from...
4001         (rank_one_type): ... this.
4002
4003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4004
4005         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4006         from...
4007         (rank_one_type): ... this.
4008
4009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4010
4011         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4012         from...
4013         (rank_one_type): ... this.
4014
4015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4016
4017         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4018         from...
4019         (rank_one_type): ... this.
4020
4021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4022
4023         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4024         from...
4025         (rank_one_type): ... this.
4026
4027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4028
4029         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4030         from...
4031         (rank_one_type): ... this.
4032
4033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4034
4035         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4036         from...
4037         (rank_one_type): ... this.
4038
4039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4040
4041         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4042         from...
4043         (rank_one_type): ... this.
4044
4045 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4046
4047         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4048         inferior-events' shows the example events.
4049
4050 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4051
4052         Support styling on native MS-Windows console
4053
4054         PR/24315
4055         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4056         on MS-Windows if $TERM is not defined.
4057
4058         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4059
4060         * posix-hdep.c (gdb_console_fputs):
4061         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4062         functions.
4063         * ui-file.h (gdb_console_fputs): Add prototype.
4064
4065         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4066         back to fputs only if the former returns zero.
4067
4068 2019-03-07  Tom Tromey  <tom@tromey.com>
4069
4070         * symmisc.c (print_symbol_bcache_statistics): Update.
4071         (print_objfile_statistics): Update.
4072         * symfile.c (allocate_symtab): Update.
4073         * stabsread.c: Don't include bcache.h.
4074         * psymtab.h (struct psymbol_bcache): Don't declare.
4075         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4076         (psymbol_bcache_init, psymbol_bcache_free)
4077         (psymbol_bcache_get_bcache): Don't declare.
4078         * psymtab.c (struct psymbol_bcache): Remove.
4079         (psymtab_storage::psymtab_storage): Update.
4080         (psymtab_storage::~psymtab_storage): Update.
4081         (psymbol_bcache_init, psymbol_bcache_free)
4082         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4083         (add_psymbol_to_bcache): Update.
4084         (allocate_psymtab): Update.
4085         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4086         macro_cache>: No longer pointers.
4087         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4088         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4089         * macrotab.c (macro_bcache): Update.
4090         * macroexp.c: Don't include bcache.h.
4091         * gdbtypes.c (check_types_worklist): Update.
4092         (types_deeply_equal): Remove TRY/CATCH.  Update.
4093         * elfread.c (elf_symtab_read): Update.
4094         * dwarf2read.c: Don't include bcache.h.
4095         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4096         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4097         (print_bcache_statistics, bcache_memory_used): Don't declare.
4098         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4099         methods.  Rename all data members.
4100         * bcache.c (struct bcache): Move to bcache.h.
4101         (bcache::expand_hash_table): Rename from expand_hash_table.
4102         (bcache): Remove.
4103         (bcache::insert): Rename from bcache_full.
4104         (bcache::compare): Rename from bcache_compare.
4105         (bcache_xmalloc): Remove.
4106         (bcache::~bcache): Rename from bcache_xfree.
4107         (bcache::print_statistics): Rename from print_bcache_statistics.
4108         (bcache::memory_used): Rename from bcache_memory_used.
4109
4110 2019-03-07  Pedro Alves  <palves@redhat.com>
4111
4112         * infrun.c (normal_stop): Also check for
4113         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4114
4115 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4116
4117         * f-lang.c (value_from_host_double): Moved to...
4118         * value.c (value_from_host_double): ...here.
4119         * value.h (value_from_host_double): Declare.
4120         * guile/scm-math.c (vlscm_convert_typed_number): Use
4121         value_from_host_double.
4122         (vlscm_convert_number): Likewise.
4123         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4124         * python/py-value.c (convert_value_from_python): Likewise.
4125
4126 2019-03-06  Tom Tromey  <tom@tromey.com>
4127
4128         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4129
4130 2019-03-06  Tom Tromey  <tom@tromey.com>
4131
4132         * utils.h (free_current_contents): Don't declare.
4133         * utils.c (free_current_contents): Remove.
4134
4135 2019-03-06  Tom Tromey  <tom@tromey.com>
4136
4137         * top.c (quit_force): Update.
4138         * main.c (captured_command_loop): Update.
4139         * common/new-op.c (operator new): Update.
4140         * common/common-exceptions.c (struct catcher)
4141         <save_cleanup_chain>: Remove member.
4142         (exceptions_state_mc_init): Update.
4143         (exception_try_scope_entry): Return nullptr.
4144         (exception_try_scope_exit, exception_rethrow)
4145         (throw_exception_sjlj, throw_exception_cxx): Update.
4146         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4147         (all_cleanups, do_cleanups, discard_cleanups)
4148         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4149         (restore_cleanups, restore_final_cleanups): Don't declare.
4150         (do_final_cleanups): Remove parameter.
4151         * common/cleanups.c (cleanup_chain, make_cleanup)
4152         (make_cleanup_dtor, all_cleanups, do_cleanups)
4153         (discard_my_cleanups, discard_cleanups)
4154         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4155         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4156         (null_cleanup): Remove.
4157         (do_final_cleanups): Remove parameter.
4158
4159 2019-03-06  Tom Tromey  <tom@tromey.com>
4160
4161         * remote.c (remote_target::remote_parse_stop_reply): Use
4162         unique_xmalloc_ptr.
4163
4164 2019-03-06  Tom Tromey  <tom@tromey.com>
4165
4166         * stabsread.c (struct stabs_field_info): Rename from field_info.
4167         <list, fnlist>: Add initializers.
4168         <obstack>: New member.
4169         (read_member_functions, read_struct_fields, read_baseclasses):
4170         Allocate on obstack.  Don't use cleanups.
4171         (read_one_struct_field, read_member_functions, read_struct_fields)
4172         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4173         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4174         (read_struct_type): Update.
4175
4176 2019-03-06  Tom Tromey  <tom@tromey.com>
4177
4178         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4179         * common/filestuff.h (make_cleanup_close): Don't declare.
4180         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4181         Remove.
4182
4183 2019-03-06  Tom Tromey  <tom@tromey.com>
4184
4185         * solib-aix.c: Use make_scope_exit.
4186
4187 2019-03-06  Tom Tromey  <tom@tromey.com>
4188
4189         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4190         Use make_scope_exit.
4191
4192 2019-03-06  Tom Tromey  <tom@tromey.com>
4193
4194         * solib-svr4.c (disable_probes_interface): Remove parameter.
4195         (svr4_handle_solib_event): Use make_scope_exit.
4196
4197 2019-03-06  Tom Tromey  <tom@tromey.com>
4198
4199         * remote.c (struct stop_reply_deleter): Remove.
4200         (stop_reply_up): Update.
4201         (struct stop_reply): Derive from notif_event.  Don't typedef.
4202         <regcache>: Now a std::vector.
4203         (stop_reply_xfree): Remove.
4204         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4205         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4206         (remote_target::discard_pending_stop_replies): Use delete.
4207         (remote_target::remote_parse_stop_reply): Update.
4208         (remote_target::process_stop_reply): Update.
4209         * remote-notif.h (struct notif_event): Add virtual destructor.
4210         Remove "dtr" member.
4211         (struct notif_client) <alloc_event>: Return a unique_ptr.
4212         (notif_event_xfree): Don't declare.
4213         (notif_event_up): New typedef.
4214         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4215         (notif_event_xfree, do_notif_event_xfree): Remove.
4216         (remote_notif_state_xfree): Update.
4217
4218 2019-03-06  Tom Tromey  <tom@tromey.com>
4219
4220         * infrun.c (displaced_step_clear_cleanup): Now a
4221         forward_scope_exit type.
4222         (displaced_step_prepare_throw): Update.
4223         (displaced_step_fixup): Update.
4224
4225 2019-03-06  Tom Tromey  <tom@tromey.com>
4226
4227         * inferior.h (class inferior): Update comment.
4228         * gdbthread.h (class thread_info): Update comment.
4229
4230 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4231             Tom Tromey  <tom@tromey.com>
4232
4233         * stabsread.h (struct stab_section_list): Remove.
4234         (coffstab_build_psymtabs): Update.
4235         * dbxread.c (symbuf_sections): Now a std::vector.
4236         (sect_idx): New global.
4237         (fill_symbuf): Update.
4238         (coffstab_build_psymtabs): Change type of stabsects parameter.
4239         Update.
4240         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4241         std::vector.
4242         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4243         (coff_locate_sections): Update.
4244         (coff_symfile_read): Remove cleanups.  Update.
4245         (init_stringtab): Add storage parameter.
4246         (free_stringtab, free_stringtab_cleanup): Remove.
4247         (init_lineno): Add storage parameter.
4248         (free_linetab, free_linetab_cleanup): Remove.
4249
4250 2019-03-06  Pedro Alves  <palves@redhat.com>
4251
4252         * linux-fork.c (fork_info::clobber_regs): Delete.
4253         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4254         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4255         comment.  Adjust.
4256         (scoped_switch_fork_info::scoped_switch_fork_info)
4257         (checkpoint_command, linux_fork_context): Adjust
4258         fork_save_infrun_state calls.
4259
4260 2019-03-06  Pedro Alves  <palves@redhat.com>
4261
4262         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4263         (inf_has_multiple_threads): Return 'bool' and rewrite using
4264         inferior_info::threads().
4265
4266 2019-03-06  Pedro Alves  <palves@redhat.com>
4267
4268         * linux-fork.c: Include <list>.
4269         (fork_list): Now a std::list instance.
4270         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4271         (forks_exist_p, find_last_fork): Adjust.
4272         (new_fork): Delete.
4273         (one_fork_p): New.
4274         (add_fork): Adjust.
4275         (free_fork): Delete, folded into fork_info::~fork_info().
4276         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4277         Adjust.
4278         (init_fork_list): Delete.
4279         (linux_fork_killall, linux_fork_mourn_inferior)
4280         (linux_fork_detach, info_checkpoints_command): Adjust.
4281         (_initialize_linux_fork): No longer call init_fork_list.
4282
4283 2019-03-06  Pedro Alves  <palves@redhat.com>
4284
4285         * linux-fork.c (new_fork): New, split out of ...
4286         (add_fork): ... this.  Return void.  Move "first fork" special
4287         case from here, to ...
4288         (checkpoint_command): ... here.
4289         * linux-linux.h (add_fork): Return void.
4290
4291 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4292
4293         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4294
4295 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4296             Chris January  <chris.january@arm.com>
4297             David Lecomber  <david.lecomber@arm.com>
4298
4299         * f-exp.y: New token, UNOP_INTRINSIC.
4300         (exp): New pattern using UNOP_INTRINSIC token.
4301         (f77_keywords): Add 'abs' keyword.
4302         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4303         (value_from_host_double): New function.
4304         (evaluate_subexp_f): Support UNOP_ABS.
4305
4306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4309         types.
4310
4311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4314         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4315         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4316
4317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4318
4319         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4320
4321 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4322             Chris January  <chris.january@arm.com>
4323
4324         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4325         * f-exp.y: Define 'KIND' token.
4326         (exp): New pattern for KIND expressions.
4327         (ptype): Handle types with a kind extension.
4328         (direct_abs_decl): Extend to spot kind extensions.
4329         (f77_keywords): Add 'kind' to the list.
4330         (push_kind_type): New function.
4331         (convert_to_kind_type): New function.
4332         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4333         * parse.c (operator_length_standard): Likewise.
4334         * parser-defs.h (enum type_pieces): Add tp_kind.
4335         * std-operator.def: Add UNOP_KIND.
4336
4337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4338
4339         * f-exp.y (f_parse): Set yydebug.
4340
4341 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4342
4343         * f-lang.c (evaluate_subexp_f): New function.
4344         (exp_descriptor_f): New global.
4345         (f_language_defn): Use exp_descriptor_f instead of
4346         exp_descriptor_standard.
4347
4348 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * f-exp.y (struct token): Add comments.
4351         (dot_ops): Remove uppercase versions and the end marker.
4352         (f77_keywords): Likewise.
4353         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4354         entries in the dot_ops array are case insensitive, and use
4355         strncasecmp to compare strings.  Also some whitespace cleanup in
4356         this area.  Similar for the f77_keywords array, except entries in
4357         this list might be case sensitive.
4358
4359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * f-exp.y (struct f77_boolean_val): Add comments.
4362         (boolean_values): Remove uppercase versions, and end marker.
4363         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4364         and use strncasecmp to achieve case insensitivity.  Additionally,
4365         perform whitespace cleanup around this code.
4366
4367 2019-03-06  Tom Tromey  <tromey@adacore.com>
4368
4369         * remote-sim.c (gdbsim_target_open): Use result of
4370         gdb_argv::release.
4371
4372 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4373         Dirk Schubert  <dirk.schubert@arm.com>
4374         Chris January  <chris.january@arm.com>
4375
4376         * eval.c (evaluate_subexp_standard): Call Fortran argument
4377         wrapping logic.
4378         * f-lang.c (struct value): A value which can be passed into a
4379         Fortran function call.
4380         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4381         where appropriate.
4382         (struct type): Value ready for a Fortran function call.
4383         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4384         is needed.
4385         * f-lang.h (fortran_argument_convert): Declaration.
4386         (fortran_preserve_arg_pointer): Declaration.
4387         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4388
4389 2019-03-05  Tom Tromey  <tromey@adacore.com>
4390
4391         * python/py-prettyprint.c (print_string_repr): Remove #if.
4392         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4393
4394 2019-03-05  Tom Tromey  <tromey@adacore.com>
4395
4396         * target.c (the_dummy_target): Move later.  Change type to
4397         "dummy_target".
4398         (initialize_targets): Don't initialize the_dummy_target.
4399
4400 2019-03-05  Tom Tromey  <tromey@adacore.com>
4401
4402         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4403         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4404
4405 2019-03-05  Tom Tromey  <tromey@adacore.com>
4406
4407         * windows-nat.c (windows_nat_target::attach)
4408         (windows_nat_target::detach): Don't call gdb_flush.
4409         * valprint.c (generic_val_print, val_print, val_print_string):
4410         Don't call gdb_flush.
4411         * utils.c (defaulted_query): Don't call gdb_flush.
4412         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4413         * target.c (target_announce_detach): Don't call gdb_flush.
4414         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4415         * remote.c (extended_remote_target::attach): Don't call
4416         gdb_flush.
4417         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4418         * printcmd.c (do_examine): Don't call gdb_flush.
4419         (info_display_command): Don't call gdb_flush.
4420         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4421         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4422         * memattr.c (info_mem_command): Don't call gdb_flush.
4423         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4424         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4425         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4426         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4427         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4428         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4429         (gnu_nat_target::detach): Don't call gdb_flush.
4430         * f-valprint.c (f_val_print): Don't call gdb_flush.
4431         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4432         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4433         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4434         gdb_flush.
4435         * c-valprint.c (c_val_print): Don't call gdb_flush.
4436         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4437
4438 2019-03-05  Tom Tromey  <tromey@adacore.com>
4439
4440         * varobj.c (update_dynamic_varobj_children): Update.
4441         (install_default_visualizer): Use reset, not release.
4442         * value.c (set_internalvar): Update.
4443         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4444         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4445         ATTRIBUTE_UNUSED_RESULT.
4446
4447 2019-03-05  Tom Tromey  <tromey@adacore.com>
4448
4449         * remote.c (class scoped_remote_fd) <release>: Add
4450         ATTRIBUTE_UNUSED_RESULT.
4451
4452 2019-03-05  Tom Tromey  <tromey@adacore.com>
4453
4454         * macroexp.c (struct macro_buffer) <release>: Add
4455         ATTRIBUTE_UNUSED_RESULT.
4456
4457 2019-03-05  Tom Tromey  <tromey@adacore.com>
4458
4459         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4460         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4461         ATTRIBUTE_UNUSED_RESULT.
4462
4463 2019-03-05  Tom Tromey  <tromey@adacore.com>
4464
4465         * common/scoped_fd.h (class scoped_fd) <release>: Add
4466         ATTRIBUTE_UNUSED_RESULT.
4467
4468 2019-03-05  Tom Tromey  <tromey@adacore.com>
4469
4470         * parser-defs.h (struct parser_state) <release>: Add
4471         ATTRIBUTE_UNUSED_RESULT.
4472
4473 2019-03-05  Tom Tromey  <tromey@adacore.com>
4474
4475         * utils.h (class gdb_argv) <release>: Add
4476         ATTRIBUTE_UNUSED_RESULT.
4477         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4478
4479 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4480
4481         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4482         for-loop range, to avoid compiler warnings.
4483
4484         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4485         avoid compiler warnings about unused variables.
4486
4487         * NEWS: Mention end of support for native debugging on MS-Windows
4488         before XP.
4489
4490         PR gdb/24292
4491         * common/netstuff.c:
4492         * gdbserver/gdbreplay.c
4493         * gdbserver/remote-utils.c:
4494         * ser-tcp.c:
4495         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4496         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4497         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4498         'getaddrinfo' and 'freeaddrinfo' were not available before
4499         Windows XP, and mingw.org's MinGW headers by default define
4500         _WIN32_WINNT to 0x500.
4501
4502 2019-03-01  Gary Benson <gbenson@redhat.com>
4503
4504         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4505
4506 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4507             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4508
4509         PR gdb/8527
4510         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4511         set_sigint_trap, clear_sigint_trap.
4512
4513 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4514
4515         * target.c (target_detach): Clear the regcache and the
4516         frame cache.
4517
4518 2019-02-27  Pedro Alves  <palves@redhat.com>
4519
4520         * utils.c (set_screen_size): When we cap the height/width sizes,
4521         tweak the corresponding command variable to show "unlimited":
4522
4523 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4524             Pedro Alves  <palves@redhat.com>
4525
4526         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4527         before calling rl_set_screen_size.
4528
4529 2019-02-27  Tom Tromey  <tromey@adacore.com>
4530
4531         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4532         define.
4533         * python/py-value.c: Remove Python 2.4 workaround.
4534         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4535         workaround.
4536         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4537         Python 2.4 workaround.
4538         * python/python-internal.h: Remove Python 2.4 comment.
4539         (Py_ssize_t): Don't define.
4540         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4541         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4542         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4543         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4544         * python/python.c (do_start_initialization): Remove Python 2.4
4545         workaround.
4546         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4547         (print_children): Remove Python 2.4 workaround.
4548         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4549         workaround.
4550         (CHARBUFFERPROC_NAME): Remove.
4551         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4552         Python 2.4 workaround.
4553
4554 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4555
4556         * NEWS: Note minimum Python version.
4557
4558 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4559
4560         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4561         code from these functions.  Remove corresponding ifdefs.  Use
4562         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4563         Remove gotos and target of gotos.
4564         (infpy_search_memory): Likewise.
4565
4566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4569         (hppa_gdbarch_init): Don't register deleted functions with
4570         gdbarch.
4571
4572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4575         (h8300_unwind_sp): Delete.
4576         (h8300_dummy_id): Delete.
4577         (h8300_gdbarch_init): Don't register deleted functions with
4578         gdbarch.
4579
4580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4581
4582         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4583         (ft32_unwind_pc): Delete.
4584         (ft32_unwind_sp): Delete.
4585         (ft32_gdbarch_init): Don't register deleted functions with
4586         gdbarch.
4587
4588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4591         (frv_unwind_pc): Delete.
4592         (frv_unwind_sp): Delete.
4593         (frv_gdbarch_init): Don't register deleted functions with
4594         gdbarch.
4595
4596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4599         (riscv_unwind_pc): Delete.
4600         (riscv_unwind_sp): Delete.
4601         (riscv_gdbarch_init): Don't register deleted functions with
4602         gdbarch.
4603
4604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4605
4606         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4607         (csky_unwind_pc): Delete.
4608         (csky_unwind_sp): Delete.
4609         (csky_gdbarch_init): Don't register deleted functions with
4610         gdbarch.
4611
4612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4613
4614         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4615         (cris_unwind_pc): Delete.
4616         (cris_unwind_sp): Delete.
4617         (cris_gdbarch_init): Don't register deleted functions with
4618         gdbarch.
4619
4620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4621
4622         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4623         (bfin_unwind_pc): Delete.
4624         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4625
4626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4627
4628         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4629         (arm_unwind_pc): Delete.
4630         (arm_unwind_sp): Delete.
4631         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4632
4633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4636         (arc_unwind_pc): Delete.
4637         (arc_unwind_sp): Delete.
4638         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4639
4640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4643         (alpha_unwind_pc): Delete.
4644         (alpha_gdbarch_init): Don't register deleted functions with
4645         gdbarch.
4646
4647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4648
4649         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4650         (aarch64_unwind_pc): Delete.
4651         (aarch64_unwind_sp): Delete.
4652         (aarch64_gdbarch_init): Don't register deleted functions with
4653         gdbarch.
4654
4655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * gdbtypes.c (type_align): Don't consider static members when
4658         computing structure alignment.
4659
4660 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4663         return 0 for other types.
4664         * arch-utils.c (default_type_align): Always return 0.
4665         * gdbarch.h: Regenerate.
4666         * gdbarch.sh (type_align): Extend comment.
4667         * gdbtypes.c (type_align): Add additional comments, always call
4668         gdbarch_type_align before applying the default rules.
4669         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4670         generic code will then apply a suitable default.
4671         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4672         types, return 0 for other types.
4673
4674 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4675
4676         * NEWS: Create a new section for the next release branch.
4677         Rename the section of the current branch, now that it has
4678         been cut.
4679
4680 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4681
4682         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4683         * version.in: Bump version to 8.3.50.DATE-git.
4684
4685 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4686
4687         * aix-thread.c (ptid_cmp): Remove unused variable.
4688         (get_signaled_thread): Likewise.
4689         (store_regs_user_thread): Likewise.
4690         (store_regs_kernel_thread): Likewise.
4691         (fetch_regs_kernel_thread): Remove shadowed variable.
4692
4693 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * features/riscv/32bit-cpu.xml: Add register numbers.
4696         * features/riscv/32bit-fpu.c: Regenerate.
4697         * features/riscv/32bit-fpu.xml: Add register numbers.
4698         * features/riscv/64bit-cpu.xml: Add register numbers.
4699         * features/riscv/64bit-fpu.c: Regenerate.
4700         * features/riscv/64bit-fpu.xml: Add register numbers.
4701
4702 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4703
4704         * NEWS: Mention two argument form of gdb.Value constructor.
4705         * python/py-value.c (convert_buffer_and_type_to_value): New
4706         function.
4707         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4708         Add support for handling an optional second argument.  Call
4709         convert_buffer_and_type_to_value as appropriate.
4710         * python/python-internal.h (Py_buffer_deleter): New struct.
4711         (Py_buffer_up): New typedef.
4712
4713 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4714
4715         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4716         instead of releasing ownership.
4717
4718 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4719
4720         * dwarf2read.c (open_and_init_dwp_file): Call
4721         elf_numsections instead of bfd_count_sections to initialize
4722         dwp_file->num_sections.
4723
4724 2019-02-25  Tom Tromey  <tromey@adacore.com>
4725
4726         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4727
4728 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4729
4730         * gcore.in: Add '--readnever' option when invoking GDB.
4731
4732 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4733
4734         * MAINTAINERS: Update my email address.
4735
4736 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4737
4738         * build-id.c (build_id_to_debug_bfd_1): New function.
4739         (build_id_to_debug_bfd): Look for separate debug file in
4740         sysroot.
4741
4742 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4743
4744         * gdbarch.sh: Update the copyright year range that is placed into
4745         generated files.
4746
4747 2019-02-22  Keith Seitz  <keiths@redhat.com>
4748
4749         PR symtab/23853
4750         * linespec.c (create_sals_line_offset): Search for the default
4751         symtab's filename instead of its fullname.
4752
4753 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4754
4755         * NEWS: Update style defaults.
4756
4757 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4758
4759         * main.c (captured_main_1): Disable styling in batch mode.
4760
4761 2019-02-20  Tom Tromey  <tom@tromey.com>
4762
4763         * symtab.c (symtab_symbol_info): Fix typos.
4764
4765 2019-02-20  Tom Tromey  <tromey@adacore.com>
4766
4767         * findcmd.c (_initialize_mem_search): Use upper case for
4768         metasyntactic variables.
4769
4770 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4771
4772         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4773         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4774
4775 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4776
4777         * top.h (source_file_name): Change to std::string.
4778         * top.c (source_file_name): Likewise.
4779         (command_line_input): Adjust.
4780         * cli/cli-script.c (script_from_file): Adjust.
4781
4782 2019-02-19  Tom Tromey  <tromey@adacore.com>
4783
4784         * ravenscar-thread.c
4785         (ravenscar_thread_target::update_thread_list): Don't call
4786         ada_build_task_list.
4787         * ada-lang.h (ada_build_task_list): Don't declare.
4788         * ada-tasks.c (struct ada_tasks_inferior_data)
4789         <task_list_valid_p>: Now bool.
4790         (read_known_tasks, ada_task_list_changed)
4791         (ada_tasks_invalidate_inferior_data): Update.
4792         (read_known_tasks_array): Return bool.
4793         (read_known_tasks_list): Likewise.
4794         (read_known_tasks): Return void.
4795         (ada_build_task_list): Now static.
4796
4797 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4800         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4801
4802 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4803
4804         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4805         variant for ada_tasks_pspace_data_handle and
4806         ada_tasks_inferior_data_handle.
4807         (ada_tasks_pspace_data_cleanup): New function.
4808         (ada_tasks_inferior_data_cleanup): New function.
4809
4810 2019-02-17  Tom Tromey  <tom@tromey.com>
4811
4812         * macrotab.h (macro_source_fullname): Return a std::string.
4813         * macrotab.c (macro_include, check_for_redefinition)
4814         (macro_undef, macro_lookup_definition, foreach_macro)
4815         (foreach_macro_in_scope): Update.
4816         (macro_source_fullname): Return a std::string.
4817         * macrocmd.c (show_pp_source_pos): Update.
4818
4819 2019-02-17  Tom Tromey  <tom@tromey.com>
4820
4821         * macrocmd.c (show_pp_source_pos): Style the file names.
4822
4823 2019-02-17  Tom Tromey  <tom@tromey.com>
4824
4825         PR tui/24197:
4826         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4827
4828 2019-02-17  Tom Tromey  <tom@tromey.com>
4829
4830         * ada-lang.c (user_select_syms): Use filtered printing.
4831         * utils.c (wrap_style): New global.
4832         (desired_style): Remove.
4833         (emit_style_escape): Add stream parameter.
4834         (set_output_style, reset_terminal_style, prompt_for_continue):
4835         Update.
4836         (flush_wrap_buffer): Only flush gdb_stdout.
4837         (wrap_here): Set wrap_style.
4838         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4839         treat escape sequences as a character.  Change when wrap buffer is
4840         flushed.
4841         (fputs_styled): Do not set the output style when the default is
4842         requested.
4843         * ui-style.h (struct ui_file_style) <is_default>: New method.
4844         * source.c (print_source_lines_base): Emit escape sequences in one
4845         piece.
4846
4847 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4848
4849         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4850         integers and enumeration types.
4851
4852 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4853
4854         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4855         instead of lookup_symbol_in_language
4856         (do_exact_match): New function.
4857         (ada_get_symbol_name_matcher): Return do_exact_match when
4858         doing a verbatim match.
4859
4860 2019-02-15  Tom Tromey  <tromey@adacore.com>
4861
4862         * ravenscar-thread.c (ravenscar_thread_target::resume)
4863         (ravenscar_thread_target::wait): Special case wildcard requests.
4864
4865 2019-02-15  Tom Tromey  <tromey@adacore.com>
4866
4867         * ravenscar-thread.c (base_ptid): Remove.
4868         (struct ravenscar_thread_target) <close>: New method.
4869         <m_base_ptid>: New member.
4870         <update_inferior_ptid, active_task, task_is_currently_active,
4871         runtime_initialized>: Declare methods.
4872         <ravenscar_thread_target>: Add constructor.
4873         (ravenscar_thread_target::task_is_currently_active)
4874         (ravenscar_thread_target::update_inferior_ptid)
4875         (ravenscar_runtime_initialized): Rename.  Now methods.
4876         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4877         (ravenscar_thread_target::update_thread_list): Update.
4878         (ravenscar_thread_target::active_task): Now method.
4879         (ravenscar_thread_target::store_registers)
4880         (ravenscar_thread_target::prepare_to_store)
4881         (ravenscar_thread_target::prepare_to_store)
4882         (ravenscar_thread_target::mourn_inferior): Update.
4883         (ravenscar_inferior_created): Use "new" to create target.
4884         (ravenscar_thread_target::get_ada_task_ptid): Update.
4885         (_initialize_ravenscar): Don't initialize base_ptid.
4886         (ravenscar_ops): Remove global.
4887
4888 2019-02-15  Tom Tromey  <tromey@adacore.com>
4889
4890         * target.h (push_target): Declare new overload.
4891         * target.c (push_target): New overload, taking an rvalue reference.
4892         * remote.c (remote_target::open_1): Use push_target overload.
4893         * corelow.c (core_target_open): Use push_target overload.
4894
4895 2019-02-15  Tom Tromey  <tromey@adacore.com>
4896
4897         * ravenscar-thread.c (is_ravenscar_task)
4898         (ravenscar_task_is_currently_active): Return bool.
4899         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4900         (_initialize_ravenscar): Remove "(void)".
4901         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4902         Return bool.
4903
4904 2019-02-15  Tom Tromey  <tromey@adacore.com>
4905
4906         * ravenscar-thread.c (ravenscar_runtime_initializer)
4907         (has_ravenscar_runtime, get_running_thread_id)
4908         (ravenscar_thread_target::resume): Fix indentation.
4909
4910 2019-02-15  Tom Tromey  <tromey@adacore.com>
4911
4912         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4913         from ravenscar_arch_ops.
4914         (sparc_ravenscar_ops::fetch_registers)
4915         (sparc_ravenscar_ops::store_registers): Now methods.
4916         (sparc_ravenscar_prepare_to_store): Remove.
4917         (sparc_ravenscar_ops): Redefine.
4918         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4919         methods and destructor.  Remove members.
4920         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4921         (ravenscar_thread_target::store_registers)
4922         (ravenscar_thread_target::prepare_to_store): Update.
4923         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4924         Remove.
4925         (struct ppc_ravenscar_powerpc_ops): Derive from
4926         ravenscar_arch_ops.
4927         (ppc_ravenscar_powerpc_ops::fetch_registers)
4928         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4929         (ppc_ravenscar_powerpc_ops): Redefine.
4930         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4931         (ppc_ravenscar_e500_ops::fetch_registers)
4932         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4933         (ppc_ravenscar_e500_ops): Redefine.
4934         * aarch64-ravenscar-thread.c
4935         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4936         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4937         (aarch64_ravenscar_fetch_registers)
4938         (aarch64_ravenscar_store_registers): Now methods.
4939         (aarch64_ravenscar_ops): Redefine.
4940
4941 2019-02-15  Tom Tromey  <tromey@adacore.com>
4942
4943         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4944         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4945         (ravenscar_thread_target::stopped_by_watchpoint)
4946         (ravenscar_thread_target::stopped_data_address)
4947         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4948
4949 2019-02-15  Tom Tromey  <tromey@adacore.com>
4950
4951         * ravenscar-thread.c: Fix some typos.
4952
4953 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4954             Tom Tromey  <tromey@adacore.com>
4955
4956         * ada-lang.c (ada_exception_sal): Change addr_string to a
4957         std::string.
4958         (create_ada_exception_catchpoint): Update.
4959
4960 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4961             Tom Tromey  <tromey@adacore.com>
4962
4963         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4964         (bp_location_ops): Remove.
4965         (base_breakpoint_allocate_location): Update.
4966         (free_bp_location): Update.
4967         * ada-lang.c (class ada_catchpoint_location)
4968         <ada_catchpoint_location>: Remove ops parameter.
4969         (ada_catchpoint_location_dtor): Remove.
4970         (ada_catchpoint_location_ops): Remove.
4971         (allocate_location_exception): Update.
4972         * breakpoint.h (struct bp_location_ops): Remove.
4973         (class bp_location) <bp_location>: Remove bp_location_ops
4974         parameter.
4975         <~bp_location>: Add destructor.
4976         <ops>: Remove.
4977
4978 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4979             Pedro Alves  <palves@redhat.com>
4980
4981         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4982         'PATH_MAX'.
4983
4984 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4985             Samuel Thibault  <samuel.thibault@gnu.org>
4986             Thomas Schwinge  <thomas@codesourcery.com>
4987
4988         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4989         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4990
4991 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4992
4993         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4994         (check_empty): Use "const char *".
4995
4996         * gnu-nat.c (gnu_nat_target::detach): Instead of
4997         'detach_inferior (pid)' call
4998         'detach_inferior (find_inferior_pid (pid))'.
4999
5000         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5001         'nat/fork-inferior.o'.
5002         * gnu-nat.c: #include "nat/fork-inferior.h".
5003
5004         * gnu-nat.c (gnu_nat_target::detach): Instead of
5005         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5006         * gnu-nat.h: #include "inf-child.h".
5007         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5008         'i386_gnu_nat_target::fetch_registers'.
5009         (gnu_store_registers): Rename/move to
5010         'i386_gnu_nat_target::store_registers'.
5011
5012         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5013         * gnu-nat.h (mach_thread_info): New function.
5014         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5015
5016         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5017
5018 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5019
5020         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5021
5022 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5023
5024         * windows-nat.c (windows_add_thread): Add new parameter
5025         "main_thread_p" with default value set to false.  Update
5026         function documentation as well as all callers.
5027         (windows_delete_thread): Likewise.
5028         (fake_create_process): Update call to windows_add_thread.
5029         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5030         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5031         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5032         call to windows_delete_thread.
5033
5034 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5035
5036         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5037
5038 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5039
5040         * symfile.c (find_separate_debug_file): Use canonical path of
5041         sysroot with child_path instead of gdb_sysroot if it is valid.
5042
5043 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5044
5045         * symfile.c (find_separate_debug_file): Use child_path to
5046         determine if an object file is under a sysroot.
5047
5048 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5049
5050         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5051         unittests/child-path-selftests.c.
5052         * common/pathstuff.c (child_path): New function.
5053         * common/pathstuff.h (child_path): New prototype.
5054         * unittests/child-path-selftests.c: New file.
5055
5056 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5057
5058         * symfile.c (find_separate_debug_file): Look for separate debug
5059         files in debug directories under the sysroot.
5060
5061 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5062
5063         * symtab.h (struct minimal_symbol data_p): New const method.
5064         (struct minimal_symbol text_p): Likewise.
5065         * symtab.c (output_source_filename): Use file name style
5066         to print file name.
5067         (print_symbol_info): Likewise.
5068         (print_msymbol_info): Use address style to print addresses.
5069         Use function name style to print executable text symbols.
5070         (expand_symtab_containing_pc): Use data_p.
5071         (find_pc_sect_compunit_symtab): Likewise.
5072
5073 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5074
5075         * breakpoint.c (describe_other_breakpoints): Use address style
5076         to print addresses.
5077         (say_where): Likewise.
5078
5079 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5080
5081         * ada-typeprint.c (print_func_type): Print function name
5082         style to print function name.
5083         * c-typeprint.c (c_print_type_1): Likewise.
5084
5085 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5086
5087         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5088         for execve.
5089
5090 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5091
5092         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5093         type_stack.
5094
5095 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5096
5097         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5098         TYPE_CODE_REF types.
5099
5100 2019-02-08  Jim Wilson  <jimw@sifive.com>
5101
5102         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5103         (riscv_linux_fregset): New.
5104         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5105
5106 2019-02-07  Tom Tromey  <tom@tromey.com>
5107
5108         * thread.c (thread_cancel_execution_command): Update.
5109         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5110         methods.
5111         (struct thread_fsm_ops): Remove.
5112         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5113         (thread_fsm_should_stop, thread_fsm_return_value)
5114         (thread_fsm_set_finished, thread_fsm_finished_p)
5115         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5116         Don't declare.
5117         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5118         * infrun.c (clear_proceed_status_thread)
5119         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5120         (print_stop_event): Update.
5121         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5122         Add constructor.
5123         (step_command_fsm_ops): Remove.
5124         (new_step_command_fsm): Remove.
5125         (step_1): Update.
5126         (step_command_fsm::should_stop): Rename from
5127         step_command_fsm_should_stop.
5128         (step_command_fsm::clean_up): Rename from
5129         step_command_fsm_clean_up.
5130         (step_command_fsm::do_async_reply_reason): Rename from
5131         step_command_fsm_async_reply_reason.
5132         (struct until_next_fsm): Inherit from thread_fsm.  Add
5133         constructor.
5134         (until_next_fsm_ops): Remove.
5135         (new_until_next_fsm): Remove.
5136         (until_next_fsm::should_stop): Rename from
5137         until_next_fsm_should_stop.
5138         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5139         (until_next_fsm::do_async_reply_reason): Rename from
5140         until_next_fsm_async_reply_reason.
5141         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5142         constructor.  Change type of breakpoint.
5143         (finish_command_fsm_ops): Remove.
5144         (new_finish_command_fsm): Remove.
5145         (finish_command_fsm::should_stop): Rename from
5146         finish_command_fsm_should_stop.
5147         (finish_command_fsm::clean_up): Rename from
5148         finish_command_fsm_clean_up.
5149         (finish_command_fsm::return_value): Rename from
5150         finish_command_fsm_return_value.
5151         (finish_command_fsm::do_async_reply_reason): Rename from
5152         finish_command_fsm_async_reply_reason.
5153         (finish_command): Update.
5154         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5155         Add constructor.
5156         (call_thread_fsm_ops): Remove.
5157         (call_thread_fsm::call_thread_fsm): Rename from
5158         new_call_thread_fsm.
5159         (call_thread_fsm::should_stop): Rename from
5160         call_thread_fsm_should_stop.
5161         (call_thread_fsm::should_notify_stop): Rename from
5162         call_thread_fsm_should_notify_stop.
5163         (run_inferior_call, call_function_by_hand_dummy): Update.
5164         * cli/cli-interp.c (should_print_stop_to_console): Update.
5165         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5166         Add constructor.  Change type of location_breakpoint,
5167         caller_breakpoint.
5168         (until_break_fsm_ops): Remove.
5169         (new_until_break_fsm): Remove.
5170         (until_break_fsm::should_stop): Rename from
5171         until_break_fsm_should_stop.
5172         (until_break_fsm::clean_up): Rename from
5173         until_break_fsm_clean_up.
5174         (until_break_fsm::do_async_reply_reason): Rename from
5175         until_break_fsm_async_reply_reason.
5176         (until_break_command): Update.
5177         * thread-fsm.c: Remove.
5178         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5179
5180 2019-02-07  Tom Tromey  <tom@tromey.com>
5181
5182         * yy-remap.h: Add include guard.
5183         * xtensa-tdep.h: Add include guard.
5184         * xcoffread.h: Rename include guard.
5185         * varobj-iter.h: Add include guard.
5186         * tui/tui.h: Rename include guard.
5187         * tui/tui-winsource.h: Rename include guard.
5188         * tui/tui-wingeneral.h: Rename include guard.
5189         * tui/tui-windata.h: Rename include guard.
5190         * tui/tui-win.h: Rename include guard.
5191         * tui/tui-stack.h: Rename include guard.
5192         * tui/tui-source.h: Rename include guard.
5193         * tui/tui-regs.h: Rename include guard.
5194         * tui/tui-out.h: Rename include guard.
5195         * tui/tui-layout.h: Rename include guard.
5196         * tui/tui-io.h: Rename include guard.
5197         * tui/tui-hooks.h: Rename include guard.
5198         * tui/tui-file.h: Rename include guard.
5199         * tui/tui-disasm.h: Rename include guard.
5200         * tui/tui-data.h: Rename include guard.
5201         * tui/tui-command.h: Rename include guard.
5202         * tic6x-tdep.h: Add include guard.
5203         * target/waitstatus.h: Rename include guard.
5204         * target/wait.h: Rename include guard.
5205         * target/target.h: Rename include guard.
5206         * target/resume.h: Rename include guard.
5207         * target-float.h: Rename include guard.
5208         * stabsread.h: Add include guard.
5209         * rs6000-tdep.h: Add include guard.
5210         * riscv-fbsd-tdep.h: Add include guard.
5211         * regformats/regdef.h: Rename include guard.
5212         * record.h: Rename include guard.
5213         * python/python.h: Rename include guard.
5214         * python/python-internal.h: Rename include guard.
5215         * python/py-stopevent.h: Rename include guard.
5216         * python/py-ref.h: Rename include guard.
5217         * python/py-record.h: Rename include guard.
5218         * python/py-record-full.h: Rename include guard.
5219         * python/py-record-btrace.h: Rename include guard.
5220         * python/py-instruction.h: Rename include guard.
5221         * python/py-events.h: Rename include guard.
5222         * python/py-event.h: Rename include guard.
5223         * procfs.h: Add include guard.
5224         * proc-utils.h: Add include guard.
5225         * p-lang.h: Add include guard.
5226         * or1k-tdep.h: Rename include guard.
5227         * observable.h: Rename include guard.
5228         * nto-tdep.h: Rename include guard.
5229         * nat/x86-linux.h: Rename include guard.
5230         * nat/x86-linux-dregs.h: Rename include guard.
5231         * nat/x86-gcc-cpuid.h: Add include guard.
5232         * nat/x86-dregs.h: Rename include guard.
5233         * nat/x86-cpuid.h: Rename include guard.
5234         * nat/ppc-linux.h: Rename include guard.
5235         * nat/mips-linux-watch.h: Rename include guard.
5236         * nat/linux-waitpid.h: Rename include guard.
5237         * nat/linux-ptrace.h: Rename include guard.
5238         * nat/linux-procfs.h: Rename include guard.
5239         * nat/linux-osdata.h: Rename include guard.
5240         * nat/linux-nat.h: Rename include guard.
5241         * nat/linux-namespaces.h: Rename include guard.
5242         * nat/linux-btrace.h: Rename include guard.
5243         * nat/glibc_thread_db.h: Rename include guard.
5244         * nat/gdb_thread_db.h: Rename include guard.
5245         * nat/gdb_ptrace.h: Rename include guard.
5246         * nat/fork-inferior.h: Rename include guard.
5247         * nat/amd64-linux-siginfo.h: Rename include guard.
5248         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5249         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5250         * nat/aarch64-linux.h: Rename include guard.
5251         * nat/aarch64-linux-hw-point.h: Rename include guard.
5252         * mn10300-tdep.h: Add include guard.
5253         * mips-linux-tdep.h: Add include guard.
5254         * mi/mi-parse.h: Rename include guard.
5255         * mi/mi-out.h: Rename include guard.
5256         * mi/mi-main.h: Rename include guard.
5257         * mi/mi-interp.h: Rename include guard.
5258         * mi/mi-getopt.h: Rename include guard.
5259         * mi/mi-console.h: Rename include guard.
5260         * mi/mi-common.h: Rename include guard.
5261         * mi/mi-cmds.h: Rename include guard.
5262         * mi/mi-cmd-break.h: Rename include guard.
5263         * m2-lang.h: Add include guard.
5264         * location.h: Rename include guard.
5265         * linux-record.h: Rename include guard.
5266         * linux-nat.h: Add include guard.
5267         * linux-fork.h: Add include guard.
5268         * i386-darwin-tdep.h: Rename include guard.
5269         * hppa-linux-offsets.h: Add include guard.
5270         * guile/guile.h: Rename include guard.
5271         * guile/guile-internal.h: Rename include guard.
5272         * gnu-nat.h: Rename include guard.
5273         * gdb-stabs.h: Rename include guard.
5274         * frv-tdep.h: Add include guard.
5275         * f-lang.h: Add include guard.
5276         * event-loop.h: Add include guard.
5277         * darwin-nat.h: Rename include guard.
5278         * cp-abi.h: Rename include guard.
5279         * config/sparc/nm-sol2.h: Rename include guard.
5280         * config/nm-nto.h: Rename include guard.
5281         * config/nm-linux.h: Add include guard.
5282         * config/i386/nm-i386gnu.h: Rename include guard.
5283         * config/djgpp/nl_types.h: Rename include guard.
5284         * config/djgpp/langinfo.h: Rename include guard.
5285         * compile/gcc-cp-plugin.h: Add include guard.
5286         * compile/gcc-c-plugin.h: Add include guard.
5287         * compile/compile.h: Rename include guard.
5288         * compile/compile-object-run.h: Rename include guard.
5289         * compile/compile-object-load.h: Rename include guard.
5290         * compile/compile-internal.h: Rename include guard.
5291         * compile/compile-cplus.h: Rename include guard.
5292         * compile/compile-c.h: Rename include guard.
5293         * common/xml-utils.h: Rename include guard.
5294         * common/x86-xstate.h: Rename include guard.
5295         * common/version.h: Rename include guard.
5296         * common/vec.h: Rename include guard.
5297         * common/tdesc.h: Rename include guard.
5298         * common/selftest.h: Rename include guard.
5299         * common/scoped_restore.h: Rename include guard.
5300         * common/scoped_mmap.h: Rename include guard.
5301         * common/scoped_fd.h: Rename include guard.
5302         * common/safe-iterator.h: Rename include guard.
5303         * common/run-time-clock.h: Rename include guard.
5304         * common/refcounted-object.h: Rename include guard.
5305         * common/queue.h: Rename include guard.
5306         * common/ptid.h: Rename include guard.
5307         * common/print-utils.h: Rename include guard.
5308         * common/preprocessor.h: Rename include guard.
5309         * common/pathstuff.h: Rename include guard.
5310         * common/observable.h: Rename include guard.
5311         * common/netstuff.h: Rename include guard.
5312         * common/job-control.h: Rename include guard.
5313         * common/host-defs.h: Rename include guard.
5314         * common/gdb_wait.h: Rename include guard.
5315         * common/gdb_vecs.h: Rename include guard.
5316         * common/gdb_unlinker.h: Rename include guard.
5317         * common/gdb_unique_ptr.h: Rename include guard.
5318         * common/gdb_tilde_expand.h: Rename include guard.
5319         * common/gdb_sys_time.h: Rename include guard.
5320         * common/gdb_string_view.h: Rename include guard.
5321         * common/gdb_splay_tree.h: Rename include guard.
5322         * common/gdb_setjmp.h: Rename include guard.
5323         * common/gdb_ref_ptr.h: Rename include guard.
5324         * common/gdb_optional.h: Rename include guard.
5325         * common/gdb_locale.h: Rename include guard.
5326         * common/gdb_assert.h: Rename include guard.
5327         * common/filtered-iterator.h: Rename include guard.
5328         * common/filestuff.h: Rename include guard.
5329         * common/fileio.h: Rename include guard.
5330         * common/environ.h: Rename include guard.
5331         * common/common-utils.h: Rename include guard.
5332         * common/common-types.h: Rename include guard.
5333         * common/common-regcache.h: Rename include guard.
5334         * common/common-inferior.h: Rename include guard.
5335         * common/common-gdbthread.h: Rename include guard.
5336         * common/common-exceptions.h: Rename include guard.
5337         * common/common-defs.h: Rename include guard.
5338         * common/common-debug.h: Rename include guard.
5339         * common/cleanups.h: Rename include guard.
5340         * common/buffer.h: Rename include guard.
5341         * common/btrace-common.h: Rename include guard.
5342         * common/break-common.h: Rename include guard.
5343         * cli/cli-utils.h: Rename include guard.
5344         * cli/cli-style.h: Rename include guard.
5345         * cli/cli-setshow.h: Rename include guard.
5346         * cli/cli-script.h: Rename include guard.
5347         * cli/cli-interp.h: Rename include guard.
5348         * cli/cli-decode.h: Rename include guard.
5349         * cli/cli-cmds.h: Rename include guard.
5350         * charset-list.h: Add include guard.
5351         * buildsym-legacy.h: Rename include guard.
5352         * bfin-tdep.h: Add include guard.
5353         * ax.h: Rename include guard.
5354         * arm-linux-tdep.h: Add include guard.
5355         * arm-fbsd-tdep.h: Add include guard.
5356         * arch/xtensa.h: Rename include guard.
5357         * arch/tic6x.h: Add include guard.
5358         * arch/i386.h: Add include guard.
5359         * arch/arm.h: Rename include guard.
5360         * arch/arm-linux.h: Rename include guard.
5361         * arch/arm-get-next-pcs.h: Rename include guard.
5362         * arch/amd64.h: Add include guard.
5363         * arch/aarch64-insn.h: Rename include guard.
5364         * arch-utils.h: Rename include guard.
5365         * annotate.h: Add include guard.
5366         * amd64-darwin-tdep.h: Rename include guard.
5367         * aarch64-linux-tdep.h: Add include guard.
5368         * aarch64-fbsd-tdep.h: Add include guard.
5369         * aarch32-linux-nat.h: Add include guard.
5370
5371 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5372
5373         * macrotab.c (macro_define_internal): New function that
5374         factorizes macro_define_object_internal and macro_define_function
5375         code.
5376         (macro_define_object_internal): Use macro_define_internal.
5377         (macro_define_function): Likewise.
5378
5379 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5380
5381         * macrocmd.c (extract_identifier): Return
5382         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5383         callers.
5384
5385 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5386
5387         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5388
5389 2019-02-05  Tom Tromey  <tom@tromey.com>
5390
5391         * target.c (target_stack::unpush): Move assertion earlier.
5392
5393 2019-01-30  Tom Tromey  <tom@tromey.com>
5394
5395         PR python/23615:
5396         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5397         (gdbpy_parse_and_eval): Likewise.
5398         * python/python-internal.h (gdbpy_allow_threads): New class.
5399
5400 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5401
5402         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5403         (aarch64_fbsd_fpregmap): Move earlier.
5404         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5405         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5406         instead of individual calls to trad_frame_set_reg_addr.
5407         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5408         earlier.
5409         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5410         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5411         instead of individual calls to trad_frame_set_reg_addr.
5412
5413 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5414
5415         * CONTRIBUTE: Replace contribution list with wiki link.
5416
5417 2019-01-25  Tom Tromey  <tom@tromey.com>
5418
5419         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5420
5421 2019-01-25  Tom Tromey  <tom@tromey.com>
5422
5423         * xtensa-linux-nat.c: Fix common/ includes.
5424         * xml-support.h: Fix common/ includes.
5425         * xml-support.c: Fix common/ includes.
5426         * x86-linux-nat.c: Fix common/ includes.
5427         * windows-nat.c: Fix common/ includes.
5428         * varobj.h: Fix common/ includes.
5429         * varobj.c: Fix common/ includes.
5430         * value.c: Fix common/ includes.
5431         * valops.c: Fix common/ includes.
5432         * utils.c: Fix common/ includes.
5433         * unittests/xml-utils-selftests.c: Fix common/ includes.
5434         * unittests/utils-selftests.c: Fix common/ includes.
5435         * unittests/unpack-selftests.c: Fix common/ includes.
5436         * unittests/tracepoint-selftests.c: Fix common/ includes.
5437         * unittests/style-selftests.c: Fix common/ includes.
5438         * unittests/string_view-selftests.c: Fix common/ includes.
5439         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5440         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5441         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5442         * unittests/rsp-low-selftests.c: Fix common/ includes.
5443         * unittests/parse-connection-spec-selftests.c: Fix common/
5444         includes.
5445         * unittests/optional-selftests.c: Fix common/ includes.
5446         * unittests/offset-type-selftests.c: Fix common/ includes.
5447         * unittests/observable-selftests.c: Fix common/ includes.
5448         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5449         * unittests/memrange-selftests.c: Fix common/ includes.
5450         * unittests/memory-map-selftests.c: Fix common/ includes.
5451         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5452         * unittests/function-view-selftests.c: Fix common/ includes.
5453         * unittests/environ-selftests.c: Fix common/ includes.
5454         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5455         * unittests/common-utils-selftests.c: Fix common/ includes.
5456         * unittests/cli-utils-selftests.c: Fix common/ includes.
5457         * unittests/array-view-selftests.c: Fix common/ includes.
5458         * ui-file.c: Fix common/ includes.
5459         * tui/tui-io.c: Fix common/ includes.
5460         * tracepoint.h: Fix common/ includes.
5461         * tracepoint.c: Fix common/ includes.
5462         * tracefile-tfile.c: Fix common/ includes.
5463         * top.h: Fix common/ includes.
5464         * top.c: Fix common/ includes.
5465         * thread.c: Fix common/ includes.
5466         * target/waitstatus.h: Fix common/ includes.
5467         * target/waitstatus.c: Fix common/ includes.
5468         * target.h: Fix common/ includes.
5469         * target.c: Fix common/ includes.
5470         * target-memory.c: Fix common/ includes.
5471         * target-descriptions.c: Fix common/ includes.
5472         * symtab.h: Fix common/ includes.
5473         * symfile.c: Fix common/ includes.
5474         * stap-probe.c: Fix common/ includes.
5475         * spu-linux-nat.c: Fix common/ includes.
5476         * sparc-nat.c: Fix common/ includes.
5477         * source.c: Fix common/ includes.
5478         * solib.c: Fix common/ includes.
5479         * solib-target.c: Fix common/ includes.
5480         * ser-unix.c: Fix common/ includes.
5481         * ser-tcp.c: Fix common/ includes.
5482         * ser-pipe.c: Fix common/ includes.
5483         * ser-base.c: Fix common/ includes.
5484         * selftest-arch.c: Fix common/ includes.
5485         * s12z-tdep.c: Fix common/ includes.
5486         * rust-exp.y: Fix common/ includes.
5487         * rs6000-aix-tdep.c: Fix common/ includes.
5488         * riscv-tdep.c: Fix common/ includes.
5489         * remote.c: Fix common/ includes.
5490         * remote-notif.h: Fix common/ includes.
5491         * remote-fileio.h: Fix common/ includes.
5492         * remote-fileio.c: Fix common/ includes.
5493         * regcache.h: Fix common/ includes.
5494         * regcache.c: Fix common/ includes.
5495         * record-btrace.c: Fix common/ includes.
5496         * python/python.c: Fix common/ includes.
5497         * python/py-type.c: Fix common/ includes.
5498         * python/py-inferior.c: Fix common/ includes.
5499         * progspace.h: Fix common/ includes.
5500         * producer.c: Fix common/ includes.
5501         * procfs.c: Fix common/ includes.
5502         * proc-api.c: Fix common/ includes.
5503         * printcmd.c: Fix common/ includes.
5504         * ppc-linux-nat.c: Fix common/ includes.
5505         * parser-defs.h: Fix common/ includes.
5506         * osdata.c: Fix common/ includes.
5507         * obsd-nat.c: Fix common/ includes.
5508         * nat/x86-linux.c: Fix common/ includes.
5509         * nat/x86-linux-dregs.c: Fix common/ includes.
5510         * nat/x86-dregs.h: Fix common/ includes.
5511         * nat/x86-dregs.c: Fix common/ includes.
5512         * nat/ppc-linux.c: Fix common/ includes.
5513         * nat/mips-linux-watch.h: Fix common/ includes.
5514         * nat/mips-linux-watch.c: Fix common/ includes.
5515         * nat/linux-waitpid.c: Fix common/ includes.
5516         * nat/linux-ptrace.h: Fix common/ includes.
5517         * nat/linux-ptrace.c: Fix common/ includes.
5518         * nat/linux-procfs.c: Fix common/ includes.
5519         * nat/linux-personality.c: Fix common/ includes.
5520         * nat/linux-osdata.c: Fix common/ includes.
5521         * nat/linux-namespaces.c: Fix common/ includes.
5522         * nat/linux-btrace.h: Fix common/ includes.
5523         * nat/linux-btrace.c: Fix common/ includes.
5524         * nat/fork-inferior.c: Fix common/ includes.
5525         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5526         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5527         * nat/aarch64-linux.c: Fix common/ includes.
5528         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5529         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5530         * namespace.h: Fix common/ includes.
5531         * mips-linux-tdep.c: Fix common/ includes.
5532         * minsyms.c: Fix common/ includes.
5533         * mi/mi-parse.h: Fix common/ includes.
5534         * mi/mi-main.c: Fix common/ includes.
5535         * mi/mi-cmd-env.c: Fix common/ includes.
5536         * memrange.h: Fix common/ includes.
5537         * memattr.c: Fix common/ includes.
5538         * maint.h: Fix common/ includes.
5539         * maint.c: Fix common/ includes.
5540         * main.c: Fix common/ includes.
5541         * machoread.c: Fix common/ includes.
5542         * location.c: Fix common/ includes.
5543         * linux-thread-db.c: Fix common/ includes.
5544         * linux-nat.c: Fix common/ includes.
5545         * linux-fork.c: Fix common/ includes.
5546         * inline-frame.c: Fix common/ includes.
5547         * infrun.c: Fix common/ includes.
5548         * inflow.c: Fix common/ includes.
5549         * inferior.h: Fix common/ includes.
5550         * inferior.c: Fix common/ includes.
5551         * infcmd.c: Fix common/ includes.
5552         * inf-ptrace.c: Fix common/ includes.
5553         * inf-child.c: Fix common/ includes.
5554         * ia64-linux-nat.c: Fix common/ includes.
5555         * i387-tdep.c: Fix common/ includes.
5556         * i386-tdep.c: Fix common/ includes.
5557         * i386-linux-tdep.c: Fix common/ includes.
5558         * i386-linux-nat.c: Fix common/ includes.
5559         * i386-go32-tdep.c: Fix common/ includes.
5560         * i386-fbsd-tdep.c: Fix common/ includes.
5561         * i386-fbsd-nat.c: Fix common/ includes.
5562         * guile/scm-type.c: Fix common/ includes.
5563         * guile/guile.c: Fix common/ includes.
5564         * go32-nat.c: Fix common/ includes.
5565         * gnu-nat.c: Fix common/ includes.
5566         * gdbthread.h: Fix common/ includes.
5567         * gdbarch-selftests.c: Fix common/ includes.
5568         * gdb_usleep.c: Fix common/ includes.
5569         * gdb_select.h: Fix common/ includes.
5570         * gdb_bfd.c: Fix common/ includes.
5571         * gcore.c: Fix common/ includes.
5572         * fork-child.c: Fix common/ includes.
5573         * findvar.c: Fix common/ includes.
5574         * fbsd-nat.c: Fix common/ includes.
5575         * event-top.c: Fix common/ includes.
5576         * event-loop.c: Fix common/ includes.
5577         * dwarf2read.c: Fix common/ includes.
5578         * dwarf2loc.c: Fix common/ includes.
5579         * dwarf2-frame.c: Fix common/ includes.
5580         * dwarf-index-cache.c: Fix common/ includes.
5581         * dtrace-probe.c: Fix common/ includes.
5582         * disasm-selftests.c: Fix common/ includes.
5583         * defs.h: Fix common/ includes.
5584         * csky-tdep.c: Fix common/ includes.
5585         * cp-valprint.c: Fix common/ includes.
5586         * cp-support.h: Fix common/ includes.
5587         * cp-support.c: Fix common/ includes.
5588         * corelow.c: Fix common/ includes.
5589         * completer.h: Fix common/ includes.
5590         * completer.c: Fix common/ includes.
5591         * compile/compile.c: Fix common/ includes.
5592         * compile/compile-loc2c.c: Fix common/ includes.
5593         * compile/compile-cplus-types.c: Fix common/ includes.
5594         * compile/compile-cplus-symbols.c: Fix common/ includes.
5595         * command.h: Fix common/ includes.
5596         * cli/cli-dump.c: Fix common/ includes.
5597         * cli/cli-cmds.c: Fix common/ includes.
5598         * charset.c: Fix common/ includes.
5599         * build-id.c: Fix common/ includes.
5600         * btrace.h: Fix common/ includes.
5601         * btrace.c: Fix common/ includes.
5602         * breakpoint.h: Fix common/ includes.
5603         * breakpoint.c: Fix common/ includes.
5604         * ax.h:
5605         (enum agent_op): Fix common/ includes.
5606         * ax-general.c (struct aop_map): Fix common/ includes.
5607         * ax-gdb.c: Fix common/ includes.
5608         * auxv.c: Fix common/ includes.
5609         * auto-load.c: Fix common/ includes.
5610         * arm-tdep.c: Fix common/ includes.
5611         * arch/riscv.c: Fix common/ includes.
5612         * arch/ppc-linux-common.c: Fix common/ includes.
5613         * arch/i386.c: Fix common/ includes.
5614         * arch/arm.c: Fix common/ includes.
5615         * arch/arm-linux.c: Fix common/ includes.
5616         * arch/arm-get-next-pcs.c: Fix common/ includes.
5617         * arch/amd64.c: Fix common/ includes.
5618         * arch/aarch64.c: Fix common/ includes.
5619         * arch/aarch64-insn.c: Fix common/ includes.
5620         * arch-utils.c: Fix common/ includes.
5621         * amd64-windows-tdep.c: Fix common/ includes.
5622         * amd64-tdep.c: Fix common/ includes.
5623         * amd64-sol2-tdep.c: Fix common/ includes.
5624         * amd64-obsd-tdep.c: Fix common/ includes.
5625         * amd64-nbsd-tdep.c: Fix common/ includes.
5626         * amd64-linux-tdep.c: Fix common/ includes.
5627         * amd64-linux-nat.c: Fix common/ includes.
5628         * amd64-fbsd-tdep.c: Fix common/ includes.
5629         * amd64-fbsd-nat.c: Fix common/ includes.
5630         * amd64-dicos-tdep.c: Fix common/ includes.
5631         * amd64-darwin-tdep.c: Fix common/ includes.
5632         * agent.c: Fix common/ includes.
5633         * ada-lang.h: Fix common/ includes.
5634         * ada-lang.c: Fix common/ includes.
5635         * aarch64-tdep.c: Fix common/ includes.
5636
5637 2019-01-25  Tom Tromey  <tom@tromey.com>
5638
5639         * common/create-version.sh: Use common/version.h.
5640
5641 2019-01-24  Pedro Alves  <palves@redhat.com>
5642
5643         * infrun.c (signal_stop, signal_print, signal_program)
5644         (signal_catch, signal_pass): Now arrays instead of pointers.
5645         (update_signals_program_target, do_target_resume)
5646         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5647         * linux-nat.c (linux_nat_target::pass_signals)
5648         (linux_nat_target::create_inferior, linux_nat_target::attach):
5649         Adjust.
5650         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5651         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5652         * procfs.c (procfs_target::pass_signals): Adjust.
5653         * record-full.c (record_full_target::resume): Adjust.
5654         * remote.c (remote_target::pass_signals)
5655         (remote_target::program_signals): Adjust.
5656         * target-debug.h (target_debug_print_signals): Now takes a
5657         gdb::array_view as parameter.  Adjust.
5658         * target.h (target_ops) <pass_signals, program_signals>: Replace
5659         pointer and length parameters with gdb::array_view.
5660         (target_pass_signals, target_program_signals): Likewise.
5661         * target-delegates.c: Regenerate.
5662
5663 2019-01-24  Pedro Alves  <palves@redhat.com>
5664
5665         * common/forward-scope-exit.h
5666         (forward_scope_exit::forward_scope_exit): Pass arguments to
5667         m_bind_function directly, instead of creating a std::bind and
5668         copying that.
5669
5670 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5671
5672         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5673         for static members.
5674         (pass_in_v_vfp_candidate): Likewise.
5675
5676 2019-01-23  Tom Tromey  <tom@tromey.com>
5677             Pedro Alves  <palves@redhat.com>
5678
5679         * regcache.c (class regcache_invalidator): Remove.
5680         (regcache::raw_write): Use make_scope_exit.
5681
5682 2019-01-23  Tom Tromey  <tom@tromey.com>
5683
5684         * ui-out.h (class ui_out_emit_type): Update comment.
5685
5686 2019-01-23  Tom Tromey  <tom@tromey.com>
5687
5688         * infrun.c (fetch_inferior_event): Update comment.
5689
5690 2019-01-23  Tom Tromey  <tom@tromey.com>
5691             Pedro Alves  <palves@redhat.com>
5692
5693         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5694         parameter.
5695         (fetch_inferior_event): Use SCOPE_EXIT.
5696
5697
5698 2019-01-23  Tom Tromey  <tom@tromey.com>
5699             Pedro Alves  <palves@redhat.com>
5700
5701         * infrun.c (disable_thread_events): Delete.
5702         (stop_all_threads): Use SCOPE_EXIT.
5703
5704 2019-01-23  Tom Tromey  <tom@tromey.com>
5705             Pedro Alves  <palves@redhat.com>
5706
5707         * symfile.c: Include forward-scope-exit.h.
5708         (clear_symtab_users_cleanup): Replace forward declaration with
5709         a FORWARD_SCOPE_EXIT.
5710         (syms_from_objfile_1): Use the forward_scope_exit and
5711         gdb::optional instead of cleanup_function.
5712         (reread_symbols): Use the forward_scope_exit instead of
5713         cleanup_function.
5714         (clear_symtab_users_cleanup): Remove function.
5715
5716 2019-01-23  Tom Tromey  <tom@tromey.com>
5717             Pedro Alves  <palves@redhat.com>
5718
5719         * linux-nat.c: Include scope-exit.h.
5720         (cleanup_target_stop): Remove.
5721         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5722         SCOPE_EXIT.
5723
5724 2019-01-23  Tom Tromey  <tom@tromey.com>
5725             Pedro Alves  <palves@redhat.com>
5726
5727         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5728         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5729
5730 2019-01-23  Tom Tromey  <tom@tromey.com>
5731             Andrew Burgess  <andrew.burgess@embecosm.com>
5732             Pedro Alves  <palves@redhat.com>
5733
5734         * infrun.c (fetch_inferior_event): Use scope_exit.
5735         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5736         * top.c (execute_command): Use scope_exit.
5737         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5738         * utils.c (do_bpstat_clear_actions_cleanup)
5739         (make_bpstat_clear_actions_cleanup): Remove.
5740
5741 2019-01-23  Tom Tromey  <tom@tromey.com>
5742             Pedro Alves  <palves@redhat.com>
5743
5744         * infrun.c: Include "common/scope-exit.h"
5745         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5746         (wait_for_inferior): Use SCOPE_EXIT.
5747         (fetch_inferior_event): Use scope_exit.
5748
5749 2019-01-23  Tom Tromey  <tom@tromey.com>
5750             Pedro Alves  <palves@redhat.com>
5751
5752         * breakpoint.c (create_breakpoint): Remove cleanup.
5753
5754 2019-01-23  Tom Tromey  <tom@tromey.com>
5755             Andrew Burgess  <andrew.burgess@embecosm.com>
5756             Pedro Alves  <palves@redhat.com>
5757
5758 2019-01-23  Pedro Alves  <palves@redhat.com>
5759
5760         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5761
5762 2019-01-23  Pedro Alves  <palves@redhat.com>
5763             Andrew Burgess  <andrew.burgess@embecosm.com>
5764
5765         * gdbthread.h: Include "common/forward-scope-exit.h".
5766         (scoped_finish_thread_state): Redefine custom class in terms of
5767         forward_scope_exit.
5768
5769 2019-01-23  Pedro Alves  <palves@redhat.com>
5770             Andrew Burgess  <andrew.burgess@embecosm.com>
5771
5772         * common/forward-scope-exit.h: New file.
5773
5774 2019-01-23  Pedro Alves  <palves@redhat.com>
5775             Andrew Burgess  <andrew.burgess@embecosm.com>
5776             Tom Tromey  <tom@tromey.com>
5777
5778         * common/scope-exit.h: New file.
5779
5780 2019-01-23  Pedro Alves  <palves@redhat.com>
5781
5782         * common/preprocessor.h (ESC): Rename to ...
5783         (ESC_PARENS): ... this.
5784         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5785         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5786
5787 2019-01-23  Tom Tromey  <tom@tromey.com>
5788
5789         * language.h (class scoped_switch_to_sym_language_if_auto):
5790         Initialize m_lang in both cases.
5791
5792 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5793
5794         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5795         with XCNEW.
5796
5797 2019-01-22  Tom Tromey  <tom@tromey.com>
5798
5799         * corelow.c: Do not include sys/file.h.
5800
5801 2019-01-22  Tom Tromey  <tom@tromey.com>
5802
5803         * tui/tui-wingeneral.h: Include gdb_curses.h.
5804
5805 2019-01-22  Tom Tromey  <tom@tromey.com>
5806
5807         * source-cache.h (class source_cache) <get_source_lines,
5808         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5809
5810 2019-01-22  Tom Tromey  <tom@tromey.com>
5811
5812         * remote-fileio.h (struct remote_target): Declare.
5813
5814 2019-01-22  Tom Tromey  <tom@tromey.com>
5815
5816         * python/py-arch.c: Do not include py-ref.h.
5817         * python/py-bpevent.c: Do not include py-ref.h.
5818         * python/py-cmd.c: Do not include py-ref.h.
5819         * python/py-continueevent.c: Do not include py-ref.h.
5820         * python/py-event.h: Do not include py-ref.h.
5821         * python/py-evtregistry.c: Do not include py-ref.h.
5822         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5823         * python/py-frame.c: Do not include py-ref.h.
5824         * python/py-framefilter.c: Do not include py-ref.h.
5825         * python/py-function.c: Do not include py-ref.h.
5826         * python/py-infevents.c: Do not include py-ref.h.
5827         * python/py-linetable.c: Do not include py-ref.h.
5828         * python/py-objfile.c: Do not include py-ref.h.
5829         * python/py-param.c: Do not include py-ref.h.
5830         * python/py-prettyprint.c: Do not include py-ref.h.
5831         * python/py-progspace.c: Do not include py-ref.h.
5832         * python/py-symbol.c: Do not include py-ref.h.
5833         * python/py-symtab.c: Do not include py-ref.h.
5834         * python/py-type.c: Do not include py-ref.h.
5835         * python/py-unwind.c: Do not include py-ref.h.
5836         * python/py-utils.c: Do not include py-ref.h.
5837         * python/py-value.c: Do not include py-ref.h.
5838         * python/py-varobj.c: Do not include py-ref.h.
5839         * python/py-xmethods.c: Do not include py-ref.h.
5840         * python/python.c: Do not include py-ref.h.
5841         * varobj.c: Do not include py-ref.h.
5842
5843 2019-01-22  Tom Tromey  <tom@tromey.com>
5844
5845         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5846         keyword for bcache.
5847
5848 2019-01-22  Tom Tromey  <tom@tromey.com>
5849
5850         * compile/compile-cplus-types.c: Remove a comment by #include.
5851
5852 2019-01-22  Tom Tromey  <tom@tromey.com>
5853
5854         * compile/gcc-c-plugin.h: Include compile-internal.h.
5855
5856 2019-01-22  Tom Tromey  <tom@tromey.com>
5857
5858         * stabsread.c (EXTERN): Do not define.
5859         (symnum, next_symbol_text_func, processing_gcc_compilation)
5860         (within_function, global_sym_chain, global_stabs)
5861         (previous_stab_code, this_object_header_files)
5862         (n_this_object_header_files)
5863         (n_allocated_this_object_header_files): Define.
5864         * stabsread.h (EXTERN): Never define.  Use "extern".
5865
5866 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5867
5868         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5869         history_value.
5870
5871 2019-01-21  Tom Tromey  <tom@tromey.com>
5872
5873         * ui-out.c: Fix includes.
5874         * tui/tui-source.c: Fix includes.
5875         * target.c: Fix includes.
5876         * remote.c: Fix includes.
5877         * regcache.c: Fix includes.
5878         * python/py-block.c: Fix includes.
5879         * printcmd.c: Fix includes.
5880         * or1k-tdep.c: Fix includes.
5881         * mi/mi-main.c: Fix includes.
5882         * m32r-tdep.c: Fix includes.
5883         * csky-tdep.c: Fix includes.
5884         * compile/compile-cplus-types.c: Fix includes.
5885         * cli/cli-interp.c: Fix includes.
5886
5887 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5888
5889         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5890         for padding.
5891
5892 2019-01-16  Tom Tromey  <tom@tromey.com>
5893
5894         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5895         earlier.
5896         (struct objfile) <msymbols_range>: Move from top level.
5897         <msymbols>: New method.
5898         (class objfile_msymbols): Remove.
5899         * symtab.c (default_collect_symbol_completion_matches_break_on):
5900         Update.
5901         * symmisc.c (dump_msymbols): Update.
5902         * stabsread.c (scan_file_globals): Update.
5903         * objc-lang.c (info_selectors_command, info_classes_command)
5904         (find_methods): Update.
5905         * minsyms.c (find_solib_trampoline_target): Update.
5906         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5907         * coffread.c (coff_symfile_read): Update.
5908         * ada-lang.c (ada_lookup_simple_minsym)
5909         (ada_collect_symbol_completion_matches): Update.
5910
5911 2019-01-16  Tom Tromey  <tom@tromey.com>
5912
5913         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5914         type.  Remove no-argument constructor.
5915         <iterator::operator++>: Simplify.
5916         <begin>: Update.
5917         <end>: Use minimal_symbol_count.
5918
5919 2019-01-16  Tom Tromey  <tom@tromey.com>
5920
5921         * objfiles.h (struct objfile) <psymtabs>: New method.
5922         (class objfile_psymtabs): Remove.
5923         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5924         typedef.
5925         <range>: New method.
5926         (require_partial_symbols): Change return type.
5927         * psymtab.c (require_partial_symbols)
5928         (psym_expand_symtabs_matching): Update.
5929         * mdebugread.c (parse_partial_symbols): Update.
5930         * dbxread.c (dbx_end_psymtab): Update.
5931
5932 2019-01-15  Tom Tromey  <tom@tromey.com>
5933
5934         * symtab.c (lookup_objfile_from_block)
5935         (lookup_symbol_in_objfile_symtabs)
5936         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5937         (find_line_symtab, info_sources_command)
5938         (default_collect_symbol_completion_matches_break_on)
5939         (make_source_files_completion_list): Update.
5940         * symmisc.c (print_objfile_statistics, dump_objfile)
5941         (maintenance_print_symbols, maintenance_info_symtabs)
5942         (maintenance_check_symtabs, maintenance_info_line_tables):
5943         Update.
5944         * source.c (select_source_symtab)
5945         (forget_cached_source_info_for_objfile): Update.
5946         * objfiles.h (class objfile_compunits): Remove.
5947         (struct objfile) <compunits_range>: New typedef.
5948         (compunits): New method.
5949         * objfiles.c (objfile_relocate1): Update.
5950         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5951         * maint.c (count_symtabs_and_blocks): Update.
5952         * linespec.c (iterate_over_all_matching_symtabs): Update.
5953         * cp-support.c (add_symbol_overload_list_qualified): Update.
5954         * coffread.c (coff_symtab_read): Update.
5955         * ada-lang.c (add_nonlocal_symbols)
5956         (ada_collect_symbol_completion_matches)
5957         (ada_add_global_exceptions): Update.
5958
5959 2019-01-15  Tom Tromey  <tom@tromey.com>
5960
5961         * progspace.h (program_space) <objfiles_safe_range>: New
5962         typedef.
5963         <objfiles_safe>: New method.
5964         * objfiles.h (class all_objfiles_safe): Remove.
5965         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5966         * jit.c (jit_inferior_exit_hook): Update.
5967
5968 2019-01-17  Tom Tromey  <tom@tromey.com>
5969
5970         * progspace.h (program_space) <objfiles_range>: New typedef.
5971         <objfiles>: New method.
5972         <objfiles_head>: Rename from objfiles.
5973         (object_files): Update.
5974         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5975         * guile/scm-pretty-print.c
5976         (ppscm_find_pretty_printer_from_objfiles): Update.
5977         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5978         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5979         Update.
5980         * python/py-progspace.c (pspy_get_objfiles): Update.
5981         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5982         Update.
5983         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5984         (objfpy_lookup_objfile_by_build_id): Update.
5985         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5986         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5987         Update.
5988         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5989         (expand_symtab_containing_pc, lookup_objfile_from_block)
5990         (lookup_static_symbol, basic_lookup_transparent_type)
5991         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5992         (find_line_symtab, info_sources_command)
5993         (default_collect_symbol_completion_matches_break_on)
5994         (make_source_files_completion_list, find_main_name): Update.
5995         * symmisc.c (print_symbol_bcache_statistics)
5996         (print_objfile_statistics, maintenance_print_symbols)
5997         (maintenance_print_msymbols, maintenance_print_objfiles)
5998         (maintenance_info_symtabs, maintenance_check_symtabs)
5999         (maintenance_expand_symtabs, maintenance_info_line_tables):
6000         Update.
6001         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6002         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6003         (map_overlay_command, unmap_overlay_command)
6004         (simple_overlay_update, expand_symtabs_matching)
6005         (map_symbol_filenames): Update.
6006         * symfile-debug.c (set_debug_symfile): Update.
6007         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6008         Update.
6009         * source.c (select_source_symtab, forget_cached_source_info):
6010         Update.
6011         * solib.c (solib_read_symbols): Update.
6012         * solib-spu.c (append_ocl_sos): Update.
6013         * psymtab.c (maintenance_print_psymbols)
6014         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6015         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6016         * printcmd.c (info_symbol_command): Update.
6017         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6018         Update.
6019         * objfiles.h (class all_objfiles): Remove.
6020         * objfiles.c (have_partial_symbols, have_full_symbols)
6021         (have_minimal_symbols, qsort_cmp, update_section_map)
6022         (shared_objfile_contains_address_p)
6023         (default_iterate_over_objfiles_in_search_order): Update.
6024         * objc-lang.c (info_selectors_command, info_classes_command)
6025         (find_methods): Update.
6026         * minsyms.c (find_solib_trampoline_target): Update.
6027         * maint.c (maintenance_info_sections)
6028         (maintenance_translate_address, count_symtabs_and_blocks):
6029         Update.
6030         * main.c (captured_main_1): Update.
6031         * linux-thread-db.c (try_thread_db_load_from_pdir)
6032         (has_libpthread): Update.
6033         * linespec.c (iterate_over_all_matching_symtabs)
6034         (search_minsyms_for_name): Update.
6035         * jit.c (jit_find_objf_with_entry_addr): Update.
6036         * hppa-tdep.c (find_unwind_entry)
6037         (hppa_lookup_stub_minimal_symbol): Update.
6038         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6039         Update.
6040         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6041         (elf_gnu_ifunc_resolve_by_got): Update.
6042         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6043         * dwarf-index-write.c (save_gdb_index_command): Update.
6044         * cp-support.c (add_symbol_overload_list_qualified): Update.
6045         * breakpoint.c (create_overlay_event_breakpoint)
6046         (create_longjmp_master_breakpoint)
6047         (create_std_terminate_master_breakpoint)
6048         (create_exception_master_breakpoint): Update.
6049         * blockframe.c (find_pc_partial_function): Update.
6050         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6051         (ada_collect_symbol_completion_matches)
6052         (ada_add_global_exceptions): Update.
6053
6054 2019-01-17  Tom Tromey  <tom@tromey.com>
6055
6056         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6057         declare VEC.
6058         (solib_target_parse_libraries): Change return type.
6059         (library_list_start_segment, library_list_start_section)
6060         (library_list_end_library, library_list_start_library); Update.
6061         (solib_target_free_library_list): Remove.
6062         (solib_target_parse_libraries): Remove cleanup.  Change return
6063         type.
6064         (solib_target_current_sos): Update.
6065
6066 2019-01-17  Tom Tromey  <tromey@bapiya>
6067
6068         * valprint.c: Replace "the the" with "the".
6069         * symtab.c: Replace "the the" with "the".
6070         * solib.c: Replace "the the" with "the".
6071         * solib-dsbt.c: Replace "the the" with "the".
6072         * linespec.c: Replace "the the" with "the".
6073         * dwarf2loc.h: Replace "the the" with "the".
6074         * amd64-windows-tdep.c: Replace "the the" with "the".
6075         * aarch64-tdep.c: Replace "the the" with "the".
6076
6077 2019-01-16  Keith Seitz  <keiths@redhat.com>
6078
6079         PR gdb/23773
6080         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6081         <builder>: Rename to ..
6082         <m_builder>: ... this and make private.
6083         (dwarf2_cu::get_builder): New method.  Change all users of
6084         `builder' to use this method.
6085         (dwarf2_start_symtab): Move to ...
6086         (dwarf2_cu::start_symtab): ... here.  Update all callers
6087         (setup_type_unit_groups): Move to ...
6088         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6089         callers.
6090         (dwarf2_cu::reset_builder): New method.
6091         (process_full_compunit, process_full_type_unit): Use
6092         dwarf2_cu::reset_builder.
6093         (follow_die_offset): Record the ancestor CU if it is different
6094         from the followed DIE's CU.
6095         (follow_die_sig_1): Likewise.
6096
6097 2019-01-15  Tom Tromey  <tom@tromey.com>
6098
6099         * remote.c (class remote_state) <buf>: Now a char_vector.
6100         <buf_size>: Remove.
6101         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6102         parameter.
6103         (remote_target::getpkt_or_notif_sane_1)
6104         (remote_target::getpkt_sane)
6105         (remote_target::getpkt_or_notif_sane): Likewise.
6106         (class remote_target) <putpkt>: New overload.
6107         (remote_target::read_frame): Change type of "buf_p".  Remove
6108         sizeof_p parameter.
6109         (packet_ok): New overload.
6110         (packet_check_result): New overload.
6111         Update all uses.
6112
6113 2019-01-14  Tom Tromey  <tom@tromey.com>
6114
6115         * remote-notif.c (handle_notification, remote_notif_ack)
6116         (remote_notif_parse): Make "buf" const.
6117         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6118         const.
6119         (remote_notif_parse, remote_notif_ack, handle_notification):
6120         Likewise.
6121         * remote.c (remote_notif_stop_parse): Make "buf" const.
6122         (remote_target::remote_parse_stop_reply): Make "buf" const.
6123         (remote_notif_stop_ack): Make "buf" const.
6124
6125 2019-01-14  Tom Tromey  <tom@tromey.com>
6126
6127         * remote.c (remote_console_output): Make parameter const.
6128
6129 2019-01-14  Tom Tromey  <tom@tromey.com>
6130
6131         * target-debug.h (target_debug_print_signals): Constify.
6132         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6133         * procfs.c (procfs_target::pass_signals): Update.
6134         * linux-nat.c (linux_nat_target::pass_signals): Update.
6135         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6136         * target-delegates.c: Rebuild.
6137         * remote.c (remote_target::program_signals): Update.
6138         (remote_target::pass_signals): Update.
6139         * target.c (target_pass_signals): Constify argument.
6140         (target_program_signals): Likewise.
6141         * target.h (struct target_ops) <pass_signals, program_signals>:
6142         Constify argument.
6143         (target_pass_signals, target_program_signals): Constify argument.
6144
6145 2019-01-14  Tom Tromey  <tom@tromey.com>
6146
6147         PR tui/28819:
6148         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6149
6150 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6151
6152         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6153         field.
6154         * rs6000-tdep.c: Include reggroups.h.
6155         (IS_V_ALIAS_PSEUDOREG): Define.
6156         (rs6000_register_name): Return names for the "vX" aliases.
6157         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6158         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6159         aliases.  Call default_register_reggroup_p for all other
6160         pseudo-registers.
6161         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6162         New functions.
6163         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6164         Handle "vX" aliases.
6165         (v_alias_pseudo_register_collect): New function.
6166         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6167         (rs6000_gdbarch_init): Initialize "vX" aliases as
6168         pseudo-registers.  Restore registration of
6169         rs6000_pseudo_register_reggroup_p with
6170         set_tdesc_pseudo_register_reggroup_p.
6171
6172 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6173
6174         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6175         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6176         set_gdbarch_num_pseudo_regs.
6177
6178 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6179
6180         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6181         Remove arg prefixname, add do_set and do_show.
6182         Add member functions set_list and show_list.
6183         * cli/cli-style.c (class cli_style_option): Update accordingly.
6184         (style_set_list): Move to file scope.
6185         (style_show_list): Likewise.
6186         (set_style): Call help_list.
6187         (show_style): Call cmd_show_list.
6188         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6189         Update to use the new macro.
6190
6191 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6192
6193         * ada-lang.c (_initialize_ada_language): Expand the help text
6194         for the "catch exception" command.
6195
6196 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6197
6198         * symtab.c (matching_obj_sections): Initialize obj,
6199         declare it closer to its usage.
6200
6201 2019-01-10  Tom Tromey  <tom@tromey.com>
6202
6203         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6204         (basic_inf_threads_range): Remove.
6205         (inf_threads_range, inf_non_exited_threads_range)
6206         (safe_inf_threads_range): Use next_adapter.
6207
6208 2019-01-10  Keith Seitz  <keiths@redhat.com>
6209
6210         PR gdb/23712
6211         PR symtab/23010
6212         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6213         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6214
6215 2019-01-10  Keith Seitz  <keiths@redhat.com>
6216
6217         PR gdb/23712
6218         PR symtab/23010
6219         * dictionary.c (pending_to_vector): Remove.
6220         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6221         Remove _1 suffix, replacing functions of the same name.  Update
6222         all callers.
6223         (dict_create_hashed, dict_create_hashed_expandable)
6224         (dict_create_linear, dict_create_linear_expandable, dict_free)
6225         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6226         Make functions static.
6227
6228 2019-01-10  Keith Seitz  <keiths@redhat.com>
6229
6230         PR gdb/23712
6231         PR symtab/23010
6232         * dictionary.h (struct dictionary): Replace declaration with
6233         multidictionary.
6234         (dict_create_hashed, dict_create_hashed_expandable)
6235         (dict_create_linear, dict_create_linear_expandable)
6236         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6237         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6238         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6239         taking multidictionary argument.
6240         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6241         * block.h (struct block) <dict>: Change to multidictionary
6242         and rename `multidict'.
6243         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6244         symmisc.c: Update all dictionary references to multidictionary.
6245
6246 2019-01-10  Keith Seitz  <keiths@redhat.com>
6247
6248         PR gdb/23712
6249         PR symtab/23010
6250         * dictionary.c: Include unordered_map.
6251         (pending_to_vector): New function.
6252         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6253         Rewrite the non-"_1" functions to take vector instead
6254         of linked list.
6255         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6256         "new" _1 versions of the same name.
6257         (multidictionary): Define.
6258         (std::hash<enum language): New definition.
6259         (collate_pending_symbols_by_language, mdict_create_hashed)
6260         (mdict_create_hashed_expandable, mdict_create_linear)
6261         (mdict_create_linear_expandable, mdict_free)
6262         (find_language_dictionary, create_new_language_dictionary)
6263         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6264         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6265         (mdict_size, mdict_empty): New functions.
6266         * dictionary.h (mdict_iterator): Define.
6267
6268 2019-01-10  Pedro Alves  <palves@redhat.com>
6269
6270         * breakpoint.c (read_uploaded_action)
6271         (create_tracepoint_from_upload): Adjust to use
6272         gdb::unique_xmalloc_ptr.
6273         * ctf.c (ctf_write_uploaded_tp):
6274         (SET_ARRAY_FIELD): Use emplace_back.
6275         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6276         * tracefile-tfile.c (tfile_write_uploaded_tp):
6277         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6278         gdb::unique_xmalloc_ptr.
6279         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6280         at_string, cond_string, cmd_strings>: Replace char pointers
6281         with gdb::unique_xmalloc_ptr.
6282
6283 2019-01-10  Pedro Alves  <palves@redhat.com>
6284
6285         * solib-target.c (library_list_start_library): Don't xstrdup name.
6286
6287 2019-01-10  Pedro Alves  <palves@redhat.com>
6288
6289         * mdebugread.c (parse_partial_symbols): Use
6290         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6291
6292 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6293
6294         * linux-fork.c (scoped_switch_fork_info)
6295         <~scoped_switch_fork_info>: Fix incorrect variable name.
6296
6297 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6298
6299         * linux-fork.c (scoped_switch_fork_info)
6300         <scoped_switch_fork_info>: Make explicit.
6301         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6302
6303 2019-01-10  Tom Tromey  <tom@tromey.com>
6304
6305         * objfiles.h (objfile::reset_psymtabs): Update.
6306         * objfiles.c (objfile::objfile): Update.
6307         * psymtab.h (psymtab_storage::obstack): Update.
6308         (psymtab_storage::m_obstack): Use gdb::optional.
6309         (class psymtab_storage): Update comment.  Remove objfile
6310         parameter.
6311         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6312
6313 2019-01-10  Tom Tromey  <tom@tromey.com>
6314
6315         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6316         <free_psymtabs>: Now private.
6317         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6318         (allocate_psymtab): Use new method.
6319
6320 2019-01-10  Tom Tromey  <tom@tromey.com>
6321
6322         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6323         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6324         * mdebugread.c (parse_partial_symbols): Use
6325         allocate_dependencies.
6326         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6327         allocate_dependencies.
6328         (process_psymtab_comp_unit_reader)
6329         (build_type_psymtab_dependencies): Likewise.
6330         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6331
6332 2019-01-10  Tom Tromey  <tom@tromey.com>
6333
6334         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6335         PSYMBOL_SET_LANGUAGE.
6336         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6337
6338 2019-01-10  Tom Tromey  <tom@tromey.com>
6339
6340         * psymtab.h (psymtab_storage::obstack): New method.
6341         <m_obstack>: Rename from obstack; now private.
6342         * psymtab.c (psymtab_storage): Update.
6343         * dwarf2read.c (create_addrmap_from_index)
6344         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6345         Update.
6346
6347 2019-01-10  Tom Tromey  <tom@tromey.com>
6348
6349         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6350         * objfiles.h (objfile::reset_psymtabs): New method.
6351
6352 2019-01-10  Tom Tromey  <tom@tromey.com>
6353
6354         * symmisc.c (print_symbol_bcache_statistics): Update.
6355         (print_objfile_statistics): Update.
6356         * symfile.c (reread_symbols): Update.
6357         * psymtab.h (class psymtab_storage): New.
6358         * psymtab.c (psymtab_storage): New constructor.
6359         (~psymtab_storage): New destructor.
6360         (require_partial_symbols): Update.
6361         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6362         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6363         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6364         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6365         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6366         (start_psymtab_common, end_psymtab_common)
6367         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6368         (allocate_psymtab): Update.
6369         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6370         Update.
6371         (dump_psymtab_addrmap, maintenance_print_psymbols)
6372         (maintenance_check_psymtabs): Update.
6373         (class objfile_psymtabs): Move to objfiles.h.
6374         * psympriv.h (discard_psymtab): Now inline.
6375         (psymtab_discarder::psymtab_discarder): Update.
6376         (psymtab_discarder::~psymtab_discarder): Update.
6377         (ALL_OBJFILE_PSYMTABS): Rewrite.
6378         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6379         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6380         Remove fields.
6381         <partial_symtabs>: New field.
6382         (class objfile_psymtabs): Move from psymtab.h.  Update.
6383         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6384         psymbol_cache.
6385         (objfile::~objfile): Don't destroy psymbol_cache.
6386         * mdebugread.c (parse_partial_symbols): Update.
6387         * dwarf2read.c (create_addrmap_from_index)
6388         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6389         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6390         (add_partial_subprogram, dwarf2_ranges_read): Update.
6391         * dwarf-index-write.c (write_address_map)
6392         (write_one_signatured_type, recursively_write_psymbols)
6393         (class debug_names, class debug_names, write_psymtabs_to_index):
6394         Update.
6395
6396 2019-01-10  Tom Tromey  <tom@tromey.com>
6397
6398         * symtab.h (SYMBOL_SET_NAMES): Update.
6399         (symbol_set_names): Update.
6400         (MSYMBOL_SET_NAMES): Update.
6401         * symtab.c (symbol_set_names): Change argument to be an
6402         objfile_per_bfd_storage.
6403         * psymtab.c (add_psymbol_to_bcache): Update.
6404         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6405
6406 2019-01-10  Tom Tromey  <tom@tromey.com>
6407
6408         * symtab.c (create_demangled_names_hash): Change argument to be an
6409         objfile_per_bfd_storage.
6410         (symbol_set_names): Update.
6411
6412 2019-01-10  Tom Tromey  <tom@tromey.com>
6413
6414         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6415         init_psymbol_list.
6416         * psymtab.c (init_psymbol_list): Do nothing if already called.
6417         * psympriv.h (init_psymbol_list): Add comment.
6418         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6419         init_psymbol_list.
6420         * dbxread.c (dbx_symfile_read): Unconditionally call
6421         init_psymbol_list.
6422
6423 2019-01-10  Tom Tromey  <tom@tromey.com>
6424
6425         * xcoffread.c (scan_xcoff_symtab): Update.
6426         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6427         "where".
6428         * mdebugread.c (parse_partial_symbols)
6429         (handle_psymbol_enumerators): Update.
6430         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6431         * dbxread.c (read_dbx_symtab): Update.
6432         * psympriv.h (psymbol_placement): New enum.
6433         (add_psymbol_to_list): Update.
6434
6435 2019-01-10  Tom Tromey  <tom@tromey.com>
6436
6437         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6438         static_psymbols parameters.
6439         (scan_xcoff_symtab): Update.
6440         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6441         static_psymbols parameters.
6442         * psympriv.h (start_psymtab_common): Update.
6443         * mdebugread.c (parse_partial_symbols): Update.
6444         * dwarf2read.c (create_partial_symtab): Update.
6445         * dbxread.c (read_dbx_symtab): Update.
6446         (start_psymtab): Remove global_psymbols and static_psymbols
6447         parameters.
6448
6449 2019-01-10  Tom Tromey  <tom@tromey.com>
6450
6451         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6452         * psymtab.c (allocate_psymtab): Add comment.
6453         * psympriv.h (allocate_psymtab): Add comment.
6454         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6455         initializations.
6456         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6457
6458 2019-01-10  Tom Tromey  <tom@tromey.com>
6459
6460         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6461         Don't declare.
6462         * mipsread.c: Include mdebugread.h.
6463         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6464         Declare.
6465         * elfread.c: Include mdebugread.h.
6466
6467 2019-01-09  Tom Tromey  <tom@tromey.com>
6468
6469         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6470         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6471         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6472         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6473         (psym_lookup_symbol, psym_find_last_source_symtab)
6474         (psym_forget_cached_source_info, psym_print_stats)
6475         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6476         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6477         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6478         (psym_find_compunit_symtab_by_address)
6479         (maintenance_print_psymbols, maintenance_info_psymtabs)
6480         (maintenance_check_psymtabs): Use ranged for.
6481         * psymtab.h (class objfile_psymtabs): New.
6482         (require_partial_symbols): Return objfile_psymtabs.
6483         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6484
6485 2019-01-09  Tom Tromey  <tom@tromey.com>
6486
6487         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6488         (find_pc_mapped_section, list_overlays_command)
6489         (map_overlay_command, unmap_overlay_command)
6490         (simple_overlay_update): Use all_objfiles.
6491         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6492         * printcmd.c (info_symbol_command): Use all_objfiles.
6493         * objfiles.h (ALL_OBJSECTIONS): Remove.
6494         * maint.c (maintenance_translate_address): Use all_objfiles.
6495         * gcore.c (gcore_create_callback): Use all_objfiles.
6496         (objfile_find_memory_regions): Likewise.
6497
6498 2019-01-09  Tom Tromey  <tom@tromey.com>
6499
6500         * symtab.c (find_line_symtab, info_sources_command)
6501         (make_source_files_completion_list): Use objfile_compunits.
6502         * source.c (select_source_symtab): Use objfile_compunits.
6503         * objfiles.h (struct objfile): Update comment.
6504         (ALL_OBJFILES): Remove.
6505         (ALL_FILETABS): Remove.
6506         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6507         objfile_compunits.
6508
6509 2019-01-09  Tom Tromey  <tom@tromey.com>
6510
6511         * symmisc.c (print_objfile_statistics, dump_objfile)
6512         (maintenance_print_symbols): Use compunit_filetabs.
6513         * source.c (forget_cached_source_info_for_objfile): Use
6514         compunit_filetabs.
6515         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6516         (ALL_FILETABS): Use compunit_filetabs.
6517         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6518         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6519
6520 2019-01-09  Tom Tromey  <tom@tromey.com>
6521
6522         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6523         (compunit_filetabs): New.
6524         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6525         compunit_filetabs.
6526         (info_sources_command, make_source_files_completion_list): Remove
6527         declaration.
6528         * symmisc.c (print_objfile_statistics, dump_objfile)
6529         (maintenance_print_symbols): Remove declaration.
6530         (maintenance_info_symtabs): Use compunit_filetabs.
6531         (maintenance_info_line_tables): Likewise.
6532         * source.c (select_source_symtab): Change local variable name.
6533         (forget_cached_source_info_for_objfile): Remove declaration.
6534         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6535         * objfiles.c (objfile_relocate1): Remove declaration.
6536         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6537         declaration.
6538         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6539         * coffread.c (coff_symtab_read): Remove declaration.
6540         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6541         compunit_filetabs.
6542
6543 2019-01-09  Tom Tromey  <tom@tromey.com>
6544
6545         * symtab.c (lookup_objfile_from_block)
6546         (find_pc_sect_compunit_symtab, search_symbols)
6547         (default_collect_symbol_completion_matches_break_on): Use
6548         objfile_compunits.
6549         * objfiles.h (ALL_COMPUNITS): Remove.
6550         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6551         * cp-support.c (add_symbol_overload_list_qualified): Use
6552         objfile_compunits.
6553         * ada-lang.c (ada_collect_symbol_completion_matches)
6554         (ada_add_global_exceptions): Use objfile_compunits.
6555
6556 2019-01-09  Tom Tromey  <tom@tromey.com>
6557
6558         * source.c (select_source_symtab)
6559         (forget_cached_source_info_for_objfile): Remove declaration.
6560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6561         declaration.
6562         * maint.c (count_symtabs_and_blocks): Remove declaration.
6563         * cp-support.c (add_symbol_overload_list_qualified): Remove
6564         declaration.
6565         * coffread.c (coff_symtab_read): Remove declaration.
6566         * symtab.c (lookup_symbol_in_objfile_symtabs)
6567         (basic_lookup_transparent_type_1): Use objfile_compunits.
6568         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6569         (info_sources_command, search_symbols)
6570         (default_collect_symbol_completion_matches_break_on)
6571         (make_source_files_completion_list): Remove declaration.
6572         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6573         (ada_collect_symbol_completion_matches)
6574         (ada_add_global_exceptions): Remove declaration.
6575         * linespec.c (iterate_over_all_matching_symtabs): Use
6576         objfile_compunits.
6577         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6578         (class objfile_compunits): New.
6579         (ALL_COMPUNITS): Use objfile_compunits.
6580         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6581         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6582         objfile_compunits.
6583         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6584
6585 2019-01-09  Tom Tromey  <tom@tromey.com>
6586
6587         * symtab.c (search_symbols)
6588         (default_collect_symbol_completion_matches_break_on): Use
6589         objfile_msymbols.
6590         * ada-lang.c (ada_lookup_simple_minsym)
6591         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6592         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6593         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6594         objfile_msymbols.
6595         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6596         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6597         * objc-lang.c (find_methods): Use objfile_msymbols.
6598         (info_selectors_command, info_classes_command): Likewise.
6599         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6600         * objfiles.h (class objfile_msymbols): New.
6601         (ALL_OBJFILE_MSYMBOLS): Remove.
6602         (ALL_MSYMBOLS): Remove.
6603
6604 2019-01-09  Tom Tromey  <tom@tromey.com>
6605
6606         * common/next-iterator.h (next_adapter): Add Iterator template
6607         parameter.
6608         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6609         (class all_objfiles_safe): New.
6610         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6611         * objfiles.c (put_objfile_before): Update comment.
6612         (add_separate_debug_objfile): Likewise.
6613         (free_all_objfiles): Use all_objfiles_safe.
6614         (objfile_purge_solibs): Likewise.
6615
6616 2019-01-09  Tom Tromey  <tom@tromey.com>
6617
6618         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6619         (expand_symtab_containing_pc, lookup_static_symbol)
6620         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6621         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6622         all_objfiles.
6623         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6624         * breakpoint.c (create_overlay_event_breakpoint)
6625         (create_longjmp_master_breakpoint)
6626         (create_std_terminate_master_breakpoint)
6627         (create_exception_master_breakpoint): Use all_objfiles.
6628         * linux-thread-db.c (try_thread_db_load_from_pdir)
6629         (has_libpthread): Use all_objfiles.
6630         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6631         * linespec.c (iterate_over_all_matching_symtabs)
6632         (search_minsyms_for_name): Use all_objfiles.
6633         * maint.c (maintenance_info_sections): Use all_objfiles.
6634         * main.c (captured_main_1): Use all_objfiles.
6635         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6636         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6637         * guile/scm-pretty-print.c
6638         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6639         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6640         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6641         (maintenance_print_msymbols): Use all_objfiles.
6642         * source.c (select_source_symtab): Use all_objfiles.
6643         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6644         * symfile.c (remove_symbol_file_command)
6645         (expand_symtabs_matching, map_symbol_filenames): Use
6646         all_objfiles.
6647         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6648         all_objfiles.
6649         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6650         * objc-lang.c (find_methods): Use all_objfiles.
6651         * objfiles.c (have_partial_symbols, have_full_symbols)
6652         (have_minimal_symbols, qsort_cmp)
6653         (default_iterate_over_objfiles_in_search_order): Use
6654         all_objfiles.
6655         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6656         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6657         (maintenance_check_psymtabs): Use all_objfiles.
6658         (ALL_PSYMTABS): Remove.
6659         * compile/compile-object-run.c (do_module_cleanup): Use
6660         all_objfiles.
6661         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6662         * cp-support.c (add_symbol_overload_list_qualified): Use
6663         all_objfiles.
6664         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6665         Use all_objfiles.
6666         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6667         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6668         all_objfiles.
6669         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6670         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6671         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6672         Uses all_objfiles.
6673         * solib.c (solib_read_symbols): Use all_objfiles
6674
6675 2019-01-09  Tom Tromey  <tom@tromey.com>
6676
6677         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6678         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6679         all_objfiles.
6680         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6681         * symmisc.c (print_symbol_bcache_statistics)
6682         (print_objfile_statistics, maintenance_print_objfiles)
6683         (maintenance_info_symtabs, maintenance_check_symtabs)
6684         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6685         all_objfiles.
6686         * source.c (forget_cached_source_info): Use all_objfiles.
6687         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6688         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6689         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6690         * objfiles.c (update_section_map): Use all_objfiles.
6691         (shared_objfile_contains_address_p): Likewise.
6692         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6693         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6694
6695 2019-01-09  Tom Tromey  <tom@tromey.com>
6696
6697         * common/next-iterator.h: New file.
6698         * objfiles.h (class all_objfiles): New.
6699         (struct objfile_iterator): New.
6700
6701 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6702
6703         * NEWS: Move the description of the changed "frame", "select-frame",
6704          and "info frame" commands to the Changed commands section.
6705
6706 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6707
6708         * gdbtypes.c (check_stub_method_group): Remove handling of old
6709         mangling schemes.
6710         * linespec.c (find_methods): Likewise.
6711         * stabsread.c (read_member_functions): Likewise.
6712         * valops.c (search_struct_method): Likewise.
6713         (value_struct_elt_for_reference): Likewise.
6714         * NEWS: Mention this change.
6715
6716 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6717
6718         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6719         print_source_lines.
6720         * source.c (print_source_lines_base): Update line number check.
6721         (print_source_lines): New function.
6722         (source_lines_range::source_lines_range): New function.
6723         * source.h (class source_lines_range): New class.
6724         (print_source_lines): New declaration.
6725
6726 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6727
6728         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6729
6730 2019-01-08  Tom Tromey  <tom@tromey.com>
6731             Simon Marchi  <simon.marchi@ericsson.com>
6732
6733         PR gdb/24060
6734         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6735         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6736         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6737         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6738         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6739         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6740
6741 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6742
6743         * source.c (select_source_symtab): Move header comment to
6744         declaration in source.h.
6745         (forget_cached_source_info_for_objfile): Likewise.
6746         (forget_cached_source_info): Likewise.
6747         (identify_source_line): Likewise.
6748         * source.h (identify_source_line): Move declaration from symtab.h
6749         and add comment from source.c
6750         (print_source_lines): Likewise.
6751         (forget_cached_source_info_for_objfile): Likewise.
6752         (forget_cached_source_info): Likewise.
6753         (select_source_symtab): Likewise.
6754         (enum print_source_lines_flag): Move definition from symtab.h.
6755         * symtab.h (identify_source_line): Move declaration to source.h.
6756         (print_source_lines): Likewise.
6757         (forget_cached_source_info_for_objfile): Likewise.
6758         (forget_cached_source_info): Likewise.
6759         (select_source_symtab): Likewise.
6760         (enum print_source_lines_flag): Move definition to source.h.
6761         * tui/tui-hooks.c: Add 'source.h' include.
6762
6763 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6764
6765         * source.c (print_source_lines_base): Handle requests to print
6766         reverse line number sequences, and guard against empty lines
6767         string.
6768
6769 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6770
6771         * source.c (print_source_lines_base): Fix skip of '\r' if next
6772         character is '\n'.
6773
6774 2019-01-06  Tom Tromey  <tom@tromey.com>
6775
6776         * c-exp.y (struct c_parse_state) <macro_original_text,
6777         expansion_obstack>: New member.
6778         (macro_original_text, expansion_obstack): Remove globals.
6779         (scan_macro_expansion, scanning_macro_expansion)
6780         (finished_macro_expansion): Update.
6781         (scan_macro_cleanup): Remove.
6782         (yylex, c_parse): Update.
6783
6784 2019-01-06  Tom Tromey  <tom@tromey.com>
6785
6786         * c-exp.y (struct c_parse_state) <strings>: New member.
6787         (operator_stoken): Update.
6788
6789 2019-01-06  Tom Tromey  <tom@tromey.com>
6790
6791         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6792         (union type_stack_elt) <typelist_val>: Now a pointer to
6793         std::vector.
6794         (type_stack_cleanup): Don't declare.
6795         (push_typelist): Update.
6796         * parse.c (pop_typelist): Return a std::vector.
6797         (push_typelist): Take a std::vector.
6798         (follow_types): Update.  Do not free args.
6799         (type_stack_cleanup): Remove.
6800         * c-exp.y (struct c_parse_state): New.
6801         (cpstate): New global.
6802         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6803         (nonempty_typelist): Update.
6804         (func_mod): Create a new vector.
6805         (c_parse): Create a c_parse_state.
6806         (check_parameter_typelist): Do not delete params.
6807         (function_method): Update.  Do not delete type_list.
6808
6809 2019-01-06  Tom Tromey  <tom@tromey.com>
6810
6811         PR gdb/28155:
6812         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6813         check_typedef.
6814         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6815         (print_return_value): Likewise.
6816
6817 2019-01-05  Tom Tromey  <tom@tromey.com>
6818
6819         * contrib/cleanup_check.py: Remove.
6820         * contrib/gcc-with-excheck: Remove.
6821         * contrib/exsummary.py: Remove.
6822         * contrib/excheck.py: Remove.
6823
6824 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6825
6826         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6827         NULL. Initialize tpprev to NULL instead of assigning it
6828         to NULL on the next statement.
6829         * windows-nat.c (windows_delete_thread): Remove check for
6830         main_thread_id before printing thread exit notifications.
6831         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6832         Remove thread ID check against main_thread_id.
6833         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6834         windows_delete_thread.
6835         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6836
6837 2019-01-04  Tom Tromey  <tom@tromey.com>
6838
6839         * compile/compile.c (_initialize_compile): Use upper case for
6840         metasyntactic variables.
6841         * symmisc.c (_initialize_symmisc): Use upper case for
6842         metasyntactic variables.
6843         * psymtab.c (_initialize_psymtab): Use upper case for
6844         metasyntactic variables.
6845         * demangle.c (demangle_command): Use upper case for metasyntactic
6846         variables.
6847         (_initialize_demangler): Likewise.
6848         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6849         variables.
6850
6851 2019-01-03  Tom Tromey  <tom@tromey.com>
6852
6853         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6854
6855 2019-01-03  Tom Tromey  <tom@tromey.com>
6856
6857         * python/py-symtab.c (salpy_str): Update.
6858         (struct salpy_sal_object) <symtab>: Now a PyObject.
6859         (salpy_dealloc): Update.
6860         (del_objfile_sal): Use gdbpy_ref.
6861
6862 2019-01-03  Tom Tromey  <tom@tromey.com>
6863
6864         * python/py-type.c (convert_field): Use new_reference.  Return
6865         gdbpy_ref.
6866         (make_fielditem): Return gdbpy_ref.
6867         (typy_fields): Update.
6868         (typy_getitem): Update.
6869         (field_name): Return gdbpy_ref.  Use new_reference.
6870         (typy_iterator_iternext): Update.
6871
6872 2019-01-03  Tom Tromey  <tom@tromey.com>
6873
6874         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6875
6876 2019-01-03  Tom Tromey  <tom@tromey.com>
6877
6878         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6879         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6880         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6881         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6882         (pspy_set_type_printers): Likewise.
6883         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6884         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6885         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6886         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6887         (objfpy_set_type_printers): Likewise.
6888
6889 2019-01-03  Tom Tromey  <tom@tromey.com>
6890
6891         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6892         (gdbpy_print_stack): Use gdbpy_err_fetch.
6893         * python/python-internal.h (class gdbpy_err_fetch): New class.
6894         (class gdbpy_enter) <m_error_type, m_error_value,
6895         m_error_traceback>: Remove.
6896         <m_error>: New member.
6897         (gdbpy_exception_to_string): Don't declare.
6898         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6899         * python/py-value.c (convert_value_from_python): Use
6900         gdbpy_err_fetch.
6901         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6902         gdbpy_exception_to_string.
6903         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6904         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6905         gdbpy_err_fetch.
6906
6907 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6908
6909         * linux-nat.c (delete_lwp_cleanup): Delete.
6910         (struct lwp_deleter): New struct.
6911         (lwp_info_up): New typedef.
6912         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6913         lwp_info_up.
6914
6915 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6916
6917         * linux-fork.c (class scoped_switch_fork_info): New class.
6918         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6919
6920 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6921
6922         * valops.c (find_overload_match): Remove use of null_cleanup, and
6923         calls to do_cleanups.
6924
6925 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * compile/compile-cplus-types.c
6928         (compile_cplus_instance::decl_name): Handle changes to
6929         cp_func_name.
6930         * cp-support.c (cp_func_name): Update header comment, update
6931         return type.
6932         * cp-support.h (cp_func_name): Update return type in declaration.
6933         * valops.c (find_overload_match): Move temp_func local to top
6934         level of function and change its type.  Use temp_func to hold and
6935         delete temporary string obtained from cp_func_name.
6936
6937 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6938
6939         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6940         gdb::char_vector, remove cleanup, and update uses of `msg`.
6941
6942 2019-01-03  Jim Wilson  <jimw@sifive.com>
6943
6944         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6945
6946 2019-01-02  Tom Tromey  <tom@tromey.com>
6947
6948         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6949         (tdesc_parse_xml): Remove cleanups.
6950         * target-descriptions.h (make_cleanup_free_target_description):
6951         Don't declare.
6952         (target_desc_deleter): New struct.
6953         (target_desc_up): New typedef.
6954         * target-descriptions.c (target_desc_deleter::operator()): Rename
6955         from free_target_description.
6956         (make_cleanup_free_target_description): Remove.
6957
6958 2019-01-02  Tom Tromey  <tom@tromey.com>
6959
6960         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6961         constructor, destructor.
6962         (linespec_parser): Remove typedef.
6963         (~linespec_parser): Rename from linespec_parser_delete.
6964         (linespec_lex_to_end, linespec_complete_label)
6965         (linespec_complete): Update.
6966         (decode_line_full): Remove cleanups.
6967         (decode_line_1): Update.
6968
6969 2019-01-02  Tom Tromey  <tom@tromey.com>
6970
6971         * python/python-internal.h (inferior_to_inferior_object): Change
6972         return type.
6973         * python/py-exitedevent.c (create_exited_event_object): Update.
6974         * python/py-inferior.c (inferior_to_inferior_object): Return
6975         gdbpy_ref.
6976         (python_new_inferior, python_inferior_deleted)
6977         (thread_to_thread_object, delete_thread_object)
6978         (build_inferior_list, gdbpy_selected_inferior): Update.
6979         * python/py-infthread.c (create_thread_object): Update.  Also fail
6980         if inferior_to_inferior_object fails.
6981
6982 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6983
6984         * inferior.h (class inferior) <displaced_step_state>: New field.
6985         * infrun.h (struct displaced_step_state): Move here from
6986         infrun.c.  Initialize fields, add constructor.
6987         <inf>: Remove field.
6988         <reset>: New method.
6989         * infrun.c (struct displaced_step_inferior_state): Move to
6990         infrun.h.
6991         (displaced_step_inferior_states): Remove.
6992         (get_displaced_stepping_state): Adust.
6993         (displaced_step_in_progress_any_inferior): Adjust.
6994         (displaced_step_in_progress_thread): Adjust.
6995         (displaced_step_in_progress): Adjust.
6996         (add_displaced_stepping_state): Remove.
6997         (get_displaced_step_closure_by_addr): Adjust.
6998         (remove_displaced_stepping_state): Remove.
6999         (infrun_inferior_exit): Call displaced_step_state.reset.
7000         (use_displaced_stepping): Don't check for NULL.
7001         (displaced_step_prepare_throw): Call
7002         get_displaced_stepping_state.
7003         (displaced_step_fixup): Don't check for NULL.
7004         (prepare_for_detach): Don't check for NULL.
7005
7006 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7007
7008         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7009          in case of call that did not complete.
7010
7011 2019-01-02  Andrey Utkin  <autkin@undo.io>
7012
7013         * symfile.c (find_separate_debug_file): Fix search of debug files for
7014         remote debuggee.
7015
7016 2019-01-02  Tom Tromey  <tom@tromey.com>
7017
7018         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7019         indentation.
7020         * python/py-frame.c (frapy_older): Remove cast.
7021         (frapy_newer): Likewise.
7022         * python/py-breakpoint.c (local_setattro): Remove cast.
7023         * python/py-arch.c (archpy_name): Remove local variable.
7024         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7025
7026 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7027
7028         * unittests/basic_string_view/element_access/char/empty.cc:
7029         Fix year range in copyright header.
7030
7031 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7034         Delete.
7035         <operator==>: Update with for removed field.
7036         <hash>: Likewise.
7037         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7038         <isa_features>: ...this.
7039         <abi_features>: New field.
7040         (riscv_isa_flen): Update comment.
7041         (riscv_abi_xlen): New declaration.
7042         (riscv_abi_flen): New declaration.
7043         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7044         isa_features.
7045         (riscv_abi_xlen): New function.
7046         (riscv_isa_flen): Update to get answer from isa_features.
7047         (riscv_abi_flen): New function.
7048         (riscv_has_fp_abi): Update to get answer from abi_features.
7049         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7050         xlen and flen.
7051         (riscv_call_info) <xlen, flen>: Update comment.
7052         (riscv_call_arg_struct): Remove invalid assertions
7053         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7054         is removed.
7055         (riscv_gdbarch_init): Gather isa features and abi features
7056         separately, ensure both match on the gdbarch when reusing an old
7057         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7058         a target with 64-bit float hardware.
7059
7060 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7061
7062         * source.c (search_command_helper): Stop reverse search
7063         when line 1 has been searched.
7064
7065 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7066
7067         * record-full.c (record_full_base_target::close): Rewrite
7068         record_full_core_buf_list free logic.
7069
7070 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7071
7072         * break-catch-syscall.c (print_one_catch_syscall): xfree
7073         the last text.
7074
7075 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7076
7077         * top.c (print_gdb_version): Update Copyright year in version
7078         message.
7079
7080 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7081
7082         Update copyright year range in all GDB files.
7083
7084 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7085
7086         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7087
7088 For older changes see ChangeLog-2018.
7089 \f
7090 Local Variables:
7091 mode: change-log
7092 left-margin: 8
7093 fill-column: 74
7094 version-control: never
7095 coding: utf-8
7096 End:
7097