gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
   4         Declare.
   5         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
   6         from tui_make_status_line.
   7         (tui_locator_window::rerender): Update.
   8
   9 2019-09-20  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-stack.c (tui_make_status_line): Return std::string.
  12         (tui_locator_window::rerender): Update.
  13
  14 2019-09-20  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-winsource.h (struct tui_source_window_base)
  17         <~tui_source_window_base>: Don't declare.
  18         <fullname>: Remove.
  19         * tui/tui-winsource.c (~tui_source_window_base): Remove.
  20         * tui/tui-source.h (struct tui_source_window) <fullname>: New
  21         member.
  22         * tui/tui-source.c (tui_source_window::set_contents): Update.
  23         (tui_source_window::location_matches_p)
  24         (tui_source_window::maybe_update): Update.
  25
  26 2019-09-20  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-winsource.h (~tui_source_element): Remove.
  29         (tui_source_element): Update.
  30         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
  31         * tui/tui-winsource.c (tui_show_source_line): Update.
  32         * tui/tui-source.c (tui_source_window::set_contents): Update.
  33         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  34
  35 2019-09-20  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
  38         declare.
  39         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
  40         tui_clear_source_windows_detail.
  41         * tui/tui-winsource.h (struct tui_source_window_base)
  42         <clear_detail>: Don't declare.
  43         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
  44         Remove.
  45         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
  46
  47 2019-09-20  Tom Tromey  <tromey@adacore.com>
  48
  49         PR ada/24919:
  50         * block.c (contained_in): Fix final return value.
  51
  52 2019-09-20  Alan Modra  <amodra@gmail.com>
  53
  54         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
  55         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
  56         (read_indirect_string_from_dwz): Use bfd accessor.
  57         * dwarf2read.h (struct dwz_file <filename>): Likewise.
  58         * machoread.c (macho_symfile_read_all_oso): Likewise.
  59         * solib.c (solib_bfd_open): Likewise.
  60
  61 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  62
  63         * eval.c: Move declaration of overload_resolution to...
  64         * value.h: ...here.
  65
  66 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  67
  68         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
  69         * arm-linux-tdep.c: Likewise.
  70         * arm-nbsd-nat.c: Likewise.
  71         * arm-tdep.h: Declare arm_apcs_32.
  72         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
  73
  74 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  75
  76         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
  77         * dwarf2read.h: Declare dwarf_always_disassemble.
  78
  79 2019-09-19  Tom de Vries  <tdevries@suse.de>
  80
  81         PR gdb/25009
  82         * source-cache.c (source_cache::ensure): Catch exception thrown during
  83         construction of the highlighter.
  84
  85 2019-09-18  Alan Modra  <amodra@gmail.com>
  86
  87         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
  88         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
  89         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
  90         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
  91         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
  92         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
  93         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
  94         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
  95         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
  96         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
  97         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
  98         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
  99         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 100         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 101         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 102         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 103         * mi/mi-interp.c: Update throughout for bfd section macro and
 104         function changes.
 105         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 106         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 107
 108 2019-09-18  Tom Tromey  <tom@tromey.com>
 109
 110         * NEWS: Add entry.
 111         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 112         call rl_initialize.
 113         (tui_enable): Do not call rl_initialize.
 114
 115 2019-09-18  Christian Groessler  <chris@groessler.org>
 116
 117         * alpha-linux-nat.c: Include gdbarch.h.
 118
 119 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 120
 121         * ui-file.c: Include cli/cli-style.h.
 122         (term_cli_styling): Remove cli_styling declaration.
 123
 124 2019-09-18  Alan Modra  <amodra@gmail.com>
 125
 126         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 127         to bfd_asymbol_section.
 128
 129 2019-09-18  Alan Modra  <amodra@gmail.com>
 130
 131         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 132         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 133         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 134
 135 2019-09-18  Alan Modra  <amodra@gmail.com>
 136
 137         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 138         * spu-linux-nat.c (spu_bfd_open): Likewise.
 139
 140 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 141
 142         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 143         to bool to match definition in dwarf2read.c.
 144
 145 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 146
 147         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 148         (print_signatures): Likewise.
 149         (trust_pad_over_xvs): Likewise.
 150         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 151         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 152         * arm-linux-nat.c (arm_apcs_32): Likewise.
 153         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 154         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 155         * arm-tdep.c (arm_debug): Likewise.
 156         (arm_apcs_32): Likewise.
 157         * auto-load.c (debug_auto_load): Likewise.
 158         (auto_load_gdb_scripts): Likewise.
 159         (global_auto_load): Likewise.
 160         (auto_load_local_gdbinit): Likewise.
 161         (auto_load_local_gdbinit_loaded): Likewise.
 162         * auto-load.h (global_auto_load): Likewise.
 163         (auto_load_local_gdbinit): Likewise.
 164         (auto_load_local_gdbinit_loaded): Likewise.
 165         * breakpoint.c (disconnected_dprintf): Likewise.
 166         (breakpoint_proceeded): Likewise.
 167         (automatic_hardware_breakpoints): Likewise.
 168         (always_inserted_mode): Likewise.
 169         (target_exact_watchpoints): Likewise.
 170         (_initialize_breakpoint): Update.
 171         * breakpoint.h (target_exact_watchpoints): Change to bool.
 172         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 173         * cli/cli-cmds.c (trace_commands): Likewise.
 174         * cli/cli-cmds.h (trace_commands): Likewise.
 175         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 176         to bool*.
 177         * cli/cli-logging.c (logging_overwrite): Change to bool.
 178         (logging_redirect): Likewise.
 179         (debug_redirect): Likewise.
 180         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 181         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 182         to bool.
 183         <boolean_option_def>: Update.
 184         (struct flag_option_def): Change default type of Context to bool
 185         from int.
 186         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 187         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 188         (get_setshow_command_value_string): Likewise.
 189         * cli/cli-style.c (cli_styling): Change to bool.
 190         (source_styling): Likewise.
 191         * cli/cli-style.h (source_styling): Likewise.
 192         (cli_styling): Likewise.
 193         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 194         to bool.
 195         * command.h (var_types): Update comment.
 196         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 197         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 198         bool.
 199         (debug_compile_cplus_scopes): Likewise.
 200         * compile/compile-internal.h (compile_debug): Likewise.
 201         * compile/compile.c (compile_debug): Likewise.
 202         (struct compile_options) <raw>: Likewise.
 203         * cp-support.c (catch_demangler_crashes): Likewise.
 204         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 205         (usr_cmd_cris_dwarf2_cfi): Likewise.
 206         * csky-tdep.c (csky_debug): Likewise.
 207         * darwin-nat.c (enable_mach_exceptions): Likewise.
 208         * dcache.c (dcache_enabled_p): Likewise.
 209         * defs.h (info_verbose): Likewise.
 210         * demangle.c (demangle): Likewise.
 211         (asm_demangle): Likewise.
 212         * dwarf-index-cache.c (debug_index_cache): Likewise.
 213         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 214         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 215         * dwarf2read.c (check_physname): Likewise.
 216         (use_deprecated_index_sections): Likewise.
 217         (dwarf_always_disassemble): Likewise.
 218         * eval.c (overload_resolution): Likewise.
 219         * event-top.c (set_editing_cmd_var): Likewise.
 220         (exec_done_display_p): Likewise.
 221         * event-top.h (set_editing_cmd_var): Likewise.
 222         (exec_done_display_p): Likewise.
 223         * exec.c (write_files): Likewise.
 224         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 225         (debug_fbsd_nat): Likewise.
 226         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 227         Likewise.
 228         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 229         <backtrace_past_entry> Likewise.
 230         * gdb-demangle.h (demangle): Likewise.
 231         (asm_demangle): Likewise.
 232         * gdb_bfd.c (bfd_sharing): Likewise.
 233         * gdbcore.h (write_files): Likewise.
 234         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 235         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 236         * gdbthread.h (print_thread_events): Likewise.
 237         * gdbtypes.c (opaque_type_resolution): Likewise.
 238         (strict_type_checking): Likewise.
 239         * gnu-nat.c (gnu_debug_flag): Likewise.
 240         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 241         * guile/scm-param.c (pascm_variable): Add boolval.
 242         (add_setshow_generic): Update.
 243         (pascm_param_value): Update.
 244         (pascm_set_param_value_x): Update.
 245         * hppa-tdep.c (hppa_debug): Change to bool..
 246         * infcall.c (may_call_functions_p): Likewise.
 247         (coerce_float_to_double_p): Likewise.
 248         (unwind_on_signal_p): Likewise.
 249         (unwind_on_terminating_exception_p): Likewise.
 250         * infcmd.c (startup_with_shell): Likewise.
 251         * inferior.c (print_inferior_events): Likewise.
 252         * inferior.h (startup_with_shell): Likewise.
 253         (print_inferior_events): Likewise.
 254         * infrun.c (step_stop_if_no_debug): Likewise.
 255         (detach_fork): Likewise.
 256         (debug_displaced): Likewise.
 257         (disable_randomization): Likewise.
 258         (non_stop): Likewise.
 259         (non_stop_1): Likewise.
 260         (observer_mode): Likewise.
 261         (observer_mode_1): Likewise.
 262         (set_observer_mode): Update.
 263         (sched_multi): Change to bool.
 264         * infrun.h (debug_displaced): Likewise.
 265         (sched_multi): Likewise.
 266         (step_stop_if_no_debug): Likewise.
 267         (non_stop): Likewise.
 268         (disable_randomization): Likewise.
 269         * linux-tdep.c (use_coredump_filter): Likewise.
 270         (dump_excluded_mappings): Likewise.
 271         * linux-thread-db.c (auto_load_thread_db): Likewise.
 272         (check_thread_db_on_load): Likewise.
 273         * main.c (captured_main_1): Update.
 274         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 275         xx2_opt, boolean_opt>: Change to bool.
 276         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 277         * maint.c (maintenance_profile_p): Likewise.
 278         (per_command_time): Likewise.
 279         (per_command_space): Likewise.
 280         (per_command_symtab): Likewise.
 281         * memattr.c (inaccessible_by_default): Likewise.
 282         * mi/mi-main.c (mi_async): Likewise.
 283         (mi_async_1): Likewise.
 284         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 285         * nat/fork-inferior.h (startup_with_shell): Likewise.
 286         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 287         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 288         * nios2-tdep.c (nios2_debug): Likewise.
 289         * or1k-tdep.c (or1k_debug): Likewise.
 290         * parse.c (parser_debug): Likewise.
 291         * parser-defs.h (parser_debug): Likewise.
 292         * printcmd.c (print_symbol_filename): Likewise.
 293         * proc-api.c (procfs_trace): Likewise.
 294         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 295         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 296         (set_parameter_value): Update.
 297         (add_setshow_generic): Update.
 298         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 299         to bool*.
 300         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 301         int*.
 302         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 303         * record-btrace.c (record_btrace_target::store_registers): Update.
 304         * record-full.c (record_full_memory_query): Change to bool.
 305         (record_full_stop_at_limit): Likewise.
 306         * record-full.h (record_full_memory_query): Likewise.
 307         * remote-notif.c (notif_debug): Likewise.
 308         * remote-notif.h (notif_debug): Likewise.
 309         * remote.c (use_range_stepping): Likewise.
 310         (interrupt_on_connect): Likewise.
 311         (remote_break): Likewise.
 312         * ser-tcp.c (tcp_auto_retry): Likewise.
 313         * ser-unix.c (serial_hwflow): Likewise.
 314         * skip.c (debug_skip): Likewise.
 315         * solib-aix.c (solib_aix_debug): Likewise.
 316         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 317         (spu_auto_flush_cache_p): Likewise.
 318         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 319         Likewise.
 320         (struct info_print_options) <quiet>: Likewise.
 321         * symfile-debug.c (debug_symfile): Likewise.
 322         * symfile.c (auto_solib_add): Likewise.
 323         (separate_debug_file_debug): Likewise.
 324         * symfile.h (auto_solib_add): Likewise.
 325         (separate_debug_file_debug): Likewise.
 326         * symtab.c (basenames_may_differ): Likewise.
 327         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 328         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 329         (struct info_types_options) <quiet>: Likewise.
 330         * symtab.h (demangle): Likewise.
 331         (basenames_may_differ): Likewise.
 332         * target-dcache.c (stack_cache_enabled_1): Likewise.
 333         (code_cache_enabled_1): Likewise.
 334         * target.c (trust_readonly): Likewise.
 335         (may_write_registers): Likewise.
 336         (may_write_memory): Likewise.
 337         (may_insert_breakpoints): Likewise.
 338         (may_insert_tracepoints): Likewise.
 339         (may_insert_fast_tracepoints): Likewise.
 340         (may_stop): Likewise.
 341         (auto_connect_native_target): Likewise.
 342         (target_stop_and_wait): Update.
 343         (target_async_permitted): Change to bool.
 344         (target_async_permitted_1): Likewise.
 345         (may_write_registers_1): Likewise.
 346         (may_write_memory_1): Likewise.
 347         (may_insert_breakpoints_1): Likewise.
 348         (may_insert_tracepoints_1): Likewise.
 349         (may_insert_fast_tracepoints_1): Likewise.
 350         (may_stop_1): Likewise.
 351         * target.h (target_async_permitted): Likewise.
 352         (may_write_registers): Likewise.
 353         (may_write_memory): Likewise.
 354         (may_insert_breakpoints): Likewise.
 355         (may_insert_tracepoints): Likewise.
 356         (may_insert_fast_tracepoints): Likewise.
 357         (may_stop): Likewise.
 358         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 359         (make_thread_apply_all_options_def_group): Change argument from int*
 360         to bool*.
 361         (thread_apply_all_command): Update.
 362         (print_thread_events): Change to bool.
 363         * top.c (confirm): Likewise.
 364         (command_editing_p): Likewise.
 365         (history_expansion_p): Likewise.
 366         (write_history_p): Likewise.
 367         (info_verbose): Likewise.
 368         * top.h (confirm): Likewise.
 369         (history_expansion_p): Likewise.
 370         * tracepoint.c (disconnected_tracing): Likewise.
 371         (circular_trace_buffer): Likewise.
 372         * typeprint.c (print_methods): Likewise.
 373         (print_typedefs): Likewise.
 374         * utils.c (debug_timestamp): Likewise.
 375         (sevenbit_strings): Likewise.
 376         (pagination_enabled): Likewise.
 377         * utils.h (sevenbit_strings): Likewise.
 378         (pagination_enabled): Likewise.
 379         * valops.c (overload_resolution): Likewise.
 380         * valprint.h (struct value_print_options) <prettyformat_arrays,
 381         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 382         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 383         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 384         Likewise.
 385         * windows-nat.c (new_console): Likewise.
 386         (cygwin_exceptions): Likewise.
 387         (new_group): Likewise.
 388         (debug_exec): Likewise.
 389         (debug_events): Likewise.
 390         (debug_memory): Likewise.
 391         (debug_exceptions): Likewise.
 392         (useshell): Likewise.
 393         * windows-tdep.c (maint_display_all_tib): Likewise.
 394         * xml-support.c (debug_xml): Likewise.
 395
 396 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 397
 398         * source.c (prepare_path_for_appending): New function.
 399         (openp): Make use of new function.
 400         (find_and_open_source): Search for the compilation directory and
 401         source file as a relative path beneath the directory search path.
 402
 403 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * source-cache.c (source_cache::get_line_charpos): Catch
 406         exceptions and return false, this matches the behaviour documented
 407         in the header file.
 408
 409 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 410
 411         * ada-tasks.c (info_task): Remove quoting of the task's name.
 412
 413 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 414
 415         * symfile.c (auto_solib_add): Replace comment with a reference
 416         to the header file.
 417
 418 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 419
 420         * NEWS: Mention that gdb can now be compiled with Python 3
 421         on Windows.
 422
 423 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * maint.c (maint_print_section_data::maint_print_section_data):
 426         Force use of 'float log10 (float)' by casting the argument to
 427         float.
 428
 429 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 430
 431         * maint.c: Add 'cmath' include.
 432         (struct maint_print_section_data): New structure.
 433         (print_section_index): New function.
 434         (print_bfd_section_info): Add header comment, small whitespace
 435         cleanup, and update to call new print_section_index function.
 436         (print_objfile_section_info): Likewise.
 437         (maint_obj_section_from_bfd_section): New function.
 438         (print_bfd_section_info_maybe_relocated): New function.
 439         (maintenance_info_sections): Add header comment, always use
 440         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 441
 442 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 445         inner scope, add check that the objfile has psymtabs before
 446         checking psymtabs_addrmap.
 447         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 448
 449 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 450
 451         * NEWS: Announce that Ada task names are now shown at more places,
 452         and between quotes (except in info task output).
 453         * gdb/ada-tasks.c (task_to_str): New function.
 454         (display_current_task_id): Call task_to_str.
 455         (task_command_1): Likewise.
 456         (print_ada_task_info): In non-mi mode, Properly align headers and data
 457         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 458
 459 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 460
 461         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 462         prstatus.pr_lwp.pr_info instead of making it up.
 463
 464 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 465
 466         * auto-load.c (auto_load_expand_dir_vars): Update.
 467         * defs.h (gdb_datadir): Change to std::string.
 468         (python_libdir): Likewise.
 469         (relocate_gdb_directory): Change return type to std::string.
 470         * guile/guile.c (gdbscm_data_directory): Update.
 471         (initialize_scheme_side): Update.
 472         * jit.c (jit_reader_dir): Change to std::string.
 473         (jit_reader_load_command): Update.
 474         * main.c (gdb_datadir): Change to std::string.
 475         (python_libdir): Likewise.
 476         (set_gdb_data_directory): Update.
 477         (relocate_path): Change to return std::string.
 478         (relocate_gdb_directory): Change to return std::string.
 479         (relocate_gdbinit_path_maybe_in_datadir): Update.
 480         (captured_main_1): Update.
 481         * python/python.c (do_start_initialization): Update.
 482         * top.c (show_gdb_datadir): Update.
 483         * xml-syscall.c (xml_init_syscalls_info): Update.
 484         (init_syscalls_info): Update.
 485
 486 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 487
 488         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 489         out of get_init_files.
 490         (get_init_files): Update.
 491
 492 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 493
 494         * main.c (get_init_files): Change to use std::string.
 495         (captured_main_1): Update.
 496         (print_gdb_help): Update.
 497
 498 2019-09-11  Ali Tamur  <tamur@google.com>
 499
 500         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 501         implementation.
 502
 503 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 504
 505         * dbxread.c (read_dbx_symtab): Update.
 506         * dwarf2read.c (load_partial_dies): Update.
 507         * mdebugread.c (parse_partial_symbols): Update.
 508         (handle_psymbol_enumerators): Update.
 509         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 510         * psymtab.c (add_psymbol_to_bcache): Likewise.
 511         (add_psymbol_to_list): Likewise.
 512         * symtab.c (symbol_set_names): Likewise.
 513         * symtab.h (symbol_set_names): Likewise.
 514         * xcoffread.c (scan_xcoff_symtab): Update.
 515
 516 2019-09-11  Tom Tromey  <tom@tromey.com>
 517
 518         * symfile-mem.c (symbol_file_add_from_memory): Use
 519         bfd_set_filename.
 520         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 521         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 522
 523 2019-09-10  Tom Tromey  <tromey@adacore.com>
 524
 525         * dwarf-index-write.c (write_psymbols): Extend error message.
 526         (debug_names::insert): Add Ada code.
 527         (debug_names::write_psymbols): Remove Ada check.
 528         (debug_names) <m_string_obstack>: New member.
 529         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 530         (gdb_index_symbol_name_matcher::matches): Remove.
 531         (mapped_index_base::find_name_components_bounds): Add "lang"
 532         parameter.
 533         (mapped_index_base::build_name_components): Also split names
 534         according to Ada syntax.
 535         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 536         type of "match_callback".
 537         (check_match, check_find_bounds_finds)
 538         (dw2_expand_symtabs_matching): Update.
 539         (dw2_debug_names_iterator): Add new constructor.
 540         (dw2_debug_names_map_matching_symbols): New function.
 541         (dw2_debug_names_expand_symtabs_matching): Update.
 542         (dwarf2_debug_names_functions): Use
 543         dw2_debug_names_map_matching_symbols.
 544
 545 2019-09-10  Tom Tromey  <tromey@adacore.com>
 546
 547         * dwarf2read.c (dw2_get_file_names_reader): Add the
 548         CU's file name to the results.
 549
 550 2019-09-10  Tom Tromey  <tromey@adacore.com>
 551
 552         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 553         map_matching_symbols.  Update.
 554         * dwarf2read.c (dw2_map_matching_symbols): Update.
 555         * psymtab.c (match_partial_symbol): Change type; update.
 556         (psym_map_matching_symbols): Likewise.
 557         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 558         type; update.
 559         * symfile.h (struct quick_symbol_functions)
 560         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 561         Remove "match".
 562
 563 2019-09-10  Tom Tromey  <tromey@adacore.com>
 564
 565         * psymtab.c (map_block): Remove.
 566         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 567         * symtab.c (iterate_over_symbols_terminated): New function.
 568         * symtab.c (iterate_over_symbols_terminated): Declare.
 569
 570 2019-09-10  Tom Tromey  <tromey@adacore.com>
 571
 572         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 573         * language.h (struct language_defn) <la_iterate_over_symbols>:
 574         Return bool.
 575         * symtab.c (iterate_over_symbols): Return bool.
 576         * symtab.h (iterate_over_symbols): Return bool.
 577
 578 2019-09-10  Tom Tromey  <tromey@adacore.com>
 579
 580         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 581         (add_nonlocal_symbols): Update.
 582         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 583         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 584         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 585         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 586         Change type of "callback".  Remove "data".
 587
 588
 589 2019-09-09  Ali Tamur  <tamur@google.com>
 590
 591         * dwarf2read.c (comp_unit_head): Update comment.
 592         (dwarf2_dwo_name): New function declaration.
 593         (dwarf_unit_type_name): New function declaration.
 594         (read_comp_unit_head): Add support for new compilation units,
 595         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 596         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 597         (currently named as "signature") in their header. Also clarify error
 598         messages.
 599         (lookup_dwo_id): New function. Returns the dwo id of the given
 600         compile unit.
 601         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 602         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 603         functions.
 604         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 605         (dwarf2_dwo_name): Get the dwo name if present.
 606         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 607         purposes.
 608
 609 2019-09-09  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 612
 613 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 614
 615         * python/python.c (do_start_initialization): Make progname_copy static,
 616         to avoid a leak report.
 617
 618 2019-09-08  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 621
 622 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 623
 624         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 625         Change type to gdb::optional<block_enum>.
 626         (dw2_symtab_iter_init): Change block_index parameter type
 627         to gdb::optional<block_enum>.
 628         (dw2_lookup_symbol): Change block_index parameter
 629         type to block_enum.c
 630         (dw2_debug_names_lookup_symbol): Likewise.
 631         * psymtab.c (psym_lookup_symbol): Likewise.
 632         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 633         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 634         Likewise.
 635
 636 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 637
 638         * defs.h (relocate_gdb_directory): Change int to bool in
 639         signature and rename flag to relocatable.
 640         * main.c (relocate_path): Likewise.
 641         (relocate_gdb_directory): Likewise.
 642
 643 2019-09-06  Alan Modra  <amodra@gmail.com>
 644
 645         * coffread.c (coff_symfile_read): Constify filename variable.
 646         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 647         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 648         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 649         * solib.c (reload_shared_libraries_1): Likewise.
 650         * symfile.c (reread_symbols): Likewise.
 651         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 652         * solib-darwin.c (darwin_bfd_open): Likewise.
 653         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 654
 655 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 656
 657         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 658         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 659
 660 2019-09-03  Tom Tromey  <tromey@adacore.com>
 661
 662         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 663         types.
 664         (has_negatives): Unbias a range type bound.
 665         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 666         * gdbtypes.c (operator==): Handle new field.
 667         (create_range_type): Add "bias" parameter.
 668         (create_static_range_type, resolve_dynamic_range): Update.
 669         * gdbtypes.h (struct range_bounds) <bias>: New member.
 670         (create_range_type): Add bias parameter.
 671         * printcmd.c (print_scalar_formatted): Unbias range types.
 672         * value.c (unpack_long): Unbias range types.
 673         (pack_long): Bias range types.
 674
 675 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 676
 677         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 678         probe arguments.
 679
 680 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 681
 682         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 683         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 684         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 685         (compile_probe_arg): Likewise.
 686         * probe.h (get_argument_count): Likewise.
 687         * solib-svr4.c (solib_event_probe_action): Likewise.
 688         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 689
 690 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 691
 692         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 693         code to here...
 694         (svr4_create_solib_event_breakpoints): ...from here.
 695
 696 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 697
 698         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 699         suffix from warning message.
 700
 701 2019-08-30  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-winsource.h (struct tui_source_window_base)
 704         <refresh_all>: Don't declare.
 705         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 706         Remove.
 707         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 708         tui_show_locator_content.
 709         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 710         declare.
 711         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 712         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 713         declare.
 714
 715 2019-08-30  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 718
 719 2019-08-30  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 722         Remove unnecessary forward declarations.
 723
 724 2019-08-30  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 727         rerender.
 728         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 729         tui_show_locator_content.
 730
 731 2019-08-30  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 734         (tui_locator_window::rerender): Rewrite using body of previous
 735         tui_show_locator_content.
 736
 737 2019-08-30  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 740         set_locator_fullname>: New methods.
 741         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 742         Rename from tui_set_locator_fullname.
 743         (tui_locator_window::set_locator_info): Rename from
 744         tui_set_locator_info.  Return bool.
 745         (tui_update_locator_fullname, tui_show_frame_info): Update.
 746
 747 2019-08-30  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 750
 751 2019-08-30  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 754         call touchwin.
 755
 756 2019-08-30  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-wingeneral.c (box_win): Assume win_info and
 759         win_info->handle cannot be NULL.
 760
 761 2019-08-30  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 764         refresh_window>: Declare.
 765         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 766         resize.
 767         (tui_data_item_window::rerender): Rename from
 768         tui_display_register.
 769         (tui_data_item_window::refresh_window): New method.
 770         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 771         no-op.
 772
 773 2019-08-30  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 776         regs_column_count, current_group>: Move later.  Now private.
 777         <get_current_group>: New method.
 778         * tui/tui-regs.c (tui_reg_command): Update.
 779         * tui/tui-layout.c (tui_set_layout): Update.
 780
 781 2019-08-30  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 784         (tui_data_window::rerender): Don't call
 785         check_and_display_highlight_if_needed.
 786         (tui_data_window::refresh_all): Remove call to
 787         erase_data_content.
 788
 789 2019-08-30  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 792         (tui_data_window::display_registers_from)
 793         (tui_data_window::display_reg_element_at_line)
 794         (tui_data_window::display_registers_from_line): Remove checks of
 795         "empty".
 796
 797 2019-08-30  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 800         Don't declare.
 801         * tui/tui-regs.c (tui_data_window::show_registers): Call
 802         rerender.
 803         (tui_data_window::rerender): Rename from display_all_data.
 804         (tui_data_window::rerender): Remove old implementation.
 805
 806 2019-08-30  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 809         text.
 810         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 811
 812 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 813             Sergio Durigan Junior  <sergiodj@redhat.com>
 814
 815         PR win32/24284
 816         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 817
 818 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 821         when searching for types.
 822
 823 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * f-lang.c (f_language_defn): Use f_print_typedef.
 826         * f-lang.h (f_print_typedef): Declare.
 827         * f-typeprint.c (f_print_typedef): Define.
 828
 829 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 830
 831         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 832
 833 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * cli/cli-utils.c (info_print_options_defs): Delete.
 836         (make_info_print_options_def_group): Delete.
 837         (extract_info_print_options): Delete.
 838         (info_print_command_completer): Delete.
 839         (info_print_args_help): Add extra parameter, and optionally
 840         include text about -n flag.
 841         * cli/cli-utils.h (struct info_print_options): Delete.
 842         (extract_info_print_options): Delete declaration.
 843         (info_print_command_completer): Delete declaration.
 844         (info_print_args_help): Add extra parameter, extend header
 845         comment.
 846         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 847         search_symbols.
 848         * stack.c (struct info_print_options): New type.
 849         (info_print_options_defs): New file scoped variable.
 850         (make_info_print_options_def_group): New static function.
 851         (info_print_command_completer): New static function.
 852         (info_locals_command): Update to use new local functions.
 853         (info_args_command): Likewise.
 854         (_initialize_stack): Add extra parameter to calls to
 855         info_print_args_help.
 856         * symtab.c (search_symbols): Add extra parameter, use this to
 857         possibly excluse non-debug symbols.
 858         (symtab_symbol_info): Add extra parameter, which is passed on to
 859         search_symbols.
 860         (struct info_print_options): New type.
 861         (info_print_options_defs): New file scoped variable.
 862         (make_info_print_options_def_group): New static function.
 863         (info_print_command_completer): New static function.
 864         (info_variables_command): Update to use local functions, and pass
 865         extra parameter through to symtab_symbol_info.
 866         (info_functions_command): Likewise.
 867         (info_types_command): Pass additional argument through to
 868         symtab_symbol_info.
 869         (rbreak_command): Pass extra argument to search_symbols.
 870         (_initialize_symtab): Add extra arguments for calls to
 871         info_print_args_help, and update help text for 'info variables',
 872         'whereis', and 'info functions' commands.
 873         * symtab.h (search_symbols): Add extra argument to declaration.
 874         * NEWS: Mention new flags.
 875
 876 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 877
 878         * symtab.c (lookup_static_symbol): Call the new function (and move
 879         it down to be next to lookup_global_symbol).
 880         (struct global_sym_lookup_data): Add block_enum member and rename to...
 881         (struct global_or_static_sym_lookup_data): ...this.
 882         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 883         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 884         (lookup_symbol_global_or_static_iterator_cb): ...this.
 885         (lookup_global_or_static_symbol): New function.
 886         (lookup_global_symbol): Call new function.
 887
 888 2019-08-26  Tom de Vries  <tdevries@suse.de>
 889
 890         PR c++/24852
 891         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 892         when pc_probe.prob == NULL.
 893
 894 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 895
 896         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 897         variable symbol_linkage to symbol_linkage_.
 898
 899 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 900
 901         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 902         represent whether the symbol is static, dynamic, or we don't
 903         know.
 904
 905 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 906
 907         * gdb/rx-tdep.c (rx_register_names): New.
 908         (rx_register_name): Delete.
 909         (rx_psw_type): Delete.
 910         (rx_fpsw_type): Delete.
 911         (rx_register_type): Delete.
 912         (rx_gdbarch_init): Convert target-descriptions.
 913         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 914         * gdb/features/Makefile: Add rx.xml.
 915         * gdb/features/rx.xml: New.
 916         * gdb/features/rx.c: Generated.
 917         * gdb/NEWS: Mention target description support.
 918
 919 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 920
 921         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 922         *slot_ptr.
 923
 924 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 925
 926         * configure.ac: Don't check for 'dlfcn.h' (moved to
 927         gdbsupport/common.m4).
 928         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 929         'gdbsupport/'.
 930         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 931         * compile/compile-c-support.c: Include
 932         'gdbsupport/gdb-dlfcn.h'.
 933         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 934         * gdb-dlfcn.c: Move to...
 935         * gdbsupport/gdb-dlfcn.c: ... here.
 936         * gdb-dlfcn.h: Move to...
 937         * gdbsupport/gdb-dlfcn.h: ... here.
 938
 939 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 940
 941         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 942         the offset field signed.
 943
 944 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 945
 946         * python/lib/gdb/__init__.py (_execute_file): New function.
 947         * python/python.c (python_run_simple_file): Call gdb._execute_file
 948         on Windows.
 949
 950 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 953         all uses as this was never set to anything but a zero value.
 954
 955 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 956
 957         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 958
 959 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 960
 961         * tui/tui-data.h (tui_gen_win_info): Add an =default
 962         move constructor, required by some GCC versions.
 963
 964 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 965
 966         * go32-nat.c (go32_sysinfo): Add hygon_p.
 967
 968 2019-08-20  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 971         line_from_reg_element_no, first_reg_element_no_inline,
 972         display_all_data, delete_data_content_windows,
 973         erase_data_content>: Now private.
 974
 975 2019-08-20  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 978         (tui_unhighlight_win, tui_highlight_win)
 979         (tui_win_info::make_window): Update.
 980         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 981
 982 2019-08-20  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 985         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 986         (MAX_PID_WIDTH): Move to tui-stack.c.
 987         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 988         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 989         (MAX_PID_WIDTH): Move from tui-data.h.
 990
 991 2019-08-20  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 994         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 995         (box_win): Update.
 996         (tui_gen_win_info::make_window): Rename from tui_make_window.
 997         (tui_win_info::make_window): New method.
 998         (tui_gen_win_info::make_visible): Update.
 999         * tui/tui-source.c (tui_source_window::set_contents): Update.
1000         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1001         (tui_data_window::display_registers_from): Update.
1002         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1003         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1004         Declare.
1005         <can_box>: Remove.
1006         <title>: Remove.
1007         (struct tui_win_info) <make_window>: Declare.
1008         <can_box>: Now virtual.
1009         <title>: New member.
1010         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1011         * tui/tui-command.c (tui_cmd_window::resize): Update.
1012
1013 2019-08-20  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1016         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1017         (tui_data_window::check_register_values): Update.
1018
1019 2019-08-20  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-regs.h (struct tui_data_window): Use
1022         DISABLE_COPY_AND_ASSIGN.
1023         <regs_content>: Change type, removing unique_ptr.
1024         <tui_data_window>: Add move constructor.
1025         * tui/tui-regs.c (tui_data_window::show_registers)
1026         (tui_data_window::show_register_group)
1027         (tui_data_window::display_registers_from)
1028         (tui_data_window::display_registers_from)
1029         (tui_data_window::first_data_item_displayed)
1030         (tui_data_window::delete_data_content_windows)
1031         (tui_data_window::rerender, tui_data_window::refresh_window)
1032         (tui_data_window::check_register_values): Update.
1033
1034 2019-08-20  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1037         show_register_group>: Declare.
1038         (tui_show_register_group): Don't declare.
1039         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1040         tui_show_registers.
1041         (tui_data_window::show_register_group): Rename from
1042         tui_show_register_group.
1043         (tui_data_window::check_register_values, tui_reg_command):
1044         Update.
1045         * tui/tui-layout.c (tui_set_layout): Update.
1046
1047 2019-08-20  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1050         Declare.
1051         (tui_check_register_values): Don't declare.
1052         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1053         from tui_check_register_values.
1054         * tui/tui-hooks.c (tui_register_changed): Update.
1055
1056 2019-08-20  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-regs.c (tui_reg_layout): Move later.
1059         (tui_show_registers): Don't enable TUI mode or change layout.
1060
1061 2019-08-20  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-regs.h (struct tui_data_item_window)
1064         <~tui_data_item_window>: Remove.
1065         <content>: Now a unique_xmalloc_ptr.
1066         * tui/tui-regs.c (tui_register_format): Return a
1067         unique_xmalloc_ptr.
1068         (tui_get_register): Update.
1069         (~tui_data_item_window): Remove.
1070         (tui_data_window::display_registers_from, tui_display_register):
1071         Update.
1072         * tui/tui-io.h (tui_expand_tabs): Update.
1073         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1074         Remove "col" parameter.
1075
1076 2019-08-20  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1079         field.
1080         * tui/tui-regs.c (~tui_data_item_window): Update.
1081
1082 2019-08-20  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1085         earlier.
1086
1087 2019-08-20  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1090
1091 2019-08-20  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-source.h (struct tui_source_window): Update.
1094         * tui/tui-regs.c (tui_show_registers): Update.
1095         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1096         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1097         (NO_REGS_STRING): Remove defines.
1098
1099 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1100
1101         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1102         unnecessary thread walk if remote doesn't support the packet.
1103
1104 2019-08-19  Tom Tromey  <tromey@adacore.com>
1105
1106         * python/py-value.c (value_has_field): Fix indentation.
1107
1108 2019-08-19  Tom Tromey  <tromey@adacore.com>
1109
1110         * printcmd.c (do_one_display, info_display_command): Update.
1111         * block.h (contained_in): Return bool.  Add allow_nested
1112         parameter.
1113         * block.c (contained_in): Return bool.  Add allow_nested
1114         parameter.
1115
1116 2019-08-19  Tom Tromey  <tom@tromey.com>
1117
1118         * configure: Rebuild.
1119         * configure.ac: Disallow the combination of -static-libstdc++ and
1120         source highlight.
1121         * source-cache.c (get_language_name): Handle rust.
1122         (source_cache::get_source_lines): Ignore highlighting exceptions.
1123
1124 2019-08-16  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1127         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1128         (struct tui_source_window_base) <make_visible, refresh_window,
1129         resize>: Remove methods.
1130         <execution_info>: Remove field.
1131         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1132         (tui_show_source_line, tui_source_window_base)
1133         (~tui_source_window_base): Update.
1134         (tui_source_window_base::resize)
1135         (tui_source_window_base::make_visible)
1136         (tui_source_window_base::refresh_window): Remove.
1137         (tui_source_window_base::update_exec_info): Update.
1138         * tui/tui-source.c (tui_source_window::set_contents): Update.
1139         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1140
1141 2019-08-16  Tom Tromey  <tom@tromey.com>
1142
1143         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1144         deprecated_query_hook.
1145
1146 2019-08-16  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1149         (tui_update_source_windows_with_line): Update.
1150         * tui/tui-source.h (struct tui_source_window)
1151         <show_symtab_source>: Declare.
1152         (tui_show_symtab_source): Don't declare.
1153         * tui/tui-source.c (tui_show_symtab_source): Rename from
1154         tui_show_symtab_source.
1155
1156 2019-08-16  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-winsource.h (struct tui_source_window_base)
1159         <set_contents>: Declare.
1160         * tui/tui-winsource.c
1161         (tui_source_window_base::update_source_window_as_is): Update.
1162         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1163         Declare.
1164         (tui_set_source_content): Don't declare.
1165         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1166         tui_set_source_content.
1167         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1168         Declare.
1169         (tui_set_disassem_content): Don't declare.
1170         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1171         tui_set_disassem_content.
1172
1173 2019-08-16  Tom Tromey  <tom@tromey.com>
1174
1175         * tui/tui-winsource.h (struct tui_source_window_base)
1176         <update_breakpoint_info>: Declare.
1177         (tui_update_breakpoint_info): Don't declare.
1178         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1179         (tui_update_all_breakpoint_info): Update.
1180         (tui_source_window_base::update_breakpoint_info): Rename from
1181         tui_update_breakpoint_info.
1182         (tui_source_window_base::update_exec_info): Update.
1183
1184 2019-08-16  Tom Tromey  <tom@tromey.com>
1185
1186         * tui/tui-winsource.h (struct tui_source_window_base)
1187         <update_source_window>: Declare.
1188         (tui_update_source_window): Don't declare.
1189         * tui/tui-winsource.c
1190         (tui_source_window_base::update_source_window): Rename from
1191         tui_update_source_window.
1192         (tui_source_window_base::rerender): Update.
1193         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1194         * tui/tui-disasm.c (tui_show_disassem)
1195         (tui_show_disassem_and_update_source)
1196         (tui_disasm_window::maybe_update): Update.
1197
1198 2019-08-16  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-winsource.h (struct tui_source_window_base)
1201         <update_source_window_as_is>: Declare.
1202         (tui_update_source_window_as_is): Don't declare.
1203         * tui/tui-winsource.c (tui_update_source_window): Update
1204         (tui_source_window_base::update_source_window_as_is): Rename from
1205         tui_update_source_window_as_is.
1206         (tui_source_window_base::refill): Update.
1207         * tui/tui-source.c (tui_show_symtab_source): Update.
1208         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1209         Update.
1210
1211 2019-08-16  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-winsource.h (tui_update_source_window)
1214         (tui_update_source_window_as_is): Remove "noerror" parameter.
1215         * tui/tui-winsource.c (tui_update_source_window)
1216         (tui_update_source_window_as_is): Remove "noerror" parameter.
1217         (tui_update_source_windows_with_addr)
1218         (tui_update_source_windows_with_line)
1219         (tui_source_window_base::rerender)
1220         (tui_source_window_base::refill): Update.
1221         * tui/tui-source.h (tui_set_source_content)
1222         (tui_show_symtab_source): Remove "noerror" parameter.
1223         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1224         parameter.
1225         (tui_show_symtab_source): Likewise.
1226         (tui_source_window::maybe_update): Update.
1227         * tui/tui-disasm.c (tui_show_disassem)
1228         (tui_show_disassem_and_update_source)
1229         (tui_disasm_window::do_scroll_vertical)
1230         (tui_disasm_window::maybe_update): Update.
1231
1232 2019-08-16  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui.c (tui_is_window_visible): Update.
1235         * tui/tui-wingeneral.c (tui_make_window)
1236         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1237         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1238         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1239         (tui_set_win_height_command, parse_scrolling_args): Update.
1240         * tui/tui-source.c (tui_source_window::style_changed): Update.
1241         * tui/tui-regs.c (tui_show_registers)
1242         (tui_data_window::first_data_item_displayed)
1243         (tui_data_window::delete_data_content_windows)
1244         (tui_check_register_values, tui_reg_command): Update.
1245         * tui/tui-disasm.c (tui_show_disassem): Update.
1246         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1247         method.
1248         <is_visible>: Remove field.
1249         * tui/tui-data.c (tui_next_win, tui_prev_win)
1250         (tui_delete_invisible_windows): Update.
1251
1252 2019-08-16  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-winsource.h (struct tui_source_window_base)
1255         <m_has_locator>: Remove.
1256         * tui/tui-layout.c (show_source_disasm_command, show_data)
1257         (show_source_or_disasm_and_command): Update.
1258
1259 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1260
1261         * NEWS (Other MI changes): New subsection.
1262         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1263         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1264         * arch-utils.c (default_get_pc_address_flags): New function.
1265         * arch-utils.h (default_get_pc_address_flags): New declaration.
1266         * gdbarch.sh: Add get_pc_address_flags.
1267         * gdbarch.c: Regenerate.
1268         * gdbarch.h: Likewise.
1269         * stack.c (print_pc): New function.
1270         (print_frame_info) (print_frame): Call print_pc.
1271
1272 2019-08-16  Tom de Vries  <tdevries@suse.de>
1273
1274         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1275         print_objfile_section_info.
1276
1277 2019-08-15  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1280         calling update_cmdwin_start_line.
1281         * tui/tui-winsource.h (struct tui_source_window_base)
1282         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1283         <rerender>: Declare.
1284         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1285         Call rerender.
1286         (tui_source_window_base::set_new_height): Remove.
1287         (tui_source_window_base::rerender): Rename from
1288         do_make_visible_with_new_height.
1289         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1290         resize method.
1291         (tui_win_info::make_invisible_and_set_new_height)
1292         (tui_win_info::make_visible_with_new_height): Remove.
1293         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1294         Declare.
1295         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1296         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1297         do_make_visible_with_new_height>: Don't declare.
1298         <rerender>: Declare.
1299         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1300         set_new_height.
1301         (tui_data_window::do_make_visible_with_new_height): Remove.
1302         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1303         call tui_show_locator_content.
1304         (tui_gen_win_info::resize): Call rerender.
1305         (show_source_or_disasm_and_command): Don't call
1306         tui_show_locator_content.
1307         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1308         method.
1309         (struct tui_win_info) <rerender>: Declare.
1310         <set_new_height, make_invisible_and_set_new_height,
1311         make_visible_with_new_height>: Don't declare.
1312         * tui/tui-data.c (tui_win_list::rerender): New method.
1313         * tui/tui-command.h (struct tui_cmd_window)
1314         <do_make_visible_with_new_height>: Don't declare.
1315         * tui/tui-command.c
1316         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1317
1318 2019-08-15  Tom Tromey  <tromey@adacore.com>
1319
1320         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1321         * ada-lang.c (ada_enum_name): Likewise.
1322
1323 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1324
1325         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1326         leading underscore.
1327         (GdbOutputErrorFile): Likewise.
1328         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1329         accordingly.
1330         (execute_unwinders): Rename to have a leading underscore.
1331         (auto_load_packages): Likewise.
1332         (global scope): Adjust call to auto_load_packages accordingly.
1333         (GdbSetPythonDirectory): Likewise.
1334         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1335         instead of execute_unwinders.
1336
1337 2019-08-15  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1340         (show_data): Don't change window visibility.
1341         (tui_gen_win_info::resize): Remove special case for command
1342         window.  Use wresize, when available.
1343         (show_source_or_disasm_and_command): Don't change window
1344         visibility.
1345         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1346         <make_visible>: New method.
1347         * tui/tui-command.c (tui_cmd_window::resize): New method.
1348
1349 2019-08-15  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1352         (struct tui_source_windows): New.
1353         * tui/tui-winsource.c (tui_display_main): Update.
1354         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1355         (new_height_ok, parse_scrolling_args): Update.
1356         * tui/tui-layout.c (show_layout, show_data): Update.
1357         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1358         (tui_add_to_source_windows): Don't declare.
1359         * tui/tui-data.c (source_windows, tui_source_windows)
1360         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1361
1362 2019-08-15  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1365         Rename from reset.
1366         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1367         * tui/tui-layout.c (show_source_disasm_command, show_data):
1368         Update.
1369         (tui_gen_win_info::resize): Rename.
1370         (show_source_or_disasm_and_command): Update.
1371         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1372         reset.
1373
1374 2019-08-15  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1377         * tui/tui-interp.c (tui_interp::init): Don't call
1378         tui_initialize_static_data.
1379         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1380
1381 2019-08-15  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1384         examine tui_win_list.
1385
1386 2019-08-15  Tom Tromey  <tom@tromey.com>
1387
1388         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1389         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1390         tui_clear_source_content.
1391         (tui_clear_source_content): Remove.
1392         (tui_source_window_base::do_erase_source_content): Hoist call to
1393         content.clear().
1394         * tui/tui-stack.c (tui_show_frame_info): Don't call
1395         tui_clear_source_content.
1396
1397 2019-08-15  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-winsource.h (struct tui_source_window_base)
1400         <do_erase_source_content>: New method.
1401         <erase_source_content>: New method.
1402         (tui_erase_source_content): Don't declare.
1403         * tui/tui-winsource.c (tui_clear_source_content): Update.
1404         (tui_source_window_base::do_erase_source_content): Rename from
1405         tui_erase_source_content.
1406         (tui_source_window_base::show_source_content): Update.
1407         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1408         * tui/tui-source.h (struct tui_source_window)
1409         <erase_source_content>: New method.
1410         * tui/tui-disasm.h (struct tui_disasm_window)
1411         <erase_source_content>: New method.
1412
1413 2019-08-15  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1416         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1417         constructor.
1418         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1419         * tui/tui-source.c (tui_set_source_content): Update.
1420         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1421
1422 2019-08-15  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1425         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1426         tui-source.c.
1427         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1428         Declare.
1429         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1430         method.
1431         (tui_source_window::maybe_update): Update.
1432
1433 2019-08-15  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1436         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1437         tui-disasm.c.
1438         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1439         Declare.
1440         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1441         method.
1442         (tui_disasm_window::maybe_update): Update.
1443
1444 2019-08-15  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-winsource.h (struct tui_source_window_base)
1447         <maybe_update>: Declare.
1448         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1449         method.
1450         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1451         Declare.
1452         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1453         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1454         Declare.
1455         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1456
1457 2019-08-15  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1460
1461 2019-08-15  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-wingeneral.c: Include tui-stack.h.
1464         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1465         (struct tui_locator_window): Move from tui-data.h.
1466         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1467         (tui_initialize_static_data): Move from tui-data.c.
1468         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1469         (struct tui_locator_window): Move to tui-stack.c.
1470         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1471         (tui_initialize_static_data): Move to tui-stack.c.
1472
1473 2019-08-15  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-layout.c (show_source_disasm_command)
1476         (show_source_or_disasm_and_command): Use make_visible method, not
1477         tui_make_window.
1478         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1479         Remove.
1480
1481 2019-08-15  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-wingeneral.h (tui_make_window): Update.
1484         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1485         parameter.
1486         (tui_gen_win_info::make_visible): Update.
1487         * tui/tui-regs.c (tui_data_window::display_registers_from):
1488         Update.
1489         * tui/tui-layout.c (show_source_disasm_command)
1490         (show_source_or_disasm_and_command): Update.
1491         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1492         (enum tui_box): Remove.
1493         (struct tui_win_info) <can_box>: New method.
1494         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1495         method.
1496
1497 2019-08-15  Tom de Vries  <tdevries@suse.de>
1498
1499         * linux-nat-trad.c: Include gdbarch.h.
1500
1501 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1502
1503         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1504         register sizes.
1505
1506 2019-08-14  Tom Tromey  <tromey@adacore.com>
1507
1508         * darwin-nat.c: Include gdbarch.h.
1509         * darwin-nat-info.c: Include gdbarch.h.
1510
1511 2019-08-13  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1514         Remove.
1515         * tui/tui-data.c (tui_initialize_static_data): Update.
1516
1517 2019-08-13  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-winsource.h (struct tui_exec_info_window)
1520         <~tui_exec_info_window, maybe_allocate_content, get_content,
1521         m_content>: Remove.
1522         (struct tui_source_window_base) <set_exec_info_content,
1523         show_exec_info_content>: Don't declare.
1524         * tui/tui-winsource.c
1525         (tui_exec_info_window::maybe_allocate_content): Remove.
1526         (tui_source_window_base::update_exec_info): Rename from
1527         set_exec_info_content.
1528         (tui_source_window_base::show_exec_info_content)
1529         (tui_source_window_base::update_exec_info): Remove.
1530
1531 2019-08-13  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1534         declare.
1535         * tui/tui-winsource.c (tui_update_source_window_as_is)
1536         (tui_update_source_windows_with_addr, tui_erase_source_content):
1537         Update.
1538         (tui_clear_exec_info_content): Remove.
1539
1540 2019-08-13  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1543         declare.
1544         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1545         call tui_erase_exec_info_content.
1546         (tui_clear_exec_info_content): Rename from
1547         tui_erase_exec_info_content.
1548         (tui_clear_exec_info_content): Delete.
1549
1550 2019-08-13  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-winsource.h (struct tui_source_window_base)
1553         <show_exec_info_content>: Declare.
1554         (tui_show_exec_info_content): Don't declare.
1555         * tui/tui-winsource.c
1556         (tui_source_window_base::show_exec_info_content): Rename from
1557         tui_show_exec_info_content.
1558         (tui_source_window_base::update_exec_info): Update.
1559
1560 2019-08-13  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1563         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1564         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1565         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1566         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1567         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1568         ... here.
1569
1570 2019-08-13  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-winsource.h (struct tui_source_window_base)
1573         <update_exec_info>: Declare.
1574         (tui_update_exec_info): Don't declare.
1575         * tui/tui-winsource.c (tui_update_source_window_as_is)
1576         (tui_source_window_base::refresh_all)
1577         (tui_update_all_breakpoint_info): Update.
1578         (tui_source_window_base::update_exec_info): Rename from
1579         tui_update_exec_info.
1580         * tui/tui-stack.c (tui_show_frame_info): Update.
1581
1582 2019-08-13  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-winsource.h (struct tui_source_window_base)
1585         <set_exec_info_content>: Declare.
1586         (tui_set_exec_info_content): Don't declare.
1587         * tui/tui-winsource.c
1588         (tui_source_window_base::set_exec_info_content): Rename from
1589         tui_set_exec_info_content.
1590         (tui_update_exec_info): Update.
1591
1592 2019-08-13  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-winsource.h (struct tui_source_window_base)
1595         <show_source_content>: Declare.
1596         (tui_show_source_content): Don't declare.
1597         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1598         (tui_source_window_base::show_source_content): Rename from
1599         tui_show_source_content.
1600         (tui_source_window_base::refresh_all): Update.
1601         * tui/tui-layout.c (show_source_disasm_command)
1602         (show_source_or_disasm_and_command): Update.
1603
1604 2019-08-13  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-winsource.c (tui_erase_source_content)
1607         (tui_show_source_content, tui_source_window_base::refresh_all):
1608         Update.
1609         * tui/tui-wingeneral.h
1610         (tui_check_and_display_highlight_if_needed): Don't declare.
1611         * tui/tui-wingeneral.c
1612         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1613         check_and_display_highlight_if_needed.
1614         * tui/tui-win.c (tui_rehighlight_all)
1615         (tui_win_info::make_visible_with_new_height): Update.
1616         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1617         (tui_data_window::erase_data_content)
1618         (tui_data_window::display_all_data): Update.
1619         * tui/tui-data.h (struct tui_win_info)
1620         <check_and_display_highlight_if_needed>: Declare.
1621
1622 2019-08-13  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-win.c (tui_resize_all): Call
1625         tui_delete_invisible_windows.
1626         * tui/tui-layout.c (show_layout): Call
1627         tui_delete_invisible_windows.
1628         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1629         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1630
1631 2019-08-13  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1634         tui_add_win_to_layout.
1635
1636 2019-08-13  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1639         * tui/tui-layout.c (tui_default_win_height): Now static.
1640
1641 2019-08-13  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1644         single switch.
1645         (show_source_disasm_command, show_source_or_disasm_and_command):
1646         Don't check current layout.
1647
1648 2019-08-13  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-wingeneral.c (make_all_visible): Remove.
1651         (tui_make_all_invisible): Simplify.
1652         * tui/tui-layout.c (tui_make_all_invisible): Move from
1653         tui-wingeneral.c; simplify.
1654         (show_layout): Hoist call to tui_make_all_invisible.
1655         (show_data): Don't call tui_make_all_invisible.
1656
1657 2019-08-13  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1660         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1661
1662 2019-08-13  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1665         tui-data.c.
1666         (show_source_disasm_command, show_data)
1667         (show_source_or_disasm_and_command): Don't use
1668         tui_set_current_layout_to.
1669         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1670         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1671         tui-layout.c.
1672         (tui_set_current_layout_to): Remove.
1673
1674 2019-08-13  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-layout.c (tui_set_layout): Update.
1677         * tui/tui-data.h (struct tui_layout_def): Remove.
1678         (tui_layout_def): Don't declare.
1679         * tui/tui-data.c (layout_def): Remove.
1680         (tui_layout_def): Remove.
1681
1682 2019-08-13  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-winsource.h (struct tui_source_window_base)
1685         <clear_detail>: No longer "override".
1686         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1687         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1688         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1689         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1690         Remove.
1691         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1692
1693 2019-08-13  Tom Tromey  <tromey@adacore.com>
1694
1695         * tracepoint.c: Don't include readline.h or history.h.
1696
1697 2019-08-12  Tom Tromey  <tom@tromey.com>
1698
1699         * configure: Rebuild.
1700         * configure.ac: Check for readline 7.
1701         * NEWS: Mention readline 7 requirement.
1702         * README: Update.
1703
1704 2019-08-12  Tom Tromey  <tom@tromey.com>
1705
1706         * mingw-hdep.c (gdb_select): Remove readline hack.
1707
1708 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1709
1710         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1711         when the function fails.
1712
1713 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1714
1715         * s390-tdep.c (s390_type_align): New function.
1716         (s390_gdbarch_init): Set it as type_align gdbarch method.
1717
1718 2019-08-09  Tom de Vries  <tdevries@suse.de>
1719
1720         PR gdb/24591
1721         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1722         pc_low with relocation offset.
1723
1724 2019-08-07  Tom Tromey  <tromey@adacore.com>
1725
1726         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1727         (print_frame_args): Update.
1728         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1729         Update.
1730         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1731         * frame.h (struct frame_arg): Add initializers.
1732         <error>: Now a unique_xmalloc_ptr.
1733
1734 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1735
1736         * NEWS: Expand the Pointer Authentication entry.
1737         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1738         (aarch64_frame_unmask_lr): ... to this.
1739         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1740         Call aarch64_frame_unmask_lr.
1741         * frame.c (struct frame_info): Add "masked" variable.
1742         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1743         (fprint_frame): Check for masked pc.
1744         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1745         declarations.
1746         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1747         * stack.c (print_frame): Check for masked pc.
1748
1749 2019-08-06  Tom Tromey  <tom@tromey.com>
1750
1751         * stabsread.c (patch_block_stabs, read_one_struct_field)
1752         (read_enum_type): Use obstack_strndup.
1753         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1754         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1755         * dwarf2read.c (guess_full_die_structure_name)
1756         (anonymous_struct_prefix): Use obstack_strndup.
1757         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1758         * c-exp.y (yylex): Use obstack_strndup.
1759         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1760         (write_var_or_type): Use obstack_strndup.
1761
1762 2019-08-06  Tom Tromey  <tom@tromey.com>
1763
1764         * symfile.c (reread_symbols): Use obstack_strdup.
1765         * stabsread.c (read_type): Use obstack_strdup.
1766         * gdb_obstack.h (obstack_strdup): New overload.
1767         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1768         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1769         (dwarf2_canonicalize_name): Use obstack_strdup.
1770         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1771         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1772         Use obstack_strdup.
1773
1774 2019-08-06  Tom Tromey  <tom@tromey.com>
1775
1776         * gdb_obstack.h (obstack_strdup): Define.
1777         * gdb_obstack.c (obstack_strdup): Don't define.
1778
1779 2019-08-06  Tom Tromey  <tom@tromey.com>
1780
1781         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1782         obstack_strdup.
1783         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1784         obstack_strdup.
1785         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1786         * stabsread.c (common_block_start): Use obstack_strdup.
1787         * objfiles.c (set_objfile_main_name, objfile): Use
1788         obstack_strdup.
1789         * namespace.c (add_using_directive): Use obstack_strdup.
1790         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1791         * jit.c (finalize_symtab): Use obstack_strdup.
1792         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1793         (guess_partial_die_structure_name, partial_die_info::fixup)
1794         (dwarf2_name): Use obstack_strdup.
1795         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1796         obstack_strdup.
1797         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1798         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1799         obstack_strdup.
1800         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1801
1802 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1803
1804         * unittests/help-doc-selftests.c: New file.
1805         * Makefile.in: Add the new file.
1806
1807 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1808
1809         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1810         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1811         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1812         the trailing '.' is not output, and the first character is uppercased.
1813         (print_help_for_command): Update call to print_doc_line.
1814         (print_doc_of_command): Likewise.
1815         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1816         * cli/cli-option.c (append_indented_doc): Do not append newline.
1817         (build_help_option): Append newline after first appended_indented_doc
1818         only if a second call is done.
1819         (build_help): Append 2 new lines before each option, except the first
1820         one.
1821         * compile/compile.c (_initialize_compile): Add new lines after
1822         %OPTIONS%, when not at the end of the help.
1823         Change help doc or code
1824         producing the help doc to respect the invariants.
1825         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1826         Also removed the new line after 'Options:', as all other commands
1827         do not put an empty line between 'Options:' and the first option.
1828         * printcmd.c (_initialize_printcmd): Likewise.
1829         * stack.c (_initialize_stack): Likewise.
1830         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1831         incorrectly telling COMMAND is optional.
1832         * ada-lang.c (_initialize_ada_language): Change help doc or code
1833         producing the help doc to respect the invariants.
1834         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1835         * breakpoint.c (_initialize_breakpoint): Likewise.
1836         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1837         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1838         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1839         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1840         _initialize_cli_style): Likewise.
1841         * corelow.c (core_target_info): Likewise.
1842         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1843         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1844         * filesystem.c (_initialize_filesystem): Likewise.
1845         * frame.c (_initialize_frame): Likewise.
1846         * gnu-nat.c (add_task_commands): Likewise.
1847         * infcall.c (_initialize_infcall): Likewise.
1848         * infcmd.c (_initialize_infcmd): Likewise.
1849         * interps.c (_initialize_interpreter): Likewise.
1850         * language.c (_initialize_language): Likewise.
1851         * linux-fork.c (_initialize_linux_fork): Likewise.
1852         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1853         * maint.c (_initialize_maint_cmds): Likewise.
1854         * memattr.c (_initialize_mem): Likewise.
1855         * printcmd.c (_initialize_printcmd): Likewise.
1856         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1857         _RegEx): Likewise.
1858         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1859         * record-btrace.c (_initialize_record_btrace): Likewise.
1860         * record-full.c (_initialize_record_full): Likewise.
1861         * record.c (_initialize_record): Likewise.
1862         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1863         * regcache.c (_initialize_regcache): Likewise.
1864         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1865         _initialize_remote): Likewise.
1866         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1867         * serial.c (_initialize_serial): Likewise.
1868         * skip.c (_initialize_step_skip): Likewise.
1869         * source.c (_initialize_source): Likewise.
1870         * stack.c (_initialize_stack): Likewise.
1871         * symfile.c (_initialize_symfile): Likewise.
1872         * symtab.c (_initialize_symtab): Likewise.
1873         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1874         * top.c (init_main): Likewise.
1875         * tracefile-tfile.c (tfile_target_info): Likewise.
1876         * tracepoint.c (_initialize_tracepoint): Likewise.
1877         * tui/tui-win.c (_initialize_tui_win): Likewise.
1878         * utils.c (add_internal_problem_command): Likewise.
1879         * valprint.c (value_print_option_defs): Likewise.
1880
1881 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1882
1883         PR build/24886
1884         * configure.ac: Drop enable-libmcheck support.
1885         * configure, config.in: Rebuild.
1886         * libmcheck.m4: Remove.
1887         * acinclude.m4: Don't include it.
1888         * Makefile.in: Don't distribute it.
1889         * top.c (print_gdb_configuration): Don't mention it.
1890
1891 2019-08-06  Tom Tromey  <tom@tromey.com>
1892
1893         * utils.c (set_output_style): Sometimes pass stream to
1894         emit_style_escape.
1895         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1896         * record-btrace.c (btrace_insn_history): Update.
1897         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1898         method.
1899         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1900         Update initializers.
1901         <m_uiout>: New field.
1902         <m_di>: Move lower.
1903         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1904         Remove "uiout" parameter.
1905         (dump_insns): Update.
1906         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1907         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1908
1909 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1910
1911         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1912         (error_in_psymtab_expansion): Likewise.
1913         (lookup_symbol_via_quick_fns): Likewise.
1914         (basic_lookup_transparent_type_quick): Likewise.
1915         (basic_lookup_transparent_type_1): Likewise.
1916
1917 2019-08-06  Tom Tromey  <tromey@adacore.com>
1918
1919         * source.c (last_source_error): Now bool.
1920         (print_source_lines_base): Make "noprint" bool.  Only open
1921         source file when last_source_visited changes.
1922
1923 2019-08-06  Tom Tromey  <tromey@adacore.com>
1924
1925         * annotate.c (annotate_source_line): Use g_source_cache.
1926         * source-cache.c (source_cache::get_plain_source_lines): Change
1927         parameters.  Populate m_offset_cache.
1928         (source_cache::ensure): New method.
1929         (source_cache::get_line_charpos): New method.
1930         (extract_lines): Move lower.  Change parameters.
1931         (source_cache::get_source_lines): Move lower.
1932         * source-cache.h (class source_cache): Update comment.
1933         <get_line_charpos>: New method.
1934         <get_source_lines>: Update comment.
1935         <clear>: Clear m_offset_cache.
1936         <get_plain_source_lines>: Change parameters.
1937         <ensure>: New method
1938         <m_offset_cache>: New member.
1939         * source.c (forget_cached_source_info_for_objfile): Update.
1940         (info_source_command): Use g_source_cache.
1941         (find_source_lines, open_source_file_with_line_charpos): Remove.
1942         (print_source_lines_base, search_command_helper): Use g_source_cache.
1943         * source.h (open_source_file_with_line_charpos): Don't declare.
1944         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1945         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1946         Use g_source_cache.
1947
1948 2019-08-06  Tom Tromey  <tromey@adacore.com>
1949
1950         * source-cache.c (source_cache::get_plain_source_lines):
1951         Remove "first_line" and "last_line" parameters.
1952         (source_cache::get_source_lines): Cache plain text.
1953         * source-cache.h (class source_cache)
1954         <get_plain_source_lines>: Update.
1955
1956 2019-08-06  Tom Tromey  <tromey@adacore.com>
1957
1958         * source-cache.c (extract_lines): No longer a method.
1959         Changed type of parameter.  Include final newline.
1960         (selftests::extract_lines_test): New function.
1961         (_initialize_source_cache): Likewise.
1962         * source-cache.h (class source_cache)
1963         <extract_lines>: Don't declare.
1964
1965 2019-08-06  Tom Tromey  <tromey@adacore.com>
1966
1967         * breakpoint.c (init_breakpoint_sal): Update.
1968         (breakpoint): Update.
1969         * breakpoint.h (struct breakpoint) <filter>: Now a
1970         unique_xmalloc_ptr.
1971
1972 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1973
1974         * NEWS: Mention dictionary access on blocks.
1975         * python/py-block.c (blpy_getitem): New function.
1976         (block_object_as_mapping): New struct.
1977         (block_object_type): Use new struct for tp_as_mapping field.
1978
1979 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1980
1981         * objfiles.h (objfile): Add a comment describing partial symbols.
1982
1983 2019-08-05  Tom Tromey  <tromey@adacore.com>
1984
1985         * compile/compile.c (_initialize_compile): Use _(), not N_().
1986         * thread.c (_initialize_thread): Use _(), not N_().
1987         * stack.c (_initialize_stack): Use _(), not N_().
1988         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1989
1990 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1991
1992         * dwarf2read.c (struct dw2_symtab_iterator):
1993         <want_specific_block>: Remove.
1994         <block_index>: Change type to gdb::optional.
1995         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1996         change type of BLOCK_INDEX parameter to gdb::optional.
1997         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1998         (dw2_lookup_symbol): Don't pass argument for
1999         WANT_SPECIFIC_BLOCK.
2000         (dw2_expand_symtabs_for_function): Don't pass argument for
2001         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2002         (class dw2_debug_names_iterator)
2003         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2004         parameter, change BLOCK_INDEX type to gdb::optional.
2005         <m_want_specific_block>: Remove.
2006         <m_block_index>: Change type to gdb::optional.
2007         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2008         gdb::optional.  Re-write in function of gdb::optional.
2009         (dw2_debug_names_lookup_symbol): Don't pass argument for
2010         WANT_SPECIFIC_BLOCK.
2011         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2012         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2013         BLOCK_INDEX.
2014
2015 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2016
2017         * NEWS: Mention changes to "info sources" command.
2018
2019 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2020
2021         * symtab.c (filename_partial_match_opts): New struct type.
2022         (struct output_source_filename_data): New members
2023         regexp, c_regexp, partial_match.
2024         (output_source_filename): Use new members to decide to print file.
2025         (info_sources_option_defs): New variable.
2026         (make_info_sources_options_def_group, print_info_sources_header,
2027         info_sources_command_completer):
2028         New functions.
2029         (info_sources_command): Read new optional arguments.
2030         (_initialize_symtab): Update info sources help.
2031
2032 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2033
2034         * ada-lang.c (exception_support_info_v0): Renamed from...
2035         (default_exception_support_info): ... this.  Create new
2036         definition for v1.
2037         (ada_has_this_exception_support): Look up catch_handlers_sym.
2038         (ada_exception_support_info_sniffer): Try v0 after default.
2039
2040 2019-08-01  Tom Tromey  <tromey@adacore.com>
2041
2042         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2043         gdbarch.h.
2044
2045 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2046
2047         * s12z-tdep.c: Fix include path for s12z-opc.h.
2048
2049 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2050
2051         * NEWS: Require GNU make 3.82.
2052
2053 2019-07-16  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2056         declare.
2057
2058 2019-07-30  Tom Tromey  <tromey@adacore.com>
2059
2060         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2061
2062 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2063
2064         * printcmd.c (print_address_symbolic): Print negative offsets.
2065         (build_address_symbolic): Force signed arithmetic when computing
2066         offset.
2067
2068 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2069
2070         PR/24474: Add a function to lookup static variables.
2071         * NEWS: Mention this new function.
2072         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2073         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2074         * python/python.c (python_GdbMethods): Add new function.
2075
2076 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2077
2078         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2079         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2080         (objfpy_lookup_static_symbol): New function.
2081         (objfile_object_methods): Add new functions.
2082
2083 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2084
2085         * NEWS: Mention 'set|show print frame-info'.  Mention new
2086         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2087         backtrace argument.  Mention that python frame filtering code
2088         is now consistent with what 'backtrace' command prints.
2089
2090 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2091
2092         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2093         comments.
2094         (print_frame_info_auto, print_frame_info_source_line,
2095         print_frame_info_location, print_frame_info_source_and_location,
2096         print_frame_info_location_and_address, print_frame_info_short_location):
2097         New declarations.
2098         (struct frame_print_options): New member print_frame_info.
2099         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2100         * stack.h (get_user_print_what_frame_info): New declaration.
2101         (frame_show_address): New declaration.
2102         * stack.c (print_frame_arguments_choices): New value 'presence'.
2103         (print_frame_info_auto, print_frame_info_source_line,
2104         print_frame_info_location, print_frame_info_source_and_location,
2105         print_frame_info_location_and_address, print_frame_info_short_location,
2106         print_frame_info_choices, print_frame_info_print_what): New definitions.
2107         (print_frame_args): Only print dots for args if print frame-arguments
2108         is 'presence'.
2109         (frame_print_option_defs): New element for "frame-info".
2110         (get_user_print_what_frame_info): New function.
2111         (frame_show_address): Make non static.  Move comment to stack.h.
2112         (print_frame_info_to_print_what): New function.
2113         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2114         to decide what to print.
2115         (backtrace_command_1): Handle the new print_frame_arguments_presence
2116         value.
2117         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2118         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2119         (py_print_frame): In non-mi mode, use LOCATION as default for
2120         print_what, similarly to frame information printed directly by
2121         backtrace command. Handle frame-info user option in non MI mode.
2122
2123 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2124
2125         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2126         Add case for debugging 32-bit target on 64-bit host.  Revise
2127         comment.
2128
2129 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2130
2131         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2132         instead of find_function_entry_range_from_pc.
2133
2134 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2135
2136         * stack.c (find_frame_funname): Remove code which preferred
2137         minsym over symtab sym in "certain pathological cases".
2138
2139         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2140         parameter.  Change type of "do_demangle" to bool.
2141         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2142         Pass suitable "prefer_sym_over_minsym" flag to
2143         build_address_symbolic().  Don't output "+" for negative offsets.
2144         * printcmd.c (print_address_symbolic): Update invocation of
2145         build_address_symbolic to include a "prefer_sym_over_minsym"
2146         flag.
2147         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2148         Restrict cases in which use of minimal symbol is preferred to that
2149         of a found symbol.  Update comments.
2150
2151         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2152         for entry pc when entry pc is out of range for that FDE.
2153
2154 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2155
2156         PR gdb/24839:
2157         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2158         type.
2159
2160 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2161
2162         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2163         this function's Python signature.
2164
2165
2166 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2167
2168         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2169         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2170         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2171         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2172         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2173
2174
2175 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2176
2177         * h8300-tdep.c (h8300_register_name_common): New.
2178         h8300_register_name): Use h8300_register_name_common.
2179         (h8300s_register_name): Likewise.
2180         (h8300sx_register_name): Likewise.
2181         (h8300h_register_nam): New.
2182         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2183
2184
2185 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2186
2187         * arm-tdep.c (arm_skip_cmse_entry): New function.
2188         (arm_is_sgstubs_section): New function.
2189         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2190
2191 2019-07-22  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2194         Don't self-assign.
2195
2196 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2197
2198         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2199         type_print.
2200
2201 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2204         so that GDB doesn't match any msymbols when searching in the
2205         TYPES_DOMAIN.
2206         (print_symbol_info): Print using typedef_print or type_print based
2207         on the type of the symbol.  Add updated FIXME comment moved from...
2208         (_initialize_symtab): ... move and update FIXME comment to above.
2209
2210 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * NEWS: Mention adding -q option to "info types".
2213         * symtab.c (struct info_types_options): New struct.
2214         (info_types_options_defs): New variable.
2215         (make_info_types_options_def_group): New function.
2216         (info_types_command): Use gdb::option framework to parse options.
2217         (info_types_command_completer): New function.
2218         (_initialize_symtab): Extend the help text on "info types" and
2219         register command completer.
2220
2221 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2222
2223         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2224         (lookup_symbol_in_objfile): Change int to block_enum and add a
2225         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2226
2227 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2228
2229         * MAINTAINERS (Write After Approval): Add self.
2230
2231 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2234         instruction to the dummy code region.
2235
2236 2019-07-19  Tom Tromey  <tromey@adacore.com>
2237
2238         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2239         (ARGSUSED, PARAMS, __func__): Remove rules.
2240
2241 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2242
2243         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2244         * features/arm/arm-with-iwmmxt.c: Remove.
2245         * features/arm/arm-with-iwmmxt.xml: Remove.
2246         * features/arm/arm-with-m-fpa-layout.c: Remove.
2247         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2248         * features/arm/arm-with-m-vfp-d16.c: Remove.
2249         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2250         * features/arm/arm-with-m.c: Remove.
2251         * features/arm/arm-with-m.xml: Remove.
2252         * features/arm/arm-with-neon.c: Remove.
2253         * features/arm/arm-with-neon.xml: Remove.
2254         * features/arm/arm-with-vfpv2.c: Remove.
2255         * features/arm/arm-with-vfpv2.xml: Remove.
2256         * features/arm/arm-with-vfpv3.c: Remove.
2257         * features/arm/arm-with-vfpv3.xml: Remove.
2258
2259 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2260
2261         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2262
2263 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2264
2265         * arch/aarch32.c (aarch32_create_target_description): Create
2266         target descriptions using features.
2267         * arch/arm.c (arm_create_target_description)
2268         (arm_create_mprofile_target_description): Likewise.
2269         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2270
2271 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * Makefile.in: Add new files.
2274         * aarch32-tdep.c: New file.
2275         * aarch32-tdep.h: New file.
2276         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2277         Call aarch32_read_description.
2278         * arch/aarch32.c: New file.
2279         * arch/aarch32.h: New file.
2280         * arch/arm.c (arm_create_target_description)
2281         (arm_create_mprofile_target_description): New function.
2282         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2283         (arm_create_target_description)
2284         (arm_create_mprofile_target_description): New declaration.
2285         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2286         read_description functions.
2287         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2288         Likewise.
2289         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2290         * arm-tdep.c (tdesc_arm_list): New variable.
2291         (arm_register_g_packet_guesses): Call create description functions.
2292         (arm_read_description) (arm_read_mprofile_description): New
2293         function.
2294         * arm-tdep.h (arm_read_description)
2295         (arm_read_mprofile_description): Add declaration.
2296         * configure.tgt: Add new files.
2297
2298 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2299
2300         * top.c (new_ui_command): Open specified terminal just once.
2301
2302 2019-07-18  Tom Tromey  <tromey@adacore.com>
2303
2304         * symtab.c (main_name): Constify return type.
2305         * symfile.c (set_initial_language): Update.
2306         * symtab.h (main_name): Constify return type.
2307
2308 2019-07-17  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-winsource.c (tui_update_source_window)
2311         (tui_update_source_window_as_is)
2312         (tui_update_source_windows_with_line): Remove return.
2313         * tui/tui-disasm.c (tui_show_disassem)
2314         (tui_show_disassem_and_update_source): Remove return.
2315         * tui/tui.c (tui_reset): Remove return.
2316         * tui/tui-wingeneral.c
2317         (tui_check_and_display_highlight_if_needed): Remove return.
2318
2319 2019-07-17  Tom Tromey  <tom@tromey.com>
2320
2321         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2322
2323 2019-07-17  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-winsource.h (struct tui_exec_info_window)
2326         (struct tui_source_window_base): Move from tui-data.h.
2327         * tui/tui-winsource.c: Move many method definitions from
2328         elsewhere.  Remove "structuring" comments.
2329         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2330         (tui_source_window_base::refresh_window): Move to
2331         tui-winsource.c.
2332         * tui/tui-win.c (tui_source_window_base::refresh_all)
2333         (tui_source_window_base::update_tab_width)
2334         (tui_source_window_base::set_new_height)
2335         (tui_source_window_base::do_make_visible_with_new_height): Move to
2336         tui-winsource.c.
2337         * tui/tui-source.h: Update.
2338         * tui/tui-source.c (tui_source_window_base::reset): Move to
2339         tui-winsource.c.
2340         * tui/tui-disasm.h: Update.
2341         * tui/tui-data.h (struct tui_exec_info_window): Move to
2342         tui-winsource.h.
2343         (struct tui_source_window_base): Likewise.
2344         * tui/tui-data.c (tui_source_window_base::clear_detail)
2345         (tui_source_window_base, ~tui_source_window_base): Move to
2346         tui-winsource.c.
2347
2348 2019-07-17  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-win.c (tui_resize_all)
2351         (tui_source_window_base::update_tab_width)
2352         (tui_adjust_win_heights): Update.
2353         (tui_win_info::make_invisible_and_set_new_height): Rename from
2354         make_invisible_and_set_new_height.
2355         * tui/tui-data.h (struct tui_win_info)
2356         <make_invisible_and_set_new_height>: New method.
2357
2358 2019-07-17  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui.c: Update.
2361         * tui/tui-source.h (struct tui_source_window): Move from
2362         tui-data.h.
2363         * tui/tui-layout.c: Update.
2364         * tui/tui-disasm.c: Update.
2365         * tui/tui-data.h (struct tui_source_window): Move to
2366         tui-source.h.
2367
2368 2019-07-17  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2371         tui-data.h.
2372         * tui/tui-data.h (struct tui_disasm_window): Move to
2373         tui-disasm.h.
2374
2375 2019-07-17  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-regs.h (struct tui_data_item_window): Move from
2378         tui-data.h.
2379         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2380         * tui/tui-data.h (struct tui_data_item_window): Move to
2381         tui-regs.h.
2382         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2383
2384 2019-07-17  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui.c: Update.
2387         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2388         (tui_cmd_window::max_height): Move to tui-command.c.
2389         * tui/tui-layout.c: Update.
2390         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2391         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2392         tui-command.c.
2393         * tui/tui-command.h (struct tui_cmd_window): Move from
2394         tui-data.h.
2395         * tui/tui-command.c: Remove "structuring" comments.
2396         (tui_cmd_window::clear_detail)
2397         (tui_cmd_window::do_make_visible_with_new_height)
2398         (tui_cmd_window::max_height): Move from elsewhere.
2399
2400 2019-07-17  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2403         Now static.
2404         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2405         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2406
2407 2019-07-17  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui.c: Update.
2410         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2411         tui-regs.c.
2412         * tui/tui-windata.h: Remove file.
2413         * tui/tui-windata.c: Remove file.
2414         * tui/tui-win.c (tui_data_window::set_new_height)
2415         (tui_data_window::do_make_visible_with_new_height): Move to
2416         tui-regs.c.
2417         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2418         * tui/tui-regs.c: Remove "structuring" comments.
2419         (tui_data_window::first_data_item_displayed)
2420         (tui_data_window::delete_data_content_windows)
2421         (tui_data_window::erase_data_content)
2422         (tui_data_window::display_all_data)
2423         (tui_data_window::refresh_all)
2424         (tui_data_window::do_scroll_vertical)
2425         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2426         (tui_data_window::do_make_visible_with_new_height)
2427         (tui_data_window::refresh_window): Move from elsewhere.
2428         (_initialize_tui_regs): Move to end of file.
2429         * tui/tui-layout.c: Update.
2430         * tui/tui-hooks.c: Update.
2431         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2432         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2433         tui-regs.c.
2434         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2435
2436 2019-07-17  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2439         seen.
2440
2441 2019-07-17  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-win.c (tui_source_window_base::set_new_height)
2444         (tui_source_window_base::do_make_visible_with_new_height): Use
2445         m_has_locator field directly.
2446         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2447         method.
2448         (struct tui_source_window_base) <has_locator>: Likewise.
2449
2450 2019-07-17  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2453         Don't declare.
2454         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2455         Remove.
2456         * tui/tui-win.c (tui_source_window_base::set_new_height)
2457         (tui_source_window_base::set_new_height)
2458         (make_invisible_and_set_new_height)
2459         (tui_source_window_base::do_make_visible_with_new_height)
2460         (tui_source_window_base::do_make_visible_with_new_height):
2461         Update.
2462         * tui/tui-layout.c (show_source_disasm_command, show_data)
2463         (show_source_or_disasm_and_command): Update.
2464         * tui/tui-layout.c (show_layout): Update.
2465
2466 2019-07-17  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-layout.c (make_data_window): Remove.
2469         (show_data): Unify creation and re-initialization cases.
2470
2471 2019-07-17  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-layout.c (make_source_window, make_disasm_window):
2474         Remove.
2475         (show_data): Unify creation and re-initialization cases.
2476
2477 2019-07-17  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-layout.c (make_command_window): Remove.
2480         (show_source_disasm_command, show_source_or_disasm_and_command):
2481         Unify creation and re-initialization cases.
2482
2483 2019-07-17  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2486         creation and re-initialization cases.
2487
2488 2019-07-17  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-regs.c (tui_get_register): Return void.
2491
2492 2019-07-17  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2495         Simplify.
2496
2497 2019-07-17  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2500         resetting.
2501
2502 2019-07-17  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2505         * tui/tui-regs.c (tui_reg_layout): New function.
2506         (tui_show_registers, tui_reg_command): Use it.
2507         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2508         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2509         parameters.
2510         (tui_layout_command): Remove.
2511
2512 2019-07-17  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-layout.h (tui/tui-layout): Return void.
2515         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2516
2517 2019-07-17  Tom Tromey  <tom@tromey.com>
2518
2519         * tui/tui-layout.c (show_source_disasm_command, show_data):
2520         Update.
2521         (reset_locator): Remove.
2522         (show_source_or_disasm_and_command): Update.
2523
2524 2019-07-17  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-source.c (tui_source_window_base::reset): Remove
2527         win_type parameter.
2528         * tui/tui-layout.c (make_command_window, make_source_window)
2529         (make_disasm_window, make_data_window)
2530         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2531         (reset_locator, show_source_or_disasm_and_command): Update.
2532         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2533         win_type parameter.
2534         (struct tui_source_window_base) <reset>: Likewise.
2535
2536 2019-07-17  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-layout.c (show_source_disasm_command): Use
2539         reset_locator.
2540         (reset_locator): New function.
2541         (init_and_make_win): Remove.
2542         (show_source_or_disasm_and_command): Use reset_locator.
2543
2544 2019-07-17  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2547         condition.
2548         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2549         Remove condition.
2550         * tui/tui-source.c (tui_source_window_base::reset): New method.
2551         * tui/tui-layout.c (make_command_window): Don't call
2552         init_and_make_win.
2553         (make_source_window, make_disasm_window): Don't call
2554         make_source_or_disasm_window.
2555         (make_data_window): Don't call init_and_make_win.  Change calling
2556         convention.
2557         (show_source_disasm_command, show_data): Simplify.
2558         (make_source_or_disasm_window): Remove.
2559         (show_source_or_disasm_and_command): Simplify.
2560         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2561         (struct tui_source_window_base) <reset>: Likewise.
2562         <execution_info>: Remove initializer.
2563         * tui/tui-data.c (tui_source_window_base): Initialize
2564         execution_info.
2565
2566 2019-07-17  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2569         variable.
2570
2571 2019-07-17  Tom Tromey  <tom@tromey.com>
2572
2573         * tui/tui.c (tui_rl_other_window): Update.
2574         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2575         superclass method first.  Always iterate over regs_content.
2576         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2577         method.
2578         * tui/tui-win.c (tui_set_focus_command): Update.
2579
2580 2019-07-17  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-win.c (tui_set_focus_command): Rename from
2583         tui_set_focus.  Call tui_enable.
2584         (tui_set_focus_command): Remove.
2585
2586 2019-07-17  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2589         refresh_window.
2590         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2591         touchwin.
2592         (tui_data_window::refresh_window): Call refresh_window on data
2593         items.  Always call superclass refresh_window.
2594         (tui_win_info::refresh): Remove.
2595         (tui_source_window_base::refresh_window): Update.
2596         (tui_refresh_all): Update.
2597         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2598         refresh_window.
2599         (show_source_or_disasm_and_command): Likewise.
2600         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2601         (struct tui_source_window_base) <refresh>: Likewise.
2602
2603 2019-07-17  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-winsource.c (tui_clear_source_content)
2606         (tui_show_source_content): Update.
2607         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2608         whether content is empty.
2609         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2610         Remove.
2611
2612 2019-07-17  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2615         window's contents.
2616         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2617         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2618
2619 2019-07-17  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2622         (struct tui_data_item_window): Update.
2623
2624 2019-07-17  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2627         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2628         defines.
2629
2630 2019-07-17  Tom Tromey  <tom@tromey.com>
2631
2632         * tui/tui-winsource.h (tui_erase_source_content)
2633         (tui_clear_source_content): Remove "display_prompt" parameter.
2634         * tui/tui-winsource.c (tui_update_source_window_as_is)
2635         (tui_update_source_windows_with_addr): Update.
2636         (tui_clear_source_content): Remove "display_prompt" parameter.
2637         (tui_erase_source_content): Likewise.  Simplify.
2638         (tui_show_source_content): Update.
2639         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2640         * tui/tui-stack.c (tui_show_frame_info): Update.
2641         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2642         Remove defines.
2643
2644 2019-07-17  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2647         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2648         parameter.
2649         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2650         parameter.
2651
2652 2019-07-17  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui-winsource.c (tui_clear_source_content)
2655         (tui_show_source_content, tui_show_exec_info_content)
2656         (tui_clear_exec_info_content): Update.
2657         * tui/tui-stack.c (tui_show_locator_content): Update.
2658         (tui_show_frame_info): Update.
2659         * tui/tui-source.h (tui_source_window): Don't declare.
2660         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2661         from tui_source_is_displayed.
2662         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2663         Remove field.
2664         (struct tui_source_window_base) <content_in_use>: New field.  Now
2665         bool.
2666         (struct tui_source_window) <showing_source_p>: New method.
2667         (TUI_SRC_WIN): Change cast.
2668         * tui/tui-data.c (tui_initialize_static_data): Update.
2669
2670 2019-07-17  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2673         location_matches_p.
2674         * tui/tui-source.c (tui_source_window::location_matches_p): New
2675         method.
2676         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2677         method.
2678         * tui/tui-data.h (struct tui_source_window_base)
2679         <location_matches_p>: New method.
2680         (struct tui_source_window, struct tui_disasm_window)
2681         <location_matches_p>: Likewise.
2682
2683 2019-07-17  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-win.c (tui_set_win_height_command): Rename from
2686         tui_set_win_height.
2687         (tui_set_win_height_command): Remove.
2688
2689 2019-07-17  Tom Tromey  <tom@tromey.com>
2690
2691         * tui/tui-source.c (tui_source_window): New constructor.  Add
2692         observer.
2693         (~tui_source_window): New destructor.
2694         (tui_source_window::style_changed): New method.
2695         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2696         (tui_attach_detach_observers): Update.
2697         * tui/tui-data.h (struct tui_source_window): Make constructor not
2698         inline.  Add destructor.
2699         (struct tui_source_window) <style_changed>: New method.
2700         <m_observable>: New member.
2701
2702 2019-07-17  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2705         * tui/tui-win.c (tui_resize_all): Fix typo.
2706
2707 2019-07-17  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2710         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2711         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2712         * tui/tui-win.c (window_name_completer): Use foreach.
2713         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2714         (update_tab_width): Likewise.
2715         * tui/tui-layout.c (show_layout): Update.
2716         * tui/tui-data.h (class tui_window_iterator): New.
2717         (struct all_tui_windows): New.
2718         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2719
2720 2019-07-17  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2723         parameter.  Don't reference globals.
2724         (tui_reg_command): Update.
2725
2726 2019-07-17  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-regs.c (tui_show_registers): Simplify.
2729
2730 2019-07-17  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-regs.c (tui_show_registers): Update.
2733         (tui_show_register_group): Add win_info parameter.
2734
2735 2019-07-17  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2738         Rename from tui_display_reg_element_at_line.
2739         (tui_data_window::display_registers_from_line): Update.
2740         * tui/tui-data.h (struct tui_data_window)
2741         <display_reg_element_at_line>: New method.
2742
2743 2019-07-17  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-regs.h (tui_display_registers_from)
2746         (tui_display_registers_from_line): Don't declare.
2747         * tui/tui-windata.c (tui_data_window::display_all_data)
2748         (tui_data_window::refresh_all)
2749         (tui_data_window::do_scroll_vertical): Update.
2750         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2751         from tui_display_registers_from.
2752         (tui_display_reg_element_at_line): Update.
2753         (tui_data_window::display_registers_from_line): Rename from
2754         tui_display_registers_from_line.
2755         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2756         display_registers_from_line>: New methods.
2757
2758 2019-07-17  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2761         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2762         from tui_erase_data_content.
2763         (tui_data_window::display_all_data)
2764         (tui_data_window::refresh_all)
2765         (tui_data_window::do_scroll_vertical): Update.
2766         * tui/tui-regs.c (tui_show_registers): Update.
2767         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2768         New method.
2769
2770 2019-07-17  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2773         declare.
2774         * tui/tui-windata.c
2775         (tui_data_window::delete_data_content_windows): Rename from
2776         tui_delete_data_content_windows.
2777         (tui_data_window::display_all_data)
2778         (tui_data_window::do_scroll_vertical): Update.
2779         * tui/tui-data.h (struct tui_data_window)
2780         <delete_data_content_windows>: New method.
2781
2782 2019-07-17  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2785         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2786
2787 2019-07-17  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2790         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2791         from tui_display_all_data.
2792         * tui/tui-win.c
2793         (tui_data_window::do_make_visible_with_new_height): Update.
2794         * tui/tui-regs.c (tui_show_registers): Update.
2795         * tui/tui-layout.c (tui_set_layout): Update.
2796         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2797         method.
2798
2799 2019-07-17  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2802         * tui/tui-windata.c (tui_display_data_from): Remove.
2803         (tui_data_window::refresh_all): Update.
2804
2805 2019-07-17  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2808         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2809         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2810         tui_display_registers_from_line.
2811         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2812         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2813         "force_display" parameter.
2814
2815 2019-07-17  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2818         declare.
2819         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2820         Rename from tui_first_reg_element_no_inline.
2821         (tui_display_reg_element_at_line)
2822         (tui_display_registers_from_line): Update.
2823         * tui/tui-data.h (struct tui_data_window)
2824         <first_reg_element_no_inline>: New method.
2825
2826 2019-07-17  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-windata.c (tui_display_data_from)
2829         (tui_data_window::do_scroll_vertical): Update.
2830         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2831         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2832         Rename from tui_line_from_reg_element_no.
2833         (tui_display_registers_from_line): Update.
2834         * tui/tui-data.h (struct tui_data_window)
2835         <line_from_reg_element_no>: New method.
2836
2837 2019-07-17  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2840         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2841         tui_last_regs_line_no.
2842         (tui_display_reg_element_at_line)
2843         (tui_display_registers_from_line): Update.
2844         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2845         method.
2846
2847 2019-07-17  Tom Tromey  <tom@tromey.com>
2848
2849         PR tui/24722:
2850         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2851         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2852         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2853         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2854         (tui_update_breakpoint_info): Likewise.
2855         * tui/tui-hooks.c (tui_event_create_breakpoint)
2856         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2857         Update.
2858
2859 2019-07-17  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2862
2863 2019-07-17  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-winsource.c (tui_update_source_window_as_is)
2866         (tui_update_source_windows_with_addr): Update.
2867         * tui/tui-source.h (tui_set_source_content)
2868         (tui_show_symtab_source): Add "win_info" parameter.
2869         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2870         parameter.
2871         (tui_show_symtab_source): Likewise.
2872
2873 2019-07-17  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-wingeneral.c
2876         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2877
2878 2019-07-17  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2881         (struct tui_cmd_window) <can_scroll>: New method.
2882         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2883         method.
2884
2885 2019-07-17  Tom Tromey  <tromey@adacore.com>
2886
2887         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2888         do_field_signed>: Rename.  Change type of "value".
2889         * ui-out.c (ui_out::field_signed): Rename from field_int.
2890         Change type of "value".
2891         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2892         type of "value".
2893         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2894         do_field_int.  Change type of "value".
2895         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2896         do_field_int.  Change type of "value".
2897         * tracepoint.c (trace_status_mi, tfind_1)
2898         (print_one_static_tracepoint_marker): Update.
2899         * thread.c (print_thread_info_1, print_selected_thread_frame):
2900         Update.
2901         * stack.c (print_frame, print_frame_info): Update.
2902         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2903         Update.
2904         * source.c (print_source_lines_base): Update.
2905         * skip.c (info_skip_command): Update.
2906         * record-btrace.c (btrace_ui_out_decode_error)
2907         (btrace_call_history_src_line): Update.
2908         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2909         Update.
2910         * progspace.c (print_program_space): Update.
2911         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2912         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2913         do_field_int.  Change type of "value".
2914         * mi/mi-out.c (mi_ui_out::do_table_begin)
2915         (mi_ui_out::do_table_header): Update.
2916         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2917         type of "value".
2918         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2919         (mi_cmd_data_list_changed_registers, output_register)
2920         (mi_cmd_data_read_memory, mi_load_progress)
2921         (mi_cmd_trace_frame_collected): Update.
2922         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2923         Update.
2924         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2925         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2926         (mi_cmd_var_list_children, varobj_update_one): Update.
2927         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2928         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2929         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2930         * inferior.c (print_inferior): Update.
2931         * gdb_bfd.c (print_one_bfd): Update.
2932         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2933         Update.
2934         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2935         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2936         do_field_int.  Change type of "value".
2937         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2938         do_field_int.  Change type of "value".
2939         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2940         (print_one_breakpoint_location, print_it_catch_fork)
2941         (print_one_catch_fork, print_it_catch_vfork)
2942         (print_one_catch_vfork, print_it_catch_solib)
2943         (print_it_catch_exec, print_it_ranged_breakpoint)
2944         (print_mention_watchpoint, print_mention_masked_watchpoint)
2945         (bkpt_print_it, update_static_tracepoint): Update.
2946         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2947         * break-catch-syscall.c (print_it_catch_syscall): Update.
2948         * ada-tasks.c (print_ada_task_info): Update.
2949         * ada-lang.c (print_it_exception, print_mention_exception):
2950         Update.
2951
2952 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2953
2954         PR breakpoints/24541
2955         * gdbarch.c: Regenerate.
2956         * gdbarch.h: Regenerate.
2957         * gdbarch.sh: Adjust return type and parameter types for
2958         'stap_adjust_register'.
2959         (i386_stap_adjust_register): Adjust signature and return new
2960         register name.
2961         * stap-probe.c (stap_parse_register_operand): Adjust use of
2962         'gdbarch_stap_adjust_register'.
2963
2964 2019-07-17  Tom Tromey  <tromey@adacore.com>
2965
2966         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2967         declare VEC.
2968         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2969         std::vector.
2970         (struct s390_process_info): Add initializers.
2971         (s390_add_process): Use new.
2972         (s390_linux_nat_target::low_forget_process): Use delete.
2973         (s390_linux_nat_target::low_new_fork)
2974         (s390_linux_nat_target::stopped_by_watchpoint)
2975         (s390_linux_nat_target::low_prepare_to_resume)
2976         (s390_linux_nat_target::insert_watchpoint)
2977         (s390_linux_nat_target::insert_hw_breakpoint)
2978         (s390_linux_nat_target::remove_watchpoint)
2979         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2980
2981 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2982
2983         * aarch64-fbsd-nat.c: Include regcache.h.
2984         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2985         argument.
2986         (aarch64_fbsd_nat_target::fetch_registers)
2987         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2988         variable.
2989         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2990
2991 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2992
2993         * fbsd-nat.c: Include gdbarch.h.
2994
2995 2019-07-15  Tom Tromey  <tromey@adacore.com>
2996
2997         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2998
2999 2019-07-15  Tom Tromey  <tromey@adacore.com>
3000
3001         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3002         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3003         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3004         * cli-out.c (cli_ui_out::do_field_int): New method.
3005         * ui-out.c (ui_out::field_unsigned): New method.
3006         * symfile.c (generic_load): Use field_unsigned.
3007         (print_transfer_performance): Likewise.
3008         * record-btrace.c (ui_out_field_uint): Remove.
3009         (btrace_call_history_insn_range, btrace_call_history): Use
3010         field_unsigned.
3011         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3012         field_unsigned.
3013         * ui-out.h (class ui_out) <field_unsigned>: New method.
3014         <do_field_unsigned>: Likewise.
3015
3016 2019-07-15  Tom Tromey  <tromey@adacore.com>
3017
3018         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3019         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3020         * target.c (flash_erase_command): Use field_string.
3021         * infrun.c (print_signal_received_reason): Use field_string.
3022         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3023         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3024         field_string.
3025         * ada-tasks.c (print_ada_task_info): Use field_string.
3026
3027 2019-07-15  Tom Tromey  <tromey@adacore.com>
3028
3029         * target.c (flash_erase_command): Use field_core_addr.
3030         * symfile.c (generic_load): Use field_core_addr.
3031         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3032         Use field_core_addr.
3033         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3034         field_core_addr.
3035
3036 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3037
3038         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3039         value if its desired type is smaller than a CORE_ADDR and signed.
3040
3041 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3044         of changes to field names, and use new is_reference field to
3045         decide if a property is a reference or not.
3046         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3047         field.
3048         (struct dwarf2_property_baton): Update header comment, rename
3049         'referenced_type' to 'property_type' and update comments.
3050         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3051         default property type, store in property baton, update to take
3052         accound of renamed field.
3053         (read_func_scope): Update call to attr_to_dynamic_prop.
3054         (read_array_type): Likewise.
3055         (dwarf2_per_cu_addr_sized_int_type): New function.
3056         (read_subrange_index_type): Move type finding code to
3057         dwarf2_per_cu_addr_sized_int_type.
3058         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3059         (dwarf2_per_cu_addr_type): New function.
3060         (set_die_type): Update calls to attr_to_dynamic_prop.
3061
3062 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3063
3064         * dwarf2read.c (read_subrange_index_type): New function.
3065         (read_subrange_type): Move code into new function and call it.
3066         * gdbtypes.c (create_range_type): Add some asserts.
3067
3068 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3071         update return statements.
3072         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3073         declaration, and update comment to match.
3074         * gdbtypes.c (resolve_dynamic_array): Update call to
3075         dwarf2_evaluate_property to match new return type.
3076
3077 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * valarith.c (value_subscripted_rvalue): Change lowerbound
3080         parameter type from int to LONGEST.
3081         * value.h (value_subscripted_rvalue): Likewise in declaration.
3082
3083 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * cli/cli-utils.c (info_print_command_completer): New function.
3086         * cli/cli-utils.h: Add 'completer.h' include, and forward
3087         declaration for 'struct cmd_list_element'.
3088         (info_print_command_completer): Declare.
3089         * stack.c (_initialize_stack): Add completer for 'info locals' and
3090         'info args'.
3091         * symtab.c (_initialize_symtab): Add completer for 'info
3092         variables' and 'info functions'.
3093         * NEWS: Mention completion for additional info commands.
3094
3095 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         * cli/cli-utils.c (extract_info_print_args): Delete.
3098         (extract_arg_maybe_quoted): Delete.
3099         (info_print_options_defs): New variable.
3100         (make_info_print_options_def_group): New function.
3101         (extract_info_print_options): Define new function.
3102         * cli/cli-utils.h (extract_info_print_args): Delete.
3103         (struct info_print_options): New structure.
3104         (extract_info_print_options): Declare new function.
3105         * stack.c (info_locals_command): Update to use new
3106         extract_info_print_options, also add a header comment.
3107         (info_args_command): Likewise.
3108         * symtab.c (info_variables_command): Likewise.
3109         (info_functions_command): Likewise.
3110
3111 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3114         to extract string arguments.
3115         * common/common-utils.c (extract_string_maybe_quoted): New function.
3116         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3117
3118 2019-07-11  Tom Tromey  <tromey@adacore.com>
3119
3120         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3121         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3122         * top.h (gdbinit): Don't declare.
3123         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3124         into...
3125         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3126         * top.c (gdb_init): Don't call init_cli_cmds.
3127         (gdbinit): Remove.
3128         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3129
3130 2019-07-11  Tom Tromey  <tromey@adacore.com>
3131
3132         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3133         after it has been moved.
3134
3135 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3136
3137         * valops.c (value_must_coerce_to_target): Change return type to
3138         bool.
3139         * value.h (value_must_coerce_to_target): Likewise.
3140
3141 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3142
3143         * breakpoint.c (is_hardware_watchpoint): Remove
3144         forward-declaration.
3145         (is_masked_watchpoint): Change return type to bool.
3146         (is_tracepoint): Likewise.
3147         (is_breakpoint): Likewise.
3148         (is_hardware_watchpoint): Likewise.
3149         (is_watchpoint): Likewise.
3150         (is_no_memory_software_watchpoint): Likewise.
3151         (is_catchpoint): Likewise.
3152         (breakpoint_1): Make FILTER parameter's return type bool.
3153         is_masked_watchpoint): Change return type to bool.
3154         (save_breakpoints): Make FILTER parameter's return type bool.
3155         * breakpoint.h (is_breakpoint): Change return type to bool.
3156         (is_watchpoint): Likewise.
3157         (is_catchpoint): Likewise.
3158         (is_tracepoint): Likewise.
3159
3160 2019-07-10  Tom Tromey  <tom@tromey.com>
3161
3162         * defs.h: Don't include gdbarch.h.
3163         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3164         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3165         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3166         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3167         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3168         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3169         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3170         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3171         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3172         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3173         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3174         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3175         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3176         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3177         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3178         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3179         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3180         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3181         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3182         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3183         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3184         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3185         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3186         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3187         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3188         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3189         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3190
3191 2019-07-10  Tom Tromey  <tromey@adacore.com>
3192
3193         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3194         * breakpoint.c (init_ada_exception_breakpoint): Register as
3195         bp_catchpoint.
3196         (print_one_breakpoint_location, print_one_breakpoint): Use
3197         is_ada_exception_catchpoint.
3198         * ada-lang.c (class ada_catchpoint_location): Pass
3199         bp_loc_software_breakpoint to bp_location constructor.
3200         (is_ada_exception_catchpoint): New function.
3201
3202 2019-07-10  Tom Tromey  <tromey@adacore.com>
3203
3204         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3205         VEC.
3206         (struct arm_exidx_entry): New method operator<.
3207         (struct arm_exidx_data) <section_maps>: Change type.
3208         (arm_exidx_data_free): Remove.
3209         (arm_exidx_data_key): Change type.  Move lower.
3210         (arm_exidx_new_objfile): Update.
3211         (arm_compare_exidx_entries): Remove.
3212         (arm_find_exidx_entry, _initialize_arm_tdep)
3213
3214 2019-07-10  Tom Tromey  <tromey@adacore.com>
3215
3216         * solib-spu.c (ocl_program_data_key): Change type.
3217         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3218         Update.
3219
3220 2019-07-10  Tom Tromey  <tromey@adacore.com>
3221
3222         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3223         (struct solib_aix_inferior_data) <library_list>: Change type.
3224         (solib_aix_inferior_data_handle): Change type.
3225         (get_solib_aix_inferior_data): Update.
3226         (solib_aix_free_library_list): Remove.
3227         (library_list_start_library): Update.
3228         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3229         return type.
3230         (solib_aix_get_library_list)
3231         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3232         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3233
3234 2019-07-10  Tom Tromey  <tromey@adacore.com>
3235
3236         * solib-dsbt.c (struct dsbt_info): Add initializers.
3237         (solib_dsbt_pspace_data): Change type.
3238         (dsbt_pspace_data_cleanup): Remove.
3239         (get_dsbt_info, _initialize_dsbt_solib): Update.
3240
3241 2019-07-10  Tom Tromey  <tromey@adacore.com>
3242
3243         * spu-tdep.c (spu_overlay_data): Change type.
3244         (spu_get_overlay_table, spu_overlay_new_objfile)
3245         (_initialize_spu_tdep): Update.
3246
3247 2019-07-10  Tom Tromey  <tromey@adacore.com>
3248
3249         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3250         destructor.
3251         (dbx_objfile_data_key): Change type and declare later.
3252         (DBX_SYMFILE_INFO): Rewrite.
3253         * dbxread.c (dbx_objfile_data_key): Change type.
3254         (dbx_symfile_init): Update.
3255         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3256         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3257         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3258
3259 2019-07-10  Tom Tromey  <tromey@adacore.com>
3260
3261         * jit.c (jit_program_space_key): Change type.  Move lower.
3262         (get_jit_program_space_data): Update.
3263         (jit_program_space_data_cleanup): Remove.
3264         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3265         Update.
3266         (struct jit_program_space_data): Add initializers.
3267
3268 2019-07-10  Tom Tromey  <tromey@adacore.com>
3269
3270         * solib-darwin.c (struct darwin_info): Add initializers.
3271         (solib_darwin_pspace_data): Change type.
3272         (darwin_pspace_data_cleanup): Remove.
3273         (get_darwin_info, _initialize_darwin_solib): Update.
3274
3275 2019-07-10  Tom Tromey  <tromey@adacore.com>
3276
3277         * remote-sim.c (struct sim_inferior_data): Add initializers,
3278         constructor, and destructor.
3279         (sim_inferior_data_key): Change type.  Move lower.
3280         (check_for_duplicate_sim_descriptor): Update.
3281         (get_sim_inferior_data): Use new.  Update.
3282         (~sim_inferior_data_cleanup): Rename from
3283         sim_inferior_data_cleanup.  Simplify.
3284         (gdbsim_close_inferior, simulator_command)
3285         (sim_command_completer, _initialize_remote_sim): Update.
3286         (next_pid, INITIAL_PID): Move earlier.
3287
3288 2019-07-10  Tom Tromey  <tromey@adacore.com>
3289
3290         * python/python-internal.h (create_thread_object): Return
3291         gdbpy_ref.
3292         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3293         * python/py-inferior.c (struct threadlist_entry): Add
3294         constructor.
3295         <thread_obj>: Now a gdbpy_ref.
3296         (thread_to_thread_object): Update.
3297         (add_thread_object): Use new.
3298         (delete_thread_object): Use delete.
3299         (infpy_threads): Update.
3300         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3301         GIL.
3302
3303 2019-07-10  Tom Tromey  <tromey@adacore.com>
3304
3305         * valops.c (value_cast): Specialize error message for Ada.
3306
3307 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3308
3309         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3310
3311 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3312
3313         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3314         bpstat_should_step): Return bool, adjust comments.
3315         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3316         bpstat_should_step): Likewise.
3317
3318 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3319
3320         * features/Makefile: Use feature target descriptions for Arm.
3321         * features/arm/arm-core.c: Generate new file.
3322         * features/arm/arm-fpa.c: Likewise.
3323         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3324         * features/arm/arm-m-profile.c: Likewise.
3325         * features/arm/arm-vfpv2.c: Likewise.
3326         * features/arm/arm-vfpv3.c: Likewise.
3327         * features/arm/xscale-iwmmxt.c: Likewise.
3328         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3329
3330 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3331
3332         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3333         ptrace earlier.
3334
3335 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3336
3337         * features/aarch64-pauth.c: Regenerate.
3338
3339 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3340
3341         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3342         bool.
3343         (bpstat_what): Use false instead of 0.
3344
3345 2019-07-09  Pedro Alves  <palves@redhat.com>
3346
3347         * break-catch-throw.c (is_exception_catchpoint): New.
3348         * breakpoint.c (print_one_breakpoint_location): New parameter
3349         'raw_loc'.  Handle it.  Use
3350         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3351         looking at the breakpoint's type.
3352         (print_one_breakpoint): If handling "maint info breakpoints", also
3353         print locations of exception catchpoints.
3354         * breakpoint.h (is_exception_catchpoint): Declare.
3355
3356 2019-07-09  Pedro Alves  <palves@redhat.com>
3357
3358         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3359         "addr" field.
3360         (allocate_location_exception_catchpoint): New.
3361         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3362         (initialize_throw_catchpoint_ops): Install
3363         allocate_location_exception_catchpoint as allocate_location
3364         method.
3365         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3366         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3367         bp_loc_other.
3368         (breakpoint_address_is_meaningful): Delete.
3369         (bl_address_is_meaningful): New.
3370         (breakpoint_locations_match): Adjust comment.
3371         (bp_location_from_bp_type): New, factored out of...
3372         (bp_location::bp_location(breakpoint *)): ... this.
3373         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3374         factored out of...
3375         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3376         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3377         breakpoint_address_is_meaningful.
3378         (bp_locations_compare): Adjust comment.
3379         (update_global_location_list): Use bl_address_is_meaningful
3380         instead of breakpoint_address_is_meaningful.
3381         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3382         explicit.
3383         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3384         * python/py-breakpoint.c (bppy_get_location): No longer check
3385         whether location is null.
3386
3387 2019-07-09  Pedro Alves  <palves@redhat.com>
3388
3389         PR c++/15468
3390         * breakpoint.c (print_one_breakpoint_location): Remove
3391         single-location assert.
3392
3393 2019-07-09  Tom Tromey  <tom@tromey.com>
3394
3395         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3396         * configure: Rebuild.
3397         * configure.ac: Change common to gdbsupport.
3398         * gdbsupport: Rename from common.
3399         * acinclude.m4: Change common to gdbsupport.
3400         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3401         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3402         gdbsupport.
3403         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3404         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3405         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3406         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3407         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3408         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3409         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3410         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3411         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3412         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3413         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3414         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3415         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3416         coff-pe-read.c, command.h, compile/compile-c-support.c,
3417         compile/compile-c.h, compile/compile-cplus-symbols.c,
3418         compile/compile-cplus-types.c, compile/compile-cplus.h,
3419         compile/compile-loc2c.c, compile/compile.c, completer.c,
3420         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3421         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3422         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3423         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3424         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3425         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3426         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3427         features/aarch64-core.c, features/aarch64-fpu.c,
3428         features/aarch64-pauth.c, features/aarch64-sve.c,
3429         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3430         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3431         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3432         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3433         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3434         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3435         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3436         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3437         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3438         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3439         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3440         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3441         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3442         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3443         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3444         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3445         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3446         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3447         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3448         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3449         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3450         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3451         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3452         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3453         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3454         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3455         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3456         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3457         minsyms.c, mips-linux-tdep.c, namespace.h,
3458         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3459         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3460         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3461         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3462         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3463         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3464         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3465         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3466         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3467         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3468         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3469         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3470         procfs.c, producer.c, progspace.h, psymtab.h,
3471         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3472         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3473         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3474         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3475         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3476         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3477         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3478         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3479         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3480         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3481         target-memory.c, target.c, target.h, target/waitstatus.c,
3482         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3483         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3484         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3485         unittests/array-view-selftests.c,
3486         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3487         unittests/common-utils-selftests.c,
3488         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3489         unittests/format_pieces-selftests.c,
3490         unittests/function-view-selftests.c,
3491         unittests/lookup_name_info-selftests.c,
3492         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3493         unittests/mkdir-recursive-selftests.c,
3494         unittests/observable-selftests.c,
3495         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3496         unittests/parse-connection-spec-selftests.c,
3497         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3498         unittests/scoped_fd-selftests.c,
3499         unittests/scoped_mmap-selftests.c,
3500         unittests/scoped_restore-selftests.c,
3501         unittests/string_view-selftests.c, unittests/style-selftests.c,
3502         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3503         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3504         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3505         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3506         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3507         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3508
3509 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3510
3511         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3512         bool value.
3513         (decode_digits_ordinary): Set explicit_line field in sal.
3514         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3515         symtab_and_line that was set on an explicit line number in
3516         assembler code.  Do always update the recorded symtab and line if
3517         we do skip the prologue.
3518
3519 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * breakpoint.c (set_breakpoint_location_function): Remove
3522         explicit_loc parameter.
3523         (momentary_breakpoint_from_master): Update call to
3524         set_breakpoint_location_function.
3525         (add_location_to_breakpoint): Likewise.
3526
3527 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3528
3529         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3530         required features based on default bfd type when no specific bfd
3531         is present.
3532
3533 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3534
3535         * NEWS: Mention that GDB printf and eval commands can now print
3536         C-style and Ada-style convenience var strings without
3537         calling the inferior.
3538         * printcmd.c (printf_c_string): Locally print GDB internal var
3539         instead of transiting via the inferior.
3540         (printf_wide_c_string): Likewise.
3541
3542 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3543
3544         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3545
3546 2019-07-04  Tom Tromey  <tom@tromey.com>
3547
3548         PR tui/24724:
3549         * tui/tui-winsource.c (tui_clear_source_content): Update.
3550         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3551         (tui_update_breakpoint_info): Update.
3552         (tui_set_exec_info_content): Update.
3553         * tui/tui-source.c (tui_set_source_content_nil): Update.
3554         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3555         has_break.
3556         * tui/tui-data.h (enum tui_bp_flag): New.
3557         (tui_bp_flags): New enum flags type.
3558         (struct tui_source_element) <break_mode>: Change type.  Rename
3559         from has_break.
3560         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3561         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3562         constants.
3563         * tui/tui-winsource.h: Fix comment.
3564
3565 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3566
3567         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3568         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3569         (store_fpregs_to_thread)
3570         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3571         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3572         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3573         (IWMMXT_REGS_SIZE): Add define.
3574         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3575         (fetch_vfp_regs, store_vfp_regs)
3576         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3577         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3578
3579 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3580
3581         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3582         defines.
3583         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3584         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3585         (ARM_INT_REGISTER_SIZE): ...to this.
3586         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3587         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3588         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3589         (arm_linux_collect_gregset, supply_nwfpe_register)
3590         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3591         defines.
3592         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3593         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3594         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3595         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3596         (arm_return_in_memory, arm_store_return_value)
3597         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3598         (arm_record_ld_st_multiple): Likewise.
3599         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3600         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3601
3602 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3603
3604         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3605         AARCH64_DISPLACED_MODIFIED_INSNS.
3606         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3607         (aarch64_displaced_step_copy_insn): Likewise.
3608         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3609         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3610         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3611         ARM_DISPLACED_MODIFIED_INSNS.
3612         * arm-tdep.c (arm_gdbarch_init): Likewise.
3613         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3614         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3615         (struct arm_displaced_step_closure): Use
3616         ARM_DISPLACED_MODIFIED_INSNS.
3617
3618 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3619
3620         * features/Makefile: Remove unused xml files.
3621         * features/aarch64.xml: Remove.
3622         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3623         * features/i386/amd64-avx-avx512.xml: Remove.
3624         * features/i386/amd64-avx-linux.xml: Remove.
3625         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3626         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3627         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3628         * features/i386/amd64-avx-mpx.xml: Remove.
3629         * features/i386/amd64-avx.xml: Remove.
3630         * features/i386/amd64-linux.xml: Remove.
3631         * features/i386/amd64-mpx-linux.xml: Remove.
3632         * features/i386/amd64-mpx.xml: Remove.
3633         * features/i386/amd64.xml: Remove.
3634         * features/i386/i386-avx-avx512-linux.xml: Remove.
3635         * features/i386/i386-avx-avx512.xml: Remove.
3636         * features/i386/i386-avx-linux.xml: Remove.
3637         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3638         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3639         * features/i386/i386-avx-mpx-linux.xml: Remove.
3640         * features/i386/i386-avx-mpx.xml: Remove.
3641         * features/i386/i386-avx.xml: Remove.
3642         * features/i386/i386-linux.xml: Remove.
3643         * features/i386/i386-mmx-linux.xml: Remove.
3644         * features/i386/i386-mmx.xml: Remove.
3645         * features/i386/i386-mpx-linux.xml: Remove.
3646         * features/i386/i386-mpx.xml: Remove.
3647         * features/i386/i386.xml: Remove.
3648         * features/i386/x32-avx-avx512-linux.xml: Remove.
3649         * features/i386/x32-avx-linux.xml: Remove.
3650         * features/i386/x32-linux.xml: Remove.
3651
3652 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3653
3654         * regformats/aarch64.dat: Remove.
3655         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3656         * regformats/i386/amd64-avx-linux.dat: Remove.
3657         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3658         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3659         * regformats/i386/amd64-linux.dat: Remove.
3660         * regformats/i386/amd64-mpx-linux.dat: Remove.
3661         * regformats/i386/amd64.dat: Remove.
3662         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3663         * regformats/i386/i386-avx-linux.dat: Remove.
3664         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3665         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3666         * regformats/i386/i386-linux.dat: Remove.
3667         * regformats/i386/i386-mmx-linux.dat: Remove.
3668         * regformats/i386/i386-mpx-linux.dat: Remove.
3669         * regformats/i386/i386.dat: Remove.
3670         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3671         * regformats/i386/x32-avx-linux.dat: Remove.
3672         * regformats/i386/x32-linux.dat: Remove.
3673
3674 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3675
3676         * aarch64-tdep.c: Remove xml self tests.
3677         * amd64-linux-tdep.c: Likewise.
3678         * amd64-tdep.c: Likewise.
3679         * i386-linux-tdep.c: Likewise.
3680         * i386-tdep.c: Likewise.
3681
3682 2019-07-03  Pedro Alves  <palves@redhat.com>
3683
3684         PR cli/24732
3685         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3686         (pipe_cmd_option_defs): New.
3687         (make_pipe_cmd_options_def_group): New.
3688         (pipe_command): Use gdb::option::process_options.
3689         (pipe_command_completer): New function.
3690         (_initialize_cli_cmds): Install completer for "pipe" command.
3691
3692 2019-07-03  Pedro Alves  <palves@redhat.com>
3693
3694         * cli/cli-option.c (union option_value) <string>: New field.
3695         (struct option_def_and_value): Add ctor, move ctor, dtor and
3696         use DISABLE_COPY_AND_ASSIGN.
3697         (option_def_and_value::clear_value): New.
3698         (parse_option, save_option_value_in_ctx, get_val_type_str)
3699         (add_setshow_cmds_for_options): Handle var_string.
3700         * cli-option.h (union option_def::var_address) <string>: New
3701         field.
3702         (struct string_option_def): New.
3703         * maint-test-options.c (struct test_options_opts): Add default
3704         ctor and use DISABLE_COPY_AND_ASSIGN.
3705         <string_opt>: New field.
3706         (test_options_opts::~test_options_opts): New.
3707         (test_options_opts::dump): Also dump "-string".
3708         (test_options_option_defs): Install "string.
3709
3710 2019-07-03  Pedro Alves  <palves@redhat.com>
3711
3712         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3713         option_value with a null enumeration.
3714         (complete_options): Save the option values in the context.
3715         (save_option_value_in_ctx): New, factored out from ...
3716         (process_options): ... here.
3717         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3718         of the function.
3719         * maint-test-options.c (test_options_opts::dump): New, factored
3720         out from ...
3721         (maintenance_test_options_command_mode): ... here.
3722         (maintenance_test_options_command_completion_result): Delete.
3723         (maintenance_test_options_command_completion_text): Update
3724         comment.
3725         (maintenance_show_test_options_completion_result): Change
3726         prototype.  Just print
3727         maintenance_test_options_command_completion_text.
3728         (save_completion_result): New.
3729         (maintenance_test_options_completer_mode): Pass options context to
3730         complete_options, and then save a dump.
3731         (_initialize_maint_test_options): Use add_cmd to install "maint
3732         show test-options-completion-result".
3733
3734 2019-07-03  Pedro Alves  <palves@redhat.com>
3735
3736         * NEWS (New commands): Mention "with" and "maint with".
3737         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3738         (with_command, with_command_completer): New.
3739         (pipe_command): Adjust to new repeat_previous
3740         interface.
3741         (_initialize_cli_cmds): Install the "with" command and its "w"
3742         alias.
3743         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3744         declarations.
3745         * cli/cli-setshow.c (parse_cli_var_uinteger)
3746         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3747         argument strings for all var_types.
3748         (get_setshow_command_value_string): New, factored out from ...
3749         (do_show_command): ... this.
3750         * cli/cli-setshow.h: Include <string>.
3751         (get_setshow_command_value_string): Declare.
3752         * command.h (repeat_previous): Now returns const char *.  Adjust
3753         comment.
3754         * maint.c: Include "cli/cli-cmds.h".
3755         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3756         (_initialize_maint_cmds): Register the "maintenance with" command.
3757         * top.c (repeat_previous): Move bits from pipe_command here:
3758         Return the saved command line, if any; error out if there's no
3759         command to relaunch.
3760
3761 2019-07-03  Pedro Alves  <palves@redhat.com>
3762
3763         * NEWS (New commands): Mention "maint set/show test-settings"
3764         instead of "maint test-settings".
3765         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3766         (maintenance_test_settings_set_list): Rename to ...
3767         (maintenance_set_test_settings_list): ... this.
3768         (maintenance_test_settings_show_list): Rename to  ...
3769         (maintenance_show_test_settings_list): ... this.
3770         (maintenance_test_settings_cmd): Delete.
3771         (maintenance_test_settings_set_cmd): ...
3772         (maintenance_set_test_settings_cmd): ... this.
3773         (maintenance_test_settings_show_cmd): ...
3774         (maintenance_show_test_settings_cmd): ... this.
3775         (maintenance_test_settings_show_value_cmd):
3776         (maintenance_show_test_settings_value_cmd): ... this.
3777         (_initialize_maint_test_settings): No longer install the "maint
3778         test-settings" prefix command.  Rename "maint test-settings set"
3779         to "maint set test-settings", and "maint test-settings show" to
3780         "maint show test-settings".  Adjust all subcommands.
3781
3782 2019-07-03  Pedro Alves  <palves@redhat.com>
3783
3784         * maint-test-settings.c: Fix file's intro comment.  Replace all
3785         references to "test-options" with references to "test-settings",
3786         in comments.
3787
3788 2019-07-03  Pedro Alves  <palves@redhat.com>
3789
3790         * maint-test-settings.c (maintenance_test_settings_xxx)
3791         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3792         New.
3793         (maintenance_test_settings_enums): Use them.
3794         (maintenance_test_settings_enum): Default to
3795         maintenance_test_settings_xxx.
3796         (_initialize_maint_test_settings): Initialize
3797         MAINTENANCE_TEST_SETTINGS_FILENAME.
3798
3799 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3800
3801         * breakpoint.h (remove_breakpoints_inf): Change return type to
3802         void, move function documentation here.
3803         * breakpoint.c (remove_breakpoints_inf): Change return type to
3804         void, move function documentation to header.
3805
3806 2019-07-02  Pedro Alves  <palves@redhat.com>
3807
3808         * NEWS (Completion improvements): Mention "info threads".
3809         * thread.c (struct info_threads_opts, info_threads_option_defs)
3810         (make_info_threads_options_def_group): New.
3811         (info_threads_command): Use gdb::option::process_options.
3812         (info_threads_command_completer): New.
3813         (_initialize_thread): Use gdb::option::build_help to build the
3814         help text for "info threads".
3815
3816 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3817
3818         * defs.h (generic_load): Move from here...
3819         * symfile.h (generic_load): ... to here.  Rename name parameter
3820         to args.
3821         * symfile.c (generic_load): Add comment.
3822
3823 2019-07-01  Tom Tromey  <tromey@adacore.com>
3824
3825         * dwarf2read.c
3826         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3827         declaration of without_params.  Fix formatting.
3828
3829 2019-07-01  Tom Tromey  <tromey@adacore.com>
3830
3831         * ada-exp.y (find_primitive_type): Update.
3832         * ada-lang.h (ada_lookup_symbol): Update.
3833         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3834         parameter.
3835         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3836
3837 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3838
3839         PR breakpoints/24541
3840         * gdbarch.c: Regenerate.
3841         * gdbarch.h: Regenerate.
3842         * gdbarch.sh: Add 'stap_adjust_register'.
3843         * i386-tdep.c: Include '<unordered_set>'.
3844         (i386_stap_adjust_register): New function.
3845         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3846         * stap-probe.c (stap_parse_register_operand): Call
3847         'gdbarch_stap_adjust_register'.
3848
3849 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3850
3851         PR python/24742
3852         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3853         * python/python.c (do_start_initialization): Use 'xmalloc'
3854         instead of 'PyMem_Malloc'.
3855
3856 2019-06-28  Tom Tromey  <tromey@adacore.com>
3857
3858         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3859         for Ada.
3860
3861 2019-06-27  Tom Tromey  <tromey@adacore.com>
3862
3863         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3864         objfile_key.
3865         (arm_find_mapping_symbol, arm_record_special_symbol)
3866         (_initialize_arm_tdep): Update.
3867         (arm_objfile_data_free): Remove.
3868
3869 2019-06-27  Tom Tromey  <tromey@adacore.com>
3870
3871         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3872         to cp_print_static_field.
3873
3874 2019-06-26  Tom Tromey  <tromey@adacore.com>
3875
3876         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3877         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3878         declare.
3879
3880 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3881
3882         * features/aarch64-core.c (create_feature_aarch64_core):
3883         Regenerate.
3884         * features/aarch64-core.xml: Add cpsr flags.
3885
3886 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3887
3888         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3889         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3890
3891 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3892
3893         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3894         field.
3895         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3896         use.
3897         (arm_record_special_symbol): Don't insert new symbol in sorted
3898         position, push it at the end.
3899
3900 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3901
3902         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3903         (arm_mapping_symbol_s): Remove.
3904         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3905         (arm_mapping_symbol_vec): New typedef.
3906         (struct arm_per_objfile): Add constructor.
3907         <section_maps>: Change type to
3908         std::unique_ptr<arm_mapping_symbol_vec[]>.
3909         (arm_compare_mapping_symbols): Remove.
3910         (arm_find_mapping_symbol): Adjust to section_maps type change.
3911         (arm_objfile_data_free): Call delete on arm_per_objfile.
3912         (arm_record_special_symbol): Adjust to section_maps type change.
3913         Allocate arm_per_objfile with new.
3914
3915 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3916
3917         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3918         with the command prefix.
3919
3920 2019-06-25  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3923         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3924
3925 2019-06-25  Tom Tromey  <tom@tromey.com>
3926
3927         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3928         type.
3929         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3930         protected.
3931
3932 2019-06-25  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-winsource.c
3935         (tui_source_window_base::set_is_exec_point_at): Add check against
3936         LOA_ADDRESS.
3937
3938 2019-06-25  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-source.c (tui_set_source_content): Don't check before
3941         xfree.
3942         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3943
3944 2019-06-25  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-winsource.h (tui_update_source_window_as_is)
3947         (tui_alloc_source_buffer, tui_line_is_displayed)
3948         (tui_addr_is_displayed): Change type of win_info.
3949         * tui/tui-winsource.c (tui_update_source_window_as_is)
3950         (tui_clear_source_content, tui_show_source_line)
3951         (tui_show_source_content, tui_source_window_base::refill)
3952         (tui_source_window_base::set_is_exec_point_at)
3953         (tui_source_window_base::set_is_exec_point_at)
3954         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3955         (tui_alloc_source_buffer, tui_line_is_displayed)
3956         (tui_addr_is_displayed): Change type of win_info.  Update.
3957         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3958         (tui_source_window_base::do_make_visible_with_new_height):
3959         Update.
3960         * tui/tui-source.c (tui_set_source_content)
3961         (tui_set_source_content_nil)
3962         (tui_source_window::do_scroll_vertical): Update.
3963         * tui/tui-layout.c (show_layout): Update.
3964         * tui/tui-disasm.c (tui_set_disassem_content)
3965         (tui_disasm_window::do_scroll_vertical): Update.
3966         * tui/tui-data.h (tui_win_content): Remove.
3967         (struct tui_gen_win_info) <content, content_size>: Remove.
3968         (struct tui_source_element): Add initializers and destructor.
3969         (union tui_which_element, struct tui_win_element): Remove.
3970         (struct tui_source_window_base) <content>: New field.
3971         (struct tui_data_window): Remove destructor.
3972         (tui_alloc_content, tui_free_win_content)
3973         (tui_free_all_source_wins_content): Don't declare.
3974         * tui/tui-data.c (tui_initialize_static_data): Update.
3975         (init_content_element, tui_alloc_content): Remove.
3976         (~tui_gen_win_info): Update.
3977         (~tui_data_window, tui_free_all_source_wins_content)
3978         (tui_free_win_content, free_content, free_content_elements):
3979         Remove.
3980
3981 2019-06-25  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-winsource.h (tui_clear_source_content)
3984         (tui_erase_source_content, tui_show_source_content): Change type
3985         of win_info.
3986         * tui/tui-winsource.c (tui_clear_source_content)
3987         (tui_erase_source_content, tui_show_source_content): Change type
3988         of win_info.
3989         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3990         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3991         win_info.
3992         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3993         win_info.
3994         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3995
3996 2019-06-25  Tom Tromey  <tom@tromey.com>
3997
3998         * tui/tui-winsource.c (tui_clear_source_content)
3999         (tui_source_window_base::set_is_exec_point_at): Update.
4000         * tui/tui-source.c (tui_set_source_content_nil): Update.
4001         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4002         a bool.
4003         * tui/tui-data.c (init_content_element): Update.
4004
4005 2019-06-25  Tom Tromey  <tom@tromey.com>
4006
4007         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4008         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4009         * tui/tui-layout.c (init_and_make_win): Update.
4010         * tui/tui.h (enum tui_win_type): Update.
4011         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4012         tui_win_is_auxillary.
4013         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4014         tui_win_is_auxillary.
4015
4016 2019-06-25  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4019         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4020         (tui_delete_data_content_windows, tui_display_all_data)
4021         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4022         Update.
4023         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4024         * tui/tui-regs.c (tui_last_regs_line_no)
4025         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4026         (tui_show_registers): Update.
4027         (tui_show_register_group): Return void.  Update.
4028         (tui_display_registers_from, tui_display_reg_element_at_line)
4029         (tui_display_registers_from_line, tui_check_register_values):
4030         Update.
4031         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4032         member.
4033         (struct tui_data_window) <regs_content>: Now a std::vector.
4034         <regs_content_count>: Remove.
4035         (tui_add_content_elements, tui_free_data_content): Don't declare.
4036         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4037         (init_content_element): Remove DATA_WIN case.  Add assert.
4038         (tui_add_content_elements): Remove.
4039         (tui_data_window): Update.
4040         (tui_free_data_content): Remove.
4041         (free_content_elements): Remove DATA_WIN case.
4042
4043 2019-06-25  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui-data.c (tui_data_item_window): Update.
4046         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4047         * tui/tui-windata.c (tui_display_all_data)
4048         (tui_display_data_from_line): Update.
4049         (tui_check_data_values): Remove.
4050         * tui/tui-regs.c (tui_show_register_group)
4051         (tui_display_reg_element_at_line): Update.
4052         * tui/tui-hooks.c (tui_register_changed)
4053         (tui_refresh_frame_and_register_information): Call
4054         tui_check_register_values.
4055         * tui/tui-data.h (struct tui_data_window) <data_content,
4056         data_content_count, data_type>: Remove.
4057         (enum tui_data_type): Remove.
4058
4059         * tui/tui-data.c (tui_data_window::clear_detail)
4060         (~tui_data_window): Update.
4061
4062 2019-06-25  Tom Tromey  <tom@tromey.com>
4063
4064         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4065         declare.
4066         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4067         Rename from tui_first_data_item_displayed.  Update.
4068         (tui_data_window::refresh_all)
4069         (tui_data_window::do_scroll_vertical): Update.
4070         * tui/tui-data.h (struct tui_data_window)
4071         <first_data_item_displayed>: Declare new method.
4072
4073 2019-06-25  Tom Tromey  <tom@tromey.com>
4074
4075         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4076         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4077         contents...
4078         (tui_initialize_static_data): ...here.
4079
4080 2019-06-25  Tom Tromey  <tom@tromey.com>
4081
4082         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4083         (tui_display_registers_from, tui_check_register_values): Update.
4084         (tui_display_register): Remove win_info parameter; update.
4085         (tui_get_register): Change type of parameters.
4086         * tui/tui-data.h (struct tui_data_element): Remove.
4087         (union tui_which_element) <data>: Remove.
4088         <data_window>: Change type.
4089         (struct tui_data_item_window): New.
4090         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4091         case.  Add assert.
4092         (~tui_data_item_window): New destructor.
4093         (free_content_elements): Remove DATA_ITEM_WIN case.
4094
4095 2019-06-25  Tom Tromey  <tom@tromey.com>
4096
4097         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4098         Remove.
4099
4100 2019-06-25  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-data.h (struct tui_command_element): Remove.
4103         (union tui_which_element) <command>: Remove.
4104         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4105         assert.
4106         (free_content_elements): Remove CMD_WIN case.
4107
4108 2019-06-25  Tom Tromey  <tom@tromey.com>
4109
4110         * tui/tui-layout.c (tui_set_layout): Update.
4111         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4112         * tui/tui-data.c (layout_def): Update.
4113
4114 2019-06-25  Tom Tromey  <tom@tromey.com>
4115
4116         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4117         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4118         (tui_source_window_base::set_new_height): Update.
4119         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4120         Update.
4121         (tui_set_locator_fullname, tui_set_locator_info)
4122         (tui_show_frame_info): Update.
4123         * tui/tui-source.c (tui_set_source_content)
4124         (tui_source_is_displayed): Update.
4125         * tui/tui-layout.c (show_source_disasm_command, show_data)
4126         (show_source_or_disasm_and_command): Update.
4127         * tui/tui-disasm.c (tui_set_disassem_content)
4128         (tui_get_begin_asm_address): Update.
4129         * tui/tui-data.h (struct tui_locator_element): Remove.
4130         (union tui_which_element) <locator>: Remove.
4131         (struct tui_locator_window): New.
4132         (tui_locator_win_info_ptr): Change return type.
4133         * tui/tui-data.c (_locator): Change type.
4134         (tui_locator_win_info_ptr): Change return type.
4135         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4136         (tui_alloc_content): Add assert.
4137
4138 2019-06-25  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-winsource.c
4141         (tui_exec_info_window::maybe_allocate_content): New method.
4142         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4143         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4144         (make_source_or_disasm_window): Add cast.
4145         * tui/tui-data.h (union tui_which_element) <simple_string>:
4146         Remove.
4147         (struct tui_source_info): New.
4148         (struct tui_source_window_base) <execution_info>: Change type.
4149         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4150         case, and add assert.
4151         (tui_alloc_content): Add assert.
4152
4153 2019-06-25  Tom Tromey  <tom@tromey.com>
4154
4155         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4156         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4157         * tui/tui-data.c (tui_alloc_win_info): Remove.
4158
4159 2019-06-25  Tom Tromey  <tom@tromey.com>
4160
4161         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4162         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4163         can_highlight.
4164
4165 2019-06-25  Tom Tromey  <tom@tromey.com>
4166
4167         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4168         make_visible_with_new_height method.
4169         (tui_win_info::make_visible_with_new_height): New method.
4170         (tui_source_window_base::do_make_visible_with_new_height)
4171         (tui_data_window::do_make_visible_with_new_height)
4172         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4173         (make_visible_with_new_height): Remove.
4174         (tui_resize_all, tui_adjust_win_heights): Use
4175         make_visible_with_new_height method.
4176         * tui/tui-data.h (struct tui_win_info)
4177         <do_make_visible_with_new_height, make_visible_with_new_height>:
4178         New methods.
4179         (struct tui_source_window_base, struct tui_data_window)
4180         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4181         methods.
4182
4183 2019-06-25  Tom Tromey  <tom@tromey.com>
4184
4185         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4186         method.
4187         (update_tab_width): Call update_tab_width method.
4188         * tui/tui-data.h (struct tui_win_info)
4189         (struct tui_source_window_base) <update_tab_width>: New methods.
4190
4191 2019-06-25  Tom Tromey  <tom@tromey.com>
4192
4193         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4194         parameter.
4195         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4196         parameter.
4197         (tui_gen_win_info::make_visible): Update.
4198         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4199         parameter.
4200         * tui/tui-data.h (enum tui_box): New enum.
4201         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4202
4203 2019-06-25  Tom Tromey  <tom@tromey.com>
4204
4205         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4206         init_and_make_win for EXEC_INFO_WIN.
4207         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4208         longer inline.
4209         (struct tui_win_info) <~tui_win_info>: Inline.
4210         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4211         Don't declare.
4212         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4213         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4214         Remove.
4215         (tui_initialize_static_data): Update.
4216         (~tui_gen_win_info): Handle more cleanup here.
4217         (~tui_source_window_base): Delete "execution_info".
4218         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4219
4220 2019-06-25  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-layout.c (make_command_window): Don't set
4223         can_highlight.
4224         (show_source_disasm_command): Call the reset method.
4225         (show_data): Don't set can_highlight.  Call the reset method.
4226         (tui_gen_win_info::reset): Rename from init_gen_win_info
4227         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4228         (show_source_or_disasm_and_command): Call the reset method.
4229         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4230         (struct tui_cmd_window): Set can_highlight.
4231
4232 2019-06-25  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4235         from make_visible.
4236         (tui_make_visible, tui_make_invisible): Rewrite.
4237         (tui_win_info::make_visible): Remove.
4238         (tui_source_window_base::make_visible): Update.
4239         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4240         method.  Moved from...
4241         (struct tui_win_info) <make_visible>: ...here.
4242
4243 2019-06-25  Tom Tromey  <tom@tromey.com>
4244
4245         * tui/tui-winsource.c
4246         (tui_source_window_base::do_scroll_horizontal): Remove direction
4247         parameter.
4248         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4249         direction parameter.
4250         * tui/tui-win.c (tui_win_info::forward_scroll)
4251         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4252         (tui_win_info::right_scroll): Update.
4253         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4254         direction parameter.
4255         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4256         direction parameter.
4257         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4258         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4259         Remove direction parameter.
4260         (struct tui_source_window_base, struct tui_source_window)
4261         (struct tui_disasm_window, struct tui_data_window)
4262         (struct tui_cmd_window): Update.
4263
4264 2019-06-25  Tom Tromey  <tom@tromey.com>
4265
4266         * tui/tui-winsource.h (tui_set_exec_info_content)
4267         (tui_show_exec_info_content, tui_erase_exec_info_content)
4268         (tui_clear_exec_info_content, tui_update_exec_info): Change
4269         argument to tui_source_window_base.
4270         * tui/tui-winsource.c (tui_set_exec_info_content)
4271         (tui_show_exec_info_content, tui_erase_exec_info_content)
4272         (tui_clear_exec_info_content, tui_update_exec_info): Change
4273         argument to tui_source_window_base.
4274
4275 2019-06-25  Tom Tromey  <tom@tromey.com>
4276
4277         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4278         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4279
4280 2019-06-25  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4283         check.
4284
4285 2019-06-25  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4288         type to void.
4289         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4290         type to void.
4291         * tui/tui-source.c (tui_set_source_content): Update.
4292         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4293
4294 2019-06-25  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui-win.c (window_name_completer, tui_set_focus)
4297         (tui_all_windows_info): Use name method.
4298         * tui/tui-data.h (struct tui_gen_win_info)
4299         (struct tui_source_window, struct tui_disasm_window)
4300         (struct tui_data_window, struct tui_cmd_window) <name>: New
4301         method.
4302         (tui_win_name): Don't declare.
4303         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4304         (tui_win_name): Remove.
4305
4306 2019-06-25  Tom Tromey  <tom@tromey.com>
4307
4308         * tui/tui-winsource.h (tui_update_source_window)
4309         (tui_update_source_window_as_is): Change parameter type.
4310         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4311         to be a tui_source_window_base.
4312         (tui_update_source_window_as_is): Likewise.
4313         * tui/tui-win.c (make_visible_with_new_height): Update.
4314
4315 2019-06-25  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-winsource.c (tui_erase_source_content)
4318         (tui_show_source_content, tui_show_exec_info_content)
4319         (tui_erase_exec_info_content): Use refresh_window method.
4320         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4321         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4322         from tui_refresh_win.
4323         (tui_data_window::refresh_window): New method.
4324         (tui_win_info::refresh, tui_source_window_base::refresh)
4325         (tui_refresh_all): Use refresh_window method.
4326         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4327         method.
4328         * tui/tui-regs.c (tui_display_register): Call refresh_window
4329         method.
4330         * tui/tui-layout.c (show_source_disasm_command)
4331         (show_source_or_disasm_and_command): Call refresh_window method.
4332         * tui/tui-data.h (struct tui_gen_win_info)
4333         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4334         New method.
4335
4336 2019-06-25  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui.c (tui_rl_other_window, tui_enable)
4339         (tui_is_window_visible, tui_get_command_dimension): Update.
4340         * tui/tui-winsource.c (tui_update_source_window_as_is)
4341         (tui_clear_source_content, tui_erase_source_content)
4342         (tui_show_source_line, tui_source_window_base::refill)
4343         (tui_source_window_base::do_scroll_horizontal)
4344         (tui_source_window_base::set_is_exec_point_at)
4345         (tui_update_breakpoint_info, tui_set_exec_info_content)
4346         (tui_alloc_source_buffer, tui_line_is_displayed)
4347         (tui_addr_is_displayed): Update.
4348         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4349         (tui_check_and_display_highlight_if_needed)
4350         (tui_win_info::make_visible, tui_win_info::refresh)
4351         (tui_refresh_all): Update.
4352         * tui/tui-windata.c (tui_first_data_item_displayed)
4353         (tui_delete_data_content_windows, tui_erase_data_content)
4354         (tui_display_all_data, tui_data_window::refresh_all)
4355         (tui_check_data_values): Update.
4356         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4357         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4358         (tui_win_info::backward_scroll, tui_refresh_all_win)
4359         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4360         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4361         (tui_source_window_base::set_new_height)
4362         (tui_data_window::set_new_height)
4363         (make_invisible_and_set_new_height)
4364         (make_visible_with_new_height, new_height_ok)
4365         (parse_scrolling_args): Update.
4366         * tui/tui-stack.c (tui_show_frame_info): Update.
4367         * tui/tui-source.c (tui_set_source_content)
4368         (tui_set_source_content_nil, tui_source_is_displayed)
4369         (tui_source_window::do_scroll_vertical): Update.
4370         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4371         (tui_display_registers_from, tui_display_reg_element_at_line)
4372         (tui_check_register_values, tui_reg_command): Update.
4373         * tui/tui-layout.c (tui_default_win_height)
4374         (show_source_disasm_command, show_data, init_and_make_win)
4375         (show_source_or_disasm_and_command): Update.
4376         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4377         (tui_redisplay_readline, tui_mld_flush)
4378         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4379         (tui_getc): Update.
4380         * tui/tui-disasm.c (tui_set_disassem_content)
4381         (tui_disasm_window::do_scroll_vertical): Update.
4382         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4383         Now virtual.
4384         (struct tui_win_info): Derive from tui_gen_win_info.
4385         <~tui_win_info>: Mark as override.
4386         <generic>: Remove member.
4387         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4388         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4389         (~tui_data_window, ~tui_win_info)
4390         (tui_free_all_source_wins_content): Update.
4391         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4392
4393 2019-06-25  Tom Tromey  <tom@tromey.com>
4394
4395         * tui/tui-layout.c (init_and_make_win): Use new.
4396         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4397         destructor, initializers.
4398         (tui_alloc_generic_win_info): Don't declare.
4399         * tui/tui-data.c (_locator): Add argument to constructor.
4400         (source_win, disasm_win): New globals.
4401         (exec_info): Remove.
4402         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4403         Update.
4404         (tui_alloc_generic_win_info): Remove.
4405         (init_content_element): Use new.
4406         (tui_win_info::tui_win_info): Update.
4407         (free_content_elements) <case DATA_WIN>: Use delete.
4408
4409 2019-06-25  Tom Tromey  <tom@tromey.com>
4410
4411         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4412         * tui/tui-windata.c (tui_first_data_item_displayed)
4413         (tui_delete_data_content_windows): Update.
4414         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4415         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4416         (tui_display_registers_from, tui_check_register_values): Update.
4417         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4418         pointer.
4419         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4420         window.
4421         (tui_free_data_content): Update.
4422         (free_content_elements) <case DATA_WIN>: Free the window.
4423
4424 2019-06-25  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4427         Update.
4428         * tui/tui-layout.c (make_command_window)
4429         (show_source_disasm_command, show_data, init_and_make_win)
4430         (show_source_or_disasm_and_command): Update.
4431         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4432         method.
4433         <can_highight, is_highlighted>: Now bool.
4434         (tui_set_win_highlight): Don't declare.
4435         * tui/tui-data.c (tui_set_win_highlight): Remove.
4436
4437 2019-06-25  Tom Tromey  <tom@tromey.com>
4438
4439         * tui/tui-wingeneral.c (make_visible): Remove check of window
4440         type.
4441
4442 2019-06-25  Tom Tromey  <tom@tromey.com>
4443
4444         * tui/tui-win.c (tui_win_info::max_height)
4445         (tui_cmd_window::max_height): New methods.
4446         (new_height_ok): Call max_height.
4447         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4448         <max_height>: New method.
4449
4450 2019-06-25  Tom Tromey  <tom@tromey.com>
4451
4452         * tui/tui-win.c (tui_source_window_base::set_new_height)
4453         (tui_data_window::set_new_height): New methods.
4454         (make_invisible_and_set_new_height): Call set_new_height method.
4455         * tui/tui-data.h (struct tui_win_info)
4456         (struct tui_source_window_base, struct tui_data_window)
4457         <set_new_height>: New method.
4458
4459 2019-06-25  Tom Tromey  <tom@tromey.com>
4460
4461         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4462         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4463         tui_refresh_data_win.
4464         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4465         method.
4466         (tui_refresh_all_win): Call the refresh_all method.
4467         (tui_set_focus): Likewise.
4468         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4469         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4470         Likewise.
4471
4472 2019-06-25  Tom Tromey  <tom@tromey.com>
4473
4474         * tui/tui-winsource.h (tui_refill_source_window)
4475         (tui_set_is_exec_point_at): Don't declare.
4476         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4477         (tui_source_window_base::refill): Rename from
4478         tui_refill_source_window.
4479         (tui_source_window_base::do_scroll_horizontal): Update.
4480         (tui_source_window_base::set_is_exec_point_at): Rename from
4481         tui_set_is_exec_point_at.
4482         (tui_update_all_breakpoint_info): Update.
4483         * tui/tui-stack.c (tui_show_frame_info): Update.
4484         * tui/tui-layout.c (show_data): Add cast.
4485         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4486         * tui/tui-data.h (struct tui_source_window_base) <refill,
4487         set_is_exec_point_at>: New methods.
4488         (tui_source_windows, tui_add_to_source_windows): Update types.
4489         (tui_add_to_source_windows): Remove redundant declaration.
4490         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4491         (tui_source_windows): Change return type.
4492         (tui_clear_source_windows_detail): Update.
4493         (tui_add_to_source_windows): Change type of parameter.
4494         (tui_free_all_source_wins_content): Update.
4495
4496 2019-06-25  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-wingeneral.c (tui_win_info::refresh)
4499         (tui_source_window_base::refresh): New methods.
4500         (tui_refresh_all): Call the refresh method.
4501         * tui/tui-data.h (struct tui_win_info)
4502         (struct tui_source_window_base) <refresh>: New method.
4503
4504 2019-06-25  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui.h (tui_is_window_visible): Return bool.
4507         * tui/tui.c (tui_is_window_visible): Return bool.
4508         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4509         (tui_make_visible, tui_make_invisible)
4510         (tui_win_info::make_visible)
4511         (tui_source_window_base::make_visible, make_all_visible)
4512         (tui_make_all_visible, tui_make_all_invisible): Update.
4513         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4514         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4515         bool.
4516         (struct tui_win_info, struct tui_source_window_base)
4517         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4518         * tui/tui-data.c (tui_init_generic_part): Update.
4519
4520 2019-06-25  Tom Tromey  <tom@tromey.com>
4521
4522         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4523         (tui_source_window_base::make_visible): New methods.
4524         (make_all_visible): Make method call.
4525         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4526         (struct tui_source_window_base, struct tui_cmd_window): Override
4527         make_visible.
4528         (tui_win_is_source_type): Don't declare.
4529         * tui/tui-data.c (tui_win_is_source_type): Remove.
4530
4531 2019-06-25  Tom Tromey  <tom@tromey.com>
4532
4533         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4534         NULL check.
4535
4536 2019-06-25  Tom Tromey  <tom@tromey.com>
4537
4538         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4539         Inline constructor.  Add initializers for members.
4540         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4541         constructors; now inline in class.
4542
4543 2019-06-25  Tom Tromey  <tom@tromey.com>
4544
4545         * tui/tui-regs.c (tui_show_registers): Update.
4546         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4547         bool.
4548         * tui/tui-data.c (tui_data_window::clear_detail)
4549         (tui_data_window): Update.
4550
4551 2019-06-25  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-windata.c (tui_display_all_data)
4554         (tui_display_data_from_line, tui_display_data_from)
4555         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4556         Update.
4557         * tui/tui-regs.c (tui_last_regs_line_no)
4558         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4559         (tui_show_registers, tui_show_register_group)
4560         (tui_display_registers_from, tui_display_reg_element_at_line)
4561         (tui_display_registers_from_line, tui_check_register_values)
4562         (tui_reg_next, tui_reg_prev): Update.
4563         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4564         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4565         tui_data_window.
4566         (struct tui_win_info) <detail>: Remove.  Add new fields from
4567         tui_data_info.
4568         (TUI_DATA_WIN): Add cast.
4569         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4570         (~tui_data_window): Simplify.
4571
4572 2019-06-25  Tom Tromey  <tom@tromey.com>
4573
4574         * tui/tui-layout.c (show_source_disasm_command)
4575         (show_source_or_disasm_and_command): Update.
4576         * tui/tui-io.c (update_cmdwin_start_line)
4577         (tui_redisplay_readline): Update.
4578         * tui/tui-data.h (struct tui_command_info): Remove.
4579         (struct tui_win_info) <detail>: Remove command_info member.
4580         (struct tui_data_window) <start_line>: New member, from
4581         tui_command_info.
4582         (TUI_CMD_WIN): Add casts.
4583
4584 2019-06-25  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-winsource.c (tui_update_source_window)
4587         (tui_refill_source_window)
4588         (tui_source_window_base::do_scroll_horizontal)
4589         (tui_update_breakpoint_info, tui_set_exec_info_content)
4590         (tui_show_exec_info_content, tui_erase_exec_info_content)
4591         (tui_clear_exec_info_content): Update.
4592         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4593         Update.
4594         * tui/tui-win.c (make_invisible_and_set_new_height)
4595         (make_visible_with_new_height): Update.
4596         * tui/tui-source.c (tui_set_source_content)
4597         (tui_show_symtab_source): Update.
4598         * tui/tui-layout.c (extract_display_start_addr)
4599         (show_source_disasm_command, show_data)
4600         (make_source_or_disasm_window)
4601         (show_source_or_disasm_and_command): Update.
4602         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4603         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4604         "gdbarch".
4605         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4606         to tui_source_window_base.
4607         (struct tui_win_info) <detail>: Remove source_info member.
4608         (struct tui_source_window_base) <has_locator>: Inline.
4609         Move contents from tui_source_info; rename has_locator member to
4610         m_has_locator.
4611         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4612         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4613         header file.
4614         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4615         Simplify.
4616         (tui_free_all_source_wins_content): Cast to
4617         tui_source_window_base.
4618
4619 2019-06-25  Tom Tromey  <tom@tromey.com>
4620
4621         * tui/tui-win.c (make_invisible_and_set_new_height)
4622         (make_visible_with_new_height): Call has_locator method.
4623         * tui/tui-layout.c (show_source_disasm_command, show_data)
4624         (show_source_or_disasm_and_command): Update for bool change.
4625         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4626         (tui_win_info) <has_locator>: New method.
4627         (struct tui_source_window_base) <has_locator>: New method.
4628         (tui_win_has_locator): Don't declare.
4629         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4630         from tui_win_has_locator.
4631         (tui_source_window_base): Use false, not FALSE.
4632
4633 2019-06-25  Tom Tromey  <tom@tromey.com>
4634
4635         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4636         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4637         clear_detail method directly.
4638         (tui_clear_win_detail): Remove.
4639
4640 2019-06-25  Tom Tromey  <tom@tromey.com>
4641
4642         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4643         "this", not TUI_DISASM_WIN.
4644
4645 2019-06-25  Tom Tromey  <tom@tromey.com>
4646
4647         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4648         declare.
4649         * tui/tui-winsource.c
4650         (tui_source_window_base::do_scroll_horizontal): Rename from
4651         tui_horizontal_source_scroll.
4652         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4653         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4654         from tui_vertical_data_scroll.
4655         * tui/tui-win.h (tui_scroll): Don't declare.
4656         * tui/tui-win.c (tui_win_info::forward_scroll)
4657         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4658         (tui_win_info::right_scroll): Rename and update.
4659         (tui_scroll_forward_command, tui_scroll_backward_command)
4660         (tui_scroll_left_command, tui_scroll_right_command): Update.
4661         (tui_scroll): Remove.
4662         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4663         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4664         from tui_vertical_source_scroll.
4665         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4666         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4667         from tui_vertical_disassem_scroll.
4668         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4669         do_scroll_horizontal>: New methods.
4670         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4671         Likewise.
4672         (struct tui_source_window_base): Add do_scroll_horizontal.
4673         (struct tui_source_window, struct tui_disasm_window): Add
4674         do_scroll_vertical.
4675         (struct tui_data_window, struct tui_cmd_window): Add
4676         do_scroll_horizontal and do_scroll_vertical.
4677         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4678
4679 2019-06-25  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-data.h (struct tui_source_window_base): New struct.
4682         (struct tui_source_window): Derive from tui_source_window_base.
4683         (struct tui_disasm_window): New struct.
4684         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4685         from tui_source_window::clear_detail.
4686         (tui_source_window_base): Rename from tui_source_window.
4687         (~tui_source_window_base): Rename from ~tui_source_window.
4688         (tui_alloc_win_info): Create a tui_disasm_window.
4689
4690 2019-06-25  Tom Tromey  <tom@tromey.com>
4691
4692         * tui/tui-data.h (struct tui_source_window)
4693         (struct tui_data_window): Declare destructors.
4694         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4695         destructors.
4696         (tui_win_info): Simplify.
4697
4698 2019-06-25  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-winsource.c (tui_display_main)
4701         (tui_update_source_windows_with_addr)
4702         (tui_update_all_breakpoint_info): Update.
4703         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4704         (new_height_ok, parse_scrolling_args): Update.
4705         * tui/tui-stack.c (tui_show_frame_info): Update.
4706         * tui/tui-data.h (struct tui_list): Remove.
4707         (tui_source_windows): Return a reference to a std::vector.
4708         * tui/tui-data.c (source_windows): Now a std::vector.
4709         (tui_source_windows): Change return type.
4710         (tui_clear_source_windows): Rewrite.
4711         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4712         (tui_free_all_source_wins_content): Rewrite.
4713
4714 2019-06-25  Tom Tromey  <tom@tromey.com>
4715
4716         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4717         (struct tui_data_window, struct tui_cmd_window): Declare
4718         clear_detail method.
4719         * tui/tui-data.c (tui_source_window::clear_detail)
4720         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4721         methods.
4722         (tui_clear_win_detail): Simplify.
4723
4724 2019-06-25  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-layout.c (make_source_window, make_disasm_window)
4727         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4728         Return the new window.
4729         (show_source_disasm_command, show_data)
4730         (show_source_or_disasm_and_command): Update.
4731
4732 2019-06-25  Tom Tromey  <tom@tromey.com>
4733
4734         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4735         parameter.  Return the new window.
4736         (show_source_disasm_command): Update and remove NULL check.
4737         (show_source_or_disasm_and_command): Update.
4738
4739 2019-06-25  Tom Tromey  <tom@tromey.com>
4740
4741         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4742
4743 2019-06-25  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-data.h (struct tui_win_info): Make constructor
4746         protected.  Make destructor virtual.  Add initializers.
4747         (tui_source_window, tui_data_window, tui_cmd_window): New
4748         classes.
4749         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4750         constructor.  Add "type" parameter.
4751         (tui_source_window, tui_data_window, tui_cmd_window): New
4752         constructors.
4753         (tui_alloc_win_info): Instantiate the appropriate subclass.
4754
4755 2019-06-25  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-win.c (tui_resize_all): Use delete.
4758         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4759         destructor.
4760         (tui_free_window): Don't declare.
4761         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4762         Update.
4763
4764 2019-06-25  Tom Tromey  <tom@tromey.com>
4765
4766         * tui/tui-data.h (struct tui_win_info): Add constructor.
4767         * tui/tui-data.c (tui_alloc_win_info): Use new.
4768         (tui_free_window): Use delete.
4769
4770 2019-06-22  Tom Tromey  <tom@tromey.com>
4771
4772         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4773         declare.
4774         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4775
4776 2019-06-22  Tom Tromey  <tom@tromey.com>
4777
4778         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4779         declare.
4780         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4781
4782 2019-06-22  Tom de Vries  <tdevries@suse.de>
4783
4784         * dwarf2read.c (create_addrmap_from_aranges)
4785         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4786         instead of '%zu'.
4787
4788 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4789
4790         * dwarf2read.h (dwarf2_section_info_def): Remove.
4791         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4792         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4793         std::vector<dwarf2_section_info>.
4794         (struct dwo_file) <~dwo_file>: Remove.
4795         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4796         types field.
4797         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4798         (dwarf2_read_debug_names): Likewise.
4799         (create_debug_types_hash_table): Change parameter type to
4800         array_view, adjust code accordingly.
4801         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4802         (partial_die_info::fixup): Likewise.
4803         (determine_prefix): Likewise.
4804         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4805
4806 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4807
4808         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4809         gdb_bfd_ref_ptr.
4810         <~dwo_file>: Remove call to gdb_bfd_unref.
4811         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4812         gdb_bfd_ref_ptr::get.
4813
4814 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4815
4816         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4817         type to htab_up.
4818         * dwarf2read.c (struct dwo_file): Initialize fields.
4819         <~dwo_file>: New.
4820         (free_dwo_file): Remove, move content to ~dwo_file.
4821         (struct dwo_file_deleter): Remove.
4822         (dwo_file_up>: Remove custom deleter.
4823         (free_dwo_files): Remove.
4824         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4825         dwo_files.
4826         (process_skeletonless_type_units): Call unique_ptr::get.
4827         (allocate_dwo_file_hash_table): Add deleter to created hash
4828         table.  Change return type to htab_up.
4829         (lookup_dwo_file_slot): Don't memset dwo_file, call
4830         unique_ptr::get.
4831         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4832         (create_dwo_unit_in_dwp_v2): Likewise.
4833         (open_and_init_dwo_file): Likewise.
4834         (free_dwo_file_from_slot): Remove.
4835
4836 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4837
4838         * dwarf2read.h (struct dwarf2_section_info) <readin,
4839         is_virtual>: Change type to bool.
4840         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4841         true instead of 1.
4842
4843 2019-06-19  Tom Tromey  <tom@tromey.com>
4844
4845         * tui/tui-data.h (tui_init_content_element): Don't declare.
4846
4847 2019-06-19  Tom Tromey  <tom@tromey.com>
4848
4849         * tui/tui-data.h (tui_init_win_info): Don't declare.
4850
4851 2019-06-19  Tom de Vries  <tdevries@suse.de>
4852
4853         * dwarf2read.h (abstract_to_concrete): Change type to
4854         std::unordered_map<sect_offset, std::vector<sect_offset>,
4855         gdb::hash_enum<sect_offset>>.
4856
4857 2019-06-19  Tom Tromey  <tromey@adacore.com>
4858
4859         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4860         EVAL_AVOID_SIDE_EFFECTS specially.
4861
4862 2019-06-19  Tom Tromey  <tromey@adacore.com>
4863
4864         * source-cache.c (highlighter): New global.
4865         (source_cache::get_source_lines): Create a highlighter on demand.
4866
4867 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * defs.h (deprecated_interactive_hook): Delete declaration.
4870         * interps.c (clear_interpreter_hooks): Remove use of
4871         deprecated_interactive_hook.
4872         * top.c (deprecated_interactive_hook): Delete definition.
4873         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4874
4875 2019-06-18  Tom de Vries  <tdevries@suse.de>
4876
4877         PR gdb/24515
4878         * dwarf2read.h (abstract_to_concrete): Change type from
4879         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4880         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4881         * dwarf2read.c (read_variable): Update.
4882         (dwarf2_fetch_die_loc_sect_off): Update.
4883
4884 2019-06-17  Tom de Vries  <tdevries@suse.de>
4885
4886         PR gdb/24617
4887         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4888         accessing parent[parent_len - 1].
4889
4890 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4891
4892         PR gdb/24364
4893         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4894         call dtrace_process_dof with NULL dof.
4895
4896 2019-06-16  Tom de Vries  <tdevries@suse.de>
4897
4898         PR gdb/24445
4899         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4900
4901 2019-06-16  Tom Tromey  <tom@tromey.com>
4902
4903         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4904         (make_all_visible): Use address of member.
4905
4906 2019-06-16  Tom Tromey  <tom@tromey.com>
4907
4908         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4909         (tui_free_window, free_content, free_content_elements): Remove
4910         unnecessary cast.
4911         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4912         cast.
4913         * tui/tui-regs.c (tui_show_register_group)
4914         (tui_display_registers_from, tui_display_reg_element_at_line):
4915         Remove unnecessary cast.
4916
4917 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * linux-nat.c (normal_mask): Delete.
4920         (_initialize_linux_nat): Don't initialise normal_mask.
4921
4922 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4923
4924         PR gdb/24445
4925         * dwarf-index-write.h (write_psymtabs_to_index): Add
4926         dwz_basename parameter.
4927         * dwarf-index-write.c (write_gdbindex): Move file writing to
4928         write_gdbindex_1.  Change return type void.
4929         (assert_file_size): Move up, remove filename parameter.
4930         (write_gdbindex_1): New function.
4931         (write_debug_names): Change return type to void, call
4932         assert_file_size.
4933         (struct index_wip_file): New struct.
4934         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4935         file logic to index_wip_file.  Write index for dwz file if
4936         needed.
4937         (save_gdb_index_command): Pass basename of dwz file, if present.
4938         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4939         build-id of dwz file, if present.
4940         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4941         (dwarf2_get_dwz_file): Likewise.
4942         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4943         (dwarf2_get_dwz_file): Likewise.
4944
4945 2019-06-16  Tom Tromey  <tom@tromey.com>
4946
4947         * coffread.c (process_coff_symbol): Use xstrdup.
4948         * value.c (create_internalvar): Use xstrdup.
4949
4950 2019-06-16  Tom Tromey  <tom@tromey.com>
4951
4952         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4953         * breakpoint.c (stopin_command, stopat_command)
4954         (until_break_command, decode_location_default): Remove unnecessary
4955         cast.
4956         * utils.c (subset_compare): Remove unnecessary cast.
4957         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4958         cast.
4959         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4960         cast.
4961         * infcmd.c (path_command): Remove unnecessary cast.
4962         * coffread.c (decode_type): Remove unnecessary cast.
4963         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4964         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4965         * tui/tui-stack.c (tui_show_locator_content)
4966         (tui_show_frame_info): Remove unnecessary cast.
4967         * tui/tui-win.c (tui_scroll_forward_command)
4968         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4969         (parse_scrolling_args): Remove unnecessary cast.
4970         * tui/tui-data.c (init_win_info, tui_del_window)
4971         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4972         (free_content_elements): Remove unnecessary cast.
4973         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4974         unnecessary cast.
4975         * tui/tui-source.c (tui_set_source_content)
4976         (tui_vertical_source_scroll): Remove unnecessary cast.
4977         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4978         cast.
4979         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4980         * tui/tui-regs.c (tui_display_registers_from)
4981         (tui_display_register): Remove unnecessary cast.
4982         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4983         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4984         (make_visible): Remove unnecessary cast.
4985         * tui/tui-winsource.c (tui_erase_source_content)
4986         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4987         unnecessary cast.
4988         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4989         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4990         * stabsread.c (read_type, read_array_type, read_range_type):
4991         Remove unnecessary cast.
4992         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4993         (parse_symbol, parse_type, upgrade_type, parse_external)
4994         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4995         unnecessary cast.
4996         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4997
4998 2019-06-16  Tom Tromey  <tom@tromey.com>
4999
5000         * tui/tui-data.c (tui_alloc_generic_win_info)
5001         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5002         checks.
5003
5004 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5005             Andrew Burgess  <andrew.burgess@embecosm.com>
5006
5007         * f-typeprint.c (f_print_type): Don't return early for not
5008         associated or not allocated types.
5009         (f_type_print_varspec_suffix): Add print_rank parameter and print
5010         ranks of array types in case they dangling.
5011         (f_type_print_base): Add print_rank parameter.
5012
5013 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5014
5015         * NEWS: Mention new MI commands.
5016         * break-catch-throw.c (enum exception_event_kind): Move to
5017         breakpoint.h.
5018         (print_mention_exception_catchpoint): Output text as a single
5019         message.
5020         (catch_exception_command_1): Rename to...
5021         (catch_exception_event): ...this, make non-static, update header
5022         command, and change some parameter types.
5023         (catch_catch_command): Update for changes to
5024         catch_exception_command_1.
5025         (catch_throw_command): Likewise.
5026         (catch_rethrow_command): Likewise.
5027         * breakpoint.c (enum exception_event_kind): Delete.
5028         * breakpoint.h (enum exception_event_kind): Moved here from
5029         break-catch-throw.c.
5030         (catch_exception_event): Declare.
5031         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5032         (mi_cmd_catch_throw): New function.
5033         (mi_cmd_catch_rethrow): New function.
5034         (mi_cmd_catch_catch): New function.
5035         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5036         'catch-catch' entries.
5037         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5038         (mi_cmd_catch_rethrow): Declare.
5039         (mi_cmd_catch_catch): Declare.
5040
5041 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * annotate.c (annotate_source_line): Change return type to void,
5044         update implementation to match.
5045         * annotate.h (annotate_source_line): Change return type to void,
5046         update header comment.
5047         * stack.c (print_frame_info): Don't change what frame information
5048         is printed based on whether annotations are on or not.
5049
5050 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5053         (annotate_source): Make static.
5054         (annotate_source_line): Moved from source.c and renamed from
5055         identify_source_line.  Update the return type.
5056         * annotate.h (annotate_source): Delete declaration.
5057         (annotate_source_line): Declaration moved from source.h, and
5058         renamed from identify_source_line.  Return type updated.
5059         * source.c (identify_source_line): Moved to annotate.c and renamed
5060         to annotate_source_line.
5061         (info_line_command): Remove check of annotation_level.
5062         * source.h (identify_source_line): Move declaration to annotate.h
5063         and rename to annotate_source_line.
5064         * stack.c: Add 'annotate.h' include.
5065         (print_frame_info): Remove check of annotation_level before
5066         calling annotate_source_line.
5067
5068 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * source-cache.c (source_cache::get_plain_source_lines): Use
5071         open_source_file_with_line_charpos instead of just
5072         open_source_file, remove call to find_source_lines.
5073         (source_cache::get_source_lines): Likewise.
5074         * source.c (find_source_lines): Make static.
5075         (get_filename_and_charpos): Renamed into...
5076         (open_source_file_with_line_charpos): ..this along with changes to
5077         return a scoped_fd, and some other minor clean ups.
5078         (identify_source_line): Use open_source_file_with_line_charpos.
5079         (search_command_helper): Use open_source_file_with_line_charpos
5080         instead of just open_source_file, remove call to
5081         find_source_lines.
5082         * source.h (open_source_file_with_line_charpos): Declare new
5083         function.
5084         (find_source_lines): Delete declaration.
5085
5086 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * source.c (get_filename_and_charpos): Remove fullname
5089         parameter.
5090         (identify_source_line): Update call to get_filename_and_charpos.
5091
5092 2019-06-14  Tom Tromey  <tromey@adacore.com>
5093
5094         PR gdb/24502:
5095         * ui-style.h (skip_ansi_escape): Update comment.
5096         * ui-file.h (class no_terminal_escape_file): New class.
5097         * ui-file.c (no_terminal_escape_file::write)
5098         (no_terminal_escape_file::puts): New methods.
5099         * cli/cli-logging.c (handle_redirections): Use
5100         no_terminal_escape_file.
5101
5102 2019-06-14  Tom Tromey  <tromey@adacore.com>
5103
5104         * NEWS: Move convenience variable news above Python news.
5105
5106 2019-06-14  Tom Tromey  <tom@tromey.com>
5107
5108         * gnulib: Move directory to top-level.
5109         * configure.ac: Don't configure gnulib.
5110         * configure: Rebuild.
5111         * common/common-defs.h: Use new path to gnulib.
5112         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5113         (GNULIB_H): Remove.
5114         (INCGNU): Look in new gnulib location.
5115         (HFILES_NO_SRCDIR): Remove gnulib files.
5116         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5117         (generated_files): Remove GNULIB_H.
5118         ($(LIBGNU), all-lib): Remove targets.
5119         (distclean): Don't mention GNULIB_BUILDDIR.
5120         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5121
5122 2019-06-14  Tom Tromey  <tromey@adacore.com>
5123
5124         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5125         Warn if symbol file does not provide any symbols.
5126
5127 2019-06-14  Tom Tromey  <tromey@adacore.com>
5128
5129         * source.c (find_and_open_source): Respect basenames_may_differ.
5130
5131 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5132
5133         * annotate.c (annotate_breakpoints_invalid): Make use of
5134         scoped_restore_terminal_state.
5135         (annotate_frames_invalid): Likewise.
5136
5137 2019-06-14  Tom Tromey  <tromey@adacore.com>
5138
5139         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5140         allow assignment to an internalvar.
5141
5142 2019-06-14  Tom Tromey  <tromey@adacore.com>
5143
5144         * ada-lex.l: Allow "_" in attribute names.
5145
5146 2019-06-14  Tom Tromey  <tromey@adacore.com>
5147
5148         PR gdb/24653:
5149         * regcache.c (registers_changed): Don't call alloca.
5150         * top.c (execute_command): Don't call alloca.
5151
5152 2019-06-13  Pedro Alves  <palves@redhat.com>
5153
5154         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5155         'expression'.  When parsing an expression, error out if there's
5156         junk after "unlimited".
5157         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5158         (do_set_command): Adjust calls to is_unlimited_literal.
5159
5160 2019-06-13  Pedro Alves  <palves@redhat.com>
5161
5162         * compile/compile.c (make_compile_options_def_group): Add braces
5163         around array_view initializer.
5164         * thread.c (make_thread_apply_all_options_def_group)
5165         (make_thread_apply_all_options_def_group): Likewise.
5166
5167 2019-06-13  Pedro Alves  <palves@redhat.com>
5168
5169         * NEWS (New commands): Mention "maint test-options
5170         require-delimiter", "maint test-options unknown-is-error", "maint
5171         test-options unknown-is-operand" and "maint show
5172         test-options-completion-result".
5173         (New command options, command completion): New section.
5174         (Completion improvements): New section.
5175         Mention that you can abbreviate "unlimited".
5176
5177 2019-06-13  Pedro Alves  <palves@redhat.com>
5178
5179         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5180         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5181         * unittests/cli-utils-selftests.c (test_parse_flags)
5182         (test_parse_flags_qcs): Delete.
5183         (test_cli_utils): Don't call deleted functions.
5184
5185 2019-06-13  Pedro Alves  <palves@redhat.com>
5186
5187         * thread.c: Include "cli/cli-option.h".
5188         (tp_array_compar_ascending): Global.
5189         (tp_array_compar): Delete function.
5190         (tp_array_compar_ascending, tp_array_compar_descending): New
5191         functions.
5192         (ascending_option_def, qcs_flag_option_def)
5193         (thr_qcs_flags_option_defs)
5194         (make_thread_apply_all_options_def_group)
5195         (make_thread_apply_options_def_group): New.
5196         (thread_apply_all_command): Use gdb::option::process_options.
5197         (thread_apply_command_completer)
5198         (thread_apply_all_command_completer): New.
5199         (thread_apply_command): Use gdb::option::process_options.
5200         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5201         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5202         to generate help text of "thread apply".  Adjust "taas"'s help.
5203         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5204         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5205
5206 2019-06-13  Pedro Alves  <palves@redhat.com>
5207
5208         * thread.c (thread_apply_command): Check for invalid TID with
5209         isdigit instead of !isalpha.
5210
5211 2019-06-13  Pedro Alves  <palves@redhat.com>
5212
5213         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5214         (validate_flags_qcs): New.
5215         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5216         (validate_flags_qcs): Declare.
5217         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5218         (make_frame_apply_options_def_group): New.
5219         (frame_apply_command_count): Process options with
5220         gdb::option::process_options.
5221         (frame_apply_completer): New.
5222         (frame_apply_level_completer, frame_apply_all_completer)
5223         (frame_apply_completer): New.
5224         (_initialize_stack): Update help of "frame apply", "frame apply
5225         level", "frame apply all" and "faas" to mention supported options
5226         and install command completers.
5227         * stack.h (frame_apply_all_completer): Declare.
5228         * thread.c: Include "stack.h".
5229         (tfaas_command): Add "--".
5230         (_initialize_thread): Update help "tfaas" to mention supported
5231         options and install command completer.
5232
5233 2019-06-13  Pedro Alves  <palves@redhat.com>
5234
5235         * completer.c (complete_nested_command_line): New.
5236         (gdb_completion_word_break_characters_throw): Add assertion.
5237         * completer.h (complete_nested_command_line): Declare.
5238
5239 2019-06-13  Pedro Alves  <palves@redhat.com>
5240
5241         * stack.c (parse_backtrace_qualifiers): New.
5242         (backtrace_command): Use it.
5243         (backtrace_command_completer): Complete on qualifiers.
5244
5245 2019-06-13  Pedro Alves  <palves@redhat.com>
5246
5247         * frame.c: Include "cli/cli-option.h.
5248         (user_set_backtrace_options): New.
5249         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5250         Delete.
5251         (get_prev_frame): Adjust.
5252         (boolean_option_def, uinteger_option_def)
5253         (set_backtrace_option_defs): New.
5254         (_initialize_frame): Adjust and use
5255         gdb::option::add_setshow_cmds_for_options to install "set
5256         backtrace past-main" and "set backtrace past-entry".
5257         * frame.h: Include "cli/cli-option.h".
5258         (struct frame_print_options): Forward declare.
5259         (print_frame_arguments_all, print_frame_arguments_scalars)
5260         (print_frame_arguments_none): Declare.
5261         (print_entry_values): Delete declaration.
5262         (struct frame_print_options, user_frame_print_options): New.
5263         (struct set_backtrace_options): New.
5264         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5265         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5266         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5267         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5268         (list_args_or_locals): Add frame_print_options parameter.
5269         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5270         * python/py-framefilter.c (enumerate_args): Pass down
5271         USER_FRAME_PRINT_OPTIONS.
5272         * stack.c: Include "cli/cli-option.h".
5273         (print_frame_arguments_all, print_frame_arguments_scalars)
5274         (print_frame_arguments_none): Declare.
5275         (print_raw_frame_arguments, print_entry_values): Delete.
5276         (user_frame_print_options): New.
5277         (boolean_option_def, enum_option_def, frame_print_option_defs):
5278         New.
5279         (struct backtrace_cmd_options): New.
5280         (bt_flag_option_def): New.
5281         (backtrace_command_option_defs): New.
5282         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5283         (print_frame_arg, read_frame_arg, print_frame_args)
5284         (print_frame_info, print_frame): Add frame_print_options parameter
5285         and use it.
5286         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5287         (backtrace_command_1): Add frame_print_options and
5288         backtrace_cmd_options parameters and use them.
5289         (make_backtrace_options_def_group): New.
5290         (backtrace_command): Process command options with
5291         gdb::option::process_options.
5292         (backtrace_command_completer): New.
5293         (_initialize_stack): Extend "backtrace"'s help to mention
5294         supported options.  Install completer for "backtrace".
5295         Install some settings commands with add_setshow_cmds_for_options.
5296
5297 2019-06-13  Pedro Alves  <palves@redhat.com>
5298
5299         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5300         and that "set/show print raw frame-arguments" are now deprecated.
5301
5302         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5303         command.
5304         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5305         * stack.c (_initialize_stack): Install "set/show print
5306         raw-frame-arguments", and deprecate "set/show print raw
5307         frame-arguments".
5308         * valprint.c (_initialize_valprint): Deprecate "set/show print
5309         raw".
5310
5311 2019-06-13  Pedro Alves  <palves@redhat.com>
5312
5313         * compile/compile.c (struct compile_options): New.
5314         (compile_flag_option_def, compile_command_option_defs)
5315         (make_compile_options_def_group): New.
5316         (compile_file_command): Handle options with
5317         gdb::option::process_options.
5318         (compile_file_command_completer): New function.
5319         (compile_code_command): Handle options with
5320         gdb::option::process_options.
5321         (compile_code_command_completer): New function.
5322         (_initialize_compiler): Install completers for "compile code" and
5323         "compile file".  Mention available options in "compile code" and
5324         "compile code"'s help.
5325         * completer.c (advance_to_completion_word): New, factored out from
5326         ...
5327         (advance_to_expression_complete_word_point): ... this.
5328         (advance_to_filename_complete_word_point): New.
5329         * completer.h (advance_to_filename_complete_word_point): New
5330         declaration.
5331
5332 2019-06-13  Pedro Alves  <palves@redhat.com>
5333
5334         * compile/compile.c: Include "cli/cli-option.h".
5335         (compile_print_value): Scope data pointer is now a
5336         value_print_options pointer; adjust.
5337         (compile_print_command): Process options.  Scope data pointer is
5338         now a value_print_options pointer; adjust.
5339         (_initialize_compile): Update "compile print"'s help to include
5340         supported options.  Install a completer for "compile print".
5341         * cp-valprint.c (show_vtblprint, show_objectprint)
5342         (show_static_field_print): Delete.
5343         (_initialize_cp_valprint): Don't install "set print
5344         static-members", "set print vtbl", "set print object" here.
5345         * printcmd.c: Include "cli/cli-option.h" and
5346         "common/gdb_optional.h".
5347         (print_command_parse_format): Rework to fill in a
5348         value_print_options instead of a format_data.
5349         (print_value): Change parameter type from format_data pointer to
5350         value_print_options reference.  Adjust.
5351         (print_command_1): Process options.  Adjust to pass down a
5352         value_print_options.
5353         (print_command_completer): New.
5354         (_initialize_printcmd): Install print_command_completer as
5355         handle_brkchars completer for the "print" command.  Update
5356         "print"'s help to include supported options.
5357         * valprint.c: Include "cli/cli-option.h".
5358         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5359         here from cp-valprint.c.
5360         (boolean_option_def, uinteger_option_def)
5361         (value_print_option_defs, make_value_print_options_def_group):
5362         New.  Use gdb::option::add_setshow_cmds_for_options to install
5363         "set print elements", "set print null-stop", "set print repeats",
5364         "set print pretty", "set print union", "set print array", "set
5365         print address", "set print symbol", "set print array-indexes".
5366         * valprint.h: Include <string> and "cli/cli-option.h".
5367         (make_value_print_options_def_group): Declare.
5368         (print_value): Change parameter type from format_data pointer to
5369         value_print_options reference.
5370         (print_command_completer): Declare.
5371
5372 2019-06-13  Pedro Alves  <palves@redhat.com>
5373
5374         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5375         (COMMON_SFILES): Add maint-test-settings.c.
5376         * cli/cli-decode.c (boolean_enums): New global, factored out from
5377         ...
5378         (add_setshow_boolean_cmd): ... here.
5379         * cli/cli-decode.h (boolean_enums): Declare.
5380         * cli/cli-option.c: New file.
5381         * cli/cli-option.h: New file.
5382         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5383         factored out from ...
5384         (parse_cli_boolean_value(const char *)): ... this.
5385         (is_unlimited_literal): Change parameter type to pointer to
5386         pointer.  Adjust and advance ARG pointer.
5387         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5388         (parse_cli_var_enum): New, factored out from ...
5389         (do_set_command): ... this.  Adjust.
5390         * cli/cli-setshow.h (parse_cli_boolean_value)
5391         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5392         (parse_cli_var_enum): Declare.
5393         * cli/cli-utils.c: Include "cli/cli-option.h".
5394         (get_ulongest): New.
5395         * cli/cli-utils.h (get_ulongest): Declare.
5396         (check_for_argument): New overloads.
5397         * maint-test-options.c: New file.
5398
5399 2019-06-13  Pedro Alves  <palves@redhat.com>
5400
5401         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5402         parse a range if "-" is at the end of the string.
5403
5404 2019-06-13  Pedro Alves  <palves@redhat.com>
5405
5406         * cli/cli-setshow.c (parse_auto_binary_operation)
5407         (parse_cli_boolean_value): Don't allow "o".
5408
5409 2019-06-13  Pedro Alves  <palves@redhat.com>
5410
5411         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5412         * NEWS: Mention maint test-settings KIND.
5413         * maint-test-settings.c: New file.
5414
5415 2019-06-13  Pedro Alves  <palves@redhat.com>
5416
5417         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5418         completer.
5419         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5420         "set" completers.
5421
5422 2019-06-13  Pedro Alves  <palves@redhat.com>
5423
5424         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5425         after item.
5426
5427 2019-06-13  Pedro Alves  <palves@redhat.com>
5428
5429         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5430
5431 2019-06-13  Pedro Alves <palves@redhat.com>
5432
5433         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5434         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5435         call.
5436         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5437         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5438         calls.
5439         (check_for_argument): Skip spaces after argument.
5440
5441 2019-06-13  Pedro Alves  <palves@redhat.com>
5442
5443         * thread.c (thread_apply_command): Adjust TID parsing.
5444         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5445         detected before end of string.
5446         (tid_is_in_list): Error out if LIST is invalid.
5447
5448 2019-06-13  Pedro Alves  <palves@redhat.com>
5449
5450         * completer.c (complete_line_internal_1): Rewind completion word
5451         point.
5452         (completion_tracker::advance_custom_word_point_by): Change
5453         parameter type to int.
5454         * completer.h (completion_tracker::advance_custom_word_point_by):
5455         Likewise.
5456
5457 2019-06-13  Pedro Alves  <palves@redhat.com>
5458
5459         * completer.c (advance_to_completion_word): Handle delimiters.
5460
5461 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5462
5463         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5464
5465 2019-06-11  Tom Tromey  <tom@tromey.com>
5466
5467         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5468         (xmalloc_failed): Move to alloc.c.
5469         * alloc.c: New file.
5470         * Makefile.in (COMMON_SFILES): Add alloc.c.
5471
5472 2019-06-11  Tom Tromey  <tom@tromey.com>
5473
5474         * nat/linux-waitpid.c: Don't include server.h.
5475         (linux_debug): Remove.
5476         (my_waitpid): Update.
5477
5478 2019-06-11  Tom Tromey  <tromey@adacore.com>
5479
5480         * infcall.c (_initialize_infcall): Remove trailing newline from
5481         help.
5482         * user-regs.c (_initialize_user_regs): Remove trailing newline
5483         from help.
5484         * typeprint.c (_initialize_typeprint): Remove trailing newline
5485         from help.
5486         * reverse.c (_initialize_reverse): Remove trailing newlines from
5487         help.
5488         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5489         from help.
5490         * language.c (add_set_language_command): Remove trailing newline
5491         from help.
5492         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5493         help.
5494         * disasm.c (_initialize_disasm): Remove trailing newline from
5495         help.
5496         * top.c (init_main): Remove trailing newline from help.
5497         * interps.c (_initialize_interpreter): Remove trailing newline
5498         from help.
5499         * btrace.c (_initialize_btrace): Remove trailing newlines from
5500         help.
5501         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5502         from help.
5503         * python/python.c (_initialize_python): Remove trailing newline
5504         from help.
5505         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5506         help.
5507         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5508         from help.  Reformat some text.
5509         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5510         from help.
5511         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5512         newline from help.
5513
5514 2019-06-11  Tom Tromey  <tromey@adacore.com>
5515
5516         * darwin-nat.c (darwin_decode_exception_message)
5517         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5518
5519 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5520
5521         * valops.c (value_slice): Check for not allocated or not
5522         associated values.
5523
5524 2019-06-10  Tom de Vries  <tdevries@suse.de>
5525
5526         PR gdb/24618
5527         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5528         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5529         invalid.
5530
5531 2019-06-10  Tom de Vries  <tdevries@suse.de>
5532
5533         PR gdb/24611
5534         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5535         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5536
5537 2019-06-10  Tom de Vries  <tdevries@suse.de>
5538
5539         PR symtab/24545
5540         * symtab.c (struct demangled_name_entry): Add language field.
5541         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5542         static minimal symbol".  Set and use language field.
5543
5544 2019-06-10  Tom Tromey  <tromey@adacore.com>
5545
5546         * ada-lang.c (_initialize_ada_language): Update help text.
5547
5548 2019-06-10  Tom Tromey  <tromey@adacore.com>
5549
5550         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5551         with a newline.
5552         * guile/guile.c (handle_boot_error): Don't end warning with a
5553         newline.
5554         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5555         warning with a newline.
5556         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5557         newline.
5558         (s12z_frame_cache): Likewise.
5559         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5560         a newline.
5561         * solib-svr4.c (disable_probes_interface): Don't end warning with
5562         a newline.
5563         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5564         newline.
5565         * python/python.c (do_finish_initialization): Don't end warning
5566         with a newline.
5567
5568 2019-06-10  Tom Tromey  <tom@tromey.com>
5569
5570         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5571         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5572         gdbpy_enter.
5573
5574 2019-06-10  Tom Tromey  <tromey@adacore.com>
5575
5576         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5577         data.
5578         (elf_new_init): Don't call stabsread_new_init.
5579         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5580         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5581         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5582
5583 2019-06-10  Tom de Vries  <tdevries@suse.de>
5584
5585         PR symtab/16264
5586         PR symtab/24517
5587         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5588
5589 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5590
5591         * source.c (find_and_open_source): Also rewrite relative file
5592         names.
5593
5594 2019-04-26  Amos Bird  <amosbird@gmail.com>
5595
5596         * annotate.c (annotate_thread_exited): Add "thread-exited"
5597         annotation.
5598
5599 2019-06-06  Tom Tromey  <tromey@adacore.com>
5600
5601         * maint.h (class scoped_command_stats): Use
5602         DISABLE_COPY_AND_ASSIGN.
5603         <print_time>: New method.
5604         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5605         print_time.
5606         (scoped_command_stats::print_time): New method.
5607
5608 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5609
5610         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5611         instructions of lengths 6 or 8 bytes.
5612
5613 2019-06-04  Pedro Alves  <palves@redhat.com>
5614
5615         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5616
5617         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5618         * breakpoint.c (condition_completer): Likewise.
5619         * cli/cli-dump.c (scan_expression): Likewise.
5620         * common/filestuff.c (mkdir_recursive): Likewise.
5621         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5622         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5623         (gdb_abspath): Likewise.
5624         * compile/compile-cplus-types.c
5625         (compile_cplus_instance::decl_name): Likewise.
5626         * completer.c (complete_explicit_location):
5627         (signal_completer, reg_or_group_completer_1): Likewise.
5628         * cp-support.c (cp_remove_params_if_any): Likewise.
5629         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5630         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5631         * infcmd.c (strip_bg_char): Likewise.
5632         * linespec.c (copy_token_string): Likewise.
5633         * mi/mi-main.c (output_cores): Likewise.
5634         * psymtab.c (psymtab_search_name):
5635         * symfile.c (test_set_ext_lang_command): Likewise.
5636         * target.c (target_fileio_read_stralloc): Likewise.
5637         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5638         * value.c (complete_internalvar): Likewise.
5639
5640 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5641
5642         Add objfile property to gdb.Type.
5643         * NEWS: Mention Python API addition.
5644         * python/py-type.c (typy_get_objfile): New method.
5645
5646 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5647
5648         * NEWS: Mention the new set|show style [title|highlight].
5649         Mention changes to "show style", "help" and "apropos".
5650
5651 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5652
5653         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5654         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5655         instead of print_help_for_command.
5656         (print_doc_of_command): New function.
5657         (help_list): Add 'apropos -v word' suggestion.
5658         (print_help_for_command): Style the command name using title style.
5659         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5660         (_initialize_cli_cmds): Describe -v in apropos_command help.
5661
5662 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5663
5664         * cli/cli-style.h (cli_style_option): Add name in constructor,
5665         add m_name class member, add constructor with intensity,
5666         add name class function.
5667         (cli_style_option::add_setshow_commands): Remove name argument.
5668         (highlight_style, title_style): New styles.
5669         * cli/cli-style.c (do_show): New function that shows a style
5670         characteristic styling the style name with itself.
5671         (set_style_name): New function.
5672         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5673         Update all callers according to the changes in cli/cli-style.h.
5674         * utils.h (fputs_highlighted): New function.
5675         * utils.c (fputs_highlighted): Likewise.
5676
5677 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5678
5679         * NEWS: Mention new pipe command and new convenience variables.
5680
5681 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5682
5683         * cli/cli-cmds.c (pipe_command): New function.
5684         (_initialize_cli_cmds): Call add_com for pipe_command.
5685         Define | as an alias for pipe.
5686         (exit_status_set_internal_vars): New function.
5687         (shell_escape): Call exit_status_set_internal_vars.
5688         cli/cli-decode.c (find_command_name_length): Recognize | as
5689         a single character command.
5690
5691 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5692
5693         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5694         top.c (execute_command_to_ui_file): New function, mostly a copy
5695         of execute_command_to_string.
5696         (execute_command_to_string): Implement by calling
5697         execute_command_to_ui_file.
5698
5699 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5700
5701         * top.h (saved_command_line): Remove declaration.
5702         * top.c (previous_saved_command_line, previous_repeat_arguments):
5703         New variables.
5704         (saved_command_line): Make static, define together with other
5705         'repeat variables'.
5706         (dont_repeat): Clear repeat_arguments.
5707         (repeat_previous, get_saved_command_line, save_command_line):
5708         New functions.
5709         (gdb_init): Initialize saved_command_line
5710         and previous_saved_command_line.
5711         * main.c (captured_main_1): Remove saved_command_line initialization.
5712         * event-top.c (handle_line_of_input): Update to use
5713         the new 'repeat' related functions instead of direct access to
5714         saved_command_line.
5715         * command.h (repeat_previous, get_saved_command_line,
5716         save_command_line): New declarations.
5717         (dont_repeat): Add comment.
5718
5719 2019-05-30  Tom Tromey  <tromey@adacore.com>
5720
5721         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5722         Fix comment.
5723         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5724
5725 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5726
5727         PR cli/24587
5728         * completer.c (complete): Initialize variable word.
5729
5730 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5731
5732         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5733         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5734         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5735         'body' is NULL to the outter 'if', protecting the '!is_define'
5736         situation as well.
5737
5738 2019-05-29  Tom Tromey  <tromey@adacore.com>
5739
5740         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5741         (dwarf_unknown): New function.
5742         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5743         (dwarf_type_encoding_name): Use dwarf_unknown.
5744
5745 2019-05-29  Tom Tromey  <tromey@adacore.com>
5746
5747         PR c++/20020:
5748         * cp-valprint.c (cp_print_value_fields): Call
5749         cp_print_static_field inside "try".
5750
5751 2019-05-29  Tom Tromey  <tromey@adacore.com>
5752
5753         * inflow.c (struct terminal_info): Add default operator=.
5754         * configure: Rebuild.
5755         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5756         -Wdeprecated-copy-dtor, -Wredundant-move.
5757
5758 2019-05-29  Tom Tromey  <tromey@adacore.com>
5759
5760         * NEWS: Add entry.
5761         * infcmd.c (print_return_value_1): Handle finish_print
5762         option.
5763         (show_print_finish): New function.
5764         (_initialize_infcmd): Add "set/show print finish" commands.
5765         * valprint.c (user_print_options): Initialize new member.
5766         * valprint.h (struct value_print_options) <finish_print>: New
5767         member.
5768
5769 2019-05-28  Tom Tromey  <tromey@adacore.com>
5770
5771         * ada-lang.c (ada_remove_Xbn_suffix)
5772         (find_old_style_renaming_symbol)
5773         (parse_old_style_renaming): Remove.
5774         (ada_find_renaming_symbol): Don't call
5775         find_old_style_renaming_symbol.
5776         (ada_is_renaming_symbol): Rename from
5777         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5778         bool.  Now static.
5779         (ada_read_var_value): Update and simplify.
5780         * ada-exp.y (write_var_or_type): Remove old code.
5781
5782 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5783
5784         * event-top.c: Remove include comment.
5785         * inflow.c (class scoped_ignore_sigttou): Move from here...
5786         * inflow.h (class scoped_ignore_sigttou): ...to here.
5787         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5788         * top.c:  Remove include comment.
5789
5790 2019-05-27  Tom Tromey  <tom@tromey.com>
5791
5792         * NEWS: Fix typo.
5793
5794 2019-05-22  Tom Tromey  <tromey@adacore.com>
5795
5796         * target.c (target_follow_exec): Constify parameter.
5797         * target-delegates.c: Rebuild.
5798         * remote.c (remote_target::follow_exec): Constify parameter.
5799         * infrun.c (follow_exec): Constify parameter.
5800         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5801         (target_follow_exec): Likewise.
5802
5803 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5804
5805         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5806         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5807
5808 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5809
5810         * NEWS: Add debugredirect and testsuite sections.
5811
5812 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5813
5814         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5815         target descriptions using exclusively floating point register name
5816         aliases.
5817
5818 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5819
5820         PR gdb/18644:
5821         * f-lang.c (build_fortran_types): Handle the case where
5822         gdbarch_floatformat_for_type returns a nullptr.
5823
5824 2019-05-21  Tom de Vries  <tdevries@suse.de>
5825
5826         PR cli/24587
5827         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5828
5829 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5830
5831         PR gdb/18644:
5832         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5833         16-byte floats.
5834         * i386-tdep.c (i386_floatformat_for_type): Use
5835         floatformats_ia64_quad for the 16-byte floating point component
5836         within a fortran 32-byte complex number.
5837
5838 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5841         delete default constructor.
5842         (find_partial_die): Update to return const struct.
5843         (partial_die_parent_scope): Move variable declaration into scope
5844         of its use and change its type to auto.
5845         (guess_partial_die_structure_name): Likewise.
5846         (partial_die_info::fixup): Likewise.
5847
5848 2019-05-17  Tom Tromey  <tromey@adacore.com>
5849
5850         * source.c (find_and_open_source): Remove cast.
5851
5852 2019-05-17  Tom Tromey  <tromey@adacore.com>
5853
5854         * annotate.c (annotate_source): Make "filename" const.
5855         * annotate.h (annotate_source): Use const.
5856
5857 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5858
5859         * disasm.c (set_disassembler_options): Send errors to stderr.
5860
5861 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5862
5863         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5864         (cli_interp_base::set_logging): Check debug_redirect.
5865         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5866         * cli/cli-logging.c (debug_redirect): Add static variable.
5867         (pop_output_files): Add default param.
5868         (handle_redirections): Print debug setting.
5869         (show_logging_command): Likewise.
5870         (_initialize_cli_logging): Add debugredirect command.
5871         * interps.c (current_interp_set_logging): Add debug_redirect
5872         parameter.
5873         * interps.h (set_logging): Add debug_redirect parameter.
5874         (current_interp_set_logging): Likewise.
5875         * mi/mi-common.h: Likewise.
5876         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5877
5878 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5879             Tom Tromey  <tromey@adacore.com>
5880
5881         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5882         directly.
5883         * cli/cli-interp.h (make_logging_output): Remove declaration.
5884         * cli/cli-logging.c (make_logging_output): Remove function.
5885         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5886         directly.
5887         * ui-file.c (tee_file::tee_file): Remove bools.
5888         (tee_file::~tee_file): Remove deletes.
5889         * ui-file.h (tee_file): Remove bools.
5890
5891 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5892
5893         * mi/mi-cmds.h (mi_cmd_complete): New function.
5894         * mi/mi-main.c (mi_cmd_complete): Likewise.
5895         * mi/mi-cmds.c: Define new MI command -complete.
5896         * NEWS: Mention new -complete command.
5897
5898 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5899
5900         * completer.h (complete): New function.
5901         * completer.c (complete): Likewise.
5902         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5903         function defined in completer.h.
5904
5905 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5906
5907         * MAINTAINERS (Write After Approval): Add myself.
5908
5909 2019-05-17  Tom de Vries  <tdevries@suse.de>
5910
5911         PR gdb/24094
5912         * dwarf2read.c (struct cu_partial_die_info): New struct.
5913         (find_partial_die): Return cu_partial_die_info.
5914         (partial_die_parent_scope, guess_partial_die_structure_name)
5915         (partial_die_info::fixup): Handle new return type of find_partial_die.
5916
5917 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5918
5919         PR breakpoints/24541
5920         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5921         "std::string", simplifying the algorithm.
5922
5923 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5924
5925         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5926         (stap_static_probe_ops::get_probes): Likewise.
5927
5928 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5929
5930         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5931         '-')" and "else if".
5932         (stap_parse_single_operand): Join checks for
5933         "gdbarch_stap_parse_special_token_p" and
5934         "gdbarch_stap_parse_special_token" in the same "if" statement.
5935         Invert check when verifying for operation on register
5936         displacement.
5937
5938 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5939
5940         * stap-probe.c (stap_get_opcode): Update comment.
5941         (stap_get_expected_argument_type): Likewise.
5942         (handle_stap_probe): Likewise.
5943
5944 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5945
5946         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5947         return type to 'bool'.  Adjust comment.  Use 'bool' when
5948         appropriate.
5949         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5950         * stap-probe.c (stap_parse_argument_1): Likewise.
5951         (stap_is_operator): Likewise.
5952         (stap_is_generic_prefix): Likewise.
5953         (stap_is_register_prefix): Likewise.
5954         (stap_is_register_indirection_prefix): Likewise.
5955         (stap_is_integer_prefix): Likewise.
5956         (stap_generic_check_suffix): Likewise.
5957         (stap_check_integer_suffix): Likewise.
5958         (stap_check_register_suffix): Likewise.
5959         (stap_check_register_indirection_suffix): Likewise.
5960         (stap_parse_register_operand): Likewise.
5961         (stap_parse_single_operand): Likewise.
5962         (stap_parse_argument_1): Likewise.
5963         (stap_probe::get_argument_count): Likewise.
5964         (stap_is_operator): Likewise.
5965
5966 2019-05-16  Tom Tromey  <tromey@adacore.com>
5967
5968         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5969         keyword to foreach.
5970
5971 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5972
5973         * linux-thread-db.c (try_thread_db_load_1): Change return type
5974         to bool.
5975         (try_thread_db_load): Likewise.
5976         (try_thread_db_load_from_pdir_1): Likewise.
5977         (try_thread_db_load_from_pdir): Likewise.
5978         (try_thread_db_load_from_sdir): Likewise.
5979         (try_thread_db_load_from_dir): Likewise.
5980         (thread_db_load_search): Likewise.
5981         (has_libpthread): Likewise.
5982         (thread_db_load): Likewise.
5983
5984 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5985
5986         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5987         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5988         NULL, and complain/return if that's the case.
5989
5990 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5991
5992         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5993         (advance, posn, abstract_read_memory): New functions.
5994         [struct mem_read_abstraction]: New struct.
5995         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5996
5997 2019-05-14  Tom Tromey  <tromey@adacore.com>
5998
5999         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6000         value is not lval_memory.
6001
6002 2019-05-14  Tom Tromey  <tromey@adacore.com>
6003
6004         * solib.c (info_sharedlibrary_command): Style the file name.
6005
6006 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6007
6008         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6009         (aarch64_vnv_type): Likewise.
6010         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6011         * common/tdesc.c: Likewise.
6012         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6013         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6014         * features/aarch64-fpu.xml: Add ieee half view.
6015         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6016         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6017         * gdbtypes.h (struct builtin_type): Likewise.
6018         (struct objfile_type): Likewise.
6019
6020 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6021
6022         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6023         typo.
6024         * location.h (string_to_event_location): Likewise.
6025
6026 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6027
6028         GDB 8.3 released.
6029
6030 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6031
6032         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6033         New variable declaration.
6034         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6035         New variable.
6036         (print_one_breakpoint): Use ui_out::test_flags and new global
6037         variable to compute use_fixed_output.
6038         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6039         Remove.
6040         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6041         (mi_multi_location_breakpoint_output_fixed): Remove.
6042         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6043         new variable.
6044         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6045         fix_multi_location_breakpoint_output flag if version >= 3.
6046         * ui-out.h (enum ui_out_flag)
6047         <fix_multi_location_breakpoint_output>: New enumerator.
6048
6049 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6050
6051         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6052
6053 2019-05-10  Tom Tromey  <tromey@adacore.com>
6054
6055         * ada-lang.c (catch_ada_completer): New function.
6056         (_initialize_ada_language): Use it.
6057
6058 2019-05-10  Tom Tromey  <tromey@adacore.com>
6059
6060         * thread.c (print_thread_info): Make "requested_threads" const.
6061         * gdbthread.h (print_thread_info): Make "requested_threads"
6062         const.
6063         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6064         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6065
6066 2019-05-08  Tom Tromey  <tom@tromey.com>
6067
6068         * gdbtypes.c (objfile_type_data): Change type.
6069         (objfile_type, _initialize_gdbtypes): Update.
6070
6071 2019-05-08  Tom Tromey  <tom@tromey.com>
6072
6073         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6074         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6075         (_initialize_dwarf2_frame): Update.
6076
6077 2019-05-08  Tom Tromey  <tom@tromey.com>
6078
6079         * objc-lang.c (objc_objfile_data): Change type.
6080         (find_methods): Update.
6081         (_initialize_objc_lang): Remove.
6082
6083 2019-05-08  Tom Tromey  <tom@tromey.com>
6084
6085         * stabsread.c (rs6000_builtin_type_data): Change type.
6086         (rs6000_builtin_type, _initialize_stabsread): Update.
6087
6088 2019-05-08  Tom Tromey  <tom@tromey.com>
6089
6090         * mips-tdep.c (mips_pdr_data): Remove.
6091         (_initialize_mips_tdep): Update.
6092
6093 2019-05-08  Tom Tromey  <tom@tromey.com>
6094
6095         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6096         (hppa_init_objfile_priv_data, read_unwind_info)
6097         (find_unwind_entry, _initialize_hppa_tdep): Update.
6098
6099 2019-05-08  Tom Tromey  <tom@tromey.com>
6100
6101         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6102         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6103         on obstack.
6104         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6105
6106 2019-05-08  Tom Tromey  <tom@tromey.com>
6107
6108         * mdebugread.c (basic_type_data): Change type.
6109         (basic_type, _initialize_mdebugread): Update.
6110
6111 2019-05-08  Tom Tromey  <tom@tromey.com>
6112
6113         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6114
6115 2019-05-08  Tom Tromey  <tom@tromey.com>
6116
6117         * nto-tdep.c (nto_inferior_data_reg): Change type.
6118         (nto_inferior_data): Update.
6119         (nto_inferior_data_cleanup, nto_new_inferior_data)
6120         (_initialize_nto_tdep): Remove.
6121         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6122
6123 2019-05-08  Tom Tromey  <tom@tromey.com>
6124
6125         * ada-lang.c (struct ada_inferior_data): Add initializers.
6126         (ada_inferior_data): Change type.
6127         (ada_inferior_data_cleanup): Remove.
6128         (get_ada_inferior_data, ada_inferior_exit)
6129         (struct ada_pspace_data): Add initializers, destructor.
6130         (ada_pspace_data_handle): Change type.
6131         (get_ada_pspace_data): Update.
6132         (ada_pspace_data_cleanup): Remove.
6133
6134 2019-05-08  Tom Tromey  <tom@tromey.com>
6135
6136         * coffread.c (struct coff_symfile_info): Add initializers.
6137         (coff_objfile_data_key): Move lower.  Change type.
6138         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6139         Update.
6140         (coff_free_info): Remove.
6141
6142 2019-05-08  Tom Tromey  <tom@tromey.com>
6143
6144         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6145         (fbsd_pspace_data_handle): Move lower.  Change type.
6146         (get_fbsd_pspace_data): Update.
6147         (fbsd_pspace_data_cleanup): Remove.
6148         (_initialize_fbsd_tdep): Update.
6149
6150 2019-05-08  Tom Tromey  <tom@tromey.com>
6151
6152         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6153         (get_ada_tasks_pspace_data): Update.
6154         (ada_tasks_pspace_data_cleanup): Remove.
6155         (_initialize_tasks): Update.
6156         (ada_tasks_inferior_data_handle): Change type.
6157         (get_ada_tasks_inferior_data): Update.
6158         (ada_tasks_inferior_data_cleanup): Remove.
6159         (struct ada_tasks_pspace_data): Add initializers.
6160
6161 2019-05-08  Tom Tromey  <tom@tromey.com>
6162
6163         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6164         * symfile-debug.c (debug_sym_get_probes): Change type.
6165         * stap-probe.c (handle_stap_probe):
6166         (stap_static_probe_ops::get_probes): Change type.
6167         * probe.h (class static_probe_ops) <get_probes>: Change type.
6168         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6169         (parse_probes_in_pspace): Update.
6170         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6171         Update.
6172         (any_static_probe_ops::get_probes): Change type.
6173         * elfread.c (elfread_data): New typedef.
6174         (probe_key): Change type.
6175         (elf_get_probes): Likewise.  Update.
6176         (probe_key_free): Remove.
6177         (_initialize_elfread): Update.
6178         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6179         Change type.
6180         (dtrace_process_dof_probe, dtrace_process_dof)
6181         (dtrace_static_probe_ops::get_probe): Change type.
6182
6183 2019-05-08  Tom Tromey  <tom@tromey.com>
6184
6185         * xcoffread.c (struct xcoff_symfile_info): Rename from
6186         coff_symfile_info.  Add initializers.
6187         (xcoff_objfile_data_key): Move lower.  Change type.
6188         (XCOFF_DATA): Rewrite.
6189         (xcoff_free_info): Remove.
6190         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6191         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6192         (xcoff_initial_scan): Update.
6193
6194 2019-05-08  Tom Tromey  <tom@tromey.com>
6195
6196         * solib-svr4.c (struct svr4_info): Add initializers and
6197         destructor.
6198         <probes_table>: Now an htab_up.
6199         (solib_svr4_pspace_data): Change type.
6200         (free_probes_table): Simplify.
6201         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6202         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6203         (probes_table_remove_objfile_probes, register_solib_event_probe)
6204         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6205         (_initialize_svr4_solib): Update.
6206
6207 2019-05-08  Tom Tromey  <tom@tromey.com>
6208
6209         * remote.c (remote_pspace_data): Change type.
6210         (remote_pspace_data_cleanup): Remove.
6211         (get_remote_exec_file, set_pspace_remote_exec_file)
6212         (_initialize_remote): Update.
6213
6214 2019-05-08  Tom Tromey  <tom@tromey.com>
6215
6216         * breakpoint.c (breakpoint_objfile_key): Change type.
6217         (get_breakpoint_objfile_data): Update.
6218         (free_breakpoint_objfile_data): Remove.
6219         (_initialize_breakpoint): Update.
6220
6221 2019-05-08  Tom Tromey  <tom@tromey.com>
6222
6223         * linux-tdep.c (struct linux_info): Add initializers.
6224         (linux_inferior_data): Move.  Change type.
6225         (invalidate_linux_cache_inf): Update.
6226         (linux_inferior_data_cleanup): Remove.
6227         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6228
6229 2019-05-08  Tom Tromey  <tom@tromey.com>
6230
6231         * auxv.c (auxv_inferior_data): Move.  Change type.
6232         (auxv_inferior_data_cleanup): Remove.
6233         (invalidate_auxv_cache_inf): Rewrite.
6234         (get_auxv_inferior_data, _initialize_auxv): Update.
6235
6236 2019-05-08  Tom Tromey  <tom@tromey.com>
6237
6238         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6239         (symfile_debug_objfile_data_key): Change type.
6240         (symfile_debug_installed, debug_qf_has_symbols)
6241         (debug_qf_find_last_source_symtab)
6242         (debug_qf_forget_cached_source_info)
6243         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6244         (debug_qf_print_stats, debug_qf_dump)
6245         (debug_qf_expand_symtabs_for_function)
6246         (debug_qf_expand_all_symtabs)
6247         (debug_qf_expand_symtabs_with_fullname)
6248         (debug_qf_map_matching_symbols)
6249         (debug_qf_expand_symtabs_matching)
6250         (debug_qf_find_pc_sect_compunit_symtab)
6251         (debug_qf_map_symbol_filenames)
6252         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6253         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6254         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6255         (debug_sym_read_linetable, debug_sym_relocate): Update.
6256         (symfile_debug_free_objfile): Remove.
6257         (install_symfile_debug_logging, _initialize_symfile_debug):
6258         Update.
6259
6260 2019-05-08  Tom Tromey  <tom@tromey.com>
6261
6262         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6263         allocate_on_obstack.
6264         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6265         (get_dwarf2_per_objfile): Update.
6266         (set_dwarf2_per_objfile): Remove.
6267         (dwarf2_has_info, dwarf2_get_section_info): Update.
6268         (dwarf2_free_objfile): Remove.
6269         (_initialize_dwarf2_read): Update.
6270
6271 2019-05-08  Tom Tromey  <tom@tromey.com>
6272
6273         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6274         initializers.
6275         <unsupported_script_warning_printed,
6276         script_not_found_warning_printed>: Now bool.
6277         (auto_load_pspace_data): Change type.
6278         (~auto_load_pspace_info): Rename from
6279         auto_load_pspace_data_cleanup.
6280         (get_auto_load_pspace_data, init_loaded_scripts_info)
6281         (clear_section_scripts, maybe_print_unsupported_script_warning)
6282         (maybe_print_script_not_found_warning, _initialize_auto_load):
6283         Update.
6284
6285 2019-05-08  Tom Tromey  <tom@tromey.com>
6286
6287         * objfiles.c (objfile_pspace_info): Add destructor and
6288         initializers.
6289         (objfiles_pspace_data): Change type.
6290         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6291         (get_objfile_pspace_data): Update.
6292         (objfiles_bfd_data): Change type.
6293         (get_objfile_bfd_data): Update.
6294         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6295
6296 2019-05-08  Tom Tromey  <tom@tromey.com>
6297
6298         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6299         Change type.
6300         (get_catch_syscall_inferior_data): Update.
6301         (catch_syscall_inferior_data_cleanup): Remove.
6302         (_initialize_break_catch_syscall): Update.
6303
6304 2019-05-08  Tom Tromey  <tom@tromey.com>
6305
6306         * inflow.c (struct terminal_info): Add destructor and
6307         initializers.
6308         (inflow_inferior_data): Change type.
6309         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6310         (get_inflow_inferior_data, inflow_inferior_exit)
6311         (swap_terminal_info, _initialize_inflow): Update.
6312
6313 2019-05-08  Tom Tromey  <tom@tromey.com>
6314
6315         * target-dcache.c (target_dcache_cleanup): Remove.
6316         (target_dcache_aspace_key): Change type.
6317         (target_dcache_init_p, target_dcache_invalidate)
6318         (target_dcache_get, target_dcache_get_or_init)
6319         (_initialize_target_dcache): Update.
6320         * dcache.h (struct dcache_deleter): New.
6321
6322 2019-05-08  Tom Tromey  <tom@tromey.com>
6323
6324         * symtab.c (struct symbol_cache): Add destructor and
6325         initializers.
6326         (symbol_cache_key): Move.  Change type.
6327         (make_symbol_cache, free_symbol_cache): Remove.
6328         (get_symbol_cache): Update.
6329         (symbol_cache_cleanup): Remove.
6330         (ALL_PSPACES, symbol_cache_flush)
6331         (maintenance_print_symbol_cache)
6332         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6333         Update.
6334
6335 2019-05-08  Tom Tromey  <tom@tromey.com>
6336
6337         * symtab.c (struct main_info): Add destructor and initializers.
6338         (main_progspace_key): Move.  Change type.
6339         (get_main_info): Update.
6340         (main_info_cleanup): Remove.
6341         (_initialize_symtab): Update.
6342
6343 2019-05-08  Tom Tromey  <tom@tromey.com>
6344
6345         * registry.h (DECLARE_REGISTRY): Define the _key class.
6346
6347 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * NEWS: Merge two 'New commands' sections.
6350
6351 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6352
6353         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6354         parameter and use Ada language definition instead.
6355         (ada_val_print_ptr): Remove unused language parameter.
6356         (ada_val_print_num): Remove language parameter and use Ada language
6357         definition instead.
6358         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6359         parameter.
6360         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6361         parameter and use Ada language definition instead.
6362         (ada_val_print_1): Update all ada_val_print_xxx calls.
6363         Remove language parameter.
6364         (ada_val_print): Update ada_val_print_1 call.
6365
6366 2019-05-08  Tom Tromey  <tromey@adacore.com>
6367
6368         * remote.c (remote_hw_watchpoint_limit)
6369         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6370         Now static.
6371
6372 2019-05-08  Tom Tromey  <tromey@adacore.com>
6373
6374         * maint.c (_initialize_maint_cmds): Move initialization code to
6375         remote.c.
6376         (watchdog, show_watchdog): Move to remote.c.
6377         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6378         "watchdog" static.
6379         (_initialize_remote): Move initialization code from maint.c.
6380         * defs.h (watchdog): Don't declare.
6381
6382 2019-05-08  Tom Tromey  <tromey@adacore.com>
6383
6384         * tui/tui-interp.c: Include main.h.
6385         * interps.c: Include main.h.
6386         * main.h (interpreter_p): Declare.
6387         * defs.h (interpreter_p): Don't declare.
6388
6389 2019-05-08  Tom Tromey  <tromey@adacore.com>
6390
6391         * dwarf2loc.c: Include dwarf2read.h.
6392         * defs.h (read_unsigned_leb128): Don't declare.
6393         * dwarf2read.h (read_unsigned_leb128): Declare.
6394
6395 2019-05-08  Tom Tromey  <tromey@adacore.com>
6396
6397         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6398         method.
6399
6400 2019-05-08  Tom Tromey  <tromey@adacore.com>
6401
6402         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6403         when no wrap column is set.
6404
6405 2019-05-08  Tom Tromey  <tromey@adacore.com>
6406
6407         * c-lang.c (c_get_string): Handle non-C-style arrays.
6408
6409 2019-05-08  Tom Tromey  <tromey@adacore.com>
6410
6411         * typeprint.c (print_offset_data::update): Print the bit offset,
6412         not the number of bits remaining.
6413
6414 2019-05-08  Tom Tromey  <tromey@adacore.com>
6415
6416         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6417         padding at end of comment.
6418
6419 2019-05-08  Tom Tromey  <tromey@adacore.com>
6420
6421         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6422         Compare main types.
6423
6424 2019-05-06  Tom Tromey  <tom@tromey.com>
6425
6426         * common/scoped_mmap.c: Include common-defs.h.
6427         * common/scoped_mmap.h: Don't include config.h.
6428
6429 2019-05-04  Tom Tromey  <tom@tromey.com>
6430
6431         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6432         (struct aarch64_call_info): Add initializers.
6433         <si>: Now a std::vector.
6434         (pass_on_stack, aarch64_push_dummy_call): Update.
6435
6436 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6437             Tom Tromey  <tom@tromey.com>
6438
6439         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6440         (ppc_threads): Now a std::vector.  Now static.
6441         (hwdebug_find_thread_points_by_tid)
6442         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6443         Update.
6444
6445 2019-05-04  Tom Tromey  <tom@tromey.com>
6446
6447         * arc-tdep.c (arc_tdesc_init): Return bool.
6448
6449 2019-05-04  Tom Tromey  <tom@tromey.com>
6450
6451         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6452         Use gdb_assert_not_reached.
6453
6454 2019-05-04  Tom Tromey  <tom@tromey.com>
6455
6456         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6457         "false".
6458
6459 2019-05-04  Tom Tromey  <tom@tromey.com>
6460
6461         * arc-tdep.c (arc_tdesc_init): Use bool.
6462
6463 2019-05-04  Tom Tromey  <tom@tromey.com>
6464
6465         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6466
6467 2019-05-04  Tom Tromey  <tom@tromey.com>
6468
6469         * cli/cli-cmds.c (valid_command_p): Return bool.
6470
6471 2019-05-04  Tom Tromey  <tom@tromey.com>
6472
6473         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6474         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6475
6476 2019-05-04  Raul Tambre  <raul@tambre.ee>
6477
6478         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6479         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6480         operator for comparison.
6481
6482 2019-05-04  Tom Tromey  <tom@tromey.com>
6483
6484         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6485         (lookup_partial_symbol, print_partial_symbols)
6486         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6487         (psymbol_compare): Update.
6488         (add_psymbol_to_bcache): Clear the entire psymbol.
6489         (maintenance_check_psymtabs): Update.
6490         * psympriv.h (struct partial_symbol): Don't derive from
6491         general_symbol_info.
6492         <obj_section, unrelocated_address, address,
6493         set_unrelocated_address>: Update.
6494         <ginfo>: New member.
6495         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6496         (debug_names::write_psymbols): Update.
6497
6498 2019-05-04  Tom de Vries  <tdevries@suse.de>
6499
6500         * contrib/cc-with-tweaks.sh: Support -n arg.
6501
6502 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6503
6504         * corelow.c (core_target::detach): Ensure frame cache and
6505         register caches are cleared.
6506         inferior.c (exit_inferior_1): Likewise.
6507
6508 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6509             Tom Tromey  <tom@tromey.com>
6510
6511         * dictionary.c (collate_pending_symbols_by_language): Remove
6512         "struct" from foreach.
6513         * symtab.c (lookup_global_symbol_from_objfile)
6514         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6515         foreach.
6516         * ser-tcp.c (net_open): Remove "struct" from foreach.
6517         * objfiles.c (objfile_relocate, objfile_rebase)
6518         (objfile_has_symbols): Remove "struct" from foreach.
6519         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6520         from foreach.
6521         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6522         foreach.
6523         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6524         "struct" from foreach.
6525         * ada-lang.c (create_excep_cond_exprs)
6526         (ada_exception_catchpoint_cond_string): Remove "struct" from
6527         foreach.
6528
6529 2019-05-03  Tom Tromey  <tromey@adacore.com>
6530
6531         * ada-exp.y (convert_char_literal): Check suffix of each
6532         enumerator.
6533
6534 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6535
6536         PR ada/21406:
6537         * ada-exp.y (yywrap): Don't define.
6538         * ada-lex.l (%option): Add noyywrap
6539         (yywrap): Remove.
6540
6541 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6542
6543         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6544         _WIN32_WINNT to the XP level, unless already defined to a higher
6545         level.
6546
6547         * unittests/parse-connection-spec-selftests.c:
6548         * ser-tcp.c:
6549         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6550         override.
6551
6552         * symfile.c (find_separate_debug_file): Remove colon from the
6553         drive spec of DOS/Windows file names of the target, so that the
6554         file name produced from DEBUGDIR and the target's directory will
6555         be valid on DOS/Windows systems.
6556
6557 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6558
6559         * rust-lang.c (val_print_struct): Handle printing structures
6560         containing strings.
6561
6562 2019-05-02  Tom Tromey  <tromey@adacore.com>
6563
6564         * valarith.c (_initialize_valarith): Remove.
6565
6566 2019-05-01  Tom Tromey  <tromey@adacore.com>
6567
6568         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6569         bitfields.
6570
6571 2019-05-01  Tom Tromey  <tromey@adacore.com>
6572
6573         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6574         for big-endian copies.
6575
6576 2019-04-30  Ali Tamur  <tamur@google.com>
6577         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6578         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6579         (read_3_bytes): New function.
6580
6581 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6582
6583         * windows-nat.c (main_thread_id): Delete.
6584         (handle_output_debug_string): Replace main_thread_id by
6585         current_event.dwThreadId.
6586         (fake_create_process): Likewise.
6587         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6588         Do not set main_thread_id.
6589         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6590         current_event.dwThreadId.
6591         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6592
6593 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6594
6595         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6596         Use current_event.dwThreadId instead of main_thread_id.
6597
6598 2019-04-30  Tom Tromey  <tromey@adacore.com>
6599
6600         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6601         (create_excep_cond_exprs): Iterate over program spaces.
6602         (ada_exception_catchpoint_cond_string): Examine all minimal
6603         symbols for exception types.
6604
6605 2019-04-30  Tom Tromey  <tromey@adacore.com>
6606
6607         PR c++/24470:
6608         * dwarf2read.c (process_structure_scope): Handle case where type
6609         has template parameters but no symbol was created.
6610
6611 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6612             Chris January  <chris.january@arm.com>
6613
6614         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6615         qualifier.
6616         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6617
6618 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6619
6620         * f-typeprint.c (f_print_type): Update rules for printing
6621         whitespace.
6622         (f_type_print_varspec_suffix): Likewise.
6623
6624 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6625             Chris January  <chris.january@arm.com>
6626
6627         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6628         function arguments.
6629
6630 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6631
6632         * f-lang.c (build_fortran_types): Change name of void type to
6633         lower case.
6634         * f-typeprint.c (f_type_print_base): Print the name of the void
6635         type, rather than a fixed string.
6636         * f-valprint.c (f_decorations): Use lower case void string.
6637
6638 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6639             Chris January  <chris.january@arm.com>
6640
6641         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6642         types for Fortran.
6643
6644 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6645             Chris January  <chris.january@arm.com>
6646             David Lecomber  <david.lecomber@arm.com>
6647
6648         * f-exp.y (BINOP_INTRINSIC): New token.
6649         (exp): New parser rule handling BINOP_INTRINSIC.
6650         (f77_keywords): Add new builtin procedures.
6651         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6652         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6653         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6654         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6655         (print_unop_subexp_f): New function.
6656         (print_binop_subexp_f): New function.
6657         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6658         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6659         (dump_subexp_body_f): Likewise.
6660         (operator_check_f): Likewise.
6661         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6662         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6663
6664 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6665
6666         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6667         UNOP_KIND.
6668         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6669         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6670         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6671         (operator_length_f): New fuction.
6672         (print_subexp_f): New function.
6673         (op_name_f): New function.
6674         (dump_subexp_body_f): New function.
6675         (operator_check_f): New function.
6676         (exp_descriptor_f): Replace standard expression handling functions
6677         with new functions.
6678         * gdb/fortran-operator.def: New file.
6679         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6680         * gdb/std-operator.def: Remove UNOP_KIND.
6681
6682 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6683
6684         * std-operator.def: Remove unbalanced, stray double quote
6685         character.
6686
6687 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6688             Chris January  <chris.january@arm.com>
6689             Daniel Everett  <daniel.everett@arm.com>
6690             Nick Forrington  <nick.forrington@arm.com>
6691             Richard Bunt  <richard.bunt@arm.com>
6692
6693         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6694         of depth when printing anonymous structs or unions.
6695         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6696         Don't print either the top-level value, or the children if the
6697         max-depth is exceeded.
6698         (ppscm_print_children): When printing the key of a map, allow one
6699         extra level of depth.
6700         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6701         print either the top-level value, or the children if the max-depth
6702         is exceeded.
6703         (print_children): When printing the key of a map, allow one extra
6704         level of depth.
6705         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6706         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6707         (user_print_options): Initialise max_depth field.
6708         (val_print_scalar_or_string_type_p): New function.
6709         (val_print): Check to see if the max depth has been reached.
6710         (val_print_check_max_depth): Define new function.
6711         (show_print_max_depth): New function.
6712         (_initialize_valprint): Add 'print max-depth' option.
6713         * valprint.h (struct value_print_options) <max_depth>: New field.
6714         (val_print_check_max_depth): Declare new function.
6715         * NEWS: Document new feature.
6716
6717 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6718
6719         * ada-lang.c (ada_language_defn): Initialise new field.
6720         * c-lang.c (c_is_string_type_p): New function.
6721         (c_language_defn): Initialise new field.
6722         (cplus_language_defn): Initialise new field.
6723         (asm_language_defn): Initialise new field.
6724         (minimal_language_defn): Initialise new field.
6725         * c-lang.h (c_is_string_type_p): Declare new function.
6726         * d-lang.c (d_language_defn): Initialise new field.
6727         * f-lang.c (f_is_string_type_p): New function.
6728         (f_language_defn): Initialise new field.
6729         * go-lang.c (go_is_string_type_p): New function.
6730         (go_language_defn): Initialise new field.
6731         * language.c (default_is_string_type_p): New function.
6732         (unknown_language_defn): Initialise new field.
6733         (auto_language_defn): Initialise new field.
6734         * language.h (struct language_defn) <la_is_string_type_p>: New
6735         member variable.
6736         (default_is_string_type_p): Declare new function.
6737         * m2-lang.c (m2_language_defn): Initialise new field.
6738         * objc-lang.c (objc_language_defn): Initialise new field.
6739         * opencl-lang.c (opencl_language_defn): Initialise new field.
6740         * p-lang.c (pascal_is_string_type_p): New function.
6741         (pascal_language_defn): Initialise new field.
6742         * rust-lang.c (rust_is_string_type_p): New function.
6743         (rust_language_defn): Initialise new field.
6744
6745 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6746
6747         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6748         New field.
6749         * ada-lang.c (ada_language_defn): Initialise new field.
6750         * c-lang.c (c_language_defn): Likewise.
6751         (cplus_language_defn): Likewise.
6752         (asm_language_defn): Likewise.
6753         (minimal_language_defn): Likewise.
6754         * d-lang.c (d_language_defn): Likewise.
6755         * f-lang.c (f_language_defn): Likewise.
6756         * go-lang.c (go_language_defn): Likewise.
6757         * language.c (unknown_language_defn): Likewise.
6758         (auto_language_defn): Likewise.
6759         * m2-lang.c (m2_language_defn): Likewise.
6760         * objc-lang.c (objc_language_defn): Likewise.
6761         * opencl-lang.c (opencl_language_defn): Likewise.
6762         * p-lang.c (pascal_language_defn): Likewise.
6763         * rust-lang.c (rust_language_defn): Likewise.
6764
6765 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6766
6767         * ada-lang.c (ada_is_character_type): Change return type to bool.
6768         (ada_is_string_type): Likewise.
6769         * ada-lang.h (ada_is_character_type): Update declaration
6770         (ada_is_string_type): Likewise.
6771
6772 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6773
6774         Support style in 'frame|thread apply'
6775
6776         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6777         * record.c (record_start, record_stop): Update callers of
6778         execute_command_to_string with false.
6779         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6780         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6781         methods.
6782         (class string_file): New constructor with term_out parameter.
6783         Override methods term_out and can_emit_style_escape.  New member
6784         term_out.
6785         (class stdio_file): Override can_emit_style_escape.
6786         (class tee_file): Override term_out and can_emit_style_escape.
6787         * utils.h (can_emit_style_escape): Remove.
6788         * utils.c (can_emit_style_escape): Likewise.
6789         Update all callers of can_emit_style_escape (SOMESTREAM) to
6790         SOMESTREAM->can_emit_style_escape.
6791         * source-cache.c (source_cache::get_source_lines): Likewise.
6792         * stack.c (frame_apply_command_count): Call execute_command_to_string
6793         passing the term_out characteristic of the current gdb_stdout.
6794         * thread.c (thr_try_catch_cmd): Likewise.
6795         * top.c (execute_command_to_string): pass term_out parameter
6796         to construct the string_file for the command output.
6797         * ui-file.c (term_cli_styling): New function (most code moved
6798         from utils.c can_emit_style_escape).
6799         (string_file::string_file, string_file::can_emit_style_escape,
6800         stdio_file::can_emit_style_escape, tee_file::term_out,
6801         tee_file::can_emit_style_escape): New functions.
6802
6803 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6804
6805         * NEWS: Mention the new set|show may-call-functions.
6806         * infcall.c (may_call_functions_p): New variable.
6807         (show_may_call_functions_p): New function.
6808         (call_function_by_hand_dummy): Throws an error if not
6809         may-call-functions.
6810         (_initialize_infcall): Call add_setshow_boolean_cmd for
6811         may-call-functions.
6812
6813 2019-04-25  Keith Seitz  <keiths@redhat.com>
6814
6815         PR c++/24367
6816         * cp-support.c (inspect_type): Don't attempt substitutions
6817         of symbol with the same name.
6818
6819 2019-04-25  Tom Tromey  <tromey@adacore.com>
6820
6821         PR gdb/24475:
6822         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6823         static.
6824
6825 2019-04-25  Tom Tromey  <tromey@adacore.com>
6826
6827         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6828         rvalue reference.
6829         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6830         (gdb_xml_parser::parse): Use std::move.
6831         * python/python-internal.h (gdbpy_convert_exception): Take a const
6832         reference.
6833         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6834         std::move.
6835         * python/py-utils.c (gdbpy_convert_exception): Take a const
6836         reference.
6837         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6838         Use std::move.
6839         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6840         Use std::move.
6841         * mi/mi-main.c (mi_print_exception): Take a const reference.
6842         * main.c (handle_command_errors): Take a const reference.
6843         * linespec.c (parse_linespec): Use std::move.
6844         * infcall.c (run_inferior_call): Use std::move.
6845         (call_function_by_hand_dummy): Use std::move.
6846         * exec.c (try_open_exec_file): Use std::move.
6847         * exceptions.h (exception_print, exception_fprintf)
6848         (exception_print_same): Update.
6849         * exceptions.c (print_exception, exception_print)
6850         (exception_fprintf, exception_print_same): Change parameters to
6851         const reference.
6852         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6853         * common/new-op.c: Use std::move.
6854         * common/common-exceptions.h (struct gdb_exception): Add move
6855         constructor.
6856         (struct gdb_exception_error, struct gdb_exception_quit, struct
6857         gdb_quit_bad_alloc): Change constructor to move constructor.
6858         (throw_exception): Change parameter to rvalue reference.
6859         * common/common-exceptions.c (throw_exception): Take rvalue
6860         reference.
6861         * cli/cli-interp.c (safe_execute_command): Use std::move.
6862         * breakpoint.c (insert_bp_location, location_to_sals): Use
6863         std::move.
6864
6865 2019-04-25  Tom Tromey  <tromey@adacore.com>
6866
6867         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6868         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6869         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6870         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6871         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6872         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6873         guile/scm-value.c: Use unpack.
6874         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6875         gdbscm_gdb_exception.
6876         (gdbscm_throw_gdb_exception): Likewise.
6877         (struct gdbscm_gdb_exception): New.
6878         (unpack): New function.
6879         (gdbscm_wrap): Use unpack.
6880
6881 2019-04-25  Tom Tromey  <tromey@adacore.com>
6882
6883         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6884         (gdb_rl_callback_handler): Use std::move.
6885         * common/common-exceptions.h (struct gdb_exception): Add move
6886         assignment operator.
6887         (throw_exception_sjlj): Change "exception" to const reference.
6888         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6889         (throw_exception_sjlj): Change "exception" to const reference.
6890
6891 2019-04-25  Tom Tromey  <tromey@adacore.com>
6892
6893         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6894         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6895         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6896         Update.
6897         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6898         Update.
6899         * mi/mi-interp.c (mi_interp::exec): Update.
6900         * linespec.c (parse_linespec): Update.
6901         * infcall.c (run_inferior_call): Update.
6902         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6903         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6904         (gdbscm_lookup_global_symbol): Update.
6905         * guile/scm-param.c (gdbscm_parameter_value): Update.
6906         * guile/scm-frame.c (gdbscm_frame_read_register)
6907         (gdbscm_frame_read_var): Update.
6908         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6909         * exec.c (try_open_exec_file): Update.
6910         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6911         (gdb_rl_callback_handler): Update.
6912         * common/common-exceptions.h (exception_none): Don't declare.
6913         * common/common-exceptions.c (exception_none): Don't define.
6914         (struct catcher) <exception>: Update.
6915         * cli/cli-interp.c (safe_execute_command): Update.
6916         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6917
6918 2019-04-25  Ali Tamur  <tamur@google.com>
6919
6920         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6921         (read_attribute_value): Likewise.
6922         (dwarf2_read_addr_index): Update comment.
6923         (read_str_index): Add DW_FORM_strx.
6924         (dwarf2_string_attr): Likewise.
6925         (dwarf2_const_value_attr): Likewise.
6926         (dump_die_shallow): Likewise.
6927         (dwarf2_fetch_constant_bytes): Likewise.
6928         (skip_form_bytes): Likewise.
6929         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6930
6931 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6932
6933         PR corefiles/11608
6934         PR corefiles/18187
6935         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6936         OFFSET.  Verify if current mapping contains an ELF header.
6937         (linux_find_memory_regions_full): Adjust call to
6938         dump_mapping_p.
6939
6940 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6941             Kang Li <kanglictf@gmail.com>
6942
6943         PR gdb/21600
6944
6945         * dwarf2-frame.c (read_initial_length): Be consistent about using
6946         unsigned representation of length.
6947         (decode_frame_entry_1): Likewise.  Check for wraparound of
6948         end pointer as well as buffer overflow.
6949
6950 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6951
6952         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6953         "vq".
6954
6955 2019-04-24  Tom Tromey  <tromey@adacore.com>
6956
6957         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6958
6959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6960
6961         * s12z-tdep.c (s12z_unwind_pc): Delete.
6962         (s12z_unwind_sp): Delete.
6963         (s12z_gdbarch_init): Don't register deleted functions with
6964         gdbarch.
6965
6966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6967
6968         * rl78-tdep.c (rl78_unwind_sp): Delete.
6969         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6970
6971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6972
6973         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6974         (xstormy16_unwind_pc): Delete.
6975         (xstormy16_dummy_id): Delete.
6976         (xstormy16_gdbarch_init): Don't register deleted functions with
6977         gdbarch.
6978
6979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6980
6981         * vax-tdep.c (vax_unwind_pc): Delete.
6982         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6983
6984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6985
6986         * v850-tdep.c (v850_unwind_sp): Delete.
6987         (v850_unwind_pc): Delete.
6988         (v850_dummy_id): Delete.
6989         (v850_gdbarch_init): Don't register deleted functions with
6990         gdbarch.
6991
6992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6995         (tilegx_unwind_pc): Delete.
6996         (tilegx_unwind_dummy_id): Delete.
6997         (tilegx_gdbarch_init): Don't register deleted functions with
6998         gdbarch.
6999
7000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7001
7002         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7003         (tic6x_dummy_id): Delete.
7004         (tic6x_gdbarch_init): Don't register deleted functions with
7005         gdbarch.
7006
7007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7008
7009         * sparc-tdep.c (sparc_unwind_pc): Delete.
7010         (sparc32_gdbarch_init): Don't register deleted function with
7011         gdbarch.
7012
7013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7014
7015         * sh-tdep.c (sh_unwind_sp): Delete.
7016         (sh_unwind_pc): Delete.
7017         (sh_dummy_id): Delete.
7018         (sh_gdbarch_init): Don't register deleted functions with
7019         gdbarch.
7020
7021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7022
7023         * score-tdep.c (score_unwind_sp): Delete.
7024         (score_unwind_pc): Delete.
7025         (score_dummy_id): Delete.
7026         (score_gdbarch_init): Don't register deleted functions with
7027         gdbarch.
7028
7029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * rx-tdep.c (rx_unwind_pc): Delete.
7032         (rx_unwind_sp): Delete.
7033         (rx_dummy_id): Delete.
7034         (rx_gdbarch_init): Don't register deleted functions with
7035         gdbarch.  Update comment.
7036
7037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7038
7039         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7040         (rs6000_dummy_id): Delete.
7041         (rs6000_gdbarch_init): Don't register deleted functions with
7042         gdbarch.
7043
7044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7045
7046         * or1k-tdep.c (or1k_dummy_id): Delete.
7047         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7048
7049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7050
7051         * nios2-tdep.c (nios2_dummy_id): Delete.
7052         (nios2_unwind_sp): Delete.
7053         (nios2_gdbarch_init): Don't register deleted functions with
7054         gdbarch.
7055
7056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * nds32-tdep.c (nds32_dummy_id): Delete.
7059         (nds32_unwind_pc): Delete.
7060         (nds32_unwind_sp): Delete.
7061         (nds32_gdbarch_init): Don't register deleted functions with
7062         gdbarch.
7063
7064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * msp430-tdep.c (msp430_unwind_pc): Delete.
7067         (msp430_unwind_sp): Delete.
7068         (msp430_dummy_id): Delete.
7069         (msp430_gdbarch_init): Don't register deleted functions with
7070         gdbarch.
7071
7072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7073
7074         * moxie-tdep.c (moxie_unwind_sp): Delete.
7075         (moxie_unwind_pc): Delete.
7076         (moxie_dummy_id): Delete.
7077         (moxie_gdbarch_init): Don't register deleted functions with
7078         gdbarch.
7079
7080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7081
7082         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7083         (mn10300_unwind_pc): Delete.
7084         (mn10300_unwind_sp): Delete.
7085         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7086         mn10300_unwind_sp.
7087         (mn10300_frame_unwind_init): Don't register deleted functions with
7088         gdbarch.
7089
7090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7091
7092         * mep-tdep.c (mep_unwind_pc): Delete.
7093         (mep_unwind_sp): Delete.
7094         (mep_dummy_id): Delete.
7095         (mep_gdbarch_init): Don't register deleted functions with
7096         gdbarch.
7097
7098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7099
7100         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7101         (m68hc11_unwind_sp): Delete.
7102         (m68hc11_gdbarch_init): Don't register deleted functions with
7103         gdbarch.
7104
7105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * m32r-tdep.c (m32r_unwind_sp): Delete.
7108         (m32r_unwind_pc): Delete.
7109         (m32r_dummy_id): Delete.
7110         (m32r_gdbarch_init): Don't register deleted functions with
7111         gdbarch.
7112
7113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7114
7115         * m32c-tdep.c (m32c_unwind_pc): Delete.
7116         (m32c_unwind_sp): Delete.
7117         (m32c_dummy_id): Delete.
7118         (m32c_gdbarch_init): Don't register deleted functions with
7119         gdbarch.
7120
7121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7122
7123         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7124         (lm32_unwind_pc): Delete.
7125         (lm32_dummy_id): Delete.
7126         (lm32_gdbarch_init): Don't register deleted functions with
7127         gdbarch.
7128
7129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7130
7131         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7132         (iq2000_unwind_pc): Delete.
7133         (iq2000_dummy_id): Delete.
7134         (iq2000_gdbarch_init): Don't register deleted functions with
7135         gdbarch.
7136
7137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7138
7139         * nds32-tdep.c (nds32_type_align): Delete.
7140         (nds32_push_dummy_call): Use type_align instead.
7141
7142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7143
7144         * arm-tdep.c (arm_type_align): Only handle vector override case.
7145         (arm_push_dummy_call): Use type_align.
7146         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7147
7148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7149
7150         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7151         case.
7152         (pass_on_stack): Use type_align.
7153         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7154         function.
7155
7156 2019-04-23  Tom Tromey  <tromey@adacore.com>
7157
7158         * dwarf2read.c (line_header::file_name_at): Remove unused
7159         overload.
7160
7161 2019-04-23  Tom de Vries  <tdevries@suse.de>
7162
7163         PR gdb/24438
7164         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7165         invocation.
7166
7167
7168 2019-03-27  Ali Tamur  <tamur@google.com>
7169
7170         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7171         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7172         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7173         (dwarf_expr_context::get_addr_index): Likewise
7174         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7175         (symbol_needs_eval_context::get_addr_index): Likewise
7176         (disassemble_dwarf_expression): Add DW_OP_addrx
7177         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7178         (read_cutu_die_from_dwo): Update comment
7179         (skip_one_die): Add DW_FORM_addrx
7180         (read_attribute_value): Likewise
7181         (var_decode_location): Add DW_OP_addrx
7182         (dwarf2_const_value_attr): Add DW_FORM_addrx
7183         (dump_die_shallow): Likewise
7184         (dwarf2_fetch_constant_bytes): Likewise
7185         (decode_locdesc): Add DW_OP_addrx
7186         (skip_form_bytes): Add DW_FORM_addrx
7187
7188 2019-04-22  Ali Tamur  <tamur@google.com>
7189
7190         * MAINTAINERS (Write After Approval): Add self.
7191
7192 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7193
7194         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7195         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7196         (open_symbol_file_object): Likewise.
7197         (svr4_default_sos): Add info parameter.
7198         (svr4_read_so_list): Likewise.
7199         (svr4_current_sos_direct): Adjust functions calls to pass down
7200         info.
7201         (svr4_current_sos_1): Add info parameter.
7202         (svr4_current_sos): Call get_svr4_info, pass info down to
7203         svr4_current_sos_1.
7204         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7205         get_svr4_info.
7206         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7207         get_svr4_info.
7208         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7209         to get_svr4_info.
7210         (probes_table_remove_objfile_probes): Likewise.
7211         (register_solib_event_probe): Add info parameter.
7212         (solist_update_incremental): Pass info parameter down to
7213         svr4_read_so_list.
7214         (disable_probes_interface): Add info parameter.
7215         (svr4_handle_solib_event): Pass current_program_space to
7216         get_svr4_info.  Adjust disable_probes_interface cleanup.
7217         (svr4_create_probe_breakpoints): Add info parameter, pass it
7218         down to register_solib_event_probe.
7219         (svr4_create_solib_event_breakpoints): Add info parameter,
7220         pass it down to svr4_create_probe_breakpoints.
7221         (enable_break): Pass info down to
7222         svr4_create_solib_event_breakpoints.
7223         (svr4_solib_create_inferior_hook): Pass current_program_space to
7224         get_svr4_info.
7225         (svr4_clear_solib): Likewise.
7226
7227 2019-04-22  Pedro Alves  <palves@redhat.com>
7228
7229         * solib-svr4.c (svr4_free_objfile_observer): New.
7230         (probe_and_action::objfile): New field.
7231         (probes_table_htab_remove_objfile_probes)
7232         (probes_table_remove_objfile_probes): New functions.
7233         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7234         in the new probe_and_action.  Don't store the probe in 'lookup'.
7235         (svr4_create_probe_breakpoints): Pass objfile to
7236         register_solib_event_probe.
7237         (_initialize_svr4_solib): Register a free_objfile observer.
7238
7239 2019-04-19  Tom Tromey  <tom@tromey.com>
7240
7241         * common/queue.h: Remove.
7242
7243 2019-04-19  Tom Tromey  <tom@tromey.com>
7244
7245         * event-loop.c: Don't include "common/queue.h".
7246
7247 2019-04-19  Tom Tromey  <tom@tromey.com>
7248
7249         * remote.c (remote_target): Use delete.
7250         * remote-notif.h: Include <list>, not "common/queue.h".
7251         (notif_client_p): Remove typedef.
7252         (remote_notif_state): Add constructor, destructor, initializer.
7253         <notif_queue>: Now a std::list.
7254         (remote_notif_state_xfree): Don't declare.
7255         * remote-notif.c (remote_notif_process, handle_notification)
7256         (remote_notif_state_allocate): Update.
7257         (~remote_notif_state): Rename from remote_notif_state_xfree.
7258
7259 2019-04-19  Tom Tromey  <tom@tromey.com>
7260
7261         * symfile.c (reread_symbols): Update.
7262         * objfiles.c (objfile_register_static_link)
7263         (objfile_lookup_static_link): Update
7264         (~objfile) Don't delete static_links.
7265         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7266
7267 2019-04-19  Tom Tromey  <tom@tromey.com>
7268
7269         * type-stack.h (struct type_stack) <insert>: Constify string.
7270         * type-stack.c (type_stack::insert): Constify string.
7271         * gdbtypes.h (lookup_template_type): Update.
7272         (address_space_name_to_int): Update.
7273         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7274         const.
7275         (lookup_template_type): Make name const.
7276         * c-exp.y: Update rules.
7277         (lex_one_token, classify_name, classify_inner_name)
7278         (c_print_token): Update.
7279         * p-exp.y: Update rules.
7280         (yylex): Update.
7281         * f-exp.y: Update rules.
7282         (yylex): Update.
7283         * d-exp.y: Update rules.
7284         (lex_one_token, classify_name, classify_inner_name): Update.
7285         * parse.c (write_dollar_variable, copy_name): Return std::string.
7286         * parser-defs.h (copy_name): Change return type.
7287         * m2-exp.y: Update rules.
7288         (yylex): Update.
7289         * go-exp.y (lex_one_token): Update.
7290         Update rules.
7291         (classify_unsafe_function, classify_packaged_name)
7292         (classify_name, yylex): Update.
7293
7294 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7295
7296         * configure.ac: add --enable-source-highlight switch.
7297         * configure: Regenerate.
7298         * top.c (print_gdb_version): plumb --enable-source-highlight
7299         status to "show configuration".
7300
7301 2019-04-19  Tom Tromey  <tromey@adacore.com>
7302
7303         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7304         Check ADA_TYPE_P.
7305         (empty_record, ada_template_to_fixed_record_type_1)
7306         (template_to_static_fixed_type)
7307         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7308         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7309         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7310         macros.
7311
7312 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7313
7314         PR symtab/24423:
7315         * source.c (print_source_lines_base): Advance "iter" when a
7316         control character is seen.
7317
7318 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7319
7320         * inferior.h (struct infcall_suspend_state_deleter):
7321         Catch exception in destructor to avoid crash.
7322
7323 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7324
7325         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7326         close to the add_com "shell".
7327
7328 2019-04-18  Tom Tromey  <tromey@adacore.com>
7329
7330         * process-stratum-target.h (class process_stratum_target)
7331         <stratum>: Add "final".
7332
7333 2019-04-17  Tom Tromey  <tromey@adacore.com>
7334
7335         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7336         against nullptr before use.
7337
7338 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7339
7340         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7341
7342 2019-04-17  Jim Wilson  <jimw@sifive.com>
7343             Andrew Burgess  <andrew.burgess@embecosm.com>
7344
7345         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7346         code read might fail, assume 4-byte breakpoint in that case.
7347
7348 2019-04-15  Leszek Swirski  <leszeks@google.com>
7349
7350         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7351         rather than a hand-rolled POD check when checking for forced MEMORY
7352         classification.
7353
7354 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7355
7356         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7357         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7358         function.
7359         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7360         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7361         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7362         declaration.
7363
7364 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7365
7366         * aarch64-linux-nat.c
7367         (aarch64_linux_nat_target::thread_architecture): Add override.
7368         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7369         each VQ.
7370
7371 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7372
7373         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7374
7375 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7376
7377         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7378         target types of size 96-bits, add some additional comments, and
7379         check that the builtin type we found was the correct size.
7380
7381 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7382
7383         * utils.c (prompt_for_continue): Don't restore the styling at the
7384         end, as applied_style has the wrong value.  This fixes styling in
7385         long lists of file names that are interrupted by the "Continue?"
7386         prompt.
7387
7388 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7389
7390         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7391         * c-lang.c (c_language_defn): Likewise.
7392         (cplus_language_defn): Likewise.
7393         (asm_language_defn): Likewise.
7394         (minimal_language_defn): Likewise.
7395         * d-lang.c (d_language_defn): Likewise.
7396         * f-lang.c (f_language_defn): Likewise.
7397         * go-lang.c (go_language_defn): Likewise.
7398         * language.c (unknown_language_defn): Likewise.
7399         (auto_language_defn): Likewise.
7400         * language.h (struct language_defn): Remove la_magic field.
7401         (LANG_MAGIC): Delete.
7402         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7403         * objc-lang.c (objc_language_defn): Likewise.
7404         * opencl-lang.c (opencl_language_defn): Likewise.
7405         * p-lang.c (pascal_language_defn): Likewise.
7406         * rust-lang.c (rust_language_defn): Likewise.
7407
7408 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7409
7410         * riscv-tdep.c (riscv_type_align): New function.
7411         (riscv_type_alignment): Delete.
7412         (riscv_arg_location): Use 'type_align'.
7413         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7414
7415 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7416
7417         * gdbtypes.c (type_align): A struct with no non-static fields also
7418         has alignment of 1.
7419
7420 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7421
7422         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7423         component to 0.
7424         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7425         member.
7426         (riscv_struct_info::analyse): New implementation using new
7427         analyse_inner member function.
7428         (riscv_struct_info::field_offset): New member function.
7429         (riscv_struct_info::m_offsets): New member variable.
7430         (riscv_struct_info::analyse_inner): New private member function,
7431         takes the old implementation of riscv_struct_info::analyse but
7432         extended to track field offsets.
7433         (riscv_call_arg_struct): Update the struct folding special cases
7434         to handle cases where empty C++ structs, which are non-zero
7435         length, are found.
7436         (riscv_arg_location): Initialise the length of each location, a
7437         non-zero length now indicates the location is in use.
7438         (riscv_push_dummy_call): Allow for the first location having a
7439         non-zero offset when setting up arguments.
7440         (riscv_return_value): Likewise, but for return values.
7441
7442 2019-04-11  Tom Tromey  <tromey@adacore.com>
7443
7444         * utils.c (internal_vproblem): Make "msg" const.
7445
7446 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7447
7448         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7449         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7450         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7451         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7452
7453 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7454
7455         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7456         function.
7457         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7458         of amd64_collect_native_gregset.
7459         (amd64_linux_nat_target::store_registers): Likewise.
7460
7461 2019-04-10  Tom Tromey  <tom@tromey.com>
7462
7463         * symtab.c (lookup_global_symbol_from_objfile)
7464         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7465         * objfiles.h (class separate_debug_iterator): New.
7466         (class separate_debug_range): New.
7467         (struct objfile) <separate_debug_objfiles>: New method.
7468         (objfile_separate_debug_iterate): Don't declare.
7469         * objfiles.c (separate_debug_iterator::operator++): Rename from
7470         objfile_separate_debug_iterate.
7471         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7472         iterator.
7473         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7474         iterator.
7475
7476 2019-04-10  Tom Tromey  <tom@tromey.com>
7477
7478         * symfile.c (reread_symbols): Remove old comment.
7479         * objfiles.c (free_all_objfiles): Fix a typo.
7480
7481 2019-04-10  Tom Tromey  <tom@tromey.com>
7482
7483         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7484         * minsyms.c (lookup_minimal_symbol): Use foreach.
7485         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7486         (lookup_minimal_symbol_solib_trampoline): Likewise.
7487         * symfile.c (reread_symbols): Use foreach.
7488
7489 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7490             Tom Tromey  <tromey@adacore.com>
7491
7492         PR rust/24414:
7493         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7494         (rust_lex_int_test): Change "value" to be LONGEST.
7495         (rust_lex_tests): Add test for long integer literal.
7496
7497 2019-04-09  Tom Tromey  <tromey@adacore.com>
7498
7499         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7500         to bool.
7501         (extended_remote_target::attach): Update.
7502         (remote_target::remote_notice_new_inferior): Update.
7503         (remote_target::add_current_inferior_and_thread): Update.
7504         * inferior.c (exit_inferior_1): Use "false".
7505         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7506
7507 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7508
7509         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7510         the "start" command.
7511
7512 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7513
7514         * python/py-inferior.c (infpy_thread_from_thread_handle):
7515         Adjust comments to reflect renaming of thread_from_thread_handle
7516         to thread_from_handle.  Adjust keywords.  Fix type error message.
7517         (inferior_object_methods): Add thread_from_handle.  Retain
7518         thread_from_thread_handle, but mark it as deprecated.
7519
7520 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7521
7522         * gdbthread.h (find_thread_by_handle): Revise declaration.
7523         * thread.c (find_thread_by_handle): Likewise.  Adjust
7524         implementation too.
7525         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7526         support for buffer objects as handles.
7527
7528 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7529
7530         * python/py-infthread.c (thpy_thread_handle): New function.
7531         (thread_object_methods): Register thpy_thread_handle.
7532
7533 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7534
7535         * gdbthread.h (thread_to_thread_handle): Declare.
7536         * thread.c (gdbtypes.h): Include.
7537         (thread_to_thread_handle): New function.
7538
7539         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7540         (target_thread_info_to_thread_handle): Declare.
7541         * target.c (target_thread_info_to_thread_handle): New function.
7542         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7543         * target-delegates.c: Regenerate.
7544
7545         * linux-thread-db.c (class thread_db_target): Add method
7546         thread_info_to_thread_handle.
7547         (thread_db_target::thread_info_to_thread_handle): Define.
7548         * remote.c (class remote_target): Add new method
7549         thread_info_to_thread_handle.
7550         (remote_target::thread_info_to_thread_handle): Define.
7551
7552 2019-04-08  Pedro Alves  <palves@redhat.com>
7553
7554         * common/common-exceptions.c (throw_exception): Don't create
7555         named object to throw; throw directly.
7556         (throw_it): Likewise.  Don't initialize gdb_exception::message
7557         here, with new; pass FMT and AP to the ctor instead.
7558         * common/common-exceptions.h: Include <string>.
7559         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7560         const char *, va_list)): New ctor.  Use std::make_shared.
7561         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7562         errors)): Delete.
7563         (gdb_exception_error::gdb_exception_error(enum errors, const char
7564         *, va_list)): New.
7565         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7566         Add assertion.
7567         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7568         errors)): Delete.
7569         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7570         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7571         Add assertion.
7572
7573 2019-04-08  Tom Tromey  <tom@tromey.com>
7574
7575         * valops.c (value_rtti_indirect_type): Replace throw_exception
7576         with throw.
7577         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7578         with throw.
7579         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7580         throw.
7581         * target.c (target_translate_tls_address): Replace throw_exception
7582         with throw.
7583         * stack.c (frame_apply_command_count): Replace throw_exception
7584         with throw.
7585         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7586         throw.
7587         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7588         with throw.
7589         * rs6000-tdep.c (rs6000_frame_cache)
7590         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7591         * remote.c: Replace throw_exception with throw.
7592         * record-full.c (record_full_message, record_full_wait_1)
7593         (record_full_restore): Replace throw_exception with throw.
7594         * record-btrace.c:
7595         (get_thread_current_frame_id, record_btrace_start_replaying)
7596         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7597         (cmd_record_btrace_start): Replace throw_exception with throw.
7598         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7599         throw.
7600         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7601         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7602         * linespec.c:
7603         (find_linespec_symbols): Replace throw_exception with throw.
7604         * infrun.c (displaced_step_prepare, resume): Replace
7605         throw_exception with throw.
7606         * infcmd.c (post_create_inferior): Replace throw_exception with
7607         throw.
7608         * inf-loop.c (inferior_event_handler): Replace throw_exception
7609         with throw.
7610         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7611         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7612         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7613         (get_prev_frame_always, get_frame_pc_if_available)
7614         (get_frame_address_in_block_if_available, get_frame_language):
7615         Replace throw_exception with throw.
7616         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7617         throw_exception with throw.
7618         * eval.c (fetch_subexp_value, evaluate_var_value)
7619         (evaluate_funcall, evaluate_subexp_standard): Replace
7620         throw_exception with throw.
7621         * dwarf2loc.c (call_site_find_chain)
7622         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7623         Replace throw_exception with throw.
7624         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7625         with throw.
7626         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7627         throw.
7628         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7629         * completer.c (complete_line_internal): Replace throw_exception
7630         with throw.
7631         * compile/compile-object-run.c (compile_object_run): Replace
7632         throw_exception with throw.
7633         * cli/cli-script.c (process_next_line): Replace throw_exception
7634         with throw.
7635         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7636         (btrace_enable, btrace_maint_update_pt_packets): Replace
7637         throw_exception with throw.
7638         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7639         throw_exception with throw.
7640         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7641         throw_exception with throw.
7642         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7643         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7644         * aarch64-tdep.c (aarch64_make_prologue_cache)
7645         (aarch64_make_stub_cache): Replace throw_exception with throw.
7646
7647 2019-04-08  Tom Tromey  <tom@tromey.com>
7648
7649         * common/common-exceptions.c (throw_exception): Rename from
7650         throw_exception_cxx.  Remove old copy.  Make argument const.
7651         (throw_it): Create and throw exception objects directly.
7652         * common/common-exceptions.h (throw_exception): Make argument
7653         const.
7654         (struct gdb_exception_error): Add constructor.
7655         (struct gdb_exception_quit): Add constructor.
7656
7657 2019-04-08  Tom Tromey  <tom@tromey.com>
7658
7659         * common/common-exceptions.h (exception_rethrow): Don't declare.
7660         (TRY_SJLJ): Update comment.
7661         (TRY, CATCH, END_CATCH): Remove.
7662         * common/common-exceptions.c (exception_rethrow): Remove.
7663
7664 2019-04-08  Tom Tromey  <tom@tromey.com>
7665
7666         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7667         Remove.
7668         (gdb_exception_error): Rename from
7669         gdb_exception_RETURN_MASK_ERROR.
7670         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7671         (gdb_quit_bad_alloc): Update.
7672         * aarch64-tdep.c: Update.
7673         * ada-lang.c: Update.
7674         * ada-typeprint.c: Update.
7675         * ada-valprint.c: Update.
7676         * amd64-tdep.c: Update.
7677         * arch-utils.c: Update.
7678         * break-catch-throw.c: Update.
7679         * breakpoint.c: Update.
7680         * btrace.c: Update.
7681         * c-varobj.c: Update.
7682         * cli/cli-cmds.c: Update.
7683         * cli/cli-interp.c: Update.
7684         * cli/cli-script.c: Update.
7685         * common/common-exceptions.c: Update.
7686         * common/new-op.c: Update.
7687         * common/selftest.c: Update.
7688         * compile/compile-c-symbols.c: Update.
7689         * compile/compile-cplus-symbols.c: Update.
7690         * compile/compile-object-load.c: Update.
7691         * compile/compile-object-run.c: Update.
7692         * completer.c: Update.
7693         * corelow.c: Update.
7694         * cp-abi.c: Update.
7695         * cp-support.c: Update.
7696         * cp-valprint.c: Update.
7697         * darwin-nat.c: Update.
7698         * disasm-selftests.c: Update.
7699         * dtrace-probe.c: Update.
7700         * dwarf-index-cache.c: Update.
7701         * dwarf-index-write.c: Update.
7702         * dwarf2-frame-tailcall.c: Update.
7703         * dwarf2-frame.c: Update.
7704         * dwarf2loc.c: Update.
7705         * dwarf2read.c: Update.
7706         * eval.c: Update.
7707         * event-loop.c: Update.
7708         * event-top.c: Update.
7709         * exec.c: Update.
7710         * f-valprint.c: Update.
7711         * fbsd-tdep.c: Update.
7712         * frame-unwind.c: Update.
7713         * frame.c: Update.
7714         * gdbtypes.c: Update.
7715         * gnu-v3-abi.c: Update.
7716         * guile/guile-internal.h: Update.
7717         * guile/scm-block.c: Update.
7718         * guile/scm-breakpoint.c: Update.
7719         * guile/scm-cmd.c: Update.
7720         * guile/scm-disasm.c: Update.
7721         * guile/scm-frame.c: Update.
7722         * guile/scm-lazy-string.c: Update.
7723         * guile/scm-math.c: Update.
7724         * guile/scm-param.c: Update.
7725         * guile/scm-ports.c: Update.
7726         * guile/scm-pretty-print.c: Update.
7727         * guile/scm-symbol.c: Update.
7728         * guile/scm-symtab.c: Update.
7729         * guile/scm-type.c: Update.
7730         * guile/scm-value.c: Update.
7731         * i386-linux-tdep.c: Update.
7732         * i386-tdep.c: Update.
7733         * inf-loop.c: Update.
7734         * infcall.c: Update.
7735         * infcmd.c: Update.
7736         * infrun.c: Update.
7737         * jit.c: Update.
7738         * language.c: Update.
7739         * linespec.c: Update.
7740         * linux-fork.c: Update.
7741         * linux-nat.c: Update.
7742         * linux-tdep.c: Update.
7743         * linux-thread-db.c: Update.
7744         * main.c: Update.
7745         * mi/mi-cmd-break.c: Update.
7746         * mi/mi-cmd-stack.c: Update.
7747         * mi/mi-interp.c: Update.
7748         * mi/mi-main.c: Update.
7749         * objc-lang.c: Update.
7750         * p-valprint.c: Update.
7751         * parse.c: Update.
7752         * ppc-linux-tdep.c: Update.
7753         * printcmd.c: Update.
7754         * python/py-arch.c: Update.
7755         * python/py-breakpoint.c: Update.
7756         * python/py-cmd.c: Update.
7757         * python/py-finishbreakpoint.c: Update.
7758         * python/py-frame.c: Update.
7759         * python/py-framefilter.c: Update.
7760         * python/py-gdb-readline.c: Update.
7761         * python/py-inferior.c: Update.
7762         * python/py-infthread.c: Update.
7763         * python/py-lazy-string.c: Update.
7764         * python/py-linetable.c: Update.
7765         * python/py-objfile.c: Update.
7766         * python/py-param.c: Update.
7767         * python/py-prettyprint.c: Update.
7768         * python/py-progspace.c: Update.
7769         * python/py-record-btrace.c: Update.
7770         * python/py-record.c: Update.
7771         * python/py-symbol.c: Update.
7772         * python/py-type.c: Update.
7773         * python/py-unwind.c: Update.
7774         * python/py-utils.c: Update.
7775         * python/py-value.c: Update.
7776         * python/python.c: Update.
7777         * record-btrace.c: Update.
7778         * record-full.c: Update.
7779         * remote-fileio.c: Update.
7780         * remote.c: Update.
7781         * riscv-tdep.c: Update.
7782         * rs6000-aix-tdep.c: Update.
7783         * rs6000-tdep.c: Update.
7784         * rust-exp.y: Update.
7785         * rust-lang.c: Update.
7786         * s390-tdep.c: Update.
7787         * selftest-arch.c: Update.
7788         * solib-dsbt.c: Update.
7789         * solib-frv.c: Update.
7790         * solib-spu.c: Update.
7791         * solib-svr4.c: Update.
7792         * solib.c: Update.
7793         * sparc64-linux-tdep.c: Update.
7794         * stack.c: Update.
7795         * symfile-mem.c: Update.
7796         * symmisc.c: Update.
7797         * target.c: Update.
7798         * thread.c: Update.
7799         * top.c: Update.
7800         * tracefile-tfile.c: Update.
7801         * tui/tui.c: Update.
7802         * typeprint.c: Update.
7803         * unittests/cli-utils-selftests.c: Update.
7804         * unittests/parse-connection-spec-selftests.c: Update.
7805         * valops.c: Update.
7806         * valprint.c: Update.
7807         * value.c: Update.
7808         * varobj.c: Update.
7809         * windows-nat.c: Update.
7810         * x86-linux-nat.c: Update.
7811         * xml-support.c: Update.
7812
7813 2019-04-08  Tom Tromey  <tom@tromey.com>
7814
7815         * xml-support.c: Use C++ exception handling.
7816         * x86-linux-nat.c: Use C++ exception handling.
7817         * windows-nat.c: Use C++ exception handling.
7818         * varobj.c: Use C++ exception handling.
7819         * value.c: Use C++ exception handling.
7820         * valprint.c: Use C++ exception handling.
7821         * valops.c: Use C++ exception handling.
7822         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7823         handling.
7824         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7825         * typeprint.c: Use C++ exception handling.
7826         * tui/tui.c: Use C++ exception handling.
7827         * tracefile-tfile.c: Use C++ exception handling.
7828         * top.c: Use C++ exception handling.
7829         * thread.c: Use C++ exception handling.
7830         * target.c: Use C++ exception handling.
7831         * symmisc.c: Use C++ exception handling.
7832         * symfile-mem.c: Use C++ exception handling.
7833         * stack.c: Use C++ exception handling.
7834         * sparc64-linux-tdep.c: Use C++ exception handling.
7835         * solib.c: Use C++ exception handling.
7836         * solib-svr4.c: Use C++ exception handling.
7837         * solib-spu.c: Use C++ exception handling.
7838         * solib-frv.c: Use C++ exception handling.
7839         * solib-dsbt.c: Use C++ exception handling.
7840         * selftest-arch.c: Use C++ exception handling.
7841         * s390-tdep.c: Use C++ exception handling.
7842         * rust-lang.c: Use C++ exception handling.
7843         * rust-exp.y: Use C++ exception handling.
7844         * rs6000-tdep.c: Use C++ exception handling.
7845         * rs6000-aix-tdep.c: Use C++ exception handling.
7846         * riscv-tdep.c: Use C++ exception handling.
7847         * remote.c: Use C++ exception handling.
7848         * remote-fileio.c: Use C++ exception handling.
7849         * record-full.c: Use C++ exception handling.
7850         * record-btrace.c: Use C++ exception handling.
7851         * python/python.c: Use C++ exception handling.
7852         * python/py-value.c: Use C++ exception handling.
7853         * python/py-utils.c: Use C++ exception handling.
7854         * python/py-unwind.c: Use C++ exception handling.
7855         * python/py-type.c: Use C++ exception handling.
7856         * python/py-symbol.c: Use C++ exception handling.
7857         * python/py-record.c: Use C++ exception handling.
7858         * python/py-record-btrace.c: Use C++ exception handling.
7859         * python/py-progspace.c: Use C++ exception handling.
7860         * python/py-prettyprint.c: Use C++ exception handling.
7861         * python/py-param.c: Use C++ exception handling.
7862         * python/py-objfile.c: Use C++ exception handling.
7863         * python/py-linetable.c: Use C++ exception handling.
7864         * python/py-lazy-string.c: Use C++ exception handling.
7865         * python/py-infthread.c: Use C++ exception handling.
7866         * python/py-inferior.c: Use C++ exception handling.
7867         * python/py-gdb-readline.c: Use C++ exception handling.
7868         * python/py-framefilter.c: Use C++ exception handling.
7869         * python/py-frame.c: Use C++ exception handling.
7870         * python/py-finishbreakpoint.c: Use C++ exception handling.
7871         * python/py-cmd.c: Use C++ exception handling.
7872         * python/py-breakpoint.c: Use C++ exception handling.
7873         * python/py-arch.c: Use C++ exception handling.
7874         * printcmd.c: Use C++ exception handling.
7875         * ppc-linux-tdep.c: Use C++ exception handling.
7876         * parse.c: Use C++ exception handling.
7877         * p-valprint.c: Use C++ exception handling.
7878         * objc-lang.c: Use C++ exception handling.
7879         * mi/mi-main.c: Use C++ exception handling.
7880         * mi/mi-interp.c: Use C++ exception handling.
7881         * mi/mi-cmd-stack.c: Use C++ exception handling.
7882         * mi/mi-cmd-break.c: Use C++ exception handling.
7883         * main.c: Use C++ exception handling.
7884         * linux-thread-db.c: Use C++ exception handling.
7885         * linux-tdep.c: Use C++ exception handling.
7886         * linux-nat.c: Use C++ exception handling.
7887         * linux-fork.c: Use C++ exception handling.
7888         * linespec.c: Use C++ exception handling.
7889         * language.c: Use C++ exception handling.
7890         * jit.c: Use C++ exception handling.
7891         * infrun.c: Use C++ exception handling.
7892         * infcmd.c: Use C++ exception handling.
7893         * infcall.c: Use C++ exception handling.
7894         * inf-loop.c: Use C++ exception handling.
7895         * i386-tdep.c: Use C++ exception handling.
7896         * i386-linux-tdep.c: Use C++ exception handling.
7897         * guile/scm-value.c: Use C++ exception handling.
7898         * guile/scm-type.c: Use C++ exception handling.
7899         * guile/scm-symtab.c: Use C++ exception handling.
7900         * guile/scm-symbol.c: Use C++ exception handling.
7901         * guile/scm-pretty-print.c: Use C++ exception handling.
7902         * guile/scm-ports.c: Use C++ exception handling.
7903         * guile/scm-param.c: Use C++ exception handling.
7904         * guile/scm-math.c: Use C++ exception handling.
7905         * guile/scm-lazy-string.c: Use C++ exception handling.
7906         * guile/scm-frame.c: Use C++ exception handling.
7907         * guile/scm-disasm.c: Use C++ exception handling.
7908         * guile/scm-cmd.c: Use C++ exception handling.
7909         * guile/scm-breakpoint.c: Use C++ exception handling.
7910         * guile/scm-block.c: Use C++ exception handling.
7911         * guile/guile-internal.h: Use C++ exception handling.
7912         * gnu-v3-abi.c: Use C++ exception handling.
7913         * gdbtypes.c: Use C++ exception handling.
7914         * frame.c: Use C++ exception handling.
7915         * frame-unwind.c: Use C++ exception handling.
7916         * fbsd-tdep.c: Use C++ exception handling.
7917         * f-valprint.c: Use C++ exception handling.
7918         * exec.c: Use C++ exception handling.
7919         * event-top.c: Use C++ exception handling.
7920         * event-loop.c: Use C++ exception handling.
7921         * eval.c: Use C++ exception handling.
7922         * dwarf2read.c: Use C++ exception handling.
7923         * dwarf2loc.c: Use C++ exception handling.
7924         * dwarf2-frame.c: Use C++ exception handling.
7925         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7926         * dwarf-index-write.c: Use C++ exception handling.
7927         * dwarf-index-cache.c: Use C++ exception handling.
7928         * dtrace-probe.c: Use C++ exception handling.
7929         * disasm-selftests.c: Use C++ exception handling.
7930         * darwin-nat.c: Use C++ exception handling.
7931         * cp-valprint.c: Use C++ exception handling.
7932         * cp-support.c: Use C++ exception handling.
7933         * cp-abi.c: Use C++ exception handling.
7934         * corelow.c: Use C++ exception handling.
7935         * completer.c: Use C++ exception handling.
7936         * compile/compile-object-run.c: Use C++ exception handling.
7937         * compile/compile-object-load.c: Use C++ exception handling.
7938         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7939         * compile/compile-c-symbols.c: Use C++ exception handling.
7940         * common/selftest.c: Use C++ exception handling.
7941         * common/new-op.c: Use C++ exception handling.
7942         * cli/cli-script.c: Use C++ exception handling.
7943         * cli/cli-interp.c: Use C++ exception handling.
7944         * cli/cli-cmds.c: Use C++ exception handling.
7945         * c-varobj.c: Use C++ exception handling.
7946         * btrace.c: Use C++ exception handling.
7947         * breakpoint.c: Use C++ exception handling.
7948         * break-catch-throw.c: Use C++ exception handling.
7949         * arch-utils.c: Use C++ exception handling.
7950         * amd64-tdep.c: Use C++ exception handling.
7951         * ada-valprint.c: Use C++ exception handling.
7952         * ada-typeprint.c: Use C++ exception handling.
7953         * ada-lang.c: Use C++ exception handling.
7954         * aarch64-tdep.c: Use C++ exception handling.
7955
7956 2019-04-08  Tom Tromey  <tom@tromey.com>
7957
7958         * xml-support.c (gdb_xml_parser::parse): Update.
7959         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7960         * value.c (show_convenience): Update.
7961         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7962         (test_parse_flags_qcs): Update.
7963         * thread.c (thr_try_catch_cmd): Update.
7964         * target.c (target_translate_tls_address): Update.
7965         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7966         (info_frame_command_core, frame_apply_command_count): Update.
7967         * rust-exp.y (rust_lex_exception_test): Update.
7968         * riscv-tdep.c (riscv_print_one_register_info): Update.
7969         * remote.c (remote_target::enable_btrace): Update.
7970         * record-btrace.c (record_btrace_enable_warn): Update.
7971         * python/py-utils.c (gdbpy_convert_exception): Update.
7972         * printcmd.c (do_one_display, print_variable_and_value): Update.
7973         * mi/mi-main.c (mi_print_exception): Update.
7974         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7975         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7976         * linux-nat.c (linux_nat_target::attach): Update.
7977         * linux-fork.c (class scoped_switch_fork_info): Update.
7978         * infrun.c (displaced_step_prepare): Update.
7979         * infcall.c (call_function_by_hand_dummy): Update.
7980         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7981         * gnu-v3-abi.c (print_one_vtable): Update.
7982         * frame.c (get_prev_frame_always): Update.
7983         * f-valprint.c (info_common_command_for_block): Update.
7984         * exec.c (try_open_exec_file): Update.
7985         * exceptions.c (print_exception, exception_print)
7986         (exception_fprintf, exception_print_same): Update.
7987         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7988         * dwarf-index-cache.c (index_cache::store)
7989         (index_cache::lookup_gdb_index): Update.
7990         * darwin-nat.c (maybe_cache_shell): Update.
7991         * cp-valprint.c (cp_print_value_fields): Update.
7992         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7993         (gcc_cplus_symbol_address): Update.
7994         * compile/compile-c-symbols.c (gcc_convert_symbol)
7995         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7996         * common/selftest.c: Update.
7997         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7998         a std::string.
7999         (exception_try_scope_entry, exception_try_scope_exit): Don't
8000         declare.
8001         (struct exception_try_scope): Remove.
8002         (TRY): Don't use exception_try_scope.
8003         (struct gdb_exception): Add constructor, operator=.
8004         <what>: New method.
8005         (struct gdb_exception_RETURN_MASK_ALL)
8006         (struct gdb_exception_RETURN_MASK_ERROR)
8007         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8008         (struct gdb_quit_bad_alloc): Update.
8009         * common/common-exceptions.c (exception_none): Change
8010         initializer.
8011         (struct catcher) <state, exception>: Initialize inline.
8012         <prev>: Remove member.
8013         (current_catcher): Remove.
8014         (catchers): New global.
8015         (exceptions_state_mc_init): Simplify.
8016         (catcher_pop): Remove.
8017         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8018         (try_scope_depth, exception_try_scope_entry)
8019         (exception_try_scope_exit): Remove.
8020         (throw_exception_sjlj): Update.
8021         (exception_messages, exception_messages_size): Remove.
8022         (throw_it): Simplify.
8023         (gdb_exception_sliced_copy): Remove.
8024         (throw_exception_cxx): Update.
8025         * cli/cli-script.c (script_from_file): Update.
8026         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8027         Update.
8028         * ada-valprint.c (ada_val_print): Update.
8029         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8030         (create_excep_cond_exprs): Update.
8031
8032 2019-04-08  Tom Tromey  <tom@tromey.com>
8033
8034         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8035         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8036         (TRY, CATCH, END_CATCH): Remove some definitions.
8037         * common/common-exceptions.c: Don't use GDB_XCPT.
8038         (catcher_list_size): Remove.
8039         (throw_exception, throw_it): Simplify.
8040
8041 2019-04-05  Tom Tromey  <tom@tromey.com>
8042
8043         Revert the header-sorting patch.
8044         * ft32-tdep.c: Revert.
8045         * frv-tdep.c: Revert.
8046         * frv-linux-tdep.c: Revert.
8047         * frame.c: Revert.
8048         * frame-unwind.c: Revert.
8049         * frame-base.c: Revert.
8050         * fork-child.c: Revert.
8051         * findvar.c: Revert.
8052         * findcmd.c: Revert.
8053         * filesystem.c: Revert.
8054         * filename-seen-cache.h: Revert.
8055         * filename-seen-cache.c: Revert.
8056         * fbsd-tdep.c: Revert.
8057         * fbsd-nat.h: Revert.
8058         * fbsd-nat.c: Revert.
8059         * f-valprint.c: Revert.
8060         * f-typeprint.c: Revert.
8061         * f-lang.c: Revert.
8062         * extension.h: Revert.
8063         * extension.c: Revert.
8064         * extension-priv.h: Revert.
8065         * expprint.c: Revert.
8066         * exec.h: Revert.
8067         * exec.c: Revert.
8068         * exceptions.c: Revert.
8069         * event-top.c: Revert.
8070         * event-loop.c: Revert.
8071         * eval.c: Revert.
8072         * elfread.c: Revert.
8073         * dwarf2read.h: Revert.
8074         * dwarf2read.c: Revert.
8075         * dwarf2loc.c: Revert.
8076         * dwarf2expr.h: Revert.
8077         * dwarf2expr.c: Revert.
8078         * dwarf2-frame.c: Revert.
8079         * dwarf2-frame-tailcall.c: Revert.
8080         * dwarf-index-write.h: Revert.
8081         * dwarf-index-write.c: Revert.
8082         * dwarf-index-common.c: Revert.
8083         * dwarf-index-cache.h: Revert.
8084         * dwarf-index-cache.c: Revert.
8085         * dummy-frame.c: Revert.
8086         * dtrace-probe.c: Revert.
8087         * disasm.h: Revert.
8088         * disasm.c: Revert.
8089         * disasm-selftests.c: Revert.
8090         * dictionary.c: Revert.
8091         * dicos-tdep.c: Revert.
8092         * demangle.c: Revert.
8093         * dcache.h: Revert.
8094         * dcache.c: Revert.
8095         * darwin-nat.h: Revert.
8096         * darwin-nat.c: Revert.
8097         * darwin-nat-info.c: Revert.
8098         * d-valprint.c: Revert.
8099         * d-namespace.c: Revert.
8100         * d-lang.c: Revert.
8101         * ctf.c: Revert.
8102         * csky-tdep.c: Revert.
8103         * csky-linux-tdep.c: Revert.
8104         * cris-tdep.c: Revert.
8105         * cris-linux-tdep.c: Revert.
8106         * cp-valprint.c: Revert.
8107         * cp-support.c: Revert.
8108         * cp-namespace.c: Revert.
8109         * cp-abi.c: Revert.
8110         * corelow.c: Revert.
8111         * corefile.c: Revert.
8112         * continuations.c: Revert.
8113         * completer.h: Revert.
8114         * completer.c: Revert.
8115         * complaints.c: Revert.
8116         * coffread.c: Revert.
8117         * coff-pe-read.c: Revert.
8118         * cli-out.h: Revert.
8119         * cli-out.c: Revert.
8120         * charset.c: Revert.
8121         * c-varobj.c: Revert.
8122         * c-valprint.c: Revert.
8123         * c-typeprint.c: Revert.
8124         * c-lang.c: Revert.
8125         * buildsym.c: Revert.
8126         * buildsym-legacy.c: Revert.
8127         * build-id.h: Revert.
8128         * build-id.c: Revert.
8129         * btrace.c: Revert.
8130         * bsd-uthread.c: Revert.
8131         * breakpoint.h: Revert.
8132         * breakpoint.c: Revert.
8133         * break-catch-throw.c: Revert.
8134         * break-catch-syscall.c: Revert.
8135         * break-catch-sig.c: Revert.
8136         * blockframe.c: Revert.
8137         * block.c: Revert.
8138         * bfin-tdep.c: Revert.
8139         * bfin-linux-tdep.c: Revert.
8140         * bfd-target.c: Revert.
8141         * bcache.c: Revert.
8142         * ax-general.c: Revert.
8143         * ax-gdb.h: Revert.
8144         * ax-gdb.c: Revert.
8145         * avr-tdep.c: Revert.
8146         * auxv.c: Revert.
8147         * auto-load.c: Revert.
8148         * arm-wince-tdep.c: Revert.
8149         * arm-tdep.c: Revert.
8150         * arm-symbian-tdep.c: Revert.
8151         * arm-pikeos-tdep.c: Revert.
8152         * arm-obsd-tdep.c: Revert.
8153         * arm-nbsd-tdep.c: Revert.
8154         * arm-nbsd-nat.c: Revert.
8155         * arm-linux-tdep.c: Revert.
8156         * arm-linux-nat.c: Revert.
8157         * arm-fbsd-tdep.c: Revert.
8158         * arm-fbsd-nat.c: Revert.
8159         * arm-bsd-tdep.c: Revert.
8160         * arch-utils.c: Revert.
8161         * arc-tdep.c: Revert.
8162         * arc-newlib-tdep.c: Revert.
8163         * annotate.h: Revert.
8164         * annotate.c: Revert.
8165         * amd64-windows-tdep.c: Revert.
8166         * amd64-windows-nat.c: Revert.
8167         * amd64-tdep.c: Revert.
8168         * amd64-sol2-tdep.c: Revert.
8169         * amd64-obsd-tdep.c: Revert.
8170         * amd64-obsd-nat.c: Revert.
8171         * amd64-nbsd-tdep.c: Revert.
8172         * amd64-nbsd-nat.c: Revert.
8173         * amd64-nat.c: Revert.
8174         * amd64-linux-tdep.c: Revert.
8175         * amd64-linux-nat.c: Revert.
8176         * amd64-fbsd-tdep.c: Revert.
8177         * amd64-fbsd-nat.c: Revert.
8178         * amd64-dicos-tdep.c: Revert.
8179         * amd64-darwin-tdep.c: Revert.
8180         * amd64-bsd-nat.c: Revert.
8181         * alpha-tdep.c: Revert.
8182         * alpha-obsd-tdep.c: Revert.
8183         * alpha-nbsd-tdep.c: Revert.
8184         * alpha-mdebug-tdep.c: Revert.
8185         * alpha-linux-tdep.c: Revert.
8186         * alpha-linux-nat.c: Revert.
8187         * alpha-bsd-tdep.c: Revert.
8188         * alpha-bsd-nat.c: Revert.
8189         * aix-thread.c: Revert.
8190         * agent.c: Revert.
8191         * addrmap.c: Revert.
8192         * ada-varobj.c: Revert.
8193         * ada-valprint.c: Revert.
8194         * ada-typeprint.c: Revert.
8195         * ada-tasks.c: Revert.
8196         * ada-lang.c: Revert.
8197         * aarch64-tdep.c: Revert.
8198         * aarch64-ravenscar-thread.c: Revert.
8199         * aarch64-newlib-tdep.c: Revert.
8200         * aarch64-linux-tdep.c: Revert.
8201         * aarch64-linux-nat.c: Revert.
8202         * aarch64-fbsd-tdep.c: Revert.
8203         * aarch64-fbsd-nat.c: Revert.
8204         * aarch32-linux-nat.c: Revert.
8205
8206 2019-04-05  Tom Tromey  <tom@tromey.com>
8207
8208         * ft32-tdep.c: Sort headers.
8209         * frv-tdep.c: Sort headers.
8210         * frv-linux-tdep.c: Sort headers.
8211         * frame.c: Sort headers.
8212         * frame-unwind.c: Sort headers.
8213         * frame-base.c: Sort headers.
8214         * fork-child.c: Sort headers.
8215         * findvar.c: Sort headers.
8216         * findcmd.c: Sort headers.
8217         * filesystem.c: Sort headers.
8218         * filename-seen-cache.h: Sort headers.
8219         * filename-seen-cache.c: Sort headers.
8220         * fbsd-tdep.c: Sort headers.
8221         * fbsd-nat.h: Sort headers.
8222         * fbsd-nat.c: Sort headers.
8223         * f-valprint.c: Sort headers.
8224         * f-typeprint.c: Sort headers.
8225         * f-lang.c: Sort headers.
8226         * extension.h: Sort headers.
8227         * extension.c: Sort headers.
8228         * extension-priv.h: Sort headers.
8229         * expprint.c: Sort headers.
8230         * exec.h: Sort headers.
8231         * exec.c: Sort headers.
8232         * exceptions.c: Sort headers.
8233         * event-top.c: Sort headers.
8234         * event-loop.c: Sort headers.
8235         * eval.c: Sort headers.
8236         * elfread.c: Sort headers.
8237         * dwarf2read.h: Sort headers.
8238         * dwarf2read.c: Sort headers.
8239         * dwarf2loc.c: Sort headers.
8240         * dwarf2expr.h: Sort headers.
8241         * dwarf2expr.c: Sort headers.
8242         * dwarf2-frame.c: Sort headers.
8243         * dwarf2-frame-tailcall.c: Sort headers.
8244         * dwarf-index-write.h: Sort headers.
8245         * dwarf-index-write.c: Sort headers.
8246         * dwarf-index-common.c: Sort headers.
8247         * dwarf-index-cache.h: Sort headers.
8248         * dwarf-index-cache.c: Sort headers.
8249         * dummy-frame.c: Sort headers.
8250         * dtrace-probe.c: Sort headers.
8251         * disasm.h: Sort headers.
8252         * disasm.c: Sort headers.
8253         * disasm-selftests.c: Sort headers.
8254         * dictionary.c: Sort headers.
8255         * dicos-tdep.c: Sort headers.
8256         * demangle.c: Sort headers.
8257         * dcache.h: Sort headers.
8258         * dcache.c: Sort headers.
8259         * darwin-nat.h: Sort headers.
8260         * darwin-nat.c: Sort headers.
8261         * darwin-nat-info.c: Sort headers.
8262         * d-valprint.c: Sort headers.
8263         * d-namespace.c: Sort headers.
8264         * d-lang.c: Sort headers.
8265         * ctf.c: Sort headers.
8266         * csky-tdep.c: Sort headers.
8267         * csky-linux-tdep.c: Sort headers.
8268         * cris-tdep.c: Sort headers.
8269         * cris-linux-tdep.c: Sort headers.
8270         * cp-valprint.c: Sort headers.
8271         * cp-support.c: Sort headers.
8272         * cp-namespace.c: Sort headers.
8273         * cp-abi.c: Sort headers.
8274         * corelow.c: Sort headers.
8275         * corefile.c: Sort headers.
8276         * continuations.c: Sort headers.
8277         * completer.h: Sort headers.
8278         * completer.c: Sort headers.
8279         * complaints.c: Sort headers.
8280         * coffread.c: Sort headers.
8281         * coff-pe-read.c: Sort headers.
8282         * cli-out.h: Sort headers.
8283         * cli-out.c: Sort headers.
8284         * charset.c: Sort headers.
8285         * c-varobj.c: Sort headers.
8286         * c-valprint.c: Sort headers.
8287         * c-typeprint.c: Sort headers.
8288         * c-lang.c: Sort headers.
8289         * buildsym.c: Sort headers.
8290         * buildsym-legacy.c: Sort headers.
8291         * build-id.h: Sort headers.
8292         * build-id.c: Sort headers.
8293         * btrace.c: Sort headers.
8294         * bsd-uthread.c: Sort headers.
8295         * breakpoint.h: Sort headers.
8296         * breakpoint.c: Sort headers.
8297         * break-catch-throw.c: Sort headers.
8298         * break-catch-syscall.c: Sort headers.
8299         * break-catch-sig.c: Sort headers.
8300         * blockframe.c: Sort headers.
8301         * block.c: Sort headers.
8302         * bfin-tdep.c: Sort headers.
8303         * bfin-linux-tdep.c: Sort headers.
8304         * bfd-target.c: Sort headers.
8305         * bcache.c: Sort headers.
8306         * ax-general.c: Sort headers.
8307         * ax-gdb.h: Sort headers.
8308         * ax-gdb.c: Sort headers.
8309         * avr-tdep.c: Sort headers.
8310         * auxv.c: Sort headers.
8311         * auto-load.c: Sort headers.
8312         * arm-wince-tdep.c: Sort headers.
8313         * arm-tdep.c: Sort headers.
8314         * arm-symbian-tdep.c: Sort headers.
8315         * arm-pikeos-tdep.c: Sort headers.
8316         * arm-obsd-tdep.c: Sort headers.
8317         * arm-nbsd-tdep.c: Sort headers.
8318         * arm-nbsd-nat.c: Sort headers.
8319         * arm-linux-tdep.c: Sort headers.
8320         * arm-linux-nat.c: Sort headers.
8321         * arm-fbsd-tdep.c: Sort headers.
8322         * arm-fbsd-nat.c: Sort headers.
8323         * arm-bsd-tdep.c: Sort headers.
8324         * arch-utils.c: Sort headers.
8325         * arc-tdep.c: Sort headers.
8326         * arc-newlib-tdep.c: Sort headers.
8327         * annotate.h: Sort headers.
8328         * annotate.c: Sort headers.
8329         * amd64-windows-tdep.c: Sort headers.
8330         * amd64-windows-nat.c: Sort headers.
8331         * amd64-tdep.c: Sort headers.
8332         * amd64-sol2-tdep.c: Sort headers.
8333         * amd64-obsd-tdep.c: Sort headers.
8334         * amd64-obsd-nat.c: Sort headers.
8335         * amd64-nbsd-tdep.c: Sort headers.
8336         * amd64-nbsd-nat.c: Sort headers.
8337         * amd64-nat.c: Sort headers.
8338         * amd64-linux-tdep.c: Sort headers.
8339         * amd64-linux-nat.c: Sort headers.
8340         * amd64-fbsd-tdep.c: Sort headers.
8341         * amd64-fbsd-nat.c: Sort headers.
8342         * amd64-dicos-tdep.c: Sort headers.
8343         * amd64-darwin-tdep.c: Sort headers.
8344         * amd64-bsd-nat.c: Sort headers.
8345         * alpha-tdep.c: Sort headers.
8346         * alpha-obsd-tdep.c: Sort headers.
8347         * alpha-nbsd-tdep.c: Sort headers.
8348         * alpha-mdebug-tdep.c: Sort headers.
8349         * alpha-linux-tdep.c: Sort headers.
8350         * alpha-linux-nat.c: Sort headers.
8351         * alpha-bsd-tdep.c: Sort headers.
8352         * alpha-bsd-nat.c: Sort headers.
8353         * aix-thread.c: Sort headers.
8354         * agent.c: Sort headers.
8355         * addrmap.c: Sort headers.
8356         * ada-varobj.c: Sort headers.
8357         * ada-valprint.c: Sort headers.
8358         * ada-typeprint.c: Sort headers.
8359         * ada-tasks.c: Sort headers.
8360         * ada-lang.c: Sort headers.
8361         * aarch64-tdep.c: Sort headers.
8362         * aarch64-ravenscar-thread.c: Sort headers.
8363         * aarch64-newlib-tdep.c: Sort headers.
8364         * aarch64-linux-tdep.c: Sort headers.
8365         * aarch64-linux-nat.c: Sort headers.
8366         * aarch64-fbsd-tdep.c: Sort headers.
8367         * aarch64-fbsd-nat.c: Sort headers.
8368         * aarch32-linux-nat.c: Sort headers.
8369
8370 2019-04-04  Tom Tromey  <tom@tromey.com>
8371
8372         * varobj.c (varobj_create): Update.
8373         * rust-exp.y (struct rust_parser) <update_innermost_block,
8374         lookup_symbol>: New methods.
8375         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8376         Rename.
8377         (rust_parser::rust_lookup_type)
8378         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8379         * printcmd.c (display_command, do_one_display): Update.
8380         * parser-defs.h (struct parser_state) <parser_state>: Add
8381         "tracker" parameter.
8382         (block_tracker): New member.
8383         (class innermost_block_tracker) <innermost_block_tracker>: Add
8384         "types" parameter.
8385         <reset>: Remove method.
8386         (innermost_block): Don't declare.
8387         (null_post_parser): Update.
8388         * parse.c (innermost_block): Remove global.
8389         (write_dollar_variable): Update.
8390         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8391         Remove "tracker_types" parameter.
8392         (parse_expression): Add "tracker" parameter.
8393         (parse_expression_for_completion): Update.
8394         (null_post_parser): Add "tracker" parameter.
8395         * p-exp.y: Update rules.
8396         * m2-exp.y: Update rules.
8397         * language.h (struct language_defn) <la_post_parser>: Add
8398         "tracker" parameter.
8399         * go-exp.y: Update rules.
8400         * f-exp.y: Update rules.
8401         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8402         parameter.
8403         * d-exp.y: Update rules.
8404         * c-exp.y: Update rules.
8405         * breakpoint.c (set_breakpoint_condition): Create an
8406         innermost_block_tracker.
8407         (watch_command_1): Likewise.
8408         * ada-lang.c (resolve): Add "tracker" parameter.
8409         (resolve_subexp): Likewise.
8410         * ada-exp.y (write_var_from_sym): Update.
8411
8412 2019-04-04  Tom Tromey  <tom@tromey.com>
8413
8414         * type-stack.h: New file.
8415         * type-stack.c: New file.
8416         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8417         type-stack.h.
8418         (insert_into_type_stack, insert_type, push_type, push_type_int)
8419         (insert_type_address_space, pop_type, pop_type_int)
8420         (pop_typelist, pop_type_stack, append_type_stack)
8421         (push_type_stack, get_type_stack, push_typelist)
8422         (follow_type_instance_flags, follow_types): Don't declare.
8423         * parse.c (type_stack): Remove global.
8424         (parse_exp_in_context): Update.
8425         (insert_into_type_stack, insert_type, push_type, push_type_int)
8426         (insert_type_address_space, pop_type, pop_type_int)
8427         (pop_typelist, pop_type_stack, append_type_stack)
8428         (push_type_stack, get_type_stack, push_typelist)
8429         (follow_type_instance_flags, follow_types): Remove (moved to
8430         type-stack.c).
8431         * f-exp.y (type_stack): New global.
8432         Update rules.
8433         (push_kind_type, f_parse): Update.
8434         * d-exp.y (type_stack): New global.
8435         Update rules.
8436         (d_parse): Update.
8437         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8438         Update rules.
8439         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8440         (HFILES_NO_SRCDIR): Add type-stack.h.
8441
8442 2019-04-04  Tom Tromey  <tom@tromey.com>
8443
8444         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8445         (rust_parser::convert_ast_to_expression, rust_parse)
8446         (rust_lex_test_completion, rust_lex_tests): Update.
8447         * parser-defs.h (struct expr_completion_state): New.
8448         (struct parser_state) <parser_state>: Add completion parameter.
8449         <mark_struct_expression, mark_completion_tag>: New methods.
8450         <parse_completion, m_completion_state>: New members.
8451         (prefixify_expression, null_post_parser): Update.
8452         (mark_struct_expression, mark_completion_tag): Don't declare.
8453         * parse.c (parse_completion, expout_last_struct)
8454         (expout_tag_completion_type, expout_completion_name): Remove
8455         globals.
8456         (parser_state::mark_struct_expression)
8457         (parser_state::mark_completion_tag): Now methods.
8458         (prefixify_expression): Add last_struct parameter.
8459         (prefixify_subexp): Likewise.
8460         (parse_exp_1): Update.
8461         (parse_exp_in_context): Add cstate parameter.  Update.
8462         (parse_expression_for_completion): Create an
8463         expr_completion_state.
8464         (null_post_parser): Add "completion" parameter.
8465         * p-exp.y: Update rules.
8466         (yylex): Update.
8467         * language.h (struct language_defn) <la_post_parser>: Add
8468         "completing" parameter.
8469         * go-exp.y: Update rules.
8470         (lex_one_token): Update.
8471         * expression.h (parse_completion): Don't declare.
8472         * d-exp.y: Update rules.
8473         (lex_one_token): Update rules.
8474         * c-exp.y: Update rules.
8475         (lex_one_token): Update.
8476         * ada-lang.c (resolve): Add "parse_completion" parameter.
8477         (resolve_subexp): Likewise.
8478         (ada_resolve_function): Likewise.
8479
8480 2019-04-04  Tom Tromey  <tom@tromey.com>
8481
8482         * parser-defs.h (struct parser_state) <start_arglist,
8483         end_arglist>: New methods.
8484         <arglist_len, m_funcall_chain>: New members.
8485         (arglist_len, start_arglist, end_arglist): Don't declare.
8486         * parse.c (arglist_len, funcall_chain): Remove global.
8487         (start_arglist, end_arglist): Remove functions.
8488         (parse_exp_in_context): Update.
8489         * p-exp.y: Update rules.
8490         * m2-exp.y: Update rules.
8491         * go-exp.y: Update rules.
8492         * f-exp.y: Update rules.
8493         * d-exp.y: Update rules.
8494         * c-exp.y: Update rules.
8495
8496 2019-04-04  Tom Tromey  <tom@tromey.com>
8497
8498         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8499         lex_operator, push_back>: New methods.
8500         Update all rules.
8501         (rust_parser::lex_hex, lex_escape): Rename and update.
8502         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8503         (rust_parser::lex_operator): Rename and update.
8504         (rust_parser::lex_number, rustyylex, rustyyerror)
8505         (rust_lex_test_init, rust_lex_test_sequence)
8506         (rust_lex_test_push_back, rust_lex_tests): Update.
8507         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8508         parameter.
8509         <lexptr, prev_lexptr>: New members.
8510         (lexptr, prev_lexptr): Don't declare.
8511         * parse.c (lexptr, prev_lexptr): Remove globals.
8512         (parse_exp_in_context): Update.
8513         * p-exp.y (yylex, yyerror): Update.
8514         * m2-exp.y (parse_number, yylex, yyerror): Update.
8515         * go-exp.y (lex_one_token, yyerror): Update.
8516         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8517         * d-exp.y (lex_one_token, yyerror): Update.
8518         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8519         (lex_one_token, yyerror): Update.
8520         * ada-lex.l (YY_INPUT): Update.
8521         (rewind_to_char): Update.
8522         * ada-exp.y (yyerror): Update.
8523
8524 2019-04-04  Tom Tromey  <tom@tromey.com>
8525
8526         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8527         * parser-defs.h (struct parser_state) <parser_state>: Add new
8528         parameter.
8529         <comma_terminates>: New member.
8530         (comma_terminates): Don't declare global.
8531         * parse.c (comma_terminates): Remove global.
8532         (parse_exp_in_context): Update.
8533         * p-exp.y (yylex): Update.
8534         * m2-exp.y (yylex): Update.
8535         * go-exp.y (lex_one_token): Update.
8536         * f-exp.y (yylex): Update.
8537         * d-exp.y (lex_one_token): Update.
8538         * c-exp.y (lex_one_token): Update.
8539         * ada-lex.l: Update.
8540
8541 2019-04-04  Tom Tromey  <tom@tromey.com>
8542
8543         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8544         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8545         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8546         * parser-defs.h (paren_depth): Don't declare.
8547         * parse.c (paren_depth): Remove global.
8548         (parse_exp_in_context): Update.
8549         * p-exp.y (paren_depth): New global.
8550         (pascal_parse): Initialize it.
8551         * m2-exp.y (paren_depth): New global.
8552         (m2_parse): Initialize it.
8553         * go-exp.y (paren_depth): New global.
8554         (go_parse): Initialize it.
8555         * f-exp.y (paren_depth): New global.
8556         (f_parse): Initialize it.
8557         * d-exp.y (paren_depth): New global.
8558         (d_parse): Initialize it.
8559         * c-exp.y (paren_depth): New global.
8560         (c_parse): Initialize it.
8561         * ada-lex.l (paren_depth): New global.
8562         (lexer_init): Initialize it.
8563
8564 2019-04-04  Tom Tromey  <tom@tromey.com>
8565
8566         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8567         (rust_parser::convert_ast_to_type)
8568         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8569         * parser-defs.h (struct parser_state) <parser_state>: Add
8570         parameters.  Initialize new members.
8571         <expression_context_block, expression_context_pc>: New members.
8572         * parse.c (expression_context_block, expression_context_pc):
8573         Remove globals.
8574         (parse_exp_in_context): Update.
8575         * p-exp.y: Update all rules.
8576         (yylex): Update.
8577         * m2-exp.y: Update all rules.
8578         (yylex): Update.
8579         * go-exp.y (yylex): Update.
8580         * f-exp.y (yylex): Update.
8581         * d-exp.y: Update all rules.
8582         (yylex): Update.
8583         * c-exp.y: Update all rules.
8584         (lex_one_token, classify_name, yylex, c_parse): Update.
8585         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8586
8587 2019-04-04  Tom Tromey  <tom@tromey.com>
8588
8589         * gdbarch.h, gdbarch.c: Rebuild.
8590         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8591         * stap-probe.h:
8592         (struct stap_parse_info): Replace "parser_state" with
8593         "expr_builder".
8594         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8595         (parser_state): New class.
8596         * parse.c (expr_builder): Rename.
8597         (expr_builder::release): Rename.
8598         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8599         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8600         (write_exp_elt_longcst, write_exp_elt_floatcst)
8601         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8602         (write_exp_string_vector, write_exp_bitstring)
8603         (write_exp_msymbol, mark_struct_expression)
8604         (write_dollar_variable)
8605         (insert_type_address_space, increase_expout_size): Replace
8606         "parser_state" with "expr_builder".
8607         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8608         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8609         "parser_state" with "expr_builder".
8610
8611 2019-04-04  Tom Tromey  <tom@tromey.com>
8612
8613         * rust-exp.y: Replace "parse_language" with method call.
8614         * p-exp.y:
8615         (yylex): Replace "parse_language" with method call.
8616         * m2-exp.y:
8617         (yylex): Replace "parse_language" with method call.
8618         * go-exp.y (classify_name): Replace "parse_language" with method
8619         call.
8620         * f-exp.y (yylex): Replace "parse_language" with method call.
8621         * d-exp.y (lex_one_token): Replace "parse_language" with method
8622         call.
8623         * c-exp.y:
8624         (lex_one_token, classify_name, yylex): Replace "parse_language"
8625         with method call.
8626         * ada-exp.y (find_primitive_type, type_char)
8627         (type_system_address): Replace "parse_language" with method call.
8628
8629 2019-04-04  Tom Tromey  <tom@tromey.com>
8630
8631         * rust-exp.y: Replace "parse_gdbarch" with method call.
8632         * parse.c (write_dollar_variable, insert_type_address_space):
8633         Replace "parse_gdbarch" with method call.
8634         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8635         call.
8636         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8637         call.
8638         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8639         "parse_gdbarch" with method call.
8640         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8641         with method call.
8642         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8643         "parse_gdbarch" with method call.
8644         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8645         "parse_gdbarch" with method call.
8646         * c-exp.y (parse_type, parse_number, classify_name): Replace
8647         "parse_gdbarch" with method call.
8648         * ada-lex.l: Replace "parse_gdbarch" with method call.
8649         * ada-exp.y (parse_type, find_primitive_type, type_char)
8650         (type_system_address): Replace "parse_gdbarch" with method call.
8651
8652 2019-04-04  Tom Tromey  <tom@tromey.com>
8653
8654         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8655         * stap-probe.c (stap_parse_argument): Update.
8656         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8657         initial_size parameter.
8658         * rust-exp.y (rust_lex_tests): Update.
8659         * parse.c (parser_state): Update.
8660         (parse_exp_in_context): Update.
8661         * parser-defs.h (struct parser_state) <parser_state>: Remove
8662         "initial_size" parameter.
8663
8664 2019-04-04  Tom Tromey  <tom@tromey.com>
8665
8666         * parser-defs.h (increase_expout_size): Don't declare.
8667         * parse.c (increase_expout_size): Now static.
8668
8669 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8670
8671         * gnu-nat.c (gnu_nat_target::wait): Fix
8672         target_waitstatus_to_string call.
8673
8674 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8675
8676         * eval.c (evaluate_subexp_standard): Handle internal functions
8677         during Fortran function call handling.
8678
8679 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8680
8681         * NEWS: Mention new internal functions.
8682         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8683         (read_base_type): Use dwarf2_init_complex_target_type.
8684         * value.c (creal_internal_fn): New function.
8685         (cimag_internal_fn): New function.
8686         (_initialize_values): Register new internal functions.
8687
8688 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8689
8690         * infrun.c (stop_all_threads): If debug_infrun, always
8691         trace the wait status after wait_one, using
8692         target_waitstatus_to_string and target_pid_to_str.
8693         (handle_inferior_event): Replace various trace of
8694         wait status kind by a single trace.
8695         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8696         wait status kind image by target_waitstatus_to_string.
8697         * target/waitstatus.c (target_waitstatus_to_string): Fix
8698         obsolete comment.
8699
8700 2019-04-01  Tom Tromey  <tromey@adacore.com>
8701
8702         PR symtab/23331:
8703         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8704
8705 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8706             Pedro Alves  <palves@redhat.com>
8707
8708         * top.c (quit_force): Call 'finalize_values'.
8709         * value.c (finalize_values): New function.
8710         * value.h (finalize_values): Declare.
8711
8712 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8713
8714         * NEWS: Announce $_gdb_major and $_gdb_minor.
8715
8716         * top.c (init_gdb_version_vars): New function.
8717         (gdb_init): Call init_gdb_version_vars.
8718
8719 2019-03-29  Tom Tromey  <tromey@adacore.com>
8720
8721         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8722         help text.  Remove dead code.
8723
8724 2019-03-29  Keith Seitz  <keiths@redhat.com>
8725
8726         From Siddhesh Poyarekar:
8727         * f-lang.h (f77_get_upperbound): Return LONGEST.
8728         (f77_get_lowerbound): Likewise.
8729         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8730         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8731         print them.
8732         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8733         plongest to format print it.
8734         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8735         (f77_get_upperbound): Likewise.
8736         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8737         LOWER_BOUND to LONGEST.
8738         (f77_create_arrayprint_offset_tbl): Likewise.
8739
8740 2019-03-29  Keith Seitz  <keiths@redhat.com>
8741
8742         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8743         %s/pulongest for TYPE_LENGTH instead of %d in format
8744         strings.
8745         * ada-typerint.c (ada_print_type): Likewise.
8746         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8747         * compile/compile-c-support.c (generate_register_struct): Likewise.
8748         * gdbtypes.c (recursive_dump_type): Likewise.
8749         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8750         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8751         instead of %d in format strings.
8752         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8753         to std::min to ULONGEST.
8754         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8755         instead of %d in format strings.
8756         * tracepoint.c (info_scope_command): Likewise.
8757         * typeprint.c (print_offset_data::update)
8758         (print_offset_data::finish): Likewise.
8759         * xtensa-tdep.c (xtensa_store_return_value)
8760         (xtensa_push_dummy_call): Likewise.
8761
8762 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8763
8764         * windows-nat.c (display_selector): Fixed format specifications
8765         for 64-bit Cygwin.
8766
8767 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8768
8769         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8770
8771 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8772
8773         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8774         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8775         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8776         (nios2_linux_init_abi): Install it.
8777
8778 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8779
8780         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8781
8782 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8783
8784         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8785
8786 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8787             Tom Tromey  <tromey@adacore.com>
8788
8789         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8790
8791 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8792
8793         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8794         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8795         method to compute the bounds of range types. Also print "[evaluated]"
8796         if the bounds' values come from a dynamic evaluation.
8797
8798 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8799
8800         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8801         whitespace when pretty printing is on.
8802
8803 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8804
8805         * ppc-linux-nat.c: Add include.
8806
8807 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8808
8809         * NEWS: Mention AArch64 Pointer Authentication.
8810
8811 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8812
8813         * arm-linux-nat.c: Add include.
8814
8815 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8816
8817         * source-cache.c (source_cache::get_source_lines): Re-read
8818         fullname after calling open_source_file.
8819
8820 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8821
8822         * NEWS: Mention TLS support for FreeBSD.
8823
8824 2019-03-25  Tom Tromey  <tromey@adacore.com>
8825
8826         * minsyms.c (BUNCH_SIZE): Update comment.
8827         (~minimal_symbol_reader): Remove old comment.
8828         (compact_minimal_symbols): Update comment.
8829         (minimal_symbol_reader::install): Remove old comment.  Update
8830         other comments.
8831
8832 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8833
8834         * s390-linux-nat.c: Add include.
8835
8836 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8837
8838         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8839         Call linux_get_hwcap.
8840         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8841         Likewise.
8842         (aarch64_linux_get_hwcap): Remove function.
8843         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8844         declaration.
8845         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8846         linux_get_hwcap.
8847         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8848         * linux-tdep.c (linux_get_hwcap): Add function.
8849         (linux_get_hwcap2): Likewise.
8850         * linux-tdep.h (linux_get_hwcap): Add declaration.
8851         (linux_get_hwcap2): Likewise.
8852         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8853         (ppc_linux_get_hwcap2): Likewise.
8854         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8855         linux_get_hwcap.
8856         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8857         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8858         (ppc_linux_nat_target::read_description): Likewise.
8859         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8860         * s390-linux-nat.c: Likewise.
8861         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8862
8863 2019-03-24  Tom Tromey  <tom@tromey.com>
8864
8865         * ada-lang.c (standard_lookup): Simplify initialization.
8866         (ada_lookup_symbol_nonlocal): Simplify return.
8867         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8868         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8869         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8870         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8871         initialization.
8872         * solib.c (solib_global_lookup): Simplify.
8873         * symtab.c (null_block_symbol): Remove.
8874         (symbol_cache_lookup): Simplify returns.
8875         (lookup_language_this): Simplify returns.
8876         (lookup_symbol_aux): Simplify return.
8877         (lookup_local_symbol): Simplify returns.
8878         (lookup_global_symbol_from_objfile): Simplify return.
8879         (lookup_symbol_in_objfile_symtabs)
8880         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8881         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8882         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8883         * cp-namespace.c (cp_lookup_bare_symbol)
8884         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8885         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8886         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8887         (cp_lookup_symbol_via_imports): Simplify initialization.
8888         (find_symbol_in_baseclass): Likewise.
8889         * symtab.h (null_block_symbol): Remove.
8890         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8891         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8892         (d_lookup_symbol_module): Likewise.
8893         (find_symbol_in_baseclass): Simplify initialization.
8894
8895 2019-03-24  Tom Tromey  <tom@tromey.com>
8896
8897         * expression.h: Don't include symtab.h.
8898         (struct block): Forward declare.
8899
8900 2019-03-24  Tom Tromey  <tom@tromey.com>
8901
8902         * c-exp.y (typebase): Remove casts.
8903         * gdbtypes.c (lookup_unsigned_typename, )
8904         (lookup_signed_typename): Remove cast.
8905         * eval.c (parse_to_comma_and_eval): Remove cast.
8906         * parse.c (write_dollar_variable): Remove cast.
8907         * block.h (struct block) <superblock>: Now const.
8908         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8909         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8910         (map_block): Make "block" const.
8911         * symfile.h (struct quick_symbol_functions)
8912         <map_matching_symbols>: Constify block argument to "callback".
8913         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8914         const.
8915         (find_pc_sect_compunit_symtab): Make "b" const.
8916         (find_symbol_at_address): Likewise.
8917         (search_symbols): Likewise.
8918         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8919         (dw2_debug_names_lookup_symbol): Likewise.
8920         (dw2_map_matching_symbols): Update.
8921         * p-valprint.c (pascal_val_print): Remove "block".
8922         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8923         (aux_add_nonlocal_symbols): Make "block" const.
8924         (resolve_subexp): Remove cast.
8925         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8926         const.
8927         (iterate_over_file_blocks): Likewise.
8928         * f-exp.y (%union) <bval>: Remove.
8929         * coffread.c (patch_opaque_types): Make "b" const.
8930         * spu-tdep.c (spu_catch_start): Make "block" const.
8931         * c-valprint.c (print_unpacked_pointer): Remove "block".
8932         * symmisc.c (dump_symtab_1): Make "b" const.
8933         (block_depth): Make "block" const.
8934         * d-exp.y (%union) <bval>: Remove.
8935         * cp-support.h (cp_lookup_rtti_type): Update.
8936         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8937         * psymtab.c (psym_lookup_symbol): Make "block" const.
8938         (maintenance_check_psymtabs): Make "b" const.
8939         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8940         (enumerate_locals, enumerate_args): Update.
8941         * python/py-symtab.c (stpy_global_block): Make "block" const.
8942         (stpy_static_block): Likewise.
8943         * inline-frame.c (block_starting_point_at): Make "new_block"
8944         const.
8945         * block.c (find_block_in_blockvector): Make return type const.
8946         (blockvector_for_pc_sect): Make "b" const.
8947         (find_block_in_blockvector): Make "b" const.
8948
8949 2019-03-23  Tom Tromey  <tom@tromey.com>
8950
8951         * varobj.c (varobj_create): Update.
8952         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8953         * printcmd.c (display_command, do_one_display): Don't reset
8954         innermost_block.
8955         * parser-defs.h (enum innermost_block_tracker_type): Move to
8956         expression.h.
8957         (innermost_block): Update comment.
8958         * parse.c (parse_exp_1): Add tracker_types parameter.
8959         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8960         tracker_types parameter.  Reset innermost_block.
8961         (parse_exp_in_context): Remove.
8962         (parse_expression_for_completion): Update.
8963         * objfiles.c (~objfile): Don't reset expression_context_block or
8964         innermost_block.
8965         * expression.h (enum innermost_block_tracker_type): Move from
8966         parser-defs.h.
8967         (parse_exp_1): Add tracker_types parameter.
8968         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8969         reset innermost_block.
8970
8971 2019-03-23  Tom Tromey  <tom@tromey.com>
8972
8973         * objfiles.h: Include bcache.h.
8974
8975 2019-03-23  Tom Tromey  <tom@tromey.com>
8976
8977         * linespec.c (get_current_search_block): Use
8978         scoped_restore_current_language.
8979         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8980
8981 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8982             Jiong Wang  <jiong.wang@arm.com>
8983
8984         * aarch64-linux-tdep.c
8985         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8986         section.
8987         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8988
8989 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8990             Jiong Wang  <jiong.wang@arm.com>
8991
8992         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8993         instructions.
8994         (aarch64_analyze_prologue_test): Add PACIASP test.
8995         (aarch64_prologue_prev_register): Unmask PC value.
8996
8997 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8998             Jiong Wang  <jiong.wang@arm.com>
8999
9000         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9001         (aarch64_dwarf2_prev_register): Unmask PC value.
9002         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9003         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9004         DW_CFA_AARCH64_negate_ra_state.
9005         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9006
9007 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9008             Jiong Wang  <jiong.wang@arm.com>
9009
9010         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9011         registers.
9012         (aarch64_pseudo_register_name): Likewise.
9013         (aarch64_pseudo_register_type): Likewise.
9014         (aarch64_pseudo_register_reggroup_p): Likewise.
9015         (aarch64_gdbarch_init): Add pauth registers.
9016         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9017         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9018         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9019         (struct gdbarch_tdep): Add regnum for ra_state.
9020
9021 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9022             Jiong Wang  <jiong.wang@arm.com>
9023
9024         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9025
9026 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9027             Jiong Wang  <jiong.wang@arm.com>
9028
9029         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9030         function.
9031         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9032         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9033         (aarch64_gdbarch_init): Add puth registers.
9034         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9035         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9036         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9037
9038 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9039             Jiong Wang  <jiong.wang@arm.com>
9040
9041         * aarch64-linux-nat.c
9042         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9043         * aarch64-linux-tdep.c
9044         (aarch64_linux_core_read_description): Likewise.
9045         (aarch64_linux_get_hwcap): New function.
9046         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9047         (aarch64_linux_get_hwcap): New declaration.
9048
9049 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9050             Jiong Wang  <jiong.wang@arm.com>
9051
9052         * aarch64-linux-nat.c
9053         (aarch64_linux_nat_target::read_description): Add pauth param.
9054         * aarch64-linux-tdep.c
9055         (aarch64_linux_core_read_description): Likewise.
9056         * aarch64-tdep.c (struct target_desc): Add in pauth.
9057         (aarch64_read_description): Add pauth param.
9058         (aarch64_gdbarch_init): Likewise.
9059         * aarch64-tdep.h (aarch64_read_description): Likewise.
9060         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9061         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9062         * features/Makefile: Add new files.
9063         * features/aarch64-pauth.c: New file.
9064         * features/aarch64-pauth.xml: New file.
9065
9066 2019-03-20  Tom Tromey  <tromey@adacore.com>
9067
9068         * infrun.c (handle_inferior_event): Rename from
9069         handle_inferior_event_1.  Create a scoped_value_mark.
9070         (handle_inferior_event): Remove.
9071
9072 2019-03-19  Tom Tromey  <tromey@adacore.com>
9073
9074         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9075         * infrun.h (print_stop_event): Add "displays" parameter.
9076         * infrun.c (print_stop_event): Add "displays" parameter.
9077
9078 2019-03-19  Pedro Alves  <palves@redhat.com>
9079
9080         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9081         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9082         to -1.  Fix TABs vs spaces.
9083         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9084         * tui/tui-out.h (tui_ui_out) Add intro comments.
9085         <m_line, m_start_of_line>: In-class initialize, and add describing
9086         comment.
9087
9088 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9089
9090         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9091         variable names.
9092         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9093
9094 2019-03-18  Pedro Alves  <palves@redhat.com>
9095             Eli Zaretskii <eliz@gnu.org>
9096
9097         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9098         m_line and m_start_of_line.
9099
9100 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9101
9102         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9103         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9104         it returns a newline.  This fixes a regression in TU mode, whereby
9105         the next line is output on the same screen line as the user input.
9106
9107 2019-03-18  Tom Tromey  <tromey@adacore.com>
9108
9109         * minsyms.c (minimal_symbol_reader::install): Remove call to
9110         obstack_blank.
9111
9112 2019-03-18  Pedro Alves  <palves@redhat.com>
9113
9114         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9115         New globals.
9116         (apply_style): New, factored out from ...
9117         (apply_ansi_escape): ... this.  Handle reverse video mode.
9118         (tui_set_reverse_mode): New function.
9119         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9120         * tui/tui-winsource.c (tui_show_source_line): Use
9121         tui_set_reverse_mode instead of setting A_STANDOUT.
9122         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9123         New setter methods.
9124
9125 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9126
9127         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9128         Handle tabs.
9129
9130 2019-03-18  Tom Tromey  <tromey@adacore.com>
9131
9132         * ada-lang.c (empty_array): Add "high" parameter.
9133         (ada_evaluate_subexp): Update.
9134
9135 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9136
9137         * unittests/string_view-selftests.c: Define
9138         _initialize_string_view_selftests unconditionally.
9139
9140 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9141
9142         PR gdb/24350
9143         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9144
9145 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9146
9147         PR gdb/24351
9148         * windows-nat.c (display_selector): Fix format specifiers.
9149
9150 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9151
9152         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9153         tui_refill_source_window instead of tui_refresh_win, to update the
9154         current execution line.  This fixes redisplay of the current line
9155         when stepping through the code with "next" or "step".
9156
9157 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9158
9159         * source-cache.c (source_cache::get_source_lines): Call
9160         find_source_lines to initialize s->nlines.  This fixes vertical
9161         scrolling of TUI source window when the DOWN arrow is pressed.
9162
9163 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9164
9165         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9166         linux-thread-db.c (_initialize_thread_db): Likewise.
9167
9168 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9169
9170         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9171         wclrtoeol in tui_show_source_line".  This reverts changes made in
9172         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9173
9174 2019-03-15  Tom Tromey  <tom@tromey.com>
9175
9176         * symtab.h (struct minimal_symbol): Derive from
9177         general_symbol_info.
9178         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9179         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9180         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9181         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9182         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9183         (MSYMBOL_SEARCH_NAME): Update.
9184         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9185         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9186         * minsyms.c (minimal_symbol_reader::record_full): Update.
9187
9188 2019-03-15  Tom Tromey  <tom@tromey.com>
9189
9190         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9191
9192 2019-03-15  Tom Tromey  <tom@tromey.com>
9193
9194         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9195         unique_xmalloc_ptr.
9196         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9197         Update.
9198         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9199         (build_minimal_symbol_hash_tables)
9200         (minimal_symbol_reader::install): Update.
9201
9202 2019-03-15  Tom Tromey  <tom@tromey.com>
9203
9204         * symtab.c (create_demangled_names_hash): Update.
9205         (symbol_set_names): Update.
9206         * objfiles.h (struct objfile_per_bfd_storage)
9207         <demangled_names_hash>: Now an htab_up.
9208         * objfiles.c (objfile_per_bfd_storage): Simplify.
9209
9210 2019-03-15  Tom Tromey  <tom@tromey.com>
9211
9212         * objfiles.h (struct objfile_per_bfd_storage): Declare
9213         destructor.
9214         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9215         New.
9216         (get_objfile_bfd_data): Use new.  Don't initialize
9217         language_of_main.
9218         (free_objfile_per_bfd_storage): Remove.
9219         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9220
9221 2019-03-15  Tom Tromey  <tom@tromey.com>
9222
9223         * symfile.c (reread_symbols): Update.
9224         * objfiles.c (objfile::objfile): Update.
9225         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9226         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9227         comment.
9228         (minimal_symbol_reader::install): Update.
9229         (terminate_minimal_symbol_table): Remove.
9230         * jit.c (jit_object_close_impl): Update.
9231
9232 2019-03-15  Tom Tromey  <tom@tromey.com>
9233
9234         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9235         initializations.
9236
9237 2019-03-15  Tom Tromey  <tom@tromey.com>
9238
9239         * objfiles.h (struct objfile_per_bfd_storage)
9240         <demangled_hash_languages>: Now a bitset.
9241         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9242         (lookup_minimal_symbol): Update.
9243
9244 2019-03-15  Tom Tromey  <tom@tromey.com>
9245
9246         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9247         Don't return the symbol.
9248         * coffread.c (record_minimal_symbol): Use record_full.
9249
9250 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9251
9252         The MS-Windows port of ncurses fails to switch to a color pair if
9253         one or both of the colors are the implicit default colors.  This
9254         change records the default colors when TUI is initialized, and
9255         then specifies them explicitly when a color pair uses the default
9256         colors.  This allows color styling in TUI mode on MS-Windows.
9257
9258         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9259         ncurses_norm_attr.
9260         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9261         colors in ncurses_norm_attr.
9262         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9263         "none", replace it with the default color recorded in
9264         ncurses_norm_attr.
9265
9266 2019-03-14  Tom Tromey  <tromey@adacore.com>
9267
9268         * source-cache.h (class source_cache) <get_source_lines>: Return
9269         std::string.
9270         * source-cache.c (source_cache::extract_lines): Handle case where
9271         first_pos==npos.  Return std::string.
9272         (source_cache::get_source_lines): Update.
9273
9274 2019-03-14  Tom Tromey  <tromey@adacore.com>
9275
9276         * NEWS: Add item for "style sources" commands.
9277         * source-cache.c (source_cache::get_source_lines): Check
9278         source_styling.
9279         * cli/cli-style.c (source_styling): New global.
9280         (_initialize_cli_style): Add "style sources" commands.
9281         (show_style_sources): New function.
9282         * cli/cli-style.h (source_styling): Declare.
9283
9284 2019-03-14  Pedro Alves  <palves@redhat.com>
9285             Tom Tromey  <tromey@adacore.com>
9286
9287         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9288         * tui/tui-winsource.c (tui_refill_source_window): New function,
9289         from...
9290         (tui_horizontal_source_scroll): ... here.  Move some logic.
9291         * cli/cli-style.c (set_style_enabled): Notify new observable.
9292         * tui/tui-hooks.c (tui_redisplay_source): New function.
9293         (tui_attach_detach_observers): Attach or detach
9294         tui_redisplay_source.
9295         * observable.h (source_styling_changed): New observable.
9296         * observable.c: Define source_styling_changed observable.
9297
9298 2019-03-13  Tom Tromey  <tromey@adacore.com>
9299
9300         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9301         (i386_gnu_nat_target::store_registers): Update.
9302         * target-debug.h (target_debug_print_std_string): New macro.
9303         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9304         * windows-tdep.c (display_one_tib): Update.
9305         * tui/tui-stack.c (tui_make_status_line): Update.
9306         * top.c (print_inferior_quit_action): Update.
9307         * thread.c (thr_try_catch_cmd): Update.
9308         (add_thread_with_info): Update.
9309         (thread_target_id_str): Update.
9310         (thr_try_catch_cmd): Update.
9311         (thread_command): Update.
9312         (thread_find_command): Update.
9313         * record-btrace.c (record_btrace_target::info_record)
9314         (record_btrace_resume_thread, record_btrace_target::resume)
9315         (record_btrace_cancel_resume, record_btrace_step_thread)
9316         (record_btrace_target::wait, record_btrace_target::wait)
9317         (record_btrace_target::wait, record_btrace_target::stop): Update.
9318         * progspace.c (print_program_space): Update.
9319         * process-stratum-target.c
9320         (process_stratum_target::thread_address_space): Update.
9321         * linux-fork.c (linux_fork_mourn_inferior)
9322         (detach_checkpoint_command, info_checkpoints_command)
9323         (linux_fork_context): Update.
9324         (linux_fork_detach): Update.
9325         (class scoped_switch_fork_info): Update.
9326         (delete_checkpoint_command): Update.
9327         * infrun.c (follow_fork_inferior): Update.
9328         (follow_fork_inferior): Update.
9329         (proceed_after_vfork_done): Update.
9330         (handle_vfork_child_exec_or_exit): Update.
9331         (follow_exec): Update.
9332         (displaced_step_prepare_throw): Update.
9333         (displaced_step_restore): Update.
9334         (start_step_over): Update.
9335         (resume_1): Update.
9336         (clear_proceed_status_thread): Update.
9337         (proceed): Update.
9338         (print_target_wait_results): Update.
9339         (do_target_wait): Update.
9340         (context_switch): Update.
9341         (stop_all_threads): Update.
9342         (restart_threads): Update.
9343         (finish_step_over): Update.
9344         (handle_signal_stop): Update.
9345         (switch_back_to_stepped_thread): Update.
9346         (keep_going_pass_signal): Update.
9347         (print_exited_reason): Update.
9348         (normal_stop): Update.
9349         * inferior.c (inferior_pid_to_str): Change return type.
9350         (print_selected_inferior): Update.
9351         (add_inferior): Update.
9352         (detach_inferior): Update.
9353         * dummy-frame.c (fprint_dummy_frames): Update.
9354         * dcache.c (dcache_info_1): Update.
9355         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9356         (btrace_fetch, btrace_clear): Update.
9357         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9358         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9359         type.
9360         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9361         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9362         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9363         * gdbarch.c, gdbarch.h: Rebuild.
9364         * gdbarch.sh (core_pid_to_str): Change return type.
9365         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9366         return type.
9367         (windows_nat_target::pid_to_str): Change return type.
9368         (windows_delete_thread): Update.
9369         (windows_nat_target::attach): Update.
9370         (windows_nat_target::files_info): Update.
9371         * target-delegates.c: Rebuild.
9372         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9373         return type.
9374         (sol_thread_target::pid_to_str): Change return type.
9375         * remote.c (class remote_target) <pid_to_str>: Change return
9376         type.
9377         (remote_target::pid_to_str): Change return type.
9378         (extended_remote_target::attach, remote_target::remote_stop_ns)
9379         (remote_target::remote_notif_remove_queued_reply)
9380         (remote_target::push_stop_reply, remote_target::disable_btrace):
9381         Update.
9382         (extended_remote_target::attach): Update.
9383         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9384         type.
9385         (gdbsim_target::pid_to_str): Change return type.
9386         * ravenscar-thread.c (struct ravenscar_thread_target)
9387         <pid_to_str>: Change return type.
9388         (ravenscar_thread_target::pid_to_str): Change return type.
9389         * procfs.c (class procfs_target) <pid_to_str>: Change return
9390         type.
9391         (procfs_target::pid_to_str): Change return type.
9392         (procfs_target::attach): Update.
9393         (procfs_target::detach): Update.
9394         (procfs_target::fetch_registers): Update.
9395         (procfs_target::store_registers): Update.
9396         (procfs_target::wait): Update.
9397         (procfs_target::files_info): Update.
9398         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9399         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9400         return type.
9401         (nto_procfs_target::pid_to_str): Change return type.
9402         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9403         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9404         return type.
9405         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9406         (exit_lwp): Update.
9407         (attach_proc_task_lwp_callback, get_detach_signal)
9408         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9409         (linux_nat_target::resume, wait_lwp, stop_callback)
9410         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9411         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9412         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9413         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9414         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9415         type.
9416         (inf_ptrace_target::attach): Update.
9417         (inf_ptrace_target::files_info): Update.
9418         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9419         type.
9420         (go32_nat_target::pid_to_str): Change return type.
9421         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9422         (gnu_nat_target::wait): Update.
9423         (gnu_nat_target::wait): Update.
9424         (gnu_nat_target::resume): Update.
9425         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9426         (fbsd_nat_target::wait): Update.
9427         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9428         type.
9429         (darwin_nat_target::attach): Update.
9430         * corelow.c (class core_target) <pid_to_str>: Change return type.
9431         (core_target::pid_to_str): Change return type.
9432         * target.c (normal_pid_to_str): Change return type.
9433         (default_pid_to_str): Likewise.
9434         (target_pid_to_str): Change return type.
9435         (target_translate_tls_address): Update.
9436         (target_announce_detach): Update.
9437         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9438         return type.
9439         (bsd_uthread_target::pid_to_str): Change return type.
9440         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9441         type.
9442         (bsd_kvm_target::pid_to_str): Change return type.
9443         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9444         return type.
9445         (aix_thread_target::pid_to_str): Change return type.
9446         * target.h (struct target_ops) <pid_to_str>: Change return type.
9447         (target_pid_to_str, normal_pid_to_str): Likewise.
9448         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9449         type.
9450         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9451         type.
9452         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9453         return type.
9454         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9455         type.
9456         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9457         type.
9458         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9459         return type.
9460
9461 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9462
9463         * NEWS: Mention that the new default MI version is 3.  Mention
9464         changes to the output of commands and events that deal with
9465         multi-location breakpoints.
9466         * breakpoint.c: Include "mi/mi-out.h".
9467         (print_one_breakpoint): Change output syntax if using MI version
9468         >= 3.
9469         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9470         New.
9471         (mi_multi_location_breakpoint_output_fixed): New.
9472         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9473         (mi_cmd_fix_multi_location_breakpoint_output): New.
9474         (mi_multi_location_breakpoint_output_fixed): New.
9475         * mi/mi-cmds.c (mi_cmds): Register command
9476         -fix-multi-location-breakpoint-output.
9477         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9478         interpreter "mi".
9479
9480 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9481
9482         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9483         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9484         instantiate mi_ui_out based on interpreter name.
9485         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9486         * mi/mi-main.c (mi_load_progress): Likewise.
9487
9488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9489
9490         * NEWS: Combine separate "New targets" sections for 8.3.
9491
9492 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9493
9494         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9495         (ppcfbsd_init_abi): Install gdbarch
9496         "fetch_tls_load_module_address" and "get_thread_local_address"
9497         methods.
9498
9499 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9500
9501         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9502         (riscv_fbsd_init_abi): Install gdbarch
9503         "fetch_tls_load_module_address" and "get_thread_local_address"
9504         methods.
9505
9506 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9507
9508         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9509         (i386fbsd_init_abi): Install gdbarch
9510         "fetch_tls_load_module_address" and "get_thread_local_address"
9511         methods.
9512
9513 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9514
9515         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9516         (amd64fbsd_init_abi): Install gdbarch
9517         "fetch_tls_load_module_address" and "get_thread_local_address"
9518         methods.
9519
9520 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9521
9522         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9523         (struct fbsd_pspace_data): New type.
9524         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9525         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9526         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9527         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9528         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9529
9530 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9531
9532         * gdbtypes.c (lookup_struct_elt): New function.
9533         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9534         * gdbtypes.h (struct struct_elt): New type.
9535         (lookup_struct_elt): New prototype.
9536
9537 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9538
9539         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9540         remove disabled code block.
9541
9542 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9543
9544         * gdbarch.sh (get_thread_local_address): New method.
9545         * gdbarch.h, gdbarch.c: Regenerate.
9546         * target.c (target_translate_tls_address): Use
9547         gdbarch_get_thread_local_address if present instead of
9548         target::get_thread_local_address.
9549
9550 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9551
9552         * target.h (target::get_thread_local_address): Update comment.
9553
9554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9555
9556         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9557         objfile->separate_debug_objfile_backlink if not NULL.
9558
9559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9560
9561         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9562         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9563         (amd64bsd_store_inferior_registers): Likewise.
9564         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9565         Enable segment base registers.
9566         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9567         PT_GETFSBASE and PT_GETGSBASE.
9568         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9569         PT_SETGSBASE.
9570         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9571         segment base registers.
9572         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9573
9574 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9575
9576         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9577         Update calls to i386_target_description to add 'segments'
9578         parameter.
9579         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9580         add segment base registers.
9581         * arch/i386.c (i386_create_target_description): Add 'segments'
9582         parameter to enable segment base registers.
9583         * arch/i386.h (i386_create_target_description): Likewise.
9584         * features/i386/32bit-segments.xml: New file.
9585         * features/i386/32bit-segments.c: Generate.
9586         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9587         call to i386_target_description to add 'segments' parameter.
9588         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9589         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9590         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9591         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9592         if feature is present.
9593         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9594         Add 'segments' parameter to call to i386_target_description.
9595         (i386_target_description): Add 'segments' parameter to enable
9596         segment base registers.
9597         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9598         to call to i386_target_description.
9599         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9600         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9601         Define I386_NUM_REGS.
9602         (i386_target_description): Add 'segments' parameter to enable
9603         segment base registers.
9604
9605 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9606
9607         PR/24325
9608         * source-cache.c: #undef open and close, to avoid unresolved
9609         externals during linking.
9610
9611 2019-03-12  Tom Tromey  <tromey@adacore.com>
9612
9613         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9614         const.  Add initializers.
9615         (_initialize_remote): Don't initialize ptid globals.
9616
9617 2019-03-12  Pedro Alves  <palves@redhat.com>
9618
9619         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9620
9621 2019-03-12  Pedro Alves  <palves@redhat.com>
9622
9623         * cp-name-parser.y (main): Remove unused 'len' variable.
9624
9625 2019-03-12  Tom Tromey  <tromey@adacore.com>
9626
9627         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9628         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9629
9630 2019-03-12  Tom Tromey  <tromey@adacore.com>
9631
9632         * linux-nat.c (iterate_over_lwps): Update.
9633         (stop_callback): Remove parameter.
9634         (stop_wait_callback, detach_callback, resume_set_callback)
9635         (select_singlestep_lwp_callback, set_ignore_sigint)
9636         (status_callback, resumed_callback, resume_clear_callback)
9637         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9638         data parameter.
9639         (linux_nat_target::detach, linux_nat_target::resume)
9640         (linux_stop_and_wait_all_lwps, select_event_lwp)
9641         (linux_nat_filter_event, linux_nat_wait_1)
9642         (linux_nat_target::kill, linux_nat_target::stop)
9643         (linux_nat_target::stop): Update.
9644         (linux_nat_resume_callback): Change type.
9645         (resume_stopped_resumed_lwps, count_events_callback)
9646         (select_event_lwp_callback): Likewise.
9647         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9648         * arm-linux-nat.c (struct update_registers_data): Remove.
9649         (update_registers_callback): Change type.
9650         (arm_linux_insert_hw_breakpoint1): Update.
9651         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9652         parameter.
9653         (x86_linux_dr_set_addr): Update.
9654         (x86_linux_dr_set_control): Update.
9655         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9656         (iterate_over_lwps): Use gdb::function_view.
9657         * nat/aarch64-linux-hw-point.c (struct
9658         aarch64_dr_update_callback_param): Remove.
9659         (debug_reg_change_callback): Change type.
9660         (aarch64_notify_debug_reg_change): Update.
9661         * s390-linux-nat.c (s390_refresh_per_info): Update.
9662
9663 2019-03-11  Tom Tromey  <tromey@adacore.com>
9664
9665         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9666         redundant assignment to "this_cu".
9667
9668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9669
9670         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9671
9672 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9673
9674         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9675         from...
9676         (rank_one_type): ... this.
9677
9678 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9679
9680         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9681         from...
9682         (rank_one_type): ... this.
9683
9684 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9685
9686         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9687         from...
9688         (rank_one_type): ... this.
9689
9690 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9691
9692         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9693         from...
9694         (rank_one_type): ... this.
9695
9696 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9697
9698         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9699         from...
9700         (rank_one_type): ... this.
9701
9702 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9703
9704         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9705         from...
9706         (rank_one_type): ... this.
9707
9708 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9709
9710         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9711         from...
9712         (rank_one_type): ... this.
9713
9714 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9715
9716         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9717         from...
9718         (rank_one_type): ... this.
9719
9720 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9721
9722         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9723         from...
9724         (rank_one_type): ... this.
9725
9726 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9727
9728         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9729         from...
9730         (rank_one_type): ... this.
9731
9732 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9733
9734         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9735         from...
9736         (rank_one_type): ... this.
9737
9738 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9739
9740         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9741         from...
9742         (rank_one_type): ... this.
9743
9744 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9745
9746         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9747         inferior-events' shows the example events.
9748
9749 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9750
9751         Support styling on native MS-Windows console
9752
9753         PR/24315
9754         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9755         on MS-Windows if $TERM is not defined.
9756
9757         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9758
9759         * posix-hdep.c (gdb_console_fputs):
9760         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9761         functions.
9762         * ui-file.h (gdb_console_fputs): Add prototype.
9763
9764         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9765         back to fputs only if the former returns zero.
9766
9767 2019-03-07  Tom Tromey  <tom@tromey.com>
9768
9769         * symmisc.c (print_symbol_bcache_statistics): Update.
9770         (print_objfile_statistics): Update.
9771         * symfile.c (allocate_symtab): Update.
9772         * stabsread.c: Don't include bcache.h.
9773         * psymtab.h (struct psymbol_bcache): Don't declare.
9774         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9775         (psymbol_bcache_init, psymbol_bcache_free)
9776         (psymbol_bcache_get_bcache): Don't declare.
9777         * psymtab.c (struct psymbol_bcache): Remove.
9778         (psymtab_storage::psymtab_storage): Update.
9779         (psymtab_storage::~psymtab_storage): Update.
9780         (psymbol_bcache_init, psymbol_bcache_free)
9781         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9782         (add_psymbol_to_bcache): Update.
9783         (allocate_psymtab): Update.
9784         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9785         macro_cache>: No longer pointers.
9786         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9787         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9788         * macrotab.c (macro_bcache): Update.
9789         * macroexp.c: Don't include bcache.h.
9790         * gdbtypes.c (check_types_worklist): Update.
9791         (types_deeply_equal): Remove TRY/CATCH.  Update.
9792         * elfread.c (elf_symtab_read): Update.
9793         * dwarf2read.c: Don't include bcache.h.
9794         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9795         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9796         (print_bcache_statistics, bcache_memory_used): Don't declare.
9797         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9798         methods.  Rename all data members.
9799         * bcache.c (struct bcache): Move to bcache.h.
9800         (bcache::expand_hash_table): Rename from expand_hash_table.
9801         (bcache): Remove.
9802         (bcache::insert): Rename from bcache_full.
9803         (bcache::compare): Rename from bcache_compare.
9804         (bcache_xmalloc): Remove.
9805         (bcache::~bcache): Rename from bcache_xfree.
9806         (bcache::print_statistics): Rename from print_bcache_statistics.
9807         (bcache::memory_used): Rename from bcache_memory_used.
9808
9809 2019-03-07  Pedro Alves  <palves@redhat.com>
9810
9811         * infrun.c (normal_stop): Also check for
9812         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9813
9814 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9815
9816         * f-lang.c (value_from_host_double): Moved to...
9817         * value.c (value_from_host_double): ...here.
9818         * value.h (value_from_host_double): Declare.
9819         * guile/scm-math.c (vlscm_convert_typed_number): Use
9820         value_from_host_double.
9821         (vlscm_convert_number): Likewise.
9822         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9823         * python/py-value.c (convert_value_from_python): Likewise.
9824
9825 2019-03-06  Tom Tromey  <tom@tromey.com>
9826
9827         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9828
9829 2019-03-06  Tom Tromey  <tom@tromey.com>
9830
9831         * utils.h (free_current_contents): Don't declare.
9832         * utils.c (free_current_contents): Remove.
9833
9834 2019-03-06  Tom Tromey  <tom@tromey.com>
9835
9836         * top.c (quit_force): Update.
9837         * main.c (captured_command_loop): Update.
9838         * common/new-op.c (operator new): Update.
9839         * common/common-exceptions.c (struct catcher)
9840         <save_cleanup_chain>: Remove member.
9841         (exceptions_state_mc_init): Update.
9842         (exception_try_scope_entry): Return nullptr.
9843         (exception_try_scope_exit, exception_rethrow)
9844         (throw_exception_sjlj, throw_exception_cxx): Update.
9845         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9846         (all_cleanups, do_cleanups, discard_cleanups)
9847         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9848         (restore_cleanups, restore_final_cleanups): Don't declare.
9849         (do_final_cleanups): Remove parameter.
9850         * common/cleanups.c (cleanup_chain, make_cleanup)
9851         (make_cleanup_dtor, all_cleanups, do_cleanups)
9852         (discard_my_cleanups, discard_cleanups)
9853         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9854         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9855         (null_cleanup): Remove.
9856         (do_final_cleanups): Remove parameter.
9857
9858 2019-03-06  Tom Tromey  <tom@tromey.com>
9859
9860         * remote.c (remote_target::remote_parse_stop_reply): Use
9861         unique_xmalloc_ptr.
9862
9863 2019-03-06  Tom Tromey  <tom@tromey.com>
9864
9865         * stabsread.c (struct stabs_field_info): Rename from field_info.
9866         <list, fnlist>: Add initializers.
9867         <obstack>: New member.
9868         (read_member_functions, read_struct_fields, read_baseclasses):
9869         Allocate on obstack.  Don't use cleanups.
9870         (read_one_struct_field, read_member_functions, read_struct_fields)
9871         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9872         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9873         (read_struct_type): Update.
9874
9875 2019-03-06  Tom Tromey  <tom@tromey.com>
9876
9877         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9878         * common/filestuff.h (make_cleanup_close): Don't declare.
9879         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9880         Remove.
9881
9882 2019-03-06  Tom Tromey  <tom@tromey.com>
9883
9884         * solib-aix.c: Use make_scope_exit.
9885
9886 2019-03-06  Tom Tromey  <tom@tromey.com>
9887
9888         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9889         Use make_scope_exit.
9890
9891 2019-03-06  Tom Tromey  <tom@tromey.com>
9892
9893         * solib-svr4.c (disable_probes_interface): Remove parameter.
9894         (svr4_handle_solib_event): Use make_scope_exit.
9895
9896 2019-03-06  Tom Tromey  <tom@tromey.com>
9897
9898         * remote.c (struct stop_reply_deleter): Remove.
9899         (stop_reply_up): Update.
9900         (struct stop_reply): Derive from notif_event.  Don't typedef.
9901         <regcache>: Now a std::vector.
9902         (stop_reply_xfree): Remove.
9903         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9904         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9905         (remote_target::discard_pending_stop_replies): Use delete.
9906         (remote_target::remote_parse_stop_reply): Update.
9907         (remote_target::process_stop_reply): Update.
9908         * remote-notif.h (struct notif_event): Add virtual destructor.
9909         Remove "dtr" member.
9910         (struct notif_client) <alloc_event>: Return a unique_ptr.
9911         (notif_event_xfree): Don't declare.
9912         (notif_event_up): New typedef.
9913         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9914         (notif_event_xfree, do_notif_event_xfree): Remove.
9915         (remote_notif_state_xfree): Update.
9916
9917 2019-03-06  Tom Tromey  <tom@tromey.com>
9918
9919         * infrun.c (displaced_step_clear_cleanup): Now a
9920         forward_scope_exit type.
9921         (displaced_step_prepare_throw): Update.
9922         (displaced_step_fixup): Update.
9923
9924 2019-03-06  Tom Tromey  <tom@tromey.com>
9925
9926         * inferior.h (class inferior): Update comment.
9927         * gdbthread.h (class thread_info): Update comment.
9928
9929 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9930             Tom Tromey  <tom@tromey.com>
9931
9932         * stabsread.h (struct stab_section_list): Remove.
9933         (coffstab_build_psymtabs): Update.
9934         * dbxread.c (symbuf_sections): Now a std::vector.
9935         (sect_idx): New global.
9936         (fill_symbuf): Update.
9937         (coffstab_build_psymtabs): Change type of stabsects parameter.
9938         Update.
9939         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9940         std::vector.
9941         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9942         (coff_locate_sections): Update.
9943         (coff_symfile_read): Remove cleanups.  Update.
9944         (init_stringtab): Add storage parameter.
9945         (free_stringtab, free_stringtab_cleanup): Remove.
9946         (init_lineno): Add storage parameter.
9947         (free_linetab, free_linetab_cleanup): Remove.
9948
9949 2019-03-06  Pedro Alves  <palves@redhat.com>
9950
9951         * linux-fork.c (fork_info::clobber_regs): Delete.
9952         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9953         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9954         comment.  Adjust.
9955         (scoped_switch_fork_info::scoped_switch_fork_info)
9956         (checkpoint_command, linux_fork_context): Adjust
9957         fork_save_infrun_state calls.
9958
9959 2019-03-06  Pedro Alves  <palves@redhat.com>
9960
9961         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9962         (inf_has_multiple_threads): Return 'bool' and rewrite using
9963         inferior_info::threads().
9964
9965 2019-03-06  Pedro Alves  <palves@redhat.com>
9966
9967         * linux-fork.c: Include <list>.
9968         (fork_list): Now a std::list instance.
9969         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9970         (forks_exist_p, find_last_fork): Adjust.
9971         (new_fork): Delete.
9972         (one_fork_p): New.
9973         (add_fork): Adjust.
9974         (free_fork): Delete, folded into fork_info::~fork_info().
9975         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9976         Adjust.
9977         (init_fork_list): Delete.
9978         (linux_fork_killall, linux_fork_mourn_inferior)
9979         (linux_fork_detach, info_checkpoints_command): Adjust.
9980         (_initialize_linux_fork): No longer call init_fork_list.
9981
9982 2019-03-06  Pedro Alves  <palves@redhat.com>
9983
9984         * linux-fork.c (new_fork): New, split out of ...
9985         (add_fork): ... this.  Return void.  Move "first fork" special
9986         case from here, to ...
9987         (checkpoint_command): ... here.
9988         * linux-linux.h (add_fork): Return void.
9989
9990 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9991
9992         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9993
9994 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9995             Chris January  <chris.january@arm.com>
9996             David Lecomber  <david.lecomber@arm.com>
9997
9998         * f-exp.y: New token, UNOP_INTRINSIC.
9999         (exp): New pattern using UNOP_INTRINSIC token.
10000         (f77_keywords): Add 'abs' keyword.
10001         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10002         (value_from_host_double): New function.
10003         (evaluate_subexp_f): Support UNOP_ABS.
10004
10005 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10006
10007         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10008         types.
10009
10010 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10011
10012         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10013         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10014         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10015
10016 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10017
10018         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10019
10020 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10021             Chris January  <chris.january@arm.com>
10022
10023         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10024         * f-exp.y: Define 'KIND' token.
10025         (exp): New pattern for KIND expressions.
10026         (ptype): Handle types with a kind extension.
10027         (direct_abs_decl): Extend to spot kind extensions.
10028         (f77_keywords): Add 'kind' to the list.
10029         (push_kind_type): New function.
10030         (convert_to_kind_type): New function.
10031         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10032         * parse.c (operator_length_standard): Likewise.
10033         * parser-defs.h (enum type_pieces): Add tp_kind.
10034         * std-operator.def: Add UNOP_KIND.
10035
10036 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10037
10038         * f-exp.y (f_parse): Set yydebug.
10039
10040 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10041
10042         * f-lang.c (evaluate_subexp_f): New function.
10043         (exp_descriptor_f): New global.
10044         (f_language_defn): Use exp_descriptor_f instead of
10045         exp_descriptor_standard.
10046
10047 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10048
10049         * f-exp.y (struct token): Add comments.
10050         (dot_ops): Remove uppercase versions and the end marker.
10051         (f77_keywords): Likewise.
10052         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10053         entries in the dot_ops array are case insensitive, and use
10054         strncasecmp to compare strings.  Also some whitespace cleanup in
10055         this area.  Similar for the f77_keywords array, except entries in
10056         this list might be case sensitive.
10057
10058 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10059
10060         * f-exp.y (struct f77_boolean_val): Add comments.
10061         (boolean_values): Remove uppercase versions, and end marker.
10062         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10063         and use strncasecmp to achieve case insensitivity.  Additionally,
10064         perform whitespace cleanup around this code.
10065
10066 2019-03-06  Tom Tromey  <tromey@adacore.com>
10067
10068         * remote-sim.c (gdbsim_target_open): Use result of
10069         gdb_argv::release.
10070
10071 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10072         Dirk Schubert  <dirk.schubert@arm.com>
10073         Chris January  <chris.january@arm.com>
10074
10075         * eval.c (evaluate_subexp_standard): Call Fortran argument
10076         wrapping logic.
10077         * f-lang.c (struct value): A value which can be passed into a
10078         Fortran function call.
10079         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10080         where appropriate.
10081         (struct type): Value ready for a Fortran function call.
10082         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10083         is needed.
10084         * f-lang.h (fortran_argument_convert): Declaration.
10085         (fortran_preserve_arg_pointer): Declaration.
10086         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10087
10088 2019-03-05  Tom Tromey  <tromey@adacore.com>
10089
10090         * python/py-prettyprint.c (print_string_repr): Remove #if.
10091         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10092
10093 2019-03-05  Tom Tromey  <tromey@adacore.com>
10094
10095         * target.c (the_dummy_target): Move later.  Change type to
10096         "dummy_target".
10097         (initialize_targets): Don't initialize the_dummy_target.
10098
10099 2019-03-05  Tom Tromey  <tromey@adacore.com>
10100
10101         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10102         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10103
10104 2019-03-05  Tom Tromey  <tromey@adacore.com>
10105
10106         * windows-nat.c (windows_nat_target::attach)
10107         (windows_nat_target::detach): Don't call gdb_flush.
10108         * valprint.c (generic_val_print, val_print, val_print_string):
10109         Don't call gdb_flush.
10110         * utils.c (defaulted_query): Don't call gdb_flush.
10111         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10112         * target.c (target_announce_detach): Don't call gdb_flush.
10113         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10114         * remote.c (extended_remote_target::attach): Don't call
10115         gdb_flush.
10116         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10117         * printcmd.c (do_examine): Don't call gdb_flush.
10118         (info_display_command): Don't call gdb_flush.
10119         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10120         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10121         * memattr.c (info_mem_command): Don't call gdb_flush.
10122         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10123         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10124         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10125         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10126         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10127         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10128         (gnu_nat_target::detach): Don't call gdb_flush.
10129         * f-valprint.c (f_val_print): Don't call gdb_flush.
10130         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10131         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10132         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10133         gdb_flush.
10134         * c-valprint.c (c_val_print): Don't call gdb_flush.
10135         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10136
10137 2019-03-05  Tom Tromey  <tromey@adacore.com>
10138
10139         * varobj.c (update_dynamic_varobj_children): Update.
10140         (install_default_visualizer): Use reset, not release.
10141         * value.c (set_internalvar): Update.
10142         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10143         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10144         ATTRIBUTE_UNUSED_RESULT.
10145
10146 2019-03-05  Tom Tromey  <tromey@adacore.com>
10147
10148         * remote.c (class scoped_remote_fd) <release>: Add
10149         ATTRIBUTE_UNUSED_RESULT.
10150
10151 2019-03-05  Tom Tromey  <tromey@adacore.com>
10152
10153         * macroexp.c (struct macro_buffer) <release>: Add
10154         ATTRIBUTE_UNUSED_RESULT.
10155
10156 2019-03-05  Tom Tromey  <tromey@adacore.com>
10157
10158         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10159         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10160         ATTRIBUTE_UNUSED_RESULT.
10161
10162 2019-03-05  Tom Tromey  <tromey@adacore.com>
10163
10164         * common/scoped_fd.h (class scoped_fd) <release>: Add
10165         ATTRIBUTE_UNUSED_RESULT.
10166
10167 2019-03-05  Tom Tromey  <tromey@adacore.com>
10168
10169         * parser-defs.h (struct parser_state) <release>: Add
10170         ATTRIBUTE_UNUSED_RESULT.
10171
10172 2019-03-05  Tom Tromey  <tromey@adacore.com>
10173
10174         * utils.h (class gdb_argv) <release>: Add
10175         ATTRIBUTE_UNUSED_RESULT.
10176         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10177
10178 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10179
10180         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10181         for-loop range, to avoid compiler warnings.
10182
10183         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10184         avoid compiler warnings about unused variables.
10185
10186         * NEWS: Mention end of support for native debugging on MS-Windows
10187         before XP.
10188
10189         PR gdb/24292
10190         * common/netstuff.c:
10191         * gdbserver/gdbreplay.c
10192         * gdbserver/remote-utils.c:
10193         * ser-tcp.c:
10194         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10195         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10196         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10197         'getaddrinfo' and 'freeaddrinfo' were not available before
10198         Windows XP, and mingw.org's MinGW headers by default define
10199         _WIN32_WINNT to 0x500.
10200
10201 2019-03-01  Gary Benson <gbenson@redhat.com>
10202
10203         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10204
10205 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10206             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10207
10208         PR gdb/8527
10209         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10210         set_sigint_trap, clear_sigint_trap.
10211
10212 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10213
10214         * target.c (target_detach): Clear the regcache and the
10215         frame cache.
10216
10217 2019-02-27  Pedro Alves  <palves@redhat.com>
10218
10219         * utils.c (set_screen_size): When we cap the height/width sizes,
10220         tweak the corresponding command variable to show "unlimited":
10221
10222 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10223             Pedro Alves  <palves@redhat.com>
10224
10225         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10226         before calling rl_set_screen_size.
10227
10228 2019-02-27  Tom Tromey  <tromey@adacore.com>
10229
10230         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10231         define.
10232         * python/py-value.c: Remove Python 2.4 workaround.
10233         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10234         workaround.
10235         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10236         Python 2.4 workaround.
10237         * python/python-internal.h: Remove Python 2.4 comment.
10238         (Py_ssize_t): Don't define.
10239         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10240         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10241         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10242         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10243         * python/python.c (do_start_initialization): Remove Python 2.4
10244         workaround.
10245         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10246         (print_children): Remove Python 2.4 workaround.
10247         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10248         workaround.
10249         (CHARBUFFERPROC_NAME): Remove.
10250         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10251         Python 2.4 workaround.
10252
10253 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10254
10255         * NEWS: Note minimum Python version.
10256
10257 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10258
10259         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10260         code from these functions.  Remove corresponding ifdefs.  Use
10261         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10262         Remove gotos and target of gotos.
10263         (infpy_search_memory): Likewise.
10264
10265 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10266
10267         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10268         (hppa_gdbarch_init): Don't register deleted functions with
10269         gdbarch.
10270
10271 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10272
10273         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10274         (h8300_unwind_sp): Delete.
10275         (h8300_dummy_id): Delete.
10276         (h8300_gdbarch_init): Don't register deleted functions with
10277         gdbarch.
10278
10279 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10280
10281         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10282         (ft32_unwind_pc): Delete.
10283         (ft32_unwind_sp): Delete.
10284         (ft32_gdbarch_init): Don't register deleted functions with
10285         gdbarch.
10286
10287 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10288
10289         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10290         (frv_unwind_pc): Delete.
10291         (frv_unwind_sp): Delete.
10292         (frv_gdbarch_init): Don't register deleted functions with
10293         gdbarch.
10294
10295 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10296
10297         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10298         (riscv_unwind_pc): Delete.
10299         (riscv_unwind_sp): Delete.
10300         (riscv_gdbarch_init): Don't register deleted functions with
10301         gdbarch.
10302
10303 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10304
10305         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10306         (csky_unwind_pc): Delete.
10307         (csky_unwind_sp): Delete.
10308         (csky_gdbarch_init): Don't register deleted functions with
10309         gdbarch.
10310
10311 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10312
10313         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10314         (cris_unwind_pc): Delete.
10315         (cris_unwind_sp): Delete.
10316         (cris_gdbarch_init): Don't register deleted functions with
10317         gdbarch.
10318
10319 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10320
10321         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10322         (bfin_unwind_pc): Delete.
10323         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10324
10325 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10326
10327         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10328         (arm_unwind_pc): Delete.
10329         (arm_unwind_sp): Delete.
10330         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10331
10332 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10333
10334         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10335         (arc_unwind_pc): Delete.
10336         (arc_unwind_sp): Delete.
10337         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10338
10339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10340
10341         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10342         (alpha_unwind_pc): Delete.
10343         (alpha_gdbarch_init): Don't register deleted functions with
10344         gdbarch.
10345
10346 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10347
10348         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10349         (aarch64_unwind_pc): Delete.
10350         (aarch64_unwind_sp): Delete.
10351         (aarch64_gdbarch_init): Don't register deleted functions with
10352         gdbarch.
10353
10354 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10355
10356         * gdbtypes.c (type_align): Don't consider static members when
10357         computing structure alignment.
10358
10359 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10360
10361         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10362         return 0 for other types.
10363         * arch-utils.c (default_type_align): Always return 0.
10364         * gdbarch.h: Regenerate.
10365         * gdbarch.sh (type_align): Extend comment.
10366         * gdbtypes.c (type_align): Add additional comments, always call
10367         gdbarch_type_align before applying the default rules.
10368         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10369         generic code will then apply a suitable default.
10370         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10371         types, return 0 for other types.
10372
10373 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10374
10375         * NEWS: Create a new section for the next release branch.
10376         Rename the section of the current branch, now that it has
10377         been cut.
10378
10379 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10380
10381         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10382         * version.in: Bump version to 8.3.50.DATE-git.
10383
10384 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10385
10386         * aix-thread.c (ptid_cmp): Remove unused variable.
10387         (get_signaled_thread): Likewise.
10388         (store_regs_user_thread): Likewise.
10389         (store_regs_kernel_thread): Likewise.
10390         (fetch_regs_kernel_thread): Remove shadowed variable.
10391
10392 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10393
10394         * features/riscv/32bit-cpu.xml: Add register numbers.
10395         * features/riscv/32bit-fpu.c: Regenerate.
10396         * features/riscv/32bit-fpu.xml: Add register numbers.
10397         * features/riscv/64bit-cpu.xml: Add register numbers.
10398         * features/riscv/64bit-fpu.c: Regenerate.
10399         * features/riscv/64bit-fpu.xml: Add register numbers.
10400
10401 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10402
10403         * NEWS: Mention two argument form of gdb.Value constructor.
10404         * python/py-value.c (convert_buffer_and_type_to_value): New
10405         function.
10406         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10407         Add support for handling an optional second argument.  Call
10408         convert_buffer_and_type_to_value as appropriate.
10409         * python/python-internal.h (Py_buffer_deleter): New struct.
10410         (Py_buffer_up): New typedef.
10411
10412 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10413
10414         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10415         instead of releasing ownership.
10416
10417 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10418
10419         * dwarf2read.c (open_and_init_dwp_file): Call
10420         elf_numsections instead of bfd_count_sections to initialize
10421         dwp_file->num_sections.
10422
10423 2019-02-25  Tom Tromey  <tromey@adacore.com>
10424
10425         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10426
10427 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10428
10429         * gcore.in: Add '--readnever' option when invoking GDB.
10430
10431 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10432
10433         * MAINTAINERS: Update my email address.
10434
10435 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10436
10437         * build-id.c (build_id_to_debug_bfd_1): New function.
10438         (build_id_to_debug_bfd): Look for separate debug file in
10439         sysroot.
10440
10441 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10442
10443         * gdbarch.sh: Update the copyright year range that is placed into
10444         generated files.
10445
10446 2019-02-22  Keith Seitz  <keiths@redhat.com>
10447
10448         PR symtab/23853
10449         * linespec.c (create_sals_line_offset): Search for the default
10450         symtab's filename instead of its fullname.
10451
10452 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10453
10454         * NEWS: Update style defaults.
10455
10456 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10457
10458         * main.c (captured_main_1): Disable styling in batch mode.
10459
10460 2019-02-20  Tom Tromey  <tom@tromey.com>
10461
10462         * symtab.c (symtab_symbol_info): Fix typos.
10463
10464 2019-02-20  Tom Tromey  <tromey@adacore.com>
10465
10466         * findcmd.c (_initialize_mem_search): Use upper case for
10467         metasyntactic variables.
10468
10469 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10470
10471         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10472         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10473
10474 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10475
10476         * top.h (source_file_name): Change to std::string.
10477         * top.c (source_file_name): Likewise.
10478         (command_line_input): Adjust.
10479         * cli/cli-script.c (script_from_file): Adjust.
10480
10481 2019-02-19  Tom Tromey  <tromey@adacore.com>
10482
10483         * ravenscar-thread.c
10484         (ravenscar_thread_target::update_thread_list): Don't call
10485         ada_build_task_list.
10486         * ada-lang.h (ada_build_task_list): Don't declare.
10487         * ada-tasks.c (struct ada_tasks_inferior_data)
10488         <task_list_valid_p>: Now bool.
10489         (read_known_tasks, ada_task_list_changed)
10490         (ada_tasks_invalidate_inferior_data): Update.
10491         (read_known_tasks_array): Return bool.
10492         (read_known_tasks_list): Likewise.
10493         (read_known_tasks): Return void.
10494         (ada_build_task_list): Now static.
10495
10496 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10497
10498         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10499         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10500
10501 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10502
10503         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10504         variant for ada_tasks_pspace_data_handle and
10505         ada_tasks_inferior_data_handle.
10506         (ada_tasks_pspace_data_cleanup): New function.
10507         (ada_tasks_inferior_data_cleanup): New function.
10508
10509 2019-02-17  Tom Tromey  <tom@tromey.com>
10510
10511         * macrotab.h (macro_source_fullname): Return a std::string.
10512         * macrotab.c (macro_include, check_for_redefinition)
10513         (macro_undef, macro_lookup_definition, foreach_macro)
10514         (foreach_macro_in_scope): Update.
10515         (macro_source_fullname): Return a std::string.
10516         * macrocmd.c (show_pp_source_pos): Update.
10517
10518 2019-02-17  Tom Tromey  <tom@tromey.com>
10519
10520         * macrocmd.c (show_pp_source_pos): Style the file names.
10521
10522 2019-02-17  Tom Tromey  <tom@tromey.com>
10523
10524         PR tui/24197:
10525         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10526
10527 2019-02-17  Tom Tromey  <tom@tromey.com>
10528
10529         * ada-lang.c (user_select_syms): Use filtered printing.
10530         * utils.c (wrap_style): New global.
10531         (desired_style): Remove.
10532         (emit_style_escape): Add stream parameter.
10533         (set_output_style, reset_terminal_style, prompt_for_continue):
10534         Update.
10535         (flush_wrap_buffer): Only flush gdb_stdout.
10536         (wrap_here): Set wrap_style.
10537         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10538         treat escape sequences as a character.  Change when wrap buffer is
10539         flushed.
10540         (fputs_styled): Do not set the output style when the default is
10541         requested.
10542         * ui-style.h (struct ui_file_style) <is_default>: New method.
10543         * source.c (print_source_lines_base): Emit escape sequences in one
10544         piece.
10545
10546 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10547
10548         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10549         integers and enumeration types.
10550
10551 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10552
10553         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10554         instead of lookup_symbol_in_language
10555         (do_exact_match): New function.
10556         (ada_get_symbol_name_matcher): Return do_exact_match when
10557         doing a verbatim match.
10558
10559 2019-02-15  Tom Tromey  <tromey@adacore.com>
10560
10561         * ravenscar-thread.c (ravenscar_thread_target::resume)
10562         (ravenscar_thread_target::wait): Special case wildcard requests.
10563
10564 2019-02-15  Tom Tromey  <tromey@adacore.com>
10565
10566         * ravenscar-thread.c (base_ptid): Remove.
10567         (struct ravenscar_thread_target) <close>: New method.
10568         <m_base_ptid>: New member.
10569         <update_inferior_ptid, active_task, task_is_currently_active,
10570         runtime_initialized>: Declare methods.
10571         <ravenscar_thread_target>: Add constructor.
10572         (ravenscar_thread_target::task_is_currently_active)
10573         (ravenscar_thread_target::update_inferior_ptid)
10574         (ravenscar_runtime_initialized): Rename.  Now methods.
10575         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10576         (ravenscar_thread_target::update_thread_list): Update.
10577         (ravenscar_thread_target::active_task): Now method.
10578         (ravenscar_thread_target::store_registers)
10579         (ravenscar_thread_target::prepare_to_store)
10580         (ravenscar_thread_target::prepare_to_store)
10581         (ravenscar_thread_target::mourn_inferior): Update.
10582         (ravenscar_inferior_created): Use "new" to create target.
10583         (ravenscar_thread_target::get_ada_task_ptid): Update.
10584         (_initialize_ravenscar): Don't initialize base_ptid.
10585         (ravenscar_ops): Remove global.
10586
10587 2019-02-15  Tom Tromey  <tromey@adacore.com>
10588
10589         * target.h (push_target): Declare new overload.
10590         * target.c (push_target): New overload, taking an rvalue reference.
10591         * remote.c (remote_target::open_1): Use push_target overload.
10592         * corelow.c (core_target_open): Use push_target overload.
10593
10594 2019-02-15  Tom Tromey  <tromey@adacore.com>
10595
10596         * ravenscar-thread.c (is_ravenscar_task)
10597         (ravenscar_task_is_currently_active): Return bool.
10598         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10599         (_initialize_ravenscar): Remove "(void)".
10600         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10601         Return bool.
10602
10603 2019-02-15  Tom Tromey  <tromey@adacore.com>
10604
10605         * ravenscar-thread.c (ravenscar_runtime_initializer)
10606         (has_ravenscar_runtime, get_running_thread_id)
10607         (ravenscar_thread_target::resume): Fix indentation.
10608
10609 2019-02-15  Tom Tromey  <tromey@adacore.com>
10610
10611         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10612         from ravenscar_arch_ops.
10613         (sparc_ravenscar_ops::fetch_registers)
10614         (sparc_ravenscar_ops::store_registers): Now methods.
10615         (sparc_ravenscar_prepare_to_store): Remove.
10616         (sparc_ravenscar_ops): Redefine.
10617         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10618         methods and destructor.  Remove members.
10619         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10620         (ravenscar_thread_target::store_registers)
10621         (ravenscar_thread_target::prepare_to_store): Update.
10622         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10623         Remove.
10624         (struct ppc_ravenscar_powerpc_ops): Derive from
10625         ravenscar_arch_ops.
10626         (ppc_ravenscar_powerpc_ops::fetch_registers)
10627         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10628         (ppc_ravenscar_powerpc_ops): Redefine.
10629         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10630         (ppc_ravenscar_e500_ops::fetch_registers)
10631         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10632         (ppc_ravenscar_e500_ops): Redefine.
10633         * aarch64-ravenscar-thread.c
10634         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10635         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10636         (aarch64_ravenscar_fetch_registers)
10637         (aarch64_ravenscar_store_registers): Now methods.
10638         (aarch64_ravenscar_ops): Redefine.
10639
10640 2019-02-15  Tom Tromey  <tromey@adacore.com>
10641
10642         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10643         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10644         (ravenscar_thread_target::stopped_by_watchpoint)
10645         (ravenscar_thread_target::stopped_data_address)
10646         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10647
10648 2019-02-15  Tom Tromey  <tromey@adacore.com>
10649
10650         * ravenscar-thread.c: Fix some typos.
10651
10652 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10653             Tom Tromey  <tromey@adacore.com>
10654
10655         * ada-lang.c (ada_exception_sal): Change addr_string to a
10656         std::string.
10657         (create_ada_exception_catchpoint): Update.
10658
10659 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10660             Tom Tromey  <tromey@adacore.com>
10661
10662         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10663         (bp_location_ops): Remove.
10664         (base_breakpoint_allocate_location): Update.
10665         (free_bp_location): Update.
10666         * ada-lang.c (class ada_catchpoint_location)
10667         <ada_catchpoint_location>: Remove ops parameter.
10668         (ada_catchpoint_location_dtor): Remove.
10669         (ada_catchpoint_location_ops): Remove.
10670         (allocate_location_exception): Update.
10671         * breakpoint.h (struct bp_location_ops): Remove.
10672         (class bp_location) <bp_location>: Remove bp_location_ops
10673         parameter.
10674         <~bp_location>: Add destructor.
10675         <ops>: Remove.
10676
10677 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10678             Pedro Alves  <palves@redhat.com>
10679
10680         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10681         'PATH_MAX'.
10682
10683 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10684             Samuel Thibault  <samuel.thibault@gnu.org>
10685             Thomas Schwinge  <thomas@codesourcery.com>
10686
10687         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10688         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10689
10690 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10691
10692         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10693         (check_empty): Use "const char *".
10694
10695         * gnu-nat.c (gnu_nat_target::detach): Instead of
10696         'detach_inferior (pid)' call
10697         'detach_inferior (find_inferior_pid (pid))'.
10698
10699         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10700         'nat/fork-inferior.o'.
10701         * gnu-nat.c: #include "nat/fork-inferior.h".
10702
10703         * gnu-nat.c (gnu_nat_target::detach): Instead of
10704         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10705         * gnu-nat.h: #include "inf-child.h".
10706         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10707         'i386_gnu_nat_target::fetch_registers'.
10708         (gnu_store_registers): Rename/move to
10709         'i386_gnu_nat_target::store_registers'.
10710
10711         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10712         * gnu-nat.h (mach_thread_info): New function.
10713         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10714
10715         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10716
10717 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10718
10719         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10720
10721 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10722
10723         * windows-nat.c (windows_add_thread): Add new parameter
10724         "main_thread_p" with default value set to false.  Update
10725         function documentation as well as all callers.
10726         (windows_delete_thread): Likewise.
10727         (fake_create_process): Update call to windows_add_thread.
10728         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10729         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10730         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10731         call to windows_delete_thread.
10732
10733 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10734
10735         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10736
10737 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10738
10739         * symfile.c (find_separate_debug_file): Use canonical path of
10740         sysroot with child_path instead of gdb_sysroot if it is valid.
10741
10742 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10743
10744         * symfile.c (find_separate_debug_file): Use child_path to
10745         determine if an object file is under a sysroot.
10746
10747 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10748
10749         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10750         unittests/child-path-selftests.c.
10751         * common/pathstuff.c (child_path): New function.
10752         * common/pathstuff.h (child_path): New prototype.
10753         * unittests/child-path-selftests.c: New file.
10754
10755 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10756
10757         * symfile.c (find_separate_debug_file): Look for separate debug
10758         files in debug directories under the sysroot.
10759
10760 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10761
10762         * symtab.h (struct minimal_symbol data_p): New const method.
10763         (struct minimal_symbol text_p): Likewise.
10764         * symtab.c (output_source_filename): Use file name style
10765         to print file name.
10766         (print_symbol_info): Likewise.
10767         (print_msymbol_info): Use address style to print addresses.
10768         Use function name style to print executable text symbols.
10769         (expand_symtab_containing_pc): Use data_p.
10770         (find_pc_sect_compunit_symtab): Likewise.
10771
10772 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10773
10774         * breakpoint.c (describe_other_breakpoints): Use address style
10775         to print addresses.
10776         (say_where): Likewise.
10777
10778 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10779
10780         * ada-typeprint.c (print_func_type): Print function name
10781         style to print function name.
10782         * c-typeprint.c (c_print_type_1): Likewise.
10783
10784 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10785
10786         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10787         for execve.
10788
10789 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10790
10791         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10792         type_stack.
10793
10794 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10795
10796         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10797         TYPE_CODE_REF types.
10798
10799 2019-02-08  Jim Wilson  <jimw@sifive.com>
10800
10801         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10802         (riscv_linux_fregset): New.
10803         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10804
10805 2019-02-07  Tom Tromey  <tom@tromey.com>
10806
10807         * thread.c (thread_cancel_execution_command): Update.
10808         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10809         methods.
10810         (struct thread_fsm_ops): Remove.
10811         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10812         (thread_fsm_should_stop, thread_fsm_return_value)
10813         (thread_fsm_set_finished, thread_fsm_finished_p)
10814         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10815         Don't declare.
10816         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10817         * infrun.c (clear_proceed_status_thread)
10818         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10819         (print_stop_event): Update.
10820         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10821         Add constructor.
10822         (step_command_fsm_ops): Remove.
10823         (new_step_command_fsm): Remove.
10824         (step_1): Update.
10825         (step_command_fsm::should_stop): Rename from
10826         step_command_fsm_should_stop.
10827         (step_command_fsm::clean_up): Rename from
10828         step_command_fsm_clean_up.
10829         (step_command_fsm::do_async_reply_reason): Rename from
10830         step_command_fsm_async_reply_reason.
10831         (struct until_next_fsm): Inherit from thread_fsm.  Add
10832         constructor.
10833         (until_next_fsm_ops): Remove.
10834         (new_until_next_fsm): Remove.
10835         (until_next_fsm::should_stop): Rename from
10836         until_next_fsm_should_stop.
10837         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10838         (until_next_fsm::do_async_reply_reason): Rename from
10839         until_next_fsm_async_reply_reason.
10840         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10841         constructor.  Change type of breakpoint.
10842         (finish_command_fsm_ops): Remove.
10843         (new_finish_command_fsm): Remove.
10844         (finish_command_fsm::should_stop): Rename from
10845         finish_command_fsm_should_stop.
10846         (finish_command_fsm::clean_up): Rename from
10847         finish_command_fsm_clean_up.
10848         (finish_command_fsm::return_value): Rename from
10849         finish_command_fsm_return_value.
10850         (finish_command_fsm::do_async_reply_reason): Rename from
10851         finish_command_fsm_async_reply_reason.
10852         (finish_command): Update.
10853         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10854         Add constructor.
10855         (call_thread_fsm_ops): Remove.
10856         (call_thread_fsm::call_thread_fsm): Rename from
10857         new_call_thread_fsm.
10858         (call_thread_fsm::should_stop): Rename from
10859         call_thread_fsm_should_stop.
10860         (call_thread_fsm::should_notify_stop): Rename from
10861         call_thread_fsm_should_notify_stop.
10862         (run_inferior_call, call_function_by_hand_dummy): Update.
10863         * cli/cli-interp.c (should_print_stop_to_console): Update.
10864         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10865         Add constructor.  Change type of location_breakpoint,
10866         caller_breakpoint.
10867         (until_break_fsm_ops): Remove.
10868         (new_until_break_fsm): Remove.
10869         (until_break_fsm::should_stop): Rename from
10870         until_break_fsm_should_stop.
10871         (until_break_fsm::clean_up): Rename from
10872         until_break_fsm_clean_up.
10873         (until_break_fsm::do_async_reply_reason): Rename from
10874         until_break_fsm_async_reply_reason.
10875         (until_break_command): Update.
10876         * thread-fsm.c: Remove.
10877         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10878
10879 2019-02-07  Tom Tromey  <tom@tromey.com>
10880
10881         * yy-remap.h: Add include guard.
10882         * xtensa-tdep.h: Add include guard.
10883         * xcoffread.h: Rename include guard.
10884         * varobj-iter.h: Add include guard.
10885         * tui/tui.h: Rename include guard.
10886         * tui/tui-winsource.h: Rename include guard.
10887         * tui/tui-wingeneral.h: Rename include guard.
10888         * tui/tui-windata.h: Rename include guard.
10889         * tui/tui-win.h: Rename include guard.
10890         * tui/tui-stack.h: Rename include guard.
10891         * tui/tui-source.h: Rename include guard.
10892         * tui/tui-regs.h: Rename include guard.
10893         * tui/tui-out.h: Rename include guard.
10894         * tui/tui-layout.h: Rename include guard.
10895         * tui/tui-io.h: Rename include guard.
10896         * tui/tui-hooks.h: Rename include guard.
10897         * tui/tui-file.h: Rename include guard.
10898         * tui/tui-disasm.h: Rename include guard.
10899         * tui/tui-data.h: Rename include guard.
10900         * tui/tui-command.h: Rename include guard.
10901         * tic6x-tdep.h: Add include guard.
10902         * target/waitstatus.h: Rename include guard.
10903         * target/wait.h: Rename include guard.
10904         * target/target.h: Rename include guard.
10905         * target/resume.h: Rename include guard.
10906         * target-float.h: Rename include guard.
10907         * stabsread.h: Add include guard.
10908         * rs6000-tdep.h: Add include guard.
10909         * riscv-fbsd-tdep.h: Add include guard.
10910         * regformats/regdef.h: Rename include guard.
10911         * record.h: Rename include guard.
10912         * python/python.h: Rename include guard.
10913         * python/python-internal.h: Rename include guard.
10914         * python/py-stopevent.h: Rename include guard.
10915         * python/py-ref.h: Rename include guard.
10916         * python/py-record.h: Rename include guard.
10917         * python/py-record-full.h: Rename include guard.
10918         * python/py-record-btrace.h: Rename include guard.
10919         * python/py-instruction.h: Rename include guard.
10920         * python/py-events.h: Rename include guard.
10921         * python/py-event.h: Rename include guard.
10922         * procfs.h: Add include guard.
10923         * proc-utils.h: Add include guard.
10924         * p-lang.h: Add include guard.
10925         * or1k-tdep.h: Rename include guard.
10926         * observable.h: Rename include guard.
10927         * nto-tdep.h: Rename include guard.
10928         * nat/x86-linux.h: Rename include guard.
10929         * nat/x86-linux-dregs.h: Rename include guard.
10930         * nat/x86-gcc-cpuid.h: Add include guard.
10931         * nat/x86-dregs.h: Rename include guard.
10932         * nat/x86-cpuid.h: Rename include guard.
10933         * nat/ppc-linux.h: Rename include guard.
10934         * nat/mips-linux-watch.h: Rename include guard.
10935         * nat/linux-waitpid.h: Rename include guard.
10936         * nat/linux-ptrace.h: Rename include guard.
10937         * nat/linux-procfs.h: Rename include guard.
10938         * nat/linux-osdata.h: Rename include guard.
10939         * nat/linux-nat.h: Rename include guard.
10940         * nat/linux-namespaces.h: Rename include guard.
10941         * nat/linux-btrace.h: Rename include guard.
10942         * nat/glibc_thread_db.h: Rename include guard.
10943         * nat/gdb_thread_db.h: Rename include guard.
10944         * nat/gdb_ptrace.h: Rename include guard.
10945         * nat/fork-inferior.h: Rename include guard.
10946         * nat/amd64-linux-siginfo.h: Rename include guard.
10947         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10948         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10949         * nat/aarch64-linux.h: Rename include guard.
10950         * nat/aarch64-linux-hw-point.h: Rename include guard.
10951         * mn10300-tdep.h: Add include guard.
10952         * mips-linux-tdep.h: Add include guard.
10953         * mi/mi-parse.h: Rename include guard.
10954         * mi/mi-out.h: Rename include guard.
10955         * mi/mi-main.h: Rename include guard.
10956         * mi/mi-interp.h: Rename include guard.
10957         * mi/mi-getopt.h: Rename include guard.
10958         * mi/mi-console.h: Rename include guard.
10959         * mi/mi-common.h: Rename include guard.
10960         * mi/mi-cmds.h: Rename include guard.
10961         * mi/mi-cmd-break.h: Rename include guard.
10962         * m2-lang.h: Add include guard.
10963         * location.h: Rename include guard.
10964         * linux-record.h: Rename include guard.
10965         * linux-nat.h: Add include guard.
10966         * linux-fork.h: Add include guard.
10967         * i386-darwin-tdep.h: Rename include guard.
10968         * hppa-linux-offsets.h: Add include guard.
10969         * guile/guile.h: Rename include guard.
10970         * guile/guile-internal.h: Rename include guard.
10971         * gnu-nat.h: Rename include guard.
10972         * gdb-stabs.h: Rename include guard.
10973         * frv-tdep.h: Add include guard.
10974         * f-lang.h: Add include guard.
10975         * event-loop.h: Add include guard.
10976         * darwin-nat.h: Rename include guard.
10977         * cp-abi.h: Rename include guard.
10978         * config/sparc/nm-sol2.h: Rename include guard.
10979         * config/nm-nto.h: Rename include guard.
10980         * config/nm-linux.h: Add include guard.
10981         * config/i386/nm-i386gnu.h: Rename include guard.
10982         * config/djgpp/nl_types.h: Rename include guard.
10983         * config/djgpp/langinfo.h: Rename include guard.
10984         * compile/gcc-cp-plugin.h: Add include guard.
10985         * compile/gcc-c-plugin.h: Add include guard.
10986         * compile/compile.h: Rename include guard.
10987         * compile/compile-object-run.h: Rename include guard.
10988         * compile/compile-object-load.h: Rename include guard.
10989         * compile/compile-internal.h: Rename include guard.
10990         * compile/compile-cplus.h: Rename include guard.
10991         * compile/compile-c.h: Rename include guard.
10992         * common/xml-utils.h: Rename include guard.
10993         * common/x86-xstate.h: Rename include guard.
10994         * common/version.h: Rename include guard.
10995         * common/vec.h: Rename include guard.
10996         * common/tdesc.h: Rename include guard.
10997         * common/selftest.h: Rename include guard.
10998         * common/scoped_restore.h: Rename include guard.
10999         * common/scoped_mmap.h: Rename include guard.
11000         * common/scoped_fd.h: Rename include guard.
11001         * common/safe-iterator.h: Rename include guard.
11002         * common/run-time-clock.h: Rename include guard.
11003         * common/refcounted-object.h: Rename include guard.
11004         * common/queue.h: Rename include guard.
11005         * common/ptid.h: Rename include guard.
11006         * common/print-utils.h: Rename include guard.
11007         * common/preprocessor.h: Rename include guard.
11008         * common/pathstuff.h: Rename include guard.
11009         * common/observable.h: Rename include guard.
11010         * common/netstuff.h: Rename include guard.
11011         * common/job-control.h: Rename include guard.
11012         * common/host-defs.h: Rename include guard.
11013         * common/gdb_wait.h: Rename include guard.
11014         * common/gdb_vecs.h: Rename include guard.
11015         * common/gdb_unlinker.h: Rename include guard.
11016         * common/gdb_unique_ptr.h: Rename include guard.
11017         * common/gdb_tilde_expand.h: Rename include guard.
11018         * common/gdb_sys_time.h: Rename include guard.
11019         * common/gdb_string_view.h: Rename include guard.
11020         * common/gdb_splay_tree.h: Rename include guard.
11021         * common/gdb_setjmp.h: Rename include guard.
11022         * common/gdb_ref_ptr.h: Rename include guard.
11023         * common/gdb_optional.h: Rename include guard.
11024         * common/gdb_locale.h: Rename include guard.
11025         * common/gdb_assert.h: Rename include guard.
11026         * common/filtered-iterator.h: Rename include guard.
11027         * common/filestuff.h: Rename include guard.
11028         * common/fileio.h: Rename include guard.
11029         * common/environ.h: Rename include guard.
11030         * common/common-utils.h: Rename include guard.
11031         * common/common-types.h: Rename include guard.
11032         * common/common-regcache.h: Rename include guard.
11033         * common/common-inferior.h: Rename include guard.
11034         * common/common-gdbthread.h: Rename include guard.
11035         * common/common-exceptions.h: Rename include guard.
11036         * common/common-defs.h: Rename include guard.
11037         * common/common-debug.h: Rename include guard.
11038         * common/cleanups.h: Rename include guard.
11039         * common/buffer.h: Rename include guard.
11040         * common/btrace-common.h: Rename include guard.
11041         * common/break-common.h: Rename include guard.
11042         * cli/cli-utils.h: Rename include guard.
11043         * cli/cli-style.h: Rename include guard.
11044         * cli/cli-setshow.h: Rename include guard.
11045         * cli/cli-script.h: Rename include guard.
11046         * cli/cli-interp.h: Rename include guard.
11047         * cli/cli-decode.h: Rename include guard.
11048         * cli/cli-cmds.h: Rename include guard.
11049         * charset-list.h: Add include guard.
11050         * buildsym-legacy.h: Rename include guard.
11051         * bfin-tdep.h: Add include guard.
11052         * ax.h: Rename include guard.
11053         * arm-linux-tdep.h: Add include guard.
11054         * arm-fbsd-tdep.h: Add include guard.
11055         * arch/xtensa.h: Rename include guard.
11056         * arch/tic6x.h: Add include guard.
11057         * arch/i386.h: Add include guard.
11058         * arch/arm.h: Rename include guard.
11059         * arch/arm-linux.h: Rename include guard.
11060         * arch/arm-get-next-pcs.h: Rename include guard.
11061         * arch/amd64.h: Add include guard.
11062         * arch/aarch64-insn.h: Rename include guard.
11063         * arch-utils.h: Rename include guard.
11064         * annotate.h: Add include guard.
11065         * amd64-darwin-tdep.h: Rename include guard.
11066         * aarch64-linux-tdep.h: Add include guard.
11067         * aarch64-fbsd-tdep.h: Add include guard.
11068         * aarch32-linux-nat.h: Add include guard.
11069
11070 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11071
11072         * macrotab.c (macro_define_internal): New function that
11073         factorizes macro_define_object_internal and macro_define_function
11074         code.
11075         (macro_define_object_internal): Use macro_define_internal.
11076         (macro_define_function): Likewise.
11077
11078 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11079
11080         * macrocmd.c (extract_identifier): Return
11081         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11082         callers.
11083
11084 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11085
11086         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11087
11088 2019-02-05  Tom Tromey  <tom@tromey.com>
11089
11090         * target.c (target_stack::unpush): Move assertion earlier.
11091
11092 2019-01-30  Tom Tromey  <tom@tromey.com>
11093
11094         PR python/23615:
11095         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11096         (gdbpy_parse_and_eval): Likewise.
11097         * python/python-internal.h (gdbpy_allow_threads): New class.
11098
11099 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11100
11101         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11102         (aarch64_fbsd_fpregmap): Move earlier.
11103         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11104         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11105         instead of individual calls to trad_frame_set_reg_addr.
11106         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11107         earlier.
11108         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11109         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11110         instead of individual calls to trad_frame_set_reg_addr.
11111
11112 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11113
11114         * CONTRIBUTE: Replace contribution list with wiki link.
11115
11116 2019-01-25  Tom Tromey  <tom@tromey.com>
11117
11118         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11119
11120 2019-01-25  Tom Tromey  <tom@tromey.com>
11121
11122         * xtensa-linux-nat.c: Fix common/ includes.
11123         * xml-support.h: Fix common/ includes.
11124         * xml-support.c: Fix common/ includes.
11125         * x86-linux-nat.c: Fix common/ includes.
11126         * windows-nat.c: Fix common/ includes.
11127         * varobj.h: Fix common/ includes.
11128         * varobj.c: Fix common/ includes.
11129         * value.c: Fix common/ includes.
11130         * valops.c: Fix common/ includes.
11131         * utils.c: Fix common/ includes.
11132         * unittests/xml-utils-selftests.c: Fix common/ includes.
11133         * unittests/utils-selftests.c: Fix common/ includes.
11134         * unittests/unpack-selftests.c: Fix common/ includes.
11135         * unittests/tracepoint-selftests.c: Fix common/ includes.
11136         * unittests/style-selftests.c: Fix common/ includes.
11137         * unittests/string_view-selftests.c: Fix common/ includes.
11138         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11139         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11140         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11141         * unittests/rsp-low-selftests.c: Fix common/ includes.
11142         * unittests/parse-connection-spec-selftests.c: Fix common/
11143         includes.
11144         * unittests/optional-selftests.c: Fix common/ includes.
11145         * unittests/offset-type-selftests.c: Fix common/ includes.
11146         * unittests/observable-selftests.c: Fix common/ includes.
11147         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11148         * unittests/memrange-selftests.c: Fix common/ includes.
11149         * unittests/memory-map-selftests.c: Fix common/ includes.
11150         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11151         * unittests/function-view-selftests.c: Fix common/ includes.
11152         * unittests/environ-selftests.c: Fix common/ includes.
11153         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11154         * unittests/common-utils-selftests.c: Fix common/ includes.
11155         * unittests/cli-utils-selftests.c: Fix common/ includes.
11156         * unittests/array-view-selftests.c: Fix common/ includes.
11157         * ui-file.c: Fix common/ includes.
11158         * tui/tui-io.c: Fix common/ includes.
11159         * tracepoint.h: Fix common/ includes.
11160         * tracepoint.c: Fix common/ includes.
11161         * tracefile-tfile.c: Fix common/ includes.
11162         * top.h: Fix common/ includes.
11163         * top.c: Fix common/ includes.
11164         * thread.c: Fix common/ includes.
11165         * target/waitstatus.h: Fix common/ includes.
11166         * target/waitstatus.c: Fix common/ includes.
11167         * target.h: Fix common/ includes.
11168         * target.c: Fix common/ includes.
11169         * target-memory.c: Fix common/ includes.
11170         * target-descriptions.c: Fix common/ includes.
11171         * symtab.h: Fix common/ includes.
11172         * symfile.c: Fix common/ includes.
11173         * stap-probe.c: Fix common/ includes.
11174         * spu-linux-nat.c: Fix common/ includes.
11175         * sparc-nat.c: Fix common/ includes.
11176         * source.c: Fix common/ includes.
11177         * solib.c: Fix common/ includes.
11178         * solib-target.c: Fix common/ includes.
11179         * ser-unix.c: Fix common/ includes.
11180         * ser-tcp.c: Fix common/ includes.
11181         * ser-pipe.c: Fix common/ includes.
11182         * ser-base.c: Fix common/ includes.
11183         * selftest-arch.c: Fix common/ includes.
11184         * s12z-tdep.c: Fix common/ includes.
11185         * rust-exp.y: Fix common/ includes.
11186         * rs6000-aix-tdep.c: Fix common/ includes.
11187         * riscv-tdep.c: Fix common/ includes.
11188         * remote.c: Fix common/ includes.
11189         * remote-notif.h: Fix common/ includes.
11190         * remote-fileio.h: Fix common/ includes.
11191         * remote-fileio.c: Fix common/ includes.
11192         * regcache.h: Fix common/ includes.
11193         * regcache.c: Fix common/ includes.
11194         * record-btrace.c: Fix common/ includes.
11195         * python/python.c: Fix common/ includes.
11196         * python/py-type.c: Fix common/ includes.
11197         * python/py-inferior.c: Fix common/ includes.
11198         * progspace.h: Fix common/ includes.
11199         * producer.c: Fix common/ includes.
11200         * procfs.c: Fix common/ includes.
11201         * proc-api.c: Fix common/ includes.
11202         * printcmd.c: Fix common/ includes.
11203         * ppc-linux-nat.c: Fix common/ includes.
11204         * parser-defs.h: Fix common/ includes.
11205         * osdata.c: Fix common/ includes.
11206         * obsd-nat.c: Fix common/ includes.
11207         * nat/x86-linux.c: Fix common/ includes.
11208         * nat/x86-linux-dregs.c: Fix common/ includes.
11209         * nat/x86-dregs.h: Fix common/ includes.
11210         * nat/x86-dregs.c: Fix common/ includes.
11211         * nat/ppc-linux.c: Fix common/ includes.
11212         * nat/mips-linux-watch.h: Fix common/ includes.
11213         * nat/mips-linux-watch.c: Fix common/ includes.
11214         * nat/linux-waitpid.c: Fix common/ includes.
11215         * nat/linux-ptrace.h: Fix common/ includes.
11216         * nat/linux-ptrace.c: Fix common/ includes.
11217         * nat/linux-procfs.c: Fix common/ includes.
11218         * nat/linux-personality.c: Fix common/ includes.
11219         * nat/linux-osdata.c: Fix common/ includes.
11220         * nat/linux-namespaces.c: Fix common/ includes.
11221         * nat/linux-btrace.h: Fix common/ includes.
11222         * nat/linux-btrace.c: Fix common/ includes.
11223         * nat/fork-inferior.c: Fix common/ includes.
11224         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11225         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11226         * nat/aarch64-linux.c: Fix common/ includes.
11227         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11228         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11229         * namespace.h: Fix common/ includes.
11230         * mips-linux-tdep.c: Fix common/ includes.
11231         * minsyms.c: Fix common/ includes.
11232         * mi/mi-parse.h: Fix common/ includes.
11233         * mi/mi-main.c: Fix common/ includes.
11234         * mi/mi-cmd-env.c: Fix common/ includes.
11235         * memrange.h: Fix common/ includes.
11236         * memattr.c: Fix common/ includes.
11237         * maint.h: Fix common/ includes.
11238         * maint.c: Fix common/ includes.
11239         * main.c: Fix common/ includes.
11240         * machoread.c: Fix common/ includes.
11241         * location.c: Fix common/ includes.
11242         * linux-thread-db.c: Fix common/ includes.
11243         * linux-nat.c: Fix common/ includes.
11244         * linux-fork.c: Fix common/ includes.
11245         * inline-frame.c: Fix common/ includes.
11246         * infrun.c: Fix common/ includes.
11247         * inflow.c: Fix common/ includes.
11248         * inferior.h: Fix common/ includes.
11249         * inferior.c: Fix common/ includes.
11250         * infcmd.c: Fix common/ includes.
11251         * inf-ptrace.c: Fix common/ includes.
11252         * inf-child.c: Fix common/ includes.
11253         * ia64-linux-nat.c: Fix common/ includes.
11254         * i387-tdep.c: Fix common/ includes.
11255         * i386-tdep.c: Fix common/ includes.
11256         * i386-linux-tdep.c: Fix common/ includes.
11257         * i386-linux-nat.c: Fix common/ includes.
11258         * i386-go32-tdep.c: Fix common/ includes.
11259         * i386-fbsd-tdep.c: Fix common/ includes.
11260         * i386-fbsd-nat.c: Fix common/ includes.
11261         * guile/scm-type.c: Fix common/ includes.
11262         * guile/guile.c: Fix common/ includes.
11263         * go32-nat.c: Fix common/ includes.
11264         * gnu-nat.c: Fix common/ includes.
11265         * gdbthread.h: Fix common/ includes.
11266         * gdbarch-selftests.c: Fix common/ includes.
11267         * gdb_usleep.c: Fix common/ includes.
11268         * gdb_select.h: Fix common/ includes.
11269         * gdb_bfd.c: Fix common/ includes.
11270         * gcore.c: Fix common/ includes.
11271         * fork-child.c: Fix common/ includes.
11272         * findvar.c: Fix common/ includes.
11273         * fbsd-nat.c: Fix common/ includes.
11274         * event-top.c: Fix common/ includes.
11275         * event-loop.c: Fix common/ includes.
11276         * dwarf2read.c: Fix common/ includes.
11277         * dwarf2loc.c: Fix common/ includes.
11278         * dwarf2-frame.c: Fix common/ includes.
11279         * dwarf-index-cache.c: Fix common/ includes.
11280         * dtrace-probe.c: Fix common/ includes.
11281         * disasm-selftests.c: Fix common/ includes.
11282         * defs.h: Fix common/ includes.
11283         * csky-tdep.c: Fix common/ includes.
11284         * cp-valprint.c: Fix common/ includes.
11285         * cp-support.h: Fix common/ includes.
11286         * cp-support.c: Fix common/ includes.
11287         * corelow.c: Fix common/ includes.
11288         * completer.h: Fix common/ includes.
11289         * completer.c: Fix common/ includes.
11290         * compile/compile.c: Fix common/ includes.
11291         * compile/compile-loc2c.c: Fix common/ includes.
11292         * compile/compile-cplus-types.c: Fix common/ includes.
11293         * compile/compile-cplus-symbols.c: Fix common/ includes.
11294         * command.h: Fix common/ includes.
11295         * cli/cli-dump.c: Fix common/ includes.
11296         * cli/cli-cmds.c: Fix common/ includes.
11297         * charset.c: Fix common/ includes.
11298         * build-id.c: Fix common/ includes.
11299         * btrace.h: Fix common/ includes.
11300         * btrace.c: Fix common/ includes.
11301         * breakpoint.h: Fix common/ includes.
11302         * breakpoint.c: Fix common/ includes.
11303         * ax.h:
11304         (enum agent_op): Fix common/ includes.
11305         * ax-general.c (struct aop_map): Fix common/ includes.
11306         * ax-gdb.c: Fix common/ includes.
11307         * auxv.c: Fix common/ includes.
11308         * auto-load.c: Fix common/ includes.
11309         * arm-tdep.c: Fix common/ includes.
11310         * arch/riscv.c: Fix common/ includes.
11311         * arch/ppc-linux-common.c: Fix common/ includes.
11312         * arch/i386.c: Fix common/ includes.
11313         * arch/arm.c: Fix common/ includes.
11314         * arch/arm-linux.c: Fix common/ includes.
11315         * arch/arm-get-next-pcs.c: Fix common/ includes.
11316         * arch/amd64.c: Fix common/ includes.
11317         * arch/aarch64.c: Fix common/ includes.
11318         * arch/aarch64-insn.c: Fix common/ includes.
11319         * arch-utils.c: Fix common/ includes.
11320         * amd64-windows-tdep.c: Fix common/ includes.
11321         * amd64-tdep.c: Fix common/ includes.
11322         * amd64-sol2-tdep.c: Fix common/ includes.
11323         * amd64-obsd-tdep.c: Fix common/ includes.
11324         * amd64-nbsd-tdep.c: Fix common/ includes.
11325         * amd64-linux-tdep.c: Fix common/ includes.
11326         * amd64-linux-nat.c: Fix common/ includes.
11327         * amd64-fbsd-tdep.c: Fix common/ includes.
11328         * amd64-fbsd-nat.c: Fix common/ includes.
11329         * amd64-dicos-tdep.c: Fix common/ includes.
11330         * amd64-darwin-tdep.c: Fix common/ includes.
11331         * agent.c: Fix common/ includes.
11332         * ada-lang.h: Fix common/ includes.
11333         * ada-lang.c: Fix common/ includes.
11334         * aarch64-tdep.c: Fix common/ includes.
11335
11336 2019-01-25  Tom Tromey  <tom@tromey.com>
11337
11338         * common/create-version.sh: Use common/version.h.
11339
11340 2019-01-24  Pedro Alves  <palves@redhat.com>
11341
11342         * infrun.c (signal_stop, signal_print, signal_program)
11343         (signal_catch, signal_pass): Now arrays instead of pointers.
11344         (update_signals_program_target, do_target_resume)
11345         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11346         * linux-nat.c (linux_nat_target::pass_signals)
11347         (linux_nat_target::create_inferior, linux_nat_target::attach):
11348         Adjust.
11349         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11350         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11351         * procfs.c (procfs_target::pass_signals): Adjust.
11352         * record-full.c (record_full_target::resume): Adjust.
11353         * remote.c (remote_target::pass_signals)
11354         (remote_target::program_signals): Adjust.
11355         * target-debug.h (target_debug_print_signals): Now takes a
11356         gdb::array_view as parameter.  Adjust.
11357         * target.h (target_ops) <pass_signals, program_signals>: Replace
11358         pointer and length parameters with gdb::array_view.
11359         (target_pass_signals, target_program_signals): Likewise.
11360         * target-delegates.c: Regenerate.
11361
11362 2019-01-24  Pedro Alves  <palves@redhat.com>
11363
11364         * common/forward-scope-exit.h
11365         (forward_scope_exit::forward_scope_exit): Pass arguments to
11366         m_bind_function directly, instead of creating a std::bind and
11367         copying that.
11368
11369 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11370
11371         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11372         for static members.
11373         (pass_in_v_vfp_candidate): Likewise.
11374
11375 2019-01-23  Tom Tromey  <tom@tromey.com>
11376             Pedro Alves  <palves@redhat.com>
11377
11378         * regcache.c (class regcache_invalidator): Remove.
11379         (regcache::raw_write): Use make_scope_exit.
11380
11381 2019-01-23  Tom Tromey  <tom@tromey.com>
11382
11383         * ui-out.h (class ui_out_emit_type): Update comment.
11384
11385 2019-01-23  Tom Tromey  <tom@tromey.com>
11386
11387         * infrun.c (fetch_inferior_event): Update comment.
11388
11389 2019-01-23  Tom Tromey  <tom@tromey.com>
11390             Pedro Alves  <palves@redhat.com>
11391
11392         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11393         parameter.
11394         (fetch_inferior_event): Use SCOPE_EXIT.
11395
11396
11397 2019-01-23  Tom Tromey  <tom@tromey.com>
11398             Pedro Alves  <palves@redhat.com>
11399
11400         * infrun.c (disable_thread_events): Delete.
11401         (stop_all_threads): Use SCOPE_EXIT.
11402
11403 2019-01-23  Tom Tromey  <tom@tromey.com>
11404             Pedro Alves  <palves@redhat.com>
11405
11406         * symfile.c: Include forward-scope-exit.h.
11407         (clear_symtab_users_cleanup): Replace forward declaration with
11408         a FORWARD_SCOPE_EXIT.
11409         (syms_from_objfile_1): Use the forward_scope_exit and
11410         gdb::optional instead of cleanup_function.
11411         (reread_symbols): Use the forward_scope_exit instead of
11412         cleanup_function.
11413         (clear_symtab_users_cleanup): Remove function.
11414
11415 2019-01-23  Tom Tromey  <tom@tromey.com>
11416             Pedro Alves  <palves@redhat.com>
11417
11418         * linux-nat.c: Include scope-exit.h.
11419         (cleanup_target_stop): Remove.
11420         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11421         SCOPE_EXIT.
11422
11423 2019-01-23  Tom Tromey  <tom@tromey.com>
11424             Pedro Alves  <palves@redhat.com>
11425
11426         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11427         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11428
11429 2019-01-23  Tom Tromey  <tom@tromey.com>
11430             Andrew Burgess  <andrew.burgess@embecosm.com>
11431             Pedro Alves  <palves@redhat.com>
11432
11433         * infrun.c (fetch_inferior_event): Use scope_exit.
11434         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11435         * top.c (execute_command): Use scope_exit.
11436         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11437         * utils.c (do_bpstat_clear_actions_cleanup)
11438         (make_bpstat_clear_actions_cleanup): Remove.
11439
11440 2019-01-23  Tom Tromey  <tom@tromey.com>
11441             Pedro Alves  <palves@redhat.com>
11442
11443         * infrun.c: Include "common/scope-exit.h"
11444         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11445         (wait_for_inferior): Use SCOPE_EXIT.
11446         (fetch_inferior_event): Use scope_exit.
11447
11448 2019-01-23  Tom Tromey  <tom@tromey.com>
11449             Pedro Alves  <palves@redhat.com>
11450
11451         * breakpoint.c (create_breakpoint): Remove cleanup.
11452
11453 2019-01-23  Tom Tromey  <tom@tromey.com>
11454             Andrew Burgess  <andrew.burgess@embecosm.com>
11455             Pedro Alves  <palves@redhat.com>
11456
11457 2019-01-23  Pedro Alves  <palves@redhat.com>
11458
11459         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11460
11461 2019-01-23  Pedro Alves  <palves@redhat.com>
11462             Andrew Burgess  <andrew.burgess@embecosm.com>
11463
11464         * gdbthread.h: Include "common/forward-scope-exit.h".
11465         (scoped_finish_thread_state): Redefine custom class in terms of
11466         forward_scope_exit.
11467
11468 2019-01-23  Pedro Alves  <palves@redhat.com>
11469             Andrew Burgess  <andrew.burgess@embecosm.com>
11470
11471         * common/forward-scope-exit.h: New file.
11472
11473 2019-01-23  Pedro Alves  <palves@redhat.com>
11474             Andrew Burgess  <andrew.burgess@embecosm.com>
11475             Tom Tromey  <tom@tromey.com>
11476
11477         * common/scope-exit.h: New file.
11478
11479 2019-01-23  Pedro Alves  <palves@redhat.com>
11480
11481         * common/preprocessor.h (ESC): Rename to ...
11482         (ESC_PARENS): ... this.
11483         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11484         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11485
11486 2019-01-23  Tom Tromey  <tom@tromey.com>
11487
11488         * language.h (class scoped_switch_to_sym_language_if_auto):
11489         Initialize m_lang in both cases.
11490
11491 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11492
11493         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11494         with XCNEW.
11495
11496 2019-01-22  Tom Tromey  <tom@tromey.com>
11497
11498         * corelow.c: Do not include sys/file.h.
11499
11500 2019-01-22  Tom Tromey  <tom@tromey.com>
11501
11502         * tui/tui-wingeneral.h: Include gdb_curses.h.
11503
11504 2019-01-22  Tom Tromey  <tom@tromey.com>
11505
11506         * source-cache.h (class source_cache) <get_source_lines,
11507         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11508
11509 2019-01-22  Tom Tromey  <tom@tromey.com>
11510
11511         * remote-fileio.h (struct remote_target): Declare.
11512
11513 2019-01-22  Tom Tromey  <tom@tromey.com>
11514
11515         * python/py-arch.c: Do not include py-ref.h.
11516         * python/py-bpevent.c: Do not include py-ref.h.
11517         * python/py-cmd.c: Do not include py-ref.h.
11518         * python/py-continueevent.c: Do not include py-ref.h.
11519         * python/py-event.h: Do not include py-ref.h.
11520         * python/py-evtregistry.c: Do not include py-ref.h.
11521         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11522         * python/py-frame.c: Do not include py-ref.h.
11523         * python/py-framefilter.c: Do not include py-ref.h.
11524         * python/py-function.c: Do not include py-ref.h.
11525         * python/py-infevents.c: Do not include py-ref.h.
11526         * python/py-linetable.c: Do not include py-ref.h.
11527         * python/py-objfile.c: Do not include py-ref.h.
11528         * python/py-param.c: Do not include py-ref.h.
11529         * python/py-prettyprint.c: Do not include py-ref.h.
11530         * python/py-progspace.c: Do not include py-ref.h.
11531         * python/py-symbol.c: Do not include py-ref.h.
11532         * python/py-symtab.c: Do not include py-ref.h.
11533         * python/py-type.c: Do not include py-ref.h.
11534         * python/py-unwind.c: Do not include py-ref.h.
11535         * python/py-utils.c: Do not include py-ref.h.
11536         * python/py-value.c: Do not include py-ref.h.
11537         * python/py-varobj.c: Do not include py-ref.h.
11538         * python/py-xmethods.c: Do not include py-ref.h.
11539         * python/python.c: Do not include py-ref.h.
11540         * varobj.c: Do not include py-ref.h.
11541
11542 2019-01-22  Tom Tromey  <tom@tromey.com>
11543
11544         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11545         keyword for bcache.
11546
11547 2019-01-22  Tom Tromey  <tom@tromey.com>
11548
11549         * compile/compile-cplus-types.c: Remove a comment by #include.
11550
11551 2019-01-22  Tom Tromey  <tom@tromey.com>
11552
11553         * compile/gcc-c-plugin.h: Include compile-internal.h.
11554
11555 2019-01-22  Tom Tromey  <tom@tromey.com>
11556
11557         * stabsread.c (EXTERN): Do not define.
11558         (symnum, next_symbol_text_func, processing_gcc_compilation)
11559         (within_function, global_sym_chain, global_stabs)
11560         (previous_stab_code, this_object_header_files)
11561         (n_this_object_header_files)
11562         (n_allocated_this_object_header_files): Define.
11563         * stabsread.h (EXTERN): Never define.  Use "extern".
11564
11565 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11566
11567         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11568         history_value.
11569
11570 2019-01-21  Tom Tromey  <tom@tromey.com>
11571
11572         * ui-out.c: Fix includes.
11573         * tui/tui-source.c: Fix includes.
11574         * target.c: Fix includes.
11575         * remote.c: Fix includes.
11576         * regcache.c: Fix includes.
11577         * python/py-block.c: Fix includes.
11578         * printcmd.c: Fix includes.
11579         * or1k-tdep.c: Fix includes.
11580         * mi/mi-main.c: Fix includes.
11581         * m32r-tdep.c: Fix includes.
11582         * csky-tdep.c: Fix includes.
11583         * compile/compile-cplus-types.c: Fix includes.
11584         * cli/cli-interp.c: Fix includes.
11585
11586 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11587
11588         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11589         for padding.
11590
11591 2019-01-16  Tom Tromey  <tom@tromey.com>
11592
11593         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11594         earlier.
11595         (struct objfile) <msymbols_range>: Move from top level.
11596         <msymbols>: New method.
11597         (class objfile_msymbols): Remove.
11598         * symtab.c (default_collect_symbol_completion_matches_break_on):
11599         Update.
11600         * symmisc.c (dump_msymbols): Update.
11601         * stabsread.c (scan_file_globals): Update.
11602         * objc-lang.c (info_selectors_command, info_classes_command)
11603         (find_methods): Update.
11604         * minsyms.c (find_solib_trampoline_target): Update.
11605         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11606         * coffread.c (coff_symfile_read): Update.
11607         * ada-lang.c (ada_lookup_simple_minsym)
11608         (ada_collect_symbol_completion_matches): Update.
11609
11610 2019-01-16  Tom Tromey  <tom@tromey.com>
11611
11612         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11613         type.  Remove no-argument constructor.
11614         <iterator::operator++>: Simplify.
11615         <begin>: Update.
11616         <end>: Use minimal_symbol_count.
11617
11618 2019-01-16  Tom Tromey  <tom@tromey.com>
11619
11620         * objfiles.h (struct objfile) <psymtabs>: New method.
11621         (class objfile_psymtabs): Remove.
11622         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11623         typedef.
11624         <range>: New method.
11625         (require_partial_symbols): Change return type.
11626         * psymtab.c (require_partial_symbols)
11627         (psym_expand_symtabs_matching): Update.
11628         * mdebugread.c (parse_partial_symbols): Update.
11629         * dbxread.c (dbx_end_psymtab): Update.
11630
11631 2019-01-15  Tom Tromey  <tom@tromey.com>
11632
11633         * symtab.c (lookup_objfile_from_block)
11634         (lookup_symbol_in_objfile_symtabs)
11635         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11636         (find_line_symtab, info_sources_command)
11637         (default_collect_symbol_completion_matches_break_on)
11638         (make_source_files_completion_list): Update.
11639         * symmisc.c (print_objfile_statistics, dump_objfile)
11640         (maintenance_print_symbols, maintenance_info_symtabs)
11641         (maintenance_check_symtabs, maintenance_info_line_tables):
11642         Update.
11643         * source.c (select_source_symtab)
11644         (forget_cached_source_info_for_objfile): Update.
11645         * objfiles.h (class objfile_compunits): Remove.
11646         (struct objfile) <compunits_range>: New typedef.
11647         (compunits): New method.
11648         * objfiles.c (objfile_relocate1): Update.
11649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11650         * maint.c (count_symtabs_and_blocks): Update.
11651         * linespec.c (iterate_over_all_matching_symtabs): Update.
11652         * cp-support.c (add_symbol_overload_list_qualified): Update.
11653         * coffread.c (coff_symtab_read): Update.
11654         * ada-lang.c (add_nonlocal_symbols)
11655         (ada_collect_symbol_completion_matches)
11656         (ada_add_global_exceptions): Update.
11657
11658 2019-01-15  Tom Tromey  <tom@tromey.com>
11659
11660         * progspace.h (program_space) <objfiles_safe_range>: New
11661         typedef.
11662         <objfiles_safe>: New method.
11663         * objfiles.h (class all_objfiles_safe): Remove.
11664         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11665         * jit.c (jit_inferior_exit_hook): Update.
11666
11667 2019-01-17  Tom Tromey  <tom@tromey.com>
11668
11669         * progspace.h (program_space) <objfiles_range>: New typedef.
11670         <objfiles>: New method.
11671         <objfiles_head>: Rename from objfiles.
11672         (object_files): Update.
11673         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11674         * guile/scm-pretty-print.c
11675         (ppscm_find_pretty_printer_from_objfiles): Update.
11676         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11677         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11678         Update.
11679         * python/py-progspace.c (pspy_get_objfiles): Update.
11680         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11681         Update.
11682         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11683         (objfpy_lookup_objfile_by_build_id): Update.
11684         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11685         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11686         Update.
11687         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11688         (expand_symtab_containing_pc, lookup_objfile_from_block)
11689         (lookup_static_symbol, basic_lookup_transparent_type)
11690         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11691         (find_line_symtab, info_sources_command)
11692         (default_collect_symbol_completion_matches_break_on)
11693         (make_source_files_completion_list, find_main_name): Update.
11694         * symmisc.c (print_symbol_bcache_statistics)
11695         (print_objfile_statistics, maintenance_print_symbols)
11696         (maintenance_print_msymbols, maintenance_print_objfiles)
11697         (maintenance_info_symtabs, maintenance_check_symtabs)
11698         (maintenance_expand_symtabs, maintenance_info_line_tables):
11699         Update.
11700         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11701         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11702         (map_overlay_command, unmap_overlay_command)
11703         (simple_overlay_update, expand_symtabs_matching)
11704         (map_symbol_filenames): Update.
11705         * symfile-debug.c (set_debug_symfile): Update.
11706         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11707         Update.
11708         * source.c (select_source_symtab, forget_cached_source_info):
11709         Update.
11710         * solib.c (solib_read_symbols): Update.
11711         * solib-spu.c (append_ocl_sos): Update.
11712         * psymtab.c (maintenance_print_psymbols)
11713         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11714         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11715         * printcmd.c (info_symbol_command): Update.
11716         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11717         Update.
11718         * objfiles.h (class all_objfiles): Remove.
11719         * objfiles.c (have_partial_symbols, have_full_symbols)
11720         (have_minimal_symbols, qsort_cmp, update_section_map)
11721         (shared_objfile_contains_address_p)
11722         (default_iterate_over_objfiles_in_search_order): Update.
11723         * objc-lang.c (info_selectors_command, info_classes_command)
11724         (find_methods): Update.
11725         * minsyms.c (find_solib_trampoline_target): Update.
11726         * maint.c (maintenance_info_sections)
11727         (maintenance_translate_address, count_symtabs_and_blocks):
11728         Update.
11729         * main.c (captured_main_1): Update.
11730         * linux-thread-db.c (try_thread_db_load_from_pdir)
11731         (has_libpthread): Update.
11732         * linespec.c (iterate_over_all_matching_symtabs)
11733         (search_minsyms_for_name): Update.
11734         * jit.c (jit_find_objf_with_entry_addr): Update.
11735         * hppa-tdep.c (find_unwind_entry)
11736         (hppa_lookup_stub_minimal_symbol): Update.
11737         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11738         Update.
11739         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11740         (elf_gnu_ifunc_resolve_by_got): Update.
11741         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11742         * dwarf-index-write.c (save_gdb_index_command): Update.
11743         * cp-support.c (add_symbol_overload_list_qualified): Update.
11744         * breakpoint.c (create_overlay_event_breakpoint)
11745         (create_longjmp_master_breakpoint)
11746         (create_std_terminate_master_breakpoint)
11747         (create_exception_master_breakpoint): Update.
11748         * blockframe.c (find_pc_partial_function): Update.
11749         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11750         (ada_collect_symbol_completion_matches)
11751         (ada_add_global_exceptions): Update.
11752
11753 2019-01-17  Tom Tromey  <tom@tromey.com>
11754
11755         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11756         declare VEC.
11757         (solib_target_parse_libraries): Change return type.
11758         (library_list_start_segment, library_list_start_section)
11759         (library_list_end_library, library_list_start_library); Update.
11760         (solib_target_free_library_list): Remove.
11761         (solib_target_parse_libraries): Remove cleanup.  Change return
11762         type.
11763         (solib_target_current_sos): Update.
11764
11765 2019-01-17  Tom Tromey  <tromey@bapiya>
11766
11767         * valprint.c: Replace "the the" with "the".
11768         * symtab.c: Replace "the the" with "the".
11769         * solib.c: Replace "the the" with "the".
11770         * solib-dsbt.c: Replace "the the" with "the".
11771         * linespec.c: Replace "the the" with "the".
11772         * dwarf2loc.h: Replace "the the" with "the".
11773         * amd64-windows-tdep.c: Replace "the the" with "the".
11774         * aarch64-tdep.c: Replace "the the" with "the".
11775
11776 2019-01-16  Keith Seitz  <keiths@redhat.com>
11777
11778         PR gdb/23773
11779         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11780         <builder>: Rename to ..
11781         <m_builder>: ... this and make private.
11782         (dwarf2_cu::get_builder): New method.  Change all users of
11783         `builder' to use this method.
11784         (dwarf2_start_symtab): Move to ...
11785         (dwarf2_cu::start_symtab): ... here.  Update all callers
11786         (setup_type_unit_groups): Move to ...
11787         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11788         callers.
11789         (dwarf2_cu::reset_builder): New method.
11790         (process_full_compunit, process_full_type_unit): Use
11791         dwarf2_cu::reset_builder.
11792         (follow_die_offset): Record the ancestor CU if it is different
11793         from the followed DIE's CU.
11794         (follow_die_sig_1): Likewise.
11795
11796 2019-01-15  Tom Tromey  <tom@tromey.com>
11797
11798         * remote.c (class remote_state) <buf>: Now a char_vector.
11799         <buf_size>: Remove.
11800         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11801         parameter.
11802         (remote_target::getpkt_or_notif_sane_1)
11803         (remote_target::getpkt_sane)
11804         (remote_target::getpkt_or_notif_sane): Likewise.
11805         (class remote_target) <putpkt>: New overload.
11806         (remote_target::read_frame): Change type of "buf_p".  Remove
11807         sizeof_p parameter.
11808         (packet_ok): New overload.
11809         (packet_check_result): New overload.
11810         Update all uses.
11811
11812 2019-01-14  Tom Tromey  <tom@tromey.com>
11813
11814         * remote-notif.c (handle_notification, remote_notif_ack)
11815         (remote_notif_parse): Make "buf" const.
11816         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11817         const.
11818         (remote_notif_parse, remote_notif_ack, handle_notification):
11819         Likewise.
11820         * remote.c (remote_notif_stop_parse): Make "buf" const.
11821         (remote_target::remote_parse_stop_reply): Make "buf" const.
11822         (remote_notif_stop_ack): Make "buf" const.
11823
11824 2019-01-14  Tom Tromey  <tom@tromey.com>
11825
11826         * remote.c (remote_console_output): Make parameter const.
11827
11828 2019-01-14  Tom Tromey  <tom@tromey.com>
11829
11830         * target-debug.h (target_debug_print_signals): Constify.
11831         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11832         * procfs.c (procfs_target::pass_signals): Update.
11833         * linux-nat.c (linux_nat_target::pass_signals): Update.
11834         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11835         * target-delegates.c: Rebuild.
11836         * remote.c (remote_target::program_signals): Update.
11837         (remote_target::pass_signals): Update.
11838         * target.c (target_pass_signals): Constify argument.
11839         (target_program_signals): Likewise.
11840         * target.h (struct target_ops) <pass_signals, program_signals>:
11841         Constify argument.
11842         (target_pass_signals, target_program_signals): Constify argument.
11843
11844 2019-01-14  Tom Tromey  <tom@tromey.com>
11845
11846         PR tui/28819:
11847         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11848
11849 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11850
11851         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11852         field.
11853         * rs6000-tdep.c: Include reggroups.h.
11854         (IS_V_ALIAS_PSEUDOREG): Define.
11855         (rs6000_register_name): Return names for the "vX" aliases.
11856         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11857         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11858         aliases.  Call default_register_reggroup_p for all other
11859         pseudo-registers.
11860         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11861         New functions.
11862         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11863         Handle "vX" aliases.
11864         (v_alias_pseudo_register_collect): New function.
11865         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11866         (rs6000_gdbarch_init): Initialize "vX" aliases as
11867         pseudo-registers.  Restore registration of
11868         rs6000_pseudo_register_reggroup_p with
11869         set_tdesc_pseudo_register_reggroup_p.
11870
11871 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11872
11873         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11874         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11875         set_gdbarch_num_pseudo_regs.
11876
11877 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11878
11879         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11880         Remove arg prefixname, add do_set and do_show.
11881         Add member functions set_list and show_list.
11882         * cli/cli-style.c (class cli_style_option): Update accordingly.
11883         (style_set_list): Move to file scope.
11884         (style_show_list): Likewise.
11885         (set_style): Call help_list.
11886         (show_style): Call cmd_show_list.
11887         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11888         Update to use the new macro.
11889
11890 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11891
11892         * ada-lang.c (_initialize_ada_language): Expand the help text
11893         for the "catch exception" command.
11894
11895 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11896
11897         * symtab.c (matching_obj_sections): Initialize obj,
11898         declare it closer to its usage.
11899
11900 2019-01-10  Tom Tromey  <tom@tromey.com>
11901
11902         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11903         (basic_inf_threads_range): Remove.
11904         (inf_threads_range, inf_non_exited_threads_range)
11905         (safe_inf_threads_range): Use next_adapter.
11906
11907 2019-01-10  Keith Seitz  <keiths@redhat.com>
11908
11909         PR gdb/23712
11910         PR symtab/23010
11911         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11912         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11913
11914 2019-01-10  Keith Seitz  <keiths@redhat.com>
11915
11916         PR gdb/23712
11917         PR symtab/23010
11918         * dictionary.c (pending_to_vector): Remove.
11919         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11920         Remove _1 suffix, replacing functions of the same name.  Update
11921         all callers.
11922         (dict_create_hashed, dict_create_hashed_expandable)
11923         (dict_create_linear, dict_create_linear_expandable, dict_free)
11924         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11925         Make functions static.
11926
11927 2019-01-10  Keith Seitz  <keiths@redhat.com>
11928
11929         PR gdb/23712
11930         PR symtab/23010
11931         * dictionary.h (struct dictionary): Replace declaration with
11932         multidictionary.
11933         (dict_create_hashed, dict_create_hashed_expandable)
11934         (dict_create_linear, dict_create_linear_expandable)
11935         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11936         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11937         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11938         taking multidictionary argument.
11939         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11940         * block.h (struct block) <dict>: Change to multidictionary
11941         and rename `multidict'.
11942         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11943         symmisc.c: Update all dictionary references to multidictionary.
11944
11945 2019-01-10  Keith Seitz  <keiths@redhat.com>
11946
11947         PR gdb/23712
11948         PR symtab/23010
11949         * dictionary.c: Include unordered_map.
11950         (pending_to_vector): New function.
11951         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11952         Rewrite the non-"_1" functions to take vector instead
11953         of linked list.
11954         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11955         "new" _1 versions of the same name.
11956         (multidictionary): Define.
11957         (std::hash<enum language): New definition.
11958         (collate_pending_symbols_by_language, mdict_create_hashed)
11959         (mdict_create_hashed_expandable, mdict_create_linear)
11960         (mdict_create_linear_expandable, mdict_free)
11961         (find_language_dictionary, create_new_language_dictionary)
11962         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11963         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11964         (mdict_size, mdict_empty): New functions.
11965         * dictionary.h (mdict_iterator): Define.
11966
11967 2019-01-10  Pedro Alves  <palves@redhat.com>
11968
11969         * breakpoint.c (read_uploaded_action)
11970         (create_tracepoint_from_upload): Adjust to use
11971         gdb::unique_xmalloc_ptr.
11972         * ctf.c (ctf_write_uploaded_tp):
11973         (SET_ARRAY_FIELD): Use emplace_back.
11974         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11975         * tracefile-tfile.c (tfile_write_uploaded_tp):
11976         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11977         gdb::unique_xmalloc_ptr.
11978         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11979         at_string, cond_string, cmd_strings>: Replace char pointers
11980         with gdb::unique_xmalloc_ptr.
11981
11982 2019-01-10  Pedro Alves  <palves@redhat.com>
11983
11984         * solib-target.c (library_list_start_library): Don't xstrdup name.
11985
11986 2019-01-10  Pedro Alves  <palves@redhat.com>
11987
11988         * mdebugread.c (parse_partial_symbols): Use
11989         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11990
11991 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11992
11993         * linux-fork.c (scoped_switch_fork_info)
11994         <~scoped_switch_fork_info>: Fix incorrect variable name.
11995
11996 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11997
11998         * linux-fork.c (scoped_switch_fork_info)
11999         <scoped_switch_fork_info>: Make explicit.
12000         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12001
12002 2019-01-10  Tom Tromey  <tom@tromey.com>
12003
12004         * objfiles.h (objfile::reset_psymtabs): Update.
12005         * objfiles.c (objfile::objfile): Update.
12006         * psymtab.h (psymtab_storage::obstack): Update.
12007         (psymtab_storage::m_obstack): Use gdb::optional.
12008         (class psymtab_storage): Update comment.  Remove objfile
12009         parameter.
12010         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12011
12012 2019-01-10  Tom Tromey  <tom@tromey.com>
12013
12014         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12015         <free_psymtabs>: Now private.
12016         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12017         (allocate_psymtab): Use new method.
12018
12019 2019-01-10  Tom Tromey  <tom@tromey.com>
12020
12021         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12022         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12023         * mdebugread.c (parse_partial_symbols): Use
12024         allocate_dependencies.
12025         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12026         allocate_dependencies.
12027         (process_psymtab_comp_unit_reader)
12028         (build_type_psymtab_dependencies): Likewise.
12029         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12030
12031 2019-01-10  Tom Tromey  <tom@tromey.com>
12032
12033         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12034         PSYMBOL_SET_LANGUAGE.
12035         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12036
12037 2019-01-10  Tom Tromey  <tom@tromey.com>
12038
12039         * psymtab.h (psymtab_storage::obstack): New method.
12040         <m_obstack>: Rename from obstack; now private.
12041         * psymtab.c (psymtab_storage): Update.
12042         * dwarf2read.c (create_addrmap_from_index)
12043         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12044         Update.
12045
12046 2019-01-10  Tom Tromey  <tom@tromey.com>
12047
12048         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12049         * objfiles.h (objfile::reset_psymtabs): New method.
12050
12051 2019-01-10  Tom Tromey  <tom@tromey.com>
12052
12053         * symmisc.c (print_symbol_bcache_statistics): Update.
12054         (print_objfile_statistics): Update.
12055         * symfile.c (reread_symbols): Update.
12056         * psymtab.h (class psymtab_storage): New.
12057         * psymtab.c (psymtab_storage): New constructor.
12058         (~psymtab_storage): New destructor.
12059         (require_partial_symbols): Update.
12060         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12061         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12062         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12063         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12064         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12065         (start_psymtab_common, end_psymtab_common)
12066         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12067         (allocate_psymtab): Update.
12068         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12069         Update.
12070         (dump_psymtab_addrmap, maintenance_print_psymbols)
12071         (maintenance_check_psymtabs): Update.
12072         (class objfile_psymtabs): Move to objfiles.h.
12073         * psympriv.h (discard_psymtab): Now inline.
12074         (psymtab_discarder::psymtab_discarder): Update.
12075         (psymtab_discarder::~psymtab_discarder): Update.
12076         (ALL_OBJFILE_PSYMTABS): Rewrite.
12077         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12078         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12079         Remove fields.
12080         <partial_symtabs>: New field.
12081         (class objfile_psymtabs): Move from psymtab.h.  Update.
12082         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12083         psymbol_cache.
12084         (objfile::~objfile): Don't destroy psymbol_cache.
12085         * mdebugread.c (parse_partial_symbols): Update.
12086         * dwarf2read.c (create_addrmap_from_index)
12087         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12088         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12089         (add_partial_subprogram, dwarf2_ranges_read): Update.
12090         * dwarf-index-write.c (write_address_map)
12091         (write_one_signatured_type, recursively_write_psymbols)
12092         (class debug_names, class debug_names, write_psymtabs_to_index):
12093         Update.
12094
12095 2019-01-10  Tom Tromey  <tom@tromey.com>
12096
12097         * symtab.h (SYMBOL_SET_NAMES): Update.
12098         (symbol_set_names): Update.
12099         (MSYMBOL_SET_NAMES): Update.
12100         * symtab.c (symbol_set_names): Change argument to be an
12101         objfile_per_bfd_storage.
12102         * psymtab.c (add_psymbol_to_bcache): Update.
12103         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12104
12105 2019-01-10  Tom Tromey  <tom@tromey.com>
12106
12107         * symtab.c (create_demangled_names_hash): Change argument to be an
12108         objfile_per_bfd_storage.
12109         (symbol_set_names): Update.
12110
12111 2019-01-10  Tom Tromey  <tom@tromey.com>
12112
12113         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12114         init_psymbol_list.
12115         * psymtab.c (init_psymbol_list): Do nothing if already called.
12116         * psympriv.h (init_psymbol_list): Add comment.
12117         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12118         init_psymbol_list.
12119         * dbxread.c (dbx_symfile_read): Unconditionally call
12120         init_psymbol_list.
12121
12122 2019-01-10  Tom Tromey  <tom@tromey.com>
12123
12124         * xcoffread.c (scan_xcoff_symtab): Update.
12125         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12126         "where".
12127         * mdebugread.c (parse_partial_symbols)
12128         (handle_psymbol_enumerators): Update.
12129         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12130         * dbxread.c (read_dbx_symtab): Update.
12131         * psympriv.h (psymbol_placement): New enum.
12132         (add_psymbol_to_list): Update.
12133
12134 2019-01-10  Tom Tromey  <tom@tromey.com>
12135
12136         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12137         static_psymbols parameters.
12138         (scan_xcoff_symtab): Update.
12139         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12140         static_psymbols parameters.
12141         * psympriv.h (start_psymtab_common): Update.
12142         * mdebugread.c (parse_partial_symbols): Update.
12143         * dwarf2read.c (create_partial_symtab): Update.
12144         * dbxread.c (read_dbx_symtab): Update.
12145         (start_psymtab): Remove global_psymbols and static_psymbols
12146         parameters.
12147
12148 2019-01-10  Tom Tromey  <tom@tromey.com>
12149
12150         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12151         * psymtab.c (allocate_psymtab): Add comment.
12152         * psympriv.h (allocate_psymtab): Add comment.
12153         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12154         initializations.
12155         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12156
12157 2019-01-10  Tom Tromey  <tom@tromey.com>
12158
12159         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12160         Don't declare.
12161         * mipsread.c: Include mdebugread.h.
12162         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12163         Declare.
12164         * elfread.c: Include mdebugread.h.
12165
12166 2019-01-09  Tom Tromey  <tom@tromey.com>
12167
12168         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12169         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12170         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12171         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12172         (psym_lookup_symbol, psym_find_last_source_symtab)
12173         (psym_forget_cached_source_info, psym_print_stats)
12174         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12175         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12176         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12177         (psym_find_compunit_symtab_by_address)
12178         (maintenance_print_psymbols, maintenance_info_psymtabs)
12179         (maintenance_check_psymtabs): Use ranged for.
12180         * psymtab.h (class objfile_psymtabs): New.
12181         (require_partial_symbols): Return objfile_psymtabs.
12182         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12183
12184 2019-01-09  Tom Tromey  <tom@tromey.com>
12185
12186         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12187         (find_pc_mapped_section, list_overlays_command)
12188         (map_overlay_command, unmap_overlay_command)
12189         (simple_overlay_update): Use all_objfiles.
12190         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12191         * printcmd.c (info_symbol_command): Use all_objfiles.
12192         * objfiles.h (ALL_OBJSECTIONS): Remove.
12193         * maint.c (maintenance_translate_address): Use all_objfiles.
12194         * gcore.c (gcore_create_callback): Use all_objfiles.
12195         (objfile_find_memory_regions): Likewise.
12196
12197 2019-01-09  Tom Tromey  <tom@tromey.com>
12198
12199         * symtab.c (find_line_symtab, info_sources_command)
12200         (make_source_files_completion_list): Use objfile_compunits.
12201         * source.c (select_source_symtab): Use objfile_compunits.
12202         * objfiles.h (struct objfile): Update comment.
12203         (ALL_OBJFILES): Remove.
12204         (ALL_FILETABS): Remove.
12205         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12206         objfile_compunits.
12207
12208 2019-01-09  Tom Tromey  <tom@tromey.com>
12209
12210         * symmisc.c (print_objfile_statistics, dump_objfile)
12211         (maintenance_print_symbols): Use compunit_filetabs.
12212         * source.c (forget_cached_source_info_for_objfile): Use
12213         compunit_filetabs.
12214         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12215         (ALL_FILETABS): Use compunit_filetabs.
12216         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12217         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12218
12219 2019-01-09  Tom Tromey  <tom@tromey.com>
12220
12221         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12222         (compunit_filetabs): New.
12223         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12224         compunit_filetabs.
12225         (info_sources_command, make_source_files_completion_list): Remove
12226         declaration.
12227         * symmisc.c (print_objfile_statistics, dump_objfile)
12228         (maintenance_print_symbols): Remove declaration.
12229         (maintenance_info_symtabs): Use compunit_filetabs.
12230         (maintenance_info_line_tables): Likewise.
12231         * source.c (select_source_symtab): Change local variable name.
12232         (forget_cached_source_info_for_objfile): Remove declaration.
12233         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12234         * objfiles.c (objfile_relocate1): Remove declaration.
12235         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12236         declaration.
12237         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12238         * coffread.c (coff_symtab_read): Remove declaration.
12239         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12240         compunit_filetabs.
12241
12242 2019-01-09  Tom Tromey  <tom@tromey.com>
12243
12244         * symtab.c (lookup_objfile_from_block)
12245         (find_pc_sect_compunit_symtab, search_symbols)
12246         (default_collect_symbol_completion_matches_break_on): Use
12247         objfile_compunits.
12248         * objfiles.h (ALL_COMPUNITS): Remove.
12249         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12250         * cp-support.c (add_symbol_overload_list_qualified): Use
12251         objfile_compunits.
12252         * ada-lang.c (ada_collect_symbol_completion_matches)
12253         (ada_add_global_exceptions): Use objfile_compunits.
12254
12255 2019-01-09  Tom Tromey  <tom@tromey.com>
12256
12257         * source.c (select_source_symtab)
12258         (forget_cached_source_info_for_objfile): Remove declaration.
12259         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12260         declaration.
12261         * maint.c (count_symtabs_and_blocks): Remove declaration.
12262         * cp-support.c (add_symbol_overload_list_qualified): Remove
12263         declaration.
12264         * coffread.c (coff_symtab_read): Remove declaration.
12265         * symtab.c (lookup_symbol_in_objfile_symtabs)
12266         (basic_lookup_transparent_type_1): Use objfile_compunits.
12267         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12268         (info_sources_command, search_symbols)
12269         (default_collect_symbol_completion_matches_break_on)
12270         (make_source_files_completion_list): Remove declaration.
12271         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12272         (ada_collect_symbol_completion_matches)
12273         (ada_add_global_exceptions): Remove declaration.
12274         * linespec.c (iterate_over_all_matching_symtabs): Use
12275         objfile_compunits.
12276         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12277         (class objfile_compunits): New.
12278         (ALL_COMPUNITS): Use objfile_compunits.
12279         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12280         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12281         objfile_compunits.
12282         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12283
12284 2019-01-09  Tom Tromey  <tom@tromey.com>
12285
12286         * symtab.c (search_symbols)
12287         (default_collect_symbol_completion_matches_break_on): Use
12288         objfile_msymbols.
12289         * ada-lang.c (ada_lookup_simple_minsym)
12290         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12291         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12292         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12293         objfile_msymbols.
12294         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12295         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12296         * objc-lang.c (find_methods): Use objfile_msymbols.
12297         (info_selectors_command, info_classes_command): Likewise.
12298         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12299         * objfiles.h (class objfile_msymbols): New.
12300         (ALL_OBJFILE_MSYMBOLS): Remove.
12301         (ALL_MSYMBOLS): Remove.
12302
12303 2019-01-09  Tom Tromey  <tom@tromey.com>
12304
12305         * common/next-iterator.h (next_adapter): Add Iterator template
12306         parameter.
12307         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12308         (class all_objfiles_safe): New.
12309         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12310         * objfiles.c (put_objfile_before): Update comment.
12311         (add_separate_debug_objfile): Likewise.
12312         (free_all_objfiles): Use all_objfiles_safe.
12313         (objfile_purge_solibs): Likewise.
12314
12315 2019-01-09  Tom Tromey  <tom@tromey.com>
12316
12317         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12318         (expand_symtab_containing_pc, lookup_static_symbol)
12319         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12320         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12321         all_objfiles.
12322         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12323         * breakpoint.c (create_overlay_event_breakpoint)
12324         (create_longjmp_master_breakpoint)
12325         (create_std_terminate_master_breakpoint)
12326         (create_exception_master_breakpoint): Use all_objfiles.
12327         * linux-thread-db.c (try_thread_db_load_from_pdir)
12328         (has_libpthread): Use all_objfiles.
12329         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12330         * linespec.c (iterate_over_all_matching_symtabs)
12331         (search_minsyms_for_name): Use all_objfiles.
12332         * maint.c (maintenance_info_sections): Use all_objfiles.
12333         * main.c (captured_main_1): Use all_objfiles.
12334         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12335         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12336         * guile/scm-pretty-print.c
12337         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12338         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12339         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12340         (maintenance_print_msymbols): Use all_objfiles.
12341         * source.c (select_source_symtab): Use all_objfiles.
12342         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12343         * symfile.c (remove_symbol_file_command)
12344         (expand_symtabs_matching, map_symbol_filenames): Use
12345         all_objfiles.
12346         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12347         all_objfiles.
12348         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12349         * objc-lang.c (find_methods): Use all_objfiles.
12350         * objfiles.c (have_partial_symbols, have_full_symbols)
12351         (have_minimal_symbols, qsort_cmp)
12352         (default_iterate_over_objfiles_in_search_order): Use
12353         all_objfiles.
12354         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12355         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12356         (maintenance_check_psymtabs): Use all_objfiles.
12357         (ALL_PSYMTABS): Remove.
12358         * compile/compile-object-run.c (do_module_cleanup): Use
12359         all_objfiles.
12360         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12361         * cp-support.c (add_symbol_overload_list_qualified): Use
12362         all_objfiles.
12363         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12364         Use all_objfiles.
12365         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12366         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12367         all_objfiles.
12368         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12369         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12370         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12371         Uses all_objfiles.
12372         * solib.c (solib_read_symbols): Use all_objfiles
12373
12374 2019-01-09  Tom Tromey  <tom@tromey.com>
12375
12376         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12377         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12378         all_objfiles.
12379         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12380         * symmisc.c (print_symbol_bcache_statistics)
12381         (print_objfile_statistics, maintenance_print_objfiles)
12382         (maintenance_info_symtabs, maintenance_check_symtabs)
12383         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12384         all_objfiles.
12385         * source.c (forget_cached_source_info): Use all_objfiles.
12386         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12387         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12388         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12389         * objfiles.c (update_section_map): Use all_objfiles.
12390         (shared_objfile_contains_address_p): Likewise.
12391         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12392         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12393
12394 2019-01-09  Tom Tromey  <tom@tromey.com>
12395
12396         * common/next-iterator.h: New file.
12397         * objfiles.h (class all_objfiles): New.
12398         (struct objfile_iterator): New.
12399
12400 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12401
12402         * NEWS: Move the description of the changed "frame", "select-frame",
12403          and "info frame" commands to the Changed commands section.
12404
12405 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12406
12407         * gdbtypes.c (check_stub_method_group): Remove handling of old
12408         mangling schemes.
12409         * linespec.c (find_methods): Likewise.
12410         * stabsread.c (read_member_functions): Likewise.
12411         * valops.c (search_struct_method): Likewise.
12412         (value_struct_elt_for_reference): Likewise.
12413         * NEWS: Mention this change.
12414
12415 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12416
12417         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12418         print_source_lines.
12419         * source.c (print_source_lines_base): Update line number check.
12420         (print_source_lines): New function.
12421         (source_lines_range::source_lines_range): New function.
12422         * source.h (class source_lines_range): New class.
12423         (print_source_lines): New declaration.
12424
12425 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12426
12427         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12428
12429 2019-01-08  Tom Tromey  <tom@tromey.com>
12430             Simon Marchi  <simon.marchi@ericsson.com>
12431
12432         PR gdb/24060
12433         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12434         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12435         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12436         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12437         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12438         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12439
12440 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12441
12442         * source.c (select_source_symtab): Move header comment to
12443         declaration in source.h.
12444         (forget_cached_source_info_for_objfile): Likewise.
12445         (forget_cached_source_info): Likewise.
12446         (identify_source_line): Likewise.
12447         * source.h (identify_source_line): Move declaration from symtab.h
12448         and add comment from source.c
12449         (print_source_lines): Likewise.
12450         (forget_cached_source_info_for_objfile): Likewise.
12451         (forget_cached_source_info): Likewise.
12452         (select_source_symtab): Likewise.
12453         (enum print_source_lines_flag): Move definition from symtab.h.
12454         * symtab.h (identify_source_line): Move declaration to source.h.
12455         (print_source_lines): Likewise.
12456         (forget_cached_source_info_for_objfile): Likewise.
12457         (forget_cached_source_info): Likewise.
12458         (select_source_symtab): Likewise.
12459         (enum print_source_lines_flag): Move definition to source.h.
12460         * tui/tui-hooks.c: Add 'source.h' include.
12461
12462 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12463
12464         * source.c (print_source_lines_base): Handle requests to print
12465         reverse line number sequences, and guard against empty lines
12466         string.
12467
12468 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12469
12470         * source.c (print_source_lines_base): Fix skip of '\r' if next
12471         character is '\n'.
12472
12473 2019-01-06  Tom Tromey  <tom@tromey.com>
12474
12475         * c-exp.y (struct c_parse_state) <macro_original_text,
12476         expansion_obstack>: New member.
12477         (macro_original_text, expansion_obstack): Remove globals.
12478         (scan_macro_expansion, scanning_macro_expansion)
12479         (finished_macro_expansion): Update.
12480         (scan_macro_cleanup): Remove.
12481         (yylex, c_parse): Update.
12482
12483 2019-01-06  Tom Tromey  <tom@tromey.com>
12484
12485         * c-exp.y (struct c_parse_state) <strings>: New member.
12486         (operator_stoken): Update.
12487
12488 2019-01-06  Tom Tromey  <tom@tromey.com>
12489
12490         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12491         (union type_stack_elt) <typelist_val>: Now a pointer to
12492         std::vector.
12493         (type_stack_cleanup): Don't declare.
12494         (push_typelist): Update.
12495         * parse.c (pop_typelist): Return a std::vector.
12496         (push_typelist): Take a std::vector.
12497         (follow_types): Update.  Do not free args.
12498         (type_stack_cleanup): Remove.
12499         * c-exp.y (struct c_parse_state): New.
12500         (cpstate): New global.
12501         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12502         (nonempty_typelist): Update.
12503         (func_mod): Create a new vector.
12504         (c_parse): Create a c_parse_state.
12505         (check_parameter_typelist): Do not delete params.
12506         (function_method): Update.  Do not delete type_list.
12507
12508 2019-01-06  Tom Tromey  <tom@tromey.com>
12509
12510         PR gdb/28155:
12511         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12512         check_typedef.
12513         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12514         (print_return_value): Likewise.
12515
12516 2019-01-05  Tom Tromey  <tom@tromey.com>
12517
12518         * contrib/cleanup_check.py: Remove.
12519         * contrib/gcc-with-excheck: Remove.
12520         * contrib/exsummary.py: Remove.
12521         * contrib/excheck.py: Remove.
12522
12523 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12524
12525         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12526         NULL. Initialize tpprev to NULL instead of assigning it
12527         to NULL on the next statement.
12528         * windows-nat.c (windows_delete_thread): Remove check for
12529         main_thread_id before printing thread exit notifications.
12530         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12531         Remove thread ID check against main_thread_id.
12532         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12533         windows_delete_thread.
12534         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12535
12536 2019-01-04  Tom Tromey  <tom@tromey.com>
12537
12538         * compile/compile.c (_initialize_compile): Use upper case for
12539         metasyntactic variables.
12540         * symmisc.c (_initialize_symmisc): Use upper case for
12541         metasyntactic variables.
12542         * psymtab.c (_initialize_psymtab): Use upper case for
12543         metasyntactic variables.
12544         * demangle.c (demangle_command): Use upper case for metasyntactic
12545         variables.
12546         (_initialize_demangler): Likewise.
12547         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12548         variables.
12549
12550 2019-01-03  Tom Tromey  <tom@tromey.com>
12551
12552         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12553
12554 2019-01-03  Tom Tromey  <tom@tromey.com>
12555
12556         * python/py-symtab.c (salpy_str): Update.
12557         (struct salpy_sal_object) <symtab>: Now a PyObject.
12558         (salpy_dealloc): Update.
12559         (del_objfile_sal): Use gdbpy_ref.
12560
12561 2019-01-03  Tom Tromey  <tom@tromey.com>
12562
12563         * python/py-type.c (convert_field): Use new_reference.  Return
12564         gdbpy_ref.
12565         (make_fielditem): Return gdbpy_ref.
12566         (typy_fields): Update.
12567         (typy_getitem): Update.
12568         (field_name): Return gdbpy_ref.  Use new_reference.
12569         (typy_iterator_iternext): Update.
12570
12571 2019-01-03  Tom Tromey  <tom@tromey.com>
12572
12573         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12574
12575 2019-01-03  Tom Tromey  <tom@tromey.com>
12576
12577         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12578         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12579         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12580         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12581         (pspy_set_type_printers): Likewise.
12582         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12583         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12584         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12585         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12586         (objfpy_set_type_printers): Likewise.
12587
12588 2019-01-03  Tom Tromey  <tom@tromey.com>
12589
12590         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12591         (gdbpy_print_stack): Use gdbpy_err_fetch.
12592         * python/python-internal.h (class gdbpy_err_fetch): New class.
12593         (class gdbpy_enter) <m_error_type, m_error_value,
12594         m_error_traceback>: Remove.
12595         <m_error>: New member.
12596         (gdbpy_exception_to_string): Don't declare.
12597         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12598         * python/py-value.c (convert_value_from_python): Use
12599         gdbpy_err_fetch.
12600         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12601         gdbpy_exception_to_string.
12602         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12603         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12604         gdbpy_err_fetch.
12605
12606 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12607
12608         * linux-nat.c (delete_lwp_cleanup): Delete.
12609         (struct lwp_deleter): New struct.
12610         (lwp_info_up): New typedef.
12611         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12612         lwp_info_up.
12613
12614 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12615
12616         * linux-fork.c (class scoped_switch_fork_info): New class.
12617         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12618
12619 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12620
12621         * valops.c (find_overload_match): Remove use of null_cleanup, and
12622         calls to do_cleanups.
12623
12624 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12625
12626         * compile/compile-cplus-types.c
12627         (compile_cplus_instance::decl_name): Handle changes to
12628         cp_func_name.
12629         * cp-support.c (cp_func_name): Update header comment, update
12630         return type.
12631         * cp-support.h (cp_func_name): Update return type in declaration.
12632         * valops.c (find_overload_match): Move temp_func local to top
12633         level of function and change its type.  Use temp_func to hold and
12634         delete temporary string obtained from cp_func_name.
12635
12636 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12637
12638         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12639         gdb::char_vector, remove cleanup, and update uses of `msg`.
12640
12641 2019-01-03  Jim Wilson  <jimw@sifive.com>
12642
12643         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12644
12645 2019-01-02  Tom Tromey  <tom@tromey.com>
12646
12647         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12648         (tdesc_parse_xml): Remove cleanups.
12649         * target-descriptions.h (make_cleanup_free_target_description):
12650         Don't declare.
12651         (target_desc_deleter): New struct.
12652         (target_desc_up): New typedef.
12653         * target-descriptions.c (target_desc_deleter::operator()): Rename
12654         from free_target_description.
12655         (make_cleanup_free_target_description): Remove.
12656
12657 2019-01-02  Tom Tromey  <tom@tromey.com>
12658
12659         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12660         constructor, destructor.
12661         (linespec_parser): Remove typedef.
12662         (~linespec_parser): Rename from linespec_parser_delete.
12663         (linespec_lex_to_end, linespec_complete_label)
12664         (linespec_complete): Update.
12665         (decode_line_full): Remove cleanups.
12666         (decode_line_1): Update.
12667
12668 2019-01-02  Tom Tromey  <tom@tromey.com>
12669
12670         * python/python-internal.h (inferior_to_inferior_object): Change
12671         return type.
12672         * python/py-exitedevent.c (create_exited_event_object): Update.
12673         * python/py-inferior.c (inferior_to_inferior_object): Return
12674         gdbpy_ref.
12675         (python_new_inferior, python_inferior_deleted)
12676         (thread_to_thread_object, delete_thread_object)
12677         (build_inferior_list, gdbpy_selected_inferior): Update.
12678         * python/py-infthread.c (create_thread_object): Update.  Also fail
12679         if inferior_to_inferior_object fails.
12680
12681 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12682
12683         * inferior.h (class inferior) <displaced_step_state>: New field.
12684         * infrun.h (struct displaced_step_state): Move here from
12685         infrun.c.  Initialize fields, add constructor.
12686         <inf>: Remove field.
12687         <reset>: New method.
12688         * infrun.c (struct displaced_step_inferior_state): Move to
12689         infrun.h.
12690         (displaced_step_inferior_states): Remove.
12691         (get_displaced_stepping_state): Adust.
12692         (displaced_step_in_progress_any_inferior): Adjust.
12693         (displaced_step_in_progress_thread): Adjust.
12694         (displaced_step_in_progress): Adjust.
12695         (add_displaced_stepping_state): Remove.
12696         (get_displaced_step_closure_by_addr): Adjust.
12697         (remove_displaced_stepping_state): Remove.
12698         (infrun_inferior_exit): Call displaced_step_state.reset.
12699         (use_displaced_stepping): Don't check for NULL.
12700         (displaced_step_prepare_throw): Call
12701         get_displaced_stepping_state.
12702         (displaced_step_fixup): Don't check for NULL.
12703         (prepare_for_detach): Don't check for NULL.
12704
12705 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12706
12707         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12708          in case of call that did not complete.
12709
12710 2019-01-02  Andrey Utkin  <autkin@undo.io>
12711
12712         * symfile.c (find_separate_debug_file): Fix search of debug files for
12713         remote debuggee.
12714
12715 2019-01-02  Tom Tromey  <tom@tromey.com>
12716
12717         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12718         indentation.
12719         * python/py-frame.c (frapy_older): Remove cast.
12720         (frapy_newer): Likewise.
12721         * python/py-breakpoint.c (local_setattro): Remove cast.
12722         * python/py-arch.c (archpy_name): Remove local variable.
12723         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12724
12725 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12726
12727         * unittests/basic_string_view/element_access/char/empty.cc:
12728         Fix year range in copyright header.
12729
12730 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12731
12732         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12733         Delete.
12734         <operator==>: Update with for removed field.
12735         <hash>: Likewise.
12736         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12737         <isa_features>: ...this.
12738         <abi_features>: New field.
12739         (riscv_isa_flen): Update comment.
12740         (riscv_abi_xlen): New declaration.
12741         (riscv_abi_flen): New declaration.
12742         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12743         isa_features.
12744         (riscv_abi_xlen): New function.
12745         (riscv_isa_flen): Update to get answer from isa_features.
12746         (riscv_abi_flen): New function.
12747         (riscv_has_fp_abi): Update to get answer from abi_features.
12748         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12749         xlen and flen.
12750         (riscv_call_info) <xlen, flen>: Update comment.
12751         (riscv_call_arg_struct): Remove invalid assertions
12752         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12753         is removed.
12754         (riscv_gdbarch_init): Gather isa features and abi features
12755         separately, ensure both match on the gdbarch when reusing an old
12756         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12757         a target with 64-bit float hardware.
12758
12759 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12760
12761         * source.c (search_command_helper): Stop reverse search
12762         when line 1 has been searched.
12763
12764 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12765
12766         * record-full.c (record_full_base_target::close): Rewrite
12767         record_full_core_buf_list free logic.
12768
12769 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12770
12771         * break-catch-syscall.c (print_one_catch_syscall): xfree
12772         the last text.
12773
12774 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12775
12776         * top.c (print_gdb_version): Update Copyright year in version
12777         message.
12778
12779 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12780
12781         Update copyright year range in all GDB files.
12782
12783 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12784
12785         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12786
12787 For older changes see ChangeLog-2018.
12788 \f
12789 Local Variables:
12790 mode: change-log
12791 left-margin: 8
12792 fill-column: 74
12793 version-control: never
12794 coding: utf-8
12795 End:
12796