gdb/ChangeLog

   1 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * event-top.c: Remove include comment.
   4         * inflow.c (class scoped_ignore_sigttou): Move from here...
   5         * inflow.h (class scoped_ignore_sigttou): ...to here.
   6         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
   7         * top.c:  Remove include comment.
   8
   9 2019-05-27  Tom Tromey  <tom@tromey.com>
  10
  11         * NEWS: Fix typo.
  12
  13 2019-05-22  Tom Tromey  <tromey@adacore.com>
  14
  15         * target.c (target_follow_exec): Constify parameter.
  16         * target-delegates.c: Rebuild.
  17         * remote.c (remote_target::follow_exec): Constify parameter.
  18         * infrun.c (follow_exec): Constify parameter.
  19         * target.h (struct target_ops) <follow_exec>: Constify parameter.
  20         (target_follow_exec): Likewise.
  21
  22 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  23
  24         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
  25         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
  26
  27 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  28
  29         * NEWS: Add debugredirect and testsuite sections.
  30
  31 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
  32
  33         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
  34         target descriptions using exclusively floating point register name
  35         aliases.
  36
  37 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  38
  39         PR gdb/18644:
  40         * f-lang.c (build_fortran_types): Handle the case where
  41         gdbarch_floatformat_for_type returns a nullptr.
  42
  43 2019-05-21  Tom de Vries  <tdevries@suse.de>
  44
  45         PR cli/24587
  46         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  47
  48 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  49
  50         PR gdb/18644:
  51         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  52         16-byte floats.
  53         * i386-tdep.c (i386_floatformat_for_type): Use
  54         floatformats_ia64_quad for the 16-byte floating point component
  55         within a fortran 32-byte complex number.
  56
  57 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  60         delete default constructor.
  61         (find_partial_die): Update to return const struct.
  62         (partial_die_parent_scope): Move variable declaration into scope
  63         of its use and change its type to auto.
  64         (guess_partial_die_structure_name): Likewise.
  65         (partial_die_info::fixup): Likewise.
  66
  67 2019-05-17  Tom Tromey  <tromey@adacore.com>
  68
  69         * source.c (find_and_open_source): Remove cast.
  70
  71 2019-05-17  Tom Tromey  <tromey@adacore.com>
  72
  73         * annotate.c (annotate_source): Make "filename" const.
  74         * annotate.h (annotate_source): Use const.
  75
  76 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  77
  78         * disasm.c (set_disassembler_options): Send errors to stderr.
  79
  80 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  81
  82         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  83         (cli_interp_base::set_logging): Check debug_redirect.
  84         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  85         * cli/cli-logging.c (debug_redirect): Add static variable.
  86         (pop_output_files): Add default param.
  87         (handle_redirections): Print debug setting.
  88         (show_logging_command): Likewise.
  89         (_initialize_cli_logging): Add debugredirect command.
  90         * interps.c (current_interp_set_logging): Add debug_redirect
  91         parameter.
  92         * interps.h (set_logging): Add debug_redirect parameter.
  93         (current_interp_set_logging): Likewise.
  94         * mi/mi-common.h: Likewise.
  95         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  96
  97 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  98             Tom Tromey  <tromey@adacore.com>
  99
 100         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 101         directly.
 102         * cli/cli-interp.h (make_logging_output): Remove declaration.
 103         * cli/cli-logging.c (make_logging_output): Remove function.
 104         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 105         directly.
 106         * ui-file.c (tee_file::tee_file): Remove bools.
 107         (tee_file::~tee_file): Remove deletes.
 108         * ui-file.h (tee_file): Remove bools.
 109
 110 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 111
 112         * mi/mi-cmds.h (mi_cmd_complete): New function.
 113         * mi/mi-main.c (mi_cmd_complete): Likewise.
 114         * mi/mi-cmds.c: Define new MI command -complete.
 115         * NEWS: Mention new -complete command.
 116
 117 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 118
 119         * completer.h (complete): New function.
 120         * completer.c (complete): Likewise.
 121         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 122         function defined in completer.h.
 123
 124 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 125
 126        * MAINTAINERS (Write After Approval): Add myself.
 127
 128 2019-05-17  Tom de Vries  <tdevries@suse.de>
 129
 130         PR gdb/24094
 131         * dwarf2read.c (struct cu_partial_die_info): New struct.
 132         (find_partial_die): Return cu_partial_die_info.
 133         (partial_die_parent_scope, guess_partial_die_structure_name)
 134         (partial_die_info::fixup): Handle new return type of find_partial_die.
 135
 136 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 137
 138         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 139         "std::string", simplifying the algorithm.
 140
 141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 142
 143         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 144         (stap_static_probe_ops::get_probes): Likewise.
 145
 146 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 147
 148         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 149         '-')" and "else if".
 150         (stap_parse_single_operand): Join checks for
 151         "gdbarch_stap_parse_special_token_p" and
 152         "gdbarch_stap_parse_special_token" in the same "if" statement.
 153         Invert check when verifying for operation on register
 154         displacement.
 155
 156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 157
 158         * stap-probe.c (stap_get_opcode): Update comment.
 159         (stap_get_expected_argument_type): Likewise.
 160         (handle_stap_probe): Likewise.
 161
 162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 163
 164         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 165         return type to 'bool'.  Adjust comment.  Use 'bool' when
 166         appropriate.
 167         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 168         * stap-probe.c (stap_parse_argument_1): Likewise.
 169         (stap_is_operator): Likewise.
 170         (stap_is_generic_prefix): Likewise.
 171         (stap_is_register_prefix): Likewise.
 172         (stap_is_register_indirection_prefix): Likewise.
 173         (stap_is_integer_prefix): Likewise.
 174         (stap_generic_check_suffix): Likewise.
 175         (stap_check_integer_suffix): Likewise.
 176         (stap_check_register_suffix): Likewise.
 177         (stap_check_register_indirection_suffix): Likewise.
 178         (stap_parse_register_operand): Likewise.
 179         (stap_parse_single_operand): Likewise.
 180         (stap_parse_argument_1): Likewise.
 181         (stap_probe::get_argument_count): Likewise.
 182         (stap_is_operator): Likewise.
 183
 184 2019-05-16  Tom Tromey  <tromey@adacore.com>
 185
 186         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 187         keyword to foreach.
 188
 189 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 190
 191         * linux-thread-db.c (try_thread_db_load_1): Change return type
 192         to bool.
 193         (try_thread_db_load): Likewise.
 194         (try_thread_db_load_from_pdir_1): Likewise.
 195         (try_thread_db_load_from_pdir): Likewise.
 196         (try_thread_db_load_from_sdir): Likewise.
 197         (try_thread_db_load_from_dir): Likewise.
 198         (thread_db_load_search): Likewise.
 199         (has_libpthread): Likewise.
 200         (thread_db_load): Likewise.
 201
 202 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 203
 204         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 205         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 206         NULL, and complain/return if that's the case.
 207
 208 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 209
 210         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 211         (advance, posn, abstract_read_memory): New functions.
 212         [struct mem_read_abstraction]: New struct.
 213         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 214
 215 2019-05-14  Tom Tromey  <tromey@adacore.com>
 216
 217         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 218         value is not lval_memory.
 219
 220 2019-05-14  Tom Tromey  <tromey@adacore.com>
 221
 222         * solib.c (info_sharedlibrary_command): Style the file name.
 223
 224 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 225
 226         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 227         (aarch64_vnv_type): Likewise.
 228         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 229         * common/tdesc.c: Likewise.
 230         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 231         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 232         * features/aarch64-fpu.xml: Add ieee half view.
 233         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 234         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 235         * gdbtypes.h (struct builtin_type): Likewise.
 236         (struct objfile_type): Likewise.
 237
 238 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 239
 240         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 241         typo.
 242         * location.h (string_to_event_location): Likewise.
 243
 244 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 245
 246         GDB 8.3 released.
 247
 248 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 249
 250         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 251         New variable declaration.
 252         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 253         New variable.
 254         (print_one_breakpoint): Use ui_out::test_flags and new global
 255         variable to compute use_fixed_output.
 256         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 257         Remove.
 258         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 259         (mi_multi_location_breakpoint_output_fixed): Remove.
 260         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 261         new variable.
 262         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 263         fix_multi_location_breakpoint_output flag if version >= 3.
 264         * ui-out.h (enum ui_out_flag)
 265         <fix_multi_location_breakpoint_output>: New enumerator.
 266
 267 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 268
 269         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 270
 271 2019-05-10  Tom Tromey  <tromey@adacore.com>
 272
 273         * ada-lang.c (catch_ada_completer): New function.
 274         (_initialize_ada_language): Use it.
 275
 276 2019-05-10  Tom Tromey  <tromey@adacore.com>
 277
 278         * thread.c (print_thread_info): Make "requested_threads" const.
 279         * gdbthread.h (print_thread_info): Make "requested_threads"
 280         const.
 281         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 282         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 283
 284 2019-05-08  Tom Tromey  <tom@tromey.com>
 285
 286         * gdbtypes.c (objfile_type_data): Change type.
 287         (objfile_type, _initialize_gdbtypes): Update.
 288
 289 2019-05-08  Tom Tromey  <tom@tromey.com>
 290
 291         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 292         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 293         (_initialize_dwarf2_frame): Update.
 294
 295 2019-05-08  Tom Tromey  <tom@tromey.com>
 296
 297         * objc-lang.c (objc_objfile_data): Change type.
 298         (find_methods): Update.
 299         (_initialize_objc_lang): Remove.
 300
 301 2019-05-08  Tom Tromey  <tom@tromey.com>
 302
 303         * stabsread.c (rs6000_builtin_type_data): Change type.
 304         (rs6000_builtin_type, _initialize_stabsread): Update.
 305
 306 2019-05-08  Tom Tromey  <tom@tromey.com>
 307
 308         * mips-tdep.c (mips_pdr_data): Remove.
 309         (_initialize_mips_tdep): Update.
 310
 311 2019-05-08  Tom Tromey  <tom@tromey.com>
 312
 313         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 314         (hppa_init_objfile_priv_data, read_unwind_info)
 315         (find_unwind_entry, _initialize_hppa_tdep): Update.
 316
 317 2019-05-08  Tom Tromey  <tom@tromey.com>
 318
 319         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 320         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 321         on obstack.
 322         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 323
 324 2019-05-08  Tom Tromey  <tom@tromey.com>
 325
 326         * mdebugread.c (basic_type_data): Change type.
 327         (basic_type, _initialize_mdebugread): Update.
 328
 329 2019-05-08  Tom Tromey  <tom@tromey.com>
 330
 331         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 332
 333 2019-05-08  Tom Tromey  <tom@tromey.com>
 334
 335         * nto-tdep.c (nto_inferior_data_reg): Change type.
 336         (nto_inferior_data): Update.
 337         (nto_inferior_data_cleanup, nto_new_inferior_data)
 338         (_initialize_nto_tdep): Remove.
 339         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 340
 341 2019-05-08  Tom Tromey  <tom@tromey.com>
 342
 343         * ada-lang.c (struct ada_inferior_data): Add initializers.
 344         (ada_inferior_data): Change type.
 345         (ada_inferior_data_cleanup): Remove.
 346         (get_ada_inferior_data, ada_inferior_exit)
 347         (struct ada_pspace_data): Add initializers, destructor.
 348         (ada_pspace_data_handle): Change type.
 349         (get_ada_pspace_data): Update.
 350         (ada_pspace_data_cleanup): Remove.
 351
 352 2019-05-08  Tom Tromey  <tom@tromey.com>
 353
 354         * coffread.c (struct coff_symfile_info): Add initializers.
 355         (coff_objfile_data_key): Move lower.  Change type.
 356         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 357         Update.
 358         (coff_free_info): Remove.
 359
 360 2019-05-08  Tom Tromey  <tom@tromey.com>
 361
 362         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 363         (fbsd_pspace_data_handle): Move lower.  Change type.
 364         (get_fbsd_pspace_data): Update.
 365         (fbsd_pspace_data_cleanup): Remove.
 366         (_initialize_fbsd_tdep): Update.
 367
 368 2019-05-08  Tom Tromey  <tom@tromey.com>
 369
 370         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 371         (get_ada_tasks_pspace_data): Update.
 372         (ada_tasks_pspace_data_cleanup): Remove.
 373         (_initialize_tasks): Update.
 374         (ada_tasks_inferior_data_handle): Change type.
 375         (get_ada_tasks_inferior_data): Update.
 376         (ada_tasks_inferior_data_cleanup): Remove.
 377         (struct ada_tasks_pspace_data): Add initializers.
 378
 379 2019-05-08  Tom Tromey  <tom@tromey.com>
 380
 381         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 382         * symfile-debug.c (debug_sym_get_probes): Change type.
 383         * stap-probe.c (handle_stap_probe):
 384         (stap_static_probe_ops::get_probes): Change type.
 385         * probe.h (class static_probe_ops) <get_probes>: Change type.
 386         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 387         (parse_probes_in_pspace): Update.
 388         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 389         Update.
 390         (any_static_probe_ops::get_probes): Change type.
 391         * elfread.c (elfread_data): New typedef.
 392         (probe_key): Change type.
 393         (elf_get_probes): Likewise.  Update.
 394         (probe_key_free): Remove.
 395         (_initialize_elfread): Update.
 396         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 397         Change type.
 398         (dtrace_process_dof_probe, dtrace_process_dof)
 399         (dtrace_static_probe_ops::get_probe): Change type.
 400
 401 2019-05-08  Tom Tromey  <tom@tromey.com>
 402
 403         * xcoffread.c (struct xcoff_symfile_info): Rename from
 404         coff_symfile_info.  Add initializers.
 405         (xcoff_objfile_data_key): Move lower.  Change type.
 406         (XCOFF_DATA): Rewrite.
 407         (xcoff_free_info): Remove.
 408         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 409         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 410         (xcoff_initial_scan): Update.
 411
 412 2019-05-08  Tom Tromey  <tom@tromey.com>
 413
 414         * solib-svr4.c (struct svr4_info): Add initializers and
 415         destructor.
 416         <probes_table>: Now an htab_up.
 417         (solib_svr4_pspace_data): Change type.
 418         (free_probes_table): Simplify.
 419         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 420         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 421         (probes_table_remove_objfile_probes, register_solib_event_probe)
 422         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 423         (_initialize_svr4_solib): Update.
 424
 425 2019-05-08  Tom Tromey  <tom@tromey.com>
 426
 427         * remote.c (remote_pspace_data): Change type.
 428         (remote_pspace_data_cleanup): Remove.
 429         (get_remote_exec_file, set_pspace_remote_exec_file)
 430         (_initialize_remote): Update.
 431
 432 2019-05-08  Tom Tromey  <tom@tromey.com>
 433
 434         * breakpoint.c (breakpoint_objfile_key): Change type.
 435         (get_breakpoint_objfile_data): Update.
 436         (free_breakpoint_objfile_data): Remove.
 437         (_initialize_breakpoint): Update.
 438
 439 2019-05-08  Tom Tromey  <tom@tromey.com>
 440
 441         * linux-tdep.c (struct linux_info): Add initializers.
 442         (linux_inferior_data): Move.  Change type.
 443         (invalidate_linux_cache_inf): Update.
 444         (linux_inferior_data_cleanup): Remove.
 445         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 446
 447 2019-05-08  Tom Tromey  <tom@tromey.com>
 448
 449         * auxv.c (auxv_inferior_data): Move.  Change type.
 450         (auxv_inferior_data_cleanup): Remove.
 451         (invalidate_auxv_cache_inf): Rewrite.
 452         (get_auxv_inferior_data, _initialize_auxv): Update.
 453
 454 2019-05-08  Tom Tromey  <tom@tromey.com>
 455
 456         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 457         (symfile_debug_objfile_data_key): Change type.
 458         (symfile_debug_installed, debug_qf_has_symbols)
 459         (debug_qf_find_last_source_symtab)
 460         (debug_qf_forget_cached_source_info)
 461         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 462         (debug_qf_print_stats, debug_qf_dump)
 463         (debug_qf_expand_symtabs_for_function)
 464         (debug_qf_expand_all_symtabs)
 465         (debug_qf_expand_symtabs_with_fullname)
 466         (debug_qf_map_matching_symbols)
 467         (debug_qf_expand_symtabs_matching)
 468         (debug_qf_find_pc_sect_compunit_symtab)
 469         (debug_qf_map_symbol_filenames)
 470         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 471         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 472         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 473         (debug_sym_read_linetable, debug_sym_relocate): Update.
 474         (symfile_debug_free_objfile): Remove.
 475         (install_symfile_debug_logging, _initialize_symfile_debug):
 476         Update.
 477
 478 2019-05-08  Tom Tromey  <tom@tromey.com>
 479
 480         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 481         allocate_on_obstack.
 482         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 483         (get_dwarf2_per_objfile): Update.
 484         (set_dwarf2_per_objfile): Remove.
 485         (dwarf2_has_info, dwarf2_get_section_info): Update.
 486         (dwarf2_free_objfile): Remove.
 487         (_initialize_dwarf2_read): Update.
 488
 489 2019-05-08  Tom Tromey  <tom@tromey.com>
 490
 491         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 492         initializers.
 493         <unsupported_script_warning_printed,
 494         script_not_found_warning_printed>: Now bool.
 495         (auto_load_pspace_data): Change type.
 496         (~auto_load_pspace_info): Rename from
 497         auto_load_pspace_data_cleanup.
 498         (get_auto_load_pspace_data, init_loaded_scripts_info)
 499         (clear_section_scripts, maybe_print_unsupported_script_warning)
 500         (maybe_print_script_not_found_warning, _initialize_auto_load):
 501         Update.
 502
 503 2019-05-08  Tom Tromey  <tom@tromey.com>
 504
 505         * objfiles.c (objfile_pspace_info): Add destructor and
 506         initializers.
 507         (objfiles_pspace_data): Change type.
 508         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 509         (get_objfile_pspace_data): Update.
 510         (objfiles_bfd_data): Change type.
 511         (get_objfile_bfd_data): Update.
 512         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 513
 514 2019-05-08  Tom Tromey  <tom@tromey.com>
 515
 516         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 517         Change type.
 518         (get_catch_syscall_inferior_data): Update.
 519         (catch_syscall_inferior_data_cleanup): Remove.
 520         (_initialize_break_catch_syscall): Update.
 521
 522 2019-05-08  Tom Tromey  <tom@tromey.com>
 523
 524         * inflow.c (struct terminal_info): Add destructor and
 525         initializers.
 526         (inflow_inferior_data): Change type.
 527         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 528         (get_inflow_inferior_data, inflow_inferior_exit)
 529         (swap_terminal_info, _initialize_inflow): Update.
 530
 531 2019-05-08  Tom Tromey  <tom@tromey.com>
 532
 533         * target-dcache.c (target_dcache_cleanup): Remove.
 534         (target_dcache_aspace_key): Change type.
 535         (target_dcache_init_p, target_dcache_invalidate)
 536         (target_dcache_get, target_dcache_get_or_init)
 537         (_initialize_target_dcache): Update.
 538         * dcache.h (struct dcache_deleter): New.
 539
 540 2019-05-08  Tom Tromey  <tom@tromey.com>
 541
 542         * symtab.c (struct symbol_cache): Add destructor and
 543         initializers.
 544         (symbol_cache_key): Move.  Change type.
 545         (make_symbol_cache, free_symbol_cache): Remove.
 546         (get_symbol_cache): Update.
 547         (symbol_cache_cleanup): Remove.
 548         (ALL_PSPACES, symbol_cache_flush)
 549         (maintenance_print_symbol_cache)
 550         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 551         Update.
 552
 553 2019-05-08  Tom Tromey  <tom@tromey.com>
 554
 555         * symtab.c (struct main_info): Add destructor and initializers.
 556         (main_progspace_key): Move.  Change type.
 557         (get_main_info): Update.
 558         (main_info_cleanup): Remove.
 559         (_initialize_symtab): Update.
 560
 561 2019-05-08  Tom Tromey  <tom@tromey.com>
 562
 563         * registry.h (DECLARE_REGISTRY): Define the _key class.
 564
 565 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * NEWS: Merge two 'New commands' sections.
 568
 569 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 570
 571         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 572         parameter and use Ada language definition instead.
 573         (ada_val_print_ptr): Remove unused language parameter.
 574         (ada_val_print_num): Remove language parameter and use Ada language
 575         definition instead.
 576         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 577         parameter.
 578         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 579         parameter and use Ada language definition instead.
 580         (ada_val_print_1): Update all ada_val_print_xxx calls.
 581         Remove language parameter.
 582         (ada_val_print): Update ada_val_print_1 call.
 583
 584 2019-05-08  Tom Tromey  <tromey@adacore.com>
 585
 586         * remote.c (remote_hw_watchpoint_limit)
 587         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 588         Now static.
 589
 590 2019-05-08  Tom Tromey  <tromey@adacore.com>
 591
 592         * maint.c (_initialize_maint_cmds): Move initialization code to
 593         remote.c.
 594         (watchdog, show_watchdog): Move to remote.c.
 595         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 596         "watchdog" static.
 597         (_initialize_remote): Move initialization code from maint.c.
 598         * defs.h (watchdog): Don't declare.
 599
 600 2019-05-08  Tom Tromey  <tromey@adacore.com>
 601
 602         * tui/tui-interp.c: Include main.h.
 603         * interps.c: Include main.h.
 604         * main.h (interpreter_p): Declare.
 605         * defs.h (interpreter_p): Don't declare.
 606
 607 2019-05-08  Tom Tromey  <tromey@adacore.com>
 608
 609         * dwarf2loc.c: Include dwarf2read.h.
 610         * defs.h (read_unsigned_leb128): Don't declare.
 611         * dwarf2read.h (read_unsigned_leb128): Declare.
 612
 613 2019-05-08  Tom Tromey  <tromey@adacore.com>
 614
 615         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 616         method.
 617
 618 2019-05-08  Tom Tromey  <tromey@adacore.com>
 619
 620         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 621         when no wrap column is set.
 622
 623 2019-05-08  Tom Tromey  <tromey@adacore.com>
 624
 625         * c-lang.c (c_get_string): Handle non-C-style arrays.
 626
 627 2019-05-08  Tom Tromey  <tromey@adacore.com>
 628
 629         * typeprint.c (print_offset_data::update): Print the bit offset,
 630         not the number of bits remaining.
 631
 632 2019-05-08  Tom Tromey  <tromey@adacore.com>
 633
 634         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 635         padding at end of comment.
 636
 637 2019-05-08  Tom Tromey  <tromey@adacore.com>
 638
 639         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 640         Compare main types.
 641
 642 2019-05-06  Tom Tromey  <tom@tromey.com>
 643
 644         * common/scoped_mmap.c: Include common-defs.h.
 645         * common/scoped_mmap.h: Don't include config.h.
 646
 647 2019-05-04  Tom Tromey  <tom@tromey.com>
 648
 649         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 650         (struct aarch64_call_info): Add initializers.
 651         <si>: Now a std::vector.
 652         (pass_on_stack, aarch64_push_dummy_call): Update.
 653
 654 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 655             Tom Tromey  <tom@tromey.com>
 656
 657         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 658         (ppc_threads): Now a std::vector.  Now static.
 659         (hwdebug_find_thread_points_by_tid)
 660         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 661         Update.
 662
 663 2019-05-04  Tom Tromey  <tom@tromey.com>
 664
 665         * arc-tdep.c (arc_tdesc_init): Return bool.
 666
 667 2019-05-04  Tom Tromey  <tom@tromey.com>
 668
 669         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 670         Use gdb_assert_not_reached.
 671
 672 2019-05-04  Tom Tromey  <tom@tromey.com>
 673
 674         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 675         "false".
 676
 677 2019-05-04  Tom Tromey  <tom@tromey.com>
 678
 679         * arc-tdep.c (arc_tdesc_init): Use bool.
 680
 681 2019-05-04  Tom Tromey  <tom@tromey.com>
 682
 683         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 684
 685 2019-05-04  Tom Tromey  <tom@tromey.com>
 686
 687         * cli/cli-cmds.c (valid_command_p): Return bool.
 688
 689 2019-05-04  Tom Tromey  <tom@tromey.com>
 690
 691         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 692         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 693
 694 2019-05-04  Raul Tambre  <raul@tambre.ee>
 695
 696         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 697         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 698         operator for comparison.
 699
 700 2019-05-04  Tom Tromey  <tom@tromey.com>
 701
 702         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 703         (lookup_partial_symbol, print_partial_symbols)
 704         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 705         (psymbol_compare): Update.
 706         (add_psymbol_to_bcache): Clear the entire psymbol.
 707         (maintenance_check_psymtabs): Update.
 708         * psympriv.h (struct partial_symbol): Don't derive from
 709         general_symbol_info.
 710         <obj_section, unrelocated_address, address,
 711         set_unrelocated_address>: Update.
 712         <ginfo>: New member.
 713         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 714         (debug_names::write_psymbols): Update.
 715
 716 2019-05-04  Tom de Vries  <tdevries@suse.de>
 717
 718         * contrib/cc-with-tweaks.sh: Support -n arg.
 719
 720 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 721
 722         * corelow.c (core_target::detach): Ensure frame cache and
 723         register caches are cleared.
 724         inferior.c (exit_inferior_1): Likewise.
 725
 726 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 727             Tom Tromey  <tom@tromey.com>
 728
 729         * dictionary.c (collate_pending_symbols_by_language): Remove
 730         "struct" from foreach.
 731         * symtab.c (lookup_global_symbol_from_objfile)
 732         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 733         foreach.
 734         * ser-tcp.c (net_open): Remove "struct" from foreach.
 735         * objfiles.c (objfile_relocate, objfile_rebase)
 736         (objfile_has_symbols): Remove "struct" from foreach.
 737         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 738         from foreach.
 739         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 740         foreach.
 741         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 742         "struct" from foreach.
 743         * ada-lang.c (create_excep_cond_exprs)
 744         (ada_exception_catchpoint_cond_string): Remove "struct" from
 745         foreach.
 746
 747 2019-05-03  Tom Tromey  <tromey@adacore.com>
 748
 749         * ada-exp.y (convert_char_literal): Check suffix of each
 750         enumerator.
 751
 752 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 753
 754         PR ada/21406:
 755         * ada-exp.y (yywrap): Don't define.
 756         * ada-lex.l (%option): Add noyywrap
 757         (yywrap): Remove.
 758
 759 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 760
 761         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 762         _WIN32_WINNT to the XP level, unless already defined to a higher
 763         level.
 764
 765         * unittests/parse-connection-spec-selftests.c:
 766         * ser-tcp.c:
 767         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 768         override.
 769
 770         * symfile.c (find_separate_debug_file): Remove colon from the
 771         drive spec of DOS/Windows file names of the target, so that the
 772         file name produced from DEBUGDIR and the target's directory will
 773         be valid on DOS/Windows systems.
 774
 775 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 776
 777         * rust-lang.c (val_print_struct): Handle printing structures
 778         containing strings.
 779
 780 2019-05-02  Tom Tromey  <tromey@adacore.com>
 781
 782         * valarith.c (_initialize_valarith): Remove.
 783
 784 2019-05-01  Tom Tromey  <tromey@adacore.com>
 785
 786         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 787         bitfields.
 788
 789 2019-05-01  Tom Tromey  <tromey@adacore.com>
 790
 791         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 792         for big-endian copies.
 793
 794 2019-04-30  Ali Tamur  <tamur@google.com>
 795         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 796         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 797         (read_3_bytes): New function.
 798
 799 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 800
 801         * windows-nat.c (main_thread_id): Delete.
 802         (handle_output_debug_string): Replace main_thread_id by
 803         current_event.dwThreadId.
 804         (fake_create_process): Likewise.
 805         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 806         Do not set main_thread_id.
 807         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 808         current_event.dwThreadId.
 809         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 810
 811 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 812
 813         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 814         Use current_event.dwThreadId instead of main_thread_id.
 815
 816 2019-04-30  Tom Tromey  <tromey@adacore.com>
 817
 818         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 819         (create_excep_cond_exprs): Iterate over program spaces.
 820         (ada_exception_catchpoint_cond_string): Examine all minimal
 821         symbols for exception types.
 822
 823 2019-04-30  Tom Tromey  <tromey@adacore.com>
 824
 825         PR c++/24470:
 826         * dwarf2read.c (process_structure_scope): Handle case where type
 827         has template parameters but no symbol was created.
 828
 829 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 830             Chris January  <chris.january@arm.com>
 831
 832         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 833         qualifier.
 834         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 835
 836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * f-typeprint.c (f_print_type): Update rules for printing
 839         whitespace.
 840         (f_type_print_varspec_suffix): Likewise.
 841
 842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 843             Chris January  <chris.january@arm.com>
 844
 845         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 846         function arguments.
 847
 848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 849
 850         * f-lang.c (build_fortran_types): Change name of void type to
 851         lower case.
 852         * f-typeprint.c (f_type_print_base): Print the name of the void
 853         type, rather than a fixed string.
 854         * f-valprint.c (f_decorations): Use lower case void string.
 855
 856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 857             Chris January  <chris.january@arm.com>
 858
 859         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 860         types for Fortran.
 861
 862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 863             Chris January  <chris.january@arm.com>
 864             David Lecomber  <david.lecomber@arm.com>
 865
 866         * f-exp.y (BINOP_INTRINSIC): New token.
 867         (exp): New parser rule handling BINOP_INTRINSIC.
 868         (f77_keywords): Add new builtin procedures.
 869         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 870         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 871         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 872         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 873         (print_unop_subexp_f): New function.
 874         (print_binop_subexp_f): New function.
 875         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 876         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 877         (dump_subexp_body_f): Likewise.
 878         (operator_check_f): Likewise.
 879         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 880         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 881
 882 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 885         UNOP_KIND.
 886         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 887         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 888         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 889         (operator_length_f): New fuction.
 890         (print_subexp_f): New function.
 891         (op_name_f): New function.
 892         (dump_subexp_body_f): New function.
 893         (operator_check_f): New function.
 894         (exp_descriptor_f): Replace standard expression handling functions
 895         with new functions.
 896         * gdb/fortran-operator.def: New file.
 897         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 898         * gdb/std-operator.def: Remove UNOP_KIND.
 899
 900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * std-operator.def: Remove unbalanced, stray double quote
 903         character.
 904
 905 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 906             Chris January  <chris.january@arm.com>
 907             Daniel Everett  <daniel.everett@arm.com>
 908             Nick Forrington  <nick.forrington@arm.com>
 909             Richard Bunt  <richard.bunt@arm.com>
 910
 911         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 912         of depth when printing anonymous structs or unions.
 913         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 914         Don't print either the top-level value, or the children if the
 915         max-depth is exceeded.
 916         (ppscm_print_children): When printing the key of a map, allow one
 917         extra level of depth.
 918         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 919         print either the top-level value, or the children if the max-depth
 920         is exceeded.
 921         (print_children): When printing the key of a map, allow one extra
 922         level of depth.
 923         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 924         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 925         (user_print_options): Initialise max_depth field.
 926         (val_print_scalar_or_string_type_p): New function.
 927         (val_print): Check to see if the max depth has been reached.
 928         (val_print_check_max_depth): Define new function.
 929         (show_print_max_depth): New function.
 930         (_initialize_valprint): Add 'print max-depth' option.
 931         * valprint.h (struct value_print_options) <max_depth>: New field.
 932         (val_print_check_max_depth): Declare new function.
 933         * NEWS: Document new feature.
 934
 935 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * ada-lang.c (ada_language_defn): Initialise new field.
 938         * c-lang.c (c_is_string_type_p): New function.
 939         (c_language_defn): Initialise new field.
 940         (cplus_language_defn): Initialise new field.
 941         (asm_language_defn): Initialise new field.
 942         (minimal_language_defn): Initialise new field.
 943         * c-lang.h (c_is_string_type_p): Declare new function.
 944         * d-lang.c (d_language_defn): Initialise new field.
 945         * f-lang.c (f_is_string_type_p): New function.
 946         (f_language_defn): Initialise new field.
 947         * go-lang.c (go_is_string_type_p): New function.
 948         (go_language_defn): Initialise new field.
 949         * language.c (default_is_string_type_p): New function.
 950         (unknown_language_defn): Initialise new field.
 951         (auto_language_defn): Initialise new field.
 952         * language.h (struct language_defn) <la_is_string_type_p>: New
 953         member variable.
 954         (default_is_string_type_p): Declare new function.
 955         * m2-lang.c (m2_language_defn): Initialise new field.
 956         * objc-lang.c (objc_language_defn): Initialise new field.
 957         * opencl-lang.c (opencl_language_defn): Initialise new field.
 958         * p-lang.c (pascal_is_string_type_p): New function.
 959         (pascal_language_defn): Initialise new field.
 960         * rust-lang.c (rust_is_string_type_p): New function.
 961         (rust_language_defn): Initialise new field.
 962
 963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 966         New field.
 967         * ada-lang.c (ada_language_defn): Initialise new field.
 968         * c-lang.c (c_language_defn): Likewise.
 969         (cplus_language_defn): Likewise.
 970         (asm_language_defn): Likewise.
 971         (minimal_language_defn): Likewise.
 972         * d-lang.c (d_language_defn): Likewise.
 973         * f-lang.c (f_language_defn): Likewise.
 974         * go-lang.c (go_language_defn): Likewise.
 975         * language.c (unknown_language_defn): Likewise.
 976         (auto_language_defn): Likewise.
 977         * m2-lang.c (m2_language_defn): Likewise.
 978         * objc-lang.c (objc_language_defn): Likewise.
 979         * opencl-lang.c (opencl_language_defn): Likewise.
 980         * p-lang.c (pascal_language_defn): Likewise.
 981         * rust-lang.c (rust_language_defn): Likewise.
 982
 983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * ada-lang.c (ada_is_character_type): Change return type to bool.
 986         (ada_is_string_type): Likewise.
 987         * ada-lang.h (ada_is_character_type): Update declaration
 988         (ada_is_string_type): Likewise.
 989
 990 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 991
 992         Support style in 'frame|thread apply'
 993
 994         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 995         * record.c (record_start, record_stop): Update callers of
 996         execute_command_to_string with false.
 997         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 998         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 999         methods.
1000         (class string_file): New constructor with term_out parameter.
1001         Override methods term_out and can_emit_style_escape.  New member
1002         term_out.
1003         (class stdio_file): Override can_emit_style_escape.
1004         (class tee_file): Override term_out and can_emit_style_escape.
1005         * utils.h (can_emit_style_escape): Remove.
1006         * utils.c (can_emit_style_escape): Likewise.
1007         Update all callers of can_emit_style_escape (SOMESTREAM) to
1008         SOMESTREAM->can_emit_style_escape.
1009         * source-cache.c (source_cache::get_source_lines): Likewise.
1010         * stack.c (frame_apply_command_count): Call execute_command_to_string
1011         passing the term_out characteristic of the current gdb_stdout.
1012         * thread.c (thr_try_catch_cmd): Likewise.
1013         * top.c (execute_command_to_string): pass term_out parameter
1014         to construct the string_file for the command output.
1015         * ui-file.c (term_cli_styling): New function (most code moved
1016         from utils.c can_emit_style_escape).
1017         (string_file::string_file, string_file::can_emit_style_escape,
1018         stdio_file::can_emit_style_escape, tee_file::term_out,
1019         tee_file::can_emit_style_escape): New functions.
1020
1021 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1022
1023         * NEWS: Mention the new set|show may-call-functions.
1024         * infcall.c (may_call_functions_p): New variable.
1025         (show_may_call_functions_p): New function.
1026         (call_function_by_hand_dummy): Throws an error if not
1027         may-call-functions.
1028         (_initialize_infcall): Call add_setshow_boolean_cmd for
1029         may-call-functions.
1030
1031 2019-04-25  Keith Seitz  <keiths@redhat.com>
1032
1033         PR c++/24367
1034         * cp-support.c (inspect_type): Don't attempt substitutions
1035         of symbol with the same name.
1036
1037 2019-04-25  Tom Tromey  <tromey@adacore.com>
1038
1039         PR gdb/24475:
1040         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1041         static.
1042
1043 2019-04-25  Tom Tromey  <tromey@adacore.com>
1044
1045         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1046         rvalue reference.
1047         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1048         (gdb_xml_parser::parse): Use std::move.
1049         * python/python-internal.h (gdbpy_convert_exception): Take a const
1050         reference.
1051         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1052         std::move.
1053         * python/py-utils.c (gdbpy_convert_exception): Take a const
1054         reference.
1055         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1056         Use std::move.
1057         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1058         Use std::move.
1059         * mi/mi-main.c (mi_print_exception): Take a const reference.
1060         * main.c (handle_command_errors): Take a const reference.
1061         * linespec.c (parse_linespec): Use std::move.
1062         * infcall.c (run_inferior_call): Use std::move.
1063         (call_function_by_hand_dummy): Use std::move.
1064         * exec.c (try_open_exec_file): Use std::move.
1065         * exceptions.h (exception_print, exception_fprintf)
1066         (exception_print_same): Update.
1067         * exceptions.c (print_exception, exception_print)
1068         (exception_fprintf, exception_print_same): Change parameters to
1069         const reference.
1070         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1071         * common/new-op.c: Use std::move.
1072         * common/common-exceptions.h (struct gdb_exception): Add move
1073         constructor.
1074         (struct gdb_exception_error, struct gdb_exception_quit, struct
1075         gdb_quit_bad_alloc): Change constructor to move constructor.
1076         (throw_exception): Change parameter to rvalue reference.
1077         * common/common-exceptions.c (throw_exception): Take rvalue
1078         reference.
1079         * cli/cli-interp.c (safe_execute_command): Use std::move.
1080         * breakpoint.c (insert_bp_location, location_to_sals): Use
1081         std::move.
1082
1083 2019-04-25  Tom Tromey  <tromey@adacore.com>
1084
1085         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1086         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1087         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1088         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1089         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1090         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1091         guile/scm-value.c: Use unpack.
1092         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1093         gdbscm_gdb_exception.
1094         (gdbscm_throw_gdb_exception): Likewise.
1095         (struct gdbscm_gdb_exception): New.
1096         (unpack): New function.
1097         (gdbscm_wrap): Use unpack.
1098
1099 2019-04-25  Tom Tromey  <tromey@adacore.com>
1100
1101         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1102         (gdb_rl_callback_handler): Use std::move.
1103         * common/common-exceptions.h (struct gdb_exception): Add move
1104         assignment operator.
1105         (throw_exception_sjlj): Change "exception" to const reference.
1106         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1107         (throw_exception_sjlj): Change "exception" to const reference.
1108
1109 2019-04-25  Tom Tromey  <tromey@adacore.com>
1110
1111         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1112         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1113         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1114         Update.
1115         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1116         Update.
1117         * mi/mi-interp.c (mi_interp::exec): Update.
1118         * linespec.c (parse_linespec): Update.
1119         * infcall.c (run_inferior_call): Update.
1120         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1121         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1122         (gdbscm_lookup_global_symbol): Update.
1123         * guile/scm-param.c (gdbscm_parameter_value): Update.
1124         * guile/scm-frame.c (gdbscm_frame_read_register)
1125         (gdbscm_frame_read_var): Update.
1126         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1127         * exec.c (try_open_exec_file): Update.
1128         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1129         (gdb_rl_callback_handler): Update.
1130         * common/common-exceptions.h (exception_none): Don't declare.
1131         * common/common-exceptions.c (exception_none): Don't define.
1132         (struct catcher) <exception>: Update.
1133         * cli/cli-interp.c (safe_execute_command): Update.
1134         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1135
1136 2019-04-25  Ali Tamur  <tamur@google.com>
1137
1138         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1139         (read_attribute_value): Likewise.
1140         (dwarf2_read_addr_index): Update comment.
1141         (read_str_index): Add DW_FORM_strx.
1142         (dwarf2_string_attr): Likewise.
1143         (dwarf2_const_value_attr): Likewise.
1144         (dump_die_shallow): Likewise.
1145         (dwarf2_fetch_constant_bytes): Likewise.
1146         (skip_form_bytes): Likewise.
1147         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1148
1149 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1150
1151         PR corefiles/11608
1152         PR corefiles/18187
1153         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1154         OFFSET.  Verify if current mapping contains an ELF header.
1155         (linux_find_memory_regions_full): Adjust call to
1156         dump_mapping_p.
1157
1158 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1159             Kang Li <kanglictf@gmail.com>
1160
1161         PR gdb/21600
1162
1163         * dwarf2-frame.c (read_initial_length): Be consistent about using
1164         unsigned representation of length.
1165         (decode_frame_entry_1): Likewise.  Check for wraparound of
1166         end pointer as well as buffer overflow.
1167
1168 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1169
1170         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1171         "vq".
1172
1173 2019-04-24  Tom Tromey  <tromey@adacore.com>
1174
1175         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1176
1177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * s12z-tdep.c (s12z_unwind_pc): Delete.
1180         (s12z_unwind_sp): Delete.
1181         (s12z_gdbarch_init): Don't register deleted functions with
1182         gdbarch.
1183
1184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * rl78-tdep.c (rl78_unwind_sp): Delete.
1187         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1188
1189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1192         (xstormy16_unwind_pc): Delete.
1193         (xstormy16_dummy_id): Delete.
1194         (xstormy16_gdbarch_init): Don't register deleted functions with
1195         gdbarch.
1196
1197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * vax-tdep.c (vax_unwind_pc): Delete.
1200         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1201
1202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * v850-tdep.c (v850_unwind_sp): Delete.
1205         (v850_unwind_pc): Delete.
1206         (v850_dummy_id): Delete.
1207         (v850_gdbarch_init): Don't register deleted functions with
1208         gdbarch.
1209
1210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1213         (tilegx_unwind_pc): Delete.
1214         (tilegx_unwind_dummy_id): Delete.
1215         (tilegx_gdbarch_init): Don't register deleted functions with
1216         gdbarch.
1217
1218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1221         (tic6x_dummy_id): Delete.
1222         (tic6x_gdbarch_init): Don't register deleted functions with
1223         gdbarch.
1224
1225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1226
1227         * sparc-tdep.c (sparc_unwind_pc): Delete.
1228         (sparc32_gdbarch_init): Don't register deleted function with
1229         gdbarch.
1230
1231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * sh-tdep.c (sh_unwind_sp): Delete.
1234         (sh_unwind_pc): Delete.
1235         (sh_dummy_id): Delete.
1236         (sh_gdbarch_init): Don't register deleted functions with
1237         gdbarch.
1238
1239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * score-tdep.c (score_unwind_sp): Delete.
1242         (score_unwind_pc): Delete.
1243         (score_dummy_id): Delete.
1244         (score_gdbarch_init): Don't register deleted functions with
1245         gdbarch.
1246
1247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1248
1249         * rx-tdep.c (rx_unwind_pc): Delete.
1250         (rx_unwind_sp): Delete.
1251         (rx_dummy_id): Delete.
1252         (rx_gdbarch_init): Don't register deleted functions with
1253         gdbarch.  Update comment.
1254
1255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1258         (rs6000_dummy_id): Delete.
1259         (rs6000_gdbarch_init): Don't register deleted functions with
1260         gdbarch.
1261
1262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * or1k-tdep.c (or1k_dummy_id): Delete.
1265         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1266
1267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * nios2-tdep.c (nios2_dummy_id): Delete.
1270         (nios2_unwind_sp): Delete.
1271         (nios2_gdbarch_init): Don't register deleted functions with
1272         gdbarch.
1273
1274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * nds32-tdep.c (nds32_dummy_id): Delete.
1277         (nds32_unwind_pc): Delete.
1278         (nds32_unwind_sp): Delete.
1279         (nds32_gdbarch_init): Don't register deleted functions with
1280         gdbarch.
1281
1282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * msp430-tdep.c (msp430_unwind_pc): Delete.
1285         (msp430_unwind_sp): Delete.
1286         (msp430_dummy_id): Delete.
1287         (msp430_gdbarch_init): Don't register deleted functions with
1288         gdbarch.
1289
1290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1291
1292         * moxie-tdep.c (moxie_unwind_sp): Delete.
1293         (moxie_unwind_pc): Delete.
1294         (moxie_dummy_id): Delete.
1295         (moxie_gdbarch_init): Don't register deleted functions with
1296         gdbarch.
1297
1298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1301         (mn10300_unwind_pc): Delete.
1302         (mn10300_unwind_sp): Delete.
1303         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1304         mn10300_unwind_sp.
1305         (mn10300_frame_unwind_init): Don't register deleted functions with
1306         gdbarch.
1307
1308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * mep-tdep.c (mep_unwind_pc): Delete.
1311         (mep_unwind_sp): Delete.
1312         (mep_dummy_id): Delete.
1313         (mep_gdbarch_init): Don't register deleted functions with
1314         gdbarch.
1315
1316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1317
1318         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1319         (m68hc11_unwind_sp): Delete.
1320         (m68hc11_gdbarch_init): Don't register deleted functions with
1321         gdbarch.
1322
1323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * m32r-tdep.c (m32r_unwind_sp): Delete.
1326         (m32r_unwind_pc): Delete.
1327         (m32r_dummy_id): Delete.
1328         (m32r_gdbarch_init): Don't register deleted functions with
1329         gdbarch.
1330
1331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * m32c-tdep.c (m32c_unwind_pc): Delete.
1334         (m32c_unwind_sp): Delete.
1335         (m32c_dummy_id): Delete.
1336         (m32c_gdbarch_init): Don't register deleted functions with
1337         gdbarch.
1338
1339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1340
1341         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1342         (lm32_unwind_pc): Delete.
1343         (lm32_dummy_id): Delete.
1344         (lm32_gdbarch_init): Don't register deleted functions with
1345         gdbarch.
1346
1347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1350         (iq2000_unwind_pc): Delete.
1351         (iq2000_dummy_id): Delete.
1352         (iq2000_gdbarch_init): Don't register deleted functions with
1353         gdbarch.
1354
1355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1356
1357         * nds32-tdep.c (nds32_type_align): Delete.
1358         (nds32_push_dummy_call): Use type_align instead.
1359
1360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * arm-tdep.c (arm_type_align): Only handle vector override case.
1363         (arm_push_dummy_call): Use type_align.
1364         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1365
1366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1367
1368         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1369         case.
1370         (pass_on_stack): Use type_align.
1371         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1372         function.
1373
1374 2019-04-23  Tom Tromey  <tromey@adacore.com>
1375
1376         * dwarf2read.c (line_header::file_name_at): Remove unused
1377         overload.
1378
1379 2019-04-23  Tom de Vries  <tdevries@suse.de>
1380
1381         PR gdb/24438
1382         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1383         invocation.
1384
1385
1386 2019-03-27  Ali Tamur  <tamur@google.com>
1387
1388         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1389         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1390         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1391         (dwarf_expr_context::get_addr_index): Likewise
1392         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1393         (symbol_needs_eval_context::get_addr_index): Likewise
1394         (disassemble_dwarf_expression): Add DW_OP_addrx
1395         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1396         (read_cutu_die_from_dwo): Update comment
1397         (skip_one_die): Add DW_FORM_addrx
1398         (read_attribute_value): Likewise
1399         (var_decode_location): Add DW_OP_addrx
1400         (dwarf2_const_value_attr): Add DW_FORM_addrx
1401         (dump_die_shallow): Likewise
1402         (dwarf2_fetch_constant_bytes): Likewise
1403         (decode_locdesc): Add DW_OP_addrx
1404         (skip_form_bytes): Add DW_FORM_addrx
1405
1406 2019-04-22  Ali Tamur  <tamur@google.com>
1407
1408         * MAINTAINERS (Write After Approval): Add self.
1409
1410 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1411
1412         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1413         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1414         (open_symbol_file_object): Likewise.
1415         (svr4_default_sos): Add info parameter.
1416         (svr4_read_so_list): Likewise.
1417         (svr4_current_sos_direct): Adjust functions calls to pass down
1418         info.
1419         (svr4_current_sos_1): Add info parameter.
1420         (svr4_current_sos): Call get_svr4_info, pass info down to
1421         svr4_current_sos_1.
1422         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1423         get_svr4_info.
1424         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1425         get_svr4_info.
1426         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1427         to get_svr4_info.
1428         (probes_table_remove_objfile_probes): Likewise.
1429         (register_solib_event_probe): Add info parameter.
1430         (solist_update_incremental): Pass info parameter down to
1431         svr4_read_so_list.
1432         (disable_probes_interface): Add info parameter.
1433         (svr4_handle_solib_event): Pass current_program_space to
1434         get_svr4_info.  Adjust disable_probes_interface cleanup.
1435         (svr4_create_probe_breakpoints): Add info parameter, pass it
1436         down to register_solib_event_probe.
1437         (svr4_create_solib_event_breakpoints): Add info parameter,
1438         pass it down to svr4_create_probe_breakpoints.
1439         (enable_break): Pass info down to
1440         svr4_create_solib_event_breakpoints.
1441         (svr4_solib_create_inferior_hook): Pass current_program_space to
1442         get_svr4_info.
1443         (svr4_clear_solib): Likewise.
1444
1445 2019-04-22  Pedro Alves  <palves@redhat.com>
1446
1447         * solib-svr4.c (svr4_free_objfile_observer): New.
1448         (probe_and_action::objfile): New field.
1449         (probes_table_htab_remove_objfile_probes)
1450         (probes_table_remove_objfile_probes): New functions.
1451         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1452         in the new probe_and_action.  Don't store the probe in 'lookup'.
1453         (svr4_create_probe_breakpoints): Pass objfile to
1454         register_solib_event_probe.
1455         (_initialize_svr4_solib): Register a free_objfile observer.
1456
1457 2019-04-19  Tom Tromey  <tom@tromey.com>
1458
1459         * common/queue.h: Remove.
1460
1461 2019-04-19  Tom Tromey  <tom@tromey.com>
1462
1463         * event-loop.c: Don't include "common/queue.h".
1464
1465 2019-04-19  Tom Tromey  <tom@tromey.com>
1466
1467         * remote.c (remote_target): Use delete.
1468         * remote-notif.h: Include <list>, not "common/queue.h".
1469         (notif_client_p): Remove typedef.
1470         (remote_notif_state): Add constructor, destructor, initializer.
1471         <notif_queue>: Now a std::list.
1472         (remote_notif_state_xfree): Don't declare.
1473         * remote-notif.c (remote_notif_process, handle_notification)
1474         (remote_notif_state_allocate): Update.
1475         (~remote_notif_state): Rename from remote_notif_state_xfree.
1476
1477 2019-04-19  Tom Tromey  <tom@tromey.com>
1478
1479         * symfile.c (reread_symbols): Update.
1480         * objfiles.c (objfile_register_static_link)
1481         (objfile_lookup_static_link): Update
1482         (~objfile) Don't delete static_links.
1483         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1484
1485 2019-04-19  Tom Tromey  <tom@tromey.com>
1486
1487         * type-stack.h (struct type_stack) <insert>: Constify string.
1488         * type-stack.c (type_stack::insert): Constify string.
1489         * gdbtypes.h (lookup_template_type): Update.
1490         (address_space_name_to_int): Update.
1491         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1492         const.
1493         (lookup_template_type): Make name const.
1494         * c-exp.y: Update rules.
1495         (lex_one_token, classify_name, classify_inner_name)
1496         (c_print_token): Update.
1497         * p-exp.y: Update rules.
1498         (yylex): Update.
1499         * f-exp.y: Update rules.
1500         (yylex): Update.
1501         * d-exp.y: Update rules.
1502         (lex_one_token, classify_name, classify_inner_name): Update.
1503         * parse.c (write_dollar_variable, copy_name): Return std::string.
1504         * parser-defs.h (copy_name): Change return type.
1505         * m2-exp.y: Update rules.
1506         (yylex): Update.
1507         * go-exp.y (lex_one_token): Update.
1508         Update rules.
1509         (classify_unsafe_function, classify_packaged_name)
1510         (classify_name, yylex): Update.
1511
1512 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1513
1514         * configure.ac: add --enable-source-highlight switch.
1515         * configure: Regenerate.
1516         * top.c (print_gdb_version): plumb --enable-source-highlight
1517         status to "show configuration".
1518
1519 2019-04-19  Tom Tromey  <tromey@adacore.com>
1520
1521         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1522         Check ADA_TYPE_P.
1523         (empty_record, ada_template_to_fixed_record_type_1)
1524         (template_to_static_fixed_type)
1525         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1526         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1527         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1528         macros.
1529
1530 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1531
1532         PR symtab/24423:
1533         * source.c (print_source_lines_base): Advance "iter" when a
1534         control character is seen.
1535
1536 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1537
1538         * inferior.h (struct infcall_suspend_state_deleter):
1539         Catch exception in destructor to avoid crash.
1540
1541 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1542
1543         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1544         close to the add_com "shell".
1545
1546 2019-04-18  Tom Tromey  <tromey@adacore.com>
1547
1548         * process-stratum-target.h (class process_stratum_target)
1549         <stratum>: Add "final".
1550
1551 2019-04-17  Tom Tromey  <tromey@adacore.com>
1552
1553         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1554         against nullptr before use.
1555
1556 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1559
1560 2019-04-17  Jim Wilson  <jimw@sifive.com>
1561             Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1564         code read might fail, assume 4-byte breakpoint in that case.
1565
1566 2019-04-15  Leszek Swirski  <leszeks@google.com>
1567
1568         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1569         rather than a hand-rolled POD check when checking for forced MEMORY
1570         classification.
1571
1572 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1573
1574         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1575         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1576         function.
1577         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1578         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1579         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1580         declaration.
1581
1582 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1583
1584         * aarch64-linux-nat.c
1585         (aarch64_linux_nat_target::thread_architecture): Add override.
1586         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1587         each VQ.
1588
1589 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1590
1591         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1592
1593 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1596         target types of size 96-bits, add some additional comments, and
1597         check that the builtin type we found was the correct size.
1598
1599 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1600
1601         * utils.c (prompt_for_continue): Don't restore the styling at the
1602         end, as applied_style has the wrong value.  This fixes styling in
1603         long lists of file names that are interrupted by the "Continue?"
1604         prompt.
1605
1606 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1607
1608         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1609         * c-lang.c (c_language_defn): Likewise.
1610         (cplus_language_defn): Likewise.
1611         (asm_language_defn): Likewise.
1612         (minimal_language_defn): Likewise.
1613         * d-lang.c (d_language_defn): Likewise.
1614         * f-lang.c (f_language_defn): Likewise.
1615         * go-lang.c (go_language_defn): Likewise.
1616         * language.c (unknown_language_defn): Likewise.
1617         (auto_language_defn): Likewise.
1618         * language.h (struct language_defn): Remove la_magic field.
1619         (LANG_MAGIC): Delete.
1620         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1621         * objc-lang.c (objc_language_defn): Likewise.
1622         * opencl-lang.c (opencl_language_defn): Likewise.
1623         * p-lang.c (pascal_language_defn): Likewise.
1624         * rust-lang.c (rust_language_defn): Likewise.
1625
1626 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1627
1628         * riscv-tdep.c (riscv_type_align): New function.
1629         (riscv_type_alignment): Delete.
1630         (riscv_arg_location): Use 'type_align'.
1631         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1632
1633 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * gdbtypes.c (type_align): A struct with no non-static fields also
1636         has alignment of 1.
1637
1638 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1639
1640         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1641         component to 0.
1642         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1643         member.
1644         (riscv_struct_info::analyse): New implementation using new
1645         analyse_inner member function.
1646         (riscv_struct_info::field_offset): New member function.
1647         (riscv_struct_info::m_offsets): New member variable.
1648         (riscv_struct_info::analyse_inner): New private member function,
1649         takes the old implementation of riscv_struct_info::analyse but
1650         extended to track field offsets.
1651         (riscv_call_arg_struct): Update the struct folding special cases
1652         to handle cases where empty C++ structs, which are non-zero
1653         length, are found.
1654         (riscv_arg_location): Initialise the length of each location, a
1655         non-zero length now indicates the location is in use.
1656         (riscv_push_dummy_call): Allow for the first location having a
1657         non-zero offset when setting up arguments.
1658         (riscv_return_value): Likewise, but for return values.
1659
1660 2019-04-11  Tom Tromey  <tromey@adacore.com>
1661
1662         * utils.c (internal_vproblem): Make "msg" const.
1663
1664 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1665
1666         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1667         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1668         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1669         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1670
1671 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1672
1673         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1674         function.
1675         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1676         of amd64_collect_native_gregset.
1677         (amd64_linux_nat_target::store_registers): Likewise.
1678
1679 2019-04-10  Tom Tromey  <tom@tromey.com>
1680
1681         * symtab.c (lookup_global_symbol_from_objfile)
1682         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1683         * objfiles.h (class separate_debug_iterator): New.
1684         (class separate_debug_range): New.
1685         (struct objfile) <separate_debug_objfiles>: New method.
1686         (objfile_separate_debug_iterate): Don't declare.
1687         * objfiles.c (separate_debug_iterator::operator++): Rename from
1688         objfile_separate_debug_iterate.
1689         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1690         iterator.
1691         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1692         iterator.
1693
1694 2019-04-10  Tom Tromey  <tom@tromey.com>
1695
1696         * symfile.c (reread_symbols): Remove old comment.
1697         * objfiles.c (free_all_objfiles): Fix a typo.
1698
1699 2019-04-10  Tom Tromey  <tom@tromey.com>
1700
1701         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1702         * minsyms.c (lookup_minimal_symbol): Use foreach.
1703         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1704         (lookup_minimal_symbol_solib_trampoline): Likewise.
1705         * symfile.c (reread_symbols): Use foreach.
1706
1707 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1708             Tom Tromey  <tromey@adacore.com>
1709
1710         PR rust/24414:
1711         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1712         (rust_lex_int_test): Change "value" to be LONGEST.
1713         (rust_lex_tests): Add test for long integer literal.
1714
1715 2019-04-09  Tom Tromey  <tromey@adacore.com>
1716
1717         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1718         to bool.
1719         (extended_remote_target::attach): Update.
1720         (remote_target::remote_notice_new_inferior): Update.
1721         (remote_target::add_current_inferior_and_thread): Update.
1722         * inferior.c (exit_inferior_1): Use "false".
1723         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1724
1725 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1726
1727         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1728         the "start" command.
1729
1730 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1731
1732         * python/py-inferior.c (infpy_thread_from_thread_handle):
1733         Adjust comments to reflect renaming of thread_from_thread_handle
1734         to thread_from_handle.  Adjust keywords.  Fix type error message.
1735         (inferior_object_methods): Add thread_from_handle.  Retain
1736         thread_from_thread_handle, but mark it as deprecated.
1737
1738 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1739
1740         * gdbthread.h (find_thread_by_handle): Revise declaration.
1741         * thread.c (find_thread_by_handle): Likewise.  Adjust
1742         implementation too.
1743         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1744         support for buffer objects as handles.
1745
1746 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1747
1748         * python/py-infthread.c (thpy_thread_handle): New function.
1749         (thread_object_methods): Register thpy_thread_handle.
1750
1751 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1752
1753         * gdbthread.h (thread_to_thread_handle): Declare.
1754         * thread.c (gdbtypes.h): Include.
1755         (thread_to_thread_handle): New function.
1756
1757         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1758         (target_thread_info_to_thread_handle): Declare.
1759         * target.c (target_thread_info_to_thread_handle): New function.
1760         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1761         * target-delegates.c: Regenerate.
1762
1763         * linux-thread-db.c (class thread_db_target): Add method
1764         thread_info_to_thread_handle.
1765         (thread_db_target::thread_info_to_thread_handle): Define.
1766         * remote.c (class remote_target): Add new method
1767         thread_info_to_thread_handle.
1768         (remote_target::thread_info_to_thread_handle): Define.
1769
1770 2019-04-08  Pedro Alves  <palves@redhat.com>
1771
1772         * common/common-exceptions.c (throw_exception): Don't create
1773         named object to throw; throw directly.
1774         (throw_it): Likewise.  Don't initialize gdb_exception::message
1775         here, with new; pass FMT and AP to the ctor instead.
1776         * common/common-exceptions.h: Include <string>.
1777         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1778         const char *, va_list)): New ctor.  Use std::make_shared.
1779         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1780         errors)): Delete.
1781         (gdb_exception_error::gdb_exception_error(enum errors, const char
1782         *, va_list)): New.
1783         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1784         Add assertion.
1785         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1786         errors)): Delete.
1787         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1788         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1789         Add assertion.
1790
1791 2019-04-08  Tom Tromey  <tom@tromey.com>
1792
1793         * valops.c (value_rtti_indirect_type): Replace throw_exception
1794         with throw.
1795         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1796         with throw.
1797         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1798         throw.
1799         * target.c (target_translate_tls_address): Replace throw_exception
1800         with throw.
1801         * stack.c (frame_apply_command_count): Replace throw_exception
1802         with throw.
1803         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1804         throw.
1805         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1806         with throw.
1807         * rs6000-tdep.c (rs6000_frame_cache)
1808         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1809         * remote.c: Replace throw_exception with throw.
1810         * record-full.c (record_full_message, record_full_wait_1)
1811         (record_full_restore): Replace throw_exception with throw.
1812         * record-btrace.c:
1813         (get_thread_current_frame_id, record_btrace_start_replaying)
1814         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1815         (cmd_record_btrace_start): Replace throw_exception with throw.
1816         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1817         throw.
1818         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1819         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1820         * linespec.c:
1821         (find_linespec_symbols): Replace throw_exception with throw.
1822         * infrun.c (displaced_step_prepare, resume): Replace
1823         throw_exception with throw.
1824         * infcmd.c (post_create_inferior): Replace throw_exception with
1825         throw.
1826         * inf-loop.c (inferior_event_handler): Replace throw_exception
1827         with throw.
1828         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1829         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1830         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1831         (get_prev_frame_always, get_frame_pc_if_available)
1832         (get_frame_address_in_block_if_available, get_frame_language):
1833         Replace throw_exception with throw.
1834         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1835         throw_exception with throw.
1836         * eval.c (fetch_subexp_value, evaluate_var_value)
1837         (evaluate_funcall, evaluate_subexp_standard): Replace
1838         throw_exception with throw.
1839         * dwarf2loc.c (call_site_find_chain)
1840         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1841         Replace throw_exception with throw.
1842         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1843         with throw.
1844         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1845         throw.
1846         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1847         * completer.c (complete_line_internal): Replace throw_exception
1848         with throw.
1849         * compile/compile-object-run.c (compile_object_run): Replace
1850         throw_exception with throw.
1851         * cli/cli-script.c (process_next_line): Replace throw_exception
1852         with throw.
1853         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1854         (btrace_enable, btrace_maint_update_pt_packets): Replace
1855         throw_exception with throw.
1856         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1857         throw_exception with throw.
1858         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1859         throw_exception with throw.
1860         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1861         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1862         * aarch64-tdep.c (aarch64_make_prologue_cache)
1863         (aarch64_make_stub_cache): Replace throw_exception with throw.
1864
1865 2019-04-08  Tom Tromey  <tom@tromey.com>
1866
1867         * common/common-exceptions.c (throw_exception): Rename from
1868         throw_exception_cxx.  Remove old copy.  Make argument const.
1869         (throw_it): Create and throw exception objects directly.
1870         * common/common-exceptions.h (throw_exception): Make argument
1871         const.
1872         (struct gdb_exception_error): Add constructor.
1873         (struct gdb_exception_quit): Add constructor.
1874
1875 2019-04-08  Tom Tromey  <tom@tromey.com>
1876
1877         * common/common-exceptions.h (exception_rethrow): Don't declare.
1878         (TRY_SJLJ): Update comment.
1879         (TRY, CATCH, END_CATCH): Remove.
1880         * common/common-exceptions.c (exception_rethrow): Remove.
1881
1882 2019-04-08  Tom Tromey  <tom@tromey.com>
1883
1884         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1885         Remove.
1886         (gdb_exception_error): Rename from
1887         gdb_exception_RETURN_MASK_ERROR.
1888         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1889         (gdb_quit_bad_alloc): Update.
1890         * aarch64-tdep.c: Update.
1891         * ada-lang.c: Update.
1892         * ada-typeprint.c: Update.
1893         * ada-valprint.c: Update.
1894         * amd64-tdep.c: Update.
1895         * arch-utils.c: Update.
1896         * break-catch-throw.c: Update.
1897         * breakpoint.c: Update.
1898         * btrace.c: Update.
1899         * c-varobj.c: Update.
1900         * cli/cli-cmds.c: Update.
1901         * cli/cli-interp.c: Update.
1902         * cli/cli-script.c: Update.
1903         * common/common-exceptions.c: Update.
1904         * common/new-op.c: Update.
1905         * common/selftest.c: Update.
1906         * compile/compile-c-symbols.c: Update.
1907         * compile/compile-cplus-symbols.c: Update.
1908         * compile/compile-object-load.c: Update.
1909         * compile/compile-object-run.c: Update.
1910         * completer.c: Update.
1911         * corelow.c: Update.
1912         * cp-abi.c: Update.
1913         * cp-support.c: Update.
1914         * cp-valprint.c: Update.
1915         * darwin-nat.c: Update.
1916         * disasm-selftests.c: Update.
1917         * dtrace-probe.c: Update.
1918         * dwarf-index-cache.c: Update.
1919         * dwarf-index-write.c: Update.
1920         * dwarf2-frame-tailcall.c: Update.
1921         * dwarf2-frame.c: Update.
1922         * dwarf2loc.c: Update.
1923         * dwarf2read.c: Update.
1924         * eval.c: Update.
1925         * event-loop.c: Update.
1926         * event-top.c: Update.
1927         * exec.c: Update.
1928         * f-valprint.c: Update.
1929         * fbsd-tdep.c: Update.
1930         * frame-unwind.c: Update.
1931         * frame.c: Update.
1932         * gdbtypes.c: Update.
1933         * gnu-v3-abi.c: Update.
1934         * guile/guile-internal.h: Update.
1935         * guile/scm-block.c: Update.
1936         * guile/scm-breakpoint.c: Update.
1937         * guile/scm-cmd.c: Update.
1938         * guile/scm-disasm.c: Update.
1939         * guile/scm-frame.c: Update.
1940         * guile/scm-lazy-string.c: Update.
1941         * guile/scm-math.c: Update.
1942         * guile/scm-param.c: Update.
1943         * guile/scm-ports.c: Update.
1944         * guile/scm-pretty-print.c: Update.
1945         * guile/scm-symbol.c: Update.
1946         * guile/scm-symtab.c: Update.
1947         * guile/scm-type.c: Update.
1948         * guile/scm-value.c: Update.
1949         * i386-linux-tdep.c: Update.
1950         * i386-tdep.c: Update.
1951         * inf-loop.c: Update.
1952         * infcall.c: Update.
1953         * infcmd.c: Update.
1954         * infrun.c: Update.
1955         * jit.c: Update.
1956         * language.c: Update.
1957         * linespec.c: Update.
1958         * linux-fork.c: Update.
1959         * linux-nat.c: Update.
1960         * linux-tdep.c: Update.
1961         * linux-thread-db.c: Update.
1962         * main.c: Update.
1963         * mi/mi-cmd-break.c: Update.
1964         * mi/mi-cmd-stack.c: Update.
1965         * mi/mi-interp.c: Update.
1966         * mi/mi-main.c: Update.
1967         * objc-lang.c: Update.
1968         * p-valprint.c: Update.
1969         * parse.c: Update.
1970         * ppc-linux-tdep.c: Update.
1971         * printcmd.c: Update.
1972         * python/py-arch.c: Update.
1973         * python/py-breakpoint.c: Update.
1974         * python/py-cmd.c: Update.
1975         * python/py-finishbreakpoint.c: Update.
1976         * python/py-frame.c: Update.
1977         * python/py-framefilter.c: Update.
1978         * python/py-gdb-readline.c: Update.
1979         * python/py-inferior.c: Update.
1980         * python/py-infthread.c: Update.
1981         * python/py-lazy-string.c: Update.
1982         * python/py-linetable.c: Update.
1983         * python/py-objfile.c: Update.
1984         * python/py-param.c: Update.
1985         * python/py-prettyprint.c: Update.
1986         * python/py-progspace.c: Update.
1987         * python/py-record-btrace.c: Update.
1988         * python/py-record.c: Update.
1989         * python/py-symbol.c: Update.
1990         * python/py-type.c: Update.
1991         * python/py-unwind.c: Update.
1992         * python/py-utils.c: Update.
1993         * python/py-value.c: Update.
1994         * python/python.c: Update.
1995         * record-btrace.c: Update.
1996         * record-full.c: Update.
1997         * remote-fileio.c: Update.
1998         * remote.c: Update.
1999         * riscv-tdep.c: Update.
2000         * rs6000-aix-tdep.c: Update.
2001         * rs6000-tdep.c: Update.
2002         * rust-exp.y: Update.
2003         * rust-lang.c: Update.
2004         * s390-tdep.c: Update.
2005         * selftest-arch.c: Update.
2006         * solib-dsbt.c: Update.
2007         * solib-frv.c: Update.
2008         * solib-spu.c: Update.
2009         * solib-svr4.c: Update.
2010         * solib.c: Update.
2011         * sparc64-linux-tdep.c: Update.
2012         * stack.c: Update.
2013         * symfile-mem.c: Update.
2014         * symmisc.c: Update.
2015         * target.c: Update.
2016         * thread.c: Update.
2017         * top.c: Update.
2018         * tracefile-tfile.c: Update.
2019         * tui/tui.c: Update.
2020         * typeprint.c: Update.
2021         * unittests/cli-utils-selftests.c: Update.
2022         * unittests/parse-connection-spec-selftests.c: Update.
2023         * valops.c: Update.
2024         * valprint.c: Update.
2025         * value.c: Update.
2026         * varobj.c: Update.
2027         * windows-nat.c: Update.
2028         * x86-linux-nat.c: Update.
2029         * xml-support.c: Update.
2030
2031 2019-04-08  Tom Tromey  <tom@tromey.com>
2032
2033         * xml-support.c: Use C++ exception handling.
2034         * x86-linux-nat.c: Use C++ exception handling.
2035         * windows-nat.c: Use C++ exception handling.
2036         * varobj.c: Use C++ exception handling.
2037         * value.c: Use C++ exception handling.
2038         * valprint.c: Use C++ exception handling.
2039         * valops.c: Use C++ exception handling.
2040         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2041         handling.
2042         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2043         * typeprint.c: Use C++ exception handling.
2044         * tui/tui.c: Use C++ exception handling.
2045         * tracefile-tfile.c: Use C++ exception handling.
2046         * top.c: Use C++ exception handling.
2047         * thread.c: Use C++ exception handling.
2048         * target.c: Use C++ exception handling.
2049         * symmisc.c: Use C++ exception handling.
2050         * symfile-mem.c: Use C++ exception handling.
2051         * stack.c: Use C++ exception handling.
2052         * sparc64-linux-tdep.c: Use C++ exception handling.
2053         * solib.c: Use C++ exception handling.
2054         * solib-svr4.c: Use C++ exception handling.
2055         * solib-spu.c: Use C++ exception handling.
2056         * solib-frv.c: Use C++ exception handling.
2057         * solib-dsbt.c: Use C++ exception handling.
2058         * selftest-arch.c: Use C++ exception handling.
2059         * s390-tdep.c: Use C++ exception handling.
2060         * rust-lang.c: Use C++ exception handling.
2061         * rust-exp.y: Use C++ exception handling.
2062         * rs6000-tdep.c: Use C++ exception handling.
2063         * rs6000-aix-tdep.c: Use C++ exception handling.
2064         * riscv-tdep.c: Use C++ exception handling.
2065         * remote.c: Use C++ exception handling.
2066         * remote-fileio.c: Use C++ exception handling.
2067         * record-full.c: Use C++ exception handling.
2068         * record-btrace.c: Use C++ exception handling.
2069         * python/python.c: Use C++ exception handling.
2070         * python/py-value.c: Use C++ exception handling.
2071         * python/py-utils.c: Use C++ exception handling.
2072         * python/py-unwind.c: Use C++ exception handling.
2073         * python/py-type.c: Use C++ exception handling.
2074         * python/py-symbol.c: Use C++ exception handling.
2075         * python/py-record.c: Use C++ exception handling.
2076         * python/py-record-btrace.c: Use C++ exception handling.
2077         * python/py-progspace.c: Use C++ exception handling.
2078         * python/py-prettyprint.c: Use C++ exception handling.
2079         * python/py-param.c: Use C++ exception handling.
2080         * python/py-objfile.c: Use C++ exception handling.
2081         * python/py-linetable.c: Use C++ exception handling.
2082         * python/py-lazy-string.c: Use C++ exception handling.
2083         * python/py-infthread.c: Use C++ exception handling.
2084         * python/py-inferior.c: Use C++ exception handling.
2085         * python/py-gdb-readline.c: Use C++ exception handling.
2086         * python/py-framefilter.c: Use C++ exception handling.
2087         * python/py-frame.c: Use C++ exception handling.
2088         * python/py-finishbreakpoint.c: Use C++ exception handling.
2089         * python/py-cmd.c: Use C++ exception handling.
2090         * python/py-breakpoint.c: Use C++ exception handling.
2091         * python/py-arch.c: Use C++ exception handling.
2092         * printcmd.c: Use C++ exception handling.
2093         * ppc-linux-tdep.c: Use C++ exception handling.
2094         * parse.c: Use C++ exception handling.
2095         * p-valprint.c: Use C++ exception handling.
2096         * objc-lang.c: Use C++ exception handling.
2097         * mi/mi-main.c: Use C++ exception handling.
2098         * mi/mi-interp.c: Use C++ exception handling.
2099         * mi/mi-cmd-stack.c: Use C++ exception handling.
2100         * mi/mi-cmd-break.c: Use C++ exception handling.
2101         * main.c: Use C++ exception handling.
2102         * linux-thread-db.c: Use C++ exception handling.
2103         * linux-tdep.c: Use C++ exception handling.
2104         * linux-nat.c: Use C++ exception handling.
2105         * linux-fork.c: Use C++ exception handling.
2106         * linespec.c: Use C++ exception handling.
2107         * language.c: Use C++ exception handling.
2108         * jit.c: Use C++ exception handling.
2109         * infrun.c: Use C++ exception handling.
2110         * infcmd.c: Use C++ exception handling.
2111         * infcall.c: Use C++ exception handling.
2112         * inf-loop.c: Use C++ exception handling.
2113         * i386-tdep.c: Use C++ exception handling.
2114         * i386-linux-tdep.c: Use C++ exception handling.
2115         * guile/scm-value.c: Use C++ exception handling.
2116         * guile/scm-type.c: Use C++ exception handling.
2117         * guile/scm-symtab.c: Use C++ exception handling.
2118         * guile/scm-symbol.c: Use C++ exception handling.
2119         * guile/scm-pretty-print.c: Use C++ exception handling.
2120         * guile/scm-ports.c: Use C++ exception handling.
2121         * guile/scm-param.c: Use C++ exception handling.
2122         * guile/scm-math.c: Use C++ exception handling.
2123         * guile/scm-lazy-string.c: Use C++ exception handling.
2124         * guile/scm-frame.c: Use C++ exception handling.
2125         * guile/scm-disasm.c: Use C++ exception handling.
2126         * guile/scm-cmd.c: Use C++ exception handling.
2127         * guile/scm-breakpoint.c: Use C++ exception handling.
2128         * guile/scm-block.c: Use C++ exception handling.
2129         * guile/guile-internal.h: Use C++ exception handling.
2130         * gnu-v3-abi.c: Use C++ exception handling.
2131         * gdbtypes.c: Use C++ exception handling.
2132         * frame.c: Use C++ exception handling.
2133         * frame-unwind.c: Use C++ exception handling.
2134         * fbsd-tdep.c: Use C++ exception handling.
2135         * f-valprint.c: Use C++ exception handling.
2136         * exec.c: Use C++ exception handling.
2137         * event-top.c: Use C++ exception handling.
2138         * event-loop.c: Use C++ exception handling.
2139         * eval.c: Use C++ exception handling.
2140         * dwarf2read.c: Use C++ exception handling.
2141         * dwarf2loc.c: Use C++ exception handling.
2142         * dwarf2-frame.c: Use C++ exception handling.
2143         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2144         * dwarf-index-write.c: Use C++ exception handling.
2145         * dwarf-index-cache.c: Use C++ exception handling.
2146         * dtrace-probe.c: Use C++ exception handling.
2147         * disasm-selftests.c: Use C++ exception handling.
2148         * darwin-nat.c: Use C++ exception handling.
2149         * cp-valprint.c: Use C++ exception handling.
2150         * cp-support.c: Use C++ exception handling.
2151         * cp-abi.c: Use C++ exception handling.
2152         * corelow.c: Use C++ exception handling.
2153         * completer.c: Use C++ exception handling.
2154         * compile/compile-object-run.c: Use C++ exception handling.
2155         * compile/compile-object-load.c: Use C++ exception handling.
2156         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2157         * compile/compile-c-symbols.c: Use C++ exception handling.
2158         * common/selftest.c: Use C++ exception handling.
2159         * common/new-op.c: Use C++ exception handling.
2160         * cli/cli-script.c: Use C++ exception handling.
2161         * cli/cli-interp.c: Use C++ exception handling.
2162         * cli/cli-cmds.c: Use C++ exception handling.
2163         * c-varobj.c: Use C++ exception handling.
2164         * btrace.c: Use C++ exception handling.
2165         * breakpoint.c: Use C++ exception handling.
2166         * break-catch-throw.c: Use C++ exception handling.
2167         * arch-utils.c: Use C++ exception handling.
2168         * amd64-tdep.c: Use C++ exception handling.
2169         * ada-valprint.c: Use C++ exception handling.
2170         * ada-typeprint.c: Use C++ exception handling.
2171         * ada-lang.c: Use C++ exception handling.
2172         * aarch64-tdep.c: Use C++ exception handling.
2173
2174 2019-04-08  Tom Tromey  <tom@tromey.com>
2175
2176         * xml-support.c (gdb_xml_parser::parse): Update.
2177         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2178         * value.c (show_convenience): Update.
2179         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2180         (test_parse_flags_qcs): Update.
2181         * thread.c (thr_try_catch_cmd): Update.
2182         * target.c (target_translate_tls_address): Update.
2183         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2184         (info_frame_command_core, frame_apply_command_count): Update.
2185         * rust-exp.y (rust_lex_exception_test): Update.
2186         * riscv-tdep.c (riscv_print_one_register_info): Update.
2187         * remote.c (remote_target::enable_btrace): Update.
2188         * record-btrace.c (record_btrace_enable_warn): Update.
2189         * python/py-utils.c (gdbpy_convert_exception): Update.
2190         * printcmd.c (do_one_display, print_variable_and_value): Update.
2191         * mi/mi-main.c (mi_print_exception): Update.
2192         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2193         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2194         * linux-nat.c (linux_nat_target::attach): Update.
2195         * linux-fork.c (class scoped_switch_fork_info): Update.
2196         * infrun.c (displaced_step_prepare): Update.
2197         * infcall.c (call_function_by_hand_dummy): Update.
2198         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2199         * gnu-v3-abi.c (print_one_vtable): Update.
2200         * frame.c (get_prev_frame_always): Update.
2201         * f-valprint.c (info_common_command_for_block): Update.
2202         * exec.c (try_open_exec_file): Update.
2203         * exceptions.c (print_exception, exception_print)
2204         (exception_fprintf, exception_print_same): Update.
2205         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2206         * dwarf-index-cache.c (index_cache::store)
2207         (index_cache::lookup_gdb_index): Update.
2208         * darwin-nat.c (maybe_cache_shell): Update.
2209         * cp-valprint.c (cp_print_value_fields): Update.
2210         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2211         (gcc_cplus_symbol_address): Update.
2212         * compile/compile-c-symbols.c (gcc_convert_symbol)
2213         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2214         * common/selftest.c: Update.
2215         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2216         a std::string.
2217         (exception_try_scope_entry, exception_try_scope_exit): Don't
2218         declare.
2219         (struct exception_try_scope): Remove.
2220         (TRY): Don't use exception_try_scope.
2221         (struct gdb_exception): Add constructor, operator=.
2222         <what>: New method.
2223         (struct gdb_exception_RETURN_MASK_ALL)
2224         (struct gdb_exception_RETURN_MASK_ERROR)
2225         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2226         (struct gdb_quit_bad_alloc): Update.
2227         * common/common-exceptions.c (exception_none): Change
2228         initializer.
2229         (struct catcher) <state, exception>: Initialize inline.
2230         <prev>: Remove member.
2231         (current_catcher): Remove.
2232         (catchers): New global.
2233         (exceptions_state_mc_init): Simplify.
2234         (catcher_pop): Remove.
2235         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2236         (try_scope_depth, exception_try_scope_entry)
2237         (exception_try_scope_exit): Remove.
2238         (throw_exception_sjlj): Update.
2239         (exception_messages, exception_messages_size): Remove.
2240         (throw_it): Simplify.
2241         (gdb_exception_sliced_copy): Remove.
2242         (throw_exception_cxx): Update.
2243         * cli/cli-script.c (script_from_file): Update.
2244         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2245         Update.
2246         * ada-valprint.c (ada_val_print): Update.
2247         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2248         (create_excep_cond_exprs): Update.
2249
2250 2019-04-08  Tom Tromey  <tom@tromey.com>
2251
2252         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2253         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2254         (TRY, CATCH, END_CATCH): Remove some definitions.
2255         * common/common-exceptions.c: Don't use GDB_XCPT.
2256         (catcher_list_size): Remove.
2257         (throw_exception, throw_it): Simplify.
2258
2259 2019-04-05  Tom Tromey  <tom@tromey.com>
2260
2261         Revert the header-sorting patch.
2262         * ft32-tdep.c: Revert.
2263         * frv-tdep.c: Revert.
2264         * frv-linux-tdep.c: Revert.
2265         * frame.c: Revert.
2266         * frame-unwind.c: Revert.
2267         * frame-base.c: Revert.
2268         * fork-child.c: Revert.
2269         * findvar.c: Revert.
2270         * findcmd.c: Revert.
2271         * filesystem.c: Revert.
2272         * filename-seen-cache.h: Revert.
2273         * filename-seen-cache.c: Revert.
2274         * fbsd-tdep.c: Revert.
2275         * fbsd-nat.h: Revert.
2276         * fbsd-nat.c: Revert.
2277         * f-valprint.c: Revert.
2278         * f-typeprint.c: Revert.
2279         * f-lang.c: Revert.
2280         * extension.h: Revert.
2281         * extension.c: Revert.
2282         * extension-priv.h: Revert.
2283         * expprint.c: Revert.
2284         * exec.h: Revert.
2285         * exec.c: Revert.
2286         * exceptions.c: Revert.
2287         * event-top.c: Revert.
2288         * event-loop.c: Revert.
2289         * eval.c: Revert.
2290         * elfread.c: Revert.
2291         * dwarf2read.h: Revert.
2292         * dwarf2read.c: Revert.
2293         * dwarf2loc.c: Revert.
2294         * dwarf2expr.h: Revert.
2295         * dwarf2expr.c: Revert.
2296         * dwarf2-frame.c: Revert.
2297         * dwarf2-frame-tailcall.c: Revert.
2298         * dwarf-index-write.h: Revert.
2299         * dwarf-index-write.c: Revert.
2300         * dwarf-index-common.c: Revert.
2301         * dwarf-index-cache.h: Revert.
2302         * dwarf-index-cache.c: Revert.
2303         * dummy-frame.c: Revert.
2304         * dtrace-probe.c: Revert.
2305         * disasm.h: Revert.
2306         * disasm.c: Revert.
2307         * disasm-selftests.c: Revert.
2308         * dictionary.c: Revert.
2309         * dicos-tdep.c: Revert.
2310         * demangle.c: Revert.
2311         * dcache.h: Revert.
2312         * dcache.c: Revert.
2313         * darwin-nat.h: Revert.
2314         * darwin-nat.c: Revert.
2315         * darwin-nat-info.c: Revert.
2316         * d-valprint.c: Revert.
2317         * d-namespace.c: Revert.
2318         * d-lang.c: Revert.
2319         * ctf.c: Revert.
2320         * csky-tdep.c: Revert.
2321         * csky-linux-tdep.c: Revert.
2322         * cris-tdep.c: Revert.
2323         * cris-linux-tdep.c: Revert.
2324         * cp-valprint.c: Revert.
2325         * cp-support.c: Revert.
2326         * cp-namespace.c: Revert.
2327         * cp-abi.c: Revert.
2328         * corelow.c: Revert.
2329         * corefile.c: Revert.
2330         * continuations.c: Revert.
2331         * completer.h: Revert.
2332         * completer.c: Revert.
2333         * complaints.c: Revert.
2334         * coffread.c: Revert.
2335         * coff-pe-read.c: Revert.
2336         * cli-out.h: Revert.
2337         * cli-out.c: Revert.
2338         * charset.c: Revert.
2339         * c-varobj.c: Revert.
2340         * c-valprint.c: Revert.
2341         * c-typeprint.c: Revert.
2342         * c-lang.c: Revert.
2343         * buildsym.c: Revert.
2344         * buildsym-legacy.c: Revert.
2345         * build-id.h: Revert.
2346         * build-id.c: Revert.
2347         * btrace.c: Revert.
2348         * bsd-uthread.c: Revert.
2349         * breakpoint.h: Revert.
2350         * breakpoint.c: Revert.
2351         * break-catch-throw.c: Revert.
2352         * break-catch-syscall.c: Revert.
2353         * break-catch-sig.c: Revert.
2354         * blockframe.c: Revert.
2355         * block.c: Revert.
2356         * bfin-tdep.c: Revert.
2357         * bfin-linux-tdep.c: Revert.
2358         * bfd-target.c: Revert.
2359         * bcache.c: Revert.
2360         * ax-general.c: Revert.
2361         * ax-gdb.h: Revert.
2362         * ax-gdb.c: Revert.
2363         * avr-tdep.c: Revert.
2364         * auxv.c: Revert.
2365         * auto-load.c: Revert.
2366         * arm-wince-tdep.c: Revert.
2367         * arm-tdep.c: Revert.
2368         * arm-symbian-tdep.c: Revert.
2369         * arm-pikeos-tdep.c: Revert.
2370         * arm-obsd-tdep.c: Revert.
2371         * arm-nbsd-tdep.c: Revert.
2372         * arm-nbsd-nat.c: Revert.
2373         * arm-linux-tdep.c: Revert.
2374         * arm-linux-nat.c: Revert.
2375         * arm-fbsd-tdep.c: Revert.
2376         * arm-fbsd-nat.c: Revert.
2377         * arm-bsd-tdep.c: Revert.
2378         * arch-utils.c: Revert.
2379         * arc-tdep.c: Revert.
2380         * arc-newlib-tdep.c: Revert.
2381         * annotate.h: Revert.
2382         * annotate.c: Revert.
2383         * amd64-windows-tdep.c: Revert.
2384         * amd64-windows-nat.c: Revert.
2385         * amd64-tdep.c: Revert.
2386         * amd64-sol2-tdep.c: Revert.
2387         * amd64-obsd-tdep.c: Revert.
2388         * amd64-obsd-nat.c: Revert.
2389         * amd64-nbsd-tdep.c: Revert.
2390         * amd64-nbsd-nat.c: Revert.
2391         * amd64-nat.c: Revert.
2392         * amd64-linux-tdep.c: Revert.
2393         * amd64-linux-nat.c: Revert.
2394         * amd64-fbsd-tdep.c: Revert.
2395         * amd64-fbsd-nat.c: Revert.
2396         * amd64-dicos-tdep.c: Revert.
2397         * amd64-darwin-tdep.c: Revert.
2398         * amd64-bsd-nat.c: Revert.
2399         * alpha-tdep.c: Revert.
2400         * alpha-obsd-tdep.c: Revert.
2401         * alpha-nbsd-tdep.c: Revert.
2402         * alpha-mdebug-tdep.c: Revert.
2403         * alpha-linux-tdep.c: Revert.
2404         * alpha-linux-nat.c: Revert.
2405         * alpha-bsd-tdep.c: Revert.
2406         * alpha-bsd-nat.c: Revert.
2407         * aix-thread.c: Revert.
2408         * agent.c: Revert.
2409         * addrmap.c: Revert.
2410         * ada-varobj.c: Revert.
2411         * ada-valprint.c: Revert.
2412         * ada-typeprint.c: Revert.
2413         * ada-tasks.c: Revert.
2414         * ada-lang.c: Revert.
2415         * aarch64-tdep.c: Revert.
2416         * aarch64-ravenscar-thread.c: Revert.
2417         * aarch64-newlib-tdep.c: Revert.
2418         * aarch64-linux-tdep.c: Revert.
2419         * aarch64-linux-nat.c: Revert.
2420         * aarch64-fbsd-tdep.c: Revert.
2421         * aarch64-fbsd-nat.c: Revert.
2422         * aarch32-linux-nat.c: Revert.
2423
2424 2019-04-05  Tom Tromey  <tom@tromey.com>
2425
2426         * ft32-tdep.c: Sort headers.
2427         * frv-tdep.c: Sort headers.
2428         * frv-linux-tdep.c: Sort headers.
2429         * frame.c: Sort headers.
2430         * frame-unwind.c: Sort headers.
2431         * frame-base.c: Sort headers.
2432         * fork-child.c: Sort headers.
2433         * findvar.c: Sort headers.
2434         * findcmd.c: Sort headers.
2435         * filesystem.c: Sort headers.
2436         * filename-seen-cache.h: Sort headers.
2437         * filename-seen-cache.c: Sort headers.
2438         * fbsd-tdep.c: Sort headers.
2439         * fbsd-nat.h: Sort headers.
2440         * fbsd-nat.c: Sort headers.
2441         * f-valprint.c: Sort headers.
2442         * f-typeprint.c: Sort headers.
2443         * f-lang.c: Sort headers.
2444         * extension.h: Sort headers.
2445         * extension.c: Sort headers.
2446         * extension-priv.h: Sort headers.
2447         * expprint.c: Sort headers.
2448         * exec.h: Sort headers.
2449         * exec.c: Sort headers.
2450         * exceptions.c: Sort headers.
2451         * event-top.c: Sort headers.
2452         * event-loop.c: Sort headers.
2453         * eval.c: Sort headers.
2454         * elfread.c: Sort headers.
2455         * dwarf2read.h: Sort headers.
2456         * dwarf2read.c: Sort headers.
2457         * dwarf2loc.c: Sort headers.
2458         * dwarf2expr.h: Sort headers.
2459         * dwarf2expr.c: Sort headers.
2460         * dwarf2-frame.c: Sort headers.
2461         * dwarf2-frame-tailcall.c: Sort headers.
2462         * dwarf-index-write.h: Sort headers.
2463         * dwarf-index-write.c: Sort headers.
2464         * dwarf-index-common.c: Sort headers.
2465         * dwarf-index-cache.h: Sort headers.
2466         * dwarf-index-cache.c: Sort headers.
2467         * dummy-frame.c: Sort headers.
2468         * dtrace-probe.c: Sort headers.
2469         * disasm.h: Sort headers.
2470         * disasm.c: Sort headers.
2471         * disasm-selftests.c: Sort headers.
2472         * dictionary.c: Sort headers.
2473         * dicos-tdep.c: Sort headers.
2474         * demangle.c: Sort headers.
2475         * dcache.h: Sort headers.
2476         * dcache.c: Sort headers.
2477         * darwin-nat.h: Sort headers.
2478         * darwin-nat.c: Sort headers.
2479         * darwin-nat-info.c: Sort headers.
2480         * d-valprint.c: Sort headers.
2481         * d-namespace.c: Sort headers.
2482         * d-lang.c: Sort headers.
2483         * ctf.c: Sort headers.
2484         * csky-tdep.c: Sort headers.
2485         * csky-linux-tdep.c: Sort headers.
2486         * cris-tdep.c: Sort headers.
2487         * cris-linux-tdep.c: Sort headers.
2488         * cp-valprint.c: Sort headers.
2489         * cp-support.c: Sort headers.
2490         * cp-namespace.c: Sort headers.
2491         * cp-abi.c: Sort headers.
2492         * corelow.c: Sort headers.
2493         * corefile.c: Sort headers.
2494         * continuations.c: Sort headers.
2495         * completer.h: Sort headers.
2496         * completer.c: Sort headers.
2497         * complaints.c: Sort headers.
2498         * coffread.c: Sort headers.
2499         * coff-pe-read.c: Sort headers.
2500         * cli-out.h: Sort headers.
2501         * cli-out.c: Sort headers.
2502         * charset.c: Sort headers.
2503         * c-varobj.c: Sort headers.
2504         * c-valprint.c: Sort headers.
2505         * c-typeprint.c: Sort headers.
2506         * c-lang.c: Sort headers.
2507         * buildsym.c: Sort headers.
2508         * buildsym-legacy.c: Sort headers.
2509         * build-id.h: Sort headers.
2510         * build-id.c: Sort headers.
2511         * btrace.c: Sort headers.
2512         * bsd-uthread.c: Sort headers.
2513         * breakpoint.h: Sort headers.
2514         * breakpoint.c: Sort headers.
2515         * break-catch-throw.c: Sort headers.
2516         * break-catch-syscall.c: Sort headers.
2517         * break-catch-sig.c: Sort headers.
2518         * blockframe.c: Sort headers.
2519         * block.c: Sort headers.
2520         * bfin-tdep.c: Sort headers.
2521         * bfin-linux-tdep.c: Sort headers.
2522         * bfd-target.c: Sort headers.
2523         * bcache.c: Sort headers.
2524         * ax-general.c: Sort headers.
2525         * ax-gdb.h: Sort headers.
2526         * ax-gdb.c: Sort headers.
2527         * avr-tdep.c: Sort headers.
2528         * auxv.c: Sort headers.
2529         * auto-load.c: Sort headers.
2530         * arm-wince-tdep.c: Sort headers.
2531         * arm-tdep.c: Sort headers.
2532         * arm-symbian-tdep.c: Sort headers.
2533         * arm-pikeos-tdep.c: Sort headers.
2534         * arm-obsd-tdep.c: Sort headers.
2535         * arm-nbsd-tdep.c: Sort headers.
2536         * arm-nbsd-nat.c: Sort headers.
2537         * arm-linux-tdep.c: Sort headers.
2538         * arm-linux-nat.c: Sort headers.
2539         * arm-fbsd-tdep.c: Sort headers.
2540         * arm-fbsd-nat.c: Sort headers.
2541         * arm-bsd-tdep.c: Sort headers.
2542         * arch-utils.c: Sort headers.
2543         * arc-tdep.c: Sort headers.
2544         * arc-newlib-tdep.c: Sort headers.
2545         * annotate.h: Sort headers.
2546         * annotate.c: Sort headers.
2547         * amd64-windows-tdep.c: Sort headers.
2548         * amd64-windows-nat.c: Sort headers.
2549         * amd64-tdep.c: Sort headers.
2550         * amd64-sol2-tdep.c: Sort headers.
2551         * amd64-obsd-tdep.c: Sort headers.
2552         * amd64-obsd-nat.c: Sort headers.
2553         * amd64-nbsd-tdep.c: Sort headers.
2554         * amd64-nbsd-nat.c: Sort headers.
2555         * amd64-nat.c: Sort headers.
2556         * amd64-linux-tdep.c: Sort headers.
2557         * amd64-linux-nat.c: Sort headers.
2558         * amd64-fbsd-tdep.c: Sort headers.
2559         * amd64-fbsd-nat.c: Sort headers.
2560         * amd64-dicos-tdep.c: Sort headers.
2561         * amd64-darwin-tdep.c: Sort headers.
2562         * amd64-bsd-nat.c: Sort headers.
2563         * alpha-tdep.c: Sort headers.
2564         * alpha-obsd-tdep.c: Sort headers.
2565         * alpha-nbsd-tdep.c: Sort headers.
2566         * alpha-mdebug-tdep.c: Sort headers.
2567         * alpha-linux-tdep.c: Sort headers.
2568         * alpha-linux-nat.c: Sort headers.
2569         * alpha-bsd-tdep.c: Sort headers.
2570         * alpha-bsd-nat.c: Sort headers.
2571         * aix-thread.c: Sort headers.
2572         * agent.c: Sort headers.
2573         * addrmap.c: Sort headers.
2574         * ada-varobj.c: Sort headers.
2575         * ada-valprint.c: Sort headers.
2576         * ada-typeprint.c: Sort headers.
2577         * ada-tasks.c: Sort headers.
2578         * ada-lang.c: Sort headers.
2579         * aarch64-tdep.c: Sort headers.
2580         * aarch64-ravenscar-thread.c: Sort headers.
2581         * aarch64-newlib-tdep.c: Sort headers.
2582         * aarch64-linux-tdep.c: Sort headers.
2583         * aarch64-linux-nat.c: Sort headers.
2584         * aarch64-fbsd-tdep.c: Sort headers.
2585         * aarch64-fbsd-nat.c: Sort headers.
2586         * aarch32-linux-nat.c: Sort headers.
2587
2588 2019-04-04  Tom Tromey  <tom@tromey.com>
2589
2590         * varobj.c (varobj_create): Update.
2591         * rust-exp.y (struct rust_parser) <update_innermost_block,
2592         lookup_symbol>: New methods.
2593         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2594         Rename.
2595         (rust_parser::rust_lookup_type)
2596         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2597         * printcmd.c (display_command, do_one_display): Update.
2598         * parser-defs.h (struct parser_state) <parser_state>: Add
2599         "tracker" parameter.
2600         (block_tracker): New member.
2601         (class innermost_block_tracker) <innermost_block_tracker>: Add
2602         "types" parameter.
2603         <reset>: Remove method.
2604         (innermost_block): Don't declare.
2605         (null_post_parser): Update.
2606         * parse.c (innermost_block): Remove global.
2607         (write_dollar_variable): Update.
2608         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2609         Remove "tracker_types" parameter.
2610         (parse_expression): Add "tracker" parameter.
2611         (parse_expression_for_completion): Update.
2612         (null_post_parser): Add "tracker" parameter.
2613         * p-exp.y: Update rules.
2614         * m2-exp.y: Update rules.
2615         * language.h (struct language_defn) <la_post_parser>: Add
2616         "tracker" parameter.
2617         * go-exp.y: Update rules.
2618         * f-exp.y: Update rules.
2619         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2620         parameter.
2621         * d-exp.y: Update rules.
2622         * c-exp.y: Update rules.
2623         * breakpoint.c (set_breakpoint_condition): Create an
2624         innermost_block_tracker.
2625         (watch_command_1): Likewise.
2626         * ada-lang.c (resolve): Add "tracker" parameter.
2627         (resolve_subexp): Likewise.
2628         * ada-exp.y (write_var_from_sym): Update.
2629
2630 2019-04-04  Tom Tromey  <tom@tromey.com>
2631
2632         * type-stack.h: New file.
2633         * type-stack.c: New file.
2634         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2635         type-stack.h.
2636         (insert_into_type_stack, insert_type, push_type, push_type_int)
2637         (insert_type_address_space, pop_type, pop_type_int)
2638         (pop_typelist, pop_type_stack, append_type_stack)
2639         (push_type_stack, get_type_stack, push_typelist)
2640         (follow_type_instance_flags, follow_types): Don't declare.
2641         * parse.c (type_stack): Remove global.
2642         (parse_exp_in_context): Update.
2643         (insert_into_type_stack, insert_type, push_type, push_type_int)
2644         (insert_type_address_space, pop_type, pop_type_int)
2645         (pop_typelist, pop_type_stack, append_type_stack)
2646         (push_type_stack, get_type_stack, push_typelist)
2647         (follow_type_instance_flags, follow_types): Remove (moved to
2648         type-stack.c).
2649         * f-exp.y (type_stack): New global.
2650         Update rules.
2651         (push_kind_type, f_parse): Update.
2652         * d-exp.y (type_stack): New global.
2653         Update rules.
2654         (d_parse): Update.
2655         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2656         Update rules.
2657         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2658         (HFILES_NO_SRCDIR): Add type-stack.h.
2659
2660 2019-04-04  Tom Tromey  <tom@tromey.com>
2661
2662         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2663         (rust_parser::convert_ast_to_expression, rust_parse)
2664         (rust_lex_test_completion, rust_lex_tests): Update.
2665         * parser-defs.h (struct expr_completion_state): New.
2666         (struct parser_state) <parser_state>: Add completion parameter.
2667         <mark_struct_expression, mark_completion_tag>: New methods.
2668         <parse_completion, m_completion_state>: New members.
2669         (prefixify_expression, null_post_parser): Update.
2670         (mark_struct_expression, mark_completion_tag): Don't declare.
2671         * parse.c (parse_completion, expout_last_struct)
2672         (expout_tag_completion_type, expout_completion_name): Remove
2673         globals.
2674         (parser_state::mark_struct_expression)
2675         (parser_state::mark_completion_tag): Now methods.
2676         (prefixify_expression): Add last_struct parameter.
2677         (prefixify_subexp): Likewise.
2678         (parse_exp_1): Update.
2679         (parse_exp_in_context): Add cstate parameter.  Update.
2680         (parse_expression_for_completion): Create an
2681         expr_completion_state.
2682         (null_post_parser): Add "completion" parameter.
2683         * p-exp.y: Update rules.
2684         (yylex): Update.
2685         * language.h (struct language_defn) <la_post_parser>: Add
2686         "completing" parameter.
2687         * go-exp.y: Update rules.
2688         (lex_one_token): Update.
2689         * expression.h (parse_completion): Don't declare.
2690         * d-exp.y: Update rules.
2691         (lex_one_token): Update rules.
2692         * c-exp.y: Update rules.
2693         (lex_one_token): Update.
2694         * ada-lang.c (resolve): Add "parse_completion" parameter.
2695         (resolve_subexp): Likewise.
2696         (ada_resolve_function): Likewise.
2697
2698 2019-04-04  Tom Tromey  <tom@tromey.com>
2699
2700         * parser-defs.h (struct parser_state) <start_arglist,
2701         end_arglist>: New methods.
2702         <arglist_len, m_funcall_chain>: New members.
2703         (arglist_len, start_arglist, end_arglist): Don't declare.
2704         * parse.c (arglist_len, funcall_chain): Remove global.
2705         (start_arglist, end_arglist): Remove functions.
2706         (parse_exp_in_context): Update.
2707         * p-exp.y: Update rules.
2708         * m2-exp.y: Update rules.
2709         * go-exp.y: Update rules.
2710         * f-exp.y: Update rules.
2711         * d-exp.y: Update rules.
2712         * c-exp.y: Update rules.
2713
2714 2019-04-04  Tom Tromey  <tom@tromey.com>
2715
2716         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2717         lex_operator, push_back>: New methods.
2718         Update all rules.
2719         (rust_parser::lex_hex, lex_escape): Rename and update.
2720         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2721         (rust_parser::lex_operator): Rename and update.
2722         (rust_parser::lex_number, rustyylex, rustyyerror)
2723         (rust_lex_test_init, rust_lex_test_sequence)
2724         (rust_lex_test_push_back, rust_lex_tests): Update.
2725         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2726         parameter.
2727         <lexptr, prev_lexptr>: New members.
2728         (lexptr, prev_lexptr): Don't declare.
2729         * parse.c (lexptr, prev_lexptr): Remove globals.
2730         (parse_exp_in_context): Update.
2731         * p-exp.y (yylex, yyerror): Update.
2732         * m2-exp.y (parse_number, yylex, yyerror): Update.
2733         * go-exp.y (lex_one_token, yyerror): Update.
2734         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2735         * d-exp.y (lex_one_token, yyerror): Update.
2736         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2737         (lex_one_token, yyerror): Update.
2738         * ada-lex.l (YY_INPUT): Update.
2739         (rewind_to_char): Update.
2740         * ada-exp.y (yyerror): Update.
2741
2742 2019-04-04  Tom Tromey  <tom@tromey.com>
2743
2744         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2745         * parser-defs.h (struct parser_state) <parser_state>: Add new
2746         parameter.
2747         <comma_terminates>: New member.
2748         (comma_terminates): Don't declare global.
2749         * parse.c (comma_terminates): Remove global.
2750         (parse_exp_in_context): Update.
2751         * p-exp.y (yylex): Update.
2752         * m2-exp.y (yylex): Update.
2753         * go-exp.y (lex_one_token): Update.
2754         * f-exp.y (yylex): Update.
2755         * d-exp.y (lex_one_token): Update.
2756         * c-exp.y (lex_one_token): Update.
2757         * ada-lex.l: Update.
2758
2759 2019-04-04  Tom Tromey  <tom@tromey.com>
2760
2761         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2762         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2763         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2764         * parser-defs.h (paren_depth): Don't declare.
2765         * parse.c (paren_depth): Remove global.
2766         (parse_exp_in_context): Update.
2767         * p-exp.y (paren_depth): New global.
2768         (pascal_parse): Initialize it.
2769         * m2-exp.y (paren_depth): New global.
2770         (m2_parse): Initialize it.
2771         * go-exp.y (paren_depth): New global.
2772         (go_parse): Initialize it.
2773         * f-exp.y (paren_depth): New global.
2774         (f_parse): Initialize it.
2775         * d-exp.y (paren_depth): New global.
2776         (d_parse): Initialize it.
2777         * c-exp.y (paren_depth): New global.
2778         (c_parse): Initialize it.
2779         * ada-lex.l (paren_depth): New global.
2780         (lexer_init): Initialize it.
2781
2782 2019-04-04  Tom Tromey  <tom@tromey.com>
2783
2784         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2785         (rust_parser::convert_ast_to_type)
2786         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2787         * parser-defs.h (struct parser_state) <parser_state>: Add
2788         parameters.  Initialize new members.
2789         <expression_context_block, expression_context_pc>: New members.
2790         * parse.c (expression_context_block, expression_context_pc):
2791         Remove globals.
2792         (parse_exp_in_context): Update.
2793         * p-exp.y: Update all rules.
2794         (yylex): Update.
2795         * m2-exp.y: Update all rules.
2796         (yylex): Update.
2797         * go-exp.y (yylex): Update.
2798         * f-exp.y (yylex): Update.
2799         * d-exp.y: Update all rules.
2800         (yylex): Update.
2801         * c-exp.y: Update all rules.
2802         (lex_one_token, classify_name, yylex, c_parse): Update.
2803         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2804
2805 2019-04-04  Tom Tromey  <tom@tromey.com>
2806
2807         * gdbarch.h, gdbarch.c: Rebuild.
2808         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2809         * stap-probe.h:
2810         (struct stap_parse_info): Replace "parser_state" with
2811         "expr_builder".
2812         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2813         (parser_state): New class.
2814         * parse.c (expr_builder): Rename.
2815         (expr_builder::release): Rename.
2816         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2817         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2818         (write_exp_elt_longcst, write_exp_elt_floatcst)
2819         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2820         (write_exp_string_vector, write_exp_bitstring)
2821         (write_exp_msymbol, mark_struct_expression)
2822         (write_dollar_variable)
2823         (insert_type_address_space, increase_expout_size): Replace
2824         "parser_state" with "expr_builder".
2825         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2826         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2827         "parser_state" with "expr_builder".
2828
2829 2019-04-04  Tom Tromey  <tom@tromey.com>
2830
2831         * rust-exp.y: Replace "parse_language" with method call.
2832         * p-exp.y:
2833         (yylex): Replace "parse_language" with method call.
2834         * m2-exp.y:
2835         (yylex): Replace "parse_language" with method call.
2836         * go-exp.y (classify_name): Replace "parse_language" with method
2837         call.
2838         * f-exp.y (yylex): Replace "parse_language" with method call.
2839         * d-exp.y (lex_one_token): Replace "parse_language" with method
2840         call.
2841         * c-exp.y:
2842         (lex_one_token, classify_name, yylex): Replace "parse_language"
2843         with method call.
2844         * ada-exp.y (find_primitive_type, type_char)
2845         (type_system_address): Replace "parse_language" with method call.
2846
2847 2019-04-04  Tom Tromey  <tom@tromey.com>
2848
2849         * rust-exp.y: Replace "parse_gdbarch" with method call.
2850         * parse.c (write_dollar_variable, insert_type_address_space):
2851         Replace "parse_gdbarch" with method call.
2852         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2853         call.
2854         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2855         call.
2856         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2857         "parse_gdbarch" with method call.
2858         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2859         with method call.
2860         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2861         "parse_gdbarch" with method call.
2862         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2863         "parse_gdbarch" with method call.
2864         * c-exp.y (parse_type, parse_number, classify_name): Replace
2865         "parse_gdbarch" with method call.
2866         * ada-lex.l: Replace "parse_gdbarch" with method call.
2867         * ada-exp.y (parse_type, find_primitive_type, type_char)
2868         (type_system_address): Replace "parse_gdbarch" with method call.
2869
2870 2019-04-04  Tom Tromey  <tom@tromey.com>
2871
2872         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2873         * stap-probe.c (stap_parse_argument): Update.
2874         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2875         initial_size parameter.
2876         * rust-exp.y (rust_lex_tests): Update.
2877         * parse.c (parser_state): Update.
2878         (parse_exp_in_context): Update.
2879         * parser-defs.h (struct parser_state) <parser_state>: Remove
2880         "initial_size" parameter.
2881
2882 2019-04-04  Tom Tromey  <tom@tromey.com>
2883
2884         * parser-defs.h (increase_expout_size): Don't declare.
2885         * parse.c (increase_expout_size): Now static.
2886
2887 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2888
2889         * gnu-nat.c (gnu_nat_target::wait): Fix
2890         target_waitstatus_to_string call.
2891
2892 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2893
2894         * eval.c (evaluate_subexp_standard): Handle internal functions
2895         during Fortran function call handling.
2896
2897 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2898
2899         * NEWS: Mention new internal functions.
2900         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2901         (read_base_type): Use dwarf2_init_complex_target_type.
2902         * value.c (creal_internal_fn): New function.
2903         (cimag_internal_fn): New function.
2904         (_initialize_values): Register new internal functions.
2905
2906 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2907
2908         * infrun.c (stop_all_threads): If debug_infrun, always
2909         trace the wait status after wait_one, using
2910         target_waitstatus_to_string and target_pid_to_str.
2911         (handle_inferior_event): Replace various trace of
2912         wait status kind by a single trace.
2913         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2914         wait status kind image by target_waitstatus_to_string.
2915         * target/waitstatus.c (target_waitstatus_to_string): Fix
2916         obsolete comment.
2917
2918 2019-04-01  Tom Tromey  <tromey@adacore.com>
2919
2920         PR symtab/23331:
2921         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2922
2923 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2924             Pedro Alves  <palves@redhat.com>
2925
2926         * top.c (quit_force): Call 'finalize_values'.
2927         * value.c (finalize_values): New function.
2928         * value.h (finalize_values): Declare.
2929
2930 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2931
2932         * NEWS: Announce $_gdb_major and $_gdb_minor.
2933
2934         * top.c (init_gdb_version_vars): New function.
2935         (gdb_init): Call init_gdb_version_vars.
2936
2937 2019-03-29  Tom Tromey  <tromey@adacore.com>
2938
2939         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2940         help text.  Remove dead code.
2941
2942 2019-03-29  Keith Seitz  <keiths@redhat.com>
2943
2944         From Siddhesh Poyarekar:
2945         * f-lang.h (f77_get_upperbound): Return LONGEST.
2946         (f77_get_lowerbound): Likewise.
2947         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2948         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2949         print them.
2950         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2951         plongest to format print it.
2952         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2953         (f77_get_upperbound): Likewise.
2954         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2955         LOWER_BOUND to LONGEST.
2956         (f77_create_arrayprint_offset_tbl): Likewise.
2957
2958 2019-03-29  Keith Seitz  <keiths@redhat.com>
2959
2960         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2961         %s/pulongest for TYPE_LENGTH instead of %d in format
2962         strings.
2963         * ada-typerint.c (ada_print_type): Likewise.
2964         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2965         * compile/compile-c-support.c (generate_register_struct): Likewise.
2966         * gdbtypes.c (recursive_dump_type): Likewise.
2967         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2968         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2969         instead of %d in format strings.
2970         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2971         to std::min to ULONGEST.
2972         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2973         instead of %d in format strings.
2974         * tracepoint.c (info_scope_command): Likewise.
2975         * typeprint.c (print_offset_data::update)
2976         (print_offset_data::finish): Likewise.
2977         * xtensa-tdep.c (xtensa_store_return_value)
2978         (xtensa_push_dummy_call): Likewise.
2979
2980 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2981
2982         * windows-nat.c (display_selector): Fixed format specifications
2983         for 64-bit Cygwin.
2984
2985 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2986
2987         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2988
2989 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2990
2991         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2992         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2993         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2994         (nios2_linux_init_abi): Install it.
2995
2996 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2997
2998         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2999
3000 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3001
3002         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3003
3004 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3005             Tom Tromey  <tromey@adacore.com>
3006
3007         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3008
3009 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3010
3011         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3012         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3013         method to compute the bounds of range types. Also print "[evaluated]"
3014         if the bounds' values come from a dynamic evaluation.
3015
3016 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3019         whitespace when pretty printing is on.
3020
3021 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3022
3023         * ppc-linux-nat.c: Add include.
3024
3025 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3026
3027         * NEWS: Mention AArch64 Pointer Authentication.
3028
3029 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3030
3031         * arm-linux-nat.c: Add include.
3032
3033 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3034
3035         * source-cache.c (source_cache::get_source_lines): Re-read
3036         fullname after calling open_source_file.
3037
3038 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3039
3040         * NEWS: Mention TLS support for FreeBSD.
3041
3042 2019-03-25  Tom Tromey  <tromey@adacore.com>
3043
3044         * minsyms.c (BUNCH_SIZE): Update comment.
3045         (~minimal_symbol_reader): Remove old comment.
3046         (compact_minimal_symbols): Update comment.
3047         (minimal_symbol_reader::install): Remove old comment.  Update
3048         other comments.
3049
3050 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3051
3052         * s390-linux-nat.c: Add include.
3053
3054 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3055
3056         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3057         Call linux_get_hwcap.
3058         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3059         Likewise.
3060         (aarch64_linux_get_hwcap): Remove function.
3061         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3062         declaration.
3063         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3064         linux_get_hwcap.
3065         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3066         * linux-tdep.c (linux_get_hwcap): Add function.
3067         (linux_get_hwcap2): Likewise.
3068         * linux-tdep.h (linux_get_hwcap): Add declaration.
3069         (linux_get_hwcap2): Likewise.
3070         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3071         (ppc_linux_get_hwcap2): Likewise.
3072         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3073         linux_get_hwcap.
3074         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3075         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3076         (ppc_linux_nat_target::read_description): Likewise.
3077         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3078         * s390-linux-nat.c: Likewise.
3079         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3080
3081 2019-03-24  Tom Tromey  <tom@tromey.com>
3082
3083         * ada-lang.c (standard_lookup): Simplify initialization.
3084         (ada_lookup_symbol_nonlocal): Simplify return.
3085         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3086         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3087         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3088         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3089         initialization.
3090         * solib.c (solib_global_lookup): Simplify.
3091         * symtab.c (null_block_symbol): Remove.
3092         (symbol_cache_lookup): Simplify returns.
3093         (lookup_language_this): Simplify returns.
3094         (lookup_symbol_aux): Simplify return.
3095         (lookup_local_symbol): Simplify returns.
3096         (lookup_global_symbol_from_objfile): Simplify return.
3097         (lookup_symbol_in_objfile_symtabs)
3098         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3099         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3100         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3101         * cp-namespace.c (cp_lookup_bare_symbol)
3102         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3103         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3104         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3105         (cp_lookup_symbol_via_imports): Simplify initialization.
3106         (find_symbol_in_baseclass): Likewise.
3107         * symtab.h (null_block_symbol): Remove.
3108         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3109         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3110         (d_lookup_symbol_module): Likewise.
3111         (find_symbol_in_baseclass): Simplify initialization.
3112
3113 2019-03-24  Tom Tromey  <tom@tromey.com>
3114
3115         * expression.h: Don't include symtab.h.
3116         (struct block): Forward declare.
3117
3118 2019-03-24  Tom Tromey  <tom@tromey.com>
3119
3120         * c-exp.y (typebase): Remove casts.
3121         * gdbtypes.c (lookup_unsigned_typename, )
3122         (lookup_signed_typename): Remove cast.
3123         * eval.c (parse_to_comma_and_eval): Remove cast.
3124         * parse.c (write_dollar_variable): Remove cast.
3125         * block.h (struct block) <superblock>: Now const.
3126         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3127         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3128         (map_block): Make "block" const.
3129         * symfile.h (struct quick_symbol_functions)
3130         <map_matching_symbols>: Constify block argument to "callback".
3131         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3132         const.
3133         (find_pc_sect_compunit_symtab): Make "b" const.
3134         (find_symbol_at_address): Likewise.
3135         (search_symbols): Likewise.
3136         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3137         (dw2_debug_names_lookup_symbol): Likewise.
3138         (dw2_map_matching_symbols): Update.
3139         * p-valprint.c (pascal_val_print): Remove "block".
3140         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3141         (aux_add_nonlocal_symbols): Make "block" const.
3142         (resolve_subexp): Remove cast.
3143         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3144         const.
3145         (iterate_over_file_blocks): Likewise.
3146         * f-exp.y (%union) <bval>: Remove.
3147         * coffread.c (patch_opaque_types): Make "b" const.
3148         * spu-tdep.c (spu_catch_start): Make "block" const.
3149         * c-valprint.c (print_unpacked_pointer): Remove "block".
3150         * symmisc.c (dump_symtab_1): Make "b" const.
3151         (block_depth): Make "block" const.
3152         * d-exp.y (%union) <bval>: Remove.
3153         * cp-support.h (cp_lookup_rtti_type): Update.
3154         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3155         * psymtab.c (psym_lookup_symbol): Make "block" const.
3156         (maintenance_check_psymtabs): Make "b" const.
3157         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3158         (enumerate_locals, enumerate_args): Update.
3159         * python/py-symtab.c (stpy_global_block): Make "block" const.
3160         (stpy_static_block): Likewise.
3161         * inline-frame.c (block_starting_point_at): Make "new_block"
3162         const.
3163         * block.c (find_block_in_blockvector): Make return type const.
3164         (blockvector_for_pc_sect): Make "b" const.
3165         (find_block_in_blockvector): Make "b" const.
3166
3167 2019-03-23  Tom Tromey  <tom@tromey.com>
3168
3169         * varobj.c (varobj_create): Update.
3170         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3171         * printcmd.c (display_command, do_one_display): Don't reset
3172         innermost_block.
3173         * parser-defs.h (enum innermost_block_tracker_type): Move to
3174         expression.h.
3175         (innermost_block): Update comment.
3176         * parse.c (parse_exp_1): Add tracker_types parameter.
3177         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3178         tracker_types parameter.  Reset innermost_block.
3179         (parse_exp_in_context): Remove.
3180         (parse_expression_for_completion): Update.
3181         * objfiles.c (~objfile): Don't reset expression_context_block or
3182         innermost_block.
3183         * expression.h (enum innermost_block_tracker_type): Move from
3184         parser-defs.h.
3185         (parse_exp_1): Add tracker_types parameter.
3186         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3187         reset innermost_block.
3188
3189 2019-03-23  Tom Tromey  <tom@tromey.com>
3190
3191         * objfiles.h: Include bcache.h.
3192
3193 2019-03-23  Tom Tromey  <tom@tromey.com>
3194
3195         * linespec.c (get_current_search_block): Use
3196         scoped_restore_current_language.
3197         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3198
3199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3200             Jiong Wang  <jiong.wang@arm.com>
3201
3202         * aarch64-linux-tdep.c
3203         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3204         section.
3205         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3206
3207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3208             Jiong Wang  <jiong.wang@arm.com>
3209
3210         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3211         instructions.
3212         (aarch64_analyze_prologue_test): Add PACIASP test.
3213         (aarch64_prologue_prev_register): Unmask PC value.
3214
3215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3216             Jiong Wang  <jiong.wang@arm.com>
3217
3218         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3219         (aarch64_dwarf2_prev_register): Unmask PC value.
3220         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3221         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3222         DW_CFA_AARCH64_negate_ra_state.
3223         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3224
3225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3226             Jiong Wang  <jiong.wang@arm.com>
3227
3228         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3229         registers.
3230         (aarch64_pseudo_register_name): Likewise.
3231         (aarch64_pseudo_register_type): Likewise.
3232         (aarch64_pseudo_register_reggroup_p): Likewise.
3233         (aarch64_gdbarch_init): Add pauth registers.
3234         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3235         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3236         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3237         (struct gdbarch_tdep): Add regnum for ra_state.
3238
3239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3240             Jiong Wang  <jiong.wang@arm.com>
3241
3242         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3243
3244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3245             Jiong Wang  <jiong.wang@arm.com>
3246
3247         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3248         function.
3249         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3250         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3251         (aarch64_gdbarch_init): Add puth registers.
3252         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3253         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3254         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3255
3256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3257             Jiong Wang  <jiong.wang@arm.com>
3258
3259         * aarch64-linux-nat.c
3260         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3261         * aarch64-linux-tdep.c
3262         (aarch64_linux_core_read_description): Likewise.
3263         (aarch64_linux_get_hwcap): New function.
3264         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3265         (aarch64_linux_get_hwcap): New declaration.
3266
3267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3268             Jiong Wang  <jiong.wang@arm.com>
3269
3270         * aarch64-linux-nat.c
3271         (aarch64_linux_nat_target::read_description): Add pauth param.
3272         * aarch64-linux-tdep.c
3273         (aarch64_linux_core_read_description): Likewise.
3274         * aarch64-tdep.c (struct target_desc): Add in pauth.
3275         (aarch64_read_description): Add pauth param.
3276         (aarch64_gdbarch_init): Likewise.
3277         * aarch64-tdep.h (aarch64_read_description): Likewise.
3278         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3279         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3280         * features/Makefile: Add new files.
3281         * features/aarch64-pauth.c: New file.
3282         * features/aarch64-pauth.xml: New file.
3283
3284 2019-03-20  Tom Tromey  <tromey@adacore.com>
3285
3286         * infrun.c (handle_inferior_event): Rename from
3287         handle_inferior_event_1.  Create a scoped_value_mark.
3288         (handle_inferior_event): Remove.
3289
3290 2019-03-19  Tom Tromey  <tromey@adacore.com>
3291
3292         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3293         * infrun.h (print_stop_event): Add "displays" parameter.
3294         * infrun.c (print_stop_event): Add "displays" parameter.
3295
3296 2019-03-19  Pedro Alves  <palves@redhat.com>
3297
3298         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3299         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3300         to -1.  Fix TABs vs spaces.
3301         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3302         * tui/tui-out.h (tui_ui_out) Add intro comments.
3303         <m_line, m_start_of_line>: In-class initialize, and add describing
3304         comment.
3305
3306 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3307
3308         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3309         variable names.
3310         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3311
3312 2019-03-18  Pedro Alves  <palves@redhat.com>
3313             Eli Zaretskii <eliz@gnu.org>
3314
3315         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3316         m_line and m_start_of_line.
3317
3318 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3319
3320         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3321         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3322         it returns a newline.  This fixes a regression in TU mode, whereby
3323         the next line is output on the same screen line as the user input.
3324
3325 2019-03-18  Tom Tromey  <tromey@adacore.com>
3326
3327         * minsyms.c (minimal_symbol_reader::install): Remove call to
3328         obstack_blank.
3329
3330 2019-03-18  Pedro Alves  <palves@redhat.com>
3331
3332         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3333         New globals.
3334         (apply_style): New, factored out from ...
3335         (apply_ansi_escape): ... this.  Handle reverse video mode.
3336         (tui_set_reverse_mode): New function.
3337         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3338         * tui/tui-winsource.c (tui_show_source_line): Use
3339         tui_set_reverse_mode instead of setting A_STANDOUT.
3340         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3341         New setter methods.
3342
3343 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3344
3345         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3346         Handle tabs.
3347
3348 2019-03-18  Tom Tromey  <tromey@adacore.com>
3349
3350         * ada-lang.c (empty_array): Add "high" parameter.
3351         (ada_evaluate_subexp): Update.
3352
3353 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3354
3355         * unittests/string_view-selftests.c: Define
3356         _initialize_string_view_selftests unconditionally.
3357
3358 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3359
3360         PR gdb/24350
3361         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3362
3363 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3364
3365         PR gdb/24351
3366         * windows-nat.c (display_selector): Fix format specifiers.
3367
3368 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3369
3370         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3371         tui_refill_source_window instead of tui_refresh_win, to update the
3372         current execution line.  This fixes redisplay of the current line
3373         when stepping through the code with "next" or "step".
3374
3375 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3376
3377         * source-cache.c (source_cache::get_source_lines): Call
3378         find_source_lines to initialize s->nlines.  This fixes vertical
3379         scrolling of TUI source window when the DOWN arrow is pressed.
3380
3381 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3382
3383         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3384         linux-thread-db.c (_initialize_thread_db): Likewise.
3385
3386 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3387
3388         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3389         wclrtoeol in tui_show_source_line".  This reverts changes made in
3390         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3391
3392 2019-03-15  Tom Tromey  <tom@tromey.com>
3393
3394         * symtab.h (struct minimal_symbol): Derive from
3395         general_symbol_info.
3396         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3397         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3398         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3399         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3400         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3401         (MSYMBOL_SEARCH_NAME): Update.
3402         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3403         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3404         * minsyms.c (minimal_symbol_reader::record_full): Update.
3405
3406 2019-03-15  Tom Tromey  <tom@tromey.com>
3407
3408         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3409
3410 2019-03-15  Tom Tromey  <tom@tromey.com>
3411
3412         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3413         unique_xmalloc_ptr.
3414         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3415         Update.
3416         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3417         (build_minimal_symbol_hash_tables)
3418         (minimal_symbol_reader::install): Update.
3419
3420 2019-03-15  Tom Tromey  <tom@tromey.com>
3421
3422         * symtab.c (create_demangled_names_hash): Update.
3423         (symbol_set_names): Update.
3424         * objfiles.h (struct objfile_per_bfd_storage)
3425         <demangled_names_hash>: Now an htab_up.
3426         * objfiles.c (objfile_per_bfd_storage): Simplify.
3427
3428 2019-03-15  Tom Tromey  <tom@tromey.com>
3429
3430         * objfiles.h (struct objfile_per_bfd_storage): Declare
3431         destructor.
3432         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3433         New.
3434         (get_objfile_bfd_data): Use new.  Don't initialize
3435         language_of_main.
3436         (free_objfile_per_bfd_storage): Remove.
3437         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3438
3439 2019-03-15  Tom Tromey  <tom@tromey.com>
3440
3441         * symfile.c (reread_symbols): Update.
3442         * objfiles.c (objfile::objfile): Update.
3443         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3444         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3445         comment.
3446         (minimal_symbol_reader::install): Update.
3447         (terminate_minimal_symbol_table): Remove.
3448         * jit.c (jit_object_close_impl): Update.
3449
3450 2019-03-15  Tom Tromey  <tom@tromey.com>
3451
3452         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3453         initializations.
3454
3455 2019-03-15  Tom Tromey  <tom@tromey.com>
3456
3457         * objfiles.h (struct objfile_per_bfd_storage)
3458         <demangled_hash_languages>: Now a bitset.
3459         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3460         (lookup_minimal_symbol): Update.
3461
3462 2019-03-15  Tom Tromey  <tom@tromey.com>
3463
3464         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3465         Don't return the symbol.
3466         * coffread.c (record_minimal_symbol): Use record_full.
3467
3468 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3469
3470         The MS-Windows port of ncurses fails to switch to a color pair if
3471         one or both of the colors are the implicit default colors.  This
3472         change records the default colors when TUI is initialized, and
3473         then specifies them explicitly when a color pair uses the default
3474         colors.  This allows color styling in TUI mode on MS-Windows.
3475
3476         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3477         ncurses_norm_attr.
3478         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3479         colors in ncurses_norm_attr.
3480         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3481         "none", replace it with the default color recorded in
3482         ncurses_norm_attr.
3483
3484 2019-03-14  Tom Tromey  <tromey@adacore.com>
3485
3486         * source-cache.h (class source_cache) <get_source_lines>: Return
3487         std::string.
3488         * source-cache.c (source_cache::extract_lines): Handle case where
3489         first_pos==npos.  Return std::string.
3490         (source_cache::get_source_lines): Update.
3491
3492 2019-03-14  Tom Tromey  <tromey@adacore.com>
3493
3494         * NEWS: Add item for "style sources" commands.
3495         * source-cache.c (source_cache::get_source_lines): Check
3496         source_styling.
3497         * cli/cli-style.c (source_styling): New global.
3498         (_initialize_cli_style): Add "style sources" commands.
3499         (show_style_sources): New function.
3500         * cli/cli-style.h (source_styling): Declare.
3501
3502 2019-03-14  Pedro Alves  <palves@redhat.com>
3503             Tom Tromey  <tromey@adacore.com>
3504
3505         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3506         * tui/tui-winsource.c (tui_refill_source_window): New function,
3507         from...
3508         (tui_horizontal_source_scroll): ... here.  Move some logic.
3509         * cli/cli-style.c (set_style_enabled): Notify new observable.
3510         * tui/tui-hooks.c (tui_redisplay_source): New function.
3511         (tui_attach_detach_observers): Attach or detach
3512         tui_redisplay_source.
3513         * observable.h (source_styling_changed): New observable.
3514         * observable.c: Define source_styling_changed observable.
3515
3516 2019-03-13  Tom Tromey  <tromey@adacore.com>
3517
3518         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3519         (i386_gnu_nat_target::store_registers): Update.
3520         * target-debug.h (target_debug_print_std_string): New macro.
3521         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3522         * windows-tdep.c (display_one_tib): Update.
3523         * tui/tui-stack.c (tui_make_status_line): Update.
3524         * top.c (print_inferior_quit_action): Update.
3525         * thread.c (thr_try_catch_cmd): Update.
3526         (add_thread_with_info): Update.
3527         (thread_target_id_str): Update.
3528         (thr_try_catch_cmd): Update.
3529         (thread_command): Update.
3530         (thread_find_command): Update.
3531         * record-btrace.c (record_btrace_target::info_record)
3532         (record_btrace_resume_thread, record_btrace_target::resume)
3533         (record_btrace_cancel_resume, record_btrace_step_thread)
3534         (record_btrace_target::wait, record_btrace_target::wait)
3535         (record_btrace_target::wait, record_btrace_target::stop): Update.
3536         * progspace.c (print_program_space): Update.
3537         * process-stratum-target.c
3538         (process_stratum_target::thread_address_space): Update.
3539         * linux-fork.c (linux_fork_mourn_inferior)
3540         (detach_checkpoint_command, info_checkpoints_command)
3541         (linux_fork_context): Update.
3542         (linux_fork_detach): Update.
3543         (class scoped_switch_fork_info): Update.
3544         (delete_checkpoint_command): Update.
3545         * infrun.c (follow_fork_inferior): Update.
3546         (follow_fork_inferior): Update.
3547         (proceed_after_vfork_done): Update.
3548         (handle_vfork_child_exec_or_exit): Update.
3549         (follow_exec): Update.
3550         (displaced_step_prepare_throw): Update.
3551         (displaced_step_restore): Update.
3552         (start_step_over): Update.
3553         (resume_1): Update.
3554         (clear_proceed_status_thread): Update.
3555         (proceed): Update.
3556         (print_target_wait_results): Update.
3557         (do_target_wait): Update.
3558         (context_switch): Update.
3559         (stop_all_threads): Update.
3560         (restart_threads): Update.
3561         (finish_step_over): Update.
3562         (handle_signal_stop): Update.
3563         (switch_back_to_stepped_thread): Update.
3564         (keep_going_pass_signal): Update.
3565         (print_exited_reason): Update.
3566         (normal_stop): Update.
3567         * inferior.c (inferior_pid_to_str): Change return type.
3568         (print_selected_inferior): Update.
3569         (add_inferior): Update.
3570         (detach_inferior): Update.
3571         * dummy-frame.c (fprint_dummy_frames): Update.
3572         * dcache.c (dcache_info_1): Update.
3573         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3574         (btrace_fetch, btrace_clear): Update.
3575         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3576         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3577         type.
3578         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3579         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3580         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3581         * gdbarch.c, gdbarch.h: Rebuild.
3582         * gdbarch.sh (core_pid_to_str): Change return type.
3583         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3584         return type.
3585         (windows_nat_target::pid_to_str): Change return type.
3586         (windows_delete_thread): Update.
3587         (windows_nat_target::attach): Update.
3588         (windows_nat_target::files_info): Update.
3589         * target-delegates.c: Rebuild.
3590         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3591         return type.
3592         (sol_thread_target::pid_to_str): Change return type.
3593         * remote.c (class remote_target) <pid_to_str>: Change return
3594         type.
3595         (remote_target::pid_to_str): Change return type.
3596         (extended_remote_target::attach, remote_target::remote_stop_ns)
3597         (remote_target::remote_notif_remove_queued_reply)
3598         (remote_target::push_stop_reply, remote_target::disable_btrace):
3599         Update.
3600         (extended_remote_target::attach): Update.
3601         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3602         type.
3603         (gdbsim_target::pid_to_str): Change return type.
3604         * ravenscar-thread.c (struct ravenscar_thread_target)
3605         <pid_to_str>: Change return type.
3606         (ravenscar_thread_target::pid_to_str): Change return type.
3607         * procfs.c (class procfs_target) <pid_to_str>: Change return
3608         type.
3609         (procfs_target::pid_to_str): Change return type.
3610         (procfs_target::attach): Update.
3611         (procfs_target::detach): Update.
3612         (procfs_target::fetch_registers): Update.
3613         (procfs_target::store_registers): Update.
3614         (procfs_target::wait): Update.
3615         (procfs_target::files_info): Update.
3616         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3617         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3618         return type.
3619         (nto_procfs_target::pid_to_str): Change return type.
3620         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3621         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3622         return type.
3623         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3624         (exit_lwp): Update.
3625         (attach_proc_task_lwp_callback, get_detach_signal)
3626         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3627         (linux_nat_target::resume, wait_lwp, stop_callback)
3628         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3629         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3630         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3631         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3632         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3633         type.
3634         (inf_ptrace_target::attach): Update.
3635         (inf_ptrace_target::files_info): Update.
3636         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3637         type.
3638         (go32_nat_target::pid_to_str): Change return type.
3639         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3640         (gnu_nat_target::wait): Update.
3641         (gnu_nat_target::wait): Update.
3642         (gnu_nat_target::resume): Update.
3643         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3644         (fbsd_nat_target::wait): Update.
3645         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3646         type.
3647         (darwin_nat_target::attach): Update.
3648         * corelow.c (class core_target) <pid_to_str>: Change return type.
3649         (core_target::pid_to_str): Change return type.
3650         * target.c (normal_pid_to_str): Change return type.
3651         (default_pid_to_str): Likewise.
3652         (target_pid_to_str): Change return type.
3653         (target_translate_tls_address): Update.
3654         (target_announce_detach): Update.
3655         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3656         return type.
3657         (bsd_uthread_target::pid_to_str): Change return type.
3658         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3659         type.
3660         (bsd_kvm_target::pid_to_str): Change return type.
3661         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3662         return type.
3663         (aix_thread_target::pid_to_str): Change return type.
3664         * target.h (struct target_ops) <pid_to_str>: Change return type.
3665         (target_pid_to_str, normal_pid_to_str): Likewise.
3666         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3667         type.
3668         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3669         type.
3670         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3671         return type.
3672         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3673         type.
3674         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3675         type.
3676         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3677         return type.
3678
3679 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3680
3681         * NEWS: Mention that the new default MI version is 3.  Mention
3682         changes to the output of commands and events that deal with
3683         multi-location breakpoints.
3684         * breakpoint.c: Include "mi/mi-out.h".
3685         (print_one_breakpoint): Change output syntax if using MI version
3686         >= 3.
3687         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3688         New.
3689         (mi_multi_location_breakpoint_output_fixed): New.
3690         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3691         (mi_cmd_fix_multi_location_breakpoint_output): New.
3692         (mi_multi_location_breakpoint_output_fixed): New.
3693         * mi/mi-cmds.c (mi_cmds): Register command
3694         -fix-multi-location-breakpoint-output.
3695         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3696         interpreter "mi".
3697
3698 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3699
3700         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3701         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3702         instantiate mi_ui_out based on interpreter name.
3703         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3704         * mi/mi-main.c (mi_load_progress): Likewise.
3705
3706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3707
3708         * NEWS: Combine separate "New targets" sections for 8.3.
3709
3710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3711
3712         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3713         (ppcfbsd_init_abi): Install gdbarch
3714         "fetch_tls_load_module_address" and "get_thread_local_address"
3715         methods.
3716
3717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3718
3719         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3720         (riscv_fbsd_init_abi): Install gdbarch
3721         "fetch_tls_load_module_address" and "get_thread_local_address"
3722         methods.
3723
3724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3725
3726         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3727         (i386fbsd_init_abi): Install gdbarch
3728         "fetch_tls_load_module_address" and "get_thread_local_address"
3729         methods.
3730
3731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3732
3733         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3734         (amd64fbsd_init_abi): Install gdbarch
3735         "fetch_tls_load_module_address" and "get_thread_local_address"
3736         methods.
3737
3738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3739
3740         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3741         (struct fbsd_pspace_data): New type.
3742         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3743         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3744         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3745         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3746         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3747
3748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3749
3750         * gdbtypes.c (lookup_struct_elt): New function.
3751         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3752         * gdbtypes.h (struct struct_elt): New type.
3753         (lookup_struct_elt): New prototype.
3754
3755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3756
3757         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3758         remove disabled code block.
3759
3760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3761
3762         * gdbarch.sh (get_thread_local_address): New method.
3763         * gdbarch.h, gdbarch.c: Regenerate.
3764         * target.c (target_translate_tls_address): Use
3765         gdbarch_get_thread_local_address if present instead of
3766         target::get_thread_local_address.
3767
3768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3769
3770         * target.h (target::get_thread_local_address): Update comment.
3771
3772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3773
3774         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3775         objfile->separate_debug_objfile_backlink if not NULL.
3776
3777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3778
3779         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3780         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3781         (amd64bsd_store_inferior_registers): Likewise.
3782         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3783         Enable segment base registers.
3784         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3785         PT_GETFSBASE and PT_GETGSBASE.
3786         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3787         PT_SETGSBASE.
3788         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3789         segment base registers.
3790         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3791
3792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3793
3794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3795         Update calls to i386_target_description to add 'segments'
3796         parameter.
3797         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3798         add segment base registers.
3799         * arch/i386.c (i386_create_target_description): Add 'segments'
3800         parameter to enable segment base registers.
3801         * arch/i386.h (i386_create_target_description): Likewise.
3802         * features/i386/32bit-segments.xml: New file.
3803         * features/i386/32bit-segments.c: Generate.
3804         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3805         call to i386_target_description to add 'segments' parameter.
3806         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3807         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3808         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3809         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3810         if feature is present.
3811         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3812         Add 'segments' parameter to call to i386_target_description.
3813         (i386_target_description): Add 'segments' parameter to enable
3814         segment base registers.
3815         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3816         to call to i386_target_description.
3817         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3818         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3819         Define I386_NUM_REGS.
3820         (i386_target_description): Add 'segments' parameter to enable
3821         segment base registers.
3822
3823 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3824
3825         PR/24325
3826         * source-cache.c: #undef open and close, to avoid unresolved
3827         externals during linking.
3828
3829 2019-03-12  Tom Tromey  <tromey@adacore.com>
3830
3831         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3832         const.  Add initializers.
3833         (_initialize_remote): Don't initialize ptid globals.
3834
3835 2019-03-12  Pedro Alves  <palves@redhat.com>
3836
3837         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3838
3839 2019-03-12  Pedro Alves  <palves@redhat.com>
3840
3841         * cp-name-parser.y (main): Remove unused 'len' variable.
3842
3843 2019-03-12  Tom Tromey  <tromey@adacore.com>
3844
3845         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3846         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3847
3848 2019-03-12  Tom Tromey  <tromey@adacore.com>
3849
3850         * linux-nat.c (iterate_over_lwps): Update.
3851         (stop_callback): Remove parameter.
3852         (stop_wait_callback, detach_callback, resume_set_callback)
3853         (select_singlestep_lwp_callback, set_ignore_sigint)
3854         (status_callback, resumed_callback, resume_clear_callback)
3855         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3856         data parameter.
3857         (linux_nat_target::detach, linux_nat_target::resume)
3858         (linux_stop_and_wait_all_lwps, select_event_lwp)
3859         (linux_nat_filter_event, linux_nat_wait_1)
3860         (linux_nat_target::kill, linux_nat_target::stop)
3861         (linux_nat_target::stop): Update.
3862         (linux_nat_resume_callback): Change type.
3863         (resume_stopped_resumed_lwps, count_events_callback)
3864         (select_event_lwp_callback): Likewise.
3865         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3866         * arm-linux-nat.c (struct update_registers_data): Remove.
3867         (update_registers_callback): Change type.
3868         (arm_linux_insert_hw_breakpoint1): Update.
3869         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3870         parameter.
3871         (x86_linux_dr_set_addr): Update.
3872         (x86_linux_dr_set_control): Update.
3873         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3874         (iterate_over_lwps): Use gdb::function_view.
3875         * nat/aarch64-linux-hw-point.c (struct
3876         aarch64_dr_update_callback_param): Remove.
3877         (debug_reg_change_callback): Change type.
3878         (aarch64_notify_debug_reg_change): Update.
3879         * s390-linux-nat.c (s390_refresh_per_info): Update.
3880
3881 2019-03-11  Tom Tromey  <tromey@adacore.com>
3882
3883         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3884         redundant assignment to "this_cu".
3885
3886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3887
3888         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3889
3890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3891
3892         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3893         from...
3894         (rank_one_type): ... this.
3895
3896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3897
3898         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3899         from...
3900         (rank_one_type): ... this.
3901
3902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3903
3904         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3905         from...
3906         (rank_one_type): ... this.
3907
3908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3909
3910         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3911         from...
3912         (rank_one_type): ... this.
3913
3914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3915
3916         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3917         from...
3918         (rank_one_type): ... this.
3919
3920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3921
3922         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3923         from...
3924         (rank_one_type): ... this.
3925
3926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3927
3928         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3929         from...
3930         (rank_one_type): ... this.
3931
3932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3933
3934         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3935         from...
3936         (rank_one_type): ... this.
3937
3938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3939
3940         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3941         from...
3942         (rank_one_type): ... this.
3943
3944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3945
3946         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3947         from...
3948         (rank_one_type): ... this.
3949
3950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3951
3952         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3953         from...
3954         (rank_one_type): ... this.
3955
3956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3957
3958         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3959         from...
3960         (rank_one_type): ... this.
3961
3962 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3963
3964         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3965         inferior-events' shows the example events.
3966
3967 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3968
3969         Support styling on native MS-Windows console
3970
3971         PR/24315
3972         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3973         on MS-Windows if $TERM is not defined.
3974
3975         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3976
3977         * posix-hdep.c (gdb_console_fputs):
3978         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3979         functions.
3980         * ui-file.h (gdb_console_fputs): Add prototype.
3981
3982         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3983         back to fputs only if the former returns zero.
3984
3985 2019-03-07  Tom Tromey  <tom@tromey.com>
3986
3987         * symmisc.c (print_symbol_bcache_statistics): Update.
3988         (print_objfile_statistics): Update.
3989         * symfile.c (allocate_symtab): Update.
3990         * stabsread.c: Don't include bcache.h.
3991         * psymtab.h (struct psymbol_bcache): Don't declare.
3992         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3993         (psymbol_bcache_init, psymbol_bcache_free)
3994         (psymbol_bcache_get_bcache): Don't declare.
3995         * psymtab.c (struct psymbol_bcache): Remove.
3996         (psymtab_storage::psymtab_storage): Update.
3997         (psymtab_storage::~psymtab_storage): Update.
3998         (psymbol_bcache_init, psymbol_bcache_free)
3999         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4000         (add_psymbol_to_bcache): Update.
4001         (allocate_psymtab): Update.
4002         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4003         macro_cache>: No longer pointers.
4004         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4005         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4006         * macrotab.c (macro_bcache): Update.
4007         * macroexp.c: Don't include bcache.h.
4008         * gdbtypes.c (check_types_worklist): Update.
4009         (types_deeply_equal): Remove TRY/CATCH.  Update.
4010         * elfread.c (elf_symtab_read): Update.
4011         * dwarf2read.c: Don't include bcache.h.
4012         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4013         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4014         (print_bcache_statistics, bcache_memory_used): Don't declare.
4015         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4016         methods.  Rename all data members.
4017         * bcache.c (struct bcache): Move to bcache.h.
4018         (bcache::expand_hash_table): Rename from expand_hash_table.
4019         (bcache): Remove.
4020         (bcache::insert): Rename from bcache_full.
4021         (bcache::compare): Rename from bcache_compare.
4022         (bcache_xmalloc): Remove.
4023         (bcache::~bcache): Rename from bcache_xfree.
4024         (bcache::print_statistics): Rename from print_bcache_statistics.
4025         (bcache::memory_used): Rename from bcache_memory_used.
4026
4027 2019-03-07  Pedro Alves  <palves@redhat.com>
4028
4029         * infrun.c (normal_stop): Also check for
4030         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4031
4032 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * f-lang.c (value_from_host_double): Moved to...
4035         * value.c (value_from_host_double): ...here.
4036         * value.h (value_from_host_double): Declare.
4037         * guile/scm-math.c (vlscm_convert_typed_number): Use
4038         value_from_host_double.
4039         (vlscm_convert_number): Likewise.
4040         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4041         * python/py-value.c (convert_value_from_python): Likewise.
4042
4043 2019-03-06  Tom Tromey  <tom@tromey.com>
4044
4045         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4046
4047 2019-03-06  Tom Tromey  <tom@tromey.com>
4048
4049         * utils.h (free_current_contents): Don't declare.
4050         * utils.c (free_current_contents): Remove.
4051
4052 2019-03-06  Tom Tromey  <tom@tromey.com>
4053
4054         * top.c (quit_force): Update.
4055         * main.c (captured_command_loop): Update.
4056         * common/new-op.c (operator new): Update.
4057         * common/common-exceptions.c (struct catcher)
4058         <save_cleanup_chain>: Remove member.
4059         (exceptions_state_mc_init): Update.
4060         (exception_try_scope_entry): Return nullptr.
4061         (exception_try_scope_exit, exception_rethrow)
4062         (throw_exception_sjlj, throw_exception_cxx): Update.
4063         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4064         (all_cleanups, do_cleanups, discard_cleanups)
4065         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4066         (restore_cleanups, restore_final_cleanups): Don't declare.
4067         (do_final_cleanups): Remove parameter.
4068         * common/cleanups.c (cleanup_chain, make_cleanup)
4069         (make_cleanup_dtor, all_cleanups, do_cleanups)
4070         (discard_my_cleanups, discard_cleanups)
4071         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4072         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4073         (null_cleanup): Remove.
4074         (do_final_cleanups): Remove parameter.
4075
4076 2019-03-06  Tom Tromey  <tom@tromey.com>
4077
4078         * remote.c (remote_target::remote_parse_stop_reply): Use
4079         unique_xmalloc_ptr.
4080
4081 2019-03-06  Tom Tromey  <tom@tromey.com>
4082
4083         * stabsread.c (struct stabs_field_info): Rename from field_info.
4084         <list, fnlist>: Add initializers.
4085         <obstack>: New member.
4086         (read_member_functions, read_struct_fields, read_baseclasses):
4087         Allocate on obstack.  Don't use cleanups.
4088         (read_one_struct_field, read_member_functions, read_struct_fields)
4089         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4090         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4091         (read_struct_type): Update.
4092
4093 2019-03-06  Tom Tromey  <tom@tromey.com>
4094
4095         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4096         * common/filestuff.h (make_cleanup_close): Don't declare.
4097         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4098         Remove.
4099
4100 2019-03-06  Tom Tromey  <tom@tromey.com>
4101
4102         * solib-aix.c: Use make_scope_exit.
4103
4104 2019-03-06  Tom Tromey  <tom@tromey.com>
4105
4106         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4107         Use make_scope_exit.
4108
4109 2019-03-06  Tom Tromey  <tom@tromey.com>
4110
4111         * solib-svr4.c (disable_probes_interface): Remove parameter.
4112         (svr4_handle_solib_event): Use make_scope_exit.
4113
4114 2019-03-06  Tom Tromey  <tom@tromey.com>
4115
4116         * remote.c (struct stop_reply_deleter): Remove.
4117         (stop_reply_up): Update.
4118         (struct stop_reply): Derive from notif_event.  Don't typedef.
4119         <regcache>: Now a std::vector.
4120         (stop_reply_xfree): Remove.
4121         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4122         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4123         (remote_target::discard_pending_stop_replies): Use delete.
4124         (remote_target::remote_parse_stop_reply): Update.
4125         (remote_target::process_stop_reply): Update.
4126         * remote-notif.h (struct notif_event): Add virtual destructor.
4127         Remove "dtr" member.
4128         (struct notif_client) <alloc_event>: Return a unique_ptr.
4129         (notif_event_xfree): Don't declare.
4130         (notif_event_up): New typedef.
4131         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4132         (notif_event_xfree, do_notif_event_xfree): Remove.
4133         (remote_notif_state_xfree): Update.
4134
4135 2019-03-06  Tom Tromey  <tom@tromey.com>
4136
4137         * infrun.c (displaced_step_clear_cleanup): Now a
4138         forward_scope_exit type.
4139         (displaced_step_prepare_throw): Update.
4140         (displaced_step_fixup): Update.
4141
4142 2019-03-06  Tom Tromey  <tom@tromey.com>
4143
4144         * inferior.h (class inferior): Update comment.
4145         * gdbthread.h (class thread_info): Update comment.
4146
4147 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4148             Tom Tromey  <tom@tromey.com>
4149
4150         * stabsread.h (struct stab_section_list): Remove.
4151         (coffstab_build_psymtabs): Update.
4152         * dbxread.c (symbuf_sections): Now a std::vector.
4153         (sect_idx): New global.
4154         (fill_symbuf): Update.
4155         (coffstab_build_psymtabs): Change type of stabsects parameter.
4156         Update.
4157         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4158         std::vector.
4159         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4160         (coff_locate_sections): Update.
4161         (coff_symfile_read): Remove cleanups.  Update.
4162         (init_stringtab): Add storage parameter.
4163         (free_stringtab, free_stringtab_cleanup): Remove.
4164         (init_lineno): Add storage parameter.
4165         (free_linetab, free_linetab_cleanup): Remove.
4166
4167 2019-03-06  Pedro Alves  <palves@redhat.com>
4168
4169         * linux-fork.c (fork_info::clobber_regs): Delete.
4170         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4171         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4172         comment.  Adjust.
4173         (scoped_switch_fork_info::scoped_switch_fork_info)
4174         (checkpoint_command, linux_fork_context): Adjust
4175         fork_save_infrun_state calls.
4176
4177 2019-03-06  Pedro Alves  <palves@redhat.com>
4178
4179         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4180         (inf_has_multiple_threads): Return 'bool' and rewrite using
4181         inferior_info::threads().
4182
4183 2019-03-06  Pedro Alves  <palves@redhat.com>
4184
4185         * linux-fork.c: Include <list>.
4186         (fork_list): Now a std::list instance.
4187         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4188         (forks_exist_p, find_last_fork): Adjust.
4189         (new_fork): Delete.
4190         (one_fork_p): New.
4191         (add_fork): Adjust.
4192         (free_fork): Delete, folded into fork_info::~fork_info().
4193         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4194         Adjust.
4195         (init_fork_list): Delete.
4196         (linux_fork_killall, linux_fork_mourn_inferior)
4197         (linux_fork_detach, info_checkpoints_command): Adjust.
4198         (_initialize_linux_fork): No longer call init_fork_list.
4199
4200 2019-03-06  Pedro Alves  <palves@redhat.com>
4201
4202         * linux-fork.c (new_fork): New, split out of ...
4203         (add_fork): ... this.  Return void.  Move "first fork" special
4204         case from here, to ...
4205         (checkpoint_command): ... here.
4206         * linux-linux.h (add_fork): Return void.
4207
4208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4211
4212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4213             Chris January  <chris.january@arm.com>
4214             David Lecomber  <david.lecomber@arm.com>
4215
4216         * f-exp.y: New token, UNOP_INTRINSIC.
4217         (exp): New pattern using UNOP_INTRINSIC token.
4218         (f77_keywords): Add 'abs' keyword.
4219         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4220         (value_from_host_double): New function.
4221         (evaluate_subexp_f): Support UNOP_ABS.
4222
4223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4224
4225         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4226         types.
4227
4228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4231         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4232         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4233
4234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4237
4238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4239             Chris January  <chris.january@arm.com>
4240
4241         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4242         * f-exp.y: Define 'KIND' token.
4243         (exp): New pattern for KIND expressions.
4244         (ptype): Handle types with a kind extension.
4245         (direct_abs_decl): Extend to spot kind extensions.
4246         (f77_keywords): Add 'kind' to the list.
4247         (push_kind_type): New function.
4248         (convert_to_kind_type): New function.
4249         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4250         * parse.c (operator_length_standard): Likewise.
4251         * parser-defs.h (enum type_pieces): Add tp_kind.
4252         * std-operator.def: Add UNOP_KIND.
4253
4254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * f-exp.y (f_parse): Set yydebug.
4257
4258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4259
4260         * f-lang.c (evaluate_subexp_f): New function.
4261         (exp_descriptor_f): New global.
4262         (f_language_defn): Use exp_descriptor_f instead of
4263         exp_descriptor_standard.
4264
4265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4266
4267         * f-exp.y (struct token): Add comments.
4268         (dot_ops): Remove uppercase versions and the end marker.
4269         (f77_keywords): Likewise.
4270         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4271         entries in the dot_ops array are case insensitive, and use
4272         strncasecmp to compare strings.  Also some whitespace cleanup in
4273         this area.  Similar for the f77_keywords array, except entries in
4274         this list might be case sensitive.
4275
4276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4277
4278         * f-exp.y (struct f77_boolean_val): Add comments.
4279         (boolean_values): Remove uppercase versions, and end marker.
4280         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4281         and use strncasecmp to achieve case insensitivity.  Additionally,
4282         perform whitespace cleanup around this code.
4283
4284 2019-03-06  Tom Tromey  <tromey@adacore.com>
4285
4286         * remote-sim.c (gdbsim_target_open): Use result of
4287         gdb_argv::release.
4288
4289 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4290         Dirk Schubert  <dirk.schubert@arm.com>
4291         Chris January  <chris.january@arm.com>
4292
4293         * eval.c (evaluate_subexp_standard): Call Fortran argument
4294         wrapping logic.
4295         * f-lang.c (struct value): A value which can be passed into a
4296         Fortran function call.
4297         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4298         where appropriate.
4299         (struct type): Value ready for a Fortran function call.
4300         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4301         is needed.
4302         * f-lang.h (fortran_argument_convert): Declaration.
4303         (fortran_preserve_arg_pointer): Declaration.
4304         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4305
4306 2019-03-05  Tom Tromey  <tromey@adacore.com>
4307
4308         * python/py-prettyprint.c (print_string_repr): Remove #if.
4309         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4310
4311 2019-03-05  Tom Tromey  <tromey@adacore.com>
4312
4313         * target.c (the_dummy_target): Move later.  Change type to
4314         "dummy_target".
4315         (initialize_targets): Don't initialize the_dummy_target.
4316
4317 2019-03-05  Tom Tromey  <tromey@adacore.com>
4318
4319         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4320         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4321
4322 2019-03-05  Tom Tromey  <tromey@adacore.com>
4323
4324         * windows-nat.c (windows_nat_target::attach)
4325         (windows_nat_target::detach): Don't call gdb_flush.
4326         * valprint.c (generic_val_print, val_print, val_print_string):
4327         Don't call gdb_flush.
4328         * utils.c (defaulted_query): Don't call gdb_flush.
4329         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4330         * target.c (target_announce_detach): Don't call gdb_flush.
4331         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4332         * remote.c (extended_remote_target::attach): Don't call
4333         gdb_flush.
4334         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4335         * printcmd.c (do_examine): Don't call gdb_flush.
4336         (info_display_command): Don't call gdb_flush.
4337         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4338         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4339         * memattr.c (info_mem_command): Don't call gdb_flush.
4340         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4341         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4342         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4343         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4344         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4345         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4346         (gnu_nat_target::detach): Don't call gdb_flush.
4347         * f-valprint.c (f_val_print): Don't call gdb_flush.
4348         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4349         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4350         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4351         gdb_flush.
4352         * c-valprint.c (c_val_print): Don't call gdb_flush.
4353         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4354
4355 2019-03-05  Tom Tromey  <tromey@adacore.com>
4356
4357         * varobj.c (update_dynamic_varobj_children): Update.
4358         (install_default_visualizer): Use reset, not release.
4359         * value.c (set_internalvar): Update.
4360         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4361         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4362         ATTRIBUTE_UNUSED_RESULT.
4363
4364 2019-03-05  Tom Tromey  <tromey@adacore.com>
4365
4366         * remote.c (class scoped_remote_fd) <release>: Add
4367         ATTRIBUTE_UNUSED_RESULT.
4368
4369 2019-03-05  Tom Tromey  <tromey@adacore.com>
4370
4371         * macroexp.c (struct macro_buffer) <release>: Add
4372         ATTRIBUTE_UNUSED_RESULT.
4373
4374 2019-03-05  Tom Tromey  <tromey@adacore.com>
4375
4376         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4377         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4378         ATTRIBUTE_UNUSED_RESULT.
4379
4380 2019-03-05  Tom Tromey  <tromey@adacore.com>
4381
4382         * common/scoped_fd.h (class scoped_fd) <release>: Add
4383         ATTRIBUTE_UNUSED_RESULT.
4384
4385 2019-03-05  Tom Tromey  <tromey@adacore.com>
4386
4387         * parser-defs.h (struct parser_state) <release>: Add
4388         ATTRIBUTE_UNUSED_RESULT.
4389
4390 2019-03-05  Tom Tromey  <tromey@adacore.com>
4391
4392         * utils.h (class gdb_argv) <release>: Add
4393         ATTRIBUTE_UNUSED_RESULT.
4394         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4395
4396 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4397
4398         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4399         for-loop range, to avoid compiler warnings.
4400
4401         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4402         avoid compiler warnings about unused variables.
4403
4404         * NEWS: Mention end of support for native debugging on MS-Windows
4405         before XP.
4406
4407         PR gdb/24292
4408         * common/netstuff.c:
4409         * gdbserver/gdbreplay.c
4410         * gdbserver/remote-utils.c:
4411         * ser-tcp.c:
4412         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4413         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4414         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4415         'getaddrinfo' and 'freeaddrinfo' were not available before
4416         Windows XP, and mingw.org's MinGW headers by default define
4417         _WIN32_WINNT to 0x500.
4418
4419 2019-03-01  Gary Benson <gbenson@redhat.com>
4420
4421         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4422
4423 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4424             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4425
4426         PR gdb/8527
4427         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4428         set_sigint_trap, clear_sigint_trap.
4429
4430 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4431
4432         * target.c (target_detach): Clear the regcache and the
4433         frame cache.
4434
4435 2019-02-27  Pedro Alves  <palves@redhat.com>
4436
4437         * utils.c (set_screen_size): When we cap the height/width sizes,
4438         tweak the corresponding command variable to show "unlimited":
4439
4440 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4441             Pedro Alves  <palves@redhat.com>
4442
4443         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4444         before calling rl_set_screen_size.
4445
4446 2019-02-27  Tom Tromey  <tromey@adacore.com>
4447
4448         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4449         define.
4450         * python/py-value.c: Remove Python 2.4 workaround.
4451         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4452         workaround.
4453         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4454         Python 2.4 workaround.
4455         * python/python-internal.h: Remove Python 2.4 comment.
4456         (Py_ssize_t): Don't define.
4457         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4458         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4459         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4460         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4461         * python/python.c (do_start_initialization): Remove Python 2.4
4462         workaround.
4463         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4464         (print_children): Remove Python 2.4 workaround.
4465         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4466         workaround.
4467         (CHARBUFFERPROC_NAME): Remove.
4468         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4469         Python 2.4 workaround.
4470
4471 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4472
4473         * NEWS: Note minimum Python version.
4474
4475 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4476
4477         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4478         code from these functions.  Remove corresponding ifdefs.  Use
4479         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4480         Remove gotos and target of gotos.
4481         (infpy_search_memory): Likewise.
4482
4483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4486         (hppa_gdbarch_init): Don't register deleted functions with
4487         gdbarch.
4488
4489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4490
4491         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4492         (h8300_unwind_sp): Delete.
4493         (h8300_dummy_id): Delete.
4494         (h8300_gdbarch_init): Don't register deleted functions with
4495         gdbarch.
4496
4497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4498
4499         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4500         (ft32_unwind_pc): Delete.
4501         (ft32_unwind_sp): Delete.
4502         (ft32_gdbarch_init): Don't register deleted functions with
4503         gdbarch.
4504
4505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4508         (frv_unwind_pc): Delete.
4509         (frv_unwind_sp): Delete.
4510         (frv_gdbarch_init): Don't register deleted functions with
4511         gdbarch.
4512
4513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4516         (riscv_unwind_pc): Delete.
4517         (riscv_unwind_sp): Delete.
4518         (riscv_gdbarch_init): Don't register deleted functions with
4519         gdbarch.
4520
4521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4524         (csky_unwind_pc): Delete.
4525         (csky_unwind_sp): Delete.
4526         (csky_gdbarch_init): Don't register deleted functions with
4527         gdbarch.
4528
4529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4532         (cris_unwind_pc): Delete.
4533         (cris_unwind_sp): Delete.
4534         (cris_gdbarch_init): Don't register deleted functions with
4535         gdbarch.
4536
4537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4538
4539         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4540         (bfin_unwind_pc): Delete.
4541         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4542
4543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4544
4545         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4546         (arm_unwind_pc): Delete.
4547         (arm_unwind_sp): Delete.
4548         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4549
4550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4551
4552         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4553         (arc_unwind_pc): Delete.
4554         (arc_unwind_sp): Delete.
4555         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4556
4557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4558
4559         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4560         (alpha_unwind_pc): Delete.
4561         (alpha_gdbarch_init): Don't register deleted functions with
4562         gdbarch.
4563
4564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4567         (aarch64_unwind_pc): Delete.
4568         (aarch64_unwind_sp): Delete.
4569         (aarch64_gdbarch_init): Don't register deleted functions with
4570         gdbarch.
4571
4572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * gdbtypes.c (type_align): Don't consider static members when
4575         computing structure alignment.
4576
4577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4580         return 0 for other types.
4581         * arch-utils.c (default_type_align): Always return 0.
4582         * gdbarch.h: Regenerate.
4583         * gdbarch.sh (type_align): Extend comment.
4584         * gdbtypes.c (type_align): Add additional comments, always call
4585         gdbarch_type_align before applying the default rules.
4586         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4587         generic code will then apply a suitable default.
4588         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4589         types, return 0 for other types.
4590
4591 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4592
4593         * NEWS: Create a new section for the next release branch.
4594         Rename the section of the current branch, now that it has
4595         been cut.
4596
4597 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4598
4599         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4600         * version.in: Bump version to 8.3.50.DATE-git.
4601
4602 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4603
4604         * aix-thread.c (ptid_cmp): Remove unused variable.
4605         (get_signaled_thread): Likewise.
4606         (store_regs_user_thread): Likewise.
4607         (store_regs_kernel_thread): Likewise.
4608         (fetch_regs_kernel_thread): Remove shadowed variable.
4609
4610 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4611
4612         * features/riscv/32bit-cpu.xml: Add register numbers.
4613         * features/riscv/32bit-fpu.c: Regenerate.
4614         * features/riscv/32bit-fpu.xml: Add register numbers.
4615         * features/riscv/64bit-cpu.xml: Add register numbers.
4616         * features/riscv/64bit-fpu.c: Regenerate.
4617         * features/riscv/64bit-fpu.xml: Add register numbers.
4618
4619 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4620
4621         * NEWS: Mention two argument form of gdb.Value constructor.
4622         * python/py-value.c (convert_buffer_and_type_to_value): New
4623         function.
4624         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4625         Add support for handling an optional second argument.  Call
4626         convert_buffer_and_type_to_value as appropriate.
4627         * python/python-internal.h (Py_buffer_deleter): New struct.
4628         (Py_buffer_up): New typedef.
4629
4630 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4631
4632         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4633         instead of releasing ownership.
4634
4635 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4636
4637         * dwarf2read.c (open_and_init_dwp_file): Call
4638         elf_numsections instead of bfd_count_sections to initialize
4639         dwp_file->num_sections.
4640
4641 2019-02-25  Tom Tromey  <tromey@adacore.com>
4642
4643         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4644
4645 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4646
4647         * gcore.in: Add '--readnever' option when invoking GDB.
4648
4649 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4650
4651         * MAINTAINERS: Update my email address.
4652
4653 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4654
4655         * build-id.c (build_id_to_debug_bfd_1): New function.
4656         (build_id_to_debug_bfd): Look for separate debug file in
4657         sysroot.
4658
4659 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * gdbarch.sh: Update the copyright year range that is placed into
4662         generated files.
4663
4664 2019-02-22  Keith Seitz  <keiths@redhat.com>
4665
4666         PR symtab/23853
4667         * linespec.c (create_sals_line_offset): Search for the default
4668         symtab's filename instead of its fullname.
4669
4670 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4671
4672         * NEWS: Update style defaults.
4673
4674 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4675
4676         * main.c (captured_main_1): Disable styling in batch mode.
4677
4678 2019-02-20  Tom Tromey  <tom@tromey.com>
4679
4680         * symtab.c (symtab_symbol_info): Fix typos.
4681
4682 2019-02-20  Tom Tromey  <tromey@adacore.com>
4683
4684         * findcmd.c (_initialize_mem_search): Use upper case for
4685         metasyntactic variables.
4686
4687 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4688
4689         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4690         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4691
4692 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4693
4694         * top.h (source_file_name): Change to std::string.
4695         * top.c (source_file_name): Likewise.
4696         (command_line_input): Adjust.
4697         * cli/cli-script.c (script_from_file): Adjust.
4698
4699 2019-02-19  Tom Tromey  <tromey@adacore.com>
4700
4701         * ravenscar-thread.c
4702         (ravenscar_thread_target::update_thread_list): Don't call
4703         ada_build_task_list.
4704         * ada-lang.h (ada_build_task_list): Don't declare.
4705         * ada-tasks.c (struct ada_tasks_inferior_data)
4706         <task_list_valid_p>: Now bool.
4707         (read_known_tasks, ada_task_list_changed)
4708         (ada_tasks_invalidate_inferior_data): Update.
4709         (read_known_tasks_array): Return bool.
4710         (read_known_tasks_list): Likewise.
4711         (read_known_tasks): Return void.
4712         (ada_build_task_list): Now static.
4713
4714 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4717         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4718
4719 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4720
4721         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4722         variant for ada_tasks_pspace_data_handle and
4723         ada_tasks_inferior_data_handle.
4724         (ada_tasks_pspace_data_cleanup): New function.
4725         (ada_tasks_inferior_data_cleanup): New function.
4726
4727 2019-02-17  Tom Tromey  <tom@tromey.com>
4728
4729         * macrotab.h (macro_source_fullname): Return a std::string.
4730         * macrotab.c (macro_include, check_for_redefinition)
4731         (macro_undef, macro_lookup_definition, foreach_macro)
4732         (foreach_macro_in_scope): Update.
4733         (macro_source_fullname): Return a std::string.
4734         * macrocmd.c (show_pp_source_pos): Update.
4735
4736 2019-02-17  Tom Tromey  <tom@tromey.com>
4737
4738         * macrocmd.c (show_pp_source_pos): Style the file names.
4739
4740 2019-02-17  Tom Tromey  <tom@tromey.com>
4741
4742         PR tui/24197:
4743         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4744
4745 2019-02-17  Tom Tromey  <tom@tromey.com>
4746
4747         * ada-lang.c (user_select_syms): Use filtered printing.
4748         * utils.c (wrap_style): New global.
4749         (desired_style): Remove.
4750         (emit_style_escape): Add stream parameter.
4751         (set_output_style, reset_terminal_style, prompt_for_continue):
4752         Update.
4753         (flush_wrap_buffer): Only flush gdb_stdout.
4754         (wrap_here): Set wrap_style.
4755         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4756         treat escape sequences as a character.  Change when wrap buffer is
4757         flushed.
4758         (fputs_styled): Do not set the output style when the default is
4759         requested.
4760         * ui-style.h (struct ui_file_style) <is_default>: New method.
4761         * source.c (print_source_lines_base): Emit escape sequences in one
4762         piece.
4763
4764 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4765
4766         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4767         integers and enumeration types.
4768
4769 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4770
4771         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4772         instead of lookup_symbol_in_language
4773         (do_exact_match): New function.
4774         (ada_get_symbol_name_matcher): Return do_exact_match when
4775         doing a verbatim match.
4776
4777 2019-02-15  Tom Tromey  <tromey@adacore.com>
4778
4779         * ravenscar-thread.c (ravenscar_thread_target::resume)
4780         (ravenscar_thread_target::wait): Special case wildcard requests.
4781
4782 2019-02-15  Tom Tromey  <tromey@adacore.com>
4783
4784         * ravenscar-thread.c (base_ptid): Remove.
4785         (struct ravenscar_thread_target) <close>: New method.
4786         <m_base_ptid>: New member.
4787         <update_inferior_ptid, active_task, task_is_currently_active,
4788         runtime_initialized>: Declare methods.
4789         <ravenscar_thread_target>: Add constructor.
4790         (ravenscar_thread_target::task_is_currently_active)
4791         (ravenscar_thread_target::update_inferior_ptid)
4792         (ravenscar_runtime_initialized): Rename.  Now methods.
4793         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4794         (ravenscar_thread_target::update_thread_list): Update.
4795         (ravenscar_thread_target::active_task): Now method.
4796         (ravenscar_thread_target::store_registers)
4797         (ravenscar_thread_target::prepare_to_store)
4798         (ravenscar_thread_target::prepare_to_store)
4799         (ravenscar_thread_target::mourn_inferior): Update.
4800         (ravenscar_inferior_created): Use "new" to create target.
4801         (ravenscar_thread_target::get_ada_task_ptid): Update.
4802         (_initialize_ravenscar): Don't initialize base_ptid.
4803         (ravenscar_ops): Remove global.
4804
4805 2019-02-15  Tom Tromey  <tromey@adacore.com>
4806
4807         * target.h (push_target): Declare new overload.
4808         * target.c (push_target): New overload, taking an rvalue reference.
4809         * remote.c (remote_target::open_1): Use push_target overload.
4810         * corelow.c (core_target_open): Use push_target overload.
4811
4812 2019-02-15  Tom Tromey  <tromey@adacore.com>
4813
4814         * ravenscar-thread.c (is_ravenscar_task)
4815         (ravenscar_task_is_currently_active): Return bool.
4816         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4817         (_initialize_ravenscar): Remove "(void)".
4818         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4819         Return bool.
4820
4821 2019-02-15  Tom Tromey  <tromey@adacore.com>
4822
4823         * ravenscar-thread.c (ravenscar_runtime_initializer)
4824         (has_ravenscar_runtime, get_running_thread_id)
4825         (ravenscar_thread_target::resume): Fix indentation.
4826
4827 2019-02-15  Tom Tromey  <tromey@adacore.com>
4828
4829         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4830         from ravenscar_arch_ops.
4831         (sparc_ravenscar_ops::fetch_registers)
4832         (sparc_ravenscar_ops::store_registers): Now methods.
4833         (sparc_ravenscar_prepare_to_store): Remove.
4834         (sparc_ravenscar_ops): Redefine.
4835         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4836         methods and destructor.  Remove members.
4837         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4838         (ravenscar_thread_target::store_registers)
4839         (ravenscar_thread_target::prepare_to_store): Update.
4840         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4841         Remove.
4842         (struct ppc_ravenscar_powerpc_ops): Derive from
4843         ravenscar_arch_ops.
4844         (ppc_ravenscar_powerpc_ops::fetch_registers)
4845         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4846         (ppc_ravenscar_powerpc_ops): Redefine.
4847         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4848         (ppc_ravenscar_e500_ops::fetch_registers)
4849         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4850         (ppc_ravenscar_e500_ops): Redefine.
4851         * aarch64-ravenscar-thread.c
4852         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4853         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4854         (aarch64_ravenscar_fetch_registers)
4855         (aarch64_ravenscar_store_registers): Now methods.
4856         (aarch64_ravenscar_ops): Redefine.
4857
4858 2019-02-15  Tom Tromey  <tromey@adacore.com>
4859
4860         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4861         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4862         (ravenscar_thread_target::stopped_by_watchpoint)
4863         (ravenscar_thread_target::stopped_data_address)
4864         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4865
4866 2019-02-15  Tom Tromey  <tromey@adacore.com>
4867
4868         * ravenscar-thread.c: Fix some typos.
4869
4870 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4871             Tom Tromey  <tromey@adacore.com>
4872
4873         * ada-lang.c (ada_exception_sal): Change addr_string to a
4874         std::string.
4875         (create_ada_exception_catchpoint): Update.
4876
4877 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4878             Tom Tromey  <tromey@adacore.com>
4879
4880         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4881         (bp_location_ops): Remove.
4882         (base_breakpoint_allocate_location): Update.
4883         (free_bp_location): Update.
4884         * ada-lang.c (class ada_catchpoint_location)
4885         <ada_catchpoint_location>: Remove ops parameter.
4886         (ada_catchpoint_location_dtor): Remove.
4887         (ada_catchpoint_location_ops): Remove.
4888         (allocate_location_exception): Update.
4889         * breakpoint.h (struct bp_location_ops): Remove.
4890         (class bp_location) <bp_location>: Remove bp_location_ops
4891         parameter.
4892         <~bp_location>: Add destructor.
4893         <ops>: Remove.
4894
4895 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4896             Pedro Alves  <palves@redhat.com>
4897
4898         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4899         'PATH_MAX'.
4900
4901 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4902             Samuel Thibault  <samuel.thibault@gnu.org>
4903             Thomas Schwinge  <thomas@codesourcery.com>
4904
4905         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4906         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4907
4908 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4909
4910         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4911         (check_empty): Use "const char *".
4912
4913         * gnu-nat.c (gnu_nat_target::detach): Instead of
4914         'detach_inferior (pid)' call
4915         'detach_inferior (find_inferior_pid (pid))'.
4916
4917         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4918         'nat/fork-inferior.o'.
4919         * gnu-nat.c: #include "nat/fork-inferior.h".
4920
4921         * gnu-nat.c (gnu_nat_target::detach): Instead of
4922         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4923         * gnu-nat.h: #include "inf-child.h".
4924         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4925         'i386_gnu_nat_target::fetch_registers'.
4926         (gnu_store_registers): Rename/move to
4927         'i386_gnu_nat_target::store_registers'.
4928
4929         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4930         * gnu-nat.h (mach_thread_info): New function.
4931         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4932
4933         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4934
4935 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4936
4937         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4938
4939 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4940
4941         * windows-nat.c (windows_add_thread): Add new parameter
4942         "main_thread_p" with default value set to false.  Update
4943         function documentation as well as all callers.
4944         (windows_delete_thread): Likewise.
4945         (fake_create_process): Update call to windows_add_thread.
4946         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4947         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4948         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4949         call to windows_delete_thread.
4950
4951 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4952
4953         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4954
4955 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4956
4957         * symfile.c (find_separate_debug_file): Use canonical path of
4958         sysroot with child_path instead of gdb_sysroot if it is valid.
4959
4960 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4961
4962         * symfile.c (find_separate_debug_file): Use child_path to
4963         determine if an object file is under a sysroot.
4964
4965 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4966
4967         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4968         unittests/child-path-selftests.c.
4969         * common/pathstuff.c (child_path): New function.
4970         * common/pathstuff.h (child_path): New prototype.
4971         * unittests/child-path-selftests.c: New file.
4972
4973 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4974
4975         * symfile.c (find_separate_debug_file): Look for separate debug
4976         files in debug directories under the sysroot.
4977
4978 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4979
4980         * symtab.h (struct minimal_symbol data_p): New const method.
4981         (struct minimal_symbol text_p): Likewise.
4982         * symtab.c (output_source_filename): Use file name style
4983         to print file name.
4984         (print_symbol_info): Likewise.
4985         (print_msymbol_info): Use address style to print addresses.
4986         Use function name style to print executable text symbols.
4987         (expand_symtab_containing_pc): Use data_p.
4988         (find_pc_sect_compunit_symtab): Likewise.
4989
4990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4991
4992         * breakpoint.c (describe_other_breakpoints): Use address style
4993         to print addresses.
4994         (say_where): Likewise.
4995
4996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4997
4998         * ada-typeprint.c (print_func_type): Print function name
4999         style to print function name.
5000         * c-typeprint.c (c_print_type_1): Likewise.
5001
5002 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5003
5004         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5005         for execve.
5006
5007 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5008
5009         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5010         type_stack.
5011
5012 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5013
5014         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5015         TYPE_CODE_REF types.
5016
5017 2019-02-08  Jim Wilson  <jimw@sifive.com>
5018
5019         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5020         (riscv_linux_fregset): New.
5021         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5022
5023 2019-02-07  Tom Tromey  <tom@tromey.com>
5024
5025         * thread.c (thread_cancel_execution_command): Update.
5026         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5027         methods.
5028         (struct thread_fsm_ops): Remove.
5029         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5030         (thread_fsm_should_stop, thread_fsm_return_value)
5031         (thread_fsm_set_finished, thread_fsm_finished_p)
5032         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5033         Don't declare.
5034         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5035         * infrun.c (clear_proceed_status_thread)
5036         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5037         (print_stop_event): Update.
5038         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5039         Add constructor.
5040         (step_command_fsm_ops): Remove.
5041         (new_step_command_fsm): Remove.
5042         (step_1): Update.
5043         (step_command_fsm::should_stop): Rename from
5044         step_command_fsm_should_stop.
5045         (step_command_fsm::clean_up): Rename from
5046         step_command_fsm_clean_up.
5047         (step_command_fsm::do_async_reply_reason): Rename from
5048         step_command_fsm_async_reply_reason.
5049         (struct until_next_fsm): Inherit from thread_fsm.  Add
5050         constructor.
5051         (until_next_fsm_ops): Remove.
5052         (new_until_next_fsm): Remove.
5053         (until_next_fsm::should_stop): Rename from
5054         until_next_fsm_should_stop.
5055         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5056         (until_next_fsm::do_async_reply_reason): Rename from
5057         until_next_fsm_async_reply_reason.
5058         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5059         constructor.  Change type of breakpoint.
5060         (finish_command_fsm_ops): Remove.
5061         (new_finish_command_fsm): Remove.
5062         (finish_command_fsm::should_stop): Rename from
5063         finish_command_fsm_should_stop.
5064         (finish_command_fsm::clean_up): Rename from
5065         finish_command_fsm_clean_up.
5066         (finish_command_fsm::return_value): Rename from
5067         finish_command_fsm_return_value.
5068         (finish_command_fsm::do_async_reply_reason): Rename from
5069         finish_command_fsm_async_reply_reason.
5070         (finish_command): Update.
5071         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5072         Add constructor.
5073         (call_thread_fsm_ops): Remove.
5074         (call_thread_fsm::call_thread_fsm): Rename from
5075         new_call_thread_fsm.
5076         (call_thread_fsm::should_stop): Rename from
5077         call_thread_fsm_should_stop.
5078         (call_thread_fsm::should_notify_stop): Rename from
5079         call_thread_fsm_should_notify_stop.
5080         (run_inferior_call, call_function_by_hand_dummy): Update.
5081         * cli/cli-interp.c (should_print_stop_to_console): Update.
5082         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5083         Add constructor.  Change type of location_breakpoint,
5084         caller_breakpoint.
5085         (until_break_fsm_ops): Remove.
5086         (new_until_break_fsm): Remove.
5087         (until_break_fsm::should_stop): Rename from
5088         until_break_fsm_should_stop.
5089         (until_break_fsm::clean_up): Rename from
5090         until_break_fsm_clean_up.
5091         (until_break_fsm::do_async_reply_reason): Rename from
5092         until_break_fsm_async_reply_reason.
5093         (until_break_command): Update.
5094         * thread-fsm.c: Remove.
5095         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5096
5097 2019-02-07  Tom Tromey  <tom@tromey.com>
5098
5099         * yy-remap.h: Add include guard.
5100         * xtensa-tdep.h: Add include guard.
5101         * xcoffread.h: Rename include guard.
5102         * varobj-iter.h: Add include guard.
5103         * tui/tui.h: Rename include guard.
5104         * tui/tui-winsource.h: Rename include guard.
5105         * tui/tui-wingeneral.h: Rename include guard.
5106         * tui/tui-windata.h: Rename include guard.
5107         * tui/tui-win.h: Rename include guard.
5108         * tui/tui-stack.h: Rename include guard.
5109         * tui/tui-source.h: Rename include guard.
5110         * tui/tui-regs.h: Rename include guard.
5111         * tui/tui-out.h: Rename include guard.
5112         * tui/tui-layout.h: Rename include guard.
5113         * tui/tui-io.h: Rename include guard.
5114         * tui/tui-hooks.h: Rename include guard.
5115         * tui/tui-file.h: Rename include guard.
5116         * tui/tui-disasm.h: Rename include guard.
5117         * tui/tui-data.h: Rename include guard.
5118         * tui/tui-command.h: Rename include guard.
5119         * tic6x-tdep.h: Add include guard.
5120         * target/waitstatus.h: Rename include guard.
5121         * target/wait.h: Rename include guard.
5122         * target/target.h: Rename include guard.
5123         * target/resume.h: Rename include guard.
5124         * target-float.h: Rename include guard.
5125         * stabsread.h: Add include guard.
5126         * rs6000-tdep.h: Add include guard.
5127         * riscv-fbsd-tdep.h: Add include guard.
5128         * regformats/regdef.h: Rename include guard.
5129         * record.h: Rename include guard.
5130         * python/python.h: Rename include guard.
5131         * python/python-internal.h: Rename include guard.
5132         * python/py-stopevent.h: Rename include guard.
5133         * python/py-ref.h: Rename include guard.
5134         * python/py-record.h: Rename include guard.
5135         * python/py-record-full.h: Rename include guard.
5136         * python/py-record-btrace.h: Rename include guard.
5137         * python/py-instruction.h: Rename include guard.
5138         * python/py-events.h: Rename include guard.
5139         * python/py-event.h: Rename include guard.
5140         * procfs.h: Add include guard.
5141         * proc-utils.h: Add include guard.
5142         * p-lang.h: Add include guard.
5143         * or1k-tdep.h: Rename include guard.
5144         * observable.h: Rename include guard.
5145         * nto-tdep.h: Rename include guard.
5146         * nat/x86-linux.h: Rename include guard.
5147         * nat/x86-linux-dregs.h: Rename include guard.
5148         * nat/x86-gcc-cpuid.h: Add include guard.
5149         * nat/x86-dregs.h: Rename include guard.
5150         * nat/x86-cpuid.h: Rename include guard.
5151         * nat/ppc-linux.h: Rename include guard.
5152         * nat/mips-linux-watch.h: Rename include guard.
5153         * nat/linux-waitpid.h: Rename include guard.
5154         * nat/linux-ptrace.h: Rename include guard.
5155         * nat/linux-procfs.h: Rename include guard.
5156         * nat/linux-osdata.h: Rename include guard.
5157         * nat/linux-nat.h: Rename include guard.
5158         * nat/linux-namespaces.h: Rename include guard.
5159         * nat/linux-btrace.h: Rename include guard.
5160         * nat/glibc_thread_db.h: Rename include guard.
5161         * nat/gdb_thread_db.h: Rename include guard.
5162         * nat/gdb_ptrace.h: Rename include guard.
5163         * nat/fork-inferior.h: Rename include guard.
5164         * nat/amd64-linux-siginfo.h: Rename include guard.
5165         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5166         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5167         * nat/aarch64-linux.h: Rename include guard.
5168         * nat/aarch64-linux-hw-point.h: Rename include guard.
5169         * mn10300-tdep.h: Add include guard.
5170         * mips-linux-tdep.h: Add include guard.
5171         * mi/mi-parse.h: Rename include guard.
5172         * mi/mi-out.h: Rename include guard.
5173         * mi/mi-main.h: Rename include guard.
5174         * mi/mi-interp.h: Rename include guard.
5175         * mi/mi-getopt.h: Rename include guard.
5176         * mi/mi-console.h: Rename include guard.
5177         * mi/mi-common.h: Rename include guard.
5178         * mi/mi-cmds.h: Rename include guard.
5179         * mi/mi-cmd-break.h: Rename include guard.
5180         * m2-lang.h: Add include guard.
5181         * location.h: Rename include guard.
5182         * linux-record.h: Rename include guard.
5183         * linux-nat.h: Add include guard.
5184         * linux-fork.h: Add include guard.
5185         * i386-darwin-tdep.h: Rename include guard.
5186         * hppa-linux-offsets.h: Add include guard.
5187         * guile/guile.h: Rename include guard.
5188         * guile/guile-internal.h: Rename include guard.
5189         * gnu-nat.h: Rename include guard.
5190         * gdb-stabs.h: Rename include guard.
5191         * frv-tdep.h: Add include guard.
5192         * f-lang.h: Add include guard.
5193         * event-loop.h: Add include guard.
5194         * darwin-nat.h: Rename include guard.
5195         * cp-abi.h: Rename include guard.
5196         * config/sparc/nm-sol2.h: Rename include guard.
5197         * config/nm-nto.h: Rename include guard.
5198         * config/nm-linux.h: Add include guard.
5199         * config/i386/nm-i386gnu.h: Rename include guard.
5200         * config/djgpp/nl_types.h: Rename include guard.
5201         * config/djgpp/langinfo.h: Rename include guard.
5202         * compile/gcc-cp-plugin.h: Add include guard.
5203         * compile/gcc-c-plugin.h: Add include guard.
5204         * compile/compile.h: Rename include guard.
5205         * compile/compile-object-run.h: Rename include guard.
5206         * compile/compile-object-load.h: Rename include guard.
5207         * compile/compile-internal.h: Rename include guard.
5208         * compile/compile-cplus.h: Rename include guard.
5209         * compile/compile-c.h: Rename include guard.
5210         * common/xml-utils.h: Rename include guard.
5211         * common/x86-xstate.h: Rename include guard.
5212         * common/version.h: Rename include guard.
5213         * common/vec.h: Rename include guard.
5214         * common/tdesc.h: Rename include guard.
5215         * common/selftest.h: Rename include guard.
5216         * common/scoped_restore.h: Rename include guard.
5217         * common/scoped_mmap.h: Rename include guard.
5218         * common/scoped_fd.h: Rename include guard.
5219         * common/safe-iterator.h: Rename include guard.
5220         * common/run-time-clock.h: Rename include guard.
5221         * common/refcounted-object.h: Rename include guard.
5222         * common/queue.h: Rename include guard.
5223         * common/ptid.h: Rename include guard.
5224         * common/print-utils.h: Rename include guard.
5225         * common/preprocessor.h: Rename include guard.
5226         * common/pathstuff.h: Rename include guard.
5227         * common/observable.h: Rename include guard.
5228         * common/netstuff.h: Rename include guard.
5229         * common/job-control.h: Rename include guard.
5230         * common/host-defs.h: Rename include guard.
5231         * common/gdb_wait.h: Rename include guard.
5232         * common/gdb_vecs.h: Rename include guard.
5233         * common/gdb_unlinker.h: Rename include guard.
5234         * common/gdb_unique_ptr.h: Rename include guard.
5235         * common/gdb_tilde_expand.h: Rename include guard.
5236         * common/gdb_sys_time.h: Rename include guard.
5237         * common/gdb_string_view.h: Rename include guard.
5238         * common/gdb_splay_tree.h: Rename include guard.
5239         * common/gdb_setjmp.h: Rename include guard.
5240         * common/gdb_ref_ptr.h: Rename include guard.
5241         * common/gdb_optional.h: Rename include guard.
5242         * common/gdb_locale.h: Rename include guard.
5243         * common/gdb_assert.h: Rename include guard.
5244         * common/filtered-iterator.h: Rename include guard.
5245         * common/filestuff.h: Rename include guard.
5246         * common/fileio.h: Rename include guard.
5247         * common/environ.h: Rename include guard.
5248         * common/common-utils.h: Rename include guard.
5249         * common/common-types.h: Rename include guard.
5250         * common/common-regcache.h: Rename include guard.
5251         * common/common-inferior.h: Rename include guard.
5252         * common/common-gdbthread.h: Rename include guard.
5253         * common/common-exceptions.h: Rename include guard.
5254         * common/common-defs.h: Rename include guard.
5255         * common/common-debug.h: Rename include guard.
5256         * common/cleanups.h: Rename include guard.
5257         * common/buffer.h: Rename include guard.
5258         * common/btrace-common.h: Rename include guard.
5259         * common/break-common.h: Rename include guard.
5260         * cli/cli-utils.h: Rename include guard.
5261         * cli/cli-style.h: Rename include guard.
5262         * cli/cli-setshow.h: Rename include guard.
5263         * cli/cli-script.h: Rename include guard.
5264         * cli/cli-interp.h: Rename include guard.
5265         * cli/cli-decode.h: Rename include guard.
5266         * cli/cli-cmds.h: Rename include guard.
5267         * charset-list.h: Add include guard.
5268         * buildsym-legacy.h: Rename include guard.
5269         * bfin-tdep.h: Add include guard.
5270         * ax.h: Rename include guard.
5271         * arm-linux-tdep.h: Add include guard.
5272         * arm-fbsd-tdep.h: Add include guard.
5273         * arch/xtensa.h: Rename include guard.
5274         * arch/tic6x.h: Add include guard.
5275         * arch/i386.h: Add include guard.
5276         * arch/arm.h: Rename include guard.
5277         * arch/arm-linux.h: Rename include guard.
5278         * arch/arm-get-next-pcs.h: Rename include guard.
5279         * arch/amd64.h: Add include guard.
5280         * arch/aarch64-insn.h: Rename include guard.
5281         * arch-utils.h: Rename include guard.
5282         * annotate.h: Add include guard.
5283         * amd64-darwin-tdep.h: Rename include guard.
5284         * aarch64-linux-tdep.h: Add include guard.
5285         * aarch64-fbsd-tdep.h: Add include guard.
5286         * aarch32-linux-nat.h: Add include guard.
5287
5288 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5289
5290         * macrotab.c (macro_define_internal): New function that
5291         factorizes macro_define_object_internal and macro_define_function
5292         code.
5293         (macro_define_object_internal): Use macro_define_internal.
5294         (macro_define_function): Likewise.
5295
5296 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5297
5298         * macrocmd.c (extract_identifier): Return
5299         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5300         callers.
5301
5302 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5303
5304         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5305
5306 2019-02-05  Tom Tromey  <tom@tromey.com>
5307
5308         * target.c (target_stack::unpush): Move assertion earlier.
5309
5310 2019-01-30  Tom Tromey  <tom@tromey.com>
5311
5312         PR python/23615:
5313         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5314         (gdbpy_parse_and_eval): Likewise.
5315         * python/python-internal.h (gdbpy_allow_threads): New class.
5316
5317 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5318
5319         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5320         (aarch64_fbsd_fpregmap): Move earlier.
5321         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5322         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5323         instead of individual calls to trad_frame_set_reg_addr.
5324         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5325         earlier.
5326         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5327         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5328         instead of individual calls to trad_frame_set_reg_addr.
5329
5330 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5331
5332         * CONTRIBUTE: Replace contribution list with wiki link.
5333
5334 2019-01-25  Tom Tromey  <tom@tromey.com>
5335
5336         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5337
5338 2019-01-25  Tom Tromey  <tom@tromey.com>
5339
5340         * xtensa-linux-nat.c: Fix common/ includes.
5341         * xml-support.h: Fix common/ includes.
5342         * xml-support.c: Fix common/ includes.
5343         * x86-linux-nat.c: Fix common/ includes.
5344         * windows-nat.c: Fix common/ includes.
5345         * varobj.h: Fix common/ includes.
5346         * varobj.c: Fix common/ includes.
5347         * value.c: Fix common/ includes.
5348         * valops.c: Fix common/ includes.
5349         * utils.c: Fix common/ includes.
5350         * unittests/xml-utils-selftests.c: Fix common/ includes.
5351         * unittests/utils-selftests.c: Fix common/ includes.
5352         * unittests/unpack-selftests.c: Fix common/ includes.
5353         * unittests/tracepoint-selftests.c: Fix common/ includes.
5354         * unittests/style-selftests.c: Fix common/ includes.
5355         * unittests/string_view-selftests.c: Fix common/ includes.
5356         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5357         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5358         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5359         * unittests/rsp-low-selftests.c: Fix common/ includes.
5360         * unittests/parse-connection-spec-selftests.c: Fix common/
5361         includes.
5362         * unittests/optional-selftests.c: Fix common/ includes.
5363         * unittests/offset-type-selftests.c: Fix common/ includes.
5364         * unittests/observable-selftests.c: Fix common/ includes.
5365         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5366         * unittests/memrange-selftests.c: Fix common/ includes.
5367         * unittests/memory-map-selftests.c: Fix common/ includes.
5368         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5369         * unittests/function-view-selftests.c: Fix common/ includes.
5370         * unittests/environ-selftests.c: Fix common/ includes.
5371         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5372         * unittests/common-utils-selftests.c: Fix common/ includes.
5373         * unittests/cli-utils-selftests.c: Fix common/ includes.
5374         * unittests/array-view-selftests.c: Fix common/ includes.
5375         * ui-file.c: Fix common/ includes.
5376         * tui/tui-io.c: Fix common/ includes.
5377         * tracepoint.h: Fix common/ includes.
5378         * tracepoint.c: Fix common/ includes.
5379         * tracefile-tfile.c: Fix common/ includes.
5380         * top.h: Fix common/ includes.
5381         * top.c: Fix common/ includes.
5382         * thread.c: Fix common/ includes.
5383         * target/waitstatus.h: Fix common/ includes.
5384         * target/waitstatus.c: Fix common/ includes.
5385         * target.h: Fix common/ includes.
5386         * target.c: Fix common/ includes.
5387         * target-memory.c: Fix common/ includes.
5388         * target-descriptions.c: Fix common/ includes.
5389         * symtab.h: Fix common/ includes.
5390         * symfile.c: Fix common/ includes.
5391         * stap-probe.c: Fix common/ includes.
5392         * spu-linux-nat.c: Fix common/ includes.
5393         * sparc-nat.c: Fix common/ includes.
5394         * source.c: Fix common/ includes.
5395         * solib.c: Fix common/ includes.
5396         * solib-target.c: Fix common/ includes.
5397         * ser-unix.c: Fix common/ includes.
5398         * ser-tcp.c: Fix common/ includes.
5399         * ser-pipe.c: Fix common/ includes.
5400         * ser-base.c: Fix common/ includes.
5401         * selftest-arch.c: Fix common/ includes.
5402         * s12z-tdep.c: Fix common/ includes.
5403         * rust-exp.y: Fix common/ includes.
5404         * rs6000-aix-tdep.c: Fix common/ includes.
5405         * riscv-tdep.c: Fix common/ includes.
5406         * remote.c: Fix common/ includes.
5407         * remote-notif.h: Fix common/ includes.
5408         * remote-fileio.h: Fix common/ includes.
5409         * remote-fileio.c: Fix common/ includes.
5410         * regcache.h: Fix common/ includes.
5411         * regcache.c: Fix common/ includes.
5412         * record-btrace.c: Fix common/ includes.
5413         * python/python.c: Fix common/ includes.
5414         * python/py-type.c: Fix common/ includes.
5415         * python/py-inferior.c: Fix common/ includes.
5416         * progspace.h: Fix common/ includes.
5417         * producer.c: Fix common/ includes.
5418         * procfs.c: Fix common/ includes.
5419         * proc-api.c: Fix common/ includes.
5420         * printcmd.c: Fix common/ includes.
5421         * ppc-linux-nat.c: Fix common/ includes.
5422         * parser-defs.h: Fix common/ includes.
5423         * osdata.c: Fix common/ includes.
5424         * obsd-nat.c: Fix common/ includes.
5425         * nat/x86-linux.c: Fix common/ includes.
5426         * nat/x86-linux-dregs.c: Fix common/ includes.
5427         * nat/x86-dregs.h: Fix common/ includes.
5428         * nat/x86-dregs.c: Fix common/ includes.
5429         * nat/ppc-linux.c: Fix common/ includes.
5430         * nat/mips-linux-watch.h: Fix common/ includes.
5431         * nat/mips-linux-watch.c: Fix common/ includes.
5432         * nat/linux-waitpid.c: Fix common/ includes.
5433         * nat/linux-ptrace.h: Fix common/ includes.
5434         * nat/linux-ptrace.c: Fix common/ includes.
5435         * nat/linux-procfs.c: Fix common/ includes.
5436         * nat/linux-personality.c: Fix common/ includes.
5437         * nat/linux-osdata.c: Fix common/ includes.
5438         * nat/linux-namespaces.c: Fix common/ includes.
5439         * nat/linux-btrace.h: Fix common/ includes.
5440         * nat/linux-btrace.c: Fix common/ includes.
5441         * nat/fork-inferior.c: Fix common/ includes.
5442         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5443         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5444         * nat/aarch64-linux.c: Fix common/ includes.
5445         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5446         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5447         * namespace.h: Fix common/ includes.
5448         * mips-linux-tdep.c: Fix common/ includes.
5449         * minsyms.c: Fix common/ includes.
5450         * mi/mi-parse.h: Fix common/ includes.
5451         * mi/mi-main.c: Fix common/ includes.
5452         * mi/mi-cmd-env.c: Fix common/ includes.
5453         * memrange.h: Fix common/ includes.
5454         * memattr.c: Fix common/ includes.
5455         * maint.h: Fix common/ includes.
5456         * maint.c: Fix common/ includes.
5457         * main.c: Fix common/ includes.
5458         * machoread.c: Fix common/ includes.
5459         * location.c: Fix common/ includes.
5460         * linux-thread-db.c: Fix common/ includes.
5461         * linux-nat.c: Fix common/ includes.
5462         * linux-fork.c: Fix common/ includes.
5463         * inline-frame.c: Fix common/ includes.
5464         * infrun.c: Fix common/ includes.
5465         * inflow.c: Fix common/ includes.
5466         * inferior.h: Fix common/ includes.
5467         * inferior.c: Fix common/ includes.
5468         * infcmd.c: Fix common/ includes.
5469         * inf-ptrace.c: Fix common/ includes.
5470         * inf-child.c: Fix common/ includes.
5471         * ia64-linux-nat.c: Fix common/ includes.
5472         * i387-tdep.c: Fix common/ includes.
5473         * i386-tdep.c: Fix common/ includes.
5474         * i386-linux-tdep.c: Fix common/ includes.
5475         * i386-linux-nat.c: Fix common/ includes.
5476         * i386-go32-tdep.c: Fix common/ includes.
5477         * i386-fbsd-tdep.c: Fix common/ includes.
5478         * i386-fbsd-nat.c: Fix common/ includes.
5479         * guile/scm-type.c: Fix common/ includes.
5480         * guile/guile.c: Fix common/ includes.
5481         * go32-nat.c: Fix common/ includes.
5482         * gnu-nat.c: Fix common/ includes.
5483         * gdbthread.h: Fix common/ includes.
5484         * gdbarch-selftests.c: Fix common/ includes.
5485         * gdb_usleep.c: Fix common/ includes.
5486         * gdb_select.h: Fix common/ includes.
5487         * gdb_bfd.c: Fix common/ includes.
5488         * gcore.c: Fix common/ includes.
5489         * fork-child.c: Fix common/ includes.
5490         * findvar.c: Fix common/ includes.
5491         * fbsd-nat.c: Fix common/ includes.
5492         * event-top.c: Fix common/ includes.
5493         * event-loop.c: Fix common/ includes.
5494         * dwarf2read.c: Fix common/ includes.
5495         * dwarf2loc.c: Fix common/ includes.
5496         * dwarf2-frame.c: Fix common/ includes.
5497         * dwarf-index-cache.c: Fix common/ includes.
5498         * dtrace-probe.c: Fix common/ includes.
5499         * disasm-selftests.c: Fix common/ includes.
5500         * defs.h: Fix common/ includes.
5501         * csky-tdep.c: Fix common/ includes.
5502         * cp-valprint.c: Fix common/ includes.
5503         * cp-support.h: Fix common/ includes.
5504         * cp-support.c: Fix common/ includes.
5505         * corelow.c: Fix common/ includes.
5506         * completer.h: Fix common/ includes.
5507         * completer.c: Fix common/ includes.
5508         * compile/compile.c: Fix common/ includes.
5509         * compile/compile-loc2c.c: Fix common/ includes.
5510         * compile/compile-cplus-types.c: Fix common/ includes.
5511         * compile/compile-cplus-symbols.c: Fix common/ includes.
5512         * command.h: Fix common/ includes.
5513         * cli/cli-dump.c: Fix common/ includes.
5514         * cli/cli-cmds.c: Fix common/ includes.
5515         * charset.c: Fix common/ includes.
5516         * build-id.c: Fix common/ includes.
5517         * btrace.h: Fix common/ includes.
5518         * btrace.c: Fix common/ includes.
5519         * breakpoint.h: Fix common/ includes.
5520         * breakpoint.c: Fix common/ includes.
5521         * ax.h:
5522         (enum agent_op): Fix common/ includes.
5523         * ax-general.c (struct aop_map): Fix common/ includes.
5524         * ax-gdb.c: Fix common/ includes.
5525         * auxv.c: Fix common/ includes.
5526         * auto-load.c: Fix common/ includes.
5527         * arm-tdep.c: Fix common/ includes.
5528         * arch/riscv.c: Fix common/ includes.
5529         * arch/ppc-linux-common.c: Fix common/ includes.
5530         * arch/i386.c: Fix common/ includes.
5531         * arch/arm.c: Fix common/ includes.
5532         * arch/arm-linux.c: Fix common/ includes.
5533         * arch/arm-get-next-pcs.c: Fix common/ includes.
5534         * arch/amd64.c: Fix common/ includes.
5535         * arch/aarch64.c: Fix common/ includes.
5536         * arch/aarch64-insn.c: Fix common/ includes.
5537         * arch-utils.c: Fix common/ includes.
5538         * amd64-windows-tdep.c: Fix common/ includes.
5539         * amd64-tdep.c: Fix common/ includes.
5540         * amd64-sol2-tdep.c: Fix common/ includes.
5541         * amd64-obsd-tdep.c: Fix common/ includes.
5542         * amd64-nbsd-tdep.c: Fix common/ includes.
5543         * amd64-linux-tdep.c: Fix common/ includes.
5544         * amd64-linux-nat.c: Fix common/ includes.
5545         * amd64-fbsd-tdep.c: Fix common/ includes.
5546         * amd64-fbsd-nat.c: Fix common/ includes.
5547         * amd64-dicos-tdep.c: Fix common/ includes.
5548         * amd64-darwin-tdep.c: Fix common/ includes.
5549         * agent.c: Fix common/ includes.
5550         * ada-lang.h: Fix common/ includes.
5551         * ada-lang.c: Fix common/ includes.
5552         * aarch64-tdep.c: Fix common/ includes.
5553
5554 2019-01-25  Tom Tromey  <tom@tromey.com>
5555
5556         * common/create-version.sh: Use common/version.h.
5557
5558 2019-01-24  Pedro Alves  <palves@redhat.com>
5559
5560         * infrun.c (signal_stop, signal_print, signal_program)
5561         (signal_catch, signal_pass): Now arrays instead of pointers.
5562         (update_signals_program_target, do_target_resume)
5563         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5564         * linux-nat.c (linux_nat_target::pass_signals)
5565         (linux_nat_target::create_inferior, linux_nat_target::attach):
5566         Adjust.
5567         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5568         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5569         * procfs.c (procfs_target::pass_signals): Adjust.
5570         * record-full.c (record_full_target::resume): Adjust.
5571         * remote.c (remote_target::pass_signals)
5572         (remote_target::program_signals): Adjust.
5573         * target-debug.h (target_debug_print_signals): Now takes a
5574         gdb::array_view as parameter.  Adjust.
5575         * target.h (target_ops) <pass_signals, program_signals>: Replace
5576         pointer and length parameters with gdb::array_view.
5577         (target_pass_signals, target_program_signals): Likewise.
5578         * target-delegates.c: Regenerate.
5579
5580 2019-01-24  Pedro Alves  <palves@redhat.com>
5581
5582         * common/forward-scope-exit.h
5583         (forward_scope_exit::forward_scope_exit): Pass arguments to
5584         m_bind_function directly, instead of creating a std::bind and
5585         copying that.
5586
5587 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5588
5589         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5590         for static members.
5591         (pass_in_v_vfp_candidate): Likewise.
5592
5593 2019-01-23  Tom Tromey  <tom@tromey.com>
5594             Pedro Alves  <palves@redhat.com>
5595
5596         * regcache.c (class regcache_invalidator): Remove.
5597         (regcache::raw_write): Use make_scope_exit.
5598
5599 2019-01-23  Tom Tromey  <tom@tromey.com>
5600
5601         * ui-out.h (class ui_out_emit_type): Update comment.
5602
5603 2019-01-23  Tom Tromey  <tom@tromey.com>
5604
5605         * infrun.c (fetch_inferior_event): Update comment.
5606
5607 2019-01-23  Tom Tromey  <tom@tromey.com>
5608             Pedro Alves  <palves@redhat.com>
5609
5610         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5611         parameter.
5612         (fetch_inferior_event): Use SCOPE_EXIT.
5613
5614
5615 2019-01-23  Tom Tromey  <tom@tromey.com>
5616             Pedro Alves  <palves@redhat.com>
5617
5618         * infrun.c (disable_thread_events): Delete.
5619         (stop_all_threads): Use SCOPE_EXIT.
5620
5621 2019-01-23  Tom Tromey  <tom@tromey.com>
5622             Pedro Alves  <palves@redhat.com>
5623
5624         * symfile.c: Include forward-scope-exit.h.
5625         (clear_symtab_users_cleanup): Replace forward declaration with
5626         a FORWARD_SCOPE_EXIT.
5627         (syms_from_objfile_1): Use the forward_scope_exit and
5628         gdb::optional instead of cleanup_function.
5629         (reread_symbols): Use the forward_scope_exit instead of
5630         cleanup_function.
5631         (clear_symtab_users_cleanup): Remove function.
5632
5633 2019-01-23  Tom Tromey  <tom@tromey.com>
5634             Pedro Alves  <palves@redhat.com>
5635
5636         * linux-nat.c: Include scope-exit.h.
5637         (cleanup_target_stop): Remove.
5638         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5639         SCOPE_EXIT.
5640
5641 2019-01-23  Tom Tromey  <tom@tromey.com>
5642             Pedro Alves  <palves@redhat.com>
5643
5644         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5645         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5646
5647 2019-01-23  Tom Tromey  <tom@tromey.com>
5648             Andrew Burgess  <andrew.burgess@embecosm.com>
5649             Pedro Alves  <palves@redhat.com>
5650
5651         * infrun.c (fetch_inferior_event): Use scope_exit.
5652         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5653         * top.c (execute_command): Use scope_exit.
5654         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5655         * utils.c (do_bpstat_clear_actions_cleanup)
5656         (make_bpstat_clear_actions_cleanup): Remove.
5657
5658 2019-01-23  Tom Tromey  <tom@tromey.com>
5659             Pedro Alves  <palves@redhat.com>
5660
5661         * infrun.c: Include "common/scope-exit.h"
5662         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5663         (wait_for_inferior): Use SCOPE_EXIT.
5664         (fetch_inferior_event): Use scope_exit.
5665
5666 2019-01-23  Tom Tromey  <tom@tromey.com>
5667             Pedro Alves  <palves@redhat.com>
5668
5669         * breakpoint.c (create_breakpoint): Remove cleanup.
5670
5671 2019-01-23  Tom Tromey  <tom@tromey.com>
5672             Andrew Burgess  <andrew.burgess@embecosm.com>
5673             Pedro Alves  <palves@redhat.com>
5674
5675 2019-01-23  Pedro Alves  <palves@redhat.com>
5676
5677         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5678
5679 2019-01-23  Pedro Alves  <palves@redhat.com>
5680             Andrew Burgess  <andrew.burgess@embecosm.com>
5681
5682         * gdbthread.h: Include "common/forward-scope-exit.h".
5683         (scoped_finish_thread_state): Redefine custom class in terms of
5684         forward_scope_exit.
5685
5686 2019-01-23  Pedro Alves  <palves@redhat.com>
5687             Andrew Burgess  <andrew.burgess@embecosm.com>
5688
5689         * common/forward-scope-exit.h: New file.
5690
5691 2019-01-23  Pedro Alves  <palves@redhat.com>
5692             Andrew Burgess  <andrew.burgess@embecosm.com>
5693             Tom Tromey  <tom@tromey.com>
5694
5695         * common/scope-exit.h: New file.
5696
5697 2019-01-23  Pedro Alves  <palves@redhat.com>
5698
5699         * common/preprocessor.h (ESC): Rename to ...
5700         (ESC_PARENS): ... this.
5701         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5702         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5703
5704 2019-01-23  Tom Tromey  <tom@tromey.com>
5705
5706         * language.h (class scoped_switch_to_sym_language_if_auto):
5707         Initialize m_lang in both cases.
5708
5709 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5710
5711         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5712         with XCNEW.
5713
5714 2019-01-22  Tom Tromey  <tom@tromey.com>
5715
5716         * corelow.c: Do not include sys/file.h.
5717
5718 2019-01-22  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-wingeneral.h: Include gdb_curses.h.
5721
5722 2019-01-22  Tom Tromey  <tom@tromey.com>
5723
5724         * source-cache.h (class source_cache) <get_source_lines,
5725         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5726
5727 2019-01-22  Tom Tromey  <tom@tromey.com>
5728
5729         * remote-fileio.h (struct remote_target): Declare.
5730
5731 2019-01-22  Tom Tromey  <tom@tromey.com>
5732
5733         * python/py-arch.c: Do not include py-ref.h.
5734         * python/py-bpevent.c: Do not include py-ref.h.
5735         * python/py-cmd.c: Do not include py-ref.h.
5736         * python/py-continueevent.c: Do not include py-ref.h.
5737         * python/py-event.h: Do not include py-ref.h.
5738         * python/py-evtregistry.c: Do not include py-ref.h.
5739         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5740         * python/py-frame.c: Do not include py-ref.h.
5741         * python/py-framefilter.c: Do not include py-ref.h.
5742         * python/py-function.c: Do not include py-ref.h.
5743         * python/py-infevents.c: Do not include py-ref.h.
5744         * python/py-linetable.c: Do not include py-ref.h.
5745         * python/py-objfile.c: Do not include py-ref.h.
5746         * python/py-param.c: Do not include py-ref.h.
5747         * python/py-prettyprint.c: Do not include py-ref.h.
5748         * python/py-progspace.c: Do not include py-ref.h.
5749         * python/py-symbol.c: Do not include py-ref.h.
5750         * python/py-symtab.c: Do not include py-ref.h.
5751         * python/py-type.c: Do not include py-ref.h.
5752         * python/py-unwind.c: Do not include py-ref.h.
5753         * python/py-utils.c: Do not include py-ref.h.
5754         * python/py-value.c: Do not include py-ref.h.
5755         * python/py-varobj.c: Do not include py-ref.h.
5756         * python/py-xmethods.c: Do not include py-ref.h.
5757         * python/python.c: Do not include py-ref.h.
5758         * varobj.c: Do not include py-ref.h.
5759
5760 2019-01-22  Tom Tromey  <tom@tromey.com>
5761
5762         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5763         keyword for bcache.
5764
5765 2019-01-22  Tom Tromey  <tom@tromey.com>
5766
5767         * compile/compile-cplus-types.c: Remove a comment by #include.
5768
5769 2019-01-22  Tom Tromey  <tom@tromey.com>
5770
5771         * compile/gcc-c-plugin.h: Include compile-internal.h.
5772
5773 2019-01-22  Tom Tromey  <tom@tromey.com>
5774
5775         * stabsread.c (EXTERN): Do not define.
5776         (symnum, next_symbol_text_func, processing_gcc_compilation)
5777         (within_function, global_sym_chain, global_stabs)
5778         (previous_stab_code, this_object_header_files)
5779         (n_this_object_header_files)
5780         (n_allocated_this_object_header_files): Define.
5781         * stabsread.h (EXTERN): Never define.  Use "extern".
5782
5783 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5784
5785         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5786         history_value.
5787
5788 2019-01-21  Tom Tromey  <tom@tromey.com>
5789
5790         * ui-out.c: Fix includes.
5791         * tui/tui-source.c: Fix includes.
5792         * target.c: Fix includes.
5793         * remote.c: Fix includes.
5794         * regcache.c: Fix includes.
5795         * python/py-block.c: Fix includes.
5796         * printcmd.c: Fix includes.
5797         * or1k-tdep.c: Fix includes.
5798         * mi/mi-main.c: Fix includes.
5799         * m32r-tdep.c: Fix includes.
5800         * csky-tdep.c: Fix includes.
5801         * compile/compile-cplus-types.c: Fix includes.
5802         * cli/cli-interp.c: Fix includes.
5803
5804 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5805
5806         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5807         for padding.
5808
5809 2019-01-16  Tom Tromey  <tom@tromey.com>
5810
5811         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5812         earlier.
5813         (struct objfile) <msymbols_range>: Move from top level.
5814         <msymbols>: New method.
5815         (class objfile_msymbols): Remove.
5816         * symtab.c (default_collect_symbol_completion_matches_break_on):
5817         Update.
5818         * symmisc.c (dump_msymbols): Update.
5819         * stabsread.c (scan_file_globals): Update.
5820         * objc-lang.c (info_selectors_command, info_classes_command)
5821         (find_methods): Update.
5822         * minsyms.c (find_solib_trampoline_target): Update.
5823         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5824         * coffread.c (coff_symfile_read): Update.
5825         * ada-lang.c (ada_lookup_simple_minsym)
5826         (ada_collect_symbol_completion_matches): Update.
5827
5828 2019-01-16  Tom Tromey  <tom@tromey.com>
5829
5830         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5831         type.  Remove no-argument constructor.
5832         <iterator::operator++>: Simplify.
5833         <begin>: Update.
5834         <end>: Use minimal_symbol_count.
5835
5836 2019-01-16  Tom Tromey  <tom@tromey.com>
5837
5838         * objfiles.h (struct objfile) <psymtabs>: New method.
5839         (class objfile_psymtabs): Remove.
5840         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5841         typedef.
5842         <range>: New method.
5843         (require_partial_symbols): Change return type.
5844         * psymtab.c (require_partial_symbols)
5845         (psym_expand_symtabs_matching): Update.
5846         * mdebugread.c (parse_partial_symbols): Update.
5847         * dbxread.c (dbx_end_psymtab): Update.
5848
5849 2019-01-15  Tom Tromey  <tom@tromey.com>
5850
5851         * symtab.c (lookup_objfile_from_block)
5852         (lookup_symbol_in_objfile_symtabs)
5853         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5854         (find_line_symtab, info_sources_command)
5855         (default_collect_symbol_completion_matches_break_on)
5856         (make_source_files_completion_list): Update.
5857         * symmisc.c (print_objfile_statistics, dump_objfile)
5858         (maintenance_print_symbols, maintenance_info_symtabs)
5859         (maintenance_check_symtabs, maintenance_info_line_tables):
5860         Update.
5861         * source.c (select_source_symtab)
5862         (forget_cached_source_info_for_objfile): Update.
5863         * objfiles.h (class objfile_compunits): Remove.
5864         (struct objfile) <compunits_range>: New typedef.
5865         (compunits): New method.
5866         * objfiles.c (objfile_relocate1): Update.
5867         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5868         * maint.c (count_symtabs_and_blocks): Update.
5869         * linespec.c (iterate_over_all_matching_symtabs): Update.
5870         * cp-support.c (add_symbol_overload_list_qualified): Update.
5871         * coffread.c (coff_symtab_read): Update.
5872         * ada-lang.c (add_nonlocal_symbols)
5873         (ada_collect_symbol_completion_matches)
5874         (ada_add_global_exceptions): Update.
5875
5876 2019-01-15  Tom Tromey  <tom@tromey.com>
5877
5878         * progspace.h (program_space) <objfiles_safe_range>: New
5879         typedef.
5880         <objfiles_safe>: New method.
5881         * objfiles.h (class all_objfiles_safe): Remove.
5882         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5883         * jit.c (jit_inferior_exit_hook): Update.
5884
5885 2019-01-17  Tom Tromey  <tom@tromey.com>
5886
5887         * progspace.h (program_space) <objfiles_range>: New typedef.
5888         <objfiles>: New method.
5889         <objfiles_head>: Rename from objfiles.
5890         (object_files): Update.
5891         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5892         * guile/scm-pretty-print.c
5893         (ppscm_find_pretty_printer_from_objfiles): Update.
5894         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5895         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5896         Update.
5897         * python/py-progspace.c (pspy_get_objfiles): Update.
5898         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5899         Update.
5900         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5901         (objfpy_lookup_objfile_by_build_id): Update.
5902         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5903         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5904         Update.
5905         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5906         (expand_symtab_containing_pc, lookup_objfile_from_block)
5907         (lookup_static_symbol, basic_lookup_transparent_type)
5908         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5909         (find_line_symtab, info_sources_command)
5910         (default_collect_symbol_completion_matches_break_on)
5911         (make_source_files_completion_list, find_main_name): Update.
5912         * symmisc.c (print_symbol_bcache_statistics)
5913         (print_objfile_statistics, maintenance_print_symbols)
5914         (maintenance_print_msymbols, maintenance_print_objfiles)
5915         (maintenance_info_symtabs, maintenance_check_symtabs)
5916         (maintenance_expand_symtabs, maintenance_info_line_tables):
5917         Update.
5918         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5919         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5920         (map_overlay_command, unmap_overlay_command)
5921         (simple_overlay_update, expand_symtabs_matching)
5922         (map_symbol_filenames): Update.
5923         * symfile-debug.c (set_debug_symfile): Update.
5924         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5925         Update.
5926         * source.c (select_source_symtab, forget_cached_source_info):
5927         Update.
5928         * solib.c (solib_read_symbols): Update.
5929         * solib-spu.c (append_ocl_sos): Update.
5930         * psymtab.c (maintenance_print_psymbols)
5931         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5932         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5933         * printcmd.c (info_symbol_command): Update.
5934         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5935         Update.
5936         * objfiles.h (class all_objfiles): Remove.
5937         * objfiles.c (have_partial_symbols, have_full_symbols)
5938         (have_minimal_symbols, qsort_cmp, update_section_map)
5939         (shared_objfile_contains_address_p)
5940         (default_iterate_over_objfiles_in_search_order): Update.
5941         * objc-lang.c (info_selectors_command, info_classes_command)
5942         (find_methods): Update.
5943         * minsyms.c (find_solib_trampoline_target): Update.
5944         * maint.c (maintenance_info_sections)
5945         (maintenance_translate_address, count_symtabs_and_blocks):
5946         Update.
5947         * main.c (captured_main_1): Update.
5948         * linux-thread-db.c (try_thread_db_load_from_pdir)
5949         (has_libpthread): Update.
5950         * linespec.c (iterate_over_all_matching_symtabs)
5951         (search_minsyms_for_name): Update.
5952         * jit.c (jit_find_objf_with_entry_addr): Update.
5953         * hppa-tdep.c (find_unwind_entry)
5954         (hppa_lookup_stub_minimal_symbol): Update.
5955         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5956         Update.
5957         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5958         (elf_gnu_ifunc_resolve_by_got): Update.
5959         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5960         * dwarf-index-write.c (save_gdb_index_command): Update.
5961         * cp-support.c (add_symbol_overload_list_qualified): Update.
5962         * breakpoint.c (create_overlay_event_breakpoint)
5963         (create_longjmp_master_breakpoint)
5964         (create_std_terminate_master_breakpoint)
5965         (create_exception_master_breakpoint): Update.
5966         * blockframe.c (find_pc_partial_function): Update.
5967         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5968         (ada_collect_symbol_completion_matches)
5969         (ada_add_global_exceptions): Update.
5970
5971 2019-01-17  Tom Tromey  <tom@tromey.com>
5972
5973         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5974         declare VEC.
5975         (solib_target_parse_libraries): Change return type.
5976         (library_list_start_segment, library_list_start_section)
5977         (library_list_end_library, library_list_start_library); Update.
5978         (solib_target_free_library_list): Remove.
5979         (solib_target_parse_libraries): Remove cleanup.  Change return
5980         type.
5981         (solib_target_current_sos): Update.
5982
5983 2019-01-17  Tom Tromey  <tromey@bapiya>
5984
5985         * valprint.c: Replace "the the" with "the".
5986         * symtab.c: Replace "the the" with "the".
5987         * solib.c: Replace "the the" with "the".
5988         * solib-dsbt.c: Replace "the the" with "the".
5989         * linespec.c: Replace "the the" with "the".
5990         * dwarf2loc.h: Replace "the the" with "the".
5991         * amd64-windows-tdep.c: Replace "the the" with "the".
5992         * aarch64-tdep.c: Replace "the the" with "the".
5993
5994 2019-01-16  Keith Seitz  <keiths@redhat.com>
5995
5996         PR gdb/23773
5997         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5998         <builder>: Rename to ..
5999         <m_builder>: ... this and make private.
6000         (dwarf2_cu::get_builder): New method.  Change all users of
6001         `builder' to use this method.
6002         (dwarf2_start_symtab): Move to ...
6003         (dwarf2_cu::start_symtab): ... here.  Update all callers
6004         (setup_type_unit_groups): Move to ...
6005         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6006         callers.
6007         (dwarf2_cu::reset_builder): New method.
6008         (process_full_compunit, process_full_type_unit): Use
6009         dwarf2_cu::reset_builder.
6010         (follow_die_offset): Record the ancestor CU if it is different
6011         from the followed DIE's CU.
6012         (follow_die_sig_1): Likewise.
6013
6014 2019-01-15  Tom Tromey  <tom@tromey.com>
6015
6016         * remote.c (class remote_state) <buf>: Now a char_vector.
6017         <buf_size>: Remove.
6018         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6019         parameter.
6020         (remote_target::getpkt_or_notif_sane_1)
6021         (remote_target::getpkt_sane)
6022         (remote_target::getpkt_or_notif_sane): Likewise.
6023         (class remote_target) <putpkt>: New overload.
6024         (remote_target::read_frame): Change type of "buf_p".  Remove
6025         sizeof_p parameter.
6026         (packet_ok): New overload.
6027         (packet_check_result): New overload.
6028         Update all uses.
6029
6030 2019-01-14  Tom Tromey  <tom@tromey.com>
6031
6032         * remote-notif.c (handle_notification, remote_notif_ack)
6033         (remote_notif_parse): Make "buf" const.
6034         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6035         const.
6036         (remote_notif_parse, remote_notif_ack, handle_notification):
6037         Likewise.
6038         * remote.c (remote_notif_stop_parse): Make "buf" const.
6039         (remote_target::remote_parse_stop_reply): Make "buf" const.
6040         (remote_notif_stop_ack): Make "buf" const.
6041
6042 2019-01-14  Tom Tromey  <tom@tromey.com>
6043
6044         * remote.c (remote_console_output): Make parameter const.
6045
6046 2019-01-14  Tom Tromey  <tom@tromey.com>
6047
6048         * target-debug.h (target_debug_print_signals): Constify.
6049         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6050         * procfs.c (procfs_target::pass_signals): Update.
6051         * linux-nat.c (linux_nat_target::pass_signals): Update.
6052         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6053         * target-delegates.c: Rebuild.
6054         * remote.c (remote_target::program_signals): Update.
6055         (remote_target::pass_signals): Update.
6056         * target.c (target_pass_signals): Constify argument.
6057         (target_program_signals): Likewise.
6058         * target.h (struct target_ops) <pass_signals, program_signals>:
6059         Constify argument.
6060         (target_pass_signals, target_program_signals): Constify argument.
6061
6062 2019-01-14  Tom Tromey  <tom@tromey.com>
6063
6064         PR tui/28819:
6065         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6066
6067 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6068
6069         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6070         field.
6071         * rs6000-tdep.c: Include reggroups.h.
6072         (IS_V_ALIAS_PSEUDOREG): Define.
6073         (rs6000_register_name): Return names for the "vX" aliases.
6074         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6075         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6076         aliases.  Call default_register_reggroup_p for all other
6077         pseudo-registers.
6078         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6079         New functions.
6080         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6081         Handle "vX" aliases.
6082         (v_alias_pseudo_register_collect): New function.
6083         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6084         (rs6000_gdbarch_init): Initialize "vX" aliases as
6085         pseudo-registers.  Restore registration of
6086         rs6000_pseudo_register_reggroup_p with
6087         set_tdesc_pseudo_register_reggroup_p.
6088
6089 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6090
6091         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6092         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6093         set_gdbarch_num_pseudo_regs.
6094
6095 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6096
6097         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6098         Remove arg prefixname, add do_set and do_show.
6099         Add member functions set_list and show_list.
6100         * cli/cli-style.c (class cli_style_option): Update accordingly.
6101         (style_set_list): Move to file scope.
6102         (style_show_list): Likewise.
6103         (set_style): Call help_list.
6104         (show_style): Call cmd_show_list.
6105         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6106         Update to use the new macro.
6107
6108 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6109
6110         * ada-lang.c (_initialize_ada_language): Expand the help text
6111         for the "catch exception" command.
6112
6113 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6114
6115         * symtab.c (matching_obj_sections): Initialize obj,
6116         declare it closer to its usage.
6117
6118 2019-01-10  Tom Tromey  <tom@tromey.com>
6119
6120         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6121         (basic_inf_threads_range): Remove.
6122         (inf_threads_range, inf_non_exited_threads_range)
6123         (safe_inf_threads_range): Use next_adapter.
6124
6125 2019-01-10  Keith Seitz  <keiths@redhat.com>
6126
6127         PR gdb/23712
6128         PR symtab/23010
6129         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6130         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6131
6132 2019-01-10  Keith Seitz  <keiths@redhat.com>
6133
6134         PR gdb/23712
6135         PR symtab/23010
6136         * dictionary.c (pending_to_vector): Remove.
6137         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6138         Remove _1 suffix, replacing functions of the same name.  Update
6139         all callers.
6140         (dict_create_hashed, dict_create_hashed_expandable)
6141         (dict_create_linear, dict_create_linear_expandable, dict_free)
6142         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6143         Make functions static.
6144
6145 2019-01-10  Keith Seitz  <keiths@redhat.com>
6146
6147         PR gdb/23712
6148         PR symtab/23010
6149         * dictionary.h (struct dictionary): Replace declaration with
6150         multidictionary.
6151         (dict_create_hashed, dict_create_hashed_expandable)
6152         (dict_create_linear, dict_create_linear_expandable)
6153         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6154         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6155         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6156         taking multidictionary argument.
6157         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6158         * block.h (struct block) <dict>: Change to multidictionary
6159         and rename `multidict'.
6160         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6161         symmisc.c: Update all dictionary references to multidictionary.
6162
6163 2019-01-10  Keith Seitz  <keiths@redhat.com>
6164
6165         PR gdb/23712
6166         PR symtab/23010
6167         * dictionary.c: Include unordered_map.
6168         (pending_to_vector): New function.
6169         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6170         Rewrite the non-"_1" functions to take vector instead
6171         of linked list.
6172         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6173         "new" _1 versions of the same name.
6174         (multidictionary): Define.
6175         (std::hash<enum language): New definition.
6176         (collate_pending_symbols_by_language, mdict_create_hashed)
6177         (mdict_create_hashed_expandable, mdict_create_linear)
6178         (mdict_create_linear_expandable, mdict_free)
6179         (find_language_dictionary, create_new_language_dictionary)
6180         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6181         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6182         (mdict_size, mdict_empty): New functions.
6183         * dictionary.h (mdict_iterator): Define.
6184
6185 2019-01-10  Pedro Alves  <palves@redhat.com>
6186
6187         * breakpoint.c (read_uploaded_action)
6188         (create_tracepoint_from_upload): Adjust to use
6189         gdb::unique_xmalloc_ptr.
6190         * ctf.c (ctf_write_uploaded_tp):
6191         (SET_ARRAY_FIELD): Use emplace_back.
6192         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6193         * tracefile-tfile.c (tfile_write_uploaded_tp):
6194         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6195         gdb::unique_xmalloc_ptr.
6196         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6197         at_string, cond_string, cmd_strings>: Replace char pointers
6198         with gdb::unique_xmalloc_ptr.
6199
6200 2019-01-10  Pedro Alves  <palves@redhat.com>
6201
6202         * solib-target.c (library_list_start_library): Don't xstrdup name.
6203
6204 2019-01-10  Pedro Alves  <palves@redhat.com>
6205
6206         * mdebugread.c (parse_partial_symbols): Use
6207         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6208
6209 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6210
6211         * linux-fork.c (scoped_switch_fork_info)
6212         <~scoped_switch_fork_info>: Fix incorrect variable name.
6213
6214 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6215
6216         * linux-fork.c (scoped_switch_fork_info)
6217         <scoped_switch_fork_info>: Make explicit.
6218         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6219
6220 2019-01-10  Tom Tromey  <tom@tromey.com>
6221
6222         * objfiles.h (objfile::reset_psymtabs): Update.
6223         * objfiles.c (objfile::objfile): Update.
6224         * psymtab.h (psymtab_storage::obstack): Update.
6225         (psymtab_storage::m_obstack): Use gdb::optional.
6226         (class psymtab_storage): Update comment.  Remove objfile
6227         parameter.
6228         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6229
6230 2019-01-10  Tom Tromey  <tom@tromey.com>
6231
6232         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6233         <free_psymtabs>: Now private.
6234         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6235         (allocate_psymtab): Use new method.
6236
6237 2019-01-10  Tom Tromey  <tom@tromey.com>
6238
6239         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6240         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6241         * mdebugread.c (parse_partial_symbols): Use
6242         allocate_dependencies.
6243         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6244         allocate_dependencies.
6245         (process_psymtab_comp_unit_reader)
6246         (build_type_psymtab_dependencies): Likewise.
6247         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6248
6249 2019-01-10  Tom Tromey  <tom@tromey.com>
6250
6251         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6252         PSYMBOL_SET_LANGUAGE.
6253         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6254
6255 2019-01-10  Tom Tromey  <tom@tromey.com>
6256
6257         * psymtab.h (psymtab_storage::obstack): New method.
6258         <m_obstack>: Rename from obstack; now private.
6259         * psymtab.c (psymtab_storage): Update.
6260         * dwarf2read.c (create_addrmap_from_index)
6261         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6262         Update.
6263
6264 2019-01-10  Tom Tromey  <tom@tromey.com>
6265
6266         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6267         * objfiles.h (objfile::reset_psymtabs): New method.
6268
6269 2019-01-10  Tom Tromey  <tom@tromey.com>
6270
6271         * symmisc.c (print_symbol_bcache_statistics): Update.
6272         (print_objfile_statistics): Update.
6273         * symfile.c (reread_symbols): Update.
6274         * psymtab.h (class psymtab_storage): New.
6275         * psymtab.c (psymtab_storage): New constructor.
6276         (~psymtab_storage): New destructor.
6277         (require_partial_symbols): Update.
6278         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6279         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6280         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6281         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6282         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6283         (start_psymtab_common, end_psymtab_common)
6284         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6285         (allocate_psymtab): Update.
6286         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6287         Update.
6288         (dump_psymtab_addrmap, maintenance_print_psymbols)
6289         (maintenance_check_psymtabs): Update.
6290         (class objfile_psymtabs): Move to objfiles.h.
6291         * psympriv.h (discard_psymtab): Now inline.
6292         (psymtab_discarder::psymtab_discarder): Update.
6293         (psymtab_discarder::~psymtab_discarder): Update.
6294         (ALL_OBJFILE_PSYMTABS): Rewrite.
6295         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6296         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6297         Remove fields.
6298         <partial_symtabs>: New field.
6299         (class objfile_psymtabs): Move from psymtab.h.  Update.
6300         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6301         psymbol_cache.
6302         (objfile::~objfile): Don't destroy psymbol_cache.
6303         * mdebugread.c (parse_partial_symbols): Update.
6304         * dwarf2read.c (create_addrmap_from_index)
6305         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6306         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6307         (add_partial_subprogram, dwarf2_ranges_read): Update.
6308         * dwarf-index-write.c (write_address_map)
6309         (write_one_signatured_type, recursively_write_psymbols)
6310         (class debug_names, class debug_names, write_psymtabs_to_index):
6311         Update.
6312
6313 2019-01-10  Tom Tromey  <tom@tromey.com>
6314
6315         * symtab.h (SYMBOL_SET_NAMES): Update.
6316         (symbol_set_names): Update.
6317         (MSYMBOL_SET_NAMES): Update.
6318         * symtab.c (symbol_set_names): Change argument to be an
6319         objfile_per_bfd_storage.
6320         * psymtab.c (add_psymbol_to_bcache): Update.
6321         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6322
6323 2019-01-10  Tom Tromey  <tom@tromey.com>
6324
6325         * symtab.c (create_demangled_names_hash): Change argument to be an
6326         objfile_per_bfd_storage.
6327         (symbol_set_names): Update.
6328
6329 2019-01-10  Tom Tromey  <tom@tromey.com>
6330
6331         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6332         init_psymbol_list.
6333         * psymtab.c (init_psymbol_list): Do nothing if already called.
6334         * psympriv.h (init_psymbol_list): Add comment.
6335         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6336         init_psymbol_list.
6337         * dbxread.c (dbx_symfile_read): Unconditionally call
6338         init_psymbol_list.
6339
6340 2019-01-10  Tom Tromey  <tom@tromey.com>
6341
6342         * xcoffread.c (scan_xcoff_symtab): Update.
6343         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6344         "where".
6345         * mdebugread.c (parse_partial_symbols)
6346         (handle_psymbol_enumerators): Update.
6347         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6348         * dbxread.c (read_dbx_symtab): Update.
6349         * psympriv.h (psymbol_placement): New enum.
6350         (add_psymbol_to_list): Update.
6351
6352 2019-01-10  Tom Tromey  <tom@tromey.com>
6353
6354         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6355         static_psymbols parameters.
6356         (scan_xcoff_symtab): Update.
6357         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6358         static_psymbols parameters.
6359         * psympriv.h (start_psymtab_common): Update.
6360         * mdebugread.c (parse_partial_symbols): Update.
6361         * dwarf2read.c (create_partial_symtab): Update.
6362         * dbxread.c (read_dbx_symtab): Update.
6363         (start_psymtab): Remove global_psymbols and static_psymbols
6364         parameters.
6365
6366 2019-01-10  Tom Tromey  <tom@tromey.com>
6367
6368         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6369         * psymtab.c (allocate_psymtab): Add comment.
6370         * psympriv.h (allocate_psymtab): Add comment.
6371         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6372         initializations.
6373         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6374
6375 2019-01-10  Tom Tromey  <tom@tromey.com>
6376
6377         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6378         Don't declare.
6379         * mipsread.c: Include mdebugread.h.
6380         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6381         Declare.
6382         * elfread.c: Include mdebugread.h.
6383
6384 2019-01-09  Tom Tromey  <tom@tromey.com>
6385
6386         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6387         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6388         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6389         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6390         (psym_lookup_symbol, psym_find_last_source_symtab)
6391         (psym_forget_cached_source_info, psym_print_stats)
6392         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6393         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6394         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6395         (psym_find_compunit_symtab_by_address)
6396         (maintenance_print_psymbols, maintenance_info_psymtabs)
6397         (maintenance_check_psymtabs): Use ranged for.
6398         * psymtab.h (class objfile_psymtabs): New.
6399         (require_partial_symbols): Return objfile_psymtabs.
6400         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6401
6402 2019-01-09  Tom Tromey  <tom@tromey.com>
6403
6404         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6405         (find_pc_mapped_section, list_overlays_command)
6406         (map_overlay_command, unmap_overlay_command)
6407         (simple_overlay_update): Use all_objfiles.
6408         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6409         * printcmd.c (info_symbol_command): Use all_objfiles.
6410         * objfiles.h (ALL_OBJSECTIONS): Remove.
6411         * maint.c (maintenance_translate_address): Use all_objfiles.
6412         * gcore.c (gcore_create_callback): Use all_objfiles.
6413         (objfile_find_memory_regions): Likewise.
6414
6415 2019-01-09  Tom Tromey  <tom@tromey.com>
6416
6417         * symtab.c (find_line_symtab, info_sources_command)
6418         (make_source_files_completion_list): Use objfile_compunits.
6419         * source.c (select_source_symtab): Use objfile_compunits.
6420         * objfiles.h (struct objfile): Update comment.
6421         (ALL_OBJFILES): Remove.
6422         (ALL_FILETABS): Remove.
6423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6424         objfile_compunits.
6425
6426 2019-01-09  Tom Tromey  <tom@tromey.com>
6427
6428         * symmisc.c (print_objfile_statistics, dump_objfile)
6429         (maintenance_print_symbols): Use compunit_filetabs.
6430         * source.c (forget_cached_source_info_for_objfile): Use
6431         compunit_filetabs.
6432         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6433         (ALL_FILETABS): Use compunit_filetabs.
6434         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6435         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6436
6437 2019-01-09  Tom Tromey  <tom@tromey.com>
6438
6439         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6440         (compunit_filetabs): New.
6441         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6442         compunit_filetabs.
6443         (info_sources_command, make_source_files_completion_list): Remove
6444         declaration.
6445         * symmisc.c (print_objfile_statistics, dump_objfile)
6446         (maintenance_print_symbols): Remove declaration.
6447         (maintenance_info_symtabs): Use compunit_filetabs.
6448         (maintenance_info_line_tables): Likewise.
6449         * source.c (select_source_symtab): Change local variable name.
6450         (forget_cached_source_info_for_objfile): Remove declaration.
6451         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6452         * objfiles.c (objfile_relocate1): Remove declaration.
6453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6454         declaration.
6455         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6456         * coffread.c (coff_symtab_read): Remove declaration.
6457         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6458         compunit_filetabs.
6459
6460 2019-01-09  Tom Tromey  <tom@tromey.com>
6461
6462         * symtab.c (lookup_objfile_from_block)
6463         (find_pc_sect_compunit_symtab, search_symbols)
6464         (default_collect_symbol_completion_matches_break_on): Use
6465         objfile_compunits.
6466         * objfiles.h (ALL_COMPUNITS): Remove.
6467         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6468         * cp-support.c (add_symbol_overload_list_qualified): Use
6469         objfile_compunits.
6470         * ada-lang.c (ada_collect_symbol_completion_matches)
6471         (ada_add_global_exceptions): Use objfile_compunits.
6472
6473 2019-01-09  Tom Tromey  <tom@tromey.com>
6474
6475         * source.c (select_source_symtab)
6476         (forget_cached_source_info_for_objfile): Remove declaration.
6477         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6478         declaration.
6479         * maint.c (count_symtabs_and_blocks): Remove declaration.
6480         * cp-support.c (add_symbol_overload_list_qualified): Remove
6481         declaration.
6482         * coffread.c (coff_symtab_read): Remove declaration.
6483         * symtab.c (lookup_symbol_in_objfile_symtabs)
6484         (basic_lookup_transparent_type_1): Use objfile_compunits.
6485         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6486         (info_sources_command, search_symbols)
6487         (default_collect_symbol_completion_matches_break_on)
6488         (make_source_files_completion_list): Remove declaration.
6489         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6490         (ada_collect_symbol_completion_matches)
6491         (ada_add_global_exceptions): Remove declaration.
6492         * linespec.c (iterate_over_all_matching_symtabs): Use
6493         objfile_compunits.
6494         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6495         (class objfile_compunits): New.
6496         (ALL_COMPUNITS): Use objfile_compunits.
6497         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6498         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6499         objfile_compunits.
6500         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6501
6502 2019-01-09  Tom Tromey  <tom@tromey.com>
6503
6504         * symtab.c (search_symbols)
6505         (default_collect_symbol_completion_matches_break_on): Use
6506         objfile_msymbols.
6507         * ada-lang.c (ada_lookup_simple_minsym)
6508         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6509         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6510         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6511         objfile_msymbols.
6512         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6513         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6514         * objc-lang.c (find_methods): Use objfile_msymbols.
6515         (info_selectors_command, info_classes_command): Likewise.
6516         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6517         * objfiles.h (class objfile_msymbols): New.
6518         (ALL_OBJFILE_MSYMBOLS): Remove.
6519         (ALL_MSYMBOLS): Remove.
6520
6521 2019-01-09  Tom Tromey  <tom@tromey.com>
6522
6523         * common/next-iterator.h (next_adapter): Add Iterator template
6524         parameter.
6525         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6526         (class all_objfiles_safe): New.
6527         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6528         * objfiles.c (put_objfile_before): Update comment.
6529         (add_separate_debug_objfile): Likewise.
6530         (free_all_objfiles): Use all_objfiles_safe.
6531         (objfile_purge_solibs): Likewise.
6532
6533 2019-01-09  Tom Tromey  <tom@tromey.com>
6534
6535         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6536         (expand_symtab_containing_pc, lookup_static_symbol)
6537         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6538         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6539         all_objfiles.
6540         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6541         * breakpoint.c (create_overlay_event_breakpoint)
6542         (create_longjmp_master_breakpoint)
6543         (create_std_terminate_master_breakpoint)
6544         (create_exception_master_breakpoint): Use all_objfiles.
6545         * linux-thread-db.c (try_thread_db_load_from_pdir)
6546         (has_libpthread): Use all_objfiles.
6547         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6548         * linespec.c (iterate_over_all_matching_symtabs)
6549         (search_minsyms_for_name): Use all_objfiles.
6550         * maint.c (maintenance_info_sections): Use all_objfiles.
6551         * main.c (captured_main_1): Use all_objfiles.
6552         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6553         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6554         * guile/scm-pretty-print.c
6555         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6556         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6557         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6558         (maintenance_print_msymbols): Use all_objfiles.
6559         * source.c (select_source_symtab): Use all_objfiles.
6560         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6561         * symfile.c (remove_symbol_file_command)
6562         (expand_symtabs_matching, map_symbol_filenames): Use
6563         all_objfiles.
6564         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6565         all_objfiles.
6566         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6567         * objc-lang.c (find_methods): Use all_objfiles.
6568         * objfiles.c (have_partial_symbols, have_full_symbols)
6569         (have_minimal_symbols, qsort_cmp)
6570         (default_iterate_over_objfiles_in_search_order): Use
6571         all_objfiles.
6572         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6573         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6574         (maintenance_check_psymtabs): Use all_objfiles.
6575         (ALL_PSYMTABS): Remove.
6576         * compile/compile-object-run.c (do_module_cleanup): Use
6577         all_objfiles.
6578         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6579         * cp-support.c (add_symbol_overload_list_qualified): Use
6580         all_objfiles.
6581         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6582         Use all_objfiles.
6583         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6584         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6585         all_objfiles.
6586         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6587         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6588         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6589         Uses all_objfiles.
6590         * solib.c (solib_read_symbols): Use all_objfiles
6591
6592 2019-01-09  Tom Tromey  <tom@tromey.com>
6593
6594         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6595         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6596         all_objfiles.
6597         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6598         * symmisc.c (print_symbol_bcache_statistics)
6599         (print_objfile_statistics, maintenance_print_objfiles)
6600         (maintenance_info_symtabs, maintenance_check_symtabs)
6601         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6602         all_objfiles.
6603         * source.c (forget_cached_source_info): Use all_objfiles.
6604         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6605         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6606         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6607         * objfiles.c (update_section_map): Use all_objfiles.
6608         (shared_objfile_contains_address_p): Likewise.
6609         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6610         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6611
6612 2019-01-09  Tom Tromey  <tom@tromey.com>
6613
6614         * common/next-iterator.h: New file.
6615         * objfiles.h (class all_objfiles): New.
6616         (struct objfile_iterator): New.
6617
6618 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6619
6620         * NEWS: Move the description of the changed "frame", "select-frame",
6621          and "info frame" commands to the Changed commands section.
6622
6623 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6624
6625         * gdbtypes.c (check_stub_method_group): Remove handling of old
6626         mangling schemes.
6627         * linespec.c (find_methods): Likewise.
6628         * stabsread.c (read_member_functions): Likewise.
6629         * valops.c (search_struct_method): Likewise.
6630         (value_struct_elt_for_reference): Likewise.
6631         * NEWS: Mention this change.
6632
6633 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6634
6635         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6636         print_source_lines.
6637         * source.c (print_source_lines_base): Update line number check.
6638         (print_source_lines): New function.
6639         (source_lines_range::source_lines_range): New function.
6640         * source.h (class source_lines_range): New class.
6641         (print_source_lines): New declaration.
6642
6643 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6644
6645         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6646
6647 2019-01-08  Tom Tromey  <tom@tromey.com>
6648             Simon Marchi  <simon.marchi@ericsson.com>
6649
6650         PR gdb/24060
6651         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6652         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6653         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6654         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6655         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6656         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6657
6658 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6659
6660         * source.c (select_source_symtab): Move header comment to
6661         declaration in source.h.
6662         (forget_cached_source_info_for_objfile): Likewise.
6663         (forget_cached_source_info): Likewise.
6664         (identify_source_line): Likewise.
6665         * source.h (identify_source_line): Move declaration from symtab.h
6666         and add comment from source.c
6667         (print_source_lines): Likewise.
6668         (forget_cached_source_info_for_objfile): Likewise.
6669         (forget_cached_source_info): Likewise.
6670         (select_source_symtab): Likewise.
6671         (enum print_source_lines_flag): Move definition from symtab.h.
6672         * symtab.h (identify_source_line): Move declaration to source.h.
6673         (print_source_lines): Likewise.
6674         (forget_cached_source_info_for_objfile): Likewise.
6675         (forget_cached_source_info): Likewise.
6676         (select_source_symtab): Likewise.
6677         (enum print_source_lines_flag): Move definition to source.h.
6678         * tui/tui-hooks.c: Add 'source.h' include.
6679
6680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * source.c (print_source_lines_base): Handle requests to print
6683         reverse line number sequences, and guard against empty lines
6684         string.
6685
6686 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6687
6688         * source.c (print_source_lines_base): Fix skip of '\r' if next
6689         character is '\n'.
6690
6691 2019-01-06  Tom Tromey  <tom@tromey.com>
6692
6693         * c-exp.y (struct c_parse_state) <macro_original_text,
6694         expansion_obstack>: New member.
6695         (macro_original_text, expansion_obstack): Remove globals.
6696         (scan_macro_expansion, scanning_macro_expansion)
6697         (finished_macro_expansion): Update.
6698         (scan_macro_cleanup): Remove.
6699         (yylex, c_parse): Update.
6700
6701 2019-01-06  Tom Tromey  <tom@tromey.com>
6702
6703         * c-exp.y (struct c_parse_state) <strings>: New member.
6704         (operator_stoken): Update.
6705
6706 2019-01-06  Tom Tromey  <tom@tromey.com>
6707
6708         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6709         (union type_stack_elt) <typelist_val>: Now a pointer to
6710         std::vector.
6711         (type_stack_cleanup): Don't declare.
6712         (push_typelist): Update.
6713         * parse.c (pop_typelist): Return a std::vector.
6714         (push_typelist): Take a std::vector.
6715         (follow_types): Update.  Do not free args.
6716         (type_stack_cleanup): Remove.
6717         * c-exp.y (struct c_parse_state): New.
6718         (cpstate): New global.
6719         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6720         (nonempty_typelist): Update.
6721         (func_mod): Create a new vector.
6722         (c_parse): Create a c_parse_state.
6723         (check_parameter_typelist): Do not delete params.
6724         (function_method): Update.  Do not delete type_list.
6725
6726 2019-01-06  Tom Tromey  <tom@tromey.com>
6727
6728         PR gdb/28155:
6729         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6730         check_typedef.
6731         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6732         (print_return_value): Likewise.
6733
6734 2019-01-05  Tom Tromey  <tom@tromey.com>
6735
6736         * contrib/cleanup_check.py: Remove.
6737         * contrib/gcc-with-excheck: Remove.
6738         * contrib/exsummary.py: Remove.
6739         * contrib/excheck.py: Remove.
6740
6741 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6742
6743         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6744         NULL. Initialize tpprev to NULL instead of assigning it
6745         to NULL on the next statement.
6746         * windows-nat.c (windows_delete_thread): Remove check for
6747         main_thread_id before printing thread exit notifications.
6748         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6749         Remove thread ID check against main_thread_id.
6750         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6751         windows_delete_thread.
6752         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6753
6754 2019-01-04  Tom Tromey  <tom@tromey.com>
6755
6756         * compile/compile.c (_initialize_compile): Use upper case for
6757         metasyntactic variables.
6758         * symmisc.c (_initialize_symmisc): Use upper case for
6759         metasyntactic variables.
6760         * psymtab.c (_initialize_psymtab): Use upper case for
6761         metasyntactic variables.
6762         * demangle.c (demangle_command): Use upper case for metasyntactic
6763         variables.
6764         (_initialize_demangler): Likewise.
6765         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6766         variables.
6767
6768 2019-01-03  Tom Tromey  <tom@tromey.com>
6769
6770         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6771
6772 2019-01-03  Tom Tromey  <tom@tromey.com>
6773
6774         * python/py-symtab.c (salpy_str): Update.
6775         (struct salpy_sal_object) <symtab>: Now a PyObject.
6776         (salpy_dealloc): Update.
6777         (del_objfile_sal): Use gdbpy_ref.
6778
6779 2019-01-03  Tom Tromey  <tom@tromey.com>
6780
6781         * python/py-type.c (convert_field): Use new_reference.  Return
6782         gdbpy_ref.
6783         (make_fielditem): Return gdbpy_ref.
6784         (typy_fields): Update.
6785         (typy_getitem): Update.
6786         (field_name): Return gdbpy_ref.  Use new_reference.
6787         (typy_iterator_iternext): Update.
6788
6789 2019-01-03  Tom Tromey  <tom@tromey.com>
6790
6791         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6792
6793 2019-01-03  Tom Tromey  <tom@tromey.com>
6794
6795         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6796         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6797         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6798         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6799         (pspy_set_type_printers): Likewise.
6800         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6801         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6802         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6803         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6804         (objfpy_set_type_printers): Likewise.
6805
6806 2019-01-03  Tom Tromey  <tom@tromey.com>
6807
6808         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6809         (gdbpy_print_stack): Use gdbpy_err_fetch.
6810         * python/python-internal.h (class gdbpy_err_fetch): New class.
6811         (class gdbpy_enter) <m_error_type, m_error_value,
6812         m_error_traceback>: Remove.
6813         <m_error>: New member.
6814         (gdbpy_exception_to_string): Don't declare.
6815         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6816         * python/py-value.c (convert_value_from_python): Use
6817         gdbpy_err_fetch.
6818         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6819         gdbpy_exception_to_string.
6820         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6821         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6822         gdbpy_err_fetch.
6823
6824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6825
6826         * linux-nat.c (delete_lwp_cleanup): Delete.
6827         (struct lwp_deleter): New struct.
6828         (lwp_info_up): New typedef.
6829         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6830         lwp_info_up.
6831
6832 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6833
6834         * linux-fork.c (class scoped_switch_fork_info): New class.
6835         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6836
6837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6838
6839         * valops.c (find_overload_match): Remove use of null_cleanup, and
6840         calls to do_cleanups.
6841
6842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * compile/compile-cplus-types.c
6845         (compile_cplus_instance::decl_name): Handle changes to
6846         cp_func_name.
6847         * cp-support.c (cp_func_name): Update header comment, update
6848         return type.
6849         * cp-support.h (cp_func_name): Update return type in declaration.
6850         * valops.c (find_overload_match): Move temp_func local to top
6851         level of function and change its type.  Use temp_func to hold and
6852         delete temporary string obtained from cp_func_name.
6853
6854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6855
6856         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6857         gdb::char_vector, remove cleanup, and update uses of `msg`.
6858
6859 2019-01-03  Jim Wilson  <jimw@sifive.com>
6860
6861         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6862
6863 2019-01-02  Tom Tromey  <tom@tromey.com>
6864
6865         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6866         (tdesc_parse_xml): Remove cleanups.
6867         * target-descriptions.h (make_cleanup_free_target_description):
6868         Don't declare.
6869         (target_desc_deleter): New struct.
6870         (target_desc_up): New typedef.
6871         * target-descriptions.c (target_desc_deleter::operator()): Rename
6872         from free_target_description.
6873         (make_cleanup_free_target_description): Remove.
6874
6875 2019-01-02  Tom Tromey  <tom@tromey.com>
6876
6877         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6878         constructor, destructor.
6879         (linespec_parser): Remove typedef.
6880         (~linespec_parser): Rename from linespec_parser_delete.
6881         (linespec_lex_to_end, linespec_complete_label)
6882         (linespec_complete): Update.
6883         (decode_line_full): Remove cleanups.
6884         (decode_line_1): Update.
6885
6886 2019-01-02  Tom Tromey  <tom@tromey.com>
6887
6888         * python/python-internal.h (inferior_to_inferior_object): Change
6889         return type.
6890         * python/py-exitedevent.c (create_exited_event_object): Update.
6891         * python/py-inferior.c (inferior_to_inferior_object): Return
6892         gdbpy_ref.
6893         (python_new_inferior, python_inferior_deleted)
6894         (thread_to_thread_object, delete_thread_object)
6895         (build_inferior_list, gdbpy_selected_inferior): Update.
6896         * python/py-infthread.c (create_thread_object): Update.  Also fail
6897         if inferior_to_inferior_object fails.
6898
6899 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6900
6901         * inferior.h (class inferior) <displaced_step_state>: New field.
6902         * infrun.h (struct displaced_step_state): Move here from
6903         infrun.c.  Initialize fields, add constructor.
6904         <inf>: Remove field.
6905         <reset>: New method.
6906         * infrun.c (struct displaced_step_inferior_state): Move to
6907         infrun.h.
6908         (displaced_step_inferior_states): Remove.
6909         (get_displaced_stepping_state): Adust.
6910         (displaced_step_in_progress_any_inferior): Adjust.
6911         (displaced_step_in_progress_thread): Adjust.
6912         (displaced_step_in_progress): Adjust.
6913         (add_displaced_stepping_state): Remove.
6914         (get_displaced_step_closure_by_addr): Adjust.
6915         (remove_displaced_stepping_state): Remove.
6916         (infrun_inferior_exit): Call displaced_step_state.reset.
6917         (use_displaced_stepping): Don't check for NULL.
6918         (displaced_step_prepare_throw): Call
6919         get_displaced_stepping_state.
6920         (displaced_step_fixup): Don't check for NULL.
6921         (prepare_for_detach): Don't check for NULL.
6922
6923 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6924
6925         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6926          in case of call that did not complete.
6927
6928 2019-01-02  Andrey Utkin  <autkin@undo.io>
6929
6930         * symfile.c (find_separate_debug_file): Fix search of debug files for
6931         remote debuggee.
6932
6933 2019-01-02  Tom Tromey  <tom@tromey.com>
6934
6935         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6936         indentation.
6937         * python/py-frame.c (frapy_older): Remove cast.
6938         (frapy_newer): Likewise.
6939         * python/py-breakpoint.c (local_setattro): Remove cast.
6940         * python/py-arch.c (archpy_name): Remove local variable.
6941         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6942
6943 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6944
6945         * unittests/basic_string_view/element_access/char/empty.cc:
6946         Fix year range in copyright header.
6947
6948 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6949
6950         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6951         Delete.
6952         <operator==>: Update with for removed field.
6953         <hash>: Likewise.
6954         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6955         <isa_features>: ...this.
6956         <abi_features>: New field.
6957         (riscv_isa_flen): Update comment.
6958         (riscv_abi_xlen): New declaration.
6959         (riscv_abi_flen): New declaration.
6960         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6961         isa_features.
6962         (riscv_abi_xlen): New function.
6963         (riscv_isa_flen): Update to get answer from isa_features.
6964         (riscv_abi_flen): New function.
6965         (riscv_has_fp_abi): Update to get answer from abi_features.
6966         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6967         xlen and flen.
6968         (riscv_call_info) <xlen, flen>: Update comment.
6969         (riscv_call_arg_struct): Remove invalid assertions
6970         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6971         is removed.
6972         (riscv_gdbarch_init): Gather isa features and abi features
6973         separately, ensure both match on the gdbarch when reusing an old
6974         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6975         a target with 64-bit float hardware.
6976
6977 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6978
6979         * source.c (search_command_helper): Stop reverse search
6980         when line 1 has been searched.
6981
6982 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6983
6984         * record-full.c (record_full_base_target::close): Rewrite
6985         record_full_core_buf_list free logic.
6986
6987 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6988
6989         * break-catch-syscall.c (print_one_catch_syscall): xfree
6990         the last text.
6991
6992 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6993
6994         * top.c (print_gdb_version): Update Copyright year in version
6995         message.
6996
6997 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6998
6999         Update copyright year range in all GDB files.
7000
7001 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7002
7003         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7004
7005 For older changes see ChangeLog-2018.
7006 \f
7007 Local Variables:
7008 mode: change-log
7009 left-margin: 8
7010 fill-column: 74
7011 version-control: never
7012 coding: utf-8
7013 End:
7014