gdb/ChangeLog

   1 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
   4         Use current_event.dwThreadId instead of main_thread_id.
   5
   6 2019-04-30  Tom Tromey  <tromey@adacore.com>
   7
   8         * ada-lang.c (ada_lookup_simple_minsyms): New function.
   9         (create_excep_cond_exprs): Iterate over program spaces.
  10         (ada_exception_catchpoint_cond_string): Examine all minimal
  11         symbols for exception types.
  12
  13 2019-04-30  Tom Tromey  <tromey@adacore.com>
  14
  15         PR c++/24470:
  16         * dwarf2read.c (process_structure_scope): Handle case where type
  17         has template parameters but no symbol was created.
  18
  19 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  20             Chris January  <chris.january@arm.com>
  21
  22         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  23         qualifier.
  24         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  25
  26 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * f-typeprint.c (f_print_type): Update rules for printing
  29         whitespace.
  30         (f_type_print_varspec_suffix): Likewise.
  31
  32 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  33             Chris January  <chris.january@arm.com>
  34
  35         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  36         function arguments.
  37
  38 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  39
  40         * f-lang.c (build_fortran_types): Change name of void type to
  41         lower case.
  42         * f-typeprint.c (f_type_print_base): Print the name of the void
  43         type, rather than a fixed string.
  44         * f-valprint.c (f_decorations): Use lower case void string.
  45
  46 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  47             Chris January  <chris.january@arm.com>
  48
  49         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  50         types for Fortran.
  51
  52 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  53             Chris January  <chris.january@arm.com>
  54             David Lecomber  <david.lecomber@arm.com>
  55
  56         * f-exp.y (BINOP_INTRINSIC): New token.
  57         (exp): New parser rule handling BINOP_INTRINSIC.
  58         (f77_keywords): Add new builtin procedures.
  59         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  60         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  61         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  62         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  63         (print_unop_subexp_f): New function.
  64         (print_binop_subexp_f): New function.
  65         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  66         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  67         (dump_subexp_body_f): Likewise.
  68         (operator_check_f): Likewise.
  69         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  70         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  71
  72 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
  75         UNOP_KIND.
  76         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
  77         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
  78         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
  79         (operator_length_f): New fuction.
  80         (print_subexp_f): New function.
  81         (op_name_f): New function.
  82         (dump_subexp_body_f): New function.
  83         (operator_check_f): New function.
  84         (exp_descriptor_f): Replace standard expression handling functions
  85         with new functions.
  86         * gdb/fortran-operator.def: New file.
  87         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
  88         * gdb/std-operator.def: Remove UNOP_KIND.
  89
  90 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         * std-operator.def: Remove unbalanced, stray double quote
  93         character.
  94
  95 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  96             Chris January  <chris.january@arm.com>
  97             Daniel Everett  <daniel.everett@arm.com>
  98             Nick Forrington  <nick.forrington@arm.com>
  99             Richard Bunt  <richard.bunt@arm.com>
 100
 101         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 102         of depth when printing anonymous structs or unions.
 103         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 104         Don't print either the top-level value, or the children if the
 105         max-depth is exceeded.
 106         (ppscm_print_children): When printing the key of a map, allow one
 107         extra level of depth.
 108         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 109         print either the top-level value, or the children if the max-depth
 110         is exceeded.
 111         (print_children): When printing the key of a map, allow one extra
 112         level of depth.
 113         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 114         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 115         (user_print_options): Initialise max_depth field.
 116         (val_print_scalar_or_string_type_p): New function.
 117         (val_print): Check to see if the max depth has been reached.
 118         (val_print_check_max_depth): Define new function.
 119         (show_print_max_depth): New function.
 120         (_initialize_valprint): Add 'print max-depth' option.
 121         * valprint.h (struct value_print_options) <max_depth>: New field.
 122         (val_print_check_max_depth): Declare new function.
 123         * NEWS: Document new feature.
 124
 125 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 126
 127         * ada-lang.c (ada_language_defn): Initialise new field.
 128         * c-lang.c (c_is_string_type_p): New function.
 129         (c_language_defn): Initialise new field.
 130         (cplus_language_defn): Initialise new field.
 131         (asm_language_defn): Initialise new field.
 132         (minimal_language_defn): Initialise new field.
 133         * c-lang.h (c_is_string_type_p): Declare new function.
 134         * d-lang.c (d_language_defn): Initialise new field.
 135         * f-lang.c (f_is_string_type_p): New function.
 136         (f_language_defn): Initialise new field.
 137         * go-lang.c (go_is_string_type_p): New function.
 138         (go_language_defn): Initialise new field.
 139         * language.c (default_is_string_type_p): New function.
 140         (unknown_language_defn): Initialise new field.
 141         (auto_language_defn): Initialise new field.
 142         * language.h (struct language_defn) <la_is_string_type_p>: New
 143         member variable.
 144         (default_is_string_type_p): Declare new function.
 145         * m2-lang.c (m2_language_defn): Initialise new field.
 146         * objc-lang.c (objc_language_defn): Initialise new field.
 147         * opencl-lang.c (opencl_language_defn): Initialise new field.
 148         * p-lang.c (pascal_is_string_type_p): New function.
 149         (pascal_language_defn): Initialise new field.
 150         * rust-lang.c (rust_is_string_type_p): New function.
 151         (rust_language_defn): Initialise new field.
 152
 153 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 154
 155         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 156         New field.
 157         * ada-lang.c (ada_language_defn): Initialise new field.
 158         * c-lang.c (c_language_defn): Likewise.
 159         (cplus_language_defn): Likewise.
 160         (asm_language_defn): Likewise.
 161         (minimal_language_defn): Likewise.
 162         * d-lang.c (d_language_defn): Likewise.
 163         * f-lang.c (f_language_defn): Likewise.
 164         * go-lang.c (go_language_defn): Likewise.
 165         * language.c (unknown_language_defn): Likewise.
 166         (auto_language_defn): Likewise.
 167         * m2-lang.c (m2_language_defn): Likewise.
 168         * objc-lang.c (objc_language_defn): Likewise.
 169         * opencl-lang.c (opencl_language_defn): Likewise.
 170         * p-lang.c (pascal_language_defn): Likewise.
 171         * rust-lang.c (rust_language_defn): Likewise.
 172
 173 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 174
 175         * ada-lang.c (ada_is_character_type): Change return type to bool.
 176         (ada_is_string_type): Likewise.
 177         * ada-lang.h (ada_is_character_type): Update declaration
 178         (ada_is_string_type): Likewise.
 179
 180 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 181
 182         Support style in 'frame|thread apply'
 183
 184         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 185         * record.c (record_start, record_stop): Update callers of
 186         execute_command_to_string with false.
 187         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 188         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 189         methods.
 190         (class string_file): New constructor with term_out parameter.
 191         Override methods term_out and can_emit_style_escape.  New member
 192         term_out.
 193         (class stdio_file): Override can_emit_style_escape.
 194         (class tee_file): Override term_out and can_emit_style_escape.
 195         * utils.h (can_emit_style_escape): Remove.
 196         * utils.c (can_emit_style_escape): Likewise.
 197         Update all callers of can_emit_style_escape (SOMESTREAM) to
 198         SOMESTREAM->can_emit_style_escape.
 199         * source-cache.c (source_cache::get_source_lines): Likewise.
 200         * stack.c (frame_apply_command_count): Call execute_command_to_string
 201         passing the term_out characteristic of the current gdb_stdout.
 202         * thread.c (thr_try_catch_cmd): Likewise.
 203         * top.c (execute_command_to_string): pass term_out parameter
 204         to construct the string_file for the command output.
 205         * ui-file.c (term_cli_styling): New function (most code moved
 206         from utils.c can_emit_style_escape).
 207         (string_file::string_file, string_file::can_emit_style_escape,
 208         stdio_file::can_emit_style_escape, tee_file::term_out,
 209         tee_file::can_emit_style_escape): New functions.
 210
 211 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 212
 213         * NEWS: Mention the new set|show may-call-functions.
 214         * infcall.c (may_call_functions_p): New variable.
 215         (show_may_call_functions_p): New function.
 216         (call_function_by_hand_dummy): Throws an error if not
 217         may-call-functions.
 218         (_initialize_infcall): Call add_setshow_boolean_cmd for
 219         may-call-functions.
 220
 221 2019-04-25  Keith Seitz  <keiths@redhat.com>
 222
 223         PR c++/24367
 224         * cp-support.c (inspect_type): Don't attempt substitutions
 225         of symbol with the same name.
 226
 227 2019-04-25  Tom Tromey  <tromey@adacore.com>
 228
 229         PR gdb/24475:
 230         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 231         static.
 232
 233 2019-04-25  Tom Tromey  <tromey@adacore.com>
 234
 235         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 236         rvalue reference.
 237         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 238         (gdb_xml_parser::parse): Use std::move.
 239         * python/python-internal.h (gdbpy_convert_exception): Take a const
 240         reference.
 241         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 242         std::move.
 243         * python/py-utils.c (gdbpy_convert_exception): Take a const
 244         reference.
 245         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 246         Use std::move.
 247         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 248         Use std::move.
 249         * mi/mi-main.c (mi_print_exception): Take a const reference.
 250         * main.c (handle_command_errors): Take a const reference.
 251         * linespec.c (parse_linespec): Use std::move.
 252         * infcall.c (run_inferior_call): Use std::move.
 253         (call_function_by_hand_dummy): Use std::move.
 254         * exec.c (try_open_exec_file): Use std::move.
 255         * exceptions.h (exception_print, exception_fprintf)
 256         (exception_print_same): Update.
 257         * exceptions.c (print_exception, exception_print)
 258         (exception_fprintf, exception_print_same): Change parameters to
 259         const reference.
 260         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 261         * common/new-op.c: Use std::move.
 262         * common/common-exceptions.h (struct gdb_exception): Add move
 263         constructor.
 264         (struct gdb_exception_error, struct gdb_exception_quit, struct
 265         gdb_quit_bad_alloc): Change constructor to move constructor.
 266         (throw_exception): Change parameter to rvalue reference.
 267         * common/common-exceptions.c (throw_exception): Take rvalue
 268         reference.
 269         * cli/cli-interp.c (safe_execute_command): Use std::move.
 270         * breakpoint.c (insert_bp_location, location_to_sals): Use
 271         std::move.
 272
 273 2019-04-25  Tom Tromey  <tromey@adacore.com>
 274
 275         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 276         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 277         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 278         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 279         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 280         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 281         guile/scm-value.c: Use unpack.
 282         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 283         gdbscm_gdb_exception.
 284         (gdbscm_throw_gdb_exception): Likewise.
 285         (struct gdbscm_gdb_exception): New.
 286         (unpack): New function.
 287         (gdbscm_wrap): Use unpack.
 288
 289 2019-04-25  Tom Tromey  <tromey@adacore.com>
 290
 291         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 292         (gdb_rl_callback_handler): Use std::move.
 293         * common/common-exceptions.h (struct gdb_exception): Add move
 294         assignment operator.
 295         (throw_exception_sjlj): Change "exception" to const reference.
 296         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 297         (throw_exception_sjlj): Change "exception" to const reference.
 298
 299 2019-04-25  Tom Tromey  <tromey@adacore.com>
 300
 301         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 302         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 303         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 304         Update.
 305         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 306         Update.
 307         * mi/mi-interp.c (mi_interp::exec): Update.
 308         * linespec.c (parse_linespec): Update.
 309         * infcall.c (run_inferior_call): Update.
 310         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 311         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 312         (gdbscm_lookup_global_symbol): Update.
 313         * guile/scm-param.c (gdbscm_parameter_value): Update.
 314         * guile/scm-frame.c (gdbscm_frame_read_register)
 315         (gdbscm_frame_read_var): Update.
 316         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 317         * exec.c (try_open_exec_file): Update.
 318         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 319         (gdb_rl_callback_handler): Update.
 320         * common/common-exceptions.h (exception_none): Don't declare.
 321         * common/common-exceptions.c (exception_none): Don't define.
 322         (struct catcher) <exception>: Update.
 323         * cli/cli-interp.c (safe_execute_command): Update.
 324         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 325
 326 2019-04-25  Ali Tamur  <tamur@google.com>
 327
 328         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 329         (read_attribute_value): Likewise.
 330         (dwarf2_read_addr_index): Update comment.
 331         (read_str_index): Add DW_FORM_strx.
 332         (dwarf2_string_attr): Likewise.
 333         (dwarf2_const_value_attr): Likewise.
 334         (dump_die_shallow): Likewise.
 335         (dwarf2_fetch_constant_bytes): Likewise.
 336         (skip_form_bytes): Likewise.
 337         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 338
 339 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 340
 341         PR corefiles/11608
 342         PR corefiles/18187
 343         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 344         OFFSET.  Verify if current mapping contains an ELF header.
 345         (linux_find_memory_regions_full): Adjust call to
 346         dump_mapping_p.
 347
 348 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 349             Kang Li <kanglictf@gmail.com>
 350
 351         PR gdb/21600
 352
 353         * dwarf2-frame.c (read_initial_length): Be consistent about using
 354         unsigned representation of length.
 355         (decode_frame_entry_1): Likewise.  Check for wraparound of
 356         end pointer as well as buffer overflow.
 357
 358 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 359
 360         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 361         "vq".
 362
 363 2019-04-24  Tom Tromey  <tromey@adacore.com>
 364
 365         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 366
 367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 368
 369         * s12z-tdep.c (s12z_unwind_pc): Delete.
 370         (s12z_unwind_sp): Delete.
 371         (s12z_gdbarch_init): Don't register deleted functions with
 372         gdbarch.
 373
 374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 375
 376         * rl78-tdep.c (rl78_unwind_sp): Delete.
 377         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 378
 379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 380
 381         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 382         (xstormy16_unwind_pc): Delete.
 383         (xstormy16_dummy_id): Delete.
 384         (xstormy16_gdbarch_init): Don't register deleted functions with
 385         gdbarch.
 386
 387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 388
 389         * vax-tdep.c (vax_unwind_pc): Delete.
 390         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 391
 392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 393
 394         * v850-tdep.c (v850_unwind_sp): Delete.
 395         (v850_unwind_pc): Delete.
 396         (v850_dummy_id): Delete.
 397         (v850_gdbarch_init): Don't register deleted functions with
 398         gdbarch.
 399
 400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 401
 402         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 403         (tilegx_unwind_pc): Delete.
 404         (tilegx_unwind_dummy_id): Delete.
 405         (tilegx_gdbarch_init): Don't register deleted functions with
 406         gdbarch.
 407
 408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 411         (tic6x_dummy_id): Delete.
 412         (tic6x_gdbarch_init): Don't register deleted functions with
 413         gdbarch.
 414
 415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 416
 417         * sparc-tdep.c (sparc_unwind_pc): Delete.
 418         (sparc32_gdbarch_init): Don't register deleted function with
 419         gdbarch.
 420
 421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 422
 423         * sh-tdep.c (sh_unwind_sp): Delete.
 424         (sh_unwind_pc): Delete.
 425         (sh_dummy_id): Delete.
 426         (sh_gdbarch_init): Don't register deleted functions with
 427         gdbarch.
 428
 429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 430
 431         * score-tdep.c (score_unwind_sp): Delete.
 432         (score_unwind_pc): Delete.
 433         (score_dummy_id): Delete.
 434         (score_gdbarch_init): Don't register deleted functions with
 435         gdbarch.
 436
 437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 438
 439         * rx-tdep.c (rx_unwind_pc): Delete.
 440         (rx_unwind_sp): Delete.
 441         (rx_dummy_id): Delete.
 442         (rx_gdbarch_init): Don't register deleted functions with
 443         gdbarch.  Update comment.
 444
 445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 446
 447         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 448         (rs6000_dummy_id): Delete.
 449         (rs6000_gdbarch_init): Don't register deleted functions with
 450         gdbarch.
 451
 452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * or1k-tdep.c (or1k_dummy_id): Delete.
 455         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 456
 457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * nios2-tdep.c (nios2_dummy_id): Delete.
 460         (nios2_unwind_sp): Delete.
 461         (nios2_gdbarch_init): Don't register deleted functions with
 462         gdbarch.
 463
 464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 465
 466         * nds32-tdep.c (nds32_dummy_id): Delete.
 467         (nds32_unwind_pc): Delete.
 468         (nds32_unwind_sp): Delete.
 469         (nds32_gdbarch_init): Don't register deleted functions with
 470         gdbarch.
 471
 472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 473
 474         * msp430-tdep.c (msp430_unwind_pc): Delete.
 475         (msp430_unwind_sp): Delete.
 476         (msp430_dummy_id): Delete.
 477         (msp430_gdbarch_init): Don't register deleted functions with
 478         gdbarch.
 479
 480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 481
 482         * moxie-tdep.c (moxie_unwind_sp): Delete.
 483         (moxie_unwind_pc): Delete.
 484         (moxie_dummy_id): Delete.
 485         (moxie_gdbarch_init): Don't register deleted functions with
 486         gdbarch.
 487
 488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 491         (mn10300_unwind_pc): Delete.
 492         (mn10300_unwind_sp): Delete.
 493         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 494         mn10300_unwind_sp.
 495         (mn10300_frame_unwind_init): Don't register deleted functions with
 496         gdbarch.
 497
 498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * mep-tdep.c (mep_unwind_pc): Delete.
 501         (mep_unwind_sp): Delete.
 502         (mep_dummy_id): Delete.
 503         (mep_gdbarch_init): Don't register deleted functions with
 504         gdbarch.
 505
 506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 509         (m68hc11_unwind_sp): Delete.
 510         (m68hc11_gdbarch_init): Don't register deleted functions with
 511         gdbarch.
 512
 513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * m32r-tdep.c (m32r_unwind_sp): Delete.
 516         (m32r_unwind_pc): Delete.
 517         (m32r_dummy_id): Delete.
 518         (m32r_gdbarch_init): Don't register deleted functions with
 519         gdbarch.
 520
 521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 522
 523         * m32c-tdep.c (m32c_unwind_pc): Delete.
 524         (m32c_unwind_sp): Delete.
 525         (m32c_dummy_id): Delete.
 526         (m32c_gdbarch_init): Don't register deleted functions with
 527         gdbarch.
 528
 529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 532         (lm32_unwind_pc): Delete.
 533         (lm32_dummy_id): Delete.
 534         (lm32_gdbarch_init): Don't register deleted functions with
 535         gdbarch.
 536
 537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 540         (iq2000_unwind_pc): Delete.
 541         (iq2000_dummy_id): Delete.
 542         (iq2000_gdbarch_init): Don't register deleted functions with
 543         gdbarch.
 544
 545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * nds32-tdep.c (nds32_type_align): Delete.
 548         (nds32_push_dummy_call): Use type_align instead.
 549
 550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 551
 552         * arm-tdep.c (arm_type_align): Only handle vector override case.
 553         (arm_push_dummy_call): Use type_align.
 554         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 555
 556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 559         case.
 560         (pass_on_stack): Use type_align.
 561         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 562         function.
 563
 564 2019-04-23  Tom Tromey  <tromey@adacore.com>
 565
 566         * dwarf2read.c (line_header::file_name_at): Remove unused
 567         overload.
 568
 569 2019-04-23  Tom de Vries  <tdevries@suse.de>
 570
 571         PR gdb/24438
 572         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 573         invocation.
 574
 575
 576 2019-03-27  Ali Tamur  <tamur@google.com>
 577
 578         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 579         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 580         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 581         (dwarf_expr_context::get_addr_index): Likewise
 582         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 583         (symbol_needs_eval_context::get_addr_index): Likewise
 584         (disassemble_dwarf_expression): Add DW_OP_addrx
 585         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 586         (read_cutu_die_from_dwo): Update comment
 587         (skip_one_die): Add DW_FORM_addrx
 588         (read_attribute_value): Likewise
 589         (var_decode_location): Add DW_OP_addrx
 590         (dwarf2_const_value_attr): Add DW_FORM_addrx
 591         (dump_die_shallow): Likewise
 592         (dwarf2_fetch_constant_bytes): Likewise
 593         (decode_locdesc): Add DW_OP_addrx
 594         (skip_form_bytes): Add DW_FORM_addrx
 595
 596 2019-04-22  Ali Tamur  <tamur@google.com>
 597
 598         * MAINTAINERS (Write After Approval): Add self.
 599
 600 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 601
 602         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 603         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 604         (open_symbol_file_object): Likewise.
 605         (svr4_default_sos): Add info parameter.
 606         (svr4_read_so_list): Likewise.
 607         (svr4_current_sos_direct): Adjust functions calls to pass down
 608         info.
 609         (svr4_current_sos_1): Add info parameter.
 610         (svr4_current_sos): Call get_svr4_info, pass info down to
 611         svr4_current_sos_1.
 612         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 613         get_svr4_info.
 614         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 615         get_svr4_info.
 616         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 617         to get_svr4_info.
 618         (probes_table_remove_objfile_probes): Likewise.
 619         (register_solib_event_probe): Add info parameter.
 620         (solist_update_incremental): Pass info parameter down to
 621         svr4_read_so_list.
 622         (disable_probes_interface): Add info parameter.
 623         (svr4_handle_solib_event): Pass current_program_space to
 624         get_svr4_info.  Adjust disable_probes_interface cleanup.
 625         (svr4_create_probe_breakpoints): Add info parameter, pass it
 626         down to register_solib_event_probe.
 627         (svr4_create_solib_event_breakpoints): Add info parameter,
 628         pass it down to svr4_create_probe_breakpoints.
 629         (enable_break): Pass info down to
 630         svr4_create_solib_event_breakpoints.
 631         (svr4_solib_create_inferior_hook): Pass current_program_space to
 632         get_svr4_info.
 633         (svr4_clear_solib): Likewise.
 634
 635 2019-04-22  Pedro Alves  <palves@redhat.com>
 636
 637         * solib-svr4.c (svr4_free_objfile_observer): New.
 638         (probe_and_action::objfile): New field.
 639         (probes_table_htab_remove_objfile_probes)
 640         (probes_table_remove_objfile_probes): New functions.
 641         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 642         in the new probe_and_action.  Don't store the probe in 'lookup'.
 643         (svr4_create_probe_breakpoints): Pass objfile to
 644         register_solib_event_probe.
 645         (_initialize_svr4_solib): Register a free_objfile observer.
 646
 647 2019-04-19  Tom Tromey  <tom@tromey.com>
 648
 649         * common/queue.h: Remove.
 650
 651 2019-04-19  Tom Tromey  <tom@tromey.com>
 652
 653         * event-loop.c: Don't include "common/queue.h".
 654
 655 2019-04-19  Tom Tromey  <tom@tromey.com>
 656
 657         * remote.c (remote_target): Use delete.
 658         * remote-notif.h: Include <list>, not "common/queue.h".
 659         (notif_client_p): Remove typedef.
 660         (remote_notif_state): Add constructor, destructor, initializer.
 661         <notif_queue>: Now a std::list.
 662         (remote_notif_state_xfree): Don't declare.
 663         * remote-notif.c (remote_notif_process, handle_notification)
 664         (remote_notif_state_allocate): Update.
 665         (~remote_notif_state): Rename from remote_notif_state_xfree.
 666
 667 2019-04-19  Tom Tromey  <tom@tromey.com>
 668
 669         * symfile.c (reread_symbols): Update.
 670         * objfiles.c (objfile_register_static_link)
 671         (objfile_lookup_static_link): Update
 672         (~objfile) Don't delete static_links.
 673         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 674
 675 2019-04-19  Tom Tromey  <tom@tromey.com>
 676
 677         * type-stack.h (struct type_stack) <insert>: Constify string.
 678         * type-stack.c (type_stack::insert): Constify string.
 679         * gdbtypes.h (lookup_template_type): Update.
 680         (address_space_name_to_int): Update.
 681         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 682         const.
 683         (lookup_template_type): Make name const.
 684         * c-exp.y: Update rules.
 685         (lex_one_token, classify_name, classify_inner_name)
 686         (c_print_token): Update.
 687         * p-exp.y: Update rules.
 688         (yylex): Update.
 689         * f-exp.y: Update rules.
 690         (yylex): Update.
 691         * d-exp.y: Update rules.
 692         (lex_one_token, classify_name, classify_inner_name): Update.
 693         * parse.c (write_dollar_variable, copy_name): Return std::string.
 694         * parser-defs.h (copy_name): Change return type.
 695         * m2-exp.y: Update rules.
 696         (yylex): Update.
 697         * go-exp.y (lex_one_token): Update.
 698         Update rules.
 699         (classify_unsafe_function, classify_packaged_name)
 700         (classify_name, yylex): Update.
 701
 702 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 703
 704         * configure.ac: add --enable-source-highlight switch.
 705         * configure: Regenerate.
 706         * top.c (print_gdb_version): plumb --enable-source-highlight
 707         status to "show configuration".
 708
 709 2019-04-19  Tom Tromey  <tromey@adacore.com>
 710
 711         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 712         Check ADA_TYPE_P.
 713         (empty_record, ada_template_to_fixed_record_type_1)
 714         (template_to_static_fixed_type)
 715         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 716         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 717         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 718         macros.
 719
 720 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 721
 722         PR symtab/24423:
 723         * source.c (print_source_lines_base): Advance "iter" when a
 724         control character is seen.
 725
 726 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 727
 728         * inferior.h (struct infcall_suspend_state_deleter):
 729         Catch exception in destructor to avoid crash.
 730
 731 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 732
 733         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 734         close to the add_com "shell".
 735
 736 2019-04-18  Tom Tromey  <tromey@adacore.com>
 737
 738         * process-stratum-target.h (class process_stratum_target)
 739         <stratum>: Add "final".
 740
 741 2019-04-17  Tom Tromey  <tromey@adacore.com>
 742
 743         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 744         against nullptr before use.
 745
 746 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 747
 748         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 749
 750 2019-04-17  Jim Wilson  <jimw@sifive.com>
 751             Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 754         code read might fail, assume 4-byte breakpoint in that case.
 755
 756 2019-04-15  Leszek Swirski  <leszeks@google.com>
 757
 758         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 759         rather than a hand-rolled POD check when checking for forced MEMORY
 760         classification.
 761
 762 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 763
 764         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 765         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 766         function.
 767         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 768         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 769         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 770         declaration.
 771
 772 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 773
 774         * aarch64-linux-nat.c
 775         (aarch64_linux_nat_target::thread_architecture): Add override.
 776         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 777         each VQ.
 778
 779 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 780
 781         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 782
 783 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 784
 785         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 786         target types of size 96-bits, add some additional comments, and
 787         check that the builtin type we found was the correct size.
 788
 789 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 790
 791         * utils.c (prompt_for_continue): Don't restore the styling at the
 792         end, as applied_style has the wrong value.  This fixes styling in
 793         long lists of file names that are interrupted by the "Continue?"
 794         prompt.
 795
 796 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 799         * c-lang.c (c_language_defn): Likewise.
 800         (cplus_language_defn): Likewise.
 801         (asm_language_defn): Likewise.
 802         (minimal_language_defn): Likewise.
 803         * d-lang.c (d_language_defn): Likewise.
 804         * f-lang.c (f_language_defn): Likewise.
 805         * go-lang.c (go_language_defn): Likewise.
 806         * language.c (unknown_language_defn): Likewise.
 807         (auto_language_defn): Likewise.
 808         * language.h (struct language_defn): Remove la_magic field.
 809         (LANG_MAGIC): Delete.
 810         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 811         * objc-lang.c (objc_language_defn): Likewise.
 812         * opencl-lang.c (opencl_language_defn): Likewise.
 813         * p-lang.c (pascal_language_defn): Likewise.
 814         * rust-lang.c (rust_language_defn): Likewise.
 815
 816 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * riscv-tdep.c (riscv_type_align): New function.
 819         (riscv_type_alignment): Delete.
 820         (riscv_arg_location): Use 'type_align'.
 821         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 822
 823 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * gdbtypes.c (type_align): A struct with no non-static fields also
 826         has alignment of 1.
 827
 828 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 831         component to 0.
 832         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 833         member.
 834         (riscv_struct_info::analyse): New implementation using new
 835         analyse_inner member function.
 836         (riscv_struct_info::field_offset): New member function.
 837         (riscv_struct_info::m_offsets): New member variable.
 838         (riscv_struct_info::analyse_inner): New private member function,
 839         takes the old implementation of riscv_struct_info::analyse but
 840         extended to track field offsets.
 841         (riscv_call_arg_struct): Update the struct folding special cases
 842         to handle cases where empty C++ structs, which are non-zero
 843         length, are found.
 844         (riscv_arg_location): Initialise the length of each location, a
 845         non-zero length now indicates the location is in use.
 846         (riscv_push_dummy_call): Allow for the first location having a
 847         non-zero offset when setting up arguments.
 848         (riscv_return_value): Likewise, but for return values.
 849
 850 2019-04-11  Tom Tromey  <tromey@adacore.com>
 851
 852         * utils.c (internal_vproblem): Make "msg" const.
 853
 854 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 855
 856         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 857         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 858         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 859         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 860
 861 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 862
 863         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 864         function.
 865         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 866         of amd64_collect_native_gregset.
 867         (amd64_linux_nat_target::store_registers): Likewise.
 868
 869 2019-04-10  Tom Tromey  <tom@tromey.com>
 870
 871         * symtab.c (lookup_global_symbol_from_objfile)
 872         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 873         * objfiles.h (class separate_debug_iterator): New.
 874         (class separate_debug_range): New.
 875         (struct objfile) <separate_debug_objfiles>: New method.
 876         (objfile_separate_debug_iterate): Don't declare.
 877         * objfiles.c (separate_debug_iterator::operator++): Rename from
 878         objfile_separate_debug_iterate.
 879         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 880         iterator.
 881         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 882         iterator.
 883
 884 2019-04-10  Tom Tromey  <tom@tromey.com>
 885
 886         * symfile.c (reread_symbols): Remove old comment.
 887         * objfiles.c (free_all_objfiles): Fix a typo.
 888
 889 2019-04-10  Tom Tromey  <tom@tromey.com>
 890
 891         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 892         * minsyms.c (lookup_minimal_symbol): Use foreach.
 893         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 894         (lookup_minimal_symbol_solib_trampoline): Likewise.
 895         * symfile.c (reread_symbols): Use foreach.
 896
 897 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 898             Tom Tromey  <tromey@adacore.com>
 899
 900         PR rust/24414:
 901         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 902         (rust_lex_int_test): Change "value" to be LONGEST.
 903         (rust_lex_tests): Add test for long integer literal.
 904
 905 2019-04-09  Tom Tromey  <tromey@adacore.com>
 906
 907         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 908         to bool.
 909         (extended_remote_target::attach): Update.
 910         (remote_target::remote_notice_new_inferior): Update.
 911         (remote_target::add_current_inferior_and_thread): Update.
 912         * inferior.c (exit_inferior_1): Use "false".
 913         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 914
 915 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 916
 917         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 918         the "start" command.
 919
 920 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 921
 922         * python/py-inferior.c (infpy_thread_from_thread_handle):
 923         Adjust comments to reflect renaming of thread_from_thread_handle
 924         to thread_from_handle.  Adjust keywords.  Fix type error message.
 925         (inferior_object_methods): Add thread_from_handle.  Retain
 926         thread_from_thread_handle, but mark it as deprecated.
 927
 928 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 929
 930         * gdbthread.h (find_thread_by_handle): Revise declaration.
 931         * thread.c (find_thread_by_handle): Likewise.  Adjust
 932         implementation too.
 933         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 934         support for buffer objects as handles.
 935
 936 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 937
 938         * python/py-infthread.c (thpy_thread_handle): New function.
 939         (thread_object_methods): Register thpy_thread_handle.
 940
 941 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 942
 943         * gdbthread.h (thread_to_thread_handle): Declare.
 944         * thread.c (gdbtypes.h): Include.
 945         (thread_to_thread_handle): New function.
 946
 947         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 948         (target_thread_info_to_thread_handle): Declare.
 949         * target.c (target_thread_info_to_thread_handle): New function.
 950         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 951         * target-delegates.c: Regenerate.
 952
 953         * linux-thread-db.c (class thread_db_target): Add method
 954         thread_info_to_thread_handle.
 955         (thread_db_target::thread_info_to_thread_handle): Define.
 956         * remote.c (class remote_target): Add new method
 957         thread_info_to_thread_handle.
 958         (remote_target::thread_info_to_thread_handle): Define.
 959
 960 2019-04-08  Pedro Alves  <palves@redhat.com>
 961
 962         * common/common-exceptions.c (throw_exception): Don't create
 963         named object to throw; throw directly.
 964         (throw_it): Likewise.  Don't initialize gdb_exception::message
 965         here, with new; pass FMT and AP to the ctor instead.
 966         * common/common-exceptions.h: Include <string>.
 967         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 968         const char *, va_list)): New ctor.  Use std::make_shared.
 969         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 970         errors)): Delete.
 971         (gdb_exception_error::gdb_exception_error(enum errors, const char
 972         *, va_list)): New.
 973         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 974         Add assertion.
 975         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 976         errors)): Delete.
 977         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 978         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 979         Add assertion.
 980
 981 2019-04-08  Tom Tromey  <tom@tromey.com>
 982
 983         * valops.c (value_rtti_indirect_type): Replace throw_exception
 984         with throw.
 985         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 986         with throw.
 987         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 988         throw.
 989         * target.c (target_translate_tls_address): Replace throw_exception
 990         with throw.
 991         * stack.c (frame_apply_command_count): Replace throw_exception
 992         with throw.
 993         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 994         throw.
 995         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 996         with throw.
 997         * rs6000-tdep.c (rs6000_frame_cache)
 998         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 999         * remote.c: Replace throw_exception with throw.
1000         * record-full.c (record_full_message, record_full_wait_1)
1001         (record_full_restore): Replace throw_exception with throw.
1002         * record-btrace.c:
1003         (get_thread_current_frame_id, record_btrace_start_replaying)
1004         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1005         (cmd_record_btrace_start): Replace throw_exception with throw.
1006         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1007         throw.
1008         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1009         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1010         * linespec.c:
1011         (find_linespec_symbols): Replace throw_exception with throw.
1012         * infrun.c (displaced_step_prepare, resume): Replace
1013         throw_exception with throw.
1014         * infcmd.c (post_create_inferior): Replace throw_exception with
1015         throw.
1016         * inf-loop.c (inferior_event_handler): Replace throw_exception
1017         with throw.
1018         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1019         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1020         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1021         (get_prev_frame_always, get_frame_pc_if_available)
1022         (get_frame_address_in_block_if_available, get_frame_language):
1023         Replace throw_exception with throw.
1024         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1025         throw_exception with throw.
1026         * eval.c (fetch_subexp_value, evaluate_var_value)
1027         (evaluate_funcall, evaluate_subexp_standard): Replace
1028         throw_exception with throw.
1029         * dwarf2loc.c (call_site_find_chain)
1030         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1031         Replace throw_exception with throw.
1032         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1033         with throw.
1034         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1035         throw.
1036         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1037         * completer.c (complete_line_internal): Replace throw_exception
1038         with throw.
1039         * compile/compile-object-run.c (compile_object_run): Replace
1040         throw_exception with throw.
1041         * cli/cli-script.c (process_next_line): Replace throw_exception
1042         with throw.
1043         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1044         (btrace_enable, btrace_maint_update_pt_packets): Replace
1045         throw_exception with throw.
1046         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1047         throw_exception with throw.
1048         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1049         throw_exception with throw.
1050         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1051         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1052         * aarch64-tdep.c (aarch64_make_prologue_cache)
1053         (aarch64_make_stub_cache): Replace throw_exception with throw.
1054
1055 2019-04-08  Tom Tromey  <tom@tromey.com>
1056
1057         * common/common-exceptions.c (throw_exception): Rename from
1058         throw_exception_cxx.  Remove old copy.  Make argument const.
1059         (throw_it): Create and throw exception objects directly.
1060         * common/common-exceptions.h (throw_exception): Make argument
1061         const.
1062         (struct gdb_exception_error): Add constructor.
1063         (struct gdb_exception_quit): Add constructor.
1064
1065 2019-04-08  Tom Tromey  <tom@tromey.com>
1066
1067         * common/common-exceptions.h (exception_rethrow): Don't declare.
1068         (TRY_SJLJ): Update comment.
1069         (TRY, CATCH, END_CATCH): Remove.
1070         * common/common-exceptions.c (exception_rethrow): Remove.
1071
1072 2019-04-08  Tom Tromey  <tom@tromey.com>
1073
1074         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1075         Remove.
1076         (gdb_exception_error): Rename from
1077         gdb_exception_RETURN_MASK_ERROR.
1078         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1079         (gdb_quit_bad_alloc): Update.
1080         * aarch64-tdep.c: Update.
1081         * ada-lang.c: Update.
1082         * ada-typeprint.c: Update.
1083         * ada-valprint.c: Update.
1084         * amd64-tdep.c: Update.
1085         * arch-utils.c: Update.
1086         * break-catch-throw.c: Update.
1087         * breakpoint.c: Update.
1088         * btrace.c: Update.
1089         * c-varobj.c: Update.
1090         * cli/cli-cmds.c: Update.
1091         * cli/cli-interp.c: Update.
1092         * cli/cli-script.c: Update.
1093         * common/common-exceptions.c: Update.
1094         * common/new-op.c: Update.
1095         * common/selftest.c: Update.
1096         * compile/compile-c-symbols.c: Update.
1097         * compile/compile-cplus-symbols.c: Update.
1098         * compile/compile-object-load.c: Update.
1099         * compile/compile-object-run.c: Update.
1100         * completer.c: Update.
1101         * corelow.c: Update.
1102         * cp-abi.c: Update.
1103         * cp-support.c: Update.
1104         * cp-valprint.c: Update.
1105         * darwin-nat.c: Update.
1106         * disasm-selftests.c: Update.
1107         * dtrace-probe.c: Update.
1108         * dwarf-index-cache.c: Update.
1109         * dwarf-index-write.c: Update.
1110         * dwarf2-frame-tailcall.c: Update.
1111         * dwarf2-frame.c: Update.
1112         * dwarf2loc.c: Update.
1113         * dwarf2read.c: Update.
1114         * eval.c: Update.
1115         * event-loop.c: Update.
1116         * event-top.c: Update.
1117         * exec.c: Update.
1118         * f-valprint.c: Update.
1119         * fbsd-tdep.c: Update.
1120         * frame-unwind.c: Update.
1121         * frame.c: Update.
1122         * gdbtypes.c: Update.
1123         * gnu-v3-abi.c: Update.
1124         * guile/guile-internal.h: Update.
1125         * guile/scm-block.c: Update.
1126         * guile/scm-breakpoint.c: Update.
1127         * guile/scm-cmd.c: Update.
1128         * guile/scm-disasm.c: Update.
1129         * guile/scm-frame.c: Update.
1130         * guile/scm-lazy-string.c: Update.
1131         * guile/scm-math.c: Update.
1132         * guile/scm-param.c: Update.
1133         * guile/scm-ports.c: Update.
1134         * guile/scm-pretty-print.c: Update.
1135         * guile/scm-symbol.c: Update.
1136         * guile/scm-symtab.c: Update.
1137         * guile/scm-type.c: Update.
1138         * guile/scm-value.c: Update.
1139         * i386-linux-tdep.c: Update.
1140         * i386-tdep.c: Update.
1141         * inf-loop.c: Update.
1142         * infcall.c: Update.
1143         * infcmd.c: Update.
1144         * infrun.c: Update.
1145         * jit.c: Update.
1146         * language.c: Update.
1147         * linespec.c: Update.
1148         * linux-fork.c: Update.
1149         * linux-nat.c: Update.
1150         * linux-tdep.c: Update.
1151         * linux-thread-db.c: Update.
1152         * main.c: Update.
1153         * mi/mi-cmd-break.c: Update.
1154         * mi/mi-cmd-stack.c: Update.
1155         * mi/mi-interp.c: Update.
1156         * mi/mi-main.c: Update.
1157         * objc-lang.c: Update.
1158         * p-valprint.c: Update.
1159         * parse.c: Update.
1160         * ppc-linux-tdep.c: Update.
1161         * printcmd.c: Update.
1162         * python/py-arch.c: Update.
1163         * python/py-breakpoint.c: Update.
1164         * python/py-cmd.c: Update.
1165         * python/py-finishbreakpoint.c: Update.
1166         * python/py-frame.c: Update.
1167         * python/py-framefilter.c: Update.
1168         * python/py-gdb-readline.c: Update.
1169         * python/py-inferior.c: Update.
1170         * python/py-infthread.c: Update.
1171         * python/py-lazy-string.c: Update.
1172         * python/py-linetable.c: Update.
1173         * python/py-objfile.c: Update.
1174         * python/py-param.c: Update.
1175         * python/py-prettyprint.c: Update.
1176         * python/py-progspace.c: Update.
1177         * python/py-record-btrace.c: Update.
1178         * python/py-record.c: Update.
1179         * python/py-symbol.c: Update.
1180         * python/py-type.c: Update.
1181         * python/py-unwind.c: Update.
1182         * python/py-utils.c: Update.
1183         * python/py-value.c: Update.
1184         * python/python.c: Update.
1185         * record-btrace.c: Update.
1186         * record-full.c: Update.
1187         * remote-fileio.c: Update.
1188         * remote.c: Update.
1189         * riscv-tdep.c: Update.
1190         * rs6000-aix-tdep.c: Update.
1191         * rs6000-tdep.c: Update.
1192         * rust-exp.y: Update.
1193         * rust-lang.c: Update.
1194         * s390-tdep.c: Update.
1195         * selftest-arch.c: Update.
1196         * solib-dsbt.c: Update.
1197         * solib-frv.c: Update.
1198         * solib-spu.c: Update.
1199         * solib-svr4.c: Update.
1200         * solib.c: Update.
1201         * sparc64-linux-tdep.c: Update.
1202         * stack.c: Update.
1203         * symfile-mem.c: Update.
1204         * symmisc.c: Update.
1205         * target.c: Update.
1206         * thread.c: Update.
1207         * top.c: Update.
1208         * tracefile-tfile.c: Update.
1209         * tui/tui.c: Update.
1210         * typeprint.c: Update.
1211         * unittests/cli-utils-selftests.c: Update.
1212         * unittests/parse-connection-spec-selftests.c: Update.
1213         * valops.c: Update.
1214         * valprint.c: Update.
1215         * value.c: Update.
1216         * varobj.c: Update.
1217         * windows-nat.c: Update.
1218         * x86-linux-nat.c: Update.
1219         * xml-support.c: Update.
1220
1221 2019-04-08  Tom Tromey  <tom@tromey.com>
1222
1223         * xml-support.c: Use C++ exception handling.
1224         * x86-linux-nat.c: Use C++ exception handling.
1225         * windows-nat.c: Use C++ exception handling.
1226         * varobj.c: Use C++ exception handling.
1227         * value.c: Use C++ exception handling.
1228         * valprint.c: Use C++ exception handling.
1229         * valops.c: Use C++ exception handling.
1230         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1231         handling.
1232         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1233         * typeprint.c: Use C++ exception handling.
1234         * tui/tui.c: Use C++ exception handling.
1235         * tracefile-tfile.c: Use C++ exception handling.
1236         * top.c: Use C++ exception handling.
1237         * thread.c: Use C++ exception handling.
1238         * target.c: Use C++ exception handling.
1239         * symmisc.c: Use C++ exception handling.
1240         * symfile-mem.c: Use C++ exception handling.
1241         * stack.c: Use C++ exception handling.
1242         * sparc64-linux-tdep.c: Use C++ exception handling.
1243         * solib.c: Use C++ exception handling.
1244         * solib-svr4.c: Use C++ exception handling.
1245         * solib-spu.c: Use C++ exception handling.
1246         * solib-frv.c: Use C++ exception handling.
1247         * solib-dsbt.c: Use C++ exception handling.
1248         * selftest-arch.c: Use C++ exception handling.
1249         * s390-tdep.c: Use C++ exception handling.
1250         * rust-lang.c: Use C++ exception handling.
1251         * rust-exp.y: Use C++ exception handling.
1252         * rs6000-tdep.c: Use C++ exception handling.
1253         * rs6000-aix-tdep.c: Use C++ exception handling.
1254         * riscv-tdep.c: Use C++ exception handling.
1255         * remote.c: Use C++ exception handling.
1256         * remote-fileio.c: Use C++ exception handling.
1257         * record-full.c: Use C++ exception handling.
1258         * record-btrace.c: Use C++ exception handling.
1259         * python/python.c: Use C++ exception handling.
1260         * python/py-value.c: Use C++ exception handling.
1261         * python/py-utils.c: Use C++ exception handling.
1262         * python/py-unwind.c: Use C++ exception handling.
1263         * python/py-type.c: Use C++ exception handling.
1264         * python/py-symbol.c: Use C++ exception handling.
1265         * python/py-record.c: Use C++ exception handling.
1266         * python/py-record-btrace.c: Use C++ exception handling.
1267         * python/py-progspace.c: Use C++ exception handling.
1268         * python/py-prettyprint.c: Use C++ exception handling.
1269         * python/py-param.c: Use C++ exception handling.
1270         * python/py-objfile.c: Use C++ exception handling.
1271         * python/py-linetable.c: Use C++ exception handling.
1272         * python/py-lazy-string.c: Use C++ exception handling.
1273         * python/py-infthread.c: Use C++ exception handling.
1274         * python/py-inferior.c: Use C++ exception handling.
1275         * python/py-gdb-readline.c: Use C++ exception handling.
1276         * python/py-framefilter.c: Use C++ exception handling.
1277         * python/py-frame.c: Use C++ exception handling.
1278         * python/py-finishbreakpoint.c: Use C++ exception handling.
1279         * python/py-cmd.c: Use C++ exception handling.
1280         * python/py-breakpoint.c: Use C++ exception handling.
1281         * python/py-arch.c: Use C++ exception handling.
1282         * printcmd.c: Use C++ exception handling.
1283         * ppc-linux-tdep.c: Use C++ exception handling.
1284         * parse.c: Use C++ exception handling.
1285         * p-valprint.c: Use C++ exception handling.
1286         * objc-lang.c: Use C++ exception handling.
1287         * mi/mi-main.c: Use C++ exception handling.
1288         * mi/mi-interp.c: Use C++ exception handling.
1289         * mi/mi-cmd-stack.c: Use C++ exception handling.
1290         * mi/mi-cmd-break.c: Use C++ exception handling.
1291         * main.c: Use C++ exception handling.
1292         * linux-thread-db.c: Use C++ exception handling.
1293         * linux-tdep.c: Use C++ exception handling.
1294         * linux-nat.c: Use C++ exception handling.
1295         * linux-fork.c: Use C++ exception handling.
1296         * linespec.c: Use C++ exception handling.
1297         * language.c: Use C++ exception handling.
1298         * jit.c: Use C++ exception handling.
1299         * infrun.c: Use C++ exception handling.
1300         * infcmd.c: Use C++ exception handling.
1301         * infcall.c: Use C++ exception handling.
1302         * inf-loop.c: Use C++ exception handling.
1303         * i386-tdep.c: Use C++ exception handling.
1304         * i386-linux-tdep.c: Use C++ exception handling.
1305         * guile/scm-value.c: Use C++ exception handling.
1306         * guile/scm-type.c: Use C++ exception handling.
1307         * guile/scm-symtab.c: Use C++ exception handling.
1308         * guile/scm-symbol.c: Use C++ exception handling.
1309         * guile/scm-pretty-print.c: Use C++ exception handling.
1310         * guile/scm-ports.c: Use C++ exception handling.
1311         * guile/scm-param.c: Use C++ exception handling.
1312         * guile/scm-math.c: Use C++ exception handling.
1313         * guile/scm-lazy-string.c: Use C++ exception handling.
1314         * guile/scm-frame.c: Use C++ exception handling.
1315         * guile/scm-disasm.c: Use C++ exception handling.
1316         * guile/scm-cmd.c: Use C++ exception handling.
1317         * guile/scm-breakpoint.c: Use C++ exception handling.
1318         * guile/scm-block.c: Use C++ exception handling.
1319         * guile/guile-internal.h: Use C++ exception handling.
1320         * gnu-v3-abi.c: Use C++ exception handling.
1321         * gdbtypes.c: Use C++ exception handling.
1322         * frame.c: Use C++ exception handling.
1323         * frame-unwind.c: Use C++ exception handling.
1324         * fbsd-tdep.c: Use C++ exception handling.
1325         * f-valprint.c: Use C++ exception handling.
1326         * exec.c: Use C++ exception handling.
1327         * event-top.c: Use C++ exception handling.
1328         * event-loop.c: Use C++ exception handling.
1329         * eval.c: Use C++ exception handling.
1330         * dwarf2read.c: Use C++ exception handling.
1331         * dwarf2loc.c: Use C++ exception handling.
1332         * dwarf2-frame.c: Use C++ exception handling.
1333         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1334         * dwarf-index-write.c: Use C++ exception handling.
1335         * dwarf-index-cache.c: Use C++ exception handling.
1336         * dtrace-probe.c: Use C++ exception handling.
1337         * disasm-selftests.c: Use C++ exception handling.
1338         * darwin-nat.c: Use C++ exception handling.
1339         * cp-valprint.c: Use C++ exception handling.
1340         * cp-support.c: Use C++ exception handling.
1341         * cp-abi.c: Use C++ exception handling.
1342         * corelow.c: Use C++ exception handling.
1343         * completer.c: Use C++ exception handling.
1344         * compile/compile-object-run.c: Use C++ exception handling.
1345         * compile/compile-object-load.c: Use C++ exception handling.
1346         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1347         * compile/compile-c-symbols.c: Use C++ exception handling.
1348         * common/selftest.c: Use C++ exception handling.
1349         * common/new-op.c: Use C++ exception handling.
1350         * cli/cli-script.c: Use C++ exception handling.
1351         * cli/cli-interp.c: Use C++ exception handling.
1352         * cli/cli-cmds.c: Use C++ exception handling.
1353         * c-varobj.c: Use C++ exception handling.
1354         * btrace.c: Use C++ exception handling.
1355         * breakpoint.c: Use C++ exception handling.
1356         * break-catch-throw.c: Use C++ exception handling.
1357         * arch-utils.c: Use C++ exception handling.
1358         * amd64-tdep.c: Use C++ exception handling.
1359         * ada-valprint.c: Use C++ exception handling.
1360         * ada-typeprint.c: Use C++ exception handling.
1361         * ada-lang.c: Use C++ exception handling.
1362         * aarch64-tdep.c: Use C++ exception handling.
1363
1364 2019-04-08  Tom Tromey  <tom@tromey.com>
1365
1366         * xml-support.c (gdb_xml_parser::parse): Update.
1367         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1368         * value.c (show_convenience): Update.
1369         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1370         (test_parse_flags_qcs): Update.
1371         * thread.c (thr_try_catch_cmd): Update.
1372         * target.c (target_translate_tls_address): Update.
1373         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1374         (info_frame_command_core, frame_apply_command_count): Update.
1375         * rust-exp.y (rust_lex_exception_test): Update.
1376         * riscv-tdep.c (riscv_print_one_register_info): Update.
1377         * remote.c (remote_target::enable_btrace): Update.
1378         * record-btrace.c (record_btrace_enable_warn): Update.
1379         * python/py-utils.c (gdbpy_convert_exception): Update.
1380         * printcmd.c (do_one_display, print_variable_and_value): Update.
1381         * mi/mi-main.c (mi_print_exception): Update.
1382         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1383         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1384         * linux-nat.c (linux_nat_target::attach): Update.
1385         * linux-fork.c (class scoped_switch_fork_info): Update.
1386         * infrun.c (displaced_step_prepare): Update.
1387         * infcall.c (call_function_by_hand_dummy): Update.
1388         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1389         * gnu-v3-abi.c (print_one_vtable): Update.
1390         * frame.c (get_prev_frame_always): Update.
1391         * f-valprint.c (info_common_command_for_block): Update.
1392         * exec.c (try_open_exec_file): Update.
1393         * exceptions.c (print_exception, exception_print)
1394         (exception_fprintf, exception_print_same): Update.
1395         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1396         * dwarf-index-cache.c (index_cache::store)
1397         (index_cache::lookup_gdb_index): Update.
1398         * darwin-nat.c (maybe_cache_shell): Update.
1399         * cp-valprint.c (cp_print_value_fields): Update.
1400         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1401         (gcc_cplus_symbol_address): Update.
1402         * compile/compile-c-symbols.c (gcc_convert_symbol)
1403         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1404         * common/selftest.c: Update.
1405         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1406         a std::string.
1407         (exception_try_scope_entry, exception_try_scope_exit): Don't
1408         declare.
1409         (struct exception_try_scope): Remove.
1410         (TRY): Don't use exception_try_scope.
1411         (struct gdb_exception): Add constructor, operator=.
1412         <what>: New method.
1413         (struct gdb_exception_RETURN_MASK_ALL)
1414         (struct gdb_exception_RETURN_MASK_ERROR)
1415         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1416         (struct gdb_quit_bad_alloc): Update.
1417         * common/common-exceptions.c (exception_none): Change
1418         initializer.
1419         (struct catcher) <state, exception>: Initialize inline.
1420         <prev>: Remove member.
1421         (current_catcher): Remove.
1422         (catchers): New global.
1423         (exceptions_state_mc_init): Simplify.
1424         (catcher_pop): Remove.
1425         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1426         (try_scope_depth, exception_try_scope_entry)
1427         (exception_try_scope_exit): Remove.
1428         (throw_exception_sjlj): Update.
1429         (exception_messages, exception_messages_size): Remove.
1430         (throw_it): Simplify.
1431         (gdb_exception_sliced_copy): Remove.
1432         (throw_exception_cxx): Update.
1433         * cli/cli-script.c (script_from_file): Update.
1434         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1435         Update.
1436         * ada-valprint.c (ada_val_print): Update.
1437         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1438         (create_excep_cond_exprs): Update.
1439
1440 2019-04-08  Tom Tromey  <tom@tromey.com>
1441
1442         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1443         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1444         (TRY, CATCH, END_CATCH): Remove some definitions.
1445         * common/common-exceptions.c: Don't use GDB_XCPT.
1446         (catcher_list_size): Remove.
1447         (throw_exception, throw_it): Simplify.
1448
1449 2019-04-05  Tom Tromey  <tom@tromey.com>
1450
1451         Revert the header-sorting patch.
1452         * ft32-tdep.c: Revert.
1453         * frv-tdep.c: Revert.
1454         * frv-linux-tdep.c: Revert.
1455         * frame.c: Revert.
1456         * frame-unwind.c: Revert.
1457         * frame-base.c: Revert.
1458         * fork-child.c: Revert.
1459         * findvar.c: Revert.
1460         * findcmd.c: Revert.
1461         * filesystem.c: Revert.
1462         * filename-seen-cache.h: Revert.
1463         * filename-seen-cache.c: Revert.
1464         * fbsd-tdep.c: Revert.
1465         * fbsd-nat.h: Revert.
1466         * fbsd-nat.c: Revert.
1467         * f-valprint.c: Revert.
1468         * f-typeprint.c: Revert.
1469         * f-lang.c: Revert.
1470         * extension.h: Revert.
1471         * extension.c: Revert.
1472         * extension-priv.h: Revert.
1473         * expprint.c: Revert.
1474         * exec.h: Revert.
1475         * exec.c: Revert.
1476         * exceptions.c: Revert.
1477         * event-top.c: Revert.
1478         * event-loop.c: Revert.
1479         * eval.c: Revert.
1480         * elfread.c: Revert.
1481         * dwarf2read.h: Revert.
1482         * dwarf2read.c: Revert.
1483         * dwarf2loc.c: Revert.
1484         * dwarf2expr.h: Revert.
1485         * dwarf2expr.c: Revert.
1486         * dwarf2-frame.c: Revert.
1487         * dwarf2-frame-tailcall.c: Revert.
1488         * dwarf-index-write.h: Revert.
1489         * dwarf-index-write.c: Revert.
1490         * dwarf-index-common.c: Revert.
1491         * dwarf-index-cache.h: Revert.
1492         * dwarf-index-cache.c: Revert.
1493         * dummy-frame.c: Revert.
1494         * dtrace-probe.c: Revert.
1495         * disasm.h: Revert.
1496         * disasm.c: Revert.
1497         * disasm-selftests.c: Revert.
1498         * dictionary.c: Revert.
1499         * dicos-tdep.c: Revert.
1500         * demangle.c: Revert.
1501         * dcache.h: Revert.
1502         * dcache.c: Revert.
1503         * darwin-nat.h: Revert.
1504         * darwin-nat.c: Revert.
1505         * darwin-nat-info.c: Revert.
1506         * d-valprint.c: Revert.
1507         * d-namespace.c: Revert.
1508         * d-lang.c: Revert.
1509         * ctf.c: Revert.
1510         * csky-tdep.c: Revert.
1511         * csky-linux-tdep.c: Revert.
1512         * cris-tdep.c: Revert.
1513         * cris-linux-tdep.c: Revert.
1514         * cp-valprint.c: Revert.
1515         * cp-support.c: Revert.
1516         * cp-namespace.c: Revert.
1517         * cp-abi.c: Revert.
1518         * corelow.c: Revert.
1519         * corefile.c: Revert.
1520         * continuations.c: Revert.
1521         * completer.h: Revert.
1522         * completer.c: Revert.
1523         * complaints.c: Revert.
1524         * coffread.c: Revert.
1525         * coff-pe-read.c: Revert.
1526         * cli-out.h: Revert.
1527         * cli-out.c: Revert.
1528         * charset.c: Revert.
1529         * c-varobj.c: Revert.
1530         * c-valprint.c: Revert.
1531         * c-typeprint.c: Revert.
1532         * c-lang.c: Revert.
1533         * buildsym.c: Revert.
1534         * buildsym-legacy.c: Revert.
1535         * build-id.h: Revert.
1536         * build-id.c: Revert.
1537         * btrace.c: Revert.
1538         * bsd-uthread.c: Revert.
1539         * breakpoint.h: Revert.
1540         * breakpoint.c: Revert.
1541         * break-catch-throw.c: Revert.
1542         * break-catch-syscall.c: Revert.
1543         * break-catch-sig.c: Revert.
1544         * blockframe.c: Revert.
1545         * block.c: Revert.
1546         * bfin-tdep.c: Revert.
1547         * bfin-linux-tdep.c: Revert.
1548         * bfd-target.c: Revert.
1549         * bcache.c: Revert.
1550         * ax-general.c: Revert.
1551         * ax-gdb.h: Revert.
1552         * ax-gdb.c: Revert.
1553         * avr-tdep.c: Revert.
1554         * auxv.c: Revert.
1555         * auto-load.c: Revert.
1556         * arm-wince-tdep.c: Revert.
1557         * arm-tdep.c: Revert.
1558         * arm-symbian-tdep.c: Revert.
1559         * arm-pikeos-tdep.c: Revert.
1560         * arm-obsd-tdep.c: Revert.
1561         * arm-nbsd-tdep.c: Revert.
1562         * arm-nbsd-nat.c: Revert.
1563         * arm-linux-tdep.c: Revert.
1564         * arm-linux-nat.c: Revert.
1565         * arm-fbsd-tdep.c: Revert.
1566         * arm-fbsd-nat.c: Revert.
1567         * arm-bsd-tdep.c: Revert.
1568         * arch-utils.c: Revert.
1569         * arc-tdep.c: Revert.
1570         * arc-newlib-tdep.c: Revert.
1571         * annotate.h: Revert.
1572         * annotate.c: Revert.
1573         * amd64-windows-tdep.c: Revert.
1574         * amd64-windows-nat.c: Revert.
1575         * amd64-tdep.c: Revert.
1576         * amd64-sol2-tdep.c: Revert.
1577         * amd64-obsd-tdep.c: Revert.
1578         * amd64-obsd-nat.c: Revert.
1579         * amd64-nbsd-tdep.c: Revert.
1580         * amd64-nbsd-nat.c: Revert.
1581         * amd64-nat.c: Revert.
1582         * amd64-linux-tdep.c: Revert.
1583         * amd64-linux-nat.c: Revert.
1584         * amd64-fbsd-tdep.c: Revert.
1585         * amd64-fbsd-nat.c: Revert.
1586         * amd64-dicos-tdep.c: Revert.
1587         * amd64-darwin-tdep.c: Revert.
1588         * amd64-bsd-nat.c: Revert.
1589         * alpha-tdep.c: Revert.
1590         * alpha-obsd-tdep.c: Revert.
1591         * alpha-nbsd-tdep.c: Revert.
1592         * alpha-mdebug-tdep.c: Revert.
1593         * alpha-linux-tdep.c: Revert.
1594         * alpha-linux-nat.c: Revert.
1595         * alpha-bsd-tdep.c: Revert.
1596         * alpha-bsd-nat.c: Revert.
1597         * aix-thread.c: Revert.
1598         * agent.c: Revert.
1599         * addrmap.c: Revert.
1600         * ada-varobj.c: Revert.
1601         * ada-valprint.c: Revert.
1602         * ada-typeprint.c: Revert.
1603         * ada-tasks.c: Revert.
1604         * ada-lang.c: Revert.
1605         * aarch64-tdep.c: Revert.
1606         * aarch64-ravenscar-thread.c: Revert.
1607         * aarch64-newlib-tdep.c: Revert.
1608         * aarch64-linux-tdep.c: Revert.
1609         * aarch64-linux-nat.c: Revert.
1610         * aarch64-fbsd-tdep.c: Revert.
1611         * aarch64-fbsd-nat.c: Revert.
1612         * aarch32-linux-nat.c: Revert.
1613
1614 2019-04-05  Tom Tromey  <tom@tromey.com>
1615
1616         * ft32-tdep.c: Sort headers.
1617         * frv-tdep.c: Sort headers.
1618         * frv-linux-tdep.c: Sort headers.
1619         * frame.c: Sort headers.
1620         * frame-unwind.c: Sort headers.
1621         * frame-base.c: Sort headers.
1622         * fork-child.c: Sort headers.
1623         * findvar.c: Sort headers.
1624         * findcmd.c: Sort headers.
1625         * filesystem.c: Sort headers.
1626         * filename-seen-cache.h: Sort headers.
1627         * filename-seen-cache.c: Sort headers.
1628         * fbsd-tdep.c: Sort headers.
1629         * fbsd-nat.h: Sort headers.
1630         * fbsd-nat.c: Sort headers.
1631         * f-valprint.c: Sort headers.
1632         * f-typeprint.c: Sort headers.
1633         * f-lang.c: Sort headers.
1634         * extension.h: Sort headers.
1635         * extension.c: Sort headers.
1636         * extension-priv.h: Sort headers.
1637         * expprint.c: Sort headers.
1638         * exec.h: Sort headers.
1639         * exec.c: Sort headers.
1640         * exceptions.c: Sort headers.
1641         * event-top.c: Sort headers.
1642         * event-loop.c: Sort headers.
1643         * eval.c: Sort headers.
1644         * elfread.c: Sort headers.
1645         * dwarf2read.h: Sort headers.
1646         * dwarf2read.c: Sort headers.
1647         * dwarf2loc.c: Sort headers.
1648         * dwarf2expr.h: Sort headers.
1649         * dwarf2expr.c: Sort headers.
1650         * dwarf2-frame.c: Sort headers.
1651         * dwarf2-frame-tailcall.c: Sort headers.
1652         * dwarf-index-write.h: Sort headers.
1653         * dwarf-index-write.c: Sort headers.
1654         * dwarf-index-common.c: Sort headers.
1655         * dwarf-index-cache.h: Sort headers.
1656         * dwarf-index-cache.c: Sort headers.
1657         * dummy-frame.c: Sort headers.
1658         * dtrace-probe.c: Sort headers.
1659         * disasm.h: Sort headers.
1660         * disasm.c: Sort headers.
1661         * disasm-selftests.c: Sort headers.
1662         * dictionary.c: Sort headers.
1663         * dicos-tdep.c: Sort headers.
1664         * demangle.c: Sort headers.
1665         * dcache.h: Sort headers.
1666         * dcache.c: Sort headers.
1667         * darwin-nat.h: Sort headers.
1668         * darwin-nat.c: Sort headers.
1669         * darwin-nat-info.c: Sort headers.
1670         * d-valprint.c: Sort headers.
1671         * d-namespace.c: Sort headers.
1672         * d-lang.c: Sort headers.
1673         * ctf.c: Sort headers.
1674         * csky-tdep.c: Sort headers.
1675         * csky-linux-tdep.c: Sort headers.
1676         * cris-tdep.c: Sort headers.
1677         * cris-linux-tdep.c: Sort headers.
1678         * cp-valprint.c: Sort headers.
1679         * cp-support.c: Sort headers.
1680         * cp-namespace.c: Sort headers.
1681         * cp-abi.c: Sort headers.
1682         * corelow.c: Sort headers.
1683         * corefile.c: Sort headers.
1684         * continuations.c: Sort headers.
1685         * completer.h: Sort headers.
1686         * completer.c: Sort headers.
1687         * complaints.c: Sort headers.
1688         * coffread.c: Sort headers.
1689         * coff-pe-read.c: Sort headers.
1690         * cli-out.h: Sort headers.
1691         * cli-out.c: Sort headers.
1692         * charset.c: Sort headers.
1693         * c-varobj.c: Sort headers.
1694         * c-valprint.c: Sort headers.
1695         * c-typeprint.c: Sort headers.
1696         * c-lang.c: Sort headers.
1697         * buildsym.c: Sort headers.
1698         * buildsym-legacy.c: Sort headers.
1699         * build-id.h: Sort headers.
1700         * build-id.c: Sort headers.
1701         * btrace.c: Sort headers.
1702         * bsd-uthread.c: Sort headers.
1703         * breakpoint.h: Sort headers.
1704         * breakpoint.c: Sort headers.
1705         * break-catch-throw.c: Sort headers.
1706         * break-catch-syscall.c: Sort headers.
1707         * break-catch-sig.c: Sort headers.
1708         * blockframe.c: Sort headers.
1709         * block.c: Sort headers.
1710         * bfin-tdep.c: Sort headers.
1711         * bfin-linux-tdep.c: Sort headers.
1712         * bfd-target.c: Sort headers.
1713         * bcache.c: Sort headers.
1714         * ax-general.c: Sort headers.
1715         * ax-gdb.h: Sort headers.
1716         * ax-gdb.c: Sort headers.
1717         * avr-tdep.c: Sort headers.
1718         * auxv.c: Sort headers.
1719         * auto-load.c: Sort headers.
1720         * arm-wince-tdep.c: Sort headers.
1721         * arm-tdep.c: Sort headers.
1722         * arm-symbian-tdep.c: Sort headers.
1723         * arm-pikeos-tdep.c: Sort headers.
1724         * arm-obsd-tdep.c: Sort headers.
1725         * arm-nbsd-tdep.c: Sort headers.
1726         * arm-nbsd-nat.c: Sort headers.
1727         * arm-linux-tdep.c: Sort headers.
1728         * arm-linux-nat.c: Sort headers.
1729         * arm-fbsd-tdep.c: Sort headers.
1730         * arm-fbsd-nat.c: Sort headers.
1731         * arm-bsd-tdep.c: Sort headers.
1732         * arch-utils.c: Sort headers.
1733         * arc-tdep.c: Sort headers.
1734         * arc-newlib-tdep.c: Sort headers.
1735         * annotate.h: Sort headers.
1736         * annotate.c: Sort headers.
1737         * amd64-windows-tdep.c: Sort headers.
1738         * amd64-windows-nat.c: Sort headers.
1739         * amd64-tdep.c: Sort headers.
1740         * amd64-sol2-tdep.c: Sort headers.
1741         * amd64-obsd-tdep.c: Sort headers.
1742         * amd64-obsd-nat.c: Sort headers.
1743         * amd64-nbsd-tdep.c: Sort headers.
1744         * amd64-nbsd-nat.c: Sort headers.
1745         * amd64-nat.c: Sort headers.
1746         * amd64-linux-tdep.c: Sort headers.
1747         * amd64-linux-nat.c: Sort headers.
1748         * amd64-fbsd-tdep.c: Sort headers.
1749         * amd64-fbsd-nat.c: Sort headers.
1750         * amd64-dicos-tdep.c: Sort headers.
1751         * amd64-darwin-tdep.c: Sort headers.
1752         * amd64-bsd-nat.c: Sort headers.
1753         * alpha-tdep.c: Sort headers.
1754         * alpha-obsd-tdep.c: Sort headers.
1755         * alpha-nbsd-tdep.c: Sort headers.
1756         * alpha-mdebug-tdep.c: Sort headers.
1757         * alpha-linux-tdep.c: Sort headers.
1758         * alpha-linux-nat.c: Sort headers.
1759         * alpha-bsd-tdep.c: Sort headers.
1760         * alpha-bsd-nat.c: Sort headers.
1761         * aix-thread.c: Sort headers.
1762         * agent.c: Sort headers.
1763         * addrmap.c: Sort headers.
1764         * ada-varobj.c: Sort headers.
1765         * ada-valprint.c: Sort headers.
1766         * ada-typeprint.c: Sort headers.
1767         * ada-tasks.c: Sort headers.
1768         * ada-lang.c: Sort headers.
1769         * aarch64-tdep.c: Sort headers.
1770         * aarch64-ravenscar-thread.c: Sort headers.
1771         * aarch64-newlib-tdep.c: Sort headers.
1772         * aarch64-linux-tdep.c: Sort headers.
1773         * aarch64-linux-nat.c: Sort headers.
1774         * aarch64-fbsd-tdep.c: Sort headers.
1775         * aarch64-fbsd-nat.c: Sort headers.
1776         * aarch32-linux-nat.c: Sort headers.
1777
1778 2019-04-04  Tom Tromey  <tom@tromey.com>
1779
1780         * varobj.c (varobj_create): Update.
1781         * rust-exp.y (struct rust_parser) <update_innermost_block,
1782         lookup_symbol>: New methods.
1783         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1784         Rename.
1785         (rust_parser::rust_lookup_type)
1786         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1787         * printcmd.c (display_command, do_one_display): Update.
1788         * parser-defs.h (struct parser_state) <parser_state>: Add
1789         "tracker" parameter.
1790         (block_tracker): New member.
1791         (class innermost_block_tracker) <innermost_block_tracker>: Add
1792         "types" parameter.
1793         <reset>: Remove method.
1794         (innermost_block): Don't declare.
1795         (null_post_parser): Update.
1796         * parse.c (innermost_block): Remove global.
1797         (write_dollar_variable): Update.
1798         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1799         Remove "tracker_types" parameter.
1800         (parse_expression): Add "tracker" parameter.
1801         (parse_expression_for_completion): Update.
1802         (null_post_parser): Add "tracker" parameter.
1803         * p-exp.y: Update rules.
1804         * m2-exp.y: Update rules.
1805         * language.h (struct language_defn) <la_post_parser>: Add
1806         "tracker" parameter.
1807         * go-exp.y: Update rules.
1808         * f-exp.y: Update rules.
1809         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1810         parameter.
1811         * d-exp.y: Update rules.
1812         * c-exp.y: Update rules.
1813         * breakpoint.c (set_breakpoint_condition): Create an
1814         innermost_block_tracker.
1815         (watch_command_1): Likewise.
1816         * ada-lang.c (resolve): Add "tracker" parameter.
1817         (resolve_subexp): Likewise.
1818         * ada-exp.y (write_var_from_sym): Update.
1819
1820 2019-04-04  Tom Tromey  <tom@tromey.com>
1821
1822         * type-stack.h: New file.
1823         * type-stack.c: New file.
1824         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1825         type-stack.h.
1826         (insert_into_type_stack, insert_type, push_type, push_type_int)
1827         (insert_type_address_space, pop_type, pop_type_int)
1828         (pop_typelist, pop_type_stack, append_type_stack)
1829         (push_type_stack, get_type_stack, push_typelist)
1830         (follow_type_instance_flags, follow_types): Don't declare.
1831         * parse.c (type_stack): Remove global.
1832         (parse_exp_in_context): Update.
1833         (insert_into_type_stack, insert_type, push_type, push_type_int)
1834         (insert_type_address_space, pop_type, pop_type_int)
1835         (pop_typelist, pop_type_stack, append_type_stack)
1836         (push_type_stack, get_type_stack, push_typelist)
1837         (follow_type_instance_flags, follow_types): Remove (moved to
1838         type-stack.c).
1839         * f-exp.y (type_stack): New global.
1840         Update rules.
1841         (push_kind_type, f_parse): Update.
1842         * d-exp.y (type_stack): New global.
1843         Update rules.
1844         (d_parse): Update.
1845         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1846         Update rules.
1847         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1848         (HFILES_NO_SRCDIR): Add type-stack.h.
1849
1850 2019-04-04  Tom Tromey  <tom@tromey.com>
1851
1852         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1853         (rust_parser::convert_ast_to_expression, rust_parse)
1854         (rust_lex_test_completion, rust_lex_tests): Update.
1855         * parser-defs.h (struct expr_completion_state): New.
1856         (struct parser_state) <parser_state>: Add completion parameter.
1857         <mark_struct_expression, mark_completion_tag>: New methods.
1858         <parse_completion, m_completion_state>: New members.
1859         (prefixify_expression, null_post_parser): Update.
1860         (mark_struct_expression, mark_completion_tag): Don't declare.
1861         * parse.c (parse_completion, expout_last_struct)
1862         (expout_tag_completion_type, expout_completion_name): Remove
1863         globals.
1864         (parser_state::mark_struct_expression)
1865         (parser_state::mark_completion_tag): Now methods.
1866         (prefixify_expression): Add last_struct parameter.
1867         (prefixify_subexp): Likewise.
1868         (parse_exp_1): Update.
1869         (parse_exp_in_context): Add cstate parameter.  Update.
1870         (parse_expression_for_completion): Create an
1871         expr_completion_state.
1872         (null_post_parser): Add "completion" parameter.
1873         * p-exp.y: Update rules.
1874         (yylex): Update.
1875         * language.h (struct language_defn) <la_post_parser>: Add
1876         "completing" parameter.
1877         * go-exp.y: Update rules.
1878         (lex_one_token): Update.
1879         * expression.h (parse_completion): Don't declare.
1880         * d-exp.y: Update rules.
1881         (lex_one_token): Update rules.
1882         * c-exp.y: Update rules.
1883         (lex_one_token): Update.
1884         * ada-lang.c (resolve): Add "parse_completion" parameter.
1885         (resolve_subexp): Likewise.
1886         (ada_resolve_function): Likewise.
1887
1888 2019-04-04  Tom Tromey  <tom@tromey.com>
1889
1890         * parser-defs.h (struct parser_state) <start_arglist,
1891         end_arglist>: New methods.
1892         <arglist_len, m_funcall_chain>: New members.
1893         (arglist_len, start_arglist, end_arglist): Don't declare.
1894         * parse.c (arglist_len, funcall_chain): Remove global.
1895         (start_arglist, end_arglist): Remove functions.
1896         (parse_exp_in_context): Update.
1897         * p-exp.y: Update rules.
1898         * m2-exp.y: Update rules.
1899         * go-exp.y: Update rules.
1900         * f-exp.y: Update rules.
1901         * d-exp.y: Update rules.
1902         * c-exp.y: Update rules.
1903
1904 2019-04-04  Tom Tromey  <tom@tromey.com>
1905
1906         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1907         lex_operator, push_back>: New methods.
1908         Update all rules.
1909         (rust_parser::lex_hex, lex_escape): Rename and update.
1910         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1911         (rust_parser::lex_operator): Rename and update.
1912         (rust_parser::lex_number, rustyylex, rustyyerror)
1913         (rust_lex_test_init, rust_lex_test_sequence)
1914         (rust_lex_test_push_back, rust_lex_tests): Update.
1915         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1916         parameter.
1917         <lexptr, prev_lexptr>: New members.
1918         (lexptr, prev_lexptr): Don't declare.
1919         * parse.c (lexptr, prev_lexptr): Remove globals.
1920         (parse_exp_in_context): Update.
1921         * p-exp.y (yylex, yyerror): Update.
1922         * m2-exp.y (parse_number, yylex, yyerror): Update.
1923         * go-exp.y (lex_one_token, yyerror): Update.
1924         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1925         * d-exp.y (lex_one_token, yyerror): Update.
1926         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1927         (lex_one_token, yyerror): Update.
1928         * ada-lex.l (YY_INPUT): Update.
1929         (rewind_to_char): Update.
1930         * ada-exp.y (yyerror): Update.
1931
1932 2019-04-04  Tom Tromey  <tom@tromey.com>
1933
1934         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1935         * parser-defs.h (struct parser_state) <parser_state>: Add new
1936         parameter.
1937         <comma_terminates>: New member.
1938         (comma_terminates): Don't declare global.
1939         * parse.c (comma_terminates): Remove global.
1940         (parse_exp_in_context): Update.
1941         * p-exp.y (yylex): Update.
1942         * m2-exp.y (yylex): Update.
1943         * go-exp.y (lex_one_token): Update.
1944         * f-exp.y (yylex): Update.
1945         * d-exp.y (lex_one_token): Update.
1946         * c-exp.y (lex_one_token): Update.
1947         * ada-lex.l: Update.
1948
1949 2019-04-04  Tom Tromey  <tom@tromey.com>
1950
1951         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1952         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1953         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1954         * parser-defs.h (paren_depth): Don't declare.
1955         * parse.c (paren_depth): Remove global.
1956         (parse_exp_in_context): Update.
1957         * p-exp.y (paren_depth): New global.
1958         (pascal_parse): Initialize it.
1959         * m2-exp.y (paren_depth): New global.
1960         (m2_parse): Initialize it.
1961         * go-exp.y (paren_depth): New global.
1962         (go_parse): Initialize it.
1963         * f-exp.y (paren_depth): New global.
1964         (f_parse): Initialize it.
1965         * d-exp.y (paren_depth): New global.
1966         (d_parse): Initialize it.
1967         * c-exp.y (paren_depth): New global.
1968         (c_parse): Initialize it.
1969         * ada-lex.l (paren_depth): New global.
1970         (lexer_init): Initialize it.
1971
1972 2019-04-04  Tom Tromey  <tom@tromey.com>
1973
1974         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1975         (rust_parser::convert_ast_to_type)
1976         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1977         * parser-defs.h (struct parser_state) <parser_state>: Add
1978         parameters.  Initialize new members.
1979         <expression_context_block, expression_context_pc>: New members.
1980         * parse.c (expression_context_block, expression_context_pc):
1981         Remove globals.
1982         (parse_exp_in_context): Update.
1983         * p-exp.y: Update all rules.
1984         (yylex): Update.
1985         * m2-exp.y: Update all rules.
1986         (yylex): Update.
1987         * go-exp.y (yylex): Update.
1988         * f-exp.y (yylex): Update.
1989         * d-exp.y: Update all rules.
1990         (yylex): Update.
1991         * c-exp.y: Update all rules.
1992         (lex_one_token, classify_name, yylex, c_parse): Update.
1993         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1994
1995 2019-04-04  Tom Tromey  <tom@tromey.com>
1996
1997         * gdbarch.h, gdbarch.c: Rebuild.
1998         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1999         * stap-probe.h:
2000         (struct stap_parse_info): Replace "parser_state" with
2001         "expr_builder".
2002         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2003         (parser_state): New class.
2004         * parse.c (expr_builder): Rename.
2005         (expr_builder::release): Rename.
2006         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2007         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2008         (write_exp_elt_longcst, write_exp_elt_floatcst)
2009         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2010         (write_exp_string_vector, write_exp_bitstring)
2011         (write_exp_msymbol, mark_struct_expression)
2012         (write_dollar_variable)
2013         (insert_type_address_space, increase_expout_size): Replace
2014         "parser_state" with "expr_builder".
2015         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2016         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2017         "parser_state" with "expr_builder".
2018
2019 2019-04-04  Tom Tromey  <tom@tromey.com>
2020
2021         * rust-exp.y: Replace "parse_language" with method call.
2022         * p-exp.y:
2023         (yylex): Replace "parse_language" with method call.
2024         * m2-exp.y:
2025         (yylex): Replace "parse_language" with method call.
2026         * go-exp.y (classify_name): Replace "parse_language" with method
2027         call.
2028         * f-exp.y (yylex): Replace "parse_language" with method call.
2029         * d-exp.y (lex_one_token): Replace "parse_language" with method
2030         call.
2031         * c-exp.y:
2032         (lex_one_token, classify_name, yylex): Replace "parse_language"
2033         with method call.
2034         * ada-exp.y (find_primitive_type, type_char)
2035         (type_system_address): Replace "parse_language" with method call.
2036
2037 2019-04-04  Tom Tromey  <tom@tromey.com>
2038
2039         * rust-exp.y: Replace "parse_gdbarch" with method call.
2040         * parse.c (write_dollar_variable, insert_type_address_space):
2041         Replace "parse_gdbarch" with method call.
2042         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2043         call.
2044         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2045         call.
2046         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2047         "parse_gdbarch" with method call.
2048         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2049         with method call.
2050         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2051         "parse_gdbarch" with method call.
2052         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2053         "parse_gdbarch" with method call.
2054         * c-exp.y (parse_type, parse_number, classify_name): Replace
2055         "parse_gdbarch" with method call.
2056         * ada-lex.l: Replace "parse_gdbarch" with method call.
2057         * ada-exp.y (parse_type, find_primitive_type, type_char)
2058         (type_system_address): Replace "parse_gdbarch" with method call.
2059
2060 2019-04-04  Tom Tromey  <tom@tromey.com>
2061
2062         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2063         * stap-probe.c (stap_parse_argument): Update.
2064         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2065         initial_size parameter.
2066         * rust-exp.y (rust_lex_tests): Update.
2067         * parse.c (parser_state): Update.
2068         (parse_exp_in_context): Update.
2069         * parser-defs.h (struct parser_state) <parser_state>: Remove
2070         "initial_size" parameter.
2071
2072 2019-04-04  Tom Tromey  <tom@tromey.com>
2073
2074         * parser-defs.h (increase_expout_size): Don't declare.
2075         * parse.c (increase_expout_size): Now static.
2076
2077 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2078
2079         * gnu-nat.c (gnu_nat_target::wait): Fix
2080         target_waitstatus_to_string call.
2081
2082 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * eval.c (evaluate_subexp_standard): Handle internal functions
2085         during Fortran function call handling.
2086
2087 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * NEWS: Mention new internal functions.
2090         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2091         (read_base_type): Use dwarf2_init_complex_target_type.
2092         * value.c (creal_internal_fn): New function.
2093         (cimag_internal_fn): New function.
2094         (_initialize_values): Register new internal functions.
2095
2096 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2097
2098         * infrun.c (stop_all_threads): If debug_infrun, always
2099         trace the wait status after wait_one, using
2100         target_waitstatus_to_string and target_pid_to_str.
2101         (handle_inferior_event): Replace various trace of
2102         wait status kind by a single trace.
2103         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2104         wait status kind image by target_waitstatus_to_string.
2105         * target/waitstatus.c (target_waitstatus_to_string): Fix
2106         obsolete comment.
2107
2108 2019-04-01  Tom Tromey  <tromey@adacore.com>
2109
2110         PR symtab/23331:
2111         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2112
2113 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2114             Pedro Alves  <palves@redhat.com>
2115
2116         * top.c (quit_force): Call 'finalize_values'.
2117         * value.c (finalize_values): New function.
2118         * value.h (finalize_values): Declare.
2119
2120 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2121
2122         * NEWS: Announce $_gdb_major and $_gdb_minor.
2123
2124         * top.c (init_gdb_version_vars): New function.
2125         (gdb_init): Call init_gdb_version_vars.
2126
2127 2019-03-29  Tom Tromey  <tromey@adacore.com>
2128
2129         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2130         help text.  Remove dead code.
2131
2132 2019-03-29  Keith Seitz  <keiths@redhat.com>
2133
2134         From Siddhesh Poyarekar:
2135         * f-lang.h (f77_get_upperbound): Return LONGEST.
2136         (f77_get_lowerbound): Likewise.
2137         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2138         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2139         print them.
2140         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2141         plongest to format print it.
2142         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2143         (f77_get_upperbound): Likewise.
2144         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2145         LOWER_BOUND to LONGEST.
2146         (f77_create_arrayprint_offset_tbl): Likewise.
2147
2148 2019-03-29  Keith Seitz  <keiths@redhat.com>
2149
2150         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2151         %s/pulongest for TYPE_LENGTH instead of %d in format
2152         strings.
2153         * ada-typerint.c (ada_print_type): Likewise.
2154         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2155         * compile/compile-c-support.c (generate_register_struct): Likewise.
2156         * gdbtypes.c (recursive_dump_type): Likewise.
2157         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2158         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2159         instead of %d in format strings.
2160         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2161         to std::min to ULONGEST.
2162         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2163         instead of %d in format strings.
2164         * tracepoint.c (info_scope_command): Likewise.
2165         * typeprint.c (print_offset_data::update)
2166         (print_offset_data::finish): Likewise.
2167         * xtensa-tdep.c (xtensa_store_return_value)
2168         (xtensa_push_dummy_call): Likewise.
2169
2170 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2171
2172         * windows-nat.c (display_selector): Fixed format specifications
2173         for 64-bit Cygwin.
2174
2175 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2176
2177         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2178
2179 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2180
2181         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2182         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2183         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2184         (nios2_linux_init_abi): Install it.
2185
2186 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2187
2188         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2189
2190 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2191
2192         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2193
2194 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2195             Tom Tromey  <tromey@adacore.com>
2196
2197         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2198
2199 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2200
2201         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2202         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2203         method to compute the bounds of range types. Also print "[evaluated]"
2204         if the bounds' values come from a dynamic evaluation.
2205
2206 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2209         whitespace when pretty printing is on.
2210
2211 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2212
2213         * ppc-linux-nat.c: Add include.
2214
2215 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2216
2217         * NEWS: Mention AArch64 Pointer Authentication.
2218
2219 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2220
2221         * arm-linux-nat.c: Add include.
2222
2223 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2224
2225         * source-cache.c (source_cache::get_source_lines): Re-read
2226         fullname after calling open_source_file.
2227
2228 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2229
2230         * NEWS: Mention TLS support for FreeBSD.
2231
2232 2019-03-25  Tom Tromey  <tromey@adacore.com>
2233
2234         * minsyms.c (BUNCH_SIZE): Update comment.
2235         (~minimal_symbol_reader): Remove old comment.
2236         (compact_minimal_symbols): Update comment.
2237         (minimal_symbol_reader::install): Remove old comment.  Update
2238         other comments.
2239
2240 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2241
2242         * s390-linux-nat.c: Add include.
2243
2244 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2245
2246         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2247         Call linux_get_hwcap.
2248         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2249         Likewise.
2250         (aarch64_linux_get_hwcap): Remove function.
2251         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2252         declaration.
2253         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2254         linux_get_hwcap.
2255         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2256         * linux-tdep.c (linux_get_hwcap): Add function.
2257         (linux_get_hwcap2): Likewise.
2258         * linux-tdep.h (linux_get_hwcap): Add declaration.
2259         (linux_get_hwcap2): Likewise.
2260         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2261         (ppc_linux_get_hwcap2): Likewise.
2262         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2263         linux_get_hwcap.
2264         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2265         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2266         (ppc_linux_nat_target::read_description): Likewise.
2267         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2268         * s390-linux-nat.c: Likewise.
2269         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2270
2271 2019-03-24  Tom Tromey  <tom@tromey.com>
2272
2273         * ada-lang.c (standard_lookup): Simplify initialization.
2274         (ada_lookup_symbol_nonlocal): Simplify return.
2275         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2276         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2277         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2278         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2279         initialization.
2280         * solib.c (solib_global_lookup): Simplify.
2281         * symtab.c (null_block_symbol): Remove.
2282         (symbol_cache_lookup): Simplify returns.
2283         (lookup_language_this): Simplify returns.
2284         (lookup_symbol_aux): Simplify return.
2285         (lookup_local_symbol): Simplify returns.
2286         (lookup_global_symbol_from_objfile): Simplify return.
2287         (lookup_symbol_in_objfile_symtabs)
2288         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2289         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2290         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2291         * cp-namespace.c (cp_lookup_bare_symbol)
2292         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2293         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2294         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2295         (cp_lookup_symbol_via_imports): Simplify initialization.
2296         (find_symbol_in_baseclass): Likewise.
2297         * symtab.h (null_block_symbol): Remove.
2298         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2299         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2300         (d_lookup_symbol_module): Likewise.
2301         (find_symbol_in_baseclass): Simplify initialization.
2302
2303 2019-03-24  Tom Tromey  <tom@tromey.com>
2304
2305         * expression.h: Don't include symtab.h.
2306         (struct block): Forward declare.
2307
2308 2019-03-24  Tom Tromey  <tom@tromey.com>
2309
2310         * c-exp.y (typebase): Remove casts.
2311         * gdbtypes.c (lookup_unsigned_typename, )
2312         (lookup_signed_typename): Remove cast.
2313         * eval.c (parse_to_comma_and_eval): Remove cast.
2314         * parse.c (write_dollar_variable): Remove cast.
2315         * block.h (struct block) <superblock>: Now const.
2316         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2317         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2318         (map_block): Make "block" const.
2319         * symfile.h (struct quick_symbol_functions)
2320         <map_matching_symbols>: Constify block argument to "callback".
2321         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2322         const.
2323         (find_pc_sect_compunit_symtab): Make "b" const.
2324         (find_symbol_at_address): Likewise.
2325         (search_symbols): Likewise.
2326         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2327         (dw2_debug_names_lookup_symbol): Likewise.
2328         (dw2_map_matching_symbols): Update.
2329         * p-valprint.c (pascal_val_print): Remove "block".
2330         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2331         (aux_add_nonlocal_symbols): Make "block" const.
2332         (resolve_subexp): Remove cast.
2333         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2334         const.
2335         (iterate_over_file_blocks): Likewise.
2336         * f-exp.y (%union) <bval>: Remove.
2337         * coffread.c (patch_opaque_types): Make "b" const.
2338         * spu-tdep.c (spu_catch_start): Make "block" const.
2339         * c-valprint.c (print_unpacked_pointer): Remove "block".
2340         * symmisc.c (dump_symtab_1): Make "b" const.
2341         (block_depth): Make "block" const.
2342         * d-exp.y (%union) <bval>: Remove.
2343         * cp-support.h (cp_lookup_rtti_type): Update.
2344         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2345         * psymtab.c (psym_lookup_symbol): Make "block" const.
2346         (maintenance_check_psymtabs): Make "b" const.
2347         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2348         (enumerate_locals, enumerate_args): Update.
2349         * python/py-symtab.c (stpy_global_block): Make "block" const.
2350         (stpy_static_block): Likewise.
2351         * inline-frame.c (block_starting_point_at): Make "new_block"
2352         const.
2353         * block.c (find_block_in_blockvector): Make return type const.
2354         (blockvector_for_pc_sect): Make "b" const.
2355         (find_block_in_blockvector): Make "b" const.
2356
2357 2019-03-23  Tom Tromey  <tom@tromey.com>
2358
2359         * varobj.c (varobj_create): Update.
2360         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2361         * printcmd.c (display_command, do_one_display): Don't reset
2362         innermost_block.
2363         * parser-defs.h (enum innermost_block_tracker_type): Move to
2364         expression.h.
2365         (innermost_block): Update comment.
2366         * parse.c (parse_exp_1): Add tracker_types parameter.
2367         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2368         tracker_types parameter.  Reset innermost_block.
2369         (parse_exp_in_context): Remove.
2370         (parse_expression_for_completion): Update.
2371         * objfiles.c (~objfile): Don't reset expression_context_block or
2372         innermost_block.
2373         * expression.h (enum innermost_block_tracker_type): Move from
2374         parser-defs.h.
2375         (parse_exp_1): Add tracker_types parameter.
2376         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2377         reset innermost_block.
2378
2379 2019-03-23  Tom Tromey  <tom@tromey.com>
2380
2381         * objfiles.h: Include bcache.h.
2382
2383 2019-03-23  Tom Tromey  <tom@tromey.com>
2384
2385         * linespec.c (get_current_search_block): Use
2386         scoped_restore_current_language.
2387         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2388
2389 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2390             Jiong Wang  <jiong.wang@arm.com>
2391
2392         * aarch64-linux-tdep.c
2393         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2394         section.
2395         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2396
2397 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2398             Jiong Wang  <jiong.wang@arm.com>
2399
2400         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2401         instructions.
2402         (aarch64_analyze_prologue_test): Add PACIASP test.
2403         (aarch64_prologue_prev_register): Unmask PC value.
2404
2405 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2406             Jiong Wang  <jiong.wang@arm.com>
2407
2408         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2409         (aarch64_dwarf2_prev_register): Unmask PC value.
2410         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2411         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2412         DW_CFA_AARCH64_negate_ra_state.
2413         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2414
2415 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2416             Jiong Wang  <jiong.wang@arm.com>
2417
2418         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2419         registers.
2420         (aarch64_pseudo_register_name): Likewise.
2421         (aarch64_pseudo_register_type): Likewise.
2422         (aarch64_pseudo_register_reggroup_p): Likewise.
2423         (aarch64_gdbarch_init): Add pauth registers.
2424         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2425         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2426         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2427         (struct gdbarch_tdep): Add regnum for ra_state.
2428
2429 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2430             Jiong Wang  <jiong.wang@arm.com>
2431
2432         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2433
2434 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2435             Jiong Wang  <jiong.wang@arm.com>
2436
2437         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2438         function.
2439         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2440         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2441         (aarch64_gdbarch_init): Add puth registers.
2442         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2443         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2444         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2445
2446 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2447             Jiong Wang  <jiong.wang@arm.com>
2448
2449         * aarch64-linux-nat.c
2450         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2451         * aarch64-linux-tdep.c
2452         (aarch64_linux_core_read_description): Likewise.
2453         (aarch64_linux_get_hwcap): New function.
2454         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2455         (aarch64_linux_get_hwcap): New declaration.
2456
2457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2458             Jiong Wang  <jiong.wang@arm.com>
2459
2460         * aarch64-linux-nat.c
2461         (aarch64_linux_nat_target::read_description): Add pauth param.
2462         * aarch64-linux-tdep.c
2463         (aarch64_linux_core_read_description): Likewise.
2464         * aarch64-tdep.c (struct target_desc): Add in pauth.
2465         (aarch64_read_description): Add pauth param.
2466         (aarch64_gdbarch_init): Likewise.
2467         * aarch64-tdep.h (aarch64_read_description): Likewise.
2468         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2469         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2470         * features/Makefile: Add new files.
2471         * features/aarch64-pauth.c: New file.
2472         * features/aarch64-pauth.xml: New file.
2473
2474 2019-03-20  Tom Tromey  <tromey@adacore.com>
2475
2476         * infrun.c (handle_inferior_event): Rename from
2477         handle_inferior_event_1.  Create a scoped_value_mark.
2478         (handle_inferior_event): Remove.
2479
2480 2019-03-19  Tom Tromey  <tromey@adacore.com>
2481
2482         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2483         * infrun.h (print_stop_event): Add "displays" parameter.
2484         * infrun.c (print_stop_event): Add "displays" parameter.
2485
2486 2019-03-19  Pedro Alves  <palves@redhat.com>
2487
2488         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2489         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2490         to -1.  Fix TABs vs spaces.
2491         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2492         * tui/tui-out.h (tui_ui_out) Add intro comments.
2493         <m_line, m_start_of_line>: In-class initialize, and add describing
2494         comment.
2495
2496 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2497
2498         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2499         variable names.
2500         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2501
2502 2019-03-18  Pedro Alves  <palves@redhat.com>
2503             Eli Zaretskii <eliz@gnu.org>
2504
2505         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2506         m_line and m_start_of_line.
2507
2508 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2509
2510         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2511         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2512         it returns a newline.  This fixes a regression in TU mode, whereby
2513         the next line is output on the same screen line as the user input.
2514
2515 2019-03-18  Tom Tromey  <tromey@adacore.com>
2516
2517         * minsyms.c (minimal_symbol_reader::install): Remove call to
2518         obstack_blank.
2519
2520 2019-03-18  Pedro Alves  <palves@redhat.com>
2521
2522         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2523         New globals.
2524         (apply_style): New, factored out from ...
2525         (apply_ansi_escape): ... this.  Handle reverse video mode.
2526         (tui_set_reverse_mode): New function.
2527         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2528         * tui/tui-winsource.c (tui_show_source_line): Use
2529         tui_set_reverse_mode instead of setting A_STANDOUT.
2530         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2531         New setter methods.
2532
2533 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2534
2535         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2536         Handle tabs.
2537
2538 2019-03-18  Tom Tromey  <tromey@adacore.com>
2539
2540         * ada-lang.c (empty_array): Add "high" parameter.
2541         (ada_evaluate_subexp): Update.
2542
2543 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2544
2545         * unittests/string_view-selftests.c: Define
2546         _initialize_string_view_selftests unconditionally.
2547
2548 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2549
2550         PR gdb/24350
2551         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2552
2553 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2554
2555         PR gdb/24351
2556         * windows-nat.c (display_selector): Fix format specifiers.
2557
2558 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2559
2560         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2561         tui_refill_source_window instead of tui_refresh_win, to update the
2562         current execution line.  This fixes redisplay of the current line
2563         when stepping through the code with "next" or "step".
2564
2565 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2566
2567         * source-cache.c (source_cache::get_source_lines): Call
2568         find_source_lines to initialize s->nlines.  This fixes vertical
2569         scrolling of TUI source window when the DOWN arrow is pressed.
2570
2571 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2572
2573         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2574         linux-thread-db.c (_initialize_thread_db): Likewise.
2575
2576 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2577
2578         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2579         wclrtoeol in tui_show_source_line".  This reverts changes made in
2580         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2581
2582 2019-03-15  Tom Tromey  <tom@tromey.com>
2583
2584         * symtab.h (struct minimal_symbol): Derive from
2585         general_symbol_info.
2586         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2587         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2588         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2589         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2590         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2591         (MSYMBOL_SEARCH_NAME): Update.
2592         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2593         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2594         * minsyms.c (minimal_symbol_reader::record_full): Update.
2595
2596 2019-03-15  Tom Tromey  <tom@tromey.com>
2597
2598         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2599
2600 2019-03-15  Tom Tromey  <tom@tromey.com>
2601
2602         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2603         unique_xmalloc_ptr.
2604         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2605         Update.
2606         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2607         (build_minimal_symbol_hash_tables)
2608         (minimal_symbol_reader::install): Update.
2609
2610 2019-03-15  Tom Tromey  <tom@tromey.com>
2611
2612         * symtab.c (create_demangled_names_hash): Update.
2613         (symbol_set_names): Update.
2614         * objfiles.h (struct objfile_per_bfd_storage)
2615         <demangled_names_hash>: Now an htab_up.
2616         * objfiles.c (objfile_per_bfd_storage): Simplify.
2617
2618 2019-03-15  Tom Tromey  <tom@tromey.com>
2619
2620         * objfiles.h (struct objfile_per_bfd_storage): Declare
2621         destructor.
2622         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2623         New.
2624         (get_objfile_bfd_data): Use new.  Don't initialize
2625         language_of_main.
2626         (free_objfile_per_bfd_storage): Remove.
2627         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2628
2629 2019-03-15  Tom Tromey  <tom@tromey.com>
2630
2631         * symfile.c (reread_symbols): Update.
2632         * objfiles.c (objfile::objfile): Update.
2633         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2634         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2635         comment.
2636         (minimal_symbol_reader::install): Update.
2637         (terminate_minimal_symbol_table): Remove.
2638         * jit.c (jit_object_close_impl): Update.
2639
2640 2019-03-15  Tom Tromey  <tom@tromey.com>
2641
2642         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2643         initializations.
2644
2645 2019-03-15  Tom Tromey  <tom@tromey.com>
2646
2647         * objfiles.h (struct objfile_per_bfd_storage)
2648         <demangled_hash_languages>: Now a bitset.
2649         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2650         (lookup_minimal_symbol): Update.
2651
2652 2019-03-15  Tom Tromey  <tom@tromey.com>
2653
2654         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2655         Don't return the symbol.
2656         * coffread.c (record_minimal_symbol): Use record_full.
2657
2658 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2659
2660         The MS-Windows port of ncurses fails to switch to a color pair if
2661         one or both of the colors are the implicit default colors.  This
2662         change records the default colors when TUI is initialized, and
2663         then specifies them explicitly when a color pair uses the default
2664         colors.  This allows color styling in TUI mode on MS-Windows.
2665
2666         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2667         ncurses_norm_attr.
2668         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2669         colors in ncurses_norm_attr.
2670         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2671         "none", replace it with the default color recorded in
2672         ncurses_norm_attr.
2673
2674 2019-03-14  Tom Tromey  <tromey@adacore.com>
2675
2676         * source-cache.h (class source_cache) <get_source_lines>: Return
2677         std::string.
2678         * source-cache.c (source_cache::extract_lines): Handle case where
2679         first_pos==npos.  Return std::string.
2680         (source_cache::get_source_lines): Update.
2681
2682 2019-03-14  Tom Tromey  <tromey@adacore.com>
2683
2684         * NEWS: Add item for "style sources" commands.
2685         * source-cache.c (source_cache::get_source_lines): Check
2686         source_styling.
2687         * cli/cli-style.c (source_styling): New global.
2688         (_initialize_cli_style): Add "style sources" commands.
2689         (show_style_sources): New function.
2690         * cli/cli-style.h (source_styling): Declare.
2691
2692 2019-03-14  Pedro Alves  <palves@redhat.com>
2693             Tom Tromey  <tromey@adacore.com>
2694
2695         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2696         * tui/tui-winsource.c (tui_refill_source_window): New function,
2697         from...
2698         (tui_horizontal_source_scroll): ... here.  Move some logic.
2699         * cli/cli-style.c (set_style_enabled): Notify new observable.
2700         * tui/tui-hooks.c (tui_redisplay_source): New function.
2701         (tui_attach_detach_observers): Attach or detach
2702         tui_redisplay_source.
2703         * observable.h (source_styling_changed): New observable.
2704         * observable.c: Define source_styling_changed observable.
2705
2706 2019-03-13  Tom Tromey  <tromey@adacore.com>
2707
2708         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2709         (i386_gnu_nat_target::store_registers): Update.
2710         * target-debug.h (target_debug_print_std_string): New macro.
2711         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2712         * windows-tdep.c (display_one_tib): Update.
2713         * tui/tui-stack.c (tui_make_status_line): Update.
2714         * top.c (print_inferior_quit_action): Update.
2715         * thread.c (thr_try_catch_cmd): Update.
2716         (add_thread_with_info): Update.
2717         (thread_target_id_str): Update.
2718         (thr_try_catch_cmd): Update.
2719         (thread_command): Update.
2720         (thread_find_command): Update.
2721         * record-btrace.c (record_btrace_target::info_record)
2722         (record_btrace_resume_thread, record_btrace_target::resume)
2723         (record_btrace_cancel_resume, record_btrace_step_thread)
2724         (record_btrace_target::wait, record_btrace_target::wait)
2725         (record_btrace_target::wait, record_btrace_target::stop): Update.
2726         * progspace.c (print_program_space): Update.
2727         * process-stratum-target.c
2728         (process_stratum_target::thread_address_space): Update.
2729         * linux-fork.c (linux_fork_mourn_inferior)
2730         (detach_checkpoint_command, info_checkpoints_command)
2731         (linux_fork_context): Update.
2732         (linux_fork_detach): Update.
2733         (class scoped_switch_fork_info): Update.
2734         (delete_checkpoint_command): Update.
2735         * infrun.c (follow_fork_inferior): Update.
2736         (follow_fork_inferior): Update.
2737         (proceed_after_vfork_done): Update.
2738         (handle_vfork_child_exec_or_exit): Update.
2739         (follow_exec): Update.
2740         (displaced_step_prepare_throw): Update.
2741         (displaced_step_restore): Update.
2742         (start_step_over): Update.
2743         (resume_1): Update.
2744         (clear_proceed_status_thread): Update.
2745         (proceed): Update.
2746         (print_target_wait_results): Update.
2747         (do_target_wait): Update.
2748         (context_switch): Update.
2749         (stop_all_threads): Update.
2750         (restart_threads): Update.
2751         (finish_step_over): Update.
2752         (handle_signal_stop): Update.
2753         (switch_back_to_stepped_thread): Update.
2754         (keep_going_pass_signal): Update.
2755         (print_exited_reason): Update.
2756         (normal_stop): Update.
2757         * inferior.c (inferior_pid_to_str): Change return type.
2758         (print_selected_inferior): Update.
2759         (add_inferior): Update.
2760         (detach_inferior): Update.
2761         * dummy-frame.c (fprint_dummy_frames): Update.
2762         * dcache.c (dcache_info_1): Update.
2763         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2764         (btrace_fetch, btrace_clear): Update.
2765         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2766         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2767         type.
2768         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2769         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2770         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2771         * gdbarch.c, gdbarch.h: Rebuild.
2772         * gdbarch.sh (core_pid_to_str): Change return type.
2773         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2774         return type.
2775         (windows_nat_target::pid_to_str): Change return type.
2776         (windows_delete_thread): Update.
2777         (windows_nat_target::attach): Update.
2778         (windows_nat_target::files_info): Update.
2779         * target-delegates.c: Rebuild.
2780         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2781         return type.
2782         (sol_thread_target::pid_to_str): Change return type.
2783         * remote.c (class remote_target) <pid_to_str>: Change return
2784         type.
2785         (remote_target::pid_to_str): Change return type.
2786         (extended_remote_target::attach, remote_target::remote_stop_ns)
2787         (remote_target::remote_notif_remove_queued_reply)
2788         (remote_target::push_stop_reply, remote_target::disable_btrace):
2789         Update.
2790         (extended_remote_target::attach): Update.
2791         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2792         type.
2793         (gdbsim_target::pid_to_str): Change return type.
2794         * ravenscar-thread.c (struct ravenscar_thread_target)
2795         <pid_to_str>: Change return type.
2796         (ravenscar_thread_target::pid_to_str): Change return type.
2797         * procfs.c (class procfs_target) <pid_to_str>: Change return
2798         type.
2799         (procfs_target::pid_to_str): Change return type.
2800         (procfs_target::attach): Update.
2801         (procfs_target::detach): Update.
2802         (procfs_target::fetch_registers): Update.
2803         (procfs_target::store_registers): Update.
2804         (procfs_target::wait): Update.
2805         (procfs_target::files_info): Update.
2806         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2807         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2808         return type.
2809         (nto_procfs_target::pid_to_str): Change return type.
2810         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2811         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2812         return type.
2813         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2814         (exit_lwp): Update.
2815         (attach_proc_task_lwp_callback, get_detach_signal)
2816         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2817         (linux_nat_target::resume, wait_lwp, stop_callback)
2818         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2819         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2820         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2821         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2822         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2823         type.
2824         (inf_ptrace_target::attach): Update.
2825         (inf_ptrace_target::files_info): Update.
2826         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2827         type.
2828         (go32_nat_target::pid_to_str): Change return type.
2829         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2830         (gnu_nat_target::wait): Update.
2831         (gnu_nat_target::wait): Update.
2832         (gnu_nat_target::resume): Update.
2833         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2834         (fbsd_nat_target::wait): Update.
2835         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2836         type.
2837         (darwin_nat_target::attach): Update.
2838         * corelow.c (class core_target) <pid_to_str>: Change return type.
2839         (core_target::pid_to_str): Change return type.
2840         * target.c (normal_pid_to_str): Change return type.
2841         (default_pid_to_str): Likewise.
2842         (target_pid_to_str): Change return type.
2843         (target_translate_tls_address): Update.
2844         (target_announce_detach): Update.
2845         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2846         return type.
2847         (bsd_uthread_target::pid_to_str): Change return type.
2848         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2849         type.
2850         (bsd_kvm_target::pid_to_str): Change return type.
2851         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2852         return type.
2853         (aix_thread_target::pid_to_str): Change return type.
2854         * target.h (struct target_ops) <pid_to_str>: Change return type.
2855         (target_pid_to_str, normal_pid_to_str): Likewise.
2856         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2857         type.
2858         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2859         type.
2860         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2861         return type.
2862         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2863         type.
2864         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2865         type.
2866         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2867         return type.
2868
2869 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2870
2871         * NEWS: Mention that the new default MI version is 3.  Mention
2872         changes to the output of commands and events that deal with
2873         multi-location breakpoints.
2874         * breakpoint.c: Include "mi/mi-out.h".
2875         (print_one_breakpoint): Change output syntax if using MI version
2876         >= 3.
2877         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2878         New.
2879         (mi_multi_location_breakpoint_output_fixed): New.
2880         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2881         (mi_cmd_fix_multi_location_breakpoint_output): New.
2882         (mi_multi_location_breakpoint_output_fixed): New.
2883         * mi/mi-cmds.c (mi_cmds): Register command
2884         -fix-multi-location-breakpoint-output.
2885         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2886         interpreter "mi".
2887
2888 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2889
2890         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2891         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2892         instantiate mi_ui_out based on interpreter name.
2893         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2894         * mi/mi-main.c (mi_load_progress): Likewise.
2895
2896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2897
2898         * NEWS: Combine separate "New targets" sections for 8.3.
2899
2900 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2901
2902         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2903         (ppcfbsd_init_abi): Install gdbarch
2904         "fetch_tls_load_module_address" and "get_thread_local_address"
2905         methods.
2906
2907 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2908
2909         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2910         (riscv_fbsd_init_abi): Install gdbarch
2911         "fetch_tls_load_module_address" and "get_thread_local_address"
2912         methods.
2913
2914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2915
2916         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2917         (i386fbsd_init_abi): Install gdbarch
2918         "fetch_tls_load_module_address" and "get_thread_local_address"
2919         methods.
2920
2921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2922
2923         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2924         (amd64fbsd_init_abi): Install gdbarch
2925         "fetch_tls_load_module_address" and "get_thread_local_address"
2926         methods.
2927
2928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2929
2930         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2931         (struct fbsd_pspace_data): New type.
2932         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2933         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2934         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2935         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2936         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2937
2938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2939
2940         * gdbtypes.c (lookup_struct_elt): New function.
2941         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2942         * gdbtypes.h (struct struct_elt): New type.
2943         (lookup_struct_elt): New prototype.
2944
2945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2946
2947         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2948         remove disabled code block.
2949
2950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2951
2952         * gdbarch.sh (get_thread_local_address): New method.
2953         * gdbarch.h, gdbarch.c: Regenerate.
2954         * target.c (target_translate_tls_address): Use
2955         gdbarch_get_thread_local_address if present instead of
2956         target::get_thread_local_address.
2957
2958 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2959
2960         * target.h (target::get_thread_local_address): Update comment.
2961
2962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2963
2964         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2965         objfile->separate_debug_objfile_backlink if not NULL.
2966
2967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2968
2969         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2970         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2971         (amd64bsd_store_inferior_registers): Likewise.
2972         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2973         Enable segment base registers.
2974         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2975         PT_GETFSBASE and PT_GETGSBASE.
2976         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2977         PT_SETGSBASE.
2978         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2979         segment base registers.
2980         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2981
2982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2983
2984         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2985         Update calls to i386_target_description to add 'segments'
2986         parameter.
2987         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2988         add segment base registers.
2989         * arch/i386.c (i386_create_target_description): Add 'segments'
2990         parameter to enable segment base registers.
2991         * arch/i386.h (i386_create_target_description): Likewise.
2992         * features/i386/32bit-segments.xml: New file.
2993         * features/i386/32bit-segments.c: Generate.
2994         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2995         call to i386_target_description to add 'segments' parameter.
2996         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2997         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2998         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2999         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3000         if feature is present.
3001         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3002         Add 'segments' parameter to call to i386_target_description.
3003         (i386_target_description): Add 'segments' parameter to enable
3004         segment base registers.
3005         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3006         to call to i386_target_description.
3007         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3008         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3009         Define I386_NUM_REGS.
3010         (i386_target_description): Add 'segments' parameter to enable
3011         segment base registers.
3012
3013 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3014
3015         PR/24325
3016         * source-cache.c: #undef open and close, to avoid unresolved
3017         externals during linking.
3018
3019 2019-03-12  Tom Tromey  <tromey@adacore.com>
3020
3021         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3022         const.  Add initializers.
3023         (_initialize_remote): Don't initialize ptid globals.
3024
3025 2019-03-12  Pedro Alves  <palves@redhat.com>
3026
3027         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3028
3029 2019-03-12  Pedro Alves  <palves@redhat.com>
3030
3031         * cp-name-parser.y (main): Remove unused 'len' variable.
3032
3033 2019-03-12  Tom Tromey  <tromey@adacore.com>
3034
3035         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3036         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3037
3038 2019-03-12  Tom Tromey  <tromey@adacore.com>
3039
3040         * linux-nat.c (iterate_over_lwps): Update.
3041         (stop_callback): Remove parameter.
3042         (stop_wait_callback, detach_callback, resume_set_callback)
3043         (select_singlestep_lwp_callback, set_ignore_sigint)
3044         (status_callback, resumed_callback, resume_clear_callback)
3045         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3046         data parameter.
3047         (linux_nat_target::detach, linux_nat_target::resume)
3048         (linux_stop_and_wait_all_lwps, select_event_lwp)
3049         (linux_nat_filter_event, linux_nat_wait_1)
3050         (linux_nat_target::kill, linux_nat_target::stop)
3051         (linux_nat_target::stop): Update.
3052         (linux_nat_resume_callback): Change type.
3053         (resume_stopped_resumed_lwps, count_events_callback)
3054         (select_event_lwp_callback): Likewise.
3055         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3056         * arm-linux-nat.c (struct update_registers_data): Remove.
3057         (update_registers_callback): Change type.
3058         (arm_linux_insert_hw_breakpoint1): Update.
3059         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3060         parameter.
3061         (x86_linux_dr_set_addr): Update.
3062         (x86_linux_dr_set_control): Update.
3063         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3064         (iterate_over_lwps): Use gdb::function_view.
3065         * nat/aarch64-linux-hw-point.c (struct
3066         aarch64_dr_update_callback_param): Remove.
3067         (debug_reg_change_callback): Change type.
3068         (aarch64_notify_debug_reg_change): Update.
3069         * s390-linux-nat.c (s390_refresh_per_info): Update.
3070
3071 2019-03-11  Tom Tromey  <tromey@adacore.com>
3072
3073         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3074         redundant assignment to "this_cu".
3075
3076 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3077
3078         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3079
3080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3081
3082         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3083         from...
3084         (rank_one_type): ... this.
3085
3086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3087
3088         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3089         from...
3090         (rank_one_type): ... this.
3091
3092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3093
3094         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3095         from...
3096         (rank_one_type): ... this.
3097
3098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3099
3100         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3101         from...
3102         (rank_one_type): ... this.
3103
3104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3105
3106         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3107         from...
3108         (rank_one_type): ... this.
3109
3110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3111
3112         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3113         from...
3114         (rank_one_type): ... this.
3115
3116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3117
3118         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3119         from...
3120         (rank_one_type): ... this.
3121
3122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3123
3124         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3125         from...
3126         (rank_one_type): ... this.
3127
3128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3129
3130         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3131         from...
3132         (rank_one_type): ... this.
3133
3134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3135
3136         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3137         from...
3138         (rank_one_type): ... this.
3139
3140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3141
3142         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3143         from...
3144         (rank_one_type): ... this.
3145
3146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3147
3148         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3149         from...
3150         (rank_one_type): ... this.
3151
3152 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3153
3154         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3155         inferior-events' shows the example events.
3156
3157 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3158
3159         Support styling on native MS-Windows console
3160
3161         PR/24315
3162         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3163         on MS-Windows if $TERM is not defined.
3164
3165         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3166
3167         * posix-hdep.c (gdb_console_fputs):
3168         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3169         functions.
3170         * ui-file.h (gdb_console_fputs): Add prototype.
3171
3172         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3173         back to fputs only if the former returns zero.
3174
3175 2019-03-07  Tom Tromey  <tom@tromey.com>
3176
3177         * symmisc.c (print_symbol_bcache_statistics): Update.
3178         (print_objfile_statistics): Update.
3179         * symfile.c (allocate_symtab): Update.
3180         * stabsread.c: Don't include bcache.h.
3181         * psymtab.h (struct psymbol_bcache): Don't declare.
3182         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3183         (psymbol_bcache_init, psymbol_bcache_free)
3184         (psymbol_bcache_get_bcache): Don't declare.
3185         * psymtab.c (struct psymbol_bcache): Remove.
3186         (psymtab_storage::psymtab_storage): Update.
3187         (psymtab_storage::~psymtab_storage): Update.
3188         (psymbol_bcache_init, psymbol_bcache_free)
3189         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3190         (add_psymbol_to_bcache): Update.
3191         (allocate_psymtab): Update.
3192         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3193         macro_cache>: No longer pointers.
3194         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3195         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3196         * macrotab.c (macro_bcache): Update.
3197         * macroexp.c: Don't include bcache.h.
3198         * gdbtypes.c (check_types_worklist): Update.
3199         (types_deeply_equal): Remove TRY/CATCH.  Update.
3200         * elfread.c (elf_symtab_read): Update.
3201         * dwarf2read.c: Don't include bcache.h.
3202         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3203         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3204         (print_bcache_statistics, bcache_memory_used): Don't declare.
3205         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3206         methods.  Rename all data members.
3207         * bcache.c (struct bcache): Move to bcache.h.
3208         (bcache::expand_hash_table): Rename from expand_hash_table.
3209         (bcache): Remove.
3210         (bcache::insert): Rename from bcache_full.
3211         (bcache::compare): Rename from bcache_compare.
3212         (bcache_xmalloc): Remove.
3213         (bcache::~bcache): Rename from bcache_xfree.
3214         (bcache::print_statistics): Rename from print_bcache_statistics.
3215         (bcache::memory_used): Rename from bcache_memory_used.
3216
3217 2019-03-07  Pedro Alves  <palves@redhat.com>
3218
3219         * infrun.c (normal_stop): Also check for
3220         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3221
3222 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3223
3224         * f-lang.c (value_from_host_double): Moved to...
3225         * value.c (value_from_host_double): ...here.
3226         * value.h (value_from_host_double): Declare.
3227         * guile/scm-math.c (vlscm_convert_typed_number): Use
3228         value_from_host_double.
3229         (vlscm_convert_number): Likewise.
3230         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3231         * python/py-value.c (convert_value_from_python): Likewise.
3232
3233 2019-03-06  Tom Tromey  <tom@tromey.com>
3234
3235         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3236
3237 2019-03-06  Tom Tromey  <tom@tromey.com>
3238
3239         * utils.h (free_current_contents): Don't declare.
3240         * utils.c (free_current_contents): Remove.
3241
3242 2019-03-06  Tom Tromey  <tom@tromey.com>
3243
3244         * top.c (quit_force): Update.
3245         * main.c (captured_command_loop): Update.
3246         * common/new-op.c (operator new): Update.
3247         * common/common-exceptions.c (struct catcher)
3248         <save_cleanup_chain>: Remove member.
3249         (exceptions_state_mc_init): Update.
3250         (exception_try_scope_entry): Return nullptr.
3251         (exception_try_scope_exit, exception_rethrow)
3252         (throw_exception_sjlj, throw_exception_cxx): Update.
3253         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3254         (all_cleanups, do_cleanups, discard_cleanups)
3255         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3256         (restore_cleanups, restore_final_cleanups): Don't declare.
3257         (do_final_cleanups): Remove parameter.
3258         * common/cleanups.c (cleanup_chain, make_cleanup)
3259         (make_cleanup_dtor, all_cleanups, do_cleanups)
3260         (discard_my_cleanups, discard_cleanups)
3261         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3262         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3263         (null_cleanup): Remove.
3264         (do_final_cleanups): Remove parameter.
3265
3266 2019-03-06  Tom Tromey  <tom@tromey.com>
3267
3268         * remote.c (remote_target::remote_parse_stop_reply): Use
3269         unique_xmalloc_ptr.
3270
3271 2019-03-06  Tom Tromey  <tom@tromey.com>
3272
3273         * stabsread.c (struct stabs_field_info): Rename from field_info.
3274         <list, fnlist>: Add initializers.
3275         <obstack>: New member.
3276         (read_member_functions, read_struct_fields, read_baseclasses):
3277         Allocate on obstack.  Don't use cleanups.
3278         (read_one_struct_field, read_member_functions, read_struct_fields)
3279         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3280         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3281         (read_struct_type): Update.
3282
3283 2019-03-06  Tom Tromey  <tom@tromey.com>
3284
3285         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3286         * common/filestuff.h (make_cleanup_close): Don't declare.
3287         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3288         Remove.
3289
3290 2019-03-06  Tom Tromey  <tom@tromey.com>
3291
3292         * solib-aix.c: Use make_scope_exit.
3293
3294 2019-03-06  Tom Tromey  <tom@tromey.com>
3295
3296         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3297         Use make_scope_exit.
3298
3299 2019-03-06  Tom Tromey  <tom@tromey.com>
3300
3301         * solib-svr4.c (disable_probes_interface): Remove parameter.
3302         (svr4_handle_solib_event): Use make_scope_exit.
3303
3304 2019-03-06  Tom Tromey  <tom@tromey.com>
3305
3306         * remote.c (struct stop_reply_deleter): Remove.
3307         (stop_reply_up): Update.
3308         (struct stop_reply): Derive from notif_event.  Don't typedef.
3309         <regcache>: Now a std::vector.
3310         (stop_reply_xfree): Remove.
3311         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3312         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3313         (remote_target::discard_pending_stop_replies): Use delete.
3314         (remote_target::remote_parse_stop_reply): Update.
3315         (remote_target::process_stop_reply): Update.
3316         * remote-notif.h (struct notif_event): Add virtual destructor.
3317         Remove "dtr" member.
3318         (struct notif_client) <alloc_event>: Return a unique_ptr.
3319         (notif_event_xfree): Don't declare.
3320         (notif_event_up): New typedef.
3321         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3322         (notif_event_xfree, do_notif_event_xfree): Remove.
3323         (remote_notif_state_xfree): Update.
3324
3325 2019-03-06  Tom Tromey  <tom@tromey.com>
3326
3327         * infrun.c (displaced_step_clear_cleanup): Now a
3328         forward_scope_exit type.
3329         (displaced_step_prepare_throw): Update.
3330         (displaced_step_fixup): Update.
3331
3332 2019-03-06  Tom Tromey  <tom@tromey.com>
3333
3334         * inferior.h (class inferior): Update comment.
3335         * gdbthread.h (class thread_info): Update comment.
3336
3337 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3338             Tom Tromey  <tom@tromey.com>
3339
3340         * stabsread.h (struct stab_section_list): Remove.
3341         (coffstab_build_psymtabs): Update.
3342         * dbxread.c (symbuf_sections): Now a std::vector.
3343         (sect_idx): New global.
3344         (fill_symbuf): Update.
3345         (coffstab_build_psymtabs): Change type of stabsects parameter.
3346         Update.
3347         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3348         std::vector.
3349         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3350         (coff_locate_sections): Update.
3351         (coff_symfile_read): Remove cleanups.  Update.
3352         (init_stringtab): Add storage parameter.
3353         (free_stringtab, free_stringtab_cleanup): Remove.
3354         (init_lineno): Add storage parameter.
3355         (free_linetab, free_linetab_cleanup): Remove.
3356
3357 2019-03-06  Pedro Alves  <palves@redhat.com>
3358
3359         * linux-fork.c (fork_info::clobber_regs): Delete.
3360         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3361         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3362         comment.  Adjust.
3363         (scoped_switch_fork_info::scoped_switch_fork_info)
3364         (checkpoint_command, linux_fork_context): Adjust
3365         fork_save_infrun_state calls.
3366
3367 2019-03-06  Pedro Alves  <palves@redhat.com>
3368
3369         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3370         (inf_has_multiple_threads): Return 'bool' and rewrite using
3371         inferior_info::threads().
3372
3373 2019-03-06  Pedro Alves  <palves@redhat.com>
3374
3375         * linux-fork.c: Include <list>.
3376         (fork_list): Now a std::list instance.
3377         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3378         (forks_exist_p, find_last_fork): Adjust.
3379         (new_fork): Delete.
3380         (one_fork_p): New.
3381         (add_fork): Adjust.
3382         (free_fork): Delete, folded into fork_info::~fork_info().
3383         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3384         Adjust.
3385         (init_fork_list): Delete.
3386         (linux_fork_killall, linux_fork_mourn_inferior)
3387         (linux_fork_detach, info_checkpoints_command): Adjust.
3388         (_initialize_linux_fork): No longer call init_fork_list.
3389
3390 2019-03-06  Pedro Alves  <palves@redhat.com>
3391
3392         * linux-fork.c (new_fork): New, split out of ...
3393         (add_fork): ... this.  Return void.  Move "first fork" special
3394         case from here, to ...
3395         (checkpoint_command): ... here.
3396         * linux-linux.h (add_fork): Return void.
3397
3398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3401
3402 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3403             Chris January  <chris.january@arm.com>
3404             David Lecomber  <david.lecomber@arm.com>
3405
3406         * f-exp.y: New token, UNOP_INTRINSIC.
3407         (exp): New pattern using UNOP_INTRINSIC token.
3408         (f77_keywords): Add 'abs' keyword.
3409         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3410         (value_from_host_double): New function.
3411         (evaluate_subexp_f): Support UNOP_ABS.
3412
3413 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3414
3415         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3416         types.
3417
3418 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3419
3420         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3421         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3422         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3423
3424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3425
3426         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3427
3428 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3429             Chris January  <chris.january@arm.com>
3430
3431         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3432         * f-exp.y: Define 'KIND' token.
3433         (exp): New pattern for KIND expressions.
3434         (ptype): Handle types with a kind extension.
3435         (direct_abs_decl): Extend to spot kind extensions.
3436         (f77_keywords): Add 'kind' to the list.
3437         (push_kind_type): New function.
3438         (convert_to_kind_type): New function.
3439         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3440         * parse.c (operator_length_standard): Likewise.
3441         * parser-defs.h (enum type_pieces): Add tp_kind.
3442         * std-operator.def: Add UNOP_KIND.
3443
3444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * f-exp.y (f_parse): Set yydebug.
3447
3448 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3449
3450         * f-lang.c (evaluate_subexp_f): New function.
3451         (exp_descriptor_f): New global.
3452         (f_language_defn): Use exp_descriptor_f instead of
3453         exp_descriptor_standard.
3454
3455 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         * f-exp.y (struct token): Add comments.
3458         (dot_ops): Remove uppercase versions and the end marker.
3459         (f77_keywords): Likewise.
3460         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3461         entries in the dot_ops array are case insensitive, and use
3462         strncasecmp to compare strings.  Also some whitespace cleanup in
3463         this area.  Similar for the f77_keywords array, except entries in
3464         this list might be case sensitive.
3465
3466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3467
3468         * f-exp.y (struct f77_boolean_val): Add comments.
3469         (boolean_values): Remove uppercase versions, and end marker.
3470         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3471         and use strncasecmp to achieve case insensitivity.  Additionally,
3472         perform whitespace cleanup around this code.
3473
3474 2019-03-06  Tom Tromey  <tromey@adacore.com>
3475
3476         * remote-sim.c (gdbsim_target_open): Use result of
3477         gdb_argv::release.
3478
3479 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3480         Dirk Schubert  <dirk.schubert@arm.com>
3481         Chris January  <chris.january@arm.com>
3482
3483         * eval.c (evaluate_subexp_standard): Call Fortran argument
3484         wrapping logic.
3485         * f-lang.c (struct value): A value which can be passed into a
3486         Fortran function call.
3487         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3488         where appropriate.
3489         (struct type): Value ready for a Fortran function call.
3490         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3491         is needed.
3492         * f-lang.h (fortran_argument_convert): Declaration.
3493         (fortran_preserve_arg_pointer): Declaration.
3494         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3495
3496 2019-03-05  Tom Tromey  <tromey@adacore.com>
3497
3498         * python/py-prettyprint.c (print_string_repr): Remove #if.
3499         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3500
3501 2019-03-05  Tom Tromey  <tromey@adacore.com>
3502
3503         * target.c (the_dummy_target): Move later.  Change type to
3504         "dummy_target".
3505         (initialize_targets): Don't initialize the_dummy_target.
3506
3507 2019-03-05  Tom Tromey  <tromey@adacore.com>
3508
3509         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3510         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3511
3512 2019-03-05  Tom Tromey  <tromey@adacore.com>
3513
3514         * windows-nat.c (windows_nat_target::attach)
3515         (windows_nat_target::detach): Don't call gdb_flush.
3516         * valprint.c (generic_val_print, val_print, val_print_string):
3517         Don't call gdb_flush.
3518         * utils.c (defaulted_query): Don't call gdb_flush.
3519         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3520         * target.c (target_announce_detach): Don't call gdb_flush.
3521         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3522         * remote.c (extended_remote_target::attach): Don't call
3523         gdb_flush.
3524         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3525         * printcmd.c (do_examine): Don't call gdb_flush.
3526         (info_display_command): Don't call gdb_flush.
3527         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3528         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3529         * memattr.c (info_mem_command): Don't call gdb_flush.
3530         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3531         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3532         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3533         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3534         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3535         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3536         (gnu_nat_target::detach): Don't call gdb_flush.
3537         * f-valprint.c (f_val_print): Don't call gdb_flush.
3538         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3539         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3540         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3541         gdb_flush.
3542         * c-valprint.c (c_val_print): Don't call gdb_flush.
3543         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3544
3545 2019-03-05  Tom Tromey  <tromey@adacore.com>
3546
3547         * varobj.c (update_dynamic_varobj_children): Update.
3548         (install_default_visualizer): Use reset, not release.
3549         * value.c (set_internalvar): Update.
3550         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3551         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3552         ATTRIBUTE_UNUSED_RESULT.
3553
3554 2019-03-05  Tom Tromey  <tromey@adacore.com>
3555
3556         * remote.c (class scoped_remote_fd) <release>: Add
3557         ATTRIBUTE_UNUSED_RESULT.
3558
3559 2019-03-05  Tom Tromey  <tromey@adacore.com>
3560
3561         * macroexp.c (struct macro_buffer) <release>: Add
3562         ATTRIBUTE_UNUSED_RESULT.
3563
3564 2019-03-05  Tom Tromey  <tromey@adacore.com>
3565
3566         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3567         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3568         ATTRIBUTE_UNUSED_RESULT.
3569
3570 2019-03-05  Tom Tromey  <tromey@adacore.com>
3571
3572         * common/scoped_fd.h (class scoped_fd) <release>: Add
3573         ATTRIBUTE_UNUSED_RESULT.
3574
3575 2019-03-05  Tom Tromey  <tromey@adacore.com>
3576
3577         * parser-defs.h (struct parser_state) <release>: Add
3578         ATTRIBUTE_UNUSED_RESULT.
3579
3580 2019-03-05  Tom Tromey  <tromey@adacore.com>
3581
3582         * utils.h (class gdb_argv) <release>: Add
3583         ATTRIBUTE_UNUSED_RESULT.
3584         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3585
3586 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3587
3588         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3589         for-loop range, to avoid compiler warnings.
3590
3591         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3592         avoid compiler warnings about unused variables.
3593
3594         * NEWS: Mention end of support for native debugging on MS-Windows
3595         before XP.
3596
3597         PR gdb/24292
3598         * common/netstuff.c:
3599         * gdbserver/gdbreplay.c
3600         * gdbserver/remote-utils.c:
3601         * ser-tcp.c:
3602         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3603         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3604         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3605         'getaddrinfo' and 'freeaddrinfo' were not available before
3606         Windows XP, and mingw.org's MinGW headers by default define
3607         _WIN32_WINNT to 0x500.
3608
3609 2019-03-01  Gary Benson <gbenson@redhat.com>
3610
3611         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3612
3613 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3614             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3615
3616         PR gdb/8527
3617         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3618         set_sigint_trap, clear_sigint_trap.
3619
3620 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3621
3622         * target.c (target_detach): Clear the regcache and the
3623         frame cache.
3624
3625 2019-02-27  Pedro Alves  <palves@redhat.com>
3626
3627         * utils.c (set_screen_size): When we cap the height/width sizes,
3628         tweak the corresponding command variable to show "unlimited":
3629
3630 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3631             Pedro Alves  <palves@redhat.com>
3632
3633         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3634         before calling rl_set_screen_size.
3635
3636 2019-02-27  Tom Tromey  <tromey@adacore.com>
3637
3638         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3639         define.
3640         * python/py-value.c: Remove Python 2.4 workaround.
3641         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3642         workaround.
3643         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3644         Python 2.4 workaround.
3645         * python/python-internal.h: Remove Python 2.4 comment.
3646         (Py_ssize_t): Don't define.
3647         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3648         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3649         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3650         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3651         * python/python.c (do_start_initialization): Remove Python 2.4
3652         workaround.
3653         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3654         (print_children): Remove Python 2.4 workaround.
3655         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3656         workaround.
3657         (CHARBUFFERPROC_NAME): Remove.
3658         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3659         Python 2.4 workaround.
3660
3661 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3662
3663         * NEWS: Note minimum Python version.
3664
3665 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3666
3667         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3668         code from these functions.  Remove corresponding ifdefs.  Use
3669         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3670         Remove gotos and target of gotos.
3671         (infpy_search_memory): Likewise.
3672
3673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3674
3675         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3676         (hppa_gdbarch_init): Don't register deleted functions with
3677         gdbarch.
3678
3679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3680
3681         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3682         (h8300_unwind_sp): Delete.
3683         (h8300_dummy_id): Delete.
3684         (h8300_gdbarch_init): Don't register deleted functions with
3685         gdbarch.
3686
3687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3688
3689         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3690         (ft32_unwind_pc): Delete.
3691         (ft32_unwind_sp): Delete.
3692         (ft32_gdbarch_init): Don't register deleted functions with
3693         gdbarch.
3694
3695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3698         (frv_unwind_pc): Delete.
3699         (frv_unwind_sp): Delete.
3700         (frv_gdbarch_init): Don't register deleted functions with
3701         gdbarch.
3702
3703 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3704
3705         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3706         (riscv_unwind_pc): Delete.
3707         (riscv_unwind_sp): Delete.
3708         (riscv_gdbarch_init): Don't register deleted functions with
3709         gdbarch.
3710
3711 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3712
3713         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3714         (csky_unwind_pc): Delete.
3715         (csky_unwind_sp): Delete.
3716         (csky_gdbarch_init): Don't register deleted functions with
3717         gdbarch.
3718
3719 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3722         (cris_unwind_pc): Delete.
3723         (cris_unwind_sp): Delete.
3724         (cris_gdbarch_init): Don't register deleted functions with
3725         gdbarch.
3726
3727 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3728
3729         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3730         (bfin_unwind_pc): Delete.
3731         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3732
3733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3736         (arm_unwind_pc): Delete.
3737         (arm_unwind_sp): Delete.
3738         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3739
3740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3741
3742         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3743         (arc_unwind_pc): Delete.
3744         (arc_unwind_sp): Delete.
3745         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3746
3747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3748
3749         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3750         (alpha_unwind_pc): Delete.
3751         (alpha_gdbarch_init): Don't register deleted functions with
3752         gdbarch.
3753
3754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3757         (aarch64_unwind_pc): Delete.
3758         (aarch64_unwind_sp): Delete.
3759         (aarch64_gdbarch_init): Don't register deleted functions with
3760         gdbarch.
3761
3762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * gdbtypes.c (type_align): Don't consider static members when
3765         computing structure alignment.
3766
3767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3768
3769         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3770         return 0 for other types.
3771         * arch-utils.c (default_type_align): Always return 0.
3772         * gdbarch.h: Regenerate.
3773         * gdbarch.sh (type_align): Extend comment.
3774         * gdbtypes.c (type_align): Add additional comments, always call
3775         gdbarch_type_align before applying the default rules.
3776         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3777         generic code will then apply a suitable default.
3778         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3779         types, return 0 for other types.
3780
3781 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3782
3783         * NEWS: Create a new section for the next release branch.
3784         Rename the section of the current branch, now that it has
3785         been cut.
3786
3787 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3788
3789         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3790         * version.in: Bump version to 8.3.50.DATE-git.
3791
3792 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3793
3794         * aix-thread.c (ptid_cmp): Remove unused variable.
3795         (get_signaled_thread): Likewise.
3796         (store_regs_user_thread): Likewise.
3797         (store_regs_kernel_thread): Likewise.
3798         (fetch_regs_kernel_thread): Remove shadowed variable.
3799
3800 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3801
3802         * features/riscv/32bit-cpu.xml: Add register numbers.
3803         * features/riscv/32bit-fpu.c: Regenerate.
3804         * features/riscv/32bit-fpu.xml: Add register numbers.
3805         * features/riscv/64bit-cpu.xml: Add register numbers.
3806         * features/riscv/64bit-fpu.c: Regenerate.
3807         * features/riscv/64bit-fpu.xml: Add register numbers.
3808
3809 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3810
3811         * NEWS: Mention two argument form of gdb.Value constructor.
3812         * python/py-value.c (convert_buffer_and_type_to_value): New
3813         function.
3814         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3815         Add support for handling an optional second argument.  Call
3816         convert_buffer_and_type_to_value as appropriate.
3817         * python/python-internal.h (Py_buffer_deleter): New struct.
3818         (Py_buffer_up): New typedef.
3819
3820 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3821
3822         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3823         instead of releasing ownership.
3824
3825 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3826
3827         * dwarf2read.c (open_and_init_dwp_file): Call
3828         elf_numsections instead of bfd_count_sections to initialize
3829         dwp_file->num_sections.
3830
3831 2019-02-25  Tom Tromey  <tromey@adacore.com>
3832
3833         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3834
3835 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3836
3837         * gcore.in: Add '--readnever' option when invoking GDB.
3838
3839 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3840
3841         * MAINTAINERS: Update my email address.
3842
3843 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3844
3845         * build-id.c (build_id_to_debug_bfd_1): New function.
3846         (build_id_to_debug_bfd): Look for separate debug file in
3847         sysroot.
3848
3849 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * gdbarch.sh: Update the copyright year range that is placed into
3852         generated files.
3853
3854 2019-02-22  Keith Seitz  <keiths@redhat.com>
3855
3856         PR symtab/23853
3857         * linespec.c (create_sals_line_offset): Search for the default
3858         symtab's filename instead of its fullname.
3859
3860 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3861
3862         * NEWS: Update style defaults.
3863
3864 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3865
3866         * main.c (captured_main_1): Disable styling in batch mode.
3867
3868 2019-02-20  Tom Tromey  <tom@tromey.com>
3869
3870         * symtab.c (symtab_symbol_info): Fix typos.
3871
3872 2019-02-20  Tom Tromey  <tromey@adacore.com>
3873
3874         * findcmd.c (_initialize_mem_search): Use upper case for
3875         metasyntactic variables.
3876
3877 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3878
3879         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3880         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3881
3882 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3883
3884         * top.h (source_file_name): Change to std::string.
3885         * top.c (source_file_name): Likewise.
3886         (command_line_input): Adjust.
3887         * cli/cli-script.c (script_from_file): Adjust.
3888
3889 2019-02-19  Tom Tromey  <tromey@adacore.com>
3890
3891         * ravenscar-thread.c
3892         (ravenscar_thread_target::update_thread_list): Don't call
3893         ada_build_task_list.
3894         * ada-lang.h (ada_build_task_list): Don't declare.
3895         * ada-tasks.c (struct ada_tasks_inferior_data)
3896         <task_list_valid_p>: Now bool.
3897         (read_known_tasks, ada_task_list_changed)
3898         (ada_tasks_invalidate_inferior_data): Update.
3899         (read_known_tasks_array): Return bool.
3900         (read_known_tasks_list): Likewise.
3901         (read_known_tasks): Return void.
3902         (ada_build_task_list): Now static.
3903
3904 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3905
3906         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3907         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3908
3909 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3910
3911         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3912         variant for ada_tasks_pspace_data_handle and
3913         ada_tasks_inferior_data_handle.
3914         (ada_tasks_pspace_data_cleanup): New function.
3915         (ada_tasks_inferior_data_cleanup): New function.
3916
3917 2019-02-17  Tom Tromey  <tom@tromey.com>
3918
3919         * macrotab.h (macro_source_fullname): Return a std::string.
3920         * macrotab.c (macro_include, check_for_redefinition)
3921         (macro_undef, macro_lookup_definition, foreach_macro)
3922         (foreach_macro_in_scope): Update.
3923         (macro_source_fullname): Return a std::string.
3924         * macrocmd.c (show_pp_source_pos): Update.
3925
3926 2019-02-17  Tom Tromey  <tom@tromey.com>
3927
3928         * macrocmd.c (show_pp_source_pos): Style the file names.
3929
3930 2019-02-17  Tom Tromey  <tom@tromey.com>
3931
3932         PR tui/24197:
3933         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3934
3935 2019-02-17  Tom Tromey  <tom@tromey.com>
3936
3937         * ada-lang.c (user_select_syms): Use filtered printing.
3938         * utils.c (wrap_style): New global.
3939         (desired_style): Remove.
3940         (emit_style_escape): Add stream parameter.
3941         (set_output_style, reset_terminal_style, prompt_for_continue):
3942         Update.
3943         (flush_wrap_buffer): Only flush gdb_stdout.
3944         (wrap_here): Set wrap_style.
3945         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3946         treat escape sequences as a character.  Change when wrap buffer is
3947         flushed.
3948         (fputs_styled): Do not set the output style when the default is
3949         requested.
3950         * ui-style.h (struct ui_file_style) <is_default>: New method.
3951         * source.c (print_source_lines_base): Emit escape sequences in one
3952         piece.
3953
3954 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3955
3956         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3957         integers and enumeration types.
3958
3959 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3960
3961         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3962         instead of lookup_symbol_in_language
3963         (do_exact_match): New function.
3964         (ada_get_symbol_name_matcher): Return do_exact_match when
3965         doing a verbatim match.
3966
3967 2019-02-15  Tom Tromey  <tromey@adacore.com>
3968
3969         * ravenscar-thread.c (ravenscar_thread_target::resume)
3970         (ravenscar_thread_target::wait): Special case wildcard requests.
3971
3972 2019-02-15  Tom Tromey  <tromey@adacore.com>
3973
3974         * ravenscar-thread.c (base_ptid): Remove.
3975         (struct ravenscar_thread_target) <close>: New method.
3976         <m_base_ptid>: New member.
3977         <update_inferior_ptid, active_task, task_is_currently_active,
3978         runtime_initialized>: Declare methods.
3979         <ravenscar_thread_target>: Add constructor.
3980         (ravenscar_thread_target::task_is_currently_active)
3981         (ravenscar_thread_target::update_inferior_ptid)
3982         (ravenscar_runtime_initialized): Rename.  Now methods.
3983         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3984         (ravenscar_thread_target::update_thread_list): Update.
3985         (ravenscar_thread_target::active_task): Now method.
3986         (ravenscar_thread_target::store_registers)
3987         (ravenscar_thread_target::prepare_to_store)
3988         (ravenscar_thread_target::prepare_to_store)
3989         (ravenscar_thread_target::mourn_inferior): Update.
3990         (ravenscar_inferior_created): Use "new" to create target.
3991         (ravenscar_thread_target::get_ada_task_ptid): Update.
3992         (_initialize_ravenscar): Don't initialize base_ptid.
3993         (ravenscar_ops): Remove global.
3994
3995 2019-02-15  Tom Tromey  <tromey@adacore.com>
3996
3997         * target.h (push_target): Declare new overload.
3998         * target.c (push_target): New overload, taking an rvalue reference.
3999         * remote.c (remote_target::open_1): Use push_target overload.
4000         * corelow.c (core_target_open): Use push_target overload.
4001
4002 2019-02-15  Tom Tromey  <tromey@adacore.com>
4003
4004         * ravenscar-thread.c (is_ravenscar_task)
4005         (ravenscar_task_is_currently_active): Return bool.
4006         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4007         (_initialize_ravenscar): Remove "(void)".
4008         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4009         Return bool.
4010
4011 2019-02-15  Tom Tromey  <tromey@adacore.com>
4012
4013         * ravenscar-thread.c (ravenscar_runtime_initializer)
4014         (has_ravenscar_runtime, get_running_thread_id)
4015         (ravenscar_thread_target::resume): Fix indentation.
4016
4017 2019-02-15  Tom Tromey  <tromey@adacore.com>
4018
4019         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4020         from ravenscar_arch_ops.
4021         (sparc_ravenscar_ops::fetch_registers)
4022         (sparc_ravenscar_ops::store_registers): Now methods.
4023         (sparc_ravenscar_prepare_to_store): Remove.
4024         (sparc_ravenscar_ops): Redefine.
4025         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4026         methods and destructor.  Remove members.
4027         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4028         (ravenscar_thread_target::store_registers)
4029         (ravenscar_thread_target::prepare_to_store): Update.
4030         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4031         Remove.
4032         (struct ppc_ravenscar_powerpc_ops): Derive from
4033         ravenscar_arch_ops.
4034         (ppc_ravenscar_powerpc_ops::fetch_registers)
4035         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4036         (ppc_ravenscar_powerpc_ops): Redefine.
4037         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4038         (ppc_ravenscar_e500_ops::fetch_registers)
4039         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4040         (ppc_ravenscar_e500_ops): Redefine.
4041         * aarch64-ravenscar-thread.c
4042         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4043         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4044         (aarch64_ravenscar_fetch_registers)
4045         (aarch64_ravenscar_store_registers): Now methods.
4046         (aarch64_ravenscar_ops): Redefine.
4047
4048 2019-02-15  Tom Tromey  <tromey@adacore.com>
4049
4050         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4051         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4052         (ravenscar_thread_target::stopped_by_watchpoint)
4053         (ravenscar_thread_target::stopped_data_address)
4054         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4055
4056 2019-02-15  Tom Tromey  <tromey@adacore.com>
4057
4058         * ravenscar-thread.c: Fix some typos.
4059
4060 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4061             Tom Tromey  <tromey@adacore.com>
4062
4063         * ada-lang.c (ada_exception_sal): Change addr_string to a
4064         std::string.
4065         (create_ada_exception_catchpoint): Update.
4066
4067 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4068             Tom Tromey  <tromey@adacore.com>
4069
4070         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4071         (bp_location_ops): Remove.
4072         (base_breakpoint_allocate_location): Update.
4073         (free_bp_location): Update.
4074         * ada-lang.c (class ada_catchpoint_location)
4075         <ada_catchpoint_location>: Remove ops parameter.
4076         (ada_catchpoint_location_dtor): Remove.
4077         (ada_catchpoint_location_ops): Remove.
4078         (allocate_location_exception): Update.
4079         * breakpoint.h (struct bp_location_ops): Remove.
4080         (class bp_location) <bp_location>: Remove bp_location_ops
4081         parameter.
4082         <~bp_location>: Add destructor.
4083         <ops>: Remove.
4084
4085 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4086             Pedro Alves  <palves@redhat.com>
4087
4088         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4089         'PATH_MAX'.
4090
4091 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4092             Samuel Thibault  <samuel.thibault@gnu.org>
4093             Thomas Schwinge  <thomas@codesourcery.com>
4094
4095         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4096         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4097
4098 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4099
4100         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4101         (check_empty): Use "const char *".
4102
4103         * gnu-nat.c (gnu_nat_target::detach): Instead of
4104         'detach_inferior (pid)' call
4105         'detach_inferior (find_inferior_pid (pid))'.
4106
4107         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4108         'nat/fork-inferior.o'.
4109         * gnu-nat.c: #include "nat/fork-inferior.h".
4110
4111         * gnu-nat.c (gnu_nat_target::detach): Instead of
4112         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4113         * gnu-nat.h: #include "inf-child.h".
4114         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4115         'i386_gnu_nat_target::fetch_registers'.
4116         (gnu_store_registers): Rename/move to
4117         'i386_gnu_nat_target::store_registers'.
4118
4119         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4120         * gnu-nat.h (mach_thread_info): New function.
4121         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4122
4123         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4124
4125 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4126
4127         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4128
4129 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4130
4131         * windows-nat.c (windows_add_thread): Add new parameter
4132         "main_thread_p" with default value set to false.  Update
4133         function documentation as well as all callers.
4134         (windows_delete_thread): Likewise.
4135         (fake_create_process): Update call to windows_add_thread.
4136         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4137         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4138         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4139         call to windows_delete_thread.
4140
4141 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4142
4143         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4144
4145 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4146
4147         * symfile.c (find_separate_debug_file): Use canonical path of
4148         sysroot with child_path instead of gdb_sysroot if it is valid.
4149
4150 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4151
4152         * symfile.c (find_separate_debug_file): Use child_path to
4153         determine if an object file is under a sysroot.
4154
4155 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4156
4157         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4158         unittests/child-path-selftests.c.
4159         * common/pathstuff.c (child_path): New function.
4160         * common/pathstuff.h (child_path): New prototype.
4161         * unittests/child-path-selftests.c: New file.
4162
4163 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4164
4165         * symfile.c (find_separate_debug_file): Look for separate debug
4166         files in debug directories under the sysroot.
4167
4168 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4169
4170         * symtab.h (struct minimal_symbol data_p): New const method.
4171         (struct minimal_symbol text_p): Likewise.
4172         * symtab.c (output_source_filename): Use file name style
4173         to print file name.
4174         (print_symbol_info): Likewise.
4175         (print_msymbol_info): Use address style to print addresses.
4176         Use function name style to print executable text symbols.
4177         (expand_symtab_containing_pc): Use data_p.
4178         (find_pc_sect_compunit_symtab): Likewise.
4179
4180 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4181
4182         * breakpoint.c (describe_other_breakpoints): Use address style
4183         to print addresses.
4184         (say_where): Likewise.
4185
4186 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4187
4188         * ada-typeprint.c (print_func_type): Print function name
4189         style to print function name.
4190         * c-typeprint.c (c_print_type_1): Likewise.
4191
4192 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4193
4194         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4195         for execve.
4196
4197 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4198
4199         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4200         type_stack.
4201
4202 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4203
4204         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4205         TYPE_CODE_REF types.
4206
4207 2019-02-08  Jim Wilson  <jimw@sifive.com>
4208
4209         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4210         (riscv_linux_fregset): New.
4211         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4212
4213 2019-02-07  Tom Tromey  <tom@tromey.com>
4214
4215         * thread.c (thread_cancel_execution_command): Update.
4216         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4217         methods.
4218         (struct thread_fsm_ops): Remove.
4219         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4220         (thread_fsm_should_stop, thread_fsm_return_value)
4221         (thread_fsm_set_finished, thread_fsm_finished_p)
4222         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4223         Don't declare.
4224         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4225         * infrun.c (clear_proceed_status_thread)
4226         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4227         (print_stop_event): Update.
4228         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4229         Add constructor.
4230         (step_command_fsm_ops): Remove.
4231         (new_step_command_fsm): Remove.
4232         (step_1): Update.
4233         (step_command_fsm::should_stop): Rename from
4234         step_command_fsm_should_stop.
4235         (step_command_fsm::clean_up): Rename from
4236         step_command_fsm_clean_up.
4237         (step_command_fsm::do_async_reply_reason): Rename from
4238         step_command_fsm_async_reply_reason.
4239         (struct until_next_fsm): Inherit from thread_fsm.  Add
4240         constructor.
4241         (until_next_fsm_ops): Remove.
4242         (new_until_next_fsm): Remove.
4243         (until_next_fsm::should_stop): Rename from
4244         until_next_fsm_should_stop.
4245         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4246         (until_next_fsm::do_async_reply_reason): Rename from
4247         until_next_fsm_async_reply_reason.
4248         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4249         constructor.  Change type of breakpoint.
4250         (finish_command_fsm_ops): Remove.
4251         (new_finish_command_fsm): Remove.
4252         (finish_command_fsm::should_stop): Rename from
4253         finish_command_fsm_should_stop.
4254         (finish_command_fsm::clean_up): Rename from
4255         finish_command_fsm_clean_up.
4256         (finish_command_fsm::return_value): Rename from
4257         finish_command_fsm_return_value.
4258         (finish_command_fsm::do_async_reply_reason): Rename from
4259         finish_command_fsm_async_reply_reason.
4260         (finish_command): Update.
4261         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4262         Add constructor.
4263         (call_thread_fsm_ops): Remove.
4264         (call_thread_fsm::call_thread_fsm): Rename from
4265         new_call_thread_fsm.
4266         (call_thread_fsm::should_stop): Rename from
4267         call_thread_fsm_should_stop.
4268         (call_thread_fsm::should_notify_stop): Rename from
4269         call_thread_fsm_should_notify_stop.
4270         (run_inferior_call, call_function_by_hand_dummy): Update.
4271         * cli/cli-interp.c (should_print_stop_to_console): Update.
4272         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4273         Add constructor.  Change type of location_breakpoint,
4274         caller_breakpoint.
4275         (until_break_fsm_ops): Remove.
4276         (new_until_break_fsm): Remove.
4277         (until_break_fsm::should_stop): Rename from
4278         until_break_fsm_should_stop.
4279         (until_break_fsm::clean_up): Rename from
4280         until_break_fsm_clean_up.
4281         (until_break_fsm::do_async_reply_reason): Rename from
4282         until_break_fsm_async_reply_reason.
4283         (until_break_command): Update.
4284         * thread-fsm.c: Remove.
4285         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4286
4287 2019-02-07  Tom Tromey  <tom@tromey.com>
4288
4289         * yy-remap.h: Add include guard.
4290         * xtensa-tdep.h: Add include guard.
4291         * xcoffread.h: Rename include guard.
4292         * varobj-iter.h: Add include guard.
4293         * tui/tui.h: Rename include guard.
4294         * tui/tui-winsource.h: Rename include guard.
4295         * tui/tui-wingeneral.h: Rename include guard.
4296         * tui/tui-windata.h: Rename include guard.
4297         * tui/tui-win.h: Rename include guard.
4298         * tui/tui-stack.h: Rename include guard.
4299         * tui/tui-source.h: Rename include guard.
4300         * tui/tui-regs.h: Rename include guard.
4301         * tui/tui-out.h: Rename include guard.
4302         * tui/tui-layout.h: Rename include guard.
4303         * tui/tui-io.h: Rename include guard.
4304         * tui/tui-hooks.h: Rename include guard.
4305         * tui/tui-file.h: Rename include guard.
4306         * tui/tui-disasm.h: Rename include guard.
4307         * tui/tui-data.h: Rename include guard.
4308         * tui/tui-command.h: Rename include guard.
4309         * tic6x-tdep.h: Add include guard.
4310         * target/waitstatus.h: Rename include guard.
4311         * target/wait.h: Rename include guard.
4312         * target/target.h: Rename include guard.
4313         * target/resume.h: Rename include guard.
4314         * target-float.h: Rename include guard.
4315         * stabsread.h: Add include guard.
4316         * rs6000-tdep.h: Add include guard.
4317         * riscv-fbsd-tdep.h: Add include guard.
4318         * regformats/regdef.h: Rename include guard.
4319         * record.h: Rename include guard.
4320         * python/python.h: Rename include guard.
4321         * python/python-internal.h: Rename include guard.
4322         * python/py-stopevent.h: Rename include guard.
4323         * python/py-ref.h: Rename include guard.
4324         * python/py-record.h: Rename include guard.
4325         * python/py-record-full.h: Rename include guard.
4326         * python/py-record-btrace.h: Rename include guard.
4327         * python/py-instruction.h: Rename include guard.
4328         * python/py-events.h: Rename include guard.
4329         * python/py-event.h: Rename include guard.
4330         * procfs.h: Add include guard.
4331         * proc-utils.h: Add include guard.
4332         * p-lang.h: Add include guard.
4333         * or1k-tdep.h: Rename include guard.
4334         * observable.h: Rename include guard.
4335         * nto-tdep.h: Rename include guard.
4336         * nat/x86-linux.h: Rename include guard.
4337         * nat/x86-linux-dregs.h: Rename include guard.
4338         * nat/x86-gcc-cpuid.h: Add include guard.
4339         * nat/x86-dregs.h: Rename include guard.
4340         * nat/x86-cpuid.h: Rename include guard.
4341         * nat/ppc-linux.h: Rename include guard.
4342         * nat/mips-linux-watch.h: Rename include guard.
4343         * nat/linux-waitpid.h: Rename include guard.
4344         * nat/linux-ptrace.h: Rename include guard.
4345         * nat/linux-procfs.h: Rename include guard.
4346         * nat/linux-osdata.h: Rename include guard.
4347         * nat/linux-nat.h: Rename include guard.
4348         * nat/linux-namespaces.h: Rename include guard.
4349         * nat/linux-btrace.h: Rename include guard.
4350         * nat/glibc_thread_db.h: Rename include guard.
4351         * nat/gdb_thread_db.h: Rename include guard.
4352         * nat/gdb_ptrace.h: Rename include guard.
4353         * nat/fork-inferior.h: Rename include guard.
4354         * nat/amd64-linux-siginfo.h: Rename include guard.
4355         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4356         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4357         * nat/aarch64-linux.h: Rename include guard.
4358         * nat/aarch64-linux-hw-point.h: Rename include guard.
4359         * mn10300-tdep.h: Add include guard.
4360         * mips-linux-tdep.h: Add include guard.
4361         * mi/mi-parse.h: Rename include guard.
4362         * mi/mi-out.h: Rename include guard.
4363         * mi/mi-main.h: Rename include guard.
4364         * mi/mi-interp.h: Rename include guard.
4365         * mi/mi-getopt.h: Rename include guard.
4366         * mi/mi-console.h: Rename include guard.
4367         * mi/mi-common.h: Rename include guard.
4368         * mi/mi-cmds.h: Rename include guard.
4369         * mi/mi-cmd-break.h: Rename include guard.
4370         * m2-lang.h: Add include guard.
4371         * location.h: Rename include guard.
4372         * linux-record.h: Rename include guard.
4373         * linux-nat.h: Add include guard.
4374         * linux-fork.h: Add include guard.
4375         * i386-darwin-tdep.h: Rename include guard.
4376         * hppa-linux-offsets.h: Add include guard.
4377         * guile/guile.h: Rename include guard.
4378         * guile/guile-internal.h: Rename include guard.
4379         * gnu-nat.h: Rename include guard.
4380         * gdb-stabs.h: Rename include guard.
4381         * frv-tdep.h: Add include guard.
4382         * f-lang.h: Add include guard.
4383         * event-loop.h: Add include guard.
4384         * darwin-nat.h: Rename include guard.
4385         * cp-abi.h: Rename include guard.
4386         * config/sparc/nm-sol2.h: Rename include guard.
4387         * config/nm-nto.h: Rename include guard.
4388         * config/nm-linux.h: Add include guard.
4389         * config/i386/nm-i386gnu.h: Rename include guard.
4390         * config/djgpp/nl_types.h: Rename include guard.
4391         * config/djgpp/langinfo.h: Rename include guard.
4392         * compile/gcc-cp-plugin.h: Add include guard.
4393         * compile/gcc-c-plugin.h: Add include guard.
4394         * compile/compile.h: Rename include guard.
4395         * compile/compile-object-run.h: Rename include guard.
4396         * compile/compile-object-load.h: Rename include guard.
4397         * compile/compile-internal.h: Rename include guard.
4398         * compile/compile-cplus.h: Rename include guard.
4399         * compile/compile-c.h: Rename include guard.
4400         * common/xml-utils.h: Rename include guard.
4401         * common/x86-xstate.h: Rename include guard.
4402         * common/version.h: Rename include guard.
4403         * common/vec.h: Rename include guard.
4404         * common/tdesc.h: Rename include guard.
4405         * common/selftest.h: Rename include guard.
4406         * common/scoped_restore.h: Rename include guard.
4407         * common/scoped_mmap.h: Rename include guard.
4408         * common/scoped_fd.h: Rename include guard.
4409         * common/safe-iterator.h: Rename include guard.
4410         * common/run-time-clock.h: Rename include guard.
4411         * common/refcounted-object.h: Rename include guard.
4412         * common/queue.h: Rename include guard.
4413         * common/ptid.h: Rename include guard.
4414         * common/print-utils.h: Rename include guard.
4415         * common/preprocessor.h: Rename include guard.
4416         * common/pathstuff.h: Rename include guard.
4417         * common/observable.h: Rename include guard.
4418         * common/netstuff.h: Rename include guard.
4419         * common/job-control.h: Rename include guard.
4420         * common/host-defs.h: Rename include guard.
4421         * common/gdb_wait.h: Rename include guard.
4422         * common/gdb_vecs.h: Rename include guard.
4423         * common/gdb_unlinker.h: Rename include guard.
4424         * common/gdb_unique_ptr.h: Rename include guard.
4425         * common/gdb_tilde_expand.h: Rename include guard.
4426         * common/gdb_sys_time.h: Rename include guard.
4427         * common/gdb_string_view.h: Rename include guard.
4428         * common/gdb_splay_tree.h: Rename include guard.
4429         * common/gdb_setjmp.h: Rename include guard.
4430         * common/gdb_ref_ptr.h: Rename include guard.
4431         * common/gdb_optional.h: Rename include guard.
4432         * common/gdb_locale.h: Rename include guard.
4433         * common/gdb_assert.h: Rename include guard.
4434         * common/filtered-iterator.h: Rename include guard.
4435         * common/filestuff.h: Rename include guard.
4436         * common/fileio.h: Rename include guard.
4437         * common/environ.h: Rename include guard.
4438         * common/common-utils.h: Rename include guard.
4439         * common/common-types.h: Rename include guard.
4440         * common/common-regcache.h: Rename include guard.
4441         * common/common-inferior.h: Rename include guard.
4442         * common/common-gdbthread.h: Rename include guard.
4443         * common/common-exceptions.h: Rename include guard.
4444         * common/common-defs.h: Rename include guard.
4445         * common/common-debug.h: Rename include guard.
4446         * common/cleanups.h: Rename include guard.
4447         * common/buffer.h: Rename include guard.
4448         * common/btrace-common.h: Rename include guard.
4449         * common/break-common.h: Rename include guard.
4450         * cli/cli-utils.h: Rename include guard.
4451         * cli/cli-style.h: Rename include guard.
4452         * cli/cli-setshow.h: Rename include guard.
4453         * cli/cli-script.h: Rename include guard.
4454         * cli/cli-interp.h: Rename include guard.
4455         * cli/cli-decode.h: Rename include guard.
4456         * cli/cli-cmds.h: Rename include guard.
4457         * charset-list.h: Add include guard.
4458         * buildsym-legacy.h: Rename include guard.
4459         * bfin-tdep.h: Add include guard.
4460         * ax.h: Rename include guard.
4461         * arm-linux-tdep.h: Add include guard.
4462         * arm-fbsd-tdep.h: Add include guard.
4463         * arch/xtensa.h: Rename include guard.
4464         * arch/tic6x.h: Add include guard.
4465         * arch/i386.h: Add include guard.
4466         * arch/arm.h: Rename include guard.
4467         * arch/arm-linux.h: Rename include guard.
4468         * arch/arm-get-next-pcs.h: Rename include guard.
4469         * arch/amd64.h: Add include guard.
4470         * arch/aarch64-insn.h: Rename include guard.
4471         * arch-utils.h: Rename include guard.
4472         * annotate.h: Add include guard.
4473         * amd64-darwin-tdep.h: Rename include guard.
4474         * aarch64-linux-tdep.h: Add include guard.
4475         * aarch64-fbsd-tdep.h: Add include guard.
4476         * aarch32-linux-nat.h: Add include guard.
4477
4478 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4479
4480         * macrotab.c (macro_define_internal): New function that
4481         factorizes macro_define_object_internal and macro_define_function
4482         code.
4483         (macro_define_object_internal): Use macro_define_internal.
4484         (macro_define_function): Likewise.
4485
4486 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4487
4488         * macrocmd.c (extract_identifier): Return
4489         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4490         callers.
4491
4492 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4493
4494         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4495
4496 2019-02-05  Tom Tromey  <tom@tromey.com>
4497
4498         * target.c (target_stack::unpush): Move assertion earlier.
4499
4500 2019-01-30  Tom Tromey  <tom@tromey.com>
4501
4502         PR python/23615:
4503         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4504         (gdbpy_parse_and_eval): Likewise.
4505         * python/python-internal.h (gdbpy_allow_threads): New class.
4506
4507 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4508
4509         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4510         (aarch64_fbsd_fpregmap): Move earlier.
4511         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4512         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4513         instead of individual calls to trad_frame_set_reg_addr.
4514         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4515         earlier.
4516         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4517         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4518         instead of individual calls to trad_frame_set_reg_addr.
4519
4520 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4521
4522         * CONTRIBUTE: Replace contribution list with wiki link.
4523
4524 2019-01-25  Tom Tromey  <tom@tromey.com>
4525
4526         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4527
4528 2019-01-25  Tom Tromey  <tom@tromey.com>
4529
4530         * xtensa-linux-nat.c: Fix common/ includes.
4531         * xml-support.h: Fix common/ includes.
4532         * xml-support.c: Fix common/ includes.
4533         * x86-linux-nat.c: Fix common/ includes.
4534         * windows-nat.c: Fix common/ includes.
4535         * varobj.h: Fix common/ includes.
4536         * varobj.c: Fix common/ includes.
4537         * value.c: Fix common/ includes.
4538         * valops.c: Fix common/ includes.
4539         * utils.c: Fix common/ includes.
4540         * unittests/xml-utils-selftests.c: Fix common/ includes.
4541         * unittests/utils-selftests.c: Fix common/ includes.
4542         * unittests/unpack-selftests.c: Fix common/ includes.
4543         * unittests/tracepoint-selftests.c: Fix common/ includes.
4544         * unittests/style-selftests.c: Fix common/ includes.
4545         * unittests/string_view-selftests.c: Fix common/ includes.
4546         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4547         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4548         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4549         * unittests/rsp-low-selftests.c: Fix common/ includes.
4550         * unittests/parse-connection-spec-selftests.c: Fix common/
4551         includes.
4552         * unittests/optional-selftests.c: Fix common/ includes.
4553         * unittests/offset-type-selftests.c: Fix common/ includes.
4554         * unittests/observable-selftests.c: Fix common/ includes.
4555         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4556         * unittests/memrange-selftests.c: Fix common/ includes.
4557         * unittests/memory-map-selftests.c: Fix common/ includes.
4558         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4559         * unittests/function-view-selftests.c: Fix common/ includes.
4560         * unittests/environ-selftests.c: Fix common/ includes.
4561         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4562         * unittests/common-utils-selftests.c: Fix common/ includes.
4563         * unittests/cli-utils-selftests.c: Fix common/ includes.
4564         * unittests/array-view-selftests.c: Fix common/ includes.
4565         * ui-file.c: Fix common/ includes.
4566         * tui/tui-io.c: Fix common/ includes.
4567         * tracepoint.h: Fix common/ includes.
4568         * tracepoint.c: Fix common/ includes.
4569         * tracefile-tfile.c: Fix common/ includes.
4570         * top.h: Fix common/ includes.
4571         * top.c: Fix common/ includes.
4572         * thread.c: Fix common/ includes.
4573         * target/waitstatus.h: Fix common/ includes.
4574         * target/waitstatus.c: Fix common/ includes.
4575         * target.h: Fix common/ includes.
4576         * target.c: Fix common/ includes.
4577         * target-memory.c: Fix common/ includes.
4578         * target-descriptions.c: Fix common/ includes.
4579         * symtab.h: Fix common/ includes.
4580         * symfile.c: Fix common/ includes.
4581         * stap-probe.c: Fix common/ includes.
4582         * spu-linux-nat.c: Fix common/ includes.
4583         * sparc-nat.c: Fix common/ includes.
4584         * source.c: Fix common/ includes.
4585         * solib.c: Fix common/ includes.
4586         * solib-target.c: Fix common/ includes.
4587         * ser-unix.c: Fix common/ includes.
4588         * ser-tcp.c: Fix common/ includes.
4589         * ser-pipe.c: Fix common/ includes.
4590         * ser-base.c: Fix common/ includes.
4591         * selftest-arch.c: Fix common/ includes.
4592         * s12z-tdep.c: Fix common/ includes.
4593         * rust-exp.y: Fix common/ includes.
4594         * rs6000-aix-tdep.c: Fix common/ includes.
4595         * riscv-tdep.c: Fix common/ includes.
4596         * remote.c: Fix common/ includes.
4597         * remote-notif.h: Fix common/ includes.
4598         * remote-fileio.h: Fix common/ includes.
4599         * remote-fileio.c: Fix common/ includes.
4600         * regcache.h: Fix common/ includes.
4601         * regcache.c: Fix common/ includes.
4602         * record-btrace.c: Fix common/ includes.
4603         * python/python.c: Fix common/ includes.
4604         * python/py-type.c: Fix common/ includes.
4605         * python/py-inferior.c: Fix common/ includes.
4606         * progspace.h: Fix common/ includes.
4607         * producer.c: Fix common/ includes.
4608         * procfs.c: Fix common/ includes.
4609         * proc-api.c: Fix common/ includes.
4610         * printcmd.c: Fix common/ includes.
4611         * ppc-linux-nat.c: Fix common/ includes.
4612         * parser-defs.h: Fix common/ includes.
4613         * osdata.c: Fix common/ includes.
4614         * obsd-nat.c: Fix common/ includes.
4615         * nat/x86-linux.c: Fix common/ includes.
4616         * nat/x86-linux-dregs.c: Fix common/ includes.
4617         * nat/x86-dregs.h: Fix common/ includes.
4618         * nat/x86-dregs.c: Fix common/ includes.
4619         * nat/ppc-linux.c: Fix common/ includes.
4620         * nat/mips-linux-watch.h: Fix common/ includes.
4621         * nat/mips-linux-watch.c: Fix common/ includes.
4622         * nat/linux-waitpid.c: Fix common/ includes.
4623         * nat/linux-ptrace.h: Fix common/ includes.
4624         * nat/linux-ptrace.c: Fix common/ includes.
4625         * nat/linux-procfs.c: Fix common/ includes.
4626         * nat/linux-personality.c: Fix common/ includes.
4627         * nat/linux-osdata.c: Fix common/ includes.
4628         * nat/linux-namespaces.c: Fix common/ includes.
4629         * nat/linux-btrace.h: Fix common/ includes.
4630         * nat/linux-btrace.c: Fix common/ includes.
4631         * nat/fork-inferior.c: Fix common/ includes.
4632         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4633         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4634         * nat/aarch64-linux.c: Fix common/ includes.
4635         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4636         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4637         * namespace.h: Fix common/ includes.
4638         * mips-linux-tdep.c: Fix common/ includes.
4639         * minsyms.c: Fix common/ includes.
4640         * mi/mi-parse.h: Fix common/ includes.
4641         * mi/mi-main.c: Fix common/ includes.
4642         * mi/mi-cmd-env.c: Fix common/ includes.
4643         * memrange.h: Fix common/ includes.
4644         * memattr.c: Fix common/ includes.
4645         * maint.h: Fix common/ includes.
4646         * maint.c: Fix common/ includes.
4647         * main.c: Fix common/ includes.
4648         * machoread.c: Fix common/ includes.
4649         * location.c: Fix common/ includes.
4650         * linux-thread-db.c: Fix common/ includes.
4651         * linux-nat.c: Fix common/ includes.
4652         * linux-fork.c: Fix common/ includes.
4653         * inline-frame.c: Fix common/ includes.
4654         * infrun.c: Fix common/ includes.
4655         * inflow.c: Fix common/ includes.
4656         * inferior.h: Fix common/ includes.
4657         * inferior.c: Fix common/ includes.
4658         * infcmd.c: Fix common/ includes.
4659         * inf-ptrace.c: Fix common/ includes.
4660         * inf-child.c: Fix common/ includes.
4661         * ia64-linux-nat.c: Fix common/ includes.
4662         * i387-tdep.c: Fix common/ includes.
4663         * i386-tdep.c: Fix common/ includes.
4664         * i386-linux-tdep.c: Fix common/ includes.
4665         * i386-linux-nat.c: Fix common/ includes.
4666         * i386-go32-tdep.c: Fix common/ includes.
4667         * i386-fbsd-tdep.c: Fix common/ includes.
4668         * i386-fbsd-nat.c: Fix common/ includes.
4669         * guile/scm-type.c: Fix common/ includes.
4670         * guile/guile.c: Fix common/ includes.
4671         * go32-nat.c: Fix common/ includes.
4672         * gnu-nat.c: Fix common/ includes.
4673         * gdbthread.h: Fix common/ includes.
4674         * gdbarch-selftests.c: Fix common/ includes.
4675         * gdb_usleep.c: Fix common/ includes.
4676         * gdb_select.h: Fix common/ includes.
4677         * gdb_bfd.c: Fix common/ includes.
4678         * gcore.c: Fix common/ includes.
4679         * fork-child.c: Fix common/ includes.
4680         * findvar.c: Fix common/ includes.
4681         * fbsd-nat.c: Fix common/ includes.
4682         * event-top.c: Fix common/ includes.
4683         * event-loop.c: Fix common/ includes.
4684         * dwarf2read.c: Fix common/ includes.
4685         * dwarf2loc.c: Fix common/ includes.
4686         * dwarf2-frame.c: Fix common/ includes.
4687         * dwarf-index-cache.c: Fix common/ includes.
4688         * dtrace-probe.c: Fix common/ includes.
4689         * disasm-selftests.c: Fix common/ includes.
4690         * defs.h: Fix common/ includes.
4691         * csky-tdep.c: Fix common/ includes.
4692         * cp-valprint.c: Fix common/ includes.
4693         * cp-support.h: Fix common/ includes.
4694         * cp-support.c: Fix common/ includes.
4695         * corelow.c: Fix common/ includes.
4696         * completer.h: Fix common/ includes.
4697         * completer.c: Fix common/ includes.
4698         * compile/compile.c: Fix common/ includes.
4699         * compile/compile-loc2c.c: Fix common/ includes.
4700         * compile/compile-cplus-types.c: Fix common/ includes.
4701         * compile/compile-cplus-symbols.c: Fix common/ includes.
4702         * command.h: Fix common/ includes.
4703         * cli/cli-dump.c: Fix common/ includes.
4704         * cli/cli-cmds.c: Fix common/ includes.
4705         * charset.c: Fix common/ includes.
4706         * build-id.c: Fix common/ includes.
4707         * btrace.h: Fix common/ includes.
4708         * btrace.c: Fix common/ includes.
4709         * breakpoint.h: Fix common/ includes.
4710         * breakpoint.c: Fix common/ includes.
4711         * ax.h:
4712         (enum agent_op): Fix common/ includes.
4713         * ax-general.c (struct aop_map): Fix common/ includes.
4714         * ax-gdb.c: Fix common/ includes.
4715         * auxv.c: Fix common/ includes.
4716         * auto-load.c: Fix common/ includes.
4717         * arm-tdep.c: Fix common/ includes.
4718         * arch/riscv.c: Fix common/ includes.
4719         * arch/ppc-linux-common.c: Fix common/ includes.
4720         * arch/i386.c: Fix common/ includes.
4721         * arch/arm.c: Fix common/ includes.
4722         * arch/arm-linux.c: Fix common/ includes.
4723         * arch/arm-get-next-pcs.c: Fix common/ includes.
4724         * arch/amd64.c: Fix common/ includes.
4725         * arch/aarch64.c: Fix common/ includes.
4726         * arch/aarch64-insn.c: Fix common/ includes.
4727         * arch-utils.c: Fix common/ includes.
4728         * amd64-windows-tdep.c: Fix common/ includes.
4729         * amd64-tdep.c: Fix common/ includes.
4730         * amd64-sol2-tdep.c: Fix common/ includes.
4731         * amd64-obsd-tdep.c: Fix common/ includes.
4732         * amd64-nbsd-tdep.c: Fix common/ includes.
4733         * amd64-linux-tdep.c: Fix common/ includes.
4734         * amd64-linux-nat.c: Fix common/ includes.
4735         * amd64-fbsd-tdep.c: Fix common/ includes.
4736         * amd64-fbsd-nat.c: Fix common/ includes.
4737         * amd64-dicos-tdep.c: Fix common/ includes.
4738         * amd64-darwin-tdep.c: Fix common/ includes.
4739         * agent.c: Fix common/ includes.
4740         * ada-lang.h: Fix common/ includes.
4741         * ada-lang.c: Fix common/ includes.
4742         * aarch64-tdep.c: Fix common/ includes.
4743
4744 2019-01-25  Tom Tromey  <tom@tromey.com>
4745
4746         * common/create-version.sh: Use common/version.h.
4747
4748 2019-01-24  Pedro Alves  <palves@redhat.com>
4749
4750         * infrun.c (signal_stop, signal_print, signal_program)
4751         (signal_catch, signal_pass): Now arrays instead of pointers.
4752         (update_signals_program_target, do_target_resume)
4753         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4754         * linux-nat.c (linux_nat_target::pass_signals)
4755         (linux_nat_target::create_inferior, linux_nat_target::attach):
4756         Adjust.
4757         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4758         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4759         * procfs.c (procfs_target::pass_signals): Adjust.
4760         * record-full.c (record_full_target::resume): Adjust.
4761         * remote.c (remote_target::pass_signals)
4762         (remote_target::program_signals): Adjust.
4763         * target-debug.h (target_debug_print_signals): Now takes a
4764         gdb::array_view as parameter.  Adjust.
4765         * target.h (target_ops) <pass_signals, program_signals>: Replace
4766         pointer and length parameters with gdb::array_view.
4767         (target_pass_signals, target_program_signals): Likewise.
4768         * target-delegates.c: Regenerate.
4769
4770 2019-01-24  Pedro Alves  <palves@redhat.com>
4771
4772         * common/forward-scope-exit.h
4773         (forward_scope_exit::forward_scope_exit): Pass arguments to
4774         m_bind_function directly, instead of creating a std::bind and
4775         copying that.
4776
4777 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4778
4779         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4780         for static members.
4781         (pass_in_v_vfp_candidate): Likewise.
4782
4783 2019-01-23  Tom Tromey  <tom@tromey.com>
4784             Pedro Alves  <palves@redhat.com>
4785
4786         * regcache.c (class regcache_invalidator): Remove.
4787         (regcache::raw_write): Use make_scope_exit.
4788
4789 2019-01-23  Tom Tromey  <tom@tromey.com>
4790
4791         * ui-out.h (class ui_out_emit_type): Update comment.
4792
4793 2019-01-23  Tom Tromey  <tom@tromey.com>
4794
4795         * infrun.c (fetch_inferior_event): Update comment.
4796
4797 2019-01-23  Tom Tromey  <tom@tromey.com>
4798             Pedro Alves  <palves@redhat.com>
4799
4800         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4801         parameter.
4802         (fetch_inferior_event): Use SCOPE_EXIT.
4803
4804
4805 2019-01-23  Tom Tromey  <tom@tromey.com>
4806             Pedro Alves  <palves@redhat.com>
4807
4808         * infrun.c (disable_thread_events): Delete.
4809         (stop_all_threads): Use SCOPE_EXIT.
4810
4811 2019-01-23  Tom Tromey  <tom@tromey.com>
4812             Pedro Alves  <palves@redhat.com>
4813
4814         * symfile.c: Include forward-scope-exit.h.
4815         (clear_symtab_users_cleanup): Replace forward declaration with
4816         a FORWARD_SCOPE_EXIT.
4817         (syms_from_objfile_1): Use the forward_scope_exit and
4818         gdb::optional instead of cleanup_function.
4819         (reread_symbols): Use the forward_scope_exit instead of
4820         cleanup_function.
4821         (clear_symtab_users_cleanup): Remove function.
4822
4823 2019-01-23  Tom Tromey  <tom@tromey.com>
4824             Pedro Alves  <palves@redhat.com>
4825
4826         * linux-nat.c: Include scope-exit.h.
4827         (cleanup_target_stop): Remove.
4828         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4829         SCOPE_EXIT.
4830
4831 2019-01-23  Tom Tromey  <tom@tromey.com>
4832             Pedro Alves  <palves@redhat.com>
4833
4834         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4835         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4836
4837 2019-01-23  Tom Tromey  <tom@tromey.com>
4838             Andrew Burgess  <andrew.burgess@embecosm.com>
4839             Pedro Alves  <palves@redhat.com>
4840
4841         * infrun.c (fetch_inferior_event): Use scope_exit.
4842         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4843         * top.c (execute_command): Use scope_exit.
4844         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4845         * utils.c (do_bpstat_clear_actions_cleanup)
4846         (make_bpstat_clear_actions_cleanup): Remove.
4847
4848 2019-01-23  Tom Tromey  <tom@tromey.com>
4849             Pedro Alves  <palves@redhat.com>
4850
4851         * infrun.c: Include "common/scope-exit.h"
4852         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4853         (wait_for_inferior): Use SCOPE_EXIT.
4854         (fetch_inferior_event): Use scope_exit.
4855
4856 2019-01-23  Tom Tromey  <tom@tromey.com>
4857             Pedro Alves  <palves@redhat.com>
4858
4859         * breakpoint.c (create_breakpoint): Remove cleanup.
4860
4861 2019-01-23  Tom Tromey  <tom@tromey.com>
4862             Andrew Burgess  <andrew.burgess@embecosm.com>
4863             Pedro Alves  <palves@redhat.com>
4864
4865 2019-01-23  Pedro Alves  <palves@redhat.com>
4866
4867         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4868
4869 2019-01-23  Pedro Alves  <palves@redhat.com>
4870             Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * gdbthread.h: Include "common/forward-scope-exit.h".
4873         (scoped_finish_thread_state): Redefine custom class in terms of
4874         forward_scope_exit.
4875
4876 2019-01-23  Pedro Alves  <palves@redhat.com>
4877             Andrew Burgess  <andrew.burgess@embecosm.com>
4878
4879         * common/forward-scope-exit.h: New file.
4880
4881 2019-01-23  Pedro Alves  <palves@redhat.com>
4882             Andrew Burgess  <andrew.burgess@embecosm.com>
4883             Tom Tromey  <tom@tromey.com>
4884
4885         * common/scope-exit.h: New file.
4886
4887 2019-01-23  Pedro Alves  <palves@redhat.com>
4888
4889         * common/preprocessor.h (ESC): Rename to ...
4890         (ESC_PARENS): ... this.
4891         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4892         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4893
4894 2019-01-23  Tom Tromey  <tom@tromey.com>
4895
4896         * language.h (class scoped_switch_to_sym_language_if_auto):
4897         Initialize m_lang in both cases.
4898
4899 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4900
4901         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4902         with XCNEW.
4903
4904 2019-01-22  Tom Tromey  <tom@tromey.com>
4905
4906         * corelow.c: Do not include sys/file.h.
4907
4908 2019-01-22  Tom Tromey  <tom@tromey.com>
4909
4910         * tui/tui-wingeneral.h: Include gdb_curses.h.
4911
4912 2019-01-22  Tom Tromey  <tom@tromey.com>
4913
4914         * source-cache.h (class source_cache) <get_source_lines,
4915         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4916
4917 2019-01-22  Tom Tromey  <tom@tromey.com>
4918
4919         * remote-fileio.h (struct remote_target): Declare.
4920
4921 2019-01-22  Tom Tromey  <tom@tromey.com>
4922
4923         * python/py-arch.c: Do not include py-ref.h.
4924         * python/py-bpevent.c: Do not include py-ref.h.
4925         * python/py-cmd.c: Do not include py-ref.h.
4926         * python/py-continueevent.c: Do not include py-ref.h.
4927         * python/py-event.h: Do not include py-ref.h.
4928         * python/py-evtregistry.c: Do not include py-ref.h.
4929         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4930         * python/py-frame.c: Do not include py-ref.h.
4931         * python/py-framefilter.c: Do not include py-ref.h.
4932         * python/py-function.c: Do not include py-ref.h.
4933         * python/py-infevents.c: Do not include py-ref.h.
4934         * python/py-linetable.c: Do not include py-ref.h.
4935         * python/py-objfile.c: Do not include py-ref.h.
4936         * python/py-param.c: Do not include py-ref.h.
4937         * python/py-prettyprint.c: Do not include py-ref.h.
4938         * python/py-progspace.c: Do not include py-ref.h.
4939         * python/py-symbol.c: Do not include py-ref.h.
4940         * python/py-symtab.c: Do not include py-ref.h.
4941         * python/py-type.c: Do not include py-ref.h.
4942         * python/py-unwind.c: Do not include py-ref.h.
4943         * python/py-utils.c: Do not include py-ref.h.
4944         * python/py-value.c: Do not include py-ref.h.
4945         * python/py-varobj.c: Do not include py-ref.h.
4946         * python/py-xmethods.c: Do not include py-ref.h.
4947         * python/python.c: Do not include py-ref.h.
4948         * varobj.c: Do not include py-ref.h.
4949
4950 2019-01-22  Tom Tromey  <tom@tromey.com>
4951
4952         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4953         keyword for bcache.
4954
4955 2019-01-22  Tom Tromey  <tom@tromey.com>
4956
4957         * compile/compile-cplus-types.c: Remove a comment by #include.
4958
4959 2019-01-22  Tom Tromey  <tom@tromey.com>
4960
4961         * compile/gcc-c-plugin.h: Include compile-internal.h.
4962
4963 2019-01-22  Tom Tromey  <tom@tromey.com>
4964
4965         * stabsread.c (EXTERN): Do not define.
4966         (symnum, next_symbol_text_func, processing_gcc_compilation)
4967         (within_function, global_sym_chain, global_stabs)
4968         (previous_stab_code, this_object_header_files)
4969         (n_this_object_header_files)
4970         (n_allocated_this_object_header_files): Define.
4971         * stabsread.h (EXTERN): Never define.  Use "extern".
4972
4973 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4974
4975         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4976         history_value.
4977
4978 2019-01-21  Tom Tromey  <tom@tromey.com>
4979
4980         * ui-out.c: Fix includes.
4981         * tui/tui-source.c: Fix includes.
4982         * target.c: Fix includes.
4983         * remote.c: Fix includes.
4984         * regcache.c: Fix includes.
4985         * python/py-block.c: Fix includes.
4986         * printcmd.c: Fix includes.
4987         * or1k-tdep.c: Fix includes.
4988         * mi/mi-main.c: Fix includes.
4989         * m32r-tdep.c: Fix includes.
4990         * csky-tdep.c: Fix includes.
4991         * compile/compile-cplus-types.c: Fix includes.
4992         * cli/cli-interp.c: Fix includes.
4993
4994 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4995
4996         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4997         for padding.
4998
4999 2019-01-16  Tom Tromey  <tom@tromey.com>
5000
5001         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5002         earlier.
5003         (struct objfile) <msymbols_range>: Move from top level.
5004         <msymbols>: New method.
5005         (class objfile_msymbols): Remove.
5006         * symtab.c (default_collect_symbol_completion_matches_break_on):
5007         Update.
5008         * symmisc.c (dump_msymbols): Update.
5009         * stabsread.c (scan_file_globals): Update.
5010         * objc-lang.c (info_selectors_command, info_classes_command)
5011         (find_methods): Update.
5012         * minsyms.c (find_solib_trampoline_target): Update.
5013         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5014         * coffread.c (coff_symfile_read): Update.
5015         * ada-lang.c (ada_lookup_simple_minsym)
5016         (ada_collect_symbol_completion_matches): Update.
5017
5018 2019-01-16  Tom Tromey  <tom@tromey.com>
5019
5020         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5021         type.  Remove no-argument constructor.
5022         <iterator::operator++>: Simplify.
5023         <begin>: Update.
5024         <end>: Use minimal_symbol_count.
5025
5026 2019-01-16  Tom Tromey  <tom@tromey.com>
5027
5028         * objfiles.h (struct objfile) <psymtabs>: New method.
5029         (class objfile_psymtabs): Remove.
5030         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5031         typedef.
5032         <range>: New method.
5033         (require_partial_symbols): Change return type.
5034         * psymtab.c (require_partial_symbols)
5035         (psym_expand_symtabs_matching): Update.
5036         * mdebugread.c (parse_partial_symbols): Update.
5037         * dbxread.c (dbx_end_psymtab): Update.
5038
5039 2019-01-15  Tom Tromey  <tom@tromey.com>
5040
5041         * symtab.c (lookup_objfile_from_block)
5042         (lookup_symbol_in_objfile_symtabs)
5043         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5044         (find_line_symtab, info_sources_command)
5045         (default_collect_symbol_completion_matches_break_on)
5046         (make_source_files_completion_list): Update.
5047         * symmisc.c (print_objfile_statistics, dump_objfile)
5048         (maintenance_print_symbols, maintenance_info_symtabs)
5049         (maintenance_check_symtabs, maintenance_info_line_tables):
5050         Update.
5051         * source.c (select_source_symtab)
5052         (forget_cached_source_info_for_objfile): Update.
5053         * objfiles.h (class objfile_compunits): Remove.
5054         (struct objfile) <compunits_range>: New typedef.
5055         (compunits): New method.
5056         * objfiles.c (objfile_relocate1): Update.
5057         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5058         * maint.c (count_symtabs_and_blocks): Update.
5059         * linespec.c (iterate_over_all_matching_symtabs): Update.
5060         * cp-support.c (add_symbol_overload_list_qualified): Update.
5061         * coffread.c (coff_symtab_read): Update.
5062         * ada-lang.c (add_nonlocal_symbols)
5063         (ada_collect_symbol_completion_matches)
5064         (ada_add_global_exceptions): Update.
5065
5066 2019-01-15  Tom Tromey  <tom@tromey.com>
5067
5068         * progspace.h (program_space) <objfiles_safe_range>: New
5069         typedef.
5070         <objfiles_safe>: New method.
5071         * objfiles.h (class all_objfiles_safe): Remove.
5072         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5073         * jit.c (jit_inferior_exit_hook): Update.
5074
5075 2019-01-17  Tom Tromey  <tom@tromey.com>
5076
5077         * progspace.h (program_space) <objfiles_range>: New typedef.
5078         <objfiles>: New method.
5079         <objfiles_head>: Rename from objfiles.
5080         (object_files): Update.
5081         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5082         * guile/scm-pretty-print.c
5083         (ppscm_find_pretty_printer_from_objfiles): Update.
5084         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5085         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5086         Update.
5087         * python/py-progspace.c (pspy_get_objfiles): Update.
5088         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5089         Update.
5090         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5091         (objfpy_lookup_objfile_by_build_id): Update.
5092         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5093         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5094         Update.
5095         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5096         (expand_symtab_containing_pc, lookup_objfile_from_block)
5097         (lookup_static_symbol, basic_lookup_transparent_type)
5098         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5099         (find_line_symtab, info_sources_command)
5100         (default_collect_symbol_completion_matches_break_on)
5101         (make_source_files_completion_list, find_main_name): Update.
5102         * symmisc.c (print_symbol_bcache_statistics)
5103         (print_objfile_statistics, maintenance_print_symbols)
5104         (maintenance_print_msymbols, maintenance_print_objfiles)
5105         (maintenance_info_symtabs, maintenance_check_symtabs)
5106         (maintenance_expand_symtabs, maintenance_info_line_tables):
5107         Update.
5108         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5109         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5110         (map_overlay_command, unmap_overlay_command)
5111         (simple_overlay_update, expand_symtabs_matching)
5112         (map_symbol_filenames): Update.
5113         * symfile-debug.c (set_debug_symfile): Update.
5114         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5115         Update.
5116         * source.c (select_source_symtab, forget_cached_source_info):
5117         Update.
5118         * solib.c (solib_read_symbols): Update.
5119         * solib-spu.c (append_ocl_sos): Update.
5120         * psymtab.c (maintenance_print_psymbols)
5121         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5122         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5123         * printcmd.c (info_symbol_command): Update.
5124         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5125         Update.
5126         * objfiles.h (class all_objfiles): Remove.
5127         * objfiles.c (have_partial_symbols, have_full_symbols)
5128         (have_minimal_symbols, qsort_cmp, update_section_map)
5129         (shared_objfile_contains_address_p)
5130         (default_iterate_over_objfiles_in_search_order): Update.
5131         * objc-lang.c (info_selectors_command, info_classes_command)
5132         (find_methods): Update.
5133         * minsyms.c (find_solib_trampoline_target): Update.
5134         * maint.c (maintenance_info_sections)
5135         (maintenance_translate_address, count_symtabs_and_blocks):
5136         Update.
5137         * main.c (captured_main_1): Update.
5138         * linux-thread-db.c (try_thread_db_load_from_pdir)
5139         (has_libpthread): Update.
5140         * linespec.c (iterate_over_all_matching_symtabs)
5141         (search_minsyms_for_name): Update.
5142         * jit.c (jit_find_objf_with_entry_addr): Update.
5143         * hppa-tdep.c (find_unwind_entry)
5144         (hppa_lookup_stub_minimal_symbol): Update.
5145         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5146         Update.
5147         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5148         (elf_gnu_ifunc_resolve_by_got): Update.
5149         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5150         * dwarf-index-write.c (save_gdb_index_command): Update.
5151         * cp-support.c (add_symbol_overload_list_qualified): Update.
5152         * breakpoint.c (create_overlay_event_breakpoint)
5153         (create_longjmp_master_breakpoint)
5154         (create_std_terminate_master_breakpoint)
5155         (create_exception_master_breakpoint): Update.
5156         * blockframe.c (find_pc_partial_function): Update.
5157         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5158         (ada_collect_symbol_completion_matches)
5159         (ada_add_global_exceptions): Update.
5160
5161 2019-01-17  Tom Tromey  <tom@tromey.com>
5162
5163         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5164         declare VEC.
5165         (solib_target_parse_libraries): Change return type.
5166         (library_list_start_segment, library_list_start_section)
5167         (library_list_end_library, library_list_start_library); Update.
5168         (solib_target_free_library_list): Remove.
5169         (solib_target_parse_libraries): Remove cleanup.  Change return
5170         type.
5171         (solib_target_current_sos): Update.
5172
5173 2019-01-17  Tom Tromey  <tromey@bapiya>
5174
5175         * valprint.c: Replace "the the" with "the".
5176         * symtab.c: Replace "the the" with "the".
5177         * solib.c: Replace "the the" with "the".
5178         * solib-dsbt.c: Replace "the the" with "the".
5179         * linespec.c: Replace "the the" with "the".
5180         * dwarf2loc.h: Replace "the the" with "the".
5181         * amd64-windows-tdep.c: Replace "the the" with "the".
5182         * aarch64-tdep.c: Replace "the the" with "the".
5183
5184 2019-01-16  Keith Seitz  <keiths@redhat.com>
5185
5186         PR gdb/23773
5187         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5188         <builder>: Rename to ..
5189         <m_builder>: ... this and make private.
5190         (dwarf2_cu::get_builder): New method.  Change all users of
5191         `builder' to use this method.
5192         (dwarf2_start_symtab): Move to ...
5193         (dwarf2_cu::start_symtab): ... here.  Update all callers
5194         (setup_type_unit_groups): Move to ...
5195         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5196         callers.
5197         (dwarf2_cu::reset_builder): New method.
5198         (process_full_compunit, process_full_type_unit): Use
5199         dwarf2_cu::reset_builder.
5200         (follow_die_offset): Record the ancestor CU if it is different
5201         from the followed DIE's CU.
5202         (follow_die_sig_1): Likewise.
5203
5204 2019-01-15  Tom Tromey  <tom@tromey.com>
5205
5206         * remote.c (class remote_state) <buf>: Now a char_vector.
5207         <buf_size>: Remove.
5208         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5209         parameter.
5210         (remote_target::getpkt_or_notif_sane_1)
5211         (remote_target::getpkt_sane)
5212         (remote_target::getpkt_or_notif_sane): Likewise.
5213         (class remote_target) <putpkt>: New overload.
5214         (remote_target::read_frame): Change type of "buf_p".  Remove
5215         sizeof_p parameter.
5216         (packet_ok): New overload.
5217         (packet_check_result): New overload.
5218         Update all uses.
5219
5220 2019-01-14  Tom Tromey  <tom@tromey.com>
5221
5222         * remote-notif.c (handle_notification, remote_notif_ack)
5223         (remote_notif_parse): Make "buf" const.
5224         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5225         const.
5226         (remote_notif_parse, remote_notif_ack, handle_notification):
5227         Likewise.
5228         * remote.c (remote_notif_stop_parse): Make "buf" const.
5229         (remote_target::remote_parse_stop_reply): Make "buf" const.
5230         (remote_notif_stop_ack): Make "buf" const.
5231
5232 2019-01-14  Tom Tromey  <tom@tromey.com>
5233
5234         * remote.c (remote_console_output): Make parameter const.
5235
5236 2019-01-14  Tom Tromey  <tom@tromey.com>
5237
5238         * target-debug.h (target_debug_print_signals): Constify.
5239         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5240         * procfs.c (procfs_target::pass_signals): Update.
5241         * linux-nat.c (linux_nat_target::pass_signals): Update.
5242         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5243         * target-delegates.c: Rebuild.
5244         * remote.c (remote_target::program_signals): Update.
5245         (remote_target::pass_signals): Update.
5246         * target.c (target_pass_signals): Constify argument.
5247         (target_program_signals): Likewise.
5248         * target.h (struct target_ops) <pass_signals, program_signals>:
5249         Constify argument.
5250         (target_pass_signals, target_program_signals): Constify argument.
5251
5252 2019-01-14  Tom Tromey  <tom@tromey.com>
5253
5254         PR tui/28819:
5255         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5256
5257 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5258
5259         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5260         field.
5261         * rs6000-tdep.c: Include reggroups.h.
5262         (IS_V_ALIAS_PSEUDOREG): Define.
5263         (rs6000_register_name): Return names for the "vX" aliases.
5264         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5265         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5266         aliases.  Call default_register_reggroup_p for all other
5267         pseudo-registers.
5268         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5269         New functions.
5270         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5271         Handle "vX" aliases.
5272         (v_alias_pseudo_register_collect): New function.
5273         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5274         (rs6000_gdbarch_init): Initialize "vX" aliases as
5275         pseudo-registers.  Restore registration of
5276         rs6000_pseudo_register_reggroup_p with
5277         set_tdesc_pseudo_register_reggroup_p.
5278
5279 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5280
5281         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5282         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5283         set_gdbarch_num_pseudo_regs.
5284
5285 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5286
5287         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5288         Remove arg prefixname, add do_set and do_show.
5289         Add member functions set_list and show_list.
5290         * cli/cli-style.c (class cli_style_option): Update accordingly.
5291         (style_set_list): Move to file scope.
5292         (style_show_list): Likewise.
5293         (set_style): Call help_list.
5294         (show_style): Call cmd_show_list.
5295         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5296         Update to use the new macro.
5297
5298 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5299
5300         * ada-lang.c (_initialize_ada_language): Expand the help text
5301         for the "catch exception" command.
5302
5303 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5304
5305         * symtab.c (matching_obj_sections): Initialize obj,
5306         declare it closer to its usage.
5307
5308 2019-01-10  Tom Tromey  <tom@tromey.com>
5309
5310         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5311         (basic_inf_threads_range): Remove.
5312         (inf_threads_range, inf_non_exited_threads_range)
5313         (safe_inf_threads_range): Use next_adapter.
5314
5315 2019-01-10  Keith Seitz  <keiths@redhat.com>
5316
5317         PR gdb/23712
5318         PR symtab/23010
5319         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5320         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5321
5322 2019-01-10  Keith Seitz  <keiths@redhat.com>
5323
5324         PR gdb/23712
5325         PR symtab/23010
5326         * dictionary.c (pending_to_vector): Remove.
5327         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5328         Remove _1 suffix, replacing functions of the same name.  Update
5329         all callers.
5330         (dict_create_hashed, dict_create_hashed_expandable)
5331         (dict_create_linear, dict_create_linear_expandable, dict_free)
5332         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5333         Make functions static.
5334
5335 2019-01-10  Keith Seitz  <keiths@redhat.com>
5336
5337         PR gdb/23712
5338         PR symtab/23010
5339         * dictionary.h (struct dictionary): Replace declaration with
5340         multidictionary.
5341         (dict_create_hashed, dict_create_hashed_expandable)
5342         (dict_create_linear, dict_create_linear_expandable)
5343         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5344         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5345         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5346         taking multidictionary argument.
5347         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5348         * block.h (struct block) <dict>: Change to multidictionary
5349         and rename `multidict'.
5350         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5351         symmisc.c: Update all dictionary references to multidictionary.
5352
5353 2019-01-10  Keith Seitz  <keiths@redhat.com>
5354
5355         PR gdb/23712
5356         PR symtab/23010
5357         * dictionary.c: Include unordered_map.
5358         (pending_to_vector): New function.
5359         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5360         Rewrite the non-"_1" functions to take vector instead
5361         of linked list.
5362         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5363         "new" _1 versions of the same name.
5364         (multidictionary): Define.
5365         (std::hash<enum language): New definition.
5366         (collate_pending_symbols_by_language, mdict_create_hashed)
5367         (mdict_create_hashed_expandable, mdict_create_linear)
5368         (mdict_create_linear_expandable, mdict_free)
5369         (find_language_dictionary, create_new_language_dictionary)
5370         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5371         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5372         (mdict_size, mdict_empty): New functions.
5373         * dictionary.h (mdict_iterator): Define.
5374
5375 2019-01-10  Pedro Alves  <palves@redhat.com>
5376
5377         * breakpoint.c (read_uploaded_action)
5378         (create_tracepoint_from_upload): Adjust to use
5379         gdb::unique_xmalloc_ptr.
5380         * ctf.c (ctf_write_uploaded_tp):
5381         (SET_ARRAY_FIELD): Use emplace_back.
5382         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5383         * tracefile-tfile.c (tfile_write_uploaded_tp):
5384         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5385         gdb::unique_xmalloc_ptr.
5386         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5387         at_string, cond_string, cmd_strings>: Replace char pointers
5388         with gdb::unique_xmalloc_ptr.
5389
5390 2019-01-10  Pedro Alves  <palves@redhat.com>
5391
5392         * solib-target.c (library_list_start_library): Don't xstrdup name.
5393
5394 2019-01-10  Pedro Alves  <palves@redhat.com>
5395
5396         * mdebugread.c (parse_partial_symbols): Use
5397         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5398
5399 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * linux-fork.c (scoped_switch_fork_info)
5402         <~scoped_switch_fork_info>: Fix incorrect variable name.
5403
5404 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5405
5406         * linux-fork.c (scoped_switch_fork_info)
5407         <scoped_switch_fork_info>: Make explicit.
5408         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5409
5410 2019-01-10  Tom Tromey  <tom@tromey.com>
5411
5412         * objfiles.h (objfile::reset_psymtabs): Update.
5413         * objfiles.c (objfile::objfile): Update.
5414         * psymtab.h (psymtab_storage::obstack): Update.
5415         (psymtab_storage::m_obstack): Use gdb::optional.
5416         (class psymtab_storage): Update comment.  Remove objfile
5417         parameter.
5418         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5419
5420 2019-01-10  Tom Tromey  <tom@tromey.com>
5421
5422         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5423         <free_psymtabs>: Now private.
5424         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5425         (allocate_psymtab): Use new method.
5426
5427 2019-01-10  Tom Tromey  <tom@tromey.com>
5428
5429         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5430         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5431         * mdebugread.c (parse_partial_symbols): Use
5432         allocate_dependencies.
5433         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5434         allocate_dependencies.
5435         (process_psymtab_comp_unit_reader)
5436         (build_type_psymtab_dependencies): Likewise.
5437         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5438
5439 2019-01-10  Tom Tromey  <tom@tromey.com>
5440
5441         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5442         PSYMBOL_SET_LANGUAGE.
5443         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5444
5445 2019-01-10  Tom Tromey  <tom@tromey.com>
5446
5447         * psymtab.h (psymtab_storage::obstack): New method.
5448         <m_obstack>: Rename from obstack; now private.
5449         * psymtab.c (psymtab_storage): Update.
5450         * dwarf2read.c (create_addrmap_from_index)
5451         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5452         Update.
5453
5454 2019-01-10  Tom Tromey  <tom@tromey.com>
5455
5456         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5457         * objfiles.h (objfile::reset_psymtabs): New method.
5458
5459 2019-01-10  Tom Tromey  <tom@tromey.com>
5460
5461         * symmisc.c (print_symbol_bcache_statistics): Update.
5462         (print_objfile_statistics): Update.
5463         * symfile.c (reread_symbols): Update.
5464         * psymtab.h (class psymtab_storage): New.
5465         * psymtab.c (psymtab_storage): New constructor.
5466         (~psymtab_storage): New destructor.
5467         (require_partial_symbols): Update.
5468         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5469         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5470         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5471         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5472         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5473         (start_psymtab_common, end_psymtab_common)
5474         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5475         (allocate_psymtab): Update.
5476         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5477         Update.
5478         (dump_psymtab_addrmap, maintenance_print_psymbols)
5479         (maintenance_check_psymtabs): Update.
5480         (class objfile_psymtabs): Move to objfiles.h.
5481         * psympriv.h (discard_psymtab): Now inline.
5482         (psymtab_discarder::psymtab_discarder): Update.
5483         (psymtab_discarder::~psymtab_discarder): Update.
5484         (ALL_OBJFILE_PSYMTABS): Rewrite.
5485         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5486         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5487         Remove fields.
5488         <partial_symtabs>: New field.
5489         (class objfile_psymtabs): Move from psymtab.h.  Update.
5490         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5491         psymbol_cache.
5492         (objfile::~objfile): Don't destroy psymbol_cache.
5493         * mdebugread.c (parse_partial_symbols): Update.
5494         * dwarf2read.c (create_addrmap_from_index)
5495         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5496         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5497         (add_partial_subprogram, dwarf2_ranges_read): Update.
5498         * dwarf-index-write.c (write_address_map)
5499         (write_one_signatured_type, recursively_write_psymbols)
5500         (class debug_names, class debug_names, write_psymtabs_to_index):
5501         Update.
5502
5503 2019-01-10  Tom Tromey  <tom@tromey.com>
5504
5505         * symtab.h (SYMBOL_SET_NAMES): Update.
5506         (symbol_set_names): Update.
5507         (MSYMBOL_SET_NAMES): Update.
5508         * symtab.c (symbol_set_names): Change argument to be an
5509         objfile_per_bfd_storage.
5510         * psymtab.c (add_psymbol_to_bcache): Update.
5511         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5512
5513 2019-01-10  Tom Tromey  <tom@tromey.com>
5514
5515         * symtab.c (create_demangled_names_hash): Change argument to be an
5516         objfile_per_bfd_storage.
5517         (symbol_set_names): Update.
5518
5519 2019-01-10  Tom Tromey  <tom@tromey.com>
5520
5521         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5522         init_psymbol_list.
5523         * psymtab.c (init_psymbol_list): Do nothing if already called.
5524         * psympriv.h (init_psymbol_list): Add comment.
5525         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5526         init_psymbol_list.
5527         * dbxread.c (dbx_symfile_read): Unconditionally call
5528         init_psymbol_list.
5529
5530 2019-01-10  Tom Tromey  <tom@tromey.com>
5531
5532         * xcoffread.c (scan_xcoff_symtab): Update.
5533         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5534         "where".
5535         * mdebugread.c (parse_partial_symbols)
5536         (handle_psymbol_enumerators): Update.
5537         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5538         * dbxread.c (read_dbx_symtab): Update.
5539         * psympriv.h (psymbol_placement): New enum.
5540         (add_psymbol_to_list): Update.
5541
5542 2019-01-10  Tom Tromey  <tom@tromey.com>
5543
5544         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5545         static_psymbols parameters.
5546         (scan_xcoff_symtab): Update.
5547         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5548         static_psymbols parameters.
5549         * psympriv.h (start_psymtab_common): Update.
5550         * mdebugread.c (parse_partial_symbols): Update.
5551         * dwarf2read.c (create_partial_symtab): Update.
5552         * dbxread.c (read_dbx_symtab): Update.
5553         (start_psymtab): Remove global_psymbols and static_psymbols
5554         parameters.
5555
5556 2019-01-10  Tom Tromey  <tom@tromey.com>
5557
5558         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5559         * psymtab.c (allocate_psymtab): Add comment.
5560         * psympriv.h (allocate_psymtab): Add comment.
5561         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5562         initializations.
5563         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5564
5565 2019-01-10  Tom Tromey  <tom@tromey.com>
5566
5567         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5568         Don't declare.
5569         * mipsread.c: Include mdebugread.h.
5570         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5571         Declare.
5572         * elfread.c: Include mdebugread.h.
5573
5574 2019-01-09  Tom Tromey  <tom@tromey.com>
5575
5576         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5577         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5578         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5579         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5580         (psym_lookup_symbol, psym_find_last_source_symtab)
5581         (psym_forget_cached_source_info, psym_print_stats)
5582         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5583         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5584         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5585         (psym_find_compunit_symtab_by_address)
5586         (maintenance_print_psymbols, maintenance_info_psymtabs)
5587         (maintenance_check_psymtabs): Use ranged for.
5588         * psymtab.h (class objfile_psymtabs): New.
5589         (require_partial_symbols): Return objfile_psymtabs.
5590         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5591
5592 2019-01-09  Tom Tromey  <tom@tromey.com>
5593
5594         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5595         (find_pc_mapped_section, list_overlays_command)
5596         (map_overlay_command, unmap_overlay_command)
5597         (simple_overlay_update): Use all_objfiles.
5598         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5599         * printcmd.c (info_symbol_command): Use all_objfiles.
5600         * objfiles.h (ALL_OBJSECTIONS): Remove.
5601         * maint.c (maintenance_translate_address): Use all_objfiles.
5602         * gcore.c (gcore_create_callback): Use all_objfiles.
5603         (objfile_find_memory_regions): Likewise.
5604
5605 2019-01-09  Tom Tromey  <tom@tromey.com>
5606
5607         * symtab.c (find_line_symtab, info_sources_command)
5608         (make_source_files_completion_list): Use objfile_compunits.
5609         * source.c (select_source_symtab): Use objfile_compunits.
5610         * objfiles.h (struct objfile): Update comment.
5611         (ALL_OBJFILES): Remove.
5612         (ALL_FILETABS): Remove.
5613         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5614         objfile_compunits.
5615
5616 2019-01-09  Tom Tromey  <tom@tromey.com>
5617
5618         * symmisc.c (print_objfile_statistics, dump_objfile)
5619         (maintenance_print_symbols): Use compunit_filetabs.
5620         * source.c (forget_cached_source_info_for_objfile): Use
5621         compunit_filetabs.
5622         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5623         (ALL_FILETABS): Use compunit_filetabs.
5624         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5625         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5626
5627 2019-01-09  Tom Tromey  <tom@tromey.com>
5628
5629         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5630         (compunit_filetabs): New.
5631         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5632         compunit_filetabs.
5633         (info_sources_command, make_source_files_completion_list): Remove
5634         declaration.
5635         * symmisc.c (print_objfile_statistics, dump_objfile)
5636         (maintenance_print_symbols): Remove declaration.
5637         (maintenance_info_symtabs): Use compunit_filetabs.
5638         (maintenance_info_line_tables): Likewise.
5639         * source.c (select_source_symtab): Change local variable name.
5640         (forget_cached_source_info_for_objfile): Remove declaration.
5641         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5642         * objfiles.c (objfile_relocate1): Remove declaration.
5643         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5644         declaration.
5645         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5646         * coffread.c (coff_symtab_read): Remove declaration.
5647         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5648         compunit_filetabs.
5649
5650 2019-01-09  Tom Tromey  <tom@tromey.com>
5651
5652         * symtab.c (lookup_objfile_from_block)
5653         (find_pc_sect_compunit_symtab, search_symbols)
5654         (default_collect_symbol_completion_matches_break_on): Use
5655         objfile_compunits.
5656         * objfiles.h (ALL_COMPUNITS): Remove.
5657         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5658         * cp-support.c (add_symbol_overload_list_qualified): Use
5659         objfile_compunits.
5660         * ada-lang.c (ada_collect_symbol_completion_matches)
5661         (ada_add_global_exceptions): Use objfile_compunits.
5662
5663 2019-01-09  Tom Tromey  <tom@tromey.com>
5664
5665         * source.c (select_source_symtab)
5666         (forget_cached_source_info_for_objfile): Remove declaration.
5667         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5668         declaration.
5669         * maint.c (count_symtabs_and_blocks): Remove declaration.
5670         * cp-support.c (add_symbol_overload_list_qualified): Remove
5671         declaration.
5672         * coffread.c (coff_symtab_read): Remove declaration.
5673         * symtab.c (lookup_symbol_in_objfile_symtabs)
5674         (basic_lookup_transparent_type_1): Use objfile_compunits.
5675         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5676         (info_sources_command, search_symbols)
5677         (default_collect_symbol_completion_matches_break_on)
5678         (make_source_files_completion_list): Remove declaration.
5679         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5680         (ada_collect_symbol_completion_matches)
5681         (ada_add_global_exceptions): Remove declaration.
5682         * linespec.c (iterate_over_all_matching_symtabs): Use
5683         objfile_compunits.
5684         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5685         (class objfile_compunits): New.
5686         (ALL_COMPUNITS): Use objfile_compunits.
5687         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5688         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5689         objfile_compunits.
5690         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5691
5692 2019-01-09  Tom Tromey  <tom@tromey.com>
5693
5694         * symtab.c (search_symbols)
5695         (default_collect_symbol_completion_matches_break_on): Use
5696         objfile_msymbols.
5697         * ada-lang.c (ada_lookup_simple_minsym)
5698         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5699         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5700         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5701         objfile_msymbols.
5702         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5703         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5704         * objc-lang.c (find_methods): Use objfile_msymbols.
5705         (info_selectors_command, info_classes_command): Likewise.
5706         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5707         * objfiles.h (class objfile_msymbols): New.
5708         (ALL_OBJFILE_MSYMBOLS): Remove.
5709         (ALL_MSYMBOLS): Remove.
5710
5711 2019-01-09  Tom Tromey  <tom@tromey.com>
5712
5713         * common/next-iterator.h (next_adapter): Add Iterator template
5714         parameter.
5715         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5716         (class all_objfiles_safe): New.
5717         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5718         * objfiles.c (put_objfile_before): Update comment.
5719         (add_separate_debug_objfile): Likewise.
5720         (free_all_objfiles): Use all_objfiles_safe.
5721         (objfile_purge_solibs): Likewise.
5722
5723 2019-01-09  Tom Tromey  <tom@tromey.com>
5724
5725         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5726         (expand_symtab_containing_pc, lookup_static_symbol)
5727         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5728         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5729         all_objfiles.
5730         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5731         * breakpoint.c (create_overlay_event_breakpoint)
5732         (create_longjmp_master_breakpoint)
5733         (create_std_terminate_master_breakpoint)
5734         (create_exception_master_breakpoint): Use all_objfiles.
5735         * linux-thread-db.c (try_thread_db_load_from_pdir)
5736         (has_libpthread): Use all_objfiles.
5737         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5738         * linespec.c (iterate_over_all_matching_symtabs)
5739         (search_minsyms_for_name): Use all_objfiles.
5740         * maint.c (maintenance_info_sections): Use all_objfiles.
5741         * main.c (captured_main_1): Use all_objfiles.
5742         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5743         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5744         * guile/scm-pretty-print.c
5745         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5746         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5747         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5748         (maintenance_print_msymbols): Use all_objfiles.
5749         * source.c (select_source_symtab): Use all_objfiles.
5750         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5751         * symfile.c (remove_symbol_file_command)
5752         (expand_symtabs_matching, map_symbol_filenames): Use
5753         all_objfiles.
5754         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5755         all_objfiles.
5756         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5757         * objc-lang.c (find_methods): Use all_objfiles.
5758         * objfiles.c (have_partial_symbols, have_full_symbols)
5759         (have_minimal_symbols, qsort_cmp)
5760         (default_iterate_over_objfiles_in_search_order): Use
5761         all_objfiles.
5762         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5763         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5764         (maintenance_check_psymtabs): Use all_objfiles.
5765         (ALL_PSYMTABS): Remove.
5766         * compile/compile-object-run.c (do_module_cleanup): Use
5767         all_objfiles.
5768         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5769         * cp-support.c (add_symbol_overload_list_qualified): Use
5770         all_objfiles.
5771         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5772         Use all_objfiles.
5773         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5774         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5775         all_objfiles.
5776         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5777         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5778         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5779         Uses all_objfiles.
5780         * solib.c (solib_read_symbols): Use all_objfiles
5781
5782 2019-01-09  Tom Tromey  <tom@tromey.com>
5783
5784         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5785         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5786         all_objfiles.
5787         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5788         * symmisc.c (print_symbol_bcache_statistics)
5789         (print_objfile_statistics, maintenance_print_objfiles)
5790         (maintenance_info_symtabs, maintenance_check_symtabs)
5791         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5792         all_objfiles.
5793         * source.c (forget_cached_source_info): Use all_objfiles.
5794         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5795         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5796         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5797         * objfiles.c (update_section_map): Use all_objfiles.
5798         (shared_objfile_contains_address_p): Likewise.
5799         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5800         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5801
5802 2019-01-09  Tom Tromey  <tom@tromey.com>
5803
5804         * common/next-iterator.h: New file.
5805         * objfiles.h (class all_objfiles): New.
5806         (struct objfile_iterator): New.
5807
5808 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5809
5810         * NEWS: Move the description of the changed "frame", "select-frame",
5811          and "info frame" commands to the Changed commands section.
5812
5813 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5814
5815         * gdbtypes.c (check_stub_method_group): Remove handling of old
5816         mangling schemes.
5817         * linespec.c (find_methods): Likewise.
5818         * stabsread.c (read_member_functions): Likewise.
5819         * valops.c (search_struct_method): Likewise.
5820         (value_struct_elt_for_reference): Likewise.
5821         * NEWS: Mention this change.
5822
5823 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5826         print_source_lines.
5827         * source.c (print_source_lines_base): Update line number check.
5828         (print_source_lines): New function.
5829         (source_lines_range::source_lines_range): New function.
5830         * source.h (class source_lines_range): New class.
5831         (print_source_lines): New declaration.
5832
5833 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5834
5835         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5836
5837 2019-01-08  Tom Tromey  <tom@tromey.com>
5838             Simon Marchi  <simon.marchi@ericsson.com>
5839
5840         PR gdb/24060
5841         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5842         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5843         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5844         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5845         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5846         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5847
5848 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5849
5850         * source.c (select_source_symtab): Move header comment to
5851         declaration in source.h.
5852         (forget_cached_source_info_for_objfile): Likewise.
5853         (forget_cached_source_info): Likewise.
5854         (identify_source_line): Likewise.
5855         * source.h (identify_source_line): Move declaration from symtab.h
5856         and add comment from source.c
5857         (print_source_lines): Likewise.
5858         (forget_cached_source_info_for_objfile): Likewise.
5859         (forget_cached_source_info): Likewise.
5860         (select_source_symtab): Likewise.
5861         (enum print_source_lines_flag): Move definition from symtab.h.
5862         * symtab.h (identify_source_line): Move declaration to source.h.
5863         (print_source_lines): Likewise.
5864         (forget_cached_source_info_for_objfile): Likewise.
5865         (forget_cached_source_info): Likewise.
5866         (select_source_symtab): Likewise.
5867         (enum print_source_lines_flag): Move definition to source.h.
5868         * tui/tui-hooks.c: Add 'source.h' include.
5869
5870 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * source.c (print_source_lines_base): Handle requests to print
5873         reverse line number sequences, and guard against empty lines
5874         string.
5875
5876 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5877
5878         * source.c (print_source_lines_base): Fix skip of '\r' if next
5879         character is '\n'.
5880
5881 2019-01-06  Tom Tromey  <tom@tromey.com>
5882
5883         * c-exp.y (struct c_parse_state) <macro_original_text,
5884         expansion_obstack>: New member.
5885         (macro_original_text, expansion_obstack): Remove globals.
5886         (scan_macro_expansion, scanning_macro_expansion)
5887         (finished_macro_expansion): Update.
5888         (scan_macro_cleanup): Remove.
5889         (yylex, c_parse): Update.
5890
5891 2019-01-06  Tom Tromey  <tom@tromey.com>
5892
5893         * c-exp.y (struct c_parse_state) <strings>: New member.
5894         (operator_stoken): Update.
5895
5896 2019-01-06  Tom Tromey  <tom@tromey.com>
5897
5898         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5899         (union type_stack_elt) <typelist_val>: Now a pointer to
5900         std::vector.
5901         (type_stack_cleanup): Don't declare.
5902         (push_typelist): Update.
5903         * parse.c (pop_typelist): Return a std::vector.
5904         (push_typelist): Take a std::vector.
5905         (follow_types): Update.  Do not free args.
5906         (type_stack_cleanup): Remove.
5907         * c-exp.y (struct c_parse_state): New.
5908         (cpstate): New global.
5909         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5910         (nonempty_typelist): Update.
5911         (func_mod): Create a new vector.
5912         (c_parse): Create a c_parse_state.
5913         (check_parameter_typelist): Do not delete params.
5914         (function_method): Update.  Do not delete type_list.
5915
5916 2019-01-06  Tom Tromey  <tom@tromey.com>
5917
5918         PR gdb/28155:
5919         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5920         check_typedef.
5921         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5922         (print_return_value): Likewise.
5923
5924 2019-01-05  Tom Tromey  <tom@tromey.com>
5925
5926         * contrib/cleanup_check.py: Remove.
5927         * contrib/gcc-with-excheck: Remove.
5928         * contrib/exsummary.py: Remove.
5929         * contrib/excheck.py: Remove.
5930
5931 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5932
5933         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5934         NULL. Initialize tpprev to NULL instead of assigning it
5935         to NULL on the next statement.
5936         * windows-nat.c (windows_delete_thread): Remove check for
5937         main_thread_id before printing thread exit notifications.
5938         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5939         Remove thread ID check against main_thread_id.
5940         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5941         windows_delete_thread.
5942         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5943
5944 2019-01-04  Tom Tromey  <tom@tromey.com>
5945
5946         * compile/compile.c (_initialize_compile): Use upper case for
5947         metasyntactic variables.
5948         * symmisc.c (_initialize_symmisc): Use upper case for
5949         metasyntactic variables.
5950         * psymtab.c (_initialize_psymtab): Use upper case for
5951         metasyntactic variables.
5952         * demangle.c (demangle_command): Use upper case for metasyntactic
5953         variables.
5954         (_initialize_demangler): Likewise.
5955         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5956         variables.
5957
5958 2019-01-03  Tom Tromey  <tom@tromey.com>
5959
5960         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5961
5962 2019-01-03  Tom Tromey  <tom@tromey.com>
5963
5964         * python/py-symtab.c (salpy_str): Update.
5965         (struct salpy_sal_object) <symtab>: Now a PyObject.
5966         (salpy_dealloc): Update.
5967         (del_objfile_sal): Use gdbpy_ref.
5968
5969 2019-01-03  Tom Tromey  <tom@tromey.com>
5970
5971         * python/py-type.c (convert_field): Use new_reference.  Return
5972         gdbpy_ref.
5973         (make_fielditem): Return gdbpy_ref.
5974         (typy_fields): Update.
5975         (typy_getitem): Update.
5976         (field_name): Return gdbpy_ref.  Use new_reference.
5977         (typy_iterator_iternext): Update.
5978
5979 2019-01-03  Tom Tromey  <tom@tromey.com>
5980
5981         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5982
5983 2019-01-03  Tom Tromey  <tom@tromey.com>
5984
5985         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5986         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5987         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5988         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5989         (pspy_set_type_printers): Likewise.
5990         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5991         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5992         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5993         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5994         (objfpy_set_type_printers): Likewise.
5995
5996 2019-01-03  Tom Tromey  <tom@tromey.com>
5997
5998         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5999         (gdbpy_print_stack): Use gdbpy_err_fetch.
6000         * python/python-internal.h (class gdbpy_err_fetch): New class.
6001         (class gdbpy_enter) <m_error_type, m_error_value,
6002         m_error_traceback>: Remove.
6003         <m_error>: New member.
6004         (gdbpy_exception_to_string): Don't declare.
6005         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6006         * python/py-value.c (convert_value_from_python): Use
6007         gdbpy_err_fetch.
6008         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6009         gdbpy_exception_to_string.
6010         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6011         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6012         gdbpy_err_fetch.
6013
6014 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6015
6016         * linux-nat.c (delete_lwp_cleanup): Delete.
6017         (struct lwp_deleter): New struct.
6018         (lwp_info_up): New typedef.
6019         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6020         lwp_info_up.
6021
6022 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * linux-fork.c (class scoped_switch_fork_info): New class.
6025         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6026
6027 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * valops.c (find_overload_match): Remove use of null_cleanup, and
6030         calls to do_cleanups.
6031
6032 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6033
6034         * compile/compile-cplus-types.c
6035         (compile_cplus_instance::decl_name): Handle changes to
6036         cp_func_name.
6037         * cp-support.c (cp_func_name): Update header comment, update
6038         return type.
6039         * cp-support.h (cp_func_name): Update return type in declaration.
6040         * valops.c (find_overload_match): Move temp_func local to top
6041         level of function and change its type.  Use temp_func to hold and
6042         delete temporary string obtained from cp_func_name.
6043
6044 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6047         gdb::char_vector, remove cleanup, and update uses of `msg`.
6048
6049 2019-01-03  Jim Wilson  <jimw@sifive.com>
6050
6051         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6052
6053 2019-01-02  Tom Tromey  <tom@tromey.com>
6054
6055         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6056         (tdesc_parse_xml): Remove cleanups.
6057         * target-descriptions.h (make_cleanup_free_target_description):
6058         Don't declare.
6059         (target_desc_deleter): New struct.
6060         (target_desc_up): New typedef.
6061         * target-descriptions.c (target_desc_deleter::operator()): Rename
6062         from free_target_description.
6063         (make_cleanup_free_target_description): Remove.
6064
6065 2019-01-02  Tom Tromey  <tom@tromey.com>
6066
6067         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6068         constructor, destructor.
6069         (linespec_parser): Remove typedef.
6070         (~linespec_parser): Rename from linespec_parser_delete.
6071         (linespec_lex_to_end, linespec_complete_label)
6072         (linespec_complete): Update.
6073         (decode_line_full): Remove cleanups.
6074         (decode_line_1): Update.
6075
6076 2019-01-02  Tom Tromey  <tom@tromey.com>
6077
6078         * python/python-internal.h (inferior_to_inferior_object): Change
6079         return type.
6080         * python/py-exitedevent.c (create_exited_event_object): Update.
6081         * python/py-inferior.c (inferior_to_inferior_object): Return
6082         gdbpy_ref.
6083         (python_new_inferior, python_inferior_deleted)
6084         (thread_to_thread_object, delete_thread_object)
6085         (build_inferior_list, gdbpy_selected_inferior): Update.
6086         * python/py-infthread.c (create_thread_object): Update.  Also fail
6087         if inferior_to_inferior_object fails.
6088
6089 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6090
6091         * inferior.h (class inferior) <displaced_step_state>: New field.
6092         * infrun.h (struct displaced_step_state): Move here from
6093         infrun.c.  Initialize fields, add constructor.
6094         <inf>: Remove field.
6095         <reset>: New method.
6096         * infrun.c (struct displaced_step_inferior_state): Move to
6097         infrun.h.
6098         (displaced_step_inferior_states): Remove.
6099         (get_displaced_stepping_state): Adust.
6100         (displaced_step_in_progress_any_inferior): Adjust.
6101         (displaced_step_in_progress_thread): Adjust.
6102         (displaced_step_in_progress): Adjust.
6103         (add_displaced_stepping_state): Remove.
6104         (get_displaced_step_closure_by_addr): Adjust.
6105         (remove_displaced_stepping_state): Remove.
6106         (infrun_inferior_exit): Call displaced_step_state.reset.
6107         (use_displaced_stepping): Don't check for NULL.
6108         (displaced_step_prepare_throw): Call
6109         get_displaced_stepping_state.
6110         (displaced_step_fixup): Don't check for NULL.
6111         (prepare_for_detach): Don't check for NULL.
6112
6113 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6114
6115         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6116          in case of call that did not complete.
6117
6118 2019-01-02  Andrey Utkin  <autkin@undo.io>
6119
6120         * symfile.c (find_separate_debug_file): Fix search of debug files for
6121         remote debuggee.
6122
6123 2019-01-02  Tom Tromey  <tom@tromey.com>
6124
6125         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6126         indentation.
6127         * python/py-frame.c (frapy_older): Remove cast.
6128         (frapy_newer): Likewise.
6129         * python/py-breakpoint.c (local_setattro): Remove cast.
6130         * python/py-arch.c (archpy_name): Remove local variable.
6131         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6132
6133 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6134
6135         * unittests/basic_string_view/element_access/char/empty.cc:
6136         Fix year range in copyright header.
6137
6138 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6141         Delete.
6142         <operator==>: Update with for removed field.
6143         <hash>: Likewise.
6144         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6145         <isa_features>: ...this.
6146         <abi_features>: New field.
6147         (riscv_isa_flen): Update comment.
6148         (riscv_abi_xlen): New declaration.
6149         (riscv_abi_flen): New declaration.
6150         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6151         isa_features.
6152         (riscv_abi_xlen): New function.
6153         (riscv_isa_flen): Update to get answer from isa_features.
6154         (riscv_abi_flen): New function.
6155         (riscv_has_fp_abi): Update to get answer from abi_features.
6156         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6157         xlen and flen.
6158         (riscv_call_info) <xlen, flen>: Update comment.
6159         (riscv_call_arg_struct): Remove invalid assertions
6160         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6161         is removed.
6162         (riscv_gdbarch_init): Gather isa features and abi features
6163         separately, ensure both match on the gdbarch when reusing an old
6164         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6165         a target with 64-bit float hardware.
6166
6167 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6168
6169         * source.c (search_command_helper): Stop reverse search
6170         when line 1 has been searched.
6171
6172 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6173
6174         * record-full.c (record_full_base_target::close): Rewrite
6175         record_full_core_buf_list free logic.
6176
6177 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6178
6179         * break-catch-syscall.c (print_one_catch_syscall): xfree
6180         the last text.
6181
6182 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6183
6184         * top.c (print_gdb_version): Update Copyright year in version
6185         message.
6186
6187 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6188
6189         Update copyright year range in all GDB files.
6190
6191 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6192
6193         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6194
6195 For older changes see ChangeLog-2018.
6196 \f
6197 Local Variables:
6198 mode: change-log
6199 left-margin: 8
6200 fill-column: 74
6201 version-control: never
6202 coding: utf-8
6203 End:
6204