gdb/ChangeLog

   1 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * cli/cli-style.h (cli_style_option): Add name in constructor,
   4         add m_name class member, add constructor with intensity,
   5         add name class function.
   6         (cli_style_option::add_setshow_commands): Remove name argument.
   7         (highlight_style, title_style): New styles.
   8         * cli/cli-style.c (do_show): New function that shows a style
   9         characteristic styling the style name with itself.
  10         (set_style_name): New function.
  11         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
  12         Update all callers according to the changes in cli/cli-style.h.
  13         * utils.h (fputs_highlighted): New function.
  14         * utils.c (fputs_highlighted): Likewise.
  15
  16 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  17
  18         * NEWS: Mention new pipe command and new convenience variables.
  19
  20 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  21
  22         * cli/cli-cmds.c (pipe_command): New function.
  23         (_initialize_cli_cmds): Call add_com for pipe_command.
  24         Define | as an alias for pipe.
  25         (exit_status_set_internal_vars): New function.
  26         (shell_escape): Call exit_status_set_internal_vars.
  27         cli/cli-decode.c (find_command_name_length): Recognize | as
  28         a single character command.
  29
  30 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  31
  32         * gdbcmd.h (execute_command_to_ui_file): New declaration.
  33         top.c (execute_command_to_ui_file): New function, mostly a copy
  34         of execute_command_to_string.
  35         (execute_command_to_string): Implement by calling
  36         execute_command_to_ui_file.
  37
  38 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  39
  40         * top.h (saved_command_line): Remove declaration.
  41         * top.c (previous_saved_command_line, previous_repeat_arguments):
  42         New variables.
  43         (saved_command_line): Make static, define together with other
  44         'repeat variables'.
  45         (dont_repeat): Clear repeat_arguments.
  46         (repeat_previous, get_saved_command_line, save_command_line):
  47         New functions.
  48         (gdb_init): Initialize saved_command_line
  49         and previous_saved_command_line.
  50         * main.c (captured_main_1): Remove saved_command_line initialization.
  51         * event-top.c (handle_line_of_input): Update to use
  52         the new 'repeat' related functions instead of direct access to
  53         saved_command_line.
  54         * command.h (repeat_previous, get_saved_command_line,
  55         save_command_line): New declarations.
  56         (dont_repeat): Add comment.
  57
  58 2019-05-30  Tom Tromey  <tromey@adacore.com>
  59
  60         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
  61         Fix comment.
  62         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
  63
  64 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
  65
  66         PR cli/24587
  67         * completer.c (complete): Initialize variable word.
  68
  69 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
  70
  71         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
  72         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
  73         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
  74         'body' is NULL to the outter 'if', protecting the '!is_define'
  75         situation as well.
  76
  77 2019-05-29  Tom Tromey  <tromey@adacore.com>
  78
  79         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
  80         (dwarf_unknown): New function.
  81         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
  82         (dwarf_type_encoding_name): Use dwarf_unknown.
  83
  84 2019-05-29  Tom Tromey  <tromey@adacore.com>
  85
  86         PR c++/20020:
  87         * cp-valprint.c (cp_print_value_fields): Call
  88         cp_print_static_field inside "try".
  89
  90 2019-05-29  Tom Tromey  <tromey@adacore.com>
  91
  92         * inflow.c (struct terminal_info): Add default operator=.
  93         * configure: Rebuild.
  94         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
  95         -Wdeprecated-copy-dtor, -Wredundant-move.
  96
  97 2019-05-29  Tom Tromey  <tromey@adacore.com>
  98
  99         * NEWS: Add entry.
 100         * infcmd.c (print_return_value_1): Handle finish_print
 101         option.
 102         (show_print_finish): New function.
 103         (_initialize_infcmd): Add "set/show print finish" commands.
 104         * valprint.c (user_print_options): Initialize new member.
 105         * valprint.h (struct value_print_options) <finish_print>: New
 106         member.
 107
 108 2019-05-28  Tom Tromey  <tromey@adacore.com>
 109
 110         * ada-lang.c (ada_remove_Xbn_suffix)
 111         (find_old_style_renaming_symbol)
 112         (parse_old_style_renaming): Remove.
 113         (ada_find_renaming_symbol): Don't call
 114         find_old_style_renaming_symbol.
 115         (ada_is_renaming_symbol): Rename from
 116         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 117         bool.  Now static.
 118         (ada_read_var_value): Update and simplify.
 119         * ada-exp.y (write_var_or_type): Remove old code.
 120
 121 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 122
 123         * event-top.c: Remove include comment.
 124         * inflow.c (class scoped_ignore_sigttou): Move from here...
 125         * inflow.h (class scoped_ignore_sigttou): ...to here.
 126         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 127         * top.c:  Remove include comment.
 128
 129 2019-05-27  Tom Tromey  <tom@tromey.com>
 130
 131         * NEWS: Fix typo.
 132
 133 2019-05-22  Tom Tromey  <tromey@adacore.com>
 134
 135         * target.c (target_follow_exec): Constify parameter.
 136         * target-delegates.c: Rebuild.
 137         * remote.c (remote_target::follow_exec): Constify parameter.
 138         * infrun.c (follow_exec): Constify parameter.
 139         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 140         (target_follow_exec): Likewise.
 141
 142 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 143
 144         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 145         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 146
 147 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 148
 149         * NEWS: Add debugredirect and testsuite sections.
 150
 151 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 152
 153         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 154         target descriptions using exclusively floating point register name
 155         aliases.
 156
 157 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         PR gdb/18644:
 160         * f-lang.c (build_fortran_types): Handle the case where
 161         gdbarch_floatformat_for_type returns a nullptr.
 162
 163 2019-05-21  Tom de Vries  <tdevries@suse.de>
 164
 165         PR cli/24587
 166         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 167
 168 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 169
 170         PR gdb/18644:
 171         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 172         16-byte floats.
 173         * i386-tdep.c (i386_floatformat_for_type): Use
 174         floatformats_ia64_quad for the 16-byte floating point component
 175         within a fortran 32-byte complex number.
 176
 177 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 178
 179         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 180         delete default constructor.
 181         (find_partial_die): Update to return const struct.
 182         (partial_die_parent_scope): Move variable declaration into scope
 183         of its use and change its type to auto.
 184         (guess_partial_die_structure_name): Likewise.
 185         (partial_die_info::fixup): Likewise.
 186
 187 2019-05-17  Tom Tromey  <tromey@adacore.com>
 188
 189         * source.c (find_and_open_source): Remove cast.
 190
 191 2019-05-17  Tom Tromey  <tromey@adacore.com>
 192
 193         * annotate.c (annotate_source): Make "filename" const.
 194         * annotate.h (annotate_source): Use const.
 195
 196 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 197
 198         * disasm.c (set_disassembler_options): Send errors to stderr.
 199
 200 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 201
 202         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 203         (cli_interp_base::set_logging): Check debug_redirect.
 204         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 205         * cli/cli-logging.c (debug_redirect): Add static variable.
 206         (pop_output_files): Add default param.
 207         (handle_redirections): Print debug setting.
 208         (show_logging_command): Likewise.
 209         (_initialize_cli_logging): Add debugredirect command.
 210         * interps.c (current_interp_set_logging): Add debug_redirect
 211         parameter.
 212         * interps.h (set_logging): Add debug_redirect parameter.
 213         (current_interp_set_logging): Likewise.
 214         * mi/mi-common.h: Likewise.
 215         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 216
 217 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 218             Tom Tromey  <tromey@adacore.com>
 219
 220         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 221         directly.
 222         * cli/cli-interp.h (make_logging_output): Remove declaration.
 223         * cli/cli-logging.c (make_logging_output): Remove function.
 224         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 225         directly.
 226         * ui-file.c (tee_file::tee_file): Remove bools.
 227         (tee_file::~tee_file): Remove deletes.
 228         * ui-file.h (tee_file): Remove bools.
 229
 230 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 231
 232         * mi/mi-cmds.h (mi_cmd_complete): New function.
 233         * mi/mi-main.c (mi_cmd_complete): Likewise.
 234         * mi/mi-cmds.c: Define new MI command -complete.
 235         * NEWS: Mention new -complete command.
 236
 237 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 238
 239         * completer.h (complete): New function.
 240         * completer.c (complete): Likewise.
 241         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 242         function defined in completer.h.
 243
 244 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 245
 246        * MAINTAINERS (Write After Approval): Add myself.
 247
 248 2019-05-17  Tom de Vries  <tdevries@suse.de>
 249
 250         PR gdb/24094
 251         * dwarf2read.c (struct cu_partial_die_info): New struct.
 252         (find_partial_die): Return cu_partial_die_info.
 253         (partial_die_parent_scope, guess_partial_die_structure_name)
 254         (partial_die_info::fixup): Handle new return type of find_partial_die.
 255
 256 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 257
 258         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 259         "std::string", simplifying the algorithm.
 260
 261 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 262
 263         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 264         (stap_static_probe_ops::get_probes): Likewise.
 265
 266 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 267
 268         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 269         '-')" and "else if".
 270         (stap_parse_single_operand): Join checks for
 271         "gdbarch_stap_parse_special_token_p" and
 272         "gdbarch_stap_parse_special_token" in the same "if" statement.
 273         Invert check when verifying for operation on register
 274         displacement.
 275
 276 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 277
 278         * stap-probe.c (stap_get_opcode): Update comment.
 279         (stap_get_expected_argument_type): Likewise.
 280         (handle_stap_probe): Likewise.
 281
 282 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 283
 284         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 285         return type to 'bool'.  Adjust comment.  Use 'bool' when
 286         appropriate.
 287         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 288         * stap-probe.c (stap_parse_argument_1): Likewise.
 289         (stap_is_operator): Likewise.
 290         (stap_is_generic_prefix): Likewise.
 291         (stap_is_register_prefix): Likewise.
 292         (stap_is_register_indirection_prefix): Likewise.
 293         (stap_is_integer_prefix): Likewise.
 294         (stap_generic_check_suffix): Likewise.
 295         (stap_check_integer_suffix): Likewise.
 296         (stap_check_register_suffix): Likewise.
 297         (stap_check_register_indirection_suffix): Likewise.
 298         (stap_parse_register_operand): Likewise.
 299         (stap_parse_single_operand): Likewise.
 300         (stap_parse_argument_1): Likewise.
 301         (stap_probe::get_argument_count): Likewise.
 302         (stap_is_operator): Likewise.
 303
 304 2019-05-16  Tom Tromey  <tromey@adacore.com>
 305
 306         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 307         keyword to foreach.
 308
 309 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 310
 311         * linux-thread-db.c (try_thread_db_load_1): Change return type
 312         to bool.
 313         (try_thread_db_load): Likewise.
 314         (try_thread_db_load_from_pdir_1): Likewise.
 315         (try_thread_db_load_from_pdir): Likewise.
 316         (try_thread_db_load_from_sdir): Likewise.
 317         (try_thread_db_load_from_dir): Likewise.
 318         (thread_db_load_search): Likewise.
 319         (has_libpthread): Likewise.
 320         (thread_db_load): Likewise.
 321
 322 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 323
 324         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 325         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 326         NULL, and complain/return if that's the case.
 327
 328 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 329
 330         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 331         (advance, posn, abstract_read_memory): New functions.
 332         [struct mem_read_abstraction]: New struct.
 333         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 334
 335 2019-05-14  Tom Tromey  <tromey@adacore.com>
 336
 337         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 338         value is not lval_memory.
 339
 340 2019-05-14  Tom Tromey  <tromey@adacore.com>
 341
 342         * solib.c (info_sharedlibrary_command): Style the file name.
 343
 344 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 345
 346         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 347         (aarch64_vnv_type): Likewise.
 348         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 349         * common/tdesc.c: Likewise.
 350         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 351         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 352         * features/aarch64-fpu.xml: Add ieee half view.
 353         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 354         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 355         * gdbtypes.h (struct builtin_type): Likewise.
 356         (struct objfile_type): Likewise.
 357
 358 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 359
 360         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 361         typo.
 362         * location.h (string_to_event_location): Likewise.
 363
 364 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 365
 366         GDB 8.3 released.
 367
 368 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 369
 370         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 371         New variable declaration.
 372         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 373         New variable.
 374         (print_one_breakpoint): Use ui_out::test_flags and new global
 375         variable to compute use_fixed_output.
 376         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 377         Remove.
 378         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 379         (mi_multi_location_breakpoint_output_fixed): Remove.
 380         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 381         new variable.
 382         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 383         fix_multi_location_breakpoint_output flag if version >= 3.
 384         * ui-out.h (enum ui_out_flag)
 385         <fix_multi_location_breakpoint_output>: New enumerator.
 386
 387 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 388
 389         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 390
 391 2019-05-10  Tom Tromey  <tromey@adacore.com>
 392
 393         * ada-lang.c (catch_ada_completer): New function.
 394         (_initialize_ada_language): Use it.
 395
 396 2019-05-10  Tom Tromey  <tromey@adacore.com>
 397
 398         * thread.c (print_thread_info): Make "requested_threads" const.
 399         * gdbthread.h (print_thread_info): Make "requested_threads"
 400         const.
 401         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 402         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 403
 404 2019-05-08  Tom Tromey  <tom@tromey.com>
 405
 406         * gdbtypes.c (objfile_type_data): Change type.
 407         (objfile_type, _initialize_gdbtypes): Update.
 408
 409 2019-05-08  Tom Tromey  <tom@tromey.com>
 410
 411         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 412         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 413         (_initialize_dwarf2_frame): Update.
 414
 415 2019-05-08  Tom Tromey  <tom@tromey.com>
 416
 417         * objc-lang.c (objc_objfile_data): Change type.
 418         (find_methods): Update.
 419         (_initialize_objc_lang): Remove.
 420
 421 2019-05-08  Tom Tromey  <tom@tromey.com>
 422
 423         * stabsread.c (rs6000_builtin_type_data): Change type.
 424         (rs6000_builtin_type, _initialize_stabsread): Update.
 425
 426 2019-05-08  Tom Tromey  <tom@tromey.com>
 427
 428         * mips-tdep.c (mips_pdr_data): Remove.
 429         (_initialize_mips_tdep): Update.
 430
 431 2019-05-08  Tom Tromey  <tom@tromey.com>
 432
 433         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 434         (hppa_init_objfile_priv_data, read_unwind_info)
 435         (find_unwind_entry, _initialize_hppa_tdep): Update.
 436
 437 2019-05-08  Tom Tromey  <tom@tromey.com>
 438
 439         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 440         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 441         on obstack.
 442         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 443
 444 2019-05-08  Tom Tromey  <tom@tromey.com>
 445
 446         * mdebugread.c (basic_type_data): Change type.
 447         (basic_type, _initialize_mdebugread): Update.
 448
 449 2019-05-08  Tom Tromey  <tom@tromey.com>
 450
 451         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 452
 453 2019-05-08  Tom Tromey  <tom@tromey.com>
 454
 455         * nto-tdep.c (nto_inferior_data_reg): Change type.
 456         (nto_inferior_data): Update.
 457         (nto_inferior_data_cleanup, nto_new_inferior_data)
 458         (_initialize_nto_tdep): Remove.
 459         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 460
 461 2019-05-08  Tom Tromey  <tom@tromey.com>
 462
 463         * ada-lang.c (struct ada_inferior_data): Add initializers.
 464         (ada_inferior_data): Change type.
 465         (ada_inferior_data_cleanup): Remove.
 466         (get_ada_inferior_data, ada_inferior_exit)
 467         (struct ada_pspace_data): Add initializers, destructor.
 468         (ada_pspace_data_handle): Change type.
 469         (get_ada_pspace_data): Update.
 470         (ada_pspace_data_cleanup): Remove.
 471
 472 2019-05-08  Tom Tromey  <tom@tromey.com>
 473
 474         * coffread.c (struct coff_symfile_info): Add initializers.
 475         (coff_objfile_data_key): Move lower.  Change type.
 476         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 477         Update.
 478         (coff_free_info): Remove.
 479
 480 2019-05-08  Tom Tromey  <tom@tromey.com>
 481
 482         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 483         (fbsd_pspace_data_handle): Move lower.  Change type.
 484         (get_fbsd_pspace_data): Update.
 485         (fbsd_pspace_data_cleanup): Remove.
 486         (_initialize_fbsd_tdep): Update.
 487
 488 2019-05-08  Tom Tromey  <tom@tromey.com>
 489
 490         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 491         (get_ada_tasks_pspace_data): Update.
 492         (ada_tasks_pspace_data_cleanup): Remove.
 493         (_initialize_tasks): Update.
 494         (ada_tasks_inferior_data_handle): Change type.
 495         (get_ada_tasks_inferior_data): Update.
 496         (ada_tasks_inferior_data_cleanup): Remove.
 497         (struct ada_tasks_pspace_data): Add initializers.
 498
 499 2019-05-08  Tom Tromey  <tom@tromey.com>
 500
 501         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 502         * symfile-debug.c (debug_sym_get_probes): Change type.
 503         * stap-probe.c (handle_stap_probe):
 504         (stap_static_probe_ops::get_probes): Change type.
 505         * probe.h (class static_probe_ops) <get_probes>: Change type.
 506         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 507         (parse_probes_in_pspace): Update.
 508         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 509         Update.
 510         (any_static_probe_ops::get_probes): Change type.
 511         * elfread.c (elfread_data): New typedef.
 512         (probe_key): Change type.
 513         (elf_get_probes): Likewise.  Update.
 514         (probe_key_free): Remove.
 515         (_initialize_elfread): Update.
 516         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 517         Change type.
 518         (dtrace_process_dof_probe, dtrace_process_dof)
 519         (dtrace_static_probe_ops::get_probe): Change type.
 520
 521 2019-05-08  Tom Tromey  <tom@tromey.com>
 522
 523         * xcoffread.c (struct xcoff_symfile_info): Rename from
 524         coff_symfile_info.  Add initializers.
 525         (xcoff_objfile_data_key): Move lower.  Change type.
 526         (XCOFF_DATA): Rewrite.
 527         (xcoff_free_info): Remove.
 528         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 529         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 530         (xcoff_initial_scan): Update.
 531
 532 2019-05-08  Tom Tromey  <tom@tromey.com>
 533
 534         * solib-svr4.c (struct svr4_info): Add initializers and
 535         destructor.
 536         <probes_table>: Now an htab_up.
 537         (solib_svr4_pspace_data): Change type.
 538         (free_probes_table): Simplify.
 539         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 540         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 541         (probes_table_remove_objfile_probes, register_solib_event_probe)
 542         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 543         (_initialize_svr4_solib): Update.
 544
 545 2019-05-08  Tom Tromey  <tom@tromey.com>
 546
 547         * remote.c (remote_pspace_data): Change type.
 548         (remote_pspace_data_cleanup): Remove.
 549         (get_remote_exec_file, set_pspace_remote_exec_file)
 550         (_initialize_remote): Update.
 551
 552 2019-05-08  Tom Tromey  <tom@tromey.com>
 553
 554         * breakpoint.c (breakpoint_objfile_key): Change type.
 555         (get_breakpoint_objfile_data): Update.
 556         (free_breakpoint_objfile_data): Remove.
 557         (_initialize_breakpoint): Update.
 558
 559 2019-05-08  Tom Tromey  <tom@tromey.com>
 560
 561         * linux-tdep.c (struct linux_info): Add initializers.
 562         (linux_inferior_data): Move.  Change type.
 563         (invalidate_linux_cache_inf): Update.
 564         (linux_inferior_data_cleanup): Remove.
 565         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 566
 567 2019-05-08  Tom Tromey  <tom@tromey.com>
 568
 569         * auxv.c (auxv_inferior_data): Move.  Change type.
 570         (auxv_inferior_data_cleanup): Remove.
 571         (invalidate_auxv_cache_inf): Rewrite.
 572         (get_auxv_inferior_data, _initialize_auxv): Update.
 573
 574 2019-05-08  Tom Tromey  <tom@tromey.com>
 575
 576         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 577         (symfile_debug_objfile_data_key): Change type.
 578         (symfile_debug_installed, debug_qf_has_symbols)
 579         (debug_qf_find_last_source_symtab)
 580         (debug_qf_forget_cached_source_info)
 581         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 582         (debug_qf_print_stats, debug_qf_dump)
 583         (debug_qf_expand_symtabs_for_function)
 584         (debug_qf_expand_all_symtabs)
 585         (debug_qf_expand_symtabs_with_fullname)
 586         (debug_qf_map_matching_symbols)
 587         (debug_qf_expand_symtabs_matching)
 588         (debug_qf_find_pc_sect_compunit_symtab)
 589         (debug_qf_map_symbol_filenames)
 590         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 591         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 592         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 593         (debug_sym_read_linetable, debug_sym_relocate): Update.
 594         (symfile_debug_free_objfile): Remove.
 595         (install_symfile_debug_logging, _initialize_symfile_debug):
 596         Update.
 597
 598 2019-05-08  Tom Tromey  <tom@tromey.com>
 599
 600         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 601         allocate_on_obstack.
 602         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 603         (get_dwarf2_per_objfile): Update.
 604         (set_dwarf2_per_objfile): Remove.
 605         (dwarf2_has_info, dwarf2_get_section_info): Update.
 606         (dwarf2_free_objfile): Remove.
 607         (_initialize_dwarf2_read): Update.
 608
 609 2019-05-08  Tom Tromey  <tom@tromey.com>
 610
 611         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 612         initializers.
 613         <unsupported_script_warning_printed,
 614         script_not_found_warning_printed>: Now bool.
 615         (auto_load_pspace_data): Change type.
 616         (~auto_load_pspace_info): Rename from
 617         auto_load_pspace_data_cleanup.
 618         (get_auto_load_pspace_data, init_loaded_scripts_info)
 619         (clear_section_scripts, maybe_print_unsupported_script_warning)
 620         (maybe_print_script_not_found_warning, _initialize_auto_load):
 621         Update.
 622
 623 2019-05-08  Tom Tromey  <tom@tromey.com>
 624
 625         * objfiles.c (objfile_pspace_info): Add destructor and
 626         initializers.
 627         (objfiles_pspace_data): Change type.
 628         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 629         (get_objfile_pspace_data): Update.
 630         (objfiles_bfd_data): Change type.
 631         (get_objfile_bfd_data): Update.
 632         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 633
 634 2019-05-08  Tom Tromey  <tom@tromey.com>
 635
 636         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 637         Change type.
 638         (get_catch_syscall_inferior_data): Update.
 639         (catch_syscall_inferior_data_cleanup): Remove.
 640         (_initialize_break_catch_syscall): Update.
 641
 642 2019-05-08  Tom Tromey  <tom@tromey.com>
 643
 644         * inflow.c (struct terminal_info): Add destructor and
 645         initializers.
 646         (inflow_inferior_data): Change type.
 647         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 648         (get_inflow_inferior_data, inflow_inferior_exit)
 649         (swap_terminal_info, _initialize_inflow): Update.
 650
 651 2019-05-08  Tom Tromey  <tom@tromey.com>
 652
 653         * target-dcache.c (target_dcache_cleanup): Remove.
 654         (target_dcache_aspace_key): Change type.
 655         (target_dcache_init_p, target_dcache_invalidate)
 656         (target_dcache_get, target_dcache_get_or_init)
 657         (_initialize_target_dcache): Update.
 658         * dcache.h (struct dcache_deleter): New.
 659
 660 2019-05-08  Tom Tromey  <tom@tromey.com>
 661
 662         * symtab.c (struct symbol_cache): Add destructor and
 663         initializers.
 664         (symbol_cache_key): Move.  Change type.
 665         (make_symbol_cache, free_symbol_cache): Remove.
 666         (get_symbol_cache): Update.
 667         (symbol_cache_cleanup): Remove.
 668         (ALL_PSPACES, symbol_cache_flush)
 669         (maintenance_print_symbol_cache)
 670         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 671         Update.
 672
 673 2019-05-08  Tom Tromey  <tom@tromey.com>
 674
 675         * symtab.c (struct main_info): Add destructor and initializers.
 676         (main_progspace_key): Move.  Change type.
 677         (get_main_info): Update.
 678         (main_info_cleanup): Remove.
 679         (_initialize_symtab): Update.
 680
 681 2019-05-08  Tom Tromey  <tom@tromey.com>
 682
 683         * registry.h (DECLARE_REGISTRY): Define the _key class.
 684
 685 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 686
 687         * NEWS: Merge two 'New commands' sections.
 688
 689 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 690
 691         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 692         parameter and use Ada language definition instead.
 693         (ada_val_print_ptr): Remove unused language parameter.
 694         (ada_val_print_num): Remove language parameter and use Ada language
 695         definition instead.
 696         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 697         parameter.
 698         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 699         parameter and use Ada language definition instead.
 700         (ada_val_print_1): Update all ada_val_print_xxx calls.
 701         Remove language parameter.
 702         (ada_val_print): Update ada_val_print_1 call.
 703
 704 2019-05-08  Tom Tromey  <tromey@adacore.com>
 705
 706         * remote.c (remote_hw_watchpoint_limit)
 707         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 708         Now static.
 709
 710 2019-05-08  Tom Tromey  <tromey@adacore.com>
 711
 712         * maint.c (_initialize_maint_cmds): Move initialization code to
 713         remote.c.
 714         (watchdog, show_watchdog): Move to remote.c.
 715         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 716         "watchdog" static.
 717         (_initialize_remote): Move initialization code from maint.c.
 718         * defs.h (watchdog): Don't declare.
 719
 720 2019-05-08  Tom Tromey  <tromey@adacore.com>
 721
 722         * tui/tui-interp.c: Include main.h.
 723         * interps.c: Include main.h.
 724         * main.h (interpreter_p): Declare.
 725         * defs.h (interpreter_p): Don't declare.
 726
 727 2019-05-08  Tom Tromey  <tromey@adacore.com>
 728
 729         * dwarf2loc.c: Include dwarf2read.h.
 730         * defs.h (read_unsigned_leb128): Don't declare.
 731         * dwarf2read.h (read_unsigned_leb128): Declare.
 732
 733 2019-05-08  Tom Tromey  <tromey@adacore.com>
 734
 735         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 736         method.
 737
 738 2019-05-08  Tom Tromey  <tromey@adacore.com>
 739
 740         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 741         when no wrap column is set.
 742
 743 2019-05-08  Tom Tromey  <tromey@adacore.com>
 744
 745         * c-lang.c (c_get_string): Handle non-C-style arrays.
 746
 747 2019-05-08  Tom Tromey  <tromey@adacore.com>
 748
 749         * typeprint.c (print_offset_data::update): Print the bit offset,
 750         not the number of bits remaining.
 751
 752 2019-05-08  Tom Tromey  <tromey@adacore.com>
 753
 754         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 755         padding at end of comment.
 756
 757 2019-05-08  Tom Tromey  <tromey@adacore.com>
 758
 759         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 760         Compare main types.
 761
 762 2019-05-06  Tom Tromey  <tom@tromey.com>
 763
 764         * common/scoped_mmap.c: Include common-defs.h.
 765         * common/scoped_mmap.h: Don't include config.h.
 766
 767 2019-05-04  Tom Tromey  <tom@tromey.com>
 768
 769         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 770         (struct aarch64_call_info): Add initializers.
 771         <si>: Now a std::vector.
 772         (pass_on_stack, aarch64_push_dummy_call): Update.
 773
 774 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 775             Tom Tromey  <tom@tromey.com>
 776
 777         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 778         (ppc_threads): Now a std::vector.  Now static.
 779         (hwdebug_find_thread_points_by_tid)
 780         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 781         Update.
 782
 783 2019-05-04  Tom Tromey  <tom@tromey.com>
 784
 785         * arc-tdep.c (arc_tdesc_init): Return bool.
 786
 787 2019-05-04  Tom Tromey  <tom@tromey.com>
 788
 789         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 790         Use gdb_assert_not_reached.
 791
 792 2019-05-04  Tom Tromey  <tom@tromey.com>
 793
 794         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 795         "false".
 796
 797 2019-05-04  Tom Tromey  <tom@tromey.com>
 798
 799         * arc-tdep.c (arc_tdesc_init): Use bool.
 800
 801 2019-05-04  Tom Tromey  <tom@tromey.com>
 802
 803         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 804
 805 2019-05-04  Tom Tromey  <tom@tromey.com>
 806
 807         * cli/cli-cmds.c (valid_command_p): Return bool.
 808
 809 2019-05-04  Tom Tromey  <tom@tromey.com>
 810
 811         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 812         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 813
 814 2019-05-04  Raul Tambre  <raul@tambre.ee>
 815
 816         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 817         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 818         operator for comparison.
 819
 820 2019-05-04  Tom Tromey  <tom@tromey.com>
 821
 822         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 823         (lookup_partial_symbol, print_partial_symbols)
 824         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 825         (psymbol_compare): Update.
 826         (add_psymbol_to_bcache): Clear the entire psymbol.
 827         (maintenance_check_psymtabs): Update.
 828         * psympriv.h (struct partial_symbol): Don't derive from
 829         general_symbol_info.
 830         <obj_section, unrelocated_address, address,
 831         set_unrelocated_address>: Update.
 832         <ginfo>: New member.
 833         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 834         (debug_names::write_psymbols): Update.
 835
 836 2019-05-04  Tom de Vries  <tdevries@suse.de>
 837
 838         * contrib/cc-with-tweaks.sh: Support -n arg.
 839
 840 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 841
 842         * corelow.c (core_target::detach): Ensure frame cache and
 843         register caches are cleared.
 844         inferior.c (exit_inferior_1): Likewise.
 845
 846 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 847             Tom Tromey  <tom@tromey.com>
 848
 849         * dictionary.c (collate_pending_symbols_by_language): Remove
 850         "struct" from foreach.
 851         * symtab.c (lookup_global_symbol_from_objfile)
 852         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 853         foreach.
 854         * ser-tcp.c (net_open): Remove "struct" from foreach.
 855         * objfiles.c (objfile_relocate, objfile_rebase)
 856         (objfile_has_symbols): Remove "struct" from foreach.
 857         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 858         from foreach.
 859         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 860         foreach.
 861         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 862         "struct" from foreach.
 863         * ada-lang.c (create_excep_cond_exprs)
 864         (ada_exception_catchpoint_cond_string): Remove "struct" from
 865         foreach.
 866
 867 2019-05-03  Tom Tromey  <tromey@adacore.com>
 868
 869         * ada-exp.y (convert_char_literal): Check suffix of each
 870         enumerator.
 871
 872 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 873
 874         PR ada/21406:
 875         * ada-exp.y (yywrap): Don't define.
 876         * ada-lex.l (%option): Add noyywrap
 877         (yywrap): Remove.
 878
 879 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 880
 881         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 882         _WIN32_WINNT to the XP level, unless already defined to a higher
 883         level.
 884
 885         * unittests/parse-connection-spec-selftests.c:
 886         * ser-tcp.c:
 887         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 888         override.
 889
 890         * symfile.c (find_separate_debug_file): Remove colon from the
 891         drive spec of DOS/Windows file names of the target, so that the
 892         file name produced from DEBUGDIR and the target's directory will
 893         be valid on DOS/Windows systems.
 894
 895 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 896
 897         * rust-lang.c (val_print_struct): Handle printing structures
 898         containing strings.
 899
 900 2019-05-02  Tom Tromey  <tromey@adacore.com>
 901
 902         * valarith.c (_initialize_valarith): Remove.
 903
 904 2019-05-01  Tom Tromey  <tromey@adacore.com>
 905
 906         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 907         bitfields.
 908
 909 2019-05-01  Tom Tromey  <tromey@adacore.com>
 910
 911         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 912         for big-endian copies.
 913
 914 2019-04-30  Ali Tamur  <tamur@google.com>
 915         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 916         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 917         (read_3_bytes): New function.
 918
 919 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 920
 921         * windows-nat.c (main_thread_id): Delete.
 922         (handle_output_debug_string): Replace main_thread_id by
 923         current_event.dwThreadId.
 924         (fake_create_process): Likewise.
 925         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 926         Do not set main_thread_id.
 927         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 928         current_event.dwThreadId.
 929         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 930
 931 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 932
 933         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 934         Use current_event.dwThreadId instead of main_thread_id.
 935
 936 2019-04-30  Tom Tromey  <tromey@adacore.com>
 937
 938         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 939         (create_excep_cond_exprs): Iterate over program spaces.
 940         (ada_exception_catchpoint_cond_string): Examine all minimal
 941         symbols for exception types.
 942
 943 2019-04-30  Tom Tromey  <tromey@adacore.com>
 944
 945         PR c++/24470:
 946         * dwarf2read.c (process_structure_scope): Handle case where type
 947         has template parameters but no symbol was created.
 948
 949 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 950             Chris January  <chris.january@arm.com>
 951
 952         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 953         qualifier.
 954         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 955
 956 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 957
 958         * f-typeprint.c (f_print_type): Update rules for printing
 959         whitespace.
 960         (f_type_print_varspec_suffix): Likewise.
 961
 962 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 963             Chris January  <chris.january@arm.com>
 964
 965         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 966         function arguments.
 967
 968 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         * f-lang.c (build_fortran_types): Change name of void type to
 971         lower case.
 972         * f-typeprint.c (f_type_print_base): Print the name of the void
 973         type, rather than a fixed string.
 974         * f-valprint.c (f_decorations): Use lower case void string.
 975
 976 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 977             Chris January  <chris.january@arm.com>
 978
 979         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 980         types for Fortran.
 981
 982 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 983             Chris January  <chris.january@arm.com>
 984             David Lecomber  <david.lecomber@arm.com>
 985
 986         * f-exp.y (BINOP_INTRINSIC): New token.
 987         (exp): New parser rule handling BINOP_INTRINSIC.
 988         (f77_keywords): Add new builtin procedures.
 989         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 990         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 991         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 992         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 993         (print_unop_subexp_f): New function.
 994         (print_binop_subexp_f): New function.
 995         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 996         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 997         (dump_subexp_body_f): Likewise.
 998         (operator_check_f): Likewise.
 999         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1000         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1001
1002 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1005         UNOP_KIND.
1006         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1007         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1008         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1009         (operator_length_f): New fuction.
1010         (print_subexp_f): New function.
1011         (op_name_f): New function.
1012         (dump_subexp_body_f): New function.
1013         (operator_check_f): New function.
1014         (exp_descriptor_f): Replace standard expression handling functions
1015         with new functions.
1016         * gdb/fortran-operator.def: New file.
1017         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1018         * gdb/std-operator.def: Remove UNOP_KIND.
1019
1020 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * std-operator.def: Remove unbalanced, stray double quote
1023         character.
1024
1025 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1026             Chris January  <chris.january@arm.com>
1027             Daniel Everett  <daniel.everett@arm.com>
1028             Nick Forrington  <nick.forrington@arm.com>
1029             Richard Bunt  <richard.bunt@arm.com>
1030
1031         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1032         of depth when printing anonymous structs or unions.
1033         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1034         Don't print either the top-level value, or the children if the
1035         max-depth is exceeded.
1036         (ppscm_print_children): When printing the key of a map, allow one
1037         extra level of depth.
1038         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1039         print either the top-level value, or the children if the max-depth
1040         is exceeded.
1041         (print_children): When printing the key of a map, allow one extra
1042         level of depth.
1043         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1044         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1045         (user_print_options): Initialise max_depth field.
1046         (val_print_scalar_or_string_type_p): New function.
1047         (val_print): Check to see if the max depth has been reached.
1048         (val_print_check_max_depth): Define new function.
1049         (show_print_max_depth): New function.
1050         (_initialize_valprint): Add 'print max-depth' option.
1051         * valprint.h (struct value_print_options) <max_depth>: New field.
1052         (val_print_check_max_depth): Declare new function.
1053         * NEWS: Document new feature.
1054
1055 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         * ada-lang.c (ada_language_defn): Initialise new field.
1058         * c-lang.c (c_is_string_type_p): New function.
1059         (c_language_defn): Initialise new field.
1060         (cplus_language_defn): Initialise new field.
1061         (asm_language_defn): Initialise new field.
1062         (minimal_language_defn): Initialise new field.
1063         * c-lang.h (c_is_string_type_p): Declare new function.
1064         * d-lang.c (d_language_defn): Initialise new field.
1065         * f-lang.c (f_is_string_type_p): New function.
1066         (f_language_defn): Initialise new field.
1067         * go-lang.c (go_is_string_type_p): New function.
1068         (go_language_defn): Initialise new field.
1069         * language.c (default_is_string_type_p): New function.
1070         (unknown_language_defn): Initialise new field.
1071         (auto_language_defn): Initialise new field.
1072         * language.h (struct language_defn) <la_is_string_type_p>: New
1073         member variable.
1074         (default_is_string_type_p): Declare new function.
1075         * m2-lang.c (m2_language_defn): Initialise new field.
1076         * objc-lang.c (objc_language_defn): Initialise new field.
1077         * opencl-lang.c (opencl_language_defn): Initialise new field.
1078         * p-lang.c (pascal_is_string_type_p): New function.
1079         (pascal_language_defn): Initialise new field.
1080         * rust-lang.c (rust_is_string_type_p): New function.
1081         (rust_language_defn): Initialise new field.
1082
1083 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1086         New field.
1087         * ada-lang.c (ada_language_defn): Initialise new field.
1088         * c-lang.c (c_language_defn): Likewise.
1089         (cplus_language_defn): Likewise.
1090         (asm_language_defn): Likewise.
1091         (minimal_language_defn): Likewise.
1092         * d-lang.c (d_language_defn): Likewise.
1093         * f-lang.c (f_language_defn): Likewise.
1094         * go-lang.c (go_language_defn): Likewise.
1095         * language.c (unknown_language_defn): Likewise.
1096         (auto_language_defn): Likewise.
1097         * m2-lang.c (m2_language_defn): Likewise.
1098         * objc-lang.c (objc_language_defn): Likewise.
1099         * opencl-lang.c (opencl_language_defn): Likewise.
1100         * p-lang.c (pascal_language_defn): Likewise.
1101         * rust-lang.c (rust_language_defn): Likewise.
1102
1103 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * ada-lang.c (ada_is_character_type): Change return type to bool.
1106         (ada_is_string_type): Likewise.
1107         * ada-lang.h (ada_is_character_type): Update declaration
1108         (ada_is_string_type): Likewise.
1109
1110 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1111
1112         Support style in 'frame|thread apply'
1113
1114         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1115         * record.c (record_start, record_stop): Update callers of
1116         execute_command_to_string with false.
1117         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1118         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1119         methods.
1120         (class string_file): New constructor with term_out parameter.
1121         Override methods term_out and can_emit_style_escape.  New member
1122         term_out.
1123         (class stdio_file): Override can_emit_style_escape.
1124         (class tee_file): Override term_out and can_emit_style_escape.
1125         * utils.h (can_emit_style_escape): Remove.
1126         * utils.c (can_emit_style_escape): Likewise.
1127         Update all callers of can_emit_style_escape (SOMESTREAM) to
1128         SOMESTREAM->can_emit_style_escape.
1129         * source-cache.c (source_cache::get_source_lines): Likewise.
1130         * stack.c (frame_apply_command_count): Call execute_command_to_string
1131         passing the term_out characteristic of the current gdb_stdout.
1132         * thread.c (thr_try_catch_cmd): Likewise.
1133         * top.c (execute_command_to_string): pass term_out parameter
1134         to construct the string_file for the command output.
1135         * ui-file.c (term_cli_styling): New function (most code moved
1136         from utils.c can_emit_style_escape).
1137         (string_file::string_file, string_file::can_emit_style_escape,
1138         stdio_file::can_emit_style_escape, tee_file::term_out,
1139         tee_file::can_emit_style_escape): New functions.
1140
1141 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1142
1143         * NEWS: Mention the new set|show may-call-functions.
1144         * infcall.c (may_call_functions_p): New variable.
1145         (show_may_call_functions_p): New function.
1146         (call_function_by_hand_dummy): Throws an error if not
1147         may-call-functions.
1148         (_initialize_infcall): Call add_setshow_boolean_cmd for
1149         may-call-functions.
1150
1151 2019-04-25  Keith Seitz  <keiths@redhat.com>
1152
1153         PR c++/24367
1154         * cp-support.c (inspect_type): Don't attempt substitutions
1155         of symbol with the same name.
1156
1157 2019-04-25  Tom Tromey  <tromey@adacore.com>
1158
1159         PR gdb/24475:
1160         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1161         static.
1162
1163 2019-04-25  Tom Tromey  <tromey@adacore.com>
1164
1165         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1166         rvalue reference.
1167         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1168         (gdb_xml_parser::parse): Use std::move.
1169         * python/python-internal.h (gdbpy_convert_exception): Take a const
1170         reference.
1171         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1172         std::move.
1173         * python/py-utils.c (gdbpy_convert_exception): Take a const
1174         reference.
1175         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1176         Use std::move.
1177         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1178         Use std::move.
1179         * mi/mi-main.c (mi_print_exception): Take a const reference.
1180         * main.c (handle_command_errors): Take a const reference.
1181         * linespec.c (parse_linespec): Use std::move.
1182         * infcall.c (run_inferior_call): Use std::move.
1183         (call_function_by_hand_dummy): Use std::move.
1184         * exec.c (try_open_exec_file): Use std::move.
1185         * exceptions.h (exception_print, exception_fprintf)
1186         (exception_print_same): Update.
1187         * exceptions.c (print_exception, exception_print)
1188         (exception_fprintf, exception_print_same): Change parameters to
1189         const reference.
1190         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1191         * common/new-op.c: Use std::move.
1192         * common/common-exceptions.h (struct gdb_exception): Add move
1193         constructor.
1194         (struct gdb_exception_error, struct gdb_exception_quit, struct
1195         gdb_quit_bad_alloc): Change constructor to move constructor.
1196         (throw_exception): Change parameter to rvalue reference.
1197         * common/common-exceptions.c (throw_exception): Take rvalue
1198         reference.
1199         * cli/cli-interp.c (safe_execute_command): Use std::move.
1200         * breakpoint.c (insert_bp_location, location_to_sals): Use
1201         std::move.
1202
1203 2019-04-25  Tom Tromey  <tromey@adacore.com>
1204
1205         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1206         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1207         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1208         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1209         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1210         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1211         guile/scm-value.c: Use unpack.
1212         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1213         gdbscm_gdb_exception.
1214         (gdbscm_throw_gdb_exception): Likewise.
1215         (struct gdbscm_gdb_exception): New.
1216         (unpack): New function.
1217         (gdbscm_wrap): Use unpack.
1218
1219 2019-04-25  Tom Tromey  <tromey@adacore.com>
1220
1221         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1222         (gdb_rl_callback_handler): Use std::move.
1223         * common/common-exceptions.h (struct gdb_exception): Add move
1224         assignment operator.
1225         (throw_exception_sjlj): Change "exception" to const reference.
1226         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1227         (throw_exception_sjlj): Change "exception" to const reference.
1228
1229 2019-04-25  Tom Tromey  <tromey@adacore.com>
1230
1231         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1232         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1233         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1234         Update.
1235         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1236         Update.
1237         * mi/mi-interp.c (mi_interp::exec): Update.
1238         * linespec.c (parse_linespec): Update.
1239         * infcall.c (run_inferior_call): Update.
1240         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1241         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1242         (gdbscm_lookup_global_symbol): Update.
1243         * guile/scm-param.c (gdbscm_parameter_value): Update.
1244         * guile/scm-frame.c (gdbscm_frame_read_register)
1245         (gdbscm_frame_read_var): Update.
1246         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1247         * exec.c (try_open_exec_file): Update.
1248         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1249         (gdb_rl_callback_handler): Update.
1250         * common/common-exceptions.h (exception_none): Don't declare.
1251         * common/common-exceptions.c (exception_none): Don't define.
1252         (struct catcher) <exception>: Update.
1253         * cli/cli-interp.c (safe_execute_command): Update.
1254         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1255
1256 2019-04-25  Ali Tamur  <tamur@google.com>
1257
1258         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1259         (read_attribute_value): Likewise.
1260         (dwarf2_read_addr_index): Update comment.
1261         (read_str_index): Add DW_FORM_strx.
1262         (dwarf2_string_attr): Likewise.
1263         (dwarf2_const_value_attr): Likewise.
1264         (dump_die_shallow): Likewise.
1265         (dwarf2_fetch_constant_bytes): Likewise.
1266         (skip_form_bytes): Likewise.
1267         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1268
1269 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1270
1271         PR corefiles/11608
1272         PR corefiles/18187
1273         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1274         OFFSET.  Verify if current mapping contains an ELF header.
1275         (linux_find_memory_regions_full): Adjust call to
1276         dump_mapping_p.
1277
1278 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1279             Kang Li <kanglictf@gmail.com>
1280
1281         PR gdb/21600
1282
1283         * dwarf2-frame.c (read_initial_length): Be consistent about using
1284         unsigned representation of length.
1285         (decode_frame_entry_1): Likewise.  Check for wraparound of
1286         end pointer as well as buffer overflow.
1287
1288 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1289
1290         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1291         "vq".
1292
1293 2019-04-24  Tom Tromey  <tromey@adacore.com>
1294
1295         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1296
1297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * s12z-tdep.c (s12z_unwind_pc): Delete.
1300         (s12z_unwind_sp): Delete.
1301         (s12z_gdbarch_init): Don't register deleted functions with
1302         gdbarch.
1303
1304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * rl78-tdep.c (rl78_unwind_sp): Delete.
1307         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1308
1309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1310
1311         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1312         (xstormy16_unwind_pc): Delete.
1313         (xstormy16_dummy_id): Delete.
1314         (xstormy16_gdbarch_init): Don't register deleted functions with
1315         gdbarch.
1316
1317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * vax-tdep.c (vax_unwind_pc): Delete.
1320         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1321
1322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * v850-tdep.c (v850_unwind_sp): Delete.
1325         (v850_unwind_pc): Delete.
1326         (v850_dummy_id): Delete.
1327         (v850_gdbarch_init): Don't register deleted functions with
1328         gdbarch.
1329
1330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1331
1332         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1333         (tilegx_unwind_pc): Delete.
1334         (tilegx_unwind_dummy_id): Delete.
1335         (tilegx_gdbarch_init): Don't register deleted functions with
1336         gdbarch.
1337
1338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1341         (tic6x_dummy_id): Delete.
1342         (tic6x_gdbarch_init): Don't register deleted functions with
1343         gdbarch.
1344
1345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * sparc-tdep.c (sparc_unwind_pc): Delete.
1348         (sparc32_gdbarch_init): Don't register deleted function with
1349         gdbarch.
1350
1351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1352
1353         * sh-tdep.c (sh_unwind_sp): Delete.
1354         (sh_unwind_pc): Delete.
1355         (sh_dummy_id): Delete.
1356         (sh_gdbarch_init): Don't register deleted functions with
1357         gdbarch.
1358
1359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1360
1361         * score-tdep.c (score_unwind_sp): Delete.
1362         (score_unwind_pc): Delete.
1363         (score_dummy_id): Delete.
1364         (score_gdbarch_init): Don't register deleted functions with
1365         gdbarch.
1366
1367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1368
1369         * rx-tdep.c (rx_unwind_pc): Delete.
1370         (rx_unwind_sp): Delete.
1371         (rx_dummy_id): Delete.
1372         (rx_gdbarch_init): Don't register deleted functions with
1373         gdbarch.  Update comment.
1374
1375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1376
1377         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1378         (rs6000_dummy_id): Delete.
1379         (rs6000_gdbarch_init): Don't register deleted functions with
1380         gdbarch.
1381
1382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1383
1384         * or1k-tdep.c (or1k_dummy_id): Delete.
1385         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1386
1387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1388
1389         * nios2-tdep.c (nios2_dummy_id): Delete.
1390         (nios2_unwind_sp): Delete.
1391         (nios2_gdbarch_init): Don't register deleted functions with
1392         gdbarch.
1393
1394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1395
1396         * nds32-tdep.c (nds32_dummy_id): Delete.
1397         (nds32_unwind_pc): Delete.
1398         (nds32_unwind_sp): Delete.
1399         (nds32_gdbarch_init): Don't register deleted functions with
1400         gdbarch.
1401
1402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1403
1404         * msp430-tdep.c (msp430_unwind_pc): Delete.
1405         (msp430_unwind_sp): Delete.
1406         (msp430_dummy_id): Delete.
1407         (msp430_gdbarch_init): Don't register deleted functions with
1408         gdbarch.
1409
1410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1411
1412         * moxie-tdep.c (moxie_unwind_sp): Delete.
1413         (moxie_unwind_pc): Delete.
1414         (moxie_dummy_id): Delete.
1415         (moxie_gdbarch_init): Don't register deleted functions with
1416         gdbarch.
1417
1418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1419
1420         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1421         (mn10300_unwind_pc): Delete.
1422         (mn10300_unwind_sp): Delete.
1423         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1424         mn10300_unwind_sp.
1425         (mn10300_frame_unwind_init): Don't register deleted functions with
1426         gdbarch.
1427
1428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1429
1430         * mep-tdep.c (mep_unwind_pc): Delete.
1431         (mep_unwind_sp): Delete.
1432         (mep_dummy_id): Delete.
1433         (mep_gdbarch_init): Don't register deleted functions with
1434         gdbarch.
1435
1436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1437
1438         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1439         (m68hc11_unwind_sp): Delete.
1440         (m68hc11_gdbarch_init): Don't register deleted functions with
1441         gdbarch.
1442
1443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1444
1445         * m32r-tdep.c (m32r_unwind_sp): Delete.
1446         (m32r_unwind_pc): Delete.
1447         (m32r_dummy_id): Delete.
1448         (m32r_gdbarch_init): Don't register deleted functions with
1449         gdbarch.
1450
1451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * m32c-tdep.c (m32c_unwind_pc): Delete.
1454         (m32c_unwind_sp): Delete.
1455         (m32c_dummy_id): Delete.
1456         (m32c_gdbarch_init): Don't register deleted functions with
1457         gdbarch.
1458
1459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1460
1461         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1462         (lm32_unwind_pc): Delete.
1463         (lm32_dummy_id): Delete.
1464         (lm32_gdbarch_init): Don't register deleted functions with
1465         gdbarch.
1466
1467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1468
1469         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1470         (iq2000_unwind_pc): Delete.
1471         (iq2000_dummy_id): Delete.
1472         (iq2000_gdbarch_init): Don't register deleted functions with
1473         gdbarch.
1474
1475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1476
1477         * nds32-tdep.c (nds32_type_align): Delete.
1478         (nds32_push_dummy_call): Use type_align instead.
1479
1480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * arm-tdep.c (arm_type_align): Only handle vector override case.
1483         (arm_push_dummy_call): Use type_align.
1484         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1485
1486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1487
1488         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1489         case.
1490         (pass_on_stack): Use type_align.
1491         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1492         function.
1493
1494 2019-04-23  Tom Tromey  <tromey@adacore.com>
1495
1496         * dwarf2read.c (line_header::file_name_at): Remove unused
1497         overload.
1498
1499 2019-04-23  Tom de Vries  <tdevries@suse.de>
1500
1501         PR gdb/24438
1502         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1503         invocation.
1504
1505
1506 2019-03-27  Ali Tamur  <tamur@google.com>
1507
1508         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1509         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1510         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1511         (dwarf_expr_context::get_addr_index): Likewise
1512         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1513         (symbol_needs_eval_context::get_addr_index): Likewise
1514         (disassemble_dwarf_expression): Add DW_OP_addrx
1515         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1516         (read_cutu_die_from_dwo): Update comment
1517         (skip_one_die): Add DW_FORM_addrx
1518         (read_attribute_value): Likewise
1519         (var_decode_location): Add DW_OP_addrx
1520         (dwarf2_const_value_attr): Add DW_FORM_addrx
1521         (dump_die_shallow): Likewise
1522         (dwarf2_fetch_constant_bytes): Likewise
1523         (decode_locdesc): Add DW_OP_addrx
1524         (skip_form_bytes): Add DW_FORM_addrx
1525
1526 2019-04-22  Ali Tamur  <tamur@google.com>
1527
1528         * MAINTAINERS (Write After Approval): Add self.
1529
1530 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1531
1532         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1533         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1534         (open_symbol_file_object): Likewise.
1535         (svr4_default_sos): Add info parameter.
1536         (svr4_read_so_list): Likewise.
1537         (svr4_current_sos_direct): Adjust functions calls to pass down
1538         info.
1539         (svr4_current_sos_1): Add info parameter.
1540         (svr4_current_sos): Call get_svr4_info, pass info down to
1541         svr4_current_sos_1.
1542         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1543         get_svr4_info.
1544         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1545         get_svr4_info.
1546         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1547         to get_svr4_info.
1548         (probes_table_remove_objfile_probes): Likewise.
1549         (register_solib_event_probe): Add info parameter.
1550         (solist_update_incremental): Pass info parameter down to
1551         svr4_read_so_list.
1552         (disable_probes_interface): Add info parameter.
1553         (svr4_handle_solib_event): Pass current_program_space to
1554         get_svr4_info.  Adjust disable_probes_interface cleanup.
1555         (svr4_create_probe_breakpoints): Add info parameter, pass it
1556         down to register_solib_event_probe.
1557         (svr4_create_solib_event_breakpoints): Add info parameter,
1558         pass it down to svr4_create_probe_breakpoints.
1559         (enable_break): Pass info down to
1560         svr4_create_solib_event_breakpoints.
1561         (svr4_solib_create_inferior_hook): Pass current_program_space to
1562         get_svr4_info.
1563         (svr4_clear_solib): Likewise.
1564
1565 2019-04-22  Pedro Alves  <palves@redhat.com>
1566
1567         * solib-svr4.c (svr4_free_objfile_observer): New.
1568         (probe_and_action::objfile): New field.
1569         (probes_table_htab_remove_objfile_probes)
1570         (probes_table_remove_objfile_probes): New functions.
1571         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1572         in the new probe_and_action.  Don't store the probe in 'lookup'.
1573         (svr4_create_probe_breakpoints): Pass objfile to
1574         register_solib_event_probe.
1575         (_initialize_svr4_solib): Register a free_objfile observer.
1576
1577 2019-04-19  Tom Tromey  <tom@tromey.com>
1578
1579         * common/queue.h: Remove.
1580
1581 2019-04-19  Tom Tromey  <tom@tromey.com>
1582
1583         * event-loop.c: Don't include "common/queue.h".
1584
1585 2019-04-19  Tom Tromey  <tom@tromey.com>
1586
1587         * remote.c (remote_target): Use delete.
1588         * remote-notif.h: Include <list>, not "common/queue.h".
1589         (notif_client_p): Remove typedef.
1590         (remote_notif_state): Add constructor, destructor, initializer.
1591         <notif_queue>: Now a std::list.
1592         (remote_notif_state_xfree): Don't declare.
1593         * remote-notif.c (remote_notif_process, handle_notification)
1594         (remote_notif_state_allocate): Update.
1595         (~remote_notif_state): Rename from remote_notif_state_xfree.
1596
1597 2019-04-19  Tom Tromey  <tom@tromey.com>
1598
1599         * symfile.c (reread_symbols): Update.
1600         * objfiles.c (objfile_register_static_link)
1601         (objfile_lookup_static_link): Update
1602         (~objfile) Don't delete static_links.
1603         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1604
1605 2019-04-19  Tom Tromey  <tom@tromey.com>
1606
1607         * type-stack.h (struct type_stack) <insert>: Constify string.
1608         * type-stack.c (type_stack::insert): Constify string.
1609         * gdbtypes.h (lookup_template_type): Update.
1610         (address_space_name_to_int): Update.
1611         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1612         const.
1613         (lookup_template_type): Make name const.
1614         * c-exp.y: Update rules.
1615         (lex_one_token, classify_name, classify_inner_name)
1616         (c_print_token): Update.
1617         * p-exp.y: Update rules.
1618         (yylex): Update.
1619         * f-exp.y: Update rules.
1620         (yylex): Update.
1621         * d-exp.y: Update rules.
1622         (lex_one_token, classify_name, classify_inner_name): Update.
1623         * parse.c (write_dollar_variable, copy_name): Return std::string.
1624         * parser-defs.h (copy_name): Change return type.
1625         * m2-exp.y: Update rules.
1626         (yylex): Update.
1627         * go-exp.y (lex_one_token): Update.
1628         Update rules.
1629         (classify_unsafe_function, classify_packaged_name)
1630         (classify_name, yylex): Update.
1631
1632 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1633
1634         * configure.ac: add --enable-source-highlight switch.
1635         * configure: Regenerate.
1636         * top.c (print_gdb_version): plumb --enable-source-highlight
1637         status to "show configuration".
1638
1639 2019-04-19  Tom Tromey  <tromey@adacore.com>
1640
1641         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1642         Check ADA_TYPE_P.
1643         (empty_record, ada_template_to_fixed_record_type_1)
1644         (template_to_static_fixed_type)
1645         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1646         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1647         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1648         macros.
1649
1650 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1651
1652         PR symtab/24423:
1653         * source.c (print_source_lines_base): Advance "iter" when a
1654         control character is seen.
1655
1656 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1657
1658         * inferior.h (struct infcall_suspend_state_deleter):
1659         Catch exception in destructor to avoid crash.
1660
1661 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1662
1663         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1664         close to the add_com "shell".
1665
1666 2019-04-18  Tom Tromey  <tromey@adacore.com>
1667
1668         * process-stratum-target.h (class process_stratum_target)
1669         <stratum>: Add "final".
1670
1671 2019-04-17  Tom Tromey  <tromey@adacore.com>
1672
1673         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1674         against nullptr before use.
1675
1676 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1677
1678         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1679
1680 2019-04-17  Jim Wilson  <jimw@sifive.com>
1681             Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1684         code read might fail, assume 4-byte breakpoint in that case.
1685
1686 2019-04-15  Leszek Swirski  <leszeks@google.com>
1687
1688         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1689         rather than a hand-rolled POD check when checking for forced MEMORY
1690         classification.
1691
1692 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1693
1694         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1695         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1696         function.
1697         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1698         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1699         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1700         declaration.
1701
1702 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1703
1704         * aarch64-linux-nat.c
1705         (aarch64_linux_nat_target::thread_architecture): Add override.
1706         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1707         each VQ.
1708
1709 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1710
1711         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1712
1713 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1714
1715         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1716         target types of size 96-bits, add some additional comments, and
1717         check that the builtin type we found was the correct size.
1718
1719 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1720
1721         * utils.c (prompt_for_continue): Don't restore the styling at the
1722         end, as applied_style has the wrong value.  This fixes styling in
1723         long lists of file names that are interrupted by the "Continue?"
1724         prompt.
1725
1726 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1729         * c-lang.c (c_language_defn): Likewise.
1730         (cplus_language_defn): Likewise.
1731         (asm_language_defn): Likewise.
1732         (minimal_language_defn): Likewise.
1733         * d-lang.c (d_language_defn): Likewise.
1734         * f-lang.c (f_language_defn): Likewise.
1735         * go-lang.c (go_language_defn): Likewise.
1736         * language.c (unknown_language_defn): Likewise.
1737         (auto_language_defn): Likewise.
1738         * language.h (struct language_defn): Remove la_magic field.
1739         (LANG_MAGIC): Delete.
1740         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1741         * objc-lang.c (objc_language_defn): Likewise.
1742         * opencl-lang.c (opencl_language_defn): Likewise.
1743         * p-lang.c (pascal_language_defn): Likewise.
1744         * rust-lang.c (rust_language_defn): Likewise.
1745
1746 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1747
1748         * riscv-tdep.c (riscv_type_align): New function.
1749         (riscv_type_alignment): Delete.
1750         (riscv_arg_location): Use 'type_align'.
1751         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1752
1753 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1754
1755         * gdbtypes.c (type_align): A struct with no non-static fields also
1756         has alignment of 1.
1757
1758 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1759
1760         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1761         component to 0.
1762         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1763         member.
1764         (riscv_struct_info::analyse): New implementation using new
1765         analyse_inner member function.
1766         (riscv_struct_info::field_offset): New member function.
1767         (riscv_struct_info::m_offsets): New member variable.
1768         (riscv_struct_info::analyse_inner): New private member function,
1769         takes the old implementation of riscv_struct_info::analyse but
1770         extended to track field offsets.
1771         (riscv_call_arg_struct): Update the struct folding special cases
1772         to handle cases where empty C++ structs, which are non-zero
1773         length, are found.
1774         (riscv_arg_location): Initialise the length of each location, a
1775         non-zero length now indicates the location is in use.
1776         (riscv_push_dummy_call): Allow for the first location having a
1777         non-zero offset when setting up arguments.
1778         (riscv_return_value): Likewise, but for return values.
1779
1780 2019-04-11  Tom Tromey  <tromey@adacore.com>
1781
1782         * utils.c (internal_vproblem): Make "msg" const.
1783
1784 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1785
1786         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1787         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1788         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1789         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1790
1791 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1792
1793         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1794         function.
1795         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1796         of amd64_collect_native_gregset.
1797         (amd64_linux_nat_target::store_registers): Likewise.
1798
1799 2019-04-10  Tom Tromey  <tom@tromey.com>
1800
1801         * symtab.c (lookup_global_symbol_from_objfile)
1802         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1803         * objfiles.h (class separate_debug_iterator): New.
1804         (class separate_debug_range): New.
1805         (struct objfile) <separate_debug_objfiles>: New method.
1806         (objfile_separate_debug_iterate): Don't declare.
1807         * objfiles.c (separate_debug_iterator::operator++): Rename from
1808         objfile_separate_debug_iterate.
1809         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1810         iterator.
1811         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1812         iterator.
1813
1814 2019-04-10  Tom Tromey  <tom@tromey.com>
1815
1816         * symfile.c (reread_symbols): Remove old comment.
1817         * objfiles.c (free_all_objfiles): Fix a typo.
1818
1819 2019-04-10  Tom Tromey  <tom@tromey.com>
1820
1821         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1822         * minsyms.c (lookup_minimal_symbol): Use foreach.
1823         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1824         (lookup_minimal_symbol_solib_trampoline): Likewise.
1825         * symfile.c (reread_symbols): Use foreach.
1826
1827 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1828             Tom Tromey  <tromey@adacore.com>
1829
1830         PR rust/24414:
1831         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1832         (rust_lex_int_test): Change "value" to be LONGEST.
1833         (rust_lex_tests): Add test for long integer literal.
1834
1835 2019-04-09  Tom Tromey  <tromey@adacore.com>
1836
1837         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1838         to bool.
1839         (extended_remote_target::attach): Update.
1840         (remote_target::remote_notice_new_inferior): Update.
1841         (remote_target::add_current_inferior_and_thread): Update.
1842         * inferior.c (exit_inferior_1): Use "false".
1843         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1844
1845 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1846
1847         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1848         the "start" command.
1849
1850 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1851
1852         * python/py-inferior.c (infpy_thread_from_thread_handle):
1853         Adjust comments to reflect renaming of thread_from_thread_handle
1854         to thread_from_handle.  Adjust keywords.  Fix type error message.
1855         (inferior_object_methods): Add thread_from_handle.  Retain
1856         thread_from_thread_handle, but mark it as deprecated.
1857
1858 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1859
1860         * gdbthread.h (find_thread_by_handle): Revise declaration.
1861         * thread.c (find_thread_by_handle): Likewise.  Adjust
1862         implementation too.
1863         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1864         support for buffer objects as handles.
1865
1866 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1867
1868         * python/py-infthread.c (thpy_thread_handle): New function.
1869         (thread_object_methods): Register thpy_thread_handle.
1870
1871 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1872
1873         * gdbthread.h (thread_to_thread_handle): Declare.
1874         * thread.c (gdbtypes.h): Include.
1875         (thread_to_thread_handle): New function.
1876
1877         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1878         (target_thread_info_to_thread_handle): Declare.
1879         * target.c (target_thread_info_to_thread_handle): New function.
1880         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1881         * target-delegates.c: Regenerate.
1882
1883         * linux-thread-db.c (class thread_db_target): Add method
1884         thread_info_to_thread_handle.
1885         (thread_db_target::thread_info_to_thread_handle): Define.
1886         * remote.c (class remote_target): Add new method
1887         thread_info_to_thread_handle.
1888         (remote_target::thread_info_to_thread_handle): Define.
1889
1890 2019-04-08  Pedro Alves  <palves@redhat.com>
1891
1892         * common/common-exceptions.c (throw_exception): Don't create
1893         named object to throw; throw directly.
1894         (throw_it): Likewise.  Don't initialize gdb_exception::message
1895         here, with new; pass FMT and AP to the ctor instead.
1896         * common/common-exceptions.h: Include <string>.
1897         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1898         const char *, va_list)): New ctor.  Use std::make_shared.
1899         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1900         errors)): Delete.
1901         (gdb_exception_error::gdb_exception_error(enum errors, const char
1902         *, va_list)): New.
1903         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1904         Add assertion.
1905         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1906         errors)): Delete.
1907         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1908         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1909         Add assertion.
1910
1911 2019-04-08  Tom Tromey  <tom@tromey.com>
1912
1913         * valops.c (value_rtti_indirect_type): Replace throw_exception
1914         with throw.
1915         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1916         with throw.
1917         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1918         throw.
1919         * target.c (target_translate_tls_address): Replace throw_exception
1920         with throw.
1921         * stack.c (frame_apply_command_count): Replace throw_exception
1922         with throw.
1923         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1924         throw.
1925         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1926         with throw.
1927         * rs6000-tdep.c (rs6000_frame_cache)
1928         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1929         * remote.c: Replace throw_exception with throw.
1930         * record-full.c (record_full_message, record_full_wait_1)
1931         (record_full_restore): Replace throw_exception with throw.
1932         * record-btrace.c:
1933         (get_thread_current_frame_id, record_btrace_start_replaying)
1934         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1935         (cmd_record_btrace_start): Replace throw_exception with throw.
1936         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1937         throw.
1938         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1939         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1940         * linespec.c:
1941         (find_linespec_symbols): Replace throw_exception with throw.
1942         * infrun.c (displaced_step_prepare, resume): Replace
1943         throw_exception with throw.
1944         * infcmd.c (post_create_inferior): Replace throw_exception with
1945         throw.
1946         * inf-loop.c (inferior_event_handler): Replace throw_exception
1947         with throw.
1948         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1949         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1950         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1951         (get_prev_frame_always, get_frame_pc_if_available)
1952         (get_frame_address_in_block_if_available, get_frame_language):
1953         Replace throw_exception with throw.
1954         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1955         throw_exception with throw.
1956         * eval.c (fetch_subexp_value, evaluate_var_value)
1957         (evaluate_funcall, evaluate_subexp_standard): Replace
1958         throw_exception with throw.
1959         * dwarf2loc.c (call_site_find_chain)
1960         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1961         Replace throw_exception with throw.
1962         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1963         with throw.
1964         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1965         throw.
1966         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1967         * completer.c (complete_line_internal): Replace throw_exception
1968         with throw.
1969         * compile/compile-object-run.c (compile_object_run): Replace
1970         throw_exception with throw.
1971         * cli/cli-script.c (process_next_line): Replace throw_exception
1972         with throw.
1973         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1974         (btrace_enable, btrace_maint_update_pt_packets): Replace
1975         throw_exception with throw.
1976         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1977         throw_exception with throw.
1978         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1979         throw_exception with throw.
1980         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1981         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1982         * aarch64-tdep.c (aarch64_make_prologue_cache)
1983         (aarch64_make_stub_cache): Replace throw_exception with throw.
1984
1985 2019-04-08  Tom Tromey  <tom@tromey.com>
1986
1987         * common/common-exceptions.c (throw_exception): Rename from
1988         throw_exception_cxx.  Remove old copy.  Make argument const.
1989         (throw_it): Create and throw exception objects directly.
1990         * common/common-exceptions.h (throw_exception): Make argument
1991         const.
1992         (struct gdb_exception_error): Add constructor.
1993         (struct gdb_exception_quit): Add constructor.
1994
1995 2019-04-08  Tom Tromey  <tom@tromey.com>
1996
1997         * common/common-exceptions.h (exception_rethrow): Don't declare.
1998         (TRY_SJLJ): Update comment.
1999         (TRY, CATCH, END_CATCH): Remove.
2000         * common/common-exceptions.c (exception_rethrow): Remove.
2001
2002 2019-04-08  Tom Tromey  <tom@tromey.com>
2003
2004         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2005         Remove.
2006         (gdb_exception_error): Rename from
2007         gdb_exception_RETURN_MASK_ERROR.
2008         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2009         (gdb_quit_bad_alloc): Update.
2010         * aarch64-tdep.c: Update.
2011         * ada-lang.c: Update.
2012         * ada-typeprint.c: Update.
2013         * ada-valprint.c: Update.
2014         * amd64-tdep.c: Update.
2015         * arch-utils.c: Update.
2016         * break-catch-throw.c: Update.
2017         * breakpoint.c: Update.
2018         * btrace.c: Update.
2019         * c-varobj.c: Update.
2020         * cli/cli-cmds.c: Update.
2021         * cli/cli-interp.c: Update.
2022         * cli/cli-script.c: Update.
2023         * common/common-exceptions.c: Update.
2024         * common/new-op.c: Update.
2025         * common/selftest.c: Update.
2026         * compile/compile-c-symbols.c: Update.
2027         * compile/compile-cplus-symbols.c: Update.
2028         * compile/compile-object-load.c: Update.
2029         * compile/compile-object-run.c: Update.
2030         * completer.c: Update.
2031         * corelow.c: Update.
2032         * cp-abi.c: Update.
2033         * cp-support.c: Update.
2034         * cp-valprint.c: Update.
2035         * darwin-nat.c: Update.
2036         * disasm-selftests.c: Update.
2037         * dtrace-probe.c: Update.
2038         * dwarf-index-cache.c: Update.
2039         * dwarf-index-write.c: Update.
2040         * dwarf2-frame-tailcall.c: Update.
2041         * dwarf2-frame.c: Update.
2042         * dwarf2loc.c: Update.
2043         * dwarf2read.c: Update.
2044         * eval.c: Update.
2045         * event-loop.c: Update.
2046         * event-top.c: Update.
2047         * exec.c: Update.
2048         * f-valprint.c: Update.
2049         * fbsd-tdep.c: Update.
2050         * frame-unwind.c: Update.
2051         * frame.c: Update.
2052         * gdbtypes.c: Update.
2053         * gnu-v3-abi.c: Update.
2054         * guile/guile-internal.h: Update.
2055         * guile/scm-block.c: Update.
2056         * guile/scm-breakpoint.c: Update.
2057         * guile/scm-cmd.c: Update.
2058         * guile/scm-disasm.c: Update.
2059         * guile/scm-frame.c: Update.
2060         * guile/scm-lazy-string.c: Update.
2061         * guile/scm-math.c: Update.
2062         * guile/scm-param.c: Update.
2063         * guile/scm-ports.c: Update.
2064         * guile/scm-pretty-print.c: Update.
2065         * guile/scm-symbol.c: Update.
2066         * guile/scm-symtab.c: Update.
2067         * guile/scm-type.c: Update.
2068         * guile/scm-value.c: Update.
2069         * i386-linux-tdep.c: Update.
2070         * i386-tdep.c: Update.
2071         * inf-loop.c: Update.
2072         * infcall.c: Update.
2073         * infcmd.c: Update.
2074         * infrun.c: Update.
2075         * jit.c: Update.
2076         * language.c: Update.
2077         * linespec.c: Update.
2078         * linux-fork.c: Update.
2079         * linux-nat.c: Update.
2080         * linux-tdep.c: Update.
2081         * linux-thread-db.c: Update.
2082         * main.c: Update.
2083         * mi/mi-cmd-break.c: Update.
2084         * mi/mi-cmd-stack.c: Update.
2085         * mi/mi-interp.c: Update.
2086         * mi/mi-main.c: Update.
2087         * objc-lang.c: Update.
2088         * p-valprint.c: Update.
2089         * parse.c: Update.
2090         * ppc-linux-tdep.c: Update.
2091         * printcmd.c: Update.
2092         * python/py-arch.c: Update.
2093         * python/py-breakpoint.c: Update.
2094         * python/py-cmd.c: Update.
2095         * python/py-finishbreakpoint.c: Update.
2096         * python/py-frame.c: Update.
2097         * python/py-framefilter.c: Update.
2098         * python/py-gdb-readline.c: Update.
2099         * python/py-inferior.c: Update.
2100         * python/py-infthread.c: Update.
2101         * python/py-lazy-string.c: Update.
2102         * python/py-linetable.c: Update.
2103         * python/py-objfile.c: Update.
2104         * python/py-param.c: Update.
2105         * python/py-prettyprint.c: Update.
2106         * python/py-progspace.c: Update.
2107         * python/py-record-btrace.c: Update.
2108         * python/py-record.c: Update.
2109         * python/py-symbol.c: Update.
2110         * python/py-type.c: Update.
2111         * python/py-unwind.c: Update.
2112         * python/py-utils.c: Update.
2113         * python/py-value.c: Update.
2114         * python/python.c: Update.
2115         * record-btrace.c: Update.
2116         * record-full.c: Update.
2117         * remote-fileio.c: Update.
2118         * remote.c: Update.
2119         * riscv-tdep.c: Update.
2120         * rs6000-aix-tdep.c: Update.
2121         * rs6000-tdep.c: Update.
2122         * rust-exp.y: Update.
2123         * rust-lang.c: Update.
2124         * s390-tdep.c: Update.
2125         * selftest-arch.c: Update.
2126         * solib-dsbt.c: Update.
2127         * solib-frv.c: Update.
2128         * solib-spu.c: Update.
2129         * solib-svr4.c: Update.
2130         * solib.c: Update.
2131         * sparc64-linux-tdep.c: Update.
2132         * stack.c: Update.
2133         * symfile-mem.c: Update.
2134         * symmisc.c: Update.
2135         * target.c: Update.
2136         * thread.c: Update.
2137         * top.c: Update.
2138         * tracefile-tfile.c: Update.
2139         * tui/tui.c: Update.
2140         * typeprint.c: Update.
2141         * unittests/cli-utils-selftests.c: Update.
2142         * unittests/parse-connection-spec-selftests.c: Update.
2143         * valops.c: Update.
2144         * valprint.c: Update.
2145         * value.c: Update.
2146         * varobj.c: Update.
2147         * windows-nat.c: Update.
2148         * x86-linux-nat.c: Update.
2149         * xml-support.c: Update.
2150
2151 2019-04-08  Tom Tromey  <tom@tromey.com>
2152
2153         * xml-support.c: Use C++ exception handling.
2154         * x86-linux-nat.c: Use C++ exception handling.
2155         * windows-nat.c: Use C++ exception handling.
2156         * varobj.c: Use C++ exception handling.
2157         * value.c: Use C++ exception handling.
2158         * valprint.c: Use C++ exception handling.
2159         * valops.c: Use C++ exception handling.
2160         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2161         handling.
2162         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2163         * typeprint.c: Use C++ exception handling.
2164         * tui/tui.c: Use C++ exception handling.
2165         * tracefile-tfile.c: Use C++ exception handling.
2166         * top.c: Use C++ exception handling.
2167         * thread.c: Use C++ exception handling.
2168         * target.c: Use C++ exception handling.
2169         * symmisc.c: Use C++ exception handling.
2170         * symfile-mem.c: Use C++ exception handling.
2171         * stack.c: Use C++ exception handling.
2172         * sparc64-linux-tdep.c: Use C++ exception handling.
2173         * solib.c: Use C++ exception handling.
2174         * solib-svr4.c: Use C++ exception handling.
2175         * solib-spu.c: Use C++ exception handling.
2176         * solib-frv.c: Use C++ exception handling.
2177         * solib-dsbt.c: Use C++ exception handling.
2178         * selftest-arch.c: Use C++ exception handling.
2179         * s390-tdep.c: Use C++ exception handling.
2180         * rust-lang.c: Use C++ exception handling.
2181         * rust-exp.y: Use C++ exception handling.
2182         * rs6000-tdep.c: Use C++ exception handling.
2183         * rs6000-aix-tdep.c: Use C++ exception handling.
2184         * riscv-tdep.c: Use C++ exception handling.
2185         * remote.c: Use C++ exception handling.
2186         * remote-fileio.c: Use C++ exception handling.
2187         * record-full.c: Use C++ exception handling.
2188         * record-btrace.c: Use C++ exception handling.
2189         * python/python.c: Use C++ exception handling.
2190         * python/py-value.c: Use C++ exception handling.
2191         * python/py-utils.c: Use C++ exception handling.
2192         * python/py-unwind.c: Use C++ exception handling.
2193         * python/py-type.c: Use C++ exception handling.
2194         * python/py-symbol.c: Use C++ exception handling.
2195         * python/py-record.c: Use C++ exception handling.
2196         * python/py-record-btrace.c: Use C++ exception handling.
2197         * python/py-progspace.c: Use C++ exception handling.
2198         * python/py-prettyprint.c: Use C++ exception handling.
2199         * python/py-param.c: Use C++ exception handling.
2200         * python/py-objfile.c: Use C++ exception handling.
2201         * python/py-linetable.c: Use C++ exception handling.
2202         * python/py-lazy-string.c: Use C++ exception handling.
2203         * python/py-infthread.c: Use C++ exception handling.
2204         * python/py-inferior.c: Use C++ exception handling.
2205         * python/py-gdb-readline.c: Use C++ exception handling.
2206         * python/py-framefilter.c: Use C++ exception handling.
2207         * python/py-frame.c: Use C++ exception handling.
2208         * python/py-finishbreakpoint.c: Use C++ exception handling.
2209         * python/py-cmd.c: Use C++ exception handling.
2210         * python/py-breakpoint.c: Use C++ exception handling.
2211         * python/py-arch.c: Use C++ exception handling.
2212         * printcmd.c: Use C++ exception handling.
2213         * ppc-linux-tdep.c: Use C++ exception handling.
2214         * parse.c: Use C++ exception handling.
2215         * p-valprint.c: Use C++ exception handling.
2216         * objc-lang.c: Use C++ exception handling.
2217         * mi/mi-main.c: Use C++ exception handling.
2218         * mi/mi-interp.c: Use C++ exception handling.
2219         * mi/mi-cmd-stack.c: Use C++ exception handling.
2220         * mi/mi-cmd-break.c: Use C++ exception handling.
2221         * main.c: Use C++ exception handling.
2222         * linux-thread-db.c: Use C++ exception handling.
2223         * linux-tdep.c: Use C++ exception handling.
2224         * linux-nat.c: Use C++ exception handling.
2225         * linux-fork.c: Use C++ exception handling.
2226         * linespec.c: Use C++ exception handling.
2227         * language.c: Use C++ exception handling.
2228         * jit.c: Use C++ exception handling.
2229         * infrun.c: Use C++ exception handling.
2230         * infcmd.c: Use C++ exception handling.
2231         * infcall.c: Use C++ exception handling.
2232         * inf-loop.c: Use C++ exception handling.
2233         * i386-tdep.c: Use C++ exception handling.
2234         * i386-linux-tdep.c: Use C++ exception handling.
2235         * guile/scm-value.c: Use C++ exception handling.
2236         * guile/scm-type.c: Use C++ exception handling.
2237         * guile/scm-symtab.c: Use C++ exception handling.
2238         * guile/scm-symbol.c: Use C++ exception handling.
2239         * guile/scm-pretty-print.c: Use C++ exception handling.
2240         * guile/scm-ports.c: Use C++ exception handling.
2241         * guile/scm-param.c: Use C++ exception handling.
2242         * guile/scm-math.c: Use C++ exception handling.
2243         * guile/scm-lazy-string.c: Use C++ exception handling.
2244         * guile/scm-frame.c: Use C++ exception handling.
2245         * guile/scm-disasm.c: Use C++ exception handling.
2246         * guile/scm-cmd.c: Use C++ exception handling.
2247         * guile/scm-breakpoint.c: Use C++ exception handling.
2248         * guile/scm-block.c: Use C++ exception handling.
2249         * guile/guile-internal.h: Use C++ exception handling.
2250         * gnu-v3-abi.c: Use C++ exception handling.
2251         * gdbtypes.c: Use C++ exception handling.
2252         * frame.c: Use C++ exception handling.
2253         * frame-unwind.c: Use C++ exception handling.
2254         * fbsd-tdep.c: Use C++ exception handling.
2255         * f-valprint.c: Use C++ exception handling.
2256         * exec.c: Use C++ exception handling.
2257         * event-top.c: Use C++ exception handling.
2258         * event-loop.c: Use C++ exception handling.
2259         * eval.c: Use C++ exception handling.
2260         * dwarf2read.c: Use C++ exception handling.
2261         * dwarf2loc.c: Use C++ exception handling.
2262         * dwarf2-frame.c: Use C++ exception handling.
2263         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2264         * dwarf-index-write.c: Use C++ exception handling.
2265         * dwarf-index-cache.c: Use C++ exception handling.
2266         * dtrace-probe.c: Use C++ exception handling.
2267         * disasm-selftests.c: Use C++ exception handling.
2268         * darwin-nat.c: Use C++ exception handling.
2269         * cp-valprint.c: Use C++ exception handling.
2270         * cp-support.c: Use C++ exception handling.
2271         * cp-abi.c: Use C++ exception handling.
2272         * corelow.c: Use C++ exception handling.
2273         * completer.c: Use C++ exception handling.
2274         * compile/compile-object-run.c: Use C++ exception handling.
2275         * compile/compile-object-load.c: Use C++ exception handling.
2276         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2277         * compile/compile-c-symbols.c: Use C++ exception handling.
2278         * common/selftest.c: Use C++ exception handling.
2279         * common/new-op.c: Use C++ exception handling.
2280         * cli/cli-script.c: Use C++ exception handling.
2281         * cli/cli-interp.c: Use C++ exception handling.
2282         * cli/cli-cmds.c: Use C++ exception handling.
2283         * c-varobj.c: Use C++ exception handling.
2284         * btrace.c: Use C++ exception handling.
2285         * breakpoint.c: Use C++ exception handling.
2286         * break-catch-throw.c: Use C++ exception handling.
2287         * arch-utils.c: Use C++ exception handling.
2288         * amd64-tdep.c: Use C++ exception handling.
2289         * ada-valprint.c: Use C++ exception handling.
2290         * ada-typeprint.c: Use C++ exception handling.
2291         * ada-lang.c: Use C++ exception handling.
2292         * aarch64-tdep.c: Use C++ exception handling.
2293
2294 2019-04-08  Tom Tromey  <tom@tromey.com>
2295
2296         * xml-support.c (gdb_xml_parser::parse): Update.
2297         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2298         * value.c (show_convenience): Update.
2299         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2300         (test_parse_flags_qcs): Update.
2301         * thread.c (thr_try_catch_cmd): Update.
2302         * target.c (target_translate_tls_address): Update.
2303         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2304         (info_frame_command_core, frame_apply_command_count): Update.
2305         * rust-exp.y (rust_lex_exception_test): Update.
2306         * riscv-tdep.c (riscv_print_one_register_info): Update.
2307         * remote.c (remote_target::enable_btrace): Update.
2308         * record-btrace.c (record_btrace_enable_warn): Update.
2309         * python/py-utils.c (gdbpy_convert_exception): Update.
2310         * printcmd.c (do_one_display, print_variable_and_value): Update.
2311         * mi/mi-main.c (mi_print_exception): Update.
2312         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2313         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2314         * linux-nat.c (linux_nat_target::attach): Update.
2315         * linux-fork.c (class scoped_switch_fork_info): Update.
2316         * infrun.c (displaced_step_prepare): Update.
2317         * infcall.c (call_function_by_hand_dummy): Update.
2318         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2319         * gnu-v3-abi.c (print_one_vtable): Update.
2320         * frame.c (get_prev_frame_always): Update.
2321         * f-valprint.c (info_common_command_for_block): Update.
2322         * exec.c (try_open_exec_file): Update.
2323         * exceptions.c (print_exception, exception_print)
2324         (exception_fprintf, exception_print_same): Update.
2325         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2326         * dwarf-index-cache.c (index_cache::store)
2327         (index_cache::lookup_gdb_index): Update.
2328         * darwin-nat.c (maybe_cache_shell): Update.
2329         * cp-valprint.c (cp_print_value_fields): Update.
2330         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2331         (gcc_cplus_symbol_address): Update.
2332         * compile/compile-c-symbols.c (gcc_convert_symbol)
2333         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2334         * common/selftest.c: Update.
2335         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2336         a std::string.
2337         (exception_try_scope_entry, exception_try_scope_exit): Don't
2338         declare.
2339         (struct exception_try_scope): Remove.
2340         (TRY): Don't use exception_try_scope.
2341         (struct gdb_exception): Add constructor, operator=.
2342         <what>: New method.
2343         (struct gdb_exception_RETURN_MASK_ALL)
2344         (struct gdb_exception_RETURN_MASK_ERROR)
2345         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2346         (struct gdb_quit_bad_alloc): Update.
2347         * common/common-exceptions.c (exception_none): Change
2348         initializer.
2349         (struct catcher) <state, exception>: Initialize inline.
2350         <prev>: Remove member.
2351         (current_catcher): Remove.
2352         (catchers): New global.
2353         (exceptions_state_mc_init): Simplify.
2354         (catcher_pop): Remove.
2355         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2356         (try_scope_depth, exception_try_scope_entry)
2357         (exception_try_scope_exit): Remove.
2358         (throw_exception_sjlj): Update.
2359         (exception_messages, exception_messages_size): Remove.
2360         (throw_it): Simplify.
2361         (gdb_exception_sliced_copy): Remove.
2362         (throw_exception_cxx): Update.
2363         * cli/cli-script.c (script_from_file): Update.
2364         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2365         Update.
2366         * ada-valprint.c (ada_val_print): Update.
2367         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2368         (create_excep_cond_exprs): Update.
2369
2370 2019-04-08  Tom Tromey  <tom@tromey.com>
2371
2372         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2373         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2374         (TRY, CATCH, END_CATCH): Remove some definitions.
2375         * common/common-exceptions.c: Don't use GDB_XCPT.
2376         (catcher_list_size): Remove.
2377         (throw_exception, throw_it): Simplify.
2378
2379 2019-04-05  Tom Tromey  <tom@tromey.com>
2380
2381         Revert the header-sorting patch.
2382         * ft32-tdep.c: Revert.
2383         * frv-tdep.c: Revert.
2384         * frv-linux-tdep.c: Revert.
2385         * frame.c: Revert.
2386         * frame-unwind.c: Revert.
2387         * frame-base.c: Revert.
2388         * fork-child.c: Revert.
2389         * findvar.c: Revert.
2390         * findcmd.c: Revert.
2391         * filesystem.c: Revert.
2392         * filename-seen-cache.h: Revert.
2393         * filename-seen-cache.c: Revert.
2394         * fbsd-tdep.c: Revert.
2395         * fbsd-nat.h: Revert.
2396         * fbsd-nat.c: Revert.
2397         * f-valprint.c: Revert.
2398         * f-typeprint.c: Revert.
2399         * f-lang.c: Revert.
2400         * extension.h: Revert.
2401         * extension.c: Revert.
2402         * extension-priv.h: Revert.
2403         * expprint.c: Revert.
2404         * exec.h: Revert.
2405         * exec.c: Revert.
2406         * exceptions.c: Revert.
2407         * event-top.c: Revert.
2408         * event-loop.c: Revert.
2409         * eval.c: Revert.
2410         * elfread.c: Revert.
2411         * dwarf2read.h: Revert.
2412         * dwarf2read.c: Revert.
2413         * dwarf2loc.c: Revert.
2414         * dwarf2expr.h: Revert.
2415         * dwarf2expr.c: Revert.
2416         * dwarf2-frame.c: Revert.
2417         * dwarf2-frame-tailcall.c: Revert.
2418         * dwarf-index-write.h: Revert.
2419         * dwarf-index-write.c: Revert.
2420         * dwarf-index-common.c: Revert.
2421         * dwarf-index-cache.h: Revert.
2422         * dwarf-index-cache.c: Revert.
2423         * dummy-frame.c: Revert.
2424         * dtrace-probe.c: Revert.
2425         * disasm.h: Revert.
2426         * disasm.c: Revert.
2427         * disasm-selftests.c: Revert.
2428         * dictionary.c: Revert.
2429         * dicos-tdep.c: Revert.
2430         * demangle.c: Revert.
2431         * dcache.h: Revert.
2432         * dcache.c: Revert.
2433         * darwin-nat.h: Revert.
2434         * darwin-nat.c: Revert.
2435         * darwin-nat-info.c: Revert.
2436         * d-valprint.c: Revert.
2437         * d-namespace.c: Revert.
2438         * d-lang.c: Revert.
2439         * ctf.c: Revert.
2440         * csky-tdep.c: Revert.
2441         * csky-linux-tdep.c: Revert.
2442         * cris-tdep.c: Revert.
2443         * cris-linux-tdep.c: Revert.
2444         * cp-valprint.c: Revert.
2445         * cp-support.c: Revert.
2446         * cp-namespace.c: Revert.
2447         * cp-abi.c: Revert.
2448         * corelow.c: Revert.
2449         * corefile.c: Revert.
2450         * continuations.c: Revert.
2451         * completer.h: Revert.
2452         * completer.c: Revert.
2453         * complaints.c: Revert.
2454         * coffread.c: Revert.
2455         * coff-pe-read.c: Revert.
2456         * cli-out.h: Revert.
2457         * cli-out.c: Revert.
2458         * charset.c: Revert.
2459         * c-varobj.c: Revert.
2460         * c-valprint.c: Revert.
2461         * c-typeprint.c: Revert.
2462         * c-lang.c: Revert.
2463         * buildsym.c: Revert.
2464         * buildsym-legacy.c: Revert.
2465         * build-id.h: Revert.
2466         * build-id.c: Revert.
2467         * btrace.c: Revert.
2468         * bsd-uthread.c: Revert.
2469         * breakpoint.h: Revert.
2470         * breakpoint.c: Revert.
2471         * break-catch-throw.c: Revert.
2472         * break-catch-syscall.c: Revert.
2473         * break-catch-sig.c: Revert.
2474         * blockframe.c: Revert.
2475         * block.c: Revert.
2476         * bfin-tdep.c: Revert.
2477         * bfin-linux-tdep.c: Revert.
2478         * bfd-target.c: Revert.
2479         * bcache.c: Revert.
2480         * ax-general.c: Revert.
2481         * ax-gdb.h: Revert.
2482         * ax-gdb.c: Revert.
2483         * avr-tdep.c: Revert.
2484         * auxv.c: Revert.
2485         * auto-load.c: Revert.
2486         * arm-wince-tdep.c: Revert.
2487         * arm-tdep.c: Revert.
2488         * arm-symbian-tdep.c: Revert.
2489         * arm-pikeos-tdep.c: Revert.
2490         * arm-obsd-tdep.c: Revert.
2491         * arm-nbsd-tdep.c: Revert.
2492         * arm-nbsd-nat.c: Revert.
2493         * arm-linux-tdep.c: Revert.
2494         * arm-linux-nat.c: Revert.
2495         * arm-fbsd-tdep.c: Revert.
2496         * arm-fbsd-nat.c: Revert.
2497         * arm-bsd-tdep.c: Revert.
2498         * arch-utils.c: Revert.
2499         * arc-tdep.c: Revert.
2500         * arc-newlib-tdep.c: Revert.
2501         * annotate.h: Revert.
2502         * annotate.c: Revert.
2503         * amd64-windows-tdep.c: Revert.
2504         * amd64-windows-nat.c: Revert.
2505         * amd64-tdep.c: Revert.
2506         * amd64-sol2-tdep.c: Revert.
2507         * amd64-obsd-tdep.c: Revert.
2508         * amd64-obsd-nat.c: Revert.
2509         * amd64-nbsd-tdep.c: Revert.
2510         * amd64-nbsd-nat.c: Revert.
2511         * amd64-nat.c: Revert.
2512         * amd64-linux-tdep.c: Revert.
2513         * amd64-linux-nat.c: Revert.
2514         * amd64-fbsd-tdep.c: Revert.
2515         * amd64-fbsd-nat.c: Revert.
2516         * amd64-dicos-tdep.c: Revert.
2517         * amd64-darwin-tdep.c: Revert.
2518         * amd64-bsd-nat.c: Revert.
2519         * alpha-tdep.c: Revert.
2520         * alpha-obsd-tdep.c: Revert.
2521         * alpha-nbsd-tdep.c: Revert.
2522         * alpha-mdebug-tdep.c: Revert.
2523         * alpha-linux-tdep.c: Revert.
2524         * alpha-linux-nat.c: Revert.
2525         * alpha-bsd-tdep.c: Revert.
2526         * alpha-bsd-nat.c: Revert.
2527         * aix-thread.c: Revert.
2528         * agent.c: Revert.
2529         * addrmap.c: Revert.
2530         * ada-varobj.c: Revert.
2531         * ada-valprint.c: Revert.
2532         * ada-typeprint.c: Revert.
2533         * ada-tasks.c: Revert.
2534         * ada-lang.c: Revert.
2535         * aarch64-tdep.c: Revert.
2536         * aarch64-ravenscar-thread.c: Revert.
2537         * aarch64-newlib-tdep.c: Revert.
2538         * aarch64-linux-tdep.c: Revert.
2539         * aarch64-linux-nat.c: Revert.
2540         * aarch64-fbsd-tdep.c: Revert.
2541         * aarch64-fbsd-nat.c: Revert.
2542         * aarch32-linux-nat.c: Revert.
2543
2544 2019-04-05  Tom Tromey  <tom@tromey.com>
2545
2546         * ft32-tdep.c: Sort headers.
2547         * frv-tdep.c: Sort headers.
2548         * frv-linux-tdep.c: Sort headers.
2549         * frame.c: Sort headers.
2550         * frame-unwind.c: Sort headers.
2551         * frame-base.c: Sort headers.
2552         * fork-child.c: Sort headers.
2553         * findvar.c: Sort headers.
2554         * findcmd.c: Sort headers.
2555         * filesystem.c: Sort headers.
2556         * filename-seen-cache.h: Sort headers.
2557         * filename-seen-cache.c: Sort headers.
2558         * fbsd-tdep.c: Sort headers.
2559         * fbsd-nat.h: Sort headers.
2560         * fbsd-nat.c: Sort headers.
2561         * f-valprint.c: Sort headers.
2562         * f-typeprint.c: Sort headers.
2563         * f-lang.c: Sort headers.
2564         * extension.h: Sort headers.
2565         * extension.c: Sort headers.
2566         * extension-priv.h: Sort headers.
2567         * expprint.c: Sort headers.
2568         * exec.h: Sort headers.
2569         * exec.c: Sort headers.
2570         * exceptions.c: Sort headers.
2571         * event-top.c: Sort headers.
2572         * event-loop.c: Sort headers.
2573         * eval.c: Sort headers.
2574         * elfread.c: Sort headers.
2575         * dwarf2read.h: Sort headers.
2576         * dwarf2read.c: Sort headers.
2577         * dwarf2loc.c: Sort headers.
2578         * dwarf2expr.h: Sort headers.
2579         * dwarf2expr.c: Sort headers.
2580         * dwarf2-frame.c: Sort headers.
2581         * dwarf2-frame-tailcall.c: Sort headers.
2582         * dwarf-index-write.h: Sort headers.
2583         * dwarf-index-write.c: Sort headers.
2584         * dwarf-index-common.c: Sort headers.
2585         * dwarf-index-cache.h: Sort headers.
2586         * dwarf-index-cache.c: Sort headers.
2587         * dummy-frame.c: Sort headers.
2588         * dtrace-probe.c: Sort headers.
2589         * disasm.h: Sort headers.
2590         * disasm.c: Sort headers.
2591         * disasm-selftests.c: Sort headers.
2592         * dictionary.c: Sort headers.
2593         * dicos-tdep.c: Sort headers.
2594         * demangle.c: Sort headers.
2595         * dcache.h: Sort headers.
2596         * dcache.c: Sort headers.
2597         * darwin-nat.h: Sort headers.
2598         * darwin-nat.c: Sort headers.
2599         * darwin-nat-info.c: Sort headers.
2600         * d-valprint.c: Sort headers.
2601         * d-namespace.c: Sort headers.
2602         * d-lang.c: Sort headers.
2603         * ctf.c: Sort headers.
2604         * csky-tdep.c: Sort headers.
2605         * csky-linux-tdep.c: Sort headers.
2606         * cris-tdep.c: Sort headers.
2607         * cris-linux-tdep.c: Sort headers.
2608         * cp-valprint.c: Sort headers.
2609         * cp-support.c: Sort headers.
2610         * cp-namespace.c: Sort headers.
2611         * cp-abi.c: Sort headers.
2612         * corelow.c: Sort headers.
2613         * corefile.c: Sort headers.
2614         * continuations.c: Sort headers.
2615         * completer.h: Sort headers.
2616         * completer.c: Sort headers.
2617         * complaints.c: Sort headers.
2618         * coffread.c: Sort headers.
2619         * coff-pe-read.c: Sort headers.
2620         * cli-out.h: Sort headers.
2621         * cli-out.c: Sort headers.
2622         * charset.c: Sort headers.
2623         * c-varobj.c: Sort headers.
2624         * c-valprint.c: Sort headers.
2625         * c-typeprint.c: Sort headers.
2626         * c-lang.c: Sort headers.
2627         * buildsym.c: Sort headers.
2628         * buildsym-legacy.c: Sort headers.
2629         * build-id.h: Sort headers.
2630         * build-id.c: Sort headers.
2631         * btrace.c: Sort headers.
2632         * bsd-uthread.c: Sort headers.
2633         * breakpoint.h: Sort headers.
2634         * breakpoint.c: Sort headers.
2635         * break-catch-throw.c: Sort headers.
2636         * break-catch-syscall.c: Sort headers.
2637         * break-catch-sig.c: Sort headers.
2638         * blockframe.c: Sort headers.
2639         * block.c: Sort headers.
2640         * bfin-tdep.c: Sort headers.
2641         * bfin-linux-tdep.c: Sort headers.
2642         * bfd-target.c: Sort headers.
2643         * bcache.c: Sort headers.
2644         * ax-general.c: Sort headers.
2645         * ax-gdb.h: Sort headers.
2646         * ax-gdb.c: Sort headers.
2647         * avr-tdep.c: Sort headers.
2648         * auxv.c: Sort headers.
2649         * auto-load.c: Sort headers.
2650         * arm-wince-tdep.c: Sort headers.
2651         * arm-tdep.c: Sort headers.
2652         * arm-symbian-tdep.c: Sort headers.
2653         * arm-pikeos-tdep.c: Sort headers.
2654         * arm-obsd-tdep.c: Sort headers.
2655         * arm-nbsd-tdep.c: Sort headers.
2656         * arm-nbsd-nat.c: Sort headers.
2657         * arm-linux-tdep.c: Sort headers.
2658         * arm-linux-nat.c: Sort headers.
2659         * arm-fbsd-tdep.c: Sort headers.
2660         * arm-fbsd-nat.c: Sort headers.
2661         * arm-bsd-tdep.c: Sort headers.
2662         * arch-utils.c: Sort headers.
2663         * arc-tdep.c: Sort headers.
2664         * arc-newlib-tdep.c: Sort headers.
2665         * annotate.h: Sort headers.
2666         * annotate.c: Sort headers.
2667         * amd64-windows-tdep.c: Sort headers.
2668         * amd64-windows-nat.c: Sort headers.
2669         * amd64-tdep.c: Sort headers.
2670         * amd64-sol2-tdep.c: Sort headers.
2671         * amd64-obsd-tdep.c: Sort headers.
2672         * amd64-obsd-nat.c: Sort headers.
2673         * amd64-nbsd-tdep.c: Sort headers.
2674         * amd64-nbsd-nat.c: Sort headers.
2675         * amd64-nat.c: Sort headers.
2676         * amd64-linux-tdep.c: Sort headers.
2677         * amd64-linux-nat.c: Sort headers.
2678         * amd64-fbsd-tdep.c: Sort headers.
2679         * amd64-fbsd-nat.c: Sort headers.
2680         * amd64-dicos-tdep.c: Sort headers.
2681         * amd64-darwin-tdep.c: Sort headers.
2682         * amd64-bsd-nat.c: Sort headers.
2683         * alpha-tdep.c: Sort headers.
2684         * alpha-obsd-tdep.c: Sort headers.
2685         * alpha-nbsd-tdep.c: Sort headers.
2686         * alpha-mdebug-tdep.c: Sort headers.
2687         * alpha-linux-tdep.c: Sort headers.
2688         * alpha-linux-nat.c: Sort headers.
2689         * alpha-bsd-tdep.c: Sort headers.
2690         * alpha-bsd-nat.c: Sort headers.
2691         * aix-thread.c: Sort headers.
2692         * agent.c: Sort headers.
2693         * addrmap.c: Sort headers.
2694         * ada-varobj.c: Sort headers.
2695         * ada-valprint.c: Sort headers.
2696         * ada-typeprint.c: Sort headers.
2697         * ada-tasks.c: Sort headers.
2698         * ada-lang.c: Sort headers.
2699         * aarch64-tdep.c: Sort headers.
2700         * aarch64-ravenscar-thread.c: Sort headers.
2701         * aarch64-newlib-tdep.c: Sort headers.
2702         * aarch64-linux-tdep.c: Sort headers.
2703         * aarch64-linux-nat.c: Sort headers.
2704         * aarch64-fbsd-tdep.c: Sort headers.
2705         * aarch64-fbsd-nat.c: Sort headers.
2706         * aarch32-linux-nat.c: Sort headers.
2707
2708 2019-04-04  Tom Tromey  <tom@tromey.com>
2709
2710         * varobj.c (varobj_create): Update.
2711         * rust-exp.y (struct rust_parser) <update_innermost_block,
2712         lookup_symbol>: New methods.
2713         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2714         Rename.
2715         (rust_parser::rust_lookup_type)
2716         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2717         * printcmd.c (display_command, do_one_display): Update.
2718         * parser-defs.h (struct parser_state) <parser_state>: Add
2719         "tracker" parameter.
2720         (block_tracker): New member.
2721         (class innermost_block_tracker) <innermost_block_tracker>: Add
2722         "types" parameter.
2723         <reset>: Remove method.
2724         (innermost_block): Don't declare.
2725         (null_post_parser): Update.
2726         * parse.c (innermost_block): Remove global.
2727         (write_dollar_variable): Update.
2728         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2729         Remove "tracker_types" parameter.
2730         (parse_expression): Add "tracker" parameter.
2731         (parse_expression_for_completion): Update.
2732         (null_post_parser): Add "tracker" parameter.
2733         * p-exp.y: Update rules.
2734         * m2-exp.y: Update rules.
2735         * language.h (struct language_defn) <la_post_parser>: Add
2736         "tracker" parameter.
2737         * go-exp.y: Update rules.
2738         * f-exp.y: Update rules.
2739         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2740         parameter.
2741         * d-exp.y: Update rules.
2742         * c-exp.y: Update rules.
2743         * breakpoint.c (set_breakpoint_condition): Create an
2744         innermost_block_tracker.
2745         (watch_command_1): Likewise.
2746         * ada-lang.c (resolve): Add "tracker" parameter.
2747         (resolve_subexp): Likewise.
2748         * ada-exp.y (write_var_from_sym): Update.
2749
2750 2019-04-04  Tom Tromey  <tom@tromey.com>
2751
2752         * type-stack.h: New file.
2753         * type-stack.c: New file.
2754         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2755         type-stack.h.
2756         (insert_into_type_stack, insert_type, push_type, push_type_int)
2757         (insert_type_address_space, pop_type, pop_type_int)
2758         (pop_typelist, pop_type_stack, append_type_stack)
2759         (push_type_stack, get_type_stack, push_typelist)
2760         (follow_type_instance_flags, follow_types): Don't declare.
2761         * parse.c (type_stack): Remove global.
2762         (parse_exp_in_context): Update.
2763         (insert_into_type_stack, insert_type, push_type, push_type_int)
2764         (insert_type_address_space, pop_type, pop_type_int)
2765         (pop_typelist, pop_type_stack, append_type_stack)
2766         (push_type_stack, get_type_stack, push_typelist)
2767         (follow_type_instance_flags, follow_types): Remove (moved to
2768         type-stack.c).
2769         * f-exp.y (type_stack): New global.
2770         Update rules.
2771         (push_kind_type, f_parse): Update.
2772         * d-exp.y (type_stack): New global.
2773         Update rules.
2774         (d_parse): Update.
2775         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2776         Update rules.
2777         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2778         (HFILES_NO_SRCDIR): Add type-stack.h.
2779
2780 2019-04-04  Tom Tromey  <tom@tromey.com>
2781
2782         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2783         (rust_parser::convert_ast_to_expression, rust_parse)
2784         (rust_lex_test_completion, rust_lex_tests): Update.
2785         * parser-defs.h (struct expr_completion_state): New.
2786         (struct parser_state) <parser_state>: Add completion parameter.
2787         <mark_struct_expression, mark_completion_tag>: New methods.
2788         <parse_completion, m_completion_state>: New members.
2789         (prefixify_expression, null_post_parser): Update.
2790         (mark_struct_expression, mark_completion_tag): Don't declare.
2791         * parse.c (parse_completion, expout_last_struct)
2792         (expout_tag_completion_type, expout_completion_name): Remove
2793         globals.
2794         (parser_state::mark_struct_expression)
2795         (parser_state::mark_completion_tag): Now methods.
2796         (prefixify_expression): Add last_struct parameter.
2797         (prefixify_subexp): Likewise.
2798         (parse_exp_1): Update.
2799         (parse_exp_in_context): Add cstate parameter.  Update.
2800         (parse_expression_for_completion): Create an
2801         expr_completion_state.
2802         (null_post_parser): Add "completion" parameter.
2803         * p-exp.y: Update rules.
2804         (yylex): Update.
2805         * language.h (struct language_defn) <la_post_parser>: Add
2806         "completing" parameter.
2807         * go-exp.y: Update rules.
2808         (lex_one_token): Update.
2809         * expression.h (parse_completion): Don't declare.
2810         * d-exp.y: Update rules.
2811         (lex_one_token): Update rules.
2812         * c-exp.y: Update rules.
2813         (lex_one_token): Update.
2814         * ada-lang.c (resolve): Add "parse_completion" parameter.
2815         (resolve_subexp): Likewise.
2816         (ada_resolve_function): Likewise.
2817
2818 2019-04-04  Tom Tromey  <tom@tromey.com>
2819
2820         * parser-defs.h (struct parser_state) <start_arglist,
2821         end_arglist>: New methods.
2822         <arglist_len, m_funcall_chain>: New members.
2823         (arglist_len, start_arglist, end_arglist): Don't declare.
2824         * parse.c (arglist_len, funcall_chain): Remove global.
2825         (start_arglist, end_arglist): Remove functions.
2826         (parse_exp_in_context): Update.
2827         * p-exp.y: Update rules.
2828         * m2-exp.y: Update rules.
2829         * go-exp.y: Update rules.
2830         * f-exp.y: Update rules.
2831         * d-exp.y: Update rules.
2832         * c-exp.y: Update rules.
2833
2834 2019-04-04  Tom Tromey  <tom@tromey.com>
2835
2836         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2837         lex_operator, push_back>: New methods.
2838         Update all rules.
2839         (rust_parser::lex_hex, lex_escape): Rename and update.
2840         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2841         (rust_parser::lex_operator): Rename and update.
2842         (rust_parser::lex_number, rustyylex, rustyyerror)
2843         (rust_lex_test_init, rust_lex_test_sequence)
2844         (rust_lex_test_push_back, rust_lex_tests): Update.
2845         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2846         parameter.
2847         <lexptr, prev_lexptr>: New members.
2848         (lexptr, prev_lexptr): Don't declare.
2849         * parse.c (lexptr, prev_lexptr): Remove globals.
2850         (parse_exp_in_context): Update.
2851         * p-exp.y (yylex, yyerror): Update.
2852         * m2-exp.y (parse_number, yylex, yyerror): Update.
2853         * go-exp.y (lex_one_token, yyerror): Update.
2854         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2855         * d-exp.y (lex_one_token, yyerror): Update.
2856         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2857         (lex_one_token, yyerror): Update.
2858         * ada-lex.l (YY_INPUT): Update.
2859         (rewind_to_char): Update.
2860         * ada-exp.y (yyerror): Update.
2861
2862 2019-04-04  Tom Tromey  <tom@tromey.com>
2863
2864         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2865         * parser-defs.h (struct parser_state) <parser_state>: Add new
2866         parameter.
2867         <comma_terminates>: New member.
2868         (comma_terminates): Don't declare global.
2869         * parse.c (comma_terminates): Remove global.
2870         (parse_exp_in_context): Update.
2871         * p-exp.y (yylex): Update.
2872         * m2-exp.y (yylex): Update.
2873         * go-exp.y (lex_one_token): Update.
2874         * f-exp.y (yylex): Update.
2875         * d-exp.y (lex_one_token): Update.
2876         * c-exp.y (lex_one_token): Update.
2877         * ada-lex.l: Update.
2878
2879 2019-04-04  Tom Tromey  <tom@tromey.com>
2880
2881         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2882         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2883         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2884         * parser-defs.h (paren_depth): Don't declare.
2885         * parse.c (paren_depth): Remove global.
2886         (parse_exp_in_context): Update.
2887         * p-exp.y (paren_depth): New global.
2888         (pascal_parse): Initialize it.
2889         * m2-exp.y (paren_depth): New global.
2890         (m2_parse): Initialize it.
2891         * go-exp.y (paren_depth): New global.
2892         (go_parse): Initialize it.
2893         * f-exp.y (paren_depth): New global.
2894         (f_parse): Initialize it.
2895         * d-exp.y (paren_depth): New global.
2896         (d_parse): Initialize it.
2897         * c-exp.y (paren_depth): New global.
2898         (c_parse): Initialize it.
2899         * ada-lex.l (paren_depth): New global.
2900         (lexer_init): Initialize it.
2901
2902 2019-04-04  Tom Tromey  <tom@tromey.com>
2903
2904         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2905         (rust_parser::convert_ast_to_type)
2906         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2907         * parser-defs.h (struct parser_state) <parser_state>: Add
2908         parameters.  Initialize new members.
2909         <expression_context_block, expression_context_pc>: New members.
2910         * parse.c (expression_context_block, expression_context_pc):
2911         Remove globals.
2912         (parse_exp_in_context): Update.
2913         * p-exp.y: Update all rules.
2914         (yylex): Update.
2915         * m2-exp.y: Update all rules.
2916         (yylex): Update.
2917         * go-exp.y (yylex): Update.
2918         * f-exp.y (yylex): Update.
2919         * d-exp.y: Update all rules.
2920         (yylex): Update.
2921         * c-exp.y: Update all rules.
2922         (lex_one_token, classify_name, yylex, c_parse): Update.
2923         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2924
2925 2019-04-04  Tom Tromey  <tom@tromey.com>
2926
2927         * gdbarch.h, gdbarch.c: Rebuild.
2928         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2929         * stap-probe.h:
2930         (struct stap_parse_info): Replace "parser_state" with
2931         "expr_builder".
2932         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2933         (parser_state): New class.
2934         * parse.c (expr_builder): Rename.
2935         (expr_builder::release): Rename.
2936         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2937         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2938         (write_exp_elt_longcst, write_exp_elt_floatcst)
2939         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2940         (write_exp_string_vector, write_exp_bitstring)
2941         (write_exp_msymbol, mark_struct_expression)
2942         (write_dollar_variable)
2943         (insert_type_address_space, increase_expout_size): Replace
2944         "parser_state" with "expr_builder".
2945         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2946         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2947         "parser_state" with "expr_builder".
2948
2949 2019-04-04  Tom Tromey  <tom@tromey.com>
2950
2951         * rust-exp.y: Replace "parse_language" with method call.
2952         * p-exp.y:
2953         (yylex): Replace "parse_language" with method call.
2954         * m2-exp.y:
2955         (yylex): Replace "parse_language" with method call.
2956         * go-exp.y (classify_name): Replace "parse_language" with method
2957         call.
2958         * f-exp.y (yylex): Replace "parse_language" with method call.
2959         * d-exp.y (lex_one_token): Replace "parse_language" with method
2960         call.
2961         * c-exp.y:
2962         (lex_one_token, classify_name, yylex): Replace "parse_language"
2963         with method call.
2964         * ada-exp.y (find_primitive_type, type_char)
2965         (type_system_address): Replace "parse_language" with method call.
2966
2967 2019-04-04  Tom Tromey  <tom@tromey.com>
2968
2969         * rust-exp.y: Replace "parse_gdbarch" with method call.
2970         * parse.c (write_dollar_variable, insert_type_address_space):
2971         Replace "parse_gdbarch" with method call.
2972         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2973         call.
2974         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2975         call.
2976         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2977         "parse_gdbarch" with method call.
2978         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2979         with method call.
2980         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2981         "parse_gdbarch" with method call.
2982         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2983         "parse_gdbarch" with method call.
2984         * c-exp.y (parse_type, parse_number, classify_name): Replace
2985         "parse_gdbarch" with method call.
2986         * ada-lex.l: Replace "parse_gdbarch" with method call.
2987         * ada-exp.y (parse_type, find_primitive_type, type_char)
2988         (type_system_address): Replace "parse_gdbarch" with method call.
2989
2990 2019-04-04  Tom Tromey  <tom@tromey.com>
2991
2992         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2993         * stap-probe.c (stap_parse_argument): Update.
2994         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2995         initial_size parameter.
2996         * rust-exp.y (rust_lex_tests): Update.
2997         * parse.c (parser_state): Update.
2998         (parse_exp_in_context): Update.
2999         * parser-defs.h (struct parser_state) <parser_state>: Remove
3000         "initial_size" parameter.
3001
3002 2019-04-04  Tom Tromey  <tom@tromey.com>
3003
3004         * parser-defs.h (increase_expout_size): Don't declare.
3005         * parse.c (increase_expout_size): Now static.
3006
3007 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3008
3009         * gnu-nat.c (gnu_nat_target::wait): Fix
3010         target_waitstatus_to_string call.
3011
3012 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * eval.c (evaluate_subexp_standard): Handle internal functions
3015         during Fortran function call handling.
3016
3017 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3018
3019         * NEWS: Mention new internal functions.
3020         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3021         (read_base_type): Use dwarf2_init_complex_target_type.
3022         * value.c (creal_internal_fn): New function.
3023         (cimag_internal_fn): New function.
3024         (_initialize_values): Register new internal functions.
3025
3026 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3027
3028         * infrun.c (stop_all_threads): If debug_infrun, always
3029         trace the wait status after wait_one, using
3030         target_waitstatus_to_string and target_pid_to_str.
3031         (handle_inferior_event): Replace various trace of
3032         wait status kind by a single trace.
3033         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3034         wait status kind image by target_waitstatus_to_string.
3035         * target/waitstatus.c (target_waitstatus_to_string): Fix
3036         obsolete comment.
3037
3038 2019-04-01  Tom Tromey  <tromey@adacore.com>
3039
3040         PR symtab/23331:
3041         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3042
3043 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3044             Pedro Alves  <palves@redhat.com>
3045
3046         * top.c (quit_force): Call 'finalize_values'.
3047         * value.c (finalize_values): New function.
3048         * value.h (finalize_values): Declare.
3049
3050 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3051
3052         * NEWS: Announce $_gdb_major and $_gdb_minor.
3053
3054         * top.c (init_gdb_version_vars): New function.
3055         (gdb_init): Call init_gdb_version_vars.
3056
3057 2019-03-29  Tom Tromey  <tromey@adacore.com>
3058
3059         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3060         help text.  Remove dead code.
3061
3062 2019-03-29  Keith Seitz  <keiths@redhat.com>
3063
3064         From Siddhesh Poyarekar:
3065         * f-lang.h (f77_get_upperbound): Return LONGEST.
3066         (f77_get_lowerbound): Likewise.
3067         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3068         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3069         print them.
3070         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3071         plongest to format print it.
3072         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3073         (f77_get_upperbound): Likewise.
3074         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3075         LOWER_BOUND to LONGEST.
3076         (f77_create_arrayprint_offset_tbl): Likewise.
3077
3078 2019-03-29  Keith Seitz  <keiths@redhat.com>
3079
3080         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3081         %s/pulongest for TYPE_LENGTH instead of %d in format
3082         strings.
3083         * ada-typerint.c (ada_print_type): Likewise.
3084         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3085         * compile/compile-c-support.c (generate_register_struct): Likewise.
3086         * gdbtypes.c (recursive_dump_type): Likewise.
3087         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3088         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3089         instead of %d in format strings.
3090         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3091         to std::min to ULONGEST.
3092         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3093         instead of %d in format strings.
3094         * tracepoint.c (info_scope_command): Likewise.
3095         * typeprint.c (print_offset_data::update)
3096         (print_offset_data::finish): Likewise.
3097         * xtensa-tdep.c (xtensa_store_return_value)
3098         (xtensa_push_dummy_call): Likewise.
3099
3100 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3101
3102         * windows-nat.c (display_selector): Fixed format specifications
3103         for 64-bit Cygwin.
3104
3105 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3106
3107         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3108
3109 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3110
3111         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3112         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3113         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3114         (nios2_linux_init_abi): Install it.
3115
3116 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3117
3118         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3119
3120 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3121
3122         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3123
3124 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3125             Tom Tromey  <tromey@adacore.com>
3126
3127         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3128
3129 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3130
3131         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3132         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3133         method to compute the bounds of range types. Also print "[evaluated]"
3134         if the bounds' values come from a dynamic evaluation.
3135
3136 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3139         whitespace when pretty printing is on.
3140
3141 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3142
3143         * ppc-linux-nat.c: Add include.
3144
3145 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3146
3147         * NEWS: Mention AArch64 Pointer Authentication.
3148
3149 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3150
3151         * arm-linux-nat.c: Add include.
3152
3153 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3154
3155         * source-cache.c (source_cache::get_source_lines): Re-read
3156         fullname after calling open_source_file.
3157
3158 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3159
3160         * NEWS: Mention TLS support for FreeBSD.
3161
3162 2019-03-25  Tom Tromey  <tromey@adacore.com>
3163
3164         * minsyms.c (BUNCH_SIZE): Update comment.
3165         (~minimal_symbol_reader): Remove old comment.
3166         (compact_minimal_symbols): Update comment.
3167         (minimal_symbol_reader::install): Remove old comment.  Update
3168         other comments.
3169
3170 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3171
3172         * s390-linux-nat.c: Add include.
3173
3174 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3175
3176         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3177         Call linux_get_hwcap.
3178         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3179         Likewise.
3180         (aarch64_linux_get_hwcap): Remove function.
3181         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3182         declaration.
3183         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3184         linux_get_hwcap.
3185         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3186         * linux-tdep.c (linux_get_hwcap): Add function.
3187         (linux_get_hwcap2): Likewise.
3188         * linux-tdep.h (linux_get_hwcap): Add declaration.
3189         (linux_get_hwcap2): Likewise.
3190         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3191         (ppc_linux_get_hwcap2): Likewise.
3192         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3193         linux_get_hwcap.
3194         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3195         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3196         (ppc_linux_nat_target::read_description): Likewise.
3197         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3198         * s390-linux-nat.c: Likewise.
3199         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3200
3201 2019-03-24  Tom Tromey  <tom@tromey.com>
3202
3203         * ada-lang.c (standard_lookup): Simplify initialization.
3204         (ada_lookup_symbol_nonlocal): Simplify return.
3205         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3206         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3207         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3208         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3209         initialization.
3210         * solib.c (solib_global_lookup): Simplify.
3211         * symtab.c (null_block_symbol): Remove.
3212         (symbol_cache_lookup): Simplify returns.
3213         (lookup_language_this): Simplify returns.
3214         (lookup_symbol_aux): Simplify return.
3215         (lookup_local_symbol): Simplify returns.
3216         (lookup_global_symbol_from_objfile): Simplify return.
3217         (lookup_symbol_in_objfile_symtabs)
3218         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3219         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3220         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3221         * cp-namespace.c (cp_lookup_bare_symbol)
3222         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3223         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3224         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3225         (cp_lookup_symbol_via_imports): Simplify initialization.
3226         (find_symbol_in_baseclass): Likewise.
3227         * symtab.h (null_block_symbol): Remove.
3228         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3229         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3230         (d_lookup_symbol_module): Likewise.
3231         (find_symbol_in_baseclass): Simplify initialization.
3232
3233 2019-03-24  Tom Tromey  <tom@tromey.com>
3234
3235         * expression.h: Don't include symtab.h.
3236         (struct block): Forward declare.
3237
3238 2019-03-24  Tom Tromey  <tom@tromey.com>
3239
3240         * c-exp.y (typebase): Remove casts.
3241         * gdbtypes.c (lookup_unsigned_typename, )
3242         (lookup_signed_typename): Remove cast.
3243         * eval.c (parse_to_comma_and_eval): Remove cast.
3244         * parse.c (write_dollar_variable): Remove cast.
3245         * block.h (struct block) <superblock>: Now const.
3246         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3247         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3248         (map_block): Make "block" const.
3249         * symfile.h (struct quick_symbol_functions)
3250         <map_matching_symbols>: Constify block argument to "callback".
3251         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3252         const.
3253         (find_pc_sect_compunit_symtab): Make "b" const.
3254         (find_symbol_at_address): Likewise.
3255         (search_symbols): Likewise.
3256         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3257         (dw2_debug_names_lookup_symbol): Likewise.
3258         (dw2_map_matching_symbols): Update.
3259         * p-valprint.c (pascal_val_print): Remove "block".
3260         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3261         (aux_add_nonlocal_symbols): Make "block" const.
3262         (resolve_subexp): Remove cast.
3263         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3264         const.
3265         (iterate_over_file_blocks): Likewise.
3266         * f-exp.y (%union) <bval>: Remove.
3267         * coffread.c (patch_opaque_types): Make "b" const.
3268         * spu-tdep.c (spu_catch_start): Make "block" const.
3269         * c-valprint.c (print_unpacked_pointer): Remove "block".
3270         * symmisc.c (dump_symtab_1): Make "b" const.
3271         (block_depth): Make "block" const.
3272         * d-exp.y (%union) <bval>: Remove.
3273         * cp-support.h (cp_lookup_rtti_type): Update.
3274         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3275         * psymtab.c (psym_lookup_symbol): Make "block" const.
3276         (maintenance_check_psymtabs): Make "b" const.
3277         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3278         (enumerate_locals, enumerate_args): Update.
3279         * python/py-symtab.c (stpy_global_block): Make "block" const.
3280         (stpy_static_block): Likewise.
3281         * inline-frame.c (block_starting_point_at): Make "new_block"
3282         const.
3283         * block.c (find_block_in_blockvector): Make return type const.
3284         (blockvector_for_pc_sect): Make "b" const.
3285         (find_block_in_blockvector): Make "b" const.
3286
3287 2019-03-23  Tom Tromey  <tom@tromey.com>
3288
3289         * varobj.c (varobj_create): Update.
3290         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3291         * printcmd.c (display_command, do_one_display): Don't reset
3292         innermost_block.
3293         * parser-defs.h (enum innermost_block_tracker_type): Move to
3294         expression.h.
3295         (innermost_block): Update comment.
3296         * parse.c (parse_exp_1): Add tracker_types parameter.
3297         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3298         tracker_types parameter.  Reset innermost_block.
3299         (parse_exp_in_context): Remove.
3300         (parse_expression_for_completion): Update.
3301         * objfiles.c (~objfile): Don't reset expression_context_block or
3302         innermost_block.
3303         * expression.h (enum innermost_block_tracker_type): Move from
3304         parser-defs.h.
3305         (parse_exp_1): Add tracker_types parameter.
3306         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3307         reset innermost_block.
3308
3309 2019-03-23  Tom Tromey  <tom@tromey.com>
3310
3311         * objfiles.h: Include bcache.h.
3312
3313 2019-03-23  Tom Tromey  <tom@tromey.com>
3314
3315         * linespec.c (get_current_search_block): Use
3316         scoped_restore_current_language.
3317         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3318
3319 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3320             Jiong Wang  <jiong.wang@arm.com>
3321
3322         * aarch64-linux-tdep.c
3323         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3324         section.
3325         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3326
3327 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3328             Jiong Wang  <jiong.wang@arm.com>
3329
3330         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3331         instructions.
3332         (aarch64_analyze_prologue_test): Add PACIASP test.
3333         (aarch64_prologue_prev_register): Unmask PC value.
3334
3335 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3336             Jiong Wang  <jiong.wang@arm.com>
3337
3338         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3339         (aarch64_dwarf2_prev_register): Unmask PC value.
3340         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3341         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3342         DW_CFA_AARCH64_negate_ra_state.
3343         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3344
3345 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3346             Jiong Wang  <jiong.wang@arm.com>
3347
3348         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3349         registers.
3350         (aarch64_pseudo_register_name): Likewise.
3351         (aarch64_pseudo_register_type): Likewise.
3352         (aarch64_pseudo_register_reggroup_p): Likewise.
3353         (aarch64_gdbarch_init): Add pauth registers.
3354         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3355         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3356         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3357         (struct gdbarch_tdep): Add regnum for ra_state.
3358
3359 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3360             Jiong Wang  <jiong.wang@arm.com>
3361
3362         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3363
3364 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3365             Jiong Wang  <jiong.wang@arm.com>
3366
3367         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3368         function.
3369         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3370         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3371         (aarch64_gdbarch_init): Add puth registers.
3372         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3373         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3374         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3375
3376 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3377             Jiong Wang  <jiong.wang@arm.com>
3378
3379         * aarch64-linux-nat.c
3380         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3381         * aarch64-linux-tdep.c
3382         (aarch64_linux_core_read_description): Likewise.
3383         (aarch64_linux_get_hwcap): New function.
3384         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3385         (aarch64_linux_get_hwcap): New declaration.
3386
3387 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3388             Jiong Wang  <jiong.wang@arm.com>
3389
3390         * aarch64-linux-nat.c
3391         (aarch64_linux_nat_target::read_description): Add pauth param.
3392         * aarch64-linux-tdep.c
3393         (aarch64_linux_core_read_description): Likewise.
3394         * aarch64-tdep.c (struct target_desc): Add in pauth.
3395         (aarch64_read_description): Add pauth param.
3396         (aarch64_gdbarch_init): Likewise.
3397         * aarch64-tdep.h (aarch64_read_description): Likewise.
3398         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3399         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3400         * features/Makefile: Add new files.
3401         * features/aarch64-pauth.c: New file.
3402         * features/aarch64-pauth.xml: New file.
3403
3404 2019-03-20  Tom Tromey  <tromey@adacore.com>
3405
3406         * infrun.c (handle_inferior_event): Rename from
3407         handle_inferior_event_1.  Create a scoped_value_mark.
3408         (handle_inferior_event): Remove.
3409
3410 2019-03-19  Tom Tromey  <tromey@adacore.com>
3411
3412         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3413         * infrun.h (print_stop_event): Add "displays" parameter.
3414         * infrun.c (print_stop_event): Add "displays" parameter.
3415
3416 2019-03-19  Pedro Alves  <palves@redhat.com>
3417
3418         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3419         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3420         to -1.  Fix TABs vs spaces.
3421         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3422         * tui/tui-out.h (tui_ui_out) Add intro comments.
3423         <m_line, m_start_of_line>: In-class initialize, and add describing
3424         comment.
3425
3426 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3427
3428         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3429         variable names.
3430         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3431
3432 2019-03-18  Pedro Alves  <palves@redhat.com>
3433             Eli Zaretskii <eliz@gnu.org>
3434
3435         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3436         m_line and m_start_of_line.
3437
3438 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3439
3440         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3441         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3442         it returns a newline.  This fixes a regression in TU mode, whereby
3443         the next line is output on the same screen line as the user input.
3444
3445 2019-03-18  Tom Tromey  <tromey@adacore.com>
3446
3447         * minsyms.c (minimal_symbol_reader::install): Remove call to
3448         obstack_blank.
3449
3450 2019-03-18  Pedro Alves  <palves@redhat.com>
3451
3452         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3453         New globals.
3454         (apply_style): New, factored out from ...
3455         (apply_ansi_escape): ... this.  Handle reverse video mode.
3456         (tui_set_reverse_mode): New function.
3457         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3458         * tui/tui-winsource.c (tui_show_source_line): Use
3459         tui_set_reverse_mode instead of setting A_STANDOUT.
3460         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3461         New setter methods.
3462
3463 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3464
3465         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3466         Handle tabs.
3467
3468 2019-03-18  Tom Tromey  <tromey@adacore.com>
3469
3470         * ada-lang.c (empty_array): Add "high" parameter.
3471         (ada_evaluate_subexp): Update.
3472
3473 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3474
3475         * unittests/string_view-selftests.c: Define
3476         _initialize_string_view_selftests unconditionally.
3477
3478 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3479
3480         PR gdb/24350
3481         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3482
3483 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3484
3485         PR gdb/24351
3486         * windows-nat.c (display_selector): Fix format specifiers.
3487
3488 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3489
3490         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3491         tui_refill_source_window instead of tui_refresh_win, to update the
3492         current execution line.  This fixes redisplay of the current line
3493         when stepping through the code with "next" or "step".
3494
3495 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3496
3497         * source-cache.c (source_cache::get_source_lines): Call
3498         find_source_lines to initialize s->nlines.  This fixes vertical
3499         scrolling of TUI source window when the DOWN arrow is pressed.
3500
3501 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3502
3503         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3504         linux-thread-db.c (_initialize_thread_db): Likewise.
3505
3506 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3507
3508         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3509         wclrtoeol in tui_show_source_line".  This reverts changes made in
3510         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3511
3512 2019-03-15  Tom Tromey  <tom@tromey.com>
3513
3514         * symtab.h (struct minimal_symbol): Derive from
3515         general_symbol_info.
3516         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3517         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3518         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3519         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3520         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3521         (MSYMBOL_SEARCH_NAME): Update.
3522         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3523         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3524         * minsyms.c (minimal_symbol_reader::record_full): Update.
3525
3526 2019-03-15  Tom Tromey  <tom@tromey.com>
3527
3528         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3529
3530 2019-03-15  Tom Tromey  <tom@tromey.com>
3531
3532         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3533         unique_xmalloc_ptr.
3534         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3535         Update.
3536         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3537         (build_minimal_symbol_hash_tables)
3538         (minimal_symbol_reader::install): Update.
3539
3540 2019-03-15  Tom Tromey  <tom@tromey.com>
3541
3542         * symtab.c (create_demangled_names_hash): Update.
3543         (symbol_set_names): Update.
3544         * objfiles.h (struct objfile_per_bfd_storage)
3545         <demangled_names_hash>: Now an htab_up.
3546         * objfiles.c (objfile_per_bfd_storage): Simplify.
3547
3548 2019-03-15  Tom Tromey  <tom@tromey.com>
3549
3550         * objfiles.h (struct objfile_per_bfd_storage): Declare
3551         destructor.
3552         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3553         New.
3554         (get_objfile_bfd_data): Use new.  Don't initialize
3555         language_of_main.
3556         (free_objfile_per_bfd_storage): Remove.
3557         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3558
3559 2019-03-15  Tom Tromey  <tom@tromey.com>
3560
3561         * symfile.c (reread_symbols): Update.
3562         * objfiles.c (objfile::objfile): Update.
3563         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3564         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3565         comment.
3566         (minimal_symbol_reader::install): Update.
3567         (terminate_minimal_symbol_table): Remove.
3568         * jit.c (jit_object_close_impl): Update.
3569
3570 2019-03-15  Tom Tromey  <tom@tromey.com>
3571
3572         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3573         initializations.
3574
3575 2019-03-15  Tom Tromey  <tom@tromey.com>
3576
3577         * objfiles.h (struct objfile_per_bfd_storage)
3578         <demangled_hash_languages>: Now a bitset.
3579         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3580         (lookup_minimal_symbol): Update.
3581
3582 2019-03-15  Tom Tromey  <tom@tromey.com>
3583
3584         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3585         Don't return the symbol.
3586         * coffread.c (record_minimal_symbol): Use record_full.
3587
3588 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3589
3590         The MS-Windows port of ncurses fails to switch to a color pair if
3591         one or both of the colors are the implicit default colors.  This
3592         change records the default colors when TUI is initialized, and
3593         then specifies them explicitly when a color pair uses the default
3594         colors.  This allows color styling in TUI mode on MS-Windows.
3595
3596         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3597         ncurses_norm_attr.
3598         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3599         colors in ncurses_norm_attr.
3600         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3601         "none", replace it with the default color recorded in
3602         ncurses_norm_attr.
3603
3604 2019-03-14  Tom Tromey  <tromey@adacore.com>
3605
3606         * source-cache.h (class source_cache) <get_source_lines>: Return
3607         std::string.
3608         * source-cache.c (source_cache::extract_lines): Handle case where
3609         first_pos==npos.  Return std::string.
3610         (source_cache::get_source_lines): Update.
3611
3612 2019-03-14  Tom Tromey  <tromey@adacore.com>
3613
3614         * NEWS: Add item for "style sources" commands.
3615         * source-cache.c (source_cache::get_source_lines): Check
3616         source_styling.
3617         * cli/cli-style.c (source_styling): New global.
3618         (_initialize_cli_style): Add "style sources" commands.
3619         (show_style_sources): New function.
3620         * cli/cli-style.h (source_styling): Declare.
3621
3622 2019-03-14  Pedro Alves  <palves@redhat.com>
3623             Tom Tromey  <tromey@adacore.com>
3624
3625         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3626         * tui/tui-winsource.c (tui_refill_source_window): New function,
3627         from...
3628         (tui_horizontal_source_scroll): ... here.  Move some logic.
3629         * cli/cli-style.c (set_style_enabled): Notify new observable.
3630         * tui/tui-hooks.c (tui_redisplay_source): New function.
3631         (tui_attach_detach_observers): Attach or detach
3632         tui_redisplay_source.
3633         * observable.h (source_styling_changed): New observable.
3634         * observable.c: Define source_styling_changed observable.
3635
3636 2019-03-13  Tom Tromey  <tromey@adacore.com>
3637
3638         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3639         (i386_gnu_nat_target::store_registers): Update.
3640         * target-debug.h (target_debug_print_std_string): New macro.
3641         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3642         * windows-tdep.c (display_one_tib): Update.
3643         * tui/tui-stack.c (tui_make_status_line): Update.
3644         * top.c (print_inferior_quit_action): Update.
3645         * thread.c (thr_try_catch_cmd): Update.
3646         (add_thread_with_info): Update.
3647         (thread_target_id_str): Update.
3648         (thr_try_catch_cmd): Update.
3649         (thread_command): Update.
3650         (thread_find_command): Update.
3651         * record-btrace.c (record_btrace_target::info_record)
3652         (record_btrace_resume_thread, record_btrace_target::resume)
3653         (record_btrace_cancel_resume, record_btrace_step_thread)
3654         (record_btrace_target::wait, record_btrace_target::wait)
3655         (record_btrace_target::wait, record_btrace_target::stop): Update.
3656         * progspace.c (print_program_space): Update.
3657         * process-stratum-target.c
3658         (process_stratum_target::thread_address_space): Update.
3659         * linux-fork.c (linux_fork_mourn_inferior)
3660         (detach_checkpoint_command, info_checkpoints_command)
3661         (linux_fork_context): Update.
3662         (linux_fork_detach): Update.
3663         (class scoped_switch_fork_info): Update.
3664         (delete_checkpoint_command): Update.
3665         * infrun.c (follow_fork_inferior): Update.
3666         (follow_fork_inferior): Update.
3667         (proceed_after_vfork_done): Update.
3668         (handle_vfork_child_exec_or_exit): Update.
3669         (follow_exec): Update.
3670         (displaced_step_prepare_throw): Update.
3671         (displaced_step_restore): Update.
3672         (start_step_over): Update.
3673         (resume_1): Update.
3674         (clear_proceed_status_thread): Update.
3675         (proceed): Update.
3676         (print_target_wait_results): Update.
3677         (do_target_wait): Update.
3678         (context_switch): Update.
3679         (stop_all_threads): Update.
3680         (restart_threads): Update.
3681         (finish_step_over): Update.
3682         (handle_signal_stop): Update.
3683         (switch_back_to_stepped_thread): Update.
3684         (keep_going_pass_signal): Update.
3685         (print_exited_reason): Update.
3686         (normal_stop): Update.
3687         * inferior.c (inferior_pid_to_str): Change return type.
3688         (print_selected_inferior): Update.
3689         (add_inferior): Update.
3690         (detach_inferior): Update.
3691         * dummy-frame.c (fprint_dummy_frames): Update.
3692         * dcache.c (dcache_info_1): Update.
3693         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3694         (btrace_fetch, btrace_clear): Update.
3695         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3696         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3697         type.
3698         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3699         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3700         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3701         * gdbarch.c, gdbarch.h: Rebuild.
3702         * gdbarch.sh (core_pid_to_str): Change return type.
3703         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3704         return type.
3705         (windows_nat_target::pid_to_str): Change return type.
3706         (windows_delete_thread): Update.
3707         (windows_nat_target::attach): Update.
3708         (windows_nat_target::files_info): Update.
3709         * target-delegates.c: Rebuild.
3710         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3711         return type.
3712         (sol_thread_target::pid_to_str): Change return type.
3713         * remote.c (class remote_target) <pid_to_str>: Change return
3714         type.
3715         (remote_target::pid_to_str): Change return type.
3716         (extended_remote_target::attach, remote_target::remote_stop_ns)
3717         (remote_target::remote_notif_remove_queued_reply)
3718         (remote_target::push_stop_reply, remote_target::disable_btrace):
3719         Update.
3720         (extended_remote_target::attach): Update.
3721         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3722         type.
3723         (gdbsim_target::pid_to_str): Change return type.
3724         * ravenscar-thread.c (struct ravenscar_thread_target)
3725         <pid_to_str>: Change return type.
3726         (ravenscar_thread_target::pid_to_str): Change return type.
3727         * procfs.c (class procfs_target) <pid_to_str>: Change return
3728         type.
3729         (procfs_target::pid_to_str): Change return type.
3730         (procfs_target::attach): Update.
3731         (procfs_target::detach): Update.
3732         (procfs_target::fetch_registers): Update.
3733         (procfs_target::store_registers): Update.
3734         (procfs_target::wait): Update.
3735         (procfs_target::files_info): Update.
3736         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3737         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3738         return type.
3739         (nto_procfs_target::pid_to_str): Change return type.
3740         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3741         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3742         return type.
3743         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3744         (exit_lwp): Update.
3745         (attach_proc_task_lwp_callback, get_detach_signal)
3746         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3747         (linux_nat_target::resume, wait_lwp, stop_callback)
3748         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3749         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3750         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3751         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3752         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3753         type.
3754         (inf_ptrace_target::attach): Update.
3755         (inf_ptrace_target::files_info): Update.
3756         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3757         type.
3758         (go32_nat_target::pid_to_str): Change return type.
3759         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3760         (gnu_nat_target::wait): Update.
3761         (gnu_nat_target::wait): Update.
3762         (gnu_nat_target::resume): Update.
3763         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3764         (fbsd_nat_target::wait): Update.
3765         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3766         type.
3767         (darwin_nat_target::attach): Update.
3768         * corelow.c (class core_target) <pid_to_str>: Change return type.
3769         (core_target::pid_to_str): Change return type.
3770         * target.c (normal_pid_to_str): Change return type.
3771         (default_pid_to_str): Likewise.
3772         (target_pid_to_str): Change return type.
3773         (target_translate_tls_address): Update.
3774         (target_announce_detach): Update.
3775         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3776         return type.
3777         (bsd_uthread_target::pid_to_str): Change return type.
3778         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3779         type.
3780         (bsd_kvm_target::pid_to_str): Change return type.
3781         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3782         return type.
3783         (aix_thread_target::pid_to_str): Change return type.
3784         * target.h (struct target_ops) <pid_to_str>: Change return type.
3785         (target_pid_to_str, normal_pid_to_str): Likewise.
3786         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3787         type.
3788         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3789         type.
3790         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3791         return type.
3792         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3793         type.
3794         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3795         type.
3796         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3797         return type.
3798
3799 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3800
3801         * NEWS: Mention that the new default MI version is 3.  Mention
3802         changes to the output of commands and events that deal with
3803         multi-location breakpoints.
3804         * breakpoint.c: Include "mi/mi-out.h".
3805         (print_one_breakpoint): Change output syntax if using MI version
3806         >= 3.
3807         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3808         New.
3809         (mi_multi_location_breakpoint_output_fixed): New.
3810         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3811         (mi_cmd_fix_multi_location_breakpoint_output): New.
3812         (mi_multi_location_breakpoint_output_fixed): New.
3813         * mi/mi-cmds.c (mi_cmds): Register command
3814         -fix-multi-location-breakpoint-output.
3815         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3816         interpreter "mi".
3817
3818 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3819
3820         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3821         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3822         instantiate mi_ui_out based on interpreter name.
3823         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3824         * mi/mi-main.c (mi_load_progress): Likewise.
3825
3826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3827
3828         * NEWS: Combine separate "New targets" sections for 8.3.
3829
3830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3831
3832         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3833         (ppcfbsd_init_abi): Install gdbarch
3834         "fetch_tls_load_module_address" and "get_thread_local_address"
3835         methods.
3836
3837 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3838
3839         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3840         (riscv_fbsd_init_abi): Install gdbarch
3841         "fetch_tls_load_module_address" and "get_thread_local_address"
3842         methods.
3843
3844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3845
3846         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3847         (i386fbsd_init_abi): Install gdbarch
3848         "fetch_tls_load_module_address" and "get_thread_local_address"
3849         methods.
3850
3851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3852
3853         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3854         (amd64fbsd_init_abi): Install gdbarch
3855         "fetch_tls_load_module_address" and "get_thread_local_address"
3856         methods.
3857
3858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3859
3860         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3861         (struct fbsd_pspace_data): New type.
3862         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3863         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3864         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3865         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3866         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3867
3868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3869
3870         * gdbtypes.c (lookup_struct_elt): New function.
3871         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3872         * gdbtypes.h (struct struct_elt): New type.
3873         (lookup_struct_elt): New prototype.
3874
3875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3876
3877         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3878         remove disabled code block.
3879
3880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3881
3882         * gdbarch.sh (get_thread_local_address): New method.
3883         * gdbarch.h, gdbarch.c: Regenerate.
3884         * target.c (target_translate_tls_address): Use
3885         gdbarch_get_thread_local_address if present instead of
3886         target::get_thread_local_address.
3887
3888 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3889
3890         * target.h (target::get_thread_local_address): Update comment.
3891
3892 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3893
3894         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3895         objfile->separate_debug_objfile_backlink if not NULL.
3896
3897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3898
3899         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3900         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3901         (amd64bsd_store_inferior_registers): Likewise.
3902         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3903         Enable segment base registers.
3904         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3905         PT_GETFSBASE and PT_GETGSBASE.
3906         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3907         PT_SETGSBASE.
3908         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3909         segment base registers.
3910         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3911
3912 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3913
3914         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3915         Update calls to i386_target_description to add 'segments'
3916         parameter.
3917         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3918         add segment base registers.
3919         * arch/i386.c (i386_create_target_description): Add 'segments'
3920         parameter to enable segment base registers.
3921         * arch/i386.h (i386_create_target_description): Likewise.
3922         * features/i386/32bit-segments.xml: New file.
3923         * features/i386/32bit-segments.c: Generate.
3924         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3925         call to i386_target_description to add 'segments' parameter.
3926         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3927         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3928         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3929         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3930         if feature is present.
3931         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3932         Add 'segments' parameter to call to i386_target_description.
3933         (i386_target_description): Add 'segments' parameter to enable
3934         segment base registers.
3935         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3936         to call to i386_target_description.
3937         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3938         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3939         Define I386_NUM_REGS.
3940         (i386_target_description): Add 'segments' parameter to enable
3941         segment base registers.
3942
3943 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3944
3945         PR/24325
3946         * source-cache.c: #undef open and close, to avoid unresolved
3947         externals during linking.
3948
3949 2019-03-12  Tom Tromey  <tromey@adacore.com>
3950
3951         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3952         const.  Add initializers.
3953         (_initialize_remote): Don't initialize ptid globals.
3954
3955 2019-03-12  Pedro Alves  <palves@redhat.com>
3956
3957         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3958
3959 2019-03-12  Pedro Alves  <palves@redhat.com>
3960
3961         * cp-name-parser.y (main): Remove unused 'len' variable.
3962
3963 2019-03-12  Tom Tromey  <tromey@adacore.com>
3964
3965         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3966         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3967
3968 2019-03-12  Tom Tromey  <tromey@adacore.com>
3969
3970         * linux-nat.c (iterate_over_lwps): Update.
3971         (stop_callback): Remove parameter.
3972         (stop_wait_callback, detach_callback, resume_set_callback)
3973         (select_singlestep_lwp_callback, set_ignore_sigint)
3974         (status_callback, resumed_callback, resume_clear_callback)
3975         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3976         data parameter.
3977         (linux_nat_target::detach, linux_nat_target::resume)
3978         (linux_stop_and_wait_all_lwps, select_event_lwp)
3979         (linux_nat_filter_event, linux_nat_wait_1)
3980         (linux_nat_target::kill, linux_nat_target::stop)
3981         (linux_nat_target::stop): Update.
3982         (linux_nat_resume_callback): Change type.
3983         (resume_stopped_resumed_lwps, count_events_callback)
3984         (select_event_lwp_callback): Likewise.
3985         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3986         * arm-linux-nat.c (struct update_registers_data): Remove.
3987         (update_registers_callback): Change type.
3988         (arm_linux_insert_hw_breakpoint1): Update.
3989         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3990         parameter.
3991         (x86_linux_dr_set_addr): Update.
3992         (x86_linux_dr_set_control): Update.
3993         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3994         (iterate_over_lwps): Use gdb::function_view.
3995         * nat/aarch64-linux-hw-point.c (struct
3996         aarch64_dr_update_callback_param): Remove.
3997         (debug_reg_change_callback): Change type.
3998         (aarch64_notify_debug_reg_change): Update.
3999         * s390-linux-nat.c (s390_refresh_per_info): Update.
4000
4001 2019-03-11  Tom Tromey  <tromey@adacore.com>
4002
4003         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4004         redundant assignment to "this_cu".
4005
4006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4007
4008         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4009
4010 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4011
4012         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4013         from...
4014         (rank_one_type): ... this.
4015
4016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4017
4018         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4019         from...
4020         (rank_one_type): ... this.
4021
4022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4023
4024         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4025         from...
4026         (rank_one_type): ... this.
4027
4028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4029
4030         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4031         from...
4032         (rank_one_type): ... this.
4033
4034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4035
4036         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4037         from...
4038         (rank_one_type): ... this.
4039
4040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4041
4042         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4043         from...
4044         (rank_one_type): ... this.
4045
4046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4047
4048         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4049         from...
4050         (rank_one_type): ... this.
4051
4052 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4053
4054         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4055         from...
4056         (rank_one_type): ... this.
4057
4058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4059
4060         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4061         from...
4062         (rank_one_type): ... this.
4063
4064 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4065
4066         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4067         from...
4068         (rank_one_type): ... this.
4069
4070 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4071
4072         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4073         from...
4074         (rank_one_type): ... this.
4075
4076 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4077
4078         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4079         from...
4080         (rank_one_type): ... this.
4081
4082 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4083
4084         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4085         inferior-events' shows the example events.
4086
4087 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4088
4089         Support styling on native MS-Windows console
4090
4091         PR/24315
4092         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4093         on MS-Windows if $TERM is not defined.
4094
4095         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4096
4097         * posix-hdep.c (gdb_console_fputs):
4098         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4099         functions.
4100         * ui-file.h (gdb_console_fputs): Add prototype.
4101
4102         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4103         back to fputs only if the former returns zero.
4104
4105 2019-03-07  Tom Tromey  <tom@tromey.com>
4106
4107         * symmisc.c (print_symbol_bcache_statistics): Update.
4108         (print_objfile_statistics): Update.
4109         * symfile.c (allocate_symtab): Update.
4110         * stabsread.c: Don't include bcache.h.
4111         * psymtab.h (struct psymbol_bcache): Don't declare.
4112         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4113         (psymbol_bcache_init, psymbol_bcache_free)
4114         (psymbol_bcache_get_bcache): Don't declare.
4115         * psymtab.c (struct psymbol_bcache): Remove.
4116         (psymtab_storage::psymtab_storage): Update.
4117         (psymtab_storage::~psymtab_storage): Update.
4118         (psymbol_bcache_init, psymbol_bcache_free)
4119         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4120         (add_psymbol_to_bcache): Update.
4121         (allocate_psymtab): Update.
4122         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4123         macro_cache>: No longer pointers.
4124         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4125         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4126         * macrotab.c (macro_bcache): Update.
4127         * macroexp.c: Don't include bcache.h.
4128         * gdbtypes.c (check_types_worklist): Update.
4129         (types_deeply_equal): Remove TRY/CATCH.  Update.
4130         * elfread.c (elf_symtab_read): Update.
4131         * dwarf2read.c: Don't include bcache.h.
4132         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4133         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4134         (print_bcache_statistics, bcache_memory_used): Don't declare.
4135         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4136         methods.  Rename all data members.
4137         * bcache.c (struct bcache): Move to bcache.h.
4138         (bcache::expand_hash_table): Rename from expand_hash_table.
4139         (bcache): Remove.
4140         (bcache::insert): Rename from bcache_full.
4141         (bcache::compare): Rename from bcache_compare.
4142         (bcache_xmalloc): Remove.
4143         (bcache::~bcache): Rename from bcache_xfree.
4144         (bcache::print_statistics): Rename from print_bcache_statistics.
4145         (bcache::memory_used): Rename from bcache_memory_used.
4146
4147 2019-03-07  Pedro Alves  <palves@redhat.com>
4148
4149         * infrun.c (normal_stop): Also check for
4150         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4151
4152 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * f-lang.c (value_from_host_double): Moved to...
4155         * value.c (value_from_host_double): ...here.
4156         * value.h (value_from_host_double): Declare.
4157         * guile/scm-math.c (vlscm_convert_typed_number): Use
4158         value_from_host_double.
4159         (vlscm_convert_number): Likewise.
4160         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4161         * python/py-value.c (convert_value_from_python): Likewise.
4162
4163 2019-03-06  Tom Tromey  <tom@tromey.com>
4164
4165         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4166
4167 2019-03-06  Tom Tromey  <tom@tromey.com>
4168
4169         * utils.h (free_current_contents): Don't declare.
4170         * utils.c (free_current_contents): Remove.
4171
4172 2019-03-06  Tom Tromey  <tom@tromey.com>
4173
4174         * top.c (quit_force): Update.
4175         * main.c (captured_command_loop): Update.
4176         * common/new-op.c (operator new): Update.
4177         * common/common-exceptions.c (struct catcher)
4178         <save_cleanup_chain>: Remove member.
4179         (exceptions_state_mc_init): Update.
4180         (exception_try_scope_entry): Return nullptr.
4181         (exception_try_scope_exit, exception_rethrow)
4182         (throw_exception_sjlj, throw_exception_cxx): Update.
4183         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4184         (all_cleanups, do_cleanups, discard_cleanups)
4185         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4186         (restore_cleanups, restore_final_cleanups): Don't declare.
4187         (do_final_cleanups): Remove parameter.
4188         * common/cleanups.c (cleanup_chain, make_cleanup)
4189         (make_cleanup_dtor, all_cleanups, do_cleanups)
4190         (discard_my_cleanups, discard_cleanups)
4191         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4192         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4193         (null_cleanup): Remove.
4194         (do_final_cleanups): Remove parameter.
4195
4196 2019-03-06  Tom Tromey  <tom@tromey.com>
4197
4198         * remote.c (remote_target::remote_parse_stop_reply): Use
4199         unique_xmalloc_ptr.
4200
4201 2019-03-06  Tom Tromey  <tom@tromey.com>
4202
4203         * stabsread.c (struct stabs_field_info): Rename from field_info.
4204         <list, fnlist>: Add initializers.
4205         <obstack>: New member.
4206         (read_member_functions, read_struct_fields, read_baseclasses):
4207         Allocate on obstack.  Don't use cleanups.
4208         (read_one_struct_field, read_member_functions, read_struct_fields)
4209         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4210         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4211         (read_struct_type): Update.
4212
4213 2019-03-06  Tom Tromey  <tom@tromey.com>
4214
4215         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4216         * common/filestuff.h (make_cleanup_close): Don't declare.
4217         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4218         Remove.
4219
4220 2019-03-06  Tom Tromey  <tom@tromey.com>
4221
4222         * solib-aix.c: Use make_scope_exit.
4223
4224 2019-03-06  Tom Tromey  <tom@tromey.com>
4225
4226         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4227         Use make_scope_exit.
4228
4229 2019-03-06  Tom Tromey  <tom@tromey.com>
4230
4231         * solib-svr4.c (disable_probes_interface): Remove parameter.
4232         (svr4_handle_solib_event): Use make_scope_exit.
4233
4234 2019-03-06  Tom Tromey  <tom@tromey.com>
4235
4236         * remote.c (struct stop_reply_deleter): Remove.
4237         (stop_reply_up): Update.
4238         (struct stop_reply): Derive from notif_event.  Don't typedef.
4239         <regcache>: Now a std::vector.
4240         (stop_reply_xfree): Remove.
4241         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4242         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4243         (remote_target::discard_pending_stop_replies): Use delete.
4244         (remote_target::remote_parse_stop_reply): Update.
4245         (remote_target::process_stop_reply): Update.
4246         * remote-notif.h (struct notif_event): Add virtual destructor.
4247         Remove "dtr" member.
4248         (struct notif_client) <alloc_event>: Return a unique_ptr.
4249         (notif_event_xfree): Don't declare.
4250         (notif_event_up): New typedef.
4251         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4252         (notif_event_xfree, do_notif_event_xfree): Remove.
4253         (remote_notif_state_xfree): Update.
4254
4255 2019-03-06  Tom Tromey  <tom@tromey.com>
4256
4257         * infrun.c (displaced_step_clear_cleanup): Now a
4258         forward_scope_exit type.
4259         (displaced_step_prepare_throw): Update.
4260         (displaced_step_fixup): Update.
4261
4262 2019-03-06  Tom Tromey  <tom@tromey.com>
4263
4264         * inferior.h (class inferior): Update comment.
4265         * gdbthread.h (class thread_info): Update comment.
4266
4267 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4268             Tom Tromey  <tom@tromey.com>
4269
4270         * stabsread.h (struct stab_section_list): Remove.
4271         (coffstab_build_psymtabs): Update.
4272         * dbxread.c (symbuf_sections): Now a std::vector.
4273         (sect_idx): New global.
4274         (fill_symbuf): Update.
4275         (coffstab_build_psymtabs): Change type of stabsects parameter.
4276         Update.
4277         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4278         std::vector.
4279         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4280         (coff_locate_sections): Update.
4281         (coff_symfile_read): Remove cleanups.  Update.
4282         (init_stringtab): Add storage parameter.
4283         (free_stringtab, free_stringtab_cleanup): Remove.
4284         (init_lineno): Add storage parameter.
4285         (free_linetab, free_linetab_cleanup): Remove.
4286
4287 2019-03-06  Pedro Alves  <palves@redhat.com>
4288
4289         * linux-fork.c (fork_info::clobber_regs): Delete.
4290         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4291         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4292         comment.  Adjust.
4293         (scoped_switch_fork_info::scoped_switch_fork_info)
4294         (checkpoint_command, linux_fork_context): Adjust
4295         fork_save_infrun_state calls.
4296
4297 2019-03-06  Pedro Alves  <palves@redhat.com>
4298
4299         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4300         (inf_has_multiple_threads): Return 'bool' and rewrite using
4301         inferior_info::threads().
4302
4303 2019-03-06  Pedro Alves  <palves@redhat.com>
4304
4305         * linux-fork.c: Include <list>.
4306         (fork_list): Now a std::list instance.
4307         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4308         (forks_exist_p, find_last_fork): Adjust.
4309         (new_fork): Delete.
4310         (one_fork_p): New.
4311         (add_fork): Adjust.
4312         (free_fork): Delete, folded into fork_info::~fork_info().
4313         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4314         Adjust.
4315         (init_fork_list): Delete.
4316         (linux_fork_killall, linux_fork_mourn_inferior)
4317         (linux_fork_detach, info_checkpoints_command): Adjust.
4318         (_initialize_linux_fork): No longer call init_fork_list.
4319
4320 2019-03-06  Pedro Alves  <palves@redhat.com>
4321
4322         * linux-fork.c (new_fork): New, split out of ...
4323         (add_fork): ... this.  Return void.  Move "first fork" special
4324         case from here, to ...
4325         (checkpoint_command): ... here.
4326         * linux-linux.h (add_fork): Return void.
4327
4328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4329
4330         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4331
4332 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4333             Chris January  <chris.january@arm.com>
4334             David Lecomber  <david.lecomber@arm.com>
4335
4336         * f-exp.y: New token, UNOP_INTRINSIC.
4337         (exp): New pattern using UNOP_INTRINSIC token.
4338         (f77_keywords): Add 'abs' keyword.
4339         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4340         (value_from_host_double): New function.
4341         (evaluate_subexp_f): Support UNOP_ABS.
4342
4343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4344
4345         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4346         types.
4347
4348 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4351         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4352         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4353
4354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4357
4358 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4359             Chris January  <chris.january@arm.com>
4360
4361         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4362         * f-exp.y: Define 'KIND' token.
4363         (exp): New pattern for KIND expressions.
4364         (ptype): Handle types with a kind extension.
4365         (direct_abs_decl): Extend to spot kind extensions.
4366         (f77_keywords): Add 'kind' to the list.
4367         (push_kind_type): New function.
4368         (convert_to_kind_type): New function.
4369         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4370         * parse.c (operator_length_standard): Likewise.
4371         * parser-defs.h (enum type_pieces): Add tp_kind.
4372         * std-operator.def: Add UNOP_KIND.
4373
4374 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4375
4376         * f-exp.y (f_parse): Set yydebug.
4377
4378 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * f-lang.c (evaluate_subexp_f): New function.
4381         (exp_descriptor_f): New global.
4382         (f_language_defn): Use exp_descriptor_f instead of
4383         exp_descriptor_standard.
4384
4385 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4386
4387         * f-exp.y (struct token): Add comments.
4388         (dot_ops): Remove uppercase versions and the end marker.
4389         (f77_keywords): Likewise.
4390         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4391         entries in the dot_ops array are case insensitive, and use
4392         strncasecmp to compare strings.  Also some whitespace cleanup in
4393         this area.  Similar for the f77_keywords array, except entries in
4394         this list might be case sensitive.
4395
4396 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4397
4398         * f-exp.y (struct f77_boolean_val): Add comments.
4399         (boolean_values): Remove uppercase versions, and end marker.
4400         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4401         and use strncasecmp to achieve case insensitivity.  Additionally,
4402         perform whitespace cleanup around this code.
4403
4404 2019-03-06  Tom Tromey  <tromey@adacore.com>
4405
4406         * remote-sim.c (gdbsim_target_open): Use result of
4407         gdb_argv::release.
4408
4409 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4410         Dirk Schubert  <dirk.schubert@arm.com>
4411         Chris January  <chris.january@arm.com>
4412
4413         * eval.c (evaluate_subexp_standard): Call Fortran argument
4414         wrapping logic.
4415         * f-lang.c (struct value): A value which can be passed into a
4416         Fortran function call.
4417         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4418         where appropriate.
4419         (struct type): Value ready for a Fortran function call.
4420         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4421         is needed.
4422         * f-lang.h (fortran_argument_convert): Declaration.
4423         (fortran_preserve_arg_pointer): Declaration.
4424         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4425
4426 2019-03-05  Tom Tromey  <tromey@adacore.com>
4427
4428         * python/py-prettyprint.c (print_string_repr): Remove #if.
4429         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4430
4431 2019-03-05  Tom Tromey  <tromey@adacore.com>
4432
4433         * target.c (the_dummy_target): Move later.  Change type to
4434         "dummy_target".
4435         (initialize_targets): Don't initialize the_dummy_target.
4436
4437 2019-03-05  Tom Tromey  <tromey@adacore.com>
4438
4439         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4440         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4441
4442 2019-03-05  Tom Tromey  <tromey@adacore.com>
4443
4444         * windows-nat.c (windows_nat_target::attach)
4445         (windows_nat_target::detach): Don't call gdb_flush.
4446         * valprint.c (generic_val_print, val_print, val_print_string):
4447         Don't call gdb_flush.
4448         * utils.c (defaulted_query): Don't call gdb_flush.
4449         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4450         * target.c (target_announce_detach): Don't call gdb_flush.
4451         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4452         * remote.c (extended_remote_target::attach): Don't call
4453         gdb_flush.
4454         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4455         * printcmd.c (do_examine): Don't call gdb_flush.
4456         (info_display_command): Don't call gdb_flush.
4457         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4458         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4459         * memattr.c (info_mem_command): Don't call gdb_flush.
4460         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4461         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4462         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4463         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4464         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4465         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4466         (gnu_nat_target::detach): Don't call gdb_flush.
4467         * f-valprint.c (f_val_print): Don't call gdb_flush.
4468         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4469         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4470         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4471         gdb_flush.
4472         * c-valprint.c (c_val_print): Don't call gdb_flush.
4473         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4474
4475 2019-03-05  Tom Tromey  <tromey@adacore.com>
4476
4477         * varobj.c (update_dynamic_varobj_children): Update.
4478         (install_default_visualizer): Use reset, not release.
4479         * value.c (set_internalvar): Update.
4480         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4481         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4482         ATTRIBUTE_UNUSED_RESULT.
4483
4484 2019-03-05  Tom Tromey  <tromey@adacore.com>
4485
4486         * remote.c (class scoped_remote_fd) <release>: Add
4487         ATTRIBUTE_UNUSED_RESULT.
4488
4489 2019-03-05  Tom Tromey  <tromey@adacore.com>
4490
4491         * macroexp.c (struct macro_buffer) <release>: Add
4492         ATTRIBUTE_UNUSED_RESULT.
4493
4494 2019-03-05  Tom Tromey  <tromey@adacore.com>
4495
4496         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4497         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4498         ATTRIBUTE_UNUSED_RESULT.
4499
4500 2019-03-05  Tom Tromey  <tromey@adacore.com>
4501
4502         * common/scoped_fd.h (class scoped_fd) <release>: Add
4503         ATTRIBUTE_UNUSED_RESULT.
4504
4505 2019-03-05  Tom Tromey  <tromey@adacore.com>
4506
4507         * parser-defs.h (struct parser_state) <release>: Add
4508         ATTRIBUTE_UNUSED_RESULT.
4509
4510 2019-03-05  Tom Tromey  <tromey@adacore.com>
4511
4512         * utils.h (class gdb_argv) <release>: Add
4513         ATTRIBUTE_UNUSED_RESULT.
4514         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4515
4516 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4517
4518         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4519         for-loop range, to avoid compiler warnings.
4520
4521         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4522         avoid compiler warnings about unused variables.
4523
4524         * NEWS: Mention end of support for native debugging on MS-Windows
4525         before XP.
4526
4527         PR gdb/24292
4528         * common/netstuff.c:
4529         * gdbserver/gdbreplay.c
4530         * gdbserver/remote-utils.c:
4531         * ser-tcp.c:
4532         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4533         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4534         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4535         'getaddrinfo' and 'freeaddrinfo' were not available before
4536         Windows XP, and mingw.org's MinGW headers by default define
4537         _WIN32_WINNT to 0x500.
4538
4539 2019-03-01  Gary Benson <gbenson@redhat.com>
4540
4541         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4542
4543 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4544             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4545
4546         PR gdb/8527
4547         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4548         set_sigint_trap, clear_sigint_trap.
4549
4550 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4551
4552         * target.c (target_detach): Clear the regcache and the
4553         frame cache.
4554
4555 2019-02-27  Pedro Alves  <palves@redhat.com>
4556
4557         * utils.c (set_screen_size): When we cap the height/width sizes,
4558         tweak the corresponding command variable to show "unlimited":
4559
4560 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4561             Pedro Alves  <palves@redhat.com>
4562
4563         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4564         before calling rl_set_screen_size.
4565
4566 2019-02-27  Tom Tromey  <tromey@adacore.com>
4567
4568         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4569         define.
4570         * python/py-value.c: Remove Python 2.4 workaround.
4571         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4572         workaround.
4573         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4574         Python 2.4 workaround.
4575         * python/python-internal.h: Remove Python 2.4 comment.
4576         (Py_ssize_t): Don't define.
4577         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4578         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4579         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4580         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4581         * python/python.c (do_start_initialization): Remove Python 2.4
4582         workaround.
4583         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4584         (print_children): Remove Python 2.4 workaround.
4585         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4586         workaround.
4587         (CHARBUFFERPROC_NAME): Remove.
4588         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4589         Python 2.4 workaround.
4590
4591 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4592
4593         * NEWS: Note minimum Python version.
4594
4595 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4596
4597         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4598         code from these functions.  Remove corresponding ifdefs.  Use
4599         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4600         Remove gotos and target of gotos.
4601         (infpy_search_memory): Likewise.
4602
4603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4606         (hppa_gdbarch_init): Don't register deleted functions with
4607         gdbarch.
4608
4609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4612         (h8300_unwind_sp): Delete.
4613         (h8300_dummy_id): Delete.
4614         (h8300_gdbarch_init): Don't register deleted functions with
4615         gdbarch.
4616
4617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4620         (ft32_unwind_pc): Delete.
4621         (ft32_unwind_sp): Delete.
4622         (ft32_gdbarch_init): Don't register deleted functions with
4623         gdbarch.
4624
4625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4626
4627         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4628         (frv_unwind_pc): Delete.
4629         (frv_unwind_sp): Delete.
4630         (frv_gdbarch_init): Don't register deleted functions with
4631         gdbarch.
4632
4633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4636         (riscv_unwind_pc): Delete.
4637         (riscv_unwind_sp): Delete.
4638         (riscv_gdbarch_init): Don't register deleted functions with
4639         gdbarch.
4640
4641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4644         (csky_unwind_pc): Delete.
4645         (csky_unwind_sp): Delete.
4646         (csky_gdbarch_init): Don't register deleted functions with
4647         gdbarch.
4648
4649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4650
4651         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4652         (cris_unwind_pc): Delete.
4653         (cris_unwind_sp): Delete.
4654         (cris_gdbarch_init): Don't register deleted functions with
4655         gdbarch.
4656
4657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4658
4659         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4660         (bfin_unwind_pc): Delete.
4661         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4662
4663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4664
4665         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4666         (arm_unwind_pc): Delete.
4667         (arm_unwind_sp): Delete.
4668         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4669
4670 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4671
4672         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4673         (arc_unwind_pc): Delete.
4674         (arc_unwind_sp): Delete.
4675         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4676
4677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4678
4679         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4680         (alpha_unwind_pc): Delete.
4681         (alpha_gdbarch_init): Don't register deleted functions with
4682         gdbarch.
4683
4684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4685
4686         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4687         (aarch64_unwind_pc): Delete.
4688         (aarch64_unwind_sp): Delete.
4689         (aarch64_gdbarch_init): Don't register deleted functions with
4690         gdbarch.
4691
4692 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4693
4694         * gdbtypes.c (type_align): Don't consider static members when
4695         computing structure alignment.
4696
4697 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4698
4699         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4700         return 0 for other types.
4701         * arch-utils.c (default_type_align): Always return 0.
4702         * gdbarch.h: Regenerate.
4703         * gdbarch.sh (type_align): Extend comment.
4704         * gdbtypes.c (type_align): Add additional comments, always call
4705         gdbarch_type_align before applying the default rules.
4706         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4707         generic code will then apply a suitable default.
4708         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4709         types, return 0 for other types.
4710
4711 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4712
4713         * NEWS: Create a new section for the next release branch.
4714         Rename the section of the current branch, now that it has
4715         been cut.
4716
4717 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4718
4719         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4720         * version.in: Bump version to 8.3.50.DATE-git.
4721
4722 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4723
4724         * aix-thread.c (ptid_cmp): Remove unused variable.
4725         (get_signaled_thread): Likewise.
4726         (store_regs_user_thread): Likewise.
4727         (store_regs_kernel_thread): Likewise.
4728         (fetch_regs_kernel_thread): Remove shadowed variable.
4729
4730 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * features/riscv/32bit-cpu.xml: Add register numbers.
4733         * features/riscv/32bit-fpu.c: Regenerate.
4734         * features/riscv/32bit-fpu.xml: Add register numbers.
4735         * features/riscv/64bit-cpu.xml: Add register numbers.
4736         * features/riscv/64bit-fpu.c: Regenerate.
4737         * features/riscv/64bit-fpu.xml: Add register numbers.
4738
4739 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4740
4741         * NEWS: Mention two argument form of gdb.Value constructor.
4742         * python/py-value.c (convert_buffer_and_type_to_value): New
4743         function.
4744         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4745         Add support for handling an optional second argument.  Call
4746         convert_buffer_and_type_to_value as appropriate.
4747         * python/python-internal.h (Py_buffer_deleter): New struct.
4748         (Py_buffer_up): New typedef.
4749
4750 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4751
4752         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4753         instead of releasing ownership.
4754
4755 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4756
4757         * dwarf2read.c (open_and_init_dwp_file): Call
4758         elf_numsections instead of bfd_count_sections to initialize
4759         dwp_file->num_sections.
4760
4761 2019-02-25  Tom Tromey  <tromey@adacore.com>
4762
4763         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4764
4765 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4766
4767         * gcore.in: Add '--readnever' option when invoking GDB.
4768
4769 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4770
4771         * MAINTAINERS: Update my email address.
4772
4773 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4774
4775         * build-id.c (build_id_to_debug_bfd_1): New function.
4776         (build_id_to_debug_bfd): Look for separate debug file in
4777         sysroot.
4778
4779 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4780
4781         * gdbarch.sh: Update the copyright year range that is placed into
4782         generated files.
4783
4784 2019-02-22  Keith Seitz  <keiths@redhat.com>
4785
4786         PR symtab/23853
4787         * linespec.c (create_sals_line_offset): Search for the default
4788         symtab's filename instead of its fullname.
4789
4790 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4791
4792         * NEWS: Update style defaults.
4793
4794 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4795
4796         * main.c (captured_main_1): Disable styling in batch mode.
4797
4798 2019-02-20  Tom Tromey  <tom@tromey.com>
4799
4800         * symtab.c (symtab_symbol_info): Fix typos.
4801
4802 2019-02-20  Tom Tromey  <tromey@adacore.com>
4803
4804         * findcmd.c (_initialize_mem_search): Use upper case for
4805         metasyntactic variables.
4806
4807 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4808
4809         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4810         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4811
4812 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4813
4814         * top.h (source_file_name): Change to std::string.
4815         * top.c (source_file_name): Likewise.
4816         (command_line_input): Adjust.
4817         * cli/cli-script.c (script_from_file): Adjust.
4818
4819 2019-02-19  Tom Tromey  <tromey@adacore.com>
4820
4821         * ravenscar-thread.c
4822         (ravenscar_thread_target::update_thread_list): Don't call
4823         ada_build_task_list.
4824         * ada-lang.h (ada_build_task_list): Don't declare.
4825         * ada-tasks.c (struct ada_tasks_inferior_data)
4826         <task_list_valid_p>: Now bool.
4827         (read_known_tasks, ada_task_list_changed)
4828         (ada_tasks_invalidate_inferior_data): Update.
4829         (read_known_tasks_array): Return bool.
4830         (read_known_tasks_list): Likewise.
4831         (read_known_tasks): Return void.
4832         (ada_build_task_list): Now static.
4833
4834 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4837         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4838
4839 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4840
4841         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4842         variant for ada_tasks_pspace_data_handle and
4843         ada_tasks_inferior_data_handle.
4844         (ada_tasks_pspace_data_cleanup): New function.
4845         (ada_tasks_inferior_data_cleanup): New function.
4846
4847 2019-02-17  Tom Tromey  <tom@tromey.com>
4848
4849         * macrotab.h (macro_source_fullname): Return a std::string.
4850         * macrotab.c (macro_include, check_for_redefinition)
4851         (macro_undef, macro_lookup_definition, foreach_macro)
4852         (foreach_macro_in_scope): Update.
4853         (macro_source_fullname): Return a std::string.
4854         * macrocmd.c (show_pp_source_pos): Update.
4855
4856 2019-02-17  Tom Tromey  <tom@tromey.com>
4857
4858         * macrocmd.c (show_pp_source_pos): Style the file names.
4859
4860 2019-02-17  Tom Tromey  <tom@tromey.com>
4861
4862         PR tui/24197:
4863         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4864
4865 2019-02-17  Tom Tromey  <tom@tromey.com>
4866
4867         * ada-lang.c (user_select_syms): Use filtered printing.
4868         * utils.c (wrap_style): New global.
4869         (desired_style): Remove.
4870         (emit_style_escape): Add stream parameter.
4871         (set_output_style, reset_terminal_style, prompt_for_continue):
4872         Update.
4873         (flush_wrap_buffer): Only flush gdb_stdout.
4874         (wrap_here): Set wrap_style.
4875         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4876         treat escape sequences as a character.  Change when wrap buffer is
4877         flushed.
4878         (fputs_styled): Do not set the output style when the default is
4879         requested.
4880         * ui-style.h (struct ui_file_style) <is_default>: New method.
4881         * source.c (print_source_lines_base): Emit escape sequences in one
4882         piece.
4883
4884 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4885
4886         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4887         integers and enumeration types.
4888
4889 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4890
4891         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4892         instead of lookup_symbol_in_language
4893         (do_exact_match): New function.
4894         (ada_get_symbol_name_matcher): Return do_exact_match when
4895         doing a verbatim match.
4896
4897 2019-02-15  Tom Tromey  <tromey@adacore.com>
4898
4899         * ravenscar-thread.c (ravenscar_thread_target::resume)
4900         (ravenscar_thread_target::wait): Special case wildcard requests.
4901
4902 2019-02-15  Tom Tromey  <tromey@adacore.com>
4903
4904         * ravenscar-thread.c (base_ptid): Remove.
4905         (struct ravenscar_thread_target) <close>: New method.
4906         <m_base_ptid>: New member.
4907         <update_inferior_ptid, active_task, task_is_currently_active,
4908         runtime_initialized>: Declare methods.
4909         <ravenscar_thread_target>: Add constructor.
4910         (ravenscar_thread_target::task_is_currently_active)
4911         (ravenscar_thread_target::update_inferior_ptid)
4912         (ravenscar_runtime_initialized): Rename.  Now methods.
4913         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4914         (ravenscar_thread_target::update_thread_list): Update.
4915         (ravenscar_thread_target::active_task): Now method.
4916         (ravenscar_thread_target::store_registers)
4917         (ravenscar_thread_target::prepare_to_store)
4918         (ravenscar_thread_target::prepare_to_store)
4919         (ravenscar_thread_target::mourn_inferior): Update.
4920         (ravenscar_inferior_created): Use "new" to create target.
4921         (ravenscar_thread_target::get_ada_task_ptid): Update.
4922         (_initialize_ravenscar): Don't initialize base_ptid.
4923         (ravenscar_ops): Remove global.
4924
4925 2019-02-15  Tom Tromey  <tromey@adacore.com>
4926
4927         * target.h (push_target): Declare new overload.
4928         * target.c (push_target): New overload, taking an rvalue reference.
4929         * remote.c (remote_target::open_1): Use push_target overload.
4930         * corelow.c (core_target_open): Use push_target overload.
4931
4932 2019-02-15  Tom Tromey  <tromey@adacore.com>
4933
4934         * ravenscar-thread.c (is_ravenscar_task)
4935         (ravenscar_task_is_currently_active): Return bool.
4936         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4937         (_initialize_ravenscar): Remove "(void)".
4938         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4939         Return bool.
4940
4941 2019-02-15  Tom Tromey  <tromey@adacore.com>
4942
4943         * ravenscar-thread.c (ravenscar_runtime_initializer)
4944         (has_ravenscar_runtime, get_running_thread_id)
4945         (ravenscar_thread_target::resume): Fix indentation.
4946
4947 2019-02-15  Tom Tromey  <tromey@adacore.com>
4948
4949         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4950         from ravenscar_arch_ops.
4951         (sparc_ravenscar_ops::fetch_registers)
4952         (sparc_ravenscar_ops::store_registers): Now methods.
4953         (sparc_ravenscar_prepare_to_store): Remove.
4954         (sparc_ravenscar_ops): Redefine.
4955         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4956         methods and destructor.  Remove members.
4957         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4958         (ravenscar_thread_target::store_registers)
4959         (ravenscar_thread_target::prepare_to_store): Update.
4960         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4961         Remove.
4962         (struct ppc_ravenscar_powerpc_ops): Derive from
4963         ravenscar_arch_ops.
4964         (ppc_ravenscar_powerpc_ops::fetch_registers)
4965         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4966         (ppc_ravenscar_powerpc_ops): Redefine.
4967         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4968         (ppc_ravenscar_e500_ops::fetch_registers)
4969         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4970         (ppc_ravenscar_e500_ops): Redefine.
4971         * aarch64-ravenscar-thread.c
4972         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4973         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4974         (aarch64_ravenscar_fetch_registers)
4975         (aarch64_ravenscar_store_registers): Now methods.
4976         (aarch64_ravenscar_ops): Redefine.
4977
4978 2019-02-15  Tom Tromey  <tromey@adacore.com>
4979
4980         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4981         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4982         (ravenscar_thread_target::stopped_by_watchpoint)
4983         (ravenscar_thread_target::stopped_data_address)
4984         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4985
4986 2019-02-15  Tom Tromey  <tromey@adacore.com>
4987
4988         * ravenscar-thread.c: Fix some typos.
4989
4990 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4991             Tom Tromey  <tromey@adacore.com>
4992
4993         * ada-lang.c (ada_exception_sal): Change addr_string to a
4994         std::string.
4995         (create_ada_exception_catchpoint): Update.
4996
4997 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4998             Tom Tromey  <tromey@adacore.com>
4999
5000         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5001         (bp_location_ops): Remove.
5002         (base_breakpoint_allocate_location): Update.
5003         (free_bp_location): Update.
5004         * ada-lang.c (class ada_catchpoint_location)
5005         <ada_catchpoint_location>: Remove ops parameter.
5006         (ada_catchpoint_location_dtor): Remove.
5007         (ada_catchpoint_location_ops): Remove.
5008         (allocate_location_exception): Update.
5009         * breakpoint.h (struct bp_location_ops): Remove.
5010         (class bp_location) <bp_location>: Remove bp_location_ops
5011         parameter.
5012         <~bp_location>: Add destructor.
5013         <ops>: Remove.
5014
5015 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5016             Pedro Alves  <palves@redhat.com>
5017
5018         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5019         'PATH_MAX'.
5020
5021 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5022             Samuel Thibault  <samuel.thibault@gnu.org>
5023             Thomas Schwinge  <thomas@codesourcery.com>
5024
5025         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5026         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5027
5028 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5029
5030         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5031         (check_empty): Use "const char *".
5032
5033         * gnu-nat.c (gnu_nat_target::detach): Instead of
5034         'detach_inferior (pid)' call
5035         'detach_inferior (find_inferior_pid (pid))'.
5036
5037         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5038         'nat/fork-inferior.o'.
5039         * gnu-nat.c: #include "nat/fork-inferior.h".
5040
5041         * gnu-nat.c (gnu_nat_target::detach): Instead of
5042         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5043         * gnu-nat.h: #include "inf-child.h".
5044         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5045         'i386_gnu_nat_target::fetch_registers'.
5046         (gnu_store_registers): Rename/move to
5047         'i386_gnu_nat_target::store_registers'.
5048
5049         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5050         * gnu-nat.h (mach_thread_info): New function.
5051         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5052
5053         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5054
5055 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5056
5057         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5058
5059 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5060
5061         * windows-nat.c (windows_add_thread): Add new parameter
5062         "main_thread_p" with default value set to false.  Update
5063         function documentation as well as all callers.
5064         (windows_delete_thread): Likewise.
5065         (fake_create_process): Update call to windows_add_thread.
5066         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5067         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5068         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5069         call to windows_delete_thread.
5070
5071 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5072
5073         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5074
5075 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5076
5077         * symfile.c (find_separate_debug_file): Use canonical path of
5078         sysroot with child_path instead of gdb_sysroot if it is valid.
5079
5080 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5081
5082         * symfile.c (find_separate_debug_file): Use child_path to
5083         determine if an object file is under a sysroot.
5084
5085 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5086
5087         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5088         unittests/child-path-selftests.c.
5089         * common/pathstuff.c (child_path): New function.
5090         * common/pathstuff.h (child_path): New prototype.
5091         * unittests/child-path-selftests.c: New file.
5092
5093 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5094
5095         * symfile.c (find_separate_debug_file): Look for separate debug
5096         files in debug directories under the sysroot.
5097
5098 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5099
5100         * symtab.h (struct minimal_symbol data_p): New const method.
5101         (struct minimal_symbol text_p): Likewise.
5102         * symtab.c (output_source_filename): Use file name style
5103         to print file name.
5104         (print_symbol_info): Likewise.
5105         (print_msymbol_info): Use address style to print addresses.
5106         Use function name style to print executable text symbols.
5107         (expand_symtab_containing_pc): Use data_p.
5108         (find_pc_sect_compunit_symtab): Likewise.
5109
5110 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5111
5112         * breakpoint.c (describe_other_breakpoints): Use address style
5113         to print addresses.
5114         (say_where): Likewise.
5115
5116 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5117
5118         * ada-typeprint.c (print_func_type): Print function name
5119         style to print function name.
5120         * c-typeprint.c (c_print_type_1): Likewise.
5121
5122 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5123
5124         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5125         for execve.
5126
5127 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5128
5129         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5130         type_stack.
5131
5132 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5133
5134         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5135         TYPE_CODE_REF types.
5136
5137 2019-02-08  Jim Wilson  <jimw@sifive.com>
5138
5139         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5140         (riscv_linux_fregset): New.
5141         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5142
5143 2019-02-07  Tom Tromey  <tom@tromey.com>
5144
5145         * thread.c (thread_cancel_execution_command): Update.
5146         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5147         methods.
5148         (struct thread_fsm_ops): Remove.
5149         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5150         (thread_fsm_should_stop, thread_fsm_return_value)
5151         (thread_fsm_set_finished, thread_fsm_finished_p)
5152         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5153         Don't declare.
5154         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5155         * infrun.c (clear_proceed_status_thread)
5156         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5157         (print_stop_event): Update.
5158         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5159         Add constructor.
5160         (step_command_fsm_ops): Remove.
5161         (new_step_command_fsm): Remove.
5162         (step_1): Update.
5163         (step_command_fsm::should_stop): Rename from
5164         step_command_fsm_should_stop.
5165         (step_command_fsm::clean_up): Rename from
5166         step_command_fsm_clean_up.
5167         (step_command_fsm::do_async_reply_reason): Rename from
5168         step_command_fsm_async_reply_reason.
5169         (struct until_next_fsm): Inherit from thread_fsm.  Add
5170         constructor.
5171         (until_next_fsm_ops): Remove.
5172         (new_until_next_fsm): Remove.
5173         (until_next_fsm::should_stop): Rename from
5174         until_next_fsm_should_stop.
5175         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5176         (until_next_fsm::do_async_reply_reason): Rename from
5177         until_next_fsm_async_reply_reason.
5178         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5179         constructor.  Change type of breakpoint.
5180         (finish_command_fsm_ops): Remove.
5181         (new_finish_command_fsm): Remove.
5182         (finish_command_fsm::should_stop): Rename from
5183         finish_command_fsm_should_stop.
5184         (finish_command_fsm::clean_up): Rename from
5185         finish_command_fsm_clean_up.
5186         (finish_command_fsm::return_value): Rename from
5187         finish_command_fsm_return_value.
5188         (finish_command_fsm::do_async_reply_reason): Rename from
5189         finish_command_fsm_async_reply_reason.
5190         (finish_command): Update.
5191         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5192         Add constructor.
5193         (call_thread_fsm_ops): Remove.
5194         (call_thread_fsm::call_thread_fsm): Rename from
5195         new_call_thread_fsm.
5196         (call_thread_fsm::should_stop): Rename from
5197         call_thread_fsm_should_stop.
5198         (call_thread_fsm::should_notify_stop): Rename from
5199         call_thread_fsm_should_notify_stop.
5200         (run_inferior_call, call_function_by_hand_dummy): Update.
5201         * cli/cli-interp.c (should_print_stop_to_console): Update.
5202         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5203         Add constructor.  Change type of location_breakpoint,
5204         caller_breakpoint.
5205         (until_break_fsm_ops): Remove.
5206         (new_until_break_fsm): Remove.
5207         (until_break_fsm::should_stop): Rename from
5208         until_break_fsm_should_stop.
5209         (until_break_fsm::clean_up): Rename from
5210         until_break_fsm_clean_up.
5211         (until_break_fsm::do_async_reply_reason): Rename from
5212         until_break_fsm_async_reply_reason.
5213         (until_break_command): Update.
5214         * thread-fsm.c: Remove.
5215         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5216
5217 2019-02-07  Tom Tromey  <tom@tromey.com>
5218
5219         * yy-remap.h: Add include guard.
5220         * xtensa-tdep.h: Add include guard.
5221         * xcoffread.h: Rename include guard.
5222         * varobj-iter.h: Add include guard.
5223         * tui/tui.h: Rename include guard.
5224         * tui/tui-winsource.h: Rename include guard.
5225         * tui/tui-wingeneral.h: Rename include guard.
5226         * tui/tui-windata.h: Rename include guard.
5227         * tui/tui-win.h: Rename include guard.
5228         * tui/tui-stack.h: Rename include guard.
5229         * tui/tui-source.h: Rename include guard.
5230         * tui/tui-regs.h: Rename include guard.
5231         * tui/tui-out.h: Rename include guard.
5232         * tui/tui-layout.h: Rename include guard.
5233         * tui/tui-io.h: Rename include guard.
5234         * tui/tui-hooks.h: Rename include guard.
5235         * tui/tui-file.h: Rename include guard.
5236         * tui/tui-disasm.h: Rename include guard.
5237         * tui/tui-data.h: Rename include guard.
5238         * tui/tui-command.h: Rename include guard.
5239         * tic6x-tdep.h: Add include guard.
5240         * target/waitstatus.h: Rename include guard.
5241         * target/wait.h: Rename include guard.
5242         * target/target.h: Rename include guard.
5243         * target/resume.h: Rename include guard.
5244         * target-float.h: Rename include guard.
5245         * stabsread.h: Add include guard.
5246         * rs6000-tdep.h: Add include guard.
5247         * riscv-fbsd-tdep.h: Add include guard.
5248         * regformats/regdef.h: Rename include guard.
5249         * record.h: Rename include guard.
5250         * python/python.h: Rename include guard.
5251         * python/python-internal.h: Rename include guard.
5252         * python/py-stopevent.h: Rename include guard.
5253         * python/py-ref.h: Rename include guard.
5254         * python/py-record.h: Rename include guard.
5255         * python/py-record-full.h: Rename include guard.
5256         * python/py-record-btrace.h: Rename include guard.
5257         * python/py-instruction.h: Rename include guard.
5258         * python/py-events.h: Rename include guard.
5259         * python/py-event.h: Rename include guard.
5260         * procfs.h: Add include guard.
5261         * proc-utils.h: Add include guard.
5262         * p-lang.h: Add include guard.
5263         * or1k-tdep.h: Rename include guard.
5264         * observable.h: Rename include guard.
5265         * nto-tdep.h: Rename include guard.
5266         * nat/x86-linux.h: Rename include guard.
5267         * nat/x86-linux-dregs.h: Rename include guard.
5268         * nat/x86-gcc-cpuid.h: Add include guard.
5269         * nat/x86-dregs.h: Rename include guard.
5270         * nat/x86-cpuid.h: Rename include guard.
5271         * nat/ppc-linux.h: Rename include guard.
5272         * nat/mips-linux-watch.h: Rename include guard.
5273         * nat/linux-waitpid.h: Rename include guard.
5274         * nat/linux-ptrace.h: Rename include guard.
5275         * nat/linux-procfs.h: Rename include guard.
5276         * nat/linux-osdata.h: Rename include guard.
5277         * nat/linux-nat.h: Rename include guard.
5278         * nat/linux-namespaces.h: Rename include guard.
5279         * nat/linux-btrace.h: Rename include guard.
5280         * nat/glibc_thread_db.h: Rename include guard.
5281         * nat/gdb_thread_db.h: Rename include guard.
5282         * nat/gdb_ptrace.h: Rename include guard.
5283         * nat/fork-inferior.h: Rename include guard.
5284         * nat/amd64-linux-siginfo.h: Rename include guard.
5285         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5286         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5287         * nat/aarch64-linux.h: Rename include guard.
5288         * nat/aarch64-linux-hw-point.h: Rename include guard.
5289         * mn10300-tdep.h: Add include guard.
5290         * mips-linux-tdep.h: Add include guard.
5291         * mi/mi-parse.h: Rename include guard.
5292         * mi/mi-out.h: Rename include guard.
5293         * mi/mi-main.h: Rename include guard.
5294         * mi/mi-interp.h: Rename include guard.
5295         * mi/mi-getopt.h: Rename include guard.
5296         * mi/mi-console.h: Rename include guard.
5297         * mi/mi-common.h: Rename include guard.
5298         * mi/mi-cmds.h: Rename include guard.
5299         * mi/mi-cmd-break.h: Rename include guard.
5300         * m2-lang.h: Add include guard.
5301         * location.h: Rename include guard.
5302         * linux-record.h: Rename include guard.
5303         * linux-nat.h: Add include guard.
5304         * linux-fork.h: Add include guard.
5305         * i386-darwin-tdep.h: Rename include guard.
5306         * hppa-linux-offsets.h: Add include guard.
5307         * guile/guile.h: Rename include guard.
5308         * guile/guile-internal.h: Rename include guard.
5309         * gnu-nat.h: Rename include guard.
5310         * gdb-stabs.h: Rename include guard.
5311         * frv-tdep.h: Add include guard.
5312         * f-lang.h: Add include guard.
5313         * event-loop.h: Add include guard.
5314         * darwin-nat.h: Rename include guard.
5315         * cp-abi.h: Rename include guard.
5316         * config/sparc/nm-sol2.h: Rename include guard.
5317         * config/nm-nto.h: Rename include guard.
5318         * config/nm-linux.h: Add include guard.
5319         * config/i386/nm-i386gnu.h: Rename include guard.
5320         * config/djgpp/nl_types.h: Rename include guard.
5321         * config/djgpp/langinfo.h: Rename include guard.
5322         * compile/gcc-cp-plugin.h: Add include guard.
5323         * compile/gcc-c-plugin.h: Add include guard.
5324         * compile/compile.h: Rename include guard.
5325         * compile/compile-object-run.h: Rename include guard.
5326         * compile/compile-object-load.h: Rename include guard.
5327         * compile/compile-internal.h: Rename include guard.
5328         * compile/compile-cplus.h: Rename include guard.
5329         * compile/compile-c.h: Rename include guard.
5330         * common/xml-utils.h: Rename include guard.
5331         * common/x86-xstate.h: Rename include guard.
5332         * common/version.h: Rename include guard.
5333         * common/vec.h: Rename include guard.
5334         * common/tdesc.h: Rename include guard.
5335         * common/selftest.h: Rename include guard.
5336         * common/scoped_restore.h: Rename include guard.
5337         * common/scoped_mmap.h: Rename include guard.
5338         * common/scoped_fd.h: Rename include guard.
5339         * common/safe-iterator.h: Rename include guard.
5340         * common/run-time-clock.h: Rename include guard.
5341         * common/refcounted-object.h: Rename include guard.
5342         * common/queue.h: Rename include guard.
5343         * common/ptid.h: Rename include guard.
5344         * common/print-utils.h: Rename include guard.
5345         * common/preprocessor.h: Rename include guard.
5346         * common/pathstuff.h: Rename include guard.
5347         * common/observable.h: Rename include guard.
5348         * common/netstuff.h: Rename include guard.
5349         * common/job-control.h: Rename include guard.
5350         * common/host-defs.h: Rename include guard.
5351         * common/gdb_wait.h: Rename include guard.
5352         * common/gdb_vecs.h: Rename include guard.
5353         * common/gdb_unlinker.h: Rename include guard.
5354         * common/gdb_unique_ptr.h: Rename include guard.
5355         * common/gdb_tilde_expand.h: Rename include guard.
5356         * common/gdb_sys_time.h: Rename include guard.
5357         * common/gdb_string_view.h: Rename include guard.
5358         * common/gdb_splay_tree.h: Rename include guard.
5359         * common/gdb_setjmp.h: Rename include guard.
5360         * common/gdb_ref_ptr.h: Rename include guard.
5361         * common/gdb_optional.h: Rename include guard.
5362         * common/gdb_locale.h: Rename include guard.
5363         * common/gdb_assert.h: Rename include guard.
5364         * common/filtered-iterator.h: Rename include guard.
5365         * common/filestuff.h: Rename include guard.
5366         * common/fileio.h: Rename include guard.
5367         * common/environ.h: Rename include guard.
5368         * common/common-utils.h: Rename include guard.
5369         * common/common-types.h: Rename include guard.
5370         * common/common-regcache.h: Rename include guard.
5371         * common/common-inferior.h: Rename include guard.
5372         * common/common-gdbthread.h: Rename include guard.
5373         * common/common-exceptions.h: Rename include guard.
5374         * common/common-defs.h: Rename include guard.
5375         * common/common-debug.h: Rename include guard.
5376         * common/cleanups.h: Rename include guard.
5377         * common/buffer.h: Rename include guard.
5378         * common/btrace-common.h: Rename include guard.
5379         * common/break-common.h: Rename include guard.
5380         * cli/cli-utils.h: Rename include guard.
5381         * cli/cli-style.h: Rename include guard.
5382         * cli/cli-setshow.h: Rename include guard.
5383         * cli/cli-script.h: Rename include guard.
5384         * cli/cli-interp.h: Rename include guard.
5385         * cli/cli-decode.h: Rename include guard.
5386         * cli/cli-cmds.h: Rename include guard.
5387         * charset-list.h: Add include guard.
5388         * buildsym-legacy.h: Rename include guard.
5389         * bfin-tdep.h: Add include guard.
5390         * ax.h: Rename include guard.
5391         * arm-linux-tdep.h: Add include guard.
5392         * arm-fbsd-tdep.h: Add include guard.
5393         * arch/xtensa.h: Rename include guard.
5394         * arch/tic6x.h: Add include guard.
5395         * arch/i386.h: Add include guard.
5396         * arch/arm.h: Rename include guard.
5397         * arch/arm-linux.h: Rename include guard.
5398         * arch/arm-get-next-pcs.h: Rename include guard.
5399         * arch/amd64.h: Add include guard.
5400         * arch/aarch64-insn.h: Rename include guard.
5401         * arch-utils.h: Rename include guard.
5402         * annotate.h: Add include guard.
5403         * amd64-darwin-tdep.h: Rename include guard.
5404         * aarch64-linux-tdep.h: Add include guard.
5405         * aarch64-fbsd-tdep.h: Add include guard.
5406         * aarch32-linux-nat.h: Add include guard.
5407
5408 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5409
5410         * macrotab.c (macro_define_internal): New function that
5411         factorizes macro_define_object_internal and macro_define_function
5412         code.
5413         (macro_define_object_internal): Use macro_define_internal.
5414         (macro_define_function): Likewise.
5415
5416 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5417
5418         * macrocmd.c (extract_identifier): Return
5419         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5420         callers.
5421
5422 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5423
5424         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5425
5426 2019-02-05  Tom Tromey  <tom@tromey.com>
5427
5428         * target.c (target_stack::unpush): Move assertion earlier.
5429
5430 2019-01-30  Tom Tromey  <tom@tromey.com>
5431
5432         PR python/23615:
5433         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5434         (gdbpy_parse_and_eval): Likewise.
5435         * python/python-internal.h (gdbpy_allow_threads): New class.
5436
5437 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5438
5439         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5440         (aarch64_fbsd_fpregmap): Move earlier.
5441         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5442         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5443         instead of individual calls to trad_frame_set_reg_addr.
5444         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5445         earlier.
5446         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5447         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5448         instead of individual calls to trad_frame_set_reg_addr.
5449
5450 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5451
5452         * CONTRIBUTE: Replace contribution list with wiki link.
5453
5454 2019-01-25  Tom Tromey  <tom@tromey.com>
5455
5456         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5457
5458 2019-01-25  Tom Tromey  <tom@tromey.com>
5459
5460         * xtensa-linux-nat.c: Fix common/ includes.
5461         * xml-support.h: Fix common/ includes.
5462         * xml-support.c: Fix common/ includes.
5463         * x86-linux-nat.c: Fix common/ includes.
5464         * windows-nat.c: Fix common/ includes.
5465         * varobj.h: Fix common/ includes.
5466         * varobj.c: Fix common/ includes.
5467         * value.c: Fix common/ includes.
5468         * valops.c: Fix common/ includes.
5469         * utils.c: Fix common/ includes.
5470         * unittests/xml-utils-selftests.c: Fix common/ includes.
5471         * unittests/utils-selftests.c: Fix common/ includes.
5472         * unittests/unpack-selftests.c: Fix common/ includes.
5473         * unittests/tracepoint-selftests.c: Fix common/ includes.
5474         * unittests/style-selftests.c: Fix common/ includes.
5475         * unittests/string_view-selftests.c: Fix common/ includes.
5476         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5477         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5478         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5479         * unittests/rsp-low-selftests.c: Fix common/ includes.
5480         * unittests/parse-connection-spec-selftests.c: Fix common/
5481         includes.
5482         * unittests/optional-selftests.c: Fix common/ includes.
5483         * unittests/offset-type-selftests.c: Fix common/ includes.
5484         * unittests/observable-selftests.c: Fix common/ includes.
5485         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5486         * unittests/memrange-selftests.c: Fix common/ includes.
5487         * unittests/memory-map-selftests.c: Fix common/ includes.
5488         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5489         * unittests/function-view-selftests.c: Fix common/ includes.
5490         * unittests/environ-selftests.c: Fix common/ includes.
5491         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5492         * unittests/common-utils-selftests.c: Fix common/ includes.
5493         * unittests/cli-utils-selftests.c: Fix common/ includes.
5494         * unittests/array-view-selftests.c: Fix common/ includes.
5495         * ui-file.c: Fix common/ includes.
5496         * tui/tui-io.c: Fix common/ includes.
5497         * tracepoint.h: Fix common/ includes.
5498         * tracepoint.c: Fix common/ includes.
5499         * tracefile-tfile.c: Fix common/ includes.
5500         * top.h: Fix common/ includes.
5501         * top.c: Fix common/ includes.
5502         * thread.c: Fix common/ includes.
5503         * target/waitstatus.h: Fix common/ includes.
5504         * target/waitstatus.c: Fix common/ includes.
5505         * target.h: Fix common/ includes.
5506         * target.c: Fix common/ includes.
5507         * target-memory.c: Fix common/ includes.
5508         * target-descriptions.c: Fix common/ includes.
5509         * symtab.h: Fix common/ includes.
5510         * symfile.c: Fix common/ includes.
5511         * stap-probe.c: Fix common/ includes.
5512         * spu-linux-nat.c: Fix common/ includes.
5513         * sparc-nat.c: Fix common/ includes.
5514         * source.c: Fix common/ includes.
5515         * solib.c: Fix common/ includes.
5516         * solib-target.c: Fix common/ includes.
5517         * ser-unix.c: Fix common/ includes.
5518         * ser-tcp.c: Fix common/ includes.
5519         * ser-pipe.c: Fix common/ includes.
5520         * ser-base.c: Fix common/ includes.
5521         * selftest-arch.c: Fix common/ includes.
5522         * s12z-tdep.c: Fix common/ includes.
5523         * rust-exp.y: Fix common/ includes.
5524         * rs6000-aix-tdep.c: Fix common/ includes.
5525         * riscv-tdep.c: Fix common/ includes.
5526         * remote.c: Fix common/ includes.
5527         * remote-notif.h: Fix common/ includes.
5528         * remote-fileio.h: Fix common/ includes.
5529         * remote-fileio.c: Fix common/ includes.
5530         * regcache.h: Fix common/ includes.
5531         * regcache.c: Fix common/ includes.
5532         * record-btrace.c: Fix common/ includes.
5533         * python/python.c: Fix common/ includes.
5534         * python/py-type.c: Fix common/ includes.
5535         * python/py-inferior.c: Fix common/ includes.
5536         * progspace.h: Fix common/ includes.
5537         * producer.c: Fix common/ includes.
5538         * procfs.c: Fix common/ includes.
5539         * proc-api.c: Fix common/ includes.
5540         * printcmd.c: Fix common/ includes.
5541         * ppc-linux-nat.c: Fix common/ includes.
5542         * parser-defs.h: Fix common/ includes.
5543         * osdata.c: Fix common/ includes.
5544         * obsd-nat.c: Fix common/ includes.
5545         * nat/x86-linux.c: Fix common/ includes.
5546         * nat/x86-linux-dregs.c: Fix common/ includes.
5547         * nat/x86-dregs.h: Fix common/ includes.
5548         * nat/x86-dregs.c: Fix common/ includes.
5549         * nat/ppc-linux.c: Fix common/ includes.
5550         * nat/mips-linux-watch.h: Fix common/ includes.
5551         * nat/mips-linux-watch.c: Fix common/ includes.
5552         * nat/linux-waitpid.c: Fix common/ includes.
5553         * nat/linux-ptrace.h: Fix common/ includes.
5554         * nat/linux-ptrace.c: Fix common/ includes.
5555         * nat/linux-procfs.c: Fix common/ includes.
5556         * nat/linux-personality.c: Fix common/ includes.
5557         * nat/linux-osdata.c: Fix common/ includes.
5558         * nat/linux-namespaces.c: Fix common/ includes.
5559         * nat/linux-btrace.h: Fix common/ includes.
5560         * nat/linux-btrace.c: Fix common/ includes.
5561         * nat/fork-inferior.c: Fix common/ includes.
5562         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5563         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5564         * nat/aarch64-linux.c: Fix common/ includes.
5565         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5566         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5567         * namespace.h: Fix common/ includes.
5568         * mips-linux-tdep.c: Fix common/ includes.
5569         * minsyms.c: Fix common/ includes.
5570         * mi/mi-parse.h: Fix common/ includes.
5571         * mi/mi-main.c: Fix common/ includes.
5572         * mi/mi-cmd-env.c: Fix common/ includes.
5573         * memrange.h: Fix common/ includes.
5574         * memattr.c: Fix common/ includes.
5575         * maint.h: Fix common/ includes.
5576         * maint.c: Fix common/ includes.
5577         * main.c: Fix common/ includes.
5578         * machoread.c: Fix common/ includes.
5579         * location.c: Fix common/ includes.
5580         * linux-thread-db.c: Fix common/ includes.
5581         * linux-nat.c: Fix common/ includes.
5582         * linux-fork.c: Fix common/ includes.
5583         * inline-frame.c: Fix common/ includes.
5584         * infrun.c: Fix common/ includes.
5585         * inflow.c: Fix common/ includes.
5586         * inferior.h: Fix common/ includes.
5587         * inferior.c: Fix common/ includes.
5588         * infcmd.c: Fix common/ includes.
5589         * inf-ptrace.c: Fix common/ includes.
5590         * inf-child.c: Fix common/ includes.
5591         * ia64-linux-nat.c: Fix common/ includes.
5592         * i387-tdep.c: Fix common/ includes.
5593         * i386-tdep.c: Fix common/ includes.
5594         * i386-linux-tdep.c: Fix common/ includes.
5595         * i386-linux-nat.c: Fix common/ includes.
5596         * i386-go32-tdep.c: Fix common/ includes.
5597         * i386-fbsd-tdep.c: Fix common/ includes.
5598         * i386-fbsd-nat.c: Fix common/ includes.
5599         * guile/scm-type.c: Fix common/ includes.
5600         * guile/guile.c: Fix common/ includes.
5601         * go32-nat.c: Fix common/ includes.
5602         * gnu-nat.c: Fix common/ includes.
5603         * gdbthread.h: Fix common/ includes.
5604         * gdbarch-selftests.c: Fix common/ includes.
5605         * gdb_usleep.c: Fix common/ includes.
5606         * gdb_select.h: Fix common/ includes.
5607         * gdb_bfd.c: Fix common/ includes.
5608         * gcore.c: Fix common/ includes.
5609         * fork-child.c: Fix common/ includes.
5610         * findvar.c: Fix common/ includes.
5611         * fbsd-nat.c: Fix common/ includes.
5612         * event-top.c: Fix common/ includes.
5613         * event-loop.c: Fix common/ includes.
5614         * dwarf2read.c: Fix common/ includes.
5615         * dwarf2loc.c: Fix common/ includes.
5616         * dwarf2-frame.c: Fix common/ includes.
5617         * dwarf-index-cache.c: Fix common/ includes.
5618         * dtrace-probe.c: Fix common/ includes.
5619         * disasm-selftests.c: Fix common/ includes.
5620         * defs.h: Fix common/ includes.
5621         * csky-tdep.c: Fix common/ includes.
5622         * cp-valprint.c: Fix common/ includes.
5623         * cp-support.h: Fix common/ includes.
5624         * cp-support.c: Fix common/ includes.
5625         * corelow.c: Fix common/ includes.
5626         * completer.h: Fix common/ includes.
5627         * completer.c: Fix common/ includes.
5628         * compile/compile.c: Fix common/ includes.
5629         * compile/compile-loc2c.c: Fix common/ includes.
5630         * compile/compile-cplus-types.c: Fix common/ includes.
5631         * compile/compile-cplus-symbols.c: Fix common/ includes.
5632         * command.h: Fix common/ includes.
5633         * cli/cli-dump.c: Fix common/ includes.
5634         * cli/cli-cmds.c: Fix common/ includes.
5635         * charset.c: Fix common/ includes.
5636         * build-id.c: Fix common/ includes.
5637         * btrace.h: Fix common/ includes.
5638         * btrace.c: Fix common/ includes.
5639         * breakpoint.h: Fix common/ includes.
5640         * breakpoint.c: Fix common/ includes.
5641         * ax.h:
5642         (enum agent_op): Fix common/ includes.
5643         * ax-general.c (struct aop_map): Fix common/ includes.
5644         * ax-gdb.c: Fix common/ includes.
5645         * auxv.c: Fix common/ includes.
5646         * auto-load.c: Fix common/ includes.
5647         * arm-tdep.c: Fix common/ includes.
5648         * arch/riscv.c: Fix common/ includes.
5649         * arch/ppc-linux-common.c: Fix common/ includes.
5650         * arch/i386.c: Fix common/ includes.
5651         * arch/arm.c: Fix common/ includes.
5652         * arch/arm-linux.c: Fix common/ includes.
5653         * arch/arm-get-next-pcs.c: Fix common/ includes.
5654         * arch/amd64.c: Fix common/ includes.
5655         * arch/aarch64.c: Fix common/ includes.
5656         * arch/aarch64-insn.c: Fix common/ includes.
5657         * arch-utils.c: Fix common/ includes.
5658         * amd64-windows-tdep.c: Fix common/ includes.
5659         * amd64-tdep.c: Fix common/ includes.
5660         * amd64-sol2-tdep.c: Fix common/ includes.
5661         * amd64-obsd-tdep.c: Fix common/ includes.
5662         * amd64-nbsd-tdep.c: Fix common/ includes.
5663         * amd64-linux-tdep.c: Fix common/ includes.
5664         * amd64-linux-nat.c: Fix common/ includes.
5665         * amd64-fbsd-tdep.c: Fix common/ includes.
5666         * amd64-fbsd-nat.c: Fix common/ includes.
5667         * amd64-dicos-tdep.c: Fix common/ includes.
5668         * amd64-darwin-tdep.c: Fix common/ includes.
5669         * agent.c: Fix common/ includes.
5670         * ada-lang.h: Fix common/ includes.
5671         * ada-lang.c: Fix common/ includes.
5672         * aarch64-tdep.c: Fix common/ includes.
5673
5674 2019-01-25  Tom Tromey  <tom@tromey.com>
5675
5676         * common/create-version.sh: Use common/version.h.
5677
5678 2019-01-24  Pedro Alves  <palves@redhat.com>
5679
5680         * infrun.c (signal_stop, signal_print, signal_program)
5681         (signal_catch, signal_pass): Now arrays instead of pointers.
5682         (update_signals_program_target, do_target_resume)
5683         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5684         * linux-nat.c (linux_nat_target::pass_signals)
5685         (linux_nat_target::create_inferior, linux_nat_target::attach):
5686         Adjust.
5687         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5688         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5689         * procfs.c (procfs_target::pass_signals): Adjust.
5690         * record-full.c (record_full_target::resume): Adjust.
5691         * remote.c (remote_target::pass_signals)
5692         (remote_target::program_signals): Adjust.
5693         * target-debug.h (target_debug_print_signals): Now takes a
5694         gdb::array_view as parameter.  Adjust.
5695         * target.h (target_ops) <pass_signals, program_signals>: Replace
5696         pointer and length parameters with gdb::array_view.
5697         (target_pass_signals, target_program_signals): Likewise.
5698         * target-delegates.c: Regenerate.
5699
5700 2019-01-24  Pedro Alves  <palves@redhat.com>
5701
5702         * common/forward-scope-exit.h
5703         (forward_scope_exit::forward_scope_exit): Pass arguments to
5704         m_bind_function directly, instead of creating a std::bind and
5705         copying that.
5706
5707 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5708
5709         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5710         for static members.
5711         (pass_in_v_vfp_candidate): Likewise.
5712
5713 2019-01-23  Tom Tromey  <tom@tromey.com>
5714             Pedro Alves  <palves@redhat.com>
5715
5716         * regcache.c (class regcache_invalidator): Remove.
5717         (regcache::raw_write): Use make_scope_exit.
5718
5719 2019-01-23  Tom Tromey  <tom@tromey.com>
5720
5721         * ui-out.h (class ui_out_emit_type): Update comment.
5722
5723 2019-01-23  Tom Tromey  <tom@tromey.com>
5724
5725         * infrun.c (fetch_inferior_event): Update comment.
5726
5727 2019-01-23  Tom Tromey  <tom@tromey.com>
5728             Pedro Alves  <palves@redhat.com>
5729
5730         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5731         parameter.
5732         (fetch_inferior_event): Use SCOPE_EXIT.
5733
5734
5735 2019-01-23  Tom Tromey  <tom@tromey.com>
5736             Pedro Alves  <palves@redhat.com>
5737
5738         * infrun.c (disable_thread_events): Delete.
5739         (stop_all_threads): Use SCOPE_EXIT.
5740
5741 2019-01-23  Tom Tromey  <tom@tromey.com>
5742             Pedro Alves  <palves@redhat.com>
5743
5744         * symfile.c: Include forward-scope-exit.h.
5745         (clear_symtab_users_cleanup): Replace forward declaration with
5746         a FORWARD_SCOPE_EXIT.
5747         (syms_from_objfile_1): Use the forward_scope_exit and
5748         gdb::optional instead of cleanup_function.
5749         (reread_symbols): Use the forward_scope_exit instead of
5750         cleanup_function.
5751         (clear_symtab_users_cleanup): Remove function.
5752
5753 2019-01-23  Tom Tromey  <tom@tromey.com>
5754             Pedro Alves  <palves@redhat.com>
5755
5756         * linux-nat.c: Include scope-exit.h.
5757         (cleanup_target_stop): Remove.
5758         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5759         SCOPE_EXIT.
5760
5761 2019-01-23  Tom Tromey  <tom@tromey.com>
5762             Pedro Alves  <palves@redhat.com>
5763
5764         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5765         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5766
5767 2019-01-23  Tom Tromey  <tom@tromey.com>
5768             Andrew Burgess  <andrew.burgess@embecosm.com>
5769             Pedro Alves  <palves@redhat.com>
5770
5771         * infrun.c (fetch_inferior_event): Use scope_exit.
5772         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5773         * top.c (execute_command): Use scope_exit.
5774         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5775         * utils.c (do_bpstat_clear_actions_cleanup)
5776         (make_bpstat_clear_actions_cleanup): Remove.
5777
5778 2019-01-23  Tom Tromey  <tom@tromey.com>
5779             Pedro Alves  <palves@redhat.com>
5780
5781         * infrun.c: Include "common/scope-exit.h"
5782         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5783         (wait_for_inferior): Use SCOPE_EXIT.
5784         (fetch_inferior_event): Use scope_exit.
5785
5786 2019-01-23  Tom Tromey  <tom@tromey.com>
5787             Pedro Alves  <palves@redhat.com>
5788
5789         * breakpoint.c (create_breakpoint): Remove cleanup.
5790
5791 2019-01-23  Tom Tromey  <tom@tromey.com>
5792             Andrew Burgess  <andrew.burgess@embecosm.com>
5793             Pedro Alves  <palves@redhat.com>
5794
5795 2019-01-23  Pedro Alves  <palves@redhat.com>
5796
5797         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5798
5799 2019-01-23  Pedro Alves  <palves@redhat.com>
5800             Andrew Burgess  <andrew.burgess@embecosm.com>
5801
5802         * gdbthread.h: Include "common/forward-scope-exit.h".
5803         (scoped_finish_thread_state): Redefine custom class in terms of
5804         forward_scope_exit.
5805
5806 2019-01-23  Pedro Alves  <palves@redhat.com>
5807             Andrew Burgess  <andrew.burgess@embecosm.com>
5808
5809         * common/forward-scope-exit.h: New file.
5810
5811 2019-01-23  Pedro Alves  <palves@redhat.com>
5812             Andrew Burgess  <andrew.burgess@embecosm.com>
5813             Tom Tromey  <tom@tromey.com>
5814
5815         * common/scope-exit.h: New file.
5816
5817 2019-01-23  Pedro Alves  <palves@redhat.com>
5818
5819         * common/preprocessor.h (ESC): Rename to ...
5820         (ESC_PARENS): ... this.
5821         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5822         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5823
5824 2019-01-23  Tom Tromey  <tom@tromey.com>
5825
5826         * language.h (class scoped_switch_to_sym_language_if_auto):
5827         Initialize m_lang in both cases.
5828
5829 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5830
5831         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5832         with XCNEW.
5833
5834 2019-01-22  Tom Tromey  <tom@tromey.com>
5835
5836         * corelow.c: Do not include sys/file.h.
5837
5838 2019-01-22  Tom Tromey  <tom@tromey.com>
5839
5840         * tui/tui-wingeneral.h: Include gdb_curses.h.
5841
5842 2019-01-22  Tom Tromey  <tom@tromey.com>
5843
5844         * source-cache.h (class source_cache) <get_source_lines,
5845         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5846
5847 2019-01-22  Tom Tromey  <tom@tromey.com>
5848
5849         * remote-fileio.h (struct remote_target): Declare.
5850
5851 2019-01-22  Tom Tromey  <tom@tromey.com>
5852
5853         * python/py-arch.c: Do not include py-ref.h.
5854         * python/py-bpevent.c: Do not include py-ref.h.
5855         * python/py-cmd.c: Do not include py-ref.h.
5856         * python/py-continueevent.c: Do not include py-ref.h.
5857         * python/py-event.h: Do not include py-ref.h.
5858         * python/py-evtregistry.c: Do not include py-ref.h.
5859         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5860         * python/py-frame.c: Do not include py-ref.h.
5861         * python/py-framefilter.c: Do not include py-ref.h.
5862         * python/py-function.c: Do not include py-ref.h.
5863         * python/py-infevents.c: Do not include py-ref.h.
5864         * python/py-linetable.c: Do not include py-ref.h.
5865         * python/py-objfile.c: Do not include py-ref.h.
5866         * python/py-param.c: Do not include py-ref.h.
5867         * python/py-prettyprint.c: Do not include py-ref.h.
5868         * python/py-progspace.c: Do not include py-ref.h.
5869         * python/py-symbol.c: Do not include py-ref.h.
5870         * python/py-symtab.c: Do not include py-ref.h.
5871         * python/py-type.c: Do not include py-ref.h.
5872         * python/py-unwind.c: Do not include py-ref.h.
5873         * python/py-utils.c: Do not include py-ref.h.
5874         * python/py-value.c: Do not include py-ref.h.
5875         * python/py-varobj.c: Do not include py-ref.h.
5876         * python/py-xmethods.c: Do not include py-ref.h.
5877         * python/python.c: Do not include py-ref.h.
5878         * varobj.c: Do not include py-ref.h.
5879
5880 2019-01-22  Tom Tromey  <tom@tromey.com>
5881
5882         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5883         keyword for bcache.
5884
5885 2019-01-22  Tom Tromey  <tom@tromey.com>
5886
5887         * compile/compile-cplus-types.c: Remove a comment by #include.
5888
5889 2019-01-22  Tom Tromey  <tom@tromey.com>
5890
5891         * compile/gcc-c-plugin.h: Include compile-internal.h.
5892
5893 2019-01-22  Tom Tromey  <tom@tromey.com>
5894
5895         * stabsread.c (EXTERN): Do not define.
5896         (symnum, next_symbol_text_func, processing_gcc_compilation)
5897         (within_function, global_sym_chain, global_stabs)
5898         (previous_stab_code, this_object_header_files)
5899         (n_this_object_header_files)
5900         (n_allocated_this_object_header_files): Define.
5901         * stabsread.h (EXTERN): Never define.  Use "extern".
5902
5903 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5904
5905         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5906         history_value.
5907
5908 2019-01-21  Tom Tromey  <tom@tromey.com>
5909
5910         * ui-out.c: Fix includes.
5911         * tui/tui-source.c: Fix includes.
5912         * target.c: Fix includes.
5913         * remote.c: Fix includes.
5914         * regcache.c: Fix includes.
5915         * python/py-block.c: Fix includes.
5916         * printcmd.c: Fix includes.
5917         * or1k-tdep.c: Fix includes.
5918         * mi/mi-main.c: Fix includes.
5919         * m32r-tdep.c: Fix includes.
5920         * csky-tdep.c: Fix includes.
5921         * compile/compile-cplus-types.c: Fix includes.
5922         * cli/cli-interp.c: Fix includes.
5923
5924 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5925
5926         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5927         for padding.
5928
5929 2019-01-16  Tom Tromey  <tom@tromey.com>
5930
5931         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5932         earlier.
5933         (struct objfile) <msymbols_range>: Move from top level.
5934         <msymbols>: New method.
5935         (class objfile_msymbols): Remove.
5936         * symtab.c (default_collect_symbol_completion_matches_break_on):
5937         Update.
5938         * symmisc.c (dump_msymbols): Update.
5939         * stabsread.c (scan_file_globals): Update.
5940         * objc-lang.c (info_selectors_command, info_classes_command)
5941         (find_methods): Update.
5942         * minsyms.c (find_solib_trampoline_target): Update.
5943         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5944         * coffread.c (coff_symfile_read): Update.
5945         * ada-lang.c (ada_lookup_simple_minsym)
5946         (ada_collect_symbol_completion_matches): Update.
5947
5948 2019-01-16  Tom Tromey  <tom@tromey.com>
5949
5950         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5951         type.  Remove no-argument constructor.
5952         <iterator::operator++>: Simplify.
5953         <begin>: Update.
5954         <end>: Use minimal_symbol_count.
5955
5956 2019-01-16  Tom Tromey  <tom@tromey.com>
5957
5958         * objfiles.h (struct objfile) <psymtabs>: New method.
5959         (class objfile_psymtabs): Remove.
5960         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5961         typedef.
5962         <range>: New method.
5963         (require_partial_symbols): Change return type.
5964         * psymtab.c (require_partial_symbols)
5965         (psym_expand_symtabs_matching): Update.
5966         * mdebugread.c (parse_partial_symbols): Update.
5967         * dbxread.c (dbx_end_psymtab): Update.
5968
5969 2019-01-15  Tom Tromey  <tom@tromey.com>
5970
5971         * symtab.c (lookup_objfile_from_block)
5972         (lookup_symbol_in_objfile_symtabs)
5973         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5974         (find_line_symtab, info_sources_command)
5975         (default_collect_symbol_completion_matches_break_on)
5976         (make_source_files_completion_list): Update.
5977         * symmisc.c (print_objfile_statistics, dump_objfile)
5978         (maintenance_print_symbols, maintenance_info_symtabs)
5979         (maintenance_check_symtabs, maintenance_info_line_tables):
5980         Update.
5981         * source.c (select_source_symtab)
5982         (forget_cached_source_info_for_objfile): Update.
5983         * objfiles.h (class objfile_compunits): Remove.
5984         (struct objfile) <compunits_range>: New typedef.
5985         (compunits): New method.
5986         * objfiles.c (objfile_relocate1): Update.
5987         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5988         * maint.c (count_symtabs_and_blocks): Update.
5989         * linespec.c (iterate_over_all_matching_symtabs): Update.
5990         * cp-support.c (add_symbol_overload_list_qualified): Update.
5991         * coffread.c (coff_symtab_read): Update.
5992         * ada-lang.c (add_nonlocal_symbols)
5993         (ada_collect_symbol_completion_matches)
5994         (ada_add_global_exceptions): Update.
5995
5996 2019-01-15  Tom Tromey  <tom@tromey.com>
5997
5998         * progspace.h (program_space) <objfiles_safe_range>: New
5999         typedef.
6000         <objfiles_safe>: New method.
6001         * objfiles.h (class all_objfiles_safe): Remove.
6002         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6003         * jit.c (jit_inferior_exit_hook): Update.
6004
6005 2019-01-17  Tom Tromey  <tom@tromey.com>
6006
6007         * progspace.h (program_space) <objfiles_range>: New typedef.
6008         <objfiles>: New method.
6009         <objfiles_head>: Rename from objfiles.
6010         (object_files): Update.
6011         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6012         * guile/scm-pretty-print.c
6013         (ppscm_find_pretty_printer_from_objfiles): Update.
6014         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6015         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6016         Update.
6017         * python/py-progspace.c (pspy_get_objfiles): Update.
6018         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6019         Update.
6020         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6021         (objfpy_lookup_objfile_by_build_id): Update.
6022         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6023         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6024         Update.
6025         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6026         (expand_symtab_containing_pc, lookup_objfile_from_block)
6027         (lookup_static_symbol, basic_lookup_transparent_type)
6028         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6029         (find_line_symtab, info_sources_command)
6030         (default_collect_symbol_completion_matches_break_on)
6031         (make_source_files_completion_list, find_main_name): Update.
6032         * symmisc.c (print_symbol_bcache_statistics)
6033         (print_objfile_statistics, maintenance_print_symbols)
6034         (maintenance_print_msymbols, maintenance_print_objfiles)
6035         (maintenance_info_symtabs, maintenance_check_symtabs)
6036         (maintenance_expand_symtabs, maintenance_info_line_tables):
6037         Update.
6038         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6039         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6040         (map_overlay_command, unmap_overlay_command)
6041         (simple_overlay_update, expand_symtabs_matching)
6042         (map_symbol_filenames): Update.
6043         * symfile-debug.c (set_debug_symfile): Update.
6044         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6045         Update.
6046         * source.c (select_source_symtab, forget_cached_source_info):
6047         Update.
6048         * solib.c (solib_read_symbols): Update.
6049         * solib-spu.c (append_ocl_sos): Update.
6050         * psymtab.c (maintenance_print_psymbols)
6051         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6052         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6053         * printcmd.c (info_symbol_command): Update.
6054         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6055         Update.
6056         * objfiles.h (class all_objfiles): Remove.
6057         * objfiles.c (have_partial_symbols, have_full_symbols)
6058         (have_minimal_symbols, qsort_cmp, update_section_map)
6059         (shared_objfile_contains_address_p)
6060         (default_iterate_over_objfiles_in_search_order): Update.
6061         * objc-lang.c (info_selectors_command, info_classes_command)
6062         (find_methods): Update.
6063         * minsyms.c (find_solib_trampoline_target): Update.
6064         * maint.c (maintenance_info_sections)
6065         (maintenance_translate_address, count_symtabs_and_blocks):
6066         Update.
6067         * main.c (captured_main_1): Update.
6068         * linux-thread-db.c (try_thread_db_load_from_pdir)
6069         (has_libpthread): Update.
6070         * linespec.c (iterate_over_all_matching_symtabs)
6071         (search_minsyms_for_name): Update.
6072         * jit.c (jit_find_objf_with_entry_addr): Update.
6073         * hppa-tdep.c (find_unwind_entry)
6074         (hppa_lookup_stub_minimal_symbol): Update.
6075         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6076         Update.
6077         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6078         (elf_gnu_ifunc_resolve_by_got): Update.
6079         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6080         * dwarf-index-write.c (save_gdb_index_command): Update.
6081         * cp-support.c (add_symbol_overload_list_qualified): Update.
6082         * breakpoint.c (create_overlay_event_breakpoint)
6083         (create_longjmp_master_breakpoint)
6084         (create_std_terminate_master_breakpoint)
6085         (create_exception_master_breakpoint): Update.
6086         * blockframe.c (find_pc_partial_function): Update.
6087         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6088         (ada_collect_symbol_completion_matches)
6089         (ada_add_global_exceptions): Update.
6090
6091 2019-01-17  Tom Tromey  <tom@tromey.com>
6092
6093         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6094         declare VEC.
6095         (solib_target_parse_libraries): Change return type.
6096         (library_list_start_segment, library_list_start_section)
6097         (library_list_end_library, library_list_start_library); Update.
6098         (solib_target_free_library_list): Remove.
6099         (solib_target_parse_libraries): Remove cleanup.  Change return
6100         type.
6101         (solib_target_current_sos): Update.
6102
6103 2019-01-17  Tom Tromey  <tromey@bapiya>
6104
6105         * valprint.c: Replace "the the" with "the".
6106         * symtab.c: Replace "the the" with "the".
6107         * solib.c: Replace "the the" with "the".
6108         * solib-dsbt.c: Replace "the the" with "the".
6109         * linespec.c: Replace "the the" with "the".
6110         * dwarf2loc.h: Replace "the the" with "the".
6111         * amd64-windows-tdep.c: Replace "the the" with "the".
6112         * aarch64-tdep.c: Replace "the the" with "the".
6113
6114 2019-01-16  Keith Seitz  <keiths@redhat.com>
6115
6116         PR gdb/23773
6117         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6118         <builder>: Rename to ..
6119         <m_builder>: ... this and make private.
6120         (dwarf2_cu::get_builder): New method.  Change all users of
6121         `builder' to use this method.
6122         (dwarf2_start_symtab): Move to ...
6123         (dwarf2_cu::start_symtab): ... here.  Update all callers
6124         (setup_type_unit_groups): Move to ...
6125         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6126         callers.
6127         (dwarf2_cu::reset_builder): New method.
6128         (process_full_compunit, process_full_type_unit): Use
6129         dwarf2_cu::reset_builder.
6130         (follow_die_offset): Record the ancestor CU if it is different
6131         from the followed DIE's CU.
6132         (follow_die_sig_1): Likewise.
6133
6134 2019-01-15  Tom Tromey  <tom@tromey.com>
6135
6136         * remote.c (class remote_state) <buf>: Now a char_vector.
6137         <buf_size>: Remove.
6138         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6139         parameter.
6140         (remote_target::getpkt_or_notif_sane_1)
6141         (remote_target::getpkt_sane)
6142         (remote_target::getpkt_or_notif_sane): Likewise.
6143         (class remote_target) <putpkt>: New overload.
6144         (remote_target::read_frame): Change type of "buf_p".  Remove
6145         sizeof_p parameter.
6146         (packet_ok): New overload.
6147         (packet_check_result): New overload.
6148         Update all uses.
6149
6150 2019-01-14  Tom Tromey  <tom@tromey.com>
6151
6152         * remote-notif.c (handle_notification, remote_notif_ack)
6153         (remote_notif_parse): Make "buf" const.
6154         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6155         const.
6156         (remote_notif_parse, remote_notif_ack, handle_notification):
6157         Likewise.
6158         * remote.c (remote_notif_stop_parse): Make "buf" const.
6159         (remote_target::remote_parse_stop_reply): Make "buf" const.
6160         (remote_notif_stop_ack): Make "buf" const.
6161
6162 2019-01-14  Tom Tromey  <tom@tromey.com>
6163
6164         * remote.c (remote_console_output): Make parameter const.
6165
6166 2019-01-14  Tom Tromey  <tom@tromey.com>
6167
6168         * target-debug.h (target_debug_print_signals): Constify.
6169         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6170         * procfs.c (procfs_target::pass_signals): Update.
6171         * linux-nat.c (linux_nat_target::pass_signals): Update.
6172         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6173         * target-delegates.c: Rebuild.
6174         * remote.c (remote_target::program_signals): Update.
6175         (remote_target::pass_signals): Update.
6176         * target.c (target_pass_signals): Constify argument.
6177         (target_program_signals): Likewise.
6178         * target.h (struct target_ops) <pass_signals, program_signals>:
6179         Constify argument.
6180         (target_pass_signals, target_program_signals): Constify argument.
6181
6182 2019-01-14  Tom Tromey  <tom@tromey.com>
6183
6184         PR tui/28819:
6185         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6186
6187 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6188
6189         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6190         field.
6191         * rs6000-tdep.c: Include reggroups.h.
6192         (IS_V_ALIAS_PSEUDOREG): Define.
6193         (rs6000_register_name): Return names for the "vX" aliases.
6194         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6195         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6196         aliases.  Call default_register_reggroup_p for all other
6197         pseudo-registers.
6198         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6199         New functions.
6200         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6201         Handle "vX" aliases.
6202         (v_alias_pseudo_register_collect): New function.
6203         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6204         (rs6000_gdbarch_init): Initialize "vX" aliases as
6205         pseudo-registers.  Restore registration of
6206         rs6000_pseudo_register_reggroup_p with
6207         set_tdesc_pseudo_register_reggroup_p.
6208
6209 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6210
6211         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6212         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6213         set_gdbarch_num_pseudo_regs.
6214
6215 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6216
6217         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6218         Remove arg prefixname, add do_set and do_show.
6219         Add member functions set_list and show_list.
6220         * cli/cli-style.c (class cli_style_option): Update accordingly.
6221         (style_set_list): Move to file scope.
6222         (style_show_list): Likewise.
6223         (set_style): Call help_list.
6224         (show_style): Call cmd_show_list.
6225         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6226         Update to use the new macro.
6227
6228 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6229
6230         * ada-lang.c (_initialize_ada_language): Expand the help text
6231         for the "catch exception" command.
6232
6233 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6234
6235         * symtab.c (matching_obj_sections): Initialize obj,
6236         declare it closer to its usage.
6237
6238 2019-01-10  Tom Tromey  <tom@tromey.com>
6239
6240         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6241         (basic_inf_threads_range): Remove.
6242         (inf_threads_range, inf_non_exited_threads_range)
6243         (safe_inf_threads_range): Use next_adapter.
6244
6245 2019-01-10  Keith Seitz  <keiths@redhat.com>
6246
6247         PR gdb/23712
6248         PR symtab/23010
6249         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6250         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6251
6252 2019-01-10  Keith Seitz  <keiths@redhat.com>
6253
6254         PR gdb/23712
6255         PR symtab/23010
6256         * dictionary.c (pending_to_vector): Remove.
6257         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6258         Remove _1 suffix, replacing functions of the same name.  Update
6259         all callers.
6260         (dict_create_hashed, dict_create_hashed_expandable)
6261         (dict_create_linear, dict_create_linear_expandable, dict_free)
6262         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6263         Make functions static.
6264
6265 2019-01-10  Keith Seitz  <keiths@redhat.com>
6266
6267         PR gdb/23712
6268         PR symtab/23010
6269         * dictionary.h (struct dictionary): Replace declaration with
6270         multidictionary.
6271         (dict_create_hashed, dict_create_hashed_expandable)
6272         (dict_create_linear, dict_create_linear_expandable)
6273         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6274         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6275         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6276         taking multidictionary argument.
6277         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6278         * block.h (struct block) <dict>: Change to multidictionary
6279         and rename `multidict'.
6280         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6281         symmisc.c: Update all dictionary references to multidictionary.
6282
6283 2019-01-10  Keith Seitz  <keiths@redhat.com>
6284
6285         PR gdb/23712
6286         PR symtab/23010
6287         * dictionary.c: Include unordered_map.
6288         (pending_to_vector): New function.
6289         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6290         Rewrite the non-"_1" functions to take vector instead
6291         of linked list.
6292         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6293         "new" _1 versions of the same name.
6294         (multidictionary): Define.
6295         (std::hash<enum language): New definition.
6296         (collate_pending_symbols_by_language, mdict_create_hashed)
6297         (mdict_create_hashed_expandable, mdict_create_linear)
6298         (mdict_create_linear_expandable, mdict_free)
6299         (find_language_dictionary, create_new_language_dictionary)
6300         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6301         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6302         (mdict_size, mdict_empty): New functions.
6303         * dictionary.h (mdict_iterator): Define.
6304
6305 2019-01-10  Pedro Alves  <palves@redhat.com>
6306
6307         * breakpoint.c (read_uploaded_action)
6308         (create_tracepoint_from_upload): Adjust to use
6309         gdb::unique_xmalloc_ptr.
6310         * ctf.c (ctf_write_uploaded_tp):
6311         (SET_ARRAY_FIELD): Use emplace_back.
6312         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6313         * tracefile-tfile.c (tfile_write_uploaded_tp):
6314         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6315         gdb::unique_xmalloc_ptr.
6316         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6317         at_string, cond_string, cmd_strings>: Replace char pointers
6318         with gdb::unique_xmalloc_ptr.
6319
6320 2019-01-10  Pedro Alves  <palves@redhat.com>
6321
6322         * solib-target.c (library_list_start_library): Don't xstrdup name.
6323
6324 2019-01-10  Pedro Alves  <palves@redhat.com>
6325
6326         * mdebugread.c (parse_partial_symbols): Use
6327         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6328
6329 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6330
6331         * linux-fork.c (scoped_switch_fork_info)
6332         <~scoped_switch_fork_info>: Fix incorrect variable name.
6333
6334 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6335
6336         * linux-fork.c (scoped_switch_fork_info)
6337         <scoped_switch_fork_info>: Make explicit.
6338         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6339
6340 2019-01-10  Tom Tromey  <tom@tromey.com>
6341
6342         * objfiles.h (objfile::reset_psymtabs): Update.
6343         * objfiles.c (objfile::objfile): Update.
6344         * psymtab.h (psymtab_storage::obstack): Update.
6345         (psymtab_storage::m_obstack): Use gdb::optional.
6346         (class psymtab_storage): Update comment.  Remove objfile
6347         parameter.
6348         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6349
6350 2019-01-10  Tom Tromey  <tom@tromey.com>
6351
6352         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6353         <free_psymtabs>: Now private.
6354         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6355         (allocate_psymtab): Use new method.
6356
6357 2019-01-10  Tom Tromey  <tom@tromey.com>
6358
6359         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6360         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6361         * mdebugread.c (parse_partial_symbols): Use
6362         allocate_dependencies.
6363         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6364         allocate_dependencies.
6365         (process_psymtab_comp_unit_reader)
6366         (build_type_psymtab_dependencies): Likewise.
6367         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6368
6369 2019-01-10  Tom Tromey  <tom@tromey.com>
6370
6371         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6372         PSYMBOL_SET_LANGUAGE.
6373         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6374
6375 2019-01-10  Tom Tromey  <tom@tromey.com>
6376
6377         * psymtab.h (psymtab_storage::obstack): New method.
6378         <m_obstack>: Rename from obstack; now private.
6379         * psymtab.c (psymtab_storage): Update.
6380         * dwarf2read.c (create_addrmap_from_index)
6381         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6382         Update.
6383
6384 2019-01-10  Tom Tromey  <tom@tromey.com>
6385
6386         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6387         * objfiles.h (objfile::reset_psymtabs): New method.
6388
6389 2019-01-10  Tom Tromey  <tom@tromey.com>
6390
6391         * symmisc.c (print_symbol_bcache_statistics): Update.
6392         (print_objfile_statistics): Update.
6393         * symfile.c (reread_symbols): Update.
6394         * psymtab.h (class psymtab_storage): New.
6395         * psymtab.c (psymtab_storage): New constructor.
6396         (~psymtab_storage): New destructor.
6397         (require_partial_symbols): Update.
6398         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6399         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6400         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6401         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6402         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6403         (start_psymtab_common, end_psymtab_common)
6404         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6405         (allocate_psymtab): Update.
6406         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6407         Update.
6408         (dump_psymtab_addrmap, maintenance_print_psymbols)
6409         (maintenance_check_psymtabs): Update.
6410         (class objfile_psymtabs): Move to objfiles.h.
6411         * psympriv.h (discard_psymtab): Now inline.
6412         (psymtab_discarder::psymtab_discarder): Update.
6413         (psymtab_discarder::~psymtab_discarder): Update.
6414         (ALL_OBJFILE_PSYMTABS): Rewrite.
6415         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6416         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6417         Remove fields.
6418         <partial_symtabs>: New field.
6419         (class objfile_psymtabs): Move from psymtab.h.  Update.
6420         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6421         psymbol_cache.
6422         (objfile::~objfile): Don't destroy psymbol_cache.
6423         * mdebugread.c (parse_partial_symbols): Update.
6424         * dwarf2read.c (create_addrmap_from_index)
6425         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6426         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6427         (add_partial_subprogram, dwarf2_ranges_read): Update.
6428         * dwarf-index-write.c (write_address_map)
6429         (write_one_signatured_type, recursively_write_psymbols)
6430         (class debug_names, class debug_names, write_psymtabs_to_index):
6431         Update.
6432
6433 2019-01-10  Tom Tromey  <tom@tromey.com>
6434
6435         * symtab.h (SYMBOL_SET_NAMES): Update.
6436         (symbol_set_names): Update.
6437         (MSYMBOL_SET_NAMES): Update.
6438         * symtab.c (symbol_set_names): Change argument to be an
6439         objfile_per_bfd_storage.
6440         * psymtab.c (add_psymbol_to_bcache): Update.
6441         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6442
6443 2019-01-10  Tom Tromey  <tom@tromey.com>
6444
6445         * symtab.c (create_demangled_names_hash): Change argument to be an
6446         objfile_per_bfd_storage.
6447         (symbol_set_names): Update.
6448
6449 2019-01-10  Tom Tromey  <tom@tromey.com>
6450
6451         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6452         init_psymbol_list.
6453         * psymtab.c (init_psymbol_list): Do nothing if already called.
6454         * psympriv.h (init_psymbol_list): Add comment.
6455         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6456         init_psymbol_list.
6457         * dbxread.c (dbx_symfile_read): Unconditionally call
6458         init_psymbol_list.
6459
6460 2019-01-10  Tom Tromey  <tom@tromey.com>
6461
6462         * xcoffread.c (scan_xcoff_symtab): Update.
6463         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6464         "where".
6465         * mdebugread.c (parse_partial_symbols)
6466         (handle_psymbol_enumerators): Update.
6467         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6468         * dbxread.c (read_dbx_symtab): Update.
6469         * psympriv.h (psymbol_placement): New enum.
6470         (add_psymbol_to_list): Update.
6471
6472 2019-01-10  Tom Tromey  <tom@tromey.com>
6473
6474         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6475         static_psymbols parameters.
6476         (scan_xcoff_symtab): Update.
6477         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6478         static_psymbols parameters.
6479         * psympriv.h (start_psymtab_common): Update.
6480         * mdebugread.c (parse_partial_symbols): Update.
6481         * dwarf2read.c (create_partial_symtab): Update.
6482         * dbxread.c (read_dbx_symtab): Update.
6483         (start_psymtab): Remove global_psymbols and static_psymbols
6484         parameters.
6485
6486 2019-01-10  Tom Tromey  <tom@tromey.com>
6487
6488         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6489         * psymtab.c (allocate_psymtab): Add comment.
6490         * psympriv.h (allocate_psymtab): Add comment.
6491         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6492         initializations.
6493         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6494
6495 2019-01-10  Tom Tromey  <tom@tromey.com>
6496
6497         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6498         Don't declare.
6499         * mipsread.c: Include mdebugread.h.
6500         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6501         Declare.
6502         * elfread.c: Include mdebugread.h.
6503
6504 2019-01-09  Tom Tromey  <tom@tromey.com>
6505
6506         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6507         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6508         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6509         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6510         (psym_lookup_symbol, psym_find_last_source_symtab)
6511         (psym_forget_cached_source_info, psym_print_stats)
6512         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6513         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6514         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6515         (psym_find_compunit_symtab_by_address)
6516         (maintenance_print_psymbols, maintenance_info_psymtabs)
6517         (maintenance_check_psymtabs): Use ranged for.
6518         * psymtab.h (class objfile_psymtabs): New.
6519         (require_partial_symbols): Return objfile_psymtabs.
6520         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6521
6522 2019-01-09  Tom Tromey  <tom@tromey.com>
6523
6524         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6525         (find_pc_mapped_section, list_overlays_command)
6526         (map_overlay_command, unmap_overlay_command)
6527         (simple_overlay_update): Use all_objfiles.
6528         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6529         * printcmd.c (info_symbol_command): Use all_objfiles.
6530         * objfiles.h (ALL_OBJSECTIONS): Remove.
6531         * maint.c (maintenance_translate_address): Use all_objfiles.
6532         * gcore.c (gcore_create_callback): Use all_objfiles.
6533         (objfile_find_memory_regions): Likewise.
6534
6535 2019-01-09  Tom Tromey  <tom@tromey.com>
6536
6537         * symtab.c (find_line_symtab, info_sources_command)
6538         (make_source_files_completion_list): Use objfile_compunits.
6539         * source.c (select_source_symtab): Use objfile_compunits.
6540         * objfiles.h (struct objfile): Update comment.
6541         (ALL_OBJFILES): Remove.
6542         (ALL_FILETABS): Remove.
6543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6544         objfile_compunits.
6545
6546 2019-01-09  Tom Tromey  <tom@tromey.com>
6547
6548         * symmisc.c (print_objfile_statistics, dump_objfile)
6549         (maintenance_print_symbols): Use compunit_filetabs.
6550         * source.c (forget_cached_source_info_for_objfile): Use
6551         compunit_filetabs.
6552         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6553         (ALL_FILETABS): Use compunit_filetabs.
6554         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6555         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6556
6557 2019-01-09  Tom Tromey  <tom@tromey.com>
6558
6559         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6560         (compunit_filetabs): New.
6561         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6562         compunit_filetabs.
6563         (info_sources_command, make_source_files_completion_list): Remove
6564         declaration.
6565         * symmisc.c (print_objfile_statistics, dump_objfile)
6566         (maintenance_print_symbols): Remove declaration.
6567         (maintenance_info_symtabs): Use compunit_filetabs.
6568         (maintenance_info_line_tables): Likewise.
6569         * source.c (select_source_symtab): Change local variable name.
6570         (forget_cached_source_info_for_objfile): Remove declaration.
6571         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6572         * objfiles.c (objfile_relocate1): Remove declaration.
6573         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6574         declaration.
6575         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6576         * coffread.c (coff_symtab_read): Remove declaration.
6577         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6578         compunit_filetabs.
6579
6580 2019-01-09  Tom Tromey  <tom@tromey.com>
6581
6582         * symtab.c (lookup_objfile_from_block)
6583         (find_pc_sect_compunit_symtab, search_symbols)
6584         (default_collect_symbol_completion_matches_break_on): Use
6585         objfile_compunits.
6586         * objfiles.h (ALL_COMPUNITS): Remove.
6587         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6588         * cp-support.c (add_symbol_overload_list_qualified): Use
6589         objfile_compunits.
6590         * ada-lang.c (ada_collect_symbol_completion_matches)
6591         (ada_add_global_exceptions): Use objfile_compunits.
6592
6593 2019-01-09  Tom Tromey  <tom@tromey.com>
6594
6595         * source.c (select_source_symtab)
6596         (forget_cached_source_info_for_objfile): Remove declaration.
6597         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6598         declaration.
6599         * maint.c (count_symtabs_and_blocks): Remove declaration.
6600         * cp-support.c (add_symbol_overload_list_qualified): Remove
6601         declaration.
6602         * coffread.c (coff_symtab_read): Remove declaration.
6603         * symtab.c (lookup_symbol_in_objfile_symtabs)
6604         (basic_lookup_transparent_type_1): Use objfile_compunits.
6605         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6606         (info_sources_command, search_symbols)
6607         (default_collect_symbol_completion_matches_break_on)
6608         (make_source_files_completion_list): Remove declaration.
6609         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6610         (ada_collect_symbol_completion_matches)
6611         (ada_add_global_exceptions): Remove declaration.
6612         * linespec.c (iterate_over_all_matching_symtabs): Use
6613         objfile_compunits.
6614         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6615         (class objfile_compunits): New.
6616         (ALL_COMPUNITS): Use objfile_compunits.
6617         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6618         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6619         objfile_compunits.
6620         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6621
6622 2019-01-09  Tom Tromey  <tom@tromey.com>
6623
6624         * symtab.c (search_symbols)
6625         (default_collect_symbol_completion_matches_break_on): Use
6626         objfile_msymbols.
6627         * ada-lang.c (ada_lookup_simple_minsym)
6628         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6629         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6630         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6631         objfile_msymbols.
6632         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6633         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6634         * objc-lang.c (find_methods): Use objfile_msymbols.
6635         (info_selectors_command, info_classes_command): Likewise.
6636         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6637         * objfiles.h (class objfile_msymbols): New.
6638         (ALL_OBJFILE_MSYMBOLS): Remove.
6639         (ALL_MSYMBOLS): Remove.
6640
6641 2019-01-09  Tom Tromey  <tom@tromey.com>
6642
6643         * common/next-iterator.h (next_adapter): Add Iterator template
6644         parameter.
6645         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6646         (class all_objfiles_safe): New.
6647         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6648         * objfiles.c (put_objfile_before): Update comment.
6649         (add_separate_debug_objfile): Likewise.
6650         (free_all_objfiles): Use all_objfiles_safe.
6651         (objfile_purge_solibs): Likewise.
6652
6653 2019-01-09  Tom Tromey  <tom@tromey.com>
6654
6655         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6656         (expand_symtab_containing_pc, lookup_static_symbol)
6657         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6658         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6659         all_objfiles.
6660         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6661         * breakpoint.c (create_overlay_event_breakpoint)
6662         (create_longjmp_master_breakpoint)
6663         (create_std_terminate_master_breakpoint)
6664         (create_exception_master_breakpoint): Use all_objfiles.
6665         * linux-thread-db.c (try_thread_db_load_from_pdir)
6666         (has_libpthread): Use all_objfiles.
6667         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6668         * linespec.c (iterate_over_all_matching_symtabs)
6669         (search_minsyms_for_name): Use all_objfiles.
6670         * maint.c (maintenance_info_sections): Use all_objfiles.
6671         * main.c (captured_main_1): Use all_objfiles.
6672         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6673         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6674         * guile/scm-pretty-print.c
6675         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6676         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6677         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6678         (maintenance_print_msymbols): Use all_objfiles.
6679         * source.c (select_source_symtab): Use all_objfiles.
6680         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6681         * symfile.c (remove_symbol_file_command)
6682         (expand_symtabs_matching, map_symbol_filenames): Use
6683         all_objfiles.
6684         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6685         all_objfiles.
6686         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6687         * objc-lang.c (find_methods): Use all_objfiles.
6688         * objfiles.c (have_partial_symbols, have_full_symbols)
6689         (have_minimal_symbols, qsort_cmp)
6690         (default_iterate_over_objfiles_in_search_order): Use
6691         all_objfiles.
6692         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6693         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6694         (maintenance_check_psymtabs): Use all_objfiles.
6695         (ALL_PSYMTABS): Remove.
6696         * compile/compile-object-run.c (do_module_cleanup): Use
6697         all_objfiles.
6698         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6699         * cp-support.c (add_symbol_overload_list_qualified): Use
6700         all_objfiles.
6701         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6702         Use all_objfiles.
6703         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6704         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6705         all_objfiles.
6706         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6707         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6708         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6709         Uses all_objfiles.
6710         * solib.c (solib_read_symbols): Use all_objfiles
6711
6712 2019-01-09  Tom Tromey  <tom@tromey.com>
6713
6714         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6715         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6716         all_objfiles.
6717         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6718         * symmisc.c (print_symbol_bcache_statistics)
6719         (print_objfile_statistics, maintenance_print_objfiles)
6720         (maintenance_info_symtabs, maintenance_check_symtabs)
6721         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6722         all_objfiles.
6723         * source.c (forget_cached_source_info): Use all_objfiles.
6724         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6725         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6726         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6727         * objfiles.c (update_section_map): Use all_objfiles.
6728         (shared_objfile_contains_address_p): Likewise.
6729         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6730         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6731
6732 2019-01-09  Tom Tromey  <tom@tromey.com>
6733
6734         * common/next-iterator.h: New file.
6735         * objfiles.h (class all_objfiles): New.
6736         (struct objfile_iterator): New.
6737
6738 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6739
6740         * NEWS: Move the description of the changed "frame", "select-frame",
6741          and "info frame" commands to the Changed commands section.
6742
6743 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6744
6745         * gdbtypes.c (check_stub_method_group): Remove handling of old
6746         mangling schemes.
6747         * linespec.c (find_methods): Likewise.
6748         * stabsread.c (read_member_functions): Likewise.
6749         * valops.c (search_struct_method): Likewise.
6750         (value_struct_elt_for_reference): Likewise.
6751         * NEWS: Mention this change.
6752
6753 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6754
6755         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6756         print_source_lines.
6757         * source.c (print_source_lines_base): Update line number check.
6758         (print_source_lines): New function.
6759         (source_lines_range::source_lines_range): New function.
6760         * source.h (class source_lines_range): New class.
6761         (print_source_lines): New declaration.
6762
6763 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6764
6765         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6766
6767 2019-01-08  Tom Tromey  <tom@tromey.com>
6768             Simon Marchi  <simon.marchi@ericsson.com>
6769
6770         PR gdb/24060
6771         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6772         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6773         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6774         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6775         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6776         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6777
6778 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6779
6780         * source.c (select_source_symtab): Move header comment to
6781         declaration in source.h.
6782         (forget_cached_source_info_for_objfile): Likewise.
6783         (forget_cached_source_info): Likewise.
6784         (identify_source_line): Likewise.
6785         * source.h (identify_source_line): Move declaration from symtab.h
6786         and add comment from source.c
6787         (print_source_lines): Likewise.
6788         (forget_cached_source_info_for_objfile): Likewise.
6789         (forget_cached_source_info): Likewise.
6790         (select_source_symtab): Likewise.
6791         (enum print_source_lines_flag): Move definition from symtab.h.
6792         * symtab.h (identify_source_line): Move declaration to source.h.
6793         (print_source_lines): Likewise.
6794         (forget_cached_source_info_for_objfile): Likewise.
6795         (forget_cached_source_info): Likewise.
6796         (select_source_symtab): Likewise.
6797         (enum print_source_lines_flag): Move definition to source.h.
6798         * tui/tui-hooks.c: Add 'source.h' include.
6799
6800 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         * source.c (print_source_lines_base): Handle requests to print
6803         reverse line number sequences, and guard against empty lines
6804         string.
6805
6806 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * source.c (print_source_lines_base): Fix skip of '\r' if next
6809         character is '\n'.
6810
6811 2019-01-06  Tom Tromey  <tom@tromey.com>
6812
6813         * c-exp.y (struct c_parse_state) <macro_original_text,
6814         expansion_obstack>: New member.
6815         (macro_original_text, expansion_obstack): Remove globals.
6816         (scan_macro_expansion, scanning_macro_expansion)
6817         (finished_macro_expansion): Update.
6818         (scan_macro_cleanup): Remove.
6819         (yylex, c_parse): Update.
6820
6821 2019-01-06  Tom Tromey  <tom@tromey.com>
6822
6823         * c-exp.y (struct c_parse_state) <strings>: New member.
6824         (operator_stoken): Update.
6825
6826 2019-01-06  Tom Tromey  <tom@tromey.com>
6827
6828         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6829         (union type_stack_elt) <typelist_val>: Now a pointer to
6830         std::vector.
6831         (type_stack_cleanup): Don't declare.
6832         (push_typelist): Update.
6833         * parse.c (pop_typelist): Return a std::vector.
6834         (push_typelist): Take a std::vector.
6835         (follow_types): Update.  Do not free args.
6836         (type_stack_cleanup): Remove.
6837         * c-exp.y (struct c_parse_state): New.
6838         (cpstate): New global.
6839         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6840         (nonempty_typelist): Update.
6841         (func_mod): Create a new vector.
6842         (c_parse): Create a c_parse_state.
6843         (check_parameter_typelist): Do not delete params.
6844         (function_method): Update.  Do not delete type_list.
6845
6846 2019-01-06  Tom Tromey  <tom@tromey.com>
6847
6848         PR gdb/28155:
6849         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6850         check_typedef.
6851         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6852         (print_return_value): Likewise.
6853
6854 2019-01-05  Tom Tromey  <tom@tromey.com>
6855
6856         * contrib/cleanup_check.py: Remove.
6857         * contrib/gcc-with-excheck: Remove.
6858         * contrib/exsummary.py: Remove.
6859         * contrib/excheck.py: Remove.
6860
6861 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6862
6863         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6864         NULL. Initialize tpprev to NULL instead of assigning it
6865         to NULL on the next statement.
6866         * windows-nat.c (windows_delete_thread): Remove check for
6867         main_thread_id before printing thread exit notifications.
6868         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6869         Remove thread ID check against main_thread_id.
6870         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6871         windows_delete_thread.
6872         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6873
6874 2019-01-04  Tom Tromey  <tom@tromey.com>
6875
6876         * compile/compile.c (_initialize_compile): Use upper case for
6877         metasyntactic variables.
6878         * symmisc.c (_initialize_symmisc): Use upper case for
6879         metasyntactic variables.
6880         * psymtab.c (_initialize_psymtab): Use upper case for
6881         metasyntactic variables.
6882         * demangle.c (demangle_command): Use upper case for metasyntactic
6883         variables.
6884         (_initialize_demangler): Likewise.
6885         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6886         variables.
6887
6888 2019-01-03  Tom Tromey  <tom@tromey.com>
6889
6890         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6891
6892 2019-01-03  Tom Tromey  <tom@tromey.com>
6893
6894         * python/py-symtab.c (salpy_str): Update.
6895         (struct salpy_sal_object) <symtab>: Now a PyObject.
6896         (salpy_dealloc): Update.
6897         (del_objfile_sal): Use gdbpy_ref.
6898
6899 2019-01-03  Tom Tromey  <tom@tromey.com>
6900
6901         * python/py-type.c (convert_field): Use new_reference.  Return
6902         gdbpy_ref.
6903         (make_fielditem): Return gdbpy_ref.
6904         (typy_fields): Update.
6905         (typy_getitem): Update.
6906         (field_name): Return gdbpy_ref.  Use new_reference.
6907         (typy_iterator_iternext): Update.
6908
6909 2019-01-03  Tom Tromey  <tom@tromey.com>
6910
6911         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6912
6913 2019-01-03  Tom Tromey  <tom@tromey.com>
6914
6915         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6916         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6917         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6918         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6919         (pspy_set_type_printers): Likewise.
6920         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6921         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6922         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6923         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6924         (objfpy_set_type_printers): Likewise.
6925
6926 2019-01-03  Tom Tromey  <tom@tromey.com>
6927
6928         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6929         (gdbpy_print_stack): Use gdbpy_err_fetch.
6930         * python/python-internal.h (class gdbpy_err_fetch): New class.
6931         (class gdbpy_enter) <m_error_type, m_error_value,
6932         m_error_traceback>: Remove.
6933         <m_error>: New member.
6934         (gdbpy_exception_to_string): Don't declare.
6935         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6936         * python/py-value.c (convert_value_from_python): Use
6937         gdbpy_err_fetch.
6938         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6939         gdbpy_exception_to_string.
6940         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6941         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6942         gdbpy_err_fetch.
6943
6944 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6945
6946         * linux-nat.c (delete_lwp_cleanup): Delete.
6947         (struct lwp_deleter): New struct.
6948         (lwp_info_up): New typedef.
6949         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6950         lwp_info_up.
6951
6952 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6953
6954         * linux-fork.c (class scoped_switch_fork_info): New class.
6955         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6956
6957 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6958
6959         * valops.c (find_overload_match): Remove use of null_cleanup, and
6960         calls to do_cleanups.
6961
6962 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6963
6964         * compile/compile-cplus-types.c
6965         (compile_cplus_instance::decl_name): Handle changes to
6966         cp_func_name.
6967         * cp-support.c (cp_func_name): Update header comment, update
6968         return type.
6969         * cp-support.h (cp_func_name): Update return type in declaration.
6970         * valops.c (find_overload_match): Move temp_func local to top
6971         level of function and change its type.  Use temp_func to hold and
6972         delete temporary string obtained from cp_func_name.
6973
6974 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6975
6976         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6977         gdb::char_vector, remove cleanup, and update uses of `msg`.
6978
6979 2019-01-03  Jim Wilson  <jimw@sifive.com>
6980
6981         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6982
6983 2019-01-02  Tom Tromey  <tom@tromey.com>
6984
6985         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6986         (tdesc_parse_xml): Remove cleanups.
6987         * target-descriptions.h (make_cleanup_free_target_description):
6988         Don't declare.
6989         (target_desc_deleter): New struct.
6990         (target_desc_up): New typedef.
6991         * target-descriptions.c (target_desc_deleter::operator()): Rename
6992         from free_target_description.
6993         (make_cleanup_free_target_description): Remove.
6994
6995 2019-01-02  Tom Tromey  <tom@tromey.com>
6996
6997         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6998         constructor, destructor.
6999         (linespec_parser): Remove typedef.
7000         (~linespec_parser): Rename from linespec_parser_delete.
7001         (linespec_lex_to_end, linespec_complete_label)
7002         (linespec_complete): Update.
7003         (decode_line_full): Remove cleanups.
7004         (decode_line_1): Update.
7005
7006 2019-01-02  Tom Tromey  <tom@tromey.com>
7007
7008         * python/python-internal.h (inferior_to_inferior_object): Change
7009         return type.
7010         * python/py-exitedevent.c (create_exited_event_object): Update.
7011         * python/py-inferior.c (inferior_to_inferior_object): Return
7012         gdbpy_ref.
7013         (python_new_inferior, python_inferior_deleted)
7014         (thread_to_thread_object, delete_thread_object)
7015         (build_inferior_list, gdbpy_selected_inferior): Update.
7016         * python/py-infthread.c (create_thread_object): Update.  Also fail
7017         if inferior_to_inferior_object fails.
7018
7019 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7020
7021         * inferior.h (class inferior) <displaced_step_state>: New field.
7022         * infrun.h (struct displaced_step_state): Move here from
7023         infrun.c.  Initialize fields, add constructor.
7024         <inf>: Remove field.
7025         <reset>: New method.
7026         * infrun.c (struct displaced_step_inferior_state): Move to
7027         infrun.h.
7028         (displaced_step_inferior_states): Remove.
7029         (get_displaced_stepping_state): Adust.
7030         (displaced_step_in_progress_any_inferior): Adjust.
7031         (displaced_step_in_progress_thread): Adjust.
7032         (displaced_step_in_progress): Adjust.
7033         (add_displaced_stepping_state): Remove.
7034         (get_displaced_step_closure_by_addr): Adjust.
7035         (remove_displaced_stepping_state): Remove.
7036         (infrun_inferior_exit): Call displaced_step_state.reset.
7037         (use_displaced_stepping): Don't check for NULL.
7038         (displaced_step_prepare_throw): Call
7039         get_displaced_stepping_state.
7040         (displaced_step_fixup): Don't check for NULL.
7041         (prepare_for_detach): Don't check for NULL.
7042
7043 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7044
7045         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7046          in case of call that did not complete.
7047
7048 2019-01-02  Andrey Utkin  <autkin@undo.io>
7049
7050         * symfile.c (find_separate_debug_file): Fix search of debug files for
7051         remote debuggee.
7052
7053 2019-01-02  Tom Tromey  <tom@tromey.com>
7054
7055         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7056         indentation.
7057         * python/py-frame.c (frapy_older): Remove cast.
7058         (frapy_newer): Likewise.
7059         * python/py-breakpoint.c (local_setattro): Remove cast.
7060         * python/py-arch.c (archpy_name): Remove local variable.
7061         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7062
7063 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7064
7065         * unittests/basic_string_view/element_access/char/empty.cc:
7066         Fix year range in copyright header.
7067
7068 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7069
7070         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7071         Delete.
7072         <operator==>: Update with for removed field.
7073         <hash>: Likewise.
7074         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7075         <isa_features>: ...this.
7076         <abi_features>: New field.
7077         (riscv_isa_flen): Update comment.
7078         (riscv_abi_xlen): New declaration.
7079         (riscv_abi_flen): New declaration.
7080         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7081         isa_features.
7082         (riscv_abi_xlen): New function.
7083         (riscv_isa_flen): Update to get answer from isa_features.
7084         (riscv_abi_flen): New function.
7085         (riscv_has_fp_abi): Update to get answer from abi_features.
7086         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7087         xlen and flen.
7088         (riscv_call_info) <xlen, flen>: Update comment.
7089         (riscv_call_arg_struct): Remove invalid assertions
7090         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7091         is removed.
7092         (riscv_gdbarch_init): Gather isa features and abi features
7093         separately, ensure both match on the gdbarch when reusing an old
7094         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7095         a target with 64-bit float hardware.
7096
7097 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7098
7099         * source.c (search_command_helper): Stop reverse search
7100         when line 1 has been searched.
7101
7102 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7103
7104         * record-full.c (record_full_base_target::close): Rewrite
7105         record_full_core_buf_list free logic.
7106
7107 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7108
7109         * break-catch-syscall.c (print_one_catch_syscall): xfree
7110         the last text.
7111
7112 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7113
7114         * top.c (print_gdb_version): Update Copyright year in version
7115         message.
7116
7117 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7118
7119         Update copyright year range in all GDB files.
7120
7121 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7122
7123         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7124
7125 For older changes see ChangeLog-2018.
7126 \f
7127 Local Variables:
7128 mode: change-log
7129 left-margin: 8
7130 fill-column: 74
7131 version-control: never
7132 coding: utf-8
7133 End:
7134