gdb/ChangeLog

   1 2018-10-08  Weimin Pan  <weimin.pan@oracle.com>
   2
   3         PR c++/16841
   4         * valops.c (get_virtual_base_offset): New function.
   5         (value_struct_elt_for_reference): Use it to get virtual base offset
   6         and add it in calculating class member address.
   7
   8 2018-10-08   John Darrington <john@darrington.wattle.id.au>
   9
  10     * dwarf2read.c (dwarf2_cu) <producer_is_codewarrior>: New field.
  11       (check_producer): Check if the producer is codewarrior.
  12       (producer_is_codewarrior): New function.
  13       (lnp_state_machine::record_line): Ignore is_stmt flag for records
  14        produced by codewarrior.
  15       (dwarf2_cu::dwarf2_cu): Initialize producer_is_codewarrior.
  16
  17 2018-10-06  Tom Tromey  <tom@tromey.com>
  18
  19         PR python/19399:
  20         * python/py-inferior.c: Add "architecture" entry.
  21         (infpy_architecture): New function.
  22
  23 2018-10-06  Tom Tromey  <tom@tromey.com>
  24
  25         PR python/21765:
  26         * python/py-symbol.c (gdbpy_initialize_symbols): Redefine
  27         SYMBOL_VARIABLES_DOMAIN, SYMBOL_FUNCTIONS_DOMAIN,
  28         SYMBOL_TYPES_DOMAIN.  Define SYMBOL_MODULE_DOMAIN,
  29         SYMBOL_COMMON_BLOCK_DOMAIN, SYMBOL_LOC_COMMON_BLOCK.
  30
  31 2018-10-06  Tom Tromey  <tom@tromey.com>
  32
  33         PR build/17077:
  34         * Makefile.in (OPCODES_CFLAGS): Remove "-I$(OPCODES_SRC)/..".
  35         * arc-tdep.c, frv-tdep.c, lm32-tdep.c, mep-tdep.c,
  36         microblaze-tdep.c, or1k-tdep.h: Use ../opcodes, not opcodes, in
  37         #include.
  38
  39 2018-10-06  Tom Tromey  <tom@tromey.com>
  40
  41         * python/py-breakpoint.c (bppy_get_location): Handle a
  42         bp_breakpoint without a location.
  43
  44 2018-10-06  Tom Tromey  <tom@tromey.com>
  45
  46         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq)
  47         (_RegEx): Reformat help text.
  48         * python/lib/gdb/function/caller_is.py (CallerIs, CallerMatches)
  49         (AnyCallerIs, AnyCallerMatches): Reformat help text.
  50         * python/lib/gdb/function/as_string.py (_AsString): Reformat help
  51         text.
  52         * python/lib/gdb/command/xmethods.py (InfoXMethod)
  53         (EnableXMethod, DisableXMethod): Remove help indentation.
  54         Capitalize meta-syntactic variables.
  55         * python/lib/gdb/command/unwinders.py (InfoUnwinder)
  56         (EnableUnwinder, DisableUnwinder): Remove help indentation.
  57         Capitalize meta-syntactic variables.
  58         * python/lib/gdb/command/explore.py (ExploreCommand)
  59         (ExploreValueCommand, ExploreTypeCommand): Reformat help text.
  60         * python/lib/gdb/command/type_printers.py (InfoTypePrinter)
  61         (EnableTypePrinter, DisableTypePrinter): Remove help indentation.
  62         * python/lib/gdb/command/pretty_printers.py (InfoPrettyPrinter):
  63         Remove help indentation.
  64         (EnablePrettyPrinter, DisablePrettyPrinter): Likewise.
  65         * python/lib/gdb/command/frame_filters.py (EnableFrameFilter)
  66         (DisableFrameFilter, SetFrameFilterPriority)
  67         (ShowFrameFilterPriority, InfoFrameFilter): Reword help text.
  68
  69 2018-10-06  Tom Tromey  <tom@tromey.com>
  70
  71         PR tui/28819:
  72         * tui/tui-io.c (gdb_wgetch): New function.
  73         (tui_mld_getc, tui_getc): Use it.
  74
  75 2018-10-05  Tom Tromey  <tom@tromey.com>
  76
  77         * sol-thread.c (sol_thread_target::wait): Rename inner
  78         "save_ptid".
  79
  80 2018-10-04  Tom Tromey  <tom@tromey.com>
  81
  82         * configure: Rebuild.
  83         * warning.m4 (AM_GDB_WARNINGS): Add -Wshadow=local.
  84
  85 2018-10-04  Tom Tromey  <tom@tromey.com>
  86
  87         * guile/scm-frame.c (gdbscm_frame_read_var): Remove inner
  88         declaration of "block".
  89
  90 2018-10-04  Tom Tromey  <tom@tromey.com>
  91
  92         * common/filestuff.c (fdwalk): Remove inner declaration of
  93         "result".
  94
  95 2018-10-04  Tom Tromey  <tom@tromey.com>
  96
  97         * msp430-tdep.c (msp430_push_dummy_call): Rename inner
  98         "structs_addr" and hoist declaration.
  99
 100 2018-10-04  Tom Tromey  <tom@tromey.com>
 101
 102         * linux-tdep.c (linux_make_mappings_corefile_notes): Introduce new
 103         variable "size".
 104
 105 2018-10-04  Tom Tromey  <tom@tromey.com>
 106
 107         * mdebugread.c (parse_partial_symbols): Use std::string.
 108
 109 2018-10-04  Tom Tromey  <tom@tromey.com>
 110
 111         * ctf.c (SET_ARRAY_FIELD): Rename "u32".
 112         * p-valprint.c (pascal_val_print): Split inner "i" variable.
 113         * xtensa-tdep.c (xtensa_push_dummy_call): Declare "i" in loop
 114         header.
 115         * xstormy16-tdep.c (xstormy16_push_dummy_call): Declare "val" in
 116         more inner scope.
 117         * xcoffread.c (read_xcoff_symtab): Rename inner "symbol".
 118         * varobj.c (varobj_update): Rename inner "newobj",
 119         "type_changed".
 120         * valprint.c (generic_emit_char): Rename inner "buf".
 121         * valops.c (find_overload_match): Rename inner "temp".
 122         (value_struct_elt_for_reference): Declare "v" in more inner
 123         scope.
 124         * v850-tdep.c (v850_push_dummy_call): Rename "len".
 125         * unittests/array-view-selftests.c (run_tests): Rename inner
 126         "vec".
 127         * tui/tui-stack.c (tui_show_frame_info): Declare "i" in loop
 128         header.
 129         * tracepoint.c (merge_uploaded_trace_state_variables): Declare
 130         "tsv" in more inner scope.
 131         (print_one_static_tracepoint_marker): Rename inner
 132         "tuple_emitter".
 133         * tic6x-tdep.c (tic6x_analyze_prologue): Declare "inst" lower.
 134         (tic6x_push_dummy_call): Don't redeclare "addr".
 135         * target-float.c: Declare "dto" lower.
 136         * symtab.c (lookup_local_symbol): Rename inner "sym".
 137         (find_pc_sect_line): Rename inner "pc".
 138         * stack.c (print_frame): Don't redeclare "gdbarch".
 139         (return_command): Rename inner "gdbarch".
 140         * s390-tdep.c (s390_prologue_frame_unwind_cache): Renam inner
 141         "sp".
 142         * rust-lang.c (rust_internal_print_type): Declare "i" in loop
 143         header.
 144         * rs6000-tdep.c (ppc_process_record): Rename inner "addr".
 145         * riscv-tdep.c (riscv_push_dummy_call): Declare "info" in inner
 146         scope.
 147         * remote.c (remote_target::update_thread_list): Don't redeclare
 148         "tp".
 149         (remote_target::process_initial_stop_replies): Rename inner
 150         "thread".
 151         (remote_target::remote_parse_stop_reply): Don't redeclare "p".
 152         (remote_target::wait_as): Don't redeclare "stop_reply".
 153         (remote_target::get_thread_local_address): Rename inner
 154         "result".
 155         (remote_target::get_tib_address): Likewise.
 156
 157         * regcache.c (cooked_read_test): Rename "regnum".
 158         * record-btrace.c (cmd_record_btrace_start): Rename inner
 159         "exception".
 160         * ppc-sysv-tdep.c (ppc64_sysv_abi_return_value): Declare "i" in
 161         loop header.
 162         * ppc-linux-tdep.c (ppc_linux_syscall_record): Declare "i" in loop
 163         header.
 164         (ppu2spu_sniffer): Rename inner "buf".
 165         * parse.c (operator_check_standard): Rename inner "type",
 166         "objfile".
 167         * p-valprint.c (pascal_val_print): Introduce new scope for
 168         "low_bound", "high_bound".
 169         * p-exp.y (yylex): Declare "i" in loop header.
 170         * objfiles.c (objfile_relocate1): Declare "i" in loop header.
 171         Lower declaration of "s".
 172         * nios2-tdep.c (nios2_analyze_prologue): Declare "i" in loop
 173         header.
 174         (nios2_push_dummy_call): Rename "len".
 175         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Rename static
 176         "buf".
 177         (linux_xfer_osdata_fds, linux_xfer_osdata_shm)
 178         (linux_xfer_osdata_sem, linux_xfer_osdata_msg)
 179         (linux_xfer_osdata_modules): Likewise.
 180         * mips-tdep.c (mips_eabi_push_dummy_call): Rename outer "len".
 181         (mips_n32n64_push_dummy_call, mips_o32_push_dummy_call)
 182         (mips_o64_push_dummy_call): Likewise.
 183         * microblaze-tdep.c (microblaze_analyze_prologue): Rename inner
 184         "op".
 185         * mi/mi-main.c (list_available_thread_groups): Rename inner
 186         "tuple_emitter".
 187         (mi_cmd_data_read_memory): Rename inner "opts".
 188         * mi/mi-cmd-var.c (varobj_update_one): Rename inner
 189         "tuple_emitter".
 190         * mep-tdep.c (mep_analyze_prologue): Declare "rn" in loop header.
 191         * mdebugread.c (parse_symbol): Rename inner "b".  Declare "f" in
 192         more inner scope.
 193         (parse_partial_symbols): Rename inner "pst", "p", "name"
 194         * main.c (captured_main_1): Rename inner "i"s.
 195         * machoread.c (macho_symfile_read_all_oso): Don't redeclare
 196         "oso2".
 197         * linux-tdep.c (linux_info_proc): Rename inner "filename".
 198         * linespec.c (linespec_lexer_lex_string): Rename inner "p".
 199         * infrun.c (handle_no_resumed): Don't redeclare "thread".
 200         (handle_signal_stop): Rename inner "gdbarch".
 201         (handle_command): Declare "signum" in loop header.
 202         * ia64-tdep.c (ia64_pseudo_register_read): Don't redeclare
 203         "status".
 204         (examine_prologue): Rename inner "sol" and "sof".
 205         (ia64_extract_return_value): Rename inner "val".  Declare another
 206         "val" in a more inner scope.
 207         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Declare "buf" in
 208         inner scope.
 209         * guile/scm-symbol.c (gdbscm_lookup_symbol): Rename inner
 210         "except".
 211         * findvar.c (default_read_var_value): Don't redeclare "addr".
 212         * f-exp.y (yylex): Declare "i" in loop header.
 213         * eval.c (evaluate_subexp_standard): Don't redeclare "type".
 214         Rename inner "type", "expect_type".
 215         (evaluate_subexp_for_sizeof): Rename inner "pc".
 216         * elfread.c (elf_symfile_read): Rename inner "abfd".
 217         * dwarf2read.c (read_debug_names_from_section): Don't redeclare
 218         "bytes_read".
 219         (process_psymtab_comp_unit_reader): Don't redeclare "gdbarch".
 220         (add_partial_subprogram): Rename inner "lowpc" and "highpc".
 221         (dwarf_decode_line_header): Rename inner "lh".
 222         * dwarf2loc.c (dwarf2_compile_expr_to_ax): Don't redeclare
 223         "offset".  Declare "i" in loop header.
 224         (disassemble_dwarf_expression): Rename inner "addr_size".
 225         * dwarf2expr.c (dwarf_expr_context::execute_stack_op): Rename
 226         inner "result".
 227         (dwarf_expr_context::execute_stack_op): Rename inner "offset".
 228         * dwarf2-frame.c (decode_frame_entry_1): Rename inner "length"s.
 229         * disasm.c (do_mixed_source_and_assembly_deprecated): Rename inner
 230         "inner_list_emitter".
 231         (do_mixed_source_and_assembly): Rename inner "tuple_emitter".
 232         * disasm-selftests.c (print_one_insn_test): Wrap "bplen"
 233         declaration in a block.
 234         * csky-tdep.c (csky_analyze_prologue): Declare "offset" lower.
 235         * cp-valprint.c (cp_print_value_fields): Don't redeclare
 236         "obstack_final_size".
 237         * cp-support.c (inspect_type): Declare "i" in loop header.
 238         * compile/compile.c (compile_instance::insert_symbol_error):
 239         Rename inner "e".
 240         * common/agent.c (agent_run_command): Remove inner "ret"
 241         declaration.
 242         * coffread.c (coff_symfile_read): Rename inner "name".
 243         (coff_symfile_read): Rename inner "abfd".
 244         * cli/cli-utils.c (get_number_trailer): Rename inner "val".
 245         * cli/cli-cmds.c (print_disassembly): Rename inner "low" and
 246         "high".
 247         * c-exp.y (lex_one_token): Move "len" declaration lower.
 248         * breakpoint.c (create_longjmp_master_breakpoint): Don't redeclare
 249         "gdbarch".
 250         (create_exception_master_breakpoint): Likewise.  Don't redeclare
 251         "b".
 252         (watch_command_1): Declare "mark" later.
 253         (clear_command): Don't shadow "a" or "b".
 254         (delete_command): Rename inner "b".
 255         (delete_trace_command): Likewise.
 256         * arm-tdep.c (thumb_process_displaced_32bit_insn): Rename inner
 257         "op".
 258         (arm_gdbarch_init): Remove inner "e_flags".
 259         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Declare
 260         "offset" in inner blocks.
 261
 262 2018-10-04  Simon Marchi  <simon.marchi@ericsson.com>
 263
 264         * dwarf-index-write.c (file_write): Don't write if the vector is
 265         empty.
 266
 267 2018-10-05  Tom de Vries  <tdevries@suse.de>
 268
 269         * python/py-progspace.c (pspy_solib_name): Fix type mismatch in
 270         PyArg_ParseTuple call.
 271
 272 2018-10-05  Tom de Vries  <tdevries@suse.de>
 273
 274         * python/py-record-btrace.c (recpy_bt_goto): Fix type mismatch in
 275         PyArg_ParseTuple call.
 276
 277 2018-10-04  Joel Brobecker  <brobecker@adacore.com>
 278
 279         * psymtab.c (recursively_search_psymtabs): Reformat parameters
 280         to avoid exceeding 80 characters per line limit.
 281
 282 2018-10-04  Tom Tromey  <tom@tromey.com>
 283
 284         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 285         (reread_symbols): Update.
 286         * complaints.h (clear_complaints): Remove argument.
 287         * complaints.c (enum complaint_series): Remove.
 288         (series): Remove global.
 289         (complaint_internal): Update.
 290         (clear_complaints): Remove argument.
 291
 292 2018-10-04  Tom Tromey  <tom@tromey.com>
 293
 294         * symfile.c (symbol_file_add_with_addrs): Do not print "no
 295         debugging symbols" message if there is a separate debug objfile.
 296
 297 2018-10-04  Tom Tromey  <tom@tromey.com>
 298
 299         PR cli/19551:
 300         * symfile.c (symbol_file_add_with_addrs): Update output.
 301         * psymtab.c (require_partial_symbols): Update output.
 302
 303 2018-10-04  Tom Tromey  <tom@tromey.com>
 304
 305         PR cli/22234:
 306         * complaints.c: Emit \n.
 307
 308 2018-10-04  Tom Tromey  <tom@tromey.com>
 309
 310         * symfile.c (symbol_file_add_with_addrs, symbol_file_clear)
 311         (separate_debug_file_exists, find_separate_debug_file)
 312         (add_symbol_file_command, reread_symbols, allocate_symtab)
 313         (allocate_compunit_symtab): Use filtered printing, not
 314         unfiltered.
 315         * psymtab.c (require_partial_symbols, dump_psymtab)
 316         (allocate_psymtab): Use filtered printing, not unfiltered.
 317
 318 2018-10-04  Tom Tromey  <tom@tromey.com>
 319
 320         * complaints.c (complaint_internal): Correctly check complaint
 321         count.
 322
 323 2018-10-04  Tom Tromey  <tom@tromey.com>
 324
 325         * complaints.h (struct complaints): Remove declaration.
 326         * complaints.c (clear_complaints): Remove an unused variable.
 327
 328 2018-10-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 329
 330         * MAINTAINERS (Write After Approval): Add self.
 331
 332 2018-10-03  Tom Tromey  <tom@tromey.com>
 333
 334         * guile/scm-value.c (gdbscm_value_to_string): Initialize
 335         "buffer_contents".
 336         * coffread.c (coff_symtab_read): Initialize "newobj".
 337
 338 2018-10-03  Simon Marchi  <simon.marchi@polymtl.ca>
 339
 340         * dwarf2read.c (read_func_scope): Remove struct keyword in
 341         range-based for.
 342
 343 2018-10-03  Tom Tromey  <tom@tromey.com>
 344
 345         * README: Mention --enable-ubsan.
 346         * NEWS: Mention --enable-ubsan.
 347         * acinclude.m4: Include sanitize.m4.
 348         * configure: Rebuild.
 349         * configure.ac: Call AM_GDB_UBSAN.
 350         * sanitize.m4: New file.
 351
 352 2018-10-03  Tom Tromey  <tom@tromey.com>
 353
 354         * expression.h (enum exp_opcode): Use uint8_t as base type.
 355         * expprint.c (op_name): Handle invalid opcodes.
 356
 357 2018-10-03  Tom Tromey  <tom@tromey.com>
 358
 359         * parse.c (prefixify_expression): Add assert.
 360         (parse_exp_in_context_1): Throw exception if the expression is
 361         empty.
 362
 363 2018-10-03  Tom Tromey  <tom@tromey.com>
 364
 365         * dwarf2read.c (read_signed_leb128): Work in ULONGEST.
 366
 367 2018-10-03  Tom Tromey  <tom@tromey.com>
 368
 369         * c-exp.y (parse_number): Work in unsigned.  Remove casts.
 370
 371 2018-10-03  Tom Tromey  <tom@tromey.com>
 372
 373         * dwarf2read.c (read_subrange_type): Make "negative_mask"
 374         unsigned.
 375
 376 2018-10-03  Tom Tromey  <tom@tromey.com>
 377
 378         * findvar.c (extract_integer): Do work in an unsigned type.
 379
 380 2018-10-03  Tom Tromey  <tom@tromey.com>
 381
 382         * common/enum-flags.h (enum_flags::operator~): Add static assert.
 383         * symfile-add-flags.h (enum symfile_add_flag): Use unsigned as
 384         base type.
 385         * objfile-flags.h (enum objfile_flag): Use unsigned as base type.
 386         * gdbtypes.h (enum type_instance_flag_value): Use unsigned as base
 387         type.
 388         * c-lang.h (enum c_string_type_values): Use unsigned as base
 389         type.
 390         * btrace.h (enum btrace_thread_flag): Use unsigned as base type.
 391
 392 2018-10-03  Tom Tromey  <tom@tromey.com>
 393
 394         * dwarf2-frame.h (dwarf2_frame_state_reg_info)
 395         <~dwarf2_frame_state_reg_info>: Update.
 396         <dwarf2_frame_state_reg_info>: Update.
 397         <alloc_regs>: Add assertion.  Update.
 398         <reg>: Now a std::vector.
 399         <num_regs>: Remove.
 400         <swap>: Update.
 401         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
 402         (execute_cfa_program_test, dwarf2_frame_cache): Update.
 403
 404 2018-10-03  Tom Tromey  <tom@tromey.com>
 405
 406         * namespace.c (add_using_directive): Don't pass NULL to memcpy.
 407
 408 2018-10-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 409
 410         * tid-parse.c (tid_is_in_list): Fix wrong 'See' comment.
 411
 412 2018-10-02  Tom Tromey  <tom@tromey.com>
 413
 414         * aarch64-linux-tdep.c (aarch64_linux_sigframe_init): Use pulongest.
 415
 416 2018-10-02  John Darrington <john@darrington.wattle.id.au>
 417
 418         * NEWS: Mention changed commands.
 419         * ser-uds.c: New file.
 420         * configure.ac (SER_HARDWIRE): Add ser-uds.o.
 421         * configure: Regenerate.
 422         * Makefile.in: Add new file.
 423         * serial.c (serial_open): Check if filename is a socket
 424           and lookup the appropriate interface accordingly.
 425
 426 2018-10-01  Alan Hayward  <alan.hayward@arm.com>
 427
 428         * aarch64-linux-tdep.c (AARCH64_SIGCONTEXT_RESERVED_OFFSET): Add
 429         define.
 430         (AARCH64_EXTRA_MAGIC): Likewise.
 431         (AARCH64_FPSIMD_MAGIC): Likewise.
 432         (AARCH64_SVE_MAGIC): Likewise.
 433         (AARCH64_EXTRA_DATAP_OFFSET): Likewise.
 434         (AARCH64_FPSIMD_FPSR_OFFSET): Likewise.
 435         (AARCH64_FPSIMD_FPCR_OFFSET): Likewise.
 436         (AARCH64_FPSIMD_V0_OFFSET): Likewise.
 437         (AARCH64_FPSIMD_VREG_SIZE): Likewise.
 438         (AARCH64_SVE_CONTEXT_VL_OFFSET): Likewise.
 439         (AARCH64_SVE_CONTEXT_REGS_OFFSET): Likewise.
 440         (AARCH64_SVE_CONTEXT_P_REGS_OFFSET): Likewise.
 441         (AARCH64_SVE_CONTEXT_FFR_OFFSET): Likewise.
 442         (AARCH64_SVE_CONTEXT_SIZE): Likewise.
 443         (read_aarch64_ctx): Add function.
 444         (aarch64_linux_sigframe_init): Detect FP registers.
 445
 446 2018-10-01  Alan Hayward  <alan.hayward@arm.com>
 447
 448         * aarch64-tdep.c (AARCH64_Q0_REGNUM): Move to here.
 449         (AARCH64_D0_REGNUM): Likewise.
 450         (AARCH64_S0_REGNUM): Likewise.
 451         (AARCH64_H0_REGNUM): Likewise.
 452         (AARCH64_B0_REGNUM): Likewise.
 453         (AARCH64_SVE_V0_REGNUM): Likewise.
 454         * arch/aarch64.h (AARCH64_Q0_REGNUM): Move from here.
 455         (AARCH64_D0_REGNUM): Likewise.
 456         (AARCH64_S0_REGNUM): Likewise.
 457         (AARCH64_H0_REGNUM): Likewise.
 458         (AARCH64_B0_REGNUM): Likewise.
 459         (AARCH64_SVE_V0_REGNUM): Likewise.
 460
 461 2018-10-01  Gary Benson <gbenson@redhat.com>
 462
 463         * gdb_proc_service.h (gdb_prfpregset_t): Remove typedef.
 464         * proc-service.c (ps_lgetfpregs, ps_lsetfpregs): Use
 465         prfpregset_t instead of gdb_prfpregset_t.
 466         * configure.ac (PRFPREGSET_T_BROKEN): Remove check.
 467         * configure, config.in: Rebuild.
 468
 469 2018-10-01  Gary Benson <gbenson@redhat.com>
 470
 471         * common/gdb_proc_service.h: New file, factored out from...
 472         * gdb_proc_service.h: Moved common code to the above file.
 473         * Makefile.in (HFILES_NO_SRCDIR): Add the above new file.
 474
 475 2018-10-01  Gary Benson <gbenson@redhat.com>
 476
 477         * gdb_proc_service.h: Use elf_gregset_t if prgregset_t is
 478         undefined.  Use elf_fpregset_t if prfpregset_t is undefined.
 479
 480 2018-10-01  Gary Benson <gbenson@redhat.com>
 481
 482         * configure.ac: Check if sys/procfs.h defines elf_fpregset_t.
 483         (AC_CHECK_HEADERS): Check for linux/elf.h.
 484         * configure, config.in: Rebuild.
 485         * gdb_proc_service.h: Include linux/elf.h if sys/procfs.h
 486         doesn't define elf_fpregset_t.
 487
 488 2018-10-01  Gary Benson <gbenson@redhat.com>
 489
 490         * gdb_proc_service.h: Whitespace change.
 491
 492 2018-10-01  Tom Tromey  <tom@tromey.com>
 493
 494         * unittests/scoped_mmap-selftests.c: Don't check HAVE_UNISTD_H.
 495         * unittests/scoped_fd-selftests.c: Don't check HAVE_UNISTD_H.
 496         * common/scoped_fd.h: Don't check HAVE_UNISTD_H.
 497
 498 2018-10-01  Tom Tromey  <tom@tromey.com>
 499
 500         * README: Minor change.
 501
 502 2018-09-30  Pedro Alves  <palves@redhat.com>
 503
 504         * darwin-nat-info.c (darwin_debug_regions_recurse)
 505         (info_mach_exceptions_command): Remove unused local variables.
 506         * darwin-nat.c (darwin_decode_notify_message)
 507         (darwin_nat_target::resume, darwin_nat_target::mourn_inferior)
 508         (darwin_stop_inferior, darwin_setup_exceptions)
 509         (darwin_nat_target::kill, darwin_attach_pid, darwin_ptrace_him)
 510         (darwin_nat_target::attach, darwin_nat_target::detach)
 511         (darwin_read_write_inferior, darwin_read_dyld_info): Remove unused
 512         local variables.
 513         * i386-darwin-nat.c (i386_darwin_dr_set): Remove unused local
 514         variables.
 515
 516 2018-09-29  Tom Tromey  <tom@tromey.com>
 517
 518         * README: Remove some leftover text.
 519
 520 2018-09-29  Tom Tromey  <tom@tromey.com>
 521
 522         * PROBLEMS: Rewrite.
 523         * README: Update.
 524
 525 2018-09-28  John Baldwin  <jhb@FreeBSD.org>
 526
 527         * disasm-selftests.c (print_one_insn_test): Add bfd_arch_riscv to
 528         case with explicit breakpoint kind.
 529         * riscv-tdep.c (show_use_compressed_breakpoints): Remove
 530         'additional_info' and related logic.
 531         (riscv_debug_breakpoints): New variable.
 532         (riscv_breakpoint_kind_from_pc): Use the length of the existing
 533         instruction to determine the breakpoint kind.
 534         (_initialize_riscv_tdep): Add 'set/show debug riscv breakpoints'
 535         flag.  Update description of 'set/show riscv
 536         use-compressed-breakpoints' flag.
 537
 538 2018-09-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         (NEWS): Mention changes to frame related commands.
 541         * cli/cli-decode.c (add_cmd_suppress_notification): New function.
 542         (add_prefix_cmd_suppress_notification): New function.
 543         (add_com_suppress_notification): Call
 544         add_cmd_suppress_notification.
 545         * command.h (add_cmd_suppress_notification): Declare.
 546         (add_prefix_cmd_suppress_notification): Declare.
 547         * mi/mi-cmd-stack.c: Add 'safe-ctype.h' include.
 548         (parse_frame_specification): Moved from stack.c, with
 549         simplification to handle a single argument.
 550         (mi_cmd_stack_select_frame): Use parse_frame_specification, the
 551         switch to the selected frame.  Add a header comment.
 552         * stack.c: Remove 'safe-ctype.h' include.
 553         (find_frame_for_function): Add declaration.
 554         (find_frame_for_address): New function.
 555         (parse_frame_specification): Moved into mi/mi-cmd-stack.c.
 556         (frame_selection_by_function_completer): New function.
 557         (info_frame_command): Rename to...
 558         (info_frame_command_core): ...this, and update parameter types.
 559         (select_frame_command): Rename to...
 560         (select_frame_command_core): ...this, and update parameter types.
 561         (frame_command): Rename to...
 562         (frame_command_core): ...this, and update parameter types.
 563         (class frame_command_helper): New class to wrap implementations of
 564         frame related sub-commands.
 565         (frame_apply_cmd_list): New static global.
 566         (frame_cmd_list): Make static.
 567         (select_frame_cmd_list): New global for sub-commands.
 568         (info_frame_cmd_list): New global for sub-commands.
 569         (_initialize_stack): Register sub-commands for 'frame',
 570         'select-frame', and 'info frame'.  Update 'frame apply' commands
 571         to use frame_apply_cmd_list.  Move function local static
 572         frame_apply_list to file static frame_apply_cmd_list for
 573         consistency.
 574         * stack.h (select_frame_command): Delete declarationn.
 575         (select_frame_for_mi): Declare new function.
 576
 577 2018-09-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * riscv-tdep.c (riscv_insn::decode): Decode c.lui.
 580         (riscv_scan_prologue): Split handling of AUIPC, LUI, ADD, ADDI,
 581         and NOP.
 582
 583 2018-09-26  Simon Marchi  <simon.marchi@ericsson.com>
 584
 585         * elf32-nds32.c (elf32_nds32_allocate_dynrelocs): Remove.
 586
 587 2018-09-26  Tom Tromey  <tom@tromey.com>
 588
 589         * valops.c (auto_abandon): Remove dead code.
 590
 591 2018-09-26  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-win.c (WIN_HEIGHT_USAGE): Remove extra ">"s.
 594
 595 2018-09-24  Tom Tromey  <tom@tromey.com>
 596
 597         * common/pathstuff.c (get_standard_cache_dir): Make
 598         "xdg_cache_home" and "home" const.
 599         * top.c (init_history): Make "tmpenv" const.
 600         * main.c (get_init_files): Make "homedir" const.
 601
 602 2018-09-23  Tom Tromey  <tom@tromey.com>
 603
 604         PR python/18852:
 605         * python/py-param.c (get_set_value): Use gdbpy_handle_exception.
 606
 607 2018-09-23  Tom Tromey  <tom@tromey.com>
 608
 609         * python/py-function.c (fnpy_call): Use gdbpy_handle_exception.
 610         * python/py-cmd.c (cmdpy_function): Use gdbpy_handle_exception.
 611         * python/python-internal.h (gdbpy_handle_exception): Declare.
 612         * python/py-utils.c (gdbpy_handle_exception): New function.
 613
 614 2018-09-23  Tom Tromey  <tom@tromey.com>
 615
 616         PR python/17284:
 617         * python/py-type.c (typy_template_argument): Check for negative
 618         argument number.
 619
 620 2018-09-23  Tom Tromey  <tom@tromey.com>
 621
 622         PR python/14062:
 623         * python/python.c (gdbpy_run_events): Do not ignore exceptions.
 624
 625 2018-09-23  Tom Tromey  <tom@tromey.com>
 626
 627         PR python/18170:
 628         * python/py-value.c (valpy_int): Allow conversion from pointer
 629         type.
 630
 631 2018-09-23  Tom Tromey  <tom@tromey.com>
 632
 633         PR python/20126:
 634         * python/py-value.c (valpy_int): Respect type sign.
 635
 636 2018-09-23  Tom Tromey  <tom@tromey.com>
 637
 638         PR python/18352;
 639         * python/py-value.c (valpy_float): Allow conversions from int or
 640         char.
 641         (valpy_int, valpy_long): Allow conversions from float.
 642
 643 2018-09-23  Tom Tromey  <tom@tromey.com>
 644
 645         * ctf.c (ctf_start): Use gdb_fopen_cloexec.
 646         * common/scoped_mmap.c (mmap_file): Use gdb_open_cloexec.
 647
 648 2018-09-23  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 649
 650         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Also recognize
 651         __sighndlr.
 652         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Likewise.
 653
 654 2018-08-02  Jon Turney  <jon.turney@dronecode.org.uk>
 655
 656         * windows-nat.c (windows_nat_target::wait): Remove a spurious
 657         target_terminal::ours().
 658
 659 2018-09-23  Simon Marchi  <simon.marchi@ericsson.com>
 660
 661         * aarch64-linux-tdep.c (aarch64_linux_supply_sve_regset): Change type
 662         of vl to ULONGEST.
 663
 664 2018-09-21  Yacov Simhony  <ysimhony@gmail.com>
 665
 666         * breakpoint.c (update_inserted_breakpoint_locations): Remove
 667         redundant condition.
 668
 669 2018-09-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 670
 671         * proc-utils.h (PROC_CTL_WORD_TYPE): Remove.
 672
 673         * procfs.c: Don't check for PR_MODEL_NATIVE definition.
 674         * sparc-sol2-nat.c: Likewise.  Remove Linux, __arch64__ references.
 675         * sol-thread.c (ps_pdmodel): Don't guard definition.
 676
 677         * procfs.c: Fix formatting.
 678
 679         * procfs.c (sysset_t_alloc): Remove.
 680         (create_procinfo): Use XNEW instead of sysset_t_alloc.
 681         (procfs_debug_inferior): Likewise.
 682         (procfs_set_exec_trap): Likewise.
 683         (proc_set_traced_sysentry): Don't allocate argp dynamically.
 684         (proc_set_traced_sysexit): Likewise.
 685
 686         * procfs.c (create_procinfo): Use xsnprintf to fix ARI warning.
 687         (dead_procinfo): Likewise.
 688         (proc_warn): Likewise.
 689         (proc_error): Likewise.
 690         (proc_get_LDT_entry): Likewise.
 691         (do_attach): Likewise.
 692         (procfs_target::pid_to_str): Likewise.
 693         (iterate_over_mappings): Likewise.
 694
 695         * procfs.c (create_procinfo): Fix ARI warning.
 696         (proc_get_status): Likewise.
 697         (proc_stop_process): Likewise.
 698         (proc_run_process): Likewise.
 699         (proc_kill): Likewise.
 700         (proc_get_LDT_entry): Likewise.
 701         (procfs_find_LDT_entry): Likewise.
 702         (proc_update_threads): Likewise.
 703         (proc_iterate_over_threads): Likewise.
 704         (do_attach): Likewise.
 705         (procfs_xfer_memory): Likewise.
 706         (invalidate_cache): Likewise.
 707         (procfs_target::resume): Likewise.
 708         (procfs_init_inferior): Likewise.
 709         (procfs_set_exec_trap): Likewise.
 710         (procfs_target::thread_alive): Likewise.
 711         (procfs_target::pid_to_exec_file): Likewise.
 712         (iterate_over_mappings): Likewise.
 713         (procfs_target::make_corefile_notes): Likewise.
 714         * sol-thread.c (sol_thread_target::thread_alive): Likewise.
 715
 716         * procfs.c (procfs_find_LDT_entry): Silence ARI warning.
 717         (procfs_find_LDT_entry): Likewise.
 718         * sol-thread.c (ps_lgetLDT): Likewise.
 719
 720 2018-09-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 721
 722         PR tdep/17903
 723         * procfs.c (procfs_target): Declare pid_to_exec_file.
 724         (procfs_target::pid_to_exec_file): New.
 725
 726 2018-09-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 727
 728         * auxv.c (default_print_auxv_entry): Reflect AT_SUN_CAP_HW1
 729         renaming.
 730         Handle AT_SUN_EMULATOR, AT_SUN_BRANDNAME, AT_SUN_BRAND_AUX1,
 731         AT_SUN_BRAND_AUX2, AT_SUN_BRAND_AUX3, AT_SUN_CAP_HW2.
 732
 733 2018-09-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 734
 735         * i386-v4-nat.c (regmap, supply_gregset, fill_gregset)
 736         (supply_fpregset, fill_fpregset): Move ...
 737         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64]: ... here.
 738         Remove HAVE_GREGSET_T, HAVE_FPREGET_T guards.
 739         Remove references to ioctl-based procfs.
 740         Include <sys/reg.h>.
 741         Remove PR_MODEL_NATIVE guards.
 742         * configure.nat <sol2, i386> (NATDEPFILES): Remove i386-v4-nat.o.
 743         * Makefile.in (ALLDEPFILES): Remove i386-v4-nat.c.
 744
 745 2018-09-19  Xavier Roirand  <roirand@adacore.com>
 746
 747         PR gdb/20981:
 748         * solib-darwin.c (darwin_get_dyld_bfd): New function.
 749         (darwin_solib_get_all_image_info_addr_at_init): Update call.
 750         (darwin_solib_create_inferior_hook): Handle unrelocated dyld.
 751
 752 2018-09-19  John Baldwin  <jhb@FreeBSD.org>
 753
 754         * fbsd-tdep.c (fbsd_print_sockaddr_in): Style fix.
 755         (fbsd_print_sockaddr_in6): Likewise.
 756
 757 2018-09-19  Richard Bunt  <richard.bunt@arm.com>
 758             Chris January  <chris.january@arm.com>
 759
 760         * eval.c (skip_undetermined_arglist): Skip argument list helper.
 761         (evaluate_subexp_standard): Return a dummy type when
 762         honoring EVAL_SKIP in OP_VAR_VALUE and handle skipping in the
 763         OP_F77_UNDETERMINED_ARGLIST case.
 764         * expression.h (enum noside): Update comment.
 765
 766 2018-09-19  George Vasick <george.vasick@oracle.com>
 767
 768         * solib-svr4.c (svr4_same_1): Also handle amd64 ld.so.1.
 769
 770 2018-09-19  Stefan Teleman <stefan.teleman@oracle.com>
 771             April Chin <april.chin@oracle.com>
 772             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 773
 774         * procfs.c (MAX_PROC_NAME_SIZE): Allow for 6-digit PID_MAX and
 775         uint_t lwpid_t.
 776         (create_procinfo): Print pids in /proc without leading zeros.
 777
 778 2018-09-18  Sandra Loosemore  <sandra@codesourcery.com>
 779
 780         * nios2-tdep.c (nios2_gcc_target_options): New.
 781         (nios2_gdb_arch_init): Install new hook.
 782
 783 2018-09-18  Simon Marchi  <simon.marchi@ericsson.com>
 784
 785         * patches/0001-Fix-PR-gdb-23558-Use-system-s-getcwd-when-cross-comp.patch:
 786         New file.
 787         * update-gnulib.sh: Apply patch.
 788         * configure: Re-generate.
 789
 790 2018-09-18  John Baldwin  <jhb@FreeBSD.org>
 791
 792         * infcmd.c (_initialize_infcmd): Remove "running" from "info proc"
 793         description.  Make "info proc" command descriptions more
 794         consistent.
 795
 796 2018-09-18  John Baldwin  <jhb@FreeBSD.org>
 797
 798         * NEWS: Mention 'info proc files' command.
 799
 800 2018-09-18  John Baldwin  <jhb@FreeBSD.org>
 801
 802         * fbsd-nat.c (fbsd_nat_target::info_proc): List open file
 803         descriptors for IP_FILES and IP_ALL.
 804
 805 2018-09-18  John Baldwin  <jhb@FreeBSD.org>
 806
 807         * fbsd-tdep.c (KF_FLAGS, KF_OFFSET, KF_VNODE_TYPE, KF_SOCK_DOMAIN)
 808         (KF_SOCK_TYPE, KF_SOCK_PROTOCOL, KF_SA_LOCAL, KF_SA_PEER)
 809         (KINFO_FILE_TYPE_SOCKET, KINFO_FILE_TYPE_PIPE)
 810         (KINFO_FILE_TYPE_FIFO, KINFO_FILE_TYPE_KQUEUE)
 811         (KINFO_FILE_TYPE_CRYPTO, KINFO_FILE_TYPE_MQUEUE)
 812         (KINFO_FILE_TYPE_SHM, KINFO_FILE_TYPE_SEM, KINFO_FILE_TYPE_PTS)
 813         (KINFO_FILE_TYPE_PROCDESC, KINFO_FILE_FD_TYPE_ROOT)
 814         (KINFO_FILE_FD_TYPE_JAIL, KINFO_FILE_FD_TYPE_TRACE)
 815         (KINFO_FILE_FD_TYPE_CTTY, KINFO_FILE_FLAG_READ)
 816         (KINFO_FILE_FLAG_WRITE, KINFO_FILE_FLAG_APPEND)
 817         (KINFO_FILE_FLAG_ASYNC, KINFO_FILE_FLAG_FSYNC)
 818         (KINFO_FILE_FLAG_NONBLOCK, KINFO_FILE_FLAG_DIRECT)
 819         (KINFO_FILE_FLAG_HASLOCK, KINFO_FILE_FLAG_EXEC)
 820         (KINFO_FILE_VTYPE_VREG, KINFO_FILE_VTYPE_VDIR)
 821         (KINFO_FILE_VTYPE_VCHR, KINFO_FILE_VTYPE_VLNK)
 822         (KINFO_FILE_VTYPE_VSOCK, KINFO_FILE_VTYPE_VFIFO, FBSD_AF_UNIX)
 823         (FBSD_AF_INET, FBSD_AF_INET6, FBSD_SOCK_STREAM, FBSD_SOCK_DGRAM)
 824         (FBSD_SOCK_SEQPACKET, FBSD_IPPROTO_ICMP, FBSD_IPPROTO_TCP)
 825         (FBSD_IPPROTO_UDP, FBSD_IPPROTO_SCTP): New defines.
 826         (struct fbsd_sockaddr_in, struct fbsd_sockaddr_in6)
 827         (struct fbsd_sockaddr_un): New types.
 828         (fbsd_file_fd, fbsd_file_type, fbsd_file_flags, fbsd_ipproto)
 829         (fbsd_print_sockaddr_in, fbsd_print_sockaddr_in6)
 830         (fbsd_info_proc_files_header, fbsd_info_proc_files_entry)
 831         (fbsd_core_info_proc_files): New functions.
 832         (fbsd_core_info_proc): List open file descriptors for IP_FILES and
 833         IP_ALL.
 834         * fbsd-tdep.h (fbsd_info_proc_files_header)
 835         (fbsd_info_proc_files_entry): New.
 836
 837 2018-09-18  John Baldwin  <jhb@FreeBSD.org>
 838
 839         * defs.h (enum info_proc_what) [IP_FILES]: New value.
 840         * infcmd.c (info_proc_cmd_files): New function.
 841         (_initialize_infcmd): Register 'info proc files' command.
 842
 843 2018-09-18  John Baldwin  <jhb@FreeBSD.org>
 844
 845         * gnulib/aclocal-m4-deps.mk: Re-generate.
 846         * gnulib/aclocal.m4: Re-generate.
 847         * gnulib/config.in: Re-generate.
 848         * gnulib/configure: Re-generate.
 849         * gnulib/import/Makefile.am: Re-generate.
 850         * gnulib/import/Makefile.in: Re-generate.
 851         * gnulib/import/m4/gnulib-cache.m4: Re-generate.
 852         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
 853         * gnulib/import/arpa_inet.in.h: New file.
 854         * gnulib/import/inet_ntop.c: New file.
 855         * gnulib/import/m4/arpa_inet_h.m4: New file.
 856         * gnulib/import/m4/inet_ntop.m4: New file.
 857         * gnulib/import/m4/netinet_in_h.m4: New file.
 858         * gnulib/import/m4/socklen.m4: New file.
 859         * gnulib/import/m4/sockpfaf.m4: New file.
 860         * gnulib/import/m4/stdalign.m4: New file.
 861         * gnulib/import/m4/sys_uio_h.m4: New file.
 862         * gnulib/import/netinet_in.in.h: New file.
 863         * gnulib/import/stdalign.in.h: New file.
 864         * gnulib/import/sys_socket.c: New file.
 865         * gnulib/import/sys_socket.in.h: New file.
 866         * gnulib/import/sys_uio.in.h: New file.
 867         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add inet_ntop
 868         module.
 869
 870 2018-09-18  John Baldwin  <jhb@FreeBSD.org>
 871
 872         * gnulib/aclocal-m4-deps.mk: New file.
 873         * gnulib/update-gnulib.sh: Generate "aclocal-m4-deps.mk"
 874         deterministically.
 875
 876 2018-09-18  John Baldwin  <jhb@FreeBSD.org>
 877
 878         * fbsd-tdep.c (fbsd_core_vnode_path): Use KF_PATH instead of
 879         KVE_PATH.
 880
 881 2018-09-18  Tom Tromey  <tom@tromey.com>
 882
 883         * compile/compile-object-load.c (struct
 884         link_hash_table_cleanup_data): Add constructor and destructor.
 885         Use DISABLE_COPY_AND_ASSIGN.
 886         (~link_hash_table_cleanup_data): Rename from
 887         link_hash_table_free.  Now a destructor.
 888         (copy_sections): Use gdb::unique_xmalloc_ptr.  Remove cleanups.
 889
 890 2018-09-18  Tom Tromey  <tom@tromey.com>
 891
 892         * compile/compile-object-run.c (do_module_cleanup): Use delete.
 893         * compile/compile-object-load.c (struct munmap_list): Move to
 894         header file.
 895         (munmap_list::add): Rename from munmap_list_add; rewrite.
 896         (munmap_list::~munmap_list): Rename from munmap_list_free.
 897         (munmap_listp_free_cleanup): Remove.
 898         (compile_object_load): Update.
 899         * compile/compile-object-load.h (struct munmap_list): Move from
 900         compile-object-load.c.  Rewrite.
 901
 902 2018-09-18  Alan Hayward  <alan.hayward@arm.com>
 903
 904         * aarch64-tdep.c (pass_in_v): Use register size.
 905         (aarch64_extract_return_value): Likewise.
 906         (aarch64_store_return_value): Likewise.
 907
 908 2018-09-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 909
 910         * utils.c (dump_core) [HAVE_SETRLIMIT]: Cast RLIM_INFINITY to
 911         rlim_t.
 912
 913 2018-09-17  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 914
 915         * python/lib/gdb/command/frame_filters.py (EnableFrameFilter):
 916         Fix short help line.
 917
 918 2018-09-17  Tom Tromey  <tom@tromey.com>
 919
 920         PR python/20445:
 921         * configure: Rebuild.
 922         * configure.ac: Conditionally use -DNDEBUG for Python.
 923
 924 2018-09-17  Tom Tromey  <tom@tromey.com>
 925
 926         * configure: Rebuild.
 927         * configure.ac: Use gmp as a library dependency when checking for
 928         mpfr.
 929
 930 2018-09-17  Pedro Alves  <palves@redhat.com>
 931
 932         * python/py-inferior.c (find_inferior_object): Delete.
 933
 934 2018-09-17  Simon Marchi  <simon.marchi@ericsson.com>
 935
 936         * compile/compile-cplus-types.c
 937         (compile_cplus_instance::enter_scope): Don't use new_scope after
 938         std::move.
 939
 940 2018-09-17  Tom Tromey  <tom@tromey.com>
 941
 942         * common/pathstuff.c (get_standard_cache_dir): Use
 943         ~/Library/Caches on macOS.
 944         * common/pathstuff.h (get_standard_cache_dir): Update comment.
 945
 946 2018-09-17  Simon Marchi  <simon.marchi@polymtl.ca>
 947
 948         PR python/23669
 949         * breakpoint.c (commands_cmd_element): New.
 950         (_initialize_breakpoint): Assign commands_cmd_element.
 951         * breakpoint.h (commands_cmd_element): New.
 952         * cli/cli-script.c (while_cmd_element, if_command,
 953         define_cmd_element): New.
 954         (command_name_equals): Remove.
 955         (process_next_line): Compare commands by pointer, not by name.
 956         (_initialize_cli_script): Assign the various cmd_list_element
 957         variables.
 958         * compile/compile.c (compile_cmd_element): New.
 959         (_initialize_compile): Assign compile_cmd_element.
 960         * compile/compile.h (compile_cmd_element): New.
 961         * guile/guile.c (guile_cmd_element): New.
 962         (install_gdb_commands): Assign guile_cmd_element.
 963         * guile/guile.h (guile_cmd_element): New.
 964         * python/python.c (python_cmd_element): New.
 965         (_initialize_python): Assign python_cmd_element.
 966         * python/python.h (python_cmd_element): New.
 967         * tracepoint.c (while_stepping_cmd_element): New.
 968         (_initialize_tracepoint): Assign while_stepping_cmd_element.
 969         * tracepoint.h (while_stepping_cmd_element): New.
 970
 971 2018-09-17  Tom Tromey  <tom@tromey.com>
 972
 973         * infrun.c (save_infcall_suspend_state): Return
 974         infcall_suspend_state_up.
 975         (save_infcall_control_state): Return infcall_control_state_up.
 976         * inferior.h (save_infcall_suspend_state)
 977         (save_infcall_control_state): Declare later.  Return unique
 978         pointers.
 979
 980 2018-09-17  Tom Tromey  <tom@tromey.com>
 981
 982         * infrun.c (struct stop_context): Declare constructor,
 983         destructor, "changed" method.
 984         (stop_context::stop_context): Rename from save_stop_context.
 985         (stop_context::~stop_context): Rename from
 986         release_stop_context_cleanup.
 987         (normal_stop): Update.
 988         (stop_context::changed): Rename from stop_context_changed.  Return
 989         bool.
 990
 991 2018-09-17  Tom Tromey  <tom@tromey.com>
 992
 993         * inferior.h (struct infcall_suspend_state_deleter): New.
 994         (infcall_suspend_state_up): New typedef.
 995         (struct infcall_control_state_deleter): New.
 996         (infcall_control_state_up): New typedef.
 997         (make_cleanup_restore_infcall_suspend_state)
 998         (make_cleanup_restore_infcall_control_state): Don't declare.
 999         * infcall.c (call_function_by_hand_dummy): Update.
1000         * infrun.c (do_restore_infcall_suspend_state_cleanup)
1001         (make_cleanup_restore_infcall_suspend_state): Remove.
1002         (do_restore_infcall_control_state_cleanup)
1003         (make_cleanup_restore_infcall_control_state): Remove.
1004
1005 2018-09-17  Tom Tromey  <tom@tromey.com>
1006
1007         * gdbthread.h (struct thread_control_state): Add initializer.
1008         (class thread_info) <control>: Remove initializer.
1009         * inferior.h (struct inferior_control_state): Add initializer.
1010         (class inferior) <control>: Remove initializer.
1011         (exit_inferior_1): Update.
1012         * infrun.c (struct infcall_control_state): Add constructors.
1013         (save_infcall_control_state): Use new.
1014         (restore_infcall_control_state, discard_infcall_control_state):
1015         Use delete.
1016
1017 2018-09-17  Tom Tromey  <tom@tromey.com>
1018
1019         * infrun.c (struct infcall_suspend_state) <registers>: Now a
1020         unique_ptr.
1021         <siginfo_data>: Now a unique_xmalloc_ptr.
1022         (save_infcall_suspend_state, restore_infcall_suspend_state)
1023         (discard_infcall_suspend_state)
1024         (get_infcall_suspend_state_regcache): Update.
1025
1026 2018-09-17  Tom Tromey  <tom@tromey.com>
1027
1028         * gdbthread.h (struct thread_suspend_state): Add initializers.
1029         (class thread_info) <suspend>: Remove initializer.
1030         * infrun.c (struct infcall_suspend_state): Add initializers.
1031         (save_infcall_suspend_state): Use new.
1032         (discard_infcall_suspend_state): Use delete.
1033
1034 2018-09-16  Tom Tromey  <tom@tromey.com>
1035
1036         * python/python-internal.h (CPYCHECKER_STEALS_REFERENCE_TO_ARG):
1037         Remove.
1038         * python/py-varobj.c (py_varobj_iter_ctor): Change pyiter to
1039         rvalue reference.  Remove CPYCHECKER_STEALS_REFERENCE_TO_ARG.
1040         (py_varobj_iter_new): Likewise.
1041         (py_varobj_get_iterator): Use gdbpy_ref.
1042
1043 2018-09-16  Tom Tromey  <tom@tromey.com>
1044
1045         * python/py-threadevent.c (py_get_event_thread): Simplify.
1046         * python/py-inferior.c (infpy_thread_from_thread_handle):
1047         Return immediately after calling thread_to_thread_object.  Use
1048         Py_RETURN_NONE.
1049         (thread_to_thread_object): Set the exception on a NULL return.
1050
1051 2018-09-16  Simon Marchi  <simon.marchi@polymtl.ca>
1052
1053         * Makefile.in (LIBGDB_OBS): Sort COMMON_OBS.
1054
1055 2018-09-16  Tom Tromey  <tom@tromey.com>
1056
1057         * python/python-internal.h (CPYCHECKER_RETURNS_BORROWED_REF):
1058         Remove.
1059
1060 2018-09-16  Tom Tromey  <tom@tromey.com>
1061
1062         * python/python-internal.h (thread_to_thread_object): Change
1063         return type.
1064         * python/py-inferior.c (thread_to_thread_object): Return a new
1065         reference.
1066         (infpy_thread_from_thread_handle): Update.
1067         * python/py-infthread.c (gdbpy_selected_thread): Update.
1068         * python/py-stopevent.c (create_stop_event_object): Update.
1069         * python/py-threadevent.c (py_get_event_thread): Return a new
1070         reference.
1071         (py_get_event_thread): Update.
1072         * python/py-event.h (py_get_event_thread): Change return type.
1073         * python/py-continueevent.c (create_continue_event_object):
1074         Update.
1075
1076 2018-09-16  Tom Tromey  <tom@tromey.com>
1077
1078         * python/py-progspace.c (pspy_get_objfiles): Update.
1079         * python/python-internal.h (objfile_to_objfile_object): Change
1080         return type.
1081         * python/py-newobjfileevent.c (create_new_objfile_event_object):
1082         Update.
1083         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1084         Update.
1085         * python/python.c (gdbpy_get_current_objfile): Update.
1086         (gdbpy_objfiles): Update.
1087         * python/py-objfile.c (objfpy_get_owner, gdbpy_lookup_objfile):
1088         Update.
1089         (objfile_to_objfile_object): Return a new reference.
1090         * python/py-symtab.c (stpy_get_objfile): Update.
1091         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1092         Update.
1093
1094 2018-09-16  Tom Tromey  <tom@tromey.com>
1095
1096         * python/py-inferior.c (infpy_get_progspace): Update.
1097         * python/python-internal.h (pspace_to_pspace_object): Change
1098         return type.
1099         * python/py-newobjfileevent.c
1100         (create_clear_objfiles_event_object): Update.
1101         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1102         Update.
1103         * python/python.c (gdbpy_get_current_progspace): Update.
1104         (gdbpy_progspaces): Update.
1105         * python/py-progspace.c (pspace_to_pspace_object): Return a new
1106         reference.
1107         * python/py-objfile.c (objfpy_get_progspace): Update.
1108         * python/py-prettyprint.c (find_pretty_printer_from_progspace):
1109         Update.
1110
1111 2018-09-16  Tom Tromey  <tom@tromey.com>
1112
1113         * python/lib/gdb/__init__.py (current_progspace, objfiles)
1114         (solib_name, block_for_pc, find_pc_line): New functions.
1115         (execute_unwinders): Update.
1116         * python/py-block.c (gdbpy_block_for_pc): Remove.
1117         * python/py-inferior.c (infpy_get_progspace): New function.
1118         (inferior_object_getset) <progspace>: Add.
1119         * python/py-progspace.c (pspy_objfiles): Rewrite.
1120         (pspy_solib_name, pspy_block_for_pc)
1121         (pspy_find_pc_line, pspy_is_valid): New functions.
1122         (progspace_object_methods): Add entries for solib_name,
1123         block_for_pc, find_pc_line, is_valid.
1124         * python/python-internal.h (gdbpy_block_for_pc)
1125         (build_objfiles_list): Don't declare.
1126         * python/python.c: Don't include solib.h.
1127         (gdbpy_solib_name, gdbpy_find_pc_line)
1128         (gdbpy_get_current_progspace, build_objfiles_list)
1129         (gdbpy_objfiles): Remove.
1130         (GdbMethods) <current_progspace, objfiles, block_for_pc,
1131         solib_name, find_pc_line>: Remove entries.
1132
1133 2018-09-16  Tom Tromey  <tom@tromey.com>
1134
1135         * top.c (new_ui_command): Use GNU style for metasyntactic
1136         variables.
1137         * breakpoint.c (stopat_command): Use GNU style for metasyntactic
1138         variables.
1139         * maint.c (maintenance_translate_address): Remove "<>" around
1140         text.
1141         * interps.c (interpreter_exec_cmd): Use GNU style for
1142         metasyntactic variables.
1143         * nto-procfs.c (nto_procfs_target_info): Use GNU style for
1144         metasyntactic variables.
1145         * tracepoint.c (tfind_range_command): Use GNU style for
1146         metasyntactic variables.
1147         (tfind_outside_command): Likewise.
1148         (_initialize_tracepoint): Likewise.
1149         * remote.c (extended_remote_target::create_inferior): Use GNU
1150         style for metasyntactic variables.
1151         * sparc64-tdep.c (adi_examine_command): Use GNU style for
1152         metasyntactic variables.
1153         (adi_assign_command): Likewise.
1154
1155 2018-09-16  Tom Tromey  <tom@tromey.com>
1156
1157         * disasm.c (show_disassembler_options_sfunc): Use GNU style for
1158         metasyntactic variables.  Print message if no disassembler options
1159         are available.
1160
1161 2018-09-15  Tom Tromey  <tom@tromey.com>
1162
1163         * infcmd.c (get_inferior_args): Return const char *.
1164         * inferior.h (get_inferior_args): Return type now const.
1165         * linux-tdep.c (linux_fill_prpsinfo): Update.
1166         * procfs.c (procfs_target::make_corefile_notes): Update.
1167
1168 2018-09-07  Tom Tromey  <tom@tromey.com>
1169
1170         * python/python.c (execute_gdb_command): Call bpstat_do_actions
1171         inside the TRY.
1172
1173 2018-09-14  Sandra Loosemore  <sandra@codesourcery.com>
1174
1175         * nios2-tdep.c (nios2_type_align): New.
1176         (nios2_gdb_arch_init): Install type_align hook.
1177
1178 2018-09-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * eval.c (fake_method::fake_method): Call xzalloc directly for a
1181         type that is neither object file owned, nor gdbarch owned.
1182         * gdbtypes.c (get_type_gdbarch): Add an assert that returned
1183         gdbarch is non-NULL.
1184         (alloc_type_instance): Allocate non-objfile owned types on the
1185         gdbarch obstack.
1186         (copy_type_recursive): Allocate TYPE_FIELDS and TYPE_RANGE_DATA
1187         using TYPE_ALLOC to ensure memory is allocated on the correct
1188         obstack.
1189         * gdbtypes.h (TYPE_ALLOC): Allocate space on either the objfile
1190         obstack, or the gdbarch obstack.
1191         (TYPE_ZALLOC): Rewrite using TYPE_ALLOC.
1192
1193 2018-09-14  Tom Tromey  <tom@tromey.com>
1194
1195         * infcall.c (call_function_by_hand_dummy): Remove unnecessary
1196         block.
1197
1198 2018-09-14  Tom Tromey  <tom@tromey.com>
1199
1200         * nat/fork-inferior.c (get_startup_shell): Remove "static".
1201
1202 2018-09-13  Tom Tromey  <tom@tromey.com>
1203
1204         * python/py-inferior.c (infpy_thread_from_thread_handle): Now
1205         static.
1206
1207 2018-09-13  Tom Tromey  <tom@tromey.com>
1208
1209         * exec.c (try_open_exec_file): Use std::string.
1210
1211 2018-09-13  Tom Tromey  <tom@tromey.com>
1212
1213         * utils.h (gdb_bfd_errmsg): Return std::string.
1214         * exec.c (exec_file_attach): Update.
1215         * compile/compile-object-load.c (compile_object_load): Update.
1216         * utils.c (gdb_bfd_errmsg): Return std::string.
1217
1218 2018-09-13  Tom Tromey  <tom@tromey.com>
1219
1220         * procfs.c (struct procinfo_deleter): New.
1221         (procinfo_up): New typedef.
1222         (do_destroy_procinfo_cleanup): Remove.
1223         (procfs_target::info_proc): Use procinfo_up.  Remove cleanups.
1224
1225 2018-09-13  Tom Tromey  <tom@tromey.com>
1226
1227         * source.c (add_path): Use gdb::unique_xmalloc_ptr.
1228
1229 2018-09-13  Simon Marchi  <simon.marchi@ericsson.com>
1230 2018-09-13  Tom Tromey  <tom@tromey.com>
1231
1232         * python/py-progspace.c (PSPY_REQUIRE_VALID): New macro.
1233         (pspy_get_objfiles): New function.
1234         (progspace_object_methods): New.
1235         (pspace_object_type): Add tp_methods callback.
1236         * python/python-internal.h (build_objfiles_list): New
1237         declaration.
1238         * python/python.c (build_objfiles_list): New function.
1239         (gdbpy_objfiles): Implement using build_objfiles_list.
1240         * NEWS: Mention the Progspace.objfiles method.
1241
1242 2018-09-13  Simon Marchi  <simon.marchi@ericsson.com>
1243
1244         * python/py-inferior.c (infpy_get_progspace): New function.
1245         (inferior_object_getset): Add progspace property.
1246         * NEWS: Mention the new property.
1247
1248 2018-09-13  Tom Tromey  <tom@tromey.com>
1249
1250         PR rust/23650:
1251         * rust-lang.c (rust_evaluate_subexp): Use field name, not "foo".
1252
1253 2018-09-13  Tom Tromey  <tom@tromey.com>
1254
1255         PR rust/23626:
1256         * rust-lang.c (rust_enum_variant): Now static.
1257         (rust_empty_enum_p): New function.
1258         (rust_print_enum, rust_evaluate_subexp, rust_print_struct_def):
1259         Handle empty enum.
1260
1261 2018-09-13  Simon Marchi  <simon.marchi@ericsson.com>
1262
1263         * python/py-inferior.c (infpy_repr): New.
1264         (inferior_object_type): Register infpy_repr.
1265         * python/py-objfile.c (objfpy_repr): New.
1266         (objfile_object_type): Register objfpy_repr.
1267
1268 2018-09-12  John Baldwin  <jhb@FreeBSD.org>
1269
1270         * fbsd-nat.c (fbsd_nat_target::info_proc): Remove unused variable.
1271
1272 2018-09-12  John Baldwin  <jhb@FreeBSD.org>
1273
1274         * aarch64-fbsd-tdep.h (AARCH64_FBSD_SIZEOF_GREGSET): Fix comment
1275         typo.
1276
1277 2018-09-12  Sergio Durigan Junior  <sergiodj@redhat.com>
1278
1279         * common/common-utils.c: Don't include '<sys/stat.h>'.
1280         (is_regular_file): Move to...
1281         * common/filestuff.c (is_regular_file): ... here.
1282         * common/common-utils.h (is_regular_file): Move to...
1283         * common/filestuff.h (is_regular_file): ... here.
1284
1285 2018-09-12  Simon Marchi  <simon.marchi@ericsson.com>
1286
1287         * skip.c (debug_skip): New variable.
1288         (skiplist_entry::do_skip_file_p): Add debug output.
1289         (skiplist_entry::do_skip_gfile_p): Likewise.
1290         (skiplist_entry::skip_function_p): Likewise.
1291         (_initialize_step_skip): Create debug command.
1292         * NEWS: Mention set/show debug skip.
1293
1294 2018-09-11  Xavier Roirand  <roirand@adacore.com>
1295
1296         * darwin-nat.c (should_disable_startup_with_shell):
1297         New function.
1298         (darwin_nat_target::create_inferior): Add call.
1299
1300 2018-09-11  Xavier Roirand  <roirand@adacore.com>
1301
1302         * darwin-nat.h (struct darwin_thread_info) <gdb_port,
1303         inf_port, msg_state>: Initialize.
1304         (struct darwin_thread_info) <signaled, single_step>: Change
1305         type and initialize.
1306         (struct darwin_thread_info) <event>: Initialize.
1307
1308 2018-09-10  Sergio Durigan Junior  <sergiodj@redhat.com>
1309
1310         PR gdb/23555
1311         PR gdb/23558
1312         * gnulib/import/m4/getcwd-path-max.m4: Add cross-compilation
1313         guesses.
1314
1315 2018-09-10  Sergio Durigan Junior  <sergiodj@redhat.com>
1316
1317         Revert:
1318         2018-08-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1319
1320         PR gdb/23555
1321         PR gdb/23558
1322         * gnulib/aclocal.m4: Regenerate.
1323         * gnulib/config.in: Regenerate.
1324         * gnulib/configure: Regenerate.
1325         * gnulib/import/Makefile.am: Update.
1326         * gnulib/import/Makefile.in: Update.
1327         * gnulib/import/extra/snippet/_Noreturn.h: Rename to...
1328         * gnulib/import/_Noreturn.h: ... this.
1329         * gnulib/import/alloca.in.h: Update.
1330         * gnulib/import/extra/snippet/arg-nonnull.h: Rename to...
1331         * gnulib/import/arg-nonnull.h: ... this.
1332         * gnulib/import/assure.h: Update.
1333         * gnulib/import/at-func.c: Update.
1334         * gnulib/import/basename-lgpl.c: Update.
1335         * gnulib/import/extra/snippet/c++defs.h: Rename to...
1336         * gnulib/import/c++defs.h: ... this.
1337         * gnulib/import/canonicalize-lgpl.c: Update.
1338         * gnulib/import/cdefs.h: Update.
1339         * gnulib/import/chdir-long.c: Update.
1340         * gnulib/import/chdir-long.h: Update.
1341         * gnulib/import/cloexec.c: Update.
1342         * gnulib/import/cloexec.h: Update.
1343         * gnulib/import/close.c: Update.
1344         * gnulib/import/closedir.c: Update.
1345         * gnulib/import/config.charset: Update.
1346         * gnulib/import/dirent-private.h: Update.
1347         * gnulib/import/dirent.in.h: Update.
1348         * gnulib/import/dirfd.c: Update.
1349         * gnulib/import/dirname-lgpl.c: Update.
1350         * gnulib/import/dirname.h: Update.
1351         * gnulib/import/dosname.h: Update.
1352         * gnulib/import/dup-safer-flag.c: Update.
1353         * gnulib/import/dup-safer.c: Update.
1354         * gnulib/import/dup.c: Update.
1355         * gnulib/import/dup2.c: Update.
1356         * gnulib/import/errno.in.h: Update.
1357         * gnulib/import/error.c: Update.
1358         * gnulib/import/error.h: Update.
1359         * gnulib/import/exitfail.c: Update.
1360         * gnulib/import/exitfail.h: Update.
1361         * gnulib/import/extra/update-copyright: Update.
1362         * gnulib/import/fchdir.c: Update.
1363         * gnulib/import/fcntl.c: Update.
1364         * gnulib/import/fcntl.in.h: Update.
1365         * gnulib/import/fd-hook.c: Update.
1366         * gnulib/import/fd-hook.h: Update.
1367         * gnulib/import/fd-safer-flag.c: Update.
1368         * gnulib/import/fd-safer.c: Update.
1369         * gnulib/import/fdopendir.c: Update.
1370         * gnulib/import/filename.h: Update.
1371         * gnulib/import/filenamecat-lgpl.c: Update.
1372         * gnulib/import/filenamecat.h: Update.
1373         * gnulib/import/flexmember.h: Update.
1374         * gnulib/import/float+.h: Update.
1375         * gnulib/import/float.c: Update.
1376         * gnulib/import/float.in.h: Update.
1377         * gnulib/import/fnmatch.c: Update.
1378         * gnulib/import/fnmatch.in.h: Update.
1379         * gnulib/import/fnmatch_loop.c: Update.
1380         * gnulib/import/fpucw.h: Update.
1381         * gnulib/import/frexp.c: Update.
1382         * gnulib/import/frexpl.c: Update.
1383         * gnulib/import/fstat.c: Update.
1384         * gnulib/import/fstatat.c: Update.
1385         * gnulib/import/getcwd-lgpl.c: Update.
1386         * gnulib/import/getcwd.c: Update.
1387         * gnulib/import/getdtablesize.c: Update.
1388         * gnulib/import/getlogin_r.c: Update.
1389         * gnulib/import/getprogname.c: Update.
1390         * gnulib/import/getprogname.h: Update.
1391         * gnulib/import/gettext.h: Update.
1392         * gnulib/import/gettimeofday.c: Update.
1393         * gnulib/import/glob-libc.h: Update.
1394         * gnulib/import/glob.c: Update.
1395         * gnulib/import/glob.in.h: Update.
1396         * gnulib/import/glob_internal.h: Update.
1397         * gnulib/import/glob_pattern_p.c: Update.
1398         * gnulib/import/globfree.c: Update.
1399         * gnulib/import/hard-locale.c: Update.
1400         * gnulib/import/hard-locale.h: Update.
1401         * gnulib/import/intprops.h: Update.
1402         * gnulib/import/inttypes.in.h: Update.
1403         * gnulib/import/isnan.c: Update.
1404         * gnulib/import/isnand-nolibm.h: Update.
1405         * gnulib/import/isnand.c: Update.
1406         * gnulib/import/isnanl-nolibm.h: Update.
1407         * gnulib/import/isnanl.c: Update.
1408         * gnulib/import/itold.c: Update.
1409         * gnulib/import/libc-config.h: Update.
1410         * gnulib/import/limits.in.h: Update.
1411         * gnulib/import/localcharset.c: Update.
1412         * gnulib/import/localcharset.h: Update.
1413         * gnulib/import/localtime-buffer.c: Update.
1414         * gnulib/import/localtime-buffer.h: Update.
1415         * gnulib/import/lstat.c: Update.
1416         * gnulib/import/m4/00gnulib.m4: Update.
1417         * gnulib/import/m4/__inline.m4: Update.
1418         * gnulib/import/m4/absolute-header.m4: Update.
1419         * gnulib/import/m4/alloca.m4: Update.
1420         * gnulib/import/m4/builtin-expect.m4: Update.
1421         * gnulib/import/m4/canonicalize.m4: Update.
1422         * gnulib/import/m4/chdir-long.m4: Update.
1423         * gnulib/import/m4/close.m4: Update.
1424         * gnulib/import/m4/closedir.m4: Update.
1425         * gnulib/import/m4/configmake.m4: Update.
1426         * gnulib/import/m4/d-ino.m4: Update.
1427         * gnulib/import/m4/d-type.m4: Update.
1428         * gnulib/import/m4/dirent_h.m4: Update.
1429         * gnulib/import/m4/dirfd.m4: Update.
1430         * gnulib/import/m4/dirname.m4: Update.
1431         * gnulib/import/m4/double-slash-root.m4: Update.
1432         * gnulib/import/m4/dup.m4: Update.
1433         * gnulib/import/m4/dup2.m4: Update.
1434         * gnulib/import/m4/eealloc.m4: Update.
1435         * gnulib/import/m4/environ.m4: Update.
1436         * gnulib/import/m4/errno_h.m4: Update.
1437         * gnulib/import/m4/error.m4: Update.
1438         * gnulib/import/m4/exponentd.m4: Update.
1439         * gnulib/import/m4/exponentl.m4: Update.
1440         * gnulib/import/m4/extensions.m4: Update.
1441         * gnulib/import/m4/extern-inline.m4: Update.
1442         * gnulib/import/m4/fchdir.m4: Update.
1443         * gnulib/import/m4/fcntl-o.m4: Update.
1444         * gnulib/import/m4/fcntl.m4: Update.
1445         * gnulib/import/m4/fcntl_h.m4: Update.
1446         * gnulib/import/m4/fdopendir.m4: Update.
1447         * gnulib/import/m4/filenamecat.m4: Update.
1448         * gnulib/import/m4/flexmember.m4: Update.
1449         * gnulib/import/m4/float_h.m4: Update.
1450         * gnulib/import/m4/fnmatch.m4: Update.
1451         * gnulib/import/m4/fnmatch_h.m4: Update.
1452         * gnulib/import/m4/fpieee.m4: Update.
1453         * gnulib/import/m4/frexp.m4: Update.
1454         * gnulib/import/m4/frexpl.m4: Update.
1455         * gnulib/import/m4/fstat.m4: Update.
1456         * gnulib/import/m4/fstatat.m4: Update.
1457         * gnulib/import/m4/getcwd-abort-bug.m4: Update.
1458         * gnulib/import/m4/getcwd-path-max.m4: Update.
1459         * gnulib/import/m4/getcwd.m4: Update.
1460         * gnulib/import/m4/getdtablesize.m4: Update.
1461         * gnulib/import/m4/getlogin.m4: Update.
1462         * gnulib/import/m4/getlogin_r.m4: Update.
1463         * gnulib/import/m4/getpagesize.m4: Update.
1464         * gnulib/import/m4/getprogname.m4: Update.
1465         * gnulib/import/m4/gettimeofday.m4: Update.
1466         * gnulib/import/m4/glibc21.m4: Update.
1467         * gnulib/import/m4/glob.m4: Update.
1468         * gnulib/import/m4/glob_h.m4: Update.
1469         * gnulib/import/m4/gnulib-cache.m4: Update.
1470         * gnulib/import/m4/gnulib-common.m4: Update.
1471         * gnulib/import/m4/gnulib-comp.m4: Update.
1472         * gnulib/import/m4/gnulib-tool.m4: Update.
1473         * gnulib/import/m4/hard-locale.m4: Update.
1474         * gnulib/import/m4/include_next.m4: Update.
1475         * gnulib/import/m4/inttypes-pri.m4: Update.
1476         * gnulib/import/m4/inttypes.m4: Update.
1477         * gnulib/import/m4/isnand.m4: Update.
1478         * gnulib/import/m4/isnanl.m4: Update.
1479         * gnulib/import/m4/largefile.m4: Update.
1480         * gnulib/import/m4/limits-h.m4: Update.
1481         * gnulib/import/m4/localcharset.m4: Update.
1482         * gnulib/import/m4/locale-fr.m4: Update.
1483         * gnulib/import/m4/locale-ja.m4: Update.
1484         * gnulib/import/m4/locale-zh.m4: Update.
1485         * gnulib/import/m4/localtime-buffer.m4: Update.
1486         * gnulib/import/m4/longlong.m4: Update.
1487         * gnulib/import/m4/lstat.m4: Update.
1488         * gnulib/import/m4/malloc.m4: Update.
1489         * gnulib/import/m4/malloca.m4: Update.
1490         * gnulib/import/m4/math_h.m4: Update.
1491         * gnulib/import/m4/mbrtowc.m4: Update.
1492         * gnulib/import/m4/mbsinit.m4: Update.
1493         * gnulib/import/m4/mbsrtowcs.m4: Update.
1494         * gnulib/import/m4/mbstate_t.m4: Update.
1495         * gnulib/import/m4/memchr.m4: Update.
1496         * gnulib/import/m4/memmem.m4: Update.
1497         * gnulib/import/m4/mempcpy.m4: Update.
1498         * gnulib/import/m4/memrchr.m4: Update.
1499         * gnulib/import/m4/mkdir.m4: Update.
1500         * gnulib/import/m4/mkstemp.m4: Update.
1501         * gnulib/import/m4/mmap-anon.m4: Update.
1502         * gnulib/import/m4/mode_t.m4: Update.
1503         * gnulib/import/m4/msvc-inval.m4: Update.
1504         * gnulib/import/m4/msvc-nothrow.m4: Update.
1505         * gnulib/import/m4/multiarch.m4: Update.
1506         * gnulib/import/m4/nocrash.m4: Update.
1507         * gnulib/import/m4/off_t.m4: Update.
1508         * gnulib/import/m4/onceonly.m4: Update.
1509         * gnulib/import/m4/open-cloexec.m4: Update.
1510         * gnulib/import/m4/open.m4: Update.
1511         * gnulib/import/m4/openat.m4: Update.
1512         * gnulib/import/m4/opendir.m4: Update.
1513         * gnulib/import/m4/pathmax.m4: Update.
1514         * gnulib/import/m4/rawmemchr.m4: Update.
1515         * gnulib/import/m4/readdir.m4: Update.
1516         * gnulib/import/m4/readlink.m4: Update.
1517         * gnulib/import/m4/realloc.m4: Update.
1518         * gnulib/import/m4/rename.m4: Update.
1519         * gnulib/import/m4/rewinddir.m4: Update.
1520         * gnulib/import/m4/rmdir.m4: Update.
1521         * gnulib/import/m4/save-cwd.m4: Update.
1522         * gnulib/import/m4/secure_getenv.m4: Update.
1523         * gnulib/import/m4/setenv.m4: Update.
1524         * gnulib/import/m4/signal_h.m4: Update.
1525         * gnulib/import/m4/ssize_t.m4: Update.
1526         * gnulib/import/m4/stat-time.m4: Update.
1527         * gnulib/import/m4/stat.m4: Update.
1528         * gnulib/import/m4/std-gnu11.m4: Update.
1529         * gnulib/import/m4/stdbool.m4: Update.
1530         * gnulib/import/m4/stddef_h.m4: Update.
1531         * gnulib/import/m4/stdint.m4: Update.
1532         * gnulib/import/m4/stdio_h.m4: Update.
1533         * gnulib/import/m4/stdlib_h.m4: Update.
1534         * gnulib/import/m4/strchrnul.m4: Update.
1535         * gnulib/import/m4/strdup.m4: Update.
1536         * gnulib/import/m4/strerror.m4: Update.
1537         * gnulib/import/m4/string_h.m4: Update.
1538         * gnulib/import/m4/strstr.m4: Update.
1539         * gnulib/import/m4/strtok_r.m4: Update.
1540         * gnulib/import/m4/sys_socket_h.m4: Update.
1541         * gnulib/import/m4/sys_stat_h.m4: Update.
1542         * gnulib/import/m4/sys_time_h.m4: Update.
1543         * gnulib/import/m4/sys_types_h.m4: Update.
1544         * gnulib/import/m4/tempname.m4: Update.
1545         * gnulib/import/m4/time_h.m4: Update.
1546         * gnulib/import/m4/unistd-safer.m4: Update.
1547         * gnulib/import/m4/unistd_h.m4: Update.
1548         * gnulib/import/m4/warn-on-use.m4: Update.
1549         * gnulib/import/m4/wchar_h.m4: Update.
1550         * gnulib/import/m4/wchar_t.m4: Update.
1551         * gnulib/import/m4/wctype_h.m4: Update.
1552         * gnulib/import/m4/wint_t.m4: Update.
1553         * gnulib/import/malloc.c: Update.
1554         * gnulib/import/malloc/scratch_buffer.h: Update.
1555         * gnulib/import/malloc/scratch_buffer_grow.c: Update.
1556         * gnulib/import/malloc/scratch_buffer_grow_preserve.c: Update.
1557         * gnulib/import/malloc/scratch_buffer_set_array_size.c: Update.
1558         * gnulib/import/malloca.c: Update.
1559         * gnulib/import/malloca.h: Update.
1560         * gnulib/import/malloca.valgrind: Update.
1561         * gnulib/import/math.in.h: Update.
1562         * gnulib/import/mbrtowc.c: Update.
1563         * gnulib/import/mbsinit.c: Update.
1564         * gnulib/import/mbsrtowcs-impl.h: Update.
1565         * gnulib/import/mbsrtowcs-state.c: Update.
1566         * gnulib/import/mbsrtowcs.c: Update.
1567         * gnulib/import/memchr.c: Update.
1568         * gnulib/import/memmem.c: Update.
1569         * gnulib/import/mempcpy.c: Update.
1570         * gnulib/import/memrchr.c: Update.
1571         * gnulib/import/mkdir.c: Update.
1572         * gnulib/import/mkstemp.c: Update.
1573         * gnulib/import/msvc-inval.c: Update.
1574         * gnulib/import/msvc-inval.h: Update.
1575         * gnulib/import/msvc-nothrow.c: Update.
1576         * gnulib/import/msvc-nothrow.h: Update.
1577         * gnulib/import/open.c: Update.
1578         * gnulib/import/openat-die.c: Update.
1579         * gnulib/import/openat-priv.h: Update.
1580         * gnulib/import/openat-proc.c: Update.
1581         * gnulib/import/openat.c: Update.
1582         * gnulib/import/openat.h: Update.
1583         * gnulib/import/opendir.c: Update.
1584         * gnulib/import/pathmax.h: Update.
1585         * gnulib/import/pipe-safer.c: Update.
1586         * gnulib/import/rawmemchr.c: Update.
1587         * gnulib/import/readdir.c: Update.
1588         * gnulib/import/readlink.c: Update.
1589         * gnulib/import/realloc.c: Update.
1590         * gnulib/import/ref-add.sin: Update.
1591         * gnulib/import/ref-del.sin: Update.
1592         * gnulib/import/rename.c: Update.
1593         * gnulib/import/rewinddir.c: Update.
1594         * gnulib/import/rmdir.c: Update.
1595         * gnulib/import/same-inode.h: Update.
1596         * gnulib/import/save-cwd.c: Update.
1597         * gnulib/import/save-cwd.h: Update.
1598         * gnulib/import/scratch_buffer.h: Update.
1599         * gnulib/import/secure_getenv.c: Update.
1600         * gnulib/import/setenv.c: Update.
1601         * gnulib/import/signal.in.h: Update.
1602         * gnulib/import/stat-time.c: Update.
1603         * gnulib/import/stat-time.h: Update.
1604         * gnulib/import/stat-w32.c: Update.
1605         * gnulib/import/stat-w32.h: Update.
1606         * gnulib/import/stat.c: Update.
1607         * gnulib/import/stdbool.in.h: Update.
1608         * gnulib/import/stddef.in.h: Update.
1609         * gnulib/import/stdint.in.h: Update.
1610         * gnulib/import/stdio.in.h: Update.
1611         * gnulib/import/stdlib.in.h: Update.
1612         * gnulib/import/str-two-way.h: Update.
1613         * gnulib/import/strchrnul.c: Update.
1614         * gnulib/import/strdup.c: Update.
1615         * gnulib/import/streq.h: Update.
1616         * gnulib/import/strerror-override.c: Update.
1617         * gnulib/import/strerror-override.h: Update.
1618         * gnulib/import/strerror.c: Update.
1619         * gnulib/import/string.in.h: Update.
1620         * gnulib/import/stripslash.c: Update.
1621         * gnulib/import/strnlen1.c: Update.
1622         * gnulib/import/strnlen1.h: Update.
1623         * gnulib/import/strstr.c: Update.
1624         * gnulib/import/strtok_r.c: Update.
1625         * gnulib/import/sys_stat.in.h: Update.
1626         * gnulib/import/sys_time.in.h: Update.
1627         * gnulib/import/sys_types.in.h: Update.
1628         * gnulib/import/tempname.c: Update.
1629         * gnulib/import/tempname.h: Update.
1630         * gnulib/import/time.in.h: Update.
1631         * gnulib/import/unistd--.h: Update.
1632         * gnulib/import/unistd-safer.h: Update.
1633         * gnulib/import/unistd.in.h: Update.
1634         * gnulib/import/unsetenv.c: Update.
1635         * gnulib/import/verify.h: Update.
1636         * gnulib/import/extra/snippet/warn-on-use.h: Update.
1637         * gnulib/import/wchar.in.h: Update.
1638         * gnulib/import/wctype.in.h: Update.
1639         * gnulib/import/xalloc-oversized.h: Update.
1640         * gnulib/update-gnulib.sh (GNULIB_COMMIT_SHA1): Set to
1641         "53e2c179f26a890fa6685af4b6c1397ee370433b".
1642
1643 2018-09-10  Simon Marchi  <simon.marchi@ericsson.com>
1644
1645         * record-btrace.c (get_thread_current_frame): Remove
1646         old_inferior_ptid.
1647
1648 2018-09-10  Jerome Guitton  <guitton@adacore.com>
1649
1650         * ada-lang.c (ada_value_struct_elt): Call ada_to_fixed_type
1651         with check_tag to 1 if and only if the type is tagged and the
1652         component being searched cannot been found in the current
1653         view. Otherwise, always call ada_to_fixed_type with
1654         check_tag to 0.
1655
1656 2018-09-10  Xavier Roirand  <roirand@adacore.com>
1657
1658         * ada-lang.c (ada_is_access_to_unconstrained_array): Remove static
1659         declaration.
1660         * ada-lang.h: add ada_is_access_to_unconstrained_array prototype.
1661         * ada-varobj.c (ada_varobj_get_number_of_children,
1662         ada_varobj_describe_child, ada_value_is_changeable_p): Cleanup code.
1663
1664 2018-09-10  Xavier Roirand  <roirand@adacore.com>
1665
1666         * ada-valprint.c (ada_value_print): Use type instead of
1667         enclosing type.
1668
1669 2018-09-10  Xavier Roirand  <roirand@adacore.com>
1670
1671         * ada-lang.c (ada_value_subscript): Handle case when parameter is
1672         an array of access to unconstrained array.
1673
1674 2018-09-10  Xavier Roirand  <roirand@adacore.com>
1675
1676         * ada-lang.c (ada_is_access_to_unconstrained_array): New function.
1677         (ada_check_typedef): Use it.
1678
1679 2018-09-10  Xavier Roirand  <roirand@adacore.com>
1680
1681         * ada-varobj.c (ada_varobj_describe_struct_child)
1682         (ada_varobj_describe_child): Handle union case like struct one.
1683
1684 2018-09-10  Tom Tromey  <tom@tromey.com>
1685
1686         PR python/18380:
1687         * python/python.c (_initialize_python): Make example in "python"
1688         help work in Python 3.
1689
1690 2018-09-10  Eli Zaretskii  <eliz@gnu.org>
1691
1692         * Makefile.in (transformed_name): Use INSTALL_SCRIPT instead of
1693         INSTALL_PROGRAM to install gdb-add-index.sh.  Don't append
1694         $(EXEEXT) to the script, as it is not a program.
1695
1696 2018-09-09  Simon Marchi  <simon.marchi@ericsson.com>
1697
1698         * python/py-prettyprint.c (pretty_print_one_value): Return
1699         gdbpy_ref<>.
1700         (print_string_repr): Adjust.
1701         (apply_varobj_pretty_printer): Return gdbpy_ref<>.
1702         * python/python-internal.h (apply_varobj_pretty_printer): Return
1703         gdbpy_ref<>.
1704         * varobj.c (varobj_value_get_print_value): Adjust.
1705
1706 2018-09-08  Tom Tromey  <tom@tromey.com>
1707
1708         PR python/16047:
1709         * python/py-prettyprint.c (pretty_print_one_value): Check for
1710         to_string method.
1711
1712 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
1713
1714         * ada-lang.c (resolve_subexp): Pass correct OPLEN in call to
1715         replace_operator_with_call.
1716
1717 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
1718
1719         * ada-lang.c (ada_value_cast): Remove unnecessary parentheses.
1720
1721 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
1722
1723         * ada-typeprint.c (print_range): Print the bounds using TYPE
1724         rather than its TYPE_TARGET_TYPE.
1725
1726 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
1727
1728         * ada-lang.c (ada_to_fixed_value): Minor reformatting in
1729         call to ada_to_fixed_value_create.
1730
1731 2018-09-08  Jerome Guitton  <guitton@adacore.com>
1732
1733         * ada-lang.c (ada_decode): strip dot prefix in symbol name.
1734
1735 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
1736
1737         * ada-lang.c (ada_exception_sal): Replace gdb_assert calls
1738         by calls to error.
1739
1740 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
1741
1742         * ada-lang.c (ada_unhandled_exception_name_addr_from_raise):
1743         Move update of loop variable "fi".
1744
1745 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
1746
1747         * ada-lang.c (value_assign_to_component): In the case of
1748         big-endian targets, extract the bits of the given VAL
1749         using an src_offset of zero if container is not a scalar.
1750
1751 2018-09-06  Simon Ser  <contact@emersion.fr>
1752
1753         PR gdb/23105
1754         * fbsd-nat.c (fbsd_nat_target::xfer_partial): Add support for
1755         TARGET_OBJECT_FREEBSD_VMMAP and TARGET_OBJECT_FREEBSD_PS_STRINGS.
1756         * fbsd-tdep.c (fbsd_make_note_desc): New.
1757         (fbsd_make_corefile_notes): Write NT_PROCSTAT_AUXV,
1758         NT_PROCSTAT_VMMAP and NT_PROCSTAT_PS_STRINGS notes.
1759         * target.h (enum target_object) Add FreeBSD-specific
1760         TARGET_OBJECT_FREEBSD_VMMAP and TARGET_OBJECT_FREEBSD_PS_STRINGS.
1761
1762 2018-09-06  Simon Marchi  <simon.marchi@ericsson.com>
1763
1764         * compile/compile-c.h (generate_c_for_variable_locations):
1765         Change reference to pointer.
1766         * compile/compile-c-support.c (compile_program) <compute>:
1767         Likewise.
1768         * compile/compile-c-symbols.c (generate_vla_size): Likewise.
1769         (generate_c_for_for_one_variable): Likewise
1770         (generate_c_for_variable_locations): Likewise
1771         * compile/compile-c-types.c (compile_c_instance::convert_type):
1772         Likewise
1773         * compile/compile-cplus-symbols.c (convert_one_symbol):
1774         std::move the scope passed to enter_scope.
1775         * compile/compile-cplus-types.c
1776         (compile_cplus_instance::enter_scope): Make parameter
1777         rvalue-reference.
1778         (compile_cplus_instance::new_scope): Change reference to
1779         pointer.
1780         (compile_cplus_instance::convert_type): Likewise
1781         (compile_cplus_convert_typedef): std::move the scope passed to
1782         enter_scope.
1783         (compile_cplus_convert_struct_or_union): Likewise.
1784         (compile_cplus_convert_enum): Likewise.
1785         (compile_cplus_convert_namespace): Likewise.
1786         * compile/compile-cplus.h (compile_cplus_instance)
1787         <enter_scope>: Make parameter rvalue-reference.
1788         * compile/compile-internal.h (compile_instance)
1789         <get_cached_type>: Likewise
1790         * compile/compile-loc2c.c (push): Likewise
1791         (pushf): Likewise
1792         (unary): Likewise
1793         (binary): Likewise
1794         (print_label): Likewise
1795         (pushf_register_address): Likewise
1796         (pushf_register): Likewise
1797         (do_compile_dwarf_expr_to_c): Likewise
1798         (compile_dwarf_expr_to_c): Likewise
1799         (compile_dwarf_bounds_to_c): Likewise
1800         * compile/compile.c (compile_instance::get_cached_type):
1801         Likewise
1802         * compile/compile.h (compile_dwarf_expr_to_c): Likewise.
1803         (compile_dwarf_bounds_to_c): Likewise
1804         * dwarf2loc.c (locexpr_generate_c_location): Likewise.
1805         (dwarf2_compile_property_to_c): Likewise
1806         * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise
1807         * symtab.h (struct symbol_computed_ops) <generate_c_location>:
1808         Likewise
1809
1810 2018-09-06  Simon Marchi  <simon.marchi@ericsson.com>
1811
1812         * tui/tui-data.h (struct tui_win_element) <highlight>: Remove.
1813         * tui/tui-data.c (init_content_element): Don't initialize it.
1814
1815 2018-09-06  Simon Marchi  <simon.marchi@ericsson.com>
1816
1817         * tui/tui-data.h (struct tui_win_info)
1818         <detail::opaque>: Remove.
1819         * tui/tui-data.c (init_win_info): Remove assignment.
1820
1821 2018-09-05  Tom Tromey  <tom@tromey.com>
1822
1823         * warning.m4 (AM_GDB_WARNINGS): Add -Wformat when testing
1824         -Wformat-nonliteral.
1825         * target-float.c (host_float_ops<T>::to_string)
1826         (host_float_ops<T>::from_string): Use
1827         DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL.
1828         * configure: Rebuild.
1829
1830 2018-09-05  Simon Marchi  <simon.marchi@ericsson.com>
1831
1832         * printcmd.c (printf_c_string): Use
1833         DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL.
1834         (printf_wide_c_string, printf_pointer, ui_printf): Likewise.
1835
1836 2018-09-05  Tom Tromey  <tom@tromey.com>
1837
1838         * cli/cli-cmds.c (shell_escape, edit_command): Remove cast.
1839
1840 2018-09-05  Tom de Vries  <tdevries@suse.de>
1841
1842         * dwarf2loc.c (sect_variable_value): Call indirect_synthetic_pointer
1843         with resolve_abstract_p == true.
1844         (indirect_synthetic_pointer): Add resolve_abstract_p parameter,
1845         defaulting to false. Propagate resolve_abstract_p to
1846         dwarf2_fetch_die_loc_sect_off.
1847         * dwarf2loc.h (dwarf2_fetch_die_loc_sect_off): Add resolve_abstract_p
1848         parameter, defaulting to false.
1849         * dwarf2read.c (read_variable): Add variable to abstract_to_concrete.
1850         (dwarf2_fetch_die_loc_sect_off): Add and handle resolve_abstract_p
1851         parameter.
1852         * dwarf2read.h (struct die_info): Forward-declare.
1853         (die_info_ptr): New typedef.
1854         (struct dwarf2_per_objfile): Add abstract_to_concrete field.
1855
1856 2018-09-05  Joel Brobecker  <brobecker@adacore.com>
1857
1858         GDB 8.2 released.
1859
1860 2018-09-04  Sergio Durigan Junior  <sergiodj@redhat.com>
1861             Pedro Alves  <palves@redhat.com>
1862
1863         * gnulib/Makefile.in (aclocal_m4_deps): Move to
1864         "aclocal-m4-deps.mk".  Include file here.
1865         $(srcdir)/aclocal.m4: Add "configure.ac".
1866         * gnulib/aclocal-m4-deps.mk: New file.
1867         * gnulib/update-gnulib.sh: Automatically update
1868         "aclocal-m4-deps.mk".
1869
1870 2018-09-04  Tom Tromey  <tom@tromey.com>
1871
1872         * configure: Rebuild.
1873         * configure.ac: Remove multi-ice code.
1874
1875 2018-09-04  Tom Tromey  <tom@tromey.com>
1876
1877         * Makefile.in (GDB_WARN_CFLAGS_NO_DEFS): Remove.
1878         (ada-exp.o): Update.
1879
1880 2018-09-04  Tom Tromey  <tom@tromey.com>
1881
1882         * Makefile.in (printcmd.o, target-float.o): Remove.
1883         (GDB_WARN_CFLAGS_NO_FORMAT): Remove.
1884
1885 2018-09-04  Tom Tromey  <tom@tromey.com>
1886
1887         * gnulib/Makefile.in: Remove obsolete comment.
1888         * Makefile.in: Remove obsolete comment.
1889
1890 2018-09-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * riscv-tdep.c (riscv_frame_cache): Fix ARI warning, don't end a
1893         line with '+'.
1894
1895 2018-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1896
1897         * riscv-tdep.c: Add 'prologue-value.h' include.
1898         (struct riscv_unwind_cache): New struct.
1899         (riscv_debug_unwinder): New global.
1900         (riscv_scan_prologue): Update arguments, capture register details
1901         from prologue scan.
1902         (riscv_skip_prologue): Reformat arguments line, move end of
1903         prologue calculation into riscv_scan_prologue.
1904         (riscv_frame_cache): Update return type, create
1905         riscv_unwind_cache, scan the prologue, and fill in remaining cache
1906         details.
1907         (riscv_frame_this_id): Use frame id computed in riscv_frame_cache.
1908         (riscv_frame_prev_register): Use the trad_frame within the
1909         riscv_unwind_cache.
1910         (_initialize_riscv_tdep): Add 'set/show debug riscv unwinder'
1911         flag.
1912
1913 2018-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1914
1915         * trad-frame.h (trad_frame_set_realreg): Declare.
1916         (trad_frame_set_addr): Declare.
1917         * trad-frame.c (trad_frame_set_realreg): Define new function.
1918         (trad_frame_set_addr): Define new function.
1919         (trad_frame_set_reg_realreg): Use new function.
1920         (trad_frame_set_reg_addr): Use new function.
1921
1922 2018-09-01  Keith Seitz  <keiths@redhat.com>
1923
1924         * compile/compile-cplus-types.c (compile_cplus_debug_output_1): Use
1925         pulongest instead of "%lld".
1926         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol): Remove
1927         ATTRIBUTE_UNUSED.
1928
1929 2018-08-31  Tom Tromey  <tom@tromey.com>
1930
1931         * dwarf2read.c (dwarf2_add_field): Set the TYPE_LENGTH of the
1932         variant part type.
1933
1934 2018-08-31  Pedro Alves  <palves@redhat.com>
1935
1936         * gdbarch.h: Regenerate.
1937
1938 2018-08-31  Pedro Alves  <palves@redhat.com>
1939
1940         * gdbarch.sh (have_nonsteppable_watchpoint): Add comment.
1941         * target.h (Hardware watchpoint interfaces): Describe
1942         continuable/steppable/non-steppable watchpoints.
1943         * gdbarch.h, gdbarch.c: Regenerate.
1944
1945 2018-08-31  Pedro Alves  <palves@redhat.com>
1946
1947         * nto-procfs.c (nto_procfs_target::have_continuable_watchpoint):
1948         Delete.
1949         * s390-linux-nat.c
1950         (s390_linux_nat_target::have_continuable_watchpoint): Delete.
1951         * target.h (target_ops::have_continuable_watchpoint): Delete.
1952         (target_have_continuable_watchpoint): Delete.
1953         * x86-nat.h (x86_nat_target::have_continuable_watchpoint): Delete.
1954         * target-delegates.c: Regenerate.
1955
1956 2018-08-31  Sergio Durigan Junior  <sergiodj@redhat.com>
1957
1958         * gnulib/Makefile.in (aclocal_m4_deps): Update according to
1959         the files present in "gnulib/import/m4/".
1960
1961 2018-08-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1962
1963         * riscv-tdep.c (riscv_insn::decode): Decode c.addi4spn, c.sd,
1964         c.sw, c.swsp, and c.sdsp.
1965
1966 2018-08-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1967
1968         * riscv-tdep.c (struct riscv_inferior_data): Delete.
1969         (riscv_read_misa_reg): Don't cache value read into inferior data.
1970         (riscv_new_inferior_data): Delete.
1971         (riscv_inferior_data_cleanup): Delete.
1972         (riscv_inferior_data): Delete.
1973         (riscv_invalidate_inferior_data): Delete.
1974         (_initialize_riscv_tdep): Remove initialisation of inferior data.
1975
1976 2018-08-30  Simon Marchi  <simon.marchi@ericsson.com>
1977
1978         * compile/compile-cplus-types.c
1979         (compile_cplus_instance::leave_scope): Take the address of scope
1980         object.
1981         (compile_cplus_instance::convert_qualified_base): Compare quals
1982         to 0.
1983
1984 2018-08-30  Keith Seitz  <keiths@redhat.com>
1985
1986         * compile/compile-cplus-types.c (compile_cplus_instance::enter_scope):
1987         Use "%s" and host_address_to_string instead of "%p" in printf.
1988
1989 2018-08-29  Keith Seitz  <keiths@redhat.com>
1990
1991         * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Add compile-cplus-symbols.c
1992         and compile-cplus-types.c.
1993         (HFILES_NO_SRCDIR): Add gcc-cp-plugin.h.
1994         * c-lang.c (cplus_language_defn): Set C++ compile functions.
1995         * c-lang.h (cplus_get_compile_context, cplus_compute_program):
1996         Declare.
1997         * compile/compile-c-support.c: Include compile-cplus.h.
1998         (load_libcompile): Templatize.
1999         (get_compile_context): "New" function.
2000         (c_get_compile_context): Use get_compile_context.
2001         (cplus_get_compile_context): New function.
2002         (cplus_push_user_expression, cplus_pop_user_expression)
2003         (cplus_add_code_header, cplus_add_input, cplus_compile_program)
2004         (cplus_compute_program): Define new structs/functions.
2005         * compile/compile-cplus-symmbols.c: New file.
2006         * compile/compile-cplus-types.c: New file.
2007         * compile/compile-cplus.h: New file.
2008         * compile/compile-internal.h (debug_compile_oracle, GCC_TYPE_NONE):
2009         Declare.
2010         * compile/compile-object-load.c (get_out_value_type): Use
2011         strncmp_iw when comparing symbol names.
2012         (compile_object_load): Add mst_bss and mst_data.
2013         * compile/compile.c (_initialize_compile): Remove
2014         -Wno-implicit-function-declaration from `compile_args'.
2015         * compile/gcc-cp-plugin.h: New file.
2016         * NEWS: Mention C++ compile support and new debug options.
2017
2018 2018-08-29  Keith Seitz  <keiths@redhat.com>
2019
2020         * linespec.c (collect_info::add_symbol): Make virtual.
2021         (struct symbol_searcher_collect_info): New struct.
2022         (symbol_searcher::find_all_symbols): New method.
2023         * symtab.h (class symbol_searcher): New class.
2024
2025 2018-08-29  Keith Seitz  <keiths@redhat.com>
2026
2027         * linespec.c (struct linespec) <function_symbols, label_symbols>:
2028         Change to vector of block_symbol.  Update all users.
2029         (struct collect_info) <symbols>: Likewise.
2030         (collect_info::add_symbol): Take block_symbol as argument.
2031         Update all callers.
2032         (decode_compound_collector) <m_symbols>: Change type to vector
2033         of block_symbol.  Update all users.
2034         (decode_compound_collector::operator ()): Change parameter type
2035         to block_symbol.
2036         (find_method, find_function_symbols, find_linespec_symbols)
2037         (find_label_symbols_in_block, find_label_symbols): Change symbol
2038         vectors to block_symbol vectors.
2039         * symtab.h (symbol_found_callback_ftype): Change parameter type to
2040         block_symbol.
2041
2042 2018-08-29  Keith Seitz  <keiths@redhat.com>
2043
2044         * linespec.c (symbolp): Remove typedef and VEC definitions.
2045         (bound_minimal_symbol_d): Likewise.
2046
2047 2018-08-29  Keith Seitz  <keiths@redhat.com>
2048
2049         * linespec.c (decode_compound_collector::decode_compound_collector):
2050         Remove initialization for `m_symtabs'.
2051         (decode_compound_collector::release_symbols): Change return type
2052         to std::vector.  Update all callers.
2053         (class decode_compound_collector) <m_symbols>: Change type to
2054         std::vector.
2055         (lookup_prefix_sym): Change return type to std::vector.  Update all
2056         callers.
2057         (compare_symbols): Remove.
2058         (std_compare_symbols): Rename to `compare_symbols'.
2059         (find_method): Change `sym_classes' parameter to std::vector.
2060         Update all callers.  Use std::sort to sort sym_classes.
2061         (find_linespec_symbols): Remove cleanup.
2062
2063 2018-08-29  Keith Seitz  <keiths@redhat.com>
2064
2065         * linespec.c (struct linespec) <minimal_symbols>: Change type to
2066         std::vector.  Update all users.
2067         (convert_linespec_to_sals): Use std::sort to sort minimal symbols.
2068         (struct collect_info) <minimal_symbols>: Likewise.
2069         (compare_msymbols): Return bool.  Change parameters to const
2070         bound_minimal_symbol references.
2071         (find_method, find_function_symbols, find_linespec_symbols): Change
2072         `minsyms' parameter to std::vector.  Update all callers.
2073
2074 2018-08-29  Keith Seitz  <keiths@redhat.com>
2075
2076         * linespec.c (struct linespec) <label_symbols>: Change type to
2077         std::vector.  Update all users.
2078         (find_label_symbols_in_block): Change `result' parameter to
2079         std::vector.  Update all callers.
2080         (find_label_symbols): Return std::vector.  Update all callers.
2081
2082 2018-08-29  Keith Seitz  <keiths@redhat.com>
2083
2084         * linespec.c (struct linespec) <function_symbols>: Change type to
2085         std::vector.  Update all users.
2086         (struct collect_info) <function_symbols>: Likewise.
2087         (convert_linespec_to_sals): Use std::sort to sort function_symbols.
2088         (std_compare_symbols): New function.
2089         (find_method, find_function_symbols, find_linespec_symbols)
2090         (find_label_symbols_in_block): Change `symbols' parameter to
2091         std::vector.  Update all callers.
2092         (find_label_symbols): Likewise for `function_symbols' and
2093         `label_funcs_ret'.
2094
2095 2018-08-29  Keith Seitz  <keiths@redhat.com>
2096
2097         * linespec.c (symtab_vector_up): Define.
2098         (struct linespec) <file_symtabs>: Change type to std::vector *.
2099         Update all uses.
2100         (struct collect_info) <file_symtabs>: Likewise.
2101         (collect_symtabs_from_filename): Return symtab_vector_up.
2102         Update all callers.
2103         (decode_objc): Remove cleanup.
2104         (symtab_collector::symtab_collector): Initialize `m_symtabs'.
2105         (symtab_collector::release_symtabs): Return symtab_vector_up.
2106         Update all callers.
2107         (class symtab_collector) <m_symtabs>: Change type to symtab_vector_up.
2108         Update all users.
2109         (collect_symtabs_from_filename, symtabs_from_filename): Return
2110         symtab_vector_up.  Update all callers.
2111
2112 2018-08-29  Tom Tromey  <tom@tromey.com>
2113
2114         * csky-tdep.c (csky_analyze_prologue): Use
2115         core_addr_to_string_nz.
2116
2117 2018-08-29  Tom Tromey  <tom@tromey.com>
2118
2119         * windows-nat.c (struct xlate_exception) <them>: Change type to
2120         DWORD.
2121         (xlate): Fix formatting.  Remove last entry.
2122         (struct xlate_exception, xlate): Comment out.
2123         (windows_nat_target::resume): Use ranged for.
2124
2125 2018-08-29  Jim Wilson  <jimw@sifive.com>
2126
2127         * riscv-linux-nat.c: Include elf/common.h instead of elf.h.
2128         (riscv_linux_nat_target::fetch_registers): Use NT_FPREGSET instead
2129         of NT_PRFPREG.
2130         (riscv_linux_nat_target::store_registers): Likewise.
2131
2132 2018-08-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2133
2134         PR gdb/23555
2135         PR gdb/23558
2136         * gnulib/aclocal.m4: Regenerate.
2137         * gnulib/config.in: Regenerate.
2138         * gnulib/configure: Regenerate.
2139         * gnulib/import/Makefile.am: Update.
2140         * gnulib/import/Makefile.in: Update.
2141         * gnulib/import/extra/snippet/_Noreturn.h: Rename to...
2142         * gnulib/import/_Noreturn.h: ... this.
2143         * gnulib/import/alloca.in.h: Update.
2144         * gnulib/import/extra/snippet/arg-nonnull.h: Rename to...
2145         * gnulib/import/arg-nonnull.h: ... this.
2146         * gnulib/import/assure.h: Update.
2147         * gnulib/import/at-func.c: Update.
2148         * gnulib/import/basename-lgpl.c: Update.
2149         * gnulib/import/extra/snippet/c++defs.h: Rename to...
2150         * gnulib/import/c++defs.h: ... this.
2151         * gnulib/import/canonicalize-lgpl.c: Update.
2152         * gnulib/import/cdefs.h: Update.
2153         * gnulib/import/chdir-long.c: Update.
2154         * gnulib/import/chdir-long.h: Update.
2155         * gnulib/import/cloexec.c: Update.
2156         * gnulib/import/cloexec.h: Update.
2157         * gnulib/import/close.c: Update.
2158         * gnulib/import/closedir.c: Update.
2159         * gnulib/import/config.charset: Update.
2160         * gnulib/import/dirent-private.h: Update.
2161         * gnulib/import/dirent.in.h: Update.
2162         * gnulib/import/dirfd.c: Update.
2163         * gnulib/import/dirname-lgpl.c: Update.
2164         * gnulib/import/dirname.h: Update.
2165         * gnulib/import/dosname.h: Update.
2166         * gnulib/import/dup-safer-flag.c: Update.
2167         * gnulib/import/dup-safer.c: Update.
2168         * gnulib/import/dup.c: Update.
2169         * gnulib/import/dup2.c: Update.
2170         * gnulib/import/errno.in.h: Update.
2171         * gnulib/import/error.c: Update.
2172         * gnulib/import/error.h: Update.
2173         * gnulib/import/exitfail.c: Update.
2174         * gnulib/import/exitfail.h: Update.
2175         * gnulib/import/extra/update-copyright: Update.
2176         * gnulib/import/fchdir.c: Update.
2177         * gnulib/import/fcntl.c: Update.
2178         * gnulib/import/fcntl.in.h: Update.
2179         * gnulib/import/fd-hook.c: Update.
2180         * gnulib/import/fd-hook.h: Update.
2181         * gnulib/import/fd-safer-flag.c: Update.
2182         * gnulib/import/fd-safer.c: Update.
2183         * gnulib/import/fdopendir.c: Update.
2184         * gnulib/import/filename.h: Update.
2185         * gnulib/import/filenamecat-lgpl.c: Update.
2186         * gnulib/import/filenamecat.h: Update.
2187         * gnulib/import/flexmember.h: Update.
2188         * gnulib/import/float+.h: Update.
2189         * gnulib/import/float.c: Update.
2190         * gnulib/import/float.in.h: Update.
2191         * gnulib/import/fnmatch.c: Update.
2192         * gnulib/import/fnmatch.in.h: Update.
2193         * gnulib/import/fnmatch_loop.c: Update.
2194         * gnulib/import/fpucw.h: Update.
2195         * gnulib/import/frexp.c: Update.
2196         * gnulib/import/frexpl.c: Update.
2197         * gnulib/import/fstat.c: Update.
2198         * gnulib/import/fstatat.c: Update.
2199         * gnulib/import/getcwd-lgpl.c: Update.
2200         * gnulib/import/getcwd.c: Update.
2201         * gnulib/import/getdtablesize.c: Update.
2202         * gnulib/import/getlogin_r.c: Update.
2203         * gnulib/import/getprogname.c: Update.
2204         * gnulib/import/getprogname.h: Update.
2205         * gnulib/import/gettext.h: Update.
2206         * gnulib/import/gettimeofday.c: Update.
2207         * gnulib/import/glob-libc.h: Update.
2208         * gnulib/import/glob.c: Update.
2209         * gnulib/import/glob.in.h: Update.
2210         * gnulib/import/glob_internal.h: Update.
2211         * gnulib/import/glob_pattern_p.c: Update.
2212         * gnulib/import/globfree.c: Update.
2213         * gnulib/import/hard-locale.c: Update.
2214         * gnulib/import/hard-locale.h: Update.
2215         * gnulib/import/intprops.h: Update.
2216         * gnulib/import/inttypes.in.h: Update.
2217         * gnulib/import/isnan.c: Update.
2218         * gnulib/import/isnand-nolibm.h: Update.
2219         * gnulib/import/isnand.c: Update.
2220         * gnulib/import/isnanl-nolibm.h: Update.
2221         * gnulib/import/isnanl.c: Update.
2222         * gnulib/import/itold.c: Update.
2223         * gnulib/import/libc-config.h: Update.
2224         * gnulib/import/limits.in.h: Update.
2225         * gnulib/import/localcharset.c: Update.
2226         * gnulib/import/localcharset.h: Update.
2227         * gnulib/import/localtime-buffer.c: Update.
2228         * gnulib/import/localtime-buffer.h: Update.
2229         * gnulib/import/lstat.c: Update.
2230         * gnulib/import/m4/00gnulib.m4: Update.
2231         * gnulib/import/m4/__inline.m4: Update.
2232         * gnulib/import/m4/absolute-header.m4: Update.
2233         * gnulib/import/m4/alloca.m4: Update.
2234         * gnulib/import/m4/builtin-expect.m4: Update.
2235         * gnulib/import/m4/canonicalize.m4: Update.
2236         * gnulib/import/m4/chdir-long.m4: Update.
2237         * gnulib/import/m4/close.m4: Update.
2238         * gnulib/import/m4/closedir.m4: Update.
2239         * gnulib/import/m4/configmake.m4: Update.
2240         * gnulib/import/m4/d-ino.m4: Update.
2241         * gnulib/import/m4/d-type.m4: Update.
2242         * gnulib/import/m4/dirent_h.m4: Update.
2243         * gnulib/import/m4/dirfd.m4: Update.
2244         * gnulib/import/m4/dirname.m4: Update.
2245         * gnulib/import/m4/double-slash-root.m4: Update.
2246         * gnulib/import/m4/dup.m4: Update.
2247         * gnulib/import/m4/dup2.m4: Update.
2248         * gnulib/import/m4/eealloc.m4: Update.
2249         * gnulib/import/m4/environ.m4: Update.
2250         * gnulib/import/m4/errno_h.m4: Update.
2251         * gnulib/import/m4/error.m4: Update.
2252         * gnulib/import/m4/exponentd.m4: Update.
2253         * gnulib/import/m4/exponentl.m4: Update.
2254         * gnulib/import/m4/extensions.m4: Update.
2255         * gnulib/import/m4/extern-inline.m4: Update.
2256         * gnulib/import/m4/fchdir.m4: Update.
2257         * gnulib/import/m4/fcntl-o.m4: Update.
2258         * gnulib/import/m4/fcntl.m4: Update.
2259         * gnulib/import/m4/fcntl_h.m4: Update.
2260         * gnulib/import/m4/fdopendir.m4: Update.
2261         * gnulib/import/m4/filenamecat.m4: Update.
2262         * gnulib/import/m4/flexmember.m4: Update.
2263         * gnulib/import/m4/float_h.m4: Update.
2264         * gnulib/import/m4/fnmatch.m4: Update.
2265         * gnulib/import/m4/fnmatch_h.m4: Update.
2266         * gnulib/import/m4/fpieee.m4: Update.
2267         * gnulib/import/m4/frexp.m4: Update.
2268         * gnulib/import/m4/frexpl.m4: Update.
2269         * gnulib/import/m4/fstat.m4: Update.
2270         * gnulib/import/m4/fstatat.m4: Update.
2271         * gnulib/import/m4/getcwd-abort-bug.m4: Update.
2272         * gnulib/import/m4/getcwd-path-max.m4: Update.
2273         * gnulib/import/m4/getcwd.m4: Update.
2274         * gnulib/import/m4/getdtablesize.m4: Update.
2275         * gnulib/import/m4/getlogin.m4: Update.
2276         * gnulib/import/m4/getlogin_r.m4: Update.
2277         * gnulib/import/m4/getpagesize.m4: Update.
2278         * gnulib/import/m4/getprogname.m4: Update.
2279         * gnulib/import/m4/gettimeofday.m4: Update.
2280         * gnulib/import/m4/glibc21.m4: Update.
2281         * gnulib/import/m4/glob.m4: Update.
2282         * gnulib/import/m4/glob_h.m4: Update.
2283         * gnulib/import/m4/gnulib-cache.m4: Update.
2284         * gnulib/import/m4/gnulib-common.m4: Update.
2285         * gnulib/import/m4/gnulib-comp.m4: Update.
2286         * gnulib/import/m4/gnulib-tool.m4: Update.
2287         * gnulib/import/m4/hard-locale.m4: Update.
2288         * gnulib/import/m4/include_next.m4: Update.
2289         * gnulib/import/m4/inttypes-pri.m4: Update.
2290         * gnulib/import/m4/inttypes.m4: Update.
2291         * gnulib/import/m4/isnand.m4: Update.
2292         * gnulib/import/m4/isnanl.m4: Update.
2293         * gnulib/import/m4/largefile.m4: Update.
2294         * gnulib/import/m4/limits-h.m4: Update.
2295         * gnulib/import/m4/localcharset.m4: Update.
2296         * gnulib/import/m4/locale-fr.m4: Update.
2297         * gnulib/import/m4/locale-ja.m4: Update.
2298         * gnulib/import/m4/locale-zh.m4: Update.
2299         * gnulib/import/m4/localtime-buffer.m4: Update.
2300         * gnulib/import/m4/longlong.m4: Update.
2301         * gnulib/import/m4/lstat.m4: Update.
2302         * gnulib/import/m4/malloc.m4: Update.
2303         * gnulib/import/m4/malloca.m4: Update.
2304         * gnulib/import/m4/math_h.m4: Update.
2305         * gnulib/import/m4/mbrtowc.m4: Update.
2306         * gnulib/import/m4/mbsinit.m4: Update.
2307         * gnulib/import/m4/mbsrtowcs.m4: Update.
2308         * gnulib/import/m4/mbstate_t.m4: Update.
2309         * gnulib/import/m4/memchr.m4: Update.
2310         * gnulib/import/m4/memmem.m4: Update.
2311         * gnulib/import/m4/mempcpy.m4: Update.
2312         * gnulib/import/m4/memrchr.m4: Update.
2313         * gnulib/import/m4/mkdir.m4: Update.
2314         * gnulib/import/m4/mkstemp.m4: Update.
2315         * gnulib/import/m4/mmap-anon.m4: Update.
2316         * gnulib/import/m4/mode_t.m4: Update.
2317         * gnulib/import/m4/msvc-inval.m4: Update.
2318         * gnulib/import/m4/msvc-nothrow.m4: Update.
2319         * gnulib/import/m4/multiarch.m4: Update.
2320         * gnulib/import/m4/nocrash.m4: Update.
2321         * gnulib/import/m4/off_t.m4: Update.
2322         * gnulib/import/m4/onceonly.m4: Update.
2323         * gnulib/import/m4/open-cloexec.m4: Update.
2324         * gnulib/import/m4/open.m4: Update.
2325         * gnulib/import/m4/openat.m4: Update.
2326         * gnulib/import/m4/opendir.m4: Update.
2327         * gnulib/import/m4/pathmax.m4: Update.
2328         * gnulib/import/m4/rawmemchr.m4: Update.
2329         * gnulib/import/m4/readdir.m4: Update.
2330         * gnulib/import/m4/readlink.m4: Update.
2331         * gnulib/import/m4/realloc.m4: Update.
2332         * gnulib/import/m4/rename.m4: Update.
2333         * gnulib/import/m4/rewinddir.m4: Update.
2334         * gnulib/import/m4/rmdir.m4: Update.
2335         * gnulib/import/m4/save-cwd.m4: Update.
2336         * gnulib/import/m4/secure_getenv.m4: Update.
2337         * gnulib/import/m4/setenv.m4: Update.
2338         * gnulib/import/m4/signal_h.m4: Update.
2339         * gnulib/import/m4/ssize_t.m4: Update.
2340         * gnulib/import/m4/stat-time.m4: Update.
2341         * gnulib/import/m4/stat.m4: Update.
2342         * gnulib/import/m4/std-gnu11.m4: Update.
2343         * gnulib/import/m4/stdbool.m4: Update.
2344         * gnulib/import/m4/stddef_h.m4: Update.
2345         * gnulib/import/m4/stdint.m4: Update.
2346         * gnulib/import/m4/stdio_h.m4: Update.
2347         * gnulib/import/m4/stdlib_h.m4: Update.
2348         * gnulib/import/m4/strchrnul.m4: Update.
2349         * gnulib/import/m4/strdup.m4: Update.
2350         * gnulib/import/m4/strerror.m4: Update.
2351         * gnulib/import/m4/string_h.m4: Update.
2352         * gnulib/import/m4/strstr.m4: Update.
2353         * gnulib/import/m4/strtok_r.m4: Update.
2354         * gnulib/import/m4/sys_socket_h.m4: Update.
2355         * gnulib/import/m4/sys_stat_h.m4: Update.
2356         * gnulib/import/m4/sys_time_h.m4: Update.
2357         * gnulib/import/m4/sys_types_h.m4: Update.
2358         * gnulib/import/m4/tempname.m4: Update.
2359         * gnulib/import/m4/time_h.m4: Update.
2360         * gnulib/import/m4/unistd-safer.m4: Update.
2361         * gnulib/import/m4/unistd_h.m4: Update.
2362         * gnulib/import/m4/warn-on-use.m4: Update.
2363         * gnulib/import/m4/wchar_h.m4: Update.
2364         * gnulib/import/m4/wchar_t.m4: Update.
2365         * gnulib/import/m4/wctype_h.m4: Update.
2366         * gnulib/import/m4/wint_t.m4: Update.
2367         * gnulib/import/malloc.c: Update.
2368         * gnulib/import/malloc/scratch_buffer.h: Update.
2369         * gnulib/import/malloc/scratch_buffer_grow.c: Update.
2370         * gnulib/import/malloc/scratch_buffer_grow_preserve.c: Update.
2371         * gnulib/import/malloc/scratch_buffer_set_array_size.c: Update.
2372         * gnulib/import/malloca.c: Update.
2373         * gnulib/import/malloca.h: Update.
2374         * gnulib/import/malloca.valgrind: Update.
2375         * gnulib/import/math.in.h: Update.
2376         * gnulib/import/mbrtowc.c: Update.
2377         * gnulib/import/mbsinit.c: Update.
2378         * gnulib/import/mbsrtowcs-impl.h: Update.
2379         * gnulib/import/mbsrtowcs-state.c: Update.
2380         * gnulib/import/mbsrtowcs.c: Update.
2381         * gnulib/import/memchr.c: Update.
2382         * gnulib/import/memmem.c: Update.
2383         * gnulib/import/mempcpy.c: Update.
2384         * gnulib/import/memrchr.c: Update.
2385         * gnulib/import/mkdir.c: Update.
2386         * gnulib/import/mkstemp.c: Update.
2387         * gnulib/import/msvc-inval.c: Update.
2388         * gnulib/import/msvc-inval.h: Update.
2389         * gnulib/import/msvc-nothrow.c: Update.
2390         * gnulib/import/msvc-nothrow.h: Update.
2391         * gnulib/import/open.c: Update.
2392         * gnulib/import/openat-die.c: Update.
2393         * gnulib/import/openat-priv.h: Update.
2394         * gnulib/import/openat-proc.c: Update.
2395         * gnulib/import/openat.c: Update.
2396         * gnulib/import/openat.h: Update.
2397         * gnulib/import/opendir.c: Update.
2398         * gnulib/import/pathmax.h: Update.
2399         * gnulib/import/pipe-safer.c: Update.
2400         * gnulib/import/rawmemchr.c: Update.
2401         * gnulib/import/readdir.c: Update.
2402         * gnulib/import/readlink.c: Update.
2403         * gnulib/import/realloc.c: Update.
2404         * gnulib/import/ref-add.sin: Update.
2405         * gnulib/import/ref-del.sin: Update.
2406         * gnulib/import/rename.c: Update.
2407         * gnulib/import/rewinddir.c: Update.
2408         * gnulib/import/rmdir.c: Update.
2409         * gnulib/import/same-inode.h: Update.
2410         * gnulib/import/save-cwd.c: Update.
2411         * gnulib/import/save-cwd.h: Update.
2412         * gnulib/import/scratch_buffer.h: Update.
2413         * gnulib/import/secure_getenv.c: Update.
2414         * gnulib/import/setenv.c: Update.
2415         * gnulib/import/signal.in.h: Update.
2416         * gnulib/import/stat-time.c: Update.
2417         * gnulib/import/stat-time.h: Update.
2418         * gnulib/import/stat-w32.c: Update.
2419         * gnulib/import/stat-w32.h: Update.
2420         * gnulib/import/stat.c: Update.
2421         * gnulib/import/stdbool.in.h: Update.
2422         * gnulib/import/stddef.in.h: Update.
2423         * gnulib/import/stdint.in.h: Update.
2424         * gnulib/import/stdio.in.h: Update.
2425         * gnulib/import/stdlib.in.h: Update.
2426         * gnulib/import/str-two-way.h: Update.
2427         * gnulib/import/strchrnul.c: Update.
2428         * gnulib/import/strdup.c: Update.
2429         * gnulib/import/streq.h: Update.
2430         * gnulib/import/strerror-override.c: Update.
2431         * gnulib/import/strerror-override.h: Update.
2432         * gnulib/import/strerror.c: Update.
2433         * gnulib/import/string.in.h: Update.
2434         * gnulib/import/stripslash.c: Update.
2435         * gnulib/import/strnlen1.c: Update.
2436         * gnulib/import/strnlen1.h: Update.
2437         * gnulib/import/strstr.c: Update.
2438         * gnulib/import/strtok_r.c: Update.
2439         * gnulib/import/sys_stat.in.h: Update.
2440         * gnulib/import/sys_time.in.h: Update.
2441         * gnulib/import/sys_types.in.h: Update.
2442         * gnulib/import/tempname.c: Update.
2443         * gnulib/import/tempname.h: Update.
2444         * gnulib/import/time.in.h: Update.
2445         * gnulib/import/unistd--.h: Update.
2446         * gnulib/import/unistd-safer.h: Update.
2447         * gnulib/import/unistd.in.h: Update.
2448         * gnulib/import/unsetenv.c: Update.
2449         * gnulib/import/verify.h: Update.
2450         * gnulib/import/extra/snippet/warn-on-use.h: Update.
2451         * gnulib/import/wchar.in.h: Update.
2452         * gnulib/import/wctype.in.h: Update.
2453         * gnulib/import/xalloc-oversized.h: Update.
2454         * gnulib/update-gnulib.sh (GNULIB_COMMIT_SHA1): Set to
2455         "53e2c179f26a890fa6685af4b6c1397ee370433b".
2456
2457 2018-08-16  Gary Benson <gbenson@redhat.com>
2458
2459         PR gdb/13000:
2460         * gdb/main.c (captured_main_1): Exit with nonzero status
2461         in batch mode if the last command to be executed failed.
2462         * NEWS: Mention the above.
2463
2464 2018-08-29  Simon Marchi  <simon.marchi@ericsson.com>
2465
2466         * csky-tdep.c (csky_memory_insert_breakpoint): Remove newline at
2467         end of warning message.
2468
2469 2018-08-29  Alan Hayward  <alan.hayward@arm.com>
2470
2471         PR gdb/22943:
2472         * aarch64-tdep.c (is_hfa_or_hva): Remove function.
2473         (aarch64_extract_return_value): Use
2474         aapcs_is_vfp_call_or_return_candidate.
2475         (aarch64_return_in_memory): Likewise.
2476         (aarch64_store_return_value): Likewise.
2477
2478 2018-08-29  Alan Hayward  <alan.hayward@arm.com>
2479
2480         * aarch64-tdep.c
2481         (aapcs_is_vfp_call_or_return_candidate): Make static
2482         (pass_in_v_or_stack): Remove function.
2483         (pass_in_v_vfp_candidate): New function.
2484         (aarch64_push_dummy_call): Check for float register candidates.
2485
2486 2018-08-29  Alan Hayward  <alan.hayward@arm.com>
2487
2488         * aarch64-tdep.c (HA_MAX_NUM_FLDS): New macro.
2489         (aapcs_is_vfp_call_or_return_candidate_1): New function.
2490         (aapcs_is_vfp_call_or_return_candidate): Likewise.
2491
2492 2018-08-28  Simon Marchi  <simon.marchi@polymtl.ca>
2493
2494         PR build/23399
2495         * common/agent.c (IPA_SYM_STRUCT_NAME): Define.
2496         (struct ipa_sym_addresses): Rename to...
2497         (struct ipa_sym_addresses_common): ... this.
2498         * common/agent.h (IPA_SYM): Use IPA_SYM_STRUCT_NAME.
2499
2500 2018-08-28  Tom Tromey  <tom@tromey.com>
2501
2502         * c-exp.y (struct token_and_value): Remove typedef and DEF_VEC.
2503         (token_fifo): Now a std::vector.
2504         (yylex, c_parse): Update.
2505         * d-exp.y (struct token_and_value): Remove typedef and DEF_VEC.
2506         (token_fifo): Now a std::vector.
2507         (yylex, d_parse): Update.
2508         * go-exp.y (struct token_and_value): Remove typedef and DEF_VEC.
2509         (token_fifo): Now a std::vector.
2510         (yylex, go_parse): Update.
2511
2512 2018-08-28  Simon Marchi  <simon.marchi@ericsson.com>
2513
2514         * parser-defs.h (struct type_stack) <elements>: Change type to
2515         std::vector<union type_stack_elt>.
2516         <depth, size>: Remove.
2517         * parse.c (parse_exp_in_context_1): Adjust.
2518         (type_stack_reserve): Remove.
2519         (check_type_stack_depth): Remove.
2520         (insert_into_type_stack): Adjust to std::vector.
2521         (insert_type): Likewise.
2522         (push_type): Likewise.
2523         (push_type_int): Likewise.
2524         (insert_type_address_space): Likewise.
2525         (pop_type): Likewise.
2526         (pop_type_int): Likewise.
2527         (pop_typelist): Likewise.
2528         (pop_type_stack): Likewise.
2529         (append_type_stack): Likewise.
2530         (push_type_stack): Likewise.
2531         (get_type_stack): Likewise.
2532         (type_stack_cleanup): Likewise.
2533         (push_typelist): Likewise.
2534         (follow_types): Likewise.
2535         (_initialize_parse): Likewise.
2536
2537 2018-08-28  Hafiz Abid Qadeer  <abidh@codesourcery.com>
2538
2539         * NEWS: Mention csky target.
2540
2541 2018-08-28  Jiangshuai Li  <jiangshuai_li@c-sky.com>
2542             Hafiz Abid Qadeer  <abidh@codesourcery.com>
2543             Don Breazeal  <donb@codesourcery.com>
2544
2545         * csky-linux-tdep.c: New file.
2546         * csky-tdep.c: Likewise.
2547         * csky-tdep.h: Likewise.
2548         * Makefile.in (ALL_TARGET_OBS): Add csky-linux-tdep.o and
2549         csky-tdep.o.
2550         (HFILES_NO_SRCDIR): Add csky-tdep.h.
2551         (ALLDEPFILES): Add csky-linux-tdep.c and csky-tdep.c
2552         * configure.tgt: Add csky support.
2553
2554 2018-08-27  Jan Vrany  <jan.vrany@fit.cvut.cz>
2555
2556         * python/py-framefilter.c (py_print_frame): Print frame architecture
2557         when printing on an MI output.
2558
2559 2018-08-27  Tom Tromey  <tom@tromey.com>
2560
2561         PR build/23087:
2562         * configure: Rebuild.
2563         * warning.m4 (AM_GDB_WARNINGS): Remove -Wno-narrowing.
2564
2565 2018-08-27  Tom Tromey  <tom@tromey.com>
2566
2567         * aarch64-linux-tdep.c
2568         (aarch64_linux_iterate_over_regset_sections) <sve_regmap>: Add
2569         casts to int.
2570
2571 2018-08-27  Tom Tromey  <tom@tromey.com>
2572
2573         * ppc64-tdep.c (insn_d, insn_ds, insn_xfx): Add casts to
2574         unsigned.
2575         (ppc64_standard_linkage1, ppc64_standard_linkage2)
2576         (ppc64_standard_linkage3, ppc64_standard_linkage4)
2577         (ppc64_standard_linkage5, ppc64_standard_linkage6)
2578         (ppc64_standard_linkage7, ppc64_standard_linkage8): Add casts to
2579         unsigned.
2580
2581 2018-08-27  Tom Tromey  <tom@tromey.com>
2582
2583         * xtensa-tdep.h (XTREG_END): Add cast to unsigned.
2584         (XTENSA_GDBARCH_TDEP_INSTANTIATE): Likewise.
2585
2586 2018-08-27  Tom Tromey  <tom@tromey.com>
2587
2588         * tramp-frame.h (TRAMP_SENTINEL_INSN): Redefine.
2589         * tilegx-linux-tdep.c (tilegx_linux_rt_sigframe): Use
2590         ULONGEST_MAX.
2591         * tic6x-linux-tdep.c (tic6x_linux_rt_sigreturn_tramp_frame): Use
2592         ULONGEST_MAX.
2593         * sparc64-linux-tdep.c (sparc64_linux_rt_sigframe): Use
2594         ULONGEST_MAX.
2595         * sparc-linux-tdep.c (sparc32_linux_sigframe)
2596         (sparc32_linux_rt_sigframe): Use ULONGEST_MAX.
2597         * ppc-nbsd-tdep.c (ppcnbsd_sigtramp, ppcnbsd2_sigtramp): Use
2598         ULONGEST_MAX.
2599         * ppc-linux-tdep.c (ppc32_linux_sigaction_tramp_frame)
2600         (ppc64_linux_sigaction_tramp_frame)
2601         (ppc32_linux_sighandler_tramp_frame)
2602         (ppc64_linux_sighandler_tramp_frame): Use ULONGEST_MAX.
2603         * nios2-linux-tdep.c (nios2_r1_linux_rt_sigreturn_tramp_frame)
2604         (nios2_r2_linux_rt_sigreturn_tramp_frame): Use ULONGEST_MAX.
2605         * mn10300-linux-tdep.c (am33_linux_sigframe)
2606         (am33_linux_rt_sigframe): Use ULONGEST_MAX.
2607         * mips64-obsd-tdep.c (mips64obsd_sigframe): Use ULONGEST_MAX.
2608         * mips-linux-tdep.c (mips_linux_o32_sigframe)
2609         (mips_linux_o32_rt_sigframe, mips_linux_n32_rt_sigframe)
2610         (mips_linux_n64_rt_sigframe, micromips_linux_o32_sigframe)
2611         (micromips_linux_o32_rt_sigframe, micromips_linux_n32_rt_sigframe)
2612         (micromips_linux_n64_rt_sigframe): Use ULONGEST_MAX.
2613         * mips-fbsd-tdep.c (mips_fbsd_sigframe, mipsn32_fbsd_sigframe)
2614         (mips64_fbsd_sigframe): Use ULONGEST_MAX.
2615         * microblaze-linux-tdep.c
2616         (microblaze_linux_sighandler_tramp_frame): Use ULONGEST_MAX.
2617         * i386-nbsd-tdep.c (i386nbsd_sigtramp_sc16, i386nbsd_sigtramp_sc2)
2618         (i386nbsd_sigtramp_si2, i386nbsd_sigtramp_si31)
2619         (i386nbsd_sigtramp_si4): Use ULONGEST_MAX.
2620         * hppa-nbsd-tdep.c (hppanbsd_sigtramp_si4): Use ULONGEST_MAX.
2621         * common/common-types.h (ULONGEST_MAX): New define.
2622         (CORE_ADDR_MAX): Fix formatting.
2623         * bfin-linux-tdep.c (bfin_linux_sigframe): Use ULONGEST_MAX.
2624         * arm-obsd-tdep.c (armobsd_sigframe): Use ULONGEST_MAX.
2625         * arm-linux-tdep.c (arm_linux_sigreturn_tramp_frame)
2626         (arm_linux_rt_sigreturn_tramp_frame)
2627         (arm_eabi_linux_sigreturn_tramp_frame)
2628         (arm_eabi_linux_rt_sigreturn_tramp_frame)
2629         (thumb2_eabi_linux_sigreturn_tramp_frame)
2630         (thumb2_eabi_linux_rt_sigreturn_tramp_frame)
2631         (arm_linux_restart_syscall_tramp_frame)
2632         (arm_kernel_linux_restart_syscall_tramp_frame): Use ULONGEST_MAX.
2633         * arm-fbsd-tdep.c (arm_fbsd_sigframe): Use ULONGEST_MAX.
2634         * aarch64-linux-tdep.c (aarch64_linux_rt_sigframe): Use
2635         ULONGEST_MAX.
2636         * aarch64-fbsd-tdep.c (aarch64_fbsd_sigframe): Use ULONGEST_MAX.
2637
2638 2018-08-27  Tom Tromey  <tom@tromey.com>
2639
2640         * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Use
2641         CORE_ADDR_MAX.
2642         * mips-tdep.c (mips_deal_with_atomic_sequence)
2643         (micromips_deal_with_atomic_sequence): Use CORE_ADDR_MAX.
2644         * arch/arm-get-next-pcs.c (thumb_deal_with_atomic_sequence_raw)
2645         (arm_deal_with_atomic_sequence_raw): Use CORE_ADDR_MAX.
2646         * alpha-tdep.c (alpha_deal_with_atomic_sequence): Use
2647         CORE_ADDR_MAX.
2648         * aarch64-tdep.c (aarch64_software_single_step): Use
2649         CORE_ADDR_MAX.
2650
2651 2018-08-27  Tom Tromey  <tom@tromey.com>
2652
2653         * linespec.c (complete_linespec_component): Add cast to "char".
2654         * completer.c (completion_tracker::build_completion_result): Add
2655         cast to "char".
2656
2657 2018-08-26  Simon Marchi  <simon.marchi@polymtl.ca>
2658
2659         * solist.h (struct solist, struct target_so_ops): Fix
2660         indentation.
2661
2662 2018-08-26  Simon Marchi  <simon.marchi@polymtl.ca>
2663
2664         * ada-tasks.c (ada_task_info_s): Remove typedef.
2665         (DEF_VEC_O(ada_task_info_s)): Remove.
2666         (struct ada_tasks_inferior_data): Initialize fields.
2667         <task_list>: Make an std::vector.
2668         (get_ada_tasks_inferior_data): Allocate with new.
2669         (ada_get_task_number): Adjust.
2670         (get_task_number_from_id): Likewise.
2671         (valid_task_id): Likewise.
2672         (ada_get_task_info_from_ptid): Likewise.
2673         (iterate_over_live_ada_tasks): Likewise.
2674         (add_ada_task): Likewise.
2675         (read_known_tasks): Likewise.
2676         (ada_build_task_list): Likewise.
2677         (print_ada_task_info): Likewise.
2678         (info_task): Likewise.
2679         (task_command_1): Likewise.
2680
2681 2018-08-26  Simon Marchi  <simon.marchi@polymtl.ca>
2682
2683         * ada-lang.c (add_angle_brackets): Return std::string.
2684
2685 2018-08-25  Simon Marchi  <simon.marchi@polymtl.ca>
2686
2687         * python/py-threadevent.c (py_get_event_thread): Initialize
2688         pythread.
2689
2690 2018-08-24  Pedro Alves  <palves@redhat.com>
2691
2692         * python/py-bpevent.c (create_breakpoint_event_object): Use
2693         copy-initialization.
2694         * python/py-continueevent.c (emit_continue_event): Use
2695         copy-initialization.
2696         * python/py-exitedevent.c (create_exited_event_object): Return a
2697         gdbpy_ref<>.
2698         (emit_exited_event): Use copy-initialization.
2699         * python/py-inferior.c (python_new_inferior)
2700         (python_inferior_deleted, add_thread_object): Use
2701         copy-initialization.
2702         * python/py-infevents.c (create_inferior_call_event_object)
2703         (create_register_changed_event_object)
2704         (create_memory_changed_event_object): Return a gdbpy_ref<>.
2705         (emit_inferior_call_event, emit_memory_changed_event)
2706         (emit_register_changed_event): Use copy-initialization.
2707         * python/py-newobjfileevent.c (create_new_objfile_event_object):
2708         Return a gdbpy_ref<>.
2709         (emit_new_objfile_event): Use copy-initialization.
2710         (create_clear_objfiles_event_object): Return a gdbpy_ref<>.
2711         (emit_clear_objfiles_event): Use copy-initialization.
2712         * python/py-signalevent.c (create_signal_event_object): Use
2713         copy-initialization.
2714         * python/py-threadevent.c (create_thread_event_object): Use
2715         copy-initialization.
2716
2717 2018-08-24  Pedro Alves  <palves@redhat.com>
2718             Simon Marchi  <simon.marchi@ericsson.com>
2719
2720         PR gdb/23379
2721         * python/py-continueevent.c: Include "gdbthread.h".
2722         (create_continue_event_object): Add intro comment.  Add 'ptid'
2723         parameter.  Use it to find thread to pass to
2724         create_thread_event_object.
2725         (emit_continue_event): Pass PTID down to
2726         create_continue_event_object.
2727         * python/py-event.h (py_get_event_thread): Declare.
2728         (create_thread_event_object): Remove default from 'thread'
2729         parameter.
2730         * python/py-stopevent.c (create_stop_event_object): Use
2731         py_get_event_thread.
2732         * python/py-threadevent.c (get_event_thread): Rename to ...
2733         (py_get_event_thread): ... this, make extern, add 'ptid' parameter
2734         and use it to find the thread.
2735         (create_thread_event_object): Assert that THREAD isn't null.
2736         Don't find the event thread here.
2737
2738 2018-08-23  Kevin Buettner  <kevinb@redhat.com>
2739
2740         * block.h (blockrange, blockranges): New struct declarations.
2741         (struct block): Add new field named `ranges'.
2742         (BLOCK_RANGES, BLOCK_NRANGES, BLOCK_RANGE, BLOCK_CONTIGUOUS_P)
2743         (BLOCK_RANGE_START, BLOCK_RANGE_END, BLOCK_ENTRY_PC): New
2744         macros for accessing ranges in struct block.
2745         (make_blockranges): New declaration.
2746         block.c (make_blockranges): New function.
2747         * dwarf2read.c (dwarf2_record_block_ranges): Fill in BLOCK_RANGES
2748         for block.
2749         * symtab.h (find_pc_partial_function): Add new parameter `block'.
2750         * blockframe.c (cache_pc_function_block): New static global.
2751         (clear_pc_function_cache): Clear cache_pc_function_block.
2752         (find_pc_partial_function): Move comment to symtab.h.  Add
2753         support for non-contiguous blocks.
2754         * cli/cli-cmds.c (block.h): Include.
2755         (print_disassembly): Handle printing of non-contiguous blocks.
2756         (disassemble_current_function): Likewise.
2757         (disassemble_command): Likewise.
2758
2759         * ax-gdb.c (gen_var_ref): Use BLOCK_ENTRY_PC in place of
2760         BLOCK_START.
2761         * blockframe.c (get_pc_function_start): Likewise.
2762         * compile/compile-c-symbols.c (convert_one_symbol): Likewise.
2763         (gcc_symbol_address): Likewise.
2764         * compile/compile-object-run.c (compile_object_run): Likewise.
2765         * compile/compile.c (get_expr_block_and_pc): Likewise.
2766         * dwarf2loc.c (dwarf2_find_location_expression): Likewise.
2767         (func_addr_to_tail_call_list): Likewise.
2768         * findvar.c (default_read_var_value): Likewise.
2769         * inline-frame.c (inline_frame_this_id): Likewise.
2770         (skip-inline_frames): Likewise.
2771         * infcmd.c (until_next_command): Likewise.
2772         * linespec.c (convert_linespec_to_sals): Likewise.
2773         * parse.c (parse_exp_in_context_1): Likewise.
2774         * printcmd.c (build_address_symbolic): likewise.
2775         (info_address_command): Likewise.
2776         symtab.c (find_function_start_sal): Likewise.
2777         (skip_prologue_sal): Likewise.
2778         (find_function_alias_target): Likewise.
2779         (find_gnu_ifunc): Likewise.
2780         * stack.c (find_frame_funname): Likewise.
2781         * symtab.c (fixup_symbol_section): Likewise.
2782         (find_function_start_sal): Likewise.
2783         (skip_prologue_sal): Likewsie.
2784         (find_function_alias_target): Likewise.
2785         (find_gnu_ifunc): Likewise.
2786         * tracepoint.c (info_scope_command): Likewise.
2787         * value.c (value_fn_field): Likewise.
2788
2789         * infrun.c (fill_in_stop_func): Use find_function_entry_range_from_pc
2790         in place of find_pc_partial_function.
2791         * blockframe.c (find_function_entry_range_from_pc): New function.
2792         * symtab.h (find_function_entry_range_from_pc): Declare and document.
2793         * objfiles.c (objfile_relocate1): Relocate start and end addresses
2794         for each range in a block.
2795
2796
2797 2018-08-23  Xavier Roirand  <roirand@adacore.com>
2798
2799         * machoread.c (macho_symfile_read_all_oso): Remove uneeded
2800         incrementation.
2801
2802 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
2803
2804         * solib-svr4.c (read_program_headers_from_bfd): Return
2805         gdb::optional<gdb::byte_vector>.
2806         (svr4_exec_displacement): Adjust.
2807
2808 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
2809
2810         * solib-svr4.c (read_program_header): Return
2811         gdb::optional<gdb::byte_vector>, remove p_sect_size param.
2812         (find_program_interpreter): Return
2813         gdb::optional<gdb::byte_vector>.
2814         (scan_dyntag_auxv): Adjust.
2815         (enable_break): Adjust.
2816         (svr4_exec_displacement): Adjust.
2817
2818 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
2819
2820         * inf-child.h (inf_child_target) <terminal_save_inferior>: New.
2821         * inf-child.c (inf_child_target::terminal_save_inferior): New.
2822
2823 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
2824
2825         * guile/scm-string.c (gdbscm_scm_from_printf): Use
2826         string_vprintf.
2827         * guile/scm-utils.c (gdbscm_printf): Likewise.
2828         * serial.c (serial_printf): Likewise.
2829         * xml-support.c (gdb_xml_parser::vdebug): Likewise.
2830
2831 2018-08-22  Jan Vrany  <jan.vrany@fit.cvut.cz>
2832
2833         * stack.c (print_frame): Print frame architecture when printing on
2834         an MI output.
2835         * NEWS: Mention new "arch" attribute in frame output.
2836
2837 2018-08-21  Alan Hayward  <alan.hayward@arm.com>
2838
2839         * arch/aarch64.h (aarch64_regnum): Update comment.
2840
2841 2018-08-21  Alan Hayward  <alan.hayward@arm.com>
2842
2843         * NEWS: Add SVE to 8.2 section.
2844
2845 2018-08-21  Pedro Alves  <palves@redhat.com>
2846
2847         * guile/scm-utils.c (gdbscm_parse_function_args_1): New, factored
2848         out from gdbscm_parse_function_args.
2849         (gdbscm_parse_function_args): Rework to use gdbscm_wrap and
2850         gdbscm_parse_function_args_1.
2851
2852 2018-08-21  Simon Marchi  <simon.marchi@ericsson.com>
2853
2854         PR gdb/17816
2855         * m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
2856         operator.
2857
2858 2018-08-19  Simon Marchi  <simon.marchi@polymtl.ca>
2859
2860         * solib-svr4.c (svr4_exec_displacement): Fix formatting.
2861
2862 2018-08-19  Michael Spang  <spang@google.com>
2863
2864         PR gdb/11786
2865         * solib-svr4.c (svr4_exec_displacement): Ignore memsz fields
2866         for PT_TLS segments.
2867
2868 2018-08-18  Kevin Buettner  <kevinb@redhat.com>
2869
2870         * dwarf2expr.h (struct dwarf_expr_context): Add virtual method
2871         dwarf_variable_value.
2872         * dwarf2-frame.c (class dwarf_expr_executor):
2873         Add override for dwarf_variable_value.
2874         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Likewise.
2875         (class symbol_needs_eval_context): Likewise.
2876         (indirect_synthetic_pointer): Add forward declaration.
2877         (sect_variable_value): New function.
2878         (dwarf2_compile_expr_to_ax): Add case for DW_OP_GNU_variable_value.
2879         * dwarf2expr.c (dwarf_expr_context::execute_stack_op): Add case
2880         for DW_OP_GNU_variable_value.
2881
2882 2018-08-16  Tom Tromey  <tom@tromey.com>
2883
2884         * top.c (read_command_file): Update.
2885         (command_line_input): Remove "repeat" argument.
2886         * ada-lang.c (get_selections): Update.
2887         * linespec.c (decode_line_2): Update.
2888         * defs.h (command_line_input): Remove argument.
2889         * cli/cli-script.c (read_next_line): Update.
2890         * python/py-gdb-readline.c: Update.
2891
2892 2018-08-17  Tom Tromey  <tom@tromey.com>
2893
2894         * cli/cli-script.c (read_next_line): Pass 0 as repeat argument to
2895         command_line_input.
2896
2897 2018-08-15  Tom Tromey  <tom@tromey.com>
2898
2899         * aarch64-linux-tdep.c (aarch64_linux_core_read_vq): Use pulongest.
2900
2901 2018-08-14  Jan Vrany  <jan.vrany@fit.cvut.cz>
2902
2903         * mi/mi-cmd-disas.c (mi_cmd_disassemble): Add -a option.
2904         If used, use find_pc_partial_function to find address range
2905         to disassemble.
2906         * mi/mi-main.c (mi_cmd_list_features): Report
2907         "data-disassemble-a-option" feature.
2908         * NEWS: Mention new -data-disassemble option -a.
2909
2910 2018-08-13  Tom Tromey  <tom@tromey.com>
2911
2912         * common/common-defs.h (_FORTIFY_SOURCE): Define.
2913
2914 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
2915
2916         * aarch64-linux-tdep.c (aarch64_linux_supply_sve_regset): New function.
2917         (aarch64_linux_collect_sve_regset): Likewise.
2918         (aarch64_linux_iterate_over_regset_sections): Check for SVE.
2919         * regcache.h (regcache_map_entry_size): New function.
2920
2921 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
2922
2923         * aarch64-linux-tdep.c (SVE_HEADER_SIZE_LENGTH): Add define.
2924         (SVE_HEADER_MAX_SIZE_LENGTH): Likewise.
2925         (SVE_HEADER_VL_LENGTH): Likewise.
2926         (SVE_HEADER_MAX_VL_LENGTH): Likewise.
2927         (SVE_HEADER_FLAGS_LENGTH): Likewise.
2928         (SVE_HEADER_RESERVED_LENGTH): Likewise.
2929         (SVE_HEADER_SIZE_OFFSET): Likewise.
2930         (SVE_HEADER_MAX_SIZE_OFFSET): Likewise.
2931         (SVE_HEADER_VL_OFFSET): Likewise.
2932         (SVE_HEADER_MAX_VL_OFFSET): Likewise.
2933         (SVE_HEADER_FLAGS_OFFSET): Likewise.
2934         (SVE_HEADER_RESERVED_OFFSET): Likewise.
2935         (SVE_HEADER_SIZE): Likewise.
2936         (aarch64_linux_core_read_vq): Add function.
2937         (aarch64_linux_core_read_description): Check for SVE section.
2938
2939 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
2940
2941         * aarch64-fbsd-tdep.c
2942         (aarch64_fbsd_iterate_over_regset_sections): Add supply_size and
2943         collect_size.
2944         * aarch64-linux-tdep.c
2945         (aarch64_linux_iterate_over_regset_sections): Likewise.
2946         * alpha-linux-tdep.c
2947         (alpha_linux_iterate_over_regset_sections):
2948         * alpha-nbsd-tdep.c
2949         (alphanbsd_iterate_over_regset_sections): Likewise.
2950         * amd64-fbsd-tdep.c
2951         (amd64fbsd_iterate_over_regset_sections): Likewise.
2952         * amd64-linux-tdep.c
2953         (amd64_linux_iterate_over_regset_sections): Likewise.
2954         * arm-bsd-tdep.c
2955         (armbsd_iterate_over_regset_sections): Likewise.
2956         * arm-fbsd-tdep.c
2957         (arm_fbsd_iterate_over_regset_sections): Likewise.
2958         * arm-linux-tdep.c
2959         (arm_linux_iterate_over_regset_sections): Likewise.
2960         * corelow.c (get_core_registers_cb): Likewise.
2961         (core_target::fetch_registers): Likewise.
2962         * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise.
2963         * frv-linux-tdep.c (frv_linux_iterate_over_regset_sections): Likewise.
2964         * gdbarch.h (void): Regenerate.
2965         * gdbarch.sh: Add supply_size and collect_size.
2966         * hppa-linux-tdep.c (hppa_linux_iterate_over_regset_sections): Likewise.
2967         * hppa-nbsd-tdep.c (hppanbsd_iterate_over_regset_sections): Likewise.
2968         * hppa-obsd-tdep.c (hppaobsd_iterate_over_regset_sections): Likewise.
2969         * i386-fbsd-tdep.c (i386fbsd_iterate_over_regset_sections): Likewise.
2970         * i386-linux-tdep.c (i386_linux_iterate_over_regset_sections): Likewise.
2971         * i386-tdep.c (i386_iterate_over_regset_sections): Likewise.
2972         * ia64-linux-tdep.c (ia64_linux_iterate_over_regset_sections): Likewise.
2973         * linux-tdep.c (linux_collect_regset_section_cb): Likewise.
2974         * m32r-linux-tdep.c (m32r_linux_iterate_over_regset_sections): Likewise.
2975         * m68k-bsd-tdep.c (m68kbsd_iterate_over_regset_sections): Likewise.
2976         * m68k-linux-tdep.c (m68k_linux_iterate_over_regset_sections): Likewise.
2977         * mips-fbsd-tdep.c (mips_fbsd_iterate_over_regset_sections): Likewise.
2978         * mips-linux-tdep.c (mips_linux_iterate_over_regset_sections): Likewise.
2979         * mips-nbsd-tdep.c (mipsnbsd_iterate_over_regset_sections): Likewise.
2980         * mips64-obsd-tdep.c (mips64obsd_iterate_over_regset_sections): Likewise.
2981         * mn10300-linux-tdep.c (am33_iterate_over_regset_sections): Likewise.
2982         * nios2-linux-tdep.c (nios2_iterate_over_regset_sections): Likewise.
2983         * ppc-fbsd-tdep.c (ppcfbsd_iterate_over_regset_sections): Likewise.
2984         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections): Likewise.
2985         * ppc-nbsd-tdep.c (ppcnbsd_iterate_over_regset_sections): Likewise.
2986         * ppc-obsd-tdep.c (ppcobsd_iterate_over_regset_sections): Likewise.
2987         * riscv-linux-tdep.c (riscv_linux_iterate_over_regset_sections): Likewise.
2988         * rs6000-aix-tdep.c (rs6000_aix_iterate_over_regset_sections): Likewise.
2989         * s390-linux-tdep.c (s390_iterate_over_regset_sections): Likewise.
2990         * score-tdep.c (score7_linux_iterate_over_regset_sections): Likewise.
2991         * sh-tdep.c (sh_iterate_over_regset_sections): Likewise.
2992         * sparc-tdep.c (sparc_iterate_over_regset_sections): Likewise.
2993         * tilegx-linux-tdep.c (tilegx_iterate_over_regset_sections): Likewise.
2994         * vax-tdep.c (vax_iterate_over_regset_sections): Likewise.
2995         * xtensa-tdep.c (xtensa_iterate_over_regset_sections): Likewise.
2996
2997 2018-08-10  Simon Marchi  <simon.marchi@ericsson.com>
2998
2999         * nat/linux-osdata.c (commandline_from_pid): Replace xstrprintf
3000         with string_printf.
3001
3002 2018-08-10  Keith Seitz  <keiths@redhat.com>
3003
3004         * compile/compile-c-support.c (add_code_header, add_code_footer):
3005         Move into policy class.
3006         (c_push_user_expression, pop_user_expression_nop)
3007         (c_add_code_header, c_add_code_footer, c_add_input): New policy class.
3008         (compile_program): New host class.
3009         (c_compile_program): New typedef.
3010         (c_compute_porgram): Use c_compile_program.
3011
3012 2018-08-10  Keith Seitz  <keiths@redhat.com>
3013
3014         * compile/compile-internal.h (compile_instance::~compile_instance):
3015         Remove calls to htab_delete.
3016         <m_type_map, m_symbol_err_map>: Switch type to htab_up.
3017         * compile.c (compile_instance::compile_instance): Initialize
3018         htab unique pointers.
3019         (compile_instance::get_cached_type, compile_instance::insert_type)
3020         (compile_instance::error_symbol_once): Update for unique_ptr.
3021
3022 2018-08-10  Keith Seitz  <keiths@redhat.com>
3023
3024         * compile/compile-c-symbols.c (struct symbol_error)
3025         (hash_symbol_error, eq_symbol_error, del_symbol_error)
3026         (compile_instance::insert_symbol_error)
3027         (compile_instance::error_symbol_once): Move to ...
3028         * compile/compile.c: ... here.
3029
3030 2018-08-10  Keith Seitz  <keiths@redhat.com>
3031
3032         * compile/compile-c-support.c (c_get_compile_context): Use `new'
3033         instead of `new_compile_instance'.
3034         * compile/compile-c-symbols.c (compile_instance::insert_symbol_error):
3035         Update description.
3036         If the symbol error map is not initialized, create it.
3037         (generate_c_for_for_one_symbol): Do not check/initialize
3038         the symbol error map.
3039         * compile/compile-c-types.c (compile_c_instance): Make a class.
3040         Update all callers.
3041         (compile_instance::compile_instance): Initialize the type cache.
3042         (get_cached_type): New function.
3043         (insert_type): Update description.
3044         (compile_c_instance::m_default_cflags): Define.
3045         (convert_type): Update description.  Use get_cached_type.
3046         (delete_instance): Moved to destructor.
3047         (new_compile_instance): Moved to constructor.
3048         * compile/compile-c.h (compile_c_instance): Make class inheriting
3049         from compile_instance.
3050         <base>: Remove field.
3051         <type_map, symbol_err_map>: Move to base class.
3052         <c_plugin>: Rename to `m_plugin' and remove pointer type.
3053         * compile/compile-internal.h (compile_instance): Make class.
3054         <type_map_t, symbol_err_map_t>: Define.
3055         <fe>: Rename to `m_gcc_fe'.
3056         <scope, block, gcc_target_options>: Add `m_' prefix.
3057         <m_type_map, m_symbol_err_map>: New fields, moved from
3058         compile_c_instance.
3059         <destroy>: Remove.
3060         (convert_type, new_compile_instance): Remove.
3061         * compile/compile.c (cleanup_compile_instance): Remove.
3062         (compile_to_object): Use unique_ptr to eliminate cleanups.
3063         (compile_instance::set_print_callback, compile_instance::version)
3064         (compile_instance::set_verbose)
3065         (compile_instance::set_driver_filename)
3066         (compile_instance::set_triplet_regexp)
3067         (compile_instance::set_arguments)
3068         (compile_instance::set_source_file)
3069         (compile_instance::compile): Define.
3070
3071 2018-08-10  Keith Seitz  <keiths@redhat.com>
3072
3073         * Makefile.in (HFILES_NO_SRCDIR): Add compile/gcc-c-plugin.h.
3074         * compile/compile-c-types.c: Define GCC_METHODN macros and include
3075         gcc-c-fe.def to define C plugin.
3076         (delete_instance): Delete `c_plugin'.
3077         (new_compile_instance): Initialize `c_plugin'.
3078         * compile/compile-c.h: Include gcc_c_plugin.h.
3079         (struct compile_c_instance) <c_plugin>: New member.
3080         * gcc-c-plugin.h: New file.
3081         Update all callers with API change.
3082
3083 2018-08-10  Keith Seitz  <keiths@redhat.com>
3084
3085         * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Move header files ...
3086         (HFILES_NO_SRCDIR): ... to here.
3087         Add compile-internal.h and compile-c.h.
3088         * compile/compile-c-support.c: Include compile-c.h.
3089         * compile/compile-c-symbols.c: Include compile-c.h.
3090         (generate_c_for_variable_locations): Update comment.
3091         * compile/compile-c-types.c: Include compile-c.h.
3092         * compile/compile-c.h: New file -- moved C language declarations
3093         from other files here.
3094         * compile/compile-internal.h: Do not include hashtab.h or
3095         common/enum-flags.h.
3096         (gcc_qualifiers_flags, struct compile_c_instance, C_CTX)
3097         (gcc_convert_symbol, gcc_symbol_address)
3098         (generate_c_for_variable_locations, c_get_mode_for_size)
3099         (c_get_range_decl_name): Definitions moved to compile-c.h.
3100         * compile/compile-loc2c.c: Include compile-c.h.
3101
3102 2018-08-10  Keith Seitz  <keiths@redhat.com>
3103
3104         * compile/compile-c-symbols.c (symbol_substitution_name): Rename to ...
3105         (c_symbol_substitution_name): ... this.
3106         Update all callers.
3107
3108 2018-08-10  Keith Seitz  <keiths@redhat.com>
3109
3110         * compile/compile-c-support.c (c_compute_program): Use
3111         unique_xmalloc_ptr to eliminate cleanup.
3112         * compile/compile-c-symbols.c (generate_c_for_variable_locations):
3113         Return a unique_xmalloc_ptr and eliminate cleanup.
3114         * compile/compile-internal.h (generate_c_for_variable_locations):
3115         Return unique_xmalloc_ptr and update description.
3116
3117 2018-08-10  Alan Hayward  <alan.hayward@arm.com>
3118
3119         * corelow.c (core_target::get_core_register_section): Rename
3120         min_size to section_min_size.
3121
3122 2018-08-09  Jim Wilson  <jimw@sifive.com>
3123
3124         * Makefile.in (ALL_TARGET_OBS): Add riscv-linux-tdep.c.
3125         (ALLDEPFILES): Add riscv-linux-nat.c, and riscv-linux-tdep.c.
3126         * NEWS: Mention new GNU/Linux RISC-V target.
3127         * configure.host: Add riscv*-*-linux*.
3128         * configure.nat: Add riscv*.
3129         * configure.tgt: Add riscv*-*-linux*.
3130         * riscv-linux-nat.c: New file.
3131         * riscv-linux-tdep.c: New file.
3132
3133 2018-08-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3134
3135         * infrun.c (resume): Make static, add forward declaration.
3136         (proceed): Update header comment.
3137         * infrun.h (resume): Delete declaration.
3138
3139 2018-08-09  Tom Tromey  <tom@tromey.com>
3140
3141         * riscv-tdep.h: Minor formatting fixes.
3142
3143 2018-08-09  Simon Marchi  <simon.marchi@ericsson.com>
3144
3145         * common/scoped_mmap.c (mmap_file): Silence ARI warning.
3146         * dwarf-index-cache.c (create_dir_and_check): Likewise.
3147         (test_mkdir_recursive): Likewise.
3148         * dwarf-index-write.c (write_psymtabs_to_index): Likewise.
3149
3150 2018-08-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * valarith.c (value_subscripted_rvalue): If an array is not in
3153         memory, and we don't know the upper bound, then we can't know that
3154         the requested element exists or not.
3155
3156 2018-08-08  Simon Marchi  <simon.marchi@ericsson.com>
3157
3158         * target.c (str_comma_list_concat_elem): Fix typo in comment.
3159         (target_options_to_string): Add comment.
3160
3161 2018-08-08  Tom Tromey  <tom@tromey.com>
3162
3163         * unittests/scoped_mmap-selftests.c: Check result of "write".
3164
3165 2018-08-08  Jim Wilson  <jimw@sifive.com>
3166
3167         * riscv-tdep.c (enum opcode): Add jump, branch, lr, and sc opcodes.
3168         (decode_register_index_short): New.
3169         (decode_j_type_insn, decode_cj_type_insn): New.
3170         (decode_b_type_insn, decode_cb_type_insn): New.
3171         (riscv_insn::decode): Add support for jumps, branches, lr, and sc.  New
3172         local xlen.  Check xlen when decoding ambiguous compressed insns.  In
3173         compressed decode, use is_c_lui_insn instead of is_lui_insn, and
3174         is_c_sw_insn instead of is_sw_insn.
3175         (riscv_next_pc, riscv_next_pc_atomic_sequence): New.
3176         (riscv_software_single_step): New.
3177         * riscv-tdep.h (riscv_software_single_step): Declare.
3178
3179         * riscv-tdep.c (riscv_isa_xlen): Drop static.
3180         * riscv-tdep.h (riscv_isa_xlen): Add extern declaration.
3181
3182 2018-08-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3183
3184         PR gdb/18050:
3185         * target.c (dispose_inferior): Don't dispose of inferiors that are
3186         already killed.
3187
3188 2018-08-08  Szabolcs Nagy  <szabolcs.nagy@arm.com>
3189
3190         * remote.c (remote_target::download_tracepoint): Change char* to
3191         const char*.
3192
3193 2018-08-07  Simon Marchi  <simon.marchi@polymtl.ca>
3194
3195         * target.h (target_options_to_string): Return an std::string.
3196         * target.c (str_comma_list_concat_elem): Return void, use
3197         std::string.
3198         (do_option): Likewise.
3199         (target_options_to_string): Return an std::string.
3200         * linux-nat.c (linux_nat_target::wait): Adjust.
3201         * target-debug.h (target_debug_print_options): Adjust.
3202
3203 2018-08-07  Tom Tromey  <tom@tromey.com>
3204
3205         * Makefile.in (CPPFLAGS): New variable.
3206         (INTERNAL_CPPFLAGS): Use it.
3207
3208 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
3209
3210         * NEWS: Mention the index cache.
3211
3212 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
3213
3214         * common/pathstuff.h (get_standard_cache_dir): New.
3215         * common/pathstuff.c (get_standard_cache_dir): New.
3216         * build-id.h (build_id_to_string): New.
3217         * dwarf-index-common.h (INDEX4_SUFFIX, INDEX5_SUFFIX,
3218         DEBUG_STR_SUFFIX): Move to here.
3219         * dwarf-index-write.c (INDEX4_SUFFIX, INDEX5_SUFFIX,
3220         DEBUG_STR_SUFFIX): Move from there.
3221         (write_psymtabs_to_index): Make non-static, add basename
3222         parameter.  Write to temporary files, rename when done.
3223         (save_gdb_index_command): Adjust call to
3224         write_psymtabs_to_index.
3225         * dwarf2read.h (dwarf2_per_objfile) <index_cache_res>: New
3226         field.
3227         * dwarf2read.c (dwz_file) <index_cache_res>: New field.
3228         (get_gdb_index_contents_from_cache): New.
3229         (get_gdb_index_contents_from_cache_dwz): New.
3230         (dwarf2_initialize_objfile): Read index from cache.
3231         (dwarf2_build_psymtabs): Save to index.
3232         * dwarf-index-cache.h: New file.
3233         * dwarf-index-cache.c: New file.
3234         * dwarf-index-write.h: New file.
3235
3236 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
3237
3238         * gnulib/aclocal.m4: Re-generate.
3239         * gnulib/config.in: Re-generate.
3240         * gnulib/configure: Re-generate.
3241         * gnulib/import/Makefile.am: Re-generate.
3242         * gnulib/import/Makefile.in: Re-generate.
3243         * gnulib/import/m4/gnulib-cache.m4: Re-generate.
3244         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
3245         * gnulib/import/m4/mkdir.m4: New file.
3246         * gnulib/import/mkdir.c: New file.
3247         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkdir
3248         module.
3249
3250 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
3251
3252         * Makefile.in (COMMON_SFILES): Add common/scoped_mmap.c.
3253         * common/scoped_mmap.c: New file.
3254         * common/scoped_mmap.h (destroy): New method.
3255         (~scoped_mmap, reset): Use destroy.
3256         (scoped_mmap): New move constructor.
3257         (mmap_file): New declaration.
3258         * unittests/scoped_mmap-selftests.c (test_normal,
3259         test_invalid_filename, run_tests): New functions.
3260         (_initialize_scoped_mmap_selftests): Register selftest.
3261
3262 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
3263
3264         * dwarf2read.c (read_gdb_index_from_section): Rename to...
3265         (read_gdb_index_from_buffer): ... this.  Remove section
3266         parameter, add buffer parameter.
3267         (get_gdb_index_contents_ftype,
3268         get_gdb_index_contents_dwz_ftype): New typedefs.
3269         (dwarf2_read_gdb_index): Add callback parameters to get the
3270         index contents.
3271         (get_gdb_index_contents_from_section): New.
3272         (dwarf2_initialize_objfile): Update call to
3273         dwarf2_read_gdb_index.
3274
3275 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
3276
3277         * common/filestuff.h (gdb_fopen_cloexec): New overload.
3278         (gdb_open_cloexec): Likewise.
3279         * nat/linux-osdata.c (command_from_pid): Use string_printf.
3280         (commandline_from_pid): Likewise.
3281         (linux_xfer_osdata_threads): Likewise.
3282         (linux_xfer_osdata_fds): Likewise.
3283         * ada-lang.c (is_package_name): Likewise.
3284         * auxv.c (procfs_xfer_auxv): Likewise.
3285         * breakpoint.c (print_one_breakpoint_location): Use
3286         uiout::field_fmt.
3287         (print_one_catch_solib): Use string_printf.
3288         * coff-pe-read.c (add_pe_exported_sym): Likewise.
3289         (add_pe_forwarded_sym): Likewise.
3290         * dwarf2read.c (create_type_unit_group): Likewise.
3291         (build_error_marker_type): Likewise.
3292         * infcall.c (get_function_name): Likewise.
3293         * valprint.c (print_converted_chars_to_obstack): Likewise.
3294         * xtensa-tdep.c (xtensa_register_type): Likewise.
3295
3296 2018-08-06  Simon Marchi  <simon.marchi@ericsson.com>
3297
3298         * remote.c (remote_target::download_tracepoint): Fix format
3299         string errors.
3300
3301 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3302
3303         * tracefile.c: Include common/byte-vector.h.
3304         (trace_save): Change type of buf to gdb::byte_vector.  Initialize
3305         with trace_regblock_size if needed.  Update uses of buf.
3306
3307 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3308
3309         * tracepoint.h (collection_list) <m_regs_mask>: Change type to
3310         std::vector<unsigned char>.
3311         * tracepoint.c (collection_list::collection_list): Remove
3312         m_regs_mask initializer from initializer list.  Resize
3313         m_regs_mask using the largest remote register number.
3314         (collection_list::add_remote_register): Remove size check on
3315         m_regs_mask.  Use at to access element.
3316         (collection_list::stringify): Change type of temp_buf to
3317         gdb::char_vector.  Update uses of temp_buf.  Resize if needed to
3318         stringify the register mask.  Use pack_hex_byte for the register
3319         mask.
3320
3321 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3322
3323         * tracepoint.h (class collection_list) <add_register>: Remove.
3324         <add_remote_register, add_ax_registers, add_local_register>:
3325         Declare.
3326         <add_memrange>: Add scope parameter.
3327         * tracepoint.c (encode_actions_1): Likewise.
3328         (collection_list::add_register): Rename to ...
3329         (collection_list::add_remote_register): ... this.  Update
3330         comment.
3331         (collection_list::add_ax_registers, add_local_register): New
3332         methods.
3333         (collection_list::add_memrange): Add scope parameter.  Call
3334         add_local_register instead of add_register.
3335         (finalize_tracepoint_aexpr): New function.
3336         (collection_list::collect_symbol): Update calls to add_memrange.
3337         Call add_local_register instead of add_register.  Call
3338         add_ax_registers.  Call finalize_tracepoint_aexpr.
3339         (encode_actions_1): Get remote regnos for $reg action.  Call
3340         add_remote_register, add_ax_registers, and add_local_register.
3341         Update call to add_memrange.  Call finalize_tracepoint_aexpr.
3342         (validate_actionline): Call finalize_tracepoint_aexpr.
3343
3344 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3345
3346         * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE.
3347         Replace array buf with gdb::char_vector buf, of size
3348         get_remote_packet_size ().  Replace references to buf and
3349         BUF_SIZE to buf.data () and buf.size ().  Replace strcpy, strcat
3350         and xsnprintf with snprintf.  Raise errors if the buffer is too
3351         small.
3352
3353 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3354
3355         * remote.c (remote_target::download_tracepoint): Fix the has_more
3356         predicate in the QTDP action list iteration.
3357
3358 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3359
3360         * remote.c (remote_target::download_tracepoint): Fix indentation
3361         in for block.
3362
3363 2018-08-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3364
3365         * proc-api.c (_initialize_proc_api): Remove c, unused.
3366         * procfs.c (procfs_init_inferior): Remove signals, unused.
3367         (procfs_target::make_corefile_notes): Remove old_chain, fpregs,
3368         unused.
3369
3370 2018-08-06  Sergey Korolev  <s.korolev@ndmsystems.com>
3371             Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * linux-nat.c (linux_nat_target::follow_fork): Avoid using
3374         'W_STOPCODE (0)' as this could be ambiguous.
3375
3376 2018-08-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3377
3378         * ser-tcp.c (net_open): Fix thinko when deciding whether to
3379         disable TCP's Nagle algorithm (use "ai_protocol" instead of
3380         "ai_socktype").
3381
3382 2018-08-02  Tom Tromey  <tom@tromey.com>
3383
3384         PR symtab/16842.
3385         * dwarf2read.c (read_func_scope): Set symtab on template parameter
3386         symbols.
3387         (process_structure_scope): Likewise.
3388
3389 2018-08-02  Xavier Roirand  <roirand@adacore.com>
3390
3391         PR gdb/22629:
3392         * darwin-nat.c (darwin_kill_inferior): Fix handling of
3393         kill inferior.
3394
3395 2018-08-02  Tom Tromey  <tom@tromey.com>
3396
3397         * darwin-nat.c (find_inferior_task_it, darwin_find_thread)
3398         (darwin_suspend_inferior, darwin_resume_inferior)
3399         (darwin_decode_notify_message, darwin_resume_inferior_threads)
3400         (darwin_check_new_threads): Check result of get_darwin_inferior.
3401
3402 2018-07-31  Joel Brobecker  <brobecker@adacore.com>
3403
3404         GDB 8.1.1 released.
3405
3406 2018-07-31  Jan Vrany  <jan.vrany@fit.cvut.cz>
3407
3408         * varobj.c (varobj_get_path_expr_parent): Report an error if
3409         parent is a dynamic varobj.
3410
3411 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
3412
3413         * gnulib/aclocal.m4: Re-generate.
3414         * gnulib/config.in: Re-generate.
3415         * gnulib/configure: Re-generate.
3416         * gnulib/import/Makefile.in: Re-generate.
3417         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
3418         * gnulib/import/m4/onceonly.m4: Re-generate.
3419
3420 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
3421
3422         * target-descriptions.c (struct xml_test_tdesc): New.
3423         (xml_tdesc): Change type to std::vector<xml_test_tdesc>.
3424         (record_xml_tdesc): Update.
3425         (maintenance_check_xml_descriptions): Update.
3426         * target-descriptions.h (record_xml_tdesc): Update comment.
3427
3428 2018-07-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3429
3430         * eval.c (evaluate_subexp_for_sizeof): Check for array type before
3431         checking array bounds are defined.
3432
3433 2018-07-30  Tom Tromey  <tom@tromey.com>
3434
3435         * nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
3436         irreflexivity violation.
3437
3438 2018-07-30  Tom Tromey  <tom@tromey.com>
3439
3440         * cli/cli-decode.c (lookup_cmd): Remove lint code.
3441         * value.c (unpack_long): Remove lint code.
3442         * valops.c (value_ind): Remove lint code.
3443         * valarith.c (value_x_binop, value_x_unop, value_equal)
3444         (value_pos): Remove lint code.
3445
3446 2018-07-28  Tom de Vries  <tdevries@suse.de>
3447
3448         * eval.c (evaluate_subexp_for_sizeof): Interpret size of dynamic type
3449         with undefined upper bound as <optimized out>.
3450
3451 2018-07-27  Sergio Durigan Junior  <sergiodj@redhat.com>
3452
3453         * gcore.in: Rename variable "name" to "prefix".  Expand
3454         "usage" text.
3455
3456 2018-07-14  Jon Turney  <jon.turney@dronecode.org.uk>
3457
3458         * windows-nat.c (windows_nat_target::create_inferior): Update to
3459         call close() in global namespace.
3460
3461 2018-07-26  Tom Tromey  <tom@tromey.com>
3462
3463         * dwarf-index-write.c (add_address_entry): Don't add objfile
3464         offsets.
3465         * dbxread.c (find_stab_function): Rename from
3466         find_stab_function_addr.  Return a bound_minimal_symbol.
3467         (read_dbx_symtab): Use raw_text_low, raw_text_high.
3468         Don't add objfile offsets.
3469         (end_psymtab): Use raw_text_low, raw_text_high,
3470         MSYMBOL_VALUE_RAW_ADDRESS.
3471         (read_ofile_symtab): Update.
3472         (process_one_symbol): Update.
3473         * dwarf2read.c (create_addrmap_from_index): Don't add objfile
3474         offsets.
3475         (dw2_relocate): Remove.
3476         (dw2_find_pc_sect_symtab): Bias PC by the text offset before
3477         searching addrmap.
3478         (dwarf2_gdb_index_functions, dwarf2_debug_names_functions):
3479         Update.
3480         (process_psymtab_comp_unit_reader, add_partial_symbol)
3481         (add_partial_subprogram, dwarf2_ranges_read): Update.
3482         (load_partial_dies): Update.
3483         (add_address_entry): Don't add objfile offsets.
3484         (dwarf2_build_include_psymtabs): Update.
3485         (create_addrmap_from_aranges): Don't add objfile offsets.
3486         (dw2_find_pc_sect_compunit_symtab): Update.
3487         * mdebugread.c (parse_symbol): Don't add objfile offsets.
3488         (parse_lines): Remove 'pst' parameter, replace with 'textlow'.
3489         Update.
3490         (parse_partial_symbols): Don't add objfile offsets.  Use
3491         raw_text_low, raw_text_high.  Update.
3492         (handle_psymbol_enumerators, psymtab_to_symtab_1): Update.
3493         * objfiles.c (objfile_relocate1): Don't relocate psymtabs_addrmap
3494         or call 'relocate' quick function.  Clear psymbol_map.
3495         * psympriv.h (struct partial_symbol) <address>: Add section
3496         offset.
3497         <set_unrelocated_address>: Rename from set_address.
3498         <raw_text_low, raw_text_high>: New methods.
3499         <text_low, text_high>: Add objfile parameter.
3500         (add_psymbol_to_bcache): Add 'section' parameter.  Call
3501         set_unrelocated_address.
3502         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
3503         (find_pc_psymbol): Update.
3504         (fixup_psymbol_section, relocate_psymtabs): Remove.
3505         (dump_psymtab, psym_functions): Update.
3506         (add_psymbol_to_bcache, add_psymbol_to_list): Add 'section'
3507         parameter.
3508         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3509         (start_psymtab_common): Update.
3510         * symfile-debug.c (debug_qf_relocate): Remove.
3511         (debug_sym_quick_functions): Update.
3512         * symfile.h (struct quick_symbol_functions) <relocate>: Remove.
3513         * xcoffread.c (scan_xcoff_symtab): Don't add objfile offsets.
3514         Update.
3515
3516 2018-07-26  Tom Tromey  <tromey@redhat.com>
3517
3518         * dbxread.c (end_psymtab): Use text_high_valid and
3519         text_low_valid.
3520         * mdebugread.c (parse_partial_symbols): Use text_low_valid.
3521         (psymtab_to_symtab_1): Use text_high_valid and text_low_valid.
3522         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
3523         Update comment.
3524         <text_low_valid, text_high_valid>: New fields.
3525         <set_text_low, set_text_high>: Update.
3526         * xcoffread.c (scan_xcoff_symtab): Use text_low_valid.
3527
3528 2018-07-26  Tom Tromey  <tom@tromey.com>
3529
3530         * dbxread.c (read_dbx_symtab, end_psymtab, read_ofile_symtab):
3531         Update.
3532         * dwarf2read.c (dwarf2_create_include_psymtab): Don't initialize
3533         textlow and texthigh fields.
3534         (process_psymtab_comp_unit_reader, dwarf2_build_include_psymtabs):
3535         Update.
3536         * mdebugread.c (parse_lines, parse_partial_symbols)
3537         (psymtab_to_symtab_1): Update.
3538         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
3539         Rename fields.  Update comment.  Now private.
3540         <text_low, text_high, set_text_low, set_text_high>: New methods.
3541         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
3542         (find_pc_sect_psymbol, relocate_psymtabs, dump_psymtab)
3543         (start_psymtab_common, maintenance_info_psymtabs)
3544         (maintenance_check_psymtabs): Update.
3545         * xcoffread.c (xcoff_end_psymtab): Don't initialize textlow and
3546         texthigh fields.
3547         (scan_xcoff_symtab): Update.
3548
3549 2018-07-26  Tom Tromey  <tromey@redhat.com>
3550
3551         * psympriv.h (struct partial_symbol) <unrelocated_address,
3552         address, set_address>: New methods.
3553         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymbol)
3554         (fixup_psymbol_section, relocate_psymtabs): Update.
3555         (print_partial_symbols): Add 'objfile' parameter.  Update.
3556         (dump_psymtab, add_psymbol_to_bcache, psym_fill_psymbol_map):
3557         Update.
3558
3559 2018-07-26  Tom Tromey  <tom@tromey.com>
3560
3561         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3562         (debug_names::write_psymbols): Update.
3563         * psympriv.h (struct partial_symbol): Derive from
3564         general_symbol_info.
3565         <obj_section>: New method.
3566         (PSYMBOL_DOMAIN, PSYMBOL_CLASS): Remove.n
3567         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
3568         (find_pc_sect_psymbol, fixup_psymbol_section)
3569         (match_partial_symbol, lookup_partial_symbol, relocate_psymtabs)
3570         (print_partial_symbols, recursively_search_psymtabs)
3571         (compare_psymbols, psymbol_hash, psymbol_compare)
3572         (add_psymbol_to_bcache, maintenance_check_psymtabs)
3573         (psymbol_name_matches, psym_fill_psymbol_map): Update.
3574
3575 2018-07-26  Tom Tromey  <tromey@redhat.com>
3576
3577         * dbxread.c (end_psymtab): Remove dead code.
3578
3579 2018-07-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3580
3581         * dwarf2-frame-tailcall.c (tailcall_frame_sniffer): Exit early if
3582         DWARF unwinders are disabled.
3583         * dwarf2-frame.c: Add dwarf2read.h include.
3584         (dwarf2_frame_sniffer): Exit early if DWARF unwinders are
3585         disabled.
3586         (dwarf2_frame_unwinders_enabled_p): Define.
3587         (show_dwarf_unwinders_enabled_p): New function.
3588         (_initialize_dwarf2_frame): Register switch to control DWARF
3589         unwinder use.
3590         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Declare.
3591         * dwarf2read.c (set_dwarf_cmdlist): Remove static keyword.
3592         (show_dwarf_cmdlist): Remove static keyword.
3593         * dwarf2read.h (set_dwarf_cmdlist): Declare.
3594         (show_dwarf_cmdlist): Declare.
3595         * NEWS: Document new feature.
3596
3597 2018-07-26  Tom de Vries  <tdevries@suse.de>
3598
3599         PR breakpoints/23366
3600         * infcmd.c (info_program_command): Handle ptid == minus_one_ptid.
3601
3602 2018-07-26  Tom de Vries  <tdevries@suse.de>
3603
3604         * dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or
3605         DW_AT_count can't be translated to a dynamic prop.
3606
3607 2018-07-25  Tom de Vries  <tdevries@suse.de>
3608
3609         * dwarf2loc.c (dwarf2_locexpr_baton_eval): Wrap ctx.eval call in
3610         try/catch.
3611
3612 2018-07-25  Jan Vrany  <jan.vrany@fit.cvut.cz>
3613
3614         * breakpoint.c (enable_disable_bp_num_loc): Notify observers.
3615
3616 2018-07-25  Joel Brobecker  <brobecker@adacore.com>
3617
3618         * MAINTAINERS (Global Maintainers): Add Tom Tromey.
3619
3620 2018-07-24  Keith Seitz  <keiths@redhat.comt
3621
3622         PR symtab/23010
3623         * dwarf2read.c (dw2_add_symbol_to_list): New function.
3624         (fixup_go_packaging, new_symbol): Use dw2_add_symbol_to_list
3625         instead of add_symbol_to_list.
3626         (read_file_scope): Call prepare_one_comp_unit before reading
3627         any other DIEs.
3628
3629 2018-07-24  Simon Marchi  <simon.marchi@ericsson.com>
3630
3631         * common/scoped_mmap.h (class scoped_mmap): Fix indentation.
3632
3633 2018-07-24  Tom Tromey  <tom@tromey.com>
3634
3635         * utils.c (malloc, realloc, free): Don't declare.
3636         * configure, config.in: Rebuild.
3637         * configure.ac: Don't check for declarations of free, malloc, or
3638         realloc.
3639
3640 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
3641
3642         * aarch64-linux-nat.c
3643         (aarch64_linux_nat_target::stopped_data_address): Remove unused
3644         variable.
3645         * arm-linux-nat.c (fetch_regs): Likewise.
3646         (store_regs): Likewise.
3647         (fetch_vfp_regs): Likewise.
3648         (store_vfp_regs): Likewise.
3649         (arm_linux_nat_target::insert_hw_breakpoint): Likewise.
3650         (arm_linux_nat_target::remove_hw_breakpoint): Likewise.
3651         (arm_linux_nat_target::insert_watchpoint): Likewise.
3652         (arm_linux_nat_target::remove_watchpoint): Likewise.
3653         * mips-linux-nat.c (mips_linux_nat_target::insert_watchpoint):
3654         Likewise.
3655         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs):
3656         Likewise.
3657         * ppc-linux-nat.c (fetch_register): Likewise.
3658         (fetch_all_gp_regs): Likewise.
3659         (fetch_ppc_registers): Likewise.
3660         (store_all_gp_regs): Likewise.
3661         (store_ppc_registers): Likewise.
3662         (hwdebug_insert_point): Likewise.
3663         (can_use_watchpoint_cond_accel): Likewise.
3664         * remote-sim.c (gdb_os_write_stdout): Likewise.
3665
3666 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
3667             Tom Tromey  <tom@tromey.com>
3668
3669         * warning.m4 (AM_GDB_WARNINGS): Add -Wunused-variable and special
3670         test for it.
3671         * configure: Rebuild.
3672
3673 2018-07-22  Tom Tromey  <tom@tromey.com>
3674
3675         * regformats/regdat.sh: Define xmltarget_${name} inside
3676         #ifndef IN_PROCESS_AGENT.
3677
3678 2018-07-22  Tom Tromey  <tom@tromey.com>
3679
3680         * value.c (value_fetch_lazy_bitfield): Remove unused variable.
3681
3682 2018-07-22  Tom Tromey  <tom@tromey.com>
3683
3684         * symfile.c (reread_symbols): Notify iter, not objfile.
3685
3686 2018-07-22  Tom Tromey  <tom@tromey.com>
3687
3688         * ravenscar-thread.c (ravenscar_thread_target::store_registers):
3689         Use arch_ops.
3690         (ravenscar_thread_target::prepare_to_store): Likewise.
3691
3692 2018-07-22  Tom Tromey  <tom@tromey.com>
3693
3694         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Remove
3695         unused variable.  Call value_fetch_lazy when needed.
3696         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3697         Remove unused variable.  Call value_fetch_lazy when needed.
3698
3699 2018-07-22  Tom Tromey  <tom@tromey.com>
3700
3701         * m32c-tdep.c (mark_dma): Return void.
3702         (make_regs): Remove unused declarations.
3703
3704 2018-07-22  Tom Tromey  <tom@tromey.com>
3705
3706         * guile/scm-cmd.c (gdbscm_dont_repeat): Call
3707         cmdscm_get_valid_command_smob_arg_unsafe for effect.
3708         * guile/scm-block.c (gdbscm_make_block_syms_iter): Call
3709         bkscm_get_valid_block_smob_arg_unsafe for effect.
3710
3711 2018-07-22  Tom Tromey  <tom@tromey.com>
3712
3713         * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
3714         value_type.
3715
3716 2018-07-22  Tom Tromey  <tom@tromey.com>
3717
3718         * windows-nat.c (saved_context): Conditionally define.
3719         * remote.c (remote_target::remote_btrace_maybe_reopen):
3720         Conditionally declare "warned".
3721         * inflow.c (sigquit_ours): Conditionally define.
3722         (new_tty): Move "tty" declaration inside #if.
3723         * guile/guile.c (guile_datadir): Conditionally define.
3724         * charset.c (set_be_le_names): Move some declarations inside #if.
3725         * btrace.c (parse_xml_btrace): Move "errcode" declaration inside
3726         #if.
3727         (parse_xml_btrace_conf): Likewise.
3728
3729 2018-07-22  Tom Tromey  <tom@tromey.com>
3730
3731         * spu-tdep.c (spu_get_overlay_table): Remove unused variable.
3732
3733 2018-07-22  Tom Tromey  <tom@tromey.com>
3734
3735         * guile/scm-value.c (gdbscm_value_call): Remove unused variables.
3736         * guile/scm-math.c (vlscm_unop_gdbthrow, vlscm_binop_gdbthrow)
3737         (vlscm_convert_typed_value_from_scheme): Remove unused variable.
3738         * buildsym-legacy.c (get_macro_table): Remove unused variable.
3739         * stack.c (frame_apply_level_command): Remove unused variable.
3740         * tic6x-tdep.c (tic6x_push_dummy_call): Remove unused variable.
3741         * sparc64-tdep.c (adi_examine_command): Remove unused variable.
3742         * rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Remove
3743         unused variable.
3744         * nios2-tdep.c (nios2_push_dummy_call): Remove unused variable.
3745         * mep-tdep.c (mep_push_dummy_call): Remove unused variable.
3746         * ada-lang.c (ada_lookup_symbol_list_worker): Remove unused
3747         variable.
3748         * amd64-tdep.c (amd64_supply_xsave): Remove unused variable.
3749         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Remove unused
3750         variable.
3751         * breakpoint.c (check_no_tracepoint_commands, update_watchpoint):
3752         Remove unused variable.
3753         * cli/cli-script.c (recurse_read_control_structure): Remove unused
3754         variable.
3755         * common/tdesc.c (print_xml_feature::visit): Remove unused
3756         variable.
3757         * compile/compile-object-load.c (store_regs): Remove unused
3758         variables.
3759         * complaints.c (clear_complaints): Remove unused variable.
3760         * corelow.c (core_target_open): Remove unused variable.
3761         * fbsd-tdep.c (fbsd_core_info_proc_status): Remove unused
3762         variable.
3763         * guile/scm-frame.c (gdbscm_frame_read_var): Remove unused
3764         variable.
3765         * guile/scm-symtab.c (stscm_print_sal_smob): Remove unused
3766         variable.
3767         * guile/scm-type.c (gdbscm_field_baseclass_p): Remove unused
3768         variable.
3769         * guile/scm-utils.c (gdbscm_parse_function_args): Remove unused
3770         variable.
3771         * hppa-tdep.c (hppa_stub_frame_unwind_cache): Remove unused
3772         variable.
3773         * ia64-tdep.c (examine_prologue): Remove unused variable.
3774         * infcall.c (run_inferior_call): Remove unused variable.
3775         * inferior.c (exit_inferior): Remove unused variable.
3776         * infrun.c (infrun_thread_ptid_changed): Remove unused variable.
3777         * linespec.c (decode_line_2): Remove unused variable.
3778         * linux-nat.c (super_close): Remove.
3779         * linux-tdep.c (linux_info_proc): Remove unused variable.
3780         * mi/mi-main.c (mi_execute_command): Remove unused variable.
3781         * microblaze-linux-tdep.c (microblaze_linux_sigtramp_cache):
3782         Remove unused variable.
3783         * parse.c (find_minsym_type_and_address): Remove unused variable.
3784         * printcmd.c (info_symbol_command, printf_floating): Remove unused
3785         variable.
3786         * python/py-breakpoint.c (bppy_set_commands): Remove unused
3787         variable.
3788         * python/py-unwind.c (unwind_infopy_dealloc): Remove unused
3789         variables.
3790         * record-btrace.c (record_btrace_target::store_registers): Remove
3791         unused variable.
3792         (cmd_show_record_btrace_cpu): Remove unused variable.
3793         * riscv-tdep.c (riscv_register_reggroup_p)
3794         (riscv_push_dummy_call, riscv_return_value): Remove unused
3795         variable.
3796         * rust-exp.y (literal): Remove unused variable.
3797         * rust-lang.c (rust_evaluate_subexp) <OP_RUST_ARARAY>: Remove
3798         unused variable.
3799         <STRUCTOP_ANONYMOUS>: Likewise.
3800         * s390-linux-tdep.c (s390_linux_init_abi_31)
3801         (s390_linux_init_abi_64): Remove unused variable.
3802         * ser-ming2.c (ser_windows_read_prim, pipe_select_thread)
3803         (file_select_thread, net_windows_open, _initialize_ser_windows):
3804         Remove unused variables.
3805         * symtab.c (find_pc_sect_line): Remove unused variable.
3806         * target-memory.c (compute_garbled_blocks): Remove unused
3807         variable.
3808         (target_write_memory_blocks): Remove unused variable.
3809         * target.c (target_stack::unpush): Remove unused variables.
3810         * tracepoint.c (start_tracing, all_tracepoint_actions)
3811         (merge_uploaded_trace_state_variables)
3812         (print_one_static_tracepoint_marker): Remove unused variable.
3813         * unittests/basic_string_view/element_access/char/1.cc (test01):
3814         Remove unused variable.
3815         * windows-nat.c (windows_continue, windows_add_all_dlls)
3816         (do_initial_windows_stuff, windows_nat_target::create_inferior):
3817         Remove unused variables.
3818
3819 2018-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
3820
3821         * arm-tdep.c (arm_gdbarch_init): Declare attr_arch and
3822         attr_profile in HAVE_ELF.
3823         * rs6000-tdep.c (bfd_uses_spe_extensions): Declare vector_abi in
3824         HAVE_ELF.
3825
3826 2018-07-20  Simon Marchi  <simon.marchi@polymtl.ca>
3827
3828         * frame.c (frame_register_unwind): Change parameter name.
3829         (frame_unwind_register): Likewise.
3830         (frame_unwind_register_value): Likewise.
3831         (frame_unwind_register_signed): Likewise.
3832         (frame_unwind_register_unsigned): Likewise.
3833         * frame.h (frame_register_unwind): Likewise.
3834         (frame_unwind_register): Likewise.
3835         (frame_unwind_register_value): Likewise.
3836         (frame_unwind_register_signed): Likewise.
3837         (frame_unwind_register_unsigned): Likewise.
3838         (frame_unwind_arch): Likewise.
3839
3840 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
3841
3842         * MAINTAINERS: Update my e-mail address, downgrade to MIPS I-IV
3843         ISA maintenance.
3844
3845 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
3846
3847         * mips-linux-nat.c (mips_linux_nat_target::read_description):
3848         Call `get_ptrace_pid' rather than extracting the ptrace PID by
3849         hand.
3850
3851 2018-07-20  Keith Seitz  <keiths@redhat.com>
3852
3853         * buildsym.h (struct buildsym_compunit) <m_objfile, m_subfiles,
3854         m_main_subfile, m_comp_dir, m_producer, m_debugformat,
3855         m_compunit_symtab, m_language>: Add "m_" prefix.
3856         Update all uses.
3857         * buildsym.c: Update all uses.
3858
3859 2018-07-20  Tom Tromey  <tom@tromey.com>
3860
3861         * buildsym-legacy.h (record_line): Don't use record_line_ftype.
3862         * buildsym.h (record_line_ftype): Remove typedef.
3863
3864 2018-07-20  Tom Tromey  <tom@tromey.com>
3865
3866         * buildsym-legacy.h (augment_type_symtab): Don't declare.
3867         (end_expandable_symtab): Likewise.
3868         (end_symtab_get_static_block): Likewise.
3869         (end_symtab_from_static_block): Likewise.
3870         * buildsym-legacy.c (augment_type_symtab): Remove.
3871         (end_expandable_symtab): Remove.
3872         (end_symtab_get_static_block): Remove.
3873         (end_symtab_from_static_block): Remove.
3874
3875 2018-07-20  Tom Tromey  <tom@tromey.com>
3876
3877         * dwarf2read.c: Include buildsym.h.
3878         (struct dwarf2_cu) <builder>: New method.
3879         (fixup_go_packaging): Update.
3880         (process_full_comp_unit, process_full_type_unit): Update.  Don't
3881         use scoped_free_pendings.
3882         (using_directives): Add "cu" parameter, remove "language".
3883         (read_import_statement, setup_type_unit_groups, )
3884         (read_func_scope, read_lexical_block_scope)
3885         (dwarf2_record_block_ranges, read_namespace): Update.
3886         (lnp_state_machine::lnp_state_machine): Add cu parameter.
3887         (lnp_state_machine::handle_end_sequence): Update.
3888         (class lnp_state_machine) <m_cu>: New member.
3889         <m_record_line_callback>: Remove.
3890         <m_currently_recording_lines>: New member.
3891         (lnp_state_machine::handle_set_file): Update.
3892         (noop_record_line): Remove.
3893         (dwarf_record_line_p): Add cu parameter.
3894         (dwarf_record_line_1, dwarf_finish_line): Likewise.
3895         (lnp_state_machine::record_line)
3896         (lnp_state_machine::lnp_state_machine)
3897         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
3898         (dwarf_decode_lines): Update.
3899         (dwarf2_start_subfile): Add cu parameter.
3900         (dwarf2_start_symtab, new_symbol): Update.
3901         (macro_start_file, dwarf_decode_macro_bytes): Add cu parameter.
3902         Remove dwarf2_per_objfile parameter.
3903         (dwarf_decode_macros): Update.
3904
3905 2018-07-20  Tom Tromey  <tom@tromey.com>
3906
3907         * stabsread.c (define_symbol): Update.
3908         * buildsym-legacy.h (get_buildsym_compunit): Declare.
3909         * dwarf2read.c (new_symbol): Update.
3910         * cp-support.h (cp_scan_for_anonymous_namespaces): Update.
3911         * cp-namespace.c: Include buildsym.h.
3912         (cp_scan_for_anonymous_namespaces): Add "compunit" parameter.
3913         * buildsym-legacy.c (get_buildsym_compunit): New function.
3914
3915 2018-07-20  Tom Tromey  <tom@tromey.com>
3916
3917         * xcoffread.c: Include buildsym-legacy.h.
3918         * windows-nat.c: Include buildsym-legacy.h.
3919         * stabsread.c: Include buildsym-legacy.h.
3920         * mdebugread.c: Include buildsym-legacy.h.
3921         * buildsym-legacy.h: New file.
3922         * buildsym-legacy.c: New file, from buildsym.c.
3923         * go32-nat.c: Include buildsym-legacy.h.
3924         * dwarf2read.c: Include buildsym-legacy.h.
3925         * dbxread.c: Include buildsym-legacy.h.
3926         * cp-namespace.c: Include buildsym-legacy.h.
3927         * coffread.c: Include buildsym-legacy.h.
3928         * buildsym.h: Move some contents to buildsym-legacy.h.
3929         * buildsym.c: Include buildsym-legacy.h.  Move many functions to
3930         buildsym-legacy.c.
3931         * Makefile.in (HFILES_NO_SRCDIR): Add buildsym-legacy.h.
3932
3933 2018-07-20  Tom Tromey  <tom@tromey.com>
3934
3935         * buildsym.h (struct buildsym_compunit): Move from buildsym.c.
3936         * buildsym.c (struct buildsym_compunit): Move to buildsym.h.
3937         (buildsym_compunit::buildsym_compunit)
3938         (buildsym_compunit::~buildsym_compunit)
3939         (buildsym_compunit::get_macro_table): Define.
3940
3941 2018-07-20  Tom Tromey  <tom@tromey.com>
3942
3943         * buildsym.c (reset_symtab_globals): Remove.
3944         (buildsym_compunit::end_symtab_from_static_block): Update.
3945         (buildsym_compunit::augment_type_symtab): Update.
3946         (end_symtab_from_static_block): Call free_buildsym_compunit.
3947         (augment_type_symtab, end_symtab, end_expandable_symtab):
3948         Likewise.
3949
3950 2018-07-20  Tom Tromey  <tom@tromey.com>
3951
3952         * arch-utils.c: Do not include buildsym.h.
3953         * mipsread.c: Do not include buildsym.h.
3954         * machoread.c: Do not include buildsym.h.
3955         * elfread.c: Do not include buildsym.h.
3956
3957 2018-07-20  Tom Tromey  <tom@tromey.com>
3958
3959         * buildsym.c (buildsym_compunit::buildsym_compunit): Do more
3960         initialization.
3961         (buildsym_compunit): Add new constructor.
3962         (struct buildsym_compunit) <get_last_source_file, finish_block,
3963         record_block_range, start_subfile, patch_subfile_names,
3964         push_subfile, pop_subfile, record_line, get_compunit_symtab,
3965         set_last_source_start_addr, get_last_source_start_addr,
3966         get_local_using_directives, set_local_using_directives,
3967         get_global_using_directives, outermost_context_p,
3968         get_current_context_stack, get_context_stack_depth,
3969         get_current_subfile, get_local_symbols, get_file_symbols,
3970         get_global_symbols, record_debugformat, record_producer,
3971         push_context, pop_context, end_symtab_get_static_block,
3972         end_symtab_from_static_block, end_symtab, end_expandable_symtab>:
3973         New public methods.
3974         <record_pending_block, finish_block_internal, make_blockvector,
3975         watch_main_source_file_lossage, end_symtab_with_blockvector>: New
3976         private methods.
3977         Update all users.
3978
3979 2018-05-22  Tom Tromey  <tom@tromey.com>
3980
3981         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
3982         parameter.
3983         (finish_block_internal): Update.
3984
3985 2018-07-20  Tom Tromey  <tom@tromey.com>
3986
3987         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
3988         parameter.
3989         (finish_block_internal): Update.
3990
3991 2018-07-20  Tom Tromey  <tom@tromey.com>
3992
3993         * buildsym.h (EXTERN): Don't define or undef.
3994         * buildsym.c (EXTERN): Don't define.
3995
3996 2018-07-20  Tom Tromey  <tom@tromey.com>
3997
3998         * buildsym.c: Remove TODO comment.
3999
4000 2018-07-20  Tom Tromey  <tom@tromey.com>
4001
4002         * coffread.c (coff_symtab_read): Update.
4003         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
4004         (xcoff_new_init): Update.
4005         * mipsread.c (mipscoff_new_init): Update.
4006         * mdebugread.c (mdebug_build_psymtabs): Update.
4007         * elfread.c (elf_new_init): Update.
4008         * dwarf2read.c (process_full_comp_unit, process_full_type_unit):
4009         Update.
4010         * dbxread.c (dbx_new_init, dbx_psymtab_to_symtab_1)
4011         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4012         (stabsect_build_psymtabs): Update.
4013         * buildsym.h (buildsym_init): Don't declare.
4014         * buildsym.c: Update comment.
4015         (prepare_for_building): Remove.
4016         (start_symtab, restart_symtab): Update.
4017         (reset_symtab_globals): Update comment.
4018         (buildsym_init): Remove.
4019
4020 2018-07-20  Tom Tromey  <tom@tromey.com>
4021
4022         * xcoffread.c (read_xcoff_symtab, process_xcoff_symbol): Update.
4023         * stabsread.c (patch_block_stabs, define_symbol, read_type)
4024         (read_enum_type, common_block_start, common_block_end)
4025         (cleanup_undefined_types_1, finish_global_stabs): Update.
4026         * mdebugread.c (psymtab_to_symtab_1): Update.
4027         * dwarf2read.c (fixup_go_packaging, read_func_scope)
4028         (read_lexical_block_scope, new_symbol): Update.
4029         * dbxread.c (process_one_symbol): Update.
4030         * coffread.c (coff_symtab_read, process_coff_symbol)
4031         (coff_read_enum_type): Update.
4032         * buildsym.h (file_symbols, global_symbols, local_symbols): Don't
4033         declare.
4034         (get_local_symbols, get_file_symbols, get_global_symbols): New
4035         functions.
4036         * buildsym.c (~buildsym_compunit): Clean up m_file_symbols and
4037         m_global_symbols.
4038         <m_file_symbols, m_local_symbols, m_global_symbols>: New members.
4039         (~scoped_free_pendings): Update.
4040         (finish_block, prepare_for_building, reset_symtab_globals)
4041         (end_symtab_get_static_block, end_symtab_with_blockvector)
4042         (augment_type_symtab, push_context): Update.
4043         (get_local_symbols, get_file_symbols, get_global_symbols): New
4044         functions.
4045         (buildsym_init): Update.
4046
4047 2018-07-20  Tom Tromey  <tom@tromey.com>
4048
4049         * dwarf2read.c (process_full_comp_unit): Do not set list_in_scope.
4050         (process_full_type_unit): Likewise.
4051         (dwarf2_start_symtab): Set list_in_scope.
4052
4053 2018-07-20  Tom Tromey  <tom@tromey.com>
4054
4055         * dwarf2read.c (process_psymtab_comp_unit_reader)
4056         (build_type_psymtabs_reader): Do not set list_in_scope.
4057
4058 2018-07-20  Tom Tromey  <tom@tromey.com>
4059
4060         * buildsym.c (free_pendings): Remove.
4061         (add_symbol_to_list, scoped_free_pendings)
4062         (finish_block_internal, buildsym_init): Update.
4063
4064 2018-07-20  Tom Tromey  <tom@tromey.com>
4065
4066         * xcoffread.c (read_xcoff_symtab): Update.
4067         * dwarf2read.c (read_func_scope, read_lexical_block_scope):
4068         Update.
4069         * dbxread.c (process_one_symbol): Update.
4070         * coffread.c (coff_symtab_read): Update.
4071         * buildsym.h (finish_block): Update.
4072         * buildsym.c (finish_block): Remove "listhead" argument.
4073         (end_symtab_get_static_block): Update.
4074
4075 2018-07-20  Tom Tromey  <tom@tromey.com>
4076
4077         * buildsym.h (class scoped_free_pendings): Remove constructor.
4078         * buildsym.c (struct buildsym_compunit) <free_pending_blocks>: New
4079         method.
4080         <m_pending_block_obstack, m_pending_blocks>: New members.
4081         (pending_block_obstack, pending_blocks): Remove.
4082         (scoped_free_pendings::scoped_free_pendings): Default.
4083         (~scoped_free_pendings): Update.
4084         (free_pending_blocks): Remove.
4085         (finish_block_internal, record_pending_block, make_blockvector)
4086         (end_symtab_get_static_block, augment_type_symtab, push_context)
4087         (buildsym_init): Update.
4088
4089 2018-07-20  Tom Tromey  <tom@tromey.com>
4090
4091         * buildsym.c (struct buildsym_compunit) <m_pending_addrmap,
4092         m_pending_addrmap_obstack, m_pending_addrmap_interesting>: New
4093         members.
4094         (pending_addrmap, pending_addrmap_obstack)
4095         (pending_addrmap_interesting): Remove.
4096         (scoped_free_pendings, record_block_range, make_blockvector)
4097         (prepare_for_building, reset_symtab_globals, buildsym_init):
4098         Update.
4099
4100 2018-07-20  Tom Tromey  <tom@tromey.com>
4101
4102         * xcoffread.c (process_linenos): Update.
4103         * stabsread.c (define_symbol, read_type, read_enum_type): Update.
4104         * mdebugread.c (psymtab_to_symtab_1): Update.
4105         * dwarf2read.c (setup_type_unit_groups)
4106         (lnp_state_machine::handle_set_file, dwarf_record_line_p)
4107         (lnp_state_machine::record_line, dwarf_decode_lines): Update.
4108         * dbxread.c (process_one_symbol): Update.
4109         * coffread.c (coff_symtab_read, enter_linenos)
4110         (process_coff_symbol): Update.
4111         * buildsym.h (current_subfile): Don't declare.
4112         (get_current_subfile): Declare.
4113         * buildsym.c (struct buildsym_compunit) <m_current_subfile>: New
4114         member.
4115         (start_subfile, free_buildsym_compunit, push_subfile)
4116         (prepare_for_building, start_symtab): Update.
4117         (get_current_subfile): New function.
4118
4119 2018-07-20  Tom Tromey  <tom@tromey.com>
4120
4121         * coffread.c (coff_symtab_read): Update.
4122         * xcoffread.c (read_xcoff_symtab): Update.
4123         * dwarf2read.c (new_symbol): Update.
4124         (read_func_scope, read_lexical_block_scope): Update.
4125         * dbxread.c (process_one_symbol): Update.
4126         * buildsym.h (context_stack, context_stack_depth): Don't declare.
4127         (outermost_context_p): Remove macro.
4128         (outermost_context_p, get_current_context_stack)
4129         (get_context_stack_depth): Declare.
4130         (pop_context): Return struct context_stack.
4131         * buildsym.c (struct buildsym_compunit) <m_context_stack: New
4132         member.
4133         (context_stack_size): Remove.
4134         (INITIAL_CONTEXT_STACK_SIZE): Remove.
4135         (prepare_for_building, end_symtab_get_static_block)
4136         (augment_type_symtab, push_context): Update.
4137         (pop_context): Return struct context_stack.
4138         (outermost_context_p, get_current_context_stack)
4139         (get_context_stack_depth): New functions.
4140         (buildsym_init): Update.
4141
4142 2018-07-20  Tom Tromey  <tom@tromey.com>
4143
4144         * rust-exp.y: Now a pure parser.  Update all rules.
4145         (%union): Move earlier.
4146         (current_parser, work_obstack): Remove globals.
4147         (rust_parser, ~rust_parser): Update.
4148         (class rust_parser) <copy_name, concat3, crate_name, super_name,
4149         lex_character, lex_number, lex_string, lex_identifier,
4150         rust_lookup_type, convert_params_to_types, convert_ast_to_type,
4151         convert_name, convert_params_to_expression,
4152         convert_ast_to_expression, ast_basic_type, ast_operation,
4153         ast_compound_assignment, rust_op, ast_literal, ast_dliteral,
4154         ast_structop, ast_structop_anonymous, ast_unary, ast_cast,
4155         ast_call_ish, ast_path, ast_string, ast_struct, ast_range,
4156         ast_array_type, ast_slice_type, ast_reference_type,
4157         ast_pointer_type, ast_function_type, ast_tuple_type>: New methods.
4158         (rust_parse): Update.
4159         (rustyyerror, rustyylex): Add parser parameter.
4160         (rust_lex_test_one, rust_lex_int_test, rust_lex_exception_test)
4161         (rust_lex_stringish_test, rust_lex_test_sequence)
4162         (rust_lex_test_trailing_dot, rust_lex_test_completion)
4163         (rust_lex_test_push_back, rust_lex_tests): Update.
4164
4165 2018-07-19  Pedro Alves  <palves@redhat.com>
4166
4167         * guile/guile-internal.h (gdbscm_scm_to_c_string): Now returns a
4168         gdb::unique_xmalloc_ptr.
4169         * guile/scm-breakpoint.c (gdbscm_set_breakpoint_condition_x):
4170         Adjust to use dbscm_wrap and gdb::unique_xmalloc_ptr.
4171         * guile/scm-exception.c (gdbscm_exception_message_to_string): Use
4172         copy-initialization.
4173         * guile/scm-pretty-print.c (ppscm_print_children): Use
4174         gdb::unique_xmalloc_ptr instead of cleanups.
4175         (gdbscm_apply_val_pretty_printer): Remove cleanups.
4176         * guile/scm-string.c (gdbscm_scm_to_c_string): Now returns a
4177         gdb::unique_xmalloc_ptr.
4178         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
4179         Adjust to use gdb::unique_xmalloc_ptr.
4180         * guile/scm-utils.c (extract_arg): Adjust.
4181         * guile/scm-value.c (gdbscm_value_field): Adjust to use
4182         gdb::unique_xmalloc_ptr instead of a cleanup.
4183
4184 2018-07-19  Tom Tromey  <tom@tromey.com>
4185
4186         * utils.c (do_value_free_to_mark)
4187         (make_cleanup_value_free_to_mark): Remove.
4188         * utils.h (make_cleanup_value_free_to_mark): Remove.
4189
4190 2018-07-19  Pedro Alves  <palves@redhat.com>
4191
4192         * guile/guile-internal.h (gdbscm_wrap): Really make 'args' a
4193         forwarding reference.
4194
4195 2018-07-18  Pedro Alves  <palves@redhat.com>
4196
4197         * guile/guile.c (gdbscm_execute_gdb_command): Adjust to use
4198         gdbscm_wrap.  Use gdb::unique_xmalloc_ptr<char> instead of a
4199         cleanup.
4200
4201 2018-07-18  Pedro Alves  <palves@redhat.com>
4202
4203         * guile/guile-internal.h: Add comment about mixing GDB and Scheme
4204         exceptions.
4205         (GDBSCM_HANDLE_GDB_EXCEPTION_WITH_CLEANUPS): Delete.
4206         (gdbscm_wrap): New.
4207         * guile/scm-frame.c (gdbscm_frame_read_register): Use xfree
4208         directly instead of a cleanup.
4209         * guile/scm-math.c (vlscm_unop_gdbthrow): New, factored out from ...
4210         (vlscm_unop): ... this.  Reimplement using gdbscm_wrap.
4211         (vlscm_binop_gdbthrow): New, factored out from ...
4212         (vlscm_binop): ... this.  Reimplement using gdbscm_wrap.
4213         (vlscm_rich_compare): Use gdbscm_wrap.
4214         * guile/scm-symbol.c (gdbscm_lookup_symbol): Use xfree directly
4215         instead of a cleanup.
4216         (gdbscm_lookup_global_symbol): Use xfree directly instead of a
4217         cleanup.
4218         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
4219         Use xfree directly instead of a cleanup.
4220         * guile/scm-value.c (gdbscm_make_value, gdbscm_make_lazy_value):
4221         Adjust to use gdbscm_wrap and scoped_value_mark.
4222         (gdbscm_value_optimized_out_p): Adjust to use gdbscm_wrap.
4223         (gdbscm_value_address, gdbscm_value_dereference)
4224         (gdbscm_value_referenced_value): Adjust to use gdbscm_wrap and
4225         scoped_value_mark.
4226         (gdbscm_value_dynamic_type): Use scoped_value_mark.
4227         (vlscm_do_cast, gdbscm_value_field): Adjust to use gdbscm_wrap and
4228         scoped_value_mark.
4229         (gdbscm_value_subscript, gdbscm_value_call): Adjust to use
4230         gdbscm_wrap and scoped_value_mark.
4231         (gdbscm_value_to_string): Use xfree directly instead of a
4232         cleanup.  Move 'buffer' unique_ptr to TRY scope.
4233         (gdbscm_value_to_lazy_string): Use xfree directly instead of a
4234         cleanup.  Move 'buffer' unique_ptr to TRY scope.  Use
4235         scoped_value_mark.
4236         (gdbscm_value_fetch_lazy_x): Use gdbscm_wrap.
4237         (gdbscm_parse_and_eval): Adjust to use gdbscm_wrap and
4238         scoped_value_mark.
4239         (gdbscm_history_ref, gdbscm_history_append_x): Adjust to use
4240         gdbscm_wrap.
4241
4242 2018-07-18  Tom de Vries  <tdevries@suse.de>
4243
4244         * findvar.c (default_read_var_value): Also resolve dynamic type for
4245         LOC_OPTIMIZED_OUT vars.
4246
4247 2018-07-18  Maciej W. Rozycki  <macro@mips.com>
4248
4249         * mips-tdep.c (micromips_next_pc): Add SYSCALL instruction
4250         decoding.
4251
4252 2018-07-17  Tom Tromey  <tom@tromey.com>
4253
4254         * guile/scm-param.c (pascm_set_func, pascm_show_func)
4255         (compute_enum_list, pascm_set_param_value_x)
4256         (gdbscm_parameter_value): Update.
4257         * guile/guile-internal.h (gdbscm_scm_to_string): Update.
4258         (gdbscm_scm_to_host_string): Update.
4259         * guile/scm-math.c (vlscm_convert_typed_value_from_scheme):
4260         Update.
4261         * guile/scm-cmd.c (cmdscm_add_completion): Update.
4262         * guile/scm-pretty-print.c (ppscm_print_string_repr): Update.
4263         * guile/scm-string.c (gdbscm_scm_to_string): Return
4264         unique_xmalloc_ptr.
4265         (gdbscm_scm_to_host_string): Likewise.
4266
4267 2018-07-17  Tom Tromey  <tom@tromey.com>
4268
4269         * guile/guile.c (gdbscm_eval_from_control_command): Update.
4270         * guile/guile-internal.h (gdbscm_safe_eval_string): Update.
4271         * guile/scm-objfile.c (gdbscm_execute_objfile_script): Update.
4272         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Return
4273         unique_xmalloc_ptr.
4274
4275 2018-07-17  Tom Tromey  <tom@tromey.com>
4276
4277         * guile/scm-param.c (pascm_signal_setshow_error): Update.
4278         * guile/guile-internal.h (gdbscm_exception_message_to_string):
4279         Update.
4280         * guile/scm-cmd.c (cmdscm_function): Update.
4281         * guile/scm-pretty-print.c
4282         (ppscm_print_exception_unless_memory_error): Update.
4283         * guile/scm-exception.c (gdbscm_exception_message_to_string):
4284         Return unique_xmalloc_ptr.
4285
4286 2018-07-17  Tom Tromey  <tom@tromey.com>
4287
4288         * guile/scm-pretty-print.c (ppscm_make_pp_type_error_exception):
4289         Use string_printf.
4290
4291 2018-07-17  Jim Wilson  <jimw@sifive.com>
4292
4293         * riscv-tdep.c (riscv_has_feature): Delete comment that refers to
4294         set_gdbarch_decr_pc_after_break.  Call riscv_read_misa_reg always.
4295         (riscv_gdbarch_init): Delete local has_compressed_isa.  Delete now
4296         unecessary braces after EF_RISCV_RVC test.  Delete call to
4297         set_gdbarch_decr_pc_after_break.
4298
4299         * riscv-tdep.h (DECLARE_CSR): Use RISCV_FIRST_CSR_REGNUM instead of
4300         RISCV_LAST_FP_REGNUM + 1.
4301         (RSICV_CSR_LEGACY_MISA_REGNUM): Add RISCV_FIRST_CSR_REGNUM.
4302
4303 2018-07-17  Tom Tromey  <tom@tromey.com>
4304
4305         * configure.ac: Remove --disable-gdbcli.
4306         * configure: Rebuild.
4307         * Makefile.in (SUBDIR_CLI_DEPS, SUBDIR_CLI_LDFLAGS)
4308         (SUBDIR_CLI_CFLAGS): Remove.
4309         (SFILES): Use SUBDIR_CLI_SRCS.
4310         (COMMON_OBS): Use SUBDIR_CLI_OBS.
4311
4312 2018-07-17  Tom Tromey  <tom@tromey.com>
4313
4314         PR gdb/18624:
4315         * coffread.c (coff_symtab_read): Use scoped_free_pendings.
4316
4317 2018-07-16  Jim Wilson  <jimw@sifive.com>
4318
4319         * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi.
4320
4321 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
4322
4323         * ia64-libunwind-tdep.c (libunwind_frame_cache): Remove unused
4324         variable.
4325         (libunwind_frame_sniffer): Likewise.
4326         (libunwind_frame_prev_register): Likewise.
4327         (libunwind_sigtramp_frame_sniffer): Likewise.
4328         * ia64-tdep.c (ia64_access_reg): Likewise.
4329         (ia64_access_rse_reg): Likewise.
4330         (ia64_libunwind_sigtramp_frame_this_id): Likewise.
4331         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Likewise.
4332
4333 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
4334
4335         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Add cast.
4336
4337 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
4338
4339         * remote-sim.c (gdbsim_target::close,
4340         gdbsim_target::mourn_inferior): Remove unused variables.
4341
4342 2018-07-16  Simon Marchi  <simon.marchi@polymtl.ca>
4343
4344         * ia64-tdep.c (ktab_buf): New global.
4345         (getunwind_table): Return a gdb::optional<gdb::byte_vector>.
4346         (get_kernel_table): Adjust.
4347
4348 2018-07-16  Tom Tromey  <tom@tromey.com>
4349
4350         * xcoffread.c (read_xcoff_symtab): Use outermost_context_p.
4351         * dwarf2read.c (using_directives, new_symbol): Use
4352         outermost_context_p.
4353         * dbxread.c (process_one_symbol): Use outermost_context_p.
4354         * coffread.c (coff_symtab_read): Use outermost_context_p.
4355
4356 2018-07-16  Tom Tromey  <tom@tromey.com>
4357
4358         * dwarf2read.c (using_directives, read_func_scope)
4359         (read_lexical_block_scope): Update.
4360         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
4361         * buildsym.h (local_using_directives, global_using_directives):
4362         Don't declare.
4363         (get_local_using_directives, set_local_using_directives)
4364         (get_global_using_directives): Declare.
4365         * buildsym.c (struct buildsym_compunit) <m_local_using_directives,
4366         m_global_using_directives>: New members.
4367         (finish_block_internal, prepare_for_building)
4368         (reset_symtab_globals, end_symtab_get_static_block)
4369         (push_context): Update.
4370         (get_local_using_directives, set_local_using_directives)
4371         (get_global_using_directives): New functions.
4372         (buildsym_init): Update.
4373
4374 2018-07-16  Tom Tromey  <tom@tromey.com>
4375
4376         * xcoffread.c (xcoff_initial_scan): Don't call
4377         free_pending_blocks.
4378         * dbxread.c (dbx_symfile_read): Don't call free_pending_blocks.
4379         * buildsym.h (class scoped_free_pendings): Add constructor.
4380         (free_pending_blocks): Don't declare.
4381         * buildsym.c (scoped_free_pendings::scoped_free_pendings): New.
4382         (free_pending_blocks): Now static.
4383
4384 2018-07-16  Tom Tromey  <tom@tromey.com>
4385
4386         * buildsym.h (push_subfile, pop_subfile): Update declarations.
4387         * buildsym.c (struct buildsym_compunit) <m_subfile_stack>: New
4388         member.
4389         (struct subfile_stack): Remove.
4390         (subfile_stack): Remove.
4391         (push_subfile, pop_subfile, buildsym_init): Update.
4392
4393 2018-07-16  Tom Tromey  <tom@tromey.com>
4394
4395         * buildsym.c (push_subfile): Use gdb_assert.
4396         (pop_subfile): Use gdb_assert.
4397
4398 2018-07-16  Tom Tromey  <tom@tromey.com>
4399
4400         * buildsym.h (merge_symbol_lists): Remove.
4401         * buildsym.c (merge_symbol_lists): Remove.
4402
4403 2018-07-16  Tom Tromey  <tom@tromey.com>
4404
4405         * stabsread.c (scan_file_globals): Update comment.
4406         * stabsread.h (scan_file_globals): Move from buildsym.h.
4407         * buildsym.h (scan_file_globals): Move to stabsread.h.
4408
4409 2018-07-16  Tom Tromey  <tom@tromey.com>
4410
4411         * xcoffread.c (xcoff_new_init): Update.
4412         * mipsread.c (mipscoff_new_init): Update.
4413         * mdebugread.c (mdebug_build_psymtabs): Update.
4414         * elfread.c (elf_new_init): Update.
4415         * dbxread.c (dbx_new_init, coffstab_build_psymtabs)
4416         (elfstab_build_psymtabs, stabsect_build_psymtabs): Update.
4417         * buildsym.h (buildsym_new_init): Don't declare.
4418         * buildsym.c (buildsym_new_init): Remove.
4419
4420 2018-07-16  Tom Tromey  <tom@tromey.com>
4421
4422         * stabsread.h (within_function): Move from buildsym.h.
4423         * stabsread.c (start_stabs): Clear within_function.
4424         * coffread.c (coff_start_symtab): Clear within_function.
4425         * buildsym.h (within_function): Move to stabsread.h.
4426         * buildsym.c (prepare_for_building): Update.
4427
4428 2018-07-16  Tom Tromey  <tom@tromey.com>
4429
4430         * stabsread.h (processing_gcc_compilation): Move from buildsym.h.
4431         * dwarf2read.c (dwarf2_start_symtab): Don't set
4432         processing_gcc_compilation.
4433         * buildsym.h (processing_gcc_compilation): Move to stabsread.h.
4434
4435 2018-07-16  Tom Tromey  <tom@tromey.com>
4436
4437         * stabsread.h (HASHSIZE, hashname, symnum, next_symbol_text)
4438         (next_symbol_text_func): Move from buildsym.h.
4439         * stabsread.c (hashname): Move from buildsym.c.
4440         * buildsym.h (HASHSIZE, symnum, next_symbol_text)
4441         (next_symbol_text_func, hashname): Move to stabsread.h.
4442         * buildsym.c: Don't include bcache.h
4443         (hashname): Move to stasbread.c.
4444
4445 2018-07-16  Tom Tromey  <tom@tromey.com>
4446
4447         * buildsym.h (context_stack_size): Don't declare.
4448         * buildsym.c (context_stack_size): New global.
4449
4450 2018-07-16  Tom Tromey  <tom@tromey.com>
4451
4452         * dbxread.c (processing_acc_compilation): New global.
4453         * buildsym.h (processing_acc_compilation): Don't declare.
4454
4455 2018-07-16  Tom Tromey  <tom@tromey.com>
4456
4457         * xcoffread.c (aix_process_linenos, complete_symtab): Update.
4458         * dbxread.c (read_ofile_symtab): Update.
4459         * coffread.c (coff_start_symtab, coff_end_symtab): Update.
4460         * buildsym.h (last_source_start_addr): Remove.
4461         (set_last_source_start_addr, get_last_source_start_addr):
4462         Declare.
4463         * buildsym.c (buildsym_compunit::buildsym_compunit): Add last_addr
4464         parameter.
4465         (struct buildsym_compunit) <m_last_source_start_addr>: New
4466         member.
4467         (prepare_for_building): Remove start_addr parameter.
4468         (start_symtab, restart_symtab, end_symtab_get_static_block)
4469         (end_symtab_with_blockvector): Update.
4470         (set_last_source_start_addr, get_last_source_start_addr): New
4471         functions.
4472
4473 2018-07-16  Tom Tromey  <tom@tromey.com>
4474
4475         * buildsym.c (struct buildsym_compunit) <m_have_line_numbers>: New
4476         member.
4477         (have_line_numbers): Remove.
4478         (record_line, prepare_for_building, end_symtab_get_static_block)
4479         (augment_type_symtab): Update.
4480
4481 2018-07-16  Tom Tromey  <tom@tromey.com>
4482
4483         * buildsym.c (~buildsym_compunit): Free the macro table.
4484         (struct buildsym_compunit) <get_macro_table, release_macros>: New
4485         methods.
4486         <m_pending_macros>: New member.
4487         (pending_macros): Remove.
4488         (~scoped_free_pendings, get_macro_table, prepare_for_building)
4489         (reset_symtab_globals, end_symtab_get_static_block)
4490         (end_symtab_with_blockvector, augment_type_symtab)
4491         (buildsym_init): Update.
4492
4493 2018-07-16  Tom Tromey  <tom@tromey.com>
4494
4495         * buildsym.c (buildsym_compunit::buildsym_compunit): Add name
4496         parameter.
4497         (buildsym_compunit::set_last_source_file): New method.
4498         <m_last_source_file>: New member.
4499         (prepare_for_building): Remove "name" parameter.
4500         (start_symtab, restart_symtab, reset_symtab_globals): Update.
4501         (last_source_file): Remove.
4502         (set_last_source_file, get_last_source_file): Update.
4503
4504 2018-07-16  Tom Tromey  <tom@tromey.com>
4505
4506         * buildsym.c (prepare_for_building): Add assert.
4507
4508 2018-07-16  Tom Tromey  <tom@tromey.com>
4509
4510         * buildsym.c (~buildsym_compunit): Update.
4511         (struct buildsym_compunit) <comp_unit>: Now a unique_xmalloc_ptr.
4512         (start_subfile, patch_subfile_names)
4513         (end_symtab_with_blockvector): Update.
4514
4515 2018-07-16  Tom Tromey  <tom@tromey.com>
4516
4517         * buildsym.c (struct buildsym_compunit): Add constructor,
4518         destructor, initializers.
4519         (start_buildsym_compunit): Remove.
4520         (free_buildsym_compunit): Use "delete".
4521         (start_symtab, restart_symtab): Use "new".
4522
4523 2018-07-13  Simon Marchi  <simon.marchi@polymtl.ca>
4524
4525         * symfile.c (set_objfile_default_section_offset): Remove struct
4526         keyword.
4527
4528 2018-07-14  Stafford Horne  <shorne@gmail.com>
4529
4530         * (Responsible Maintainers): Add myself as or1k maintainer.
4531
4532 2018-07-13  Tom Tromey  <tom@tromey.com>
4533
4534         * symfile.c (set_objfile_default_section_offset): Use extra braces
4535         around initializer.
4536
4537 2018-07-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4538
4539         * s390-tdep.c (s390_displaced_step_fixup): Adjust PC for a
4540         non-branching basr.
4541
4542 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4543
4544         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4545         unittests/cli-utils-selftests.c
4546         * unittests/cli-utils-selftests.c: New file.
4547
4548 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4549
4550         * NEWS: Mention new commands. Mention change to 'thread apply'.
4551
4552 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4553
4554         * thread.c (thr_try_catch_cmd): New function.
4555         (thread_apply_all_command): Handle qcs flags.
4556         (thread_apply_command): Handle qcs flags.
4557         (taas_command): New function.
4558         (tfaas_command): New function.
4559         (_initialize_thread): Update to setup the new commands 'taas
4560         and 'tfaas'. Change doc string for 'thread apply'.
4561
4562 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4563
4564         * stack.c: (trailing_outermost_frame): New function, mostly
4565         extracted from backtrace_command_1.
4566         (leading_innermost_frame): New function.
4567         (backtrace_command_1): Update to call trailing_outermost_frame.
4568         (frame_apply_command_count): New function.
4569         (frame_apply_level_command): New function.
4570         (frame_apply_all_command): New function.
4571         (frame_apply_command): New function.
4572         (faas_command): New function.
4573         (frame_cmd_list): New variable.
4574         (_initialize_stack): Update to setup the new commands 'frame apply'
4575         and 'faas'.
4576
4577 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4578
4579         * cli-utils.c (number_or_range_parser::get_number): Only handle
4580         numbers or convenience var as numbers.
4581         (parse_flags): New function.
4582         (parse_flags_qcs): New function.
4583         (number_or_range_parser::finished): Ensure parsing end is detected
4584         before end of string.
4585         * cli-utils.h (parse_flags): New function.
4586         (parse_flags_qcs): New function.
4587         (number_or_range_parser): Remove m_finished bool.
4588         (number_or_range_parser::skip_range): Set m_in_range to false.
4589
4590 2018-07-12  Sergio Durigan Junior  <sergiodj@redhat.com>
4591
4592         * ser-tcp.c (try_connect): Declare 'ioarg' as 'u_long' if building
4593         on Windows.
4594
4595 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
4596             Jan Kratochvil  <jan.kratochvil@redhat.com>
4597             Paul Fertser  <fercerpav@gmail.com>
4598             Tsutomu Seki  <sekiriki@gmail.com>
4599             Pedro Alves  <palves@redhat.com>
4600
4601         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4602         'unittests/parse-connection-spec-selftests.c'.
4603         (COMMON_SFILES): Add 'common/netstuff.c'.
4604         (HFILES_NO_SRCDIR): Add 'common/netstuff.h'.
4605         * NEWS (Changes since GDB 8.2): Mention IPv6 support.
4606         * common/netstuff.c: New file.
4607         * common/netstuff.h: New file.
4608         * ser-tcp.c: Include 'netstuff.h' and 'wspiapi.h'.
4609         (wait_for_connect): Update comment.  New parameter
4610         'gdb::optional<int> sock' instead of 'struct serial *scb'.
4611         Use 'sock' directly instead of 'scb->fd'.
4612         (try_connect): New function, with code from 'net_open'.
4613         (net_open): Rewrite main loop to deal with multiple
4614         sockets/addresses.  Handle IPv6-style hostnames; implement
4615         support for IPv6 connections.
4616         * unittests/parse-connection-spec-selftests.c: New file.
4617
4618 2018-07-11  Pedro Alves  <palves@redhat.com>
4619
4620         PR gdb/23377
4621         * remote.c (remote_target::remote_detach_pid): Call
4622         set_current_process.
4623
4624 2018-07-11  Pedro Alves  <palves@redhat.com>
4625
4626         * h8300-tdep.c (h8300_gdbarch_init): Remove
4627         set_gdbarch_ecoff_reg_to_regnum calls.
4628
4629 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
4630
4631         PR c++/23373
4632         * c-typeprint.c (c_type_print_base_struct_union): Don't print
4633         offsets/sizes for static members of a class/struct.
4634
4635 2018-07-11  Alan Hayward  <alan.hayward@arm.com>
4636
4637         * target-descriptions.c (tdesc_register_bitsize): Rename.
4638         * target-descriptions.h (tdesc_register_bitsize): Likewise.
4639         * rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
4640         * aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.
4641
4642 2018-07-10  Tom Tromey  <tom@tromey.com>
4643
4644         * breakpoint.c (moribund_locations): Now static and a
4645         std::vector.
4646         (breakpoint_init_inferior, moribund_breakpoint_here_p)
4647         (build_bpstat_chain, update_global_location_list)
4648         (breakpoint_retire_moribund): Update.
4649         * breakpoint.h (bp_location_p): Remove typedef.  Don't declare
4650         VEC.
4651
4652 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4653
4654         * riscv-tdep.c (riscv_is_fp_regno_p): New function.
4655         (riscv_register_reggroup_p): Use new function, remove unneeded
4656         parenthesis.
4657         (riscv_push_dummy_call): Extend assert to compare against xlen or
4658         flen based on register type.
4659
4660 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * riscv-tdep.c (riscv_print_arg_location): Use TYPE_SAFE_NAME.
4663
4664 2018-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * remote.c (show_hardware_watchpoint_limit): New function.
4667         (show_hardware_watchpoint_length_limit): New function.
4668         (show_hardware_breakpoint_limit): New function.
4669         (_initialize_remote): Use add_setshow_zuinteger_unlimited_cmd
4670         where appropriate, update help text.
4671
4672 2018-07-09  Tom Tromey  <tom@tromey.com>
4673
4674         * Makefile.in (CDEPS): Don't mention XM_CDEPS.
4675         (CLIBS): Don't mention NAT_CLIBS.
4676
4677 2018-07-09  Tom Tromey  <tom@tromey.com>
4678
4679         * Makefile.in (ADD_FILES, ADD_DEPS): Remove.
4680         (LIBGDB_OBS, clean mostlyclean): Update.
4681         (gdb$(EXEEXT), insight$(EXEEXT)): Update.
4682
4683 2018-07-09  Tom Tromey  <tom@tromey.com>
4684
4685         * Makefile.in (%.c: %.y): Use ECHO_YACC.
4686         (%.c: %.l): Use ECHO_LEX.  Just fail if flex not available.
4687         * silent-rules.mk (ECHO_YACC, ECHO_LEX): New variables.
4688
4689 2018-07-09  Tom Tromey  <tom@tromey.com>
4690
4691         * Makefile.in (ALLDEPFILES): Remove exec.c.
4692         (COMMON_OBS): Remove exec.o.
4693         (COMMON_SFILES): Add exec.c.
4694
4695 2018-07-09  Tom Tromey  <tom@tromey.com>
4696
4697         * Makefile.in (LINT, LINTFLAGS, LINTFILES, lint): Remove.
4698
4699 2018-07-09  Tom Tromey  <tom@tromey.com>
4700
4701         * Makefile.in (clean mostlyclean): Remove stamp-version.
4702         (version.c): Depend on stamp-version.
4703         (stamp-version): New rule, from version.c rule.
4704
4705 2018-07-09  Tom Tromey  <tom@tromey.com>
4706
4707         * Makefile.in (init.c): Depend on stamp-init.
4708         (stamp-init): New rule, from init.c rule.
4709         (clean mostlyclean): Remove stamp-init.
4710
4711 2018-07-09  Tom Tromey  <tom@tromey.com>
4712
4713         * Makefile.in (INIT_FILES): Remove CONFIG_SRCS,
4714         SUBDIR_GCC_COMPILE_SRCS.
4715
4716 2018-07-09  Tom Tromey  <tom@tromey.com>
4717
4718         * Makefile.in (init.c): Remove some unused sed rules.
4719
4720 2018-07-09  Tom Tromey  <tom@tromey.com>
4721
4722         * Makefile.in (TSOBS): Remove.
4723         (INIT_FILES): Update.
4724         (LIBGDB_OBS): Update.
4725         (COMMON_SFILES): Add inflow.c.
4726         (SFILES): Remove inflow.c.
4727
4728 2018-07-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
4729
4730         * contrib/gdb-add-index.sh ($dwarf5): New, use it.
4731
4732 2018-07-07  Simon Marchi  <simon.marchi@polymtl.ca>
4733
4734         * ia64-libunwind-tdep.c (get_reg_name, get_fpreg_name,
4735         get_saveloc_name, is_signal_frame_name, step_name,
4736         init_remote_name, create_addr_space_name,
4737         destroy_addr_space_name, search_unwind_table_name,
4738         find_dyn_list_name): Constify.
4739
4740 2018-07-05  Simon Marchi  <simon.marchi@polymtl.ca>
4741
4742         * darwin-nat.c (darwin_pthread_kill): New function.
4743         (darwin_resume_thread): Use darwin_pthread_kill.
4744
4745 2018-07-05  Tom de Vries  <tdevries@suse.de>
4746
4747         * macroexp.c (macro_buffer) <operator=>: New member function.
4748
4749 2018-07-04  Tom Tromey  <tom@tromey.com>
4750
4751         * darwin-nat.c (darwin_attach_pid): Use exit_inferior.
4752
4753 2018-07-04  Simon Marchi  <simon.marchi@polymtl.ca>
4754
4755         * common/common-defs.h (HAVE_USEFUL_SBRK): Define.
4756         * main.c: Use HAVE_USEFUL_SBRK instead of HAVE_SBRK.
4757         * maint.c: Likewise.
4758         * top.c: Likewise.
4759
4760 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
4761
4762         * NEWS: Create a new section for the next release branch.
4763         Rename the section of the current branch, now that it has
4764         been cut.
4765
4766 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
4767
4768         GDB 8.2 branch created (1b919490e8ba30bf1d6941df0ed112b0e557017e):
4769         * version.in: Bump version to 8.2.50.DATE-git.
4770
4771 2018-07-04  Vyacheslav Barinov  <v.barinov@samsung.com>
4772             Pedro Alves  <palves@redhat.com>
4773
4774         * linux-nat.c (linux_init_ptrace): Rename to ...
4775         (linux_init_ptrace_procfs): ... this.  Call
4776         linux_proc_init_warnings.
4777         (linux_nat_target::post_attach)
4778         (linux_nat_target::post_startup_inferior): Adjust.
4779         * nat/linux-procfs.c (linux_proc_init_warnings): Define function.
4780         * nat/linux-procfs.h (linux_proc_init_warnings): Declare function.
4781
4782 2018-07-04  Tom de Vries  <tdevries@suse.de>
4783
4784         * dwarf2read.c (error_check_comp_unit_head): Move dwarf version
4785         check ...
4786         (read_comp_unit_head): ... here.
4787
4788 2018-07-03  Tom Tromey  <tom@tromey.com>
4789
4790         * tracepoint.c (process_tracepoint_on_disconnect, start_tracing)
4791         (stop_tracing, tstatus_command)
4792         (find_matching_tracepoint_location, merge_uploaded_tracepoints)
4793         (print_one_static_tracepoint_marker): Update.
4794         * breakpoint.c (static_tracepoints_here, all_tracepoints): Return
4795         std::vector.
4796         * breakpoint.h (breakpoint_p): Remove typedef.  Don't declare
4797         VEC.
4798         (all_tracepoints, static_tracepoints_here): Return std::vector.
4799
4800 2018-07-03  Tom Tromey  <tom@tromey.com>
4801
4802         * common/ptid.c (ptid_equal): Remove.
4803         * common/ptid.h (ptid_equal): Don't declare.
4804         * ada-tasks.c: Update.
4805         * breakpoint.c: Update.
4806         * common/agent.c: Update.
4807         * corelow.c: Update.
4808         * darwin-nat-info.c: Update.
4809         * darwin-nat.c: Update.
4810         * dcache.c: Update.
4811         * dtrace-probe.c: Update.
4812         * dummy-frame.c: Update.
4813         * fbsd-nat.c: Update.
4814         * frame.c: Update.
4815         * gdbthread.h: Update.
4816         * gnu-nat.c: Update.
4817         * go32-nat.c: Update.
4818         * inf-loop.c: Update.
4819         * inf-ptrace.c: Update.
4820         * infcall.c: Update.
4821         * infcmd.c: Update.
4822         * inflow.c: Update.
4823         * infrun.c: Update.
4824         * linux-fork.c: Update.
4825         * linux-nat.c: Update.
4826         * linux-thread-db.c: Update.
4827         * mi/mi-cmd-var.c: Update.
4828         * mi/mi-interp.c: Update.
4829         * mi/mi-main.c: Update.
4830         * nto-procfs.c: Update.
4831         * ppc-linux-tdep.c: Update.
4832         * procfs.c: Update.
4833         * python/py-inferior.c: Update.
4834         * python/py-record-btrace.c: Update.
4835         * python/py-record.c: Update.
4836         * ravenscar-thread.c: Update.
4837         * regcache.c: Update.
4838         * remote-sim.c: Update.
4839         * remote.c: Update.
4840         * sol-thread.c: Update.
4841         * solib.c: Update.
4842         * target.c: Update.
4843         * tui/tui-stack.c: Update.
4844         * varobj.c: Update.
4845         * windows-nat.c: Update.
4846         * windows-tdep.c: Update.
4847
4848 2018-07-03  Tom Tromey  <tom@tromey.com>
4849
4850         * common/ptid.c (ptid_match): Remove.
4851         * common/ptid.h (ptid_match): Don't declare.
4852         * fbsd-nat.c: Update.
4853         * infcmd.c: Update.
4854         * infrun.c: Update.
4855         * linux-nat.c: Update.
4856         * record-btrace.c: Update.
4857         * regcache.c: Update.
4858         * remote.c: Update.
4859
4860 2018-07-03  Tom Tromey  <tom@tromey.com>
4861
4862         * common/ptid.c (ptid_tid_p): Remove.
4863         * common/ptid.h (ptid_tid_p): Don't declare.
4864         * sol-thread.c: Update.
4865
4866 2018-07-03  Tom Tromey  <tom@tromey.com>
4867
4868         * common/ptid.c (ptid_lwp_p): Remove.
4869         * common/ptid.h (ptid_lwp_p): Don't declare.
4870         * fbsd-nat.c: Update.
4871         * linux-nat.c: Update.
4872         * nat/linux-procfs.c: Update.
4873         * nat/x86-linux-dregs.c: Update.
4874         * sol-thread.c: Update.
4875
4876 2018-07-03  Tom Tromey  <tom@tromey.com>
4877
4878         * common/ptid.c (ptid_is_pid): Remove.
4879         * common/ptid.h (ptid_is_pid): Don't declare.
4880         * infrun.c: Update.
4881         * linux-nat.c: Update.
4882         * mi/mi-interp.c: Update.
4883         * remote.c: Update.
4884         * thread.c: Update.
4885
4886 2018-07-03  Tom Tromey  <tom@tromey.com>
4887
4888         * common/ptid.c (ptid_get_tid): Remove.
4889         * common/ptid.h (ptid_get_tid): Don't declare.
4890         * ada-tasks.c: Update.
4891         * aix-thread.c: Update.
4892         * bsd-uthread.c: Update.
4893         * darwin-nat.c: Update.
4894         * fbsd-nat.c: Update.
4895         * i386-darwin-nat.c: Update.
4896         * infrun.c: Update.
4897         * linux-tdep.c: Update.
4898         * nto-procfs.c: Update.
4899         * ppc-ravenscar-thread.c: Update.
4900         * python/py-infthread.c: Update.
4901         * ravenscar-thread.c: Update.
4902         * sol-thread.c: Update.
4903         * sparc-ravenscar-thread.c: Update.
4904         * windows-nat.c: Update.
4905
4906 2018-07-03  Tom Tromey  <tom@tromey.com>
4907
4908         * common/ptid.c (ptid_get_lwp): Remove.
4909         * common/ptid.h (ptid_get_lwp): Don't declare.
4910         * aarch64-linux-nat.c: Update.
4911         * ada-tasks.c: Update.
4912         * aix-thread.c: Update.
4913         * amd64-linux-nat.c: Update.
4914         * arm-linux-nat.c: Update.
4915         * corelow.c: Update.
4916         * fbsd-nat.c: Update.
4917         * fbsd-tdep.c: Update.
4918         * gnu-nat.c: Update.
4919         * i386-cygwin-tdep.c: Update.
4920         * i386-gnu-nat.c: Update.
4921         * i386-linux-nat.c: Update.
4922         * ia64-linux-nat.c: Update.
4923         * inf-ptrace.c: Update.
4924         * infrun.c: Update.
4925         * linux-fork.c: Update.
4926         * linux-nat.c: Update.
4927         * linux-tdep.c: Update.
4928         * linux-thread-db.c: Update.
4929         * mips-linux-nat.c: Update.
4930         * nat/aarch64-linux-hw-point.c: Update.
4931         * nat/aarch64-linux.c: Update.
4932         * nat/linux-btrace.c: Update.
4933         * nat/linux-osdata.c: Update.
4934         * nat/linux-procfs.c: Update.
4935         * nat/x86-linux-dregs.c: Update.
4936         * obsd-nat.c: Update.
4937         * ppc-fbsd-nat.c: Update.
4938         * ppc-linux-nat.c: Update.
4939         * procfs.c: Update.
4940         * python/py-infthread.c: Update.
4941         * ravenscar-thread.c: Update.
4942         * remote.c: Update.
4943         * s390-linux-nat.c: Update.
4944         * sol-thread.c: Update.
4945         * sol2-tdep.c: Update.
4946         * spu-linux-nat.c: Update.
4947         * x86-linux-nat.c: Update.
4948         * xtensa-linux-nat.c: Update.
4949
4950 2018-07-03  Tom Tromey  <tom@tromey.com>
4951
4952         * common/ptid.c (ptid_get_pid): Remove.
4953         * common/ptid.h (ptid_get_pid): Don't declare.
4954         * aarch64-linux-nat.c: Update.
4955         * ada-lang.c: Update.
4956         * aix-thread.c: Update.
4957         * alpha-bsd-nat.c: Update.
4958         * amd64-fbsd-nat.c: Update.
4959         * amd64-linux-nat.c: Update.
4960         * arm-linux-nat.c: Update.
4961         * arm-nbsd-nat.c: Update.
4962         * auxv.c: Update.
4963         * break-catch-syscall.c: Update.
4964         * breakpoint.c: Update.
4965         * bsd-uthread.c: Update.
4966         * corelow.c: Update.
4967         * ctf.c: Update.
4968         * darwin-nat.c: Update.
4969         * fbsd-nat.c: Update.
4970         * fbsd-tdep.c: Update.
4971         * gcore.c: Update.
4972         * gnu-nat.c: Update.
4973         * hppa-nbsd-nat.c: Update.
4974         * hppa-obsd-nat.c: Update.
4975         * i386-fbsd-nat.c: Update.
4976         * ia64-linux-nat.c: Update.
4977         * inf-ptrace.c: Update.
4978         * infcmd.c: Update.
4979         * inferior.c: Update.
4980         * inferior.h: Update.
4981         * inflow.c: Update.
4982         * infrun.c: Update.
4983         * linux-fork.c: Update.
4984         * linux-nat.c: Update.
4985         * linux-tdep.c: Update.
4986         * linux-thread-db.c: Update.
4987         * m68k-bsd-nat.c: Update.
4988         * mi/mi-interp.c: Update.
4989         * mi/mi-main.c: Update.
4990         * mips-linux-nat.c: Update.
4991         * mips-nbsd-nat.c: Update.
4992         * mips64-obsd-nat.c: Update.
4993         * nat/aarch64-linux-hw-point.c: Update.
4994         * nat/aarch64-linux.c: Update.
4995         * nat/linux-btrace.c: Update.
4996         * nat/linux-osdata.c: Update.
4997         * nat/linux-procfs.c: Update.
4998         * nat/x86-linux-dregs.c: Update.
4999         * nto-procfs.c: Update.
5000         * obsd-nat.c: Update.
5001         * ppc-linux-nat.c: Update.
5002         * ppc-nbsd-nat.c: Update.
5003         * ppc-obsd-nat.c: Update.
5004         * proc-service.c: Update.
5005         * procfs.c: Update.
5006         * python/py-inferior.c: Update.
5007         * python/py-infthread.c: Update.
5008         * ravenscar-thread.c: Update.
5009         * record.c: Update.
5010         * remote-sim.c: Update.
5011         * remote.c: Update.
5012         * rs6000-nat.c: Update.
5013         * s390-linux-nat.c: Update.
5014         * sh-nbsd-nat.c: Update.
5015         * sol-thread.c: Update.
5016         * sparc-nat.c: Update.
5017         * sparc64-tdep.c: Update.
5018         * spu-linux-nat.c: Update.
5019         * spu-tdep.c: Update.
5020         * target-debug.h: Update.
5021         * target.c: Update.
5022         * thread.c: Update.
5023         * tid-parse.c: Update.
5024         * tracefile-tfile.c: Update.
5025         * vax-bsd-nat.c: Update.
5026         * windows-nat.c: Update.
5027         * x86-linux-nat.c: Update.
5028         * x86-nat.c: Update.
5029
5030 2018-07-03  Tom Tromey  <tom@tromey.com>
5031
5032         * common/ptid.c (pid_to_ptid): Remove.
5033         * common/ptid.h (pid_to_ptid): Don't declare.
5034         * aix-thread.c: Update.
5035         * arm-linux-nat.c: Update.
5036         * common/ptid.c: Update.
5037         * common/ptid.h: Update.
5038         * corelow.c: Update.
5039         * ctf.c: Update.
5040         * darwin-nat.c: Update.
5041         * fbsd-nat.c: Update.
5042         * fork-child.c: Update.
5043         * gnu-nat.c: Update.
5044         * go32-nat.c: Update.
5045         * inf-ptrace.c: Update.
5046         * infcmd.c: Update.
5047         * inferior.c: Update.
5048         * infrun.c: Update.
5049         * linux-fork.c: Update.
5050         * linux-nat.c: Update.
5051         * nat/aarch64-linux-hw-point.c: Update.
5052         * nat/fork-inferior.c: Update.
5053         * nat/x86-linux-dregs.c: Update.
5054         * nto-procfs.c: Update.
5055         * obsd-nat.c: Update.
5056         * procfs.c: Update.
5057         * progspace.c: Update.
5058         * remote.c: Update.
5059         * rs6000-nat.c: Update.
5060         * s390-linux-nat.c: Update.
5061         * sol-thread.c: Update.
5062         * spu-linux-nat.c: Update.
5063         * target.c: Update.
5064         * top.c: Update.
5065         * tracefile-tfile.c: Update.
5066         * windows-nat.c: Update.
5067
5068 2018-07-03  Tom Tromey  <tom@tromey.com>
5069
5070         * common/ptid.h (ptid_build): Don't declare.
5071         * common/ptid.c (ptid_build): Remove.
5072         * aix-thread.c: Update.
5073         * bsd-kvm.c: Update.
5074         * bsd-uthread.c: Update.
5075         * common/agent.c: Update.
5076         * common/ptid.c: Update.
5077         * common/ptid.h: Update.
5078         * corelow.c: Update.
5079         * darwin-nat.c: Update.
5080         * fbsd-nat.c: Update.
5081         * gnu-nat.c: Update.
5082         * linux-fork.c: Update.
5083         * linux-nat.c: Update.
5084         * linux-thread-db.c: Update.
5085         * nat/linux-osdata.c: Update.
5086         * nat/linux-procfs.c: Update.
5087         * nto-procfs.c: Update.
5088         * obsd-nat.c: Update.
5089         * proc-service.c: Update.
5090         * procfs.c: Update.
5091         * ravenscar-thread.c: Update.
5092         * remote-sim.c: Update.
5093         * remote.c: Update.
5094         * sol-thread.c: Update.
5095         * target.c: Update.
5096         * windows-nat.c: Update.
5097
5098 2018-07-03  Tom Tromey  <tom@tromey.com>
5099
5100         * infrun.c (follow_exec): Use exit_inferior_silent.
5101         * inferior.c (exit_inferior_num_silent): Remove.
5102         * inferior.h (exit_inferior_num_silent): Don't declare.
5103
5104 2018-07-03  Tom Tromey  <tom@tromey.com>
5105
5106         PR cli/23340:
5107         * darwin-nat.c (darwin_attach_pid): Reset inferior and
5108         inferior_ptid on error.
5109
5110 2018-07-02  Maciej W. Rozycki  <macro@mips.com>
5111             Simon Marchi  <simon.marchi@polymtl.ca>
5112
5113         PR tdep/8282
5114         * disasm.h (gdb_disassembler): Add
5115         `m_disassembler_options_holder'. member
5116         * disasm.c (get_all_disassembler_options): New function.
5117         (gdb_disassembler::gdb_disassembler): Use it.
5118         (gdb_buffered_insn_length_init_dis): Likewise.
5119         (gdb_buffered_insn_length): Adjust accordingly.
5120         (set_disassembler_options): Handle options with arguments.
5121         (show_disassembler_options_sfunc): Likewise.  Add a leading new
5122         line if showing options with descriptions.
5123         (disassembler_options_completer): Adapt to using the
5124         `disasm_options_and_args_t' structure.
5125         * mips-tdep.c (mips_disassembler_options): New variable.
5126         (mips_disassembler_options_o32): Likewise.
5127         (mips_disassembler_options_n32): Likewise.
5128         (mips_disassembler_options_n64): Likewise.
5129         (gdb_print_insn_mips): Don't set `disassembler_options'.
5130         (gdb_print_insn_mips_n32, gdb_print_insn_mips_n64): Remove
5131         functions.
5132         (mips_gdbarch_init): Always set `gdbarch_print_insn' to
5133         `gdb_print_insn_mips'.  Set `gdbarch_disassembler_options',
5134         `gdbarch_disassembler_options_implicit' and
5135         `gdbarch_valid_disassembler_options'.
5136         * arm-tdep.c (_initialize_arm_tdep): Adapt to using the
5137         `disasm_options_and_args_t' structure.
5138         * gdbarch.sh (disassembler_options_implicit): New `gdbarch'
5139         method.
5140         (valid_disassembler_options): Switch from `disasm_options_t' to
5141         the `disasm_options_and_args_t' structure.
5142         * NEWS: Document `set disassembler-options' support for the MIPS
5143         target.
5144         * gdbarch.h: Regenerate.
5145         * gdbarch.c: Regenerate.
5146
5147 2018-07-02  Sebastian Huber  <sebastian.huber@embedded-brains.de>
5148
5149         * riscv-tdep.c (riscv_register_aliases): Swap "fp" and "s0" entries.
5150
5151 2018-06-29  Joel Brobecker  <brobecker@adacore.com>
5152
5153         * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
5154         parameter in call to amd64_target_description.
5155         * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
5156         * amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
5157         (amd64fbsd_init_abi): Likewise.
5158         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
5159         * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
5160         * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
5161         * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
5162
5163 2018-06-29  Pedro Alves  <palves@redhat.com>
5164
5165         * gdb/amd64-tdep.h (amd64_create_target_description): Add
5166         "segments" parameter.
5167         * gdb/amd64-tdep.c (amd64_none_init_abi, amd64_x32_none_init_abi)
5168         (_initialize_amd64_tdep): Update call to
5169         amd64_create_target_description.
5170         (amd64_target_description): Add "segments" parameter.  Adjust
5171         the implementation to use it.
5172         * gdb/amd64-linux-tdep.c (amd64_linux_read_description): Update
5173         call to amd64_create_target_description.
5174         * gdb/amd64-windows-tdep.c (amd64_windows_init_abi): Likewise.
5175         * gdb/arch/amd64.h (amd64_create_target_description): Add
5176         "segments" register.
5177         * gdb/arch/amd64.c (amd64_create_target_description): Add
5178         "segments" parameter.  Call create_feature_i386_64bit_segments
5179         only if SEGMENTS is true.
5180         * gdb/gdbserver/win32-i386-low.c (i386_arch_setup): Update
5181         call to amd64_create_target_description.
5182
5183 2018-06-29  Pedro Alves  <palves@redhat.com>
5184
5185         * thread.c (thread_target_id_str): New, factored out from ...
5186         (print_thread_info_1): ... here.  Use it to compute the max
5187         "Target Id" column width.
5188
5189 2018-06-29  Pedro Alves  <palves@redhat.com>
5190
5191         * remote.c (remote_target::extra_thread_info): Delete
5192         'display_buf' and 'n' locals.  from the cache, regardless of
5193         packet mechanims is in use.  Use cache for qThreadExtra and qP
5194         methods too.
5195
5196 2018-06-29  Pedro Alves  <palves@redhat.com>
5197
5198         * blockframe.c (find_pc_sect_containing_function): New function.
5199         * breakpoint.c (print_breakpoint_location): Don't call
5200         find_pc_sect_function.
5201         * linespec.c (create_sals_line_offset): Record the location's
5202         symbol in the sal.
5203         * linespec.c (convert_address_location_to_sals): Fill in sal's
5204         symbol with find_pc_sect_containing_function.
5205         * symtab.c (find_function_start_sal): Rename to ...
5206         (find_function_start_sal_1): ... this.
5207         (find_function_start_sal): Reimplement as wrapper around
5208         find_function_start_sal_1, and use
5209         find_pc_sect_containing_function to fill in the sal's symbol.
5210         (find_function_start_sal(symbol*, bool)): Adjust.
5211         * symtab.h (find_pc_function, find_pc_sect_function): Adjust
5212         comments.
5213         (find_pc_sect_containing_function): Declare.
5214
5215 2018-06-29  Pedro Alves  <palves@redhat.com>
5216
5217         * inline-frame.c (stopped_by_user_bp_inline_frame): Return
5218         true if the the location has no symbol.
5219
5220 2018-06-28  Tom Tromey  <tom@tromey.com>
5221
5222         * NEWS: Mention --enable-codesign.
5223         * silent-rules.mk (ECHO_SIGN): New variable.
5224         * configure.ac: Add --enable-codesign.
5225         * configure: Rebuild.
5226         * Makefile.in (CODESIGN, CODESIGN_CERT): New variables.
5227         (gdb$(EXEEXT)): Optionally invoke codesign.
5228
5229 2018-06-28  Pedro Alves  <palves@redhat.com>
5230
5231         * gdbthread.h (struct thread_suspend_state) <stop_pc>: Extend
5232         comments.
5233         (switch_to_thread_no_regs): Adjust comment.
5234         * infcmd.c (stop_pc): Delete.
5235         (post_create_inferior, info_program_command): Replace references
5236         to stop_pc with references to thread_info->suspend.stop_pc.
5237         * inferior.h (stop_pc): Delete declaration.
5238         * infrun.c (proceed, handle_syscall_event, fill_in_stop_func)
5239         (handle_inferior_event_1, handle_signal_stop)
5240         (process_event_stop_test, keep_going_stepped_thread)
5241         (handle_step_into_function, handle_step_into_function_backward)
5242         (print_stop_location): Replace references to stop_pc with
5243         references to thread_info->suspend.stop_pc.
5244         (struct infcall_suspend_state) <stop_pc>: Delete field.
5245         (save_infcall_suspend_state, restore_infcall_suspend_state):
5246         Remove references to inf_stat->stop_pc.
5247         * linux-fork.c (fork_load_infrun_state): Likewise.
5248         * record-btrace.c (record_btrace_set_replay): Likewise.
5249         * record-full.c (record_full_goto_entry): Likewise.
5250         * remote.c (print_one_stopped_thread): Likewise.
5251         * target.c (target_resume): Extend comment.
5252         * thread.c (set_executing_thread): New.
5253         (set_executing): Use it.
5254         (switch_to_thread_no_regs, switch_to_no_thread, switch_to_thread):
5255         Remove references to stop_pc.
5256
5257 2018-06-28  Pedro Alves  <palves@redhat.com>
5258
5259         * infrun.c (handle_inferior_event_1) <TARGET_WAITKIND_EXECD>:
5260         Moving fetching stop_pc until after ecs->event_thread is refreshed.
5261
5262 2018-06-28  Tom Tromey  <tom@tromey.com>
5263
5264         * coffread.c (coff_symfile_finish): Update.
5265         * xcoffread.c (xcoff_symfile_finish): Update.
5266         * elfread.c (elf_symfile_finish): Update.
5267         * symfile.h (dwarf2_free_objfile): Don't declare.
5268         * dwarf2read.c (_initialize_dwarf2_read): Use
5269         register_objfile_data_with_cleanup.
5270         (dwarf2_free_objfile): Now static.  Change signature.
5271
5272 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
5273
5274         * symfile.c (add_symbol_file_command, _initialize_symfile): Add
5275         option "-o" to add-symbol-file-load to add an offset to each
5276         section's load address.
5277         * symfile.c (set_objfile_default_section_offset): New function.
5278
5279 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
5280
5281         * symfile.c (add_symbol_file_command): Make sure that sections
5282         with the same name are sorted in the same order.
5283
5284 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
5285
5286         * symfile.c (add_symbol_file_command, _initialize_symfile): Do not
5287         require the second argument.  If omitted, load sections at the
5288         addresses specified in the file.
5289
5290 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
5291
5292         * symfile.c (symbol_file_command, symbol_file_add_main_1)
5293         (_initialize_symfile): Add option "-o" to symbol-file to add an
5294         offset to each section of the symbol file.
5295
5296 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
5297
5298         * MAINTAINERS (Write After Approval): Add Petr Tesarik.
5299
5300 2018-06-27  Tom Tromey  <tom@tromey.com>
5301
5302         * stack.c (_initialize_stack): Update "func" help text.
5303
5304 2018-06-27  Tom Tromey  <tom@tromey.com>
5305
5306         * python/py-unwind.c (unwind_info_object) <saved_regs>: Now a
5307         std::vector.
5308         (unwind_infopy_str, pyuw_create_unwind_info)
5309         (unwind_infopy_add_saved_register, pyuw_sniffer)
5310         (unwind_infopy_dealloc, unwind_infopy_add_saved_register):
5311         Update.
5312         (struct saved_reg): Add constructor.
5313         <value>: Now a gdbpy_ref<>.
5314
5315 2018-06-27  Tom Tromey  <tom@tromey.com>
5316
5317         * machoread.c (macho_symfile_read): Define "symbol_table" earlier.
5318
5319 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
5320
5321         * gdb-gdb.py.in: Format using autopep8.
5322
5323 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
5324
5325         * gdb-gdb.py.in (CoreAddrPrettyPrinter): New class.
5326         (type_lookup_function): Recognize CORE_ADDR values.
5327
5328 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
5329
5330         * gdb-gdb.py.in (StructMainTypePrettyPrinter) <to_string>: Don't
5331         print tag_name.
5332
5333 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
5334
5335         * gdb-gdb.py.in (TypeFlag) <__cmp__>: Remove.
5336         <__lt__>: Add.
5337
5338 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
5339
5340         * gdb-gdb.py: Move to...
5341         * gdb-gdb.py.in: ... here.
5342         * configure.ac (AC_CONFIG_FILES): Add gdb-gdb.py.
5343         * Makefile.in (all): Add gdb-gdb.gdb and gdb-gdb.py as
5344         dependencies.
5345         (distclean): Remove gdb-gdb.py when cleaning.
5346         (gdb-gdb.py, gdb-gdb.gdb): New rules.
5347         * configure: Re-generate.
5348
5349 2018-06-27  Pedro Alves  <palves@redhat.com>
5350
5351         * proc-service.c (get_ps_regcache): New.
5352         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs)
5353         (ps_lsetfpregs): Use it.
5354
5355 2018-06-27  Omair Javaid  <omair.javaid@linaro.org>
5356
5357         PR gdb/21695
5358         * dwarf2read.c (lnp_state_machine::check_line_address): Update declaration.
5359         (dwarf_decode_lines_1): Adjust.
5360
5361 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
5362
5363         * fbsd-nat.h (class fbsd_nat_target) <find_memory_regions>: Add
5364         override.
5365         <info_proc>: Likewise.
5366
5367 2018-06-26  Joel Brobecker  <brobecker@adacore.com>
5368
5369         * windows-nat.c (do_windows_fetch_inferior_registers): Rename
5370         to windows_fetch_one_register, and only handle the case of
5371         fetching one register.  Move the code that reloads the context
5372         and iterates over all registers if R is negative to...
5373         (windows_nat_target::fetch_registers): ... here.
5374         (do_windows_store_inferior_registers): Rename to
5375         windows_store_one_register, and only handle the case of storing
5376         one register.  Move the code that handles the case where r is
5377         negative to...
5378         (windows_nat_target::store_registers) ... here.
5379
5380 2018-06-26  Tom Tromey  <tom@tromey.com>
5381
5382         PR rust/22574:
5383         * typeprint.c (whatis_exp): Allow ptype/o for Rust.
5384         * rust-lang.c (rust_print_struct_def): Add podata parameter.
5385         Update.
5386         (rust_internal_print_type): Add podata parameter.
5387         (rust_print_type): Update.
5388
5389 2018-06-26  Tom Tromey  <tom@tromey.com>
5390
5391         * typeprint.h (struct print_offset_data) <update, finish,
5392         maybe_print_hole>: New methods.
5393         <indentation>: New constant.
5394         * typeprint.c (print_offset_data::indentation): Define.
5395         (print_offset_data::maybe_print_hole, print_offset_data::update)
5396         (print_offset_data::finish): Move from c-typeprint.c and rename.
5397         * c-typeprint.c (OFFSET_SPC_LEN): Remove.
5398         (print_spaces_filtered_with_print_options): Update.
5399         (c_print_type_union_field_offset, maybe_print_hole)
5400         (c_print_type_struct_field_offset): Move to typeprint.c and
5401         rename.
5402         (c_type_print_base_struct_union): Update.
5403
5404 2018-06-25  Pedro Alves  <palves@redhat.com>
5405
5406         * gdbthread.h (thread_info_ref, delete_thread)
5407         (delete_thread_silent, first_thread_of_inferior)
5408         (any_thread_of_inferior, switch_to_thread)
5409         (enable_thread_stack_temporaries)
5410         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
5411         (get_last_thread_stack_temporary)
5412         (value_in_thread_stack_temporaries, can_access_registers_thread):
5413         Spell out "struct thread_info" instead of just "thread_info".
5414         * inferior.h (notice_new_inferior): Likewise.
5415
5416 2018-06-25  Pedro Alves  <palves@redhat.com>
5417
5418         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
5419         pass thread_info pointer to delete_thread.
5420         (windows_nat_target::detach): Pass inferior pointer to
5421         detach_inferior.
5422         * aix-thread.c (sync_threadlists): Pass thread_info pointer to
5423         delete_thread.
5424         * bsd-kvm.c (bsd_kvm_target::close): Use discard_all_inferiors.
5425         * darwin-nat.c (darwin_check_new_threads): Use find_thread_ptid
5426         and pass a thread_info pointer to delete_thread.
5427         * fbsd-nat.c (fbsd_nat_target::wait): Use find_thread_ptid and
5428         pass thread_info pointer to delete_thread.
5429         * go32-nat.c (go32_nat_target::mourn_inferior): Remove
5430         delete_thread_silent call.
5431         * procfs.c (procfs_target::detach): Pass inferior pointer to
5432         detach_inferior.
5433         (procfs_target::wait): Pass thread_info pointer to delete_thread.
5434         * remote-sim.c (gdbsim_target::mourn_inferior): Remove
5435         delete_thread_silent call.
5436         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
5437         pass thread_info pointer to delete_thread.
5438         (windows_nat_target::detach): Pass inferior pointer to
5439         delete_inferior.
5440
5441 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
5442
5443         * regcache.c (readable_regcache::read_part): Fix asserts.
5444         (reg_buffer::raw_collect_part): New function.
5445         (regcache::write_part): Fix asserts.
5446         (reg_buffer::raw_supply_part): New function.
5447         (regcache::transfer_regset_register): New helper function.
5448         (regcache::transfer_regset): Call new functions.
5449         (regcache_supply_regset): Use gdb_byte*.
5450         (regcache::supply_regset): Likewise.
5451         (regcache_collect_regset): Likewise.
5452         (regcache::collect_regset): Likewise.
5453         * regcache.h (reg_buffer::raw_collect_part): New declaration.
5454         (reg_buffer::raw_supply_part): Likewise.
5455         (regcache::transfer_regset_register): Likewise.
5456         (regcache::transfer_regset): Use gdb_byte*.
5457
5458 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
5459
5460         * nat/aarch64-sve-linux-ptrace.h (HAS_SVE_STATE): Use &.
5461
5462 2018-06-21  Pedro Alves  <palves@redhat.com>
5463
5464         * ada-lang.h (ada_get_task_number): Take a thread_info pointer
5465         instead of a ptid_t.  All callers adjusted.
5466         * ada-tasks.c (ada_get_task_number): Likewise.  All callers
5467         adjusted.
5468         (print_ada_task_info, display_current_task_id, task_command_1):
5469         Adjust.
5470         * breakpoint.c (watchpoint_in_thread_scope): Adjust to use
5471         inferior_thread.
5472         (breakpoint_kind): Adjust.
5473         (remove_breakpoints_pid): Rename to ...
5474         (remove_breakpoints_inf): ... this.  Adjust to take an inferior
5475         pointer.  All callers adjusted.
5476         (bpstat_clear_actions): Use inferior_thread.
5477         (get_bpstat_thread): New.
5478         (bpstat_do_actions): Use it.
5479         (bpstat_check_breakpoint_conditions, bpstat_stop_status): Adjust
5480         to take a thread_info pointer.  All callers adjusted.
5481         (set_longjmp_breakpoint_for_call_dummy, set_momentary_breakpoint)
5482         (breakpoint_re_set_thread): Use inferior_thread.
5483         * breakpoint.h (struct inferior): Forward declare.
5484         (bpstat_stop_status): Update.
5485         (remove_breakpoints_pid): Delete.
5486         (remove_breakpoints_inf): New.
5487         * bsd-uthread.c (bsd_uthread_target::wait)
5488         (bsd_uthread_target::update_thread_list): Use find_thread_ptid.
5489         * btrace.c (btrace_add_pc, btrace_enable, btrace_fetch)
5490         (maint_btrace_packet_history_cmd)
5491         (maint_btrace_clear_packet_history_cmd): Adjust.
5492         (maint_btrace_clear_cmd, maint_info_btrace_cmd): Adjust to use
5493         inferior_thread.
5494         * cli/cli-interp.c: Include "inferior.h".
5495         * common/refcounted-object.h (struct
5496         refcounted_object_ref_policy): New.
5497         * compile/compile-object-load.c: Include gdbthread.h.
5498         (store_regs): Use inferior_thread.
5499         * corelow.c (core_target::close): Use current_inferior.
5500         (core_target_open): Adjust to use first_thread_of_inferior and use
5501         the current inferior.
5502         * ctf.c (ctf_target::close): Adjust to use current_inferior.
5503         * dummy-frame.c (dummy_frame_id) <ptid>: Delete, replaced by ...
5504         <thread>: ... this new field.  All references adjusted.
5505         (dummy_frame_pop, dummy_frame_discard, register_dummy_frame_dtor):
5506         Take a thread_info pointer instead of a ptid_t.
5507         * dummy-frame.h (dummy_frame_push, dummy_frame_pop)
5508         (dummy_frame_discard, register_dummy_frame_dtor): Take a
5509         thread_info pointer instead of a ptid_t.
5510         * elfread.c: Include "inferior.h".
5511         (elf_gnu_ifunc_resolver_stop, elf_gnu_ifunc_resolver_return_stop):
5512         Use inferior_thread.
5513         * eval.c (evaluate_subexp): Likewise.
5514         * frame.c (frame_pop, has_stack_frames, find_frame_sal): Use
5515         inferior_thread.
5516         * gdb_proc_service.h (struct thread_info): Forward declare.
5517         (struct ps_prochandle) <ptid>: Delete, replaced by ...
5518         <thread>: ... this new field.  All references adjusted.
5519         * gdbarch.h, gdbarch.c: Regenerate.
5520         * gdbarch.sh (get_syscall_number): Replace 'ptid' parameter with a
5521         'thread' parameter.  All implementations and callers adjusted.
5522         * gdbthread.h (thread_info) <set_running>: New method.
5523         (delete_thread, delete_thread_silent): Take a thread_info pointer
5524         instead of a ptid.
5525         (global_thread_id_to_ptid, ptid_to_global_thread_id): Delete.
5526         (first_thread_of_process): Delete, replaced by ...
5527         (first_thread_of_inferior): ... this new function.  All callers
5528         adjusted.
5529         (any_live_thread_of_process): Delete, replaced by ...
5530         (any_live_thread_of_inferior): ... this new function.  All callers
5531         adjusted.
5532         (switch_to_thread, switch_to_no_thread): Declare.
5533         (is_executing): Delete.
5534         (enable_thread_stack_temporaries): Update comment.
5535         <enable_thread_stack_temporaries>: Take a thread_info pointer
5536         instead of a ptid_t.  Incref the thread.
5537         <~enable_thread_stack_temporaries>: Decref the thread.
5538         <m_ptid>: Delete
5539         <m_thr>: New.
5540         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
5541         (get_last_thread_stack_temporary)
5542         (value_in_thread_stack_temporaries, can_access_registers_thread):
5543         Take a thread_info pointer instead of a ptid_t.  All callers
5544         adjusted.
5545         * infcall.c (get_call_return_value): Use inferior_thread.
5546         (run_inferior_call): Work with thread pointers instead of ptid_t.
5547         (call_function_by_hand_dummy): Work with thread pointers instead
5548         of ptid_t.  Use thread_info_ref.
5549         * infcmd.c (proceed_thread_callback): Access thread's state
5550         directly.
5551         (ensure_valid_thread, ensure_not_running): Use inferior_thread,
5552         access thread's state directly.
5553         (continue_command): Use inferior_thread.
5554         (info_program_command): Use find_thread_ptid and access thread
5555         state directly.
5556         (proceed_after_attach_callback): Use thread state directly.
5557         (notice_new_inferior): Take a thread_info pointer instead of a
5558         ptid_t.  All callers adjusted.
5559         (exit_inferior): Take an inferior pointer instead of a pid.  All
5560         callers adjusted.
5561         (exit_inferior_silent): New.
5562         (detach_inferior): Delete.
5563         (valid_gdb_inferior_id, pid_to_gdb_inferior_id)
5564         (gdb_inferior_id_to_pid, in_inferior_list): Delete.
5565         (detach_inferior_command, kill_inferior_command): Use
5566         find_inferior_id instead of valid_gdb_inferior_id and
5567         gdb_inferior_id_to_pid.
5568         (inferior_command): Use inferior and thread pointers.
5569         * inferior.h (struct thread_info): Forward declare.
5570         (notice_new_inferior): Take a thread_info pointer instead of a
5571         ptid_t.  All callers adjusted.
5572         (detach_inferior): Delete declaration.
5573         (exit_inferior, exit_inferior_silent): Take an inferior pointer
5574         instead of a pid.  All callers adjusted.
5575         (gdb_inferior_id_to_pid, pid_to_gdb_inferior_id, in_inferior_list)
5576         (valid_gdb_inferior_id): Delete.
5577         * infrun.c (follow_fork_inferior, proceed_after_vfork_done)
5578         (handle_vfork_child_exec_or_exit, follow_exec): Adjust.
5579         (struct displaced_step_inferior_state) <pid>: Delete, replaced by
5580         ...
5581         <inf>: ... this new field.
5582         <step_ptid>: Delete, replaced by ...
5583         <step_thread>: ... this new field.
5584         (get_displaced_stepping_state): Take an inferior pointer instead
5585         of a pid.  All callers adjusted.
5586         (displaced_step_in_progress_any_inferior): Adjust.
5587         (displaced_step_in_progress_thread): Take a thread pointer instead
5588         of a ptid_t.  All callers adjusted.
5589         (displaced_step_in_progress, add_displaced_stepping_state): Take
5590         an inferior pointer instead of a pid.  All callers adjusted.
5591         (get_displaced_step_closure_by_addr): Adjust.
5592         (remove_displaced_stepping_state): Take an inferior pointer
5593         instead of a pid.  All callers adjusted.
5594         (displaced_step_prepare_throw, displaced_step_prepare)
5595         (displaced_step_fixup): Take a thread pointer instead of a ptid_t.
5596         All callers adjusted.
5597         (start_step_over): Adjust.
5598         (infrun_thread_ptid_changed): Remove bit updating ptids in the
5599         displaced step queue.
5600         (do_target_resume): Adjust.
5601         (fetch_inferior_event): Use inferior_thread.
5602         (context_switch, get_inferior_stop_soon): Take an
5603         execution_control_state pointer instead of a ptid_t.  All callers
5604         adjusted.
5605         (switch_to_thread_cleanup): Delete.
5606         (stop_all_threads): Use scoped_restore_current_thread.
5607         * inline-frame.c: Include "gdbthread.h".
5608         (inline_state) <inline_state>: Take a thread pointer instead of a
5609         ptid_t.  All callers adjusted.
5610         <ptid>: Delete, replaced by ...
5611         <thread>: ... this new field.
5612         (find_inline_frame_state): Take a thread pointer instead of a
5613         ptid_t.  All callers adjusted.
5614         (skip_inline_frames, step_into_inline_frame)
5615         (inline_skipped_frames, inline_skipped_symbol): Take a thread
5616         pointer instead of a ptid_t.  All callers adjusted.
5617         * inline-frame.h (skip_inline_frames, step_into_inline_frame)
5618         (inline_skipped_frames, inline_skipped_symbol): Likewise.
5619         * linux-fork.c (delete_checkpoint_command): Adjust to use thread
5620         pointers directly.
5621         * linux-nat.c (get_detach_signal): Likewise.
5622         * linux-thread-db.c (thread_from_lwp): New 'stopped' parameter.
5623         (thread_db_notice_clone): Adjust.
5624         (thread_db_find_new_threads_silently)
5625         (thread_db_find_new_threads_2, thread_db_find_new_threads_1): Take
5626         a thread pointer instead of a ptid_t.  All callers adjusted.
5627         * mi/mi-cmd-var.c: Include "inferior.h".
5628         (mi_cmd_var_update_iter): Update to use thread pointers.
5629         * mi/mi-interp.c (mi_new_thread): Update to use the thread's
5630         inferior directly.
5631         (mi_output_running_pid, mi_inferior_count): Delete, bits factored
5632         out to ...
5633         (mi_output_running): ... this new function.
5634         (mi_on_resume_1): Adjust to use it.
5635         (mi_user_selected_context_changed): Adjust to use inferior_thread.
5636         * mi/mi-main.c (proceed_thread): Adjust to use thread pointers
5637         directly.
5638         (interrupt_thread_callback): : Adjust to use thread and inferior
5639         pointers.
5640         * proc-service.c: Include "gdbthread.h".
5641         (ps_pglobal_lookup): Adjust to use the thread's inferior directly.
5642         * progspace-and-thread.c: Include "inferior.h".
5643         * progspace.c: Include "inferior.h".
5644         * python/py-exitedevent.c (create_exited_event_object): Adjust to
5645         hold a reference to an inferior_object.
5646         * python/py-finishbreakpoint.c (bpfinishpy_init): Adjust to use
5647         inferior_thread.
5648         * python/py-inferior.c (struct inferior_object): Give the type a
5649         tag name instead of a typedef.
5650         (python_on_normal_stop): No need to check if the current thread is
5651         listed.
5652         (inferior_to_inferior_object): Change return type to
5653         inferior_object.  All callers adjusted.
5654         (find_thread_object): Delete, bits factored out to ...
5655         (thread_to_thread_object): ... this new function.
5656         * python/py-infthread.c (create_thread_object): Use
5657         inferior_to_inferior_object.
5658         (thpy_is_stopped): Use thread pointer directly.
5659         (gdbpy_selected_thread): Use inferior_thread.
5660         * python/py-record-btrace.c (btpy_list_object) <ptid>: Delete
5661         field, replaced with ...
5662         <thread>: ... this new field.  All users adjusted.
5663         (btpy_insn_or_gap_new): Drop const.
5664         (btpy_list_new): Take a thread pointer instead of a ptid_t.  All
5665         callers adjusted.
5666         * python/py-record.c: Include "gdbthread.h".
5667         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
5668         a ptid_t.  All callers adjusted.
5669         (gdbpy_current_recording): Use inferior_thread.
5670         * python/py-record.h (recpy_record_object) <ptid>: Delete
5671         field, replaced with ...
5672         <thread>: ... this new field.  All users adjusted.
5673         (recpy_element_object) <ptid>: Delete
5674         field, replaced with ...
5675         <thread>: ... this new field.  All users adjusted.
5676         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
5677         a ptid_t.  All callers adjusted.
5678         * python/py-threadevent.c: Include "gdbthread.h".
5679         (get_event_thread): Use thread_to_thread_object.
5680         * python/python-internal.h (struct inferior_object): Forward
5681         declare.
5682         (find_thread_object, find_inferior_object): Delete declarations.
5683         (thread_to_thread_object, inferior_to_inferior_object): New
5684         declarations.
5685         * record-btrace.c: Include "inferior.h".
5686         (require_btrace_thread): Use inferior_thread.
5687         (record_btrace_frame_sniffer)
5688         (record_btrace_tailcall_frame_sniffer): Use inferior_thread.
5689         (get_thread_current_frame): Use scoped_restore_current_thread and
5690         switch_to_thread.
5691         (get_thread_current_frame): Use thread pointer directly.
5692         (record_btrace_replay_at_breakpoint): Use thread's inferior
5693         pointer directly.
5694         * record-full.c: Include "inferior.h".
5695         * regcache.c: Include "gdbthread.h".
5696         (get_thread_arch_regcache): Use the inferior's address space
5697         directly.
5698         (get_thread_regcache, registers_changed_thread): New.
5699         * regcache.h (get_thread_regcache(thread_info *thread)): New
5700         overload.
5701         (registers_changed_thread): New.
5702         (remote_target) <remote_detach_1>: Swap order of parameters.
5703         (remote_add_thread): <remote_add_thread>: Return the new thread.
5704         (get_remote_thread_info(ptid_t)): New overload.
5705         (remote_target::remote_notice_new_inferior): Use thread pointers
5706         directly.
5707         (remote_target::process_initial_stop_replies): Use
5708         thread_info::set_running.
5709         (remote_target::remote_detach_1, remote_target::detach)
5710         (extended_remote_target::detach): Adjust.
5711         * stack.c (frame_show_address): Use inferior_thread.
5712         * target-debug.h (target_debug_print_thread_info_pp): New.
5713         * target-delegates.c: Regenerate.
5714         * target.c (default_thread_address_space): Delete.
5715         (memory_xfer_partial_1): Use current_inferior.
5716         (target_detach): Use current_inferior.
5717         (target_thread_address_space): Delete.
5718         (generic_mourn_inferior): Use current_inferior.
5719         * target.h (struct target_ops) <thread_address_space>: Delete.
5720         (target_thread_address_space): Delete.
5721         * thread.c (init_thread_list): Use ALL_THREADS_SAFE.  Use thread
5722         pointers directly.
5723         (delete_thread_1, delete_thread, delete_thread_silent): Take a
5724         thread pointer instead of a ptid_t.  Adjust all callers.
5725         (ptid_to_global_thread_id, global_thread_id_to_ptid): Delete.
5726         (first_thread_of_process): Delete, replaced by ...
5727         (first_thread_of_inferior): ... this new function.  All callers
5728         adjusted.
5729         (any_thread_of_process): Rename to ...
5730         (any_thread_of_inferior): ... this, and take an inferior pointer.
5731         (any_live_thread_of_process): Rename to ...
5732         (any_live_thread_of_inferior): ... this, and take an inferior
5733         pointer.
5734         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
5735         (value_in_thread_stack_temporaries)
5736         (get_last_thread_stack_temporary): Take a thread pointer instead
5737         of a ptid_t.  Adjust all callers.
5738         (thread_info::set_running): New.
5739         (validate_registers_access): Use inferior_thread.
5740         (can_access_registers_ptid): Rename to ...
5741         (can_access_registers_thread): ... this, and take a thread
5742         pointer.
5743         (print_thread_info_1): Adjust to compare thread pointers instead
5744         of ptids.
5745         (switch_to_no_thread, switch_to_thread): Make extern.
5746         (scoped_restore_current_thread::~scoped_restore_current_thread):
5747         Use m_thread pointer directly.
5748         (scoped_restore_current_thread::scoped_restore_current_thread):
5749         Use inferior_thread.
5750         (thread_command): Use thread pointer directly.
5751         (thread_num_make_value_helper): Use inferior_thread.
5752         * top.c (execute_command): Use inferior_thread.
5753         * tui/tui-interp.c: Include "inferior.h".
5754         * varobj.c (varobj_create): Use inferior_thread.
5755         (value_of_root_1): Use find_thread_global_id instead of
5756         global_thread_id_to_ptid.
5757
5758 2018-06-21  Alan Hayward  <alan.hayward@arm.com>
5759
5760         * regcache.c (readable_regcache::read_part): Avoid memcpy when
5761         possible.
5762         (regcache::write_part): Likewise.
5763         (readable_regcache::cooked_read_part): Update comment.
5764         (readable_regcache::cooked_write_part): Likewise.
5765         * regcache.h: (readable_regcache::read_part): Likewise.
5766         (regcache::write_part): Likewise.
5767
5768 2018-06-21  Richard Bunt  <richard.bunt@arm.com>
5769             Dirk Schubert  <dirk.schubert@arm.com>
5770
5771         * aarch64-linux-nat.c (post_attach): New.
5772         (aarch64_linux_nat_target::post_attach): Override post_attach to
5773         record the number of hardware debug registers.
5774
5775 2018-06-20  Tom Tromey  <tom@tromey.com>
5776
5777         * python/py-param.c (add_setshow_generic): Make parameters const.
5778         (parmpy_init): Update.
5779
5780 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
5781
5782         * regcache.h (regcache_cooked_read_ftype): Rename to...
5783         (register_read_ftype): ...this, change type to function_view.
5784         (class reg_buffer) <save>: Remove src parameter.
5785         (readonly_detached_regcache) <readonly_detached_regcache>: Make
5786         parameter non-const in first overload.  Remove src parameter in
5787         second overload.
5788         * regcache.c (do_cooked_read): Remove.
5789         (readonly_detached_regcache::readonly_detached_regcache): Make
5790         parameter non-const, adjust call to other constructor.
5791         (reg_buffer::save): Remove src parameter.
5792         * frame.c (do_frame_register_read): Remove.
5793         (frame_save_as_regcache): Use lambda function.
5794         * ppc-linux-tdep.c (ppu2spu_unwind_register): Change type of src
5795         parameter to ppu2spu_data *.
5796         (ppu2spu_sniffer): Use lambda function.
5797
5798 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
5799
5800         * record-full.c (record_full_target::insert_breakpoint): Remove
5801         "struct" keyword, add const.
5802
5803 2018-06-19  Simon Marchi  <simon.marchi@ericsson.com>
5804
5805         * common/common-defs.h (PACKAGE_NAME, PACKAGE_VERSION,
5806         PACKAGE_STRING, PACKAGE_TARNAME): Undefine.
5807         * configure.ac: Remove AC_PREREQ, add missing quoting.
5808         * gnulib/configure.ac: Modernize usage of
5809         AC_INIT/AM_INIT_AUTOMAKE.  Remove AC_PREREQ.
5810         * gnulib/update-gnulib.sh (AUTOCONF_VERSION): Bump to 2.69.
5811         (AUTOMAKE_VERSION): Bump to 1.15.1.
5812         * configure: Re-generate.
5813         * config.in: Re-generate.
5814         * aclocal.m4: Re-generate.
5815         * gnulib/aclocal.m4: Re-generate.
5816         * gnulib/config.in: Re-generate.
5817         * gnulib/configure: Re-generate.
5818         * gnulib/import/Makefile.in: Re-generate.
5819
5820 2018-06-19  Pedro Alves  <palves@redhat.com>
5821
5822         * minsyms.c (msym_prefer_to_msym_type): New, factored out from ...
5823         (lookup_minimal_symbol_by_pc_section): ... here with
5824         gdb_assert_not_reached added.
5825
5826 2018-06-19  Pedro Alves  <palves@redhat.com>
5827
5828         * inline-frame.c (stopped_by_user_bp_inline_frame): Replace PC
5829         parameter with a block parameter.  Compare location's block symbol
5830         with the frame's block instead of addresses.
5831         (skip_inline_frames): Pass the current block instead of the
5832         frame's address.  Break out as soon as we determine the frame
5833         should not be skipped.
5834
5835 2018-06-18  Tom Tromey  <tom@tromey.com>
5836
5837         * solib-aix.c (solib_aix_get_section_offsets): Return
5838         unique_xmalloc_ptr.
5839         (solib_aix_solib_create_inferior_hook): Update.
5840
5841 2018-06-18  Tom Tromey  <tom@tromey.com>
5842
5843         * solib-darwin.c (darwin_current_sos): Use unique_xmalloc_ptr.
5844
5845 2018-06-18  Tom Tromey  <tom@tromey.com>
5846
5847         * solib-frv.c (frv_relocate_main_executable): Use
5848         unique_xmalloc_ptr.
5849         * solib-dsbt.c (dsbt_relocate_main_executable): Use
5850         unique_xmalloc_ptr.
5851
5852 2018-06-18  Tom Tromey  <tom@tromey.com>
5853
5854         * objfiles.h (inhibit_section_map_updates): Update.
5855         (resume_section_map_updates, resume_section_map_updates_cleanup):
5856         Remove.
5857         * solib-svr4.c (svr4_handle_solib_event): Update.
5858         * objfiles.c (inhibit_section_map_updates): Return
5859         scoped_restore_tmpl<int>.
5860         (resume_section_map_updates, resume_section_map_updates_cleanup):
5861         Remove.
5862
5863 2018-06-18  Tom Tromey  <tom@tromey.com>
5864
5865         * valprint.h (read_string): Update.
5866         * valprint.c (read_string): Change type of "buffer".
5867         (val_print_string): Update.
5868         * python/py-value.c (valpy_string): Update.
5869         * language.h (struct language_defn) <la_get_string>: Change
5870         type of "buffer".
5871         (default_get_string, c_get_string): Update.
5872         * language.c (default_get_string): Change type of "buffer".
5873         * guile/scm-value.c (gdbscm_value_to_string): Update.
5874         * c-lang.c (c_get_string): Change type of "buffer".
5875
5876 2018-06-18  Tom Tromey  <tom@tromey.com>
5877
5878         * ser-mingw.c (struct pipe_state_destroyer): New.
5879         (pipe_state_up): New typedef.
5880         (cleanup_pipe_state): Remove.
5881         (pipe_windows_open): Use pipe_state_up.  Don't release argv.
5882
5883 2018-06-18  Tom Tromey  <tom@tromey.com>
5884
5885         * rust-lang.h (rust_yyerror): Don't declare.
5886         * rust-lang.c (rust_language_defn): Update.
5887         * rust-exp.y (yyerror): Now static.
5888         * parse.c (parse_exp_in_context_1): Update.
5889         * p-lang.h (p_yyerror): Don't declare.
5890         * p-lang.c (p_language_defn): Update.
5891         * p-exp.y (yyerror): Now static.
5892         * opencl-lang.c (opencl_language_defn): Update.
5893         * objc-lang.c (objc_language_defn): Update.
5894         * m2-lang.h (m2_yyerror): Don't declare.
5895         * m2-lang.c (m2_language_defn): Update.
5896         * m2-exp.y (yyerror): Now static.
5897         * language.h (struct language_defn) <la_error>: Remove.
5898         * language.c (unk_lang_error): Remove.
5899         (unknown_language_defn, auto_language_defn): Remove.
5900         * go-lang.h (go_yyerror): Don't declare.
5901         * go-lang.c (go_language_defn): Update.
5902         * go-exp.y (yyerror): Now static.
5903         * f-lang.h (f_yyerror): Don't declare.
5904         * f-lang.c (f_language_defn): Update.
5905         * f-exp.y (yyerror): Now static.
5906         * d-lang.h (d_yyerror): Don't declare.
5907         * d-lang.c (d_language_defn): Update.
5908         * d-exp.y (yyerror): Now static.
5909         * c-lang.h (c_yyerror): Don't declare.
5910         * c-lang.c (c_language_defn, cplus_language_defn)
5911         (asm_language_defn, minimal_language_defn): Update.
5912         * c-exp.y (yyerror): Now static.
5913         * ada-lang.h (ada_yyerror): Don't declare.
5914         * ada-lang.c (ada_language_defn): Update.
5915         * ada-exp.y (yyerror): Now static.
5916
5917 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
5918
5919         * aarch64-linux-nat.c (fetch_sveregs_from_thread): New function.
5920         (store_sveregs_to_thread): Likewise.
5921         (aarch64_linux_fetch_inferior_registers): Check for SVE.
5922         (aarch64_linux_store_inferior_registers): Likewise.
5923         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs): New
5924         function.
5925         (aarch64_sve_regs_copy_to_regcache): Likewise.
5926         (aarch64_sve_regs_copy_from_regcache): Likewise.
5927         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_sveregs): New
5928         declaration.
5929         (aarch64_sve_regs_copy_to_regcache): Likewise.
5930         (aarch64_sve_regs_copy_from_regcache): Likewise.
5931         (sve_context): Structure from Linux headers.
5932         (SVE_SIG_ZREGS_SIZE): Define from Linux headers.
5933         (SVE_SIG_ZREG_SIZE): Likewise.
5934         (SVE_SIG_PREG_SIZE): Likewise.
5935         (SVE_SIG_FFR_SIZE): Likewise.
5936         (SVE_SIG_REGS_OFFSET): Likewise.
5937         (SVE_SIG_ZREGS_OFFSET): Likewise.
5938         (SVE_SIG_ZREG_OFFSET): Likewise.
5939         (SVE_SIG_ZREGS_SIZE): Likewise.
5940         (SVE_SIG_PREGS_OFFSET): Likewise.
5941         (SVE_SIG_PREG_OFFSET): Likewise.
5942         (SVE_SIG_PREGS_SIZE): Likewise.
5943         (SVE_SIG_FFR_OFFSET): Likewise.
5944         (SVE_SIG_REGS_SIZE): Likewise.
5945         (SVE_SIG_CONTEXT_SIZE): Likewise.
5946         (SVE_PT_REGS_MASK): Likewise.
5947         (SVE_PT_REGS_FPSIMD): Likewise.
5948         (SVE_PT_REGS_SVE): Likewise.
5949         (SVE_PT_VL_INHERIT): Likewise.
5950         (SVE_PT_VL_ONEXEC): Likewise.
5951         (SVE_PT_REGS_OFFSET): Likewise.
5952         (SVE_PT_FPSIMD_OFFSET): Likewise.
5953         (SVE_PT_FPSIMD_SIZE): Likewise.
5954         (SVE_PT_SVE_ZREG_SIZE): Likewise.
5955         (SVE_PT_SVE_PREG_SIZE): Likewise.
5956         (SVE_PT_SVE_FFR_SIZE): Likewise.
5957         (SVE_PT_SVE_FPSR_SIZE): Likewise.
5958         (SVE_PT_SVE_FPCR_SIZE): Likewise.
5959         (__SVE_SIG_TO_PT): Likewise.
5960         (SVE_PT_SVE_OFFSET): Likewise.
5961         (SVE_PT_SVE_ZREGS_OFFSET): Likewise.
5962         (SVE_PT_SVE_ZREG_OFFSET): Likewise.
5963         (SVE_PT_SVE_ZREGS_SIZE): Likewise.
5964         (SVE_PT_SVE_PREGS_OFFSET): Likewise.
5965         (SVE_PT_SVE_PREG_OFFSET): Likewise.
5966         (SVE_PT_SVE_PREGS_SIZE): Likewise.
5967         (SVE_PT_SVE_FFR_OFFSET): Likewise.
5968         (SVE_PT_SVE_FPSR_OFFSET): Likewise.
5969         (SVE_PT_SVE_FPCR_OFFSET): Likewise.
5970         (SVE_PT_SVE_SIZE): Likewise.
5971         (SVE_PT_SIZE): Likewise.
5972         (HAS_SVE_STATE): New define.
5973
5974 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
5975
5976         * nat/aarch64-sve-linux-sigcontext.h: New file.
5977         * nat/aarch64-sve-linux-ptrace.h (SVE_VQ_BYTES): Move to
5978         new files.
5979         (SVE_VQ_MIN): Likewise.
5980         (SVE_VQ_MAX): Likewise.
5981         (SVE_VL_MIN): Likewise.
5982         (SVE_VL_MAX): Likewise.
5983         (SVE_NUM_ZREGS): Likewise.
5984         (SVE_NUM_PREGS): Likewise.
5985         (sve_vl_valid): Likewise.
5986         (struct user_sve_header): Likewise.
5987
5988 2018-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5989             Richard Bunt <Richard.Bunt@arm.com>
5990
5991         * linux-nat.c (stop_wait_callback): Don't discard SIGSTOP if it
5992         was requested by GDB.
5993
5994 2018-06-15  Tom de Vries  <tdevries@suse.de>
5995
5996         * MAINTAINERS (Write After Approval): Add Tom de Vries.
5997
5998 2018-06-14  Simon Marchi  <simon.marchi@polymtl.ca>
5999
6000         * gnulib/update-gnulib.sh: Print expected versions of
6001         autoconf/aclocal.
6002
6003 2018-06-14  Simon Marchi  <simon.marchi@ericsson.com>
6004
6005         * arch-utils.c (default_type_align): Use type_length_units.
6006         * gdbtypes.c (type_align): Use type_length_units.
6007
6008 2018-06-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6009
6010         * cli/cli-script.c (_initialize_cli_script): Fix online documentation
6011         of 'define' command.
6012
6013 2018-06-14  Tom de Vries  <tdevries@suse.de>
6014
6015         PR cli/22573
6016         * infcmd.c (print_return_value_1): Use get_user_print_options instead of
6017         get_no_prettyformat_print_options.
6018
6019 2018-06-13  Simon Marchi  <simon.marchi@ericsson.com>
6020
6021         * sparc-nat.h: Include target.h.
6022         * sparc64-linux-nat.c (class sparc64_linux_nat_target)
6023         <fetch_registers>: Remove this argument in function call.
6024         <store_registers>: Remove this argument in function call, remove
6025         extra semicolon.
6026         <low_forget_process>: Call sparc64_forget_process instead of
6027         sparc_forget_process.
6028
6029 2018-06-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6030
6031         * procfs.c (_initialize_procfs): Use add_inf_child_target.
6032         (procfs_target::make_corefile_notes): Adjust to new
6033         target_read_alloc return type.
6034
6035 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6036             Stephen Roberts  <stephen.roberts@arm.com>
6037
6038         PR gdb/22882
6039         * infrun.c (fetch_inferior_event): If GDB is not proceeding then
6040         run INF_EXEC_COMPLETE handler, even when not calling normal_stop.
6041         Move should_notify_stop local into more inner scope.
6042
6043 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6044             Stephen Roberts  <stephen.roberts@arm.com>
6045
6046         PR gdb/22882
6047         * infrun.c (resume_1): Add call to mark_async_event_handler.
6048
6049 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6050
6051         * infrun.c (do_target_wait): Change old version of $pc printed.
6052
6053 2018-06-11  Simon Marchi  <simon.marchi@ericsson.com>
6054
6055         * dwarf2read.c (read_index_from_section): Rename to...
6056         (read_gdb_index_from_section): ... this, update all callers.
6057         (dwarf2_read_index): Rename to...
6058         (dwarf2_read_gdb_index): ... this, update all callers.
6059
6060 2018-06-11  John David Anglin  <danglin@gcc.gnu.org>
6061
6062         * gdb/hppa-linux-nat.c
6063         (hppa_linux_nat_target::fetch_inferior_registers): Rename to
6064         hppa_linux_nat_target::fetch_registers.
6065
6066 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
6067
6068         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Add mappings.
6069         * aarch64-tdep.h (AARCH64_DWARF_SVE_VG): Add define.
6070         (AARCH64_DWARF_SVE_FFR): Likewise.
6071         (AARCH64_DWARF_SVE_P0): Likewise.
6072         (AARCH64_DWARF_SVE_Z0): Likewise.
6073
6074 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
6075
6076         * common/common-regcache.h (raw_compare): New function.
6077         * regcache.c (regcache::raw_compare): Likewise.
6078         * regcache.h (regcache::raw_compare): New declaration.
6079
6080 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
6081
6082         * common/common-regcache.h (reg_buffer_common): New structure.
6083         * regcache.c (reg_buffer::invalidate): Move from detached_regcache.
6084         (reg_buffer::raw_supply): Likewise.
6085         (reg_buffer::raw_supply_integer): Likewise.
6086         (reg_buffer::raw_supply_zeroed): Likewise.
6087         (reg_buffer::raw_collect): Likewise.
6088         (reg_buffer::raw_collect_integer): Likewise.
6089         * regcache.h (reg_buffer::invalidate): Move from detached_regcache.
6090         (reg_buffer::raw_supply): Likewise.
6091         (reg_buffer::raw_supply_integer): Likewise.
6092         (reg_buffer::raw_supply_zeroed): Likewise.
6093         (reg_buffer::raw_collect): Likewise.
6094         (reg_buffer::raw_collect_integer): Likewise.
6095
6096 2018-06-10  Tom Tromey  <tom@tromey.com>
6097
6098         * remote.c (stop_reply_p): Remove typedef.  Don't declare queue.
6099         (class remote_state) <stop_reply_queue>: Now std::vector.
6100         (remote_state::~remote_state)
6101         (remote_target::stop_reply_queue_length): Update.
6102         (struct queue_iter_param, remove_child_of_pending_fork)
6103         (struct check_pending_event_prevents_wildcard_vcont_callback_data)
6104         (check_pending_event_prevents_wildcard_vcont_callback)
6105         (remove_stop_reply_for_inferior)
6106         (remove_stop_reply_of_remote_state)
6107         (remote_notif_remove_once_on_match)
6108         (stop_reply_match_ptid_and_ws)
6109         (remote_kill_child_of_pending_fork): Remove.
6110         (remote_target::remove_new_fork_children)
6111         (remote_target::check_pending_events_prevent_wildcard_vcont)
6112         (remote_target::discard_pending_stop_replies)
6113         (remote_target::discard_pending_stop_replies_in_queue)
6114         (remote_target::remote_notif_remove_queued_reply)
6115         (remote_target::queued_stop_reply)
6116         (remote_target::push_stop_reply, remote_target::peek_stop_reply)
6117         (remote_target::wait, remote_target::kill_new_fork_children)
6118         (remote_target::async): Update.
6119
6120 2018-06-10  Tom Tromey  <tom@tromey.com>
6121
6122         * record-full.c (record_full_arch_list_cleanups): Remove.
6123         (record_full_message): Use try/catch.
6124         (record_full_wait_cleanups): Remove.
6125         (record_full_wait_1): Use try/catch.
6126         (record_full_restore): Likewise.
6127
6128 2018-06-10  Tom Tromey  <tom@tromey.com>
6129
6130         * record-full.c (record_full_breakpoint_p): Remove typedef.  Don't
6131         declare VEC.  Add constructor.
6132         <in_target_beneath>: Now bool.
6133         (record_full_breakpoints): Now a std::vector, static.
6134         (record_full_sync_record_breakpoints)
6135         (record_full_init_record_breakpoints)
6136         (record_full_target::insert_breakpoint)
6137         (record_full_target::remove_breakpoint): Update.  Don't use XNEW.
6138
6139 2018-06-10  Simon Marchi  <simon.marchi@polymtl.ca>
6140
6141         * dwarf2read.c (process_cu_includes): Remove struct keyword.
6142         * serial.c (serial_interface_lookup): Remove struct keyword.
6143
6144 2018-06-10  Tom Tromey  <tom@tromey.com>
6145
6146         * procfs.c (procfs_target::xfer_partial): Use "beneath" as a
6147         method.
6148         * nto-procfs.c (nto_procfs_target::xfer_partial): Use "beneath" as
6149         a method.
6150         * go32-nat.c (go32_nat_target::xfer_partial): Use "beneath" as a
6151         method.
6152         * arm-linux-nat.c (arm_linux_nat_target::read_description): Use
6153         "beneath" as a method.
6154         * arm-fbsd-nat.c (arm_fbsd_nat_target::read_description):
6155         Use "beneath" as a method.
6156
6157 2018-06-10  Tom Tromey  <tom@tromey.com>
6158
6159         * tracefile.c (struct trace_file_writer_deleter): New.
6160         <operator()>: Rename from trace_file_writer_xfree.
6161         (trace_file_writer_up): New typedef.
6162         (tsave_command, trace_save_tfile, trace_save_ctf): Update.
6163
6164 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
6165
6166         * regcache.h (reg_buffer) <~reg_buffer>: Use default destructor.
6167         <m_registers, m_register_status>: Change type to
6168         std::unique_ptr.
6169         * regcache.c (reg_buffer::reg_buffer): Use new instead of
6170         XCNEWVEC.
6171
6172 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
6173
6174         * common/common-regcache.h (enum register_status): Add
6175         underlying type "signed char".
6176         * regcache.h (reg_buffer) <m_register_status>: Change type to
6177         register_status *.
6178         * regcache.c (reg_buffer::reg_buffer): Alocate arrays of
6179         register_status instead of signed char.
6180         (reg_buffer::save): Use REG_UNKNOWN instead of 0.
6181         (reg_buffer::get_register_status): Remove cast.
6182         (readable_regcache::raw_read): Remove cast.
6183         (readable_regcache::cooked_read): Remove cast.
6184
6185 2018-06-09  Tom Tromey  <tom@tromey.com>
6186
6187         * source.c (reverse_search_command, forward_search_command): Use
6188         scoped_fd.
6189
6190 2018-06-09  Tom Tromey  <tom@tromey.com>
6191
6192         * serial.c (serial_ops_p): Remove typedef.  Don't declare VEC.
6193         (serial_ops_list): Now static, std::vector.
6194         (serial_interface_lookup, serial_add_interface): Update.
6195
6196 2018-06-09  Tom Tromey  <tom@tromey.com>
6197
6198         * dwarf2read.c (process_cu_includes): Update.
6199         (process_full_comp_unit): Update.
6200         * dwarf2read.h (struct dwarf2_per_objfile) <just_read_cus>: Now a
6201         std::vector.
6202
6203 2018-06-08  Paul Koning  <paul_koning@dell.com>
6204
6205         PR gdb/23252
6206
6207         * python/python.c (do_start_initialization):
6208         Avoid call to internal Python API.
6209         (init__gdb_module): New function.
6210
6211 2018-06-08  Gary Benson <gbenson@redhat.com>
6212
6213         * linux-thread-db.c (valprint.h): New include.
6214         (struct check_thread_db_info): New structure.
6215         (check_thread_db_on_load, tdb_testinfo): New static globals.
6216         (check_thread_db, check_thread_db_callback): New functions.
6217         (try_thread_db_load_1): Run integrity checks if requested.
6218         (maintenance_check_libthread_db): New function.
6219         (_initialize_thread_db): Register "maint check libthread-db"
6220         and "maint set/show check-libthread-db".
6221         * NEWS: Mention the above new commands.
6222
6223 2018-06-08  Tom Tromey  <tom@tromey.com>
6224
6225         * windows-nat.c (windows_nat_target::xfer_partial): "beneath" is
6226         now a method.
6227
6228 2018-06-08  Tom Tromey  <tom@tromey.com>
6229
6230         * btrace.c (parse_xml_raw): Use gdb::unique_xmalloc_ptr.
6231
6232 2018-06-08  Tom Tromey  <tom@tromey.com>
6233
6234         * common/btrace-common.h (struct btrace_data): Add constructor,
6235         destructor, move assignment operator.
6236         <empty, clear, fini>: New methods.
6237         <format>: Initialize.
6238         (btrace_data_init, btrace_data_fini, btrace_data_clear)
6239         (btrace_data_empty): Don't declare.
6240         * common/btrace-common.c (btrace_data_init): Remove.
6241         (btrace_data::fini): Rename from btrace_data_fini.
6242         (btrace_data::empty): Rename from btrace_data_empty.
6243         (btrace_data::clear): Rename from btrace_data_clear.  Return
6244         bool.
6245         * btrace.h (make_cleanup_btrace_data): Don't declare.
6246         * btrace.c (btrace_add_pc, btrace_stitch_trace, btrace_clear)
6247         (parse_xml_btrace): Update.
6248         (do_btrace_data_cleanup, make_cleanup_btrace_data): Remove.
6249         (maint_btrace_clear_packet_history_cmd): Update.
6250
6251 2018-06-07  Pedro Alves  <palves@redhat.com>
6252
6253         * target.h (target_ops) <beneath>: Now a method.  All references
6254         updated.
6255         (class target_stack): New.
6256         * target.c (g_target_stack): New.
6257         (g_current_top_target): Delete.
6258         (current_top_target): Get the top target out of g_target_stack.
6259         (target_stack::push, target_stack::unpush): New.
6260         (push_target, unpush_target): Reimplement.
6261         (target_is_pushed): Reimplement in terms of g_target_stack.
6262         (target_ops::beneath, target_stack::find_beneath): New.
6263
6264 2018-06-07  Pedro Alves  <palves@redhat.com>
6265
6266         * target.h (find_target_beneath): Delete declaration.
6267         * target.c (find_target_beneath): Delete definition.
6268         * aix-thread.c: All callers of find_target_beneath adjusted to
6269         call target_ops::beneath instead.
6270         * bsd-uthread.c: Likewise.
6271         * linux-thread-db.c: Likewise.
6272         * ravenscar-thread.c: Likewise.
6273         * sol-thread.c: Likewise.
6274         * spu-multiarch.c: Likewise.
6275
6276 2018-06-07  Pedro Alves  <palves@redhat.com>
6277
6278         * target.h (target_ops) <beneath>: Now a method.  All references
6279         updated.
6280         (target_ops) <m_beneath>: New.
6281         * target.c (target_ops::beneath): New.
6282         * corelow.c: Adjust all references to target_ops::beneath.
6283         * linux-thread-db.c: Likewise.
6284         * make-target-delegates: Likewise.
6285         * record-btrace.c: Likewise.
6286         * record-full.c: Likewise.
6287         * remote.c: Likewise.
6288         * target.c: Likewise.
6289         * target-delegates.c: Regenerate.
6290
6291 2018-06-07  Pedro Alves  <palves@redhat.com>
6292
6293         * target.h (target_stack): Delete.
6294         (current_top_target): Declare function.
6295         * target.c (target_stack): Delete.
6296         (g_current_top_target): New.
6297         (current_top_target): New function.
6298         * auxv.c: Use current_top_target instead of target_stack
6299         throughout.
6300         * avr-tdep.c: Likewise.
6301         * breakpoint.c: Likewise.
6302         * corefile.c: Likewise.
6303         * elfread.c: Likewise.
6304         * eval.c: Likewise.
6305         * exceptions.c: Likewise.
6306         * frame.c: Likewise.
6307         * gdbarch-selftests.c: Likewise.
6308         * gnu-v3-abi.c: Likewise.
6309         * ia64-tdep.c: Likewise.
6310         * ia64-vms-tdep.c: Likewise.
6311         * infcall.c: Likewise.
6312         * infcmd.c: Likewise.
6313         * infrun.c: Likewise.
6314         * linespec.c: Likewise.
6315         * linux-tdep.c: Likewise.
6316         * minsyms.c: Likewise.
6317         * ppc-linux-nat.c: Likewise.
6318         * ppc-linux-tdep.c: Likewise.
6319         * procfs.c: Likewise.
6320         * regcache.c: Likewise.
6321         * remote.c: Likewise.
6322         * rs6000-tdep.c: Likewise.
6323         * s390-linux-nat.c: Likewise.
6324         * s390-tdep.c: Likewise.
6325         * solib-aix.c: Likewise.
6326         * solib-darwin.c: Likewise.
6327         * solib-dsbt.c: Likewise.
6328         * solib-spu.c: Likewise.
6329         * solib-svr4.c: Likewise.
6330         * solib-target.c: Likewise.
6331         * sparc-tdep.c: Likewise.
6332         * sparc64-tdep.c: Likewise.
6333         * spu-tdep.c: Likewise.
6334         * symfile.c: Likewise.
6335         * symtab.c: Likewise.
6336         * target-descriptions.c: Likewise.
6337         * target-memory.c: Likewise.
6338         * target.c: Likewise.
6339         * target.h: Likewise.
6340         * tracefile-tfile.c: Likewise.
6341         * tracepoint.c: Likewise.
6342         * valops.c: Likewise.
6343         * valprint.c: Likewise.
6344         * value.c: Likewise.
6345         * windows-tdep.c: Likewise.
6346         * mi/mi-main.c: Likewise.
6347
6348 2018-06-07  Tom Tromey  <tom@tromey.com>
6349
6350         * valprint.h (build_address_symbolic): Declare.
6351         * printcmd.c (print_address_symbolic): Update.
6352         (build_address_symbolic): Change "name" and "filename" to
6353         std::string.
6354         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6355         Update.
6356         * defs.h (build_address_symbolic): Remove declaration.
6357
6358 2018-06-07  Alan Hayward  <alan.hayward@arm.com>
6359
6360         * aarch64-tdep.c (AARCH64_SVE_V0_REGNUM): Add define.
6361         (aarch64_vnv_type): Add function.
6362         (aarch64_pseudo_register_name): Add V regs for SVE.
6363         (aarch64_pseudo_register_type): Likewise.
6364         (aarch64_pseudo_register_reggroup_p): Likewise.
6365         (aarch64_pseudo_read_value_2): Use V0 offset for SVE
6366         (aarch64_pseudo_read_value): Add V regs for SVE.
6367         (aarch64_pseudo_write_2): Use V0 offset for SVE
6368         (aarch64_pseudo_write): Add V regs for SVE.
6369         * aarch64-tdep.h (struct gdbarch_tdep): Add vnv_type.
6370
6371 2018-06-06  Sergio Durigan Junior  <sergiodj@redhat.com>
6372
6373         * arch/aarch64.h (sve_vq_from_vl): Guard with #ifndef.
6374         (sve_vl_from_vq): Likewise.
6375
6376 2018-06-05  Tom Tromey  <tom@tromey.com>
6377
6378         * cli/cli-cmds.c (show_version): Update.
6379         * top.c (print_gdb_version): Add "interactive" parameter.
6380         Update.
6381         * main.c (captured_main_1): Update.
6382         * top.h (print_gdb_version): Add "interactive" parameter and a
6383         comment.
6384
6385 2018-06-05  David Malcolm  <dmalcolm@redhat.com>
6386
6387         * common/enum-flags.h: Add trailing semicolon to example in
6388         comment.
6389
6390 2018-06-05  Tom Tromey  <tom@tromey.com>
6391
6392         PR cli/12326:
6393         * NEWS: Add entry about pager.
6394         * utils.c (pagination_disabled_for_command): New global.
6395         (prompt_for_continue): Allow "c" response to prompt.
6396         (reinitialize_more_filter): Clear
6397         pagination_disabled_for_command.
6398         (fputs_maybe_filtered): Check pagination_disabled_for_command.
6399
6400 2018-06-04  Tom Tromey  <tom@tromey.com>
6401
6402         * ada-lang.h (ada_lookup_symbol_list): Update.
6403         * ada-lang.c (resolve_subexp): Update.
6404         (symbols_are_identical_enums): Change type of syms.  Remove nsyms
6405         parameter.
6406         (remove_extra_symbols, remove_irrelevant_renamings): Likewise.
6407         (ada_lookup_symbol_list_worker, ada_lookup_symbol_list): Change
6408         results parameter to std::vector.
6409         (ada_iterate_over_symbols, ada_lookup_symbol, get_var_value):
6410         Update.
6411         * ada-exp.y (block_lookup): Update.
6412         (select_possible_type_sym): Change type of syms.  Remove nsyms
6413         parameter.
6414         (write_var_or_type, write_name_assoc): Update.
6415
6416 2018-06-04  Joel Brobecker  <brobecker@adacore.com>
6417
6418         * windows-nat.c (windows_nat_target::xfer_partial): Return
6419         TARGET_XFER_E_IO if we need to delegate to the target beneath
6420         but BENEATH is NULL.
6421
6422 2018-06-04  Simon Marchi  <simon.marchi@ericsson.com>
6423
6424         * Makefile.in (config.status): Add configure.nat as a
6425         dependency.
6426
6427 2018-06-04  Tom Tromey  <tom@tromey.com>
6428
6429         * cp-name-parser.y (cpname_state): Add method declarations.
6430         (HANDLE_QUAL): Update.
6431         (cpname_state::d_grab, cpname_state::fill_comp)
6432         (cpname_state::make_operator, cpname_state::make_dtor)
6433         (cpname_state::make_builtin_type, cpname_state::make_name)
6434         (cpname_state::d_qualify, cpname_state::d_int_type)
6435         (cpname_state::d_unary, cpname_state::d_binary): Now methods.
6436         (%union): Move earlier.
6437
6438 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
6439
6440         * elfread.c (elf_symfile_segments): Use ELF_SECTION_IN_SEGMENT.
6441
6442 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
6443
6444         * aarch64-tdep.c (aarch64_pseudo_read_value_1): New helper func.
6445         (aarch64_pseudo_write_1): Likewise.
6446         (aarch64_pseudo_read_value): Use helper.
6447         (aarch64_pseudo_write): Likewise.
6448
6449 2018-06-04  Pedro Alves  <palves@redhat.com>
6450
6451         * darwin-nat.c (darwin_ops): Delete.
6452         (darwin_attach_pid): Use get_native_target.
6453
6454 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
6455
6456         * aarch64-tdep.c (aarch64_get_tdesc_vq): Use uint64_t for VQ.
6457         * aarch64-tdep.h (struct gdbarch_tdep): Likewise.
6458
6459 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
6460
6461         * aarch64-linux-nat.c (aarch64_linux_read_description): Support SVE.
6462         * aarch64-tdep.c (aarch64_get_tdesc_vq): New function.
6463         (aarch64_gdbarch_init): Check for SVE.
6464         * aarch64-tdep.h (gdbarch_tdep::has_sve): New function.
6465
6466 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
6467
6468         * aarch64-tdep.c (aarch64_read_description): Use uint64_t for VQ.
6469         * aarch64-tdep.h (aarch64_read_description): Likewise.
6470         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6471         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6472         * features/aarch64-sve.c (create_feature_aarch64_sve): Likewise.
6473         * nat/aarch64-sve-linux-ptrace.c(aarch64_sve_get_vq): Likewise.
6474         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_vq): Likewise.
6475
6476 2018-06-02  Simon Marchi  <simon.marchi@ericsson.com>
6477
6478         * value.c (value_fetch_lazy_bitfield): New.
6479         (value_fetch_lazy_memory): New.
6480         (value_fetch_lazy_register): New.
6481         (value_fetch_lazy): Factor out to smaller functions.
6482
6483 2018-06-01  Tom Tromey  <tom@tromey.com>
6484
6485         * cp-name-parser.y (backslashable, represented): Now const.
6486
6487 2018-06-01  Tom Tromey  <tom@tromey.com>
6488
6489         * cp-name-parser.y: Include parser-defs.h.
6490         (parser_fprintf): Remove declaration.
6491
6492 2018-06-01  Tom Tromey  <tom@tromey.com>
6493
6494         * cp-name-parser.y: Use %pure-parser, %lex-param, and
6495         %parse-param.
6496         (lexptr, prev_lexptr, error_lexptr, global_errmsg, demangle_info)
6497         (global_result): Remove globals.
6498         (struct cpname_state): New.
6499         (yyparse): Don't declare.
6500         (yylex, yyerror): Move declarations after %union.
6501         (d_grab, fill_comp, make_operator, make_dtor, make_builtin_type)
6502         (make_name): Add state parameter.
6503         Update all callers.
6504         (d_qualify, d_int_type, d_unary, d_binary, parse_number) Add state
6505         parameter.
6506         (HANDLE_QUAL, HANDLE_SPECIAL, HANDLE_TOKEN2, HANDLE_TOKEN3):
6507         Update.
6508         (yylex): Add lvalp, state parameters.
6509         (yyerror): Add state parameter.
6510         (cp_demangled_name_to_comp): Update.
6511
6512 2018-06-01  Tom Tromey  <tom@tromey.com>
6513
6514         * cp-name-parser.y (parser_fprintf): Declare.
6515         (GDB_YY_REMAP_PREFIX): Define.
6516         Include yy-remap.h.  Don't redefine yy* identifiers.
6517
6518 2018-06-01  Tom Tromey  <tom@tromey.com>
6519
6520         * python/py-type.c (typy_legacy_template_argument): Update.
6521         * cp-support.h (cp_demangled_name_to_comp): Update.
6522         * cp-name-parser.y (cp_demangled_name_to_comp): Change errmsg
6523         parameter to be a "std::string *".
6524         (main): Update.
6525
6526 2018-06-01  H.J. Lu  <hongjiu.lu@intel.com>
6527
6528         * ada-lex.l: Include "diagnostics.h" instead of
6529         "common/diagnostics.h".
6530         * unittests/environ-selftests.c: Likewise.
6531         * common/diagnostics.h: Moved to ../include.
6532
6533 2018-06-01  Joel Brobecker  <brobecker@adacore.com>
6534
6535         * breakpoint.c (breakpoint_re_set): Temporarily force language_mode
6536         to language_mode_manual while calling breakpoint_re_set_one.
6537
6538 2018-06-01  Tom Tromey  <tom@tromey.com>
6539
6540         * valops.c (value_cast_structs, destructor_name_p): Update.
6541         * symtab.c (gdb_mangle_name): Update.
6542         * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses):
6543         Update.
6544         * p-valprint.c (pascal_object_is_vtbl_ptr_type)
6545         (pascal_object_print_value_fields, pascal_object_print_value):
6546         Update.
6547         * p-typeprint.c (pascal_type_print_derivation_info): Update.
6548         * linespec.c (find_methods): Update.
6549         * gdbtypes.h (type_name_no_tag): Remove.
6550         (type_name_or_error): Rename from type_name_no_tag_or_error.
6551         * gdbtypes.c (type_name_no_tag): Remove.
6552         (type_name_or_error): Rename from type_name_no_tag_or_error.
6553         (lookup_struct_elt_type, check_typedef): Update.
6554         * expprint.c (print_subexp_standard): Update.
6555         * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update.
6556         * d-namespace.c (d_lookup_nested_symbol): Update.
6557         * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields)
6558         (cp_print_class_member): Update.
6559         * cp-namespace.c (cp_lookup_nested_symbol): Update.
6560         * completer.c (add_struct_fields): Update.
6561         * c-typeprint.c (cp_type_print_derivation_info)
6562         (c_type_print_varspec_prefix, c_type_print_base_struct_union):
6563         Update.
6564         * ada-lang.c (parse_old_style_renaming, xget_renaming_scope)
6565         (ada_prefer_type, ada_is_exception_sym): Update.
6566
6567 2018-06-01  Tom Tromey  <tom@tromey.com>
6568
6569         * valops.c (enum_constant_from_type, value_namespace_elt)
6570         (value_maybe_namespace_elt): Update.
6571         * valarith.c (find_size_for_pointer_math): Update.
6572         * target-descriptions.c (make_gdb_type): Update.
6573         * symmisc.c (print_symbol): Update.
6574         * stabsread.c (define_symbol, read_type)
6575         (complain_about_struct_wipeout, add_undefined_type)
6576         (cleanup_undefined_types_1): Update.
6577         * rust-lang.c (rust_tuple_type_p, rust_slice_type_p)
6578         (rust_range_type_p, val_print_struct, rust_print_struct_def)
6579         (rust_internal_print_type, rust_composite_type)
6580         (rust_evaluate_funcall, rust_evaluate_subexp)
6581         (rust_inclusive_range_type_p): Update.
6582         * python/py-type.c (typy_get_tag): Update.
6583         * p-typeprint.c (pascal_type_print_base): Update.
6584         * mdebugread.c (parse_symbol, parse_type): Update.
6585         * m2-typeprint.c (m2_long_set, m2_record_fields, m2_enum):
6586         Update.
6587         * guile/scm-type.c (gdbscm_type_tag): Update.
6588         * go-lang.c (sixg_string_p): Update.
6589         * gnu-v3-abi.c (build_gdb_vtable_type, build_std_type_info_type):
6590         Update.
6591         * gdbtypes.h (struct main_type) <tag_name>: Remove.
6592         (TYPE_TAG_NAME): Remove.
6593         * gdbtypes.c (type_name_no_tag): Simplify.
6594         (check_typedef, check_types_equal, recursive_dump_type)
6595         (copy_type_recursive, arch_composite_type): Update.
6596         * f-typeprint.c (f_type_print_base): Update.  Print "Type" prefix
6597         in summary mode when needed.
6598         * eval.c (evaluate_funcall): Update.
6599         * dwarf2read.c (fixup_go_packaging, read_structure_type)
6600         (process_structure_scope, read_enumeration_type)
6601         (read_namespace_type, read_module_type, determine_prefix): Update.
6602         * cp-support.c (inspect_type): Update.
6603         * coffread.c (process_coff_symbol, decode_base_type): Update.
6604         * c-varobj.c (c_is_path_expr_parent): Update.
6605         * c-typeprint.c (c_type_print_base_struct_union): Update.
6606         (c_type_print_base_1): Update.  Print struct/class/union/enum in
6607         summary when using C language.
6608         * ax-gdb.c (gen_struct_ref, gen_namespace_elt)
6609         (gen_maybe_namespace_elt): Update.
6610         * ada-lang.c (ada_type_name): Simplify.
6611         (empty_record, ada_template_to_fixed_record_type_1)
6612         (template_to_static_fixed_type)
6613         (to_record_with_fixed_variant_part, ada_check_typedef): Update.
6614
6615 2018-06-01  Tom Tromey  <tom@tromey.com>
6616
6617         * dwarf2read.c (dwarf2_compute_name): Pass CU's language to
6618         c_print_type.
6619         * c-typeprint.c (c_print_type_1): Add "language" parameter.
6620         (c_print_type): Update.
6621         (c_print_type): New overload.
6622         (c_type_print_varspec_prefix, c_type_print_args)
6623         (c_type_print_varspec_suffix, c_print_type_no_offsets)
6624         (c_type_print_base_struct_union, c_type_print_base_1)
6625         (cp_type_print_method_args): Add "language" parameter.
6626         (c_type_print_base): Update.
6627         * c-lang.h (c_print_type): Add new overload.
6628
6629 2018-06-01  Tom Tromey  <tom@tromey.com>
6630
6631         * typeprint.h (c_type_print_varspec_suffix): Don't declare.
6632         * c-typeprint.c (c_type_print_varspec_suffix): Now static.
6633
6634 2018-06-01  Alan Hayward  <alan.hayward@arm.com>
6635
6636         * aarch64-tdep.c (aarch64_sve_register_names): New const
6637         var.
6638         * arch/aarch64.h (enum aarch64_regnum): Add SVE entries.
6639         (AARCH64_SVE_Z_REGS_NUM): New define.
6640         (AARCH64_SVE_P_REGS_NUM): Likewise.
6641         (AARCH64_SVE_NUM_REGS): Likewise.
6642
6643 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
6644
6645         * nat/linux-ptrace.h [__alpha__]
6646         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
6647         definitions.
6648
6649 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
6650
6651         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
6652         the endianness selected.
6653         * NEWS: Document `set endian auto' mode operation update.
6654
6655 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
6656
6657         * Makefile.in: Add new header.
6658         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
6659         (sve_vl_from_vg): Likewise.
6660         (sve_vq_from_vl): Likewise.
6661         (sve_vl_from_vq): Likewise.
6662         (sve_vq_from_vg): Likewise.
6663         (sve_vg_from_vq): Likewise.
6664         * configure.nat: Add new c file.
6665         * nat/aarch64-sve-linux-ptrace.c: New file.
6666         * nat/aarch64-sve-linux-ptrace.h: New file.
6667
6668 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
6669
6670         * aarch64-linux-nat.c (aarch64_linux_read_description):
6671         Add parmeter zero.
6672         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6673         Likewise.
6674         * aarch64-tdep.c (tdesc_aarch64_list): Add.
6675         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
6676         (aarch64_gdbarch_init): Add parmeter zero.
6677         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
6678         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
6679         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
6680         parmeter.
6681         * doc/gdb.texinfo: Describe SVE feature
6682         * features/aarch64-sve.c: New file.
6683
6684 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
6685
6686         PR gdb/23210
6687         * gdbarch.sh (significant_addr_bit): Default to zero when
6688         not set by target architecture.
6689         * gdbarch.c: Re-generated.
6690         * utils.c (address_significant): Update.
6691
6692 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
6693
6694         * stack.c (func_command): Remove trailing newline in call to error.
6695
6696 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6697
6698         * regcache.h (regcache_raw_collect): Remove, update callers to
6699         use regcache::raw_collect.
6700         * regcache.c (regcache_raw_collect): Remove.
6701
6702 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6703
6704         * regcache.h (regcache_raw_supply): Remove, update callers to
6705         use detached_regcache::raw_supply.
6706         * regcache.c (regcache_raw_supply): Remove.
6707
6708 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6709
6710         * regcache.h (regcache_cooked_write_part): Remove, update
6711         callers to use regcache::cooked_write_part.
6712         * regcache.c (regcache_cooked_write_part): Remove.
6713
6714 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6715
6716         * regcache.h (regcache_cooked_read_part): Remove, update callers
6717         to use readable_regcache::cooked_read_part.
6718         * regcache.c (regcache_cooked_read_part): Remove.
6719
6720 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6721
6722         * regcache.h (regcache_cooked_read_value): Remove, update
6723         callers to use readable_regcache::cooked_read_value.
6724         * regcache.c (regcache_cooked_read_value): Remove.
6725
6726 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6727
6728         * regcache.h (regcache_cooked_write): Remove, update callers to
6729         use regcache::cooked_write.
6730         * regcache.c (regcache_cooked_write): Remove.
6731
6732 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6733
6734         * regcache.h (regcache_invalidate): Remove, update callers to
6735         use detached_regcache::invalidate instead.
6736         * regcache.c (regcache_invalidate): Remove.
6737
6738 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6739
6740         * regcache.h (regcache_raw_write_part): Remove, update callers
6741         to use regcache::raw_write_part instead.
6742         * regcache.c (regcache_raw_write_part): Remove.
6743
6744 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6745
6746         * regcache.h (regcache_raw_read_part): Remove, update callers to
6747         use readable_regcache::raw_read_part instead.
6748         * regcache.c (regcache_raw_read_part): Remove.
6749
6750 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6751
6752         * regcache.h (regcache_cooked_read): Remove, update callers to
6753         use readable_regcache::cooked_read instead.
6754         * regcache.c (regcache_cooked_read): Remove.
6755
6756 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6757
6758         * regcache.h (regcache_raw_write): Remove, update callers to use
6759         regcache::raw_write instead.
6760         * regcache.c (regcache_raw_write): Remove.
6761
6762 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6763
6764         * regcache.h (regcache_raw_read): Remove, update callers to use
6765         readable_regcache::raw_read instead.
6766         * regcache.c (regcache_raw_read): Remove.
6767
6768 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6769
6770         * regcache.h (regcache_raw_update): Remove, update callers to
6771         use readable_regcache::raw_update instead.
6772         * regcache.c (regcache_raw_update): Remove.
6773
6774 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6775
6776         * regcache.h (regcache_register_status): Remove, update callers
6777         to use reg_buffer::get_register_status directly instead.
6778         * regcache.c (regcache_register_status): Remove.
6779
6780 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6781
6782         * regcache.h (regcache_get_ptid): Remove, update all callers to
6783         call regcache::ptid instead.
6784         * regcache.c (regcache_get_ptid): Remove.
6785
6786 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
6787
6788         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
6789
6790 2018-05-30  Pedro Alves  <palves@redhat.com>
6791
6792         * common/common-exceptions.h (exception_rethrow): Use
6793         ATTRIBUTE_NORETURN.
6794
6795 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
6796
6797         * breakpoint.c (print_solib_event, check_status_catch_solib):
6798         Remove struct keyword in range-based for loops.
6799         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
6800         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
6801         Likewise.
6802         * linespec.c (find_superclass_methods, search_minsyms_for_name):
6803         Likewise.
6804         * symfile.c (addr_info_make_relative): Likewise.
6805         * thread.c (value_in_thread_stack_temporaries): Likewise.
6806
6807 2018-06-12  Weimin Pan  <weimin.pan@oracle.com>
6808
6809         PR gdb/16841
6810         * valops.c (value_struct_elt_for_reference): Call check_typedef on
6811         aggregate type to get its real type before accessing it.
6812
6813 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
6814
6815         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
6816         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
6817         * coff-pe-read.c (add_pe_forwarded_sym): Replace
6818         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
6819         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
6820         * jit.c (jit_breakpoint_re_set_internal): Likewise.
6821         * printcmd.c (info_address_command): Likewise.
6822
6823 2018-05-29  Tom Tromey  <tom@tromey.com>
6824
6825         * windows-nat.c (handle_exception): Update fall-through comment.
6826
6827 2018-05-29  Tom Tromey  <tom@tromey.com>
6828
6829         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
6830         (struct program_space) <added_solibs>: Now a std::vector.
6831         * breakpoint.c (print_solib_event): Update.
6832         (check_status_catch_solib): Update.
6833         * progspace.c (clear_program_space_solib_cache): Update.
6834         * solib.c (update_solib_list): Update.
6835
6836 2018-05-29  Tom Tromey  <tom@tromey.com>
6837
6838         * python/py-type.c (typy_richcompare): Update.
6839         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
6840         * gdbtypes.h (types_deeply_equal): Return bool.
6841         (types_equal): Likewise.
6842         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
6843         declare VEC.
6844         (check_types_equal): Change worklist to std::vector.  Return
6845         bool.
6846         (struct type_equality_entry): Add constructor.
6847         (compare_maybe_null_strings): Return bool.
6848         (check_types_worklist): Return bool.  Change worklist to
6849         std::vector.
6850         (types_deeply_equal): Use std::vector.
6851         (types_equal): Return bool.
6852         (compare_maybe_null_strings): Simplify.
6853
6854 2018-05-29  Tom Tromey  <tom@tromey.com>
6855
6856         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
6857
6858 2018-05-29  Tom Tromey  <tom@tromey.com>
6859
6860         * objc-lang.h: Don't include cp-support.h.
6861         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
6862         declare VEC.
6863
6864 2018-05-27  Tom Tromey  <tom@tromey.com>
6865
6866         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
6867
6868 2018-05-25  Tom Tromey  <tom@tromey.com>
6869
6870         * value.c (value::location): Initialize.
6871
6872 2018-05-25  Tom Tromey  <tom@tromey.com>
6873
6874         * dbxread.c (init_bincl_list): Remove.
6875         (bincl_list): Now a std::vector.
6876         (bincls_allocated, next_bincl): Remove.
6877         (free_bincl_list, do_free_bincl_list_cleanup)
6878         (make_cleanup_free_bincl_list): Remove.
6879         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
6880         unique_xmalloc_ptr.
6881         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
6882         (struct header_file_location): Add constructor.
6883         (add_bincl_to_list): Remove.
6884
6885 2018-05-25  Tom Tromey  <tom@tromey.com>
6886
6887         * tui/tui.c (tui_enable): Update.
6888         * mi/mi-interp.c (mi_interp::init): Update.
6889         * interps.h (class interp) <name>: New method.
6890         <m_name>: Rename from name.
6891         (~scoped_restore_interp): Update.
6892         * interps.c (interp::interp): Update.
6893         (interp_add, interp_set, interp_lookup_existing)
6894         (current_interp_named_p): Update.
6895
6896 2018-05-25  Tom Tromey  <tom@tromey.com>
6897
6898         * interps.c (interp_name): Remove.
6899         * mi/mi-interp.c (mi_interp::init): Update.
6900         * interps.h (interp_name): Remove.
6901         (~scoped_restore_interp): Update.
6902         * tui/tui.c (tui_enable): Update.
6903
6904 2018-05-25  Tom Tromey  <tom@tromey.com>
6905
6906         * utils.c (fputs_maybe_filtered): Update.
6907         * linespec.c (decode_line_full): Update.
6908         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
6909         (mi_print_breakpoint_for_event, mi_solib_loaded)
6910         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
6911         (mi_user_selected_context_changed): Update.
6912         * mi/mi-main.c (mi_execute_command): Update.
6913         * cli/cli-script.c (execute_control_command): Update.
6914         * python/python.c (execute_gdb_command): Update.
6915         * solib.c (info_sharedlibrary_command): Update.
6916         * interps.c (interp_ui_out): Remove.
6917         * interps.h (interp_ui_out): Remove.
6918
6919 2018-05-25  Tom Tromey  <tom@tromey.com>
6920
6921         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
6922         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
6923         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
6924
6925 2018-05-25  Tom Tromey  <tom@tromey.com>
6926
6927         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
6928         * interps.c (interp_exec): Use scoped_restore.
6929
6930 2018-05-25  Tom Tromey  <tom@tromey.com>
6931
6932         * remote.c (remote_target::remote_file_get): Use
6933         gdb::byte_vector.
6934         (remote_target::remote_file_put): Likewise.
6935
6936 2018-05-25  Tom Tromey  <tom@tromey.com>
6937
6938         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
6939         a std::string.
6940         (get_pe_section_index, add_pe_exported_sym): Update.
6941         (read_pe_exported_syms): Use gdb::def_vector.
6942
6943 2018-05-25  Tom Tromey  <tom@tromey.com>
6944
6945         * frame.c (remove_prev_frame): Remove.
6946         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
6947
6948 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
6949
6950         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
6951         Remove prototypes.
6952         * mips-linux-nat.c (supply_fpregset): Always call
6953         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
6954         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
6955         `mips_fill_fpregset'.
6956         * mips-linux-tdep.c (mips_supply_fpregset)
6957         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
6958         (mips_fill_fpregset_wrapper): Remove functions.
6959         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
6960         (mips_linux_fpregset): Remove variable.
6961         (mips_linux_iterate_over_regset_sections): Use
6962         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
6963         (mips_linux_o32_sigframe_init): Remove comment.
6964
6965 2018-05-25  Pedro Alves  <palves@redhat.com>
6966
6967         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
6968         (struct readahead_cache, struct packet_reg, struct
6969         remote_arch_state, class remote_state): Move higher up in the
6970         file.
6971         (remote_target::m_remote_state): Now an object instead of a pointer.
6972         (remote_target::get_remote_state): Adjust.
6973
6974 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6975
6976         * stack.c (select_and_print_frame): Delete.
6977         (struct function_bounds): Move struct within function.
6978         (func_command): Most content moved into new function
6979         find_frame_for_function, use new function, print result, add
6980         function comment.
6981         (find_frame_for_function): New function, now returns a result.
6982
6983 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6984
6985         * stack.c (iterate_over_block_arg_vars): Fix comment.
6986         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
6987
6988 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6989
6990         PR gdb/23203
6991         * frame.c
6992         (scoped_restore_selected_frame::scoped_restore_selected_frame):
6993         Define.
6994         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
6995         Define.
6996         * frame.h (class scoped_restore_selected_frame): New class.
6997         * stack.c (print_frame_local_vars): Remove catching and rethrowing
6998         of any exception, use scoped_restore_selected_frame to restore the
6999         frame instead.
7000
7001 2018-05-24  Pedro Alves  <palves@redhat.com>
7002
7003         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
7004         override.
7005
7006 2018-05-23  Tom Tromey  <tom@tromey.com>
7007
7008         * complaints.c (struct complaints): Remove.
7009         (symfile_complaint_book): Remove.
7010         (series): New global.
7011         (complaint_internal): Update.
7012         (clear_complaints): Update.
7013
7014 2018-05-23  Tom Tromey  <tom@tromey.com>
7015
7016         * complaints.c (counters): New global.
7017         (struct complain): Remove.
7018         (struct complaints) <root>: Remove.
7019         (complaint_sentinel): Remove.
7020         (symfile_complaint_book): Update.
7021         (find_complaint) Remove.
7022         (complaint_internal, clear_complaints): Update.
7023
7024 2018-05-23  Tom Tromey  <tom@tromey.com>
7025
7026         * complaints.c (struct complain) <file, line>: Remove.
7027         (find_complaint): Remove file, line parameters.
7028         (complaint_internal): Update.
7029
7030 2018-05-23  Tom Tromey  <tom@tromey.com>
7031
7032         * complaints.c (vcomplaint): Remove.
7033         (complaint_internal) Merge in contents of vcomplaint.
7034
7035 2018-05-23  Tom Tromey  <tom@tromey.com>
7036
7037         * complaints.c (struct complaints) <explanation>: Remove.
7038         (symfile_explanations): Remove.
7039         (symfile_complaint_book): Update.
7040         (vcomplaint): Update.
7041         (struct explanation): Remove.
7042
7043 2018-05-23  Tom Tromey  <tom@tromey.com>
7044
7045         * complaints.c (symfile_complaints): Remove.
7046         (complaint_internal): Remove "complaints" parameter.
7047         (clear_complaints, vcomplaint): Remove "c" parameter.
7048         (get_complaints): Remove.
7049         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
7050         (dwarf2_debug_line_missing_file_complaint)
7051         (dwarf2_debug_line_missing_end_sequence_complaint)
7052         (dwarf2_complex_location_expr_complaint)
7053         (dwarf2_const_value_length_mismatch_complaint)
7054         (dwarf2_section_buffer_overflow_complaint)
7055         (dwarf2_macro_malformed_definition_complaint)
7056         (dwarf2_invalid_attrib_class_complaint)
7057         (create_addrmap_from_index, dw2_symtab_iter_next)
7058         (dw2_expand_marked_cus)
7059         (dw2_debug_names_iterator::find_vec_in_debug_names)
7060         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
7061         (create_debug_type_hash_table, init_cutu_and_read_dies)
7062         (partial_die_parent_scope, add_partial_enumeration)
7063         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
7064         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
7065         (read_import_statement, read_file_scope, create_dwo_cu_reader)
7066         (create_cus_hash_table, create_dwp_hash_table)
7067         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
7068         (dwarf2_rnglists_process, dwarf2_ranges_process)
7069         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
7070         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
7071         (handle_struct_member_die, process_structure_scope)
7072         (read_array_type, read_common_block, read_module_type)
7073         (read_tag_pointer_type, read_typedef, read_base_type)
7074         (read_subrange_type, load_partial_dies, partial_die_info::read)
7075         (partial_die_info::read, partial_die_info::read)
7076         (partial_die_info::read, read_checked_initial_length_and_offset)
7077         (dwarf2_string_attr, read_formatted_entries)
7078         (dwarf_decode_line_header)
7079         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
7080         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
7081         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
7082         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
7083         (get_signatured_type, get_DW_AT_signature_type)
7084         (decode_locdesc, file_file_name, consume_improper_spaces)
7085         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
7086         (dwarf_decode_macro_bytes, dwarf_decode_macros)
7087         (dwarf2_symbol_mark_computed, set_die_type)
7088         (read_attribute_value): Update.
7089         * stap-probe.c (handle_stap_probe, get_stap_base_address):
7090         Update.
7091         * dbxread.c (unknown_symtype_complaint)
7092         (lbrac_mismatch_complaint, repeated_header_complaint)
7093         (set_namestring, function_outside_compilation_unit_complaint)
7094         (read_dbx_symtab, process_one_symbol): Update.
7095         * gdbtypes.c (stub_noname_complaint): Update.
7096         * windows-nat.c (handle_unload_dll): Update.
7097         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
7098         (decode_base_type): Update.
7099         * xcoffread.c (bf_notfound_complaint, ef_complaint)
7100         (eb_complaint, record_include_begin, record_include_end)
7101         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
7102         (process_xcoff_symbol, read_symbol)
7103         (function_outside_compilation_unit_complaint)
7104         (scan_xcoff_symtab): Update.
7105         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
7106         * buildsym.c (finish_block_internal, make_blockvector)
7107         (end_symtab_get_static_block, augment_type_symtab): Update.
7108         * dtrace-probe.c (dtrace_process_dof)
7109         (dtrace_static_probe_ops::get_probes): Update.
7110         * complaints.h (struct complaint): Don't declare.
7111         (symfile_complaints): Remove.
7112         (complaint_internal): Remove "complaints" parameter.
7113         (complaint): Likewise.
7114         (clear_complaints): Likewise.
7115         * symfile.c (syms_from_objfile_1, finish_new_objfile)
7116         (reread_symbols): Update.
7117         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
7118         (dwarf2_frame_cache, decode_frame_entry): Update.
7119         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
7120         * objc-lang.c (lookup_objc_class, lookup_child_selector)
7121         (info_selectors_command): Update.
7122         * macrotab.c (macro_include, check_for_redefinition)
7123         (macro_undef): Update.
7124         * objfiles.c (filter_overlapping_sections): Update.
7125         * stabsread.c (invalid_cpp_abbrev_complaint)
7126         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
7127         (define_symbol, error_type, read_type, rs6000_builtin_type)
7128         (stabs_method_name_from_physname, read_member_functions)
7129         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
7130         (attach_fields_to_type, complain_about_struct_wipeout)
7131         (read_range_type, read_args, common_block_start)
7132         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
7133         Update.
7134         * mdebugread.c (index_complaint, unknown_ext_complaint)
7135         (basic_type_complaint, bad_tag_guess_complaint)
7136         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
7137         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
7138         (parse_procedure, parse_lines)
7139         (function_outside_compilation_unit_complaint)
7140         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
7141         (bad_tag_guess_complaint, reg_value_complaint): Update.
7142         * cp-support.c (demangled_name_complaint): Update.
7143         * macroscope.c (sal_macro_scope): Update.
7144         * dwarf-index-write.c (class debug_names): Update.
7145
7146 2018-05-23  Tom Tromey  <tom@tromey.com>
7147
7148         * complaints.c (clear_complaints): Remove "noisy" parameter.
7149         * complaints.h (clear_complaints): Update.
7150         * symfile.c (syms_from_objfile_1, finish_new_objfile)
7151         (reread_symbols): Update.
7152
7153 2018-05-23  Tom Tromey  <tom@tromey.com>
7154
7155         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
7156         SUBSEQUENT_MESSAGE.
7157         (vcomplaint, clear_complaints): Update.
7158         (symfile_explanations): Remove some messages.
7159
7160 2018-05-23  Tom Tromey  <tom@tromey.com>
7161
7162         * complaints.c (internal_complaint): Remove.
7163         * complaints.h (internal_complaint): Remove.
7164
7165 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
7166
7167         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
7168
7169 2018-05-22  Pedro Alves  <palves@redhat.com>
7170
7171         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
7172         (remote_fileio_badfd, remote_fileio_return_errno)
7173         (remote_fileio_return_success, remote_fileio_func_open)
7174         (remote_fileio_func_open, remote_fileio_func_close)
7175         (remote_fileio_func_read, remote_fileio_func_write)
7176         (remote_fileio_func_lseek, remote_fileio_func_rename)
7177         (remote_fileio_func_unlink, remote_fileio_func_stat)
7178         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
7179         (remote_fileio_func_isatty, remote_fileio_func_system): Add
7180         remote_target parameter.
7181         (remote_fio_func_map) <func>: Add remote_target parameter.
7182         (do_remote_fileio_request, remote_fileio_request):
7183         * remote-fileio.h (remote_fileio_request):
7184         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
7185         remote_target parameter.
7186         (remote_notif_process, handle_notification): Adjust to pass down
7187         the remote.
7188         (remote_notif_state_allocate): Add remote_target parameter.  Save
7189         it.
7190         * remote-notif.h (struct remote_target): Forward declare.
7191         (struct notif_client) <parse, ack, can_get_pending_events>: Add
7192         remote_target parameter.
7193         (struct remote_notif_state) <remote>: New field.
7194         (remote_notif_ack, remote_notif_parse): Add remote_target
7195         parameter.
7196         (remote_notif_state_allocate, remote_notif_state_allocate): Add
7197         remote_target parameter.
7198         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
7199         (threads_listing_context, rmt_thread_action, protocol_feature)
7200         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
7201         (packet_result, struct threads_listing_context, remote_state):
7202         Move definitions and declarations higher up.
7203         (remote_target) <~remote_target>: Declare.
7204         (remote_download_command_source, remote_file_put, remote_file_get)
7205         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
7206         (remote_hostio_pread_vFile, remote_hostio_send_command)
7207         (remote_hostio_set_filesystem, remote_hostio_open)
7208         (remote_hostio_close, remote_hostio_unlink, remote_state)
7209         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
7210         (get_memory_write_packet_size, get_memory_read_packet_size)
7211         (append_pending_thread_resumptions, remote_detach_1)
7212         (append_resumption, remote_resume_with_vcont)
7213         (add_current_inferior_and_thread, wait_ns, wait_as)
7214         (process_stop_reply, remote_notice_new_inferior)
7215         (process_initial_stop_replies, remote_add_thread)
7216         (btrace_sync_conf, remote_btrace_maybe_reopen)
7217         (remove_new_fork_children, kill_new_fork_children)
7218         (discard_pending_stop_replies, stop_reply_queue_length)
7219         (check_pending_events_prevent_wildcard_vcont)
7220         (discard_pending_stop_replies_in_queue, stop_reply)
7221         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
7222         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
7223         (remote_interrupt_as, remote_interrupt_ns)
7224         (remote_get_noisy_reply, remote_query_attached)
7225         (remote_add_inferior, remote_current_thread, get_current_thread)
7226         (set_thread, set_general_thread, set_continue_thread)
7227         (set_general_process, write_ptid)
7228         (remote_unpack_thread_info_response, remote_get_threadinfo)
7229         (parse_threadlist_response, remote_get_threadlist)
7230         (remote_threadlist_iterator, remote_get_threads_with_ql)
7231         (remote_get_threads_with_qxfer)
7232         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
7233         (get_offsets, remote_check_symbols, remote_supported_packet)
7234         (remote_query_supported, remote_packet_size)
7235         (remote_serial_quit_handler, remote_detach_pid)
7236         (remote_vcont_probe, remote_resume_with_hc)
7237         (send_interrupt_sequence, interrupt_query)
7238         (remote_notif_get_pending_events, fetch_register_using_p)
7239         (send_g_packet, process_g_packet, fetch_registers_using_g)
7240         (store_register_using_P, store_registers_using_G)
7241         (set_remote_traceframe, check_binary_download)
7242         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
7243         (remote_xfer_live_readonly_partial, remote_read_bytes)
7244         (remote_send_printf, remote_flash_write, readchar)
7245         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
7246         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
7247         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
7248         (extended_remote_disable_randomization, extended_remote_run)
7249         (send_environment_packet, extended_remote_environment_support)
7250         (extended_remote_set_inferior_cwd, remote_write_qxfer)
7251         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
7252         (packet_command): Now methods of ...
7253         (remote_target): ... this class.
7254         (m_remote_state) <remote_target>: New field.
7255         (struct remote_state) <stop_reply_queue,
7256         remote_async_inferior_event_token, wait_forever_enabled_p>: New
7257         fields.
7258         (remote_state::remote_state): Allocate stop_reply_queue.
7259         (remote_state): Delete global.
7260         (get_remote_state_raw): Delete.
7261         (remote_target::get_remote_state): Allocate m_remote_state on
7262         demand.
7263         (get_current_remote_target): New.
7264         (remote_ops, extended_remote_ops): Delete.
7265         (wait_forever_enabled_p, remote_async_inferior_event_token):
7266         Delete, moved to struct remote_state.
7267         (remote_target::close): Delete self.  Destruction bits split to
7268         ...
7269         (remote_target::~remote_target): ... this.
7270         (show_memory_packet_size): Adjust to use
7271         get_current_remote_target.
7272         (struct protocol_feature) <func>: Add remote_target parameter.
7273         All callers adjusted.
7274         (curr_quit_handler_target): New.
7275         (remote_serial_quit_handler): Reimplement.
7276         (remote_target::open_1): Adjust to use get_current_remote_target.
7277         Heap-allocate remote_target/extended_remote_target instances.
7278         (vcont_builder::vcont_builder): Add remote_target parameter, and
7279         save it in m_remote.  All callers adjusted.
7280         (vcont_builder::m_remote): New field.
7281         (vcont_builder::restart, vcont_builder::flush)
7282         (vcont_builder::push_action): Use it.
7283         (remote_target::commit_resume): Use it.
7284         (struct queue_iter_param) <remote>: New field.
7285         (remote_target::remove_new_fork_children): Fill in 'remote' field.
7286         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
7287         (check_pending_event_prevents_wildcard_vcont_callback)
7288         (remote_target::check_pending_events_prevent_wildcard_vcont)
7289         (remote_target::discard_pending_stop_replies)
7290         (remote_target::discard_pending_stop_replies_in_queue)
7291         (remote_target::remote_notif_remove_queued_reply): Fill in
7292         'remote' field.
7293         (remote_notif_get_pending_events): New.
7294         (remote_target::readchar, remote_target::remote_serial_write):
7295         Save/restore curr_quit_handler_target.
7296         (putpkt): New.
7297         (kill_new_fork_children): Fill in 'remote' field.
7298         (packet_command): Use get_current_remote_target, defer to
7299         remote_target method of same name.
7300         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
7301         parameter, and save it in m_remote.  All callers adjusted.
7302         (scoped_remote_fd::release): Use m_remote.
7303         (scoped_remote_fd::m_remote): New field.
7304         (remote_file_put, remote_file_get, remote_file_delete): Use
7305         get_current_remote_target, defer to remote_target method of same
7306         name.
7307         (remote_btrace_reset): Add remote_state paremeter.  Update all
7308         callers.
7309         (remote_async_inferior_event_handler). Pass down 'data'.
7310         (remote_new_objfile): Use get_current_remote_target.
7311         (remote_target::vcont_r_supported): New.
7312         (set_range_stepping): Use get_current_remote_target and
7313         remote_target::vcont_r_supported.
7314         (_initialize_remote): Don't allocate 'remote_state' and
7315         'stop_reply_queue' globals.
7316         * remote.h (struct remote_target): Forward declare.
7317         (getpkt, putpkt, remote_notif_get_pending_events): Add
7318         'remote_target' parameter.
7319
7320 2018-05-22  Pedro Alves  <palves@redhat.com>
7321
7322         * remote.c (vcont_builder): Now a class.  Make all data members
7323         private.
7324         (vcont_builder) <vcont_builder, restart, flush, push_action>:
7325         Declare methods.
7326         (vcont_builder_restart): Rename to ...
7327         (vcont_builder::restart): ... this.
7328         (vcont_builder_flush): Rename to ...
7329         (vcont_builder::flush): ... this.
7330         (vcont_builder_push_action): Rename to ...
7331         (vcont_builder::push_action): ... this.
7332         (remote_target::commit_resume): Adjust.
7333
7334 2018-05-22  Pedro Alves  <palves@redhat.com>
7335
7336         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
7337         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
7338         (get_fixed_memory_packet_size): New.
7339         (get_memory_packet_size): Use it.
7340         (set_memory_packet_size): Don't override the config size with
7341         DEFAULT_MAX_MEMORY_PACKET_SIZE.
7342         (show_memory_packet_size): Use get_fixed_memory_packet_size.
7343         Don't refer to get_memory_packet_size if not connected to a remote
7344         target.  Show "(default)" if configured size is 0.
7345
7346 2018-05-22  Pedro Alves  <palves@redhat.com>
7347
7348         * remote.c (remote_target::mourn_inferior): Move
7349         discard_pending_stop_replies call here from ...
7350         (_initialize_remote): ... here.
7351
7352 2018-05-22  Pedro Alves  <palves@redhat.com>
7353
7354         * remote.c (compare_section_command): Remove set_general_process
7355         call.
7356
7357 2018-05-22  Pedro Alves  <palves@redhat.com>
7358
7359         * remote.c (struct packet_reg, struct remote_arch_state):
7360         Move higher up in the file.
7361         (remote_state) <m_arch_states>: Store remote_arch_state values
7362         instead of remote_arch_state pointers.
7363         (remote_state::get_remote_arch_state): Adjust.
7364
7365 2018-05-22  Pedro Alves  <palves@redhat.com>
7366
7367         * remote.c: Include <unordered_map>.
7368         (remote_state): Now a class.
7369         (remote_state) <get_remote_arch_state>: Declare method.
7370         <get_remote_arch_state>: New field.
7371         (remote_arch_state) <remote_arch_state>: Declare ctor.
7372         <regs>: Now a unique_ptr.
7373         (remote_gdbarch_data_handle): Delete.
7374         (get_remote_arch_state): Delete.
7375         (remote_state::get_remote_arch_state): New.
7376         (get_remote_state): Adjust to call remote_state's
7377         get_remote_arch_state method.
7378         (init_remote_state): Delete, bits factored out to ...
7379         (remote_arch_state::remote_arch_state): ... this new method.
7380         (get_remote_packet_size, get_memory_packet_size)
7381         (process_g_packet, remote_target::fetch_registers)
7382         (remote_target::prepare_to_store, store_registers_using_G)
7383         (remote_target::store_registers, remote_target::get_trace_status):
7384         Adjust to call remote_state's method.
7385         (_initialize_remote): Remove reference to
7386         remote_gdbarch_data_handle.
7387
7388 2018-05-22  Pedro Alves  <palves@redhat.com>
7389
7390         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
7391         pread>: New method declarations.
7392         (remote_target::open_1): Adjust.
7393         (readahead_cache_invalidate): Rename to ...
7394         (readahead_cache::invalidate): ... this, and adjust to be a class
7395         method.
7396         (readahead_cache_invalidate_fd): Rename to ...
7397         (readahead_cache::invalidate_fd): ... this, and adjust to be a
7398         class method.
7399         (remote_hostio_pwrite): Adjust.
7400         (remote_hostio_pread_from_cache): Rename to ...
7401         (readahead_cache::pread): ... this, and adjust to be a class
7402         method.
7403         (remote_hostio_close): Adjust.
7404
7405 2018-05-22  Pedro Alves  <palves@redhat.com>
7406
7407         * remote.c (remote_hostio_close_cleanup): Delete.
7408         (class scoped_remote_fd): New.
7409         (remote_file_put, remote_file_get): Use it.
7410
7411 2018-05-22  Pedro Alves  <palves@redhat.com>
7412
7413         (struct vCont_action_support): Use bool and initialize all fields.
7414         (struct readahead_cache): Initialize all fields.
7415         (remote_state): Use bool and initialize all fields.
7416         (remote_state::remote_state, remote_state::~remote_state): New.
7417         (new_remote_state): Delete.
7418         (_initialize_remote): Use new to allocate remote_state.
7419
7420 2018-05-22  Pedro Alves  <palves@redhat.com>
7421             張俊芝  <zjz@zjz.name>
7422
7423         PR gdb/22973
7424         * c-exp.y: Include "c-support.h".
7425         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
7426         of tolower.  Use c_ident_is_alpha to scan names.
7427         * c-lang.c: Include "c-support.h".
7428         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
7429         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
7430         * c-support.h: New file, with bits factored out from ...
7431         * cp-name-parser.y: ... this file.
7432         Include "c-support.h".
7433         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
7434         c-support.h and renamed.
7435         (symbol_end, yylex): Adjust.
7436
7437 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
7438
7439         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
7440         parameter type to CORE_ADDR.
7441         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
7442         parameter type in declaration to CORE_ADDR.
7443         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
7444         target_auxv_search to get AT_HWCAP and use the result to get the
7445         target description.
7446         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
7447         to CORE_ADDR. Remove the cast of the return value to unsigned
7448         long. Fix error predicate of target_auxv_search.
7449         (ppc_linux_nat_target::read_description): Change the type of the
7450         hwcap variable to CORE_ADDR.
7451
7452 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
7453
7454         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
7455         if the size of fpscr is larger than 32 bits.
7456
7457 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
7458
7459         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
7460         (ppc32_linux_vsxregmap): New global.
7461         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
7462         regcache_supply_regset, and regcache_collect_regset.
7463         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
7464         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
7465         (fetch_vsx_register, store_vsx_register): Remove.
7466         (fetch_vsx_registers): Add regno parameter. Get regset using
7467         ppc_linux_vsxregset. Use regset to supply registers.
7468         (store_vsx_registers): Add regno parameter. Get regset using
7469         ppc_linux_vsxregset. Use regset to collect registers.
7470         (fetch_register): Call fetch_vsx_registers instead of
7471         fetch_vsx_register.
7472         (store_register): Call store_vsx_registers instead of
7473         store_vsx_register.
7474         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
7475         new regno parameter.
7476         (store_ppc_registers): Call store_vsx_registers with -1 for the
7477         new regno parameter.
7478         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
7479         (ppc_collect_vsxregset): Remove.
7480
7481 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
7482
7483         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
7484         offset fields.
7485         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
7486         for vector register offset fields.
7487         (ppc64_fbsd_reg_offsets): Likewise.
7488         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
7489         to vector register offset fields.
7490         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
7491         to vector register offset fields.
7492         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
7493         vector register offset fields.
7494         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
7495         initializers for vector register offset fields.
7496         (rs6000_aix64_reg_offsets): Likewise.
7497         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
7498         (ppc_supply_vrregset): Remove.
7499         (ppc_collect_vrregset): Remove.
7500         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
7501         (ppc_linux_vrregset) : New function.
7502         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
7503         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
7504         (ppc32_linux_vrregset): Remove.
7505         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
7506         and use result instead of ppc32_linux_vrregset.
7507         (ppc32_linux_reg_offsets): Remove initializers for vector register
7508         offset fields.
7509         (ppc64_linux_reg_offsets): Likewise.
7510         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
7511         * ppc-linux-nat.c: Include regset.h.
7512         (gdb_vrregset_t): Adjust comment to account for little-endian
7513         mode.
7514         (supply_vrregset, fill_vrregset): Remove.
7515         (fetch_altivec_register, store_altivec_register): Remove.
7516         (fetch_altivec_registers): Add regno parameter. Get regset using
7517         ppc_linux_vrregset. Use regset to supply registers.
7518         (store_altivec_registers): Add regno parameter. Get regset using
7519         ppc_linux_vrregset. Use regset to collect registers.
7520         (fetch_register): Call fetch_altivec_registers instead of
7521         fetch_altivec_register.
7522         (store_register): Call store_altivec_registers instead of
7523         store_altivec_register.
7524         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
7525         the new regno parameter.
7526         (store_ppc_registers): Call store_altivec_registers with -1 for
7527         the new regno parameter.
7528
7529 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
7530
7531         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
7532         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
7533         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
7534         (gdb_vrregset_t): Change array type size to
7535         PPC_LINUX_SIZEOF_VRREGSET.
7536         (gdb_vsxregset_t): Change array type size to
7537         PPC_LINUX_SIZEOF_VSXREGSET.
7538         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
7539         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
7540         PPC_LINUX_SIZEOF_VSXREGSET.
7541
7542 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
7543
7544         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
7545         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
7546         nat/ppc-linux.c.
7547         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
7548         ppc_linux_target_wordsize with tid.
7549         (ppc_linux_nat_target::read_description): Call ppc_linux_target
7550         wordsize with tid.
7551         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
7552         (ppc64_64bit_inferior_p): Add static and inline specifiers.
7553         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
7554         tid parameter. Remove static specifier.
7555         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
7556         (ppc_linux_target_wordsize): New declaration.
7557
7558 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
7559
7560         * arch/ppc-linux-common.c: New file.
7561         * arch/ppc-linux-common.h: New file.
7562         * arch/ppc-linux-tdesc.h: New file.
7563         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
7564         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
7565         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
7566         arch/ppc-linux-tdesc.h.
7567         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
7568         arch/ppc-linux-tdesc.h.
7569         (ppc_linux_nat_target::read_description): Remove target
7570         description matching code. Fill a ppc_linux_features struct and
7571         call ppc_linux_match_description with it. Move comment about ISA
7572         2.05 to ppc-linux-common.c.
7573         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
7574         arch/ppc-linux-tdesc.h.
7575         (ppc_linux_core_read_description): Remove target description
7576         matching code. Fill a ppc_linux_features struct and call
7577         ppc_linux_match_description with it.
7578         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
7579         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
7580         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
7581         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
7582         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
7583         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
7584         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
7585         (tdesc_powerpc_e500l): Remove.
7586
7587 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
7588
7589         * ada-lang.c (catch_assert_command): Pass empty string instead
7590         of NULL for excep_string argument.
7591
7592 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
7593
7594         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
7595         the width of the requested register exceeds the width of the
7596         `ptrace' data type.
7597
7598 2018-05-21  Tom Tromey  <tom@tromey.com>
7599
7600         * printcmd.c (output_command): Remove.
7601         (output_command_const): Rename to output_command.
7602         * valprint.h (output_command): Rename from output_command_const.
7603         * tracepoint.c (trace_dump_actions): Call output_command.
7604
7605 2018-05-21  Tom Tromey  <tom@tromey.com>
7606
7607         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
7608         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
7609         * ada-lang.h (create_ada_exception_catchpoint): Update.
7610         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
7611         std::string.
7612         (create_excep_cond_exprs, ~ada_catchpoint)
7613         (should_stop_exception, print_one_exception)
7614         (print_mention_exception, print_recreate_exception): Update.
7615         (ada_get_next_arg): Remove.
7616         (catch_ada_exception_command_split): Use std::string.  Change type
7617         of "excep_string", "cond_string".
7618         (catch_ada_exception_command): Update.
7619         (create_ada_exception_catchpoint): Change type of excep_string.
7620         (ada_exception_sal): Remove excep_string parameter.
7621         (~ada_catchpoint): Remove.
7622
7623 2018-05-21  Tom Tromey  <tom@tromey.com>
7624
7625         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
7626         cleanup.
7627
7628 2018-05-21  Tom Tromey  <tom@tromey.com>
7629
7630         * ada-lang.c (ada_exception_message_1, ada_exception_message):
7631         Return unique_xmalloc_ptr.
7632         (print_it_exception): Update.
7633
7634 2018-05-21  Tom Tromey  <tom@tromey.com>
7635
7636         * tracepoint.c (trace_dump_actions): Use std::string.
7637
7638 2018-05-21  Tom Tromey  <tom@tromey.com>
7639
7640         * symfile.c (reread_symbols): Use std::string for original_name.
7641
7642 2018-05-21  Tom Tromey  <tom@tromey.com>
7643
7644         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
7645         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
7646         constructor.
7647
7648 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
7649
7650         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
7651         instance to...
7652         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
7653         * objfiles.c (get_objfile_bfd_data): Allocate
7654         objfile_per_bfd_storage with obstack_new when allocating on
7655         obstack.
7656
7657 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
7658
7659         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
7660         OBSTACK_ZALLOC.
7661         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
7662         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
7663         * mdebugread.c (mdebug_build_psymtabs): Likewise.
7664         (add_pending): Likewise.
7665         (parse_symbol): Likewise.
7666         (parse_partial_symbols): Likewise.
7667         (psymtab_to_symtab_1): Likewise.
7668         (new_psymtab): Likewise.
7669         (elfmdebug_build_psymtabs): Likewise.
7670         * minsyms.c (terminate_minimal_symbol_table): Likewise.
7671         * objfiles.c (get_objfile_bfd_data): Likewise.
7672         (objfile_register_static_link): Likewise.
7673         * psymtab.c (allocate_psymtab): Likewise.
7674         * stabsread.c (read_member_functions): Likewise.
7675         * xcoffread.c (xcoff_end_psymtab): Likewise.
7676
7677 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
7678
7679         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
7680         compiler supports std::is_trivially_constructible.
7681         * common/poison.h: Include obstack.h.
7682         (IsMallocable): Define to is_trivially_constructible if the
7683         compiler supports it, define to true_type otherwise.
7684         (xobnew): New.
7685         (XOBNEW): Redefine.
7686         (xobnewvec): New.
7687         (XOBNEWVEC): Redefine.
7688         * gdb_obstack.h (obstack_zalloc): New.
7689         (OBSTACK_ZALLOC): Redefine.
7690         (obstack_calloc): New.
7691         (OBSTACK_CALLOC): Redefine.
7692         (obstack_new): New.
7693         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
7694         (gdbarch_obstack): New declaration in gdbarch.h, definition in
7695         gdbarch.c.
7696         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
7697         obstack_calloc/obstack_zalloc.
7698         (gdbarch_obstack_zalloc): Remove.
7699         * target-descriptions.c (tdesc_data_init): Use obstack_new.
7700
7701 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7702
7703         * stack.c (backtrace_command_1): Remove useless variable int i.
7704
7705 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7706
7707         * stack.c (print_frame_info): Fix comment.
7708
7709 2018-05-18  Tom Tromey  <tom@tromey.com>
7710
7711         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
7712         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
7713         (~dwarf2_per_objfile): Update
7714         (dwarf2_get_dwz_file): Use new.
7715         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
7716         unique_ptr.
7717
7718 2018-05-18  Tom Tromey  <tom@tromey.com>
7719
7720         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
7721         unique_ptr.
7722         * dwarf2read.c (struct dwp_file): Add constructor and
7723         initializers.
7724         (open_and_init_dwp_file): Return a unique_ptr.
7725         (dwarf2_per_objfile, create_dwp_hash_table)
7726         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
7727         (lookup_dwo_unit_in_dwp): Update.
7728         (open_and_init_dwp_file, get_dwp_file): Update.
7729
7730 2018-05-18  Tom Tromey  <tom@tromey.com>
7731
7732         * dwarf2read.c (dwarf2_per_objfile): Update.
7733         (struct mapped_index): Add initializers.
7734         (dwarf2_read_index): Use new.
7735         (dw2_symtab_iter_init): Update.
7736         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
7737         unique_ptr.
7738
7739 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
7740
7741         * dwarf2read.c (mapped_index) <total_size>: Remove.
7742
7743 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
7744
7745         * unittests/format_pieces-selftests.c (test_format_specifier):
7746         Add ARI comments.
7747
7748 2018-05-18  Tom Tromey  <tom@tromey.com>
7749
7750         * c-typeprint.c (maybe_print_hole): New function.
7751         (c_print_type_struct_field_offset): Update.
7752         (c_type_print_base_struct_union): Call maybe_print_hole.
7753
7754 2018-05-17  Keith Seitz  <keiths@redhat.com>
7755
7756         * breakpoint.c (build_bpstat_chain): New function, moved from
7757         bpstat_stop_status.
7758         (bpstat_stop_status): Add optional parameter, `stop_chain'.
7759         If no stop chain is passed, call build_bpstat_chain to build it.
7760         * breakpoint.h (build_bpstat_chain): Declare.
7761         (bpstat_stop_status): Move documentation here from breakpoint.c.
7762         * infrun.c (handle_signal_stop): Before eliding inlined frames,
7763         build the stop chain and pass it to skip_inline_frames.
7764         Pass this stop chain to bpstat_stop_status.
7765         * inline-frame.c: Include breakpoint.h.
7766         (stopped_by_user_bp_inline_frame): New function.
7767         (skip_inline_frames): Add parameter `stop_chain'.
7768         Move documention to inline-frame.h.
7769         If non-NULL, use stopped_by_user_bp_inline_frame to determine
7770         whether the frame should be elided.
7771         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
7772         Add moved documentation and update for new parameter.
7773
7774 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
7775
7776         PR cli/14975
7777         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7778         unittests/format_pieces-selftests.c.
7779         * common/format.h (format_piece) <operator==>: New.
7780         (format_pieces) <operator[]>: Remove.
7781         * common/format.c (format_pieces::format_pieces): Handle \e.
7782         * unittests/format_pieces-selftests.c: New.
7783
7784 2018-05-17  Tom Tromey  <tom@tromey.com>
7785
7786         PR symtab/23010:
7787         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
7788         (dw2_instantiate_symtab): Add skip_partial parameter.
7789         (dw2_find_last_source_symtab, dw2_map_expand_apply)
7790         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
7791         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
7792         (dw2_expand_symtabs_matching_one)
7793         (dw2_find_pc_sect_compunit_symtab)
7794         (dw2_debug_names_lookup_symbol)
7795         (dw2_debug_names_expand_symtabs_for_function): Update.
7796         (init_cutu_and_read_dies): Add skip_partial parameter.
7797         (process_psymtab_comp_unit, build_type_psymtabs_1)
7798         (process_skeletonless_type_unit, load_partial_comp_unit)
7799         (psymtab_to_symtab_1): Update.
7800         (load_full_comp_unit): Add skip_partial parameter.
7801         (process_imported_unit_die, dwarf2_read_addr_index)
7802         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
7803         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
7804         (read_signatured_type): Update.
7805
7806 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
7807
7808         * value.c (release_value): Remove unused variable.
7809         (record_latest_value): Likewise.
7810         (access_value_history): Likewise.
7811         (preserve_values): Likewise.
7812
7813 2018-05-17  Tom Tromey  <tom@tromey.com>
7814
7815         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
7816         Initialize.
7817
7818 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
7819
7820         PR gdb/22286
7821         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
7822         Also handle registers whose width is not a multiple of
7823         PTRACE_TYPE_RET.
7824         (linux_nat_trad_target::store_register): Likewise.
7825
7826 2018-05-16  Tom Tromey  <tom@tromey.com>
7827
7828         * gdbcore.h (core_bfd): Redefine.
7829         * corelow.c (core_target::close): Update.
7830         (core_target_open): Update.
7831         * progspace.h (struct program_space) <cbfd>: Now a
7832         gdb_bfd_ref_ptr.
7833
7834 2018-05-16  Tom Tromey  <tom@tromey.com>
7835
7836         PR cli/19551:
7837         * symfile-add-flags.h (enum symfile_add_flags)
7838         <SYMFILE_NOT_FILENAME>: New constant.
7839         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
7840         objfile name from BFD.
7841         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
7842         * minidebug.c (find_separate_debug_file_in_section): Put
7843         ".gnu_debugdata" into BFD's file name.
7844
7845 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
7846
7847         * regcache.c (regcache_read_ftype, regcache_write_ftype):
7848         Remove.
7849
7850 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
7851
7852         PR binutils/21446
7853         * aarch64-tdep.c (aarch64_analyze_prologue,
7854         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
7855         Indicate not interested in errors.
7856
7857 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
7858
7859         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
7860         Supply the MIPS_ZERO_REGNUM register.
7861
7862 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
7863
7864         * mips-tdep.c (mask_address_var): Make variable static.
7865
7866 2018-05-14  Tom Tromey  <tom@tromey.com>
7867
7868         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
7869
7870 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7871
7872         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
7873         FXSAVE_ADDR for the mxcsr register.
7874
7875 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
7876
7877         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
7878
7879 2018-05-11  Pedro Alves  <palves@redhat.com>
7880
7881         * corelow.c (core_target) <core_target>: No longer inline.
7882         Initialize m_core_gdbarch, m_core_vec and build the section table
7883         here.
7884         <~core_target>: New.
7885         <core_gdbarch, get_core_register_section>: New methods.
7886         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
7887         factored out from ...
7888         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
7889         (core_ops): Delete.
7890         (sniff_core_bfd): Add gdbarch parameter.
7891         (core_close): Delete, merged into ...
7892         (core_target::close): ... here.  Delete self.
7893         (core_close_cleanup): Delete.
7894         (core_target_open): Allocate a core_target on the heap.  Use a
7895         unique_ptr instead of a cleanup.  Bits moved into the core_target
7896         ctor.  Adjust to use core_target methods instead of globals.
7897         (get_core_register_section): Rename to ...
7898         (core_target::get_core_register_section): ... this and adjust.
7899         (struct get_core_registers_cb_data): New.
7900         (get_core_registers_cb): Use it.  Use bool.
7901         (core_target::fetch_registers, core_target::files_info)
7902         (core_target::xfer_partial, core_target::read_description)
7903         (core_target::pid_to, core_target::thread_name): Adjust to
7904         reference class fields instead of globals.
7905         * target.h (struct target_ops_deleter, target_ops_up): New.
7906
7907 2018-05-11  Pedro Alves  <palves@redhat.com>
7908
7909         * corefile.c (core_file_command): Move to corelow.c.
7910         * corelow.c (the_core_target): Delete.
7911         (core_file_command): Moved from corefile.c.  Check exec_bfd
7912         instead of the_core_target.  Use target_detach instead of calling
7913         into the_core_target directly.
7914         (maybe_say_no_core_file_now): New.
7915         (core_target::detach): Use it.
7916         (_initialize_corelow): Remove references to the_core_target.
7917         * gdbcore.h (the_core_target): Delete.
7918
7919 2018-05-11  Tom Tromey  <tromey@redhat.com>
7920             Pedro Alves  <palves@redhat.com>
7921
7922         * corefile.c (core_bfd): Remove.
7923         * gdbcore.h (core_bfd): Now a macro.
7924         * progspace.h (struct program_space) <cbfd>: New field.
7925
7926 2018-05-11  Tom Tromey  <tom@tromey.com>
7927
7928         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
7929         gdb::def_vector.
7930
7931 2018-05-10  Tom Tromey  <tom@tromey.com>
7932
7933         * configure: Rebuild.
7934         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
7935
7936 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
7937
7938         PR server/23158:
7939         * regformats/regdat.sh: Adjust script, following the addition
7940         of the new expedite_regs parameter to init_target_desc.
7941
7942 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
7943
7944         PR gdb/23127
7945         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
7946         set_gdbarch_significant_addr_bit.
7947         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
7948         set_gdbarch_significant_addr_bit.
7949         * utils.c (address_significant): Update to sign extend addr.
7950
7951 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
7952
7953         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
7954         (xtensa_linux_init_abi): Limit tdep->num_regs by
7955         tdep->num_nopriv_regs.
7956         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
7957         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
7958         not initialized.
7959
7960 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
7961
7962         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
7963
7964 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
7967         (I387_MXCSR_INIT_VAL): New constant.
7968         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
7969         buffer if it was supplied by the inferior.
7970         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
7971         (i387_xsave_get_clear_bv): New function.
7972         (i387_supply_xsave): Only read x87 control registers from the
7973         xsave buffer if the feature is enabled, and the state will have
7974         been written, otherwise, provide a suitable default.
7975         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
7976         including x87 control registers.  Update control registers if they
7977         have changed from the default value, and mark features as enabled
7978         as required.
7979         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
7980
7981 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
7982
7983         * spu-tdep.c (info_spu_event_command): Fix output formatting.
7984
7985 2018-05-07  Tom Tromey  <tom@tromey.com>
7986
7987         * configure: Rebuild.
7988         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
7989
7990 2018-05-07  Tom Tromey  <tom@tromey.com>
7991
7992         PR tdep/20362:
7993         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
7994         bit.  Use correct value for VDIV.
7995
7996 2018-05-04  Tom Tromey  <tom@tromey.com>
7997
7998         * configure: Rebuild.
7999         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
8000
8001 2018-05-04  Tom Tromey  <tom@tromey.com>
8002
8003         * linux-record.c (record_linux_system_call) <case
8004         RECORD_SYS_RECVFROM>: Add "break".
8005
8006 2018-05-04  Tom Tromey  <tom@tromey.com>
8007
8008         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
8009         Add missing "break".
8010         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
8011         Add missing "break".
8012
8013 2018-05-04  Tom Tromey  <tom@tromey.com>
8014
8015         * rs6000-tdep.c (ppc_process_record_op4)
8016         (ppc_process_record_op63): Add fall-through comment.
8017
8018 2018-05-04  Tom Tromey  <tom@tromey.com>
8019
8020         * i386-tdep.c (i386_process_record): Add fall-through comment.
8021
8022 2018-05-04  Tom Tromey  <tom@tromey.com>
8023
8024         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
8025         comment.
8026
8027 2018-05-04  Tom Tromey  <tom@tromey.com>
8028
8029         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
8030         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
8031         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
8032         comment.
8033         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
8034         comment.
8035         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
8036         comment.
8037
8038 2018-05-04  Tom Tromey  <tom@tromey.com>
8039
8040         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
8041
8042 2018-05-04  Tom Tromey  <tom@tromey.com>
8043
8044         * s390-tdep.c (s390_process_record): Fix fall-through comments.
8045         * xcoffread.c (scan_xcoff_symtab): Move comment later.
8046         * symfile.c (section_is_mapped): Fix fall-through comment.
8047         * stabsread.c (define_symbol, read_member_functions): Fix
8048         fall-through comment.
8049         * s390-linux-tdep.c (s390_process_record): Fix fall-through
8050         comment.
8051         * remote.c (remote_wait_as): Fix fall-through comment.
8052         * p-exp.y (yylex): Fix fall-through comment.
8053         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
8054         comment.
8055         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
8056         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
8057         * jv-exp.y (yylex): Fix fall-through comment.
8058         * go-exp.y (lex_one_token): Fix fall-through comment.
8059         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
8060         fall-through comment.
8061         * f-exp.y (yylex): Fix fall-through comment.
8062         * dwarf2read.c (process_die): Fix fall-through comments.
8063         * dbxread.c (process_one_symbol): Fix fall-through comment.
8064         * d-exp.y (lex_one_token): Fix fall-through comment.
8065         * cp-name-parser.y (yylex): Fix fall-through comment.
8066         * coffread.c (coff_symtab_read): Fix fall-through comment.
8067         * c-exp.y (lex_one_token): Fix fall-through comment.
8068         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
8069         comment.
8070         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
8071         comment.
8072
8073 2018-05-04  Tom Tromey  <tom@tromey.com>
8074
8075         PR python/22730:
8076         * NEWS: Mention gdb.execute change.
8077         * gdbcmd.h (execute_control_command): Don't declare.
8078         * python/python.c (execute_gdb_command): Use read_command_lines_1,
8079         execute_control_commands, execute_control_commands_to_string.
8080         * cli/cli-script.h (execute_control_commands)
8081         (execute_control_commands_to_string): Declare.
8082         (execute_control_command): Add from_tty parameter.
8083         * cli/cli-script.c (execute_control_commands)
8084         (execute_control_commands_to_string): New functions.
8085         (execute_user_command): Use execute_control_commands.
8086         (execute_control_command_1): Add "from_tty" parameter.  Update.
8087         (execute_control_command): Likewise.
8088
8089 2018-05-04  Tom Tromey  <tom@tromey.com>
8090
8091         PR python/22731:
8092         * NEWS: Mention that breakpoint commands are writable.
8093         * python/py-breakpoint.c (bppy_set_commands): New function.
8094         (breakpoint_object_getset) <"commands">: Use it.
8095
8096 2018-05-04  Tom Tromey  <tom@tromey.com>
8097
8098         * tracepoint.c (actions_command): Update.
8099         * mi/mi-cmd-break.c (mi_command_line_array)
8100         (mi_command_line_array_cnt, mi_command_line_array_ptr)
8101         (mi_read_next_line): Remove.
8102         (mi_cmd_break_commands): Update.
8103         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
8104         function_view.
8105         * cli/cli-script.c (get_command_line): Update.
8106         (process_next_line): Use function_view.  Constify.
8107         (recurse_read_control_structure, read_command_lines)
8108         (read_command_lines_1): Change argument types to function_view.
8109         (do_define_command, document_command): Update.
8110         * breakpoint.h (check_tracepoint_command): Don't declare.
8111         * breakpoint.c (check_tracepoint_command): Remove.
8112         (commands_command_1, create_tracepoint_from_upload): Update.
8113
8114 2018-05-04  Tom Tromey  <tom@tromey.com>
8115
8116         PR gdb/11750:
8117         * cli/cli-script.h (enum command_control_type) <define_control>:
8118         New constant.
8119         * cli/cli-script.c (multi_line_command_p): Handle define_control.
8120         (build_command_line, execute_control_command_1)
8121         (process_next_line): Likewise.
8122         (do_define_command): New function, extracted from define_command.
8123         (define_command): Use it.
8124
8125 2018-05-04  Tom Tromey  <tom@tromey.com>
8126
8127         * tracepoint.c (actions_command): Update.
8128         * cli/cli-script.h (read_command_lines): Update.
8129         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
8130         (MAX_TMPBUF): Remove define.
8131         (define_command): Use string_printf.
8132         (document_command): Likewise.
8133         * breakpoint.c (commands_command_1): Update.
8134
8135 2018-05-04  Tom Tromey  <tom@tromey.com>
8136
8137         * top.c (execute_command): Update.
8138         * cli/cli-script.h (print_command_lines): Now varargs.
8139         * cli/cli-script.c (print_command_lines): Now varargs.
8140         (execute_control_command_1) <case while_control, case if_control>:
8141         Update.
8142
8143 2018-05-04  Tom Tromey  <tom@tromey.com>
8144
8145         * tracepoint.c (all_tracepoint_actions): Rename from
8146         all_tracepoint_actions_and_cleanup.  Change return type.
8147         (actions_command, encode_actions_1, encode_actions)
8148         (trace_dump_actions, tdump_command): Update.
8149         * remote.c (remote_download_command_source): Update.
8150         * python/python.c (gdbpy_eval_from_control_command)
8151         (python_command, python_interactive_command): Update.
8152         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
8153         * guile/guile.c (guile_command)
8154         (gdbscm_eval_from_control_command, guile_command): Update.
8155         * compile/compile.c (compile_code_command)
8156         (compile_print_command, compile_to_object): Update.
8157         * cli/cli-script.h (struct command_lines_deleter): New.
8158         (counted_command_line): New typedef.
8159         (struct command_line): Add constructor, destructor.
8160         <body_list>: Remove.
8161         <body_list_0, body_list_1>: New members.
8162         (command_line_up): Remove typedef.
8163         (read_command_lines, read_command_lines_1, get_command_line):
8164         Update.
8165         (copy_command_lines): Don't declare.
8166         * cli/cli-script.c (build_command_line): Use "new".
8167         (get_command_line): Return counted_command_line.
8168         (print_command_lines, execute_user_command)
8169         (execute_control_command_1, while_command, if_command): Update.
8170         (realloc_body_list): Remove.
8171         (process_next_line, recurse_read_control_structure): Update.
8172         (read_command_lines, read_command_lines_1): Return counted_command_line.
8173         (free_command_lines): Use "delete".
8174         (copy_command_lines): Remove.
8175         (define_command, document_command, show_user_1): Update.
8176         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
8177         a counted_command_line.
8178         * breakpoint.h (counted_command_line): Remove typedef.
8179         (breakpoint_set_commands): Update.
8180         * breakpoint.c (check_no_tracepoint_commands)
8181         (validate_commands_for_breakpoint): Update.
8182         (breakpoint_set_commands): Change commands to be a
8183         counted_command_line.
8184         (commands_command_1, update_dprintf_command_list)
8185         (create_tracepoint_from_upload): Update.
8186
8187 2018-05-04  Tom Tromey  <tom@tromey.com>
8188
8189         * cli/cli-decode.h (cmd_list_element): New constructor.
8190         (~cmd_list_element): New destructor.
8191         (struct cmd_list_element): Add initializers.
8192         * cli/cli-decode.c (do_add_cmd): Use "new".
8193         (delete_cmd): Use "delete".
8194
8195 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
8196             Pedro Alves <palves@redhat.com>
8197
8198         PR breakpoints/19806 and support for PR external/20207.
8199         * NEWS: Mention Aarch64 watchpoint improvements.
8200         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
8201         watchpoints and PR external/20207 watchpoints.
8202         * nat/aarch64-linux-hw-point.c
8203         (kernel_supports_any_contiguous_range): New.
8204         (aarch64_watchpoint_offset): New.
8205         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
8206         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
8207         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
8208         (aarch64_align_watchpoint): New parameters aligned_offset_p and
8209         next_addr_orig_p.  Support PR external/20207 watchpoints.
8210         (aarch64_downgrade_regs): New.
8211         (aarch64_dr_state_insert_one_point): New parameters offset and
8212         addr_orig.
8213         (aarch64_dr_state_remove_one_point): Likewise.
8214         (aarch64_handle_breakpoint): Update caller.
8215         (aarch64_handle_aligned_watchpoint): Likewise.
8216         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
8217         aligned_offset.
8218         (aarch64_linux_set_debug_regs): Remove const from state.  Call
8219         aarch64_downgrade_regs.
8220         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
8221         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
8222         (DR_CONTROL_MASK): ... this.
8223         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
8224         (unsigned int aarch64_watchpoint_offset): New prototype.
8225         (aarch64_linux_set_debug_regs): Remove const from state.
8226         * utils.c (align_up, align_down): Move to ...
8227         * common/common-utils.c (align_up, align_down): ... here.
8228         * utils.h (align_up, align_down): Move to ...
8229         * common/common-utils.h (align_up, align_down): ... here.
8230
8231 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
8232
8233         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
8234         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
8235         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
8236         Re-implement to match the ABI as summarized in GCC's
8237         gcc/config/sparc/sparc.c.  All callers updated.
8238         (sparc32_store_arguments): Remove assertion.
8239
8240 2018-05-04  Tom Tromey  <tom@tromey.com>
8241
8242         * printcmd.c: Don't include tui.h.
8243         (decode_format): Use skip_spaces.
8244
8245 2018-05-04  Tom Tromey  <tom@tromey.com>
8246
8247         PR gdb/22619:
8248         * printcmd.c (last_count): New global.
8249         (x_command): Use saved count when repeating.
8250
8251 2018-05-04  Tom Tromey  <tom@tromey.com>
8252
8253         * nto-procfs.c (do_closedir_cleanup): Remove.
8254         (procfs_pidlist): Use gdb_dir_up.
8255         * procfs.c (do_closedir_cleanup): Remove.
8256         (proc_update_threads): Use gdb_dir_up.
8257         * common/filestuff.h (struct gdb_dir_deleter): New.
8258         (gdb_dir_up): New typedef.
8259
8260 2018-05-04  Tom Tromey  <tom@tromey.com>
8261
8262         * ada-lang.c (print_mention_exception): Use std::string.
8263
8264 2018-05-04  Tom Tromey  <tom@tromey.com>
8265
8266         * ada-lang.c (create_excep_cond_exprs): Update.
8267         (ada_exception_catchpoint_cond_string): Use std::string.
8268
8269 2018-05-04  Tom Tromey  <tom@tromey.com>
8270
8271         * ada-lang.c (xget_renaming_scope): Return std::string.
8272         (old_renaming_is_invisible): Update.
8273
8274 2018-05-04  Tom Tromey  <tom@tromey.com>
8275
8276         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
8277         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
8278
8279 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
8280
8281         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
8282
8283 2018-05-04  Tom Tromey  <tom@tromey.com>
8284
8285         * remote.c (remote_query_supported_append): Change type.
8286         (remote_check_symbols): Update.
8287
8288 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
8289
8290         PR gdb/11420
8291         * configure.ac: Prepend libpython.
8292         * python/python-config.py: Likewise.
8293         * configure: Regenerate.
8294
8295 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
8296
8297         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
8298
8299 2018-05-03  Pedro Alves  <palves@redhat.com>
8300
8301         * s390-linux-nat.c
8302         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
8303         override.  Write 'true' instead of '1'.
8304         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
8305         declaration.
8306
8307 2018-05-02  Pedro Alves  <palves@redhat.com>
8308
8309         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
8310         add_inf_child_target.
8311         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
8312         add_inf_child_target.
8313         * aix-thread.c (aix_thread_target_info): New.
8314         (aix_thread_target) <shortname, longname, doc>: Delete.
8315         <info>: New.
8316         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
8317         add_inf_child_target.
8318         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
8319         add_inf_child_target.
8320         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
8321         add_inf_child_target.
8322         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
8323         add_inf_child_target.
8324         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
8325         add_inf_child_target.
8326         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
8327         add_inf_child_target.
8328         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
8329         add_inf_child_target.
8330         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
8331         add_inf_child_target.
8332         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
8333         add_inf_child_target.
8334         * bfd-target.c (target_bfd_target_info): New.
8335         (target_bfd) <shortname, longname, doc>: Delete.
8336         <info>: New.
8337         * bsd-kvm.c (bsd_kvm_target_info): New.
8338         (bsd_kvm_target) <shortname, longname, doc>: Delete.
8339         <info>: New.
8340         (bsd_kvm_target::open): Rename to ...
8341         (bsd_kvm_target_open): ... this.  Adjust.
8342         * bsd-uthread.c (bsd_uthread_target_info): New.
8343         (bsd_uthread_target) <shortname, longname, doc>: Delete.
8344         <info>: New.
8345         * corefile.c (core_file_command): Adjust.
8346         * corelow.c (core_target_info): New.
8347         (core_target) <shortname, longname, doc>: Delete.
8348         <info>: New.
8349         (core_target::open): Rename to ...
8350         (core_target_open): ... this.  Adjust.
8351         * ctf.c (ctf_target_info): New.
8352         (ctf_target) <shortname, longname, doc>: Delete.
8353         <info>: New.
8354         (ctf_target::open): Rename to ...
8355         (ctf_target_open): ... this.
8356         (_initialize_ctf): Adjust.
8357         * exec.c (exec_target_info): New.
8358         (exec_target) <shortname, longname, doc>: Delete.
8359         <info>: New.
8360         (exec_target::open): Rename to ...
8361         (exec_target_open): ... this.
8362         * gdbcore.h (core_target_open): Declare.
8363         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
8364         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
8365         add_inf_child_target.
8366         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
8367         add_inf_child_target.
8368         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
8369         add_inf_child_target.
8370         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
8371         add_inf_child_target.
8372         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
8373         add_inf_child_target.
8374         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
8375         add_inf_child_target.
8376         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
8377         add_inf_child_target.
8378         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
8379         add_inf_child_target.
8380         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
8381         add_inf_child_target.
8382         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
8383         add_inf_child_target.
8384         * inf-child.c (inf_child_target_info): New.
8385         (inf_child_target::info): New.
8386         (inf_child_open_target): Remove 'target' parameter.  Use
8387         get_native_target instead.
8388         (inf_child_target::open): Delete.
8389         (add_inf_child_target): New.
8390         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
8391         Delete.
8392         <info>: New.
8393         (add_inf_child_target): Declare.
8394         (inf_child_open_target): Declare.
8395         * linux-thread-db.c (thread_db_target_info): New.
8396         (thread_db_target) <shortname, longname, doc>: Delete.
8397         <info>: New.
8398         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
8399         add_inf_child_target.
8400         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
8401         add_inf_child_target.
8402         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
8403         add_inf_child_target.
8404         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
8405         add_inf_child_target.
8406         * make-target-delegates (print_class): Adjust.
8407         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
8408         add_inf_child_target.
8409         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
8410         add_inf_child_target.
8411         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
8412         add_inf_child_target.
8413         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
8414         add_inf_child_target.
8415         * nto-procfs.c (nto_native_target_info): New.
8416         (nto_procfs_target_native) <shortname, longname, doc>:
8417         Delete.
8418         <info>: New.
8419         (nto_procfs_target_info): New.
8420         (nto_procfs_target_procfs) <shortname, longname, doc>:
8421         Delete.
8422         <info>: New.
8423         (init_procfs_targets): Adjust.
8424         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
8425         add_inf_child_target.
8426         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
8427         add_inf_child_target.
8428         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
8429         add_inf_child_target.
8430         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
8431         add_inf_child_target.
8432         * ravenscar-thread.c (ravenscar_target_info): New.
8433         (ravenscar_thread_target) <shortname, longname, doc>:
8434         Delete.
8435         <info>: New.
8436         * record-btrace.c (record_btrace_target_info):
8437         (record_btrace_target) <shortname, longname, doc>: Delete.
8438         <info>: New.
8439         (record_btrace_target::open): Rename to ...
8440         (record_btrace_target_open): ... this.  Adjust.
8441         * record-full.c (record_longname, record_doc): New.
8442         (record_full_base_target) <shortname, longname, doc>: Delete.
8443         <info>: New.
8444         (record_full_target_info): New.
8445         (record_full_target): <shortname>: Delete.
8446         <info>: New.
8447         (record_full_core_open_1, record_full_open_1): Update comments.
8448         (record_full_base_target::open): Rename to ...
8449         (record_full_open): ... this.
8450         (cmd_record_full_restore): Update.
8451         (_initialize_record_full): Update.
8452         * remote-sim.c (remote_sim_target_info): New.
8453         (gdbsim_target) <shortname, longname, doc>: Delete.
8454         <info>: New.
8455         (gdbsim_target::open): Rename to ...
8456         (gdbsim_target_open): ... this.
8457         (_initialize_remote_sim): Adjust.
8458         * remote.c (remote_doc): New.
8459         (remote_target_info): New.
8460         (remote_target) <shortname, longname, doc>: Delete.
8461         <info>: New.
8462         (extended_remote_target_info): New.
8463         (extended_remote_target) <shortname, longname, doc>: Delete.
8464         <info>: New.
8465         (remote_target::open_1): Make static.  Adjust.
8466         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
8467         * s390-linux-nat.c (_initialize_s390_nat): Use
8468         add_inf_child_target.
8469         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
8470         add_inf_child_target.
8471         * sol-thread.c (thread_db_target_info): New.
8472         (sol_thread_target) <shortname, longname, doc>: Delete.
8473         <info>: New.
8474         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
8475         add_inf_child_target.
8476         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
8477         add_inf_child_target.
8478         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
8479         add_inf_child_target.
8480         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
8481         add_inf_child_target.
8482         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
8483         add_inf_child_target.
8484         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
8485         add_inf_child_target.
8486         * spu-linux-nat.c (_initialize_spu_nat): Use
8487         add_inf_child_target.
8488         * spu-multiarch.c (spu_multiarch_target_info): New.
8489         (spu_multiarch_target) <shortname, longname, doc>: Delete.
8490         <info>: New.
8491         * target-delegates.c: Regenerate.
8492         * target.c: Include <unordered_map>.
8493         (target_ops_p): Delete.
8494         (DEF_VEC_P(target_ops_p)): Delete.
8495         (target_factories): New.
8496         (test_target_info): New.
8497         (test_target_ops::info): New.
8498         (open_target): Adjust to use target_factories.
8499         (add_target_with_completer): Rename to ...
8500         (add_target): ... this.  Change prototype.  Register target_info
8501         and open callback in target_factories.  Register target_info in
8502         command context instead of target_ops.
8503         (add_target): Delete old implementation.
8504         (add_deprecated_target_alias): Change prototype.  Adjust.
8505         (the_native_target): New.
8506         (set_native_target, get_native_target): New.
8507         (find_default_run_target): Use the_native_target.
8508         (find_attach_target, find_run_target): Simplify.
8509         (target_ops::open): Delete.
8510         (dummy_target_info): New.
8511         (dummy_target::shortname, dummy_target::longname)
8512         (dummy_target::doc): Delete.
8513         (dummy_target::info): New.
8514         (debug_target::shortname, debug_target::longname)
8515         (debug_target::doc): Delete.
8516         (debug_target::info): New.
8517         * target.h (struct target_info): New.
8518         (target_ops::~target_ops): Add comment.
8519         (target_ops::info): New.
8520         (target_ops::shortname, target_ops::longname, target_ops::doc): No
8521         longer virtual.  Implement in terms of target_info.
8522         (set_native_target, get_native_target): Declare.
8523         (target_open_ftype): New.
8524         (add_target, add_target_with_completer)
8525         (add_deprecated_target_alias): Change prototype.
8526         (test_target) <shortname, longname, doc>: Delete.
8527         <info>: New.
8528         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
8529         add_inf_child_target.
8530         * tracefile-tfile.c (tfile_target_info): New.
8531         (tfile_target) <shortname, longname, doc>: Delete.
8532         <info>: New.
8533         (tfile_target::open): Rename to ...
8534         (tfile_target_open): ... this.
8535         (_initialize_tracefile_tfile): Adjust.
8536         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
8537         add_inf_child_target.
8538         * windows-nat.c (_initialize_windows_nat): Use
8539         add_inf_child_target.
8540         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
8541         add_inf_child_target.
8542
8543 2018-05-02  Pedro Alves  <palves@redhat.com>
8544
8545         * linux-nat.h (linux_nat_target) <low_new_thread,
8546         low_delete_thread, low_new_fork, low_forget_process,
8547         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
8548         New virtual methods.
8549         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
8550         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
8551         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
8552         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
8553         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
8554         Delete.
8555         * linux-fork.c (delete_fork): Adjust to call low method.
8556         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
8557         (linux_nat_new_fork, linux_nat_forget_process_hook)
8558         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
8559         (linux_nat_status_is_event):
8560         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
8561         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
8562         to call low method.
8563         (sigtrap_is_event): Rename to ...
8564         (linux_nat_target::low_status_is_event): ... this.
8565         (linux_nat_set_status_is_event): Delete.
8566         (save_stop_reason, linux_nat_wait_1)
8567         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
8568         low methods.
8569         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
8570         (linux_nat_set_new_fork, linux_nat_set_forget_process)
8571         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
8572         (linux_nat_set_prepare_to_resume): Delete.
8573         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
8574         low virtual methods.
8575         * amd64-linux-nat.c: Likewise.
8576         * arm-linux-nat.c: Likewise.
8577         * i386-linux-nat.c: Likewise.
8578         * ia64-linux-nat.c: Likewise.
8579         * mips-linux-nat.c: Likewise.
8580         * ppc-linux-nat.c: Likewise.
8581         * s390-linux-nat.c: Likewise.
8582         * sparc64-linux-nat.c: Likewise.
8583         * x86-linux-nat.c: Likewise.
8584         * x86-linux-nat.h: Include "nat/x86-linux.h".
8585         (x86_linux_nat_target) <low_new_fork, low_forget_process,
8586         low_prepare_to_resume, low_new_thread, low_delete_thread>:
8587         Override methods.
8588
8589 2018-05-02  Pedro Alves  <palves@redhat.com>
8590
8591         * target.h (target_ops)
8592         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
8593         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
8594         stopped_by_watchpoint, have_continuable_watchpoint,
8595         stopped_data_address, watchpoint_addr_within_range,
8596         can_accel_watchpoint_condition, can_run, thread_alive,
8597         has_all_memory, has_memory, has_stack, has_registers,
8598         has_execution, can_async_p, is_async_p, supports_non_stop,
8599         always_non_stop_p, can_execute_reverse, supports_multi_process,
8600         supports_enable_disable_tracepoint,
8601         supports_disable_randomization, supports_string_tracing,
8602         supports_evaluation_of_breakpoint_conditions,
8603         can_run_breakpoint_commands, filesystem_is_local,
8604         can_download_tracepoint, get_trace_state_variable_value,
8605         set_trace_notes, get_tib_address, use_agent, can_use_agent,
8606         record_is_replaying, record_will_replay,
8607         augmented_libraries_svr4_read>: Adjust to return bool.
8608         * aarch64-linux-nat.c: All implementations adjusted.
8609         * aix-thread.c: All implementations adjusted.
8610         * arm-linux-nat.c: All implementations adjusted.
8611         * breakpoint.c: All implementations adjusted.
8612         * bsd-kvm.c: All implementations adjusted.
8613         * bsd-uthread.c: All implementations adjusted.
8614         * corelow.c: All implementations adjusted.
8615         * ctf.c: All implementations adjusted.
8616         * darwin-nat.c: All implementations adjusted.
8617         * darwin-nat.h: All implementations adjusted.
8618         * exec.c: All implementations adjusted.
8619         * fbsd-nat.c: All implementations adjusted.
8620         * fbsd-nat.h: All implementations adjusted.
8621         * gnu-nat.c: All implementations adjusted.
8622         * gnu-nat.h: All implementations adjusted.
8623         * go32-nat.c: All implementations adjusted.
8624         * ia64-linux-nat.c: All implementations adjusted.
8625         * inf-child.c: All implementations adjusted.
8626         * inf-child.h: All implementations adjusted.
8627         * inf-ptrace.c: All implementations adjusted.
8628         * inf-ptrace.h: All implementations adjusted.
8629         * linux-nat.c: All implementations adjusted.
8630         * linux-nat.h: All implementations adjusted.
8631         * mips-linux-nat.c: All implementations adjusted.
8632         * nto-procfs.c: All implementations adjusted.
8633         * ppc-linux-nat.c: All implementations adjusted.
8634         * procfs.c: All implementations adjusted.
8635         * ravenscar-thread.c: All implementations adjusted.
8636         * record-btrace.c: All implementations adjusted.
8637         * record-full.c: All implementations adjusted.
8638         * remote-sim.c: All implementations adjusted.
8639         * remote.c: All implementations adjusted.
8640         * s390-linux-nat.c: All implementations adjusted.
8641         * sol-thread.c: All implementations adjusted.
8642         * spu-multiarch.c: All implementations adjusted.
8643         * target-delegates.c: All implementations adjusted.
8644         * target.c: All implementations adjusted.
8645         * target.h: All implementations adjusted.
8646         * tracefile-tfile.c: All implementations adjusted.
8647         * tracefile.c: All implementations adjusted.
8648         * tracefile.h: All implementations adjusted.
8649         * windows-nat.c: All implementations adjusted.
8650         * x86-linux-nat.h: All implementations adjusted.
8651         * x86-nat.h: All implementations adjusted.
8652
8653 2018-05-02  Pedro Alves  <palves@redhat.com>
8654
8655         * make-target-delegates (scan_target_h): Don't trim lines here.
8656         Replace sequences of tabs and/or whitespace with a single
8657         whitespace.
8658         (top level, parsing methods): Trim each line before processing it
8659         here.
8660
8661 2018-05-02  Pedro Alves  <palves@redhat.com>
8662             John Baldwin  <jhb@freebsd.org>
8663
8664         * target.h (enum strata) <debug_stratum>: New.
8665         (struct target_ops) <all delegation methods>: Replace by C++
8666         virtual methods, and drop "to_" prefix.  All references updated
8667         throughout.
8668         <to_shortname, to_longname, to_doc, to_data,
8669         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
8670         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
8671         virtual methods.  All references updated throughout.
8672         <can_attach, supports_terminal_ours, can_create_inferior,
8673         get_thread_control_capabilities, attach_no_wait>: New
8674         virtual methods.
8675         <insert_breakpoint, remove_breakpoint>: Now
8676         TARGET_DEFAULT_NORETURN methods.
8677         <info_proc>: Now returns bool.
8678         <to_magic>: Delete.
8679         (OPS_MAGIC): Delete.
8680         (current_target): Delete.  All references replaced by references
8681         to ...
8682         (target_stack): ... this.  New.
8683         (target_shortname, target_longname): Adjust.
8684         (target_can_run): Now a function declaration.
8685         (default_child_has_all_memory, default_child_has_memory)
8686         (default_child_has_stack, default_child_has_registers)
8687         (default_child_has_execution): Remove target_ops parameter.
8688         (complete_target_initialization): Delete.
8689         (memory_breakpoint_target): New template class.
8690         (test_target_ops): Refactor as a C++ class with virtual methods.
8691         * make-target-delegates (NAME_PART): Tighten.
8692         (POINTER_PART, CP_SYMBOL): New.
8693         (SIMPLE_RETURN_PART): Reimplement.
8694         (VEC_RETURN_PART): Expect less.
8695         (RETURN_PART, VIRTUAL_PART): New.
8696         (METHOD): Adjust to C++ virtual methods.
8697         (scan_target_h): Remove reference to C99.
8698         (dname): Output "target_ops::" prefix.
8699         (write_function_header): Adjust to output a C++ class method.
8700         (write_declaration): New.
8701         (write_delegator): Adjust to output a C++ class method.
8702         (tdname): Output "dummy_target::" prefix.
8703         (write_tdefault, write_debugmethod): Adjust to output a C++ class
8704         method.
8705         (tdefault_names, debug_names): Delete.
8706         (return_types, tdefaults, styles, argtypes_array): New.
8707         (top level): All methods are delegators.
8708         (print_class): New.
8709         (top level): Print dummy_target and debug_target classes.
8710         * target-delegates.c: Regenerate.
8711         * target-debug.h (target_debug_print_enum_info_proc_what)
8712         (target_debug_print_thread_control_capabilities)
8713         (target_debug_print_thread_info_p): New.
8714         * target.c (dummy_target): Delete.
8715         (the_dummy_target, the_debug_target): New.
8716         (target_stack): Now extern.
8717         (set_targetdebug): Push/unpush debug target.
8718         (default_child_has_all_memory, default_child_has_memory)
8719         (default_child_has_stack, default_child_has_registers)
8720         (default_child_has_execution): Remove target_ops parameter.
8721         (complete_target_initialization): Delete.
8722         (add_target_with_completer): No longer call
8723         complete_target_initialization.
8724         (target_supports_terminal_ours): Use regular delegation.
8725         (update_current_target): Delete.
8726         (push_target): No longer check magic number.  Don't call
8727         update_current_target.
8728         (unpush_target): Don't call update_current_target.
8729         (target_is_pushed): No longer check magic number.
8730         (target_require_runnable): Skip for all stratums over
8731         process_stratum.
8732         (target_ops::info_proc): New.
8733         (target_info_proc): Use find_target_at and
8734         find_default_run_target.
8735         (target_supports_disable_randomization): Use regular delegation.
8736         (target_get_osdata): Use find_target_at.
8737         (target_ops::open, target_ops::close, target_ops::can_attach)
8738         (target_ops::attach, target_ops::can_create_inferior)
8739         (target_ops::create_inferior, target_ops::can_run)
8740         (target_can_run): New.
8741         (default_fileio_target): Use regular delegation.
8742         (target_ops::fileio_open, target_ops::fileio_pwrite)
8743         (target_ops::fileio_pread, target_ops::fileio_fstat)
8744         (target_ops::fileio_close, target_ops::fileio_unlink)
8745         (target_ops::fileio_readlink): New.
8746         (target_fileio_open_1, target_fileio_unlink)
8747         (target_fileio_readlink): Always call the target method.  Handle
8748         FILEIO_ENOSYS.
8749         (return_zero, return_zero_has_execution): Delete.
8750         (init_dummy_target): Delete.
8751         (dummy_target::dummy_target, dummy_target::shortname)
8752         (dummy_target::longname, dummy_target::doc)
8753         (debug_target::debug_target, debug_target::shortname)
8754         (debug_target::longname, debug_target::doc): New.
8755         (target_supports_delete_record): Use regular delegation.
8756         (setup_target_debug): Delete.
8757         (maintenance_print_target_stack): Skip debug_stratum.
8758         (initialize_targets): Instantiate the_dummy_target and
8759         the_debug_target.
8760         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
8761         use target_stack.
8762         (target_auxv_search, fprint_target_auxv): Adjust.
8763         (info_auxv_command): Adjust to use target_stack.
8764         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
8765         * exceptions.c (print_flush): Handle a NULL target_stack.
8766         * regcache.c (target_ops_no_register): Refactor as class with
8767         virtual methods.
8768
8769         * exec.c (exec_target): New class.
8770         (exec_ops): Now an exec_target.
8771         (exec_open, exec_close_1, exec_get_section_table)
8772         (exec_xfer_partial, exec_files_info, exec_has_memory)
8773         (exec_make_note_section): Refactor as exec_target methods.
8774         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
8775         Delete.
8776         (exec_target::find_memory_regions): New.
8777         (_initialize_exec): Don't call init_exec_ops.
8778         * gdbcore.h (exec_file_clear): Delete.
8779
8780         * corefile.c (core_target): Delete.
8781         (core_file_command): Adjust.
8782         * corelow.c (core_target): New class.
8783         (the_core_target): New.
8784         (core_close): Remove target_ops parameter.
8785         (core_close_cleanup): Adjust.
8786         (core_target::close): New.
8787         (core_open, core_detach, get_core_registers, core_files_info)
8788         (core_xfer_partial, core_thread_alive, core_read_description)
8789         (core_pid_to_str, core_thread_name, core_has_memory)
8790         (core_has_stack, core_has_registers, core_info_proc): Rework as
8791         core_target methods.
8792         (ignore, core_remove_breakpoint, init_core_ops): Delete.
8793         (_initialize_corelow): Initialize the_core_target.
8794         * gdbcore.h (core_target): Delete.
8795         (the_core_target): New.
8796
8797         * ctf.c: (ctf_target): New class.
8798         (ctf_ops): Now a ctf_target.
8799         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
8800         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
8801         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
8802         methods.
8803         (init_ctf_ops): Delete.
8804         (_initialize_ctf): Don't call it.
8805         * tracefile-tfile.c (tfile_target): New class.
8806         (tfile_ops): Now a tfile_target.
8807         (tfile_open, tfile_close, tfile_files_info)
8808         (tfile_get_tracepoint_status, tfile_trace_find)
8809         (tfile_fetch_registers, tfile_xfer_partial)
8810         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
8811         Refactor as tfile_target methods.
8812         (tfile_xfer_partial_features): Remove target_ops parameter.
8813         (init_tfile_ops): Delete.
8814         (_initialize_tracefile_tfile): Don't call it.
8815         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
8816         (tracefile_has_stack, tracefile_has_registers)
8817         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
8818         tracefile_target methods.
8819         (init_tracefile_ops): Delete.
8820         (tracefile_target::tracefile_target): New.
8821         * tracefile.h: Include "target.h".
8822         (tracefile_target): New class.
8823         (init_tracefile_ops): Delete.
8824
8825         * spu-multiarch.c (spu_multiarch_target): New class.
8826         (spu_ops): Now a spu_multiarch_target.
8827         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
8828         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
8829         (spu_search_memory, spu_mourn_inferior): Refactor as
8830         spu_multiarch_target methods.
8831         (init_spu_ops): Delete.
8832         (_initialize_spu_multiarch): Remove references to init_spu_ops,
8833         complete_target_initialization.
8834
8835         * ravenscar-thread.c (ravenscar_thread_target): New class.
8836         (ravenscar_ops): Now a ravenscar_thread_target.
8837         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
8838         (ravenscar_thread_alive, ravenscar_pid_to_str)
8839         (ravenscar_fetch_registers, ravenscar_store_registers)
8840         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
8841         (ravenscar_stopped_by_hw_breakpoint)
8842         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
8843         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
8844         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
8845         methods.
8846         (init_ravenscar_thread_ops): Delete.
8847         (_initialize_ravenscar): Remove references to
8848         init_ravenscar_thread_ops and complete_target_initialization.
8849
8850         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
8851         (bsd_uthread_target): New class.
8852         (bsd_uthread_ops): Now a bsd_uthread_target.
8853         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
8854         (bsd_uthread_close, bsd_uthread_mourn_inferior)
8855         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
8856         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
8857         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
8858         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
8859         (bsd_uthread_target): Delete function.
8860         (_initialize_bsd_uthread): Remove reference to
8861         complete_target_initialization.
8862
8863         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
8864         (target_bfd): ... this new class.
8865         (target_bfd_xfer_partial, target_bfd_get_section_table)
8866         (target_bfd_close): Refactor as target_bfd methods.
8867         (target_bfd::~target_bfd): New.
8868         (target_bfd_reopen): Adjust.
8869         (target_bfd::close): New.
8870
8871         * record-btrace.c (record_btrace_target): New class.
8872         (record_btrace_ops): Now a record_btrace_target.
8873         (record_btrace_open, record_btrace_stop_recording)
8874         (record_btrace_disconnect, record_btrace_close)
8875         (record_btrace_async, record_btrace_info)
8876         (record_btrace_insn_history, record_btrace_insn_history_range)
8877         (record_btrace_insn_history_from, record_btrace_call_history)
8878         (record_btrace_call_history_range)
8879         (record_btrace_call_history_from, record_btrace_record_method)
8880         (record_btrace_is_replaying, record_btrace_will_replay)
8881         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
8882         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
8883         (record_btrace_store_registers, record_btrace_prepare_to_store)
8884         (record_btrace_to_get_unwinder)
8885         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
8886         (record_btrace_commit_resume, record_btrace_wait)
8887         (record_btrace_stop, record_btrace_can_execute_reverse)
8888         (record_btrace_stopped_by_sw_breakpoint)
8889         (record_btrace_supports_stopped_by_sw_breakpoint)
8890         (record_btrace_stopped_by_hw_breakpoint)
8891         (record_btrace_supports_stopped_by_hw_breakpoint)
8892         (record_btrace_update_thread_list, record_btrace_thread_alive)
8893         (record_btrace_goto_begin, record_btrace_goto_end)
8894         (record_btrace_goto, record_btrace_stop_replaying_all)
8895         (record_btrace_execution_direction)
8896         (record_btrace_prepare_to_generate_core)
8897         (record_btrace_done_generating_core): Refactor as
8898         record_btrace_target methods.
8899         (init_record_btrace_ops): Delete.
8900         (_initialize_record_btrace): Remove reference to
8901         init_record_btrace_ops.
8902         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
8903         the execution_direction global.
8904         (record_full_base_target, record_full_target)
8905         (record_full_core_target): New classes.
8906         (record_full_ops): Now a record_full_target.
8907         (record_full_core_ops): Now a record_full_core_target.
8908         (record_full_target::detach, record_full_target::disconnect)
8909         (record_full_core_target::disconnect)
8910         (record_full_target::mourn_inferior, record_full_target::kill):
8911         New.
8912         (record_full_open, record_full_close, record_full_async): Refactor
8913         as methods of the record_full_base_target class.
8914         (record_full_resume, record_full_commit_resume): Refactor
8915         as methods of the record_full_target class.
8916         (record_full_wait, record_full_stopped_by_watchpoint)
8917         (record_full_stopped_data_address)
8918         (record_full_stopped_by_sw_breakpoint)
8919         (record_full_supports_stopped_by_sw_breakpoint)
8920         (record_full_stopped_by_hw_breakpoint)
8921         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
8922         methods of the record_full_base_target class.
8923         (record_full_store_registers, record_full_xfer_partial)
8924         (record_full_insert_breakpoint, record_full_remove_breakpoint):
8925         Refactor as methods of the record_full_target class.
8926         (record_full_can_execute_reverse, record_full_get_bookmark)
8927         (record_full_goto_bookmark, record_full_execution_direction)
8928         (record_full_record_method, record_full_info, record_full_delete)
8929         (record_full_is_replaying, record_full_will_replay)
8930         (record_full_goto_begin, record_full_goto_end, record_full_goto)
8931         (record_full_stop_replaying): Refactor as methods of the
8932         record_full_base_target class.
8933         (record_full_core_resume, record_full_core_kill)
8934         (record_full_core_fetch_registers)
8935         (record_full_core_prepare_to_store)
8936         (record_full_core_store_registers, record_full_core_xfer_partial)
8937         (record_full_core_insert_breakpoint)
8938         (record_full_core_remove_breakpoint)
8939         (record_full_core_has_execution): Refactor
8940         as methods of the record_full_core_target class.
8941         (record_full_base_target::supports_delete_record): New.
8942         (init_record_full_ops): Delete.
8943         (init_record_full_core_ops): Delete.
8944         (record_full_save): Refactor as method of the
8945         record_full_base_target class.
8946         (_initialize_record_full): Remove references to
8947         init_record_full_ops and init_record_full_core_ops.
8948
8949         * remote.c (remote_target, extended_remote_target): New classes.
8950         (remote_ops): Now a remote_target.
8951         (extended_remote_ops): Now an extended_remote_target.
8952         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
8953         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
8954         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
8955         (remote_pass_signals, remote_set_syscall_catchpoint)
8956         (remote_program_signals, )
8957         (remote_thread_always_alive): Remove target_ops parameter.
8958         (remote_thread_alive, remote_thread_name)
8959         (remote_update_thread_list, remote_threads_extra_info)
8960         (remote_static_tracepoint_marker_at)
8961         (remote_static_tracepoint_markers_by_strid)
8962         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
8963         (remote_open): Refactor as methods of remote_target.
8964         (extended_remote_open, extended_remote_detach)
8965         (extended_remote_attach, extended_remote_post_attach):
8966         (extended_remote_supports_disable_randomization)
8967         (extended_remote_create_inferior): : Refactor as method of
8968         extended_remote_target.
8969         (remote_set_permissions, remote_open_1, remote_detach)
8970         (remote_follow_fork, remote_follow_exec, remote_disconnect)
8971         (remote_resume, remote_commit_resume, remote_stop)
8972         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
8973         (remote_terminal_ours, remote_wait, remote_fetch_registers)
8974         (remote_prepare_to_store, remote_store_registers)
8975         (remote_flash_erase, remote_flash_done, remote_files_info)
8976         (remote_kill, remote_mourn, remote_insert_breakpoint)
8977         (remote_remove_breakpoint, remote_insert_watchpoint)
8978         (remote_watchpoint_addr_within_range)
8979         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
8980         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
8981         (remote_supports_stopped_by_sw_breakpoint)
8982         (remote_stopped_by_hw_breakpoint)
8983         (remote_supports_stopped_by_hw_breakpoint)
8984         (remote_stopped_by_watchpoint, remote_stopped_data_address)
8985         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
8986         (remote_verify_memory): Refactor as methods of remote_target.
8987         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
8988         parameter.
8989         (remote_xfer_partial, remote_get_memory_xfer_limit)
8990         (remote_search_memory, remote_rcmd, remote_memory_map)
8991         (remote_pid_to_str, remote_get_thread_local_address)
8992         (remote_get_tib_address, remote_read_description): Refactor as
8993         methods of remote_target.
8994         (remote_target::fileio_open, remote_target::fileio_pwrite)
8995         (remote_target::fileio_pread, remote_target::fileio_close): New.
8996         (remote_hostio_readlink, remote_hostio_fstat)
8997         (remote_filesystem_is_local, remote_can_execute_reverse)
8998         (remote_supports_non_stop, remote_supports_disable_randomization)
8999         (remote_supports_multi_process, remote_supports_cond_breakpoints)
9000         (remote_supports_enable_disable_tracepoint)
9001         (remote_supports_string_tracing)
9002         (remote_can_run_breakpoint_commands, remote_trace_init)
9003         (remote_download_tracepoint, remote_can_download_tracepoint)
9004         (remote_download_trace_state_variable, remote_enable_tracepoint)
9005         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
9006         (remote_trace_start, remote_get_trace_status)
9007         (remote_get_tracepoint_status, remote_trace_stop)
9008         (remote_trace_find, remote_get_trace_state_variable_value)
9009         (remote_save_trace_data, remote_get_raw_trace_data)
9010         (remote_set_disconnected_tracing, remote_core_of_thread)
9011         (remote_set_circular_trace_buffer, remote_traceframe_info)
9012         (remote_get_min_fast_tracepoint_insn_len)
9013         (remote_set_trace_buffer_size, remote_set_trace_notes)
9014         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
9015         (remote_disable_btrace, remote_teardown_btrace)
9016         (remote_read_btrace, remote_btrace_conf)
9017         (remote_augmented_libraries_svr4_read, remote_load)
9018         (remote_pid_to_exec_file, remote_can_do_single_step)
9019         (remote_execution_direction, remote_thread_handle_to_thread_info):
9020         Refactor as methods of remote_target.
9021         (init_remote_ops, init_extended_remote_ops): Delete.
9022         (remote_can_async_p, remote_is_async_p, remote_async)
9023         (remote_thread_events, remote_upload_tracepoints)
9024         (remote_upload_trace_state_variables): Refactor as methods of
9025         remote_target.
9026         (_initialize_remote): Remove references to init_remote_ops and
9027         init_extended_remote_ops.
9028
9029         * remote-sim.c (gdbsim_target): New class.
9030         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
9031         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
9032         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
9033         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
9034         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
9035         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
9036         Refactor as methods of gdbsim_target.
9037         (gdbsim_ops): Now a gdbsim_target.
9038         (init_gdbsim_ops): Delete.
9039         (gdbsim_cntrl_c): Adjust.
9040         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
9041
9042         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
9043         (the_amd64_linux_nat_target): New.
9044         (amd64_linux_fetch_inferior_registers)
9045         (amd64_linux_store_inferior_registers): Refactor as methods of
9046         amd64_linux_nat_target.
9047         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
9048         * i386-linux-nat.c: Don't include "linux-nat.h".
9049         (i386_linux_nat_target): New class.
9050         (the_i386_linux_nat_target): New.
9051         (i386_linux_fetch_inferior_registers)
9052         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
9053         as methods of i386_linux_nat_target.
9054         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
9055         * inf-child.c (inf_child_ops): Delete.
9056         (inf_child_fetch_inferior_registers)
9057         (inf_child_store_inferior_registers): Delete.
9058         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
9059         methods of inf_child_target.
9060         (inf_child_target::supports_terminal_ours)
9061         (inf_child_target::terminal_init)
9062         (inf_child_target::terminal_inferior)
9063         (inf_child_target::terminal_ours_for_output)
9064         (inf_child_target::terminal_ours, inf_child_target::interrupt)
9065         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
9066         New.
9067         (inf_child_open, inf_child_disconnect, inf_child_close)
9068         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
9069         (inf_child_post_startup_inferior, inf_child_can_run)
9070         (inf_child_pid_to_exec_file): Refactor as methods of
9071         inf_child_target.
9072         (inf_child_follow_fork): Delete.
9073         (inf_child_target::can_create_inferior)
9074         (inf_child_target::can_attach): New.
9075         (inf_child_target::has_all_memory, inf_child_target::has_memory)
9076         (inf_child_target::has_stack, inf_child_target::has_registers)
9077         (inf_child_target::has_execution): New.
9078         (inf_child_fileio_open, inf_child_fileio_pwrite)
9079         (inf_child_fileio_pread, inf_child_fileio_fstat)
9080         (inf_child_fileio_close, inf_child_fileio_unlink)
9081         (inf_child_fileio_readlink, inf_child_use_agent)
9082         (inf_child_can_use_agent): Refactor as methods of
9083         inf_child_target.
9084         (return_zero, inf_child_target): Delete.
9085         (inf_child_target::inf_child_target): New.
9086         * inf-child.h: Include "target.h".
9087         (inf_child_target): Delete function prototype.
9088         (inf_child_target): New class.
9089         (inf_child_open_target, inf_child_mourn_inferior)
9090         (inf_child_maybe_unpush_target): Delete.
9091         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
9092         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
9093         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
9094         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
9095         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
9096         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
9097         (inf_ptrace_wait, inf_ptrace_xfer_partial)
9098         (inf_ptrace_thread_alive, inf_ptrace_files_info)
9099         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
9100         methods of inf_ptrace_target.
9101         (inf_ptrace_target): Delete function.
9102         * inf-ptrace.h: Include "inf-child.h".
9103         (inf_ptrace_target): Delete function declaration.
9104         (inf_ptrace_target): New class.
9105         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
9106         * linux-nat.c (linux_target): New.
9107         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
9108         (linux_nat_target::~linux_nat_target): New.
9109         (linux_child_post_attach, linux_child_post_startup_inferior)
9110         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
9111         (linux_child_remove_fork_catchpoint)
9112         (linux_child_insert_vfork_catchpoint)
9113         (linux_child_remove_vfork_catchpoint)
9114         (linux_child_insert_exec_catchpoint)
9115         (linux_child_remove_exec_catchpoint)
9116         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
9117         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
9118         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
9119         (linux_nat_stopped_data_address)
9120         (linux_nat_stopped_by_sw_breakpoint)
9121         (linux_nat_supports_stopped_by_sw_breakpoint)
9122         (linux_nat_stopped_by_hw_breakpoint)
9123         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
9124         (linux_nat_kill, linux_nat_mourn_inferior)
9125         (linux_nat_xfer_partial, linux_nat_thread_alive)
9126         (linux_nat_update_thread_list, linux_nat_pid_to_str)
9127         (linux_nat_thread_name, linux_child_pid_to_exec_file)
9128         (linux_child_static_tracepoint_markers_by_strid)
9129         (linux_nat_is_async_p, linux_nat_can_async_p)
9130         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
9131         (linux_nat_supports_multi_process)
9132         (linux_nat_supports_disable_randomization, linux_nat_async)
9133         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
9134         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
9135         (linux_nat_fileio_open, linux_nat_fileio_readlink)
9136         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
9137         methods of linux_nat_target.
9138         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
9139         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
9140         parameter.
9141         (check_stopped_by_watchpoint): Adjust.
9142         (linux_xfer_partial): Delete.
9143         (linux_target_install_ops, linux_target, linux_nat_add_target):
9144         Delete.
9145         (linux_nat_target::linux_nat_target): New.
9146         * linux-nat.h: Include "inf-ptrace.h".
9147         (linux_nat_target): New.
9148         (linux_target, linux_target_install_ops, linux_nat_add_target):
9149         Delete function declarations.
9150         (linux_target): Declare global.
9151         * linux-thread-db.c (thread_db_target): New.
9152         (thread_db_target::thread_db_target): New.
9153         (thread_db_ops): Delete.
9154         (the_thread_db_target): New.
9155         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
9156         (thread_db_update_thread_list, thread_db_pid_to_str)
9157         (thread_db_extra_thread_info)
9158         (thread_db_thread_handle_to_thread_info)
9159         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
9160         (thread_db_resume): Refactor as methods of thread_db_target.
9161         (init_thread_db_ops): Delete.
9162         (_initialize_thread_db): Remove reference to init_thread_db_ops.
9163         * x86-linux-nat.c: Don't include "linux-nat.h".
9164         (super_post_startup_inferior): Delete.
9165         (x86_linux_nat_target::~x86_linux_nat_target): New.
9166         (x86_linux_child_post_startup_inferior)
9167         (x86_linux_read_description, x86_linux_enable_btrace)
9168         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
9169         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
9170         methods of x86_linux_nat_target.
9171         (x86_linux_create_target): Delete.  Bits folded ...
9172         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
9173         pointer.
9174         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
9175         (x86_linux_nat_target): New class.
9176         (x86_linux_create_target): Delete.
9177         (x86_linux_add_target): Now takes a linux_nat_target pointer.
9178         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
9179         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
9180         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
9181         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
9182         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
9183         make extern.
9184         (x86_use_watchpoints): Delete.
9185         * x86-nat.h: Include "breakpoint.h" and "target.h".
9186         (x86_use_watchpoints): Delete.
9187         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
9188         (x86_stopped_by_watchpoint, x86_stopped_data_address)
9189         (x86_insert_watchpoint, x86_remove_watchpoint)
9190         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
9191         (x86_stopped_by_hw_breakpoint): New declarations.
9192         (x86_nat_target): New template class.
9193
9194         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
9195         (the_ppc_linux_nat_target): New.
9196         (ppc_linux_fetch_inferior_registers)
9197         (ppc_linux_can_use_hw_breakpoint)
9198         (ppc_linux_region_ok_for_hw_watchpoint)
9199         (ppc_linux_ranged_break_num_registers)
9200         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
9201         (ppc_linux_insert_mask_watchpoint)
9202         (ppc_linux_remove_mask_watchpoint)
9203         (ppc_linux_can_accel_watchpoint_condition)
9204         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
9205         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
9206         (ppc_linux_watchpoint_addr_within_range)
9207         (ppc_linux_masked_watch_num_registers)
9208         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
9209         (ppc_linux_read_description): Refactor as methods of
9210         ppc_linux_nat_target.
9211         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
9212
9213         * procfs.c (procfs_xfer_partial): Delete forward declaration.
9214         (procfs_target): New class.
9215         (the_procfs_target): New.
9216         (procfs_target): Delete function.
9217         (procfs_auxv_parse, procfs_attach, procfs_detach)
9218         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
9219         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
9220         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
9221         (procfs_create_inferior, procfs_update_thread_list)
9222         (procfs_thread_alive, procfs_pid_to_str)
9223         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
9224         (procfs_stopped_data_address, procfs_insert_watchpoint)
9225         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
9226         (proc_find_memory_regions, procfs_info_proc)
9227         (procfs_make_note_section): Refactor as methods of procfs_target.
9228         (_initialize_procfs): Adjust.
9229         * sol-thread.c (sol_thread_target): New class.
9230         (sol_thread_ops): Now a sol_thread_target.
9231         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
9232         (sol_thread_fetch_registers, sol_thread_store_registers)
9233         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
9234         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
9235         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
9236         (init_sol_thread_ops): Delete.
9237         (_initialize_sol_thread): Adjust.  Remove references to
9238         init_sol_thread_ops and complete_target_initialization.
9239
9240         * windows-nat.c (windows_nat_target): New class.
9241         (windows_fetch_inferior_registers)
9242         (windows_store_inferior_registers, windows_resume, windows_wait)
9243         (windows_attach, windows_detach, windows_pid_to_exec_file)
9244         (windows_files_info, windows_create_inferior)
9245         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
9246         (windows_close, windows_pid_to_str, windows_xfer_partial)
9247         (windows_get_tib_address, windows_get_ada_task_ptid)
9248         (windows_thread_name, windows_thread_alive): Refactor as
9249         windows_nat_target methods.
9250         (do_initial_windows_stuff): Adjust.
9251         (windows_target): Delete function.
9252         (_initialize_windows_nat): Adjust.
9253
9254         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
9255         (darwin_mourn_inferior, darwin_kill_inferior)
9256         (darwin_create_inferior, darwin_attach, darwin_detach)
9257         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
9258         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
9259         (darwin_supports_multi_process): Refactor as darwin_nat_target
9260         methods.
9261         (darwin_resume_to, darwin_files_info): Delete.
9262         (_initialize_darwin_inferior): Rename to ...
9263         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
9264         * darwin-nat.h: Include "inf-child.h".
9265         (darwin_nat_target): New class.
9266         (darwin_complete_target): Delete.
9267         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
9268         (darwin_target): New.
9269         (i386_darwin_fetch_inferior_registers)
9270         (i386_darwin_store_inferior_registers): Refactor as methods of
9271         darwin_nat_target.
9272         (darwin_complete_target): Delete, with ...
9273         (_initialize_i386_darwin_nat): ... bits factored out here.
9274
9275         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
9276         (the_alpha_linux_nat_target): New.
9277         (alpha_linux_register_u_offset): Refactor as
9278         alpha_linux_nat_target method.
9279         (_initialize_alpha_linux_nat): Adjust.
9280         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
9281         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
9282         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
9283         methods of linux_nat_trad_target.
9284         (linux_trad_target): Delete.
9285         * linux-nat-trad.h (linux_trad_target): Delete function.
9286         (linux_nat_trad_target): New class.
9287         * mips-linux-nat.c (mips_linux_nat_target): New class.
9288         (super_fetch_registers, super_store_registers, super_close):
9289         Delete.
9290         (the_mips_linux_nat_target): New.
9291         (mips64_linux_regsets_fetch_registers)
9292         (mips64_linux_regsets_store_registers)
9293         (mips64_linux_fetch_registers, mips64_linux_store_registers)
9294         (mips_linux_register_u_offset, mips_linux_read_description)
9295         (mips_linux_can_use_hw_breakpoint)
9296         (mips_linux_stopped_by_watchpoint)
9297         (mips_linux_stopped_data_address)
9298         (mips_linux_region_ok_for_hw_watchpoint)
9299         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
9300         (mips_linux_close): Refactor as methods of mips_linux_nat.
9301         (_initialize_mips_linux_nat): Adjust to C++ification.
9302
9303         * aix-thread.c (aix_thread_target): New class.
9304         (aix_thread_ops): Now an aix_thread_target.
9305         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
9306         (aix_thread_fetch_registers, aix_thread_store_registers)
9307         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
9308         (aix_thread_thread_alive, aix_thread_pid_to_str)
9309         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
9310         Refactor as methods of aix_thread_target.
9311         (init_aix_thread_ops): Delete.
9312         (_initialize_aix_thread): Remove references to init_aix_thread_ops
9313         and complete_target_initialization.
9314         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
9315         (rs6000_nat_target): New class.
9316         (the_rs6000_nat_target): New.
9317         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
9318         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
9319         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
9320         (super_create_inferior): Delete.
9321         (_initialize_rs6000_nat): Adjust to C++ification.
9322
9323         * arm-linux-nat.c (arm_linux_nat_target): New class.
9324         (the_arm_linux_nat_target): New.
9325         (arm_linux_fetch_inferior_registers)
9326         (arm_linux_store_inferior_registers, arm_linux_read_description)
9327         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
9328         (arm_linux_remove_hw_breakpoint)
9329         (arm_linux_region_ok_for_hw_watchpoint)
9330         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
9331         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
9332         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
9333         arm_linux_nat_target.
9334         (_initialize_arm_linux_nat): Adjust to C++ification.
9335
9336         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
9337         (the_aarch64_linux_nat_target): New.
9338         (aarch64_linux_fetch_inferior_registers)
9339         (aarch64_linux_store_inferior_registers)
9340         (aarch64_linux_child_post_startup_inferior)
9341         (aarch64_linux_read_description)
9342         (aarch64_linux_can_use_hw_breakpoint)
9343         (aarch64_linux_insert_hw_breakpoint)
9344         (aarch64_linux_remove_hw_breakpoint)
9345         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
9346         (aarch64_linux_region_ok_for_hw_watchpoint)
9347         (aarch64_linux_stopped_data_address)
9348         (aarch64_linux_stopped_by_watchpoint)
9349         (aarch64_linux_watchpoint_addr_within_range)
9350         (aarch64_linux_can_do_single_step): Refactor as methods of
9351         aarch64_linux_nat_target.
9352         (super_post_startup_inferior): Delete.
9353         (_initialize_aarch64_linux_nat): Adjust to C++ification.
9354
9355         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
9356         (the_hppa_linux_nat_target): New.
9357         (hppa_linux_fetch_inferior_registers)
9358         (hppa_linux_store_inferior_registers): Refactor as methods of
9359         hppa_linux_nat_target.
9360         (_initialize_hppa_linux_nat): Adjust to C++ification.
9361
9362         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
9363         (the_ia64_linux_nat_target): New.
9364         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
9365         (ia64_linux_stopped_data_address)
9366         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
9367         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
9368         ia64_linux_nat_target methods.
9369         (super_xfer_partial): Delete.
9370         (_initialize_ia64_linux_nat): Adjust to C++ification.
9371
9372         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
9373         (the_m32r_linux_nat_target): New.
9374         (m32r_linux_fetch_inferior_registers)
9375         (m32r_linux_store_inferior_registers): Refactor as
9376         m32r_linux_nat_target methods.
9377         (_initialize_m32r_linux_nat): Adjust to C++ification.
9378
9379         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
9380         (the_m68k_linux_nat_target): New.
9381         (m68k_linux_fetch_inferior_registers)
9382         (m68k_linux_store_inferior_registers): Refactor as
9383         m68k_linux_nat_target methods.
9384         (_initialize_m68k_linux_nat): Adjust to C++ification.
9385
9386         * s390-linux-nat.c (s390_linux_nat_target): New class.
9387         (the_s390_linux_nat_target): New.
9388         (s390_linux_fetch_inferior_registers)
9389         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
9390         (s390_insert_watchpoint, s390_remove_watchpoint)
9391         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
9392         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
9393         (s390_auxv_parse, s390_read_description): Refactor as methods of
9394         s390_linux_nat_target.
9395         (_initialize_s390_nat): Adjust to C++ification.
9396
9397         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
9398         (the_sparc_linux_nat_target): New.
9399         (_initialize_sparc_linux_nat): Adjust to C++ification.
9400         * sparc-nat.c (sparc_fetch_inferior_registers)
9401         (sparc_store_inferior_registers): Remove target_ops parameter.
9402         * sparc-nat.h (sparc_fetch_inferior_registers)
9403         (sparc_store_inferior_registers): Remove target_ops parameter.
9404         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
9405         (the_sparc64_linux_nat_target): New.
9406         (_initialize_sparc64_linux_nat): Adjust to C++ification.
9407
9408         * spu-linux-nat.c (spu_linux_nat_target): New class.
9409         (the_spu_linux_nat_target): New.
9410         (spu_child_post_startup_inferior, spu_child_post_attach)
9411         (spu_child_wait, spu_fetch_inferior_registers)
9412         (spu_store_inferior_registers, spu_xfer_partial)
9413         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
9414         methods.
9415         (_initialize_spu_nat): Adjust to C++ification.
9416
9417         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
9418         (the_tilegx_linux_nat_target): New.
9419         (fetch_inferior_registers, store_inferior_registers):
9420         Refactor as methods.
9421         (_initialize_tile_linux_nat): Adjust to C++ification.
9422
9423         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
9424         (the_xtensa_linux_nat_target): New.
9425         (xtensa_linux_fetch_inferior_registers)
9426         (xtensa_linux_store_inferior_registers): Refactor as
9427         xtensa_linux_nat_target methods.
9428         (_initialize_xtensa_linux_nat): Adjust to C++ification.
9429
9430         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
9431         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
9432         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
9433         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
9434         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
9435         (fbsd_stopped_by_sw_breakpoint)
9436         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
9437         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
9438         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
9439         (fbsd_post_startup_inferior, fbsd_post_attach)
9440         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
9441         (fbsd_set_syscall_catchpoint)
9442         (super_xfer_partial, super_resume, super_wait)
9443         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
9444         (fbsd_handle_debug_trap): Remove target_ops parameter.
9445         (fbsd_nat_add_target): Delete.
9446         * fbsd-nat.h: Include "inf-ptrace.h".
9447         (fbsd_nat_add_target): Delete.
9448         (USE_SIGTRAP_SIGINFO): Define.
9449         (fbsd_nat_target): New class.
9450
9451         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
9452         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
9453         (amd64bsd_target): Delete.
9454         * amd64-bsd-nat.h: New file.
9455         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
9456         "x86-bsd-nat.h".
9457         (amd64_fbsd_nat_target): New class.
9458         (the_amd64_fbsd_nat_target): New.
9459         (amd64fbsd_read_description): Refactor as method of
9460         amd64_fbsd_nat_target.
9461         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
9462         (_initialize_amd64fbsd_nat): Adjust to C++ification.
9463         * amd64-nat.h (amd64bsd_target): Delete function declaration.
9464         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
9465         (i386bsd_store_inferior_registers): Remove target_ops parameter.
9466         (i386bsd_target): Delete.
9467         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
9468         (i386bsd_fetch_inferior_registers)
9469         (i386bsd_store_inferior_registers): Declare.
9470         (i386_bsd_nat_target): New class.
9471         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
9472         (the_i386_fbsd_nat_target): New.
9473         (i386fbsd_resume, i386fbsd_read_description): Refactor as
9474         i386_fbsd_nat_target methods.
9475         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
9476         (_initialize_i386fbsd_nat): Adjust to C++ification.
9477         * x86-bsd-nat.c (super_mourn_inferior): Delete.
9478         (x86bsd_mourn_inferior, x86bsd_target): Delete.
9479         (_initialize_x86_bsd_nat): Adjust to C++ification.
9480         * x86-bsd-nat.h: Include "x86-nat.h".
9481         (x86bsd_target): Delete declaration.
9482         (x86bsd_nat_target): New class.
9483
9484         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
9485         (the_aarch64_fbsd_nat_target): New.
9486         (aarch64_fbsd_fetch_inferior_registers)
9487         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
9488         aarch64_fbsd_nat_target.
9489         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
9490         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
9491         (the_alpha_bsd_nat_target): New.
9492         (alphabsd_fetch_inferior_registers)
9493         (alphabsd_store_inferior_registers): Refactor as
9494         alpha_bsd_nat_target methods.
9495         (_initialize_alphabsd_nat): Refactor as methods of
9496         alpha_bsd_nat_target.
9497         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
9498         (the_amd64_nbsd_nat_target): New.
9499         (_initialize_amd64nbsd_nat): Adjust to C++ification.
9500         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
9501         (the_amd64_obsd_nat_target): New.
9502         (_initialize_amd64obsd_nat): Adjust to C++ification.
9503         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
9504         (the_arm_fbsd_nat_target): New.
9505         (arm_fbsd_fetch_inferior_registers)
9506         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
9507         (_initialize_arm_fbsd_nat): Refactor as methods of
9508         arm_fbsd_nat_target.
9509         (_initialize_arm_fbsd_nat): Adjust to C++ification.
9510         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
9511         (the_arm_netbsd_nat_target): New.
9512         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
9513         arm_netbsd_nat_target.
9514         (_initialize_arm_netbsd_nat): Adjust to C++ification.
9515         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
9516         (the_hppa_nbsd_nat_target): New.
9517         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
9518         hppa_nbsd_nat_target methods.
9519         (_initialize_hppanbsd_nat): Adjust to C++ification.
9520         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
9521         (the_hppa_obsd_nat_target): New.
9522         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
9523         methods of hppa_obsd_nat_target.
9524         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
9525         add_target.
9526         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
9527         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
9528         add_target.
9529         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
9530         (_initialize_i386obsd_nat): Use add_target.
9531         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
9532         (the_m68k_bsd_nat_target): New.
9533         (m68kbsd_fetch_inferior_registers)
9534         (m68kbsd_store_inferior_registers): Refactor as methods of
9535         m68k_bsd_nat_target.
9536         (_initialize_m68kbsd_nat): Adjust to C++ification.
9537         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
9538         (the_mips_fbsd_nat_target): New.
9539         (mips_fbsd_fetch_inferior_registers)
9540         (mips_fbsd_store_inferior_registers): Refactor as methods of
9541         mips_fbsd_nat_target.
9542         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
9543         add_target.
9544         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
9545         (the_mips_nbsd_nat_target): New.
9546         (mipsnbsd_fetch_inferior_registers)
9547         (mipsnbsd_store_inferior_registers): Refactor as methods of
9548         mips_nbsd_nat_target.
9549         (_initialize_mipsnbsd_nat): Adjust to C++ification.
9550         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
9551         (the_mips64_obsd_nat_target): New.
9552         (mips64obsd_fetch_inferior_registers)
9553         (mips64obsd_store_inferior_registers): Refactor as methods of
9554         mips64_obsd_nat_target.
9555         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
9556         add_target.
9557         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
9558         nbsd_nat_target.
9559         * nbsd-nat.h: Include "inf-ptrace.h".
9560         (nbsd_nat_target): New class.
9561         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
9562         (obsd_wait): Refactor as methods of obsd_nat_target.
9563         (obsd_add_target): Delete.
9564         * obsd-nat.h: Include "inf-ptrace.h".
9565         (obsd_nat_target): New class.
9566         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
9567         (the_ppc_fbsd_nat_target): New.
9568         (ppcfbsd_fetch_inferior_registers)
9569         (ppcfbsd_store_inferior_registers): Refactor as methods of
9570         ppc_fbsd_nat_target.
9571         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
9572         add_target.
9573         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
9574         (the_ppc_nbsd_nat_target): New.
9575         (ppcnbsd_fetch_inferior_registers)
9576         (ppcnbsd_store_inferior_registers): Refactor as methods of
9577         ppc_nbsd_nat_target.
9578         (_initialize_ppcnbsd_nat): Adjust to C++ification.
9579         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
9580         (the_ppc_obsd_nat_target): New.
9581         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
9582         methods of ppc_obsd_nat_target.
9583         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
9584         add_target.
9585         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
9586         (the_sh_nbsd_nat_target): New.
9587         (shnbsd_fetch_inferior_registers)
9588         (shnbsd_store_inferior_registers): Refactor as methods of
9589         sh_nbsd_nat_target.
9590         (_initialize_shnbsd_nat): Adjust to C++ification.
9591         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
9592         (inf_ptrace_xfer_partial): Delete.
9593         (sparc_xfer_partial, sparc_target): Delete.
9594         * sparc-nat.h (sparc_fetch_inferior_registers)
9595         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
9596         (sparc_target): Delete function declaration.
9597         (sparc_target): New template class.
9598         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
9599         (_initialize_sparcnbsd_nat): Adjust to C++ification.
9600         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
9601         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
9602         add_target.
9603         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
9604         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
9605         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
9606         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
9607         add_target.
9608         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
9609         (the_vax_bsd_nat_target): New.
9610         (vaxbsd_fetch_inferior_registers)
9611         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
9612         methods.
9613         (_initialize_vaxbsd_nat): Adjust to C++ification.
9614
9615         * bsd-kvm.c (bsd_kvm_target): New class.
9616         (bsd_kvm_ops): Now a bsd_kvm_target.
9617         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
9618         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
9619         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
9620         bsd_kvm_target.
9621         (bsd_kvm_return_one): Delete.
9622         (bsd_kvm_add_target): Adjust to C++ification.
9623
9624         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
9625         (nto_procfs_target_procfs): New classes.
9626         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
9627         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
9628         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
9629         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
9630         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
9631         (procfs_remove_hw_breakpoint, procfs_resume)
9632         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
9633         (procfs_kill_inferior, procfs_store_registers)
9634         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
9635         as methods of nto_procfs_target.
9636         (nto_procfs_ops): Now an nto_procfs_target_procfs.
9637         (nto_native_ops): Delete.
9638         (procfs_open, procfs_native_open): Delete.
9639         (nto_native_ops): Now an nto_procfs_target_native.
9640         (init_procfs_targets): Adjust to C++ification.
9641         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
9642         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
9643         Refactor as methods of nto_procfs_target.
9644
9645         * go32-nat.c (go32_nat_target): New class.
9646         (the_go32_nat_target): New.
9647         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
9648         (go32_store_registers, go32_xfer_partial, go32_files_info)
9649         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
9650         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
9651         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
9652         (go32_pid_to_str): Refactor as methods of go32_nat_target.
9653         (go32_target): Delete.
9654         (_initialize_go32_nat): Adjust to C++ification.
9655
9656         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
9657         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
9658         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
9659         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
9660         gnu_nat_target.
9661         (gnu_target): Delete.
9662         * gnu-nat.h (gnu_target): Delete.
9663         (gnu_nat_target): New class.
9664         * i386-gnu-nat.c (gnu_base_target): New.
9665         (i386_gnu_nat_target): New class.
9666         (the_i386_gnu_nat_target): New.
9667         (_initialize_i386gnu_nat): Adjust to C++ification.
9668
9669 2018-05-02  Pedro Alves  <palves@redhat.com>
9670
9671         * bfd-target.c (target_bfd_xclose): Rename to ...
9672         (target_bfd_close): ... this.
9673         (target_bfd_reopen): Adjust.
9674         * target.c (target_close): Remove references to to_xclose.
9675         * target.h (target_ops::to_xclose): Delete.
9676         (target_ops::to_close): Update comments.
9677
9678 2018-05-02  Pedro Alves  <palves@redhat.com>
9679
9680         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
9681         "linux-nat.h".
9682         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
9683         * inf-ptrace.c (inf_ptrace_register_u_offset)
9684         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
9685         (inf_ptrace_store_register, inf_ptrace_store_registers)
9686         (inf_ptrace_trad_target): Move to ...
9687         * linux-nat-trad.c: ... this new file.
9688         * linux-nat-trad.h: New file.
9689         * linux-nat.c (linux_target_install_ops): Make extern.
9690         (linux_trad_target): Delete.
9691         * linux-nat.h (linux_trad_target): Delete declaration.
9692         (linux_target_install_ops): Declare.
9693         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
9694         "linux-nat.h".
9695
9696 2018-05-02  Pedro Alves  <palves@redhat.com>
9697
9698         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
9699         procfs_target/add_target here.
9700         * procfs.c (procfs_target): Make static.
9701         (_initialize_procfs): Call add_target here.
9702         * procfs.h (struct target_ops): Remove forward declaration.
9703         (procfs_target): Remove declaration.
9704         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
9705
9706 2018-05-02  Pedro Alves  <palves@redhat.com>
9707
9708         * procfs.c (procfs_stopped_by_watchpoint)
9709         (procfs_insert_watchpoint, procfs_remove_watchpoint)
9710         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
9711         Forward declare.
9712         (procfs_use_watchpoints): Delete, move contents...
9713         (procfs_target): ... here.
9714         * procfs.h (procfs_use_watchpoints): Delete declaration.
9715         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
9716         procfs_use_watchpoints.
9717         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
9718         procfs_use_watchpoints.
9719
9720 2018-05-02  Tom Tromey  <tom@tromey.com>
9721
9722         PR python/20084:
9723         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
9724         and var_zuinteger_unlimited.
9725         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
9726         and PARAM_ZUINTEGER_UNLIMITED.
9727         (set_parameter_value): Handle var_zuinteger and
9728         var_zuinteger_unlimited.
9729         (add_setshow_generic): Likewise.
9730         (parmpy_init): Likewise.
9731
9732 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
9733
9734         PR rust/23124
9735         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
9736         pointer is not null before dereferencing it.
9737
9738 2018-04-30  Tom Tromey  <tom@tromey.com>
9739
9740         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
9741         is_mi_like_p.
9742
9743 2018-04-30  Tom Tromey  <tom@tromey.com>
9744
9745         * breakpoint.c (mention): Remove use of is_mi_like_p.
9746         (print_mention_ranged_breakpoint): Likewise.
9747         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
9748         of is_mi_like_p.
9749
9750 2018-04-30  Tom Tromey  <tom@tromey.com>
9751
9752         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
9753
9754 2018-04-30  Tom Tromey  <tom@tromey.com>
9755
9756         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
9757         (info_spu_event_command): Remove some uses of is_mi_like_p.
9758
9759 2018-04-30  Tom Tromey  <tom@tromey.com>
9760
9761         * python/py-framefilter.c (py_print_single_arg)
9762         (enumerate_locals, py_print_args, py_print_frame): Remove some
9763         uses of is_mi_like_p.
9764
9765 2018-04-30  Tom Tromey  <tom@tromey.com>
9766
9767         * ui-out.c: Update.
9768         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
9769         * ui-out.h (ui_out::is_mi_like_p): Now const.
9770         (ui_out::do_is_mi_like_p): Now const.
9771         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
9772
9773 2018-04-30  Tom Tromey  <tom@tromey.com>
9774
9775         * varobj.c (varobj_set_visualizer): Use new_reference.
9776         * python/python.c (gdbpy_decode_line): Use new_reference.
9777         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
9778         new_reference.
9779
9780 2018-04-30  Tom Tromey  <tom@tromey.com>
9781
9782         * varobj.c (install_new_value): Use new_reference.
9783         * value.h (value_incref): Return void.  Swap intro comment with
9784         value_decref.
9785         * value.c (set_value_parent): Use new_reference.
9786         (value_incref): Return void.  Update intro comment.
9787         (release_value): Use new_reference.
9788         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
9789
9790 2018-04-30  Tom Tromey  <tom@tromey.com>
9791
9792         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
9793         * gdb_bfd.h (new_bfd_ref): Remove.
9794         (gdb_bfd_open): Update comment.
9795         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
9796         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
9797         (gdb_bfd_fdopenr): Use new_reference.
9798         * exec.c (exec_file_attach): Use new_reference.
9799
9800 2018-04-30  Tom Tromey  <tom@tromey.com>
9801
9802         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
9803         method.
9804
9805 2018-04-30  Tom Tromey  <tom@tromey.com>
9806
9807         * jit.c (jit_read_code_entry): Use type_align.
9808         * i386-tdep.c (i386_gdbarch_init): Don't call
9809         set_gdbarch_long_long_align_bit.
9810         * gdbarch.sh: Remove long_long_align_bit.
9811         * gdbarch.c, gdbarch.h: Rebuild.
9812         * arc-tdep.c (arc_type_align): New function.
9813         (arc_gdbarch_init): Use arc_type_align.  Don't call
9814         set_gdbarch_long_long_align_bit.
9815
9816 2018-04-30  Tom Tromey  <tom@tromey.com>
9817
9818         * rust-lang.c (rust_type_alignment): Remove.
9819         (rust_composite_type): Use type_align.
9820
9821 2018-04-30  Tom Tromey  <tom@tromey.com>
9822
9823         * NEWS: Mention Type.align.
9824         * python/py-type.c (typy_get_alignof): New function.
9825         (type_object_getset): Add "alignof".
9826
9827 2018-04-30  Tom Tromey  <tom@tromey.com>
9828
9829         PR exp/17095:
9830         * NEWS: Update.
9831         * std-operator.def (UNOP_ALIGNOF): New operator.
9832         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
9833         New.
9834         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
9835         * c-lang.c (c_op_print_tab): Add alignof.
9836         * c-exp.y (ALIGNOF): New token.
9837         (exp): Add "ALIGNOF" production.
9838         (ident_tokens): Add _Alignof and alignof.
9839
9840 2018-04-30  Tom Tromey  <tom@tromey.com>
9841
9842         * i386-tdep.c (i386_type_align): New function.
9843         (i386_gdbarch_init): Update.
9844         * gdbarch.sh (type_align): New method.
9845         * gdbarch.c, gdbarch.h: Rebuild.
9846         * arch-utils.h (default_type_align): Declare.
9847         * arch-utils.c (default_type_align): New function.
9848         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
9849         (struct type) <align_log2>: New field.
9850         <instance_flags>: Now a bitfield.
9851         (TYPE_RAW_ALIGN): New macro.
9852         (type_align, type_raw_align, set_type_align): Declare.
9853         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
9854         functions.
9855         * dwarf2read.c (quirk_rust_enum): Set type alignment.
9856         (get_alignment, maybe_set_alignment): New functions.
9857         (read_structure_type, read_enumeration_type, read_array_type)
9858         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
9859         (read_subrange_type, read_base_type): Set type alignment.
9860
9861 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
9862
9863         * dwarf2read.c (read_index_from_section): Use bool.
9864
9865 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
9866
9867         PR gdb/22950
9868         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
9869         with #ifdef.
9870
9871 2018-04-29  John Reiser  <jreiser@BitWagon.com>
9872
9873         PR build/22873
9874         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
9875         last step, and do it atomically.
9876
9877 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
9878
9879         * compile/compile-c-types.c (convert_int, convert_float):
9880         Update for C FE v1.
9881
9882 2018-04-27  Tom Tromey  <tom@tromey.com>
9883
9884         PR rust/22545:
9885         * rust-lang.c (rust_inclusive_range_type_p): New function.
9886         (rust_range): Handle inclusive ranges.
9887         (rust_compute_range): Likewise.
9888         * rust-exp.y (struct rust_op) <inclusive>: New field.
9889         (DOTDOTEQ): New constant.
9890         (range_expr): Add "..=" productions.
9891         (operator_tokens): Add "..=" token.
9892         (ast_range): Add "inclusive" parameter.
9893         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
9894         ranges.
9895         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
9896         bounds values.
9897         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
9898         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
9899         Update comments.
9900         * expprint.c (print_subexp_standard): Handle new bounds values.
9901         (dump_subexp_body_standard): Likewise.
9902
9903 2018-04-27  Tom Tromey  <tom@tromey.com>
9904
9905         * configure: Rebuild.
9906         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
9907         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
9908         "OVERRIDE".
9909         (class symbol_needs_eval_context): Likewise.
9910         * dwarf2read.c (mock_mapped_index::symbol_name_count)
9911         (mock_mapped_index::symbol_name_at): Use "override".  Remove
9912         "virtual".
9913         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
9914         "override".
9915         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
9916         * aarch64-tdep.c (instruction_reader::read): Use "override".
9917         (instruction_reader_test::read): Likewise.
9918         * arm-tdep.c (instruction_reader::read): Use "override".
9919         (instruction_reader_thumb::read): Likewise.
9920
9921 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
9922
9923         PR remote/9665
9924         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
9925         instead of remote_send.
9926         (remote_send): Remove.
9927
9928 2018-04-26  Pedro Alves  <palves@redhat.com>
9929
9930         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
9931         find_function_start_sal instead of find_pc_line.
9932
9933 2018-04-26  Pedro Alves  <palves@redhat.com>
9934
9935         * breakpoint.c (set_breakpoint_location_function): Handle
9936         mst_data_gnu_ifunc.
9937         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
9938         * elfread.c (elf_symtab_read): Give data symbols with
9939         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
9940         (elf_rel_plt_read): Update comment.
9941         * linespec.c (convert_linespec_to_sals): Handle
9942         mst_data_gnu_ifunc.
9943         (minsym_found): Handle mst_data_gnu_ifunc.
9944         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
9945         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
9946         * parse.c (find_minsym_type_and_address): Handle
9947         mst_data_gnu_ifunc.
9948         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
9949         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
9950         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
9951         comment.
9952         <mst_data_gnu_ifunc>: New enumerator.
9953
9954 2018-04-26  Pedro Alves  <palves@redhat.com>
9955
9956         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
9957         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
9958         'want_trampoline' parameter by a lookup_msym_prefer parameter.
9959         Handle it.
9960         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
9961         (lookup_minimal_symbol_by_pc): Adjust.
9962         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
9963         (lookup_solib_trampoline_symbol_by_pc): Adjust.
9964         * minsyms.h (lookup_msym_prefer): New enum.
9965         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
9966         parameter by a lookup_msym_prefer parameter.
9967
9968 2018-04-26  Pedro Alves  <palves@redhat.com>
9969
9970         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
9971         ends in "@plt" instead of looking at the symbol's section.
9972
9973 2018-04-26  Pedro Alves  <palves@redhat.com>
9974
9975         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
9976         all references.
9977         (find_pc_partial_function_gnu_ifunc): Rename to ...
9978         (find_pc_partial_function): ... this, and remove references to
9979         'is_gnu_ifunc_p'.
9980         (find_pc_partial_function): Delete old implementation.
9981         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
9982
9983 2018-04-26  Pedro Alves  <palves@redhat.com>
9984
9985         * linespec.c (struct bound_minimal_symbol_search_key): New.
9986         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
9987         skip first line if we found a GNU ifunc minimal symbol by name.
9988         (compare_msymbols): Change parameters to work with a destructured
9989         lhs minsym.
9990         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
9991         functions.
9992
9993 2018-04-26  Pedro Alves  <palves@redhat.com>
9994
9995         * breakpoint.c (set_breakpoint_location_function): Don't resolve
9996         ifunc targets here.  Instead, if we have an ifunc minsym, use its
9997         address/name.
9998         (add_location_to_breakpoint): Store the minsym and the objfile in
9999         the breakpoint location.
10000         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
10001         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
10002         Record the minsym in the sal.
10003         * symtab.h (symtab_and_line) <msymbol>: New field.
10004
10005 2018-04-26  Pedro Alves  <palves@redhat.com>
10006
10007         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
10008         unless we actually resolved the ifunc.
10009
10010 2018-04-26  Pedro Alves  <palves@redhat.com>
10011
10012         * c-exp.y (variable production): Prefer ifunc minsyms over
10013         regular function symbols.
10014         * symtab.c (find_gnu_ifunc): New function.
10015         * minsyms.h (lookup_msym_prefer): New enum.
10016         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
10017         parameter by a lookup_msym_prefer parameter.
10018         * symtab.h (find_gnu_ifunc): New declaration.
10019
10020 2018-04-26  Pedro Alves  <palves@redhat.com>
10021
10022         * blockframe.c (find_gnu_ifunc_target_type): New function.
10023         (find_function_type): New.
10024         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
10025         return a value with a memory address.
10026         (eval_call): For calls to GNU ifunc functions, try to find the
10027         type of the target function from the type that the resolver
10028         returns.
10029         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
10030         symbols.
10031         * infcall.c (find_function_return_type): Delete.
10032         (find_function_addr): Add 'function_type' parameter.  For calls to
10033         GNU ifunc functions, try to find the type of the target function
10034         from the type that the resolver returns, and return it via
10035         FUNCTION_TYPE.
10036         (call_function_by_hand_dummy): Adjust to use the function type
10037         returned by find_function_addr.
10038         (find_function_addr): Add 'function_type' parameter and move
10039         description here.
10040         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
10041         declarations.
10042
10043 2018-04-26  Pedro Alves  <palves@redhat.com>
10044
10045         * c-exp.y (variable production): Skip finding an alias for ifunc
10046         symbols.
10047
10048 2018-04-26  Pedro Alves  <palves@redhat.com>
10049
10050         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
10051
10052 2018-04-25  Pedro Alves  <palves@redhat.com>
10053
10054         * infcmd.c (kill_command): Print the pid as string, not the whole
10055         thread's ptid.  Add comment.  s/has been killed/killed/ in output
10056         message.
10057         * remote.c (remote_detach_1): Print the pid as string, not the
10058         whole thread's ptid.
10059
10060 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
10061             Sergio Durigan Junior  <sergiodj@redhat.com>
10062             Pedro Alves  <palves@redhat.com>
10063
10064         * infcmd.c (kill_command): Print message when inferior has
10065         been killed.
10066         * inferior.c (print_inferior_events): Remove 'static'.  Set as
10067         '1'.
10068         (add_inferior): Improve message printed when
10069         'print_inferior_events' is on.
10070         (exit_inferior): Remove message printed when
10071         'print_inferior_events' is on.
10072         (detach_inferior): Improve message printed when
10073         'print_inferior_events' is on.
10074         (initialize_inferiors): Use 'add_inferior_silent' to set
10075         'current_inferior_'.
10076         * inferior.h (print_inferior_events): Declare here as
10077         'extern'.
10078         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
10079         '[Detaching...]' messages when 'print_inferior_events' is on.
10080         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
10081         as prefix/suffix for messages.  Remove periods.  Fix erroneous
10082         'Detaching after fork from child...', replace it by '... from
10083         parent...'.
10084         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
10085         prefix/suffix when printing 'Detaching...' messages.  Print
10086         them when 'print_inferior_events' is on.
10087         * remote.c (remote_detach_1): Print message when detaching
10088         from inferior and '!is_fork_parent'.
10089
10090 2018-04-24  Tom Tromey  <tom@tromey.com>
10091
10092         * cli-out.h: Reindent.
10093
10094 2018-04-24  Tom Tromey  <tom@tromey.com>
10095
10096         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
10097         (cli_ui_out::do_field_string): Use fputs_filtered.
10098         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
10099
10100 2018-04-23  Tom Tromey  <tom@tromey.com>
10101
10102         * guile/scm-frame.c (gdbscm_frame_read_var): Use
10103         gdb::unique_xmalloc_ptr.
10104
10105 2018-04-23  Tom Tromey  <tom@tromey.com>
10106
10107         * configure: Rebuild.
10108
10109 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
10110
10111         PR gdb/23095
10112         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
10113         prepare_for_testing.  Set normal_bp to r_debug_state if target
10114         is bsd.
10115
10116 2018-04-21  Pedro Alves  <palves@redhat.com>
10117             Rajendra SY  <rajendra.sy@gmail.com>
10118
10119         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
10120         * remote.c (extended_remote_attach): In all-stop mode, mark the
10121         thread as executing.
10122
10123 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10124
10125         * thread.c (thread_apply_all_command): Fix comment.
10126         (thread_command): Fix comment.
10127
10128 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
10129
10130         * common/tdesc.h (tdesc_create_feature): Remove xml filename
10131         parameter.
10132         * features/aarch64-core.c (create_feature_aarch64_core):
10133         Regenerate.
10134         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
10135         Likewise.
10136         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
10137         Likewise.
10138         * features/i386/32bit-avx512.c
10139         (create_feature_i386_32bit_avx512): Likewise.
10140         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
10141         Likewise.
10142         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
10143         Likewise.
10144         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
10145         Likewise.
10146         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
10147         Likewise.
10148         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
10149         Likewise.
10150         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
10151         Likewise.
10152         * features/i386/64bit-avx512.c
10153         (create_feature_i386_64bit_avx512): Likewise.
10154         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
10155         Likewise.
10156         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
10157         Likewise.
10158         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
10159         Likewise.
10160         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
10161         Likewise.
10162         * features/i386/64bit-segments.c
10163         (create_feature_i386_64bit_segments): Likewise.
10164         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
10165         Likewise.
10166         * features/i386/x32-core.c
10167         (create_feature_i386_x32_core): Likewise.
10168         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
10169         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
10170         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
10171         * target-descriptions.c: In generated code, don't pass xml
10172         filename.
10173
10174 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
10175
10176         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
10177         (print_xml_feature::visit_post): Likewise.
10178         (print_xml_feature::visit): Likewise.
10179         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
10180         (print_xml_feature): Add new class.
10181         * regformats/regdat.sh: Null xmltarget on feature targets.
10182         * target-descriptions.c (struct target_desc): Add xmltarget.
10183         (maintenance_check_tdesc_xml_convert): Add unittest function.
10184         (tdesc_get_features_xml): Add function to get xml.
10185         (maintenance_check_xml_descriptions): Test xml generation.
10186         * xml-tdesc.c (string_read_description_xml): Add function.
10187         * xml-tdesc.h (string_read_description_xml): Add declaration.
10188
10189 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
10190
10191         * features/Makefile: Add feature marker to targets with new style
10192         target descriptions.
10193         * regformats/aarch64.dat: Regenerate.
10194         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
10195         * regformats/i386/amd64-avx-linux.dat: Likewise.
10196         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
10197         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
10198         * regformats/i386/amd64-linux.dat: Likewise.
10199         * regformats/i386/amd64-mpx-linux.dat: Likewise.
10200         * regformats/i386/amd64.dat: Likewise.
10201         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
10202         * regformats/i386/i386-avx-linux.dat: Likewise.
10203         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
10204         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
10205         * regformats/i386/i386-linux.dat: Likewise.
10206         * regformats/i386/i386-mmx-linux.dat: Likewise.
10207         * regformats/i386/i386-mpx-linux.dat: Likewise.
10208         * regformats/i386/i386.dat: Likewise.
10209         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
10210         * regformats/i386/x32-avx-linux.dat: Likewise.
10211         * regformats/i386/x32-linux.dat: Likewise.
10212         * regformats/tic6x-c62x-linux.dat: Likewise.
10213         * regformats/tic6x-c64x-linux.dat: Likewise.
10214         * regformats/tic6x-c64xp-linux.dat: Likewise.
10215         * regformats/regdat.sh: Parse feature marker.
10216
10217 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
10218
10219         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
10220         (tdesc_osabi_name): Likewise.
10221         * target-descriptions.c (tdesc_architecture_name): Add new
10222         function.
10223         (tdesc_osabi_name): Likewise.
10224
10225 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
10226
10227         * common/tdesc.c (tdesc_predefined_type): Move to here.
10228         (tdesc_named_type): Likewise.
10229         (tdesc_create_vector): Likewise.
10230         (tdesc_create_struct): Likewise.
10231         (tdesc_set_struct_size): Likewise.
10232         (tdesc_create_union): Likewise.
10233         (tdesc_create_flags): Likewise.
10234         (tdesc_create_enum): Likewise.
10235         (tdesc_add_field): Likewise.
10236         (tdesc_add_typed_bitfield): Likewise.
10237         (tdesc_add_bitfield): Likewise.
10238         (tdesc_add_flag): Likewise.
10239         (tdesc_add_enum_value): Likewise.
10240         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
10241         (struct tdesc_type_vector): Likewise.
10242         (struct tdesc_type_field): Likewise.
10243         (struct tdesc_type_with_fields): Likewise.
10244         (tdesc_create_enum): Add declaration.
10245         (tdesc_add_typed_bitfield): Likewise.
10246         (tdesc_add_enum_value): Likewise.
10247         * target-descriptions.c (tdesc_type_field): Move from here.
10248         (tdesc_type_builtin): Likewise.
10249         (tdesc_type_vector): Likewise.
10250         (tdesc_type_with_fields): Likewise.
10251         (tdesc_predefined_types): Likewise.
10252         (tdesc_named_type): Likewise.
10253         (tdesc_create_vector): Likewise.
10254         (tdesc_create_struct): Likewise.
10255         (tdesc_set_struct_size): Likewise.
10256         (tdesc_create_union): Likewise.
10257         (tdesc_create_flags): Likewise.
10258         (tdesc_create_enum): Likewise.
10259         (tdesc_add_field): Likewise.
10260         (tdesc_add_typed_bitfield): Likewise.
10261         (tdesc_add_bitfield): Likewise.
10262         (tdesc_add_flag): Likewise.
10263         (tdesc_add_enum_value): Likewise.
10264         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
10265         (tdesc_add_typed_bitfield): Likewise.
10266         (tdesc_add_enum_value): Likewise.
10267
10268 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
10269
10270         * common/tdesc.c (tdesc_feature::accept): Move to here.
10271         (tdesc_feature::operator==): Likewise.
10272         (tdesc_create_reg): Likewise.
10273         * common/tdesc.h (tdesc_type_kind): Likewise.
10274         (struct tdesc_type): Likewise.
10275         (struct tdesc_feature): Likewise.
10276         * regformats/regdat.sh: Create a feature.
10277         * target-descriptions.c (tdesc_type_kind): Move from here.
10278         (tdesc_type): Likewise.
10279         (tdesc_type_up): Likewise.
10280         (tdesc_feature): Likewise.
10281         (tdesc_create_reg): Likewise.
10282
10283 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
10284
10285         * Makefile.in: Add arch/tdesc.c
10286         * common/tdesc.c: New file.
10287         * common/tdesc.h (tdesc_element_visitor): Move to here.
10288         (tdesc_element): Likewise.
10289         (tdesc_reg): Likewise.
10290         (tdesc_reg_up): Likewise.
10291         * regformats/regdef.h (reg): Add offset to constructors.
10292         * target-descriptions.c (tdesc_element_visitor): Move from here.
10293         (tdesc_element): Likewise.
10294         (tdesc_reg): Likewise.
10295         (tdesc_reg_up): Likewise.
10296
10297 2018-04-17  Tom Tromey  <tom@tromey.com>
10298
10299         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
10300         discriminant field.
10301
10302 2018-04-17  Tom Tromey  <tom@tromey.com>
10303
10304         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
10305
10306 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
10307
10308         * symtab.c (print_symbol_info): Skip printing filename and line
10309         number when `last' is NULL.
10310         (symtab_symbol_info): Use empty string instead of NULL for first
10311         invocation of print_symbol_info.
10312         (rbreak_command): Pass NULL to `last' parameter of
10313         print_symbol_info.
10314
10315 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
10316
10317         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
10318         instead of nullptr.
10319
10320 2018-04-16  Pedro Alves  <palves@redhat.com>
10321
10322         * MAINTAINERS (sh): Remove.
10323         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
10324         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
10325         (ALLDEPFILES): Remove sh64-tdep.c.
10326         * NEWS: Mentions that support for SH-5/SH64 is removed.
10327         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
10328         (sh*-*-openbsd*): Ditto.
10329         (sh64-*-elf*): Remove.
10330         (sh*): Remove.
10331         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
10332         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
10333         * sh-tdep.c: No longer include "sh64-tdep.h".
10334         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
10335         * sh64-tdep.c, sh64-tdep.h: Remove files.
10336
10337 2018-04-16  Pedro Alves  <palves@redhat.com>
10338
10339         * MAINTAINERS: Remove m88k.
10340         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
10341         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
10342         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
10343         * NEWS: Mention that support for m88k was removed.
10344         * configure.host (m88*-*-*): Remove support.
10345         * configure.nat (m88k-*-*): Remove support.
10346         * configure.tgt (m88*-*-openbsd*): Remove.
10347         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
10348
10349 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
10350
10351         * configure.tgt (x86_tobjs): New variable.
10352         (amd64_tobjs, i386_tobjs): Use it.
10353
10354 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
10355
10356         * symtab.c (print_symbol_info): Precede the symbol definition by
10357         the line number when available.
10358         * NEWS: Advertise this enhancement.
10359
10360 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
10361
10362         * NEWS (New options): announce set/show record btrace cpu.
10363         * btrace.c: Include record-btrace.h.
10364         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
10365         the vendor is unknown.
10366         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
10367         Maybe overwrite the btrace configuration's cpu.
10368         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
10369         (btrace_fetch): Add cpu parameter.  Update callers.
10370         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
10371         Maybe overwrite the btrace configuration's cpu.  Skip enabling
10372         errata workarounds if the vendor is unknown.
10373         * python/py-record-btrace.c: Include record-btrace.h.
10374         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
10375         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
10376         * record-btrace.c (record_btrace_cpu_state_kind): New.
10377         (record_btrace_cpu): New.
10378         (set_record_btrace_cpu_cmdlist): New.
10379         (record_btrace_get_cpu): New.
10380         (require_btrace_thread, record_btrace_info)
10381         (record_btrace_resume_thread): Call record_btrace_get_cpu.
10382         (cmd_set_record_btrace_cpu_none): New.
10383         (cmd_set_record_btrace_cpu_auto): New.
10384         (cmd_set_record_btrace_cpu): New.
10385         (cmd_show_record_btrace_cpu): New.
10386         (_initialize_record_btrace): Initialize set/show record btrace cpu
10387         commands.
10388         * record-btrace.h (record_btrace_get_cpu): New.
10389
10390 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
10391
10392         * record.c (set_record_command): Fix typo in message.
10393
10394 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
10395
10396         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
10397
10398 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
10399
10400         * infrun.c (process_event_stop_test): Call
10401         gdbarch_in_indirect_branch_thunk.
10402         * gdbarch.sh (in_indirect_branch_thunk): New.
10403         * gdbarch.c: Regenerated.
10404         * gdbarch.h: Regenerated.
10405         * x86-tdep.h: New.
10406         * x86-tdep.c: New.
10407         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
10408         (HFILES_NO_SRCDIR): Add x86-tdep.h.
10409         (ALLDEPFILES): Add x86-tdep.c.
10410         * arch-utils.h (default_in_indirect_branch_thunk): New.
10411         * arch-utils.c (default_in_indirect_branch_thunk): New.
10412         * i386-tdep: Include x86-tdep.h.
10413         (i386_in_indirect_branch_thunk): New.
10414         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
10415         function.
10416         * amd64-tdep: Include x86-tdep.h.
10417         (amd64_in_indirect_branch_thunk): New.
10418         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
10419
10420 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
10421
10422         PR gdb/23053
10423         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
10424         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
10425         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
10426         regression.
10427
10428 2018-04-12  Tom Tromey  <tom@tromey.com>
10429
10430         * rust-lang.c (rust_print_struct_def): Remove univariant code.
10431         (rust_evaluate_subexp): Likewise.
10432
10433 2018-04-12  Pedro Alves  <palves@redhat.com>
10434
10435         * procfs.c (procfs_detach): Make forward declaration's prototype
10436         match definition's protototype.
10437         (proc_get_LDT_entry): Remove stale do_cleanups call.
10438
10439 2018-04-12  Pedro Alves  <palves@redhat.com>
10440
10441         * target.h (target_ops::to_has_exited): Delete.
10442         (target_has_exited): Delete.
10443         * target-delegates.c: Regenerate.
10444
10445 2018-04-11  Pedro Alves  <palves@redhat.com>
10446
10447         * target.c (fileio_fh_t::t): Add comment.
10448         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
10449         (target_fileio_close): Handle a NULL target.
10450         (invalidate_fileio_fh): New.
10451         (target_close): Call it.
10452         * remote.c (remote_hostio_send_command): No longer check whether
10453         remote_desc is open.
10454
10455 2018-04-11  Pedro Alves  <palves@redhat.com>
10456
10457         * target.c (fileio_fh_t): Make it a named struct instead of a
10458         typedef.
10459         (fileio_fh_t::is_closed): New method.
10460         (DEF_VEC_O (fileio_fh_t)): Remove.
10461         (fileio_fhandles): Now a std::vector.
10462         (is_closed_fileio_fh): Delete.
10463         (acquire_fileio_fd): Adjust.  Rename parameters.
10464         (release_fileio_fd): Adjust.
10465         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
10466         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
10467         (target_fileio_close): Adjust.
10468
10469 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
10470
10471         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
10472         index.
10473
10474 2018-04-10  Pedro Alves  <palves@redhat.com>
10475
10476         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
10477         (scoped_finish_thread_state): New class.
10478         * infcmd.c (run_command_1): Use it instead of finish_thread_state
10479         cleanup.
10480         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
10481         (fetch_inferior_event, normal_stop): Likewise.
10482         * thread.c (finish_thread_state_cleanup): Delete.
10483
10484 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
10485             Pedro Alves  <palves@redhat.com>
10486
10487         * value.c: Include "selftest.h" and "common/array-view.h".
10488         (struct range) <operator ==>: New.
10489         (test_ranges_contain): New.
10490         (check_ranges_vector): New.
10491         (test_insert_into_bit_range_vector): New.
10492         (_initialize_values): Register selftests.
10493         * common/array-view.h (operator==, operator!=): New.
10494
10495 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
10496
10497         * common/gdb_vecs.h (unordered_remove): Add overload that takes
10498         an iterator.
10499         * inline-frame.c: Include <algorithm>.
10500         (struct inline_state): Add constructor.
10501         (inline_state_s): Remove.
10502         (DEF_VEC_O(inline_state_s)): Remove.
10503         (inline_states): Change type to std::vector.
10504         (find_inline_frame_state): Adjust to std::vector.
10505         (allocate_inline_frame_state): Remove.
10506         (clear_inline_frame_state): Adjust to std::vector.
10507         (skip_inline_frames): Adjust to std::vector.
10508
10509 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
10510
10511         * tracepoint.h (struct trace_state_variable): Add constructor.
10512         <name>: Change type to std::string.
10513         * tracepoint.c (tsv_s): Remove.
10514         (DEF_VEC_O(tsv_s)): Remove.
10515         (tvariables): Change to std::vector.
10516         (create_trace_state_variable): Adjust to std::vector.
10517         (find_trace_state_variable): Likewise.
10518         (find_trace_state_variable_by_number): Likewise.
10519         (delete_trace_state_variable): Likewise.
10520         (trace_variable_command): Adjust to std::string.
10521         (delete_trace_variable_command): Likewise.
10522         (tvariables_info_1): Adjust to std::vector.
10523         (save_trace_state_variables): Likewise.
10524         (start_tracing): Likewise.
10525         (merge_uploaded_trace_state_variables): Adjust to std::vector
10526         and std::string.
10527         * target.h (struct target_ops)
10528         <to_download_trace_state_variable>: Pass reference to
10529         trace_state_variable.
10530         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
10531         * target-delegates.c: Re-generate.
10532         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
10533         (mi_tsv_deleted): Likewise.
10534         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
10535         * remote.c (remote_download_trace_state_variable): Change
10536         pointer to reference and adjust.
10537         * make-target-delegates (parse_argtypes): Handle references.
10538         (write_function_header): Likewise.
10539         (munge_type): Likewise.
10540
10541 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
10542
10543         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10544         string_view-selftests.c.
10545         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
10546         testsuite.
10547         * unittests/basic_string_view/cons/char/1.cc: Likewise.
10548         * unittests/basic_string_view/cons/char/2.cc: Likewise.
10549         * unittests/basic_string_view/cons/char/3.cc: Likewise.
10550         * unittests/basic_string_view/element_access/char/1.cc:
10551         Likewise.
10552         * unittests/basic_string_view/element_access/char/empty.cc:
10553         Likewise.
10554         * unittests/basic_string_view/element_access/char/front_back.cc:
10555         Likewise.
10556         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
10557         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
10558         Likewise.
10559         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
10560         Likewise.
10561         * unittests/basic_string_view/modifiers/swap/char/1.cc:
10562         Likewise.
10563         * unittests/basic_string_view/operations/compare/char/1.cc:
10564         Likewise.
10565         * unittests/basic_string_view/operations/compare/char/13650.cc:
10566         Likewise.
10567         * unittests/basic_string_view/operations/copy/char/1.cc:
10568         Likewise.
10569         * unittests/basic_string_view/operations/data/char/1.cc:
10570         Likewise.
10571         * unittests/basic_string_view/operations/find/char/1.cc:
10572         Likewise.
10573         * unittests/basic_string_view/operations/find/char/2.cc:
10574         Likewise.
10575         * unittests/basic_string_view/operations/find/char/3.cc:
10576         Likewise.
10577         * unittests/basic_string_view/operations/find/char/4.cc:
10578         Likewise.
10579         * unittests/basic_string_view/operations/rfind/char/1.cc:
10580         Likewise.
10581         * unittests/basic_string_view/operations/rfind/char/2.cc:
10582         Likewise.
10583         * unittests/basic_string_view/operations/rfind/char/3.cc:
10584         Likewise.
10585         * unittests/basic_string_view/operations/substr/char/1.cc:
10586         Likewise.
10587         * unittests/basic_string_view/operators/char/2.cc: Likewise.
10588         * unittests/string_view-selftests.c: New file.
10589
10590 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
10591
10592         * unittests/basic_string_view/capacity/1.cc: New file.
10593         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
10594         * unittests/basic_string_view/cons/char/1.cc: New file.
10595         * unittests/basic_string_view/cons/char/2.cc: New file.
10596         * unittests/basic_string_view/cons/char/3.cc: New file.
10597         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
10598         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
10599         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
10600         * unittests/basic_string_view/element_access/char/1.cc: New file.
10601         * unittests/basic_string_view/element_access/char/2.cc: New file.
10602         * unittests/basic_string_view/element_access/char/empty.cc: New file.
10603         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
10604         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
10605         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
10606         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
10607         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
10608         * unittests/basic_string_view/include.cc: New file.
10609         * unittests/basic_string_view/inserters/char/1.cc: New file.
10610         * unittests/basic_string_view/inserters/char/2.cc: New file.
10611         * unittests/basic_string_view/inserters/char/3.cc: New file.
10612         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
10613         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
10614         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
10615         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
10616         * unittests/basic_string_view/literals/types.cc: New file.
10617         * unittests/basic_string_view/literals/values.cc: New file.
10618         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
10619         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
10620         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
10621         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
10622         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
10623         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
10624         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
10625         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
10626         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
10627         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
10628         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
10629         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
10630         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
10631         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
10632         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
10633         * unittests/basic_string_view/operations/data/char/1.cc: New file.
10634         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
10635         * unittests/basic_string_view/operations/find/char/1.cc: New file.
10636         * unittests/basic_string_view/operations/find/char/2.cc: New file.
10637         * unittests/basic_string_view/operations/find/char/3.cc: New file.
10638         * unittests/basic_string_view/operations/find/char/4.cc: New file.
10639         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
10640         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
10641         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
10642         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
10643         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
10644         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
10645         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
10646         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
10647         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
10648         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
10649         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
10650         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
10651         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
10652         * unittests/basic_string_view/operators/char/2.cc: New file.
10653         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
10654         * unittests/basic_string_view/range_access/char/1.cc: New file.
10655         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
10656         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
10657         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
10658         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
10659         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
10660         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
10661         * unittests/basic_string_view/requirements/typedefs.cc: New file.
10662         * unittests/basic_string_view/typedefs.cc: New file.
10663         * unittests/basic_string_view/types/1.cc: New file.
10664
10665 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
10666
10667         * common/gdb_string_view.h: Remove libstdc++ implementation
10668         details, adjust to gdb reality.
10669         * common/gdb_string_view.tcc: Likewise.
10670         * cli/cli-script.c (struct string_view): Remove.
10671         (user_args) <m_args>: Change element type to gdb::string_view.
10672         (user_args::insert_args): Adjust.
10673
10674 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
10675
10676         * common/gdb_string_view.h: New file.
10677         * common/gdb_string_view.tcc: New file.
10678
10679 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
10680
10681         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
10682         * configure: Re-generate.
10683
10684 2018-04-09  Pedro Alves  <palves@redhat.com>
10685
10686         * gdbarch.sh: Include "observable.h" instead of "observer.h".
10687         (set_target_gdbarch): Call
10688         gdb::observers::architecture_changed.notify instead of
10689         observer_notify_architecture_changed.
10690
10691 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10692
10693         * tracepoint.c (struct current_traceframe_cleanup): Remove.
10694         (do_restore_current_traceframe_cleanup): Remove.
10695         (restore_current_traceframe_cleanup_dtor): Remove.
10696         (make_cleanup_restore_current_traceframe): Remove.
10697         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
10698         New.
10699         * tracepoint.h (struct scoped_restore_current_traceframe): New.
10700         * infrun.c (fetch_inferior_event): Use
10701         scoped_restore_current_traceframe.
10702
10703 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10704
10705         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
10706         Remove.
10707         <n_allocated_type_units>: Remove.
10708         <all_type_units>: Change to std::vector.
10709         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
10710         to std::vector change.
10711         (dwarf2_per_objfile::get_cutu): Likewise.
10712         (dwarf2_per_objfile::get_tu): Likewise.
10713         (create_signatured_type_table_from_index): Likewise.
10714         (create_signatured_type_table_from_debug_names): Likewise.
10715         (dw2_symtab_iter_next): Likewise.
10716         (dw2_print_stats): Likewise.
10717         (dw2_expand_all_symtabs): Likewise.
10718         (dw2_expand_marked_cus): Likewise.
10719         (dw2_debug_names_iterator::next): Likewise.
10720         (dwarf2_initialize_objfile): Likewise.
10721         (add_signatured_type_cu_to_table): Likewise.
10722         (create_all_type_units): Likewise.
10723         (add_type_unit): Likewise.
10724         (struct tu_abbrev_offset): Add constructor.
10725         (build_type_psymtabs_1): Adjust to std::vector change.
10726         (print_tu_stats): Likewise.
10727         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
10728         (write_debug_names): Likewise.
10729
10730 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10731
10732         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
10733         Make an std::vector.
10734         <n_comp_units>: Remove.
10735         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
10736         to std::vector change.
10737         (dwarf2_per_objfile::get_cutu): Likewise.
10738         (dwarf2_per_objfile::get_cu): Likewise.
10739         (create_cus_from_index): Likewise.
10740         (create_addrmap_from_index): Likewise.
10741         (create_addrmap_from_aranges): Likewise.
10742         (dwarf2_read_index): Likewise.
10743         (dw2_find_last_source_symtab): Likewise.
10744         (dw2_map_symtabs_matching_filename): Likewise.
10745         (dw2_symtab_iter_next): Likewise.
10746         (dw2_print_stats): Likewise.
10747         (dw2_expand_all_symtabs): Likewise.
10748         (dw2_expand_symtabs_with_fullname): Likewise.
10749         (dw2_expand_marked_cus): Likewise.
10750         (dw2_map_symbol_filenames): Likewise.
10751         (create_cus_from_debug_names): Likewise.
10752         (dwarf2_read_debug_names): Likewise.
10753         (dw2_debug_names_iterator::next): Likewise.
10754         (dwarf2_initialize_objfile): Likewise.
10755         (set_partial_user): Likewise.
10756         (dwarf2_build_psymtabs_hard): Likewise.
10757         (read_comp_units_from_section): Remove arguments, adjust to
10758         std::vector change.
10759         (create_all_comp_units): Adjust to std::vector and
10760         read_comp_units_from_section changes.
10761         (dwarf2_find_containing_comp_unit): Adjust to std::vector
10762         change.
10763         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
10764         (psyms_seen_size): Likewise.
10765         (write_gdbindex): Likewise.
10766         (write_debug_names): Likewise.
10767
10768 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10769
10770         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
10771         with dwarf2_per_objfile.
10772         (create_cus_from_index): Likewise.
10773         (create_signatured_type_table_from_index): Likewise.
10774         (dwarf2_read_index): Likewise.
10775         (dwarf2_initialize_objfile): Likewise.
10776         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
10777         per_cu rather than get_dwarf2_per_objfile.
10778
10779 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10780
10781         * dwarf2read.h (struct signatured_type): Forward declare.
10782         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
10783         New methods.
10784         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
10785         (dw2_get_cutu): ...this.
10786         (dwarf2_per_objfile::get_cu): Rename from...
10787         (dw2_get_cu): ...this.
10788         (dwarf2_per_objfile::get_tu): New.
10789         (create_addrmap_from_index): Adjust.
10790         (create_addrmap_from_aranges): Adjust.
10791         (dw2_find_last_source_symtab): Adjust.
10792         (dw2_map_symtabs_matching_filename): Adjust.
10793         (dw2_symtab_iter_next): Adjust.
10794         (dw2_print_stats): Adjust.
10795         (dw2_expand_all_symtabs): Adjust.
10796         (dw2_expand_symtabs_with_fullname): Adjust.
10797         (dw2_expand_marked_cus): Adjust.
10798         (dw_expand_symtabs_matching_file_matcher): Adjust.
10799         (dw2_map_symbol_filenames): Adjust.
10800         (dw2_debug_names_iterator::next): Adjust.
10801         (dwarf2_initialize_objfile): Adjust.
10802         (set_partial_user): Adjust.
10803         (dwarf2_build_psymtabs_hard): Adjust.
10804
10805 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10806
10807         * dwarf2read.c (create_signatured_type_table_from_debug_names):
10808         Remove unused variables.
10809         (dw2_map_symtabs_matching_filename): Likewise.
10810         (dwarf2_record_block_ranges): Likewise.
10811         (dwarf2_read_addr_index): Likewise.
10812         (follow_die_offset): Likewise.
10813
10814 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10815
10816         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
10817         to symbol_file_add_main.
10818
10819 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10820
10821         PR mi/22299
10822         * mi/mi-console.c (do_fputc_async_safe): New.
10823         (mi_console_file::write_async_safe): New.
10824         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
10825         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
10826         New.
10827         * ui-file.c (ui_file::putstrn): Adjust call to
10828         fputstrn_unfiltered.
10829         * utils.c (printchar): Replace do_fputs and do_fprintf
10830         parameters by do_fputc.
10831         (fputstr_filtered): Adjust call to printchar.
10832         (fputstr_unfiltered): Likewise.
10833         (fputstrn_filtered): Likewise.
10834         (fputstrn_unfiltered): Add do_fputc parameter, pass to
10835         printchar.
10836         * utils.h (do_fputc_ftype): New typedef.
10837         (fputstrn_unfiltered): Add do_fputc parameter.
10838
10839 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
10840
10841         * regformats/i386/i386-avx.dat: Remove.
10842
10843 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
10844
10845         PR gdb/22979
10846         * amd64-tdep.c (amd64_none_init_abi): New function.
10847         (amd64_x32_none_init_abi): New function.
10848         (_initialize_amd64_tdep): Register handlers for x86-64 and
10849         x64_32 with GDB_OSABI_NONE.
10850         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
10851         GDB_OSABI_NONE osabi.
10852
10853 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
10854
10855         PR gdb/22980
10856         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
10857         GDB_OSABI_NONE.
10858         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
10859         * osabi.c (gdb_osabi_names): Add "unknown" entry.
10860
10861 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
10862
10863         * common/byte-vector.h (char_vector): New type.
10864         * target.h (target_read_alloc): Return
10865         gdb::optional<byte_vector>.
10866         (target_read_stralloc): Return gdb::optional<char_vector>.
10867         (target_get_osdata): Return gdb::optional<char_vector>.
10868         * target.c (target_read_alloc_1): Templatize.  Replacement
10869         manual memory management with vector.
10870         (target_read_alloc): Change return type, adjust.
10871         (target_read_stralloc): Change return type, adjust.
10872         (target_get_osdata): Change return type, adjust.
10873         * auxv.c (struct auxv_info) <length>: Remove.
10874         <data>: Change type to gdb::optional<byte_vector>.
10875         (auxv_inferior_data_cleanup): Free auxv_info with delete.
10876         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
10877         (target_auxv_search): Adjust.
10878         (fprint_target_auxv): Adjust.
10879         * avr-tdep.c (avr_io_reg_read_command): Adjust.
10880         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
10881         (linux_make_corefile_notes): Adjust.
10882         * osdata.c (get_osdata): Adjust.
10883         * remote.c (remote_get_threads_with_qxfer): Adjust.
10884         (remote_memory_map): Adjust.
10885         (remote_traceframe_info): Adjust.
10886         (btrace_read_config): Adjust.
10887         (remote_read_btrace): Adjust.
10888         (remote_pid_to_exec_file): Adjust.
10889         * solib-aix.c (solib_aix_get_library_list): Adjust.
10890         * solib-dsbt.c (decode_loadmap): Don't free buf.
10891         (dsbt_get_initial_loadmaps): Adjust.
10892         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
10893         * solib-target.c (solib_target_current_sos): Adjust.
10894         * tracepoint.c (sdata_make_value): Adjust.
10895         * xml-support.c (xinclude_start_include): Adjust.
10896         (xml_fetch_content_from_file): Adjust.
10897         * xml-support.h (xml_fetch_another): Change return type.
10898         (xml_fetch_content_from_file): Change return type.
10899         * xml-syscall.c (xml_init_syscalls_info): Adjust.
10900         * xml-tdesc.c (file_read_description_xml): Adjust.
10901         (fetch_available_features_from_target): Change return type.
10902         (target_fetch_description_xml): Adjust.
10903         (target_read_description_xml): Adjust.
10904
10905 2018-04-06  Tom Tromey  <tom@tromey.com>
10906
10907         * value.c (~value): Update.
10908         (struct value) <contents>: Now unique_xmalloc_ptr.
10909         (value_contents_bits_eq, allocate_value_contents)
10910         (value_contents_raw, value_contents_all_raw)
10911         (value_contents_for_printing, value_contents_for_printing_const)
10912         (set_value_enclosing_type): Update.
10913
10914 2018-04-06  Tom Tromey  <tom@tromey.com>
10915
10916         * value.c (range_s): Remove typedef, VEC.
10917         (struct range): Add operator<.
10918         (range_lessthan): Remove.
10919         (ranges_contain): Change type.
10920         (~value): Update.
10921         (struct value) <unavailable, optimized_out>: Now std::vector.
10922         (value_entirely_available)
10923         (value_entirely_covered_by_range_vector)
10924         (value_entirely_unavailable, value_entirely_optimized_out):
10925         Update.
10926         (insert_into_bit_range_vector): Change argument type.
10927         (find_first_range_overlap): Likewise.
10928         (struct ranges_and_idx, value_contents_bits_eq)
10929         (require_not_optimized_out, require_available): Update.
10930         (ranges_copy_adjusted): Change argument types.
10931         (value_optimized_out, value_copy, value_fetch_lazy): Update.
10932
10933 2018-04-06  Tom Tromey  <tom@tromey.com>
10934
10935         * value.c (~value): Update.
10936         (struct value) <parent>: Now a value_ref_ptr.
10937         (value_parent, set_value_parent, value_address, value_copy):
10938         Update.
10939
10940 2018-04-06  Tom Tromey  <tom@tromey.com>
10941
10942         * value.c (struct value): Add constructor, destructor, and member
10943         initializers.
10944         (allocate_value_lazy, value_decref): Update.
10945
10946 2018-04-06  Tom Tromey  <tom@tromey.com>
10947
10948         * value.c (struct value) <released, next>: Remove.
10949         (all_values): Now a std::vector.
10950         (allocate_value_lazy): Update.
10951         (value_next): Remove.
10952         (value_mark, value_free_to_mark, release_value)
10953         (value_release_to_mark): Update.
10954
10955 2018-04-06  Tom Tromey  <tom@tromey.com>
10956
10957         * value.h (fetch_subexp_value, value_release_to_mark): Update.
10958         (free_value_chain): Remove.
10959         * value.c (free_value_chain): Remove.
10960         (value_release_to_mark): Return a std::vector.
10961         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
10962         std::vector.
10963         (check_condition): Update.
10964         * eval.c (fetch_subexp_value): Change "val_chain" to a
10965         std::vector.
10966         * breakpoint.c (update_watchpoint): Update.
10967         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
10968
10969 2018-04-06  Tom Tromey  <tom@tromey.com>
10970
10971         * value.h (free_all_values): Remove.
10972         * value.c (free_all_values): Remove.
10973
10974 2018-04-06  Tom Tromey  <tom@tromey.com>
10975
10976         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
10977         (value_history_chain, value_history_count): Remove.
10978         (value_history): New global.
10979         (record_latest_value, access_value_history, show_values)
10980         (preserve_values): Update.
10981
10982 2018-04-06  Tom Tromey  <tom@tromey.com>
10983
10984         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
10985         * varobj.c (varobj_set_display_format, varobj_set_value)
10986         (install_default_visualizer, construct_visualizer)
10987         (install_new_value, ~varobj, varobj_get_value_type)
10988         (my_value_of_variable, varobj_editable_p): Update.
10989         * c-varobj.c (c_describe_child, c_value_of_variable)
10990         (cplus_number_of_children, cplus_describe_child): Update.
10991         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
10992         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
10993         (ada_value_of_variable, ada_value_is_changeable_p): Update.
10994
10995 2018-04-06  Tom Tromey  <tom@tromey.com>
10996
10997         * printcmd.c (last_examine_address): Change type to
10998         value_ref_ptr.
10999         (do_examine, x_command): Update.
11000
11001 2018-04-06  Tom Tromey  <tom@tromey.com>
11002
11003         * value.c (release_value): Update.
11004         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
11005         (struct bpstats) <val>: Now a value_ref_ptr.
11006         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
11007         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
11008         (~watchpoint, print_it_watchpoint, watch_command_1)
11009         (invalidate_bp_value_on_memory_change): Update.
11010
11011 2018-04-06  Tom Tromey  <tom@tromey.com>
11012
11013         * varobj.c (varobj_clear_saved_item)
11014         (update_dynamic_varobj_children, install_new_value, ~varobj):
11015         Update.
11016         * value.h (value_incref): Move declaration earlier.
11017         (value_decref): Rename from value_free.
11018         (struct value_ref_policy): New.
11019         (value_ref_ptr): New typedef.
11020         (struct value_deleter): Remove.
11021         (gdb_value_up): Remove typedef.
11022         (release_value): Change return type.
11023         (release_value_or_incref): Remove.
11024         * value.c (set_value_parent): Update.
11025         (value_incref): Change return type.
11026         (value_decref): Rename from value_free.
11027         (value_free_to_mark, free_all_values, free_value_chain): Update.
11028         (release_value): Return value_ref_ptr.
11029         (release_value_or_incref): Remove.
11030         (record_latest_value, set_internalvar, clear_internalvar):
11031         Update.
11032         * stack.c (info_frame_command): Don't call value_free.
11033         * python/py-value.c (valpy_dealloc, valpy_new)
11034         (value_to_value_object): Update.
11035         * printcmd.c (do_examine): Update.
11036         * opencl-lang.c (lval_func_free_closure): Update.
11037         * mi/mi-main.c (register_changed_p): Don't call value_free.
11038         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
11039         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
11040         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
11041         value_free.
11042         * guile/scm-value.c (vlscm_free_value_smob)
11043         (vlscm_scm_from_value): Update.
11044         * frame.c (frame_register_unwind, frame_unwind_register_signed)
11045         (frame_unwind_register_unsigned, get_frame_register_bytes)
11046         (put_frame_register_bytes): Don't call value_free.
11047         * findvar.c (address_from_register): Don't call value_free.
11048         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
11049         * dwarf2loc.c (entry_data_value_free_closure)
11050         (value_of_dwarf_reg_entry, free_pieced_value_closure)
11051         (dwarf2_evaluate_loc_desc_full): Update.
11052         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
11053         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
11054         (~watchpoint, watch_command_1)
11055         (invalidate_bp_value_on_memory_change): Update.
11056         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
11057
11058 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
11059
11060         PR gdb/23022
11061         * warning.m4: Add -Wno-error=deprecated-register.
11062         * configure: Re-generate.
11063
11064 2018-04-05  Tom Tromey  <tom@tromey.com>
11065
11066         * linespec.h: Remove include of "vec.h".
11067
11068 2018-04-05  Tom Tromey  <tom@tromey.com>
11069
11070         * linespec.c (typep): Remove typedef.
11071         (find_methods, find_superclass_methods): Take a std::vector.
11072         (find_method): Use std::vector.
11073
11074 2018-04-05  Tom Tromey  <tom@tromey.com>
11075
11076         * utils.c (compare_strings): Remove.
11077         * utils.h (compare_strings): Remove.
11078         * objc-lang.h (find_imps): Update.
11079         * objc-lang.c (find_methods): Take a std::vector.
11080         (uniquify_strings, find_imps): Likewise.
11081         * linespec.c (find_methods): Take a std::vector.
11082         (decode_objc): Use std::vector.
11083         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
11084         a std::vector.
11085         (find_method, find_function_symbols): Use std::vector.
11086
11087 2018-04-05  Tom Tromey  <tom@tromey.com>
11088
11089         * completer.c (completion_tracker::completion_tracker): Remove
11090         cast.
11091         (completion_tracker::discard_completions): Likewise.
11092         * breakpoint.c (ambiguous_names_p): Remove cast.
11093         * ada-lang.c (_initialize_ada_language): Remove cast.
11094         * utils.h (streq): Update.
11095         (streq_hash): Add new declaration.
11096         * utils.c (streq): Return bool.
11097         (streq_hash): New function.
11098
11099 2018-04-05  Tom Tromey  <tom@tromey.com>
11100
11101         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
11102         Remove a string copy.
11103
11104 2018-04-05  Tom Tromey  <tom@tromey.com>
11105
11106         * linespec.c (filter_results): Use std::vector.
11107         (decode_line_2, decode_line_full): Update.
11108
11109 2018-04-05  Tom Tromey  <tom@tromey.com>
11110
11111         * linespec.c (canonical_to_fullform): Return std::string.
11112         (filter_results): Update.
11113         (struct decode_line_2_item): Add constructor.
11114         <fullform, displayform>: Now std::string.
11115         (decode_line_2_compare_items): Now a std::sort comparator.
11116         (decode_line_2): Update.
11117
11118 2018-04-05  Tom Tromey  <tom@tromey.com>
11119
11120         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
11121         (unexpected_linespec_error): Update.
11122         (linespec_parse_basic, parse_linespec): Update.
11123
11124 2018-04-05  Tom Tromey  <tom@tromey.com>
11125
11126         * linespec.c (linespec_parse_basic): Reindent.
11127
11128 2018-04-05  Tom Tromey  <tom@tromey.com>
11129
11130         * minsyms.h (iterate_over_minimal_symbols): Update.
11131         * minsyms.c (iterate_over_minimal_symbols): Take a
11132         gdb::function_view.
11133         * linespec.c (struct collect_minsyms): Remove.
11134         (compare_msyms): Now a std::sort comparator.
11135         (add_minsym): Add parameters.
11136         (search_minsyms_for_name): Update.  Use std::vector.
11137
11138 2018-04-03  Tom Tromey  <tom@tromey.com>
11139
11140         * mipsread.c (read_alphacoff_dynamic_symtab): Use
11141         gdb::byte_vector.
11142
11143 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
11144
11145         * MAINTAINERS (Write After Approval): Add Weimin Pan.
11146
11147 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
11148
11149         PR gdb/16959
11150         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
11151         printing static type.
11152
11153 2018-04-01  Tom Tromey  <tom@tromey.com>
11154
11155         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
11156         (rs6000_xfer_shared_libraries): Update.
11157
11158 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
11159
11160         * common/gdb_vecs.h (char_ptr): Remove.
11161         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
11162
11163 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
11164
11165         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
11166         with std::vector.
11167         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
11168
11169 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
11170
11171         * tracepoint.h (struct uploaded_tp): Initialize fields.
11172         <actions, step_actions, cmd_strings>: Change type to
11173         std::vector<char *>.
11174         * tracepoint.c (get_uploaded_tp): Allocate with new.
11175         (free_uploaded_tps): Free with delete.
11176         (parse_tracepoint_definition): Adjust to std::vector change.
11177         * breakpoint.c (read_uploaded_action): Likewise.
11178         (create_tracepoint_from_upload): Likewise.
11179         * ctf.c (ctf_write_uploaded_tp): Likewise.
11180         (SET_ARRAY_FIELD): Likewise.
11181         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
11182
11183 2018-03-30  Tom Tromey  <tom@tromey.com>
11184
11185         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
11186         std::unique_ptr.
11187         (svr4_keep_data_in_core): Update.
11188         (svr4_read_so_list): Update.
11189
11190 2018-03-30  Tom Tromey  <tom@tromey.com>
11191
11192         * windows-nat.c (handle_output_debug_string, handle_exception):
11193         Update.
11194         * target.h (target_read_string): Update.
11195         * target.c (target_read_string): Change "string" to
11196         unique_xmalloc_ptr.
11197         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
11198         Update.
11199         * solib-frv.c (frv_current_sos): Update.
11200         * solib-dsbt.c (dsbt_current_sos): Update.
11201         * solib-darwin.c (darwin_current_sos): Update.
11202         * linux-thread-db.c (inferior_has_bug): Update.
11203         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
11204         Update.  Remove alloca.
11205         * ada-lang.c (ada_main_name): Update.
11206
11207 2018-03-30  Tom Tromey  <tom@tromey.com>
11208
11209         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
11210         (struct dwo_file_deleter): New.
11211         (dwo_file_up): New typedef.
11212         (open_and_init_dwo_file): Use dwo_file_up.
11213         (free_dwo_file_cleanup): Remove.
11214
11215 2018-03-30  Tom Tromey  <tom@tromey.com>
11216
11217         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
11218         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
11219
11220 2018-03-30  Tom Tromey  <tom@tromey.com>
11221
11222         * dwarf2read.c (class free_cached_comp_units): New class.
11223         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
11224         (free_cached_comp_units): Remove function.
11225
11226 2018-03-30  Tom Tromey  <tom@tromey.com>
11227
11228         * utils.h (make_cleanup_unpush_target): Remove.
11229         * inf-ptrace.c (struct target_unpusher): New.
11230         (target_unpush_up) New typedef.
11231         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
11232         target_unpush_up.
11233         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
11234
11235 2018-03-27  Tom Tromey  <tom@tromey.com>
11236
11237         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
11238
11239 2018-03-27  Pedro Alves  <palves@redhat.com>
11240             Tom Tromey  <tom@tromey.com>
11241
11242         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
11243         destructor.  Now a class.
11244         (gdb_readline_wrapper_cleanup): Remove function.
11245         (gdb_readline_wrapper): Remove cleanups.
11246
11247 2018-03-27  Tom Tromey  <tom@tromey.com>
11248
11249         * typeprint.h (struct type_print_options) <local_typedefs,
11250         global_typedefs>: Remove "struct" keyword.
11251         (class typedef_hash_table): New class.
11252         (recursively_update_typedef_hash, add_template_parameters)
11253         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
11254         (find_typedef_in_hash): Don't declare.
11255         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
11256         (typedef_hash_table::recursively_update): Rename from
11257         recursively_update_typedef_hash.  Now a member.
11258         (typedef_hash_table::add_template_parameters): Rename from
11259         add_template_parameters.  Now a member.
11260         (typedef_hash_table::typedef_hash_table): Now a constructor;
11261         rename from create_typedef_hash.
11262         (typedef_hash_table::~typedef_hash_table): Now a destructor;
11263         rename from free_typedef_hash.
11264         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
11265         (do_free_global_table): Remove.
11266         (typedef_hash_table::typedef_hash_table): New constructor; renamed
11267         from copy_type_recursive.
11268         (create_global_typedef_table): Remove.
11269         (typedef_hash_table::find_global_typedef): Now a member of
11270         typedef_hash_table.
11271         (typedef_hash_table::find_typedef): Rename from
11272         find_typedef_in_hash; now a member.
11273         (whatis_exp): Update.
11274         * extension.h (struct ext_lang_type_printers): Add constructor and
11275         destructor.
11276         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
11277         declare.
11278         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
11279         Now a constructor; rename from start_ext_lang_type_printers.
11280         (ext_lang_type_printers): Now a destructor; rename from
11281         free_ext_lang_type_printers.
11282         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
11283         Update.
11284         (c_type_print_base_struct_union): Update.  Remove cleanups.
11285
11286 2018-03-27  Tom Tromey  <tom@tromey.com>
11287
11288         * dwarf-index-write.c: Include <cmath>.
11289
11290 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
11291
11292         * NEWS: Add entry describing new "set|show varsize-limit" command.
11293         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
11294         command.
11295         * printcmd.c (_initialize_printcmd): Add "set var" alias of
11296         "set variable".
11297
11298 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
11299
11300         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
11301         dwarf-index-write.c
11302         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
11303         * dwarf-index-common.c: New file.
11304         * dwarf-index-common.h: New file.
11305         * dwarf-index-write.c: New file.
11306         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
11307         (struct dwarf2_section_info): Move from here.
11308         (dwarf2_section_info_def): Likewise.
11309         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
11310         (offset_type): Likewise.
11311         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
11312         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
11313         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
11314         (byte_swap): Likewise.
11315         (MAYBE_SWAP): Likewise.
11316         (dwarf2_per_cu_ptr): Likewise.
11317         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
11318         (struct tu_stats): Likewise.
11319         (struct dwarf2_per_objfile): Likewise.
11320         (struct dwarf2_per_cu_data): Likewise.
11321         (struct signatured_type): Likewise.
11322         (sig_type_ptr): Likewise.
11323         (DEF_VEC_P (sig_type_ptr)): Likewise.
11324         (INDEX4_SUFFIX): Likewise.
11325         (INDEX5_SUFFIX): Likewise.
11326         (DEBUG_STR_SUFFIX): Likewise.
11327         (dwarf2_read_section): Make non-static.
11328         (mapped_index_string_hash): Move from here.
11329         (dwarf5_djb_hash): Likewise.
11330         (file_write): Likewise.
11331         (class data_buf): Likewise.
11332         (struct symtab_index_entry): Likewise.
11333         (struct mapped_symtab): Likewise.
11334         (find_slot): Likewise.
11335         (hash_expand): Likewise.
11336         (add_index_entry): Likewise.
11337         (uniquify_cu_indices): Likewise.
11338         (class c_str_view): Likewise.
11339         (class c_str_view_hasher): Likewise.
11340         (class vector_hasher): Likewise.
11341         (write_hash_table): Likewise.
11342         (psym_index_map): Likewise.
11343         (struct addrmap_index_data): Likewise.
11344         (add_address_entry): Likewise.
11345         (add_address_entry_worker): Likewise.
11346         (write_address_map): Likewise.
11347         (symbol_kind): Likewise.
11348         (write_psymbols): Likewise.
11349         (struct signatured_type_index_data): Likewise.
11350         (write_one_signatured_type): Likewise.
11351         (recursively_count_psymbols): Likewise.
11352         (recursively_write_psymbols): Likewise.
11353         (class debug_names): Likewise.
11354         (check_dwarf64_offsets): Likewise.
11355         (psyms_seen_size): Likewise.
11356         (write_gdbindex): Likewise.
11357         (write_debug_names): Likewise.
11358         (assert_file_size): Likewise.
11359         (write_psymtabs_to_index): Likewise.
11360         (save_gdb_index_command): Likewise.
11361         (_initialize_dwarf2_read): Don't register the "save gdb-index"
11362         command.
11363         * dwarf2read.h: New file.
11364
11365 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
11366
11367         PR gdb/22670
11368         * dwarf2read.c (dwarf2_physname): Do not return the demangled
11369         symbol name if the CU's language stores symbol names in linkage
11370         format.
11371         * language.h (struct language_defn)
11372         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
11373         all instances of this struct.
11374
11375 2018-03-26  Tom Tromey  <tom@tromey.com>
11376
11377         * stack.c (backtrace_command_1): Remove verbose code.
11378
11379 2018-03-26  Tom Tromey  <tom@tromey.com>
11380
11381         * python/py-framefilter.c (py_print_type): Don't catch
11382         exceptions.  Return void.
11383         (py_print_value): Likewise.
11384         (py_print_single_arg): Likewise.
11385         (enumerate_args): Don't catch exceptions.
11386         (py_print_args): Likewise.
11387         (py_print_frame): Likewise.
11388         (gdbpy_apply_frame_filter): Catch exceptions here.
11389
11390 2018-03-26  Tom Tromey  <tom@tromey.com>
11391
11392         * stack.c (_initialize_stack): Remove trailing newlines from help
11393         text.  Add "Usage" line to "backtrace" help.
11394
11395 2018-03-26  Tom Tromey  <tom@tromey.com>
11396
11397         PR python/16486:
11398         * python/py-framefilter.c (py_print_args): Call wrap_hint.
11399
11400 2018-03-26  Tom Tromey  <tom@tromey.com>
11401
11402         * python/py-framefilter.c (py_print_single_arg): Return
11403         EXT_LANG_BT_ERROR from catch.
11404
11405 2018-03-26  Tom Tromey  <tom@tromey.com>
11406
11407         PR backtrace/15584:
11408         * stack.c (backtrace_command_1): Move some code into no-filters
11409         "if".
11410
11411 2018-03-26  Tom Tromey  <tom@tromey.com>
11412
11413         * python/py-framefilter.c (throw_quit_or_print_exception): New
11414         function.
11415         (gdbpy_apply_frame_filter): Use it.
11416
11417 2018-03-26  Tom Tromey  <tom@tromey.com>
11418
11419         PR cli/17716:
11420         * python/py-framefilter.c (py_print_type, py_print_value)
11421         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
11422         RETURN_MASK_ERROR.
11423
11424 2018-03-26  Tom Tromey  <tom@tromey.com>
11425
11426         * python/py-framefilter.c (enumerate_args): Use
11427         gdb::unique_xmalloc_ptr.
11428
11429 2018-03-26  Tom Tromey  <tom@tromey.com>
11430
11431         * python/py-framefilter.c (py_print_frame): Return
11432         EXT_LANG_BT_OK.
11433         (gdbpy_apply_frame_filter): Update comment.
11434         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
11435         Remove.
11436         <EXT_LANG_BT_NO_FILTERS>: Change value.
11437
11438 2018-03-26  Tom Tromey  <tom@tromey.com>
11439
11440         PR backtrace/15582:
11441         * stack.c (backtrace_command): Parse "hide" argument.
11442         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
11443         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
11444         constant.
11445
11446 2018-03-26  Tom Tromey  <tom@tromey.com>
11447
11448         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
11449         add "flags".
11450         (backtrace_command): Remove "fulltrace", add "flags".
11451
11452 2018-03-26  Tom Tromey  <tom@tromey.com>
11453
11454         * stack.c (backtrace_command): Rewrite command line parsing.
11455
11456 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
11457
11458         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
11459
11460 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
11461
11462         * filename-seen-cache.h: Add include guard.
11463
11464 2018-03-26  Keith Seitz  <keiths@redhat.com>
11465
11466         * symfile.c (place_section): Remove "struct" from section_addr_info
11467         in comment.
11468         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
11469         "struct" keyword from section_addr_info.
11470
11471 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
11472
11473         * regformats/regdef.h (reg): Add constructors.
11474
11475 2018-03-25  Pedro Alves  <palves@redhat.com>
11476
11477         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
11478         if then/else bodies in var_func_name extraction.
11479
11480 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
11481
11482         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
11483         lookup_minimal_symbol() to find symbol entry.
11484         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
11485
11486 2018-03-23  Keith Seitz  <keiths@redhat.com>
11487
11488         PR c++/22968
11489         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
11490         nested type definitions for C++, too.
11491
11492 2018-03-23  Tom Tromey  <tom@tromey.com>
11493
11494         * machoread.c (struct oso_el): Add a constructor.  Don't define as
11495         a typedef.
11496         (macho_register_oso): Remove.
11497         (macho_symtab_read): Take a std::vector.
11498         (oso_el_compare_name): Now a std::sort comparator.
11499         (macho_symfile_read_all_oso): Take a std::vector.
11500         (macho_symfile_read): Use std::vector.  Remove cleanups.
11501
11502 2018-03-22  Tom Tromey  <tom@tromey.com>
11503
11504         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
11505         (record_full_goto_bookmark): Use std::string.
11506
11507 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
11508
11509         PR tdep/18295
11510         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
11511         a single mask.
11512
11513 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
11514
11515         * rs6000-tdep.c (store_insn_p): New function.
11516         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
11517         and cr_reg to their unshifted values. Use store_insn_p to
11518         match LR saves using either R1 or fdata->alloca_reg. Use
11519         store_insn_p to match CR saves. Set alloca_reg_offset
11520         when alloca_reg and framep are set. Remove lr_reg shift
11521         when assigning to fdata->lr_register.
11522
11523 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
11524
11525         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
11526         command line args instead of emitting a warning.
11527
11528 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
11529
11530         * tracepoint.h (struct static_tracepoint_marker): Initialize
11531         fields, define default constructor, move constructor and move
11532         assignment, disable the rest.
11533         <str_id, extra>: Make std::string.
11534         (release_static_tracepoint_marker): Remove.
11535         (free_current_marker): Remove.
11536         * tracepoint.c (free_current_marker): Remove.
11537         (parse_static_tracepoint_marker_definition): Adjust to
11538         std::string, use new hex2str overload.
11539         (release_static_tracepoint_marker): Remove.
11540         (print_one_static_tracepoint_marker): Get marker by reference
11541         and adjust to std::string.
11542         (info_static_tracepoint_markers_command): Adjust to std::vector
11543         changes
11544         * target.h (static_tracepoint_marker_p): Remove typedef.
11545         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
11546         (struct target_ops) <to_static_tracepoint_marker_at>: Return
11547         bool.
11548         <to_static_tracepoint_markers_by_strid>: Return std::vector.
11549         * target-debug.h
11550         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
11551         (target_debug_print_std_vector_static_tracepoint_marker): New.
11552         (target_debug_print_struct_static_tracepoint_marker_p): Rename
11553         to...
11554         (target_debug_print_static_tracepoint_marker_p): ... this.
11555         * target-delegates.c: Re-generate.
11556         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
11557         Make std::string.
11558         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
11559         (decode_static_tracepoint_spec): Adjust to std::vector.
11560         (tracepoint_print_one_detail): Adjust to std::string.
11561         (strace_marker_decode_location): Adjust to std::string.
11562         (update_static_tracepoint): Adjust to std::string, remove call
11563         to release_static_tracepoint_marker.
11564         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
11565         Adjust to std::vector.
11566         * remote.c (remote_static_tracepoint_marker_at): Return bool.
11567         (remote_static_tracepoint_markers_by_strid): Adjust to
11568         std::vector.
11569         * common/rsp-low.h (hex2str): New overload with explicit count
11570         of bytes.
11571         * common/rsp-low.c (hex2str): New overload with explicit count
11572         of bytes.
11573         * unittests/rsp-low-selftests.c (test_hex2str): New function.
11574         (_initialize_rsp_low_selftests): Add test_hex2str test.
11575         * unittests/tracepoint-selftests.c
11576         (test_parse_static_tracepoint_marker_definition): Adjust to
11577         std::string.
11578
11579 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
11580
11581         * tracepoint.c (parse_static_tracepoint_marker_definition):
11582         Consider case where the definition is followed by more
11583         definitions.
11584         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11585         tracepoint-selftests.c.
11586         * unittests/tracepoint-selftests.c: New.
11587
11588 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
11589
11590         * MAINTAINERS (Write After Approval): Add Pedro Franco de
11591         Carvalho.
11592
11593 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
11594
11595         * symtab.c (find_pc_sect_line): fixed indentation.
11596
11597 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
11598
11599         * symtab.c (find_pc_sect_line): now uses binary search.
11600
11601 2018-03-19  Tom Tromey  <tom@tromey.com>
11602
11603         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
11604         "IDENT" production.
11605
11606 2018-03-19  Pedro Alves  <palves@redhat.com>
11607             Tom Tromey  <tom@tromey.com>
11608
11609         * unittests/observable-selftests.c: New file.
11610         * common/observable.h: New file.
11611         * observable.h: New file.
11612         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
11613         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
11614         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
11615         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
11616         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
11617         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
11618         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
11619         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
11620         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
11621         python/py-breakpoint.c, python/py-finishbreakpoint.c,
11622         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
11623         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
11624         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
11625         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
11626         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
11627         tui/tui-interp.c, valops.c: Update all users.
11628         * tui/tui-hooks.c (tui_bp_created_observer)
11629         (tui_bp_deleted_observer, tui_bp_modified_observer)
11630         (tui_inferior_exit_observer, tui_before_prompt_observer)
11631         (tui_normal_stop_observer, tui_register_changed_observer):
11632         Remove.
11633         (tui_observers_token): New global.
11634         (attach_or_detach, tui_attach_detach_observers): New functions.
11635         (tui_install_hooks, tui_remove_hooks): Use
11636         tui_attach_detach_observers.
11637         * record-btrace.c (record_btrace_thread_observer): Remove.
11638         (record_btrace_thread_observer_token): New global.
11639         * observer.sh: Remove.
11640         * observer.c: Rename to observable.c.
11641         * observable.c (namespace gdb_observers): Define new objects.
11642         (observer_debug): Move into gdb_observers namespace.
11643         (struct observer, struct observer_list, xalloc_observer_list_node)
11644         (xfree_observer_list_node, generic_observer_attach)
11645         (generic_observer_detach, generic_observer_notify): Remove.
11646         (_initialize_observer): Update.
11647         Don't include observer.inc.
11648         * Makefile.in (generated_files): Remove observer.h, observer.inc.
11649         (clean mostlyclean): Likewise.
11650         (observer.h, observer.inc): Remove targets.
11651         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
11652         (COMMON_SFILES): Use observable.c, not observer.c.
11653         * .gitignore: Remove observer.h.
11654
11655 2018-03-18  Tom Tromey  <tom@tromey.com>
11656
11657         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
11658         gdb::def_vector.
11659         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
11660
11661 2018-03-17  Tom Tromey  <tom@tromey.com>
11662
11663         * auto-load.c (auto_load_objfile_script_1): Use std::string.
11664
11665 2018-03-17  Tom Tromey  <tom@tromey.com>
11666
11667         * target.c (class scoped_target_fd): New.
11668         (target_fileio_close_cleanup): Remove.
11669         (target_fileio_read_alloc_1): Use scoped_target_fd.
11670
11671 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
11672
11673         * silent-rules.mk: New.
11674         * Makefile.in: Include silent-rules.mk
11675         (srcdir, VPATH, top_srcdir): Move up.
11676         (COMPILE): Add ECHO_CXX.
11677         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
11678         (init.c): Add ECHO_INIT_C.
11679         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
11680         (version.c): Add ECHO_GEN.
11681         (printcmd.o): Add ECHO_CXX.
11682         (target-float.o): Add ECHO_CXX.
11683         (ada-exp.o): Add ECHO_CXX.
11684         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
11685         (insight$(EXEEXT)): Add ECHO_CXXLD.
11686         * gnulib/configure.ac: Add AM_SILENT_RULES.
11687         * gnulib/aclocal.m4: Re-generate.
11688         * gnulib/configure: Re-generate.
11689         * gnulib/import/Makefile.in: Re-generate.
11690
11691 2018-03-16  Tom Tromey  <tom@tromey.com>
11692
11693         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
11694         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
11695         * utils.c (do_free_section_addr_info)
11696         (make_cleanup_free_section_addr_info): Remove.
11697         * symfile.h (struct other_sections): Add constructor.
11698         (struct section_addr_info): Remove.
11699         (section_addr_info): New typedef.
11700         (struct sym_fns) <sym_offsets>: Change type of parameter.
11701         (build_section_addr_info_from_objfile)
11702         (relative_addr_info_to_section_offsets, addr_info_make_relative)
11703         (default_symfile_offsets, symbol_file_add)
11704         (symbol_file_add_from_bfd)
11705         (build_section_addr_info_from_section_table): Update.
11706         (alloc_section_addr_info, free_section_addr_info): Don't declare.
11707         * symfile.c (alloc_section_addr_info): Remove.
11708         (build_section_addr_info_from_section_table): Change return type.
11709         Update.
11710         (build_section_addr_info_from_bfd)
11711         (build_section_addr_info_from_objfile): Likewise.
11712         (free_section_addr_info): Remove.
11713         (relative_addr_info_to_section_offsets): Change type of "addrs".
11714         (addrs_section_compar): Now a std::sort comparator.
11715         (addrs_section_sort): Change return type.
11716         (addr_info_make_relative): Change type of "addrs".  Update.
11717         (default_symfile_offsets, syms_from_objfile_1)
11718         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
11719         (symbol_file_add_separate): Update.
11720         (symbol_file_add): Change type of "addrs".  Update.
11721         (add_symbol_file_command): Update.  Remove cleanups.
11722         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
11723         cleanups.
11724         * symfile-debug.c (debug_sym_offsets): Change type of "info".
11725         * solib.c (solib_read_symbols): Update.
11726         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
11727         * machoread.c (macho_symfile_offsets): Update.
11728         * jit.c (jit_bfd_try_read_symtab): Update.
11729
11730 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
11731
11732         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11733         unittests/utils-selftests.c.
11734         * unittests/utils-selftests.c: New file.
11735
11736 2018-03-14  Tom Tromey  <tom@tromey.com>
11737
11738         PR cli/14977:
11739         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
11740         for NULL.
11741
11742 2018-03-14  Tom Tromey  <tom@tromey.com>
11743
11744         PR cli/19918:
11745         * printcmd.c (printf_pointer): Allow "-" in format.
11746
11747 2018-03-14  Tom Tromey  <tom@tromey.com>
11748
11749         * printcmd.c (_initialize_printcmd): Add usage to printf.
11750
11751 2018-03-14  Yao Qi  <qiyao@sourceware.org>
11752
11753         * MAINTAINERS: Update my email address.
11754
11755 2018-03-13  Tom Tromey  <tom@tromey.com>
11756
11757         * machoread.c (macho_check_dsym): Change filenamep to a
11758         std::string*.
11759         (macho_symfile_read): Update.
11760         * symfile.c (load_command): Use std::string.
11761
11762 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11763
11764         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
11765         to error message string.
11766         (riscv_register_name): Use xsnprintf instead of sprintf.
11767         (riscv_insn::fetch_instruction): Use gdb_assert instead of
11768         internal_error.
11769         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
11770         error.
11771         (riscv_push_dummy_call): Likewise.
11772
11773 2018-03-12  Tom Tromey  <tom@tromey.com>
11774
11775         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
11776         Use gdb::byte_vector.
11777         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
11778
11779 2018-03-12  Yao Qi  <yao.qi@linaro.org>
11780
11781         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
11782         parameter type to readable_regcache.
11783         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
11784         the declaration.
11785
11786 2018-03-11  Tom Tromey  <tom@tromey.com>
11787
11788         * dwarf2read.c (struct nextfield): Add initializers.
11789         (struct nextfnfield): Remove.
11790         (struct fnfieldlist): Add initializers.  Remove "length" and
11791         "head", use std::vector.
11792         (struct decl_field_list): Remove.
11793         (struct field_info): Add initializers.
11794         <fields, baseclasses>: Now std::vector.
11795         <nbaseclasses, nfnfields, typedef_field_list_count,
11796         nested_types_list_count>: Remove.
11797         (dwarf2_add_field, dwarf2_add_type_defn)
11798         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
11799         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
11800         (process_structure_scope): Update.
11801
11802 2018-03-11  Tom Tromey  <tom@tromey.com>
11803
11804         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
11805         for use by std::sort.
11806         (build_type_psymtabs_1): Use std::vector.
11807
11808 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
11809
11810         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
11811         and LIBMPFR in the printed configuration.
11812
11813 2018-03-08  Tom Tromey  <tom@tromey.com>
11814
11815         * source.c (get_filename_and_charpos): Use scoped_fd.
11816         * nto-procfs.c (procfs_open_1): Use scoped_fd.
11817         (procfs_pidlist): Likewise.
11818         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
11819         (iterate_over_mappings): Likewise.
11820
11821 2018-03-08  Tom Tromey  <tom@tromey.com>
11822
11823         * infcall.c (struct call_return_meta_info)
11824         <stack_temporaries_enabled>: Remove.
11825         (get_call_return_value, call_function_by_hand_dummy): Update.
11826         * thread.c (disable_thread_stack_temporaries): Remove.
11827         (enable_thread_stack_temporaries): Remove.
11828         (thread_stack_temporaries_enabled_p): Return bool.
11829         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
11830         (get_last_thread_stack_temporary): Update.
11831         * eval.c (evaluate_subexp): Update.
11832         * gdbthread.h (class enable_thread_stack_temporaries): Now a
11833         class, not a function.
11834         (value_ptr, value_vec): Remove typedefs.
11835         (class thread_info) <stack_temporaries_enabled>: Now bool.
11836         <stack_temporaries>: Now a std::vector.
11837         (thread_stack_temporaries_enabled_p)
11838         (value_in_thread_stack_temporaries): Return bool.
11839
11840 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
11841
11842         * remote.c (putpkt_binary): Fix omitted bytes reporting.
11843         (getpkt_or_notif_sane_1): Likewise.
11844
11845 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
11846
11847         * build-id.c (build_id_to_debug_bfd): Use std::string.
11848
11849 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
11850
11851         * build-id.c (find_separate_debug_file_by_buildid): Return
11852         std::string.
11853         * build-id.h (find_separate_debug_file_by_buildid): Return
11854         std::string.
11855         * coffread.c (coff_symfile_read): Adjust to std::string.
11856         * elfread.c (elf_symfile_read): Adjust to std::string.
11857         * symfile.c (separate_debug_file_exists): Change parameter to
11858         std::string.
11859         (find_separate_debug_file): Return std::string.
11860         (find_separate_debug_file_by_debuglink): Return std::string.
11861         * symfile.h (find_separate_debug_file_by_debuglink): Return
11862         std::string.
11863
11864 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
11865
11866         * common/xml-utils.c (xml_escape_text): Move code to...
11867         (xml_escape_text_append): ... this new function.
11868         * common/xml-utils.h (xml_escape_text_append): New declaration.
11869         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
11870         New function.
11871         (_initialize_xml_utils): register test_xml_escape_text_append as
11872         a selftest.
11873
11874 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
11875
11876         * defs.h: Remove MAX_REGISTER_SIZE.
11877         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
11878         asserts.
11879         * python/py-unwind.c (pyuw_sniffer): Likewise.
11880
11881 2018-03-07  Tom Tromey  <tom@tromey.com>
11882
11883         * linux-tdep.c (linux_info_proc): Update.
11884         * target.h (struct target_ops) <to_fileio_readlink>: Return
11885         optional<string>.
11886         (target_fileio_readlink): Return optional<string>.
11887         * remote.c (remote_hostio_readlink): Return optional<string>.
11888         * inf-child.c (inf_child_fileio_readlink): Return
11889         optional<string>.
11890         * target.c (target_fileio_readlink): Return optional<string>.
11891
11892 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11893
11894         * regcache.c (cooked_read_test): Add riscv to the list of
11895         architectures that have a save_reggroup.
11896
11897 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
11898
11899         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
11900         value is not a dynamic class object.
11901
11902 2018-03-06  Tom Tromey  <tom@tromey.com>
11903
11904         * rust-exp.y: Formatting fixes.
11905
11906 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11907
11908         * riscv-tdep.c (riscv_register_name): Remove target description
11909         support.
11910         (riscv_gdbarch_init): Remove target description check.
11911
11912 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11913
11914         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
11915         comment.
11916         * riscv-tdep.h: Likewise.
11917
11918 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11919
11920         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
11921         (riscv_pseudo_register_write): Delete.
11922         (riscv_gdbarch_init): Remove all use of pseudo registers.
11923
11924 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
11925
11926         * record-btrace.c (btrace_print_lines): Replace cleanup
11927         parameter with RAII equivalents.
11928         (btrace_insn_history): Replace cleanup with RAII equivalents.
11929         * ui-out.h (make_cleanup_ui_out_list_begin_end,
11930         make_cleanup_ui_out_tuple_begin_end): Remove.
11931         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
11932         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
11933         make_cleanup_ui_out_list_begin_end): Remove.
11934
11935 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
11936
11937         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
11938         parameter types to std::vector.  Use bool.
11939         (record_btrace_wait): Replace VEC(tp_t) with
11940         std::vector<thread_info *>.
11941         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
11942
11943 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
11944
11945         * record-btrace.c (record_btrace_disable_callback): Remove.
11946         (struct scoped_btrace_disable): New.
11947         (record_btrace_open): Use scoped_btrace_disable.
11948
11949 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11950
11951         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
11952         reading values from registers.
11953
11954 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11955
11956         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
11957         where appropriate.
11958
11959 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11960
11961         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
11962         change parameter type.  Use GDB's print functions, and use
11963         core_addr_to_string where appropriate.
11964         (riscv_push_dummy_call): Use core_addr_to_string where
11965         appropriate, update call to riscv_print_arg_location, and reindent
11966         a few lines.
11967         (riscv_return_value): Update call to riscv_print_arg_location.
11968
11969 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11970             Tim Newsome <tim@sifive.com>
11971             Albert Ou <a0u@eecs.berkeley.edu>
11972             Darius Rad <darius@bluespec.com>
11973
11974         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
11975         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
11976         (ALLDEPFILES): Add riscv-tdep.c
11977         * configure.tgt: Add riscv support.
11978         * riscv-tdep.c: New file.
11979         * riscv-tdep.h: New file.
11980         * NEWS: Mention new target.
11981         * MAINTAINERS: Add entry for riscv.
11982
11983 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11984
11985         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
11986         fields within aggregates.
11987
11988 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
11989
11990         * record-btrace.c (btrace_print_lines): Change type of flags to
11991         gdb_disassembly_flags.
11992
11993 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
11994
11995         * fbsd-nat.c: Include "inf-ptrace.h".
11996         (USE_SIGTRAP_SIGINFO): Conditionally define.
11997         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
11998         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
11999         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
12000         function.
12001         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
12002         Likewise.
12003         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
12004         Likewise.
12005         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
12006         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
12007         "supports_stopped_by_hw_breakpoint" target methods.
12008
12009 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
12010
12011         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
12012         * fbsd-nat.c (debug_fbsd_nat): New variable.
12013         (show_fbsd_nat_debug): New function.
12014         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
12015         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
12016
12017 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
12018
12019         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
12020         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
12021         prototype.
12022         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
12023         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
12024         method.
12025
12026 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
12027
12028         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
12029         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
12030
12031 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
12032
12033         * charset.c (struct charset_vector): New.
12034         (charsets): Change type to charset_vector.
12035         (find_charset_names): Adjust.
12036         (add_one): Adjust.
12037         (_initialize_charset): Adjust.
12038
12039 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
12040
12041         * progspace.h (struct program_space) <deleted_solibs>: Change
12042         type to std::vector<std::string>.
12043         * progspace.c (clear_program_space_solib_cache): Adjust.
12044         * breakpoint.c (print_solib_event): Adjust.
12045         (check_status_catch_solib): Adjust.
12046         * solib.c (update_solib_list): Adjust.
12047         * ui-out.h (class ui_out) <field_string>: New overload.
12048         * ui-out.c (ui_out::field_string): New overload.
12049
12050 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
12051
12052         * progspace.h (struct program_space): Add constructor and
12053         destructor, initialize fields.
12054         (add_program_space): Remove.
12055         * progspace.c (add_program_space): Rename to...
12056         (program_space::program_space): ... this.
12057         (release_program_space): Rename to...
12058         (program_space::~program_space): ... this.
12059         (delete_program_space): Use delete to delete program_space.
12060         (initialize_progspace): Use new to allocate program_space.
12061         * inferior.c (add_inferior_with_spaces): Likewise.
12062         (clone_inferior_command): Likewise.
12063         * infrun.c (follow_fork_inferior): Likewise.
12064         (handle_vfork_child_exec_or_exit): Likewise.
12065
12066 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
12067
12068         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
12069         (delim_string_to_char_ptr_vec): Return std::vector of
12070         gdb::unique_xmalloc_ptr.
12071         (dirnames_to_char_ptr_vec_append): Take std::vector of
12072         gdb::unique_xmalloc_ptr.
12073         (dirnames_to_char_ptr_vec): Return std::vector of
12074         gdb::unique_xmalloc_ptr.
12075         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
12076         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
12077         (delim_string_to_char_ptr_vec): Return an std::vector of
12078         gdb::unique_xmalloc_ptr, adjust the code.
12079         (dirnames_to_char_ptr_vec_append): Take an std::vector of
12080         gdb::unique_xmalloc_ptr, adjust the code.
12081         (dirnames_to_char_ptr_vec): Return an std::vector of
12082         gdb::unique_xmalloc_ptr, adjust the code.
12083         * auto-load.c (auto_load_safe_path_vec): Change type to
12084         std::vector of gdb::unique_xmalloc_ptr.
12085         (auto_load_expand_dir_vars): Return an std::vector of
12086         gdb::unique_xmalloc_ptr, adjust the code.
12087         (auto_load_safe_path_vec_update): Adjust.
12088         (filename_is_in_auto_load_safe_path_vec): Adjust.
12089         (auto_load_objfile_script_1): Adjust.
12090         * build-id.c (build_id_to_debug_bfd): Adjust.
12091         * linux-thread-db.c (thread_db_load_search): Adjust.
12092         * source.c (add_path): Adjust.
12093         (openp): Adjust.
12094         * symfile.c (find_separate_debug_file): Adjust.
12095         * utils.c (do_free_char_ptr_vec): Remove.
12096         (make_cleanup_free_char_ptr_vec): Remove.
12097
12098 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12099
12100         PR gdb/22907
12101         * common/pathstuff.c: Conditionally include "<windows.h>".
12102
12103 2018-03-01  Georg Sauthoff  <mail@georg.so>
12104
12105         PR gdb/22888
12106         * gcore.in: Quote variables and switch interpreter to bash.
12107
12108 2018-03-01  Tom Tromey  <tom@tromey.com>
12109
12110         * dwarf2read.c (alloc_discriminant_info): Fix default_index
12111         assertion.  Add assertion for discriminant_index.
12112         (quirk_rust_enum): Use correct base type name in univariant case.
12113
12114 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
12115
12116         * record.c (get_call_history_modifiers): Return a
12117         record_print_flags.
12118         (cmd_record_call_history): Adjust.
12119         * record-btrace.c (record_btrace_call_history): Adjust.
12120         (record_btrace_call_history_range): Adjust.
12121         (record_btrace_call_history_from): Adjust.
12122         * target-debug.h (target_debug_print_record_print_flags): New.
12123         * target-delegates.c: Re-generate.
12124         * target.c (target_call_history): Change flags type.
12125         (target_call_history_from): Likewise.
12126         (target_call_history_range): Likewise.
12127         * target.h (struct target_ops) <target_call_history>: Likewise.
12128         (target_call_history_from): Likewise.
12129         (target_call_history_range): Likewise.
12130
12131 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
12132             Simon Marchi  <simon.marchi@polymtl.ca>
12133
12134         * common/common-utils.c: Include "sys/stat.h".
12135         (is_regular_file): Move here from "source.c"; change return
12136         type to "bool".
12137         * common/common-utils.h (is_regular_file): New prototype.
12138         * common/pathstuff.c (contains_dir_separator): New function.
12139         * common/pathstuff.h (contains_dir_separator): New prototype.
12140         * source.c: Don't include "sys/stat.h".
12141         (is_regular_file): Move to "common/common-utils.c".
12142
12143 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
12144
12145         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
12146         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
12147         * auto-load.c: Include "common/pathstuff.h".
12148         * common/common-def.h (current_directory): Move here.
12149         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
12150         function.
12151         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
12152         prototype.
12153         * common/pathstuff.c: New file.
12154         * common/pathstuff.h: New file.
12155         * compile/compile.c: Include "common/pathstuff.h".
12156         * defs.h (current_directory): Move to "common/common-defs.h".
12157         * dwarf2read.c: Include "common/pathstuff.h".
12158         * exec.c: Likewise.
12159         * guile/scm-safe-call.c: Likewise.
12160         * linux-thread-db.c: Likewise.
12161         * main.c: Likewise.
12162         * nto-tdep.c: Likewise.
12163         * objfiles.c: Likewise.
12164         * source.c: Likewise.
12165         * symtab.c: Likewise.
12166         * utils.c: Include "common/pathstuff.h".
12167         (gdb_realpath): Move to "common/pathstuff.c".
12168         (gdb_realpath_keepfile): Likewise.
12169         (gdb_abspath): Likewise.
12170         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
12171         (gdb_realpath_keepfile): Likewise.
12172         (gdb_abspath): Likewise.
12173
12174 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
12175
12176         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
12177         wildcard process pid for super_resume for kernels with a
12178         specific bug.
12179
12180 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
12181
12182         * compile/compile.c (get_args): Add additional comments
12183         explaining function.
12184
12185 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
12186             Tom Tromey  <tom@tromey.com>
12187
12188         * target.h (memory_write_request_s): Remove typedef.  Don't define
12189         VEC.
12190         (target_write_memory_blocks): Change argument to std::vector.
12191         (struct memory_write_request): Add constructor.
12192         * target-memory.c (compare_block_starting_address): Return bool.
12193         Change argument types.
12194         (claim_memory): Change arguments to use std::vector.
12195         (split_regular_and_flash_blocks, blocks_to_erase)
12196         (compute_garbled_blocks): Likewise.
12197         (cleanup_request_data, cleanup_write_requests_vector): Remove.
12198         (target_write_memory_blocks): Change argument to std::vector.
12199         * symfile.c (struct load_section_data): Add constructor and
12200         destructor.  Use std::vector for "requests".
12201         (struct load_progress_data): Add initializers.
12202         (load_section_callback): Update.  Use "new".
12203         (clear_memory_write_data): Remove.
12204         (generic_load): Update.
12205
12206 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
12207
12208         * arch/aarch64.h: Use common/tdesc.h.
12209
12210 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
12211
12212         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
12213         architecture with a 64-bit ABI.
12214
12215 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
12216
12217         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
12218         ahead of target description loading.
12219
12220 2018-02-26  Tom Tromey  <tom@tromey.com>
12221
12222         * stack.c (backtrace_command_1): Update.
12223         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
12224         of "flags".
12225         * python/py-framefilter.c (py_print_frame)
12226         (gdbpy_apply_frame_filter): Change type of "flags".
12227         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
12228         of "flags".
12229         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
12230         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
12231         * extension.h (enum frame_filter_flag): Rename from
12232         frame_filter_flags.
12233         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
12234         (apply_ext_lang_frame_filter): Change type of "flags".
12235         * extension.c (apply_ext_lang_frame_filter): Change type of
12236         "flags".
12237         * extension-priv.h (struct extension_language_ops)
12238         <apply_frame_filter>: Change type of "flags".
12239
12240 2018-02-26  Tom Tromey  <tom@tromey.com>
12241
12242         PR python/16497:
12243         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
12244         off-by-one in py_end computation.
12245         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
12246         PRINT_MORE_FRAMES.
12247         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
12248         constant.
12249
12250 2018-02-26  Tom Tromey  <tom@tromey.com>
12251
12252         * dwarf2read.c (struct variant_field): New.
12253         (struct nextfield) <variant>: New field.
12254         (dwarf2_add_field): Handle DW_TAG_variant_part.
12255         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
12256         discriminated union.
12257         (read_structure_type): Handle DW_TAG_variant_part.
12258         (handle_struct_member_die): New function, extracted from
12259         process_structure_scope.  Handle DW_TAG_variant.
12260         (process_structure_scope): Handle discriminated unions.  Call
12261         handle_struct_member_die.
12262
12263 2018-02-26  Tom Tromey  <tom@tromey.com>
12264
12265         * rust-lang.h (rust_last_path_segment): Declare.
12266         * rust-lang.c (rust_last_path_segment): Now public.  Change
12267         contract.
12268         (struct disr_info): Remove.
12269         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
12270         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
12271         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
12272         (rust_enum_p, rust_enum_variant): New function.
12273         (rust_underscore_fields): Remove "offset" parameter.
12274         (rust_print_enum): New function.
12275         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
12276         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
12277         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
12278         enums.
12279         (rust_internal_print_type): New function, from rust_print_type.
12280         Remove enum code.
12281         (rust_print_type): Call rust_internal_print_type.
12282         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
12283         Update enum handling.
12284         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
12285         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
12286         (rust_union_quirks): New functions.
12287         (process_full_comp_unit, process_full_type_unit): Call
12288         rust_union_quirks.
12289         (process_structure_scope): Update rust_unions if necessary.
12290
12291 2018-02-26  Tom Tromey  <tom@tromey.com>
12292
12293         * value.h (value_union_variant): Declare.
12294         * valops.c (value_union_variant): New function.
12295         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
12296         (struct discriminant_info): New.
12297         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
12298         enumerator.
12299         (struct main_type) <flag_discriminated_union>: New field.
12300
12301 2018-02-26  Tom Tromey  <tom@tromey.com>
12302
12303         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12304         unittests/unpack-selftests.c.
12305         * unittests/unpack-selftests.c: New file.
12306         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
12307
12308 2018-02-26  Yao Qi  <yao.qi@linaro.org>
12309
12310         * dwarf2read.c (struct partial_die_info) <read>: New method.
12311         (read_partial_die): Remove the declaration.
12312         (load_partial_dies): Update.
12313         (partial_die_info::partial_die_info):
12314         (read_partial_die): Change it to partial_die_info::read.
12315
12316 2018-02-26  Yao Qi  <yao.qi@linaro.org>
12317
12318         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
12319         (fixup_partial_die): Remove declaration.
12320         (scan_partial_symbols): Update.
12321         (partial_die_parent_scope): Likewise.
12322         (partial_die_full_name): Likewise.
12323         (fixup_partial_die): Change it to partial_die_info::fixup.
12324
12325 2018-02-26  Yao Qi  <yao.qi@linaro.org>
12326
12327         * dwarf2read.c (read_partial_die): Update the declaration.
12328         (load_partial_dies): Caller update.
12329         (read_partial_die): Remove one argument abbrev_len.
12330
12331 2018-02-26  Yao Qi  <yao.qi@linaro.org>
12332
12333         * dwarf2read.c (struct partial_die_info): Add ctor, delete
12334         assignment operator.
12335         (load_partial_dies): Use ctor and copy ctor.
12336         (read_partial_die): Update.
12337         (dwarf2_cu::find_partial_die): Use ctor.
12338
12339 2018-02-26  Yao Qi  <yao.qi@linaro.org>
12340
12341         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
12342         (find_partial_die_in_comp_unit): Change it to
12343         dwarf2_cu::find_partial_die.
12344         (find_partial_die): Update.
12345
12346 2018-02-26  Yao Qi  <yao.qi@linaro.org>
12347
12348         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
12349         is NULL.
12350
12351 2018-02-26  Yao Qi  <yao.qi@linaro.org>
12352
12353         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
12354
12355 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
12356
12357         * arch/amd64.h: Use common/tdesc.h.
12358         * arch/i386.c: Likewise.
12359         * arch/i386.h: Likewise.
12360         * arch/tic6x.c: Likewise.
12361         * arch/tdesc.h: Move file from here...
12362         * common/tdesc.h: ...to here.
12363         * features/aarch64-core.c: Regenerate.
12364         * features/aarch64-fpu.c: Regenerate.
12365         * features/i386/32bit-avx.c: Regenerate.
12366         * features/i386/32bit-avx512.c: Regenerate.
12367         * features/i386/32bit-core.c: Regenerate.
12368         * features/i386/32bit-linux.c: Regenerate.
12369         * features/i386/32bit-mpx.c: Regenerate.
12370         * features/i386/32bit-pkeys.c: Regenerate.
12371         * features/i386/32bit-sse.c: Regenerate.
12372         * features/i386/64bit-avx.c: Regenerate.
12373         * features/i386/64bit-avx512.c: Regenerate.
12374         * features/i386/64bit-core.c: Regenerate.
12375         * features/i386/64bit-linux.c: Regenerate.
12376         * features/i386/64bit-mpx.c: Regenerate.
12377         * features/i386/64bit-pkeys.c: Regenerate.
12378         * features/i386/64bit-segments.c: Regenerate.
12379         * features/i386/64bit-sse.c: Regenerate.
12380         * features/i386/x32-core.c: Regenerate.
12381         * features/tic6x-c6xp.c: Regenerate.
12382         * features/tic6x-core.c: Regenerate.
12383         * features/tic6x-gp.c: Regenerate.
12384         * target-descriptions.c: Use common/tdesc.h.
12385         * target-descriptions.h: Likewise.
12386
12387 2018-02-24  Tom Tromey  <tom@tromey.com>
12388
12389         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
12390         (try_thread_db_load_from_dir, thread_db_load_search): Use
12391         std::string.
12392         (info_auto_load_libthread_db_compare): Return bool.  Change
12393         argument types.
12394         (info_auto_load_libthread_db): Use std::vector, std::string.
12395         Remove cleanups.
12396
12397 2018-02-24  Tom Tromey  <tom@tromey.com>
12398
12399         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
12400         std::string.
12401         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
12402         std::string*.
12403         * gdbarch.c: Rebuild.
12404         * gdbarch.h: Rebuild.
12405         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
12406         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
12407         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
12408         std::string*.
12409
12410 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
12411
12412         * gdbtypes.h (sect_offset): Change type to uint64_t.
12413         (sect_offset_str): New function.
12414         * dwarf2read.c (create_addrmap_from_aranges): Use
12415         sect_offset_str.
12416         (error_check_comp_unit_head): Likewise.
12417         (create_debug_type_hash_table): Likewise.
12418         (read_cutu_die_from_dwo): Likewise.
12419         (init_cutu_and_read_dies): Likewise.
12420         (init_cutu_and_read_dies_no_follow): Likewise.
12421         (process_psymtab_comp_unit_reader): Likewise.
12422         (partial_die_parent_scope): Likewise.
12423         (peek_die_abbrev): Likewise.
12424         (process_queue): Likewise.
12425         (dwarf2_physname): Likewise.
12426         (read_namespace_alias): Likewise.
12427         (read_import_statement): Likewise.
12428         (create_dwo_cu_reader): Likewise.
12429         (create_cus_hash_table): Likewise.
12430         (lookup_dwo_cutu): Likewise.
12431         (inherit_abstract_dies): Likewise.
12432         (read_func_scope): Likewise.
12433         (read_call_site_scope): Likewise.
12434         (dwarf2_add_member_fn): Likewise.
12435         (read_common_block): Likewise.
12436         (read_module_type): Likewise.
12437         (read_typedef): Likewise.
12438         (read_subrange_type): Likewise.
12439         (load_partial_dies): Likewise.
12440         (read_partial_die): Likewise.
12441         (find_partial_die): Likewise.
12442         (read_str_index): Likewise.
12443         (dwarf2_string_attr): Likewise.
12444         (build_error_marker_type): Likewise.
12445         (lookup_die_type): Likewise.
12446         (dump_die_shallow): Likewise.
12447         (follow_die_ref): Likewise.
12448         (dwarf2_fetch_die_loc_sect_off): Likewise.
12449         (dwarf2_fetch_constant_bytes): Likewise.
12450         (follow_die_sig): Likewise.
12451         (get_signatured_type): Likewise.
12452         (get_DW_AT_signature_type): Likewise.
12453         (dwarf2_find_containing_comp_unit): Likewise.
12454         (set_die_type): Likewise.
12455
12456 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
12457
12458         * arch/aarch64.c: Include "common-defs.h".
12459         * arch/amd64.c: Likewise.
12460         * arch/i386.c: Likewise.
12461
12462 2018-02-21  Tom Tromey  <tom@tromey.com>
12463
12464         * value.h: (extract_field_op): Update.
12465         * eval.c (extract_field_op): Return a const char *.
12466         * expression.h (parse_expression_for_completion): Update.
12467         * completer.c (complete_expression): Update.
12468         (add_struct_fields): Make fieldname const.
12469         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
12470         (mark_completion_tag, parse_exp_in_context_1): Update.
12471         (parse_expression_for_completion): Change "name" to
12472         unique_xmalloc_ptr*.
12473
12474 2018-02-21  Tom Tromey  <tom@tromey.com>
12475
12476         * infcall.c (call_function_by_hand_dummy): Use std::vector.
12477
12478 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12479
12480         * avr-tdep.c (avr_read_pc): Change parameter type to
12481         readable_regcache.
12482         * gdbarch.sh (read_pc): Likewise.
12483         * gdbarch.c: Re-generated.
12484         * gdbarch.h: Re-generated.
12485         * hppa-tdep.c (hppa_read_pc): Change parameter type to
12486         readable_regcache.
12487         * ia64-tdep.c (ia64_read_pc): Likewise.
12488         * mips-tdep.c (mips_read_pc): Likewise.
12489         * spu-tdep.c (spu_read_pc): Likewise.
12490
12491 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12492
12493         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
12494         * regcache-dump.c: New file.
12495         * regcache.c: Move register_dump to regcache-dump.c.
12496         (maintenance_print_registers): Likewise.
12497         (maintenance_print_raw_registers): Likewise.
12498         (maintenance_print_cooked_registers): Likewise.
12499         (maintenance_print_register_groups): Likewise.
12500         (maintenance_print_remote_registers): Likewise.
12501         (_initialize_regcache): Likewise.
12502         * regcache.h (register_dump): Moved from regcache.c.
12503
12504 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12505
12506         * regcache.c (regcache::regcache): Update.
12507         (regcache::invalidate): Move it to detached_regcache::invalidate.
12508         (get_thread_arch_aspace_regcache): Update.
12509         (regcache::raw_update): Update.
12510         (regcache::cooked_read): Remove some code.
12511         (regcache::cooked_read_value): Likewise.
12512         (regcache::raw_write): Remove assert on m_readonly_p.
12513         (regcache::raw_supply_integer): Move it to
12514         detached_regcache::raw_supply_integer.
12515         (regcache::raw_supply_zeroed): Likewise.
12516         * regcache.h (detached_regcache) <raw_supply_integer>: New
12517         declaration.
12518         <raw_supply_zeroed, invalidate>: Likewise.
12519         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
12520         <invalidate>: Likewise.
12521         <m_readonly_p>: Removed.
12522
12523 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12524
12525         * infcmd.c (get_return_value): Let stop_regs point to
12526         get_current_regcache.
12527         * regcache.c (regcache::regcache): Remove.
12528         (register_dump_reg_buffer): New class.
12529         (regcache_print): Adjust.
12530         * regcache.h (regcache): Remove constructors.
12531
12532 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12533
12534         * regcache.c (class register_dump): New class.
12535         (register_dump_regcache, register_dump_none): New class.
12536         (register_dump_remote, register_dump_groups): New class.
12537         (regcache_print): Update.
12538         * regcache.h (regcache_dump_what): Move it to regcache.c.
12539         (regcache) <dump>: Remove.
12540
12541 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12542
12543         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
12544          reg_buffer_rw *.
12545         (jit_unwind_reg_set_impl): Call raw_supply.
12546         (jit_frame_sniffer): Use reg_buffer_rw.
12547         * record-full.c (record_full_core_regbuf): Change its type.
12548         (record_full_core_open_1): Use reg_buffer_rw.
12549         (record_full_close): Likewise.
12550         (record_full_core_fetch_registers): Use regcache->raw_supply.
12551         (record_full_core_store_registers): Likewise.
12552         * regcache.c (regcache::get_register_status): Move it to
12553         reg_buffer.
12554         (regcache_raw_set_cached_value): Remove.
12555         (regcache::raw_set_cached_value): Remove.
12556         (regcache::raw_write): Call raw_supply.
12557         (regcache::raw_supply): Move it to reg_buffer_rw.
12558         * regcache.h (regcache_raw_set_cached_value): Remove.
12559         (reg_buffer_rw): New class.
12560
12561 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12562
12563         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
12564         readonly_detached_regcache.
12565         (dummy_frame_prev_register): Use regcache->cooked_read.
12566         * frame.c (frame_save_as_regcache): Change return type.
12567         (frame_pop): Update.
12568         * frame.h (frame_save_as_regcache): Update declaration.
12569         * inferior.h (get_infcall_suspend_state_regcache): Update
12570         declaration.
12571         * infrun.c (infcall_suspend_state) <registers>: use
12572         readonly_detached_regcache.
12573         (save_infcall_suspend_state): Don't use regcache_dup.
12574         (get_infcall_suspend_state_regcache): Change return type.
12575         * linux-fork.c (struct fork_info) <savedregs>: Change to
12576         readonly_detached_regcache.
12577         <pc>: New field.
12578         (fork_save_infrun_state): Don't use regcache_dup.
12579         (info_checkpoints_command): Adjust.
12580         * mi/mi-main.c (register_changed_p): Update declaration.
12581         (mi_cmd_data_list_changed_registers): Use
12582         readonly_detached_regcache.
12583         (register_changed_p): Change parameter type to
12584         readonly_detached_regcache.
12585         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
12586         readonly_detached_regcache.
12587         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
12588         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
12589         New.
12590         (regcache::save): Move it to reg_buffer.
12591         (regcache::restore): Change parameter type.
12592         (regcache_dup): Remove.
12593         * regcache.h (reg_buffer) <save>: New method.
12594         (readonly_detached_regcache): New class.
12595         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
12596         readonly_detached_regcache.
12597         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
12598
12599 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12600
12601         * frame.c (frame_save_as_regcache): Use regcache method save.
12602         (frame_pop): Use regcache method restore.
12603         * infrun.c (restore_infcall_suspend_state): Likewise.
12604         * linux-fork.c (fork_load_infrun_state): Likewise.
12605         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
12606         save.
12607         * regcache.c (regcache_save): Remove.
12608         (regcache::restore): More asserts.
12609         (regcache_cpy): Remove.
12610         * regcache.h (regcache_save): Remove the declaration.
12611         (regcache::restore): Move from private to public.
12612         Remove the friend declaration of regcache_cpy.
12613         (regcache_cpy): Remove declaration.
12614
12615 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12616
12617         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
12618         parameter type to 'readable_regcache *'.
12619         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
12620         * arm-tdep.c (arm_neon_quad_read): Likewise.
12621         (arm_pseudo_read): Likewise.
12622         * avr-tdep.c (avr_pseudo_register_read): Likewise.
12623         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
12624         * frv-tdep.c (frv_pseudo_register_read): Likewise.
12625         * gdbarch.c: Re-generated.
12626         * gdbarch.h: Re-generated.
12627         * gdbarch.sh (pseudo_register_read): Change parameter type to
12628         'readable_regcache *'.
12629         (pseudo_register_read_value): Likewise.
12630         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
12631         (h8300_pseudo_register_read): Likewise.
12632         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
12633         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
12634         (i386_pseudo_register_read_into_value): Likewise.
12635         (i386_pseudo_register_read_value): Likewise.
12636         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
12637         declaration.
12638         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
12639         * m32c-tdep.c (m32c_raw_read): Likewise.
12640         (m32c_read_flg): Likewise.
12641         (m32c_banked_register): Likewise.
12642         (m32c_banked_read): Likewise.
12643         (m32c_sb_read): Likewise.
12644         (m32c_part_read): Likewise.
12645         (m32c_cat_read): Likewise.
12646         (m32c_r3r2r1r0_read): Likewise.
12647         (m32c_pseudo_register_read): Likewise.
12648         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
12649         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
12650         (mep_pseudo_cr64_read): Likewise.
12651         (mep_pseudo_register_read): Likewise.
12652         * mips-tdep.c (mips_pseudo_register_read): Likewise.
12653         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
12654         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
12655         * regcache.c (regcache::raw_read): Move it to readable_regcache.
12656         (regcache::cooked_read): Likewise.
12657         (regcache::cooked_read_value): Likewise.
12658         (regcache_cooked_read_signed):
12659         (regcache::cooked_read): Likewise.
12660         * regcache.h (readable_regcache): New class.
12661         (regcache): Inherit readable_regcache.  Move some methods to
12662         readable_regcache.
12663         * rl78-tdep.c (rl78_pseudo_register_read): Change
12664         parameter type to 'readable_regcache *'.
12665         * rs6000-tdep.c (do_regcache_raw_read): Remove.
12666         (e500_pseudo_register_read): Change parameter type to
12667         'readable_regcache *'.
12668         (dfp_pseudo_register_read): Likewise.
12669         (vsx_pseudo_register_read): Likewise.
12670         (efpr_pseudo_register_read): Likewise.
12671         * s390-tdep.c (s390_pseudo_register_read): Likewise.
12672         * sh-tdep.c (sh_pseudo_register_read): Likewise.
12673         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
12674         (sh64_pseudo_register_read): Likewise.
12675         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
12676         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
12677         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
12678         (spu_pseudo_register_read): Likewise.
12679         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
12680         (xtensa_pseudo_register_read): Likewise.
12681
12682 2018-02-21  Yao Qi  <yao.qi@linaro.org>
12683
12684         * regcache.c (regcache::regcache): Call reg_buffer ctor.
12685         (regcache::arch): Move it to reg_buffer::arch.
12686         (regcache::register_buffer): Likewise.
12687         (regcache::assert_regnum): Likewise.
12688         (regcache::num_raw_registers): Likewise.
12689         * regcache.h (reg_buffer): New class.
12690         (regcache): Inherit reg_buffer.
12691
12692 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
12693
12694         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
12695         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
12696
12697 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
12698
12699         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
12700
12701 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
12702
12703         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
12704         (SFILES): Remove common/*.c files.
12705         (COMMON_OBS): Remove some *.o files built from common/*.c files.
12706         * common/common.host: Add common reference.
12707         * configure.ac: Likewise.
12708         * configure: Regenerate.
12709
12710 2018-02-16  Yao Qi  <yao.qi@linaro.org>
12711
12712         * block.c (block_namespace_info): Inherit allocate_on_obstack.
12713         (block_initialize_namespace): Use new.
12714         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
12715         (dwarf2_free_objfile): Use delete.
12716         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
12717         (copy_type_recursive): Use new.
12718         * gdb_obstack.h (allocate_on_obstack): New.
12719
12720 2018-02-15  Yao Qi  <yao.qi@linaro.org>
12721
12722         PR gdb/22849
12723         * inferior.c (exit_inferior_1): Reset inf->control.
12724
12725 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
12726
12727         * ada-lang.c (ada_to_fixed_value_create): Delete advance
12728         declaration.
12729
12730 2018-02-14  Pedro Alves  <palves@redhat.com>
12731
12732         * frame-unwind.c (frame_unwind_try_unwinder): Always call
12733         frame_cleanup_after_sniffer on exception.
12734
12735 2018-02-14  Tom Tromey  <tom@tromey.com>
12736
12737         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
12738         const.
12739         (solib_bfd_open): Make pathname const.
12740         * solib.c (solib_bfd_open): Make pathname const.
12741         * solib-spu.c (spu_bfd_fopen): Make name const.
12742         (spu_bfd_open): Make pathname const.
12743         * solib-darwin.c (darwin_bfd_open): Make pathname const.
12744         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
12745
12746 2018-02-14  Tom Tromey  <tom@tromey.com>
12747
12748         * symfile.c (symfile_bfd_open): Update.
12749         * source.h (openp, source_full_path_of, find_and_open_source):
12750         Change argument type to unique_xmalloc_ptr.
12751         * source.c (openp): Take a unique_xmalloc_ptr.
12752         (source_full_path_of, find_and_open_source): Likewise.
12753         (open_source_file, symtab_to_fullname): Update.
12754         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
12755         unique_xmalloc_ptr.
12756         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
12757         (exec_file_find): Update.
12758         * psymtab.c (psymtab_to_fullname): Update.
12759         * nto-tdep.h (nto_find_and_open_solib): Update.
12760         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
12761         unique_xmalloc_ptr.
12762         * exec.c (exec_file_attach): Update.
12763         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
12764         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
12765
12766 2018-02-14  Tom Tromey  <tom@tromey.com>
12767
12768         * solib.c: Include source.h.
12769         * nto-tdep.c: Include source.h.
12770         * mi/mi-cmd-env.c: Include source.h.
12771         * infcmd.c: Include source.h.
12772         * exec.c: Include source.h.
12773         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
12774         (add_path, directory_switch, source_path, init_source_path): Move
12775         declarations...
12776         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
12777         (add_path, directory_switch, source_path, init_source_path):
12778         ...here.
12779
12780 2018-02-14  Tom Tromey  <tom@tromey.com>
12781
12782         * solist.h (exec_file_find, solib_find): Return
12783         unique_xmalloc_ptr.
12784         (solib_bfd_fopen): Take a const char *.
12785         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
12786         (exec_file_find, solib_find): Likewise.
12787         (solib_bfd_fopen): Do not take ownership of "pathname".
12788         (solib_bfd_open): Use unique_xmalloc_ptr.
12789         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
12790         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
12791         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
12792         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
12793
12794 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
12795
12796         * ada-lang.c (name_match_type_from_name): Remove reference to
12797         ada_name_for_lookup in function's documentation.
12798         * ada-lang.h (ada_name_for_lookup): Delete declaration.
12799
12800 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
12801
12802         * defs.h (enum openp_flags): New enum.
12803         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
12804         Move to enum openp_flags.
12805         (openp_flags): New enum flags.
12806         (openp): Change parameter type to openp_flags.
12807         * source.c (openp): Change parameter type to openp_flags.
12808         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
12809         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
12810
12811 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
12812
12813         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
12814         per-command.
12815
12816 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
12817
12818         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
12819         into...
12820         (class dwarf2_queue_guard): ...the destructor of this new class.
12821         (dw2_do_instantiate_symtab): Create instance of the new class
12822         dwarf2_queue_guard, remove cleanup.
12823
12824 2018-02-09  Tom Tromey  <tom@tromey.com>
12825
12826         * source.c (find_source_lines): Don't reference past the end of
12827         the vector.
12828
12829 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
12830
12831         * remote.c (remote_btrace_maybe_reopen): Change error message.
12832         * btrace.c (btrace_enable): Likewise.
12833         (parse_xml_btrace): Likewise.
12834         (parse_xml_btrace_conf): Likewise.
12835
12836 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
12837
12838         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
12839         (linux_enable_pt, linux_enable_bts): Call
12840         diagnose_perf_event_open_fail.
12841
12842 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
12843
12844         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
12845         Remove parameter and change return type.  Update callers.  Move it.
12846         (linux_enable_bts, linux_enable_pt): Improve error message.
12847         (linux_enable_pt): Remove zero buffer size check.
12848         (linux_enable_btrace): Improve error messages.  Remove NULL return
12849         check.
12850
12851 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
12852
12853         * btrace.c (btrace_enable): Remove target_supports_btrace call.
12854         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
12855         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
12856         (linux_supports_pt, linux_supports_btrace): Remove.
12857         (linux_enable_bts): Call cpu_supports_bts.
12858         * nat/linux-btrace.h (linux_supports_btrace): Remove.
12859         * remote.c (remote_supports_btrace): Remove.
12860         (init_remote_ops): Remove remote_supports_btrace.
12861         * target-delegates.c: Regenerated.
12862         * target.c (target_supports_btrace): Remove.
12863         * target.h (target_ops) <to_supports_btrace>: Remove
12864         (target_supports_btrace): Remove.
12865         * x86-linux-nat.c (x86_linux_create_target): Remove
12866         linux_supports_btrace.
12867
12868 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
12869
12870         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
12871         btrace failed.
12872         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
12873         exception and use message in own exception.
12874
12875 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
12876
12877         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
12878         (perf_event_pt_event_type): Use gdb_file_up.
12879         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
12880         scoped_fd, and scoped_mmap.
12881
12882 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
12883
12884         * common/scoped_mmap.h: New.
12885         * unittests/scoped_mmap-selftest.c: New.
12886         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12887         unittests/scoped_mmap-selftest.c.
12888
12889 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
12890
12891         * common/scoped_fd.h: New.
12892         * unittests/scoped_fd-selftest.c: New.
12893         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12894         unittests/scoped_fd-selftest.c.
12895
12896 2018-02-09  Tom Tromey  <tom@tromey.com>
12897
12898         * auto-load.c (auto_load_section_scripts): Use
12899         gdb::unique_xmalloc_ptr.
12900
12901 2018-02-09  Tom Tromey  <tom@tromey.com>
12902
12903         * auto-load.c (execute_script_contents): Use std::string.
12904
12905 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
12906
12907         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
12908         Python function, rather than a new command.
12909
12910 2018-02-08  Tom Tromey  <tom@tromey.com>
12911
12912         * solib.c (solib_find_1): Use std::string.
12913         (solib_bfd_fopen): Use unique_xmalloc_ptr.
12914
12915 2018-02-08  Tom Tromey  <tom@tromey.com>
12916
12917         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
12918
12919 2018-02-08  Tom Tromey  <tom@tromey.com>
12920
12921         * source.c (find_source_lines): Use gdb::def_vector.
12922
12923 2018-02-08  Tom Tromey  <tom@tromey.com>
12924
12925         * macrocmd.c (struct temporary_macro_definition): New.
12926         (macro_define_command): Use temporary_macro_definition.  Remove
12927         cleanups.
12928         (free_macro_definition_ptr): Remove.
12929
12930 2018-02-08  Tom Tromey  <tom@tromey.com>
12931
12932         * macroexp.c (maybe_expand): Use std::string.
12933
12934 2018-02-08  Tom Tromey  <tom@tromey.com>
12935
12936         * macroexp.c (struct macro_buffer): Add initializers for some
12937         members.
12938         (init_buffer, init_shared_buffer, free_buffer)
12939         (free_buffer_return_text): Remove.
12940         (macro_buffer): New constructors.
12941         (~macro_buffer): New destructor.
12942         (macro_buffer::set_shared): New method.
12943         (macro_buffer::resize_buffer, macro_buffer::appendc)
12944         (macro_buffer::appendmem): Now methods, not free functions.
12945         (set_token, append_tokens_without_splicing, stringify)
12946         (macro_stringify): Update.
12947         (gather_arguments): Change return type.  Remove argc_p argument,
12948         add args_ptr argument.  Use std::vector.
12949         (substitute_args): Remove argc argument.  Accept std::vector.
12950         (expand): Update.  Use std::vector.
12951         (scan, macro_expand, macro_expand_next): Update.
12952
12953 2018-02-08  Tom Tromey  <tom@tromey.com>
12954
12955         * symtab.c (default_collect_symbol_completion_matches_break_on):
12956         Use unique_xmalloc_ptr.
12957         * macroscope.h: (sal_macro_scope, user_macro_scope)
12958         (default_macro_scope): Return unique_xmalloc_ptr.
12959         * macroscope.c (sal_macro_scope, user_macro_scope)
12960         (default_macro_scope): Return unique_xmalloc_ptr.
12961         * macroexp.h (macro_expand, macro_expand_once): Return
12962         unique_xmalloc_ptr.
12963         * macroexp.c (macro_expand, macro_expand_once): Return
12964         unique_xmalloc_ptr.
12965         * macrocmd.c (macro_expand_command, macro_expand_once_command)
12966         (info_macro_command, info_macros_command): Use
12967         unique_xmalloc_ptr.
12968         * compile/compile-c-support.c (write_macro_definitions): Use
12969         unique_xmalloc_ptr.
12970         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
12971
12972 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
12973
12974         * value.c (value_static_field): Assign field type instead of
12975         containing type when returning an optimized out value.
12976
12977 2018-02-06  Yao Qi  <yao.qi@linaro.org>
12978
12979         * ft32-tdep.c (ft32_read_pc): Remove.
12980         (ft32_write_pc): Remove.
12981         (ft32_gdbarch_init): Update.
12982         * m32r-tdep.c (m32r_read_pc): Remove.
12983         (m32r_gdbarch_init): Update.
12984         * mep-tdep.c (mep_read_pc): Remove.
12985         (mep_gdbarch_init): Update.
12986         * microblaze-tdep.c (microblaze_write_pc): Remove.
12987         (microblaze_gdbarch_init): Update.
12988         * mn10300-tdep.c (mn10300_read_pc): Remove.
12989         (mn10300_write_pc): Remove.
12990         (mn10300_gdbarch_init): Update.
12991         * moxie-tdep.c (moxie_read_pc): Remove.
12992         (moxie_write_pc): Remove.
12993         (moxie_gdbarch_init): Update.
12994
12995 2018-02-06  Yao Qi  <yao.qi@linaro.org>
12996
12997         * expprint.c (print_subexp_standard): Handle
12998         OP_F77_UNDETERMINED_ARGLIST.
12999         (dump_subexp_body_standard): Likewise.
13000
13001 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
13002
13003         * target-descriptions.c (tdesc_element_visitor) Add empty
13004         implementations.
13005         (tdesc_type): Move make_gdb_type from here.
13006         (tdesc_type_builtin): Likewise.
13007         (tdesc_type_vector): Likewise.
13008         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
13009         (make_gdb_type_struct): Move from tdesc_type_with_fields.
13010         (make_gdb_type_union): Likewise.
13011         (make_gdb_type_flags): Likewise.
13012         (make_gdb_type_enum): Likewise.
13013         (make_gdb_type): New function.
13014         (tdesc_register_type): Use static make_gdb_type.
13015
13016 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
13017
13018         * infcmd.c (default_print_one_register_info): Align natural-format
13019         column values consistently one under another.
13020         (pad_to_column): New function.
13021
13022 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
13023
13024         * dwarf2read.c (dwarf2_physname): Move commment.
13025
13026 2018-02-01  Leszek Swirski  <leszeks@google.com>
13027
13028         * varobj.c (varobj_formatted_print_options): Allow recursive
13029         pretty printing if pretty printing is enabled.
13030
13031 2018-02-01  Leszek Swirski  <leszeks@google.com>
13032
13033         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
13034         names after a structop as a filename.
13035
13036 2018-02-01  Yao Qi  <yao.qi@linaro.org>
13037
13038         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
13039         (arm_record_coproc_data_proc): Likewise.
13040
13041 2018-02-01  Yao Qi  <yao.qi@linaro.org>
13042
13043         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
13044
13045 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
13046
13047         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
13048         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
13049
13050 2018-01-31  Pedro Alves  <palves@redhat.com>
13051
13052         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
13053         * inflow.c (child_terminal_save_inferior): Wrap reference to
13054         tcgetpgrp in HAVE_TERMIOS_H.
13055         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
13056         _WIN32.
13057         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
13058         always iterate over all inferiors.
13059         (gdbsim_cntrl_c): Adjust.
13060         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
13061
13062 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
13063
13064         * gdbtypes.c (lookup_array_range_type): Make sure the array's
13065         index type is objfile-owned if the element type is as well.
13066
13067 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
13068
13069         GDB 8.1 released.
13070
13071 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13072
13073         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
13074         "features/s390x-linux64.c".
13075         (_initialize_s390_linux_tdep): Remove initialization of tdescs
13076         s390_linux32 and s390x_linux64.
13077         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
13078         default tdesc.
13079         * s390-tdep.c: Include "features/s390-linux32.c" and
13080         "features/s390x-linux64.c".
13081         (s390_tdesc_valid): Add check for tdesc_has_registers.
13082         (s390_gdbarch_init): Make sure there is always a valid tdesc.
13083         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
13084         tdesc_s390x_linux64.
13085         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
13086         tdesc_s390x_linux64 to...
13087         * s390-tdep.h: ...here.
13088
13089 2018-01-30  Pedro Alves  <palves@redhat.com>
13090
13091         PR gdb/13211
13092         * config.in, configure: Regenerate.
13093         * configure.ac: Check for getpgid.
13094         * go32-nat.c (go32_pass_ctrlc): New.
13095         (go32_target): Install it.
13096         * inf-child.c (inf_child_target): Install
13097         child_terminal_save_inferior, child_pass_ctrlc and
13098         child_interrupt.
13099         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
13100         (inf_ptrace_target): No longer install it.
13101         * infcmd.c (interrupt_target_1): Adjust.
13102         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
13103         (child_interrupt): Declare.
13104         (inferior::terminal_state): New.
13105         * inflow.c (struct terminal_info): Update comments.
13106         (inferior_process_group): Delete.
13107         (terminal_is_ours): Delete.
13108         (gdb_tty_state): New.
13109         (child_terminal_init): Adjust.
13110         (is_gdb_terminal, sharing_input_terminal_1)
13111         (sharing_input_terminal): New functions.
13112         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
13113         Set the process's actual process group in the foreground if
13114         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
13115         mark terminal as the inferior's if not sharing GDB's terminal.
13116         Don't check attach_flag.
13117         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
13118         pass down a target_terminal_state.
13119         (child_terminal_save_inferior): New, factored out from ...
13120         (child_terminal_ours_1): ... this.  Handle
13121         target_terminal_state::is_ours_for_output.
13122         (child_interrupt, child_pass_ctrlc): New.
13123         (inflow_inferior_exit): Clear the inferior's terminal_state.
13124         (copy_terminal_info): Copy the inferior's terminal state.
13125         (_initialize_inflow): Remove reference to terminal_is_ours.
13126         * inflow.h (inferior_process_group): Delete.
13127         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
13128         * procfs.c (procfs_target): Don't install procfs_interrupt.
13129         (procfs_interrupt): Delete.
13130         * remote.c (remote_serial_quit_handler): Adjust.
13131         (remote_interrupt): Remove ptid parameter.  Adjust.
13132         * target-delegates.c: Regenerate.
13133         * target.c: Include "terminal.h".
13134         (target_terminal::terminal_state): Rename to ...
13135         (target_terminal::m_terminal_state): ... this.
13136         (target_terminal::init): Adjust.
13137         (target_terminal::inferior): Adjust to per-inferior
13138         terminal_state.
13139         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
13140         (target_terminal::ours, target_terminal::ours_for_output): Use
13141         target_terminal_is_ours_kind.
13142         (target_interrupt): Remove ptid parameter.  Adjust.
13143         (default_target_pass_ctrlc): Adjust.
13144         * target.h (target_ops::to_terminal_save_inferior): New field.
13145         (target_ops::to_interrupt): Remove ptid_t parameter.
13146         (target_interrupt): Remove ptid_t parameter.  Update comment.
13147         (target_pass_ctrlc): Update comment.
13148         * target/target.h (target_terminal_state): New scoped enum,
13149         factored out of ...
13150         (target_terminal::terminal_state): ... here.
13151         (target_terminal::inferior): Update comments.
13152         (target_terminal::restore_inferior): New.
13153         (target_terminal::is_inferior, target_terminal::is_ours)
13154         (target_terminal::is_ours_for_output): Adjust.
13155         (target_terminal::scoped_restore_terminal_state): Adjust to
13156         rename, and call restore_inferior() instead of inferior().
13157         (target_terminal::scoped_restore_terminal_state::m_state): Change
13158         type.
13159         (target_terminal::terminal_state): Rename to ...
13160         (target_terminal::m_terminal_state): ... this and change type.
13161
13162 2018-01-30  Pedro Alves  <palves@redhat.com>
13163
13164         * linux-nat.c (wait_for_signal): New function.
13165         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
13166         directly.
13167         (async_terminal_is_ours)
13168         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
13169         (linux_nat_add_target): Don't override
13170         to_terminal_inferior/to_terminal_ours.
13171
13172 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
13173
13174         * remote.c (remote_follow_fork): Don't call "detach_inferior".
13175
13176 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
13177
13178         * dwarf2read.c (free_dwo_files): Add forward-declaration.
13179         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
13180         dwarf2_per_objfile_free here.
13181         (dwarf2_per_objfile_free): Remove.
13182         (_initialize_dwarf2_read): Don't register
13183         dwarf2_per_objfile_free as a registry cleanup.
13184
13185 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
13186
13187         Avoid compilation errors in MinGW native builds
13188
13189         The error is triggered by including python-internal.h, and the
13190         error message is:
13191
13192              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
13193                       from build-gnulib/import/math.h:27,
13194                       from d:/usr/Python26/include/pyport.h:235,
13195                       from d:/usr/Python26/include/Python.h:58,
13196                       from python/python-internal.h:94,
13197                       from python/py-arch.c:24:
13198              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
13199         using ::hypot;
13200                 ^~~~~
13201
13202         This happens because Python headers define 'hypot' to expand t
13203         '_hypot' in the Windows builds.
13204         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
13205         'hypoth'.  This avoids a compilation error.
13206
13207 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
13208
13209         * MAINTAINERS (Write After Approval): Fix ordering.
13210
13211 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
13212
13213         * MAINTAINERS (Write After Approval): Add Alan Hayward.
13214
13215 2018-01-26  Alan Modra  <amodra@gmail.com>
13216
13217         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
13218         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
13219         Remove nop.  Make const.  Comment.
13220         (powerpc32_plt_stub_so_2): New.
13221         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
13222         Correct count.  Update uses.
13223         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
13224         Move common code reading PLT entry word.  Correct
13225         powerpc32_plt_stub PLT address calculation.
13226         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
13227         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
13228         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
13229         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
13230         (ppc64_standard_linkage8): Likewise.
13231         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
13232         Correct insns description.
13233         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
13234
13235 2018-01-24  Pedro Alves  <palves@redhat.com>
13236
13237         GCC PR libstdc++/83906
13238         * gdbtypes.c (operator==(const dynamic_prop &,
13239         const dynamic_prop &)): New.
13240         (operator==(const range_bounds &, const range_bounds &)): New.
13241         (check_types_equal): Use them instead of memcmp.
13242         * gdbtypes.h (operator==(const dynamic_prop &,
13243         const dynamic_prop &)): Declare.
13244         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
13245         (operator==(const range_bounds &, const range_bounds &)): Declare.
13246         (operator!=(const range_bounds &, const range_bounds &)): Declare.
13247
13248 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13249
13250         * s390-linux-tdep.c (s390_record_address_mask)
13251         (s390_record_calc_disp_common, s390_record_calc_disp)
13252         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
13253         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
13254         (s390_process_record): Move to s390-tdep.c.
13255         (s390_linux_init_abi_any): Adjust.
13256         * s390-tdep.c (s390_record_address_mask)
13257         (s390_record_calc_disp_common, s390_record_calc_disp)
13258         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
13259         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
13260         (s390_process_record): Moved from s390-linux-tdep.c
13261         (s390_gdbarch_init): Adjust.
13262
13263 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13264
13265         * s390-linux-nat.c (s390-tdep.h): New include.
13266         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
13267         (HFILES_NO_SRCDIR): Add s390-tdep.h.
13268         (ALLDEPFILES): Add s390-tdep.c.
13269         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
13270         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
13271         * s390-tdep.h: ...this.  New file.
13272         * s390-linux-tdep.c (s390-tdep.h): New include.
13273         (_initialize_s390_tdep): Rename to...
13274         (_initialize_s390_linux_tdep): ...this and adjust.
13275         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
13276         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
13277         s390-tdep.h.
13278         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
13279         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
13280         (s390_is_partial_instruction, s390_software_single_step)
13281         (is_non_branch_ril, s390_displaced_step_copy_insn)
13282         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
13283         (s390_prologue_data, s390_addr, s390_store, s390_load)
13284         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
13285         (s390_register_call_saved, s390_guess_tracepoint_registers)
13286         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
13287         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
13288         (s390_pseudo_register_name, s390_pseudo_register_type)
13289         (s390_pseudo_register_read, s390_pseudo_register_write)
13290         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
13291         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
13292         (s390_addr_bits_remove, s390_address_class_type_flags)
13293         (s390_address_class_type_flags_to_name)
13294         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
13295         (s390_function_arg_float, s390_function_arg_vector)
13296         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
13297         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
13298         (s390_frame_align, s390_register_return_value, s390_return_value)
13299         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
13300         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
13301         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
13302         (s390_trad_frame_prev_register, s390_unwind_cache)
13303         (s390_prologue_frame_unwind_cache)
13304         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
13305         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
13306         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
13307         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
13308         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
13309         (s390_frame_base_address, s390_local_base_address)
13310         (s390_frame_base, s390_gcc_target_options)
13311         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
13312         (s390_validate_reg_range, s390_tdesc_valid)
13313         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
13314         * s390-tdep.c: ...this.  New file.
13315
13316 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13317
13318         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
13319         (s390_process_record, s390_gdbarch_tdep_alloc)
13320         (s390_linux_init_abi_any): Use/set new hook.
13321
13322 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13323
13324         * s390-linux-tdep.c (osabi.h): New include.
13325         (s390_linux_init_abi_31, s390_linux_init_abi_64)
13326         (s390_linux_init_abi_any): New functions.
13327         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
13328
13329 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13330
13331         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
13332         tdesc_has_registers check
13333
13334 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13335
13336         * s390-linux-tdep.c (s390_tdesc_valid): New function.
13337         (s390_validate_reg_range): New macro.
13338         (s390_gdbarch_init): Adjust.
13339
13340 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13341
13342         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
13343         (s390_gdbarch_tdep_alloc): Adjust.
13344         (s390_gdbarch_init): Adjust.
13345
13346 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13347
13348         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
13349         <have_tdb>: Change type to bool.
13350         (s390_gdbarch_tdep_alloc): Adjust.
13351         (s390_gdbarch_init): Adjust.
13352
13353 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13354
13355         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
13356         (gdbarch_tdep) <have_upper, have_vx>: New fields.
13357         (s390_gdbarch_tdep_alloc): New function.
13358         (s390_gdbarch_init): Allocate tdep at start and use its fields
13359         instead of separate variables.
13360
13361 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
13362
13363         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
13364         when looking for cached gdbarch and add comment for remaining.
13365
13366 2018-01-22  Pedro Alves  <palves@redhat.com>
13367             Sergio Durigan Junior  <sergiodj@redhat.com>
13368
13369         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
13370         case.
13371
13372 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
13373
13374         * MAINTAINERS: Update my company e-mail address.
13375
13376 2018-01-22  Yao Qi  <yao.qi@linaro.org>
13377
13378         * regcache.c (cooked_write_test): New function.
13379         (_initialize_regcache): Register the test.
13380
13381 2018-01-22  Yao Qi  <yao.qi@linaro.org>
13382
13383         * ia64-tdep.c (ia64_pseudo_register_read): Call
13384         regcache->cooked_read instead of regcache_cooked_read_unsigned.
13385         * m32c-tdep.c (m32c_cat_read): Likewise.
13386         (m32c_r3r2r1r0_read): Likewise.
13387         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
13388         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
13389
13390 2018-01-22  Yao Qi  <yao.qi@linaro.org>
13391
13392         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
13393         method raw_read instead of regcache_raw_read.
13394         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
13395         * arm-tdep.c (arm_neon_quad_read): Likewise.
13396         * avr-tdep.c (avr_pseudo_register_read): Likewise.
13397         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
13398         * frv-tdep.c (frv_pseudo_register_read): Likewise.
13399         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
13400         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
13401         (i386_pseudo_register_read_into_value): Likewise.
13402         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
13403         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
13404         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
13405         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
13406         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
13407         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
13408         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
13409         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
13410         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
13411
13412 2018-01-22  Yao Qi  <yao.qi@linaro.org>
13413
13414         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
13415         * configure.tgt: Remove target mt.
13416         * mt-tdep.c: Remove.
13417         * regcache.c (cooked_read_test): Remove the check for mt.
13418
13419 2018-01-22  Yao Qi  <yao.qi@linaro.org>
13420
13421         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
13422         instead of gdbarch_pseudo_register_read_value.
13423
13424 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
13425
13426         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
13427         language is Ada.
13428
13429 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
13430
13431         * linespec.c (create_sals_line_offset): Remove code that preserved
13432         the symtab_and_line's line number.
13433
13434 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
13435
13436         * varobj.c (varobj_create): Don't set valid_block when creating a
13437         floating varobj.
13438
13439 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
13440
13441         * varobj.c (varobj_create): Remove out of date comment.
13442
13443 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
13444
13445         PR mi/20395
13446         * ada-exp.y (write_var_from_sym): Pass extra parameter when
13447         updating innermost block.
13448         * parse.c (innermost_block_tracker::update): Take extra type
13449         parameter, and check types match before updating innermost block.
13450         (write_dollar_variable): Update innermost block for registers.
13451         * parser-defs.h (enum innermost_block_tracker_type): New enum.
13452         (innermost_block_tracker::innermost_block_tracker): Initialise
13453         m_types member.
13454         (innermost_block_tracker::reset): Take type parameter.
13455         (innermost_block_tracker::update): Take type parameter, and pass
13456         type through as needed.
13457         (innermost_block_tracker::m_types): New member.
13458         * varobj.c (varobj_create): Pass type when reseting innermost
13459         block.
13460
13461 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
13462
13463         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
13464         * ada-lang.c (resolve_subexp): Likewise.
13465         * breakpoint.c (set_breakpoint_condition) Likewise.
13466         (watch_command_1) Likewise.
13467         * c-exp.y (variable): Likewise.
13468         * d-exp.y (PrimaryExpression): Likewise.
13469         * f-exp.y (variable): Likewise.
13470         * go-exp.y (variable): Likewise.
13471         * m2-exp.y (variable): Likewise.
13472         * objfiles.c (objfile::~objfile): Likewise.
13473         * p-exp.y (variable): Likewise.
13474         * parse.c (innermost_block): Change type.
13475         * parser-defs.h (class innermost_block_tracker): New.
13476         (innermost_block): Change to innermost_block_tracker.
13477         * printcmd.c (display_command): Switch to innermost_block API.
13478         (do_one_display): Likewise.
13479         * rust-exp.y (do_one_display): Likewise.
13480         * symfile.c (clear_symtab_users): Likewise.
13481         * varobj.c (varobj_create): Switch to innermost_block API, replace
13482         use of innermost_block with block stored on varobj object.
13483
13484 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
13485
13486         * expression.h (innermost_block): Remove declaration.
13487         * varobj.c: Add 'parser-defs.h' include.
13488
13489 2018-01-19  Tom Tromey  <tom@tromey.com>
13490
13491         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
13492         symbols in the static and global blocks.
13493
13494 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
13495
13496         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
13497         gdb_ptrace.h, and move including gdb_wait.h ...
13498         * nat/linux-ptrace.h: ... to here.
13499
13500 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
13501
13502         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
13503         inf_ptrace_detach_success.
13504         (inf_ptrace_detach_success): Add inferior parameter, use it
13505         instead of inferior_ptid, pass it to detach_inferior.
13506         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
13507         parameter.
13508         * inferior.c (detach_inferior): Add overload that takes an
13509         inferior object.
13510         * inferior.h (detach_inferior): Likewise.
13511         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
13512         use inferior_ptid, adjust call to inf_ptrace_detach_success.
13513         * linux-thread-db.c (thread_db_detach): Use inf parameter.
13514
13515 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
13516
13517         * target.h (struct target_ops) <to_detach>: Add inferior
13518         parameter.
13519         (target_detach): Likewise.
13520         * target.c (dispose_inferior): Pass inferior down.
13521         (target_detach): Pass inferior down.  Assert that it is equal to
13522         the current inferior.
13523         * aix-thread.c (aix_thread_detach): Pass inferior down.
13524         * corefile.c (core_file_command): Pass current_inferior() down.
13525         * corelow.c (core_detach): Add inferior parameter.
13526         * darwin-nat.c (darwin_detach): Likewise.
13527         * gnu-nat.c (gnu_detach): Likewise.
13528         * inf-ptrace.c (inf_ptrace_detach): Likewise.
13529         * infcmd.c (detach_command): Pass current_inferior() down to
13530         target_detach.
13531         * infrun.c (follow_fork_inferior): Pass parent_inf to
13532         target_detach.
13533         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
13534         target_detach.
13535         * linux-nat.c (linux_nat_detach): Add inferior parameter.
13536         * linux-thread-db.c (thread_db_detach): Likewise.
13537         * nto-procfs.c (procfs_detach): Likewise.
13538         * procfs.c (procfs_detach): Likewise.
13539         * record.c (record_detach): Likewise.
13540         * record.h (struct inferior): Forward-declare.
13541         (record_detach): Add inferior parameter.
13542         * remote-sim.c (gdbsim_detach): Likewise.
13543         * remote.c (remote_detach_1): Likewise.
13544         (remote_detach): Likewise.
13545         (extended_remote_detach): Likewise.
13546         * sol-thread.c (sol_thread_detach): Likewise.
13547         * target-debug.h (target_debug_print_inferior_p): New macro.
13548         * target-delegates.c: Re-generate.
13549         * top.c (kill_or_detach): Pass inferior down to target_detach.
13550         * windows-nat.c (windows_detach): Add inferior parameter.
13551
13552 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
13553
13554         * target.h (struct target_ops) <to_detach>: Remove args
13555         parameter.
13556         (target_detach): Likewise.
13557         * target.c (dispose_inferior): Adjust.
13558         (target_detach): Remove args parameter, adjust.
13559         * aix-thread.c (aix_thread_detach): Adjust.
13560         * corefile.c (core_file_command): Adjust.
13561         * corelow.c (core_detach): Adjust.
13562         * darwin-nat.c (darwin_detach): Adjust.
13563         * gnu-nat.c (gnu_detach): Adjust.
13564         * inf-ptrace.c (inf_ptrace_detach): Adjust.
13565         * infcmd.c (detach_command): Adjust
13566         * infrun.c (follow_fork_inferior): Adjust.
13567         (handle_vfork_child_exec_or_exit): Adjust.
13568         * linux-fork.c (linux_fork_detach): Remove args parameter.
13569         * linux-fork.h (linux_fork_detach): Likewise.
13570         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
13571         * linux-thread-db.c (thread_db_detach): Likewise.
13572         * nto-procfs.c (procfs_detach): Likewise.
13573         * procfs.c (procfs_detach): Likewise.
13574         (do_detach): Remove signo parameter.
13575         * record.c (record_detach): Remove args parameter.
13576         * record.h (record_detach): Likewise.
13577         * remote-sim.c (gdbsim_detach): Likewise.
13578         * remote.c (remote_detach_1): Likewise.
13579         (remote_detach): Likewise.
13580         (extended_remote_detach): Likewise.
13581         * sol-thread.c (sol_thread_detach): Likewise.
13582         * target-delegates.c: Re-generate.
13583         * top.c (struct qt_args) <args>: Remove field.
13584         (kill_or_detach): Don't pass args.
13585         (quit_force): Don't set args.
13586         * windows-nat.c (windows_detach): Remove args parameter.
13587
13588 2018-01-19  Yao Qi  <yao.qi@linaro.org>
13589
13590         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
13591         (arm_linux_init_abi): Install it.
13592
13593 2018-01-19  Yao Qi  <yao.qi@linaro.org>
13594
13595         * osabi.c (gdb_osabi_names): Extend the regexp for
13596         arm-linux-gnueabihf.
13597
13598 2018-01-18  Yao Qi  <yao.qi@linaro.org>
13599
13600         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
13601         m_abbrevs.
13602         (abbrev_table::add_abbrev): Update.
13603         (abbrev_table::lookup_abbrev): Update.
13604
13605 2018-01-18  Yao Qi  <yao.qi@linaro.org>
13606
13607         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
13608
13609 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
13610
13611         * compile/compile.c (compile_to_object): Convert "triplet_rx"
13612         to "std::string".
13613
13614 2018-01-17  Tom Tromey  <tom@tromey.com>
13615
13616         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
13617
13618 2018-01-17  Tom Tromey  <tom@tromey.com>
13619
13620         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
13621         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
13622         (create_array_type_with_stride): Update.
13623         * dwarf2read.c (set_die_type): Update.
13624
13625 2018-01-17  Tom Tromey  <tom@tromey.com>
13626
13627         * dwarf2read.c (delayed_method_info): Remove typedef.
13628         (dwarf2_cu::method_info): Now a std::vector.
13629         (add_to_method_list): Update.
13630         (free_delayed_list): Remove.
13631         (compute_delayed_physnames): Update.
13632         (process_full_comp_unit, process_full_type_unit): Clear the method
13633         list.  Remove cleanups.
13634         (psymtab_include_file_name): Add name_holder parameter.  Use
13635         unique_xmalloc_ptr.
13636         (dwarf_decode_lines): Update.
13637
13638 2018-01-17  Tom Tromey  <tom@tromey.com>
13639             Simon Marchi  <simon.marchi@ericsson.com>
13640
13641         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
13642         (dwarf2_per_objfile::free_cached_comp_units)
13643         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
13644         (init_cutu_and_read_dies_no_follow): Update.
13645         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
13646         (dwarf2_cu::~dwarf2_cu): New.
13647         (free_heap_comp_unit, free_stack_comp_unit): Remove.
13648         (age_cached_comp_units, free_one_cached_comp_unit): Update.
13649
13650 2018-01-17  Tom Tromey  <tom@tromey.com>
13651             Simon Marchi  <simon.marchi@ericsson.com>
13652
13653         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
13654         (struct die_reader_specs) <abbrev_table>: New member.
13655         (struct abbrev_table): Add constructor.
13656         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
13657         <abbrev_obstack>: Now an auto_obstack.
13658         (abbrev_table_up): New typedef.
13659         (init_cu_die_reader): Add abbrev_table parameter.
13660         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
13661         Add result_dwo_abbrev_table.
13662         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
13663         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
13664         Update.
13665         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
13666         parameter.
13667         (skip_children): Update.
13668         (abbrev_table::alloc_abbrev): Rename from
13669         abbrev_table_alloc_abbrev.
13670         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
13671         (abbrev_table::lookup_abbrev): Rename from
13672         abbrev_table_lookup_abbrev.
13673         (abbrev_table_read_table): Return abbrev_table_up.
13674         (abbrev_table_free, abbrev_table_free_cleanup)
13675         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
13676         (load_partial_dies): Update.
13677
13678 2018-01-17  Tom Tromey  <tom@tromey.com>
13679
13680         * dwarf2read.c (dwarf2_compute_name): Update comment.
13681         (read_func_scope, read_variable): Update.
13682         (new_symbol): Remove.
13683         (new_symbol_full): Rename to new_symbol.
13684
13685 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
13686
13687         PR gdb/16577
13688         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
13689         a warning instead of throwing an error, set section size to 0 and return
13690         NULL.
13691         * gdb_bfd.h (gdb_bfd_map_section): Update description.
13692
13693 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
13694
13695         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
13696         std::string.
13697         (linux_ptrace_attach_fail_reason_string): Likewise.
13698         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
13699         Likewise.
13700         (linux_ptrace_attach_fail_reason_string): Likewise.
13701         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
13702
13703 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
13704
13705         * linux-nat.c (linux_nat_attach): Remove xstrdup.
13706
13707 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
13708
13709         PR gdb/21559
13710         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
13711         checking for fs_base/gs_base fields in struct user_regs_struct.
13712         * configure: Regenerate.
13713
13714 2018-01-17  Yao Qi  <yao.qi@linaro.org>
13715
13716         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
13717         function.
13718         (aarch64_linux_init_abi): Install it to gdbarch hook
13719         gcc_target_options.
13720
13721 2018-01-15  Pedro Alves  <palves@redhat.com>
13722
13723         * common/signals-state-save-restore.c
13724         (save_original_signals_state): Fix typos.
13725
13726 2017-01-12  Tom Tromey  <tom@tromey.com>
13727             Sergio Durigan Junior  <sergiodj@redhat.com>
13728
13729         * Makefile.in (install-only): Install gdb-add-index.
13730
13731 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
13732
13733         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
13734
13735 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
13736
13737         * infrun.c (keep_going_pass_signal): Clear step-over info when
13738         insert_breakpoints fails.
13739
13740 2018-01-11  Pedro Alves  <palves@redhat.com>
13741
13742         PR gdb/22583
13743         * infrun.c (resume): Rename to ...
13744         (resume_1): ... this.
13745         (resume): Reimplement as wrapper around resume_1.
13746
13747 2018-01-11  Pedro Alves  <palves@redhat.com>
13748
13749         PR remote/22597
13750         * remote.c (remote_parse_stop_reply): Default to the last-set
13751         general thread instead of to 'magic_null_ptid'.
13752
13753 2018-01-10  Pedro Alves  <palves@redhat.com>
13754
13755         * language.h (language_get_symbol_name_matcher): Rename ...
13756         (get_symbol_name_matcher): ... this.
13757         * language.c (language_get_symbol_name_matcher): Ditto.
13758         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
13759         callers adjusted.
13760
13761 2018-01-10  Pedro Alves  <palves@redhat.com>
13762
13763         PR gdb/22670
13764         * dwarf2read.c
13765         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
13766         Adjust to use language_get_symbol_name_matcher instead of
13767         language_defn::la_get_symbol_name_matcher.
13768         * language.c (language_get_symbol_name_matcher): If in Ada mode
13769         and the lookup name is a verbatim match, return Ada's matcher.
13770         * language.h (language_get_symbol_name_matcher): Adjust comment.
13771         (ada_lookup_name_info::verbatim_p):: New method.
13772
13773 2018-01-10  Pedro Alves  <palves@redhat.com>
13774
13775         PR gdb/22670
13776         * ada-lang.c (ada_collect_symbol_completion_matches): If the
13777         minsym's language is language_auto or language_cplus, pass down
13778         language_ada instead.
13779         * symtab.c (compare_symbol_name): Don't frob symbol language here.
13780
13781 2018-01-10  Pedro Alves  <palves@redhat.com>
13782
13783         PR gdb/22670
13784         * minsyms.c (linkage_name_str): New function.
13785         (iterate_over_minimal_symbols): Use it.
13786
13787 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
13788
13789         * NEWS: Document that 'info proc' now works on FreeBSD.
13790
13791 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
13792
13793         * configure.ac: Check for kinfo_getfile in libutil.
13794         * configure: Regenerate.
13795         * config.in: Regenerate.
13796         * fbsd-nat.c: Include "fbsd-tdep.h".
13797         (fbsd_fetch_cmdline): New.
13798         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
13799         rather than calling error.
13800         (fbsd_info_proc): New.
13801         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
13802         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
13803         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
13804
13805 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
13806
13807         * fbsd-nat.c (struct free_deleter): Remove.
13808         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
13809
13810 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
13811
13812         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
13813         NULL for an empty pathname.
13814
13815 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
13816
13817         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
13818         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
13819         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
13820         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
13821         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
13822         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
13823         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
13824         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
13825         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
13826         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
13827         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
13828         (fbsd_core_fetch_timeval, fbsd_print_sigset)
13829         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
13830         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
13831         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
13832
13833 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
13834
13835         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
13836         (gnu_xfer_auxv): New function.
13837         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
13838         TARGET_OBJECT_AUXV.
13839
13840 2018-01-08  Yao Qi  <yao.qi@linaro.org>
13841             Simon Marchi  <simon.marchi@ericsson.com>
13842
13843         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
13844         common/selftest.c.
13845         (COMMON_OBS): Remove selftest.o.
13846         * configure.ac: Append selftest-arch.c and common/selftest.c to
13847         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
13848         * configure: Re-generated.
13849         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
13850         GDB_SELF_TEST.
13851         (maintenance_info_selftests): Likewise.
13852
13853 2018-01-08  Xavier Roirand  <roirand@adacore.com>
13854
13855         * ada-valprint.c (val_print_packed_array_elements): Use
13856         proper number of elements when printing an array indexed
13857         by an enumeration type.
13858
13859 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
13860
13861         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
13862         (dw2_get_file_names_reader): Adjust.
13863         (lookup_dwo_signatured_type): Adjust.
13864         (lookup_dwp_signatured_type): Adjust.
13865         (lookup_signatured_type): Adjust.
13866         (create_type_unit_group): Adjust.
13867         (get_type_unit_group): Adjust.
13868         (process_psymtab_comp_unit_reader): Adjust.
13869         (build_type_psymtabs_reader): Adjust.
13870         (scan_partial_symbols): Adjust.
13871         (add_partial_symbol): Adjust.
13872         (add_partial_subprogram): Adjust.
13873         (peek_die_abbrev): Adjust.
13874         (fixup_go_packaging): Adjust.
13875         (process_imported_unit_die): Adjust.
13876         (dwarf2_compute_name): Adjust.
13877         (dwarf2_physname): Adjust.
13878         (read_import_statement): Adjust.
13879         (handle_DW_AT_stmt_list): Adjust.
13880         (read_file_scope): Adjust.
13881         (read_func_scope): Adjust.
13882         (read_lexical_block_scope): Adjust.
13883         (read_call_site_scope): Adjust.
13884         (read_variable): Adjust.
13885         (dwarf2_rnglists_process): Adjust.
13886         (dwarf2_ranges_process): Adjust.
13887         (dwarf2_ranges_read): Adjust.
13888         (dwarf2_get_pc_bounds): Adjust.
13889         (dwarf2_record_block_ranges): Adjust.
13890         (dwarf2_add_field): Adjust.
13891         (dwarf2_add_member_fn): Adjust.
13892         (read_structure_type): Adjust.
13893         (process_structure_scope): Adjust.
13894         (read_enumeration_type): Adjust.
13895         (read_array_type): Adjust.
13896         (mark_common_block_symbol_computed): Adjust.
13897         (read_common_block): Adjust.
13898         (read_namespace_type): Adjust.
13899         (read_namespace): Adjust.
13900         (read_module_type): Adjust.
13901         (read_tag_pointer_type): Adjust.
13902         (read_tag_ptr_to_member_type): Adjust.
13903         (read_tag_string_type): Adjust.
13904         (read_subroutine_type): Adjust.
13905         (read_typedef): Adjust.
13906         (read_base_type): Adjust.
13907         (attr_to_dynamic_prop): Adjust.
13908         (read_subrange_type): Adjust.
13909         (read_unspecified_type): Adjust.
13910         (dwarf2_read_abbrevs): Adjust.
13911         (load_partial_dies): Adjust.
13912         (read_partial_die): Adjust.
13913         (find_partial_die): Adjust.
13914         (guess_partial_die_structure_name): Adjust.
13915         (fixup_partial_die): Adjust.
13916         (read_attribute_value): Adjust.
13917         (read_addr_index): Adjust.
13918         (read_addr_index_from_leb128): Adjust.
13919         (read_str_index): Adjust.
13920         (dwarf2_string_attr): Adjust.
13921         (get_debug_line_section): Adjust.
13922         (dwarf_decode_line_header): Adjust.
13923         (lnp_state_machine::check_line_address): Adjust.
13924         (dwarf_decode_lines_1): Adjust.
13925         (dwarf_decode_lines): Adjust.
13926         (dwarf2_start_symtab): Adjust.
13927         (var_decode_location): Adjust.
13928         (new_symbol_full): Adjust.
13929         (dwarf2_const_value_data): Adjust.
13930         (dwarf2_const_value_attr): Adjust.
13931         (dwarf2_const_value): Adjust.
13932         (die_type): Adjust.
13933         (die_containing_type): Adjust.
13934         (build_error_marker_type): Adjust.
13935         (lookup_die_type): Adjust.
13936         (guess_full_die_structure_name): Adjust.
13937         (anonymous_struct_prefix): Adjust.
13938         (determine_prefix): Adjust.
13939         (dwarf2_name): Adjust.
13940         (follow_die_ref_or_sig): Adjust.
13941         (follow_die_offset): Adjust.
13942         (follow_die_ref): Adjust.
13943         (follow_die_sig_1): Adjust.
13944         (follow_die_sig): Adjust.
13945         (get_signatured_type): Adjust.
13946         (get_DW_AT_signature_type): Adjust.
13947         (decode_locdesc): Adjust.
13948         (dwarf_decode_macros): Adjust.
13949         (cu_debug_loc_section): Adjust.
13950         (fill_in_loclist_baton): Adjust.
13951         (dwarf2_symbol_mark_computed): Adjust.
13952         (init_one_comp_unit): Don't assign
13953         dwarf2_cu::dwarf2_per_objfile.
13954         (set_die_type): Adjust.
13955
13956 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
13957
13958         * dwarf2read.c (struct mapped_debug_names): Add constructor.
13959         <dwarf2_per_objfile>: New field.
13960         (dwarf2_per_objfile): Remove global.
13961         (get_dwarf2_per_objfile): New function.
13962         (set_dwarf2_per_objfile): New function.
13963         (dwarf2_build_psymtabs_hard): Change objfile parameter to
13964         dwarf2_per_objfile.
13965         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
13966         (read_abbrev_offset): Likewise.
13967         (read_indirect_string): Likewise.
13968         (read_indirect_line_string): Likewise.
13969         (read_indirect_string_at_offset): Likewise.
13970         (read_indirect_string_from_dwz): Likewise.
13971         (dwarf2_find_containing_comp_unit): Change objfile parameter to
13972         dwarf2_per_objfile.
13973         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
13974         (create_all_comp_units): Change objfile parameter to
13975         dwarf2_per_objfile.
13976         (create_all_type_units): Likewise.
13977         (process_queue): Add dwarf2_per_objfile parameter.
13978         (read_and_check_comp_unit_head): Likewise.
13979         (lookup_dwo_unit_in_dwp): Likewise.
13980         (get_dwp_file): Likewise.
13981         (process_cu_includes): Likewise.
13982         (struct free_dwo_file_cleanup_data): New struct.
13983         (dwarf2_has_info): Use get_dwarf2_per_objfile and
13984         set_dwarf2_per_objfile.
13985         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
13986         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
13987         context, adjust calls.
13988         (dw2_instantiate_symtab): Likewise.
13989         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
13990         (dw2_get_cu): Likewise.
13991         (create_cu_from_index_list): Change objfile parameter to
13992         dwarf2_per_objfile.
13993         (create_cus_from_index_list): Get dwarf2_per_objfile from
13994         context, adjust calls.
13995         (create_cus_from_index): Likewise.
13996         (create_signatured_type_table_from_index): Change objfile
13997         parameter to dwarf2_per_objfile.
13998         (create_signatured_type_table_from_debug_names): Change objfile
13999         parameter to dwarf2_per_objfile.
14000         (create_addrmap_from_index): Likewise.
14001         (create_addrmap_from_aranges): Likewise.
14002         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
14003         (dw2_setup): Remove.
14004         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
14005         context.
14006         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
14007         get_dwarf2_per_objfile.
14008         (dw2_forget_cached_source_info): Likewise.
14009         (dw2_map_symtabs_matching_filename): Likewise.
14010         (struct dw2_symtab_iterator) <index>: Remove.
14011         <dwarf2_per_objfile>: New field.
14012         (dw2_symtab_iter_init): Replace index parameter with
14013         dwarf2_per_objfile.
14014         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
14015         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
14016         (dw2_print_stats): Likewise.
14017         (dw2_dump): Likewise.
14018         (dw2_expand_symtabs_for_function): Likewise.
14019         (dw2_expand_all_symtabs): Likewise.
14020         (dw2_expand_symtabs_with_fullname): Likewise.
14021         (dw2_expand_marked_cus): Replace index and objfile parameters
14022         with dwarf2_per_objfile.
14023         (dw_expand_symtabs_matching_file_matcher): Add
14024         dwarf2_per_objfile parameter and adjust calls.
14025         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
14026         adjust calls.
14027         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
14028         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
14029         adjust calls.
14030         (create_cus_from_debug_names_list): Replace objfile parameter
14031         with dwarf2_per_objfile and adjust calls.
14032         (create_cus_from_debug_names): Likewise.
14033         (dwarf2_read_debug_names): Likewise.
14034         (mapped_debug_names::namei_to_name): Adjust call.
14035         (dw2_debug_names_iterator::next): Likewise.
14036         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
14037         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
14038         (dw2_debug_names_dump): Likewise.
14039         (dw2_debug_names_expand_symtabs_for_function): Likewise.
14040         (dw2_debug_names_expand_symtabs_matching): Likewise.
14041         (dwarf2_initialize_objfile): Likewise.
14042         (dwarf2_build_psymtabs): Likewise.
14043         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
14044         this_cu.
14045         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
14046         (read_and_check_comp_unit_head): Likewise.
14047         (read_abbrev_offset): Likewise.
14048         (create_debug_type_hash_table): Likewise.
14049         (create_debug_types_hash_table): Likewise.
14050         (create_all_type_units): Replace objfile parameter with
14051         dwarf2_per_objfile.
14052         (add_type_unit): Add dwarf2_per_objfile parameter.
14053         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
14054         with dwarf2_per_objfile.
14055         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
14056         (lookup_dwp_signatured_type): Likewise.
14057         (lookup_signatured_type): Likewise.
14058         (read_cutu_die_from_dwo): Likewise.
14059         (init_tu_and_read_dwo_dies): Likewise.
14060         (init_cutu_and_read_dies): Likewise.
14061         (init_cutu_and_read_dies_no_follow): Likewise.
14062         (allocate_type_unit_groups_table): Add objfile parameter.
14063         (create_type_unit_group): Use dwarf2_per_objfile from cu.
14064         (get_type_unit_group): Likewise.
14065         (process_psymtab_comp_unit): Update call.
14066         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
14067         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
14068         (print_tu_stats): Likewise.
14069         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
14070         in void* parameter.
14071         (build_type_psymtabs): Change objfile parameter to
14072         dwarf2_per_objfile.
14073         (process_skeletonless_type_unit): Use dwarf2_per_objfile
14074         passed in void* parameter.
14075         (process_skeletonless_type_units): Change objfile parameter to
14076         dwarf2_per_objfile.
14077         (set_partial_user): Likewise.
14078         (dwarf2_build_psymtabs_hard): Likewise.
14079         (read_comp_units_from_section): Likewise.
14080         (create_all_comp_units): Likewise.
14081         (scan_partial_symbols): Update calls.
14082         (add_partial_symbol): Likewise.
14083         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
14084         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
14085         (process_queue): Add dwarf2_per_objfile parameter.
14086         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
14087         (compute_compunit_symtab_includes): Likewise.
14088         (process_cu_includes): Add dwarf2_per_objfile parameter.
14089         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
14090         (process_full_type_unit): Likewise.
14091         (process_imported_unit_die): Update call.
14092         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
14093         (read_file_scope): Likewise.
14094         (allocate_dwo_file_hash_table): Add objfile parameter.
14095         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
14096         (create_cus_hash_table): Likewise.
14097         (create_dwp_hash_table): Likewise.
14098         (create_dwo_unit_in_dwp_v1): Likewise.
14099         (create_dwp_v2_section): Likewise.
14100         (create_dwo_unit_in_dwp_v2): Likewise.
14101         (lookup_dwo_unit_in_dwp): Likewise.
14102         (try_open_dwop_file): Likewise.
14103         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
14104         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
14105         cleanup to include a reference to dwarf2_per_objfile.
14106         (open_dwp_file): Add dwarf2_per_objfile parameter.
14107         (open_and_init_dwp_file): Likewise.
14108         (get_dwp_file): Likewise.
14109         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
14110         (queue_and_load_all_dwo_tus): Update call.
14111         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
14112         data.
14113         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
14114         (dwarf2_ranges_process): Likewise.
14115         (dwarf2_get_pc_bounds): Likewise.
14116         (mark_common_block_symbol_computed): Likewise.
14117         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
14118         (dwarf2_read_abbrevs): Update call.
14119         (read_partial_die): Use dwarf2_per_objfile from cu.
14120         (find_partial_die): Likewise.
14121         (fixup_partial_die): Likewise.
14122         (read_attribute_value): Likewise.
14123         (read_indirect_string_at_offset_from): Add objfile parameter.
14124         (read_indirect_string_at_offset): Add dwarf2_per_objfile
14125         parameter.
14126         (read_indirect_string_from_dwz): Add objfile parameter.
14127         (read_indirect_string): Add objfile parameter.
14128         (read_addr_index_1): Add dwarf2_per_objfile parameter.
14129         (read_addr_index): Use dwarf2_per_objfile from cu.
14130         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
14131         call dw2_setup.
14132         (read_str_index): Use dwarf2_per_objfile from cu.
14133         (get_debug_line_section): Likewise.
14134         (read_formatted_entries): Add dwarf2_per_objfile parameter.
14135         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
14136         (new_symbol_full): Use dwarf2_per_objfile from cu.
14137         (build_error_marker_type): Likewise.
14138         (lookup_die_type): Likewise.
14139         (determine_prefix): Likewise.
14140         (follow_die_offset): Likewise.
14141         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
14142         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
14143         (dwarf2_fetch_die_type_sect_off): Likewise.
14144         (dwarf2_get_die_type): Likewise.
14145         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
14146         (get_signatured_type): Likewise.
14147         (get_DW_AT_signature_type): Likewise.
14148         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
14149         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
14150         (cu_debug_loc_section): Likewise.
14151         (fill_in_loclist_baton): Likewise.
14152         (dwarf2_symbol_mark_computed): Likewise.
14153         (dwarf2_find_containing_comp_unit): Change objfile parameter to
14154         dwarf2_per_objfile.
14155         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
14156         parameter.
14157         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
14158         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
14159         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
14160         (set_die_type): Use dwarf2_free_objfile from cu.
14161         (get_die_type_at_offset): Likewise.
14162         (dwarf2_per_objfile_free): Don't assign global variable.
14163         (debug_names) <constructor>: Add dwarf2_per_objfile
14164         parameter, update m_debugstrlookup construction.
14165         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
14166         parameter.
14167         <m_dwarf2_per_objfile>: New field.
14168         <lookup>: Use m_dwarf2_per_objfile.
14169         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
14170         (psyms_seen_size): Likewise.
14171         (write_gdbindex): Replace objfile parameter with
14172         dwarf2_per_objfile.
14173         (write_debug_names): Likewise.
14174         (write_psymtabs_to_index): Likewise.
14175         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
14176         calls.
14177
14178 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
14179
14180         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
14181         <dwarf2_per_objfile>: New field.
14182         (struct dwarf2_per_cu_data) <objfile>: Remove.
14183         <dwarf2_per_objfile>: New field.
14184         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
14185         of objfile.
14186         (create_signatured_type_table_from_index): Likewise.
14187         (create_debug_type_hash_table): Likewise.
14188         (fill_in_sig_entry_from_dwo_entry): Likewise.
14189         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
14190         (create_type_unit_group): Assign dwarf2_per_objfile instead of
14191         objfile.
14192         (create_partial_symtab): Access objfile through
14193         dwarf2_per_objfile.
14194         (process_psymtab_comp_unit_reader): Likewise.
14195         (read_comp_units_from_section): Likewise.
14196         (scan_partial_symbols): Likewise.
14197         (add_partial_symbol): Likewise.
14198         (add_partial_subprogram): Likewise.
14199         (peek_die_abbrev): Likewise.
14200         (fixup_go_packaging): Likewise.
14201         (process_full_comp_unit): Likewise.
14202         (process_full_type_unit): Likewise.
14203         (process_imported_unit_die): Likewise.
14204         (dwarf2_compute_name): Likewise.
14205         (dwarf2_physname): Likewise.
14206         (read_import_statement): Likewise.
14207         (create_cus_hash_table): Assign dwarf2_physname instead of
14208         objfile.
14209         (read_func_scope): Access objfile through dwarf2_per_objfile.
14210         (read_lexical_block_scope): Likewise.
14211         (read_call_site_scope): Likewise.
14212         (read_variable): Likewise.
14213         (dwarf2_rnglists_process): Likewise.
14214         (dwarf2_ranges_process): Likewise.
14215         (dwarf2_ranges_read): Likewise.
14216         (dwarf2_record_block_ranges): Likewise.
14217         (dwarf2_add_field): Likewise.
14218         (dwarf2_add_member_fn): Likewise.
14219         (read_structure_type): Likewise.
14220         (process_structure_scope): Likewise.
14221         (read_enumeration_type): Likewise.
14222         (read_array_type): Likewise.
14223         (read_common_block): Likewise.
14224         (read_namespace_type): Likewise.
14225         (read_namespace): Likewise.
14226         (read_module_type): Likewise.
14227         (read_tag_pointer_type): Likewise.
14228         (read_tag_ptr_to_member_type): Likewise.
14229         (read_tag_string_type): Likewise.
14230         (read_subroutine_type): Likewise.
14231         (read_typedef): Likewise.
14232         (read_base_type): Likewise.
14233         (attr_to_dynamic_prop): Likewise.
14234         (read_subrange_type): Likewise.
14235         (read_unspecified_type): Likewise.
14236         (load_partial_dies): Likewise.
14237         (read_partial_die): Likewise.
14238         (find_partial_die): Likewise.
14239         (guess_partial_die_structure_name): Likewise.
14240         (fixup_partial_die): Likewise.
14241         (read_attribute_value): Likewise.
14242         (read_addr_index_from_leb128): Likewise.
14243         (dwarf2_read_addr_index): Likewise.
14244         (dwarf2_string_attr): Likewise.
14245         (lnp_state_machine::check_line_address): Likewise.
14246         (dwarf_decode_lines_1): Likewise.
14247         (dwarf_decode_lines): Likewise.
14248         (dwarf2_start_symtab): Likewise.
14249         (var_decode_location): Likewise.
14250         (new_symbol_full): Likewise.
14251         (dwarf2_const_value_data): Likewise.
14252         (dwarf2_const_value_attr): Likewise.
14253         (dwarf2_const_value): Likewise.
14254         (die_type): Likewise.
14255         (die_containing_type): Likewise.
14256         (lookup_die_type): Likewise.
14257         (guess_full_die_structure_name): Likewise.
14258         (anonymous_struct_prefix): Likewise.
14259         (dwarf2_name): Likewise.
14260         (follow_die_ref_or_sig): Likewise.
14261         (follow_die_offset): Likewise.
14262         (follow_die_ref): Likewise.
14263         (dwarf2_fetch_die_loc_sect_off): Likewise.
14264         (dwarf2_fetch_constant_bytes): Likewise.
14265         (dwarf2_fetch_die_type_sect_off): Likewise.
14266         (dwarf2_get_die_type): Likewise.
14267         (follow_die_sig): Likewise.
14268         (decode_locdesc): Likewise.
14269         (dwarf2_per_cu_objfile): Likewise.
14270         (dwarf2_per_cu_text_offset): Likewise.
14271         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
14272         objfile.
14273         (set_die_type): Access objfile through
14274         dwarf2_per_objfile.
14275
14276 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
14277
14278         * valprint.c (converted_character_d): Remove typedef.
14279         (DEF_VEC_O (converted_character_d)): Remove.
14280         (count_next_character): Use std::vector.
14281         (print_converted_chars_to_obstack): Likewise.
14282         (generic_printstr): Likewise.
14283
14284 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
14285
14286         * xml-support.h (struct gdb_xml_value): Add constructor.
14287         <value>: Change type to unique_xmalloc_ptr.
14288         (gdb_xml_value_s): Remove typedef.
14289         (DEF_VEC_O (gdb_xml_value_s)): Remove.
14290         (gdb_xml_element_start_handler): Change parameter type to
14291         std::vector.
14292         (xml_find_attribute): Likewise.
14293         * xml-support.c (xml_find_attribute): Change parameter type to
14294         std::vector and adjust.
14295         (gdb_xml_values_cleanup): Remove.
14296         (gdb_xml_parser::start_element): Adjust to std::vector.
14297         (xinclude_start_include): Change paraeter type to std::vector
14298         and adjust.
14299         * btrace.c (check_xml_btrace_version): Likewise.
14300         (parse_xml_btrace_block): Likewise.
14301         (parse_xml_btrace_pt_config_cpu): Likewise.
14302         (parse_xml_btrace_pt): Likewise.
14303         (parse_xml_btrace_conf_bts): Likewise.
14304         (parse_xml_btrace_conf_pt): Likewise.
14305         * memory-map.c (memory_map_start_memory): Likewise.
14306         (memory_map_start_property): Likewise.
14307         * osdata.c (osdata_start_osdata): Likewise.
14308         (osdata_start_item): Likewise.
14309         (osdata_start_column): Likewise.
14310         * remote.c (start_thread): Likewise.
14311         * solib-aix.c (library_list_start_library): Likewise.
14312         (library_list_start_list): Likewise.
14313         * solib-svr4.c (library_list_start_library): Likewise.
14314         (svr4_library_list_start_list): Likewise.
14315         * solib-target.c (library_list_start_segment): Likewise.
14316         (library_list_start_section): Likewise.
14317         (library_list_start_library): Likewise.
14318         (library_list_start_list): Likewise.
14319         * tracepoint.c (traceframe_info_start_memory): Likewise.
14320         (traceframe_info_start_tvar): Likewise.
14321         * xml-syscall.c (syscall_start_syscall): Likewise.
14322         * xml-tdesc.c (tdesc_start_target): Likewise.
14323         (tdesc_start_feature): Likewise.
14324         (tdesc_start_reg): Likewise.
14325         (tdesc_start_union): Likewise.
14326         (tdesc_start_struct): Likewise.
14327         (tdesc_start_flags): Likewise.
14328         (tdesc_start_enum): Likewise.
14329         (tdesc_start_field): Likewise.
14330         (tdesc_start_enum_value): Likewise.
14331         (tdesc_start_vector): Likewise.
14332
14333 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
14334
14335         * extension.h (struct xmethod_worker) <clone>: Remove.
14336         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
14337         Remove.
14338         (python_xmethod_worker::clone): Remove.
14339         * valops.c (find_overload_match): Use std::move instead of
14340         clone.
14341
14342 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
14343
14344         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
14345         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
14346         <free_xmethod_worker_data>: Remove.
14347         <get_matching_xmethod_workers>: Chance VEC to std::vector.
14348         <get_xmethod_arg_types>: Remove.
14349         <get_xmethod_result_type>: Remove.
14350         <invoke_xmethod>: Remove.
14351         * extension.c (new_xmethod_worker): Remove.
14352         (clone_xmethod_worker): Remove.
14353         (get_matching_xmethod_workers): Return void, pass std::vector by
14354         pointer.
14355         (get_xmethod_arg_types): Rename to...
14356         (xmethod_worker::get_arg_types): ... this, and adjust.
14357         (get_xmethod_result_type): Rename to...
14358         (xmethod_worker::get_result_type): ... this, and adjust.
14359         (invoke_xmethod): Remove.
14360         (free_xmethod_worker): Remove.
14361         (free_xmethod_worker_vec): Remove.
14362         * extension.h (enum ext_lang_rc): Move here from
14363         extension-priv.h.
14364         (struct xmethod_worker): Add constructor and destructor.
14365         <data>: Remove.
14366         <value>: Remove.
14367         <invoke, clone, do_get_result_type, do_get_arg_types>: New
14368         virtual pure methods.
14369         <get_arg_types, get_result_type>: New methods.
14370         (xmethod_worker_ptr): Remove typedef.
14371         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
14372         (xmethod_worker_vec): Remove typedef.
14373         (xmethod_worker_up): New typedef.
14374         (invoke_xmethod): Remove.
14375         (clone_xmethod_worker): Remove.
14376         (free_xmethod_worker): Remove.
14377         (free_xmethod_worker_vec): Remove.
14378         (get_xmethod_arg_types): Remove.
14379         (get_xmethod_result_type): Remove.
14380         * valops.c (find_method_list): Use std::vector, don't use
14381         intermediate vector.
14382         (value_find_oload_method_list): Use std::vector.
14383         (find_overload_match): Use std::vector.
14384         (find_oload_champ): Use std::vector.
14385         * value.c (value_free): Use operator delete.
14386         (value_of_xmethod): Rename to...
14387         (value_from_xmethod): ... this.  Don't assign
14388         xmethod_worker::value, take rvalue-reference.
14389         (result_type_of_xmethod): Adjust.
14390         (call_xmethod): Adjust.
14391         * value.h: Include extension.h.
14392         (struct xmethod_worker): Don't forward-declare.
14393         (value_of_xmethod): Rename to...
14394         (value_from_xmethod): ... this, take rvalue-reference.
14395         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
14396         (struct python_xmethod_worker): ... this, add constructor and
14397         destructor.
14398         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
14399         (gdbpy_free_xmethod_worker_data): Rename to...
14400         (python_xmethod_worker::~python_xmethod_worker): ... this and
14401         adjust.
14402         (gdbpy_clone_xmethod_worker_data): Rename to...
14403         (python_xmethod_worker::clone): ... this and adjust.
14404         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
14405         temporary vector.
14406         (gdbpy_get_xmethod_arg_types): Rename to...
14407         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
14408         (gdbpy_get_xmethod_result_type): Rename to...
14409         (python_xmethod_worker::do_get_result_type): ... this and
14410         adjust.
14411         (gdbpy_invoke_xmethod): Rename to...
14412         (python_xmethod_worker::invoke): ... this and adjust.
14413         (new_python_xmethod_worker): Rename to...
14414         (python_xmethod_worker::python_xmethod_worker): ... this and
14415         adjust.
14416         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
14417         Remove.
14418         (gdbpy_free_xmethod_worker_data): Remove.
14419         (gdbpy_get_matching_xmethod_workers): Use std::vector.
14420         (gdbpy_get_xmethod_arg_types): Remove.
14421         (gdbpy_get_xmethod_result_type): Remove.
14422         (gdbpy_invoke_xmethod): Remove.
14423         * python/python.c (python_extension_ops): Remove obsolete
14424         callbacks.
14425
14426 2018-01-05  Pedro Alves  <palves@redhat.com>
14427
14428         PR gdb/18653
14429         * common/signals-state-save-restore.c
14430         (save_original_signals_state): New parameter 'quiet'.  Warn if we
14431         find a custom handler preinstalled, instead of internal erroring.
14432         But only warn if !quiet.
14433         * common/signals-state-save-restore.h
14434         (save_original_signals_state): New parameter 'quiet'.
14435         * main.c (captured_main_1): Move save_original_signals_state call
14436         after option handling, and pass QUIET.
14437
14438 2018-01-05  Pedro Alves  <palves@redhat.com>
14439
14440         * spu-tdep.c (spu_catch_start): Pass
14441         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
14442
14443 2018-01-05  Pedro Alves  <palves@redhat.com>
14444
14445         PR gdb/22670
14446         * ada-lang.c (literal_symbol_name_matcher): New function.
14447         (ada_get_symbol_name_matcher): Use it for
14448         symbol_name_match_type::SEARCH_NAME.
14449         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
14450         it down instead of assuming symbol_name_match_type::FULL.
14451         * block.h (block_lookup_symbol): New parameter 'match_type'.
14452         * c-valprint.c (print_unpacked_pointer): Use
14453         lookup_symbol_search_name instead of lookup_symbol.
14454         * compile/compile-object-load.c (get_out_value_type): Pass down
14455         symbol_name_match_type::SEARCH_NAME.
14456         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
14457         symbol_name_match_type::FULL.
14458         * cp-support.c (cp_get_symbol_name_matcher): Handle
14459         symbol_name_match_type::SEARCH_NAME.
14460         * infrun.c (insert_exception_resume_breakpoint): Use
14461         lookup_symbol_search_name.
14462         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
14463         * psymtab.c (maintenance_check_psymtabs): Use
14464         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
14465         * stack.c (print_frame_args): Use lookup_symbol_search_name and
14466         SYMBOL_SEARCH_NAME.
14467         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
14468         if symbol_name_match_type::SEARCH_NAME.
14469         (lookup_symbol_in_language): Pass down
14470         symbol_name_match_type::FULL.
14471         (lookup_symbol_search_name): New.
14472         (lookup_language_this): Pass down
14473         symbol_name_match_type::SEARCH_NAME.
14474         (lookup_symbol_aux, lookup_local_symbol): New parameter
14475         'match_type'.  Pass it down.
14476         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
14477         (lookup_symbol_search_name): New declaration.
14478         (lookup_symbol_in_block): New 'match_type' parameter.
14479
14480 2018-01-05  Pedro Alves  <palves@redhat.com>
14481
14482         PR gdb/22670
14483         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
14484         ada_lookup_symbol.
14485         (ada_lookup_symbol): Reimplement in terms of
14486         ada_lookup_symbol_list, bits factored out from
14487         ada_lookup_encoded_symbol.
14488
14489 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
14490
14491         * ada-exp.y (write_object_renaming): When subscripting an array
14492         using a symbol as the index, pass the block in call to
14493         ada_lookup_encoded_symbol when looking that symbol up.
14494
14495 2018-01-05  Jerome Guitton  <guitton@adacore.com>
14496
14497         * ada-lang.c (ada_array_length): Use ada_index_type instead of
14498         TYPE_INDEX_TYPE.
14499
14500 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
14501
14502         * ada-lang.c (ada_to_fixed_value_create): Add handling of
14503         the case where VALUE_LVAL (val0) is not lval_memory.
14504
14505 2018-01-05  Xavier Roirand  <roirand@adacore.com>
14506
14507         * ada-valprint.c (print_optional_low_bound): Handle
14508         character-indexed array printing like boolean-indexed array
14509         printing.
14510
14511 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
14512
14513         * NEWS: Create a new section for the next release branch.
14514         Rename the section of the current branch, now that it has
14515         been cut.
14516
14517 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
14518
14519         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
14520         * version.in: Bump version to 8.1.50.DATE-git.
14521
14522 2018-01-03  Xavier Roirand  <roirand@adacore.com>
14523
14524         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
14525         Add field.
14526         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
14527         Add field.
14528         (default_exception_support_info) <catch_handlers_sym>: Add field.
14529         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
14530         (ada_exception_name_addr_1): Add "catch handlers" handling.
14531         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
14532         Update all callers.
14533         (create_excep_cond_exprs) <ex>: Add parameter.
14534         (re_set_exception): Update create_excep_cond_exprs call.
14535         (print_it_exception, print_one_exception, print_mention_exception)
14536         (print_recreate_exception): Add "catch handler" handling.
14537         (allocate_location_catch_handlers, re_set_catch_handlers)
14538         (check_status_catch_handlers, print_it_catch_handlers)
14539         (print_one_catch_handlers, print_mention_catch_handlers)
14540         (print_recreate_catch_handlers): New function.
14541         (catch_handlers_breakpoint_ops): New variable.
14542         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
14543         Add parameter.  Add "catch handler" handling.
14544         (ada_exception_sym_name, ada_exception_breakpoint_ops):
14545         Add "catch handler" handling.
14546         (ada_exception_catchpoint_cond_string): Add "catch handler"
14547         handling.
14548         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
14549         call.
14550         (catch_ada_handlers_command): New function.
14551         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
14552         operations structure.
14553         (_initialize_ada_language): Add "catch handlers" command entry.
14554         * NEWS: Document "catch handlers" feature.
14555
14556 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
14557
14558         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
14559         account when creating the array type of the slice.
14560         (ada_value_slice): Likewise.
14561
14562 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
14563
14564         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
14565         New enum value.
14566         (create_array_type_with_stride): Add byte_stride_prop parameter.
14567         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
14568         New parameter.  Update all callers in this file.
14569         (array_type_has_dynamic_stride): New function.
14570         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
14571         of arrays with dynamic byte strides.
14572         * dwarf2read.c (read_array_type): Add support for dynamic
14573         DW_AT_byte_stride attributes.
14574
14575 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
14576
14577         * dwarf2read.c (read_unspecified_type): Treat
14578         DW_TAG_enumeration_type DIEs from Ada units as stubs.
14579
14580 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
14581
14582         Update copyright year range in all GDB files.
14583
14584 2018-01-01, 18  Joel Brobecker  <brobecker@adacore.com>
14585
14586         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
14587         and gdb/testsuite/gdb.base/step-line.c.
14588
14589 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
14590
14591         * copyright.py (main): Dump the contents of
14592         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
14593         even if BY_HAND is empty.
14594
14595 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
14596
14597         * top.c (print_gdb_version): Update Copyright year in version
14598         message.
14599
14600 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
14601
14602         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
14603
14604 For older changes see ChangeLog-2017.
14605 \f
14606 Local Variables:
14607 mode: change-log
14608 left-margin: 8
14609 fill-column: 74
14610 version-control: never
14611 coding: utf-8
14612 End: