gdb/ChangeLog

   1 2019-06-14  Tom Tromey  <tromey@adacore.com>
   2
   3         * source.c (find_and_open_source): Respect basenames_may_differ.
   4
   5 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
   6
   7         * annotate.c (annotate_breakpoints_invalid): Make use of
   8         scoped_restore_terminal_state.
   9         (annotate_frames_invalid): Likewise.
  10
  11 2019-06-14  Tom Tromey  <tromey@adacore.com>
  12
  13         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
  14         allow assignment to an internalvar.
  15
  16 2019-06-14  Tom Tromey  <tromey@adacore.com>
  17
  18         * ada-lex.l: Allow "_" in attribute names.
  19
  20 2019-06-14  Tom Tromey  <tromey@adacore.com>
  21
  22         PR gdb/24653:
  23         * regcache.c (registers_changed): Don't call alloca.
  24         * top.c (execute_command): Don't call alloca.
  25
  26 2019-06-13  Pedro Alves  <palves@redhat.com>
  27
  28         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
  29         'expression'.  When parsing an expression, error out if there's
  30         junk after "unlimited".
  31         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  32         (do_set_command): Adjust calls to is_unlimited_literal.
  33
  34 2019-06-13  Pedro Alves  <palves@redhat.com>
  35
  36         * compile/compile.c (make_compile_options_def_group): Add braces
  37         around array_view initializer.
  38         * thread.c (make_thread_apply_all_options_def_group)
  39         (make_thread_apply_all_options_def_group): Likewise.
  40
  41 2019-06-13  Pedro Alves  <palves@redhat.com>
  42
  43         * NEWS (New commands): Mention "maint test-options
  44         require-delimiter", "maint test-options unknown-is-error", "maint
  45         test-options unknown-is-operand" and "maint show
  46         test-options-completion-result".
  47         (New command options, command completion): New section.
  48         (Completion improvements): New section.
  49         Mention that you can abbreviate "unlimited".
  50
  51 2019-06-13  Pedro Alves  <palves@redhat.com>
  52
  53         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
  54         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
  55         * unittests/cli-utils-selftests.c (test_parse_flags)
  56         (test_parse_flags_qcs): Delete.
  57         (test_cli_utils): Don't call deleted functions.
  58
  59 2019-06-13  Pedro Alves  <palves@redhat.com>
  60
  61         * thread.c: Include "cli/cli-option.h".
  62         (tp_array_compar_ascending): Global.
  63         (tp_array_compar): Delete function.
  64         (tp_array_compar_ascending, tp_array_compar_descending): New
  65         functions.
  66         (ascending_option_def, qcs_flag_option_def)
  67         (thr_qcs_flags_option_defs)
  68         (make_thread_apply_all_options_def_group)
  69         (make_thread_apply_options_def_group): New.
  70         (thread_apply_all_command): Use gdb::option::process_options.
  71         (thread_apply_command_completer)
  72         (thread_apply_all_command_completer): New.
  73         (thread_apply_command): Use gdb::option::process_options.
  74         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
  75         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
  76         to generate help text of "thread apply".  Adjust "taas"'s help.
  77         * tid-parse.c (tid_range_parser::in_thread_range): New method.
  78         * tid-parse.h (tid_range_parser::in_thread_range): New method.
  79
  80 2019-06-13  Pedro Alves  <palves@redhat.com>
  81
  82         * thread.c (thread_apply_command): Check for invalid TID with
  83         isdigit instead of !isalpha.
  84
  85 2019-06-13  Pedro Alves  <palves@redhat.com>
  86
  87         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
  88         (validate_flags_qcs): New.
  89         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
  90         (validate_flags_qcs): Declare.
  91         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
  92         (make_frame_apply_options_def_group): New.
  93         (frame_apply_command_count): Process options with
  94         gdb::option::process_options.
  95         (frame_apply_completer): New.
  96         (frame_apply_level_completer, frame_apply_all_completer)
  97         (frame_apply_completer): New.
  98         (_initialize_stack): Update help of "frame apply", "frame apply
  99         level", "frame apply all" and "faas" to mention supported options
 100         and install command completers.
 101         * stack.h (frame_apply_all_completer): Declare.
 102         * thread.c: Include "stack.h".
 103         (tfaas_command): Add "--".
 104         (_initialize_thread): Update help "tfaas" to mention supported
 105         options and install command completer.
 106
 107 2019-06-13  Pedro Alves  <palves@redhat.com>
 108
 109         * completer.c (complete_nested_command_line): New.
 110         (gdb_completion_word_break_characters_throw): Add assertion.
 111         * completer.h (complete_nested_command_line): Declare.
 112
 113 2019-06-13  Pedro Alves  <palves@redhat.com>
 114
 115         * stack.c (parse_backtrace_qualifiers): New.
 116         (backtrace_command): Use it.
 117         (backtrace_command_completer): Complete on qualifiers.
 118
 119 2019-06-13  Pedro Alves  <palves@redhat.com>
 120
 121         * frame.c: Include "cli/cli-option.h.
 122         (user_set_backtrace_options): New.
 123         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 124         Delete.
 125         (get_prev_frame): Adjust.
 126         (boolean_option_def, uinteger_option_def)
 127         (set_backtrace_option_defs): New.
 128         (_initialize_frame): Adjust and use
 129         gdb::option::add_setshow_cmds_for_options to install "set
 130         backtrace past-main" and "set backtrace past-entry".
 131         * frame.h: Include "cli/cli-option.h".
 132         (struct frame_print_options): Forward declare.
 133         (print_frame_arguments_all, print_frame_arguments_scalars)
 134         (print_frame_arguments_none): Declare.
 135         (print_entry_values): Delete declaration.
 136         (struct frame_print_options, user_frame_print_options): New.
 137         (struct set_backtrace_options): New.
 138         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 139         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 140         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 141         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 142         (list_args_or_locals): Add frame_print_options parameter.
 143         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 144         * python/py-framefilter.c (enumerate_args): Pass down
 145         USER_FRAME_PRINT_OPTIONS.
 146         * stack.c: Include "cli/cli-option.h".
 147         (print_frame_arguments_all, print_frame_arguments_scalars)
 148         (print_frame_arguments_none): Declare.
 149         (print_raw_frame_arguments, print_entry_values): Delete.
 150         (user_frame_print_options): New.
 151         (boolean_option_def, enum_option_def, frame_print_option_defs):
 152         New.
 153         (struct backtrace_cmd_options): New.
 154         (bt_flag_option_def): New.
 155         (backtrace_command_option_defs): New.
 156         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 157         (print_frame_arg, read_frame_arg, print_frame_args)
 158         (print_frame_info, print_frame): Add frame_print_options parameter
 159         and use it.
 160         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 161         (backtrace_command_1): Add frame_print_options and
 162         backtrace_cmd_options parameters and use them.
 163         (make_backtrace_options_def_group): New.
 164         (backtrace_command): Process command options with
 165         gdb::option::process_options.
 166         (backtrace_command_completer): New.
 167         (_initialize_stack): Extend "backtrace"'s help to mention
 168         supported options.  Install completer for "backtrace".
 169         Install some settings commands with add_setshow_cmds_for_options.
 170
 171 2019-06-13  Pedro Alves  <palves@redhat.com>
 172
 173         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 174         and that "set/show print raw frame-arguments" are now deprecated.
 175
 176         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 177         command.
 178         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 179         * stack.c (_initialize_stack): Install "set/show print
 180         raw-frame-arguments", and deprecate "set/show print raw
 181         frame-arguments".
 182         * valprint.c (_initialize_valprint): Deprecate "set/show print
 183         raw".
 184
 185 2019-06-13  Pedro Alves  <palves@redhat.com>
 186
 187         * compile/compile.c (struct compile_options): New.
 188         (compile_flag_option_def, compile_command_option_defs)
 189         (make_compile_options_def_group): New.
 190         (compile_file_command): Handle options with
 191         gdb::option::process_options.
 192         (compile_file_command_completer): New function.
 193         (compile_code_command): Handle options with
 194         gdb::option::process_options.
 195         (compile_code_command_completer): New function.
 196         (_initialize_compiler): Install completers for "compile code" and
 197         "compile file".  Mention available options in "compile code" and
 198         "compile code"'s help.
 199         * completer.c (advance_to_completion_word): New, factored out from
 200         ...
 201         (advance_to_expression_complete_word_point): ... this.
 202         (advance_to_filename_complete_word_point): New.
 203         * completer.h (advance_to_filename_complete_word_point): New
 204         declaration.
 205
 206 2019-06-13  Pedro Alves  <palves@redhat.com>
 207
 208         * compile/compile.c: Include "cli/cli-option.h".
 209         (compile_print_value): Scope data pointer is now a
 210         value_print_options pointer; adjust.
 211         (compile_print_command): Process options.  Scope data pointer is
 212         now a value_print_options pointer; adjust.
 213         (_initialize_compile): Update "compile print"'s help to include
 214         supported options.  Install a completer for "compile print".
 215         * cp-valprint.c (show_vtblprint, show_objectprint)
 216         (show_static_field_print): Delete.
 217         (_initialize_cp_valprint): Don't install "set print
 218         static-members", "set print vtbl", "set print object" here.
 219         * printcmd.c: Include "cli/cli-option.h" and
 220         "common/gdb_optional.h".
 221         (print_command_parse_format): Rework to fill in a
 222         value_print_options instead of a format_data.
 223         (print_value): Change parameter type from format_data pointer to
 224         value_print_options reference.  Adjust.
 225         (print_command_1): Process options.  Adjust to pass down a
 226         value_print_options.
 227         (print_command_completer): New.
 228         (_initialize_printcmd): Install print_command_completer as
 229         handle_brkchars completer for the "print" command.  Update
 230         "print"'s help to include supported options.
 231         * valprint.c: Include "cli/cli-option.h".
 232         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 233         here from cp-valprint.c.
 234         (boolean_option_def, uinteger_option_def)
 235         (value_print_option_defs, make_value_print_options_def_group):
 236         New.  Use gdb::option::add_setshow_cmds_for_options to install
 237         "set print elements", "set print null-stop", "set print repeats",
 238         "set print pretty", "set print union", "set print array", "set
 239         print address", "set print symbol", "set print array-indexes".
 240         * valprint.h: Include <string> and "cli/cli-option.h".
 241         (make_value_print_options_def_group): Declare.
 242         (print_value): Change parameter type from format_data pointer to
 243         value_print_options reference.
 244         (print_command_completer): Declare.
 245
 246 2019-06-13  Pedro Alves  <palves@redhat.com>
 247
 248         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 249         (COMMON_SFILES): Add maint-test-settings.c.
 250         * cli/cli-decode.c (boolean_enums): New global, factored out from
 251         ...
 252         (add_setshow_boolean_cmd): ... here.
 253         * cli/cli-decode.h (boolean_enums): Declare.
 254         * cli/cli-option.c: New file.
 255         * cli/cli-option.h: New file.
 256         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 257         factored out from ...
 258         (parse_cli_boolean_value(const char *)): ... this.
 259         (is_unlimited_literal): Change parameter type to pointer to
 260         pointer.  Adjust and advance ARG pointer.
 261         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 262         (parse_cli_var_enum): New, factored out from ...
 263         (do_set_command): ... this.  Adjust.
 264         * cli/cli-setshow.h (parse_cli_boolean_value)
 265         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 266         (parse_cli_var_enum): Declare.
 267         * cli/cli-utils.c: Include "cli/cli-option.h".
 268         (get_ulongest): New.
 269         * cli/cli-utils.h (get_ulongest): Declare.
 270         (check_for_argument): New overloads.
 271         * maint-test-options.c: New file.
 272
 273 2019-06-13  Pedro Alves  <palves@redhat.com>
 274
 275         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 276         parse a range if "-" is at the end of the string.
 277
 278 2019-06-13  Pedro Alves  <palves@redhat.com>
 279
 280         * cli/cli-setshow.c (parse_auto_binary_operation)
 281         (parse_cli_boolean_value): Don't allow "o".
 282
 283 2019-06-13  Pedro Alves  <palves@redhat.com>
 284
 285         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 286         * NEWS: Mention maint test-settings KIND.
 287         * maint-test-settings.c: New file.
 288
 289 2019-06-13  Pedro Alves  <palves@redhat.com>
 290
 291         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 292         completer.
 293         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 294         "set" completers.
 295
 296 2019-06-13  Pedro Alves  <palves@redhat.com>
 297
 298         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 299         after item.
 300
 301 2019-06-13  Pedro Alves  <palves@redhat.com>
 302
 303         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 304
 305 2019-06-13  Pedro Alves <palves@redhat.com>
 306
 307         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 308         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 309         call.
 310         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 311         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 312         calls.
 313         (check_for_argument): Skip spaces after argument.
 314
 315 2019-06-13  Pedro Alves  <palves@redhat.com>
 316
 317         * thread.c (thread_apply_command): Adjust TID parsing.
 318         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 319         detected before end of string.
 320         (tid_is_in_list): Error out if LIST is invalid.
 321
 322 2019-06-13  Pedro Alves  <palves@redhat.com>
 323
 324         * completer.c (complete_line_internal_1): Rewind completion word
 325         point.
 326         (completion_tracker::advance_custom_word_point_by): Change
 327         parameter type to int.
 328         * completer.h (completion_tracker::advance_custom_word_point_by):
 329         Likewise.
 330
 331 2019-06-13  Pedro Alves  <palves@redhat.com>
 332
 333         * completer.c (advance_to_completion_word): Handle delimiters.
 334
 335 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 336
 337         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 338
 339 2019-06-11  Tom Tromey  <tom@tromey.com>
 340
 341         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 342         (xmalloc_failed): Move to alloc.c.
 343         * alloc.c: New file.
 344         * Makefile.in (COMMON_SFILES): Add alloc.c.
 345
 346 2019-06-11  Tom Tromey  <tom@tromey.com>
 347
 348         * nat/linux-waitpid.c: Don't include server.h.
 349         (linux_debug): Remove.
 350         (my_waitpid): Update.
 351
 352 2019-06-11  Tom Tromey  <tromey@adacore.com>
 353
 354         * infcall.c (_initialize_infcall): Remove trailing newline from
 355         help.
 356         * user-regs.c (_initialize_user_regs): Remove trailing newline
 357         from help.
 358         * typeprint.c (_initialize_typeprint): Remove trailing newline
 359         from help.
 360         * reverse.c (_initialize_reverse): Remove trailing newlines from
 361         help.
 362         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 363         from help.
 364         * language.c (add_set_language_command): Remove trailing newline
 365         from help.
 366         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 367         help.
 368         * disasm.c (_initialize_disasm): Remove trailing newline from
 369         help.
 370         * top.c (init_main): Remove trailing newline from help.
 371         * interps.c (_initialize_interpreter): Remove trailing newline
 372         from help.
 373         * btrace.c (_initialize_btrace): Remove trailing newlines from
 374         help.
 375         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 376         from help.
 377         * python/python.c (_initialize_python): Remove trailing newline
 378         from help.
 379         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 380         help.
 381         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 382         from help.  Reformat some text.
 383         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 384         from help.
 385         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 386         newline from help.
 387
 388 2019-06-11  Tom Tromey  <tromey@adacore.com>
 389
 390         * darwin-nat.c (darwin_decode_exception_message)
 391         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 392
 393 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 394
 395         * valops.c (value_slice): Check for not allocated or not
 396         associated values.
 397
 398 2019-06-10  Tom de Vries  <tdevries@suse.de>
 399
 400         PR gdb/24618
 401         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 402         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 403         invalid.
 404
 405 2019-06-10  Tom de Vries  <tdevries@suse.de>
 406
 407         PR gdb/24611
 408         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 409         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 410
 411 2019-06-10  Tom de Vries  <tdevries@suse.de>
 412
 413         PR symtab/24545
 414         * symtab.c (struct demangled_name_entry): Add language field.
 415         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 416         static minimal symbol".  Set and use language field.
 417
 418 2019-06-10  Tom Tromey  <tromey@adacore.com>
 419
 420         * ada-lang.c (_initialize_ada_language): Update help text.
 421
 422 2019-06-10  Tom Tromey  <tromey@adacore.com>
 423
 424         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 425         with a newline.
 426         * guile/guile.c (handle_boot_error): Don't end warning with a
 427         newline.
 428         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 429         warning with a newline.
 430         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 431         newline.
 432         (s12z_frame_cache): Likewise.
 433         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 434         a newline.
 435         * solib-svr4.c (disable_probes_interface): Don't end warning with
 436         a newline.
 437         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 438         newline.
 439         * python/python.c (do_finish_initialization): Don't end warning
 440         with a newline.
 441
 442 2019-06-10  Tom Tromey  <tom@tromey.com>
 443
 444         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 445         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 446         gdbpy_enter.
 447
 448 2019-06-10  Tom Tromey  <tromey@adacore.com>
 449
 450         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 451         data.
 452         (elf_new_init): Don't call stabsread_new_init.
 453         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 454         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 455         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 456
 457 2019-06-10  Tom de Vries  <tdevries@suse.de>
 458
 459         PR symtab/16264
 460         PR symtab/24517
 461         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 462
 463 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 464
 465         * source.c (find_and_open_source): Also rewrite relative file
 466         names.
 467
 468 2019-04-26  Amos Bird  <amosbird@gmail.com>
 469
 470         * annotate.c (annotate_thread_exited): Add "thread-exited"
 471         annotation.
 472
 473 2019-06-06  Tom Tromey  <tromey@adacore.com>
 474
 475         * maint.h (class scoped_command_stats): Use
 476         DISABLE_COPY_AND_ASSIGN.
 477         <print_time>: New method.
 478         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 479         print_time.
 480         (scoped_command_stats::print_time): New method.
 481
 482 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 483
 484         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 485         instructions of lengths 6 or 8 bytes.
 486
 487 2019-06-04  Pedro Alves  <palves@redhat.com>
 488
 489         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 490
 491         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 492         * breakpoint.c (condition_completer): Likewise.
 493         * cli/cli-dump.c (scan_expression): Likewise.
 494         * common/filestuff.c (mkdir_recursive): Likewise.
 495         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 496         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 497         (gdb_abspath): Likewise.
 498         * compile/compile-cplus-types.c
 499         (compile_cplus_instance::decl_name): Likewise.
 500         * completer.c (complete_explicit_location):
 501         (signal_completer, reg_or_group_completer_1): Likewise.
 502         * cp-support.c (cp_remove_params_if_any): Likewise.
 503         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 504         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 505         * infcmd.c (strip_bg_char): Likewise.
 506         * linespec.c (copy_token_string): Likewise.
 507         * mi/mi-main.c (output_cores): Likewise.
 508         * psymtab.c (psymtab_search_name):
 509         * symfile.c (test_set_ext_lang_command): Likewise.
 510         * target.c (target_fileio_read_stralloc): Likewise.
 511         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 512         * value.c (complete_internalvar): Likewise.
 513
 514 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 515
 516         Add objfile property to gdb.Type.
 517         * NEWS: Mention Python API addition.
 518         * python/py-type.c (typy_get_objfile): New method.
 519
 520 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 521
 522         * NEWS: Mention the new set|show style [title|highlight].
 523         Mention changes to "show style", "help" and "apropos".
 524
 525 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 526
 527         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 528         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 529         instead of print_help_for_command.
 530         (print_doc_of_command): New function.
 531         (help_list): Add 'apropos -v word' suggestion.
 532         (print_help_for_command): Style the command name using title style.
 533         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 534         (_initialize_cli_cmds): Describe -v in apropos_command help.
 535
 536 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 537
 538         * cli/cli-style.h (cli_style_option): Add name in constructor,
 539         add m_name class member, add constructor with intensity,
 540         add name class function.
 541         (cli_style_option::add_setshow_commands): Remove name argument.
 542         (highlight_style, title_style): New styles.
 543         * cli/cli-style.c (do_show): New function that shows a style
 544         characteristic styling the style name with itself.
 545         (set_style_name): New function.
 546         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 547         Update all callers according to the changes in cli/cli-style.h.
 548         * utils.h (fputs_highlighted): New function.
 549         * utils.c (fputs_highlighted): Likewise.
 550
 551 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 552
 553         * NEWS: Mention new pipe command and new convenience variables.
 554
 555 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 556
 557         * cli/cli-cmds.c (pipe_command): New function.
 558         (_initialize_cli_cmds): Call add_com for pipe_command.
 559         Define | as an alias for pipe.
 560         (exit_status_set_internal_vars): New function.
 561         (shell_escape): Call exit_status_set_internal_vars.
 562         cli/cli-decode.c (find_command_name_length): Recognize | as
 563         a single character command.
 564
 565 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 566
 567         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 568         top.c (execute_command_to_ui_file): New function, mostly a copy
 569         of execute_command_to_string.
 570         (execute_command_to_string): Implement by calling
 571         execute_command_to_ui_file.
 572
 573 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 574
 575         * top.h (saved_command_line): Remove declaration.
 576         * top.c (previous_saved_command_line, previous_repeat_arguments):
 577         New variables.
 578         (saved_command_line): Make static, define together with other
 579         'repeat variables'.
 580         (dont_repeat): Clear repeat_arguments.
 581         (repeat_previous, get_saved_command_line, save_command_line):
 582         New functions.
 583         (gdb_init): Initialize saved_command_line
 584         and previous_saved_command_line.
 585         * main.c (captured_main_1): Remove saved_command_line initialization.
 586         * event-top.c (handle_line_of_input): Update to use
 587         the new 'repeat' related functions instead of direct access to
 588         saved_command_line.
 589         * command.h (repeat_previous, get_saved_command_line,
 590         save_command_line): New declarations.
 591         (dont_repeat): Add comment.
 592
 593 2019-05-30  Tom Tromey  <tromey@adacore.com>
 594
 595         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 596         Fix comment.
 597         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 598
 599 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 600
 601         PR cli/24587
 602         * completer.c (complete): Initialize variable word.
 603
 604 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 605
 606         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 607         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 608         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 609         'body' is NULL to the outter 'if', protecting the '!is_define'
 610         situation as well.
 611
 612 2019-05-29  Tom Tromey  <tromey@adacore.com>
 613
 614         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 615         (dwarf_unknown): New function.
 616         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 617         (dwarf_type_encoding_name): Use dwarf_unknown.
 618
 619 2019-05-29  Tom Tromey  <tromey@adacore.com>
 620
 621         PR c++/20020:
 622         * cp-valprint.c (cp_print_value_fields): Call
 623         cp_print_static_field inside "try".
 624
 625 2019-05-29  Tom Tromey  <tromey@adacore.com>
 626
 627         * inflow.c (struct terminal_info): Add default operator=.
 628         * configure: Rebuild.
 629         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 630         -Wdeprecated-copy-dtor, -Wredundant-move.
 631
 632 2019-05-29  Tom Tromey  <tromey@adacore.com>
 633
 634         * NEWS: Add entry.
 635         * infcmd.c (print_return_value_1): Handle finish_print
 636         option.
 637         (show_print_finish): New function.
 638         (_initialize_infcmd): Add "set/show print finish" commands.
 639         * valprint.c (user_print_options): Initialize new member.
 640         * valprint.h (struct value_print_options) <finish_print>: New
 641         member.
 642
 643 2019-05-28  Tom Tromey  <tromey@adacore.com>
 644
 645         * ada-lang.c (ada_remove_Xbn_suffix)
 646         (find_old_style_renaming_symbol)
 647         (parse_old_style_renaming): Remove.
 648         (ada_find_renaming_symbol): Don't call
 649         find_old_style_renaming_symbol.
 650         (ada_is_renaming_symbol): Rename from
 651         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 652         bool.  Now static.
 653         (ada_read_var_value): Update and simplify.
 654         * ada-exp.y (write_var_or_type): Remove old code.
 655
 656 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 657
 658         * event-top.c: Remove include comment.
 659         * inflow.c (class scoped_ignore_sigttou): Move from here...
 660         * inflow.h (class scoped_ignore_sigttou): ...to here.
 661         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 662         * top.c:  Remove include comment.
 663
 664 2019-05-27  Tom Tromey  <tom@tromey.com>
 665
 666         * NEWS: Fix typo.
 667
 668 2019-05-22  Tom Tromey  <tromey@adacore.com>
 669
 670         * target.c (target_follow_exec): Constify parameter.
 671         * target-delegates.c: Rebuild.
 672         * remote.c (remote_target::follow_exec): Constify parameter.
 673         * infrun.c (follow_exec): Constify parameter.
 674         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 675         (target_follow_exec): Likewise.
 676
 677 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 678
 679         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 680         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 681
 682 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 683
 684         * NEWS: Add debugredirect and testsuite sections.
 685
 686 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 687
 688         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 689         target descriptions using exclusively floating point register name
 690         aliases.
 691
 692 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 693
 694         PR gdb/18644:
 695         * f-lang.c (build_fortran_types): Handle the case where
 696         gdbarch_floatformat_for_type returns a nullptr.
 697
 698 2019-05-21  Tom de Vries  <tdevries@suse.de>
 699
 700         PR cli/24587
 701         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 702
 703 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 704
 705         PR gdb/18644:
 706         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 707         16-byte floats.
 708         * i386-tdep.c (i386_floatformat_for_type): Use
 709         floatformats_ia64_quad for the 16-byte floating point component
 710         within a fortran 32-byte complex number.
 711
 712 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 715         delete default constructor.
 716         (find_partial_die): Update to return const struct.
 717         (partial_die_parent_scope): Move variable declaration into scope
 718         of its use and change its type to auto.
 719         (guess_partial_die_structure_name): Likewise.
 720         (partial_die_info::fixup): Likewise.
 721
 722 2019-05-17  Tom Tromey  <tromey@adacore.com>
 723
 724         * source.c (find_and_open_source): Remove cast.
 725
 726 2019-05-17  Tom Tromey  <tromey@adacore.com>
 727
 728         * annotate.c (annotate_source): Make "filename" const.
 729         * annotate.h (annotate_source): Use const.
 730
 731 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 732
 733         * disasm.c (set_disassembler_options): Send errors to stderr.
 734
 735 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 736
 737         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 738         (cli_interp_base::set_logging): Check debug_redirect.
 739         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 740         * cli/cli-logging.c (debug_redirect): Add static variable.
 741         (pop_output_files): Add default param.
 742         (handle_redirections): Print debug setting.
 743         (show_logging_command): Likewise.
 744         (_initialize_cli_logging): Add debugredirect command.
 745         * interps.c (current_interp_set_logging): Add debug_redirect
 746         parameter.
 747         * interps.h (set_logging): Add debug_redirect parameter.
 748         (current_interp_set_logging): Likewise.
 749         * mi/mi-common.h: Likewise.
 750         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 751
 752 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 753             Tom Tromey  <tromey@adacore.com>
 754
 755         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 756         directly.
 757         * cli/cli-interp.h (make_logging_output): Remove declaration.
 758         * cli/cli-logging.c (make_logging_output): Remove function.
 759         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 760         directly.
 761         * ui-file.c (tee_file::tee_file): Remove bools.
 762         (tee_file::~tee_file): Remove deletes.
 763         * ui-file.h (tee_file): Remove bools.
 764
 765 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 766
 767         * mi/mi-cmds.h (mi_cmd_complete): New function.
 768         * mi/mi-main.c (mi_cmd_complete): Likewise.
 769         * mi/mi-cmds.c: Define new MI command -complete.
 770         * NEWS: Mention new -complete command.
 771
 772 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 773
 774         * completer.h (complete): New function.
 775         * completer.c (complete): Likewise.
 776         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 777         function defined in completer.h.
 778
 779 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 780
 781        * MAINTAINERS (Write After Approval): Add myself.
 782
 783 2019-05-17  Tom de Vries  <tdevries@suse.de>
 784
 785         PR gdb/24094
 786         * dwarf2read.c (struct cu_partial_die_info): New struct.
 787         (find_partial_die): Return cu_partial_die_info.
 788         (partial_die_parent_scope, guess_partial_die_structure_name)
 789         (partial_die_info::fixup): Handle new return type of find_partial_die.
 790
 791 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 792
 793         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 794         "std::string", simplifying the algorithm.
 795
 796 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 797
 798         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 799         (stap_static_probe_ops::get_probes): Likewise.
 800
 801 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 802
 803         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 804         '-')" and "else if".
 805         (stap_parse_single_operand): Join checks for
 806         "gdbarch_stap_parse_special_token_p" and
 807         "gdbarch_stap_parse_special_token" in the same "if" statement.
 808         Invert check when verifying for operation on register
 809         displacement.
 810
 811 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 812
 813         * stap-probe.c (stap_get_opcode): Update comment.
 814         (stap_get_expected_argument_type): Likewise.
 815         (handle_stap_probe): Likewise.
 816
 817 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 818
 819         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 820         return type to 'bool'.  Adjust comment.  Use 'bool' when
 821         appropriate.
 822         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 823         * stap-probe.c (stap_parse_argument_1): Likewise.
 824         (stap_is_operator): Likewise.
 825         (stap_is_generic_prefix): Likewise.
 826         (stap_is_register_prefix): Likewise.
 827         (stap_is_register_indirection_prefix): Likewise.
 828         (stap_is_integer_prefix): Likewise.
 829         (stap_generic_check_suffix): Likewise.
 830         (stap_check_integer_suffix): Likewise.
 831         (stap_check_register_suffix): Likewise.
 832         (stap_check_register_indirection_suffix): Likewise.
 833         (stap_parse_register_operand): Likewise.
 834         (stap_parse_single_operand): Likewise.
 835         (stap_parse_argument_1): Likewise.
 836         (stap_probe::get_argument_count): Likewise.
 837         (stap_is_operator): Likewise.
 838
 839 2019-05-16  Tom Tromey  <tromey@adacore.com>
 840
 841         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 842         keyword to foreach.
 843
 844 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 845
 846         * linux-thread-db.c (try_thread_db_load_1): Change return type
 847         to bool.
 848         (try_thread_db_load): Likewise.
 849         (try_thread_db_load_from_pdir_1): Likewise.
 850         (try_thread_db_load_from_pdir): Likewise.
 851         (try_thread_db_load_from_sdir): Likewise.
 852         (try_thread_db_load_from_dir): Likewise.
 853         (thread_db_load_search): Likewise.
 854         (has_libpthread): Likewise.
 855         (thread_db_load): Likewise.
 856
 857 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 858
 859         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 860         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 861         NULL, and complain/return if that's the case.
 862
 863 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 864
 865         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 866         (advance, posn, abstract_read_memory): New functions.
 867         [struct mem_read_abstraction]: New struct.
 868         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 869
 870 2019-05-14  Tom Tromey  <tromey@adacore.com>
 871
 872         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 873         value is not lval_memory.
 874
 875 2019-05-14  Tom Tromey  <tromey@adacore.com>
 876
 877         * solib.c (info_sharedlibrary_command): Style the file name.
 878
 879 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 880
 881         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 882         (aarch64_vnv_type): Likewise.
 883         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 884         * common/tdesc.c: Likewise.
 885         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 886         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 887         * features/aarch64-fpu.xml: Add ieee half view.
 888         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 889         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 890         * gdbtypes.h (struct builtin_type): Likewise.
 891         (struct objfile_type): Likewise.
 892
 893 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 894
 895         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 896         typo.
 897         * location.h (string_to_event_location): Likewise.
 898
 899 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 900
 901         GDB 8.3 released.
 902
 903 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 904
 905         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 906         New variable declaration.
 907         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 908         New variable.
 909         (print_one_breakpoint): Use ui_out::test_flags and new global
 910         variable to compute use_fixed_output.
 911         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 912         Remove.
 913         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 914         (mi_multi_location_breakpoint_output_fixed): Remove.
 915         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 916         new variable.
 917         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 918         fix_multi_location_breakpoint_output flag if version >= 3.
 919         * ui-out.h (enum ui_out_flag)
 920         <fix_multi_location_breakpoint_output>: New enumerator.
 921
 922 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 923
 924         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 925
 926 2019-05-10  Tom Tromey  <tromey@adacore.com>
 927
 928         * ada-lang.c (catch_ada_completer): New function.
 929         (_initialize_ada_language): Use it.
 930
 931 2019-05-10  Tom Tromey  <tromey@adacore.com>
 932
 933         * thread.c (print_thread_info): Make "requested_threads" const.
 934         * gdbthread.h (print_thread_info): Make "requested_threads"
 935         const.
 936         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 937         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 938
 939 2019-05-08  Tom Tromey  <tom@tromey.com>
 940
 941         * gdbtypes.c (objfile_type_data): Change type.
 942         (objfile_type, _initialize_gdbtypes): Update.
 943
 944 2019-05-08  Tom Tromey  <tom@tromey.com>
 945
 946         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 947         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 948         (_initialize_dwarf2_frame): Update.
 949
 950 2019-05-08  Tom Tromey  <tom@tromey.com>
 951
 952         * objc-lang.c (objc_objfile_data): Change type.
 953         (find_methods): Update.
 954         (_initialize_objc_lang): Remove.
 955
 956 2019-05-08  Tom Tromey  <tom@tromey.com>
 957
 958         * stabsread.c (rs6000_builtin_type_data): Change type.
 959         (rs6000_builtin_type, _initialize_stabsread): Update.
 960
 961 2019-05-08  Tom Tromey  <tom@tromey.com>
 962
 963         * mips-tdep.c (mips_pdr_data): Remove.
 964         (_initialize_mips_tdep): Update.
 965
 966 2019-05-08  Tom Tromey  <tom@tromey.com>
 967
 968         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 969         (hppa_init_objfile_priv_data, read_unwind_info)
 970         (find_unwind_entry, _initialize_hppa_tdep): Update.
 971
 972 2019-05-08  Tom Tromey  <tom@tromey.com>
 973
 974         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 975         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 976         on obstack.
 977         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 978
 979 2019-05-08  Tom Tromey  <tom@tromey.com>
 980
 981         * mdebugread.c (basic_type_data): Change type.
 982         (basic_type, _initialize_mdebugread): Update.
 983
 984 2019-05-08  Tom Tromey  <tom@tromey.com>
 985
 986         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 987
 988 2019-05-08  Tom Tromey  <tom@tromey.com>
 989
 990         * nto-tdep.c (nto_inferior_data_reg): Change type.
 991         (nto_inferior_data): Update.
 992         (nto_inferior_data_cleanup, nto_new_inferior_data)
 993         (_initialize_nto_tdep): Remove.
 994         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 995
 996 2019-05-08  Tom Tromey  <tom@tromey.com>
 997
 998         * ada-lang.c (struct ada_inferior_data): Add initializers.
 999         (ada_inferior_data): Change type.
1000         (ada_inferior_data_cleanup): Remove.
1001         (get_ada_inferior_data, ada_inferior_exit)
1002         (struct ada_pspace_data): Add initializers, destructor.
1003         (ada_pspace_data_handle): Change type.
1004         (get_ada_pspace_data): Update.
1005         (ada_pspace_data_cleanup): Remove.
1006
1007 2019-05-08  Tom Tromey  <tom@tromey.com>
1008
1009         * coffread.c (struct coff_symfile_info): Add initializers.
1010         (coff_objfile_data_key): Move lower.  Change type.
1011         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1012         Update.
1013         (coff_free_info): Remove.
1014
1015 2019-05-08  Tom Tromey  <tom@tromey.com>
1016
1017         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1018         (fbsd_pspace_data_handle): Move lower.  Change type.
1019         (get_fbsd_pspace_data): Update.
1020         (fbsd_pspace_data_cleanup): Remove.
1021         (_initialize_fbsd_tdep): Update.
1022
1023 2019-05-08  Tom Tromey  <tom@tromey.com>
1024
1025         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1026         (get_ada_tasks_pspace_data): Update.
1027         (ada_tasks_pspace_data_cleanup): Remove.
1028         (_initialize_tasks): Update.
1029         (ada_tasks_inferior_data_handle): Change type.
1030         (get_ada_tasks_inferior_data): Update.
1031         (ada_tasks_inferior_data_cleanup): Remove.
1032         (struct ada_tasks_pspace_data): Add initializers.
1033
1034 2019-05-08  Tom Tromey  <tom@tromey.com>
1035
1036         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1037         * symfile-debug.c (debug_sym_get_probes): Change type.
1038         * stap-probe.c (handle_stap_probe):
1039         (stap_static_probe_ops::get_probes): Change type.
1040         * probe.h (class static_probe_ops) <get_probes>: Change type.
1041         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1042         (parse_probes_in_pspace): Update.
1043         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1044         Update.
1045         (any_static_probe_ops::get_probes): Change type.
1046         * elfread.c (elfread_data): New typedef.
1047         (probe_key): Change type.
1048         (elf_get_probes): Likewise.  Update.
1049         (probe_key_free): Remove.
1050         (_initialize_elfread): Update.
1051         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1052         Change type.
1053         (dtrace_process_dof_probe, dtrace_process_dof)
1054         (dtrace_static_probe_ops::get_probe): Change type.
1055
1056 2019-05-08  Tom Tromey  <tom@tromey.com>
1057
1058         * xcoffread.c (struct xcoff_symfile_info): Rename from
1059         coff_symfile_info.  Add initializers.
1060         (xcoff_objfile_data_key): Move lower.  Change type.
1061         (XCOFF_DATA): Rewrite.
1062         (xcoff_free_info): Remove.
1063         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1064         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1065         (xcoff_initial_scan): Update.
1066
1067 2019-05-08  Tom Tromey  <tom@tromey.com>
1068
1069         * solib-svr4.c (struct svr4_info): Add initializers and
1070         destructor.
1071         <probes_table>: Now an htab_up.
1072         (solib_svr4_pspace_data): Change type.
1073         (free_probes_table): Simplify.
1074         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1075         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1076         (probes_table_remove_objfile_probes, register_solib_event_probe)
1077         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1078         (_initialize_svr4_solib): Update.
1079
1080 2019-05-08  Tom Tromey  <tom@tromey.com>
1081
1082         * remote.c (remote_pspace_data): Change type.
1083         (remote_pspace_data_cleanup): Remove.
1084         (get_remote_exec_file, set_pspace_remote_exec_file)
1085         (_initialize_remote): Update.
1086
1087 2019-05-08  Tom Tromey  <tom@tromey.com>
1088
1089         * breakpoint.c (breakpoint_objfile_key): Change type.
1090         (get_breakpoint_objfile_data): Update.
1091         (free_breakpoint_objfile_data): Remove.
1092         (_initialize_breakpoint): Update.
1093
1094 2019-05-08  Tom Tromey  <tom@tromey.com>
1095
1096         * linux-tdep.c (struct linux_info): Add initializers.
1097         (linux_inferior_data): Move.  Change type.
1098         (invalidate_linux_cache_inf): Update.
1099         (linux_inferior_data_cleanup): Remove.
1100         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1101
1102 2019-05-08  Tom Tromey  <tom@tromey.com>
1103
1104         * auxv.c (auxv_inferior_data): Move.  Change type.
1105         (auxv_inferior_data_cleanup): Remove.
1106         (invalidate_auxv_cache_inf): Rewrite.
1107         (get_auxv_inferior_data, _initialize_auxv): Update.
1108
1109 2019-05-08  Tom Tromey  <tom@tromey.com>
1110
1111         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1112         (symfile_debug_objfile_data_key): Change type.
1113         (symfile_debug_installed, debug_qf_has_symbols)
1114         (debug_qf_find_last_source_symtab)
1115         (debug_qf_forget_cached_source_info)
1116         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1117         (debug_qf_print_stats, debug_qf_dump)
1118         (debug_qf_expand_symtabs_for_function)
1119         (debug_qf_expand_all_symtabs)
1120         (debug_qf_expand_symtabs_with_fullname)
1121         (debug_qf_map_matching_symbols)
1122         (debug_qf_expand_symtabs_matching)
1123         (debug_qf_find_pc_sect_compunit_symtab)
1124         (debug_qf_map_symbol_filenames)
1125         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1126         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1127         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1128         (debug_sym_read_linetable, debug_sym_relocate): Update.
1129         (symfile_debug_free_objfile): Remove.
1130         (install_symfile_debug_logging, _initialize_symfile_debug):
1131         Update.
1132
1133 2019-05-08  Tom Tromey  <tom@tromey.com>
1134
1135         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1136         allocate_on_obstack.
1137         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1138         (get_dwarf2_per_objfile): Update.
1139         (set_dwarf2_per_objfile): Remove.
1140         (dwarf2_has_info, dwarf2_get_section_info): Update.
1141         (dwarf2_free_objfile): Remove.
1142         (_initialize_dwarf2_read): Update.
1143
1144 2019-05-08  Tom Tromey  <tom@tromey.com>
1145
1146         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1147         initializers.
1148         <unsupported_script_warning_printed,
1149         script_not_found_warning_printed>: Now bool.
1150         (auto_load_pspace_data): Change type.
1151         (~auto_load_pspace_info): Rename from
1152         auto_load_pspace_data_cleanup.
1153         (get_auto_load_pspace_data, init_loaded_scripts_info)
1154         (clear_section_scripts, maybe_print_unsupported_script_warning)
1155         (maybe_print_script_not_found_warning, _initialize_auto_load):
1156         Update.
1157
1158 2019-05-08  Tom Tromey  <tom@tromey.com>
1159
1160         * objfiles.c (objfile_pspace_info): Add destructor and
1161         initializers.
1162         (objfiles_pspace_data): Change type.
1163         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1164         (get_objfile_pspace_data): Update.
1165         (objfiles_bfd_data): Change type.
1166         (get_objfile_bfd_data): Update.
1167         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1168
1169 2019-05-08  Tom Tromey  <tom@tromey.com>
1170
1171         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1172         Change type.
1173         (get_catch_syscall_inferior_data): Update.
1174         (catch_syscall_inferior_data_cleanup): Remove.
1175         (_initialize_break_catch_syscall): Update.
1176
1177 2019-05-08  Tom Tromey  <tom@tromey.com>
1178
1179         * inflow.c (struct terminal_info): Add destructor and
1180         initializers.
1181         (inflow_inferior_data): Change type.
1182         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1183         (get_inflow_inferior_data, inflow_inferior_exit)
1184         (swap_terminal_info, _initialize_inflow): Update.
1185
1186 2019-05-08  Tom Tromey  <tom@tromey.com>
1187
1188         * target-dcache.c (target_dcache_cleanup): Remove.
1189         (target_dcache_aspace_key): Change type.
1190         (target_dcache_init_p, target_dcache_invalidate)
1191         (target_dcache_get, target_dcache_get_or_init)
1192         (_initialize_target_dcache): Update.
1193         * dcache.h (struct dcache_deleter): New.
1194
1195 2019-05-08  Tom Tromey  <tom@tromey.com>
1196
1197         * symtab.c (struct symbol_cache): Add destructor and
1198         initializers.
1199         (symbol_cache_key): Move.  Change type.
1200         (make_symbol_cache, free_symbol_cache): Remove.
1201         (get_symbol_cache): Update.
1202         (symbol_cache_cleanup): Remove.
1203         (ALL_PSPACES, symbol_cache_flush)
1204         (maintenance_print_symbol_cache)
1205         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1206         Update.
1207
1208 2019-05-08  Tom Tromey  <tom@tromey.com>
1209
1210         * symtab.c (struct main_info): Add destructor and initializers.
1211         (main_progspace_key): Move.  Change type.
1212         (get_main_info): Update.
1213         (main_info_cleanup): Remove.
1214         (_initialize_symtab): Update.
1215
1216 2019-05-08  Tom Tromey  <tom@tromey.com>
1217
1218         * registry.h (DECLARE_REGISTRY): Define the _key class.
1219
1220 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * NEWS: Merge two 'New commands' sections.
1223
1224 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1225
1226         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1227         parameter and use Ada language definition instead.
1228         (ada_val_print_ptr): Remove unused language parameter.
1229         (ada_val_print_num): Remove language parameter and use Ada language
1230         definition instead.
1231         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1232         parameter.
1233         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1234         parameter and use Ada language definition instead.
1235         (ada_val_print_1): Update all ada_val_print_xxx calls.
1236         Remove language parameter.
1237         (ada_val_print): Update ada_val_print_1 call.
1238
1239 2019-05-08  Tom Tromey  <tromey@adacore.com>
1240
1241         * remote.c (remote_hw_watchpoint_limit)
1242         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1243         Now static.
1244
1245 2019-05-08  Tom Tromey  <tromey@adacore.com>
1246
1247         * maint.c (_initialize_maint_cmds): Move initialization code to
1248         remote.c.
1249         (watchdog, show_watchdog): Move to remote.c.
1250         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1251         "watchdog" static.
1252         (_initialize_remote): Move initialization code from maint.c.
1253         * defs.h (watchdog): Don't declare.
1254
1255 2019-05-08  Tom Tromey  <tromey@adacore.com>
1256
1257         * tui/tui-interp.c: Include main.h.
1258         * interps.c: Include main.h.
1259         * main.h (interpreter_p): Declare.
1260         * defs.h (interpreter_p): Don't declare.
1261
1262 2019-05-08  Tom Tromey  <tromey@adacore.com>
1263
1264         * dwarf2loc.c: Include dwarf2read.h.
1265         * defs.h (read_unsigned_leb128): Don't declare.
1266         * dwarf2read.h (read_unsigned_leb128): Declare.
1267
1268 2019-05-08  Tom Tromey  <tromey@adacore.com>
1269
1270         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1271         method.
1272
1273 2019-05-08  Tom Tromey  <tromey@adacore.com>
1274
1275         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1276         when no wrap column is set.
1277
1278 2019-05-08  Tom Tromey  <tromey@adacore.com>
1279
1280         * c-lang.c (c_get_string): Handle non-C-style arrays.
1281
1282 2019-05-08  Tom Tromey  <tromey@adacore.com>
1283
1284         * typeprint.c (print_offset_data::update): Print the bit offset,
1285         not the number of bits remaining.
1286
1287 2019-05-08  Tom Tromey  <tromey@adacore.com>
1288
1289         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1290         padding at end of comment.
1291
1292 2019-05-08  Tom Tromey  <tromey@adacore.com>
1293
1294         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1295         Compare main types.
1296
1297 2019-05-06  Tom Tromey  <tom@tromey.com>
1298
1299         * common/scoped_mmap.c: Include common-defs.h.
1300         * common/scoped_mmap.h: Don't include config.h.
1301
1302 2019-05-04  Tom Tromey  <tom@tromey.com>
1303
1304         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1305         (struct aarch64_call_info): Add initializers.
1306         <si>: Now a std::vector.
1307         (pass_on_stack, aarch64_push_dummy_call): Update.
1308
1309 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1310             Tom Tromey  <tom@tromey.com>
1311
1312         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1313         (ppc_threads): Now a std::vector.  Now static.
1314         (hwdebug_find_thread_points_by_tid)
1315         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1316         Update.
1317
1318 2019-05-04  Tom Tromey  <tom@tromey.com>
1319
1320         * arc-tdep.c (arc_tdesc_init): Return bool.
1321
1322 2019-05-04  Tom Tromey  <tom@tromey.com>
1323
1324         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1325         Use gdb_assert_not_reached.
1326
1327 2019-05-04  Tom Tromey  <tom@tromey.com>
1328
1329         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1330         "false".
1331
1332 2019-05-04  Tom Tromey  <tom@tromey.com>
1333
1334         * arc-tdep.c (arc_tdesc_init): Use bool.
1335
1336 2019-05-04  Tom Tromey  <tom@tromey.com>
1337
1338         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1339
1340 2019-05-04  Tom Tromey  <tom@tromey.com>
1341
1342         * cli/cli-cmds.c (valid_command_p): Return bool.
1343
1344 2019-05-04  Tom Tromey  <tom@tromey.com>
1345
1346         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1347         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1348
1349 2019-05-04  Raul Tambre  <raul@tambre.ee>
1350
1351         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1352         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1353         operator for comparison.
1354
1355 2019-05-04  Tom Tromey  <tom@tromey.com>
1356
1357         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1358         (lookup_partial_symbol, print_partial_symbols)
1359         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1360         (psymbol_compare): Update.
1361         (add_psymbol_to_bcache): Clear the entire psymbol.
1362         (maintenance_check_psymtabs): Update.
1363         * psympriv.h (struct partial_symbol): Don't derive from
1364         general_symbol_info.
1365         <obj_section, unrelocated_address, address,
1366         set_unrelocated_address>: Update.
1367         <ginfo>: New member.
1368         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1369         (debug_names::write_psymbols): Update.
1370
1371 2019-05-04  Tom de Vries  <tdevries@suse.de>
1372
1373         * contrib/cc-with-tweaks.sh: Support -n arg.
1374
1375 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1376
1377         * corelow.c (core_target::detach): Ensure frame cache and
1378         register caches are cleared.
1379         inferior.c (exit_inferior_1): Likewise.
1380
1381 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1382             Tom Tromey  <tom@tromey.com>
1383
1384         * dictionary.c (collate_pending_symbols_by_language): Remove
1385         "struct" from foreach.
1386         * symtab.c (lookup_global_symbol_from_objfile)
1387         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1388         foreach.
1389         * ser-tcp.c (net_open): Remove "struct" from foreach.
1390         * objfiles.c (objfile_relocate, objfile_rebase)
1391         (objfile_has_symbols): Remove "struct" from foreach.
1392         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1393         from foreach.
1394         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1395         foreach.
1396         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1397         "struct" from foreach.
1398         * ada-lang.c (create_excep_cond_exprs)
1399         (ada_exception_catchpoint_cond_string): Remove "struct" from
1400         foreach.
1401
1402 2019-05-03  Tom Tromey  <tromey@adacore.com>
1403
1404         * ada-exp.y (convert_char_literal): Check suffix of each
1405         enumerator.
1406
1407 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1408
1409         PR ada/21406:
1410         * ada-exp.y (yywrap): Don't define.
1411         * ada-lex.l (%option): Add noyywrap
1412         (yywrap): Remove.
1413
1414 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1415
1416         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1417         _WIN32_WINNT to the XP level, unless already defined to a higher
1418         level.
1419
1420         * unittests/parse-connection-spec-selftests.c:
1421         * ser-tcp.c:
1422         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1423         override.
1424
1425         * symfile.c (find_separate_debug_file): Remove colon from the
1426         drive spec of DOS/Windows file names of the target, so that the
1427         file name produced from DEBUGDIR and the target's directory will
1428         be valid on DOS/Windows systems.
1429
1430 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * rust-lang.c (val_print_struct): Handle printing structures
1433         containing strings.
1434
1435 2019-05-02  Tom Tromey  <tromey@adacore.com>
1436
1437         * valarith.c (_initialize_valarith): Remove.
1438
1439 2019-05-01  Tom Tromey  <tromey@adacore.com>
1440
1441         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1442         bitfields.
1443
1444 2019-05-01  Tom Tromey  <tromey@adacore.com>
1445
1446         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1447         for big-endian copies.
1448
1449 2019-04-30  Ali Tamur  <tamur@google.com>
1450         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1451         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1452         (read_3_bytes): New function.
1453
1454 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1455
1456         * windows-nat.c (main_thread_id): Delete.
1457         (handle_output_debug_string): Replace main_thread_id by
1458         current_event.dwThreadId.
1459         (fake_create_process): Likewise.
1460         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1461         Do not set main_thread_id.
1462         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1463         current_event.dwThreadId.
1464         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1465
1466 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1467
1468         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1469         Use current_event.dwThreadId instead of main_thread_id.
1470
1471 2019-04-30  Tom Tromey  <tromey@adacore.com>
1472
1473         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1474         (create_excep_cond_exprs): Iterate over program spaces.
1475         (ada_exception_catchpoint_cond_string): Examine all minimal
1476         symbols for exception types.
1477
1478 2019-04-30  Tom Tromey  <tromey@adacore.com>
1479
1480         PR c++/24470:
1481         * dwarf2read.c (process_structure_scope): Handle case where type
1482         has template parameters but no symbol was created.
1483
1484 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1485             Chris January  <chris.january@arm.com>
1486
1487         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1488         qualifier.
1489         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1490
1491 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1492
1493         * f-typeprint.c (f_print_type): Update rules for printing
1494         whitespace.
1495         (f_type_print_varspec_suffix): Likewise.
1496
1497 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1498             Chris January  <chris.january@arm.com>
1499
1500         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1501         function arguments.
1502
1503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1504
1505         * f-lang.c (build_fortran_types): Change name of void type to
1506         lower case.
1507         * f-typeprint.c (f_type_print_base): Print the name of the void
1508         type, rather than a fixed string.
1509         * f-valprint.c (f_decorations): Use lower case void string.
1510
1511 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1512             Chris January  <chris.january@arm.com>
1513
1514         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1515         types for Fortran.
1516
1517 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1518             Chris January  <chris.january@arm.com>
1519             David Lecomber  <david.lecomber@arm.com>
1520
1521         * f-exp.y (BINOP_INTRINSIC): New token.
1522         (exp): New parser rule handling BINOP_INTRINSIC.
1523         (f77_keywords): Add new builtin procedures.
1524         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1525         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1526         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1527         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1528         (print_unop_subexp_f): New function.
1529         (print_binop_subexp_f): New function.
1530         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1531         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1532         (dump_subexp_body_f): Likewise.
1533         (operator_check_f): Likewise.
1534         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1535         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1536
1537 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1540         UNOP_KIND.
1541         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1542         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1543         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1544         (operator_length_f): New fuction.
1545         (print_subexp_f): New function.
1546         (op_name_f): New function.
1547         (dump_subexp_body_f): New function.
1548         (operator_check_f): New function.
1549         (exp_descriptor_f): Replace standard expression handling functions
1550         with new functions.
1551         * gdb/fortran-operator.def: New file.
1552         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1553         * gdb/std-operator.def: Remove UNOP_KIND.
1554
1555 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * std-operator.def: Remove unbalanced, stray double quote
1558         character.
1559
1560 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1561             Chris January  <chris.january@arm.com>
1562             Daniel Everett  <daniel.everett@arm.com>
1563             Nick Forrington  <nick.forrington@arm.com>
1564             Richard Bunt  <richard.bunt@arm.com>
1565
1566         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1567         of depth when printing anonymous structs or unions.
1568         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1569         Don't print either the top-level value, or the children if the
1570         max-depth is exceeded.
1571         (ppscm_print_children): When printing the key of a map, allow one
1572         extra level of depth.
1573         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1574         print either the top-level value, or the children if the max-depth
1575         is exceeded.
1576         (print_children): When printing the key of a map, allow one extra
1577         level of depth.
1578         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1579         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1580         (user_print_options): Initialise max_depth field.
1581         (val_print_scalar_or_string_type_p): New function.
1582         (val_print): Check to see if the max depth has been reached.
1583         (val_print_check_max_depth): Define new function.
1584         (show_print_max_depth): New function.
1585         (_initialize_valprint): Add 'print max-depth' option.
1586         * valprint.h (struct value_print_options) <max_depth>: New field.
1587         (val_print_check_max_depth): Declare new function.
1588         * NEWS: Document new feature.
1589
1590 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1591
1592         * ada-lang.c (ada_language_defn): Initialise new field.
1593         * c-lang.c (c_is_string_type_p): New function.
1594         (c_language_defn): Initialise new field.
1595         (cplus_language_defn): Initialise new field.
1596         (asm_language_defn): Initialise new field.
1597         (minimal_language_defn): Initialise new field.
1598         * c-lang.h (c_is_string_type_p): Declare new function.
1599         * d-lang.c (d_language_defn): Initialise new field.
1600         * f-lang.c (f_is_string_type_p): New function.
1601         (f_language_defn): Initialise new field.
1602         * go-lang.c (go_is_string_type_p): New function.
1603         (go_language_defn): Initialise new field.
1604         * language.c (default_is_string_type_p): New function.
1605         (unknown_language_defn): Initialise new field.
1606         (auto_language_defn): Initialise new field.
1607         * language.h (struct language_defn) <la_is_string_type_p>: New
1608         member variable.
1609         (default_is_string_type_p): Declare new function.
1610         * m2-lang.c (m2_language_defn): Initialise new field.
1611         * objc-lang.c (objc_language_defn): Initialise new field.
1612         * opencl-lang.c (opencl_language_defn): Initialise new field.
1613         * p-lang.c (pascal_is_string_type_p): New function.
1614         (pascal_language_defn): Initialise new field.
1615         * rust-lang.c (rust_is_string_type_p): New function.
1616         (rust_language_defn): Initialise new field.
1617
1618 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1619
1620         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1621         New field.
1622         * ada-lang.c (ada_language_defn): Initialise new field.
1623         * c-lang.c (c_language_defn): Likewise.
1624         (cplus_language_defn): Likewise.
1625         (asm_language_defn): Likewise.
1626         (minimal_language_defn): Likewise.
1627         * d-lang.c (d_language_defn): Likewise.
1628         * f-lang.c (f_language_defn): Likewise.
1629         * go-lang.c (go_language_defn): Likewise.
1630         * language.c (unknown_language_defn): Likewise.
1631         (auto_language_defn): Likewise.
1632         * m2-lang.c (m2_language_defn): Likewise.
1633         * objc-lang.c (objc_language_defn): Likewise.
1634         * opencl-lang.c (opencl_language_defn): Likewise.
1635         * p-lang.c (pascal_language_defn): Likewise.
1636         * rust-lang.c (rust_language_defn): Likewise.
1637
1638 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1639
1640         * ada-lang.c (ada_is_character_type): Change return type to bool.
1641         (ada_is_string_type): Likewise.
1642         * ada-lang.h (ada_is_character_type): Update declaration
1643         (ada_is_string_type): Likewise.
1644
1645 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1646
1647         Support style in 'frame|thread apply'
1648
1649         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1650         * record.c (record_start, record_stop): Update callers of
1651         execute_command_to_string with false.
1652         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1653         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1654         methods.
1655         (class string_file): New constructor with term_out parameter.
1656         Override methods term_out and can_emit_style_escape.  New member
1657         term_out.
1658         (class stdio_file): Override can_emit_style_escape.
1659         (class tee_file): Override term_out and can_emit_style_escape.
1660         * utils.h (can_emit_style_escape): Remove.
1661         * utils.c (can_emit_style_escape): Likewise.
1662         Update all callers of can_emit_style_escape (SOMESTREAM) to
1663         SOMESTREAM->can_emit_style_escape.
1664         * source-cache.c (source_cache::get_source_lines): Likewise.
1665         * stack.c (frame_apply_command_count): Call execute_command_to_string
1666         passing the term_out characteristic of the current gdb_stdout.
1667         * thread.c (thr_try_catch_cmd): Likewise.
1668         * top.c (execute_command_to_string): pass term_out parameter
1669         to construct the string_file for the command output.
1670         * ui-file.c (term_cli_styling): New function (most code moved
1671         from utils.c can_emit_style_escape).
1672         (string_file::string_file, string_file::can_emit_style_escape,
1673         stdio_file::can_emit_style_escape, tee_file::term_out,
1674         tee_file::can_emit_style_escape): New functions.
1675
1676 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1677
1678         * NEWS: Mention the new set|show may-call-functions.
1679         * infcall.c (may_call_functions_p): New variable.
1680         (show_may_call_functions_p): New function.
1681         (call_function_by_hand_dummy): Throws an error if not
1682         may-call-functions.
1683         (_initialize_infcall): Call add_setshow_boolean_cmd for
1684         may-call-functions.
1685
1686 2019-04-25  Keith Seitz  <keiths@redhat.com>
1687
1688         PR c++/24367
1689         * cp-support.c (inspect_type): Don't attempt substitutions
1690         of symbol with the same name.
1691
1692 2019-04-25  Tom Tromey  <tromey@adacore.com>
1693
1694         PR gdb/24475:
1695         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1696         static.
1697
1698 2019-04-25  Tom Tromey  <tromey@adacore.com>
1699
1700         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1701         rvalue reference.
1702         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1703         (gdb_xml_parser::parse): Use std::move.
1704         * python/python-internal.h (gdbpy_convert_exception): Take a const
1705         reference.
1706         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1707         std::move.
1708         * python/py-utils.c (gdbpy_convert_exception): Take a const
1709         reference.
1710         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1711         Use std::move.
1712         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1713         Use std::move.
1714         * mi/mi-main.c (mi_print_exception): Take a const reference.
1715         * main.c (handle_command_errors): Take a const reference.
1716         * linespec.c (parse_linespec): Use std::move.
1717         * infcall.c (run_inferior_call): Use std::move.
1718         (call_function_by_hand_dummy): Use std::move.
1719         * exec.c (try_open_exec_file): Use std::move.
1720         * exceptions.h (exception_print, exception_fprintf)
1721         (exception_print_same): Update.
1722         * exceptions.c (print_exception, exception_print)
1723         (exception_fprintf, exception_print_same): Change parameters to
1724         const reference.
1725         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1726         * common/new-op.c: Use std::move.
1727         * common/common-exceptions.h (struct gdb_exception): Add move
1728         constructor.
1729         (struct gdb_exception_error, struct gdb_exception_quit, struct
1730         gdb_quit_bad_alloc): Change constructor to move constructor.
1731         (throw_exception): Change parameter to rvalue reference.
1732         * common/common-exceptions.c (throw_exception): Take rvalue
1733         reference.
1734         * cli/cli-interp.c (safe_execute_command): Use std::move.
1735         * breakpoint.c (insert_bp_location, location_to_sals): Use
1736         std::move.
1737
1738 2019-04-25  Tom Tromey  <tromey@adacore.com>
1739
1740         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1741         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1742         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1743         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1744         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1745         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1746         guile/scm-value.c: Use unpack.
1747         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1748         gdbscm_gdb_exception.
1749         (gdbscm_throw_gdb_exception): Likewise.
1750         (struct gdbscm_gdb_exception): New.
1751         (unpack): New function.
1752         (gdbscm_wrap): Use unpack.
1753
1754 2019-04-25  Tom Tromey  <tromey@adacore.com>
1755
1756         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1757         (gdb_rl_callback_handler): Use std::move.
1758         * common/common-exceptions.h (struct gdb_exception): Add move
1759         assignment operator.
1760         (throw_exception_sjlj): Change "exception" to const reference.
1761         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1762         (throw_exception_sjlj): Change "exception" to const reference.
1763
1764 2019-04-25  Tom Tromey  <tromey@adacore.com>
1765
1766         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1767         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1768         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1769         Update.
1770         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1771         Update.
1772         * mi/mi-interp.c (mi_interp::exec): Update.
1773         * linespec.c (parse_linespec): Update.
1774         * infcall.c (run_inferior_call): Update.
1775         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1776         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1777         (gdbscm_lookup_global_symbol): Update.
1778         * guile/scm-param.c (gdbscm_parameter_value): Update.
1779         * guile/scm-frame.c (gdbscm_frame_read_register)
1780         (gdbscm_frame_read_var): Update.
1781         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1782         * exec.c (try_open_exec_file): Update.
1783         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1784         (gdb_rl_callback_handler): Update.
1785         * common/common-exceptions.h (exception_none): Don't declare.
1786         * common/common-exceptions.c (exception_none): Don't define.
1787         (struct catcher) <exception>: Update.
1788         * cli/cli-interp.c (safe_execute_command): Update.
1789         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1790
1791 2019-04-25  Ali Tamur  <tamur@google.com>
1792
1793         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1794         (read_attribute_value): Likewise.
1795         (dwarf2_read_addr_index): Update comment.
1796         (read_str_index): Add DW_FORM_strx.
1797         (dwarf2_string_attr): Likewise.
1798         (dwarf2_const_value_attr): Likewise.
1799         (dump_die_shallow): Likewise.
1800         (dwarf2_fetch_constant_bytes): Likewise.
1801         (skip_form_bytes): Likewise.
1802         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1803
1804 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1805
1806         PR corefiles/11608
1807         PR corefiles/18187
1808         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1809         OFFSET.  Verify if current mapping contains an ELF header.
1810         (linux_find_memory_regions_full): Adjust call to
1811         dump_mapping_p.
1812
1813 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1814             Kang Li <kanglictf@gmail.com>
1815
1816         PR gdb/21600
1817
1818         * dwarf2-frame.c (read_initial_length): Be consistent about using
1819         unsigned representation of length.
1820         (decode_frame_entry_1): Likewise.  Check for wraparound of
1821         end pointer as well as buffer overflow.
1822
1823 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1824
1825         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1826         "vq".
1827
1828 2019-04-24  Tom Tromey  <tromey@adacore.com>
1829
1830         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1831
1832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1833
1834         * s12z-tdep.c (s12z_unwind_pc): Delete.
1835         (s12z_unwind_sp): Delete.
1836         (s12z_gdbarch_init): Don't register deleted functions with
1837         gdbarch.
1838
1839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1840
1841         * rl78-tdep.c (rl78_unwind_sp): Delete.
1842         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1843
1844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1845
1846         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1847         (xstormy16_unwind_pc): Delete.
1848         (xstormy16_dummy_id): Delete.
1849         (xstormy16_gdbarch_init): Don't register deleted functions with
1850         gdbarch.
1851
1852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1853
1854         * vax-tdep.c (vax_unwind_pc): Delete.
1855         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1856
1857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1858
1859         * v850-tdep.c (v850_unwind_sp): Delete.
1860         (v850_unwind_pc): Delete.
1861         (v850_dummy_id): Delete.
1862         (v850_gdbarch_init): Don't register deleted functions with
1863         gdbarch.
1864
1865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1868         (tilegx_unwind_pc): Delete.
1869         (tilegx_unwind_dummy_id): Delete.
1870         (tilegx_gdbarch_init): Don't register deleted functions with
1871         gdbarch.
1872
1873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1874
1875         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1876         (tic6x_dummy_id): Delete.
1877         (tic6x_gdbarch_init): Don't register deleted functions with
1878         gdbarch.
1879
1880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1881
1882         * sparc-tdep.c (sparc_unwind_pc): Delete.
1883         (sparc32_gdbarch_init): Don't register deleted function with
1884         gdbarch.
1885
1886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1887
1888         * sh-tdep.c (sh_unwind_sp): Delete.
1889         (sh_unwind_pc): Delete.
1890         (sh_dummy_id): Delete.
1891         (sh_gdbarch_init): Don't register deleted functions with
1892         gdbarch.
1893
1894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * score-tdep.c (score_unwind_sp): Delete.
1897         (score_unwind_pc): Delete.
1898         (score_dummy_id): Delete.
1899         (score_gdbarch_init): Don't register deleted functions with
1900         gdbarch.
1901
1902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * rx-tdep.c (rx_unwind_pc): Delete.
1905         (rx_unwind_sp): Delete.
1906         (rx_dummy_id): Delete.
1907         (rx_gdbarch_init): Don't register deleted functions with
1908         gdbarch.  Update comment.
1909
1910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1913         (rs6000_dummy_id): Delete.
1914         (rs6000_gdbarch_init): Don't register deleted functions with
1915         gdbarch.
1916
1917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1918
1919         * or1k-tdep.c (or1k_dummy_id): Delete.
1920         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1921
1922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1923
1924         * nios2-tdep.c (nios2_dummy_id): Delete.
1925         (nios2_unwind_sp): Delete.
1926         (nios2_gdbarch_init): Don't register deleted functions with
1927         gdbarch.
1928
1929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1930
1931         * nds32-tdep.c (nds32_dummy_id): Delete.
1932         (nds32_unwind_pc): Delete.
1933         (nds32_unwind_sp): Delete.
1934         (nds32_gdbarch_init): Don't register deleted functions with
1935         gdbarch.
1936
1937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1938
1939         * msp430-tdep.c (msp430_unwind_pc): Delete.
1940         (msp430_unwind_sp): Delete.
1941         (msp430_dummy_id): Delete.
1942         (msp430_gdbarch_init): Don't register deleted functions with
1943         gdbarch.
1944
1945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1946
1947         * moxie-tdep.c (moxie_unwind_sp): Delete.
1948         (moxie_unwind_pc): Delete.
1949         (moxie_dummy_id): Delete.
1950         (moxie_gdbarch_init): Don't register deleted functions with
1951         gdbarch.
1952
1953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1954
1955         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1956         (mn10300_unwind_pc): Delete.
1957         (mn10300_unwind_sp): Delete.
1958         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1959         mn10300_unwind_sp.
1960         (mn10300_frame_unwind_init): Don't register deleted functions with
1961         gdbarch.
1962
1963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1964
1965         * mep-tdep.c (mep_unwind_pc): Delete.
1966         (mep_unwind_sp): Delete.
1967         (mep_dummy_id): Delete.
1968         (mep_gdbarch_init): Don't register deleted functions with
1969         gdbarch.
1970
1971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1972
1973         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1974         (m68hc11_unwind_sp): Delete.
1975         (m68hc11_gdbarch_init): Don't register deleted functions with
1976         gdbarch.
1977
1978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         * m32r-tdep.c (m32r_unwind_sp): Delete.
1981         (m32r_unwind_pc): Delete.
1982         (m32r_dummy_id): Delete.
1983         (m32r_gdbarch_init): Don't register deleted functions with
1984         gdbarch.
1985
1986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1987
1988         * m32c-tdep.c (m32c_unwind_pc): Delete.
1989         (m32c_unwind_sp): Delete.
1990         (m32c_dummy_id): Delete.
1991         (m32c_gdbarch_init): Don't register deleted functions with
1992         gdbarch.
1993
1994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1995
1996         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1997         (lm32_unwind_pc): Delete.
1998         (lm32_dummy_id): Delete.
1999         (lm32_gdbarch_init): Don't register deleted functions with
2000         gdbarch.
2001
2002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2003
2004         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2005         (iq2000_unwind_pc): Delete.
2006         (iq2000_dummy_id): Delete.
2007         (iq2000_gdbarch_init): Don't register deleted functions with
2008         gdbarch.
2009
2010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2011
2012         * nds32-tdep.c (nds32_type_align): Delete.
2013         (nds32_push_dummy_call): Use type_align instead.
2014
2015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2016
2017         * arm-tdep.c (arm_type_align): Only handle vector override case.
2018         (arm_push_dummy_call): Use type_align.
2019         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2020
2021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2022
2023         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2024         case.
2025         (pass_on_stack): Use type_align.
2026         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2027         function.
2028
2029 2019-04-23  Tom Tromey  <tromey@adacore.com>
2030
2031         * dwarf2read.c (line_header::file_name_at): Remove unused
2032         overload.
2033
2034 2019-04-23  Tom de Vries  <tdevries@suse.de>
2035
2036         PR gdb/24438
2037         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2038         invocation.
2039
2040
2041 2019-03-27  Ali Tamur  <tamur@google.com>
2042
2043         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2044         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2045         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2046         (dwarf_expr_context::get_addr_index): Likewise
2047         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2048         (symbol_needs_eval_context::get_addr_index): Likewise
2049         (disassemble_dwarf_expression): Add DW_OP_addrx
2050         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2051         (read_cutu_die_from_dwo): Update comment
2052         (skip_one_die): Add DW_FORM_addrx
2053         (read_attribute_value): Likewise
2054         (var_decode_location): Add DW_OP_addrx
2055         (dwarf2_const_value_attr): Add DW_FORM_addrx
2056         (dump_die_shallow): Likewise
2057         (dwarf2_fetch_constant_bytes): Likewise
2058         (decode_locdesc): Add DW_OP_addrx
2059         (skip_form_bytes): Add DW_FORM_addrx
2060
2061 2019-04-22  Ali Tamur  <tamur@google.com>
2062
2063         * MAINTAINERS (Write After Approval): Add self.
2064
2065 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2066
2067         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2068         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2069         (open_symbol_file_object): Likewise.
2070         (svr4_default_sos): Add info parameter.
2071         (svr4_read_so_list): Likewise.
2072         (svr4_current_sos_direct): Adjust functions calls to pass down
2073         info.
2074         (svr4_current_sos_1): Add info parameter.
2075         (svr4_current_sos): Call get_svr4_info, pass info down to
2076         svr4_current_sos_1.
2077         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2078         get_svr4_info.
2079         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2080         get_svr4_info.
2081         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2082         to get_svr4_info.
2083         (probes_table_remove_objfile_probes): Likewise.
2084         (register_solib_event_probe): Add info parameter.
2085         (solist_update_incremental): Pass info parameter down to
2086         svr4_read_so_list.
2087         (disable_probes_interface): Add info parameter.
2088         (svr4_handle_solib_event): Pass current_program_space to
2089         get_svr4_info.  Adjust disable_probes_interface cleanup.
2090         (svr4_create_probe_breakpoints): Add info parameter, pass it
2091         down to register_solib_event_probe.
2092         (svr4_create_solib_event_breakpoints): Add info parameter,
2093         pass it down to svr4_create_probe_breakpoints.
2094         (enable_break): Pass info down to
2095         svr4_create_solib_event_breakpoints.
2096         (svr4_solib_create_inferior_hook): Pass current_program_space to
2097         get_svr4_info.
2098         (svr4_clear_solib): Likewise.
2099
2100 2019-04-22  Pedro Alves  <palves@redhat.com>
2101
2102         * solib-svr4.c (svr4_free_objfile_observer): New.
2103         (probe_and_action::objfile): New field.
2104         (probes_table_htab_remove_objfile_probes)
2105         (probes_table_remove_objfile_probes): New functions.
2106         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2107         in the new probe_and_action.  Don't store the probe in 'lookup'.
2108         (svr4_create_probe_breakpoints): Pass objfile to
2109         register_solib_event_probe.
2110         (_initialize_svr4_solib): Register a free_objfile observer.
2111
2112 2019-04-19  Tom Tromey  <tom@tromey.com>
2113
2114         * common/queue.h: Remove.
2115
2116 2019-04-19  Tom Tromey  <tom@tromey.com>
2117
2118         * event-loop.c: Don't include "common/queue.h".
2119
2120 2019-04-19  Tom Tromey  <tom@tromey.com>
2121
2122         * remote.c (remote_target): Use delete.
2123         * remote-notif.h: Include <list>, not "common/queue.h".
2124         (notif_client_p): Remove typedef.
2125         (remote_notif_state): Add constructor, destructor, initializer.
2126         <notif_queue>: Now a std::list.
2127         (remote_notif_state_xfree): Don't declare.
2128         * remote-notif.c (remote_notif_process, handle_notification)
2129         (remote_notif_state_allocate): Update.
2130         (~remote_notif_state): Rename from remote_notif_state_xfree.
2131
2132 2019-04-19  Tom Tromey  <tom@tromey.com>
2133
2134         * symfile.c (reread_symbols): Update.
2135         * objfiles.c (objfile_register_static_link)
2136         (objfile_lookup_static_link): Update
2137         (~objfile) Don't delete static_links.
2138         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2139
2140 2019-04-19  Tom Tromey  <tom@tromey.com>
2141
2142         * type-stack.h (struct type_stack) <insert>: Constify string.
2143         * type-stack.c (type_stack::insert): Constify string.
2144         * gdbtypes.h (lookup_template_type): Update.
2145         (address_space_name_to_int): Update.
2146         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2147         const.
2148         (lookup_template_type): Make name const.
2149         * c-exp.y: Update rules.
2150         (lex_one_token, classify_name, classify_inner_name)
2151         (c_print_token): Update.
2152         * p-exp.y: Update rules.
2153         (yylex): Update.
2154         * f-exp.y: Update rules.
2155         (yylex): Update.
2156         * d-exp.y: Update rules.
2157         (lex_one_token, classify_name, classify_inner_name): Update.
2158         * parse.c (write_dollar_variable, copy_name): Return std::string.
2159         * parser-defs.h (copy_name): Change return type.
2160         * m2-exp.y: Update rules.
2161         (yylex): Update.
2162         * go-exp.y (lex_one_token): Update.
2163         Update rules.
2164         (classify_unsafe_function, classify_packaged_name)
2165         (classify_name, yylex): Update.
2166
2167 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2168
2169         * configure.ac: add --enable-source-highlight switch.
2170         * configure: Regenerate.
2171         * top.c (print_gdb_version): plumb --enable-source-highlight
2172         status to "show configuration".
2173
2174 2019-04-19  Tom Tromey  <tromey@adacore.com>
2175
2176         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2177         Check ADA_TYPE_P.
2178         (empty_record, ada_template_to_fixed_record_type_1)
2179         (template_to_static_fixed_type)
2180         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2181         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2182         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2183         macros.
2184
2185 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2186
2187         PR symtab/24423:
2188         * source.c (print_source_lines_base): Advance "iter" when a
2189         control character is seen.
2190
2191 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2192
2193         * inferior.h (struct infcall_suspend_state_deleter):
2194         Catch exception in destructor to avoid crash.
2195
2196 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2197
2198         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2199         close to the add_com "shell".
2200
2201 2019-04-18  Tom Tromey  <tromey@adacore.com>
2202
2203         * process-stratum-target.h (class process_stratum_target)
2204         <stratum>: Add "final".
2205
2206 2019-04-17  Tom Tromey  <tromey@adacore.com>
2207
2208         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2209         against nullptr before use.
2210
2211 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2212
2213         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2214
2215 2019-04-17  Jim Wilson  <jimw@sifive.com>
2216             Andrew Burgess  <andrew.burgess@embecosm.com>
2217
2218         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2219         code read might fail, assume 4-byte breakpoint in that case.
2220
2221 2019-04-15  Leszek Swirski  <leszeks@google.com>
2222
2223         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2224         rather than a hand-rolled POD check when checking for forced MEMORY
2225         classification.
2226
2227 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2228
2229         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2230         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2231         function.
2232         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2233         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2234         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2235         declaration.
2236
2237 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2238
2239         * aarch64-linux-nat.c
2240         (aarch64_linux_nat_target::thread_architecture): Add override.
2241         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2242         each VQ.
2243
2244 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2245
2246         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2247
2248 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2251         target types of size 96-bits, add some additional comments, and
2252         check that the builtin type we found was the correct size.
2253
2254 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2255
2256         * utils.c (prompt_for_continue): Don't restore the styling at the
2257         end, as applied_style has the wrong value.  This fixes styling in
2258         long lists of file names that are interrupted by the "Continue?"
2259         prompt.
2260
2261 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2264         * c-lang.c (c_language_defn): Likewise.
2265         (cplus_language_defn): Likewise.
2266         (asm_language_defn): Likewise.
2267         (minimal_language_defn): Likewise.
2268         * d-lang.c (d_language_defn): Likewise.
2269         * f-lang.c (f_language_defn): Likewise.
2270         * go-lang.c (go_language_defn): Likewise.
2271         * language.c (unknown_language_defn): Likewise.
2272         (auto_language_defn): Likewise.
2273         * language.h (struct language_defn): Remove la_magic field.
2274         (LANG_MAGIC): Delete.
2275         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2276         * objc-lang.c (objc_language_defn): Likewise.
2277         * opencl-lang.c (opencl_language_defn): Likewise.
2278         * p-lang.c (pascal_language_defn): Likewise.
2279         * rust-lang.c (rust_language_defn): Likewise.
2280
2281 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         * riscv-tdep.c (riscv_type_align): New function.
2284         (riscv_type_alignment): Delete.
2285         (riscv_arg_location): Use 'type_align'.
2286         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2287
2288 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * gdbtypes.c (type_align): A struct with no non-static fields also
2291         has alignment of 1.
2292
2293 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2296         component to 0.
2297         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2298         member.
2299         (riscv_struct_info::analyse): New implementation using new
2300         analyse_inner member function.
2301         (riscv_struct_info::field_offset): New member function.
2302         (riscv_struct_info::m_offsets): New member variable.
2303         (riscv_struct_info::analyse_inner): New private member function,
2304         takes the old implementation of riscv_struct_info::analyse but
2305         extended to track field offsets.
2306         (riscv_call_arg_struct): Update the struct folding special cases
2307         to handle cases where empty C++ structs, which are non-zero
2308         length, are found.
2309         (riscv_arg_location): Initialise the length of each location, a
2310         non-zero length now indicates the location is in use.
2311         (riscv_push_dummy_call): Allow for the first location having a
2312         non-zero offset when setting up arguments.
2313         (riscv_return_value): Likewise, but for return values.
2314
2315 2019-04-11  Tom Tromey  <tromey@adacore.com>
2316
2317         * utils.c (internal_vproblem): Make "msg" const.
2318
2319 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2320
2321         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2322         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2323         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2324         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2325
2326 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2327
2328         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2329         function.
2330         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2331         of amd64_collect_native_gregset.
2332         (amd64_linux_nat_target::store_registers): Likewise.
2333
2334 2019-04-10  Tom Tromey  <tom@tromey.com>
2335
2336         * symtab.c (lookup_global_symbol_from_objfile)
2337         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2338         * objfiles.h (class separate_debug_iterator): New.
2339         (class separate_debug_range): New.
2340         (struct objfile) <separate_debug_objfiles>: New method.
2341         (objfile_separate_debug_iterate): Don't declare.
2342         * objfiles.c (separate_debug_iterator::operator++): Rename from
2343         objfile_separate_debug_iterate.
2344         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2345         iterator.
2346         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2347         iterator.
2348
2349 2019-04-10  Tom Tromey  <tom@tromey.com>
2350
2351         * symfile.c (reread_symbols): Remove old comment.
2352         * objfiles.c (free_all_objfiles): Fix a typo.
2353
2354 2019-04-10  Tom Tromey  <tom@tromey.com>
2355
2356         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2357         * minsyms.c (lookup_minimal_symbol): Use foreach.
2358         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2359         (lookup_minimal_symbol_solib_trampoline): Likewise.
2360         * symfile.c (reread_symbols): Use foreach.
2361
2362 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2363             Tom Tromey  <tromey@adacore.com>
2364
2365         PR rust/24414:
2366         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2367         (rust_lex_int_test): Change "value" to be LONGEST.
2368         (rust_lex_tests): Add test for long integer literal.
2369
2370 2019-04-09  Tom Tromey  <tromey@adacore.com>
2371
2372         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2373         to bool.
2374         (extended_remote_target::attach): Update.
2375         (remote_target::remote_notice_new_inferior): Update.
2376         (remote_target::add_current_inferior_and_thread): Update.
2377         * inferior.c (exit_inferior_1): Use "false".
2378         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2379
2380 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2381
2382         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2383         the "start" command.
2384
2385 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2386
2387         * python/py-inferior.c (infpy_thread_from_thread_handle):
2388         Adjust comments to reflect renaming of thread_from_thread_handle
2389         to thread_from_handle.  Adjust keywords.  Fix type error message.
2390         (inferior_object_methods): Add thread_from_handle.  Retain
2391         thread_from_thread_handle, but mark it as deprecated.
2392
2393 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2394
2395         * gdbthread.h (find_thread_by_handle): Revise declaration.
2396         * thread.c (find_thread_by_handle): Likewise.  Adjust
2397         implementation too.
2398         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2399         support for buffer objects as handles.
2400
2401 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2402
2403         * python/py-infthread.c (thpy_thread_handle): New function.
2404         (thread_object_methods): Register thpy_thread_handle.
2405
2406 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2407
2408         * gdbthread.h (thread_to_thread_handle): Declare.
2409         * thread.c (gdbtypes.h): Include.
2410         (thread_to_thread_handle): New function.
2411
2412         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2413         (target_thread_info_to_thread_handle): Declare.
2414         * target.c (target_thread_info_to_thread_handle): New function.
2415         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2416         * target-delegates.c: Regenerate.
2417
2418         * linux-thread-db.c (class thread_db_target): Add method
2419         thread_info_to_thread_handle.
2420         (thread_db_target::thread_info_to_thread_handle): Define.
2421         * remote.c (class remote_target): Add new method
2422         thread_info_to_thread_handle.
2423         (remote_target::thread_info_to_thread_handle): Define.
2424
2425 2019-04-08  Pedro Alves  <palves@redhat.com>
2426
2427         * common/common-exceptions.c (throw_exception): Don't create
2428         named object to throw; throw directly.
2429         (throw_it): Likewise.  Don't initialize gdb_exception::message
2430         here, with new; pass FMT and AP to the ctor instead.
2431         * common/common-exceptions.h: Include <string>.
2432         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2433         const char *, va_list)): New ctor.  Use std::make_shared.
2434         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2435         errors)): Delete.
2436         (gdb_exception_error::gdb_exception_error(enum errors, const char
2437         *, va_list)): New.
2438         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2439         Add assertion.
2440         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2441         errors)): Delete.
2442         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2443         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2444         Add assertion.
2445
2446 2019-04-08  Tom Tromey  <tom@tromey.com>
2447
2448         * valops.c (value_rtti_indirect_type): Replace throw_exception
2449         with throw.
2450         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2451         with throw.
2452         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2453         throw.
2454         * target.c (target_translate_tls_address): Replace throw_exception
2455         with throw.
2456         * stack.c (frame_apply_command_count): Replace throw_exception
2457         with throw.
2458         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2459         throw.
2460         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2461         with throw.
2462         * rs6000-tdep.c (rs6000_frame_cache)
2463         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2464         * remote.c: Replace throw_exception with throw.
2465         * record-full.c (record_full_message, record_full_wait_1)
2466         (record_full_restore): Replace throw_exception with throw.
2467         * record-btrace.c:
2468         (get_thread_current_frame_id, record_btrace_start_replaying)
2469         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2470         (cmd_record_btrace_start): Replace throw_exception with throw.
2471         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2472         throw.
2473         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2474         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2475         * linespec.c:
2476         (find_linespec_symbols): Replace throw_exception with throw.
2477         * infrun.c (displaced_step_prepare, resume): Replace
2478         throw_exception with throw.
2479         * infcmd.c (post_create_inferior): Replace throw_exception with
2480         throw.
2481         * inf-loop.c (inferior_event_handler): Replace throw_exception
2482         with throw.
2483         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2484         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2485         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2486         (get_prev_frame_always, get_frame_pc_if_available)
2487         (get_frame_address_in_block_if_available, get_frame_language):
2488         Replace throw_exception with throw.
2489         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2490         throw_exception with throw.
2491         * eval.c (fetch_subexp_value, evaluate_var_value)
2492         (evaluate_funcall, evaluate_subexp_standard): Replace
2493         throw_exception with throw.
2494         * dwarf2loc.c (call_site_find_chain)
2495         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2496         Replace throw_exception with throw.
2497         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2498         with throw.
2499         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2500         throw.
2501         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2502         * completer.c (complete_line_internal): Replace throw_exception
2503         with throw.
2504         * compile/compile-object-run.c (compile_object_run): Replace
2505         throw_exception with throw.
2506         * cli/cli-script.c (process_next_line): Replace throw_exception
2507         with throw.
2508         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2509         (btrace_enable, btrace_maint_update_pt_packets): Replace
2510         throw_exception with throw.
2511         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2512         throw_exception with throw.
2513         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2514         throw_exception with throw.
2515         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2516         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2517         * aarch64-tdep.c (aarch64_make_prologue_cache)
2518         (aarch64_make_stub_cache): Replace throw_exception with throw.
2519
2520 2019-04-08  Tom Tromey  <tom@tromey.com>
2521
2522         * common/common-exceptions.c (throw_exception): Rename from
2523         throw_exception_cxx.  Remove old copy.  Make argument const.
2524         (throw_it): Create and throw exception objects directly.
2525         * common/common-exceptions.h (throw_exception): Make argument
2526         const.
2527         (struct gdb_exception_error): Add constructor.
2528         (struct gdb_exception_quit): Add constructor.
2529
2530 2019-04-08  Tom Tromey  <tom@tromey.com>
2531
2532         * common/common-exceptions.h (exception_rethrow): Don't declare.
2533         (TRY_SJLJ): Update comment.
2534         (TRY, CATCH, END_CATCH): Remove.
2535         * common/common-exceptions.c (exception_rethrow): Remove.
2536
2537 2019-04-08  Tom Tromey  <tom@tromey.com>
2538
2539         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2540         Remove.
2541         (gdb_exception_error): Rename from
2542         gdb_exception_RETURN_MASK_ERROR.
2543         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2544         (gdb_quit_bad_alloc): Update.
2545         * aarch64-tdep.c: Update.
2546         * ada-lang.c: Update.
2547         * ada-typeprint.c: Update.
2548         * ada-valprint.c: Update.
2549         * amd64-tdep.c: Update.
2550         * arch-utils.c: Update.
2551         * break-catch-throw.c: Update.
2552         * breakpoint.c: Update.
2553         * btrace.c: Update.
2554         * c-varobj.c: Update.
2555         * cli/cli-cmds.c: Update.
2556         * cli/cli-interp.c: Update.
2557         * cli/cli-script.c: Update.
2558         * common/common-exceptions.c: Update.
2559         * common/new-op.c: Update.
2560         * common/selftest.c: Update.
2561         * compile/compile-c-symbols.c: Update.
2562         * compile/compile-cplus-symbols.c: Update.
2563         * compile/compile-object-load.c: Update.
2564         * compile/compile-object-run.c: Update.
2565         * completer.c: Update.
2566         * corelow.c: Update.
2567         * cp-abi.c: Update.
2568         * cp-support.c: Update.
2569         * cp-valprint.c: Update.
2570         * darwin-nat.c: Update.
2571         * disasm-selftests.c: Update.
2572         * dtrace-probe.c: Update.
2573         * dwarf-index-cache.c: Update.
2574         * dwarf-index-write.c: Update.
2575         * dwarf2-frame-tailcall.c: Update.
2576         * dwarf2-frame.c: Update.
2577         * dwarf2loc.c: Update.
2578         * dwarf2read.c: Update.
2579         * eval.c: Update.
2580         * event-loop.c: Update.
2581         * event-top.c: Update.
2582         * exec.c: Update.
2583         * f-valprint.c: Update.
2584         * fbsd-tdep.c: Update.
2585         * frame-unwind.c: Update.
2586         * frame.c: Update.
2587         * gdbtypes.c: Update.
2588         * gnu-v3-abi.c: Update.
2589         * guile/guile-internal.h: Update.
2590         * guile/scm-block.c: Update.
2591         * guile/scm-breakpoint.c: Update.
2592         * guile/scm-cmd.c: Update.
2593         * guile/scm-disasm.c: Update.
2594         * guile/scm-frame.c: Update.
2595         * guile/scm-lazy-string.c: Update.
2596         * guile/scm-math.c: Update.
2597         * guile/scm-param.c: Update.
2598         * guile/scm-ports.c: Update.
2599         * guile/scm-pretty-print.c: Update.
2600         * guile/scm-symbol.c: Update.
2601         * guile/scm-symtab.c: Update.
2602         * guile/scm-type.c: Update.
2603         * guile/scm-value.c: Update.
2604         * i386-linux-tdep.c: Update.
2605         * i386-tdep.c: Update.
2606         * inf-loop.c: Update.
2607         * infcall.c: Update.
2608         * infcmd.c: Update.
2609         * infrun.c: Update.
2610         * jit.c: Update.
2611         * language.c: Update.
2612         * linespec.c: Update.
2613         * linux-fork.c: Update.
2614         * linux-nat.c: Update.
2615         * linux-tdep.c: Update.
2616         * linux-thread-db.c: Update.
2617         * main.c: Update.
2618         * mi/mi-cmd-break.c: Update.
2619         * mi/mi-cmd-stack.c: Update.
2620         * mi/mi-interp.c: Update.
2621         * mi/mi-main.c: Update.
2622         * objc-lang.c: Update.
2623         * p-valprint.c: Update.
2624         * parse.c: Update.
2625         * ppc-linux-tdep.c: Update.
2626         * printcmd.c: Update.
2627         * python/py-arch.c: Update.
2628         * python/py-breakpoint.c: Update.
2629         * python/py-cmd.c: Update.
2630         * python/py-finishbreakpoint.c: Update.
2631         * python/py-frame.c: Update.
2632         * python/py-framefilter.c: Update.
2633         * python/py-gdb-readline.c: Update.
2634         * python/py-inferior.c: Update.
2635         * python/py-infthread.c: Update.
2636         * python/py-lazy-string.c: Update.
2637         * python/py-linetable.c: Update.
2638         * python/py-objfile.c: Update.
2639         * python/py-param.c: Update.
2640         * python/py-prettyprint.c: Update.
2641         * python/py-progspace.c: Update.
2642         * python/py-record-btrace.c: Update.
2643         * python/py-record.c: Update.
2644         * python/py-symbol.c: Update.
2645         * python/py-type.c: Update.
2646         * python/py-unwind.c: Update.
2647         * python/py-utils.c: Update.
2648         * python/py-value.c: Update.
2649         * python/python.c: Update.
2650         * record-btrace.c: Update.
2651         * record-full.c: Update.
2652         * remote-fileio.c: Update.
2653         * remote.c: Update.
2654         * riscv-tdep.c: Update.
2655         * rs6000-aix-tdep.c: Update.
2656         * rs6000-tdep.c: Update.
2657         * rust-exp.y: Update.
2658         * rust-lang.c: Update.
2659         * s390-tdep.c: Update.
2660         * selftest-arch.c: Update.
2661         * solib-dsbt.c: Update.
2662         * solib-frv.c: Update.
2663         * solib-spu.c: Update.
2664         * solib-svr4.c: Update.
2665         * solib.c: Update.
2666         * sparc64-linux-tdep.c: Update.
2667         * stack.c: Update.
2668         * symfile-mem.c: Update.
2669         * symmisc.c: Update.
2670         * target.c: Update.
2671         * thread.c: Update.
2672         * top.c: Update.
2673         * tracefile-tfile.c: Update.
2674         * tui/tui.c: Update.
2675         * typeprint.c: Update.
2676         * unittests/cli-utils-selftests.c: Update.
2677         * unittests/parse-connection-spec-selftests.c: Update.
2678         * valops.c: Update.
2679         * valprint.c: Update.
2680         * value.c: Update.
2681         * varobj.c: Update.
2682         * windows-nat.c: Update.
2683         * x86-linux-nat.c: Update.
2684         * xml-support.c: Update.
2685
2686 2019-04-08  Tom Tromey  <tom@tromey.com>
2687
2688         * xml-support.c: Use C++ exception handling.
2689         * x86-linux-nat.c: Use C++ exception handling.
2690         * windows-nat.c: Use C++ exception handling.
2691         * varobj.c: Use C++ exception handling.
2692         * value.c: Use C++ exception handling.
2693         * valprint.c: Use C++ exception handling.
2694         * valops.c: Use C++ exception handling.
2695         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2696         handling.
2697         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2698         * typeprint.c: Use C++ exception handling.
2699         * tui/tui.c: Use C++ exception handling.
2700         * tracefile-tfile.c: Use C++ exception handling.
2701         * top.c: Use C++ exception handling.
2702         * thread.c: Use C++ exception handling.
2703         * target.c: Use C++ exception handling.
2704         * symmisc.c: Use C++ exception handling.
2705         * symfile-mem.c: Use C++ exception handling.
2706         * stack.c: Use C++ exception handling.
2707         * sparc64-linux-tdep.c: Use C++ exception handling.
2708         * solib.c: Use C++ exception handling.
2709         * solib-svr4.c: Use C++ exception handling.
2710         * solib-spu.c: Use C++ exception handling.
2711         * solib-frv.c: Use C++ exception handling.
2712         * solib-dsbt.c: Use C++ exception handling.
2713         * selftest-arch.c: Use C++ exception handling.
2714         * s390-tdep.c: Use C++ exception handling.
2715         * rust-lang.c: Use C++ exception handling.
2716         * rust-exp.y: Use C++ exception handling.
2717         * rs6000-tdep.c: Use C++ exception handling.
2718         * rs6000-aix-tdep.c: Use C++ exception handling.
2719         * riscv-tdep.c: Use C++ exception handling.
2720         * remote.c: Use C++ exception handling.
2721         * remote-fileio.c: Use C++ exception handling.
2722         * record-full.c: Use C++ exception handling.
2723         * record-btrace.c: Use C++ exception handling.
2724         * python/python.c: Use C++ exception handling.
2725         * python/py-value.c: Use C++ exception handling.
2726         * python/py-utils.c: Use C++ exception handling.
2727         * python/py-unwind.c: Use C++ exception handling.
2728         * python/py-type.c: Use C++ exception handling.
2729         * python/py-symbol.c: Use C++ exception handling.
2730         * python/py-record.c: Use C++ exception handling.
2731         * python/py-record-btrace.c: Use C++ exception handling.
2732         * python/py-progspace.c: Use C++ exception handling.
2733         * python/py-prettyprint.c: Use C++ exception handling.
2734         * python/py-param.c: Use C++ exception handling.
2735         * python/py-objfile.c: Use C++ exception handling.
2736         * python/py-linetable.c: Use C++ exception handling.
2737         * python/py-lazy-string.c: Use C++ exception handling.
2738         * python/py-infthread.c: Use C++ exception handling.
2739         * python/py-inferior.c: Use C++ exception handling.
2740         * python/py-gdb-readline.c: Use C++ exception handling.
2741         * python/py-framefilter.c: Use C++ exception handling.
2742         * python/py-frame.c: Use C++ exception handling.
2743         * python/py-finishbreakpoint.c: Use C++ exception handling.
2744         * python/py-cmd.c: Use C++ exception handling.
2745         * python/py-breakpoint.c: Use C++ exception handling.
2746         * python/py-arch.c: Use C++ exception handling.
2747         * printcmd.c: Use C++ exception handling.
2748         * ppc-linux-tdep.c: Use C++ exception handling.
2749         * parse.c: Use C++ exception handling.
2750         * p-valprint.c: Use C++ exception handling.
2751         * objc-lang.c: Use C++ exception handling.
2752         * mi/mi-main.c: Use C++ exception handling.
2753         * mi/mi-interp.c: Use C++ exception handling.
2754         * mi/mi-cmd-stack.c: Use C++ exception handling.
2755         * mi/mi-cmd-break.c: Use C++ exception handling.
2756         * main.c: Use C++ exception handling.
2757         * linux-thread-db.c: Use C++ exception handling.
2758         * linux-tdep.c: Use C++ exception handling.
2759         * linux-nat.c: Use C++ exception handling.
2760         * linux-fork.c: Use C++ exception handling.
2761         * linespec.c: Use C++ exception handling.
2762         * language.c: Use C++ exception handling.
2763         * jit.c: Use C++ exception handling.
2764         * infrun.c: Use C++ exception handling.
2765         * infcmd.c: Use C++ exception handling.
2766         * infcall.c: Use C++ exception handling.
2767         * inf-loop.c: Use C++ exception handling.
2768         * i386-tdep.c: Use C++ exception handling.
2769         * i386-linux-tdep.c: Use C++ exception handling.
2770         * guile/scm-value.c: Use C++ exception handling.
2771         * guile/scm-type.c: Use C++ exception handling.
2772         * guile/scm-symtab.c: Use C++ exception handling.
2773         * guile/scm-symbol.c: Use C++ exception handling.
2774         * guile/scm-pretty-print.c: Use C++ exception handling.
2775         * guile/scm-ports.c: Use C++ exception handling.
2776         * guile/scm-param.c: Use C++ exception handling.
2777         * guile/scm-math.c: Use C++ exception handling.
2778         * guile/scm-lazy-string.c: Use C++ exception handling.
2779         * guile/scm-frame.c: Use C++ exception handling.
2780         * guile/scm-disasm.c: Use C++ exception handling.
2781         * guile/scm-cmd.c: Use C++ exception handling.
2782         * guile/scm-breakpoint.c: Use C++ exception handling.
2783         * guile/scm-block.c: Use C++ exception handling.
2784         * guile/guile-internal.h: Use C++ exception handling.
2785         * gnu-v3-abi.c: Use C++ exception handling.
2786         * gdbtypes.c: Use C++ exception handling.
2787         * frame.c: Use C++ exception handling.
2788         * frame-unwind.c: Use C++ exception handling.
2789         * fbsd-tdep.c: Use C++ exception handling.
2790         * f-valprint.c: Use C++ exception handling.
2791         * exec.c: Use C++ exception handling.
2792         * event-top.c: Use C++ exception handling.
2793         * event-loop.c: Use C++ exception handling.
2794         * eval.c: Use C++ exception handling.
2795         * dwarf2read.c: Use C++ exception handling.
2796         * dwarf2loc.c: Use C++ exception handling.
2797         * dwarf2-frame.c: Use C++ exception handling.
2798         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2799         * dwarf-index-write.c: Use C++ exception handling.
2800         * dwarf-index-cache.c: Use C++ exception handling.
2801         * dtrace-probe.c: Use C++ exception handling.
2802         * disasm-selftests.c: Use C++ exception handling.
2803         * darwin-nat.c: Use C++ exception handling.
2804         * cp-valprint.c: Use C++ exception handling.
2805         * cp-support.c: Use C++ exception handling.
2806         * cp-abi.c: Use C++ exception handling.
2807         * corelow.c: Use C++ exception handling.
2808         * completer.c: Use C++ exception handling.
2809         * compile/compile-object-run.c: Use C++ exception handling.
2810         * compile/compile-object-load.c: Use C++ exception handling.
2811         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2812         * compile/compile-c-symbols.c: Use C++ exception handling.
2813         * common/selftest.c: Use C++ exception handling.
2814         * common/new-op.c: Use C++ exception handling.
2815         * cli/cli-script.c: Use C++ exception handling.
2816         * cli/cli-interp.c: Use C++ exception handling.
2817         * cli/cli-cmds.c: Use C++ exception handling.
2818         * c-varobj.c: Use C++ exception handling.
2819         * btrace.c: Use C++ exception handling.
2820         * breakpoint.c: Use C++ exception handling.
2821         * break-catch-throw.c: Use C++ exception handling.
2822         * arch-utils.c: Use C++ exception handling.
2823         * amd64-tdep.c: Use C++ exception handling.
2824         * ada-valprint.c: Use C++ exception handling.
2825         * ada-typeprint.c: Use C++ exception handling.
2826         * ada-lang.c: Use C++ exception handling.
2827         * aarch64-tdep.c: Use C++ exception handling.
2828
2829 2019-04-08  Tom Tromey  <tom@tromey.com>
2830
2831         * xml-support.c (gdb_xml_parser::parse): Update.
2832         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2833         * value.c (show_convenience): Update.
2834         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2835         (test_parse_flags_qcs): Update.
2836         * thread.c (thr_try_catch_cmd): Update.
2837         * target.c (target_translate_tls_address): Update.
2838         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2839         (info_frame_command_core, frame_apply_command_count): Update.
2840         * rust-exp.y (rust_lex_exception_test): Update.
2841         * riscv-tdep.c (riscv_print_one_register_info): Update.
2842         * remote.c (remote_target::enable_btrace): Update.
2843         * record-btrace.c (record_btrace_enable_warn): Update.
2844         * python/py-utils.c (gdbpy_convert_exception): Update.
2845         * printcmd.c (do_one_display, print_variable_and_value): Update.
2846         * mi/mi-main.c (mi_print_exception): Update.
2847         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2848         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2849         * linux-nat.c (linux_nat_target::attach): Update.
2850         * linux-fork.c (class scoped_switch_fork_info): Update.
2851         * infrun.c (displaced_step_prepare): Update.
2852         * infcall.c (call_function_by_hand_dummy): Update.
2853         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2854         * gnu-v3-abi.c (print_one_vtable): Update.
2855         * frame.c (get_prev_frame_always): Update.
2856         * f-valprint.c (info_common_command_for_block): Update.
2857         * exec.c (try_open_exec_file): Update.
2858         * exceptions.c (print_exception, exception_print)
2859         (exception_fprintf, exception_print_same): Update.
2860         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2861         * dwarf-index-cache.c (index_cache::store)
2862         (index_cache::lookup_gdb_index): Update.
2863         * darwin-nat.c (maybe_cache_shell): Update.
2864         * cp-valprint.c (cp_print_value_fields): Update.
2865         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2866         (gcc_cplus_symbol_address): Update.
2867         * compile/compile-c-symbols.c (gcc_convert_symbol)
2868         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2869         * common/selftest.c: Update.
2870         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2871         a std::string.
2872         (exception_try_scope_entry, exception_try_scope_exit): Don't
2873         declare.
2874         (struct exception_try_scope): Remove.
2875         (TRY): Don't use exception_try_scope.
2876         (struct gdb_exception): Add constructor, operator=.
2877         <what>: New method.
2878         (struct gdb_exception_RETURN_MASK_ALL)
2879         (struct gdb_exception_RETURN_MASK_ERROR)
2880         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2881         (struct gdb_quit_bad_alloc): Update.
2882         * common/common-exceptions.c (exception_none): Change
2883         initializer.
2884         (struct catcher) <state, exception>: Initialize inline.
2885         <prev>: Remove member.
2886         (current_catcher): Remove.
2887         (catchers): New global.
2888         (exceptions_state_mc_init): Simplify.
2889         (catcher_pop): Remove.
2890         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2891         (try_scope_depth, exception_try_scope_entry)
2892         (exception_try_scope_exit): Remove.
2893         (throw_exception_sjlj): Update.
2894         (exception_messages, exception_messages_size): Remove.
2895         (throw_it): Simplify.
2896         (gdb_exception_sliced_copy): Remove.
2897         (throw_exception_cxx): Update.
2898         * cli/cli-script.c (script_from_file): Update.
2899         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2900         Update.
2901         * ada-valprint.c (ada_val_print): Update.
2902         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2903         (create_excep_cond_exprs): Update.
2904
2905 2019-04-08  Tom Tromey  <tom@tromey.com>
2906
2907         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2908         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2909         (TRY, CATCH, END_CATCH): Remove some definitions.
2910         * common/common-exceptions.c: Don't use GDB_XCPT.
2911         (catcher_list_size): Remove.
2912         (throw_exception, throw_it): Simplify.
2913
2914 2019-04-05  Tom Tromey  <tom@tromey.com>
2915
2916         Revert the header-sorting patch.
2917         * ft32-tdep.c: Revert.
2918         * frv-tdep.c: Revert.
2919         * frv-linux-tdep.c: Revert.
2920         * frame.c: Revert.
2921         * frame-unwind.c: Revert.
2922         * frame-base.c: Revert.
2923         * fork-child.c: Revert.
2924         * findvar.c: Revert.
2925         * findcmd.c: Revert.
2926         * filesystem.c: Revert.
2927         * filename-seen-cache.h: Revert.
2928         * filename-seen-cache.c: Revert.
2929         * fbsd-tdep.c: Revert.
2930         * fbsd-nat.h: Revert.
2931         * fbsd-nat.c: Revert.
2932         * f-valprint.c: Revert.
2933         * f-typeprint.c: Revert.
2934         * f-lang.c: Revert.
2935         * extension.h: Revert.
2936         * extension.c: Revert.
2937         * extension-priv.h: Revert.
2938         * expprint.c: Revert.
2939         * exec.h: Revert.
2940         * exec.c: Revert.
2941         * exceptions.c: Revert.
2942         * event-top.c: Revert.
2943         * event-loop.c: Revert.
2944         * eval.c: Revert.
2945         * elfread.c: Revert.
2946         * dwarf2read.h: Revert.
2947         * dwarf2read.c: Revert.
2948         * dwarf2loc.c: Revert.
2949         * dwarf2expr.h: Revert.
2950         * dwarf2expr.c: Revert.
2951         * dwarf2-frame.c: Revert.
2952         * dwarf2-frame-tailcall.c: Revert.
2953         * dwarf-index-write.h: Revert.
2954         * dwarf-index-write.c: Revert.
2955         * dwarf-index-common.c: Revert.
2956         * dwarf-index-cache.h: Revert.
2957         * dwarf-index-cache.c: Revert.
2958         * dummy-frame.c: Revert.
2959         * dtrace-probe.c: Revert.
2960         * disasm.h: Revert.
2961         * disasm.c: Revert.
2962         * disasm-selftests.c: Revert.
2963         * dictionary.c: Revert.
2964         * dicos-tdep.c: Revert.
2965         * demangle.c: Revert.
2966         * dcache.h: Revert.
2967         * dcache.c: Revert.
2968         * darwin-nat.h: Revert.
2969         * darwin-nat.c: Revert.
2970         * darwin-nat-info.c: Revert.
2971         * d-valprint.c: Revert.
2972         * d-namespace.c: Revert.
2973         * d-lang.c: Revert.
2974         * ctf.c: Revert.
2975         * csky-tdep.c: Revert.
2976         * csky-linux-tdep.c: Revert.
2977         * cris-tdep.c: Revert.
2978         * cris-linux-tdep.c: Revert.
2979         * cp-valprint.c: Revert.
2980         * cp-support.c: Revert.
2981         * cp-namespace.c: Revert.
2982         * cp-abi.c: Revert.
2983         * corelow.c: Revert.
2984         * corefile.c: Revert.
2985         * continuations.c: Revert.
2986         * completer.h: Revert.
2987         * completer.c: Revert.
2988         * complaints.c: Revert.
2989         * coffread.c: Revert.
2990         * coff-pe-read.c: Revert.
2991         * cli-out.h: Revert.
2992         * cli-out.c: Revert.
2993         * charset.c: Revert.
2994         * c-varobj.c: Revert.
2995         * c-valprint.c: Revert.
2996         * c-typeprint.c: Revert.
2997         * c-lang.c: Revert.
2998         * buildsym.c: Revert.
2999         * buildsym-legacy.c: Revert.
3000         * build-id.h: Revert.
3001         * build-id.c: Revert.
3002         * btrace.c: Revert.
3003         * bsd-uthread.c: Revert.
3004         * breakpoint.h: Revert.
3005         * breakpoint.c: Revert.
3006         * break-catch-throw.c: Revert.
3007         * break-catch-syscall.c: Revert.
3008         * break-catch-sig.c: Revert.
3009         * blockframe.c: Revert.
3010         * block.c: Revert.
3011         * bfin-tdep.c: Revert.
3012         * bfin-linux-tdep.c: Revert.
3013         * bfd-target.c: Revert.
3014         * bcache.c: Revert.
3015         * ax-general.c: Revert.
3016         * ax-gdb.h: Revert.
3017         * ax-gdb.c: Revert.
3018         * avr-tdep.c: Revert.
3019         * auxv.c: Revert.
3020         * auto-load.c: Revert.
3021         * arm-wince-tdep.c: Revert.
3022         * arm-tdep.c: Revert.
3023         * arm-symbian-tdep.c: Revert.
3024         * arm-pikeos-tdep.c: Revert.
3025         * arm-obsd-tdep.c: Revert.
3026         * arm-nbsd-tdep.c: Revert.
3027         * arm-nbsd-nat.c: Revert.
3028         * arm-linux-tdep.c: Revert.
3029         * arm-linux-nat.c: Revert.
3030         * arm-fbsd-tdep.c: Revert.
3031         * arm-fbsd-nat.c: Revert.
3032         * arm-bsd-tdep.c: Revert.
3033         * arch-utils.c: Revert.
3034         * arc-tdep.c: Revert.
3035         * arc-newlib-tdep.c: Revert.
3036         * annotate.h: Revert.
3037         * annotate.c: Revert.
3038         * amd64-windows-tdep.c: Revert.
3039         * amd64-windows-nat.c: Revert.
3040         * amd64-tdep.c: Revert.
3041         * amd64-sol2-tdep.c: Revert.
3042         * amd64-obsd-tdep.c: Revert.
3043         * amd64-obsd-nat.c: Revert.
3044         * amd64-nbsd-tdep.c: Revert.
3045         * amd64-nbsd-nat.c: Revert.
3046         * amd64-nat.c: Revert.
3047         * amd64-linux-tdep.c: Revert.
3048         * amd64-linux-nat.c: Revert.
3049         * amd64-fbsd-tdep.c: Revert.
3050         * amd64-fbsd-nat.c: Revert.
3051         * amd64-dicos-tdep.c: Revert.
3052         * amd64-darwin-tdep.c: Revert.
3053         * amd64-bsd-nat.c: Revert.
3054         * alpha-tdep.c: Revert.
3055         * alpha-obsd-tdep.c: Revert.
3056         * alpha-nbsd-tdep.c: Revert.
3057         * alpha-mdebug-tdep.c: Revert.
3058         * alpha-linux-tdep.c: Revert.
3059         * alpha-linux-nat.c: Revert.
3060         * alpha-bsd-tdep.c: Revert.
3061         * alpha-bsd-nat.c: Revert.
3062         * aix-thread.c: Revert.
3063         * agent.c: Revert.
3064         * addrmap.c: Revert.
3065         * ada-varobj.c: Revert.
3066         * ada-valprint.c: Revert.
3067         * ada-typeprint.c: Revert.
3068         * ada-tasks.c: Revert.
3069         * ada-lang.c: Revert.
3070         * aarch64-tdep.c: Revert.
3071         * aarch64-ravenscar-thread.c: Revert.
3072         * aarch64-newlib-tdep.c: Revert.
3073         * aarch64-linux-tdep.c: Revert.
3074         * aarch64-linux-nat.c: Revert.
3075         * aarch64-fbsd-tdep.c: Revert.
3076         * aarch64-fbsd-nat.c: Revert.
3077         * aarch32-linux-nat.c: Revert.
3078
3079 2019-04-05  Tom Tromey  <tom@tromey.com>
3080
3081         * ft32-tdep.c: Sort headers.
3082         * frv-tdep.c: Sort headers.
3083         * frv-linux-tdep.c: Sort headers.
3084         * frame.c: Sort headers.
3085         * frame-unwind.c: Sort headers.
3086         * frame-base.c: Sort headers.
3087         * fork-child.c: Sort headers.
3088         * findvar.c: Sort headers.
3089         * findcmd.c: Sort headers.
3090         * filesystem.c: Sort headers.
3091         * filename-seen-cache.h: Sort headers.
3092         * filename-seen-cache.c: Sort headers.
3093         * fbsd-tdep.c: Sort headers.
3094         * fbsd-nat.h: Sort headers.
3095         * fbsd-nat.c: Sort headers.
3096         * f-valprint.c: Sort headers.
3097         * f-typeprint.c: Sort headers.
3098         * f-lang.c: Sort headers.
3099         * extension.h: Sort headers.
3100         * extension.c: Sort headers.
3101         * extension-priv.h: Sort headers.
3102         * expprint.c: Sort headers.
3103         * exec.h: Sort headers.
3104         * exec.c: Sort headers.
3105         * exceptions.c: Sort headers.
3106         * event-top.c: Sort headers.
3107         * event-loop.c: Sort headers.
3108         * eval.c: Sort headers.
3109         * elfread.c: Sort headers.
3110         * dwarf2read.h: Sort headers.
3111         * dwarf2read.c: Sort headers.
3112         * dwarf2loc.c: Sort headers.
3113         * dwarf2expr.h: Sort headers.
3114         * dwarf2expr.c: Sort headers.
3115         * dwarf2-frame.c: Sort headers.
3116         * dwarf2-frame-tailcall.c: Sort headers.
3117         * dwarf-index-write.h: Sort headers.
3118         * dwarf-index-write.c: Sort headers.
3119         * dwarf-index-common.c: Sort headers.
3120         * dwarf-index-cache.h: Sort headers.
3121         * dwarf-index-cache.c: Sort headers.
3122         * dummy-frame.c: Sort headers.
3123         * dtrace-probe.c: Sort headers.
3124         * disasm.h: Sort headers.
3125         * disasm.c: Sort headers.
3126         * disasm-selftests.c: Sort headers.
3127         * dictionary.c: Sort headers.
3128         * dicos-tdep.c: Sort headers.
3129         * demangle.c: Sort headers.
3130         * dcache.h: Sort headers.
3131         * dcache.c: Sort headers.
3132         * darwin-nat.h: Sort headers.
3133         * darwin-nat.c: Sort headers.
3134         * darwin-nat-info.c: Sort headers.
3135         * d-valprint.c: Sort headers.
3136         * d-namespace.c: Sort headers.
3137         * d-lang.c: Sort headers.
3138         * ctf.c: Sort headers.
3139         * csky-tdep.c: Sort headers.
3140         * csky-linux-tdep.c: Sort headers.
3141         * cris-tdep.c: Sort headers.
3142         * cris-linux-tdep.c: Sort headers.
3143         * cp-valprint.c: Sort headers.
3144         * cp-support.c: Sort headers.
3145         * cp-namespace.c: Sort headers.
3146         * cp-abi.c: Sort headers.
3147         * corelow.c: Sort headers.
3148         * corefile.c: Sort headers.
3149         * continuations.c: Sort headers.
3150         * completer.h: Sort headers.
3151         * completer.c: Sort headers.
3152         * complaints.c: Sort headers.
3153         * coffread.c: Sort headers.
3154         * coff-pe-read.c: Sort headers.
3155         * cli-out.h: Sort headers.
3156         * cli-out.c: Sort headers.
3157         * charset.c: Sort headers.
3158         * c-varobj.c: Sort headers.
3159         * c-valprint.c: Sort headers.
3160         * c-typeprint.c: Sort headers.
3161         * c-lang.c: Sort headers.
3162         * buildsym.c: Sort headers.
3163         * buildsym-legacy.c: Sort headers.
3164         * build-id.h: Sort headers.
3165         * build-id.c: Sort headers.
3166         * btrace.c: Sort headers.
3167         * bsd-uthread.c: Sort headers.
3168         * breakpoint.h: Sort headers.
3169         * breakpoint.c: Sort headers.
3170         * break-catch-throw.c: Sort headers.
3171         * break-catch-syscall.c: Sort headers.
3172         * break-catch-sig.c: Sort headers.
3173         * blockframe.c: Sort headers.
3174         * block.c: Sort headers.
3175         * bfin-tdep.c: Sort headers.
3176         * bfin-linux-tdep.c: Sort headers.
3177         * bfd-target.c: Sort headers.
3178         * bcache.c: Sort headers.
3179         * ax-general.c: Sort headers.
3180         * ax-gdb.h: Sort headers.
3181         * ax-gdb.c: Sort headers.
3182         * avr-tdep.c: Sort headers.
3183         * auxv.c: Sort headers.
3184         * auto-load.c: Sort headers.
3185         * arm-wince-tdep.c: Sort headers.
3186         * arm-tdep.c: Sort headers.
3187         * arm-symbian-tdep.c: Sort headers.
3188         * arm-pikeos-tdep.c: Sort headers.
3189         * arm-obsd-tdep.c: Sort headers.
3190         * arm-nbsd-tdep.c: Sort headers.
3191         * arm-nbsd-nat.c: Sort headers.
3192         * arm-linux-tdep.c: Sort headers.
3193         * arm-linux-nat.c: Sort headers.
3194         * arm-fbsd-tdep.c: Sort headers.
3195         * arm-fbsd-nat.c: Sort headers.
3196         * arm-bsd-tdep.c: Sort headers.
3197         * arch-utils.c: Sort headers.
3198         * arc-tdep.c: Sort headers.
3199         * arc-newlib-tdep.c: Sort headers.
3200         * annotate.h: Sort headers.
3201         * annotate.c: Sort headers.
3202         * amd64-windows-tdep.c: Sort headers.
3203         * amd64-windows-nat.c: Sort headers.
3204         * amd64-tdep.c: Sort headers.
3205         * amd64-sol2-tdep.c: Sort headers.
3206         * amd64-obsd-tdep.c: Sort headers.
3207         * amd64-obsd-nat.c: Sort headers.
3208         * amd64-nbsd-tdep.c: Sort headers.
3209         * amd64-nbsd-nat.c: Sort headers.
3210         * amd64-nat.c: Sort headers.
3211         * amd64-linux-tdep.c: Sort headers.
3212         * amd64-linux-nat.c: Sort headers.
3213         * amd64-fbsd-tdep.c: Sort headers.
3214         * amd64-fbsd-nat.c: Sort headers.
3215         * amd64-dicos-tdep.c: Sort headers.
3216         * amd64-darwin-tdep.c: Sort headers.
3217         * amd64-bsd-nat.c: Sort headers.
3218         * alpha-tdep.c: Sort headers.
3219         * alpha-obsd-tdep.c: Sort headers.
3220         * alpha-nbsd-tdep.c: Sort headers.
3221         * alpha-mdebug-tdep.c: Sort headers.
3222         * alpha-linux-tdep.c: Sort headers.
3223         * alpha-linux-nat.c: Sort headers.
3224         * alpha-bsd-tdep.c: Sort headers.
3225         * alpha-bsd-nat.c: Sort headers.
3226         * aix-thread.c: Sort headers.
3227         * agent.c: Sort headers.
3228         * addrmap.c: Sort headers.
3229         * ada-varobj.c: Sort headers.
3230         * ada-valprint.c: Sort headers.
3231         * ada-typeprint.c: Sort headers.
3232         * ada-tasks.c: Sort headers.
3233         * ada-lang.c: Sort headers.
3234         * aarch64-tdep.c: Sort headers.
3235         * aarch64-ravenscar-thread.c: Sort headers.
3236         * aarch64-newlib-tdep.c: Sort headers.
3237         * aarch64-linux-tdep.c: Sort headers.
3238         * aarch64-linux-nat.c: Sort headers.
3239         * aarch64-fbsd-tdep.c: Sort headers.
3240         * aarch64-fbsd-nat.c: Sort headers.
3241         * aarch32-linux-nat.c: Sort headers.
3242
3243 2019-04-04  Tom Tromey  <tom@tromey.com>
3244
3245         * varobj.c (varobj_create): Update.
3246         * rust-exp.y (struct rust_parser) <update_innermost_block,
3247         lookup_symbol>: New methods.
3248         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3249         Rename.
3250         (rust_parser::rust_lookup_type)
3251         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3252         * printcmd.c (display_command, do_one_display): Update.
3253         * parser-defs.h (struct parser_state) <parser_state>: Add
3254         "tracker" parameter.
3255         (block_tracker): New member.
3256         (class innermost_block_tracker) <innermost_block_tracker>: Add
3257         "types" parameter.
3258         <reset>: Remove method.
3259         (innermost_block): Don't declare.
3260         (null_post_parser): Update.
3261         * parse.c (innermost_block): Remove global.
3262         (write_dollar_variable): Update.
3263         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3264         Remove "tracker_types" parameter.
3265         (parse_expression): Add "tracker" parameter.
3266         (parse_expression_for_completion): Update.
3267         (null_post_parser): Add "tracker" parameter.
3268         * p-exp.y: Update rules.
3269         * m2-exp.y: Update rules.
3270         * language.h (struct language_defn) <la_post_parser>: Add
3271         "tracker" parameter.
3272         * go-exp.y: Update rules.
3273         * f-exp.y: Update rules.
3274         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3275         parameter.
3276         * d-exp.y: Update rules.
3277         * c-exp.y: Update rules.
3278         * breakpoint.c (set_breakpoint_condition): Create an
3279         innermost_block_tracker.
3280         (watch_command_1): Likewise.
3281         * ada-lang.c (resolve): Add "tracker" parameter.
3282         (resolve_subexp): Likewise.
3283         * ada-exp.y (write_var_from_sym): Update.
3284
3285 2019-04-04  Tom Tromey  <tom@tromey.com>
3286
3287         * type-stack.h: New file.
3288         * type-stack.c: New file.
3289         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3290         type-stack.h.
3291         (insert_into_type_stack, insert_type, push_type, push_type_int)
3292         (insert_type_address_space, pop_type, pop_type_int)
3293         (pop_typelist, pop_type_stack, append_type_stack)
3294         (push_type_stack, get_type_stack, push_typelist)
3295         (follow_type_instance_flags, follow_types): Don't declare.
3296         * parse.c (type_stack): Remove global.
3297         (parse_exp_in_context): Update.
3298         (insert_into_type_stack, insert_type, push_type, push_type_int)
3299         (insert_type_address_space, pop_type, pop_type_int)
3300         (pop_typelist, pop_type_stack, append_type_stack)
3301         (push_type_stack, get_type_stack, push_typelist)
3302         (follow_type_instance_flags, follow_types): Remove (moved to
3303         type-stack.c).
3304         * f-exp.y (type_stack): New global.
3305         Update rules.
3306         (push_kind_type, f_parse): Update.
3307         * d-exp.y (type_stack): New global.
3308         Update rules.
3309         (d_parse): Update.
3310         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3311         Update rules.
3312         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3313         (HFILES_NO_SRCDIR): Add type-stack.h.
3314
3315 2019-04-04  Tom Tromey  <tom@tromey.com>
3316
3317         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3318         (rust_parser::convert_ast_to_expression, rust_parse)
3319         (rust_lex_test_completion, rust_lex_tests): Update.
3320         * parser-defs.h (struct expr_completion_state): New.
3321         (struct parser_state) <parser_state>: Add completion parameter.
3322         <mark_struct_expression, mark_completion_tag>: New methods.
3323         <parse_completion, m_completion_state>: New members.
3324         (prefixify_expression, null_post_parser): Update.
3325         (mark_struct_expression, mark_completion_tag): Don't declare.
3326         * parse.c (parse_completion, expout_last_struct)
3327         (expout_tag_completion_type, expout_completion_name): Remove
3328         globals.
3329         (parser_state::mark_struct_expression)
3330         (parser_state::mark_completion_tag): Now methods.
3331         (prefixify_expression): Add last_struct parameter.
3332         (prefixify_subexp): Likewise.
3333         (parse_exp_1): Update.
3334         (parse_exp_in_context): Add cstate parameter.  Update.
3335         (parse_expression_for_completion): Create an
3336         expr_completion_state.
3337         (null_post_parser): Add "completion" parameter.
3338         * p-exp.y: Update rules.
3339         (yylex): Update.
3340         * language.h (struct language_defn) <la_post_parser>: Add
3341         "completing" parameter.
3342         * go-exp.y: Update rules.
3343         (lex_one_token): Update.
3344         * expression.h (parse_completion): Don't declare.
3345         * d-exp.y: Update rules.
3346         (lex_one_token): Update rules.
3347         * c-exp.y: Update rules.
3348         (lex_one_token): Update.
3349         * ada-lang.c (resolve): Add "parse_completion" parameter.
3350         (resolve_subexp): Likewise.
3351         (ada_resolve_function): Likewise.
3352
3353 2019-04-04  Tom Tromey  <tom@tromey.com>
3354
3355         * parser-defs.h (struct parser_state) <start_arglist,
3356         end_arglist>: New methods.
3357         <arglist_len, m_funcall_chain>: New members.
3358         (arglist_len, start_arglist, end_arglist): Don't declare.
3359         * parse.c (arglist_len, funcall_chain): Remove global.
3360         (start_arglist, end_arglist): Remove functions.
3361         (parse_exp_in_context): Update.
3362         * p-exp.y: Update rules.
3363         * m2-exp.y: Update rules.
3364         * go-exp.y: Update rules.
3365         * f-exp.y: Update rules.
3366         * d-exp.y: Update rules.
3367         * c-exp.y: Update rules.
3368
3369 2019-04-04  Tom Tromey  <tom@tromey.com>
3370
3371         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3372         lex_operator, push_back>: New methods.
3373         Update all rules.
3374         (rust_parser::lex_hex, lex_escape): Rename and update.
3375         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3376         (rust_parser::lex_operator): Rename and update.
3377         (rust_parser::lex_number, rustyylex, rustyyerror)
3378         (rust_lex_test_init, rust_lex_test_sequence)
3379         (rust_lex_test_push_back, rust_lex_tests): Update.
3380         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3381         parameter.
3382         <lexptr, prev_lexptr>: New members.
3383         (lexptr, prev_lexptr): Don't declare.
3384         * parse.c (lexptr, prev_lexptr): Remove globals.
3385         (parse_exp_in_context): Update.
3386         * p-exp.y (yylex, yyerror): Update.
3387         * m2-exp.y (parse_number, yylex, yyerror): Update.
3388         * go-exp.y (lex_one_token, yyerror): Update.
3389         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3390         * d-exp.y (lex_one_token, yyerror): Update.
3391         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3392         (lex_one_token, yyerror): Update.
3393         * ada-lex.l (YY_INPUT): Update.
3394         (rewind_to_char): Update.
3395         * ada-exp.y (yyerror): Update.
3396
3397 2019-04-04  Tom Tromey  <tom@tromey.com>
3398
3399         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3400         * parser-defs.h (struct parser_state) <parser_state>: Add new
3401         parameter.
3402         <comma_terminates>: New member.
3403         (comma_terminates): Don't declare global.
3404         * parse.c (comma_terminates): Remove global.
3405         (parse_exp_in_context): Update.
3406         * p-exp.y (yylex): Update.
3407         * m2-exp.y (yylex): Update.
3408         * go-exp.y (lex_one_token): Update.
3409         * f-exp.y (yylex): Update.
3410         * d-exp.y (lex_one_token): Update.
3411         * c-exp.y (lex_one_token): Update.
3412         * ada-lex.l: Update.
3413
3414 2019-04-04  Tom Tromey  <tom@tromey.com>
3415
3416         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3417         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3418         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3419         * parser-defs.h (paren_depth): Don't declare.
3420         * parse.c (paren_depth): Remove global.
3421         (parse_exp_in_context): Update.
3422         * p-exp.y (paren_depth): New global.
3423         (pascal_parse): Initialize it.
3424         * m2-exp.y (paren_depth): New global.
3425         (m2_parse): Initialize it.
3426         * go-exp.y (paren_depth): New global.
3427         (go_parse): Initialize it.
3428         * f-exp.y (paren_depth): New global.
3429         (f_parse): Initialize it.
3430         * d-exp.y (paren_depth): New global.
3431         (d_parse): Initialize it.
3432         * c-exp.y (paren_depth): New global.
3433         (c_parse): Initialize it.
3434         * ada-lex.l (paren_depth): New global.
3435         (lexer_init): Initialize it.
3436
3437 2019-04-04  Tom Tromey  <tom@tromey.com>
3438
3439         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3440         (rust_parser::convert_ast_to_type)
3441         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3442         * parser-defs.h (struct parser_state) <parser_state>: Add
3443         parameters.  Initialize new members.
3444         <expression_context_block, expression_context_pc>: New members.
3445         * parse.c (expression_context_block, expression_context_pc):
3446         Remove globals.
3447         (parse_exp_in_context): Update.
3448         * p-exp.y: Update all rules.
3449         (yylex): Update.
3450         * m2-exp.y: Update all rules.
3451         (yylex): Update.
3452         * go-exp.y (yylex): Update.
3453         * f-exp.y (yylex): Update.
3454         * d-exp.y: Update all rules.
3455         (yylex): Update.
3456         * c-exp.y: Update all rules.
3457         (lex_one_token, classify_name, yylex, c_parse): Update.
3458         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3459
3460 2019-04-04  Tom Tromey  <tom@tromey.com>
3461
3462         * gdbarch.h, gdbarch.c: Rebuild.
3463         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3464         * stap-probe.h:
3465         (struct stap_parse_info): Replace "parser_state" with
3466         "expr_builder".
3467         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3468         (parser_state): New class.
3469         * parse.c (expr_builder): Rename.
3470         (expr_builder::release): Rename.
3471         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3472         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3473         (write_exp_elt_longcst, write_exp_elt_floatcst)
3474         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3475         (write_exp_string_vector, write_exp_bitstring)
3476         (write_exp_msymbol, mark_struct_expression)
3477         (write_dollar_variable)
3478         (insert_type_address_space, increase_expout_size): Replace
3479         "parser_state" with "expr_builder".
3480         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3481         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3482         "parser_state" with "expr_builder".
3483
3484 2019-04-04  Tom Tromey  <tom@tromey.com>
3485
3486         * rust-exp.y: Replace "parse_language" with method call.
3487         * p-exp.y:
3488         (yylex): Replace "parse_language" with method call.
3489         * m2-exp.y:
3490         (yylex): Replace "parse_language" with method call.
3491         * go-exp.y (classify_name): Replace "parse_language" with method
3492         call.
3493         * f-exp.y (yylex): Replace "parse_language" with method call.
3494         * d-exp.y (lex_one_token): Replace "parse_language" with method
3495         call.
3496         * c-exp.y:
3497         (lex_one_token, classify_name, yylex): Replace "parse_language"
3498         with method call.
3499         * ada-exp.y (find_primitive_type, type_char)
3500         (type_system_address): Replace "parse_language" with method call.
3501
3502 2019-04-04  Tom Tromey  <tom@tromey.com>
3503
3504         * rust-exp.y: Replace "parse_gdbarch" with method call.
3505         * parse.c (write_dollar_variable, insert_type_address_space):
3506         Replace "parse_gdbarch" with method call.
3507         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3508         call.
3509         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3510         call.
3511         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3512         "parse_gdbarch" with method call.
3513         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3514         with method call.
3515         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3516         "parse_gdbarch" with method call.
3517         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3518         "parse_gdbarch" with method call.
3519         * c-exp.y (parse_type, parse_number, classify_name): Replace
3520         "parse_gdbarch" with method call.
3521         * ada-lex.l: Replace "parse_gdbarch" with method call.
3522         * ada-exp.y (parse_type, find_primitive_type, type_char)
3523         (type_system_address): Replace "parse_gdbarch" with method call.
3524
3525 2019-04-04  Tom Tromey  <tom@tromey.com>
3526
3527         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3528         * stap-probe.c (stap_parse_argument): Update.
3529         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3530         initial_size parameter.
3531         * rust-exp.y (rust_lex_tests): Update.
3532         * parse.c (parser_state): Update.
3533         (parse_exp_in_context): Update.
3534         * parser-defs.h (struct parser_state) <parser_state>: Remove
3535         "initial_size" parameter.
3536
3537 2019-04-04  Tom Tromey  <tom@tromey.com>
3538
3539         * parser-defs.h (increase_expout_size): Don't declare.
3540         * parse.c (increase_expout_size): Now static.
3541
3542 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3543
3544         * gnu-nat.c (gnu_nat_target::wait): Fix
3545         target_waitstatus_to_string call.
3546
3547 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * eval.c (evaluate_subexp_standard): Handle internal functions
3550         during Fortran function call handling.
3551
3552 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3553
3554         * NEWS: Mention new internal functions.
3555         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3556         (read_base_type): Use dwarf2_init_complex_target_type.
3557         * value.c (creal_internal_fn): New function.
3558         (cimag_internal_fn): New function.
3559         (_initialize_values): Register new internal functions.
3560
3561 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3562
3563         * infrun.c (stop_all_threads): If debug_infrun, always
3564         trace the wait status after wait_one, using
3565         target_waitstatus_to_string and target_pid_to_str.
3566         (handle_inferior_event): Replace various trace of
3567         wait status kind by a single trace.
3568         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3569         wait status kind image by target_waitstatus_to_string.
3570         * target/waitstatus.c (target_waitstatus_to_string): Fix
3571         obsolete comment.
3572
3573 2019-04-01  Tom Tromey  <tromey@adacore.com>
3574
3575         PR symtab/23331:
3576         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3577
3578 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3579             Pedro Alves  <palves@redhat.com>
3580
3581         * top.c (quit_force): Call 'finalize_values'.
3582         * value.c (finalize_values): New function.
3583         * value.h (finalize_values): Declare.
3584
3585 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3586
3587         * NEWS: Announce $_gdb_major and $_gdb_minor.
3588
3589         * top.c (init_gdb_version_vars): New function.
3590         (gdb_init): Call init_gdb_version_vars.
3591
3592 2019-03-29  Tom Tromey  <tromey@adacore.com>
3593
3594         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3595         help text.  Remove dead code.
3596
3597 2019-03-29  Keith Seitz  <keiths@redhat.com>
3598
3599         From Siddhesh Poyarekar:
3600         * f-lang.h (f77_get_upperbound): Return LONGEST.
3601         (f77_get_lowerbound): Likewise.
3602         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3603         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3604         print them.
3605         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3606         plongest to format print it.
3607         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3608         (f77_get_upperbound): Likewise.
3609         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3610         LOWER_BOUND to LONGEST.
3611         (f77_create_arrayprint_offset_tbl): Likewise.
3612
3613 2019-03-29  Keith Seitz  <keiths@redhat.com>
3614
3615         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3616         %s/pulongest for TYPE_LENGTH instead of %d in format
3617         strings.
3618         * ada-typerint.c (ada_print_type): Likewise.
3619         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3620         * compile/compile-c-support.c (generate_register_struct): Likewise.
3621         * gdbtypes.c (recursive_dump_type): Likewise.
3622         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3623         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3624         instead of %d in format strings.
3625         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3626         to std::min to ULONGEST.
3627         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3628         instead of %d in format strings.
3629         * tracepoint.c (info_scope_command): Likewise.
3630         * typeprint.c (print_offset_data::update)
3631         (print_offset_data::finish): Likewise.
3632         * xtensa-tdep.c (xtensa_store_return_value)
3633         (xtensa_push_dummy_call): Likewise.
3634
3635 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3636
3637         * windows-nat.c (display_selector): Fixed format specifications
3638         for 64-bit Cygwin.
3639
3640 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3641
3642         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3643
3644 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3645
3646         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3647         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3648         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3649         (nios2_linux_init_abi): Install it.
3650
3651 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3652
3653         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3654
3655 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3656
3657         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3658
3659 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3660             Tom Tromey  <tromey@adacore.com>
3661
3662         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3663
3664 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3665
3666         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3667         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3668         method to compute the bounds of range types. Also print "[evaluated]"
3669         if the bounds' values come from a dynamic evaluation.
3670
3671 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3672
3673         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3674         whitespace when pretty printing is on.
3675
3676 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3677
3678         * ppc-linux-nat.c: Add include.
3679
3680 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3681
3682         * NEWS: Mention AArch64 Pointer Authentication.
3683
3684 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3685
3686         * arm-linux-nat.c: Add include.
3687
3688 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3689
3690         * source-cache.c (source_cache::get_source_lines): Re-read
3691         fullname after calling open_source_file.
3692
3693 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3694
3695         * NEWS: Mention TLS support for FreeBSD.
3696
3697 2019-03-25  Tom Tromey  <tromey@adacore.com>
3698
3699         * minsyms.c (BUNCH_SIZE): Update comment.
3700         (~minimal_symbol_reader): Remove old comment.
3701         (compact_minimal_symbols): Update comment.
3702         (minimal_symbol_reader::install): Remove old comment.  Update
3703         other comments.
3704
3705 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3706
3707         * s390-linux-nat.c: Add include.
3708
3709 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3710
3711         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3712         Call linux_get_hwcap.
3713         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3714         Likewise.
3715         (aarch64_linux_get_hwcap): Remove function.
3716         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3717         declaration.
3718         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3719         linux_get_hwcap.
3720         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3721         * linux-tdep.c (linux_get_hwcap): Add function.
3722         (linux_get_hwcap2): Likewise.
3723         * linux-tdep.h (linux_get_hwcap): Add declaration.
3724         (linux_get_hwcap2): Likewise.
3725         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3726         (ppc_linux_get_hwcap2): Likewise.
3727         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3728         linux_get_hwcap.
3729         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3730         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3731         (ppc_linux_nat_target::read_description): Likewise.
3732         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3733         * s390-linux-nat.c: Likewise.
3734         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3735
3736 2019-03-24  Tom Tromey  <tom@tromey.com>
3737
3738         * ada-lang.c (standard_lookup): Simplify initialization.
3739         (ada_lookup_symbol_nonlocal): Simplify return.
3740         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3741         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3742         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3743         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3744         initialization.
3745         * solib.c (solib_global_lookup): Simplify.
3746         * symtab.c (null_block_symbol): Remove.
3747         (symbol_cache_lookup): Simplify returns.
3748         (lookup_language_this): Simplify returns.
3749         (lookup_symbol_aux): Simplify return.
3750         (lookup_local_symbol): Simplify returns.
3751         (lookup_global_symbol_from_objfile): Simplify return.
3752         (lookup_symbol_in_objfile_symtabs)
3753         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3754         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3755         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3756         * cp-namespace.c (cp_lookup_bare_symbol)
3757         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3758         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3759         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3760         (cp_lookup_symbol_via_imports): Simplify initialization.
3761         (find_symbol_in_baseclass): Likewise.
3762         * symtab.h (null_block_symbol): Remove.
3763         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3764         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3765         (d_lookup_symbol_module): Likewise.
3766         (find_symbol_in_baseclass): Simplify initialization.
3767
3768 2019-03-24  Tom Tromey  <tom@tromey.com>
3769
3770         * expression.h: Don't include symtab.h.
3771         (struct block): Forward declare.
3772
3773 2019-03-24  Tom Tromey  <tom@tromey.com>
3774
3775         * c-exp.y (typebase): Remove casts.
3776         * gdbtypes.c (lookup_unsigned_typename, )
3777         (lookup_signed_typename): Remove cast.
3778         * eval.c (parse_to_comma_and_eval): Remove cast.
3779         * parse.c (write_dollar_variable): Remove cast.
3780         * block.h (struct block) <superblock>: Now const.
3781         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3782         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3783         (map_block): Make "block" const.
3784         * symfile.h (struct quick_symbol_functions)
3785         <map_matching_symbols>: Constify block argument to "callback".
3786         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3787         const.
3788         (find_pc_sect_compunit_symtab): Make "b" const.
3789         (find_symbol_at_address): Likewise.
3790         (search_symbols): Likewise.
3791         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3792         (dw2_debug_names_lookup_symbol): Likewise.
3793         (dw2_map_matching_symbols): Update.
3794         * p-valprint.c (pascal_val_print): Remove "block".
3795         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3796         (aux_add_nonlocal_symbols): Make "block" const.
3797         (resolve_subexp): Remove cast.
3798         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3799         const.
3800         (iterate_over_file_blocks): Likewise.
3801         * f-exp.y (%union) <bval>: Remove.
3802         * coffread.c (patch_opaque_types): Make "b" const.
3803         * spu-tdep.c (spu_catch_start): Make "block" const.
3804         * c-valprint.c (print_unpacked_pointer): Remove "block".
3805         * symmisc.c (dump_symtab_1): Make "b" const.
3806         (block_depth): Make "block" const.
3807         * d-exp.y (%union) <bval>: Remove.
3808         * cp-support.h (cp_lookup_rtti_type): Update.
3809         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3810         * psymtab.c (psym_lookup_symbol): Make "block" const.
3811         (maintenance_check_psymtabs): Make "b" const.
3812         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3813         (enumerate_locals, enumerate_args): Update.
3814         * python/py-symtab.c (stpy_global_block): Make "block" const.
3815         (stpy_static_block): Likewise.
3816         * inline-frame.c (block_starting_point_at): Make "new_block"
3817         const.
3818         * block.c (find_block_in_blockvector): Make return type const.
3819         (blockvector_for_pc_sect): Make "b" const.
3820         (find_block_in_blockvector): Make "b" const.
3821
3822 2019-03-23  Tom Tromey  <tom@tromey.com>
3823
3824         * varobj.c (varobj_create): Update.
3825         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3826         * printcmd.c (display_command, do_one_display): Don't reset
3827         innermost_block.
3828         * parser-defs.h (enum innermost_block_tracker_type): Move to
3829         expression.h.
3830         (innermost_block): Update comment.
3831         * parse.c (parse_exp_1): Add tracker_types parameter.
3832         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3833         tracker_types parameter.  Reset innermost_block.
3834         (parse_exp_in_context): Remove.
3835         (parse_expression_for_completion): Update.
3836         * objfiles.c (~objfile): Don't reset expression_context_block or
3837         innermost_block.
3838         * expression.h (enum innermost_block_tracker_type): Move from
3839         parser-defs.h.
3840         (parse_exp_1): Add tracker_types parameter.
3841         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3842         reset innermost_block.
3843
3844 2019-03-23  Tom Tromey  <tom@tromey.com>
3845
3846         * objfiles.h: Include bcache.h.
3847
3848 2019-03-23  Tom Tromey  <tom@tromey.com>
3849
3850         * linespec.c (get_current_search_block): Use
3851         scoped_restore_current_language.
3852         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3853
3854 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3855             Jiong Wang  <jiong.wang@arm.com>
3856
3857         * aarch64-linux-tdep.c
3858         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3859         section.
3860         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3861
3862 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3863             Jiong Wang  <jiong.wang@arm.com>
3864
3865         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3866         instructions.
3867         (aarch64_analyze_prologue_test): Add PACIASP test.
3868         (aarch64_prologue_prev_register): Unmask PC value.
3869
3870 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3871             Jiong Wang  <jiong.wang@arm.com>
3872
3873         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3874         (aarch64_dwarf2_prev_register): Unmask PC value.
3875         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3876         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3877         DW_CFA_AARCH64_negate_ra_state.
3878         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3879
3880 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3881             Jiong Wang  <jiong.wang@arm.com>
3882
3883         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3884         registers.
3885         (aarch64_pseudo_register_name): Likewise.
3886         (aarch64_pseudo_register_type): Likewise.
3887         (aarch64_pseudo_register_reggroup_p): Likewise.
3888         (aarch64_gdbarch_init): Add pauth registers.
3889         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3890         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3891         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3892         (struct gdbarch_tdep): Add regnum for ra_state.
3893
3894 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3895             Jiong Wang  <jiong.wang@arm.com>
3896
3897         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3898
3899 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3900             Jiong Wang  <jiong.wang@arm.com>
3901
3902         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3903         function.
3904         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3905         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3906         (aarch64_gdbarch_init): Add puth registers.
3907         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3908         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3909         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3910
3911 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3912             Jiong Wang  <jiong.wang@arm.com>
3913
3914         * aarch64-linux-nat.c
3915         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3916         * aarch64-linux-tdep.c
3917         (aarch64_linux_core_read_description): Likewise.
3918         (aarch64_linux_get_hwcap): New function.
3919         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3920         (aarch64_linux_get_hwcap): New declaration.
3921
3922 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3923             Jiong Wang  <jiong.wang@arm.com>
3924
3925         * aarch64-linux-nat.c
3926         (aarch64_linux_nat_target::read_description): Add pauth param.
3927         * aarch64-linux-tdep.c
3928         (aarch64_linux_core_read_description): Likewise.
3929         * aarch64-tdep.c (struct target_desc): Add in pauth.
3930         (aarch64_read_description): Add pauth param.
3931         (aarch64_gdbarch_init): Likewise.
3932         * aarch64-tdep.h (aarch64_read_description): Likewise.
3933         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3934         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3935         * features/Makefile: Add new files.
3936         * features/aarch64-pauth.c: New file.
3937         * features/aarch64-pauth.xml: New file.
3938
3939 2019-03-20  Tom Tromey  <tromey@adacore.com>
3940
3941         * infrun.c (handle_inferior_event): Rename from
3942         handle_inferior_event_1.  Create a scoped_value_mark.
3943         (handle_inferior_event): Remove.
3944
3945 2019-03-19  Tom Tromey  <tromey@adacore.com>
3946
3947         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3948         * infrun.h (print_stop_event): Add "displays" parameter.
3949         * infrun.c (print_stop_event): Add "displays" parameter.
3950
3951 2019-03-19  Pedro Alves  <palves@redhat.com>
3952
3953         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3954         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3955         to -1.  Fix TABs vs spaces.
3956         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3957         * tui/tui-out.h (tui_ui_out) Add intro comments.
3958         <m_line, m_start_of_line>: In-class initialize, and add describing
3959         comment.
3960
3961 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3962
3963         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3964         variable names.
3965         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3966
3967 2019-03-18  Pedro Alves  <palves@redhat.com>
3968             Eli Zaretskii <eliz@gnu.org>
3969
3970         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3971         m_line and m_start_of_line.
3972
3973 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3974
3975         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3976         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3977         it returns a newline.  This fixes a regression in TU mode, whereby
3978         the next line is output on the same screen line as the user input.
3979
3980 2019-03-18  Tom Tromey  <tromey@adacore.com>
3981
3982         * minsyms.c (minimal_symbol_reader::install): Remove call to
3983         obstack_blank.
3984
3985 2019-03-18  Pedro Alves  <palves@redhat.com>
3986
3987         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3988         New globals.
3989         (apply_style): New, factored out from ...
3990         (apply_ansi_escape): ... this.  Handle reverse video mode.
3991         (tui_set_reverse_mode): New function.
3992         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3993         * tui/tui-winsource.c (tui_show_source_line): Use
3994         tui_set_reverse_mode instead of setting A_STANDOUT.
3995         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3996         New setter methods.
3997
3998 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3999
4000         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4001         Handle tabs.
4002
4003 2019-03-18  Tom Tromey  <tromey@adacore.com>
4004
4005         * ada-lang.c (empty_array): Add "high" parameter.
4006         (ada_evaluate_subexp): Update.
4007
4008 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4009
4010         * unittests/string_view-selftests.c: Define
4011         _initialize_string_view_selftests unconditionally.
4012
4013 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4014
4015         PR gdb/24350
4016         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4017
4018 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4019
4020         PR gdb/24351
4021         * windows-nat.c (display_selector): Fix format specifiers.
4022
4023 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4024
4025         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4026         tui_refill_source_window instead of tui_refresh_win, to update the
4027         current execution line.  This fixes redisplay of the current line
4028         when stepping through the code with "next" or "step".
4029
4030 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4031
4032         * source-cache.c (source_cache::get_source_lines): Call
4033         find_source_lines to initialize s->nlines.  This fixes vertical
4034         scrolling of TUI source window when the DOWN arrow is pressed.
4035
4036 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4037
4038         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4039         linux-thread-db.c (_initialize_thread_db): Likewise.
4040
4041 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4042
4043         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4044         wclrtoeol in tui_show_source_line".  This reverts changes made in
4045         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4046
4047 2019-03-15  Tom Tromey  <tom@tromey.com>
4048
4049         * symtab.h (struct minimal_symbol): Derive from
4050         general_symbol_info.
4051         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4052         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4053         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4054         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4055         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4056         (MSYMBOL_SEARCH_NAME): Update.
4057         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4058         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4059         * minsyms.c (minimal_symbol_reader::record_full): Update.
4060
4061 2019-03-15  Tom Tromey  <tom@tromey.com>
4062
4063         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4064
4065 2019-03-15  Tom Tromey  <tom@tromey.com>
4066
4067         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4068         unique_xmalloc_ptr.
4069         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4070         Update.
4071         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4072         (build_minimal_symbol_hash_tables)
4073         (minimal_symbol_reader::install): Update.
4074
4075 2019-03-15  Tom Tromey  <tom@tromey.com>
4076
4077         * symtab.c (create_demangled_names_hash): Update.
4078         (symbol_set_names): Update.
4079         * objfiles.h (struct objfile_per_bfd_storage)
4080         <demangled_names_hash>: Now an htab_up.
4081         * objfiles.c (objfile_per_bfd_storage): Simplify.
4082
4083 2019-03-15  Tom Tromey  <tom@tromey.com>
4084
4085         * objfiles.h (struct objfile_per_bfd_storage): Declare
4086         destructor.
4087         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4088         New.
4089         (get_objfile_bfd_data): Use new.  Don't initialize
4090         language_of_main.
4091         (free_objfile_per_bfd_storage): Remove.
4092         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4093
4094 2019-03-15  Tom Tromey  <tom@tromey.com>
4095
4096         * symfile.c (reread_symbols): Update.
4097         * objfiles.c (objfile::objfile): Update.
4098         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4099         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4100         comment.
4101         (minimal_symbol_reader::install): Update.
4102         (terminate_minimal_symbol_table): Remove.
4103         * jit.c (jit_object_close_impl): Update.
4104
4105 2019-03-15  Tom Tromey  <tom@tromey.com>
4106
4107         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4108         initializations.
4109
4110 2019-03-15  Tom Tromey  <tom@tromey.com>
4111
4112         * objfiles.h (struct objfile_per_bfd_storage)
4113         <demangled_hash_languages>: Now a bitset.
4114         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4115         (lookup_minimal_symbol): Update.
4116
4117 2019-03-15  Tom Tromey  <tom@tromey.com>
4118
4119         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4120         Don't return the symbol.
4121         * coffread.c (record_minimal_symbol): Use record_full.
4122
4123 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4124
4125         The MS-Windows port of ncurses fails to switch to a color pair if
4126         one or both of the colors are the implicit default colors.  This
4127         change records the default colors when TUI is initialized, and
4128         then specifies them explicitly when a color pair uses the default
4129         colors.  This allows color styling in TUI mode on MS-Windows.
4130
4131         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4132         ncurses_norm_attr.
4133         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4134         colors in ncurses_norm_attr.
4135         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4136         "none", replace it with the default color recorded in
4137         ncurses_norm_attr.
4138
4139 2019-03-14  Tom Tromey  <tromey@adacore.com>
4140
4141         * source-cache.h (class source_cache) <get_source_lines>: Return
4142         std::string.
4143         * source-cache.c (source_cache::extract_lines): Handle case where
4144         first_pos==npos.  Return std::string.
4145         (source_cache::get_source_lines): Update.
4146
4147 2019-03-14  Tom Tromey  <tromey@adacore.com>
4148
4149         * NEWS: Add item for "style sources" commands.
4150         * source-cache.c (source_cache::get_source_lines): Check
4151         source_styling.
4152         * cli/cli-style.c (source_styling): New global.
4153         (_initialize_cli_style): Add "style sources" commands.
4154         (show_style_sources): New function.
4155         * cli/cli-style.h (source_styling): Declare.
4156
4157 2019-03-14  Pedro Alves  <palves@redhat.com>
4158             Tom Tromey  <tromey@adacore.com>
4159
4160         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4161         * tui/tui-winsource.c (tui_refill_source_window): New function,
4162         from...
4163         (tui_horizontal_source_scroll): ... here.  Move some logic.
4164         * cli/cli-style.c (set_style_enabled): Notify new observable.
4165         * tui/tui-hooks.c (tui_redisplay_source): New function.
4166         (tui_attach_detach_observers): Attach or detach
4167         tui_redisplay_source.
4168         * observable.h (source_styling_changed): New observable.
4169         * observable.c: Define source_styling_changed observable.
4170
4171 2019-03-13  Tom Tromey  <tromey@adacore.com>
4172
4173         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4174         (i386_gnu_nat_target::store_registers): Update.
4175         * target-debug.h (target_debug_print_std_string): New macro.
4176         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4177         * windows-tdep.c (display_one_tib): Update.
4178         * tui/tui-stack.c (tui_make_status_line): Update.
4179         * top.c (print_inferior_quit_action): Update.
4180         * thread.c (thr_try_catch_cmd): Update.
4181         (add_thread_with_info): Update.
4182         (thread_target_id_str): Update.
4183         (thr_try_catch_cmd): Update.
4184         (thread_command): Update.
4185         (thread_find_command): Update.
4186         * record-btrace.c (record_btrace_target::info_record)
4187         (record_btrace_resume_thread, record_btrace_target::resume)
4188         (record_btrace_cancel_resume, record_btrace_step_thread)
4189         (record_btrace_target::wait, record_btrace_target::wait)
4190         (record_btrace_target::wait, record_btrace_target::stop): Update.
4191         * progspace.c (print_program_space): Update.
4192         * process-stratum-target.c
4193         (process_stratum_target::thread_address_space): Update.
4194         * linux-fork.c (linux_fork_mourn_inferior)
4195         (detach_checkpoint_command, info_checkpoints_command)
4196         (linux_fork_context): Update.
4197         (linux_fork_detach): Update.
4198         (class scoped_switch_fork_info): Update.
4199         (delete_checkpoint_command): Update.
4200         * infrun.c (follow_fork_inferior): Update.
4201         (follow_fork_inferior): Update.
4202         (proceed_after_vfork_done): Update.
4203         (handle_vfork_child_exec_or_exit): Update.
4204         (follow_exec): Update.
4205         (displaced_step_prepare_throw): Update.
4206         (displaced_step_restore): Update.
4207         (start_step_over): Update.
4208         (resume_1): Update.
4209         (clear_proceed_status_thread): Update.
4210         (proceed): Update.
4211         (print_target_wait_results): Update.
4212         (do_target_wait): Update.
4213         (context_switch): Update.
4214         (stop_all_threads): Update.
4215         (restart_threads): Update.
4216         (finish_step_over): Update.
4217         (handle_signal_stop): Update.
4218         (switch_back_to_stepped_thread): Update.
4219         (keep_going_pass_signal): Update.
4220         (print_exited_reason): Update.
4221         (normal_stop): Update.
4222         * inferior.c (inferior_pid_to_str): Change return type.
4223         (print_selected_inferior): Update.
4224         (add_inferior): Update.
4225         (detach_inferior): Update.
4226         * dummy-frame.c (fprint_dummy_frames): Update.
4227         * dcache.c (dcache_info_1): Update.
4228         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4229         (btrace_fetch, btrace_clear): Update.
4230         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4231         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4232         type.
4233         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4234         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4235         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4236         * gdbarch.c, gdbarch.h: Rebuild.
4237         * gdbarch.sh (core_pid_to_str): Change return type.
4238         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4239         return type.
4240         (windows_nat_target::pid_to_str): Change return type.
4241         (windows_delete_thread): Update.
4242         (windows_nat_target::attach): Update.
4243         (windows_nat_target::files_info): Update.
4244         * target-delegates.c: Rebuild.
4245         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4246         return type.
4247         (sol_thread_target::pid_to_str): Change return type.
4248         * remote.c (class remote_target) <pid_to_str>: Change return
4249         type.
4250         (remote_target::pid_to_str): Change return type.
4251         (extended_remote_target::attach, remote_target::remote_stop_ns)
4252         (remote_target::remote_notif_remove_queued_reply)
4253         (remote_target::push_stop_reply, remote_target::disable_btrace):
4254         Update.
4255         (extended_remote_target::attach): Update.
4256         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4257         type.
4258         (gdbsim_target::pid_to_str): Change return type.
4259         * ravenscar-thread.c (struct ravenscar_thread_target)
4260         <pid_to_str>: Change return type.
4261         (ravenscar_thread_target::pid_to_str): Change return type.
4262         * procfs.c (class procfs_target) <pid_to_str>: Change return
4263         type.
4264         (procfs_target::pid_to_str): Change return type.
4265         (procfs_target::attach): Update.
4266         (procfs_target::detach): Update.
4267         (procfs_target::fetch_registers): Update.
4268         (procfs_target::store_registers): Update.
4269         (procfs_target::wait): Update.
4270         (procfs_target::files_info): Update.
4271         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4272         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4273         return type.
4274         (nto_procfs_target::pid_to_str): Change return type.
4275         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4276         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4277         return type.
4278         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4279         (exit_lwp): Update.
4280         (attach_proc_task_lwp_callback, get_detach_signal)
4281         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4282         (linux_nat_target::resume, wait_lwp, stop_callback)
4283         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4284         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4285         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4286         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4287         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4288         type.
4289         (inf_ptrace_target::attach): Update.
4290         (inf_ptrace_target::files_info): Update.
4291         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4292         type.
4293         (go32_nat_target::pid_to_str): Change return type.
4294         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4295         (gnu_nat_target::wait): Update.
4296         (gnu_nat_target::wait): Update.
4297         (gnu_nat_target::resume): Update.
4298         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4299         (fbsd_nat_target::wait): Update.
4300         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4301         type.
4302         (darwin_nat_target::attach): Update.
4303         * corelow.c (class core_target) <pid_to_str>: Change return type.
4304         (core_target::pid_to_str): Change return type.
4305         * target.c (normal_pid_to_str): Change return type.
4306         (default_pid_to_str): Likewise.
4307         (target_pid_to_str): Change return type.
4308         (target_translate_tls_address): Update.
4309         (target_announce_detach): Update.
4310         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4311         return type.
4312         (bsd_uthread_target::pid_to_str): Change return type.
4313         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4314         type.
4315         (bsd_kvm_target::pid_to_str): Change return type.
4316         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4317         return type.
4318         (aix_thread_target::pid_to_str): Change return type.
4319         * target.h (struct target_ops) <pid_to_str>: Change return type.
4320         (target_pid_to_str, normal_pid_to_str): Likewise.
4321         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4322         type.
4323         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4324         type.
4325         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4326         return type.
4327         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4328         type.
4329         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4330         type.
4331         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4332         return type.
4333
4334 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4335
4336         * NEWS: Mention that the new default MI version is 3.  Mention
4337         changes to the output of commands and events that deal with
4338         multi-location breakpoints.
4339         * breakpoint.c: Include "mi/mi-out.h".
4340         (print_one_breakpoint): Change output syntax if using MI version
4341         >= 3.
4342         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4343         New.
4344         (mi_multi_location_breakpoint_output_fixed): New.
4345         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4346         (mi_cmd_fix_multi_location_breakpoint_output): New.
4347         (mi_multi_location_breakpoint_output_fixed): New.
4348         * mi/mi-cmds.c (mi_cmds): Register command
4349         -fix-multi-location-breakpoint-output.
4350         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4351         interpreter "mi".
4352
4353 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4354
4355         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4356         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4357         instantiate mi_ui_out based on interpreter name.
4358         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4359         * mi/mi-main.c (mi_load_progress): Likewise.
4360
4361 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4362
4363         * NEWS: Combine separate "New targets" sections for 8.3.
4364
4365 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4366
4367         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4368         (ppcfbsd_init_abi): Install gdbarch
4369         "fetch_tls_load_module_address" and "get_thread_local_address"
4370         methods.
4371
4372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4373
4374         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4375         (riscv_fbsd_init_abi): Install gdbarch
4376         "fetch_tls_load_module_address" and "get_thread_local_address"
4377         methods.
4378
4379 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4380
4381         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4382         (i386fbsd_init_abi): Install gdbarch
4383         "fetch_tls_load_module_address" and "get_thread_local_address"
4384         methods.
4385
4386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4387
4388         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4389         (amd64fbsd_init_abi): Install gdbarch
4390         "fetch_tls_load_module_address" and "get_thread_local_address"
4391         methods.
4392
4393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4394
4395         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4396         (struct fbsd_pspace_data): New type.
4397         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4398         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4399         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4400         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4401         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4402
4403 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4404
4405         * gdbtypes.c (lookup_struct_elt): New function.
4406         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4407         * gdbtypes.h (struct struct_elt): New type.
4408         (lookup_struct_elt): New prototype.
4409
4410 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4411
4412         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4413         remove disabled code block.
4414
4415 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4416
4417         * gdbarch.sh (get_thread_local_address): New method.
4418         * gdbarch.h, gdbarch.c: Regenerate.
4419         * target.c (target_translate_tls_address): Use
4420         gdbarch_get_thread_local_address if present instead of
4421         target::get_thread_local_address.
4422
4423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4424
4425         * target.h (target::get_thread_local_address): Update comment.
4426
4427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4428
4429         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4430         objfile->separate_debug_objfile_backlink if not NULL.
4431
4432 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4433
4434         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4435         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4436         (amd64bsd_store_inferior_registers): Likewise.
4437         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4438         Enable segment base registers.
4439         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4440         PT_GETFSBASE and PT_GETGSBASE.
4441         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4442         PT_SETGSBASE.
4443         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4444         segment base registers.
4445         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4446
4447 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4448
4449         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4450         Update calls to i386_target_description to add 'segments'
4451         parameter.
4452         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4453         add segment base registers.
4454         * arch/i386.c (i386_create_target_description): Add 'segments'
4455         parameter to enable segment base registers.
4456         * arch/i386.h (i386_create_target_description): Likewise.
4457         * features/i386/32bit-segments.xml: New file.
4458         * features/i386/32bit-segments.c: Generate.
4459         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4460         call to i386_target_description to add 'segments' parameter.
4461         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4462         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4463         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4464         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4465         if feature is present.
4466         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4467         Add 'segments' parameter to call to i386_target_description.
4468         (i386_target_description): Add 'segments' parameter to enable
4469         segment base registers.
4470         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4471         to call to i386_target_description.
4472         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4473         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4474         Define I386_NUM_REGS.
4475         (i386_target_description): Add 'segments' parameter to enable
4476         segment base registers.
4477
4478 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4479
4480         PR/24325
4481         * source-cache.c: #undef open and close, to avoid unresolved
4482         externals during linking.
4483
4484 2019-03-12  Tom Tromey  <tromey@adacore.com>
4485
4486         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4487         const.  Add initializers.
4488         (_initialize_remote): Don't initialize ptid globals.
4489
4490 2019-03-12  Pedro Alves  <palves@redhat.com>
4491
4492         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4493
4494 2019-03-12  Pedro Alves  <palves@redhat.com>
4495
4496         * cp-name-parser.y (main): Remove unused 'len' variable.
4497
4498 2019-03-12  Tom Tromey  <tromey@adacore.com>
4499
4500         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4501         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4502
4503 2019-03-12  Tom Tromey  <tromey@adacore.com>
4504
4505         * linux-nat.c (iterate_over_lwps): Update.
4506         (stop_callback): Remove parameter.
4507         (stop_wait_callback, detach_callback, resume_set_callback)
4508         (select_singlestep_lwp_callback, set_ignore_sigint)
4509         (status_callback, resumed_callback, resume_clear_callback)
4510         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4511         data parameter.
4512         (linux_nat_target::detach, linux_nat_target::resume)
4513         (linux_stop_and_wait_all_lwps, select_event_lwp)
4514         (linux_nat_filter_event, linux_nat_wait_1)
4515         (linux_nat_target::kill, linux_nat_target::stop)
4516         (linux_nat_target::stop): Update.
4517         (linux_nat_resume_callback): Change type.
4518         (resume_stopped_resumed_lwps, count_events_callback)
4519         (select_event_lwp_callback): Likewise.
4520         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4521         * arm-linux-nat.c (struct update_registers_data): Remove.
4522         (update_registers_callback): Change type.
4523         (arm_linux_insert_hw_breakpoint1): Update.
4524         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4525         parameter.
4526         (x86_linux_dr_set_addr): Update.
4527         (x86_linux_dr_set_control): Update.
4528         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4529         (iterate_over_lwps): Use gdb::function_view.
4530         * nat/aarch64-linux-hw-point.c (struct
4531         aarch64_dr_update_callback_param): Remove.
4532         (debug_reg_change_callback): Change type.
4533         (aarch64_notify_debug_reg_change): Update.
4534         * s390-linux-nat.c (s390_refresh_per_info): Update.
4535
4536 2019-03-11  Tom Tromey  <tromey@adacore.com>
4537
4538         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4539         redundant assignment to "this_cu".
4540
4541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4542
4543         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4544
4545 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4546
4547         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4548         from...
4549         (rank_one_type): ... this.
4550
4551 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4552
4553         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4554         from...
4555         (rank_one_type): ... this.
4556
4557 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4558
4559         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4560         from...
4561         (rank_one_type): ... this.
4562
4563 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4564
4565         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4566         from...
4567         (rank_one_type): ... this.
4568
4569 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4570
4571         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4572         from...
4573         (rank_one_type): ... this.
4574
4575 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4576
4577         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4578         from...
4579         (rank_one_type): ... this.
4580
4581 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4582
4583         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4584         from...
4585         (rank_one_type): ... this.
4586
4587 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4588
4589         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4590         from...
4591         (rank_one_type): ... this.
4592
4593 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4594
4595         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4596         from...
4597         (rank_one_type): ... this.
4598
4599 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4600
4601         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4602         from...
4603         (rank_one_type): ... this.
4604
4605 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4606
4607         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4608         from...
4609         (rank_one_type): ... this.
4610
4611 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4612
4613         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4614         from...
4615         (rank_one_type): ... this.
4616
4617 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4618
4619         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4620         inferior-events' shows the example events.
4621
4622 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4623
4624         Support styling on native MS-Windows console
4625
4626         PR/24315
4627         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4628         on MS-Windows if $TERM is not defined.
4629
4630         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4631
4632         * posix-hdep.c (gdb_console_fputs):
4633         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4634         functions.
4635         * ui-file.h (gdb_console_fputs): Add prototype.
4636
4637         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4638         back to fputs only if the former returns zero.
4639
4640 2019-03-07  Tom Tromey  <tom@tromey.com>
4641
4642         * symmisc.c (print_symbol_bcache_statistics): Update.
4643         (print_objfile_statistics): Update.
4644         * symfile.c (allocate_symtab): Update.
4645         * stabsread.c: Don't include bcache.h.
4646         * psymtab.h (struct psymbol_bcache): Don't declare.
4647         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4648         (psymbol_bcache_init, psymbol_bcache_free)
4649         (psymbol_bcache_get_bcache): Don't declare.
4650         * psymtab.c (struct psymbol_bcache): Remove.
4651         (psymtab_storage::psymtab_storage): Update.
4652         (psymtab_storage::~psymtab_storage): Update.
4653         (psymbol_bcache_init, psymbol_bcache_free)
4654         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4655         (add_psymbol_to_bcache): Update.
4656         (allocate_psymtab): Update.
4657         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4658         macro_cache>: No longer pointers.
4659         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4660         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4661         * macrotab.c (macro_bcache): Update.
4662         * macroexp.c: Don't include bcache.h.
4663         * gdbtypes.c (check_types_worklist): Update.
4664         (types_deeply_equal): Remove TRY/CATCH.  Update.
4665         * elfread.c (elf_symtab_read): Update.
4666         * dwarf2read.c: Don't include bcache.h.
4667         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4668         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4669         (print_bcache_statistics, bcache_memory_used): Don't declare.
4670         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4671         methods.  Rename all data members.
4672         * bcache.c (struct bcache): Move to bcache.h.
4673         (bcache::expand_hash_table): Rename from expand_hash_table.
4674         (bcache): Remove.
4675         (bcache::insert): Rename from bcache_full.
4676         (bcache::compare): Rename from bcache_compare.
4677         (bcache_xmalloc): Remove.
4678         (bcache::~bcache): Rename from bcache_xfree.
4679         (bcache::print_statistics): Rename from print_bcache_statistics.
4680         (bcache::memory_used): Rename from bcache_memory_used.
4681
4682 2019-03-07  Pedro Alves  <palves@redhat.com>
4683
4684         * infrun.c (normal_stop): Also check for
4685         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4686
4687 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4688
4689         * f-lang.c (value_from_host_double): Moved to...
4690         * value.c (value_from_host_double): ...here.
4691         * value.h (value_from_host_double): Declare.
4692         * guile/scm-math.c (vlscm_convert_typed_number): Use
4693         value_from_host_double.
4694         (vlscm_convert_number): Likewise.
4695         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4696         * python/py-value.c (convert_value_from_python): Likewise.
4697
4698 2019-03-06  Tom Tromey  <tom@tromey.com>
4699
4700         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4701
4702 2019-03-06  Tom Tromey  <tom@tromey.com>
4703
4704         * utils.h (free_current_contents): Don't declare.
4705         * utils.c (free_current_contents): Remove.
4706
4707 2019-03-06  Tom Tromey  <tom@tromey.com>
4708
4709         * top.c (quit_force): Update.
4710         * main.c (captured_command_loop): Update.
4711         * common/new-op.c (operator new): Update.
4712         * common/common-exceptions.c (struct catcher)
4713         <save_cleanup_chain>: Remove member.
4714         (exceptions_state_mc_init): Update.
4715         (exception_try_scope_entry): Return nullptr.
4716         (exception_try_scope_exit, exception_rethrow)
4717         (throw_exception_sjlj, throw_exception_cxx): Update.
4718         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4719         (all_cleanups, do_cleanups, discard_cleanups)
4720         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4721         (restore_cleanups, restore_final_cleanups): Don't declare.
4722         (do_final_cleanups): Remove parameter.
4723         * common/cleanups.c (cleanup_chain, make_cleanup)
4724         (make_cleanup_dtor, all_cleanups, do_cleanups)
4725         (discard_my_cleanups, discard_cleanups)
4726         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4727         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4728         (null_cleanup): Remove.
4729         (do_final_cleanups): Remove parameter.
4730
4731 2019-03-06  Tom Tromey  <tom@tromey.com>
4732
4733         * remote.c (remote_target::remote_parse_stop_reply): Use
4734         unique_xmalloc_ptr.
4735
4736 2019-03-06  Tom Tromey  <tom@tromey.com>
4737
4738         * stabsread.c (struct stabs_field_info): Rename from field_info.
4739         <list, fnlist>: Add initializers.
4740         <obstack>: New member.
4741         (read_member_functions, read_struct_fields, read_baseclasses):
4742         Allocate on obstack.  Don't use cleanups.
4743         (read_one_struct_field, read_member_functions, read_struct_fields)
4744         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4745         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4746         (read_struct_type): Update.
4747
4748 2019-03-06  Tom Tromey  <tom@tromey.com>
4749
4750         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4751         * common/filestuff.h (make_cleanup_close): Don't declare.
4752         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4753         Remove.
4754
4755 2019-03-06  Tom Tromey  <tom@tromey.com>
4756
4757         * solib-aix.c: Use make_scope_exit.
4758
4759 2019-03-06  Tom Tromey  <tom@tromey.com>
4760
4761         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4762         Use make_scope_exit.
4763
4764 2019-03-06  Tom Tromey  <tom@tromey.com>
4765
4766         * solib-svr4.c (disable_probes_interface): Remove parameter.
4767         (svr4_handle_solib_event): Use make_scope_exit.
4768
4769 2019-03-06  Tom Tromey  <tom@tromey.com>
4770
4771         * remote.c (struct stop_reply_deleter): Remove.
4772         (stop_reply_up): Update.
4773         (struct stop_reply): Derive from notif_event.  Don't typedef.
4774         <regcache>: Now a std::vector.
4775         (stop_reply_xfree): Remove.
4776         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4777         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4778         (remote_target::discard_pending_stop_replies): Use delete.
4779         (remote_target::remote_parse_stop_reply): Update.
4780         (remote_target::process_stop_reply): Update.
4781         * remote-notif.h (struct notif_event): Add virtual destructor.
4782         Remove "dtr" member.
4783         (struct notif_client) <alloc_event>: Return a unique_ptr.
4784         (notif_event_xfree): Don't declare.
4785         (notif_event_up): New typedef.
4786         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4787         (notif_event_xfree, do_notif_event_xfree): Remove.
4788         (remote_notif_state_xfree): Update.
4789
4790 2019-03-06  Tom Tromey  <tom@tromey.com>
4791
4792         * infrun.c (displaced_step_clear_cleanup): Now a
4793         forward_scope_exit type.
4794         (displaced_step_prepare_throw): Update.
4795         (displaced_step_fixup): Update.
4796
4797 2019-03-06  Tom Tromey  <tom@tromey.com>
4798
4799         * inferior.h (class inferior): Update comment.
4800         * gdbthread.h (class thread_info): Update comment.
4801
4802 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4803             Tom Tromey  <tom@tromey.com>
4804
4805         * stabsread.h (struct stab_section_list): Remove.
4806         (coffstab_build_psymtabs): Update.
4807         * dbxread.c (symbuf_sections): Now a std::vector.
4808         (sect_idx): New global.
4809         (fill_symbuf): Update.
4810         (coffstab_build_psymtabs): Change type of stabsects parameter.
4811         Update.
4812         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4813         std::vector.
4814         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4815         (coff_locate_sections): Update.
4816         (coff_symfile_read): Remove cleanups.  Update.
4817         (init_stringtab): Add storage parameter.
4818         (free_stringtab, free_stringtab_cleanup): Remove.
4819         (init_lineno): Add storage parameter.
4820         (free_linetab, free_linetab_cleanup): Remove.
4821
4822 2019-03-06  Pedro Alves  <palves@redhat.com>
4823
4824         * linux-fork.c (fork_info::clobber_regs): Delete.
4825         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4826         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4827         comment.  Adjust.
4828         (scoped_switch_fork_info::scoped_switch_fork_info)
4829         (checkpoint_command, linux_fork_context): Adjust
4830         fork_save_infrun_state calls.
4831
4832 2019-03-06  Pedro Alves  <palves@redhat.com>
4833
4834         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4835         (inf_has_multiple_threads): Return 'bool' and rewrite using
4836         inferior_info::threads().
4837
4838 2019-03-06  Pedro Alves  <palves@redhat.com>
4839
4840         * linux-fork.c: Include <list>.
4841         (fork_list): Now a std::list instance.
4842         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4843         (forks_exist_p, find_last_fork): Adjust.
4844         (new_fork): Delete.
4845         (one_fork_p): New.
4846         (add_fork): Adjust.
4847         (free_fork): Delete, folded into fork_info::~fork_info().
4848         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4849         Adjust.
4850         (init_fork_list): Delete.
4851         (linux_fork_killall, linux_fork_mourn_inferior)
4852         (linux_fork_detach, info_checkpoints_command): Adjust.
4853         (_initialize_linux_fork): No longer call init_fork_list.
4854
4855 2019-03-06  Pedro Alves  <palves@redhat.com>
4856
4857         * linux-fork.c (new_fork): New, split out of ...
4858         (add_fork): ... this.  Return void.  Move "first fork" special
4859         case from here, to ...
4860         (checkpoint_command): ... here.
4861         * linux-linux.h (add_fork): Return void.
4862
4863 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4866
4867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4868             Chris January  <chris.january@arm.com>
4869             David Lecomber  <david.lecomber@arm.com>
4870
4871         * f-exp.y: New token, UNOP_INTRINSIC.
4872         (exp): New pattern using UNOP_INTRINSIC token.
4873         (f77_keywords): Add 'abs' keyword.
4874         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4875         (value_from_host_double): New function.
4876         (evaluate_subexp_f): Support UNOP_ABS.
4877
4878 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4881         types.
4882
4883 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4886         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4887         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4888
4889 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4892
4893 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4894             Chris January  <chris.january@arm.com>
4895
4896         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4897         * f-exp.y: Define 'KIND' token.
4898         (exp): New pattern for KIND expressions.
4899         (ptype): Handle types with a kind extension.
4900         (direct_abs_decl): Extend to spot kind extensions.
4901         (f77_keywords): Add 'kind' to the list.
4902         (push_kind_type): New function.
4903         (convert_to_kind_type): New function.
4904         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4905         * parse.c (operator_length_standard): Likewise.
4906         * parser-defs.h (enum type_pieces): Add tp_kind.
4907         * std-operator.def: Add UNOP_KIND.
4908
4909 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4910
4911         * f-exp.y (f_parse): Set yydebug.
4912
4913 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * f-lang.c (evaluate_subexp_f): New function.
4916         (exp_descriptor_f): New global.
4917         (f_language_defn): Use exp_descriptor_f instead of
4918         exp_descriptor_standard.
4919
4920 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * f-exp.y (struct token): Add comments.
4923         (dot_ops): Remove uppercase versions and the end marker.
4924         (f77_keywords): Likewise.
4925         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4926         entries in the dot_ops array are case insensitive, and use
4927         strncasecmp to compare strings.  Also some whitespace cleanup in
4928         this area.  Similar for the f77_keywords array, except entries in
4929         this list might be case sensitive.
4930
4931 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * f-exp.y (struct f77_boolean_val): Add comments.
4934         (boolean_values): Remove uppercase versions, and end marker.
4935         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4936         and use strncasecmp to achieve case insensitivity.  Additionally,
4937         perform whitespace cleanup around this code.
4938
4939 2019-03-06  Tom Tromey  <tromey@adacore.com>
4940
4941         * remote-sim.c (gdbsim_target_open): Use result of
4942         gdb_argv::release.
4943
4944 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4945         Dirk Schubert  <dirk.schubert@arm.com>
4946         Chris January  <chris.january@arm.com>
4947
4948         * eval.c (evaluate_subexp_standard): Call Fortran argument
4949         wrapping logic.
4950         * f-lang.c (struct value): A value which can be passed into a
4951         Fortran function call.
4952         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4953         where appropriate.
4954         (struct type): Value ready for a Fortran function call.
4955         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4956         is needed.
4957         * f-lang.h (fortran_argument_convert): Declaration.
4958         (fortran_preserve_arg_pointer): Declaration.
4959         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4960
4961 2019-03-05  Tom Tromey  <tromey@adacore.com>
4962
4963         * python/py-prettyprint.c (print_string_repr): Remove #if.
4964         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4965
4966 2019-03-05  Tom Tromey  <tromey@adacore.com>
4967
4968         * target.c (the_dummy_target): Move later.  Change type to
4969         "dummy_target".
4970         (initialize_targets): Don't initialize the_dummy_target.
4971
4972 2019-03-05  Tom Tromey  <tromey@adacore.com>
4973
4974         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4975         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4976
4977 2019-03-05  Tom Tromey  <tromey@adacore.com>
4978
4979         * windows-nat.c (windows_nat_target::attach)
4980         (windows_nat_target::detach): Don't call gdb_flush.
4981         * valprint.c (generic_val_print, val_print, val_print_string):
4982         Don't call gdb_flush.
4983         * utils.c (defaulted_query): Don't call gdb_flush.
4984         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4985         * target.c (target_announce_detach): Don't call gdb_flush.
4986         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4987         * remote.c (extended_remote_target::attach): Don't call
4988         gdb_flush.
4989         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4990         * printcmd.c (do_examine): Don't call gdb_flush.
4991         (info_display_command): Don't call gdb_flush.
4992         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4993         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4994         * memattr.c (info_mem_command): Don't call gdb_flush.
4995         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4996         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4997         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4998         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4999         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5000         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5001         (gnu_nat_target::detach): Don't call gdb_flush.
5002         * f-valprint.c (f_val_print): Don't call gdb_flush.
5003         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5004         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5005         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5006         gdb_flush.
5007         * c-valprint.c (c_val_print): Don't call gdb_flush.
5008         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5009
5010 2019-03-05  Tom Tromey  <tromey@adacore.com>
5011
5012         * varobj.c (update_dynamic_varobj_children): Update.
5013         (install_default_visualizer): Use reset, not release.
5014         * value.c (set_internalvar): Update.
5015         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5016         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5017         ATTRIBUTE_UNUSED_RESULT.
5018
5019 2019-03-05  Tom Tromey  <tromey@adacore.com>
5020
5021         * remote.c (class scoped_remote_fd) <release>: Add
5022         ATTRIBUTE_UNUSED_RESULT.
5023
5024 2019-03-05  Tom Tromey  <tromey@adacore.com>
5025
5026         * macroexp.c (struct macro_buffer) <release>: Add
5027         ATTRIBUTE_UNUSED_RESULT.
5028
5029 2019-03-05  Tom Tromey  <tromey@adacore.com>
5030
5031         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5032         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5033         ATTRIBUTE_UNUSED_RESULT.
5034
5035 2019-03-05  Tom Tromey  <tromey@adacore.com>
5036
5037         * common/scoped_fd.h (class scoped_fd) <release>: Add
5038         ATTRIBUTE_UNUSED_RESULT.
5039
5040 2019-03-05  Tom Tromey  <tromey@adacore.com>
5041
5042         * parser-defs.h (struct parser_state) <release>: Add
5043         ATTRIBUTE_UNUSED_RESULT.
5044
5045 2019-03-05  Tom Tromey  <tromey@adacore.com>
5046
5047         * utils.h (class gdb_argv) <release>: Add
5048         ATTRIBUTE_UNUSED_RESULT.
5049         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5050
5051 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5052
5053         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5054         for-loop range, to avoid compiler warnings.
5055
5056         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5057         avoid compiler warnings about unused variables.
5058
5059         * NEWS: Mention end of support for native debugging on MS-Windows
5060         before XP.
5061
5062         PR gdb/24292
5063         * common/netstuff.c:
5064         * gdbserver/gdbreplay.c
5065         * gdbserver/remote-utils.c:
5066         * ser-tcp.c:
5067         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5068         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5069         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5070         'getaddrinfo' and 'freeaddrinfo' were not available before
5071         Windows XP, and mingw.org's MinGW headers by default define
5072         _WIN32_WINNT to 0x500.
5073
5074 2019-03-01  Gary Benson <gbenson@redhat.com>
5075
5076         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5077
5078 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5079             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5080
5081         PR gdb/8527
5082         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5083         set_sigint_trap, clear_sigint_trap.
5084
5085 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5086
5087         * target.c (target_detach): Clear the regcache and the
5088         frame cache.
5089
5090 2019-02-27  Pedro Alves  <palves@redhat.com>
5091
5092         * utils.c (set_screen_size): When we cap the height/width sizes,
5093         tweak the corresponding command variable to show "unlimited":
5094
5095 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5096             Pedro Alves  <palves@redhat.com>
5097
5098         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5099         before calling rl_set_screen_size.
5100
5101 2019-02-27  Tom Tromey  <tromey@adacore.com>
5102
5103         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5104         define.
5105         * python/py-value.c: Remove Python 2.4 workaround.
5106         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5107         workaround.
5108         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5109         Python 2.4 workaround.
5110         * python/python-internal.h: Remove Python 2.4 comment.
5111         (Py_ssize_t): Don't define.
5112         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5113         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5114         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5115         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5116         * python/python.c (do_start_initialization): Remove Python 2.4
5117         workaround.
5118         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5119         (print_children): Remove Python 2.4 workaround.
5120         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5121         workaround.
5122         (CHARBUFFERPROC_NAME): Remove.
5123         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5124         Python 2.4 workaround.
5125
5126 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5127
5128         * NEWS: Note minimum Python version.
5129
5130 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5131
5132         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5133         code from these functions.  Remove corresponding ifdefs.  Use
5134         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5135         Remove gotos and target of gotos.
5136         (infpy_search_memory): Likewise.
5137
5138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5139
5140         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5141         (hppa_gdbarch_init): Don't register deleted functions with
5142         gdbarch.
5143
5144 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5147         (h8300_unwind_sp): Delete.
5148         (h8300_dummy_id): Delete.
5149         (h8300_gdbarch_init): Don't register deleted functions with
5150         gdbarch.
5151
5152 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5155         (ft32_unwind_pc): Delete.
5156         (ft32_unwind_sp): Delete.
5157         (ft32_gdbarch_init): Don't register deleted functions with
5158         gdbarch.
5159
5160 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5161
5162         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5163         (frv_unwind_pc): Delete.
5164         (frv_unwind_sp): Delete.
5165         (frv_gdbarch_init): Don't register deleted functions with
5166         gdbarch.
5167
5168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5169
5170         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5171         (riscv_unwind_pc): Delete.
5172         (riscv_unwind_sp): Delete.
5173         (riscv_gdbarch_init): Don't register deleted functions with
5174         gdbarch.
5175
5176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5177
5178         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5179         (csky_unwind_pc): Delete.
5180         (csky_unwind_sp): Delete.
5181         (csky_gdbarch_init): Don't register deleted functions with
5182         gdbarch.
5183
5184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5185
5186         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5187         (cris_unwind_pc): Delete.
5188         (cris_unwind_sp): Delete.
5189         (cris_gdbarch_init): Don't register deleted functions with
5190         gdbarch.
5191
5192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5193
5194         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5195         (bfin_unwind_pc): Delete.
5196         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5197
5198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5199
5200         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5201         (arm_unwind_pc): Delete.
5202         (arm_unwind_sp): Delete.
5203         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5204
5205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5208         (arc_unwind_pc): Delete.
5209         (arc_unwind_sp): Delete.
5210         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5211
5212 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5213
5214         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5215         (alpha_unwind_pc): Delete.
5216         (alpha_gdbarch_init): Don't register deleted functions with
5217         gdbarch.
5218
5219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5222         (aarch64_unwind_pc): Delete.
5223         (aarch64_unwind_sp): Delete.
5224         (aarch64_gdbarch_init): Don't register deleted functions with
5225         gdbarch.
5226
5227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5228
5229         * gdbtypes.c (type_align): Don't consider static members when
5230         computing structure alignment.
5231
5232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5233
5234         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5235         return 0 for other types.
5236         * arch-utils.c (default_type_align): Always return 0.
5237         * gdbarch.h: Regenerate.
5238         * gdbarch.sh (type_align): Extend comment.
5239         * gdbtypes.c (type_align): Add additional comments, always call
5240         gdbarch_type_align before applying the default rules.
5241         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5242         generic code will then apply a suitable default.
5243         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5244         types, return 0 for other types.
5245
5246 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5247
5248         * NEWS: Create a new section for the next release branch.
5249         Rename the section of the current branch, now that it has
5250         been cut.
5251
5252 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5253
5254         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5255         * version.in: Bump version to 8.3.50.DATE-git.
5256
5257 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5258
5259         * aix-thread.c (ptid_cmp): Remove unused variable.
5260         (get_signaled_thread): Likewise.
5261         (store_regs_user_thread): Likewise.
5262         (store_regs_kernel_thread): Likewise.
5263         (fetch_regs_kernel_thread): Remove shadowed variable.
5264
5265 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5266
5267         * features/riscv/32bit-cpu.xml: Add register numbers.
5268         * features/riscv/32bit-fpu.c: Regenerate.
5269         * features/riscv/32bit-fpu.xml: Add register numbers.
5270         * features/riscv/64bit-cpu.xml: Add register numbers.
5271         * features/riscv/64bit-fpu.c: Regenerate.
5272         * features/riscv/64bit-fpu.xml: Add register numbers.
5273
5274 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5275
5276         * NEWS: Mention two argument form of gdb.Value constructor.
5277         * python/py-value.c (convert_buffer_and_type_to_value): New
5278         function.
5279         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5280         Add support for handling an optional second argument.  Call
5281         convert_buffer_and_type_to_value as appropriate.
5282         * python/python-internal.h (Py_buffer_deleter): New struct.
5283         (Py_buffer_up): New typedef.
5284
5285 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5286
5287         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5288         instead of releasing ownership.
5289
5290 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5291
5292         * dwarf2read.c (open_and_init_dwp_file): Call
5293         elf_numsections instead of bfd_count_sections to initialize
5294         dwp_file->num_sections.
5295
5296 2019-02-25  Tom Tromey  <tromey@adacore.com>
5297
5298         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5299
5300 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5301
5302         * gcore.in: Add '--readnever' option when invoking GDB.
5303
5304 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5305
5306         * MAINTAINERS: Update my email address.
5307
5308 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5309
5310         * build-id.c (build_id_to_debug_bfd_1): New function.
5311         (build_id_to_debug_bfd): Look for separate debug file in
5312         sysroot.
5313
5314 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5315
5316         * gdbarch.sh: Update the copyright year range that is placed into
5317         generated files.
5318
5319 2019-02-22  Keith Seitz  <keiths@redhat.com>
5320
5321         PR symtab/23853
5322         * linespec.c (create_sals_line_offset): Search for the default
5323         symtab's filename instead of its fullname.
5324
5325 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5326
5327         * NEWS: Update style defaults.
5328
5329 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5330
5331         * main.c (captured_main_1): Disable styling in batch mode.
5332
5333 2019-02-20  Tom Tromey  <tom@tromey.com>
5334
5335         * symtab.c (symtab_symbol_info): Fix typos.
5336
5337 2019-02-20  Tom Tromey  <tromey@adacore.com>
5338
5339         * findcmd.c (_initialize_mem_search): Use upper case for
5340         metasyntactic variables.
5341
5342 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5343
5344         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5345         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5346
5347 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5348
5349         * top.h (source_file_name): Change to std::string.
5350         * top.c (source_file_name): Likewise.
5351         (command_line_input): Adjust.
5352         * cli/cli-script.c (script_from_file): Adjust.
5353
5354 2019-02-19  Tom Tromey  <tromey@adacore.com>
5355
5356         * ravenscar-thread.c
5357         (ravenscar_thread_target::update_thread_list): Don't call
5358         ada_build_task_list.
5359         * ada-lang.h (ada_build_task_list): Don't declare.
5360         * ada-tasks.c (struct ada_tasks_inferior_data)
5361         <task_list_valid_p>: Now bool.
5362         (read_known_tasks, ada_task_list_changed)
5363         (ada_tasks_invalidate_inferior_data): Update.
5364         (read_known_tasks_array): Return bool.
5365         (read_known_tasks_list): Likewise.
5366         (read_known_tasks): Return void.
5367         (ada_build_task_list): Now static.
5368
5369 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5370
5371         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5372         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5373
5374 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5375
5376         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5377         variant for ada_tasks_pspace_data_handle and
5378         ada_tasks_inferior_data_handle.
5379         (ada_tasks_pspace_data_cleanup): New function.
5380         (ada_tasks_inferior_data_cleanup): New function.
5381
5382 2019-02-17  Tom Tromey  <tom@tromey.com>
5383
5384         * macrotab.h (macro_source_fullname): Return a std::string.
5385         * macrotab.c (macro_include, check_for_redefinition)
5386         (macro_undef, macro_lookup_definition, foreach_macro)
5387         (foreach_macro_in_scope): Update.
5388         (macro_source_fullname): Return a std::string.
5389         * macrocmd.c (show_pp_source_pos): Update.
5390
5391 2019-02-17  Tom Tromey  <tom@tromey.com>
5392
5393         * macrocmd.c (show_pp_source_pos): Style the file names.
5394
5395 2019-02-17  Tom Tromey  <tom@tromey.com>
5396
5397         PR tui/24197:
5398         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5399
5400 2019-02-17  Tom Tromey  <tom@tromey.com>
5401
5402         * ada-lang.c (user_select_syms): Use filtered printing.
5403         * utils.c (wrap_style): New global.
5404         (desired_style): Remove.
5405         (emit_style_escape): Add stream parameter.
5406         (set_output_style, reset_terminal_style, prompt_for_continue):
5407         Update.
5408         (flush_wrap_buffer): Only flush gdb_stdout.
5409         (wrap_here): Set wrap_style.
5410         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5411         treat escape sequences as a character.  Change when wrap buffer is
5412         flushed.
5413         (fputs_styled): Do not set the output style when the default is
5414         requested.
5415         * ui-style.h (struct ui_file_style) <is_default>: New method.
5416         * source.c (print_source_lines_base): Emit escape sequences in one
5417         piece.
5418
5419 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5420
5421         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5422         integers and enumeration types.
5423
5424 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5425
5426         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5427         instead of lookup_symbol_in_language
5428         (do_exact_match): New function.
5429         (ada_get_symbol_name_matcher): Return do_exact_match when
5430         doing a verbatim match.
5431
5432 2019-02-15  Tom Tromey  <tromey@adacore.com>
5433
5434         * ravenscar-thread.c (ravenscar_thread_target::resume)
5435         (ravenscar_thread_target::wait): Special case wildcard requests.
5436
5437 2019-02-15  Tom Tromey  <tromey@adacore.com>
5438
5439         * ravenscar-thread.c (base_ptid): Remove.
5440         (struct ravenscar_thread_target) <close>: New method.
5441         <m_base_ptid>: New member.
5442         <update_inferior_ptid, active_task, task_is_currently_active,
5443         runtime_initialized>: Declare methods.
5444         <ravenscar_thread_target>: Add constructor.
5445         (ravenscar_thread_target::task_is_currently_active)
5446         (ravenscar_thread_target::update_inferior_ptid)
5447         (ravenscar_runtime_initialized): Rename.  Now methods.
5448         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5449         (ravenscar_thread_target::update_thread_list): Update.
5450         (ravenscar_thread_target::active_task): Now method.
5451         (ravenscar_thread_target::store_registers)
5452         (ravenscar_thread_target::prepare_to_store)
5453         (ravenscar_thread_target::prepare_to_store)
5454         (ravenscar_thread_target::mourn_inferior): Update.
5455         (ravenscar_inferior_created): Use "new" to create target.
5456         (ravenscar_thread_target::get_ada_task_ptid): Update.
5457         (_initialize_ravenscar): Don't initialize base_ptid.
5458         (ravenscar_ops): Remove global.
5459
5460 2019-02-15  Tom Tromey  <tromey@adacore.com>
5461
5462         * target.h (push_target): Declare new overload.
5463         * target.c (push_target): New overload, taking an rvalue reference.
5464         * remote.c (remote_target::open_1): Use push_target overload.
5465         * corelow.c (core_target_open): Use push_target overload.
5466
5467 2019-02-15  Tom Tromey  <tromey@adacore.com>
5468
5469         * ravenscar-thread.c (is_ravenscar_task)
5470         (ravenscar_task_is_currently_active): Return bool.
5471         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5472         (_initialize_ravenscar): Remove "(void)".
5473         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5474         Return bool.
5475
5476 2019-02-15  Tom Tromey  <tromey@adacore.com>
5477
5478         * ravenscar-thread.c (ravenscar_runtime_initializer)
5479         (has_ravenscar_runtime, get_running_thread_id)
5480         (ravenscar_thread_target::resume): Fix indentation.
5481
5482 2019-02-15  Tom Tromey  <tromey@adacore.com>
5483
5484         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5485         from ravenscar_arch_ops.
5486         (sparc_ravenscar_ops::fetch_registers)
5487         (sparc_ravenscar_ops::store_registers): Now methods.
5488         (sparc_ravenscar_prepare_to_store): Remove.
5489         (sparc_ravenscar_ops): Redefine.
5490         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5491         methods and destructor.  Remove members.
5492         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5493         (ravenscar_thread_target::store_registers)
5494         (ravenscar_thread_target::prepare_to_store): Update.
5495         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5496         Remove.
5497         (struct ppc_ravenscar_powerpc_ops): Derive from
5498         ravenscar_arch_ops.
5499         (ppc_ravenscar_powerpc_ops::fetch_registers)
5500         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5501         (ppc_ravenscar_powerpc_ops): Redefine.
5502         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5503         (ppc_ravenscar_e500_ops::fetch_registers)
5504         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5505         (ppc_ravenscar_e500_ops): Redefine.
5506         * aarch64-ravenscar-thread.c
5507         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5508         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5509         (aarch64_ravenscar_fetch_registers)
5510         (aarch64_ravenscar_store_registers): Now methods.
5511         (aarch64_ravenscar_ops): Redefine.
5512
5513 2019-02-15  Tom Tromey  <tromey@adacore.com>
5514
5515         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5516         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5517         (ravenscar_thread_target::stopped_by_watchpoint)
5518         (ravenscar_thread_target::stopped_data_address)
5519         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5520
5521 2019-02-15  Tom Tromey  <tromey@adacore.com>
5522
5523         * ravenscar-thread.c: Fix some typos.
5524
5525 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5526             Tom Tromey  <tromey@adacore.com>
5527
5528         * ada-lang.c (ada_exception_sal): Change addr_string to a
5529         std::string.
5530         (create_ada_exception_catchpoint): Update.
5531
5532 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5533             Tom Tromey  <tromey@adacore.com>
5534
5535         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5536         (bp_location_ops): Remove.
5537         (base_breakpoint_allocate_location): Update.
5538         (free_bp_location): Update.
5539         * ada-lang.c (class ada_catchpoint_location)
5540         <ada_catchpoint_location>: Remove ops parameter.
5541         (ada_catchpoint_location_dtor): Remove.
5542         (ada_catchpoint_location_ops): Remove.
5543         (allocate_location_exception): Update.
5544         * breakpoint.h (struct bp_location_ops): Remove.
5545         (class bp_location) <bp_location>: Remove bp_location_ops
5546         parameter.
5547         <~bp_location>: Add destructor.
5548         <ops>: Remove.
5549
5550 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5551             Pedro Alves  <palves@redhat.com>
5552
5553         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5554         'PATH_MAX'.
5555
5556 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5557             Samuel Thibault  <samuel.thibault@gnu.org>
5558             Thomas Schwinge  <thomas@codesourcery.com>
5559
5560         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5561         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5562
5563 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5564
5565         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5566         (check_empty): Use "const char *".
5567
5568         * gnu-nat.c (gnu_nat_target::detach): Instead of
5569         'detach_inferior (pid)' call
5570         'detach_inferior (find_inferior_pid (pid))'.
5571
5572         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5573         'nat/fork-inferior.o'.
5574         * gnu-nat.c: #include "nat/fork-inferior.h".
5575
5576         * gnu-nat.c (gnu_nat_target::detach): Instead of
5577         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5578         * gnu-nat.h: #include "inf-child.h".
5579         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5580         'i386_gnu_nat_target::fetch_registers'.
5581         (gnu_store_registers): Rename/move to
5582         'i386_gnu_nat_target::store_registers'.
5583
5584         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5585         * gnu-nat.h (mach_thread_info): New function.
5586         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5587
5588         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5589
5590 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5591
5592         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5593
5594 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5595
5596         * windows-nat.c (windows_add_thread): Add new parameter
5597         "main_thread_p" with default value set to false.  Update
5598         function documentation as well as all callers.
5599         (windows_delete_thread): Likewise.
5600         (fake_create_process): Update call to windows_add_thread.
5601         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5602         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5603         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5604         call to windows_delete_thread.
5605
5606 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5607
5608         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5609
5610 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5611
5612         * symfile.c (find_separate_debug_file): Use canonical path of
5613         sysroot with child_path instead of gdb_sysroot if it is valid.
5614
5615 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5616
5617         * symfile.c (find_separate_debug_file): Use child_path to
5618         determine if an object file is under a sysroot.
5619
5620 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5621
5622         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5623         unittests/child-path-selftests.c.
5624         * common/pathstuff.c (child_path): New function.
5625         * common/pathstuff.h (child_path): New prototype.
5626         * unittests/child-path-selftests.c: New file.
5627
5628 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5629
5630         * symfile.c (find_separate_debug_file): Look for separate debug
5631         files in debug directories under the sysroot.
5632
5633 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5634
5635         * symtab.h (struct minimal_symbol data_p): New const method.
5636         (struct minimal_symbol text_p): Likewise.
5637         * symtab.c (output_source_filename): Use file name style
5638         to print file name.
5639         (print_symbol_info): Likewise.
5640         (print_msymbol_info): Use address style to print addresses.
5641         Use function name style to print executable text symbols.
5642         (expand_symtab_containing_pc): Use data_p.
5643         (find_pc_sect_compunit_symtab): Likewise.
5644
5645 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5646
5647         * breakpoint.c (describe_other_breakpoints): Use address style
5648         to print addresses.
5649         (say_where): Likewise.
5650
5651 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5652
5653         * ada-typeprint.c (print_func_type): Print function name
5654         style to print function name.
5655         * c-typeprint.c (c_print_type_1): Likewise.
5656
5657 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5658
5659         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5660         for execve.
5661
5662 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5663
5664         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5665         type_stack.
5666
5667 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5668
5669         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5670         TYPE_CODE_REF types.
5671
5672 2019-02-08  Jim Wilson  <jimw@sifive.com>
5673
5674         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5675         (riscv_linux_fregset): New.
5676         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5677
5678 2019-02-07  Tom Tromey  <tom@tromey.com>
5679
5680         * thread.c (thread_cancel_execution_command): Update.
5681         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5682         methods.
5683         (struct thread_fsm_ops): Remove.
5684         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5685         (thread_fsm_should_stop, thread_fsm_return_value)
5686         (thread_fsm_set_finished, thread_fsm_finished_p)
5687         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5688         Don't declare.
5689         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5690         * infrun.c (clear_proceed_status_thread)
5691         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5692         (print_stop_event): Update.
5693         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5694         Add constructor.
5695         (step_command_fsm_ops): Remove.
5696         (new_step_command_fsm): Remove.
5697         (step_1): Update.
5698         (step_command_fsm::should_stop): Rename from
5699         step_command_fsm_should_stop.
5700         (step_command_fsm::clean_up): Rename from
5701         step_command_fsm_clean_up.
5702         (step_command_fsm::do_async_reply_reason): Rename from
5703         step_command_fsm_async_reply_reason.
5704         (struct until_next_fsm): Inherit from thread_fsm.  Add
5705         constructor.
5706         (until_next_fsm_ops): Remove.
5707         (new_until_next_fsm): Remove.
5708         (until_next_fsm::should_stop): Rename from
5709         until_next_fsm_should_stop.
5710         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5711         (until_next_fsm::do_async_reply_reason): Rename from
5712         until_next_fsm_async_reply_reason.
5713         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5714         constructor.  Change type of breakpoint.
5715         (finish_command_fsm_ops): Remove.
5716         (new_finish_command_fsm): Remove.
5717         (finish_command_fsm::should_stop): Rename from
5718         finish_command_fsm_should_stop.
5719         (finish_command_fsm::clean_up): Rename from
5720         finish_command_fsm_clean_up.
5721         (finish_command_fsm::return_value): Rename from
5722         finish_command_fsm_return_value.
5723         (finish_command_fsm::do_async_reply_reason): Rename from
5724         finish_command_fsm_async_reply_reason.
5725         (finish_command): Update.
5726         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5727         Add constructor.
5728         (call_thread_fsm_ops): Remove.
5729         (call_thread_fsm::call_thread_fsm): Rename from
5730         new_call_thread_fsm.
5731         (call_thread_fsm::should_stop): Rename from
5732         call_thread_fsm_should_stop.
5733         (call_thread_fsm::should_notify_stop): Rename from
5734         call_thread_fsm_should_notify_stop.
5735         (run_inferior_call, call_function_by_hand_dummy): Update.
5736         * cli/cli-interp.c (should_print_stop_to_console): Update.
5737         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5738         Add constructor.  Change type of location_breakpoint,
5739         caller_breakpoint.
5740         (until_break_fsm_ops): Remove.
5741         (new_until_break_fsm): Remove.
5742         (until_break_fsm::should_stop): Rename from
5743         until_break_fsm_should_stop.
5744         (until_break_fsm::clean_up): Rename from
5745         until_break_fsm_clean_up.
5746         (until_break_fsm::do_async_reply_reason): Rename from
5747         until_break_fsm_async_reply_reason.
5748         (until_break_command): Update.
5749         * thread-fsm.c: Remove.
5750         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5751
5752 2019-02-07  Tom Tromey  <tom@tromey.com>
5753
5754         * yy-remap.h: Add include guard.
5755         * xtensa-tdep.h: Add include guard.
5756         * xcoffread.h: Rename include guard.
5757         * varobj-iter.h: Add include guard.
5758         * tui/tui.h: Rename include guard.
5759         * tui/tui-winsource.h: Rename include guard.
5760         * tui/tui-wingeneral.h: Rename include guard.
5761         * tui/tui-windata.h: Rename include guard.
5762         * tui/tui-win.h: Rename include guard.
5763         * tui/tui-stack.h: Rename include guard.
5764         * tui/tui-source.h: Rename include guard.
5765         * tui/tui-regs.h: Rename include guard.
5766         * tui/tui-out.h: Rename include guard.
5767         * tui/tui-layout.h: Rename include guard.
5768         * tui/tui-io.h: Rename include guard.
5769         * tui/tui-hooks.h: Rename include guard.
5770         * tui/tui-file.h: Rename include guard.
5771         * tui/tui-disasm.h: Rename include guard.
5772         * tui/tui-data.h: Rename include guard.
5773         * tui/tui-command.h: Rename include guard.
5774         * tic6x-tdep.h: Add include guard.
5775         * target/waitstatus.h: Rename include guard.
5776         * target/wait.h: Rename include guard.
5777         * target/target.h: Rename include guard.
5778         * target/resume.h: Rename include guard.
5779         * target-float.h: Rename include guard.
5780         * stabsread.h: Add include guard.
5781         * rs6000-tdep.h: Add include guard.
5782         * riscv-fbsd-tdep.h: Add include guard.
5783         * regformats/regdef.h: Rename include guard.
5784         * record.h: Rename include guard.
5785         * python/python.h: Rename include guard.
5786         * python/python-internal.h: Rename include guard.
5787         * python/py-stopevent.h: Rename include guard.
5788         * python/py-ref.h: Rename include guard.
5789         * python/py-record.h: Rename include guard.
5790         * python/py-record-full.h: Rename include guard.
5791         * python/py-record-btrace.h: Rename include guard.
5792         * python/py-instruction.h: Rename include guard.
5793         * python/py-events.h: Rename include guard.
5794         * python/py-event.h: Rename include guard.
5795         * procfs.h: Add include guard.
5796         * proc-utils.h: Add include guard.
5797         * p-lang.h: Add include guard.
5798         * or1k-tdep.h: Rename include guard.
5799         * observable.h: Rename include guard.
5800         * nto-tdep.h: Rename include guard.
5801         * nat/x86-linux.h: Rename include guard.
5802         * nat/x86-linux-dregs.h: Rename include guard.
5803         * nat/x86-gcc-cpuid.h: Add include guard.
5804         * nat/x86-dregs.h: Rename include guard.
5805         * nat/x86-cpuid.h: Rename include guard.
5806         * nat/ppc-linux.h: Rename include guard.
5807         * nat/mips-linux-watch.h: Rename include guard.
5808         * nat/linux-waitpid.h: Rename include guard.
5809         * nat/linux-ptrace.h: Rename include guard.
5810         * nat/linux-procfs.h: Rename include guard.
5811         * nat/linux-osdata.h: Rename include guard.
5812         * nat/linux-nat.h: Rename include guard.
5813         * nat/linux-namespaces.h: Rename include guard.
5814         * nat/linux-btrace.h: Rename include guard.
5815         * nat/glibc_thread_db.h: Rename include guard.
5816         * nat/gdb_thread_db.h: Rename include guard.
5817         * nat/gdb_ptrace.h: Rename include guard.
5818         * nat/fork-inferior.h: Rename include guard.
5819         * nat/amd64-linux-siginfo.h: Rename include guard.
5820         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5821         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5822         * nat/aarch64-linux.h: Rename include guard.
5823         * nat/aarch64-linux-hw-point.h: Rename include guard.
5824         * mn10300-tdep.h: Add include guard.
5825         * mips-linux-tdep.h: Add include guard.
5826         * mi/mi-parse.h: Rename include guard.
5827         * mi/mi-out.h: Rename include guard.
5828         * mi/mi-main.h: Rename include guard.
5829         * mi/mi-interp.h: Rename include guard.
5830         * mi/mi-getopt.h: Rename include guard.
5831         * mi/mi-console.h: Rename include guard.
5832         * mi/mi-common.h: Rename include guard.
5833         * mi/mi-cmds.h: Rename include guard.
5834         * mi/mi-cmd-break.h: Rename include guard.
5835         * m2-lang.h: Add include guard.
5836         * location.h: Rename include guard.
5837         * linux-record.h: Rename include guard.
5838         * linux-nat.h: Add include guard.
5839         * linux-fork.h: Add include guard.
5840         * i386-darwin-tdep.h: Rename include guard.
5841         * hppa-linux-offsets.h: Add include guard.
5842         * guile/guile.h: Rename include guard.
5843         * guile/guile-internal.h: Rename include guard.
5844         * gnu-nat.h: Rename include guard.
5845         * gdb-stabs.h: Rename include guard.
5846         * frv-tdep.h: Add include guard.
5847         * f-lang.h: Add include guard.
5848         * event-loop.h: Add include guard.
5849         * darwin-nat.h: Rename include guard.
5850         * cp-abi.h: Rename include guard.
5851         * config/sparc/nm-sol2.h: Rename include guard.
5852         * config/nm-nto.h: Rename include guard.
5853         * config/nm-linux.h: Add include guard.
5854         * config/i386/nm-i386gnu.h: Rename include guard.
5855         * config/djgpp/nl_types.h: Rename include guard.
5856         * config/djgpp/langinfo.h: Rename include guard.
5857         * compile/gcc-cp-plugin.h: Add include guard.
5858         * compile/gcc-c-plugin.h: Add include guard.
5859         * compile/compile.h: Rename include guard.
5860         * compile/compile-object-run.h: Rename include guard.
5861         * compile/compile-object-load.h: Rename include guard.
5862         * compile/compile-internal.h: Rename include guard.
5863         * compile/compile-cplus.h: Rename include guard.
5864         * compile/compile-c.h: Rename include guard.
5865         * common/xml-utils.h: Rename include guard.
5866         * common/x86-xstate.h: Rename include guard.
5867         * common/version.h: Rename include guard.
5868         * common/vec.h: Rename include guard.
5869         * common/tdesc.h: Rename include guard.
5870         * common/selftest.h: Rename include guard.
5871         * common/scoped_restore.h: Rename include guard.
5872         * common/scoped_mmap.h: Rename include guard.
5873         * common/scoped_fd.h: Rename include guard.
5874         * common/safe-iterator.h: Rename include guard.
5875         * common/run-time-clock.h: Rename include guard.
5876         * common/refcounted-object.h: Rename include guard.
5877         * common/queue.h: Rename include guard.
5878         * common/ptid.h: Rename include guard.
5879         * common/print-utils.h: Rename include guard.
5880         * common/preprocessor.h: Rename include guard.
5881         * common/pathstuff.h: Rename include guard.
5882         * common/observable.h: Rename include guard.
5883         * common/netstuff.h: Rename include guard.
5884         * common/job-control.h: Rename include guard.
5885         * common/host-defs.h: Rename include guard.
5886         * common/gdb_wait.h: Rename include guard.
5887         * common/gdb_vecs.h: Rename include guard.
5888         * common/gdb_unlinker.h: Rename include guard.
5889         * common/gdb_unique_ptr.h: Rename include guard.
5890         * common/gdb_tilde_expand.h: Rename include guard.
5891         * common/gdb_sys_time.h: Rename include guard.
5892         * common/gdb_string_view.h: Rename include guard.
5893         * common/gdb_splay_tree.h: Rename include guard.
5894         * common/gdb_setjmp.h: Rename include guard.
5895         * common/gdb_ref_ptr.h: Rename include guard.
5896         * common/gdb_optional.h: Rename include guard.
5897         * common/gdb_locale.h: Rename include guard.
5898         * common/gdb_assert.h: Rename include guard.
5899         * common/filtered-iterator.h: Rename include guard.
5900         * common/filestuff.h: Rename include guard.
5901         * common/fileio.h: Rename include guard.
5902         * common/environ.h: Rename include guard.
5903         * common/common-utils.h: Rename include guard.
5904         * common/common-types.h: Rename include guard.
5905         * common/common-regcache.h: Rename include guard.
5906         * common/common-inferior.h: Rename include guard.
5907         * common/common-gdbthread.h: Rename include guard.
5908         * common/common-exceptions.h: Rename include guard.
5909         * common/common-defs.h: Rename include guard.
5910         * common/common-debug.h: Rename include guard.
5911         * common/cleanups.h: Rename include guard.
5912         * common/buffer.h: Rename include guard.
5913         * common/btrace-common.h: Rename include guard.
5914         * common/break-common.h: Rename include guard.
5915         * cli/cli-utils.h: Rename include guard.
5916         * cli/cli-style.h: Rename include guard.
5917         * cli/cli-setshow.h: Rename include guard.
5918         * cli/cli-script.h: Rename include guard.
5919         * cli/cli-interp.h: Rename include guard.
5920         * cli/cli-decode.h: Rename include guard.
5921         * cli/cli-cmds.h: Rename include guard.
5922         * charset-list.h: Add include guard.
5923         * buildsym-legacy.h: Rename include guard.
5924         * bfin-tdep.h: Add include guard.
5925         * ax.h: Rename include guard.
5926         * arm-linux-tdep.h: Add include guard.
5927         * arm-fbsd-tdep.h: Add include guard.
5928         * arch/xtensa.h: Rename include guard.
5929         * arch/tic6x.h: Add include guard.
5930         * arch/i386.h: Add include guard.
5931         * arch/arm.h: Rename include guard.
5932         * arch/arm-linux.h: Rename include guard.
5933         * arch/arm-get-next-pcs.h: Rename include guard.
5934         * arch/amd64.h: Add include guard.
5935         * arch/aarch64-insn.h: Rename include guard.
5936         * arch-utils.h: Rename include guard.
5937         * annotate.h: Add include guard.
5938         * amd64-darwin-tdep.h: Rename include guard.
5939         * aarch64-linux-tdep.h: Add include guard.
5940         * aarch64-fbsd-tdep.h: Add include guard.
5941         * aarch32-linux-nat.h: Add include guard.
5942
5943 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5944
5945         * macrotab.c (macro_define_internal): New function that
5946         factorizes macro_define_object_internal and macro_define_function
5947         code.
5948         (macro_define_object_internal): Use macro_define_internal.
5949         (macro_define_function): Likewise.
5950
5951 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5952
5953         * macrocmd.c (extract_identifier): Return
5954         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5955         callers.
5956
5957 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5958
5959         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5960
5961 2019-02-05  Tom Tromey  <tom@tromey.com>
5962
5963         * target.c (target_stack::unpush): Move assertion earlier.
5964
5965 2019-01-30  Tom Tromey  <tom@tromey.com>
5966
5967         PR python/23615:
5968         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5969         (gdbpy_parse_and_eval): Likewise.
5970         * python/python-internal.h (gdbpy_allow_threads): New class.
5971
5972 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5973
5974         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5975         (aarch64_fbsd_fpregmap): Move earlier.
5976         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5977         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5978         instead of individual calls to trad_frame_set_reg_addr.
5979         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5980         earlier.
5981         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5982         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5983         instead of individual calls to trad_frame_set_reg_addr.
5984
5985 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5986
5987         * CONTRIBUTE: Replace contribution list with wiki link.
5988
5989 2019-01-25  Tom Tromey  <tom@tromey.com>
5990
5991         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5992
5993 2019-01-25  Tom Tromey  <tom@tromey.com>
5994
5995         * xtensa-linux-nat.c: Fix common/ includes.
5996         * xml-support.h: Fix common/ includes.
5997         * xml-support.c: Fix common/ includes.
5998         * x86-linux-nat.c: Fix common/ includes.
5999         * windows-nat.c: Fix common/ includes.
6000         * varobj.h: Fix common/ includes.
6001         * varobj.c: Fix common/ includes.
6002         * value.c: Fix common/ includes.
6003         * valops.c: Fix common/ includes.
6004         * utils.c: Fix common/ includes.
6005         * unittests/xml-utils-selftests.c: Fix common/ includes.
6006         * unittests/utils-selftests.c: Fix common/ includes.
6007         * unittests/unpack-selftests.c: Fix common/ includes.
6008         * unittests/tracepoint-selftests.c: Fix common/ includes.
6009         * unittests/style-selftests.c: Fix common/ includes.
6010         * unittests/string_view-selftests.c: Fix common/ includes.
6011         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6012         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6013         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6014         * unittests/rsp-low-selftests.c: Fix common/ includes.
6015         * unittests/parse-connection-spec-selftests.c: Fix common/
6016         includes.
6017         * unittests/optional-selftests.c: Fix common/ includes.
6018         * unittests/offset-type-selftests.c: Fix common/ includes.
6019         * unittests/observable-selftests.c: Fix common/ includes.
6020         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6021         * unittests/memrange-selftests.c: Fix common/ includes.
6022         * unittests/memory-map-selftests.c: Fix common/ includes.
6023         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6024         * unittests/function-view-selftests.c: Fix common/ includes.
6025         * unittests/environ-selftests.c: Fix common/ includes.
6026         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6027         * unittests/common-utils-selftests.c: Fix common/ includes.
6028         * unittests/cli-utils-selftests.c: Fix common/ includes.
6029         * unittests/array-view-selftests.c: Fix common/ includes.
6030         * ui-file.c: Fix common/ includes.
6031         * tui/tui-io.c: Fix common/ includes.
6032         * tracepoint.h: Fix common/ includes.
6033         * tracepoint.c: Fix common/ includes.
6034         * tracefile-tfile.c: Fix common/ includes.
6035         * top.h: Fix common/ includes.
6036         * top.c: Fix common/ includes.
6037         * thread.c: Fix common/ includes.
6038         * target/waitstatus.h: Fix common/ includes.
6039         * target/waitstatus.c: Fix common/ includes.
6040         * target.h: Fix common/ includes.
6041         * target.c: Fix common/ includes.
6042         * target-memory.c: Fix common/ includes.
6043         * target-descriptions.c: Fix common/ includes.
6044         * symtab.h: Fix common/ includes.
6045         * symfile.c: Fix common/ includes.
6046         * stap-probe.c: Fix common/ includes.
6047         * spu-linux-nat.c: Fix common/ includes.
6048         * sparc-nat.c: Fix common/ includes.
6049         * source.c: Fix common/ includes.
6050         * solib.c: Fix common/ includes.
6051         * solib-target.c: Fix common/ includes.
6052         * ser-unix.c: Fix common/ includes.
6053         * ser-tcp.c: Fix common/ includes.
6054         * ser-pipe.c: Fix common/ includes.
6055         * ser-base.c: Fix common/ includes.
6056         * selftest-arch.c: Fix common/ includes.
6057         * s12z-tdep.c: Fix common/ includes.
6058         * rust-exp.y: Fix common/ includes.
6059         * rs6000-aix-tdep.c: Fix common/ includes.
6060         * riscv-tdep.c: Fix common/ includes.
6061         * remote.c: Fix common/ includes.
6062         * remote-notif.h: Fix common/ includes.
6063         * remote-fileio.h: Fix common/ includes.
6064         * remote-fileio.c: Fix common/ includes.
6065         * regcache.h: Fix common/ includes.
6066         * regcache.c: Fix common/ includes.
6067         * record-btrace.c: Fix common/ includes.
6068         * python/python.c: Fix common/ includes.
6069         * python/py-type.c: Fix common/ includes.
6070         * python/py-inferior.c: Fix common/ includes.
6071         * progspace.h: Fix common/ includes.
6072         * producer.c: Fix common/ includes.
6073         * procfs.c: Fix common/ includes.
6074         * proc-api.c: Fix common/ includes.
6075         * printcmd.c: Fix common/ includes.
6076         * ppc-linux-nat.c: Fix common/ includes.
6077         * parser-defs.h: Fix common/ includes.
6078         * osdata.c: Fix common/ includes.
6079         * obsd-nat.c: Fix common/ includes.
6080         * nat/x86-linux.c: Fix common/ includes.
6081         * nat/x86-linux-dregs.c: Fix common/ includes.
6082         * nat/x86-dregs.h: Fix common/ includes.
6083         * nat/x86-dregs.c: Fix common/ includes.
6084         * nat/ppc-linux.c: Fix common/ includes.
6085         * nat/mips-linux-watch.h: Fix common/ includes.
6086         * nat/mips-linux-watch.c: Fix common/ includes.
6087         * nat/linux-waitpid.c: Fix common/ includes.
6088         * nat/linux-ptrace.h: Fix common/ includes.
6089         * nat/linux-ptrace.c: Fix common/ includes.
6090         * nat/linux-procfs.c: Fix common/ includes.
6091         * nat/linux-personality.c: Fix common/ includes.
6092         * nat/linux-osdata.c: Fix common/ includes.
6093         * nat/linux-namespaces.c: Fix common/ includes.
6094         * nat/linux-btrace.h: Fix common/ includes.
6095         * nat/linux-btrace.c: Fix common/ includes.
6096         * nat/fork-inferior.c: Fix common/ includes.
6097         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6098         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6099         * nat/aarch64-linux.c: Fix common/ includes.
6100         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6101         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6102         * namespace.h: Fix common/ includes.
6103         * mips-linux-tdep.c: Fix common/ includes.
6104         * minsyms.c: Fix common/ includes.
6105         * mi/mi-parse.h: Fix common/ includes.
6106         * mi/mi-main.c: Fix common/ includes.
6107         * mi/mi-cmd-env.c: Fix common/ includes.
6108         * memrange.h: Fix common/ includes.
6109         * memattr.c: Fix common/ includes.
6110         * maint.h: Fix common/ includes.
6111         * maint.c: Fix common/ includes.
6112         * main.c: Fix common/ includes.
6113         * machoread.c: Fix common/ includes.
6114         * location.c: Fix common/ includes.
6115         * linux-thread-db.c: Fix common/ includes.
6116         * linux-nat.c: Fix common/ includes.
6117         * linux-fork.c: Fix common/ includes.
6118         * inline-frame.c: Fix common/ includes.
6119         * infrun.c: Fix common/ includes.
6120         * inflow.c: Fix common/ includes.
6121         * inferior.h: Fix common/ includes.
6122         * inferior.c: Fix common/ includes.
6123         * infcmd.c: Fix common/ includes.
6124         * inf-ptrace.c: Fix common/ includes.
6125         * inf-child.c: Fix common/ includes.
6126         * ia64-linux-nat.c: Fix common/ includes.
6127         * i387-tdep.c: Fix common/ includes.
6128         * i386-tdep.c: Fix common/ includes.
6129         * i386-linux-tdep.c: Fix common/ includes.
6130         * i386-linux-nat.c: Fix common/ includes.
6131         * i386-go32-tdep.c: Fix common/ includes.
6132         * i386-fbsd-tdep.c: Fix common/ includes.
6133         * i386-fbsd-nat.c: Fix common/ includes.
6134         * guile/scm-type.c: Fix common/ includes.
6135         * guile/guile.c: Fix common/ includes.
6136         * go32-nat.c: Fix common/ includes.
6137         * gnu-nat.c: Fix common/ includes.
6138         * gdbthread.h: Fix common/ includes.
6139         * gdbarch-selftests.c: Fix common/ includes.
6140         * gdb_usleep.c: Fix common/ includes.
6141         * gdb_select.h: Fix common/ includes.
6142         * gdb_bfd.c: Fix common/ includes.
6143         * gcore.c: Fix common/ includes.
6144         * fork-child.c: Fix common/ includes.
6145         * findvar.c: Fix common/ includes.
6146         * fbsd-nat.c: Fix common/ includes.
6147         * event-top.c: Fix common/ includes.
6148         * event-loop.c: Fix common/ includes.
6149         * dwarf2read.c: Fix common/ includes.
6150         * dwarf2loc.c: Fix common/ includes.
6151         * dwarf2-frame.c: Fix common/ includes.
6152         * dwarf-index-cache.c: Fix common/ includes.
6153         * dtrace-probe.c: Fix common/ includes.
6154         * disasm-selftests.c: Fix common/ includes.
6155         * defs.h: Fix common/ includes.
6156         * csky-tdep.c: Fix common/ includes.
6157         * cp-valprint.c: Fix common/ includes.
6158         * cp-support.h: Fix common/ includes.
6159         * cp-support.c: Fix common/ includes.
6160         * corelow.c: Fix common/ includes.
6161         * completer.h: Fix common/ includes.
6162         * completer.c: Fix common/ includes.
6163         * compile/compile.c: Fix common/ includes.
6164         * compile/compile-loc2c.c: Fix common/ includes.
6165         * compile/compile-cplus-types.c: Fix common/ includes.
6166         * compile/compile-cplus-symbols.c: Fix common/ includes.
6167         * command.h: Fix common/ includes.
6168         * cli/cli-dump.c: Fix common/ includes.
6169         * cli/cli-cmds.c: Fix common/ includes.
6170         * charset.c: Fix common/ includes.
6171         * build-id.c: Fix common/ includes.
6172         * btrace.h: Fix common/ includes.
6173         * btrace.c: Fix common/ includes.
6174         * breakpoint.h: Fix common/ includes.
6175         * breakpoint.c: Fix common/ includes.
6176         * ax.h:
6177         (enum agent_op): Fix common/ includes.
6178         * ax-general.c (struct aop_map): Fix common/ includes.
6179         * ax-gdb.c: Fix common/ includes.
6180         * auxv.c: Fix common/ includes.
6181         * auto-load.c: Fix common/ includes.
6182         * arm-tdep.c: Fix common/ includes.
6183         * arch/riscv.c: Fix common/ includes.
6184         * arch/ppc-linux-common.c: Fix common/ includes.
6185         * arch/i386.c: Fix common/ includes.
6186         * arch/arm.c: Fix common/ includes.
6187         * arch/arm-linux.c: Fix common/ includes.
6188         * arch/arm-get-next-pcs.c: Fix common/ includes.
6189         * arch/amd64.c: Fix common/ includes.
6190         * arch/aarch64.c: Fix common/ includes.
6191         * arch/aarch64-insn.c: Fix common/ includes.
6192         * arch-utils.c: Fix common/ includes.
6193         * amd64-windows-tdep.c: Fix common/ includes.
6194         * amd64-tdep.c: Fix common/ includes.
6195         * amd64-sol2-tdep.c: Fix common/ includes.
6196         * amd64-obsd-tdep.c: Fix common/ includes.
6197         * amd64-nbsd-tdep.c: Fix common/ includes.
6198         * amd64-linux-tdep.c: Fix common/ includes.
6199         * amd64-linux-nat.c: Fix common/ includes.
6200         * amd64-fbsd-tdep.c: Fix common/ includes.
6201         * amd64-fbsd-nat.c: Fix common/ includes.
6202         * amd64-dicos-tdep.c: Fix common/ includes.
6203         * amd64-darwin-tdep.c: Fix common/ includes.
6204         * agent.c: Fix common/ includes.
6205         * ada-lang.h: Fix common/ includes.
6206         * ada-lang.c: Fix common/ includes.
6207         * aarch64-tdep.c: Fix common/ includes.
6208
6209 2019-01-25  Tom Tromey  <tom@tromey.com>
6210
6211         * common/create-version.sh: Use common/version.h.
6212
6213 2019-01-24  Pedro Alves  <palves@redhat.com>
6214
6215         * infrun.c (signal_stop, signal_print, signal_program)
6216         (signal_catch, signal_pass): Now arrays instead of pointers.
6217         (update_signals_program_target, do_target_resume)
6218         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6219         * linux-nat.c (linux_nat_target::pass_signals)
6220         (linux_nat_target::create_inferior, linux_nat_target::attach):
6221         Adjust.
6222         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6223         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6224         * procfs.c (procfs_target::pass_signals): Adjust.
6225         * record-full.c (record_full_target::resume): Adjust.
6226         * remote.c (remote_target::pass_signals)
6227         (remote_target::program_signals): Adjust.
6228         * target-debug.h (target_debug_print_signals): Now takes a
6229         gdb::array_view as parameter.  Adjust.
6230         * target.h (target_ops) <pass_signals, program_signals>: Replace
6231         pointer and length parameters with gdb::array_view.
6232         (target_pass_signals, target_program_signals): Likewise.
6233         * target-delegates.c: Regenerate.
6234
6235 2019-01-24  Pedro Alves  <palves@redhat.com>
6236
6237         * common/forward-scope-exit.h
6238         (forward_scope_exit::forward_scope_exit): Pass arguments to
6239         m_bind_function directly, instead of creating a std::bind and
6240         copying that.
6241
6242 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6243
6244         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6245         for static members.
6246         (pass_in_v_vfp_candidate): Likewise.
6247
6248 2019-01-23  Tom Tromey  <tom@tromey.com>
6249             Pedro Alves  <palves@redhat.com>
6250
6251         * regcache.c (class regcache_invalidator): Remove.
6252         (regcache::raw_write): Use make_scope_exit.
6253
6254 2019-01-23  Tom Tromey  <tom@tromey.com>
6255
6256         * ui-out.h (class ui_out_emit_type): Update comment.
6257
6258 2019-01-23  Tom Tromey  <tom@tromey.com>
6259
6260         * infrun.c (fetch_inferior_event): Update comment.
6261
6262 2019-01-23  Tom Tromey  <tom@tromey.com>
6263             Pedro Alves  <palves@redhat.com>
6264
6265         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6266         parameter.
6267         (fetch_inferior_event): Use SCOPE_EXIT.
6268
6269
6270 2019-01-23  Tom Tromey  <tom@tromey.com>
6271             Pedro Alves  <palves@redhat.com>
6272
6273         * infrun.c (disable_thread_events): Delete.
6274         (stop_all_threads): Use SCOPE_EXIT.
6275
6276 2019-01-23  Tom Tromey  <tom@tromey.com>
6277             Pedro Alves  <palves@redhat.com>
6278
6279         * symfile.c: Include forward-scope-exit.h.
6280         (clear_symtab_users_cleanup): Replace forward declaration with
6281         a FORWARD_SCOPE_EXIT.
6282         (syms_from_objfile_1): Use the forward_scope_exit and
6283         gdb::optional instead of cleanup_function.
6284         (reread_symbols): Use the forward_scope_exit instead of
6285         cleanup_function.
6286         (clear_symtab_users_cleanup): Remove function.
6287
6288 2019-01-23  Tom Tromey  <tom@tromey.com>
6289             Pedro Alves  <palves@redhat.com>
6290
6291         * linux-nat.c: Include scope-exit.h.
6292         (cleanup_target_stop): Remove.
6293         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6294         SCOPE_EXIT.
6295
6296 2019-01-23  Tom Tromey  <tom@tromey.com>
6297             Pedro Alves  <palves@redhat.com>
6298
6299         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6300         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6301
6302 2019-01-23  Tom Tromey  <tom@tromey.com>
6303             Andrew Burgess  <andrew.burgess@embecosm.com>
6304             Pedro Alves  <palves@redhat.com>
6305
6306         * infrun.c (fetch_inferior_event): Use scope_exit.
6307         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6308         * top.c (execute_command): Use scope_exit.
6309         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6310         * utils.c (do_bpstat_clear_actions_cleanup)
6311         (make_bpstat_clear_actions_cleanup): Remove.
6312
6313 2019-01-23  Tom Tromey  <tom@tromey.com>
6314             Pedro Alves  <palves@redhat.com>
6315
6316         * infrun.c: Include "common/scope-exit.h"
6317         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6318         (wait_for_inferior): Use SCOPE_EXIT.
6319         (fetch_inferior_event): Use scope_exit.
6320
6321 2019-01-23  Tom Tromey  <tom@tromey.com>
6322             Pedro Alves  <palves@redhat.com>
6323
6324         * breakpoint.c (create_breakpoint): Remove cleanup.
6325
6326 2019-01-23  Tom Tromey  <tom@tromey.com>
6327             Andrew Burgess  <andrew.burgess@embecosm.com>
6328             Pedro Alves  <palves@redhat.com>
6329
6330 2019-01-23  Pedro Alves  <palves@redhat.com>
6331
6332         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6333
6334 2019-01-23  Pedro Alves  <palves@redhat.com>
6335             Andrew Burgess  <andrew.burgess@embecosm.com>
6336
6337         * gdbthread.h: Include "common/forward-scope-exit.h".
6338         (scoped_finish_thread_state): Redefine custom class in terms of
6339         forward_scope_exit.
6340
6341 2019-01-23  Pedro Alves  <palves@redhat.com>
6342             Andrew Burgess  <andrew.burgess@embecosm.com>
6343
6344         * common/forward-scope-exit.h: New file.
6345
6346 2019-01-23  Pedro Alves  <palves@redhat.com>
6347             Andrew Burgess  <andrew.burgess@embecosm.com>
6348             Tom Tromey  <tom@tromey.com>
6349
6350         * common/scope-exit.h: New file.
6351
6352 2019-01-23  Pedro Alves  <palves@redhat.com>
6353
6354         * common/preprocessor.h (ESC): Rename to ...
6355         (ESC_PARENS): ... this.
6356         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6357         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6358
6359 2019-01-23  Tom Tromey  <tom@tromey.com>
6360
6361         * language.h (class scoped_switch_to_sym_language_if_auto):
6362         Initialize m_lang in both cases.
6363
6364 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6365
6366         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6367         with XCNEW.
6368
6369 2019-01-22  Tom Tromey  <tom@tromey.com>
6370
6371         * corelow.c: Do not include sys/file.h.
6372
6373 2019-01-22  Tom Tromey  <tom@tromey.com>
6374
6375         * tui/tui-wingeneral.h: Include gdb_curses.h.
6376
6377 2019-01-22  Tom Tromey  <tom@tromey.com>
6378
6379         * source-cache.h (class source_cache) <get_source_lines,
6380         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6381
6382 2019-01-22  Tom Tromey  <tom@tromey.com>
6383
6384         * remote-fileio.h (struct remote_target): Declare.
6385
6386 2019-01-22  Tom Tromey  <tom@tromey.com>
6387
6388         * python/py-arch.c: Do not include py-ref.h.
6389         * python/py-bpevent.c: Do not include py-ref.h.
6390         * python/py-cmd.c: Do not include py-ref.h.
6391         * python/py-continueevent.c: Do not include py-ref.h.
6392         * python/py-event.h: Do not include py-ref.h.
6393         * python/py-evtregistry.c: Do not include py-ref.h.
6394         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6395         * python/py-frame.c: Do not include py-ref.h.
6396         * python/py-framefilter.c: Do not include py-ref.h.
6397         * python/py-function.c: Do not include py-ref.h.
6398         * python/py-infevents.c: Do not include py-ref.h.
6399         * python/py-linetable.c: Do not include py-ref.h.
6400         * python/py-objfile.c: Do not include py-ref.h.
6401         * python/py-param.c: Do not include py-ref.h.
6402         * python/py-prettyprint.c: Do not include py-ref.h.
6403         * python/py-progspace.c: Do not include py-ref.h.
6404         * python/py-symbol.c: Do not include py-ref.h.
6405         * python/py-symtab.c: Do not include py-ref.h.
6406         * python/py-type.c: Do not include py-ref.h.
6407         * python/py-unwind.c: Do not include py-ref.h.
6408         * python/py-utils.c: Do not include py-ref.h.
6409         * python/py-value.c: Do not include py-ref.h.
6410         * python/py-varobj.c: Do not include py-ref.h.
6411         * python/py-xmethods.c: Do not include py-ref.h.
6412         * python/python.c: Do not include py-ref.h.
6413         * varobj.c: Do not include py-ref.h.
6414
6415 2019-01-22  Tom Tromey  <tom@tromey.com>
6416
6417         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6418         keyword for bcache.
6419
6420 2019-01-22  Tom Tromey  <tom@tromey.com>
6421
6422         * compile/compile-cplus-types.c: Remove a comment by #include.
6423
6424 2019-01-22  Tom Tromey  <tom@tromey.com>
6425
6426         * compile/gcc-c-plugin.h: Include compile-internal.h.
6427
6428 2019-01-22  Tom Tromey  <tom@tromey.com>
6429
6430         * stabsread.c (EXTERN): Do not define.
6431         (symnum, next_symbol_text_func, processing_gcc_compilation)
6432         (within_function, global_sym_chain, global_stabs)
6433         (previous_stab_code, this_object_header_files)
6434         (n_this_object_header_files)
6435         (n_allocated_this_object_header_files): Define.
6436         * stabsread.h (EXTERN): Never define.  Use "extern".
6437
6438 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6439
6440         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6441         history_value.
6442
6443 2019-01-21  Tom Tromey  <tom@tromey.com>
6444
6445         * ui-out.c: Fix includes.
6446         * tui/tui-source.c: Fix includes.
6447         * target.c: Fix includes.
6448         * remote.c: Fix includes.
6449         * regcache.c: Fix includes.
6450         * python/py-block.c: Fix includes.
6451         * printcmd.c: Fix includes.
6452         * or1k-tdep.c: Fix includes.
6453         * mi/mi-main.c: Fix includes.
6454         * m32r-tdep.c: Fix includes.
6455         * csky-tdep.c: Fix includes.
6456         * compile/compile-cplus-types.c: Fix includes.
6457         * cli/cli-interp.c: Fix includes.
6458
6459 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6460
6461         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6462         for padding.
6463
6464 2019-01-16  Tom Tromey  <tom@tromey.com>
6465
6466         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6467         earlier.
6468         (struct objfile) <msymbols_range>: Move from top level.
6469         <msymbols>: New method.
6470         (class objfile_msymbols): Remove.
6471         * symtab.c (default_collect_symbol_completion_matches_break_on):
6472         Update.
6473         * symmisc.c (dump_msymbols): Update.
6474         * stabsread.c (scan_file_globals): Update.
6475         * objc-lang.c (info_selectors_command, info_classes_command)
6476         (find_methods): Update.
6477         * minsyms.c (find_solib_trampoline_target): Update.
6478         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6479         * coffread.c (coff_symfile_read): Update.
6480         * ada-lang.c (ada_lookup_simple_minsym)
6481         (ada_collect_symbol_completion_matches): Update.
6482
6483 2019-01-16  Tom Tromey  <tom@tromey.com>
6484
6485         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6486         type.  Remove no-argument constructor.
6487         <iterator::operator++>: Simplify.
6488         <begin>: Update.
6489         <end>: Use minimal_symbol_count.
6490
6491 2019-01-16  Tom Tromey  <tom@tromey.com>
6492
6493         * objfiles.h (struct objfile) <psymtabs>: New method.
6494         (class objfile_psymtabs): Remove.
6495         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6496         typedef.
6497         <range>: New method.
6498         (require_partial_symbols): Change return type.
6499         * psymtab.c (require_partial_symbols)
6500         (psym_expand_symtabs_matching): Update.
6501         * mdebugread.c (parse_partial_symbols): Update.
6502         * dbxread.c (dbx_end_psymtab): Update.
6503
6504 2019-01-15  Tom Tromey  <tom@tromey.com>
6505
6506         * symtab.c (lookup_objfile_from_block)
6507         (lookup_symbol_in_objfile_symtabs)
6508         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6509         (find_line_symtab, info_sources_command)
6510         (default_collect_symbol_completion_matches_break_on)
6511         (make_source_files_completion_list): Update.
6512         * symmisc.c (print_objfile_statistics, dump_objfile)
6513         (maintenance_print_symbols, maintenance_info_symtabs)
6514         (maintenance_check_symtabs, maintenance_info_line_tables):
6515         Update.
6516         * source.c (select_source_symtab)
6517         (forget_cached_source_info_for_objfile): Update.
6518         * objfiles.h (class objfile_compunits): Remove.
6519         (struct objfile) <compunits_range>: New typedef.
6520         (compunits): New method.
6521         * objfiles.c (objfile_relocate1): Update.
6522         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6523         * maint.c (count_symtabs_and_blocks): Update.
6524         * linespec.c (iterate_over_all_matching_symtabs): Update.
6525         * cp-support.c (add_symbol_overload_list_qualified): Update.
6526         * coffread.c (coff_symtab_read): Update.
6527         * ada-lang.c (add_nonlocal_symbols)
6528         (ada_collect_symbol_completion_matches)
6529         (ada_add_global_exceptions): Update.
6530
6531 2019-01-15  Tom Tromey  <tom@tromey.com>
6532
6533         * progspace.h (program_space) <objfiles_safe_range>: New
6534         typedef.
6535         <objfiles_safe>: New method.
6536         * objfiles.h (class all_objfiles_safe): Remove.
6537         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6538         * jit.c (jit_inferior_exit_hook): Update.
6539
6540 2019-01-17  Tom Tromey  <tom@tromey.com>
6541
6542         * progspace.h (program_space) <objfiles_range>: New typedef.
6543         <objfiles>: New method.
6544         <objfiles_head>: Rename from objfiles.
6545         (object_files): Update.
6546         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6547         * guile/scm-pretty-print.c
6548         (ppscm_find_pretty_printer_from_objfiles): Update.
6549         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6550         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6551         Update.
6552         * python/py-progspace.c (pspy_get_objfiles): Update.
6553         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6554         Update.
6555         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6556         (objfpy_lookup_objfile_by_build_id): Update.
6557         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6558         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6559         Update.
6560         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6561         (expand_symtab_containing_pc, lookup_objfile_from_block)
6562         (lookup_static_symbol, basic_lookup_transparent_type)
6563         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6564         (find_line_symtab, info_sources_command)
6565         (default_collect_symbol_completion_matches_break_on)
6566         (make_source_files_completion_list, find_main_name): Update.
6567         * symmisc.c (print_symbol_bcache_statistics)
6568         (print_objfile_statistics, maintenance_print_symbols)
6569         (maintenance_print_msymbols, maintenance_print_objfiles)
6570         (maintenance_info_symtabs, maintenance_check_symtabs)
6571         (maintenance_expand_symtabs, maintenance_info_line_tables):
6572         Update.
6573         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6574         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6575         (map_overlay_command, unmap_overlay_command)
6576         (simple_overlay_update, expand_symtabs_matching)
6577         (map_symbol_filenames): Update.
6578         * symfile-debug.c (set_debug_symfile): Update.
6579         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6580         Update.
6581         * source.c (select_source_symtab, forget_cached_source_info):
6582         Update.
6583         * solib.c (solib_read_symbols): Update.
6584         * solib-spu.c (append_ocl_sos): Update.
6585         * psymtab.c (maintenance_print_psymbols)
6586         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6587         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6588         * printcmd.c (info_symbol_command): Update.
6589         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6590         Update.
6591         * objfiles.h (class all_objfiles): Remove.
6592         * objfiles.c (have_partial_symbols, have_full_symbols)
6593         (have_minimal_symbols, qsort_cmp, update_section_map)
6594         (shared_objfile_contains_address_p)
6595         (default_iterate_over_objfiles_in_search_order): Update.
6596         * objc-lang.c (info_selectors_command, info_classes_command)
6597         (find_methods): Update.
6598         * minsyms.c (find_solib_trampoline_target): Update.
6599         * maint.c (maintenance_info_sections)
6600         (maintenance_translate_address, count_symtabs_and_blocks):
6601         Update.
6602         * main.c (captured_main_1): Update.
6603         * linux-thread-db.c (try_thread_db_load_from_pdir)
6604         (has_libpthread): Update.
6605         * linespec.c (iterate_over_all_matching_symtabs)
6606         (search_minsyms_for_name): Update.
6607         * jit.c (jit_find_objf_with_entry_addr): Update.
6608         * hppa-tdep.c (find_unwind_entry)
6609         (hppa_lookup_stub_minimal_symbol): Update.
6610         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6611         Update.
6612         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6613         (elf_gnu_ifunc_resolve_by_got): Update.
6614         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6615         * dwarf-index-write.c (save_gdb_index_command): Update.
6616         * cp-support.c (add_symbol_overload_list_qualified): Update.
6617         * breakpoint.c (create_overlay_event_breakpoint)
6618         (create_longjmp_master_breakpoint)
6619         (create_std_terminate_master_breakpoint)
6620         (create_exception_master_breakpoint): Update.
6621         * blockframe.c (find_pc_partial_function): Update.
6622         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6623         (ada_collect_symbol_completion_matches)
6624         (ada_add_global_exceptions): Update.
6625
6626 2019-01-17  Tom Tromey  <tom@tromey.com>
6627
6628         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6629         declare VEC.
6630         (solib_target_parse_libraries): Change return type.
6631         (library_list_start_segment, library_list_start_section)
6632         (library_list_end_library, library_list_start_library); Update.
6633         (solib_target_free_library_list): Remove.
6634         (solib_target_parse_libraries): Remove cleanup.  Change return
6635         type.
6636         (solib_target_current_sos): Update.
6637
6638 2019-01-17  Tom Tromey  <tromey@bapiya>
6639
6640         * valprint.c: Replace "the the" with "the".
6641         * symtab.c: Replace "the the" with "the".
6642         * solib.c: Replace "the the" with "the".
6643         * solib-dsbt.c: Replace "the the" with "the".
6644         * linespec.c: Replace "the the" with "the".
6645         * dwarf2loc.h: Replace "the the" with "the".
6646         * amd64-windows-tdep.c: Replace "the the" with "the".
6647         * aarch64-tdep.c: Replace "the the" with "the".
6648
6649 2019-01-16  Keith Seitz  <keiths@redhat.com>
6650
6651         PR gdb/23773
6652         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6653         <builder>: Rename to ..
6654         <m_builder>: ... this and make private.
6655         (dwarf2_cu::get_builder): New method.  Change all users of
6656         `builder' to use this method.
6657         (dwarf2_start_symtab): Move to ...
6658         (dwarf2_cu::start_symtab): ... here.  Update all callers
6659         (setup_type_unit_groups): Move to ...
6660         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6661         callers.
6662         (dwarf2_cu::reset_builder): New method.
6663         (process_full_compunit, process_full_type_unit): Use
6664         dwarf2_cu::reset_builder.
6665         (follow_die_offset): Record the ancestor CU if it is different
6666         from the followed DIE's CU.
6667         (follow_die_sig_1): Likewise.
6668
6669 2019-01-15  Tom Tromey  <tom@tromey.com>
6670
6671         * remote.c (class remote_state) <buf>: Now a char_vector.
6672         <buf_size>: Remove.
6673         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6674         parameter.
6675         (remote_target::getpkt_or_notif_sane_1)
6676         (remote_target::getpkt_sane)
6677         (remote_target::getpkt_or_notif_sane): Likewise.
6678         (class remote_target) <putpkt>: New overload.
6679         (remote_target::read_frame): Change type of "buf_p".  Remove
6680         sizeof_p parameter.
6681         (packet_ok): New overload.
6682         (packet_check_result): New overload.
6683         Update all uses.
6684
6685 2019-01-14  Tom Tromey  <tom@tromey.com>
6686
6687         * remote-notif.c (handle_notification, remote_notif_ack)
6688         (remote_notif_parse): Make "buf" const.
6689         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6690         const.
6691         (remote_notif_parse, remote_notif_ack, handle_notification):
6692         Likewise.
6693         * remote.c (remote_notif_stop_parse): Make "buf" const.
6694         (remote_target::remote_parse_stop_reply): Make "buf" const.
6695         (remote_notif_stop_ack): Make "buf" const.
6696
6697 2019-01-14  Tom Tromey  <tom@tromey.com>
6698
6699         * remote.c (remote_console_output): Make parameter const.
6700
6701 2019-01-14  Tom Tromey  <tom@tromey.com>
6702
6703         * target-debug.h (target_debug_print_signals): Constify.
6704         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6705         * procfs.c (procfs_target::pass_signals): Update.
6706         * linux-nat.c (linux_nat_target::pass_signals): Update.
6707         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6708         * target-delegates.c: Rebuild.
6709         * remote.c (remote_target::program_signals): Update.
6710         (remote_target::pass_signals): Update.
6711         * target.c (target_pass_signals): Constify argument.
6712         (target_program_signals): Likewise.
6713         * target.h (struct target_ops) <pass_signals, program_signals>:
6714         Constify argument.
6715         (target_pass_signals, target_program_signals): Constify argument.
6716
6717 2019-01-14  Tom Tromey  <tom@tromey.com>
6718
6719         PR tui/28819:
6720         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6721
6722 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6723
6724         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6725         field.
6726         * rs6000-tdep.c: Include reggroups.h.
6727         (IS_V_ALIAS_PSEUDOREG): Define.
6728         (rs6000_register_name): Return names for the "vX" aliases.
6729         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6730         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6731         aliases.  Call default_register_reggroup_p for all other
6732         pseudo-registers.
6733         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6734         New functions.
6735         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6736         Handle "vX" aliases.
6737         (v_alias_pseudo_register_collect): New function.
6738         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6739         (rs6000_gdbarch_init): Initialize "vX" aliases as
6740         pseudo-registers.  Restore registration of
6741         rs6000_pseudo_register_reggroup_p with
6742         set_tdesc_pseudo_register_reggroup_p.
6743
6744 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6745
6746         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6747         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6748         set_gdbarch_num_pseudo_regs.
6749
6750 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6751
6752         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6753         Remove arg prefixname, add do_set and do_show.
6754         Add member functions set_list and show_list.
6755         * cli/cli-style.c (class cli_style_option): Update accordingly.
6756         (style_set_list): Move to file scope.
6757         (style_show_list): Likewise.
6758         (set_style): Call help_list.
6759         (show_style): Call cmd_show_list.
6760         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6761         Update to use the new macro.
6762
6763 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6764
6765         * ada-lang.c (_initialize_ada_language): Expand the help text
6766         for the "catch exception" command.
6767
6768 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6769
6770         * symtab.c (matching_obj_sections): Initialize obj,
6771         declare it closer to its usage.
6772
6773 2019-01-10  Tom Tromey  <tom@tromey.com>
6774
6775         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6776         (basic_inf_threads_range): Remove.
6777         (inf_threads_range, inf_non_exited_threads_range)
6778         (safe_inf_threads_range): Use next_adapter.
6779
6780 2019-01-10  Keith Seitz  <keiths@redhat.com>
6781
6782         PR gdb/23712
6783         PR symtab/23010
6784         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6785         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6786
6787 2019-01-10  Keith Seitz  <keiths@redhat.com>
6788
6789         PR gdb/23712
6790         PR symtab/23010
6791         * dictionary.c (pending_to_vector): Remove.
6792         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6793         Remove _1 suffix, replacing functions of the same name.  Update
6794         all callers.
6795         (dict_create_hashed, dict_create_hashed_expandable)
6796         (dict_create_linear, dict_create_linear_expandable, dict_free)
6797         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6798         Make functions static.
6799
6800 2019-01-10  Keith Seitz  <keiths@redhat.com>
6801
6802         PR gdb/23712
6803         PR symtab/23010
6804         * dictionary.h (struct dictionary): Replace declaration with
6805         multidictionary.
6806         (dict_create_hashed, dict_create_hashed_expandable)
6807         (dict_create_linear, dict_create_linear_expandable)
6808         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6809         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6810         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6811         taking multidictionary argument.
6812         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6813         * block.h (struct block) <dict>: Change to multidictionary
6814         and rename `multidict'.
6815         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6816         symmisc.c: Update all dictionary references to multidictionary.
6817
6818 2019-01-10  Keith Seitz  <keiths@redhat.com>
6819
6820         PR gdb/23712
6821         PR symtab/23010
6822         * dictionary.c: Include unordered_map.
6823         (pending_to_vector): New function.
6824         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6825         Rewrite the non-"_1" functions to take vector instead
6826         of linked list.
6827         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6828         "new" _1 versions of the same name.
6829         (multidictionary): Define.
6830         (std::hash<enum language): New definition.
6831         (collate_pending_symbols_by_language, mdict_create_hashed)
6832         (mdict_create_hashed_expandable, mdict_create_linear)
6833         (mdict_create_linear_expandable, mdict_free)
6834         (find_language_dictionary, create_new_language_dictionary)
6835         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6836         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6837         (mdict_size, mdict_empty): New functions.
6838         * dictionary.h (mdict_iterator): Define.
6839
6840 2019-01-10  Pedro Alves  <palves@redhat.com>
6841
6842         * breakpoint.c (read_uploaded_action)
6843         (create_tracepoint_from_upload): Adjust to use
6844         gdb::unique_xmalloc_ptr.
6845         * ctf.c (ctf_write_uploaded_tp):
6846         (SET_ARRAY_FIELD): Use emplace_back.
6847         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6848         * tracefile-tfile.c (tfile_write_uploaded_tp):
6849         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6850         gdb::unique_xmalloc_ptr.
6851         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6852         at_string, cond_string, cmd_strings>: Replace char pointers
6853         with gdb::unique_xmalloc_ptr.
6854
6855 2019-01-10  Pedro Alves  <palves@redhat.com>
6856
6857         * solib-target.c (library_list_start_library): Don't xstrdup name.
6858
6859 2019-01-10  Pedro Alves  <palves@redhat.com>
6860
6861         * mdebugread.c (parse_partial_symbols): Use
6862         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6863
6864 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6865
6866         * linux-fork.c (scoped_switch_fork_info)
6867         <~scoped_switch_fork_info>: Fix incorrect variable name.
6868
6869 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6870
6871         * linux-fork.c (scoped_switch_fork_info)
6872         <scoped_switch_fork_info>: Make explicit.
6873         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6874
6875 2019-01-10  Tom Tromey  <tom@tromey.com>
6876
6877         * objfiles.h (objfile::reset_psymtabs): Update.
6878         * objfiles.c (objfile::objfile): Update.
6879         * psymtab.h (psymtab_storage::obstack): Update.
6880         (psymtab_storage::m_obstack): Use gdb::optional.
6881         (class psymtab_storage): Update comment.  Remove objfile
6882         parameter.
6883         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6884
6885 2019-01-10  Tom Tromey  <tom@tromey.com>
6886
6887         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6888         <free_psymtabs>: Now private.
6889         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6890         (allocate_psymtab): Use new method.
6891
6892 2019-01-10  Tom Tromey  <tom@tromey.com>
6893
6894         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6895         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6896         * mdebugread.c (parse_partial_symbols): Use
6897         allocate_dependencies.
6898         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6899         allocate_dependencies.
6900         (process_psymtab_comp_unit_reader)
6901         (build_type_psymtab_dependencies): Likewise.
6902         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6903
6904 2019-01-10  Tom Tromey  <tom@tromey.com>
6905
6906         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6907         PSYMBOL_SET_LANGUAGE.
6908         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6909
6910 2019-01-10  Tom Tromey  <tom@tromey.com>
6911
6912         * psymtab.h (psymtab_storage::obstack): New method.
6913         <m_obstack>: Rename from obstack; now private.
6914         * psymtab.c (psymtab_storage): Update.
6915         * dwarf2read.c (create_addrmap_from_index)
6916         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6917         Update.
6918
6919 2019-01-10  Tom Tromey  <tom@tromey.com>
6920
6921         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6922         * objfiles.h (objfile::reset_psymtabs): New method.
6923
6924 2019-01-10  Tom Tromey  <tom@tromey.com>
6925
6926         * symmisc.c (print_symbol_bcache_statistics): Update.
6927         (print_objfile_statistics): Update.
6928         * symfile.c (reread_symbols): Update.
6929         * psymtab.h (class psymtab_storage): New.
6930         * psymtab.c (psymtab_storage): New constructor.
6931         (~psymtab_storage): New destructor.
6932         (require_partial_symbols): Update.
6933         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6934         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6935         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6936         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6937         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6938         (start_psymtab_common, end_psymtab_common)
6939         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6940         (allocate_psymtab): Update.
6941         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6942         Update.
6943         (dump_psymtab_addrmap, maintenance_print_psymbols)
6944         (maintenance_check_psymtabs): Update.
6945         (class objfile_psymtabs): Move to objfiles.h.
6946         * psympriv.h (discard_psymtab): Now inline.
6947         (psymtab_discarder::psymtab_discarder): Update.
6948         (psymtab_discarder::~psymtab_discarder): Update.
6949         (ALL_OBJFILE_PSYMTABS): Rewrite.
6950         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6951         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6952         Remove fields.
6953         <partial_symtabs>: New field.
6954         (class objfile_psymtabs): Move from psymtab.h.  Update.
6955         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6956         psymbol_cache.
6957         (objfile::~objfile): Don't destroy psymbol_cache.
6958         * mdebugread.c (parse_partial_symbols): Update.
6959         * dwarf2read.c (create_addrmap_from_index)
6960         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6961         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6962         (add_partial_subprogram, dwarf2_ranges_read): Update.
6963         * dwarf-index-write.c (write_address_map)
6964         (write_one_signatured_type, recursively_write_psymbols)
6965         (class debug_names, class debug_names, write_psymtabs_to_index):
6966         Update.
6967
6968 2019-01-10  Tom Tromey  <tom@tromey.com>
6969
6970         * symtab.h (SYMBOL_SET_NAMES): Update.
6971         (symbol_set_names): Update.
6972         (MSYMBOL_SET_NAMES): Update.
6973         * symtab.c (symbol_set_names): Change argument to be an
6974         objfile_per_bfd_storage.
6975         * psymtab.c (add_psymbol_to_bcache): Update.
6976         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6977
6978 2019-01-10  Tom Tromey  <tom@tromey.com>
6979
6980         * symtab.c (create_demangled_names_hash): Change argument to be an
6981         objfile_per_bfd_storage.
6982         (symbol_set_names): Update.
6983
6984 2019-01-10  Tom Tromey  <tom@tromey.com>
6985
6986         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6987         init_psymbol_list.
6988         * psymtab.c (init_psymbol_list): Do nothing if already called.
6989         * psympriv.h (init_psymbol_list): Add comment.
6990         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6991         init_psymbol_list.
6992         * dbxread.c (dbx_symfile_read): Unconditionally call
6993         init_psymbol_list.
6994
6995 2019-01-10  Tom Tromey  <tom@tromey.com>
6996
6997         * xcoffread.c (scan_xcoff_symtab): Update.
6998         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6999         "where".
7000         * mdebugread.c (parse_partial_symbols)
7001         (handle_psymbol_enumerators): Update.
7002         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7003         * dbxread.c (read_dbx_symtab): Update.
7004         * psympriv.h (psymbol_placement): New enum.
7005         (add_psymbol_to_list): Update.
7006
7007 2019-01-10  Tom Tromey  <tom@tromey.com>
7008
7009         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7010         static_psymbols parameters.
7011         (scan_xcoff_symtab): Update.
7012         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7013         static_psymbols parameters.
7014         * psympriv.h (start_psymtab_common): Update.
7015         * mdebugread.c (parse_partial_symbols): Update.
7016         * dwarf2read.c (create_partial_symtab): Update.
7017         * dbxread.c (read_dbx_symtab): Update.
7018         (start_psymtab): Remove global_psymbols and static_psymbols
7019         parameters.
7020
7021 2019-01-10  Tom Tromey  <tom@tromey.com>
7022
7023         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7024         * psymtab.c (allocate_psymtab): Add comment.
7025         * psympriv.h (allocate_psymtab): Add comment.
7026         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7027         initializations.
7028         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7029
7030 2019-01-10  Tom Tromey  <tom@tromey.com>
7031
7032         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7033         Don't declare.
7034         * mipsread.c: Include mdebugread.h.
7035         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7036         Declare.
7037         * elfread.c: Include mdebugread.h.
7038
7039 2019-01-09  Tom Tromey  <tom@tromey.com>
7040
7041         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7042         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7043         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7044         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7045         (psym_lookup_symbol, psym_find_last_source_symtab)
7046         (psym_forget_cached_source_info, psym_print_stats)
7047         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7048         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7049         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7050         (psym_find_compunit_symtab_by_address)
7051         (maintenance_print_psymbols, maintenance_info_psymtabs)
7052         (maintenance_check_psymtabs): Use ranged for.
7053         * psymtab.h (class objfile_psymtabs): New.
7054         (require_partial_symbols): Return objfile_psymtabs.
7055         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7056
7057 2019-01-09  Tom Tromey  <tom@tromey.com>
7058
7059         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7060         (find_pc_mapped_section, list_overlays_command)
7061         (map_overlay_command, unmap_overlay_command)
7062         (simple_overlay_update): Use all_objfiles.
7063         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7064         * printcmd.c (info_symbol_command): Use all_objfiles.
7065         * objfiles.h (ALL_OBJSECTIONS): Remove.
7066         * maint.c (maintenance_translate_address): Use all_objfiles.
7067         * gcore.c (gcore_create_callback): Use all_objfiles.
7068         (objfile_find_memory_regions): Likewise.
7069
7070 2019-01-09  Tom Tromey  <tom@tromey.com>
7071
7072         * symtab.c (find_line_symtab, info_sources_command)
7073         (make_source_files_completion_list): Use objfile_compunits.
7074         * source.c (select_source_symtab): Use objfile_compunits.
7075         * objfiles.h (struct objfile): Update comment.
7076         (ALL_OBJFILES): Remove.
7077         (ALL_FILETABS): Remove.
7078         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7079         objfile_compunits.
7080
7081 2019-01-09  Tom Tromey  <tom@tromey.com>
7082
7083         * symmisc.c (print_objfile_statistics, dump_objfile)
7084         (maintenance_print_symbols): Use compunit_filetabs.
7085         * source.c (forget_cached_source_info_for_objfile): Use
7086         compunit_filetabs.
7087         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7088         (ALL_FILETABS): Use compunit_filetabs.
7089         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7090         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7091
7092 2019-01-09  Tom Tromey  <tom@tromey.com>
7093
7094         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7095         (compunit_filetabs): New.
7096         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7097         compunit_filetabs.
7098         (info_sources_command, make_source_files_completion_list): Remove
7099         declaration.
7100         * symmisc.c (print_objfile_statistics, dump_objfile)
7101         (maintenance_print_symbols): Remove declaration.
7102         (maintenance_info_symtabs): Use compunit_filetabs.
7103         (maintenance_info_line_tables): Likewise.
7104         * source.c (select_source_symtab): Change local variable name.
7105         (forget_cached_source_info_for_objfile): Remove declaration.
7106         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7107         * objfiles.c (objfile_relocate1): Remove declaration.
7108         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7109         declaration.
7110         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7111         * coffread.c (coff_symtab_read): Remove declaration.
7112         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7113         compunit_filetabs.
7114
7115 2019-01-09  Tom Tromey  <tom@tromey.com>
7116
7117         * symtab.c (lookup_objfile_from_block)
7118         (find_pc_sect_compunit_symtab, search_symbols)
7119         (default_collect_symbol_completion_matches_break_on): Use
7120         objfile_compunits.
7121         * objfiles.h (ALL_COMPUNITS): Remove.
7122         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7123         * cp-support.c (add_symbol_overload_list_qualified): Use
7124         objfile_compunits.
7125         * ada-lang.c (ada_collect_symbol_completion_matches)
7126         (ada_add_global_exceptions): Use objfile_compunits.
7127
7128 2019-01-09  Tom Tromey  <tom@tromey.com>
7129
7130         * source.c (select_source_symtab)
7131         (forget_cached_source_info_for_objfile): Remove declaration.
7132         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7133         declaration.
7134         * maint.c (count_symtabs_and_blocks): Remove declaration.
7135         * cp-support.c (add_symbol_overload_list_qualified): Remove
7136         declaration.
7137         * coffread.c (coff_symtab_read): Remove declaration.
7138         * symtab.c (lookup_symbol_in_objfile_symtabs)
7139         (basic_lookup_transparent_type_1): Use objfile_compunits.
7140         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7141         (info_sources_command, search_symbols)
7142         (default_collect_symbol_completion_matches_break_on)
7143         (make_source_files_completion_list): Remove declaration.
7144         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7145         (ada_collect_symbol_completion_matches)
7146         (ada_add_global_exceptions): Remove declaration.
7147         * linespec.c (iterate_over_all_matching_symtabs): Use
7148         objfile_compunits.
7149         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7150         (class objfile_compunits): New.
7151         (ALL_COMPUNITS): Use objfile_compunits.
7152         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7153         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7154         objfile_compunits.
7155         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7156
7157 2019-01-09  Tom Tromey  <tom@tromey.com>
7158
7159         * symtab.c (search_symbols)
7160         (default_collect_symbol_completion_matches_break_on): Use
7161         objfile_msymbols.
7162         * ada-lang.c (ada_lookup_simple_minsym)
7163         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7164         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7165         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7166         objfile_msymbols.
7167         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7168         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7169         * objc-lang.c (find_methods): Use objfile_msymbols.
7170         (info_selectors_command, info_classes_command): Likewise.
7171         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7172         * objfiles.h (class objfile_msymbols): New.
7173         (ALL_OBJFILE_MSYMBOLS): Remove.
7174         (ALL_MSYMBOLS): Remove.
7175
7176 2019-01-09  Tom Tromey  <tom@tromey.com>
7177
7178         * common/next-iterator.h (next_adapter): Add Iterator template
7179         parameter.
7180         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7181         (class all_objfiles_safe): New.
7182         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7183         * objfiles.c (put_objfile_before): Update comment.
7184         (add_separate_debug_objfile): Likewise.
7185         (free_all_objfiles): Use all_objfiles_safe.
7186         (objfile_purge_solibs): Likewise.
7187
7188 2019-01-09  Tom Tromey  <tom@tromey.com>
7189
7190         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7191         (expand_symtab_containing_pc, lookup_static_symbol)
7192         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7193         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7194         all_objfiles.
7195         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7196         * breakpoint.c (create_overlay_event_breakpoint)
7197         (create_longjmp_master_breakpoint)
7198         (create_std_terminate_master_breakpoint)
7199         (create_exception_master_breakpoint): Use all_objfiles.
7200         * linux-thread-db.c (try_thread_db_load_from_pdir)
7201         (has_libpthread): Use all_objfiles.
7202         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7203         * linespec.c (iterate_over_all_matching_symtabs)
7204         (search_minsyms_for_name): Use all_objfiles.
7205         * maint.c (maintenance_info_sections): Use all_objfiles.
7206         * main.c (captured_main_1): Use all_objfiles.
7207         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7208         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7209         * guile/scm-pretty-print.c
7210         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7211         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7212         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7213         (maintenance_print_msymbols): Use all_objfiles.
7214         * source.c (select_source_symtab): Use all_objfiles.
7215         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7216         * symfile.c (remove_symbol_file_command)
7217         (expand_symtabs_matching, map_symbol_filenames): Use
7218         all_objfiles.
7219         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7220         all_objfiles.
7221         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7222         * objc-lang.c (find_methods): Use all_objfiles.
7223         * objfiles.c (have_partial_symbols, have_full_symbols)
7224         (have_minimal_symbols, qsort_cmp)
7225         (default_iterate_over_objfiles_in_search_order): Use
7226         all_objfiles.
7227         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7228         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7229         (maintenance_check_psymtabs): Use all_objfiles.
7230         (ALL_PSYMTABS): Remove.
7231         * compile/compile-object-run.c (do_module_cleanup): Use
7232         all_objfiles.
7233         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7234         * cp-support.c (add_symbol_overload_list_qualified): Use
7235         all_objfiles.
7236         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7237         Use all_objfiles.
7238         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7239         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7240         all_objfiles.
7241         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7242         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7243         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7244         Uses all_objfiles.
7245         * solib.c (solib_read_symbols): Use all_objfiles
7246
7247 2019-01-09  Tom Tromey  <tom@tromey.com>
7248
7249         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7250         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7251         all_objfiles.
7252         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7253         * symmisc.c (print_symbol_bcache_statistics)
7254         (print_objfile_statistics, maintenance_print_objfiles)
7255         (maintenance_info_symtabs, maintenance_check_symtabs)
7256         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7257         all_objfiles.
7258         * source.c (forget_cached_source_info): Use all_objfiles.
7259         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7260         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7261         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7262         * objfiles.c (update_section_map): Use all_objfiles.
7263         (shared_objfile_contains_address_p): Likewise.
7264         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7265         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7266
7267 2019-01-09  Tom Tromey  <tom@tromey.com>
7268
7269         * common/next-iterator.h: New file.
7270         * objfiles.h (class all_objfiles): New.
7271         (struct objfile_iterator): New.
7272
7273 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7274
7275         * NEWS: Move the description of the changed "frame", "select-frame",
7276          and "info frame" commands to the Changed commands section.
7277
7278 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7279
7280         * gdbtypes.c (check_stub_method_group): Remove handling of old
7281         mangling schemes.
7282         * linespec.c (find_methods): Likewise.
7283         * stabsread.c (read_member_functions): Likewise.
7284         * valops.c (search_struct_method): Likewise.
7285         (value_struct_elt_for_reference): Likewise.
7286         * NEWS: Mention this change.
7287
7288 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7289
7290         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7291         print_source_lines.
7292         * source.c (print_source_lines_base): Update line number check.
7293         (print_source_lines): New function.
7294         (source_lines_range::source_lines_range): New function.
7295         * source.h (class source_lines_range): New class.
7296         (print_source_lines): New declaration.
7297
7298 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7299
7300         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7301
7302 2019-01-08  Tom Tromey  <tom@tromey.com>
7303             Simon Marchi  <simon.marchi@ericsson.com>
7304
7305         PR gdb/24060
7306         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7307         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7308         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7309         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7310         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7311         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7312
7313 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7314
7315         * source.c (select_source_symtab): Move header comment to
7316         declaration in source.h.
7317         (forget_cached_source_info_for_objfile): Likewise.
7318         (forget_cached_source_info): Likewise.
7319         (identify_source_line): Likewise.
7320         * source.h (identify_source_line): Move declaration from symtab.h
7321         and add comment from source.c
7322         (print_source_lines): Likewise.
7323         (forget_cached_source_info_for_objfile): Likewise.
7324         (forget_cached_source_info): Likewise.
7325         (select_source_symtab): Likewise.
7326         (enum print_source_lines_flag): Move definition from symtab.h.
7327         * symtab.h (identify_source_line): Move declaration to source.h.
7328         (print_source_lines): Likewise.
7329         (forget_cached_source_info_for_objfile): Likewise.
7330         (forget_cached_source_info): Likewise.
7331         (select_source_symtab): Likewise.
7332         (enum print_source_lines_flag): Move definition to source.h.
7333         * tui/tui-hooks.c: Add 'source.h' include.
7334
7335 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7336
7337         * source.c (print_source_lines_base): Handle requests to print
7338         reverse line number sequences, and guard against empty lines
7339         string.
7340
7341 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7342
7343         * source.c (print_source_lines_base): Fix skip of '\r' if next
7344         character is '\n'.
7345
7346 2019-01-06  Tom Tromey  <tom@tromey.com>
7347
7348         * c-exp.y (struct c_parse_state) <macro_original_text,
7349         expansion_obstack>: New member.
7350         (macro_original_text, expansion_obstack): Remove globals.
7351         (scan_macro_expansion, scanning_macro_expansion)
7352         (finished_macro_expansion): Update.
7353         (scan_macro_cleanup): Remove.
7354         (yylex, c_parse): Update.
7355
7356 2019-01-06  Tom Tromey  <tom@tromey.com>
7357
7358         * c-exp.y (struct c_parse_state) <strings>: New member.
7359         (operator_stoken): Update.
7360
7361 2019-01-06  Tom Tromey  <tom@tromey.com>
7362
7363         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7364         (union type_stack_elt) <typelist_val>: Now a pointer to
7365         std::vector.
7366         (type_stack_cleanup): Don't declare.
7367         (push_typelist): Update.
7368         * parse.c (pop_typelist): Return a std::vector.
7369         (push_typelist): Take a std::vector.
7370         (follow_types): Update.  Do not free args.
7371         (type_stack_cleanup): Remove.
7372         * c-exp.y (struct c_parse_state): New.
7373         (cpstate): New global.
7374         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7375         (nonempty_typelist): Update.
7376         (func_mod): Create a new vector.
7377         (c_parse): Create a c_parse_state.
7378         (check_parameter_typelist): Do not delete params.
7379         (function_method): Update.  Do not delete type_list.
7380
7381 2019-01-06  Tom Tromey  <tom@tromey.com>
7382
7383         PR gdb/28155:
7384         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7385         check_typedef.
7386         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7387         (print_return_value): Likewise.
7388
7389 2019-01-05  Tom Tromey  <tom@tromey.com>
7390
7391         * contrib/cleanup_check.py: Remove.
7392         * contrib/gcc-with-excheck: Remove.
7393         * contrib/exsummary.py: Remove.
7394         * contrib/excheck.py: Remove.
7395
7396 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7397
7398         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7399         NULL. Initialize tpprev to NULL instead of assigning it
7400         to NULL on the next statement.
7401         * windows-nat.c (windows_delete_thread): Remove check for
7402         main_thread_id before printing thread exit notifications.
7403         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7404         Remove thread ID check against main_thread_id.
7405         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7406         windows_delete_thread.
7407         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7408
7409 2019-01-04  Tom Tromey  <tom@tromey.com>
7410
7411         * compile/compile.c (_initialize_compile): Use upper case for
7412         metasyntactic variables.
7413         * symmisc.c (_initialize_symmisc): Use upper case for
7414         metasyntactic variables.
7415         * psymtab.c (_initialize_psymtab): Use upper case for
7416         metasyntactic variables.
7417         * demangle.c (demangle_command): Use upper case for metasyntactic
7418         variables.
7419         (_initialize_demangler): Likewise.
7420         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7421         variables.
7422
7423 2019-01-03  Tom Tromey  <tom@tromey.com>
7424
7425         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7426
7427 2019-01-03  Tom Tromey  <tom@tromey.com>
7428
7429         * python/py-symtab.c (salpy_str): Update.
7430         (struct salpy_sal_object) <symtab>: Now a PyObject.
7431         (salpy_dealloc): Update.
7432         (del_objfile_sal): Use gdbpy_ref.
7433
7434 2019-01-03  Tom Tromey  <tom@tromey.com>
7435
7436         * python/py-type.c (convert_field): Use new_reference.  Return
7437         gdbpy_ref.
7438         (make_fielditem): Return gdbpy_ref.
7439         (typy_fields): Update.
7440         (typy_getitem): Update.
7441         (field_name): Return gdbpy_ref.  Use new_reference.
7442         (typy_iterator_iternext): Update.
7443
7444 2019-01-03  Tom Tromey  <tom@tromey.com>
7445
7446         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7447
7448 2019-01-03  Tom Tromey  <tom@tromey.com>
7449
7450         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7451         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7452         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7453         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7454         (pspy_set_type_printers): Likewise.
7455         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7456         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7457         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7458         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7459         (objfpy_set_type_printers): Likewise.
7460
7461 2019-01-03  Tom Tromey  <tom@tromey.com>
7462
7463         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7464         (gdbpy_print_stack): Use gdbpy_err_fetch.
7465         * python/python-internal.h (class gdbpy_err_fetch): New class.
7466         (class gdbpy_enter) <m_error_type, m_error_value,
7467         m_error_traceback>: Remove.
7468         <m_error>: New member.
7469         (gdbpy_exception_to_string): Don't declare.
7470         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7471         * python/py-value.c (convert_value_from_python): Use
7472         gdbpy_err_fetch.
7473         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7474         gdbpy_exception_to_string.
7475         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7476         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7477         gdbpy_err_fetch.
7478
7479 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7480
7481         * linux-nat.c (delete_lwp_cleanup): Delete.
7482         (struct lwp_deleter): New struct.
7483         (lwp_info_up): New typedef.
7484         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7485         lwp_info_up.
7486
7487 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7488
7489         * linux-fork.c (class scoped_switch_fork_info): New class.
7490         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7491
7492 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7493
7494         * valops.c (find_overload_match): Remove use of null_cleanup, and
7495         calls to do_cleanups.
7496
7497 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7498
7499         * compile/compile-cplus-types.c
7500         (compile_cplus_instance::decl_name): Handle changes to
7501         cp_func_name.
7502         * cp-support.c (cp_func_name): Update header comment, update
7503         return type.
7504         * cp-support.h (cp_func_name): Update return type in declaration.
7505         * valops.c (find_overload_match): Move temp_func local to top
7506         level of function and change its type.  Use temp_func to hold and
7507         delete temporary string obtained from cp_func_name.
7508
7509 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7510
7511         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7512         gdb::char_vector, remove cleanup, and update uses of `msg`.
7513
7514 2019-01-03  Jim Wilson  <jimw@sifive.com>
7515
7516         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7517
7518 2019-01-02  Tom Tromey  <tom@tromey.com>
7519
7520         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7521         (tdesc_parse_xml): Remove cleanups.
7522         * target-descriptions.h (make_cleanup_free_target_description):
7523         Don't declare.
7524         (target_desc_deleter): New struct.
7525         (target_desc_up): New typedef.
7526         * target-descriptions.c (target_desc_deleter::operator()): Rename
7527         from free_target_description.
7528         (make_cleanup_free_target_description): Remove.
7529
7530 2019-01-02  Tom Tromey  <tom@tromey.com>
7531
7532         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7533         constructor, destructor.
7534         (linespec_parser): Remove typedef.
7535         (~linespec_parser): Rename from linespec_parser_delete.
7536         (linespec_lex_to_end, linespec_complete_label)
7537         (linespec_complete): Update.
7538         (decode_line_full): Remove cleanups.
7539         (decode_line_1): Update.
7540
7541 2019-01-02  Tom Tromey  <tom@tromey.com>
7542
7543         * python/python-internal.h (inferior_to_inferior_object): Change
7544         return type.
7545         * python/py-exitedevent.c (create_exited_event_object): Update.
7546         * python/py-inferior.c (inferior_to_inferior_object): Return
7547         gdbpy_ref.
7548         (python_new_inferior, python_inferior_deleted)
7549         (thread_to_thread_object, delete_thread_object)
7550         (build_inferior_list, gdbpy_selected_inferior): Update.
7551         * python/py-infthread.c (create_thread_object): Update.  Also fail
7552         if inferior_to_inferior_object fails.
7553
7554 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7555
7556         * inferior.h (class inferior) <displaced_step_state>: New field.
7557         * infrun.h (struct displaced_step_state): Move here from
7558         infrun.c.  Initialize fields, add constructor.
7559         <inf>: Remove field.
7560         <reset>: New method.
7561         * infrun.c (struct displaced_step_inferior_state): Move to
7562         infrun.h.
7563         (displaced_step_inferior_states): Remove.
7564         (get_displaced_stepping_state): Adust.
7565         (displaced_step_in_progress_any_inferior): Adjust.
7566         (displaced_step_in_progress_thread): Adjust.
7567         (displaced_step_in_progress): Adjust.
7568         (add_displaced_stepping_state): Remove.
7569         (get_displaced_step_closure_by_addr): Adjust.
7570         (remove_displaced_stepping_state): Remove.
7571         (infrun_inferior_exit): Call displaced_step_state.reset.
7572         (use_displaced_stepping): Don't check for NULL.
7573         (displaced_step_prepare_throw): Call
7574         get_displaced_stepping_state.
7575         (displaced_step_fixup): Don't check for NULL.
7576         (prepare_for_detach): Don't check for NULL.
7577
7578 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7579
7580         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7581          in case of call that did not complete.
7582
7583 2019-01-02  Andrey Utkin  <autkin@undo.io>
7584
7585         * symfile.c (find_separate_debug_file): Fix search of debug files for
7586         remote debuggee.
7587
7588 2019-01-02  Tom Tromey  <tom@tromey.com>
7589
7590         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7591         indentation.
7592         * python/py-frame.c (frapy_older): Remove cast.
7593         (frapy_newer): Likewise.
7594         * python/py-breakpoint.c (local_setattro): Remove cast.
7595         * python/py-arch.c (archpy_name): Remove local variable.
7596         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7597
7598 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7599
7600         * unittests/basic_string_view/element_access/char/empty.cc:
7601         Fix year range in copyright header.
7602
7603 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7606         Delete.
7607         <operator==>: Update with for removed field.
7608         <hash>: Likewise.
7609         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7610         <isa_features>: ...this.
7611         <abi_features>: New field.
7612         (riscv_isa_flen): Update comment.
7613         (riscv_abi_xlen): New declaration.
7614         (riscv_abi_flen): New declaration.
7615         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7616         isa_features.
7617         (riscv_abi_xlen): New function.
7618         (riscv_isa_flen): Update to get answer from isa_features.
7619         (riscv_abi_flen): New function.
7620         (riscv_has_fp_abi): Update to get answer from abi_features.
7621         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7622         xlen and flen.
7623         (riscv_call_info) <xlen, flen>: Update comment.
7624         (riscv_call_arg_struct): Remove invalid assertions
7625         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7626         is removed.
7627         (riscv_gdbarch_init): Gather isa features and abi features
7628         separately, ensure both match on the gdbarch when reusing an old
7629         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7630         a target with 64-bit float hardware.
7631
7632 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7633
7634         * source.c (search_command_helper): Stop reverse search
7635         when line 1 has been searched.
7636
7637 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7638
7639         * record-full.c (record_full_base_target::close): Rewrite
7640         record_full_core_buf_list free logic.
7641
7642 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7643
7644         * break-catch-syscall.c (print_one_catch_syscall): xfree
7645         the last text.
7646
7647 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7648
7649         * top.c (print_gdb_version): Update Copyright year in version
7650         message.
7651
7652 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7653
7654         Update copyright year range in all GDB files.
7655
7656 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7657
7658         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7659
7660 For older changes see ChangeLog-2018.
7661 \f
7662 Local Variables:
7663 mode: change-log
7664 left-margin: 8
7665 fill-column: 74
7666 version-control: never
7667 coding: utf-8
7668 End:
7669