gdb/ChangeLog

   1 2019-12-01  Tom Tromey  <tom@tromey.com>
   2
   3         * NEWS: Document new settings.
   4         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
   5         * tui/tui-win.c (_initialize_tui_win): Add border style
   6         observers.
   7         * tui/tui-io.h (tui_apply_style): Declare.
   8         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
   9         longer static.
  10         (apply_ansi_escape, tui_set_reverse_mode): Update.
  11         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
  12         Add "skip_intensity" parameter.
  13         <changed>: New member.
  14         <do_set_value>: Declare.
  15         (tui_border_style, tui_active_border_style): Declare.
  16         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
  17         globals.
  18         (cli_style_option): Initialize "changed".
  19         (cli_style_option::do_set_value): New function.
  20         (cli_style_option::add_setshow_commands): Add "skip_intensity"
  21         parameter.  Update.
  22         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
  23         (_initialize_cli_style): Update.  Create TUI border style
  24         commands.
  25
  26 2019-12-01  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
  29         parameter.
  30         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
  31         parameter.
  32         * tui/tui-win.h (compact_source): Declare.
  33         * tui/tui-win.c (compact_source): New global.
  34         (tui_set_compact_source, tui_show_compact_source): New functions.
  35         (_initialize_tui_win): Add "compact-source" setting.
  36         * tui/tui-source.c (tui_source_window::set_contents): Handle
  37         compact_source setting.
  38         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  39         * NEWS: Document new setting.
  40
  41 2019-11-30  Tom Tromey  <tom@tromey.com>
  42
  43         * dwarf2read.c (dwarf2_add_field): Include field offset when
  44         computing variant part length.
  45
  46 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  47         * NEWS:  Mention define-prefix.  Tell that command names can now
  48         contain a . character.
  49
  50 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  51
  52         * command.h (valid_cmd_char_p): Declare.
  53         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
  54         the check of valid command char.
  55         (find_command_name_length, valid_user_defined_cmd_name_p): Use
  56         valid_cmd_char_p.
  57         * cli/cli-script.c (validate_comname): Likewise.
  58         * completer.c (gdb_completer_command_word_break_characters):
  59         Do not remove . from the word break char, update comments.
  60         (complete_line_internal_1): Use valid_cmd_char_p.
  61         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
  62         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
  63
  64 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  65
  66         * cli/cli-script.c (do_define_command): Ensure a redefined
  67         prefix command is kept as a prefix command.
  68         (define_prefix_command): New function.
  69         (show_user_1): Report user defined prefixes.
  70         (_initialize_cli_script):  Create the new 'define-prefix' command.
  71         Add completers for 'define' and 'document'.
  72         * top.c (execute_command):  If command is a user-defined prefix only
  73         command, report the list of commands for this prefix command.
  74
  75 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  76
  77         * valops.c (find_oload_champ): Improve debug output.
  78
  79 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  80
  81         * valops.c (find_oload_champ): Print part of debug messages
  82         before the badness vector is std::move'd.
  83
  84 2019-11-28  Tom Tromey  <tom@tromey.com>
  85
  86         * value.c (creal_internal_fn): Fix comment.
  87
  88 2019-11-28  Tom Tromey  <tom@tromey.com>
  89
  90         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
  91         flag_bound_evaluated>: Now unsigned.
  92
  93 2019-11-28  Tom Tromey  <tom@tromey.com>
  94
  95         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
  96         declare.
  97
  98 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
  99
 100         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 101         debug output.
 102         * jit.c (jit_unregister_code): Add debug print to match
 103         `jit_register_code`.
 104
 105 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 106
 107         * NEWS: Mention the new multithreaded symbol loading.
 108
 109 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 110
 111         * maint.c (n_worker_threads): Default to 0.
 112         (worker_threads_disabled): New function.
 113         * maint.h (worker_threads_disabled): New function.
 114         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 115         here if worker_threads_disabled () is true.
 116         (minimal_symbol_reader::install): Skip all threading if
 117         worker_threads_disabled () is true.
 118
 119 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 120
 121         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 122         hash code if possible.
 123         (add_minsym_to_demangled_hash_table): Likewise.
 124         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 125         on the background thread.
 126         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 127         Add these fields.
 128
 129 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 130
 131         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 132         of the mangled name on the background thread.
 133         * symtab.c (symbol_set_names): Allow passing in the hash of the
 134         linkage_name.
 135         * symtab.h (symbol_set_names): Likewise.
 136
 137 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 138
 139         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 140         physnames are computed for inherited DIEs.
 141
 142 2019-11-27  Tom Tromey  <tromey@adacore.com>
 143
 144         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 145         backslashes.
 146         * cp-support.c: Remove unnecessary backslashes.
 147
 148 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 151         with sym->set_linkage_name.
 152         * coffread.c (coff_read_enum_type): Likewise.
 153         * mdebugread.c (parse_symbol): Likewise.
 154         * stabsread.c (patch_block_stabs): Likewise.
 155         (define_symbol): Likewise.
 156         (read_enum_type): Likewise.
 157         (common_block_end): Likewise.
 158         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 159         function.
 160         (SYMBOL_SET_LINKAGE_NAME): Remove.
 161         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 162         with sym->set_linkage_name.
 163
 164 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 165
 166         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 167         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 168         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 169         * NEWS: Mention new MI command.
 170
 171 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 174         '-symbol-info-types', and '-symbol-info-variables'.
 175         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 176         (mi_cmd_symbol_info_types): Declare.
 177         (mi_cmd_symbol_info_variables): Declare.
 178         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 179         (output_debug_symbol): New function.
 180         (output_nondebug_symbol): New function.
 181         (mi_symbol_info): New function.
 182         (mi_info_functions_or_variables): New function.
 183         (mi_cmd_symbol_info_functions): New function.
 184         (mi_cmd_symbol_info_types): New function.
 185         (mi_cmd_symbol_info_variables): New function.
 186         * NEWS: Mention new commands.
 187
 188 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 189
 190         * symtab.c (symbol_to_info_string): New function, most content
 191         moved from print_symbol_info, but updated to return a std::string.
 192         (print_symbol_info): Update to use symbol_to_info_string and print
 193         returned string.
 194         * symtab.h (symbol_to_info_string): Declare new function.
 195
 196 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 197
 198         * python/python.c (gdbpy_rbreak): Convert to using
 199         global_symbol_searcher.
 200         * symtab.c (file_matches): Convert return type to bool, change
 201         file list to std::vector, update header comment.
 202         (search_symbols): Rename to...
 203         (global_symbol_searcher::search): ...this and update now its
 204         a member function of global_symbol_searcher.  Take account of the
 205         changes to file_matches.
 206         (symtab_symbol_info): Convert to using global_symbol_searcher.
 207         (rbreak_command): Likewise.
 208         (search_module_symbols): Likewise.
 209         * symtab.h (enum symbol_search): Update comment.
 210         (search_symbols): Remove declaration.
 211         (class global_symbol_searcher): New class.
 212
 213 2019-11-26  Tom Tromey  <tromey@adacore.com>
 214
 215         * cp-support.c (_initialize_cp_support): Conditionally initialize
 216         gdb_demangle_attempt_core_dump.
 217
 218 2019-11-26  Tom Tromey  <tom@tromey.com>
 219
 220         * python/py-function.c (fnpy_init): Update.
 221         * value.h (add_internal_function): Adjust declaration.
 222         * value.c (function_destroyer): Remove.
 223         (do_add_internal_function): Don't set destroyer or copy name.
 224         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 225         Set name_allocated.
 226         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 227         (cmdpy_init): Set name_allocated.
 228         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 229         member.
 230         (~cmd_list_element): Free "name" if needed.
 231
 232 2019-11-26  Tom Tromey  <tom@tromey.com>
 233
 234         * value.h (add_internal_function): Add new overload.  Move
 235         documentation from value.h.
 236         * value.c (do_add_internal_function): New function.
 237         (add_internal_function): Use it.  Add new overload.
 238         (function_destroyer): Don't free doc.
 239         * python/py-function.c (fnpy_init): Update.
 240
 241 2019-11-26  Tom Tromey  <tom@tromey.com>
 242
 243         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 244         (cmdpy_init): Set "doc_allocated".
 245
 246 2019-11-26  Tom Tromey  <tom@tromey.com>
 247
 248         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 249         name of worker thread.
 250         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 251         pthread_setname_np.
 252         * configure, config.in: Rebuild.
 253
 254 2019-11-26  Tom Tromey  <tom@tromey.com>
 255
 256         * python/python.c (class gdbpy_gil): New.
 257         (struct gdbpy_event): Add constructor, destructor, operator().
 258         (gdbpy_post_event): Use run_on_main_thread.
 259         (gdbpy_initialize_events): Remove.
 260         (do_start_initialization): Update.
 261
 262 2019-11-26  Tom Tromey  <tom@tromey.com>
 263
 264         * NEWS: Add entry.
 265         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 266         commands.  Call update_thread_pool_size.
 267         (update_thread_pool_size, maintenance_set_worker_threads): New
 268         functions.
 269         (n_worker_threads): New global.
 270
 271 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 272             Tom Tromey  <tom@tromey.com>
 273
 274         * minsyms.c (minimal_symbol_reader::install): Use
 275         parallel_for_each.
 276         * gdbsupport/parallel-for.h: New file.
 277         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 278
 279 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 280             Tom Tromey  <tom@tromey.com>
 281
 282         * gdbsupport/thread-pool.h: New file.
 283         * gdbsupport/thread-pool.c: New file.
 284         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 285         (HFILES_NO_SRCDIR): Add thread-pool.h.
 286
 287 2019-11-26  Tom Tromey  <tom@tromey.com>
 288
 289         * event-top.h (thread_local_segv_handler): Declare.
 290         * event-top.c (thread_local_segv_handler): New global.
 291         (install_handle_sigsegv, handle_sigsegv): New functions.
 292         (async_init_signals): Install SIGSEGV handler.
 293         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 294         thread-local.
 295         (report_failed_demangle): New function.
 296         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 297         handler-setting code, instead use segv_handler.  Run warning code
 298         on main thread.
 299
 300 2019-11-26  Tom Tromey  <tom@tromey.com>
 301
 302         * run-on-main-thread.c: New file.
 303         * run-on-main-thread.h: New file.
 304         * unittests/main-thread-selftests.c: New file.
 305         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 306         main-thread-selftests.c.
 307         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 308         (COMMON_SFILES): Add run-on-main-thread.c.
 309
 310 2019-11-26  Tom Tromey  <tom@tromey.com>
 311
 312         * main.c (setup_alternate_signal_stack): Remove.
 313         (captured_main_1): Use gdb::alternate_signal_stack.
 314         * gdbsupport/alt-stack.h: New file.
 315
 316 2019-11-26  Tom Tromey  <tom@tromey.com>
 317
 318         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 319         Remove comment.
 320         (save_original_signals_state, restore_original_signals_state): Use
 321         gdb_sigmask.
 322         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 323         (_initialize_linux_nat): Use gdb_sigmask.
 324         * guile/guile.c (_initialize_guile): Use block_signals.
 325         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 326         * gdbsupport/gdb-sigmask.h: New file.
 327         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 328         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 329         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 330         pthread_sigmask.
 331         * configure, config.in: Rebuild.
 332         * gdbsupport/block-signals.h: New file.
 333
 334 2019-11-26  Tom Tromey  <tom@tromey.com>
 335
 336         * acinclude.m4: Include ax_pthread.m4.
 337         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 338         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 339         (CLIBS): Use PTHREAD_LIBS.
 340         (aclocal_m4_deps): Add ax_pthread.m4.
 341         * config.in, configure: Rebuild.
 342         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 343
 344 2019-11-26  Tom Tromey  <tom@tromey.com>
 345
 346         * symtab.h (struct minimal_symbol) <name_set>: New member.
 347         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 348         Don't call symbol_set_names.
 349         (minimal_symbol_reader::install): Call symbol_set_names.
 350
 351 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 352
 353         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 354         restore_active_ext_lang, as GIL is needed for (indirectly)
 355         called PyOS_InterruptOccurred.
 356
 357 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 358
 359         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 360         definition.
 361
 362 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 363
 364         * remote-sim.c (simulator_command): Make static, remove
 365         declaration.
 366
 367 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 368
 369         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 370         static.
 371         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 372         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 373         (main): Likewise.
 374         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 375         (main): Likewise.
 376         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 377         (main): Likewise.
 378         * unittests/basic_string_view/element_access/char/1.cc (test01):
 379         Likewise.
 380         (main): Likewise.
 381         * unittests/basic_string_view/element_access/char/empty.cc (main):
 382         Likewise.
 383         * unittests/basic_string_view/element_access/char/front_back.cc
 384         (test01): Likewise.
 385         (main): Likewise.
 386         * unittests/basic_string_view/inserters/char/2.cc (test05):
 387         Likewise.
 388         (main): Likewise.
 389         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 390         (test01): Likewise.
 391         (main): Likewise.
 392         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 393         (test01): Likewise.
 394         (main): Likewise.
 395         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 396         Likewise.
 397         * unittests/basic_string_view/operations/compare/char/1.cc
 398         (test01): Likewise.
 399         (main): Likewise.
 400         * unittests/basic_string_view/operations/compare/char/13650.cc
 401         (test01): Likewise.
 402         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 403         Likewise.
 404         (main): Likewise.
 405         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 406         Likewise.
 407         (main): Likewise.
 408         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 409         Likewise.
 410         (main): Likewise.
 411         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 412         Likewise.
 413         (main): Likewise.
 414         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 415         Likewise.
 416         (main): Likewise.
 417         * unittests/basic_string_view/operations/find/char/4.cc (main):
 418         Likewise.
 419         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 420         Likewise.
 421         (main): Likewise.
 422         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 423         Likewise.
 424         (main): Likewise.
 425         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 426         Likewise.
 427         (main): Likewise.
 428         * unittests/basic_string_view/operations/substr/char/1.cc
 429         (test01): Likewise.
 430         (main): Likewise.
 431         * unittests/basic_string_view/operators/char/2.cc (main):
 432         Likewise.
 433         * unittests/optional/assignment/1.cc (test): Likewise.
 434         * unittests/optional/assignment/2.cc (test): Likewise.
 435         * unittests/optional/assignment/3.cc (test): Likewise.
 436         * unittests/optional/assignment/4.cc (test): Likewise.
 437         * unittests/optional/assignment/5.cc (test): Likewise.
 438         * unittests/optional/assignment/6.cc (test): Likewise.
 439         * unittests/optional/assignment/7.cc (test): Likewise.
 440         * unittests/optional/cons/copy.cc (test): Likewise.
 441         * unittests/optional/cons/default.cc (test): Likewise.
 442         * unittests/optional/cons/move.cc (test): Likewise.
 443         * unittests/optional/cons/value.cc (test): Likewise.
 444         * unittests/optional/in_place.cc (test): Likewise.
 445         * unittests/optional/observers/1.cc (test): Likewise.
 446         * unittests/optional/observers/2.cc (test): Likewise.
 447
 448 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 449
 450         * tui-win.h (tui_set_var_cmd): Remove.
 451         * tui-win.c (tui_set_var_cmd): Make static.
 452
 453 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 454
 455         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 456         rbreak_command_wrapper): Remove.
 457         * symtab.c (rbreak_command_wrapper): Remove.
 458
 459 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * inferior.h (info_terminal_command): Remove declaration.
 462         * inflow.c (info_terminal_command): Make static.
 463
 464 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 465
 466         * inferior.c (exit_inferior_silent): Remove.
 467
 468 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 469
 470         * dictionary.c (dict_empty, mdict_empty): Remove.
 471         * dictionary.c (mdict_empty): Remove.
 472
 473 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 474
 475          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 476          (arc_insn_get_memory_offset): Likewise.
 477          (arc_insn_dump): Likewise.
 478          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 479          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 480          * dictionary.c (dict_iterator_next): Likewise.
 481          (dict_iter_match_first): Likewise.
 482          (dict_iter_match_next): Likewise.
 483          * f-lang.c (evaluate_subexp_f): Likewise.
 484          * hppa-tdep.c (hppa_read_pc): Likewise.
 485          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 486          * parse.c (write_exp_elt_msym): Likewise.
 487          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 488          * remote.c (remote_packet_size): Likewise.
 489          (remote_notif_stop_parse): Likewise.
 490          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 491          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 492          * source.c (prepare_path_for_appending): Likewise.
 493          * sparc64-linux-tdep.c
 494          (sparc64_linux_handle_segmentation_fault); Likewise.
 495          * stack.c (frame_selection_by_function_completer): Likewise.
 496
 497 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 498
 499         * completer.c (set_gdb_completion_word_break_characters):
 500         Remove.
 501
 502 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 503
 504         * dwarf-index-write.c: Include dwarf-index-write.h.
 505         * mi/mi-interp.c: Include mi/mi-interp.h.
 506
 507 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 508
 509         * aarch32-tdep.c: Include aarch32-tdep.h.
 510         * aarch32-tdep.h: Forward-declare struct target_desc.
 511
 512 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 513
 514         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 515         strerror.
 516         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 517         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 518
 519 2019-11-25  Tom de Vries  <tdevries@suse.de>
 520
 521         * contrib/words.sh: Add -c option.
 522
 523 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 524
 525         * solib.c (solib_find_1): Change int to bool.
 526         (exec_file_find): Change int to bool.
 527         (solib_find): Change int to bool.
 528         (solib_read_symbols): Change int to bool.
 529         (solib_used): Change int to bool.
 530         (solib_add): Change int to bool.
 531         (info_sharedlibrary_command): Change int to bool.
 532         (solib_contains_address_p): Change int to bool.
 533         (solib_keep_data_in_core): Change int to bool.
 534         (in_solib_dynsym_resolve_code): Change int to bool.
 535         (reload_shared_libraries_1): Change int to bool.
 536         (gdb_sysroot_changed): Change int to bool.
 537         * solib.h (solib_read_symbols): Change int to bool.
 538         (solib_contains_address_p): Change int to bool.
 539         (solib_keep_data_in_core): Change int to bool.
 540         (in_solib_dynsym_resolve_code): Change int to bool.
 541         (libpthread_name_p): Change int to bool.
 542
 543 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 544
 545         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 546         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 547         (remote_packet_max_chars): New static global.
 548         (show_remote_packet_max_chars): New function.
 549         (remote_target::putpkt_binary): Adjust to use new
 550         remote_packet_max_chars option.
 551         (remote_target::getpkt_or_notif_sane_1): Likewise.
 552         (_initialize_remote): Register new remote-packet-max-chars option.
 553
 554 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 555
 556         * m68k-linux-nat.c: Include gdbarch.h.
 557
 558 2019-11-24  Tom Tromey  <tom@tromey.com>
 559
 560         * symfile.c (read_symbols): Update.
 561         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 562         bool.
 563         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 564         (psym_lookup_symbol, psym_find_last_source_symtab)
 565         (psym_forget_cached_source_info, psym_print_stats)
 566         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 567         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 568         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 569         (psym_find_compunit_symtab_by_address)
 570         (maintenance_print_psymbols, maintenance_info_psymtabs)
 571         (maintenance_check_psymtabs): Update.
 572         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 573         bool.
 574
 575 2019-11-22  Tom Tromey  <tom@tromey.com>
 576
 577         * observable.h: Update comments.
 578
 579 2019-11-22  Tom Tromey  <tromey@adacore.com>
 580
 581         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 582         (print_ada_task_info): Don't try to fetch thread id if task is not
 583         alive.
 584
 585 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 586
 587         * ada-exp.y: Update.
 588         * ada-lang.c (sort_choices): Update.
 589         (ada_print_symbol_signature): Update.
 590         (resolve_subexp): Update.
 591         (ada_parse_renaming): Update.
 592         (ada_read_renaming_var_value): Update.
 593         (lesseq_defined_than): Update.
 594         (remove_extra_symbols): Update.
 595         (remove_irrelevant_renamings): Update.
 596         (ada_add_block_symbols): Update.
 597         (ada_collect_symbol_completion_matches): Update.
 598         (ada_is_renaming_symbol): Update.
 599         (aggregate_assign_from_choices): Update.
 600         (ada_evaluate_subexp): Update.
 601         (ada_has_this_exception_support): Update.
 602         (ada_is_non_standard_exception_sym): Update.
 603         (ada_add_exceptions_from_frame): Update.
 604         (ada_add_global_exceptions): Update.
 605         (ada_print_subexp): Update.
 606         * ax-gdb.c (gen_var_ref): Update.
 607         (gen_maybe_namespace_elt): Update.
 608         (gen_expr_for_cast): Update.
 609         (gen_expr): Update.
 610         * block.h: Update.
 611         * blockframe.c (find_pc_partial_function): Update.
 612         * breakpoint.c (print_breakpoint_location): Update.
 613         (update_static_tracepoint): Update.
 614         * btrace.c (ftrace_print_function_name): Update.
 615         (ftrace_function_switched): Update.
 616         * buildsym.c (find_symbol_in_list): Update.
 617         * c-exp.y: Update.
 618         * c-typeprint.c (c_print_typedef): Update.
 619         (c_type_print_template_args): Update.
 620         * cli/cli-cmds.c (edit_command): Update.
 621         (list_command): Update.
 622         (print_sal_location): Update.
 623         * coffread.c (patch_opaque_types): Update.
 624         (process_coff_symbol): Update.
 625         (coff_read_enum_type): Update.
 626         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 627         (convert_one_symbol): Update.
 628         (hash_symname): Update.
 629         (eq_symname): Update.
 630         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 631         * compile/compile-cplus-types.c (debug_print_scope): Update.
 632         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 633         * compile/compile-object-load.c (get_out_value_type): Update.
 634         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 635         (search_symbol_list): Update.
 636         (cp_lookup_symbol_imports_or_template): Update.
 637         * cp-support.c (overload_list_add_symbol): Update.
 638         * ctfread.c (psymtab_to_symtab): Update.
 639         * dbxread.c (cp_set_block_scope): Update.
 640         * dictionary.c (iter_match_first_hashed): Update.
 641         (iter_match_next_hashed): Update.
 642         (insert_symbol_hashed): Update.
 643         (iter_match_next_linear): Update.
 644         * dictionary.h: Update.
 645         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 646         (locexpr_describe_location_piece): Update.
 647         (locexpr_describe_location_1): Update.
 648         (locexpr_generate_c_location): Update.
 649         (loclist_describe_location): Update.
 650         (loclist_generate_c_location): Update.
 651         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 652         (read_func_scope): Update.
 653         (process_enumeration_scope): Update.
 654         (new_symbol): Update.
 655         (dwarf2_const_value): Update.
 656         (dwarf2_symbol_mark_computed): Update.
 657         * eval.c (evaluate_funcall): Update.
 658         (evaluate_subexp_standard): Update.
 659         * expprint.c (print_subexp_standard): Update.
 660         (dump_subexp_body_standard): Update.
 661         * f-valprint.c (info_common_command_for_block): Update.
 662         * findvar.c (get_hosting_frame): Update.
 663         (default_read_var_value): Update.
 664         * go-lang.c (go_symbol_package_name): Update.
 665         * guile/scm-block.c (bkscm_print_block_smob): Update.
 666         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 667         (gdbscm_symbol_name): Update.
 668         (gdbscm_symbol_linkage_name): Update.
 669         (gdbscm_symbol_print_name): Update.
 670         * infcall.c (get_function_name): Update.
 671         * infcmd.c (jump_command): Update.
 672         (finish_command): Update.
 673         * infrun.c (insert_exception_resume_breakpoint): Update.
 674         * linespec.c (canonicalize_linespec): Update.
 675         (create_sals_line_offset): Update.
 676         (convert_linespec_to_sals): Update.
 677         (complete_label): Update.
 678         (find_label_symbols_in_block): Update.
 679         * m2-typeprint.c (m2_print_typedef): Update.
 680         * mdebugread.c (mdebug_reg_to_regnum): Update.
 681         (parse_symbol): Update.
 682         (mylookup_symbol): Update.
 683         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 684         (list_args_or_locals): Update.
 685         * objc-lang.c (compare_selectors): Update.
 686         (info_selectors_command): Update.
 687         (compare_classes): Update.
 688         (info_classes_command): Update.
 689         (find_imps): Update.
 690         * p-typeprint.c (pascal_print_typedef): Update.
 691         * printcmd.c (build_address_symbolic): Update.
 692         (info_address_command): Update.
 693         (print_variable_and_value): Update.
 694         * python/py-framefilter.c (extract_sym): Update.
 695         (py_print_single_arg): Update.
 696         * python/py-symbol.c (sympy_str): Update.
 697         (sympy_get_name): Update.
 698         (sympy_get_linkage_name): Update.
 699         * python/python.c (gdbpy_rbreak): Update.
 700         * record-btrace.c (btrace_get_bfun_name): Update.
 701         (btrace_call_history): Update.
 702         * rust-lang.c (rust_print_typedef): Update.
 703         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 704         * stabsread.c (stab_reg_to_regnum): Update.
 705         (define_symbol): Update.
 706         (read_enum_type): Update.
 707         (common_block_end): Update.
 708         (cleanup_undefined_types_1): Update.
 709         (scan_file_globals): Update.
 710         * stack.c (print_frame_arg): Update.
 711         (print_frame_args): Update.
 712         (find_frame_funname): Update.
 713         (info_frame_command_core): Update.
 714         (iterate_over_block_locals): Update.
 715         (print_block_frame_labels): Update.
 716         (do_print_variable_and_value): Update.
 717         (iterate_over_block_arg_vars): Update.
 718         (return_command): Update.
 719         * symmisc.c (dump_symtab_1): Update.
 720         (print_symbol): Update.
 721         * symtab.c (eq_symbol_entry): Update.
 722         (symbol_cache_dump): Update.
 723         (lookup_language_this): Update.
 724         (find_pc_sect_line): Update.
 725         (skip_prologue_sal): Update.
 726         (symbol_search::compare_search_syms): Update.
 727         (treg_matches_sym_type_name): Update.
 728         (search_symbols): Update.
 729         (print_symbol_info): Update.
 730         (rbreak_command): Update.
 731         (completion_list_add_symbol): Update.
 732         (find_gnu_ifunc): Update.
 733         (get_symbol_address): Update.
 734         (search_module_symbols): Update.
 735         (info_module_subcommand): Update.
 736         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 737         (SYMBOL_LINKAGE_NAME): Remove.
 738         (SYMBOL_DEMANGLED_NAME): Remove.
 739         (SYMBOL_PRINT_NAME): Remove.
 740         (SYMBOL_SEARCH_NAME): Remove.
 741         * tracepoint.c (set_traceframe_context): Update.
 742         (validate_actionline): Update.
 743         (collection_list::collect_symbol): Update.
 744         (encode_actions_1): Update.
 745         (info_scope_command): Update.
 746         (print_one_static_tracepoint_marker): Update.
 747         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 748         * valops.c (address_of_variable): Update.
 749         (find_overload_match): Update.
 750         (find_oload_champ): Update.
 751
 752 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 753
 754         * ada-lang.c (ada_lookup_simple_minsym): Update.
 755         (ada_collect_symbol_completion_matches): Update.
 756         * ada-tasks.c (read_atcb): Update.
 757         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 758         (amd64_windows_skip_trampoline_code): Update.
 759         * arm-tdep.c (skip_prologue_function): Update.
 760         (arm_skip_stack_protector): Update.
 761         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 762         (arm_wince_skip_main_prologue): Update.
 763         * ax-gdb.c (gen_expr): Update.
 764         * block.c (call_site_for_pc): Update.
 765         * blockframe.c (find_pc_partial_function): Update.
 766         * breakpoint.c (set_breakpoint_location_function): Update.
 767         * btrace.c (ftrace_print_function_name): Update.
 768         (ftrace_function_switched): Update.
 769         * c-valprint.c (print_unpacked_pointer): Update.
 770         * coffread.c (coff_symfile_read): Update.
 771         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 772         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 773         * dwarf-index-write.c (write_psymbols): Update.
 774         * dwarf2loc.c (call_site_to_target_addr): Update.
 775         (func_verify_no_selftailcall): Update.
 776         (tailcall_dump): Update.
 777         (call_site_find_chain_1): Update.
 778         (dwarf_expr_reg_to_entry_parameter): Update.
 779         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 780         * eval.c (evaluate_funcall): Update.
 781         (evaluate_subexp_standard): Update.
 782         (evaluate_subexp_for_sizeof): Update.
 783         * expprint.c (print_subexp_standard): Update.
 784         (dump_subexp_body_standard): Update.
 785         * frame.c (get_prev_frame_always_1): Update.
 786         * frv-tdep.c (frv_skip_main_prologue): Update.
 787         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 788         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 789         (gnuv3_get_typename_from_type_info): Update.
 790         (gnuv3_skip_trampoline): Update.
 791         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 792         * i386-tdep.c (i386_skip_main_prologue): Update.
 793         (i386_pe_skip_trampoline_code): Update.
 794         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 795         * infcall.c (get_function_name): Update.
 796         * linespec.c (minsym_found): Update.
 797         * linux-fork.c (info_checkpoints_command): Update.
 798         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 799         (m32c_m16c_pointer_to_address): Update.
 800         * maint.c (maintenance_translate_address): Update.
 801         * minsyms.c (add_minsym_to_hash_table): Update.
 802         (add_minsym_to_demangled_hash_table): Update.
 803         (lookup_minimal_symbol_mangled): Update.
 804         (lookup_minimal_symbol_demangled): Update.
 805         (lookup_minimal_symbol_linkage): Update.
 806         (lookup_minimal_symbol_text): Update.
 807         (lookup_minimal_symbol_by_pc_name): Update.
 808         (minimal_symbol_is_less_than): Update.
 809         (compact_minimal_symbols): Update.
 810         (build_minimal_symbol_hash_tables): Update.
 811         (find_solib_trampoline_target): Update.
 812         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 813         (mips_skip_pic_trampoline_code): Update.
 814         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 815         * objc-lang.c (info_selectors_command): Update.
 816         (info_classes_command): Update.
 817         (find_methods): Update.
 818         (find_imps): Update.
 819         * p-valprint.c (pascal_val_print): Update.
 820         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 821         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 822         * printcmd.c (build_address_symbolic): Update.
 823         (info_symbol_command): Update.
 824         * psymtab.c (psymbol_name_matches): Update.
 825         (match_partial_symbol): Update.
 826         (lookup_partial_symbol): Update.
 827         (print_partial_symbols): Update.
 828         (sort_pst_symbols): Update.
 829         (maintenance_check_psymtabs): Update.
 830         * python/py-framefilter.c (py_print_frame): Update.
 831         * python/python.c (gdbpy_rbreak): Update.
 832         * record-btrace.c (btrace_get_bfun_name): Update.
 833         (btrace_call_history): Update.
 834         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 835         (rs6000_skip_trampoline_code): Update.
 836         * sol-thread.c (info_cb): Update.
 837         * stabsread.c (scan_file_globals): Update.
 838         * stack.c (find_frame_funname): Update.
 839         (info_frame_command_core): Update.
 840         * symmisc.c (dump_msymbols): Update.
 841         * symtab.c (symbol_natural_name): Rename to..,
 842         (general_symbol_info::natural_name): ...this.
 843         (symbol_demangled_name): Rename to...
 844         (general_symbol_info::demangled_name): ...this.
 845         (symbol_search_name): Rename to...
 846         (general_symbol_info::search_name): ...this.
 847         (symbol_matches_search_name): Update.
 848         (find_pc_sect_line): Update.
 849         (skip_prologue_sal): Update.
 850         (search_symbols): Update.
 851         (print_msymbol_info): Update.
 852         (rbreak_command): Update.
 853         (completion_list_add_msymbol): Update.
 854         (completion_list_objc_symbol): Update.
 855         (get_msymbol_address): Update.
 856         * symtab.h (struct general_symbol_info): Add member functions
 857         natural_name (), linkage_name (), print_name (), demangled_name (),
 858         and search_name ().
 859         (SYMBOL_NATURAL_NAME): Update.
 860         (symbol_natural_name): Move to a member function on general_symbol_info.
 861         (SYMBOL_DEMANGLED_NAME): Update.
 862         (symbol_demangled_name): Move to a member function on
 863         general_symbol_info.
 864         (SYMBOL_SEARCH_NAME): Update.
 865         (symbol_search_name): Move to a member function on general_symbol_info.
 866         (MSYMBOL_NATURAL_NAME): Remove.
 867         (MSYMBOL_LINKAGE_NAME): Remove.
 868         (MSYMBOL_PRINT_NAME): Remove.
 869         (MSYMBOL_DEMANGLED_NAME): Remove.
 870         (MSYMBOL_SEARCH_NAME): Remove.
 871         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 872
 873 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 874
 875         * symtab.c (create_demangled_names_hash): Use per_bfd->
 876         minimal_symbol_count for computing the initial size, if greater
 877         than our default size.
 878
 879 2019-11-22  Tom de Vries  <tdevries@suse.de>
 880
 881         * contrib/words.sh: Improve words extraction.
 882
 883 2019-11-22  Tom de Vries  <tdevries@suse.de>
 884
 885         * contrib/words.sh: Combine sed invocations.
 886
 887 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 888
 889         * Makefile.in: Update.
 890         * demangle.c: Rename to...
 891         * gdb-demangle.c: ..this.
 892         (is_cplus_marker): Change return type to bool.
 893         (_initialize_demangler): Rename to...
 894         (_initialize_gdb_demangle): ...this.
 895         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 896         * symtab.h (demangle): Remove declaration; instead include
 897         gdb-demangle.h.
 898
 899 2019-11-21  Tom Tromey  <tromey@adacore.com>
 900
 901         * gdbsupport/format.c (format_pieces): Parse %I64d.
 902         * unittests/format_pieces-selftests.c (test_windows_formats): New
 903         function.
 904         (run_tests): Call it.
 905
 906 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 907
 908         Byte reverse display of variables with DW_END_big, DW_END_little
 909         (DW_AT_endianity) dwarf attributes if different than the native
 910         byte order.
 911         * ada-lang.c (ada_value_binop):
 912         Use type_byte_order instead of gdbarch_byte_order.
 913         * ada-valprint.c (printstr):
 914         (ada_val_print_string):
 915         * ada-lang.c (value_pointer):
 916         (ada_value_binop):
 917         Use type_byte_order instead of gdbarch_byte_order.
 918         * c-lang.c (c_get_string):
 919         Use type_byte_order instead of gdbarch_byte_order.
 920         * c-valprint.c (c_val_print_array):
 921         Use type_byte_order instead of gdbarch_byte_order.
 922         * cp-valprint.c (cp_print_class_member):
 923         Use type_byte_order instead of gdbarch_byte_order.
 924         * dwarf2loc.c (rw_pieced_value):
 925         Use type_byte_order instead of gdbarch_byte_order.
 926         * dwarf2read.c (read_base_type): Handle DW_END_big,
 927         DW_END_little
 928         * f-lang.c (f_get_encoding):
 929         Use type_byte_order instead of gdbarch_byte_order.
 930         * findvar.c (default_read_var_value):
 931         Use type_byte_order instead of gdbarch_byte_order.
 932         * gdbtypes.c (check_types_equal):
 933         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 934         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 935         and TYPE_ENDIANITY_LITTLE if set.
 936         (type_byte_order): new function.
 937         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 938         (struct main_type) <flag_endianity_not_default>:
 939         New field.
 940         (type_byte_order): New function.
 941         * infcmd.c (default_print_one_register_info):
 942         Use type_byte_order instead of gdbarch_byte_order.
 943         * p-lang.c (pascal_printstr):
 944         Use type_byte_order instead of gdbarch_byte_order.
 945         * p-valprint.c (pascal_val_print):
 946         Use type_byte_order instead of gdbarch_byte_order.
 947         * printcmd.c (print_scalar_formatted):
 948         Use type_byte_order instead of gdbarch_byte_order.
 949         * solib-darwin.c (darwin_current_sos):
 950         Use type_byte_order instead of gdbarch_byte_order.
 951         * solib-svr4.c (solib_svr4_r_ldsomap):
 952         Use type_byte_order instead of gdbarch_byte_order.
 953         * stap-probe.c (stap_modify_semaphore):
 954         Use type_byte_order instead of gdbarch_byte_order.
 955         * target-float.c (target_float_same_format_p):
 956         Use type_byte_order instead of gdbarch_byte_order.
 957         * valarith.c (scalar_binop):
 958         (value_bit_index):
 959         Use type_byte_order instead of gdbarch_byte_order.
 960         * valops.c (value_cast):
 961         Use type_byte_order instead of gdbarch_byte_order.
 962         * valprint.c (generic_emit_char):
 963         (generic_printstr):
 964         (val_print_string):
 965         Use type_byte_order instead of gdbarch_byte_order.
 966         * value.c (unpack_long):
 967         (unpack_bits_as_long):
 968         (unpack_value_bitfield):
 969         (modify_field):
 970         (pack_long):
 971         (pack_unsigned_long):
 972         Use type_byte_order instead of gdbarch_byte_order.
 973         * findvar.c (unsigned_pointer_to_address):
 974         (signed_pointer_to_address):
 975         (unsigned_address_to_pointer):
 976         (address_to_signed_pointer):
 977         (default_read_var_value):
 978         (default_value_from_register):
 979         Use type_byte_order instead of gdbarch_byte_order.
 980         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 981         Use type_byte_order instead of gdbarch_byte_order.
 982         * riscv-tdep.c (riscv_print_one_register_info):
 983         Use type_byte_order instead of gdbarch_byte_order.
 984
 985 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 986
 987         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 988         (current_ui_gdb_stdin_ptr): Likewise.
 989         (current_ui_gdb_stderr_ptr): Likewise.
 990         (current_ui_gdb_stdlog_ptr): Likewise.
 991         (current_ui_current_uiout_ptr): Likewise.
 992         (gen_ret_current_ui_field_ptr): Remove.
 993
 994 2019-11-21  Tom de Vries  <tdevries@suse.de>
 995
 996         PR gdb/24956
 997         * cli/cli-script.c (execute_control_command): Only switch to
 998         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 999
1000 2019-11-19  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1003         Now static.  Change type of "name".
1004         (tui_set_win_height_command): Don't copy "arg".
1005         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1006         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1007
1008 2019-11-19  Ali Tamur <tamur@google.com>
1009
1010         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1011         "if (attr != nullptr)".
1012         (dwarf2_find_base_address): Likewise.
1013         (dwarf2_build_include_psymtabs): Likewise.
1014         (read_cutu_die_from_dwo): Likewise.
1015         (read_func_scope): Likewise.
1016         (read_call_site_scope): Likewise.
1017         (dwarf2_get_pc_bounds): Likewise.
1018         (dwarf2_record_block_ranges): Likewise.
1019         (dwarf2_add_field): Likewise.
1020         (dwarf2_add_member_fn): Likewise.
1021         (read_structure_type): Likewise.
1022         (read_enumeration_type): Likewise.
1023         (read_array_type): Likewise.
1024         (read_array_order): Likewise.
1025         (read_set_type): Likewise.
1026         (read_common_block): Likewise.
1027         (read_tag_reference_type): Likewise.
1028         (read_tag_string_type): Likewise.
1029         (read_subroutine_type): Likewise.
1030         (read_base_type): Likewise.
1031         (read_subrange_type): Likewise.
1032         (new_symbol): Likewise.
1033         (prepare_one_comp_unit): Likewise.
1034
1035 2019-11-19  Tom Tromey  <tromey@adacore.com>
1036
1037         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1038         result in error when DebugActiveProcess fails.
1039
1040 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1041             Pedro Alves  <palves@redhat.com>
1042
1043         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1044         * target.c (target_stack::push): Call 'unpush' if there's a
1045         target on top of the stack.
1046
1047 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1048
1049         * python/py-block.c (blpy_dealloc): Call tp_free.
1050         (blpy_block_syms_dealloc): Likewise.
1051         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1052         * python/py-inferior.c (infpy_dealloc): Likewise.
1053         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1054         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1055         * python/py-symbol.c (sympy_dealloc): Likewise.
1056         * python/py-symtab.c (stpy_dealloc): Likewise.
1057         * python/py-type.c (typy_iterator_dealloc): Likewise.
1058
1059 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1060
1061         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1062         constructor instead of using a class initializer.
1063
1064 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1065
1066         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1067         * configure: Regenerate.
1068         * configure.ac: Don't source common.host.
1069         * gdbsupport/common.host: Remove.
1070         * gdbsupport/mingw-strerror.c: Remove.
1071         * gdbsupport/posix-strerror.c: Rename to...
1072         * gdbsupport/safe-strerror.c: ...this.
1073
1074 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1075
1076         * maint.c (scoped_command_stats::print_time): Use localtime_r
1077         instead of localtime (provided through gnulib if necessary).
1078         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1079         of ctime.
1080
1081 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1082
1083         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1084         avoid compile errors.
1085
1086 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1087
1088         * config.in: Regenerate.
1089         * configure: Regenerate.
1090         * gdbsupport/common.m4: No longer check for strerror_r.
1091         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1092         POSIX version of strerror_r, now that gnulib provides it if
1093         necessary.
1094
1095 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1096
1097         * README (`configure' options): Update.
1098
1099 2019-11-14  Tom Tromey  <tromey@adacore.com>
1100
1101         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1102         expected type for the RHS if the LHS is a convenience variable.
1103
1104 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1105
1106         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1107         Provide explicit default and copy constructor.
1108
1109 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1110
1111         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1112         only call Py_INCREF (newbp) in the bppy_pending_object case.
1113
1114 2019-11-13  Tom Tromey  <tromey@adacore.com>
1115
1116         PR build/25182:
1117         * psympriv.h (partial_symbol): Remove static assert.
1118         * symtab.h (general_symbol_info, symbol): Remove static assert.
1119
1120 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1121
1122         * gdbsupport/format.c (format_pieces::format_pieces): Support
1123         printf 'z' size modifier.
1124         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1125         * printcmd.c (ui_printf):  Handle size_t_arg.
1126         * ui-out.c (ui_out::vmessage): Likewise.
1127         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1128         function.
1129         (run_tests): Call test_format_int_sizes.
1130
1131 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1132
1133         * ada-exp.y (write_ambiguous_var): Update.
1134         * buildsym.c (add_symbol_to_list): Update.
1135         * dwarf2read.c (read_variable): Update.
1136         (new_symbol): Update.
1137         * jit.c (finalize_symtab): Update.
1138         * language.c (language_alloc_type_symbol): Update.
1139         * symtab.c (fixup_symbol_section): Update.
1140         (initialize_objfile_symbol_1): Move code to...
1141         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1142         (allocate_symbol): Update.
1143         (allocate_template_symbol): Update.
1144         (get_symbol_address): Update.
1145         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1146         of having as a field, and add a constructor.
1147         (SYMBOL_VALUE): Update.
1148         (SYMBOL_VALUE_ADDRESS): Update.
1149         (SET_SYMBOL_VALUE_ADDRESS): Update.
1150         (SYMBOL_VALUE_BYTES): Update.
1151         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1152         (SYMBOL_BLOCK_VALUE): Update.
1153         (SYMBOL_VALUE_CHAIN): Update.
1154         (SYMBOL_LANGUAGE): Update.
1155         (SYMBOL_SECTION): Update.
1156         (SYMBOL_OBJ_SECTION): Update.
1157         (SYMBOL_SET_LANGUAGE): Update.
1158         (SYMBOL_SET_LINKAGE_NAME): Update.
1159         (SYMBOL_SET_NAMES): Update.
1160         (SYMBOL_NATURAL_NAME): Update.
1161         (SYMBOL_LINKAGE_NAME): Update.
1162         (SYMBOL_DEMANGLED_NAME): Update.
1163         (SYMBOL_SEARCH_NAME): Update.
1164         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1165         (struct symbol): Update.
1166         (struct template_symbol): Update.
1167         (struct rust_vtable_symbol): Update.
1168         * xcoffread.c (SYMBOL_DUP): Update.
1169
1170 2019-11-12  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-layout.c (show_layout): Set current_layout.
1173         (show_source_disasm_command, show_data)
1174         (show_source_or_disasm_and_command): Don't set current_layout.
1175
1176 2019-11-12  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1179
1180 2019-11-12  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui-win.c (resize_message): New global.
1183         (show_tui_resize_message): New function.
1184         (tui_async_resize_screen): Print message if requested.
1185         (_initialize_tui_win): Add tui-resize-message setting.
1186         * NEWS: Add entry for new commands.
1187
1188 2019-11-11  Tom Tromey  <tom@tromey.com>
1189
1190         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1191         functions.
1192
1193 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1194
1195         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1196
1197 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1200         function.
1201         * python/python-internal.h (gdbpy_lookup_static_symbols):
1202         Declare new function.
1203         * python/python.c (python_GdbMethods): Add
1204         gdb.lookup_static_symbols method.
1205         * NEWS: Mention gdb.lookup_static_symbols.
1206
1207 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1210         static block of current object file first.  Also fix typo in
1211         header comment.
1212
1213 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * stack.c (set_last_displayed_sal): Delete.
1216         (last_displayed_sal_valid): Delete.
1217         (last_displayed_pspace): Delete.
1218         (last_displayed_addr): Delete.
1219         (last_displayed_symtab): Delete.
1220         (last_displayed_line): Delete.
1221         (class last_displayed_symtab_info_type): New.
1222         (last_displayed_symtab_info): New static global variable.
1223         (print_frame_info): Call methods on last_displayed_symtab_info.
1224         (clear_last_displayed_sal): Update header comment, and make use of
1225         last_displayed_symtab_info.
1226         (last_displayed_sal_is_valid): Likewise.
1227         (get_last_displayed_pspace): Likewise.
1228         (get_last_displayed_addr): Likewise.
1229         (get_last_displayed_symtab): Likewise.
1230         (get_last_displayed_line): Likewise.
1231         (get_last_displayed_sal): Likewise.
1232         * stack.h (clear_last_displayed_sal): Update header comment.
1233         (last_displayed_sal_is_valid): Likewise.
1234         (get_last_displayed_pspace): Likewise.
1235         (get_last_displayed_addr): Likewise.
1236         (get_last_displayed_symtab): Likewise.
1237         (get_last_displayed_line): Likewise.
1238         (get_last_displayed_sal): Likewise.
1239
1240 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * stack.c (frame_show_address): Convert return type to bool.
1243         * stack.h (frame_show_address): Likewise, and update header
1244         comment.
1245
1246 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1249         * unittests/vec-utils-selftests.c: New file.
1250         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1251
1252 2019-11-10  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1255         (tui_highlight_win): Likewise.
1256         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1257         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1258         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1259         Don't set can_highlight.
1260
1261 2019-11-10  Tom Tromey  <tom@tromey.com>
1262
1263         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1264         Remove unused declaration.
1265
1266 2019-11-08  Tom Tromey  <tromey@adacore.com>
1267
1268         * top.c (read_command_file): Update.
1269         (command_line_input): Make return type const.
1270         * python/py-gdb-readline.c: Update.
1271         * linespec.c (decode_line_2): Update.
1272         * defs.h (command_line_input): Make return type const.
1273         * cli/cli-script.c (read_next_line): Make return type const.
1274         * ada-lang.c (get_selections): Update.
1275
1276 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1277
1278         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1279         * mi/mi-main.c (output_cores): Likewise.
1280         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1281         (linux_xfer_osdata_modules): Likewise.
1282         * remote.c (register_remote_support_xml): Likewise.
1283         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1284         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1285
1286 2019-11-06  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-interp.c: Don't include readline.h.
1289         * tui/tui-hooks.c: Don't include readline.h.
1290         * symmisc.c: Include tilde.h, not readline.h.
1291         * symfile.c: Include tilde.h, not readline.h.
1292         * source.c: Include tilde.h, not readline.h.
1293         * solib.c: Include tilde.h, not readline.h.
1294         * psymtab.c: Include tilde.h, not readline.h.
1295         * exec.c: Include tilde.h, not readline.h.
1296         * corelow.c: Include tilde.h, not readline.h.
1297         * cli/cli-dump.c: Include tilde.h, not readline.h.
1298         * cli/cli-cmds.c: Don't include readline.h.
1299
1300 2019-11-05  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1303         (tui_disassemble): Set addr_size.
1304         (tui_disasm_window::set_contents): Use addr_size.
1305
1306 2019-11-05  Tom Tromey  <tom@tromey.com>
1307
1308         * rust-lang.c (rust_language_defn): Update.
1309         * python/py-value.c (valpy_string): Call c_get_string.
1310         * p-lang.c (pascal_language_defn): Update.
1311         * opencl-lang.c (opencl_language_defn): Update.
1312         * objc-lang.c (objc_language_defn): Update.
1313         * m2-lang.c (m2_language_defn): Update.
1314         * language.c (unknown_language_defn, auto_language_defn): Update.
1315         (default_get_string): Remove.
1316         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1317         * go-lang.c (go_language_defn): Update.
1318         * f-lang.c (f_language_defn): Update.
1319         * d-lang.c (d_language_defn): Update.
1320         * c-lang.c (c_language_defn, cplus_language_defn)
1321         (asm_language_defn, minimal_language_defn): Update.
1322         * ada-lang.c (ada_language_defn): Update.
1323         * language.h (struct language_defn) <la_get_string>: Remove.
1324         (LA_GET_STRING): Remove.
1325         (default_get_string): Don't declare.
1326
1327 2019-11-05  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-source.h (struct tui_source_window): Inline
1330         constructor.  Remove destructor.
1331         <style_changed, m_observable>: Move to superclass.
1332         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1333         (struct tui_source_window_base): Move private members to end.
1334         <style_changed, m_observable>: Move from tui_source_window.
1335         * tui/tui-winsource.c (tui_copy_source_line): Move from
1336         tui-source.c.  Rename from copy_source_line.  Add special handling
1337         for negative line number.
1338         (tui_source_window_base::style_changed): Move from
1339         tui_source_window.
1340         (tui_source_window_base): Register observer.
1341         (~tui_source_window_base): New.
1342         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1343         rename.
1344         (tui_source_window::set_contents): Use tui_copy_source_line.
1345         (tui_source_window::tui_source_window): Move to tui-source.h.
1346         (tui_source_window::~tui_source_window): Remove.
1347         (tui_source_window::style_changed): Move to superclass.
1348         * tui/tui-disasm.c (tui_disassemble): Create string file with
1349         styling, when possible.  Add "addr_size" parameter.
1350         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1351         Don't compute maximum size.
1352         (len_without_escapes): New function
1353
1354 2019-11-05  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1357         std::string.
1358         * tui/tui-winsource.c (tui_show_source_line): Update.
1359         * tui/tui-source.c (tui_source_window::set_contents): Update.
1360         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1361
1362 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1363
1364         * symtab.h (gdb_static_assert): Put && operator at the beginning
1365         of the line instead of the end.
1366
1367 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1368
1369         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1370         and sizeof (symbol).
1371         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1372
1373 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1374
1375         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1376         * configure.host: Mark *-*-solaris2.10* obsolete.
1377         * configure.tgt: Mark Solaris < 11 obsolete.
1378         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1379         Update target triplet.
1380
1381 2019-11-01  Tom Tromey  <tromey@adacore.com>
1382
1383         * utils.c (print_sys_errmsg): Simplify.
1384
1385 2019-11-01  Tom Tromey  <tromey@adacore.com>
1386
1387         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1388
1389 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1390
1391         * configure: Regenerate.
1392         * configure.ac: Remove check for strerror_r.
1393         * gdbsupport/common.m4: Check for strerror_r.
1394
1395 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1396
1397         PR gdb/25124
1398
1399         * arm-tdep.c (arm_per_objfile): Rename to ...
1400         (arm_per_bfd): ... this.
1401         (arm_objfile_data_key): Rename to ...
1402         (arm_bfd_data_key): ... this.
1403         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1404         data.
1405         (arm_record_special_symbol): Likewise.
1406
1407 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1408
1409         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1410         end.
1411         * c-typeprint.c (c_print_typedef): Likewise.
1412         * f-typeprint.c (f_print_typedef): Likewise.
1413         * m2-typeprint.c (m2_print_typedef): Likewise.
1414         * p-typeprint.c (pascal_print_typedef): Likewise.
1415         * rust-lang.c (rust_print_typedef): Likewise.
1416         * symtab.c (print_symbol_info): Print a newline after calling
1417         typedef_print.
1418
1419 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * symtab.c (info_module_cmdlist): New variable.
1422         (info_module_command): New function.
1423         (search_module_symbols): New function.
1424         (info_module_subcommand): New function.
1425         (struct info_modules_var_func_options): New struct.
1426         (info_modules_var_func_options_defs): New variable.
1427         (make_info_modules_var_func_options_def_group): New function.
1428         (info_module_functions_command): New function.
1429         (info_module_variables_command): New function.
1430         (info_module_var_func_command_completer): New function.
1431         (_initialize_symtab): Register new 'info module functions' and
1432         'info module variables' commands.
1433         * symtab.h (typedef symbol_search_in_module): New typedef.
1434         (search_module_symbols): Declare new function.
1435         * NEWS: Mention new commands.
1436
1437 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1438
1439         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1440         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1441         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1442         MODULES_DOMAIN.
1443         (scan_partial_symbols): Only create partial module symbols for non
1444         declarations.
1445         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1446         and MODULES_DOMAIN.
1447         * symtab.c (search_domain_name): Likewise.
1448         (search_symbols): Likewise.
1449         (print_symbol_info): Likewise.
1450         (symtab_symbol_info): Likewise.
1451         (info_modules_command): New function.
1452         (_initialize_symtab): Register 'info modules' command.
1453         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1454         * NEWS: Mention new 'info modules' command.
1455
1456 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1457
1458         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1459         and $_gdb_maint_setting_str.
1460
1461 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1462
1463         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1464         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1465         (str_value_from_setting, gdb_setting_str_internal_fn)
1466         (gdb_maint_setting_str_internal_fn): New functions.
1467         (_initialize_cli_cmds): Define the new convenience functions.
1468         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1469         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1470
1471 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1472
1473         * agent.c (set_can_use_agent): When the setting is turned on,
1474         look up agent symbols if we don't have them yet.
1475         (agent_new_objfile): Don't look up agent symbols when the agent
1476         setting is off.
1477
1478 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1479
1480         * config.in: Regenerate.
1481
1482 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1483
1484         * configure: Regenerate.
1485         * configure.ac: Check for strerror_r.
1486         * gdbsupport/common-utils.h (safe_strerror): Change return value
1487         to const char * and document that this function is now threadsafe.
1488         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1489         thread_local and call strerror_r, if available.
1490         * utils.c (perror_string): Update.
1491         (print_sys_errmsg): Update.
1492
1493 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1494
1495         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1496         objfile_key.
1497         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1498         objfile to fetch per-bfd data.
1499         (arm_find_exidx_entry): Likewise.
1500
1501 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1502
1503         * gdbsupport/agent.c (debug_agent): Change type to bool.
1504         (use_agent): Likewise.
1505         (all_agent_symbols_look_up): Likewise.
1506         (agent_loaded_p): Change return value to bool.
1507         (agent_look_up_symbols): Update.
1508         (agent_capability_check): Change return value to bool.
1509         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1510         (debug_agent): Change type to bool.
1511         (use_agent): Likewise.
1512         (agent_capability_check): Change return value to bool.
1513
1514 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1515
1516         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1517         (build_minimal_symbol_hash_tables): Code to clear the table moved
1518         to clear_minimal_symbol_hash_tables.
1519         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1520         when needed.
1521
1522 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1523
1524         * infcmd.c: Remove includes.
1525         * infrun.c: Remove includes.
1526
1527 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1528
1529         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1530         (grow_vect): Remove declaration.
1531         (ada_type_of_array): Remove declaration.
1532         (ada_update_initial_language): Remove declaration.
1533         (ada_fold_name): Remove declaration.
1534         (ada_fill_in_ada_prototype): Remove declaration.
1535         (user_select_syms): Remove declaration.
1536         (get_selections): Remove declaration.
1537         (ada_tag_type): Remove declaration.
1538         (ada_value_tag): Remove declaration.
1539         (ada_is_others_clause): Remove declaration.
1540         (ada_in_variant): Remove declaration.
1541         (ada_value_struct_elt): Remove declaration.
1542         (ada_attribute_name): Remove declaration.
1543         (ada_system_address_type): Remove declaration.
1544         * ada-lang.c (ada_watch_location_expression): Make static.
1545         (GROW_VECT): Move here from ada-lang.h.
1546         (grow_vect): Make static.
1547         (ada_update_initial_language): Make static.
1548         (ada_fold_name): Make static.
1549         (ada_type_of_array): Make static.
1550         (encoded_ordered_before): Move up.
1551         (sort_choices): Move up.
1552         (print_signatures): Move up.
1553         (ada_print_symbol_signature): Move up.
1554         (get_selections): Move up and make static.
1555         (user_select_syms): Move up and make static.
1556         (ada_value_struct_elt): Move up and make static.
1557         (ada_tag_type): Make static.
1558         (ada_value_tag): Make static.
1559         (ada_is_others_clause): Make static.
1560         (ada_in_variant): Make static.
1561         (ada_attribute_name): Make static.
1562
1563 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1564
1565         * ada-lang.c: Remove includes.
1566         * ada-typeprint.c: Remove includes.
1567         * ada-valprint.c: Remove includes.
1568
1569 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1570
1571         * addrmap.c: Add static assertions of type size, moved from
1572         _initialize_addrmap.
1573         (_initialize_addrmap): Remove.
1574
1575 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1576
1577         * coffread.c (record_minimal_symbol): Update.
1578         (process_coff_symbol): Update.
1579         * dbxread.c (read_dbx_symtab): Update.
1580         * dwarf2read.c (add_partial_symbol): Update.
1581         (fixup_go_packaging): Update.
1582         (load_partial_dies): Update.
1583         (new_symbol): Update.
1584         * elfread.c (record_minimal_symbol): Change signature to use
1585         gdb::string_view instead of name+len.
1586         (elf_symtab_read): Update.
1587         (elf_rel_plt_read): Update.
1588         * mdebugread.c (parse_partial_symbols): Update.
1589         (handle_psymbol_enumerators): Update.
1590         (new_symbol): Update.
1591         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1592         to use gdb::string_view instead of name+len.
1593         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1594         * psympriv.h (add_psymbol_to_list): Likewise.
1595         * psymtab.c (add_psymbol_to_bcache): Likewise.
1596         (add_psymbol_to_list): Likewise.
1597         * stabsread.c (define_symbol): Update.
1598         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1599         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1600         (symbol_set_names): Likewise.
1601         * xcoffread.c (scan_xcoff_symtab): Update.
1602
1603 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1604
1605         * symtab.h (symbol_set_names): Document that copy_name must be
1606         set to true for non-nullterminated strings.
1607         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1608         linkage_name if the entry was not found and we need to demangle.
1609
1610 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1611
1612         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1613         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1614         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1615         * gdbsupport/gdb_binary_search.h: New file.
1616
1617 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1618
1619         * NEWS: Mention new --with-system-gdbinit-dir option.
1620         * config.in: Regenerate.
1621         * configure: Regenerate.
1622         * configure.ac: Add new option --with-system-gdbinit-dir.
1623         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1624         for a ".gdb" suffix.
1625         * main.c (get_init_files): Change system_gdbinit argument to
1626         a vector and return the files in SYSTEM_GDBINIT_DIR in
1627         addition to SYSTEM_GDBINIT.
1628         (captured_main_1): Update.
1629         (print_gdb_help): Update.
1630         * top.c (print_gdb_configuration): Also print the value of
1631         SYSTEM_GDBINIT_DIR.
1632
1633 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1634
1635         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1636         that takes gdb::string_view arguments.
1637
1638 2019-10-26  Tom de Vries  <tdevries@suse.de>
1639
1640         * aarch64-linux-tdep.c: Fix typos in comments.
1641         * aarch64-tdep.c: Same.
1642         * ada-lang.c: Same.
1643         * amd64-nat.c: Same.
1644         * arc-tdep.c: Same.
1645         * arch/aarch64-insn.c: Same.
1646         * block.c: Same.
1647         * breakpoint.h: Same.
1648         * btrace.h: Same.
1649         * c-varobj.c: Same.
1650         * cli/cli-decode.c: Same.
1651         * cli/cli-script.c: Same.
1652         * cli/cli-utils.h: Same.
1653         * coff-pe-read.c: Same.
1654         * coffread.c: Same.
1655         * compile/compile-cplus-symbols.c: Same.
1656         * compile/compile-object-run.c: Same.
1657         * completer.c: Same.
1658         * corelow.c: Same.
1659         * cp-support.c: Same.
1660         * demangle.c: Same.
1661         * dwarf-index-write.c: Same.
1662         * dwarf2-frame.c: Same.
1663         * dwarf2-frame.h: Same.
1664         * eval.c: Same.
1665         * frame-base.h: Same.
1666         * frame.h: Same.
1667         * gdbcmd.h: Same.
1668         * gdbtypes.h: Same.
1669         * gnu-nat.c: Same.
1670         * guile/scm-objfile.c: Same.
1671         * i386-tdep.c: Same.
1672         * i386-tdep.h: Same.
1673         * infcall.c: Same.
1674         * infcall.h: Same.
1675         * linux-nat.c: Same.
1676         * m68k-tdep.c: Same.
1677         * macroexp.c: Same.
1678         * memattr.c: Same.
1679         * mi/mi-cmd-disas.c: Same.
1680         * mi/mi-getopt.h: Same.
1681         * mi/mi-main.c: Same.
1682         * minsyms.c: Same.
1683         * nat/aarch64-sve-linux-sigcontext.h: Same.
1684         * objfiles.h: Same.
1685         * ppc-linux-nat.c: Same.
1686         * ppc-linux-tdep.c: Same.
1687         * ppc-tdep.h: Same.
1688         * progspace.h: Same.
1689         * prologue-value.h: Same.
1690         * python/py-evtregistry.c: Same.
1691         * python/py-instruction.h: Same.
1692         * record-btrace.c: Same.
1693         * record-full.c: Same.
1694         * remote.c: Same.
1695         * rs6000-tdep.c: Same.
1696         * ser-tcp.c: Same.
1697         * sol-thread.c: Same.
1698         * sparc-sol2-tdep.c: Same.
1699         * sparc64-tdep.c: Same.
1700         * stabsread.c: Same.
1701         * symfile.c: Same.
1702         * symtab.h: Same.
1703         * target.c: Same.
1704         * tracepoint.c: Same.
1705         * tui/tui-data.h: Same.
1706         * tui/tui-io.c: Same.
1707         * tui/tui-win.c: Same.
1708         * tui/tui.c: Same.
1709         * unittests/rsp-low-selftests.c: Same.
1710         * user-regs.h: Same.
1711         * utils.c: Same.
1712         * utils.h: Same.
1713         * valarith.c: Same.
1714         * valops.c: Same.
1715         * valprint.c: Same.
1716         * valprint.h: Same.
1717         * value.c: Same.
1718         * value.h: Same.
1719         * varobj.c: Same.
1720         * x86-nat.h: Same.
1721         * xtensa-tdep.c: Same.
1722
1723 2019-10-25  Ali Tamur <tamur@google.com>
1724
1725         * charset.c (find_charset_names): Reflect API change.
1726
1727 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1728
1729         * symtab.c (struct demangled_name_entry): Change demangled name
1730         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1731         part of the struct anymore.
1732         (symbol_set_names): No longer obstack allocate + copy the demangled
1733         name, just store the allocated name from bfd.
1734
1735 2019-10-25  Tom Tromey  <tromey@adacore.com>
1736
1737         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1738         (bsearch_cie_cmp, add_cie): Remove.
1739         (find_cie): Reimplement.
1740         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1741         (dwarf2_build_frame_info): Update.
1742
1743 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1744
1745         PR gdb/25126
1746         * symfile.c (reread_symbols): Call forget_cached_source_info to
1747         clear the stale source cache.
1748
1749 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1750
1751         * configure: Regenerate.
1752         * configure.ac: Remove code that sets python_has_threads.
1753
1754 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1755
1756         * config.in: Regenerate.
1757         * configure: Regenerate.
1758         * configure.ac: Remove the code that uses sed to get the python
1759         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1760
1761 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1764         error paths.
1765
1766 2019-10-23  Tom Tromey  <tom@tromey.com>
1767
1768         * arc-tdep.c: Remove ".." from include.
1769         * frv-tdep.c: Remove ".." from include.
1770         * lm32-tdep.c: Remove ".." from include.
1771         * microblaze-tdep.c: Remove ".." from include.
1772         * or1k-tdep.h: Remove ".." from include.
1773         * s12z-tdep.c: Remove ".." from include.
1774         * Makefile.in (OPCODES_CFLAGS): Add comment.
1775         (TOP_CFLAGS): New variable.
1776         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1777
1778 2019-10-23  Tom Tromey  <tom@tromey.com>
1779
1780         * Makefile.in (READLINE_DIR): Update.
1781
1782 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1783
1784         * infcall.c (call_function_by_hand_dummy): Fix the function
1785         comment.  And extract out a code section into...
1786         (reserve_stack_space): ...this new function.
1787
1788 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1789
1790         * infcall.c (value_arg_coerce): Remove an unused parameter.
1791         (call_function_by_hand_dummy): Update the call to
1792         'value_arg_coerce'.
1793
1794 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1795
1796         * infcall.c (call_function_by_hand_dummy): Refactor.
1797
1798 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1799
1800         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1801
1802 2019-10-23  Tom Tromey  <tom@tromey.com>
1803
1804         * configure: Rebuild.
1805         * configure.ac: Don't check for sigprocmask.
1806         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1807
1808 2019-10-23  Tom Tromey  <tom@tromey.com>
1809
1810         * configure: Rebuild.
1811         * acinclude.m4: Use m4_include, not sinclude.
1812
1813 2019-10-23  Tom de Vries  <tdevries@suse.de>
1814
1815         PR breakpoints/24687
1816         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1817
1818 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1819
1820         * symtab.c (struct demangled_name_entry) <language>: Change from
1821         bitfield to regular variable.
1822
1823 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1824
1825         * symtab.c (struct demangled_name_entry): Add a constructor.
1826         (free_demangled_name_entry): New function to call the destructor
1827         for demangled_name_entry.
1828         (create_demangled_names_hash): Pass free_demangled_name_entry to
1829         htab_create_alloc.
1830         (symbol_set_names): Call placement new for demangled_name_entry.
1831         * utils.c: No longer include xxhash.h here, now that fast_hash
1832         is inlined in the header.
1833         * utils.h: Instead, include it here.
1834
1835 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1836
1837         * Makefile.in: Link with libxxhash.
1838         * config.in: Regenerate.
1839         * configure: Regenerate.
1840         * configure.ac: Search for libxxhash.
1841         * utils.c (fast_hash): Use xxhash if present.
1842
1843 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1844
1845         * utils.h (fast_hash): New function.
1846         * symtab.c (hash_demangled_name_entry): Call new function
1847         fast_hash.
1848
1849 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1850
1851         * symtab.c (struct demangled_name_entry): Change type of mangled
1852         to gdb::string_view. Also adds a constructor that takes the
1853         mangled name.
1854         (hash_demangled_name_entry): Update.
1855         (eq_demangled_name_entry): Update.
1856         (free_demangled_name_entry): New function to call the destructor
1857         now that this is not a POD anymore.
1858         (create_demangled_names_hash): Pass free_demangled_name_entry to
1859         htab_create_alloc.
1860         (symbol_set_names): Update.
1861
1862 2019-10-21  Ali Tamur  <tamu@google.com>
1863
1864         * dwarf2read.c (dir_index): Change type.
1865         (file_name_index): Likewise.
1866         (line_header::include_dir_at): Change comment and implementation on
1867         whether it is DWARF 5.
1868         (line_header::is_valid_file_index): New function.
1869         (line_header::file_name_at): Change comment and implementation on
1870         whether it is DWARF 5.
1871         (line_header::file_names): Change to private field renamed as
1872         m_file_names and introduce a new accessor method.
1873         (line_header::file_names_size): New method.
1874         (line_header::include_dirs): Change to private field and rename as
1875         m_include_dirs.
1876         (dw2_get_file_names_reader): Define local var at a smaller scope and
1877         reflect API change.
1878         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1879         (process_structure_scope): Likewise.
1880         (line_header::add_include_dir): Change message and reflect renaming.
1881         (line_header::add_file_name): Likewise.
1882         (read_formatted_entries): Handle DW_FORM_data16.
1883         (dwarf_decode_line_header): Fix line header length calculation.
1884         (psymtab_include_file_name): Change comment and API.
1885         (lnp_state_machine::m_file): Update comment and reflect type change.
1886         (lnp_state_machine::record_line): Reflect type change.
1887         (dwarf_decode_lines): Reflect API change.
1888         (file_file_name): Likewise.
1889         (file_full_name): Likewise.
1890
1891 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1892
1893         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1894
1895 2019-10-21  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1898
1899 2019-10-21  Tom Tromey  <tom@tromey.com>
1900
1901         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1902         NM_H.   Use AC_CONFIG_LINKS.
1903         * configure: Rebuild.
1904         * Makefile.in (NM_H): New variable.
1905         (generated_files): Add NM_H.  Remove gcore.
1906         (nm.h, stamp-nmh): New targets.
1907
1908 2019-10-20  Tom Tromey  <tom@tromey.com>
1909
1910         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1911         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1912         obsolete comment.
1913         (put_objfile_before): Now static.
1914
1915 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1916
1917         * gdbsupport/common-utils.h (startswith): Change return type to
1918         bool.
1919
1920 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1921
1922         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1923         * breakpoint.c (bp_locations_compare): Rename to...
1924         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1925         (update_global_location_list): Use std::sort instead of qsort.
1926         * buildsym.c (compare_line_numbers): Rename to...
1927         (lte_is_less_than): ...this, and change to std::sort semantics.
1928         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1929         instead of qsort.
1930         * disasm.c (compare_lines): Rename to...
1931         (line_is_less_than): ...this, and change to std::sort semantics.
1932         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1933         of qsort.
1934         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1935         (fde_is_less_than): ...this, and change to std::sort semantics.
1936         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1937         * mdebugread.c (compare_blocks):
1938         (block_is_less_than): ...this, and change to std::sort semantics.
1939         (sort_blocks): Call std::sort instead of qsort.
1940         * objfiles.c (qsort_cmp): Rename to...
1941         (sort_cmp): ...this, and change to std::sort semantics.
1942         (update_section_map): Call std::sort instead of qsort.
1943         * remote.c (compare_pnums): Remove.
1944         (map_regcache_remote_table): Call std::sort instead of qsort.
1945         * utils.c (compare_positive_ints): Remove.
1946         * utils.h (compare_positive_ints): Remove.
1947         * xcoffread.c (compare_lte): Remove.
1948         (arrange_linetable): Call std::sort instead of qsort.
1949
1950 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1951
1952         * symfile.c (init_entry_point_info): Fix typo.
1953         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1954
1955 2019-10-18  Tom de Vries  <tdevries@suse.de>
1956
1957         * aarch64-tdep.c: Fix typos in comments.
1958         * ada-lang.c: Same.
1959         * ada-tasks.c: Same.
1960         * alpha-tdep.c: Same.
1961         * alpha-tdep.h: Same.
1962         * amd64-nat.c: Same.
1963         * amd64-windows-tdep.c: Same.
1964         * arc-tdep.c: Same.
1965         * arc-tdep.h: Same.
1966         * arch-utils.c: Same.
1967         * arm-nbsd-tdep.c: Same.
1968         * arm-tdep.c: Same.
1969         * ax-gdb.c: Same.
1970         * blockframe.c: Same.
1971         * btrace.c: Same.
1972         * c-varobj.c: Same.
1973         * coff-pe-read.c: Same.
1974         * coffread.c: Same.
1975         * cris-tdep.c: Same.
1976         * darwin-nat.c: Same.
1977         * dbxread.c: Same.
1978         * dcache.c: Same.
1979         * disasm.c: Same.
1980         * dtrace-probe.c: Same.
1981         * dwarf-index-write.c: Same.
1982         * dwarf2-frame-tailcall.c: Same.
1983         * dwarf2-frame.c: Same.
1984         * dwarf2read.c: Same.
1985         * eval.c: Same.
1986         * exceptions.c: Same.
1987         * fbsd-tdep.c: Same.
1988         * findvar.c: Same.
1989         * frame.c: Same.
1990         * frv-tdep.c: Same.
1991         * gnu-v3-abi.c: Same.
1992         * go32-nat.c: Same.
1993         * h8300-tdep.c: Same.
1994         * hppa-tdep.c: Same.
1995         * i386-linux-tdep.c: Same.
1996         * i386-tdep.c: Same.
1997         * ia64-libunwind-tdep.c: Same.
1998         * ia64-tdep.c: Same.
1999         * infcmd.c: Same.
2000         * infrun.c: Same.
2001         * linespec.c: Same.
2002         * linux-nat.c: Same.
2003         * linux-thread-db.c: Same.
2004         * machoread.c: Same.
2005         * mdebugread.c: Same.
2006         * mep-tdep.c: Same.
2007         * mn10300-tdep.c: Same.
2008         * namespace.c: Same.
2009         * objfiles.c: Same.
2010         * opencl-lang.c: Same.
2011         * or1k-tdep.c: Same.
2012         * osabi.c: Same.
2013         * ppc-linux-nat.c: Same.
2014         * ppc-linux-tdep.c: Same.
2015         * ppc-sysv-tdep.c: Same.
2016         * printcmd.c: Same.
2017         * procfs.c: Same.
2018         * record-btrace.c: Same.
2019         * record-full.c: Same.
2020         * remote-fileio.c: Same.
2021         * remote.c: Same.
2022         * rs6000-tdep.c: Same.
2023         * s12z-tdep.c: Same.
2024         * score-tdep.c: Same.
2025         * ser-base.c: Same.
2026         * ser-go32.c: Same.
2027         * skip.c: Same.
2028         * sol-thread.c: Same.
2029         * solib-svr4.c: Same.
2030         * solib.c: Same.
2031         * source.c: Same.
2032         * sparc-nat.c: Same.
2033         * sparc-sol2-tdep.c: Same.
2034         * sparc-tdep.c: Same.
2035         * sparc64-tdep.c: Same.
2036         * stabsread.c: Same.
2037         * stack.c: Same.
2038         * symfile.c: Same.
2039         * symtab.c: Same.
2040         * target-descriptions.c: Same.
2041         * target-float.c: Same.
2042         * thread.c: Same.
2043         * utils.c: Same.
2044         * valops.c: Same.
2045         * valprint.c: Same.
2046         * value.c: Same.
2047         * varobj.c: Same.
2048         * windows-nat.c: Same.
2049         * xcoffread.c: Same.
2050         * xstormy16-tdep.c: Same.
2051         * xtensa-tdep.c: Same.
2052
2053 2019-10-17  Tom Tromey  <tromey@adacore.com>
2054
2055         * configure: Rebuild.
2056         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2057         in AC_CONFIG_FILES invocation.
2058         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2059         new-style config.status invocation.
2060
2061 2019-10-17  Tom de Vries  <tdevries@suse.de>
2062
2063         * arm-nbsd-nat.c: Fix typos in comments.
2064         * arm-tdep.c: Same.
2065         * darwin-nat-info.c: Same.
2066         * dwarf2read.c: Same.
2067         * elfread.c: Same.
2068         * event-top.c: Same.
2069         * findvar.c: Same.
2070         * gdbtypes.c: Same.
2071         * hppa-tdep.c: Same.
2072         * i386-tdep.c: Same.
2073         * jit.c: Same.
2074         * main.c: Same.
2075         * mdebugread.c: Same.
2076         * moxie-tdep.c: Same.
2077         * nto-procfs.c: Same.
2078         * osabi.c: Same.
2079         * ppc-linux-tdep.c: Same.
2080         * remote.c: Same.
2081         * riscv-tdep.c: Same.
2082         * s390-tdep.c: Same.
2083         * sh-tdep.c: Same.
2084         * sparc-linux-tdep.c: Same.
2085         * sparc-nat.c: Same.
2086         * stack.c: Same.
2087         * target-descriptions.c: Same.
2088         * top.c: Same.
2089         * varobj.c: Same.
2090
2091 2019-10-16  Tom Tromey  <tom@tromey.com>
2092
2093         * objfiles.h (struct objfile) <original_name>: Now const.
2094
2095 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2096
2097         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2098         pass on to sigsetjmp's second argument.
2099         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2100
2101 2019-10-16  Keith Seitz  <keiths@redhat.com>
2102
2103         PR gdb/23567
2104         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2105         sections whose size is greater than the file size.
2106
2107 2019-10-16  Jim Wilson  <jimw@sifive.com>
2108
2109         * riscv-tdep.c (riscv_gcc_target_options): New.
2110         (riscv_gnu_triplet_regexp): New.
2111         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2112         set_gdbarch_gnu_triplet_regexp.
2113
2114 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2115
2116         * Makefile.in: Add xml-builtin.h.
2117         * features/feature_to_c.sh: Add an include for xml-builtin.h
2118         to ensure that the compiler checks that the types match.
2119         * xml-builtin.h: New file.
2120         * xml-support.c (fetch_xml_builtin): Add missing const.
2121         * xml-support.h: Remove declaration of xml_builtins.
2122
2123 2019-10-16  Tom de Vries  <tdevries@suse.de>
2124
2125         PR tdep/25096
2126         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2127         (amd64_classify_aggregate): ... here.
2128         (amd64_classify_aggregate_field): Handled fiels of nested structs
2129         recursively.
2130
2131 2019-10-16  Tom de Vries  <tdevries@suse.de>
2132
2133         PR tdep/24104
2134         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2135         that handles 'theclass'.
2136
2137 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * linespec.c (decode_digits_ordinary): Update comment.
2140         * make-target-delegates: No longer need to handle VEC case.
2141         * memrange.c (normalize_mem_ranges): Update comment.
2142         * namespace.c (add_using_directive): Update comment.
2143         * objc-lang.c (uniquify_strings): Update comment.
2144         * ppc-linux-nat.c (struct thread_points): Update comment.
2145         * probe.h (find_probes_in_objfile): Update comment.
2146         * target.h (enum flash_preserve_mode): Update comment.
2147         * varobj.c (varobj_restrict_range): Update comment.
2148         * varobj.h (varobj_list_children): Update comment.
2149
2150 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2151
2152         * Makefile.in: Remove references to vec.h and vec.c.
2153         * aarch64-tdep.c: No longer include vec.h.
2154         * ada-lang.c: Likewise.
2155         * ada-lang.h: Likewise.
2156         * arm-tdep.c: Likewise.
2157         * ax.h: Likewise.
2158         * breakpoint.h: Likewise.
2159         * charset.c: Likewise.
2160         * cp-support.h: Likewise.
2161         * dtrace-probe.c: Likewise.
2162         * dwarf2read.c: Likewise.
2163         * extension.h: Likewise.
2164         * gdb_bfd.c: Likewise.
2165         * gdbsupport/gdb_vecs.h: Likewise.
2166         * gdbsupport/vec.c: Remove.
2167         * gdbsupport/vec.h: Remove.
2168         * gdbthread.h: Likewise.
2169         * guile/scm-type.c: Likewise.
2170         * inline-frame.c: Likewise.
2171         * machoread.c: Likewise.
2172         * memattr.c: Likewise.
2173         * memrange.h: Likewise.
2174         * namespace.h: Likewise.
2175         * nat/linux-btrace.h: Likewise.
2176         * osdata.c: Likewise.
2177         * parser-defs.h: Likewise.
2178         * progspace.h: Likewise.
2179         * python/py-type.c: Likewise.
2180         * record-btrace.c: Likewise.
2181         * rust-exp.y: Likewise.
2182         * solib-target.c: Likewise.
2183         * stap-probe.c: Likewise.
2184         * target-descriptions.c: Likewise.
2185         * target-memory.c: Likewise.
2186         * target.h: Likewise.
2187         * varobj.c: Likewise.
2188         * varobj.h: Likewise.
2189         * xml-support.h: Likewise.
2190
2191 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2194         Update for new std::vector based implementation.
2195         (process_psymtab_comp_unit_reader): Likewise.
2196         (scan_partial_symbols): Likewise.
2197         (recursively_compute_inclusions): Likewise.
2198         (compute_compunit_symtab_includes): Likewise.
2199         (process_imported_unit_die): Likewise.
2200         (queue_and_load_dwo_tu): Likewise.
2201         (follow_die_sig_1): Likewise.
2202         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2203         (typedef dwarf2_per_cu_ptr): Remove.
2204         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2205         function.
2206         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2207         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2208         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2209         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2210         std::vector.
2211
2212 2019-10-15  Tom Tromey  <tromey@adacore.com>
2213
2214         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2215         TID.
2216
2217 2019-10-15  Tom Tromey  <tromey@adacore.com>
2218
2219         * windows-nat.c (windows_nat_target::fetch_registers)
2220         (windows_nat_target::store_registers): Rename "pid" to "tid".
2221
2222 2019-10-15  Tom Tromey  <tromey@adacore.com>
2223
2224         * gdbarch.h, gdbarch.c: Rebuild.
2225         * gdbarch.sh (gcc_target_options): Change return type to
2226         std::string.
2227         * compile/compile.c (get_args): Update.
2228         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2229         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2230         std::string.
2231         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2232         std::string.
2233         * arch-utils.c (default_gcc_target_options): Return std::string.
2234         * arch-utils.h (default_gcc_target_options): Return std::string.
2235         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2236
2237 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2238
2239         * breakpoint.c (breakpoint_chain): Make static.
2240         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2241         of accessing breakpoint_chain.
2242
2243 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2244
2245         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2246         to a gdb::function_view and return value to bool.
2247         * breakpoint.h (iterate_over_breakpoints): Likewise.
2248         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2249         (pop_dummy_frame): Update.
2250         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2251         (gdbscm_breakpoints): Update.
2252         * python/py-breakpoint.c (build_bp_list): Update.
2253         (gdbpy_breakpoints): Update.
2254         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2255         Update.
2256         (bpfinishpy_handle_stop): Update.
2257         (bpfinishpy_handle_exit): Update.
2258         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2259         (svr4_update_solib_event_breakpoints): Update.
2260
2261 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2262
2263         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2264         when unwrapping single-field structs.
2265
2266 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2267
2268         * dwarf2read.c: Remove includes.
2269
2270 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2271
2272         * ui-out.c (ui_out::call_do_message): Silence
2273         -Wformat-nonliteral warning.
2274
2275 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2276
2277         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2278         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2279         include: readline/tilde.h.
2280
2281 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2282
2283         * remote.c (remote_target::get_trace_status): Remove declaration of
2284         trace_regblock_size.
2285
2286 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2287
2288         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2289         (show_user): Remove declaration of cmdlist.
2290         * cli/cli-cmds.h (max_user_call_depth): Declare.
2291         * cli/cli-script.c (execute_user_command): Remove declaration
2292         of max_user_call_depth.
2293
2294 2019-10-11  Jim Wilson  <jimw@sifive.com>
2295
2296         * gdbsupport/print-utils.h (pulongest): Fix comment.
2297         (plongest): Likewise.
2298         (phex): Add missing comment, mention leading zeros.
2299         (phex_nz): Add mention of no leading zeros to comment.
2300
2301         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2302         plongest instead of unsigned long long cast.
2303
2304 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2305
2306         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2307         for external_editor_command and gdbtk_test.
2308
2309 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2310
2311         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2312         * varobj.c (varobjdebug): Move comment to...
2313         * varobj.h (varobjdebug): ...here, and declare.
2314
2315 2019-10-09  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2318         erase_data_content.
2319
2320 2019-10-09  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2323         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2324         * tui/tui-command.c (tui_cmd_window::resize)
2325         (tui_refresh_cmd_win): Update.
2326         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2327         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2328         * tui/tui-data.c (~tui_gen_win_info): Remove.
2329         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2330         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2331         (tui_redisplay_readline, tui_mld_flush)
2332         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2333         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2334         (tui_data_window::erase_data_content)
2335         (tui_data_item_window::rerender)
2336         (tui_data_item_window::refresh_window): Update.
2337         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2338         (box_win, tui_gen_win_info::make_window)
2339         (tui_gen_win_info::make_visible): Update.
2340         (tui_delete_win): Remove.
2341         * tui/tui-winsource.c
2342         (tui_source_window_base::do_erase_source_content): Update.
2343         (tui_show_source_line, tui_source_window_base::update_tab_width)
2344         (tui_source_window_base::update_exec_info): Update.
2345         * tui/tui-data.h (struct curses_deleter): New.
2346         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2347         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2348
2349 2019-10-09  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2352
2353 2019-10-09  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2356         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2357
2358 2019-10-09  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2361         window height directly.
2362         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2363         declare.
2364         * tui/tui-layout.c (tui_default_win_height): Remove.
2365         (tui_default_win_viewport_height): Remove.
2366
2367 2019-10-09  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui.h: Remove comments.
2370
2371 2019-10-09  Tom de Vries  <tdevries@suse.de>
2372
2373         * python/lib/gdb/printer/bound_registers.py: Use
2374         '^builtin_type_bound128' as regexp argument for
2375         add_builtin_pretty_printer.
2376
2377 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2378
2379         * guile/guile.c (guile_extension_script_ops): Remove forward
2380         declaration and mark as static.
2381         (guile_script_ops): Likewise.
2382         (extension_language_guile): Move further down in the file so
2383         it can reference the definitions for guile_{extension_,}script_ops.
2384
2385 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2386
2387         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2388         except SORTL, DFLTCC, and KDSA.
2389
2390 2019-10-08  Tom Tromey  <tromey@adacore.com>
2391
2392         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2393         (struct safe_symbol_file_add_args): Remove.
2394
2395 2019-10-08  Tom Tromey  <tromey@adacore.com>
2396
2397         * windows-nat.c: Don't include buildsym-legacy.h.
2398
2399 2019-10-08  Tom Tromey  <tromey@adacore.com>
2400
2401         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2402
2403 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2404
2405         * gdbtypes.c (overload_debug): Move comment to header.
2406         * gdbtypes.h (overload_debug): Declare.
2407         * valops.c: Remove declaration of overload_debug, instead
2408         include gdbtypes.h.
2409
2410 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2411
2412         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2413         through _().
2414         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2415         move comment...
2416         * language.h (lang_frame_mismatch_warn): ... here. Also add
2417         declaration.
2418         * top.c (lang_frame_mismatch_warn): Remove declaration.
2419         (check_frame_language_change): Pass lang_frame_mismatch_warn
2420         through _().
2421
2422 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2423
2424         * c-lang.h (vtbl_ptr_name): Declare.
2425         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2426         it from the header.
2427         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2428
2429 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2430
2431         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2432         gdb_static_assert.
2433
2434 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2435
2436         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2437         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2438         * ctfread.c: New file.
2439         * ctfread.h: New file.
2440         * elfread.c: Include ctfread.h.
2441         (struct elfinfo text_p): New member ctfsect.
2442         (elf_locate_sections): Mark CTF section.
2443         (elf_symfile_read): Call elfctf_build_psymtabs.
2444         * Makefile.in (LIBCTF): Add.
2445         (CLIBS): Use it.
2446         (CDEPS): Likewise.
2447         (DIST): Add ctfread.c.
2448
2449 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2450
2451         * ctfread.c (struct nextfield): Renamed to ...
2452         (struct ctf_nextfield): ... this.
2453         (struct field_info): Renamed to ...
2454         (strut ctf_field_info): ... this.
2455         (attach_fields_to_type): Update for renamed structures.
2456         (ctf_add_member_cb): Likewise.
2457         (ctf_add_enum_member_cb): Likewise.
2458         (process_struct_members): Likewise.
2459         (process_enum_type): Likewise.
2460
2461 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2462
2463         * tracectf.h: Rename, was ctf.h.
2464         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2465         * tracefile.c: Likewise.
2466         * tracepoint.c: Remove unused include ctf.h.
2467         * mi/mi-main.c: Likewise.
2468         * Makefile.in Replace ctf.c with tracectf.c.
2469
2470 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2471
2472         * version.in: Change version number to "9.0.50.DATE-git".
2473
2474 2019-10-03  Tom Tromey  <tom@tromey.com>
2475
2476         PR rust/24976:
2477         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2478
2479 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2482         cp_search_name_hash.
2483         * NEWS: Add entry about nested function support.
2484
2485 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2486             Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2489         for nested static variables when searchin VAR_DOMAIN.
2490         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2491         global scope, update comment.
2492         (add_partial_subprogram): Call add_partial_subprogram recursively
2493         for nested subroutines when processinng Fortran.
2494         (load_partial_dies): Process the child entities of a subprogram
2495         when processing Fortran.
2496         (partial_die_parent_scope): Handle building scope
2497         for Fortran nested functions.
2498         (process_die): Record that nested functions have a scope.
2499         (new_symbol): Always record Fortran subprograms on the global
2500         symbol list.
2501         (determine_prefix): How to build the prefix for Fortran
2502         subprograms.
2503
2504 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2507         have just sent the thread a SIGSTOP and are waiting for it to
2508         arrive.
2509
2510 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2511
2512         * btrace.c (btrace_add_pc): Remove whitespace before the template
2513         parameter in 'std::vector <...>'.
2514         (parse_xml_btrace_block): Likewise.
2515         (btrace_maint_decode_pt): Likewise.
2516         (btrace_maint_update_packets): Likewise.
2517         (btrace_maint_print_packets): Likewise.
2518         * btrace.h (struct btrace_maint_info): Likewise.
2519         * dwarf2read.c (struct type_unit_group): Likewise.
2520         (build_type_psymtabs_reader): Likewise.
2521         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2522         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2523         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2524
2525 2019-10-03  Tom de Vries  <tdevries@suse.de>
2526
2527         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2528         the first line of the help text for set/show style metadata.
2529
2530 2019-10-02  Tom Tromey  <tromey@adacore.com>
2531
2532         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2533         * gdbsupport/common-inferior.c: New file.
2534         * infcmd.c (startup_with_shell): Don't define.
2535         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2536         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2537         * inferior.h (startup_with_shell): Don't declare.
2538
2539 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2540
2541         * gdbsupport/gdb_assert.h: Include errors.h.
2542         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2543
2544 2019-10-02  Tom Tromey  <tromey@adacore.com>
2545
2546         * NEWS: Add $_ada_exception entry.
2547         * ada-lang.c (struct ada_catchpoint): Add constructor.
2548         <m_kind>: New member.
2549         (allocate_location_exception, re_set_exception): Remove
2550         "ex" parameter.
2551         (should_stop_exception): Compute $_ada_exception.
2552         (check_status_exception, print_it_exception)
2553         (print_one_exception, print_mention_exception): Remove
2554         "ex" parameter.
2555         (allocate_location_catch_exception, re_set_catch_exception)
2556         (check_status_exception, print_it_catch_exception)
2557         (print_one_catch_exception, print_mention_catch_exception)
2558         (print_recreate_catch_exception)
2559         (allocate_location_catch_exception_unhandled)
2560         (re_set_catch_exception_unhandled)
2561         (check_status_exception, print_it_catch_exception_unhandled)
2562         (print_one_catch_exception_unhandled)
2563         (print_mention_catch_exception_unhandled)
2564         (print_recreate_catch_exception_unhandled)
2565         (allocate_location_catch_assert, re_set_catch_assert)
2566         (check_status_assert, print_it_catch_assert)
2567         (print_one_catch_assert, print_mention_catch_assert)
2568         (print_recreate_catch_assert)
2569         (allocate_location_catch_handlers, re_set_catch_handlers)
2570         (check_status_handlers, print_it_catch_handlers)
2571         (print_one_catch_handlers, print_mention_catch_handlers)
2572         (print_recreate_catch_handlers): Remove.
2573         (create_ada_exception_catchpoint): Update.
2574         (initialize_ada_catchpoint_ops): Update.
2575
2576 2019-10-02  Tom Tromey  <tromey@adacore.com>
2577
2578         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2579         (create_excep_cond_exprs): Simplify exception string computation.
2580         (ada_exception_catchpoint_cond_string): Likewise.
2581
2582 2019-10-02  Tom Tromey  <tromey@adacore.com>
2583
2584         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2585         * ada-lang.c (lesseq_defined_than): Handle
2586         LOC_STATIC.
2587         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2588         parameter.
2589         (dwarf2_has_info): Likewise.
2590         (new_symbol): Set maybe_copied on symbol when
2591         appropriate.
2592         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2593         parameter.
2594         <can_copy>: New member.
2595         * elfread.c (record_minimal_symbol): Set maybe_copied
2596         on symbol when appropriate.
2597         (elf_symfile_read): Update call to dwarf2_has_info.
2598         * minsyms.c (lookup_minimal_symbol_linkage): New
2599         function.
2600         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2601         * symtab.c (get_symbol_address, get_msymbol_address):
2602         New functions.
2603         * symtab.h (get_symbol_address, get_msymbol_address):
2604         Declare.
2605         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2606         maybe_copied.
2607         (struct symbol, struct minimal_symbol) <maybe_copied>:
2608         New member.
2609
2610 2019-10-02  Tom Tromey  <tromey@adacore.com>
2611
2612         * source.c (struct current_source_location): New.
2613         (current_source_key): New global.
2614         (current_source_symtab, current_source_line)
2615         (current_source_pspace): Remove.
2616         (get_source_location): New function.
2617         (get_current_source_symtab_and_line)
2618         (set_default_source_symtab_and_line)
2619         (set_current_source_symtab_and_line)
2620         (clear_current_source_symtab_and_line, select_source_symtab)
2621         (info_source_command, print_source_lines_base)
2622         (info_line_command, search_command_helper, _initialize_source):
2623         Update.
2624
2625 2019-10-02  Tom Tromey  <tromey@adacore.com>
2626
2627         * source.c (select_source_symtab): Don't call
2628         decode_line_with_current_source.
2629
2630 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * symtab.c (lookup_global_symbol): Search global block.
2633
2634 2019-10-02  Tom Tromey  <tromey@adacore.com>
2635
2636         * coffread.c (process_coff_symbol): Update.
2637         * dwarf2read.c (var_decode_location, new_symbol): Update.
2638         * mdebugread.c (parse_symbol): Update.
2639         * objfiles.c (relocate_one_symbol): Update.
2640         * stabsread.c (define_symbol, fix_common_block)
2641         (scan_file_globals): Update.
2642         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2643         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2644         * xcoffread.c (process_xcoff_symbol): Update.
2645
2646 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2647
2648         * MAINTAINERS: Update my email address.
2649
2650 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2651
2652         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2653         std::vector.
2654         (build_type_psymtabs_reader): Update for std::vector.
2655         (build_type_psymtab_dependencies): Likewise.
2656         * dwarf2read.h: Remove use of DEF_VEC_P.
2657         (typedef sig_type_ptr): Delete.
2658
2659 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2660
2661         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2662         to std::vector.
2663         (btrace_maint_decode_pt): Likewise, and move allocation of the
2664         vector outside of the loop.
2665         (btrace_maint_update_packets): Update to handle change from VEC to
2666         std::vector.
2667         (btrace_maint_print_packets): Likewise.
2668         (maint_info_btrace_cmd): Likewise.
2669         * btrace.h: Remove use of DEF_VEC_O.
2670         (typedef btrace_pt_packet_s): Delete.
2671         (struct btrace_maint_info) <packets>: Change fromm VEC to
2672         std::vector.
2673         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2674
2675 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2676
2677         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2678         make accesses into the vector constant references.
2679         (btrace_add_pc): Update for std::vector.
2680         (btrace_stitch_bts): Likewise.
2681         (parse_xml_btrace_block): Likewise.
2682         (btrace_maint_update_packets): Likewise.
2683         (btrace_maint_print_packets): Likewise.
2684         (maint_info_btrace_cmd): Likewise.
2685         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2686         std::vector.
2687         (btrace_data::empty): Likewise.
2688         (btrace_data_append): Likewise.
2689         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2690         (typedef btrace_block_s): Delete.
2691         (struct btrace_block): Add constructor.
2692         (struct btrace_data_bts) <blocks>: Change to std::vector.
2693         * nat/linux-btrace.c (perf_event_read_bts): Update for
2694         std::vector.
2695         (linux_read_bts): Likewise.
2696
2697 2019-10-01  Tom Tromey  <tom@tromey.com>
2698
2699         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2700
2701 2019-10-01  Tom Tromey  <tom@tromey.com>
2702
2703         * stack.c (print_frame, info_frame_command_core): Use
2704         styled_string.
2705         * linux-thread-db.c (try_thread_db_load_1)
2706         (try_thread_db_load_from_pdir_1): Use styled_string.
2707         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2708         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2709         (maybe_print_unsupported_script_warning)
2710         (maybe_print_script_not_found_warning): Use styled_string.
2711         * ada-lang.c (user_select_syms): Use styled_string.
2712
2713 2019-10-01  Tom Tromey  <tom@tromey.com>
2714
2715         * p-lang.c (pascal_printstr): Use metadata style.
2716         * value.c (show_convenience): Use metadata style.
2717         * valprint.c (valprint_check_validity, val_print_optimized_out)
2718         (val_print_not_saved, val_print_unavailable)
2719         (val_print_invalid_address, generic_val_print, val_print)
2720         (value_check_printable, val_print_array_elements): Use metadata
2721         style.
2722         * ui-out.h (class ui_out) <field_fmt>: New overload.
2723         <do_field_fmt>: Add style parameter.
2724         * ui-out.c (ui_out::field_fmt): New overload.
2725         * typeprint.c (type_print_unknown_return_type)
2726         (val_print_not_allocated, val_print_not_associated): Use metadata
2727         style.
2728         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2729         parameter.
2730         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2731         * tracepoint.c (tvariables_info_1): Use metadata style.
2732         * stack.c (print_frame_arg, print_frame_info, print_frame)
2733         (info_frame_command_core): Use metadata style.
2734         * skip.c (info_skip_command): Use metadata style.
2735         * rust-lang.c (rust_print_enum): Use metadata style.
2736         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2737         metadata style.
2738         * python/py-framefilter.c (py_print_single_arg): Use metadata
2739         style.
2740         * printcmd.c (do_one_display, print_variable_and_value): Use
2741         metadata style.
2742         * p-valprint.c (pascal_val_print)
2743         (pascal_object_print_value_fields): Use metadata style.
2744         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2745         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2746         parameter.
2747         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2748         * m2-valprint.c (m2_print_long_set): Use metadata style.
2749         * m2-typeprint.c (m2_print_type): Use metadata style.
2750         * infcmd.c (print_return_value_1): Use metadata style.
2751         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2752         * f-valprint.c (info_common_command_for_block): Use metadata
2753         style.
2754         * f-typeprint.c (f_type_print_base): Use metadata style.
2755         * expprint.c (print_subexp_standard): Use metadata style.
2756         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2757         * cli/cli-style.h (class cli_style_option): Add constructor.
2758         (metadata_style): Declare.
2759         * cli/cli-style.c (metadata_style): New global.
2760         (_initialize_cli_style): Register metadata style.
2761         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2762         parameter.
2763         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2764         * c-typeprint.c (c_type_print_base_struct_union)
2765         (c_type_print_base_1): Use metadata style.
2766         * breakpoint.c (watchpoint_value_print)
2767         (print_one_breakpoint_location): Use metadata style.
2768         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2769         style.
2770         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2771         style.
2772         * ada-valprint.c (val_print_packed_array_elements, printstr)
2773         (print_field_values, ada_val_print_ref, ada_val_print): Use
2774         metadata style.
2775         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2776         style.
2777         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2778         style.
2779         * ada-lang.c (user_select_syms): Use metadata style.
2780
2781 2019-10-01  Tom Tromey  <tom@tromey.com>
2782
2783         * cli/cli-cmds.c (pwd_command): Style output.
2784
2785 2019-10-01  Pedro Alves  <palves@redhat.com>
2786             Tom Tromey  <tom@tromey.com>
2787
2788         * symtab.c (print_symbol_info): Use %ps.
2789         (print_msymbol_info): Use %ps.
2790         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2791         * printcmd.c (print_variable_and_value): Use %ps.
2792         * macrocmd.c (show_pp_source_pos): Use %ps.
2793         * infrun.c (print_exited_reason): Use ui_out::message.
2794         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2795         (describe_other_breakpoints): Use ui_out::message and new
2796         formats.
2797         (say_where): Use new formats.
2798         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2799         and new formats.
2800
2801 2019-10-01  Pedro Alves  <palves@redhat.com>
2802             Tom Tromey  <tom@tromey.com>
2803
2804         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2805         (test_gdb_formats): New function.
2806         (run_tests): Call it.
2807         (test_format_specifier): Update.
2808         * utils.h (fputs_filtered): Update comment.
2809         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2810         (fputs_styled_unfiltered): Declare.
2811         * utils.c (fputs_styled_unfiltered): New function.
2812         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2813         (vfprintf_filtered): Update.
2814         (vfprintf_unfiltered, vprintf_filtered): Update.
2815         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2816         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2817         disallow_ui_out_field>: New constants.
2818         (enum class field_kind): New.
2819         (struct base_field_s, struct signed_field_s): New.
2820         (signed_field): New function.
2821         (struct string_field_s): New.
2822         (string_field): New function.
2823         (struct styled_string_s): New.
2824         (styled_string): New function.
2825         (class ui_out) <message>: Add comment.
2826         <vmessage, call_do_message>: New methods.
2827         <do_message>: Add style parameter.
2828         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2829         methods.
2830         (ui_out::message): Rewrite.
2831         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2832         parameter.
2833         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2834         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2835         gdb_extensions parameter.
2836         (class format_piece): Add parameter to constructor.
2837         (n_int_args): New field.
2838         * gdbsupport/format.c (format_pieces::format_pieces): Add
2839         gdb_extensions parameter.  Handle '*'.
2840         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2841         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2842         vfprintf_styled_no_gdbfmt.
2843         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2844         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2845         unfiltered output.
2846         * ui-style.h (struct ui_file_style) <ptr>: New method.
2847
2848 2019-10-01  Tom Tromey  <tom@tromey.com>
2849
2850         * unittests/format_pieces-selftests.c: Update.  Add final format.
2851         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2852         empty literal pieces.
2853
2854 2019-10-01  Tom Tromey  <tom@tromey.com>
2855
2856         * ui-out.h (enum class ui_out_style_kind): Remove.
2857         (class ui_out) <field_string, field_stsream, do_field_string>:
2858         Change type of "style".
2859         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2860         (ui_out::field_string): Update.
2861         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2862         of "style".
2863         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2864         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2865         * stack.c (print_frame_arg, print_frame_info, print_frame):
2866         Update.
2867         * source.c (print_source_lines_base): Update.
2868         * solib.c (info_sharedlibrary_command): Update.
2869         * skip.c (info_skip_command): Update.
2870         * record-btrace.c (btrace_call_history_src_line)
2871         (btrace_call_history): Update.
2872         * python/py-framefilter.c (py_print_frame): Update.
2873         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2874         "style".
2875         * mi/mi-out.c (mi_ui_out::do_table_header)
2876         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2877         (mi_ui_out::do_field_string): Update.
2878         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2879         Update.
2880         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2881         "style".
2882         * cli-out.c (cli_ui_out::do_table_header)
2883         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2884         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2885         (cli_ui_out::do_field_fmt): Update.
2886         * breakpoint.c (print_breakpoint_location): Update.
2887         (update_static_tracepoint): Update.
2888
2889 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2890
2891         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2892         conversion of gdb_datadir.
2893         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2894         remove not needed c_str ().
2895
2896 2019-09-30  Ali Tamur <tamur@google.com>
2897
2898         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2899         (dwarf2_string_attr): Likewise.
2900
2901 2019-09-30  Ali Tamur <tamur@google.com>
2902
2903         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2904         (process_full_type_unit): Likewise.
2905         (dump_die_shallow): Likewise.
2906         (cu_debug_loc_section): Likewise.
2907
2908 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2909
2910         * minsyms.c (compare_minimal_symbols): Rename to...
2911         (minimal_symbol_is_less_than): ...this, and adjust to STL
2912         conventions (return bool, take arguments as references)
2913         (minimal_symbol_reader::install): Call std::sort instead
2914         of qsort.
2915
2916 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2917
2918         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2919         hash and why.
2920         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2921         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2922
2923 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2924
2925         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2926         * psympriv.h (add_psymbol_to_list): Move comment here and update
2927         it.
2928
2929 2019-09-29  Tom de Vries  <tdevries@suse.de>
2930
2931         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2932         Use $tmpdir/$(basename "$output_file").dwz instead of
2933         "${output_file}.dwz".
2934
2935 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2936
2937         PR gdb/25045
2938         * hppa-linux-nat.c: Include gdbarch.h.
2939
2940 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2941
2942         * blockframe.c (find_pc_partial_function): Change return type to bool.
2943         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2944         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2945         (stub_gnu_ifunc_resolve_name): Likewise.
2946         * symtab.c (compare_filenames_for_search): Likewise.
2947         (compare_glob_filenames_for_search): Likewise.
2948         (matching_obj_sections): Likewise.
2949         (symbol_matches_domain): Likewise.
2950         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2951         (find_line_pc): Change return type to bool.
2952         (find_line_pc_range): Likewise.
2953         (producer_is_realview): Likewise.
2954         * symtab.h (symbol_matches_domain): Likewise.
2955         (find_pc_partial_function): Likewise.
2956         (find_pc_line_pc_range): Likewise.
2957         (in_gnu_ifunc_stub): Likewise.
2958         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2959         (find_line_pc): Likewise.
2960         (find_line_pc_range): Likewise.
2961         (matching_obj_sections): Likewise.
2962         (find_line_symtab): Change out parameter to bool.
2963         (producer_is_realview): Change return type to bool.
2964         (compare_filenames_for_search): Likewise.
2965         (compare_glob_filenames_for_search): Likewise.
2966
2967 2019-09-26  Tom Tromey  <tom@tromey.com>
2968
2969         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2970         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2971         * gdb_usleep.h: Remove.
2972         * gdb_usleep.c: Remove.
2973         * utils.c: Don't include gdb_usleep.h.
2974
2975 2019-09-26  Tom Tromey  <tromey@adacore.com>
2976
2977         * python/py-type.c (type_to_type_object): Call check_typedef
2978         for stub types.
2979
2980 2019-09-26  Tom Tromey  <tom@tromey.com>
2981
2982         * utils.h (initialize_utils): Don't declare.
2983         * top.c (gdb_init): Don't call initialize_utils.
2984         * utils.c (initialize_utils): Remove.  Move contents...
2985         (_initialize_utils): ... here.
2986
2987 2019-09-25  Tom Tromey  <tom@tromey.com>
2988
2989         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2990         * utils.h (make_hex_string): Don't declare.
2991         * utils.c (make_hex_string): Remove.
2992
2993 2019-09-24  Tom de Vries  <tdevries@suse.de>
2994
2995         PR gdb/23815
2996         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2997         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2998
2999 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3000
3001         * NEWS: Mention new simulator port for PRU.
3002
3003 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3004
3005         * ada-exp.y (write_object_remaining): Update.
3006         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3007         and eliminate the static buffer.
3008         (ada_decode_symbol): Update.
3009         (ada_la_decode): Update.
3010         (ada_sniff_from_mangled_name): Update.
3011         (is_valid_name_for_wild_match): Update.
3012         (ada_lookup_name_info::matches): Update and simplify.
3013         (name_matches_regex): Update.
3014         (ada_add_global_exceptions): Update.
3015         * ada-lang.h (ada_decode): Update signature.
3016         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3017         * dwarf-index-write.c (debug_names::insert): Update.
3018
3019 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3020
3021         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3022         formatting.
3023
3024 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3025
3026         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3027         Change "nonzero" to "true" in documentation.
3028
3029 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3030
3031         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3032         (_initialize_darwin_solib): Don't set
3033         darwin_so_ops.lookup_lib_global_symbol.
3034         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3035         set_gdbarch_iterate_over_objfiles_in_search_order.
3036         (elf_lookup_lib_symbol): Rename to...
3037         (svr4_iterate_over_objfiles_in_search_order): this, and update
3038         to iterate semantics.
3039         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3040         * solib.c (solib_global_lookup): Remove.
3041         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3042         (solib_global_lookup): Remove.
3043         * symtab.c (lookup_global_or_static_symbol): Remove call to
3044         solib_global_lookup.
3045
3046 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3047
3048         * NEWS: Move entries about default MI version now being
3049         version 3, and about the GDB/MI fix for multi-location
3050         breakpoints to the "since GDB 8.3" section.
3051
3052 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3053
3054         GDB 8.3.1 released.
3055
3056 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3057
3058         * NEWS: Mention that Cell/B.E. debugging support was removed.
3059         * MAINTAINERS: Remove spu target.
3060
3061         * config/djgpp/fnchange.lst: Remove entries for removed files.
3062
3063         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3064         spu-multiarch.o, and spu-tdep.o.
3065         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3066         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3067         spu-multiarch.c, and spu-tdep.c.
3068         * spu-linux-nat.c: Remove file.
3069         * spu-multiarch.c: Remove file.
3070         * spu-tdep.c: Remove file.
3071         * spu-tdep.h: Remove file.
3072         * solib-spu.c: Remove file.
3073         * solib-spu.h: Remove file.
3074
3075         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3076         * configure.nat (spu-linux): Remove.
3077         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3078         solib-multiarch.o from gdb_target_obs.
3079         (spu*-*-*): Remove.
3080
3081         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3082         feature flag.
3083         (ppc_linux_no_features): Update.
3084         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3085         Cell/B.E. support.
3086         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3087         (tdesc_powerpc_cell64l): Likewise.
3088         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3089         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3090         Cell/B.E. support.
3091         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3092         Do not include "features/rs6000/powerpc-cell32l.c" or
3093         "features/rs6000/powerpc-cell64l.c".
3094         (ppc_linux_spu_section): Remove.
3095         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3096         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3097         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3098         (ppc_linux_spe_context_lookup): Remove.
3099         (ppc_linux_spe_context_inferior_created): Remove.
3100         (ppc_linux_spe_context_solib_loaded): Remove.
3101         (ppc_linux_spe_context_solib_unloaded): Remove.
3102         (ppc_linux_spe_context): Remove.
3103         (struct ppu2spu_cache): Remove.
3104         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3105         (struct ppu2spu_data): Remove.
3106         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3107         ppu2spu_unwind): Remove.
3108         (ppc_linux_init_abi): Remove Cell/B.E. support.
3109         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3110
3111         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3112         (rs6000/powerpc-cell64l-expedite): Likewise
3113         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3114         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3115         rs6000/powerpc-cell64l.xml.
3116         * features/rs6000/powerpc-cell32l.xml: Remove.
3117         * features/rs6000/powerpc-cell64l.xml: Likewise.
3118         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3119         * features/rs6000/powerpc-cell64l.c: Likewise.
3120         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3121         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3122         * regformats/reg-spu.dat: Remove.
3123
3124         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3125         * corelow.c (struct spuid_list): Remove.
3126         (add_to_spuid_list): Remove.
3127         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3128         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3129         (remote_protocol_features): Remove associated entries.
3130         (_initialize_remote): No longer initialize them.
3131         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3132         * linux-nat.c (SPUFS_MAGIC): Remove.
3133         (linux_proc_xfer_spu): Remove.
3134         (spu_enumerate_spu_ids): Remove.
3135         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3136         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3137         (linux_make_corefile_notes): No longer call it.
3138
3139         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3140         (cooked_write_test): Likewise.
3141
3142 2019-09-20  Tom Tromey  <tom@tromey.com>
3143
3144         * NEWS: Mention case-sensitivity of TUI commands.
3145         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3146         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3147         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3148
3149 2019-09-20  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-source.c (tui_source_window::set_contents): Use
3152         make_unique_xstrdup.
3153         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3154         make_unique_xstrdup.
3155
3156 2019-09-20  Tom Tromey  <tom@tromey.com>
3157
3158         * tui/tui-data.c: Remove separator comments.
3159         * tui/tui-layout.c: Remove separator comments.
3160         * tui/tui-win.c: Remove separator comments.
3161         * tui/tui-wingeneral.c: Remove separator comments.
3162
3163 2019-09-20  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui.h (strcat_to_buf): Don't declare.
3166         * tui/tui.c (strcat_to_buf): Remove.
3167
3168 2019-09-20  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3171         from "fullname".
3172         * tui/tui-source.c (tui_source_window::set_contents)
3173         (tui_source_window::location_matches_p)
3174         (tui_source_window::maybe_update): Update.
3175
3176 2019-09-20  Tom Tromey  <tom@tromey.com>
3177
3178         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3179         Update.
3180         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3181         prefix.
3182         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3183         (tui_data_window::line_from_reg_element_no)
3184         (tui_data_window::first_reg_element_no_inline)
3185         (tui_data_window::show_registers)
3186         (tui_data_window::show_register_group)
3187         (tui_data_window::display_registers_from)
3188         (tui_data_window::display_registers_from_line)
3189         (tui_data_window::first_data_item_displayed)
3190         (tui_data_window::delete_data_content_windows)
3191         (tui_data_window::erase_data_content)
3192         (tui_data_window::do_scroll_vertical)
3193         (tui_data_window::refresh_window)
3194         (tui_data_window::check_register_values): Update.
3195
3196 2019-09-20  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3199         (struct tui_locator_window) <full_name, proc_name>: Now
3200         std::string.
3201         * tui/tui-stack.c (tui_locator_window::make_status_line)
3202         (tui_locator_window::set_locator_fullname)
3203         (tui_locator_window::set_locator_info): Update.
3204         * tui/tui-source.c (tui_source_window::set_contents)
3205         (tui_source_window::showing_source_p): Update.
3206
3207 2019-09-20  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3210         Don't call tui_locator_win_info_ptr.
3211
3212 2019-09-20  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3215
3216 2019-09-20  Tom Tromey  <tom@tromey.com>
3217
3218         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3219         height for locator.
3220         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3221         * tui/tui-layout.c (show_source_disasm_command, show_data)
3222         (show_source_or_disasm_and_command): Use 1 as height for locator.
3223
3224 2019-09-20  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui.c (tui_enable): Update.
3227         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3228         Update.
3229         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3230         Update.
3231         * tui/tui-data.c (win_resized): Now bool.
3232         (tui_win_resized): Return bool.
3233         (tui_set_win_resized_to): Accept a bool.
3234
3235 2019-09-20  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3238         Change type of "refresh_values_only".
3239         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3240         type of "refresh_values_only".
3241
3242 2019-09-20  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3245         std::string.
3246         (tui_disassemble): Add "pos" parameter.
3247         (tui_disasm_window::set_contents): Simplify.
3248
3249 2019-09-20  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-winsource.h (struct tui_source_window_base)
3252         <show_source_content>: Now private.
3253         * tui/tui-winsource.c
3254         (tui_source_window_base::show_source_content): Don't handle empty
3255         content case.
3256
3257 2019-09-20  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-layout.c (show_source_disasm_command)
3260         (show_source_or_disasm_and_command): Don't call
3261         show_source_content.
3262
3263 2019-09-20  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3266         Declare.
3267         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3268         from tui_make_status_line.
3269         (tui_locator_window::rerender): Update.
3270
3271 2019-09-20  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3274         (tui_locator_window::rerender): Update.
3275
3276 2019-09-20  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-winsource.h (struct tui_source_window_base)
3279         <~tui_source_window_base>: Don't declare.
3280         <fullname>: Remove.
3281         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3282         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3283         member.
3284         * tui/tui-source.c (tui_source_window::set_contents): Update.
3285         (tui_source_window::location_matches_p)
3286         (tui_source_window::maybe_update): Update.
3287
3288 2019-09-20  Tom Tromey  <tom@tromey.com>
3289
3290         * tui/tui-winsource.h (~tui_source_element): Remove.
3291         (tui_source_element): Update.
3292         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3293         * tui/tui-winsource.c (tui_show_source_line): Update.
3294         * tui/tui-source.c (tui_source_window::set_contents): Update.
3295         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3296
3297 2019-09-20  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3300         declare.
3301         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3302         tui_clear_source_windows_detail.
3303         * tui/tui-winsource.h (struct tui_source_window_base)
3304         <clear_detail>: Don't declare.
3305         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3306         Remove.
3307         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3308
3309 2019-09-20  Tom Tromey  <tromey@adacore.com>
3310
3311         PR ada/24919:
3312         * block.c (contained_in): Fix final return value.
3313
3314 2019-09-20  Alan Modra  <amodra@gmail.com>
3315
3316         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3317         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3318         (read_indirect_string_from_dwz): Use bfd accessor.
3319         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3320         * machoread.c (macho_symfile_read_all_oso): Likewise.
3321         * solib.c (solib_bfd_open): Likewise.
3322
3323 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3324
3325         * eval.c: Move declaration of overload_resolution to...
3326         * value.h: ...here.
3327
3328 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3329
3330         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3331         * arm-linux-tdep.c: Likewise.
3332         * arm-nbsd-nat.c: Likewise.
3333         * arm-tdep.h: Declare arm_apcs_32.
3334         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3335
3336 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3337
3338         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3339         * dwarf2read.h: Declare dwarf_always_disassemble.
3340
3341 2019-09-19  Tom de Vries  <tdevries@suse.de>
3342
3343         PR gdb/25009
3344         * source-cache.c (source_cache::ensure): Catch exception thrown during
3345         construction of the highlighter.
3346
3347 2019-09-18  Alan Modra  <amodra@gmail.com>
3348
3349         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3350         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3351         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3352         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3353         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3354         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3355         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3356         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3357         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3358         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3359         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3360         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3361         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3362         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3363         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3364         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3365         * mi/mi-interp.c: Update throughout for bfd section macro and
3366         function changes.
3367         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3368         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3369
3370 2019-09-18  Tom Tromey  <tom@tromey.com>
3371
3372         * NEWS: Add entry.
3373         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3374         call rl_initialize.
3375         (tui_enable): Do not call rl_initialize.
3376
3377 2019-09-18  Christian Groessler  <chris@groessler.org>
3378
3379         * alpha-linux-nat.c: Include gdbarch.h.
3380
3381 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3382
3383         * ui-file.c: Include cli/cli-style.h.
3384         (term_cli_styling): Remove cli_styling declaration.
3385
3386 2019-09-18  Alan Modra  <amodra@gmail.com>
3387
3388         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3389         to bfd_asymbol_section.
3390
3391 2019-09-18  Alan Modra  <amodra@gmail.com>
3392
3393         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3394         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3395         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3396
3397 2019-09-18  Alan Modra  <amodra@gmail.com>
3398
3399         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3400         * spu-linux-nat.c (spu_bfd_open): Likewise.
3401
3402 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3403
3404         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3405         to bool to match definition in dwarf2read.c.
3406
3407 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3408
3409         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3410         (print_signatures): Likewise.
3411         (trust_pad_over_xvs): Likewise.
3412         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3413         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3414         * arm-linux-nat.c (arm_apcs_32): Likewise.
3415         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3416         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3417         * arm-tdep.c (arm_debug): Likewise.
3418         (arm_apcs_32): Likewise.
3419         * auto-load.c (debug_auto_load): Likewise.
3420         (auto_load_gdb_scripts): Likewise.
3421         (global_auto_load): Likewise.
3422         (auto_load_local_gdbinit): Likewise.
3423         (auto_load_local_gdbinit_loaded): Likewise.
3424         * auto-load.h (global_auto_load): Likewise.
3425         (auto_load_local_gdbinit): Likewise.
3426         (auto_load_local_gdbinit_loaded): Likewise.
3427         * breakpoint.c (disconnected_dprintf): Likewise.
3428         (breakpoint_proceeded): Likewise.
3429         (automatic_hardware_breakpoints): Likewise.
3430         (always_inserted_mode): Likewise.
3431         (target_exact_watchpoints): Likewise.
3432         (_initialize_breakpoint): Update.
3433         * breakpoint.h (target_exact_watchpoints): Change to bool.
3434         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3435         * cli/cli-cmds.c (trace_commands): Likewise.
3436         * cli/cli-cmds.h (trace_commands): Likewise.
3437         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3438         to bool*.
3439         * cli/cli-logging.c (logging_overwrite): Change to bool.
3440         (logging_redirect): Likewise.
3441         (debug_redirect): Likewise.
3442         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3443         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3444         to bool.
3445         <boolean_option_def>: Update.
3446         (struct flag_option_def): Change default type of Context to bool
3447         from int.
3448         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3449         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3450         (get_setshow_command_value_string): Likewise.
3451         * cli/cli-style.c (cli_styling): Change to bool.
3452         (source_styling): Likewise.
3453         * cli/cli-style.h (source_styling): Likewise.
3454         (cli_styling): Likewise.
3455         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3456         to bool.
3457         * command.h (var_types): Update comment.
3458         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3459         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3460         bool.
3461         (debug_compile_cplus_scopes): Likewise.
3462         * compile/compile-internal.h (compile_debug): Likewise.
3463         * compile/compile.c (compile_debug): Likewise.
3464         (struct compile_options) <raw>: Likewise.
3465         * cp-support.c (catch_demangler_crashes): Likewise.
3466         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3467         (usr_cmd_cris_dwarf2_cfi): Likewise.
3468         * csky-tdep.c (csky_debug): Likewise.
3469         * darwin-nat.c (enable_mach_exceptions): Likewise.
3470         * dcache.c (dcache_enabled_p): Likewise.
3471         * defs.h (info_verbose): Likewise.
3472         * demangle.c (demangle): Likewise.
3473         (asm_demangle): Likewise.
3474         * dwarf-index-cache.c (debug_index_cache): Likewise.
3475         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3476         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3477         * dwarf2read.c (check_physname): Likewise.
3478         (use_deprecated_index_sections): Likewise.
3479         (dwarf_always_disassemble): Likewise.
3480         * eval.c (overload_resolution): Likewise.
3481         * event-top.c (set_editing_cmd_var): Likewise.
3482         (exec_done_display_p): Likewise.
3483         * event-top.h (set_editing_cmd_var): Likewise.
3484         (exec_done_display_p): Likewise.
3485         * exec.c (write_files): Likewise.
3486         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3487         (debug_fbsd_nat): Likewise.
3488         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3489         Likewise.
3490         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3491         <backtrace_past_entry> Likewise.
3492         * gdb-demangle.h (demangle): Likewise.
3493         (asm_demangle): Likewise.
3494         * gdb_bfd.c (bfd_sharing): Likewise.
3495         * gdbcore.h (write_files): Likewise.
3496         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3497         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3498         * gdbthread.h (print_thread_events): Likewise.
3499         * gdbtypes.c (opaque_type_resolution): Likewise.
3500         (strict_type_checking): Likewise.
3501         * gnu-nat.c (gnu_debug_flag): Likewise.
3502         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3503         * guile/scm-param.c (pascm_variable): Add boolval.
3504         (add_setshow_generic): Update.
3505         (pascm_param_value): Update.
3506         (pascm_set_param_value_x): Update.
3507         * hppa-tdep.c (hppa_debug): Change to bool..
3508         * infcall.c (may_call_functions_p): Likewise.
3509         (coerce_float_to_double_p): Likewise.
3510         (unwind_on_signal_p): Likewise.
3511         (unwind_on_terminating_exception_p): Likewise.
3512         * infcmd.c (startup_with_shell): Likewise.
3513         * inferior.c (print_inferior_events): Likewise.
3514         * inferior.h (startup_with_shell): Likewise.
3515         (print_inferior_events): Likewise.
3516         * infrun.c (step_stop_if_no_debug): Likewise.
3517         (detach_fork): Likewise.
3518         (debug_displaced): Likewise.
3519         (disable_randomization): Likewise.
3520         (non_stop): Likewise.
3521         (non_stop_1): Likewise.
3522         (observer_mode): Likewise.
3523         (observer_mode_1): Likewise.
3524         (set_observer_mode): Update.
3525         (sched_multi): Change to bool.
3526         * infrun.h (debug_displaced): Likewise.
3527         (sched_multi): Likewise.
3528         (step_stop_if_no_debug): Likewise.
3529         (non_stop): Likewise.
3530         (disable_randomization): Likewise.
3531         * linux-tdep.c (use_coredump_filter): Likewise.
3532         (dump_excluded_mappings): Likewise.
3533         * linux-thread-db.c (auto_load_thread_db): Likewise.
3534         (check_thread_db_on_load): Likewise.
3535         * main.c (captured_main_1): Update.
3536         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3537         xx2_opt, boolean_opt>: Change to bool.
3538         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3539         * maint.c (maintenance_profile_p): Likewise.
3540         (per_command_time): Likewise.
3541         (per_command_space): Likewise.
3542         (per_command_symtab): Likewise.
3543         * memattr.c (inaccessible_by_default): Likewise.
3544         * mi/mi-main.c (mi_async): Likewise.
3545         (mi_async_1): Likewise.
3546         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3547         * nat/fork-inferior.h (startup_with_shell): Likewise.
3548         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3549         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3550         * nios2-tdep.c (nios2_debug): Likewise.
3551         * or1k-tdep.c (or1k_debug): Likewise.
3552         * parse.c (parser_debug): Likewise.
3553         * parser-defs.h (parser_debug): Likewise.
3554         * printcmd.c (print_symbol_filename): Likewise.
3555         * proc-api.c (procfs_trace): Likewise.
3556         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3557         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3558         (set_parameter_value): Update.
3559         (add_setshow_generic): Update.
3560         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3561         to bool*.
3562         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3563         int*.
3564         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3565         * record-btrace.c (record_btrace_target::store_registers): Update.
3566         * record-full.c (record_full_memory_query): Change to bool.
3567         (record_full_stop_at_limit): Likewise.
3568         * record-full.h (record_full_memory_query): Likewise.
3569         * remote-notif.c (notif_debug): Likewise.
3570         * remote-notif.h (notif_debug): Likewise.
3571         * remote.c (use_range_stepping): Likewise.
3572         (interrupt_on_connect): Likewise.
3573         (remote_break): Likewise.
3574         * ser-tcp.c (tcp_auto_retry): Likewise.
3575         * ser-unix.c (serial_hwflow): Likewise.
3576         * skip.c (debug_skip): Likewise.
3577         * solib-aix.c (solib_aix_debug): Likewise.
3578         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3579         (spu_auto_flush_cache_p): Likewise.
3580         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3581         Likewise.
3582         (struct info_print_options) <quiet>: Likewise.
3583         * symfile-debug.c (debug_symfile): Likewise.
3584         * symfile.c (auto_solib_add): Likewise.
3585         (separate_debug_file_debug): Likewise.
3586         * symfile.h (auto_solib_add): Likewise.
3587         (separate_debug_file_debug): Likewise.
3588         * symtab.c (basenames_may_differ): Likewise.
3589         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3590         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3591         (struct info_types_options) <quiet>: Likewise.
3592         * symtab.h (demangle): Likewise.
3593         (basenames_may_differ): Likewise.
3594         * target-dcache.c (stack_cache_enabled_1): Likewise.
3595         (code_cache_enabled_1): Likewise.
3596         * target.c (trust_readonly): Likewise.
3597         (may_write_registers): Likewise.
3598         (may_write_memory): Likewise.
3599         (may_insert_breakpoints): Likewise.
3600         (may_insert_tracepoints): Likewise.
3601         (may_insert_fast_tracepoints): Likewise.
3602         (may_stop): Likewise.
3603         (auto_connect_native_target): Likewise.
3604         (target_stop_and_wait): Update.
3605         (target_async_permitted): Change to bool.
3606         (target_async_permitted_1): Likewise.
3607         (may_write_registers_1): Likewise.
3608         (may_write_memory_1): Likewise.
3609         (may_insert_breakpoints_1): Likewise.
3610         (may_insert_tracepoints_1): Likewise.
3611         (may_insert_fast_tracepoints_1): Likewise.
3612         (may_stop_1): Likewise.
3613         * target.h (target_async_permitted): Likewise.
3614         (may_write_registers): Likewise.
3615         (may_write_memory): Likewise.
3616         (may_insert_breakpoints): Likewise.
3617         (may_insert_tracepoints): Likewise.
3618         (may_insert_fast_tracepoints): Likewise.
3619         (may_stop): Likewise.
3620         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3621         (make_thread_apply_all_options_def_group): Change argument from int*
3622         to bool*.
3623         (thread_apply_all_command): Update.
3624         (print_thread_events): Change to bool.
3625         * top.c (confirm): Likewise.
3626         (command_editing_p): Likewise.
3627         (history_expansion_p): Likewise.
3628         (write_history_p): Likewise.
3629         (info_verbose): Likewise.
3630         * top.h (confirm): Likewise.
3631         (history_expansion_p): Likewise.
3632         * tracepoint.c (disconnected_tracing): Likewise.
3633         (circular_trace_buffer): Likewise.
3634         * typeprint.c (print_methods): Likewise.
3635         (print_typedefs): Likewise.
3636         * utils.c (debug_timestamp): Likewise.
3637         (sevenbit_strings): Likewise.
3638         (pagination_enabled): Likewise.
3639         * utils.h (sevenbit_strings): Likewise.
3640         (pagination_enabled): Likewise.
3641         * valops.c (overload_resolution): Likewise.
3642         * valprint.h (struct value_print_options) <prettyformat_arrays,
3643         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3644         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3645         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3646         Likewise.
3647         * windows-nat.c (new_console): Likewise.
3648         (cygwin_exceptions): Likewise.
3649         (new_group): Likewise.
3650         (debug_exec): Likewise.
3651         (debug_events): Likewise.
3652         (debug_memory): Likewise.
3653         (debug_exceptions): Likewise.
3654         (useshell): Likewise.
3655         * windows-tdep.c (maint_display_all_tib): Likewise.
3656         * xml-support.c (debug_xml): Likewise.
3657
3658 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3659
3660         * source.c (prepare_path_for_appending): New function.
3661         (openp): Make use of new function.
3662         (find_and_open_source): Search for the compilation directory and
3663         source file as a relative path beneath the directory search path.
3664
3665 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * source-cache.c (source_cache::get_line_charpos): Catch
3668         exceptions and return false, this matches the behaviour documented
3669         in the header file.
3670
3671 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3672
3673         * ada-tasks.c (info_task): Remove quoting of the task's name.
3674
3675 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3676
3677         * symfile.c (auto_solib_add): Replace comment with a reference
3678         to the header file.
3679
3680 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3681
3682         * NEWS: Mention that gdb can now be compiled with Python 3
3683         on Windows.
3684
3685 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3686
3687         * maint.c (maint_print_section_data::maint_print_section_data):
3688         Force use of 'float log10 (float)' by casting the argument to
3689         float.
3690
3691 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * maint.c: Add 'cmath' include.
3694         (struct maint_print_section_data): New structure.
3695         (print_section_index): New function.
3696         (print_bfd_section_info): Add header comment, small whitespace
3697         cleanup, and update to call new print_section_index function.
3698         (print_objfile_section_info): Likewise.
3699         (maint_obj_section_from_bfd_section): New function.
3700         (print_bfd_section_info_maybe_relocated): New function.
3701         (maintenance_info_sections): Add header comment, always use
3702         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3703
3704 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3707         inner scope, add check that the objfile has psymtabs before
3708         checking psymtabs_addrmap.
3709         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3710
3711 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3712
3713         * NEWS: Announce that Ada task names are now shown at more places,
3714         and between quotes (except in info task output).
3715         * gdb/ada-tasks.c (task_to_str): New function.
3716         (display_current_task_id): Call task_to_str.
3717         (task_command_1): Likewise.
3718         (print_ada_task_info): In non-mi mode, Properly align headers and data
3719         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3720
3721 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3722
3723         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3724         prstatus.pr_lwp.pr_info instead of making it up.
3725
3726 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3727
3728         * auto-load.c (auto_load_expand_dir_vars): Update.
3729         * defs.h (gdb_datadir): Change to std::string.
3730         (python_libdir): Likewise.
3731         (relocate_gdb_directory): Change return type to std::string.
3732         * guile/guile.c (gdbscm_data_directory): Update.
3733         (initialize_scheme_side): Update.
3734         * jit.c (jit_reader_dir): Change to std::string.
3735         (jit_reader_load_command): Update.
3736         * main.c (gdb_datadir): Change to std::string.
3737         (python_libdir): Likewise.
3738         (set_gdb_data_directory): Update.
3739         (relocate_path): Change to return std::string.
3740         (relocate_gdb_directory): Change to return std::string.
3741         (relocate_gdbinit_path_maybe_in_datadir): Update.
3742         (captured_main_1): Update.
3743         * python/python.c (do_start_initialization): Update.
3744         * top.c (show_gdb_datadir): Update.
3745         * xml-syscall.c (xml_init_syscalls_info): Update.
3746         (init_syscalls_info): Update.
3747
3748 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3749
3750         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3751         out of get_init_files.
3752         (get_init_files): Update.
3753
3754 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3755
3756         * main.c (get_init_files): Change to use std::string.
3757         (captured_main_1): Update.
3758         (print_gdb_help): Update.
3759
3760 2019-09-11  Ali Tamur  <tamur@google.com>
3761
3762         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3763         implementation.
3764
3765 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3766
3767         * dbxread.c (read_dbx_symtab): Update.
3768         * dwarf2read.c (load_partial_dies): Update.
3769         * mdebugread.c (parse_partial_symbols): Update.
3770         (handle_psymbol_enumerators): Update.
3771         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3772         * psymtab.c (add_psymbol_to_bcache): Likewise.
3773         (add_psymbol_to_list): Likewise.
3774         * symtab.c (symbol_set_names): Likewise.
3775         * symtab.h (symbol_set_names): Likewise.
3776         * xcoffread.c (scan_xcoff_symtab): Update.
3777
3778 2019-09-11  Tom Tromey  <tom@tromey.com>
3779
3780         * symfile-mem.c (symbol_file_add_from_memory): Use
3781         bfd_set_filename.
3782         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3783         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3784
3785 2019-09-10  Tom Tromey  <tromey@adacore.com>
3786
3787         * dwarf-index-write.c (write_psymbols): Extend error message.
3788         (debug_names::insert): Add Ada code.
3789         (debug_names::write_psymbols): Remove Ada check.
3790         (debug_names) <m_string_obstack>: New member.
3791         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3792         (gdb_index_symbol_name_matcher::matches): Remove.
3793         (mapped_index_base::find_name_components_bounds): Add "lang"
3794         parameter.
3795         (mapped_index_base::build_name_components): Also split names
3796         according to Ada syntax.
3797         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3798         type of "match_callback".
3799         (check_match, check_find_bounds_finds)
3800         (dw2_expand_symtabs_matching): Update.
3801         (dw2_debug_names_iterator): Add new constructor.
3802         (dw2_debug_names_map_matching_symbols): New function.
3803         (dw2_debug_names_expand_symtabs_matching): Update.
3804         (dwarf2_debug_names_functions): Use
3805         dw2_debug_names_map_matching_symbols.
3806
3807 2019-09-10  Tom Tromey  <tromey@adacore.com>
3808
3809         * dwarf2read.c (dw2_get_file_names_reader): Add the
3810         CU's file name to the results.
3811
3812 2019-09-10  Tom Tromey  <tromey@adacore.com>
3813
3814         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3815         map_matching_symbols.  Update.
3816         * dwarf2read.c (dw2_map_matching_symbols): Update.
3817         * psymtab.c (match_partial_symbol): Change type; update.
3818         (psym_map_matching_symbols): Likewise.
3819         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3820         type; update.
3821         * symfile.h (struct quick_symbol_functions)
3822         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3823         Remove "match".
3824
3825 2019-09-10  Tom Tromey  <tromey@adacore.com>
3826
3827         * psymtab.c (map_block): Remove.
3828         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3829         * symtab.c (iterate_over_symbols_terminated): New function.
3830         * symtab.c (iterate_over_symbols_terminated): Declare.
3831
3832 2019-09-10  Tom Tromey  <tromey@adacore.com>
3833
3834         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3835         * language.h (struct language_defn) <la_iterate_over_symbols>:
3836         Return bool.
3837         * symtab.c (iterate_over_symbols): Return bool.
3838         * symtab.h (iterate_over_symbols): Return bool.
3839
3840 2019-09-10  Tom Tromey  <tromey@adacore.com>
3841
3842         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3843         (add_nonlocal_symbols): Update.
3844         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3845         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3846         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3847         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3848         Change type of "callback".  Remove "data".
3849
3850
3851 2019-09-09  Ali Tamur  <tamur@google.com>
3852
3853         * dwarf2read.c (comp_unit_head): Update comment.
3854         (dwarf2_dwo_name): New function declaration.
3855         (dwarf_unit_type_name): New function declaration.
3856         (read_comp_unit_head): Add support for new compilation units,
3857         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3858         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3859         (currently named as "signature") in their header. Also clarify error
3860         messages.
3861         (lookup_dwo_id): New function. Returns the dwo id of the given
3862         compile unit.
3863         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3864         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3865         functions.
3866         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3867         (dwarf2_dwo_name): Get the dwo name if present.
3868         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3869         purposes.
3870
3871 2019-09-09  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3874
3875 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3876
3877         * python/python.c (do_start_initialization): Make progname_copy static,
3878         to avoid a leak report.
3879
3880 2019-09-08  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3883
3884 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3885
3886         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3887         Change type to gdb::optional<block_enum>.
3888         (dw2_symtab_iter_init): Change block_index parameter type
3889         to gdb::optional<block_enum>.
3890         (dw2_lookup_symbol): Change block_index parameter
3891         type to block_enum.c
3892         (dw2_debug_names_lookup_symbol): Likewise.
3893         * psymtab.c (psym_lookup_symbol): Likewise.
3894         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3895         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3896         Likewise.
3897
3898 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3899
3900         * defs.h (relocate_gdb_directory): Change int to bool in
3901         signature and rename flag to relocatable.
3902         * main.c (relocate_path): Likewise.
3903         (relocate_gdb_directory): Likewise.
3904
3905 2019-09-06  Alan Modra  <amodra@gmail.com>
3906
3907         * coffread.c (coff_symfile_read): Constify filename variable.
3908         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3909         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3910         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3911         * solib.c (reload_shared_libraries_1): Likewise.
3912         * symfile.c (reread_symbols): Likewise.
3913         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3914         * solib-darwin.c (darwin_bfd_open): Likewise.
3915         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3916
3917 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3918
3919         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3920         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3921
3922 2019-09-03  Tom Tromey  <tromey@adacore.com>
3923
3924         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3925         types.
3926         (has_negatives): Unbias a range type bound.
3927         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3928         * gdbtypes.c (operator==): Handle new field.
3929         (create_range_type): Add "bias" parameter.
3930         (create_static_range_type, resolve_dynamic_range): Update.
3931         * gdbtypes.h (struct range_bounds) <bias>: New member.
3932         (create_range_type): Add bias parameter.
3933         * printcmd.c (print_scalar_formatted): Unbias range types.
3934         * value.c (unpack_long): Unbias range types.
3935         (pack_long): Bias range types.
3936
3937 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3938
3939         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3940         probe arguments.
3941
3942 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3943
3944         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3945         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3946         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3947         (compile_probe_arg): Likewise.
3948         * probe.h (get_argument_count): Likewise.
3949         * solib-svr4.c (solib_event_probe_action): Likewise.
3950         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3951
3952 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3953
3954         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3955         code to here...
3956         (svr4_create_solib_event_breakpoints): ...from here.
3957
3958 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3959
3960         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3961         suffix from warning message.
3962
3963 2019-08-30  Tom Tromey  <tom@tromey.com>
3964
3965         * tui/tui-winsource.h (struct tui_source_window_base)
3966         <refresh_all>: Don't declare.
3967         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3968         Remove.
3969         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3970         tui_show_locator_content.
3971         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3972         declare.
3973         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3974         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3975         declare.
3976
3977 2019-08-30  Tom Tromey  <tom@tromey.com>
3978
3979         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3980
3981 2019-08-30  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3984         Remove unnecessary forward declarations.
3985
3986 2019-08-30  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3989         rerender.
3990         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3991         tui_show_locator_content.
3992
3993 2019-08-30  Tom Tromey  <tom@tromey.com>
3994
3995         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3996         (tui_locator_window::rerender): Rewrite using body of previous
3997         tui_show_locator_content.
3998
3999 2019-08-30  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4002         set_locator_fullname>: New methods.
4003         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4004         Rename from tui_set_locator_fullname.
4005         (tui_locator_window::set_locator_info): Rename from
4006         tui_set_locator_info.  Return bool.
4007         (tui_update_locator_fullname, tui_show_frame_info): Update.
4008
4009 2019-08-30  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4012
4013 2019-08-30  Tom Tromey  <tom@tromey.com>
4014
4015         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4016         call touchwin.
4017
4018 2019-08-30  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-wingeneral.c (box_win): Assume win_info and
4021         win_info->handle cannot be NULL.
4022
4023 2019-08-30  Tom Tromey  <tom@tromey.com>
4024
4025         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4026         refresh_window>: Declare.
4027         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4028         resize.
4029         (tui_data_item_window::rerender): Rename from
4030         tui_display_register.
4031         (tui_data_item_window::refresh_window): New method.
4032         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4033         no-op.
4034
4035 2019-08-30  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4038         regs_column_count, current_group>: Move later.  Now private.
4039         <get_current_group>: New method.
4040         * tui/tui-regs.c (tui_reg_command): Update.
4041         * tui/tui-layout.c (tui_set_layout): Update.
4042
4043 2019-08-30  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4046         (tui_data_window::rerender): Don't call
4047         check_and_display_highlight_if_needed.
4048         (tui_data_window::refresh_all): Remove call to
4049         erase_data_content.
4050
4051 2019-08-30  Tom Tromey  <tom@tromey.com>
4052
4053         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4054         (tui_data_window::display_registers_from)
4055         (tui_data_window::display_reg_element_at_line)
4056         (tui_data_window::display_registers_from_line): Remove checks of
4057         "empty".
4058
4059 2019-08-30  Tom Tromey  <tom@tromey.com>
4060
4061         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4062         Don't declare.
4063         * tui/tui-regs.c (tui_data_window::show_registers): Call
4064         rerender.
4065         (tui_data_window::rerender): Rename from display_all_data.
4066         (tui_data_window::rerender): Remove old implementation.
4067
4068 2019-08-30  Tom Tromey  <tom@tromey.com>
4069
4070         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4071         text.
4072         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4073
4074 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4075             Sergio Durigan Junior  <sergiodj@redhat.com>
4076
4077         PR win32/24284
4078         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4079
4080 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4081
4082         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4083         when searching for types.
4084
4085 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * f-lang.c (f_language_defn): Use f_print_typedef.
4088         * f-lang.h (f_print_typedef): Declare.
4089         * f-typeprint.c (f_print_typedef): Define.
4090
4091 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4092
4093         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4094
4095 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * cli/cli-utils.c (info_print_options_defs): Delete.
4098         (make_info_print_options_def_group): Delete.
4099         (extract_info_print_options): Delete.
4100         (info_print_command_completer): Delete.
4101         (info_print_args_help): Add extra parameter, and optionally
4102         include text about -n flag.
4103         * cli/cli-utils.h (struct info_print_options): Delete.
4104         (extract_info_print_options): Delete declaration.
4105         (info_print_command_completer): Delete declaration.
4106         (info_print_args_help): Add extra parameter, extend header
4107         comment.
4108         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4109         search_symbols.
4110         * stack.c (struct info_print_options): New type.
4111         (info_print_options_defs): New file scoped variable.
4112         (make_info_print_options_def_group): New static function.
4113         (info_print_command_completer): New static function.
4114         (info_locals_command): Update to use new local functions.
4115         (info_args_command): Likewise.
4116         (_initialize_stack): Add extra parameter to calls to
4117         info_print_args_help.
4118         * symtab.c (search_symbols): Add extra parameter, use this to
4119         possibly excluse non-debug symbols.
4120         (symtab_symbol_info): Add extra parameter, which is passed on to
4121         search_symbols.
4122         (struct info_print_options): New type.
4123         (info_print_options_defs): New file scoped variable.
4124         (make_info_print_options_def_group): New static function.
4125         (info_print_command_completer): New static function.
4126         (info_variables_command): Update to use local functions, and pass
4127         extra parameter through to symtab_symbol_info.
4128         (info_functions_command): Likewise.
4129         (info_types_command): Pass additional argument through to
4130         symtab_symbol_info.
4131         (rbreak_command): Pass extra argument to search_symbols.
4132         (_initialize_symtab): Add extra arguments for calls to
4133         info_print_args_help, and update help text for 'info variables',
4134         'whereis', and 'info functions' commands.
4135         * symtab.h (search_symbols): Add extra argument to declaration.
4136         * NEWS: Mention new flags.
4137
4138 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4139
4140         * symtab.c (lookup_static_symbol): Call the new function (and move
4141         it down to be next to lookup_global_symbol).
4142         (struct global_sym_lookup_data): Add block_enum member and rename to...
4143         (struct global_or_static_sym_lookup_data): ...this.
4144         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4145         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4146         (lookup_symbol_global_or_static_iterator_cb): ...this.
4147         (lookup_global_or_static_symbol): New function.
4148         (lookup_global_symbol): Call new function.
4149
4150 2019-08-26  Tom de Vries  <tdevries@suse.de>
4151
4152         PR c++/24852
4153         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4154         when pc_probe.prob == NULL.
4155
4156 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4157
4158         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4159         variable symbol_linkage to symbol_linkage_.
4160
4161 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4162
4163         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4164         represent whether the symbol is static, dynamic, or we don't
4165         know.
4166
4167 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4168
4169         * gdb/rx-tdep.c (rx_register_names): New.
4170         (rx_register_name): Delete.
4171         (rx_psw_type): Delete.
4172         (rx_fpsw_type): Delete.
4173         (rx_register_type): Delete.
4174         (rx_gdbarch_init): Convert target-descriptions.
4175         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4176         * gdb/features/Makefile: Add rx.xml.
4177         * gdb/features/rx.xml: New.
4178         * gdb/features/rx.c: Generated.
4179         * gdb/NEWS: Mention target description support.
4180
4181 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4182
4183         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4184         *slot_ptr.
4185
4186 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4187
4188         * configure.ac: Don't check for 'dlfcn.h' (moved to
4189         gdbsupport/common.m4).
4190         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4191         'gdbsupport/'.
4192         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4193         * compile/compile-c-support.c: Include
4194         'gdbsupport/gdb-dlfcn.h'.
4195         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4196         * gdb-dlfcn.c: Move to...
4197         * gdbsupport/gdb-dlfcn.c: ... here.
4198         * gdb-dlfcn.h: Move to...
4199         * gdbsupport/gdb-dlfcn.h: ... here.
4200
4201 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4202
4203         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4204         the offset field signed.
4205
4206 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4207
4208         * python/lib/gdb/__init__.py (_execute_file): New function.
4209         * python/python.c (python_run_simple_file): Call gdb._execute_file
4210         on Windows.
4211
4212 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4213
4214         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4215         all uses as this was never set to anything but a zero value.
4216
4217 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4218
4219         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4220
4221 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4222
4223         * tui/tui-data.h (tui_gen_win_info): Add an =default
4224         move constructor, required by some GCC versions.
4225
4226 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4227
4228         * go32-nat.c (go32_sysinfo): Add hygon_p.
4229
4230 2019-08-20  Tom Tromey  <tom@tromey.com>
4231
4232         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4233         line_from_reg_element_no, first_reg_element_no_inline,
4234         display_all_data, delete_data_content_windows,
4235         erase_data_content>: Now private.
4236
4237 2019-08-20  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4240         (tui_unhighlight_win, tui_highlight_win)
4241         (tui_win_info::make_window): Update.
4242         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4243
4244 2019-08-20  Tom Tromey  <tom@tromey.com>
4245
4246         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4247         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4248         (MAX_PID_WIDTH): Move to tui-stack.c.
4249         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4250         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4251         (MAX_PID_WIDTH): Move from tui-data.h.
4252
4253 2019-08-20  Tom Tromey  <tom@tromey.com>
4254
4255         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4256         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4257         (box_win): Update.
4258         (tui_gen_win_info::make_window): Rename from tui_make_window.
4259         (tui_win_info::make_window): New method.
4260         (tui_gen_win_info::make_visible): Update.
4261         * tui/tui-source.c (tui_source_window::set_contents): Update.
4262         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4263         (tui_data_window::display_registers_from): Update.
4264         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4265         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4266         Declare.
4267         <can_box>: Remove.
4268         <title>: Remove.
4269         (struct tui_win_info) <make_window>: Declare.
4270         <can_box>: Now virtual.
4271         <title>: New member.
4272         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4273         * tui/tui-command.c (tui_cmd_window::resize): Update.
4274
4275 2019-08-20  Tom Tromey  <tom@tromey.com>
4276
4277         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4278         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4279         (tui_data_window::check_register_values): Update.
4280
4281 2019-08-20  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-regs.h (struct tui_data_window): Use
4284         DISABLE_COPY_AND_ASSIGN.
4285         <regs_content>: Change type, removing unique_ptr.
4286         <tui_data_window>: Add move constructor.
4287         * tui/tui-regs.c (tui_data_window::show_registers)
4288         (tui_data_window::show_register_group)
4289         (tui_data_window::display_registers_from)
4290         (tui_data_window::display_registers_from)
4291         (tui_data_window::first_data_item_displayed)
4292         (tui_data_window::delete_data_content_windows)
4293         (tui_data_window::rerender, tui_data_window::refresh_window)
4294         (tui_data_window::check_register_values): Update.
4295
4296 2019-08-20  Tom Tromey  <tom@tromey.com>
4297
4298         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4299         show_register_group>: Declare.
4300         (tui_show_register_group): Don't declare.
4301         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4302         tui_show_registers.
4303         (tui_data_window::show_register_group): Rename from
4304         tui_show_register_group.
4305         (tui_data_window::check_register_values, tui_reg_command):
4306         Update.
4307         * tui/tui-layout.c (tui_set_layout): Update.
4308
4309 2019-08-20  Tom Tromey  <tom@tromey.com>
4310
4311         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4312         Declare.
4313         (tui_check_register_values): Don't declare.
4314         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4315         from tui_check_register_values.
4316         * tui/tui-hooks.c (tui_register_changed): Update.
4317
4318 2019-08-20  Tom Tromey  <tom@tromey.com>
4319
4320         * tui/tui-regs.c (tui_reg_layout): Move later.
4321         (tui_show_registers): Don't enable TUI mode or change layout.
4322
4323 2019-08-20  Tom Tromey  <tom@tromey.com>
4324
4325         * tui/tui-regs.h (struct tui_data_item_window)
4326         <~tui_data_item_window>: Remove.
4327         <content>: Now a unique_xmalloc_ptr.
4328         * tui/tui-regs.c (tui_register_format): Return a
4329         unique_xmalloc_ptr.
4330         (tui_get_register): Update.
4331         (~tui_data_item_window): Remove.
4332         (tui_data_window::display_registers_from, tui_display_register):
4333         Update.
4334         * tui/tui-io.h (tui_expand_tabs): Update.
4335         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4336         Remove "col" parameter.
4337
4338 2019-08-20  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4341         field.
4342         * tui/tui-regs.c (~tui_data_item_window): Update.
4343
4344 2019-08-20  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4347         earlier.
4348
4349 2019-08-20  Tom Tromey  <tom@tromey.com>
4350
4351         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4352
4353 2019-08-20  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-source.h (struct tui_source_window): Update.
4356         * tui/tui-regs.c (tui_show_registers): Update.
4357         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4358         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4359         (NO_REGS_STRING): Remove defines.
4360
4361 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4362
4363         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4364         unnecessary thread walk if remote doesn't support the packet.
4365
4366 2019-08-19  Tom Tromey  <tromey@adacore.com>
4367
4368         * python/py-value.c (value_has_field): Fix indentation.
4369
4370 2019-08-19  Tom Tromey  <tromey@adacore.com>
4371
4372         * printcmd.c (do_one_display, info_display_command): Update.
4373         * block.h (contained_in): Return bool.  Add allow_nested
4374         parameter.
4375         * block.c (contained_in): Return bool.  Add allow_nested
4376         parameter.
4377
4378 2019-08-19  Tom Tromey  <tom@tromey.com>
4379
4380         * configure: Rebuild.
4381         * configure.ac: Disallow the combination of -static-libstdc++ and
4382         source highlight.
4383         * source-cache.c (get_language_name): Handle rust.
4384         (source_cache::get_source_lines): Ignore highlighting exceptions.
4385
4386 2019-08-16  Tom Tromey  <tom@tromey.com>
4387
4388         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4389         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4390         (struct tui_source_window_base) <make_visible, refresh_window,
4391         resize>: Remove methods.
4392         <execution_info>: Remove field.
4393         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4394         (tui_show_source_line, tui_source_window_base)
4395         (~tui_source_window_base): Update.
4396         (tui_source_window_base::resize)
4397         (tui_source_window_base::make_visible)
4398         (tui_source_window_base::refresh_window): Remove.
4399         (tui_source_window_base::update_exec_info): Update.
4400         * tui/tui-source.c (tui_source_window::set_contents): Update.
4401         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4402
4403 2019-08-16  Tom Tromey  <tom@tromey.com>
4404
4405         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4406         deprecated_query_hook.
4407
4408 2019-08-16  Tom Tromey  <tom@tromey.com>
4409
4410         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4411         (tui_update_source_windows_with_line): Update.
4412         * tui/tui-source.h (struct tui_source_window)
4413         <show_symtab_source>: Declare.
4414         (tui_show_symtab_source): Don't declare.
4415         * tui/tui-source.c (tui_show_symtab_source): Rename from
4416         tui_show_symtab_source.
4417
4418 2019-08-16  Tom Tromey  <tom@tromey.com>
4419
4420         * tui/tui-winsource.h (struct tui_source_window_base)
4421         <set_contents>: Declare.
4422         * tui/tui-winsource.c
4423         (tui_source_window_base::update_source_window_as_is): Update.
4424         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4425         Declare.
4426         (tui_set_source_content): Don't declare.
4427         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4428         tui_set_source_content.
4429         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4430         Declare.
4431         (tui_set_disassem_content): Don't declare.
4432         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4433         tui_set_disassem_content.
4434
4435 2019-08-16  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui-winsource.h (struct tui_source_window_base)
4438         <update_breakpoint_info>: Declare.
4439         (tui_update_breakpoint_info): Don't declare.
4440         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4441         (tui_update_all_breakpoint_info): Update.
4442         (tui_source_window_base::update_breakpoint_info): Rename from
4443         tui_update_breakpoint_info.
4444         (tui_source_window_base::update_exec_info): Update.
4445
4446 2019-08-16  Tom Tromey  <tom@tromey.com>
4447
4448         * tui/tui-winsource.h (struct tui_source_window_base)
4449         <update_source_window>: Declare.
4450         (tui_update_source_window): Don't declare.
4451         * tui/tui-winsource.c
4452         (tui_source_window_base::update_source_window): Rename from
4453         tui_update_source_window.
4454         (tui_source_window_base::rerender): Update.
4455         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4456         * tui/tui-disasm.c (tui_show_disassem)
4457         (tui_show_disassem_and_update_source)
4458         (tui_disasm_window::maybe_update): Update.
4459
4460 2019-08-16  Tom Tromey  <tom@tromey.com>
4461
4462         * tui/tui-winsource.h (struct tui_source_window_base)
4463         <update_source_window_as_is>: Declare.
4464         (tui_update_source_window_as_is): Don't declare.
4465         * tui/tui-winsource.c (tui_update_source_window): Update
4466         (tui_source_window_base::update_source_window_as_is): Rename from
4467         tui_update_source_window_as_is.
4468         (tui_source_window_base::refill): Update.
4469         * tui/tui-source.c (tui_show_symtab_source): Update.
4470         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4471         Update.
4472
4473 2019-08-16  Tom Tromey  <tom@tromey.com>
4474
4475         * tui/tui-winsource.h (tui_update_source_window)
4476         (tui_update_source_window_as_is): Remove "noerror" parameter.
4477         * tui/tui-winsource.c (tui_update_source_window)
4478         (tui_update_source_window_as_is): Remove "noerror" parameter.
4479         (tui_update_source_windows_with_addr)
4480         (tui_update_source_windows_with_line)
4481         (tui_source_window_base::rerender)
4482         (tui_source_window_base::refill): Update.
4483         * tui/tui-source.h (tui_set_source_content)
4484         (tui_show_symtab_source): Remove "noerror" parameter.
4485         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4486         parameter.
4487         (tui_show_symtab_source): Likewise.
4488         (tui_source_window::maybe_update): Update.
4489         * tui/tui-disasm.c (tui_show_disassem)
4490         (tui_show_disassem_and_update_source)
4491         (tui_disasm_window::do_scroll_vertical)
4492         (tui_disasm_window::maybe_update): Update.
4493
4494 2019-08-16  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui.c (tui_is_window_visible): Update.
4497         * tui/tui-wingeneral.c (tui_make_window)
4498         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4499         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4500         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4501         (tui_set_win_height_command, parse_scrolling_args): Update.
4502         * tui/tui-source.c (tui_source_window::style_changed): Update.
4503         * tui/tui-regs.c (tui_show_registers)
4504         (tui_data_window::first_data_item_displayed)
4505         (tui_data_window::delete_data_content_windows)
4506         (tui_check_register_values, tui_reg_command): Update.
4507         * tui/tui-disasm.c (tui_show_disassem): Update.
4508         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4509         method.
4510         <is_visible>: Remove field.
4511         * tui/tui-data.c (tui_next_win, tui_prev_win)
4512         (tui_delete_invisible_windows): Update.
4513
4514 2019-08-16  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-winsource.h (struct tui_source_window_base)
4517         <m_has_locator>: Remove.
4518         * tui/tui-layout.c (show_source_disasm_command, show_data)
4519         (show_source_or_disasm_and_command): Update.
4520
4521 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4522
4523         * NEWS (Other MI changes): New subsection.
4524         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4525         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4526         * arch-utils.c (default_get_pc_address_flags): New function.
4527         * arch-utils.h (default_get_pc_address_flags): New declaration.
4528         * gdbarch.sh: Add get_pc_address_flags.
4529         * gdbarch.c: Regenerate.
4530         * gdbarch.h: Likewise.
4531         * stack.c (print_pc): New function.
4532         (print_frame_info) (print_frame): Call print_pc.
4533
4534 2019-08-16  Tom de Vries  <tdevries@suse.de>
4535
4536         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4537         print_objfile_section_info.
4538
4539 2019-08-15  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4542         calling update_cmdwin_start_line.
4543         * tui/tui-winsource.h (struct tui_source_window_base)
4544         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4545         <rerender>: Declare.
4546         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4547         Call rerender.
4548         (tui_source_window_base::set_new_height): Remove.
4549         (tui_source_window_base::rerender): Rename from
4550         do_make_visible_with_new_height.
4551         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4552         resize method.
4553         (tui_win_info::make_invisible_and_set_new_height)
4554         (tui_win_info::make_visible_with_new_height): Remove.
4555         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4556         Declare.
4557         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4558         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4559         do_make_visible_with_new_height>: Don't declare.
4560         <rerender>: Declare.
4561         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4562         set_new_height.
4563         (tui_data_window::do_make_visible_with_new_height): Remove.
4564         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4565         call tui_show_locator_content.
4566         (tui_gen_win_info::resize): Call rerender.
4567         (show_source_or_disasm_and_command): Don't call
4568         tui_show_locator_content.
4569         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4570         method.
4571         (struct tui_win_info) <rerender>: Declare.
4572         <set_new_height, make_invisible_and_set_new_height,
4573         make_visible_with_new_height>: Don't declare.
4574         * tui/tui-data.c (tui_win_list::rerender): New method.
4575         * tui/tui-command.h (struct tui_cmd_window)
4576         <do_make_visible_with_new_height>: Don't declare.
4577         * tui/tui-command.c
4578         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4579
4580 2019-08-15  Tom Tromey  <tromey@adacore.com>
4581
4582         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4583         * ada-lang.c (ada_enum_name): Likewise.
4584
4585 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4586
4587         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4588         leading underscore.
4589         (GdbOutputErrorFile): Likewise.
4590         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4591         accordingly.
4592         (execute_unwinders): Rename to have a leading underscore.
4593         (auto_load_packages): Likewise.
4594         (global scope): Adjust call to auto_load_packages accordingly.
4595         (GdbSetPythonDirectory): Likewise.
4596         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4597         instead of execute_unwinders.
4598
4599 2019-08-15  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4602         (show_data): Don't change window visibility.
4603         (tui_gen_win_info::resize): Remove special case for command
4604         window.  Use wresize, when available.
4605         (show_source_or_disasm_and_command): Don't change window
4606         visibility.
4607         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4608         <make_visible>: New method.
4609         * tui/tui-command.c (tui_cmd_window::resize): New method.
4610
4611 2019-08-15  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4614         (struct tui_source_windows): New.
4615         * tui/tui-winsource.c (tui_display_main): Update.
4616         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4617         (new_height_ok, parse_scrolling_args): Update.
4618         * tui/tui-layout.c (show_layout, show_data): Update.
4619         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4620         (tui_add_to_source_windows): Don't declare.
4621         * tui/tui-data.c (source_windows, tui_source_windows)
4622         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4623
4624 2019-08-15  Tom Tromey  <tom@tromey.com>
4625
4626         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4627         Rename from reset.
4628         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4629         * tui/tui-layout.c (show_source_disasm_command, show_data):
4630         Update.
4631         (tui_gen_win_info::resize): Rename.
4632         (show_source_or_disasm_and_command): Update.
4633         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4634         reset.
4635
4636 2019-08-15  Tom Tromey  <tom@tromey.com>
4637
4638         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4639         * tui/tui-interp.c (tui_interp::init): Don't call
4640         tui_initialize_static_data.
4641         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4642
4643 2019-08-15  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4646         examine tui_win_list.
4647
4648 2019-08-15  Tom Tromey  <tom@tromey.com>
4649
4650         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4651         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4652         tui_clear_source_content.
4653         (tui_clear_source_content): Remove.
4654         (tui_source_window_base::do_erase_source_content): Hoist call to
4655         content.clear().
4656         * tui/tui-stack.c (tui_show_frame_info): Don't call
4657         tui_clear_source_content.
4658
4659 2019-08-15  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-winsource.h (struct tui_source_window_base)
4662         <do_erase_source_content>: New method.
4663         <erase_source_content>: New method.
4664         (tui_erase_source_content): Don't declare.
4665         * tui/tui-winsource.c (tui_clear_source_content): Update.
4666         (tui_source_window_base::do_erase_source_content): Rename from
4667         tui_erase_source_content.
4668         (tui_source_window_base::show_source_content): Update.
4669         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4670         * tui/tui-source.h (struct tui_source_window)
4671         <erase_source_content>: New method.
4672         * tui/tui-disasm.h (struct tui_disasm_window)
4673         <erase_source_content>: New method.
4674
4675 2019-08-15  Tom Tromey  <tom@tromey.com>
4676
4677         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4678         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4679         constructor.
4680         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4681         * tui/tui-source.c (tui_set_source_content): Update.
4682         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4683
4684 2019-08-15  Tom Tromey  <tom@tromey.com>
4685
4686         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4687         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4688         tui-source.c.
4689         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4690         Declare.
4691         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4692         method.
4693         (tui_source_window::maybe_update): Update.
4694
4695 2019-08-15  Tom Tromey  <tom@tromey.com>
4696
4697         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4698         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4699         tui-disasm.c.
4700         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4701         Declare.
4702         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4703         method.
4704         (tui_disasm_window::maybe_update): Update.
4705
4706 2019-08-15  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-winsource.h (struct tui_source_window_base)
4709         <maybe_update>: Declare.
4710         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4711         method.
4712         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4713         Declare.
4714         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4715         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4716         Declare.
4717         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4718
4719 2019-08-15  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4722
4723 2019-08-15  Tom Tromey  <tom@tromey.com>
4724
4725         * tui/tui-wingeneral.c: Include tui-stack.h.
4726         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4727         (struct tui_locator_window): Move from tui-data.h.
4728         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4729         (tui_initialize_static_data): Move from tui-data.c.
4730         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4731         (struct tui_locator_window): Move to tui-stack.c.
4732         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4733         (tui_initialize_static_data): Move to tui-stack.c.
4734
4735 2019-08-15  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-layout.c (show_source_disasm_command)
4738         (show_source_or_disasm_and_command): Use make_visible method, not
4739         tui_make_window.
4740         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4741         Remove.
4742
4743 2019-08-15  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-wingeneral.h (tui_make_window): Update.
4746         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4747         parameter.
4748         (tui_gen_win_info::make_visible): Update.
4749         * tui/tui-regs.c (tui_data_window::display_registers_from):
4750         Update.
4751         * tui/tui-layout.c (show_source_disasm_command)
4752         (show_source_or_disasm_and_command): Update.
4753         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4754         (enum tui_box): Remove.
4755         (struct tui_win_info) <can_box>: New method.
4756         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4757         method.
4758
4759 2019-08-15  Tom de Vries  <tdevries@suse.de>
4760
4761         * linux-nat-trad.c: Include gdbarch.h.
4762
4763 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4764
4765         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4766         register sizes.
4767
4768 2019-08-14  Tom Tromey  <tromey@adacore.com>
4769
4770         * darwin-nat.c: Include gdbarch.h.
4771         * darwin-nat-info.c: Include gdbarch.h.
4772
4773 2019-08-13  Tom Tromey  <tom@tromey.com>
4774
4775         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4776         Remove.
4777         * tui/tui-data.c (tui_initialize_static_data): Update.
4778
4779 2019-08-13  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-winsource.h (struct tui_exec_info_window)
4782         <~tui_exec_info_window, maybe_allocate_content, get_content,
4783         m_content>: Remove.
4784         (struct tui_source_window_base) <set_exec_info_content,
4785         show_exec_info_content>: Don't declare.
4786         * tui/tui-winsource.c
4787         (tui_exec_info_window::maybe_allocate_content): Remove.
4788         (tui_source_window_base::update_exec_info): Rename from
4789         set_exec_info_content.
4790         (tui_source_window_base::show_exec_info_content)
4791         (tui_source_window_base::update_exec_info): Remove.
4792
4793 2019-08-13  Tom Tromey  <tom@tromey.com>
4794
4795         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4796         declare.
4797         * tui/tui-winsource.c (tui_update_source_window_as_is)
4798         (tui_update_source_windows_with_addr, tui_erase_source_content):
4799         Update.
4800         (tui_clear_exec_info_content): Remove.
4801
4802 2019-08-13  Tom Tromey  <tom@tromey.com>
4803
4804         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4805         declare.
4806         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4807         call tui_erase_exec_info_content.
4808         (tui_clear_exec_info_content): Rename from
4809         tui_erase_exec_info_content.
4810         (tui_clear_exec_info_content): Delete.
4811
4812 2019-08-13  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-winsource.h (struct tui_source_window_base)
4815         <show_exec_info_content>: Declare.
4816         (tui_show_exec_info_content): Don't declare.
4817         * tui/tui-winsource.c
4818         (tui_source_window_base::show_exec_info_content): Rename from
4819         tui_show_exec_info_content.
4820         (tui_source_window_base::update_exec_info): Update.
4821
4822 2019-08-13  Tom Tromey  <tom@tromey.com>
4823
4824         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4825         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4826         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4827         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4828         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4829         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4830         ... here.
4831
4832 2019-08-13  Tom Tromey  <tom@tromey.com>
4833
4834         * tui/tui-winsource.h (struct tui_source_window_base)
4835         <update_exec_info>: Declare.
4836         (tui_update_exec_info): Don't declare.
4837         * tui/tui-winsource.c (tui_update_source_window_as_is)
4838         (tui_source_window_base::refresh_all)
4839         (tui_update_all_breakpoint_info): Update.
4840         (tui_source_window_base::update_exec_info): Rename from
4841         tui_update_exec_info.
4842         * tui/tui-stack.c (tui_show_frame_info): Update.
4843
4844 2019-08-13  Tom Tromey  <tom@tromey.com>
4845
4846         * tui/tui-winsource.h (struct tui_source_window_base)
4847         <set_exec_info_content>: Declare.
4848         (tui_set_exec_info_content): Don't declare.
4849         * tui/tui-winsource.c
4850         (tui_source_window_base::set_exec_info_content): Rename from
4851         tui_set_exec_info_content.
4852         (tui_update_exec_info): Update.
4853
4854 2019-08-13  Tom Tromey  <tom@tromey.com>
4855
4856         * tui/tui-winsource.h (struct tui_source_window_base)
4857         <show_source_content>: Declare.
4858         (tui_show_source_content): Don't declare.
4859         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4860         (tui_source_window_base::show_source_content): Rename from
4861         tui_show_source_content.
4862         (tui_source_window_base::refresh_all): Update.
4863         * tui/tui-layout.c (show_source_disasm_command)
4864         (show_source_or_disasm_and_command): Update.
4865
4866 2019-08-13  Tom Tromey  <tom@tromey.com>
4867
4868         * tui/tui-winsource.c (tui_erase_source_content)
4869         (tui_show_source_content, tui_source_window_base::refresh_all):
4870         Update.
4871         * tui/tui-wingeneral.h
4872         (tui_check_and_display_highlight_if_needed): Don't declare.
4873         * tui/tui-wingeneral.c
4874         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4875         check_and_display_highlight_if_needed.
4876         * tui/tui-win.c (tui_rehighlight_all)
4877         (tui_win_info::make_visible_with_new_height): Update.
4878         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4879         (tui_data_window::erase_data_content)
4880         (tui_data_window::display_all_data): Update.
4881         * tui/tui-data.h (struct tui_win_info)
4882         <check_and_display_highlight_if_needed>: Declare.
4883
4884 2019-08-13  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-win.c (tui_resize_all): Call
4887         tui_delete_invisible_windows.
4888         * tui/tui-layout.c (show_layout): Call
4889         tui_delete_invisible_windows.
4890         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4891         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4892
4893 2019-08-13  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4896         tui_add_win_to_layout.
4897
4898 2019-08-13  Tom Tromey  <tom@tromey.com>
4899
4900         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4901         * tui/tui-layout.c (tui_default_win_height): Now static.
4902
4903 2019-08-13  Tom Tromey  <tom@tromey.com>
4904
4905         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4906         single switch.
4907         (show_source_disasm_command, show_source_or_disasm_and_command):
4908         Don't check current layout.
4909
4910 2019-08-13  Tom Tromey  <tom@tromey.com>
4911
4912         * tui/tui-wingeneral.c (make_all_visible): Remove.
4913         (tui_make_all_invisible): Simplify.
4914         * tui/tui-layout.c (tui_make_all_invisible): Move from
4915         tui-wingeneral.c; simplify.
4916         (show_layout): Hoist call to tui_make_all_invisible.
4917         (show_data): Don't call tui_make_all_invisible.
4918
4919 2019-08-13  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4922         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4923
4924 2019-08-13  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4927         tui-data.c.
4928         (show_source_disasm_command, show_data)
4929         (show_source_or_disasm_and_command): Don't use
4930         tui_set_current_layout_to.
4931         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4932         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4933         tui-layout.c.
4934         (tui_set_current_layout_to): Remove.
4935
4936 2019-08-13  Tom Tromey  <tom@tromey.com>
4937
4938         * tui/tui-layout.c (tui_set_layout): Update.
4939         * tui/tui-data.h (struct tui_layout_def): Remove.
4940         (tui_layout_def): Don't declare.
4941         * tui/tui-data.c (layout_def): Remove.
4942         (tui_layout_def): Remove.
4943
4944 2019-08-13  Tom Tromey  <tom@tromey.com>
4945
4946         * tui/tui-winsource.h (struct tui_source_window_base)
4947         <clear_detail>: No longer "override".
4948         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4949         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4950         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4951         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4952         Remove.
4953         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4954
4955 2019-08-13  Tom Tromey  <tromey@adacore.com>
4956
4957         * tracepoint.c: Don't include readline.h or history.h.
4958
4959 2019-08-12  Tom Tromey  <tom@tromey.com>
4960
4961         * configure: Rebuild.
4962         * configure.ac: Check for readline 7.
4963         * NEWS: Mention readline 7 requirement.
4964         * README: Update.
4965
4966 2019-08-12  Tom Tromey  <tom@tromey.com>
4967
4968         * mingw-hdep.c (gdb_select): Remove readline hack.
4969
4970 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4971
4972         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4973         when the function fails.
4974
4975 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4976
4977         * s390-tdep.c (s390_type_align): New function.
4978         (s390_gdbarch_init): Set it as type_align gdbarch method.
4979
4980 2019-08-09  Tom de Vries  <tdevries@suse.de>
4981
4982         PR gdb/24591
4983         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4984         pc_low with relocation offset.
4985
4986 2019-08-07  Tom Tromey  <tromey@adacore.com>
4987
4988         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4989         (print_frame_args): Update.
4990         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4991         Update.
4992         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4993         * frame.h (struct frame_arg): Add initializers.
4994         <error>: Now a unique_xmalloc_ptr.
4995
4996 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4997
4998         * NEWS: Expand the Pointer Authentication entry.
4999         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5000         (aarch64_frame_unmask_lr): ... to this.
5001         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5002         Call aarch64_frame_unmask_lr.
5003         * frame.c (struct frame_info): Add "masked" variable.
5004         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5005         (fprint_frame): Check for masked pc.
5006         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5007         declarations.
5008         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5009         * stack.c (print_frame): Check for masked pc.
5010
5011 2019-08-06  Tom Tromey  <tom@tromey.com>
5012
5013         * stabsread.c (patch_block_stabs, read_one_struct_field)
5014         (read_enum_type): Use obstack_strndup.
5015         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5016         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5017         * dwarf2read.c (guess_full_die_structure_name)
5018         (anonymous_struct_prefix): Use obstack_strndup.
5019         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5020         * c-exp.y (yylex): Use obstack_strndup.
5021         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5022         (write_var_or_type): Use obstack_strndup.
5023
5024 2019-08-06  Tom Tromey  <tom@tromey.com>
5025
5026         * symfile.c (reread_symbols): Use obstack_strdup.
5027         * stabsread.c (read_type): Use obstack_strdup.
5028         * gdb_obstack.h (obstack_strdup): New overload.
5029         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5030         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5031         (dwarf2_canonicalize_name): Use obstack_strdup.
5032         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5033         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5034         Use obstack_strdup.
5035
5036 2019-08-06  Tom Tromey  <tom@tromey.com>
5037
5038         * gdb_obstack.h (obstack_strdup): Define.
5039         * gdb_obstack.c (obstack_strdup): Don't define.
5040
5041 2019-08-06  Tom Tromey  <tom@tromey.com>
5042
5043         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5044         obstack_strdup.
5045         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5046         obstack_strdup.
5047         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5048         * stabsread.c (common_block_start): Use obstack_strdup.
5049         * objfiles.c (set_objfile_main_name, objfile): Use
5050         obstack_strdup.
5051         * namespace.c (add_using_directive): Use obstack_strdup.
5052         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5053         * jit.c (finalize_symtab): Use obstack_strdup.
5054         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5055         (guess_partial_die_structure_name, partial_die_info::fixup)
5056         (dwarf2_name): Use obstack_strdup.
5057         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5058         obstack_strdup.
5059         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5060         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5061         obstack_strdup.
5062         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5063
5064 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5065
5066         * unittests/help-doc-selftests.c: New file.
5067         * Makefile.in: Add the new file.
5068
5069 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5070
5071         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5072         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5073         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5074         the trailing '.' is not output, and the first character is uppercased.
5075         (print_help_for_command): Update call to print_doc_line.
5076         (print_doc_of_command): Likewise.
5077         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5078         * cli/cli-option.c (append_indented_doc): Do not append newline.
5079         (build_help_option): Append newline after first appended_indented_doc
5080         only if a second call is done.
5081         (build_help): Append 2 new lines before each option, except the first
5082         one.
5083         * compile/compile.c (_initialize_compile): Add new lines after
5084         %OPTIONS%, when not at the end of the help.
5085         Change help doc or code
5086         producing the help doc to respect the invariants.
5087         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5088         Also removed the new line after 'Options:', as all other commands
5089         do not put an empty line between 'Options:' and the first option.
5090         * printcmd.c (_initialize_printcmd): Likewise.
5091         * stack.c (_initialize_stack): Likewise.
5092         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5093         incorrectly telling COMMAND is optional.
5094         * ada-lang.c (_initialize_ada_language): Change help doc or code
5095         producing the help doc to respect the invariants.
5096         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5097         * breakpoint.c (_initialize_breakpoint): Likewise.
5098         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5099         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5100         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5101         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5102         _initialize_cli_style): Likewise.
5103         * corelow.c (core_target_info): Likewise.
5104         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5105         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5106         * filesystem.c (_initialize_filesystem): Likewise.
5107         * frame.c (_initialize_frame): Likewise.
5108         * gnu-nat.c (add_task_commands): Likewise.
5109         * infcall.c (_initialize_infcall): Likewise.
5110         * infcmd.c (_initialize_infcmd): Likewise.
5111         * interps.c (_initialize_interpreter): Likewise.
5112         * language.c (_initialize_language): Likewise.
5113         * linux-fork.c (_initialize_linux_fork): Likewise.
5114         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5115         * maint.c (_initialize_maint_cmds): Likewise.
5116         * memattr.c (_initialize_mem): Likewise.
5117         * printcmd.c (_initialize_printcmd): Likewise.
5118         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5119         _RegEx): Likewise.
5120         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5121         * record-btrace.c (_initialize_record_btrace): Likewise.
5122         * record-full.c (_initialize_record_full): Likewise.
5123         * record.c (_initialize_record): Likewise.
5124         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5125         * regcache.c (_initialize_regcache): Likewise.
5126         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5127         _initialize_remote): Likewise.
5128         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5129         * serial.c (_initialize_serial): Likewise.
5130         * skip.c (_initialize_step_skip): Likewise.
5131         * source.c (_initialize_source): Likewise.
5132         * stack.c (_initialize_stack): Likewise.
5133         * symfile.c (_initialize_symfile): Likewise.
5134         * symtab.c (_initialize_symtab): Likewise.
5135         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5136         * top.c (init_main): Likewise.
5137         * tracefile-tfile.c (tfile_target_info): Likewise.
5138         * tracepoint.c (_initialize_tracepoint): Likewise.
5139         * tui/tui-win.c (_initialize_tui_win): Likewise.
5140         * utils.c (add_internal_problem_command): Likewise.
5141         * valprint.c (value_print_option_defs): Likewise.
5142
5143 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5144
5145         PR build/24886
5146         * configure.ac: Drop enable-libmcheck support.
5147         * configure, config.in: Rebuild.
5148         * libmcheck.m4: Remove.
5149         * acinclude.m4: Don't include it.
5150         * Makefile.in: Don't distribute it.
5151         * top.c (print_gdb_configuration): Don't mention it.
5152
5153 2019-08-06  Tom Tromey  <tom@tromey.com>
5154
5155         * utils.c (set_output_style): Sometimes pass stream to
5156         emit_style_escape.
5157         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5158         * record-btrace.c (btrace_insn_history): Update.
5159         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5160         method.
5161         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5162         Update initializers.
5163         <m_uiout>: New field.
5164         <m_di>: Move lower.
5165         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5166         Remove "uiout" parameter.
5167         (dump_insns): Update.
5168         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5169         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5170
5171 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5172
5173         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5174         (error_in_psymtab_expansion): Likewise.
5175         (lookup_symbol_via_quick_fns): Likewise.
5176         (basic_lookup_transparent_type_quick): Likewise.
5177         (basic_lookup_transparent_type_1): Likewise.
5178
5179 2019-08-06  Tom Tromey  <tromey@adacore.com>
5180
5181         * source.c (last_source_error): Now bool.
5182         (print_source_lines_base): Make "noprint" bool.  Only open
5183         source file when last_source_visited changes.
5184
5185 2019-08-06  Tom Tromey  <tromey@adacore.com>
5186
5187         * annotate.c (annotate_source_line): Use g_source_cache.
5188         * source-cache.c (source_cache::get_plain_source_lines): Change
5189         parameters.  Populate m_offset_cache.
5190         (source_cache::ensure): New method.
5191         (source_cache::get_line_charpos): New method.
5192         (extract_lines): Move lower.  Change parameters.
5193         (source_cache::get_source_lines): Move lower.
5194         * source-cache.h (class source_cache): Update comment.
5195         <get_line_charpos>: New method.
5196         <get_source_lines>: Update comment.
5197         <clear>: Clear m_offset_cache.
5198         <get_plain_source_lines>: Change parameters.
5199         <ensure>: New method
5200         <m_offset_cache>: New member.
5201         * source.c (forget_cached_source_info_for_objfile): Update.
5202         (info_source_command): Use g_source_cache.
5203         (find_source_lines, open_source_file_with_line_charpos): Remove.
5204         (print_source_lines_base, search_command_helper): Use g_source_cache.
5205         * source.h (open_source_file_with_line_charpos): Don't declare.
5206         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5207         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5208         Use g_source_cache.
5209
5210 2019-08-06  Tom Tromey  <tromey@adacore.com>
5211
5212         * source-cache.c (source_cache::get_plain_source_lines):
5213         Remove "first_line" and "last_line" parameters.
5214         (source_cache::get_source_lines): Cache plain text.
5215         * source-cache.h (class source_cache)
5216         <get_plain_source_lines>: Update.
5217
5218 2019-08-06  Tom Tromey  <tromey@adacore.com>
5219
5220         * source-cache.c (extract_lines): No longer a method.
5221         Changed type of parameter.  Include final newline.
5222         (selftests::extract_lines_test): New function.
5223         (_initialize_source_cache): Likewise.
5224         * source-cache.h (class source_cache)
5225         <extract_lines>: Don't declare.
5226
5227 2019-08-06  Tom Tromey  <tromey@adacore.com>
5228
5229         * breakpoint.c (init_breakpoint_sal): Update.
5230         (breakpoint): Update.
5231         * breakpoint.h (struct breakpoint) <filter>: Now a
5232         unique_xmalloc_ptr.
5233
5234 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5235
5236         * NEWS: Mention dictionary access on blocks.
5237         * python/py-block.c (blpy_getitem): New function.
5238         (block_object_as_mapping): New struct.
5239         (block_object_type): Use new struct for tp_as_mapping field.
5240
5241 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5242
5243         * objfiles.h (objfile): Add a comment describing partial symbols.
5244
5245 2019-08-05  Tom Tromey  <tromey@adacore.com>
5246
5247         * compile/compile.c (_initialize_compile): Use _(), not N_().
5248         * thread.c (_initialize_thread): Use _(), not N_().
5249         * stack.c (_initialize_stack): Use _(), not N_().
5250         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5251
5252 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5253
5254         * dwarf2read.c (struct dw2_symtab_iterator):
5255         <want_specific_block>: Remove.
5256         <block_index>: Change type to gdb::optional.
5257         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5258         change type of BLOCK_INDEX parameter to gdb::optional.
5259         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5260         (dw2_lookup_symbol): Don't pass argument for
5261         WANT_SPECIFIC_BLOCK.
5262         (dw2_expand_symtabs_for_function): Don't pass argument for
5263         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5264         (class dw2_debug_names_iterator)
5265         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5266         parameter, change BLOCK_INDEX type to gdb::optional.
5267         <m_want_specific_block>: Remove.
5268         <m_block_index>: Change type to gdb::optional.
5269         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5270         gdb::optional.  Re-write in function of gdb::optional.
5271         (dw2_debug_names_lookup_symbol): Don't pass argument for
5272         WANT_SPECIFIC_BLOCK.
5273         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5274         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5275         BLOCK_INDEX.
5276
5277 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5278
5279         * NEWS: Mention changes to "info sources" command.
5280
5281 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5282
5283         * symtab.c (filename_partial_match_opts): New struct type.
5284         (struct output_source_filename_data): New members
5285         regexp, c_regexp, partial_match.
5286         (output_source_filename): Use new members to decide to print file.
5287         (info_sources_option_defs): New variable.
5288         (make_info_sources_options_def_group, print_info_sources_header,
5289         info_sources_command_completer):
5290         New functions.
5291         (info_sources_command): Read new optional arguments.
5292         (_initialize_symtab): Update info sources help.
5293
5294 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5295
5296         * ada-lang.c (exception_support_info_v0): Renamed from...
5297         (default_exception_support_info): ... this.  Create new
5298         definition for v1.
5299         (ada_has_this_exception_support): Look up catch_handlers_sym.
5300         (ada_exception_support_info_sniffer): Try v0 after default.
5301
5302 2019-08-01  Tom Tromey  <tromey@adacore.com>
5303
5304         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5305         gdbarch.h.
5306
5307 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5308
5309         * s12z-tdep.c: Fix include path for s12z-opc.h.
5310
5311 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5312
5313         * NEWS: Require GNU make 3.82.
5314
5315 2019-07-16  Tom Tromey  <tom@tromey.com>
5316
5317         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5318         declare.
5319
5320 2019-07-30  Tom Tromey  <tromey@adacore.com>
5321
5322         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5323
5324 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5325
5326         * printcmd.c (print_address_symbolic): Print negative offsets.
5327         (build_address_symbolic): Force signed arithmetic when computing
5328         offset.
5329
5330 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5331
5332         PR/24474: Add a function to lookup static variables.
5333         * NEWS: Mention this new function.
5334         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5335         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5336         * python/python.c (python_GdbMethods): Add new function.
5337
5338 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5339
5340         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5341         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5342         (objfpy_lookup_static_symbol): New function.
5343         (objfile_object_methods): Add new functions.
5344
5345 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5346
5347         * NEWS: Mention 'set|show print frame-info'.  Mention new
5348         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5349         backtrace argument.  Mention that python frame filtering code
5350         is now consistent with what 'backtrace' command prints.
5351
5352 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5353
5354         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5355         comments.
5356         (print_frame_info_auto, print_frame_info_source_line,
5357         print_frame_info_location, print_frame_info_source_and_location,
5358         print_frame_info_location_and_address, print_frame_info_short_location):
5359         New declarations.
5360         (struct frame_print_options): New member print_frame_info.
5361         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5362         * stack.h (get_user_print_what_frame_info): New declaration.
5363         (frame_show_address): New declaration.
5364         * stack.c (print_frame_arguments_choices): New value 'presence'.
5365         (print_frame_info_auto, print_frame_info_source_line,
5366         print_frame_info_location, print_frame_info_source_and_location,
5367         print_frame_info_location_and_address, print_frame_info_short_location,
5368         print_frame_info_choices, print_frame_info_print_what): New definitions.
5369         (print_frame_args): Only print dots for args if print frame-arguments
5370         is 'presence'.
5371         (frame_print_option_defs): New element for "frame-info".
5372         (get_user_print_what_frame_info): New function.
5373         (frame_show_address): Make non static.  Move comment to stack.h.
5374         (print_frame_info_to_print_what): New function.
5375         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5376         to decide what to print.
5377         (backtrace_command_1): Handle the new print_frame_arguments_presence
5378         value.
5379         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5380         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5381         (py_print_frame): In non-mi mode, use LOCATION as default for
5382         print_what, similarly to frame information printed directly by
5383         backtrace command. Handle frame-info user option in non MI mode.
5384
5385 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5386
5387         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5388         Add case for debugging 32-bit target on 64-bit host.  Revise
5389         comment.
5390
5391 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5392
5393         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5394         instead of find_function_entry_range_from_pc.
5395
5396 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5397
5398         * stack.c (find_frame_funname): Remove code which preferred
5399         minsym over symtab sym in "certain pathological cases".
5400
5401         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5402         parameter.  Change type of "do_demangle" to bool.
5403         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5404         Pass suitable "prefer_sym_over_minsym" flag to
5405         build_address_symbolic().  Don't output "+" for negative offsets.
5406         * printcmd.c (print_address_symbolic): Update invocation of
5407         build_address_symbolic to include a "prefer_sym_over_minsym"
5408         flag.
5409         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5410         Restrict cases in which use of minimal symbol is preferred to that
5411         of a found symbol.  Update comments.
5412
5413         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5414         for entry pc when entry pc is out of range for that FDE.
5415
5416 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5417
5418         PR gdb/24839:
5419         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5420         type.
5421
5422 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5423
5424         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5425         this function's Python signature.
5426
5427
5428 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5429
5430         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5431         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5432         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5433         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5434         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5435
5436
5437 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5438
5439         * h8300-tdep.c (h8300_register_name_common): New.
5440         h8300_register_name): Use h8300_register_name_common.
5441         (h8300s_register_name): Likewise.
5442         (h8300sx_register_name): Likewise.
5443         (h8300h_register_nam): New.
5444         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5445
5446
5447 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5448
5449         * arm-tdep.c (arm_skip_cmse_entry): New function.
5450         (arm_is_sgstubs_section): New function.
5451         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5452
5453 2019-07-22  Tom Tromey  <tom@tromey.com>
5454
5455         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5456         Don't self-assign.
5457
5458 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5459
5460         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5461         type_print.
5462
5463 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5466         so that GDB doesn't match any msymbols when searching in the
5467         TYPES_DOMAIN.
5468         (print_symbol_info): Print using typedef_print or type_print based
5469         on the type of the symbol.  Add updated FIXME comment moved from...
5470         (_initialize_symtab): ... move and update FIXME comment to above.
5471
5472 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5473
5474         * NEWS: Mention adding -q option to "info types".
5475         * symtab.c (struct info_types_options): New struct.
5476         (info_types_options_defs): New variable.
5477         (make_info_types_options_def_group): New function.
5478         (info_types_command): Use gdb::option framework to parse options.
5479         (info_types_command_completer): New function.
5480         (_initialize_symtab): Extend the help text on "info types" and
5481         register command completer.
5482
5483 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5484
5485         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5486         (lookup_symbol_in_objfile): Change int to block_enum and add a
5487         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5488
5489 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5490
5491         * MAINTAINERS (Write After Approval): Add self.
5492
5493 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5494
5495         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5496         instruction to the dummy code region.
5497
5498 2019-07-19  Tom Tromey  <tromey@adacore.com>
5499
5500         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5501         (ARGSUSED, PARAMS, __func__): Remove rules.
5502
5503 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5504
5505         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5506         * features/arm/arm-with-iwmmxt.c: Remove.
5507         * features/arm/arm-with-iwmmxt.xml: Remove.
5508         * features/arm/arm-with-m-fpa-layout.c: Remove.
5509         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5510         * features/arm/arm-with-m-vfp-d16.c: Remove.
5511         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5512         * features/arm/arm-with-m.c: Remove.
5513         * features/arm/arm-with-m.xml: Remove.
5514         * features/arm/arm-with-neon.c: Remove.
5515         * features/arm/arm-with-neon.xml: Remove.
5516         * features/arm/arm-with-vfpv2.c: Remove.
5517         * features/arm/arm-with-vfpv2.xml: Remove.
5518         * features/arm/arm-with-vfpv3.c: Remove.
5519         * features/arm/arm-with-vfpv3.xml: Remove.
5520
5521 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5522
5523         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5524
5525 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5526
5527         * arch/aarch32.c (aarch32_create_target_description): Create
5528         target descriptions using features.
5529         * arch/arm.c (arm_create_target_description)
5530         (arm_create_mprofile_target_description): Likewise.
5531         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5532
5533 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5534
5535         * Makefile.in: Add new files.
5536         * aarch32-tdep.c: New file.
5537         * aarch32-tdep.h: New file.
5538         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5539         Call aarch32_read_description.
5540         * arch/aarch32.c: New file.
5541         * arch/aarch32.h: New file.
5542         * arch/arm.c (arm_create_target_description)
5543         (arm_create_mprofile_target_description): New function.
5544         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5545         (arm_create_target_description)
5546         (arm_create_mprofile_target_description): New declaration.
5547         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5548         read_description functions.
5549         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5550         Likewise.
5551         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5552         * arm-tdep.c (tdesc_arm_list): New variable.
5553         (arm_register_g_packet_guesses): Call create description functions.
5554         (arm_read_description) (arm_read_mprofile_description): New
5555         function.
5556         * arm-tdep.h (arm_read_description)
5557         (arm_read_mprofile_description): Add declaration.
5558         * configure.tgt: Add new files.
5559
5560 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5561
5562         * top.c (new_ui_command): Open specified terminal just once.
5563
5564 2019-07-18  Tom Tromey  <tromey@adacore.com>
5565
5566         * symtab.c (main_name): Constify return type.
5567         * symfile.c (set_initial_language): Update.
5568         * symtab.h (main_name): Constify return type.
5569
5570 2019-07-17  Tom Tromey  <tom@tromey.com>
5571
5572         * tui/tui-winsource.c (tui_update_source_window)
5573         (tui_update_source_window_as_is)
5574         (tui_update_source_windows_with_line): Remove return.
5575         * tui/tui-disasm.c (tui_show_disassem)
5576         (tui_show_disassem_and_update_source): Remove return.
5577         * tui/tui.c (tui_reset): Remove return.
5578         * tui/tui-wingeneral.c
5579         (tui_check_and_display_highlight_if_needed): Remove return.
5580
5581 2019-07-17  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5584
5585 2019-07-17  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-winsource.h (struct tui_exec_info_window)
5588         (struct tui_source_window_base): Move from tui-data.h.
5589         * tui/tui-winsource.c: Move many method definitions from
5590         elsewhere.  Remove "structuring" comments.
5591         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5592         (tui_source_window_base::refresh_window): Move to
5593         tui-winsource.c.
5594         * tui/tui-win.c (tui_source_window_base::refresh_all)
5595         (tui_source_window_base::update_tab_width)
5596         (tui_source_window_base::set_new_height)
5597         (tui_source_window_base::do_make_visible_with_new_height): Move to
5598         tui-winsource.c.
5599         * tui/tui-source.h: Update.
5600         * tui/tui-source.c (tui_source_window_base::reset): Move to
5601         tui-winsource.c.
5602         * tui/tui-disasm.h: Update.
5603         * tui/tui-data.h (struct tui_exec_info_window): Move to
5604         tui-winsource.h.
5605         (struct tui_source_window_base): Likewise.
5606         * tui/tui-data.c (tui_source_window_base::clear_detail)
5607         (tui_source_window_base, ~tui_source_window_base): Move to
5608         tui-winsource.c.
5609
5610 2019-07-17  Tom Tromey  <tom@tromey.com>
5611
5612         * tui/tui-win.c (tui_resize_all)
5613         (tui_source_window_base::update_tab_width)
5614         (tui_adjust_win_heights): Update.
5615         (tui_win_info::make_invisible_and_set_new_height): Rename from
5616         make_invisible_and_set_new_height.
5617         * tui/tui-data.h (struct tui_win_info)
5618         <make_invisible_and_set_new_height>: New method.
5619
5620 2019-07-17  Tom Tromey  <tom@tromey.com>
5621
5622         * tui/tui.c: Update.
5623         * tui/tui-source.h (struct tui_source_window): Move from
5624         tui-data.h.
5625         * tui/tui-layout.c: Update.
5626         * tui/tui-disasm.c: Update.
5627         * tui/tui-data.h (struct tui_source_window): Move to
5628         tui-source.h.
5629
5630 2019-07-17  Tom Tromey  <tom@tromey.com>
5631
5632         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5633         tui-data.h.
5634         * tui/tui-data.h (struct tui_disasm_window): Move to
5635         tui-disasm.h.
5636
5637 2019-07-17  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui-regs.h (struct tui_data_item_window): Move from
5640         tui-data.h.
5641         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5642         * tui/tui-data.h (struct tui_data_item_window): Move to
5643         tui-regs.h.
5644         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5645
5646 2019-07-17  Tom Tromey  <tom@tromey.com>
5647
5648         * tui/tui.c: Update.
5649         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5650         (tui_cmd_window::max_height): Move to tui-command.c.
5651         * tui/tui-layout.c: Update.
5652         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5653         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5654         tui-command.c.
5655         * tui/tui-command.h (struct tui_cmd_window): Move from
5656         tui-data.h.
5657         * tui/tui-command.c: Remove "structuring" comments.
5658         (tui_cmd_window::clear_detail)
5659         (tui_cmd_window::do_make_visible_with_new_height)
5660         (tui_cmd_window::max_height): Move from elsewhere.
5661
5662 2019-07-17  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5665         Now static.
5666         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5667         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5668
5669 2019-07-17  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui.c: Update.
5672         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5673         tui-regs.c.
5674         * tui/tui-windata.h: Remove file.
5675         * tui/tui-windata.c: Remove file.
5676         * tui/tui-win.c (tui_data_window::set_new_height)
5677         (tui_data_window::do_make_visible_with_new_height): Move to
5678         tui-regs.c.
5679         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5680         * tui/tui-regs.c: Remove "structuring" comments.
5681         (tui_data_window::first_data_item_displayed)
5682         (tui_data_window::delete_data_content_windows)
5683         (tui_data_window::erase_data_content)
5684         (tui_data_window::display_all_data)
5685         (tui_data_window::refresh_all)
5686         (tui_data_window::do_scroll_vertical)
5687         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5688         (tui_data_window::do_make_visible_with_new_height)
5689         (tui_data_window::refresh_window): Move from elsewhere.
5690         (_initialize_tui_regs): Move to end of file.
5691         * tui/tui-layout.c: Update.
5692         * tui/tui-hooks.c: Update.
5693         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5694         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5695         tui-regs.c.
5696         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5697
5698 2019-07-17  Tom Tromey  <tom@tromey.com>
5699
5700         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5701         seen.
5702
5703 2019-07-17  Tom Tromey  <tom@tromey.com>
5704
5705         * tui/tui-win.c (tui_source_window_base::set_new_height)
5706         (tui_source_window_base::do_make_visible_with_new_height): Use
5707         m_has_locator field directly.
5708         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5709         method.
5710         (struct tui_source_window_base) <has_locator>: Likewise.
5711
5712 2019-07-17  Tom Tromey  <tom@tromey.com>
5713
5714         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5715         Don't declare.
5716         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5717         Remove.
5718         * tui/tui-win.c (tui_source_window_base::set_new_height)
5719         (tui_source_window_base::set_new_height)
5720         (make_invisible_and_set_new_height)
5721         (tui_source_window_base::do_make_visible_with_new_height)
5722         (tui_source_window_base::do_make_visible_with_new_height):
5723         Update.
5724         * tui/tui-layout.c (show_source_disasm_command, show_data)
5725         (show_source_or_disasm_and_command): Update.
5726         * tui/tui-layout.c (show_layout): Update.
5727
5728 2019-07-17  Tom Tromey  <tom@tromey.com>
5729
5730         * tui/tui-layout.c (make_data_window): Remove.
5731         (show_data): Unify creation and re-initialization cases.
5732
5733 2019-07-17  Tom Tromey  <tom@tromey.com>
5734
5735         * tui/tui-layout.c (make_source_window, make_disasm_window):
5736         Remove.
5737         (show_data): Unify creation and re-initialization cases.
5738
5739 2019-07-17  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-layout.c (make_command_window): Remove.
5742         (show_source_disasm_command, show_source_or_disasm_and_command):
5743         Unify creation and re-initialization cases.
5744
5745 2019-07-17  Tom Tromey  <tom@tromey.com>
5746
5747         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5748         creation and re-initialization cases.
5749
5750 2019-07-17  Tom Tromey  <tom@tromey.com>
5751
5752         * tui/tui-regs.c (tui_get_register): Return void.
5753
5754 2019-07-17  Tom Tromey  <tom@tromey.com>
5755
5756         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5757         Simplify.
5758
5759 2019-07-17  Tom Tromey  <tom@tromey.com>
5760
5761         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5762         resetting.
5763
5764 2019-07-17  Tom Tromey  <tom@tromey.com>
5765
5766         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5767         * tui/tui-regs.c (tui_reg_layout): New function.
5768         (tui_show_registers, tui_reg_command): Use it.
5769         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5770         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5771         parameters.
5772         (tui_layout_command): Remove.
5773
5774 2019-07-17  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-layout.h (tui/tui-layout): Return void.
5777         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5778
5779 2019-07-17  Tom Tromey  <tom@tromey.com>
5780
5781         * tui/tui-layout.c (show_source_disasm_command, show_data):
5782         Update.
5783         (reset_locator): Remove.
5784         (show_source_or_disasm_and_command): Update.
5785
5786 2019-07-17  Tom Tromey  <tom@tromey.com>
5787
5788         * tui/tui-source.c (tui_source_window_base::reset): Remove
5789         win_type parameter.
5790         * tui/tui-layout.c (make_command_window, make_source_window)
5791         (make_disasm_window, make_data_window)
5792         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5793         (reset_locator, show_source_or_disasm_and_command): Update.
5794         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5795         win_type parameter.
5796         (struct tui_source_window_base) <reset>: Likewise.
5797
5798 2019-07-17  Tom Tromey  <tom@tromey.com>
5799
5800         * tui/tui-layout.c (show_source_disasm_command): Use
5801         reset_locator.
5802         (reset_locator): New function.
5803         (init_and_make_win): Remove.
5804         (show_source_or_disasm_and_command): Use reset_locator.
5805
5806 2019-07-17  Tom Tromey  <tom@tromey.com>
5807
5808         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5809         condition.
5810         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5811         Remove condition.
5812         * tui/tui-source.c (tui_source_window_base::reset): New method.
5813         * tui/tui-layout.c (make_command_window): Don't call
5814         init_and_make_win.
5815         (make_source_window, make_disasm_window): Don't call
5816         make_source_or_disasm_window.
5817         (make_data_window): Don't call init_and_make_win.  Change calling
5818         convention.
5819         (show_source_disasm_command, show_data): Simplify.
5820         (make_source_or_disasm_window): Remove.
5821         (show_source_or_disasm_and_command): Simplify.
5822         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5823         (struct tui_source_window_base) <reset>: Likewise.
5824         <execution_info>: Remove initializer.
5825         * tui/tui-data.c (tui_source_window_base): Initialize
5826         execution_info.
5827
5828 2019-07-17  Tom Tromey  <tom@tromey.com>
5829
5830         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5831         variable.
5832
5833 2019-07-17  Tom Tromey  <tom@tromey.com>
5834
5835         * tui/tui.c (tui_rl_other_window): Update.
5836         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5837         superclass method first.  Always iterate over regs_content.
5838         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5839         method.
5840         * tui/tui-win.c (tui_set_focus_command): Update.
5841
5842 2019-07-17  Tom Tromey  <tom@tromey.com>
5843
5844         * tui/tui-win.c (tui_set_focus_command): Rename from
5845         tui_set_focus.  Call tui_enable.
5846         (tui_set_focus_command): Remove.
5847
5848 2019-07-17  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5851         refresh_window.
5852         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5853         touchwin.
5854         (tui_data_window::refresh_window): Call refresh_window on data
5855         items.  Always call superclass refresh_window.
5856         (tui_win_info::refresh): Remove.
5857         (tui_source_window_base::refresh_window): Update.
5858         (tui_refresh_all): Update.
5859         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5860         refresh_window.
5861         (show_source_or_disasm_and_command): Likewise.
5862         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5863         (struct tui_source_window_base) <refresh>: Likewise.
5864
5865 2019-07-17  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-winsource.c (tui_clear_source_content)
5868         (tui_show_source_content): Update.
5869         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5870         whether content is empty.
5871         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5872         Remove.
5873
5874 2019-07-17  Tom Tromey  <tom@tromey.com>
5875
5876         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5877         window's contents.
5878         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5879         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5880
5881 2019-07-17  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5884         (struct tui_data_item_window): Update.
5885
5886 2019-07-17  Tom Tromey  <tom@tromey.com>
5887
5888         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5889         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5890         defines.
5891
5892 2019-07-17  Tom Tromey  <tom@tromey.com>
5893
5894         * tui/tui-winsource.h (tui_erase_source_content)
5895         (tui_clear_source_content): Remove "display_prompt" parameter.
5896         * tui/tui-winsource.c (tui_update_source_window_as_is)
5897         (tui_update_source_windows_with_addr): Update.
5898         (tui_clear_source_content): Remove "display_prompt" parameter.
5899         (tui_erase_source_content): Likewise.  Simplify.
5900         (tui_show_source_content): Update.
5901         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5902         * tui/tui-stack.c (tui_show_frame_info): Update.
5903         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5904         Remove defines.
5905
5906 2019-07-17  Tom Tromey  <tom@tromey.com>
5907
5908         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5909         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5910         parameter.
5911         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5912         parameter.
5913
5914 2019-07-17  Tom Tromey  <tom@tromey.com>
5915
5916         * tui/tui-winsource.c (tui_clear_source_content)
5917         (tui_show_source_content, tui_show_exec_info_content)
5918         (tui_clear_exec_info_content): Update.
5919         * tui/tui-stack.c (tui_show_locator_content): Update.
5920         (tui_show_frame_info): Update.
5921         * tui/tui-source.h (tui_source_window): Don't declare.
5922         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5923         from tui_source_is_displayed.
5924         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5925         Remove field.
5926         (struct tui_source_window_base) <content_in_use>: New field.  Now
5927         bool.
5928         (struct tui_source_window) <showing_source_p>: New method.
5929         (TUI_SRC_WIN): Change cast.
5930         * tui/tui-data.c (tui_initialize_static_data): Update.
5931
5932 2019-07-17  Tom Tromey  <tom@tromey.com>
5933
5934         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5935         location_matches_p.
5936         * tui/tui-source.c (tui_source_window::location_matches_p): New
5937         method.
5938         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5939         method.
5940         * tui/tui-data.h (struct tui_source_window_base)
5941         <location_matches_p>: New method.
5942         (struct tui_source_window, struct tui_disasm_window)
5943         <location_matches_p>: Likewise.
5944
5945 2019-07-17  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui-win.c (tui_set_win_height_command): Rename from
5948         tui_set_win_height.
5949         (tui_set_win_height_command): Remove.
5950
5951 2019-07-17  Tom Tromey  <tom@tromey.com>
5952
5953         * tui/tui-source.c (tui_source_window): New constructor.  Add
5954         observer.
5955         (~tui_source_window): New destructor.
5956         (tui_source_window::style_changed): New method.
5957         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5958         (tui_attach_detach_observers): Update.
5959         * tui/tui-data.h (struct tui_source_window): Make constructor not
5960         inline.  Add destructor.
5961         (struct tui_source_window) <style_changed>: New method.
5962         <m_observable>: New member.
5963
5964 2019-07-17  Tom Tromey  <tom@tromey.com>
5965
5966         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5967         * tui/tui-win.c (tui_resize_all): Fix typo.
5968
5969 2019-07-17  Tom Tromey  <tom@tromey.com>
5970
5971         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5972         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5973         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5974         * tui/tui-win.c (window_name_completer): Use foreach.
5975         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5976         (update_tab_width): Likewise.
5977         * tui/tui-layout.c (show_layout): Update.
5978         * tui/tui-data.h (class tui_window_iterator): New.
5979         (struct all_tui_windows): New.
5980         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5981
5982 2019-07-17  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5985         parameter.  Don't reference globals.
5986         (tui_reg_command): Update.
5987
5988 2019-07-17  Tom Tromey  <tom@tromey.com>
5989
5990         * tui/tui-regs.c (tui_show_registers): Simplify.
5991
5992 2019-07-17  Tom Tromey  <tom@tromey.com>
5993
5994         * tui/tui-regs.c (tui_show_registers): Update.
5995         (tui_show_register_group): Add win_info parameter.
5996
5997 2019-07-17  Tom Tromey  <tom@tromey.com>
5998
5999         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6000         Rename from tui_display_reg_element_at_line.
6001         (tui_data_window::display_registers_from_line): Update.
6002         * tui/tui-data.h (struct tui_data_window)
6003         <display_reg_element_at_line>: New method.
6004
6005 2019-07-17  Tom Tromey  <tom@tromey.com>
6006
6007         * tui/tui-regs.h (tui_display_registers_from)
6008         (tui_display_registers_from_line): Don't declare.
6009         * tui/tui-windata.c (tui_data_window::display_all_data)
6010         (tui_data_window::refresh_all)
6011         (tui_data_window::do_scroll_vertical): Update.
6012         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6013         from tui_display_registers_from.
6014         (tui_display_reg_element_at_line): Update.
6015         (tui_data_window::display_registers_from_line): Rename from
6016         tui_display_registers_from_line.
6017         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6018         display_registers_from_line>: New methods.
6019
6020 2019-07-17  Tom Tromey  <tom@tromey.com>
6021
6022         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6023         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6024         from tui_erase_data_content.
6025         (tui_data_window::display_all_data)
6026         (tui_data_window::refresh_all)
6027         (tui_data_window::do_scroll_vertical): Update.
6028         * tui/tui-regs.c (tui_show_registers): Update.
6029         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6030         New method.
6031
6032 2019-07-17  Tom Tromey  <tom@tromey.com>
6033
6034         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6035         declare.
6036         * tui/tui-windata.c
6037         (tui_data_window::delete_data_content_windows): Rename from
6038         tui_delete_data_content_windows.
6039         (tui_data_window::display_all_data)
6040         (tui_data_window::do_scroll_vertical): Update.
6041         * tui/tui-data.h (struct tui_data_window)
6042         <delete_data_content_windows>: New method.
6043
6044 2019-07-17  Tom Tromey  <tom@tromey.com>
6045
6046         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6047         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6048
6049 2019-07-17  Tom Tromey  <tom@tromey.com>
6050
6051         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6052         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6053         from tui_display_all_data.
6054         * tui/tui-win.c
6055         (tui_data_window::do_make_visible_with_new_height): Update.
6056         * tui/tui-regs.c (tui_show_registers): Update.
6057         * tui/tui-layout.c (tui_set_layout): Update.
6058         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6059         method.
6060
6061 2019-07-17  Tom Tromey  <tom@tromey.com>
6062
6063         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6064         * tui/tui-windata.c (tui_display_data_from): Remove.
6065         (tui_data_window::refresh_all): Update.
6066
6067 2019-07-17  Tom Tromey  <tom@tromey.com>
6068
6069         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6070         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6071         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6072         tui_display_registers_from_line.
6073         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6074         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6075         "force_display" parameter.
6076
6077 2019-07-17  Tom Tromey  <tom@tromey.com>
6078
6079         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6080         declare.
6081         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6082         Rename from tui_first_reg_element_no_inline.
6083         (tui_display_reg_element_at_line)
6084         (tui_display_registers_from_line): Update.
6085         * tui/tui-data.h (struct tui_data_window)
6086         <first_reg_element_no_inline>: New method.
6087
6088 2019-07-17  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-windata.c (tui_display_data_from)
6091         (tui_data_window::do_scroll_vertical): Update.
6092         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6093         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6094         Rename from tui_line_from_reg_element_no.
6095         (tui_display_registers_from_line): Update.
6096         * tui/tui-data.h (struct tui_data_window)
6097         <line_from_reg_element_no>: New method.
6098
6099 2019-07-17  Tom Tromey  <tom@tromey.com>
6100
6101         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6102         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6103         tui_last_regs_line_no.
6104         (tui_display_reg_element_at_line)
6105         (tui_display_registers_from_line): Update.
6106         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6107         method.
6108
6109 2019-07-17  Tom Tromey  <tom@tromey.com>
6110
6111         PR tui/24722:
6112         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6113         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6114         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6115         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6116         (tui_update_breakpoint_info): Likewise.
6117         * tui/tui-hooks.c (tui_event_create_breakpoint)
6118         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6119         Update.
6120
6121 2019-07-17  Tom Tromey  <tom@tromey.com>
6122
6123         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6124
6125 2019-07-17  Tom Tromey  <tom@tromey.com>
6126
6127         * tui/tui-winsource.c (tui_update_source_window_as_is)
6128         (tui_update_source_windows_with_addr): Update.
6129         * tui/tui-source.h (tui_set_source_content)
6130         (tui_show_symtab_source): Add "win_info" parameter.
6131         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6132         parameter.
6133         (tui_show_symtab_source): Likewise.
6134
6135 2019-07-17  Tom Tromey  <tom@tromey.com>
6136
6137         * tui/tui-wingeneral.c
6138         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6139
6140 2019-07-17  Tom Tromey  <tom@tromey.com>
6141
6142         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6143         (struct tui_cmd_window) <can_scroll>: New method.
6144         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6145         method.
6146
6147 2019-07-17  Tom Tromey  <tromey@adacore.com>
6148
6149         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6150         do_field_signed>: Rename.  Change type of "value".
6151         * ui-out.c (ui_out::field_signed): Rename from field_int.
6152         Change type of "value".
6153         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6154         type of "value".
6155         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6156         do_field_int.  Change type of "value".
6157         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6158         do_field_int.  Change type of "value".
6159         * tracepoint.c (trace_status_mi, tfind_1)
6160         (print_one_static_tracepoint_marker): Update.
6161         * thread.c (print_thread_info_1, print_selected_thread_frame):
6162         Update.
6163         * stack.c (print_frame, print_frame_info): Update.
6164         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6165         Update.
6166         * source.c (print_source_lines_base): Update.
6167         * skip.c (info_skip_command): Update.
6168         * record-btrace.c (btrace_ui_out_decode_error)
6169         (btrace_call_history_src_line): Update.
6170         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6171         Update.
6172         * progspace.c (print_program_space): Update.
6173         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6174         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6175         do_field_int.  Change type of "value".
6176         * mi/mi-out.c (mi_ui_out::do_table_begin)
6177         (mi_ui_out::do_table_header): Update.
6178         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6179         type of "value".
6180         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6181         (mi_cmd_data_list_changed_registers, output_register)
6182         (mi_cmd_data_read_memory, mi_load_progress)
6183         (mi_cmd_trace_frame_collected): Update.
6184         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6185         Update.
6186         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6187         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6188         (mi_cmd_var_list_children, varobj_update_one): Update.
6189         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6190         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6191         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6192         * inferior.c (print_inferior): Update.
6193         * gdb_bfd.c (print_one_bfd): Update.
6194         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6195         Update.
6196         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6197         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6198         do_field_int.  Change type of "value".
6199         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6200         do_field_int.  Change type of "value".
6201         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6202         (print_one_breakpoint_location, print_it_catch_fork)
6203         (print_one_catch_fork, print_it_catch_vfork)
6204         (print_one_catch_vfork, print_it_catch_solib)
6205         (print_it_catch_exec, print_it_ranged_breakpoint)
6206         (print_mention_watchpoint, print_mention_masked_watchpoint)
6207         (bkpt_print_it, update_static_tracepoint): Update.
6208         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6209         * break-catch-syscall.c (print_it_catch_syscall): Update.
6210         * ada-tasks.c (print_ada_task_info): Update.
6211         * ada-lang.c (print_it_exception, print_mention_exception):
6212         Update.
6213
6214 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6215
6216         PR breakpoints/24541
6217         * gdbarch.c: Regenerate.
6218         * gdbarch.h: Regenerate.
6219         * gdbarch.sh: Adjust return type and parameter types for
6220         'stap_adjust_register'.
6221         (i386_stap_adjust_register): Adjust signature and return new
6222         register name.
6223         * stap-probe.c (stap_parse_register_operand): Adjust use of
6224         'gdbarch_stap_adjust_register'.
6225
6226 2019-07-17  Tom Tromey  <tromey@adacore.com>
6227
6228         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6229         declare VEC.
6230         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6231         std::vector.
6232         (struct s390_process_info): Add initializers.
6233         (s390_add_process): Use new.
6234         (s390_linux_nat_target::low_forget_process): Use delete.
6235         (s390_linux_nat_target::low_new_fork)
6236         (s390_linux_nat_target::stopped_by_watchpoint)
6237         (s390_linux_nat_target::low_prepare_to_resume)
6238         (s390_linux_nat_target::insert_watchpoint)
6239         (s390_linux_nat_target::insert_hw_breakpoint)
6240         (s390_linux_nat_target::remove_watchpoint)
6241         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6242
6243 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6244
6245         * aarch64-fbsd-nat.c: Include regcache.h.
6246         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6247         argument.
6248         (aarch64_fbsd_nat_target::fetch_registers)
6249         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6250         variable.
6251         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6252
6253 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6254
6255         * fbsd-nat.c: Include gdbarch.h.
6256
6257 2019-07-15  Tom Tromey  <tromey@adacore.com>
6258
6259         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6260
6261 2019-07-15  Tom Tromey  <tromey@adacore.com>
6262
6263         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6264         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6265         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6266         * cli-out.c (cli_ui_out::do_field_int): New method.
6267         * ui-out.c (ui_out::field_unsigned): New method.
6268         * symfile.c (generic_load): Use field_unsigned.
6269         (print_transfer_performance): Likewise.
6270         * record-btrace.c (ui_out_field_uint): Remove.
6271         (btrace_call_history_insn_range, btrace_call_history): Use
6272         field_unsigned.
6273         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6274         field_unsigned.
6275         * ui-out.h (class ui_out) <field_unsigned>: New method.
6276         <do_field_unsigned>: Likewise.
6277
6278 2019-07-15  Tom Tromey  <tromey@adacore.com>
6279
6280         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6281         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6282         * target.c (flash_erase_command): Use field_string.
6283         * infrun.c (print_signal_received_reason): Use field_string.
6284         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6285         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6286         field_string.
6287         * ada-tasks.c (print_ada_task_info): Use field_string.
6288
6289 2019-07-15  Tom Tromey  <tromey@adacore.com>
6290
6291         * target.c (flash_erase_command): Use field_core_addr.
6292         * symfile.c (generic_load): Use field_core_addr.
6293         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6294         Use field_core_addr.
6295         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6296         field_core_addr.
6297
6298 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6301         value if its desired type is smaller than a CORE_ADDR and signed.
6302
6303 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6304
6305         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6306         of changes to field names, and use new is_reference field to
6307         decide if a property is a reference or not.
6308         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6309         field.
6310         (struct dwarf2_property_baton): Update header comment, rename
6311         'referenced_type' to 'property_type' and update comments.
6312         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6313         default property type, store in property baton, update to take
6314         accound of renamed field.
6315         (read_func_scope): Update call to attr_to_dynamic_prop.
6316         (read_array_type): Likewise.
6317         (dwarf2_per_cu_addr_sized_int_type): New function.
6318         (read_subrange_index_type): Move type finding code to
6319         dwarf2_per_cu_addr_sized_int_type.
6320         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6321         (dwarf2_per_cu_addr_type): New function.
6322         (set_die_type): Update calls to attr_to_dynamic_prop.
6323
6324 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * dwarf2read.c (read_subrange_index_type): New function.
6327         (read_subrange_type): Move code into new function and call it.
6328         * gdbtypes.c (create_range_type): Add some asserts.
6329
6330 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6331
6332         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6333         update return statements.
6334         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6335         declaration, and update comment to match.
6336         * gdbtypes.c (resolve_dynamic_array): Update call to
6337         dwarf2_evaluate_property to match new return type.
6338
6339 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6340
6341         * valarith.c (value_subscripted_rvalue): Change lowerbound
6342         parameter type from int to LONGEST.
6343         * value.h (value_subscripted_rvalue): Likewise in declaration.
6344
6345 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6346
6347         * cli/cli-utils.c (info_print_command_completer): New function.
6348         * cli/cli-utils.h: Add 'completer.h' include, and forward
6349         declaration for 'struct cmd_list_element'.
6350         (info_print_command_completer): Declare.
6351         * stack.c (_initialize_stack): Add completer for 'info locals' and
6352         'info args'.
6353         * symtab.c (_initialize_symtab): Add completer for 'info
6354         variables' and 'info functions'.
6355         * NEWS: Mention completion for additional info commands.
6356
6357 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6358
6359         * cli/cli-utils.c (extract_info_print_args): Delete.
6360         (extract_arg_maybe_quoted): Delete.
6361         (info_print_options_defs): New variable.
6362         (make_info_print_options_def_group): New function.
6363         (extract_info_print_options): Define new function.
6364         * cli/cli-utils.h (extract_info_print_args): Delete.
6365         (struct info_print_options): New structure.
6366         (extract_info_print_options): Declare new function.
6367         * stack.c (info_locals_command): Update to use new
6368         extract_info_print_options, also add a header comment.
6369         (info_args_command): Likewise.
6370         * symtab.c (info_variables_command): Likewise.
6371         (info_functions_command): Likewise.
6372
6373 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6374
6375         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6376         to extract string arguments.
6377         * common/common-utils.c (extract_string_maybe_quoted): New function.
6378         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6379
6380 2019-07-11  Tom Tromey  <tromey@adacore.com>
6381
6382         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6383         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6384         * top.h (gdbinit): Don't declare.
6385         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6386         into...
6387         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6388         * top.c (gdb_init): Don't call init_cli_cmds.
6389         (gdbinit): Remove.
6390         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6391
6392 2019-07-11  Tom Tromey  <tromey@adacore.com>
6393
6394         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6395         after it has been moved.
6396
6397 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6398
6399         * valops.c (value_must_coerce_to_target): Change return type to
6400         bool.
6401         * value.h (value_must_coerce_to_target): Likewise.
6402
6403 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6404
6405         * breakpoint.c (is_hardware_watchpoint): Remove
6406         forward-declaration.
6407         (is_masked_watchpoint): Change return type to bool.
6408         (is_tracepoint): Likewise.
6409         (is_breakpoint): Likewise.
6410         (is_hardware_watchpoint): Likewise.
6411         (is_watchpoint): Likewise.
6412         (is_no_memory_software_watchpoint): Likewise.
6413         (is_catchpoint): Likewise.
6414         (breakpoint_1): Make FILTER parameter's return type bool.
6415         is_masked_watchpoint): Change return type to bool.
6416         (save_breakpoints): Make FILTER parameter's return type bool.
6417         * breakpoint.h (is_breakpoint): Change return type to bool.
6418         (is_watchpoint): Likewise.
6419         (is_catchpoint): Likewise.
6420         (is_tracepoint): Likewise.
6421
6422 2019-07-10  Tom Tromey  <tom@tromey.com>
6423
6424         * defs.h: Don't include gdbarch.h.
6425         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6426         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6427         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6428         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6429         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6430         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6431         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6432         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6433         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6434         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6435         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6436         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6437         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6438         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6439         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6440         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6441         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6442         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6443         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6444         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6445         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6446         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6447         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6448         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6449         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6450         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6451         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6452
6453 2019-07-10  Tom Tromey  <tromey@adacore.com>
6454
6455         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6456         * breakpoint.c (init_ada_exception_breakpoint): Register as
6457         bp_catchpoint.
6458         (print_one_breakpoint_location, print_one_breakpoint): Use
6459         is_ada_exception_catchpoint.
6460         * ada-lang.c (class ada_catchpoint_location): Pass
6461         bp_loc_software_breakpoint to bp_location constructor.
6462         (is_ada_exception_catchpoint): New function.
6463
6464 2019-07-10  Tom Tromey  <tromey@adacore.com>
6465
6466         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6467         VEC.
6468         (struct arm_exidx_entry): New method operator<.
6469         (struct arm_exidx_data) <section_maps>: Change type.
6470         (arm_exidx_data_free): Remove.
6471         (arm_exidx_data_key): Change type.  Move lower.
6472         (arm_exidx_new_objfile): Update.
6473         (arm_compare_exidx_entries): Remove.
6474         (arm_find_exidx_entry, _initialize_arm_tdep)
6475
6476 2019-07-10  Tom Tromey  <tromey@adacore.com>
6477
6478         * solib-spu.c (ocl_program_data_key): Change type.
6479         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6480         Update.
6481
6482 2019-07-10  Tom Tromey  <tromey@adacore.com>
6483
6484         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6485         (struct solib_aix_inferior_data) <library_list>: Change type.
6486         (solib_aix_inferior_data_handle): Change type.
6487         (get_solib_aix_inferior_data): Update.
6488         (solib_aix_free_library_list): Remove.
6489         (library_list_start_library): Update.
6490         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6491         return type.
6492         (solib_aix_get_library_list)
6493         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6494         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6495
6496 2019-07-10  Tom Tromey  <tromey@adacore.com>
6497
6498         * solib-dsbt.c (struct dsbt_info): Add initializers.
6499         (solib_dsbt_pspace_data): Change type.
6500         (dsbt_pspace_data_cleanup): Remove.
6501         (get_dsbt_info, _initialize_dsbt_solib): Update.
6502
6503 2019-07-10  Tom Tromey  <tromey@adacore.com>
6504
6505         * spu-tdep.c (spu_overlay_data): Change type.
6506         (spu_get_overlay_table, spu_overlay_new_objfile)
6507         (_initialize_spu_tdep): Update.
6508
6509 2019-07-10  Tom Tromey  <tromey@adacore.com>
6510
6511         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6512         destructor.
6513         (dbx_objfile_data_key): Change type and declare later.
6514         (DBX_SYMFILE_INFO): Rewrite.
6515         * dbxread.c (dbx_objfile_data_key): Change type.
6516         (dbx_symfile_init): Update.
6517         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6518         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6519         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6520
6521 2019-07-10  Tom Tromey  <tromey@adacore.com>
6522
6523         * jit.c (jit_program_space_key): Change type.  Move lower.
6524         (get_jit_program_space_data): Update.
6525         (jit_program_space_data_cleanup): Remove.
6526         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6527         Update.
6528         (struct jit_program_space_data): Add initializers.
6529
6530 2019-07-10  Tom Tromey  <tromey@adacore.com>
6531
6532         * solib-darwin.c (struct darwin_info): Add initializers.
6533         (solib_darwin_pspace_data): Change type.
6534         (darwin_pspace_data_cleanup): Remove.
6535         (get_darwin_info, _initialize_darwin_solib): Update.
6536
6537 2019-07-10  Tom Tromey  <tromey@adacore.com>
6538
6539         * remote-sim.c (struct sim_inferior_data): Add initializers,
6540         constructor, and destructor.
6541         (sim_inferior_data_key): Change type.  Move lower.
6542         (check_for_duplicate_sim_descriptor): Update.
6543         (get_sim_inferior_data): Use new.  Update.
6544         (~sim_inferior_data_cleanup): Rename from
6545         sim_inferior_data_cleanup.  Simplify.
6546         (gdbsim_close_inferior, simulator_command)
6547         (sim_command_completer, _initialize_remote_sim): Update.
6548         (next_pid, INITIAL_PID): Move earlier.
6549
6550 2019-07-10  Tom Tromey  <tromey@adacore.com>
6551
6552         * python/python-internal.h (create_thread_object): Return
6553         gdbpy_ref.
6554         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6555         * python/py-inferior.c (struct threadlist_entry): Add
6556         constructor.
6557         <thread_obj>: Now a gdbpy_ref.
6558         (thread_to_thread_object): Update.
6559         (add_thread_object): Use new.
6560         (delete_thread_object): Use delete.
6561         (infpy_threads): Update.
6562         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6563         GIL.
6564
6565 2019-07-10  Tom Tromey  <tromey@adacore.com>
6566
6567         * valops.c (value_cast): Specialize error message for Ada.
6568
6569 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6570
6571         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6572
6573 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6574
6575         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6576         bpstat_should_step): Return bool, adjust comments.
6577         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6578         bpstat_should_step): Likewise.
6579
6580 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6581
6582         * features/Makefile: Use feature target descriptions for Arm.
6583         * features/arm/arm-core.c: Generate new file.
6584         * features/arm/arm-fpa.c: Likewise.
6585         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6586         * features/arm/arm-m-profile.c: Likewise.
6587         * features/arm/arm-vfpv2.c: Likewise.
6588         * features/arm/arm-vfpv3.c: Likewise.
6589         * features/arm/xscale-iwmmxt.c: Likewise.
6590         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6591
6592 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6593
6594         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6595         ptrace earlier.
6596
6597 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6598
6599         * features/aarch64-pauth.c: Regenerate.
6600
6601 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6602
6603         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6604         bool.
6605         (bpstat_what): Use false instead of 0.
6606
6607 2019-07-09  Pedro Alves  <palves@redhat.com>
6608
6609         * break-catch-throw.c (is_exception_catchpoint): New.
6610         * breakpoint.c (print_one_breakpoint_location): New parameter
6611         'raw_loc'.  Handle it.  Use
6612         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6613         looking at the breakpoint's type.
6614         (print_one_breakpoint): If handling "maint info breakpoints", also
6615         print locations of exception catchpoints.
6616         * breakpoint.h (is_exception_catchpoint): Declare.
6617
6618 2019-07-09  Pedro Alves  <palves@redhat.com>
6619
6620         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6621         "addr" field.
6622         (allocate_location_exception_catchpoint): New.
6623         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6624         (initialize_throw_catchpoint_ops): Install
6625         allocate_location_exception_catchpoint as allocate_location
6626         method.
6627         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6628         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6629         bp_loc_other.
6630         (breakpoint_address_is_meaningful): Delete.
6631         (bl_address_is_meaningful): New.
6632         (breakpoint_locations_match): Adjust comment.
6633         (bp_location_from_bp_type): New, factored out of...
6634         (bp_location::bp_location(breakpoint *)): ... this.
6635         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6636         factored out of...
6637         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6638         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6639         breakpoint_address_is_meaningful.
6640         (bp_locations_compare): Adjust comment.
6641         (update_global_location_list): Use bl_address_is_meaningful
6642         instead of breakpoint_address_is_meaningful.
6643         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6644         explicit.
6645         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6646         * python/py-breakpoint.c (bppy_get_location): No longer check
6647         whether location is null.
6648
6649 2019-07-09  Pedro Alves  <palves@redhat.com>
6650
6651         PR c++/15468
6652         * breakpoint.c (print_one_breakpoint_location): Remove
6653         single-location assert.
6654
6655 2019-07-09  Tom Tromey  <tom@tromey.com>
6656
6657         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6658         * configure: Rebuild.
6659         * configure.ac: Change common to gdbsupport.
6660         * gdbsupport: Rename from common.
6661         * acinclude.m4: Change common to gdbsupport.
6662         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6663         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6664         gdbsupport.
6665         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6666         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6667         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6668         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6669         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6670         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6671         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6672         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6673         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6674         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6675         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6676         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6677         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6678         coff-pe-read.c, command.h, compile/compile-c-support.c,
6679         compile/compile-c.h, compile/compile-cplus-symbols.c,
6680         compile/compile-cplus-types.c, compile/compile-cplus.h,
6681         compile/compile-loc2c.c, compile/compile.c, completer.c,
6682         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6683         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6684         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6685         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6686         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6687         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6688         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6689         features/aarch64-core.c, features/aarch64-fpu.c,
6690         features/aarch64-pauth.c, features/aarch64-sve.c,
6691         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6692         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6693         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6694         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6695         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6696         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6697         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6698         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6699         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6700         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6701         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6702         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6703         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6704         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6705         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6706         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6707         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6708         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6709         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6710         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6711         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6712         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6713         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6714         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6715         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6716         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6717         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6718         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6719         minsyms.c, mips-linux-tdep.c, namespace.h,
6720         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6721         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6722         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6723         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6724         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6725         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6726         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6727         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6728         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6729         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6730         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6731         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6732         procfs.c, producer.c, progspace.h, psymtab.h,
6733         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6734         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6735         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6736         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6737         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6738         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6739         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6740         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6741         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6742         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6743         target-memory.c, target.c, target.h, target/waitstatus.c,
6744         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6745         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6746         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6747         unittests/array-view-selftests.c,
6748         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6749         unittests/common-utils-selftests.c,
6750         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6751         unittests/format_pieces-selftests.c,
6752         unittests/function-view-selftests.c,
6753         unittests/lookup_name_info-selftests.c,
6754         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6755         unittests/mkdir-recursive-selftests.c,
6756         unittests/observable-selftests.c,
6757         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6758         unittests/parse-connection-spec-selftests.c,
6759         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6760         unittests/scoped_fd-selftests.c,
6761         unittests/scoped_mmap-selftests.c,
6762         unittests/scoped_restore-selftests.c,
6763         unittests/string_view-selftests.c, unittests/style-selftests.c,
6764         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6765         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6766         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6767         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6768         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6769         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6770
6771 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6772
6773         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6774         bool value.
6775         (decode_digits_ordinary): Set explicit_line field in sal.
6776         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6777         symtab_and_line that was set on an explicit line number in
6778         assembler code.  Do always update the recorded symtab and line if
6779         we do skip the prologue.
6780
6781 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6782
6783         * breakpoint.c (set_breakpoint_location_function): Remove
6784         explicit_loc parameter.
6785         (momentary_breakpoint_from_master): Update call to
6786         set_breakpoint_location_function.
6787         (add_location_to_breakpoint): Likewise.
6788
6789 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6790
6791         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6792         required features based on default bfd type when no specific bfd
6793         is present.
6794
6795 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6796
6797         * NEWS: Mention that GDB printf and eval commands can now print
6798         C-style and Ada-style convenience var strings without
6799         calling the inferior.
6800         * printcmd.c (printf_c_string): Locally print GDB internal var
6801         instead of transiting via the inferior.
6802         (printf_wide_c_string): Likewise.
6803
6804 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6805
6806         PR breakpoints/25011
6807         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6808
6809 2019-07-04  Tom Tromey  <tom@tromey.com>
6810
6811         PR tui/24724:
6812         * tui/tui-winsource.c (tui_clear_source_content): Update.
6813         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6814         (tui_update_breakpoint_info): Update.
6815         (tui_set_exec_info_content): Update.
6816         * tui/tui-source.c (tui_set_source_content_nil): Update.
6817         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6818         has_break.
6819         * tui/tui-data.h (enum tui_bp_flag): New.
6820         (tui_bp_flags): New enum flags type.
6821         (struct tui_source_element) <break_mode>: Change type.  Rename
6822         from has_break.
6823         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6824         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6825         constants.
6826         * tui/tui-winsource.h: Fix comment.
6827
6828 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6829
6830         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6831         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6832         (store_fpregs_to_thread)
6833         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6834         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6835         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6836         (IWMMXT_REGS_SIZE): Add define.
6837         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6838         (fetch_vfp_regs, store_vfp_regs)
6839         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6840         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6841
6842 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6843
6844         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6845         defines.
6846         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6847         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6848         (ARM_INT_REGISTER_SIZE): ...to this.
6849         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6850         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6851         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6852         (arm_linux_collect_gregset, supply_nwfpe_register)
6853         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6854         defines.
6855         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6856         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6857         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6858         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6859         (arm_return_in_memory, arm_store_return_value)
6860         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6861         (arm_record_ld_st_multiple): Likewise.
6862         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6863         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6864
6865 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6866
6867         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6868         AARCH64_DISPLACED_MODIFIED_INSNS.
6869         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6870         (aarch64_displaced_step_copy_insn): Likewise.
6871         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6872         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6873         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6874         ARM_DISPLACED_MODIFIED_INSNS.
6875         * arm-tdep.c (arm_gdbarch_init): Likewise.
6876         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6877         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6878         (struct arm_displaced_step_closure): Use
6879         ARM_DISPLACED_MODIFIED_INSNS.
6880
6881 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6882
6883         * features/Makefile: Remove unused xml files.
6884         * features/aarch64.xml: Remove.
6885         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6886         * features/i386/amd64-avx-avx512.xml: Remove.
6887         * features/i386/amd64-avx-linux.xml: Remove.
6888         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6889         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6890         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6891         * features/i386/amd64-avx-mpx.xml: Remove.
6892         * features/i386/amd64-avx.xml: Remove.
6893         * features/i386/amd64-linux.xml: Remove.
6894         * features/i386/amd64-mpx-linux.xml: Remove.
6895         * features/i386/amd64-mpx.xml: Remove.
6896         * features/i386/amd64.xml: Remove.
6897         * features/i386/i386-avx-avx512-linux.xml: Remove.
6898         * features/i386/i386-avx-avx512.xml: Remove.
6899         * features/i386/i386-avx-linux.xml: Remove.
6900         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6901         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6902         * features/i386/i386-avx-mpx-linux.xml: Remove.
6903         * features/i386/i386-avx-mpx.xml: Remove.
6904         * features/i386/i386-avx.xml: Remove.
6905         * features/i386/i386-linux.xml: Remove.
6906         * features/i386/i386-mmx-linux.xml: Remove.
6907         * features/i386/i386-mmx.xml: Remove.
6908         * features/i386/i386-mpx-linux.xml: Remove.
6909         * features/i386/i386-mpx.xml: Remove.
6910         * features/i386/i386.xml: Remove.
6911         * features/i386/x32-avx-avx512-linux.xml: Remove.
6912         * features/i386/x32-avx-linux.xml: Remove.
6913         * features/i386/x32-linux.xml: Remove.
6914
6915 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6916
6917         * regformats/aarch64.dat: Remove.
6918         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6919         * regformats/i386/amd64-avx-linux.dat: Remove.
6920         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6921         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6922         * regformats/i386/amd64-linux.dat: Remove.
6923         * regformats/i386/amd64-mpx-linux.dat: Remove.
6924         * regformats/i386/amd64.dat: Remove.
6925         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6926         * regformats/i386/i386-avx-linux.dat: Remove.
6927         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6928         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6929         * regformats/i386/i386-linux.dat: Remove.
6930         * regformats/i386/i386-mmx-linux.dat: Remove.
6931         * regformats/i386/i386-mpx-linux.dat: Remove.
6932         * regformats/i386/i386.dat: Remove.
6933         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6934         * regformats/i386/x32-avx-linux.dat: Remove.
6935         * regformats/i386/x32-linux.dat: Remove.
6936
6937 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6938
6939         * aarch64-tdep.c: Remove xml self tests.
6940         * amd64-linux-tdep.c: Likewise.
6941         * amd64-tdep.c: Likewise.
6942         * i386-linux-tdep.c: Likewise.
6943         * i386-tdep.c: Likewise.
6944
6945 2019-07-03  Pedro Alves  <palves@redhat.com>
6946
6947         PR cli/24732
6948         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6949         (pipe_cmd_option_defs): New.
6950         (make_pipe_cmd_options_def_group): New.
6951         (pipe_command): Use gdb::option::process_options.
6952         (pipe_command_completer): New function.
6953         (_initialize_cli_cmds): Install completer for "pipe" command.
6954
6955 2019-07-03  Pedro Alves  <palves@redhat.com>
6956
6957         * cli/cli-option.c (union option_value) <string>: New field.
6958         (struct option_def_and_value): Add ctor, move ctor, dtor and
6959         use DISABLE_COPY_AND_ASSIGN.
6960         (option_def_and_value::clear_value): New.
6961         (parse_option, save_option_value_in_ctx, get_val_type_str)
6962         (add_setshow_cmds_for_options): Handle var_string.
6963         * cli-option.h (union option_def::var_address) <string>: New
6964         field.
6965         (struct string_option_def): New.
6966         * maint-test-options.c (struct test_options_opts): Add default
6967         ctor and use DISABLE_COPY_AND_ASSIGN.
6968         <string_opt>: New field.
6969         (test_options_opts::~test_options_opts): New.
6970         (test_options_opts::dump): Also dump "-string".
6971         (test_options_option_defs): Install "string.
6972
6973 2019-07-03  Pedro Alves  <palves@redhat.com>
6974
6975         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6976         option_value with a null enumeration.
6977         (complete_options): Save the option values in the context.
6978         (save_option_value_in_ctx): New, factored out from ...
6979         (process_options): ... here.
6980         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6981         of the function.
6982         * maint-test-options.c (test_options_opts::dump): New, factored
6983         out from ...
6984         (maintenance_test_options_command_mode): ... here.
6985         (maintenance_test_options_command_completion_result): Delete.
6986         (maintenance_test_options_command_completion_text): Update
6987         comment.
6988         (maintenance_show_test_options_completion_result): Change
6989         prototype.  Just print
6990         maintenance_test_options_command_completion_text.
6991         (save_completion_result): New.
6992         (maintenance_test_options_completer_mode): Pass options context to
6993         complete_options, and then save a dump.
6994         (_initialize_maint_test_options): Use add_cmd to install "maint
6995         show test-options-completion-result".
6996
6997 2019-07-03  Pedro Alves  <palves@redhat.com>
6998
6999         * NEWS (New commands): Mention "with" and "maint with".
7000         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7001         (with_command, with_command_completer): New.
7002         (pipe_command): Adjust to new repeat_previous
7003         interface.
7004         (_initialize_cli_cmds): Install the "with" command and its "w"
7005         alias.
7006         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7007         declarations.
7008         * cli/cli-setshow.c (parse_cli_var_uinteger)
7009         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7010         argument strings for all var_types.
7011         (get_setshow_command_value_string): New, factored out from ...
7012         (do_show_command): ... this.
7013         * cli/cli-setshow.h: Include <string>.
7014         (get_setshow_command_value_string): Declare.
7015         * command.h (repeat_previous): Now returns const char *.  Adjust
7016         comment.
7017         * maint.c: Include "cli/cli-cmds.h".
7018         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7019         (_initialize_maint_cmds): Register the "maintenance with" command.
7020         * top.c (repeat_previous): Move bits from pipe_command here:
7021         Return the saved command line, if any; error out if there's no
7022         command to relaunch.
7023
7024 2019-07-03  Pedro Alves  <palves@redhat.com>
7025
7026         * NEWS (New commands): Mention "maint set/show test-settings"
7027         instead of "maint test-settings".
7028         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7029         (maintenance_test_settings_set_list): Rename to ...
7030         (maintenance_set_test_settings_list): ... this.
7031         (maintenance_test_settings_show_list): Rename to  ...
7032         (maintenance_show_test_settings_list): ... this.
7033         (maintenance_test_settings_cmd): Delete.
7034         (maintenance_test_settings_set_cmd): ...
7035         (maintenance_set_test_settings_cmd): ... this.
7036         (maintenance_test_settings_show_cmd): ...
7037         (maintenance_show_test_settings_cmd): ... this.
7038         (maintenance_test_settings_show_value_cmd):
7039         (maintenance_show_test_settings_value_cmd): ... this.
7040         (_initialize_maint_test_settings): No longer install the "maint
7041         test-settings" prefix command.  Rename "maint test-settings set"
7042         to "maint set test-settings", and "maint test-settings show" to
7043         "maint show test-settings".  Adjust all subcommands.
7044
7045 2019-07-03  Pedro Alves  <palves@redhat.com>
7046
7047         * maint-test-settings.c: Fix file's intro comment.  Replace all
7048         references to "test-options" with references to "test-settings",
7049         in comments.
7050
7051 2019-07-03  Pedro Alves  <palves@redhat.com>
7052
7053         * maint-test-settings.c (maintenance_test_settings_xxx)
7054         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7055         New.
7056         (maintenance_test_settings_enums): Use them.
7057         (maintenance_test_settings_enum): Default to
7058         maintenance_test_settings_xxx.
7059         (_initialize_maint_test_settings): Initialize
7060         MAINTENANCE_TEST_SETTINGS_FILENAME.
7061
7062 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7063
7064         * breakpoint.h (remove_breakpoints_inf): Change return type to
7065         void, move function documentation here.
7066         * breakpoint.c (remove_breakpoints_inf): Change return type to
7067         void, move function documentation to header.
7068
7069 2019-07-02  Pedro Alves  <palves@redhat.com>
7070
7071         * NEWS (Completion improvements): Mention "info threads".
7072         * thread.c (struct info_threads_opts, info_threads_option_defs)
7073         (make_info_threads_options_def_group): New.
7074         (info_threads_command): Use gdb::option::process_options.
7075         (info_threads_command_completer): New.
7076         (_initialize_thread): Use gdb::option::build_help to build the
7077         help text for "info threads".
7078
7079 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7080
7081         * defs.h (generic_load): Move from here...
7082         * symfile.h (generic_load): ... to here.  Rename name parameter
7083         to args.
7084         * symfile.c (generic_load): Add comment.
7085
7086 2019-07-01  Tom Tromey  <tromey@adacore.com>
7087
7088         * dwarf2read.c
7089         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7090         declaration of without_params.  Fix formatting.
7091
7092 2019-07-01  Tom Tromey  <tromey@adacore.com>
7093
7094         * ada-exp.y (find_primitive_type): Update.
7095         * ada-lang.h (ada_lookup_symbol): Update.
7096         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7097         parameter.
7098         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7099
7100 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7101
7102         PR breakpoints/24541
7103         * gdbarch.c: Regenerate.
7104         * gdbarch.h: Regenerate.
7105         * gdbarch.sh: Add 'stap_adjust_register'.
7106         * i386-tdep.c: Include '<unordered_set>'.
7107         (i386_stap_adjust_register): New function.
7108         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7109         * stap-probe.c (stap_parse_register_operand): Call
7110         'gdbarch_stap_adjust_register'.
7111
7112 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7113
7114         PR python/24742
7115         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7116         * python/python.c (do_start_initialization): Use 'xmalloc'
7117         instead of 'PyMem_Malloc'.
7118
7119 2019-06-28  Tom Tromey  <tromey@adacore.com>
7120
7121         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7122         for Ada.
7123
7124 2019-06-27  Tom Tromey  <tromey@adacore.com>
7125
7126         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7127         objfile_key.
7128         (arm_find_mapping_symbol, arm_record_special_symbol)
7129         (_initialize_arm_tdep): Update.
7130         (arm_objfile_data_free): Remove.
7131
7132 2019-06-27  Tom Tromey  <tromey@adacore.com>
7133
7134         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7135         to cp_print_static_field.
7136
7137 2019-06-26  Tom Tromey  <tromey@adacore.com>
7138
7139         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7140         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7141         declare.
7142
7143 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7144
7145         * features/aarch64-core.c (create_feature_aarch64_core):
7146         Regenerate.
7147         * features/aarch64-core.xml: Add cpsr flags.
7148
7149 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7150
7151         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7152         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7153
7154 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7155
7156         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7157         field.
7158         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7159         use.
7160         (arm_record_special_symbol): Don't insert new symbol in sorted
7161         position, push it at the end.
7162
7163 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7164
7165         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7166         (arm_mapping_symbol_s): Remove.
7167         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7168         (arm_mapping_symbol_vec): New typedef.
7169         (struct arm_per_objfile): Add constructor.
7170         <section_maps>: Change type to
7171         std::unique_ptr<arm_mapping_symbol_vec[]>.
7172         (arm_compare_mapping_symbols): Remove.
7173         (arm_find_mapping_symbol): Adjust to section_maps type change.
7174         (arm_objfile_data_free): Call delete on arm_per_objfile.
7175         (arm_record_special_symbol): Adjust to section_maps type change.
7176         Allocate arm_per_objfile with new.
7177
7178 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7179
7180         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7181         with the command prefix.
7182
7183 2019-06-25  Tom Tromey  <tom@tromey.com>
7184
7185         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7186         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7187
7188 2019-06-25  Tom Tromey  <tom@tromey.com>
7189
7190         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7191         type.
7192         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7193         protected.
7194
7195 2019-06-25  Tom Tromey  <tom@tromey.com>
7196
7197         * tui/tui-winsource.c
7198         (tui_source_window_base::set_is_exec_point_at): Add check against
7199         LOA_ADDRESS.
7200
7201 2019-06-25  Tom Tromey  <tom@tromey.com>
7202
7203         * tui/tui-source.c (tui_set_source_content): Don't check before
7204         xfree.
7205         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7206
7207 2019-06-25  Tom Tromey  <tom@tromey.com>
7208
7209         * tui/tui-winsource.h (tui_update_source_window_as_is)
7210         (tui_alloc_source_buffer, tui_line_is_displayed)
7211         (tui_addr_is_displayed): Change type of win_info.
7212         * tui/tui-winsource.c (tui_update_source_window_as_is)
7213         (tui_clear_source_content, tui_show_source_line)
7214         (tui_show_source_content, tui_source_window_base::refill)
7215         (tui_source_window_base::set_is_exec_point_at)
7216         (tui_source_window_base::set_is_exec_point_at)
7217         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7218         (tui_alloc_source_buffer, tui_line_is_displayed)
7219         (tui_addr_is_displayed): Change type of win_info.  Update.
7220         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7221         (tui_source_window_base::do_make_visible_with_new_height):
7222         Update.
7223         * tui/tui-source.c (tui_set_source_content)
7224         (tui_set_source_content_nil)
7225         (tui_source_window::do_scroll_vertical): Update.
7226         * tui/tui-layout.c (show_layout): Update.
7227         * tui/tui-disasm.c (tui_set_disassem_content)
7228         (tui_disasm_window::do_scroll_vertical): Update.
7229         * tui/tui-data.h (tui_win_content): Remove.
7230         (struct tui_gen_win_info) <content, content_size>: Remove.
7231         (struct tui_source_element): Add initializers and destructor.
7232         (union tui_which_element, struct tui_win_element): Remove.
7233         (struct tui_source_window_base) <content>: New field.
7234         (struct tui_data_window): Remove destructor.
7235         (tui_alloc_content, tui_free_win_content)
7236         (tui_free_all_source_wins_content): Don't declare.
7237         * tui/tui-data.c (tui_initialize_static_data): Update.
7238         (init_content_element, tui_alloc_content): Remove.
7239         (~tui_gen_win_info): Update.
7240         (~tui_data_window, tui_free_all_source_wins_content)
7241         (tui_free_win_content, free_content, free_content_elements):
7242         Remove.
7243
7244 2019-06-25  Tom Tromey  <tom@tromey.com>
7245
7246         * tui/tui-winsource.h (tui_clear_source_content)
7247         (tui_erase_source_content, tui_show_source_content): Change type
7248         of win_info.
7249         * tui/tui-winsource.c (tui_clear_source_content)
7250         (tui_erase_source_content, tui_show_source_content): Change type
7251         of win_info.
7252         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7253         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7254         win_info.
7255         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7256         win_info.
7257         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7258
7259 2019-06-25  Tom Tromey  <tom@tromey.com>
7260
7261         * tui/tui-winsource.c (tui_clear_source_content)
7262         (tui_source_window_base::set_is_exec_point_at): Update.
7263         * tui/tui-source.c (tui_set_source_content_nil): Update.
7264         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7265         a bool.
7266         * tui/tui-data.c (init_content_element): Update.
7267
7268 2019-06-25  Tom Tromey  <tom@tromey.com>
7269
7270         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7271         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7272         * tui/tui-layout.c (init_and_make_win): Update.
7273         * tui/tui.h (enum tui_win_type): Update.
7274         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7275         tui_win_is_auxillary.
7276         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7277         tui_win_is_auxillary.
7278
7279 2019-06-25  Tom Tromey  <tom@tromey.com>
7280
7281         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7282         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7283         (tui_delete_data_content_windows, tui_display_all_data)
7284         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7285         Update.
7286         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7287         * tui/tui-regs.c (tui_last_regs_line_no)
7288         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7289         (tui_show_registers): Update.
7290         (tui_show_register_group): Return void.  Update.
7291         (tui_display_registers_from, tui_display_reg_element_at_line)
7292         (tui_display_registers_from_line, tui_check_register_values):
7293         Update.
7294         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7295         member.
7296         (struct tui_data_window) <regs_content>: Now a std::vector.
7297         <regs_content_count>: Remove.
7298         (tui_add_content_elements, tui_free_data_content): Don't declare.
7299         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7300         (init_content_element): Remove DATA_WIN case.  Add assert.
7301         (tui_add_content_elements): Remove.
7302         (tui_data_window): Update.
7303         (tui_free_data_content): Remove.
7304         (free_content_elements): Remove DATA_WIN case.
7305
7306 2019-06-25  Tom Tromey  <tom@tromey.com>
7307
7308         * tui/tui-data.c (tui_data_item_window): Update.
7309         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7310         * tui/tui-windata.c (tui_display_all_data)
7311         (tui_display_data_from_line): Update.
7312         (tui_check_data_values): Remove.
7313         * tui/tui-regs.c (tui_show_register_group)
7314         (tui_display_reg_element_at_line): Update.
7315         * tui/tui-hooks.c (tui_register_changed)
7316         (tui_refresh_frame_and_register_information): Call
7317         tui_check_register_values.
7318         * tui/tui-data.h (struct tui_data_window) <data_content,
7319         data_content_count, data_type>: Remove.
7320         (enum tui_data_type): Remove.
7321
7322         * tui/tui-data.c (tui_data_window::clear_detail)
7323         (~tui_data_window): Update.
7324
7325 2019-06-25  Tom Tromey  <tom@tromey.com>
7326
7327         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7328         declare.
7329         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7330         Rename from tui_first_data_item_displayed.  Update.
7331         (tui_data_window::refresh_all)
7332         (tui_data_window::do_scroll_vertical): Update.
7333         * tui/tui-data.h (struct tui_data_window)
7334         <first_data_item_displayed>: Declare new method.
7335
7336 2019-06-25  Tom Tromey  <tom@tromey.com>
7337
7338         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7339         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7340         contents...
7341         (tui_initialize_static_data): ...here.
7342
7343 2019-06-25  Tom Tromey  <tom@tromey.com>
7344
7345         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7346         (tui_display_registers_from, tui_check_register_values): Update.
7347         (tui_display_register): Remove win_info parameter; update.
7348         (tui_get_register): Change type of parameters.
7349         * tui/tui-data.h (struct tui_data_element): Remove.
7350         (union tui_which_element) <data>: Remove.
7351         <data_window>: Change type.
7352         (struct tui_data_item_window): New.
7353         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7354         case.  Add assert.
7355         (~tui_data_item_window): New destructor.
7356         (free_content_elements): Remove DATA_ITEM_WIN case.
7357
7358 2019-06-25  Tom Tromey  <tom@tromey.com>
7359
7360         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7361         Remove.
7362
7363 2019-06-25  Tom Tromey  <tom@tromey.com>
7364
7365         * tui/tui-data.h (struct tui_command_element): Remove.
7366         (union tui_which_element) <command>: Remove.
7367         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7368         assert.
7369         (free_content_elements): Remove CMD_WIN case.
7370
7371 2019-06-25  Tom Tromey  <tom@tromey.com>
7372
7373         * tui/tui-layout.c (tui_set_layout): Update.
7374         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7375         * tui/tui-data.c (layout_def): Update.
7376
7377 2019-06-25  Tom Tromey  <tom@tromey.com>
7378
7379         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7380         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7381         (tui_source_window_base::set_new_height): Update.
7382         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7383         Update.
7384         (tui_set_locator_fullname, tui_set_locator_info)
7385         (tui_show_frame_info): Update.
7386         * tui/tui-source.c (tui_set_source_content)
7387         (tui_source_is_displayed): Update.
7388         * tui/tui-layout.c (show_source_disasm_command, show_data)
7389         (show_source_or_disasm_and_command): Update.
7390         * tui/tui-disasm.c (tui_set_disassem_content)
7391         (tui_get_begin_asm_address): Update.
7392         * tui/tui-data.h (struct tui_locator_element): Remove.
7393         (union tui_which_element) <locator>: Remove.
7394         (struct tui_locator_window): New.
7395         (tui_locator_win_info_ptr): Change return type.
7396         * tui/tui-data.c (_locator): Change type.
7397         (tui_locator_win_info_ptr): Change return type.
7398         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7399         (tui_alloc_content): Add assert.
7400
7401 2019-06-25  Tom Tromey  <tom@tromey.com>
7402
7403         * tui/tui-winsource.c
7404         (tui_exec_info_window::maybe_allocate_content): New method.
7405         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7406         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7407         (make_source_or_disasm_window): Add cast.
7408         * tui/tui-data.h (union tui_which_element) <simple_string>:
7409         Remove.
7410         (struct tui_source_info): New.
7411         (struct tui_source_window_base) <execution_info>: Change type.
7412         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7413         case, and add assert.
7414         (tui_alloc_content): Add assert.
7415
7416 2019-06-25  Tom Tromey  <tom@tromey.com>
7417
7418         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7419         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7420         * tui/tui-data.c (tui_alloc_win_info): Remove.
7421
7422 2019-06-25  Tom Tromey  <tom@tromey.com>
7423
7424         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7425         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7426         can_highlight.
7427
7428 2019-06-25  Tom Tromey  <tom@tromey.com>
7429
7430         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7431         make_visible_with_new_height method.
7432         (tui_win_info::make_visible_with_new_height): New method.
7433         (tui_source_window_base::do_make_visible_with_new_height)
7434         (tui_data_window::do_make_visible_with_new_height)
7435         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7436         (make_visible_with_new_height): Remove.
7437         (tui_resize_all, tui_adjust_win_heights): Use
7438         make_visible_with_new_height method.
7439         * tui/tui-data.h (struct tui_win_info)
7440         <do_make_visible_with_new_height, make_visible_with_new_height>:
7441         New methods.
7442         (struct tui_source_window_base, struct tui_data_window)
7443         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7444         methods.
7445
7446 2019-06-25  Tom Tromey  <tom@tromey.com>
7447
7448         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7449         method.
7450         (update_tab_width): Call update_tab_width method.
7451         * tui/tui-data.h (struct tui_win_info)
7452         (struct tui_source_window_base) <update_tab_width>: New methods.
7453
7454 2019-06-25  Tom Tromey  <tom@tromey.com>
7455
7456         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7457         parameter.
7458         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7459         parameter.
7460         (tui_gen_win_info::make_visible): Update.
7461         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7462         parameter.
7463         * tui/tui-data.h (enum tui_box): New enum.
7464         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7465
7466 2019-06-25  Tom Tromey  <tom@tromey.com>
7467
7468         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7469         init_and_make_win for EXEC_INFO_WIN.
7470         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7471         longer inline.
7472         (struct tui_win_info) <~tui_win_info>: Inline.
7473         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7474         Don't declare.
7475         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7476         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7477         Remove.
7478         (tui_initialize_static_data): Update.
7479         (~tui_gen_win_info): Handle more cleanup here.
7480         (~tui_source_window_base): Delete "execution_info".
7481         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7482
7483 2019-06-25  Tom Tromey  <tom@tromey.com>
7484
7485         * tui/tui-layout.c (make_command_window): Don't set
7486         can_highlight.
7487         (show_source_disasm_command): Call the reset method.
7488         (show_data): Don't set can_highlight.  Call the reset method.
7489         (tui_gen_win_info::reset): Rename from init_gen_win_info
7490         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7491         (show_source_or_disasm_and_command): Call the reset method.
7492         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7493         (struct tui_cmd_window): Set can_highlight.
7494
7495 2019-06-25  Tom Tromey  <tom@tromey.com>
7496
7497         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7498         from make_visible.
7499         (tui_make_visible, tui_make_invisible): Rewrite.
7500         (tui_win_info::make_visible): Remove.
7501         (tui_source_window_base::make_visible): Update.
7502         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7503         method.  Moved from...
7504         (struct tui_win_info) <make_visible>: ...here.
7505
7506 2019-06-25  Tom Tromey  <tom@tromey.com>
7507
7508         * tui/tui-winsource.c
7509         (tui_source_window_base::do_scroll_horizontal): Remove direction
7510         parameter.
7511         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7512         direction parameter.
7513         * tui/tui-win.c (tui_win_info::forward_scroll)
7514         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7515         (tui_win_info::right_scroll): Update.
7516         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7517         direction parameter.
7518         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7519         direction parameter.
7520         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7521         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7522         Remove direction parameter.
7523         (struct tui_source_window_base, struct tui_source_window)
7524         (struct tui_disasm_window, struct tui_data_window)
7525         (struct tui_cmd_window): Update.
7526
7527 2019-06-25  Tom Tromey  <tom@tromey.com>
7528
7529         * tui/tui-winsource.h (tui_set_exec_info_content)
7530         (tui_show_exec_info_content, tui_erase_exec_info_content)
7531         (tui_clear_exec_info_content, tui_update_exec_info): Change
7532         argument to tui_source_window_base.
7533         * tui/tui-winsource.c (tui_set_exec_info_content)
7534         (tui_show_exec_info_content, tui_erase_exec_info_content)
7535         (tui_clear_exec_info_content, tui_update_exec_info): Change
7536         argument to tui_source_window_base.
7537
7538 2019-06-25  Tom Tromey  <tom@tromey.com>
7539
7540         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7541         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7542
7543 2019-06-25  Tom Tromey  <tom@tromey.com>
7544
7545         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7546         check.
7547
7548 2019-06-25  Tom Tromey  <tom@tromey.com>
7549
7550         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7551         type to void.
7552         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7553         type to void.
7554         * tui/tui-source.c (tui_set_source_content): Update.
7555         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7556
7557 2019-06-25  Tom Tromey  <tom@tromey.com>
7558
7559         * tui/tui-win.c (window_name_completer, tui_set_focus)
7560         (tui_all_windows_info): Use name method.
7561         * tui/tui-data.h (struct tui_gen_win_info)
7562         (struct tui_source_window, struct tui_disasm_window)
7563         (struct tui_data_window, struct tui_cmd_window) <name>: New
7564         method.
7565         (tui_win_name): Don't declare.
7566         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7567         (tui_win_name): Remove.
7568
7569 2019-06-25  Tom Tromey  <tom@tromey.com>
7570
7571         * tui/tui-winsource.h (tui_update_source_window)
7572         (tui_update_source_window_as_is): Change parameter type.
7573         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7574         to be a tui_source_window_base.
7575         (tui_update_source_window_as_is): Likewise.
7576         * tui/tui-win.c (make_visible_with_new_height): Update.
7577
7578 2019-06-25  Tom Tromey  <tom@tromey.com>
7579
7580         * tui/tui-winsource.c (tui_erase_source_content)
7581         (tui_show_source_content, tui_show_exec_info_content)
7582         (tui_erase_exec_info_content): Use refresh_window method.
7583         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7584         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7585         from tui_refresh_win.
7586         (tui_data_window::refresh_window): New method.
7587         (tui_win_info::refresh, tui_source_window_base::refresh)
7588         (tui_refresh_all): Use refresh_window method.
7589         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7590         method.
7591         * tui/tui-regs.c (tui_display_register): Call refresh_window
7592         method.
7593         * tui/tui-layout.c (show_source_disasm_command)
7594         (show_source_or_disasm_and_command): Call refresh_window method.
7595         * tui/tui-data.h (struct tui_gen_win_info)
7596         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7597         New method.
7598
7599 2019-06-25  Tom Tromey  <tom@tromey.com>
7600
7601         * tui/tui.c (tui_rl_other_window, tui_enable)
7602         (tui_is_window_visible, tui_get_command_dimension): Update.
7603         * tui/tui-winsource.c (tui_update_source_window_as_is)
7604         (tui_clear_source_content, tui_erase_source_content)
7605         (tui_show_source_line, tui_source_window_base::refill)
7606         (tui_source_window_base::do_scroll_horizontal)
7607         (tui_source_window_base::set_is_exec_point_at)
7608         (tui_update_breakpoint_info, tui_set_exec_info_content)
7609         (tui_alloc_source_buffer, tui_line_is_displayed)
7610         (tui_addr_is_displayed): Update.
7611         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7612         (tui_check_and_display_highlight_if_needed)
7613         (tui_win_info::make_visible, tui_win_info::refresh)
7614         (tui_refresh_all): Update.
7615         * tui/tui-windata.c (tui_first_data_item_displayed)
7616         (tui_delete_data_content_windows, tui_erase_data_content)
7617         (tui_display_all_data, tui_data_window::refresh_all)
7618         (tui_check_data_values): Update.
7619         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7620         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7621         (tui_win_info::backward_scroll, tui_refresh_all_win)
7622         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7623         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7624         (tui_source_window_base::set_new_height)
7625         (tui_data_window::set_new_height)
7626         (make_invisible_and_set_new_height)
7627         (make_visible_with_new_height, new_height_ok)
7628         (parse_scrolling_args): Update.
7629         * tui/tui-stack.c (tui_show_frame_info): Update.
7630         * tui/tui-source.c (tui_set_source_content)
7631         (tui_set_source_content_nil, tui_source_is_displayed)
7632         (tui_source_window::do_scroll_vertical): Update.
7633         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7634         (tui_display_registers_from, tui_display_reg_element_at_line)
7635         (tui_check_register_values, tui_reg_command): Update.
7636         * tui/tui-layout.c (tui_default_win_height)
7637         (show_source_disasm_command, show_data, init_and_make_win)
7638         (show_source_or_disasm_and_command): Update.
7639         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7640         (tui_redisplay_readline, tui_mld_flush)
7641         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7642         (tui_getc): Update.
7643         * tui/tui-disasm.c (tui_set_disassem_content)
7644         (tui_disasm_window::do_scroll_vertical): Update.
7645         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7646         Now virtual.
7647         (struct tui_win_info): Derive from tui_gen_win_info.
7648         <~tui_win_info>: Mark as override.
7649         <generic>: Remove member.
7650         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7651         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7652         (~tui_data_window, ~tui_win_info)
7653         (tui_free_all_source_wins_content): Update.
7654         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7655
7656 2019-06-25  Tom Tromey  <tom@tromey.com>
7657
7658         * tui/tui-layout.c (init_and_make_win): Use new.
7659         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7660         destructor, initializers.
7661         (tui_alloc_generic_win_info): Don't declare.
7662         * tui/tui-data.c (_locator): Add argument to constructor.
7663         (source_win, disasm_win): New globals.
7664         (exec_info): Remove.
7665         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7666         Update.
7667         (tui_alloc_generic_win_info): Remove.
7668         (init_content_element): Use new.
7669         (tui_win_info::tui_win_info): Update.
7670         (free_content_elements) <case DATA_WIN>: Use delete.
7671
7672 2019-06-25  Tom Tromey  <tom@tromey.com>
7673
7674         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7675         * tui/tui-windata.c (tui_first_data_item_displayed)
7676         (tui_delete_data_content_windows): Update.
7677         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7678         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7679         (tui_display_registers_from, tui_check_register_values): Update.
7680         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7681         pointer.
7682         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7683         window.
7684         (tui_free_data_content): Update.
7685         (free_content_elements) <case DATA_WIN>: Free the window.
7686
7687 2019-06-25  Tom Tromey  <tom@tromey.com>
7688
7689         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7690         Update.
7691         * tui/tui-layout.c (make_command_window)
7692         (show_source_disasm_command, show_data, init_and_make_win)
7693         (show_source_or_disasm_and_command): Update.
7694         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7695         method.
7696         <can_highight, is_highlighted>: Now bool.
7697         (tui_set_win_highlight): Don't declare.
7698         * tui/tui-data.c (tui_set_win_highlight): Remove.
7699
7700 2019-06-25  Tom Tromey  <tom@tromey.com>
7701
7702         * tui/tui-wingeneral.c (make_visible): Remove check of window
7703         type.
7704
7705 2019-06-25  Tom Tromey  <tom@tromey.com>
7706
7707         * tui/tui-win.c (tui_win_info::max_height)
7708         (tui_cmd_window::max_height): New methods.
7709         (new_height_ok): Call max_height.
7710         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7711         <max_height>: New method.
7712
7713 2019-06-25  Tom Tromey  <tom@tromey.com>
7714
7715         * tui/tui-win.c (tui_source_window_base::set_new_height)
7716         (tui_data_window::set_new_height): New methods.
7717         (make_invisible_and_set_new_height): Call set_new_height method.
7718         * tui/tui-data.h (struct tui_win_info)
7719         (struct tui_source_window_base, struct tui_data_window)
7720         <set_new_height>: New method.
7721
7722 2019-06-25  Tom Tromey  <tom@tromey.com>
7723
7724         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7725         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7726         tui_refresh_data_win.
7727         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7728         method.
7729         (tui_refresh_all_win): Call the refresh_all method.
7730         (tui_set_focus): Likewise.
7731         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7732         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7733         Likewise.
7734
7735 2019-06-25  Tom Tromey  <tom@tromey.com>
7736
7737         * tui/tui-winsource.h (tui_refill_source_window)
7738         (tui_set_is_exec_point_at): Don't declare.
7739         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7740         (tui_source_window_base::refill): Rename from
7741         tui_refill_source_window.
7742         (tui_source_window_base::do_scroll_horizontal): Update.
7743         (tui_source_window_base::set_is_exec_point_at): Rename from
7744         tui_set_is_exec_point_at.
7745         (tui_update_all_breakpoint_info): Update.
7746         * tui/tui-stack.c (tui_show_frame_info): Update.
7747         * tui/tui-layout.c (show_data): Add cast.
7748         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7749         * tui/tui-data.h (struct tui_source_window_base) <refill,
7750         set_is_exec_point_at>: New methods.
7751         (tui_source_windows, tui_add_to_source_windows): Update types.
7752         (tui_add_to_source_windows): Remove redundant declaration.
7753         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7754         (tui_source_windows): Change return type.
7755         (tui_clear_source_windows_detail): Update.
7756         (tui_add_to_source_windows): Change type of parameter.
7757         (tui_free_all_source_wins_content): Update.
7758
7759 2019-06-25  Tom Tromey  <tom@tromey.com>
7760
7761         * tui/tui-wingeneral.c (tui_win_info::refresh)
7762         (tui_source_window_base::refresh): New methods.
7763         (tui_refresh_all): Call the refresh method.
7764         * tui/tui-data.h (struct tui_win_info)
7765         (struct tui_source_window_base) <refresh>: New method.
7766
7767 2019-06-25  Tom Tromey  <tom@tromey.com>
7768
7769         * tui/tui.h (tui_is_window_visible): Return bool.
7770         * tui/tui.c (tui_is_window_visible): Return bool.
7771         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7772         (tui_make_visible, tui_make_invisible)
7773         (tui_win_info::make_visible)
7774         (tui_source_window_base::make_visible, make_all_visible)
7775         (tui_make_all_visible, tui_make_all_invisible): Update.
7776         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7777         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7778         bool.
7779         (struct tui_win_info, struct tui_source_window_base)
7780         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7781         * tui/tui-data.c (tui_init_generic_part): Update.
7782
7783 2019-06-25  Tom Tromey  <tom@tromey.com>
7784
7785         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7786         (tui_source_window_base::make_visible): New methods.
7787         (make_all_visible): Make method call.
7788         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7789         (struct tui_source_window_base, struct tui_cmd_window): Override
7790         make_visible.
7791         (tui_win_is_source_type): Don't declare.
7792         * tui/tui-data.c (tui_win_is_source_type): Remove.
7793
7794 2019-06-25  Tom Tromey  <tom@tromey.com>
7795
7796         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7797         NULL check.
7798
7799 2019-06-25  Tom Tromey  <tom@tromey.com>
7800
7801         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7802         Inline constructor.  Add initializers for members.
7803         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7804         constructors; now inline in class.
7805
7806 2019-06-25  Tom Tromey  <tom@tromey.com>
7807
7808         * tui/tui-regs.c (tui_show_registers): Update.
7809         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7810         bool.
7811         * tui/tui-data.c (tui_data_window::clear_detail)
7812         (tui_data_window): Update.
7813
7814 2019-06-25  Tom Tromey  <tom@tromey.com>
7815
7816         * tui/tui-windata.c (tui_display_all_data)
7817         (tui_display_data_from_line, tui_display_data_from)
7818         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7819         Update.
7820         * tui/tui-regs.c (tui_last_regs_line_no)
7821         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7822         (tui_show_registers, tui_show_register_group)
7823         (tui_display_registers_from, tui_display_reg_element_at_line)
7824         (tui_display_registers_from_line, tui_check_register_values)
7825         (tui_reg_next, tui_reg_prev): Update.
7826         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7827         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7828         tui_data_window.
7829         (struct tui_win_info) <detail>: Remove.  Add new fields from
7830         tui_data_info.
7831         (TUI_DATA_WIN): Add cast.
7832         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7833         (~tui_data_window): Simplify.
7834
7835 2019-06-25  Tom Tromey  <tom@tromey.com>
7836
7837         * tui/tui-layout.c (show_source_disasm_command)
7838         (show_source_or_disasm_and_command): Update.
7839         * tui/tui-io.c (update_cmdwin_start_line)
7840         (tui_redisplay_readline): Update.
7841         * tui/tui-data.h (struct tui_command_info): Remove.
7842         (struct tui_win_info) <detail>: Remove command_info member.
7843         (struct tui_data_window) <start_line>: New member, from
7844         tui_command_info.
7845         (TUI_CMD_WIN): Add casts.
7846
7847 2019-06-25  Tom Tromey  <tom@tromey.com>
7848
7849         * tui/tui-winsource.c (tui_update_source_window)
7850         (tui_refill_source_window)
7851         (tui_source_window_base::do_scroll_horizontal)
7852         (tui_update_breakpoint_info, tui_set_exec_info_content)
7853         (tui_show_exec_info_content, tui_erase_exec_info_content)
7854         (tui_clear_exec_info_content): Update.
7855         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7856         Update.
7857         * tui/tui-win.c (make_invisible_and_set_new_height)
7858         (make_visible_with_new_height): Update.
7859         * tui/tui-source.c (tui_set_source_content)
7860         (tui_show_symtab_source): Update.
7861         * tui/tui-layout.c (extract_display_start_addr)
7862         (show_source_disasm_command, show_data)
7863         (make_source_or_disasm_window)
7864         (show_source_or_disasm_and_command): Update.
7865         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7866         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7867         "gdbarch".
7868         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7869         to tui_source_window_base.
7870         (struct tui_win_info) <detail>: Remove source_info member.
7871         (struct tui_source_window_base) <has_locator>: Inline.
7872         Move contents from tui_source_info; rename has_locator member to
7873         m_has_locator.
7874         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7875         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7876         header file.
7877         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7878         Simplify.
7879         (tui_free_all_source_wins_content): Cast to
7880         tui_source_window_base.
7881
7882 2019-06-25  Tom Tromey  <tom@tromey.com>
7883
7884         * tui/tui-win.c (make_invisible_and_set_new_height)
7885         (make_visible_with_new_height): Call has_locator method.
7886         * tui/tui-layout.c (show_source_disasm_command, show_data)
7887         (show_source_or_disasm_and_command): Update for bool change.
7888         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7889         (tui_win_info) <has_locator>: New method.
7890         (struct tui_source_window_base) <has_locator>: New method.
7891         (tui_win_has_locator): Don't declare.
7892         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7893         from tui_win_has_locator.
7894         (tui_source_window_base): Use false, not FALSE.
7895
7896 2019-06-25  Tom Tromey  <tom@tromey.com>
7897
7898         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7899         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7900         clear_detail method directly.
7901         (tui_clear_win_detail): Remove.
7902
7903 2019-06-25  Tom Tromey  <tom@tromey.com>
7904
7905         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7906         "this", not TUI_DISASM_WIN.
7907
7908 2019-06-25  Tom Tromey  <tom@tromey.com>
7909
7910         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7911         declare.
7912         * tui/tui-winsource.c
7913         (tui_source_window_base::do_scroll_horizontal): Rename from
7914         tui_horizontal_source_scroll.
7915         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7916         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7917         from tui_vertical_data_scroll.
7918         * tui/tui-win.h (tui_scroll): Don't declare.
7919         * tui/tui-win.c (tui_win_info::forward_scroll)
7920         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7921         (tui_win_info::right_scroll): Rename and update.
7922         (tui_scroll_forward_command, tui_scroll_backward_command)
7923         (tui_scroll_left_command, tui_scroll_right_command): Update.
7924         (tui_scroll): Remove.
7925         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7926         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7927         from tui_vertical_source_scroll.
7928         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7929         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7930         from tui_vertical_disassem_scroll.
7931         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7932         do_scroll_horizontal>: New methods.
7933         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7934         Likewise.
7935         (struct tui_source_window_base): Add do_scroll_horizontal.
7936         (struct tui_source_window, struct tui_disasm_window): Add
7937         do_scroll_vertical.
7938         (struct tui_data_window, struct tui_cmd_window): Add
7939         do_scroll_horizontal and do_scroll_vertical.
7940         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7941
7942 2019-06-25  Tom Tromey  <tom@tromey.com>
7943
7944         * tui/tui-data.h (struct tui_source_window_base): New struct.
7945         (struct tui_source_window): Derive from tui_source_window_base.
7946         (struct tui_disasm_window): New struct.
7947         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7948         from tui_source_window::clear_detail.
7949         (tui_source_window_base): Rename from tui_source_window.
7950         (~tui_source_window_base): Rename from ~tui_source_window.
7951         (tui_alloc_win_info): Create a tui_disasm_window.
7952
7953 2019-06-25  Tom Tromey  <tom@tromey.com>
7954
7955         * tui/tui-data.h (struct tui_source_window)
7956         (struct tui_data_window): Declare destructors.
7957         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7958         destructors.
7959         (tui_win_info): Simplify.
7960
7961 2019-06-25  Tom Tromey  <tom@tromey.com>
7962
7963         * tui/tui-winsource.c (tui_display_main)
7964         (tui_update_source_windows_with_addr)
7965         (tui_update_all_breakpoint_info): Update.
7966         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7967         (new_height_ok, parse_scrolling_args): Update.
7968         * tui/tui-stack.c (tui_show_frame_info): Update.
7969         * tui/tui-data.h (struct tui_list): Remove.
7970         (tui_source_windows): Return a reference to a std::vector.
7971         * tui/tui-data.c (source_windows): Now a std::vector.
7972         (tui_source_windows): Change return type.
7973         (tui_clear_source_windows): Rewrite.
7974         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7975         (tui_free_all_source_wins_content): Rewrite.
7976
7977 2019-06-25  Tom Tromey  <tom@tromey.com>
7978
7979         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7980         (struct tui_data_window, struct tui_cmd_window): Declare
7981         clear_detail method.
7982         * tui/tui-data.c (tui_source_window::clear_detail)
7983         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7984         methods.
7985         (tui_clear_win_detail): Simplify.
7986
7987 2019-06-25  Tom Tromey  <tom@tromey.com>
7988
7989         * tui/tui-layout.c (make_source_window, make_disasm_window)
7990         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7991         Return the new window.
7992         (show_source_disasm_command, show_data)
7993         (show_source_or_disasm_and_command): Update.
7994
7995 2019-06-25  Tom Tromey  <tom@tromey.com>
7996
7997         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7998         parameter.  Return the new window.
7999         (show_source_disasm_command): Update and remove NULL check.
8000         (show_source_or_disasm_and_command): Update.
8001
8002 2019-06-25  Tom Tromey  <tom@tromey.com>
8003
8004         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8005
8006 2019-06-25  Tom Tromey  <tom@tromey.com>
8007
8008         * tui/tui-data.h (struct tui_win_info): Make constructor
8009         protected.  Make destructor virtual.  Add initializers.
8010         (tui_source_window, tui_data_window, tui_cmd_window): New
8011         classes.
8012         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8013         constructor.  Add "type" parameter.
8014         (tui_source_window, tui_data_window, tui_cmd_window): New
8015         constructors.
8016         (tui_alloc_win_info): Instantiate the appropriate subclass.
8017
8018 2019-06-25  Tom Tromey  <tom@tromey.com>
8019
8020         * tui/tui-win.c (tui_resize_all): Use delete.
8021         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8022         destructor.
8023         (tui_free_window): Don't declare.
8024         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8025         Update.
8026
8027 2019-06-25  Tom Tromey  <tom@tromey.com>
8028
8029         * tui/tui-data.h (struct tui_win_info): Add constructor.
8030         * tui/tui-data.c (tui_alloc_win_info): Use new.
8031         (tui_free_window): Use delete.
8032
8033 2019-06-22  Tom Tromey  <tom@tromey.com>
8034
8035         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8036         declare.
8037         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8038
8039 2019-06-22  Tom Tromey  <tom@tromey.com>
8040
8041         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8042         declare.
8043         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8044
8045 2019-06-22  Tom de Vries  <tdevries@suse.de>
8046
8047         * dwarf2read.c (create_addrmap_from_aranges)
8048         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8049         instead of '%zu'.
8050
8051 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8052
8053         * dwarf2read.h (dwarf2_section_info_def): Remove.
8054         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8055         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8056         std::vector<dwarf2_section_info>.
8057         (struct dwo_file) <~dwo_file>: Remove.
8058         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8059         types field.
8060         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8061         (dwarf2_read_debug_names): Likewise.
8062         (create_debug_types_hash_table): Change parameter type to
8063         array_view, adjust code accordingly.
8064         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8065         (partial_die_info::fixup): Likewise.
8066         (determine_prefix): Likewise.
8067         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8068
8069 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8070
8071         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8072         gdb_bfd_ref_ptr.
8073         <~dwo_file>: Remove call to gdb_bfd_unref.
8074         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8075         gdb_bfd_ref_ptr::get.
8076
8077 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8078
8079         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8080         type to htab_up.
8081         * dwarf2read.c (struct dwo_file): Initialize fields.
8082         <~dwo_file>: New.
8083         (free_dwo_file): Remove, move content to ~dwo_file.
8084         (struct dwo_file_deleter): Remove.
8085         (dwo_file_up>: Remove custom deleter.
8086         (free_dwo_files): Remove.
8087         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8088         dwo_files.
8089         (process_skeletonless_type_units): Call unique_ptr::get.
8090         (allocate_dwo_file_hash_table): Add deleter to created hash
8091         table.  Change return type to htab_up.
8092         (lookup_dwo_file_slot): Don't memset dwo_file, call
8093         unique_ptr::get.
8094         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8095         (create_dwo_unit_in_dwp_v2): Likewise.
8096         (open_and_init_dwo_file): Likewise.
8097         (free_dwo_file_from_slot): Remove.
8098
8099 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8100
8101         * dwarf2read.h (struct dwarf2_section_info) <readin,
8102         is_virtual>: Change type to bool.
8103         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8104         true instead of 1.
8105
8106 2019-06-19  Tom Tromey  <tom@tromey.com>
8107
8108         * tui/tui-data.h (tui_init_content_element): Don't declare.
8109
8110 2019-06-19  Tom Tromey  <tom@tromey.com>
8111
8112         * tui/tui-data.h (tui_init_win_info): Don't declare.
8113
8114 2019-06-19  Tom de Vries  <tdevries@suse.de>
8115
8116         * dwarf2read.h (abstract_to_concrete): Change type to
8117         std::unordered_map<sect_offset, std::vector<sect_offset>,
8118         gdb::hash_enum<sect_offset>>.
8119
8120 2019-06-19  Tom Tromey  <tromey@adacore.com>
8121
8122         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8123         EVAL_AVOID_SIDE_EFFECTS specially.
8124
8125 2019-06-19  Tom Tromey  <tromey@adacore.com>
8126
8127         * source-cache.c (highlighter): New global.
8128         (source_cache::get_source_lines): Create a highlighter on demand.
8129
8130 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8131
8132         * defs.h (deprecated_interactive_hook): Delete declaration.
8133         * interps.c (clear_interpreter_hooks): Remove use of
8134         deprecated_interactive_hook.
8135         * top.c (deprecated_interactive_hook): Delete definition.
8136         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8137
8138 2019-06-18  Tom de Vries  <tdevries@suse.de>
8139
8140         PR gdb/24515
8141         * dwarf2read.h (abstract_to_concrete): Change type from
8142         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8143         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8144         * dwarf2read.c (read_variable): Update.
8145         (dwarf2_fetch_die_loc_sect_off): Update.
8146
8147 2019-06-17  Tom de Vries  <tdevries@suse.de>
8148
8149         PR gdb/24617
8150         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8151         accessing parent[parent_len - 1].
8152
8153 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8154
8155         PR gdb/24364
8156         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8157         call dtrace_process_dof with NULL dof.
8158
8159 2019-06-16  Tom de Vries  <tdevries@suse.de>
8160
8161         PR gdb/24445
8162         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8163
8164 2019-06-16  Tom Tromey  <tom@tromey.com>
8165
8166         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8167         (make_all_visible): Use address of member.
8168
8169 2019-06-16  Tom Tromey  <tom@tromey.com>
8170
8171         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8172         (tui_free_window, free_content, free_content_elements): Remove
8173         unnecessary cast.
8174         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8175         cast.
8176         * tui/tui-regs.c (tui_show_register_group)
8177         (tui_display_registers_from, tui_display_reg_element_at_line):
8178         Remove unnecessary cast.
8179
8180 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8181
8182         * linux-nat.c (normal_mask): Delete.
8183         (_initialize_linux_nat): Don't initialise normal_mask.
8184
8185 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8186
8187         PR gdb/24445
8188         * dwarf-index-write.h (write_psymtabs_to_index): Add
8189         dwz_basename parameter.
8190         * dwarf-index-write.c (write_gdbindex): Move file writing to
8191         write_gdbindex_1.  Change return type void.
8192         (assert_file_size): Move up, remove filename parameter.
8193         (write_gdbindex_1): New function.
8194         (write_debug_names): Change return type to void, call
8195         assert_file_size.
8196         (struct index_wip_file): New struct.
8197         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8198         file logic to index_wip_file.  Write index for dwz file if
8199         needed.
8200         (save_gdb_index_command): Pass basename of dwz file, if present.
8201         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8202         build-id of dwz file, if present.
8203         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8204         (dwarf2_get_dwz_file): Likewise.
8205         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8206         (dwarf2_get_dwz_file): Likewise.
8207
8208 2019-06-16  Tom Tromey  <tom@tromey.com>
8209
8210         * coffread.c (process_coff_symbol): Use xstrdup.
8211         * value.c (create_internalvar): Use xstrdup.
8212
8213 2019-06-16  Tom Tromey  <tom@tromey.com>
8214
8215         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8216         * breakpoint.c (stopin_command, stopat_command)
8217         (until_break_command, decode_location_default): Remove unnecessary
8218         cast.
8219         * utils.c (subset_compare): Remove unnecessary cast.
8220         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8221         cast.
8222         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8223         cast.
8224         * infcmd.c (path_command): Remove unnecessary cast.
8225         * coffread.c (decode_type): Remove unnecessary cast.
8226         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8227         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8228         * tui/tui-stack.c (tui_show_locator_content)
8229         (tui_show_frame_info): Remove unnecessary cast.
8230         * tui/tui-win.c (tui_scroll_forward_command)
8231         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8232         (parse_scrolling_args): Remove unnecessary cast.
8233         * tui/tui-data.c (init_win_info, tui_del_window)
8234         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8235         (free_content_elements): Remove unnecessary cast.
8236         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8237         unnecessary cast.
8238         * tui/tui-source.c (tui_set_source_content)
8239         (tui_vertical_source_scroll): Remove unnecessary cast.
8240         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8241         cast.
8242         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8243         * tui/tui-regs.c (tui_display_registers_from)
8244         (tui_display_register): Remove unnecessary cast.
8245         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8246         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8247         (make_visible): Remove unnecessary cast.
8248         * tui/tui-winsource.c (tui_erase_source_content)
8249         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8250         unnecessary cast.
8251         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8252         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8253         * stabsread.c (read_type, read_array_type, read_range_type):
8254         Remove unnecessary cast.
8255         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8256         (parse_symbol, parse_type, upgrade_type, parse_external)
8257         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8258         unnecessary cast.
8259         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8260
8261 2019-06-16  Tom Tromey  <tom@tromey.com>
8262
8263         * tui/tui-data.c (tui_alloc_generic_win_info)
8264         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8265         checks.
8266
8267 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8268             Andrew Burgess  <andrew.burgess@embecosm.com>
8269
8270         * f-typeprint.c (f_print_type): Don't return early for not
8271         associated or not allocated types.
8272         (f_type_print_varspec_suffix): Add print_rank parameter and print
8273         ranks of array types in case they dangling.
8274         (f_type_print_base): Add print_rank parameter.
8275
8276 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8277
8278         * NEWS: Mention new MI commands.
8279         * break-catch-throw.c (enum exception_event_kind): Move to
8280         breakpoint.h.
8281         (print_mention_exception_catchpoint): Output text as a single
8282         message.
8283         (catch_exception_command_1): Rename to...
8284         (catch_exception_event): ...this, make non-static, update header
8285         command, and change some parameter types.
8286         (catch_catch_command): Update for changes to
8287         catch_exception_command_1.
8288         (catch_throw_command): Likewise.
8289         (catch_rethrow_command): Likewise.
8290         * breakpoint.c (enum exception_event_kind): Delete.
8291         * breakpoint.h (enum exception_event_kind): Moved here from
8292         break-catch-throw.c.
8293         (catch_exception_event): Declare.
8294         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8295         (mi_cmd_catch_throw): New function.
8296         (mi_cmd_catch_rethrow): New function.
8297         (mi_cmd_catch_catch): New function.
8298         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8299         'catch-catch' entries.
8300         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8301         (mi_cmd_catch_rethrow): Declare.
8302         (mi_cmd_catch_catch): Declare.
8303
8304 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8305
8306         * annotate.c (annotate_source_line): Change return type to void,
8307         update implementation to match.
8308         * annotate.h (annotate_source_line): Change return type to void,
8309         update header comment.
8310         * stack.c (print_frame_info): Don't change what frame information
8311         is printed based on whether annotations are on or not.
8312
8313 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8314
8315         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8316         (annotate_source): Make static.
8317         (annotate_source_line): Moved from source.c and renamed from
8318         identify_source_line.  Update the return type.
8319         * annotate.h (annotate_source): Delete declaration.
8320         (annotate_source_line): Declaration moved from source.h, and
8321         renamed from identify_source_line.  Return type updated.
8322         * source.c (identify_source_line): Moved to annotate.c and renamed
8323         to annotate_source_line.
8324         (info_line_command): Remove check of annotation_level.
8325         * source.h (identify_source_line): Move declaration to annotate.h
8326         and rename to annotate_source_line.
8327         * stack.c: Add 'annotate.h' include.
8328         (print_frame_info): Remove check of annotation_level before
8329         calling annotate_source_line.
8330
8331 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8332
8333         * source-cache.c (source_cache::get_plain_source_lines): Use
8334         open_source_file_with_line_charpos instead of just
8335         open_source_file, remove call to find_source_lines.
8336         (source_cache::get_source_lines): Likewise.
8337         * source.c (find_source_lines): Make static.
8338         (get_filename_and_charpos): Renamed into...
8339         (open_source_file_with_line_charpos): ..this along with changes to
8340         return a scoped_fd, and some other minor clean ups.
8341         (identify_source_line): Use open_source_file_with_line_charpos.
8342         (search_command_helper): Use open_source_file_with_line_charpos
8343         instead of just open_source_file, remove call to
8344         find_source_lines.
8345         * source.h (open_source_file_with_line_charpos): Declare new
8346         function.
8347         (find_source_lines): Delete declaration.
8348
8349 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8350
8351         * source.c (get_filename_and_charpos): Remove fullname
8352         parameter.
8353         (identify_source_line): Update call to get_filename_and_charpos.
8354
8355 2019-06-14  Tom Tromey  <tromey@adacore.com>
8356
8357         PR gdb/24502:
8358         * ui-style.h (skip_ansi_escape): Update comment.
8359         * ui-file.h (class no_terminal_escape_file): New class.
8360         * ui-file.c (no_terminal_escape_file::write)
8361         (no_terminal_escape_file::puts): New methods.
8362         * cli/cli-logging.c (handle_redirections): Use
8363         no_terminal_escape_file.
8364
8365 2019-06-14  Tom Tromey  <tromey@adacore.com>
8366
8367         * NEWS: Move convenience variable news above Python news.
8368
8369 2019-06-14  Tom Tromey  <tom@tromey.com>
8370
8371         * gnulib: Move directory to top-level.
8372         * configure.ac: Don't configure gnulib.
8373         * configure: Rebuild.
8374         * common/common-defs.h: Use new path to gnulib.
8375         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8376         (GNULIB_H): Remove.
8377         (INCGNU): Look in new gnulib location.
8378         (HFILES_NO_SRCDIR): Remove gnulib files.
8379         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8380         (generated_files): Remove GNULIB_H.
8381         ($(LIBGNU), all-lib): Remove targets.
8382         (distclean): Don't mention GNULIB_BUILDDIR.
8383         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8384
8385 2019-06-14  Tom Tromey  <tromey@adacore.com>
8386
8387         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8388         Warn if symbol file does not provide any symbols.
8389
8390 2019-06-14  Tom Tromey  <tromey@adacore.com>
8391
8392         * source.c (find_and_open_source): Respect basenames_may_differ.
8393
8394 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * annotate.c (annotate_breakpoints_invalid): Make use of
8397         scoped_restore_terminal_state.
8398         (annotate_frames_invalid): Likewise.
8399
8400 2019-06-14  Tom Tromey  <tromey@adacore.com>
8401
8402         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8403         allow assignment to an internalvar.
8404
8405 2019-06-14  Tom Tromey  <tromey@adacore.com>
8406
8407         * ada-lex.l: Allow "_" in attribute names.
8408
8409 2019-06-14  Tom Tromey  <tromey@adacore.com>
8410
8411         PR gdb/24653:
8412         * regcache.c (registers_changed): Don't call alloca.
8413         * top.c (execute_command): Don't call alloca.
8414
8415 2019-06-13  Pedro Alves  <palves@redhat.com>
8416
8417         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8418         'expression'.  When parsing an expression, error out if there's
8419         junk after "unlimited".
8420         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8421         (do_set_command): Adjust calls to is_unlimited_literal.
8422
8423 2019-06-13  Pedro Alves  <palves@redhat.com>
8424
8425         * compile/compile.c (make_compile_options_def_group): Add braces
8426         around array_view initializer.
8427         * thread.c (make_thread_apply_all_options_def_group)
8428         (make_thread_apply_all_options_def_group): Likewise.
8429
8430 2019-06-13  Pedro Alves  <palves@redhat.com>
8431
8432         * NEWS (New commands): Mention "maint test-options
8433         require-delimiter", "maint test-options unknown-is-error", "maint
8434         test-options unknown-is-operand" and "maint show
8435         test-options-completion-result".
8436         (New command options, command completion): New section.
8437         (Completion improvements): New section.
8438         Mention that you can abbreviate "unlimited".
8439
8440 2019-06-13  Pedro Alves  <palves@redhat.com>
8441
8442         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8443         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8444         * unittests/cli-utils-selftests.c (test_parse_flags)
8445         (test_parse_flags_qcs): Delete.
8446         (test_cli_utils): Don't call deleted functions.
8447
8448 2019-06-13  Pedro Alves  <palves@redhat.com>
8449
8450         * thread.c: Include "cli/cli-option.h".
8451         (tp_array_compar_ascending): Global.
8452         (tp_array_compar): Delete function.
8453         (tp_array_compar_ascending, tp_array_compar_descending): New
8454         functions.
8455         (ascending_option_def, qcs_flag_option_def)
8456         (thr_qcs_flags_option_defs)
8457         (make_thread_apply_all_options_def_group)
8458         (make_thread_apply_options_def_group): New.
8459         (thread_apply_all_command): Use gdb::option::process_options.
8460         (thread_apply_command_completer)
8461         (thread_apply_all_command_completer): New.
8462         (thread_apply_command): Use gdb::option::process_options.
8463         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8464         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8465         to generate help text of "thread apply".  Adjust "taas"'s help.
8466         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8467         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8468
8469 2019-06-13  Pedro Alves  <palves@redhat.com>
8470
8471         * thread.c (thread_apply_command): Check for invalid TID with
8472         isdigit instead of !isalpha.
8473
8474 2019-06-13  Pedro Alves  <palves@redhat.com>
8475
8476         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8477         (validate_flags_qcs): New.
8478         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8479         (validate_flags_qcs): Declare.
8480         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8481         (make_frame_apply_options_def_group): New.
8482         (frame_apply_command_count): Process options with
8483         gdb::option::process_options.
8484         (frame_apply_completer): New.
8485         (frame_apply_level_completer, frame_apply_all_completer)
8486         (frame_apply_completer): New.
8487         (_initialize_stack): Update help of "frame apply", "frame apply
8488         level", "frame apply all" and "faas" to mention supported options
8489         and install command completers.
8490         * stack.h (frame_apply_all_completer): Declare.
8491         * thread.c: Include "stack.h".
8492         (tfaas_command): Add "--".
8493         (_initialize_thread): Update help "tfaas" to mention supported
8494         options and install command completer.
8495
8496 2019-06-13  Pedro Alves  <palves@redhat.com>
8497
8498         * completer.c (complete_nested_command_line): New.
8499         (gdb_completion_word_break_characters_throw): Add assertion.
8500         * completer.h (complete_nested_command_line): Declare.
8501
8502 2019-06-13  Pedro Alves  <palves@redhat.com>
8503
8504         * stack.c (parse_backtrace_qualifiers): New.
8505         (backtrace_command): Use it.
8506         (backtrace_command_completer): Complete on qualifiers.
8507
8508 2019-06-13  Pedro Alves  <palves@redhat.com>
8509
8510         * frame.c: Include "cli/cli-option.h.
8511         (user_set_backtrace_options): New.
8512         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8513         Delete.
8514         (get_prev_frame): Adjust.
8515         (boolean_option_def, uinteger_option_def)
8516         (set_backtrace_option_defs): New.
8517         (_initialize_frame): Adjust and use
8518         gdb::option::add_setshow_cmds_for_options to install "set
8519         backtrace past-main" and "set backtrace past-entry".
8520         * frame.h: Include "cli/cli-option.h".
8521         (struct frame_print_options): Forward declare.
8522         (print_frame_arguments_all, print_frame_arguments_scalars)
8523         (print_frame_arguments_none): Declare.
8524         (print_entry_values): Delete declaration.
8525         (struct frame_print_options, user_frame_print_options): New.
8526         (struct set_backtrace_options): New.
8527         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8528         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8529         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8530         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8531         (list_args_or_locals): Add frame_print_options parameter.
8532         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8533         * python/py-framefilter.c (enumerate_args): Pass down
8534         USER_FRAME_PRINT_OPTIONS.
8535         * stack.c: Include "cli/cli-option.h".
8536         (print_frame_arguments_all, print_frame_arguments_scalars)
8537         (print_frame_arguments_none): Declare.
8538         (print_raw_frame_arguments, print_entry_values): Delete.
8539         (user_frame_print_options): New.
8540         (boolean_option_def, enum_option_def, frame_print_option_defs):
8541         New.
8542         (struct backtrace_cmd_options): New.
8543         (bt_flag_option_def): New.
8544         (backtrace_command_option_defs): New.
8545         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8546         (print_frame_arg, read_frame_arg, print_frame_args)
8547         (print_frame_info, print_frame): Add frame_print_options parameter
8548         and use it.
8549         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8550         (backtrace_command_1): Add frame_print_options and
8551         backtrace_cmd_options parameters and use them.
8552         (make_backtrace_options_def_group): New.
8553         (backtrace_command): Process command options with
8554         gdb::option::process_options.
8555         (backtrace_command_completer): New.
8556         (_initialize_stack): Extend "backtrace"'s help to mention
8557         supported options.  Install completer for "backtrace".
8558         Install some settings commands with add_setshow_cmds_for_options.
8559
8560 2019-06-13  Pedro Alves  <palves@redhat.com>
8561
8562         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8563         and that "set/show print raw frame-arguments" are now deprecated.
8564
8565         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8566         command.
8567         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8568         * stack.c (_initialize_stack): Install "set/show print
8569         raw-frame-arguments", and deprecate "set/show print raw
8570         frame-arguments".
8571         * valprint.c (_initialize_valprint): Deprecate "set/show print
8572         raw".
8573
8574 2019-06-13  Pedro Alves  <palves@redhat.com>
8575
8576         * compile/compile.c (struct compile_options): New.
8577         (compile_flag_option_def, compile_command_option_defs)
8578         (make_compile_options_def_group): New.
8579         (compile_file_command): Handle options with
8580         gdb::option::process_options.
8581         (compile_file_command_completer): New function.
8582         (compile_code_command): Handle options with
8583         gdb::option::process_options.
8584         (compile_code_command_completer): New function.
8585         (_initialize_compiler): Install completers for "compile code" and
8586         "compile file".  Mention available options in "compile code" and
8587         "compile code"'s help.
8588         * completer.c (advance_to_completion_word): New, factored out from
8589         ...
8590         (advance_to_expression_complete_word_point): ... this.
8591         (advance_to_filename_complete_word_point): New.
8592         * completer.h (advance_to_filename_complete_word_point): New
8593         declaration.
8594
8595 2019-06-13  Pedro Alves  <palves@redhat.com>
8596
8597         * compile/compile.c: Include "cli/cli-option.h".
8598         (compile_print_value): Scope data pointer is now a
8599         value_print_options pointer; adjust.
8600         (compile_print_command): Process options.  Scope data pointer is
8601         now a value_print_options pointer; adjust.
8602         (_initialize_compile): Update "compile print"'s help to include
8603         supported options.  Install a completer for "compile print".
8604         * cp-valprint.c (show_vtblprint, show_objectprint)
8605         (show_static_field_print): Delete.
8606         (_initialize_cp_valprint): Don't install "set print
8607         static-members", "set print vtbl", "set print object" here.
8608         * printcmd.c: Include "cli/cli-option.h" and
8609         "common/gdb_optional.h".
8610         (print_command_parse_format): Rework to fill in a
8611         value_print_options instead of a format_data.
8612         (print_value): Change parameter type from format_data pointer to
8613         value_print_options reference.  Adjust.
8614         (print_command_1): Process options.  Adjust to pass down a
8615         value_print_options.
8616         (print_command_completer): New.
8617         (_initialize_printcmd): Install print_command_completer as
8618         handle_brkchars completer for the "print" command.  Update
8619         "print"'s help to include supported options.
8620         * valprint.c: Include "cli/cli-option.h".
8621         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8622         here from cp-valprint.c.
8623         (boolean_option_def, uinteger_option_def)
8624         (value_print_option_defs, make_value_print_options_def_group):
8625         New.  Use gdb::option::add_setshow_cmds_for_options to install
8626         "set print elements", "set print null-stop", "set print repeats",
8627         "set print pretty", "set print union", "set print array", "set
8628         print address", "set print symbol", "set print array-indexes".
8629         * valprint.h: Include <string> and "cli/cli-option.h".
8630         (make_value_print_options_def_group): Declare.
8631         (print_value): Change parameter type from format_data pointer to
8632         value_print_options reference.
8633         (print_command_completer): Declare.
8634
8635 2019-06-13  Pedro Alves  <palves@redhat.com>
8636
8637         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8638         (COMMON_SFILES): Add maint-test-settings.c.
8639         * cli/cli-decode.c (boolean_enums): New global, factored out from
8640         ...
8641         (add_setshow_boolean_cmd): ... here.
8642         * cli/cli-decode.h (boolean_enums): Declare.
8643         * cli/cli-option.c: New file.
8644         * cli/cli-option.h: New file.
8645         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8646         factored out from ...
8647         (parse_cli_boolean_value(const char *)): ... this.
8648         (is_unlimited_literal): Change parameter type to pointer to
8649         pointer.  Adjust and advance ARG pointer.
8650         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8651         (parse_cli_var_enum): New, factored out from ...
8652         (do_set_command): ... this.  Adjust.
8653         * cli/cli-setshow.h (parse_cli_boolean_value)
8654         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8655         (parse_cli_var_enum): Declare.
8656         * cli/cli-utils.c: Include "cli/cli-option.h".
8657         (get_ulongest): New.
8658         * cli/cli-utils.h (get_ulongest): Declare.
8659         (check_for_argument): New overloads.
8660         * maint-test-options.c: New file.
8661
8662 2019-06-13  Pedro Alves  <palves@redhat.com>
8663
8664         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8665         parse a range if "-" is at the end of the string.
8666
8667 2019-06-13  Pedro Alves  <palves@redhat.com>
8668
8669         * cli/cli-setshow.c (parse_auto_binary_operation)
8670         (parse_cli_boolean_value): Don't allow "o".
8671
8672 2019-06-13  Pedro Alves  <palves@redhat.com>
8673
8674         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8675         * NEWS: Mention maint test-settings KIND.
8676         * maint-test-settings.c: New file.
8677
8678 2019-06-13  Pedro Alves  <palves@redhat.com>
8679
8680         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8681         completer.
8682         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8683         "set" completers.
8684
8685 2019-06-13  Pedro Alves  <palves@redhat.com>
8686
8687         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8688         after item.
8689
8690 2019-06-13  Pedro Alves  <palves@redhat.com>
8691
8692         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8693
8694 2019-06-13  Pedro Alves <palves@redhat.com>
8695
8696         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8697         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8698         call.
8699         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8700         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8701         calls.
8702         (check_for_argument): Skip spaces after argument.
8703
8704 2019-06-13  Pedro Alves  <palves@redhat.com>
8705
8706         * thread.c (thread_apply_command): Adjust TID parsing.
8707         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8708         detected before end of string.
8709         (tid_is_in_list): Error out if LIST is invalid.
8710
8711 2019-06-13  Pedro Alves  <palves@redhat.com>
8712
8713         * completer.c (complete_line_internal_1): Rewind completion word
8714         point.
8715         (completion_tracker::advance_custom_word_point_by): Change
8716         parameter type to int.
8717         * completer.h (completion_tracker::advance_custom_word_point_by):
8718         Likewise.
8719
8720 2019-06-13  Pedro Alves  <palves@redhat.com>
8721
8722         * completer.c (advance_to_completion_word): Handle delimiters.
8723
8724 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8725
8726         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8727
8728 2019-06-11  Tom Tromey  <tom@tromey.com>
8729
8730         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8731         (xmalloc_failed): Move to alloc.c.
8732         * alloc.c: New file.
8733         * Makefile.in (COMMON_SFILES): Add alloc.c.
8734
8735 2019-06-11  Tom Tromey  <tom@tromey.com>
8736
8737         * nat/linux-waitpid.c: Don't include server.h.
8738         (linux_debug): Remove.
8739         (my_waitpid): Update.
8740
8741 2019-06-11  Tom Tromey  <tromey@adacore.com>
8742
8743         * infcall.c (_initialize_infcall): Remove trailing newline from
8744         help.
8745         * user-regs.c (_initialize_user_regs): Remove trailing newline
8746         from help.
8747         * typeprint.c (_initialize_typeprint): Remove trailing newline
8748         from help.
8749         * reverse.c (_initialize_reverse): Remove trailing newlines from
8750         help.
8751         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8752         from help.
8753         * language.c (add_set_language_command): Remove trailing newline
8754         from help.
8755         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8756         help.
8757         * disasm.c (_initialize_disasm): Remove trailing newline from
8758         help.
8759         * top.c (init_main): Remove trailing newline from help.
8760         * interps.c (_initialize_interpreter): Remove trailing newline
8761         from help.
8762         * btrace.c (_initialize_btrace): Remove trailing newlines from
8763         help.
8764         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8765         from help.
8766         * python/python.c (_initialize_python): Remove trailing newline
8767         from help.
8768         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8769         help.
8770         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8771         from help.  Reformat some text.
8772         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8773         from help.
8774         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8775         newline from help.
8776
8777 2019-06-11  Tom Tromey  <tromey@adacore.com>
8778
8779         * darwin-nat.c (darwin_decode_exception_message)
8780         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8781
8782 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8783
8784         * valops.c (value_slice): Check for not allocated or not
8785         associated values.
8786
8787 2019-06-10  Tom de Vries  <tdevries@suse.de>
8788
8789         PR gdb/24618
8790         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8791         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8792         invalid.
8793
8794 2019-06-10  Tom de Vries  <tdevries@suse.de>
8795
8796         PR gdb/24611
8797         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8798         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8799
8800 2019-06-10  Tom de Vries  <tdevries@suse.de>
8801
8802         PR symtab/24545
8803         * symtab.c (struct demangled_name_entry): Add language field.
8804         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8805         static minimal symbol".  Set and use language field.
8806
8807 2019-06-10  Tom Tromey  <tromey@adacore.com>
8808
8809         * ada-lang.c (_initialize_ada_language): Update help text.
8810
8811 2019-06-10  Tom Tromey  <tromey@adacore.com>
8812
8813         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8814         with a newline.
8815         * guile/guile.c (handle_boot_error): Don't end warning with a
8816         newline.
8817         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8818         warning with a newline.
8819         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8820         newline.
8821         (s12z_frame_cache): Likewise.
8822         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8823         a newline.
8824         * solib-svr4.c (disable_probes_interface): Don't end warning with
8825         a newline.
8826         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8827         newline.
8828         * python/python.c (do_finish_initialization): Don't end warning
8829         with a newline.
8830
8831 2019-06-10  Tom Tromey  <tom@tromey.com>
8832
8833         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8834         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8835         gdbpy_enter.
8836
8837 2019-06-10  Tom Tromey  <tromey@adacore.com>
8838
8839         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8840         data.
8841         (elf_new_init): Don't call stabsread_new_init.
8842         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8843         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8844         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8845
8846 2019-06-10  Tom de Vries  <tdevries@suse.de>
8847
8848         PR symtab/16264
8849         PR symtab/24517
8850         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8851
8852 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8853
8854         * source.c (find_and_open_source): Also rewrite relative file
8855         names.
8856
8857 2019-04-26  Amos Bird  <amosbird@gmail.com>
8858
8859         * annotate.c (annotate_thread_exited): Add "thread-exited"
8860         annotation.
8861
8862 2019-06-06  Tom Tromey  <tromey@adacore.com>
8863
8864         * maint.h (class scoped_command_stats): Use
8865         DISABLE_COPY_AND_ASSIGN.
8866         <print_time>: New method.
8867         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8868         print_time.
8869         (scoped_command_stats::print_time): New method.
8870
8871 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8872
8873         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8874         instructions of lengths 6 or 8 bytes.
8875
8876 2019-06-04  Pedro Alves  <palves@redhat.com>
8877
8878         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8879
8880         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8881         * breakpoint.c (condition_completer): Likewise.
8882         * cli/cli-dump.c (scan_expression): Likewise.
8883         * common/filestuff.c (mkdir_recursive): Likewise.
8884         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8885         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8886         (gdb_abspath): Likewise.
8887         * compile/compile-cplus-types.c
8888         (compile_cplus_instance::decl_name): Likewise.
8889         * completer.c (complete_explicit_location):
8890         (signal_completer, reg_or_group_completer_1): Likewise.
8891         * cp-support.c (cp_remove_params_if_any): Likewise.
8892         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8893         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8894         * infcmd.c (strip_bg_char): Likewise.
8895         * linespec.c (copy_token_string): Likewise.
8896         * mi/mi-main.c (output_cores): Likewise.
8897         * psymtab.c (psymtab_search_name):
8898         * symfile.c (test_set_ext_lang_command): Likewise.
8899         * target.c (target_fileio_read_stralloc): Likewise.
8900         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8901         * value.c (complete_internalvar): Likewise.
8902
8903 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8904
8905         Add objfile property to gdb.Type.
8906         * NEWS: Mention Python API addition.
8907         * python/py-type.c (typy_get_objfile): New method.
8908
8909 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8910
8911         * NEWS: Mention the new set|show style [title|highlight].
8912         Mention changes to "show style", "help" and "apropos".
8913
8914 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8915
8916         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8917         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8918         instead of print_help_for_command.
8919         (print_doc_of_command): New function.
8920         (help_list): Add 'apropos -v word' suggestion.
8921         (print_help_for_command): Style the command name using title style.
8922         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8923         (_initialize_cli_cmds): Describe -v in apropos_command help.
8924
8925 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8926
8927         * cli/cli-style.h (cli_style_option): Add name in constructor,
8928         add m_name class member, add constructor with intensity,
8929         add name class function.
8930         (cli_style_option::add_setshow_commands): Remove name argument.
8931         (highlight_style, title_style): New styles.
8932         * cli/cli-style.c (do_show): New function that shows a style
8933         characteristic styling the style name with itself.
8934         (set_style_name): New function.
8935         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8936         Update all callers according to the changes in cli/cli-style.h.
8937         * utils.h (fputs_highlighted): New function.
8938         * utils.c (fputs_highlighted): Likewise.
8939
8940 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8941
8942         * NEWS: Mention new pipe command and new convenience variables.
8943
8944 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8945
8946         * cli/cli-cmds.c (pipe_command): New function.
8947         (_initialize_cli_cmds): Call add_com for pipe_command.
8948         Define | as an alias for pipe.
8949         (exit_status_set_internal_vars): New function.
8950         (shell_escape): Call exit_status_set_internal_vars.
8951         cli/cli-decode.c (find_command_name_length): Recognize | as
8952         a single character command.
8953
8954 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8955
8956         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8957         top.c (execute_command_to_ui_file): New function, mostly a copy
8958         of execute_command_to_string.
8959         (execute_command_to_string): Implement by calling
8960         execute_command_to_ui_file.
8961
8962 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8963
8964         * top.h (saved_command_line): Remove declaration.
8965         * top.c (previous_saved_command_line, previous_repeat_arguments):
8966         New variables.
8967         (saved_command_line): Make static, define together with other
8968         'repeat variables'.
8969         (dont_repeat): Clear repeat_arguments.
8970         (repeat_previous, get_saved_command_line, save_command_line):
8971         New functions.
8972         (gdb_init): Initialize saved_command_line
8973         and previous_saved_command_line.
8974         * main.c (captured_main_1): Remove saved_command_line initialization.
8975         * event-top.c (handle_line_of_input): Update to use
8976         the new 'repeat' related functions instead of direct access to
8977         saved_command_line.
8978         * command.h (repeat_previous, get_saved_command_line,
8979         save_command_line): New declarations.
8980         (dont_repeat): Add comment.
8981
8982 2019-05-30  Tom Tromey  <tromey@adacore.com>
8983
8984         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8985         Fix comment.
8986         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8987
8988 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8989
8990         PR cli/24587
8991         * completer.c (complete): Initialize variable word.
8992
8993 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8994
8995         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8996         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8997         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8998         'body' is NULL to the outter 'if', protecting the '!is_define'
8999         situation as well.
9000
9001 2019-05-29  Tom Tromey  <tromey@adacore.com>
9002
9003         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9004         (dwarf_unknown): New function.
9005         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9006         (dwarf_type_encoding_name): Use dwarf_unknown.
9007
9008 2019-05-29  Tom Tromey  <tromey@adacore.com>
9009
9010         PR c++/20020:
9011         * cp-valprint.c (cp_print_value_fields): Call
9012         cp_print_static_field inside "try".
9013
9014 2019-05-29  Tom Tromey  <tromey@adacore.com>
9015
9016         * inflow.c (struct terminal_info): Add default operator=.
9017         * configure: Rebuild.
9018         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9019         -Wdeprecated-copy-dtor, -Wredundant-move.
9020
9021 2019-05-29  Tom Tromey  <tromey@adacore.com>
9022
9023         * NEWS: Add entry.
9024         * infcmd.c (print_return_value_1): Handle finish_print
9025         option.
9026         (show_print_finish): New function.
9027         (_initialize_infcmd): Add "set/show print finish" commands.
9028         * valprint.c (user_print_options): Initialize new member.
9029         * valprint.h (struct value_print_options) <finish_print>: New
9030         member.
9031
9032 2019-05-28  Tom Tromey  <tromey@adacore.com>
9033
9034         * ada-lang.c (ada_remove_Xbn_suffix)
9035         (find_old_style_renaming_symbol)
9036         (parse_old_style_renaming): Remove.
9037         (ada_find_renaming_symbol): Don't call
9038         find_old_style_renaming_symbol.
9039         (ada_is_renaming_symbol): Rename from
9040         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9041         bool.  Now static.
9042         (ada_read_var_value): Update and simplify.
9043         * ada-exp.y (write_var_or_type): Remove old code.
9044
9045 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9046
9047         PR gdb/25010
9048         * event-top.c: Remove include comment.
9049         * inflow.c (class scoped_ignore_sigttou): Move from here...
9050         * inflow.h (class scoped_ignore_sigttou): ...to here.
9051         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9052         * top.c:  Remove include comment.
9053
9054 2019-05-27  Tom Tromey  <tom@tromey.com>
9055
9056         * NEWS: Fix typo.
9057
9058 2019-05-22  Tom Tromey  <tromey@adacore.com>
9059
9060         * target.c (target_follow_exec): Constify parameter.
9061         * target-delegates.c: Rebuild.
9062         * remote.c (remote_target::follow_exec): Constify parameter.
9063         * infrun.c (follow_exec): Constify parameter.
9064         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9065         (target_follow_exec): Likewise.
9066
9067 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9068
9069         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9070         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9071
9072 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9073
9074         * NEWS: Add debugredirect and testsuite sections.
9075
9076 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9077
9078         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9079         target descriptions using exclusively floating point register name
9080         aliases.
9081
9082 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9083
9084         PR gdb/18644:
9085         * f-lang.c (build_fortran_types): Handle the case where
9086         gdbarch_floatformat_for_type returns a nullptr.
9087
9088 2019-05-21  Tom de Vries  <tdevries@suse.de>
9089
9090         PR cli/24587
9091         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9092
9093 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9094
9095         PR gdb/18644:
9096         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9097         16-byte floats.
9098         * i386-tdep.c (i386_floatformat_for_type): Use
9099         floatformats_ia64_quad for the 16-byte floating point component
9100         within a fortran 32-byte complex number.
9101
9102 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9103
9104         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9105         delete default constructor.
9106         (find_partial_die): Update to return const struct.
9107         (partial_die_parent_scope): Move variable declaration into scope
9108         of its use and change its type to auto.
9109         (guess_partial_die_structure_name): Likewise.
9110         (partial_die_info::fixup): Likewise.
9111
9112 2019-05-17  Tom Tromey  <tromey@adacore.com>
9113
9114         * source.c (find_and_open_source): Remove cast.
9115
9116 2019-05-17  Tom Tromey  <tromey@adacore.com>
9117
9118         * annotate.c (annotate_source): Make "filename" const.
9119         * annotate.h (annotate_source): Use const.
9120
9121 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9122
9123         * disasm.c (set_disassembler_options): Send errors to stderr.
9124
9125 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9126
9127         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9128         (cli_interp_base::set_logging): Check debug_redirect.
9129         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9130         * cli/cli-logging.c (debug_redirect): Add static variable.
9131         (pop_output_files): Add default param.
9132         (handle_redirections): Print debug setting.
9133         (show_logging_command): Likewise.
9134         (_initialize_cli_logging): Add debugredirect command.
9135         * interps.c (current_interp_set_logging): Add debug_redirect
9136         parameter.
9137         * interps.h (set_logging): Add debug_redirect parameter.
9138         (current_interp_set_logging): Likewise.
9139         * mi/mi-common.h: Likewise.
9140         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9141
9142 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9143             Tom Tromey  <tromey@adacore.com>
9144
9145         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9146         directly.
9147         * cli/cli-interp.h (make_logging_output): Remove declaration.
9148         * cli/cli-logging.c (make_logging_output): Remove function.
9149         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9150         directly.
9151         * ui-file.c (tee_file::tee_file): Remove bools.
9152         (tee_file::~tee_file): Remove deletes.
9153         * ui-file.h (tee_file): Remove bools.
9154
9155 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9156
9157         * mi/mi-cmds.h (mi_cmd_complete): New function.
9158         * mi/mi-main.c (mi_cmd_complete): Likewise.
9159         * mi/mi-cmds.c: Define new MI command -complete.
9160         * NEWS: Mention new -complete command.
9161
9162 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9163
9164         * completer.h (complete): New function.
9165         * completer.c (complete): Likewise.
9166         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9167         function defined in completer.h.
9168
9169 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9170
9171         * MAINTAINERS (Write After Approval): Add myself.
9172
9173 2019-05-17  Tom de Vries  <tdevries@suse.de>
9174
9175         PR gdb/24094
9176         * dwarf2read.c (struct cu_partial_die_info): New struct.
9177         (find_partial_die): Return cu_partial_die_info.
9178         (partial_die_parent_scope, guess_partial_die_structure_name)
9179         (partial_die_info::fixup): Handle new return type of find_partial_die.
9180
9181 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9182
9183         PR breakpoints/24541
9184         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9185         "std::string", simplifying the algorithm.
9186
9187 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9188
9189         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9190         (stap_static_probe_ops::get_probes): Likewise.
9191
9192 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9193
9194         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9195         '-')" and "else if".
9196         (stap_parse_single_operand): Join checks for
9197         "gdbarch_stap_parse_special_token_p" and
9198         "gdbarch_stap_parse_special_token" in the same "if" statement.
9199         Invert check when verifying for operation on register
9200         displacement.
9201
9202 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9203
9204         * stap-probe.c (stap_get_opcode): Update comment.
9205         (stap_get_expected_argument_type): Likewise.
9206         (handle_stap_probe): Likewise.
9207
9208 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9209
9210         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9211         return type to 'bool'.  Adjust comment.  Use 'bool' when
9212         appropriate.
9213         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9214         * stap-probe.c (stap_parse_argument_1): Likewise.
9215         (stap_is_operator): Likewise.
9216         (stap_is_generic_prefix): Likewise.
9217         (stap_is_register_prefix): Likewise.
9218         (stap_is_register_indirection_prefix): Likewise.
9219         (stap_is_integer_prefix): Likewise.
9220         (stap_generic_check_suffix): Likewise.
9221         (stap_check_integer_suffix): Likewise.
9222         (stap_check_register_suffix): Likewise.
9223         (stap_check_register_indirection_suffix): Likewise.
9224         (stap_parse_register_operand): Likewise.
9225         (stap_parse_single_operand): Likewise.
9226         (stap_parse_argument_1): Likewise.
9227         (stap_probe::get_argument_count): Likewise.
9228         (stap_is_operator): Likewise.
9229
9230 2019-05-16  Tom Tromey  <tromey@adacore.com>
9231
9232         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9233         keyword to foreach.
9234
9235 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9236
9237         * linux-thread-db.c (try_thread_db_load_1): Change return type
9238         to bool.
9239         (try_thread_db_load): Likewise.
9240         (try_thread_db_load_from_pdir_1): Likewise.
9241         (try_thread_db_load_from_pdir): Likewise.
9242         (try_thread_db_load_from_sdir): Likewise.
9243         (try_thread_db_load_from_dir): Likewise.
9244         (thread_db_load_search): Likewise.
9245         (has_libpthread): Likewise.
9246         (thread_db_load): Likewise.
9247
9248 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9249
9250         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9251         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9252         NULL, and complain/return if that's the case.
9253
9254 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9255
9256         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9257         (advance, posn, abstract_read_memory): New functions.
9258         [struct mem_read_abstraction]: New struct.
9259         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9260
9261 2019-05-14  Tom Tromey  <tromey@adacore.com>
9262
9263         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9264         value is not lval_memory.
9265
9266 2019-05-14  Tom Tromey  <tromey@adacore.com>
9267
9268         * solib.c (info_sharedlibrary_command): Style the file name.
9269
9270 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9271
9272         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9273         (aarch64_vnv_type): Likewise.
9274         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9275         * common/tdesc.c: Likewise.
9276         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9277         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9278         * features/aarch64-fpu.xml: Add ieee half view.
9279         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9280         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9281         * gdbtypes.h (struct builtin_type): Likewise.
9282         (struct objfile_type): Likewise.
9283
9284 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9285
9286         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9287         typo.
9288         * location.h (string_to_event_location): Likewise.
9289
9290 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9291
9292         GDB 8.3 released.
9293
9294 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9295
9296         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9297         New variable declaration.
9298         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9299         New variable.
9300         (print_one_breakpoint): Use ui_out::test_flags and new global
9301         variable to compute use_fixed_output.
9302         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9303         Remove.
9304         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9305         (mi_multi_location_breakpoint_output_fixed): Remove.
9306         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9307         new variable.
9308         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9309         fix_multi_location_breakpoint_output flag if version >= 3.
9310         * ui-out.h (enum ui_out_flag)
9311         <fix_multi_location_breakpoint_output>: New enumerator.
9312
9313 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9314
9315         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9316
9317 2019-05-10  Tom Tromey  <tromey@adacore.com>
9318
9319         * ada-lang.c (catch_ada_completer): New function.
9320         (_initialize_ada_language): Use it.
9321
9322 2019-05-10  Tom Tromey  <tromey@adacore.com>
9323
9324         * thread.c (print_thread_info): Make "requested_threads" const.
9325         * gdbthread.h (print_thread_info): Make "requested_threads"
9326         const.
9327         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9328         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9329
9330 2019-05-08  Tom Tromey  <tom@tromey.com>
9331
9332         * gdbtypes.c (objfile_type_data): Change type.
9333         (objfile_type, _initialize_gdbtypes): Update.
9334
9335 2019-05-08  Tom Tromey  <tom@tromey.com>
9336
9337         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9338         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9339         (_initialize_dwarf2_frame): Update.
9340
9341 2019-05-08  Tom Tromey  <tom@tromey.com>
9342
9343         * objc-lang.c (objc_objfile_data): Change type.
9344         (find_methods): Update.
9345         (_initialize_objc_lang): Remove.
9346
9347 2019-05-08  Tom Tromey  <tom@tromey.com>
9348
9349         * stabsread.c (rs6000_builtin_type_data): Change type.
9350         (rs6000_builtin_type, _initialize_stabsread): Update.
9351
9352 2019-05-08  Tom Tromey  <tom@tromey.com>
9353
9354         * mips-tdep.c (mips_pdr_data): Remove.
9355         (_initialize_mips_tdep): Update.
9356
9357 2019-05-08  Tom Tromey  <tom@tromey.com>
9358
9359         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9360         (hppa_init_objfile_priv_data, read_unwind_info)
9361         (find_unwind_entry, _initialize_hppa_tdep): Update.
9362
9363 2019-05-08  Tom Tromey  <tom@tromey.com>
9364
9365         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9366         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9367         on obstack.
9368         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9369
9370 2019-05-08  Tom Tromey  <tom@tromey.com>
9371
9372         * mdebugread.c (basic_type_data): Change type.
9373         (basic_type, _initialize_mdebugread): Update.
9374
9375 2019-05-08  Tom Tromey  <tom@tromey.com>
9376
9377         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9378
9379 2019-05-08  Tom Tromey  <tom@tromey.com>
9380
9381         * nto-tdep.c (nto_inferior_data_reg): Change type.
9382         (nto_inferior_data): Update.
9383         (nto_inferior_data_cleanup, nto_new_inferior_data)
9384         (_initialize_nto_tdep): Remove.
9385         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9386
9387 2019-05-08  Tom Tromey  <tom@tromey.com>
9388
9389         * ada-lang.c (struct ada_inferior_data): Add initializers.
9390         (ada_inferior_data): Change type.
9391         (ada_inferior_data_cleanup): Remove.
9392         (get_ada_inferior_data, ada_inferior_exit)
9393         (struct ada_pspace_data): Add initializers, destructor.
9394         (ada_pspace_data_handle): Change type.
9395         (get_ada_pspace_data): Update.
9396         (ada_pspace_data_cleanup): Remove.
9397
9398 2019-05-08  Tom Tromey  <tom@tromey.com>
9399
9400         * coffread.c (struct coff_symfile_info): Add initializers.
9401         (coff_objfile_data_key): Move lower.  Change type.
9402         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9403         Update.
9404         (coff_free_info): Remove.
9405
9406 2019-05-08  Tom Tromey  <tom@tromey.com>
9407
9408         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9409         (fbsd_pspace_data_handle): Move lower.  Change type.
9410         (get_fbsd_pspace_data): Update.
9411         (fbsd_pspace_data_cleanup): Remove.
9412         (_initialize_fbsd_tdep): Update.
9413
9414 2019-05-08  Tom Tromey  <tom@tromey.com>
9415
9416         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9417         (get_ada_tasks_pspace_data): Update.
9418         (ada_tasks_pspace_data_cleanup): Remove.
9419         (_initialize_tasks): Update.
9420         (ada_tasks_inferior_data_handle): Change type.
9421         (get_ada_tasks_inferior_data): Update.
9422         (ada_tasks_inferior_data_cleanup): Remove.
9423         (struct ada_tasks_pspace_data): Add initializers.
9424
9425 2019-05-08  Tom Tromey  <tom@tromey.com>
9426
9427         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9428         * symfile-debug.c (debug_sym_get_probes): Change type.
9429         * stap-probe.c (handle_stap_probe):
9430         (stap_static_probe_ops::get_probes): Change type.
9431         * probe.h (class static_probe_ops) <get_probes>: Change type.
9432         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9433         (parse_probes_in_pspace): Update.
9434         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9435         Update.
9436         (any_static_probe_ops::get_probes): Change type.
9437         * elfread.c (elfread_data): New typedef.
9438         (probe_key): Change type.
9439         (elf_get_probes): Likewise.  Update.
9440         (probe_key_free): Remove.
9441         (_initialize_elfread): Update.
9442         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9443         Change type.
9444         (dtrace_process_dof_probe, dtrace_process_dof)
9445         (dtrace_static_probe_ops::get_probe): Change type.
9446
9447 2019-05-08  Tom Tromey  <tom@tromey.com>
9448
9449         * xcoffread.c (struct xcoff_symfile_info): Rename from
9450         coff_symfile_info.  Add initializers.
9451         (xcoff_objfile_data_key): Move lower.  Change type.
9452         (XCOFF_DATA): Rewrite.
9453         (xcoff_free_info): Remove.
9454         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9455         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9456         (xcoff_initial_scan): Update.
9457
9458 2019-05-08  Tom Tromey  <tom@tromey.com>
9459
9460         * solib-svr4.c (struct svr4_info): Add initializers and
9461         destructor.
9462         <probes_table>: Now an htab_up.
9463         (solib_svr4_pspace_data): Change type.
9464         (free_probes_table): Simplify.
9465         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9466         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9467         (probes_table_remove_objfile_probes, register_solib_event_probe)
9468         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9469         (_initialize_svr4_solib): Update.
9470
9471 2019-05-08  Tom Tromey  <tom@tromey.com>
9472
9473         * remote.c (remote_pspace_data): Change type.
9474         (remote_pspace_data_cleanup): Remove.
9475         (get_remote_exec_file, set_pspace_remote_exec_file)
9476         (_initialize_remote): Update.
9477
9478 2019-05-08  Tom Tromey  <tom@tromey.com>
9479
9480         * breakpoint.c (breakpoint_objfile_key): Change type.
9481         (get_breakpoint_objfile_data): Update.
9482         (free_breakpoint_objfile_data): Remove.
9483         (_initialize_breakpoint): Update.
9484
9485 2019-05-08  Tom Tromey  <tom@tromey.com>
9486
9487         * linux-tdep.c (struct linux_info): Add initializers.
9488         (linux_inferior_data): Move.  Change type.
9489         (invalidate_linux_cache_inf): Update.
9490         (linux_inferior_data_cleanup): Remove.
9491         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9492
9493 2019-05-08  Tom Tromey  <tom@tromey.com>
9494
9495         * auxv.c (auxv_inferior_data): Move.  Change type.
9496         (auxv_inferior_data_cleanup): Remove.
9497         (invalidate_auxv_cache_inf): Rewrite.
9498         (get_auxv_inferior_data, _initialize_auxv): Update.
9499
9500 2019-05-08  Tom Tromey  <tom@tromey.com>
9501
9502         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9503         (symfile_debug_objfile_data_key): Change type.
9504         (symfile_debug_installed, debug_qf_has_symbols)
9505         (debug_qf_find_last_source_symtab)
9506         (debug_qf_forget_cached_source_info)
9507         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9508         (debug_qf_print_stats, debug_qf_dump)
9509         (debug_qf_expand_symtabs_for_function)
9510         (debug_qf_expand_all_symtabs)
9511         (debug_qf_expand_symtabs_with_fullname)
9512         (debug_qf_map_matching_symbols)
9513         (debug_qf_expand_symtabs_matching)
9514         (debug_qf_find_pc_sect_compunit_symtab)
9515         (debug_qf_map_symbol_filenames)
9516         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9517         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9518         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9519         (debug_sym_read_linetable, debug_sym_relocate): Update.
9520         (symfile_debug_free_objfile): Remove.
9521         (install_symfile_debug_logging, _initialize_symfile_debug):
9522         Update.
9523
9524 2019-05-08  Tom Tromey  <tom@tromey.com>
9525
9526         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9527         allocate_on_obstack.
9528         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9529         (get_dwarf2_per_objfile): Update.
9530         (set_dwarf2_per_objfile): Remove.
9531         (dwarf2_has_info, dwarf2_get_section_info): Update.
9532         (dwarf2_free_objfile): Remove.
9533         (_initialize_dwarf2_read): Update.
9534
9535 2019-05-08  Tom Tromey  <tom@tromey.com>
9536
9537         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9538         initializers.
9539         <unsupported_script_warning_printed,
9540         script_not_found_warning_printed>: Now bool.
9541         (auto_load_pspace_data): Change type.
9542         (~auto_load_pspace_info): Rename from
9543         auto_load_pspace_data_cleanup.
9544         (get_auto_load_pspace_data, init_loaded_scripts_info)
9545         (clear_section_scripts, maybe_print_unsupported_script_warning)
9546         (maybe_print_script_not_found_warning, _initialize_auto_load):
9547         Update.
9548
9549 2019-05-08  Tom Tromey  <tom@tromey.com>
9550
9551         * objfiles.c (objfile_pspace_info): Add destructor and
9552         initializers.
9553         (objfiles_pspace_data): Change type.
9554         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9555         (get_objfile_pspace_data): Update.
9556         (objfiles_bfd_data): Change type.
9557         (get_objfile_bfd_data): Update.
9558         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9559
9560 2019-05-08  Tom Tromey  <tom@tromey.com>
9561
9562         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9563         Change type.
9564         (get_catch_syscall_inferior_data): Update.
9565         (catch_syscall_inferior_data_cleanup): Remove.
9566         (_initialize_break_catch_syscall): Update.
9567
9568 2019-05-08  Tom Tromey  <tom@tromey.com>
9569
9570         * inflow.c (struct terminal_info): Add destructor and
9571         initializers.
9572         (inflow_inferior_data): Change type.
9573         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9574         (get_inflow_inferior_data, inflow_inferior_exit)
9575         (swap_terminal_info, _initialize_inflow): Update.
9576
9577 2019-05-08  Tom Tromey  <tom@tromey.com>
9578
9579         * target-dcache.c (target_dcache_cleanup): Remove.
9580         (target_dcache_aspace_key): Change type.
9581         (target_dcache_init_p, target_dcache_invalidate)
9582         (target_dcache_get, target_dcache_get_or_init)
9583         (_initialize_target_dcache): Update.
9584         * dcache.h (struct dcache_deleter): New.
9585
9586 2019-05-08  Tom Tromey  <tom@tromey.com>
9587
9588         * symtab.c (struct symbol_cache): Add destructor and
9589         initializers.
9590         (symbol_cache_key): Move.  Change type.
9591         (make_symbol_cache, free_symbol_cache): Remove.
9592         (get_symbol_cache): Update.
9593         (symbol_cache_cleanup): Remove.
9594         (ALL_PSPACES, symbol_cache_flush)
9595         (maintenance_print_symbol_cache)
9596         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9597         Update.
9598
9599 2019-05-08  Tom Tromey  <tom@tromey.com>
9600
9601         * symtab.c (struct main_info): Add destructor and initializers.
9602         (main_progspace_key): Move.  Change type.
9603         (get_main_info): Update.
9604         (main_info_cleanup): Remove.
9605         (_initialize_symtab): Update.
9606
9607 2019-05-08  Tom Tromey  <tom@tromey.com>
9608
9609         * registry.h (DECLARE_REGISTRY): Define the _key class.
9610
9611 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9612
9613         * NEWS: Merge two 'New commands' sections.
9614
9615 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9616
9617         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9618         parameter and use Ada language definition instead.
9619         (ada_val_print_ptr): Remove unused language parameter.
9620         (ada_val_print_num): Remove language parameter and use Ada language
9621         definition instead.
9622         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9623         parameter.
9624         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9625         parameter and use Ada language definition instead.
9626         (ada_val_print_1): Update all ada_val_print_xxx calls.
9627         Remove language parameter.
9628         (ada_val_print): Update ada_val_print_1 call.
9629
9630 2019-05-08  Tom Tromey  <tromey@adacore.com>
9631
9632         * remote.c (remote_hw_watchpoint_limit)
9633         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9634         Now static.
9635
9636 2019-05-08  Tom Tromey  <tromey@adacore.com>
9637
9638         * maint.c (_initialize_maint_cmds): Move initialization code to
9639         remote.c.
9640         (watchdog, show_watchdog): Move to remote.c.
9641         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9642         "watchdog" static.
9643         (_initialize_remote): Move initialization code from maint.c.
9644         * defs.h (watchdog): Don't declare.
9645
9646 2019-05-08  Tom Tromey  <tromey@adacore.com>
9647
9648         * tui/tui-interp.c: Include main.h.
9649         * interps.c: Include main.h.
9650         * main.h (interpreter_p): Declare.
9651         * defs.h (interpreter_p): Don't declare.
9652
9653 2019-05-08  Tom Tromey  <tromey@adacore.com>
9654
9655         * dwarf2loc.c: Include dwarf2read.h.
9656         * defs.h (read_unsigned_leb128): Don't declare.
9657         * dwarf2read.h (read_unsigned_leb128): Declare.
9658
9659 2019-05-08  Tom Tromey  <tromey@adacore.com>
9660
9661         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9662         method.
9663
9664 2019-05-08  Tom Tromey  <tromey@adacore.com>
9665
9666         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9667         when no wrap column is set.
9668
9669 2019-05-08  Tom Tromey  <tromey@adacore.com>
9670
9671         * c-lang.c (c_get_string): Handle non-C-style arrays.
9672
9673 2019-05-08  Tom Tromey  <tromey@adacore.com>
9674
9675         * typeprint.c (print_offset_data::update): Print the bit offset,
9676         not the number of bits remaining.
9677
9678 2019-05-08  Tom Tromey  <tromey@adacore.com>
9679
9680         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9681         padding at end of comment.
9682
9683 2019-05-08  Tom Tromey  <tromey@adacore.com>
9684
9685         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9686         Compare main types.
9687
9688 2019-05-06  Tom Tromey  <tom@tromey.com>
9689
9690         * common/scoped_mmap.c: Include common-defs.h.
9691         * common/scoped_mmap.h: Don't include config.h.
9692
9693 2019-05-04  Tom Tromey  <tom@tromey.com>
9694
9695         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9696         (struct aarch64_call_info): Add initializers.
9697         <si>: Now a std::vector.
9698         (pass_on_stack, aarch64_push_dummy_call): Update.
9699
9700 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9701             Tom Tromey  <tom@tromey.com>
9702
9703         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9704         (ppc_threads): Now a std::vector.  Now static.
9705         (hwdebug_find_thread_points_by_tid)
9706         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9707         Update.
9708
9709 2019-05-04  Tom Tromey  <tom@tromey.com>
9710
9711         * arc-tdep.c (arc_tdesc_init): Return bool.
9712
9713 2019-05-04  Tom Tromey  <tom@tromey.com>
9714
9715         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9716         Use gdb_assert_not_reached.
9717
9718 2019-05-04  Tom Tromey  <tom@tromey.com>
9719
9720         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9721         "false".
9722
9723 2019-05-04  Tom Tromey  <tom@tromey.com>
9724
9725         * arc-tdep.c (arc_tdesc_init): Use bool.
9726
9727 2019-05-04  Tom Tromey  <tom@tromey.com>
9728
9729         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9730
9731 2019-05-04  Tom Tromey  <tom@tromey.com>
9732
9733         * cli/cli-cmds.c (valid_command_p): Return bool.
9734
9735 2019-05-04  Tom Tromey  <tom@tromey.com>
9736
9737         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9738         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9739
9740 2019-05-04  Raul Tambre  <raul@tambre.ee>
9741
9742         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9743         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9744         operator for comparison.
9745
9746 2019-05-04  Tom Tromey  <tom@tromey.com>
9747
9748         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9749         (lookup_partial_symbol, print_partial_symbols)
9750         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9751         (psymbol_compare): Update.
9752         (add_psymbol_to_bcache): Clear the entire psymbol.
9753         (maintenance_check_psymtabs): Update.
9754         * psympriv.h (struct partial_symbol): Don't derive from
9755         general_symbol_info.
9756         <obj_section, unrelocated_address, address,
9757         set_unrelocated_address>: Update.
9758         <ginfo>: New member.
9759         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9760         (debug_names::write_psymbols): Update.
9761
9762 2019-05-04  Tom de Vries  <tdevries@suse.de>
9763
9764         * contrib/cc-with-tweaks.sh: Support -n arg.
9765
9766 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9767
9768         * corelow.c (core_target::detach): Ensure frame cache and
9769         register caches are cleared.
9770         inferior.c (exit_inferior_1): Likewise.
9771
9772 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9773             Tom Tromey  <tom@tromey.com>
9774
9775         * dictionary.c (collate_pending_symbols_by_language): Remove
9776         "struct" from foreach.
9777         * symtab.c (lookup_global_symbol_from_objfile)
9778         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9779         foreach.
9780         * ser-tcp.c (net_open): Remove "struct" from foreach.
9781         * objfiles.c (objfile_relocate, objfile_rebase)
9782         (objfile_has_symbols): Remove "struct" from foreach.
9783         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9784         from foreach.
9785         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9786         foreach.
9787         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9788         "struct" from foreach.
9789         * ada-lang.c (create_excep_cond_exprs)
9790         (ada_exception_catchpoint_cond_string): Remove "struct" from
9791         foreach.
9792
9793 2019-05-03  Tom Tromey  <tromey@adacore.com>
9794
9795         * ada-exp.y (convert_char_literal): Check suffix of each
9796         enumerator.
9797
9798 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9799
9800         PR ada/21406:
9801         * ada-exp.y (yywrap): Don't define.
9802         * ada-lex.l (%option): Add noyywrap
9803         (yywrap): Remove.
9804
9805 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9806
9807         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9808         _WIN32_WINNT to the XP level, unless already defined to a higher
9809         level.
9810
9811         * unittests/parse-connection-spec-selftests.c:
9812         * ser-tcp.c:
9813         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9814         override.
9815
9816         * symfile.c (find_separate_debug_file): Remove colon from the
9817         drive spec of DOS/Windows file names of the target, so that the
9818         file name produced from DEBUGDIR and the target's directory will
9819         be valid on DOS/Windows systems.
9820
9821 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * rust-lang.c (val_print_struct): Handle printing structures
9824         containing strings.
9825
9826 2019-05-02  Tom Tromey  <tromey@adacore.com>
9827
9828         * valarith.c (_initialize_valarith): Remove.
9829
9830 2019-05-01  Tom Tromey  <tromey@adacore.com>
9831
9832         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9833         bitfields.
9834
9835 2019-05-01  Tom Tromey  <tromey@adacore.com>
9836
9837         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9838         for big-endian copies.
9839
9840 2019-04-30  Ali Tamur  <tamur@google.com>
9841         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9842         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9843         (read_3_bytes): New function.
9844
9845 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9846
9847         * windows-nat.c (main_thread_id): Delete.
9848         (handle_output_debug_string): Replace main_thread_id by
9849         current_event.dwThreadId.
9850         (fake_create_process): Likewise.
9851         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9852         Do not set main_thread_id.
9853         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9854         current_event.dwThreadId.
9855         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9856
9857 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9858
9859         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9860         Use current_event.dwThreadId instead of main_thread_id.
9861
9862 2019-04-30  Tom Tromey  <tromey@adacore.com>
9863
9864         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9865         (create_excep_cond_exprs): Iterate over program spaces.
9866         (ada_exception_catchpoint_cond_string): Examine all minimal
9867         symbols for exception types.
9868
9869 2019-04-30  Tom Tromey  <tromey@adacore.com>
9870
9871         PR c++/24470:
9872         * dwarf2read.c (process_structure_scope): Handle case where type
9873         has template parameters but no symbol was created.
9874
9875 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9876             Chris January  <chris.january@arm.com>
9877
9878         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9879         qualifier.
9880         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9881
9882 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9883
9884         * f-typeprint.c (f_print_type): Update rules for printing
9885         whitespace.
9886         (f_type_print_varspec_suffix): Likewise.
9887
9888 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9889             Chris January  <chris.january@arm.com>
9890
9891         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9892         function arguments.
9893
9894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9895
9896         * f-lang.c (build_fortran_types): Change name of void type to
9897         lower case.
9898         * f-typeprint.c (f_type_print_base): Print the name of the void
9899         type, rather than a fixed string.
9900         * f-valprint.c (f_decorations): Use lower case void string.
9901
9902 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9903             Chris January  <chris.january@arm.com>
9904
9905         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9906         types for Fortran.
9907
9908 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9909             Chris January  <chris.january@arm.com>
9910             David Lecomber  <david.lecomber@arm.com>
9911
9912         * f-exp.y (BINOP_INTRINSIC): New token.
9913         (exp): New parser rule handling BINOP_INTRINSIC.
9914         (f77_keywords): Add new builtin procedures.
9915         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9916         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9917         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9918         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9919         (print_unop_subexp_f): New function.
9920         (print_binop_subexp_f): New function.
9921         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9922         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9923         (dump_subexp_body_f): Likewise.
9924         (operator_check_f): Likewise.
9925         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9926         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9927
9928 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9929
9930         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9931         UNOP_KIND.
9932         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9933         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9934         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9935         (operator_length_f): New fuction.
9936         (print_subexp_f): New function.
9937         (op_name_f): New function.
9938         (dump_subexp_body_f): New function.
9939         (operator_check_f): New function.
9940         (exp_descriptor_f): Replace standard expression handling functions
9941         with new functions.
9942         * gdb/fortran-operator.def: New file.
9943         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9944         * gdb/std-operator.def: Remove UNOP_KIND.
9945
9946 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9947
9948         * std-operator.def: Remove unbalanced, stray double quote
9949         character.
9950
9951 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9952             Chris January  <chris.january@arm.com>
9953             Daniel Everett  <daniel.everett@arm.com>
9954             Nick Forrington  <nick.forrington@arm.com>
9955             Richard Bunt  <richard.bunt@arm.com>
9956
9957         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9958         of depth when printing anonymous structs or unions.
9959         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9960         Don't print either the top-level value, or the children if the
9961         max-depth is exceeded.
9962         (ppscm_print_children): When printing the key of a map, allow one
9963         extra level of depth.
9964         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9965         print either the top-level value, or the children if the max-depth
9966         is exceeded.
9967         (print_children): When printing the key of a map, allow one extra
9968         level of depth.
9969         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9970         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9971         (user_print_options): Initialise max_depth field.
9972         (val_print_scalar_or_string_type_p): New function.
9973         (val_print): Check to see if the max depth has been reached.
9974         (val_print_check_max_depth): Define new function.
9975         (show_print_max_depth): New function.
9976         (_initialize_valprint): Add 'print max-depth' option.
9977         * valprint.h (struct value_print_options) <max_depth>: New field.
9978         (val_print_check_max_depth): Declare new function.
9979         * NEWS: Document new feature.
9980
9981 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9982
9983         * ada-lang.c (ada_language_defn): Initialise new field.
9984         * c-lang.c (c_is_string_type_p): New function.
9985         (c_language_defn): Initialise new field.
9986         (cplus_language_defn): Initialise new field.
9987         (asm_language_defn): Initialise new field.
9988         (minimal_language_defn): Initialise new field.
9989         * c-lang.h (c_is_string_type_p): Declare new function.
9990         * d-lang.c (d_language_defn): Initialise new field.
9991         * f-lang.c (f_is_string_type_p): New function.
9992         (f_language_defn): Initialise new field.
9993         * go-lang.c (go_is_string_type_p): New function.
9994         (go_language_defn): Initialise new field.
9995         * language.c (default_is_string_type_p): New function.
9996         (unknown_language_defn): Initialise new field.
9997         (auto_language_defn): Initialise new field.
9998         * language.h (struct language_defn) <la_is_string_type_p>: New
9999         member variable.
10000         (default_is_string_type_p): Declare new function.
10001         * m2-lang.c (m2_language_defn): Initialise new field.
10002         * objc-lang.c (objc_language_defn): Initialise new field.
10003         * opencl-lang.c (opencl_language_defn): Initialise new field.
10004         * p-lang.c (pascal_is_string_type_p): New function.
10005         (pascal_language_defn): Initialise new field.
10006         * rust-lang.c (rust_is_string_type_p): New function.
10007         (rust_language_defn): Initialise new field.
10008
10009 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10010
10011         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10012         New field.
10013         * ada-lang.c (ada_language_defn): Initialise new field.
10014         * c-lang.c (c_language_defn): Likewise.
10015         (cplus_language_defn): Likewise.
10016         (asm_language_defn): Likewise.
10017         (minimal_language_defn): Likewise.
10018         * d-lang.c (d_language_defn): Likewise.
10019         * f-lang.c (f_language_defn): Likewise.
10020         * go-lang.c (go_language_defn): Likewise.
10021         * language.c (unknown_language_defn): Likewise.
10022         (auto_language_defn): Likewise.
10023         * m2-lang.c (m2_language_defn): Likewise.
10024         * objc-lang.c (objc_language_defn): Likewise.
10025         * opencl-lang.c (opencl_language_defn): Likewise.
10026         * p-lang.c (pascal_language_defn): Likewise.
10027         * rust-lang.c (rust_language_defn): Likewise.
10028
10029 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10030
10031         * ada-lang.c (ada_is_character_type): Change return type to bool.
10032         (ada_is_string_type): Likewise.
10033         * ada-lang.h (ada_is_character_type): Update declaration
10034         (ada_is_string_type): Likewise.
10035
10036 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10037
10038         Support style in 'frame|thread apply'
10039
10040         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10041         * record.c (record_start, record_stop): Update callers of
10042         execute_command_to_string with false.
10043         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10044         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10045         methods.
10046         (class string_file): New constructor with term_out parameter.
10047         Override methods term_out and can_emit_style_escape.  New member
10048         term_out.
10049         (class stdio_file): Override can_emit_style_escape.
10050         (class tee_file): Override term_out and can_emit_style_escape.
10051         * utils.h (can_emit_style_escape): Remove.
10052         * utils.c (can_emit_style_escape): Likewise.
10053         Update all callers of can_emit_style_escape (SOMESTREAM) to
10054         SOMESTREAM->can_emit_style_escape.
10055         * source-cache.c (source_cache::get_source_lines): Likewise.
10056         * stack.c (frame_apply_command_count): Call execute_command_to_string
10057         passing the term_out characteristic of the current gdb_stdout.
10058         * thread.c (thr_try_catch_cmd): Likewise.
10059         * top.c (execute_command_to_string): pass term_out parameter
10060         to construct the string_file for the command output.
10061         * ui-file.c (term_cli_styling): New function (most code moved
10062         from utils.c can_emit_style_escape).
10063         (string_file::string_file, string_file::can_emit_style_escape,
10064         stdio_file::can_emit_style_escape, tee_file::term_out,
10065         tee_file::can_emit_style_escape): New functions.
10066
10067 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10068
10069         * NEWS: Mention the new set|show may-call-functions.
10070         * infcall.c (may_call_functions_p): New variable.
10071         (show_may_call_functions_p): New function.
10072         (call_function_by_hand_dummy): Throws an error if not
10073         may-call-functions.
10074         (_initialize_infcall): Call add_setshow_boolean_cmd for
10075         may-call-functions.
10076
10077 2019-04-25  Keith Seitz  <keiths@redhat.com>
10078
10079         PR c++/24367
10080         * cp-support.c (inspect_type): Don't attempt substitutions
10081         of symbol with the same name.
10082
10083 2019-04-25  Tom Tromey  <tromey@adacore.com>
10084
10085         PR gdb/24475:
10086         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10087         static.
10088
10089 2019-04-25  Tom Tromey  <tromey@adacore.com>
10090
10091         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10092         rvalue reference.
10093         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10094         (gdb_xml_parser::parse): Use std::move.
10095         * python/python-internal.h (gdbpy_convert_exception): Take a const
10096         reference.
10097         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10098         std::move.
10099         * python/py-utils.c (gdbpy_convert_exception): Take a const
10100         reference.
10101         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10102         Use std::move.
10103         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10104         Use std::move.
10105         * mi/mi-main.c (mi_print_exception): Take a const reference.
10106         * main.c (handle_command_errors): Take a const reference.
10107         * linespec.c (parse_linespec): Use std::move.
10108         * infcall.c (run_inferior_call): Use std::move.
10109         (call_function_by_hand_dummy): Use std::move.
10110         * exec.c (try_open_exec_file): Use std::move.
10111         * exceptions.h (exception_print, exception_fprintf)
10112         (exception_print_same): Update.
10113         * exceptions.c (print_exception, exception_print)
10114         (exception_fprintf, exception_print_same): Change parameters to
10115         const reference.
10116         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10117         * common/new-op.c: Use std::move.
10118         * common/common-exceptions.h (struct gdb_exception): Add move
10119         constructor.
10120         (struct gdb_exception_error, struct gdb_exception_quit, struct
10121         gdb_quit_bad_alloc): Change constructor to move constructor.
10122         (throw_exception): Change parameter to rvalue reference.
10123         * common/common-exceptions.c (throw_exception): Take rvalue
10124         reference.
10125         * cli/cli-interp.c (safe_execute_command): Use std::move.
10126         * breakpoint.c (insert_bp_location, location_to_sals): Use
10127         std::move.
10128
10129 2019-04-25  Tom Tromey  <tromey@adacore.com>
10130
10131         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10132         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10133         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10134         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10135         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10136         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10137         guile/scm-value.c: Use unpack.
10138         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10139         gdbscm_gdb_exception.
10140         (gdbscm_throw_gdb_exception): Likewise.
10141         (struct gdbscm_gdb_exception): New.
10142         (unpack): New function.
10143         (gdbscm_wrap): Use unpack.
10144
10145 2019-04-25  Tom Tromey  <tromey@adacore.com>
10146
10147         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10148         (gdb_rl_callback_handler): Use std::move.
10149         * common/common-exceptions.h (struct gdb_exception): Add move
10150         assignment operator.
10151         (throw_exception_sjlj): Change "exception" to const reference.
10152         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10153         (throw_exception_sjlj): Change "exception" to const reference.
10154
10155 2019-04-25  Tom Tromey  <tromey@adacore.com>
10156
10157         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10158         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10159         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10160         Update.
10161         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10162         Update.
10163         * mi/mi-interp.c (mi_interp::exec): Update.
10164         * linespec.c (parse_linespec): Update.
10165         * infcall.c (run_inferior_call): Update.
10166         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10167         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10168         (gdbscm_lookup_global_symbol): Update.
10169         * guile/scm-param.c (gdbscm_parameter_value): Update.
10170         * guile/scm-frame.c (gdbscm_frame_read_register)
10171         (gdbscm_frame_read_var): Update.
10172         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10173         * exec.c (try_open_exec_file): Update.
10174         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10175         (gdb_rl_callback_handler): Update.
10176         * common/common-exceptions.h (exception_none): Don't declare.
10177         * common/common-exceptions.c (exception_none): Don't define.
10178         (struct catcher) <exception>: Update.
10179         * cli/cli-interp.c (safe_execute_command): Update.
10180         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10181
10182 2019-04-25  Ali Tamur  <tamur@google.com>
10183
10184         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10185         (read_attribute_value): Likewise.
10186         (dwarf2_read_addr_index): Update comment.
10187         (read_str_index): Add DW_FORM_strx.
10188         (dwarf2_string_attr): Likewise.
10189         (dwarf2_const_value_attr): Likewise.
10190         (dump_die_shallow): Likewise.
10191         (dwarf2_fetch_constant_bytes): Likewise.
10192         (skip_form_bytes): Likewise.
10193         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10194
10195 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10196
10197         PR corefiles/11608
10198         PR corefiles/18187
10199         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10200         OFFSET.  Verify if current mapping contains an ELF header.
10201         (linux_find_memory_regions_full): Adjust call to
10202         dump_mapping_p.
10203
10204 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10205             Kang Li <kanglictf@gmail.com>
10206
10207         PR gdb/21600
10208
10209         * dwarf2-frame.c (read_initial_length): Be consistent about using
10210         unsigned representation of length.
10211         (decode_frame_entry_1): Likewise.  Check for wraparound of
10212         end pointer as well as buffer overflow.
10213
10214 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10215
10216         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10217         "vq".
10218
10219 2019-04-24  Tom Tromey  <tromey@adacore.com>
10220
10221         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10222
10223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10224
10225         * s12z-tdep.c (s12z_unwind_pc): Delete.
10226         (s12z_unwind_sp): Delete.
10227         (s12z_gdbarch_init): Don't register deleted functions with
10228         gdbarch.
10229
10230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10231
10232         * rl78-tdep.c (rl78_unwind_sp): Delete.
10233         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10234
10235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10236
10237         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10238         (xstormy16_unwind_pc): Delete.
10239         (xstormy16_dummy_id): Delete.
10240         (xstormy16_gdbarch_init): Don't register deleted functions with
10241         gdbarch.
10242
10243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10244
10245         * vax-tdep.c (vax_unwind_pc): Delete.
10246         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10247
10248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10249
10250         * v850-tdep.c (v850_unwind_sp): Delete.
10251         (v850_unwind_pc): Delete.
10252         (v850_dummy_id): Delete.
10253         (v850_gdbarch_init): Don't register deleted functions with
10254         gdbarch.
10255
10256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10257
10258         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10259         (tilegx_unwind_pc): Delete.
10260         (tilegx_unwind_dummy_id): Delete.
10261         (tilegx_gdbarch_init): Don't register deleted functions with
10262         gdbarch.
10263
10264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10265
10266         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10267         (tic6x_dummy_id): Delete.
10268         (tic6x_gdbarch_init): Don't register deleted functions with
10269         gdbarch.
10270
10271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10272
10273         * sparc-tdep.c (sparc_unwind_pc): Delete.
10274         (sparc32_gdbarch_init): Don't register deleted function with
10275         gdbarch.
10276
10277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10278
10279         * sh-tdep.c (sh_unwind_sp): Delete.
10280         (sh_unwind_pc): Delete.
10281         (sh_dummy_id): Delete.
10282         (sh_gdbarch_init): Don't register deleted functions with
10283         gdbarch.
10284
10285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10286
10287         * score-tdep.c (score_unwind_sp): Delete.
10288         (score_unwind_pc): Delete.
10289         (score_dummy_id): Delete.
10290         (score_gdbarch_init): Don't register deleted functions with
10291         gdbarch.
10292
10293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10294
10295         * rx-tdep.c (rx_unwind_pc): Delete.
10296         (rx_unwind_sp): Delete.
10297         (rx_dummy_id): Delete.
10298         (rx_gdbarch_init): Don't register deleted functions with
10299         gdbarch.  Update comment.
10300
10301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10302
10303         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10304         (rs6000_dummy_id): Delete.
10305         (rs6000_gdbarch_init): Don't register deleted functions with
10306         gdbarch.
10307
10308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10309
10310         * or1k-tdep.c (or1k_dummy_id): Delete.
10311         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10312
10313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10314
10315         * nios2-tdep.c (nios2_dummy_id): Delete.
10316         (nios2_unwind_sp): Delete.
10317         (nios2_gdbarch_init): Don't register deleted functions with
10318         gdbarch.
10319
10320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10321
10322         * nds32-tdep.c (nds32_dummy_id): Delete.
10323         (nds32_unwind_pc): Delete.
10324         (nds32_unwind_sp): Delete.
10325         (nds32_gdbarch_init): Don't register deleted functions with
10326         gdbarch.
10327
10328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10329
10330         * msp430-tdep.c (msp430_unwind_pc): Delete.
10331         (msp430_unwind_sp): Delete.
10332         (msp430_dummy_id): Delete.
10333         (msp430_gdbarch_init): Don't register deleted functions with
10334         gdbarch.
10335
10336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10337
10338         * moxie-tdep.c (moxie_unwind_sp): Delete.
10339         (moxie_unwind_pc): Delete.
10340         (moxie_dummy_id): Delete.
10341         (moxie_gdbarch_init): Don't register deleted functions with
10342         gdbarch.
10343
10344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10345
10346         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10347         (mn10300_unwind_pc): Delete.
10348         (mn10300_unwind_sp): Delete.
10349         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10350         mn10300_unwind_sp.
10351         (mn10300_frame_unwind_init): Don't register deleted functions with
10352         gdbarch.
10353
10354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10355
10356         * mep-tdep.c (mep_unwind_pc): Delete.
10357         (mep_unwind_sp): Delete.
10358         (mep_dummy_id): Delete.
10359         (mep_gdbarch_init): Don't register deleted functions with
10360         gdbarch.
10361
10362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10363
10364         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10365         (m68hc11_unwind_sp): Delete.
10366         (m68hc11_gdbarch_init): Don't register deleted functions with
10367         gdbarch.
10368
10369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10370
10371         * m32r-tdep.c (m32r_unwind_sp): Delete.
10372         (m32r_unwind_pc): Delete.
10373         (m32r_dummy_id): Delete.
10374         (m32r_gdbarch_init): Don't register deleted functions with
10375         gdbarch.
10376
10377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10378
10379         * m32c-tdep.c (m32c_unwind_pc): Delete.
10380         (m32c_unwind_sp): Delete.
10381         (m32c_dummy_id): Delete.
10382         (m32c_gdbarch_init): Don't register deleted functions with
10383         gdbarch.
10384
10385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10386
10387         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10388         (lm32_unwind_pc): Delete.
10389         (lm32_dummy_id): Delete.
10390         (lm32_gdbarch_init): Don't register deleted functions with
10391         gdbarch.
10392
10393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10394
10395         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10396         (iq2000_unwind_pc): Delete.
10397         (iq2000_dummy_id): Delete.
10398         (iq2000_gdbarch_init): Don't register deleted functions with
10399         gdbarch.
10400
10401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10402
10403         * nds32-tdep.c (nds32_type_align): Delete.
10404         (nds32_push_dummy_call): Use type_align instead.
10405
10406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10407
10408         * arm-tdep.c (arm_type_align): Only handle vector override case.
10409         (arm_push_dummy_call): Use type_align.
10410         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10411
10412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10413
10414         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10415         case.
10416         (pass_on_stack): Use type_align.
10417         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10418         function.
10419
10420 2019-04-23  Tom Tromey  <tromey@adacore.com>
10421
10422         * dwarf2read.c (line_header::file_name_at): Remove unused
10423         overload.
10424
10425 2019-04-23  Tom de Vries  <tdevries@suse.de>
10426
10427         PR gdb/24438
10428         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10429         invocation.
10430
10431
10432 2019-03-27  Ali Tamur  <tamur@google.com>
10433
10434         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10435         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10436         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10437         (dwarf_expr_context::get_addr_index): Likewise
10438         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10439         (symbol_needs_eval_context::get_addr_index): Likewise
10440         (disassemble_dwarf_expression): Add DW_OP_addrx
10441         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10442         (read_cutu_die_from_dwo): Update comment
10443         (skip_one_die): Add DW_FORM_addrx
10444         (read_attribute_value): Likewise
10445         (var_decode_location): Add DW_OP_addrx
10446         (dwarf2_const_value_attr): Add DW_FORM_addrx
10447         (dump_die_shallow): Likewise
10448         (dwarf2_fetch_constant_bytes): Likewise
10449         (decode_locdesc): Add DW_OP_addrx
10450         (skip_form_bytes): Add DW_FORM_addrx
10451
10452 2019-04-22  Ali Tamur  <tamur@google.com>
10453
10454         * MAINTAINERS (Write After Approval): Add self.
10455
10456 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10457
10458         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10459         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10460         (open_symbol_file_object): Likewise.
10461         (svr4_default_sos): Add info parameter.
10462         (svr4_read_so_list): Likewise.
10463         (svr4_current_sos_direct): Adjust functions calls to pass down
10464         info.
10465         (svr4_current_sos_1): Add info parameter.
10466         (svr4_current_sos): Call get_svr4_info, pass info down to
10467         svr4_current_sos_1.
10468         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10469         get_svr4_info.
10470         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10471         get_svr4_info.
10472         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10473         to get_svr4_info.
10474         (probes_table_remove_objfile_probes): Likewise.
10475         (register_solib_event_probe): Add info parameter.
10476         (solist_update_incremental): Pass info parameter down to
10477         svr4_read_so_list.
10478         (disable_probes_interface): Add info parameter.
10479         (svr4_handle_solib_event): Pass current_program_space to
10480         get_svr4_info.  Adjust disable_probes_interface cleanup.
10481         (svr4_create_probe_breakpoints): Add info parameter, pass it
10482         down to register_solib_event_probe.
10483         (svr4_create_solib_event_breakpoints): Add info parameter,
10484         pass it down to svr4_create_probe_breakpoints.
10485         (enable_break): Pass info down to
10486         svr4_create_solib_event_breakpoints.
10487         (svr4_solib_create_inferior_hook): Pass current_program_space to
10488         get_svr4_info.
10489         (svr4_clear_solib): Likewise.
10490
10491 2019-04-22  Pedro Alves  <palves@redhat.com>
10492
10493         * solib-svr4.c (svr4_free_objfile_observer): New.
10494         (probe_and_action::objfile): New field.
10495         (probes_table_htab_remove_objfile_probes)
10496         (probes_table_remove_objfile_probes): New functions.
10497         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10498         in the new probe_and_action.  Don't store the probe in 'lookup'.
10499         (svr4_create_probe_breakpoints): Pass objfile to
10500         register_solib_event_probe.
10501         (_initialize_svr4_solib): Register a free_objfile observer.
10502
10503 2019-04-19  Tom Tromey  <tom@tromey.com>
10504
10505         * common/queue.h: Remove.
10506
10507 2019-04-19  Tom Tromey  <tom@tromey.com>
10508
10509         * event-loop.c: Don't include "common/queue.h".
10510
10511 2019-04-19  Tom Tromey  <tom@tromey.com>
10512
10513         * remote.c (remote_target): Use delete.
10514         * remote-notif.h: Include <list>, not "common/queue.h".
10515         (notif_client_p): Remove typedef.
10516         (remote_notif_state): Add constructor, destructor, initializer.
10517         <notif_queue>: Now a std::list.
10518         (remote_notif_state_xfree): Don't declare.
10519         * remote-notif.c (remote_notif_process, handle_notification)
10520         (remote_notif_state_allocate): Update.
10521         (~remote_notif_state): Rename from remote_notif_state_xfree.
10522
10523 2019-04-19  Tom Tromey  <tom@tromey.com>
10524
10525         * symfile.c (reread_symbols): Update.
10526         * objfiles.c (objfile_register_static_link)
10527         (objfile_lookup_static_link): Update
10528         (~objfile) Don't delete static_links.
10529         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10530
10531 2019-04-19  Tom Tromey  <tom@tromey.com>
10532
10533         * type-stack.h (struct type_stack) <insert>: Constify string.
10534         * type-stack.c (type_stack::insert): Constify string.
10535         * gdbtypes.h (lookup_template_type): Update.
10536         (address_space_name_to_int): Update.
10537         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10538         const.
10539         (lookup_template_type): Make name const.
10540         * c-exp.y: Update rules.
10541         (lex_one_token, classify_name, classify_inner_name)
10542         (c_print_token): Update.
10543         * p-exp.y: Update rules.
10544         (yylex): Update.
10545         * f-exp.y: Update rules.
10546         (yylex): Update.
10547         * d-exp.y: Update rules.
10548         (lex_one_token, classify_name, classify_inner_name): Update.
10549         * parse.c (write_dollar_variable, copy_name): Return std::string.
10550         * parser-defs.h (copy_name): Change return type.
10551         * m2-exp.y: Update rules.
10552         (yylex): Update.
10553         * go-exp.y (lex_one_token): Update.
10554         Update rules.
10555         (classify_unsafe_function, classify_packaged_name)
10556         (classify_name, yylex): Update.
10557
10558 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10559
10560         * configure.ac: add --enable-source-highlight switch.
10561         * configure: Regenerate.
10562         * top.c (print_gdb_version): plumb --enable-source-highlight
10563         status to "show configuration".
10564
10565 2019-04-19  Tom Tromey  <tromey@adacore.com>
10566
10567         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10568         Check ADA_TYPE_P.
10569         (empty_record, ada_template_to_fixed_record_type_1)
10570         (template_to_static_fixed_type)
10571         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10572         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10573         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10574         macros.
10575
10576 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10577
10578         PR symtab/24423:
10579         * source.c (print_source_lines_base): Advance "iter" when a
10580         control character is seen.
10581
10582 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10583
10584         * inferior.h (struct infcall_suspend_state_deleter):
10585         Catch exception in destructor to avoid crash.
10586
10587 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10588
10589         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10590         close to the add_com "shell".
10591
10592 2019-04-18  Tom Tromey  <tromey@adacore.com>
10593
10594         * process-stratum-target.h (class process_stratum_target)
10595         <stratum>: Add "final".
10596
10597 2019-04-17  Tom Tromey  <tromey@adacore.com>
10598
10599         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10600         against nullptr before use.
10601
10602 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10603
10604         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10605
10606 2019-04-17  Jim Wilson  <jimw@sifive.com>
10607             Andrew Burgess  <andrew.burgess@embecosm.com>
10608
10609         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10610         code read might fail, assume 4-byte breakpoint in that case.
10611
10612 2019-04-15  Leszek Swirski  <leszeks@google.com>
10613
10614         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10615         rather than a hand-rolled POD check when checking for forced MEMORY
10616         classification.
10617
10618 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10619
10620         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10621         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10622         function.
10623         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10624         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10625         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10626         declaration.
10627
10628 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10629
10630         * aarch64-linux-nat.c
10631         (aarch64_linux_nat_target::thread_architecture): Add override.
10632         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10633         each VQ.
10634
10635 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10636
10637         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10638
10639 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10640
10641         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10642         target types of size 96-bits, add some additional comments, and
10643         check that the builtin type we found was the correct size.
10644
10645 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10646
10647         * utils.c (prompt_for_continue): Don't restore the styling at the
10648         end, as applied_style has the wrong value.  This fixes styling in
10649         long lists of file names that are interrupted by the "Continue?"
10650         prompt.
10651
10652 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10653
10654         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10655         * c-lang.c (c_language_defn): Likewise.
10656         (cplus_language_defn): Likewise.
10657         (asm_language_defn): Likewise.
10658         (minimal_language_defn): Likewise.
10659         * d-lang.c (d_language_defn): Likewise.
10660         * f-lang.c (f_language_defn): Likewise.
10661         * go-lang.c (go_language_defn): Likewise.
10662         * language.c (unknown_language_defn): Likewise.
10663         (auto_language_defn): Likewise.
10664         * language.h (struct language_defn): Remove la_magic field.
10665         (LANG_MAGIC): Delete.
10666         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10667         * objc-lang.c (objc_language_defn): Likewise.
10668         * opencl-lang.c (opencl_language_defn): Likewise.
10669         * p-lang.c (pascal_language_defn): Likewise.
10670         * rust-lang.c (rust_language_defn): Likewise.
10671
10672 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10673
10674         * riscv-tdep.c (riscv_type_align): New function.
10675         (riscv_type_alignment): Delete.
10676         (riscv_arg_location): Use 'type_align'.
10677         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10678
10679 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10680
10681         * gdbtypes.c (type_align): A struct with no non-static fields also
10682         has alignment of 1.
10683
10684 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10685
10686         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10687         component to 0.
10688         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10689         member.
10690         (riscv_struct_info::analyse): New implementation using new
10691         analyse_inner member function.
10692         (riscv_struct_info::field_offset): New member function.
10693         (riscv_struct_info::m_offsets): New member variable.
10694         (riscv_struct_info::analyse_inner): New private member function,
10695         takes the old implementation of riscv_struct_info::analyse but
10696         extended to track field offsets.
10697         (riscv_call_arg_struct): Update the struct folding special cases
10698         to handle cases where empty C++ structs, which are non-zero
10699         length, are found.
10700         (riscv_arg_location): Initialise the length of each location, a
10701         non-zero length now indicates the location is in use.
10702         (riscv_push_dummy_call): Allow for the first location having a
10703         non-zero offset when setting up arguments.
10704         (riscv_return_value): Likewise, but for return values.
10705
10706 2019-04-11  Tom Tromey  <tromey@adacore.com>
10707
10708         * utils.c (internal_vproblem): Make "msg" const.
10709
10710 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10711
10712         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10713         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10714         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10715         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10716
10717 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10718
10719         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10720         function.
10721         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10722         of amd64_collect_native_gregset.
10723         (amd64_linux_nat_target::store_registers): Likewise.
10724
10725 2019-04-10  Tom Tromey  <tom@tromey.com>
10726
10727         * symtab.c (lookup_global_symbol_from_objfile)
10728         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10729         * objfiles.h (class separate_debug_iterator): New.
10730         (class separate_debug_range): New.
10731         (struct objfile) <separate_debug_objfiles>: New method.
10732         (objfile_separate_debug_iterate): Don't declare.
10733         * objfiles.c (separate_debug_iterator::operator++): Rename from
10734         objfile_separate_debug_iterate.
10735         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10736         iterator.
10737         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10738         iterator.
10739
10740 2019-04-10  Tom Tromey  <tom@tromey.com>
10741
10742         * symfile.c (reread_symbols): Remove old comment.
10743         * objfiles.c (free_all_objfiles): Fix a typo.
10744
10745 2019-04-10  Tom Tromey  <tom@tromey.com>
10746
10747         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10748         * minsyms.c (lookup_minimal_symbol): Use foreach.
10749         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10750         (lookup_minimal_symbol_solib_trampoline): Likewise.
10751         * symfile.c (reread_symbols): Use foreach.
10752
10753 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10754             Tom Tromey  <tromey@adacore.com>
10755
10756         PR rust/24414:
10757         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10758         (rust_lex_int_test): Change "value" to be LONGEST.
10759         (rust_lex_tests): Add test for long integer literal.
10760
10761 2019-04-09  Tom Tromey  <tromey@adacore.com>
10762
10763         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10764         to bool.
10765         (extended_remote_target::attach): Update.
10766         (remote_target::remote_notice_new_inferior): Update.
10767         (remote_target::add_current_inferior_and_thread): Update.
10768         * inferior.c (exit_inferior_1): Use "false".
10769         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10770
10771 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10772
10773         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10774         the "start" command.
10775
10776 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10777
10778         * python/py-inferior.c (infpy_thread_from_thread_handle):
10779         Adjust comments to reflect renaming of thread_from_thread_handle
10780         to thread_from_handle.  Adjust keywords.  Fix type error message.
10781         (inferior_object_methods): Add thread_from_handle.  Retain
10782         thread_from_thread_handle, but mark it as deprecated.
10783
10784 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10785
10786         * gdbthread.h (find_thread_by_handle): Revise declaration.
10787         * thread.c (find_thread_by_handle): Likewise.  Adjust
10788         implementation too.
10789         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10790         support for buffer objects as handles.
10791
10792 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10793
10794         * python/py-infthread.c (thpy_thread_handle): New function.
10795         (thread_object_methods): Register thpy_thread_handle.
10796
10797 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10798
10799         * gdbthread.h (thread_to_thread_handle): Declare.
10800         * thread.c (gdbtypes.h): Include.
10801         (thread_to_thread_handle): New function.
10802
10803         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10804         (target_thread_info_to_thread_handle): Declare.
10805         * target.c (target_thread_info_to_thread_handle): New function.
10806         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10807         * target-delegates.c: Regenerate.
10808
10809         * linux-thread-db.c (class thread_db_target): Add method
10810         thread_info_to_thread_handle.
10811         (thread_db_target::thread_info_to_thread_handle): Define.
10812         * remote.c (class remote_target): Add new method
10813         thread_info_to_thread_handle.
10814         (remote_target::thread_info_to_thread_handle): Define.
10815
10816 2019-04-08  Pedro Alves  <palves@redhat.com>
10817
10818         * common/common-exceptions.c (throw_exception): Don't create
10819         named object to throw; throw directly.
10820         (throw_it): Likewise.  Don't initialize gdb_exception::message
10821         here, with new; pass FMT and AP to the ctor instead.
10822         * common/common-exceptions.h: Include <string>.
10823         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10824         const char *, va_list)): New ctor.  Use std::make_shared.
10825         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10826         errors)): Delete.
10827         (gdb_exception_error::gdb_exception_error(enum errors, const char
10828         *, va_list)): New.
10829         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10830         Add assertion.
10831         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10832         errors)): Delete.
10833         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10834         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10835         Add assertion.
10836
10837 2019-04-08  Tom Tromey  <tom@tromey.com>
10838
10839         * valops.c (value_rtti_indirect_type): Replace throw_exception
10840         with throw.
10841         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10842         with throw.
10843         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10844         throw.
10845         * target.c (target_translate_tls_address): Replace throw_exception
10846         with throw.
10847         * stack.c (frame_apply_command_count): Replace throw_exception
10848         with throw.
10849         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10850         throw.
10851         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10852         with throw.
10853         * rs6000-tdep.c (rs6000_frame_cache)
10854         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10855         * remote.c: Replace throw_exception with throw.
10856         * record-full.c (record_full_message, record_full_wait_1)
10857         (record_full_restore): Replace throw_exception with throw.
10858         * record-btrace.c:
10859         (get_thread_current_frame_id, record_btrace_start_replaying)
10860         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10861         (cmd_record_btrace_start): Replace throw_exception with throw.
10862         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10863         throw.
10864         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10865         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10866         * linespec.c:
10867         (find_linespec_symbols): Replace throw_exception with throw.
10868         * infrun.c (displaced_step_prepare, resume): Replace
10869         throw_exception with throw.
10870         * infcmd.c (post_create_inferior): Replace throw_exception with
10871         throw.
10872         * inf-loop.c (inferior_event_handler): Replace throw_exception
10873         with throw.
10874         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10875         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10876         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10877         (get_prev_frame_always, get_frame_pc_if_available)
10878         (get_frame_address_in_block_if_available, get_frame_language):
10879         Replace throw_exception with throw.
10880         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10881         throw_exception with throw.
10882         * eval.c (fetch_subexp_value, evaluate_var_value)
10883         (evaluate_funcall, evaluate_subexp_standard): Replace
10884         throw_exception with throw.
10885         * dwarf2loc.c (call_site_find_chain)
10886         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10887         Replace throw_exception with throw.
10888         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10889         with throw.
10890         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10891         throw.
10892         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10893         * completer.c (complete_line_internal): Replace throw_exception
10894         with throw.
10895         * compile/compile-object-run.c (compile_object_run): Replace
10896         throw_exception with throw.
10897         * cli/cli-script.c (process_next_line): Replace throw_exception
10898         with throw.
10899         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10900         (btrace_enable, btrace_maint_update_pt_packets): Replace
10901         throw_exception with throw.
10902         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10903         throw_exception with throw.
10904         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10905         throw_exception with throw.
10906         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10907         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10908         * aarch64-tdep.c (aarch64_make_prologue_cache)
10909         (aarch64_make_stub_cache): Replace throw_exception with throw.
10910
10911 2019-04-08  Tom Tromey  <tom@tromey.com>
10912
10913         * common/common-exceptions.c (throw_exception): Rename from
10914         throw_exception_cxx.  Remove old copy.  Make argument const.
10915         (throw_it): Create and throw exception objects directly.
10916         * common/common-exceptions.h (throw_exception): Make argument
10917         const.
10918         (struct gdb_exception_error): Add constructor.
10919         (struct gdb_exception_quit): Add constructor.
10920
10921 2019-04-08  Tom Tromey  <tom@tromey.com>
10922
10923         * common/common-exceptions.h (exception_rethrow): Don't declare.
10924         (TRY_SJLJ): Update comment.
10925         (TRY, CATCH, END_CATCH): Remove.
10926         * common/common-exceptions.c (exception_rethrow): Remove.
10927
10928 2019-04-08  Tom Tromey  <tom@tromey.com>
10929
10930         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10931         Remove.
10932         (gdb_exception_error): Rename from
10933         gdb_exception_RETURN_MASK_ERROR.
10934         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10935         (gdb_quit_bad_alloc): Update.
10936         * aarch64-tdep.c: Update.
10937         * ada-lang.c: Update.
10938         * ada-typeprint.c: Update.
10939         * ada-valprint.c: Update.
10940         * amd64-tdep.c: Update.
10941         * arch-utils.c: Update.
10942         * break-catch-throw.c: Update.
10943         * breakpoint.c: Update.
10944         * btrace.c: Update.
10945         * c-varobj.c: Update.
10946         * cli/cli-cmds.c: Update.
10947         * cli/cli-interp.c: Update.
10948         * cli/cli-script.c: Update.
10949         * common/common-exceptions.c: Update.
10950         * common/new-op.c: Update.
10951         * common/selftest.c: Update.
10952         * compile/compile-c-symbols.c: Update.
10953         * compile/compile-cplus-symbols.c: Update.
10954         * compile/compile-object-load.c: Update.
10955         * compile/compile-object-run.c: Update.
10956         * completer.c: Update.
10957         * corelow.c: Update.
10958         * cp-abi.c: Update.
10959         * cp-support.c: Update.
10960         * cp-valprint.c: Update.
10961         * darwin-nat.c: Update.
10962         * disasm-selftests.c: Update.
10963         * dtrace-probe.c: Update.
10964         * dwarf-index-cache.c: Update.
10965         * dwarf-index-write.c: Update.
10966         * dwarf2-frame-tailcall.c: Update.
10967         * dwarf2-frame.c: Update.
10968         * dwarf2loc.c: Update.
10969         * dwarf2read.c: Update.
10970         * eval.c: Update.
10971         * event-loop.c: Update.
10972         * event-top.c: Update.
10973         * exec.c: Update.
10974         * f-valprint.c: Update.
10975         * fbsd-tdep.c: Update.
10976         * frame-unwind.c: Update.
10977         * frame.c: Update.
10978         * gdbtypes.c: Update.
10979         * gnu-v3-abi.c: Update.
10980         * guile/guile-internal.h: Update.
10981         * guile/scm-block.c: Update.
10982         * guile/scm-breakpoint.c: Update.
10983         * guile/scm-cmd.c: Update.
10984         * guile/scm-disasm.c: Update.
10985         * guile/scm-frame.c: Update.
10986         * guile/scm-lazy-string.c: Update.
10987         * guile/scm-math.c: Update.
10988         * guile/scm-param.c: Update.
10989         * guile/scm-ports.c: Update.
10990         * guile/scm-pretty-print.c: Update.
10991         * guile/scm-symbol.c: Update.
10992         * guile/scm-symtab.c: Update.
10993         * guile/scm-type.c: Update.
10994         * guile/scm-value.c: Update.
10995         * i386-linux-tdep.c: Update.
10996         * i386-tdep.c: Update.
10997         * inf-loop.c: Update.
10998         * infcall.c: Update.
10999         * infcmd.c: Update.
11000         * infrun.c: Update.
11001         * jit.c: Update.
11002         * language.c: Update.
11003         * linespec.c: Update.
11004         * linux-fork.c: Update.
11005         * linux-nat.c: Update.
11006         * linux-tdep.c: Update.
11007         * linux-thread-db.c: Update.
11008         * main.c: Update.
11009         * mi/mi-cmd-break.c: Update.
11010         * mi/mi-cmd-stack.c: Update.
11011         * mi/mi-interp.c: Update.
11012         * mi/mi-main.c: Update.
11013         * objc-lang.c: Update.
11014         * p-valprint.c: Update.
11015         * parse.c: Update.
11016         * ppc-linux-tdep.c: Update.
11017         * printcmd.c: Update.
11018         * python/py-arch.c: Update.
11019         * python/py-breakpoint.c: Update.
11020         * python/py-cmd.c: Update.
11021         * python/py-finishbreakpoint.c: Update.
11022         * python/py-frame.c: Update.
11023         * python/py-framefilter.c: Update.
11024         * python/py-gdb-readline.c: Update.
11025         * python/py-inferior.c: Update.
11026         * python/py-infthread.c: Update.
11027         * python/py-lazy-string.c: Update.
11028         * python/py-linetable.c: Update.
11029         * python/py-objfile.c: Update.
11030         * python/py-param.c: Update.
11031         * python/py-prettyprint.c: Update.
11032         * python/py-progspace.c: Update.
11033         * python/py-record-btrace.c: Update.
11034         * python/py-record.c: Update.
11035         * python/py-symbol.c: Update.
11036         * python/py-type.c: Update.
11037         * python/py-unwind.c: Update.
11038         * python/py-utils.c: Update.
11039         * python/py-value.c: Update.
11040         * python/python.c: Update.
11041         * record-btrace.c: Update.
11042         * record-full.c: Update.
11043         * remote-fileio.c: Update.
11044         * remote.c: Update.
11045         * riscv-tdep.c: Update.
11046         * rs6000-aix-tdep.c: Update.
11047         * rs6000-tdep.c: Update.
11048         * rust-exp.y: Update.
11049         * rust-lang.c: Update.
11050         * s390-tdep.c: Update.
11051         * selftest-arch.c: Update.
11052         * solib-dsbt.c: Update.
11053         * solib-frv.c: Update.
11054         * solib-spu.c: Update.
11055         * solib-svr4.c: Update.
11056         * solib.c: Update.
11057         * sparc64-linux-tdep.c: Update.
11058         * stack.c: Update.
11059         * symfile-mem.c: Update.
11060         * symmisc.c: Update.
11061         * target.c: Update.
11062         * thread.c: Update.
11063         * top.c: Update.
11064         * tracefile-tfile.c: Update.
11065         * tui/tui.c: Update.
11066         * typeprint.c: Update.
11067         * unittests/cli-utils-selftests.c: Update.
11068         * unittests/parse-connection-spec-selftests.c: Update.
11069         * valops.c: Update.
11070         * valprint.c: Update.
11071         * value.c: Update.
11072         * varobj.c: Update.
11073         * windows-nat.c: Update.
11074         * x86-linux-nat.c: Update.
11075         * xml-support.c: Update.
11076
11077 2019-04-08  Tom Tromey  <tom@tromey.com>
11078
11079         * xml-support.c: Use C++ exception handling.
11080         * x86-linux-nat.c: Use C++ exception handling.
11081         * windows-nat.c: Use C++ exception handling.
11082         * varobj.c: Use C++ exception handling.
11083         * value.c: Use C++ exception handling.
11084         * valprint.c: Use C++ exception handling.
11085         * valops.c: Use C++ exception handling.
11086         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11087         handling.
11088         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11089         * typeprint.c: Use C++ exception handling.
11090         * tui/tui.c: Use C++ exception handling.
11091         * tracefile-tfile.c: Use C++ exception handling.
11092         * top.c: Use C++ exception handling.
11093         * thread.c: Use C++ exception handling.
11094         * target.c: Use C++ exception handling.
11095         * symmisc.c: Use C++ exception handling.
11096         * symfile-mem.c: Use C++ exception handling.
11097         * stack.c: Use C++ exception handling.
11098         * sparc64-linux-tdep.c: Use C++ exception handling.
11099         * solib.c: Use C++ exception handling.
11100         * solib-svr4.c: Use C++ exception handling.
11101         * solib-spu.c: Use C++ exception handling.
11102         * solib-frv.c: Use C++ exception handling.
11103         * solib-dsbt.c: Use C++ exception handling.
11104         * selftest-arch.c: Use C++ exception handling.
11105         * s390-tdep.c: Use C++ exception handling.
11106         * rust-lang.c: Use C++ exception handling.
11107         * rust-exp.y: Use C++ exception handling.
11108         * rs6000-tdep.c: Use C++ exception handling.
11109         * rs6000-aix-tdep.c: Use C++ exception handling.
11110         * riscv-tdep.c: Use C++ exception handling.
11111         * remote.c: Use C++ exception handling.
11112         * remote-fileio.c: Use C++ exception handling.
11113         * record-full.c: Use C++ exception handling.
11114         * record-btrace.c: Use C++ exception handling.
11115         * python/python.c: Use C++ exception handling.
11116         * python/py-value.c: Use C++ exception handling.
11117         * python/py-utils.c: Use C++ exception handling.
11118         * python/py-unwind.c: Use C++ exception handling.
11119         * python/py-type.c: Use C++ exception handling.
11120         * python/py-symbol.c: Use C++ exception handling.
11121         * python/py-record.c: Use C++ exception handling.
11122         * python/py-record-btrace.c: Use C++ exception handling.
11123         * python/py-progspace.c: Use C++ exception handling.
11124         * python/py-prettyprint.c: Use C++ exception handling.
11125         * python/py-param.c: Use C++ exception handling.
11126         * python/py-objfile.c: Use C++ exception handling.
11127         * python/py-linetable.c: Use C++ exception handling.
11128         * python/py-lazy-string.c: Use C++ exception handling.
11129         * python/py-infthread.c: Use C++ exception handling.
11130         * python/py-inferior.c: Use C++ exception handling.
11131         * python/py-gdb-readline.c: Use C++ exception handling.
11132         * python/py-framefilter.c: Use C++ exception handling.
11133         * python/py-frame.c: Use C++ exception handling.
11134         * python/py-finishbreakpoint.c: Use C++ exception handling.
11135         * python/py-cmd.c: Use C++ exception handling.
11136         * python/py-breakpoint.c: Use C++ exception handling.
11137         * python/py-arch.c: Use C++ exception handling.
11138         * printcmd.c: Use C++ exception handling.
11139         * ppc-linux-tdep.c: Use C++ exception handling.
11140         * parse.c: Use C++ exception handling.
11141         * p-valprint.c: Use C++ exception handling.
11142         * objc-lang.c: Use C++ exception handling.
11143         * mi/mi-main.c: Use C++ exception handling.
11144         * mi/mi-interp.c: Use C++ exception handling.
11145         * mi/mi-cmd-stack.c: Use C++ exception handling.
11146         * mi/mi-cmd-break.c: Use C++ exception handling.
11147         * main.c: Use C++ exception handling.
11148         * linux-thread-db.c: Use C++ exception handling.
11149         * linux-tdep.c: Use C++ exception handling.
11150         * linux-nat.c: Use C++ exception handling.
11151         * linux-fork.c: Use C++ exception handling.
11152         * linespec.c: Use C++ exception handling.
11153         * language.c: Use C++ exception handling.
11154         * jit.c: Use C++ exception handling.
11155         * infrun.c: Use C++ exception handling.
11156         * infcmd.c: Use C++ exception handling.
11157         * infcall.c: Use C++ exception handling.
11158         * inf-loop.c: Use C++ exception handling.
11159         * i386-tdep.c: Use C++ exception handling.
11160         * i386-linux-tdep.c: Use C++ exception handling.
11161         * guile/scm-value.c: Use C++ exception handling.
11162         * guile/scm-type.c: Use C++ exception handling.
11163         * guile/scm-symtab.c: Use C++ exception handling.
11164         * guile/scm-symbol.c: Use C++ exception handling.
11165         * guile/scm-pretty-print.c: Use C++ exception handling.
11166         * guile/scm-ports.c: Use C++ exception handling.
11167         * guile/scm-param.c: Use C++ exception handling.
11168         * guile/scm-math.c: Use C++ exception handling.
11169         * guile/scm-lazy-string.c: Use C++ exception handling.
11170         * guile/scm-frame.c: Use C++ exception handling.
11171         * guile/scm-disasm.c: Use C++ exception handling.
11172         * guile/scm-cmd.c: Use C++ exception handling.
11173         * guile/scm-breakpoint.c: Use C++ exception handling.
11174         * guile/scm-block.c: Use C++ exception handling.
11175         * guile/guile-internal.h: Use C++ exception handling.
11176         * gnu-v3-abi.c: Use C++ exception handling.
11177         * gdbtypes.c: Use C++ exception handling.
11178         * frame.c: Use C++ exception handling.
11179         * frame-unwind.c: Use C++ exception handling.
11180         * fbsd-tdep.c: Use C++ exception handling.
11181         * f-valprint.c: Use C++ exception handling.
11182         * exec.c: Use C++ exception handling.
11183         * event-top.c: Use C++ exception handling.
11184         * event-loop.c: Use C++ exception handling.
11185         * eval.c: Use C++ exception handling.
11186         * dwarf2read.c: Use C++ exception handling.
11187         * dwarf2loc.c: Use C++ exception handling.
11188         * dwarf2-frame.c: Use C++ exception handling.
11189         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11190         * dwarf-index-write.c: Use C++ exception handling.
11191         * dwarf-index-cache.c: Use C++ exception handling.
11192         * dtrace-probe.c: Use C++ exception handling.
11193         * disasm-selftests.c: Use C++ exception handling.
11194         * darwin-nat.c: Use C++ exception handling.
11195         * cp-valprint.c: Use C++ exception handling.
11196         * cp-support.c: Use C++ exception handling.
11197         * cp-abi.c: Use C++ exception handling.
11198         * corelow.c: Use C++ exception handling.
11199         * completer.c: Use C++ exception handling.
11200         * compile/compile-object-run.c: Use C++ exception handling.
11201         * compile/compile-object-load.c: Use C++ exception handling.
11202         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11203         * compile/compile-c-symbols.c: Use C++ exception handling.
11204         * common/selftest.c: Use C++ exception handling.
11205         * common/new-op.c: Use C++ exception handling.
11206         * cli/cli-script.c: Use C++ exception handling.
11207         * cli/cli-interp.c: Use C++ exception handling.
11208         * cli/cli-cmds.c: Use C++ exception handling.
11209         * c-varobj.c: Use C++ exception handling.
11210         * btrace.c: Use C++ exception handling.
11211         * breakpoint.c: Use C++ exception handling.
11212         * break-catch-throw.c: Use C++ exception handling.
11213         * arch-utils.c: Use C++ exception handling.
11214         * amd64-tdep.c: Use C++ exception handling.
11215         * ada-valprint.c: Use C++ exception handling.
11216         * ada-typeprint.c: Use C++ exception handling.
11217         * ada-lang.c: Use C++ exception handling.
11218         * aarch64-tdep.c: Use C++ exception handling.
11219
11220 2019-04-08  Tom Tromey  <tom@tromey.com>
11221
11222         * xml-support.c (gdb_xml_parser::parse): Update.
11223         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11224         * value.c (show_convenience): Update.
11225         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11226         (test_parse_flags_qcs): Update.
11227         * thread.c (thr_try_catch_cmd): Update.
11228         * target.c (target_translate_tls_address): Update.
11229         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11230         (info_frame_command_core, frame_apply_command_count): Update.
11231         * rust-exp.y (rust_lex_exception_test): Update.
11232         * riscv-tdep.c (riscv_print_one_register_info): Update.
11233         * remote.c (remote_target::enable_btrace): Update.
11234         * record-btrace.c (record_btrace_enable_warn): Update.
11235         * python/py-utils.c (gdbpy_convert_exception): Update.
11236         * printcmd.c (do_one_display, print_variable_and_value): Update.
11237         * mi/mi-main.c (mi_print_exception): Update.
11238         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11239         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11240         * linux-nat.c (linux_nat_target::attach): Update.
11241         * linux-fork.c (class scoped_switch_fork_info): Update.
11242         * infrun.c (displaced_step_prepare): Update.
11243         * infcall.c (call_function_by_hand_dummy): Update.
11244         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11245         * gnu-v3-abi.c (print_one_vtable): Update.
11246         * frame.c (get_prev_frame_always): Update.
11247         * f-valprint.c (info_common_command_for_block): Update.
11248         * exec.c (try_open_exec_file): Update.
11249         * exceptions.c (print_exception, exception_print)
11250         (exception_fprintf, exception_print_same): Update.
11251         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11252         * dwarf-index-cache.c (index_cache::store)
11253         (index_cache::lookup_gdb_index): Update.
11254         * darwin-nat.c (maybe_cache_shell): Update.
11255         * cp-valprint.c (cp_print_value_fields): Update.
11256         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11257         (gcc_cplus_symbol_address): Update.
11258         * compile/compile-c-symbols.c (gcc_convert_symbol)
11259         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11260         * common/selftest.c: Update.
11261         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11262         a std::string.
11263         (exception_try_scope_entry, exception_try_scope_exit): Don't
11264         declare.
11265         (struct exception_try_scope): Remove.
11266         (TRY): Don't use exception_try_scope.
11267         (struct gdb_exception): Add constructor, operator=.
11268         <what>: New method.
11269         (struct gdb_exception_RETURN_MASK_ALL)
11270         (struct gdb_exception_RETURN_MASK_ERROR)
11271         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11272         (struct gdb_quit_bad_alloc): Update.
11273         * common/common-exceptions.c (exception_none): Change
11274         initializer.
11275         (struct catcher) <state, exception>: Initialize inline.
11276         <prev>: Remove member.
11277         (current_catcher): Remove.
11278         (catchers): New global.
11279         (exceptions_state_mc_init): Simplify.
11280         (catcher_pop): Remove.
11281         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11282         (try_scope_depth, exception_try_scope_entry)
11283         (exception_try_scope_exit): Remove.
11284         (throw_exception_sjlj): Update.
11285         (exception_messages, exception_messages_size): Remove.
11286         (throw_it): Simplify.
11287         (gdb_exception_sliced_copy): Remove.
11288         (throw_exception_cxx): Update.
11289         * cli/cli-script.c (script_from_file): Update.
11290         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11291         Update.
11292         * ada-valprint.c (ada_val_print): Update.
11293         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11294         (create_excep_cond_exprs): Update.
11295
11296 2019-04-08  Tom Tromey  <tom@tromey.com>
11297
11298         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11299         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11300         (TRY, CATCH, END_CATCH): Remove some definitions.
11301         * common/common-exceptions.c: Don't use GDB_XCPT.
11302         (catcher_list_size): Remove.
11303         (throw_exception, throw_it): Simplify.
11304
11305 2019-04-05  Tom Tromey  <tom@tromey.com>
11306
11307         Revert the header-sorting patch.
11308         * ft32-tdep.c: Revert.
11309         * frv-tdep.c: Revert.
11310         * frv-linux-tdep.c: Revert.
11311         * frame.c: Revert.
11312         * frame-unwind.c: Revert.
11313         * frame-base.c: Revert.
11314         * fork-child.c: Revert.
11315         * findvar.c: Revert.
11316         * findcmd.c: Revert.
11317         * filesystem.c: Revert.
11318         * filename-seen-cache.h: Revert.
11319         * filename-seen-cache.c: Revert.
11320         * fbsd-tdep.c: Revert.
11321         * fbsd-nat.h: Revert.
11322         * fbsd-nat.c: Revert.
11323         * f-valprint.c: Revert.
11324         * f-typeprint.c: Revert.
11325         * f-lang.c: Revert.
11326         * extension.h: Revert.
11327         * extension.c: Revert.
11328         * extension-priv.h: Revert.
11329         * expprint.c: Revert.
11330         * exec.h: Revert.
11331         * exec.c: Revert.
11332         * exceptions.c: Revert.
11333         * event-top.c: Revert.
11334         * event-loop.c: Revert.
11335         * eval.c: Revert.
11336         * elfread.c: Revert.
11337         * dwarf2read.h: Revert.
11338         * dwarf2read.c: Revert.
11339         * dwarf2loc.c: Revert.
11340         * dwarf2expr.h: Revert.
11341         * dwarf2expr.c: Revert.
11342         * dwarf2-frame.c: Revert.
11343         * dwarf2-frame-tailcall.c: Revert.
11344         * dwarf-index-write.h: Revert.
11345         * dwarf-index-write.c: Revert.
11346         * dwarf-index-common.c: Revert.
11347         * dwarf-index-cache.h: Revert.
11348         * dwarf-index-cache.c: Revert.
11349         * dummy-frame.c: Revert.
11350         * dtrace-probe.c: Revert.
11351         * disasm.h: Revert.
11352         * disasm.c: Revert.
11353         * disasm-selftests.c: Revert.
11354         * dictionary.c: Revert.
11355         * dicos-tdep.c: Revert.
11356         * demangle.c: Revert.
11357         * dcache.h: Revert.
11358         * dcache.c: Revert.
11359         * darwin-nat.h: Revert.
11360         * darwin-nat.c: Revert.
11361         * darwin-nat-info.c: Revert.
11362         * d-valprint.c: Revert.
11363         * d-namespace.c: Revert.
11364         * d-lang.c: Revert.
11365         * ctf.c: Revert.
11366         * csky-tdep.c: Revert.
11367         * csky-linux-tdep.c: Revert.
11368         * cris-tdep.c: Revert.
11369         * cris-linux-tdep.c: Revert.
11370         * cp-valprint.c: Revert.
11371         * cp-support.c: Revert.
11372         * cp-namespace.c: Revert.
11373         * cp-abi.c: Revert.
11374         * corelow.c: Revert.
11375         * corefile.c: Revert.
11376         * continuations.c: Revert.
11377         * completer.h: Revert.
11378         * completer.c: Revert.
11379         * complaints.c: Revert.
11380         * coffread.c: Revert.
11381         * coff-pe-read.c: Revert.
11382         * cli-out.h: Revert.
11383         * cli-out.c: Revert.
11384         * charset.c: Revert.
11385         * c-varobj.c: Revert.
11386         * c-valprint.c: Revert.
11387         * c-typeprint.c: Revert.
11388         * c-lang.c: Revert.
11389         * buildsym.c: Revert.
11390         * buildsym-legacy.c: Revert.
11391         * build-id.h: Revert.
11392         * build-id.c: Revert.
11393         * btrace.c: Revert.
11394         * bsd-uthread.c: Revert.
11395         * breakpoint.h: Revert.
11396         * breakpoint.c: Revert.
11397         * break-catch-throw.c: Revert.
11398         * break-catch-syscall.c: Revert.
11399         * break-catch-sig.c: Revert.
11400         * blockframe.c: Revert.
11401         * block.c: Revert.
11402         * bfin-tdep.c: Revert.
11403         * bfin-linux-tdep.c: Revert.
11404         * bfd-target.c: Revert.
11405         * bcache.c: Revert.
11406         * ax-general.c: Revert.
11407         * ax-gdb.h: Revert.
11408         * ax-gdb.c: Revert.
11409         * avr-tdep.c: Revert.
11410         * auxv.c: Revert.
11411         * auto-load.c: Revert.
11412         * arm-wince-tdep.c: Revert.
11413         * arm-tdep.c: Revert.
11414         * arm-symbian-tdep.c: Revert.
11415         * arm-pikeos-tdep.c: Revert.
11416         * arm-obsd-tdep.c: Revert.
11417         * arm-nbsd-tdep.c: Revert.
11418         * arm-nbsd-nat.c: Revert.
11419         * arm-linux-tdep.c: Revert.
11420         * arm-linux-nat.c: Revert.
11421         * arm-fbsd-tdep.c: Revert.
11422         * arm-fbsd-nat.c: Revert.
11423         * arm-bsd-tdep.c: Revert.
11424         * arch-utils.c: Revert.
11425         * arc-tdep.c: Revert.
11426         * arc-newlib-tdep.c: Revert.
11427         * annotate.h: Revert.
11428         * annotate.c: Revert.
11429         * amd64-windows-tdep.c: Revert.
11430         * amd64-windows-nat.c: Revert.
11431         * amd64-tdep.c: Revert.
11432         * amd64-sol2-tdep.c: Revert.
11433         * amd64-obsd-tdep.c: Revert.
11434         * amd64-obsd-nat.c: Revert.
11435         * amd64-nbsd-tdep.c: Revert.
11436         * amd64-nbsd-nat.c: Revert.
11437         * amd64-nat.c: Revert.
11438         * amd64-linux-tdep.c: Revert.
11439         * amd64-linux-nat.c: Revert.
11440         * amd64-fbsd-tdep.c: Revert.
11441         * amd64-fbsd-nat.c: Revert.
11442         * amd64-dicos-tdep.c: Revert.
11443         * amd64-darwin-tdep.c: Revert.
11444         * amd64-bsd-nat.c: Revert.
11445         * alpha-tdep.c: Revert.
11446         * alpha-obsd-tdep.c: Revert.
11447         * alpha-nbsd-tdep.c: Revert.
11448         * alpha-mdebug-tdep.c: Revert.
11449         * alpha-linux-tdep.c: Revert.
11450         * alpha-linux-nat.c: Revert.
11451         * alpha-bsd-tdep.c: Revert.
11452         * alpha-bsd-nat.c: Revert.
11453         * aix-thread.c: Revert.
11454         * agent.c: Revert.
11455         * addrmap.c: Revert.
11456         * ada-varobj.c: Revert.
11457         * ada-valprint.c: Revert.
11458         * ada-typeprint.c: Revert.
11459         * ada-tasks.c: Revert.
11460         * ada-lang.c: Revert.
11461         * aarch64-tdep.c: Revert.
11462         * aarch64-ravenscar-thread.c: Revert.
11463         * aarch64-newlib-tdep.c: Revert.
11464         * aarch64-linux-tdep.c: Revert.
11465         * aarch64-linux-nat.c: Revert.
11466         * aarch64-fbsd-tdep.c: Revert.
11467         * aarch64-fbsd-nat.c: Revert.
11468         * aarch32-linux-nat.c: Revert.
11469
11470 2019-04-05  Tom Tromey  <tom@tromey.com>
11471
11472         * ft32-tdep.c: Sort headers.
11473         * frv-tdep.c: Sort headers.
11474         * frv-linux-tdep.c: Sort headers.
11475         * frame.c: Sort headers.
11476         * frame-unwind.c: Sort headers.
11477         * frame-base.c: Sort headers.
11478         * fork-child.c: Sort headers.
11479         * findvar.c: Sort headers.
11480         * findcmd.c: Sort headers.
11481         * filesystem.c: Sort headers.
11482         * filename-seen-cache.h: Sort headers.
11483         * filename-seen-cache.c: Sort headers.
11484         * fbsd-tdep.c: Sort headers.
11485         * fbsd-nat.h: Sort headers.
11486         * fbsd-nat.c: Sort headers.
11487         * f-valprint.c: Sort headers.
11488         * f-typeprint.c: Sort headers.
11489         * f-lang.c: Sort headers.
11490         * extension.h: Sort headers.
11491         * extension.c: Sort headers.
11492         * extension-priv.h: Sort headers.
11493         * expprint.c: Sort headers.
11494         * exec.h: Sort headers.
11495         * exec.c: Sort headers.
11496         * exceptions.c: Sort headers.
11497         * event-top.c: Sort headers.
11498         * event-loop.c: Sort headers.
11499         * eval.c: Sort headers.
11500         * elfread.c: Sort headers.
11501         * dwarf2read.h: Sort headers.
11502         * dwarf2read.c: Sort headers.
11503         * dwarf2loc.c: Sort headers.
11504         * dwarf2expr.h: Sort headers.
11505         * dwarf2expr.c: Sort headers.
11506         * dwarf2-frame.c: Sort headers.
11507         * dwarf2-frame-tailcall.c: Sort headers.
11508         * dwarf-index-write.h: Sort headers.
11509         * dwarf-index-write.c: Sort headers.
11510         * dwarf-index-common.c: Sort headers.
11511         * dwarf-index-cache.h: Sort headers.
11512         * dwarf-index-cache.c: Sort headers.
11513         * dummy-frame.c: Sort headers.
11514         * dtrace-probe.c: Sort headers.
11515         * disasm.h: Sort headers.
11516         * disasm.c: Sort headers.
11517         * disasm-selftests.c: Sort headers.
11518         * dictionary.c: Sort headers.
11519         * dicos-tdep.c: Sort headers.
11520         * demangle.c: Sort headers.
11521         * dcache.h: Sort headers.
11522         * dcache.c: Sort headers.
11523         * darwin-nat.h: Sort headers.
11524         * darwin-nat.c: Sort headers.
11525         * darwin-nat-info.c: Sort headers.
11526         * d-valprint.c: Sort headers.
11527         * d-namespace.c: Sort headers.
11528         * d-lang.c: Sort headers.
11529         * ctf.c: Sort headers.
11530         * csky-tdep.c: Sort headers.
11531         * csky-linux-tdep.c: Sort headers.
11532         * cris-tdep.c: Sort headers.
11533         * cris-linux-tdep.c: Sort headers.
11534         * cp-valprint.c: Sort headers.
11535         * cp-support.c: Sort headers.
11536         * cp-namespace.c: Sort headers.
11537         * cp-abi.c: Sort headers.
11538         * corelow.c: Sort headers.
11539         * corefile.c: Sort headers.
11540         * continuations.c: Sort headers.
11541         * completer.h: Sort headers.
11542         * completer.c: Sort headers.
11543         * complaints.c: Sort headers.
11544         * coffread.c: Sort headers.
11545         * coff-pe-read.c: Sort headers.
11546         * cli-out.h: Sort headers.
11547         * cli-out.c: Sort headers.
11548         * charset.c: Sort headers.
11549         * c-varobj.c: Sort headers.
11550         * c-valprint.c: Sort headers.
11551         * c-typeprint.c: Sort headers.
11552         * c-lang.c: Sort headers.
11553         * buildsym.c: Sort headers.
11554         * buildsym-legacy.c: Sort headers.
11555         * build-id.h: Sort headers.
11556         * build-id.c: Sort headers.
11557         * btrace.c: Sort headers.
11558         * bsd-uthread.c: Sort headers.
11559         * breakpoint.h: Sort headers.
11560         * breakpoint.c: Sort headers.
11561         * break-catch-throw.c: Sort headers.
11562         * break-catch-syscall.c: Sort headers.
11563         * break-catch-sig.c: Sort headers.
11564         * blockframe.c: Sort headers.
11565         * block.c: Sort headers.
11566         * bfin-tdep.c: Sort headers.
11567         * bfin-linux-tdep.c: Sort headers.
11568         * bfd-target.c: Sort headers.
11569         * bcache.c: Sort headers.
11570         * ax-general.c: Sort headers.
11571         * ax-gdb.h: Sort headers.
11572         * ax-gdb.c: Sort headers.
11573         * avr-tdep.c: Sort headers.
11574         * auxv.c: Sort headers.
11575         * auto-load.c: Sort headers.
11576         * arm-wince-tdep.c: Sort headers.
11577         * arm-tdep.c: Sort headers.
11578         * arm-symbian-tdep.c: Sort headers.
11579         * arm-pikeos-tdep.c: Sort headers.
11580         * arm-obsd-tdep.c: Sort headers.
11581         * arm-nbsd-tdep.c: Sort headers.
11582         * arm-nbsd-nat.c: Sort headers.
11583         * arm-linux-tdep.c: Sort headers.
11584         * arm-linux-nat.c: Sort headers.
11585         * arm-fbsd-tdep.c: Sort headers.
11586         * arm-fbsd-nat.c: Sort headers.
11587         * arm-bsd-tdep.c: Sort headers.
11588         * arch-utils.c: Sort headers.
11589         * arc-tdep.c: Sort headers.
11590         * arc-newlib-tdep.c: Sort headers.
11591         * annotate.h: Sort headers.
11592         * annotate.c: Sort headers.
11593         * amd64-windows-tdep.c: Sort headers.
11594         * amd64-windows-nat.c: Sort headers.
11595         * amd64-tdep.c: Sort headers.
11596         * amd64-sol2-tdep.c: Sort headers.
11597         * amd64-obsd-tdep.c: Sort headers.
11598         * amd64-obsd-nat.c: Sort headers.
11599         * amd64-nbsd-tdep.c: Sort headers.
11600         * amd64-nbsd-nat.c: Sort headers.
11601         * amd64-nat.c: Sort headers.
11602         * amd64-linux-tdep.c: Sort headers.
11603         * amd64-linux-nat.c: Sort headers.
11604         * amd64-fbsd-tdep.c: Sort headers.
11605         * amd64-fbsd-nat.c: Sort headers.
11606         * amd64-dicos-tdep.c: Sort headers.
11607         * amd64-darwin-tdep.c: Sort headers.
11608         * amd64-bsd-nat.c: Sort headers.
11609         * alpha-tdep.c: Sort headers.
11610         * alpha-obsd-tdep.c: Sort headers.
11611         * alpha-nbsd-tdep.c: Sort headers.
11612         * alpha-mdebug-tdep.c: Sort headers.
11613         * alpha-linux-tdep.c: Sort headers.
11614         * alpha-linux-nat.c: Sort headers.
11615         * alpha-bsd-tdep.c: Sort headers.
11616         * alpha-bsd-nat.c: Sort headers.
11617         * aix-thread.c: Sort headers.
11618         * agent.c: Sort headers.
11619         * addrmap.c: Sort headers.
11620         * ada-varobj.c: Sort headers.
11621         * ada-valprint.c: Sort headers.
11622         * ada-typeprint.c: Sort headers.
11623         * ada-tasks.c: Sort headers.
11624         * ada-lang.c: Sort headers.
11625         * aarch64-tdep.c: Sort headers.
11626         * aarch64-ravenscar-thread.c: Sort headers.
11627         * aarch64-newlib-tdep.c: Sort headers.
11628         * aarch64-linux-tdep.c: Sort headers.
11629         * aarch64-linux-nat.c: Sort headers.
11630         * aarch64-fbsd-tdep.c: Sort headers.
11631         * aarch64-fbsd-nat.c: Sort headers.
11632         * aarch32-linux-nat.c: Sort headers.
11633
11634 2019-04-04  Tom Tromey  <tom@tromey.com>
11635
11636         * varobj.c (varobj_create): Update.
11637         * rust-exp.y (struct rust_parser) <update_innermost_block,
11638         lookup_symbol>: New methods.
11639         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11640         Rename.
11641         (rust_parser::rust_lookup_type)
11642         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11643         * printcmd.c (display_command, do_one_display): Update.
11644         * parser-defs.h (struct parser_state) <parser_state>: Add
11645         "tracker" parameter.
11646         (block_tracker): New member.
11647         (class innermost_block_tracker) <innermost_block_tracker>: Add
11648         "types" parameter.
11649         <reset>: Remove method.
11650         (innermost_block): Don't declare.
11651         (null_post_parser): Update.
11652         * parse.c (innermost_block): Remove global.
11653         (write_dollar_variable): Update.
11654         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11655         Remove "tracker_types" parameter.
11656         (parse_expression): Add "tracker" parameter.
11657         (parse_expression_for_completion): Update.
11658         (null_post_parser): Add "tracker" parameter.
11659         * p-exp.y: Update rules.
11660         * m2-exp.y: Update rules.
11661         * language.h (struct language_defn) <la_post_parser>: Add
11662         "tracker" parameter.
11663         * go-exp.y: Update rules.
11664         * f-exp.y: Update rules.
11665         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11666         parameter.
11667         * d-exp.y: Update rules.
11668         * c-exp.y: Update rules.
11669         * breakpoint.c (set_breakpoint_condition): Create an
11670         innermost_block_tracker.
11671         (watch_command_1): Likewise.
11672         * ada-lang.c (resolve): Add "tracker" parameter.
11673         (resolve_subexp): Likewise.
11674         * ada-exp.y (write_var_from_sym): Update.
11675
11676 2019-04-04  Tom Tromey  <tom@tromey.com>
11677
11678         * type-stack.h: New file.
11679         * type-stack.c: New file.
11680         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11681         type-stack.h.
11682         (insert_into_type_stack, insert_type, push_type, push_type_int)
11683         (insert_type_address_space, pop_type, pop_type_int)
11684         (pop_typelist, pop_type_stack, append_type_stack)
11685         (push_type_stack, get_type_stack, push_typelist)
11686         (follow_type_instance_flags, follow_types): Don't declare.
11687         * parse.c (type_stack): Remove global.
11688         (parse_exp_in_context): Update.
11689         (insert_into_type_stack, insert_type, push_type, push_type_int)
11690         (insert_type_address_space, pop_type, pop_type_int)
11691         (pop_typelist, pop_type_stack, append_type_stack)
11692         (push_type_stack, get_type_stack, push_typelist)
11693         (follow_type_instance_flags, follow_types): Remove (moved to
11694         type-stack.c).
11695         * f-exp.y (type_stack): New global.
11696         Update rules.
11697         (push_kind_type, f_parse): Update.
11698         * d-exp.y (type_stack): New global.
11699         Update rules.
11700         (d_parse): Update.
11701         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11702         Update rules.
11703         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11704         (HFILES_NO_SRCDIR): Add type-stack.h.
11705
11706 2019-04-04  Tom Tromey  <tom@tromey.com>
11707
11708         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11709         (rust_parser::convert_ast_to_expression, rust_parse)
11710         (rust_lex_test_completion, rust_lex_tests): Update.
11711         * parser-defs.h (struct expr_completion_state): New.
11712         (struct parser_state) <parser_state>: Add completion parameter.
11713         <mark_struct_expression, mark_completion_tag>: New methods.
11714         <parse_completion, m_completion_state>: New members.
11715         (prefixify_expression, null_post_parser): Update.
11716         (mark_struct_expression, mark_completion_tag): Don't declare.
11717         * parse.c (parse_completion, expout_last_struct)
11718         (expout_tag_completion_type, expout_completion_name): Remove
11719         globals.
11720         (parser_state::mark_struct_expression)
11721         (parser_state::mark_completion_tag): Now methods.
11722         (prefixify_expression): Add last_struct parameter.
11723         (prefixify_subexp): Likewise.
11724         (parse_exp_1): Update.
11725         (parse_exp_in_context): Add cstate parameter.  Update.
11726         (parse_expression_for_completion): Create an
11727         expr_completion_state.
11728         (null_post_parser): Add "completion" parameter.
11729         * p-exp.y: Update rules.
11730         (yylex): Update.
11731         * language.h (struct language_defn) <la_post_parser>: Add
11732         "completing" parameter.
11733         * go-exp.y: Update rules.
11734         (lex_one_token): Update.
11735         * expression.h (parse_completion): Don't declare.
11736         * d-exp.y: Update rules.
11737         (lex_one_token): Update rules.
11738         * c-exp.y: Update rules.
11739         (lex_one_token): Update.
11740         * ada-lang.c (resolve): Add "parse_completion" parameter.
11741         (resolve_subexp): Likewise.
11742         (ada_resolve_function): Likewise.
11743
11744 2019-04-04  Tom Tromey  <tom@tromey.com>
11745
11746         * parser-defs.h (struct parser_state) <start_arglist,
11747         end_arglist>: New methods.
11748         <arglist_len, m_funcall_chain>: New members.
11749         (arglist_len, start_arglist, end_arglist): Don't declare.
11750         * parse.c (arglist_len, funcall_chain): Remove global.
11751         (start_arglist, end_arglist): Remove functions.
11752         (parse_exp_in_context): Update.
11753         * p-exp.y: Update rules.
11754         * m2-exp.y: Update rules.
11755         * go-exp.y: Update rules.
11756         * f-exp.y: Update rules.
11757         * d-exp.y: Update rules.
11758         * c-exp.y: Update rules.
11759
11760 2019-04-04  Tom Tromey  <tom@tromey.com>
11761
11762         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11763         lex_operator, push_back>: New methods.
11764         Update all rules.
11765         (rust_parser::lex_hex, lex_escape): Rename and update.
11766         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11767         (rust_parser::lex_operator): Rename and update.
11768         (rust_parser::lex_number, rustyylex, rustyyerror)
11769         (rust_lex_test_init, rust_lex_test_sequence)
11770         (rust_lex_test_push_back, rust_lex_tests): Update.
11771         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11772         parameter.
11773         <lexptr, prev_lexptr>: New members.
11774         (lexptr, prev_lexptr): Don't declare.
11775         * parse.c (lexptr, prev_lexptr): Remove globals.
11776         (parse_exp_in_context): Update.
11777         * p-exp.y (yylex, yyerror): Update.
11778         * m2-exp.y (parse_number, yylex, yyerror): Update.
11779         * go-exp.y (lex_one_token, yyerror): Update.
11780         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11781         * d-exp.y (lex_one_token, yyerror): Update.
11782         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11783         (lex_one_token, yyerror): Update.
11784         * ada-lex.l (YY_INPUT): Update.
11785         (rewind_to_char): Update.
11786         * ada-exp.y (yyerror): Update.
11787
11788 2019-04-04  Tom Tromey  <tom@tromey.com>
11789
11790         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11791         * parser-defs.h (struct parser_state) <parser_state>: Add new
11792         parameter.
11793         <comma_terminates>: New member.
11794         (comma_terminates): Don't declare global.
11795         * parse.c (comma_terminates): Remove global.
11796         (parse_exp_in_context): Update.
11797         * p-exp.y (yylex): Update.
11798         * m2-exp.y (yylex): Update.
11799         * go-exp.y (lex_one_token): Update.
11800         * f-exp.y (yylex): Update.
11801         * d-exp.y (lex_one_token): Update.
11802         * c-exp.y (lex_one_token): Update.
11803         * ada-lex.l: Update.
11804
11805 2019-04-04  Tom Tromey  <tom@tromey.com>
11806
11807         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11808         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11809         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11810         * parser-defs.h (paren_depth): Don't declare.
11811         * parse.c (paren_depth): Remove global.
11812         (parse_exp_in_context): Update.
11813         * p-exp.y (paren_depth): New global.
11814         (pascal_parse): Initialize it.
11815         * m2-exp.y (paren_depth): New global.
11816         (m2_parse): Initialize it.
11817         * go-exp.y (paren_depth): New global.
11818         (go_parse): Initialize it.
11819         * f-exp.y (paren_depth): New global.
11820         (f_parse): Initialize it.
11821         * d-exp.y (paren_depth): New global.
11822         (d_parse): Initialize it.
11823         * c-exp.y (paren_depth): New global.
11824         (c_parse): Initialize it.
11825         * ada-lex.l (paren_depth): New global.
11826         (lexer_init): Initialize it.
11827
11828 2019-04-04  Tom Tromey  <tom@tromey.com>
11829
11830         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11831         (rust_parser::convert_ast_to_type)
11832         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11833         * parser-defs.h (struct parser_state) <parser_state>: Add
11834         parameters.  Initialize new members.
11835         <expression_context_block, expression_context_pc>: New members.
11836         * parse.c (expression_context_block, expression_context_pc):
11837         Remove globals.
11838         (parse_exp_in_context): Update.
11839         * p-exp.y: Update all rules.
11840         (yylex): Update.
11841         * m2-exp.y: Update all rules.
11842         (yylex): Update.
11843         * go-exp.y (yylex): Update.
11844         * f-exp.y (yylex): Update.
11845         * d-exp.y: Update all rules.
11846         (yylex): Update.
11847         * c-exp.y: Update all rules.
11848         (lex_one_token, classify_name, yylex, c_parse): Update.
11849         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11850
11851 2019-04-04  Tom Tromey  <tom@tromey.com>
11852
11853         * gdbarch.h, gdbarch.c: Rebuild.
11854         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11855         * stap-probe.h:
11856         (struct stap_parse_info): Replace "parser_state" with
11857         "expr_builder".
11858         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11859         (parser_state): New class.
11860         * parse.c (expr_builder): Rename.
11861         (expr_builder::release): Rename.
11862         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11863         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11864         (write_exp_elt_longcst, write_exp_elt_floatcst)
11865         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11866         (write_exp_string_vector, write_exp_bitstring)
11867         (write_exp_msymbol, mark_struct_expression)
11868         (write_dollar_variable)
11869         (insert_type_address_space, increase_expout_size): Replace
11870         "parser_state" with "expr_builder".
11871         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11872         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11873         "parser_state" with "expr_builder".
11874
11875 2019-04-04  Tom Tromey  <tom@tromey.com>
11876
11877         * rust-exp.y: Replace "parse_language" with method call.
11878         * p-exp.y:
11879         (yylex): Replace "parse_language" with method call.
11880         * m2-exp.y:
11881         (yylex): Replace "parse_language" with method call.
11882         * go-exp.y (classify_name): Replace "parse_language" with method
11883         call.
11884         * f-exp.y (yylex): Replace "parse_language" with method call.
11885         * d-exp.y (lex_one_token): Replace "parse_language" with method
11886         call.
11887         * c-exp.y:
11888         (lex_one_token, classify_name, yylex): Replace "parse_language"
11889         with method call.
11890         * ada-exp.y (find_primitive_type, type_char)
11891         (type_system_address): Replace "parse_language" with method call.
11892
11893 2019-04-04  Tom Tromey  <tom@tromey.com>
11894
11895         * rust-exp.y: Replace "parse_gdbarch" with method call.
11896         * parse.c (write_dollar_variable, insert_type_address_space):
11897         Replace "parse_gdbarch" with method call.
11898         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11899         call.
11900         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11901         call.
11902         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11903         "parse_gdbarch" with method call.
11904         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11905         with method call.
11906         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11907         "parse_gdbarch" with method call.
11908         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11909         "parse_gdbarch" with method call.
11910         * c-exp.y (parse_type, parse_number, classify_name): Replace
11911         "parse_gdbarch" with method call.
11912         * ada-lex.l: Replace "parse_gdbarch" with method call.
11913         * ada-exp.y (parse_type, find_primitive_type, type_char)
11914         (type_system_address): Replace "parse_gdbarch" with method call.
11915
11916 2019-04-04  Tom Tromey  <tom@tromey.com>
11917
11918         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11919         * stap-probe.c (stap_parse_argument): Update.
11920         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11921         initial_size parameter.
11922         * rust-exp.y (rust_lex_tests): Update.
11923         * parse.c (parser_state): Update.
11924         (parse_exp_in_context): Update.
11925         * parser-defs.h (struct parser_state) <parser_state>: Remove
11926         "initial_size" parameter.
11927
11928 2019-04-04  Tom Tromey  <tom@tromey.com>
11929
11930         * parser-defs.h (increase_expout_size): Don't declare.
11931         * parse.c (increase_expout_size): Now static.
11932
11933 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11934
11935         * gnu-nat.c (gnu_nat_target::wait): Fix
11936         target_waitstatus_to_string call.
11937
11938 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11939
11940         * eval.c (evaluate_subexp_standard): Handle internal functions
11941         during Fortran function call handling.
11942
11943 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11944
11945         * NEWS: Mention new internal functions.
11946         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11947         (read_base_type): Use dwarf2_init_complex_target_type.
11948         * value.c (creal_internal_fn): New function.
11949         (cimag_internal_fn): New function.
11950         (_initialize_values): Register new internal functions.
11951
11952 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11953
11954         * infrun.c (stop_all_threads): If debug_infrun, always
11955         trace the wait status after wait_one, using
11956         target_waitstatus_to_string and target_pid_to_str.
11957         (handle_inferior_event): Replace various trace of
11958         wait status kind by a single trace.
11959         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11960         wait status kind image by target_waitstatus_to_string.
11961         * target/waitstatus.c (target_waitstatus_to_string): Fix
11962         obsolete comment.
11963
11964 2019-04-01  Tom Tromey  <tromey@adacore.com>
11965
11966         PR symtab/23331:
11967         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11968
11969 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11970             Pedro Alves  <palves@redhat.com>
11971
11972         * top.c (quit_force): Call 'finalize_values'.
11973         * value.c (finalize_values): New function.
11974         * value.h (finalize_values): Declare.
11975
11976 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11977
11978         * NEWS: Announce $_gdb_major and $_gdb_minor.
11979
11980         * top.c (init_gdb_version_vars): New function.
11981         (gdb_init): Call init_gdb_version_vars.
11982
11983 2019-03-29  Tom Tromey  <tromey@adacore.com>
11984
11985         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11986         help text.  Remove dead code.
11987
11988 2019-03-29  Keith Seitz  <keiths@redhat.com>
11989
11990         From Siddhesh Poyarekar:
11991         * f-lang.h (f77_get_upperbound): Return LONGEST.
11992         (f77_get_lowerbound): Likewise.
11993         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11994         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11995         print them.
11996         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11997         plongest to format print it.
11998         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11999         (f77_get_upperbound): Likewise.
12000         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12001         LOWER_BOUND to LONGEST.
12002         (f77_create_arrayprint_offset_tbl): Likewise.
12003
12004 2019-03-29  Keith Seitz  <keiths@redhat.com>
12005
12006         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12007         %s/pulongest for TYPE_LENGTH instead of %d in format
12008         strings.
12009         * ada-typerint.c (ada_print_type): Likewise.
12010         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12011         * compile/compile-c-support.c (generate_register_struct): Likewise.
12012         * gdbtypes.c (recursive_dump_type): Likewise.
12013         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12014         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12015         instead of %d in format strings.
12016         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12017         to std::min to ULONGEST.
12018         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12019         instead of %d in format strings.
12020         * tracepoint.c (info_scope_command): Likewise.
12021         * typeprint.c (print_offset_data::update)
12022         (print_offset_data::finish): Likewise.
12023         * xtensa-tdep.c (xtensa_store_return_value)
12024         (xtensa_push_dummy_call): Likewise.
12025
12026 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12027
12028         * windows-nat.c (display_selector): Fixed format specifications
12029         for 64-bit Cygwin.
12030
12031 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12032
12033         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12034
12035 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12036
12037         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12038         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12039         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12040         (nios2_linux_init_abi): Install it.
12041
12042 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12043
12044         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12045
12046 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12047
12048         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12049
12050 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12051             Tom Tromey  <tromey@adacore.com>
12052
12053         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12054
12055 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12056
12057         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12058         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12059         method to compute the bounds of range types. Also print "[evaluated]"
12060         if the bounds' values come from a dynamic evaluation.
12061
12062 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12063
12064         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12065         whitespace when pretty printing is on.
12066
12067 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12068
12069         * ppc-linux-nat.c: Add include.
12070
12071 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12072
12073         * NEWS: Mention AArch64 Pointer Authentication.
12074
12075 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12076
12077         * arm-linux-nat.c: Add include.
12078
12079 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12080
12081         * source-cache.c (source_cache::get_source_lines): Re-read
12082         fullname after calling open_source_file.
12083
12084 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12085
12086         * NEWS: Mention TLS support for FreeBSD.
12087
12088 2019-03-25  Tom Tromey  <tromey@adacore.com>
12089
12090         * minsyms.c (BUNCH_SIZE): Update comment.
12091         (~minimal_symbol_reader): Remove old comment.
12092         (compact_minimal_symbols): Update comment.
12093         (minimal_symbol_reader::install): Remove old comment.  Update
12094         other comments.
12095
12096 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12097
12098         * s390-linux-nat.c: Add include.
12099
12100 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12101
12102         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12103         Call linux_get_hwcap.
12104         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12105         Likewise.
12106         (aarch64_linux_get_hwcap): Remove function.
12107         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12108         declaration.
12109         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12110         linux_get_hwcap.
12111         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12112         * linux-tdep.c (linux_get_hwcap): Add function.
12113         (linux_get_hwcap2): Likewise.
12114         * linux-tdep.h (linux_get_hwcap): Add declaration.
12115         (linux_get_hwcap2): Likewise.
12116         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12117         (ppc_linux_get_hwcap2): Likewise.
12118         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12119         linux_get_hwcap.
12120         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12121         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12122         (ppc_linux_nat_target::read_description): Likewise.
12123         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12124         * s390-linux-nat.c: Likewise.
12125         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12126
12127 2019-03-24  Tom Tromey  <tom@tromey.com>
12128
12129         * ada-lang.c (standard_lookup): Simplify initialization.
12130         (ada_lookup_symbol_nonlocal): Simplify return.
12131         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12132         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12133         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12134         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12135         initialization.
12136         * solib.c (solib_global_lookup): Simplify.
12137         * symtab.c (null_block_symbol): Remove.
12138         (symbol_cache_lookup): Simplify returns.
12139         (lookup_language_this): Simplify returns.
12140         (lookup_symbol_aux): Simplify return.
12141         (lookup_local_symbol): Simplify returns.
12142         (lookup_global_symbol_from_objfile): Simplify return.
12143         (lookup_symbol_in_objfile_symtabs)
12144         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12145         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12146         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12147         * cp-namespace.c (cp_lookup_bare_symbol)
12148         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12149         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12150         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12151         (cp_lookup_symbol_via_imports): Simplify initialization.
12152         (find_symbol_in_baseclass): Likewise.
12153         * symtab.h (null_block_symbol): Remove.
12154         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12155         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12156         (d_lookup_symbol_module): Likewise.
12157         (find_symbol_in_baseclass): Simplify initialization.
12158
12159 2019-03-24  Tom Tromey  <tom@tromey.com>
12160
12161         * expression.h: Don't include symtab.h.
12162         (struct block): Forward declare.
12163
12164 2019-03-24  Tom Tromey  <tom@tromey.com>
12165
12166         * c-exp.y (typebase): Remove casts.
12167         * gdbtypes.c (lookup_unsigned_typename, )
12168         (lookup_signed_typename): Remove cast.
12169         * eval.c (parse_to_comma_and_eval): Remove cast.
12170         * parse.c (write_dollar_variable): Remove cast.
12171         * block.h (struct block) <superblock>: Now const.
12172         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12173         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12174         (map_block): Make "block" const.
12175         * symfile.h (struct quick_symbol_functions)
12176         <map_matching_symbols>: Constify block argument to "callback".
12177         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12178         const.
12179         (find_pc_sect_compunit_symtab): Make "b" const.
12180         (find_symbol_at_address): Likewise.
12181         (search_symbols): Likewise.
12182         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12183         (dw2_debug_names_lookup_symbol): Likewise.
12184         (dw2_map_matching_symbols): Update.
12185         * p-valprint.c (pascal_val_print): Remove "block".
12186         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12187         (aux_add_nonlocal_symbols): Make "block" const.
12188         (resolve_subexp): Remove cast.
12189         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12190         const.
12191         (iterate_over_file_blocks): Likewise.
12192         * f-exp.y (%union) <bval>: Remove.
12193         * coffread.c (patch_opaque_types): Make "b" const.
12194         * spu-tdep.c (spu_catch_start): Make "block" const.
12195         * c-valprint.c (print_unpacked_pointer): Remove "block".
12196         * symmisc.c (dump_symtab_1): Make "b" const.
12197         (block_depth): Make "block" const.
12198         * d-exp.y (%union) <bval>: Remove.
12199         * cp-support.h (cp_lookup_rtti_type): Update.
12200         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12201         * psymtab.c (psym_lookup_symbol): Make "block" const.
12202         (maintenance_check_psymtabs): Make "b" const.
12203         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12204         (enumerate_locals, enumerate_args): Update.
12205         * python/py-symtab.c (stpy_global_block): Make "block" const.
12206         (stpy_static_block): Likewise.
12207         * inline-frame.c (block_starting_point_at): Make "new_block"
12208         const.
12209         * block.c (find_block_in_blockvector): Make return type const.
12210         (blockvector_for_pc_sect): Make "b" const.
12211         (find_block_in_blockvector): Make "b" const.
12212
12213 2019-03-23  Tom Tromey  <tom@tromey.com>
12214
12215         * varobj.c (varobj_create): Update.
12216         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12217         * printcmd.c (display_command, do_one_display): Don't reset
12218         innermost_block.
12219         * parser-defs.h (enum innermost_block_tracker_type): Move to
12220         expression.h.
12221         (innermost_block): Update comment.
12222         * parse.c (parse_exp_1): Add tracker_types parameter.
12223         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12224         tracker_types parameter.  Reset innermost_block.
12225         (parse_exp_in_context): Remove.
12226         (parse_expression_for_completion): Update.
12227         * objfiles.c (~objfile): Don't reset expression_context_block or
12228         innermost_block.
12229         * expression.h (enum innermost_block_tracker_type): Move from
12230         parser-defs.h.
12231         (parse_exp_1): Add tracker_types parameter.
12232         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12233         reset innermost_block.
12234
12235 2019-03-23  Tom Tromey  <tom@tromey.com>
12236
12237         * objfiles.h: Include bcache.h.
12238
12239 2019-03-23  Tom Tromey  <tom@tromey.com>
12240
12241         * linespec.c (get_current_search_block): Use
12242         scoped_restore_current_language.
12243         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12244
12245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12246             Jiong Wang  <jiong.wang@arm.com>
12247
12248         * aarch64-linux-tdep.c
12249         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12250         section.
12251         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12252
12253 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12254             Jiong Wang  <jiong.wang@arm.com>
12255
12256         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12257         instructions.
12258         (aarch64_analyze_prologue_test): Add PACIASP test.
12259         (aarch64_prologue_prev_register): Unmask PC value.
12260
12261 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12262             Jiong Wang  <jiong.wang@arm.com>
12263
12264         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12265         (aarch64_dwarf2_prev_register): Unmask PC value.
12266         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12267         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12268         DW_CFA_AARCH64_negate_ra_state.
12269         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12270
12271 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12272             Jiong Wang  <jiong.wang@arm.com>
12273
12274         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12275         registers.
12276         (aarch64_pseudo_register_name): Likewise.
12277         (aarch64_pseudo_register_type): Likewise.
12278         (aarch64_pseudo_register_reggroup_p): Likewise.
12279         (aarch64_gdbarch_init): Add pauth registers.
12280         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12281         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12282         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12283         (struct gdbarch_tdep): Add regnum for ra_state.
12284
12285 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12286             Jiong Wang  <jiong.wang@arm.com>
12287
12288         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12289
12290 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12291             Jiong Wang  <jiong.wang@arm.com>
12292
12293         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12294         function.
12295         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12296         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12297         (aarch64_gdbarch_init): Add puth registers.
12298         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12299         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12300         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12301
12302 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12303             Jiong Wang  <jiong.wang@arm.com>
12304
12305         * aarch64-linux-nat.c
12306         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12307         * aarch64-linux-tdep.c
12308         (aarch64_linux_core_read_description): Likewise.
12309         (aarch64_linux_get_hwcap): New function.
12310         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12311         (aarch64_linux_get_hwcap): New declaration.
12312
12313 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12314             Jiong Wang  <jiong.wang@arm.com>
12315
12316         * aarch64-linux-nat.c
12317         (aarch64_linux_nat_target::read_description): Add pauth param.
12318         * aarch64-linux-tdep.c
12319         (aarch64_linux_core_read_description): Likewise.
12320         * aarch64-tdep.c (struct target_desc): Add in pauth.
12321         (aarch64_read_description): Add pauth param.
12322         (aarch64_gdbarch_init): Likewise.
12323         * aarch64-tdep.h (aarch64_read_description): Likewise.
12324         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12325         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12326         * features/Makefile: Add new files.
12327         * features/aarch64-pauth.c: New file.
12328         * features/aarch64-pauth.xml: New file.
12329
12330 2019-03-20  Tom Tromey  <tromey@adacore.com>
12331
12332         * infrun.c (handle_inferior_event): Rename from
12333         handle_inferior_event_1.  Create a scoped_value_mark.
12334         (handle_inferior_event): Remove.
12335
12336 2019-03-19  Tom Tromey  <tromey@adacore.com>
12337
12338         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12339         * infrun.h (print_stop_event): Add "displays" parameter.
12340         * infrun.c (print_stop_event): Add "displays" parameter.
12341
12342 2019-03-19  Pedro Alves  <palves@redhat.com>
12343
12344         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12345         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12346         to -1.  Fix TABs vs spaces.
12347         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12348         * tui/tui-out.h (tui_ui_out) Add intro comments.
12349         <m_line, m_start_of_line>: In-class initialize, and add describing
12350         comment.
12351
12352 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12353
12354         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12355         variable names.
12356         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12357
12358 2019-03-18  Pedro Alves  <palves@redhat.com>
12359             Eli Zaretskii <eliz@gnu.org>
12360
12361         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12362         m_line and m_start_of_line.
12363
12364 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12365
12366         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12367         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12368         it returns a newline.  This fixes a regression in TU mode, whereby
12369         the next line is output on the same screen line as the user input.
12370
12371 2019-03-18  Tom Tromey  <tromey@adacore.com>
12372
12373         * minsyms.c (minimal_symbol_reader::install): Remove call to
12374         obstack_blank.
12375
12376 2019-03-18  Pedro Alves  <palves@redhat.com>
12377
12378         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12379         New globals.
12380         (apply_style): New, factored out from ...
12381         (apply_ansi_escape): ... this.  Handle reverse video mode.
12382         (tui_set_reverse_mode): New function.
12383         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12384         * tui/tui-winsource.c (tui_show_source_line): Use
12385         tui_set_reverse_mode instead of setting A_STANDOUT.
12386         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12387         New setter methods.
12388
12389 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12390
12391         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12392         Handle tabs.
12393
12394 2019-03-18  Tom Tromey  <tromey@adacore.com>
12395
12396         * ada-lang.c (empty_array): Add "high" parameter.
12397         (ada_evaluate_subexp): Update.
12398
12399 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12400
12401         * unittests/string_view-selftests.c: Define
12402         _initialize_string_view_selftests unconditionally.
12403
12404 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12405
12406         PR gdb/24350
12407         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12408
12409 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12410
12411         PR gdb/24351
12412         * windows-nat.c (display_selector): Fix format specifiers.
12413
12414 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12415
12416         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12417         tui_refill_source_window instead of tui_refresh_win, to update the
12418         current execution line.  This fixes redisplay of the current line
12419         when stepping through the code with "next" or "step".
12420
12421 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12422
12423         * source-cache.c (source_cache::get_source_lines): Call
12424         find_source_lines to initialize s->nlines.  This fixes vertical
12425         scrolling of TUI source window when the DOWN arrow is pressed.
12426
12427 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12428
12429         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12430         linux-thread-db.c (_initialize_thread_db): Likewise.
12431
12432 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12433
12434         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12435         wclrtoeol in tui_show_source_line".  This reverts changes made in
12436         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12437
12438 2019-03-15  Tom Tromey  <tom@tromey.com>
12439
12440         * symtab.h (struct minimal_symbol): Derive from
12441         general_symbol_info.
12442         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12443         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12444         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12445         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12446         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12447         (MSYMBOL_SEARCH_NAME): Update.
12448         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12449         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12450         * minsyms.c (minimal_symbol_reader::record_full): Update.
12451
12452 2019-03-15  Tom Tromey  <tom@tromey.com>
12453
12454         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12455
12456 2019-03-15  Tom Tromey  <tom@tromey.com>
12457
12458         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12459         unique_xmalloc_ptr.
12460         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12461         Update.
12462         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12463         (build_minimal_symbol_hash_tables)
12464         (minimal_symbol_reader::install): Update.
12465
12466 2019-03-15  Tom Tromey  <tom@tromey.com>
12467
12468         * symtab.c (create_demangled_names_hash): Update.
12469         (symbol_set_names): Update.
12470         * objfiles.h (struct objfile_per_bfd_storage)
12471         <demangled_names_hash>: Now an htab_up.
12472         * objfiles.c (objfile_per_bfd_storage): Simplify.
12473
12474 2019-03-15  Tom Tromey  <tom@tromey.com>
12475
12476         * objfiles.h (struct objfile_per_bfd_storage): Declare
12477         destructor.
12478         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12479         New.
12480         (get_objfile_bfd_data): Use new.  Don't initialize
12481         language_of_main.
12482         (free_objfile_per_bfd_storage): Remove.
12483         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12484
12485 2019-03-15  Tom Tromey  <tom@tromey.com>
12486
12487         * symfile.c (reread_symbols): Update.
12488         * objfiles.c (objfile::objfile): Update.
12489         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12490         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12491         comment.
12492         (minimal_symbol_reader::install): Update.
12493         (terminate_minimal_symbol_table): Remove.
12494         * jit.c (jit_object_close_impl): Update.
12495
12496 2019-03-15  Tom Tromey  <tom@tromey.com>
12497
12498         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12499         initializations.
12500
12501 2019-03-15  Tom Tromey  <tom@tromey.com>
12502
12503         * objfiles.h (struct objfile_per_bfd_storage)
12504         <demangled_hash_languages>: Now a bitset.
12505         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12506         (lookup_minimal_symbol): Update.
12507
12508 2019-03-15  Tom Tromey  <tom@tromey.com>
12509
12510         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12511         Don't return the symbol.
12512         * coffread.c (record_minimal_symbol): Use record_full.
12513
12514 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12515
12516         The MS-Windows port of ncurses fails to switch to a color pair if
12517         one or both of the colors are the implicit default colors.  This
12518         change records the default colors when TUI is initialized, and
12519         then specifies them explicitly when a color pair uses the default
12520         colors.  This allows color styling in TUI mode on MS-Windows.
12521
12522         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12523         ncurses_norm_attr.
12524         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12525         colors in ncurses_norm_attr.
12526         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12527         "none", replace it with the default color recorded in
12528         ncurses_norm_attr.
12529
12530 2019-03-14  Tom Tromey  <tromey@adacore.com>
12531
12532         * source-cache.h (class source_cache) <get_source_lines>: Return
12533         std::string.
12534         * source-cache.c (source_cache::extract_lines): Handle case where
12535         first_pos==npos.  Return std::string.
12536         (source_cache::get_source_lines): Update.
12537
12538 2019-03-14  Tom Tromey  <tromey@adacore.com>
12539
12540         * NEWS: Add item for "style sources" commands.
12541         * source-cache.c (source_cache::get_source_lines): Check
12542         source_styling.
12543         * cli/cli-style.c (source_styling): New global.
12544         (_initialize_cli_style): Add "style sources" commands.
12545         (show_style_sources): New function.
12546         * cli/cli-style.h (source_styling): Declare.
12547
12548 2019-03-14  Pedro Alves  <palves@redhat.com>
12549             Tom Tromey  <tromey@adacore.com>
12550
12551         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12552         * tui/tui-winsource.c (tui_refill_source_window): New function,
12553         from...
12554         (tui_horizontal_source_scroll): ... here.  Move some logic.
12555         * cli/cli-style.c (set_style_enabled): Notify new observable.
12556         * tui/tui-hooks.c (tui_redisplay_source): New function.
12557         (tui_attach_detach_observers): Attach or detach
12558         tui_redisplay_source.
12559         * observable.h (source_styling_changed): New observable.
12560         * observable.c: Define source_styling_changed observable.
12561
12562 2019-03-13  Tom Tromey  <tromey@adacore.com>
12563
12564         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12565         (i386_gnu_nat_target::store_registers): Update.
12566         * target-debug.h (target_debug_print_std_string): New macro.
12567         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12568         * windows-tdep.c (display_one_tib): Update.
12569         * tui/tui-stack.c (tui_make_status_line): Update.
12570         * top.c (print_inferior_quit_action): Update.
12571         * thread.c (thr_try_catch_cmd): Update.
12572         (add_thread_with_info): Update.
12573         (thread_target_id_str): Update.
12574         (thr_try_catch_cmd): Update.
12575         (thread_command): Update.
12576         (thread_find_command): Update.
12577         * record-btrace.c (record_btrace_target::info_record)
12578         (record_btrace_resume_thread, record_btrace_target::resume)
12579         (record_btrace_cancel_resume, record_btrace_step_thread)
12580         (record_btrace_target::wait, record_btrace_target::wait)
12581         (record_btrace_target::wait, record_btrace_target::stop): Update.
12582         * progspace.c (print_program_space): Update.
12583         * process-stratum-target.c
12584         (process_stratum_target::thread_address_space): Update.
12585         * linux-fork.c (linux_fork_mourn_inferior)
12586         (detach_checkpoint_command, info_checkpoints_command)
12587         (linux_fork_context): Update.
12588         (linux_fork_detach): Update.
12589         (class scoped_switch_fork_info): Update.
12590         (delete_checkpoint_command): Update.
12591         * infrun.c (follow_fork_inferior): Update.
12592         (follow_fork_inferior): Update.
12593         (proceed_after_vfork_done): Update.
12594         (handle_vfork_child_exec_or_exit): Update.
12595         (follow_exec): Update.
12596         (displaced_step_prepare_throw): Update.
12597         (displaced_step_restore): Update.
12598         (start_step_over): Update.
12599         (resume_1): Update.
12600         (clear_proceed_status_thread): Update.
12601         (proceed): Update.
12602         (print_target_wait_results): Update.
12603         (do_target_wait): Update.
12604         (context_switch): Update.
12605         (stop_all_threads): Update.
12606         (restart_threads): Update.
12607         (finish_step_over): Update.
12608         (handle_signal_stop): Update.
12609         (switch_back_to_stepped_thread): Update.
12610         (keep_going_pass_signal): Update.
12611         (print_exited_reason): Update.
12612         (normal_stop): Update.
12613         * inferior.c (inferior_pid_to_str): Change return type.
12614         (print_selected_inferior): Update.
12615         (add_inferior): Update.
12616         (detach_inferior): Update.
12617         * dummy-frame.c (fprint_dummy_frames): Update.
12618         * dcache.c (dcache_info_1): Update.
12619         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12620         (btrace_fetch, btrace_clear): Update.
12621         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12622         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12623         type.
12624         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12625         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12626         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12627         * gdbarch.c, gdbarch.h: Rebuild.
12628         * gdbarch.sh (core_pid_to_str): Change return type.
12629         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12630         return type.
12631         (windows_nat_target::pid_to_str): Change return type.
12632         (windows_delete_thread): Update.
12633         (windows_nat_target::attach): Update.
12634         (windows_nat_target::files_info): Update.
12635         * target-delegates.c: Rebuild.
12636         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12637         return type.
12638         (sol_thread_target::pid_to_str): Change return type.
12639         * remote.c (class remote_target) <pid_to_str>: Change return
12640         type.
12641         (remote_target::pid_to_str): Change return type.
12642         (extended_remote_target::attach, remote_target::remote_stop_ns)
12643         (remote_target::remote_notif_remove_queued_reply)
12644         (remote_target::push_stop_reply, remote_target::disable_btrace):
12645         Update.
12646         (extended_remote_target::attach): Update.
12647         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12648         type.
12649         (gdbsim_target::pid_to_str): Change return type.
12650         * ravenscar-thread.c (struct ravenscar_thread_target)
12651         <pid_to_str>: Change return type.
12652         (ravenscar_thread_target::pid_to_str): Change return type.
12653         * procfs.c (class procfs_target) <pid_to_str>: Change return
12654         type.
12655         (procfs_target::pid_to_str): Change return type.
12656         (procfs_target::attach): Update.
12657         (procfs_target::detach): Update.
12658         (procfs_target::fetch_registers): Update.
12659         (procfs_target::store_registers): Update.
12660         (procfs_target::wait): Update.
12661         (procfs_target::files_info): Update.
12662         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12663         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12664         return type.
12665         (nto_procfs_target::pid_to_str): Change return type.
12666         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12667         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12668         return type.
12669         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12670         (exit_lwp): Update.
12671         (attach_proc_task_lwp_callback, get_detach_signal)
12672         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12673         (linux_nat_target::resume, wait_lwp, stop_callback)
12674         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12675         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12676         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12677         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12678         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12679         type.
12680         (inf_ptrace_target::attach): Update.
12681         (inf_ptrace_target::files_info): Update.
12682         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12683         type.
12684         (go32_nat_target::pid_to_str): Change return type.
12685         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12686         (gnu_nat_target::wait): Update.
12687         (gnu_nat_target::wait): Update.
12688         (gnu_nat_target::resume): Update.
12689         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12690         (fbsd_nat_target::wait): Update.
12691         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12692         type.
12693         (darwin_nat_target::attach): Update.
12694         * corelow.c (class core_target) <pid_to_str>: Change return type.
12695         (core_target::pid_to_str): Change return type.
12696         * target.c (normal_pid_to_str): Change return type.
12697         (default_pid_to_str): Likewise.
12698         (target_pid_to_str): Change return type.
12699         (target_translate_tls_address): Update.
12700         (target_announce_detach): Update.
12701         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12702         return type.
12703         (bsd_uthread_target::pid_to_str): Change return type.
12704         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12705         type.
12706         (bsd_kvm_target::pid_to_str): Change return type.
12707         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12708         return type.
12709         (aix_thread_target::pid_to_str): Change return type.
12710         * target.h (struct target_ops) <pid_to_str>: Change return type.
12711         (target_pid_to_str, normal_pid_to_str): Likewise.
12712         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12713         type.
12714         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12715         type.
12716         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12717         return type.
12718         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12719         type.
12720         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12721         type.
12722         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12723         return type.
12724
12725 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12726
12727         * NEWS: Mention that the new default MI version is 3.  Mention
12728         changes to the output of commands and events that deal with
12729         multi-location breakpoints.
12730         * breakpoint.c: Include "mi/mi-out.h".
12731         (print_one_breakpoint): Change output syntax if using MI version
12732         >= 3.
12733         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12734         New.
12735         (mi_multi_location_breakpoint_output_fixed): New.
12736         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12737         (mi_cmd_fix_multi_location_breakpoint_output): New.
12738         (mi_multi_location_breakpoint_output_fixed): New.
12739         * mi/mi-cmds.c (mi_cmds): Register command
12740         -fix-multi-location-breakpoint-output.
12741         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12742         interpreter "mi".
12743
12744 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12745
12746         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12747         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12748         instantiate mi_ui_out based on interpreter name.
12749         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12750         * mi/mi-main.c (mi_load_progress): Likewise.
12751
12752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12753
12754         * NEWS: Combine separate "New targets" sections for 8.3.
12755
12756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12757
12758         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12759         (ppcfbsd_init_abi): Install gdbarch
12760         "fetch_tls_load_module_address" and "get_thread_local_address"
12761         methods.
12762
12763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12764
12765         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12766         (riscv_fbsd_init_abi): Install gdbarch
12767         "fetch_tls_load_module_address" and "get_thread_local_address"
12768         methods.
12769
12770 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12771
12772         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12773         (i386fbsd_init_abi): Install gdbarch
12774         "fetch_tls_load_module_address" and "get_thread_local_address"
12775         methods.
12776
12777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12778
12779         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12780         (amd64fbsd_init_abi): Install gdbarch
12781         "fetch_tls_load_module_address" and "get_thread_local_address"
12782         methods.
12783
12784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12785
12786         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12787         (struct fbsd_pspace_data): New type.
12788         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12789         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12790         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12791         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12792         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12793
12794 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12795
12796         * gdbtypes.c (lookup_struct_elt): New function.
12797         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12798         * gdbtypes.h (struct struct_elt): New type.
12799         (lookup_struct_elt): New prototype.
12800
12801 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12802
12803         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12804         remove disabled code block.
12805
12806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12807
12808         * gdbarch.sh (get_thread_local_address): New method.
12809         * gdbarch.h, gdbarch.c: Regenerate.
12810         * target.c (target_translate_tls_address): Use
12811         gdbarch_get_thread_local_address if present instead of
12812         target::get_thread_local_address.
12813
12814 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12815
12816         * target.h (target::get_thread_local_address): Update comment.
12817
12818 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12819
12820         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12821         objfile->separate_debug_objfile_backlink if not NULL.
12822
12823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12824
12825         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12826         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12827         (amd64bsd_store_inferior_registers): Likewise.
12828         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12829         Enable segment base registers.
12830         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12831         PT_GETFSBASE and PT_GETGSBASE.
12832         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12833         PT_SETGSBASE.
12834         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12835         segment base registers.
12836         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12837
12838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12839
12840         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12841         Update calls to i386_target_description to add 'segments'
12842         parameter.
12843         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12844         add segment base registers.
12845         * arch/i386.c (i386_create_target_description): Add 'segments'
12846         parameter to enable segment base registers.
12847         * arch/i386.h (i386_create_target_description): Likewise.
12848         * features/i386/32bit-segments.xml: New file.
12849         * features/i386/32bit-segments.c: Generate.
12850         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12851         call to i386_target_description to add 'segments' parameter.
12852         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12853         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12854         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12855         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12856         if feature is present.
12857         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12858         Add 'segments' parameter to call to i386_target_description.
12859         (i386_target_description): Add 'segments' parameter to enable
12860         segment base registers.
12861         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12862         to call to i386_target_description.
12863         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12864         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12865         Define I386_NUM_REGS.
12866         (i386_target_description): Add 'segments' parameter to enable
12867         segment base registers.
12868
12869 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12870
12871         PR/24325
12872         * source-cache.c: #undef open and close, to avoid unresolved
12873         externals during linking.
12874
12875 2019-03-12  Tom Tromey  <tromey@adacore.com>
12876
12877         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12878         const.  Add initializers.
12879         (_initialize_remote): Don't initialize ptid globals.
12880
12881 2019-03-12  Pedro Alves  <palves@redhat.com>
12882
12883         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12884
12885 2019-03-12  Pedro Alves  <palves@redhat.com>
12886
12887         * cp-name-parser.y (main): Remove unused 'len' variable.
12888
12889 2019-03-12  Tom Tromey  <tromey@adacore.com>
12890
12891         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12892         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12893
12894 2019-03-12  Tom Tromey  <tromey@adacore.com>
12895
12896         * linux-nat.c (iterate_over_lwps): Update.
12897         (stop_callback): Remove parameter.
12898         (stop_wait_callback, detach_callback, resume_set_callback)
12899         (select_singlestep_lwp_callback, set_ignore_sigint)
12900         (status_callback, resumed_callback, resume_clear_callback)
12901         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12902         data parameter.
12903         (linux_nat_target::detach, linux_nat_target::resume)
12904         (linux_stop_and_wait_all_lwps, select_event_lwp)
12905         (linux_nat_filter_event, linux_nat_wait_1)
12906         (linux_nat_target::kill, linux_nat_target::stop)
12907         (linux_nat_target::stop): Update.
12908         (linux_nat_resume_callback): Change type.
12909         (resume_stopped_resumed_lwps, count_events_callback)
12910         (select_event_lwp_callback): Likewise.
12911         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12912         * arm-linux-nat.c (struct update_registers_data): Remove.
12913         (update_registers_callback): Change type.
12914         (arm_linux_insert_hw_breakpoint1): Update.
12915         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12916         parameter.
12917         (x86_linux_dr_set_addr): Update.
12918         (x86_linux_dr_set_control): Update.
12919         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12920         (iterate_over_lwps): Use gdb::function_view.
12921         * nat/aarch64-linux-hw-point.c (struct
12922         aarch64_dr_update_callback_param): Remove.
12923         (debug_reg_change_callback): Change type.
12924         (aarch64_notify_debug_reg_change): Update.
12925         * s390-linux-nat.c (s390_refresh_per_info): Update.
12926
12927 2019-03-11  Tom Tromey  <tromey@adacore.com>
12928
12929         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12930         redundant assignment to "this_cu".
12931
12932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12933
12934         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12935
12936 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12937
12938         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12939         from...
12940         (rank_one_type): ... this.
12941
12942 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12943
12944         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12945         from...
12946         (rank_one_type): ... this.
12947
12948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12949
12950         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12951         from...
12952         (rank_one_type): ... this.
12953
12954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12955
12956         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12957         from...
12958         (rank_one_type): ... this.
12959
12960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12961
12962         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12963         from...
12964         (rank_one_type): ... this.
12965
12966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12967
12968         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12969         from...
12970         (rank_one_type): ... this.
12971
12972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12973
12974         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12975         from...
12976         (rank_one_type): ... this.
12977
12978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12979
12980         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12981         from...
12982         (rank_one_type): ... this.
12983
12984 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12985
12986         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12987         from...
12988         (rank_one_type): ... this.
12989
12990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12991
12992         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12993         from...
12994         (rank_one_type): ... this.
12995
12996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12997
12998         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12999         from...
13000         (rank_one_type): ... this.
13001
13002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13003
13004         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13005         from...
13006         (rank_one_type): ... this.
13007
13008 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13009
13010         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13011         inferior-events' shows the example events.
13012
13013 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13014
13015         Support styling on native MS-Windows console
13016
13017         PR/24315
13018         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13019         on MS-Windows if $TERM is not defined.
13020
13021         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13022
13023         * posix-hdep.c (gdb_console_fputs):
13024         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13025         functions.
13026         * ui-file.h (gdb_console_fputs): Add prototype.
13027
13028         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13029         back to fputs only if the former returns zero.
13030
13031 2019-03-07  Tom Tromey  <tom@tromey.com>
13032
13033         * symmisc.c (print_symbol_bcache_statistics): Update.
13034         (print_objfile_statistics): Update.
13035         * symfile.c (allocate_symtab): Update.
13036         * stabsread.c: Don't include bcache.h.
13037         * psymtab.h (struct psymbol_bcache): Don't declare.
13038         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13039         (psymbol_bcache_init, psymbol_bcache_free)
13040         (psymbol_bcache_get_bcache): Don't declare.
13041         * psymtab.c (struct psymbol_bcache): Remove.
13042         (psymtab_storage::psymtab_storage): Update.
13043         (psymtab_storage::~psymtab_storage): Update.
13044         (psymbol_bcache_init, psymbol_bcache_free)
13045         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13046         (add_psymbol_to_bcache): Update.
13047         (allocate_psymtab): Update.
13048         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13049         macro_cache>: No longer pointers.
13050         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13051         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13052         * macrotab.c (macro_bcache): Update.
13053         * macroexp.c: Don't include bcache.h.
13054         * gdbtypes.c (check_types_worklist): Update.
13055         (types_deeply_equal): Remove TRY/CATCH.  Update.
13056         * elfread.c (elf_symtab_read): Update.
13057         * dwarf2read.c: Don't include bcache.h.
13058         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13059         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13060         (print_bcache_statistics, bcache_memory_used): Don't declare.
13061         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13062         methods.  Rename all data members.
13063         * bcache.c (struct bcache): Move to bcache.h.
13064         (bcache::expand_hash_table): Rename from expand_hash_table.
13065         (bcache): Remove.
13066         (bcache::insert): Rename from bcache_full.
13067         (bcache::compare): Rename from bcache_compare.
13068         (bcache_xmalloc): Remove.
13069         (bcache::~bcache): Rename from bcache_xfree.
13070         (bcache::print_statistics): Rename from print_bcache_statistics.
13071         (bcache::memory_used): Rename from bcache_memory_used.
13072
13073 2019-03-07  Pedro Alves  <palves@redhat.com>
13074
13075         * infrun.c (normal_stop): Also check for
13076         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13077
13078 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13079
13080         * f-lang.c (value_from_host_double): Moved to...
13081         * value.c (value_from_host_double): ...here.
13082         * value.h (value_from_host_double): Declare.
13083         * guile/scm-math.c (vlscm_convert_typed_number): Use
13084         value_from_host_double.
13085         (vlscm_convert_number): Likewise.
13086         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13087         * python/py-value.c (convert_value_from_python): Likewise.
13088
13089 2019-03-06  Tom Tromey  <tom@tromey.com>
13090
13091         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13092
13093 2019-03-06  Tom Tromey  <tom@tromey.com>
13094
13095         * utils.h (free_current_contents): Don't declare.
13096         * utils.c (free_current_contents): Remove.
13097
13098 2019-03-06  Tom Tromey  <tom@tromey.com>
13099
13100         * top.c (quit_force): Update.
13101         * main.c (captured_command_loop): Update.
13102         * common/new-op.c (operator new): Update.
13103         * common/common-exceptions.c (struct catcher)
13104         <save_cleanup_chain>: Remove member.
13105         (exceptions_state_mc_init): Update.
13106         (exception_try_scope_entry): Return nullptr.
13107         (exception_try_scope_exit, exception_rethrow)
13108         (throw_exception_sjlj, throw_exception_cxx): Update.
13109         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13110         (all_cleanups, do_cleanups, discard_cleanups)
13111         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13112         (restore_cleanups, restore_final_cleanups): Don't declare.
13113         (do_final_cleanups): Remove parameter.
13114         * common/cleanups.c (cleanup_chain, make_cleanup)
13115         (make_cleanup_dtor, all_cleanups, do_cleanups)
13116         (discard_my_cleanups, discard_cleanups)
13117         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13118         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13119         (null_cleanup): Remove.
13120         (do_final_cleanups): Remove parameter.
13121
13122 2019-03-06  Tom Tromey  <tom@tromey.com>
13123
13124         * remote.c (remote_target::remote_parse_stop_reply): Use
13125         unique_xmalloc_ptr.
13126
13127 2019-03-06  Tom Tromey  <tom@tromey.com>
13128
13129         * stabsread.c (struct stabs_field_info): Rename from field_info.
13130         <list, fnlist>: Add initializers.
13131         <obstack>: New member.
13132         (read_member_functions, read_struct_fields, read_baseclasses):
13133         Allocate on obstack.  Don't use cleanups.
13134         (read_one_struct_field, read_member_functions, read_struct_fields)
13135         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13136         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13137         (read_struct_type): Update.
13138
13139 2019-03-06  Tom Tromey  <tom@tromey.com>
13140
13141         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13142         * common/filestuff.h (make_cleanup_close): Don't declare.
13143         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13144         Remove.
13145
13146 2019-03-06  Tom Tromey  <tom@tromey.com>
13147
13148         * solib-aix.c: Use make_scope_exit.
13149
13150 2019-03-06  Tom Tromey  <tom@tromey.com>
13151
13152         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13153         Use make_scope_exit.
13154
13155 2019-03-06  Tom Tromey  <tom@tromey.com>
13156
13157         * solib-svr4.c (disable_probes_interface): Remove parameter.
13158         (svr4_handle_solib_event): Use make_scope_exit.
13159
13160 2019-03-06  Tom Tromey  <tom@tromey.com>
13161
13162         * remote.c (struct stop_reply_deleter): Remove.
13163         (stop_reply_up): Update.
13164         (struct stop_reply): Derive from notif_event.  Don't typedef.
13165         <regcache>: Now a std::vector.
13166         (stop_reply_xfree): Remove.
13167         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13168         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13169         (remote_target::discard_pending_stop_replies): Use delete.
13170         (remote_target::remote_parse_stop_reply): Update.
13171         (remote_target::process_stop_reply): Update.
13172         * remote-notif.h (struct notif_event): Add virtual destructor.
13173         Remove "dtr" member.
13174         (struct notif_client) <alloc_event>: Return a unique_ptr.
13175         (notif_event_xfree): Don't declare.
13176         (notif_event_up): New typedef.
13177         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13178         (notif_event_xfree, do_notif_event_xfree): Remove.
13179         (remote_notif_state_xfree): Update.
13180
13181 2019-03-06  Tom Tromey  <tom@tromey.com>
13182
13183         * infrun.c (displaced_step_clear_cleanup): Now a
13184         forward_scope_exit type.
13185         (displaced_step_prepare_throw): Update.
13186         (displaced_step_fixup): Update.
13187
13188 2019-03-06  Tom Tromey  <tom@tromey.com>
13189
13190         * inferior.h (class inferior): Update comment.
13191         * gdbthread.h (class thread_info): Update comment.
13192
13193 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13194             Tom Tromey  <tom@tromey.com>
13195
13196         * stabsread.h (struct stab_section_list): Remove.
13197         (coffstab_build_psymtabs): Update.
13198         * dbxread.c (symbuf_sections): Now a std::vector.
13199         (sect_idx): New global.
13200         (fill_symbuf): Update.
13201         (coffstab_build_psymtabs): Change type of stabsects parameter.
13202         Update.
13203         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13204         std::vector.
13205         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13206         (coff_locate_sections): Update.
13207         (coff_symfile_read): Remove cleanups.  Update.
13208         (init_stringtab): Add storage parameter.
13209         (free_stringtab, free_stringtab_cleanup): Remove.
13210         (init_lineno): Add storage parameter.
13211         (free_linetab, free_linetab_cleanup): Remove.
13212
13213 2019-03-06  Pedro Alves  <palves@redhat.com>
13214
13215         * linux-fork.c (fork_info::clobber_regs): Delete.
13216         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13217         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13218         comment.  Adjust.
13219         (scoped_switch_fork_info::scoped_switch_fork_info)
13220         (checkpoint_command, linux_fork_context): Adjust
13221         fork_save_infrun_state calls.
13222
13223 2019-03-06  Pedro Alves  <palves@redhat.com>
13224
13225         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13226         (inf_has_multiple_threads): Return 'bool' and rewrite using
13227         inferior_info::threads().
13228
13229 2019-03-06  Pedro Alves  <palves@redhat.com>
13230
13231         * linux-fork.c: Include <list>.
13232         (fork_list): Now a std::list instance.
13233         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13234         (forks_exist_p, find_last_fork): Adjust.
13235         (new_fork): Delete.
13236         (one_fork_p): New.
13237         (add_fork): Adjust.
13238         (free_fork): Delete, folded into fork_info::~fork_info().
13239         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13240         Adjust.
13241         (init_fork_list): Delete.
13242         (linux_fork_killall, linux_fork_mourn_inferior)
13243         (linux_fork_detach, info_checkpoints_command): Adjust.
13244         (_initialize_linux_fork): No longer call init_fork_list.
13245
13246 2019-03-06  Pedro Alves  <palves@redhat.com>
13247
13248         * linux-fork.c (new_fork): New, split out of ...
13249         (add_fork): ... this.  Return void.  Move "first fork" special
13250         case from here, to ...
13251         (checkpoint_command): ... here.
13252         * linux-linux.h (add_fork): Return void.
13253
13254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13255
13256         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13257
13258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13259             Chris January  <chris.january@arm.com>
13260             David Lecomber  <david.lecomber@arm.com>
13261
13262         * f-exp.y: New token, UNOP_INTRINSIC.
13263         (exp): New pattern using UNOP_INTRINSIC token.
13264         (f77_keywords): Add 'abs' keyword.
13265         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13266         (value_from_host_double): New function.
13267         (evaluate_subexp_f): Support UNOP_ABS.
13268
13269 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13270
13271         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13272         types.
13273
13274 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13275
13276         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13277         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13278         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13279
13280 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13281
13282         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13283
13284 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13285             Chris January  <chris.january@arm.com>
13286
13287         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13288         * f-exp.y: Define 'KIND' token.
13289         (exp): New pattern for KIND expressions.
13290         (ptype): Handle types with a kind extension.
13291         (direct_abs_decl): Extend to spot kind extensions.
13292         (f77_keywords): Add 'kind' to the list.
13293         (push_kind_type): New function.
13294         (convert_to_kind_type): New function.
13295         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13296         * parse.c (operator_length_standard): Likewise.
13297         * parser-defs.h (enum type_pieces): Add tp_kind.
13298         * std-operator.def: Add UNOP_KIND.
13299
13300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13301
13302         * f-exp.y (f_parse): Set yydebug.
13303
13304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13305
13306         * f-lang.c (evaluate_subexp_f): New function.
13307         (exp_descriptor_f): New global.
13308         (f_language_defn): Use exp_descriptor_f instead of
13309         exp_descriptor_standard.
13310
13311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13312
13313         * f-exp.y (struct token): Add comments.
13314         (dot_ops): Remove uppercase versions and the end marker.
13315         (f77_keywords): Likewise.
13316         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13317         entries in the dot_ops array are case insensitive, and use
13318         strncasecmp to compare strings.  Also some whitespace cleanup in
13319         this area.  Similar for the f77_keywords array, except entries in
13320         this list might be case sensitive.
13321
13322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13323
13324         * f-exp.y (struct f77_boolean_val): Add comments.
13325         (boolean_values): Remove uppercase versions, and end marker.
13326         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13327         and use strncasecmp to achieve case insensitivity.  Additionally,
13328         perform whitespace cleanup around this code.
13329
13330 2019-03-06  Tom Tromey  <tromey@adacore.com>
13331
13332         * remote-sim.c (gdbsim_target_open): Use result of
13333         gdb_argv::release.
13334
13335 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13336         Dirk Schubert  <dirk.schubert@arm.com>
13337         Chris January  <chris.january@arm.com>
13338
13339         * eval.c (evaluate_subexp_standard): Call Fortran argument
13340         wrapping logic.
13341         * f-lang.c (struct value): A value which can be passed into a
13342         Fortran function call.
13343         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13344         where appropriate.
13345         (struct type): Value ready for a Fortran function call.
13346         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13347         is needed.
13348         * f-lang.h (fortran_argument_convert): Declaration.
13349         (fortran_preserve_arg_pointer): Declaration.
13350         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13351
13352 2019-03-05  Tom Tromey  <tromey@adacore.com>
13353
13354         * python/py-prettyprint.c (print_string_repr): Remove #if.
13355         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13356
13357 2019-03-05  Tom Tromey  <tromey@adacore.com>
13358
13359         * target.c (the_dummy_target): Move later.  Change type to
13360         "dummy_target".
13361         (initialize_targets): Don't initialize the_dummy_target.
13362
13363 2019-03-05  Tom Tromey  <tromey@adacore.com>
13364
13365         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13366         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13367
13368 2019-03-05  Tom Tromey  <tromey@adacore.com>
13369
13370         * windows-nat.c (windows_nat_target::attach)
13371         (windows_nat_target::detach): Don't call gdb_flush.
13372         * valprint.c (generic_val_print, val_print, val_print_string):
13373         Don't call gdb_flush.
13374         * utils.c (defaulted_query): Don't call gdb_flush.
13375         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13376         * target.c (target_announce_detach): Don't call gdb_flush.
13377         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13378         * remote.c (extended_remote_target::attach): Don't call
13379         gdb_flush.
13380         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13381         * printcmd.c (do_examine): Don't call gdb_flush.
13382         (info_display_command): Don't call gdb_flush.
13383         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13384         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13385         * memattr.c (info_mem_command): Don't call gdb_flush.
13386         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13387         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13388         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13389         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13390         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13391         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13392         (gnu_nat_target::detach): Don't call gdb_flush.
13393         * f-valprint.c (f_val_print): Don't call gdb_flush.
13394         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13395         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13396         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13397         gdb_flush.
13398         * c-valprint.c (c_val_print): Don't call gdb_flush.
13399         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13400
13401 2019-03-05  Tom Tromey  <tromey@adacore.com>
13402
13403         * varobj.c (update_dynamic_varobj_children): Update.
13404         (install_default_visualizer): Use reset, not release.
13405         * value.c (set_internalvar): Update.
13406         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13407         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13408         ATTRIBUTE_UNUSED_RESULT.
13409
13410 2019-03-05  Tom Tromey  <tromey@adacore.com>
13411
13412         * remote.c (class scoped_remote_fd) <release>: Add
13413         ATTRIBUTE_UNUSED_RESULT.
13414
13415 2019-03-05  Tom Tromey  <tromey@adacore.com>
13416
13417         * macroexp.c (struct macro_buffer) <release>: Add
13418         ATTRIBUTE_UNUSED_RESULT.
13419
13420 2019-03-05  Tom Tromey  <tromey@adacore.com>
13421
13422         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13423         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13424         ATTRIBUTE_UNUSED_RESULT.
13425
13426 2019-03-05  Tom Tromey  <tromey@adacore.com>
13427
13428         * common/scoped_fd.h (class scoped_fd) <release>: Add
13429         ATTRIBUTE_UNUSED_RESULT.
13430
13431 2019-03-05  Tom Tromey  <tromey@adacore.com>
13432
13433         * parser-defs.h (struct parser_state) <release>: Add
13434         ATTRIBUTE_UNUSED_RESULT.
13435
13436 2019-03-05  Tom Tromey  <tromey@adacore.com>
13437
13438         * utils.h (class gdb_argv) <release>: Add
13439         ATTRIBUTE_UNUSED_RESULT.
13440         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13441
13442 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13443
13444         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13445         for-loop range, to avoid compiler warnings.
13446
13447         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13448         avoid compiler warnings about unused variables.
13449
13450         * NEWS: Mention end of support for native debugging on MS-Windows
13451         before XP.
13452
13453         PR gdb/24292
13454         * common/netstuff.c:
13455         * gdbserver/gdbreplay.c
13456         * gdbserver/remote-utils.c:
13457         * ser-tcp.c:
13458         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13459         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13460         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13461         'getaddrinfo' and 'freeaddrinfo' were not available before
13462         Windows XP, and mingw.org's MinGW headers by default define
13463         _WIN32_WINNT to 0x500.
13464
13465 2019-03-01  Gary Benson <gbenson@redhat.com>
13466
13467         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13468
13469 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13470             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13471
13472         PR gdb/8527
13473         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13474         set_sigint_trap, clear_sigint_trap.
13475
13476 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13477
13478         * target.c (target_detach): Clear the regcache and the
13479         frame cache.
13480
13481 2019-02-27  Pedro Alves  <palves@redhat.com>
13482
13483         * utils.c (set_screen_size): When we cap the height/width sizes,
13484         tweak the corresponding command variable to show "unlimited":
13485
13486 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13487             Pedro Alves  <palves@redhat.com>
13488
13489         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13490         before calling rl_set_screen_size.
13491
13492 2019-02-27  Tom Tromey  <tromey@adacore.com>
13493
13494         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13495         define.
13496         * python/py-value.c: Remove Python 2.4 workaround.
13497         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13498         workaround.
13499         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13500         Python 2.4 workaround.
13501         * python/python-internal.h: Remove Python 2.4 comment.
13502         (Py_ssize_t): Don't define.
13503         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13504         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13505         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13506         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13507         * python/python.c (do_start_initialization): Remove Python 2.4
13508         workaround.
13509         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13510         (print_children): Remove Python 2.4 workaround.
13511         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13512         workaround.
13513         (CHARBUFFERPROC_NAME): Remove.
13514         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13515         Python 2.4 workaround.
13516
13517 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13518
13519         * NEWS: Note minimum Python version.
13520
13521 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13522
13523         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13524         code from these functions.  Remove corresponding ifdefs.  Use
13525         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13526         Remove gotos and target of gotos.
13527         (infpy_search_memory): Likewise.
13528
13529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13530
13531         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13532         (hppa_gdbarch_init): Don't register deleted functions with
13533         gdbarch.
13534
13535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13536
13537         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13538         (h8300_unwind_sp): Delete.
13539         (h8300_dummy_id): Delete.
13540         (h8300_gdbarch_init): Don't register deleted functions with
13541         gdbarch.
13542
13543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13544
13545         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13546         (ft32_unwind_pc): Delete.
13547         (ft32_unwind_sp): Delete.
13548         (ft32_gdbarch_init): Don't register deleted functions with
13549         gdbarch.
13550
13551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13552
13553         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13554         (frv_unwind_pc): Delete.
13555         (frv_unwind_sp): Delete.
13556         (frv_gdbarch_init): Don't register deleted functions with
13557         gdbarch.
13558
13559 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13560
13561         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13562         (riscv_unwind_pc): Delete.
13563         (riscv_unwind_sp): Delete.
13564         (riscv_gdbarch_init): Don't register deleted functions with
13565         gdbarch.
13566
13567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13568
13569         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13570         (csky_unwind_pc): Delete.
13571         (csky_unwind_sp): Delete.
13572         (csky_gdbarch_init): Don't register deleted functions with
13573         gdbarch.
13574
13575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13576
13577         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13578         (cris_unwind_pc): Delete.
13579         (cris_unwind_sp): Delete.
13580         (cris_gdbarch_init): Don't register deleted functions with
13581         gdbarch.
13582
13583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13584
13585         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13586         (bfin_unwind_pc): Delete.
13587         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13588
13589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13590
13591         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13592         (arm_unwind_pc): Delete.
13593         (arm_unwind_sp): Delete.
13594         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13595
13596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13597
13598         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13599         (arc_unwind_pc): Delete.
13600         (arc_unwind_sp): Delete.
13601         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13602
13603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13604
13605         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13606         (alpha_unwind_pc): Delete.
13607         (alpha_gdbarch_init): Don't register deleted functions with
13608         gdbarch.
13609
13610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13611
13612         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13613         (aarch64_unwind_pc): Delete.
13614         (aarch64_unwind_sp): Delete.
13615         (aarch64_gdbarch_init): Don't register deleted functions with
13616         gdbarch.
13617
13618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13619
13620         * gdbtypes.c (type_align): Don't consider static members when
13621         computing structure alignment.
13622
13623 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13624
13625         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13626         return 0 for other types.
13627         * arch-utils.c (default_type_align): Always return 0.
13628         * gdbarch.h: Regenerate.
13629         * gdbarch.sh (type_align): Extend comment.
13630         * gdbtypes.c (type_align): Add additional comments, always call
13631         gdbarch_type_align before applying the default rules.
13632         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13633         generic code will then apply a suitable default.
13634         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13635         types, return 0 for other types.
13636
13637 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13638
13639         * NEWS: Create a new section for the next release branch.
13640         Rename the section of the current branch, now that it has
13641         been cut.
13642
13643 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13644
13645         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13646         * version.in: Bump version to 8.3.50.DATE-git.
13647
13648 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13649
13650         * aix-thread.c (ptid_cmp): Remove unused variable.
13651         (get_signaled_thread): Likewise.
13652         (store_regs_user_thread): Likewise.
13653         (store_regs_kernel_thread): Likewise.
13654         (fetch_regs_kernel_thread): Remove shadowed variable.
13655
13656 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13657
13658         * features/riscv/32bit-cpu.xml: Add register numbers.
13659         * features/riscv/32bit-fpu.c: Regenerate.
13660         * features/riscv/32bit-fpu.xml: Add register numbers.
13661         * features/riscv/64bit-cpu.xml: Add register numbers.
13662         * features/riscv/64bit-fpu.c: Regenerate.
13663         * features/riscv/64bit-fpu.xml: Add register numbers.
13664
13665 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13666
13667         * NEWS: Mention two argument form of gdb.Value constructor.
13668         * python/py-value.c (convert_buffer_and_type_to_value): New
13669         function.
13670         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13671         Add support for handling an optional second argument.  Call
13672         convert_buffer_and_type_to_value as appropriate.
13673         * python/python-internal.h (Py_buffer_deleter): New struct.
13674         (Py_buffer_up): New typedef.
13675
13676 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13677
13678         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13679         instead of releasing ownership.
13680
13681 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13682
13683         * dwarf2read.c (open_and_init_dwp_file): Call
13684         elf_numsections instead of bfd_count_sections to initialize
13685         dwp_file->num_sections.
13686
13687 2019-02-25  Tom Tromey  <tromey@adacore.com>
13688
13689         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13690
13691 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13692
13693         * gcore.in: Add '--readnever' option when invoking GDB.
13694
13695 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13696
13697         * MAINTAINERS: Update my email address.
13698
13699 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13700
13701         * build-id.c (build_id_to_debug_bfd_1): New function.
13702         (build_id_to_debug_bfd): Look for separate debug file in
13703         sysroot.
13704
13705 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13706
13707         * gdbarch.sh: Update the copyright year range that is placed into
13708         generated files.
13709
13710 2019-02-22  Keith Seitz  <keiths@redhat.com>
13711
13712         PR symtab/23853
13713         * linespec.c (create_sals_line_offset): Search for the default
13714         symtab's filename instead of its fullname.
13715
13716 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13717
13718         * NEWS: Update style defaults.
13719
13720 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13721
13722         * main.c (captured_main_1): Disable styling in batch mode.
13723
13724 2019-02-20  Tom Tromey  <tom@tromey.com>
13725
13726         * symtab.c (symtab_symbol_info): Fix typos.
13727
13728 2019-02-20  Tom Tromey  <tromey@adacore.com>
13729
13730         * findcmd.c (_initialize_mem_search): Use upper case for
13731         metasyntactic variables.
13732
13733 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13734
13735         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13736         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13737
13738 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13739
13740         * top.h (source_file_name): Change to std::string.
13741         * top.c (source_file_name): Likewise.
13742         (command_line_input): Adjust.
13743         * cli/cli-script.c (script_from_file): Adjust.
13744
13745 2019-02-19  Tom Tromey  <tromey@adacore.com>
13746
13747         * ravenscar-thread.c
13748         (ravenscar_thread_target::update_thread_list): Don't call
13749         ada_build_task_list.
13750         * ada-lang.h (ada_build_task_list): Don't declare.
13751         * ada-tasks.c (struct ada_tasks_inferior_data)
13752         <task_list_valid_p>: Now bool.
13753         (read_known_tasks, ada_task_list_changed)
13754         (ada_tasks_invalidate_inferior_data): Update.
13755         (read_known_tasks_array): Return bool.
13756         (read_known_tasks_list): Likewise.
13757         (read_known_tasks): Return void.
13758         (ada_build_task_list): Now static.
13759
13760 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13761
13762         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13763         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13764
13765 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13766
13767         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13768         variant for ada_tasks_pspace_data_handle and
13769         ada_tasks_inferior_data_handle.
13770         (ada_tasks_pspace_data_cleanup): New function.
13771         (ada_tasks_inferior_data_cleanup): New function.
13772
13773 2019-02-17  Tom Tromey  <tom@tromey.com>
13774
13775         * macrotab.h (macro_source_fullname): Return a std::string.
13776         * macrotab.c (macro_include, check_for_redefinition)
13777         (macro_undef, macro_lookup_definition, foreach_macro)
13778         (foreach_macro_in_scope): Update.
13779         (macro_source_fullname): Return a std::string.
13780         * macrocmd.c (show_pp_source_pos): Update.
13781
13782 2019-02-17  Tom Tromey  <tom@tromey.com>
13783
13784         * macrocmd.c (show_pp_source_pos): Style the file names.
13785
13786 2019-02-17  Tom Tromey  <tom@tromey.com>
13787
13788         PR tui/24197:
13789         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13790
13791 2019-02-17  Tom Tromey  <tom@tromey.com>
13792
13793         * ada-lang.c (user_select_syms): Use filtered printing.
13794         * utils.c (wrap_style): New global.
13795         (desired_style): Remove.
13796         (emit_style_escape): Add stream parameter.
13797         (set_output_style, reset_terminal_style, prompt_for_continue):
13798         Update.
13799         (flush_wrap_buffer): Only flush gdb_stdout.
13800         (wrap_here): Set wrap_style.
13801         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13802         treat escape sequences as a character.  Change when wrap buffer is
13803         flushed.
13804         (fputs_styled): Do not set the output style when the default is
13805         requested.
13806         * ui-style.h (struct ui_file_style) <is_default>: New method.
13807         * source.c (print_source_lines_base): Emit escape sequences in one
13808         piece.
13809
13810 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13811
13812         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13813         integers and enumeration types.
13814
13815 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13816
13817         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13818         instead of lookup_symbol_in_language
13819         (do_exact_match): New function.
13820         (ada_get_symbol_name_matcher): Return do_exact_match when
13821         doing a verbatim match.
13822
13823 2019-02-15  Tom Tromey  <tromey@adacore.com>
13824
13825         * ravenscar-thread.c (ravenscar_thread_target::resume)
13826         (ravenscar_thread_target::wait): Special case wildcard requests.
13827
13828 2019-02-15  Tom Tromey  <tromey@adacore.com>
13829
13830         * ravenscar-thread.c (base_ptid): Remove.
13831         (struct ravenscar_thread_target) <close>: New method.
13832         <m_base_ptid>: New member.
13833         <update_inferior_ptid, active_task, task_is_currently_active,
13834         runtime_initialized>: Declare methods.
13835         <ravenscar_thread_target>: Add constructor.
13836         (ravenscar_thread_target::task_is_currently_active)
13837         (ravenscar_thread_target::update_inferior_ptid)
13838         (ravenscar_runtime_initialized): Rename.  Now methods.
13839         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13840         (ravenscar_thread_target::update_thread_list): Update.
13841         (ravenscar_thread_target::active_task): Now method.
13842         (ravenscar_thread_target::store_registers)
13843         (ravenscar_thread_target::prepare_to_store)
13844         (ravenscar_thread_target::prepare_to_store)
13845         (ravenscar_thread_target::mourn_inferior): Update.
13846         (ravenscar_inferior_created): Use "new" to create target.
13847         (ravenscar_thread_target::get_ada_task_ptid): Update.
13848         (_initialize_ravenscar): Don't initialize base_ptid.
13849         (ravenscar_ops): Remove global.
13850
13851 2019-02-15  Tom Tromey  <tromey@adacore.com>
13852
13853         * target.h (push_target): Declare new overload.
13854         * target.c (push_target): New overload, taking an rvalue reference.
13855         * remote.c (remote_target::open_1): Use push_target overload.
13856         * corelow.c (core_target_open): Use push_target overload.
13857
13858 2019-02-15  Tom Tromey  <tromey@adacore.com>
13859
13860         * ravenscar-thread.c (is_ravenscar_task)
13861         (ravenscar_task_is_currently_active): Return bool.
13862         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13863         (_initialize_ravenscar): Remove "(void)".
13864         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13865         Return bool.
13866
13867 2019-02-15  Tom Tromey  <tromey@adacore.com>
13868
13869         * ravenscar-thread.c (ravenscar_runtime_initializer)
13870         (has_ravenscar_runtime, get_running_thread_id)
13871         (ravenscar_thread_target::resume): Fix indentation.
13872
13873 2019-02-15  Tom Tromey  <tromey@adacore.com>
13874
13875         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13876         from ravenscar_arch_ops.
13877         (sparc_ravenscar_ops::fetch_registers)
13878         (sparc_ravenscar_ops::store_registers): Now methods.
13879         (sparc_ravenscar_prepare_to_store): Remove.
13880         (sparc_ravenscar_ops): Redefine.
13881         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13882         methods and destructor.  Remove members.
13883         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13884         (ravenscar_thread_target::store_registers)
13885         (ravenscar_thread_target::prepare_to_store): Update.
13886         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13887         Remove.
13888         (struct ppc_ravenscar_powerpc_ops): Derive from
13889         ravenscar_arch_ops.
13890         (ppc_ravenscar_powerpc_ops::fetch_registers)
13891         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13892         (ppc_ravenscar_powerpc_ops): Redefine.
13893         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13894         (ppc_ravenscar_e500_ops::fetch_registers)
13895         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13896         (ppc_ravenscar_e500_ops): Redefine.
13897         * aarch64-ravenscar-thread.c
13898         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13899         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13900         (aarch64_ravenscar_fetch_registers)
13901         (aarch64_ravenscar_store_registers): Now methods.
13902         (aarch64_ravenscar_ops): Redefine.
13903
13904 2019-02-15  Tom Tromey  <tromey@adacore.com>
13905
13906         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13907         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13908         (ravenscar_thread_target::stopped_by_watchpoint)
13909         (ravenscar_thread_target::stopped_data_address)
13910         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13911
13912 2019-02-15  Tom Tromey  <tromey@adacore.com>
13913
13914         * ravenscar-thread.c: Fix some typos.
13915
13916 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13917             Tom Tromey  <tromey@adacore.com>
13918
13919         * ada-lang.c (ada_exception_sal): Change addr_string to a
13920         std::string.
13921         (create_ada_exception_catchpoint): Update.
13922
13923 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13924             Tom Tromey  <tromey@adacore.com>
13925
13926         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13927         (bp_location_ops): Remove.
13928         (base_breakpoint_allocate_location): Update.
13929         (free_bp_location): Update.
13930         * ada-lang.c (class ada_catchpoint_location)
13931         <ada_catchpoint_location>: Remove ops parameter.
13932         (ada_catchpoint_location_dtor): Remove.
13933         (ada_catchpoint_location_ops): Remove.
13934         (allocate_location_exception): Update.
13935         * breakpoint.h (struct bp_location_ops): Remove.
13936         (class bp_location) <bp_location>: Remove bp_location_ops
13937         parameter.
13938         <~bp_location>: Add destructor.
13939         <ops>: Remove.
13940
13941 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13942             Pedro Alves  <palves@redhat.com>
13943
13944         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13945         'PATH_MAX'.
13946
13947 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13948             Samuel Thibault  <samuel.thibault@gnu.org>
13949             Thomas Schwinge  <thomas@codesourcery.com>
13950
13951         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13952         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13953
13954 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13955
13956         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13957         (check_empty): Use "const char *".
13958
13959         * gnu-nat.c (gnu_nat_target::detach): Instead of
13960         'detach_inferior (pid)' call
13961         'detach_inferior (find_inferior_pid (pid))'.
13962
13963         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13964         'nat/fork-inferior.o'.
13965         * gnu-nat.c: #include "nat/fork-inferior.h".
13966
13967         * gnu-nat.c (gnu_nat_target::detach): Instead of
13968         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13969         * gnu-nat.h: #include "inf-child.h".
13970         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13971         'i386_gnu_nat_target::fetch_registers'.
13972         (gnu_store_registers): Rename/move to
13973         'i386_gnu_nat_target::store_registers'.
13974
13975         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13976         * gnu-nat.h (mach_thread_info): New function.
13977         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13978
13979         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13980
13981 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13982
13983         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13984
13985 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13986
13987         * windows-nat.c (windows_add_thread): Add new parameter
13988         "main_thread_p" with default value set to false.  Update
13989         function documentation as well as all callers.
13990         (windows_delete_thread): Likewise.
13991         (fake_create_process): Update call to windows_add_thread.
13992         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13993         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13994         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13995         call to windows_delete_thread.
13996
13997 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13998
13999         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14000
14001 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14002
14003         * symfile.c (find_separate_debug_file): Use canonical path of
14004         sysroot with child_path instead of gdb_sysroot if it is valid.
14005
14006 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14007
14008         * symfile.c (find_separate_debug_file): Use child_path to
14009         determine if an object file is under a sysroot.
14010
14011 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14012
14013         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14014         unittests/child-path-selftests.c.
14015         * common/pathstuff.c (child_path): New function.
14016         * common/pathstuff.h (child_path): New prototype.
14017         * unittests/child-path-selftests.c: New file.
14018
14019 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14020
14021         * symfile.c (find_separate_debug_file): Look for separate debug
14022         files in debug directories under the sysroot.
14023
14024 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14025
14026         * symtab.h (struct minimal_symbol data_p): New const method.
14027         (struct minimal_symbol text_p): Likewise.
14028         * symtab.c (output_source_filename): Use file name style
14029         to print file name.
14030         (print_symbol_info): Likewise.
14031         (print_msymbol_info): Use address style to print addresses.
14032         Use function name style to print executable text symbols.
14033         (expand_symtab_containing_pc): Use data_p.
14034         (find_pc_sect_compunit_symtab): Likewise.
14035
14036 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14037
14038         * breakpoint.c (describe_other_breakpoints): Use address style
14039         to print addresses.
14040         (say_where): Likewise.
14041
14042 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14043
14044         * ada-typeprint.c (print_func_type): Print function name
14045         style to print function name.
14046         * c-typeprint.c (c_print_type_1): Likewise.
14047
14048 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14049
14050         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14051         for execve.
14052
14053 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14054
14055         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14056         type_stack.
14057
14058 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14059
14060         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14061         TYPE_CODE_REF types.
14062
14063 2019-02-08  Jim Wilson  <jimw@sifive.com>
14064
14065         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14066         (riscv_linux_fregset): New.
14067         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14068
14069 2019-02-07  Tom Tromey  <tom@tromey.com>
14070
14071         * thread.c (thread_cancel_execution_command): Update.
14072         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14073         methods.
14074         (struct thread_fsm_ops): Remove.
14075         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14076         (thread_fsm_should_stop, thread_fsm_return_value)
14077         (thread_fsm_set_finished, thread_fsm_finished_p)
14078         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14079         Don't declare.
14080         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14081         * infrun.c (clear_proceed_status_thread)
14082         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14083         (print_stop_event): Update.
14084         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14085         Add constructor.
14086         (step_command_fsm_ops): Remove.
14087         (new_step_command_fsm): Remove.
14088         (step_1): Update.
14089         (step_command_fsm::should_stop): Rename from
14090         step_command_fsm_should_stop.
14091         (step_command_fsm::clean_up): Rename from
14092         step_command_fsm_clean_up.
14093         (step_command_fsm::do_async_reply_reason): Rename from
14094         step_command_fsm_async_reply_reason.
14095         (struct until_next_fsm): Inherit from thread_fsm.  Add
14096         constructor.
14097         (until_next_fsm_ops): Remove.
14098         (new_until_next_fsm): Remove.
14099         (until_next_fsm::should_stop): Rename from
14100         until_next_fsm_should_stop.
14101         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14102         (until_next_fsm::do_async_reply_reason): Rename from
14103         until_next_fsm_async_reply_reason.
14104         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14105         constructor.  Change type of breakpoint.
14106         (finish_command_fsm_ops): Remove.
14107         (new_finish_command_fsm): Remove.
14108         (finish_command_fsm::should_stop): Rename from
14109         finish_command_fsm_should_stop.
14110         (finish_command_fsm::clean_up): Rename from
14111         finish_command_fsm_clean_up.
14112         (finish_command_fsm::return_value): Rename from
14113         finish_command_fsm_return_value.
14114         (finish_command_fsm::do_async_reply_reason): Rename from
14115         finish_command_fsm_async_reply_reason.
14116         (finish_command): Update.
14117         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14118         Add constructor.
14119         (call_thread_fsm_ops): Remove.
14120         (call_thread_fsm::call_thread_fsm): Rename from
14121         new_call_thread_fsm.
14122         (call_thread_fsm::should_stop): Rename from
14123         call_thread_fsm_should_stop.
14124         (call_thread_fsm::should_notify_stop): Rename from
14125         call_thread_fsm_should_notify_stop.
14126         (run_inferior_call, call_function_by_hand_dummy): Update.
14127         * cli/cli-interp.c (should_print_stop_to_console): Update.
14128         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14129         Add constructor.  Change type of location_breakpoint,
14130         caller_breakpoint.
14131         (until_break_fsm_ops): Remove.
14132         (new_until_break_fsm): Remove.
14133         (until_break_fsm::should_stop): Rename from
14134         until_break_fsm_should_stop.
14135         (until_break_fsm::clean_up): Rename from
14136         until_break_fsm_clean_up.
14137         (until_break_fsm::do_async_reply_reason): Rename from
14138         until_break_fsm_async_reply_reason.
14139         (until_break_command): Update.
14140         * thread-fsm.c: Remove.
14141         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14142
14143 2019-02-07  Tom Tromey  <tom@tromey.com>
14144
14145         * yy-remap.h: Add include guard.
14146         * xtensa-tdep.h: Add include guard.
14147         * xcoffread.h: Rename include guard.
14148         * varobj-iter.h: Add include guard.
14149         * tui/tui.h: Rename include guard.
14150         * tui/tui-winsource.h: Rename include guard.
14151         * tui/tui-wingeneral.h: Rename include guard.
14152         * tui/tui-windata.h: Rename include guard.
14153         * tui/tui-win.h: Rename include guard.
14154         * tui/tui-stack.h: Rename include guard.
14155         * tui/tui-source.h: Rename include guard.
14156         * tui/tui-regs.h: Rename include guard.
14157         * tui/tui-out.h: Rename include guard.
14158         * tui/tui-layout.h: Rename include guard.
14159         * tui/tui-io.h: Rename include guard.
14160         * tui/tui-hooks.h: Rename include guard.
14161         * tui/tui-file.h: Rename include guard.
14162         * tui/tui-disasm.h: Rename include guard.
14163         * tui/tui-data.h: Rename include guard.
14164         * tui/tui-command.h: Rename include guard.
14165         * tic6x-tdep.h: Add include guard.
14166         * target/waitstatus.h: Rename include guard.
14167         * target/wait.h: Rename include guard.
14168         * target/target.h: Rename include guard.
14169         * target/resume.h: Rename include guard.
14170         * target-float.h: Rename include guard.
14171         * stabsread.h: Add include guard.
14172         * rs6000-tdep.h: Add include guard.
14173         * riscv-fbsd-tdep.h: Add include guard.
14174         * regformats/regdef.h: Rename include guard.
14175         * record.h: Rename include guard.
14176         * python/python.h: Rename include guard.
14177         * python/python-internal.h: Rename include guard.
14178         * python/py-stopevent.h: Rename include guard.
14179         * python/py-ref.h: Rename include guard.
14180         * python/py-record.h: Rename include guard.
14181         * python/py-record-full.h: Rename include guard.
14182         * python/py-record-btrace.h: Rename include guard.
14183         * python/py-instruction.h: Rename include guard.
14184         * python/py-events.h: Rename include guard.
14185         * python/py-event.h: Rename include guard.
14186         * procfs.h: Add include guard.
14187         * proc-utils.h: Add include guard.
14188         * p-lang.h: Add include guard.
14189         * or1k-tdep.h: Rename include guard.
14190         * observable.h: Rename include guard.
14191         * nto-tdep.h: Rename include guard.
14192         * nat/x86-linux.h: Rename include guard.
14193         * nat/x86-linux-dregs.h: Rename include guard.
14194         * nat/x86-gcc-cpuid.h: Add include guard.
14195         * nat/x86-dregs.h: Rename include guard.
14196         * nat/x86-cpuid.h: Rename include guard.
14197         * nat/ppc-linux.h: Rename include guard.
14198         * nat/mips-linux-watch.h: Rename include guard.
14199         * nat/linux-waitpid.h: Rename include guard.
14200         * nat/linux-ptrace.h: Rename include guard.
14201         * nat/linux-procfs.h: Rename include guard.
14202         * nat/linux-osdata.h: Rename include guard.
14203         * nat/linux-nat.h: Rename include guard.
14204         * nat/linux-namespaces.h: Rename include guard.
14205         * nat/linux-btrace.h: Rename include guard.
14206         * nat/glibc_thread_db.h: Rename include guard.
14207         * nat/gdb_thread_db.h: Rename include guard.
14208         * nat/gdb_ptrace.h: Rename include guard.
14209         * nat/fork-inferior.h: Rename include guard.
14210         * nat/amd64-linux-siginfo.h: Rename include guard.
14211         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14212         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14213         * nat/aarch64-linux.h: Rename include guard.
14214         * nat/aarch64-linux-hw-point.h: Rename include guard.
14215         * mn10300-tdep.h: Add include guard.
14216         * mips-linux-tdep.h: Add include guard.
14217         * mi/mi-parse.h: Rename include guard.
14218         * mi/mi-out.h: Rename include guard.
14219         * mi/mi-main.h: Rename include guard.
14220         * mi/mi-interp.h: Rename include guard.
14221         * mi/mi-getopt.h: Rename include guard.
14222         * mi/mi-console.h: Rename include guard.
14223         * mi/mi-common.h: Rename include guard.
14224         * mi/mi-cmds.h: Rename include guard.
14225         * mi/mi-cmd-break.h: Rename include guard.
14226         * m2-lang.h: Add include guard.
14227         * location.h: Rename include guard.
14228         * linux-record.h: Rename include guard.
14229         * linux-nat.h: Add include guard.
14230         * linux-fork.h: Add include guard.
14231         * i386-darwin-tdep.h: Rename include guard.
14232         * hppa-linux-offsets.h: Add include guard.
14233         * guile/guile.h: Rename include guard.
14234         * guile/guile-internal.h: Rename include guard.
14235         * gnu-nat.h: Rename include guard.
14236         * gdb-stabs.h: Rename include guard.
14237         * frv-tdep.h: Add include guard.
14238         * f-lang.h: Add include guard.
14239         * event-loop.h: Add include guard.
14240         * darwin-nat.h: Rename include guard.
14241         * cp-abi.h: Rename include guard.
14242         * config/sparc/nm-sol2.h: Rename include guard.
14243         * config/nm-nto.h: Rename include guard.
14244         * config/nm-linux.h: Add include guard.
14245         * config/i386/nm-i386gnu.h: Rename include guard.
14246         * config/djgpp/nl_types.h: Rename include guard.
14247         * config/djgpp/langinfo.h: Rename include guard.
14248         * compile/gcc-cp-plugin.h: Add include guard.
14249         * compile/gcc-c-plugin.h: Add include guard.
14250         * compile/compile.h: Rename include guard.
14251         * compile/compile-object-run.h: Rename include guard.
14252         * compile/compile-object-load.h: Rename include guard.
14253         * compile/compile-internal.h: Rename include guard.
14254         * compile/compile-cplus.h: Rename include guard.
14255         * compile/compile-c.h: Rename include guard.
14256         * common/xml-utils.h: Rename include guard.
14257         * common/x86-xstate.h: Rename include guard.
14258         * common/version.h: Rename include guard.
14259         * common/vec.h: Rename include guard.
14260         * common/tdesc.h: Rename include guard.
14261         * common/selftest.h: Rename include guard.
14262         * common/scoped_restore.h: Rename include guard.
14263         * common/scoped_mmap.h: Rename include guard.
14264         * common/scoped_fd.h: Rename include guard.
14265         * common/safe-iterator.h: Rename include guard.
14266         * common/run-time-clock.h: Rename include guard.
14267         * common/refcounted-object.h: Rename include guard.
14268         * common/queue.h: Rename include guard.
14269         * common/ptid.h: Rename include guard.
14270         * common/print-utils.h: Rename include guard.
14271         * common/preprocessor.h: Rename include guard.
14272         * common/pathstuff.h: Rename include guard.
14273         * common/observable.h: Rename include guard.
14274         * common/netstuff.h: Rename include guard.
14275         * common/job-control.h: Rename include guard.
14276         * common/host-defs.h: Rename include guard.
14277         * common/gdb_wait.h: Rename include guard.
14278         * common/gdb_vecs.h: Rename include guard.
14279         * common/gdb_unlinker.h: Rename include guard.
14280         * common/gdb_unique_ptr.h: Rename include guard.
14281         * common/gdb_tilde_expand.h: Rename include guard.
14282         * common/gdb_sys_time.h: Rename include guard.
14283         * common/gdb_string_view.h: Rename include guard.
14284         * common/gdb_splay_tree.h: Rename include guard.
14285         * common/gdb_setjmp.h: Rename include guard.
14286         * common/gdb_ref_ptr.h: Rename include guard.
14287         * common/gdb_optional.h: Rename include guard.
14288         * common/gdb_locale.h: Rename include guard.
14289         * common/gdb_assert.h: Rename include guard.
14290         * common/filtered-iterator.h: Rename include guard.
14291         * common/filestuff.h: Rename include guard.
14292         * common/fileio.h: Rename include guard.
14293         * common/environ.h: Rename include guard.
14294         * common/common-utils.h: Rename include guard.
14295         * common/common-types.h: Rename include guard.
14296         * common/common-regcache.h: Rename include guard.
14297         * common/common-inferior.h: Rename include guard.
14298         * common/common-gdbthread.h: Rename include guard.
14299         * common/common-exceptions.h: Rename include guard.
14300         * common/common-defs.h: Rename include guard.
14301         * common/common-debug.h: Rename include guard.
14302         * common/cleanups.h: Rename include guard.
14303         * common/buffer.h: Rename include guard.
14304         * common/btrace-common.h: Rename include guard.
14305         * common/break-common.h: Rename include guard.
14306         * cli/cli-utils.h: Rename include guard.
14307         * cli/cli-style.h: Rename include guard.
14308         * cli/cli-setshow.h: Rename include guard.
14309         * cli/cli-script.h: Rename include guard.
14310         * cli/cli-interp.h: Rename include guard.
14311         * cli/cli-decode.h: Rename include guard.
14312         * cli/cli-cmds.h: Rename include guard.
14313         * charset-list.h: Add include guard.
14314         * buildsym-legacy.h: Rename include guard.
14315         * bfin-tdep.h: Add include guard.
14316         * ax.h: Rename include guard.
14317         * arm-linux-tdep.h: Add include guard.
14318         * arm-fbsd-tdep.h: Add include guard.
14319         * arch/xtensa.h: Rename include guard.
14320         * arch/tic6x.h: Add include guard.
14321         * arch/i386.h: Add include guard.
14322         * arch/arm.h: Rename include guard.
14323         * arch/arm-linux.h: Rename include guard.
14324         * arch/arm-get-next-pcs.h: Rename include guard.
14325         * arch/amd64.h: Add include guard.
14326         * arch/aarch64-insn.h: Rename include guard.
14327         * arch-utils.h: Rename include guard.
14328         * annotate.h: Add include guard.
14329         * amd64-darwin-tdep.h: Rename include guard.
14330         * aarch64-linux-tdep.h: Add include guard.
14331         * aarch64-fbsd-tdep.h: Add include guard.
14332         * aarch32-linux-nat.h: Add include guard.
14333
14334 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14335
14336         * macrotab.c (macro_define_internal): New function that
14337         factorizes macro_define_object_internal and macro_define_function
14338         code.
14339         (macro_define_object_internal): Use macro_define_internal.
14340         (macro_define_function): Likewise.
14341
14342 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14343
14344         * macrocmd.c (extract_identifier): Return
14345         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14346         callers.
14347
14348 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14349
14350         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14351
14352 2019-02-05  Tom Tromey  <tom@tromey.com>
14353
14354         * target.c (target_stack::unpush): Move assertion earlier.
14355
14356 2019-01-30  Tom Tromey  <tom@tromey.com>
14357
14358         PR python/23615:
14359         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14360         (gdbpy_parse_and_eval): Likewise.
14361         * python/python-internal.h (gdbpy_allow_threads): New class.
14362
14363 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14364
14365         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14366         (aarch64_fbsd_fpregmap): Move earlier.
14367         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14368         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14369         instead of individual calls to trad_frame_set_reg_addr.
14370         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14371         earlier.
14372         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14373         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14374         instead of individual calls to trad_frame_set_reg_addr.
14375
14376 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14377
14378         * CONTRIBUTE: Replace contribution list with wiki link.
14379
14380 2019-01-25  Tom Tromey  <tom@tromey.com>
14381
14382         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14383
14384 2019-01-25  Tom Tromey  <tom@tromey.com>
14385
14386         * xtensa-linux-nat.c: Fix common/ includes.
14387         * xml-support.h: Fix common/ includes.
14388         * xml-support.c: Fix common/ includes.
14389         * x86-linux-nat.c: Fix common/ includes.
14390         * windows-nat.c: Fix common/ includes.
14391         * varobj.h: Fix common/ includes.
14392         * varobj.c: Fix common/ includes.
14393         * value.c: Fix common/ includes.
14394         * valops.c: Fix common/ includes.
14395         * utils.c: Fix common/ includes.
14396         * unittests/xml-utils-selftests.c: Fix common/ includes.
14397         * unittests/utils-selftests.c: Fix common/ includes.
14398         * unittests/unpack-selftests.c: Fix common/ includes.
14399         * unittests/tracepoint-selftests.c: Fix common/ includes.
14400         * unittests/style-selftests.c: Fix common/ includes.
14401         * unittests/string_view-selftests.c: Fix common/ includes.
14402         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14403         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14404         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14405         * unittests/rsp-low-selftests.c: Fix common/ includes.
14406         * unittests/parse-connection-spec-selftests.c: Fix common/
14407         includes.
14408         * unittests/optional-selftests.c: Fix common/ includes.
14409         * unittests/offset-type-selftests.c: Fix common/ includes.
14410         * unittests/observable-selftests.c: Fix common/ includes.
14411         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14412         * unittests/memrange-selftests.c: Fix common/ includes.
14413         * unittests/memory-map-selftests.c: Fix common/ includes.
14414         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14415         * unittests/function-view-selftests.c: Fix common/ includes.
14416         * unittests/environ-selftests.c: Fix common/ includes.
14417         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14418         * unittests/common-utils-selftests.c: Fix common/ includes.
14419         * unittests/cli-utils-selftests.c: Fix common/ includes.
14420         * unittests/array-view-selftests.c: Fix common/ includes.
14421         * ui-file.c: Fix common/ includes.
14422         * tui/tui-io.c: Fix common/ includes.
14423         * tracepoint.h: Fix common/ includes.
14424         * tracepoint.c: Fix common/ includes.
14425         * tracefile-tfile.c: Fix common/ includes.
14426         * top.h: Fix common/ includes.
14427         * top.c: Fix common/ includes.
14428         * thread.c: Fix common/ includes.
14429         * target/waitstatus.h: Fix common/ includes.
14430         * target/waitstatus.c: Fix common/ includes.
14431         * target.h: Fix common/ includes.
14432         * target.c: Fix common/ includes.
14433         * target-memory.c: Fix common/ includes.
14434         * target-descriptions.c: Fix common/ includes.
14435         * symtab.h: Fix common/ includes.
14436         * symfile.c: Fix common/ includes.
14437         * stap-probe.c: Fix common/ includes.
14438         * spu-linux-nat.c: Fix common/ includes.
14439         * sparc-nat.c: Fix common/ includes.
14440         * source.c: Fix common/ includes.
14441         * solib.c: Fix common/ includes.
14442         * solib-target.c: Fix common/ includes.
14443         * ser-unix.c: Fix common/ includes.
14444         * ser-tcp.c: Fix common/ includes.
14445         * ser-pipe.c: Fix common/ includes.
14446         * ser-base.c: Fix common/ includes.
14447         * selftest-arch.c: Fix common/ includes.
14448         * s12z-tdep.c: Fix common/ includes.
14449         * rust-exp.y: Fix common/ includes.
14450         * rs6000-aix-tdep.c: Fix common/ includes.
14451         * riscv-tdep.c: Fix common/ includes.
14452         * remote.c: Fix common/ includes.
14453         * remote-notif.h: Fix common/ includes.
14454         * remote-fileio.h: Fix common/ includes.
14455         * remote-fileio.c: Fix common/ includes.
14456         * regcache.h: Fix common/ includes.
14457         * regcache.c: Fix common/ includes.
14458         * record-btrace.c: Fix common/ includes.
14459         * python/python.c: Fix common/ includes.
14460         * python/py-type.c: Fix common/ includes.
14461         * python/py-inferior.c: Fix common/ includes.
14462         * progspace.h: Fix common/ includes.
14463         * producer.c: Fix common/ includes.
14464         * procfs.c: Fix common/ includes.
14465         * proc-api.c: Fix common/ includes.
14466         * printcmd.c: Fix common/ includes.
14467         * ppc-linux-nat.c: Fix common/ includes.
14468         * parser-defs.h: Fix common/ includes.
14469         * osdata.c: Fix common/ includes.
14470         * obsd-nat.c: Fix common/ includes.
14471         * nat/x86-linux.c: Fix common/ includes.
14472         * nat/x86-linux-dregs.c: Fix common/ includes.
14473         * nat/x86-dregs.h: Fix common/ includes.
14474         * nat/x86-dregs.c: Fix common/ includes.
14475         * nat/ppc-linux.c: Fix common/ includes.
14476         * nat/mips-linux-watch.h: Fix common/ includes.
14477         * nat/mips-linux-watch.c: Fix common/ includes.
14478         * nat/linux-waitpid.c: Fix common/ includes.
14479         * nat/linux-ptrace.h: Fix common/ includes.
14480         * nat/linux-ptrace.c: Fix common/ includes.
14481         * nat/linux-procfs.c: Fix common/ includes.
14482         * nat/linux-personality.c: Fix common/ includes.
14483         * nat/linux-osdata.c: Fix common/ includes.
14484         * nat/linux-namespaces.c: Fix common/ includes.
14485         * nat/linux-btrace.h: Fix common/ includes.
14486         * nat/linux-btrace.c: Fix common/ includes.
14487         * nat/fork-inferior.c: Fix common/ includes.
14488         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14489         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14490         * nat/aarch64-linux.c: Fix common/ includes.
14491         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14492         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14493         * namespace.h: Fix common/ includes.
14494         * mips-linux-tdep.c: Fix common/ includes.
14495         * minsyms.c: Fix common/ includes.
14496         * mi/mi-parse.h: Fix common/ includes.
14497         * mi/mi-main.c: Fix common/ includes.
14498         * mi/mi-cmd-env.c: Fix common/ includes.
14499         * memrange.h: Fix common/ includes.
14500         * memattr.c: Fix common/ includes.
14501         * maint.h: Fix common/ includes.
14502         * maint.c: Fix common/ includes.
14503         * main.c: Fix common/ includes.
14504         * machoread.c: Fix common/ includes.
14505         * location.c: Fix common/ includes.
14506         * linux-thread-db.c: Fix common/ includes.
14507         * linux-nat.c: Fix common/ includes.
14508         * linux-fork.c: Fix common/ includes.
14509         * inline-frame.c: Fix common/ includes.
14510         * infrun.c: Fix common/ includes.
14511         * inflow.c: Fix common/ includes.
14512         * inferior.h: Fix common/ includes.
14513         * inferior.c: Fix common/ includes.
14514         * infcmd.c: Fix common/ includes.
14515         * inf-ptrace.c: Fix common/ includes.
14516         * inf-child.c: Fix common/ includes.
14517         * ia64-linux-nat.c: Fix common/ includes.
14518         * i387-tdep.c: Fix common/ includes.
14519         * i386-tdep.c: Fix common/ includes.
14520         * i386-linux-tdep.c: Fix common/ includes.
14521         * i386-linux-nat.c: Fix common/ includes.
14522         * i386-go32-tdep.c: Fix common/ includes.
14523         * i386-fbsd-tdep.c: Fix common/ includes.
14524         * i386-fbsd-nat.c: Fix common/ includes.
14525         * guile/scm-type.c: Fix common/ includes.
14526         * guile/guile.c: Fix common/ includes.
14527         * go32-nat.c: Fix common/ includes.
14528         * gnu-nat.c: Fix common/ includes.
14529         * gdbthread.h: Fix common/ includes.
14530         * gdbarch-selftests.c: Fix common/ includes.
14531         * gdb_usleep.c: Fix common/ includes.
14532         * gdb_select.h: Fix common/ includes.
14533         * gdb_bfd.c: Fix common/ includes.
14534         * gcore.c: Fix common/ includes.
14535         * fork-child.c: Fix common/ includes.
14536         * findvar.c: Fix common/ includes.
14537         * fbsd-nat.c: Fix common/ includes.
14538         * event-top.c: Fix common/ includes.
14539         * event-loop.c: Fix common/ includes.
14540         * dwarf2read.c: Fix common/ includes.
14541         * dwarf2loc.c: Fix common/ includes.
14542         * dwarf2-frame.c: Fix common/ includes.
14543         * dwarf-index-cache.c: Fix common/ includes.
14544         * dtrace-probe.c: Fix common/ includes.
14545         * disasm-selftests.c: Fix common/ includes.
14546         * defs.h: Fix common/ includes.
14547         * csky-tdep.c: Fix common/ includes.
14548         * cp-valprint.c: Fix common/ includes.
14549         * cp-support.h: Fix common/ includes.
14550         * cp-support.c: Fix common/ includes.
14551         * corelow.c: Fix common/ includes.
14552         * completer.h: Fix common/ includes.
14553         * completer.c: Fix common/ includes.
14554         * compile/compile.c: Fix common/ includes.
14555         * compile/compile-loc2c.c: Fix common/ includes.
14556         * compile/compile-cplus-types.c: Fix common/ includes.
14557         * compile/compile-cplus-symbols.c: Fix common/ includes.
14558         * command.h: Fix common/ includes.
14559         * cli/cli-dump.c: Fix common/ includes.
14560         * cli/cli-cmds.c: Fix common/ includes.
14561         * charset.c: Fix common/ includes.
14562         * build-id.c: Fix common/ includes.
14563         * btrace.h: Fix common/ includes.
14564         * btrace.c: Fix common/ includes.
14565         * breakpoint.h: Fix common/ includes.
14566         * breakpoint.c: Fix common/ includes.
14567         * ax.h:
14568         (enum agent_op): Fix common/ includes.
14569         * ax-general.c (struct aop_map): Fix common/ includes.
14570         * ax-gdb.c: Fix common/ includes.
14571         * auxv.c: Fix common/ includes.
14572         * auto-load.c: Fix common/ includes.
14573         * arm-tdep.c: Fix common/ includes.
14574         * arch/riscv.c: Fix common/ includes.
14575         * arch/ppc-linux-common.c: Fix common/ includes.
14576         * arch/i386.c: Fix common/ includes.
14577         * arch/arm.c: Fix common/ includes.
14578         * arch/arm-linux.c: Fix common/ includes.
14579         * arch/arm-get-next-pcs.c: Fix common/ includes.
14580         * arch/amd64.c: Fix common/ includes.
14581         * arch/aarch64.c: Fix common/ includes.
14582         * arch/aarch64-insn.c: Fix common/ includes.
14583         * arch-utils.c: Fix common/ includes.
14584         * amd64-windows-tdep.c: Fix common/ includes.
14585         * amd64-tdep.c: Fix common/ includes.
14586         * amd64-sol2-tdep.c: Fix common/ includes.
14587         * amd64-obsd-tdep.c: Fix common/ includes.
14588         * amd64-nbsd-tdep.c: Fix common/ includes.
14589         * amd64-linux-tdep.c: Fix common/ includes.
14590         * amd64-linux-nat.c: Fix common/ includes.
14591         * amd64-fbsd-tdep.c: Fix common/ includes.
14592         * amd64-fbsd-nat.c: Fix common/ includes.
14593         * amd64-dicos-tdep.c: Fix common/ includes.
14594         * amd64-darwin-tdep.c: Fix common/ includes.
14595         * agent.c: Fix common/ includes.
14596         * ada-lang.h: Fix common/ includes.
14597         * ada-lang.c: Fix common/ includes.
14598         * aarch64-tdep.c: Fix common/ includes.
14599
14600 2019-01-25  Tom Tromey  <tom@tromey.com>
14601
14602         * common/create-version.sh: Use common/version.h.
14603
14604 2019-01-24  Pedro Alves  <palves@redhat.com>
14605
14606         * infrun.c (signal_stop, signal_print, signal_program)
14607         (signal_catch, signal_pass): Now arrays instead of pointers.
14608         (update_signals_program_target, do_target_resume)
14609         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14610         * linux-nat.c (linux_nat_target::pass_signals)
14611         (linux_nat_target::create_inferior, linux_nat_target::attach):
14612         Adjust.
14613         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14614         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14615         * procfs.c (procfs_target::pass_signals): Adjust.
14616         * record-full.c (record_full_target::resume): Adjust.
14617         * remote.c (remote_target::pass_signals)
14618         (remote_target::program_signals): Adjust.
14619         * target-debug.h (target_debug_print_signals): Now takes a
14620         gdb::array_view as parameter.  Adjust.
14621         * target.h (target_ops) <pass_signals, program_signals>: Replace
14622         pointer and length parameters with gdb::array_view.
14623         (target_pass_signals, target_program_signals): Likewise.
14624         * target-delegates.c: Regenerate.
14625
14626 2019-01-24  Pedro Alves  <palves@redhat.com>
14627
14628         * common/forward-scope-exit.h
14629         (forward_scope_exit::forward_scope_exit): Pass arguments to
14630         m_bind_function directly, instead of creating a std::bind and
14631         copying that.
14632
14633 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14634
14635         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14636         for static members.
14637         (pass_in_v_vfp_candidate): Likewise.
14638
14639 2019-01-23  Tom Tromey  <tom@tromey.com>
14640             Pedro Alves  <palves@redhat.com>
14641
14642         * regcache.c (class regcache_invalidator): Remove.
14643         (regcache::raw_write): Use make_scope_exit.
14644
14645 2019-01-23  Tom Tromey  <tom@tromey.com>
14646
14647         * ui-out.h (class ui_out_emit_type): Update comment.
14648
14649 2019-01-23  Tom Tromey  <tom@tromey.com>
14650
14651         * infrun.c (fetch_inferior_event): Update comment.
14652
14653 2019-01-23  Tom Tromey  <tom@tromey.com>
14654             Pedro Alves  <palves@redhat.com>
14655
14656         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14657         parameter.
14658         (fetch_inferior_event): Use SCOPE_EXIT.
14659
14660
14661 2019-01-23  Tom Tromey  <tom@tromey.com>
14662             Pedro Alves  <palves@redhat.com>
14663
14664         * infrun.c (disable_thread_events): Delete.
14665         (stop_all_threads): Use SCOPE_EXIT.
14666
14667 2019-01-23  Tom Tromey  <tom@tromey.com>
14668             Pedro Alves  <palves@redhat.com>
14669
14670         * symfile.c: Include forward-scope-exit.h.
14671         (clear_symtab_users_cleanup): Replace forward declaration with
14672         a FORWARD_SCOPE_EXIT.
14673         (syms_from_objfile_1): Use the forward_scope_exit and
14674         gdb::optional instead of cleanup_function.
14675         (reread_symbols): Use the forward_scope_exit instead of
14676         cleanup_function.
14677         (clear_symtab_users_cleanup): Remove function.
14678
14679 2019-01-23  Tom Tromey  <tom@tromey.com>
14680             Pedro Alves  <palves@redhat.com>
14681
14682         * linux-nat.c: Include scope-exit.h.
14683         (cleanup_target_stop): Remove.
14684         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14685         SCOPE_EXIT.
14686
14687 2019-01-23  Tom Tromey  <tom@tromey.com>
14688             Pedro Alves  <palves@redhat.com>
14689
14690         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14691         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14692
14693 2019-01-23  Tom Tromey  <tom@tromey.com>
14694             Andrew Burgess  <andrew.burgess@embecosm.com>
14695             Pedro Alves  <palves@redhat.com>
14696
14697         * infrun.c (fetch_inferior_event): Use scope_exit.
14698         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14699         * top.c (execute_command): Use scope_exit.
14700         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14701         * utils.c (do_bpstat_clear_actions_cleanup)
14702         (make_bpstat_clear_actions_cleanup): Remove.
14703
14704 2019-01-23  Tom Tromey  <tom@tromey.com>
14705             Pedro Alves  <palves@redhat.com>
14706
14707         * infrun.c: Include "common/scope-exit.h"
14708         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14709         (wait_for_inferior): Use SCOPE_EXIT.
14710         (fetch_inferior_event): Use scope_exit.
14711
14712 2019-01-23  Tom Tromey  <tom@tromey.com>
14713             Pedro Alves  <palves@redhat.com>
14714
14715         * breakpoint.c (create_breakpoint): Remove cleanup.
14716
14717 2019-01-23  Tom Tromey  <tom@tromey.com>
14718             Andrew Burgess  <andrew.burgess@embecosm.com>
14719             Pedro Alves  <palves@redhat.com>
14720
14721 2019-01-23  Pedro Alves  <palves@redhat.com>
14722
14723         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14724
14725 2019-01-23  Pedro Alves  <palves@redhat.com>
14726             Andrew Burgess  <andrew.burgess@embecosm.com>
14727
14728         * gdbthread.h: Include "common/forward-scope-exit.h".
14729         (scoped_finish_thread_state): Redefine custom class in terms of
14730         forward_scope_exit.
14731
14732 2019-01-23  Pedro Alves  <palves@redhat.com>
14733             Andrew Burgess  <andrew.burgess@embecosm.com>
14734
14735         * common/forward-scope-exit.h: New file.
14736
14737 2019-01-23  Pedro Alves  <palves@redhat.com>
14738             Andrew Burgess  <andrew.burgess@embecosm.com>
14739             Tom Tromey  <tom@tromey.com>
14740
14741         * common/scope-exit.h: New file.
14742
14743 2019-01-23  Pedro Alves  <palves@redhat.com>
14744
14745         * common/preprocessor.h (ESC): Rename to ...
14746         (ESC_PARENS): ... this.
14747         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14748         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14749
14750 2019-01-23  Tom Tromey  <tom@tromey.com>
14751
14752         * language.h (class scoped_switch_to_sym_language_if_auto):
14753         Initialize m_lang in both cases.
14754
14755 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14756
14757         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14758         with XCNEW.
14759
14760 2019-01-22  Tom Tromey  <tom@tromey.com>
14761
14762         * corelow.c: Do not include sys/file.h.
14763
14764 2019-01-22  Tom Tromey  <tom@tromey.com>
14765
14766         * tui/tui-wingeneral.h: Include gdb_curses.h.
14767
14768 2019-01-22  Tom Tromey  <tom@tromey.com>
14769
14770         * source-cache.h (class source_cache) <get_source_lines,
14771         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14772
14773 2019-01-22  Tom Tromey  <tom@tromey.com>
14774
14775         * remote-fileio.h (struct remote_target): Declare.
14776
14777 2019-01-22  Tom Tromey  <tom@tromey.com>
14778
14779         * python/py-arch.c: Do not include py-ref.h.
14780         * python/py-bpevent.c: Do not include py-ref.h.
14781         * python/py-cmd.c: Do not include py-ref.h.
14782         * python/py-continueevent.c: Do not include py-ref.h.
14783         * python/py-event.h: Do not include py-ref.h.
14784         * python/py-evtregistry.c: Do not include py-ref.h.
14785         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14786         * python/py-frame.c: Do not include py-ref.h.
14787         * python/py-framefilter.c: Do not include py-ref.h.
14788         * python/py-function.c: Do not include py-ref.h.
14789         * python/py-infevents.c: Do not include py-ref.h.
14790         * python/py-linetable.c: Do not include py-ref.h.
14791         * python/py-objfile.c: Do not include py-ref.h.
14792         * python/py-param.c: Do not include py-ref.h.
14793         * python/py-prettyprint.c: Do not include py-ref.h.
14794         * python/py-progspace.c: Do not include py-ref.h.
14795         * python/py-symbol.c: Do not include py-ref.h.
14796         * python/py-symtab.c: Do not include py-ref.h.
14797         * python/py-type.c: Do not include py-ref.h.
14798         * python/py-unwind.c: Do not include py-ref.h.
14799         * python/py-utils.c: Do not include py-ref.h.
14800         * python/py-value.c: Do not include py-ref.h.
14801         * python/py-varobj.c: Do not include py-ref.h.
14802         * python/py-xmethods.c: Do not include py-ref.h.
14803         * python/python.c: Do not include py-ref.h.
14804         * varobj.c: Do not include py-ref.h.
14805
14806 2019-01-22  Tom Tromey  <tom@tromey.com>
14807
14808         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14809         keyword for bcache.
14810
14811 2019-01-22  Tom Tromey  <tom@tromey.com>
14812
14813         * compile/compile-cplus-types.c: Remove a comment by #include.
14814
14815 2019-01-22  Tom Tromey  <tom@tromey.com>
14816
14817         * compile/gcc-c-plugin.h: Include compile-internal.h.
14818
14819 2019-01-22  Tom Tromey  <tom@tromey.com>
14820
14821         * stabsread.c (EXTERN): Do not define.
14822         (symnum, next_symbol_text_func, processing_gcc_compilation)
14823         (within_function, global_sym_chain, global_stabs)
14824         (previous_stab_code, this_object_header_files)
14825         (n_this_object_header_files)
14826         (n_allocated_this_object_header_files): Define.
14827         * stabsread.h (EXTERN): Never define.  Use "extern".
14828
14829 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14830
14831         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14832         history_value.
14833
14834 2019-01-21  Tom Tromey  <tom@tromey.com>
14835
14836         * ui-out.c: Fix includes.
14837         * tui/tui-source.c: Fix includes.
14838         * target.c: Fix includes.
14839         * remote.c: Fix includes.
14840         * regcache.c: Fix includes.
14841         * python/py-block.c: Fix includes.
14842         * printcmd.c: Fix includes.
14843         * or1k-tdep.c: Fix includes.
14844         * mi/mi-main.c: Fix includes.
14845         * m32r-tdep.c: Fix includes.
14846         * csky-tdep.c: Fix includes.
14847         * compile/compile-cplus-types.c: Fix includes.
14848         * cli/cli-interp.c: Fix includes.
14849
14850 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14851
14852         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14853         for padding.
14854
14855 2019-01-16  Tom Tromey  <tom@tromey.com>
14856
14857         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14858         earlier.
14859         (struct objfile) <msymbols_range>: Move from top level.
14860         <msymbols>: New method.
14861         (class objfile_msymbols): Remove.
14862         * symtab.c (default_collect_symbol_completion_matches_break_on):
14863         Update.
14864         * symmisc.c (dump_msymbols): Update.
14865         * stabsread.c (scan_file_globals): Update.
14866         * objc-lang.c (info_selectors_command, info_classes_command)
14867         (find_methods): Update.
14868         * minsyms.c (find_solib_trampoline_target): Update.
14869         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14870         * coffread.c (coff_symfile_read): Update.
14871         * ada-lang.c (ada_lookup_simple_minsym)
14872         (ada_collect_symbol_completion_matches): Update.
14873
14874 2019-01-16  Tom Tromey  <tom@tromey.com>
14875
14876         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14877         type.  Remove no-argument constructor.
14878         <iterator::operator++>: Simplify.
14879         <begin>: Update.
14880         <end>: Use minimal_symbol_count.
14881
14882 2019-01-16  Tom Tromey  <tom@tromey.com>
14883
14884         * objfiles.h (struct objfile) <psymtabs>: New method.
14885         (class objfile_psymtabs): Remove.
14886         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14887         typedef.
14888         <range>: New method.
14889         (require_partial_symbols): Change return type.
14890         * psymtab.c (require_partial_symbols)
14891         (psym_expand_symtabs_matching): Update.
14892         * mdebugread.c (parse_partial_symbols): Update.
14893         * dbxread.c (dbx_end_psymtab): Update.
14894
14895 2019-01-15  Tom Tromey  <tom@tromey.com>
14896
14897         * symtab.c (lookup_objfile_from_block)
14898         (lookup_symbol_in_objfile_symtabs)
14899         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14900         (find_line_symtab, info_sources_command)
14901         (default_collect_symbol_completion_matches_break_on)
14902         (make_source_files_completion_list): Update.
14903         * symmisc.c (print_objfile_statistics, dump_objfile)
14904         (maintenance_print_symbols, maintenance_info_symtabs)
14905         (maintenance_check_symtabs, maintenance_info_line_tables):
14906         Update.
14907         * source.c (select_source_symtab)
14908         (forget_cached_source_info_for_objfile): Update.
14909         * objfiles.h (class objfile_compunits): Remove.
14910         (struct objfile) <compunits_range>: New typedef.
14911         (compunits): New method.
14912         * objfiles.c (objfile_relocate1): Update.
14913         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14914         * maint.c (count_symtabs_and_blocks): Update.
14915         * linespec.c (iterate_over_all_matching_symtabs): Update.
14916         * cp-support.c (add_symbol_overload_list_qualified): Update.
14917         * coffread.c (coff_symtab_read): Update.
14918         * ada-lang.c (add_nonlocal_symbols)
14919         (ada_collect_symbol_completion_matches)
14920         (ada_add_global_exceptions): Update.
14921
14922 2019-01-15  Tom Tromey  <tom@tromey.com>
14923
14924         * progspace.h (program_space) <objfiles_safe_range>: New
14925         typedef.
14926         <objfiles_safe>: New method.
14927         * objfiles.h (class all_objfiles_safe): Remove.
14928         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14929         * jit.c (jit_inferior_exit_hook): Update.
14930
14931 2019-01-17  Tom Tromey  <tom@tromey.com>
14932
14933         * progspace.h (program_space) <objfiles_range>: New typedef.
14934         <objfiles>: New method.
14935         <objfiles_head>: Rename from objfiles.
14936         (object_files): Update.
14937         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14938         * guile/scm-pretty-print.c
14939         (ppscm_find_pretty_printer_from_objfiles): Update.
14940         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14941         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14942         Update.
14943         * python/py-progspace.c (pspy_get_objfiles): Update.
14944         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14945         Update.
14946         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14947         (objfpy_lookup_objfile_by_build_id): Update.
14948         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14949         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14950         Update.
14951         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14952         (expand_symtab_containing_pc, lookup_objfile_from_block)
14953         (lookup_static_symbol, basic_lookup_transparent_type)
14954         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14955         (find_line_symtab, info_sources_command)
14956         (default_collect_symbol_completion_matches_break_on)
14957         (make_source_files_completion_list, find_main_name): Update.
14958         * symmisc.c (print_symbol_bcache_statistics)
14959         (print_objfile_statistics, maintenance_print_symbols)
14960         (maintenance_print_msymbols, maintenance_print_objfiles)
14961         (maintenance_info_symtabs, maintenance_check_symtabs)
14962         (maintenance_expand_symtabs, maintenance_info_line_tables):
14963         Update.
14964         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14965         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14966         (map_overlay_command, unmap_overlay_command)
14967         (simple_overlay_update, expand_symtabs_matching)
14968         (map_symbol_filenames): Update.
14969         * symfile-debug.c (set_debug_symfile): Update.
14970         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14971         Update.
14972         * source.c (select_source_symtab, forget_cached_source_info):
14973         Update.
14974         * solib.c (solib_read_symbols): Update.
14975         * solib-spu.c (append_ocl_sos): Update.
14976         * psymtab.c (maintenance_print_psymbols)
14977         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14978         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14979         * printcmd.c (info_symbol_command): Update.
14980         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14981         Update.
14982         * objfiles.h (class all_objfiles): Remove.
14983         * objfiles.c (have_partial_symbols, have_full_symbols)
14984         (have_minimal_symbols, qsort_cmp, update_section_map)
14985         (shared_objfile_contains_address_p)
14986         (default_iterate_over_objfiles_in_search_order): Update.
14987         * objc-lang.c (info_selectors_command, info_classes_command)
14988         (find_methods): Update.
14989         * minsyms.c (find_solib_trampoline_target): Update.
14990         * maint.c (maintenance_info_sections)
14991         (maintenance_translate_address, count_symtabs_and_blocks):
14992         Update.
14993         * main.c (captured_main_1): Update.
14994         * linux-thread-db.c (try_thread_db_load_from_pdir)
14995         (has_libpthread): Update.
14996         * linespec.c (iterate_over_all_matching_symtabs)
14997         (search_minsyms_for_name): Update.
14998         * jit.c (jit_find_objf_with_entry_addr): Update.
14999         * hppa-tdep.c (find_unwind_entry)
15000         (hppa_lookup_stub_minimal_symbol): Update.
15001         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15002         Update.
15003         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15004         (elf_gnu_ifunc_resolve_by_got): Update.
15005         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15006         * dwarf-index-write.c (save_gdb_index_command): Update.
15007         * cp-support.c (add_symbol_overload_list_qualified): Update.
15008         * breakpoint.c (create_overlay_event_breakpoint)
15009         (create_longjmp_master_breakpoint)
15010         (create_std_terminate_master_breakpoint)
15011         (create_exception_master_breakpoint): Update.
15012         * blockframe.c (find_pc_partial_function): Update.
15013         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15014         (ada_collect_symbol_completion_matches)
15015         (ada_add_global_exceptions): Update.
15016
15017 2019-01-17  Tom Tromey  <tom@tromey.com>
15018
15019         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15020         declare VEC.
15021         (solib_target_parse_libraries): Change return type.
15022         (library_list_start_segment, library_list_start_section)
15023         (library_list_end_library, library_list_start_library); Update.
15024         (solib_target_free_library_list): Remove.
15025         (solib_target_parse_libraries): Remove cleanup.  Change return
15026         type.
15027         (solib_target_current_sos): Update.
15028
15029 2019-01-17  Tom Tromey  <tromey@bapiya>
15030
15031         * valprint.c: Replace "the the" with "the".
15032         * symtab.c: Replace "the the" with "the".
15033         * solib.c: Replace "the the" with "the".
15034         * solib-dsbt.c: Replace "the the" with "the".
15035         * linespec.c: Replace "the the" with "the".
15036         * dwarf2loc.h: Replace "the the" with "the".
15037         * amd64-windows-tdep.c: Replace "the the" with "the".
15038         * aarch64-tdep.c: Replace "the the" with "the".
15039
15040 2019-01-16  Keith Seitz  <keiths@redhat.com>
15041
15042         PR gdb/23773
15043         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15044         <builder>: Rename to ..
15045         <m_builder>: ... this and make private.
15046         (dwarf2_cu::get_builder): New method.  Change all users of
15047         `builder' to use this method.
15048         (dwarf2_start_symtab): Move to ...
15049         (dwarf2_cu::start_symtab): ... here.  Update all callers
15050         (setup_type_unit_groups): Move to ...
15051         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15052         callers.
15053         (dwarf2_cu::reset_builder): New method.
15054         (process_full_compunit, process_full_type_unit): Use
15055         dwarf2_cu::reset_builder.
15056         (follow_die_offset): Record the ancestor CU if it is different
15057         from the followed DIE's CU.
15058         (follow_die_sig_1): Likewise.
15059
15060 2019-01-15  Tom Tromey  <tom@tromey.com>
15061
15062         * remote.c (class remote_state) <buf>: Now a char_vector.
15063         <buf_size>: Remove.
15064         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15065         parameter.
15066         (remote_target::getpkt_or_notif_sane_1)
15067         (remote_target::getpkt_sane)
15068         (remote_target::getpkt_or_notif_sane): Likewise.
15069         (class remote_target) <putpkt>: New overload.
15070         (remote_target::read_frame): Change type of "buf_p".  Remove
15071         sizeof_p parameter.
15072         (packet_ok): New overload.
15073         (packet_check_result): New overload.
15074         Update all uses.
15075
15076 2019-01-14  Tom Tromey  <tom@tromey.com>
15077
15078         * remote-notif.c (handle_notification, remote_notif_ack)
15079         (remote_notif_parse): Make "buf" const.
15080         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15081         const.
15082         (remote_notif_parse, remote_notif_ack, handle_notification):
15083         Likewise.
15084         * remote.c (remote_notif_stop_parse): Make "buf" const.
15085         (remote_target::remote_parse_stop_reply): Make "buf" const.
15086         (remote_notif_stop_ack): Make "buf" const.
15087
15088 2019-01-14  Tom Tromey  <tom@tromey.com>
15089
15090         * remote.c (remote_console_output): Make parameter const.
15091
15092 2019-01-14  Tom Tromey  <tom@tromey.com>
15093
15094         * target-debug.h (target_debug_print_signals): Constify.
15095         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15096         * procfs.c (procfs_target::pass_signals): Update.
15097         * linux-nat.c (linux_nat_target::pass_signals): Update.
15098         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15099         * target-delegates.c: Rebuild.
15100         * remote.c (remote_target::program_signals): Update.
15101         (remote_target::pass_signals): Update.
15102         * target.c (target_pass_signals): Constify argument.
15103         (target_program_signals): Likewise.
15104         * target.h (struct target_ops) <pass_signals, program_signals>:
15105         Constify argument.
15106         (target_pass_signals, target_program_signals): Constify argument.
15107
15108 2019-01-14  Tom Tromey  <tom@tromey.com>
15109
15110         PR tui/28819:
15111         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15112
15113 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15114
15115         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15116         field.
15117         * rs6000-tdep.c: Include reggroups.h.
15118         (IS_V_ALIAS_PSEUDOREG): Define.
15119         (rs6000_register_name): Return names for the "vX" aliases.
15120         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15121         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15122         aliases.  Call default_register_reggroup_p for all other
15123         pseudo-registers.
15124         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15125         New functions.
15126         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15127         Handle "vX" aliases.
15128         (v_alias_pseudo_register_collect): New function.
15129         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15130         (rs6000_gdbarch_init): Initialize "vX" aliases as
15131         pseudo-registers.  Restore registration of
15132         rs6000_pseudo_register_reggroup_p with
15133         set_tdesc_pseudo_register_reggroup_p.
15134
15135 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15136
15137         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15138         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15139         set_gdbarch_num_pseudo_regs.
15140
15141 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15142
15143         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15144         Remove arg prefixname, add do_set and do_show.
15145         Add member functions set_list and show_list.
15146         * cli/cli-style.c (class cli_style_option): Update accordingly.
15147         (style_set_list): Move to file scope.
15148         (style_show_list): Likewise.
15149         (set_style): Call help_list.
15150         (show_style): Call cmd_show_list.
15151         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15152         Update to use the new macro.
15153
15154 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15155
15156         * ada-lang.c (_initialize_ada_language): Expand the help text
15157         for the "catch exception" command.
15158
15159 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15160
15161         * symtab.c (matching_obj_sections): Initialize obj,
15162         declare it closer to its usage.
15163
15164 2019-01-10  Tom Tromey  <tom@tromey.com>
15165
15166         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15167         (basic_inf_threads_range): Remove.
15168         (inf_threads_range, inf_non_exited_threads_range)
15169         (safe_inf_threads_range): Use next_adapter.
15170
15171 2019-01-10  Keith Seitz  <keiths@redhat.com>
15172
15173         PR gdb/23712
15174         PR symtab/23010
15175         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15176         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15177
15178 2019-01-10  Keith Seitz  <keiths@redhat.com>
15179
15180         PR gdb/23712
15181         PR symtab/23010
15182         * dictionary.c (pending_to_vector): Remove.
15183         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15184         Remove _1 suffix, replacing functions of the same name.  Update
15185         all callers.
15186         (dict_create_hashed, dict_create_hashed_expandable)
15187         (dict_create_linear, dict_create_linear_expandable, dict_free)
15188         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15189         Make functions static.
15190
15191 2019-01-10  Keith Seitz  <keiths@redhat.com>
15192
15193         PR gdb/23712
15194         PR symtab/23010
15195         * dictionary.h (struct dictionary): Replace declaration with
15196         multidictionary.
15197         (dict_create_hashed, dict_create_hashed_expandable)
15198         (dict_create_linear, dict_create_linear_expandable)
15199         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15200         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15201         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15202         taking multidictionary argument.
15203         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15204         * block.h (struct block) <dict>: Change to multidictionary
15205         and rename `multidict'.
15206         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15207         symmisc.c: Update all dictionary references to multidictionary.
15208
15209 2019-01-10  Keith Seitz  <keiths@redhat.com>
15210
15211         PR gdb/23712
15212         PR symtab/23010
15213         * dictionary.c: Include unordered_map.
15214         (pending_to_vector): New function.
15215         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15216         Rewrite the non-"_1" functions to take vector instead
15217         of linked list.
15218         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15219         "new" _1 versions of the same name.
15220         (multidictionary): Define.
15221         (std::hash<enum language): New definition.
15222         (collate_pending_symbols_by_language, mdict_create_hashed)
15223         (mdict_create_hashed_expandable, mdict_create_linear)
15224         (mdict_create_linear_expandable, mdict_free)
15225         (find_language_dictionary, create_new_language_dictionary)
15226         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15227         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15228         (mdict_size, mdict_empty): New functions.
15229         * dictionary.h (mdict_iterator): Define.
15230
15231 2019-01-10  Pedro Alves  <palves@redhat.com>
15232
15233         * breakpoint.c (read_uploaded_action)
15234         (create_tracepoint_from_upload): Adjust to use
15235         gdb::unique_xmalloc_ptr.
15236         * ctf.c (ctf_write_uploaded_tp):
15237         (SET_ARRAY_FIELD): Use emplace_back.
15238         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15239         * tracefile-tfile.c (tfile_write_uploaded_tp):
15240         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15241         gdb::unique_xmalloc_ptr.
15242         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15243         at_string, cond_string, cmd_strings>: Replace char pointers
15244         with gdb::unique_xmalloc_ptr.
15245
15246 2019-01-10  Pedro Alves  <palves@redhat.com>
15247
15248         * solib-target.c (library_list_start_library): Don't xstrdup name.
15249
15250 2019-01-10  Pedro Alves  <palves@redhat.com>
15251
15252         * mdebugread.c (parse_partial_symbols): Use
15253         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15254
15255 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15256
15257         * linux-fork.c (scoped_switch_fork_info)
15258         <~scoped_switch_fork_info>: Fix incorrect variable name.
15259
15260 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15261
15262         * linux-fork.c (scoped_switch_fork_info)
15263         <scoped_switch_fork_info>: Make explicit.
15264         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15265
15266 2019-01-10  Tom Tromey  <tom@tromey.com>
15267
15268         * objfiles.h (objfile::reset_psymtabs): Update.
15269         * objfiles.c (objfile::objfile): Update.
15270         * psymtab.h (psymtab_storage::obstack): Update.
15271         (psymtab_storage::m_obstack): Use gdb::optional.
15272         (class psymtab_storage): Update comment.  Remove objfile
15273         parameter.
15274         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15275
15276 2019-01-10  Tom Tromey  <tom@tromey.com>
15277
15278         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15279         <free_psymtabs>: Now private.
15280         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15281         (allocate_psymtab): Use new method.
15282
15283 2019-01-10  Tom Tromey  <tom@tromey.com>
15284
15285         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15286         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15287         * mdebugread.c (parse_partial_symbols): Use
15288         allocate_dependencies.
15289         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15290         allocate_dependencies.
15291         (process_psymtab_comp_unit_reader)
15292         (build_type_psymtab_dependencies): Likewise.
15293         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15294
15295 2019-01-10  Tom Tromey  <tom@tromey.com>
15296
15297         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15298         PSYMBOL_SET_LANGUAGE.
15299         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15300
15301 2019-01-10  Tom Tromey  <tom@tromey.com>
15302
15303         * psymtab.h (psymtab_storage::obstack): New method.
15304         <m_obstack>: Rename from obstack; now private.
15305         * psymtab.c (psymtab_storage): Update.
15306         * dwarf2read.c (create_addrmap_from_index)
15307         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15308         Update.
15309
15310 2019-01-10  Tom Tromey  <tom@tromey.com>
15311
15312         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15313         * objfiles.h (objfile::reset_psymtabs): New method.
15314
15315 2019-01-10  Tom Tromey  <tom@tromey.com>
15316
15317         * symmisc.c (print_symbol_bcache_statistics): Update.
15318         (print_objfile_statistics): Update.
15319         * symfile.c (reread_symbols): Update.
15320         * psymtab.h (class psymtab_storage): New.
15321         * psymtab.c (psymtab_storage): New constructor.
15322         (~psymtab_storage): New destructor.
15323         (require_partial_symbols): Update.
15324         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15325         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15326         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15327         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15328         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15329         (start_psymtab_common, end_psymtab_common)
15330         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15331         (allocate_psymtab): Update.
15332         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15333         Update.
15334         (dump_psymtab_addrmap, maintenance_print_psymbols)
15335         (maintenance_check_psymtabs): Update.
15336         (class objfile_psymtabs): Move to objfiles.h.
15337         * psympriv.h (discard_psymtab): Now inline.
15338         (psymtab_discarder::psymtab_discarder): Update.
15339         (psymtab_discarder::~psymtab_discarder): Update.
15340         (ALL_OBJFILE_PSYMTABS): Rewrite.
15341         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15342         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15343         Remove fields.
15344         <partial_symtabs>: New field.
15345         (class objfile_psymtabs): Move from psymtab.h.  Update.
15346         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15347         psymbol_cache.
15348         (objfile::~objfile): Don't destroy psymbol_cache.
15349         * mdebugread.c (parse_partial_symbols): Update.
15350         * dwarf2read.c (create_addrmap_from_index)
15351         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15352         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15353         (add_partial_subprogram, dwarf2_ranges_read): Update.
15354         * dwarf-index-write.c (write_address_map)
15355         (write_one_signatured_type, recursively_write_psymbols)
15356         (class debug_names, class debug_names, write_psymtabs_to_index):
15357         Update.
15358
15359 2019-01-10  Tom Tromey  <tom@tromey.com>
15360
15361         * symtab.h (SYMBOL_SET_NAMES): Update.
15362         (symbol_set_names): Update.
15363         (MSYMBOL_SET_NAMES): Update.
15364         * symtab.c (symbol_set_names): Change argument to be an
15365         objfile_per_bfd_storage.
15366         * psymtab.c (add_psymbol_to_bcache): Update.
15367         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15368
15369 2019-01-10  Tom Tromey  <tom@tromey.com>
15370
15371         * symtab.c (create_demangled_names_hash): Change argument to be an
15372         objfile_per_bfd_storage.
15373         (symbol_set_names): Update.
15374
15375 2019-01-10  Tom Tromey  <tom@tromey.com>
15376
15377         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15378         init_psymbol_list.
15379         * psymtab.c (init_psymbol_list): Do nothing if already called.
15380         * psympriv.h (init_psymbol_list): Add comment.
15381         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15382         init_psymbol_list.
15383         * dbxread.c (dbx_symfile_read): Unconditionally call
15384         init_psymbol_list.
15385
15386 2019-01-10  Tom Tromey  <tom@tromey.com>
15387
15388         * xcoffread.c (scan_xcoff_symtab): Update.
15389         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15390         "where".
15391         * mdebugread.c (parse_partial_symbols)
15392         (handle_psymbol_enumerators): Update.
15393         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15394         * dbxread.c (read_dbx_symtab): Update.
15395         * psympriv.h (psymbol_placement): New enum.
15396         (add_psymbol_to_list): Update.
15397
15398 2019-01-10  Tom Tromey  <tom@tromey.com>
15399
15400         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15401         static_psymbols parameters.
15402         (scan_xcoff_symtab): Update.
15403         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15404         static_psymbols parameters.
15405         * psympriv.h (start_psymtab_common): Update.
15406         * mdebugread.c (parse_partial_symbols): Update.
15407         * dwarf2read.c (create_partial_symtab): Update.
15408         * dbxread.c (read_dbx_symtab): Update.
15409         (start_psymtab): Remove global_psymbols and static_psymbols
15410         parameters.
15411
15412 2019-01-10  Tom Tromey  <tom@tromey.com>
15413
15414         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15415         * psymtab.c (allocate_psymtab): Add comment.
15416         * psympriv.h (allocate_psymtab): Add comment.
15417         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15418         initializations.
15419         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15420
15421 2019-01-10  Tom Tromey  <tom@tromey.com>
15422
15423         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15424         Don't declare.
15425         * mipsread.c: Include mdebugread.h.
15426         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15427         Declare.
15428         * elfread.c: Include mdebugread.h.
15429
15430 2019-01-09  Tom Tromey  <tom@tromey.com>
15431
15432         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15433         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15434         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15435         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15436         (psym_lookup_symbol, psym_find_last_source_symtab)
15437         (psym_forget_cached_source_info, psym_print_stats)
15438         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15439         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15440         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15441         (psym_find_compunit_symtab_by_address)
15442         (maintenance_print_psymbols, maintenance_info_psymtabs)
15443         (maintenance_check_psymtabs): Use ranged for.
15444         * psymtab.h (class objfile_psymtabs): New.
15445         (require_partial_symbols): Return objfile_psymtabs.
15446         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15447
15448 2019-01-09  Tom Tromey  <tom@tromey.com>
15449
15450         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15451         (find_pc_mapped_section, list_overlays_command)
15452         (map_overlay_command, unmap_overlay_command)
15453         (simple_overlay_update): Use all_objfiles.
15454         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15455         * printcmd.c (info_symbol_command): Use all_objfiles.
15456         * objfiles.h (ALL_OBJSECTIONS): Remove.
15457         * maint.c (maintenance_translate_address): Use all_objfiles.
15458         * gcore.c (gcore_create_callback): Use all_objfiles.
15459         (objfile_find_memory_regions): Likewise.
15460
15461 2019-01-09  Tom Tromey  <tom@tromey.com>
15462
15463         * symtab.c (find_line_symtab, info_sources_command)
15464         (make_source_files_completion_list): Use objfile_compunits.
15465         * source.c (select_source_symtab): Use objfile_compunits.
15466         * objfiles.h (struct objfile): Update comment.
15467         (ALL_OBJFILES): Remove.
15468         (ALL_FILETABS): Remove.
15469         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15470         objfile_compunits.
15471
15472 2019-01-09  Tom Tromey  <tom@tromey.com>
15473
15474         * symmisc.c (print_objfile_statistics, dump_objfile)
15475         (maintenance_print_symbols): Use compunit_filetabs.
15476         * source.c (forget_cached_source_info_for_objfile): Use
15477         compunit_filetabs.
15478         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15479         (ALL_FILETABS): Use compunit_filetabs.
15480         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15481         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15482
15483 2019-01-09  Tom Tromey  <tom@tromey.com>
15484
15485         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15486         (compunit_filetabs): New.
15487         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15488         compunit_filetabs.
15489         (info_sources_command, make_source_files_completion_list): Remove
15490         declaration.
15491         * symmisc.c (print_objfile_statistics, dump_objfile)
15492         (maintenance_print_symbols): Remove declaration.
15493         (maintenance_info_symtabs): Use compunit_filetabs.
15494         (maintenance_info_line_tables): Likewise.
15495         * source.c (select_source_symtab): Change local variable name.
15496         (forget_cached_source_info_for_objfile): Remove declaration.
15497         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15498         * objfiles.c (objfile_relocate1): Remove declaration.
15499         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15500         declaration.
15501         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15502         * coffread.c (coff_symtab_read): Remove declaration.
15503         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15504         compunit_filetabs.
15505
15506 2019-01-09  Tom Tromey  <tom@tromey.com>
15507
15508         * symtab.c (lookup_objfile_from_block)
15509         (find_pc_sect_compunit_symtab, search_symbols)
15510         (default_collect_symbol_completion_matches_break_on): Use
15511         objfile_compunits.
15512         * objfiles.h (ALL_COMPUNITS): Remove.
15513         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15514         * cp-support.c (add_symbol_overload_list_qualified): Use
15515         objfile_compunits.
15516         * ada-lang.c (ada_collect_symbol_completion_matches)
15517         (ada_add_global_exceptions): Use objfile_compunits.
15518
15519 2019-01-09  Tom Tromey  <tom@tromey.com>
15520
15521         * source.c (select_source_symtab)
15522         (forget_cached_source_info_for_objfile): Remove declaration.
15523         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15524         declaration.
15525         * maint.c (count_symtabs_and_blocks): Remove declaration.
15526         * cp-support.c (add_symbol_overload_list_qualified): Remove
15527         declaration.
15528         * coffread.c (coff_symtab_read): Remove declaration.
15529         * symtab.c (lookup_symbol_in_objfile_symtabs)
15530         (basic_lookup_transparent_type_1): Use objfile_compunits.
15531         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15532         (info_sources_command, search_symbols)
15533         (default_collect_symbol_completion_matches_break_on)
15534         (make_source_files_completion_list): Remove declaration.
15535         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15536         (ada_collect_symbol_completion_matches)
15537         (ada_add_global_exceptions): Remove declaration.
15538         * linespec.c (iterate_over_all_matching_symtabs): Use
15539         objfile_compunits.
15540         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15541         (class objfile_compunits): New.
15542         (ALL_COMPUNITS): Use objfile_compunits.
15543         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15544         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15545         objfile_compunits.
15546         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15547
15548 2019-01-09  Tom Tromey  <tom@tromey.com>
15549
15550         * symtab.c (search_symbols)
15551         (default_collect_symbol_completion_matches_break_on): Use
15552         objfile_msymbols.
15553         * ada-lang.c (ada_lookup_simple_minsym)
15554         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15555         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15556         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15557         objfile_msymbols.
15558         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15559         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15560         * objc-lang.c (find_methods): Use objfile_msymbols.
15561         (info_selectors_command, info_classes_command): Likewise.
15562         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15563         * objfiles.h (class objfile_msymbols): New.
15564         (ALL_OBJFILE_MSYMBOLS): Remove.
15565         (ALL_MSYMBOLS): Remove.
15566
15567 2019-01-09  Tom Tromey  <tom@tromey.com>
15568
15569         * common/next-iterator.h (next_adapter): Add Iterator template
15570         parameter.
15571         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15572         (class all_objfiles_safe): New.
15573         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15574         * objfiles.c (put_objfile_before): Update comment.
15575         (add_separate_debug_objfile): Likewise.
15576         (free_all_objfiles): Use all_objfiles_safe.
15577         (objfile_purge_solibs): Likewise.
15578
15579 2019-01-09  Tom Tromey  <tom@tromey.com>
15580
15581         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15582         (expand_symtab_containing_pc, lookup_static_symbol)
15583         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15584         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15585         all_objfiles.
15586         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15587         * breakpoint.c (create_overlay_event_breakpoint)
15588         (create_longjmp_master_breakpoint)
15589         (create_std_terminate_master_breakpoint)
15590         (create_exception_master_breakpoint): Use all_objfiles.
15591         * linux-thread-db.c (try_thread_db_load_from_pdir)
15592         (has_libpthread): Use all_objfiles.
15593         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15594         * linespec.c (iterate_over_all_matching_symtabs)
15595         (search_minsyms_for_name): Use all_objfiles.
15596         * maint.c (maintenance_info_sections): Use all_objfiles.
15597         * main.c (captured_main_1): Use all_objfiles.
15598         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15599         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15600         * guile/scm-pretty-print.c
15601         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15602         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15603         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15604         (maintenance_print_msymbols): Use all_objfiles.
15605         * source.c (select_source_symtab): Use all_objfiles.
15606         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15607         * symfile.c (remove_symbol_file_command)
15608         (expand_symtabs_matching, map_symbol_filenames): Use
15609         all_objfiles.
15610         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15611         all_objfiles.
15612         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15613         * objc-lang.c (find_methods): Use all_objfiles.
15614         * objfiles.c (have_partial_symbols, have_full_symbols)
15615         (have_minimal_symbols, qsort_cmp)
15616         (default_iterate_over_objfiles_in_search_order): Use
15617         all_objfiles.
15618         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15619         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15620         (maintenance_check_psymtabs): Use all_objfiles.
15621         (ALL_PSYMTABS): Remove.
15622         * compile/compile-object-run.c (do_module_cleanup): Use
15623         all_objfiles.
15624         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15625         * cp-support.c (add_symbol_overload_list_qualified): Use
15626         all_objfiles.
15627         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15628         Use all_objfiles.
15629         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15630         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15631         all_objfiles.
15632         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15633         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15634         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15635         Uses all_objfiles.
15636         * solib.c (solib_read_symbols): Use all_objfiles
15637
15638 2019-01-09  Tom Tromey  <tom@tromey.com>
15639
15640         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15641         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15642         all_objfiles.
15643         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15644         * symmisc.c (print_symbol_bcache_statistics)
15645         (print_objfile_statistics, maintenance_print_objfiles)
15646         (maintenance_info_symtabs, maintenance_check_symtabs)
15647         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15648         all_objfiles.
15649         * source.c (forget_cached_source_info): Use all_objfiles.
15650         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15651         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15652         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15653         * objfiles.c (update_section_map): Use all_objfiles.
15654         (shared_objfile_contains_address_p): Likewise.
15655         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15656         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15657
15658 2019-01-09  Tom Tromey  <tom@tromey.com>
15659
15660         * common/next-iterator.h: New file.
15661         * objfiles.h (class all_objfiles): New.
15662         (struct objfile_iterator): New.
15663
15664 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15665
15666         * NEWS: Move the description of the changed "frame", "select-frame",
15667          and "info frame" commands to the Changed commands section.
15668
15669 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15670
15671         * gdbtypes.c (check_stub_method_group): Remove handling of old
15672         mangling schemes.
15673         * linespec.c (find_methods): Likewise.
15674         * stabsread.c (read_member_functions): Likewise.
15675         * valops.c (search_struct_method): Likewise.
15676         (value_struct_elt_for_reference): Likewise.
15677         * NEWS: Mention this change.
15678
15679 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15680
15681         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15682         print_source_lines.
15683         * source.c (print_source_lines_base): Update line number check.
15684         (print_source_lines): New function.
15685         (source_lines_range::source_lines_range): New function.
15686         * source.h (class source_lines_range): New class.
15687         (print_source_lines): New declaration.
15688
15689 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15690
15691         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15692
15693 2019-01-08  Tom Tromey  <tom@tromey.com>
15694             Simon Marchi  <simon.marchi@ericsson.com>
15695
15696         PR gdb/24060
15697         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15698         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15699         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15700         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15701         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15702         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15703
15704 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15705
15706         * source.c (select_source_symtab): Move header comment to
15707         declaration in source.h.
15708         (forget_cached_source_info_for_objfile): Likewise.
15709         (forget_cached_source_info): Likewise.
15710         (identify_source_line): Likewise.
15711         * source.h (identify_source_line): Move declaration from symtab.h
15712         and add comment from source.c
15713         (print_source_lines): Likewise.
15714         (forget_cached_source_info_for_objfile): Likewise.
15715         (forget_cached_source_info): Likewise.
15716         (select_source_symtab): Likewise.
15717         (enum print_source_lines_flag): Move definition from symtab.h.
15718         * symtab.h (identify_source_line): Move declaration to source.h.
15719         (print_source_lines): Likewise.
15720         (forget_cached_source_info_for_objfile): Likewise.
15721         (forget_cached_source_info): Likewise.
15722         (select_source_symtab): Likewise.
15723         (enum print_source_lines_flag): Move definition to source.h.
15724         * tui/tui-hooks.c: Add 'source.h' include.
15725
15726 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15727
15728         * source.c (print_source_lines_base): Handle requests to print
15729         reverse line number sequences, and guard against empty lines
15730         string.
15731
15732 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15733
15734         * source.c (print_source_lines_base): Fix skip of '\r' if next
15735         character is '\n'.
15736
15737 2019-01-06  Tom Tromey  <tom@tromey.com>
15738
15739         * c-exp.y (struct c_parse_state) <macro_original_text,
15740         expansion_obstack>: New member.
15741         (macro_original_text, expansion_obstack): Remove globals.
15742         (scan_macro_expansion, scanning_macro_expansion)
15743         (finished_macro_expansion): Update.
15744         (scan_macro_cleanup): Remove.
15745         (yylex, c_parse): Update.
15746
15747 2019-01-06  Tom Tromey  <tom@tromey.com>
15748
15749         * c-exp.y (struct c_parse_state) <strings>: New member.
15750         (operator_stoken): Update.
15751
15752 2019-01-06  Tom Tromey  <tom@tromey.com>
15753
15754         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15755         (union type_stack_elt) <typelist_val>: Now a pointer to
15756         std::vector.
15757         (type_stack_cleanup): Don't declare.
15758         (push_typelist): Update.
15759         * parse.c (pop_typelist): Return a std::vector.
15760         (push_typelist): Take a std::vector.
15761         (follow_types): Update.  Do not free args.
15762         (type_stack_cleanup): Remove.
15763         * c-exp.y (struct c_parse_state): New.
15764         (cpstate): New global.
15765         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15766         (nonempty_typelist): Update.
15767         (func_mod): Create a new vector.
15768         (c_parse): Create a c_parse_state.
15769         (check_parameter_typelist): Do not delete params.
15770         (function_method): Update.  Do not delete type_list.
15771
15772 2019-01-06  Tom Tromey  <tom@tromey.com>
15773
15774         PR gdb/28155:
15775         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15776         check_typedef.
15777         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15778         (print_return_value): Likewise.
15779
15780 2019-01-05  Tom Tromey  <tom@tromey.com>
15781
15782         * contrib/cleanup_check.py: Remove.
15783         * contrib/gcc-with-excheck: Remove.
15784         * contrib/exsummary.py: Remove.
15785         * contrib/excheck.py: Remove.
15786
15787 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15788
15789         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15790         NULL. Initialize tpprev to NULL instead of assigning it
15791         to NULL on the next statement.
15792         * windows-nat.c (windows_delete_thread): Remove check for
15793         main_thread_id before printing thread exit notifications.
15794         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15795         Remove thread ID check against main_thread_id.
15796         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15797         windows_delete_thread.
15798         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15799
15800 2019-01-04  Tom Tromey  <tom@tromey.com>
15801
15802         * compile/compile.c (_initialize_compile): Use upper case for
15803         metasyntactic variables.
15804         * symmisc.c (_initialize_symmisc): Use upper case for
15805         metasyntactic variables.
15806         * psymtab.c (_initialize_psymtab): Use upper case for
15807         metasyntactic variables.
15808         * demangle.c (demangle_command): Use upper case for metasyntactic
15809         variables.
15810         (_initialize_demangler): Likewise.
15811         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15812         variables.
15813
15814 2019-01-03  Tom Tromey  <tom@tromey.com>
15815
15816         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15817
15818 2019-01-03  Tom Tromey  <tom@tromey.com>
15819
15820         * python/py-symtab.c (salpy_str): Update.
15821         (struct salpy_sal_object) <symtab>: Now a PyObject.
15822         (salpy_dealloc): Update.
15823         (del_objfile_sal): Use gdbpy_ref.
15824
15825 2019-01-03  Tom Tromey  <tom@tromey.com>
15826
15827         * python/py-type.c (convert_field): Use new_reference.  Return
15828         gdbpy_ref.
15829         (make_fielditem): Return gdbpy_ref.
15830         (typy_fields): Update.
15831         (typy_getitem): Update.
15832         (field_name): Return gdbpy_ref.  Use new_reference.
15833         (typy_iterator_iternext): Update.
15834
15835 2019-01-03  Tom Tromey  <tom@tromey.com>
15836
15837         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15838
15839 2019-01-03  Tom Tromey  <tom@tromey.com>
15840
15841         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15842         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15843         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15844         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15845         (pspy_set_type_printers): Likewise.
15846         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15847         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15848         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15849         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15850         (objfpy_set_type_printers): Likewise.
15851
15852 2019-01-03  Tom Tromey  <tom@tromey.com>
15853
15854         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15855         (gdbpy_print_stack): Use gdbpy_err_fetch.
15856         * python/python-internal.h (class gdbpy_err_fetch): New class.
15857         (class gdbpy_enter) <m_error_type, m_error_value,
15858         m_error_traceback>: Remove.
15859         <m_error>: New member.
15860         (gdbpy_exception_to_string): Don't declare.
15861         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15862         * python/py-value.c (convert_value_from_python): Use
15863         gdbpy_err_fetch.
15864         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15865         gdbpy_exception_to_string.
15866         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15867         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15868         gdbpy_err_fetch.
15869
15870 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15871
15872         * linux-nat.c (delete_lwp_cleanup): Delete.
15873         (struct lwp_deleter): New struct.
15874         (lwp_info_up): New typedef.
15875         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15876         lwp_info_up.
15877
15878 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15879
15880         * linux-fork.c (class scoped_switch_fork_info): New class.
15881         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15882
15883 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15884
15885         * valops.c (find_overload_match): Remove use of null_cleanup, and
15886         calls to do_cleanups.
15887
15888 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15889
15890         * compile/compile-cplus-types.c
15891         (compile_cplus_instance::decl_name): Handle changes to
15892         cp_func_name.
15893         * cp-support.c (cp_func_name): Update header comment, update
15894         return type.
15895         * cp-support.h (cp_func_name): Update return type in declaration.
15896         * valops.c (find_overload_match): Move temp_func local to top
15897         level of function and change its type.  Use temp_func to hold and
15898         delete temporary string obtained from cp_func_name.
15899
15900 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15901
15902         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15903         gdb::char_vector, remove cleanup, and update uses of `msg`.
15904
15905 2019-01-03  Jim Wilson  <jimw@sifive.com>
15906
15907         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15908
15909 2019-01-02  Tom Tromey  <tom@tromey.com>
15910
15911         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15912         (tdesc_parse_xml): Remove cleanups.
15913         * target-descriptions.h (make_cleanup_free_target_description):
15914         Don't declare.
15915         (target_desc_deleter): New struct.
15916         (target_desc_up): New typedef.
15917         * target-descriptions.c (target_desc_deleter::operator()): Rename
15918         from free_target_description.
15919         (make_cleanup_free_target_description): Remove.
15920
15921 2019-01-02  Tom Tromey  <tom@tromey.com>
15922
15923         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15924         constructor, destructor.
15925         (linespec_parser): Remove typedef.
15926         (~linespec_parser): Rename from linespec_parser_delete.
15927         (linespec_lex_to_end, linespec_complete_label)
15928         (linespec_complete): Update.
15929         (decode_line_full): Remove cleanups.
15930         (decode_line_1): Update.
15931
15932 2019-01-02  Tom Tromey  <tom@tromey.com>
15933
15934         * python/python-internal.h (inferior_to_inferior_object): Change
15935         return type.
15936         * python/py-exitedevent.c (create_exited_event_object): Update.
15937         * python/py-inferior.c (inferior_to_inferior_object): Return
15938         gdbpy_ref.
15939         (python_new_inferior, python_inferior_deleted)
15940         (thread_to_thread_object, delete_thread_object)
15941         (build_inferior_list, gdbpy_selected_inferior): Update.
15942         * python/py-infthread.c (create_thread_object): Update.  Also fail
15943         if inferior_to_inferior_object fails.
15944
15945 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15946
15947         * inferior.h (class inferior) <displaced_step_state>: New field.
15948         * infrun.h (struct displaced_step_state): Move here from
15949         infrun.c.  Initialize fields, add constructor.
15950         <inf>: Remove field.
15951         <reset>: New method.
15952         * infrun.c (struct displaced_step_inferior_state): Move to
15953         infrun.h.
15954         (displaced_step_inferior_states): Remove.
15955         (get_displaced_stepping_state): Adust.
15956         (displaced_step_in_progress_any_inferior): Adjust.
15957         (displaced_step_in_progress_thread): Adjust.
15958         (displaced_step_in_progress): Adjust.
15959         (add_displaced_stepping_state): Remove.
15960         (get_displaced_step_closure_by_addr): Adjust.
15961         (remove_displaced_stepping_state): Remove.
15962         (infrun_inferior_exit): Call displaced_step_state.reset.
15963         (use_displaced_stepping): Don't check for NULL.
15964         (displaced_step_prepare_throw): Call
15965         get_displaced_stepping_state.
15966         (displaced_step_fixup): Don't check for NULL.
15967         (prepare_for_detach): Don't check for NULL.
15968
15969 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15970
15971         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15972          in case of call that did not complete.
15973
15974 2019-01-02  Andrey Utkin  <autkin@undo.io>
15975
15976         * symfile.c (find_separate_debug_file): Fix search of debug files for
15977         remote debuggee.
15978
15979 2019-01-02  Tom Tromey  <tom@tromey.com>
15980
15981         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15982         indentation.
15983         * python/py-frame.c (frapy_older): Remove cast.
15984         (frapy_newer): Likewise.
15985         * python/py-breakpoint.c (local_setattro): Remove cast.
15986         * python/py-arch.c (archpy_name): Remove local variable.
15987         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15988
15989 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15990
15991         * unittests/basic_string_view/element_access/char/empty.cc:
15992         Fix year range in copyright header.
15993
15994 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15995
15996         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15997         Delete.
15998         <operator==>: Update with for removed field.
15999         <hash>: Likewise.
16000         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16001         <isa_features>: ...this.
16002         <abi_features>: New field.
16003         (riscv_isa_flen): Update comment.
16004         (riscv_abi_xlen): New declaration.
16005         (riscv_abi_flen): New declaration.
16006         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16007         isa_features.
16008         (riscv_abi_xlen): New function.
16009         (riscv_isa_flen): Update to get answer from isa_features.
16010         (riscv_abi_flen): New function.
16011         (riscv_has_fp_abi): Update to get answer from abi_features.
16012         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16013         xlen and flen.
16014         (riscv_call_info) <xlen, flen>: Update comment.
16015         (riscv_call_arg_struct): Remove invalid assertions
16016         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16017         is removed.
16018         (riscv_gdbarch_init): Gather isa features and abi features
16019         separately, ensure both match on the gdbarch when reusing an old
16020         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16021         a target with 64-bit float hardware.
16022
16023 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16024
16025         * source.c (search_command_helper): Stop reverse search
16026         when line 1 has been searched.
16027
16028 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16029
16030         * record-full.c (record_full_base_target::close): Rewrite
16031         record_full_core_buf_list free logic.
16032
16033 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16034
16035         * break-catch-syscall.c (print_one_catch_syscall): xfree
16036         the last text.
16037
16038 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16039
16040         * top.c (print_gdb_version): Update Copyright year in version
16041         message.
16042
16043 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16044
16045         Update copyright year range in all GDB files.
16046
16047 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16048
16049         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16050
16051 For older changes see ChangeLog-2018.
16052 \f
16053 Local Variables:
16054 mode: change-log
16055 left-margin: 8
16056 fill-column: 74
16057 version-control: never
16058 coding: utf-8
16059 End:
16060