gdb/ChangeLog

   1 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * windows-nat.c (main_thread_id): Delete.
   4         (handle_output_debug_string): Replace main_thread_id by
   5         current_event.dwThreadId.
   6         (fake_create_process): Likewise.
   7         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
   8         Do not set main_thread_id.
   9         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  10         current_event.dwThreadId.
  11         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  12
  13 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  14
  15         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  16         Use current_event.dwThreadId instead of main_thread_id.
  17
  18 2019-04-30  Tom Tromey  <tromey@adacore.com>
  19
  20         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  21         (create_excep_cond_exprs): Iterate over program spaces.
  22         (ada_exception_catchpoint_cond_string): Examine all minimal
  23         symbols for exception types.
  24
  25 2019-04-30  Tom Tromey  <tromey@adacore.com>
  26
  27         PR c++/24470:
  28         * dwarf2read.c (process_structure_scope): Handle case where type
  29         has template parameters but no symbol was created.
  30
  31 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  32             Chris January  <chris.january@arm.com>
  33
  34         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  35         qualifier.
  36         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  37
  38 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  39
  40         * f-typeprint.c (f_print_type): Update rules for printing
  41         whitespace.
  42         (f_type_print_varspec_suffix): Likewise.
  43
  44 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  45             Chris January  <chris.january@arm.com>
  46
  47         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  48         function arguments.
  49
  50 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * f-lang.c (build_fortran_types): Change name of void type to
  53         lower case.
  54         * f-typeprint.c (f_type_print_base): Print the name of the void
  55         type, rather than a fixed string.
  56         * f-valprint.c (f_decorations): Use lower case void string.
  57
  58 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  59             Chris January  <chris.january@arm.com>
  60
  61         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  62         types for Fortran.
  63
  64 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  65             Chris January  <chris.january@arm.com>
  66             David Lecomber  <david.lecomber@arm.com>
  67
  68         * f-exp.y (BINOP_INTRINSIC): New token.
  69         (exp): New parser rule handling BINOP_INTRINSIC.
  70         (f77_keywords): Add new builtin procedures.
  71         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  72         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  73         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  74         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  75         (print_unop_subexp_f): New function.
  76         (print_binop_subexp_f): New function.
  77         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  78         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  79         (dump_subexp_body_f): Likewise.
  80         (operator_check_f): Likewise.
  81         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  82         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  83
  84 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  85
  86         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
  87         UNOP_KIND.
  88         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
  89         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
  90         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
  91         (operator_length_f): New fuction.
  92         (print_subexp_f): New function.
  93         (op_name_f): New function.
  94         (dump_subexp_body_f): New function.
  95         (operator_check_f): New function.
  96         (exp_descriptor_f): Replace standard expression handling functions
  97         with new functions.
  98         * gdb/fortran-operator.def: New file.
  99         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 100         * gdb/std-operator.def: Remove UNOP_KIND.
 101
 102 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 103
 104         * std-operator.def: Remove unbalanced, stray double quote
 105         character.
 106
 107 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 108             Chris January  <chris.january@arm.com>
 109             Daniel Everett  <daniel.everett@arm.com>
 110             Nick Forrington  <nick.forrington@arm.com>
 111             Richard Bunt  <richard.bunt@arm.com>
 112
 113         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 114         of depth when printing anonymous structs or unions.
 115         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 116         Don't print either the top-level value, or the children if the
 117         max-depth is exceeded.
 118         (ppscm_print_children): When printing the key of a map, allow one
 119         extra level of depth.
 120         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 121         print either the top-level value, or the children if the max-depth
 122         is exceeded.
 123         (print_children): When printing the key of a map, allow one extra
 124         level of depth.
 125         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 126         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 127         (user_print_options): Initialise max_depth field.
 128         (val_print_scalar_or_string_type_p): New function.
 129         (val_print): Check to see if the max depth has been reached.
 130         (val_print_check_max_depth): Define new function.
 131         (show_print_max_depth): New function.
 132         (_initialize_valprint): Add 'print max-depth' option.
 133         * valprint.h (struct value_print_options) <max_depth>: New field.
 134         (val_print_check_max_depth): Declare new function.
 135         * NEWS: Document new feature.
 136
 137 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 138
 139         * ada-lang.c (ada_language_defn): Initialise new field.
 140         * c-lang.c (c_is_string_type_p): New function.
 141         (c_language_defn): Initialise new field.
 142         (cplus_language_defn): Initialise new field.
 143         (asm_language_defn): Initialise new field.
 144         (minimal_language_defn): Initialise new field.
 145         * c-lang.h (c_is_string_type_p): Declare new function.
 146         * d-lang.c (d_language_defn): Initialise new field.
 147         * f-lang.c (f_is_string_type_p): New function.
 148         (f_language_defn): Initialise new field.
 149         * go-lang.c (go_is_string_type_p): New function.
 150         (go_language_defn): Initialise new field.
 151         * language.c (default_is_string_type_p): New function.
 152         (unknown_language_defn): Initialise new field.
 153         (auto_language_defn): Initialise new field.
 154         * language.h (struct language_defn) <la_is_string_type_p>: New
 155         member variable.
 156         (default_is_string_type_p): Declare new function.
 157         * m2-lang.c (m2_language_defn): Initialise new field.
 158         * objc-lang.c (objc_language_defn): Initialise new field.
 159         * opencl-lang.c (opencl_language_defn): Initialise new field.
 160         * p-lang.c (pascal_is_string_type_p): New function.
 161         (pascal_language_defn): Initialise new field.
 162         * rust-lang.c (rust_is_string_type_p): New function.
 163         (rust_language_defn): Initialise new field.
 164
 165 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 168         New field.
 169         * ada-lang.c (ada_language_defn): Initialise new field.
 170         * c-lang.c (c_language_defn): Likewise.
 171         (cplus_language_defn): Likewise.
 172         (asm_language_defn): Likewise.
 173         (minimal_language_defn): Likewise.
 174         * d-lang.c (d_language_defn): Likewise.
 175         * f-lang.c (f_language_defn): Likewise.
 176         * go-lang.c (go_language_defn): Likewise.
 177         * language.c (unknown_language_defn): Likewise.
 178         (auto_language_defn): Likewise.
 179         * m2-lang.c (m2_language_defn): Likewise.
 180         * objc-lang.c (objc_language_defn): Likewise.
 181         * opencl-lang.c (opencl_language_defn): Likewise.
 182         * p-lang.c (pascal_language_defn): Likewise.
 183         * rust-lang.c (rust_language_defn): Likewise.
 184
 185 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 186
 187         * ada-lang.c (ada_is_character_type): Change return type to bool.
 188         (ada_is_string_type): Likewise.
 189         * ada-lang.h (ada_is_character_type): Update declaration
 190         (ada_is_string_type): Likewise.
 191
 192 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 193
 194         Support style in 'frame|thread apply'
 195
 196         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 197         * record.c (record_start, record_stop): Update callers of
 198         execute_command_to_string with false.
 199         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 200         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 201         methods.
 202         (class string_file): New constructor with term_out parameter.
 203         Override methods term_out and can_emit_style_escape.  New member
 204         term_out.
 205         (class stdio_file): Override can_emit_style_escape.
 206         (class tee_file): Override term_out and can_emit_style_escape.
 207         * utils.h (can_emit_style_escape): Remove.
 208         * utils.c (can_emit_style_escape): Likewise.
 209         Update all callers of can_emit_style_escape (SOMESTREAM) to
 210         SOMESTREAM->can_emit_style_escape.
 211         * source-cache.c (source_cache::get_source_lines): Likewise.
 212         * stack.c (frame_apply_command_count): Call execute_command_to_string
 213         passing the term_out characteristic of the current gdb_stdout.
 214         * thread.c (thr_try_catch_cmd): Likewise.
 215         * top.c (execute_command_to_string): pass term_out parameter
 216         to construct the string_file for the command output.
 217         * ui-file.c (term_cli_styling): New function (most code moved
 218         from utils.c can_emit_style_escape).
 219         (string_file::string_file, string_file::can_emit_style_escape,
 220         stdio_file::can_emit_style_escape, tee_file::term_out,
 221         tee_file::can_emit_style_escape): New functions.
 222
 223 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 224
 225         * NEWS: Mention the new set|show may-call-functions.
 226         * infcall.c (may_call_functions_p): New variable.
 227         (show_may_call_functions_p): New function.
 228         (call_function_by_hand_dummy): Throws an error if not
 229         may-call-functions.
 230         (_initialize_infcall): Call add_setshow_boolean_cmd for
 231         may-call-functions.
 232
 233 2019-04-25  Keith Seitz  <keiths@redhat.com>
 234
 235         PR c++/24367
 236         * cp-support.c (inspect_type): Don't attempt substitutions
 237         of symbol with the same name.
 238
 239 2019-04-25  Tom Tromey  <tromey@adacore.com>
 240
 241         PR gdb/24475:
 242         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 243         static.
 244
 245 2019-04-25  Tom Tromey  <tromey@adacore.com>
 246
 247         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 248         rvalue reference.
 249         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 250         (gdb_xml_parser::parse): Use std::move.
 251         * python/python-internal.h (gdbpy_convert_exception): Take a const
 252         reference.
 253         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 254         std::move.
 255         * python/py-utils.c (gdbpy_convert_exception): Take a const
 256         reference.
 257         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 258         Use std::move.
 259         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 260         Use std::move.
 261         * mi/mi-main.c (mi_print_exception): Take a const reference.
 262         * main.c (handle_command_errors): Take a const reference.
 263         * linespec.c (parse_linespec): Use std::move.
 264         * infcall.c (run_inferior_call): Use std::move.
 265         (call_function_by_hand_dummy): Use std::move.
 266         * exec.c (try_open_exec_file): Use std::move.
 267         * exceptions.h (exception_print, exception_fprintf)
 268         (exception_print_same): Update.
 269         * exceptions.c (print_exception, exception_print)
 270         (exception_fprintf, exception_print_same): Change parameters to
 271         const reference.
 272         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 273         * common/new-op.c: Use std::move.
 274         * common/common-exceptions.h (struct gdb_exception): Add move
 275         constructor.
 276         (struct gdb_exception_error, struct gdb_exception_quit, struct
 277         gdb_quit_bad_alloc): Change constructor to move constructor.
 278         (throw_exception): Change parameter to rvalue reference.
 279         * common/common-exceptions.c (throw_exception): Take rvalue
 280         reference.
 281         * cli/cli-interp.c (safe_execute_command): Use std::move.
 282         * breakpoint.c (insert_bp_location, location_to_sals): Use
 283         std::move.
 284
 285 2019-04-25  Tom Tromey  <tromey@adacore.com>
 286
 287         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 288         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 289         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 290         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 291         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 292         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 293         guile/scm-value.c: Use unpack.
 294         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 295         gdbscm_gdb_exception.
 296         (gdbscm_throw_gdb_exception): Likewise.
 297         (struct gdbscm_gdb_exception): New.
 298         (unpack): New function.
 299         (gdbscm_wrap): Use unpack.
 300
 301 2019-04-25  Tom Tromey  <tromey@adacore.com>
 302
 303         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 304         (gdb_rl_callback_handler): Use std::move.
 305         * common/common-exceptions.h (struct gdb_exception): Add move
 306         assignment operator.
 307         (throw_exception_sjlj): Change "exception" to const reference.
 308         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 309         (throw_exception_sjlj): Change "exception" to const reference.
 310
 311 2019-04-25  Tom Tromey  <tromey@adacore.com>
 312
 313         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 314         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 315         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 316         Update.
 317         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 318         Update.
 319         * mi/mi-interp.c (mi_interp::exec): Update.
 320         * linespec.c (parse_linespec): Update.
 321         * infcall.c (run_inferior_call): Update.
 322         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 323         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 324         (gdbscm_lookup_global_symbol): Update.
 325         * guile/scm-param.c (gdbscm_parameter_value): Update.
 326         * guile/scm-frame.c (gdbscm_frame_read_register)
 327         (gdbscm_frame_read_var): Update.
 328         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 329         * exec.c (try_open_exec_file): Update.
 330         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 331         (gdb_rl_callback_handler): Update.
 332         * common/common-exceptions.h (exception_none): Don't declare.
 333         * common/common-exceptions.c (exception_none): Don't define.
 334         (struct catcher) <exception>: Update.
 335         * cli/cli-interp.c (safe_execute_command): Update.
 336         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 337
 338 2019-04-25  Ali Tamur  <tamur@google.com>
 339
 340         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 341         (read_attribute_value): Likewise.
 342         (dwarf2_read_addr_index): Update comment.
 343         (read_str_index): Add DW_FORM_strx.
 344         (dwarf2_string_attr): Likewise.
 345         (dwarf2_const_value_attr): Likewise.
 346         (dump_die_shallow): Likewise.
 347         (dwarf2_fetch_constant_bytes): Likewise.
 348         (skip_form_bytes): Likewise.
 349         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 350
 351 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 352
 353         PR corefiles/11608
 354         PR corefiles/18187
 355         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 356         OFFSET.  Verify if current mapping contains an ELF header.
 357         (linux_find_memory_regions_full): Adjust call to
 358         dump_mapping_p.
 359
 360 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 361             Kang Li <kanglictf@gmail.com>
 362
 363         PR gdb/21600
 364
 365         * dwarf2-frame.c (read_initial_length): Be consistent about using
 366         unsigned representation of length.
 367         (decode_frame_entry_1): Likewise.  Check for wraparound of
 368         end pointer as well as buffer overflow.
 369
 370 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 371
 372         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 373         "vq".
 374
 375 2019-04-24  Tom Tromey  <tromey@adacore.com>
 376
 377         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 378
 379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 380
 381         * s12z-tdep.c (s12z_unwind_pc): Delete.
 382         (s12z_unwind_sp): Delete.
 383         (s12z_gdbarch_init): Don't register deleted functions with
 384         gdbarch.
 385
 386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 387
 388         * rl78-tdep.c (rl78_unwind_sp): Delete.
 389         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 390
 391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 392
 393         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 394         (xstormy16_unwind_pc): Delete.
 395         (xstormy16_dummy_id): Delete.
 396         (xstormy16_gdbarch_init): Don't register deleted functions with
 397         gdbarch.
 398
 399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 400
 401         * vax-tdep.c (vax_unwind_pc): Delete.
 402         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 403
 404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * v850-tdep.c (v850_unwind_sp): Delete.
 407         (v850_unwind_pc): Delete.
 408         (v850_dummy_id): Delete.
 409         (v850_gdbarch_init): Don't register deleted functions with
 410         gdbarch.
 411
 412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 415         (tilegx_unwind_pc): Delete.
 416         (tilegx_unwind_dummy_id): Delete.
 417         (tilegx_gdbarch_init): Don't register deleted functions with
 418         gdbarch.
 419
 420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 421
 422         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 423         (tic6x_dummy_id): Delete.
 424         (tic6x_gdbarch_init): Don't register deleted functions with
 425         gdbarch.
 426
 427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * sparc-tdep.c (sparc_unwind_pc): Delete.
 430         (sparc32_gdbarch_init): Don't register deleted function with
 431         gdbarch.
 432
 433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 434
 435         * sh-tdep.c (sh_unwind_sp): Delete.
 436         (sh_unwind_pc): Delete.
 437         (sh_dummy_id): Delete.
 438         (sh_gdbarch_init): Don't register deleted functions with
 439         gdbarch.
 440
 441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 442
 443         * score-tdep.c (score_unwind_sp): Delete.
 444         (score_unwind_pc): Delete.
 445         (score_dummy_id): Delete.
 446         (score_gdbarch_init): Don't register deleted functions with
 447         gdbarch.
 448
 449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 450
 451         * rx-tdep.c (rx_unwind_pc): Delete.
 452         (rx_unwind_sp): Delete.
 453         (rx_dummy_id): Delete.
 454         (rx_gdbarch_init): Don't register deleted functions with
 455         gdbarch.  Update comment.
 456
 457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 460         (rs6000_dummy_id): Delete.
 461         (rs6000_gdbarch_init): Don't register deleted functions with
 462         gdbarch.
 463
 464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 465
 466         * or1k-tdep.c (or1k_dummy_id): Delete.
 467         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 468
 469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * nios2-tdep.c (nios2_dummy_id): Delete.
 472         (nios2_unwind_sp): Delete.
 473         (nios2_gdbarch_init): Don't register deleted functions with
 474         gdbarch.
 475
 476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * nds32-tdep.c (nds32_dummy_id): Delete.
 479         (nds32_unwind_pc): Delete.
 480         (nds32_unwind_sp): Delete.
 481         (nds32_gdbarch_init): Don't register deleted functions with
 482         gdbarch.
 483
 484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 485
 486         * msp430-tdep.c (msp430_unwind_pc): Delete.
 487         (msp430_unwind_sp): Delete.
 488         (msp430_dummy_id): Delete.
 489         (msp430_gdbarch_init): Don't register deleted functions with
 490         gdbarch.
 491
 492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * moxie-tdep.c (moxie_unwind_sp): Delete.
 495         (moxie_unwind_pc): Delete.
 496         (moxie_dummy_id): Delete.
 497         (moxie_gdbarch_init): Don't register deleted functions with
 498         gdbarch.
 499
 500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 503         (mn10300_unwind_pc): Delete.
 504         (mn10300_unwind_sp): Delete.
 505         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 506         mn10300_unwind_sp.
 507         (mn10300_frame_unwind_init): Don't register deleted functions with
 508         gdbarch.
 509
 510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 511
 512         * mep-tdep.c (mep_unwind_pc): Delete.
 513         (mep_unwind_sp): Delete.
 514         (mep_dummy_id): Delete.
 515         (mep_gdbarch_init): Don't register deleted functions with
 516         gdbarch.
 517
 518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 521         (m68hc11_unwind_sp): Delete.
 522         (m68hc11_gdbarch_init): Don't register deleted functions with
 523         gdbarch.
 524
 525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * m32r-tdep.c (m32r_unwind_sp): Delete.
 528         (m32r_unwind_pc): Delete.
 529         (m32r_dummy_id): Delete.
 530         (m32r_gdbarch_init): Don't register deleted functions with
 531         gdbarch.
 532
 533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 534
 535         * m32c-tdep.c (m32c_unwind_pc): Delete.
 536         (m32c_unwind_sp): Delete.
 537         (m32c_dummy_id): Delete.
 538         (m32c_gdbarch_init): Don't register deleted functions with
 539         gdbarch.
 540
 541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 544         (lm32_unwind_pc): Delete.
 545         (lm32_dummy_id): Delete.
 546         (lm32_gdbarch_init): Don't register deleted functions with
 547         gdbarch.
 548
 549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 552         (iq2000_unwind_pc): Delete.
 553         (iq2000_dummy_id): Delete.
 554         (iq2000_gdbarch_init): Don't register deleted functions with
 555         gdbarch.
 556
 557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * nds32-tdep.c (nds32_type_align): Delete.
 560         (nds32_push_dummy_call): Use type_align instead.
 561
 562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 563
 564         * arm-tdep.c (arm_type_align): Only handle vector override case.
 565         (arm_push_dummy_call): Use type_align.
 566         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 567
 568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 571         case.
 572         (pass_on_stack): Use type_align.
 573         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 574         function.
 575
 576 2019-04-23  Tom Tromey  <tromey@adacore.com>
 577
 578         * dwarf2read.c (line_header::file_name_at): Remove unused
 579         overload.
 580
 581 2019-04-23  Tom de Vries  <tdevries@suse.de>
 582
 583         PR gdb/24438
 584         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 585         invocation.
 586
 587
 588 2019-03-27  Ali Tamur  <tamur@google.com>
 589
 590         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 591         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 592         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 593         (dwarf_expr_context::get_addr_index): Likewise
 594         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 595         (symbol_needs_eval_context::get_addr_index): Likewise
 596         (disassemble_dwarf_expression): Add DW_OP_addrx
 597         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 598         (read_cutu_die_from_dwo): Update comment
 599         (skip_one_die): Add DW_FORM_addrx
 600         (read_attribute_value): Likewise
 601         (var_decode_location): Add DW_OP_addrx
 602         (dwarf2_const_value_attr): Add DW_FORM_addrx
 603         (dump_die_shallow): Likewise
 604         (dwarf2_fetch_constant_bytes): Likewise
 605         (decode_locdesc): Add DW_OP_addrx
 606         (skip_form_bytes): Add DW_FORM_addrx
 607
 608 2019-04-22  Ali Tamur  <tamur@google.com>
 609
 610         * MAINTAINERS (Write After Approval): Add self.
 611
 612 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 613
 614         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 615         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 616         (open_symbol_file_object): Likewise.
 617         (svr4_default_sos): Add info parameter.
 618         (svr4_read_so_list): Likewise.
 619         (svr4_current_sos_direct): Adjust functions calls to pass down
 620         info.
 621         (svr4_current_sos_1): Add info parameter.
 622         (svr4_current_sos): Call get_svr4_info, pass info down to
 623         svr4_current_sos_1.
 624         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 625         get_svr4_info.
 626         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 627         get_svr4_info.
 628         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 629         to get_svr4_info.
 630         (probes_table_remove_objfile_probes): Likewise.
 631         (register_solib_event_probe): Add info parameter.
 632         (solist_update_incremental): Pass info parameter down to
 633         svr4_read_so_list.
 634         (disable_probes_interface): Add info parameter.
 635         (svr4_handle_solib_event): Pass current_program_space to
 636         get_svr4_info.  Adjust disable_probes_interface cleanup.
 637         (svr4_create_probe_breakpoints): Add info parameter, pass it
 638         down to register_solib_event_probe.
 639         (svr4_create_solib_event_breakpoints): Add info parameter,
 640         pass it down to svr4_create_probe_breakpoints.
 641         (enable_break): Pass info down to
 642         svr4_create_solib_event_breakpoints.
 643         (svr4_solib_create_inferior_hook): Pass current_program_space to
 644         get_svr4_info.
 645         (svr4_clear_solib): Likewise.
 646
 647 2019-04-22  Pedro Alves  <palves@redhat.com>
 648
 649         * solib-svr4.c (svr4_free_objfile_observer): New.
 650         (probe_and_action::objfile): New field.
 651         (probes_table_htab_remove_objfile_probes)
 652         (probes_table_remove_objfile_probes): New functions.
 653         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 654         in the new probe_and_action.  Don't store the probe in 'lookup'.
 655         (svr4_create_probe_breakpoints): Pass objfile to
 656         register_solib_event_probe.
 657         (_initialize_svr4_solib): Register a free_objfile observer.
 658
 659 2019-04-19  Tom Tromey  <tom@tromey.com>
 660
 661         * common/queue.h: Remove.
 662
 663 2019-04-19  Tom Tromey  <tom@tromey.com>
 664
 665         * event-loop.c: Don't include "common/queue.h".
 666
 667 2019-04-19  Tom Tromey  <tom@tromey.com>
 668
 669         * remote.c (remote_target): Use delete.
 670         * remote-notif.h: Include <list>, not "common/queue.h".
 671         (notif_client_p): Remove typedef.
 672         (remote_notif_state): Add constructor, destructor, initializer.
 673         <notif_queue>: Now a std::list.
 674         (remote_notif_state_xfree): Don't declare.
 675         * remote-notif.c (remote_notif_process, handle_notification)
 676         (remote_notif_state_allocate): Update.
 677         (~remote_notif_state): Rename from remote_notif_state_xfree.
 678
 679 2019-04-19  Tom Tromey  <tom@tromey.com>
 680
 681         * symfile.c (reread_symbols): Update.
 682         * objfiles.c (objfile_register_static_link)
 683         (objfile_lookup_static_link): Update
 684         (~objfile) Don't delete static_links.
 685         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 686
 687 2019-04-19  Tom Tromey  <tom@tromey.com>
 688
 689         * type-stack.h (struct type_stack) <insert>: Constify string.
 690         * type-stack.c (type_stack::insert): Constify string.
 691         * gdbtypes.h (lookup_template_type): Update.
 692         (address_space_name_to_int): Update.
 693         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 694         const.
 695         (lookup_template_type): Make name const.
 696         * c-exp.y: Update rules.
 697         (lex_one_token, classify_name, classify_inner_name)
 698         (c_print_token): Update.
 699         * p-exp.y: Update rules.
 700         (yylex): Update.
 701         * f-exp.y: Update rules.
 702         (yylex): Update.
 703         * d-exp.y: Update rules.
 704         (lex_one_token, classify_name, classify_inner_name): Update.
 705         * parse.c (write_dollar_variable, copy_name): Return std::string.
 706         * parser-defs.h (copy_name): Change return type.
 707         * m2-exp.y: Update rules.
 708         (yylex): Update.
 709         * go-exp.y (lex_one_token): Update.
 710         Update rules.
 711         (classify_unsafe_function, classify_packaged_name)
 712         (classify_name, yylex): Update.
 713
 714 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 715
 716         * configure.ac: add --enable-source-highlight switch.
 717         * configure: Regenerate.
 718         * top.c (print_gdb_version): plumb --enable-source-highlight
 719         status to "show configuration".
 720
 721 2019-04-19  Tom Tromey  <tromey@adacore.com>
 722
 723         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 724         Check ADA_TYPE_P.
 725         (empty_record, ada_template_to_fixed_record_type_1)
 726         (template_to_static_fixed_type)
 727         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 728         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 729         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 730         macros.
 731
 732 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 733
 734         PR symtab/24423:
 735         * source.c (print_source_lines_base): Advance "iter" when a
 736         control character is seen.
 737
 738 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 739
 740         * inferior.h (struct infcall_suspend_state_deleter):
 741         Catch exception in destructor to avoid crash.
 742
 743 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 744
 745         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 746         close to the add_com "shell".
 747
 748 2019-04-18  Tom Tromey  <tromey@adacore.com>
 749
 750         * process-stratum-target.h (class process_stratum_target)
 751         <stratum>: Add "final".
 752
 753 2019-04-17  Tom Tromey  <tromey@adacore.com>
 754
 755         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 756         against nullptr before use.
 757
 758 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 759
 760         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 761
 762 2019-04-17  Jim Wilson  <jimw@sifive.com>
 763             Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 766         code read might fail, assume 4-byte breakpoint in that case.
 767
 768 2019-04-15  Leszek Swirski  <leszeks@google.com>
 769
 770         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 771         rather than a hand-rolled POD check when checking for forced MEMORY
 772         classification.
 773
 774 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 775
 776         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 777         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 778         function.
 779         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 780         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 781         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 782         declaration.
 783
 784 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 785
 786         * aarch64-linux-nat.c
 787         (aarch64_linux_nat_target::thread_architecture): Add override.
 788         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 789         each VQ.
 790
 791 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 792
 793         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 794
 795 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 796
 797         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 798         target types of size 96-bits, add some additional comments, and
 799         check that the builtin type we found was the correct size.
 800
 801 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 802
 803         * utils.c (prompt_for_continue): Don't restore the styling at the
 804         end, as applied_style has the wrong value.  This fixes styling in
 805         long lists of file names that are interrupted by the "Continue?"
 806         prompt.
 807
 808 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 811         * c-lang.c (c_language_defn): Likewise.
 812         (cplus_language_defn): Likewise.
 813         (asm_language_defn): Likewise.
 814         (minimal_language_defn): Likewise.
 815         * d-lang.c (d_language_defn): Likewise.
 816         * f-lang.c (f_language_defn): Likewise.
 817         * go-lang.c (go_language_defn): Likewise.
 818         * language.c (unknown_language_defn): Likewise.
 819         (auto_language_defn): Likewise.
 820         * language.h (struct language_defn): Remove la_magic field.
 821         (LANG_MAGIC): Delete.
 822         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 823         * objc-lang.c (objc_language_defn): Likewise.
 824         * opencl-lang.c (opencl_language_defn): Likewise.
 825         * p-lang.c (pascal_language_defn): Likewise.
 826         * rust-lang.c (rust_language_defn): Likewise.
 827
 828 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * riscv-tdep.c (riscv_type_align): New function.
 831         (riscv_type_alignment): Delete.
 832         (riscv_arg_location): Use 'type_align'.
 833         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 834
 835 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 836
 837         * gdbtypes.c (type_align): A struct with no non-static fields also
 838         has alignment of 1.
 839
 840 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 843         component to 0.
 844         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 845         member.
 846         (riscv_struct_info::analyse): New implementation using new
 847         analyse_inner member function.
 848         (riscv_struct_info::field_offset): New member function.
 849         (riscv_struct_info::m_offsets): New member variable.
 850         (riscv_struct_info::analyse_inner): New private member function,
 851         takes the old implementation of riscv_struct_info::analyse but
 852         extended to track field offsets.
 853         (riscv_call_arg_struct): Update the struct folding special cases
 854         to handle cases where empty C++ structs, which are non-zero
 855         length, are found.
 856         (riscv_arg_location): Initialise the length of each location, a
 857         non-zero length now indicates the location is in use.
 858         (riscv_push_dummy_call): Allow for the first location having a
 859         non-zero offset when setting up arguments.
 860         (riscv_return_value): Likewise, but for return values.
 861
 862 2019-04-11  Tom Tromey  <tromey@adacore.com>
 863
 864         * utils.c (internal_vproblem): Make "msg" const.
 865
 866 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 867
 868         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 869         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 870         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 871         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 872
 873 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 874
 875         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 876         function.
 877         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 878         of amd64_collect_native_gregset.
 879         (amd64_linux_nat_target::store_registers): Likewise.
 880
 881 2019-04-10  Tom Tromey  <tom@tromey.com>
 882
 883         * symtab.c (lookup_global_symbol_from_objfile)
 884         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 885         * objfiles.h (class separate_debug_iterator): New.
 886         (class separate_debug_range): New.
 887         (struct objfile) <separate_debug_objfiles>: New method.
 888         (objfile_separate_debug_iterate): Don't declare.
 889         * objfiles.c (separate_debug_iterator::operator++): Rename from
 890         objfile_separate_debug_iterate.
 891         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 892         iterator.
 893         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 894         iterator.
 895
 896 2019-04-10  Tom Tromey  <tom@tromey.com>
 897
 898         * symfile.c (reread_symbols): Remove old comment.
 899         * objfiles.c (free_all_objfiles): Fix a typo.
 900
 901 2019-04-10  Tom Tromey  <tom@tromey.com>
 902
 903         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 904         * minsyms.c (lookup_minimal_symbol): Use foreach.
 905         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 906         (lookup_minimal_symbol_solib_trampoline): Likewise.
 907         * symfile.c (reread_symbols): Use foreach.
 908
 909 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 910             Tom Tromey  <tromey@adacore.com>
 911
 912         PR rust/24414:
 913         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 914         (rust_lex_int_test): Change "value" to be LONGEST.
 915         (rust_lex_tests): Add test for long integer literal.
 916
 917 2019-04-09  Tom Tromey  <tromey@adacore.com>
 918
 919         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 920         to bool.
 921         (extended_remote_target::attach): Update.
 922         (remote_target::remote_notice_new_inferior): Update.
 923         (remote_target::add_current_inferior_and_thread): Update.
 924         * inferior.c (exit_inferior_1): Use "false".
 925         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 926
 927 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 928
 929         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 930         the "start" command.
 931
 932 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 933
 934         * python/py-inferior.c (infpy_thread_from_thread_handle):
 935         Adjust comments to reflect renaming of thread_from_thread_handle
 936         to thread_from_handle.  Adjust keywords.  Fix type error message.
 937         (inferior_object_methods): Add thread_from_handle.  Retain
 938         thread_from_thread_handle, but mark it as deprecated.
 939
 940 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 941
 942         * gdbthread.h (find_thread_by_handle): Revise declaration.
 943         * thread.c (find_thread_by_handle): Likewise.  Adjust
 944         implementation too.
 945         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 946         support for buffer objects as handles.
 947
 948 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 949
 950         * python/py-infthread.c (thpy_thread_handle): New function.
 951         (thread_object_methods): Register thpy_thread_handle.
 952
 953 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 954
 955         * gdbthread.h (thread_to_thread_handle): Declare.
 956         * thread.c (gdbtypes.h): Include.
 957         (thread_to_thread_handle): New function.
 958
 959         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 960         (target_thread_info_to_thread_handle): Declare.
 961         * target.c (target_thread_info_to_thread_handle): New function.
 962         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 963         * target-delegates.c: Regenerate.
 964
 965         * linux-thread-db.c (class thread_db_target): Add method
 966         thread_info_to_thread_handle.
 967         (thread_db_target::thread_info_to_thread_handle): Define.
 968         * remote.c (class remote_target): Add new method
 969         thread_info_to_thread_handle.
 970         (remote_target::thread_info_to_thread_handle): Define.
 971
 972 2019-04-08  Pedro Alves  <palves@redhat.com>
 973
 974         * common/common-exceptions.c (throw_exception): Don't create
 975         named object to throw; throw directly.
 976         (throw_it): Likewise.  Don't initialize gdb_exception::message
 977         here, with new; pass FMT and AP to the ctor instead.
 978         * common/common-exceptions.h: Include <string>.
 979         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 980         const char *, va_list)): New ctor.  Use std::make_shared.
 981         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 982         errors)): Delete.
 983         (gdb_exception_error::gdb_exception_error(enum errors, const char
 984         *, va_list)): New.
 985         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 986         Add assertion.
 987         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 988         errors)): Delete.
 989         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 990         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 991         Add assertion.
 992
 993 2019-04-08  Tom Tromey  <tom@tromey.com>
 994
 995         * valops.c (value_rtti_indirect_type): Replace throw_exception
 996         with throw.
 997         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 998         with throw.
 999         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1000         throw.
1001         * target.c (target_translate_tls_address): Replace throw_exception
1002         with throw.
1003         * stack.c (frame_apply_command_count): Replace throw_exception
1004         with throw.
1005         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1006         throw.
1007         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1008         with throw.
1009         * rs6000-tdep.c (rs6000_frame_cache)
1010         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1011         * remote.c: Replace throw_exception with throw.
1012         * record-full.c (record_full_message, record_full_wait_1)
1013         (record_full_restore): Replace throw_exception with throw.
1014         * record-btrace.c:
1015         (get_thread_current_frame_id, record_btrace_start_replaying)
1016         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1017         (cmd_record_btrace_start): Replace throw_exception with throw.
1018         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1019         throw.
1020         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1021         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1022         * linespec.c:
1023         (find_linespec_symbols): Replace throw_exception with throw.
1024         * infrun.c (displaced_step_prepare, resume): Replace
1025         throw_exception with throw.
1026         * infcmd.c (post_create_inferior): Replace throw_exception with
1027         throw.
1028         * inf-loop.c (inferior_event_handler): Replace throw_exception
1029         with throw.
1030         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1031         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1032         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1033         (get_prev_frame_always, get_frame_pc_if_available)
1034         (get_frame_address_in_block_if_available, get_frame_language):
1035         Replace throw_exception with throw.
1036         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1037         throw_exception with throw.
1038         * eval.c (fetch_subexp_value, evaluate_var_value)
1039         (evaluate_funcall, evaluate_subexp_standard): Replace
1040         throw_exception with throw.
1041         * dwarf2loc.c (call_site_find_chain)
1042         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1043         Replace throw_exception with throw.
1044         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1045         with throw.
1046         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1047         throw.
1048         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1049         * completer.c (complete_line_internal): Replace throw_exception
1050         with throw.
1051         * compile/compile-object-run.c (compile_object_run): Replace
1052         throw_exception with throw.
1053         * cli/cli-script.c (process_next_line): Replace throw_exception
1054         with throw.
1055         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1056         (btrace_enable, btrace_maint_update_pt_packets): Replace
1057         throw_exception with throw.
1058         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1059         throw_exception with throw.
1060         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1061         throw_exception with throw.
1062         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1063         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1064         * aarch64-tdep.c (aarch64_make_prologue_cache)
1065         (aarch64_make_stub_cache): Replace throw_exception with throw.
1066
1067 2019-04-08  Tom Tromey  <tom@tromey.com>
1068
1069         * common/common-exceptions.c (throw_exception): Rename from
1070         throw_exception_cxx.  Remove old copy.  Make argument const.
1071         (throw_it): Create and throw exception objects directly.
1072         * common/common-exceptions.h (throw_exception): Make argument
1073         const.
1074         (struct gdb_exception_error): Add constructor.
1075         (struct gdb_exception_quit): Add constructor.
1076
1077 2019-04-08  Tom Tromey  <tom@tromey.com>
1078
1079         * common/common-exceptions.h (exception_rethrow): Don't declare.
1080         (TRY_SJLJ): Update comment.
1081         (TRY, CATCH, END_CATCH): Remove.
1082         * common/common-exceptions.c (exception_rethrow): Remove.
1083
1084 2019-04-08  Tom Tromey  <tom@tromey.com>
1085
1086         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1087         Remove.
1088         (gdb_exception_error): Rename from
1089         gdb_exception_RETURN_MASK_ERROR.
1090         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1091         (gdb_quit_bad_alloc): Update.
1092         * aarch64-tdep.c: Update.
1093         * ada-lang.c: Update.
1094         * ada-typeprint.c: Update.
1095         * ada-valprint.c: Update.
1096         * amd64-tdep.c: Update.
1097         * arch-utils.c: Update.
1098         * break-catch-throw.c: Update.
1099         * breakpoint.c: Update.
1100         * btrace.c: Update.
1101         * c-varobj.c: Update.
1102         * cli/cli-cmds.c: Update.
1103         * cli/cli-interp.c: Update.
1104         * cli/cli-script.c: Update.
1105         * common/common-exceptions.c: Update.
1106         * common/new-op.c: Update.
1107         * common/selftest.c: Update.
1108         * compile/compile-c-symbols.c: Update.
1109         * compile/compile-cplus-symbols.c: Update.
1110         * compile/compile-object-load.c: Update.
1111         * compile/compile-object-run.c: Update.
1112         * completer.c: Update.
1113         * corelow.c: Update.
1114         * cp-abi.c: Update.
1115         * cp-support.c: Update.
1116         * cp-valprint.c: Update.
1117         * darwin-nat.c: Update.
1118         * disasm-selftests.c: Update.
1119         * dtrace-probe.c: Update.
1120         * dwarf-index-cache.c: Update.
1121         * dwarf-index-write.c: Update.
1122         * dwarf2-frame-tailcall.c: Update.
1123         * dwarf2-frame.c: Update.
1124         * dwarf2loc.c: Update.
1125         * dwarf2read.c: Update.
1126         * eval.c: Update.
1127         * event-loop.c: Update.
1128         * event-top.c: Update.
1129         * exec.c: Update.
1130         * f-valprint.c: Update.
1131         * fbsd-tdep.c: Update.
1132         * frame-unwind.c: Update.
1133         * frame.c: Update.
1134         * gdbtypes.c: Update.
1135         * gnu-v3-abi.c: Update.
1136         * guile/guile-internal.h: Update.
1137         * guile/scm-block.c: Update.
1138         * guile/scm-breakpoint.c: Update.
1139         * guile/scm-cmd.c: Update.
1140         * guile/scm-disasm.c: Update.
1141         * guile/scm-frame.c: Update.
1142         * guile/scm-lazy-string.c: Update.
1143         * guile/scm-math.c: Update.
1144         * guile/scm-param.c: Update.
1145         * guile/scm-ports.c: Update.
1146         * guile/scm-pretty-print.c: Update.
1147         * guile/scm-symbol.c: Update.
1148         * guile/scm-symtab.c: Update.
1149         * guile/scm-type.c: Update.
1150         * guile/scm-value.c: Update.
1151         * i386-linux-tdep.c: Update.
1152         * i386-tdep.c: Update.
1153         * inf-loop.c: Update.
1154         * infcall.c: Update.
1155         * infcmd.c: Update.
1156         * infrun.c: Update.
1157         * jit.c: Update.
1158         * language.c: Update.
1159         * linespec.c: Update.
1160         * linux-fork.c: Update.
1161         * linux-nat.c: Update.
1162         * linux-tdep.c: Update.
1163         * linux-thread-db.c: Update.
1164         * main.c: Update.
1165         * mi/mi-cmd-break.c: Update.
1166         * mi/mi-cmd-stack.c: Update.
1167         * mi/mi-interp.c: Update.
1168         * mi/mi-main.c: Update.
1169         * objc-lang.c: Update.
1170         * p-valprint.c: Update.
1171         * parse.c: Update.
1172         * ppc-linux-tdep.c: Update.
1173         * printcmd.c: Update.
1174         * python/py-arch.c: Update.
1175         * python/py-breakpoint.c: Update.
1176         * python/py-cmd.c: Update.
1177         * python/py-finishbreakpoint.c: Update.
1178         * python/py-frame.c: Update.
1179         * python/py-framefilter.c: Update.
1180         * python/py-gdb-readline.c: Update.
1181         * python/py-inferior.c: Update.
1182         * python/py-infthread.c: Update.
1183         * python/py-lazy-string.c: Update.
1184         * python/py-linetable.c: Update.
1185         * python/py-objfile.c: Update.
1186         * python/py-param.c: Update.
1187         * python/py-prettyprint.c: Update.
1188         * python/py-progspace.c: Update.
1189         * python/py-record-btrace.c: Update.
1190         * python/py-record.c: Update.
1191         * python/py-symbol.c: Update.
1192         * python/py-type.c: Update.
1193         * python/py-unwind.c: Update.
1194         * python/py-utils.c: Update.
1195         * python/py-value.c: Update.
1196         * python/python.c: Update.
1197         * record-btrace.c: Update.
1198         * record-full.c: Update.
1199         * remote-fileio.c: Update.
1200         * remote.c: Update.
1201         * riscv-tdep.c: Update.
1202         * rs6000-aix-tdep.c: Update.
1203         * rs6000-tdep.c: Update.
1204         * rust-exp.y: Update.
1205         * rust-lang.c: Update.
1206         * s390-tdep.c: Update.
1207         * selftest-arch.c: Update.
1208         * solib-dsbt.c: Update.
1209         * solib-frv.c: Update.
1210         * solib-spu.c: Update.
1211         * solib-svr4.c: Update.
1212         * solib.c: Update.
1213         * sparc64-linux-tdep.c: Update.
1214         * stack.c: Update.
1215         * symfile-mem.c: Update.
1216         * symmisc.c: Update.
1217         * target.c: Update.
1218         * thread.c: Update.
1219         * top.c: Update.
1220         * tracefile-tfile.c: Update.
1221         * tui/tui.c: Update.
1222         * typeprint.c: Update.
1223         * unittests/cli-utils-selftests.c: Update.
1224         * unittests/parse-connection-spec-selftests.c: Update.
1225         * valops.c: Update.
1226         * valprint.c: Update.
1227         * value.c: Update.
1228         * varobj.c: Update.
1229         * windows-nat.c: Update.
1230         * x86-linux-nat.c: Update.
1231         * xml-support.c: Update.
1232
1233 2019-04-08  Tom Tromey  <tom@tromey.com>
1234
1235         * xml-support.c: Use C++ exception handling.
1236         * x86-linux-nat.c: Use C++ exception handling.
1237         * windows-nat.c: Use C++ exception handling.
1238         * varobj.c: Use C++ exception handling.
1239         * value.c: Use C++ exception handling.
1240         * valprint.c: Use C++ exception handling.
1241         * valops.c: Use C++ exception handling.
1242         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1243         handling.
1244         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1245         * typeprint.c: Use C++ exception handling.
1246         * tui/tui.c: Use C++ exception handling.
1247         * tracefile-tfile.c: Use C++ exception handling.
1248         * top.c: Use C++ exception handling.
1249         * thread.c: Use C++ exception handling.
1250         * target.c: Use C++ exception handling.
1251         * symmisc.c: Use C++ exception handling.
1252         * symfile-mem.c: Use C++ exception handling.
1253         * stack.c: Use C++ exception handling.
1254         * sparc64-linux-tdep.c: Use C++ exception handling.
1255         * solib.c: Use C++ exception handling.
1256         * solib-svr4.c: Use C++ exception handling.
1257         * solib-spu.c: Use C++ exception handling.
1258         * solib-frv.c: Use C++ exception handling.
1259         * solib-dsbt.c: Use C++ exception handling.
1260         * selftest-arch.c: Use C++ exception handling.
1261         * s390-tdep.c: Use C++ exception handling.
1262         * rust-lang.c: Use C++ exception handling.
1263         * rust-exp.y: Use C++ exception handling.
1264         * rs6000-tdep.c: Use C++ exception handling.
1265         * rs6000-aix-tdep.c: Use C++ exception handling.
1266         * riscv-tdep.c: Use C++ exception handling.
1267         * remote.c: Use C++ exception handling.
1268         * remote-fileio.c: Use C++ exception handling.
1269         * record-full.c: Use C++ exception handling.
1270         * record-btrace.c: Use C++ exception handling.
1271         * python/python.c: Use C++ exception handling.
1272         * python/py-value.c: Use C++ exception handling.
1273         * python/py-utils.c: Use C++ exception handling.
1274         * python/py-unwind.c: Use C++ exception handling.
1275         * python/py-type.c: Use C++ exception handling.
1276         * python/py-symbol.c: Use C++ exception handling.
1277         * python/py-record.c: Use C++ exception handling.
1278         * python/py-record-btrace.c: Use C++ exception handling.
1279         * python/py-progspace.c: Use C++ exception handling.
1280         * python/py-prettyprint.c: Use C++ exception handling.
1281         * python/py-param.c: Use C++ exception handling.
1282         * python/py-objfile.c: Use C++ exception handling.
1283         * python/py-linetable.c: Use C++ exception handling.
1284         * python/py-lazy-string.c: Use C++ exception handling.
1285         * python/py-infthread.c: Use C++ exception handling.
1286         * python/py-inferior.c: Use C++ exception handling.
1287         * python/py-gdb-readline.c: Use C++ exception handling.
1288         * python/py-framefilter.c: Use C++ exception handling.
1289         * python/py-frame.c: Use C++ exception handling.
1290         * python/py-finishbreakpoint.c: Use C++ exception handling.
1291         * python/py-cmd.c: Use C++ exception handling.
1292         * python/py-breakpoint.c: Use C++ exception handling.
1293         * python/py-arch.c: Use C++ exception handling.
1294         * printcmd.c: Use C++ exception handling.
1295         * ppc-linux-tdep.c: Use C++ exception handling.
1296         * parse.c: Use C++ exception handling.
1297         * p-valprint.c: Use C++ exception handling.
1298         * objc-lang.c: Use C++ exception handling.
1299         * mi/mi-main.c: Use C++ exception handling.
1300         * mi/mi-interp.c: Use C++ exception handling.
1301         * mi/mi-cmd-stack.c: Use C++ exception handling.
1302         * mi/mi-cmd-break.c: Use C++ exception handling.
1303         * main.c: Use C++ exception handling.
1304         * linux-thread-db.c: Use C++ exception handling.
1305         * linux-tdep.c: Use C++ exception handling.
1306         * linux-nat.c: Use C++ exception handling.
1307         * linux-fork.c: Use C++ exception handling.
1308         * linespec.c: Use C++ exception handling.
1309         * language.c: Use C++ exception handling.
1310         * jit.c: Use C++ exception handling.
1311         * infrun.c: Use C++ exception handling.
1312         * infcmd.c: Use C++ exception handling.
1313         * infcall.c: Use C++ exception handling.
1314         * inf-loop.c: Use C++ exception handling.
1315         * i386-tdep.c: Use C++ exception handling.
1316         * i386-linux-tdep.c: Use C++ exception handling.
1317         * guile/scm-value.c: Use C++ exception handling.
1318         * guile/scm-type.c: Use C++ exception handling.
1319         * guile/scm-symtab.c: Use C++ exception handling.
1320         * guile/scm-symbol.c: Use C++ exception handling.
1321         * guile/scm-pretty-print.c: Use C++ exception handling.
1322         * guile/scm-ports.c: Use C++ exception handling.
1323         * guile/scm-param.c: Use C++ exception handling.
1324         * guile/scm-math.c: Use C++ exception handling.
1325         * guile/scm-lazy-string.c: Use C++ exception handling.
1326         * guile/scm-frame.c: Use C++ exception handling.
1327         * guile/scm-disasm.c: Use C++ exception handling.
1328         * guile/scm-cmd.c: Use C++ exception handling.
1329         * guile/scm-breakpoint.c: Use C++ exception handling.
1330         * guile/scm-block.c: Use C++ exception handling.
1331         * guile/guile-internal.h: Use C++ exception handling.
1332         * gnu-v3-abi.c: Use C++ exception handling.
1333         * gdbtypes.c: Use C++ exception handling.
1334         * frame.c: Use C++ exception handling.
1335         * frame-unwind.c: Use C++ exception handling.
1336         * fbsd-tdep.c: Use C++ exception handling.
1337         * f-valprint.c: Use C++ exception handling.
1338         * exec.c: Use C++ exception handling.
1339         * event-top.c: Use C++ exception handling.
1340         * event-loop.c: Use C++ exception handling.
1341         * eval.c: Use C++ exception handling.
1342         * dwarf2read.c: Use C++ exception handling.
1343         * dwarf2loc.c: Use C++ exception handling.
1344         * dwarf2-frame.c: Use C++ exception handling.
1345         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1346         * dwarf-index-write.c: Use C++ exception handling.
1347         * dwarf-index-cache.c: Use C++ exception handling.
1348         * dtrace-probe.c: Use C++ exception handling.
1349         * disasm-selftests.c: Use C++ exception handling.
1350         * darwin-nat.c: Use C++ exception handling.
1351         * cp-valprint.c: Use C++ exception handling.
1352         * cp-support.c: Use C++ exception handling.
1353         * cp-abi.c: Use C++ exception handling.
1354         * corelow.c: Use C++ exception handling.
1355         * completer.c: Use C++ exception handling.
1356         * compile/compile-object-run.c: Use C++ exception handling.
1357         * compile/compile-object-load.c: Use C++ exception handling.
1358         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1359         * compile/compile-c-symbols.c: Use C++ exception handling.
1360         * common/selftest.c: Use C++ exception handling.
1361         * common/new-op.c: Use C++ exception handling.
1362         * cli/cli-script.c: Use C++ exception handling.
1363         * cli/cli-interp.c: Use C++ exception handling.
1364         * cli/cli-cmds.c: Use C++ exception handling.
1365         * c-varobj.c: Use C++ exception handling.
1366         * btrace.c: Use C++ exception handling.
1367         * breakpoint.c: Use C++ exception handling.
1368         * break-catch-throw.c: Use C++ exception handling.
1369         * arch-utils.c: Use C++ exception handling.
1370         * amd64-tdep.c: Use C++ exception handling.
1371         * ada-valprint.c: Use C++ exception handling.
1372         * ada-typeprint.c: Use C++ exception handling.
1373         * ada-lang.c: Use C++ exception handling.
1374         * aarch64-tdep.c: Use C++ exception handling.
1375
1376 2019-04-08  Tom Tromey  <tom@tromey.com>
1377
1378         * xml-support.c (gdb_xml_parser::parse): Update.
1379         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1380         * value.c (show_convenience): Update.
1381         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1382         (test_parse_flags_qcs): Update.
1383         * thread.c (thr_try_catch_cmd): Update.
1384         * target.c (target_translate_tls_address): Update.
1385         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1386         (info_frame_command_core, frame_apply_command_count): Update.
1387         * rust-exp.y (rust_lex_exception_test): Update.
1388         * riscv-tdep.c (riscv_print_one_register_info): Update.
1389         * remote.c (remote_target::enable_btrace): Update.
1390         * record-btrace.c (record_btrace_enable_warn): Update.
1391         * python/py-utils.c (gdbpy_convert_exception): Update.
1392         * printcmd.c (do_one_display, print_variable_and_value): Update.
1393         * mi/mi-main.c (mi_print_exception): Update.
1394         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1395         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1396         * linux-nat.c (linux_nat_target::attach): Update.
1397         * linux-fork.c (class scoped_switch_fork_info): Update.
1398         * infrun.c (displaced_step_prepare): Update.
1399         * infcall.c (call_function_by_hand_dummy): Update.
1400         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1401         * gnu-v3-abi.c (print_one_vtable): Update.
1402         * frame.c (get_prev_frame_always): Update.
1403         * f-valprint.c (info_common_command_for_block): Update.
1404         * exec.c (try_open_exec_file): Update.
1405         * exceptions.c (print_exception, exception_print)
1406         (exception_fprintf, exception_print_same): Update.
1407         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1408         * dwarf-index-cache.c (index_cache::store)
1409         (index_cache::lookup_gdb_index): Update.
1410         * darwin-nat.c (maybe_cache_shell): Update.
1411         * cp-valprint.c (cp_print_value_fields): Update.
1412         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1413         (gcc_cplus_symbol_address): Update.
1414         * compile/compile-c-symbols.c (gcc_convert_symbol)
1415         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1416         * common/selftest.c: Update.
1417         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1418         a std::string.
1419         (exception_try_scope_entry, exception_try_scope_exit): Don't
1420         declare.
1421         (struct exception_try_scope): Remove.
1422         (TRY): Don't use exception_try_scope.
1423         (struct gdb_exception): Add constructor, operator=.
1424         <what>: New method.
1425         (struct gdb_exception_RETURN_MASK_ALL)
1426         (struct gdb_exception_RETURN_MASK_ERROR)
1427         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1428         (struct gdb_quit_bad_alloc): Update.
1429         * common/common-exceptions.c (exception_none): Change
1430         initializer.
1431         (struct catcher) <state, exception>: Initialize inline.
1432         <prev>: Remove member.
1433         (current_catcher): Remove.
1434         (catchers): New global.
1435         (exceptions_state_mc_init): Simplify.
1436         (catcher_pop): Remove.
1437         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1438         (try_scope_depth, exception_try_scope_entry)
1439         (exception_try_scope_exit): Remove.
1440         (throw_exception_sjlj): Update.
1441         (exception_messages, exception_messages_size): Remove.
1442         (throw_it): Simplify.
1443         (gdb_exception_sliced_copy): Remove.
1444         (throw_exception_cxx): Update.
1445         * cli/cli-script.c (script_from_file): Update.
1446         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1447         Update.
1448         * ada-valprint.c (ada_val_print): Update.
1449         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1450         (create_excep_cond_exprs): Update.
1451
1452 2019-04-08  Tom Tromey  <tom@tromey.com>
1453
1454         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1455         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1456         (TRY, CATCH, END_CATCH): Remove some definitions.
1457         * common/common-exceptions.c: Don't use GDB_XCPT.
1458         (catcher_list_size): Remove.
1459         (throw_exception, throw_it): Simplify.
1460
1461 2019-04-05  Tom Tromey  <tom@tromey.com>
1462
1463         Revert the header-sorting patch.
1464         * ft32-tdep.c: Revert.
1465         * frv-tdep.c: Revert.
1466         * frv-linux-tdep.c: Revert.
1467         * frame.c: Revert.
1468         * frame-unwind.c: Revert.
1469         * frame-base.c: Revert.
1470         * fork-child.c: Revert.
1471         * findvar.c: Revert.
1472         * findcmd.c: Revert.
1473         * filesystem.c: Revert.
1474         * filename-seen-cache.h: Revert.
1475         * filename-seen-cache.c: Revert.
1476         * fbsd-tdep.c: Revert.
1477         * fbsd-nat.h: Revert.
1478         * fbsd-nat.c: Revert.
1479         * f-valprint.c: Revert.
1480         * f-typeprint.c: Revert.
1481         * f-lang.c: Revert.
1482         * extension.h: Revert.
1483         * extension.c: Revert.
1484         * extension-priv.h: Revert.
1485         * expprint.c: Revert.
1486         * exec.h: Revert.
1487         * exec.c: Revert.
1488         * exceptions.c: Revert.
1489         * event-top.c: Revert.
1490         * event-loop.c: Revert.
1491         * eval.c: Revert.
1492         * elfread.c: Revert.
1493         * dwarf2read.h: Revert.
1494         * dwarf2read.c: Revert.
1495         * dwarf2loc.c: Revert.
1496         * dwarf2expr.h: Revert.
1497         * dwarf2expr.c: Revert.
1498         * dwarf2-frame.c: Revert.
1499         * dwarf2-frame-tailcall.c: Revert.
1500         * dwarf-index-write.h: Revert.
1501         * dwarf-index-write.c: Revert.
1502         * dwarf-index-common.c: Revert.
1503         * dwarf-index-cache.h: Revert.
1504         * dwarf-index-cache.c: Revert.
1505         * dummy-frame.c: Revert.
1506         * dtrace-probe.c: Revert.
1507         * disasm.h: Revert.
1508         * disasm.c: Revert.
1509         * disasm-selftests.c: Revert.
1510         * dictionary.c: Revert.
1511         * dicos-tdep.c: Revert.
1512         * demangle.c: Revert.
1513         * dcache.h: Revert.
1514         * dcache.c: Revert.
1515         * darwin-nat.h: Revert.
1516         * darwin-nat.c: Revert.
1517         * darwin-nat-info.c: Revert.
1518         * d-valprint.c: Revert.
1519         * d-namespace.c: Revert.
1520         * d-lang.c: Revert.
1521         * ctf.c: Revert.
1522         * csky-tdep.c: Revert.
1523         * csky-linux-tdep.c: Revert.
1524         * cris-tdep.c: Revert.
1525         * cris-linux-tdep.c: Revert.
1526         * cp-valprint.c: Revert.
1527         * cp-support.c: Revert.
1528         * cp-namespace.c: Revert.
1529         * cp-abi.c: Revert.
1530         * corelow.c: Revert.
1531         * corefile.c: Revert.
1532         * continuations.c: Revert.
1533         * completer.h: Revert.
1534         * completer.c: Revert.
1535         * complaints.c: Revert.
1536         * coffread.c: Revert.
1537         * coff-pe-read.c: Revert.
1538         * cli-out.h: Revert.
1539         * cli-out.c: Revert.
1540         * charset.c: Revert.
1541         * c-varobj.c: Revert.
1542         * c-valprint.c: Revert.
1543         * c-typeprint.c: Revert.
1544         * c-lang.c: Revert.
1545         * buildsym.c: Revert.
1546         * buildsym-legacy.c: Revert.
1547         * build-id.h: Revert.
1548         * build-id.c: Revert.
1549         * btrace.c: Revert.
1550         * bsd-uthread.c: Revert.
1551         * breakpoint.h: Revert.
1552         * breakpoint.c: Revert.
1553         * break-catch-throw.c: Revert.
1554         * break-catch-syscall.c: Revert.
1555         * break-catch-sig.c: Revert.
1556         * blockframe.c: Revert.
1557         * block.c: Revert.
1558         * bfin-tdep.c: Revert.
1559         * bfin-linux-tdep.c: Revert.
1560         * bfd-target.c: Revert.
1561         * bcache.c: Revert.
1562         * ax-general.c: Revert.
1563         * ax-gdb.h: Revert.
1564         * ax-gdb.c: Revert.
1565         * avr-tdep.c: Revert.
1566         * auxv.c: Revert.
1567         * auto-load.c: Revert.
1568         * arm-wince-tdep.c: Revert.
1569         * arm-tdep.c: Revert.
1570         * arm-symbian-tdep.c: Revert.
1571         * arm-pikeos-tdep.c: Revert.
1572         * arm-obsd-tdep.c: Revert.
1573         * arm-nbsd-tdep.c: Revert.
1574         * arm-nbsd-nat.c: Revert.
1575         * arm-linux-tdep.c: Revert.
1576         * arm-linux-nat.c: Revert.
1577         * arm-fbsd-tdep.c: Revert.
1578         * arm-fbsd-nat.c: Revert.
1579         * arm-bsd-tdep.c: Revert.
1580         * arch-utils.c: Revert.
1581         * arc-tdep.c: Revert.
1582         * arc-newlib-tdep.c: Revert.
1583         * annotate.h: Revert.
1584         * annotate.c: Revert.
1585         * amd64-windows-tdep.c: Revert.
1586         * amd64-windows-nat.c: Revert.
1587         * amd64-tdep.c: Revert.
1588         * amd64-sol2-tdep.c: Revert.
1589         * amd64-obsd-tdep.c: Revert.
1590         * amd64-obsd-nat.c: Revert.
1591         * amd64-nbsd-tdep.c: Revert.
1592         * amd64-nbsd-nat.c: Revert.
1593         * amd64-nat.c: Revert.
1594         * amd64-linux-tdep.c: Revert.
1595         * amd64-linux-nat.c: Revert.
1596         * amd64-fbsd-tdep.c: Revert.
1597         * amd64-fbsd-nat.c: Revert.
1598         * amd64-dicos-tdep.c: Revert.
1599         * amd64-darwin-tdep.c: Revert.
1600         * amd64-bsd-nat.c: Revert.
1601         * alpha-tdep.c: Revert.
1602         * alpha-obsd-tdep.c: Revert.
1603         * alpha-nbsd-tdep.c: Revert.
1604         * alpha-mdebug-tdep.c: Revert.
1605         * alpha-linux-tdep.c: Revert.
1606         * alpha-linux-nat.c: Revert.
1607         * alpha-bsd-tdep.c: Revert.
1608         * alpha-bsd-nat.c: Revert.
1609         * aix-thread.c: Revert.
1610         * agent.c: Revert.
1611         * addrmap.c: Revert.
1612         * ada-varobj.c: Revert.
1613         * ada-valprint.c: Revert.
1614         * ada-typeprint.c: Revert.
1615         * ada-tasks.c: Revert.
1616         * ada-lang.c: Revert.
1617         * aarch64-tdep.c: Revert.
1618         * aarch64-ravenscar-thread.c: Revert.
1619         * aarch64-newlib-tdep.c: Revert.
1620         * aarch64-linux-tdep.c: Revert.
1621         * aarch64-linux-nat.c: Revert.
1622         * aarch64-fbsd-tdep.c: Revert.
1623         * aarch64-fbsd-nat.c: Revert.
1624         * aarch32-linux-nat.c: Revert.
1625
1626 2019-04-05  Tom Tromey  <tom@tromey.com>
1627
1628         * ft32-tdep.c: Sort headers.
1629         * frv-tdep.c: Sort headers.
1630         * frv-linux-tdep.c: Sort headers.
1631         * frame.c: Sort headers.
1632         * frame-unwind.c: Sort headers.
1633         * frame-base.c: Sort headers.
1634         * fork-child.c: Sort headers.
1635         * findvar.c: Sort headers.
1636         * findcmd.c: Sort headers.
1637         * filesystem.c: Sort headers.
1638         * filename-seen-cache.h: Sort headers.
1639         * filename-seen-cache.c: Sort headers.
1640         * fbsd-tdep.c: Sort headers.
1641         * fbsd-nat.h: Sort headers.
1642         * fbsd-nat.c: Sort headers.
1643         * f-valprint.c: Sort headers.
1644         * f-typeprint.c: Sort headers.
1645         * f-lang.c: Sort headers.
1646         * extension.h: Sort headers.
1647         * extension.c: Sort headers.
1648         * extension-priv.h: Sort headers.
1649         * expprint.c: Sort headers.
1650         * exec.h: Sort headers.
1651         * exec.c: Sort headers.
1652         * exceptions.c: Sort headers.
1653         * event-top.c: Sort headers.
1654         * event-loop.c: Sort headers.
1655         * eval.c: Sort headers.
1656         * elfread.c: Sort headers.
1657         * dwarf2read.h: Sort headers.
1658         * dwarf2read.c: Sort headers.
1659         * dwarf2loc.c: Sort headers.
1660         * dwarf2expr.h: Sort headers.
1661         * dwarf2expr.c: Sort headers.
1662         * dwarf2-frame.c: Sort headers.
1663         * dwarf2-frame-tailcall.c: Sort headers.
1664         * dwarf-index-write.h: Sort headers.
1665         * dwarf-index-write.c: Sort headers.
1666         * dwarf-index-common.c: Sort headers.
1667         * dwarf-index-cache.h: Sort headers.
1668         * dwarf-index-cache.c: Sort headers.
1669         * dummy-frame.c: Sort headers.
1670         * dtrace-probe.c: Sort headers.
1671         * disasm.h: Sort headers.
1672         * disasm.c: Sort headers.
1673         * disasm-selftests.c: Sort headers.
1674         * dictionary.c: Sort headers.
1675         * dicos-tdep.c: Sort headers.
1676         * demangle.c: Sort headers.
1677         * dcache.h: Sort headers.
1678         * dcache.c: Sort headers.
1679         * darwin-nat.h: Sort headers.
1680         * darwin-nat.c: Sort headers.
1681         * darwin-nat-info.c: Sort headers.
1682         * d-valprint.c: Sort headers.
1683         * d-namespace.c: Sort headers.
1684         * d-lang.c: Sort headers.
1685         * ctf.c: Sort headers.
1686         * csky-tdep.c: Sort headers.
1687         * csky-linux-tdep.c: Sort headers.
1688         * cris-tdep.c: Sort headers.
1689         * cris-linux-tdep.c: Sort headers.
1690         * cp-valprint.c: Sort headers.
1691         * cp-support.c: Sort headers.
1692         * cp-namespace.c: Sort headers.
1693         * cp-abi.c: Sort headers.
1694         * corelow.c: Sort headers.
1695         * corefile.c: Sort headers.
1696         * continuations.c: Sort headers.
1697         * completer.h: Sort headers.
1698         * completer.c: Sort headers.
1699         * complaints.c: Sort headers.
1700         * coffread.c: Sort headers.
1701         * coff-pe-read.c: Sort headers.
1702         * cli-out.h: Sort headers.
1703         * cli-out.c: Sort headers.
1704         * charset.c: Sort headers.
1705         * c-varobj.c: Sort headers.
1706         * c-valprint.c: Sort headers.
1707         * c-typeprint.c: Sort headers.
1708         * c-lang.c: Sort headers.
1709         * buildsym.c: Sort headers.
1710         * buildsym-legacy.c: Sort headers.
1711         * build-id.h: Sort headers.
1712         * build-id.c: Sort headers.
1713         * btrace.c: Sort headers.
1714         * bsd-uthread.c: Sort headers.
1715         * breakpoint.h: Sort headers.
1716         * breakpoint.c: Sort headers.
1717         * break-catch-throw.c: Sort headers.
1718         * break-catch-syscall.c: Sort headers.
1719         * break-catch-sig.c: Sort headers.
1720         * blockframe.c: Sort headers.
1721         * block.c: Sort headers.
1722         * bfin-tdep.c: Sort headers.
1723         * bfin-linux-tdep.c: Sort headers.
1724         * bfd-target.c: Sort headers.
1725         * bcache.c: Sort headers.
1726         * ax-general.c: Sort headers.
1727         * ax-gdb.h: Sort headers.
1728         * ax-gdb.c: Sort headers.
1729         * avr-tdep.c: Sort headers.
1730         * auxv.c: Sort headers.
1731         * auto-load.c: Sort headers.
1732         * arm-wince-tdep.c: Sort headers.
1733         * arm-tdep.c: Sort headers.
1734         * arm-symbian-tdep.c: Sort headers.
1735         * arm-pikeos-tdep.c: Sort headers.
1736         * arm-obsd-tdep.c: Sort headers.
1737         * arm-nbsd-tdep.c: Sort headers.
1738         * arm-nbsd-nat.c: Sort headers.
1739         * arm-linux-tdep.c: Sort headers.
1740         * arm-linux-nat.c: Sort headers.
1741         * arm-fbsd-tdep.c: Sort headers.
1742         * arm-fbsd-nat.c: Sort headers.
1743         * arm-bsd-tdep.c: Sort headers.
1744         * arch-utils.c: Sort headers.
1745         * arc-tdep.c: Sort headers.
1746         * arc-newlib-tdep.c: Sort headers.
1747         * annotate.h: Sort headers.
1748         * annotate.c: Sort headers.
1749         * amd64-windows-tdep.c: Sort headers.
1750         * amd64-windows-nat.c: Sort headers.
1751         * amd64-tdep.c: Sort headers.
1752         * amd64-sol2-tdep.c: Sort headers.
1753         * amd64-obsd-tdep.c: Sort headers.
1754         * amd64-obsd-nat.c: Sort headers.
1755         * amd64-nbsd-tdep.c: Sort headers.
1756         * amd64-nbsd-nat.c: Sort headers.
1757         * amd64-nat.c: Sort headers.
1758         * amd64-linux-tdep.c: Sort headers.
1759         * amd64-linux-nat.c: Sort headers.
1760         * amd64-fbsd-tdep.c: Sort headers.
1761         * amd64-fbsd-nat.c: Sort headers.
1762         * amd64-dicos-tdep.c: Sort headers.
1763         * amd64-darwin-tdep.c: Sort headers.
1764         * amd64-bsd-nat.c: Sort headers.
1765         * alpha-tdep.c: Sort headers.
1766         * alpha-obsd-tdep.c: Sort headers.
1767         * alpha-nbsd-tdep.c: Sort headers.
1768         * alpha-mdebug-tdep.c: Sort headers.
1769         * alpha-linux-tdep.c: Sort headers.
1770         * alpha-linux-nat.c: Sort headers.
1771         * alpha-bsd-tdep.c: Sort headers.
1772         * alpha-bsd-nat.c: Sort headers.
1773         * aix-thread.c: Sort headers.
1774         * agent.c: Sort headers.
1775         * addrmap.c: Sort headers.
1776         * ada-varobj.c: Sort headers.
1777         * ada-valprint.c: Sort headers.
1778         * ada-typeprint.c: Sort headers.
1779         * ada-tasks.c: Sort headers.
1780         * ada-lang.c: Sort headers.
1781         * aarch64-tdep.c: Sort headers.
1782         * aarch64-ravenscar-thread.c: Sort headers.
1783         * aarch64-newlib-tdep.c: Sort headers.
1784         * aarch64-linux-tdep.c: Sort headers.
1785         * aarch64-linux-nat.c: Sort headers.
1786         * aarch64-fbsd-tdep.c: Sort headers.
1787         * aarch64-fbsd-nat.c: Sort headers.
1788         * aarch32-linux-nat.c: Sort headers.
1789
1790 2019-04-04  Tom Tromey  <tom@tromey.com>
1791
1792         * varobj.c (varobj_create): Update.
1793         * rust-exp.y (struct rust_parser) <update_innermost_block,
1794         lookup_symbol>: New methods.
1795         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1796         Rename.
1797         (rust_parser::rust_lookup_type)
1798         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1799         * printcmd.c (display_command, do_one_display): Update.
1800         * parser-defs.h (struct parser_state) <parser_state>: Add
1801         "tracker" parameter.
1802         (block_tracker): New member.
1803         (class innermost_block_tracker) <innermost_block_tracker>: Add
1804         "types" parameter.
1805         <reset>: Remove method.
1806         (innermost_block): Don't declare.
1807         (null_post_parser): Update.
1808         * parse.c (innermost_block): Remove global.
1809         (write_dollar_variable): Update.
1810         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1811         Remove "tracker_types" parameter.
1812         (parse_expression): Add "tracker" parameter.
1813         (parse_expression_for_completion): Update.
1814         (null_post_parser): Add "tracker" parameter.
1815         * p-exp.y: Update rules.
1816         * m2-exp.y: Update rules.
1817         * language.h (struct language_defn) <la_post_parser>: Add
1818         "tracker" parameter.
1819         * go-exp.y: Update rules.
1820         * f-exp.y: Update rules.
1821         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1822         parameter.
1823         * d-exp.y: Update rules.
1824         * c-exp.y: Update rules.
1825         * breakpoint.c (set_breakpoint_condition): Create an
1826         innermost_block_tracker.
1827         (watch_command_1): Likewise.
1828         * ada-lang.c (resolve): Add "tracker" parameter.
1829         (resolve_subexp): Likewise.
1830         * ada-exp.y (write_var_from_sym): Update.
1831
1832 2019-04-04  Tom Tromey  <tom@tromey.com>
1833
1834         * type-stack.h: New file.
1835         * type-stack.c: New file.
1836         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1837         type-stack.h.
1838         (insert_into_type_stack, insert_type, push_type, push_type_int)
1839         (insert_type_address_space, pop_type, pop_type_int)
1840         (pop_typelist, pop_type_stack, append_type_stack)
1841         (push_type_stack, get_type_stack, push_typelist)
1842         (follow_type_instance_flags, follow_types): Don't declare.
1843         * parse.c (type_stack): Remove global.
1844         (parse_exp_in_context): Update.
1845         (insert_into_type_stack, insert_type, push_type, push_type_int)
1846         (insert_type_address_space, pop_type, pop_type_int)
1847         (pop_typelist, pop_type_stack, append_type_stack)
1848         (push_type_stack, get_type_stack, push_typelist)
1849         (follow_type_instance_flags, follow_types): Remove (moved to
1850         type-stack.c).
1851         * f-exp.y (type_stack): New global.
1852         Update rules.
1853         (push_kind_type, f_parse): Update.
1854         * d-exp.y (type_stack): New global.
1855         Update rules.
1856         (d_parse): Update.
1857         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1858         Update rules.
1859         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1860         (HFILES_NO_SRCDIR): Add type-stack.h.
1861
1862 2019-04-04  Tom Tromey  <tom@tromey.com>
1863
1864         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1865         (rust_parser::convert_ast_to_expression, rust_parse)
1866         (rust_lex_test_completion, rust_lex_tests): Update.
1867         * parser-defs.h (struct expr_completion_state): New.
1868         (struct parser_state) <parser_state>: Add completion parameter.
1869         <mark_struct_expression, mark_completion_tag>: New methods.
1870         <parse_completion, m_completion_state>: New members.
1871         (prefixify_expression, null_post_parser): Update.
1872         (mark_struct_expression, mark_completion_tag): Don't declare.
1873         * parse.c (parse_completion, expout_last_struct)
1874         (expout_tag_completion_type, expout_completion_name): Remove
1875         globals.
1876         (parser_state::mark_struct_expression)
1877         (parser_state::mark_completion_tag): Now methods.
1878         (prefixify_expression): Add last_struct parameter.
1879         (prefixify_subexp): Likewise.
1880         (parse_exp_1): Update.
1881         (parse_exp_in_context): Add cstate parameter.  Update.
1882         (parse_expression_for_completion): Create an
1883         expr_completion_state.
1884         (null_post_parser): Add "completion" parameter.
1885         * p-exp.y: Update rules.
1886         (yylex): Update.
1887         * language.h (struct language_defn) <la_post_parser>: Add
1888         "completing" parameter.
1889         * go-exp.y: Update rules.
1890         (lex_one_token): Update.
1891         * expression.h (parse_completion): Don't declare.
1892         * d-exp.y: Update rules.
1893         (lex_one_token): Update rules.
1894         * c-exp.y: Update rules.
1895         (lex_one_token): Update.
1896         * ada-lang.c (resolve): Add "parse_completion" parameter.
1897         (resolve_subexp): Likewise.
1898         (ada_resolve_function): Likewise.
1899
1900 2019-04-04  Tom Tromey  <tom@tromey.com>
1901
1902         * parser-defs.h (struct parser_state) <start_arglist,
1903         end_arglist>: New methods.
1904         <arglist_len, m_funcall_chain>: New members.
1905         (arglist_len, start_arglist, end_arglist): Don't declare.
1906         * parse.c (arglist_len, funcall_chain): Remove global.
1907         (start_arglist, end_arglist): Remove functions.
1908         (parse_exp_in_context): Update.
1909         * p-exp.y: Update rules.
1910         * m2-exp.y: Update rules.
1911         * go-exp.y: Update rules.
1912         * f-exp.y: Update rules.
1913         * d-exp.y: Update rules.
1914         * c-exp.y: Update rules.
1915
1916 2019-04-04  Tom Tromey  <tom@tromey.com>
1917
1918         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1919         lex_operator, push_back>: New methods.
1920         Update all rules.
1921         (rust_parser::lex_hex, lex_escape): Rename and update.
1922         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1923         (rust_parser::lex_operator): Rename and update.
1924         (rust_parser::lex_number, rustyylex, rustyyerror)
1925         (rust_lex_test_init, rust_lex_test_sequence)
1926         (rust_lex_test_push_back, rust_lex_tests): Update.
1927         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1928         parameter.
1929         <lexptr, prev_lexptr>: New members.
1930         (lexptr, prev_lexptr): Don't declare.
1931         * parse.c (lexptr, prev_lexptr): Remove globals.
1932         (parse_exp_in_context): Update.
1933         * p-exp.y (yylex, yyerror): Update.
1934         * m2-exp.y (parse_number, yylex, yyerror): Update.
1935         * go-exp.y (lex_one_token, yyerror): Update.
1936         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1937         * d-exp.y (lex_one_token, yyerror): Update.
1938         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1939         (lex_one_token, yyerror): Update.
1940         * ada-lex.l (YY_INPUT): Update.
1941         (rewind_to_char): Update.
1942         * ada-exp.y (yyerror): Update.
1943
1944 2019-04-04  Tom Tromey  <tom@tromey.com>
1945
1946         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1947         * parser-defs.h (struct parser_state) <parser_state>: Add new
1948         parameter.
1949         <comma_terminates>: New member.
1950         (comma_terminates): Don't declare global.
1951         * parse.c (comma_terminates): Remove global.
1952         (parse_exp_in_context): Update.
1953         * p-exp.y (yylex): Update.
1954         * m2-exp.y (yylex): Update.
1955         * go-exp.y (lex_one_token): Update.
1956         * f-exp.y (yylex): Update.
1957         * d-exp.y (lex_one_token): Update.
1958         * c-exp.y (lex_one_token): Update.
1959         * ada-lex.l: Update.
1960
1961 2019-04-04  Tom Tromey  <tom@tromey.com>
1962
1963         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1964         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1965         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1966         * parser-defs.h (paren_depth): Don't declare.
1967         * parse.c (paren_depth): Remove global.
1968         (parse_exp_in_context): Update.
1969         * p-exp.y (paren_depth): New global.
1970         (pascal_parse): Initialize it.
1971         * m2-exp.y (paren_depth): New global.
1972         (m2_parse): Initialize it.
1973         * go-exp.y (paren_depth): New global.
1974         (go_parse): Initialize it.
1975         * f-exp.y (paren_depth): New global.
1976         (f_parse): Initialize it.
1977         * d-exp.y (paren_depth): New global.
1978         (d_parse): Initialize it.
1979         * c-exp.y (paren_depth): New global.
1980         (c_parse): Initialize it.
1981         * ada-lex.l (paren_depth): New global.
1982         (lexer_init): Initialize it.
1983
1984 2019-04-04  Tom Tromey  <tom@tromey.com>
1985
1986         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1987         (rust_parser::convert_ast_to_type)
1988         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1989         * parser-defs.h (struct parser_state) <parser_state>: Add
1990         parameters.  Initialize new members.
1991         <expression_context_block, expression_context_pc>: New members.
1992         * parse.c (expression_context_block, expression_context_pc):
1993         Remove globals.
1994         (parse_exp_in_context): Update.
1995         * p-exp.y: Update all rules.
1996         (yylex): Update.
1997         * m2-exp.y: Update all rules.
1998         (yylex): Update.
1999         * go-exp.y (yylex): Update.
2000         * f-exp.y (yylex): Update.
2001         * d-exp.y: Update all rules.
2002         (yylex): Update.
2003         * c-exp.y: Update all rules.
2004         (lex_one_token, classify_name, yylex, c_parse): Update.
2005         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2006
2007 2019-04-04  Tom Tromey  <tom@tromey.com>
2008
2009         * gdbarch.h, gdbarch.c: Rebuild.
2010         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2011         * stap-probe.h:
2012         (struct stap_parse_info): Replace "parser_state" with
2013         "expr_builder".
2014         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2015         (parser_state): New class.
2016         * parse.c (expr_builder): Rename.
2017         (expr_builder::release): Rename.
2018         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2019         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2020         (write_exp_elt_longcst, write_exp_elt_floatcst)
2021         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2022         (write_exp_string_vector, write_exp_bitstring)
2023         (write_exp_msymbol, mark_struct_expression)
2024         (write_dollar_variable)
2025         (insert_type_address_space, increase_expout_size): Replace
2026         "parser_state" with "expr_builder".
2027         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2028         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2029         "parser_state" with "expr_builder".
2030
2031 2019-04-04  Tom Tromey  <tom@tromey.com>
2032
2033         * rust-exp.y: Replace "parse_language" with method call.
2034         * p-exp.y:
2035         (yylex): Replace "parse_language" with method call.
2036         * m2-exp.y:
2037         (yylex): Replace "parse_language" with method call.
2038         * go-exp.y (classify_name): Replace "parse_language" with method
2039         call.
2040         * f-exp.y (yylex): Replace "parse_language" with method call.
2041         * d-exp.y (lex_one_token): Replace "parse_language" with method
2042         call.
2043         * c-exp.y:
2044         (lex_one_token, classify_name, yylex): Replace "parse_language"
2045         with method call.
2046         * ada-exp.y (find_primitive_type, type_char)
2047         (type_system_address): Replace "parse_language" with method call.
2048
2049 2019-04-04  Tom Tromey  <tom@tromey.com>
2050
2051         * rust-exp.y: Replace "parse_gdbarch" with method call.
2052         * parse.c (write_dollar_variable, insert_type_address_space):
2053         Replace "parse_gdbarch" with method call.
2054         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2055         call.
2056         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2057         call.
2058         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2059         "parse_gdbarch" with method call.
2060         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2061         with method call.
2062         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2063         "parse_gdbarch" with method call.
2064         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2065         "parse_gdbarch" with method call.
2066         * c-exp.y (parse_type, parse_number, classify_name): Replace
2067         "parse_gdbarch" with method call.
2068         * ada-lex.l: Replace "parse_gdbarch" with method call.
2069         * ada-exp.y (parse_type, find_primitive_type, type_char)
2070         (type_system_address): Replace "parse_gdbarch" with method call.
2071
2072 2019-04-04  Tom Tromey  <tom@tromey.com>
2073
2074         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2075         * stap-probe.c (stap_parse_argument): Update.
2076         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2077         initial_size parameter.
2078         * rust-exp.y (rust_lex_tests): Update.
2079         * parse.c (parser_state): Update.
2080         (parse_exp_in_context): Update.
2081         * parser-defs.h (struct parser_state) <parser_state>: Remove
2082         "initial_size" parameter.
2083
2084 2019-04-04  Tom Tromey  <tom@tromey.com>
2085
2086         * parser-defs.h (increase_expout_size): Don't declare.
2087         * parse.c (increase_expout_size): Now static.
2088
2089 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2090
2091         * gnu-nat.c (gnu_nat_target::wait): Fix
2092         target_waitstatus_to_string call.
2093
2094 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2095
2096         * eval.c (evaluate_subexp_standard): Handle internal functions
2097         during Fortran function call handling.
2098
2099 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2100
2101         * NEWS: Mention new internal functions.
2102         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2103         (read_base_type): Use dwarf2_init_complex_target_type.
2104         * value.c (creal_internal_fn): New function.
2105         (cimag_internal_fn): New function.
2106         (_initialize_values): Register new internal functions.
2107
2108 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2109
2110         * infrun.c (stop_all_threads): If debug_infrun, always
2111         trace the wait status after wait_one, using
2112         target_waitstatus_to_string and target_pid_to_str.
2113         (handle_inferior_event): Replace various trace of
2114         wait status kind by a single trace.
2115         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2116         wait status kind image by target_waitstatus_to_string.
2117         * target/waitstatus.c (target_waitstatus_to_string): Fix
2118         obsolete comment.
2119
2120 2019-04-01  Tom Tromey  <tromey@adacore.com>
2121
2122         PR symtab/23331:
2123         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2124
2125 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2126             Pedro Alves  <palves@redhat.com>
2127
2128         * top.c (quit_force): Call 'finalize_values'.
2129         * value.c (finalize_values): New function.
2130         * value.h (finalize_values): Declare.
2131
2132 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2133
2134         * NEWS: Announce $_gdb_major and $_gdb_minor.
2135
2136         * top.c (init_gdb_version_vars): New function.
2137         (gdb_init): Call init_gdb_version_vars.
2138
2139 2019-03-29  Tom Tromey  <tromey@adacore.com>
2140
2141         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2142         help text.  Remove dead code.
2143
2144 2019-03-29  Keith Seitz  <keiths@redhat.com>
2145
2146         From Siddhesh Poyarekar:
2147         * f-lang.h (f77_get_upperbound): Return LONGEST.
2148         (f77_get_lowerbound): Likewise.
2149         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2150         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2151         print them.
2152         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2153         plongest to format print it.
2154         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2155         (f77_get_upperbound): Likewise.
2156         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2157         LOWER_BOUND to LONGEST.
2158         (f77_create_arrayprint_offset_tbl): Likewise.
2159
2160 2019-03-29  Keith Seitz  <keiths@redhat.com>
2161
2162         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2163         %s/pulongest for TYPE_LENGTH instead of %d in format
2164         strings.
2165         * ada-typerint.c (ada_print_type): Likewise.
2166         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2167         * compile/compile-c-support.c (generate_register_struct): Likewise.
2168         * gdbtypes.c (recursive_dump_type): Likewise.
2169         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2170         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2171         instead of %d in format strings.
2172         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2173         to std::min to ULONGEST.
2174         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2175         instead of %d in format strings.
2176         * tracepoint.c (info_scope_command): Likewise.
2177         * typeprint.c (print_offset_data::update)
2178         (print_offset_data::finish): Likewise.
2179         * xtensa-tdep.c (xtensa_store_return_value)
2180         (xtensa_push_dummy_call): Likewise.
2181
2182 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2183
2184         * windows-nat.c (display_selector): Fixed format specifications
2185         for 64-bit Cygwin.
2186
2187 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2188
2189         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2190
2191 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2192
2193         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2194         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2195         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2196         (nios2_linux_init_abi): Install it.
2197
2198 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2199
2200         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2201
2202 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2203
2204         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2205
2206 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2207             Tom Tromey  <tromey@adacore.com>
2208
2209         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2210
2211 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2212
2213         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2214         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2215         method to compute the bounds of range types. Also print "[evaluated]"
2216         if the bounds' values come from a dynamic evaluation.
2217
2218 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2219
2220         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2221         whitespace when pretty printing is on.
2222
2223 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2224
2225         * ppc-linux-nat.c: Add include.
2226
2227 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2228
2229         * NEWS: Mention AArch64 Pointer Authentication.
2230
2231 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2232
2233         * arm-linux-nat.c: Add include.
2234
2235 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2236
2237         * source-cache.c (source_cache::get_source_lines): Re-read
2238         fullname after calling open_source_file.
2239
2240 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2241
2242         * NEWS: Mention TLS support for FreeBSD.
2243
2244 2019-03-25  Tom Tromey  <tromey@adacore.com>
2245
2246         * minsyms.c (BUNCH_SIZE): Update comment.
2247         (~minimal_symbol_reader): Remove old comment.
2248         (compact_minimal_symbols): Update comment.
2249         (minimal_symbol_reader::install): Remove old comment.  Update
2250         other comments.
2251
2252 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2253
2254         * s390-linux-nat.c: Add include.
2255
2256 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2257
2258         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2259         Call linux_get_hwcap.
2260         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2261         Likewise.
2262         (aarch64_linux_get_hwcap): Remove function.
2263         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2264         declaration.
2265         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2266         linux_get_hwcap.
2267         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2268         * linux-tdep.c (linux_get_hwcap): Add function.
2269         (linux_get_hwcap2): Likewise.
2270         * linux-tdep.h (linux_get_hwcap): Add declaration.
2271         (linux_get_hwcap2): Likewise.
2272         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2273         (ppc_linux_get_hwcap2): Likewise.
2274         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2275         linux_get_hwcap.
2276         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2277         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2278         (ppc_linux_nat_target::read_description): Likewise.
2279         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2280         * s390-linux-nat.c: Likewise.
2281         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2282
2283 2019-03-24  Tom Tromey  <tom@tromey.com>
2284
2285         * ada-lang.c (standard_lookup): Simplify initialization.
2286         (ada_lookup_symbol_nonlocal): Simplify return.
2287         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2288         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2289         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2290         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2291         initialization.
2292         * solib.c (solib_global_lookup): Simplify.
2293         * symtab.c (null_block_symbol): Remove.
2294         (symbol_cache_lookup): Simplify returns.
2295         (lookup_language_this): Simplify returns.
2296         (lookup_symbol_aux): Simplify return.
2297         (lookup_local_symbol): Simplify returns.
2298         (lookup_global_symbol_from_objfile): Simplify return.
2299         (lookup_symbol_in_objfile_symtabs)
2300         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2301         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2302         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2303         * cp-namespace.c (cp_lookup_bare_symbol)
2304         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2305         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2306         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2307         (cp_lookup_symbol_via_imports): Simplify initialization.
2308         (find_symbol_in_baseclass): Likewise.
2309         * symtab.h (null_block_symbol): Remove.
2310         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2311         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2312         (d_lookup_symbol_module): Likewise.
2313         (find_symbol_in_baseclass): Simplify initialization.
2314
2315 2019-03-24  Tom Tromey  <tom@tromey.com>
2316
2317         * expression.h: Don't include symtab.h.
2318         (struct block): Forward declare.
2319
2320 2019-03-24  Tom Tromey  <tom@tromey.com>
2321
2322         * c-exp.y (typebase): Remove casts.
2323         * gdbtypes.c (lookup_unsigned_typename, )
2324         (lookup_signed_typename): Remove cast.
2325         * eval.c (parse_to_comma_and_eval): Remove cast.
2326         * parse.c (write_dollar_variable): Remove cast.
2327         * block.h (struct block) <superblock>: Now const.
2328         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2329         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2330         (map_block): Make "block" const.
2331         * symfile.h (struct quick_symbol_functions)
2332         <map_matching_symbols>: Constify block argument to "callback".
2333         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2334         const.
2335         (find_pc_sect_compunit_symtab): Make "b" const.
2336         (find_symbol_at_address): Likewise.
2337         (search_symbols): Likewise.
2338         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2339         (dw2_debug_names_lookup_symbol): Likewise.
2340         (dw2_map_matching_symbols): Update.
2341         * p-valprint.c (pascal_val_print): Remove "block".
2342         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2343         (aux_add_nonlocal_symbols): Make "block" const.
2344         (resolve_subexp): Remove cast.
2345         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2346         const.
2347         (iterate_over_file_blocks): Likewise.
2348         * f-exp.y (%union) <bval>: Remove.
2349         * coffread.c (patch_opaque_types): Make "b" const.
2350         * spu-tdep.c (spu_catch_start): Make "block" const.
2351         * c-valprint.c (print_unpacked_pointer): Remove "block".
2352         * symmisc.c (dump_symtab_1): Make "b" const.
2353         (block_depth): Make "block" const.
2354         * d-exp.y (%union) <bval>: Remove.
2355         * cp-support.h (cp_lookup_rtti_type): Update.
2356         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2357         * psymtab.c (psym_lookup_symbol): Make "block" const.
2358         (maintenance_check_psymtabs): Make "b" const.
2359         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2360         (enumerate_locals, enumerate_args): Update.
2361         * python/py-symtab.c (stpy_global_block): Make "block" const.
2362         (stpy_static_block): Likewise.
2363         * inline-frame.c (block_starting_point_at): Make "new_block"
2364         const.
2365         * block.c (find_block_in_blockvector): Make return type const.
2366         (blockvector_for_pc_sect): Make "b" const.
2367         (find_block_in_blockvector): Make "b" const.
2368
2369 2019-03-23  Tom Tromey  <tom@tromey.com>
2370
2371         * varobj.c (varobj_create): Update.
2372         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2373         * printcmd.c (display_command, do_one_display): Don't reset
2374         innermost_block.
2375         * parser-defs.h (enum innermost_block_tracker_type): Move to
2376         expression.h.
2377         (innermost_block): Update comment.
2378         * parse.c (parse_exp_1): Add tracker_types parameter.
2379         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2380         tracker_types parameter.  Reset innermost_block.
2381         (parse_exp_in_context): Remove.
2382         (parse_expression_for_completion): Update.
2383         * objfiles.c (~objfile): Don't reset expression_context_block or
2384         innermost_block.
2385         * expression.h (enum innermost_block_tracker_type): Move from
2386         parser-defs.h.
2387         (parse_exp_1): Add tracker_types parameter.
2388         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2389         reset innermost_block.
2390
2391 2019-03-23  Tom Tromey  <tom@tromey.com>
2392
2393         * objfiles.h: Include bcache.h.
2394
2395 2019-03-23  Tom Tromey  <tom@tromey.com>
2396
2397         * linespec.c (get_current_search_block): Use
2398         scoped_restore_current_language.
2399         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2400
2401 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2402             Jiong Wang  <jiong.wang@arm.com>
2403
2404         * aarch64-linux-tdep.c
2405         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2406         section.
2407         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2408
2409 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2410             Jiong Wang  <jiong.wang@arm.com>
2411
2412         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2413         instructions.
2414         (aarch64_analyze_prologue_test): Add PACIASP test.
2415         (aarch64_prologue_prev_register): Unmask PC value.
2416
2417 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2418             Jiong Wang  <jiong.wang@arm.com>
2419
2420         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2421         (aarch64_dwarf2_prev_register): Unmask PC value.
2422         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2423         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2424         DW_CFA_AARCH64_negate_ra_state.
2425         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2426
2427 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2428             Jiong Wang  <jiong.wang@arm.com>
2429
2430         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2431         registers.
2432         (aarch64_pseudo_register_name): Likewise.
2433         (aarch64_pseudo_register_type): Likewise.
2434         (aarch64_pseudo_register_reggroup_p): Likewise.
2435         (aarch64_gdbarch_init): Add pauth registers.
2436         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2437         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2438         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2439         (struct gdbarch_tdep): Add regnum for ra_state.
2440
2441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2442             Jiong Wang  <jiong.wang@arm.com>
2443
2444         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2445
2446 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2447             Jiong Wang  <jiong.wang@arm.com>
2448
2449         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2450         function.
2451         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2452         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2453         (aarch64_gdbarch_init): Add puth registers.
2454         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2455         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2456         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2457
2458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2459             Jiong Wang  <jiong.wang@arm.com>
2460
2461         * aarch64-linux-nat.c
2462         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2463         * aarch64-linux-tdep.c
2464         (aarch64_linux_core_read_description): Likewise.
2465         (aarch64_linux_get_hwcap): New function.
2466         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2467         (aarch64_linux_get_hwcap): New declaration.
2468
2469 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2470             Jiong Wang  <jiong.wang@arm.com>
2471
2472         * aarch64-linux-nat.c
2473         (aarch64_linux_nat_target::read_description): Add pauth param.
2474         * aarch64-linux-tdep.c
2475         (aarch64_linux_core_read_description): Likewise.
2476         * aarch64-tdep.c (struct target_desc): Add in pauth.
2477         (aarch64_read_description): Add pauth param.
2478         (aarch64_gdbarch_init): Likewise.
2479         * aarch64-tdep.h (aarch64_read_description): Likewise.
2480         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2481         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2482         * features/Makefile: Add new files.
2483         * features/aarch64-pauth.c: New file.
2484         * features/aarch64-pauth.xml: New file.
2485
2486 2019-03-20  Tom Tromey  <tromey@adacore.com>
2487
2488         * infrun.c (handle_inferior_event): Rename from
2489         handle_inferior_event_1.  Create a scoped_value_mark.
2490         (handle_inferior_event): Remove.
2491
2492 2019-03-19  Tom Tromey  <tromey@adacore.com>
2493
2494         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2495         * infrun.h (print_stop_event): Add "displays" parameter.
2496         * infrun.c (print_stop_event): Add "displays" parameter.
2497
2498 2019-03-19  Pedro Alves  <palves@redhat.com>
2499
2500         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2501         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2502         to -1.  Fix TABs vs spaces.
2503         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2504         * tui/tui-out.h (tui_ui_out) Add intro comments.
2505         <m_line, m_start_of_line>: In-class initialize, and add describing
2506         comment.
2507
2508 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2509
2510         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2511         variable names.
2512         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2513
2514 2019-03-18  Pedro Alves  <palves@redhat.com>
2515             Eli Zaretskii <eliz@gnu.org>
2516
2517         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2518         m_line and m_start_of_line.
2519
2520 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2521
2522         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2523         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2524         it returns a newline.  This fixes a regression in TU mode, whereby
2525         the next line is output on the same screen line as the user input.
2526
2527 2019-03-18  Tom Tromey  <tromey@adacore.com>
2528
2529         * minsyms.c (minimal_symbol_reader::install): Remove call to
2530         obstack_blank.
2531
2532 2019-03-18  Pedro Alves  <palves@redhat.com>
2533
2534         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2535         New globals.
2536         (apply_style): New, factored out from ...
2537         (apply_ansi_escape): ... this.  Handle reverse video mode.
2538         (tui_set_reverse_mode): New function.
2539         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2540         * tui/tui-winsource.c (tui_show_source_line): Use
2541         tui_set_reverse_mode instead of setting A_STANDOUT.
2542         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2543         New setter methods.
2544
2545 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2546
2547         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2548         Handle tabs.
2549
2550 2019-03-18  Tom Tromey  <tromey@adacore.com>
2551
2552         * ada-lang.c (empty_array): Add "high" parameter.
2553         (ada_evaluate_subexp): Update.
2554
2555 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2556
2557         * unittests/string_view-selftests.c: Define
2558         _initialize_string_view_selftests unconditionally.
2559
2560 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2561
2562         PR gdb/24350
2563         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2564
2565 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2566
2567         PR gdb/24351
2568         * windows-nat.c (display_selector): Fix format specifiers.
2569
2570 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2571
2572         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2573         tui_refill_source_window instead of tui_refresh_win, to update the
2574         current execution line.  This fixes redisplay of the current line
2575         when stepping through the code with "next" or "step".
2576
2577 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2578
2579         * source-cache.c (source_cache::get_source_lines): Call
2580         find_source_lines to initialize s->nlines.  This fixes vertical
2581         scrolling of TUI source window when the DOWN arrow is pressed.
2582
2583 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2584
2585         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2586         linux-thread-db.c (_initialize_thread_db): Likewise.
2587
2588 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2589
2590         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2591         wclrtoeol in tui_show_source_line".  This reverts changes made in
2592         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2593
2594 2019-03-15  Tom Tromey  <tom@tromey.com>
2595
2596         * symtab.h (struct minimal_symbol): Derive from
2597         general_symbol_info.
2598         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2599         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2600         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2601         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2602         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2603         (MSYMBOL_SEARCH_NAME): Update.
2604         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2605         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2606         * minsyms.c (minimal_symbol_reader::record_full): Update.
2607
2608 2019-03-15  Tom Tromey  <tom@tromey.com>
2609
2610         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2611
2612 2019-03-15  Tom Tromey  <tom@tromey.com>
2613
2614         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2615         unique_xmalloc_ptr.
2616         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2617         Update.
2618         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2619         (build_minimal_symbol_hash_tables)
2620         (minimal_symbol_reader::install): Update.
2621
2622 2019-03-15  Tom Tromey  <tom@tromey.com>
2623
2624         * symtab.c (create_demangled_names_hash): Update.
2625         (symbol_set_names): Update.
2626         * objfiles.h (struct objfile_per_bfd_storage)
2627         <demangled_names_hash>: Now an htab_up.
2628         * objfiles.c (objfile_per_bfd_storage): Simplify.
2629
2630 2019-03-15  Tom Tromey  <tom@tromey.com>
2631
2632         * objfiles.h (struct objfile_per_bfd_storage): Declare
2633         destructor.
2634         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2635         New.
2636         (get_objfile_bfd_data): Use new.  Don't initialize
2637         language_of_main.
2638         (free_objfile_per_bfd_storage): Remove.
2639         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2640
2641 2019-03-15  Tom Tromey  <tom@tromey.com>
2642
2643         * symfile.c (reread_symbols): Update.
2644         * objfiles.c (objfile::objfile): Update.
2645         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2646         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2647         comment.
2648         (minimal_symbol_reader::install): Update.
2649         (terminate_minimal_symbol_table): Remove.
2650         * jit.c (jit_object_close_impl): Update.
2651
2652 2019-03-15  Tom Tromey  <tom@tromey.com>
2653
2654         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2655         initializations.
2656
2657 2019-03-15  Tom Tromey  <tom@tromey.com>
2658
2659         * objfiles.h (struct objfile_per_bfd_storage)
2660         <demangled_hash_languages>: Now a bitset.
2661         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2662         (lookup_minimal_symbol): Update.
2663
2664 2019-03-15  Tom Tromey  <tom@tromey.com>
2665
2666         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2667         Don't return the symbol.
2668         * coffread.c (record_minimal_symbol): Use record_full.
2669
2670 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2671
2672         The MS-Windows port of ncurses fails to switch to a color pair if
2673         one or both of the colors are the implicit default colors.  This
2674         change records the default colors when TUI is initialized, and
2675         then specifies them explicitly when a color pair uses the default
2676         colors.  This allows color styling in TUI mode on MS-Windows.
2677
2678         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2679         ncurses_norm_attr.
2680         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2681         colors in ncurses_norm_attr.
2682         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2683         "none", replace it with the default color recorded in
2684         ncurses_norm_attr.
2685
2686 2019-03-14  Tom Tromey  <tromey@adacore.com>
2687
2688         * source-cache.h (class source_cache) <get_source_lines>: Return
2689         std::string.
2690         * source-cache.c (source_cache::extract_lines): Handle case where
2691         first_pos==npos.  Return std::string.
2692         (source_cache::get_source_lines): Update.
2693
2694 2019-03-14  Tom Tromey  <tromey@adacore.com>
2695
2696         * NEWS: Add item for "style sources" commands.
2697         * source-cache.c (source_cache::get_source_lines): Check
2698         source_styling.
2699         * cli/cli-style.c (source_styling): New global.
2700         (_initialize_cli_style): Add "style sources" commands.
2701         (show_style_sources): New function.
2702         * cli/cli-style.h (source_styling): Declare.
2703
2704 2019-03-14  Pedro Alves  <palves@redhat.com>
2705             Tom Tromey  <tromey@adacore.com>
2706
2707         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2708         * tui/tui-winsource.c (tui_refill_source_window): New function,
2709         from...
2710         (tui_horizontal_source_scroll): ... here.  Move some logic.
2711         * cli/cli-style.c (set_style_enabled): Notify new observable.
2712         * tui/tui-hooks.c (tui_redisplay_source): New function.
2713         (tui_attach_detach_observers): Attach or detach
2714         tui_redisplay_source.
2715         * observable.h (source_styling_changed): New observable.
2716         * observable.c: Define source_styling_changed observable.
2717
2718 2019-03-13  Tom Tromey  <tromey@adacore.com>
2719
2720         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2721         (i386_gnu_nat_target::store_registers): Update.
2722         * target-debug.h (target_debug_print_std_string): New macro.
2723         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2724         * windows-tdep.c (display_one_tib): Update.
2725         * tui/tui-stack.c (tui_make_status_line): Update.
2726         * top.c (print_inferior_quit_action): Update.
2727         * thread.c (thr_try_catch_cmd): Update.
2728         (add_thread_with_info): Update.
2729         (thread_target_id_str): Update.
2730         (thr_try_catch_cmd): Update.
2731         (thread_command): Update.
2732         (thread_find_command): Update.
2733         * record-btrace.c (record_btrace_target::info_record)
2734         (record_btrace_resume_thread, record_btrace_target::resume)
2735         (record_btrace_cancel_resume, record_btrace_step_thread)
2736         (record_btrace_target::wait, record_btrace_target::wait)
2737         (record_btrace_target::wait, record_btrace_target::stop): Update.
2738         * progspace.c (print_program_space): Update.
2739         * process-stratum-target.c
2740         (process_stratum_target::thread_address_space): Update.
2741         * linux-fork.c (linux_fork_mourn_inferior)
2742         (detach_checkpoint_command, info_checkpoints_command)
2743         (linux_fork_context): Update.
2744         (linux_fork_detach): Update.
2745         (class scoped_switch_fork_info): Update.
2746         (delete_checkpoint_command): Update.
2747         * infrun.c (follow_fork_inferior): Update.
2748         (follow_fork_inferior): Update.
2749         (proceed_after_vfork_done): Update.
2750         (handle_vfork_child_exec_or_exit): Update.
2751         (follow_exec): Update.
2752         (displaced_step_prepare_throw): Update.
2753         (displaced_step_restore): Update.
2754         (start_step_over): Update.
2755         (resume_1): Update.
2756         (clear_proceed_status_thread): Update.
2757         (proceed): Update.
2758         (print_target_wait_results): Update.
2759         (do_target_wait): Update.
2760         (context_switch): Update.
2761         (stop_all_threads): Update.
2762         (restart_threads): Update.
2763         (finish_step_over): Update.
2764         (handle_signal_stop): Update.
2765         (switch_back_to_stepped_thread): Update.
2766         (keep_going_pass_signal): Update.
2767         (print_exited_reason): Update.
2768         (normal_stop): Update.
2769         * inferior.c (inferior_pid_to_str): Change return type.
2770         (print_selected_inferior): Update.
2771         (add_inferior): Update.
2772         (detach_inferior): Update.
2773         * dummy-frame.c (fprint_dummy_frames): Update.
2774         * dcache.c (dcache_info_1): Update.
2775         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2776         (btrace_fetch, btrace_clear): Update.
2777         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2778         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2779         type.
2780         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2781         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2782         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2783         * gdbarch.c, gdbarch.h: Rebuild.
2784         * gdbarch.sh (core_pid_to_str): Change return type.
2785         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2786         return type.
2787         (windows_nat_target::pid_to_str): Change return type.
2788         (windows_delete_thread): Update.
2789         (windows_nat_target::attach): Update.
2790         (windows_nat_target::files_info): Update.
2791         * target-delegates.c: Rebuild.
2792         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2793         return type.
2794         (sol_thread_target::pid_to_str): Change return type.
2795         * remote.c (class remote_target) <pid_to_str>: Change return
2796         type.
2797         (remote_target::pid_to_str): Change return type.
2798         (extended_remote_target::attach, remote_target::remote_stop_ns)
2799         (remote_target::remote_notif_remove_queued_reply)
2800         (remote_target::push_stop_reply, remote_target::disable_btrace):
2801         Update.
2802         (extended_remote_target::attach): Update.
2803         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2804         type.
2805         (gdbsim_target::pid_to_str): Change return type.
2806         * ravenscar-thread.c (struct ravenscar_thread_target)
2807         <pid_to_str>: Change return type.
2808         (ravenscar_thread_target::pid_to_str): Change return type.
2809         * procfs.c (class procfs_target) <pid_to_str>: Change return
2810         type.
2811         (procfs_target::pid_to_str): Change return type.
2812         (procfs_target::attach): Update.
2813         (procfs_target::detach): Update.
2814         (procfs_target::fetch_registers): Update.
2815         (procfs_target::store_registers): Update.
2816         (procfs_target::wait): Update.
2817         (procfs_target::files_info): Update.
2818         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2819         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2820         return type.
2821         (nto_procfs_target::pid_to_str): Change return type.
2822         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2823         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2824         return type.
2825         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2826         (exit_lwp): Update.
2827         (attach_proc_task_lwp_callback, get_detach_signal)
2828         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2829         (linux_nat_target::resume, wait_lwp, stop_callback)
2830         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2831         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2832         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2833         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2834         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2835         type.
2836         (inf_ptrace_target::attach): Update.
2837         (inf_ptrace_target::files_info): Update.
2838         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2839         type.
2840         (go32_nat_target::pid_to_str): Change return type.
2841         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2842         (gnu_nat_target::wait): Update.
2843         (gnu_nat_target::wait): Update.
2844         (gnu_nat_target::resume): Update.
2845         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2846         (fbsd_nat_target::wait): Update.
2847         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2848         type.
2849         (darwin_nat_target::attach): Update.
2850         * corelow.c (class core_target) <pid_to_str>: Change return type.
2851         (core_target::pid_to_str): Change return type.
2852         * target.c (normal_pid_to_str): Change return type.
2853         (default_pid_to_str): Likewise.
2854         (target_pid_to_str): Change return type.
2855         (target_translate_tls_address): Update.
2856         (target_announce_detach): Update.
2857         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2858         return type.
2859         (bsd_uthread_target::pid_to_str): Change return type.
2860         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2861         type.
2862         (bsd_kvm_target::pid_to_str): Change return type.
2863         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2864         return type.
2865         (aix_thread_target::pid_to_str): Change return type.
2866         * target.h (struct target_ops) <pid_to_str>: Change return type.
2867         (target_pid_to_str, normal_pid_to_str): Likewise.
2868         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2869         type.
2870         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2871         type.
2872         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2873         return type.
2874         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2875         type.
2876         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2877         type.
2878         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2879         return type.
2880
2881 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2882
2883         * NEWS: Mention that the new default MI version is 3.  Mention
2884         changes to the output of commands and events that deal with
2885         multi-location breakpoints.
2886         * breakpoint.c: Include "mi/mi-out.h".
2887         (print_one_breakpoint): Change output syntax if using MI version
2888         >= 3.
2889         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2890         New.
2891         (mi_multi_location_breakpoint_output_fixed): New.
2892         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2893         (mi_cmd_fix_multi_location_breakpoint_output): New.
2894         (mi_multi_location_breakpoint_output_fixed): New.
2895         * mi/mi-cmds.c (mi_cmds): Register command
2896         -fix-multi-location-breakpoint-output.
2897         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2898         interpreter "mi".
2899
2900 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2901
2902         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2903         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2904         instantiate mi_ui_out based on interpreter name.
2905         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2906         * mi/mi-main.c (mi_load_progress): Likewise.
2907
2908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2909
2910         * NEWS: Combine separate "New targets" sections for 8.3.
2911
2912 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2913
2914         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2915         (ppcfbsd_init_abi): Install gdbarch
2916         "fetch_tls_load_module_address" and "get_thread_local_address"
2917         methods.
2918
2919 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2920
2921         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2922         (riscv_fbsd_init_abi): Install gdbarch
2923         "fetch_tls_load_module_address" and "get_thread_local_address"
2924         methods.
2925
2926 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2927
2928         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2929         (i386fbsd_init_abi): Install gdbarch
2930         "fetch_tls_load_module_address" and "get_thread_local_address"
2931         methods.
2932
2933 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2934
2935         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2936         (amd64fbsd_init_abi): Install gdbarch
2937         "fetch_tls_load_module_address" and "get_thread_local_address"
2938         methods.
2939
2940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2941
2942         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2943         (struct fbsd_pspace_data): New type.
2944         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2945         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2946         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2947         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2948         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2949
2950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2951
2952         * gdbtypes.c (lookup_struct_elt): New function.
2953         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2954         * gdbtypes.h (struct struct_elt): New type.
2955         (lookup_struct_elt): New prototype.
2956
2957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2958
2959         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2960         remove disabled code block.
2961
2962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2963
2964         * gdbarch.sh (get_thread_local_address): New method.
2965         * gdbarch.h, gdbarch.c: Regenerate.
2966         * target.c (target_translate_tls_address): Use
2967         gdbarch_get_thread_local_address if present instead of
2968         target::get_thread_local_address.
2969
2970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2971
2972         * target.h (target::get_thread_local_address): Update comment.
2973
2974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2975
2976         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2977         objfile->separate_debug_objfile_backlink if not NULL.
2978
2979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2980
2981         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2982         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2983         (amd64bsd_store_inferior_registers): Likewise.
2984         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2985         Enable segment base registers.
2986         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2987         PT_GETFSBASE and PT_GETGSBASE.
2988         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2989         PT_SETGSBASE.
2990         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2991         segment base registers.
2992         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2993
2994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2995
2996         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2997         Update calls to i386_target_description to add 'segments'
2998         parameter.
2999         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3000         add segment base registers.
3001         * arch/i386.c (i386_create_target_description): Add 'segments'
3002         parameter to enable segment base registers.
3003         * arch/i386.h (i386_create_target_description): Likewise.
3004         * features/i386/32bit-segments.xml: New file.
3005         * features/i386/32bit-segments.c: Generate.
3006         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3007         call to i386_target_description to add 'segments' parameter.
3008         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3009         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3010         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3011         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3012         if feature is present.
3013         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3014         Add 'segments' parameter to call to i386_target_description.
3015         (i386_target_description): Add 'segments' parameter to enable
3016         segment base registers.
3017         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3018         to call to i386_target_description.
3019         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3020         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3021         Define I386_NUM_REGS.
3022         (i386_target_description): Add 'segments' parameter to enable
3023         segment base registers.
3024
3025 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3026
3027         PR/24325
3028         * source-cache.c: #undef open and close, to avoid unresolved
3029         externals during linking.
3030
3031 2019-03-12  Tom Tromey  <tromey@adacore.com>
3032
3033         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3034         const.  Add initializers.
3035         (_initialize_remote): Don't initialize ptid globals.
3036
3037 2019-03-12  Pedro Alves  <palves@redhat.com>
3038
3039         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3040
3041 2019-03-12  Pedro Alves  <palves@redhat.com>
3042
3043         * cp-name-parser.y (main): Remove unused 'len' variable.
3044
3045 2019-03-12  Tom Tromey  <tromey@adacore.com>
3046
3047         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3048         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3049
3050 2019-03-12  Tom Tromey  <tromey@adacore.com>
3051
3052         * linux-nat.c (iterate_over_lwps): Update.
3053         (stop_callback): Remove parameter.
3054         (stop_wait_callback, detach_callback, resume_set_callback)
3055         (select_singlestep_lwp_callback, set_ignore_sigint)
3056         (status_callback, resumed_callback, resume_clear_callback)
3057         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3058         data parameter.
3059         (linux_nat_target::detach, linux_nat_target::resume)
3060         (linux_stop_and_wait_all_lwps, select_event_lwp)
3061         (linux_nat_filter_event, linux_nat_wait_1)
3062         (linux_nat_target::kill, linux_nat_target::stop)
3063         (linux_nat_target::stop): Update.
3064         (linux_nat_resume_callback): Change type.
3065         (resume_stopped_resumed_lwps, count_events_callback)
3066         (select_event_lwp_callback): Likewise.
3067         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3068         * arm-linux-nat.c (struct update_registers_data): Remove.
3069         (update_registers_callback): Change type.
3070         (arm_linux_insert_hw_breakpoint1): Update.
3071         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3072         parameter.
3073         (x86_linux_dr_set_addr): Update.
3074         (x86_linux_dr_set_control): Update.
3075         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3076         (iterate_over_lwps): Use gdb::function_view.
3077         * nat/aarch64-linux-hw-point.c (struct
3078         aarch64_dr_update_callback_param): Remove.
3079         (debug_reg_change_callback): Change type.
3080         (aarch64_notify_debug_reg_change): Update.
3081         * s390-linux-nat.c (s390_refresh_per_info): Update.
3082
3083 2019-03-11  Tom Tromey  <tromey@adacore.com>
3084
3085         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3086         redundant assignment to "this_cu".
3087
3088 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3089
3090         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3091
3092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3093
3094         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3095         from...
3096         (rank_one_type): ... this.
3097
3098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3099
3100         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3101         from...
3102         (rank_one_type): ... this.
3103
3104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3105
3106         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3107         from...
3108         (rank_one_type): ... this.
3109
3110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3111
3112         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3113         from...
3114         (rank_one_type): ... this.
3115
3116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3117
3118         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3119         from...
3120         (rank_one_type): ... this.
3121
3122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3123
3124         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3125         from...
3126         (rank_one_type): ... this.
3127
3128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3129
3130         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3131         from...
3132         (rank_one_type): ... this.
3133
3134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3135
3136         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3137         from...
3138         (rank_one_type): ... this.
3139
3140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3141
3142         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3143         from...
3144         (rank_one_type): ... this.
3145
3146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3147
3148         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3149         from...
3150         (rank_one_type): ... this.
3151
3152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3153
3154         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3155         from...
3156         (rank_one_type): ... this.
3157
3158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3159
3160         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3161         from...
3162         (rank_one_type): ... this.
3163
3164 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165
3166         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3167         inferior-events' shows the example events.
3168
3169 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3170
3171         Support styling on native MS-Windows console
3172
3173         PR/24315
3174         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3175         on MS-Windows if $TERM is not defined.
3176
3177         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3178
3179         * posix-hdep.c (gdb_console_fputs):
3180         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3181         functions.
3182         * ui-file.h (gdb_console_fputs): Add prototype.
3183
3184         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3185         back to fputs only if the former returns zero.
3186
3187 2019-03-07  Tom Tromey  <tom@tromey.com>
3188
3189         * symmisc.c (print_symbol_bcache_statistics): Update.
3190         (print_objfile_statistics): Update.
3191         * symfile.c (allocate_symtab): Update.
3192         * stabsread.c: Don't include bcache.h.
3193         * psymtab.h (struct psymbol_bcache): Don't declare.
3194         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3195         (psymbol_bcache_init, psymbol_bcache_free)
3196         (psymbol_bcache_get_bcache): Don't declare.
3197         * psymtab.c (struct psymbol_bcache): Remove.
3198         (psymtab_storage::psymtab_storage): Update.
3199         (psymtab_storage::~psymtab_storage): Update.
3200         (psymbol_bcache_init, psymbol_bcache_free)
3201         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3202         (add_psymbol_to_bcache): Update.
3203         (allocate_psymtab): Update.
3204         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3205         macro_cache>: No longer pointers.
3206         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3207         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3208         * macrotab.c (macro_bcache): Update.
3209         * macroexp.c: Don't include bcache.h.
3210         * gdbtypes.c (check_types_worklist): Update.
3211         (types_deeply_equal): Remove TRY/CATCH.  Update.
3212         * elfread.c (elf_symtab_read): Update.
3213         * dwarf2read.c: Don't include bcache.h.
3214         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3215         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3216         (print_bcache_statistics, bcache_memory_used): Don't declare.
3217         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3218         methods.  Rename all data members.
3219         * bcache.c (struct bcache): Move to bcache.h.
3220         (bcache::expand_hash_table): Rename from expand_hash_table.
3221         (bcache): Remove.
3222         (bcache::insert): Rename from bcache_full.
3223         (bcache::compare): Rename from bcache_compare.
3224         (bcache_xmalloc): Remove.
3225         (bcache::~bcache): Rename from bcache_xfree.
3226         (bcache::print_statistics): Rename from print_bcache_statistics.
3227         (bcache::memory_used): Rename from bcache_memory_used.
3228
3229 2019-03-07  Pedro Alves  <palves@redhat.com>
3230
3231         * infrun.c (normal_stop): Also check for
3232         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3233
3234 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3235
3236         * f-lang.c (value_from_host_double): Moved to...
3237         * value.c (value_from_host_double): ...here.
3238         * value.h (value_from_host_double): Declare.
3239         * guile/scm-math.c (vlscm_convert_typed_number): Use
3240         value_from_host_double.
3241         (vlscm_convert_number): Likewise.
3242         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3243         * python/py-value.c (convert_value_from_python): Likewise.
3244
3245 2019-03-06  Tom Tromey  <tom@tromey.com>
3246
3247         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3248
3249 2019-03-06  Tom Tromey  <tom@tromey.com>
3250
3251         * utils.h (free_current_contents): Don't declare.
3252         * utils.c (free_current_contents): Remove.
3253
3254 2019-03-06  Tom Tromey  <tom@tromey.com>
3255
3256         * top.c (quit_force): Update.
3257         * main.c (captured_command_loop): Update.
3258         * common/new-op.c (operator new): Update.
3259         * common/common-exceptions.c (struct catcher)
3260         <save_cleanup_chain>: Remove member.
3261         (exceptions_state_mc_init): Update.
3262         (exception_try_scope_entry): Return nullptr.
3263         (exception_try_scope_exit, exception_rethrow)
3264         (throw_exception_sjlj, throw_exception_cxx): Update.
3265         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3266         (all_cleanups, do_cleanups, discard_cleanups)
3267         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3268         (restore_cleanups, restore_final_cleanups): Don't declare.
3269         (do_final_cleanups): Remove parameter.
3270         * common/cleanups.c (cleanup_chain, make_cleanup)
3271         (make_cleanup_dtor, all_cleanups, do_cleanups)
3272         (discard_my_cleanups, discard_cleanups)
3273         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3274         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3275         (null_cleanup): Remove.
3276         (do_final_cleanups): Remove parameter.
3277
3278 2019-03-06  Tom Tromey  <tom@tromey.com>
3279
3280         * remote.c (remote_target::remote_parse_stop_reply): Use
3281         unique_xmalloc_ptr.
3282
3283 2019-03-06  Tom Tromey  <tom@tromey.com>
3284
3285         * stabsread.c (struct stabs_field_info): Rename from field_info.
3286         <list, fnlist>: Add initializers.
3287         <obstack>: New member.
3288         (read_member_functions, read_struct_fields, read_baseclasses):
3289         Allocate on obstack.  Don't use cleanups.
3290         (read_one_struct_field, read_member_functions, read_struct_fields)
3291         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3292         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3293         (read_struct_type): Update.
3294
3295 2019-03-06  Tom Tromey  <tom@tromey.com>
3296
3297         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3298         * common/filestuff.h (make_cleanup_close): Don't declare.
3299         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3300         Remove.
3301
3302 2019-03-06  Tom Tromey  <tom@tromey.com>
3303
3304         * solib-aix.c: Use make_scope_exit.
3305
3306 2019-03-06  Tom Tromey  <tom@tromey.com>
3307
3308         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3309         Use make_scope_exit.
3310
3311 2019-03-06  Tom Tromey  <tom@tromey.com>
3312
3313         * solib-svr4.c (disable_probes_interface): Remove parameter.
3314         (svr4_handle_solib_event): Use make_scope_exit.
3315
3316 2019-03-06  Tom Tromey  <tom@tromey.com>
3317
3318         * remote.c (struct stop_reply_deleter): Remove.
3319         (stop_reply_up): Update.
3320         (struct stop_reply): Derive from notif_event.  Don't typedef.
3321         <regcache>: Now a std::vector.
3322         (stop_reply_xfree): Remove.
3323         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3324         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3325         (remote_target::discard_pending_stop_replies): Use delete.
3326         (remote_target::remote_parse_stop_reply): Update.
3327         (remote_target::process_stop_reply): Update.
3328         * remote-notif.h (struct notif_event): Add virtual destructor.
3329         Remove "dtr" member.
3330         (struct notif_client) <alloc_event>: Return a unique_ptr.
3331         (notif_event_xfree): Don't declare.
3332         (notif_event_up): New typedef.
3333         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3334         (notif_event_xfree, do_notif_event_xfree): Remove.
3335         (remote_notif_state_xfree): Update.
3336
3337 2019-03-06  Tom Tromey  <tom@tromey.com>
3338
3339         * infrun.c (displaced_step_clear_cleanup): Now a
3340         forward_scope_exit type.
3341         (displaced_step_prepare_throw): Update.
3342         (displaced_step_fixup): Update.
3343
3344 2019-03-06  Tom Tromey  <tom@tromey.com>
3345
3346         * inferior.h (class inferior): Update comment.
3347         * gdbthread.h (class thread_info): Update comment.
3348
3349 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3350             Tom Tromey  <tom@tromey.com>
3351
3352         * stabsread.h (struct stab_section_list): Remove.
3353         (coffstab_build_psymtabs): Update.
3354         * dbxread.c (symbuf_sections): Now a std::vector.
3355         (sect_idx): New global.
3356         (fill_symbuf): Update.
3357         (coffstab_build_psymtabs): Change type of stabsects parameter.
3358         Update.
3359         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3360         std::vector.
3361         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3362         (coff_locate_sections): Update.
3363         (coff_symfile_read): Remove cleanups.  Update.
3364         (init_stringtab): Add storage parameter.
3365         (free_stringtab, free_stringtab_cleanup): Remove.
3366         (init_lineno): Add storage parameter.
3367         (free_linetab, free_linetab_cleanup): Remove.
3368
3369 2019-03-06  Pedro Alves  <palves@redhat.com>
3370
3371         * linux-fork.c (fork_info::clobber_regs): Delete.
3372         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3373         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3374         comment.  Adjust.
3375         (scoped_switch_fork_info::scoped_switch_fork_info)
3376         (checkpoint_command, linux_fork_context): Adjust
3377         fork_save_infrun_state calls.
3378
3379 2019-03-06  Pedro Alves  <palves@redhat.com>
3380
3381         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3382         (inf_has_multiple_threads): Return 'bool' and rewrite using
3383         inferior_info::threads().
3384
3385 2019-03-06  Pedro Alves  <palves@redhat.com>
3386
3387         * linux-fork.c: Include <list>.
3388         (fork_list): Now a std::list instance.
3389         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3390         (forks_exist_p, find_last_fork): Adjust.
3391         (new_fork): Delete.
3392         (one_fork_p): New.
3393         (add_fork): Adjust.
3394         (free_fork): Delete, folded into fork_info::~fork_info().
3395         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3396         Adjust.
3397         (init_fork_list): Delete.
3398         (linux_fork_killall, linux_fork_mourn_inferior)
3399         (linux_fork_detach, info_checkpoints_command): Adjust.
3400         (_initialize_linux_fork): No longer call init_fork_list.
3401
3402 2019-03-06  Pedro Alves  <palves@redhat.com>
3403
3404         * linux-fork.c (new_fork): New, split out of ...
3405         (add_fork): ... this.  Return void.  Move "first fork" special
3406         case from here, to ...
3407         (checkpoint_command): ... here.
3408         * linux-linux.h (add_fork): Return void.
3409
3410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3413
3414 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3415             Chris January  <chris.january@arm.com>
3416             David Lecomber  <david.lecomber@arm.com>
3417
3418         * f-exp.y: New token, UNOP_INTRINSIC.
3419         (exp): New pattern using UNOP_INTRINSIC token.
3420         (f77_keywords): Add 'abs' keyword.
3421         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3422         (value_from_host_double): New function.
3423         (evaluate_subexp_f): Support UNOP_ABS.
3424
3425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3426
3427         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3428         types.
3429
3430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3433         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3434         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3435
3436 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3437
3438         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3439
3440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3441             Chris January  <chris.january@arm.com>
3442
3443         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3444         * f-exp.y: Define 'KIND' token.
3445         (exp): New pattern for KIND expressions.
3446         (ptype): Handle types with a kind extension.
3447         (direct_abs_decl): Extend to spot kind extensions.
3448         (f77_keywords): Add 'kind' to the list.
3449         (push_kind_type): New function.
3450         (convert_to_kind_type): New function.
3451         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3452         * parse.c (operator_length_standard): Likewise.
3453         * parser-defs.h (enum type_pieces): Add tp_kind.
3454         * std-operator.def: Add UNOP_KIND.
3455
3456 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * f-exp.y (f_parse): Set yydebug.
3459
3460 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * f-lang.c (evaluate_subexp_f): New function.
3463         (exp_descriptor_f): New global.
3464         (f_language_defn): Use exp_descriptor_f instead of
3465         exp_descriptor_standard.
3466
3467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3468
3469         * f-exp.y (struct token): Add comments.
3470         (dot_ops): Remove uppercase versions and the end marker.
3471         (f77_keywords): Likewise.
3472         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3473         entries in the dot_ops array are case insensitive, and use
3474         strncasecmp to compare strings.  Also some whitespace cleanup in
3475         this area.  Similar for the f77_keywords array, except entries in
3476         this list might be case sensitive.
3477
3478 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3479
3480         * f-exp.y (struct f77_boolean_val): Add comments.
3481         (boolean_values): Remove uppercase versions, and end marker.
3482         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3483         and use strncasecmp to achieve case insensitivity.  Additionally,
3484         perform whitespace cleanup around this code.
3485
3486 2019-03-06  Tom Tromey  <tromey@adacore.com>
3487
3488         * remote-sim.c (gdbsim_target_open): Use result of
3489         gdb_argv::release.
3490
3491 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3492         Dirk Schubert  <dirk.schubert@arm.com>
3493         Chris January  <chris.january@arm.com>
3494
3495         * eval.c (evaluate_subexp_standard): Call Fortran argument
3496         wrapping logic.
3497         * f-lang.c (struct value): A value which can be passed into a
3498         Fortran function call.
3499         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3500         where appropriate.
3501         (struct type): Value ready for a Fortran function call.
3502         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3503         is needed.
3504         * f-lang.h (fortran_argument_convert): Declaration.
3505         (fortran_preserve_arg_pointer): Declaration.
3506         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3507
3508 2019-03-05  Tom Tromey  <tromey@adacore.com>
3509
3510         * python/py-prettyprint.c (print_string_repr): Remove #if.
3511         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3512
3513 2019-03-05  Tom Tromey  <tromey@adacore.com>
3514
3515         * target.c (the_dummy_target): Move later.  Change type to
3516         "dummy_target".
3517         (initialize_targets): Don't initialize the_dummy_target.
3518
3519 2019-03-05  Tom Tromey  <tromey@adacore.com>
3520
3521         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3522         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3523
3524 2019-03-05  Tom Tromey  <tromey@adacore.com>
3525
3526         * windows-nat.c (windows_nat_target::attach)
3527         (windows_nat_target::detach): Don't call gdb_flush.
3528         * valprint.c (generic_val_print, val_print, val_print_string):
3529         Don't call gdb_flush.
3530         * utils.c (defaulted_query): Don't call gdb_flush.
3531         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3532         * target.c (target_announce_detach): Don't call gdb_flush.
3533         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3534         * remote.c (extended_remote_target::attach): Don't call
3535         gdb_flush.
3536         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3537         * printcmd.c (do_examine): Don't call gdb_flush.
3538         (info_display_command): Don't call gdb_flush.
3539         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3540         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3541         * memattr.c (info_mem_command): Don't call gdb_flush.
3542         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3543         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3544         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3545         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3546         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3547         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3548         (gnu_nat_target::detach): Don't call gdb_flush.
3549         * f-valprint.c (f_val_print): Don't call gdb_flush.
3550         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3551         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3552         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3553         gdb_flush.
3554         * c-valprint.c (c_val_print): Don't call gdb_flush.
3555         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3556
3557 2019-03-05  Tom Tromey  <tromey@adacore.com>
3558
3559         * varobj.c (update_dynamic_varobj_children): Update.
3560         (install_default_visualizer): Use reset, not release.
3561         * value.c (set_internalvar): Update.
3562         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3563         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3564         ATTRIBUTE_UNUSED_RESULT.
3565
3566 2019-03-05  Tom Tromey  <tromey@adacore.com>
3567
3568         * remote.c (class scoped_remote_fd) <release>: Add
3569         ATTRIBUTE_UNUSED_RESULT.
3570
3571 2019-03-05  Tom Tromey  <tromey@adacore.com>
3572
3573         * macroexp.c (struct macro_buffer) <release>: Add
3574         ATTRIBUTE_UNUSED_RESULT.
3575
3576 2019-03-05  Tom Tromey  <tromey@adacore.com>
3577
3578         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3579         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3580         ATTRIBUTE_UNUSED_RESULT.
3581
3582 2019-03-05  Tom Tromey  <tromey@adacore.com>
3583
3584         * common/scoped_fd.h (class scoped_fd) <release>: Add
3585         ATTRIBUTE_UNUSED_RESULT.
3586
3587 2019-03-05  Tom Tromey  <tromey@adacore.com>
3588
3589         * parser-defs.h (struct parser_state) <release>: Add
3590         ATTRIBUTE_UNUSED_RESULT.
3591
3592 2019-03-05  Tom Tromey  <tromey@adacore.com>
3593
3594         * utils.h (class gdb_argv) <release>: Add
3595         ATTRIBUTE_UNUSED_RESULT.
3596         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3597
3598 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3599
3600         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3601         for-loop range, to avoid compiler warnings.
3602
3603         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3604         avoid compiler warnings about unused variables.
3605
3606         * NEWS: Mention end of support for native debugging on MS-Windows
3607         before XP.
3608
3609         PR gdb/24292
3610         * common/netstuff.c:
3611         * gdbserver/gdbreplay.c
3612         * gdbserver/remote-utils.c:
3613         * ser-tcp.c:
3614         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3615         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3616         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3617         'getaddrinfo' and 'freeaddrinfo' were not available before
3618         Windows XP, and mingw.org's MinGW headers by default define
3619         _WIN32_WINNT to 0x500.
3620
3621 2019-03-01  Gary Benson <gbenson@redhat.com>
3622
3623         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3624
3625 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3626             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3627
3628         PR gdb/8527
3629         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3630         set_sigint_trap, clear_sigint_trap.
3631
3632 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3633
3634         * target.c (target_detach): Clear the regcache and the
3635         frame cache.
3636
3637 2019-02-27  Pedro Alves  <palves@redhat.com>
3638
3639         * utils.c (set_screen_size): When we cap the height/width sizes,
3640         tweak the corresponding command variable to show "unlimited":
3641
3642 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3643             Pedro Alves  <palves@redhat.com>
3644
3645         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3646         before calling rl_set_screen_size.
3647
3648 2019-02-27  Tom Tromey  <tromey@adacore.com>
3649
3650         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3651         define.
3652         * python/py-value.c: Remove Python 2.4 workaround.
3653         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3654         workaround.
3655         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3656         Python 2.4 workaround.
3657         * python/python-internal.h: Remove Python 2.4 comment.
3658         (Py_ssize_t): Don't define.
3659         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3660         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3661         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3662         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3663         * python/python.c (do_start_initialization): Remove Python 2.4
3664         workaround.
3665         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3666         (print_children): Remove Python 2.4 workaround.
3667         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3668         workaround.
3669         (CHARBUFFERPROC_NAME): Remove.
3670         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3671         Python 2.4 workaround.
3672
3673 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3674
3675         * NEWS: Note minimum Python version.
3676
3677 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3678
3679         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3680         code from these functions.  Remove corresponding ifdefs.  Use
3681         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3682         Remove gotos and target of gotos.
3683         (infpy_search_memory): Likewise.
3684
3685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3686
3687         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3688         (hppa_gdbarch_init): Don't register deleted functions with
3689         gdbarch.
3690
3691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3694         (h8300_unwind_sp): Delete.
3695         (h8300_dummy_id): Delete.
3696         (h8300_gdbarch_init): Don't register deleted functions with
3697         gdbarch.
3698
3699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3700
3701         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3702         (ft32_unwind_pc): Delete.
3703         (ft32_unwind_sp): Delete.
3704         (ft32_gdbarch_init): Don't register deleted functions with
3705         gdbarch.
3706
3707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3708
3709         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3710         (frv_unwind_pc): Delete.
3711         (frv_unwind_sp): Delete.
3712         (frv_gdbarch_init): Don't register deleted functions with
3713         gdbarch.
3714
3715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3716
3717         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3718         (riscv_unwind_pc): Delete.
3719         (riscv_unwind_sp): Delete.
3720         (riscv_gdbarch_init): Don't register deleted functions with
3721         gdbarch.
3722
3723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3724
3725         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3726         (csky_unwind_pc): Delete.
3727         (csky_unwind_sp): Delete.
3728         (csky_gdbarch_init): Don't register deleted functions with
3729         gdbarch.
3730
3731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3732
3733         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3734         (cris_unwind_pc): Delete.
3735         (cris_unwind_sp): Delete.
3736         (cris_gdbarch_init): Don't register deleted functions with
3737         gdbarch.
3738
3739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3740
3741         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3742         (bfin_unwind_pc): Delete.
3743         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3744
3745 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3748         (arm_unwind_pc): Delete.
3749         (arm_unwind_sp): Delete.
3750         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3751
3752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3755         (arc_unwind_pc): Delete.
3756         (arc_unwind_sp): Delete.
3757         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3758
3759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3760
3761         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3762         (alpha_unwind_pc): Delete.
3763         (alpha_gdbarch_init): Don't register deleted functions with
3764         gdbarch.
3765
3766 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3769         (aarch64_unwind_pc): Delete.
3770         (aarch64_unwind_sp): Delete.
3771         (aarch64_gdbarch_init): Don't register deleted functions with
3772         gdbarch.
3773
3774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * gdbtypes.c (type_align): Don't consider static members when
3777         computing structure alignment.
3778
3779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3782         return 0 for other types.
3783         * arch-utils.c (default_type_align): Always return 0.
3784         * gdbarch.h: Regenerate.
3785         * gdbarch.sh (type_align): Extend comment.
3786         * gdbtypes.c (type_align): Add additional comments, always call
3787         gdbarch_type_align before applying the default rules.
3788         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3789         generic code will then apply a suitable default.
3790         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3791         types, return 0 for other types.
3792
3793 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3794
3795         * NEWS: Create a new section for the next release branch.
3796         Rename the section of the current branch, now that it has
3797         been cut.
3798
3799 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3800
3801         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3802         * version.in: Bump version to 8.3.50.DATE-git.
3803
3804 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3805
3806         * aix-thread.c (ptid_cmp): Remove unused variable.
3807         (get_signaled_thread): Likewise.
3808         (store_regs_user_thread): Likewise.
3809         (store_regs_kernel_thread): Likewise.
3810         (fetch_regs_kernel_thread): Remove shadowed variable.
3811
3812 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * features/riscv/32bit-cpu.xml: Add register numbers.
3815         * features/riscv/32bit-fpu.c: Regenerate.
3816         * features/riscv/32bit-fpu.xml: Add register numbers.
3817         * features/riscv/64bit-cpu.xml: Add register numbers.
3818         * features/riscv/64bit-fpu.c: Regenerate.
3819         * features/riscv/64bit-fpu.xml: Add register numbers.
3820
3821 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3822
3823         * NEWS: Mention two argument form of gdb.Value constructor.
3824         * python/py-value.c (convert_buffer_and_type_to_value): New
3825         function.
3826         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3827         Add support for handling an optional second argument.  Call
3828         convert_buffer_and_type_to_value as appropriate.
3829         * python/python-internal.h (Py_buffer_deleter): New struct.
3830         (Py_buffer_up): New typedef.
3831
3832 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3833
3834         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3835         instead of releasing ownership.
3836
3837 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3838
3839         * dwarf2read.c (open_and_init_dwp_file): Call
3840         elf_numsections instead of bfd_count_sections to initialize
3841         dwp_file->num_sections.
3842
3843 2019-02-25  Tom Tromey  <tromey@adacore.com>
3844
3845         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3846
3847 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3848
3849         * gcore.in: Add '--readnever' option when invoking GDB.
3850
3851 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3852
3853         * MAINTAINERS: Update my email address.
3854
3855 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3856
3857         * build-id.c (build_id_to_debug_bfd_1): New function.
3858         (build_id_to_debug_bfd): Look for separate debug file in
3859         sysroot.
3860
3861 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * gdbarch.sh: Update the copyright year range that is placed into
3864         generated files.
3865
3866 2019-02-22  Keith Seitz  <keiths@redhat.com>
3867
3868         PR symtab/23853
3869         * linespec.c (create_sals_line_offset): Search for the default
3870         symtab's filename instead of its fullname.
3871
3872 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3873
3874         * NEWS: Update style defaults.
3875
3876 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3877
3878         * main.c (captured_main_1): Disable styling in batch mode.
3879
3880 2019-02-20  Tom Tromey  <tom@tromey.com>
3881
3882         * symtab.c (symtab_symbol_info): Fix typos.
3883
3884 2019-02-20  Tom Tromey  <tromey@adacore.com>
3885
3886         * findcmd.c (_initialize_mem_search): Use upper case for
3887         metasyntactic variables.
3888
3889 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3890
3891         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3892         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3893
3894 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3895
3896         * top.h (source_file_name): Change to std::string.
3897         * top.c (source_file_name): Likewise.
3898         (command_line_input): Adjust.
3899         * cli/cli-script.c (script_from_file): Adjust.
3900
3901 2019-02-19  Tom Tromey  <tromey@adacore.com>
3902
3903         * ravenscar-thread.c
3904         (ravenscar_thread_target::update_thread_list): Don't call
3905         ada_build_task_list.
3906         * ada-lang.h (ada_build_task_list): Don't declare.
3907         * ada-tasks.c (struct ada_tasks_inferior_data)
3908         <task_list_valid_p>: Now bool.
3909         (read_known_tasks, ada_task_list_changed)
3910         (ada_tasks_invalidate_inferior_data): Update.
3911         (read_known_tasks_array): Return bool.
3912         (read_known_tasks_list): Likewise.
3913         (read_known_tasks): Return void.
3914         (ada_build_task_list): Now static.
3915
3916 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3919         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3920
3921 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3922
3923         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3924         variant for ada_tasks_pspace_data_handle and
3925         ada_tasks_inferior_data_handle.
3926         (ada_tasks_pspace_data_cleanup): New function.
3927         (ada_tasks_inferior_data_cleanup): New function.
3928
3929 2019-02-17  Tom Tromey  <tom@tromey.com>
3930
3931         * macrotab.h (macro_source_fullname): Return a std::string.
3932         * macrotab.c (macro_include, check_for_redefinition)
3933         (macro_undef, macro_lookup_definition, foreach_macro)
3934         (foreach_macro_in_scope): Update.
3935         (macro_source_fullname): Return a std::string.
3936         * macrocmd.c (show_pp_source_pos): Update.
3937
3938 2019-02-17  Tom Tromey  <tom@tromey.com>
3939
3940         * macrocmd.c (show_pp_source_pos): Style the file names.
3941
3942 2019-02-17  Tom Tromey  <tom@tromey.com>
3943
3944         PR tui/24197:
3945         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3946
3947 2019-02-17  Tom Tromey  <tom@tromey.com>
3948
3949         * ada-lang.c (user_select_syms): Use filtered printing.
3950         * utils.c (wrap_style): New global.
3951         (desired_style): Remove.
3952         (emit_style_escape): Add stream parameter.
3953         (set_output_style, reset_terminal_style, prompt_for_continue):
3954         Update.
3955         (flush_wrap_buffer): Only flush gdb_stdout.
3956         (wrap_here): Set wrap_style.
3957         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3958         treat escape sequences as a character.  Change when wrap buffer is
3959         flushed.
3960         (fputs_styled): Do not set the output style when the default is
3961         requested.
3962         * ui-style.h (struct ui_file_style) <is_default>: New method.
3963         * source.c (print_source_lines_base): Emit escape sequences in one
3964         piece.
3965
3966 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3967
3968         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3969         integers and enumeration types.
3970
3971 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3972
3973         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3974         instead of lookup_symbol_in_language
3975         (do_exact_match): New function.
3976         (ada_get_symbol_name_matcher): Return do_exact_match when
3977         doing a verbatim match.
3978
3979 2019-02-15  Tom Tromey  <tromey@adacore.com>
3980
3981         * ravenscar-thread.c (ravenscar_thread_target::resume)
3982         (ravenscar_thread_target::wait): Special case wildcard requests.
3983
3984 2019-02-15  Tom Tromey  <tromey@adacore.com>
3985
3986         * ravenscar-thread.c (base_ptid): Remove.
3987         (struct ravenscar_thread_target) <close>: New method.
3988         <m_base_ptid>: New member.
3989         <update_inferior_ptid, active_task, task_is_currently_active,
3990         runtime_initialized>: Declare methods.
3991         <ravenscar_thread_target>: Add constructor.
3992         (ravenscar_thread_target::task_is_currently_active)
3993         (ravenscar_thread_target::update_inferior_ptid)
3994         (ravenscar_runtime_initialized): Rename.  Now methods.
3995         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3996         (ravenscar_thread_target::update_thread_list): Update.
3997         (ravenscar_thread_target::active_task): Now method.
3998         (ravenscar_thread_target::store_registers)
3999         (ravenscar_thread_target::prepare_to_store)
4000         (ravenscar_thread_target::prepare_to_store)
4001         (ravenscar_thread_target::mourn_inferior): Update.
4002         (ravenscar_inferior_created): Use "new" to create target.
4003         (ravenscar_thread_target::get_ada_task_ptid): Update.
4004         (_initialize_ravenscar): Don't initialize base_ptid.
4005         (ravenscar_ops): Remove global.
4006
4007 2019-02-15  Tom Tromey  <tromey@adacore.com>
4008
4009         * target.h (push_target): Declare new overload.
4010         * target.c (push_target): New overload, taking an rvalue reference.
4011         * remote.c (remote_target::open_1): Use push_target overload.
4012         * corelow.c (core_target_open): Use push_target overload.
4013
4014 2019-02-15  Tom Tromey  <tromey@adacore.com>
4015
4016         * ravenscar-thread.c (is_ravenscar_task)
4017         (ravenscar_task_is_currently_active): Return bool.
4018         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4019         (_initialize_ravenscar): Remove "(void)".
4020         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4021         Return bool.
4022
4023 2019-02-15  Tom Tromey  <tromey@adacore.com>
4024
4025         * ravenscar-thread.c (ravenscar_runtime_initializer)
4026         (has_ravenscar_runtime, get_running_thread_id)
4027         (ravenscar_thread_target::resume): Fix indentation.
4028
4029 2019-02-15  Tom Tromey  <tromey@adacore.com>
4030
4031         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4032         from ravenscar_arch_ops.
4033         (sparc_ravenscar_ops::fetch_registers)
4034         (sparc_ravenscar_ops::store_registers): Now methods.
4035         (sparc_ravenscar_prepare_to_store): Remove.
4036         (sparc_ravenscar_ops): Redefine.
4037         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4038         methods and destructor.  Remove members.
4039         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4040         (ravenscar_thread_target::store_registers)
4041         (ravenscar_thread_target::prepare_to_store): Update.
4042         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4043         Remove.
4044         (struct ppc_ravenscar_powerpc_ops): Derive from
4045         ravenscar_arch_ops.
4046         (ppc_ravenscar_powerpc_ops::fetch_registers)
4047         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4048         (ppc_ravenscar_powerpc_ops): Redefine.
4049         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4050         (ppc_ravenscar_e500_ops::fetch_registers)
4051         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4052         (ppc_ravenscar_e500_ops): Redefine.
4053         * aarch64-ravenscar-thread.c
4054         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4055         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4056         (aarch64_ravenscar_fetch_registers)
4057         (aarch64_ravenscar_store_registers): Now methods.
4058         (aarch64_ravenscar_ops): Redefine.
4059
4060 2019-02-15  Tom Tromey  <tromey@adacore.com>
4061
4062         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4063         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4064         (ravenscar_thread_target::stopped_by_watchpoint)
4065         (ravenscar_thread_target::stopped_data_address)
4066         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4067
4068 2019-02-15  Tom Tromey  <tromey@adacore.com>
4069
4070         * ravenscar-thread.c: Fix some typos.
4071
4072 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4073             Tom Tromey  <tromey@adacore.com>
4074
4075         * ada-lang.c (ada_exception_sal): Change addr_string to a
4076         std::string.
4077         (create_ada_exception_catchpoint): Update.
4078
4079 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4080             Tom Tromey  <tromey@adacore.com>
4081
4082         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4083         (bp_location_ops): Remove.
4084         (base_breakpoint_allocate_location): Update.
4085         (free_bp_location): Update.
4086         * ada-lang.c (class ada_catchpoint_location)
4087         <ada_catchpoint_location>: Remove ops parameter.
4088         (ada_catchpoint_location_dtor): Remove.
4089         (ada_catchpoint_location_ops): Remove.
4090         (allocate_location_exception): Update.
4091         * breakpoint.h (struct bp_location_ops): Remove.
4092         (class bp_location) <bp_location>: Remove bp_location_ops
4093         parameter.
4094         <~bp_location>: Add destructor.
4095         <ops>: Remove.
4096
4097 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4098             Pedro Alves  <palves@redhat.com>
4099
4100         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4101         'PATH_MAX'.
4102
4103 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4104             Samuel Thibault  <samuel.thibault@gnu.org>
4105             Thomas Schwinge  <thomas@codesourcery.com>
4106
4107         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4108         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4109
4110 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4111
4112         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4113         (check_empty): Use "const char *".
4114
4115         * gnu-nat.c (gnu_nat_target::detach): Instead of
4116         'detach_inferior (pid)' call
4117         'detach_inferior (find_inferior_pid (pid))'.
4118
4119         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4120         'nat/fork-inferior.o'.
4121         * gnu-nat.c: #include "nat/fork-inferior.h".
4122
4123         * gnu-nat.c (gnu_nat_target::detach): Instead of
4124         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4125         * gnu-nat.h: #include "inf-child.h".
4126         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4127         'i386_gnu_nat_target::fetch_registers'.
4128         (gnu_store_registers): Rename/move to
4129         'i386_gnu_nat_target::store_registers'.
4130
4131         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4132         * gnu-nat.h (mach_thread_info): New function.
4133         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4134
4135         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4136
4137 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4138
4139         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4140
4141 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4142
4143         * windows-nat.c (windows_add_thread): Add new parameter
4144         "main_thread_p" with default value set to false.  Update
4145         function documentation as well as all callers.
4146         (windows_delete_thread): Likewise.
4147         (fake_create_process): Update call to windows_add_thread.
4148         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4149         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4150         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4151         call to windows_delete_thread.
4152
4153 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4154
4155         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4156
4157 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4158
4159         * symfile.c (find_separate_debug_file): Use canonical path of
4160         sysroot with child_path instead of gdb_sysroot if it is valid.
4161
4162 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4163
4164         * symfile.c (find_separate_debug_file): Use child_path to
4165         determine if an object file is under a sysroot.
4166
4167 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4168
4169         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4170         unittests/child-path-selftests.c.
4171         * common/pathstuff.c (child_path): New function.
4172         * common/pathstuff.h (child_path): New prototype.
4173         * unittests/child-path-selftests.c: New file.
4174
4175 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4176
4177         * symfile.c (find_separate_debug_file): Look for separate debug
4178         files in debug directories under the sysroot.
4179
4180 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4181
4182         * symtab.h (struct minimal_symbol data_p): New const method.
4183         (struct minimal_symbol text_p): Likewise.
4184         * symtab.c (output_source_filename): Use file name style
4185         to print file name.
4186         (print_symbol_info): Likewise.
4187         (print_msymbol_info): Use address style to print addresses.
4188         Use function name style to print executable text symbols.
4189         (expand_symtab_containing_pc): Use data_p.
4190         (find_pc_sect_compunit_symtab): Likewise.
4191
4192 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4193
4194         * breakpoint.c (describe_other_breakpoints): Use address style
4195         to print addresses.
4196         (say_where): Likewise.
4197
4198 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4199
4200         * ada-typeprint.c (print_func_type): Print function name
4201         style to print function name.
4202         * c-typeprint.c (c_print_type_1): Likewise.
4203
4204 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4205
4206         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4207         for execve.
4208
4209 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4210
4211         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4212         type_stack.
4213
4214 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4215
4216         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4217         TYPE_CODE_REF types.
4218
4219 2019-02-08  Jim Wilson  <jimw@sifive.com>
4220
4221         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4222         (riscv_linux_fregset): New.
4223         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4224
4225 2019-02-07  Tom Tromey  <tom@tromey.com>
4226
4227         * thread.c (thread_cancel_execution_command): Update.
4228         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4229         methods.
4230         (struct thread_fsm_ops): Remove.
4231         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4232         (thread_fsm_should_stop, thread_fsm_return_value)
4233         (thread_fsm_set_finished, thread_fsm_finished_p)
4234         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4235         Don't declare.
4236         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4237         * infrun.c (clear_proceed_status_thread)
4238         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4239         (print_stop_event): Update.
4240         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4241         Add constructor.
4242         (step_command_fsm_ops): Remove.
4243         (new_step_command_fsm): Remove.
4244         (step_1): Update.
4245         (step_command_fsm::should_stop): Rename from
4246         step_command_fsm_should_stop.
4247         (step_command_fsm::clean_up): Rename from
4248         step_command_fsm_clean_up.
4249         (step_command_fsm::do_async_reply_reason): Rename from
4250         step_command_fsm_async_reply_reason.
4251         (struct until_next_fsm): Inherit from thread_fsm.  Add
4252         constructor.
4253         (until_next_fsm_ops): Remove.
4254         (new_until_next_fsm): Remove.
4255         (until_next_fsm::should_stop): Rename from
4256         until_next_fsm_should_stop.
4257         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4258         (until_next_fsm::do_async_reply_reason): Rename from
4259         until_next_fsm_async_reply_reason.
4260         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4261         constructor.  Change type of breakpoint.
4262         (finish_command_fsm_ops): Remove.
4263         (new_finish_command_fsm): Remove.
4264         (finish_command_fsm::should_stop): Rename from
4265         finish_command_fsm_should_stop.
4266         (finish_command_fsm::clean_up): Rename from
4267         finish_command_fsm_clean_up.
4268         (finish_command_fsm::return_value): Rename from
4269         finish_command_fsm_return_value.
4270         (finish_command_fsm::do_async_reply_reason): Rename from
4271         finish_command_fsm_async_reply_reason.
4272         (finish_command): Update.
4273         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4274         Add constructor.
4275         (call_thread_fsm_ops): Remove.
4276         (call_thread_fsm::call_thread_fsm): Rename from
4277         new_call_thread_fsm.
4278         (call_thread_fsm::should_stop): Rename from
4279         call_thread_fsm_should_stop.
4280         (call_thread_fsm::should_notify_stop): Rename from
4281         call_thread_fsm_should_notify_stop.
4282         (run_inferior_call, call_function_by_hand_dummy): Update.
4283         * cli/cli-interp.c (should_print_stop_to_console): Update.
4284         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4285         Add constructor.  Change type of location_breakpoint,
4286         caller_breakpoint.
4287         (until_break_fsm_ops): Remove.
4288         (new_until_break_fsm): Remove.
4289         (until_break_fsm::should_stop): Rename from
4290         until_break_fsm_should_stop.
4291         (until_break_fsm::clean_up): Rename from
4292         until_break_fsm_clean_up.
4293         (until_break_fsm::do_async_reply_reason): Rename from
4294         until_break_fsm_async_reply_reason.
4295         (until_break_command): Update.
4296         * thread-fsm.c: Remove.
4297         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4298
4299 2019-02-07  Tom Tromey  <tom@tromey.com>
4300
4301         * yy-remap.h: Add include guard.
4302         * xtensa-tdep.h: Add include guard.
4303         * xcoffread.h: Rename include guard.
4304         * varobj-iter.h: Add include guard.
4305         * tui/tui.h: Rename include guard.
4306         * tui/tui-winsource.h: Rename include guard.
4307         * tui/tui-wingeneral.h: Rename include guard.
4308         * tui/tui-windata.h: Rename include guard.
4309         * tui/tui-win.h: Rename include guard.
4310         * tui/tui-stack.h: Rename include guard.
4311         * tui/tui-source.h: Rename include guard.
4312         * tui/tui-regs.h: Rename include guard.
4313         * tui/tui-out.h: Rename include guard.
4314         * tui/tui-layout.h: Rename include guard.
4315         * tui/tui-io.h: Rename include guard.
4316         * tui/tui-hooks.h: Rename include guard.
4317         * tui/tui-file.h: Rename include guard.
4318         * tui/tui-disasm.h: Rename include guard.
4319         * tui/tui-data.h: Rename include guard.
4320         * tui/tui-command.h: Rename include guard.
4321         * tic6x-tdep.h: Add include guard.
4322         * target/waitstatus.h: Rename include guard.
4323         * target/wait.h: Rename include guard.
4324         * target/target.h: Rename include guard.
4325         * target/resume.h: Rename include guard.
4326         * target-float.h: Rename include guard.
4327         * stabsread.h: Add include guard.
4328         * rs6000-tdep.h: Add include guard.
4329         * riscv-fbsd-tdep.h: Add include guard.
4330         * regformats/regdef.h: Rename include guard.
4331         * record.h: Rename include guard.
4332         * python/python.h: Rename include guard.
4333         * python/python-internal.h: Rename include guard.
4334         * python/py-stopevent.h: Rename include guard.
4335         * python/py-ref.h: Rename include guard.
4336         * python/py-record.h: Rename include guard.
4337         * python/py-record-full.h: Rename include guard.
4338         * python/py-record-btrace.h: Rename include guard.
4339         * python/py-instruction.h: Rename include guard.
4340         * python/py-events.h: Rename include guard.
4341         * python/py-event.h: Rename include guard.
4342         * procfs.h: Add include guard.
4343         * proc-utils.h: Add include guard.
4344         * p-lang.h: Add include guard.
4345         * or1k-tdep.h: Rename include guard.
4346         * observable.h: Rename include guard.
4347         * nto-tdep.h: Rename include guard.
4348         * nat/x86-linux.h: Rename include guard.
4349         * nat/x86-linux-dregs.h: Rename include guard.
4350         * nat/x86-gcc-cpuid.h: Add include guard.
4351         * nat/x86-dregs.h: Rename include guard.
4352         * nat/x86-cpuid.h: Rename include guard.
4353         * nat/ppc-linux.h: Rename include guard.
4354         * nat/mips-linux-watch.h: Rename include guard.
4355         * nat/linux-waitpid.h: Rename include guard.
4356         * nat/linux-ptrace.h: Rename include guard.
4357         * nat/linux-procfs.h: Rename include guard.
4358         * nat/linux-osdata.h: Rename include guard.
4359         * nat/linux-nat.h: Rename include guard.
4360         * nat/linux-namespaces.h: Rename include guard.
4361         * nat/linux-btrace.h: Rename include guard.
4362         * nat/glibc_thread_db.h: Rename include guard.
4363         * nat/gdb_thread_db.h: Rename include guard.
4364         * nat/gdb_ptrace.h: Rename include guard.
4365         * nat/fork-inferior.h: Rename include guard.
4366         * nat/amd64-linux-siginfo.h: Rename include guard.
4367         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4368         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4369         * nat/aarch64-linux.h: Rename include guard.
4370         * nat/aarch64-linux-hw-point.h: Rename include guard.
4371         * mn10300-tdep.h: Add include guard.
4372         * mips-linux-tdep.h: Add include guard.
4373         * mi/mi-parse.h: Rename include guard.
4374         * mi/mi-out.h: Rename include guard.
4375         * mi/mi-main.h: Rename include guard.
4376         * mi/mi-interp.h: Rename include guard.
4377         * mi/mi-getopt.h: Rename include guard.
4378         * mi/mi-console.h: Rename include guard.
4379         * mi/mi-common.h: Rename include guard.
4380         * mi/mi-cmds.h: Rename include guard.
4381         * mi/mi-cmd-break.h: Rename include guard.
4382         * m2-lang.h: Add include guard.
4383         * location.h: Rename include guard.
4384         * linux-record.h: Rename include guard.
4385         * linux-nat.h: Add include guard.
4386         * linux-fork.h: Add include guard.
4387         * i386-darwin-tdep.h: Rename include guard.
4388         * hppa-linux-offsets.h: Add include guard.
4389         * guile/guile.h: Rename include guard.
4390         * guile/guile-internal.h: Rename include guard.
4391         * gnu-nat.h: Rename include guard.
4392         * gdb-stabs.h: Rename include guard.
4393         * frv-tdep.h: Add include guard.
4394         * f-lang.h: Add include guard.
4395         * event-loop.h: Add include guard.
4396         * darwin-nat.h: Rename include guard.
4397         * cp-abi.h: Rename include guard.
4398         * config/sparc/nm-sol2.h: Rename include guard.
4399         * config/nm-nto.h: Rename include guard.
4400         * config/nm-linux.h: Add include guard.
4401         * config/i386/nm-i386gnu.h: Rename include guard.
4402         * config/djgpp/nl_types.h: Rename include guard.
4403         * config/djgpp/langinfo.h: Rename include guard.
4404         * compile/gcc-cp-plugin.h: Add include guard.
4405         * compile/gcc-c-plugin.h: Add include guard.
4406         * compile/compile.h: Rename include guard.
4407         * compile/compile-object-run.h: Rename include guard.
4408         * compile/compile-object-load.h: Rename include guard.
4409         * compile/compile-internal.h: Rename include guard.
4410         * compile/compile-cplus.h: Rename include guard.
4411         * compile/compile-c.h: Rename include guard.
4412         * common/xml-utils.h: Rename include guard.
4413         * common/x86-xstate.h: Rename include guard.
4414         * common/version.h: Rename include guard.
4415         * common/vec.h: Rename include guard.
4416         * common/tdesc.h: Rename include guard.
4417         * common/selftest.h: Rename include guard.
4418         * common/scoped_restore.h: Rename include guard.
4419         * common/scoped_mmap.h: Rename include guard.
4420         * common/scoped_fd.h: Rename include guard.
4421         * common/safe-iterator.h: Rename include guard.
4422         * common/run-time-clock.h: Rename include guard.
4423         * common/refcounted-object.h: Rename include guard.
4424         * common/queue.h: Rename include guard.
4425         * common/ptid.h: Rename include guard.
4426         * common/print-utils.h: Rename include guard.
4427         * common/preprocessor.h: Rename include guard.
4428         * common/pathstuff.h: Rename include guard.
4429         * common/observable.h: Rename include guard.
4430         * common/netstuff.h: Rename include guard.
4431         * common/job-control.h: Rename include guard.
4432         * common/host-defs.h: Rename include guard.
4433         * common/gdb_wait.h: Rename include guard.
4434         * common/gdb_vecs.h: Rename include guard.
4435         * common/gdb_unlinker.h: Rename include guard.
4436         * common/gdb_unique_ptr.h: Rename include guard.
4437         * common/gdb_tilde_expand.h: Rename include guard.
4438         * common/gdb_sys_time.h: Rename include guard.
4439         * common/gdb_string_view.h: Rename include guard.
4440         * common/gdb_splay_tree.h: Rename include guard.
4441         * common/gdb_setjmp.h: Rename include guard.
4442         * common/gdb_ref_ptr.h: Rename include guard.
4443         * common/gdb_optional.h: Rename include guard.
4444         * common/gdb_locale.h: Rename include guard.
4445         * common/gdb_assert.h: Rename include guard.
4446         * common/filtered-iterator.h: Rename include guard.
4447         * common/filestuff.h: Rename include guard.
4448         * common/fileio.h: Rename include guard.
4449         * common/environ.h: Rename include guard.
4450         * common/common-utils.h: Rename include guard.
4451         * common/common-types.h: Rename include guard.
4452         * common/common-regcache.h: Rename include guard.
4453         * common/common-inferior.h: Rename include guard.
4454         * common/common-gdbthread.h: Rename include guard.
4455         * common/common-exceptions.h: Rename include guard.
4456         * common/common-defs.h: Rename include guard.
4457         * common/common-debug.h: Rename include guard.
4458         * common/cleanups.h: Rename include guard.
4459         * common/buffer.h: Rename include guard.
4460         * common/btrace-common.h: Rename include guard.
4461         * common/break-common.h: Rename include guard.
4462         * cli/cli-utils.h: Rename include guard.
4463         * cli/cli-style.h: Rename include guard.
4464         * cli/cli-setshow.h: Rename include guard.
4465         * cli/cli-script.h: Rename include guard.
4466         * cli/cli-interp.h: Rename include guard.
4467         * cli/cli-decode.h: Rename include guard.
4468         * cli/cli-cmds.h: Rename include guard.
4469         * charset-list.h: Add include guard.
4470         * buildsym-legacy.h: Rename include guard.
4471         * bfin-tdep.h: Add include guard.
4472         * ax.h: Rename include guard.
4473         * arm-linux-tdep.h: Add include guard.
4474         * arm-fbsd-tdep.h: Add include guard.
4475         * arch/xtensa.h: Rename include guard.
4476         * arch/tic6x.h: Add include guard.
4477         * arch/i386.h: Add include guard.
4478         * arch/arm.h: Rename include guard.
4479         * arch/arm-linux.h: Rename include guard.
4480         * arch/arm-get-next-pcs.h: Rename include guard.
4481         * arch/amd64.h: Add include guard.
4482         * arch/aarch64-insn.h: Rename include guard.
4483         * arch-utils.h: Rename include guard.
4484         * annotate.h: Add include guard.
4485         * amd64-darwin-tdep.h: Rename include guard.
4486         * aarch64-linux-tdep.h: Add include guard.
4487         * aarch64-fbsd-tdep.h: Add include guard.
4488         * aarch32-linux-nat.h: Add include guard.
4489
4490 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4491
4492         * macrotab.c (macro_define_internal): New function that
4493         factorizes macro_define_object_internal and macro_define_function
4494         code.
4495         (macro_define_object_internal): Use macro_define_internal.
4496         (macro_define_function): Likewise.
4497
4498 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4499
4500         * macrocmd.c (extract_identifier): Return
4501         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4502         callers.
4503
4504 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4505
4506         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4507
4508 2019-02-05  Tom Tromey  <tom@tromey.com>
4509
4510         * target.c (target_stack::unpush): Move assertion earlier.
4511
4512 2019-01-30  Tom Tromey  <tom@tromey.com>
4513
4514         PR python/23615:
4515         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4516         (gdbpy_parse_and_eval): Likewise.
4517         * python/python-internal.h (gdbpy_allow_threads): New class.
4518
4519 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4520
4521         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4522         (aarch64_fbsd_fpregmap): Move earlier.
4523         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4524         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4525         instead of individual calls to trad_frame_set_reg_addr.
4526         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4527         earlier.
4528         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4529         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4530         instead of individual calls to trad_frame_set_reg_addr.
4531
4532 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4533
4534         * CONTRIBUTE: Replace contribution list with wiki link.
4535
4536 2019-01-25  Tom Tromey  <tom@tromey.com>
4537
4538         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4539
4540 2019-01-25  Tom Tromey  <tom@tromey.com>
4541
4542         * xtensa-linux-nat.c: Fix common/ includes.
4543         * xml-support.h: Fix common/ includes.
4544         * xml-support.c: Fix common/ includes.
4545         * x86-linux-nat.c: Fix common/ includes.
4546         * windows-nat.c: Fix common/ includes.
4547         * varobj.h: Fix common/ includes.
4548         * varobj.c: Fix common/ includes.
4549         * value.c: Fix common/ includes.
4550         * valops.c: Fix common/ includes.
4551         * utils.c: Fix common/ includes.
4552         * unittests/xml-utils-selftests.c: Fix common/ includes.
4553         * unittests/utils-selftests.c: Fix common/ includes.
4554         * unittests/unpack-selftests.c: Fix common/ includes.
4555         * unittests/tracepoint-selftests.c: Fix common/ includes.
4556         * unittests/style-selftests.c: Fix common/ includes.
4557         * unittests/string_view-selftests.c: Fix common/ includes.
4558         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4559         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4560         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4561         * unittests/rsp-low-selftests.c: Fix common/ includes.
4562         * unittests/parse-connection-spec-selftests.c: Fix common/
4563         includes.
4564         * unittests/optional-selftests.c: Fix common/ includes.
4565         * unittests/offset-type-selftests.c: Fix common/ includes.
4566         * unittests/observable-selftests.c: Fix common/ includes.
4567         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4568         * unittests/memrange-selftests.c: Fix common/ includes.
4569         * unittests/memory-map-selftests.c: Fix common/ includes.
4570         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4571         * unittests/function-view-selftests.c: Fix common/ includes.
4572         * unittests/environ-selftests.c: Fix common/ includes.
4573         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4574         * unittests/common-utils-selftests.c: Fix common/ includes.
4575         * unittests/cli-utils-selftests.c: Fix common/ includes.
4576         * unittests/array-view-selftests.c: Fix common/ includes.
4577         * ui-file.c: Fix common/ includes.
4578         * tui/tui-io.c: Fix common/ includes.
4579         * tracepoint.h: Fix common/ includes.
4580         * tracepoint.c: Fix common/ includes.
4581         * tracefile-tfile.c: Fix common/ includes.
4582         * top.h: Fix common/ includes.
4583         * top.c: Fix common/ includes.
4584         * thread.c: Fix common/ includes.
4585         * target/waitstatus.h: Fix common/ includes.
4586         * target/waitstatus.c: Fix common/ includes.
4587         * target.h: Fix common/ includes.
4588         * target.c: Fix common/ includes.
4589         * target-memory.c: Fix common/ includes.
4590         * target-descriptions.c: Fix common/ includes.
4591         * symtab.h: Fix common/ includes.
4592         * symfile.c: Fix common/ includes.
4593         * stap-probe.c: Fix common/ includes.
4594         * spu-linux-nat.c: Fix common/ includes.
4595         * sparc-nat.c: Fix common/ includes.
4596         * source.c: Fix common/ includes.
4597         * solib.c: Fix common/ includes.
4598         * solib-target.c: Fix common/ includes.
4599         * ser-unix.c: Fix common/ includes.
4600         * ser-tcp.c: Fix common/ includes.
4601         * ser-pipe.c: Fix common/ includes.
4602         * ser-base.c: Fix common/ includes.
4603         * selftest-arch.c: Fix common/ includes.
4604         * s12z-tdep.c: Fix common/ includes.
4605         * rust-exp.y: Fix common/ includes.
4606         * rs6000-aix-tdep.c: Fix common/ includes.
4607         * riscv-tdep.c: Fix common/ includes.
4608         * remote.c: Fix common/ includes.
4609         * remote-notif.h: Fix common/ includes.
4610         * remote-fileio.h: Fix common/ includes.
4611         * remote-fileio.c: Fix common/ includes.
4612         * regcache.h: Fix common/ includes.
4613         * regcache.c: Fix common/ includes.
4614         * record-btrace.c: Fix common/ includes.
4615         * python/python.c: Fix common/ includes.
4616         * python/py-type.c: Fix common/ includes.
4617         * python/py-inferior.c: Fix common/ includes.
4618         * progspace.h: Fix common/ includes.
4619         * producer.c: Fix common/ includes.
4620         * procfs.c: Fix common/ includes.
4621         * proc-api.c: Fix common/ includes.
4622         * printcmd.c: Fix common/ includes.
4623         * ppc-linux-nat.c: Fix common/ includes.
4624         * parser-defs.h: Fix common/ includes.
4625         * osdata.c: Fix common/ includes.
4626         * obsd-nat.c: Fix common/ includes.
4627         * nat/x86-linux.c: Fix common/ includes.
4628         * nat/x86-linux-dregs.c: Fix common/ includes.
4629         * nat/x86-dregs.h: Fix common/ includes.
4630         * nat/x86-dregs.c: Fix common/ includes.
4631         * nat/ppc-linux.c: Fix common/ includes.
4632         * nat/mips-linux-watch.h: Fix common/ includes.
4633         * nat/mips-linux-watch.c: Fix common/ includes.
4634         * nat/linux-waitpid.c: Fix common/ includes.
4635         * nat/linux-ptrace.h: Fix common/ includes.
4636         * nat/linux-ptrace.c: Fix common/ includes.
4637         * nat/linux-procfs.c: Fix common/ includes.
4638         * nat/linux-personality.c: Fix common/ includes.
4639         * nat/linux-osdata.c: Fix common/ includes.
4640         * nat/linux-namespaces.c: Fix common/ includes.
4641         * nat/linux-btrace.h: Fix common/ includes.
4642         * nat/linux-btrace.c: Fix common/ includes.
4643         * nat/fork-inferior.c: Fix common/ includes.
4644         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4645         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4646         * nat/aarch64-linux.c: Fix common/ includes.
4647         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4648         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4649         * namespace.h: Fix common/ includes.
4650         * mips-linux-tdep.c: Fix common/ includes.
4651         * minsyms.c: Fix common/ includes.
4652         * mi/mi-parse.h: Fix common/ includes.
4653         * mi/mi-main.c: Fix common/ includes.
4654         * mi/mi-cmd-env.c: Fix common/ includes.
4655         * memrange.h: Fix common/ includes.
4656         * memattr.c: Fix common/ includes.
4657         * maint.h: Fix common/ includes.
4658         * maint.c: Fix common/ includes.
4659         * main.c: Fix common/ includes.
4660         * machoread.c: Fix common/ includes.
4661         * location.c: Fix common/ includes.
4662         * linux-thread-db.c: Fix common/ includes.
4663         * linux-nat.c: Fix common/ includes.
4664         * linux-fork.c: Fix common/ includes.
4665         * inline-frame.c: Fix common/ includes.
4666         * infrun.c: Fix common/ includes.
4667         * inflow.c: Fix common/ includes.
4668         * inferior.h: Fix common/ includes.
4669         * inferior.c: Fix common/ includes.
4670         * infcmd.c: Fix common/ includes.
4671         * inf-ptrace.c: Fix common/ includes.
4672         * inf-child.c: Fix common/ includes.
4673         * ia64-linux-nat.c: Fix common/ includes.
4674         * i387-tdep.c: Fix common/ includes.
4675         * i386-tdep.c: Fix common/ includes.
4676         * i386-linux-tdep.c: Fix common/ includes.
4677         * i386-linux-nat.c: Fix common/ includes.
4678         * i386-go32-tdep.c: Fix common/ includes.
4679         * i386-fbsd-tdep.c: Fix common/ includes.
4680         * i386-fbsd-nat.c: Fix common/ includes.
4681         * guile/scm-type.c: Fix common/ includes.
4682         * guile/guile.c: Fix common/ includes.
4683         * go32-nat.c: Fix common/ includes.
4684         * gnu-nat.c: Fix common/ includes.
4685         * gdbthread.h: Fix common/ includes.
4686         * gdbarch-selftests.c: Fix common/ includes.
4687         * gdb_usleep.c: Fix common/ includes.
4688         * gdb_select.h: Fix common/ includes.
4689         * gdb_bfd.c: Fix common/ includes.
4690         * gcore.c: Fix common/ includes.
4691         * fork-child.c: Fix common/ includes.
4692         * findvar.c: Fix common/ includes.
4693         * fbsd-nat.c: Fix common/ includes.
4694         * event-top.c: Fix common/ includes.
4695         * event-loop.c: Fix common/ includes.
4696         * dwarf2read.c: Fix common/ includes.
4697         * dwarf2loc.c: Fix common/ includes.
4698         * dwarf2-frame.c: Fix common/ includes.
4699         * dwarf-index-cache.c: Fix common/ includes.
4700         * dtrace-probe.c: Fix common/ includes.
4701         * disasm-selftests.c: Fix common/ includes.
4702         * defs.h: Fix common/ includes.
4703         * csky-tdep.c: Fix common/ includes.
4704         * cp-valprint.c: Fix common/ includes.
4705         * cp-support.h: Fix common/ includes.
4706         * cp-support.c: Fix common/ includes.
4707         * corelow.c: Fix common/ includes.
4708         * completer.h: Fix common/ includes.
4709         * completer.c: Fix common/ includes.
4710         * compile/compile.c: Fix common/ includes.
4711         * compile/compile-loc2c.c: Fix common/ includes.
4712         * compile/compile-cplus-types.c: Fix common/ includes.
4713         * compile/compile-cplus-symbols.c: Fix common/ includes.
4714         * command.h: Fix common/ includes.
4715         * cli/cli-dump.c: Fix common/ includes.
4716         * cli/cli-cmds.c: Fix common/ includes.
4717         * charset.c: Fix common/ includes.
4718         * build-id.c: Fix common/ includes.
4719         * btrace.h: Fix common/ includes.
4720         * btrace.c: Fix common/ includes.
4721         * breakpoint.h: Fix common/ includes.
4722         * breakpoint.c: Fix common/ includes.
4723         * ax.h:
4724         (enum agent_op): Fix common/ includes.
4725         * ax-general.c (struct aop_map): Fix common/ includes.
4726         * ax-gdb.c: Fix common/ includes.
4727         * auxv.c: Fix common/ includes.
4728         * auto-load.c: Fix common/ includes.
4729         * arm-tdep.c: Fix common/ includes.
4730         * arch/riscv.c: Fix common/ includes.
4731         * arch/ppc-linux-common.c: Fix common/ includes.
4732         * arch/i386.c: Fix common/ includes.
4733         * arch/arm.c: Fix common/ includes.
4734         * arch/arm-linux.c: Fix common/ includes.
4735         * arch/arm-get-next-pcs.c: Fix common/ includes.
4736         * arch/amd64.c: Fix common/ includes.
4737         * arch/aarch64.c: Fix common/ includes.
4738         * arch/aarch64-insn.c: Fix common/ includes.
4739         * arch-utils.c: Fix common/ includes.
4740         * amd64-windows-tdep.c: Fix common/ includes.
4741         * amd64-tdep.c: Fix common/ includes.
4742         * amd64-sol2-tdep.c: Fix common/ includes.
4743         * amd64-obsd-tdep.c: Fix common/ includes.
4744         * amd64-nbsd-tdep.c: Fix common/ includes.
4745         * amd64-linux-tdep.c: Fix common/ includes.
4746         * amd64-linux-nat.c: Fix common/ includes.
4747         * amd64-fbsd-tdep.c: Fix common/ includes.
4748         * amd64-fbsd-nat.c: Fix common/ includes.
4749         * amd64-dicos-tdep.c: Fix common/ includes.
4750         * amd64-darwin-tdep.c: Fix common/ includes.
4751         * agent.c: Fix common/ includes.
4752         * ada-lang.h: Fix common/ includes.
4753         * ada-lang.c: Fix common/ includes.
4754         * aarch64-tdep.c: Fix common/ includes.
4755
4756 2019-01-25  Tom Tromey  <tom@tromey.com>
4757
4758         * common/create-version.sh: Use common/version.h.
4759
4760 2019-01-24  Pedro Alves  <palves@redhat.com>
4761
4762         * infrun.c (signal_stop, signal_print, signal_program)
4763         (signal_catch, signal_pass): Now arrays instead of pointers.
4764         (update_signals_program_target, do_target_resume)
4765         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4766         * linux-nat.c (linux_nat_target::pass_signals)
4767         (linux_nat_target::create_inferior, linux_nat_target::attach):
4768         Adjust.
4769         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4770         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4771         * procfs.c (procfs_target::pass_signals): Adjust.
4772         * record-full.c (record_full_target::resume): Adjust.
4773         * remote.c (remote_target::pass_signals)
4774         (remote_target::program_signals): Adjust.
4775         * target-debug.h (target_debug_print_signals): Now takes a
4776         gdb::array_view as parameter.  Adjust.
4777         * target.h (target_ops) <pass_signals, program_signals>: Replace
4778         pointer and length parameters with gdb::array_view.
4779         (target_pass_signals, target_program_signals): Likewise.
4780         * target-delegates.c: Regenerate.
4781
4782 2019-01-24  Pedro Alves  <palves@redhat.com>
4783
4784         * common/forward-scope-exit.h
4785         (forward_scope_exit::forward_scope_exit): Pass arguments to
4786         m_bind_function directly, instead of creating a std::bind and
4787         copying that.
4788
4789 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4790
4791         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4792         for static members.
4793         (pass_in_v_vfp_candidate): Likewise.
4794
4795 2019-01-23  Tom Tromey  <tom@tromey.com>
4796             Pedro Alves  <palves@redhat.com>
4797
4798         * regcache.c (class regcache_invalidator): Remove.
4799         (regcache::raw_write): Use make_scope_exit.
4800
4801 2019-01-23  Tom Tromey  <tom@tromey.com>
4802
4803         * ui-out.h (class ui_out_emit_type): Update comment.
4804
4805 2019-01-23  Tom Tromey  <tom@tromey.com>
4806
4807         * infrun.c (fetch_inferior_event): Update comment.
4808
4809 2019-01-23  Tom Tromey  <tom@tromey.com>
4810             Pedro Alves  <palves@redhat.com>
4811
4812         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4813         parameter.
4814         (fetch_inferior_event): Use SCOPE_EXIT.
4815
4816
4817 2019-01-23  Tom Tromey  <tom@tromey.com>
4818             Pedro Alves  <palves@redhat.com>
4819
4820         * infrun.c (disable_thread_events): Delete.
4821         (stop_all_threads): Use SCOPE_EXIT.
4822
4823 2019-01-23  Tom Tromey  <tom@tromey.com>
4824             Pedro Alves  <palves@redhat.com>
4825
4826         * symfile.c: Include forward-scope-exit.h.
4827         (clear_symtab_users_cleanup): Replace forward declaration with
4828         a FORWARD_SCOPE_EXIT.
4829         (syms_from_objfile_1): Use the forward_scope_exit and
4830         gdb::optional instead of cleanup_function.
4831         (reread_symbols): Use the forward_scope_exit instead of
4832         cleanup_function.
4833         (clear_symtab_users_cleanup): Remove function.
4834
4835 2019-01-23  Tom Tromey  <tom@tromey.com>
4836             Pedro Alves  <palves@redhat.com>
4837
4838         * linux-nat.c: Include scope-exit.h.
4839         (cleanup_target_stop): Remove.
4840         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4841         SCOPE_EXIT.
4842
4843 2019-01-23  Tom Tromey  <tom@tromey.com>
4844             Pedro Alves  <palves@redhat.com>
4845
4846         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4847         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4848
4849 2019-01-23  Tom Tromey  <tom@tromey.com>
4850             Andrew Burgess  <andrew.burgess@embecosm.com>
4851             Pedro Alves  <palves@redhat.com>
4852
4853         * infrun.c (fetch_inferior_event): Use scope_exit.
4854         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4855         * top.c (execute_command): Use scope_exit.
4856         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4857         * utils.c (do_bpstat_clear_actions_cleanup)
4858         (make_bpstat_clear_actions_cleanup): Remove.
4859
4860 2019-01-23  Tom Tromey  <tom@tromey.com>
4861             Pedro Alves  <palves@redhat.com>
4862
4863         * infrun.c: Include "common/scope-exit.h"
4864         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4865         (wait_for_inferior): Use SCOPE_EXIT.
4866         (fetch_inferior_event): Use scope_exit.
4867
4868 2019-01-23  Tom Tromey  <tom@tromey.com>
4869             Pedro Alves  <palves@redhat.com>
4870
4871         * breakpoint.c (create_breakpoint): Remove cleanup.
4872
4873 2019-01-23  Tom Tromey  <tom@tromey.com>
4874             Andrew Burgess  <andrew.burgess@embecosm.com>
4875             Pedro Alves  <palves@redhat.com>
4876
4877 2019-01-23  Pedro Alves  <palves@redhat.com>
4878
4879         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4880
4881 2019-01-23  Pedro Alves  <palves@redhat.com>
4882             Andrew Burgess  <andrew.burgess@embecosm.com>
4883
4884         * gdbthread.h: Include "common/forward-scope-exit.h".
4885         (scoped_finish_thread_state): Redefine custom class in terms of
4886         forward_scope_exit.
4887
4888 2019-01-23  Pedro Alves  <palves@redhat.com>
4889             Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * common/forward-scope-exit.h: New file.
4892
4893 2019-01-23  Pedro Alves  <palves@redhat.com>
4894             Andrew Burgess  <andrew.burgess@embecosm.com>
4895             Tom Tromey  <tom@tromey.com>
4896
4897         * common/scope-exit.h: New file.
4898
4899 2019-01-23  Pedro Alves  <palves@redhat.com>
4900
4901         * common/preprocessor.h (ESC): Rename to ...
4902         (ESC_PARENS): ... this.
4903         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4904         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4905
4906 2019-01-23  Tom Tromey  <tom@tromey.com>
4907
4908         * language.h (class scoped_switch_to_sym_language_if_auto):
4909         Initialize m_lang in both cases.
4910
4911 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4912
4913         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4914         with XCNEW.
4915
4916 2019-01-22  Tom Tromey  <tom@tromey.com>
4917
4918         * corelow.c: Do not include sys/file.h.
4919
4920 2019-01-22  Tom Tromey  <tom@tromey.com>
4921
4922         * tui/tui-wingeneral.h: Include gdb_curses.h.
4923
4924 2019-01-22  Tom Tromey  <tom@tromey.com>
4925
4926         * source-cache.h (class source_cache) <get_source_lines,
4927         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4928
4929 2019-01-22  Tom Tromey  <tom@tromey.com>
4930
4931         * remote-fileio.h (struct remote_target): Declare.
4932
4933 2019-01-22  Tom Tromey  <tom@tromey.com>
4934
4935         * python/py-arch.c: Do not include py-ref.h.
4936         * python/py-bpevent.c: Do not include py-ref.h.
4937         * python/py-cmd.c: Do not include py-ref.h.
4938         * python/py-continueevent.c: Do not include py-ref.h.
4939         * python/py-event.h: Do not include py-ref.h.
4940         * python/py-evtregistry.c: Do not include py-ref.h.
4941         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4942         * python/py-frame.c: Do not include py-ref.h.
4943         * python/py-framefilter.c: Do not include py-ref.h.
4944         * python/py-function.c: Do not include py-ref.h.
4945         * python/py-infevents.c: Do not include py-ref.h.
4946         * python/py-linetable.c: Do not include py-ref.h.
4947         * python/py-objfile.c: Do not include py-ref.h.
4948         * python/py-param.c: Do not include py-ref.h.
4949         * python/py-prettyprint.c: Do not include py-ref.h.
4950         * python/py-progspace.c: Do not include py-ref.h.
4951         * python/py-symbol.c: Do not include py-ref.h.
4952         * python/py-symtab.c: Do not include py-ref.h.
4953         * python/py-type.c: Do not include py-ref.h.
4954         * python/py-unwind.c: Do not include py-ref.h.
4955         * python/py-utils.c: Do not include py-ref.h.
4956         * python/py-value.c: Do not include py-ref.h.
4957         * python/py-varobj.c: Do not include py-ref.h.
4958         * python/py-xmethods.c: Do not include py-ref.h.
4959         * python/python.c: Do not include py-ref.h.
4960         * varobj.c: Do not include py-ref.h.
4961
4962 2019-01-22  Tom Tromey  <tom@tromey.com>
4963
4964         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4965         keyword for bcache.
4966
4967 2019-01-22  Tom Tromey  <tom@tromey.com>
4968
4969         * compile/compile-cplus-types.c: Remove a comment by #include.
4970
4971 2019-01-22  Tom Tromey  <tom@tromey.com>
4972
4973         * compile/gcc-c-plugin.h: Include compile-internal.h.
4974
4975 2019-01-22  Tom Tromey  <tom@tromey.com>
4976
4977         * stabsread.c (EXTERN): Do not define.
4978         (symnum, next_symbol_text_func, processing_gcc_compilation)
4979         (within_function, global_sym_chain, global_stabs)
4980         (previous_stab_code, this_object_header_files)
4981         (n_this_object_header_files)
4982         (n_allocated_this_object_header_files): Define.
4983         * stabsread.h (EXTERN): Never define.  Use "extern".
4984
4985 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4986
4987         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4988         history_value.
4989
4990 2019-01-21  Tom Tromey  <tom@tromey.com>
4991
4992         * ui-out.c: Fix includes.
4993         * tui/tui-source.c: Fix includes.
4994         * target.c: Fix includes.
4995         * remote.c: Fix includes.
4996         * regcache.c: Fix includes.
4997         * python/py-block.c: Fix includes.
4998         * printcmd.c: Fix includes.
4999         * or1k-tdep.c: Fix includes.
5000         * mi/mi-main.c: Fix includes.
5001         * m32r-tdep.c: Fix includes.
5002         * csky-tdep.c: Fix includes.
5003         * compile/compile-cplus-types.c: Fix includes.
5004         * cli/cli-interp.c: Fix includes.
5005
5006 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5007
5008         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5009         for padding.
5010
5011 2019-01-16  Tom Tromey  <tom@tromey.com>
5012
5013         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5014         earlier.
5015         (struct objfile) <msymbols_range>: Move from top level.
5016         <msymbols>: New method.
5017         (class objfile_msymbols): Remove.
5018         * symtab.c (default_collect_symbol_completion_matches_break_on):
5019         Update.
5020         * symmisc.c (dump_msymbols): Update.
5021         * stabsread.c (scan_file_globals): Update.
5022         * objc-lang.c (info_selectors_command, info_classes_command)
5023         (find_methods): Update.
5024         * minsyms.c (find_solib_trampoline_target): Update.
5025         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5026         * coffread.c (coff_symfile_read): Update.
5027         * ada-lang.c (ada_lookup_simple_minsym)
5028         (ada_collect_symbol_completion_matches): Update.
5029
5030 2019-01-16  Tom Tromey  <tom@tromey.com>
5031
5032         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5033         type.  Remove no-argument constructor.
5034         <iterator::operator++>: Simplify.
5035         <begin>: Update.
5036         <end>: Use minimal_symbol_count.
5037
5038 2019-01-16  Tom Tromey  <tom@tromey.com>
5039
5040         * objfiles.h (struct objfile) <psymtabs>: New method.
5041         (class objfile_psymtabs): Remove.
5042         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5043         typedef.
5044         <range>: New method.
5045         (require_partial_symbols): Change return type.
5046         * psymtab.c (require_partial_symbols)
5047         (psym_expand_symtabs_matching): Update.
5048         * mdebugread.c (parse_partial_symbols): Update.
5049         * dbxread.c (dbx_end_psymtab): Update.
5050
5051 2019-01-15  Tom Tromey  <tom@tromey.com>
5052
5053         * symtab.c (lookup_objfile_from_block)
5054         (lookup_symbol_in_objfile_symtabs)
5055         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5056         (find_line_symtab, info_sources_command)
5057         (default_collect_symbol_completion_matches_break_on)
5058         (make_source_files_completion_list): Update.
5059         * symmisc.c (print_objfile_statistics, dump_objfile)
5060         (maintenance_print_symbols, maintenance_info_symtabs)
5061         (maintenance_check_symtabs, maintenance_info_line_tables):
5062         Update.
5063         * source.c (select_source_symtab)
5064         (forget_cached_source_info_for_objfile): Update.
5065         * objfiles.h (class objfile_compunits): Remove.
5066         (struct objfile) <compunits_range>: New typedef.
5067         (compunits): New method.
5068         * objfiles.c (objfile_relocate1): Update.
5069         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5070         * maint.c (count_symtabs_and_blocks): Update.
5071         * linespec.c (iterate_over_all_matching_symtabs): Update.
5072         * cp-support.c (add_symbol_overload_list_qualified): Update.
5073         * coffread.c (coff_symtab_read): Update.
5074         * ada-lang.c (add_nonlocal_symbols)
5075         (ada_collect_symbol_completion_matches)
5076         (ada_add_global_exceptions): Update.
5077
5078 2019-01-15  Tom Tromey  <tom@tromey.com>
5079
5080         * progspace.h (program_space) <objfiles_safe_range>: New
5081         typedef.
5082         <objfiles_safe>: New method.
5083         * objfiles.h (class all_objfiles_safe): Remove.
5084         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5085         * jit.c (jit_inferior_exit_hook): Update.
5086
5087 2019-01-17  Tom Tromey  <tom@tromey.com>
5088
5089         * progspace.h (program_space) <objfiles_range>: New typedef.
5090         <objfiles>: New method.
5091         <objfiles_head>: Rename from objfiles.
5092         (object_files): Update.
5093         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5094         * guile/scm-pretty-print.c
5095         (ppscm_find_pretty_printer_from_objfiles): Update.
5096         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5097         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5098         Update.
5099         * python/py-progspace.c (pspy_get_objfiles): Update.
5100         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5101         Update.
5102         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5103         (objfpy_lookup_objfile_by_build_id): Update.
5104         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5105         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5106         Update.
5107         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5108         (expand_symtab_containing_pc, lookup_objfile_from_block)
5109         (lookup_static_symbol, basic_lookup_transparent_type)
5110         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5111         (find_line_symtab, info_sources_command)
5112         (default_collect_symbol_completion_matches_break_on)
5113         (make_source_files_completion_list, find_main_name): Update.
5114         * symmisc.c (print_symbol_bcache_statistics)
5115         (print_objfile_statistics, maintenance_print_symbols)
5116         (maintenance_print_msymbols, maintenance_print_objfiles)
5117         (maintenance_info_symtabs, maintenance_check_symtabs)
5118         (maintenance_expand_symtabs, maintenance_info_line_tables):
5119         Update.
5120         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5121         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5122         (map_overlay_command, unmap_overlay_command)
5123         (simple_overlay_update, expand_symtabs_matching)
5124         (map_symbol_filenames): Update.
5125         * symfile-debug.c (set_debug_symfile): Update.
5126         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5127         Update.
5128         * source.c (select_source_symtab, forget_cached_source_info):
5129         Update.
5130         * solib.c (solib_read_symbols): Update.
5131         * solib-spu.c (append_ocl_sos): Update.
5132         * psymtab.c (maintenance_print_psymbols)
5133         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5134         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5135         * printcmd.c (info_symbol_command): Update.
5136         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5137         Update.
5138         * objfiles.h (class all_objfiles): Remove.
5139         * objfiles.c (have_partial_symbols, have_full_symbols)
5140         (have_minimal_symbols, qsort_cmp, update_section_map)
5141         (shared_objfile_contains_address_p)
5142         (default_iterate_over_objfiles_in_search_order): Update.
5143         * objc-lang.c (info_selectors_command, info_classes_command)
5144         (find_methods): Update.
5145         * minsyms.c (find_solib_trampoline_target): Update.
5146         * maint.c (maintenance_info_sections)
5147         (maintenance_translate_address, count_symtabs_and_blocks):
5148         Update.
5149         * main.c (captured_main_1): Update.
5150         * linux-thread-db.c (try_thread_db_load_from_pdir)
5151         (has_libpthread): Update.
5152         * linespec.c (iterate_over_all_matching_symtabs)
5153         (search_minsyms_for_name): Update.
5154         * jit.c (jit_find_objf_with_entry_addr): Update.
5155         * hppa-tdep.c (find_unwind_entry)
5156         (hppa_lookup_stub_minimal_symbol): Update.
5157         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5158         Update.
5159         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5160         (elf_gnu_ifunc_resolve_by_got): Update.
5161         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5162         * dwarf-index-write.c (save_gdb_index_command): Update.
5163         * cp-support.c (add_symbol_overload_list_qualified): Update.
5164         * breakpoint.c (create_overlay_event_breakpoint)
5165         (create_longjmp_master_breakpoint)
5166         (create_std_terminate_master_breakpoint)
5167         (create_exception_master_breakpoint): Update.
5168         * blockframe.c (find_pc_partial_function): Update.
5169         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5170         (ada_collect_symbol_completion_matches)
5171         (ada_add_global_exceptions): Update.
5172
5173 2019-01-17  Tom Tromey  <tom@tromey.com>
5174
5175         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5176         declare VEC.
5177         (solib_target_parse_libraries): Change return type.
5178         (library_list_start_segment, library_list_start_section)
5179         (library_list_end_library, library_list_start_library); Update.
5180         (solib_target_free_library_list): Remove.
5181         (solib_target_parse_libraries): Remove cleanup.  Change return
5182         type.
5183         (solib_target_current_sos): Update.
5184
5185 2019-01-17  Tom Tromey  <tromey@bapiya>
5186
5187         * valprint.c: Replace "the the" with "the".
5188         * symtab.c: Replace "the the" with "the".
5189         * solib.c: Replace "the the" with "the".
5190         * solib-dsbt.c: Replace "the the" with "the".
5191         * linespec.c: Replace "the the" with "the".
5192         * dwarf2loc.h: Replace "the the" with "the".
5193         * amd64-windows-tdep.c: Replace "the the" with "the".
5194         * aarch64-tdep.c: Replace "the the" with "the".
5195
5196 2019-01-16  Keith Seitz  <keiths@redhat.com>
5197
5198         PR gdb/23773
5199         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5200         <builder>: Rename to ..
5201         <m_builder>: ... this and make private.
5202         (dwarf2_cu::get_builder): New method.  Change all users of
5203         `builder' to use this method.
5204         (dwarf2_start_symtab): Move to ...
5205         (dwarf2_cu::start_symtab): ... here.  Update all callers
5206         (setup_type_unit_groups): Move to ...
5207         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5208         callers.
5209         (dwarf2_cu::reset_builder): New method.
5210         (process_full_compunit, process_full_type_unit): Use
5211         dwarf2_cu::reset_builder.
5212         (follow_die_offset): Record the ancestor CU if it is different
5213         from the followed DIE's CU.
5214         (follow_die_sig_1): Likewise.
5215
5216 2019-01-15  Tom Tromey  <tom@tromey.com>
5217
5218         * remote.c (class remote_state) <buf>: Now a char_vector.
5219         <buf_size>: Remove.
5220         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5221         parameter.
5222         (remote_target::getpkt_or_notif_sane_1)
5223         (remote_target::getpkt_sane)
5224         (remote_target::getpkt_or_notif_sane): Likewise.
5225         (class remote_target) <putpkt>: New overload.
5226         (remote_target::read_frame): Change type of "buf_p".  Remove
5227         sizeof_p parameter.
5228         (packet_ok): New overload.
5229         (packet_check_result): New overload.
5230         Update all uses.
5231
5232 2019-01-14  Tom Tromey  <tom@tromey.com>
5233
5234         * remote-notif.c (handle_notification, remote_notif_ack)
5235         (remote_notif_parse): Make "buf" const.
5236         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5237         const.
5238         (remote_notif_parse, remote_notif_ack, handle_notification):
5239         Likewise.
5240         * remote.c (remote_notif_stop_parse): Make "buf" const.
5241         (remote_target::remote_parse_stop_reply): Make "buf" const.
5242         (remote_notif_stop_ack): Make "buf" const.
5243
5244 2019-01-14  Tom Tromey  <tom@tromey.com>
5245
5246         * remote.c (remote_console_output): Make parameter const.
5247
5248 2019-01-14  Tom Tromey  <tom@tromey.com>
5249
5250         * target-debug.h (target_debug_print_signals): Constify.
5251         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5252         * procfs.c (procfs_target::pass_signals): Update.
5253         * linux-nat.c (linux_nat_target::pass_signals): Update.
5254         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5255         * target-delegates.c: Rebuild.
5256         * remote.c (remote_target::program_signals): Update.
5257         (remote_target::pass_signals): Update.
5258         * target.c (target_pass_signals): Constify argument.
5259         (target_program_signals): Likewise.
5260         * target.h (struct target_ops) <pass_signals, program_signals>:
5261         Constify argument.
5262         (target_pass_signals, target_program_signals): Constify argument.
5263
5264 2019-01-14  Tom Tromey  <tom@tromey.com>
5265
5266         PR tui/28819:
5267         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5268
5269 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5270
5271         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5272         field.
5273         * rs6000-tdep.c: Include reggroups.h.
5274         (IS_V_ALIAS_PSEUDOREG): Define.
5275         (rs6000_register_name): Return names for the "vX" aliases.
5276         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5277         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5278         aliases.  Call default_register_reggroup_p for all other
5279         pseudo-registers.
5280         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5281         New functions.
5282         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5283         Handle "vX" aliases.
5284         (v_alias_pseudo_register_collect): New function.
5285         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5286         (rs6000_gdbarch_init): Initialize "vX" aliases as
5287         pseudo-registers.  Restore registration of
5288         rs6000_pseudo_register_reggroup_p with
5289         set_tdesc_pseudo_register_reggroup_p.
5290
5291 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5292
5293         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5294         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5295         set_gdbarch_num_pseudo_regs.
5296
5297 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5298
5299         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5300         Remove arg prefixname, add do_set and do_show.
5301         Add member functions set_list and show_list.
5302         * cli/cli-style.c (class cli_style_option): Update accordingly.
5303         (style_set_list): Move to file scope.
5304         (style_show_list): Likewise.
5305         (set_style): Call help_list.
5306         (show_style): Call cmd_show_list.
5307         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5308         Update to use the new macro.
5309
5310 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5311
5312         * ada-lang.c (_initialize_ada_language): Expand the help text
5313         for the "catch exception" command.
5314
5315 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5316
5317         * symtab.c (matching_obj_sections): Initialize obj,
5318         declare it closer to its usage.
5319
5320 2019-01-10  Tom Tromey  <tom@tromey.com>
5321
5322         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5323         (basic_inf_threads_range): Remove.
5324         (inf_threads_range, inf_non_exited_threads_range)
5325         (safe_inf_threads_range): Use next_adapter.
5326
5327 2019-01-10  Keith Seitz  <keiths@redhat.com>
5328
5329         PR gdb/23712
5330         PR symtab/23010
5331         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5332         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5333
5334 2019-01-10  Keith Seitz  <keiths@redhat.com>
5335
5336         PR gdb/23712
5337         PR symtab/23010
5338         * dictionary.c (pending_to_vector): Remove.
5339         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5340         Remove _1 suffix, replacing functions of the same name.  Update
5341         all callers.
5342         (dict_create_hashed, dict_create_hashed_expandable)
5343         (dict_create_linear, dict_create_linear_expandable, dict_free)
5344         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5345         Make functions static.
5346
5347 2019-01-10  Keith Seitz  <keiths@redhat.com>
5348
5349         PR gdb/23712
5350         PR symtab/23010
5351         * dictionary.h (struct dictionary): Replace declaration with
5352         multidictionary.
5353         (dict_create_hashed, dict_create_hashed_expandable)
5354         (dict_create_linear, dict_create_linear_expandable)
5355         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5356         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5357         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5358         taking multidictionary argument.
5359         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5360         * block.h (struct block) <dict>: Change to multidictionary
5361         and rename `multidict'.
5362         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5363         symmisc.c: Update all dictionary references to multidictionary.
5364
5365 2019-01-10  Keith Seitz  <keiths@redhat.com>
5366
5367         PR gdb/23712
5368         PR symtab/23010
5369         * dictionary.c: Include unordered_map.
5370         (pending_to_vector): New function.
5371         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5372         Rewrite the non-"_1" functions to take vector instead
5373         of linked list.
5374         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5375         "new" _1 versions of the same name.
5376         (multidictionary): Define.
5377         (std::hash<enum language): New definition.
5378         (collate_pending_symbols_by_language, mdict_create_hashed)
5379         (mdict_create_hashed_expandable, mdict_create_linear)
5380         (mdict_create_linear_expandable, mdict_free)
5381         (find_language_dictionary, create_new_language_dictionary)
5382         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5383         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5384         (mdict_size, mdict_empty): New functions.
5385         * dictionary.h (mdict_iterator): Define.
5386
5387 2019-01-10  Pedro Alves  <palves@redhat.com>
5388
5389         * breakpoint.c (read_uploaded_action)
5390         (create_tracepoint_from_upload): Adjust to use
5391         gdb::unique_xmalloc_ptr.
5392         * ctf.c (ctf_write_uploaded_tp):
5393         (SET_ARRAY_FIELD): Use emplace_back.
5394         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5395         * tracefile-tfile.c (tfile_write_uploaded_tp):
5396         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5397         gdb::unique_xmalloc_ptr.
5398         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5399         at_string, cond_string, cmd_strings>: Replace char pointers
5400         with gdb::unique_xmalloc_ptr.
5401
5402 2019-01-10  Pedro Alves  <palves@redhat.com>
5403
5404         * solib-target.c (library_list_start_library): Don't xstrdup name.
5405
5406 2019-01-10  Pedro Alves  <palves@redhat.com>
5407
5408         * mdebugread.c (parse_partial_symbols): Use
5409         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5410
5411 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5412
5413         * linux-fork.c (scoped_switch_fork_info)
5414         <~scoped_switch_fork_info>: Fix incorrect variable name.
5415
5416 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5417
5418         * linux-fork.c (scoped_switch_fork_info)
5419         <scoped_switch_fork_info>: Make explicit.
5420         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5421
5422 2019-01-10  Tom Tromey  <tom@tromey.com>
5423
5424         * objfiles.h (objfile::reset_psymtabs): Update.
5425         * objfiles.c (objfile::objfile): Update.
5426         * psymtab.h (psymtab_storage::obstack): Update.
5427         (psymtab_storage::m_obstack): Use gdb::optional.
5428         (class psymtab_storage): Update comment.  Remove objfile
5429         parameter.
5430         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5431
5432 2019-01-10  Tom Tromey  <tom@tromey.com>
5433
5434         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5435         <free_psymtabs>: Now private.
5436         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5437         (allocate_psymtab): Use new method.
5438
5439 2019-01-10  Tom Tromey  <tom@tromey.com>
5440
5441         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5442         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5443         * mdebugread.c (parse_partial_symbols): Use
5444         allocate_dependencies.
5445         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5446         allocate_dependencies.
5447         (process_psymtab_comp_unit_reader)
5448         (build_type_psymtab_dependencies): Likewise.
5449         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5450
5451 2019-01-10  Tom Tromey  <tom@tromey.com>
5452
5453         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5454         PSYMBOL_SET_LANGUAGE.
5455         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5456
5457 2019-01-10  Tom Tromey  <tom@tromey.com>
5458
5459         * psymtab.h (psymtab_storage::obstack): New method.
5460         <m_obstack>: Rename from obstack; now private.
5461         * psymtab.c (psymtab_storage): Update.
5462         * dwarf2read.c (create_addrmap_from_index)
5463         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5464         Update.
5465
5466 2019-01-10  Tom Tromey  <tom@tromey.com>
5467
5468         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5469         * objfiles.h (objfile::reset_psymtabs): New method.
5470
5471 2019-01-10  Tom Tromey  <tom@tromey.com>
5472
5473         * symmisc.c (print_symbol_bcache_statistics): Update.
5474         (print_objfile_statistics): Update.
5475         * symfile.c (reread_symbols): Update.
5476         * psymtab.h (class psymtab_storage): New.
5477         * psymtab.c (psymtab_storage): New constructor.
5478         (~psymtab_storage): New destructor.
5479         (require_partial_symbols): Update.
5480         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5481         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5482         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5483         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5484         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5485         (start_psymtab_common, end_psymtab_common)
5486         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5487         (allocate_psymtab): Update.
5488         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5489         Update.
5490         (dump_psymtab_addrmap, maintenance_print_psymbols)
5491         (maintenance_check_psymtabs): Update.
5492         (class objfile_psymtabs): Move to objfiles.h.
5493         * psympriv.h (discard_psymtab): Now inline.
5494         (psymtab_discarder::psymtab_discarder): Update.
5495         (psymtab_discarder::~psymtab_discarder): Update.
5496         (ALL_OBJFILE_PSYMTABS): Rewrite.
5497         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5498         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5499         Remove fields.
5500         <partial_symtabs>: New field.
5501         (class objfile_psymtabs): Move from psymtab.h.  Update.
5502         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5503         psymbol_cache.
5504         (objfile::~objfile): Don't destroy psymbol_cache.
5505         * mdebugread.c (parse_partial_symbols): Update.
5506         * dwarf2read.c (create_addrmap_from_index)
5507         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5508         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5509         (add_partial_subprogram, dwarf2_ranges_read): Update.
5510         * dwarf-index-write.c (write_address_map)
5511         (write_one_signatured_type, recursively_write_psymbols)
5512         (class debug_names, class debug_names, write_psymtabs_to_index):
5513         Update.
5514
5515 2019-01-10  Tom Tromey  <tom@tromey.com>
5516
5517         * symtab.h (SYMBOL_SET_NAMES): Update.
5518         (symbol_set_names): Update.
5519         (MSYMBOL_SET_NAMES): Update.
5520         * symtab.c (symbol_set_names): Change argument to be an
5521         objfile_per_bfd_storage.
5522         * psymtab.c (add_psymbol_to_bcache): Update.
5523         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5524
5525 2019-01-10  Tom Tromey  <tom@tromey.com>
5526
5527         * symtab.c (create_demangled_names_hash): Change argument to be an
5528         objfile_per_bfd_storage.
5529         (symbol_set_names): Update.
5530
5531 2019-01-10  Tom Tromey  <tom@tromey.com>
5532
5533         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5534         init_psymbol_list.
5535         * psymtab.c (init_psymbol_list): Do nothing if already called.
5536         * psympriv.h (init_psymbol_list): Add comment.
5537         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5538         init_psymbol_list.
5539         * dbxread.c (dbx_symfile_read): Unconditionally call
5540         init_psymbol_list.
5541
5542 2019-01-10  Tom Tromey  <tom@tromey.com>
5543
5544         * xcoffread.c (scan_xcoff_symtab): Update.
5545         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5546         "where".
5547         * mdebugread.c (parse_partial_symbols)
5548         (handle_psymbol_enumerators): Update.
5549         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5550         * dbxread.c (read_dbx_symtab): Update.
5551         * psympriv.h (psymbol_placement): New enum.
5552         (add_psymbol_to_list): Update.
5553
5554 2019-01-10  Tom Tromey  <tom@tromey.com>
5555
5556         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5557         static_psymbols parameters.
5558         (scan_xcoff_symtab): Update.
5559         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5560         static_psymbols parameters.
5561         * psympriv.h (start_psymtab_common): Update.
5562         * mdebugread.c (parse_partial_symbols): Update.
5563         * dwarf2read.c (create_partial_symtab): Update.
5564         * dbxread.c (read_dbx_symtab): Update.
5565         (start_psymtab): Remove global_psymbols and static_psymbols
5566         parameters.
5567
5568 2019-01-10  Tom Tromey  <tom@tromey.com>
5569
5570         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5571         * psymtab.c (allocate_psymtab): Add comment.
5572         * psympriv.h (allocate_psymtab): Add comment.
5573         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5574         initializations.
5575         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5576
5577 2019-01-10  Tom Tromey  <tom@tromey.com>
5578
5579         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5580         Don't declare.
5581         * mipsread.c: Include mdebugread.h.
5582         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5583         Declare.
5584         * elfread.c: Include mdebugread.h.
5585
5586 2019-01-09  Tom Tromey  <tom@tromey.com>
5587
5588         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5589         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5590         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5591         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5592         (psym_lookup_symbol, psym_find_last_source_symtab)
5593         (psym_forget_cached_source_info, psym_print_stats)
5594         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5595         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5596         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5597         (psym_find_compunit_symtab_by_address)
5598         (maintenance_print_psymbols, maintenance_info_psymtabs)
5599         (maintenance_check_psymtabs): Use ranged for.
5600         * psymtab.h (class objfile_psymtabs): New.
5601         (require_partial_symbols): Return objfile_psymtabs.
5602         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5603
5604 2019-01-09  Tom Tromey  <tom@tromey.com>
5605
5606         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5607         (find_pc_mapped_section, list_overlays_command)
5608         (map_overlay_command, unmap_overlay_command)
5609         (simple_overlay_update): Use all_objfiles.
5610         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5611         * printcmd.c (info_symbol_command): Use all_objfiles.
5612         * objfiles.h (ALL_OBJSECTIONS): Remove.
5613         * maint.c (maintenance_translate_address): Use all_objfiles.
5614         * gcore.c (gcore_create_callback): Use all_objfiles.
5615         (objfile_find_memory_regions): Likewise.
5616
5617 2019-01-09  Tom Tromey  <tom@tromey.com>
5618
5619         * symtab.c (find_line_symtab, info_sources_command)
5620         (make_source_files_completion_list): Use objfile_compunits.
5621         * source.c (select_source_symtab): Use objfile_compunits.
5622         * objfiles.h (struct objfile): Update comment.
5623         (ALL_OBJFILES): Remove.
5624         (ALL_FILETABS): Remove.
5625         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5626         objfile_compunits.
5627
5628 2019-01-09  Tom Tromey  <tom@tromey.com>
5629
5630         * symmisc.c (print_objfile_statistics, dump_objfile)
5631         (maintenance_print_symbols): Use compunit_filetabs.
5632         * source.c (forget_cached_source_info_for_objfile): Use
5633         compunit_filetabs.
5634         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5635         (ALL_FILETABS): Use compunit_filetabs.
5636         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5637         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5638
5639 2019-01-09  Tom Tromey  <tom@tromey.com>
5640
5641         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5642         (compunit_filetabs): New.
5643         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5644         compunit_filetabs.
5645         (info_sources_command, make_source_files_completion_list): Remove
5646         declaration.
5647         * symmisc.c (print_objfile_statistics, dump_objfile)
5648         (maintenance_print_symbols): Remove declaration.
5649         (maintenance_info_symtabs): Use compunit_filetabs.
5650         (maintenance_info_line_tables): Likewise.
5651         * source.c (select_source_symtab): Change local variable name.
5652         (forget_cached_source_info_for_objfile): Remove declaration.
5653         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5654         * objfiles.c (objfile_relocate1): Remove declaration.
5655         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5656         declaration.
5657         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5658         * coffread.c (coff_symtab_read): Remove declaration.
5659         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5660         compunit_filetabs.
5661
5662 2019-01-09  Tom Tromey  <tom@tromey.com>
5663
5664         * symtab.c (lookup_objfile_from_block)
5665         (find_pc_sect_compunit_symtab, search_symbols)
5666         (default_collect_symbol_completion_matches_break_on): Use
5667         objfile_compunits.
5668         * objfiles.h (ALL_COMPUNITS): Remove.
5669         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5670         * cp-support.c (add_symbol_overload_list_qualified): Use
5671         objfile_compunits.
5672         * ada-lang.c (ada_collect_symbol_completion_matches)
5673         (ada_add_global_exceptions): Use objfile_compunits.
5674
5675 2019-01-09  Tom Tromey  <tom@tromey.com>
5676
5677         * source.c (select_source_symtab)
5678         (forget_cached_source_info_for_objfile): Remove declaration.
5679         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5680         declaration.
5681         * maint.c (count_symtabs_and_blocks): Remove declaration.
5682         * cp-support.c (add_symbol_overload_list_qualified): Remove
5683         declaration.
5684         * coffread.c (coff_symtab_read): Remove declaration.
5685         * symtab.c (lookup_symbol_in_objfile_symtabs)
5686         (basic_lookup_transparent_type_1): Use objfile_compunits.
5687         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5688         (info_sources_command, search_symbols)
5689         (default_collect_symbol_completion_matches_break_on)
5690         (make_source_files_completion_list): Remove declaration.
5691         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5692         (ada_collect_symbol_completion_matches)
5693         (ada_add_global_exceptions): Remove declaration.
5694         * linespec.c (iterate_over_all_matching_symtabs): Use
5695         objfile_compunits.
5696         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5697         (class objfile_compunits): New.
5698         (ALL_COMPUNITS): Use objfile_compunits.
5699         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5700         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5701         objfile_compunits.
5702         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5703
5704 2019-01-09  Tom Tromey  <tom@tromey.com>
5705
5706         * symtab.c (search_symbols)
5707         (default_collect_symbol_completion_matches_break_on): Use
5708         objfile_msymbols.
5709         * ada-lang.c (ada_lookup_simple_minsym)
5710         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5711         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5712         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5713         objfile_msymbols.
5714         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5715         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5716         * objc-lang.c (find_methods): Use objfile_msymbols.
5717         (info_selectors_command, info_classes_command): Likewise.
5718         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5719         * objfiles.h (class objfile_msymbols): New.
5720         (ALL_OBJFILE_MSYMBOLS): Remove.
5721         (ALL_MSYMBOLS): Remove.
5722
5723 2019-01-09  Tom Tromey  <tom@tromey.com>
5724
5725         * common/next-iterator.h (next_adapter): Add Iterator template
5726         parameter.
5727         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5728         (class all_objfiles_safe): New.
5729         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5730         * objfiles.c (put_objfile_before): Update comment.
5731         (add_separate_debug_objfile): Likewise.
5732         (free_all_objfiles): Use all_objfiles_safe.
5733         (objfile_purge_solibs): Likewise.
5734
5735 2019-01-09  Tom Tromey  <tom@tromey.com>
5736
5737         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5738         (expand_symtab_containing_pc, lookup_static_symbol)
5739         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5740         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5741         all_objfiles.
5742         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5743         * breakpoint.c (create_overlay_event_breakpoint)
5744         (create_longjmp_master_breakpoint)
5745         (create_std_terminate_master_breakpoint)
5746         (create_exception_master_breakpoint): Use all_objfiles.
5747         * linux-thread-db.c (try_thread_db_load_from_pdir)
5748         (has_libpthread): Use all_objfiles.
5749         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5750         * linespec.c (iterate_over_all_matching_symtabs)
5751         (search_minsyms_for_name): Use all_objfiles.
5752         * maint.c (maintenance_info_sections): Use all_objfiles.
5753         * main.c (captured_main_1): Use all_objfiles.
5754         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5755         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5756         * guile/scm-pretty-print.c
5757         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5758         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5759         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5760         (maintenance_print_msymbols): Use all_objfiles.
5761         * source.c (select_source_symtab): Use all_objfiles.
5762         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5763         * symfile.c (remove_symbol_file_command)
5764         (expand_symtabs_matching, map_symbol_filenames): Use
5765         all_objfiles.
5766         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5767         all_objfiles.
5768         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5769         * objc-lang.c (find_methods): Use all_objfiles.
5770         * objfiles.c (have_partial_symbols, have_full_symbols)
5771         (have_minimal_symbols, qsort_cmp)
5772         (default_iterate_over_objfiles_in_search_order): Use
5773         all_objfiles.
5774         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5775         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5776         (maintenance_check_psymtabs): Use all_objfiles.
5777         (ALL_PSYMTABS): Remove.
5778         * compile/compile-object-run.c (do_module_cleanup): Use
5779         all_objfiles.
5780         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5781         * cp-support.c (add_symbol_overload_list_qualified): Use
5782         all_objfiles.
5783         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5784         Use all_objfiles.
5785         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5786         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5787         all_objfiles.
5788         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5789         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5790         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5791         Uses all_objfiles.
5792         * solib.c (solib_read_symbols): Use all_objfiles
5793
5794 2019-01-09  Tom Tromey  <tom@tromey.com>
5795
5796         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5797         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5798         all_objfiles.
5799         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5800         * symmisc.c (print_symbol_bcache_statistics)
5801         (print_objfile_statistics, maintenance_print_objfiles)
5802         (maintenance_info_symtabs, maintenance_check_symtabs)
5803         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5804         all_objfiles.
5805         * source.c (forget_cached_source_info): Use all_objfiles.
5806         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5807         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5808         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5809         * objfiles.c (update_section_map): Use all_objfiles.
5810         (shared_objfile_contains_address_p): Likewise.
5811         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5812         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5813
5814 2019-01-09  Tom Tromey  <tom@tromey.com>
5815
5816         * common/next-iterator.h: New file.
5817         * objfiles.h (class all_objfiles): New.
5818         (struct objfile_iterator): New.
5819
5820 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5821
5822         * NEWS: Move the description of the changed "frame", "select-frame",
5823          and "info frame" commands to the Changed commands section.
5824
5825 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5826
5827         * gdbtypes.c (check_stub_method_group): Remove handling of old
5828         mangling schemes.
5829         * linespec.c (find_methods): Likewise.
5830         * stabsread.c (read_member_functions): Likewise.
5831         * valops.c (search_struct_method): Likewise.
5832         (value_struct_elt_for_reference): Likewise.
5833         * NEWS: Mention this change.
5834
5835 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5836
5837         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5838         print_source_lines.
5839         * source.c (print_source_lines_base): Update line number check.
5840         (print_source_lines): New function.
5841         (source_lines_range::source_lines_range): New function.
5842         * source.h (class source_lines_range): New class.
5843         (print_source_lines): New declaration.
5844
5845 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5846
5847         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5848
5849 2019-01-08  Tom Tromey  <tom@tromey.com>
5850             Simon Marchi  <simon.marchi@ericsson.com>
5851
5852         PR gdb/24060
5853         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5854         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5855         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5856         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5857         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5858         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5859
5860 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * source.c (select_source_symtab): Move header comment to
5863         declaration in source.h.
5864         (forget_cached_source_info_for_objfile): Likewise.
5865         (forget_cached_source_info): Likewise.
5866         (identify_source_line): Likewise.
5867         * source.h (identify_source_line): Move declaration from symtab.h
5868         and add comment from source.c
5869         (print_source_lines): Likewise.
5870         (forget_cached_source_info_for_objfile): Likewise.
5871         (forget_cached_source_info): Likewise.
5872         (select_source_symtab): Likewise.
5873         (enum print_source_lines_flag): Move definition from symtab.h.
5874         * symtab.h (identify_source_line): Move declaration to source.h.
5875         (print_source_lines): Likewise.
5876         (forget_cached_source_info_for_objfile): Likewise.
5877         (forget_cached_source_info): Likewise.
5878         (select_source_symtab): Likewise.
5879         (enum print_source_lines_flag): Move definition to source.h.
5880         * tui/tui-hooks.c: Add 'source.h' include.
5881
5882 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * source.c (print_source_lines_base): Handle requests to print
5885         reverse line number sequences, and guard against empty lines
5886         string.
5887
5888 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * source.c (print_source_lines_base): Fix skip of '\r' if next
5891         character is '\n'.
5892
5893 2019-01-06  Tom Tromey  <tom@tromey.com>
5894
5895         * c-exp.y (struct c_parse_state) <macro_original_text,
5896         expansion_obstack>: New member.
5897         (macro_original_text, expansion_obstack): Remove globals.
5898         (scan_macro_expansion, scanning_macro_expansion)
5899         (finished_macro_expansion): Update.
5900         (scan_macro_cleanup): Remove.
5901         (yylex, c_parse): Update.
5902
5903 2019-01-06  Tom Tromey  <tom@tromey.com>
5904
5905         * c-exp.y (struct c_parse_state) <strings>: New member.
5906         (operator_stoken): Update.
5907
5908 2019-01-06  Tom Tromey  <tom@tromey.com>
5909
5910         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5911         (union type_stack_elt) <typelist_val>: Now a pointer to
5912         std::vector.
5913         (type_stack_cleanup): Don't declare.
5914         (push_typelist): Update.
5915         * parse.c (pop_typelist): Return a std::vector.
5916         (push_typelist): Take a std::vector.
5917         (follow_types): Update.  Do not free args.
5918         (type_stack_cleanup): Remove.
5919         * c-exp.y (struct c_parse_state): New.
5920         (cpstate): New global.
5921         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5922         (nonempty_typelist): Update.
5923         (func_mod): Create a new vector.
5924         (c_parse): Create a c_parse_state.
5925         (check_parameter_typelist): Do not delete params.
5926         (function_method): Update.  Do not delete type_list.
5927
5928 2019-01-06  Tom Tromey  <tom@tromey.com>
5929
5930         PR gdb/28155:
5931         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5932         check_typedef.
5933         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5934         (print_return_value): Likewise.
5935
5936 2019-01-05  Tom Tromey  <tom@tromey.com>
5937
5938         * contrib/cleanup_check.py: Remove.
5939         * contrib/gcc-with-excheck: Remove.
5940         * contrib/exsummary.py: Remove.
5941         * contrib/excheck.py: Remove.
5942
5943 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5944
5945         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5946         NULL. Initialize tpprev to NULL instead of assigning it
5947         to NULL on the next statement.
5948         * windows-nat.c (windows_delete_thread): Remove check for
5949         main_thread_id before printing thread exit notifications.
5950         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5951         Remove thread ID check against main_thread_id.
5952         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5953         windows_delete_thread.
5954         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5955
5956 2019-01-04  Tom Tromey  <tom@tromey.com>
5957
5958         * compile/compile.c (_initialize_compile): Use upper case for
5959         metasyntactic variables.
5960         * symmisc.c (_initialize_symmisc): Use upper case for
5961         metasyntactic variables.
5962         * psymtab.c (_initialize_psymtab): Use upper case for
5963         metasyntactic variables.
5964         * demangle.c (demangle_command): Use upper case for metasyntactic
5965         variables.
5966         (_initialize_demangler): Likewise.
5967         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5968         variables.
5969
5970 2019-01-03  Tom Tromey  <tom@tromey.com>
5971
5972         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5973
5974 2019-01-03  Tom Tromey  <tom@tromey.com>
5975
5976         * python/py-symtab.c (salpy_str): Update.
5977         (struct salpy_sal_object) <symtab>: Now a PyObject.
5978         (salpy_dealloc): Update.
5979         (del_objfile_sal): Use gdbpy_ref.
5980
5981 2019-01-03  Tom Tromey  <tom@tromey.com>
5982
5983         * python/py-type.c (convert_field): Use new_reference.  Return
5984         gdbpy_ref.
5985         (make_fielditem): Return gdbpy_ref.
5986         (typy_fields): Update.
5987         (typy_getitem): Update.
5988         (field_name): Return gdbpy_ref.  Use new_reference.
5989         (typy_iterator_iternext): Update.
5990
5991 2019-01-03  Tom Tromey  <tom@tromey.com>
5992
5993         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5994
5995 2019-01-03  Tom Tromey  <tom@tromey.com>
5996
5997         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5998         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5999         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6000         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6001         (pspy_set_type_printers): Likewise.
6002         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6003         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6004         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6005         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6006         (objfpy_set_type_printers): Likewise.
6007
6008 2019-01-03  Tom Tromey  <tom@tromey.com>
6009
6010         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6011         (gdbpy_print_stack): Use gdbpy_err_fetch.
6012         * python/python-internal.h (class gdbpy_err_fetch): New class.
6013         (class gdbpy_enter) <m_error_type, m_error_value,
6014         m_error_traceback>: Remove.
6015         <m_error>: New member.
6016         (gdbpy_exception_to_string): Don't declare.
6017         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6018         * python/py-value.c (convert_value_from_python): Use
6019         gdbpy_err_fetch.
6020         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6021         gdbpy_exception_to_string.
6022         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6023         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6024         gdbpy_err_fetch.
6025
6026 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * linux-nat.c (delete_lwp_cleanup): Delete.
6029         (struct lwp_deleter): New struct.
6030         (lwp_info_up): New typedef.
6031         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6032         lwp_info_up.
6033
6034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * linux-fork.c (class scoped_switch_fork_info): New class.
6037         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6038
6039 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * valops.c (find_overload_match): Remove use of null_cleanup, and
6042         calls to do_cleanups.
6043
6044 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * compile/compile-cplus-types.c
6047         (compile_cplus_instance::decl_name): Handle changes to
6048         cp_func_name.
6049         * cp-support.c (cp_func_name): Update header comment, update
6050         return type.
6051         * cp-support.h (cp_func_name): Update return type in declaration.
6052         * valops.c (find_overload_match): Move temp_func local to top
6053         level of function and change its type.  Use temp_func to hold and
6054         delete temporary string obtained from cp_func_name.
6055
6056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6057
6058         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6059         gdb::char_vector, remove cleanup, and update uses of `msg`.
6060
6061 2019-01-03  Jim Wilson  <jimw@sifive.com>
6062
6063         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6064
6065 2019-01-02  Tom Tromey  <tom@tromey.com>
6066
6067         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6068         (tdesc_parse_xml): Remove cleanups.
6069         * target-descriptions.h (make_cleanup_free_target_description):
6070         Don't declare.
6071         (target_desc_deleter): New struct.
6072         (target_desc_up): New typedef.
6073         * target-descriptions.c (target_desc_deleter::operator()): Rename
6074         from free_target_description.
6075         (make_cleanup_free_target_description): Remove.
6076
6077 2019-01-02  Tom Tromey  <tom@tromey.com>
6078
6079         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6080         constructor, destructor.
6081         (linespec_parser): Remove typedef.
6082         (~linespec_parser): Rename from linespec_parser_delete.
6083         (linespec_lex_to_end, linespec_complete_label)
6084         (linespec_complete): Update.
6085         (decode_line_full): Remove cleanups.
6086         (decode_line_1): Update.
6087
6088 2019-01-02  Tom Tromey  <tom@tromey.com>
6089
6090         * python/python-internal.h (inferior_to_inferior_object): Change
6091         return type.
6092         * python/py-exitedevent.c (create_exited_event_object): Update.
6093         * python/py-inferior.c (inferior_to_inferior_object): Return
6094         gdbpy_ref.
6095         (python_new_inferior, python_inferior_deleted)
6096         (thread_to_thread_object, delete_thread_object)
6097         (build_inferior_list, gdbpy_selected_inferior): Update.
6098         * python/py-infthread.c (create_thread_object): Update.  Also fail
6099         if inferior_to_inferior_object fails.
6100
6101 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6102
6103         * inferior.h (class inferior) <displaced_step_state>: New field.
6104         * infrun.h (struct displaced_step_state): Move here from
6105         infrun.c.  Initialize fields, add constructor.
6106         <inf>: Remove field.
6107         <reset>: New method.
6108         * infrun.c (struct displaced_step_inferior_state): Move to
6109         infrun.h.
6110         (displaced_step_inferior_states): Remove.
6111         (get_displaced_stepping_state): Adust.
6112         (displaced_step_in_progress_any_inferior): Adjust.
6113         (displaced_step_in_progress_thread): Adjust.
6114         (displaced_step_in_progress): Adjust.
6115         (add_displaced_stepping_state): Remove.
6116         (get_displaced_step_closure_by_addr): Adjust.
6117         (remove_displaced_stepping_state): Remove.
6118         (infrun_inferior_exit): Call displaced_step_state.reset.
6119         (use_displaced_stepping): Don't check for NULL.
6120         (displaced_step_prepare_throw): Call
6121         get_displaced_stepping_state.
6122         (displaced_step_fixup): Don't check for NULL.
6123         (prepare_for_detach): Don't check for NULL.
6124
6125 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6126
6127         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6128          in case of call that did not complete.
6129
6130 2019-01-02  Andrey Utkin  <autkin@undo.io>
6131
6132         * symfile.c (find_separate_debug_file): Fix search of debug files for
6133         remote debuggee.
6134
6135 2019-01-02  Tom Tromey  <tom@tromey.com>
6136
6137         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6138         indentation.
6139         * python/py-frame.c (frapy_older): Remove cast.
6140         (frapy_newer): Likewise.
6141         * python/py-breakpoint.c (local_setattro): Remove cast.
6142         * python/py-arch.c (archpy_name): Remove local variable.
6143         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6144
6145 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6146
6147         * unittests/basic_string_view/element_access/char/empty.cc:
6148         Fix year range in copyright header.
6149
6150 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6151
6152         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6153         Delete.
6154         <operator==>: Update with for removed field.
6155         <hash>: Likewise.
6156         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6157         <isa_features>: ...this.
6158         <abi_features>: New field.
6159         (riscv_isa_flen): Update comment.
6160         (riscv_abi_xlen): New declaration.
6161         (riscv_abi_flen): New declaration.
6162         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6163         isa_features.
6164         (riscv_abi_xlen): New function.
6165         (riscv_isa_flen): Update to get answer from isa_features.
6166         (riscv_abi_flen): New function.
6167         (riscv_has_fp_abi): Update to get answer from abi_features.
6168         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6169         xlen and flen.
6170         (riscv_call_info) <xlen, flen>: Update comment.
6171         (riscv_call_arg_struct): Remove invalid assertions
6172         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6173         is removed.
6174         (riscv_gdbarch_init): Gather isa features and abi features
6175         separately, ensure both match on the gdbarch when reusing an old
6176         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6177         a target with 64-bit float hardware.
6178
6179 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6180
6181         * source.c (search_command_helper): Stop reverse search
6182         when line 1 has been searched.
6183
6184 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6185
6186         * record-full.c (record_full_base_target::close): Rewrite
6187         record_full_core_buf_list free logic.
6188
6189 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6190
6191         * break-catch-syscall.c (print_one_catch_syscall): xfree
6192         the last text.
6193
6194 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6195
6196         * top.c (print_gdb_version): Update Copyright year in version
6197         message.
6198
6199 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6200
6201         Update copyright year range in all GDB files.
6202
6203 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6204
6205         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6206
6207 For older changes see ChangeLog-2018.
6208 \f
6209 Local Variables:
6210 mode: change-log
6211 left-margin: 8
6212 fill-column: 74
6213 version-control: never
6214 coding: utf-8
6215 End:
6216