gdb/ChangeLog

   1 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * c-exp.y (direct_abs_decl): Use emplace_back to record the
   4         type_stack.
   5
   6 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
   7
   8         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
   9         TYPE_CODE_REF types.
  10
  11 2019-02-08  Jim Wilson  <jimw@sifive.com>
  12
  13         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
  14         (riscv_linux_fregset): New.
  15         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
  16
  17 2019-02-07  Tom Tromey  <tom@tromey.com>
  18
  19         * thread.c (thread_cancel_execution_command): Update.
  20         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
  21         methods.
  22         (struct thread_fsm_ops): Remove.
  23         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
  24         (thread_fsm_should_stop, thread_fsm_return_value)
  25         (thread_fsm_set_finished, thread_fsm_finished_p)
  26         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
  27         Don't declare.
  28         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
  29         * infrun.c (clear_proceed_status_thread)
  30         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
  31         (print_stop_event): Update.
  32         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
  33         Add constructor.
  34         (step_command_fsm_ops): Remove.
  35         (new_step_command_fsm): Remove.
  36         (step_1): Update.
  37         (step_command_fsm::should_stop): Rename from
  38         step_command_fsm_should_stop.
  39         (step_command_fsm::clean_up): Rename from
  40         step_command_fsm_clean_up.
  41         (step_command_fsm::do_async_reply_reason): Rename from
  42         step_command_fsm_async_reply_reason.
  43         (struct until_next_fsm): Inherit from thread_fsm.  Add
  44         constructor.
  45         (until_next_fsm_ops): Remove.
  46         (new_until_next_fsm): Remove.
  47         (until_next_fsm::should_stop): Rename from
  48         until_next_fsm_should_stop.
  49         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
  50         (until_next_fsm::do_async_reply_reason): Rename from
  51         until_next_fsm_async_reply_reason.
  52         (struct finish_command_fsm): Inherit from thread_fsm.  Add
  53         constructor.  Change type of breakpoint.
  54         (finish_command_fsm_ops): Remove.
  55         (new_finish_command_fsm): Remove.
  56         (finish_command_fsm::should_stop): Rename from
  57         finish_command_fsm_should_stop.
  58         (finish_command_fsm::clean_up): Rename from
  59         finish_command_fsm_clean_up.
  60         (finish_command_fsm::return_value): Rename from
  61         finish_command_fsm_return_value.
  62         (finish_command_fsm::do_async_reply_reason): Rename from
  63         finish_command_fsm_async_reply_reason.
  64         (finish_command): Update.
  65         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
  66         Add constructor.
  67         (call_thread_fsm_ops): Remove.
  68         (call_thread_fsm::call_thread_fsm): Rename from
  69         new_call_thread_fsm.
  70         (call_thread_fsm::should_stop): Rename from
  71         call_thread_fsm_should_stop.
  72         (call_thread_fsm::should_notify_stop): Rename from
  73         call_thread_fsm_should_notify_stop.
  74         (run_inferior_call, call_function_by_hand_dummy): Update.
  75         * cli/cli-interp.c (should_print_stop_to_console): Update.
  76         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
  77         Add constructor.  Change type of location_breakpoint,
  78         caller_breakpoint.
  79         (until_break_fsm_ops): Remove.
  80         (new_until_break_fsm): Remove.
  81         (until_break_fsm::should_stop): Rename from
  82         until_break_fsm_should_stop.
  83         (until_break_fsm::clean_up): Rename from
  84         until_break_fsm_clean_up.
  85         (until_break_fsm::do_async_reply_reason): Rename from
  86         until_break_fsm_async_reply_reason.
  87         (until_break_command): Update.
  88         * thread-fsm.c: Remove.
  89         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
  90
  91 2019-02-07  Tom Tromey  <tom@tromey.com>
  92
  93         * yy-remap.h: Add include guard.
  94         * xtensa-tdep.h: Add include guard.
  95         * xcoffread.h: Rename include guard.
  96         * varobj-iter.h: Add include guard.
  97         * tui/tui.h: Rename include guard.
  98         * tui/tui-winsource.h: Rename include guard.
  99         * tui/tui-wingeneral.h: Rename include guard.
 100         * tui/tui-windata.h: Rename include guard.
 101         * tui/tui-win.h: Rename include guard.
 102         * tui/tui-stack.h: Rename include guard.
 103         * tui/tui-source.h: Rename include guard.
 104         * tui/tui-regs.h: Rename include guard.
 105         * tui/tui-out.h: Rename include guard.
 106         * tui/tui-layout.h: Rename include guard.
 107         * tui/tui-io.h: Rename include guard.
 108         * tui/tui-hooks.h: Rename include guard.
 109         * tui/tui-file.h: Rename include guard.
 110         * tui/tui-disasm.h: Rename include guard.
 111         * tui/tui-data.h: Rename include guard.
 112         * tui/tui-command.h: Rename include guard.
 113         * tic6x-tdep.h: Add include guard.
 114         * target/waitstatus.h: Rename include guard.
 115         * target/wait.h: Rename include guard.
 116         * target/target.h: Rename include guard.
 117         * target/resume.h: Rename include guard.
 118         * target-float.h: Rename include guard.
 119         * stabsread.h: Add include guard.
 120         * rs6000-tdep.h: Add include guard.
 121         * riscv-fbsd-tdep.h: Add include guard.
 122         * regformats/regdef.h: Rename include guard.
 123         * record.h: Rename include guard.
 124         * python/python.h: Rename include guard.
 125         * python/python-internal.h: Rename include guard.
 126         * python/py-stopevent.h: Rename include guard.
 127         * python/py-ref.h: Rename include guard.
 128         * python/py-record.h: Rename include guard.
 129         * python/py-record-full.h: Rename include guard.
 130         * python/py-record-btrace.h: Rename include guard.
 131         * python/py-instruction.h: Rename include guard.
 132         * python/py-events.h: Rename include guard.
 133         * python/py-event.h: Rename include guard.
 134         * procfs.h: Add include guard.
 135         * proc-utils.h: Add include guard.
 136         * p-lang.h: Add include guard.
 137         * or1k-tdep.h: Rename include guard.
 138         * observable.h: Rename include guard.
 139         * nto-tdep.h: Rename include guard.
 140         * nat/x86-linux.h: Rename include guard.
 141         * nat/x86-linux-dregs.h: Rename include guard.
 142         * nat/x86-gcc-cpuid.h: Add include guard.
 143         * nat/x86-dregs.h: Rename include guard.
 144         * nat/x86-cpuid.h: Rename include guard.
 145         * nat/ppc-linux.h: Rename include guard.
 146         * nat/mips-linux-watch.h: Rename include guard.
 147         * nat/linux-waitpid.h: Rename include guard.
 148         * nat/linux-ptrace.h: Rename include guard.
 149         * nat/linux-procfs.h: Rename include guard.
 150         * nat/linux-osdata.h: Rename include guard.
 151         * nat/linux-nat.h: Rename include guard.
 152         * nat/linux-namespaces.h: Rename include guard.
 153         * nat/linux-btrace.h: Rename include guard.
 154         * nat/glibc_thread_db.h: Rename include guard.
 155         * nat/gdb_thread_db.h: Rename include guard.
 156         * nat/gdb_ptrace.h: Rename include guard.
 157         * nat/fork-inferior.h: Rename include guard.
 158         * nat/amd64-linux-siginfo.h: Rename include guard.
 159         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 160         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 161         * nat/aarch64-linux.h: Rename include guard.
 162         * nat/aarch64-linux-hw-point.h: Rename include guard.
 163         * mn10300-tdep.h: Add include guard.
 164         * mips-linux-tdep.h: Add include guard.
 165         * mi/mi-parse.h: Rename include guard.
 166         * mi/mi-out.h: Rename include guard.
 167         * mi/mi-main.h: Rename include guard.
 168         * mi/mi-interp.h: Rename include guard.
 169         * mi/mi-getopt.h: Rename include guard.
 170         * mi/mi-console.h: Rename include guard.
 171         * mi/mi-common.h: Rename include guard.
 172         * mi/mi-cmds.h: Rename include guard.
 173         * mi/mi-cmd-break.h: Rename include guard.
 174         * m2-lang.h: Add include guard.
 175         * location.h: Rename include guard.
 176         * linux-record.h: Rename include guard.
 177         * linux-nat.h: Add include guard.
 178         * linux-fork.h: Add include guard.
 179         * i386-darwin-tdep.h: Rename include guard.
 180         * hppa-linux-offsets.h: Add include guard.
 181         * guile/guile.h: Rename include guard.
 182         * guile/guile-internal.h: Rename include guard.
 183         * gnu-nat.h: Rename include guard.
 184         * gdb-stabs.h: Rename include guard.
 185         * frv-tdep.h: Add include guard.
 186         * f-lang.h: Add include guard.
 187         * event-loop.h: Add include guard.
 188         * darwin-nat.h: Rename include guard.
 189         * cp-abi.h: Rename include guard.
 190         * config/sparc/nm-sol2.h: Rename include guard.
 191         * config/nm-nto.h: Rename include guard.
 192         * config/nm-linux.h: Add include guard.
 193         * config/i386/nm-i386gnu.h: Rename include guard.
 194         * config/djgpp/nl_types.h: Rename include guard.
 195         * config/djgpp/langinfo.h: Rename include guard.
 196         * compile/gcc-cp-plugin.h: Add include guard.
 197         * compile/gcc-c-plugin.h: Add include guard.
 198         * compile/compile.h: Rename include guard.
 199         * compile/compile-object-run.h: Rename include guard.
 200         * compile/compile-object-load.h: Rename include guard.
 201         * compile/compile-internal.h: Rename include guard.
 202         * compile/compile-cplus.h: Rename include guard.
 203         * compile/compile-c.h: Rename include guard.
 204         * common/xml-utils.h: Rename include guard.
 205         * common/x86-xstate.h: Rename include guard.
 206         * common/version.h: Rename include guard.
 207         * common/vec.h: Rename include guard.
 208         * common/tdesc.h: Rename include guard.
 209         * common/selftest.h: Rename include guard.
 210         * common/scoped_restore.h: Rename include guard.
 211         * common/scoped_mmap.h: Rename include guard.
 212         * common/scoped_fd.h: Rename include guard.
 213         * common/safe-iterator.h: Rename include guard.
 214         * common/run-time-clock.h: Rename include guard.
 215         * common/refcounted-object.h: Rename include guard.
 216         * common/queue.h: Rename include guard.
 217         * common/ptid.h: Rename include guard.
 218         * common/print-utils.h: Rename include guard.
 219         * common/preprocessor.h: Rename include guard.
 220         * common/pathstuff.h: Rename include guard.
 221         * common/observable.h: Rename include guard.
 222         * common/netstuff.h: Rename include guard.
 223         * common/job-control.h: Rename include guard.
 224         * common/host-defs.h: Rename include guard.
 225         * common/gdb_wait.h: Rename include guard.
 226         * common/gdb_vecs.h: Rename include guard.
 227         * common/gdb_unlinker.h: Rename include guard.
 228         * common/gdb_unique_ptr.h: Rename include guard.
 229         * common/gdb_tilde_expand.h: Rename include guard.
 230         * common/gdb_sys_time.h: Rename include guard.
 231         * common/gdb_string_view.h: Rename include guard.
 232         * common/gdb_splay_tree.h: Rename include guard.
 233         * common/gdb_setjmp.h: Rename include guard.
 234         * common/gdb_ref_ptr.h: Rename include guard.
 235         * common/gdb_optional.h: Rename include guard.
 236         * common/gdb_locale.h: Rename include guard.
 237         * common/gdb_assert.h: Rename include guard.
 238         * common/filtered-iterator.h: Rename include guard.
 239         * common/filestuff.h: Rename include guard.
 240         * common/fileio.h: Rename include guard.
 241         * common/environ.h: Rename include guard.
 242         * common/common-utils.h: Rename include guard.
 243         * common/common-types.h: Rename include guard.
 244         * common/common-regcache.h: Rename include guard.
 245         * common/common-inferior.h: Rename include guard.
 246         * common/common-gdbthread.h: Rename include guard.
 247         * common/common-exceptions.h: Rename include guard.
 248         * common/common-defs.h: Rename include guard.
 249         * common/common-debug.h: Rename include guard.
 250         * common/cleanups.h: Rename include guard.
 251         * common/buffer.h: Rename include guard.
 252         * common/btrace-common.h: Rename include guard.
 253         * common/break-common.h: Rename include guard.
 254         * cli/cli-utils.h: Rename include guard.
 255         * cli/cli-style.h: Rename include guard.
 256         * cli/cli-setshow.h: Rename include guard.
 257         * cli/cli-script.h: Rename include guard.
 258         * cli/cli-interp.h: Rename include guard.
 259         * cli/cli-decode.h: Rename include guard.
 260         * cli/cli-cmds.h: Rename include guard.
 261         * charset-list.h: Add include guard.
 262         * buildsym-legacy.h: Rename include guard.
 263         * bfin-tdep.h: Add include guard.
 264         * ax.h: Rename include guard.
 265         * arm-linux-tdep.h: Add include guard.
 266         * arm-fbsd-tdep.h: Add include guard.
 267         * arch/xtensa.h: Rename include guard.
 268         * arch/tic6x.h: Add include guard.
 269         * arch/i386.h: Add include guard.
 270         * arch/arm.h: Rename include guard.
 271         * arch/arm-linux.h: Rename include guard.
 272         * arch/arm-get-next-pcs.h: Rename include guard.
 273         * arch/amd64.h: Add include guard.
 274         * arch/aarch64-insn.h: Rename include guard.
 275         * arch-utils.h: Rename include guard.
 276         * annotate.h: Add include guard.
 277         * amd64-darwin-tdep.h: Rename include guard.
 278         * aarch64-linux-tdep.h: Add include guard.
 279         * aarch64-fbsd-tdep.h: Add include guard.
 280         * aarch32-linux-nat.h: Add include guard.
 281
 282 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 283
 284         * macrotab.c (macro_define_internal): New function that
 285         factorizes macro_define_object_internal and macro_define_function
 286         code.
 287         (macro_define_object_internal): Use macro_define_internal.
 288         (macro_define_function): Likewise.
 289
 290 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 291
 292         * macrocmd.c (extract_identifier): Return
 293         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 294         callers.
 295
 296 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 297
 298         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 299
 300 2019-02-05  Tom Tromey  <tom@tromey.com>
 301
 302         * target.c (target_stack::unpush): Move assertion earlier.
 303
 304 2019-01-30  Tom Tromey  <tom@tromey.com>
 305
 306         PR python/23615:
 307         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 308         (gdbpy_parse_and_eval): Likewise.
 309         * python/python-internal.h (gdbpy_allow_threads): New class.
 310
 311 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 312
 313         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 314         (aarch64_fbsd_fpregmap): Move earlier.
 315         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 316         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 317         instead of individual calls to trad_frame_set_reg_addr.
 318         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 319         earlier.
 320         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 321         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 322         instead of individual calls to trad_frame_set_reg_addr.
 323
 324 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 325
 326         * CONTRIBUTE: Replace contribution list with wiki link.
 327
 328 2019-01-25  Tom Tromey  <tom@tromey.com>
 329
 330         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 331
 332 2019-01-25  Tom Tromey  <tom@tromey.com>
 333
 334         * xtensa-linux-nat.c: Fix common/ includes.
 335         * xml-support.h: Fix common/ includes.
 336         * xml-support.c: Fix common/ includes.
 337         * x86-linux-nat.c: Fix common/ includes.
 338         * windows-nat.c: Fix common/ includes.
 339         * varobj.h: Fix common/ includes.
 340         * varobj.c: Fix common/ includes.
 341         * value.c: Fix common/ includes.
 342         * valops.c: Fix common/ includes.
 343         * utils.c: Fix common/ includes.
 344         * unittests/xml-utils-selftests.c: Fix common/ includes.
 345         * unittests/utils-selftests.c: Fix common/ includes.
 346         * unittests/unpack-selftests.c: Fix common/ includes.
 347         * unittests/tracepoint-selftests.c: Fix common/ includes.
 348         * unittests/style-selftests.c: Fix common/ includes.
 349         * unittests/string_view-selftests.c: Fix common/ includes.
 350         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 351         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 352         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 353         * unittests/rsp-low-selftests.c: Fix common/ includes.
 354         * unittests/parse-connection-spec-selftests.c: Fix common/
 355         includes.
 356         * unittests/optional-selftests.c: Fix common/ includes.
 357         * unittests/offset-type-selftests.c: Fix common/ includes.
 358         * unittests/observable-selftests.c: Fix common/ includes.
 359         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 360         * unittests/memrange-selftests.c: Fix common/ includes.
 361         * unittests/memory-map-selftests.c: Fix common/ includes.
 362         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 363         * unittests/function-view-selftests.c: Fix common/ includes.
 364         * unittests/environ-selftests.c: Fix common/ includes.
 365         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 366         * unittests/common-utils-selftests.c: Fix common/ includes.
 367         * unittests/cli-utils-selftests.c: Fix common/ includes.
 368         * unittests/array-view-selftests.c: Fix common/ includes.
 369         * ui-file.c: Fix common/ includes.
 370         * tui/tui-io.c: Fix common/ includes.
 371         * tracepoint.h: Fix common/ includes.
 372         * tracepoint.c: Fix common/ includes.
 373         * tracefile-tfile.c: Fix common/ includes.
 374         * top.h: Fix common/ includes.
 375         * top.c: Fix common/ includes.
 376         * thread.c: Fix common/ includes.
 377         * target/waitstatus.h: Fix common/ includes.
 378         * target/waitstatus.c: Fix common/ includes.
 379         * target.h: Fix common/ includes.
 380         * target.c: Fix common/ includes.
 381         * target-memory.c: Fix common/ includes.
 382         * target-descriptions.c: Fix common/ includes.
 383         * symtab.h: Fix common/ includes.
 384         * symfile.c: Fix common/ includes.
 385         * stap-probe.c: Fix common/ includes.
 386         * spu-linux-nat.c: Fix common/ includes.
 387         * sparc-nat.c: Fix common/ includes.
 388         * source.c: Fix common/ includes.
 389         * solib.c: Fix common/ includes.
 390         * solib-target.c: Fix common/ includes.
 391         * ser-unix.c: Fix common/ includes.
 392         * ser-tcp.c: Fix common/ includes.
 393         * ser-pipe.c: Fix common/ includes.
 394         * ser-base.c: Fix common/ includes.
 395         * selftest-arch.c: Fix common/ includes.
 396         * s12z-tdep.c: Fix common/ includes.
 397         * rust-exp.y: Fix common/ includes.
 398         * rs6000-aix-tdep.c: Fix common/ includes.
 399         * riscv-tdep.c: Fix common/ includes.
 400         * remote.c: Fix common/ includes.
 401         * remote-notif.h: Fix common/ includes.
 402         * remote-fileio.h: Fix common/ includes.
 403         * remote-fileio.c: Fix common/ includes.
 404         * regcache.h: Fix common/ includes.
 405         * regcache.c: Fix common/ includes.
 406         * record-btrace.c: Fix common/ includes.
 407         * python/python.c: Fix common/ includes.
 408         * python/py-type.c: Fix common/ includes.
 409         * python/py-inferior.c: Fix common/ includes.
 410         * progspace.h: Fix common/ includes.
 411         * producer.c: Fix common/ includes.
 412         * procfs.c: Fix common/ includes.
 413         * proc-api.c: Fix common/ includes.
 414         * printcmd.c: Fix common/ includes.
 415         * ppc-linux-nat.c: Fix common/ includes.
 416         * parser-defs.h: Fix common/ includes.
 417         * osdata.c: Fix common/ includes.
 418         * obsd-nat.c: Fix common/ includes.
 419         * nat/x86-linux.c: Fix common/ includes.
 420         * nat/x86-linux-dregs.c: Fix common/ includes.
 421         * nat/x86-dregs.h: Fix common/ includes.
 422         * nat/x86-dregs.c: Fix common/ includes.
 423         * nat/ppc-linux.c: Fix common/ includes.
 424         * nat/mips-linux-watch.h: Fix common/ includes.
 425         * nat/mips-linux-watch.c: Fix common/ includes.
 426         * nat/linux-waitpid.c: Fix common/ includes.
 427         * nat/linux-ptrace.h: Fix common/ includes.
 428         * nat/linux-ptrace.c: Fix common/ includes.
 429         * nat/linux-procfs.c: Fix common/ includes.
 430         * nat/linux-personality.c: Fix common/ includes.
 431         * nat/linux-osdata.c: Fix common/ includes.
 432         * nat/linux-namespaces.c: Fix common/ includes.
 433         * nat/linux-btrace.h: Fix common/ includes.
 434         * nat/linux-btrace.c: Fix common/ includes.
 435         * nat/fork-inferior.c: Fix common/ includes.
 436         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 437         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 438         * nat/aarch64-linux.c: Fix common/ includes.
 439         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 440         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 441         * namespace.h: Fix common/ includes.
 442         * mips-linux-tdep.c: Fix common/ includes.
 443         * minsyms.c: Fix common/ includes.
 444         * mi/mi-parse.h: Fix common/ includes.
 445         * mi/mi-main.c: Fix common/ includes.
 446         * mi/mi-cmd-env.c: Fix common/ includes.
 447         * memrange.h: Fix common/ includes.
 448         * memattr.c: Fix common/ includes.
 449         * maint.h: Fix common/ includes.
 450         * maint.c: Fix common/ includes.
 451         * main.c: Fix common/ includes.
 452         * machoread.c: Fix common/ includes.
 453         * location.c: Fix common/ includes.
 454         * linux-thread-db.c: Fix common/ includes.
 455         * linux-nat.c: Fix common/ includes.
 456         * linux-fork.c: Fix common/ includes.
 457         * inline-frame.c: Fix common/ includes.
 458         * infrun.c: Fix common/ includes.
 459         * inflow.c: Fix common/ includes.
 460         * inferior.h: Fix common/ includes.
 461         * inferior.c: Fix common/ includes.
 462         * infcmd.c: Fix common/ includes.
 463         * inf-ptrace.c: Fix common/ includes.
 464         * inf-child.c: Fix common/ includes.
 465         * ia64-linux-nat.c: Fix common/ includes.
 466         * i387-tdep.c: Fix common/ includes.
 467         * i386-tdep.c: Fix common/ includes.
 468         * i386-linux-tdep.c: Fix common/ includes.
 469         * i386-linux-nat.c: Fix common/ includes.
 470         * i386-go32-tdep.c: Fix common/ includes.
 471         * i386-fbsd-tdep.c: Fix common/ includes.
 472         * i386-fbsd-nat.c: Fix common/ includes.
 473         * guile/scm-type.c: Fix common/ includes.
 474         * guile/guile.c: Fix common/ includes.
 475         * go32-nat.c: Fix common/ includes.
 476         * gnu-nat.c: Fix common/ includes.
 477         * gdbthread.h: Fix common/ includes.
 478         * gdbarch-selftests.c: Fix common/ includes.
 479         * gdb_usleep.c: Fix common/ includes.
 480         * gdb_select.h: Fix common/ includes.
 481         * gdb_bfd.c: Fix common/ includes.
 482         * gcore.c: Fix common/ includes.
 483         * fork-child.c: Fix common/ includes.
 484         * findvar.c: Fix common/ includes.
 485         * fbsd-nat.c: Fix common/ includes.
 486         * event-top.c: Fix common/ includes.
 487         * event-loop.c: Fix common/ includes.
 488         * dwarf2read.c: Fix common/ includes.
 489         * dwarf2loc.c: Fix common/ includes.
 490         * dwarf2-frame.c: Fix common/ includes.
 491         * dwarf-index-cache.c: Fix common/ includes.
 492         * dtrace-probe.c: Fix common/ includes.
 493         * disasm-selftests.c: Fix common/ includes.
 494         * defs.h: Fix common/ includes.
 495         * csky-tdep.c: Fix common/ includes.
 496         * cp-valprint.c: Fix common/ includes.
 497         * cp-support.h: Fix common/ includes.
 498         * cp-support.c: Fix common/ includes.
 499         * corelow.c: Fix common/ includes.
 500         * completer.h: Fix common/ includes.
 501         * completer.c: Fix common/ includes.
 502         * compile/compile.c: Fix common/ includes.
 503         * compile/compile-loc2c.c: Fix common/ includes.
 504         * compile/compile-cplus-types.c: Fix common/ includes.
 505         * compile/compile-cplus-symbols.c: Fix common/ includes.
 506         * command.h: Fix common/ includes.
 507         * cli/cli-dump.c: Fix common/ includes.
 508         * cli/cli-cmds.c: Fix common/ includes.
 509         * charset.c: Fix common/ includes.
 510         * build-id.c: Fix common/ includes.
 511         * btrace.h: Fix common/ includes.
 512         * btrace.c: Fix common/ includes.
 513         * breakpoint.h: Fix common/ includes.
 514         * breakpoint.c: Fix common/ includes.
 515         * ax.h:
 516         (enum agent_op): Fix common/ includes.
 517         * ax-general.c (struct aop_map): Fix common/ includes.
 518         * ax-gdb.c: Fix common/ includes.
 519         * auxv.c: Fix common/ includes.
 520         * auto-load.c: Fix common/ includes.
 521         * arm-tdep.c: Fix common/ includes.
 522         * arch/riscv.c: Fix common/ includes.
 523         * arch/ppc-linux-common.c: Fix common/ includes.
 524         * arch/i386.c: Fix common/ includes.
 525         * arch/arm.c: Fix common/ includes.
 526         * arch/arm-linux.c: Fix common/ includes.
 527         * arch/arm-get-next-pcs.c: Fix common/ includes.
 528         * arch/amd64.c: Fix common/ includes.
 529         * arch/aarch64.c: Fix common/ includes.
 530         * arch/aarch64-insn.c: Fix common/ includes.
 531         * arch-utils.c: Fix common/ includes.
 532         * amd64-windows-tdep.c: Fix common/ includes.
 533         * amd64-tdep.c: Fix common/ includes.
 534         * amd64-sol2-tdep.c: Fix common/ includes.
 535         * amd64-obsd-tdep.c: Fix common/ includes.
 536         * amd64-nbsd-tdep.c: Fix common/ includes.
 537         * amd64-linux-tdep.c: Fix common/ includes.
 538         * amd64-linux-nat.c: Fix common/ includes.
 539         * amd64-fbsd-tdep.c: Fix common/ includes.
 540         * amd64-fbsd-nat.c: Fix common/ includes.
 541         * amd64-dicos-tdep.c: Fix common/ includes.
 542         * amd64-darwin-tdep.c: Fix common/ includes.
 543         * agent.c: Fix common/ includes.
 544         * ada-lang.h: Fix common/ includes.
 545         * ada-lang.c: Fix common/ includes.
 546         * aarch64-tdep.c: Fix common/ includes.
 547
 548 2019-01-25  Tom Tromey  <tom@tromey.com>
 549
 550         * common/create-version.sh: Use common/version.h.
 551
 552 2019-01-24  Pedro Alves  <palves@redhat.com>
 553
 554         * infrun.c (signal_stop, signal_print, signal_program)
 555         (signal_catch, signal_pass): Now arrays instead of pointers.
 556         (update_signals_program_target, do_target_resume)
 557         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 558         * linux-nat.c (linux_nat_target::pass_signals)
 559         (linux_nat_target::create_inferior, linux_nat_target::attach):
 560         Adjust.
 561         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 562         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 563         * procfs.c (procfs_target::pass_signals): Adjust.
 564         * record-full.c (record_full_target::resume): Adjust.
 565         * remote.c (remote_target::pass_signals)
 566         (remote_target::program_signals): Adjust.
 567         * target-debug.h (target_debug_print_signals): Now takes a
 568         gdb::array_view as parameter.  Adjust.
 569         * target.h (target_ops) <pass_signals, program_signals>: Replace
 570         pointer and length parameters with gdb::array_view.
 571         (target_pass_signals, target_program_signals): Likewise.
 572         * target-delegates.c: Regenerate.
 573
 574 2019-01-24  Pedro Alves  <palves@redhat.com>
 575
 576         * common/forward-scope-exit.h
 577         (forward_scope_exit::forward_scope_exit): Pass arguments to
 578         m_bind_function directly, instead of creating a std::bind and
 579         copying that.
 580
 581 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 582
 583         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 584         for static members.
 585         (pass_in_v_vfp_candidate): Likewise.
 586
 587 2019-01-23  Tom Tromey  <tom@tromey.com>
 588             Pedro Alves  <palves@redhat.com>
 589
 590         * regcache.c (class regcache_invalidator): Remove.
 591         (regcache::raw_write): Use make_scope_exit.
 592
 593 2019-01-23  Tom Tromey  <tom@tromey.com>
 594
 595         * ui-out.h (class ui_out_emit_type): Update comment.
 596
 597 2019-01-23  Tom Tromey  <tom@tromey.com>
 598
 599         * infrun.c (fetch_inferior_event): Update comment.
 600
 601 2019-01-23  Tom Tromey  <tom@tromey.com>
 602             Pedro Alves  <palves@redhat.com>
 603
 604         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 605         parameter.
 606         (fetch_inferior_event): Use SCOPE_EXIT.
 607
 608
 609 2019-01-23  Tom Tromey  <tom@tromey.com>
 610             Pedro Alves  <palves@redhat.com>
 611
 612         * infrun.c (disable_thread_events): Delete.
 613         (stop_all_threads): Use SCOPE_EXIT.
 614
 615 2019-01-23  Tom Tromey  <tom@tromey.com>
 616             Pedro Alves  <palves@redhat.com>
 617
 618         * symfile.c: Include forward-scope-exit.h.
 619         (clear_symtab_users_cleanup): Replace forward declaration with
 620         a FORWARD_SCOPE_EXIT.
 621         (syms_from_objfile_1): Use the forward_scope_exit and
 622         gdb::optional instead of cleanup_function.
 623         (reread_symbols): Use the forward_scope_exit instead of
 624         cleanup_function.
 625         (clear_symtab_users_cleanup): Remove function.
 626
 627 2019-01-23  Tom Tromey  <tom@tromey.com>
 628             Pedro Alves  <palves@redhat.com>
 629
 630         * linux-nat.c: Include scope-exit.h.
 631         (cleanup_target_stop): Remove.
 632         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 633         SCOPE_EXIT.
 634
 635 2019-01-23  Tom Tromey  <tom@tromey.com>
 636             Pedro Alves  <palves@redhat.com>
 637
 638         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 639         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 640
 641 2019-01-23  Tom Tromey  <tom@tromey.com>
 642             Andrew Burgess  <andrew.burgess@embecosm.com>
 643             Pedro Alves  <palves@redhat.com>
 644
 645         * infrun.c (fetch_inferior_event): Use scope_exit.
 646         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 647         * top.c (execute_command): Use scope_exit.
 648         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 649         * utils.c (do_bpstat_clear_actions_cleanup)
 650         (make_bpstat_clear_actions_cleanup): Remove.
 651
 652 2019-01-23  Tom Tromey  <tom@tromey.com>
 653             Pedro Alves  <palves@redhat.com>
 654
 655         * infrun.c: Include "common/scope-exit.h"
 656         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 657         (wait_for_inferior): Use SCOPE_EXIT.
 658         (fetch_inferior_event): Use scope_exit.
 659
 660 2019-01-23  Tom Tromey  <tom@tromey.com>
 661             Pedro Alves  <palves@redhat.com>
 662
 663         * breakpoint.c (create_breakpoint): Remove cleanup.
 664
 665 2019-01-23  Tom Tromey  <tom@tromey.com>
 666             Andrew Burgess  <andrew.burgess@embecosm.com>
 667             Pedro Alves  <palves@redhat.com>
 668
 669 2019-01-23  Pedro Alves  <palves@redhat.com>
 670
 671         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 672
 673 2019-01-23  Pedro Alves  <palves@redhat.com>
 674             Andrew Burgess  <andrew.burgess@embecosm.com>
 675
 676         * gdbthread.h: Include "common/forward-scope-exit.h".
 677         (scoped_finish_thread_state): Redefine custom class in terms of
 678         forward_scope_exit.
 679
 680 2019-01-23  Pedro Alves  <palves@redhat.com>
 681             Andrew Burgess  <andrew.burgess@embecosm.com>
 682
 683         * common/forward-scope-exit.h: New file.
 684
 685 2019-01-23  Pedro Alves  <palves@redhat.com>
 686             Andrew Burgess  <andrew.burgess@embecosm.com>
 687             Tom Tromey  <tom@tromey.com>
 688
 689         * common/scope-exit.h: New file.
 690
 691 2019-01-23  Pedro Alves  <palves@redhat.com>
 692
 693         * common/preprocessor.h (ESC): Rename to ...
 694         (ESC_PARENS): ... this.
 695         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 696         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 697
 698 2019-01-23  Tom Tromey  <tom@tromey.com>
 699
 700         * language.h (class scoped_switch_to_sym_language_if_auto):
 701         Initialize m_lang in both cases.
 702
 703 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 704
 705         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 706         with XCNEW.
 707
 708 2019-01-22  Tom Tromey  <tom@tromey.com>
 709
 710         * corelow.c: Do not include sys/file.h.
 711
 712 2019-01-22  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-wingeneral.h: Include gdb_curses.h.
 715
 716 2019-01-22  Tom Tromey  <tom@tromey.com>
 717
 718         * source-cache.h (class source_cache) <get_source_lines,
 719         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 720
 721 2019-01-22  Tom Tromey  <tom@tromey.com>
 722
 723         * remote-fileio.h (struct remote_target): Declare.
 724
 725 2019-01-22  Tom Tromey  <tom@tromey.com>
 726
 727         * python/py-arch.c: Do not include py-ref.h.
 728         * python/py-bpevent.c: Do not include py-ref.h.
 729         * python/py-cmd.c: Do not include py-ref.h.
 730         * python/py-continueevent.c: Do not include py-ref.h.
 731         * python/py-event.h: Do not include py-ref.h.
 732         * python/py-evtregistry.c: Do not include py-ref.h.
 733         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 734         * python/py-frame.c: Do not include py-ref.h.
 735         * python/py-framefilter.c: Do not include py-ref.h.
 736         * python/py-function.c: Do not include py-ref.h.
 737         * python/py-infevents.c: Do not include py-ref.h.
 738         * python/py-linetable.c: Do not include py-ref.h.
 739         * python/py-objfile.c: Do not include py-ref.h.
 740         * python/py-param.c: Do not include py-ref.h.
 741         * python/py-prettyprint.c: Do not include py-ref.h.
 742         * python/py-progspace.c: Do not include py-ref.h.
 743         * python/py-symbol.c: Do not include py-ref.h.
 744         * python/py-symtab.c: Do not include py-ref.h.
 745         * python/py-type.c: Do not include py-ref.h.
 746         * python/py-unwind.c: Do not include py-ref.h.
 747         * python/py-utils.c: Do not include py-ref.h.
 748         * python/py-value.c: Do not include py-ref.h.
 749         * python/py-varobj.c: Do not include py-ref.h.
 750         * python/py-xmethods.c: Do not include py-ref.h.
 751         * python/python.c: Do not include py-ref.h.
 752         * varobj.c: Do not include py-ref.h.
 753
 754 2019-01-22  Tom Tromey  <tom@tromey.com>
 755
 756         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 757         keyword for bcache.
 758
 759 2019-01-22  Tom Tromey  <tom@tromey.com>
 760
 761         * compile/compile-cplus-types.c: Remove a comment by #include.
 762
 763 2019-01-22  Tom Tromey  <tom@tromey.com>
 764
 765         * compile/gcc-c-plugin.h: Include compile-internal.h.
 766
 767 2019-01-22  Tom Tromey  <tom@tromey.com>
 768
 769         * stabsread.c (EXTERN): Do not define.
 770         (symnum, next_symbol_text_func, processing_gcc_compilation)
 771         (within_function, global_sym_chain, global_stabs)
 772         (previous_stab_code, this_object_header_files)
 773         (n_this_object_header_files)
 774         (n_allocated_this_object_header_files): Define.
 775         * stabsread.h (EXTERN): Never define.  Use "extern".
 776
 777 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 778
 779         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 780         history_value.
 781
 782 2019-01-21  Tom Tromey  <tom@tromey.com>
 783
 784         * ui-out.c: Fix includes.
 785         * tui/tui-source.c: Fix includes.
 786         * target.c: Fix includes.
 787         * remote.c: Fix includes.
 788         * regcache.c: Fix includes.
 789         * python/py-block.c: Fix includes.
 790         * printcmd.c: Fix includes.
 791         * or1k-tdep.c: Fix includes.
 792         * mi/mi-main.c: Fix includes.
 793         * m32r-tdep.c: Fix includes.
 794         * csky-tdep.c: Fix includes.
 795         * compile/compile-cplus-types.c: Fix includes.
 796         * cli/cli-interp.c: Fix includes.
 797
 798 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 799
 800         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 801         for padding.
 802
 803 2019-01-16  Tom Tromey  <tom@tromey.com>
 804
 805         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 806         earlier.
 807         (struct objfile) <msymbols_range>: Move from top level.
 808         <msymbols>: New method.
 809         (class objfile_msymbols): Remove.
 810         * symtab.c (default_collect_symbol_completion_matches_break_on):
 811         Update.
 812         * symmisc.c (dump_msymbols): Update.
 813         * stabsread.c (scan_file_globals): Update.
 814         * objc-lang.c (info_selectors_command, info_classes_command)
 815         (find_methods): Update.
 816         * minsyms.c (find_solib_trampoline_target): Update.
 817         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 818         * coffread.c (coff_symfile_read): Update.
 819         * ada-lang.c (ada_lookup_simple_minsym)
 820         (ada_collect_symbol_completion_matches): Update.
 821
 822 2019-01-16  Tom Tromey  <tom@tromey.com>
 823
 824         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 825         type.  Remove no-argument constructor.
 826         <iterator::operator++>: Simplify.
 827         <begin>: Update.
 828         <end>: Use minimal_symbol_count.
 829
 830 2019-01-16  Tom Tromey  <tom@tromey.com>
 831
 832         * objfiles.h (struct objfile) <psymtabs>: New method.
 833         (class objfile_psymtabs): Remove.
 834         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 835         typedef.
 836         <range>: New method.
 837         (require_partial_symbols): Change return type.
 838         * psymtab.c (require_partial_symbols)
 839         (psym_expand_symtabs_matching): Update.
 840         * mdebugread.c (parse_partial_symbols): Update.
 841         * dbxread.c (dbx_end_psymtab): Update.
 842
 843 2019-01-15  Tom Tromey  <tom@tromey.com>
 844
 845         * symtab.c (lookup_objfile_from_block)
 846         (lookup_symbol_in_objfile_symtabs)
 847         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 848         (find_line_symtab, info_sources_command)
 849         (default_collect_symbol_completion_matches_break_on)
 850         (make_source_files_completion_list): Update.
 851         * symmisc.c (print_objfile_statistics, dump_objfile)
 852         (maintenance_print_symbols, maintenance_info_symtabs)
 853         (maintenance_check_symtabs, maintenance_info_line_tables):
 854         Update.
 855         * source.c (select_source_symtab)
 856         (forget_cached_source_info_for_objfile): Update.
 857         * objfiles.h (class objfile_compunits): Remove.
 858         (struct objfile) <compunits_range>: New typedef.
 859         (compunits): New method.
 860         * objfiles.c (objfile_relocate1): Update.
 861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 862         * maint.c (count_symtabs_and_blocks): Update.
 863         * linespec.c (iterate_over_all_matching_symtabs): Update.
 864         * cp-support.c (add_symbol_overload_list_qualified): Update.
 865         * coffread.c (coff_symtab_read): Update.
 866         * ada-lang.c (add_nonlocal_symbols)
 867         (ada_collect_symbol_completion_matches)
 868         (ada_add_global_exceptions): Update.
 869
 870 2019-01-15  Tom Tromey  <tom@tromey.com>
 871
 872         * progspace.h (program_space) <objfiles_safe_range>: New
 873         typedef.
 874         <objfiles_safe>: New method.
 875         * objfiles.h (class all_objfiles_safe): Remove.
 876         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 877         * jit.c (jit_inferior_exit_hook): Update.
 878
 879 2019-01-17  Tom Tromey  <tom@tromey.com>
 880
 881         * progspace.h (program_space) <objfiles_range>: New typedef.
 882         <objfiles>: New method.
 883         <objfiles_head>: Rename from objfiles.
 884         (object_files): Update.
 885         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 886         * guile/scm-pretty-print.c
 887         (ppscm_find_pretty_printer_from_objfiles): Update.
 888         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 889         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 890         Update.
 891         * python/py-progspace.c (pspy_get_objfiles): Update.
 892         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 893         Update.
 894         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 895         (objfpy_lookup_objfile_by_build_id): Update.
 896         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 897         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 898         Update.
 899         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 900         (expand_symtab_containing_pc, lookup_objfile_from_block)
 901         (lookup_static_symbol, basic_lookup_transparent_type)
 902         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 903         (find_line_symtab, info_sources_command)
 904         (default_collect_symbol_completion_matches_break_on)
 905         (make_source_files_completion_list, find_main_name): Update.
 906         * symmisc.c (print_symbol_bcache_statistics)
 907         (print_objfile_statistics, maintenance_print_symbols)
 908         (maintenance_print_msymbols, maintenance_print_objfiles)
 909         (maintenance_info_symtabs, maintenance_check_symtabs)
 910         (maintenance_expand_symtabs, maintenance_info_line_tables):
 911         Update.
 912         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 913         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 914         (map_overlay_command, unmap_overlay_command)
 915         (simple_overlay_update, expand_symtabs_matching)
 916         (map_symbol_filenames): Update.
 917         * symfile-debug.c (set_debug_symfile): Update.
 918         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 919         Update.
 920         * source.c (select_source_symtab, forget_cached_source_info):
 921         Update.
 922         * solib.c (solib_read_symbols): Update.
 923         * solib-spu.c (append_ocl_sos): Update.
 924         * psymtab.c (maintenance_print_psymbols)
 925         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 926         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 927         * printcmd.c (info_symbol_command): Update.
 928         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 929         Update.
 930         * objfiles.h (class all_objfiles): Remove.
 931         * objfiles.c (have_partial_symbols, have_full_symbols)
 932         (have_minimal_symbols, qsort_cmp, update_section_map)
 933         (shared_objfile_contains_address_p)
 934         (default_iterate_over_objfiles_in_search_order): Update.
 935         * objc-lang.c (info_selectors_command, info_classes_command)
 936         (find_methods): Update.
 937         * minsyms.c (find_solib_trampoline_target): Update.
 938         * maint.c (maintenance_info_sections)
 939         (maintenance_translate_address, count_symtabs_and_blocks):
 940         Update.
 941         * main.c (captured_main_1): Update.
 942         * linux-thread-db.c (try_thread_db_load_from_pdir)
 943         (has_libpthread): Update.
 944         * linespec.c (iterate_over_all_matching_symtabs)
 945         (search_minsyms_for_name): Update.
 946         * jit.c (jit_find_objf_with_entry_addr): Update.
 947         * hppa-tdep.c (find_unwind_entry)
 948         (hppa_lookup_stub_minimal_symbol): Update.
 949         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 950         Update.
 951         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 952         (elf_gnu_ifunc_resolve_by_got): Update.
 953         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 954         * dwarf-index-write.c (save_gdb_index_command): Update.
 955         * cp-support.c (add_symbol_overload_list_qualified): Update.
 956         * breakpoint.c (create_overlay_event_breakpoint)
 957         (create_longjmp_master_breakpoint)
 958         (create_std_terminate_master_breakpoint)
 959         (create_exception_master_breakpoint): Update.
 960         * blockframe.c (find_pc_partial_function): Update.
 961         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 962         (ada_collect_symbol_completion_matches)
 963         (ada_add_global_exceptions): Update.
 964
 965 2019-01-17  Tom Tromey  <tom@tromey.com>
 966
 967         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 968         declare VEC.
 969         (solib_target_parse_libraries): Change return type.
 970         (library_list_start_segment, library_list_start_section)
 971         (library_list_end_library, library_list_start_library); Update.
 972         (solib_target_free_library_list): Remove.
 973         (solib_target_parse_libraries): Remove cleanup.  Change return
 974         type.
 975         (solib_target_current_sos): Update.
 976
 977 2019-01-17  Tom Tromey  <tromey@bapiya>
 978
 979         * valprint.c: Replace "the the" with "the".
 980         * symtab.c: Replace "the the" with "the".
 981         * solib.c: Replace "the the" with "the".
 982         * solib-dsbt.c: Replace "the the" with "the".
 983         * linespec.c: Replace "the the" with "the".
 984         * dwarf2loc.h: Replace "the the" with "the".
 985         * amd64-windows-tdep.c: Replace "the the" with "the".
 986         * aarch64-tdep.c: Replace "the the" with "the".
 987
 988 2019-01-16  Keith Seitz  <keiths@redhat.com>
 989
 990         PR gdb/23773
 991         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 992         <builder>: Rename to ..
 993         <m_builder>: ... this and make private.
 994         (dwarf2_cu::get_builder): New method.  Change all users of
 995         `builder' to use this method.
 996         (dwarf2_start_symtab): Move to ...
 997         (dwarf2_cu::start_symtab): ... here.  Update all callers
 998         (setup_type_unit_groups): Move to ...
 999         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1000         callers.
1001         (dwarf2_cu::reset_builder): New method.
1002         (process_full_compunit, process_full_type_unit): Use
1003         dwarf2_cu::reset_builder.
1004         (follow_die_offset): Record the ancestor CU if it is different
1005         from the followed DIE's CU.
1006         (follow_die_sig_1): Likewise.
1007
1008 2019-01-15  Tom Tromey  <tom@tromey.com>
1009
1010         * remote.c (class remote_state) <buf>: Now a char_vector.
1011         <buf_size>: Remove.
1012         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1013         parameter.
1014         (remote_target::getpkt_or_notif_sane_1)
1015         (remote_target::getpkt_sane)
1016         (remote_target::getpkt_or_notif_sane): Likewise.
1017         (class remote_target) <putpkt>: New overload.
1018         (remote_target::read_frame): Change type of "buf_p".  Remove
1019         sizeof_p parameter.
1020         (packet_ok): New overload.
1021         (packet_check_result): New overload.
1022         Update all uses.
1023
1024 2019-01-14  Tom Tromey  <tom@tromey.com>
1025
1026         * remote-notif.c (handle_notification, remote_notif_ack)
1027         (remote_notif_parse): Make "buf" const.
1028         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1029         const.
1030         (remote_notif_parse, remote_notif_ack, handle_notification):
1031         Likewise.
1032         * remote.c (remote_notif_stop_parse): Make "buf" const.
1033         (remote_target::remote_parse_stop_reply): Make "buf" const.
1034         (remote_notif_stop_ack): Make "buf" const.
1035
1036 2019-01-14  Tom Tromey  <tom@tromey.com>
1037
1038         * remote.c (remote_console_output): Make parameter const.
1039
1040 2019-01-14  Tom Tromey  <tom@tromey.com>
1041
1042         * target-debug.h (target_debug_print_signals): Constify.
1043         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1044         * procfs.c (procfs_target::pass_signals): Update.
1045         * linux-nat.c (linux_nat_target::pass_signals): Update.
1046         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1047         * target-delegates.c: Rebuild.
1048         * remote.c (remote_target::program_signals): Update.
1049         (remote_target::pass_signals): Update.
1050         * target.c (target_pass_signals): Constify argument.
1051         (target_program_signals): Likewise.
1052         * target.h (struct target_ops) <pass_signals, program_signals>:
1053         Constify argument.
1054         (target_pass_signals, target_program_signals): Constify argument.
1055
1056 2019-01-14  Tom Tromey  <tom@tromey.com>
1057
1058         PR tui/28819:
1059         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1060
1061 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1062
1063         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1064         field.
1065         * rs6000-tdep.c: Include reggroups.h.
1066         (IS_V_ALIAS_PSEUDOREG): Define.
1067         (rs6000_register_name): Return names for the "vX" aliases.
1068         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1069         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1070         aliases.  Call default_register_reggroup_p for all other
1071         pseudo-registers.
1072         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1073         New functions.
1074         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1075         Handle "vX" aliases.
1076         (v_alias_pseudo_register_collect): New function.
1077         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1078         (rs6000_gdbarch_init): Initialize "vX" aliases as
1079         pseudo-registers.  Restore registration of
1080         rs6000_pseudo_register_reggroup_p with
1081         set_tdesc_pseudo_register_reggroup_p.
1082
1083 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1084
1085         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1086         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1087         set_gdbarch_num_pseudo_regs.
1088
1089 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1090
1091         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1092         Remove arg prefixname, add do_set and do_show.
1093         Add member functions set_list and show_list.
1094         * cli/cli-style.c (class cli_style_option): Update accordingly.
1095         (style_set_list): Move to file scope.
1096         (style_show_list): Likewise.
1097         (set_style): Call help_list.
1098         (show_style): Call cmd_show_list.
1099         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1100         Update to use the new macro.
1101
1102 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1103
1104         * ada-lang.c (_initialize_ada_language): Expand the help text
1105         for the "catch exception" command.
1106
1107 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1108
1109         * symtab.c (matching_obj_sections): Initialize obj,
1110         declare it closer to its usage.
1111
1112 2019-01-10  Tom Tromey  <tom@tromey.com>
1113
1114         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1115         (basic_inf_threads_range): Remove.
1116         (inf_threads_range, inf_non_exited_threads_range)
1117         (safe_inf_threads_range): Use next_adapter.
1118
1119 2019-01-10  Keith Seitz  <keiths@redhat.com>
1120
1121         PR gdb/23712
1122         PR symtab/23010
1123         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1124         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1125
1126 2019-01-10  Keith Seitz  <keiths@redhat.com>
1127
1128         PR gdb/23712
1129         PR symtab/23010
1130         * dictionary.c (pending_to_vector): Remove.
1131         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1132         Remove _1 suffix, replacing functions of the same name.  Update
1133         all callers.
1134         (dict_create_hashed, dict_create_hashed_expandable)
1135         (dict_create_linear, dict_create_linear_expandable, dict_free)
1136         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1137         Make functions static.
1138
1139 2019-01-10  Keith Seitz  <keiths@redhat.com>
1140
1141         PR gdb/23712
1142         PR symtab/23010
1143         * dictionary.h (struct dictionary): Replace declaration with
1144         multidictionary.
1145         (dict_create_hashed, dict_create_hashed_expandable)
1146         (dict_create_linear, dict_create_linear_expandable)
1147         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1148         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1149         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1150         taking multidictionary argument.
1151         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1152         * block.h (struct block) <dict>: Change to multidictionary
1153         and rename `multidict'.
1154         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1155         symmisc.c: Update all dictionary references to multidictionary.
1156
1157 2019-01-10  Keith Seitz  <keiths@redhat.com>
1158
1159         PR gdb/23712
1160         PR symtab/23010
1161         * dictionary.c: Include unordered_map.
1162         (pending_to_vector): New function.
1163         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1164         Rewrite the non-"_1" functions to take vector instead
1165         of linked list.
1166         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1167         "new" _1 versions of the same name.
1168         (multidictionary): Define.
1169         (std::hash<enum language): New definition.
1170         (collate_pending_symbols_by_language, mdict_create_hashed)
1171         (mdict_create_hashed_expandable, mdict_create_linear)
1172         (mdict_create_linear_expandable, mdict_free)
1173         (find_language_dictionary, create_new_language_dictionary)
1174         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1175         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1176         (mdict_size, mdict_empty): New functions.
1177         * dictionary.h (mdict_iterator): Define.
1178
1179 2019-01-10  Pedro Alves  <palves@redhat.com>
1180
1181         * breakpoint.c (read_uploaded_action)
1182         (create_tracepoint_from_upload): Adjust to use
1183         gdb::unique_xmalloc_ptr.
1184         * ctf.c (ctf_write_uploaded_tp):
1185         (SET_ARRAY_FIELD): Use emplace_back.
1186         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1187         * tracefile-tfile.c (tfile_write_uploaded_tp):
1188         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1189         gdb::unique_xmalloc_ptr.
1190         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1191         at_string, cond_string, cmd_strings>: Replace char pointers
1192         with gdb::unique_xmalloc_ptr.
1193
1194 2019-01-10  Pedro Alves  <palves@redhat.com>
1195
1196         * solib-target.c (library_list_start_library): Don't xstrdup name.
1197
1198 2019-01-10  Pedro Alves  <palves@redhat.com>
1199
1200         * mdebugread.c (parse_partial_symbols): Use
1201         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1202
1203 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1204
1205         * linux-fork.c (scoped_switch_fork_info)
1206         <~scoped_switch_fork_info>: Fix incorrect variable name.
1207
1208 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * linux-fork.c (scoped_switch_fork_info)
1211         <scoped_switch_fork_info>: Make explicit.
1212         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1213
1214 2019-01-10  Tom Tromey  <tom@tromey.com>
1215
1216         * objfiles.h (objfile::reset_psymtabs): Update.
1217         * objfiles.c (objfile::objfile): Update.
1218         * psymtab.h (psymtab_storage::obstack): Update.
1219         (psymtab_storage::m_obstack): Use gdb::optional.
1220         (class psymtab_storage): Update comment.  Remove objfile
1221         parameter.
1222         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1223
1224 2019-01-10  Tom Tromey  <tom@tromey.com>
1225
1226         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1227         <free_psymtabs>: Now private.
1228         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1229         (allocate_psymtab): Use new method.
1230
1231 2019-01-10  Tom Tromey  <tom@tromey.com>
1232
1233         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1234         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1235         * mdebugread.c (parse_partial_symbols): Use
1236         allocate_dependencies.
1237         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1238         allocate_dependencies.
1239         (process_psymtab_comp_unit_reader)
1240         (build_type_psymtab_dependencies): Likewise.
1241         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1242
1243 2019-01-10  Tom Tromey  <tom@tromey.com>
1244
1245         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1246         PSYMBOL_SET_LANGUAGE.
1247         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1248
1249 2019-01-10  Tom Tromey  <tom@tromey.com>
1250
1251         * psymtab.h (psymtab_storage::obstack): New method.
1252         <m_obstack>: Rename from obstack; now private.
1253         * psymtab.c (psymtab_storage): Update.
1254         * dwarf2read.c (create_addrmap_from_index)
1255         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1256         Update.
1257
1258 2019-01-10  Tom Tromey  <tom@tromey.com>
1259
1260         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1261         * objfiles.h (objfile::reset_psymtabs): New method.
1262
1263 2019-01-10  Tom Tromey  <tom@tromey.com>
1264
1265         * symmisc.c (print_symbol_bcache_statistics): Update.
1266         (print_objfile_statistics): Update.
1267         * symfile.c (reread_symbols): Update.
1268         * psymtab.h (class psymtab_storage): New.
1269         * psymtab.c (psymtab_storage): New constructor.
1270         (~psymtab_storage): New destructor.
1271         (require_partial_symbols): Update.
1272         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1273         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1274         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1275         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1276         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1277         (start_psymtab_common, end_psymtab_common)
1278         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1279         (allocate_psymtab): Update.
1280         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1281         Update.
1282         (dump_psymtab_addrmap, maintenance_print_psymbols)
1283         (maintenance_check_psymtabs): Update.
1284         (class objfile_psymtabs): Move to objfiles.h.
1285         * psympriv.h (discard_psymtab): Now inline.
1286         (psymtab_discarder::psymtab_discarder): Update.
1287         (psymtab_discarder::~psymtab_discarder): Update.
1288         (ALL_OBJFILE_PSYMTABS): Rewrite.
1289         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1290         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1291         Remove fields.
1292         <partial_symtabs>: New field.
1293         (class objfile_psymtabs): Move from psymtab.h.  Update.
1294         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1295         psymbol_cache.
1296         (objfile::~objfile): Don't destroy psymbol_cache.
1297         * mdebugread.c (parse_partial_symbols): Update.
1298         * dwarf2read.c (create_addrmap_from_index)
1299         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1300         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1301         (add_partial_subprogram, dwarf2_ranges_read): Update.
1302         * dwarf-index-write.c (write_address_map)
1303         (write_one_signatured_type, recursively_write_psymbols)
1304         (class debug_names, class debug_names, write_psymtabs_to_index):
1305         Update.
1306
1307 2019-01-10  Tom Tromey  <tom@tromey.com>
1308
1309         * symtab.h (SYMBOL_SET_NAMES): Update.
1310         (symbol_set_names): Update.
1311         (MSYMBOL_SET_NAMES): Update.
1312         * symtab.c (symbol_set_names): Change argument to be an
1313         objfile_per_bfd_storage.
1314         * psymtab.c (add_psymbol_to_bcache): Update.
1315         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1316
1317 2019-01-10  Tom Tromey  <tom@tromey.com>
1318
1319         * symtab.c (create_demangled_names_hash): Change argument to be an
1320         objfile_per_bfd_storage.
1321         (symbol_set_names): Update.
1322
1323 2019-01-10  Tom Tromey  <tom@tromey.com>
1324
1325         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1326         init_psymbol_list.
1327         * psymtab.c (init_psymbol_list): Do nothing if already called.
1328         * psympriv.h (init_psymbol_list): Add comment.
1329         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1330         init_psymbol_list.
1331         * dbxread.c (dbx_symfile_read): Unconditionally call
1332         init_psymbol_list.
1333
1334 2019-01-10  Tom Tromey  <tom@tromey.com>
1335
1336         * xcoffread.c (scan_xcoff_symtab): Update.
1337         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1338         "where".
1339         * mdebugread.c (parse_partial_symbols)
1340         (handle_psymbol_enumerators): Update.
1341         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1342         * dbxread.c (read_dbx_symtab): Update.
1343         * psympriv.h (psymbol_placement): New enum.
1344         (add_psymbol_to_list): Update.
1345
1346 2019-01-10  Tom Tromey  <tom@tromey.com>
1347
1348         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1349         static_psymbols parameters.
1350         (scan_xcoff_symtab): Update.
1351         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1352         static_psymbols parameters.
1353         * psympriv.h (start_psymtab_common): Update.
1354         * mdebugread.c (parse_partial_symbols): Update.
1355         * dwarf2read.c (create_partial_symtab): Update.
1356         * dbxread.c (read_dbx_symtab): Update.
1357         (start_psymtab): Remove global_psymbols and static_psymbols
1358         parameters.
1359
1360 2019-01-10  Tom Tromey  <tom@tromey.com>
1361
1362         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1363         * psymtab.c (allocate_psymtab): Add comment.
1364         * psympriv.h (allocate_psymtab): Add comment.
1365         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1366         initializations.
1367         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1368
1369 2019-01-10  Tom Tromey  <tom@tromey.com>
1370
1371         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1372         Don't declare.
1373         * mipsread.c: Include mdebugread.h.
1374         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1375         Declare.
1376         * elfread.c: Include mdebugread.h.
1377
1378 2019-01-09  Tom Tromey  <tom@tromey.com>
1379
1380         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1381         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1382         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1383         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1384         (psym_lookup_symbol, psym_find_last_source_symtab)
1385         (psym_forget_cached_source_info, psym_print_stats)
1386         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1387         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1388         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1389         (psym_find_compunit_symtab_by_address)
1390         (maintenance_print_psymbols, maintenance_info_psymtabs)
1391         (maintenance_check_psymtabs): Use ranged for.
1392         * psymtab.h (class objfile_psymtabs): New.
1393         (require_partial_symbols): Return objfile_psymtabs.
1394         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1395
1396 2019-01-09  Tom Tromey  <tom@tromey.com>
1397
1398         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1399         (find_pc_mapped_section, list_overlays_command)
1400         (map_overlay_command, unmap_overlay_command)
1401         (simple_overlay_update): Use all_objfiles.
1402         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1403         * printcmd.c (info_symbol_command): Use all_objfiles.
1404         * objfiles.h (ALL_OBJSECTIONS): Remove.
1405         * maint.c (maintenance_translate_address): Use all_objfiles.
1406         * gcore.c (gcore_create_callback): Use all_objfiles.
1407         (objfile_find_memory_regions): Likewise.
1408
1409 2019-01-09  Tom Tromey  <tom@tromey.com>
1410
1411         * symtab.c (find_line_symtab, info_sources_command)
1412         (make_source_files_completion_list): Use objfile_compunits.
1413         * source.c (select_source_symtab): Use objfile_compunits.
1414         * objfiles.h (struct objfile): Update comment.
1415         (ALL_OBJFILES): Remove.
1416         (ALL_FILETABS): Remove.
1417         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1418         objfile_compunits.
1419
1420 2019-01-09  Tom Tromey  <tom@tromey.com>
1421
1422         * symmisc.c (print_objfile_statistics, dump_objfile)
1423         (maintenance_print_symbols): Use compunit_filetabs.
1424         * source.c (forget_cached_source_info_for_objfile): Use
1425         compunit_filetabs.
1426         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1427         (ALL_FILETABS): Use compunit_filetabs.
1428         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1429         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1430
1431 2019-01-09  Tom Tromey  <tom@tromey.com>
1432
1433         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1434         (compunit_filetabs): New.
1435         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1436         compunit_filetabs.
1437         (info_sources_command, make_source_files_completion_list): Remove
1438         declaration.
1439         * symmisc.c (print_objfile_statistics, dump_objfile)
1440         (maintenance_print_symbols): Remove declaration.
1441         (maintenance_info_symtabs): Use compunit_filetabs.
1442         (maintenance_info_line_tables): Likewise.
1443         * source.c (select_source_symtab): Change local variable name.
1444         (forget_cached_source_info_for_objfile): Remove declaration.
1445         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1446         * objfiles.c (objfile_relocate1): Remove declaration.
1447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1448         declaration.
1449         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1450         * coffread.c (coff_symtab_read): Remove declaration.
1451         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1452         compunit_filetabs.
1453
1454 2019-01-09  Tom Tromey  <tom@tromey.com>
1455
1456         * symtab.c (lookup_objfile_from_block)
1457         (find_pc_sect_compunit_symtab, search_symbols)
1458         (default_collect_symbol_completion_matches_break_on): Use
1459         objfile_compunits.
1460         * objfiles.h (ALL_COMPUNITS): Remove.
1461         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1462         * cp-support.c (add_symbol_overload_list_qualified): Use
1463         objfile_compunits.
1464         * ada-lang.c (ada_collect_symbol_completion_matches)
1465         (ada_add_global_exceptions): Use objfile_compunits.
1466
1467 2019-01-09  Tom Tromey  <tom@tromey.com>
1468
1469         * source.c (select_source_symtab)
1470         (forget_cached_source_info_for_objfile): Remove declaration.
1471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1472         declaration.
1473         * maint.c (count_symtabs_and_blocks): Remove declaration.
1474         * cp-support.c (add_symbol_overload_list_qualified): Remove
1475         declaration.
1476         * coffread.c (coff_symtab_read): Remove declaration.
1477         * symtab.c (lookup_symbol_in_objfile_symtabs)
1478         (basic_lookup_transparent_type_1): Use objfile_compunits.
1479         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1480         (info_sources_command, search_symbols)
1481         (default_collect_symbol_completion_matches_break_on)
1482         (make_source_files_completion_list): Remove declaration.
1483         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1484         (ada_collect_symbol_completion_matches)
1485         (ada_add_global_exceptions): Remove declaration.
1486         * linespec.c (iterate_over_all_matching_symtabs): Use
1487         objfile_compunits.
1488         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1489         (class objfile_compunits): New.
1490         (ALL_COMPUNITS): Use objfile_compunits.
1491         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1492         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1493         objfile_compunits.
1494         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1495
1496 2019-01-09  Tom Tromey  <tom@tromey.com>
1497
1498         * symtab.c (search_symbols)
1499         (default_collect_symbol_completion_matches_break_on): Use
1500         objfile_msymbols.
1501         * ada-lang.c (ada_lookup_simple_minsym)
1502         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1503         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1504         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1505         objfile_msymbols.
1506         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1507         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1508         * objc-lang.c (find_methods): Use objfile_msymbols.
1509         (info_selectors_command, info_classes_command): Likewise.
1510         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1511         * objfiles.h (class objfile_msymbols): New.
1512         (ALL_OBJFILE_MSYMBOLS): Remove.
1513         (ALL_MSYMBOLS): Remove.
1514
1515 2019-01-09  Tom Tromey  <tom@tromey.com>
1516
1517         * common/next-iterator.h (next_adapter): Add Iterator template
1518         parameter.
1519         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1520         (class all_objfiles_safe): New.
1521         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1522         * objfiles.c (put_objfile_before): Update comment.
1523         (add_separate_debug_objfile): Likewise.
1524         (free_all_objfiles): Use all_objfiles_safe.
1525         (objfile_purge_solibs): Likewise.
1526
1527 2019-01-09  Tom Tromey  <tom@tromey.com>
1528
1529         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1530         (expand_symtab_containing_pc, lookup_static_symbol)
1531         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1532         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1533         all_objfiles.
1534         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1535         * breakpoint.c (create_overlay_event_breakpoint)
1536         (create_longjmp_master_breakpoint)
1537         (create_std_terminate_master_breakpoint)
1538         (create_exception_master_breakpoint): Use all_objfiles.
1539         * linux-thread-db.c (try_thread_db_load_from_pdir)
1540         (has_libpthread): Use all_objfiles.
1541         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1542         * linespec.c (iterate_over_all_matching_symtabs)
1543         (search_minsyms_for_name): Use all_objfiles.
1544         * maint.c (maintenance_info_sections): Use all_objfiles.
1545         * main.c (captured_main_1): Use all_objfiles.
1546         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1547         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1548         * guile/scm-pretty-print.c
1549         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1550         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1551         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1552         (maintenance_print_msymbols): Use all_objfiles.
1553         * source.c (select_source_symtab): Use all_objfiles.
1554         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1555         * symfile.c (remove_symbol_file_command)
1556         (expand_symtabs_matching, map_symbol_filenames): Use
1557         all_objfiles.
1558         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1559         all_objfiles.
1560         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1561         * objc-lang.c (find_methods): Use all_objfiles.
1562         * objfiles.c (have_partial_symbols, have_full_symbols)
1563         (have_minimal_symbols, qsort_cmp)
1564         (default_iterate_over_objfiles_in_search_order): Use
1565         all_objfiles.
1566         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1567         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1568         (maintenance_check_psymtabs): Use all_objfiles.
1569         (ALL_PSYMTABS): Remove.
1570         * compile/compile-object-run.c (do_module_cleanup): Use
1571         all_objfiles.
1572         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1573         * cp-support.c (add_symbol_overload_list_qualified): Use
1574         all_objfiles.
1575         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1576         Use all_objfiles.
1577         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1578         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1579         all_objfiles.
1580         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1581         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1582         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1583         Uses all_objfiles.
1584         * solib.c (solib_read_symbols): Use all_objfiles
1585
1586 2019-01-09  Tom Tromey  <tom@tromey.com>
1587
1588         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1589         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1590         all_objfiles.
1591         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1592         * symmisc.c (print_symbol_bcache_statistics)
1593         (print_objfile_statistics, maintenance_print_objfiles)
1594         (maintenance_info_symtabs, maintenance_check_symtabs)
1595         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1596         all_objfiles.
1597         * source.c (forget_cached_source_info): Use all_objfiles.
1598         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1599         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1600         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1601         * objfiles.c (update_section_map): Use all_objfiles.
1602         (shared_objfile_contains_address_p): Likewise.
1603         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1604         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1605
1606 2019-01-09  Tom Tromey  <tom@tromey.com>
1607
1608         * common/next-iterator.h: New file.
1609         * objfiles.h (class all_objfiles): New.
1610         (struct objfile_iterator): New.
1611
1612 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1613
1614         * NEWS: Move the description of the changed "frame", "select-frame",
1615          and "info frame" commands to the Changed commands section.
1616
1617 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1618
1619         * gdbtypes.c (check_stub_method_group): Remove handling of old
1620         mangling schemes.
1621         * linespec.c (find_methods): Likewise.
1622         * stabsread.c (read_member_functions): Likewise.
1623         * valops.c (search_struct_method): Likewise.
1624         (value_struct_elt_for_reference): Likewise.
1625         * NEWS: Mention this change.
1626
1627 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1630         print_source_lines.
1631         * source.c (print_source_lines_base): Update line number check.
1632         (print_source_lines): New function.
1633         (source_lines_range::source_lines_range): New function.
1634         * source.h (class source_lines_range): New class.
1635         (print_source_lines): New declaration.
1636
1637 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1638
1639         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1640
1641 2019-01-08  Tom Tromey  <tom@tromey.com>
1642             Simon Marchi  <simon.marchi@ericsson.com>
1643
1644         PR gdb/24060
1645         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1646         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1647         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1648         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1649         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1650         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1651
1652 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * source.c (select_source_symtab): Move header comment to
1655         declaration in source.h.
1656         (forget_cached_source_info_for_objfile): Likewise.
1657         (forget_cached_source_info): Likewise.
1658         (identify_source_line): Likewise.
1659         * source.h (identify_source_line): Move declaration from symtab.h
1660         and add comment from source.c
1661         (print_source_lines): Likewise.
1662         (forget_cached_source_info_for_objfile): Likewise.
1663         (forget_cached_source_info): Likewise.
1664         (select_source_symtab): Likewise.
1665         (enum print_source_lines_flag): Move definition from symtab.h.
1666         * symtab.h (identify_source_line): Move declaration to source.h.
1667         (print_source_lines): Likewise.
1668         (forget_cached_source_info_for_objfile): Likewise.
1669         (forget_cached_source_info): Likewise.
1670         (select_source_symtab): Likewise.
1671         (enum print_source_lines_flag): Move definition to source.h.
1672         * tui/tui-hooks.c: Add 'source.h' include.
1673
1674 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * source.c (print_source_lines_base): Handle requests to print
1677         reverse line number sequences, and guard against empty lines
1678         string.
1679
1680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1681
1682         * source.c (print_source_lines_base): Fix skip of '\r' if next
1683         character is '\n'.
1684
1685 2019-01-06  Tom Tromey  <tom@tromey.com>
1686
1687         * c-exp.y (struct c_parse_state) <macro_original_text,
1688         expansion_obstack>: New member.
1689         (macro_original_text, expansion_obstack): Remove globals.
1690         (scan_macro_expansion, scanning_macro_expansion)
1691         (finished_macro_expansion): Update.
1692         (scan_macro_cleanup): Remove.
1693         (yylex, c_parse): Update.
1694
1695 2019-01-06  Tom Tromey  <tom@tromey.com>
1696
1697         * c-exp.y (struct c_parse_state) <strings>: New member.
1698         (operator_stoken): Update.
1699
1700 2019-01-06  Tom Tromey  <tom@tromey.com>
1701
1702         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1703         (union type_stack_elt) <typelist_val>: Now a pointer to
1704         std::vector.
1705         (type_stack_cleanup): Don't declare.
1706         (push_typelist): Update.
1707         * parse.c (pop_typelist): Return a std::vector.
1708         (push_typelist): Take a std::vector.
1709         (follow_types): Update.  Do not free args.
1710         (type_stack_cleanup): Remove.
1711         * c-exp.y (struct c_parse_state): New.
1712         (cpstate): New global.
1713         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1714         (nonempty_typelist): Update.
1715         (func_mod): Create a new vector.
1716         (c_parse): Create a c_parse_state.
1717         (check_parameter_typelist): Do not delete params.
1718         (function_method): Update.  Do not delete type_list.
1719
1720 2019-01-06  Tom Tromey  <tom@tromey.com>
1721
1722         PR gdb/28155:
1723         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1724         check_typedef.
1725         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1726         (print_return_value): Likewise.
1727
1728 2019-01-05  Tom Tromey  <tom@tromey.com>
1729
1730         * contrib/cleanup_check.py: Remove.
1731         * contrib/gcc-with-excheck: Remove.
1732         * contrib/exsummary.py: Remove.
1733         * contrib/excheck.py: Remove.
1734
1735 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1736
1737         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1738         NULL. Initialize tpprev to NULL instead of assigning it
1739         to NULL on the next statement.
1740         * windows-nat.c (windows_delete_thread): Remove check for
1741         main_thread_id before printing thread exit notifications.
1742         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1743         Remove thread ID check against main_thread_id.
1744         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1745         windows_delete_thread.
1746         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1747
1748 2019-01-04  Tom Tromey  <tom@tromey.com>
1749
1750         * compile/compile.c (_initialize_compile): Use upper case for
1751         metasyntactic variables.
1752         * symmisc.c (_initialize_symmisc): Use upper case for
1753         metasyntactic variables.
1754         * psymtab.c (_initialize_psymtab): Use upper case for
1755         metasyntactic variables.
1756         * demangle.c (demangle_command): Use upper case for metasyntactic
1757         variables.
1758         (_initialize_demangler): Likewise.
1759         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1760         variables.
1761
1762 2019-01-03  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1765
1766 2019-01-03  Tom Tromey  <tom@tromey.com>
1767
1768         * python/py-symtab.c (salpy_str): Update.
1769         (struct salpy_sal_object) <symtab>: Now a PyObject.
1770         (salpy_dealloc): Update.
1771         (del_objfile_sal): Use gdbpy_ref.
1772
1773 2019-01-03  Tom Tromey  <tom@tromey.com>
1774
1775         * python/py-type.c (convert_field): Use new_reference.  Return
1776         gdbpy_ref.
1777         (make_fielditem): Return gdbpy_ref.
1778         (typy_fields): Update.
1779         (typy_getitem): Update.
1780         (field_name): Return gdbpy_ref.  Use new_reference.
1781         (typy_iterator_iternext): Update.
1782
1783 2019-01-03  Tom Tromey  <tom@tromey.com>
1784
1785         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1786
1787 2019-01-03  Tom Tromey  <tom@tromey.com>
1788
1789         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1790         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1791         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1792         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1793         (pspy_set_type_printers): Likewise.
1794         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1795         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1796         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1797         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1798         (objfpy_set_type_printers): Likewise.
1799
1800 2019-01-03  Tom Tromey  <tom@tromey.com>
1801
1802         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1803         (gdbpy_print_stack): Use gdbpy_err_fetch.
1804         * python/python-internal.h (class gdbpy_err_fetch): New class.
1805         (class gdbpy_enter) <m_error_type, m_error_value,
1806         m_error_traceback>: Remove.
1807         <m_error>: New member.
1808         (gdbpy_exception_to_string): Don't declare.
1809         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1810         * python/py-value.c (convert_value_from_python): Use
1811         gdbpy_err_fetch.
1812         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1813         gdbpy_exception_to_string.
1814         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1815         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1816         gdbpy_err_fetch.
1817
1818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1819
1820         * linux-nat.c (delete_lwp_cleanup): Delete.
1821         (struct lwp_deleter): New struct.
1822         (lwp_info_up): New typedef.
1823         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1824         lwp_info_up.
1825
1826 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1827
1828         * linux-fork.c (class scoped_switch_fork_info): New class.
1829         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1830
1831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * valops.c (find_overload_match): Remove use of null_cleanup, and
1834         calls to do_cleanups.
1835
1836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1837
1838         * compile/compile-cplus-types.c
1839         (compile_cplus_instance::decl_name): Handle changes to
1840         cp_func_name.
1841         * cp-support.c (cp_func_name): Update header comment, update
1842         return type.
1843         * cp-support.h (cp_func_name): Update return type in declaration.
1844         * valops.c (find_overload_match): Move temp_func local to top
1845         level of function and change its type.  Use temp_func to hold and
1846         delete temporary string obtained from cp_func_name.
1847
1848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1849
1850         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1851         gdb::char_vector, remove cleanup, and update uses of `msg`.
1852
1853 2019-01-03  Jim Wilson  <jimw@sifive.com>
1854
1855         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1856
1857 2019-01-02  Tom Tromey  <tom@tromey.com>
1858
1859         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1860         (tdesc_parse_xml): Remove cleanups.
1861         * target-descriptions.h (make_cleanup_free_target_description):
1862         Don't declare.
1863         (target_desc_deleter): New struct.
1864         (target_desc_up): New typedef.
1865         * target-descriptions.c (target_desc_deleter::operator()): Rename
1866         from free_target_description.
1867         (make_cleanup_free_target_description): Remove.
1868
1869 2019-01-02  Tom Tromey  <tom@tromey.com>
1870
1871         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1872         constructor, destructor.
1873         (linespec_parser): Remove typedef.
1874         (~linespec_parser): Rename from linespec_parser_delete.
1875         (linespec_lex_to_end, linespec_complete_label)
1876         (linespec_complete): Update.
1877         (decode_line_full): Remove cleanups.
1878         (decode_line_1): Update.
1879
1880 2019-01-02  Tom Tromey  <tom@tromey.com>
1881
1882         * python/python-internal.h (inferior_to_inferior_object): Change
1883         return type.
1884         * python/py-exitedevent.c (create_exited_event_object): Update.
1885         * python/py-inferior.c (inferior_to_inferior_object): Return
1886         gdbpy_ref.
1887         (python_new_inferior, python_inferior_deleted)
1888         (thread_to_thread_object, delete_thread_object)
1889         (build_inferior_list, gdbpy_selected_inferior): Update.
1890         * python/py-infthread.c (create_thread_object): Update.  Also fail
1891         if inferior_to_inferior_object fails.
1892
1893 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1894
1895         * inferior.h (class inferior) <displaced_step_state>: New field.
1896         * infrun.h (struct displaced_step_state): Move here from
1897         infrun.c.  Initialize fields, add constructor.
1898         <inf>: Remove field.
1899         <reset>: New method.
1900         * infrun.c (struct displaced_step_inferior_state): Move to
1901         infrun.h.
1902         (displaced_step_inferior_states): Remove.
1903         (get_displaced_stepping_state): Adust.
1904         (displaced_step_in_progress_any_inferior): Adjust.
1905         (displaced_step_in_progress_thread): Adjust.
1906         (displaced_step_in_progress): Adjust.
1907         (add_displaced_stepping_state): Remove.
1908         (get_displaced_step_closure_by_addr): Adjust.
1909         (remove_displaced_stepping_state): Remove.
1910         (infrun_inferior_exit): Call displaced_step_state.reset.
1911         (use_displaced_stepping): Don't check for NULL.
1912         (displaced_step_prepare_throw): Call
1913         get_displaced_stepping_state.
1914         (displaced_step_fixup): Don't check for NULL.
1915         (prepare_for_detach): Don't check for NULL.
1916
1917 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1918
1919         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1920          in case of call that did not complete.
1921
1922 2019-01-02  Andrey Utkin  <autkin@undo.io>
1923
1924         * symfile.c (find_separate_debug_file): Fix search of debug files for
1925         remote debuggee.
1926
1927 2019-01-02  Tom Tromey  <tom@tromey.com>
1928
1929         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1930         indentation.
1931         * python/py-frame.c (frapy_older): Remove cast.
1932         (frapy_newer): Likewise.
1933         * python/py-breakpoint.c (local_setattro): Remove cast.
1934         * python/py-arch.c (archpy_name): Remove local variable.
1935         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1936
1937 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1938
1939         * unittests/basic_string_view/element_access/char/empty.cc:
1940         Fix year range in copyright header.
1941
1942 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1943
1944         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1945         Delete.
1946         <operator==>: Update with for removed field.
1947         <hash>: Likewise.
1948         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1949         <isa_features>: ...this.
1950         <abi_features>: New field.
1951         (riscv_isa_flen): Update comment.
1952         (riscv_abi_xlen): New declaration.
1953         (riscv_abi_flen): New declaration.
1954         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1955         isa_features.
1956         (riscv_abi_xlen): New function.
1957         (riscv_isa_flen): Update to get answer from isa_features.
1958         (riscv_abi_flen): New function.
1959         (riscv_has_fp_abi): Update to get answer from abi_features.
1960         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1961         xlen and flen.
1962         (riscv_call_info) <xlen, flen>: Update comment.
1963         (riscv_call_arg_struct): Remove invalid assertions
1964         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1965         is removed.
1966         (riscv_gdbarch_init): Gather isa features and abi features
1967         separately, ensure both match on the gdbarch when reusing an old
1968         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1969         a target with 64-bit float hardware.
1970
1971 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1972
1973         * source.c (search_command_helper): Stop reverse search
1974         when line 1 has been searched.
1975
1976 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1977
1978         * record-full.c (record_full_base_target::close): Rewrite
1979         record_full_core_buf_list free logic.
1980
1981 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1982
1983         * break-catch-syscall.c (print_one_catch_syscall): xfree
1984         the last text.
1985
1986 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1987
1988         * top.c (print_gdb_version): Update Copyright year in version
1989         message.
1990
1991 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1992
1993         Update copyright year range in all GDB files.
1994
1995 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1996
1997         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1998
1999 For older changes see ChangeLog-2018.
2000 \f
2001 Local Variables:
2002 mode: change-log
2003 left-margin: 8
2004 fill-column: 74
2005 version-control: never
2006 coding: utf-8
2007 End:
2008