gdb/ChangeLog

   1 2019-05-04  Tom Tromey  <tom@tromey.com>
   2
   3         * psymtab.c (psymbol_name_matches, match_partial_symbol)
   4         (lookup_partial_symbol, print_partial_symbols)
   5         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
   6         (psymbol_compare): Update.
   7         (add_psymbol_to_bcache): Clear the entire psymbol.
   8         (maintenance_check_psymtabs): Update.
   9         * psympriv.h (struct partial_symbol): Don't derive from
  10         general_symbol_info.
  11         <obj_section, unrelocated_address, address,
  12         set_unrelocated_address>: Update.
  13         <ginfo>: New member.
  14         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  15         (debug_names::write_psymbols): Update.
  16
  17 2019-05-04  Tom de Vries  <tdevries@suse.de>
  18
  19         * contrib/cc-with-tweaks.sh: Support -n arg.
  20
  21 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  22
  23         * corelow.c (core_target::detach): Ensure frame cache and
  24         register caches are cleared.
  25         inferior.c (exit_inferior_1): Likewise.
  26
  27 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  28             Tom Tromey  <tom@tromey.com>
  29
  30         * dictionary.c (collate_pending_symbols_by_language): Remove
  31         "struct" from foreach.
  32         * symtab.c (lookup_global_symbol_from_objfile)
  33         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  34         foreach.
  35         * ser-tcp.c (net_open): Remove "struct" from foreach.
  36         * objfiles.c (objfile_relocate, objfile_rebase)
  37         (objfile_has_symbols): Remove "struct" from foreach.
  38         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  39         from foreach.
  40         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  41         foreach.
  42         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  43         "struct" from foreach.
  44         * ada-lang.c (create_excep_cond_exprs)
  45         (ada_exception_catchpoint_cond_string): Remove "struct" from
  46         foreach.
  47
  48 2019-05-03  Tom Tromey  <tromey@adacore.com>
  49
  50         * ada-exp.y (convert_char_literal): Check suffix of each
  51         enumerator.
  52
  53 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
  54
  55         PR ada/21406:
  56         * ada-exp.y (yywrap): Don't define.
  57         * ada-lex.l (%option): Add noyywrap
  58         (yywrap): Remove.
  59
  60 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  61
  62         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  63         _WIN32_WINNT to the XP level, unless already defined to a higher
  64         level.
  65
  66         * unittests/parse-connection-spec-selftests.c:
  67         * ser-tcp.c:
  68         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  69         override.
  70
  71         * symfile.c (find_separate_debug_file): Remove colon from the
  72         drive spec of DOS/Windows file names of the target, so that the
  73         file name produced from DEBUGDIR and the target's directory will
  74         be valid on DOS/Windows systems.
  75
  76 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  77
  78         * rust-lang.c (val_print_struct): Handle printing structures
  79         containing strings.
  80
  81 2019-05-02  Tom Tromey  <tromey@adacore.com>
  82
  83         * valarith.c (_initialize_valarith): Remove.
  84
  85 2019-05-01  Tom Tromey  <tromey@adacore.com>
  86
  87         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  88         bitfields.
  89
  90 2019-05-01  Tom Tromey  <tromey@adacore.com>
  91
  92         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  93         for big-endian copies.
  94
  95 2019-04-30  Ali Tamur  <tamur@google.com>
  96         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  97         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  98         (read_3_bytes): New function.
  99
 100 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 101
 102         * windows-nat.c (main_thread_id): Delete.
 103         (handle_output_debug_string): Replace main_thread_id by
 104         current_event.dwThreadId.
 105         (fake_create_process): Likewise.
 106         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 107         Do not set main_thread_id.
 108         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 109         current_event.dwThreadId.
 110         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 111
 112 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 113
 114         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 115         Use current_event.dwThreadId instead of main_thread_id.
 116
 117 2019-04-30  Tom Tromey  <tromey@adacore.com>
 118
 119         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 120         (create_excep_cond_exprs): Iterate over program spaces.
 121         (ada_exception_catchpoint_cond_string): Examine all minimal
 122         symbols for exception types.
 123
 124 2019-04-30  Tom Tromey  <tromey@adacore.com>
 125
 126         PR c++/24470:
 127         * dwarf2read.c (process_structure_scope): Handle case where type
 128         has template parameters but no symbol was created.
 129
 130 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 131             Chris January  <chris.january@arm.com>
 132
 133         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 134         qualifier.
 135         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 136
 137 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 138
 139         * f-typeprint.c (f_print_type): Update rules for printing
 140         whitespace.
 141         (f_type_print_varspec_suffix): Likewise.
 142
 143 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 144             Chris January  <chris.january@arm.com>
 145
 146         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 147         function arguments.
 148
 149 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         * f-lang.c (build_fortran_types): Change name of void type to
 152         lower case.
 153         * f-typeprint.c (f_type_print_base): Print the name of the void
 154         type, rather than a fixed string.
 155         * f-valprint.c (f_decorations): Use lower case void string.
 156
 157 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 158             Chris January  <chris.january@arm.com>
 159
 160         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 161         types for Fortran.
 162
 163 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 164             Chris January  <chris.january@arm.com>
 165             David Lecomber  <david.lecomber@arm.com>
 166
 167         * f-exp.y (BINOP_INTRINSIC): New token.
 168         (exp): New parser rule handling BINOP_INTRINSIC.
 169         (f77_keywords): Add new builtin procedures.
 170         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 171         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 172         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 173         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 174         (print_unop_subexp_f): New function.
 175         (print_binop_subexp_f): New function.
 176         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 177         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 178         (dump_subexp_body_f): Likewise.
 179         (operator_check_f): Likewise.
 180         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 181         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 182
 183 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 184
 185         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 186         UNOP_KIND.
 187         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 188         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 189         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 190         (operator_length_f): New fuction.
 191         (print_subexp_f): New function.
 192         (op_name_f): New function.
 193         (dump_subexp_body_f): New function.
 194         (operator_check_f): New function.
 195         (exp_descriptor_f): Replace standard expression handling functions
 196         with new functions.
 197         * gdb/fortran-operator.def: New file.
 198         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 199         * gdb/std-operator.def: Remove UNOP_KIND.
 200
 201 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 202
 203         * std-operator.def: Remove unbalanced, stray double quote
 204         character.
 205
 206 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 207             Chris January  <chris.january@arm.com>
 208             Daniel Everett  <daniel.everett@arm.com>
 209             Nick Forrington  <nick.forrington@arm.com>
 210             Richard Bunt  <richard.bunt@arm.com>
 211
 212         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 213         of depth when printing anonymous structs or unions.
 214         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 215         Don't print either the top-level value, or the children if the
 216         max-depth is exceeded.
 217         (ppscm_print_children): When printing the key of a map, allow one
 218         extra level of depth.
 219         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 220         print either the top-level value, or the children if the max-depth
 221         is exceeded.
 222         (print_children): When printing the key of a map, allow one extra
 223         level of depth.
 224         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 225         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 226         (user_print_options): Initialise max_depth field.
 227         (val_print_scalar_or_string_type_p): New function.
 228         (val_print): Check to see if the max depth has been reached.
 229         (val_print_check_max_depth): Define new function.
 230         (show_print_max_depth): New function.
 231         (_initialize_valprint): Add 'print max-depth' option.
 232         * valprint.h (struct value_print_options) <max_depth>: New field.
 233         (val_print_check_max_depth): Declare new function.
 234         * NEWS: Document new feature.
 235
 236 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * ada-lang.c (ada_language_defn): Initialise new field.
 239         * c-lang.c (c_is_string_type_p): New function.
 240         (c_language_defn): Initialise new field.
 241         (cplus_language_defn): Initialise new field.
 242         (asm_language_defn): Initialise new field.
 243         (minimal_language_defn): Initialise new field.
 244         * c-lang.h (c_is_string_type_p): Declare new function.
 245         * d-lang.c (d_language_defn): Initialise new field.
 246         * f-lang.c (f_is_string_type_p): New function.
 247         (f_language_defn): Initialise new field.
 248         * go-lang.c (go_is_string_type_p): New function.
 249         (go_language_defn): Initialise new field.
 250         * language.c (default_is_string_type_p): New function.
 251         (unknown_language_defn): Initialise new field.
 252         (auto_language_defn): Initialise new field.
 253         * language.h (struct language_defn) <la_is_string_type_p>: New
 254         member variable.
 255         (default_is_string_type_p): Declare new function.
 256         * m2-lang.c (m2_language_defn): Initialise new field.
 257         * objc-lang.c (objc_language_defn): Initialise new field.
 258         * opencl-lang.c (opencl_language_defn): Initialise new field.
 259         * p-lang.c (pascal_is_string_type_p): New function.
 260         (pascal_language_defn): Initialise new field.
 261         * rust-lang.c (rust_is_string_type_p): New function.
 262         (rust_language_defn): Initialise new field.
 263
 264 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 267         New field.
 268         * ada-lang.c (ada_language_defn): Initialise new field.
 269         * c-lang.c (c_language_defn): Likewise.
 270         (cplus_language_defn): Likewise.
 271         (asm_language_defn): Likewise.
 272         (minimal_language_defn): Likewise.
 273         * d-lang.c (d_language_defn): Likewise.
 274         * f-lang.c (f_language_defn): Likewise.
 275         * go-lang.c (go_language_defn): Likewise.
 276         * language.c (unknown_language_defn): Likewise.
 277         (auto_language_defn): Likewise.
 278         * m2-lang.c (m2_language_defn): Likewise.
 279         * objc-lang.c (objc_language_defn): Likewise.
 280         * opencl-lang.c (opencl_language_defn): Likewise.
 281         * p-lang.c (pascal_language_defn): Likewise.
 282         * rust-lang.c (rust_language_defn): Likewise.
 283
 284 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 285
 286         * ada-lang.c (ada_is_character_type): Change return type to bool.
 287         (ada_is_string_type): Likewise.
 288         * ada-lang.h (ada_is_character_type): Update declaration
 289         (ada_is_string_type): Likewise.
 290
 291 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 292
 293         Support style in 'frame|thread apply'
 294
 295         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 296         * record.c (record_start, record_stop): Update callers of
 297         execute_command_to_string with false.
 298         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 299         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 300         methods.
 301         (class string_file): New constructor with term_out parameter.
 302         Override methods term_out and can_emit_style_escape.  New member
 303         term_out.
 304         (class stdio_file): Override can_emit_style_escape.
 305         (class tee_file): Override term_out and can_emit_style_escape.
 306         * utils.h (can_emit_style_escape): Remove.
 307         * utils.c (can_emit_style_escape): Likewise.
 308         Update all callers of can_emit_style_escape (SOMESTREAM) to
 309         SOMESTREAM->can_emit_style_escape.
 310         * source-cache.c (source_cache::get_source_lines): Likewise.
 311         * stack.c (frame_apply_command_count): Call execute_command_to_string
 312         passing the term_out characteristic of the current gdb_stdout.
 313         * thread.c (thr_try_catch_cmd): Likewise.
 314         * top.c (execute_command_to_string): pass term_out parameter
 315         to construct the string_file for the command output.
 316         * ui-file.c (term_cli_styling): New function (most code moved
 317         from utils.c can_emit_style_escape).
 318         (string_file::string_file, string_file::can_emit_style_escape,
 319         stdio_file::can_emit_style_escape, tee_file::term_out,
 320         tee_file::can_emit_style_escape): New functions.
 321
 322 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 323
 324         * NEWS: Mention the new set|show may-call-functions.
 325         * infcall.c (may_call_functions_p): New variable.
 326         (show_may_call_functions_p): New function.
 327         (call_function_by_hand_dummy): Throws an error if not
 328         may-call-functions.
 329         (_initialize_infcall): Call add_setshow_boolean_cmd for
 330         may-call-functions.
 331
 332 2019-04-25  Keith Seitz  <keiths@redhat.com>
 333
 334         PR c++/24367
 335         * cp-support.c (inspect_type): Don't attempt substitutions
 336         of symbol with the same name.
 337
 338 2019-04-25  Tom Tromey  <tromey@adacore.com>
 339
 340         PR gdb/24475:
 341         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 342         static.
 343
 344 2019-04-25  Tom Tromey  <tromey@adacore.com>
 345
 346         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 347         rvalue reference.
 348         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 349         (gdb_xml_parser::parse): Use std::move.
 350         * python/python-internal.h (gdbpy_convert_exception): Take a const
 351         reference.
 352         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 353         std::move.
 354         * python/py-utils.c (gdbpy_convert_exception): Take a const
 355         reference.
 356         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 357         Use std::move.
 358         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 359         Use std::move.
 360         * mi/mi-main.c (mi_print_exception): Take a const reference.
 361         * main.c (handle_command_errors): Take a const reference.
 362         * linespec.c (parse_linespec): Use std::move.
 363         * infcall.c (run_inferior_call): Use std::move.
 364         (call_function_by_hand_dummy): Use std::move.
 365         * exec.c (try_open_exec_file): Use std::move.
 366         * exceptions.h (exception_print, exception_fprintf)
 367         (exception_print_same): Update.
 368         * exceptions.c (print_exception, exception_print)
 369         (exception_fprintf, exception_print_same): Change parameters to
 370         const reference.
 371         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 372         * common/new-op.c: Use std::move.
 373         * common/common-exceptions.h (struct gdb_exception): Add move
 374         constructor.
 375         (struct gdb_exception_error, struct gdb_exception_quit, struct
 376         gdb_quit_bad_alloc): Change constructor to move constructor.
 377         (throw_exception): Change parameter to rvalue reference.
 378         * common/common-exceptions.c (throw_exception): Take rvalue
 379         reference.
 380         * cli/cli-interp.c (safe_execute_command): Use std::move.
 381         * breakpoint.c (insert_bp_location, location_to_sals): Use
 382         std::move.
 383
 384 2019-04-25  Tom Tromey  <tromey@adacore.com>
 385
 386         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 387         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 388         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 389         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 390         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 391         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 392         guile/scm-value.c: Use unpack.
 393         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 394         gdbscm_gdb_exception.
 395         (gdbscm_throw_gdb_exception): Likewise.
 396         (struct gdbscm_gdb_exception): New.
 397         (unpack): New function.
 398         (gdbscm_wrap): Use unpack.
 399
 400 2019-04-25  Tom Tromey  <tromey@adacore.com>
 401
 402         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 403         (gdb_rl_callback_handler): Use std::move.
 404         * common/common-exceptions.h (struct gdb_exception): Add move
 405         assignment operator.
 406         (throw_exception_sjlj): Change "exception" to const reference.
 407         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 408         (throw_exception_sjlj): Change "exception" to const reference.
 409
 410 2019-04-25  Tom Tromey  <tromey@adacore.com>
 411
 412         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 413         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 414         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 415         Update.
 416         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 417         Update.
 418         * mi/mi-interp.c (mi_interp::exec): Update.
 419         * linespec.c (parse_linespec): Update.
 420         * infcall.c (run_inferior_call): Update.
 421         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 422         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 423         (gdbscm_lookup_global_symbol): Update.
 424         * guile/scm-param.c (gdbscm_parameter_value): Update.
 425         * guile/scm-frame.c (gdbscm_frame_read_register)
 426         (gdbscm_frame_read_var): Update.
 427         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 428         * exec.c (try_open_exec_file): Update.
 429         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 430         (gdb_rl_callback_handler): Update.
 431         * common/common-exceptions.h (exception_none): Don't declare.
 432         * common/common-exceptions.c (exception_none): Don't define.
 433         (struct catcher) <exception>: Update.
 434         * cli/cli-interp.c (safe_execute_command): Update.
 435         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 436
 437 2019-04-25  Ali Tamur  <tamur@google.com>
 438
 439         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 440         (read_attribute_value): Likewise.
 441         (dwarf2_read_addr_index): Update comment.
 442         (read_str_index): Add DW_FORM_strx.
 443         (dwarf2_string_attr): Likewise.
 444         (dwarf2_const_value_attr): Likewise.
 445         (dump_die_shallow): Likewise.
 446         (dwarf2_fetch_constant_bytes): Likewise.
 447         (skip_form_bytes): Likewise.
 448         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 449
 450 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 451
 452         PR corefiles/11608
 453         PR corefiles/18187
 454         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 455         OFFSET.  Verify if current mapping contains an ELF header.
 456         (linux_find_memory_regions_full): Adjust call to
 457         dump_mapping_p.
 458
 459 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 460             Kang Li <kanglictf@gmail.com>
 461
 462         PR gdb/21600
 463
 464         * dwarf2-frame.c (read_initial_length): Be consistent about using
 465         unsigned representation of length.
 466         (decode_frame_entry_1): Likewise.  Check for wraparound of
 467         end pointer as well as buffer overflow.
 468
 469 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 470
 471         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 472         "vq".
 473
 474 2019-04-24  Tom Tromey  <tromey@adacore.com>
 475
 476         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 477
 478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 479
 480         * s12z-tdep.c (s12z_unwind_pc): Delete.
 481         (s12z_unwind_sp): Delete.
 482         (s12z_gdbarch_init): Don't register deleted functions with
 483         gdbarch.
 484
 485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 486
 487         * rl78-tdep.c (rl78_unwind_sp): Delete.
 488         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 489
 490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 491
 492         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 493         (xstormy16_unwind_pc): Delete.
 494         (xstormy16_dummy_id): Delete.
 495         (xstormy16_gdbarch_init): Don't register deleted functions with
 496         gdbarch.
 497
 498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * vax-tdep.c (vax_unwind_pc): Delete.
 501         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 502
 503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * v850-tdep.c (v850_unwind_sp): Delete.
 506         (v850_unwind_pc): Delete.
 507         (v850_dummy_id): Delete.
 508         (v850_gdbarch_init): Don't register deleted functions with
 509         gdbarch.
 510
 511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 514         (tilegx_unwind_pc): Delete.
 515         (tilegx_unwind_dummy_id): Delete.
 516         (tilegx_gdbarch_init): Don't register deleted functions with
 517         gdbarch.
 518
 519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 522         (tic6x_dummy_id): Delete.
 523         (tic6x_gdbarch_init): Don't register deleted functions with
 524         gdbarch.
 525
 526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * sparc-tdep.c (sparc_unwind_pc): Delete.
 529         (sparc32_gdbarch_init): Don't register deleted function with
 530         gdbarch.
 531
 532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * sh-tdep.c (sh_unwind_sp): Delete.
 535         (sh_unwind_pc): Delete.
 536         (sh_dummy_id): Delete.
 537         (sh_gdbarch_init): Don't register deleted functions with
 538         gdbarch.
 539
 540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 541
 542         * score-tdep.c (score_unwind_sp): Delete.
 543         (score_unwind_pc): Delete.
 544         (score_dummy_id): Delete.
 545         (score_gdbarch_init): Don't register deleted functions with
 546         gdbarch.
 547
 548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * rx-tdep.c (rx_unwind_pc): Delete.
 551         (rx_unwind_sp): Delete.
 552         (rx_dummy_id): Delete.
 553         (rx_gdbarch_init): Don't register deleted functions with
 554         gdbarch.  Update comment.
 555
 556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 559         (rs6000_dummy_id): Delete.
 560         (rs6000_gdbarch_init): Don't register deleted functions with
 561         gdbarch.
 562
 563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * or1k-tdep.c (or1k_dummy_id): Delete.
 566         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 567
 568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * nios2-tdep.c (nios2_dummy_id): Delete.
 571         (nios2_unwind_sp): Delete.
 572         (nios2_gdbarch_init): Don't register deleted functions with
 573         gdbarch.
 574
 575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 576
 577         * nds32-tdep.c (nds32_dummy_id): Delete.
 578         (nds32_unwind_pc): Delete.
 579         (nds32_unwind_sp): Delete.
 580         (nds32_gdbarch_init): Don't register deleted functions with
 581         gdbarch.
 582
 583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 584
 585         * msp430-tdep.c (msp430_unwind_pc): Delete.
 586         (msp430_unwind_sp): Delete.
 587         (msp430_dummy_id): Delete.
 588         (msp430_gdbarch_init): Don't register deleted functions with
 589         gdbarch.
 590
 591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 592
 593         * moxie-tdep.c (moxie_unwind_sp): Delete.
 594         (moxie_unwind_pc): Delete.
 595         (moxie_dummy_id): Delete.
 596         (moxie_gdbarch_init): Don't register deleted functions with
 597         gdbarch.
 598
 599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 602         (mn10300_unwind_pc): Delete.
 603         (mn10300_unwind_sp): Delete.
 604         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 605         mn10300_unwind_sp.
 606         (mn10300_frame_unwind_init): Don't register deleted functions with
 607         gdbarch.
 608
 609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 610
 611         * mep-tdep.c (mep_unwind_pc): Delete.
 612         (mep_unwind_sp): Delete.
 613         (mep_dummy_id): Delete.
 614         (mep_gdbarch_init): Don't register deleted functions with
 615         gdbarch.
 616
 617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 618
 619         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 620         (m68hc11_unwind_sp): Delete.
 621         (m68hc11_gdbarch_init): Don't register deleted functions with
 622         gdbarch.
 623
 624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * m32r-tdep.c (m32r_unwind_sp): Delete.
 627         (m32r_unwind_pc): Delete.
 628         (m32r_dummy_id): Delete.
 629         (m32r_gdbarch_init): Don't register deleted functions with
 630         gdbarch.
 631
 632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         * m32c-tdep.c (m32c_unwind_pc): Delete.
 635         (m32c_unwind_sp): Delete.
 636         (m32c_dummy_id): Delete.
 637         (m32c_gdbarch_init): Don't register deleted functions with
 638         gdbarch.
 639
 640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 641
 642         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 643         (lm32_unwind_pc): Delete.
 644         (lm32_dummy_id): Delete.
 645         (lm32_gdbarch_init): Don't register deleted functions with
 646         gdbarch.
 647
 648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 649
 650         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 651         (iq2000_unwind_pc): Delete.
 652         (iq2000_dummy_id): Delete.
 653         (iq2000_gdbarch_init): Don't register deleted functions with
 654         gdbarch.
 655
 656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 657
 658         * nds32-tdep.c (nds32_type_align): Delete.
 659         (nds32_push_dummy_call): Use type_align instead.
 660
 661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 662
 663         * arm-tdep.c (arm_type_align): Only handle vector override case.
 664         (arm_push_dummy_call): Use type_align.
 665         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 666
 667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 670         case.
 671         (pass_on_stack): Use type_align.
 672         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 673         function.
 674
 675 2019-04-23  Tom Tromey  <tromey@adacore.com>
 676
 677         * dwarf2read.c (line_header::file_name_at): Remove unused
 678         overload.
 679
 680 2019-04-23  Tom de Vries  <tdevries@suse.de>
 681
 682         PR gdb/24438
 683         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 684         invocation.
 685
 686
 687 2019-03-27  Ali Tamur  <tamur@google.com>
 688
 689         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 690         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 691         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 692         (dwarf_expr_context::get_addr_index): Likewise
 693         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 694         (symbol_needs_eval_context::get_addr_index): Likewise
 695         (disassemble_dwarf_expression): Add DW_OP_addrx
 696         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 697         (read_cutu_die_from_dwo): Update comment
 698         (skip_one_die): Add DW_FORM_addrx
 699         (read_attribute_value): Likewise
 700         (var_decode_location): Add DW_OP_addrx
 701         (dwarf2_const_value_attr): Add DW_FORM_addrx
 702         (dump_die_shallow): Likewise
 703         (dwarf2_fetch_constant_bytes): Likewise
 704         (decode_locdesc): Add DW_OP_addrx
 705         (skip_form_bytes): Add DW_FORM_addrx
 706
 707 2019-04-22  Ali Tamur  <tamur@google.com>
 708
 709         * MAINTAINERS (Write After Approval): Add self.
 710
 711 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 712
 713         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 714         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 715         (open_symbol_file_object): Likewise.
 716         (svr4_default_sos): Add info parameter.
 717         (svr4_read_so_list): Likewise.
 718         (svr4_current_sos_direct): Adjust functions calls to pass down
 719         info.
 720         (svr4_current_sos_1): Add info parameter.
 721         (svr4_current_sos): Call get_svr4_info, pass info down to
 722         svr4_current_sos_1.
 723         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 724         get_svr4_info.
 725         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 726         get_svr4_info.
 727         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 728         to get_svr4_info.
 729         (probes_table_remove_objfile_probes): Likewise.
 730         (register_solib_event_probe): Add info parameter.
 731         (solist_update_incremental): Pass info parameter down to
 732         svr4_read_so_list.
 733         (disable_probes_interface): Add info parameter.
 734         (svr4_handle_solib_event): Pass current_program_space to
 735         get_svr4_info.  Adjust disable_probes_interface cleanup.
 736         (svr4_create_probe_breakpoints): Add info parameter, pass it
 737         down to register_solib_event_probe.
 738         (svr4_create_solib_event_breakpoints): Add info parameter,
 739         pass it down to svr4_create_probe_breakpoints.
 740         (enable_break): Pass info down to
 741         svr4_create_solib_event_breakpoints.
 742         (svr4_solib_create_inferior_hook): Pass current_program_space to
 743         get_svr4_info.
 744         (svr4_clear_solib): Likewise.
 745
 746 2019-04-22  Pedro Alves  <palves@redhat.com>
 747
 748         * solib-svr4.c (svr4_free_objfile_observer): New.
 749         (probe_and_action::objfile): New field.
 750         (probes_table_htab_remove_objfile_probes)
 751         (probes_table_remove_objfile_probes): New functions.
 752         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 753         in the new probe_and_action.  Don't store the probe in 'lookup'.
 754         (svr4_create_probe_breakpoints): Pass objfile to
 755         register_solib_event_probe.
 756         (_initialize_svr4_solib): Register a free_objfile observer.
 757
 758 2019-04-19  Tom Tromey  <tom@tromey.com>
 759
 760         * common/queue.h: Remove.
 761
 762 2019-04-19  Tom Tromey  <tom@tromey.com>
 763
 764         * event-loop.c: Don't include "common/queue.h".
 765
 766 2019-04-19  Tom Tromey  <tom@tromey.com>
 767
 768         * remote.c (remote_target): Use delete.
 769         * remote-notif.h: Include <list>, not "common/queue.h".
 770         (notif_client_p): Remove typedef.
 771         (remote_notif_state): Add constructor, destructor, initializer.
 772         <notif_queue>: Now a std::list.
 773         (remote_notif_state_xfree): Don't declare.
 774         * remote-notif.c (remote_notif_process, handle_notification)
 775         (remote_notif_state_allocate): Update.
 776         (~remote_notif_state): Rename from remote_notif_state_xfree.
 777
 778 2019-04-19  Tom Tromey  <tom@tromey.com>
 779
 780         * symfile.c (reread_symbols): Update.
 781         * objfiles.c (objfile_register_static_link)
 782         (objfile_lookup_static_link): Update
 783         (~objfile) Don't delete static_links.
 784         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 785
 786 2019-04-19  Tom Tromey  <tom@tromey.com>
 787
 788         * type-stack.h (struct type_stack) <insert>: Constify string.
 789         * type-stack.c (type_stack::insert): Constify string.
 790         * gdbtypes.h (lookup_template_type): Update.
 791         (address_space_name_to_int): Update.
 792         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 793         const.
 794         (lookup_template_type): Make name const.
 795         * c-exp.y: Update rules.
 796         (lex_one_token, classify_name, classify_inner_name)
 797         (c_print_token): Update.
 798         * p-exp.y: Update rules.
 799         (yylex): Update.
 800         * f-exp.y: Update rules.
 801         (yylex): Update.
 802         * d-exp.y: Update rules.
 803         (lex_one_token, classify_name, classify_inner_name): Update.
 804         * parse.c (write_dollar_variable, copy_name): Return std::string.
 805         * parser-defs.h (copy_name): Change return type.
 806         * m2-exp.y: Update rules.
 807         (yylex): Update.
 808         * go-exp.y (lex_one_token): Update.
 809         Update rules.
 810         (classify_unsafe_function, classify_packaged_name)
 811         (classify_name, yylex): Update.
 812
 813 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 814
 815         * configure.ac: add --enable-source-highlight switch.
 816         * configure: Regenerate.
 817         * top.c (print_gdb_version): plumb --enable-source-highlight
 818         status to "show configuration".
 819
 820 2019-04-19  Tom Tromey  <tromey@adacore.com>
 821
 822         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 823         Check ADA_TYPE_P.
 824         (empty_record, ada_template_to_fixed_record_type_1)
 825         (template_to_static_fixed_type)
 826         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 827         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 828         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 829         macros.
 830
 831 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 832
 833         PR symtab/24423:
 834         * source.c (print_source_lines_base): Advance "iter" when a
 835         control character is seen.
 836
 837 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 838
 839         * inferior.h (struct infcall_suspend_state_deleter):
 840         Catch exception in destructor to avoid crash.
 841
 842 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 843
 844         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 845         close to the add_com "shell".
 846
 847 2019-04-18  Tom Tromey  <tromey@adacore.com>
 848
 849         * process-stratum-target.h (class process_stratum_target)
 850         <stratum>: Add "final".
 851
 852 2019-04-17  Tom Tromey  <tromey@adacore.com>
 853
 854         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 855         against nullptr before use.
 856
 857 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 858
 859         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 860
 861 2019-04-17  Jim Wilson  <jimw@sifive.com>
 862             Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 865         code read might fail, assume 4-byte breakpoint in that case.
 866
 867 2019-04-15  Leszek Swirski  <leszeks@google.com>
 868
 869         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 870         rather than a hand-rolled POD check when checking for forced MEMORY
 871         classification.
 872
 873 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 874
 875         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 876         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 877         function.
 878         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 879         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 880         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 881         declaration.
 882
 883 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 884
 885         * aarch64-linux-nat.c
 886         (aarch64_linux_nat_target::thread_architecture): Add override.
 887         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 888         each VQ.
 889
 890 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 891
 892         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 893
 894 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 897         target types of size 96-bits, add some additional comments, and
 898         check that the builtin type we found was the correct size.
 899
 900 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 901
 902         * utils.c (prompt_for_continue): Don't restore the styling at the
 903         end, as applied_style has the wrong value.  This fixes styling in
 904         long lists of file names that are interrupted by the "Continue?"
 905         prompt.
 906
 907 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 910         * c-lang.c (c_language_defn): Likewise.
 911         (cplus_language_defn): Likewise.
 912         (asm_language_defn): Likewise.
 913         (minimal_language_defn): Likewise.
 914         * d-lang.c (d_language_defn): Likewise.
 915         * f-lang.c (f_language_defn): Likewise.
 916         * go-lang.c (go_language_defn): Likewise.
 917         * language.c (unknown_language_defn): Likewise.
 918         (auto_language_defn): Likewise.
 919         * language.h (struct language_defn): Remove la_magic field.
 920         (LANG_MAGIC): Delete.
 921         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 922         * objc-lang.c (objc_language_defn): Likewise.
 923         * opencl-lang.c (opencl_language_defn): Likewise.
 924         * p-lang.c (pascal_language_defn): Likewise.
 925         * rust-lang.c (rust_language_defn): Likewise.
 926
 927 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * riscv-tdep.c (riscv_type_align): New function.
 930         (riscv_type_alignment): Delete.
 931         (riscv_arg_location): Use 'type_align'.
 932         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 933
 934 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * gdbtypes.c (type_align): A struct with no non-static fields also
 937         has alignment of 1.
 938
 939 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 942         component to 0.
 943         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 944         member.
 945         (riscv_struct_info::analyse): New implementation using new
 946         analyse_inner member function.
 947         (riscv_struct_info::field_offset): New member function.
 948         (riscv_struct_info::m_offsets): New member variable.
 949         (riscv_struct_info::analyse_inner): New private member function,
 950         takes the old implementation of riscv_struct_info::analyse but
 951         extended to track field offsets.
 952         (riscv_call_arg_struct): Update the struct folding special cases
 953         to handle cases where empty C++ structs, which are non-zero
 954         length, are found.
 955         (riscv_arg_location): Initialise the length of each location, a
 956         non-zero length now indicates the location is in use.
 957         (riscv_push_dummy_call): Allow for the first location having a
 958         non-zero offset when setting up arguments.
 959         (riscv_return_value): Likewise, but for return values.
 960
 961 2019-04-11  Tom Tromey  <tromey@adacore.com>
 962
 963         * utils.c (internal_vproblem): Make "msg" const.
 964
 965 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 966
 967         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 968         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 969         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 970         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 971
 972 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 973
 974         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 975         function.
 976         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 977         of amd64_collect_native_gregset.
 978         (amd64_linux_nat_target::store_registers): Likewise.
 979
 980 2019-04-10  Tom Tromey  <tom@tromey.com>
 981
 982         * symtab.c (lookup_global_symbol_from_objfile)
 983         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 984         * objfiles.h (class separate_debug_iterator): New.
 985         (class separate_debug_range): New.
 986         (struct objfile) <separate_debug_objfiles>: New method.
 987         (objfile_separate_debug_iterate): Don't declare.
 988         * objfiles.c (separate_debug_iterator::operator++): Rename from
 989         objfile_separate_debug_iterate.
 990         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 991         iterator.
 992         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 993         iterator.
 994
 995 2019-04-10  Tom Tromey  <tom@tromey.com>
 996
 997         * symfile.c (reread_symbols): Remove old comment.
 998         * objfiles.c (free_all_objfiles): Fix a typo.
 999
1000 2019-04-10  Tom Tromey  <tom@tromey.com>
1001
1002         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1003         * minsyms.c (lookup_minimal_symbol): Use foreach.
1004         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1005         (lookup_minimal_symbol_solib_trampoline): Likewise.
1006         * symfile.c (reread_symbols): Use foreach.
1007
1008 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1009             Tom Tromey  <tromey@adacore.com>
1010
1011         PR rust/24414:
1012         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1013         (rust_lex_int_test): Change "value" to be LONGEST.
1014         (rust_lex_tests): Add test for long integer literal.
1015
1016 2019-04-09  Tom Tromey  <tromey@adacore.com>
1017
1018         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1019         to bool.
1020         (extended_remote_target::attach): Update.
1021         (remote_target::remote_notice_new_inferior): Update.
1022         (remote_target::add_current_inferior_and_thread): Update.
1023         * inferior.c (exit_inferior_1): Use "false".
1024         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1025
1026 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1027
1028         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1029         the "start" command.
1030
1031 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1032
1033         * python/py-inferior.c (infpy_thread_from_thread_handle):
1034         Adjust comments to reflect renaming of thread_from_thread_handle
1035         to thread_from_handle.  Adjust keywords.  Fix type error message.
1036         (inferior_object_methods): Add thread_from_handle.  Retain
1037         thread_from_thread_handle, but mark it as deprecated.
1038
1039 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1040
1041         * gdbthread.h (find_thread_by_handle): Revise declaration.
1042         * thread.c (find_thread_by_handle): Likewise.  Adjust
1043         implementation too.
1044         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1045         support for buffer objects as handles.
1046
1047 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1048
1049         * python/py-infthread.c (thpy_thread_handle): New function.
1050         (thread_object_methods): Register thpy_thread_handle.
1051
1052 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1053
1054         * gdbthread.h (thread_to_thread_handle): Declare.
1055         * thread.c (gdbtypes.h): Include.
1056         (thread_to_thread_handle): New function.
1057
1058         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1059         (target_thread_info_to_thread_handle): Declare.
1060         * target.c (target_thread_info_to_thread_handle): New function.
1061         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1062         * target-delegates.c: Regenerate.
1063
1064         * linux-thread-db.c (class thread_db_target): Add method
1065         thread_info_to_thread_handle.
1066         (thread_db_target::thread_info_to_thread_handle): Define.
1067         * remote.c (class remote_target): Add new method
1068         thread_info_to_thread_handle.
1069         (remote_target::thread_info_to_thread_handle): Define.
1070
1071 2019-04-08  Pedro Alves  <palves@redhat.com>
1072
1073         * common/common-exceptions.c (throw_exception): Don't create
1074         named object to throw; throw directly.
1075         (throw_it): Likewise.  Don't initialize gdb_exception::message
1076         here, with new; pass FMT and AP to the ctor instead.
1077         * common/common-exceptions.h: Include <string>.
1078         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1079         const char *, va_list)): New ctor.  Use std::make_shared.
1080         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1081         errors)): Delete.
1082         (gdb_exception_error::gdb_exception_error(enum errors, const char
1083         *, va_list)): New.
1084         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1085         Add assertion.
1086         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1087         errors)): Delete.
1088         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1089         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1090         Add assertion.
1091
1092 2019-04-08  Tom Tromey  <tom@tromey.com>
1093
1094         * valops.c (value_rtti_indirect_type): Replace throw_exception
1095         with throw.
1096         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1097         with throw.
1098         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1099         throw.
1100         * target.c (target_translate_tls_address): Replace throw_exception
1101         with throw.
1102         * stack.c (frame_apply_command_count): Replace throw_exception
1103         with throw.
1104         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1105         throw.
1106         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1107         with throw.
1108         * rs6000-tdep.c (rs6000_frame_cache)
1109         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1110         * remote.c: Replace throw_exception with throw.
1111         * record-full.c (record_full_message, record_full_wait_1)
1112         (record_full_restore): Replace throw_exception with throw.
1113         * record-btrace.c:
1114         (get_thread_current_frame_id, record_btrace_start_replaying)
1115         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1116         (cmd_record_btrace_start): Replace throw_exception with throw.
1117         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1118         throw.
1119         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1120         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1121         * linespec.c:
1122         (find_linespec_symbols): Replace throw_exception with throw.
1123         * infrun.c (displaced_step_prepare, resume): Replace
1124         throw_exception with throw.
1125         * infcmd.c (post_create_inferior): Replace throw_exception with
1126         throw.
1127         * inf-loop.c (inferior_event_handler): Replace throw_exception
1128         with throw.
1129         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1130         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1131         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1132         (get_prev_frame_always, get_frame_pc_if_available)
1133         (get_frame_address_in_block_if_available, get_frame_language):
1134         Replace throw_exception with throw.
1135         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1136         throw_exception with throw.
1137         * eval.c (fetch_subexp_value, evaluate_var_value)
1138         (evaluate_funcall, evaluate_subexp_standard): Replace
1139         throw_exception with throw.
1140         * dwarf2loc.c (call_site_find_chain)
1141         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1142         Replace throw_exception with throw.
1143         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1144         with throw.
1145         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1146         throw.
1147         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1148         * completer.c (complete_line_internal): Replace throw_exception
1149         with throw.
1150         * compile/compile-object-run.c (compile_object_run): Replace
1151         throw_exception with throw.
1152         * cli/cli-script.c (process_next_line): Replace throw_exception
1153         with throw.
1154         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1155         (btrace_enable, btrace_maint_update_pt_packets): Replace
1156         throw_exception with throw.
1157         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1158         throw_exception with throw.
1159         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1160         throw_exception with throw.
1161         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1162         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1163         * aarch64-tdep.c (aarch64_make_prologue_cache)
1164         (aarch64_make_stub_cache): Replace throw_exception with throw.
1165
1166 2019-04-08  Tom Tromey  <tom@tromey.com>
1167
1168         * common/common-exceptions.c (throw_exception): Rename from
1169         throw_exception_cxx.  Remove old copy.  Make argument const.
1170         (throw_it): Create and throw exception objects directly.
1171         * common/common-exceptions.h (throw_exception): Make argument
1172         const.
1173         (struct gdb_exception_error): Add constructor.
1174         (struct gdb_exception_quit): Add constructor.
1175
1176 2019-04-08  Tom Tromey  <tom@tromey.com>
1177
1178         * common/common-exceptions.h (exception_rethrow): Don't declare.
1179         (TRY_SJLJ): Update comment.
1180         (TRY, CATCH, END_CATCH): Remove.
1181         * common/common-exceptions.c (exception_rethrow): Remove.
1182
1183 2019-04-08  Tom Tromey  <tom@tromey.com>
1184
1185         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1186         Remove.
1187         (gdb_exception_error): Rename from
1188         gdb_exception_RETURN_MASK_ERROR.
1189         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1190         (gdb_quit_bad_alloc): Update.
1191         * aarch64-tdep.c: Update.
1192         * ada-lang.c: Update.
1193         * ada-typeprint.c: Update.
1194         * ada-valprint.c: Update.
1195         * amd64-tdep.c: Update.
1196         * arch-utils.c: Update.
1197         * break-catch-throw.c: Update.
1198         * breakpoint.c: Update.
1199         * btrace.c: Update.
1200         * c-varobj.c: Update.
1201         * cli/cli-cmds.c: Update.
1202         * cli/cli-interp.c: Update.
1203         * cli/cli-script.c: Update.
1204         * common/common-exceptions.c: Update.
1205         * common/new-op.c: Update.
1206         * common/selftest.c: Update.
1207         * compile/compile-c-symbols.c: Update.
1208         * compile/compile-cplus-symbols.c: Update.
1209         * compile/compile-object-load.c: Update.
1210         * compile/compile-object-run.c: Update.
1211         * completer.c: Update.
1212         * corelow.c: Update.
1213         * cp-abi.c: Update.
1214         * cp-support.c: Update.
1215         * cp-valprint.c: Update.
1216         * darwin-nat.c: Update.
1217         * disasm-selftests.c: Update.
1218         * dtrace-probe.c: Update.
1219         * dwarf-index-cache.c: Update.
1220         * dwarf-index-write.c: Update.
1221         * dwarf2-frame-tailcall.c: Update.
1222         * dwarf2-frame.c: Update.
1223         * dwarf2loc.c: Update.
1224         * dwarf2read.c: Update.
1225         * eval.c: Update.
1226         * event-loop.c: Update.
1227         * event-top.c: Update.
1228         * exec.c: Update.
1229         * f-valprint.c: Update.
1230         * fbsd-tdep.c: Update.
1231         * frame-unwind.c: Update.
1232         * frame.c: Update.
1233         * gdbtypes.c: Update.
1234         * gnu-v3-abi.c: Update.
1235         * guile/guile-internal.h: Update.
1236         * guile/scm-block.c: Update.
1237         * guile/scm-breakpoint.c: Update.
1238         * guile/scm-cmd.c: Update.
1239         * guile/scm-disasm.c: Update.
1240         * guile/scm-frame.c: Update.
1241         * guile/scm-lazy-string.c: Update.
1242         * guile/scm-math.c: Update.
1243         * guile/scm-param.c: Update.
1244         * guile/scm-ports.c: Update.
1245         * guile/scm-pretty-print.c: Update.
1246         * guile/scm-symbol.c: Update.
1247         * guile/scm-symtab.c: Update.
1248         * guile/scm-type.c: Update.
1249         * guile/scm-value.c: Update.
1250         * i386-linux-tdep.c: Update.
1251         * i386-tdep.c: Update.
1252         * inf-loop.c: Update.
1253         * infcall.c: Update.
1254         * infcmd.c: Update.
1255         * infrun.c: Update.
1256         * jit.c: Update.
1257         * language.c: Update.
1258         * linespec.c: Update.
1259         * linux-fork.c: Update.
1260         * linux-nat.c: Update.
1261         * linux-tdep.c: Update.
1262         * linux-thread-db.c: Update.
1263         * main.c: Update.
1264         * mi/mi-cmd-break.c: Update.
1265         * mi/mi-cmd-stack.c: Update.
1266         * mi/mi-interp.c: Update.
1267         * mi/mi-main.c: Update.
1268         * objc-lang.c: Update.
1269         * p-valprint.c: Update.
1270         * parse.c: Update.
1271         * ppc-linux-tdep.c: Update.
1272         * printcmd.c: Update.
1273         * python/py-arch.c: Update.
1274         * python/py-breakpoint.c: Update.
1275         * python/py-cmd.c: Update.
1276         * python/py-finishbreakpoint.c: Update.
1277         * python/py-frame.c: Update.
1278         * python/py-framefilter.c: Update.
1279         * python/py-gdb-readline.c: Update.
1280         * python/py-inferior.c: Update.
1281         * python/py-infthread.c: Update.
1282         * python/py-lazy-string.c: Update.
1283         * python/py-linetable.c: Update.
1284         * python/py-objfile.c: Update.
1285         * python/py-param.c: Update.
1286         * python/py-prettyprint.c: Update.
1287         * python/py-progspace.c: Update.
1288         * python/py-record-btrace.c: Update.
1289         * python/py-record.c: Update.
1290         * python/py-symbol.c: Update.
1291         * python/py-type.c: Update.
1292         * python/py-unwind.c: Update.
1293         * python/py-utils.c: Update.
1294         * python/py-value.c: Update.
1295         * python/python.c: Update.
1296         * record-btrace.c: Update.
1297         * record-full.c: Update.
1298         * remote-fileio.c: Update.
1299         * remote.c: Update.
1300         * riscv-tdep.c: Update.
1301         * rs6000-aix-tdep.c: Update.
1302         * rs6000-tdep.c: Update.
1303         * rust-exp.y: Update.
1304         * rust-lang.c: Update.
1305         * s390-tdep.c: Update.
1306         * selftest-arch.c: Update.
1307         * solib-dsbt.c: Update.
1308         * solib-frv.c: Update.
1309         * solib-spu.c: Update.
1310         * solib-svr4.c: Update.
1311         * solib.c: Update.
1312         * sparc64-linux-tdep.c: Update.
1313         * stack.c: Update.
1314         * symfile-mem.c: Update.
1315         * symmisc.c: Update.
1316         * target.c: Update.
1317         * thread.c: Update.
1318         * top.c: Update.
1319         * tracefile-tfile.c: Update.
1320         * tui/tui.c: Update.
1321         * typeprint.c: Update.
1322         * unittests/cli-utils-selftests.c: Update.
1323         * unittests/parse-connection-spec-selftests.c: Update.
1324         * valops.c: Update.
1325         * valprint.c: Update.
1326         * value.c: Update.
1327         * varobj.c: Update.
1328         * windows-nat.c: Update.
1329         * x86-linux-nat.c: Update.
1330         * xml-support.c: Update.
1331
1332 2019-04-08  Tom Tromey  <tom@tromey.com>
1333
1334         * xml-support.c: Use C++ exception handling.
1335         * x86-linux-nat.c: Use C++ exception handling.
1336         * windows-nat.c: Use C++ exception handling.
1337         * varobj.c: Use C++ exception handling.
1338         * value.c: Use C++ exception handling.
1339         * valprint.c: Use C++ exception handling.
1340         * valops.c: Use C++ exception handling.
1341         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1342         handling.
1343         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1344         * typeprint.c: Use C++ exception handling.
1345         * tui/tui.c: Use C++ exception handling.
1346         * tracefile-tfile.c: Use C++ exception handling.
1347         * top.c: Use C++ exception handling.
1348         * thread.c: Use C++ exception handling.
1349         * target.c: Use C++ exception handling.
1350         * symmisc.c: Use C++ exception handling.
1351         * symfile-mem.c: Use C++ exception handling.
1352         * stack.c: Use C++ exception handling.
1353         * sparc64-linux-tdep.c: Use C++ exception handling.
1354         * solib.c: Use C++ exception handling.
1355         * solib-svr4.c: Use C++ exception handling.
1356         * solib-spu.c: Use C++ exception handling.
1357         * solib-frv.c: Use C++ exception handling.
1358         * solib-dsbt.c: Use C++ exception handling.
1359         * selftest-arch.c: Use C++ exception handling.
1360         * s390-tdep.c: Use C++ exception handling.
1361         * rust-lang.c: Use C++ exception handling.
1362         * rust-exp.y: Use C++ exception handling.
1363         * rs6000-tdep.c: Use C++ exception handling.
1364         * rs6000-aix-tdep.c: Use C++ exception handling.
1365         * riscv-tdep.c: Use C++ exception handling.
1366         * remote.c: Use C++ exception handling.
1367         * remote-fileio.c: Use C++ exception handling.
1368         * record-full.c: Use C++ exception handling.
1369         * record-btrace.c: Use C++ exception handling.
1370         * python/python.c: Use C++ exception handling.
1371         * python/py-value.c: Use C++ exception handling.
1372         * python/py-utils.c: Use C++ exception handling.
1373         * python/py-unwind.c: Use C++ exception handling.
1374         * python/py-type.c: Use C++ exception handling.
1375         * python/py-symbol.c: Use C++ exception handling.
1376         * python/py-record.c: Use C++ exception handling.
1377         * python/py-record-btrace.c: Use C++ exception handling.
1378         * python/py-progspace.c: Use C++ exception handling.
1379         * python/py-prettyprint.c: Use C++ exception handling.
1380         * python/py-param.c: Use C++ exception handling.
1381         * python/py-objfile.c: Use C++ exception handling.
1382         * python/py-linetable.c: Use C++ exception handling.
1383         * python/py-lazy-string.c: Use C++ exception handling.
1384         * python/py-infthread.c: Use C++ exception handling.
1385         * python/py-inferior.c: Use C++ exception handling.
1386         * python/py-gdb-readline.c: Use C++ exception handling.
1387         * python/py-framefilter.c: Use C++ exception handling.
1388         * python/py-frame.c: Use C++ exception handling.
1389         * python/py-finishbreakpoint.c: Use C++ exception handling.
1390         * python/py-cmd.c: Use C++ exception handling.
1391         * python/py-breakpoint.c: Use C++ exception handling.
1392         * python/py-arch.c: Use C++ exception handling.
1393         * printcmd.c: Use C++ exception handling.
1394         * ppc-linux-tdep.c: Use C++ exception handling.
1395         * parse.c: Use C++ exception handling.
1396         * p-valprint.c: Use C++ exception handling.
1397         * objc-lang.c: Use C++ exception handling.
1398         * mi/mi-main.c: Use C++ exception handling.
1399         * mi/mi-interp.c: Use C++ exception handling.
1400         * mi/mi-cmd-stack.c: Use C++ exception handling.
1401         * mi/mi-cmd-break.c: Use C++ exception handling.
1402         * main.c: Use C++ exception handling.
1403         * linux-thread-db.c: Use C++ exception handling.
1404         * linux-tdep.c: Use C++ exception handling.
1405         * linux-nat.c: Use C++ exception handling.
1406         * linux-fork.c: Use C++ exception handling.
1407         * linespec.c: Use C++ exception handling.
1408         * language.c: Use C++ exception handling.
1409         * jit.c: Use C++ exception handling.
1410         * infrun.c: Use C++ exception handling.
1411         * infcmd.c: Use C++ exception handling.
1412         * infcall.c: Use C++ exception handling.
1413         * inf-loop.c: Use C++ exception handling.
1414         * i386-tdep.c: Use C++ exception handling.
1415         * i386-linux-tdep.c: Use C++ exception handling.
1416         * guile/scm-value.c: Use C++ exception handling.
1417         * guile/scm-type.c: Use C++ exception handling.
1418         * guile/scm-symtab.c: Use C++ exception handling.
1419         * guile/scm-symbol.c: Use C++ exception handling.
1420         * guile/scm-pretty-print.c: Use C++ exception handling.
1421         * guile/scm-ports.c: Use C++ exception handling.
1422         * guile/scm-param.c: Use C++ exception handling.
1423         * guile/scm-math.c: Use C++ exception handling.
1424         * guile/scm-lazy-string.c: Use C++ exception handling.
1425         * guile/scm-frame.c: Use C++ exception handling.
1426         * guile/scm-disasm.c: Use C++ exception handling.
1427         * guile/scm-cmd.c: Use C++ exception handling.
1428         * guile/scm-breakpoint.c: Use C++ exception handling.
1429         * guile/scm-block.c: Use C++ exception handling.
1430         * guile/guile-internal.h: Use C++ exception handling.
1431         * gnu-v3-abi.c: Use C++ exception handling.
1432         * gdbtypes.c: Use C++ exception handling.
1433         * frame.c: Use C++ exception handling.
1434         * frame-unwind.c: Use C++ exception handling.
1435         * fbsd-tdep.c: Use C++ exception handling.
1436         * f-valprint.c: Use C++ exception handling.
1437         * exec.c: Use C++ exception handling.
1438         * event-top.c: Use C++ exception handling.
1439         * event-loop.c: Use C++ exception handling.
1440         * eval.c: Use C++ exception handling.
1441         * dwarf2read.c: Use C++ exception handling.
1442         * dwarf2loc.c: Use C++ exception handling.
1443         * dwarf2-frame.c: Use C++ exception handling.
1444         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1445         * dwarf-index-write.c: Use C++ exception handling.
1446         * dwarf-index-cache.c: Use C++ exception handling.
1447         * dtrace-probe.c: Use C++ exception handling.
1448         * disasm-selftests.c: Use C++ exception handling.
1449         * darwin-nat.c: Use C++ exception handling.
1450         * cp-valprint.c: Use C++ exception handling.
1451         * cp-support.c: Use C++ exception handling.
1452         * cp-abi.c: Use C++ exception handling.
1453         * corelow.c: Use C++ exception handling.
1454         * completer.c: Use C++ exception handling.
1455         * compile/compile-object-run.c: Use C++ exception handling.
1456         * compile/compile-object-load.c: Use C++ exception handling.
1457         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1458         * compile/compile-c-symbols.c: Use C++ exception handling.
1459         * common/selftest.c: Use C++ exception handling.
1460         * common/new-op.c: Use C++ exception handling.
1461         * cli/cli-script.c: Use C++ exception handling.
1462         * cli/cli-interp.c: Use C++ exception handling.
1463         * cli/cli-cmds.c: Use C++ exception handling.
1464         * c-varobj.c: Use C++ exception handling.
1465         * btrace.c: Use C++ exception handling.
1466         * breakpoint.c: Use C++ exception handling.
1467         * break-catch-throw.c: Use C++ exception handling.
1468         * arch-utils.c: Use C++ exception handling.
1469         * amd64-tdep.c: Use C++ exception handling.
1470         * ada-valprint.c: Use C++ exception handling.
1471         * ada-typeprint.c: Use C++ exception handling.
1472         * ada-lang.c: Use C++ exception handling.
1473         * aarch64-tdep.c: Use C++ exception handling.
1474
1475 2019-04-08  Tom Tromey  <tom@tromey.com>
1476
1477         * xml-support.c (gdb_xml_parser::parse): Update.
1478         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1479         * value.c (show_convenience): Update.
1480         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1481         (test_parse_flags_qcs): Update.
1482         * thread.c (thr_try_catch_cmd): Update.
1483         * target.c (target_translate_tls_address): Update.
1484         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1485         (info_frame_command_core, frame_apply_command_count): Update.
1486         * rust-exp.y (rust_lex_exception_test): Update.
1487         * riscv-tdep.c (riscv_print_one_register_info): Update.
1488         * remote.c (remote_target::enable_btrace): Update.
1489         * record-btrace.c (record_btrace_enable_warn): Update.
1490         * python/py-utils.c (gdbpy_convert_exception): Update.
1491         * printcmd.c (do_one_display, print_variable_and_value): Update.
1492         * mi/mi-main.c (mi_print_exception): Update.
1493         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1494         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1495         * linux-nat.c (linux_nat_target::attach): Update.
1496         * linux-fork.c (class scoped_switch_fork_info): Update.
1497         * infrun.c (displaced_step_prepare): Update.
1498         * infcall.c (call_function_by_hand_dummy): Update.
1499         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1500         * gnu-v3-abi.c (print_one_vtable): Update.
1501         * frame.c (get_prev_frame_always): Update.
1502         * f-valprint.c (info_common_command_for_block): Update.
1503         * exec.c (try_open_exec_file): Update.
1504         * exceptions.c (print_exception, exception_print)
1505         (exception_fprintf, exception_print_same): Update.
1506         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1507         * dwarf-index-cache.c (index_cache::store)
1508         (index_cache::lookup_gdb_index): Update.
1509         * darwin-nat.c (maybe_cache_shell): Update.
1510         * cp-valprint.c (cp_print_value_fields): Update.
1511         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1512         (gcc_cplus_symbol_address): Update.
1513         * compile/compile-c-symbols.c (gcc_convert_symbol)
1514         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1515         * common/selftest.c: Update.
1516         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1517         a std::string.
1518         (exception_try_scope_entry, exception_try_scope_exit): Don't
1519         declare.
1520         (struct exception_try_scope): Remove.
1521         (TRY): Don't use exception_try_scope.
1522         (struct gdb_exception): Add constructor, operator=.
1523         <what>: New method.
1524         (struct gdb_exception_RETURN_MASK_ALL)
1525         (struct gdb_exception_RETURN_MASK_ERROR)
1526         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1527         (struct gdb_quit_bad_alloc): Update.
1528         * common/common-exceptions.c (exception_none): Change
1529         initializer.
1530         (struct catcher) <state, exception>: Initialize inline.
1531         <prev>: Remove member.
1532         (current_catcher): Remove.
1533         (catchers): New global.
1534         (exceptions_state_mc_init): Simplify.
1535         (catcher_pop): Remove.
1536         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1537         (try_scope_depth, exception_try_scope_entry)
1538         (exception_try_scope_exit): Remove.
1539         (throw_exception_sjlj): Update.
1540         (exception_messages, exception_messages_size): Remove.
1541         (throw_it): Simplify.
1542         (gdb_exception_sliced_copy): Remove.
1543         (throw_exception_cxx): Update.
1544         * cli/cli-script.c (script_from_file): Update.
1545         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1546         Update.
1547         * ada-valprint.c (ada_val_print): Update.
1548         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1549         (create_excep_cond_exprs): Update.
1550
1551 2019-04-08  Tom Tromey  <tom@tromey.com>
1552
1553         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1554         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1555         (TRY, CATCH, END_CATCH): Remove some definitions.
1556         * common/common-exceptions.c: Don't use GDB_XCPT.
1557         (catcher_list_size): Remove.
1558         (throw_exception, throw_it): Simplify.
1559
1560 2019-04-05  Tom Tromey  <tom@tromey.com>
1561
1562         Revert the header-sorting patch.
1563         * ft32-tdep.c: Revert.
1564         * frv-tdep.c: Revert.
1565         * frv-linux-tdep.c: Revert.
1566         * frame.c: Revert.
1567         * frame-unwind.c: Revert.
1568         * frame-base.c: Revert.
1569         * fork-child.c: Revert.
1570         * findvar.c: Revert.
1571         * findcmd.c: Revert.
1572         * filesystem.c: Revert.
1573         * filename-seen-cache.h: Revert.
1574         * filename-seen-cache.c: Revert.
1575         * fbsd-tdep.c: Revert.
1576         * fbsd-nat.h: Revert.
1577         * fbsd-nat.c: Revert.
1578         * f-valprint.c: Revert.
1579         * f-typeprint.c: Revert.
1580         * f-lang.c: Revert.
1581         * extension.h: Revert.
1582         * extension.c: Revert.
1583         * extension-priv.h: Revert.
1584         * expprint.c: Revert.
1585         * exec.h: Revert.
1586         * exec.c: Revert.
1587         * exceptions.c: Revert.
1588         * event-top.c: Revert.
1589         * event-loop.c: Revert.
1590         * eval.c: Revert.
1591         * elfread.c: Revert.
1592         * dwarf2read.h: Revert.
1593         * dwarf2read.c: Revert.
1594         * dwarf2loc.c: Revert.
1595         * dwarf2expr.h: Revert.
1596         * dwarf2expr.c: Revert.
1597         * dwarf2-frame.c: Revert.
1598         * dwarf2-frame-tailcall.c: Revert.
1599         * dwarf-index-write.h: Revert.
1600         * dwarf-index-write.c: Revert.
1601         * dwarf-index-common.c: Revert.
1602         * dwarf-index-cache.h: Revert.
1603         * dwarf-index-cache.c: Revert.
1604         * dummy-frame.c: Revert.
1605         * dtrace-probe.c: Revert.
1606         * disasm.h: Revert.
1607         * disasm.c: Revert.
1608         * disasm-selftests.c: Revert.
1609         * dictionary.c: Revert.
1610         * dicos-tdep.c: Revert.
1611         * demangle.c: Revert.
1612         * dcache.h: Revert.
1613         * dcache.c: Revert.
1614         * darwin-nat.h: Revert.
1615         * darwin-nat.c: Revert.
1616         * darwin-nat-info.c: Revert.
1617         * d-valprint.c: Revert.
1618         * d-namespace.c: Revert.
1619         * d-lang.c: Revert.
1620         * ctf.c: Revert.
1621         * csky-tdep.c: Revert.
1622         * csky-linux-tdep.c: Revert.
1623         * cris-tdep.c: Revert.
1624         * cris-linux-tdep.c: Revert.
1625         * cp-valprint.c: Revert.
1626         * cp-support.c: Revert.
1627         * cp-namespace.c: Revert.
1628         * cp-abi.c: Revert.
1629         * corelow.c: Revert.
1630         * corefile.c: Revert.
1631         * continuations.c: Revert.
1632         * completer.h: Revert.
1633         * completer.c: Revert.
1634         * complaints.c: Revert.
1635         * coffread.c: Revert.
1636         * coff-pe-read.c: Revert.
1637         * cli-out.h: Revert.
1638         * cli-out.c: Revert.
1639         * charset.c: Revert.
1640         * c-varobj.c: Revert.
1641         * c-valprint.c: Revert.
1642         * c-typeprint.c: Revert.
1643         * c-lang.c: Revert.
1644         * buildsym.c: Revert.
1645         * buildsym-legacy.c: Revert.
1646         * build-id.h: Revert.
1647         * build-id.c: Revert.
1648         * btrace.c: Revert.
1649         * bsd-uthread.c: Revert.
1650         * breakpoint.h: Revert.
1651         * breakpoint.c: Revert.
1652         * break-catch-throw.c: Revert.
1653         * break-catch-syscall.c: Revert.
1654         * break-catch-sig.c: Revert.
1655         * blockframe.c: Revert.
1656         * block.c: Revert.
1657         * bfin-tdep.c: Revert.
1658         * bfin-linux-tdep.c: Revert.
1659         * bfd-target.c: Revert.
1660         * bcache.c: Revert.
1661         * ax-general.c: Revert.
1662         * ax-gdb.h: Revert.
1663         * ax-gdb.c: Revert.
1664         * avr-tdep.c: Revert.
1665         * auxv.c: Revert.
1666         * auto-load.c: Revert.
1667         * arm-wince-tdep.c: Revert.
1668         * arm-tdep.c: Revert.
1669         * arm-symbian-tdep.c: Revert.
1670         * arm-pikeos-tdep.c: Revert.
1671         * arm-obsd-tdep.c: Revert.
1672         * arm-nbsd-tdep.c: Revert.
1673         * arm-nbsd-nat.c: Revert.
1674         * arm-linux-tdep.c: Revert.
1675         * arm-linux-nat.c: Revert.
1676         * arm-fbsd-tdep.c: Revert.
1677         * arm-fbsd-nat.c: Revert.
1678         * arm-bsd-tdep.c: Revert.
1679         * arch-utils.c: Revert.
1680         * arc-tdep.c: Revert.
1681         * arc-newlib-tdep.c: Revert.
1682         * annotate.h: Revert.
1683         * annotate.c: Revert.
1684         * amd64-windows-tdep.c: Revert.
1685         * amd64-windows-nat.c: Revert.
1686         * amd64-tdep.c: Revert.
1687         * amd64-sol2-tdep.c: Revert.
1688         * amd64-obsd-tdep.c: Revert.
1689         * amd64-obsd-nat.c: Revert.
1690         * amd64-nbsd-tdep.c: Revert.
1691         * amd64-nbsd-nat.c: Revert.
1692         * amd64-nat.c: Revert.
1693         * amd64-linux-tdep.c: Revert.
1694         * amd64-linux-nat.c: Revert.
1695         * amd64-fbsd-tdep.c: Revert.
1696         * amd64-fbsd-nat.c: Revert.
1697         * amd64-dicos-tdep.c: Revert.
1698         * amd64-darwin-tdep.c: Revert.
1699         * amd64-bsd-nat.c: Revert.
1700         * alpha-tdep.c: Revert.
1701         * alpha-obsd-tdep.c: Revert.
1702         * alpha-nbsd-tdep.c: Revert.
1703         * alpha-mdebug-tdep.c: Revert.
1704         * alpha-linux-tdep.c: Revert.
1705         * alpha-linux-nat.c: Revert.
1706         * alpha-bsd-tdep.c: Revert.
1707         * alpha-bsd-nat.c: Revert.
1708         * aix-thread.c: Revert.
1709         * agent.c: Revert.
1710         * addrmap.c: Revert.
1711         * ada-varobj.c: Revert.
1712         * ada-valprint.c: Revert.
1713         * ada-typeprint.c: Revert.
1714         * ada-tasks.c: Revert.
1715         * ada-lang.c: Revert.
1716         * aarch64-tdep.c: Revert.
1717         * aarch64-ravenscar-thread.c: Revert.
1718         * aarch64-newlib-tdep.c: Revert.
1719         * aarch64-linux-tdep.c: Revert.
1720         * aarch64-linux-nat.c: Revert.
1721         * aarch64-fbsd-tdep.c: Revert.
1722         * aarch64-fbsd-nat.c: Revert.
1723         * aarch32-linux-nat.c: Revert.
1724
1725 2019-04-05  Tom Tromey  <tom@tromey.com>
1726
1727         * ft32-tdep.c: Sort headers.
1728         * frv-tdep.c: Sort headers.
1729         * frv-linux-tdep.c: Sort headers.
1730         * frame.c: Sort headers.
1731         * frame-unwind.c: Sort headers.
1732         * frame-base.c: Sort headers.
1733         * fork-child.c: Sort headers.
1734         * findvar.c: Sort headers.
1735         * findcmd.c: Sort headers.
1736         * filesystem.c: Sort headers.
1737         * filename-seen-cache.h: Sort headers.
1738         * filename-seen-cache.c: Sort headers.
1739         * fbsd-tdep.c: Sort headers.
1740         * fbsd-nat.h: Sort headers.
1741         * fbsd-nat.c: Sort headers.
1742         * f-valprint.c: Sort headers.
1743         * f-typeprint.c: Sort headers.
1744         * f-lang.c: Sort headers.
1745         * extension.h: Sort headers.
1746         * extension.c: Sort headers.
1747         * extension-priv.h: Sort headers.
1748         * expprint.c: Sort headers.
1749         * exec.h: Sort headers.
1750         * exec.c: Sort headers.
1751         * exceptions.c: Sort headers.
1752         * event-top.c: Sort headers.
1753         * event-loop.c: Sort headers.
1754         * eval.c: Sort headers.
1755         * elfread.c: Sort headers.
1756         * dwarf2read.h: Sort headers.
1757         * dwarf2read.c: Sort headers.
1758         * dwarf2loc.c: Sort headers.
1759         * dwarf2expr.h: Sort headers.
1760         * dwarf2expr.c: Sort headers.
1761         * dwarf2-frame.c: Sort headers.
1762         * dwarf2-frame-tailcall.c: Sort headers.
1763         * dwarf-index-write.h: Sort headers.
1764         * dwarf-index-write.c: Sort headers.
1765         * dwarf-index-common.c: Sort headers.
1766         * dwarf-index-cache.h: Sort headers.
1767         * dwarf-index-cache.c: Sort headers.
1768         * dummy-frame.c: Sort headers.
1769         * dtrace-probe.c: Sort headers.
1770         * disasm.h: Sort headers.
1771         * disasm.c: Sort headers.
1772         * disasm-selftests.c: Sort headers.
1773         * dictionary.c: Sort headers.
1774         * dicos-tdep.c: Sort headers.
1775         * demangle.c: Sort headers.
1776         * dcache.h: Sort headers.
1777         * dcache.c: Sort headers.
1778         * darwin-nat.h: Sort headers.
1779         * darwin-nat.c: Sort headers.
1780         * darwin-nat-info.c: Sort headers.
1781         * d-valprint.c: Sort headers.
1782         * d-namespace.c: Sort headers.
1783         * d-lang.c: Sort headers.
1784         * ctf.c: Sort headers.
1785         * csky-tdep.c: Sort headers.
1786         * csky-linux-tdep.c: Sort headers.
1787         * cris-tdep.c: Sort headers.
1788         * cris-linux-tdep.c: Sort headers.
1789         * cp-valprint.c: Sort headers.
1790         * cp-support.c: Sort headers.
1791         * cp-namespace.c: Sort headers.
1792         * cp-abi.c: Sort headers.
1793         * corelow.c: Sort headers.
1794         * corefile.c: Sort headers.
1795         * continuations.c: Sort headers.
1796         * completer.h: Sort headers.
1797         * completer.c: Sort headers.
1798         * complaints.c: Sort headers.
1799         * coffread.c: Sort headers.
1800         * coff-pe-read.c: Sort headers.
1801         * cli-out.h: Sort headers.
1802         * cli-out.c: Sort headers.
1803         * charset.c: Sort headers.
1804         * c-varobj.c: Sort headers.
1805         * c-valprint.c: Sort headers.
1806         * c-typeprint.c: Sort headers.
1807         * c-lang.c: Sort headers.
1808         * buildsym.c: Sort headers.
1809         * buildsym-legacy.c: Sort headers.
1810         * build-id.h: Sort headers.
1811         * build-id.c: Sort headers.
1812         * btrace.c: Sort headers.
1813         * bsd-uthread.c: Sort headers.
1814         * breakpoint.h: Sort headers.
1815         * breakpoint.c: Sort headers.
1816         * break-catch-throw.c: Sort headers.
1817         * break-catch-syscall.c: Sort headers.
1818         * break-catch-sig.c: Sort headers.
1819         * blockframe.c: Sort headers.
1820         * block.c: Sort headers.
1821         * bfin-tdep.c: Sort headers.
1822         * bfin-linux-tdep.c: Sort headers.
1823         * bfd-target.c: Sort headers.
1824         * bcache.c: Sort headers.
1825         * ax-general.c: Sort headers.
1826         * ax-gdb.h: Sort headers.
1827         * ax-gdb.c: Sort headers.
1828         * avr-tdep.c: Sort headers.
1829         * auxv.c: Sort headers.
1830         * auto-load.c: Sort headers.
1831         * arm-wince-tdep.c: Sort headers.
1832         * arm-tdep.c: Sort headers.
1833         * arm-symbian-tdep.c: Sort headers.
1834         * arm-pikeos-tdep.c: Sort headers.
1835         * arm-obsd-tdep.c: Sort headers.
1836         * arm-nbsd-tdep.c: Sort headers.
1837         * arm-nbsd-nat.c: Sort headers.
1838         * arm-linux-tdep.c: Sort headers.
1839         * arm-linux-nat.c: Sort headers.
1840         * arm-fbsd-tdep.c: Sort headers.
1841         * arm-fbsd-nat.c: Sort headers.
1842         * arm-bsd-tdep.c: Sort headers.
1843         * arch-utils.c: Sort headers.
1844         * arc-tdep.c: Sort headers.
1845         * arc-newlib-tdep.c: Sort headers.
1846         * annotate.h: Sort headers.
1847         * annotate.c: Sort headers.
1848         * amd64-windows-tdep.c: Sort headers.
1849         * amd64-windows-nat.c: Sort headers.
1850         * amd64-tdep.c: Sort headers.
1851         * amd64-sol2-tdep.c: Sort headers.
1852         * amd64-obsd-tdep.c: Sort headers.
1853         * amd64-obsd-nat.c: Sort headers.
1854         * amd64-nbsd-tdep.c: Sort headers.
1855         * amd64-nbsd-nat.c: Sort headers.
1856         * amd64-nat.c: Sort headers.
1857         * amd64-linux-tdep.c: Sort headers.
1858         * amd64-linux-nat.c: Sort headers.
1859         * amd64-fbsd-tdep.c: Sort headers.
1860         * amd64-fbsd-nat.c: Sort headers.
1861         * amd64-dicos-tdep.c: Sort headers.
1862         * amd64-darwin-tdep.c: Sort headers.
1863         * amd64-bsd-nat.c: Sort headers.
1864         * alpha-tdep.c: Sort headers.
1865         * alpha-obsd-tdep.c: Sort headers.
1866         * alpha-nbsd-tdep.c: Sort headers.
1867         * alpha-mdebug-tdep.c: Sort headers.
1868         * alpha-linux-tdep.c: Sort headers.
1869         * alpha-linux-nat.c: Sort headers.
1870         * alpha-bsd-tdep.c: Sort headers.
1871         * alpha-bsd-nat.c: Sort headers.
1872         * aix-thread.c: Sort headers.
1873         * agent.c: Sort headers.
1874         * addrmap.c: Sort headers.
1875         * ada-varobj.c: Sort headers.
1876         * ada-valprint.c: Sort headers.
1877         * ada-typeprint.c: Sort headers.
1878         * ada-tasks.c: Sort headers.
1879         * ada-lang.c: Sort headers.
1880         * aarch64-tdep.c: Sort headers.
1881         * aarch64-ravenscar-thread.c: Sort headers.
1882         * aarch64-newlib-tdep.c: Sort headers.
1883         * aarch64-linux-tdep.c: Sort headers.
1884         * aarch64-linux-nat.c: Sort headers.
1885         * aarch64-fbsd-tdep.c: Sort headers.
1886         * aarch64-fbsd-nat.c: Sort headers.
1887         * aarch32-linux-nat.c: Sort headers.
1888
1889 2019-04-04  Tom Tromey  <tom@tromey.com>
1890
1891         * varobj.c (varobj_create): Update.
1892         * rust-exp.y (struct rust_parser) <update_innermost_block,
1893         lookup_symbol>: New methods.
1894         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1895         Rename.
1896         (rust_parser::rust_lookup_type)
1897         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1898         * printcmd.c (display_command, do_one_display): Update.
1899         * parser-defs.h (struct parser_state) <parser_state>: Add
1900         "tracker" parameter.
1901         (block_tracker): New member.
1902         (class innermost_block_tracker) <innermost_block_tracker>: Add
1903         "types" parameter.
1904         <reset>: Remove method.
1905         (innermost_block): Don't declare.
1906         (null_post_parser): Update.
1907         * parse.c (innermost_block): Remove global.
1908         (write_dollar_variable): Update.
1909         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1910         Remove "tracker_types" parameter.
1911         (parse_expression): Add "tracker" parameter.
1912         (parse_expression_for_completion): Update.
1913         (null_post_parser): Add "tracker" parameter.
1914         * p-exp.y: Update rules.
1915         * m2-exp.y: Update rules.
1916         * language.h (struct language_defn) <la_post_parser>: Add
1917         "tracker" parameter.
1918         * go-exp.y: Update rules.
1919         * f-exp.y: Update rules.
1920         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1921         parameter.
1922         * d-exp.y: Update rules.
1923         * c-exp.y: Update rules.
1924         * breakpoint.c (set_breakpoint_condition): Create an
1925         innermost_block_tracker.
1926         (watch_command_1): Likewise.
1927         * ada-lang.c (resolve): Add "tracker" parameter.
1928         (resolve_subexp): Likewise.
1929         * ada-exp.y (write_var_from_sym): Update.
1930
1931 2019-04-04  Tom Tromey  <tom@tromey.com>
1932
1933         * type-stack.h: New file.
1934         * type-stack.c: New file.
1935         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1936         type-stack.h.
1937         (insert_into_type_stack, insert_type, push_type, push_type_int)
1938         (insert_type_address_space, pop_type, pop_type_int)
1939         (pop_typelist, pop_type_stack, append_type_stack)
1940         (push_type_stack, get_type_stack, push_typelist)
1941         (follow_type_instance_flags, follow_types): Don't declare.
1942         * parse.c (type_stack): Remove global.
1943         (parse_exp_in_context): Update.
1944         (insert_into_type_stack, insert_type, push_type, push_type_int)
1945         (insert_type_address_space, pop_type, pop_type_int)
1946         (pop_typelist, pop_type_stack, append_type_stack)
1947         (push_type_stack, get_type_stack, push_typelist)
1948         (follow_type_instance_flags, follow_types): Remove (moved to
1949         type-stack.c).
1950         * f-exp.y (type_stack): New global.
1951         Update rules.
1952         (push_kind_type, f_parse): Update.
1953         * d-exp.y (type_stack): New global.
1954         Update rules.
1955         (d_parse): Update.
1956         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1957         Update rules.
1958         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1959         (HFILES_NO_SRCDIR): Add type-stack.h.
1960
1961 2019-04-04  Tom Tromey  <tom@tromey.com>
1962
1963         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1964         (rust_parser::convert_ast_to_expression, rust_parse)
1965         (rust_lex_test_completion, rust_lex_tests): Update.
1966         * parser-defs.h (struct expr_completion_state): New.
1967         (struct parser_state) <parser_state>: Add completion parameter.
1968         <mark_struct_expression, mark_completion_tag>: New methods.
1969         <parse_completion, m_completion_state>: New members.
1970         (prefixify_expression, null_post_parser): Update.
1971         (mark_struct_expression, mark_completion_tag): Don't declare.
1972         * parse.c (parse_completion, expout_last_struct)
1973         (expout_tag_completion_type, expout_completion_name): Remove
1974         globals.
1975         (parser_state::mark_struct_expression)
1976         (parser_state::mark_completion_tag): Now methods.
1977         (prefixify_expression): Add last_struct parameter.
1978         (prefixify_subexp): Likewise.
1979         (parse_exp_1): Update.
1980         (parse_exp_in_context): Add cstate parameter.  Update.
1981         (parse_expression_for_completion): Create an
1982         expr_completion_state.
1983         (null_post_parser): Add "completion" parameter.
1984         * p-exp.y: Update rules.
1985         (yylex): Update.
1986         * language.h (struct language_defn) <la_post_parser>: Add
1987         "completing" parameter.
1988         * go-exp.y: Update rules.
1989         (lex_one_token): Update.
1990         * expression.h (parse_completion): Don't declare.
1991         * d-exp.y: Update rules.
1992         (lex_one_token): Update rules.
1993         * c-exp.y: Update rules.
1994         (lex_one_token): Update.
1995         * ada-lang.c (resolve): Add "parse_completion" parameter.
1996         (resolve_subexp): Likewise.
1997         (ada_resolve_function): Likewise.
1998
1999 2019-04-04  Tom Tromey  <tom@tromey.com>
2000
2001         * parser-defs.h (struct parser_state) <start_arglist,
2002         end_arglist>: New methods.
2003         <arglist_len, m_funcall_chain>: New members.
2004         (arglist_len, start_arglist, end_arglist): Don't declare.
2005         * parse.c (arglist_len, funcall_chain): Remove global.
2006         (start_arglist, end_arglist): Remove functions.
2007         (parse_exp_in_context): Update.
2008         * p-exp.y: Update rules.
2009         * m2-exp.y: Update rules.
2010         * go-exp.y: Update rules.
2011         * f-exp.y: Update rules.
2012         * d-exp.y: Update rules.
2013         * c-exp.y: Update rules.
2014
2015 2019-04-04  Tom Tromey  <tom@tromey.com>
2016
2017         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2018         lex_operator, push_back>: New methods.
2019         Update all rules.
2020         (rust_parser::lex_hex, lex_escape): Rename and update.
2021         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2022         (rust_parser::lex_operator): Rename and update.
2023         (rust_parser::lex_number, rustyylex, rustyyerror)
2024         (rust_lex_test_init, rust_lex_test_sequence)
2025         (rust_lex_test_push_back, rust_lex_tests): Update.
2026         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2027         parameter.
2028         <lexptr, prev_lexptr>: New members.
2029         (lexptr, prev_lexptr): Don't declare.
2030         * parse.c (lexptr, prev_lexptr): Remove globals.
2031         (parse_exp_in_context): Update.
2032         * p-exp.y (yylex, yyerror): Update.
2033         * m2-exp.y (parse_number, yylex, yyerror): Update.
2034         * go-exp.y (lex_one_token, yyerror): Update.
2035         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2036         * d-exp.y (lex_one_token, yyerror): Update.
2037         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2038         (lex_one_token, yyerror): Update.
2039         * ada-lex.l (YY_INPUT): Update.
2040         (rewind_to_char): Update.
2041         * ada-exp.y (yyerror): Update.
2042
2043 2019-04-04  Tom Tromey  <tom@tromey.com>
2044
2045         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2046         * parser-defs.h (struct parser_state) <parser_state>: Add new
2047         parameter.
2048         <comma_terminates>: New member.
2049         (comma_terminates): Don't declare global.
2050         * parse.c (comma_terminates): Remove global.
2051         (parse_exp_in_context): Update.
2052         * p-exp.y (yylex): Update.
2053         * m2-exp.y (yylex): Update.
2054         * go-exp.y (lex_one_token): Update.
2055         * f-exp.y (yylex): Update.
2056         * d-exp.y (lex_one_token): Update.
2057         * c-exp.y (lex_one_token): Update.
2058         * ada-lex.l: Update.
2059
2060 2019-04-04  Tom Tromey  <tom@tromey.com>
2061
2062         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2063         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2064         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2065         * parser-defs.h (paren_depth): Don't declare.
2066         * parse.c (paren_depth): Remove global.
2067         (parse_exp_in_context): Update.
2068         * p-exp.y (paren_depth): New global.
2069         (pascal_parse): Initialize it.
2070         * m2-exp.y (paren_depth): New global.
2071         (m2_parse): Initialize it.
2072         * go-exp.y (paren_depth): New global.
2073         (go_parse): Initialize it.
2074         * f-exp.y (paren_depth): New global.
2075         (f_parse): Initialize it.
2076         * d-exp.y (paren_depth): New global.
2077         (d_parse): Initialize it.
2078         * c-exp.y (paren_depth): New global.
2079         (c_parse): Initialize it.
2080         * ada-lex.l (paren_depth): New global.
2081         (lexer_init): Initialize it.
2082
2083 2019-04-04  Tom Tromey  <tom@tromey.com>
2084
2085         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2086         (rust_parser::convert_ast_to_type)
2087         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2088         * parser-defs.h (struct parser_state) <parser_state>: Add
2089         parameters.  Initialize new members.
2090         <expression_context_block, expression_context_pc>: New members.
2091         * parse.c (expression_context_block, expression_context_pc):
2092         Remove globals.
2093         (parse_exp_in_context): Update.
2094         * p-exp.y: Update all rules.
2095         (yylex): Update.
2096         * m2-exp.y: Update all rules.
2097         (yylex): Update.
2098         * go-exp.y (yylex): Update.
2099         * f-exp.y (yylex): Update.
2100         * d-exp.y: Update all rules.
2101         (yylex): Update.
2102         * c-exp.y: Update all rules.
2103         (lex_one_token, classify_name, yylex, c_parse): Update.
2104         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2105
2106 2019-04-04  Tom Tromey  <tom@tromey.com>
2107
2108         * gdbarch.h, gdbarch.c: Rebuild.
2109         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2110         * stap-probe.h:
2111         (struct stap_parse_info): Replace "parser_state" with
2112         "expr_builder".
2113         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2114         (parser_state): New class.
2115         * parse.c (expr_builder): Rename.
2116         (expr_builder::release): Rename.
2117         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2118         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2119         (write_exp_elt_longcst, write_exp_elt_floatcst)
2120         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2121         (write_exp_string_vector, write_exp_bitstring)
2122         (write_exp_msymbol, mark_struct_expression)
2123         (write_dollar_variable)
2124         (insert_type_address_space, increase_expout_size): Replace
2125         "parser_state" with "expr_builder".
2126         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2127         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2128         "parser_state" with "expr_builder".
2129
2130 2019-04-04  Tom Tromey  <tom@tromey.com>
2131
2132         * rust-exp.y: Replace "parse_language" with method call.
2133         * p-exp.y:
2134         (yylex): Replace "parse_language" with method call.
2135         * m2-exp.y:
2136         (yylex): Replace "parse_language" with method call.
2137         * go-exp.y (classify_name): Replace "parse_language" with method
2138         call.
2139         * f-exp.y (yylex): Replace "parse_language" with method call.
2140         * d-exp.y (lex_one_token): Replace "parse_language" with method
2141         call.
2142         * c-exp.y:
2143         (lex_one_token, classify_name, yylex): Replace "parse_language"
2144         with method call.
2145         * ada-exp.y (find_primitive_type, type_char)
2146         (type_system_address): Replace "parse_language" with method call.
2147
2148 2019-04-04  Tom Tromey  <tom@tromey.com>
2149
2150         * rust-exp.y: Replace "parse_gdbarch" with method call.
2151         * parse.c (write_dollar_variable, insert_type_address_space):
2152         Replace "parse_gdbarch" with method call.
2153         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2154         call.
2155         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2156         call.
2157         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2158         "parse_gdbarch" with method call.
2159         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2160         with method call.
2161         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2162         "parse_gdbarch" with method call.
2163         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2164         "parse_gdbarch" with method call.
2165         * c-exp.y (parse_type, parse_number, classify_name): Replace
2166         "parse_gdbarch" with method call.
2167         * ada-lex.l: Replace "parse_gdbarch" with method call.
2168         * ada-exp.y (parse_type, find_primitive_type, type_char)
2169         (type_system_address): Replace "parse_gdbarch" with method call.
2170
2171 2019-04-04  Tom Tromey  <tom@tromey.com>
2172
2173         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2174         * stap-probe.c (stap_parse_argument): Update.
2175         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2176         initial_size parameter.
2177         * rust-exp.y (rust_lex_tests): Update.
2178         * parse.c (parser_state): Update.
2179         (parse_exp_in_context): Update.
2180         * parser-defs.h (struct parser_state) <parser_state>: Remove
2181         "initial_size" parameter.
2182
2183 2019-04-04  Tom Tromey  <tom@tromey.com>
2184
2185         * parser-defs.h (increase_expout_size): Don't declare.
2186         * parse.c (increase_expout_size): Now static.
2187
2188 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2189
2190         * gnu-nat.c (gnu_nat_target::wait): Fix
2191         target_waitstatus_to_string call.
2192
2193 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * eval.c (evaluate_subexp_standard): Handle internal functions
2196         during Fortran function call handling.
2197
2198 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * NEWS: Mention new internal functions.
2201         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2202         (read_base_type): Use dwarf2_init_complex_target_type.
2203         * value.c (creal_internal_fn): New function.
2204         (cimag_internal_fn): New function.
2205         (_initialize_values): Register new internal functions.
2206
2207 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2208
2209         * infrun.c (stop_all_threads): If debug_infrun, always
2210         trace the wait status after wait_one, using
2211         target_waitstatus_to_string and target_pid_to_str.
2212         (handle_inferior_event): Replace various trace of
2213         wait status kind by a single trace.
2214         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2215         wait status kind image by target_waitstatus_to_string.
2216         * target/waitstatus.c (target_waitstatus_to_string): Fix
2217         obsolete comment.
2218
2219 2019-04-01  Tom Tromey  <tromey@adacore.com>
2220
2221         PR symtab/23331:
2222         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2223
2224 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2225             Pedro Alves  <palves@redhat.com>
2226
2227         * top.c (quit_force): Call 'finalize_values'.
2228         * value.c (finalize_values): New function.
2229         * value.h (finalize_values): Declare.
2230
2231 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2232
2233         * NEWS: Announce $_gdb_major and $_gdb_minor.
2234
2235         * top.c (init_gdb_version_vars): New function.
2236         (gdb_init): Call init_gdb_version_vars.
2237
2238 2019-03-29  Tom Tromey  <tromey@adacore.com>
2239
2240         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2241         help text.  Remove dead code.
2242
2243 2019-03-29  Keith Seitz  <keiths@redhat.com>
2244
2245         From Siddhesh Poyarekar:
2246         * f-lang.h (f77_get_upperbound): Return LONGEST.
2247         (f77_get_lowerbound): Likewise.
2248         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2249         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2250         print them.
2251         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2252         plongest to format print it.
2253         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2254         (f77_get_upperbound): Likewise.
2255         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2256         LOWER_BOUND to LONGEST.
2257         (f77_create_arrayprint_offset_tbl): Likewise.
2258
2259 2019-03-29  Keith Seitz  <keiths@redhat.com>
2260
2261         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2262         %s/pulongest for TYPE_LENGTH instead of %d in format
2263         strings.
2264         * ada-typerint.c (ada_print_type): Likewise.
2265         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2266         * compile/compile-c-support.c (generate_register_struct): Likewise.
2267         * gdbtypes.c (recursive_dump_type): Likewise.
2268         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2269         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2270         instead of %d in format strings.
2271         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2272         to std::min to ULONGEST.
2273         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2274         instead of %d in format strings.
2275         * tracepoint.c (info_scope_command): Likewise.
2276         * typeprint.c (print_offset_data::update)
2277         (print_offset_data::finish): Likewise.
2278         * xtensa-tdep.c (xtensa_store_return_value)
2279         (xtensa_push_dummy_call): Likewise.
2280
2281 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2282
2283         * windows-nat.c (display_selector): Fixed format specifications
2284         for 64-bit Cygwin.
2285
2286 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2287
2288         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2289
2290 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2291
2292         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2293         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2294         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2295         (nios2_linux_init_abi): Install it.
2296
2297 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2298
2299         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2300
2301 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2302
2303         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2304
2305 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2306             Tom Tromey  <tromey@adacore.com>
2307
2308         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2309
2310 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2311
2312         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2313         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2314         method to compute the bounds of range types. Also print "[evaluated]"
2315         if the bounds' values come from a dynamic evaluation.
2316
2317 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2320         whitespace when pretty printing is on.
2321
2322 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2323
2324         * ppc-linux-nat.c: Add include.
2325
2326 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2327
2328         * NEWS: Mention AArch64 Pointer Authentication.
2329
2330 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2331
2332         * arm-linux-nat.c: Add include.
2333
2334 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2335
2336         * source-cache.c (source_cache::get_source_lines): Re-read
2337         fullname after calling open_source_file.
2338
2339 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2340
2341         * NEWS: Mention TLS support for FreeBSD.
2342
2343 2019-03-25  Tom Tromey  <tromey@adacore.com>
2344
2345         * minsyms.c (BUNCH_SIZE): Update comment.
2346         (~minimal_symbol_reader): Remove old comment.
2347         (compact_minimal_symbols): Update comment.
2348         (minimal_symbol_reader::install): Remove old comment.  Update
2349         other comments.
2350
2351 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2352
2353         * s390-linux-nat.c: Add include.
2354
2355 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2356
2357         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2358         Call linux_get_hwcap.
2359         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2360         Likewise.
2361         (aarch64_linux_get_hwcap): Remove function.
2362         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2363         declaration.
2364         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2365         linux_get_hwcap.
2366         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2367         * linux-tdep.c (linux_get_hwcap): Add function.
2368         (linux_get_hwcap2): Likewise.
2369         * linux-tdep.h (linux_get_hwcap): Add declaration.
2370         (linux_get_hwcap2): Likewise.
2371         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2372         (ppc_linux_get_hwcap2): Likewise.
2373         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2374         linux_get_hwcap.
2375         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2376         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2377         (ppc_linux_nat_target::read_description): Likewise.
2378         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2379         * s390-linux-nat.c: Likewise.
2380         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2381
2382 2019-03-24  Tom Tromey  <tom@tromey.com>
2383
2384         * ada-lang.c (standard_lookup): Simplify initialization.
2385         (ada_lookup_symbol_nonlocal): Simplify return.
2386         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2387         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2388         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2389         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2390         initialization.
2391         * solib.c (solib_global_lookup): Simplify.
2392         * symtab.c (null_block_symbol): Remove.
2393         (symbol_cache_lookup): Simplify returns.
2394         (lookup_language_this): Simplify returns.
2395         (lookup_symbol_aux): Simplify return.
2396         (lookup_local_symbol): Simplify returns.
2397         (lookup_global_symbol_from_objfile): Simplify return.
2398         (lookup_symbol_in_objfile_symtabs)
2399         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2400         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2401         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2402         * cp-namespace.c (cp_lookup_bare_symbol)
2403         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2404         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2405         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2406         (cp_lookup_symbol_via_imports): Simplify initialization.
2407         (find_symbol_in_baseclass): Likewise.
2408         * symtab.h (null_block_symbol): Remove.
2409         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2410         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2411         (d_lookup_symbol_module): Likewise.
2412         (find_symbol_in_baseclass): Simplify initialization.
2413
2414 2019-03-24  Tom Tromey  <tom@tromey.com>
2415
2416         * expression.h: Don't include symtab.h.
2417         (struct block): Forward declare.
2418
2419 2019-03-24  Tom Tromey  <tom@tromey.com>
2420
2421         * c-exp.y (typebase): Remove casts.
2422         * gdbtypes.c (lookup_unsigned_typename, )
2423         (lookup_signed_typename): Remove cast.
2424         * eval.c (parse_to_comma_and_eval): Remove cast.
2425         * parse.c (write_dollar_variable): Remove cast.
2426         * block.h (struct block) <superblock>: Now const.
2427         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2428         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2429         (map_block): Make "block" const.
2430         * symfile.h (struct quick_symbol_functions)
2431         <map_matching_symbols>: Constify block argument to "callback".
2432         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2433         const.
2434         (find_pc_sect_compunit_symtab): Make "b" const.
2435         (find_symbol_at_address): Likewise.
2436         (search_symbols): Likewise.
2437         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2438         (dw2_debug_names_lookup_symbol): Likewise.
2439         (dw2_map_matching_symbols): Update.
2440         * p-valprint.c (pascal_val_print): Remove "block".
2441         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2442         (aux_add_nonlocal_symbols): Make "block" const.
2443         (resolve_subexp): Remove cast.
2444         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2445         const.
2446         (iterate_over_file_blocks): Likewise.
2447         * f-exp.y (%union) <bval>: Remove.
2448         * coffread.c (patch_opaque_types): Make "b" const.
2449         * spu-tdep.c (spu_catch_start): Make "block" const.
2450         * c-valprint.c (print_unpacked_pointer): Remove "block".
2451         * symmisc.c (dump_symtab_1): Make "b" const.
2452         (block_depth): Make "block" const.
2453         * d-exp.y (%union) <bval>: Remove.
2454         * cp-support.h (cp_lookup_rtti_type): Update.
2455         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2456         * psymtab.c (psym_lookup_symbol): Make "block" const.
2457         (maintenance_check_psymtabs): Make "b" const.
2458         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2459         (enumerate_locals, enumerate_args): Update.
2460         * python/py-symtab.c (stpy_global_block): Make "block" const.
2461         (stpy_static_block): Likewise.
2462         * inline-frame.c (block_starting_point_at): Make "new_block"
2463         const.
2464         * block.c (find_block_in_blockvector): Make return type const.
2465         (blockvector_for_pc_sect): Make "b" const.
2466         (find_block_in_blockvector): Make "b" const.
2467
2468 2019-03-23  Tom Tromey  <tom@tromey.com>
2469
2470         * varobj.c (varobj_create): Update.
2471         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2472         * printcmd.c (display_command, do_one_display): Don't reset
2473         innermost_block.
2474         * parser-defs.h (enum innermost_block_tracker_type): Move to
2475         expression.h.
2476         (innermost_block): Update comment.
2477         * parse.c (parse_exp_1): Add tracker_types parameter.
2478         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2479         tracker_types parameter.  Reset innermost_block.
2480         (parse_exp_in_context): Remove.
2481         (parse_expression_for_completion): Update.
2482         * objfiles.c (~objfile): Don't reset expression_context_block or
2483         innermost_block.
2484         * expression.h (enum innermost_block_tracker_type): Move from
2485         parser-defs.h.
2486         (parse_exp_1): Add tracker_types parameter.
2487         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2488         reset innermost_block.
2489
2490 2019-03-23  Tom Tromey  <tom@tromey.com>
2491
2492         * objfiles.h: Include bcache.h.
2493
2494 2019-03-23  Tom Tromey  <tom@tromey.com>
2495
2496         * linespec.c (get_current_search_block): Use
2497         scoped_restore_current_language.
2498         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2499
2500 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2501             Jiong Wang  <jiong.wang@arm.com>
2502
2503         * aarch64-linux-tdep.c
2504         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2505         section.
2506         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2507
2508 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2509             Jiong Wang  <jiong.wang@arm.com>
2510
2511         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2512         instructions.
2513         (aarch64_analyze_prologue_test): Add PACIASP test.
2514         (aarch64_prologue_prev_register): Unmask PC value.
2515
2516 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2517             Jiong Wang  <jiong.wang@arm.com>
2518
2519         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2520         (aarch64_dwarf2_prev_register): Unmask PC value.
2521         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2522         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2523         DW_CFA_AARCH64_negate_ra_state.
2524         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2525
2526 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2527             Jiong Wang  <jiong.wang@arm.com>
2528
2529         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2530         registers.
2531         (aarch64_pseudo_register_name): Likewise.
2532         (aarch64_pseudo_register_type): Likewise.
2533         (aarch64_pseudo_register_reggroup_p): Likewise.
2534         (aarch64_gdbarch_init): Add pauth registers.
2535         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2536         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2537         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2538         (struct gdbarch_tdep): Add regnum for ra_state.
2539
2540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2541             Jiong Wang  <jiong.wang@arm.com>
2542
2543         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2544
2545 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2546             Jiong Wang  <jiong.wang@arm.com>
2547
2548         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2549         function.
2550         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2551         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2552         (aarch64_gdbarch_init): Add puth registers.
2553         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2554         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2555         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2556
2557 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2558             Jiong Wang  <jiong.wang@arm.com>
2559
2560         * aarch64-linux-nat.c
2561         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2562         * aarch64-linux-tdep.c
2563         (aarch64_linux_core_read_description): Likewise.
2564         (aarch64_linux_get_hwcap): New function.
2565         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2566         (aarch64_linux_get_hwcap): New declaration.
2567
2568 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2569             Jiong Wang  <jiong.wang@arm.com>
2570
2571         * aarch64-linux-nat.c
2572         (aarch64_linux_nat_target::read_description): Add pauth param.
2573         * aarch64-linux-tdep.c
2574         (aarch64_linux_core_read_description): Likewise.
2575         * aarch64-tdep.c (struct target_desc): Add in pauth.
2576         (aarch64_read_description): Add pauth param.
2577         (aarch64_gdbarch_init): Likewise.
2578         * aarch64-tdep.h (aarch64_read_description): Likewise.
2579         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2580         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2581         * features/Makefile: Add new files.
2582         * features/aarch64-pauth.c: New file.
2583         * features/aarch64-pauth.xml: New file.
2584
2585 2019-03-20  Tom Tromey  <tromey@adacore.com>
2586
2587         * infrun.c (handle_inferior_event): Rename from
2588         handle_inferior_event_1.  Create a scoped_value_mark.
2589         (handle_inferior_event): Remove.
2590
2591 2019-03-19  Tom Tromey  <tromey@adacore.com>
2592
2593         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2594         * infrun.h (print_stop_event): Add "displays" parameter.
2595         * infrun.c (print_stop_event): Add "displays" parameter.
2596
2597 2019-03-19  Pedro Alves  <palves@redhat.com>
2598
2599         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2600         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2601         to -1.  Fix TABs vs spaces.
2602         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2603         * tui/tui-out.h (tui_ui_out) Add intro comments.
2604         <m_line, m_start_of_line>: In-class initialize, and add describing
2605         comment.
2606
2607 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2608
2609         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2610         variable names.
2611         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2612
2613 2019-03-18  Pedro Alves  <palves@redhat.com>
2614             Eli Zaretskii <eliz@gnu.org>
2615
2616         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2617         m_line and m_start_of_line.
2618
2619 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2620
2621         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2622         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2623         it returns a newline.  This fixes a regression in TU mode, whereby
2624         the next line is output on the same screen line as the user input.
2625
2626 2019-03-18  Tom Tromey  <tromey@adacore.com>
2627
2628         * minsyms.c (minimal_symbol_reader::install): Remove call to
2629         obstack_blank.
2630
2631 2019-03-18  Pedro Alves  <palves@redhat.com>
2632
2633         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2634         New globals.
2635         (apply_style): New, factored out from ...
2636         (apply_ansi_escape): ... this.  Handle reverse video mode.
2637         (tui_set_reverse_mode): New function.
2638         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2639         * tui/tui-winsource.c (tui_show_source_line): Use
2640         tui_set_reverse_mode instead of setting A_STANDOUT.
2641         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2642         New setter methods.
2643
2644 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2645
2646         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2647         Handle tabs.
2648
2649 2019-03-18  Tom Tromey  <tromey@adacore.com>
2650
2651         * ada-lang.c (empty_array): Add "high" parameter.
2652         (ada_evaluate_subexp): Update.
2653
2654 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2655
2656         * unittests/string_view-selftests.c: Define
2657         _initialize_string_view_selftests unconditionally.
2658
2659 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2660
2661         PR gdb/24350
2662         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2663
2664 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2665
2666         PR gdb/24351
2667         * windows-nat.c (display_selector): Fix format specifiers.
2668
2669 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2670
2671         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2672         tui_refill_source_window instead of tui_refresh_win, to update the
2673         current execution line.  This fixes redisplay of the current line
2674         when stepping through the code with "next" or "step".
2675
2676 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2677
2678         * source-cache.c (source_cache::get_source_lines): Call
2679         find_source_lines to initialize s->nlines.  This fixes vertical
2680         scrolling of TUI source window when the DOWN arrow is pressed.
2681
2682 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2683
2684         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2685         linux-thread-db.c (_initialize_thread_db): Likewise.
2686
2687 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2688
2689         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2690         wclrtoeol in tui_show_source_line".  This reverts changes made in
2691         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2692
2693 2019-03-15  Tom Tromey  <tom@tromey.com>
2694
2695         * symtab.h (struct minimal_symbol): Derive from
2696         general_symbol_info.
2697         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2698         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2699         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2700         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2701         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2702         (MSYMBOL_SEARCH_NAME): Update.
2703         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2704         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2705         * minsyms.c (minimal_symbol_reader::record_full): Update.
2706
2707 2019-03-15  Tom Tromey  <tom@tromey.com>
2708
2709         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2710
2711 2019-03-15  Tom Tromey  <tom@tromey.com>
2712
2713         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2714         unique_xmalloc_ptr.
2715         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2716         Update.
2717         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2718         (build_minimal_symbol_hash_tables)
2719         (minimal_symbol_reader::install): Update.
2720
2721 2019-03-15  Tom Tromey  <tom@tromey.com>
2722
2723         * symtab.c (create_demangled_names_hash): Update.
2724         (symbol_set_names): Update.
2725         * objfiles.h (struct objfile_per_bfd_storage)
2726         <demangled_names_hash>: Now an htab_up.
2727         * objfiles.c (objfile_per_bfd_storage): Simplify.
2728
2729 2019-03-15  Tom Tromey  <tom@tromey.com>
2730
2731         * objfiles.h (struct objfile_per_bfd_storage): Declare
2732         destructor.
2733         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2734         New.
2735         (get_objfile_bfd_data): Use new.  Don't initialize
2736         language_of_main.
2737         (free_objfile_per_bfd_storage): Remove.
2738         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2739
2740 2019-03-15  Tom Tromey  <tom@tromey.com>
2741
2742         * symfile.c (reread_symbols): Update.
2743         * objfiles.c (objfile::objfile): Update.
2744         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2745         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2746         comment.
2747         (minimal_symbol_reader::install): Update.
2748         (terminate_minimal_symbol_table): Remove.
2749         * jit.c (jit_object_close_impl): Update.
2750
2751 2019-03-15  Tom Tromey  <tom@tromey.com>
2752
2753         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2754         initializations.
2755
2756 2019-03-15  Tom Tromey  <tom@tromey.com>
2757
2758         * objfiles.h (struct objfile_per_bfd_storage)
2759         <demangled_hash_languages>: Now a bitset.
2760         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2761         (lookup_minimal_symbol): Update.
2762
2763 2019-03-15  Tom Tromey  <tom@tromey.com>
2764
2765         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2766         Don't return the symbol.
2767         * coffread.c (record_minimal_symbol): Use record_full.
2768
2769 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2770
2771         The MS-Windows port of ncurses fails to switch to a color pair if
2772         one or both of the colors are the implicit default colors.  This
2773         change records the default colors when TUI is initialized, and
2774         then specifies them explicitly when a color pair uses the default
2775         colors.  This allows color styling in TUI mode on MS-Windows.
2776
2777         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2778         ncurses_norm_attr.
2779         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2780         colors in ncurses_norm_attr.
2781         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2782         "none", replace it with the default color recorded in
2783         ncurses_norm_attr.
2784
2785 2019-03-14  Tom Tromey  <tromey@adacore.com>
2786
2787         * source-cache.h (class source_cache) <get_source_lines>: Return
2788         std::string.
2789         * source-cache.c (source_cache::extract_lines): Handle case where
2790         first_pos==npos.  Return std::string.
2791         (source_cache::get_source_lines): Update.
2792
2793 2019-03-14  Tom Tromey  <tromey@adacore.com>
2794
2795         * NEWS: Add item for "style sources" commands.
2796         * source-cache.c (source_cache::get_source_lines): Check
2797         source_styling.
2798         * cli/cli-style.c (source_styling): New global.
2799         (_initialize_cli_style): Add "style sources" commands.
2800         (show_style_sources): New function.
2801         * cli/cli-style.h (source_styling): Declare.
2802
2803 2019-03-14  Pedro Alves  <palves@redhat.com>
2804             Tom Tromey  <tromey@adacore.com>
2805
2806         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2807         * tui/tui-winsource.c (tui_refill_source_window): New function,
2808         from...
2809         (tui_horizontal_source_scroll): ... here.  Move some logic.
2810         * cli/cli-style.c (set_style_enabled): Notify new observable.
2811         * tui/tui-hooks.c (tui_redisplay_source): New function.
2812         (tui_attach_detach_observers): Attach or detach
2813         tui_redisplay_source.
2814         * observable.h (source_styling_changed): New observable.
2815         * observable.c: Define source_styling_changed observable.
2816
2817 2019-03-13  Tom Tromey  <tromey@adacore.com>
2818
2819         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2820         (i386_gnu_nat_target::store_registers): Update.
2821         * target-debug.h (target_debug_print_std_string): New macro.
2822         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2823         * windows-tdep.c (display_one_tib): Update.
2824         * tui/tui-stack.c (tui_make_status_line): Update.
2825         * top.c (print_inferior_quit_action): Update.
2826         * thread.c (thr_try_catch_cmd): Update.
2827         (add_thread_with_info): Update.
2828         (thread_target_id_str): Update.
2829         (thr_try_catch_cmd): Update.
2830         (thread_command): Update.
2831         (thread_find_command): Update.
2832         * record-btrace.c (record_btrace_target::info_record)
2833         (record_btrace_resume_thread, record_btrace_target::resume)
2834         (record_btrace_cancel_resume, record_btrace_step_thread)
2835         (record_btrace_target::wait, record_btrace_target::wait)
2836         (record_btrace_target::wait, record_btrace_target::stop): Update.
2837         * progspace.c (print_program_space): Update.
2838         * process-stratum-target.c
2839         (process_stratum_target::thread_address_space): Update.
2840         * linux-fork.c (linux_fork_mourn_inferior)
2841         (detach_checkpoint_command, info_checkpoints_command)
2842         (linux_fork_context): Update.
2843         (linux_fork_detach): Update.
2844         (class scoped_switch_fork_info): Update.
2845         (delete_checkpoint_command): Update.
2846         * infrun.c (follow_fork_inferior): Update.
2847         (follow_fork_inferior): Update.
2848         (proceed_after_vfork_done): Update.
2849         (handle_vfork_child_exec_or_exit): Update.
2850         (follow_exec): Update.
2851         (displaced_step_prepare_throw): Update.
2852         (displaced_step_restore): Update.
2853         (start_step_over): Update.
2854         (resume_1): Update.
2855         (clear_proceed_status_thread): Update.
2856         (proceed): Update.
2857         (print_target_wait_results): Update.
2858         (do_target_wait): Update.
2859         (context_switch): Update.
2860         (stop_all_threads): Update.
2861         (restart_threads): Update.
2862         (finish_step_over): Update.
2863         (handle_signal_stop): Update.
2864         (switch_back_to_stepped_thread): Update.
2865         (keep_going_pass_signal): Update.
2866         (print_exited_reason): Update.
2867         (normal_stop): Update.
2868         * inferior.c (inferior_pid_to_str): Change return type.
2869         (print_selected_inferior): Update.
2870         (add_inferior): Update.
2871         (detach_inferior): Update.
2872         * dummy-frame.c (fprint_dummy_frames): Update.
2873         * dcache.c (dcache_info_1): Update.
2874         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2875         (btrace_fetch, btrace_clear): Update.
2876         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2877         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2878         type.
2879         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2880         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2881         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2882         * gdbarch.c, gdbarch.h: Rebuild.
2883         * gdbarch.sh (core_pid_to_str): Change return type.
2884         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2885         return type.
2886         (windows_nat_target::pid_to_str): Change return type.
2887         (windows_delete_thread): Update.
2888         (windows_nat_target::attach): Update.
2889         (windows_nat_target::files_info): Update.
2890         * target-delegates.c: Rebuild.
2891         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2892         return type.
2893         (sol_thread_target::pid_to_str): Change return type.
2894         * remote.c (class remote_target) <pid_to_str>: Change return
2895         type.
2896         (remote_target::pid_to_str): Change return type.
2897         (extended_remote_target::attach, remote_target::remote_stop_ns)
2898         (remote_target::remote_notif_remove_queued_reply)
2899         (remote_target::push_stop_reply, remote_target::disable_btrace):
2900         Update.
2901         (extended_remote_target::attach): Update.
2902         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2903         type.
2904         (gdbsim_target::pid_to_str): Change return type.
2905         * ravenscar-thread.c (struct ravenscar_thread_target)
2906         <pid_to_str>: Change return type.
2907         (ravenscar_thread_target::pid_to_str): Change return type.
2908         * procfs.c (class procfs_target) <pid_to_str>: Change return
2909         type.
2910         (procfs_target::pid_to_str): Change return type.
2911         (procfs_target::attach): Update.
2912         (procfs_target::detach): Update.
2913         (procfs_target::fetch_registers): Update.
2914         (procfs_target::store_registers): Update.
2915         (procfs_target::wait): Update.
2916         (procfs_target::files_info): Update.
2917         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2918         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2919         return type.
2920         (nto_procfs_target::pid_to_str): Change return type.
2921         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2922         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2923         return type.
2924         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2925         (exit_lwp): Update.
2926         (attach_proc_task_lwp_callback, get_detach_signal)
2927         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2928         (linux_nat_target::resume, wait_lwp, stop_callback)
2929         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2930         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2931         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2932         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2933         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2934         type.
2935         (inf_ptrace_target::attach): Update.
2936         (inf_ptrace_target::files_info): Update.
2937         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2938         type.
2939         (go32_nat_target::pid_to_str): Change return type.
2940         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2941         (gnu_nat_target::wait): Update.
2942         (gnu_nat_target::wait): Update.
2943         (gnu_nat_target::resume): Update.
2944         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2945         (fbsd_nat_target::wait): Update.
2946         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2947         type.
2948         (darwin_nat_target::attach): Update.
2949         * corelow.c (class core_target) <pid_to_str>: Change return type.
2950         (core_target::pid_to_str): Change return type.
2951         * target.c (normal_pid_to_str): Change return type.
2952         (default_pid_to_str): Likewise.
2953         (target_pid_to_str): Change return type.
2954         (target_translate_tls_address): Update.
2955         (target_announce_detach): Update.
2956         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2957         return type.
2958         (bsd_uthread_target::pid_to_str): Change return type.
2959         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2960         type.
2961         (bsd_kvm_target::pid_to_str): Change return type.
2962         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2963         return type.
2964         (aix_thread_target::pid_to_str): Change return type.
2965         * target.h (struct target_ops) <pid_to_str>: Change return type.
2966         (target_pid_to_str, normal_pid_to_str): Likewise.
2967         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2968         type.
2969         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2970         type.
2971         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2972         return type.
2973         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2974         type.
2975         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2976         type.
2977         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2978         return type.
2979
2980 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2981
2982         * NEWS: Mention that the new default MI version is 3.  Mention
2983         changes to the output of commands and events that deal with
2984         multi-location breakpoints.
2985         * breakpoint.c: Include "mi/mi-out.h".
2986         (print_one_breakpoint): Change output syntax if using MI version
2987         >= 3.
2988         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2989         New.
2990         (mi_multi_location_breakpoint_output_fixed): New.
2991         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2992         (mi_cmd_fix_multi_location_breakpoint_output): New.
2993         (mi_multi_location_breakpoint_output_fixed): New.
2994         * mi/mi-cmds.c (mi_cmds): Register command
2995         -fix-multi-location-breakpoint-output.
2996         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2997         interpreter "mi".
2998
2999 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3000
3001         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3002         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3003         instantiate mi_ui_out based on interpreter name.
3004         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3005         * mi/mi-main.c (mi_load_progress): Likewise.
3006
3007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3008
3009         * NEWS: Combine separate "New targets" sections for 8.3.
3010
3011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3012
3013         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3014         (ppcfbsd_init_abi): Install gdbarch
3015         "fetch_tls_load_module_address" and "get_thread_local_address"
3016         methods.
3017
3018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3019
3020         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3021         (riscv_fbsd_init_abi): Install gdbarch
3022         "fetch_tls_load_module_address" and "get_thread_local_address"
3023         methods.
3024
3025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3026
3027         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3028         (i386fbsd_init_abi): Install gdbarch
3029         "fetch_tls_load_module_address" and "get_thread_local_address"
3030         methods.
3031
3032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3033
3034         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3035         (amd64fbsd_init_abi): Install gdbarch
3036         "fetch_tls_load_module_address" and "get_thread_local_address"
3037         methods.
3038
3039 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3040
3041         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3042         (struct fbsd_pspace_data): New type.
3043         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3044         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3045         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3046         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3047         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3048
3049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3050
3051         * gdbtypes.c (lookup_struct_elt): New function.
3052         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3053         * gdbtypes.h (struct struct_elt): New type.
3054         (lookup_struct_elt): New prototype.
3055
3056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3057
3058         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3059         remove disabled code block.
3060
3061 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3062
3063         * gdbarch.sh (get_thread_local_address): New method.
3064         * gdbarch.h, gdbarch.c: Regenerate.
3065         * target.c (target_translate_tls_address): Use
3066         gdbarch_get_thread_local_address if present instead of
3067         target::get_thread_local_address.
3068
3069 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3070
3071         * target.h (target::get_thread_local_address): Update comment.
3072
3073 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3074
3075         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3076         objfile->separate_debug_objfile_backlink if not NULL.
3077
3078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3079
3080         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3081         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3082         (amd64bsd_store_inferior_registers): Likewise.
3083         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3084         Enable segment base registers.
3085         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3086         PT_GETFSBASE and PT_GETGSBASE.
3087         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3088         PT_SETGSBASE.
3089         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3090         segment base registers.
3091         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3092
3093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3094
3095         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3096         Update calls to i386_target_description to add 'segments'
3097         parameter.
3098         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3099         add segment base registers.
3100         * arch/i386.c (i386_create_target_description): Add 'segments'
3101         parameter to enable segment base registers.
3102         * arch/i386.h (i386_create_target_description): Likewise.
3103         * features/i386/32bit-segments.xml: New file.
3104         * features/i386/32bit-segments.c: Generate.
3105         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3106         call to i386_target_description to add 'segments' parameter.
3107         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3108         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3109         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3110         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3111         if feature is present.
3112         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3113         Add 'segments' parameter to call to i386_target_description.
3114         (i386_target_description): Add 'segments' parameter to enable
3115         segment base registers.
3116         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3117         to call to i386_target_description.
3118         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3119         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3120         Define I386_NUM_REGS.
3121         (i386_target_description): Add 'segments' parameter to enable
3122         segment base registers.
3123
3124 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3125
3126         PR/24325
3127         * source-cache.c: #undef open and close, to avoid unresolved
3128         externals during linking.
3129
3130 2019-03-12  Tom Tromey  <tromey@adacore.com>
3131
3132         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3133         const.  Add initializers.
3134         (_initialize_remote): Don't initialize ptid globals.
3135
3136 2019-03-12  Pedro Alves  <palves@redhat.com>
3137
3138         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3139
3140 2019-03-12  Pedro Alves  <palves@redhat.com>
3141
3142         * cp-name-parser.y (main): Remove unused 'len' variable.
3143
3144 2019-03-12  Tom Tromey  <tromey@adacore.com>
3145
3146         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3147         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3148
3149 2019-03-12  Tom Tromey  <tromey@adacore.com>
3150
3151         * linux-nat.c (iterate_over_lwps): Update.
3152         (stop_callback): Remove parameter.
3153         (stop_wait_callback, detach_callback, resume_set_callback)
3154         (select_singlestep_lwp_callback, set_ignore_sigint)
3155         (status_callback, resumed_callback, resume_clear_callback)
3156         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3157         data parameter.
3158         (linux_nat_target::detach, linux_nat_target::resume)
3159         (linux_stop_and_wait_all_lwps, select_event_lwp)
3160         (linux_nat_filter_event, linux_nat_wait_1)
3161         (linux_nat_target::kill, linux_nat_target::stop)
3162         (linux_nat_target::stop): Update.
3163         (linux_nat_resume_callback): Change type.
3164         (resume_stopped_resumed_lwps, count_events_callback)
3165         (select_event_lwp_callback): Likewise.
3166         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3167         * arm-linux-nat.c (struct update_registers_data): Remove.
3168         (update_registers_callback): Change type.
3169         (arm_linux_insert_hw_breakpoint1): Update.
3170         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3171         parameter.
3172         (x86_linux_dr_set_addr): Update.
3173         (x86_linux_dr_set_control): Update.
3174         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3175         (iterate_over_lwps): Use gdb::function_view.
3176         * nat/aarch64-linux-hw-point.c (struct
3177         aarch64_dr_update_callback_param): Remove.
3178         (debug_reg_change_callback): Change type.
3179         (aarch64_notify_debug_reg_change): Update.
3180         * s390-linux-nat.c (s390_refresh_per_info): Update.
3181
3182 2019-03-11  Tom Tromey  <tromey@adacore.com>
3183
3184         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3185         redundant assignment to "this_cu".
3186
3187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3188
3189         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3190
3191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3192
3193         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3194         from...
3195         (rank_one_type): ... this.
3196
3197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3198
3199         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3200         from...
3201         (rank_one_type): ... this.
3202
3203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3204
3205         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3206         from...
3207         (rank_one_type): ... this.
3208
3209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3210
3211         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3212         from...
3213         (rank_one_type): ... this.
3214
3215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3216
3217         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3218         from...
3219         (rank_one_type): ... this.
3220
3221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3222
3223         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3224         from...
3225         (rank_one_type): ... this.
3226
3227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3228
3229         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3230         from...
3231         (rank_one_type): ... this.
3232
3233 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3234
3235         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3236         from...
3237         (rank_one_type): ... this.
3238
3239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3240
3241         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3242         from...
3243         (rank_one_type): ... this.
3244
3245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3246
3247         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3248         from...
3249         (rank_one_type): ... this.
3250
3251 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3252
3253         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3254         from...
3255         (rank_one_type): ... this.
3256
3257 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3258
3259         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3260         from...
3261         (rank_one_type): ... this.
3262
3263 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3264
3265         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3266         inferior-events' shows the example events.
3267
3268 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3269
3270         Support styling on native MS-Windows console
3271
3272         PR/24315
3273         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3274         on MS-Windows if $TERM is not defined.
3275
3276         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3277
3278         * posix-hdep.c (gdb_console_fputs):
3279         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3280         functions.
3281         * ui-file.h (gdb_console_fputs): Add prototype.
3282
3283         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3284         back to fputs only if the former returns zero.
3285
3286 2019-03-07  Tom Tromey  <tom@tromey.com>
3287
3288         * symmisc.c (print_symbol_bcache_statistics): Update.
3289         (print_objfile_statistics): Update.
3290         * symfile.c (allocate_symtab): Update.
3291         * stabsread.c: Don't include bcache.h.
3292         * psymtab.h (struct psymbol_bcache): Don't declare.
3293         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3294         (psymbol_bcache_init, psymbol_bcache_free)
3295         (psymbol_bcache_get_bcache): Don't declare.
3296         * psymtab.c (struct psymbol_bcache): Remove.
3297         (psymtab_storage::psymtab_storage): Update.
3298         (psymtab_storage::~psymtab_storage): Update.
3299         (psymbol_bcache_init, psymbol_bcache_free)
3300         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3301         (add_psymbol_to_bcache): Update.
3302         (allocate_psymtab): Update.
3303         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3304         macro_cache>: No longer pointers.
3305         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3306         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3307         * macrotab.c (macro_bcache): Update.
3308         * macroexp.c: Don't include bcache.h.
3309         * gdbtypes.c (check_types_worklist): Update.
3310         (types_deeply_equal): Remove TRY/CATCH.  Update.
3311         * elfread.c (elf_symtab_read): Update.
3312         * dwarf2read.c: Don't include bcache.h.
3313         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3314         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3315         (print_bcache_statistics, bcache_memory_used): Don't declare.
3316         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3317         methods.  Rename all data members.
3318         * bcache.c (struct bcache): Move to bcache.h.
3319         (bcache::expand_hash_table): Rename from expand_hash_table.
3320         (bcache): Remove.
3321         (bcache::insert): Rename from bcache_full.
3322         (bcache::compare): Rename from bcache_compare.
3323         (bcache_xmalloc): Remove.
3324         (bcache::~bcache): Rename from bcache_xfree.
3325         (bcache::print_statistics): Rename from print_bcache_statistics.
3326         (bcache::memory_used): Rename from bcache_memory_used.
3327
3328 2019-03-07  Pedro Alves  <palves@redhat.com>
3329
3330         * infrun.c (normal_stop): Also check for
3331         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3332
3333 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3334
3335         * f-lang.c (value_from_host_double): Moved to...
3336         * value.c (value_from_host_double): ...here.
3337         * value.h (value_from_host_double): Declare.
3338         * guile/scm-math.c (vlscm_convert_typed_number): Use
3339         value_from_host_double.
3340         (vlscm_convert_number): Likewise.
3341         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3342         * python/py-value.c (convert_value_from_python): Likewise.
3343
3344 2019-03-06  Tom Tromey  <tom@tromey.com>
3345
3346         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3347
3348 2019-03-06  Tom Tromey  <tom@tromey.com>
3349
3350         * utils.h (free_current_contents): Don't declare.
3351         * utils.c (free_current_contents): Remove.
3352
3353 2019-03-06  Tom Tromey  <tom@tromey.com>
3354
3355         * top.c (quit_force): Update.
3356         * main.c (captured_command_loop): Update.
3357         * common/new-op.c (operator new): Update.
3358         * common/common-exceptions.c (struct catcher)
3359         <save_cleanup_chain>: Remove member.
3360         (exceptions_state_mc_init): Update.
3361         (exception_try_scope_entry): Return nullptr.
3362         (exception_try_scope_exit, exception_rethrow)
3363         (throw_exception_sjlj, throw_exception_cxx): Update.
3364         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3365         (all_cleanups, do_cleanups, discard_cleanups)
3366         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3367         (restore_cleanups, restore_final_cleanups): Don't declare.
3368         (do_final_cleanups): Remove parameter.
3369         * common/cleanups.c (cleanup_chain, make_cleanup)
3370         (make_cleanup_dtor, all_cleanups, do_cleanups)
3371         (discard_my_cleanups, discard_cleanups)
3372         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3373         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3374         (null_cleanup): Remove.
3375         (do_final_cleanups): Remove parameter.
3376
3377 2019-03-06  Tom Tromey  <tom@tromey.com>
3378
3379         * remote.c (remote_target::remote_parse_stop_reply): Use
3380         unique_xmalloc_ptr.
3381
3382 2019-03-06  Tom Tromey  <tom@tromey.com>
3383
3384         * stabsread.c (struct stabs_field_info): Rename from field_info.
3385         <list, fnlist>: Add initializers.
3386         <obstack>: New member.
3387         (read_member_functions, read_struct_fields, read_baseclasses):
3388         Allocate on obstack.  Don't use cleanups.
3389         (read_one_struct_field, read_member_functions, read_struct_fields)
3390         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3391         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3392         (read_struct_type): Update.
3393
3394 2019-03-06  Tom Tromey  <tom@tromey.com>
3395
3396         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3397         * common/filestuff.h (make_cleanup_close): Don't declare.
3398         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3399         Remove.
3400
3401 2019-03-06  Tom Tromey  <tom@tromey.com>
3402
3403         * solib-aix.c: Use make_scope_exit.
3404
3405 2019-03-06  Tom Tromey  <tom@tromey.com>
3406
3407         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3408         Use make_scope_exit.
3409
3410 2019-03-06  Tom Tromey  <tom@tromey.com>
3411
3412         * solib-svr4.c (disable_probes_interface): Remove parameter.
3413         (svr4_handle_solib_event): Use make_scope_exit.
3414
3415 2019-03-06  Tom Tromey  <tom@tromey.com>
3416
3417         * remote.c (struct stop_reply_deleter): Remove.
3418         (stop_reply_up): Update.
3419         (struct stop_reply): Derive from notif_event.  Don't typedef.
3420         <regcache>: Now a std::vector.
3421         (stop_reply_xfree): Remove.
3422         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3423         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3424         (remote_target::discard_pending_stop_replies): Use delete.
3425         (remote_target::remote_parse_stop_reply): Update.
3426         (remote_target::process_stop_reply): Update.
3427         * remote-notif.h (struct notif_event): Add virtual destructor.
3428         Remove "dtr" member.
3429         (struct notif_client) <alloc_event>: Return a unique_ptr.
3430         (notif_event_xfree): Don't declare.
3431         (notif_event_up): New typedef.
3432         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3433         (notif_event_xfree, do_notif_event_xfree): Remove.
3434         (remote_notif_state_xfree): Update.
3435
3436 2019-03-06  Tom Tromey  <tom@tromey.com>
3437
3438         * infrun.c (displaced_step_clear_cleanup): Now a
3439         forward_scope_exit type.
3440         (displaced_step_prepare_throw): Update.
3441         (displaced_step_fixup): Update.
3442
3443 2019-03-06  Tom Tromey  <tom@tromey.com>
3444
3445         * inferior.h (class inferior): Update comment.
3446         * gdbthread.h (class thread_info): Update comment.
3447
3448 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3449             Tom Tromey  <tom@tromey.com>
3450
3451         * stabsread.h (struct stab_section_list): Remove.
3452         (coffstab_build_psymtabs): Update.
3453         * dbxread.c (symbuf_sections): Now a std::vector.
3454         (sect_idx): New global.
3455         (fill_symbuf): Update.
3456         (coffstab_build_psymtabs): Change type of stabsects parameter.
3457         Update.
3458         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3459         std::vector.
3460         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3461         (coff_locate_sections): Update.
3462         (coff_symfile_read): Remove cleanups.  Update.
3463         (init_stringtab): Add storage parameter.
3464         (free_stringtab, free_stringtab_cleanup): Remove.
3465         (init_lineno): Add storage parameter.
3466         (free_linetab, free_linetab_cleanup): Remove.
3467
3468 2019-03-06  Pedro Alves  <palves@redhat.com>
3469
3470         * linux-fork.c (fork_info::clobber_regs): Delete.
3471         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3472         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3473         comment.  Adjust.
3474         (scoped_switch_fork_info::scoped_switch_fork_info)
3475         (checkpoint_command, linux_fork_context): Adjust
3476         fork_save_infrun_state calls.
3477
3478 2019-03-06  Pedro Alves  <palves@redhat.com>
3479
3480         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3481         (inf_has_multiple_threads): Return 'bool' and rewrite using
3482         inferior_info::threads().
3483
3484 2019-03-06  Pedro Alves  <palves@redhat.com>
3485
3486         * linux-fork.c: Include <list>.
3487         (fork_list): Now a std::list instance.
3488         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3489         (forks_exist_p, find_last_fork): Adjust.
3490         (new_fork): Delete.
3491         (one_fork_p): New.
3492         (add_fork): Adjust.
3493         (free_fork): Delete, folded into fork_info::~fork_info().
3494         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3495         Adjust.
3496         (init_fork_list): Delete.
3497         (linux_fork_killall, linux_fork_mourn_inferior)
3498         (linux_fork_detach, info_checkpoints_command): Adjust.
3499         (_initialize_linux_fork): No longer call init_fork_list.
3500
3501 2019-03-06  Pedro Alves  <palves@redhat.com>
3502
3503         * linux-fork.c (new_fork): New, split out of ...
3504         (add_fork): ... this.  Return void.  Move "first fork" special
3505         case from here, to ...
3506         (checkpoint_command): ... here.
3507         * linux-linux.h (add_fork): Return void.
3508
3509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3510
3511         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3512
3513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3514             Chris January  <chris.january@arm.com>
3515             David Lecomber  <david.lecomber@arm.com>
3516
3517         * f-exp.y: New token, UNOP_INTRINSIC.
3518         (exp): New pattern using UNOP_INTRINSIC token.
3519         (f77_keywords): Add 'abs' keyword.
3520         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3521         (value_from_host_double): New function.
3522         (evaluate_subexp_f): Support UNOP_ABS.
3523
3524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3525
3526         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3527         types.
3528
3529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3530
3531         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3532         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3533         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3534
3535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3538
3539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3540             Chris January  <chris.january@arm.com>
3541
3542         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3543         * f-exp.y: Define 'KIND' token.
3544         (exp): New pattern for KIND expressions.
3545         (ptype): Handle types with a kind extension.
3546         (direct_abs_decl): Extend to spot kind extensions.
3547         (f77_keywords): Add 'kind' to the list.
3548         (push_kind_type): New function.
3549         (convert_to_kind_type): New function.
3550         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3551         * parse.c (operator_length_standard): Likewise.
3552         * parser-defs.h (enum type_pieces): Add tp_kind.
3553         * std-operator.def: Add UNOP_KIND.
3554
3555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * f-exp.y (f_parse): Set yydebug.
3558
3559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * f-lang.c (evaluate_subexp_f): New function.
3562         (exp_descriptor_f): New global.
3563         (f_language_defn): Use exp_descriptor_f instead of
3564         exp_descriptor_standard.
3565
3566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3567
3568         * f-exp.y (struct token): Add comments.
3569         (dot_ops): Remove uppercase versions and the end marker.
3570         (f77_keywords): Likewise.
3571         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3572         entries in the dot_ops array are case insensitive, and use
3573         strncasecmp to compare strings.  Also some whitespace cleanup in
3574         this area.  Similar for the f77_keywords array, except entries in
3575         this list might be case sensitive.
3576
3577 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * f-exp.y (struct f77_boolean_val): Add comments.
3580         (boolean_values): Remove uppercase versions, and end marker.
3581         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3582         and use strncasecmp to achieve case insensitivity.  Additionally,
3583         perform whitespace cleanup around this code.
3584
3585 2019-03-06  Tom Tromey  <tromey@adacore.com>
3586
3587         * remote-sim.c (gdbsim_target_open): Use result of
3588         gdb_argv::release.
3589
3590 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3591         Dirk Schubert  <dirk.schubert@arm.com>
3592         Chris January  <chris.january@arm.com>
3593
3594         * eval.c (evaluate_subexp_standard): Call Fortran argument
3595         wrapping logic.
3596         * f-lang.c (struct value): A value which can be passed into a
3597         Fortran function call.
3598         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3599         where appropriate.
3600         (struct type): Value ready for a Fortran function call.
3601         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3602         is needed.
3603         * f-lang.h (fortran_argument_convert): Declaration.
3604         (fortran_preserve_arg_pointer): Declaration.
3605         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3606
3607 2019-03-05  Tom Tromey  <tromey@adacore.com>
3608
3609         * python/py-prettyprint.c (print_string_repr): Remove #if.
3610         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3611
3612 2019-03-05  Tom Tromey  <tromey@adacore.com>
3613
3614         * target.c (the_dummy_target): Move later.  Change type to
3615         "dummy_target".
3616         (initialize_targets): Don't initialize the_dummy_target.
3617
3618 2019-03-05  Tom Tromey  <tromey@adacore.com>
3619
3620         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3621         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3622
3623 2019-03-05  Tom Tromey  <tromey@adacore.com>
3624
3625         * windows-nat.c (windows_nat_target::attach)
3626         (windows_nat_target::detach): Don't call gdb_flush.
3627         * valprint.c (generic_val_print, val_print, val_print_string):
3628         Don't call gdb_flush.
3629         * utils.c (defaulted_query): Don't call gdb_flush.
3630         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3631         * target.c (target_announce_detach): Don't call gdb_flush.
3632         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3633         * remote.c (extended_remote_target::attach): Don't call
3634         gdb_flush.
3635         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3636         * printcmd.c (do_examine): Don't call gdb_flush.
3637         (info_display_command): Don't call gdb_flush.
3638         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3639         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3640         * memattr.c (info_mem_command): Don't call gdb_flush.
3641         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3642         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3643         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3644         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3645         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3646         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3647         (gnu_nat_target::detach): Don't call gdb_flush.
3648         * f-valprint.c (f_val_print): Don't call gdb_flush.
3649         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3650         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3651         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3652         gdb_flush.
3653         * c-valprint.c (c_val_print): Don't call gdb_flush.
3654         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3655
3656 2019-03-05  Tom Tromey  <tromey@adacore.com>
3657
3658         * varobj.c (update_dynamic_varobj_children): Update.
3659         (install_default_visualizer): Use reset, not release.
3660         * value.c (set_internalvar): Update.
3661         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3662         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3663         ATTRIBUTE_UNUSED_RESULT.
3664
3665 2019-03-05  Tom Tromey  <tromey@adacore.com>
3666
3667         * remote.c (class scoped_remote_fd) <release>: Add
3668         ATTRIBUTE_UNUSED_RESULT.
3669
3670 2019-03-05  Tom Tromey  <tromey@adacore.com>
3671
3672         * macroexp.c (struct macro_buffer) <release>: Add
3673         ATTRIBUTE_UNUSED_RESULT.
3674
3675 2019-03-05  Tom Tromey  <tromey@adacore.com>
3676
3677         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3678         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3679         ATTRIBUTE_UNUSED_RESULT.
3680
3681 2019-03-05  Tom Tromey  <tromey@adacore.com>
3682
3683         * common/scoped_fd.h (class scoped_fd) <release>: Add
3684         ATTRIBUTE_UNUSED_RESULT.
3685
3686 2019-03-05  Tom Tromey  <tromey@adacore.com>
3687
3688         * parser-defs.h (struct parser_state) <release>: Add
3689         ATTRIBUTE_UNUSED_RESULT.
3690
3691 2019-03-05  Tom Tromey  <tromey@adacore.com>
3692
3693         * utils.h (class gdb_argv) <release>: Add
3694         ATTRIBUTE_UNUSED_RESULT.
3695         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3696
3697 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3698
3699         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3700         for-loop range, to avoid compiler warnings.
3701
3702         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3703         avoid compiler warnings about unused variables.
3704
3705         * NEWS: Mention end of support for native debugging on MS-Windows
3706         before XP.
3707
3708         PR gdb/24292
3709         * common/netstuff.c:
3710         * gdbserver/gdbreplay.c
3711         * gdbserver/remote-utils.c:
3712         * ser-tcp.c:
3713         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3714         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3715         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3716         'getaddrinfo' and 'freeaddrinfo' were not available before
3717         Windows XP, and mingw.org's MinGW headers by default define
3718         _WIN32_WINNT to 0x500.
3719
3720 2019-03-01  Gary Benson <gbenson@redhat.com>
3721
3722         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3723
3724 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3725             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3726
3727         PR gdb/8527
3728         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3729         set_sigint_trap, clear_sigint_trap.
3730
3731 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3732
3733         * target.c (target_detach): Clear the regcache and the
3734         frame cache.
3735
3736 2019-02-27  Pedro Alves  <palves@redhat.com>
3737
3738         * utils.c (set_screen_size): When we cap the height/width sizes,
3739         tweak the corresponding command variable to show "unlimited":
3740
3741 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3742             Pedro Alves  <palves@redhat.com>
3743
3744         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3745         before calling rl_set_screen_size.
3746
3747 2019-02-27  Tom Tromey  <tromey@adacore.com>
3748
3749         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3750         define.
3751         * python/py-value.c: Remove Python 2.4 workaround.
3752         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3753         workaround.
3754         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3755         Python 2.4 workaround.
3756         * python/python-internal.h: Remove Python 2.4 comment.
3757         (Py_ssize_t): Don't define.
3758         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3759         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3760         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3761         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3762         * python/python.c (do_start_initialization): Remove Python 2.4
3763         workaround.
3764         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3765         (print_children): Remove Python 2.4 workaround.
3766         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3767         workaround.
3768         (CHARBUFFERPROC_NAME): Remove.
3769         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3770         Python 2.4 workaround.
3771
3772 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3773
3774         * NEWS: Note minimum Python version.
3775
3776 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3777
3778         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3779         code from these functions.  Remove corresponding ifdefs.  Use
3780         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3781         Remove gotos and target of gotos.
3782         (infpy_search_memory): Likewise.
3783
3784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3787         (hppa_gdbarch_init): Don't register deleted functions with
3788         gdbarch.
3789
3790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3793         (h8300_unwind_sp): Delete.
3794         (h8300_dummy_id): Delete.
3795         (h8300_gdbarch_init): Don't register deleted functions with
3796         gdbarch.
3797
3798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3799
3800         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3801         (ft32_unwind_pc): Delete.
3802         (ft32_unwind_sp): Delete.
3803         (ft32_gdbarch_init): Don't register deleted functions with
3804         gdbarch.
3805
3806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3807
3808         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3809         (frv_unwind_pc): Delete.
3810         (frv_unwind_sp): Delete.
3811         (frv_gdbarch_init): Don't register deleted functions with
3812         gdbarch.
3813
3814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3817         (riscv_unwind_pc): Delete.
3818         (riscv_unwind_sp): Delete.
3819         (riscv_gdbarch_init): Don't register deleted functions with
3820         gdbarch.
3821
3822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3825         (csky_unwind_pc): Delete.
3826         (csky_unwind_sp): Delete.
3827         (csky_gdbarch_init): Don't register deleted functions with
3828         gdbarch.
3829
3830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3833         (cris_unwind_pc): Delete.
3834         (cris_unwind_sp): Delete.
3835         (cris_gdbarch_init): Don't register deleted functions with
3836         gdbarch.
3837
3838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3841         (bfin_unwind_pc): Delete.
3842         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3843
3844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3847         (arm_unwind_pc): Delete.
3848         (arm_unwind_sp): Delete.
3849         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3850
3851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3852
3853         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3854         (arc_unwind_pc): Delete.
3855         (arc_unwind_sp): Delete.
3856         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3857
3858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3861         (alpha_unwind_pc): Delete.
3862         (alpha_gdbarch_init): Don't register deleted functions with
3863         gdbarch.
3864
3865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3866
3867         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3868         (aarch64_unwind_pc): Delete.
3869         (aarch64_unwind_sp): Delete.
3870         (aarch64_gdbarch_init): Don't register deleted functions with
3871         gdbarch.
3872
3873 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * gdbtypes.c (type_align): Don't consider static members when
3876         computing structure alignment.
3877
3878 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3879
3880         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3881         return 0 for other types.
3882         * arch-utils.c (default_type_align): Always return 0.
3883         * gdbarch.h: Regenerate.
3884         * gdbarch.sh (type_align): Extend comment.
3885         * gdbtypes.c (type_align): Add additional comments, always call
3886         gdbarch_type_align before applying the default rules.
3887         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3888         generic code will then apply a suitable default.
3889         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3890         types, return 0 for other types.
3891
3892 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3893
3894         * NEWS: Create a new section for the next release branch.
3895         Rename the section of the current branch, now that it has
3896         been cut.
3897
3898 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3899
3900         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3901         * version.in: Bump version to 8.3.50.DATE-git.
3902
3903 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3904
3905         * aix-thread.c (ptid_cmp): Remove unused variable.
3906         (get_signaled_thread): Likewise.
3907         (store_regs_user_thread): Likewise.
3908         (store_regs_kernel_thread): Likewise.
3909         (fetch_regs_kernel_thread): Remove shadowed variable.
3910
3911 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * features/riscv/32bit-cpu.xml: Add register numbers.
3914         * features/riscv/32bit-fpu.c: Regenerate.
3915         * features/riscv/32bit-fpu.xml: Add register numbers.
3916         * features/riscv/64bit-cpu.xml: Add register numbers.
3917         * features/riscv/64bit-fpu.c: Regenerate.
3918         * features/riscv/64bit-fpu.xml: Add register numbers.
3919
3920 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3921
3922         * NEWS: Mention two argument form of gdb.Value constructor.
3923         * python/py-value.c (convert_buffer_and_type_to_value): New
3924         function.
3925         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3926         Add support for handling an optional second argument.  Call
3927         convert_buffer_and_type_to_value as appropriate.
3928         * python/python-internal.h (Py_buffer_deleter): New struct.
3929         (Py_buffer_up): New typedef.
3930
3931 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3932
3933         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3934         instead of releasing ownership.
3935
3936 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3937
3938         * dwarf2read.c (open_and_init_dwp_file): Call
3939         elf_numsections instead of bfd_count_sections to initialize
3940         dwp_file->num_sections.
3941
3942 2019-02-25  Tom Tromey  <tromey@adacore.com>
3943
3944         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3945
3946 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3947
3948         * gcore.in: Add '--readnever' option when invoking GDB.
3949
3950 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3951
3952         * MAINTAINERS: Update my email address.
3953
3954 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3955
3956         * build-id.c (build_id_to_debug_bfd_1): New function.
3957         (build_id_to_debug_bfd): Look for separate debug file in
3958         sysroot.
3959
3960 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * gdbarch.sh: Update the copyright year range that is placed into
3963         generated files.
3964
3965 2019-02-22  Keith Seitz  <keiths@redhat.com>
3966
3967         PR symtab/23853
3968         * linespec.c (create_sals_line_offset): Search for the default
3969         symtab's filename instead of its fullname.
3970
3971 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3972
3973         * NEWS: Update style defaults.
3974
3975 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3976
3977         * main.c (captured_main_1): Disable styling in batch mode.
3978
3979 2019-02-20  Tom Tromey  <tom@tromey.com>
3980
3981         * symtab.c (symtab_symbol_info): Fix typos.
3982
3983 2019-02-20  Tom Tromey  <tromey@adacore.com>
3984
3985         * findcmd.c (_initialize_mem_search): Use upper case for
3986         metasyntactic variables.
3987
3988 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3989
3990         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3991         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3992
3993 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3994
3995         * top.h (source_file_name): Change to std::string.
3996         * top.c (source_file_name): Likewise.
3997         (command_line_input): Adjust.
3998         * cli/cli-script.c (script_from_file): Adjust.
3999
4000 2019-02-19  Tom Tromey  <tromey@adacore.com>
4001
4002         * ravenscar-thread.c
4003         (ravenscar_thread_target::update_thread_list): Don't call
4004         ada_build_task_list.
4005         * ada-lang.h (ada_build_task_list): Don't declare.
4006         * ada-tasks.c (struct ada_tasks_inferior_data)
4007         <task_list_valid_p>: Now bool.
4008         (read_known_tasks, ada_task_list_changed)
4009         (ada_tasks_invalidate_inferior_data): Update.
4010         (read_known_tasks_array): Return bool.
4011         (read_known_tasks_list): Likewise.
4012         (read_known_tasks): Return void.
4013         (ada_build_task_list): Now static.
4014
4015 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4016
4017         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4018         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4019
4020 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4021
4022         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4023         variant for ada_tasks_pspace_data_handle and
4024         ada_tasks_inferior_data_handle.
4025         (ada_tasks_pspace_data_cleanup): New function.
4026         (ada_tasks_inferior_data_cleanup): New function.
4027
4028 2019-02-17  Tom Tromey  <tom@tromey.com>
4029
4030         * macrotab.h (macro_source_fullname): Return a std::string.
4031         * macrotab.c (macro_include, check_for_redefinition)
4032         (macro_undef, macro_lookup_definition, foreach_macro)
4033         (foreach_macro_in_scope): Update.
4034         (macro_source_fullname): Return a std::string.
4035         * macrocmd.c (show_pp_source_pos): Update.
4036
4037 2019-02-17  Tom Tromey  <tom@tromey.com>
4038
4039         * macrocmd.c (show_pp_source_pos): Style the file names.
4040
4041 2019-02-17  Tom Tromey  <tom@tromey.com>
4042
4043         PR tui/24197:
4044         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4045
4046 2019-02-17  Tom Tromey  <tom@tromey.com>
4047
4048         * ada-lang.c (user_select_syms): Use filtered printing.
4049         * utils.c (wrap_style): New global.
4050         (desired_style): Remove.
4051         (emit_style_escape): Add stream parameter.
4052         (set_output_style, reset_terminal_style, prompt_for_continue):
4053         Update.
4054         (flush_wrap_buffer): Only flush gdb_stdout.
4055         (wrap_here): Set wrap_style.
4056         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4057         treat escape sequences as a character.  Change when wrap buffer is
4058         flushed.
4059         (fputs_styled): Do not set the output style when the default is
4060         requested.
4061         * ui-style.h (struct ui_file_style) <is_default>: New method.
4062         * source.c (print_source_lines_base): Emit escape sequences in one
4063         piece.
4064
4065 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4066
4067         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4068         integers and enumeration types.
4069
4070 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4071
4072         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4073         instead of lookup_symbol_in_language
4074         (do_exact_match): New function.
4075         (ada_get_symbol_name_matcher): Return do_exact_match when
4076         doing a verbatim match.
4077
4078 2019-02-15  Tom Tromey  <tromey@adacore.com>
4079
4080         * ravenscar-thread.c (ravenscar_thread_target::resume)
4081         (ravenscar_thread_target::wait): Special case wildcard requests.
4082
4083 2019-02-15  Tom Tromey  <tromey@adacore.com>
4084
4085         * ravenscar-thread.c (base_ptid): Remove.
4086         (struct ravenscar_thread_target) <close>: New method.
4087         <m_base_ptid>: New member.
4088         <update_inferior_ptid, active_task, task_is_currently_active,
4089         runtime_initialized>: Declare methods.
4090         <ravenscar_thread_target>: Add constructor.
4091         (ravenscar_thread_target::task_is_currently_active)
4092         (ravenscar_thread_target::update_inferior_ptid)
4093         (ravenscar_runtime_initialized): Rename.  Now methods.
4094         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4095         (ravenscar_thread_target::update_thread_list): Update.
4096         (ravenscar_thread_target::active_task): Now method.
4097         (ravenscar_thread_target::store_registers)
4098         (ravenscar_thread_target::prepare_to_store)
4099         (ravenscar_thread_target::prepare_to_store)
4100         (ravenscar_thread_target::mourn_inferior): Update.
4101         (ravenscar_inferior_created): Use "new" to create target.
4102         (ravenscar_thread_target::get_ada_task_ptid): Update.
4103         (_initialize_ravenscar): Don't initialize base_ptid.
4104         (ravenscar_ops): Remove global.
4105
4106 2019-02-15  Tom Tromey  <tromey@adacore.com>
4107
4108         * target.h (push_target): Declare new overload.
4109         * target.c (push_target): New overload, taking an rvalue reference.
4110         * remote.c (remote_target::open_1): Use push_target overload.
4111         * corelow.c (core_target_open): Use push_target overload.
4112
4113 2019-02-15  Tom Tromey  <tromey@adacore.com>
4114
4115         * ravenscar-thread.c (is_ravenscar_task)
4116         (ravenscar_task_is_currently_active): Return bool.
4117         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4118         (_initialize_ravenscar): Remove "(void)".
4119         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4120         Return bool.
4121
4122 2019-02-15  Tom Tromey  <tromey@adacore.com>
4123
4124         * ravenscar-thread.c (ravenscar_runtime_initializer)
4125         (has_ravenscar_runtime, get_running_thread_id)
4126         (ravenscar_thread_target::resume): Fix indentation.
4127
4128 2019-02-15  Tom Tromey  <tromey@adacore.com>
4129
4130         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4131         from ravenscar_arch_ops.
4132         (sparc_ravenscar_ops::fetch_registers)
4133         (sparc_ravenscar_ops::store_registers): Now methods.
4134         (sparc_ravenscar_prepare_to_store): Remove.
4135         (sparc_ravenscar_ops): Redefine.
4136         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4137         methods and destructor.  Remove members.
4138         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4139         (ravenscar_thread_target::store_registers)
4140         (ravenscar_thread_target::prepare_to_store): Update.
4141         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4142         Remove.
4143         (struct ppc_ravenscar_powerpc_ops): Derive from
4144         ravenscar_arch_ops.
4145         (ppc_ravenscar_powerpc_ops::fetch_registers)
4146         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4147         (ppc_ravenscar_powerpc_ops): Redefine.
4148         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4149         (ppc_ravenscar_e500_ops::fetch_registers)
4150         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4151         (ppc_ravenscar_e500_ops): Redefine.
4152         * aarch64-ravenscar-thread.c
4153         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4154         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4155         (aarch64_ravenscar_fetch_registers)
4156         (aarch64_ravenscar_store_registers): Now methods.
4157         (aarch64_ravenscar_ops): Redefine.
4158
4159 2019-02-15  Tom Tromey  <tromey@adacore.com>
4160
4161         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4162         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4163         (ravenscar_thread_target::stopped_by_watchpoint)
4164         (ravenscar_thread_target::stopped_data_address)
4165         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4166
4167 2019-02-15  Tom Tromey  <tromey@adacore.com>
4168
4169         * ravenscar-thread.c: Fix some typos.
4170
4171 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4172             Tom Tromey  <tromey@adacore.com>
4173
4174         * ada-lang.c (ada_exception_sal): Change addr_string to a
4175         std::string.
4176         (create_ada_exception_catchpoint): Update.
4177
4178 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4179             Tom Tromey  <tromey@adacore.com>
4180
4181         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4182         (bp_location_ops): Remove.
4183         (base_breakpoint_allocate_location): Update.
4184         (free_bp_location): Update.
4185         * ada-lang.c (class ada_catchpoint_location)
4186         <ada_catchpoint_location>: Remove ops parameter.
4187         (ada_catchpoint_location_dtor): Remove.
4188         (ada_catchpoint_location_ops): Remove.
4189         (allocate_location_exception): Update.
4190         * breakpoint.h (struct bp_location_ops): Remove.
4191         (class bp_location) <bp_location>: Remove bp_location_ops
4192         parameter.
4193         <~bp_location>: Add destructor.
4194         <ops>: Remove.
4195
4196 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4197             Pedro Alves  <palves@redhat.com>
4198
4199         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4200         'PATH_MAX'.
4201
4202 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4203             Samuel Thibault  <samuel.thibault@gnu.org>
4204             Thomas Schwinge  <thomas@codesourcery.com>
4205
4206         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4207         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4208
4209 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4210
4211         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4212         (check_empty): Use "const char *".
4213
4214         * gnu-nat.c (gnu_nat_target::detach): Instead of
4215         'detach_inferior (pid)' call
4216         'detach_inferior (find_inferior_pid (pid))'.
4217
4218         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4219         'nat/fork-inferior.o'.
4220         * gnu-nat.c: #include "nat/fork-inferior.h".
4221
4222         * gnu-nat.c (gnu_nat_target::detach): Instead of
4223         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4224         * gnu-nat.h: #include "inf-child.h".
4225         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4226         'i386_gnu_nat_target::fetch_registers'.
4227         (gnu_store_registers): Rename/move to
4228         'i386_gnu_nat_target::store_registers'.
4229
4230         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4231         * gnu-nat.h (mach_thread_info): New function.
4232         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4233
4234         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4235
4236 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4237
4238         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4239
4240 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4241
4242         * windows-nat.c (windows_add_thread): Add new parameter
4243         "main_thread_p" with default value set to false.  Update
4244         function documentation as well as all callers.
4245         (windows_delete_thread): Likewise.
4246         (fake_create_process): Update call to windows_add_thread.
4247         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4248         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4249         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4250         call to windows_delete_thread.
4251
4252 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4253
4254         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4255
4256 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4257
4258         * symfile.c (find_separate_debug_file): Use canonical path of
4259         sysroot with child_path instead of gdb_sysroot if it is valid.
4260
4261 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4262
4263         * symfile.c (find_separate_debug_file): Use child_path to
4264         determine if an object file is under a sysroot.
4265
4266 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4267
4268         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4269         unittests/child-path-selftests.c.
4270         * common/pathstuff.c (child_path): New function.
4271         * common/pathstuff.h (child_path): New prototype.
4272         * unittests/child-path-selftests.c: New file.
4273
4274 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4275
4276         * symfile.c (find_separate_debug_file): Look for separate debug
4277         files in debug directories under the sysroot.
4278
4279 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4280
4281         * symtab.h (struct minimal_symbol data_p): New const method.
4282         (struct minimal_symbol text_p): Likewise.
4283         * symtab.c (output_source_filename): Use file name style
4284         to print file name.
4285         (print_symbol_info): Likewise.
4286         (print_msymbol_info): Use address style to print addresses.
4287         Use function name style to print executable text symbols.
4288         (expand_symtab_containing_pc): Use data_p.
4289         (find_pc_sect_compunit_symtab): Likewise.
4290
4291 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4292
4293         * breakpoint.c (describe_other_breakpoints): Use address style
4294         to print addresses.
4295         (say_where): Likewise.
4296
4297 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4298
4299         * ada-typeprint.c (print_func_type): Print function name
4300         style to print function name.
4301         * c-typeprint.c (c_print_type_1): Likewise.
4302
4303 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4304
4305         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4306         for execve.
4307
4308 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4309
4310         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4311         type_stack.
4312
4313 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4314
4315         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4316         TYPE_CODE_REF types.
4317
4318 2019-02-08  Jim Wilson  <jimw@sifive.com>
4319
4320         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4321         (riscv_linux_fregset): New.
4322         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4323
4324 2019-02-07  Tom Tromey  <tom@tromey.com>
4325
4326         * thread.c (thread_cancel_execution_command): Update.
4327         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4328         methods.
4329         (struct thread_fsm_ops): Remove.
4330         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4331         (thread_fsm_should_stop, thread_fsm_return_value)
4332         (thread_fsm_set_finished, thread_fsm_finished_p)
4333         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4334         Don't declare.
4335         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4336         * infrun.c (clear_proceed_status_thread)
4337         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4338         (print_stop_event): Update.
4339         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4340         Add constructor.
4341         (step_command_fsm_ops): Remove.
4342         (new_step_command_fsm): Remove.
4343         (step_1): Update.
4344         (step_command_fsm::should_stop): Rename from
4345         step_command_fsm_should_stop.
4346         (step_command_fsm::clean_up): Rename from
4347         step_command_fsm_clean_up.
4348         (step_command_fsm::do_async_reply_reason): Rename from
4349         step_command_fsm_async_reply_reason.
4350         (struct until_next_fsm): Inherit from thread_fsm.  Add
4351         constructor.
4352         (until_next_fsm_ops): Remove.
4353         (new_until_next_fsm): Remove.
4354         (until_next_fsm::should_stop): Rename from
4355         until_next_fsm_should_stop.
4356         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4357         (until_next_fsm::do_async_reply_reason): Rename from
4358         until_next_fsm_async_reply_reason.
4359         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4360         constructor.  Change type of breakpoint.
4361         (finish_command_fsm_ops): Remove.
4362         (new_finish_command_fsm): Remove.
4363         (finish_command_fsm::should_stop): Rename from
4364         finish_command_fsm_should_stop.
4365         (finish_command_fsm::clean_up): Rename from
4366         finish_command_fsm_clean_up.
4367         (finish_command_fsm::return_value): Rename from
4368         finish_command_fsm_return_value.
4369         (finish_command_fsm::do_async_reply_reason): Rename from
4370         finish_command_fsm_async_reply_reason.
4371         (finish_command): Update.
4372         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4373         Add constructor.
4374         (call_thread_fsm_ops): Remove.
4375         (call_thread_fsm::call_thread_fsm): Rename from
4376         new_call_thread_fsm.
4377         (call_thread_fsm::should_stop): Rename from
4378         call_thread_fsm_should_stop.
4379         (call_thread_fsm::should_notify_stop): Rename from
4380         call_thread_fsm_should_notify_stop.
4381         (run_inferior_call, call_function_by_hand_dummy): Update.
4382         * cli/cli-interp.c (should_print_stop_to_console): Update.
4383         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4384         Add constructor.  Change type of location_breakpoint,
4385         caller_breakpoint.
4386         (until_break_fsm_ops): Remove.
4387         (new_until_break_fsm): Remove.
4388         (until_break_fsm::should_stop): Rename from
4389         until_break_fsm_should_stop.
4390         (until_break_fsm::clean_up): Rename from
4391         until_break_fsm_clean_up.
4392         (until_break_fsm::do_async_reply_reason): Rename from
4393         until_break_fsm_async_reply_reason.
4394         (until_break_command): Update.
4395         * thread-fsm.c: Remove.
4396         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4397
4398 2019-02-07  Tom Tromey  <tom@tromey.com>
4399
4400         * yy-remap.h: Add include guard.
4401         * xtensa-tdep.h: Add include guard.
4402         * xcoffread.h: Rename include guard.
4403         * varobj-iter.h: Add include guard.
4404         * tui/tui.h: Rename include guard.
4405         * tui/tui-winsource.h: Rename include guard.
4406         * tui/tui-wingeneral.h: Rename include guard.
4407         * tui/tui-windata.h: Rename include guard.
4408         * tui/tui-win.h: Rename include guard.
4409         * tui/tui-stack.h: Rename include guard.
4410         * tui/tui-source.h: Rename include guard.
4411         * tui/tui-regs.h: Rename include guard.
4412         * tui/tui-out.h: Rename include guard.
4413         * tui/tui-layout.h: Rename include guard.
4414         * tui/tui-io.h: Rename include guard.
4415         * tui/tui-hooks.h: Rename include guard.
4416         * tui/tui-file.h: Rename include guard.
4417         * tui/tui-disasm.h: Rename include guard.
4418         * tui/tui-data.h: Rename include guard.
4419         * tui/tui-command.h: Rename include guard.
4420         * tic6x-tdep.h: Add include guard.
4421         * target/waitstatus.h: Rename include guard.
4422         * target/wait.h: Rename include guard.
4423         * target/target.h: Rename include guard.
4424         * target/resume.h: Rename include guard.
4425         * target-float.h: Rename include guard.
4426         * stabsread.h: Add include guard.
4427         * rs6000-tdep.h: Add include guard.
4428         * riscv-fbsd-tdep.h: Add include guard.
4429         * regformats/regdef.h: Rename include guard.
4430         * record.h: Rename include guard.
4431         * python/python.h: Rename include guard.
4432         * python/python-internal.h: Rename include guard.
4433         * python/py-stopevent.h: Rename include guard.
4434         * python/py-ref.h: Rename include guard.
4435         * python/py-record.h: Rename include guard.
4436         * python/py-record-full.h: Rename include guard.
4437         * python/py-record-btrace.h: Rename include guard.
4438         * python/py-instruction.h: Rename include guard.
4439         * python/py-events.h: Rename include guard.
4440         * python/py-event.h: Rename include guard.
4441         * procfs.h: Add include guard.
4442         * proc-utils.h: Add include guard.
4443         * p-lang.h: Add include guard.
4444         * or1k-tdep.h: Rename include guard.
4445         * observable.h: Rename include guard.
4446         * nto-tdep.h: Rename include guard.
4447         * nat/x86-linux.h: Rename include guard.
4448         * nat/x86-linux-dregs.h: Rename include guard.
4449         * nat/x86-gcc-cpuid.h: Add include guard.
4450         * nat/x86-dregs.h: Rename include guard.
4451         * nat/x86-cpuid.h: Rename include guard.
4452         * nat/ppc-linux.h: Rename include guard.
4453         * nat/mips-linux-watch.h: Rename include guard.
4454         * nat/linux-waitpid.h: Rename include guard.
4455         * nat/linux-ptrace.h: Rename include guard.
4456         * nat/linux-procfs.h: Rename include guard.
4457         * nat/linux-osdata.h: Rename include guard.
4458         * nat/linux-nat.h: Rename include guard.
4459         * nat/linux-namespaces.h: Rename include guard.
4460         * nat/linux-btrace.h: Rename include guard.
4461         * nat/glibc_thread_db.h: Rename include guard.
4462         * nat/gdb_thread_db.h: Rename include guard.
4463         * nat/gdb_ptrace.h: Rename include guard.
4464         * nat/fork-inferior.h: Rename include guard.
4465         * nat/amd64-linux-siginfo.h: Rename include guard.
4466         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4467         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4468         * nat/aarch64-linux.h: Rename include guard.
4469         * nat/aarch64-linux-hw-point.h: Rename include guard.
4470         * mn10300-tdep.h: Add include guard.
4471         * mips-linux-tdep.h: Add include guard.
4472         * mi/mi-parse.h: Rename include guard.
4473         * mi/mi-out.h: Rename include guard.
4474         * mi/mi-main.h: Rename include guard.
4475         * mi/mi-interp.h: Rename include guard.
4476         * mi/mi-getopt.h: Rename include guard.
4477         * mi/mi-console.h: Rename include guard.
4478         * mi/mi-common.h: Rename include guard.
4479         * mi/mi-cmds.h: Rename include guard.
4480         * mi/mi-cmd-break.h: Rename include guard.
4481         * m2-lang.h: Add include guard.
4482         * location.h: Rename include guard.
4483         * linux-record.h: Rename include guard.
4484         * linux-nat.h: Add include guard.
4485         * linux-fork.h: Add include guard.
4486         * i386-darwin-tdep.h: Rename include guard.
4487         * hppa-linux-offsets.h: Add include guard.
4488         * guile/guile.h: Rename include guard.
4489         * guile/guile-internal.h: Rename include guard.
4490         * gnu-nat.h: Rename include guard.
4491         * gdb-stabs.h: Rename include guard.
4492         * frv-tdep.h: Add include guard.
4493         * f-lang.h: Add include guard.
4494         * event-loop.h: Add include guard.
4495         * darwin-nat.h: Rename include guard.
4496         * cp-abi.h: Rename include guard.
4497         * config/sparc/nm-sol2.h: Rename include guard.
4498         * config/nm-nto.h: Rename include guard.
4499         * config/nm-linux.h: Add include guard.
4500         * config/i386/nm-i386gnu.h: Rename include guard.
4501         * config/djgpp/nl_types.h: Rename include guard.
4502         * config/djgpp/langinfo.h: Rename include guard.
4503         * compile/gcc-cp-plugin.h: Add include guard.
4504         * compile/gcc-c-plugin.h: Add include guard.
4505         * compile/compile.h: Rename include guard.
4506         * compile/compile-object-run.h: Rename include guard.
4507         * compile/compile-object-load.h: Rename include guard.
4508         * compile/compile-internal.h: Rename include guard.
4509         * compile/compile-cplus.h: Rename include guard.
4510         * compile/compile-c.h: Rename include guard.
4511         * common/xml-utils.h: Rename include guard.
4512         * common/x86-xstate.h: Rename include guard.
4513         * common/version.h: Rename include guard.
4514         * common/vec.h: Rename include guard.
4515         * common/tdesc.h: Rename include guard.
4516         * common/selftest.h: Rename include guard.
4517         * common/scoped_restore.h: Rename include guard.
4518         * common/scoped_mmap.h: Rename include guard.
4519         * common/scoped_fd.h: Rename include guard.
4520         * common/safe-iterator.h: Rename include guard.
4521         * common/run-time-clock.h: Rename include guard.
4522         * common/refcounted-object.h: Rename include guard.
4523         * common/queue.h: Rename include guard.
4524         * common/ptid.h: Rename include guard.
4525         * common/print-utils.h: Rename include guard.
4526         * common/preprocessor.h: Rename include guard.
4527         * common/pathstuff.h: Rename include guard.
4528         * common/observable.h: Rename include guard.
4529         * common/netstuff.h: Rename include guard.
4530         * common/job-control.h: Rename include guard.
4531         * common/host-defs.h: Rename include guard.
4532         * common/gdb_wait.h: Rename include guard.
4533         * common/gdb_vecs.h: Rename include guard.
4534         * common/gdb_unlinker.h: Rename include guard.
4535         * common/gdb_unique_ptr.h: Rename include guard.
4536         * common/gdb_tilde_expand.h: Rename include guard.
4537         * common/gdb_sys_time.h: Rename include guard.
4538         * common/gdb_string_view.h: Rename include guard.
4539         * common/gdb_splay_tree.h: Rename include guard.
4540         * common/gdb_setjmp.h: Rename include guard.
4541         * common/gdb_ref_ptr.h: Rename include guard.
4542         * common/gdb_optional.h: Rename include guard.
4543         * common/gdb_locale.h: Rename include guard.
4544         * common/gdb_assert.h: Rename include guard.
4545         * common/filtered-iterator.h: Rename include guard.
4546         * common/filestuff.h: Rename include guard.
4547         * common/fileio.h: Rename include guard.
4548         * common/environ.h: Rename include guard.
4549         * common/common-utils.h: Rename include guard.
4550         * common/common-types.h: Rename include guard.
4551         * common/common-regcache.h: Rename include guard.
4552         * common/common-inferior.h: Rename include guard.
4553         * common/common-gdbthread.h: Rename include guard.
4554         * common/common-exceptions.h: Rename include guard.
4555         * common/common-defs.h: Rename include guard.
4556         * common/common-debug.h: Rename include guard.
4557         * common/cleanups.h: Rename include guard.
4558         * common/buffer.h: Rename include guard.
4559         * common/btrace-common.h: Rename include guard.
4560         * common/break-common.h: Rename include guard.
4561         * cli/cli-utils.h: Rename include guard.
4562         * cli/cli-style.h: Rename include guard.
4563         * cli/cli-setshow.h: Rename include guard.
4564         * cli/cli-script.h: Rename include guard.
4565         * cli/cli-interp.h: Rename include guard.
4566         * cli/cli-decode.h: Rename include guard.
4567         * cli/cli-cmds.h: Rename include guard.
4568         * charset-list.h: Add include guard.
4569         * buildsym-legacy.h: Rename include guard.
4570         * bfin-tdep.h: Add include guard.
4571         * ax.h: Rename include guard.
4572         * arm-linux-tdep.h: Add include guard.
4573         * arm-fbsd-tdep.h: Add include guard.
4574         * arch/xtensa.h: Rename include guard.
4575         * arch/tic6x.h: Add include guard.
4576         * arch/i386.h: Add include guard.
4577         * arch/arm.h: Rename include guard.
4578         * arch/arm-linux.h: Rename include guard.
4579         * arch/arm-get-next-pcs.h: Rename include guard.
4580         * arch/amd64.h: Add include guard.
4581         * arch/aarch64-insn.h: Rename include guard.
4582         * arch-utils.h: Rename include guard.
4583         * annotate.h: Add include guard.
4584         * amd64-darwin-tdep.h: Rename include guard.
4585         * aarch64-linux-tdep.h: Add include guard.
4586         * aarch64-fbsd-tdep.h: Add include guard.
4587         * aarch32-linux-nat.h: Add include guard.
4588
4589 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4590
4591         * macrotab.c (macro_define_internal): New function that
4592         factorizes macro_define_object_internal and macro_define_function
4593         code.
4594         (macro_define_object_internal): Use macro_define_internal.
4595         (macro_define_function): Likewise.
4596
4597 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4598
4599         * macrocmd.c (extract_identifier): Return
4600         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4601         callers.
4602
4603 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4604
4605         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4606
4607 2019-02-05  Tom Tromey  <tom@tromey.com>
4608
4609         * target.c (target_stack::unpush): Move assertion earlier.
4610
4611 2019-01-30  Tom Tromey  <tom@tromey.com>
4612
4613         PR python/23615:
4614         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4615         (gdbpy_parse_and_eval): Likewise.
4616         * python/python-internal.h (gdbpy_allow_threads): New class.
4617
4618 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4619
4620         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4621         (aarch64_fbsd_fpregmap): Move earlier.
4622         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4623         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4624         instead of individual calls to trad_frame_set_reg_addr.
4625         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4626         earlier.
4627         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4628         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4629         instead of individual calls to trad_frame_set_reg_addr.
4630
4631 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4632
4633         * CONTRIBUTE: Replace contribution list with wiki link.
4634
4635 2019-01-25  Tom Tromey  <tom@tromey.com>
4636
4637         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4638
4639 2019-01-25  Tom Tromey  <tom@tromey.com>
4640
4641         * xtensa-linux-nat.c: Fix common/ includes.
4642         * xml-support.h: Fix common/ includes.
4643         * xml-support.c: Fix common/ includes.
4644         * x86-linux-nat.c: Fix common/ includes.
4645         * windows-nat.c: Fix common/ includes.
4646         * varobj.h: Fix common/ includes.
4647         * varobj.c: Fix common/ includes.
4648         * value.c: Fix common/ includes.
4649         * valops.c: Fix common/ includes.
4650         * utils.c: Fix common/ includes.
4651         * unittests/xml-utils-selftests.c: Fix common/ includes.
4652         * unittests/utils-selftests.c: Fix common/ includes.
4653         * unittests/unpack-selftests.c: Fix common/ includes.
4654         * unittests/tracepoint-selftests.c: Fix common/ includes.
4655         * unittests/style-selftests.c: Fix common/ includes.
4656         * unittests/string_view-selftests.c: Fix common/ includes.
4657         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4658         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4659         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4660         * unittests/rsp-low-selftests.c: Fix common/ includes.
4661         * unittests/parse-connection-spec-selftests.c: Fix common/
4662         includes.
4663         * unittests/optional-selftests.c: Fix common/ includes.
4664         * unittests/offset-type-selftests.c: Fix common/ includes.
4665         * unittests/observable-selftests.c: Fix common/ includes.
4666         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4667         * unittests/memrange-selftests.c: Fix common/ includes.
4668         * unittests/memory-map-selftests.c: Fix common/ includes.
4669         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4670         * unittests/function-view-selftests.c: Fix common/ includes.
4671         * unittests/environ-selftests.c: Fix common/ includes.
4672         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4673         * unittests/common-utils-selftests.c: Fix common/ includes.
4674         * unittests/cli-utils-selftests.c: Fix common/ includes.
4675         * unittests/array-view-selftests.c: Fix common/ includes.
4676         * ui-file.c: Fix common/ includes.
4677         * tui/tui-io.c: Fix common/ includes.
4678         * tracepoint.h: Fix common/ includes.
4679         * tracepoint.c: Fix common/ includes.
4680         * tracefile-tfile.c: Fix common/ includes.
4681         * top.h: Fix common/ includes.
4682         * top.c: Fix common/ includes.
4683         * thread.c: Fix common/ includes.
4684         * target/waitstatus.h: Fix common/ includes.
4685         * target/waitstatus.c: Fix common/ includes.
4686         * target.h: Fix common/ includes.
4687         * target.c: Fix common/ includes.
4688         * target-memory.c: Fix common/ includes.
4689         * target-descriptions.c: Fix common/ includes.
4690         * symtab.h: Fix common/ includes.
4691         * symfile.c: Fix common/ includes.
4692         * stap-probe.c: Fix common/ includes.
4693         * spu-linux-nat.c: Fix common/ includes.
4694         * sparc-nat.c: Fix common/ includes.
4695         * source.c: Fix common/ includes.
4696         * solib.c: Fix common/ includes.
4697         * solib-target.c: Fix common/ includes.
4698         * ser-unix.c: Fix common/ includes.
4699         * ser-tcp.c: Fix common/ includes.
4700         * ser-pipe.c: Fix common/ includes.
4701         * ser-base.c: Fix common/ includes.
4702         * selftest-arch.c: Fix common/ includes.
4703         * s12z-tdep.c: Fix common/ includes.
4704         * rust-exp.y: Fix common/ includes.
4705         * rs6000-aix-tdep.c: Fix common/ includes.
4706         * riscv-tdep.c: Fix common/ includes.
4707         * remote.c: Fix common/ includes.
4708         * remote-notif.h: Fix common/ includes.
4709         * remote-fileio.h: Fix common/ includes.
4710         * remote-fileio.c: Fix common/ includes.
4711         * regcache.h: Fix common/ includes.
4712         * regcache.c: Fix common/ includes.
4713         * record-btrace.c: Fix common/ includes.
4714         * python/python.c: Fix common/ includes.
4715         * python/py-type.c: Fix common/ includes.
4716         * python/py-inferior.c: Fix common/ includes.
4717         * progspace.h: Fix common/ includes.
4718         * producer.c: Fix common/ includes.
4719         * procfs.c: Fix common/ includes.
4720         * proc-api.c: Fix common/ includes.
4721         * printcmd.c: Fix common/ includes.
4722         * ppc-linux-nat.c: Fix common/ includes.
4723         * parser-defs.h: Fix common/ includes.
4724         * osdata.c: Fix common/ includes.
4725         * obsd-nat.c: Fix common/ includes.
4726         * nat/x86-linux.c: Fix common/ includes.
4727         * nat/x86-linux-dregs.c: Fix common/ includes.
4728         * nat/x86-dregs.h: Fix common/ includes.
4729         * nat/x86-dregs.c: Fix common/ includes.
4730         * nat/ppc-linux.c: Fix common/ includes.
4731         * nat/mips-linux-watch.h: Fix common/ includes.
4732         * nat/mips-linux-watch.c: Fix common/ includes.
4733         * nat/linux-waitpid.c: Fix common/ includes.
4734         * nat/linux-ptrace.h: Fix common/ includes.
4735         * nat/linux-ptrace.c: Fix common/ includes.
4736         * nat/linux-procfs.c: Fix common/ includes.
4737         * nat/linux-personality.c: Fix common/ includes.
4738         * nat/linux-osdata.c: Fix common/ includes.
4739         * nat/linux-namespaces.c: Fix common/ includes.
4740         * nat/linux-btrace.h: Fix common/ includes.
4741         * nat/linux-btrace.c: Fix common/ includes.
4742         * nat/fork-inferior.c: Fix common/ includes.
4743         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4744         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4745         * nat/aarch64-linux.c: Fix common/ includes.
4746         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4747         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4748         * namespace.h: Fix common/ includes.
4749         * mips-linux-tdep.c: Fix common/ includes.
4750         * minsyms.c: Fix common/ includes.
4751         * mi/mi-parse.h: Fix common/ includes.
4752         * mi/mi-main.c: Fix common/ includes.
4753         * mi/mi-cmd-env.c: Fix common/ includes.
4754         * memrange.h: Fix common/ includes.
4755         * memattr.c: Fix common/ includes.
4756         * maint.h: Fix common/ includes.
4757         * maint.c: Fix common/ includes.
4758         * main.c: Fix common/ includes.
4759         * machoread.c: Fix common/ includes.
4760         * location.c: Fix common/ includes.
4761         * linux-thread-db.c: Fix common/ includes.
4762         * linux-nat.c: Fix common/ includes.
4763         * linux-fork.c: Fix common/ includes.
4764         * inline-frame.c: Fix common/ includes.
4765         * infrun.c: Fix common/ includes.
4766         * inflow.c: Fix common/ includes.
4767         * inferior.h: Fix common/ includes.
4768         * inferior.c: Fix common/ includes.
4769         * infcmd.c: Fix common/ includes.
4770         * inf-ptrace.c: Fix common/ includes.
4771         * inf-child.c: Fix common/ includes.
4772         * ia64-linux-nat.c: Fix common/ includes.
4773         * i387-tdep.c: Fix common/ includes.
4774         * i386-tdep.c: Fix common/ includes.
4775         * i386-linux-tdep.c: Fix common/ includes.
4776         * i386-linux-nat.c: Fix common/ includes.
4777         * i386-go32-tdep.c: Fix common/ includes.
4778         * i386-fbsd-tdep.c: Fix common/ includes.
4779         * i386-fbsd-nat.c: Fix common/ includes.
4780         * guile/scm-type.c: Fix common/ includes.
4781         * guile/guile.c: Fix common/ includes.
4782         * go32-nat.c: Fix common/ includes.
4783         * gnu-nat.c: Fix common/ includes.
4784         * gdbthread.h: Fix common/ includes.
4785         * gdbarch-selftests.c: Fix common/ includes.
4786         * gdb_usleep.c: Fix common/ includes.
4787         * gdb_select.h: Fix common/ includes.
4788         * gdb_bfd.c: Fix common/ includes.
4789         * gcore.c: Fix common/ includes.
4790         * fork-child.c: Fix common/ includes.
4791         * findvar.c: Fix common/ includes.
4792         * fbsd-nat.c: Fix common/ includes.
4793         * event-top.c: Fix common/ includes.
4794         * event-loop.c: Fix common/ includes.
4795         * dwarf2read.c: Fix common/ includes.
4796         * dwarf2loc.c: Fix common/ includes.
4797         * dwarf2-frame.c: Fix common/ includes.
4798         * dwarf-index-cache.c: Fix common/ includes.
4799         * dtrace-probe.c: Fix common/ includes.
4800         * disasm-selftests.c: Fix common/ includes.
4801         * defs.h: Fix common/ includes.
4802         * csky-tdep.c: Fix common/ includes.
4803         * cp-valprint.c: Fix common/ includes.
4804         * cp-support.h: Fix common/ includes.
4805         * cp-support.c: Fix common/ includes.
4806         * corelow.c: Fix common/ includes.
4807         * completer.h: Fix common/ includes.
4808         * completer.c: Fix common/ includes.
4809         * compile/compile.c: Fix common/ includes.
4810         * compile/compile-loc2c.c: Fix common/ includes.
4811         * compile/compile-cplus-types.c: Fix common/ includes.
4812         * compile/compile-cplus-symbols.c: Fix common/ includes.
4813         * command.h: Fix common/ includes.
4814         * cli/cli-dump.c: Fix common/ includes.
4815         * cli/cli-cmds.c: Fix common/ includes.
4816         * charset.c: Fix common/ includes.
4817         * build-id.c: Fix common/ includes.
4818         * btrace.h: Fix common/ includes.
4819         * btrace.c: Fix common/ includes.
4820         * breakpoint.h: Fix common/ includes.
4821         * breakpoint.c: Fix common/ includes.
4822         * ax.h:
4823         (enum agent_op): Fix common/ includes.
4824         * ax-general.c (struct aop_map): Fix common/ includes.
4825         * ax-gdb.c: Fix common/ includes.
4826         * auxv.c: Fix common/ includes.
4827         * auto-load.c: Fix common/ includes.
4828         * arm-tdep.c: Fix common/ includes.
4829         * arch/riscv.c: Fix common/ includes.
4830         * arch/ppc-linux-common.c: Fix common/ includes.
4831         * arch/i386.c: Fix common/ includes.
4832         * arch/arm.c: Fix common/ includes.
4833         * arch/arm-linux.c: Fix common/ includes.
4834         * arch/arm-get-next-pcs.c: Fix common/ includes.
4835         * arch/amd64.c: Fix common/ includes.
4836         * arch/aarch64.c: Fix common/ includes.
4837         * arch/aarch64-insn.c: Fix common/ includes.
4838         * arch-utils.c: Fix common/ includes.
4839         * amd64-windows-tdep.c: Fix common/ includes.
4840         * amd64-tdep.c: Fix common/ includes.
4841         * amd64-sol2-tdep.c: Fix common/ includes.
4842         * amd64-obsd-tdep.c: Fix common/ includes.
4843         * amd64-nbsd-tdep.c: Fix common/ includes.
4844         * amd64-linux-tdep.c: Fix common/ includes.
4845         * amd64-linux-nat.c: Fix common/ includes.
4846         * amd64-fbsd-tdep.c: Fix common/ includes.
4847         * amd64-fbsd-nat.c: Fix common/ includes.
4848         * amd64-dicos-tdep.c: Fix common/ includes.
4849         * amd64-darwin-tdep.c: Fix common/ includes.
4850         * agent.c: Fix common/ includes.
4851         * ada-lang.h: Fix common/ includes.
4852         * ada-lang.c: Fix common/ includes.
4853         * aarch64-tdep.c: Fix common/ includes.
4854
4855 2019-01-25  Tom Tromey  <tom@tromey.com>
4856
4857         * common/create-version.sh: Use common/version.h.
4858
4859 2019-01-24  Pedro Alves  <palves@redhat.com>
4860
4861         * infrun.c (signal_stop, signal_print, signal_program)
4862         (signal_catch, signal_pass): Now arrays instead of pointers.
4863         (update_signals_program_target, do_target_resume)
4864         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4865         * linux-nat.c (linux_nat_target::pass_signals)
4866         (linux_nat_target::create_inferior, linux_nat_target::attach):
4867         Adjust.
4868         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4869         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4870         * procfs.c (procfs_target::pass_signals): Adjust.
4871         * record-full.c (record_full_target::resume): Adjust.
4872         * remote.c (remote_target::pass_signals)
4873         (remote_target::program_signals): Adjust.
4874         * target-debug.h (target_debug_print_signals): Now takes a
4875         gdb::array_view as parameter.  Adjust.
4876         * target.h (target_ops) <pass_signals, program_signals>: Replace
4877         pointer and length parameters with gdb::array_view.
4878         (target_pass_signals, target_program_signals): Likewise.
4879         * target-delegates.c: Regenerate.
4880
4881 2019-01-24  Pedro Alves  <palves@redhat.com>
4882
4883         * common/forward-scope-exit.h
4884         (forward_scope_exit::forward_scope_exit): Pass arguments to
4885         m_bind_function directly, instead of creating a std::bind and
4886         copying that.
4887
4888 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4889
4890         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4891         for static members.
4892         (pass_in_v_vfp_candidate): Likewise.
4893
4894 2019-01-23  Tom Tromey  <tom@tromey.com>
4895             Pedro Alves  <palves@redhat.com>
4896
4897         * regcache.c (class regcache_invalidator): Remove.
4898         (regcache::raw_write): Use make_scope_exit.
4899
4900 2019-01-23  Tom Tromey  <tom@tromey.com>
4901
4902         * ui-out.h (class ui_out_emit_type): Update comment.
4903
4904 2019-01-23  Tom Tromey  <tom@tromey.com>
4905
4906         * infrun.c (fetch_inferior_event): Update comment.
4907
4908 2019-01-23  Tom Tromey  <tom@tromey.com>
4909             Pedro Alves  <palves@redhat.com>
4910
4911         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4912         parameter.
4913         (fetch_inferior_event): Use SCOPE_EXIT.
4914
4915
4916 2019-01-23  Tom Tromey  <tom@tromey.com>
4917             Pedro Alves  <palves@redhat.com>
4918
4919         * infrun.c (disable_thread_events): Delete.
4920         (stop_all_threads): Use SCOPE_EXIT.
4921
4922 2019-01-23  Tom Tromey  <tom@tromey.com>
4923             Pedro Alves  <palves@redhat.com>
4924
4925         * symfile.c: Include forward-scope-exit.h.
4926         (clear_symtab_users_cleanup): Replace forward declaration with
4927         a FORWARD_SCOPE_EXIT.
4928         (syms_from_objfile_1): Use the forward_scope_exit and
4929         gdb::optional instead of cleanup_function.
4930         (reread_symbols): Use the forward_scope_exit instead of
4931         cleanup_function.
4932         (clear_symtab_users_cleanup): Remove function.
4933
4934 2019-01-23  Tom Tromey  <tom@tromey.com>
4935             Pedro Alves  <palves@redhat.com>
4936
4937         * linux-nat.c: Include scope-exit.h.
4938         (cleanup_target_stop): Remove.
4939         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4940         SCOPE_EXIT.
4941
4942 2019-01-23  Tom Tromey  <tom@tromey.com>
4943             Pedro Alves  <palves@redhat.com>
4944
4945         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4946         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4947
4948 2019-01-23  Tom Tromey  <tom@tromey.com>
4949             Andrew Burgess  <andrew.burgess@embecosm.com>
4950             Pedro Alves  <palves@redhat.com>
4951
4952         * infrun.c (fetch_inferior_event): Use scope_exit.
4953         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4954         * top.c (execute_command): Use scope_exit.
4955         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4956         * utils.c (do_bpstat_clear_actions_cleanup)
4957         (make_bpstat_clear_actions_cleanup): Remove.
4958
4959 2019-01-23  Tom Tromey  <tom@tromey.com>
4960             Pedro Alves  <palves@redhat.com>
4961
4962         * infrun.c: Include "common/scope-exit.h"
4963         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4964         (wait_for_inferior): Use SCOPE_EXIT.
4965         (fetch_inferior_event): Use scope_exit.
4966
4967 2019-01-23  Tom Tromey  <tom@tromey.com>
4968             Pedro Alves  <palves@redhat.com>
4969
4970         * breakpoint.c (create_breakpoint): Remove cleanup.
4971
4972 2019-01-23  Tom Tromey  <tom@tromey.com>
4973             Andrew Burgess  <andrew.burgess@embecosm.com>
4974             Pedro Alves  <palves@redhat.com>
4975
4976 2019-01-23  Pedro Alves  <palves@redhat.com>
4977
4978         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4979
4980 2019-01-23  Pedro Alves  <palves@redhat.com>
4981             Andrew Burgess  <andrew.burgess@embecosm.com>
4982
4983         * gdbthread.h: Include "common/forward-scope-exit.h".
4984         (scoped_finish_thread_state): Redefine custom class in terms of
4985         forward_scope_exit.
4986
4987 2019-01-23  Pedro Alves  <palves@redhat.com>
4988             Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * common/forward-scope-exit.h: New file.
4991
4992 2019-01-23  Pedro Alves  <palves@redhat.com>
4993             Andrew Burgess  <andrew.burgess@embecosm.com>
4994             Tom Tromey  <tom@tromey.com>
4995
4996         * common/scope-exit.h: New file.
4997
4998 2019-01-23  Pedro Alves  <palves@redhat.com>
4999
5000         * common/preprocessor.h (ESC): Rename to ...
5001         (ESC_PARENS): ... this.
5002         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5003         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5004
5005 2019-01-23  Tom Tromey  <tom@tromey.com>
5006
5007         * language.h (class scoped_switch_to_sym_language_if_auto):
5008         Initialize m_lang in both cases.
5009
5010 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5011
5012         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5013         with XCNEW.
5014
5015 2019-01-22  Tom Tromey  <tom@tromey.com>
5016
5017         * corelow.c: Do not include sys/file.h.
5018
5019 2019-01-22  Tom Tromey  <tom@tromey.com>
5020
5021         * tui/tui-wingeneral.h: Include gdb_curses.h.
5022
5023 2019-01-22  Tom Tromey  <tom@tromey.com>
5024
5025         * source-cache.h (class source_cache) <get_source_lines,
5026         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5027
5028 2019-01-22  Tom Tromey  <tom@tromey.com>
5029
5030         * remote-fileio.h (struct remote_target): Declare.
5031
5032 2019-01-22  Tom Tromey  <tom@tromey.com>
5033
5034         * python/py-arch.c: Do not include py-ref.h.
5035         * python/py-bpevent.c: Do not include py-ref.h.
5036         * python/py-cmd.c: Do not include py-ref.h.
5037         * python/py-continueevent.c: Do not include py-ref.h.
5038         * python/py-event.h: Do not include py-ref.h.
5039         * python/py-evtregistry.c: Do not include py-ref.h.
5040         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5041         * python/py-frame.c: Do not include py-ref.h.
5042         * python/py-framefilter.c: Do not include py-ref.h.
5043         * python/py-function.c: Do not include py-ref.h.
5044         * python/py-infevents.c: Do not include py-ref.h.
5045         * python/py-linetable.c: Do not include py-ref.h.
5046         * python/py-objfile.c: Do not include py-ref.h.
5047         * python/py-param.c: Do not include py-ref.h.
5048         * python/py-prettyprint.c: Do not include py-ref.h.
5049         * python/py-progspace.c: Do not include py-ref.h.
5050         * python/py-symbol.c: Do not include py-ref.h.
5051         * python/py-symtab.c: Do not include py-ref.h.
5052         * python/py-type.c: Do not include py-ref.h.
5053         * python/py-unwind.c: Do not include py-ref.h.
5054         * python/py-utils.c: Do not include py-ref.h.
5055         * python/py-value.c: Do not include py-ref.h.
5056         * python/py-varobj.c: Do not include py-ref.h.
5057         * python/py-xmethods.c: Do not include py-ref.h.
5058         * python/python.c: Do not include py-ref.h.
5059         * varobj.c: Do not include py-ref.h.
5060
5061 2019-01-22  Tom Tromey  <tom@tromey.com>
5062
5063         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5064         keyword for bcache.
5065
5066 2019-01-22  Tom Tromey  <tom@tromey.com>
5067
5068         * compile/compile-cplus-types.c: Remove a comment by #include.
5069
5070 2019-01-22  Tom Tromey  <tom@tromey.com>
5071
5072         * compile/gcc-c-plugin.h: Include compile-internal.h.
5073
5074 2019-01-22  Tom Tromey  <tom@tromey.com>
5075
5076         * stabsread.c (EXTERN): Do not define.
5077         (symnum, next_symbol_text_func, processing_gcc_compilation)
5078         (within_function, global_sym_chain, global_stabs)
5079         (previous_stab_code, this_object_header_files)
5080         (n_this_object_header_files)
5081         (n_allocated_this_object_header_files): Define.
5082         * stabsread.h (EXTERN): Never define.  Use "extern".
5083
5084 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5085
5086         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5087         history_value.
5088
5089 2019-01-21  Tom Tromey  <tom@tromey.com>
5090
5091         * ui-out.c: Fix includes.
5092         * tui/tui-source.c: Fix includes.
5093         * target.c: Fix includes.
5094         * remote.c: Fix includes.
5095         * regcache.c: Fix includes.
5096         * python/py-block.c: Fix includes.
5097         * printcmd.c: Fix includes.
5098         * or1k-tdep.c: Fix includes.
5099         * mi/mi-main.c: Fix includes.
5100         * m32r-tdep.c: Fix includes.
5101         * csky-tdep.c: Fix includes.
5102         * compile/compile-cplus-types.c: Fix includes.
5103         * cli/cli-interp.c: Fix includes.
5104
5105 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5106
5107         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5108         for padding.
5109
5110 2019-01-16  Tom Tromey  <tom@tromey.com>
5111
5112         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5113         earlier.
5114         (struct objfile) <msymbols_range>: Move from top level.
5115         <msymbols>: New method.
5116         (class objfile_msymbols): Remove.
5117         * symtab.c (default_collect_symbol_completion_matches_break_on):
5118         Update.
5119         * symmisc.c (dump_msymbols): Update.
5120         * stabsread.c (scan_file_globals): Update.
5121         * objc-lang.c (info_selectors_command, info_classes_command)
5122         (find_methods): Update.
5123         * minsyms.c (find_solib_trampoline_target): Update.
5124         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5125         * coffread.c (coff_symfile_read): Update.
5126         * ada-lang.c (ada_lookup_simple_minsym)
5127         (ada_collect_symbol_completion_matches): Update.
5128
5129 2019-01-16  Tom Tromey  <tom@tromey.com>
5130
5131         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5132         type.  Remove no-argument constructor.
5133         <iterator::operator++>: Simplify.
5134         <begin>: Update.
5135         <end>: Use minimal_symbol_count.
5136
5137 2019-01-16  Tom Tromey  <tom@tromey.com>
5138
5139         * objfiles.h (struct objfile) <psymtabs>: New method.
5140         (class objfile_psymtabs): Remove.
5141         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5142         typedef.
5143         <range>: New method.
5144         (require_partial_symbols): Change return type.
5145         * psymtab.c (require_partial_symbols)
5146         (psym_expand_symtabs_matching): Update.
5147         * mdebugread.c (parse_partial_symbols): Update.
5148         * dbxread.c (dbx_end_psymtab): Update.
5149
5150 2019-01-15  Tom Tromey  <tom@tromey.com>
5151
5152         * symtab.c (lookup_objfile_from_block)
5153         (lookup_symbol_in_objfile_symtabs)
5154         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5155         (find_line_symtab, info_sources_command)
5156         (default_collect_symbol_completion_matches_break_on)
5157         (make_source_files_completion_list): Update.
5158         * symmisc.c (print_objfile_statistics, dump_objfile)
5159         (maintenance_print_symbols, maintenance_info_symtabs)
5160         (maintenance_check_symtabs, maintenance_info_line_tables):
5161         Update.
5162         * source.c (select_source_symtab)
5163         (forget_cached_source_info_for_objfile): Update.
5164         * objfiles.h (class objfile_compunits): Remove.
5165         (struct objfile) <compunits_range>: New typedef.
5166         (compunits): New method.
5167         * objfiles.c (objfile_relocate1): Update.
5168         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5169         * maint.c (count_symtabs_and_blocks): Update.
5170         * linespec.c (iterate_over_all_matching_symtabs): Update.
5171         * cp-support.c (add_symbol_overload_list_qualified): Update.
5172         * coffread.c (coff_symtab_read): Update.
5173         * ada-lang.c (add_nonlocal_symbols)
5174         (ada_collect_symbol_completion_matches)
5175         (ada_add_global_exceptions): Update.
5176
5177 2019-01-15  Tom Tromey  <tom@tromey.com>
5178
5179         * progspace.h (program_space) <objfiles_safe_range>: New
5180         typedef.
5181         <objfiles_safe>: New method.
5182         * objfiles.h (class all_objfiles_safe): Remove.
5183         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5184         * jit.c (jit_inferior_exit_hook): Update.
5185
5186 2019-01-17  Tom Tromey  <tom@tromey.com>
5187
5188         * progspace.h (program_space) <objfiles_range>: New typedef.
5189         <objfiles>: New method.
5190         <objfiles_head>: Rename from objfiles.
5191         (object_files): Update.
5192         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5193         * guile/scm-pretty-print.c
5194         (ppscm_find_pretty_printer_from_objfiles): Update.
5195         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5196         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5197         Update.
5198         * python/py-progspace.c (pspy_get_objfiles): Update.
5199         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5200         Update.
5201         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5202         (objfpy_lookup_objfile_by_build_id): Update.
5203         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5204         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5205         Update.
5206         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5207         (expand_symtab_containing_pc, lookup_objfile_from_block)
5208         (lookup_static_symbol, basic_lookup_transparent_type)
5209         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5210         (find_line_symtab, info_sources_command)
5211         (default_collect_symbol_completion_matches_break_on)
5212         (make_source_files_completion_list, find_main_name): Update.
5213         * symmisc.c (print_symbol_bcache_statistics)
5214         (print_objfile_statistics, maintenance_print_symbols)
5215         (maintenance_print_msymbols, maintenance_print_objfiles)
5216         (maintenance_info_symtabs, maintenance_check_symtabs)
5217         (maintenance_expand_symtabs, maintenance_info_line_tables):
5218         Update.
5219         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5220         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5221         (map_overlay_command, unmap_overlay_command)
5222         (simple_overlay_update, expand_symtabs_matching)
5223         (map_symbol_filenames): Update.
5224         * symfile-debug.c (set_debug_symfile): Update.
5225         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5226         Update.
5227         * source.c (select_source_symtab, forget_cached_source_info):
5228         Update.
5229         * solib.c (solib_read_symbols): Update.
5230         * solib-spu.c (append_ocl_sos): Update.
5231         * psymtab.c (maintenance_print_psymbols)
5232         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5233         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5234         * printcmd.c (info_symbol_command): Update.
5235         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5236         Update.
5237         * objfiles.h (class all_objfiles): Remove.
5238         * objfiles.c (have_partial_symbols, have_full_symbols)
5239         (have_minimal_symbols, qsort_cmp, update_section_map)
5240         (shared_objfile_contains_address_p)
5241         (default_iterate_over_objfiles_in_search_order): Update.
5242         * objc-lang.c (info_selectors_command, info_classes_command)
5243         (find_methods): Update.
5244         * minsyms.c (find_solib_trampoline_target): Update.
5245         * maint.c (maintenance_info_sections)
5246         (maintenance_translate_address, count_symtabs_and_blocks):
5247         Update.
5248         * main.c (captured_main_1): Update.
5249         * linux-thread-db.c (try_thread_db_load_from_pdir)
5250         (has_libpthread): Update.
5251         * linespec.c (iterate_over_all_matching_symtabs)
5252         (search_minsyms_for_name): Update.
5253         * jit.c (jit_find_objf_with_entry_addr): Update.
5254         * hppa-tdep.c (find_unwind_entry)
5255         (hppa_lookup_stub_minimal_symbol): Update.
5256         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5257         Update.
5258         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5259         (elf_gnu_ifunc_resolve_by_got): Update.
5260         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5261         * dwarf-index-write.c (save_gdb_index_command): Update.
5262         * cp-support.c (add_symbol_overload_list_qualified): Update.
5263         * breakpoint.c (create_overlay_event_breakpoint)
5264         (create_longjmp_master_breakpoint)
5265         (create_std_terminate_master_breakpoint)
5266         (create_exception_master_breakpoint): Update.
5267         * blockframe.c (find_pc_partial_function): Update.
5268         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5269         (ada_collect_symbol_completion_matches)
5270         (ada_add_global_exceptions): Update.
5271
5272 2019-01-17  Tom Tromey  <tom@tromey.com>
5273
5274         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5275         declare VEC.
5276         (solib_target_parse_libraries): Change return type.
5277         (library_list_start_segment, library_list_start_section)
5278         (library_list_end_library, library_list_start_library); Update.
5279         (solib_target_free_library_list): Remove.
5280         (solib_target_parse_libraries): Remove cleanup.  Change return
5281         type.
5282         (solib_target_current_sos): Update.
5283
5284 2019-01-17  Tom Tromey  <tromey@bapiya>
5285
5286         * valprint.c: Replace "the the" with "the".
5287         * symtab.c: Replace "the the" with "the".
5288         * solib.c: Replace "the the" with "the".
5289         * solib-dsbt.c: Replace "the the" with "the".
5290         * linespec.c: Replace "the the" with "the".
5291         * dwarf2loc.h: Replace "the the" with "the".
5292         * amd64-windows-tdep.c: Replace "the the" with "the".
5293         * aarch64-tdep.c: Replace "the the" with "the".
5294
5295 2019-01-16  Keith Seitz  <keiths@redhat.com>
5296
5297         PR gdb/23773
5298         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5299         <builder>: Rename to ..
5300         <m_builder>: ... this and make private.
5301         (dwarf2_cu::get_builder): New method.  Change all users of
5302         `builder' to use this method.
5303         (dwarf2_start_symtab): Move to ...
5304         (dwarf2_cu::start_symtab): ... here.  Update all callers
5305         (setup_type_unit_groups): Move to ...
5306         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5307         callers.
5308         (dwarf2_cu::reset_builder): New method.
5309         (process_full_compunit, process_full_type_unit): Use
5310         dwarf2_cu::reset_builder.
5311         (follow_die_offset): Record the ancestor CU if it is different
5312         from the followed DIE's CU.
5313         (follow_die_sig_1): Likewise.
5314
5315 2019-01-15  Tom Tromey  <tom@tromey.com>
5316
5317         * remote.c (class remote_state) <buf>: Now a char_vector.
5318         <buf_size>: Remove.
5319         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5320         parameter.
5321         (remote_target::getpkt_or_notif_sane_1)
5322         (remote_target::getpkt_sane)
5323         (remote_target::getpkt_or_notif_sane): Likewise.
5324         (class remote_target) <putpkt>: New overload.
5325         (remote_target::read_frame): Change type of "buf_p".  Remove
5326         sizeof_p parameter.
5327         (packet_ok): New overload.
5328         (packet_check_result): New overload.
5329         Update all uses.
5330
5331 2019-01-14  Tom Tromey  <tom@tromey.com>
5332
5333         * remote-notif.c (handle_notification, remote_notif_ack)
5334         (remote_notif_parse): Make "buf" const.
5335         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5336         const.
5337         (remote_notif_parse, remote_notif_ack, handle_notification):
5338         Likewise.
5339         * remote.c (remote_notif_stop_parse): Make "buf" const.
5340         (remote_target::remote_parse_stop_reply): Make "buf" const.
5341         (remote_notif_stop_ack): Make "buf" const.
5342
5343 2019-01-14  Tom Tromey  <tom@tromey.com>
5344
5345         * remote.c (remote_console_output): Make parameter const.
5346
5347 2019-01-14  Tom Tromey  <tom@tromey.com>
5348
5349         * target-debug.h (target_debug_print_signals): Constify.
5350         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5351         * procfs.c (procfs_target::pass_signals): Update.
5352         * linux-nat.c (linux_nat_target::pass_signals): Update.
5353         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5354         * target-delegates.c: Rebuild.
5355         * remote.c (remote_target::program_signals): Update.
5356         (remote_target::pass_signals): Update.
5357         * target.c (target_pass_signals): Constify argument.
5358         (target_program_signals): Likewise.
5359         * target.h (struct target_ops) <pass_signals, program_signals>:
5360         Constify argument.
5361         (target_pass_signals, target_program_signals): Constify argument.
5362
5363 2019-01-14  Tom Tromey  <tom@tromey.com>
5364
5365         PR tui/28819:
5366         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5367
5368 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5369
5370         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5371         field.
5372         * rs6000-tdep.c: Include reggroups.h.
5373         (IS_V_ALIAS_PSEUDOREG): Define.
5374         (rs6000_register_name): Return names for the "vX" aliases.
5375         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5376         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5377         aliases.  Call default_register_reggroup_p for all other
5378         pseudo-registers.
5379         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5380         New functions.
5381         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5382         Handle "vX" aliases.
5383         (v_alias_pseudo_register_collect): New function.
5384         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5385         (rs6000_gdbarch_init): Initialize "vX" aliases as
5386         pseudo-registers.  Restore registration of
5387         rs6000_pseudo_register_reggroup_p with
5388         set_tdesc_pseudo_register_reggroup_p.
5389
5390 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5391
5392         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5393         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5394         set_gdbarch_num_pseudo_regs.
5395
5396 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5397
5398         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5399         Remove arg prefixname, add do_set and do_show.
5400         Add member functions set_list and show_list.
5401         * cli/cli-style.c (class cli_style_option): Update accordingly.
5402         (style_set_list): Move to file scope.
5403         (style_show_list): Likewise.
5404         (set_style): Call help_list.
5405         (show_style): Call cmd_show_list.
5406         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5407         Update to use the new macro.
5408
5409 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5410
5411         * ada-lang.c (_initialize_ada_language): Expand the help text
5412         for the "catch exception" command.
5413
5414 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5415
5416         * symtab.c (matching_obj_sections): Initialize obj,
5417         declare it closer to its usage.
5418
5419 2019-01-10  Tom Tromey  <tom@tromey.com>
5420
5421         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5422         (basic_inf_threads_range): Remove.
5423         (inf_threads_range, inf_non_exited_threads_range)
5424         (safe_inf_threads_range): Use next_adapter.
5425
5426 2019-01-10  Keith Seitz  <keiths@redhat.com>
5427
5428         PR gdb/23712
5429         PR symtab/23010
5430         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5431         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5432
5433 2019-01-10  Keith Seitz  <keiths@redhat.com>
5434
5435         PR gdb/23712
5436         PR symtab/23010
5437         * dictionary.c (pending_to_vector): Remove.
5438         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5439         Remove _1 suffix, replacing functions of the same name.  Update
5440         all callers.
5441         (dict_create_hashed, dict_create_hashed_expandable)
5442         (dict_create_linear, dict_create_linear_expandable, dict_free)
5443         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5444         Make functions static.
5445
5446 2019-01-10  Keith Seitz  <keiths@redhat.com>
5447
5448         PR gdb/23712
5449         PR symtab/23010
5450         * dictionary.h (struct dictionary): Replace declaration with
5451         multidictionary.
5452         (dict_create_hashed, dict_create_hashed_expandable)
5453         (dict_create_linear, dict_create_linear_expandable)
5454         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5455         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5456         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5457         taking multidictionary argument.
5458         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5459         * block.h (struct block) <dict>: Change to multidictionary
5460         and rename `multidict'.
5461         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5462         symmisc.c: Update all dictionary references to multidictionary.
5463
5464 2019-01-10  Keith Seitz  <keiths@redhat.com>
5465
5466         PR gdb/23712
5467         PR symtab/23010
5468         * dictionary.c: Include unordered_map.
5469         (pending_to_vector): New function.
5470         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5471         Rewrite the non-"_1" functions to take vector instead
5472         of linked list.
5473         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5474         "new" _1 versions of the same name.
5475         (multidictionary): Define.
5476         (std::hash<enum language): New definition.
5477         (collate_pending_symbols_by_language, mdict_create_hashed)
5478         (mdict_create_hashed_expandable, mdict_create_linear)
5479         (mdict_create_linear_expandable, mdict_free)
5480         (find_language_dictionary, create_new_language_dictionary)
5481         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5482         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5483         (mdict_size, mdict_empty): New functions.
5484         * dictionary.h (mdict_iterator): Define.
5485
5486 2019-01-10  Pedro Alves  <palves@redhat.com>
5487
5488         * breakpoint.c (read_uploaded_action)
5489         (create_tracepoint_from_upload): Adjust to use
5490         gdb::unique_xmalloc_ptr.
5491         * ctf.c (ctf_write_uploaded_tp):
5492         (SET_ARRAY_FIELD): Use emplace_back.
5493         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5494         * tracefile-tfile.c (tfile_write_uploaded_tp):
5495         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5496         gdb::unique_xmalloc_ptr.
5497         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5498         at_string, cond_string, cmd_strings>: Replace char pointers
5499         with gdb::unique_xmalloc_ptr.
5500
5501 2019-01-10  Pedro Alves  <palves@redhat.com>
5502
5503         * solib-target.c (library_list_start_library): Don't xstrdup name.
5504
5505 2019-01-10  Pedro Alves  <palves@redhat.com>
5506
5507         * mdebugread.c (parse_partial_symbols): Use
5508         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5509
5510 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * linux-fork.c (scoped_switch_fork_info)
5513         <~scoped_switch_fork_info>: Fix incorrect variable name.
5514
5515 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5516
5517         * linux-fork.c (scoped_switch_fork_info)
5518         <scoped_switch_fork_info>: Make explicit.
5519         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5520
5521 2019-01-10  Tom Tromey  <tom@tromey.com>
5522
5523         * objfiles.h (objfile::reset_psymtabs): Update.
5524         * objfiles.c (objfile::objfile): Update.
5525         * psymtab.h (psymtab_storage::obstack): Update.
5526         (psymtab_storage::m_obstack): Use gdb::optional.
5527         (class psymtab_storage): Update comment.  Remove objfile
5528         parameter.
5529         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5530
5531 2019-01-10  Tom Tromey  <tom@tromey.com>
5532
5533         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5534         <free_psymtabs>: Now private.
5535         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5536         (allocate_psymtab): Use new method.
5537
5538 2019-01-10  Tom Tromey  <tom@tromey.com>
5539
5540         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5541         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5542         * mdebugread.c (parse_partial_symbols): Use
5543         allocate_dependencies.
5544         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5545         allocate_dependencies.
5546         (process_psymtab_comp_unit_reader)
5547         (build_type_psymtab_dependencies): Likewise.
5548         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5549
5550 2019-01-10  Tom Tromey  <tom@tromey.com>
5551
5552         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5553         PSYMBOL_SET_LANGUAGE.
5554         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5555
5556 2019-01-10  Tom Tromey  <tom@tromey.com>
5557
5558         * psymtab.h (psymtab_storage::obstack): New method.
5559         <m_obstack>: Rename from obstack; now private.
5560         * psymtab.c (psymtab_storage): Update.
5561         * dwarf2read.c (create_addrmap_from_index)
5562         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5563         Update.
5564
5565 2019-01-10  Tom Tromey  <tom@tromey.com>
5566
5567         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5568         * objfiles.h (objfile::reset_psymtabs): New method.
5569
5570 2019-01-10  Tom Tromey  <tom@tromey.com>
5571
5572         * symmisc.c (print_symbol_bcache_statistics): Update.
5573         (print_objfile_statistics): Update.
5574         * symfile.c (reread_symbols): Update.
5575         * psymtab.h (class psymtab_storage): New.
5576         * psymtab.c (psymtab_storage): New constructor.
5577         (~psymtab_storage): New destructor.
5578         (require_partial_symbols): Update.
5579         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5580         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5581         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5582         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5583         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5584         (start_psymtab_common, end_psymtab_common)
5585         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5586         (allocate_psymtab): Update.
5587         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5588         Update.
5589         (dump_psymtab_addrmap, maintenance_print_psymbols)
5590         (maintenance_check_psymtabs): Update.
5591         (class objfile_psymtabs): Move to objfiles.h.
5592         * psympriv.h (discard_psymtab): Now inline.
5593         (psymtab_discarder::psymtab_discarder): Update.
5594         (psymtab_discarder::~psymtab_discarder): Update.
5595         (ALL_OBJFILE_PSYMTABS): Rewrite.
5596         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5597         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5598         Remove fields.
5599         <partial_symtabs>: New field.
5600         (class objfile_psymtabs): Move from psymtab.h.  Update.
5601         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5602         psymbol_cache.
5603         (objfile::~objfile): Don't destroy psymbol_cache.
5604         * mdebugread.c (parse_partial_symbols): Update.
5605         * dwarf2read.c (create_addrmap_from_index)
5606         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5607         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5608         (add_partial_subprogram, dwarf2_ranges_read): Update.
5609         * dwarf-index-write.c (write_address_map)
5610         (write_one_signatured_type, recursively_write_psymbols)
5611         (class debug_names, class debug_names, write_psymtabs_to_index):
5612         Update.
5613
5614 2019-01-10  Tom Tromey  <tom@tromey.com>
5615
5616         * symtab.h (SYMBOL_SET_NAMES): Update.
5617         (symbol_set_names): Update.
5618         (MSYMBOL_SET_NAMES): Update.
5619         * symtab.c (symbol_set_names): Change argument to be an
5620         objfile_per_bfd_storage.
5621         * psymtab.c (add_psymbol_to_bcache): Update.
5622         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5623
5624 2019-01-10  Tom Tromey  <tom@tromey.com>
5625
5626         * symtab.c (create_demangled_names_hash): Change argument to be an
5627         objfile_per_bfd_storage.
5628         (symbol_set_names): Update.
5629
5630 2019-01-10  Tom Tromey  <tom@tromey.com>
5631
5632         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5633         init_psymbol_list.
5634         * psymtab.c (init_psymbol_list): Do nothing if already called.
5635         * psympriv.h (init_psymbol_list): Add comment.
5636         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5637         init_psymbol_list.
5638         * dbxread.c (dbx_symfile_read): Unconditionally call
5639         init_psymbol_list.
5640
5641 2019-01-10  Tom Tromey  <tom@tromey.com>
5642
5643         * xcoffread.c (scan_xcoff_symtab): Update.
5644         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5645         "where".
5646         * mdebugread.c (parse_partial_symbols)
5647         (handle_psymbol_enumerators): Update.
5648         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5649         * dbxread.c (read_dbx_symtab): Update.
5650         * psympriv.h (psymbol_placement): New enum.
5651         (add_psymbol_to_list): Update.
5652
5653 2019-01-10  Tom Tromey  <tom@tromey.com>
5654
5655         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5656         static_psymbols parameters.
5657         (scan_xcoff_symtab): Update.
5658         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5659         static_psymbols parameters.
5660         * psympriv.h (start_psymtab_common): Update.
5661         * mdebugread.c (parse_partial_symbols): Update.
5662         * dwarf2read.c (create_partial_symtab): Update.
5663         * dbxread.c (read_dbx_symtab): Update.
5664         (start_psymtab): Remove global_psymbols and static_psymbols
5665         parameters.
5666
5667 2019-01-10  Tom Tromey  <tom@tromey.com>
5668
5669         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5670         * psymtab.c (allocate_psymtab): Add comment.
5671         * psympriv.h (allocate_psymtab): Add comment.
5672         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5673         initializations.
5674         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5675
5676 2019-01-10  Tom Tromey  <tom@tromey.com>
5677
5678         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5679         Don't declare.
5680         * mipsread.c: Include mdebugread.h.
5681         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5682         Declare.
5683         * elfread.c: Include mdebugread.h.
5684
5685 2019-01-09  Tom Tromey  <tom@tromey.com>
5686
5687         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5688         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5689         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5690         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5691         (psym_lookup_symbol, psym_find_last_source_symtab)
5692         (psym_forget_cached_source_info, psym_print_stats)
5693         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5694         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5695         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5696         (psym_find_compunit_symtab_by_address)
5697         (maintenance_print_psymbols, maintenance_info_psymtabs)
5698         (maintenance_check_psymtabs): Use ranged for.
5699         * psymtab.h (class objfile_psymtabs): New.
5700         (require_partial_symbols): Return objfile_psymtabs.
5701         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5702
5703 2019-01-09  Tom Tromey  <tom@tromey.com>
5704
5705         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5706         (find_pc_mapped_section, list_overlays_command)
5707         (map_overlay_command, unmap_overlay_command)
5708         (simple_overlay_update): Use all_objfiles.
5709         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5710         * printcmd.c (info_symbol_command): Use all_objfiles.
5711         * objfiles.h (ALL_OBJSECTIONS): Remove.
5712         * maint.c (maintenance_translate_address): Use all_objfiles.
5713         * gcore.c (gcore_create_callback): Use all_objfiles.
5714         (objfile_find_memory_regions): Likewise.
5715
5716 2019-01-09  Tom Tromey  <tom@tromey.com>
5717
5718         * symtab.c (find_line_symtab, info_sources_command)
5719         (make_source_files_completion_list): Use objfile_compunits.
5720         * source.c (select_source_symtab): Use objfile_compunits.
5721         * objfiles.h (struct objfile): Update comment.
5722         (ALL_OBJFILES): Remove.
5723         (ALL_FILETABS): Remove.
5724         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5725         objfile_compunits.
5726
5727 2019-01-09  Tom Tromey  <tom@tromey.com>
5728
5729         * symmisc.c (print_objfile_statistics, dump_objfile)
5730         (maintenance_print_symbols): Use compunit_filetabs.
5731         * source.c (forget_cached_source_info_for_objfile): Use
5732         compunit_filetabs.
5733         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5734         (ALL_FILETABS): Use compunit_filetabs.
5735         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5736         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5737
5738 2019-01-09  Tom Tromey  <tom@tromey.com>
5739
5740         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5741         (compunit_filetabs): New.
5742         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5743         compunit_filetabs.
5744         (info_sources_command, make_source_files_completion_list): Remove
5745         declaration.
5746         * symmisc.c (print_objfile_statistics, dump_objfile)
5747         (maintenance_print_symbols): Remove declaration.
5748         (maintenance_info_symtabs): Use compunit_filetabs.
5749         (maintenance_info_line_tables): Likewise.
5750         * source.c (select_source_symtab): Change local variable name.
5751         (forget_cached_source_info_for_objfile): Remove declaration.
5752         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5753         * objfiles.c (objfile_relocate1): Remove declaration.
5754         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5755         declaration.
5756         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5757         * coffread.c (coff_symtab_read): Remove declaration.
5758         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5759         compunit_filetabs.
5760
5761 2019-01-09  Tom Tromey  <tom@tromey.com>
5762
5763         * symtab.c (lookup_objfile_from_block)
5764         (find_pc_sect_compunit_symtab, search_symbols)
5765         (default_collect_symbol_completion_matches_break_on): Use
5766         objfile_compunits.
5767         * objfiles.h (ALL_COMPUNITS): Remove.
5768         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5769         * cp-support.c (add_symbol_overload_list_qualified): Use
5770         objfile_compunits.
5771         * ada-lang.c (ada_collect_symbol_completion_matches)
5772         (ada_add_global_exceptions): Use objfile_compunits.
5773
5774 2019-01-09  Tom Tromey  <tom@tromey.com>
5775
5776         * source.c (select_source_symtab)
5777         (forget_cached_source_info_for_objfile): Remove declaration.
5778         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5779         declaration.
5780         * maint.c (count_symtabs_and_blocks): Remove declaration.
5781         * cp-support.c (add_symbol_overload_list_qualified): Remove
5782         declaration.
5783         * coffread.c (coff_symtab_read): Remove declaration.
5784         * symtab.c (lookup_symbol_in_objfile_symtabs)
5785         (basic_lookup_transparent_type_1): Use objfile_compunits.
5786         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5787         (info_sources_command, search_symbols)
5788         (default_collect_symbol_completion_matches_break_on)
5789         (make_source_files_completion_list): Remove declaration.
5790         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5791         (ada_collect_symbol_completion_matches)
5792         (ada_add_global_exceptions): Remove declaration.
5793         * linespec.c (iterate_over_all_matching_symtabs): Use
5794         objfile_compunits.
5795         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5796         (class objfile_compunits): New.
5797         (ALL_COMPUNITS): Use objfile_compunits.
5798         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5799         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5800         objfile_compunits.
5801         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5802
5803 2019-01-09  Tom Tromey  <tom@tromey.com>
5804
5805         * symtab.c (search_symbols)
5806         (default_collect_symbol_completion_matches_break_on): Use
5807         objfile_msymbols.
5808         * ada-lang.c (ada_lookup_simple_minsym)
5809         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5810         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5811         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5812         objfile_msymbols.
5813         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5814         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5815         * objc-lang.c (find_methods): Use objfile_msymbols.
5816         (info_selectors_command, info_classes_command): Likewise.
5817         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5818         * objfiles.h (class objfile_msymbols): New.
5819         (ALL_OBJFILE_MSYMBOLS): Remove.
5820         (ALL_MSYMBOLS): Remove.
5821
5822 2019-01-09  Tom Tromey  <tom@tromey.com>
5823
5824         * common/next-iterator.h (next_adapter): Add Iterator template
5825         parameter.
5826         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5827         (class all_objfiles_safe): New.
5828         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5829         * objfiles.c (put_objfile_before): Update comment.
5830         (add_separate_debug_objfile): Likewise.
5831         (free_all_objfiles): Use all_objfiles_safe.
5832         (objfile_purge_solibs): Likewise.
5833
5834 2019-01-09  Tom Tromey  <tom@tromey.com>
5835
5836         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5837         (expand_symtab_containing_pc, lookup_static_symbol)
5838         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5839         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5840         all_objfiles.
5841         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5842         * breakpoint.c (create_overlay_event_breakpoint)
5843         (create_longjmp_master_breakpoint)
5844         (create_std_terminate_master_breakpoint)
5845         (create_exception_master_breakpoint): Use all_objfiles.
5846         * linux-thread-db.c (try_thread_db_load_from_pdir)
5847         (has_libpthread): Use all_objfiles.
5848         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5849         * linespec.c (iterate_over_all_matching_symtabs)
5850         (search_minsyms_for_name): Use all_objfiles.
5851         * maint.c (maintenance_info_sections): Use all_objfiles.
5852         * main.c (captured_main_1): Use all_objfiles.
5853         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5854         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5855         * guile/scm-pretty-print.c
5856         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5857         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5858         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5859         (maintenance_print_msymbols): Use all_objfiles.
5860         * source.c (select_source_symtab): Use all_objfiles.
5861         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5862         * symfile.c (remove_symbol_file_command)
5863         (expand_symtabs_matching, map_symbol_filenames): Use
5864         all_objfiles.
5865         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5866         all_objfiles.
5867         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5868         * objc-lang.c (find_methods): Use all_objfiles.
5869         * objfiles.c (have_partial_symbols, have_full_symbols)
5870         (have_minimal_symbols, qsort_cmp)
5871         (default_iterate_over_objfiles_in_search_order): Use
5872         all_objfiles.
5873         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5874         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5875         (maintenance_check_psymtabs): Use all_objfiles.
5876         (ALL_PSYMTABS): Remove.
5877         * compile/compile-object-run.c (do_module_cleanup): Use
5878         all_objfiles.
5879         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5880         * cp-support.c (add_symbol_overload_list_qualified): Use
5881         all_objfiles.
5882         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5883         Use all_objfiles.
5884         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5885         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5886         all_objfiles.
5887         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5888         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5889         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5890         Uses all_objfiles.
5891         * solib.c (solib_read_symbols): Use all_objfiles
5892
5893 2019-01-09  Tom Tromey  <tom@tromey.com>
5894
5895         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5896         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5897         all_objfiles.
5898         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5899         * symmisc.c (print_symbol_bcache_statistics)
5900         (print_objfile_statistics, maintenance_print_objfiles)
5901         (maintenance_info_symtabs, maintenance_check_symtabs)
5902         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5903         all_objfiles.
5904         * source.c (forget_cached_source_info): Use all_objfiles.
5905         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5906         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5907         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5908         * objfiles.c (update_section_map): Use all_objfiles.
5909         (shared_objfile_contains_address_p): Likewise.
5910         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5911         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5912
5913 2019-01-09  Tom Tromey  <tom@tromey.com>
5914
5915         * common/next-iterator.h: New file.
5916         * objfiles.h (class all_objfiles): New.
5917         (struct objfile_iterator): New.
5918
5919 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5920
5921         * NEWS: Move the description of the changed "frame", "select-frame",
5922          and "info frame" commands to the Changed commands section.
5923
5924 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5925
5926         * gdbtypes.c (check_stub_method_group): Remove handling of old
5927         mangling schemes.
5928         * linespec.c (find_methods): Likewise.
5929         * stabsread.c (read_member_functions): Likewise.
5930         * valops.c (search_struct_method): Likewise.
5931         (value_struct_elt_for_reference): Likewise.
5932         * NEWS: Mention this change.
5933
5934 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5937         print_source_lines.
5938         * source.c (print_source_lines_base): Update line number check.
5939         (print_source_lines): New function.
5940         (source_lines_range::source_lines_range): New function.
5941         * source.h (class source_lines_range): New class.
5942         (print_source_lines): New declaration.
5943
5944 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5945
5946         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5947
5948 2019-01-08  Tom Tromey  <tom@tromey.com>
5949             Simon Marchi  <simon.marchi@ericsson.com>
5950
5951         PR gdb/24060
5952         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5953         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5954         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5955         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5956         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5957         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5958
5959 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5960
5961         * source.c (select_source_symtab): Move header comment to
5962         declaration in source.h.
5963         (forget_cached_source_info_for_objfile): Likewise.
5964         (forget_cached_source_info): Likewise.
5965         (identify_source_line): Likewise.
5966         * source.h (identify_source_line): Move declaration from symtab.h
5967         and add comment from source.c
5968         (print_source_lines): Likewise.
5969         (forget_cached_source_info_for_objfile): Likewise.
5970         (forget_cached_source_info): Likewise.
5971         (select_source_symtab): Likewise.
5972         (enum print_source_lines_flag): Move definition from symtab.h.
5973         * symtab.h (identify_source_line): Move declaration to source.h.
5974         (print_source_lines): Likewise.
5975         (forget_cached_source_info_for_objfile): Likewise.
5976         (forget_cached_source_info): Likewise.
5977         (select_source_symtab): Likewise.
5978         (enum print_source_lines_flag): Move definition to source.h.
5979         * tui/tui-hooks.c: Add 'source.h' include.
5980
5981 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * source.c (print_source_lines_base): Handle requests to print
5984         reverse line number sequences, and guard against empty lines
5985         string.
5986
5987 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * source.c (print_source_lines_base): Fix skip of '\r' if next
5990         character is '\n'.
5991
5992 2019-01-06  Tom Tromey  <tom@tromey.com>
5993
5994         * c-exp.y (struct c_parse_state) <macro_original_text,
5995         expansion_obstack>: New member.
5996         (macro_original_text, expansion_obstack): Remove globals.
5997         (scan_macro_expansion, scanning_macro_expansion)
5998         (finished_macro_expansion): Update.
5999         (scan_macro_cleanup): Remove.
6000         (yylex, c_parse): Update.
6001
6002 2019-01-06  Tom Tromey  <tom@tromey.com>
6003
6004         * c-exp.y (struct c_parse_state) <strings>: New member.
6005         (operator_stoken): Update.
6006
6007 2019-01-06  Tom Tromey  <tom@tromey.com>
6008
6009         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6010         (union type_stack_elt) <typelist_val>: Now a pointer to
6011         std::vector.
6012         (type_stack_cleanup): Don't declare.
6013         (push_typelist): Update.
6014         * parse.c (pop_typelist): Return a std::vector.
6015         (push_typelist): Take a std::vector.
6016         (follow_types): Update.  Do not free args.
6017         (type_stack_cleanup): Remove.
6018         * c-exp.y (struct c_parse_state): New.
6019         (cpstate): New global.
6020         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6021         (nonempty_typelist): Update.
6022         (func_mod): Create a new vector.
6023         (c_parse): Create a c_parse_state.
6024         (check_parameter_typelist): Do not delete params.
6025         (function_method): Update.  Do not delete type_list.
6026
6027 2019-01-06  Tom Tromey  <tom@tromey.com>
6028
6029         PR gdb/28155:
6030         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6031         check_typedef.
6032         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6033         (print_return_value): Likewise.
6034
6035 2019-01-05  Tom Tromey  <tom@tromey.com>
6036
6037         * contrib/cleanup_check.py: Remove.
6038         * contrib/gcc-with-excheck: Remove.
6039         * contrib/exsummary.py: Remove.
6040         * contrib/excheck.py: Remove.
6041
6042 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6043
6044         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6045         NULL. Initialize tpprev to NULL instead of assigning it
6046         to NULL on the next statement.
6047         * windows-nat.c (windows_delete_thread): Remove check for
6048         main_thread_id before printing thread exit notifications.
6049         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6050         Remove thread ID check against main_thread_id.
6051         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6052         windows_delete_thread.
6053         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6054
6055 2019-01-04  Tom Tromey  <tom@tromey.com>
6056
6057         * compile/compile.c (_initialize_compile): Use upper case for
6058         metasyntactic variables.
6059         * symmisc.c (_initialize_symmisc): Use upper case for
6060         metasyntactic variables.
6061         * psymtab.c (_initialize_psymtab): Use upper case for
6062         metasyntactic variables.
6063         * demangle.c (demangle_command): Use upper case for metasyntactic
6064         variables.
6065         (_initialize_demangler): Likewise.
6066         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6067         variables.
6068
6069 2019-01-03  Tom Tromey  <tom@tromey.com>
6070
6071         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6072
6073 2019-01-03  Tom Tromey  <tom@tromey.com>
6074
6075         * python/py-symtab.c (salpy_str): Update.
6076         (struct salpy_sal_object) <symtab>: Now a PyObject.
6077         (salpy_dealloc): Update.
6078         (del_objfile_sal): Use gdbpy_ref.
6079
6080 2019-01-03  Tom Tromey  <tom@tromey.com>
6081
6082         * python/py-type.c (convert_field): Use new_reference.  Return
6083         gdbpy_ref.
6084         (make_fielditem): Return gdbpy_ref.
6085         (typy_fields): Update.
6086         (typy_getitem): Update.
6087         (field_name): Return gdbpy_ref.  Use new_reference.
6088         (typy_iterator_iternext): Update.
6089
6090 2019-01-03  Tom Tromey  <tom@tromey.com>
6091
6092         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6093
6094 2019-01-03  Tom Tromey  <tom@tromey.com>
6095
6096         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6097         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6098         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6099         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6100         (pspy_set_type_printers): Likewise.
6101         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6102         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6103         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6104         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6105         (objfpy_set_type_printers): Likewise.
6106
6107 2019-01-03  Tom Tromey  <tom@tromey.com>
6108
6109         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6110         (gdbpy_print_stack): Use gdbpy_err_fetch.
6111         * python/python-internal.h (class gdbpy_err_fetch): New class.
6112         (class gdbpy_enter) <m_error_type, m_error_value,
6113         m_error_traceback>: Remove.
6114         <m_error>: New member.
6115         (gdbpy_exception_to_string): Don't declare.
6116         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6117         * python/py-value.c (convert_value_from_python): Use
6118         gdbpy_err_fetch.
6119         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6120         gdbpy_exception_to_string.
6121         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6122         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6123         gdbpy_err_fetch.
6124
6125 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6126
6127         * linux-nat.c (delete_lwp_cleanup): Delete.
6128         (struct lwp_deleter): New struct.
6129         (lwp_info_up): New typedef.
6130         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6131         lwp_info_up.
6132
6133 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6134
6135         * linux-fork.c (class scoped_switch_fork_info): New class.
6136         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6137
6138 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * valops.c (find_overload_match): Remove use of null_cleanup, and
6141         calls to do_cleanups.
6142
6143 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * compile/compile-cplus-types.c
6146         (compile_cplus_instance::decl_name): Handle changes to
6147         cp_func_name.
6148         * cp-support.c (cp_func_name): Update header comment, update
6149         return type.
6150         * cp-support.h (cp_func_name): Update return type in declaration.
6151         * valops.c (find_overload_match): Move temp_func local to top
6152         level of function and change its type.  Use temp_func to hold and
6153         delete temporary string obtained from cp_func_name.
6154
6155 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6156
6157         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6158         gdb::char_vector, remove cleanup, and update uses of `msg`.
6159
6160 2019-01-03  Jim Wilson  <jimw@sifive.com>
6161
6162         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6163
6164 2019-01-02  Tom Tromey  <tom@tromey.com>
6165
6166         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6167         (tdesc_parse_xml): Remove cleanups.
6168         * target-descriptions.h (make_cleanup_free_target_description):
6169         Don't declare.
6170         (target_desc_deleter): New struct.
6171         (target_desc_up): New typedef.
6172         * target-descriptions.c (target_desc_deleter::operator()): Rename
6173         from free_target_description.
6174         (make_cleanup_free_target_description): Remove.
6175
6176 2019-01-02  Tom Tromey  <tom@tromey.com>
6177
6178         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6179         constructor, destructor.
6180         (linespec_parser): Remove typedef.
6181         (~linespec_parser): Rename from linespec_parser_delete.
6182         (linespec_lex_to_end, linespec_complete_label)
6183         (linespec_complete): Update.
6184         (decode_line_full): Remove cleanups.
6185         (decode_line_1): Update.
6186
6187 2019-01-02  Tom Tromey  <tom@tromey.com>
6188
6189         * python/python-internal.h (inferior_to_inferior_object): Change
6190         return type.
6191         * python/py-exitedevent.c (create_exited_event_object): Update.
6192         * python/py-inferior.c (inferior_to_inferior_object): Return
6193         gdbpy_ref.
6194         (python_new_inferior, python_inferior_deleted)
6195         (thread_to_thread_object, delete_thread_object)
6196         (build_inferior_list, gdbpy_selected_inferior): Update.
6197         * python/py-infthread.c (create_thread_object): Update.  Also fail
6198         if inferior_to_inferior_object fails.
6199
6200 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6201
6202         * inferior.h (class inferior) <displaced_step_state>: New field.
6203         * infrun.h (struct displaced_step_state): Move here from
6204         infrun.c.  Initialize fields, add constructor.
6205         <inf>: Remove field.
6206         <reset>: New method.
6207         * infrun.c (struct displaced_step_inferior_state): Move to
6208         infrun.h.
6209         (displaced_step_inferior_states): Remove.
6210         (get_displaced_stepping_state): Adust.
6211         (displaced_step_in_progress_any_inferior): Adjust.
6212         (displaced_step_in_progress_thread): Adjust.
6213         (displaced_step_in_progress): Adjust.
6214         (add_displaced_stepping_state): Remove.
6215         (get_displaced_step_closure_by_addr): Adjust.
6216         (remove_displaced_stepping_state): Remove.
6217         (infrun_inferior_exit): Call displaced_step_state.reset.
6218         (use_displaced_stepping): Don't check for NULL.
6219         (displaced_step_prepare_throw): Call
6220         get_displaced_stepping_state.
6221         (displaced_step_fixup): Don't check for NULL.
6222         (prepare_for_detach): Don't check for NULL.
6223
6224 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6225
6226         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6227          in case of call that did not complete.
6228
6229 2019-01-02  Andrey Utkin  <autkin@undo.io>
6230
6231         * symfile.c (find_separate_debug_file): Fix search of debug files for
6232         remote debuggee.
6233
6234 2019-01-02  Tom Tromey  <tom@tromey.com>
6235
6236         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6237         indentation.
6238         * python/py-frame.c (frapy_older): Remove cast.
6239         (frapy_newer): Likewise.
6240         * python/py-breakpoint.c (local_setattro): Remove cast.
6241         * python/py-arch.c (archpy_name): Remove local variable.
6242         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6243
6244 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6245
6246         * unittests/basic_string_view/element_access/char/empty.cc:
6247         Fix year range in copyright header.
6248
6249 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6252         Delete.
6253         <operator==>: Update with for removed field.
6254         <hash>: Likewise.
6255         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6256         <isa_features>: ...this.
6257         <abi_features>: New field.
6258         (riscv_isa_flen): Update comment.
6259         (riscv_abi_xlen): New declaration.
6260         (riscv_abi_flen): New declaration.
6261         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6262         isa_features.
6263         (riscv_abi_xlen): New function.
6264         (riscv_isa_flen): Update to get answer from isa_features.
6265         (riscv_abi_flen): New function.
6266         (riscv_has_fp_abi): Update to get answer from abi_features.
6267         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6268         xlen and flen.
6269         (riscv_call_info) <xlen, flen>: Update comment.
6270         (riscv_call_arg_struct): Remove invalid assertions
6271         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6272         is removed.
6273         (riscv_gdbarch_init): Gather isa features and abi features
6274         separately, ensure both match on the gdbarch when reusing an old
6275         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6276         a target with 64-bit float hardware.
6277
6278 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6279
6280         * source.c (search_command_helper): Stop reverse search
6281         when line 1 has been searched.
6282
6283 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6284
6285         * record-full.c (record_full_base_target::close): Rewrite
6286         record_full_core_buf_list free logic.
6287
6288 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6289
6290         * break-catch-syscall.c (print_one_catch_syscall): xfree
6291         the last text.
6292
6293 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6294
6295         * top.c (print_gdb_version): Update Copyright year in version
6296         message.
6297
6298 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6299
6300         Update copyright year range in all GDB files.
6301
6302 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6303
6304         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6305
6306 For older changes see ChangeLog-2018.
6307 \f
6308 Local Variables:
6309 mode: change-log
6310 left-margin: 8
6311 fill-column: 74
6312 version-control: never
6313 coding: utf-8
6314 End:
6315