gdb/ChangeLog

   1 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * configure: Regenerate.
   4         * configure.ac: Check for strerror_r.
   5         * gdbsupport/common-utils.h (safe_strerror): Change return value
   6         to const char * and document that this function is now threadsafe.
   7         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
   8         thread_local and call strerror_r, if available.
   9         * utils.c (perror_string): Update.
  10         (print_sys_errmsg): Update.
  11
  12 2019-10-31  Luis Machado  <luis.machado@linaro.org>
  13
  14         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
  15         objfile_key.
  16         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
  17         objfile to fetch per-bfd data.
  18         (arm_find_exidx_entry): Likewise.
  19
  20 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  21
  22         * gdbsupport/agent.c (debug_agent): Change type to bool.
  23         (use_agent): Likewise.
  24         (all_agent_symbols_look_up): Likewise.
  25         (agent_loaded_p): Change return value to bool.
  26         (agent_look_up_symbols): Update.
  27         (agent_capability_check): Change return value to bool.
  28         * gdbsupport/agent.h (agent_loaded_p): Likewise.
  29         (debug_agent): Change type to bool.
  30         (use_agent): Likewise.
  31         (agent_capability_check): Change return value to bool.
  32
  33 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
  34
  35         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
  36         (build_minimal_symbol_hash_tables): Code to clear the table moved
  37         to clear_minimal_symbol_hash_tables.
  38         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
  39         when needed.
  40
  41 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  42
  43         * infcmd.c: Remove includes.
  44         * infrun.c: Remove includes.
  45
  46 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  47
  48         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
  49         (grow_vect): Remove declaration.
  50         (ada_type_of_array): Remove declaration.
  51         (ada_update_initial_language): Remove declaration.
  52         (ada_fold_name): Remove declaration.
  53         (ada_fill_in_ada_prototype): Remove declaration.
  54         (user_select_syms): Remove declaration.
  55         (get_selections): Remove declaration.
  56         (ada_tag_type): Remove declaration.
  57         (ada_value_tag): Remove declaration.
  58         (ada_is_others_clause): Remove declaration.
  59         (ada_in_variant): Remove declaration.
  60         (ada_value_struct_elt): Remove declaration.
  61         (ada_attribute_name): Remove declaration.
  62         (ada_system_address_type): Remove declaration.
  63         * ada-lang.c (ada_watch_location_expression): Make static.
  64         (GROW_VECT): Move here from ada-lang.h.
  65         (grow_vect): Make static.
  66         (ada_update_initial_language): Make static.
  67         (ada_fold_name): Make static.
  68         (ada_type_of_array): Make static.
  69         (encoded_ordered_before): Move up.
  70         (sort_choices): Move up.
  71         (print_signatures): Move up.
  72         (ada_print_symbol_signature): Move up.
  73         (get_selections): Move up and make static.
  74         (user_select_syms): Move up and make static.
  75         (ada_value_struct_elt): Move up and make static.
  76         (ada_tag_type): Make static.
  77         (ada_value_tag): Make static.
  78         (ada_is_others_clause): Make static.
  79         (ada_in_variant): Make static.
  80         (ada_attribute_name): Make static.
  81
  82 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  83
  84         * ada-lang.c: Remove includes.
  85         * ada-typeprint.c: Remove includes.
  86         * ada-valprint.c: Remove includes.
  87
  88 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
  89
  90         * addrmap.c: Add static assertions of type size, moved from
  91         _initialize_addrmap.
  92         (_initialize_addrmap): Remove.
  93
  94 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  95
  96         * coffread.c (record_minimal_symbol): Update.
  97         (process_coff_symbol): Update.
  98         * dbxread.c (read_dbx_symtab): Update.
  99         * dwarf2read.c (add_partial_symbol): Update.
 100         (fixup_go_packaging): Update.
 101         (load_partial_dies): Update.
 102         (new_symbol): Update.
 103         * elfread.c (record_minimal_symbol): Change signature to use
 104         gdb::string_view instead of name+len.
 105         (elf_symtab_read): Update.
 106         (elf_rel_plt_read): Update.
 107         * mdebugread.c (parse_partial_symbols): Update.
 108         (handle_psymbol_enumerators): Update.
 109         (new_symbol): Update.
 110         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 111         to use gdb::string_view instead of name+len.
 112         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 113         * psympriv.h (add_psymbol_to_list): Likewise.
 114         * psymtab.c (add_psymbol_to_bcache): Likewise.
 115         (add_psymbol_to_list): Likewise.
 116         * stabsread.c (define_symbol): Update.
 117         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 118         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 119         (symbol_set_names): Likewise.
 120         * xcoffread.c (scan_xcoff_symtab): Update.
 121
 122 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 123
 124         * symtab.h (symbol_set_names): Document that copy_name must be
 125         set to true for non-nullterminated strings.
 126         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 127         linkage_name if the entry was not found and we need to demangle.
 128
 129 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 130
 131         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 132         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 133         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 134         * gdbsupport/gdb_binary_search.h: New file.
 135
 136 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 137
 138         * NEWS: Mention new --with-system-gdbinit-dir option.
 139         * config.in: Regenerate.
 140         * configure: Regenerate.
 141         * configure.ac: Add new option --with-system-gdbinit-dir.
 142         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 143         for a ".gdb" suffix.
 144         * main.c (get_init_files): Change system_gdbinit argument to
 145         a vector and return the files in SYSTEM_GDBINIT_DIR in
 146         addition to SYSTEM_GDBINIT.
 147         (captured_main_1): Update.
 148         (print_gdb_help): Update.
 149         * top.c (print_gdb_configuration): Also print the value of
 150         SYSTEM_GDBINIT_DIR.
 151
 152 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 153
 154         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 155         that takes gdb::string_view arguments.
 156
 157 2019-10-26  Tom de Vries  <tdevries@suse.de>
 158
 159         * aarch64-linux-tdep.c: Fix typos in comments.
 160         * aarch64-tdep.c: Same.
 161         * ada-lang.c: Same.
 162         * amd64-nat.c: Same.
 163         * arc-tdep.c: Same.
 164         * arch/aarch64-insn.c: Same.
 165         * block.c: Same.
 166         * breakpoint.h: Same.
 167         * btrace.h: Same.
 168         * c-varobj.c: Same.
 169         * cli/cli-decode.c: Same.
 170         * cli/cli-script.c: Same.
 171         * cli/cli-utils.h: Same.
 172         * coff-pe-read.c: Same.
 173         * coffread.c: Same.
 174         * compile/compile-cplus-symbols.c: Same.
 175         * compile/compile-object-run.c: Same.
 176         * completer.c: Same.
 177         * corelow.c: Same.
 178         * cp-support.c: Same.
 179         * demangle.c: Same.
 180         * dwarf-index-write.c: Same.
 181         * dwarf2-frame.c: Same.
 182         * dwarf2-frame.h: Same.
 183         * eval.c: Same.
 184         * frame-base.h: Same.
 185         * frame.h: Same.
 186         * gdbcmd.h: Same.
 187         * gdbtypes.h: Same.
 188         * gnu-nat.c: Same.
 189         * guile/scm-objfile.c: Same.
 190         * i386-tdep.c: Same.
 191         * i386-tdep.h: Same.
 192         * infcall.c: Same.
 193         * infcall.h: Same.
 194         * linux-nat.c: Same.
 195         * m68k-tdep.c: Same.
 196         * macroexp.c: Same.
 197         * memattr.c: Same.
 198         * mi/mi-cmd-disas.c: Same.
 199         * mi/mi-getopt.h: Same.
 200         * mi/mi-main.c: Same.
 201         * minsyms.c: Same.
 202         * nat/aarch64-sve-linux-sigcontext.h: Same.
 203         * objfiles.h: Same.
 204         * ppc-linux-nat.c: Same.
 205         * ppc-linux-tdep.c: Same.
 206         * ppc-tdep.h: Same.
 207         * progspace.h: Same.
 208         * prologue-value.h: Same.
 209         * python/py-evtregistry.c: Same.
 210         * python/py-instruction.h: Same.
 211         * record-btrace.c: Same.
 212         * record-full.c: Same.
 213         * remote.c: Same.
 214         * rs6000-tdep.c: Same.
 215         * ser-tcp.c: Same.
 216         * sol-thread.c: Same.
 217         * sparc-sol2-tdep.c: Same.
 218         * sparc64-tdep.c: Same.
 219         * stabsread.c: Same.
 220         * symfile.c: Same.
 221         * symtab.h: Same.
 222         * target.c: Same.
 223         * tracepoint.c: Same.
 224         * tui/tui-data.h: Same.
 225         * tui/tui-io.c: Same.
 226         * tui/tui-win.c: Same.
 227         * tui/tui.c: Same.
 228         * unittests/rsp-low-selftests.c: Same.
 229         * user-regs.h: Same.
 230         * utils.c: Same.
 231         * utils.h: Same.
 232         * valarith.c: Same.
 233         * valops.c: Same.
 234         * valprint.c: Same.
 235         * valprint.h: Same.
 236         * value.c: Same.
 237         * value.h: Same.
 238         * varobj.c: Same.
 239         * x86-nat.h: Same.
 240         * xtensa-tdep.c: Same.
 241
 242 2019-10-25  Ali Tamur <tamur@google.com>
 243
 244         * charset.c (find_charset_names): Reflect API change.
 245
 246 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 247
 248         * symtab.c (struct demangled_name_entry): Change demangled name
 249         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 250         part of the struct anymore.
 251         (symbol_set_names): No longer obstack allocate + copy the demangled
 252         name, just store the allocated name from bfd.
 253
 254 2019-10-25  Tom Tromey  <tromey@adacore.com>
 255
 256         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 257         (bsearch_cie_cmp, add_cie): Remove.
 258         (find_cie): Reimplement.
 259         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 260         (dwarf2_build_frame_info): Update.
 261
 262 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 263
 264         PR gdb/25126
 265         * symfile.c (reread_symbols): Call forget_cached_source_info to
 266         clear the stale source cache.
 267
 268 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 269
 270         * configure: Regenerate.
 271         * configure.ac: Remove code that sets python_has_threads.
 272
 273 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 274
 275         * config.in: Regenerate.
 276         * configure: Regenerate.
 277         * configure.ac: Remove the code that uses sed to get the python
 278         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 279
 280 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 281
 282         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 283         error paths.
 284
 285 2019-10-23  Tom Tromey  <tom@tromey.com>
 286
 287         * arc-tdep.c: Remove ".." from include.
 288         * frv-tdep.c: Remove ".." from include.
 289         * lm32-tdep.c: Remove ".." from include.
 290         * microblaze-tdep.c: Remove ".." from include.
 291         * or1k-tdep.h: Remove ".." from include.
 292         * s12z-tdep.c: Remove ".." from include.
 293         * Makefile.in (OPCODES_CFLAGS): Add comment.
 294         (TOP_CFLAGS): New variable.
 295         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 296
 297 2019-10-23  Tom Tromey  <tom@tromey.com>
 298
 299         * Makefile.in (READLINE_DIR): Update.
 300
 301 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 302
 303         * infcall.c (call_function_by_hand_dummy): Fix the function
 304         comment.  And extract out a code section into...
 305         (reserve_stack_space): ...this new function.
 306
 307 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 308
 309         * infcall.c (value_arg_coerce): Remove an unused parameter.
 310         (call_function_by_hand_dummy): Update the call to
 311         'value_arg_coerce'.
 312
 313 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 314
 315         * infcall.c (call_function_by_hand_dummy): Refactor.
 316
 317 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 318
 319         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 320
 321 2019-10-23  Tom Tromey  <tom@tromey.com>
 322
 323         * configure: Rebuild.
 324         * configure.ac: Don't check for sigprocmask.
 325         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 326
 327 2019-10-23  Tom Tromey  <tom@tromey.com>
 328
 329         * configure: Rebuild.
 330         * acinclude.m4: Use m4_include, not sinclude.
 331
 332 2019-10-23  Tom de Vries  <tdevries@suse.de>
 333
 334         PR breakpoints/24687
 335         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 336
 337 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 338
 339         * symtab.c (struct demangled_name_entry) <language>: Change from
 340         bitfield to regular variable.
 341
 342 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * symtab.c (struct demangled_name_entry): Add a constructor.
 345         (free_demangled_name_entry): New function to call the destructor
 346         for demangled_name_entry.
 347         (create_demangled_names_hash): Pass free_demangled_name_entry to
 348         htab_create_alloc.
 349         (symbol_set_names): Call placement new for demangled_name_entry.
 350         * utils.c: No longer include xxhash.h here, now that fast_hash
 351         is inlined in the header.
 352         * utils.h: Instead, include it here.
 353
 354 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 355
 356         * Makefile.in: Link with libxxhash.
 357         * config.in: Regenerate.
 358         * configure: Regenerate.
 359         * configure.ac: Search for libxxhash.
 360         * utils.c (fast_hash): Use xxhash if present.
 361
 362 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 363
 364         * utils.h (fast_hash): New function.
 365         * symtab.c (hash_demangled_name_entry): Call new function
 366         fast_hash.
 367
 368 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 369
 370         * symtab.c (struct demangled_name_entry): Change type of mangled
 371         to gdb::string_view. Also adds a constructor that takes the
 372         mangled name.
 373         (hash_demangled_name_entry): Update.
 374         (eq_demangled_name_entry): Update.
 375         (free_demangled_name_entry): New function to call the destructor
 376         now that this is not a POD anymore.
 377         (create_demangled_names_hash): Pass free_demangled_name_entry to
 378         htab_create_alloc.
 379         (symbol_set_names): Update.
 380
 381 2019-10-21  Ali Tamur  <tamu@google.com>
 382
 383         * dwarf2read.c (dir_index): Change type.
 384         (file_name_index): Likewise.
 385         (line_header::include_dir_at): Change comment and implementation on
 386         whether it is DWARF 5.
 387         (line_header::is_valid_file_index): New function.
 388         (line_header::file_name_at): Change comment and implementation on
 389         whether it is DWARF 5.
 390         (line_header::file_names): Change to private field renamed as
 391         m_file_names and introduce a new accessor method.
 392         (line_header::file_names_size): New method.
 393         (line_header::include_dirs): Change to private field and rename as
 394         m_include_dirs.
 395         (dw2_get_file_names_reader): Define local var at a smaller scope and
 396         reflect API change.
 397         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 398         (process_structure_scope): Likewise.
 399         (line_header::add_include_dir): Change message and reflect renaming.
 400         (line_header::add_file_name): Likewise.
 401         (read_formatted_entries): Handle DW_FORM_data16.
 402         (dwarf_decode_line_header): Fix line header length calculation.
 403         (psymtab_include_file_name): Change comment and API.
 404         (lnp_state_machine::m_file): Update comment and reflect type change.
 405         (lnp_state_machine::record_line): Reflect type change.
 406         (dwarf_decode_lines): Reflect API change.
 407         (file_file_name): Likewise.
 408         (file_full_name): Likewise.
 409
 410 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 411
 412         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 413
 414 2019-10-21  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 417
 418 2019-10-21  Tom Tromey  <tom@tromey.com>
 419
 420         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 421         NM_H.   Use AC_CONFIG_LINKS.
 422         * configure: Rebuild.
 423         * Makefile.in (NM_H): New variable.
 424         (generated_files): Add NM_H.  Remove gcore.
 425         (nm.h, stamp-nmh): New targets.
 426
 427 2019-10-20  Tom Tromey  <tom@tromey.com>
 428
 429         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 430         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 431         obsolete comment.
 432         (put_objfile_before): Now static.
 433
 434 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 435
 436         * gdbsupport/common-utils.h (startswith): Change return type to
 437         bool.
 438
 439 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 440
 441         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 442         * breakpoint.c (bp_locations_compare): Rename to...
 443         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 444         (update_global_location_list): Use std::sort instead of qsort.
 445         * buildsym.c (compare_line_numbers): Rename to...
 446         (lte_is_less_than): ...this, and change to std::sort semantics.
 447         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 448         instead of qsort.
 449         * disasm.c (compare_lines): Rename to...
 450         (line_is_less_than): ...this, and change to std::sort semantics.
 451         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 452         of qsort.
 453         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 454         (fde_is_less_than): ...this, and change to std::sort semantics.
 455         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 456         * mdebugread.c (compare_blocks):
 457         (block_is_less_than): ...this, and change to std::sort semantics.
 458         (sort_blocks): Call std::sort instead of qsort.
 459         * objfiles.c (qsort_cmp): Rename to...
 460         (sort_cmp): ...this, and change to std::sort semantics.
 461         (update_section_map): Call std::sort instead of qsort.
 462         * remote.c (compare_pnums): Remove.
 463         (map_regcache_remote_table): Call std::sort instead of qsort.
 464         * utils.c (compare_positive_ints): Remove.
 465         * utils.h (compare_positive_ints): Remove.
 466         * xcoffread.c (compare_lte): Remove.
 467         (arrange_linetable): Call std::sort instead of qsort.
 468
 469 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 470
 471         * symfile.c (init_entry_point_info): Fix typo.
 472         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 473
 474 2019-10-18  Tom de Vries  <tdevries@suse.de>
 475
 476         * aarch64-tdep.c: Fix typos in comments.
 477         * ada-lang.c: Same.
 478         * ada-tasks.c: Same.
 479         * alpha-tdep.c: Same.
 480         * alpha-tdep.h: Same.
 481         * amd64-nat.c: Same.
 482         * amd64-windows-tdep.c: Same.
 483         * arc-tdep.c: Same.
 484         * arc-tdep.h: Same.
 485         * arch-utils.c: Same.
 486         * arm-nbsd-tdep.c: Same.
 487         * arm-tdep.c: Same.
 488         * ax-gdb.c: Same.
 489         * blockframe.c: Same.
 490         * btrace.c: Same.
 491         * c-varobj.c: Same.
 492         * coff-pe-read.c: Same.
 493         * coffread.c: Same.
 494         * cris-tdep.c: Same.
 495         * darwin-nat.c: Same.
 496         * dbxread.c: Same.
 497         * dcache.c: Same.
 498         * disasm.c: Same.
 499         * dtrace-probe.c: Same.
 500         * dwarf-index-write.c: Same.
 501         * dwarf2-frame-tailcall.c: Same.
 502         * dwarf2-frame.c: Same.
 503         * dwarf2read.c: Same.
 504         * eval.c: Same.
 505         * exceptions.c: Same.
 506         * fbsd-tdep.c: Same.
 507         * findvar.c: Same.
 508         * frame.c: Same.
 509         * frv-tdep.c: Same.
 510         * gnu-v3-abi.c: Same.
 511         * go32-nat.c: Same.
 512         * h8300-tdep.c: Same.
 513         * hppa-tdep.c: Same.
 514         * i386-linux-tdep.c: Same.
 515         * i386-tdep.c: Same.
 516         * ia64-libunwind-tdep.c: Same.
 517         * ia64-tdep.c: Same.
 518         * infcmd.c: Same.
 519         * infrun.c: Same.
 520         * linespec.c: Same.
 521         * linux-nat.c: Same.
 522         * linux-thread-db.c: Same.
 523         * machoread.c: Same.
 524         * mdebugread.c: Same.
 525         * mep-tdep.c: Same.
 526         * mn10300-tdep.c: Same.
 527         * namespace.c: Same.
 528         * objfiles.c: Same.
 529         * opencl-lang.c: Same.
 530         * or1k-tdep.c: Same.
 531         * osabi.c: Same.
 532         * ppc-linux-nat.c: Same.
 533         * ppc-linux-tdep.c: Same.
 534         * ppc-sysv-tdep.c: Same.
 535         * printcmd.c: Same.
 536         * procfs.c: Same.
 537         * record-btrace.c: Same.
 538         * record-full.c: Same.
 539         * remote-fileio.c: Same.
 540         * remote.c: Same.
 541         * rs6000-tdep.c: Same.
 542         * s12z-tdep.c: Same.
 543         * score-tdep.c: Same.
 544         * ser-base.c: Same.
 545         * ser-go32.c: Same.
 546         * skip.c: Same.
 547         * sol-thread.c: Same.
 548         * solib-svr4.c: Same.
 549         * solib.c: Same.
 550         * source.c: Same.
 551         * sparc-nat.c: Same.
 552         * sparc-sol2-tdep.c: Same.
 553         * sparc-tdep.c: Same.
 554         * sparc64-tdep.c: Same.
 555         * stabsread.c: Same.
 556         * stack.c: Same.
 557         * symfile.c: Same.
 558         * symtab.c: Same.
 559         * target-descriptions.c: Same.
 560         * target-float.c: Same.
 561         * thread.c: Same.
 562         * utils.c: Same.
 563         * valops.c: Same.
 564         * valprint.c: Same.
 565         * value.c: Same.
 566         * varobj.c: Same.
 567         * windows-nat.c: Same.
 568         * xcoffread.c: Same.
 569         * xstormy16-tdep.c: Same.
 570         * xtensa-tdep.c: Same.
 571
 572 2019-10-17  Tom Tromey  <tromey@adacore.com>
 573
 574         * configure: Rebuild.
 575         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 576         in AC_CONFIG_FILES invocation.
 577         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 578         new-style config.status invocation.
 579
 580 2019-10-17  Tom de Vries  <tdevries@suse.de>
 581
 582         * arm-nbsd-nat.c: Fix typos in comments.
 583         * arm-tdep.c: Same.
 584         * darwin-nat-info.c: Same.
 585         * dwarf2read.c: Same.
 586         * elfread.c: Same.
 587         * event-top.c: Same.
 588         * findvar.c: Same.
 589         * gdbtypes.c: Same.
 590         * hppa-tdep.c: Same.
 591         * i386-tdep.c: Same.
 592         * jit.c: Same.
 593         * main.c: Same.
 594         * mdebugread.c: Same.
 595         * moxie-tdep.c: Same.
 596         * nto-procfs.c: Same.
 597         * osabi.c: Same.
 598         * ppc-linux-tdep.c: Same.
 599         * remote.c: Same.
 600         * riscv-tdep.c: Same.
 601         * s390-tdep.c: Same.
 602         * sh-tdep.c: Same.
 603         * sparc-linux-tdep.c: Same.
 604         * sparc-nat.c: Same.
 605         * stack.c: Same.
 606         * target-descriptions.c: Same.
 607         * top.c: Same.
 608         * varobj.c: Same.
 609
 610 2019-10-16  Tom Tromey  <tom@tromey.com>
 611
 612         * objfiles.h (struct objfile) <original_name>: Now const.
 613
 614 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 615
 616         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 617         pass on to sigsetjmp's second argument.
 618         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 619
 620 2019-10-16  Keith Seitz  <keiths@redhat.com>
 621
 622         PR gdb/23567
 623         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 624         sections whose size is greater than the file size.
 625
 626 2019-10-16  Jim Wilson  <jimw@sifive.com>
 627
 628         * riscv-tdep.c (riscv_gcc_target_options): New.
 629         (riscv_gnu_triplet_regexp): New.
 630         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 631         set_gdbarch_gnu_triplet_regexp.
 632
 633 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 634
 635         * Makefile.in: Add xml-builtin.h.
 636         * features/feature_to_c.sh: Add an include for xml-builtin.h
 637         to ensure that the compiler checks that the types match.
 638         * xml-builtin.h: New file.
 639         * xml-support.c (fetch_xml_builtin): Add missing const.
 640         * xml-support.h: Remove declaration of xml_builtins.
 641
 642 2019-10-16  Tom de Vries  <tdevries@suse.de>
 643
 644         PR tdep/25096
 645         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 646         (amd64_classify_aggregate): ... here.
 647         (amd64_classify_aggregate_field): Handled fiels of nested structs
 648         recursively.
 649
 650 2019-10-16  Tom de Vries  <tdevries@suse.de>
 651
 652         PR tdep/24104
 653         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 654         that handles 'theclass'.
 655
 656 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 657
 658         * linespec.c (decode_digits_ordinary): Update comment.
 659         * make-target-delegates: No longer need to handle VEC case.
 660         * memrange.c (normalize_mem_ranges): Update comment.
 661         * namespace.c (add_using_directive): Update comment.
 662         * objc-lang.c (uniquify_strings): Update comment.
 663         * ppc-linux-nat.c (struct thread_points): Update comment.
 664         * probe.h (find_probes_in_objfile): Update comment.
 665         * target.h (enum flash_preserve_mode): Update comment.
 666         * varobj.c (varobj_restrict_range): Update comment.
 667         * varobj.h (varobj_list_children): Update comment.
 668
 669 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 670
 671         * Makefile.in: Remove references to vec.h and vec.c.
 672         * aarch64-tdep.c: No longer include vec.h.
 673         * ada-lang.c: Likewise.
 674         * ada-lang.h: Likewise.
 675         * arm-tdep.c: Likewise.
 676         * ax.h: Likewise.
 677         * breakpoint.h: Likewise.
 678         * charset.c: Likewise.
 679         * cp-support.h: Likewise.
 680         * dtrace-probe.c: Likewise.
 681         * dwarf2read.c: Likewise.
 682         * extension.h: Likewise.
 683         * gdb_bfd.c: Likewise.
 684         * gdbsupport/gdb_vecs.h: Likewise.
 685         * gdbsupport/vec.c: Remove.
 686         * gdbsupport/vec.h: Remove.
 687         * gdbthread.h: Likewise.
 688         * guile/scm-type.c: Likewise.
 689         * inline-frame.c: Likewise.
 690         * machoread.c: Likewise.
 691         * memattr.c: Likewise.
 692         * memrange.h: Likewise.
 693         * namespace.h: Likewise.
 694         * nat/linux-btrace.h: Likewise.
 695         * osdata.c: Likewise.
 696         * parser-defs.h: Likewise.
 697         * progspace.h: Likewise.
 698         * python/py-type.c: Likewise.
 699         * record-btrace.c: Likewise.
 700         * rust-exp.y: Likewise.
 701         * solib-target.c: Likewise.
 702         * stap-probe.c: Likewise.
 703         * target-descriptions.c: Likewise.
 704         * target-memory.c: Likewise.
 705         * target.h: Likewise.
 706         * varobj.c: Likewise.
 707         * varobj.h: Likewise.
 708         * xml-support.h: Likewise.
 709
 710 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 711
 712         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 713         Update for new std::vector based implementation.
 714         (process_psymtab_comp_unit_reader): Likewise.
 715         (scan_partial_symbols): Likewise.
 716         (recursively_compute_inclusions): Likewise.
 717         (compute_compunit_symtab_includes): Likewise.
 718         (process_imported_unit_die): Likewise.
 719         (queue_and_load_dwo_tu): Likewise.
 720         (follow_die_sig_1): Likewise.
 721         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 722         (typedef dwarf2_per_cu_ptr): Remove.
 723         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 724         function.
 725         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 726         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 727         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 728         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 729         std::vector.
 730
 731 2019-10-15  Tom Tromey  <tromey@adacore.com>
 732
 733         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 734         TID.
 735
 736 2019-10-15  Tom Tromey  <tromey@adacore.com>
 737
 738         * windows-nat.c (windows_nat_target::fetch_registers)
 739         (windows_nat_target::store_registers): Rename "pid" to "tid".
 740
 741 2019-10-15  Tom Tromey  <tromey@adacore.com>
 742
 743         * gdbarch.h, gdbarch.c: Rebuild.
 744         * gdbarch.sh (gcc_target_options): Change return type to
 745         std::string.
 746         * compile/compile.c (get_args): Update.
 747         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 748         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 749         std::string.
 750         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 751         std::string.
 752         * arch-utils.c (default_gcc_target_options): Return std::string.
 753         * arch-utils.h (default_gcc_target_options): Return std::string.
 754         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 755
 756 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 757
 758         * breakpoint.c (breakpoint_chain): Make static.
 759         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 760         of accessing breakpoint_chain.
 761
 762 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 763
 764         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 765         to a gdb::function_view and return value to bool.
 766         * breakpoint.h (iterate_over_breakpoints): Likewise.
 767         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 768         (pop_dummy_frame): Update.
 769         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 770         (gdbscm_breakpoints): Update.
 771         * python/py-breakpoint.c (build_bp_list): Update.
 772         (gdbpy_breakpoints): Update.
 773         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 774         Update.
 775         (bpfinishpy_handle_stop): Update.
 776         (bpfinishpy_handle_exit): Update.
 777         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 778         (svr4_update_solib_event_breakpoints): Update.
 779
 780 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 781
 782         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 783         when unwrapping single-field structs.
 784
 785 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 786
 787         * dwarf2read.c: Remove includes.
 788
 789 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 790
 791         * ui-out.c (ui_out::call_do_message): Silence
 792         -Wformat-nonliteral warning.
 793
 794 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 795
 796         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 797         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 798         include: readline/tilde.h.
 799
 800 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 801
 802         * remote.c (remote_target::get_trace_status): Remove declaration of
 803         trace_regblock_size.
 804
 805 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 806
 807         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 808         (show_user): Remove declaration of cmdlist.
 809         * cli/cli-cmds.h (max_user_call_depth): Declare.
 810         * cli/cli-script.c (execute_user_command): Remove declaration
 811         of max_user_call_depth.
 812
 813 2019-10-11  Jim Wilson  <jimw@sifive.com>
 814
 815         * gdbsupport/print-utils.h (pulongest): Fix comment.
 816         (plongest): Likewise.
 817         (phex): Add missing comment, mention leading zeros.
 818         (phex_nz): Add mention of no leading zeros to comment.
 819
 820         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 821         plongest instead of unsigned long long cast.
 822
 823 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 824
 825         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 826         for external_editor_command and gdbtk_test.
 827
 828 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 829
 830         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 831         * varobj.c (varobjdebug): Move comment to...
 832         * varobj.h (varobjdebug): ...here, and declare.
 833
 834 2019-10-09  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 837         erase_data_content.
 838
 839 2019-10-09  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 842         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 843         * tui/tui-command.c (tui_cmd_window::resize)
 844         (tui_refresh_cmd_win): Update.
 845         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 846         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 847         * tui/tui-data.c (~tui_gen_win_info): Remove.
 848         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 849         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 850         (tui_redisplay_readline, tui_mld_flush)
 851         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 852         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 853         (tui_data_window::erase_data_content)
 854         (tui_data_item_window::rerender)
 855         (tui_data_item_window::refresh_window): Update.
 856         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 857         (box_win, tui_gen_win_info::make_window)
 858         (tui_gen_win_info::make_visible): Update.
 859         (tui_delete_win): Remove.
 860         * tui/tui-winsource.c
 861         (tui_source_window_base::do_erase_source_content): Update.
 862         (tui_show_source_line, tui_source_window_base::update_tab_width)
 863         (tui_source_window_base::update_exec_info): Update.
 864         * tui/tui-data.h (struct curses_deleter): New.
 865         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 866         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 867
 868 2019-10-09  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 871
 872 2019-10-09  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 875         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 876
 877 2019-10-09  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 880         window height directly.
 881         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 882         declare.
 883         * tui/tui-layout.c (tui_default_win_height): Remove.
 884         (tui_default_win_viewport_height): Remove.
 885
 886 2019-10-09  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui.h: Remove comments.
 889
 890 2019-10-09  Tom de Vries  <tdevries@suse.de>
 891
 892         * python/lib/gdb/printer/bound_registers.py: Use
 893         '^builtin_type_bound128' as regexp argument for
 894         add_builtin_pretty_printer.
 895
 896 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 897
 898         * guile/guile.c (guile_extension_script_ops): Remove forward
 899         declaration and mark as static.
 900         (guile_script_ops): Likewise.
 901         (extension_language_guile): Move further down in the file so
 902         it can reference the definitions for guile_{extension_,}script_ops.
 903
 904 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 905
 906         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 907         except SORTL, DFLTCC, and KDSA.
 908
 909 2019-10-08  Tom Tromey  <tromey@adacore.com>
 910
 911         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 912         (struct safe_symbol_file_add_args): Remove.
 913
 914 2019-10-08  Tom Tromey  <tromey@adacore.com>
 915
 916         * windows-nat.c: Don't include buildsym-legacy.h.
 917
 918 2019-10-08  Tom Tromey  <tromey@adacore.com>
 919
 920         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 921
 922 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 923
 924         * gdbtypes.c (overload_debug): Move comment to header.
 925         * gdbtypes.h (overload_debug): Declare.
 926         * valops.c: Remove declaration of overload_debug, instead
 927         include gdbtypes.h.
 928
 929 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 930
 931         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 932         through _().
 933         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 934         move comment...
 935         * language.h (lang_frame_mismatch_warn): ... here. Also add
 936         declaration.
 937         * top.c (lang_frame_mismatch_warn): Remove declaration.
 938         (check_frame_language_change): Pass lang_frame_mismatch_warn
 939         through _().
 940
 941 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 942
 943         * c-lang.h (vtbl_ptr_name): Declare.
 944         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 945         it from the header.
 946         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 947
 948 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 949
 950         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 951         gdb_static_assert.
 952
 953 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 954
 955         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 956         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 957         * ctfread.c: New file.
 958         * ctfread.h: New file.
 959         * elfread.c: Include ctfread.h.
 960         (struct elfinfo text_p): New member ctfsect.
 961         (elf_locate_sections): Mark CTF section.
 962         (elf_symfile_read): Call elfctf_build_psymtabs.
 963         * Makefile.in (LIBCTF): Add.
 964         (CLIBS): Use it.
 965         (CDEPS): Likewise.
 966         (DIST): Add ctfread.c.
 967
 968 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         * ctfread.c (struct nextfield): Renamed to ...
 971         (struct ctf_nextfield): ... this.
 972         (struct field_info): Renamed to ...
 973         (strut ctf_field_info): ... this.
 974         (attach_fields_to_type): Update for renamed structures.
 975         (ctf_add_member_cb): Likewise.
 976         (ctf_add_enum_member_cb): Likewise.
 977         (process_struct_members): Likewise.
 978         (process_enum_type): Likewise.
 979
 980 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 981
 982         * tracectf.h: Rename, was ctf.h.
 983         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 984         * tracefile.c: Likewise.
 985         * tracepoint.c: Remove unused include ctf.h.
 986         * mi/mi-main.c: Likewise.
 987         * Makefile.in Replace ctf.c with tracectf.c.
 988
 989 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 990
 991         * version.in: Change version number to "9.0.50.DATE-git".
 992
 993 2019-10-03  Tom Tromey  <tom@tromey.com>
 994
 995         PR rust/24976:
 996         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 997
 998 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 999
1000         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1001         cp_search_name_hash.
1002         * NEWS: Add entry about nested function support.
1003
1004 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1005             Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1008         for nested static variables when searchin VAR_DOMAIN.
1009         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1010         global scope, update comment.
1011         (add_partial_subprogram): Call add_partial_subprogram recursively
1012         for nested subroutines when processinng Fortran.
1013         (load_partial_dies): Process the child entities of a subprogram
1014         when processing Fortran.
1015         (partial_die_parent_scope): Handle building scope
1016         for Fortran nested functions.
1017         (process_die): Record that nested functions have a scope.
1018         (new_symbol): Always record Fortran subprograms on the global
1019         symbol list.
1020         (determine_prefix): How to build the prefix for Fortran
1021         subprograms.
1022
1023 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1026         have just sent the thread a SIGSTOP and are waiting for it to
1027         arrive.
1028
1029 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * btrace.c (btrace_add_pc): Remove whitespace before the template
1032         parameter in 'std::vector <...>'.
1033         (parse_xml_btrace_block): Likewise.
1034         (btrace_maint_decode_pt): Likewise.
1035         (btrace_maint_update_packets): Likewise.
1036         (btrace_maint_print_packets): Likewise.
1037         * btrace.h (struct btrace_maint_info): Likewise.
1038         * dwarf2read.c (struct type_unit_group): Likewise.
1039         (build_type_psymtabs_reader): Likewise.
1040         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1041         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1042         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1043
1044 2019-10-03  Tom de Vries  <tdevries@suse.de>
1045
1046         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1047         the first line of the help text for set/show style metadata.
1048
1049 2019-10-02  Tom Tromey  <tromey@adacore.com>
1050
1051         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1052         * gdbsupport/common-inferior.c: New file.
1053         * infcmd.c (startup_with_shell): Don't define.
1054         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1055         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1056         * inferior.h (startup_with_shell): Don't declare.
1057
1058 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1059
1060         * gdbsupport/gdb_assert.h: Include errors.h.
1061         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1062
1063 2019-10-02  Tom Tromey  <tromey@adacore.com>
1064
1065         * NEWS: Add $_ada_exception entry.
1066         * ada-lang.c (struct ada_catchpoint): Add constructor.
1067         <m_kind>: New member.
1068         (allocate_location_exception, re_set_exception): Remove
1069         "ex" parameter.
1070         (should_stop_exception): Compute $_ada_exception.
1071         (check_status_exception, print_it_exception)
1072         (print_one_exception, print_mention_exception): Remove
1073         "ex" parameter.
1074         (allocate_location_catch_exception, re_set_catch_exception)
1075         (check_status_exception, print_it_catch_exception)
1076         (print_one_catch_exception, print_mention_catch_exception)
1077         (print_recreate_catch_exception)
1078         (allocate_location_catch_exception_unhandled)
1079         (re_set_catch_exception_unhandled)
1080         (check_status_exception, print_it_catch_exception_unhandled)
1081         (print_one_catch_exception_unhandled)
1082         (print_mention_catch_exception_unhandled)
1083         (print_recreate_catch_exception_unhandled)
1084         (allocate_location_catch_assert, re_set_catch_assert)
1085         (check_status_assert, print_it_catch_assert)
1086         (print_one_catch_assert, print_mention_catch_assert)
1087         (print_recreate_catch_assert)
1088         (allocate_location_catch_handlers, re_set_catch_handlers)
1089         (check_status_handlers, print_it_catch_handlers)
1090         (print_one_catch_handlers, print_mention_catch_handlers)
1091         (print_recreate_catch_handlers): Remove.
1092         (create_ada_exception_catchpoint): Update.
1093         (initialize_ada_catchpoint_ops): Update.
1094
1095 2019-10-02  Tom Tromey  <tromey@adacore.com>
1096
1097         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1098         (create_excep_cond_exprs): Simplify exception string computation.
1099         (ada_exception_catchpoint_cond_string): Likewise.
1100
1101 2019-10-02  Tom Tromey  <tromey@adacore.com>
1102
1103         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1104         * ada-lang.c (lesseq_defined_than): Handle
1105         LOC_STATIC.
1106         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1107         parameter.
1108         (dwarf2_has_info): Likewise.
1109         (new_symbol): Set maybe_copied on symbol when
1110         appropriate.
1111         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1112         parameter.
1113         <can_copy>: New member.
1114         * elfread.c (record_minimal_symbol): Set maybe_copied
1115         on symbol when appropriate.
1116         (elf_symfile_read): Update call to dwarf2_has_info.
1117         * minsyms.c (lookup_minimal_symbol_linkage): New
1118         function.
1119         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1120         * symtab.c (get_symbol_address, get_msymbol_address):
1121         New functions.
1122         * symtab.h (get_symbol_address, get_msymbol_address):
1123         Declare.
1124         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1125         maybe_copied.
1126         (struct symbol, struct minimal_symbol) <maybe_copied>:
1127         New member.
1128
1129 2019-10-02  Tom Tromey  <tromey@adacore.com>
1130
1131         * source.c (struct current_source_location): New.
1132         (current_source_key): New global.
1133         (current_source_symtab, current_source_line)
1134         (current_source_pspace): Remove.
1135         (get_source_location): New function.
1136         (get_current_source_symtab_and_line)
1137         (set_default_source_symtab_and_line)
1138         (set_current_source_symtab_and_line)
1139         (clear_current_source_symtab_and_line, select_source_symtab)
1140         (info_source_command, print_source_lines_base)
1141         (info_line_command, search_command_helper, _initialize_source):
1142         Update.
1143
1144 2019-10-02  Tom Tromey  <tromey@adacore.com>
1145
1146         * source.c (select_source_symtab): Don't call
1147         decode_line_with_current_source.
1148
1149 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1150
1151         * symtab.c (lookup_global_symbol): Search global block.
1152
1153 2019-10-02  Tom Tromey  <tromey@adacore.com>
1154
1155         * coffread.c (process_coff_symbol): Update.
1156         * dwarf2read.c (var_decode_location, new_symbol): Update.
1157         * mdebugread.c (parse_symbol): Update.
1158         * objfiles.c (relocate_one_symbol): Update.
1159         * stabsread.c (define_symbol, fix_common_block)
1160         (scan_file_globals): Update.
1161         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1162         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1163         * xcoffread.c (process_xcoff_symbol): Update.
1164
1165 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1166
1167         * MAINTAINERS: Update my email address.
1168
1169 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1172         std::vector.
1173         (build_type_psymtabs_reader): Update for std::vector.
1174         (build_type_psymtab_dependencies): Likewise.
1175         * dwarf2read.h: Remove use of DEF_VEC_P.
1176         (typedef sig_type_ptr): Delete.
1177
1178 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1181         to std::vector.
1182         (btrace_maint_decode_pt): Likewise, and move allocation of the
1183         vector outside of the loop.
1184         (btrace_maint_update_packets): Update to handle change from VEC to
1185         std::vector.
1186         (btrace_maint_print_packets): Likewise.
1187         (maint_info_btrace_cmd): Likewise.
1188         * btrace.h: Remove use of DEF_VEC_O.
1189         (typedef btrace_pt_packet_s): Delete.
1190         (struct btrace_maint_info) <packets>: Change fromm VEC to
1191         std::vector.
1192         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1193
1194 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1195
1196         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1197         make accesses into the vector constant references.
1198         (btrace_add_pc): Update for std::vector.
1199         (btrace_stitch_bts): Likewise.
1200         (parse_xml_btrace_block): Likewise.
1201         (btrace_maint_update_packets): Likewise.
1202         (btrace_maint_print_packets): Likewise.
1203         (maint_info_btrace_cmd): Likewise.
1204         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1205         std::vector.
1206         (btrace_data::empty): Likewise.
1207         (btrace_data_append): Likewise.
1208         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1209         (typedef btrace_block_s): Delete.
1210         (struct btrace_block): Add constructor.
1211         (struct btrace_data_bts) <blocks>: Change to std::vector.
1212         * nat/linux-btrace.c (perf_event_read_bts): Update for
1213         std::vector.
1214         (linux_read_bts): Likewise.
1215
1216 2019-10-01  Tom Tromey  <tom@tromey.com>
1217
1218         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1219
1220 2019-10-01  Tom Tromey  <tom@tromey.com>
1221
1222         * stack.c (print_frame, info_frame_command_core): Use
1223         styled_string.
1224         * linux-thread-db.c (try_thread_db_load_1)
1225         (try_thread_db_load_from_pdir_1): Use styled_string.
1226         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1227         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1228         (maybe_print_unsupported_script_warning)
1229         (maybe_print_script_not_found_warning): Use styled_string.
1230         * ada-lang.c (user_select_syms): Use styled_string.
1231
1232 2019-10-01  Tom Tromey  <tom@tromey.com>
1233
1234         * p-lang.c (pascal_printstr): Use metadata style.
1235         * value.c (show_convenience): Use metadata style.
1236         * valprint.c (valprint_check_validity, val_print_optimized_out)
1237         (val_print_not_saved, val_print_unavailable)
1238         (val_print_invalid_address, generic_val_print, val_print)
1239         (value_check_printable, val_print_array_elements): Use metadata
1240         style.
1241         * ui-out.h (class ui_out) <field_fmt>: New overload.
1242         <do_field_fmt>: Add style parameter.
1243         * ui-out.c (ui_out::field_fmt): New overload.
1244         * typeprint.c (type_print_unknown_return_type)
1245         (val_print_not_allocated, val_print_not_associated): Use metadata
1246         style.
1247         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1248         parameter.
1249         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1250         * tracepoint.c (tvariables_info_1): Use metadata style.
1251         * stack.c (print_frame_arg, print_frame_info, print_frame)
1252         (info_frame_command_core): Use metadata style.
1253         * skip.c (info_skip_command): Use metadata style.
1254         * rust-lang.c (rust_print_enum): Use metadata style.
1255         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1256         metadata style.
1257         * python/py-framefilter.c (py_print_single_arg): Use metadata
1258         style.
1259         * printcmd.c (do_one_display, print_variable_and_value): Use
1260         metadata style.
1261         * p-valprint.c (pascal_val_print)
1262         (pascal_object_print_value_fields): Use metadata style.
1263         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1264         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1265         parameter.
1266         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1267         * m2-valprint.c (m2_print_long_set): Use metadata style.
1268         * m2-typeprint.c (m2_print_type): Use metadata style.
1269         * infcmd.c (print_return_value_1): Use metadata style.
1270         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1271         * f-valprint.c (info_common_command_for_block): Use metadata
1272         style.
1273         * f-typeprint.c (f_type_print_base): Use metadata style.
1274         * expprint.c (print_subexp_standard): Use metadata style.
1275         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1276         * cli/cli-style.h (class cli_style_option): Add constructor.
1277         (metadata_style): Declare.
1278         * cli/cli-style.c (metadata_style): New global.
1279         (_initialize_cli_style): Register metadata style.
1280         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1281         parameter.
1282         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1283         * c-typeprint.c (c_type_print_base_struct_union)
1284         (c_type_print_base_1): Use metadata style.
1285         * breakpoint.c (watchpoint_value_print)
1286         (print_one_breakpoint_location): Use metadata style.
1287         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1288         style.
1289         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1290         style.
1291         * ada-valprint.c (val_print_packed_array_elements, printstr)
1292         (print_field_values, ada_val_print_ref, ada_val_print): Use
1293         metadata style.
1294         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1295         style.
1296         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1297         style.
1298         * ada-lang.c (user_select_syms): Use metadata style.
1299
1300 2019-10-01  Tom Tromey  <tom@tromey.com>
1301
1302         * cli/cli-cmds.c (pwd_command): Style output.
1303
1304 2019-10-01  Pedro Alves  <palves@redhat.com>
1305             Tom Tromey  <tom@tromey.com>
1306
1307         * symtab.c (print_symbol_info): Use %ps.
1308         (print_msymbol_info): Use %ps.
1309         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1310         * printcmd.c (print_variable_and_value): Use %ps.
1311         * macrocmd.c (show_pp_source_pos): Use %ps.
1312         * infrun.c (print_exited_reason): Use ui_out::message.
1313         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1314         (describe_other_breakpoints): Use ui_out::message and new
1315         formats.
1316         (say_where): Use new formats.
1317         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1318         and new formats.
1319
1320 2019-10-01  Pedro Alves  <palves@redhat.com>
1321             Tom Tromey  <tom@tromey.com>
1322
1323         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1324         (test_gdb_formats): New function.
1325         (run_tests): Call it.
1326         (test_format_specifier): Update.
1327         * utils.h (fputs_filtered): Update comment.
1328         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1329         (fputs_styled_unfiltered): Declare.
1330         * utils.c (fputs_styled_unfiltered): New function.
1331         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1332         (vfprintf_filtered): Update.
1333         (vfprintf_unfiltered, vprintf_filtered): Update.
1334         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1335         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1336         disallow_ui_out_field>: New constants.
1337         (enum class field_kind): New.
1338         (struct base_field_s, struct signed_field_s): New.
1339         (signed_field): New function.
1340         (struct string_field_s): New.
1341         (string_field): New function.
1342         (struct styled_string_s): New.
1343         (styled_string): New function.
1344         (class ui_out) <message>: Add comment.
1345         <vmessage, call_do_message>: New methods.
1346         <do_message>: Add style parameter.
1347         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1348         methods.
1349         (ui_out::message): Rewrite.
1350         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1351         parameter.
1352         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1353         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1354         gdb_extensions parameter.
1355         (class format_piece): Add parameter to constructor.
1356         (n_int_args): New field.
1357         * gdbsupport/format.c (format_pieces::format_pieces): Add
1358         gdb_extensions parameter.  Handle '*'.
1359         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1360         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1361         vfprintf_styled_no_gdbfmt.
1362         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1363         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1364         unfiltered output.
1365         * ui-style.h (struct ui_file_style) <ptr>: New method.
1366
1367 2019-10-01  Tom Tromey  <tom@tromey.com>
1368
1369         * unittests/format_pieces-selftests.c: Update.  Add final format.
1370         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1371         empty literal pieces.
1372
1373 2019-10-01  Tom Tromey  <tom@tromey.com>
1374
1375         * ui-out.h (enum class ui_out_style_kind): Remove.
1376         (class ui_out) <field_string, field_stsream, do_field_string>:
1377         Change type of "style".
1378         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1379         (ui_out::field_string): Update.
1380         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1381         of "style".
1382         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1383         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1384         * stack.c (print_frame_arg, print_frame_info, print_frame):
1385         Update.
1386         * source.c (print_source_lines_base): Update.
1387         * solib.c (info_sharedlibrary_command): Update.
1388         * skip.c (info_skip_command): Update.
1389         * record-btrace.c (btrace_call_history_src_line)
1390         (btrace_call_history): Update.
1391         * python/py-framefilter.c (py_print_frame): Update.
1392         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1393         "style".
1394         * mi/mi-out.c (mi_ui_out::do_table_header)
1395         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1396         (mi_ui_out::do_field_string): Update.
1397         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1398         Update.
1399         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1400         "style".
1401         * cli-out.c (cli_ui_out::do_table_header)
1402         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1403         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1404         (cli_ui_out::do_field_fmt): Update.
1405         * breakpoint.c (print_breakpoint_location): Update.
1406         (update_static_tracepoint): Update.
1407
1408 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1409
1410         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1411         conversion of gdb_datadir.
1412         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1413         remove not needed c_str ().
1414
1415 2019-09-30  Ali Tamur <tamur@google.com>
1416
1417         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1418         (dwarf2_string_attr): Likewise.
1419
1420 2019-09-30  Ali Tamur <tamur@google.com>
1421
1422         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1423         (process_full_type_unit): Likewise.
1424         (dump_die_shallow): Likewise.
1425         (cu_debug_loc_section): Likewise.
1426
1427 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1428
1429         * minsyms.c (compare_minimal_symbols): Rename to...
1430         (minimal_symbol_is_less_than): ...this, and adjust to STL
1431         conventions (return bool, take arguments as references)
1432         (minimal_symbol_reader::install): Call std::sort instead
1433         of qsort.
1434
1435 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1436
1437         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1438         hash and why.
1439         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1440         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1441
1442 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1443
1444         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1445         * psympriv.h (add_psymbol_to_list): Move comment here and update
1446         it.
1447
1448 2019-09-29  Tom de Vries  <tdevries@suse.de>
1449
1450         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1451         Use $tmpdir/$(basename "$output_file").dwz instead of
1452         "${output_file}.dwz".
1453
1454 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1455
1456         PR gdb/25045
1457         * hppa-linux-nat.c: Include gdbarch.h.
1458
1459 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1460
1461         * blockframe.c (find_pc_partial_function): Change return type to bool.
1462         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1463         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1464         (stub_gnu_ifunc_resolve_name): Likewise.
1465         * symtab.c (compare_filenames_for_search): Likewise.
1466         (compare_glob_filenames_for_search): Likewise.
1467         (matching_obj_sections): Likewise.
1468         (symbol_matches_domain): Likewise.
1469         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1470         (find_line_pc): Change return type to bool.
1471         (find_line_pc_range): Likewise.
1472         (producer_is_realview): Likewise.
1473         * symtab.h (symbol_matches_domain): Likewise.
1474         (find_pc_partial_function): Likewise.
1475         (find_pc_line_pc_range): Likewise.
1476         (in_gnu_ifunc_stub): Likewise.
1477         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1478         (find_line_pc): Likewise.
1479         (find_line_pc_range): Likewise.
1480         (matching_obj_sections): Likewise.
1481         (find_line_symtab): Change out parameter to bool.
1482         (producer_is_realview): Change return type to bool.
1483         (compare_filenames_for_search): Likewise.
1484         (compare_glob_filenames_for_search): Likewise.
1485
1486 2019-09-26  Tom Tromey  <tom@tromey.com>
1487
1488         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1489         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1490         * gdb_usleep.h: Remove.
1491         * gdb_usleep.c: Remove.
1492         * utils.c: Don't include gdb_usleep.h.
1493
1494 2019-09-26  Tom Tromey  <tromey@adacore.com>
1495
1496         * python/py-type.c (type_to_type_object): Call check_typedef
1497         for stub types.
1498
1499 2019-09-26  Tom Tromey  <tom@tromey.com>
1500
1501         * utils.h (initialize_utils): Don't declare.
1502         * top.c (gdb_init): Don't call initialize_utils.
1503         * utils.c (initialize_utils): Remove.  Move contents...
1504         (_initialize_utils): ... here.
1505
1506 2019-09-25  Tom Tromey  <tom@tromey.com>
1507
1508         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1509         * utils.h (make_hex_string): Don't declare.
1510         * utils.c (make_hex_string): Remove.
1511
1512 2019-09-24  Tom de Vries  <tdevries@suse.de>
1513
1514         PR gdb/23815
1515         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1516         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1517
1518 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1519
1520         * NEWS: Mention new simulator port for PRU.
1521
1522 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1523
1524         * ada-exp.y (write_object_remaining): Update.
1525         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1526         and eliminate the static buffer.
1527         (ada_decode_symbol): Update.
1528         (ada_la_decode): Update.
1529         (ada_sniff_from_mangled_name): Update.
1530         (is_valid_name_for_wild_match): Update.
1531         (ada_lookup_name_info::matches): Update and simplify.
1532         (name_matches_regex): Update.
1533         (ada_add_global_exceptions): Update.
1534         * ada-lang.h (ada_decode): Update signature.
1535         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1536         * dwarf-index-write.c (debug_names::insert): Update.
1537
1538 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1539
1540         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1541         formatting.
1542
1543 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1544
1545         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1546         Change "nonzero" to "true" in documentation.
1547
1548 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1549
1550         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1551         (_initialize_darwin_solib): Don't set
1552         darwin_so_ops.lookup_lib_global_symbol.
1553         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1554         set_gdbarch_iterate_over_objfiles_in_search_order.
1555         (elf_lookup_lib_symbol): Rename to...
1556         (svr4_iterate_over_objfiles_in_search_order): this, and update
1557         to iterate semantics.
1558         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1559         * solib.c (solib_global_lookup): Remove.
1560         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1561         (solib_global_lookup): Remove.
1562         * symtab.c (lookup_global_or_static_symbol): Remove call to
1563         solib_global_lookup.
1564
1565 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1566
1567         * NEWS: Move entries about default MI version now being
1568         version 3, and about the GDB/MI fix for multi-location
1569         breakpoints to the "since GDB 8.3" section.
1570
1571 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1572
1573         GDB 8.3.1 released.
1574
1575 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1576
1577         * NEWS: Mention that Cell/B.E. debugging support was removed.
1578         * MAINTAINERS: Remove spu target.
1579
1580         * config/djgpp/fnchange.lst: Remove entries for removed files.
1581
1582         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1583         spu-multiarch.o, and spu-tdep.o.
1584         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1585         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1586         spu-multiarch.c, and spu-tdep.c.
1587         * spu-linux-nat.c: Remove file.
1588         * spu-multiarch.c: Remove file.
1589         * spu-tdep.c: Remove file.
1590         * spu-tdep.h: Remove file.
1591         * solib-spu.c: Remove file.
1592         * solib-spu.h: Remove file.
1593
1594         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1595         * configure.nat (spu-linux): Remove.
1596         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1597         solib-multiarch.o from gdb_target_obs.
1598         (spu*-*-*): Remove.
1599
1600         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1601         feature flag.
1602         (ppc_linux_no_features): Update.
1603         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1604         Cell/B.E. support.
1605         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1606         (tdesc_powerpc_cell64l): Likewise.
1607         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1608         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1609         Cell/B.E. support.
1610         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1611         Do not include "features/rs6000/powerpc-cell32l.c" or
1612         "features/rs6000/powerpc-cell64l.c".
1613         (ppc_linux_spu_section): Remove.
1614         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1615         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1616         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1617         (ppc_linux_spe_context_lookup): Remove.
1618         (ppc_linux_spe_context_inferior_created): Remove.
1619         (ppc_linux_spe_context_solib_loaded): Remove.
1620         (ppc_linux_spe_context_solib_unloaded): Remove.
1621         (ppc_linux_spe_context): Remove.
1622         (struct ppu2spu_cache): Remove.
1623         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1624         (struct ppu2spu_data): Remove.
1625         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1626         ppu2spu_unwind): Remove.
1627         (ppc_linux_init_abi): Remove Cell/B.E. support.
1628         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1629
1630         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1631         (rs6000/powerpc-cell64l-expedite): Likewise
1632         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1633         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1634         rs6000/powerpc-cell64l.xml.
1635         * features/rs6000/powerpc-cell32l.xml: Remove.
1636         * features/rs6000/powerpc-cell64l.xml: Likewise.
1637         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1638         * features/rs6000/powerpc-cell64l.c: Likewise.
1639         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1640         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1641         * regformats/reg-spu.dat: Remove.
1642
1643         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1644         * corelow.c (struct spuid_list): Remove.
1645         (add_to_spuid_list): Remove.
1646         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1647         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1648         (remote_protocol_features): Remove associated entries.
1649         (_initialize_remote): No longer initialize them.
1650         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1651         * linux-nat.c (SPUFS_MAGIC): Remove.
1652         (linux_proc_xfer_spu): Remove.
1653         (spu_enumerate_spu_ids): Remove.
1654         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1655         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1656         (linux_make_corefile_notes): No longer call it.
1657
1658         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1659         (cooked_write_test): Likewise.
1660
1661 2019-09-20  Tom Tromey  <tom@tromey.com>
1662
1663         * NEWS: Mention case-sensitivity of TUI commands.
1664         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1665         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1666         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1667
1668 2019-09-20  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-source.c (tui_source_window::set_contents): Use
1671         make_unique_xstrdup.
1672         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1673         make_unique_xstrdup.
1674
1675 2019-09-20  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-data.c: Remove separator comments.
1678         * tui/tui-layout.c: Remove separator comments.
1679         * tui/tui-win.c: Remove separator comments.
1680         * tui/tui-wingeneral.c: Remove separator comments.
1681
1682 2019-09-20  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui.h (strcat_to_buf): Don't declare.
1685         * tui/tui.c (strcat_to_buf): Remove.
1686
1687 2019-09-20  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1690         from "fullname".
1691         * tui/tui-source.c (tui_source_window::set_contents)
1692         (tui_source_window::location_matches_p)
1693         (tui_source_window::maybe_update): Update.
1694
1695 2019-09-20  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1698         Update.
1699         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1700         prefix.
1701         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1702         (tui_data_window::line_from_reg_element_no)
1703         (tui_data_window::first_reg_element_no_inline)
1704         (tui_data_window::show_registers)
1705         (tui_data_window::show_register_group)
1706         (tui_data_window::display_registers_from)
1707         (tui_data_window::display_registers_from_line)
1708         (tui_data_window::first_data_item_displayed)
1709         (tui_data_window::delete_data_content_windows)
1710         (tui_data_window::erase_data_content)
1711         (tui_data_window::do_scroll_vertical)
1712         (tui_data_window::refresh_window)
1713         (tui_data_window::check_register_values): Update.
1714
1715 2019-09-20  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1718         (struct tui_locator_window) <full_name, proc_name>: Now
1719         std::string.
1720         * tui/tui-stack.c (tui_locator_window::make_status_line)
1721         (tui_locator_window::set_locator_fullname)
1722         (tui_locator_window::set_locator_info): Update.
1723         * tui/tui-source.c (tui_source_window::set_contents)
1724         (tui_source_window::showing_source_p): Update.
1725
1726 2019-09-20  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1729         Don't call tui_locator_win_info_ptr.
1730
1731 2019-09-20  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1734
1735 2019-09-20  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1738         height for locator.
1739         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1740         * tui/tui-layout.c (show_source_disasm_command, show_data)
1741         (show_source_or_disasm_and_command): Use 1 as height for locator.
1742
1743 2019-09-20  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui.c (tui_enable): Update.
1746         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1747         Update.
1748         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1749         Update.
1750         * tui/tui-data.c (win_resized): Now bool.
1751         (tui_win_resized): Return bool.
1752         (tui_set_win_resized_to): Accept a bool.
1753
1754 2019-09-20  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1757         Change type of "refresh_values_only".
1758         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1759         type of "refresh_values_only".
1760
1761 2019-09-20  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1764         std::string.
1765         (tui_disassemble): Add "pos" parameter.
1766         (tui_disasm_window::set_contents): Simplify.
1767
1768 2019-09-20  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-winsource.h (struct tui_source_window_base)
1771         <show_source_content>: Now private.
1772         * tui/tui-winsource.c
1773         (tui_source_window_base::show_source_content): Don't handle empty
1774         content case.
1775
1776 2019-09-20  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-layout.c (show_source_disasm_command)
1779         (show_source_or_disasm_and_command): Don't call
1780         show_source_content.
1781
1782 2019-09-20  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1785         Declare.
1786         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1787         from tui_make_status_line.
1788         (tui_locator_window::rerender): Update.
1789
1790 2019-09-20  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1793         (tui_locator_window::rerender): Update.
1794
1795 2019-09-20  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-winsource.h (struct tui_source_window_base)
1798         <~tui_source_window_base>: Don't declare.
1799         <fullname>: Remove.
1800         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1801         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1802         member.
1803         * tui/tui-source.c (tui_source_window::set_contents): Update.
1804         (tui_source_window::location_matches_p)
1805         (tui_source_window::maybe_update): Update.
1806
1807 2019-09-20  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-winsource.h (~tui_source_element): Remove.
1810         (tui_source_element): Update.
1811         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1812         * tui/tui-winsource.c (tui_show_source_line): Update.
1813         * tui/tui-source.c (tui_source_window::set_contents): Update.
1814         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1815
1816 2019-09-20  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1819         declare.
1820         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1821         tui_clear_source_windows_detail.
1822         * tui/tui-winsource.h (struct tui_source_window_base)
1823         <clear_detail>: Don't declare.
1824         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1825         Remove.
1826         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1827
1828 2019-09-20  Tom Tromey  <tromey@adacore.com>
1829
1830         PR ada/24919:
1831         * block.c (contained_in): Fix final return value.
1832
1833 2019-09-20  Alan Modra  <amodra@gmail.com>
1834
1835         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1836         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1837         (read_indirect_string_from_dwz): Use bfd accessor.
1838         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1839         * machoread.c (macho_symfile_read_all_oso): Likewise.
1840         * solib.c (solib_bfd_open): Likewise.
1841
1842 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1843
1844         * eval.c: Move declaration of overload_resolution to...
1845         * value.h: ...here.
1846
1847 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1848
1849         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1850         * arm-linux-tdep.c: Likewise.
1851         * arm-nbsd-nat.c: Likewise.
1852         * arm-tdep.h: Declare arm_apcs_32.
1853         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1854
1855 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1856
1857         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1858         * dwarf2read.h: Declare dwarf_always_disassemble.
1859
1860 2019-09-19  Tom de Vries  <tdevries@suse.de>
1861
1862         PR gdb/25009
1863         * source-cache.c (source_cache::ensure): Catch exception thrown during
1864         construction of the highlighter.
1865
1866 2019-09-18  Alan Modra  <amodra@gmail.com>
1867
1868         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1869         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1870         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1871         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1872         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1873         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1874         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1875         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1876         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1877         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1878         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1879         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1880         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1881         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1882         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1883         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1884         * mi/mi-interp.c: Update throughout for bfd section macro and
1885         function changes.
1886         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1887         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1888
1889 2019-09-18  Tom Tromey  <tom@tromey.com>
1890
1891         * NEWS: Add entry.
1892         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1893         call rl_initialize.
1894         (tui_enable): Do not call rl_initialize.
1895
1896 2019-09-18  Christian Groessler  <chris@groessler.org>
1897
1898         * alpha-linux-nat.c: Include gdbarch.h.
1899
1900 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1901
1902         * ui-file.c: Include cli/cli-style.h.
1903         (term_cli_styling): Remove cli_styling declaration.
1904
1905 2019-09-18  Alan Modra  <amodra@gmail.com>
1906
1907         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1908         to bfd_asymbol_section.
1909
1910 2019-09-18  Alan Modra  <amodra@gmail.com>
1911
1912         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1913         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1914         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1915
1916 2019-09-18  Alan Modra  <amodra@gmail.com>
1917
1918         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1919         * spu-linux-nat.c (spu_bfd_open): Likewise.
1920
1921 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1922
1923         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1924         to bool to match definition in dwarf2read.c.
1925
1926 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1927
1928         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1929         (print_signatures): Likewise.
1930         (trust_pad_over_xvs): Likewise.
1931         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1932         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1933         * arm-linux-nat.c (arm_apcs_32): Likewise.
1934         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1935         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1936         * arm-tdep.c (arm_debug): Likewise.
1937         (arm_apcs_32): Likewise.
1938         * auto-load.c (debug_auto_load): Likewise.
1939         (auto_load_gdb_scripts): Likewise.
1940         (global_auto_load): Likewise.
1941         (auto_load_local_gdbinit): Likewise.
1942         (auto_load_local_gdbinit_loaded): Likewise.
1943         * auto-load.h (global_auto_load): Likewise.
1944         (auto_load_local_gdbinit): Likewise.
1945         (auto_load_local_gdbinit_loaded): Likewise.
1946         * breakpoint.c (disconnected_dprintf): Likewise.
1947         (breakpoint_proceeded): Likewise.
1948         (automatic_hardware_breakpoints): Likewise.
1949         (always_inserted_mode): Likewise.
1950         (target_exact_watchpoints): Likewise.
1951         (_initialize_breakpoint): Update.
1952         * breakpoint.h (target_exact_watchpoints): Change to bool.
1953         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1954         * cli/cli-cmds.c (trace_commands): Likewise.
1955         * cli/cli-cmds.h (trace_commands): Likewise.
1956         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1957         to bool*.
1958         * cli/cli-logging.c (logging_overwrite): Change to bool.
1959         (logging_redirect): Likewise.
1960         (debug_redirect): Likewise.
1961         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1962         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1963         to bool.
1964         <boolean_option_def>: Update.
1965         (struct flag_option_def): Change default type of Context to bool
1966         from int.
1967         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1968         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1969         (get_setshow_command_value_string): Likewise.
1970         * cli/cli-style.c (cli_styling): Change to bool.
1971         (source_styling): Likewise.
1972         * cli/cli-style.h (source_styling): Likewise.
1973         (cli_styling): Likewise.
1974         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1975         to bool.
1976         * command.h (var_types): Update comment.
1977         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1978         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1979         bool.
1980         (debug_compile_cplus_scopes): Likewise.
1981         * compile/compile-internal.h (compile_debug): Likewise.
1982         * compile/compile.c (compile_debug): Likewise.
1983         (struct compile_options) <raw>: Likewise.
1984         * cp-support.c (catch_demangler_crashes): Likewise.
1985         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1986         (usr_cmd_cris_dwarf2_cfi): Likewise.
1987         * csky-tdep.c (csky_debug): Likewise.
1988         * darwin-nat.c (enable_mach_exceptions): Likewise.
1989         * dcache.c (dcache_enabled_p): Likewise.
1990         * defs.h (info_verbose): Likewise.
1991         * demangle.c (demangle): Likewise.
1992         (asm_demangle): Likewise.
1993         * dwarf-index-cache.c (debug_index_cache): Likewise.
1994         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1995         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1996         * dwarf2read.c (check_physname): Likewise.
1997         (use_deprecated_index_sections): Likewise.
1998         (dwarf_always_disassemble): Likewise.
1999         * eval.c (overload_resolution): Likewise.
2000         * event-top.c (set_editing_cmd_var): Likewise.
2001         (exec_done_display_p): Likewise.
2002         * event-top.h (set_editing_cmd_var): Likewise.
2003         (exec_done_display_p): Likewise.
2004         * exec.c (write_files): Likewise.
2005         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2006         (debug_fbsd_nat): Likewise.
2007         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2008         Likewise.
2009         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2010         <backtrace_past_entry> Likewise.
2011         * gdb-demangle.h (demangle): Likewise.
2012         (asm_demangle): Likewise.
2013         * gdb_bfd.c (bfd_sharing): Likewise.
2014         * gdbcore.h (write_files): Likewise.
2015         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2016         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2017         * gdbthread.h (print_thread_events): Likewise.
2018         * gdbtypes.c (opaque_type_resolution): Likewise.
2019         (strict_type_checking): Likewise.
2020         * gnu-nat.c (gnu_debug_flag): Likewise.
2021         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2022         * guile/scm-param.c (pascm_variable): Add boolval.
2023         (add_setshow_generic): Update.
2024         (pascm_param_value): Update.
2025         (pascm_set_param_value_x): Update.
2026         * hppa-tdep.c (hppa_debug): Change to bool..
2027         * infcall.c (may_call_functions_p): Likewise.
2028         (coerce_float_to_double_p): Likewise.
2029         (unwind_on_signal_p): Likewise.
2030         (unwind_on_terminating_exception_p): Likewise.
2031         * infcmd.c (startup_with_shell): Likewise.
2032         * inferior.c (print_inferior_events): Likewise.
2033         * inferior.h (startup_with_shell): Likewise.
2034         (print_inferior_events): Likewise.
2035         * infrun.c (step_stop_if_no_debug): Likewise.
2036         (detach_fork): Likewise.
2037         (debug_displaced): Likewise.
2038         (disable_randomization): Likewise.
2039         (non_stop): Likewise.
2040         (non_stop_1): Likewise.
2041         (observer_mode): Likewise.
2042         (observer_mode_1): Likewise.
2043         (set_observer_mode): Update.
2044         (sched_multi): Change to bool.
2045         * infrun.h (debug_displaced): Likewise.
2046         (sched_multi): Likewise.
2047         (step_stop_if_no_debug): Likewise.
2048         (non_stop): Likewise.
2049         (disable_randomization): Likewise.
2050         * linux-tdep.c (use_coredump_filter): Likewise.
2051         (dump_excluded_mappings): Likewise.
2052         * linux-thread-db.c (auto_load_thread_db): Likewise.
2053         (check_thread_db_on_load): Likewise.
2054         * main.c (captured_main_1): Update.
2055         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2056         xx2_opt, boolean_opt>: Change to bool.
2057         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2058         * maint.c (maintenance_profile_p): Likewise.
2059         (per_command_time): Likewise.
2060         (per_command_space): Likewise.
2061         (per_command_symtab): Likewise.
2062         * memattr.c (inaccessible_by_default): Likewise.
2063         * mi/mi-main.c (mi_async): Likewise.
2064         (mi_async_1): Likewise.
2065         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2066         * nat/fork-inferior.h (startup_with_shell): Likewise.
2067         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2068         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2069         * nios2-tdep.c (nios2_debug): Likewise.
2070         * or1k-tdep.c (or1k_debug): Likewise.
2071         * parse.c (parser_debug): Likewise.
2072         * parser-defs.h (parser_debug): Likewise.
2073         * printcmd.c (print_symbol_filename): Likewise.
2074         * proc-api.c (procfs_trace): Likewise.
2075         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2076         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2077         (set_parameter_value): Update.
2078         (add_setshow_generic): Update.
2079         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2080         to bool*.
2081         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2082         int*.
2083         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2084         * record-btrace.c (record_btrace_target::store_registers): Update.
2085         * record-full.c (record_full_memory_query): Change to bool.
2086         (record_full_stop_at_limit): Likewise.
2087         * record-full.h (record_full_memory_query): Likewise.
2088         * remote-notif.c (notif_debug): Likewise.
2089         * remote-notif.h (notif_debug): Likewise.
2090         * remote.c (use_range_stepping): Likewise.
2091         (interrupt_on_connect): Likewise.
2092         (remote_break): Likewise.
2093         * ser-tcp.c (tcp_auto_retry): Likewise.
2094         * ser-unix.c (serial_hwflow): Likewise.
2095         * skip.c (debug_skip): Likewise.
2096         * solib-aix.c (solib_aix_debug): Likewise.
2097         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2098         (spu_auto_flush_cache_p): Likewise.
2099         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2100         Likewise.
2101         (struct info_print_options) <quiet>: Likewise.
2102         * symfile-debug.c (debug_symfile): Likewise.
2103         * symfile.c (auto_solib_add): Likewise.
2104         (separate_debug_file_debug): Likewise.
2105         * symfile.h (auto_solib_add): Likewise.
2106         (separate_debug_file_debug): Likewise.
2107         * symtab.c (basenames_may_differ): Likewise.
2108         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2109         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2110         (struct info_types_options) <quiet>: Likewise.
2111         * symtab.h (demangle): Likewise.
2112         (basenames_may_differ): Likewise.
2113         * target-dcache.c (stack_cache_enabled_1): Likewise.
2114         (code_cache_enabled_1): Likewise.
2115         * target.c (trust_readonly): Likewise.
2116         (may_write_registers): Likewise.
2117         (may_write_memory): Likewise.
2118         (may_insert_breakpoints): Likewise.
2119         (may_insert_tracepoints): Likewise.
2120         (may_insert_fast_tracepoints): Likewise.
2121         (may_stop): Likewise.
2122         (auto_connect_native_target): Likewise.
2123         (target_stop_and_wait): Update.
2124         (target_async_permitted): Change to bool.
2125         (target_async_permitted_1): Likewise.
2126         (may_write_registers_1): Likewise.
2127         (may_write_memory_1): Likewise.
2128         (may_insert_breakpoints_1): Likewise.
2129         (may_insert_tracepoints_1): Likewise.
2130         (may_insert_fast_tracepoints_1): Likewise.
2131         (may_stop_1): Likewise.
2132         * target.h (target_async_permitted): Likewise.
2133         (may_write_registers): Likewise.
2134         (may_write_memory): Likewise.
2135         (may_insert_breakpoints): Likewise.
2136         (may_insert_tracepoints): Likewise.
2137         (may_insert_fast_tracepoints): Likewise.
2138         (may_stop): Likewise.
2139         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2140         (make_thread_apply_all_options_def_group): Change argument from int*
2141         to bool*.
2142         (thread_apply_all_command): Update.
2143         (print_thread_events): Change to bool.
2144         * top.c (confirm): Likewise.
2145         (command_editing_p): Likewise.
2146         (history_expansion_p): Likewise.
2147         (write_history_p): Likewise.
2148         (info_verbose): Likewise.
2149         * top.h (confirm): Likewise.
2150         (history_expansion_p): Likewise.
2151         * tracepoint.c (disconnected_tracing): Likewise.
2152         (circular_trace_buffer): Likewise.
2153         * typeprint.c (print_methods): Likewise.
2154         (print_typedefs): Likewise.
2155         * utils.c (debug_timestamp): Likewise.
2156         (sevenbit_strings): Likewise.
2157         (pagination_enabled): Likewise.
2158         * utils.h (sevenbit_strings): Likewise.
2159         (pagination_enabled): Likewise.
2160         * valops.c (overload_resolution): Likewise.
2161         * valprint.h (struct value_print_options) <prettyformat_arrays,
2162         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2163         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2164         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2165         Likewise.
2166         * windows-nat.c (new_console): Likewise.
2167         (cygwin_exceptions): Likewise.
2168         (new_group): Likewise.
2169         (debug_exec): Likewise.
2170         (debug_events): Likewise.
2171         (debug_memory): Likewise.
2172         (debug_exceptions): Likewise.
2173         (useshell): Likewise.
2174         * windows-tdep.c (maint_display_all_tib): Likewise.
2175         * xml-support.c (debug_xml): Likewise.
2176
2177 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2178
2179         * source.c (prepare_path_for_appending): New function.
2180         (openp): Make use of new function.
2181         (find_and_open_source): Search for the compilation directory and
2182         source file as a relative path beneath the directory search path.
2183
2184 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2185
2186         * source-cache.c (source_cache::get_line_charpos): Catch
2187         exceptions and return false, this matches the behaviour documented
2188         in the header file.
2189
2190 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2191
2192         * ada-tasks.c (info_task): Remove quoting of the task's name.
2193
2194 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2195
2196         * symfile.c (auto_solib_add): Replace comment with a reference
2197         to the header file.
2198
2199 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2200
2201         * NEWS: Mention that gdb can now be compiled with Python 3
2202         on Windows.
2203
2204 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * maint.c (maint_print_section_data::maint_print_section_data):
2207         Force use of 'float log10 (float)' by casting the argument to
2208         float.
2209
2210 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * maint.c: Add 'cmath' include.
2213         (struct maint_print_section_data): New structure.
2214         (print_section_index): New function.
2215         (print_bfd_section_info): Add header comment, small whitespace
2216         cleanup, and update to call new print_section_index function.
2217         (print_objfile_section_info): Likewise.
2218         (maint_obj_section_from_bfd_section): New function.
2219         (print_bfd_section_info_maybe_relocated): New function.
2220         (maintenance_info_sections): Add header comment, always use
2221         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2222
2223 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2226         inner scope, add check that the objfile has psymtabs before
2227         checking psymtabs_addrmap.
2228         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2229
2230 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2231
2232         * NEWS: Announce that Ada task names are now shown at more places,
2233         and between quotes (except in info task output).
2234         * gdb/ada-tasks.c (task_to_str): New function.
2235         (display_current_task_id): Call task_to_str.
2236         (task_command_1): Likewise.
2237         (print_ada_task_info): In non-mi mode, Properly align headers and data
2238         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2239
2240 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2241
2242         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2243         prstatus.pr_lwp.pr_info instead of making it up.
2244
2245 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2246
2247         * auto-load.c (auto_load_expand_dir_vars): Update.
2248         * defs.h (gdb_datadir): Change to std::string.
2249         (python_libdir): Likewise.
2250         (relocate_gdb_directory): Change return type to std::string.
2251         * guile/guile.c (gdbscm_data_directory): Update.
2252         (initialize_scheme_side): Update.
2253         * jit.c (jit_reader_dir): Change to std::string.
2254         (jit_reader_load_command): Update.
2255         * main.c (gdb_datadir): Change to std::string.
2256         (python_libdir): Likewise.
2257         (set_gdb_data_directory): Update.
2258         (relocate_path): Change to return std::string.
2259         (relocate_gdb_directory): Change to return std::string.
2260         (relocate_gdbinit_path_maybe_in_datadir): Update.
2261         (captured_main_1): Update.
2262         * python/python.c (do_start_initialization): Update.
2263         * top.c (show_gdb_datadir): Update.
2264         * xml-syscall.c (xml_init_syscalls_info): Update.
2265         (init_syscalls_info): Update.
2266
2267 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2268
2269         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2270         out of get_init_files.
2271         (get_init_files): Update.
2272
2273 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2274
2275         * main.c (get_init_files): Change to use std::string.
2276         (captured_main_1): Update.
2277         (print_gdb_help): Update.
2278
2279 2019-09-11  Ali Tamur  <tamur@google.com>
2280
2281         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2282         implementation.
2283
2284 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2285
2286         * dbxread.c (read_dbx_symtab): Update.
2287         * dwarf2read.c (load_partial_dies): Update.
2288         * mdebugread.c (parse_partial_symbols): Update.
2289         (handle_psymbol_enumerators): Update.
2290         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2291         * psymtab.c (add_psymbol_to_bcache): Likewise.
2292         (add_psymbol_to_list): Likewise.
2293         * symtab.c (symbol_set_names): Likewise.
2294         * symtab.h (symbol_set_names): Likewise.
2295         * xcoffread.c (scan_xcoff_symtab): Update.
2296
2297 2019-09-11  Tom Tromey  <tom@tromey.com>
2298
2299         * symfile-mem.c (symbol_file_add_from_memory): Use
2300         bfd_set_filename.
2301         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2302         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2303
2304 2019-09-10  Tom Tromey  <tromey@adacore.com>
2305
2306         * dwarf-index-write.c (write_psymbols): Extend error message.
2307         (debug_names::insert): Add Ada code.
2308         (debug_names::write_psymbols): Remove Ada check.
2309         (debug_names) <m_string_obstack>: New member.
2310         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2311         (gdb_index_symbol_name_matcher::matches): Remove.
2312         (mapped_index_base::find_name_components_bounds): Add "lang"
2313         parameter.
2314         (mapped_index_base::build_name_components): Also split names
2315         according to Ada syntax.
2316         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2317         type of "match_callback".
2318         (check_match, check_find_bounds_finds)
2319         (dw2_expand_symtabs_matching): Update.
2320         (dw2_debug_names_iterator): Add new constructor.
2321         (dw2_debug_names_map_matching_symbols): New function.
2322         (dw2_debug_names_expand_symtabs_matching): Update.
2323         (dwarf2_debug_names_functions): Use
2324         dw2_debug_names_map_matching_symbols.
2325
2326 2019-09-10  Tom Tromey  <tromey@adacore.com>
2327
2328         * dwarf2read.c (dw2_get_file_names_reader): Add the
2329         CU's file name to the results.
2330
2331 2019-09-10  Tom Tromey  <tromey@adacore.com>
2332
2333         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2334         map_matching_symbols.  Update.
2335         * dwarf2read.c (dw2_map_matching_symbols): Update.
2336         * psymtab.c (match_partial_symbol): Change type; update.
2337         (psym_map_matching_symbols): Likewise.
2338         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2339         type; update.
2340         * symfile.h (struct quick_symbol_functions)
2341         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2342         Remove "match".
2343
2344 2019-09-10  Tom Tromey  <tromey@adacore.com>
2345
2346         * psymtab.c (map_block): Remove.
2347         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2348         * symtab.c (iterate_over_symbols_terminated): New function.
2349         * symtab.c (iterate_over_symbols_terminated): Declare.
2350
2351 2019-09-10  Tom Tromey  <tromey@adacore.com>
2352
2353         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2354         * language.h (struct language_defn) <la_iterate_over_symbols>:
2355         Return bool.
2356         * symtab.c (iterate_over_symbols): Return bool.
2357         * symtab.h (iterate_over_symbols): Return bool.
2358
2359 2019-09-10  Tom Tromey  <tromey@adacore.com>
2360
2361         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2362         (add_nonlocal_symbols): Update.
2363         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2364         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2365         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2366         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2367         Change type of "callback".  Remove "data".
2368
2369
2370 2019-09-09  Ali Tamur  <tamur@google.com>
2371
2372         * dwarf2read.c (comp_unit_head): Update comment.
2373         (dwarf2_dwo_name): New function declaration.
2374         (dwarf_unit_type_name): New function declaration.
2375         (read_comp_unit_head): Add support for new compilation units,
2376         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2377         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2378         (currently named as "signature") in their header. Also clarify error
2379         messages.
2380         (lookup_dwo_id): New function. Returns the dwo id of the given
2381         compile unit.
2382         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2383         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2384         functions.
2385         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2386         (dwarf2_dwo_name): Get the dwo name if present.
2387         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2388         purposes.
2389
2390 2019-09-09  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2393
2394 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2395
2396         * python/python.c (do_start_initialization): Make progname_copy static,
2397         to avoid a leak report.
2398
2399 2019-09-08  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2402
2403 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2404
2405         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2406         Change type to gdb::optional<block_enum>.
2407         (dw2_symtab_iter_init): Change block_index parameter type
2408         to gdb::optional<block_enum>.
2409         (dw2_lookup_symbol): Change block_index parameter
2410         type to block_enum.c
2411         (dw2_debug_names_lookup_symbol): Likewise.
2412         * psymtab.c (psym_lookup_symbol): Likewise.
2413         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2414         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2415         Likewise.
2416
2417 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2418
2419         * defs.h (relocate_gdb_directory): Change int to bool in
2420         signature and rename flag to relocatable.
2421         * main.c (relocate_path): Likewise.
2422         (relocate_gdb_directory): Likewise.
2423
2424 2019-09-06  Alan Modra  <amodra@gmail.com>
2425
2426         * coffread.c (coff_symfile_read): Constify filename variable.
2427         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2428         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2429         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2430         * solib.c (reload_shared_libraries_1): Likewise.
2431         * symfile.c (reread_symbols): Likewise.
2432         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2433         * solib-darwin.c (darwin_bfd_open): Likewise.
2434         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2435
2436 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2437
2438         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2439         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2440
2441 2019-09-03  Tom Tromey  <tromey@adacore.com>
2442
2443         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2444         types.
2445         (has_negatives): Unbias a range type bound.
2446         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2447         * gdbtypes.c (operator==): Handle new field.
2448         (create_range_type): Add "bias" parameter.
2449         (create_static_range_type, resolve_dynamic_range): Update.
2450         * gdbtypes.h (struct range_bounds) <bias>: New member.
2451         (create_range_type): Add bias parameter.
2452         * printcmd.c (print_scalar_formatted): Unbias range types.
2453         * value.c (unpack_long): Unbias range types.
2454         (pack_long): Bias range types.
2455
2456 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2457
2458         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2459         probe arguments.
2460
2461 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2462
2463         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2464         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2465         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2466         (compile_probe_arg): Likewise.
2467         * probe.h (get_argument_count): Likewise.
2468         * solib-svr4.c (solib_event_probe_action): Likewise.
2469         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2470
2471 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2472
2473         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2474         code to here...
2475         (svr4_create_solib_event_breakpoints): ...from here.
2476
2477 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2478
2479         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2480         suffix from warning message.
2481
2482 2019-08-30  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-winsource.h (struct tui_source_window_base)
2485         <refresh_all>: Don't declare.
2486         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2487         Remove.
2488         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2489         tui_show_locator_content.
2490         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2491         declare.
2492         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2493         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2494         declare.
2495
2496 2019-08-30  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2499
2500 2019-08-30  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2503         Remove unnecessary forward declarations.
2504
2505 2019-08-30  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2508         rerender.
2509         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2510         tui_show_locator_content.
2511
2512 2019-08-30  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2515         (tui_locator_window::rerender): Rewrite using body of previous
2516         tui_show_locator_content.
2517
2518 2019-08-30  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2521         set_locator_fullname>: New methods.
2522         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2523         Rename from tui_set_locator_fullname.
2524         (tui_locator_window::set_locator_info): Rename from
2525         tui_set_locator_info.  Return bool.
2526         (tui_update_locator_fullname, tui_show_frame_info): Update.
2527
2528 2019-08-30  Tom Tromey  <tom@tromey.com>
2529
2530         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2531
2532 2019-08-30  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2535         call touchwin.
2536
2537 2019-08-30  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-wingeneral.c (box_win): Assume win_info and
2540         win_info->handle cannot be NULL.
2541
2542 2019-08-30  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2545         refresh_window>: Declare.
2546         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2547         resize.
2548         (tui_data_item_window::rerender): Rename from
2549         tui_display_register.
2550         (tui_data_item_window::refresh_window): New method.
2551         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2552         no-op.
2553
2554 2019-08-30  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2557         regs_column_count, current_group>: Move later.  Now private.
2558         <get_current_group>: New method.
2559         * tui/tui-regs.c (tui_reg_command): Update.
2560         * tui/tui-layout.c (tui_set_layout): Update.
2561
2562 2019-08-30  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2565         (tui_data_window::rerender): Don't call
2566         check_and_display_highlight_if_needed.
2567         (tui_data_window::refresh_all): Remove call to
2568         erase_data_content.
2569
2570 2019-08-30  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2573         (tui_data_window::display_registers_from)
2574         (tui_data_window::display_reg_element_at_line)
2575         (tui_data_window::display_registers_from_line): Remove checks of
2576         "empty".
2577
2578 2019-08-30  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2581         Don't declare.
2582         * tui/tui-regs.c (tui_data_window::show_registers): Call
2583         rerender.
2584         (tui_data_window::rerender): Rename from display_all_data.
2585         (tui_data_window::rerender): Remove old implementation.
2586
2587 2019-08-30  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2590         text.
2591         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2592
2593 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2594             Sergio Durigan Junior  <sergiodj@redhat.com>
2595
2596         PR win32/24284
2597         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2598
2599 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2602         when searching for types.
2603
2604 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2605
2606         * f-lang.c (f_language_defn): Use f_print_typedef.
2607         * f-lang.h (f_print_typedef): Declare.
2608         * f-typeprint.c (f_print_typedef): Define.
2609
2610 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2611
2612         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2613
2614 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * cli/cli-utils.c (info_print_options_defs): Delete.
2617         (make_info_print_options_def_group): Delete.
2618         (extract_info_print_options): Delete.
2619         (info_print_command_completer): Delete.
2620         (info_print_args_help): Add extra parameter, and optionally
2621         include text about -n flag.
2622         * cli/cli-utils.h (struct info_print_options): Delete.
2623         (extract_info_print_options): Delete declaration.
2624         (info_print_command_completer): Delete declaration.
2625         (info_print_args_help): Add extra parameter, extend header
2626         comment.
2627         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2628         search_symbols.
2629         * stack.c (struct info_print_options): New type.
2630         (info_print_options_defs): New file scoped variable.
2631         (make_info_print_options_def_group): New static function.
2632         (info_print_command_completer): New static function.
2633         (info_locals_command): Update to use new local functions.
2634         (info_args_command): Likewise.
2635         (_initialize_stack): Add extra parameter to calls to
2636         info_print_args_help.
2637         * symtab.c (search_symbols): Add extra parameter, use this to
2638         possibly excluse non-debug symbols.
2639         (symtab_symbol_info): Add extra parameter, which is passed on to
2640         search_symbols.
2641         (struct info_print_options): New type.
2642         (info_print_options_defs): New file scoped variable.
2643         (make_info_print_options_def_group): New static function.
2644         (info_print_command_completer): New static function.
2645         (info_variables_command): Update to use local functions, and pass
2646         extra parameter through to symtab_symbol_info.
2647         (info_functions_command): Likewise.
2648         (info_types_command): Pass additional argument through to
2649         symtab_symbol_info.
2650         (rbreak_command): Pass extra argument to search_symbols.
2651         (_initialize_symtab): Add extra arguments for calls to
2652         info_print_args_help, and update help text for 'info variables',
2653         'whereis', and 'info functions' commands.
2654         * symtab.h (search_symbols): Add extra argument to declaration.
2655         * NEWS: Mention new flags.
2656
2657 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2658
2659         * symtab.c (lookup_static_symbol): Call the new function (and move
2660         it down to be next to lookup_global_symbol).
2661         (struct global_sym_lookup_data): Add block_enum member and rename to...
2662         (struct global_or_static_sym_lookup_data): ...this.
2663         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2664         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2665         (lookup_symbol_global_or_static_iterator_cb): ...this.
2666         (lookup_global_or_static_symbol): New function.
2667         (lookup_global_symbol): Call new function.
2668
2669 2019-08-26  Tom de Vries  <tdevries@suse.de>
2670
2671         PR c++/24852
2672         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2673         when pc_probe.prob == NULL.
2674
2675 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2676
2677         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2678         variable symbol_linkage to symbol_linkage_.
2679
2680 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2681
2682         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2683         represent whether the symbol is static, dynamic, or we don't
2684         know.
2685
2686 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2687
2688         * gdb/rx-tdep.c (rx_register_names): New.
2689         (rx_register_name): Delete.
2690         (rx_psw_type): Delete.
2691         (rx_fpsw_type): Delete.
2692         (rx_register_type): Delete.
2693         (rx_gdbarch_init): Convert target-descriptions.
2694         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2695         * gdb/features/Makefile: Add rx.xml.
2696         * gdb/features/rx.xml: New.
2697         * gdb/features/rx.c: Generated.
2698         * gdb/NEWS: Mention target description support.
2699
2700 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2701
2702         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2703         *slot_ptr.
2704
2705 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2706
2707         * configure.ac: Don't check for 'dlfcn.h' (moved to
2708         gdbsupport/common.m4).
2709         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2710         'gdbsupport/'.
2711         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2712         * compile/compile-c-support.c: Include
2713         'gdbsupport/gdb-dlfcn.h'.
2714         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2715         * gdb-dlfcn.c: Move to...
2716         * gdbsupport/gdb-dlfcn.c: ... here.
2717         * gdb-dlfcn.h: Move to...
2718         * gdbsupport/gdb-dlfcn.h: ... here.
2719
2720 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2721
2722         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2723         the offset field signed.
2724
2725 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2726
2727         * python/lib/gdb/__init__.py (_execute_file): New function.
2728         * python/python.c (python_run_simple_file): Call gdb._execute_file
2729         on Windows.
2730
2731 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2734         all uses as this was never set to anything but a zero value.
2735
2736 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2737
2738         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2739
2740 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2741
2742         * tui/tui-data.h (tui_gen_win_info): Add an =default
2743         move constructor, required by some GCC versions.
2744
2745 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2746
2747         * go32-nat.c (go32_sysinfo): Add hygon_p.
2748
2749 2019-08-20  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2752         line_from_reg_element_no, first_reg_element_no_inline,
2753         display_all_data, delete_data_content_windows,
2754         erase_data_content>: Now private.
2755
2756 2019-08-20  Tom Tromey  <tom@tromey.com>
2757
2758         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2759         (tui_unhighlight_win, tui_highlight_win)
2760         (tui_win_info::make_window): Update.
2761         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2762
2763 2019-08-20  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2766         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2767         (MAX_PID_WIDTH): Move to tui-stack.c.
2768         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2769         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2770         (MAX_PID_WIDTH): Move from tui-data.h.
2771
2772 2019-08-20  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2775         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2776         (box_win): Update.
2777         (tui_gen_win_info::make_window): Rename from tui_make_window.
2778         (tui_win_info::make_window): New method.
2779         (tui_gen_win_info::make_visible): Update.
2780         * tui/tui-source.c (tui_source_window::set_contents): Update.
2781         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2782         (tui_data_window::display_registers_from): Update.
2783         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2784         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2785         Declare.
2786         <can_box>: Remove.
2787         <title>: Remove.
2788         (struct tui_win_info) <make_window>: Declare.
2789         <can_box>: Now virtual.
2790         <title>: New member.
2791         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2792         * tui/tui-command.c (tui_cmd_window::resize): Update.
2793
2794 2019-08-20  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2797         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2798         (tui_data_window::check_register_values): Update.
2799
2800 2019-08-20  Tom Tromey  <tom@tromey.com>
2801
2802         * tui/tui-regs.h (struct tui_data_window): Use
2803         DISABLE_COPY_AND_ASSIGN.
2804         <regs_content>: Change type, removing unique_ptr.
2805         <tui_data_window>: Add move constructor.
2806         * tui/tui-regs.c (tui_data_window::show_registers)
2807         (tui_data_window::show_register_group)
2808         (tui_data_window::display_registers_from)
2809         (tui_data_window::display_registers_from)
2810         (tui_data_window::first_data_item_displayed)
2811         (tui_data_window::delete_data_content_windows)
2812         (tui_data_window::rerender, tui_data_window::refresh_window)
2813         (tui_data_window::check_register_values): Update.
2814
2815 2019-08-20  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2818         show_register_group>: Declare.
2819         (tui_show_register_group): Don't declare.
2820         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2821         tui_show_registers.
2822         (tui_data_window::show_register_group): Rename from
2823         tui_show_register_group.
2824         (tui_data_window::check_register_values, tui_reg_command):
2825         Update.
2826         * tui/tui-layout.c (tui_set_layout): Update.
2827
2828 2019-08-20  Tom Tromey  <tom@tromey.com>
2829
2830         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2831         Declare.
2832         (tui_check_register_values): Don't declare.
2833         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2834         from tui_check_register_values.
2835         * tui/tui-hooks.c (tui_register_changed): Update.
2836
2837 2019-08-20  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-regs.c (tui_reg_layout): Move later.
2840         (tui_show_registers): Don't enable TUI mode or change layout.
2841
2842 2019-08-20  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-regs.h (struct tui_data_item_window)
2845         <~tui_data_item_window>: Remove.
2846         <content>: Now a unique_xmalloc_ptr.
2847         * tui/tui-regs.c (tui_register_format): Return a
2848         unique_xmalloc_ptr.
2849         (tui_get_register): Update.
2850         (~tui_data_item_window): Remove.
2851         (tui_data_window::display_registers_from, tui_display_register):
2852         Update.
2853         * tui/tui-io.h (tui_expand_tabs): Update.
2854         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2855         Remove "col" parameter.
2856
2857 2019-08-20  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2860         field.
2861         * tui/tui-regs.c (~tui_data_item_window): Update.
2862
2863 2019-08-20  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2866         earlier.
2867
2868 2019-08-20  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2871
2872 2019-08-20  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-source.h (struct tui_source_window): Update.
2875         * tui/tui-regs.c (tui_show_registers): Update.
2876         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2877         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2878         (NO_REGS_STRING): Remove defines.
2879
2880 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2881
2882         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2883         unnecessary thread walk if remote doesn't support the packet.
2884
2885 2019-08-19  Tom Tromey  <tromey@adacore.com>
2886
2887         * python/py-value.c (value_has_field): Fix indentation.
2888
2889 2019-08-19  Tom Tromey  <tromey@adacore.com>
2890
2891         * printcmd.c (do_one_display, info_display_command): Update.
2892         * block.h (contained_in): Return bool.  Add allow_nested
2893         parameter.
2894         * block.c (contained_in): Return bool.  Add allow_nested
2895         parameter.
2896
2897 2019-08-19  Tom Tromey  <tom@tromey.com>
2898
2899         * configure: Rebuild.
2900         * configure.ac: Disallow the combination of -static-libstdc++ and
2901         source highlight.
2902         * source-cache.c (get_language_name): Handle rust.
2903         (source_cache::get_source_lines): Ignore highlighting exceptions.
2904
2905 2019-08-16  Tom Tromey  <tom@tromey.com>
2906
2907         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2908         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2909         (struct tui_source_window_base) <make_visible, refresh_window,
2910         resize>: Remove methods.
2911         <execution_info>: Remove field.
2912         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2913         (tui_show_source_line, tui_source_window_base)
2914         (~tui_source_window_base): Update.
2915         (tui_source_window_base::resize)
2916         (tui_source_window_base::make_visible)
2917         (tui_source_window_base::refresh_window): Remove.
2918         (tui_source_window_base::update_exec_info): Update.
2919         * tui/tui-source.c (tui_source_window::set_contents): Update.
2920         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2921
2922 2019-08-16  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2925         deprecated_query_hook.
2926
2927 2019-08-16  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2930         (tui_update_source_windows_with_line): Update.
2931         * tui/tui-source.h (struct tui_source_window)
2932         <show_symtab_source>: Declare.
2933         (tui_show_symtab_source): Don't declare.
2934         * tui/tui-source.c (tui_show_symtab_source): Rename from
2935         tui_show_symtab_source.
2936
2937 2019-08-16  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-winsource.h (struct tui_source_window_base)
2940         <set_contents>: Declare.
2941         * tui/tui-winsource.c
2942         (tui_source_window_base::update_source_window_as_is): Update.
2943         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2944         Declare.
2945         (tui_set_source_content): Don't declare.
2946         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2947         tui_set_source_content.
2948         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2949         Declare.
2950         (tui_set_disassem_content): Don't declare.
2951         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2952         tui_set_disassem_content.
2953
2954 2019-08-16  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-winsource.h (struct tui_source_window_base)
2957         <update_breakpoint_info>: Declare.
2958         (tui_update_breakpoint_info): Don't declare.
2959         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2960         (tui_update_all_breakpoint_info): Update.
2961         (tui_source_window_base::update_breakpoint_info): Rename from
2962         tui_update_breakpoint_info.
2963         (tui_source_window_base::update_exec_info): Update.
2964
2965 2019-08-16  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-winsource.h (struct tui_source_window_base)
2968         <update_source_window>: Declare.
2969         (tui_update_source_window): Don't declare.
2970         * tui/tui-winsource.c
2971         (tui_source_window_base::update_source_window): Rename from
2972         tui_update_source_window.
2973         (tui_source_window_base::rerender): Update.
2974         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2975         * tui/tui-disasm.c (tui_show_disassem)
2976         (tui_show_disassem_and_update_source)
2977         (tui_disasm_window::maybe_update): Update.
2978
2979 2019-08-16  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-winsource.h (struct tui_source_window_base)
2982         <update_source_window_as_is>: Declare.
2983         (tui_update_source_window_as_is): Don't declare.
2984         * tui/tui-winsource.c (tui_update_source_window): Update
2985         (tui_source_window_base::update_source_window_as_is): Rename from
2986         tui_update_source_window_as_is.
2987         (tui_source_window_base::refill): Update.
2988         * tui/tui-source.c (tui_show_symtab_source): Update.
2989         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2990         Update.
2991
2992 2019-08-16  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-winsource.h (tui_update_source_window)
2995         (tui_update_source_window_as_is): Remove "noerror" parameter.
2996         * tui/tui-winsource.c (tui_update_source_window)
2997         (tui_update_source_window_as_is): Remove "noerror" parameter.
2998         (tui_update_source_windows_with_addr)
2999         (tui_update_source_windows_with_line)
3000         (tui_source_window_base::rerender)
3001         (tui_source_window_base::refill): Update.
3002         * tui/tui-source.h (tui_set_source_content)
3003         (tui_show_symtab_source): Remove "noerror" parameter.
3004         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3005         parameter.
3006         (tui_show_symtab_source): Likewise.
3007         (tui_source_window::maybe_update): Update.
3008         * tui/tui-disasm.c (tui_show_disassem)
3009         (tui_show_disassem_and_update_source)
3010         (tui_disasm_window::do_scroll_vertical)
3011         (tui_disasm_window::maybe_update): Update.
3012
3013 2019-08-16  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui.c (tui_is_window_visible): Update.
3016         * tui/tui-wingeneral.c (tui_make_window)
3017         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3018         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3019         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3020         (tui_set_win_height_command, parse_scrolling_args): Update.
3021         * tui/tui-source.c (tui_source_window::style_changed): Update.
3022         * tui/tui-regs.c (tui_show_registers)
3023         (tui_data_window::first_data_item_displayed)
3024         (tui_data_window::delete_data_content_windows)
3025         (tui_check_register_values, tui_reg_command): Update.
3026         * tui/tui-disasm.c (tui_show_disassem): Update.
3027         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3028         method.
3029         <is_visible>: Remove field.
3030         * tui/tui-data.c (tui_next_win, tui_prev_win)
3031         (tui_delete_invisible_windows): Update.
3032
3033 2019-08-16  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui-winsource.h (struct tui_source_window_base)
3036         <m_has_locator>: Remove.
3037         * tui/tui-layout.c (show_source_disasm_command, show_data)
3038         (show_source_or_disasm_and_command): Update.
3039
3040 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3041
3042         * NEWS (Other MI changes): New subsection.
3043         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3044         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3045         * arch-utils.c (default_get_pc_address_flags): New function.
3046         * arch-utils.h (default_get_pc_address_flags): New declaration.
3047         * gdbarch.sh: Add get_pc_address_flags.
3048         * gdbarch.c: Regenerate.
3049         * gdbarch.h: Likewise.
3050         * stack.c (print_pc): New function.
3051         (print_frame_info) (print_frame): Call print_pc.
3052
3053 2019-08-16  Tom de Vries  <tdevries@suse.de>
3054
3055         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3056         print_objfile_section_info.
3057
3058 2019-08-15  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3061         calling update_cmdwin_start_line.
3062         * tui/tui-winsource.h (struct tui_source_window_base)
3063         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3064         <rerender>: Declare.
3065         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3066         Call rerender.
3067         (tui_source_window_base::set_new_height): Remove.
3068         (tui_source_window_base::rerender): Rename from
3069         do_make_visible_with_new_height.
3070         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3071         resize method.
3072         (tui_win_info::make_invisible_and_set_new_height)
3073         (tui_win_info::make_visible_with_new_height): Remove.
3074         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3075         Declare.
3076         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3077         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3078         do_make_visible_with_new_height>: Don't declare.
3079         <rerender>: Declare.
3080         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3081         set_new_height.
3082         (tui_data_window::do_make_visible_with_new_height): Remove.
3083         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3084         call tui_show_locator_content.
3085         (tui_gen_win_info::resize): Call rerender.
3086         (show_source_or_disasm_and_command): Don't call
3087         tui_show_locator_content.
3088         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3089         method.
3090         (struct tui_win_info) <rerender>: Declare.
3091         <set_new_height, make_invisible_and_set_new_height,
3092         make_visible_with_new_height>: Don't declare.
3093         * tui/tui-data.c (tui_win_list::rerender): New method.
3094         * tui/tui-command.h (struct tui_cmd_window)
3095         <do_make_visible_with_new_height>: Don't declare.
3096         * tui/tui-command.c
3097         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3098
3099 2019-08-15  Tom Tromey  <tromey@adacore.com>
3100
3101         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3102         * ada-lang.c (ada_enum_name): Likewise.
3103
3104 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3105
3106         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3107         leading underscore.
3108         (GdbOutputErrorFile): Likewise.
3109         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3110         accordingly.
3111         (execute_unwinders): Rename to have a leading underscore.
3112         (auto_load_packages): Likewise.
3113         (global scope): Adjust call to auto_load_packages accordingly.
3114         (GdbSetPythonDirectory): Likewise.
3115         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3116         instead of execute_unwinders.
3117
3118 2019-08-15  Tom Tromey  <tom@tromey.com>
3119
3120         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3121         (show_data): Don't change window visibility.
3122         (tui_gen_win_info::resize): Remove special case for command
3123         window.  Use wresize, when available.
3124         (show_source_or_disasm_and_command): Don't change window
3125         visibility.
3126         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3127         <make_visible>: New method.
3128         * tui/tui-command.c (tui_cmd_window::resize): New method.
3129
3130 2019-08-15  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3133         (struct tui_source_windows): New.
3134         * tui/tui-winsource.c (tui_display_main): Update.
3135         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3136         (new_height_ok, parse_scrolling_args): Update.
3137         * tui/tui-layout.c (show_layout, show_data): Update.
3138         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3139         (tui_add_to_source_windows): Don't declare.
3140         * tui/tui-data.c (source_windows, tui_source_windows)
3141         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3142
3143 2019-08-15  Tom Tromey  <tom@tromey.com>
3144
3145         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3146         Rename from reset.
3147         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3148         * tui/tui-layout.c (show_source_disasm_command, show_data):
3149         Update.
3150         (tui_gen_win_info::resize): Rename.
3151         (show_source_or_disasm_and_command): Update.
3152         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3153         reset.
3154
3155 2019-08-15  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3158         * tui/tui-interp.c (tui_interp::init): Don't call
3159         tui_initialize_static_data.
3160         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3161
3162 2019-08-15  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3165         examine tui_win_list.
3166
3167 2019-08-15  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3170         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3171         tui_clear_source_content.
3172         (tui_clear_source_content): Remove.
3173         (tui_source_window_base::do_erase_source_content): Hoist call to
3174         content.clear().
3175         * tui/tui-stack.c (tui_show_frame_info): Don't call
3176         tui_clear_source_content.
3177
3178 2019-08-15  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-winsource.h (struct tui_source_window_base)
3181         <do_erase_source_content>: New method.
3182         <erase_source_content>: New method.
3183         (tui_erase_source_content): Don't declare.
3184         * tui/tui-winsource.c (tui_clear_source_content): Update.
3185         (tui_source_window_base::do_erase_source_content): Rename from
3186         tui_erase_source_content.
3187         (tui_source_window_base::show_source_content): Update.
3188         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3189         * tui/tui-source.h (struct tui_source_window)
3190         <erase_source_content>: New method.
3191         * tui/tui-disasm.h (struct tui_disasm_window)
3192         <erase_source_content>: New method.
3193
3194 2019-08-15  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3197         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3198         constructor.
3199         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3200         * tui/tui-source.c (tui_set_source_content): Update.
3201         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3202
3203 2019-08-15  Tom Tromey  <tom@tromey.com>
3204
3205         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3206         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3207         tui-source.c.
3208         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3209         Declare.
3210         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3211         method.
3212         (tui_source_window::maybe_update): Update.
3213
3214 2019-08-15  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3217         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3218         tui-disasm.c.
3219         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3220         Declare.
3221         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3222         method.
3223         (tui_disasm_window::maybe_update): Update.
3224
3225 2019-08-15  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-winsource.h (struct tui_source_window_base)
3228         <maybe_update>: Declare.
3229         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3230         method.
3231         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3232         Declare.
3233         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3234         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3235         Declare.
3236         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3237
3238 2019-08-15  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3241
3242 2019-08-15  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-wingeneral.c: Include tui-stack.h.
3245         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3246         (struct tui_locator_window): Move from tui-data.h.
3247         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3248         (tui_initialize_static_data): Move from tui-data.c.
3249         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3250         (struct tui_locator_window): Move to tui-stack.c.
3251         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3252         (tui_initialize_static_data): Move to tui-stack.c.
3253
3254 2019-08-15  Tom Tromey  <tom@tromey.com>
3255
3256         * tui/tui-layout.c (show_source_disasm_command)
3257         (show_source_or_disasm_and_command): Use make_visible method, not
3258         tui_make_window.
3259         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3260         Remove.
3261
3262 2019-08-15  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-wingeneral.h (tui_make_window): Update.
3265         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3266         parameter.
3267         (tui_gen_win_info::make_visible): Update.
3268         * tui/tui-regs.c (tui_data_window::display_registers_from):
3269         Update.
3270         * tui/tui-layout.c (show_source_disasm_command)
3271         (show_source_or_disasm_and_command): Update.
3272         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3273         (enum tui_box): Remove.
3274         (struct tui_win_info) <can_box>: New method.
3275         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3276         method.
3277
3278 2019-08-15  Tom de Vries  <tdevries@suse.de>
3279
3280         * linux-nat-trad.c: Include gdbarch.h.
3281
3282 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3283
3284         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3285         register sizes.
3286
3287 2019-08-14  Tom Tromey  <tromey@adacore.com>
3288
3289         * darwin-nat.c: Include gdbarch.h.
3290         * darwin-nat-info.c: Include gdbarch.h.
3291
3292 2019-08-13  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3295         Remove.
3296         * tui/tui-data.c (tui_initialize_static_data): Update.
3297
3298 2019-08-13  Tom Tromey  <tom@tromey.com>
3299
3300         * tui/tui-winsource.h (struct tui_exec_info_window)
3301         <~tui_exec_info_window, maybe_allocate_content, get_content,
3302         m_content>: Remove.
3303         (struct tui_source_window_base) <set_exec_info_content,
3304         show_exec_info_content>: Don't declare.
3305         * tui/tui-winsource.c
3306         (tui_exec_info_window::maybe_allocate_content): Remove.
3307         (tui_source_window_base::update_exec_info): Rename from
3308         set_exec_info_content.
3309         (tui_source_window_base::show_exec_info_content)
3310         (tui_source_window_base::update_exec_info): Remove.
3311
3312 2019-08-13  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3315         declare.
3316         * tui/tui-winsource.c (tui_update_source_window_as_is)
3317         (tui_update_source_windows_with_addr, tui_erase_source_content):
3318         Update.
3319         (tui_clear_exec_info_content): Remove.
3320
3321 2019-08-13  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3324         declare.
3325         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3326         call tui_erase_exec_info_content.
3327         (tui_clear_exec_info_content): Rename from
3328         tui_erase_exec_info_content.
3329         (tui_clear_exec_info_content): Delete.
3330
3331 2019-08-13  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-winsource.h (struct tui_source_window_base)
3334         <show_exec_info_content>: Declare.
3335         (tui_show_exec_info_content): Don't declare.
3336         * tui/tui-winsource.c
3337         (tui_source_window_base::show_exec_info_content): Rename from
3338         tui_show_exec_info_content.
3339         (tui_source_window_base::update_exec_info): Update.
3340
3341 2019-08-13  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3344         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3345         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3346         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3347         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3348         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3349         ... here.
3350
3351 2019-08-13  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-winsource.h (struct tui_source_window_base)
3354         <update_exec_info>: Declare.
3355         (tui_update_exec_info): Don't declare.
3356         * tui/tui-winsource.c (tui_update_source_window_as_is)
3357         (tui_source_window_base::refresh_all)
3358         (tui_update_all_breakpoint_info): Update.
3359         (tui_source_window_base::update_exec_info): Rename from
3360         tui_update_exec_info.
3361         * tui/tui-stack.c (tui_show_frame_info): Update.
3362
3363 2019-08-13  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-winsource.h (struct tui_source_window_base)
3366         <set_exec_info_content>: Declare.
3367         (tui_set_exec_info_content): Don't declare.
3368         * tui/tui-winsource.c
3369         (tui_source_window_base::set_exec_info_content): Rename from
3370         tui_set_exec_info_content.
3371         (tui_update_exec_info): Update.
3372
3373 2019-08-13  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-winsource.h (struct tui_source_window_base)
3376         <show_source_content>: Declare.
3377         (tui_show_source_content): Don't declare.
3378         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3379         (tui_source_window_base::show_source_content): Rename from
3380         tui_show_source_content.
3381         (tui_source_window_base::refresh_all): Update.
3382         * tui/tui-layout.c (show_source_disasm_command)
3383         (show_source_or_disasm_and_command): Update.
3384
3385 2019-08-13  Tom Tromey  <tom@tromey.com>
3386
3387         * tui/tui-winsource.c (tui_erase_source_content)
3388         (tui_show_source_content, tui_source_window_base::refresh_all):
3389         Update.
3390         * tui/tui-wingeneral.h
3391         (tui_check_and_display_highlight_if_needed): Don't declare.
3392         * tui/tui-wingeneral.c
3393         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3394         check_and_display_highlight_if_needed.
3395         * tui/tui-win.c (tui_rehighlight_all)
3396         (tui_win_info::make_visible_with_new_height): Update.
3397         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3398         (tui_data_window::erase_data_content)
3399         (tui_data_window::display_all_data): Update.
3400         * tui/tui-data.h (struct tui_win_info)
3401         <check_and_display_highlight_if_needed>: Declare.
3402
3403 2019-08-13  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-win.c (tui_resize_all): Call
3406         tui_delete_invisible_windows.
3407         * tui/tui-layout.c (show_layout): Call
3408         tui_delete_invisible_windows.
3409         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3410         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3411
3412 2019-08-13  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3415         tui_add_win_to_layout.
3416
3417 2019-08-13  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3420         * tui/tui-layout.c (tui_default_win_height): Now static.
3421
3422 2019-08-13  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3425         single switch.
3426         (show_source_disasm_command, show_source_or_disasm_and_command):
3427         Don't check current layout.
3428
3429 2019-08-13  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-wingeneral.c (make_all_visible): Remove.
3432         (tui_make_all_invisible): Simplify.
3433         * tui/tui-layout.c (tui_make_all_invisible): Move from
3434         tui-wingeneral.c; simplify.
3435         (show_layout): Hoist call to tui_make_all_invisible.
3436         (show_data): Don't call tui_make_all_invisible.
3437
3438 2019-08-13  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3441         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3442
3443 2019-08-13  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3446         tui-data.c.
3447         (show_source_disasm_command, show_data)
3448         (show_source_or_disasm_and_command): Don't use
3449         tui_set_current_layout_to.
3450         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3451         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3452         tui-layout.c.
3453         (tui_set_current_layout_to): Remove.
3454
3455 2019-08-13  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui-layout.c (tui_set_layout): Update.
3458         * tui/tui-data.h (struct tui_layout_def): Remove.
3459         (tui_layout_def): Don't declare.
3460         * tui/tui-data.c (layout_def): Remove.
3461         (tui_layout_def): Remove.
3462
3463 2019-08-13  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-winsource.h (struct tui_source_window_base)
3466         <clear_detail>: No longer "override".
3467         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3468         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3469         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3470         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3471         Remove.
3472         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3473
3474 2019-08-13  Tom Tromey  <tromey@adacore.com>
3475
3476         * tracepoint.c: Don't include readline.h or history.h.
3477
3478 2019-08-12  Tom Tromey  <tom@tromey.com>
3479
3480         * configure: Rebuild.
3481         * configure.ac: Check for readline 7.
3482         * NEWS: Mention readline 7 requirement.
3483         * README: Update.
3484
3485 2019-08-12  Tom Tromey  <tom@tromey.com>
3486
3487         * mingw-hdep.c (gdb_select): Remove readline hack.
3488
3489 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3490
3491         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3492         when the function fails.
3493
3494 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3495
3496         * s390-tdep.c (s390_type_align): New function.
3497         (s390_gdbarch_init): Set it as type_align gdbarch method.
3498
3499 2019-08-09  Tom de Vries  <tdevries@suse.de>
3500
3501         PR gdb/24591
3502         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3503         pc_low with relocation offset.
3504
3505 2019-08-07  Tom Tromey  <tromey@adacore.com>
3506
3507         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3508         (print_frame_args): Update.
3509         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3510         Update.
3511         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3512         * frame.h (struct frame_arg): Add initializers.
3513         <error>: Now a unique_xmalloc_ptr.
3514
3515 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3516
3517         * NEWS: Expand the Pointer Authentication entry.
3518         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3519         (aarch64_frame_unmask_lr): ... to this.
3520         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3521         Call aarch64_frame_unmask_lr.
3522         * frame.c (struct frame_info): Add "masked" variable.
3523         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3524         (fprint_frame): Check for masked pc.
3525         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3526         declarations.
3527         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3528         * stack.c (print_frame): Check for masked pc.
3529
3530 2019-08-06  Tom Tromey  <tom@tromey.com>
3531
3532         * stabsread.c (patch_block_stabs, read_one_struct_field)
3533         (read_enum_type): Use obstack_strndup.
3534         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3535         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3536         * dwarf2read.c (guess_full_die_structure_name)
3537         (anonymous_struct_prefix): Use obstack_strndup.
3538         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3539         * c-exp.y (yylex): Use obstack_strndup.
3540         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3541         (write_var_or_type): Use obstack_strndup.
3542
3543 2019-08-06  Tom Tromey  <tom@tromey.com>
3544
3545         * symfile.c (reread_symbols): Use obstack_strdup.
3546         * stabsread.c (read_type): Use obstack_strdup.
3547         * gdb_obstack.h (obstack_strdup): New overload.
3548         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3549         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3550         (dwarf2_canonicalize_name): Use obstack_strdup.
3551         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3552         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3553         Use obstack_strdup.
3554
3555 2019-08-06  Tom Tromey  <tom@tromey.com>
3556
3557         * gdb_obstack.h (obstack_strdup): Define.
3558         * gdb_obstack.c (obstack_strdup): Don't define.
3559
3560 2019-08-06  Tom Tromey  <tom@tromey.com>
3561
3562         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3563         obstack_strdup.
3564         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3565         obstack_strdup.
3566         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3567         * stabsread.c (common_block_start): Use obstack_strdup.
3568         * objfiles.c (set_objfile_main_name, objfile): Use
3569         obstack_strdup.
3570         * namespace.c (add_using_directive): Use obstack_strdup.
3571         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3572         * jit.c (finalize_symtab): Use obstack_strdup.
3573         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3574         (guess_partial_die_structure_name, partial_die_info::fixup)
3575         (dwarf2_name): Use obstack_strdup.
3576         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3577         obstack_strdup.
3578         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3579         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3580         obstack_strdup.
3581         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3582
3583 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3584
3585         * unittests/help-doc-selftests.c: New file.
3586         * Makefile.in: Add the new file.
3587
3588 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3589
3590         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3591         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3592         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3593         the trailing '.' is not output, and the first character is uppercased.
3594         (print_help_for_command): Update call to print_doc_line.
3595         (print_doc_of_command): Likewise.
3596         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3597         * cli/cli-option.c (append_indented_doc): Do not append newline.
3598         (build_help_option): Append newline after first appended_indented_doc
3599         only if a second call is done.
3600         (build_help): Append 2 new lines before each option, except the first
3601         one.
3602         * compile/compile.c (_initialize_compile): Add new lines after
3603         %OPTIONS%, when not at the end of the help.
3604         Change help doc or code
3605         producing the help doc to respect the invariants.
3606         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3607         Also removed the new line after 'Options:', as all other commands
3608         do not put an empty line between 'Options:' and the first option.
3609         * printcmd.c (_initialize_printcmd): Likewise.
3610         * stack.c (_initialize_stack): Likewise.
3611         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3612         incorrectly telling COMMAND is optional.
3613         * ada-lang.c (_initialize_ada_language): Change help doc or code
3614         producing the help doc to respect the invariants.
3615         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3616         * breakpoint.c (_initialize_breakpoint): Likewise.
3617         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3618         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3619         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3620         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3621         _initialize_cli_style): Likewise.
3622         * corelow.c (core_target_info): Likewise.
3623         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3624         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3625         * filesystem.c (_initialize_filesystem): Likewise.
3626         * frame.c (_initialize_frame): Likewise.
3627         * gnu-nat.c (add_task_commands): Likewise.
3628         * infcall.c (_initialize_infcall): Likewise.
3629         * infcmd.c (_initialize_infcmd): Likewise.
3630         * interps.c (_initialize_interpreter): Likewise.
3631         * language.c (_initialize_language): Likewise.
3632         * linux-fork.c (_initialize_linux_fork): Likewise.
3633         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3634         * maint.c (_initialize_maint_cmds): Likewise.
3635         * memattr.c (_initialize_mem): Likewise.
3636         * printcmd.c (_initialize_printcmd): Likewise.
3637         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3638         _RegEx): Likewise.
3639         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3640         * record-btrace.c (_initialize_record_btrace): Likewise.
3641         * record-full.c (_initialize_record_full): Likewise.
3642         * record.c (_initialize_record): Likewise.
3643         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3644         * regcache.c (_initialize_regcache): Likewise.
3645         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3646         _initialize_remote): Likewise.
3647         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3648         * serial.c (_initialize_serial): Likewise.
3649         * skip.c (_initialize_step_skip): Likewise.
3650         * source.c (_initialize_source): Likewise.
3651         * stack.c (_initialize_stack): Likewise.
3652         * symfile.c (_initialize_symfile): Likewise.
3653         * symtab.c (_initialize_symtab): Likewise.
3654         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3655         * top.c (init_main): Likewise.
3656         * tracefile-tfile.c (tfile_target_info): Likewise.
3657         * tracepoint.c (_initialize_tracepoint): Likewise.
3658         * tui/tui-win.c (_initialize_tui_win): Likewise.
3659         * utils.c (add_internal_problem_command): Likewise.
3660         * valprint.c (value_print_option_defs): Likewise.
3661
3662 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3663
3664         PR build/24886
3665         * configure.ac: Drop enable-libmcheck support.
3666         * configure, config.in: Rebuild.
3667         * libmcheck.m4: Remove.
3668         * acinclude.m4: Don't include it.
3669         * Makefile.in: Don't distribute it.
3670         * top.c (print_gdb_configuration): Don't mention it.
3671
3672 2019-08-06  Tom Tromey  <tom@tromey.com>
3673
3674         * utils.c (set_output_style): Sometimes pass stream to
3675         emit_style_escape.
3676         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3677         * record-btrace.c (btrace_insn_history): Update.
3678         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3679         method.
3680         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3681         Update initializers.
3682         <m_uiout>: New field.
3683         <m_di>: Move lower.
3684         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3685         Remove "uiout" parameter.
3686         (dump_insns): Update.
3687         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3688         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3689
3690 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3691
3692         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3693         (error_in_psymtab_expansion): Likewise.
3694         (lookup_symbol_via_quick_fns): Likewise.
3695         (basic_lookup_transparent_type_quick): Likewise.
3696         (basic_lookup_transparent_type_1): Likewise.
3697
3698 2019-08-06  Tom Tromey  <tromey@adacore.com>
3699
3700         * source.c (last_source_error): Now bool.
3701         (print_source_lines_base): Make "noprint" bool.  Only open
3702         source file when last_source_visited changes.
3703
3704 2019-08-06  Tom Tromey  <tromey@adacore.com>
3705
3706         * annotate.c (annotate_source_line): Use g_source_cache.
3707         * source-cache.c (source_cache::get_plain_source_lines): Change
3708         parameters.  Populate m_offset_cache.
3709         (source_cache::ensure): New method.
3710         (source_cache::get_line_charpos): New method.
3711         (extract_lines): Move lower.  Change parameters.
3712         (source_cache::get_source_lines): Move lower.
3713         * source-cache.h (class source_cache): Update comment.
3714         <get_line_charpos>: New method.
3715         <get_source_lines>: Update comment.
3716         <clear>: Clear m_offset_cache.
3717         <get_plain_source_lines>: Change parameters.
3718         <ensure>: New method
3719         <m_offset_cache>: New member.
3720         * source.c (forget_cached_source_info_for_objfile): Update.
3721         (info_source_command): Use g_source_cache.
3722         (find_source_lines, open_source_file_with_line_charpos): Remove.
3723         (print_source_lines_base, search_command_helper): Use g_source_cache.
3724         * source.h (open_source_file_with_line_charpos): Don't declare.
3725         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3726         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3727         Use g_source_cache.
3728
3729 2019-08-06  Tom Tromey  <tromey@adacore.com>
3730
3731         * source-cache.c (source_cache::get_plain_source_lines):
3732         Remove "first_line" and "last_line" parameters.
3733         (source_cache::get_source_lines): Cache plain text.
3734         * source-cache.h (class source_cache)
3735         <get_plain_source_lines>: Update.
3736
3737 2019-08-06  Tom Tromey  <tromey@adacore.com>
3738
3739         * source-cache.c (extract_lines): No longer a method.
3740         Changed type of parameter.  Include final newline.
3741         (selftests::extract_lines_test): New function.
3742         (_initialize_source_cache): Likewise.
3743         * source-cache.h (class source_cache)
3744         <extract_lines>: Don't declare.
3745
3746 2019-08-06  Tom Tromey  <tromey@adacore.com>
3747
3748         * breakpoint.c (init_breakpoint_sal): Update.
3749         (breakpoint): Update.
3750         * breakpoint.h (struct breakpoint) <filter>: Now a
3751         unique_xmalloc_ptr.
3752
3753 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3754
3755         * NEWS: Mention dictionary access on blocks.
3756         * python/py-block.c (blpy_getitem): New function.
3757         (block_object_as_mapping): New struct.
3758         (block_object_type): Use new struct for tp_as_mapping field.
3759
3760 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3761
3762         * objfiles.h (objfile): Add a comment describing partial symbols.
3763
3764 2019-08-05  Tom Tromey  <tromey@adacore.com>
3765
3766         * compile/compile.c (_initialize_compile): Use _(), not N_().
3767         * thread.c (_initialize_thread): Use _(), not N_().
3768         * stack.c (_initialize_stack): Use _(), not N_().
3769         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3770
3771 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3772
3773         * dwarf2read.c (struct dw2_symtab_iterator):
3774         <want_specific_block>: Remove.
3775         <block_index>: Change type to gdb::optional.
3776         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3777         change type of BLOCK_INDEX parameter to gdb::optional.
3778         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3779         (dw2_lookup_symbol): Don't pass argument for
3780         WANT_SPECIFIC_BLOCK.
3781         (dw2_expand_symtabs_for_function): Don't pass argument for
3782         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3783         (class dw2_debug_names_iterator)
3784         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3785         parameter, change BLOCK_INDEX type to gdb::optional.
3786         <m_want_specific_block>: Remove.
3787         <m_block_index>: Change type to gdb::optional.
3788         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3789         gdb::optional.  Re-write in function of gdb::optional.
3790         (dw2_debug_names_lookup_symbol): Don't pass argument for
3791         WANT_SPECIFIC_BLOCK.
3792         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3793         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3794         BLOCK_INDEX.
3795
3796 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3797
3798         * NEWS: Mention changes to "info sources" command.
3799
3800 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3801
3802         * symtab.c (filename_partial_match_opts): New struct type.
3803         (struct output_source_filename_data): New members
3804         regexp, c_regexp, partial_match.
3805         (output_source_filename): Use new members to decide to print file.
3806         (info_sources_option_defs): New variable.
3807         (make_info_sources_options_def_group, print_info_sources_header,
3808         info_sources_command_completer):
3809         New functions.
3810         (info_sources_command): Read new optional arguments.
3811         (_initialize_symtab): Update info sources help.
3812
3813 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3814
3815         * ada-lang.c (exception_support_info_v0): Renamed from...
3816         (default_exception_support_info): ... this.  Create new
3817         definition for v1.
3818         (ada_has_this_exception_support): Look up catch_handlers_sym.
3819         (ada_exception_support_info_sniffer): Try v0 after default.
3820
3821 2019-08-01  Tom Tromey  <tromey@adacore.com>
3822
3823         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3824         gdbarch.h.
3825
3826 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3827
3828         * s12z-tdep.c: Fix include path for s12z-opc.h.
3829
3830 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3831
3832         * NEWS: Require GNU make 3.82.
3833
3834 2019-07-16  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3837         declare.
3838
3839 2019-07-30  Tom Tromey  <tromey@adacore.com>
3840
3841         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3842
3843 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3844
3845         * printcmd.c (print_address_symbolic): Print negative offsets.
3846         (build_address_symbolic): Force signed arithmetic when computing
3847         offset.
3848
3849 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3850
3851         PR/24474: Add a function to lookup static variables.
3852         * NEWS: Mention this new function.
3853         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3854         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3855         * python/python.c (python_GdbMethods): Add new function.
3856
3857 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3858
3859         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3860         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3861         (objfpy_lookup_static_symbol): New function.
3862         (objfile_object_methods): Add new functions.
3863
3864 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3865
3866         * NEWS: Mention 'set|show print frame-info'.  Mention new
3867         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3868         backtrace argument.  Mention that python frame filtering code
3869         is now consistent with what 'backtrace' command prints.
3870
3871 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3872
3873         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3874         comments.
3875         (print_frame_info_auto, print_frame_info_source_line,
3876         print_frame_info_location, print_frame_info_source_and_location,
3877         print_frame_info_location_and_address, print_frame_info_short_location):
3878         New declarations.
3879         (struct frame_print_options): New member print_frame_info.
3880         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3881         * stack.h (get_user_print_what_frame_info): New declaration.
3882         (frame_show_address): New declaration.
3883         * stack.c (print_frame_arguments_choices): New value 'presence'.
3884         (print_frame_info_auto, print_frame_info_source_line,
3885         print_frame_info_location, print_frame_info_source_and_location,
3886         print_frame_info_location_and_address, print_frame_info_short_location,
3887         print_frame_info_choices, print_frame_info_print_what): New definitions.
3888         (print_frame_args): Only print dots for args if print frame-arguments
3889         is 'presence'.
3890         (frame_print_option_defs): New element for "frame-info".
3891         (get_user_print_what_frame_info): New function.
3892         (frame_show_address): Make non static.  Move comment to stack.h.
3893         (print_frame_info_to_print_what): New function.
3894         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3895         to decide what to print.
3896         (backtrace_command_1): Handle the new print_frame_arguments_presence
3897         value.
3898         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3899         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3900         (py_print_frame): In non-mi mode, use LOCATION as default for
3901         print_what, similarly to frame information printed directly by
3902         backtrace command. Handle frame-info user option in non MI mode.
3903
3904 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3905
3906         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3907         Add case for debugging 32-bit target on 64-bit host.  Revise
3908         comment.
3909
3910 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3911
3912         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3913         instead of find_function_entry_range_from_pc.
3914
3915 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3916
3917         * stack.c (find_frame_funname): Remove code which preferred
3918         minsym over symtab sym in "certain pathological cases".
3919
3920         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3921         parameter.  Change type of "do_demangle" to bool.
3922         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3923         Pass suitable "prefer_sym_over_minsym" flag to
3924         build_address_symbolic().  Don't output "+" for negative offsets.
3925         * printcmd.c (print_address_symbolic): Update invocation of
3926         build_address_symbolic to include a "prefer_sym_over_minsym"
3927         flag.
3928         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3929         Restrict cases in which use of minimal symbol is preferred to that
3930         of a found symbol.  Update comments.
3931
3932         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3933         for entry pc when entry pc is out of range for that FDE.
3934
3935 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3936
3937         PR gdb/24839:
3938         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3939         type.
3940
3941 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3942
3943         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3944         this function's Python signature.
3945
3946
3947 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3948
3949         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3950         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3951         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3952         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3953         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3954
3955
3956 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3957
3958         * h8300-tdep.c (h8300_register_name_common): New.
3959         h8300_register_name): Use h8300_register_name_common.
3960         (h8300s_register_name): Likewise.
3961         (h8300sx_register_name): Likewise.
3962         (h8300h_register_nam): New.
3963         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3964
3965
3966 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3967
3968         * arm-tdep.c (arm_skip_cmse_entry): New function.
3969         (arm_is_sgstubs_section): New function.
3970         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3971
3972 2019-07-22  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3975         Don't self-assign.
3976
3977 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3978
3979         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3980         type_print.
3981
3982 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3983
3984         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3985         so that GDB doesn't match any msymbols when searching in the
3986         TYPES_DOMAIN.
3987         (print_symbol_info): Print using typedef_print or type_print based
3988         on the type of the symbol.  Add updated FIXME comment moved from...
3989         (_initialize_symtab): ... move and update FIXME comment to above.
3990
3991 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * NEWS: Mention adding -q option to "info types".
3994         * symtab.c (struct info_types_options): New struct.
3995         (info_types_options_defs): New variable.
3996         (make_info_types_options_def_group): New function.
3997         (info_types_command): Use gdb::option framework to parse options.
3998         (info_types_command_completer): New function.
3999         (_initialize_symtab): Extend the help text on "info types" and
4000         register command completer.
4001
4002 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4003
4004         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4005         (lookup_symbol_in_objfile): Change int to block_enum and add a
4006         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4007
4008 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4009
4010         * MAINTAINERS (Write After Approval): Add self.
4011
4012 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4015         instruction to the dummy code region.
4016
4017 2019-07-19  Tom Tromey  <tromey@adacore.com>
4018
4019         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4020         (ARGSUSED, PARAMS, __func__): Remove rules.
4021
4022 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4023
4024         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4025         * features/arm/arm-with-iwmmxt.c: Remove.
4026         * features/arm/arm-with-iwmmxt.xml: Remove.
4027         * features/arm/arm-with-m-fpa-layout.c: Remove.
4028         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4029         * features/arm/arm-with-m-vfp-d16.c: Remove.
4030         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4031         * features/arm/arm-with-m.c: Remove.
4032         * features/arm/arm-with-m.xml: Remove.
4033         * features/arm/arm-with-neon.c: Remove.
4034         * features/arm/arm-with-neon.xml: Remove.
4035         * features/arm/arm-with-vfpv2.c: Remove.
4036         * features/arm/arm-with-vfpv2.xml: Remove.
4037         * features/arm/arm-with-vfpv3.c: Remove.
4038         * features/arm/arm-with-vfpv3.xml: Remove.
4039
4040 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4041
4042         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4043
4044 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4045
4046         * arch/aarch32.c (aarch32_create_target_description): Create
4047         target descriptions using features.
4048         * arch/arm.c (arm_create_target_description)
4049         (arm_create_mprofile_target_description): Likewise.
4050         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4051
4052 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4053
4054         * Makefile.in: Add new files.
4055         * aarch32-tdep.c: New file.
4056         * aarch32-tdep.h: New file.
4057         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4058         Call aarch32_read_description.
4059         * arch/aarch32.c: New file.
4060         * arch/aarch32.h: New file.
4061         * arch/arm.c (arm_create_target_description)
4062         (arm_create_mprofile_target_description): New function.
4063         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4064         (arm_create_target_description)
4065         (arm_create_mprofile_target_description): New declaration.
4066         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4067         read_description functions.
4068         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4069         Likewise.
4070         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4071         * arm-tdep.c (tdesc_arm_list): New variable.
4072         (arm_register_g_packet_guesses): Call create description functions.
4073         (arm_read_description) (arm_read_mprofile_description): New
4074         function.
4075         * arm-tdep.h (arm_read_description)
4076         (arm_read_mprofile_description): Add declaration.
4077         * configure.tgt: Add new files.
4078
4079 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4080
4081         * top.c (new_ui_command): Open specified terminal just once.
4082
4083 2019-07-18  Tom Tromey  <tromey@adacore.com>
4084
4085         * symtab.c (main_name): Constify return type.
4086         * symfile.c (set_initial_language): Update.
4087         * symtab.h (main_name): Constify return type.
4088
4089 2019-07-17  Tom Tromey  <tom@tromey.com>
4090
4091         * tui/tui-winsource.c (tui_update_source_window)
4092         (tui_update_source_window_as_is)
4093         (tui_update_source_windows_with_line): Remove return.
4094         * tui/tui-disasm.c (tui_show_disassem)
4095         (tui_show_disassem_and_update_source): Remove return.
4096         * tui/tui.c (tui_reset): Remove return.
4097         * tui/tui-wingeneral.c
4098         (tui_check_and_display_highlight_if_needed): Remove return.
4099
4100 2019-07-17  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4103
4104 2019-07-17  Tom Tromey  <tom@tromey.com>
4105
4106         * tui/tui-winsource.h (struct tui_exec_info_window)
4107         (struct tui_source_window_base): Move from tui-data.h.
4108         * tui/tui-winsource.c: Move many method definitions from
4109         elsewhere.  Remove "structuring" comments.
4110         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4111         (tui_source_window_base::refresh_window): Move to
4112         tui-winsource.c.
4113         * tui/tui-win.c (tui_source_window_base::refresh_all)
4114         (tui_source_window_base::update_tab_width)
4115         (tui_source_window_base::set_new_height)
4116         (tui_source_window_base::do_make_visible_with_new_height): Move to
4117         tui-winsource.c.
4118         * tui/tui-source.h: Update.
4119         * tui/tui-source.c (tui_source_window_base::reset): Move to
4120         tui-winsource.c.
4121         * tui/tui-disasm.h: Update.
4122         * tui/tui-data.h (struct tui_exec_info_window): Move to
4123         tui-winsource.h.
4124         (struct tui_source_window_base): Likewise.
4125         * tui/tui-data.c (tui_source_window_base::clear_detail)
4126         (tui_source_window_base, ~tui_source_window_base): Move to
4127         tui-winsource.c.
4128
4129 2019-07-17  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-win.c (tui_resize_all)
4132         (tui_source_window_base::update_tab_width)
4133         (tui_adjust_win_heights): Update.
4134         (tui_win_info::make_invisible_and_set_new_height): Rename from
4135         make_invisible_and_set_new_height.
4136         * tui/tui-data.h (struct tui_win_info)
4137         <make_invisible_and_set_new_height>: New method.
4138
4139 2019-07-17  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui.c: Update.
4142         * tui/tui-source.h (struct tui_source_window): Move from
4143         tui-data.h.
4144         * tui/tui-layout.c: Update.
4145         * tui/tui-disasm.c: Update.
4146         * tui/tui-data.h (struct tui_source_window): Move to
4147         tui-source.h.
4148
4149 2019-07-17  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4152         tui-data.h.
4153         * tui/tui-data.h (struct tui_disasm_window): Move to
4154         tui-disasm.h.
4155
4156 2019-07-17  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-regs.h (struct tui_data_item_window): Move from
4159         tui-data.h.
4160         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4161         * tui/tui-data.h (struct tui_data_item_window): Move to
4162         tui-regs.h.
4163         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4164
4165 2019-07-17  Tom Tromey  <tom@tromey.com>
4166
4167         * tui/tui.c: Update.
4168         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4169         (tui_cmd_window::max_height): Move to tui-command.c.
4170         * tui/tui-layout.c: Update.
4171         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4172         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4173         tui-command.c.
4174         * tui/tui-command.h (struct tui_cmd_window): Move from
4175         tui-data.h.
4176         * tui/tui-command.c: Remove "structuring" comments.
4177         (tui_cmd_window::clear_detail)
4178         (tui_cmd_window::do_make_visible_with_new_height)
4179         (tui_cmd_window::max_height): Move from elsewhere.
4180
4181 2019-07-17  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4184         Now static.
4185         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4186         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4187
4188 2019-07-17  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui.c: Update.
4191         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4192         tui-regs.c.
4193         * tui/tui-windata.h: Remove file.
4194         * tui/tui-windata.c: Remove file.
4195         * tui/tui-win.c (tui_data_window::set_new_height)
4196         (tui_data_window::do_make_visible_with_new_height): Move to
4197         tui-regs.c.
4198         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4199         * tui/tui-regs.c: Remove "structuring" comments.
4200         (tui_data_window::first_data_item_displayed)
4201         (tui_data_window::delete_data_content_windows)
4202         (tui_data_window::erase_data_content)
4203         (tui_data_window::display_all_data)
4204         (tui_data_window::refresh_all)
4205         (tui_data_window::do_scroll_vertical)
4206         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4207         (tui_data_window::do_make_visible_with_new_height)
4208         (tui_data_window::refresh_window): Move from elsewhere.
4209         (_initialize_tui_regs): Move to end of file.
4210         * tui/tui-layout.c: Update.
4211         * tui/tui-hooks.c: Update.
4212         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4213         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4214         tui-regs.c.
4215         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4216
4217 2019-07-17  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4220         seen.
4221
4222 2019-07-17  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui-win.c (tui_source_window_base::set_new_height)
4225         (tui_source_window_base::do_make_visible_with_new_height): Use
4226         m_has_locator field directly.
4227         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4228         method.
4229         (struct tui_source_window_base) <has_locator>: Likewise.
4230
4231 2019-07-17  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4234         Don't declare.
4235         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4236         Remove.
4237         * tui/tui-win.c (tui_source_window_base::set_new_height)
4238         (tui_source_window_base::set_new_height)
4239         (make_invisible_and_set_new_height)
4240         (tui_source_window_base::do_make_visible_with_new_height)
4241         (tui_source_window_base::do_make_visible_with_new_height):
4242         Update.
4243         * tui/tui-layout.c (show_source_disasm_command, show_data)
4244         (show_source_or_disasm_and_command): Update.
4245         * tui/tui-layout.c (show_layout): Update.
4246
4247 2019-07-17  Tom Tromey  <tom@tromey.com>
4248
4249         * tui/tui-layout.c (make_data_window): Remove.
4250         (show_data): Unify creation and re-initialization cases.
4251
4252 2019-07-17  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-layout.c (make_source_window, make_disasm_window):
4255         Remove.
4256         (show_data): Unify creation and re-initialization cases.
4257
4258 2019-07-17  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-layout.c (make_command_window): Remove.
4261         (show_source_disasm_command, show_source_or_disasm_and_command):
4262         Unify creation and re-initialization cases.
4263
4264 2019-07-17  Tom Tromey  <tom@tromey.com>
4265
4266         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4267         creation and re-initialization cases.
4268
4269 2019-07-17  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-regs.c (tui_get_register): Return void.
4272
4273 2019-07-17  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4276         Simplify.
4277
4278 2019-07-17  Tom Tromey  <tom@tromey.com>
4279
4280         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4281         resetting.
4282
4283 2019-07-17  Tom Tromey  <tom@tromey.com>
4284
4285         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4286         * tui/tui-regs.c (tui_reg_layout): New function.
4287         (tui_show_registers, tui_reg_command): Use it.
4288         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4289         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4290         parameters.
4291         (tui_layout_command): Remove.
4292
4293 2019-07-17  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui-layout.h (tui/tui-layout): Return void.
4296         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4297
4298 2019-07-17  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-layout.c (show_source_disasm_command, show_data):
4301         Update.
4302         (reset_locator): Remove.
4303         (show_source_or_disasm_and_command): Update.
4304
4305 2019-07-17  Tom Tromey  <tom@tromey.com>
4306
4307         * tui/tui-source.c (tui_source_window_base::reset): Remove
4308         win_type parameter.
4309         * tui/tui-layout.c (make_command_window, make_source_window)
4310         (make_disasm_window, make_data_window)
4311         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4312         (reset_locator, show_source_or_disasm_and_command): Update.
4313         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4314         win_type parameter.
4315         (struct tui_source_window_base) <reset>: Likewise.
4316
4317 2019-07-17  Tom Tromey  <tom@tromey.com>
4318
4319         * tui/tui-layout.c (show_source_disasm_command): Use
4320         reset_locator.
4321         (reset_locator): New function.
4322         (init_and_make_win): Remove.
4323         (show_source_or_disasm_and_command): Use reset_locator.
4324
4325 2019-07-17  Tom Tromey  <tom@tromey.com>
4326
4327         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4328         condition.
4329         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4330         Remove condition.
4331         * tui/tui-source.c (tui_source_window_base::reset): New method.
4332         * tui/tui-layout.c (make_command_window): Don't call
4333         init_and_make_win.
4334         (make_source_window, make_disasm_window): Don't call
4335         make_source_or_disasm_window.
4336         (make_data_window): Don't call init_and_make_win.  Change calling
4337         convention.
4338         (show_source_disasm_command, show_data): Simplify.
4339         (make_source_or_disasm_window): Remove.
4340         (show_source_or_disasm_and_command): Simplify.
4341         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4342         (struct tui_source_window_base) <reset>: Likewise.
4343         <execution_info>: Remove initializer.
4344         * tui/tui-data.c (tui_source_window_base): Initialize
4345         execution_info.
4346
4347 2019-07-17  Tom Tromey  <tom@tromey.com>
4348
4349         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4350         variable.
4351
4352 2019-07-17  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui.c (tui_rl_other_window): Update.
4355         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4356         superclass method first.  Always iterate over regs_content.
4357         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4358         method.
4359         * tui/tui-win.c (tui_set_focus_command): Update.
4360
4361 2019-07-17  Tom Tromey  <tom@tromey.com>
4362
4363         * tui/tui-win.c (tui_set_focus_command): Rename from
4364         tui_set_focus.  Call tui_enable.
4365         (tui_set_focus_command): Remove.
4366
4367 2019-07-17  Tom Tromey  <tom@tromey.com>
4368
4369         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4370         refresh_window.
4371         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4372         touchwin.
4373         (tui_data_window::refresh_window): Call refresh_window on data
4374         items.  Always call superclass refresh_window.
4375         (tui_win_info::refresh): Remove.
4376         (tui_source_window_base::refresh_window): Update.
4377         (tui_refresh_all): Update.
4378         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4379         refresh_window.
4380         (show_source_or_disasm_and_command): Likewise.
4381         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4382         (struct tui_source_window_base) <refresh>: Likewise.
4383
4384 2019-07-17  Tom Tromey  <tom@tromey.com>
4385
4386         * tui/tui-winsource.c (tui_clear_source_content)
4387         (tui_show_source_content): Update.
4388         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4389         whether content is empty.
4390         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4391         Remove.
4392
4393 2019-07-17  Tom Tromey  <tom@tromey.com>
4394
4395         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4396         window's contents.
4397         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4398         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4399
4400 2019-07-17  Tom Tromey  <tom@tromey.com>
4401
4402         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4403         (struct tui_data_item_window): Update.
4404
4405 2019-07-17  Tom Tromey  <tom@tromey.com>
4406
4407         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4408         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4409         defines.
4410
4411 2019-07-17  Tom Tromey  <tom@tromey.com>
4412
4413         * tui/tui-winsource.h (tui_erase_source_content)
4414         (tui_clear_source_content): Remove "display_prompt" parameter.
4415         * tui/tui-winsource.c (tui_update_source_window_as_is)
4416         (tui_update_source_windows_with_addr): Update.
4417         (tui_clear_source_content): Remove "display_prompt" parameter.
4418         (tui_erase_source_content): Likewise.  Simplify.
4419         (tui_show_source_content): Update.
4420         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4421         * tui/tui-stack.c (tui_show_frame_info): Update.
4422         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4423         Remove defines.
4424
4425 2019-07-17  Tom Tromey  <tom@tromey.com>
4426
4427         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4428         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4429         parameter.
4430         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4431         parameter.
4432
4433 2019-07-17  Tom Tromey  <tom@tromey.com>
4434
4435         * tui/tui-winsource.c (tui_clear_source_content)
4436         (tui_show_source_content, tui_show_exec_info_content)
4437         (tui_clear_exec_info_content): Update.
4438         * tui/tui-stack.c (tui_show_locator_content): Update.
4439         (tui_show_frame_info): Update.
4440         * tui/tui-source.h (tui_source_window): Don't declare.
4441         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4442         from tui_source_is_displayed.
4443         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4444         Remove field.
4445         (struct tui_source_window_base) <content_in_use>: New field.  Now
4446         bool.
4447         (struct tui_source_window) <showing_source_p>: New method.
4448         (TUI_SRC_WIN): Change cast.
4449         * tui/tui-data.c (tui_initialize_static_data): Update.
4450
4451 2019-07-17  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4454         location_matches_p.
4455         * tui/tui-source.c (tui_source_window::location_matches_p): New
4456         method.
4457         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4458         method.
4459         * tui/tui-data.h (struct tui_source_window_base)
4460         <location_matches_p>: New method.
4461         (struct tui_source_window, struct tui_disasm_window)
4462         <location_matches_p>: Likewise.
4463
4464 2019-07-17  Tom Tromey  <tom@tromey.com>
4465
4466         * tui/tui-win.c (tui_set_win_height_command): Rename from
4467         tui_set_win_height.
4468         (tui_set_win_height_command): Remove.
4469
4470 2019-07-17  Tom Tromey  <tom@tromey.com>
4471
4472         * tui/tui-source.c (tui_source_window): New constructor.  Add
4473         observer.
4474         (~tui_source_window): New destructor.
4475         (tui_source_window::style_changed): New method.
4476         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4477         (tui_attach_detach_observers): Update.
4478         * tui/tui-data.h (struct tui_source_window): Make constructor not
4479         inline.  Add destructor.
4480         (struct tui_source_window) <style_changed>: New method.
4481         <m_observable>: New member.
4482
4483 2019-07-17  Tom Tromey  <tom@tromey.com>
4484
4485         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4486         * tui/tui-win.c (tui_resize_all): Fix typo.
4487
4488 2019-07-17  Tom Tromey  <tom@tromey.com>
4489
4490         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4491         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4492         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4493         * tui/tui-win.c (window_name_completer): Use foreach.
4494         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4495         (update_tab_width): Likewise.
4496         * tui/tui-layout.c (show_layout): Update.
4497         * tui/tui-data.h (class tui_window_iterator): New.
4498         (struct all_tui_windows): New.
4499         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4500
4501 2019-07-17  Tom Tromey  <tom@tromey.com>
4502
4503         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4504         parameter.  Don't reference globals.
4505         (tui_reg_command): Update.
4506
4507 2019-07-17  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-regs.c (tui_show_registers): Simplify.
4510
4511 2019-07-17  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-regs.c (tui_show_registers): Update.
4514         (tui_show_register_group): Add win_info parameter.
4515
4516 2019-07-17  Tom Tromey  <tom@tromey.com>
4517
4518         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4519         Rename from tui_display_reg_element_at_line.
4520         (tui_data_window::display_registers_from_line): Update.
4521         * tui/tui-data.h (struct tui_data_window)
4522         <display_reg_element_at_line>: New method.
4523
4524 2019-07-17  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-regs.h (tui_display_registers_from)
4527         (tui_display_registers_from_line): Don't declare.
4528         * tui/tui-windata.c (tui_data_window::display_all_data)
4529         (tui_data_window::refresh_all)
4530         (tui_data_window::do_scroll_vertical): Update.
4531         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4532         from tui_display_registers_from.
4533         (tui_display_reg_element_at_line): Update.
4534         (tui_data_window::display_registers_from_line): Rename from
4535         tui_display_registers_from_line.
4536         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4537         display_registers_from_line>: New methods.
4538
4539 2019-07-17  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4542         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4543         from tui_erase_data_content.
4544         (tui_data_window::display_all_data)
4545         (tui_data_window::refresh_all)
4546         (tui_data_window::do_scroll_vertical): Update.
4547         * tui/tui-regs.c (tui_show_registers): Update.
4548         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4549         New method.
4550
4551 2019-07-17  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4554         declare.
4555         * tui/tui-windata.c
4556         (tui_data_window::delete_data_content_windows): Rename from
4557         tui_delete_data_content_windows.
4558         (tui_data_window::display_all_data)
4559         (tui_data_window::do_scroll_vertical): Update.
4560         * tui/tui-data.h (struct tui_data_window)
4561         <delete_data_content_windows>: New method.
4562
4563 2019-07-17  Tom Tromey  <tom@tromey.com>
4564
4565         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4566         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4567
4568 2019-07-17  Tom Tromey  <tom@tromey.com>
4569
4570         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4571         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4572         from tui_display_all_data.
4573         * tui/tui-win.c
4574         (tui_data_window::do_make_visible_with_new_height): Update.
4575         * tui/tui-regs.c (tui_show_registers): Update.
4576         * tui/tui-layout.c (tui_set_layout): Update.
4577         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4578         method.
4579
4580 2019-07-17  Tom Tromey  <tom@tromey.com>
4581
4582         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4583         * tui/tui-windata.c (tui_display_data_from): Remove.
4584         (tui_data_window::refresh_all): Update.
4585
4586 2019-07-17  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4589         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4590         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4591         tui_display_registers_from_line.
4592         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4593         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4594         "force_display" parameter.
4595
4596 2019-07-17  Tom Tromey  <tom@tromey.com>
4597
4598         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4599         declare.
4600         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4601         Rename from tui_first_reg_element_no_inline.
4602         (tui_display_reg_element_at_line)
4603         (tui_display_registers_from_line): Update.
4604         * tui/tui-data.h (struct tui_data_window)
4605         <first_reg_element_no_inline>: New method.
4606
4607 2019-07-17  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui-windata.c (tui_display_data_from)
4610         (tui_data_window::do_scroll_vertical): Update.
4611         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4612         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4613         Rename from tui_line_from_reg_element_no.
4614         (tui_display_registers_from_line): Update.
4615         * tui/tui-data.h (struct tui_data_window)
4616         <line_from_reg_element_no>: New method.
4617
4618 2019-07-17  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4621         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4622         tui_last_regs_line_no.
4623         (tui_display_reg_element_at_line)
4624         (tui_display_registers_from_line): Update.
4625         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4626         method.
4627
4628 2019-07-17  Tom Tromey  <tom@tromey.com>
4629
4630         PR tui/24722:
4631         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4632         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4633         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4634         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4635         (tui_update_breakpoint_info): Likewise.
4636         * tui/tui-hooks.c (tui_event_create_breakpoint)
4637         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4638         Update.
4639
4640 2019-07-17  Tom Tromey  <tom@tromey.com>
4641
4642         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4643
4644 2019-07-17  Tom Tromey  <tom@tromey.com>
4645
4646         * tui/tui-winsource.c (tui_update_source_window_as_is)
4647         (tui_update_source_windows_with_addr): Update.
4648         * tui/tui-source.h (tui_set_source_content)
4649         (tui_show_symtab_source): Add "win_info" parameter.
4650         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4651         parameter.
4652         (tui_show_symtab_source): Likewise.
4653
4654 2019-07-17  Tom Tromey  <tom@tromey.com>
4655
4656         * tui/tui-wingeneral.c
4657         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4658
4659 2019-07-17  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4662         (struct tui_cmd_window) <can_scroll>: New method.
4663         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4664         method.
4665
4666 2019-07-17  Tom Tromey  <tromey@adacore.com>
4667
4668         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4669         do_field_signed>: Rename.  Change type of "value".
4670         * ui-out.c (ui_out::field_signed): Rename from field_int.
4671         Change type of "value".
4672         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4673         type of "value".
4674         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4675         do_field_int.  Change type of "value".
4676         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4677         do_field_int.  Change type of "value".
4678         * tracepoint.c (trace_status_mi, tfind_1)
4679         (print_one_static_tracepoint_marker): Update.
4680         * thread.c (print_thread_info_1, print_selected_thread_frame):
4681         Update.
4682         * stack.c (print_frame, print_frame_info): Update.
4683         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4684         Update.
4685         * source.c (print_source_lines_base): Update.
4686         * skip.c (info_skip_command): Update.
4687         * record-btrace.c (btrace_ui_out_decode_error)
4688         (btrace_call_history_src_line): Update.
4689         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4690         Update.
4691         * progspace.c (print_program_space): Update.
4692         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4693         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4694         do_field_int.  Change type of "value".
4695         * mi/mi-out.c (mi_ui_out::do_table_begin)
4696         (mi_ui_out::do_table_header): Update.
4697         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4698         type of "value".
4699         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4700         (mi_cmd_data_list_changed_registers, output_register)
4701         (mi_cmd_data_read_memory, mi_load_progress)
4702         (mi_cmd_trace_frame_collected): Update.
4703         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4704         Update.
4705         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4706         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4707         (mi_cmd_var_list_children, varobj_update_one): Update.
4708         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4709         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4710         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4711         * inferior.c (print_inferior): Update.
4712         * gdb_bfd.c (print_one_bfd): Update.
4713         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4714         Update.
4715         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4716         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4717         do_field_int.  Change type of "value".
4718         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4719         do_field_int.  Change type of "value".
4720         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4721         (print_one_breakpoint_location, print_it_catch_fork)
4722         (print_one_catch_fork, print_it_catch_vfork)
4723         (print_one_catch_vfork, print_it_catch_solib)
4724         (print_it_catch_exec, print_it_ranged_breakpoint)
4725         (print_mention_watchpoint, print_mention_masked_watchpoint)
4726         (bkpt_print_it, update_static_tracepoint): Update.
4727         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4728         * break-catch-syscall.c (print_it_catch_syscall): Update.
4729         * ada-tasks.c (print_ada_task_info): Update.
4730         * ada-lang.c (print_it_exception, print_mention_exception):
4731         Update.
4732
4733 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4734
4735         PR breakpoints/24541
4736         * gdbarch.c: Regenerate.
4737         * gdbarch.h: Regenerate.
4738         * gdbarch.sh: Adjust return type and parameter types for
4739         'stap_adjust_register'.
4740         (i386_stap_adjust_register): Adjust signature and return new
4741         register name.
4742         * stap-probe.c (stap_parse_register_operand): Adjust use of
4743         'gdbarch_stap_adjust_register'.
4744
4745 2019-07-17  Tom Tromey  <tromey@adacore.com>
4746
4747         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4748         declare VEC.
4749         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4750         std::vector.
4751         (struct s390_process_info): Add initializers.
4752         (s390_add_process): Use new.
4753         (s390_linux_nat_target::low_forget_process): Use delete.
4754         (s390_linux_nat_target::low_new_fork)
4755         (s390_linux_nat_target::stopped_by_watchpoint)
4756         (s390_linux_nat_target::low_prepare_to_resume)
4757         (s390_linux_nat_target::insert_watchpoint)
4758         (s390_linux_nat_target::insert_hw_breakpoint)
4759         (s390_linux_nat_target::remove_watchpoint)
4760         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4761
4762 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4763
4764         * aarch64-fbsd-nat.c: Include regcache.h.
4765         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4766         argument.
4767         (aarch64_fbsd_nat_target::fetch_registers)
4768         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4769         variable.
4770         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4771
4772 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4773
4774         * fbsd-nat.c: Include gdbarch.h.
4775
4776 2019-07-15  Tom Tromey  <tromey@adacore.com>
4777
4778         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4779
4780 2019-07-15  Tom Tromey  <tromey@adacore.com>
4781
4782         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4783         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4784         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4785         * cli-out.c (cli_ui_out::do_field_int): New method.
4786         * ui-out.c (ui_out::field_unsigned): New method.
4787         * symfile.c (generic_load): Use field_unsigned.
4788         (print_transfer_performance): Likewise.
4789         * record-btrace.c (ui_out_field_uint): Remove.
4790         (btrace_call_history_insn_range, btrace_call_history): Use
4791         field_unsigned.
4792         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4793         field_unsigned.
4794         * ui-out.h (class ui_out) <field_unsigned>: New method.
4795         <do_field_unsigned>: Likewise.
4796
4797 2019-07-15  Tom Tromey  <tromey@adacore.com>
4798
4799         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4800         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4801         * target.c (flash_erase_command): Use field_string.
4802         * infrun.c (print_signal_received_reason): Use field_string.
4803         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4804         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4805         field_string.
4806         * ada-tasks.c (print_ada_task_info): Use field_string.
4807
4808 2019-07-15  Tom Tromey  <tromey@adacore.com>
4809
4810         * target.c (flash_erase_command): Use field_core_addr.
4811         * symfile.c (generic_load): Use field_core_addr.
4812         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4813         Use field_core_addr.
4814         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4815         field_core_addr.
4816
4817 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4820         value if its desired type is smaller than a CORE_ADDR and signed.
4821
4822 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4825         of changes to field names, and use new is_reference field to
4826         decide if a property is a reference or not.
4827         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4828         field.
4829         (struct dwarf2_property_baton): Update header comment, rename
4830         'referenced_type' to 'property_type' and update comments.
4831         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4832         default property type, store in property baton, update to take
4833         accound of renamed field.
4834         (read_func_scope): Update call to attr_to_dynamic_prop.
4835         (read_array_type): Likewise.
4836         (dwarf2_per_cu_addr_sized_int_type): New function.
4837         (read_subrange_index_type): Move type finding code to
4838         dwarf2_per_cu_addr_sized_int_type.
4839         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4840         (dwarf2_per_cu_addr_type): New function.
4841         (set_die_type): Update calls to attr_to_dynamic_prop.
4842
4843 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * dwarf2read.c (read_subrange_index_type): New function.
4846         (read_subrange_type): Move code into new function and call it.
4847         * gdbtypes.c (create_range_type): Add some asserts.
4848
4849 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4852         update return statements.
4853         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4854         declaration, and update comment to match.
4855         * gdbtypes.c (resolve_dynamic_array): Update call to
4856         dwarf2_evaluate_property to match new return type.
4857
4858 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4859
4860         * valarith.c (value_subscripted_rvalue): Change lowerbound
4861         parameter type from int to LONGEST.
4862         * value.h (value_subscripted_rvalue): Likewise in declaration.
4863
4864 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * cli/cli-utils.c (info_print_command_completer): New function.
4867         * cli/cli-utils.h: Add 'completer.h' include, and forward
4868         declaration for 'struct cmd_list_element'.
4869         (info_print_command_completer): Declare.
4870         * stack.c (_initialize_stack): Add completer for 'info locals' and
4871         'info args'.
4872         * symtab.c (_initialize_symtab): Add completer for 'info
4873         variables' and 'info functions'.
4874         * NEWS: Mention completion for additional info commands.
4875
4876 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4877
4878         * cli/cli-utils.c (extract_info_print_args): Delete.
4879         (extract_arg_maybe_quoted): Delete.
4880         (info_print_options_defs): New variable.
4881         (make_info_print_options_def_group): New function.
4882         (extract_info_print_options): Define new function.
4883         * cli/cli-utils.h (extract_info_print_args): Delete.
4884         (struct info_print_options): New structure.
4885         (extract_info_print_options): Declare new function.
4886         * stack.c (info_locals_command): Update to use new
4887         extract_info_print_options, also add a header comment.
4888         (info_args_command): Likewise.
4889         * symtab.c (info_variables_command): Likewise.
4890         (info_functions_command): Likewise.
4891
4892 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4895         to extract string arguments.
4896         * common/common-utils.c (extract_string_maybe_quoted): New function.
4897         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4898
4899 2019-07-11  Tom Tromey  <tromey@adacore.com>
4900
4901         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4902         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4903         * top.h (gdbinit): Don't declare.
4904         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4905         into...
4906         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4907         * top.c (gdb_init): Don't call init_cli_cmds.
4908         (gdbinit): Remove.
4909         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4910
4911 2019-07-11  Tom Tromey  <tromey@adacore.com>
4912
4913         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4914         after it has been moved.
4915
4916 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4917
4918         * valops.c (value_must_coerce_to_target): Change return type to
4919         bool.
4920         * value.h (value_must_coerce_to_target): Likewise.
4921
4922 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4923
4924         * breakpoint.c (is_hardware_watchpoint): Remove
4925         forward-declaration.
4926         (is_masked_watchpoint): Change return type to bool.
4927         (is_tracepoint): Likewise.
4928         (is_breakpoint): Likewise.
4929         (is_hardware_watchpoint): Likewise.
4930         (is_watchpoint): Likewise.
4931         (is_no_memory_software_watchpoint): Likewise.
4932         (is_catchpoint): Likewise.
4933         (breakpoint_1): Make FILTER parameter's return type bool.
4934         is_masked_watchpoint): Change return type to bool.
4935         (save_breakpoints): Make FILTER parameter's return type bool.
4936         * breakpoint.h (is_breakpoint): Change return type to bool.
4937         (is_watchpoint): Likewise.
4938         (is_catchpoint): Likewise.
4939         (is_tracepoint): Likewise.
4940
4941 2019-07-10  Tom Tromey  <tom@tromey.com>
4942
4943         * defs.h: Don't include gdbarch.h.
4944         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4945         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4946         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4947         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4948         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4949         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4950         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4951         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4952         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4953         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4954         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4955         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4956         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4957         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4958         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4959         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4960         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4961         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4962         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4963         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4964         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4965         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4966         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4967         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4968         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4969         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4970         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4971
4972 2019-07-10  Tom Tromey  <tromey@adacore.com>
4973
4974         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4975         * breakpoint.c (init_ada_exception_breakpoint): Register as
4976         bp_catchpoint.
4977         (print_one_breakpoint_location, print_one_breakpoint): Use
4978         is_ada_exception_catchpoint.
4979         * ada-lang.c (class ada_catchpoint_location): Pass
4980         bp_loc_software_breakpoint to bp_location constructor.
4981         (is_ada_exception_catchpoint): New function.
4982
4983 2019-07-10  Tom Tromey  <tromey@adacore.com>
4984
4985         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4986         VEC.
4987         (struct arm_exidx_entry): New method operator<.
4988         (struct arm_exidx_data) <section_maps>: Change type.
4989         (arm_exidx_data_free): Remove.
4990         (arm_exidx_data_key): Change type.  Move lower.
4991         (arm_exidx_new_objfile): Update.
4992         (arm_compare_exidx_entries): Remove.
4993         (arm_find_exidx_entry, _initialize_arm_tdep)
4994
4995 2019-07-10  Tom Tromey  <tromey@adacore.com>
4996
4997         * solib-spu.c (ocl_program_data_key): Change type.
4998         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4999         Update.
5000
5001 2019-07-10  Tom Tromey  <tromey@adacore.com>
5002
5003         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5004         (struct solib_aix_inferior_data) <library_list>: Change type.
5005         (solib_aix_inferior_data_handle): Change type.
5006         (get_solib_aix_inferior_data): Update.
5007         (solib_aix_free_library_list): Remove.
5008         (library_list_start_library): Update.
5009         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5010         return type.
5011         (solib_aix_get_library_list)
5012         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5013         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5014
5015 2019-07-10  Tom Tromey  <tromey@adacore.com>
5016
5017         * solib-dsbt.c (struct dsbt_info): Add initializers.
5018         (solib_dsbt_pspace_data): Change type.
5019         (dsbt_pspace_data_cleanup): Remove.
5020         (get_dsbt_info, _initialize_dsbt_solib): Update.
5021
5022 2019-07-10  Tom Tromey  <tromey@adacore.com>
5023
5024         * spu-tdep.c (spu_overlay_data): Change type.
5025         (spu_get_overlay_table, spu_overlay_new_objfile)
5026         (_initialize_spu_tdep): Update.
5027
5028 2019-07-10  Tom Tromey  <tromey@adacore.com>
5029
5030         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5031         destructor.
5032         (dbx_objfile_data_key): Change type and declare later.
5033         (DBX_SYMFILE_INFO): Rewrite.
5034         * dbxread.c (dbx_objfile_data_key): Change type.
5035         (dbx_symfile_init): Update.
5036         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5037         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5038         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5039
5040 2019-07-10  Tom Tromey  <tromey@adacore.com>
5041
5042         * jit.c (jit_program_space_key): Change type.  Move lower.
5043         (get_jit_program_space_data): Update.
5044         (jit_program_space_data_cleanup): Remove.
5045         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5046         Update.
5047         (struct jit_program_space_data): Add initializers.
5048
5049 2019-07-10  Tom Tromey  <tromey@adacore.com>
5050
5051         * solib-darwin.c (struct darwin_info): Add initializers.
5052         (solib_darwin_pspace_data): Change type.
5053         (darwin_pspace_data_cleanup): Remove.
5054         (get_darwin_info, _initialize_darwin_solib): Update.
5055
5056 2019-07-10  Tom Tromey  <tromey@adacore.com>
5057
5058         * remote-sim.c (struct sim_inferior_data): Add initializers,
5059         constructor, and destructor.
5060         (sim_inferior_data_key): Change type.  Move lower.
5061         (check_for_duplicate_sim_descriptor): Update.
5062         (get_sim_inferior_data): Use new.  Update.
5063         (~sim_inferior_data_cleanup): Rename from
5064         sim_inferior_data_cleanup.  Simplify.
5065         (gdbsim_close_inferior, simulator_command)
5066         (sim_command_completer, _initialize_remote_sim): Update.
5067         (next_pid, INITIAL_PID): Move earlier.
5068
5069 2019-07-10  Tom Tromey  <tromey@adacore.com>
5070
5071         * python/python-internal.h (create_thread_object): Return
5072         gdbpy_ref.
5073         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5074         * python/py-inferior.c (struct threadlist_entry): Add
5075         constructor.
5076         <thread_obj>: Now a gdbpy_ref.
5077         (thread_to_thread_object): Update.
5078         (add_thread_object): Use new.
5079         (delete_thread_object): Use delete.
5080         (infpy_threads): Update.
5081         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5082         GIL.
5083
5084 2019-07-10  Tom Tromey  <tromey@adacore.com>
5085
5086         * valops.c (value_cast): Specialize error message for Ada.
5087
5088 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5089
5090         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5091
5092 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5093
5094         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5095         bpstat_should_step): Return bool, adjust comments.
5096         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5097         bpstat_should_step): Likewise.
5098
5099 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5100
5101         * features/Makefile: Use feature target descriptions for Arm.
5102         * features/arm/arm-core.c: Generate new file.
5103         * features/arm/arm-fpa.c: Likewise.
5104         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5105         * features/arm/arm-m-profile.c: Likewise.
5106         * features/arm/arm-vfpv2.c: Likewise.
5107         * features/arm/arm-vfpv3.c: Likewise.
5108         * features/arm/xscale-iwmmxt.c: Likewise.
5109         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5110
5111 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5112
5113         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5114         ptrace earlier.
5115
5116 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5117
5118         * features/aarch64-pauth.c: Regenerate.
5119
5120 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5121
5122         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5123         bool.
5124         (bpstat_what): Use false instead of 0.
5125
5126 2019-07-09  Pedro Alves  <palves@redhat.com>
5127
5128         * break-catch-throw.c (is_exception_catchpoint): New.
5129         * breakpoint.c (print_one_breakpoint_location): New parameter
5130         'raw_loc'.  Handle it.  Use
5131         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5132         looking at the breakpoint's type.
5133         (print_one_breakpoint): If handling "maint info breakpoints", also
5134         print locations of exception catchpoints.
5135         * breakpoint.h (is_exception_catchpoint): Declare.
5136
5137 2019-07-09  Pedro Alves  <palves@redhat.com>
5138
5139         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5140         "addr" field.
5141         (allocate_location_exception_catchpoint): New.
5142         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5143         (initialize_throw_catchpoint_ops): Install
5144         allocate_location_exception_catchpoint as allocate_location
5145         method.
5146         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5147         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5148         bp_loc_other.
5149         (breakpoint_address_is_meaningful): Delete.
5150         (bl_address_is_meaningful): New.
5151         (breakpoint_locations_match): Adjust comment.
5152         (bp_location_from_bp_type): New, factored out of...
5153         (bp_location::bp_location(breakpoint *)): ... this.
5154         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5155         factored out of...
5156         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5157         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5158         breakpoint_address_is_meaningful.
5159         (bp_locations_compare): Adjust comment.
5160         (update_global_location_list): Use bl_address_is_meaningful
5161         instead of breakpoint_address_is_meaningful.
5162         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5163         explicit.
5164         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5165         * python/py-breakpoint.c (bppy_get_location): No longer check
5166         whether location is null.
5167
5168 2019-07-09  Pedro Alves  <palves@redhat.com>
5169
5170         PR c++/15468
5171         * breakpoint.c (print_one_breakpoint_location): Remove
5172         single-location assert.
5173
5174 2019-07-09  Tom Tromey  <tom@tromey.com>
5175
5176         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5177         * configure: Rebuild.
5178         * configure.ac: Change common to gdbsupport.
5179         * gdbsupport: Rename from common.
5180         * acinclude.m4: Change common to gdbsupport.
5181         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5182         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5183         gdbsupport.
5184         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5185         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5186         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5187         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5188         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5189         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5190         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5191         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5192         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5193         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5194         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5195         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5196         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5197         coff-pe-read.c, command.h, compile/compile-c-support.c,
5198         compile/compile-c.h, compile/compile-cplus-symbols.c,
5199         compile/compile-cplus-types.c, compile/compile-cplus.h,
5200         compile/compile-loc2c.c, compile/compile.c, completer.c,
5201         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5202         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5203         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5204         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5205         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5206         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5207         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5208         features/aarch64-core.c, features/aarch64-fpu.c,
5209         features/aarch64-pauth.c, features/aarch64-sve.c,
5210         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5211         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5212         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5213         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5214         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5215         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5216         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5217         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5218         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5219         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5220         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5221         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5222         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5223         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5224         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5225         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5226         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5227         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5228         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5229         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5230         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5231         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5232         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5233         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5234         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5235         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5236         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5237         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5238         minsyms.c, mips-linux-tdep.c, namespace.h,
5239         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5240         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5241         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5242         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5243         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5244         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5245         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5246         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5247         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5248         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5249         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5250         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5251         procfs.c, producer.c, progspace.h, psymtab.h,
5252         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5253         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5254         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5255         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5256         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5257         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5258         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5259         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5260         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5261         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5262         target-memory.c, target.c, target.h, target/waitstatus.c,
5263         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5264         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5265         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5266         unittests/array-view-selftests.c,
5267         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5268         unittests/common-utils-selftests.c,
5269         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5270         unittests/format_pieces-selftests.c,
5271         unittests/function-view-selftests.c,
5272         unittests/lookup_name_info-selftests.c,
5273         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5274         unittests/mkdir-recursive-selftests.c,
5275         unittests/observable-selftests.c,
5276         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5277         unittests/parse-connection-spec-selftests.c,
5278         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5279         unittests/scoped_fd-selftests.c,
5280         unittests/scoped_mmap-selftests.c,
5281         unittests/scoped_restore-selftests.c,
5282         unittests/string_view-selftests.c, unittests/style-selftests.c,
5283         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5284         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5285         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5286         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5287         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5288         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5289
5290 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5293         bool value.
5294         (decode_digits_ordinary): Set explicit_line field in sal.
5295         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5296         symtab_and_line that was set on an explicit line number in
5297         assembler code.  Do always update the recorded symtab and line if
5298         we do skip the prologue.
5299
5300 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * breakpoint.c (set_breakpoint_location_function): Remove
5303         explicit_loc parameter.
5304         (momentary_breakpoint_from_master): Update call to
5305         set_breakpoint_location_function.
5306         (add_location_to_breakpoint): Likewise.
5307
5308 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5309
5310         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5311         required features based on default bfd type when no specific bfd
5312         is present.
5313
5314 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5315
5316         * NEWS: Mention that GDB printf and eval commands can now print
5317         C-style and Ada-style convenience var strings without
5318         calling the inferior.
5319         * printcmd.c (printf_c_string): Locally print GDB internal var
5320         instead of transiting via the inferior.
5321         (printf_wide_c_string): Likewise.
5322
5323 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5324
5325         PR breakpoints/25011
5326         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5327
5328 2019-07-04  Tom Tromey  <tom@tromey.com>
5329
5330         PR tui/24724:
5331         * tui/tui-winsource.c (tui_clear_source_content): Update.
5332         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5333         (tui_update_breakpoint_info): Update.
5334         (tui_set_exec_info_content): Update.
5335         * tui/tui-source.c (tui_set_source_content_nil): Update.
5336         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5337         has_break.
5338         * tui/tui-data.h (enum tui_bp_flag): New.
5339         (tui_bp_flags): New enum flags type.
5340         (struct tui_source_element) <break_mode>: Change type.  Rename
5341         from has_break.
5342         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5343         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5344         constants.
5345         * tui/tui-winsource.h: Fix comment.
5346
5347 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5348
5349         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5350         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5351         (store_fpregs_to_thread)
5352         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5353         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5354         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5355         (IWMMXT_REGS_SIZE): Add define.
5356         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5357         (fetch_vfp_regs, store_vfp_regs)
5358         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5359         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5360
5361 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5362
5363         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5364         defines.
5365         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5366         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5367         (ARM_INT_REGISTER_SIZE): ...to this.
5368         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5369         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5370         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5371         (arm_linux_collect_gregset, supply_nwfpe_register)
5372         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5373         defines.
5374         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5375         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5376         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5377         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5378         (arm_return_in_memory, arm_store_return_value)
5379         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5380         (arm_record_ld_st_multiple): Likewise.
5381         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5382         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5383
5384 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5385
5386         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5387         AARCH64_DISPLACED_MODIFIED_INSNS.
5388         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5389         (aarch64_displaced_step_copy_insn): Likewise.
5390         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5391         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5392         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5393         ARM_DISPLACED_MODIFIED_INSNS.
5394         * arm-tdep.c (arm_gdbarch_init): Likewise.
5395         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5396         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5397         (struct arm_displaced_step_closure): Use
5398         ARM_DISPLACED_MODIFIED_INSNS.
5399
5400 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5401
5402         * features/Makefile: Remove unused xml files.
5403         * features/aarch64.xml: Remove.
5404         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5405         * features/i386/amd64-avx-avx512.xml: Remove.
5406         * features/i386/amd64-avx-linux.xml: Remove.
5407         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5408         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5409         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5410         * features/i386/amd64-avx-mpx.xml: Remove.
5411         * features/i386/amd64-avx.xml: Remove.
5412         * features/i386/amd64-linux.xml: Remove.
5413         * features/i386/amd64-mpx-linux.xml: Remove.
5414         * features/i386/amd64-mpx.xml: Remove.
5415         * features/i386/amd64.xml: Remove.
5416         * features/i386/i386-avx-avx512-linux.xml: Remove.
5417         * features/i386/i386-avx-avx512.xml: Remove.
5418         * features/i386/i386-avx-linux.xml: Remove.
5419         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5420         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5421         * features/i386/i386-avx-mpx-linux.xml: Remove.
5422         * features/i386/i386-avx-mpx.xml: Remove.
5423         * features/i386/i386-avx.xml: Remove.
5424         * features/i386/i386-linux.xml: Remove.
5425         * features/i386/i386-mmx-linux.xml: Remove.
5426         * features/i386/i386-mmx.xml: Remove.
5427         * features/i386/i386-mpx-linux.xml: Remove.
5428         * features/i386/i386-mpx.xml: Remove.
5429         * features/i386/i386.xml: Remove.
5430         * features/i386/x32-avx-avx512-linux.xml: Remove.
5431         * features/i386/x32-avx-linux.xml: Remove.
5432         * features/i386/x32-linux.xml: Remove.
5433
5434 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5435
5436         * regformats/aarch64.dat: Remove.
5437         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5438         * regformats/i386/amd64-avx-linux.dat: Remove.
5439         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5440         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5441         * regformats/i386/amd64-linux.dat: Remove.
5442         * regformats/i386/amd64-mpx-linux.dat: Remove.
5443         * regformats/i386/amd64.dat: Remove.
5444         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5445         * regformats/i386/i386-avx-linux.dat: Remove.
5446         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5447         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5448         * regformats/i386/i386-linux.dat: Remove.
5449         * regformats/i386/i386-mmx-linux.dat: Remove.
5450         * regformats/i386/i386-mpx-linux.dat: Remove.
5451         * regformats/i386/i386.dat: Remove.
5452         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5453         * regformats/i386/x32-avx-linux.dat: Remove.
5454         * regformats/i386/x32-linux.dat: Remove.
5455
5456 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5457
5458         * aarch64-tdep.c: Remove xml self tests.
5459         * amd64-linux-tdep.c: Likewise.
5460         * amd64-tdep.c: Likewise.
5461         * i386-linux-tdep.c: Likewise.
5462         * i386-tdep.c: Likewise.
5463
5464 2019-07-03  Pedro Alves  <palves@redhat.com>
5465
5466         PR cli/24732
5467         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5468         (pipe_cmd_option_defs): New.
5469         (make_pipe_cmd_options_def_group): New.
5470         (pipe_command): Use gdb::option::process_options.
5471         (pipe_command_completer): New function.
5472         (_initialize_cli_cmds): Install completer for "pipe" command.
5473
5474 2019-07-03  Pedro Alves  <palves@redhat.com>
5475
5476         * cli/cli-option.c (union option_value) <string>: New field.
5477         (struct option_def_and_value): Add ctor, move ctor, dtor and
5478         use DISABLE_COPY_AND_ASSIGN.
5479         (option_def_and_value::clear_value): New.
5480         (parse_option, save_option_value_in_ctx, get_val_type_str)
5481         (add_setshow_cmds_for_options): Handle var_string.
5482         * cli-option.h (union option_def::var_address) <string>: New
5483         field.
5484         (struct string_option_def): New.
5485         * maint-test-options.c (struct test_options_opts): Add default
5486         ctor and use DISABLE_COPY_AND_ASSIGN.
5487         <string_opt>: New field.
5488         (test_options_opts::~test_options_opts): New.
5489         (test_options_opts::dump): Also dump "-string".
5490         (test_options_option_defs): Install "string.
5491
5492 2019-07-03  Pedro Alves  <palves@redhat.com>
5493
5494         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5495         option_value with a null enumeration.
5496         (complete_options): Save the option values in the context.
5497         (save_option_value_in_ctx): New, factored out from ...
5498         (process_options): ... here.
5499         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5500         of the function.
5501         * maint-test-options.c (test_options_opts::dump): New, factored
5502         out from ...
5503         (maintenance_test_options_command_mode): ... here.
5504         (maintenance_test_options_command_completion_result): Delete.
5505         (maintenance_test_options_command_completion_text): Update
5506         comment.
5507         (maintenance_show_test_options_completion_result): Change
5508         prototype.  Just print
5509         maintenance_test_options_command_completion_text.
5510         (save_completion_result): New.
5511         (maintenance_test_options_completer_mode): Pass options context to
5512         complete_options, and then save a dump.
5513         (_initialize_maint_test_options): Use add_cmd to install "maint
5514         show test-options-completion-result".
5515
5516 2019-07-03  Pedro Alves  <palves@redhat.com>
5517
5518         * NEWS (New commands): Mention "with" and "maint with".
5519         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5520         (with_command, with_command_completer): New.
5521         (pipe_command): Adjust to new repeat_previous
5522         interface.
5523         (_initialize_cli_cmds): Install the "with" command and its "w"
5524         alias.
5525         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5526         declarations.
5527         * cli/cli-setshow.c (parse_cli_var_uinteger)
5528         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5529         argument strings for all var_types.
5530         (get_setshow_command_value_string): New, factored out from ...
5531         (do_show_command): ... this.
5532         * cli/cli-setshow.h: Include <string>.
5533         (get_setshow_command_value_string): Declare.
5534         * command.h (repeat_previous): Now returns const char *.  Adjust
5535         comment.
5536         * maint.c: Include "cli/cli-cmds.h".
5537         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5538         (_initialize_maint_cmds): Register the "maintenance with" command.
5539         * top.c (repeat_previous): Move bits from pipe_command here:
5540         Return the saved command line, if any; error out if there's no
5541         command to relaunch.
5542
5543 2019-07-03  Pedro Alves  <palves@redhat.com>
5544
5545         * NEWS (New commands): Mention "maint set/show test-settings"
5546         instead of "maint test-settings".
5547         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5548         (maintenance_test_settings_set_list): Rename to ...
5549         (maintenance_set_test_settings_list): ... this.
5550         (maintenance_test_settings_show_list): Rename to  ...
5551         (maintenance_show_test_settings_list): ... this.
5552         (maintenance_test_settings_cmd): Delete.
5553         (maintenance_test_settings_set_cmd): ...
5554         (maintenance_set_test_settings_cmd): ... this.
5555         (maintenance_test_settings_show_cmd): ...
5556         (maintenance_show_test_settings_cmd): ... this.
5557         (maintenance_test_settings_show_value_cmd):
5558         (maintenance_show_test_settings_value_cmd): ... this.
5559         (_initialize_maint_test_settings): No longer install the "maint
5560         test-settings" prefix command.  Rename "maint test-settings set"
5561         to "maint set test-settings", and "maint test-settings show" to
5562         "maint show test-settings".  Adjust all subcommands.
5563
5564 2019-07-03  Pedro Alves  <palves@redhat.com>
5565
5566         * maint-test-settings.c: Fix file's intro comment.  Replace all
5567         references to "test-options" with references to "test-settings",
5568         in comments.
5569
5570 2019-07-03  Pedro Alves  <palves@redhat.com>
5571
5572         * maint-test-settings.c (maintenance_test_settings_xxx)
5573         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5574         New.
5575         (maintenance_test_settings_enums): Use them.
5576         (maintenance_test_settings_enum): Default to
5577         maintenance_test_settings_xxx.
5578         (_initialize_maint_test_settings): Initialize
5579         MAINTENANCE_TEST_SETTINGS_FILENAME.
5580
5581 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5582
5583         * breakpoint.h (remove_breakpoints_inf): Change return type to
5584         void, move function documentation here.
5585         * breakpoint.c (remove_breakpoints_inf): Change return type to
5586         void, move function documentation to header.
5587
5588 2019-07-02  Pedro Alves  <palves@redhat.com>
5589
5590         * NEWS (Completion improvements): Mention "info threads".
5591         * thread.c (struct info_threads_opts, info_threads_option_defs)
5592         (make_info_threads_options_def_group): New.
5593         (info_threads_command): Use gdb::option::process_options.
5594         (info_threads_command_completer): New.
5595         (_initialize_thread): Use gdb::option::build_help to build the
5596         help text for "info threads".
5597
5598 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5599
5600         * defs.h (generic_load): Move from here...
5601         * symfile.h (generic_load): ... to here.  Rename name parameter
5602         to args.
5603         * symfile.c (generic_load): Add comment.
5604
5605 2019-07-01  Tom Tromey  <tromey@adacore.com>
5606
5607         * dwarf2read.c
5608         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5609         declaration of without_params.  Fix formatting.
5610
5611 2019-07-01  Tom Tromey  <tromey@adacore.com>
5612
5613         * ada-exp.y (find_primitive_type): Update.
5614         * ada-lang.h (ada_lookup_symbol): Update.
5615         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5616         parameter.
5617         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5618
5619 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5620
5621         PR breakpoints/24541
5622         * gdbarch.c: Regenerate.
5623         * gdbarch.h: Regenerate.
5624         * gdbarch.sh: Add 'stap_adjust_register'.
5625         * i386-tdep.c: Include '<unordered_set>'.
5626         (i386_stap_adjust_register): New function.
5627         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5628         * stap-probe.c (stap_parse_register_operand): Call
5629         'gdbarch_stap_adjust_register'.
5630
5631 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5632
5633         PR python/24742
5634         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5635         * python/python.c (do_start_initialization): Use 'xmalloc'
5636         instead of 'PyMem_Malloc'.
5637
5638 2019-06-28  Tom Tromey  <tromey@adacore.com>
5639
5640         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5641         for Ada.
5642
5643 2019-06-27  Tom Tromey  <tromey@adacore.com>
5644
5645         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5646         objfile_key.
5647         (arm_find_mapping_symbol, arm_record_special_symbol)
5648         (_initialize_arm_tdep): Update.
5649         (arm_objfile_data_free): Remove.
5650
5651 2019-06-27  Tom Tromey  <tromey@adacore.com>
5652
5653         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5654         to cp_print_static_field.
5655
5656 2019-06-26  Tom Tromey  <tromey@adacore.com>
5657
5658         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5659         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5660         declare.
5661
5662 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5663
5664         * features/aarch64-core.c (create_feature_aarch64_core):
5665         Regenerate.
5666         * features/aarch64-core.xml: Add cpsr flags.
5667
5668 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5669
5670         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5671         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5672
5673 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5674
5675         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5676         field.
5677         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5678         use.
5679         (arm_record_special_symbol): Don't insert new symbol in sorted
5680         position, push it at the end.
5681
5682 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5683
5684         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5685         (arm_mapping_symbol_s): Remove.
5686         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5687         (arm_mapping_symbol_vec): New typedef.
5688         (struct arm_per_objfile): Add constructor.
5689         <section_maps>: Change type to
5690         std::unique_ptr<arm_mapping_symbol_vec[]>.
5691         (arm_compare_mapping_symbols): Remove.
5692         (arm_find_mapping_symbol): Adjust to section_maps type change.
5693         (arm_objfile_data_free): Call delete on arm_per_objfile.
5694         (arm_record_special_symbol): Adjust to section_maps type change.
5695         Allocate arm_per_objfile with new.
5696
5697 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5698
5699         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5700         with the command prefix.
5701
5702 2019-06-25  Tom Tromey  <tom@tromey.com>
5703
5704         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5705         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5706
5707 2019-06-25  Tom Tromey  <tom@tromey.com>
5708
5709         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5710         type.
5711         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5712         protected.
5713
5714 2019-06-25  Tom Tromey  <tom@tromey.com>
5715
5716         * tui/tui-winsource.c
5717         (tui_source_window_base::set_is_exec_point_at): Add check against
5718         LOA_ADDRESS.
5719
5720 2019-06-25  Tom Tromey  <tom@tromey.com>
5721
5722         * tui/tui-source.c (tui_set_source_content): Don't check before
5723         xfree.
5724         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5725
5726 2019-06-25  Tom Tromey  <tom@tromey.com>
5727
5728         * tui/tui-winsource.h (tui_update_source_window_as_is)
5729         (tui_alloc_source_buffer, tui_line_is_displayed)
5730         (tui_addr_is_displayed): Change type of win_info.
5731         * tui/tui-winsource.c (tui_update_source_window_as_is)
5732         (tui_clear_source_content, tui_show_source_line)
5733         (tui_show_source_content, tui_source_window_base::refill)
5734         (tui_source_window_base::set_is_exec_point_at)
5735         (tui_source_window_base::set_is_exec_point_at)
5736         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5737         (tui_alloc_source_buffer, tui_line_is_displayed)
5738         (tui_addr_is_displayed): Change type of win_info.  Update.
5739         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5740         (tui_source_window_base::do_make_visible_with_new_height):
5741         Update.
5742         * tui/tui-source.c (tui_set_source_content)
5743         (tui_set_source_content_nil)
5744         (tui_source_window::do_scroll_vertical): Update.
5745         * tui/tui-layout.c (show_layout): Update.
5746         * tui/tui-disasm.c (tui_set_disassem_content)
5747         (tui_disasm_window::do_scroll_vertical): Update.
5748         * tui/tui-data.h (tui_win_content): Remove.
5749         (struct tui_gen_win_info) <content, content_size>: Remove.
5750         (struct tui_source_element): Add initializers and destructor.
5751         (union tui_which_element, struct tui_win_element): Remove.
5752         (struct tui_source_window_base) <content>: New field.
5753         (struct tui_data_window): Remove destructor.
5754         (tui_alloc_content, tui_free_win_content)
5755         (tui_free_all_source_wins_content): Don't declare.
5756         * tui/tui-data.c (tui_initialize_static_data): Update.
5757         (init_content_element, tui_alloc_content): Remove.
5758         (~tui_gen_win_info): Update.
5759         (~tui_data_window, tui_free_all_source_wins_content)
5760         (tui_free_win_content, free_content, free_content_elements):
5761         Remove.
5762
5763 2019-06-25  Tom Tromey  <tom@tromey.com>
5764
5765         * tui/tui-winsource.h (tui_clear_source_content)
5766         (tui_erase_source_content, tui_show_source_content): Change type
5767         of win_info.
5768         * tui/tui-winsource.c (tui_clear_source_content)
5769         (tui_erase_source_content, tui_show_source_content): Change type
5770         of win_info.
5771         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5772         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5773         win_info.
5774         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5775         win_info.
5776         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5777
5778 2019-06-25  Tom Tromey  <tom@tromey.com>
5779
5780         * tui/tui-winsource.c (tui_clear_source_content)
5781         (tui_source_window_base::set_is_exec_point_at): Update.
5782         * tui/tui-source.c (tui_set_source_content_nil): Update.
5783         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5784         a bool.
5785         * tui/tui-data.c (init_content_element): Update.
5786
5787 2019-06-25  Tom Tromey  <tom@tromey.com>
5788
5789         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5790         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5791         * tui/tui-layout.c (init_and_make_win): Update.
5792         * tui/tui.h (enum tui_win_type): Update.
5793         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5794         tui_win_is_auxillary.
5795         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5796         tui_win_is_auxillary.
5797
5798 2019-06-25  Tom Tromey  <tom@tromey.com>
5799
5800         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5801         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5802         (tui_delete_data_content_windows, tui_display_all_data)
5803         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5804         Update.
5805         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5806         * tui/tui-regs.c (tui_last_regs_line_no)
5807         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5808         (tui_show_registers): Update.
5809         (tui_show_register_group): Return void.  Update.
5810         (tui_display_registers_from, tui_display_reg_element_at_line)
5811         (tui_display_registers_from_line, tui_check_register_values):
5812         Update.
5813         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5814         member.
5815         (struct tui_data_window) <regs_content>: Now a std::vector.
5816         <regs_content_count>: Remove.
5817         (tui_add_content_elements, tui_free_data_content): Don't declare.
5818         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5819         (init_content_element): Remove DATA_WIN case.  Add assert.
5820         (tui_add_content_elements): Remove.
5821         (tui_data_window): Update.
5822         (tui_free_data_content): Remove.
5823         (free_content_elements): Remove DATA_WIN case.
5824
5825 2019-06-25  Tom Tromey  <tom@tromey.com>
5826
5827         * tui/tui-data.c (tui_data_item_window): Update.
5828         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5829         * tui/tui-windata.c (tui_display_all_data)
5830         (tui_display_data_from_line): Update.
5831         (tui_check_data_values): Remove.
5832         * tui/tui-regs.c (tui_show_register_group)
5833         (tui_display_reg_element_at_line): Update.
5834         * tui/tui-hooks.c (tui_register_changed)
5835         (tui_refresh_frame_and_register_information): Call
5836         tui_check_register_values.
5837         * tui/tui-data.h (struct tui_data_window) <data_content,
5838         data_content_count, data_type>: Remove.
5839         (enum tui_data_type): Remove.
5840
5841         * tui/tui-data.c (tui_data_window::clear_detail)
5842         (~tui_data_window): Update.
5843
5844 2019-06-25  Tom Tromey  <tom@tromey.com>
5845
5846         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5847         declare.
5848         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5849         Rename from tui_first_data_item_displayed.  Update.
5850         (tui_data_window::refresh_all)
5851         (tui_data_window::do_scroll_vertical): Update.
5852         * tui/tui-data.h (struct tui_data_window)
5853         <first_data_item_displayed>: Declare new method.
5854
5855 2019-06-25  Tom Tromey  <tom@tromey.com>
5856
5857         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5858         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5859         contents...
5860         (tui_initialize_static_data): ...here.
5861
5862 2019-06-25  Tom Tromey  <tom@tromey.com>
5863
5864         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5865         (tui_display_registers_from, tui_check_register_values): Update.
5866         (tui_display_register): Remove win_info parameter; update.
5867         (tui_get_register): Change type of parameters.
5868         * tui/tui-data.h (struct tui_data_element): Remove.
5869         (union tui_which_element) <data>: Remove.
5870         <data_window>: Change type.
5871         (struct tui_data_item_window): New.
5872         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5873         case.  Add assert.
5874         (~tui_data_item_window): New destructor.
5875         (free_content_elements): Remove DATA_ITEM_WIN case.
5876
5877 2019-06-25  Tom Tromey  <tom@tromey.com>
5878
5879         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5880         Remove.
5881
5882 2019-06-25  Tom Tromey  <tom@tromey.com>
5883
5884         * tui/tui-data.h (struct tui_command_element): Remove.
5885         (union tui_which_element) <command>: Remove.
5886         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5887         assert.
5888         (free_content_elements): Remove CMD_WIN case.
5889
5890 2019-06-25  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-layout.c (tui_set_layout): Update.
5893         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5894         * tui/tui-data.c (layout_def): Update.
5895
5896 2019-06-25  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5899         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5900         (tui_source_window_base::set_new_height): Update.
5901         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5902         Update.
5903         (tui_set_locator_fullname, tui_set_locator_info)
5904         (tui_show_frame_info): Update.
5905         * tui/tui-source.c (tui_set_source_content)
5906         (tui_source_is_displayed): Update.
5907         * tui/tui-layout.c (show_source_disasm_command, show_data)
5908         (show_source_or_disasm_and_command): Update.
5909         * tui/tui-disasm.c (tui_set_disassem_content)
5910         (tui_get_begin_asm_address): Update.
5911         * tui/tui-data.h (struct tui_locator_element): Remove.
5912         (union tui_which_element) <locator>: Remove.
5913         (struct tui_locator_window): New.
5914         (tui_locator_win_info_ptr): Change return type.
5915         * tui/tui-data.c (_locator): Change type.
5916         (tui_locator_win_info_ptr): Change return type.
5917         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5918         (tui_alloc_content): Add assert.
5919
5920 2019-06-25  Tom Tromey  <tom@tromey.com>
5921
5922         * tui/tui-winsource.c
5923         (tui_exec_info_window::maybe_allocate_content): New method.
5924         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5925         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5926         (make_source_or_disasm_window): Add cast.
5927         * tui/tui-data.h (union tui_which_element) <simple_string>:
5928         Remove.
5929         (struct tui_source_info): New.
5930         (struct tui_source_window_base) <execution_info>: Change type.
5931         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5932         case, and add assert.
5933         (tui_alloc_content): Add assert.
5934
5935 2019-06-25  Tom Tromey  <tom@tromey.com>
5936
5937         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5938         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5939         * tui/tui-data.c (tui_alloc_win_info): Remove.
5940
5941 2019-06-25  Tom Tromey  <tom@tromey.com>
5942
5943         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5944         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5945         can_highlight.
5946
5947 2019-06-25  Tom Tromey  <tom@tromey.com>
5948
5949         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5950         make_visible_with_new_height method.
5951         (tui_win_info::make_visible_with_new_height): New method.
5952         (tui_source_window_base::do_make_visible_with_new_height)
5953         (tui_data_window::do_make_visible_with_new_height)
5954         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5955         (make_visible_with_new_height): Remove.
5956         (tui_resize_all, tui_adjust_win_heights): Use
5957         make_visible_with_new_height method.
5958         * tui/tui-data.h (struct tui_win_info)
5959         <do_make_visible_with_new_height, make_visible_with_new_height>:
5960         New methods.
5961         (struct tui_source_window_base, struct tui_data_window)
5962         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5963         methods.
5964
5965 2019-06-25  Tom Tromey  <tom@tromey.com>
5966
5967         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5968         method.
5969         (update_tab_width): Call update_tab_width method.
5970         * tui/tui-data.h (struct tui_win_info)
5971         (struct tui_source_window_base) <update_tab_width>: New methods.
5972
5973 2019-06-25  Tom Tromey  <tom@tromey.com>
5974
5975         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5976         parameter.
5977         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5978         parameter.
5979         (tui_gen_win_info::make_visible): Update.
5980         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5981         parameter.
5982         * tui/tui-data.h (enum tui_box): New enum.
5983         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5984
5985 2019-06-25  Tom Tromey  <tom@tromey.com>
5986
5987         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5988         init_and_make_win for EXEC_INFO_WIN.
5989         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5990         longer inline.
5991         (struct tui_win_info) <~tui_win_info>: Inline.
5992         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5993         Don't declare.
5994         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5995         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5996         Remove.
5997         (tui_initialize_static_data): Update.
5998         (~tui_gen_win_info): Handle more cleanup here.
5999         (~tui_source_window_base): Delete "execution_info".
6000         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6001
6002 2019-06-25  Tom Tromey  <tom@tromey.com>
6003
6004         * tui/tui-layout.c (make_command_window): Don't set
6005         can_highlight.
6006         (show_source_disasm_command): Call the reset method.
6007         (show_data): Don't set can_highlight.  Call the reset method.
6008         (tui_gen_win_info::reset): Rename from init_gen_win_info
6009         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6010         (show_source_or_disasm_and_command): Call the reset method.
6011         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6012         (struct tui_cmd_window): Set can_highlight.
6013
6014 2019-06-25  Tom Tromey  <tom@tromey.com>
6015
6016         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6017         from make_visible.
6018         (tui_make_visible, tui_make_invisible): Rewrite.
6019         (tui_win_info::make_visible): Remove.
6020         (tui_source_window_base::make_visible): Update.
6021         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6022         method.  Moved from...
6023         (struct tui_win_info) <make_visible>: ...here.
6024
6025 2019-06-25  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui-winsource.c
6028         (tui_source_window_base::do_scroll_horizontal): Remove direction
6029         parameter.
6030         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6031         direction parameter.
6032         * tui/tui-win.c (tui_win_info::forward_scroll)
6033         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6034         (tui_win_info::right_scroll): Update.
6035         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6036         direction parameter.
6037         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6038         direction parameter.
6039         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6040         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6041         Remove direction parameter.
6042         (struct tui_source_window_base, struct tui_source_window)
6043         (struct tui_disasm_window, struct tui_data_window)
6044         (struct tui_cmd_window): Update.
6045
6046 2019-06-25  Tom Tromey  <tom@tromey.com>
6047
6048         * tui/tui-winsource.h (tui_set_exec_info_content)
6049         (tui_show_exec_info_content, tui_erase_exec_info_content)
6050         (tui_clear_exec_info_content, tui_update_exec_info): Change
6051         argument to tui_source_window_base.
6052         * tui/tui-winsource.c (tui_set_exec_info_content)
6053         (tui_show_exec_info_content, tui_erase_exec_info_content)
6054         (tui_clear_exec_info_content, tui_update_exec_info): Change
6055         argument to tui_source_window_base.
6056
6057 2019-06-25  Tom Tromey  <tom@tromey.com>
6058
6059         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6060         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6061
6062 2019-06-25  Tom Tromey  <tom@tromey.com>
6063
6064         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6065         check.
6066
6067 2019-06-25  Tom Tromey  <tom@tromey.com>
6068
6069         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6070         type to void.
6071         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6072         type to void.
6073         * tui/tui-source.c (tui_set_source_content): Update.
6074         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6075
6076 2019-06-25  Tom Tromey  <tom@tromey.com>
6077
6078         * tui/tui-win.c (window_name_completer, tui_set_focus)
6079         (tui_all_windows_info): Use name method.
6080         * tui/tui-data.h (struct tui_gen_win_info)
6081         (struct tui_source_window, struct tui_disasm_window)
6082         (struct tui_data_window, struct tui_cmd_window) <name>: New
6083         method.
6084         (tui_win_name): Don't declare.
6085         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6086         (tui_win_name): Remove.
6087
6088 2019-06-25  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-winsource.h (tui_update_source_window)
6091         (tui_update_source_window_as_is): Change parameter type.
6092         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6093         to be a tui_source_window_base.
6094         (tui_update_source_window_as_is): Likewise.
6095         * tui/tui-win.c (make_visible_with_new_height): Update.
6096
6097 2019-06-25  Tom Tromey  <tom@tromey.com>
6098
6099         * tui/tui-winsource.c (tui_erase_source_content)
6100         (tui_show_source_content, tui_show_exec_info_content)
6101         (tui_erase_exec_info_content): Use refresh_window method.
6102         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6103         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6104         from tui_refresh_win.
6105         (tui_data_window::refresh_window): New method.
6106         (tui_win_info::refresh, tui_source_window_base::refresh)
6107         (tui_refresh_all): Use refresh_window method.
6108         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6109         method.
6110         * tui/tui-regs.c (tui_display_register): Call refresh_window
6111         method.
6112         * tui/tui-layout.c (show_source_disasm_command)
6113         (show_source_or_disasm_and_command): Call refresh_window method.
6114         * tui/tui-data.h (struct tui_gen_win_info)
6115         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6116         New method.
6117
6118 2019-06-25  Tom Tromey  <tom@tromey.com>
6119
6120         * tui/tui.c (tui_rl_other_window, tui_enable)
6121         (tui_is_window_visible, tui_get_command_dimension): Update.
6122         * tui/tui-winsource.c (tui_update_source_window_as_is)
6123         (tui_clear_source_content, tui_erase_source_content)
6124         (tui_show_source_line, tui_source_window_base::refill)
6125         (tui_source_window_base::do_scroll_horizontal)
6126         (tui_source_window_base::set_is_exec_point_at)
6127         (tui_update_breakpoint_info, tui_set_exec_info_content)
6128         (tui_alloc_source_buffer, tui_line_is_displayed)
6129         (tui_addr_is_displayed): Update.
6130         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6131         (tui_check_and_display_highlight_if_needed)
6132         (tui_win_info::make_visible, tui_win_info::refresh)
6133         (tui_refresh_all): Update.
6134         * tui/tui-windata.c (tui_first_data_item_displayed)
6135         (tui_delete_data_content_windows, tui_erase_data_content)
6136         (tui_display_all_data, tui_data_window::refresh_all)
6137         (tui_check_data_values): Update.
6138         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6139         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6140         (tui_win_info::backward_scroll, tui_refresh_all_win)
6141         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6142         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6143         (tui_source_window_base::set_new_height)
6144         (tui_data_window::set_new_height)
6145         (make_invisible_and_set_new_height)
6146         (make_visible_with_new_height, new_height_ok)
6147         (parse_scrolling_args): Update.
6148         * tui/tui-stack.c (tui_show_frame_info): Update.
6149         * tui/tui-source.c (tui_set_source_content)
6150         (tui_set_source_content_nil, tui_source_is_displayed)
6151         (tui_source_window::do_scroll_vertical): Update.
6152         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6153         (tui_display_registers_from, tui_display_reg_element_at_line)
6154         (tui_check_register_values, tui_reg_command): Update.
6155         * tui/tui-layout.c (tui_default_win_height)
6156         (show_source_disasm_command, show_data, init_and_make_win)
6157         (show_source_or_disasm_and_command): Update.
6158         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6159         (tui_redisplay_readline, tui_mld_flush)
6160         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6161         (tui_getc): Update.
6162         * tui/tui-disasm.c (tui_set_disassem_content)
6163         (tui_disasm_window::do_scroll_vertical): Update.
6164         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6165         Now virtual.
6166         (struct tui_win_info): Derive from tui_gen_win_info.
6167         <~tui_win_info>: Mark as override.
6168         <generic>: Remove member.
6169         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6170         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6171         (~tui_data_window, ~tui_win_info)
6172         (tui_free_all_source_wins_content): Update.
6173         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6174
6175 2019-06-25  Tom Tromey  <tom@tromey.com>
6176
6177         * tui/tui-layout.c (init_and_make_win): Use new.
6178         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6179         destructor, initializers.
6180         (tui_alloc_generic_win_info): Don't declare.
6181         * tui/tui-data.c (_locator): Add argument to constructor.
6182         (source_win, disasm_win): New globals.
6183         (exec_info): Remove.
6184         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6185         Update.
6186         (tui_alloc_generic_win_info): Remove.
6187         (init_content_element): Use new.
6188         (tui_win_info::tui_win_info): Update.
6189         (free_content_elements) <case DATA_WIN>: Use delete.
6190
6191 2019-06-25  Tom Tromey  <tom@tromey.com>
6192
6193         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6194         * tui/tui-windata.c (tui_first_data_item_displayed)
6195         (tui_delete_data_content_windows): Update.
6196         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6197         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6198         (tui_display_registers_from, tui_check_register_values): Update.
6199         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6200         pointer.
6201         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6202         window.
6203         (tui_free_data_content): Update.
6204         (free_content_elements) <case DATA_WIN>: Free the window.
6205
6206 2019-06-25  Tom Tromey  <tom@tromey.com>
6207
6208         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6209         Update.
6210         * tui/tui-layout.c (make_command_window)
6211         (show_source_disasm_command, show_data, init_and_make_win)
6212         (show_source_or_disasm_and_command): Update.
6213         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6214         method.
6215         <can_highight, is_highlighted>: Now bool.
6216         (tui_set_win_highlight): Don't declare.
6217         * tui/tui-data.c (tui_set_win_highlight): Remove.
6218
6219 2019-06-25  Tom Tromey  <tom@tromey.com>
6220
6221         * tui/tui-wingeneral.c (make_visible): Remove check of window
6222         type.
6223
6224 2019-06-25  Tom Tromey  <tom@tromey.com>
6225
6226         * tui/tui-win.c (tui_win_info::max_height)
6227         (tui_cmd_window::max_height): New methods.
6228         (new_height_ok): Call max_height.
6229         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6230         <max_height>: New method.
6231
6232 2019-06-25  Tom Tromey  <tom@tromey.com>
6233
6234         * tui/tui-win.c (tui_source_window_base::set_new_height)
6235         (tui_data_window::set_new_height): New methods.
6236         (make_invisible_and_set_new_height): Call set_new_height method.
6237         * tui/tui-data.h (struct tui_win_info)
6238         (struct tui_source_window_base, struct tui_data_window)
6239         <set_new_height>: New method.
6240
6241 2019-06-25  Tom Tromey  <tom@tromey.com>
6242
6243         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6244         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6245         tui_refresh_data_win.
6246         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6247         method.
6248         (tui_refresh_all_win): Call the refresh_all method.
6249         (tui_set_focus): Likewise.
6250         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6251         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6252         Likewise.
6253
6254 2019-06-25  Tom Tromey  <tom@tromey.com>
6255
6256         * tui/tui-winsource.h (tui_refill_source_window)
6257         (tui_set_is_exec_point_at): Don't declare.
6258         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6259         (tui_source_window_base::refill): Rename from
6260         tui_refill_source_window.
6261         (tui_source_window_base::do_scroll_horizontal): Update.
6262         (tui_source_window_base::set_is_exec_point_at): Rename from
6263         tui_set_is_exec_point_at.
6264         (tui_update_all_breakpoint_info): Update.
6265         * tui/tui-stack.c (tui_show_frame_info): Update.
6266         * tui/tui-layout.c (show_data): Add cast.
6267         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6268         * tui/tui-data.h (struct tui_source_window_base) <refill,
6269         set_is_exec_point_at>: New methods.
6270         (tui_source_windows, tui_add_to_source_windows): Update types.
6271         (tui_add_to_source_windows): Remove redundant declaration.
6272         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6273         (tui_source_windows): Change return type.
6274         (tui_clear_source_windows_detail): Update.
6275         (tui_add_to_source_windows): Change type of parameter.
6276         (tui_free_all_source_wins_content): Update.
6277
6278 2019-06-25  Tom Tromey  <tom@tromey.com>
6279
6280         * tui/tui-wingeneral.c (tui_win_info::refresh)
6281         (tui_source_window_base::refresh): New methods.
6282         (tui_refresh_all): Call the refresh method.
6283         * tui/tui-data.h (struct tui_win_info)
6284         (struct tui_source_window_base) <refresh>: New method.
6285
6286 2019-06-25  Tom Tromey  <tom@tromey.com>
6287
6288         * tui/tui.h (tui_is_window_visible): Return bool.
6289         * tui/tui.c (tui_is_window_visible): Return bool.
6290         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6291         (tui_make_visible, tui_make_invisible)
6292         (tui_win_info::make_visible)
6293         (tui_source_window_base::make_visible, make_all_visible)
6294         (tui_make_all_visible, tui_make_all_invisible): Update.
6295         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6296         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6297         bool.
6298         (struct tui_win_info, struct tui_source_window_base)
6299         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6300         * tui/tui-data.c (tui_init_generic_part): Update.
6301
6302 2019-06-25  Tom Tromey  <tom@tromey.com>
6303
6304         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6305         (tui_source_window_base::make_visible): New methods.
6306         (make_all_visible): Make method call.
6307         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6308         (struct tui_source_window_base, struct tui_cmd_window): Override
6309         make_visible.
6310         (tui_win_is_source_type): Don't declare.
6311         * tui/tui-data.c (tui_win_is_source_type): Remove.
6312
6313 2019-06-25  Tom Tromey  <tom@tromey.com>
6314
6315         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6316         NULL check.
6317
6318 2019-06-25  Tom Tromey  <tom@tromey.com>
6319
6320         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6321         Inline constructor.  Add initializers for members.
6322         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6323         constructors; now inline in class.
6324
6325 2019-06-25  Tom Tromey  <tom@tromey.com>
6326
6327         * tui/tui-regs.c (tui_show_registers): Update.
6328         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6329         bool.
6330         * tui/tui-data.c (tui_data_window::clear_detail)
6331         (tui_data_window): Update.
6332
6333 2019-06-25  Tom Tromey  <tom@tromey.com>
6334
6335         * tui/tui-windata.c (tui_display_all_data)
6336         (tui_display_data_from_line, tui_display_data_from)
6337         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6338         Update.
6339         * tui/tui-regs.c (tui_last_regs_line_no)
6340         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6341         (tui_show_registers, tui_show_register_group)
6342         (tui_display_registers_from, tui_display_reg_element_at_line)
6343         (tui_display_registers_from_line, tui_check_register_values)
6344         (tui_reg_next, tui_reg_prev): Update.
6345         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6346         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6347         tui_data_window.
6348         (struct tui_win_info) <detail>: Remove.  Add new fields from
6349         tui_data_info.
6350         (TUI_DATA_WIN): Add cast.
6351         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6352         (~tui_data_window): Simplify.
6353
6354 2019-06-25  Tom Tromey  <tom@tromey.com>
6355
6356         * tui/tui-layout.c (show_source_disasm_command)
6357         (show_source_or_disasm_and_command): Update.
6358         * tui/tui-io.c (update_cmdwin_start_line)
6359         (tui_redisplay_readline): Update.
6360         * tui/tui-data.h (struct tui_command_info): Remove.
6361         (struct tui_win_info) <detail>: Remove command_info member.
6362         (struct tui_data_window) <start_line>: New member, from
6363         tui_command_info.
6364         (TUI_CMD_WIN): Add casts.
6365
6366 2019-06-25  Tom Tromey  <tom@tromey.com>
6367
6368         * tui/tui-winsource.c (tui_update_source_window)
6369         (tui_refill_source_window)
6370         (tui_source_window_base::do_scroll_horizontal)
6371         (tui_update_breakpoint_info, tui_set_exec_info_content)
6372         (tui_show_exec_info_content, tui_erase_exec_info_content)
6373         (tui_clear_exec_info_content): Update.
6374         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6375         Update.
6376         * tui/tui-win.c (make_invisible_and_set_new_height)
6377         (make_visible_with_new_height): Update.
6378         * tui/tui-source.c (tui_set_source_content)
6379         (tui_show_symtab_source): Update.
6380         * tui/tui-layout.c (extract_display_start_addr)
6381         (show_source_disasm_command, show_data)
6382         (make_source_or_disasm_window)
6383         (show_source_or_disasm_and_command): Update.
6384         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6385         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6386         "gdbarch".
6387         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6388         to tui_source_window_base.
6389         (struct tui_win_info) <detail>: Remove source_info member.
6390         (struct tui_source_window_base) <has_locator>: Inline.
6391         Move contents from tui_source_info; rename has_locator member to
6392         m_has_locator.
6393         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6394         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6395         header file.
6396         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6397         Simplify.
6398         (tui_free_all_source_wins_content): Cast to
6399         tui_source_window_base.
6400
6401 2019-06-25  Tom Tromey  <tom@tromey.com>
6402
6403         * tui/tui-win.c (make_invisible_and_set_new_height)
6404         (make_visible_with_new_height): Call has_locator method.
6405         * tui/tui-layout.c (show_source_disasm_command, show_data)
6406         (show_source_or_disasm_and_command): Update for bool change.
6407         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6408         (tui_win_info) <has_locator>: New method.
6409         (struct tui_source_window_base) <has_locator>: New method.
6410         (tui_win_has_locator): Don't declare.
6411         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6412         from tui_win_has_locator.
6413         (tui_source_window_base): Use false, not FALSE.
6414
6415 2019-06-25  Tom Tromey  <tom@tromey.com>
6416
6417         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6418         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6419         clear_detail method directly.
6420         (tui_clear_win_detail): Remove.
6421
6422 2019-06-25  Tom Tromey  <tom@tromey.com>
6423
6424         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6425         "this", not TUI_DISASM_WIN.
6426
6427 2019-06-25  Tom Tromey  <tom@tromey.com>
6428
6429         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6430         declare.
6431         * tui/tui-winsource.c
6432         (tui_source_window_base::do_scroll_horizontal): Rename from
6433         tui_horizontal_source_scroll.
6434         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6435         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6436         from tui_vertical_data_scroll.
6437         * tui/tui-win.h (tui_scroll): Don't declare.
6438         * tui/tui-win.c (tui_win_info::forward_scroll)
6439         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6440         (tui_win_info::right_scroll): Rename and update.
6441         (tui_scroll_forward_command, tui_scroll_backward_command)
6442         (tui_scroll_left_command, tui_scroll_right_command): Update.
6443         (tui_scroll): Remove.
6444         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6445         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6446         from tui_vertical_source_scroll.
6447         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6448         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6449         from tui_vertical_disassem_scroll.
6450         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6451         do_scroll_horizontal>: New methods.
6452         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6453         Likewise.
6454         (struct tui_source_window_base): Add do_scroll_horizontal.
6455         (struct tui_source_window, struct tui_disasm_window): Add
6456         do_scroll_vertical.
6457         (struct tui_data_window, struct tui_cmd_window): Add
6458         do_scroll_horizontal and do_scroll_vertical.
6459         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6460
6461 2019-06-25  Tom Tromey  <tom@tromey.com>
6462
6463         * tui/tui-data.h (struct tui_source_window_base): New struct.
6464         (struct tui_source_window): Derive from tui_source_window_base.
6465         (struct tui_disasm_window): New struct.
6466         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6467         from tui_source_window::clear_detail.
6468         (tui_source_window_base): Rename from tui_source_window.
6469         (~tui_source_window_base): Rename from ~tui_source_window.
6470         (tui_alloc_win_info): Create a tui_disasm_window.
6471
6472 2019-06-25  Tom Tromey  <tom@tromey.com>
6473
6474         * tui/tui-data.h (struct tui_source_window)
6475         (struct tui_data_window): Declare destructors.
6476         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6477         destructors.
6478         (tui_win_info): Simplify.
6479
6480 2019-06-25  Tom Tromey  <tom@tromey.com>
6481
6482         * tui/tui-winsource.c (tui_display_main)
6483         (tui_update_source_windows_with_addr)
6484         (tui_update_all_breakpoint_info): Update.
6485         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6486         (new_height_ok, parse_scrolling_args): Update.
6487         * tui/tui-stack.c (tui_show_frame_info): Update.
6488         * tui/tui-data.h (struct tui_list): Remove.
6489         (tui_source_windows): Return a reference to a std::vector.
6490         * tui/tui-data.c (source_windows): Now a std::vector.
6491         (tui_source_windows): Change return type.
6492         (tui_clear_source_windows): Rewrite.
6493         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6494         (tui_free_all_source_wins_content): Rewrite.
6495
6496 2019-06-25  Tom Tromey  <tom@tromey.com>
6497
6498         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6499         (struct tui_data_window, struct tui_cmd_window): Declare
6500         clear_detail method.
6501         * tui/tui-data.c (tui_source_window::clear_detail)
6502         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6503         methods.
6504         (tui_clear_win_detail): Simplify.
6505
6506 2019-06-25  Tom Tromey  <tom@tromey.com>
6507
6508         * tui/tui-layout.c (make_source_window, make_disasm_window)
6509         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6510         Return the new window.
6511         (show_source_disasm_command, show_data)
6512         (show_source_or_disasm_and_command): Update.
6513
6514 2019-06-25  Tom Tromey  <tom@tromey.com>
6515
6516         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6517         parameter.  Return the new window.
6518         (show_source_disasm_command): Update and remove NULL check.
6519         (show_source_or_disasm_and_command): Update.
6520
6521 2019-06-25  Tom Tromey  <tom@tromey.com>
6522
6523         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6524
6525 2019-06-25  Tom Tromey  <tom@tromey.com>
6526
6527         * tui/tui-data.h (struct tui_win_info): Make constructor
6528         protected.  Make destructor virtual.  Add initializers.
6529         (tui_source_window, tui_data_window, tui_cmd_window): New
6530         classes.
6531         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6532         constructor.  Add "type" parameter.
6533         (tui_source_window, tui_data_window, tui_cmd_window): New
6534         constructors.
6535         (tui_alloc_win_info): Instantiate the appropriate subclass.
6536
6537 2019-06-25  Tom Tromey  <tom@tromey.com>
6538
6539         * tui/tui-win.c (tui_resize_all): Use delete.
6540         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6541         destructor.
6542         (tui_free_window): Don't declare.
6543         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6544         Update.
6545
6546 2019-06-25  Tom Tromey  <tom@tromey.com>
6547
6548         * tui/tui-data.h (struct tui_win_info): Add constructor.
6549         * tui/tui-data.c (tui_alloc_win_info): Use new.
6550         (tui_free_window): Use delete.
6551
6552 2019-06-22  Tom Tromey  <tom@tromey.com>
6553
6554         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6555         declare.
6556         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6557
6558 2019-06-22  Tom Tromey  <tom@tromey.com>
6559
6560         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6561         declare.
6562         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6563
6564 2019-06-22  Tom de Vries  <tdevries@suse.de>
6565
6566         * dwarf2read.c (create_addrmap_from_aranges)
6567         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6568         instead of '%zu'.
6569
6570 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6571
6572         * dwarf2read.h (dwarf2_section_info_def): Remove.
6573         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6574         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6575         std::vector<dwarf2_section_info>.
6576         (struct dwo_file) <~dwo_file>: Remove.
6577         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6578         types field.
6579         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6580         (dwarf2_read_debug_names): Likewise.
6581         (create_debug_types_hash_table): Change parameter type to
6582         array_view, adjust code accordingly.
6583         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6584         (partial_die_info::fixup): Likewise.
6585         (determine_prefix): Likewise.
6586         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6587
6588 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6589
6590         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6591         gdb_bfd_ref_ptr.
6592         <~dwo_file>: Remove call to gdb_bfd_unref.
6593         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6594         gdb_bfd_ref_ptr::get.
6595
6596 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6597
6598         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6599         type to htab_up.
6600         * dwarf2read.c (struct dwo_file): Initialize fields.
6601         <~dwo_file>: New.
6602         (free_dwo_file): Remove, move content to ~dwo_file.
6603         (struct dwo_file_deleter): Remove.
6604         (dwo_file_up>: Remove custom deleter.
6605         (free_dwo_files): Remove.
6606         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6607         dwo_files.
6608         (process_skeletonless_type_units): Call unique_ptr::get.
6609         (allocate_dwo_file_hash_table): Add deleter to created hash
6610         table.  Change return type to htab_up.
6611         (lookup_dwo_file_slot): Don't memset dwo_file, call
6612         unique_ptr::get.
6613         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6614         (create_dwo_unit_in_dwp_v2): Likewise.
6615         (open_and_init_dwo_file): Likewise.
6616         (free_dwo_file_from_slot): Remove.
6617
6618 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6619
6620         * dwarf2read.h (struct dwarf2_section_info) <readin,
6621         is_virtual>: Change type to bool.
6622         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6623         true instead of 1.
6624
6625 2019-06-19  Tom Tromey  <tom@tromey.com>
6626
6627         * tui/tui-data.h (tui_init_content_element): Don't declare.
6628
6629 2019-06-19  Tom Tromey  <tom@tromey.com>
6630
6631         * tui/tui-data.h (tui_init_win_info): Don't declare.
6632
6633 2019-06-19  Tom de Vries  <tdevries@suse.de>
6634
6635         * dwarf2read.h (abstract_to_concrete): Change type to
6636         std::unordered_map<sect_offset, std::vector<sect_offset>,
6637         gdb::hash_enum<sect_offset>>.
6638
6639 2019-06-19  Tom Tromey  <tromey@adacore.com>
6640
6641         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6642         EVAL_AVOID_SIDE_EFFECTS specially.
6643
6644 2019-06-19  Tom Tromey  <tromey@adacore.com>
6645
6646         * source-cache.c (highlighter): New global.
6647         (source_cache::get_source_lines): Create a highlighter on demand.
6648
6649 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6650
6651         * defs.h (deprecated_interactive_hook): Delete declaration.
6652         * interps.c (clear_interpreter_hooks): Remove use of
6653         deprecated_interactive_hook.
6654         * top.c (deprecated_interactive_hook): Delete definition.
6655         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6656
6657 2019-06-18  Tom de Vries  <tdevries@suse.de>
6658
6659         PR gdb/24515
6660         * dwarf2read.h (abstract_to_concrete): Change type from
6661         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6662         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6663         * dwarf2read.c (read_variable): Update.
6664         (dwarf2_fetch_die_loc_sect_off): Update.
6665
6666 2019-06-17  Tom de Vries  <tdevries@suse.de>
6667
6668         PR gdb/24617
6669         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6670         accessing parent[parent_len - 1].
6671
6672 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6673
6674         PR gdb/24364
6675         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6676         call dtrace_process_dof with NULL dof.
6677
6678 2019-06-16  Tom de Vries  <tdevries@suse.de>
6679
6680         PR gdb/24445
6681         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6682
6683 2019-06-16  Tom Tromey  <tom@tromey.com>
6684
6685         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6686         (make_all_visible): Use address of member.
6687
6688 2019-06-16  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6691         (tui_free_window, free_content, free_content_elements): Remove
6692         unnecessary cast.
6693         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6694         cast.
6695         * tui/tui-regs.c (tui_show_register_group)
6696         (tui_display_registers_from, tui_display_reg_element_at_line):
6697         Remove unnecessary cast.
6698
6699 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6700
6701         * linux-nat.c (normal_mask): Delete.
6702         (_initialize_linux_nat): Don't initialise normal_mask.
6703
6704 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6705
6706         PR gdb/24445
6707         * dwarf-index-write.h (write_psymtabs_to_index): Add
6708         dwz_basename parameter.
6709         * dwarf-index-write.c (write_gdbindex): Move file writing to
6710         write_gdbindex_1.  Change return type void.
6711         (assert_file_size): Move up, remove filename parameter.
6712         (write_gdbindex_1): New function.
6713         (write_debug_names): Change return type to void, call
6714         assert_file_size.
6715         (struct index_wip_file): New struct.
6716         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6717         file logic to index_wip_file.  Write index for dwz file if
6718         needed.
6719         (save_gdb_index_command): Pass basename of dwz file, if present.
6720         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6721         build-id of dwz file, if present.
6722         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6723         (dwarf2_get_dwz_file): Likewise.
6724         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6725         (dwarf2_get_dwz_file): Likewise.
6726
6727 2019-06-16  Tom Tromey  <tom@tromey.com>
6728
6729         * coffread.c (process_coff_symbol): Use xstrdup.
6730         * value.c (create_internalvar): Use xstrdup.
6731
6732 2019-06-16  Tom Tromey  <tom@tromey.com>
6733
6734         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6735         * breakpoint.c (stopin_command, stopat_command)
6736         (until_break_command, decode_location_default): Remove unnecessary
6737         cast.
6738         * utils.c (subset_compare): Remove unnecessary cast.
6739         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6740         cast.
6741         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6742         cast.
6743         * infcmd.c (path_command): Remove unnecessary cast.
6744         * coffread.c (decode_type): Remove unnecessary cast.
6745         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6746         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6747         * tui/tui-stack.c (tui_show_locator_content)
6748         (tui_show_frame_info): Remove unnecessary cast.
6749         * tui/tui-win.c (tui_scroll_forward_command)
6750         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6751         (parse_scrolling_args): Remove unnecessary cast.
6752         * tui/tui-data.c (init_win_info, tui_del_window)
6753         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6754         (free_content_elements): Remove unnecessary cast.
6755         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6756         unnecessary cast.
6757         * tui/tui-source.c (tui_set_source_content)
6758         (tui_vertical_source_scroll): Remove unnecessary cast.
6759         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6760         cast.
6761         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6762         * tui/tui-regs.c (tui_display_registers_from)
6763         (tui_display_register): Remove unnecessary cast.
6764         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6765         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6766         (make_visible): Remove unnecessary cast.
6767         * tui/tui-winsource.c (tui_erase_source_content)
6768         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6769         unnecessary cast.
6770         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6771         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6772         * stabsread.c (read_type, read_array_type, read_range_type):
6773         Remove unnecessary cast.
6774         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6775         (parse_symbol, parse_type, upgrade_type, parse_external)
6776         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6777         unnecessary cast.
6778         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6779
6780 2019-06-16  Tom Tromey  <tom@tromey.com>
6781
6782         * tui/tui-data.c (tui_alloc_generic_win_info)
6783         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6784         checks.
6785
6786 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6787             Andrew Burgess  <andrew.burgess@embecosm.com>
6788
6789         * f-typeprint.c (f_print_type): Don't return early for not
6790         associated or not allocated types.
6791         (f_type_print_varspec_suffix): Add print_rank parameter and print
6792         ranks of array types in case they dangling.
6793         (f_type_print_base): Add print_rank parameter.
6794
6795 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6796
6797         * NEWS: Mention new MI commands.
6798         * break-catch-throw.c (enum exception_event_kind): Move to
6799         breakpoint.h.
6800         (print_mention_exception_catchpoint): Output text as a single
6801         message.
6802         (catch_exception_command_1): Rename to...
6803         (catch_exception_event): ...this, make non-static, update header
6804         command, and change some parameter types.
6805         (catch_catch_command): Update for changes to
6806         catch_exception_command_1.
6807         (catch_throw_command): Likewise.
6808         (catch_rethrow_command): Likewise.
6809         * breakpoint.c (enum exception_event_kind): Delete.
6810         * breakpoint.h (enum exception_event_kind): Moved here from
6811         break-catch-throw.c.
6812         (catch_exception_event): Declare.
6813         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6814         (mi_cmd_catch_throw): New function.
6815         (mi_cmd_catch_rethrow): New function.
6816         (mi_cmd_catch_catch): New function.
6817         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6818         'catch-catch' entries.
6819         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6820         (mi_cmd_catch_rethrow): Declare.
6821         (mi_cmd_catch_catch): Declare.
6822
6823 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6824
6825         * annotate.c (annotate_source_line): Change return type to void,
6826         update implementation to match.
6827         * annotate.h (annotate_source_line): Change return type to void,
6828         update header comment.
6829         * stack.c (print_frame_info): Don't change what frame information
6830         is printed based on whether annotations are on or not.
6831
6832 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6833
6834         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6835         (annotate_source): Make static.
6836         (annotate_source_line): Moved from source.c and renamed from
6837         identify_source_line.  Update the return type.
6838         * annotate.h (annotate_source): Delete declaration.
6839         (annotate_source_line): Declaration moved from source.h, and
6840         renamed from identify_source_line.  Return type updated.
6841         * source.c (identify_source_line): Moved to annotate.c and renamed
6842         to annotate_source_line.
6843         (info_line_command): Remove check of annotation_level.
6844         * source.h (identify_source_line): Move declaration to annotate.h
6845         and rename to annotate_source_line.
6846         * stack.c: Add 'annotate.h' include.
6847         (print_frame_info): Remove check of annotation_level before
6848         calling annotate_source_line.
6849
6850 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6851
6852         * source-cache.c (source_cache::get_plain_source_lines): Use
6853         open_source_file_with_line_charpos instead of just
6854         open_source_file, remove call to find_source_lines.
6855         (source_cache::get_source_lines): Likewise.
6856         * source.c (find_source_lines): Make static.
6857         (get_filename_and_charpos): Renamed into...
6858         (open_source_file_with_line_charpos): ..this along with changes to
6859         return a scoped_fd, and some other minor clean ups.
6860         (identify_source_line): Use open_source_file_with_line_charpos.
6861         (search_command_helper): Use open_source_file_with_line_charpos
6862         instead of just open_source_file, remove call to
6863         find_source_lines.
6864         * source.h (open_source_file_with_line_charpos): Declare new
6865         function.
6866         (find_source_lines): Delete declaration.
6867
6868 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6869
6870         * source.c (get_filename_and_charpos): Remove fullname
6871         parameter.
6872         (identify_source_line): Update call to get_filename_and_charpos.
6873
6874 2019-06-14  Tom Tromey  <tromey@adacore.com>
6875
6876         PR gdb/24502:
6877         * ui-style.h (skip_ansi_escape): Update comment.
6878         * ui-file.h (class no_terminal_escape_file): New class.
6879         * ui-file.c (no_terminal_escape_file::write)
6880         (no_terminal_escape_file::puts): New methods.
6881         * cli/cli-logging.c (handle_redirections): Use
6882         no_terminal_escape_file.
6883
6884 2019-06-14  Tom Tromey  <tromey@adacore.com>
6885
6886         * NEWS: Move convenience variable news above Python news.
6887
6888 2019-06-14  Tom Tromey  <tom@tromey.com>
6889
6890         * gnulib: Move directory to top-level.
6891         * configure.ac: Don't configure gnulib.
6892         * configure: Rebuild.
6893         * common/common-defs.h: Use new path to gnulib.
6894         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6895         (GNULIB_H): Remove.
6896         (INCGNU): Look in new gnulib location.
6897         (HFILES_NO_SRCDIR): Remove gnulib files.
6898         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6899         (generated_files): Remove GNULIB_H.
6900         ($(LIBGNU), all-lib): Remove targets.
6901         (distclean): Don't mention GNULIB_BUILDDIR.
6902         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6903
6904 2019-06-14  Tom Tromey  <tromey@adacore.com>
6905
6906         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6907         Warn if symbol file does not provide any symbols.
6908
6909 2019-06-14  Tom Tromey  <tromey@adacore.com>
6910
6911         * source.c (find_and_open_source): Respect basenames_may_differ.
6912
6913 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6914
6915         * annotate.c (annotate_breakpoints_invalid): Make use of
6916         scoped_restore_terminal_state.
6917         (annotate_frames_invalid): Likewise.
6918
6919 2019-06-14  Tom Tromey  <tromey@adacore.com>
6920
6921         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6922         allow assignment to an internalvar.
6923
6924 2019-06-14  Tom Tromey  <tromey@adacore.com>
6925
6926         * ada-lex.l: Allow "_" in attribute names.
6927
6928 2019-06-14  Tom Tromey  <tromey@adacore.com>
6929
6930         PR gdb/24653:
6931         * regcache.c (registers_changed): Don't call alloca.
6932         * top.c (execute_command): Don't call alloca.
6933
6934 2019-06-13  Pedro Alves  <palves@redhat.com>
6935
6936         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6937         'expression'.  When parsing an expression, error out if there's
6938         junk after "unlimited".
6939         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6940         (do_set_command): Adjust calls to is_unlimited_literal.
6941
6942 2019-06-13  Pedro Alves  <palves@redhat.com>
6943
6944         * compile/compile.c (make_compile_options_def_group): Add braces
6945         around array_view initializer.
6946         * thread.c (make_thread_apply_all_options_def_group)
6947         (make_thread_apply_all_options_def_group): Likewise.
6948
6949 2019-06-13  Pedro Alves  <palves@redhat.com>
6950
6951         * NEWS (New commands): Mention "maint test-options
6952         require-delimiter", "maint test-options unknown-is-error", "maint
6953         test-options unknown-is-operand" and "maint show
6954         test-options-completion-result".
6955         (New command options, command completion): New section.
6956         (Completion improvements): New section.
6957         Mention that you can abbreviate "unlimited".
6958
6959 2019-06-13  Pedro Alves  <palves@redhat.com>
6960
6961         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6962         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6963         * unittests/cli-utils-selftests.c (test_parse_flags)
6964         (test_parse_flags_qcs): Delete.
6965         (test_cli_utils): Don't call deleted functions.
6966
6967 2019-06-13  Pedro Alves  <palves@redhat.com>
6968
6969         * thread.c: Include "cli/cli-option.h".
6970         (tp_array_compar_ascending): Global.
6971         (tp_array_compar): Delete function.
6972         (tp_array_compar_ascending, tp_array_compar_descending): New
6973         functions.
6974         (ascending_option_def, qcs_flag_option_def)
6975         (thr_qcs_flags_option_defs)
6976         (make_thread_apply_all_options_def_group)
6977         (make_thread_apply_options_def_group): New.
6978         (thread_apply_all_command): Use gdb::option::process_options.
6979         (thread_apply_command_completer)
6980         (thread_apply_all_command_completer): New.
6981         (thread_apply_command): Use gdb::option::process_options.
6982         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6983         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6984         to generate help text of "thread apply".  Adjust "taas"'s help.
6985         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6986         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6987
6988 2019-06-13  Pedro Alves  <palves@redhat.com>
6989
6990         * thread.c (thread_apply_command): Check for invalid TID with
6991         isdigit instead of !isalpha.
6992
6993 2019-06-13  Pedro Alves  <palves@redhat.com>
6994
6995         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6996         (validate_flags_qcs): New.
6997         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6998         (validate_flags_qcs): Declare.
6999         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7000         (make_frame_apply_options_def_group): New.
7001         (frame_apply_command_count): Process options with
7002         gdb::option::process_options.
7003         (frame_apply_completer): New.
7004         (frame_apply_level_completer, frame_apply_all_completer)
7005         (frame_apply_completer): New.
7006         (_initialize_stack): Update help of "frame apply", "frame apply
7007         level", "frame apply all" and "faas" to mention supported options
7008         and install command completers.
7009         * stack.h (frame_apply_all_completer): Declare.
7010         * thread.c: Include "stack.h".
7011         (tfaas_command): Add "--".
7012         (_initialize_thread): Update help "tfaas" to mention supported
7013         options and install command completer.
7014
7015 2019-06-13  Pedro Alves  <palves@redhat.com>
7016
7017         * completer.c (complete_nested_command_line): New.
7018         (gdb_completion_word_break_characters_throw): Add assertion.
7019         * completer.h (complete_nested_command_line): Declare.
7020
7021 2019-06-13  Pedro Alves  <palves@redhat.com>
7022
7023         * stack.c (parse_backtrace_qualifiers): New.
7024         (backtrace_command): Use it.
7025         (backtrace_command_completer): Complete on qualifiers.
7026
7027 2019-06-13  Pedro Alves  <palves@redhat.com>
7028
7029         * frame.c: Include "cli/cli-option.h.
7030         (user_set_backtrace_options): New.
7031         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7032         Delete.
7033         (get_prev_frame): Adjust.
7034         (boolean_option_def, uinteger_option_def)
7035         (set_backtrace_option_defs): New.
7036         (_initialize_frame): Adjust and use
7037         gdb::option::add_setshow_cmds_for_options to install "set
7038         backtrace past-main" and "set backtrace past-entry".
7039         * frame.h: Include "cli/cli-option.h".
7040         (struct frame_print_options): Forward declare.
7041         (print_frame_arguments_all, print_frame_arguments_scalars)
7042         (print_frame_arguments_none): Declare.
7043         (print_entry_values): Delete declaration.
7044         (struct frame_print_options, user_frame_print_options): New.
7045         (struct set_backtrace_options): New.
7046         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7047         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7048         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7049         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7050         (list_args_or_locals): Add frame_print_options parameter.
7051         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7052         * python/py-framefilter.c (enumerate_args): Pass down
7053         USER_FRAME_PRINT_OPTIONS.
7054         * stack.c: Include "cli/cli-option.h".
7055         (print_frame_arguments_all, print_frame_arguments_scalars)
7056         (print_frame_arguments_none): Declare.
7057         (print_raw_frame_arguments, print_entry_values): Delete.
7058         (user_frame_print_options): New.
7059         (boolean_option_def, enum_option_def, frame_print_option_defs):
7060         New.
7061         (struct backtrace_cmd_options): New.
7062         (bt_flag_option_def): New.
7063         (backtrace_command_option_defs): New.
7064         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7065         (print_frame_arg, read_frame_arg, print_frame_args)
7066         (print_frame_info, print_frame): Add frame_print_options parameter
7067         and use it.
7068         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7069         (backtrace_command_1): Add frame_print_options and
7070         backtrace_cmd_options parameters and use them.
7071         (make_backtrace_options_def_group): New.
7072         (backtrace_command): Process command options with
7073         gdb::option::process_options.
7074         (backtrace_command_completer): New.
7075         (_initialize_stack): Extend "backtrace"'s help to mention
7076         supported options.  Install completer for "backtrace".
7077         Install some settings commands with add_setshow_cmds_for_options.
7078
7079 2019-06-13  Pedro Alves  <palves@redhat.com>
7080
7081         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7082         and that "set/show print raw frame-arguments" are now deprecated.
7083
7084         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7085         command.
7086         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7087         * stack.c (_initialize_stack): Install "set/show print
7088         raw-frame-arguments", and deprecate "set/show print raw
7089         frame-arguments".
7090         * valprint.c (_initialize_valprint): Deprecate "set/show print
7091         raw".
7092
7093 2019-06-13  Pedro Alves  <palves@redhat.com>
7094
7095         * compile/compile.c (struct compile_options): New.
7096         (compile_flag_option_def, compile_command_option_defs)
7097         (make_compile_options_def_group): New.
7098         (compile_file_command): Handle options with
7099         gdb::option::process_options.
7100         (compile_file_command_completer): New function.
7101         (compile_code_command): Handle options with
7102         gdb::option::process_options.
7103         (compile_code_command_completer): New function.
7104         (_initialize_compiler): Install completers for "compile code" and
7105         "compile file".  Mention available options in "compile code" and
7106         "compile code"'s help.
7107         * completer.c (advance_to_completion_word): New, factored out from
7108         ...
7109         (advance_to_expression_complete_word_point): ... this.
7110         (advance_to_filename_complete_word_point): New.
7111         * completer.h (advance_to_filename_complete_word_point): New
7112         declaration.
7113
7114 2019-06-13  Pedro Alves  <palves@redhat.com>
7115
7116         * compile/compile.c: Include "cli/cli-option.h".
7117         (compile_print_value): Scope data pointer is now a
7118         value_print_options pointer; adjust.
7119         (compile_print_command): Process options.  Scope data pointer is
7120         now a value_print_options pointer; adjust.
7121         (_initialize_compile): Update "compile print"'s help to include
7122         supported options.  Install a completer for "compile print".
7123         * cp-valprint.c (show_vtblprint, show_objectprint)
7124         (show_static_field_print): Delete.
7125         (_initialize_cp_valprint): Don't install "set print
7126         static-members", "set print vtbl", "set print object" here.
7127         * printcmd.c: Include "cli/cli-option.h" and
7128         "common/gdb_optional.h".
7129         (print_command_parse_format): Rework to fill in a
7130         value_print_options instead of a format_data.
7131         (print_value): Change parameter type from format_data pointer to
7132         value_print_options reference.  Adjust.
7133         (print_command_1): Process options.  Adjust to pass down a
7134         value_print_options.
7135         (print_command_completer): New.
7136         (_initialize_printcmd): Install print_command_completer as
7137         handle_brkchars completer for the "print" command.  Update
7138         "print"'s help to include supported options.
7139         * valprint.c: Include "cli/cli-option.h".
7140         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7141         here from cp-valprint.c.
7142         (boolean_option_def, uinteger_option_def)
7143         (value_print_option_defs, make_value_print_options_def_group):
7144         New.  Use gdb::option::add_setshow_cmds_for_options to install
7145         "set print elements", "set print null-stop", "set print repeats",
7146         "set print pretty", "set print union", "set print array", "set
7147         print address", "set print symbol", "set print array-indexes".
7148         * valprint.h: Include <string> and "cli/cli-option.h".
7149         (make_value_print_options_def_group): Declare.
7150         (print_value): Change parameter type from format_data pointer to
7151         value_print_options reference.
7152         (print_command_completer): Declare.
7153
7154 2019-06-13  Pedro Alves  <palves@redhat.com>
7155
7156         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7157         (COMMON_SFILES): Add maint-test-settings.c.
7158         * cli/cli-decode.c (boolean_enums): New global, factored out from
7159         ...
7160         (add_setshow_boolean_cmd): ... here.
7161         * cli/cli-decode.h (boolean_enums): Declare.
7162         * cli/cli-option.c: New file.
7163         * cli/cli-option.h: New file.
7164         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7165         factored out from ...
7166         (parse_cli_boolean_value(const char *)): ... this.
7167         (is_unlimited_literal): Change parameter type to pointer to
7168         pointer.  Adjust and advance ARG pointer.
7169         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7170         (parse_cli_var_enum): New, factored out from ...
7171         (do_set_command): ... this.  Adjust.
7172         * cli/cli-setshow.h (parse_cli_boolean_value)
7173         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7174         (parse_cli_var_enum): Declare.
7175         * cli/cli-utils.c: Include "cli/cli-option.h".
7176         (get_ulongest): New.
7177         * cli/cli-utils.h (get_ulongest): Declare.
7178         (check_for_argument): New overloads.
7179         * maint-test-options.c: New file.
7180
7181 2019-06-13  Pedro Alves  <palves@redhat.com>
7182
7183         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7184         parse a range if "-" is at the end of the string.
7185
7186 2019-06-13  Pedro Alves  <palves@redhat.com>
7187
7188         * cli/cli-setshow.c (parse_auto_binary_operation)
7189         (parse_cli_boolean_value): Don't allow "o".
7190
7191 2019-06-13  Pedro Alves  <palves@redhat.com>
7192
7193         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7194         * NEWS: Mention maint test-settings KIND.
7195         * maint-test-settings.c: New file.
7196
7197 2019-06-13  Pedro Alves  <palves@redhat.com>
7198
7199         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7200         completer.
7201         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7202         "set" completers.
7203
7204 2019-06-13  Pedro Alves  <palves@redhat.com>
7205
7206         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7207         after item.
7208
7209 2019-06-13  Pedro Alves  <palves@redhat.com>
7210
7211         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7212
7213 2019-06-13  Pedro Alves <palves@redhat.com>
7214
7215         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7216         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7217         call.
7218         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7219         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7220         calls.
7221         (check_for_argument): Skip spaces after argument.
7222
7223 2019-06-13  Pedro Alves  <palves@redhat.com>
7224
7225         * thread.c (thread_apply_command): Adjust TID parsing.
7226         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7227         detected before end of string.
7228         (tid_is_in_list): Error out if LIST is invalid.
7229
7230 2019-06-13  Pedro Alves  <palves@redhat.com>
7231
7232         * completer.c (complete_line_internal_1): Rewind completion word
7233         point.
7234         (completion_tracker::advance_custom_word_point_by): Change
7235         parameter type to int.
7236         * completer.h (completion_tracker::advance_custom_word_point_by):
7237         Likewise.
7238
7239 2019-06-13  Pedro Alves  <palves@redhat.com>
7240
7241         * completer.c (advance_to_completion_word): Handle delimiters.
7242
7243 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7244
7245         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7246
7247 2019-06-11  Tom Tromey  <tom@tromey.com>
7248
7249         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7250         (xmalloc_failed): Move to alloc.c.
7251         * alloc.c: New file.
7252         * Makefile.in (COMMON_SFILES): Add alloc.c.
7253
7254 2019-06-11  Tom Tromey  <tom@tromey.com>
7255
7256         * nat/linux-waitpid.c: Don't include server.h.
7257         (linux_debug): Remove.
7258         (my_waitpid): Update.
7259
7260 2019-06-11  Tom Tromey  <tromey@adacore.com>
7261
7262         * infcall.c (_initialize_infcall): Remove trailing newline from
7263         help.
7264         * user-regs.c (_initialize_user_regs): Remove trailing newline
7265         from help.
7266         * typeprint.c (_initialize_typeprint): Remove trailing newline
7267         from help.
7268         * reverse.c (_initialize_reverse): Remove trailing newlines from
7269         help.
7270         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7271         from help.
7272         * language.c (add_set_language_command): Remove trailing newline
7273         from help.
7274         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7275         help.
7276         * disasm.c (_initialize_disasm): Remove trailing newline from
7277         help.
7278         * top.c (init_main): Remove trailing newline from help.
7279         * interps.c (_initialize_interpreter): Remove trailing newline
7280         from help.
7281         * btrace.c (_initialize_btrace): Remove trailing newlines from
7282         help.
7283         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7284         from help.
7285         * python/python.c (_initialize_python): Remove trailing newline
7286         from help.
7287         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7288         help.
7289         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7290         from help.  Reformat some text.
7291         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7292         from help.
7293         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7294         newline from help.
7295
7296 2019-06-11  Tom Tromey  <tromey@adacore.com>
7297
7298         * darwin-nat.c (darwin_decode_exception_message)
7299         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7300
7301 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7302
7303         * valops.c (value_slice): Check for not allocated or not
7304         associated values.
7305
7306 2019-06-10  Tom de Vries  <tdevries@suse.de>
7307
7308         PR gdb/24618
7309         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7310         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7311         invalid.
7312
7313 2019-06-10  Tom de Vries  <tdevries@suse.de>
7314
7315         PR gdb/24611
7316         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7317         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7318
7319 2019-06-10  Tom de Vries  <tdevries@suse.de>
7320
7321         PR symtab/24545
7322         * symtab.c (struct demangled_name_entry): Add language field.
7323         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7324         static minimal symbol".  Set and use language field.
7325
7326 2019-06-10  Tom Tromey  <tromey@adacore.com>
7327
7328         * ada-lang.c (_initialize_ada_language): Update help text.
7329
7330 2019-06-10  Tom Tromey  <tromey@adacore.com>
7331
7332         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7333         with a newline.
7334         * guile/guile.c (handle_boot_error): Don't end warning with a
7335         newline.
7336         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7337         warning with a newline.
7338         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7339         newline.
7340         (s12z_frame_cache): Likewise.
7341         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7342         a newline.
7343         * solib-svr4.c (disable_probes_interface): Don't end warning with
7344         a newline.
7345         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7346         newline.
7347         * python/python.c (do_finish_initialization): Don't end warning
7348         with a newline.
7349
7350 2019-06-10  Tom Tromey  <tom@tromey.com>
7351
7352         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7353         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7354         gdbpy_enter.
7355
7356 2019-06-10  Tom Tromey  <tromey@adacore.com>
7357
7358         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7359         data.
7360         (elf_new_init): Don't call stabsread_new_init.
7361         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7362         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7363         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7364
7365 2019-06-10  Tom de Vries  <tdevries@suse.de>
7366
7367         PR symtab/16264
7368         PR symtab/24517
7369         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7370
7371 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7372
7373         * source.c (find_and_open_source): Also rewrite relative file
7374         names.
7375
7376 2019-04-26  Amos Bird  <amosbird@gmail.com>
7377
7378         * annotate.c (annotate_thread_exited): Add "thread-exited"
7379         annotation.
7380
7381 2019-06-06  Tom Tromey  <tromey@adacore.com>
7382
7383         * maint.h (class scoped_command_stats): Use
7384         DISABLE_COPY_AND_ASSIGN.
7385         <print_time>: New method.
7386         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7387         print_time.
7388         (scoped_command_stats::print_time): New method.
7389
7390 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7391
7392         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7393         instructions of lengths 6 or 8 bytes.
7394
7395 2019-06-04  Pedro Alves  <palves@redhat.com>
7396
7397         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7398
7399         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7400         * breakpoint.c (condition_completer): Likewise.
7401         * cli/cli-dump.c (scan_expression): Likewise.
7402         * common/filestuff.c (mkdir_recursive): Likewise.
7403         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7404         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7405         (gdb_abspath): Likewise.
7406         * compile/compile-cplus-types.c
7407         (compile_cplus_instance::decl_name): Likewise.
7408         * completer.c (complete_explicit_location):
7409         (signal_completer, reg_or_group_completer_1): Likewise.
7410         * cp-support.c (cp_remove_params_if_any): Likewise.
7411         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7412         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7413         * infcmd.c (strip_bg_char): Likewise.
7414         * linespec.c (copy_token_string): Likewise.
7415         * mi/mi-main.c (output_cores): Likewise.
7416         * psymtab.c (psymtab_search_name):
7417         * symfile.c (test_set_ext_lang_command): Likewise.
7418         * target.c (target_fileio_read_stralloc): Likewise.
7419         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7420         * value.c (complete_internalvar): Likewise.
7421
7422 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7423
7424         Add objfile property to gdb.Type.
7425         * NEWS: Mention Python API addition.
7426         * python/py-type.c (typy_get_objfile): New method.
7427
7428 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7429
7430         * NEWS: Mention the new set|show style [title|highlight].
7431         Mention changes to "show style", "help" and "apropos".
7432
7433 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7434
7435         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7436         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7437         instead of print_help_for_command.
7438         (print_doc_of_command): New function.
7439         (help_list): Add 'apropos -v word' suggestion.
7440         (print_help_for_command): Style the command name using title style.
7441         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7442         (_initialize_cli_cmds): Describe -v in apropos_command help.
7443
7444 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7445
7446         * cli/cli-style.h (cli_style_option): Add name in constructor,
7447         add m_name class member, add constructor with intensity,
7448         add name class function.
7449         (cli_style_option::add_setshow_commands): Remove name argument.
7450         (highlight_style, title_style): New styles.
7451         * cli/cli-style.c (do_show): New function that shows a style
7452         characteristic styling the style name with itself.
7453         (set_style_name): New function.
7454         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7455         Update all callers according to the changes in cli/cli-style.h.
7456         * utils.h (fputs_highlighted): New function.
7457         * utils.c (fputs_highlighted): Likewise.
7458
7459 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7460
7461         * NEWS: Mention new pipe command and new convenience variables.
7462
7463 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7464
7465         * cli/cli-cmds.c (pipe_command): New function.
7466         (_initialize_cli_cmds): Call add_com for pipe_command.
7467         Define | as an alias for pipe.
7468         (exit_status_set_internal_vars): New function.
7469         (shell_escape): Call exit_status_set_internal_vars.
7470         cli/cli-decode.c (find_command_name_length): Recognize | as
7471         a single character command.
7472
7473 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7474
7475         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7476         top.c (execute_command_to_ui_file): New function, mostly a copy
7477         of execute_command_to_string.
7478         (execute_command_to_string): Implement by calling
7479         execute_command_to_ui_file.
7480
7481 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7482
7483         * top.h (saved_command_line): Remove declaration.
7484         * top.c (previous_saved_command_line, previous_repeat_arguments):
7485         New variables.
7486         (saved_command_line): Make static, define together with other
7487         'repeat variables'.
7488         (dont_repeat): Clear repeat_arguments.
7489         (repeat_previous, get_saved_command_line, save_command_line):
7490         New functions.
7491         (gdb_init): Initialize saved_command_line
7492         and previous_saved_command_line.
7493         * main.c (captured_main_1): Remove saved_command_line initialization.
7494         * event-top.c (handle_line_of_input): Update to use
7495         the new 'repeat' related functions instead of direct access to
7496         saved_command_line.
7497         * command.h (repeat_previous, get_saved_command_line,
7498         save_command_line): New declarations.
7499         (dont_repeat): Add comment.
7500
7501 2019-05-30  Tom Tromey  <tromey@adacore.com>
7502
7503         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7504         Fix comment.
7505         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7506
7507 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7508
7509         PR cli/24587
7510         * completer.c (complete): Initialize variable word.
7511
7512 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7513
7514         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7515         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7516         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7517         'body' is NULL to the outter 'if', protecting the '!is_define'
7518         situation as well.
7519
7520 2019-05-29  Tom Tromey  <tromey@adacore.com>
7521
7522         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7523         (dwarf_unknown): New function.
7524         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7525         (dwarf_type_encoding_name): Use dwarf_unknown.
7526
7527 2019-05-29  Tom Tromey  <tromey@adacore.com>
7528
7529         PR c++/20020:
7530         * cp-valprint.c (cp_print_value_fields): Call
7531         cp_print_static_field inside "try".
7532
7533 2019-05-29  Tom Tromey  <tromey@adacore.com>
7534
7535         * inflow.c (struct terminal_info): Add default operator=.
7536         * configure: Rebuild.
7537         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7538         -Wdeprecated-copy-dtor, -Wredundant-move.
7539
7540 2019-05-29  Tom Tromey  <tromey@adacore.com>
7541
7542         * NEWS: Add entry.
7543         * infcmd.c (print_return_value_1): Handle finish_print
7544         option.
7545         (show_print_finish): New function.
7546         (_initialize_infcmd): Add "set/show print finish" commands.
7547         * valprint.c (user_print_options): Initialize new member.
7548         * valprint.h (struct value_print_options) <finish_print>: New
7549         member.
7550
7551 2019-05-28  Tom Tromey  <tromey@adacore.com>
7552
7553         * ada-lang.c (ada_remove_Xbn_suffix)
7554         (find_old_style_renaming_symbol)
7555         (parse_old_style_renaming): Remove.
7556         (ada_find_renaming_symbol): Don't call
7557         find_old_style_renaming_symbol.
7558         (ada_is_renaming_symbol): Rename from
7559         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7560         bool.  Now static.
7561         (ada_read_var_value): Update and simplify.
7562         * ada-exp.y (write_var_or_type): Remove old code.
7563
7564 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7565
7566         PR gdb/25010
7567         * event-top.c: Remove include comment.
7568         * inflow.c (class scoped_ignore_sigttou): Move from here...
7569         * inflow.h (class scoped_ignore_sigttou): ...to here.
7570         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7571         * top.c:  Remove include comment.
7572
7573 2019-05-27  Tom Tromey  <tom@tromey.com>
7574
7575         * NEWS: Fix typo.
7576
7577 2019-05-22  Tom Tromey  <tromey@adacore.com>
7578
7579         * target.c (target_follow_exec): Constify parameter.
7580         * target-delegates.c: Rebuild.
7581         * remote.c (remote_target::follow_exec): Constify parameter.
7582         * infrun.c (follow_exec): Constify parameter.
7583         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7584         (target_follow_exec): Likewise.
7585
7586 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7587
7588         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7589         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7590
7591 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7592
7593         * NEWS: Add debugredirect and testsuite sections.
7594
7595 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7596
7597         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7598         target descriptions using exclusively floating point register name
7599         aliases.
7600
7601 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7602
7603         PR gdb/18644:
7604         * f-lang.c (build_fortran_types): Handle the case where
7605         gdbarch_floatformat_for_type returns a nullptr.
7606
7607 2019-05-21  Tom de Vries  <tdevries@suse.de>
7608
7609         PR cli/24587
7610         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7611
7612 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7613
7614         PR gdb/18644:
7615         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7616         16-byte floats.
7617         * i386-tdep.c (i386_floatformat_for_type): Use
7618         floatformats_ia64_quad for the 16-byte floating point component
7619         within a fortran 32-byte complex number.
7620
7621 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7622
7623         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7624         delete default constructor.
7625         (find_partial_die): Update to return const struct.
7626         (partial_die_parent_scope): Move variable declaration into scope
7627         of its use and change its type to auto.
7628         (guess_partial_die_structure_name): Likewise.
7629         (partial_die_info::fixup): Likewise.
7630
7631 2019-05-17  Tom Tromey  <tromey@adacore.com>
7632
7633         * source.c (find_and_open_source): Remove cast.
7634
7635 2019-05-17  Tom Tromey  <tromey@adacore.com>
7636
7637         * annotate.c (annotate_source): Make "filename" const.
7638         * annotate.h (annotate_source): Use const.
7639
7640 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7641
7642         * disasm.c (set_disassembler_options): Send errors to stderr.
7643
7644 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7645
7646         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7647         (cli_interp_base::set_logging): Check debug_redirect.
7648         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7649         * cli/cli-logging.c (debug_redirect): Add static variable.
7650         (pop_output_files): Add default param.
7651         (handle_redirections): Print debug setting.
7652         (show_logging_command): Likewise.
7653         (_initialize_cli_logging): Add debugredirect command.
7654         * interps.c (current_interp_set_logging): Add debug_redirect
7655         parameter.
7656         * interps.h (set_logging): Add debug_redirect parameter.
7657         (current_interp_set_logging): Likewise.
7658         * mi/mi-common.h: Likewise.
7659         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7660
7661 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7662             Tom Tromey  <tromey@adacore.com>
7663
7664         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7665         directly.
7666         * cli/cli-interp.h (make_logging_output): Remove declaration.
7667         * cli/cli-logging.c (make_logging_output): Remove function.
7668         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7669         directly.
7670         * ui-file.c (tee_file::tee_file): Remove bools.
7671         (tee_file::~tee_file): Remove deletes.
7672         * ui-file.h (tee_file): Remove bools.
7673
7674 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7675
7676         * mi/mi-cmds.h (mi_cmd_complete): New function.
7677         * mi/mi-main.c (mi_cmd_complete): Likewise.
7678         * mi/mi-cmds.c: Define new MI command -complete.
7679         * NEWS: Mention new -complete command.
7680
7681 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7682
7683         * completer.h (complete): New function.
7684         * completer.c (complete): Likewise.
7685         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7686         function defined in completer.h.
7687
7688 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7689
7690         * MAINTAINERS (Write After Approval): Add myself.
7691
7692 2019-05-17  Tom de Vries  <tdevries@suse.de>
7693
7694         PR gdb/24094
7695         * dwarf2read.c (struct cu_partial_die_info): New struct.
7696         (find_partial_die): Return cu_partial_die_info.
7697         (partial_die_parent_scope, guess_partial_die_structure_name)
7698         (partial_die_info::fixup): Handle new return type of find_partial_die.
7699
7700 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7701
7702         PR breakpoints/24541
7703         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7704         "std::string", simplifying the algorithm.
7705
7706 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7707
7708         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7709         (stap_static_probe_ops::get_probes): Likewise.
7710
7711 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7712
7713         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7714         '-')" and "else if".
7715         (stap_parse_single_operand): Join checks for
7716         "gdbarch_stap_parse_special_token_p" and
7717         "gdbarch_stap_parse_special_token" in the same "if" statement.
7718         Invert check when verifying for operation on register
7719         displacement.
7720
7721 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7722
7723         * stap-probe.c (stap_get_opcode): Update comment.
7724         (stap_get_expected_argument_type): Likewise.
7725         (handle_stap_probe): Likewise.
7726
7727 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7728
7729         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7730         return type to 'bool'.  Adjust comment.  Use 'bool' when
7731         appropriate.
7732         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7733         * stap-probe.c (stap_parse_argument_1): Likewise.
7734         (stap_is_operator): Likewise.
7735         (stap_is_generic_prefix): Likewise.
7736         (stap_is_register_prefix): Likewise.
7737         (stap_is_register_indirection_prefix): Likewise.
7738         (stap_is_integer_prefix): Likewise.
7739         (stap_generic_check_suffix): Likewise.
7740         (stap_check_integer_suffix): Likewise.
7741         (stap_check_register_suffix): Likewise.
7742         (stap_check_register_indirection_suffix): Likewise.
7743         (stap_parse_register_operand): Likewise.
7744         (stap_parse_single_operand): Likewise.
7745         (stap_parse_argument_1): Likewise.
7746         (stap_probe::get_argument_count): Likewise.
7747         (stap_is_operator): Likewise.
7748
7749 2019-05-16  Tom Tromey  <tromey@adacore.com>
7750
7751         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7752         keyword to foreach.
7753
7754 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7755
7756         * linux-thread-db.c (try_thread_db_load_1): Change return type
7757         to bool.
7758         (try_thread_db_load): Likewise.
7759         (try_thread_db_load_from_pdir_1): Likewise.
7760         (try_thread_db_load_from_pdir): Likewise.
7761         (try_thread_db_load_from_sdir): Likewise.
7762         (try_thread_db_load_from_dir): Likewise.
7763         (thread_db_load_search): Likewise.
7764         (has_libpthread): Likewise.
7765         (thread_db_load): Likewise.
7766
7767 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7768
7769         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7770         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7771         NULL, and complain/return if that's the case.
7772
7773 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7774
7775         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7776         (advance, posn, abstract_read_memory): New functions.
7777         [struct mem_read_abstraction]: New struct.
7778         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7779
7780 2019-05-14  Tom Tromey  <tromey@adacore.com>
7781
7782         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7783         value is not lval_memory.
7784
7785 2019-05-14  Tom Tromey  <tromey@adacore.com>
7786
7787         * solib.c (info_sharedlibrary_command): Style the file name.
7788
7789 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7790
7791         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7792         (aarch64_vnv_type): Likewise.
7793         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7794         * common/tdesc.c: Likewise.
7795         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7796         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7797         * features/aarch64-fpu.xml: Add ieee half view.
7798         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7799         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7800         * gdbtypes.h (struct builtin_type): Likewise.
7801         (struct objfile_type): Likewise.
7802
7803 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7804
7805         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7806         typo.
7807         * location.h (string_to_event_location): Likewise.
7808
7809 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7810
7811         GDB 8.3 released.
7812
7813 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7814
7815         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7816         New variable declaration.
7817         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7818         New variable.
7819         (print_one_breakpoint): Use ui_out::test_flags and new global
7820         variable to compute use_fixed_output.
7821         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7822         Remove.
7823         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7824         (mi_multi_location_breakpoint_output_fixed): Remove.
7825         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7826         new variable.
7827         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7828         fix_multi_location_breakpoint_output flag if version >= 3.
7829         * ui-out.h (enum ui_out_flag)
7830         <fix_multi_location_breakpoint_output>: New enumerator.
7831
7832 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7833
7834         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7835
7836 2019-05-10  Tom Tromey  <tromey@adacore.com>
7837
7838         * ada-lang.c (catch_ada_completer): New function.
7839         (_initialize_ada_language): Use it.
7840
7841 2019-05-10  Tom Tromey  <tromey@adacore.com>
7842
7843         * thread.c (print_thread_info): Make "requested_threads" const.
7844         * gdbthread.h (print_thread_info): Make "requested_threads"
7845         const.
7846         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7847         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7848
7849 2019-05-08  Tom Tromey  <tom@tromey.com>
7850
7851         * gdbtypes.c (objfile_type_data): Change type.
7852         (objfile_type, _initialize_gdbtypes): Update.
7853
7854 2019-05-08  Tom Tromey  <tom@tromey.com>
7855
7856         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7857         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7858         (_initialize_dwarf2_frame): Update.
7859
7860 2019-05-08  Tom Tromey  <tom@tromey.com>
7861
7862         * objc-lang.c (objc_objfile_data): Change type.
7863         (find_methods): Update.
7864         (_initialize_objc_lang): Remove.
7865
7866 2019-05-08  Tom Tromey  <tom@tromey.com>
7867
7868         * stabsread.c (rs6000_builtin_type_data): Change type.
7869         (rs6000_builtin_type, _initialize_stabsread): Update.
7870
7871 2019-05-08  Tom Tromey  <tom@tromey.com>
7872
7873         * mips-tdep.c (mips_pdr_data): Remove.
7874         (_initialize_mips_tdep): Update.
7875
7876 2019-05-08  Tom Tromey  <tom@tromey.com>
7877
7878         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7879         (hppa_init_objfile_priv_data, read_unwind_info)
7880         (find_unwind_entry, _initialize_hppa_tdep): Update.
7881
7882 2019-05-08  Tom Tromey  <tom@tromey.com>
7883
7884         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7885         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7886         on obstack.
7887         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7888
7889 2019-05-08  Tom Tromey  <tom@tromey.com>
7890
7891         * mdebugread.c (basic_type_data): Change type.
7892         (basic_type, _initialize_mdebugread): Update.
7893
7894 2019-05-08  Tom Tromey  <tom@tromey.com>
7895
7896         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7897
7898 2019-05-08  Tom Tromey  <tom@tromey.com>
7899
7900         * nto-tdep.c (nto_inferior_data_reg): Change type.
7901         (nto_inferior_data): Update.
7902         (nto_inferior_data_cleanup, nto_new_inferior_data)
7903         (_initialize_nto_tdep): Remove.
7904         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7905
7906 2019-05-08  Tom Tromey  <tom@tromey.com>
7907
7908         * ada-lang.c (struct ada_inferior_data): Add initializers.
7909         (ada_inferior_data): Change type.
7910         (ada_inferior_data_cleanup): Remove.
7911         (get_ada_inferior_data, ada_inferior_exit)
7912         (struct ada_pspace_data): Add initializers, destructor.
7913         (ada_pspace_data_handle): Change type.
7914         (get_ada_pspace_data): Update.
7915         (ada_pspace_data_cleanup): Remove.
7916
7917 2019-05-08  Tom Tromey  <tom@tromey.com>
7918
7919         * coffread.c (struct coff_symfile_info): Add initializers.
7920         (coff_objfile_data_key): Move lower.  Change type.
7921         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7922         Update.
7923         (coff_free_info): Remove.
7924
7925 2019-05-08  Tom Tromey  <tom@tromey.com>
7926
7927         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7928         (fbsd_pspace_data_handle): Move lower.  Change type.
7929         (get_fbsd_pspace_data): Update.
7930         (fbsd_pspace_data_cleanup): Remove.
7931         (_initialize_fbsd_tdep): Update.
7932
7933 2019-05-08  Tom Tromey  <tom@tromey.com>
7934
7935         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7936         (get_ada_tasks_pspace_data): Update.
7937         (ada_tasks_pspace_data_cleanup): Remove.
7938         (_initialize_tasks): Update.
7939         (ada_tasks_inferior_data_handle): Change type.
7940         (get_ada_tasks_inferior_data): Update.
7941         (ada_tasks_inferior_data_cleanup): Remove.
7942         (struct ada_tasks_pspace_data): Add initializers.
7943
7944 2019-05-08  Tom Tromey  <tom@tromey.com>
7945
7946         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7947         * symfile-debug.c (debug_sym_get_probes): Change type.
7948         * stap-probe.c (handle_stap_probe):
7949         (stap_static_probe_ops::get_probes): Change type.
7950         * probe.h (class static_probe_ops) <get_probes>: Change type.
7951         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7952         (parse_probes_in_pspace): Update.
7953         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7954         Update.
7955         (any_static_probe_ops::get_probes): Change type.
7956         * elfread.c (elfread_data): New typedef.
7957         (probe_key): Change type.
7958         (elf_get_probes): Likewise.  Update.
7959         (probe_key_free): Remove.
7960         (_initialize_elfread): Update.
7961         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7962         Change type.
7963         (dtrace_process_dof_probe, dtrace_process_dof)
7964         (dtrace_static_probe_ops::get_probe): Change type.
7965
7966 2019-05-08  Tom Tromey  <tom@tromey.com>
7967
7968         * xcoffread.c (struct xcoff_symfile_info): Rename from
7969         coff_symfile_info.  Add initializers.
7970         (xcoff_objfile_data_key): Move lower.  Change type.
7971         (XCOFF_DATA): Rewrite.
7972         (xcoff_free_info): Remove.
7973         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7974         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7975         (xcoff_initial_scan): Update.
7976
7977 2019-05-08  Tom Tromey  <tom@tromey.com>
7978
7979         * solib-svr4.c (struct svr4_info): Add initializers and
7980         destructor.
7981         <probes_table>: Now an htab_up.
7982         (solib_svr4_pspace_data): Change type.
7983         (free_probes_table): Simplify.
7984         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7985         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7986         (probes_table_remove_objfile_probes, register_solib_event_probe)
7987         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7988         (_initialize_svr4_solib): Update.
7989
7990 2019-05-08  Tom Tromey  <tom@tromey.com>
7991
7992         * remote.c (remote_pspace_data): Change type.
7993         (remote_pspace_data_cleanup): Remove.
7994         (get_remote_exec_file, set_pspace_remote_exec_file)
7995         (_initialize_remote): Update.
7996
7997 2019-05-08  Tom Tromey  <tom@tromey.com>
7998
7999         * breakpoint.c (breakpoint_objfile_key): Change type.
8000         (get_breakpoint_objfile_data): Update.
8001         (free_breakpoint_objfile_data): Remove.
8002         (_initialize_breakpoint): Update.
8003
8004 2019-05-08  Tom Tromey  <tom@tromey.com>
8005
8006         * linux-tdep.c (struct linux_info): Add initializers.
8007         (linux_inferior_data): Move.  Change type.
8008         (invalidate_linux_cache_inf): Update.
8009         (linux_inferior_data_cleanup): Remove.
8010         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8011
8012 2019-05-08  Tom Tromey  <tom@tromey.com>
8013
8014         * auxv.c (auxv_inferior_data): Move.  Change type.
8015         (auxv_inferior_data_cleanup): Remove.
8016         (invalidate_auxv_cache_inf): Rewrite.
8017         (get_auxv_inferior_data, _initialize_auxv): Update.
8018
8019 2019-05-08  Tom Tromey  <tom@tromey.com>
8020
8021         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8022         (symfile_debug_objfile_data_key): Change type.
8023         (symfile_debug_installed, debug_qf_has_symbols)
8024         (debug_qf_find_last_source_symtab)
8025         (debug_qf_forget_cached_source_info)
8026         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8027         (debug_qf_print_stats, debug_qf_dump)
8028         (debug_qf_expand_symtabs_for_function)
8029         (debug_qf_expand_all_symtabs)
8030         (debug_qf_expand_symtabs_with_fullname)
8031         (debug_qf_map_matching_symbols)
8032         (debug_qf_expand_symtabs_matching)
8033         (debug_qf_find_pc_sect_compunit_symtab)
8034         (debug_qf_map_symbol_filenames)
8035         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8036         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8037         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8038         (debug_sym_read_linetable, debug_sym_relocate): Update.
8039         (symfile_debug_free_objfile): Remove.
8040         (install_symfile_debug_logging, _initialize_symfile_debug):
8041         Update.
8042
8043 2019-05-08  Tom Tromey  <tom@tromey.com>
8044
8045         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8046         allocate_on_obstack.
8047         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8048         (get_dwarf2_per_objfile): Update.
8049         (set_dwarf2_per_objfile): Remove.
8050         (dwarf2_has_info, dwarf2_get_section_info): Update.
8051         (dwarf2_free_objfile): Remove.
8052         (_initialize_dwarf2_read): Update.
8053
8054 2019-05-08  Tom Tromey  <tom@tromey.com>
8055
8056         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8057         initializers.
8058         <unsupported_script_warning_printed,
8059         script_not_found_warning_printed>: Now bool.
8060         (auto_load_pspace_data): Change type.
8061         (~auto_load_pspace_info): Rename from
8062         auto_load_pspace_data_cleanup.
8063         (get_auto_load_pspace_data, init_loaded_scripts_info)
8064         (clear_section_scripts, maybe_print_unsupported_script_warning)
8065         (maybe_print_script_not_found_warning, _initialize_auto_load):
8066         Update.
8067
8068 2019-05-08  Tom Tromey  <tom@tromey.com>
8069
8070         * objfiles.c (objfile_pspace_info): Add destructor and
8071         initializers.
8072         (objfiles_pspace_data): Change type.
8073         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8074         (get_objfile_pspace_data): Update.
8075         (objfiles_bfd_data): Change type.
8076         (get_objfile_bfd_data): Update.
8077         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8078
8079 2019-05-08  Tom Tromey  <tom@tromey.com>
8080
8081         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8082         Change type.
8083         (get_catch_syscall_inferior_data): Update.
8084         (catch_syscall_inferior_data_cleanup): Remove.
8085         (_initialize_break_catch_syscall): Update.
8086
8087 2019-05-08  Tom Tromey  <tom@tromey.com>
8088
8089         * inflow.c (struct terminal_info): Add destructor and
8090         initializers.
8091         (inflow_inferior_data): Change type.
8092         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8093         (get_inflow_inferior_data, inflow_inferior_exit)
8094         (swap_terminal_info, _initialize_inflow): Update.
8095
8096 2019-05-08  Tom Tromey  <tom@tromey.com>
8097
8098         * target-dcache.c (target_dcache_cleanup): Remove.
8099         (target_dcache_aspace_key): Change type.
8100         (target_dcache_init_p, target_dcache_invalidate)
8101         (target_dcache_get, target_dcache_get_or_init)
8102         (_initialize_target_dcache): Update.
8103         * dcache.h (struct dcache_deleter): New.
8104
8105 2019-05-08  Tom Tromey  <tom@tromey.com>
8106
8107         * symtab.c (struct symbol_cache): Add destructor and
8108         initializers.
8109         (symbol_cache_key): Move.  Change type.
8110         (make_symbol_cache, free_symbol_cache): Remove.
8111         (get_symbol_cache): Update.
8112         (symbol_cache_cleanup): Remove.
8113         (ALL_PSPACES, symbol_cache_flush)
8114         (maintenance_print_symbol_cache)
8115         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8116         Update.
8117
8118 2019-05-08  Tom Tromey  <tom@tromey.com>
8119
8120         * symtab.c (struct main_info): Add destructor and initializers.
8121         (main_progspace_key): Move.  Change type.
8122         (get_main_info): Update.
8123         (main_info_cleanup): Remove.
8124         (_initialize_symtab): Update.
8125
8126 2019-05-08  Tom Tromey  <tom@tromey.com>
8127
8128         * registry.h (DECLARE_REGISTRY): Define the _key class.
8129
8130 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8131
8132         * NEWS: Merge two 'New commands' sections.
8133
8134 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8135
8136         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8137         parameter and use Ada language definition instead.
8138         (ada_val_print_ptr): Remove unused language parameter.
8139         (ada_val_print_num): Remove language parameter and use Ada language
8140         definition instead.
8141         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8142         parameter.
8143         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8144         parameter and use Ada language definition instead.
8145         (ada_val_print_1): Update all ada_val_print_xxx calls.
8146         Remove language parameter.
8147         (ada_val_print): Update ada_val_print_1 call.
8148
8149 2019-05-08  Tom Tromey  <tromey@adacore.com>
8150
8151         * remote.c (remote_hw_watchpoint_limit)
8152         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8153         Now static.
8154
8155 2019-05-08  Tom Tromey  <tromey@adacore.com>
8156
8157         * maint.c (_initialize_maint_cmds): Move initialization code to
8158         remote.c.
8159         (watchdog, show_watchdog): Move to remote.c.
8160         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8161         "watchdog" static.
8162         (_initialize_remote): Move initialization code from maint.c.
8163         * defs.h (watchdog): Don't declare.
8164
8165 2019-05-08  Tom Tromey  <tromey@adacore.com>
8166
8167         * tui/tui-interp.c: Include main.h.
8168         * interps.c: Include main.h.
8169         * main.h (interpreter_p): Declare.
8170         * defs.h (interpreter_p): Don't declare.
8171
8172 2019-05-08  Tom Tromey  <tromey@adacore.com>
8173
8174         * dwarf2loc.c: Include dwarf2read.h.
8175         * defs.h (read_unsigned_leb128): Don't declare.
8176         * dwarf2read.h (read_unsigned_leb128): Declare.
8177
8178 2019-05-08  Tom Tromey  <tromey@adacore.com>
8179
8180         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8181         method.
8182
8183 2019-05-08  Tom Tromey  <tromey@adacore.com>
8184
8185         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8186         when no wrap column is set.
8187
8188 2019-05-08  Tom Tromey  <tromey@adacore.com>
8189
8190         * c-lang.c (c_get_string): Handle non-C-style arrays.
8191
8192 2019-05-08  Tom Tromey  <tromey@adacore.com>
8193
8194         * typeprint.c (print_offset_data::update): Print the bit offset,
8195         not the number of bits remaining.
8196
8197 2019-05-08  Tom Tromey  <tromey@adacore.com>
8198
8199         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8200         padding at end of comment.
8201
8202 2019-05-08  Tom Tromey  <tromey@adacore.com>
8203
8204         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8205         Compare main types.
8206
8207 2019-05-06  Tom Tromey  <tom@tromey.com>
8208
8209         * common/scoped_mmap.c: Include common-defs.h.
8210         * common/scoped_mmap.h: Don't include config.h.
8211
8212 2019-05-04  Tom Tromey  <tom@tromey.com>
8213
8214         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8215         (struct aarch64_call_info): Add initializers.
8216         <si>: Now a std::vector.
8217         (pass_on_stack, aarch64_push_dummy_call): Update.
8218
8219 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8220             Tom Tromey  <tom@tromey.com>
8221
8222         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8223         (ppc_threads): Now a std::vector.  Now static.
8224         (hwdebug_find_thread_points_by_tid)
8225         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8226         Update.
8227
8228 2019-05-04  Tom Tromey  <tom@tromey.com>
8229
8230         * arc-tdep.c (arc_tdesc_init): Return bool.
8231
8232 2019-05-04  Tom Tromey  <tom@tromey.com>
8233
8234         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8235         Use gdb_assert_not_reached.
8236
8237 2019-05-04  Tom Tromey  <tom@tromey.com>
8238
8239         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8240         "false".
8241
8242 2019-05-04  Tom Tromey  <tom@tromey.com>
8243
8244         * arc-tdep.c (arc_tdesc_init): Use bool.
8245
8246 2019-05-04  Tom Tromey  <tom@tromey.com>
8247
8248         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8249
8250 2019-05-04  Tom Tromey  <tom@tromey.com>
8251
8252         * cli/cli-cmds.c (valid_command_p): Return bool.
8253
8254 2019-05-04  Tom Tromey  <tom@tromey.com>
8255
8256         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8257         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8258
8259 2019-05-04  Raul Tambre  <raul@tambre.ee>
8260
8261         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8262         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8263         operator for comparison.
8264
8265 2019-05-04  Tom Tromey  <tom@tromey.com>
8266
8267         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8268         (lookup_partial_symbol, print_partial_symbols)
8269         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8270         (psymbol_compare): Update.
8271         (add_psymbol_to_bcache): Clear the entire psymbol.
8272         (maintenance_check_psymtabs): Update.
8273         * psympriv.h (struct partial_symbol): Don't derive from
8274         general_symbol_info.
8275         <obj_section, unrelocated_address, address,
8276         set_unrelocated_address>: Update.
8277         <ginfo>: New member.
8278         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8279         (debug_names::write_psymbols): Update.
8280
8281 2019-05-04  Tom de Vries  <tdevries@suse.de>
8282
8283         * contrib/cc-with-tweaks.sh: Support -n arg.
8284
8285 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8286
8287         * corelow.c (core_target::detach): Ensure frame cache and
8288         register caches are cleared.
8289         inferior.c (exit_inferior_1): Likewise.
8290
8291 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8292             Tom Tromey  <tom@tromey.com>
8293
8294         * dictionary.c (collate_pending_symbols_by_language): Remove
8295         "struct" from foreach.
8296         * symtab.c (lookup_global_symbol_from_objfile)
8297         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8298         foreach.
8299         * ser-tcp.c (net_open): Remove "struct" from foreach.
8300         * objfiles.c (objfile_relocate, objfile_rebase)
8301         (objfile_has_symbols): Remove "struct" from foreach.
8302         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8303         from foreach.
8304         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8305         foreach.
8306         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8307         "struct" from foreach.
8308         * ada-lang.c (create_excep_cond_exprs)
8309         (ada_exception_catchpoint_cond_string): Remove "struct" from
8310         foreach.
8311
8312 2019-05-03  Tom Tromey  <tromey@adacore.com>
8313
8314         * ada-exp.y (convert_char_literal): Check suffix of each
8315         enumerator.
8316
8317 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8318
8319         PR ada/21406:
8320         * ada-exp.y (yywrap): Don't define.
8321         * ada-lex.l (%option): Add noyywrap
8322         (yywrap): Remove.
8323
8324 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8325
8326         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8327         _WIN32_WINNT to the XP level, unless already defined to a higher
8328         level.
8329
8330         * unittests/parse-connection-spec-selftests.c:
8331         * ser-tcp.c:
8332         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8333         override.
8334
8335         * symfile.c (find_separate_debug_file): Remove colon from the
8336         drive spec of DOS/Windows file names of the target, so that the
8337         file name produced from DEBUGDIR and the target's directory will
8338         be valid on DOS/Windows systems.
8339
8340 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8341
8342         * rust-lang.c (val_print_struct): Handle printing structures
8343         containing strings.
8344
8345 2019-05-02  Tom Tromey  <tromey@adacore.com>
8346
8347         * valarith.c (_initialize_valarith): Remove.
8348
8349 2019-05-01  Tom Tromey  <tromey@adacore.com>
8350
8351         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8352         bitfields.
8353
8354 2019-05-01  Tom Tromey  <tromey@adacore.com>
8355
8356         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8357         for big-endian copies.
8358
8359 2019-04-30  Ali Tamur  <tamur@google.com>
8360         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8361         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8362         (read_3_bytes): New function.
8363
8364 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8365
8366         * windows-nat.c (main_thread_id): Delete.
8367         (handle_output_debug_string): Replace main_thread_id by
8368         current_event.dwThreadId.
8369         (fake_create_process): Likewise.
8370         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8371         Do not set main_thread_id.
8372         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8373         current_event.dwThreadId.
8374         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8375
8376 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8377
8378         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8379         Use current_event.dwThreadId instead of main_thread_id.
8380
8381 2019-04-30  Tom Tromey  <tromey@adacore.com>
8382
8383         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8384         (create_excep_cond_exprs): Iterate over program spaces.
8385         (ada_exception_catchpoint_cond_string): Examine all minimal
8386         symbols for exception types.
8387
8388 2019-04-30  Tom Tromey  <tromey@adacore.com>
8389
8390         PR c++/24470:
8391         * dwarf2read.c (process_structure_scope): Handle case where type
8392         has template parameters but no symbol was created.
8393
8394 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8395             Chris January  <chris.january@arm.com>
8396
8397         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8398         qualifier.
8399         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8400
8401 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8402
8403         * f-typeprint.c (f_print_type): Update rules for printing
8404         whitespace.
8405         (f_type_print_varspec_suffix): Likewise.
8406
8407 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8408             Chris January  <chris.january@arm.com>
8409
8410         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8411         function arguments.
8412
8413 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8414
8415         * f-lang.c (build_fortran_types): Change name of void type to
8416         lower case.
8417         * f-typeprint.c (f_type_print_base): Print the name of the void
8418         type, rather than a fixed string.
8419         * f-valprint.c (f_decorations): Use lower case void string.
8420
8421 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8422             Chris January  <chris.january@arm.com>
8423
8424         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8425         types for Fortran.
8426
8427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8428             Chris January  <chris.january@arm.com>
8429             David Lecomber  <david.lecomber@arm.com>
8430
8431         * f-exp.y (BINOP_INTRINSIC): New token.
8432         (exp): New parser rule handling BINOP_INTRINSIC.
8433         (f77_keywords): Add new builtin procedures.
8434         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8435         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8436         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8437         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8438         (print_unop_subexp_f): New function.
8439         (print_binop_subexp_f): New function.
8440         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8441         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8442         (dump_subexp_body_f): Likewise.
8443         (operator_check_f): Likewise.
8444         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8445         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8446
8447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8448
8449         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8450         UNOP_KIND.
8451         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8452         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8453         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8454         (operator_length_f): New fuction.
8455         (print_subexp_f): New function.
8456         (op_name_f): New function.
8457         (dump_subexp_body_f): New function.
8458         (operator_check_f): New function.
8459         (exp_descriptor_f): Replace standard expression handling functions
8460         with new functions.
8461         * gdb/fortran-operator.def: New file.
8462         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8463         * gdb/std-operator.def: Remove UNOP_KIND.
8464
8465 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8466
8467         * std-operator.def: Remove unbalanced, stray double quote
8468         character.
8469
8470 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8471             Chris January  <chris.january@arm.com>
8472             Daniel Everett  <daniel.everett@arm.com>
8473             Nick Forrington  <nick.forrington@arm.com>
8474             Richard Bunt  <richard.bunt@arm.com>
8475
8476         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8477         of depth when printing anonymous structs or unions.
8478         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8479         Don't print either the top-level value, or the children if the
8480         max-depth is exceeded.
8481         (ppscm_print_children): When printing the key of a map, allow one
8482         extra level of depth.
8483         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8484         print either the top-level value, or the children if the max-depth
8485         is exceeded.
8486         (print_children): When printing the key of a map, allow one extra
8487         level of depth.
8488         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8489         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8490         (user_print_options): Initialise max_depth field.
8491         (val_print_scalar_or_string_type_p): New function.
8492         (val_print): Check to see if the max depth has been reached.
8493         (val_print_check_max_depth): Define new function.
8494         (show_print_max_depth): New function.
8495         (_initialize_valprint): Add 'print max-depth' option.
8496         * valprint.h (struct value_print_options) <max_depth>: New field.
8497         (val_print_check_max_depth): Declare new function.
8498         * NEWS: Document new feature.
8499
8500 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8501
8502         * ada-lang.c (ada_language_defn): Initialise new field.
8503         * c-lang.c (c_is_string_type_p): New function.
8504         (c_language_defn): Initialise new field.
8505         (cplus_language_defn): Initialise new field.
8506         (asm_language_defn): Initialise new field.
8507         (minimal_language_defn): Initialise new field.
8508         * c-lang.h (c_is_string_type_p): Declare new function.
8509         * d-lang.c (d_language_defn): Initialise new field.
8510         * f-lang.c (f_is_string_type_p): New function.
8511         (f_language_defn): Initialise new field.
8512         * go-lang.c (go_is_string_type_p): New function.
8513         (go_language_defn): Initialise new field.
8514         * language.c (default_is_string_type_p): New function.
8515         (unknown_language_defn): Initialise new field.
8516         (auto_language_defn): Initialise new field.
8517         * language.h (struct language_defn) <la_is_string_type_p>: New
8518         member variable.
8519         (default_is_string_type_p): Declare new function.
8520         * m2-lang.c (m2_language_defn): Initialise new field.
8521         * objc-lang.c (objc_language_defn): Initialise new field.
8522         * opencl-lang.c (opencl_language_defn): Initialise new field.
8523         * p-lang.c (pascal_is_string_type_p): New function.
8524         (pascal_language_defn): Initialise new field.
8525         * rust-lang.c (rust_is_string_type_p): New function.
8526         (rust_language_defn): Initialise new field.
8527
8528 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8529
8530         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8531         New field.
8532         * ada-lang.c (ada_language_defn): Initialise new field.
8533         * c-lang.c (c_language_defn): Likewise.
8534         (cplus_language_defn): Likewise.
8535         (asm_language_defn): Likewise.
8536         (minimal_language_defn): Likewise.
8537         * d-lang.c (d_language_defn): Likewise.
8538         * f-lang.c (f_language_defn): Likewise.
8539         * go-lang.c (go_language_defn): Likewise.
8540         * language.c (unknown_language_defn): Likewise.
8541         (auto_language_defn): Likewise.
8542         * m2-lang.c (m2_language_defn): Likewise.
8543         * objc-lang.c (objc_language_defn): Likewise.
8544         * opencl-lang.c (opencl_language_defn): Likewise.
8545         * p-lang.c (pascal_language_defn): Likewise.
8546         * rust-lang.c (rust_language_defn): Likewise.
8547
8548 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8549
8550         * ada-lang.c (ada_is_character_type): Change return type to bool.
8551         (ada_is_string_type): Likewise.
8552         * ada-lang.h (ada_is_character_type): Update declaration
8553         (ada_is_string_type): Likewise.
8554
8555 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8556
8557         Support style in 'frame|thread apply'
8558
8559         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8560         * record.c (record_start, record_stop): Update callers of
8561         execute_command_to_string with false.
8562         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8563         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8564         methods.
8565         (class string_file): New constructor with term_out parameter.
8566         Override methods term_out and can_emit_style_escape.  New member
8567         term_out.
8568         (class stdio_file): Override can_emit_style_escape.
8569         (class tee_file): Override term_out and can_emit_style_escape.
8570         * utils.h (can_emit_style_escape): Remove.
8571         * utils.c (can_emit_style_escape): Likewise.
8572         Update all callers of can_emit_style_escape (SOMESTREAM) to
8573         SOMESTREAM->can_emit_style_escape.
8574         * source-cache.c (source_cache::get_source_lines): Likewise.
8575         * stack.c (frame_apply_command_count): Call execute_command_to_string
8576         passing the term_out characteristic of the current gdb_stdout.
8577         * thread.c (thr_try_catch_cmd): Likewise.
8578         * top.c (execute_command_to_string): pass term_out parameter
8579         to construct the string_file for the command output.
8580         * ui-file.c (term_cli_styling): New function (most code moved
8581         from utils.c can_emit_style_escape).
8582         (string_file::string_file, string_file::can_emit_style_escape,
8583         stdio_file::can_emit_style_escape, tee_file::term_out,
8584         tee_file::can_emit_style_escape): New functions.
8585
8586 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8587
8588         * NEWS: Mention the new set|show may-call-functions.
8589         * infcall.c (may_call_functions_p): New variable.
8590         (show_may_call_functions_p): New function.
8591         (call_function_by_hand_dummy): Throws an error if not
8592         may-call-functions.
8593         (_initialize_infcall): Call add_setshow_boolean_cmd for
8594         may-call-functions.
8595
8596 2019-04-25  Keith Seitz  <keiths@redhat.com>
8597
8598         PR c++/24367
8599         * cp-support.c (inspect_type): Don't attempt substitutions
8600         of symbol with the same name.
8601
8602 2019-04-25  Tom Tromey  <tromey@adacore.com>
8603
8604         PR gdb/24475:
8605         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8606         static.
8607
8608 2019-04-25  Tom Tromey  <tromey@adacore.com>
8609
8610         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8611         rvalue reference.
8612         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8613         (gdb_xml_parser::parse): Use std::move.
8614         * python/python-internal.h (gdbpy_convert_exception): Take a const
8615         reference.
8616         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8617         std::move.
8618         * python/py-utils.c (gdbpy_convert_exception): Take a const
8619         reference.
8620         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8621         Use std::move.
8622         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8623         Use std::move.
8624         * mi/mi-main.c (mi_print_exception): Take a const reference.
8625         * main.c (handle_command_errors): Take a const reference.
8626         * linespec.c (parse_linespec): Use std::move.
8627         * infcall.c (run_inferior_call): Use std::move.
8628         (call_function_by_hand_dummy): Use std::move.
8629         * exec.c (try_open_exec_file): Use std::move.
8630         * exceptions.h (exception_print, exception_fprintf)
8631         (exception_print_same): Update.
8632         * exceptions.c (print_exception, exception_print)
8633         (exception_fprintf, exception_print_same): Change parameters to
8634         const reference.
8635         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8636         * common/new-op.c: Use std::move.
8637         * common/common-exceptions.h (struct gdb_exception): Add move
8638         constructor.
8639         (struct gdb_exception_error, struct gdb_exception_quit, struct
8640         gdb_quit_bad_alloc): Change constructor to move constructor.
8641         (throw_exception): Change parameter to rvalue reference.
8642         * common/common-exceptions.c (throw_exception): Take rvalue
8643         reference.
8644         * cli/cli-interp.c (safe_execute_command): Use std::move.
8645         * breakpoint.c (insert_bp_location, location_to_sals): Use
8646         std::move.
8647
8648 2019-04-25  Tom Tromey  <tromey@adacore.com>
8649
8650         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8651         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8652         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8653         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8654         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8655         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8656         guile/scm-value.c: Use unpack.
8657         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8658         gdbscm_gdb_exception.
8659         (gdbscm_throw_gdb_exception): Likewise.
8660         (struct gdbscm_gdb_exception): New.
8661         (unpack): New function.
8662         (gdbscm_wrap): Use unpack.
8663
8664 2019-04-25  Tom Tromey  <tromey@adacore.com>
8665
8666         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8667         (gdb_rl_callback_handler): Use std::move.
8668         * common/common-exceptions.h (struct gdb_exception): Add move
8669         assignment operator.
8670         (throw_exception_sjlj): Change "exception" to const reference.
8671         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8672         (throw_exception_sjlj): Change "exception" to const reference.
8673
8674 2019-04-25  Tom Tromey  <tromey@adacore.com>
8675
8676         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8677         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8678         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8679         Update.
8680         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8681         Update.
8682         * mi/mi-interp.c (mi_interp::exec): Update.
8683         * linespec.c (parse_linespec): Update.
8684         * infcall.c (run_inferior_call): Update.
8685         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8686         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8687         (gdbscm_lookup_global_symbol): Update.
8688         * guile/scm-param.c (gdbscm_parameter_value): Update.
8689         * guile/scm-frame.c (gdbscm_frame_read_register)
8690         (gdbscm_frame_read_var): Update.
8691         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8692         * exec.c (try_open_exec_file): Update.
8693         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8694         (gdb_rl_callback_handler): Update.
8695         * common/common-exceptions.h (exception_none): Don't declare.
8696         * common/common-exceptions.c (exception_none): Don't define.
8697         (struct catcher) <exception>: Update.
8698         * cli/cli-interp.c (safe_execute_command): Update.
8699         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8700
8701 2019-04-25  Ali Tamur  <tamur@google.com>
8702
8703         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8704         (read_attribute_value): Likewise.
8705         (dwarf2_read_addr_index): Update comment.
8706         (read_str_index): Add DW_FORM_strx.
8707         (dwarf2_string_attr): Likewise.
8708         (dwarf2_const_value_attr): Likewise.
8709         (dump_die_shallow): Likewise.
8710         (dwarf2_fetch_constant_bytes): Likewise.
8711         (skip_form_bytes): Likewise.
8712         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8713
8714 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8715
8716         PR corefiles/11608
8717         PR corefiles/18187
8718         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8719         OFFSET.  Verify if current mapping contains an ELF header.
8720         (linux_find_memory_regions_full): Adjust call to
8721         dump_mapping_p.
8722
8723 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8724             Kang Li <kanglictf@gmail.com>
8725
8726         PR gdb/21600
8727
8728         * dwarf2-frame.c (read_initial_length): Be consistent about using
8729         unsigned representation of length.
8730         (decode_frame_entry_1): Likewise.  Check for wraparound of
8731         end pointer as well as buffer overflow.
8732
8733 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8734
8735         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8736         "vq".
8737
8738 2019-04-24  Tom Tromey  <tromey@adacore.com>
8739
8740         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8741
8742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8743
8744         * s12z-tdep.c (s12z_unwind_pc): Delete.
8745         (s12z_unwind_sp): Delete.
8746         (s12z_gdbarch_init): Don't register deleted functions with
8747         gdbarch.
8748
8749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8750
8751         * rl78-tdep.c (rl78_unwind_sp): Delete.
8752         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8753
8754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8755
8756         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8757         (xstormy16_unwind_pc): Delete.
8758         (xstormy16_dummy_id): Delete.
8759         (xstormy16_gdbarch_init): Don't register deleted functions with
8760         gdbarch.
8761
8762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8763
8764         * vax-tdep.c (vax_unwind_pc): Delete.
8765         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8766
8767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8768
8769         * v850-tdep.c (v850_unwind_sp): Delete.
8770         (v850_unwind_pc): Delete.
8771         (v850_dummy_id): Delete.
8772         (v850_gdbarch_init): Don't register deleted functions with
8773         gdbarch.
8774
8775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8778         (tilegx_unwind_pc): Delete.
8779         (tilegx_unwind_dummy_id): Delete.
8780         (tilegx_gdbarch_init): Don't register deleted functions with
8781         gdbarch.
8782
8783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8784
8785         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8786         (tic6x_dummy_id): Delete.
8787         (tic6x_gdbarch_init): Don't register deleted functions with
8788         gdbarch.
8789
8790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8791
8792         * sparc-tdep.c (sparc_unwind_pc): Delete.
8793         (sparc32_gdbarch_init): Don't register deleted function with
8794         gdbarch.
8795
8796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8797
8798         * sh-tdep.c (sh_unwind_sp): Delete.
8799         (sh_unwind_pc): Delete.
8800         (sh_dummy_id): Delete.
8801         (sh_gdbarch_init): Don't register deleted functions with
8802         gdbarch.
8803
8804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8805
8806         * score-tdep.c (score_unwind_sp): Delete.
8807         (score_unwind_pc): Delete.
8808         (score_dummy_id): Delete.
8809         (score_gdbarch_init): Don't register deleted functions with
8810         gdbarch.
8811
8812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8813
8814         * rx-tdep.c (rx_unwind_pc): Delete.
8815         (rx_unwind_sp): Delete.
8816         (rx_dummy_id): Delete.
8817         (rx_gdbarch_init): Don't register deleted functions with
8818         gdbarch.  Update comment.
8819
8820 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8821
8822         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8823         (rs6000_dummy_id): Delete.
8824         (rs6000_gdbarch_init): Don't register deleted functions with
8825         gdbarch.
8826
8827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8828
8829         * or1k-tdep.c (or1k_dummy_id): Delete.
8830         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8831
8832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * nios2-tdep.c (nios2_dummy_id): Delete.
8835         (nios2_unwind_sp): Delete.
8836         (nios2_gdbarch_init): Don't register deleted functions with
8837         gdbarch.
8838
8839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8840
8841         * nds32-tdep.c (nds32_dummy_id): Delete.
8842         (nds32_unwind_pc): Delete.
8843         (nds32_unwind_sp): Delete.
8844         (nds32_gdbarch_init): Don't register deleted functions with
8845         gdbarch.
8846
8847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8848
8849         * msp430-tdep.c (msp430_unwind_pc): Delete.
8850         (msp430_unwind_sp): Delete.
8851         (msp430_dummy_id): Delete.
8852         (msp430_gdbarch_init): Don't register deleted functions with
8853         gdbarch.
8854
8855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8856
8857         * moxie-tdep.c (moxie_unwind_sp): Delete.
8858         (moxie_unwind_pc): Delete.
8859         (moxie_dummy_id): Delete.
8860         (moxie_gdbarch_init): Don't register deleted functions with
8861         gdbarch.
8862
8863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8864
8865         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8866         (mn10300_unwind_pc): Delete.
8867         (mn10300_unwind_sp): Delete.
8868         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8869         mn10300_unwind_sp.
8870         (mn10300_frame_unwind_init): Don't register deleted functions with
8871         gdbarch.
8872
8873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8874
8875         * mep-tdep.c (mep_unwind_pc): Delete.
8876         (mep_unwind_sp): Delete.
8877         (mep_dummy_id): Delete.
8878         (mep_gdbarch_init): Don't register deleted functions with
8879         gdbarch.
8880
8881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8884         (m68hc11_unwind_sp): Delete.
8885         (m68hc11_gdbarch_init): Don't register deleted functions with
8886         gdbarch.
8887
8888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8889
8890         * m32r-tdep.c (m32r_unwind_sp): Delete.
8891         (m32r_unwind_pc): Delete.
8892         (m32r_dummy_id): Delete.
8893         (m32r_gdbarch_init): Don't register deleted functions with
8894         gdbarch.
8895
8896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8897
8898         * m32c-tdep.c (m32c_unwind_pc): Delete.
8899         (m32c_unwind_sp): Delete.
8900         (m32c_dummy_id): Delete.
8901         (m32c_gdbarch_init): Don't register deleted functions with
8902         gdbarch.
8903
8904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8905
8906         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8907         (lm32_unwind_pc): Delete.
8908         (lm32_dummy_id): Delete.
8909         (lm32_gdbarch_init): Don't register deleted functions with
8910         gdbarch.
8911
8912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8915         (iq2000_unwind_pc): Delete.
8916         (iq2000_dummy_id): Delete.
8917         (iq2000_gdbarch_init): Don't register deleted functions with
8918         gdbarch.
8919
8920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8921
8922         * nds32-tdep.c (nds32_type_align): Delete.
8923         (nds32_push_dummy_call): Use type_align instead.
8924
8925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8926
8927         * arm-tdep.c (arm_type_align): Only handle vector override case.
8928         (arm_push_dummy_call): Use type_align.
8929         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8930
8931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8932
8933         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8934         case.
8935         (pass_on_stack): Use type_align.
8936         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8937         function.
8938
8939 2019-04-23  Tom Tromey  <tromey@adacore.com>
8940
8941         * dwarf2read.c (line_header::file_name_at): Remove unused
8942         overload.
8943
8944 2019-04-23  Tom de Vries  <tdevries@suse.de>
8945
8946         PR gdb/24438
8947         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8948         invocation.
8949
8950
8951 2019-03-27  Ali Tamur  <tamur@google.com>
8952
8953         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8954         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8955         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8956         (dwarf_expr_context::get_addr_index): Likewise
8957         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8958         (symbol_needs_eval_context::get_addr_index): Likewise
8959         (disassemble_dwarf_expression): Add DW_OP_addrx
8960         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8961         (read_cutu_die_from_dwo): Update comment
8962         (skip_one_die): Add DW_FORM_addrx
8963         (read_attribute_value): Likewise
8964         (var_decode_location): Add DW_OP_addrx
8965         (dwarf2_const_value_attr): Add DW_FORM_addrx
8966         (dump_die_shallow): Likewise
8967         (dwarf2_fetch_constant_bytes): Likewise
8968         (decode_locdesc): Add DW_OP_addrx
8969         (skip_form_bytes): Add DW_FORM_addrx
8970
8971 2019-04-22  Ali Tamur  <tamur@google.com>
8972
8973         * MAINTAINERS (Write After Approval): Add self.
8974
8975 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8976
8977         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8978         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8979         (open_symbol_file_object): Likewise.
8980         (svr4_default_sos): Add info parameter.
8981         (svr4_read_so_list): Likewise.
8982         (svr4_current_sos_direct): Adjust functions calls to pass down
8983         info.
8984         (svr4_current_sos_1): Add info parameter.
8985         (svr4_current_sos): Call get_svr4_info, pass info down to
8986         svr4_current_sos_1.
8987         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8988         get_svr4_info.
8989         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8990         get_svr4_info.
8991         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8992         to get_svr4_info.
8993         (probes_table_remove_objfile_probes): Likewise.
8994         (register_solib_event_probe): Add info parameter.
8995         (solist_update_incremental): Pass info parameter down to
8996         svr4_read_so_list.
8997         (disable_probes_interface): Add info parameter.
8998         (svr4_handle_solib_event): Pass current_program_space to
8999         get_svr4_info.  Adjust disable_probes_interface cleanup.
9000         (svr4_create_probe_breakpoints): Add info parameter, pass it
9001         down to register_solib_event_probe.
9002         (svr4_create_solib_event_breakpoints): Add info parameter,
9003         pass it down to svr4_create_probe_breakpoints.
9004         (enable_break): Pass info down to
9005         svr4_create_solib_event_breakpoints.
9006         (svr4_solib_create_inferior_hook): Pass current_program_space to
9007         get_svr4_info.
9008         (svr4_clear_solib): Likewise.
9009
9010 2019-04-22  Pedro Alves  <palves@redhat.com>
9011
9012         * solib-svr4.c (svr4_free_objfile_observer): New.
9013         (probe_and_action::objfile): New field.
9014         (probes_table_htab_remove_objfile_probes)
9015         (probes_table_remove_objfile_probes): New functions.
9016         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9017         in the new probe_and_action.  Don't store the probe in 'lookup'.
9018         (svr4_create_probe_breakpoints): Pass objfile to
9019         register_solib_event_probe.
9020         (_initialize_svr4_solib): Register a free_objfile observer.
9021
9022 2019-04-19  Tom Tromey  <tom@tromey.com>
9023
9024         * common/queue.h: Remove.
9025
9026 2019-04-19  Tom Tromey  <tom@tromey.com>
9027
9028         * event-loop.c: Don't include "common/queue.h".
9029
9030 2019-04-19  Tom Tromey  <tom@tromey.com>
9031
9032         * remote.c (remote_target): Use delete.
9033         * remote-notif.h: Include <list>, not "common/queue.h".
9034         (notif_client_p): Remove typedef.
9035         (remote_notif_state): Add constructor, destructor, initializer.
9036         <notif_queue>: Now a std::list.
9037         (remote_notif_state_xfree): Don't declare.
9038         * remote-notif.c (remote_notif_process, handle_notification)
9039         (remote_notif_state_allocate): Update.
9040         (~remote_notif_state): Rename from remote_notif_state_xfree.
9041
9042 2019-04-19  Tom Tromey  <tom@tromey.com>
9043
9044         * symfile.c (reread_symbols): Update.
9045         * objfiles.c (objfile_register_static_link)
9046         (objfile_lookup_static_link): Update
9047         (~objfile) Don't delete static_links.
9048         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9049
9050 2019-04-19  Tom Tromey  <tom@tromey.com>
9051
9052         * type-stack.h (struct type_stack) <insert>: Constify string.
9053         * type-stack.c (type_stack::insert): Constify string.
9054         * gdbtypes.h (lookup_template_type): Update.
9055         (address_space_name_to_int): Update.
9056         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9057         const.
9058         (lookup_template_type): Make name const.
9059         * c-exp.y: Update rules.
9060         (lex_one_token, classify_name, classify_inner_name)
9061         (c_print_token): Update.
9062         * p-exp.y: Update rules.
9063         (yylex): Update.
9064         * f-exp.y: Update rules.
9065         (yylex): Update.
9066         * d-exp.y: Update rules.
9067         (lex_one_token, classify_name, classify_inner_name): Update.
9068         * parse.c (write_dollar_variable, copy_name): Return std::string.
9069         * parser-defs.h (copy_name): Change return type.
9070         * m2-exp.y: Update rules.
9071         (yylex): Update.
9072         * go-exp.y (lex_one_token): Update.
9073         Update rules.
9074         (classify_unsafe_function, classify_packaged_name)
9075         (classify_name, yylex): Update.
9076
9077 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9078
9079         * configure.ac: add --enable-source-highlight switch.
9080         * configure: Regenerate.
9081         * top.c (print_gdb_version): plumb --enable-source-highlight
9082         status to "show configuration".
9083
9084 2019-04-19  Tom Tromey  <tromey@adacore.com>
9085
9086         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9087         Check ADA_TYPE_P.
9088         (empty_record, ada_template_to_fixed_record_type_1)
9089         (template_to_static_fixed_type)
9090         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9091         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9092         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9093         macros.
9094
9095 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9096
9097         PR symtab/24423:
9098         * source.c (print_source_lines_base): Advance "iter" when a
9099         control character is seen.
9100
9101 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9102
9103         * inferior.h (struct infcall_suspend_state_deleter):
9104         Catch exception in destructor to avoid crash.
9105
9106 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9107
9108         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9109         close to the add_com "shell".
9110
9111 2019-04-18  Tom Tromey  <tromey@adacore.com>
9112
9113         * process-stratum-target.h (class process_stratum_target)
9114         <stratum>: Add "final".
9115
9116 2019-04-17  Tom Tromey  <tromey@adacore.com>
9117
9118         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9119         against nullptr before use.
9120
9121 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9122
9123         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9124
9125 2019-04-17  Jim Wilson  <jimw@sifive.com>
9126             Andrew Burgess  <andrew.burgess@embecosm.com>
9127
9128         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9129         code read might fail, assume 4-byte breakpoint in that case.
9130
9131 2019-04-15  Leszek Swirski  <leszeks@google.com>
9132
9133         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9134         rather than a hand-rolled POD check when checking for forced MEMORY
9135         classification.
9136
9137 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9138
9139         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9140         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9141         function.
9142         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9143         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9144         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9145         declaration.
9146
9147 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9148
9149         * aarch64-linux-nat.c
9150         (aarch64_linux_nat_target::thread_architecture): Add override.
9151         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9152         each VQ.
9153
9154 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9155
9156         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9157
9158 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9159
9160         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9161         target types of size 96-bits, add some additional comments, and
9162         check that the builtin type we found was the correct size.
9163
9164 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9165
9166         * utils.c (prompt_for_continue): Don't restore the styling at the
9167         end, as applied_style has the wrong value.  This fixes styling in
9168         long lists of file names that are interrupted by the "Continue?"
9169         prompt.
9170
9171 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9172
9173         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9174         * c-lang.c (c_language_defn): Likewise.
9175         (cplus_language_defn): Likewise.
9176         (asm_language_defn): Likewise.
9177         (minimal_language_defn): Likewise.
9178         * d-lang.c (d_language_defn): Likewise.
9179         * f-lang.c (f_language_defn): Likewise.
9180         * go-lang.c (go_language_defn): Likewise.
9181         * language.c (unknown_language_defn): Likewise.
9182         (auto_language_defn): Likewise.
9183         * language.h (struct language_defn): Remove la_magic field.
9184         (LANG_MAGIC): Delete.
9185         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9186         * objc-lang.c (objc_language_defn): Likewise.
9187         * opencl-lang.c (opencl_language_defn): Likewise.
9188         * p-lang.c (pascal_language_defn): Likewise.
9189         * rust-lang.c (rust_language_defn): Likewise.
9190
9191 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9192
9193         * riscv-tdep.c (riscv_type_align): New function.
9194         (riscv_type_alignment): Delete.
9195         (riscv_arg_location): Use 'type_align'.
9196         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9197
9198 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * gdbtypes.c (type_align): A struct with no non-static fields also
9201         has alignment of 1.
9202
9203 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9206         component to 0.
9207         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9208         member.
9209         (riscv_struct_info::analyse): New implementation using new
9210         analyse_inner member function.
9211         (riscv_struct_info::field_offset): New member function.
9212         (riscv_struct_info::m_offsets): New member variable.
9213         (riscv_struct_info::analyse_inner): New private member function,
9214         takes the old implementation of riscv_struct_info::analyse but
9215         extended to track field offsets.
9216         (riscv_call_arg_struct): Update the struct folding special cases
9217         to handle cases where empty C++ structs, which are non-zero
9218         length, are found.
9219         (riscv_arg_location): Initialise the length of each location, a
9220         non-zero length now indicates the location is in use.
9221         (riscv_push_dummy_call): Allow for the first location having a
9222         non-zero offset when setting up arguments.
9223         (riscv_return_value): Likewise, but for return values.
9224
9225 2019-04-11  Tom Tromey  <tromey@adacore.com>
9226
9227         * utils.c (internal_vproblem): Make "msg" const.
9228
9229 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9230
9231         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9232         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9233         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9234         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9235
9236 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9237
9238         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9239         function.
9240         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9241         of amd64_collect_native_gregset.
9242         (amd64_linux_nat_target::store_registers): Likewise.
9243
9244 2019-04-10  Tom Tromey  <tom@tromey.com>
9245
9246         * symtab.c (lookup_global_symbol_from_objfile)
9247         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9248         * objfiles.h (class separate_debug_iterator): New.
9249         (class separate_debug_range): New.
9250         (struct objfile) <separate_debug_objfiles>: New method.
9251         (objfile_separate_debug_iterate): Don't declare.
9252         * objfiles.c (separate_debug_iterator::operator++): Rename from
9253         objfile_separate_debug_iterate.
9254         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9255         iterator.
9256         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9257         iterator.
9258
9259 2019-04-10  Tom Tromey  <tom@tromey.com>
9260
9261         * symfile.c (reread_symbols): Remove old comment.
9262         * objfiles.c (free_all_objfiles): Fix a typo.
9263
9264 2019-04-10  Tom Tromey  <tom@tromey.com>
9265
9266         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9267         * minsyms.c (lookup_minimal_symbol): Use foreach.
9268         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9269         (lookup_minimal_symbol_solib_trampoline): Likewise.
9270         * symfile.c (reread_symbols): Use foreach.
9271
9272 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9273             Tom Tromey  <tromey@adacore.com>
9274
9275         PR rust/24414:
9276         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9277         (rust_lex_int_test): Change "value" to be LONGEST.
9278         (rust_lex_tests): Add test for long integer literal.
9279
9280 2019-04-09  Tom Tromey  <tromey@adacore.com>
9281
9282         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9283         to bool.
9284         (extended_remote_target::attach): Update.
9285         (remote_target::remote_notice_new_inferior): Update.
9286         (remote_target::add_current_inferior_and_thread): Update.
9287         * inferior.c (exit_inferior_1): Use "false".
9288         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9289
9290 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9291
9292         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9293         the "start" command.
9294
9295 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9296
9297         * python/py-inferior.c (infpy_thread_from_thread_handle):
9298         Adjust comments to reflect renaming of thread_from_thread_handle
9299         to thread_from_handle.  Adjust keywords.  Fix type error message.
9300         (inferior_object_methods): Add thread_from_handle.  Retain
9301         thread_from_thread_handle, but mark it as deprecated.
9302
9303 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9304
9305         * gdbthread.h (find_thread_by_handle): Revise declaration.
9306         * thread.c (find_thread_by_handle): Likewise.  Adjust
9307         implementation too.
9308         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9309         support for buffer objects as handles.
9310
9311 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9312
9313         * python/py-infthread.c (thpy_thread_handle): New function.
9314         (thread_object_methods): Register thpy_thread_handle.
9315
9316 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9317
9318         * gdbthread.h (thread_to_thread_handle): Declare.
9319         * thread.c (gdbtypes.h): Include.
9320         (thread_to_thread_handle): New function.
9321
9322         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9323         (target_thread_info_to_thread_handle): Declare.
9324         * target.c (target_thread_info_to_thread_handle): New function.
9325         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9326         * target-delegates.c: Regenerate.
9327
9328         * linux-thread-db.c (class thread_db_target): Add method
9329         thread_info_to_thread_handle.
9330         (thread_db_target::thread_info_to_thread_handle): Define.
9331         * remote.c (class remote_target): Add new method
9332         thread_info_to_thread_handle.
9333         (remote_target::thread_info_to_thread_handle): Define.
9334
9335 2019-04-08  Pedro Alves  <palves@redhat.com>
9336
9337         * common/common-exceptions.c (throw_exception): Don't create
9338         named object to throw; throw directly.
9339         (throw_it): Likewise.  Don't initialize gdb_exception::message
9340         here, with new; pass FMT and AP to the ctor instead.
9341         * common/common-exceptions.h: Include <string>.
9342         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9343         const char *, va_list)): New ctor.  Use std::make_shared.
9344         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9345         errors)): Delete.
9346         (gdb_exception_error::gdb_exception_error(enum errors, const char
9347         *, va_list)): New.
9348         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9349         Add assertion.
9350         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9351         errors)): Delete.
9352         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9353         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9354         Add assertion.
9355
9356 2019-04-08  Tom Tromey  <tom@tromey.com>
9357
9358         * valops.c (value_rtti_indirect_type): Replace throw_exception
9359         with throw.
9360         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9361         with throw.
9362         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9363         throw.
9364         * target.c (target_translate_tls_address): Replace throw_exception
9365         with throw.
9366         * stack.c (frame_apply_command_count): Replace throw_exception
9367         with throw.
9368         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9369         throw.
9370         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9371         with throw.
9372         * rs6000-tdep.c (rs6000_frame_cache)
9373         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9374         * remote.c: Replace throw_exception with throw.
9375         * record-full.c (record_full_message, record_full_wait_1)
9376         (record_full_restore): Replace throw_exception with throw.
9377         * record-btrace.c:
9378         (get_thread_current_frame_id, record_btrace_start_replaying)
9379         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9380         (cmd_record_btrace_start): Replace throw_exception with throw.
9381         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9382         throw.
9383         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9384         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9385         * linespec.c:
9386         (find_linespec_symbols): Replace throw_exception with throw.
9387         * infrun.c (displaced_step_prepare, resume): Replace
9388         throw_exception with throw.
9389         * infcmd.c (post_create_inferior): Replace throw_exception with
9390         throw.
9391         * inf-loop.c (inferior_event_handler): Replace throw_exception
9392         with throw.
9393         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9394         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9395         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9396         (get_prev_frame_always, get_frame_pc_if_available)
9397         (get_frame_address_in_block_if_available, get_frame_language):
9398         Replace throw_exception with throw.
9399         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9400         throw_exception with throw.
9401         * eval.c (fetch_subexp_value, evaluate_var_value)
9402         (evaluate_funcall, evaluate_subexp_standard): Replace
9403         throw_exception with throw.
9404         * dwarf2loc.c (call_site_find_chain)
9405         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9406         Replace throw_exception with throw.
9407         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9408         with throw.
9409         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9410         throw.
9411         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9412         * completer.c (complete_line_internal): Replace throw_exception
9413         with throw.
9414         * compile/compile-object-run.c (compile_object_run): Replace
9415         throw_exception with throw.
9416         * cli/cli-script.c (process_next_line): Replace throw_exception
9417         with throw.
9418         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9419         (btrace_enable, btrace_maint_update_pt_packets): Replace
9420         throw_exception with throw.
9421         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9422         throw_exception with throw.
9423         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9424         throw_exception with throw.
9425         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9426         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9427         * aarch64-tdep.c (aarch64_make_prologue_cache)
9428         (aarch64_make_stub_cache): Replace throw_exception with throw.
9429
9430 2019-04-08  Tom Tromey  <tom@tromey.com>
9431
9432         * common/common-exceptions.c (throw_exception): Rename from
9433         throw_exception_cxx.  Remove old copy.  Make argument const.
9434         (throw_it): Create and throw exception objects directly.
9435         * common/common-exceptions.h (throw_exception): Make argument
9436         const.
9437         (struct gdb_exception_error): Add constructor.
9438         (struct gdb_exception_quit): Add constructor.
9439
9440 2019-04-08  Tom Tromey  <tom@tromey.com>
9441
9442         * common/common-exceptions.h (exception_rethrow): Don't declare.
9443         (TRY_SJLJ): Update comment.
9444         (TRY, CATCH, END_CATCH): Remove.
9445         * common/common-exceptions.c (exception_rethrow): Remove.
9446
9447 2019-04-08  Tom Tromey  <tom@tromey.com>
9448
9449         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9450         Remove.
9451         (gdb_exception_error): Rename from
9452         gdb_exception_RETURN_MASK_ERROR.
9453         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9454         (gdb_quit_bad_alloc): Update.
9455         * aarch64-tdep.c: Update.
9456         * ada-lang.c: Update.
9457         * ada-typeprint.c: Update.
9458         * ada-valprint.c: Update.
9459         * amd64-tdep.c: Update.
9460         * arch-utils.c: Update.
9461         * break-catch-throw.c: Update.
9462         * breakpoint.c: Update.
9463         * btrace.c: Update.
9464         * c-varobj.c: Update.
9465         * cli/cli-cmds.c: Update.
9466         * cli/cli-interp.c: Update.
9467         * cli/cli-script.c: Update.
9468         * common/common-exceptions.c: Update.
9469         * common/new-op.c: Update.
9470         * common/selftest.c: Update.
9471         * compile/compile-c-symbols.c: Update.
9472         * compile/compile-cplus-symbols.c: Update.
9473         * compile/compile-object-load.c: Update.
9474         * compile/compile-object-run.c: Update.
9475         * completer.c: Update.
9476         * corelow.c: Update.
9477         * cp-abi.c: Update.
9478         * cp-support.c: Update.
9479         * cp-valprint.c: Update.
9480         * darwin-nat.c: Update.
9481         * disasm-selftests.c: Update.
9482         * dtrace-probe.c: Update.
9483         * dwarf-index-cache.c: Update.
9484         * dwarf-index-write.c: Update.
9485         * dwarf2-frame-tailcall.c: Update.
9486         * dwarf2-frame.c: Update.
9487         * dwarf2loc.c: Update.
9488         * dwarf2read.c: Update.
9489         * eval.c: Update.
9490         * event-loop.c: Update.
9491         * event-top.c: Update.
9492         * exec.c: Update.
9493         * f-valprint.c: Update.
9494         * fbsd-tdep.c: Update.
9495         * frame-unwind.c: Update.
9496         * frame.c: Update.
9497         * gdbtypes.c: Update.
9498         * gnu-v3-abi.c: Update.
9499         * guile/guile-internal.h: Update.
9500         * guile/scm-block.c: Update.
9501         * guile/scm-breakpoint.c: Update.
9502         * guile/scm-cmd.c: Update.
9503         * guile/scm-disasm.c: Update.
9504         * guile/scm-frame.c: Update.
9505         * guile/scm-lazy-string.c: Update.
9506         * guile/scm-math.c: Update.
9507         * guile/scm-param.c: Update.
9508         * guile/scm-ports.c: Update.
9509         * guile/scm-pretty-print.c: Update.
9510         * guile/scm-symbol.c: Update.
9511         * guile/scm-symtab.c: Update.
9512         * guile/scm-type.c: Update.
9513         * guile/scm-value.c: Update.
9514         * i386-linux-tdep.c: Update.
9515         * i386-tdep.c: Update.
9516         * inf-loop.c: Update.
9517         * infcall.c: Update.
9518         * infcmd.c: Update.
9519         * infrun.c: Update.
9520         * jit.c: Update.
9521         * language.c: Update.
9522         * linespec.c: Update.
9523         * linux-fork.c: Update.
9524         * linux-nat.c: Update.
9525         * linux-tdep.c: Update.
9526         * linux-thread-db.c: Update.
9527         * main.c: Update.
9528         * mi/mi-cmd-break.c: Update.
9529         * mi/mi-cmd-stack.c: Update.
9530         * mi/mi-interp.c: Update.
9531         * mi/mi-main.c: Update.
9532         * objc-lang.c: Update.
9533         * p-valprint.c: Update.
9534         * parse.c: Update.
9535         * ppc-linux-tdep.c: Update.
9536         * printcmd.c: Update.
9537         * python/py-arch.c: Update.
9538         * python/py-breakpoint.c: Update.
9539         * python/py-cmd.c: Update.
9540         * python/py-finishbreakpoint.c: Update.
9541         * python/py-frame.c: Update.
9542         * python/py-framefilter.c: Update.
9543         * python/py-gdb-readline.c: Update.
9544         * python/py-inferior.c: Update.
9545         * python/py-infthread.c: Update.
9546         * python/py-lazy-string.c: Update.
9547         * python/py-linetable.c: Update.
9548         * python/py-objfile.c: Update.
9549         * python/py-param.c: Update.
9550         * python/py-prettyprint.c: Update.
9551         * python/py-progspace.c: Update.
9552         * python/py-record-btrace.c: Update.
9553         * python/py-record.c: Update.
9554         * python/py-symbol.c: Update.
9555         * python/py-type.c: Update.
9556         * python/py-unwind.c: Update.
9557         * python/py-utils.c: Update.
9558         * python/py-value.c: Update.
9559         * python/python.c: Update.
9560         * record-btrace.c: Update.
9561         * record-full.c: Update.
9562         * remote-fileio.c: Update.
9563         * remote.c: Update.
9564         * riscv-tdep.c: Update.
9565         * rs6000-aix-tdep.c: Update.
9566         * rs6000-tdep.c: Update.
9567         * rust-exp.y: Update.
9568         * rust-lang.c: Update.
9569         * s390-tdep.c: Update.
9570         * selftest-arch.c: Update.
9571         * solib-dsbt.c: Update.
9572         * solib-frv.c: Update.
9573         * solib-spu.c: Update.
9574         * solib-svr4.c: Update.
9575         * solib.c: Update.
9576         * sparc64-linux-tdep.c: Update.
9577         * stack.c: Update.
9578         * symfile-mem.c: Update.
9579         * symmisc.c: Update.
9580         * target.c: Update.
9581         * thread.c: Update.
9582         * top.c: Update.
9583         * tracefile-tfile.c: Update.
9584         * tui/tui.c: Update.
9585         * typeprint.c: Update.
9586         * unittests/cli-utils-selftests.c: Update.
9587         * unittests/parse-connection-spec-selftests.c: Update.
9588         * valops.c: Update.
9589         * valprint.c: Update.
9590         * value.c: Update.
9591         * varobj.c: Update.
9592         * windows-nat.c: Update.
9593         * x86-linux-nat.c: Update.
9594         * xml-support.c: Update.
9595
9596 2019-04-08  Tom Tromey  <tom@tromey.com>
9597
9598         * xml-support.c: Use C++ exception handling.
9599         * x86-linux-nat.c: Use C++ exception handling.
9600         * windows-nat.c: Use C++ exception handling.
9601         * varobj.c: Use C++ exception handling.
9602         * value.c: Use C++ exception handling.
9603         * valprint.c: Use C++ exception handling.
9604         * valops.c: Use C++ exception handling.
9605         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9606         handling.
9607         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9608         * typeprint.c: Use C++ exception handling.
9609         * tui/tui.c: Use C++ exception handling.
9610         * tracefile-tfile.c: Use C++ exception handling.
9611         * top.c: Use C++ exception handling.
9612         * thread.c: Use C++ exception handling.
9613         * target.c: Use C++ exception handling.
9614         * symmisc.c: Use C++ exception handling.
9615         * symfile-mem.c: Use C++ exception handling.
9616         * stack.c: Use C++ exception handling.
9617         * sparc64-linux-tdep.c: Use C++ exception handling.
9618         * solib.c: Use C++ exception handling.
9619         * solib-svr4.c: Use C++ exception handling.
9620         * solib-spu.c: Use C++ exception handling.
9621         * solib-frv.c: Use C++ exception handling.
9622         * solib-dsbt.c: Use C++ exception handling.
9623         * selftest-arch.c: Use C++ exception handling.
9624         * s390-tdep.c: Use C++ exception handling.
9625         * rust-lang.c: Use C++ exception handling.
9626         * rust-exp.y: Use C++ exception handling.
9627         * rs6000-tdep.c: Use C++ exception handling.
9628         * rs6000-aix-tdep.c: Use C++ exception handling.
9629         * riscv-tdep.c: Use C++ exception handling.
9630         * remote.c: Use C++ exception handling.
9631         * remote-fileio.c: Use C++ exception handling.
9632         * record-full.c: Use C++ exception handling.
9633         * record-btrace.c: Use C++ exception handling.
9634         * python/python.c: Use C++ exception handling.
9635         * python/py-value.c: Use C++ exception handling.
9636         * python/py-utils.c: Use C++ exception handling.
9637         * python/py-unwind.c: Use C++ exception handling.
9638         * python/py-type.c: Use C++ exception handling.
9639         * python/py-symbol.c: Use C++ exception handling.
9640         * python/py-record.c: Use C++ exception handling.
9641         * python/py-record-btrace.c: Use C++ exception handling.
9642         * python/py-progspace.c: Use C++ exception handling.
9643         * python/py-prettyprint.c: Use C++ exception handling.
9644         * python/py-param.c: Use C++ exception handling.
9645         * python/py-objfile.c: Use C++ exception handling.
9646         * python/py-linetable.c: Use C++ exception handling.
9647         * python/py-lazy-string.c: Use C++ exception handling.
9648         * python/py-infthread.c: Use C++ exception handling.
9649         * python/py-inferior.c: Use C++ exception handling.
9650         * python/py-gdb-readline.c: Use C++ exception handling.
9651         * python/py-framefilter.c: Use C++ exception handling.
9652         * python/py-frame.c: Use C++ exception handling.
9653         * python/py-finishbreakpoint.c: Use C++ exception handling.
9654         * python/py-cmd.c: Use C++ exception handling.
9655         * python/py-breakpoint.c: Use C++ exception handling.
9656         * python/py-arch.c: Use C++ exception handling.
9657         * printcmd.c: Use C++ exception handling.
9658         * ppc-linux-tdep.c: Use C++ exception handling.
9659         * parse.c: Use C++ exception handling.
9660         * p-valprint.c: Use C++ exception handling.
9661         * objc-lang.c: Use C++ exception handling.
9662         * mi/mi-main.c: Use C++ exception handling.
9663         * mi/mi-interp.c: Use C++ exception handling.
9664         * mi/mi-cmd-stack.c: Use C++ exception handling.
9665         * mi/mi-cmd-break.c: Use C++ exception handling.
9666         * main.c: Use C++ exception handling.
9667         * linux-thread-db.c: Use C++ exception handling.
9668         * linux-tdep.c: Use C++ exception handling.
9669         * linux-nat.c: Use C++ exception handling.
9670         * linux-fork.c: Use C++ exception handling.
9671         * linespec.c: Use C++ exception handling.
9672         * language.c: Use C++ exception handling.
9673         * jit.c: Use C++ exception handling.
9674         * infrun.c: Use C++ exception handling.
9675         * infcmd.c: Use C++ exception handling.
9676         * infcall.c: Use C++ exception handling.
9677         * inf-loop.c: Use C++ exception handling.
9678         * i386-tdep.c: Use C++ exception handling.
9679         * i386-linux-tdep.c: Use C++ exception handling.
9680         * guile/scm-value.c: Use C++ exception handling.
9681         * guile/scm-type.c: Use C++ exception handling.
9682         * guile/scm-symtab.c: Use C++ exception handling.
9683         * guile/scm-symbol.c: Use C++ exception handling.
9684         * guile/scm-pretty-print.c: Use C++ exception handling.
9685         * guile/scm-ports.c: Use C++ exception handling.
9686         * guile/scm-param.c: Use C++ exception handling.
9687         * guile/scm-math.c: Use C++ exception handling.
9688         * guile/scm-lazy-string.c: Use C++ exception handling.
9689         * guile/scm-frame.c: Use C++ exception handling.
9690         * guile/scm-disasm.c: Use C++ exception handling.
9691         * guile/scm-cmd.c: Use C++ exception handling.
9692         * guile/scm-breakpoint.c: Use C++ exception handling.
9693         * guile/scm-block.c: Use C++ exception handling.
9694         * guile/guile-internal.h: Use C++ exception handling.
9695         * gnu-v3-abi.c: Use C++ exception handling.
9696         * gdbtypes.c: Use C++ exception handling.
9697         * frame.c: Use C++ exception handling.
9698         * frame-unwind.c: Use C++ exception handling.
9699         * fbsd-tdep.c: Use C++ exception handling.
9700         * f-valprint.c: Use C++ exception handling.
9701         * exec.c: Use C++ exception handling.
9702         * event-top.c: Use C++ exception handling.
9703         * event-loop.c: Use C++ exception handling.
9704         * eval.c: Use C++ exception handling.
9705         * dwarf2read.c: Use C++ exception handling.
9706         * dwarf2loc.c: Use C++ exception handling.
9707         * dwarf2-frame.c: Use C++ exception handling.
9708         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9709         * dwarf-index-write.c: Use C++ exception handling.
9710         * dwarf-index-cache.c: Use C++ exception handling.
9711         * dtrace-probe.c: Use C++ exception handling.
9712         * disasm-selftests.c: Use C++ exception handling.
9713         * darwin-nat.c: Use C++ exception handling.
9714         * cp-valprint.c: Use C++ exception handling.
9715         * cp-support.c: Use C++ exception handling.
9716         * cp-abi.c: Use C++ exception handling.
9717         * corelow.c: Use C++ exception handling.
9718         * completer.c: Use C++ exception handling.
9719         * compile/compile-object-run.c: Use C++ exception handling.
9720         * compile/compile-object-load.c: Use C++ exception handling.
9721         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9722         * compile/compile-c-symbols.c: Use C++ exception handling.
9723         * common/selftest.c: Use C++ exception handling.
9724         * common/new-op.c: Use C++ exception handling.
9725         * cli/cli-script.c: Use C++ exception handling.
9726         * cli/cli-interp.c: Use C++ exception handling.
9727         * cli/cli-cmds.c: Use C++ exception handling.
9728         * c-varobj.c: Use C++ exception handling.
9729         * btrace.c: Use C++ exception handling.
9730         * breakpoint.c: Use C++ exception handling.
9731         * break-catch-throw.c: Use C++ exception handling.
9732         * arch-utils.c: Use C++ exception handling.
9733         * amd64-tdep.c: Use C++ exception handling.
9734         * ada-valprint.c: Use C++ exception handling.
9735         * ada-typeprint.c: Use C++ exception handling.
9736         * ada-lang.c: Use C++ exception handling.
9737         * aarch64-tdep.c: Use C++ exception handling.
9738
9739 2019-04-08  Tom Tromey  <tom@tromey.com>
9740
9741         * xml-support.c (gdb_xml_parser::parse): Update.
9742         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9743         * value.c (show_convenience): Update.
9744         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9745         (test_parse_flags_qcs): Update.
9746         * thread.c (thr_try_catch_cmd): Update.
9747         * target.c (target_translate_tls_address): Update.
9748         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9749         (info_frame_command_core, frame_apply_command_count): Update.
9750         * rust-exp.y (rust_lex_exception_test): Update.
9751         * riscv-tdep.c (riscv_print_one_register_info): Update.
9752         * remote.c (remote_target::enable_btrace): Update.
9753         * record-btrace.c (record_btrace_enable_warn): Update.
9754         * python/py-utils.c (gdbpy_convert_exception): Update.
9755         * printcmd.c (do_one_display, print_variable_and_value): Update.
9756         * mi/mi-main.c (mi_print_exception): Update.
9757         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9758         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9759         * linux-nat.c (linux_nat_target::attach): Update.
9760         * linux-fork.c (class scoped_switch_fork_info): Update.
9761         * infrun.c (displaced_step_prepare): Update.
9762         * infcall.c (call_function_by_hand_dummy): Update.
9763         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9764         * gnu-v3-abi.c (print_one_vtable): Update.
9765         * frame.c (get_prev_frame_always): Update.
9766         * f-valprint.c (info_common_command_for_block): Update.
9767         * exec.c (try_open_exec_file): Update.
9768         * exceptions.c (print_exception, exception_print)
9769         (exception_fprintf, exception_print_same): Update.
9770         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9771         * dwarf-index-cache.c (index_cache::store)
9772         (index_cache::lookup_gdb_index): Update.
9773         * darwin-nat.c (maybe_cache_shell): Update.
9774         * cp-valprint.c (cp_print_value_fields): Update.
9775         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9776         (gcc_cplus_symbol_address): Update.
9777         * compile/compile-c-symbols.c (gcc_convert_symbol)
9778         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9779         * common/selftest.c: Update.
9780         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9781         a std::string.
9782         (exception_try_scope_entry, exception_try_scope_exit): Don't
9783         declare.
9784         (struct exception_try_scope): Remove.
9785         (TRY): Don't use exception_try_scope.
9786         (struct gdb_exception): Add constructor, operator=.
9787         <what>: New method.
9788         (struct gdb_exception_RETURN_MASK_ALL)
9789         (struct gdb_exception_RETURN_MASK_ERROR)
9790         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9791         (struct gdb_quit_bad_alloc): Update.
9792         * common/common-exceptions.c (exception_none): Change
9793         initializer.
9794         (struct catcher) <state, exception>: Initialize inline.
9795         <prev>: Remove member.
9796         (current_catcher): Remove.
9797         (catchers): New global.
9798         (exceptions_state_mc_init): Simplify.
9799         (catcher_pop): Remove.
9800         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9801         (try_scope_depth, exception_try_scope_entry)
9802         (exception_try_scope_exit): Remove.
9803         (throw_exception_sjlj): Update.
9804         (exception_messages, exception_messages_size): Remove.
9805         (throw_it): Simplify.
9806         (gdb_exception_sliced_copy): Remove.
9807         (throw_exception_cxx): Update.
9808         * cli/cli-script.c (script_from_file): Update.
9809         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9810         Update.
9811         * ada-valprint.c (ada_val_print): Update.
9812         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9813         (create_excep_cond_exprs): Update.
9814
9815 2019-04-08  Tom Tromey  <tom@tromey.com>
9816
9817         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9818         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9819         (TRY, CATCH, END_CATCH): Remove some definitions.
9820         * common/common-exceptions.c: Don't use GDB_XCPT.
9821         (catcher_list_size): Remove.
9822         (throw_exception, throw_it): Simplify.
9823
9824 2019-04-05  Tom Tromey  <tom@tromey.com>
9825
9826         Revert the header-sorting patch.
9827         * ft32-tdep.c: Revert.
9828         * frv-tdep.c: Revert.
9829         * frv-linux-tdep.c: Revert.
9830         * frame.c: Revert.
9831         * frame-unwind.c: Revert.
9832         * frame-base.c: Revert.
9833         * fork-child.c: Revert.
9834         * findvar.c: Revert.
9835         * findcmd.c: Revert.
9836         * filesystem.c: Revert.
9837         * filename-seen-cache.h: Revert.
9838         * filename-seen-cache.c: Revert.
9839         * fbsd-tdep.c: Revert.
9840         * fbsd-nat.h: Revert.
9841         * fbsd-nat.c: Revert.
9842         * f-valprint.c: Revert.
9843         * f-typeprint.c: Revert.
9844         * f-lang.c: Revert.
9845         * extension.h: Revert.
9846         * extension.c: Revert.
9847         * extension-priv.h: Revert.
9848         * expprint.c: Revert.
9849         * exec.h: Revert.
9850         * exec.c: Revert.
9851         * exceptions.c: Revert.
9852         * event-top.c: Revert.
9853         * event-loop.c: Revert.
9854         * eval.c: Revert.
9855         * elfread.c: Revert.
9856         * dwarf2read.h: Revert.
9857         * dwarf2read.c: Revert.
9858         * dwarf2loc.c: Revert.
9859         * dwarf2expr.h: Revert.
9860         * dwarf2expr.c: Revert.
9861         * dwarf2-frame.c: Revert.
9862         * dwarf2-frame-tailcall.c: Revert.
9863         * dwarf-index-write.h: Revert.
9864         * dwarf-index-write.c: Revert.
9865         * dwarf-index-common.c: Revert.
9866         * dwarf-index-cache.h: Revert.
9867         * dwarf-index-cache.c: Revert.
9868         * dummy-frame.c: Revert.
9869         * dtrace-probe.c: Revert.
9870         * disasm.h: Revert.
9871         * disasm.c: Revert.
9872         * disasm-selftests.c: Revert.
9873         * dictionary.c: Revert.
9874         * dicos-tdep.c: Revert.
9875         * demangle.c: Revert.
9876         * dcache.h: Revert.
9877         * dcache.c: Revert.
9878         * darwin-nat.h: Revert.
9879         * darwin-nat.c: Revert.
9880         * darwin-nat-info.c: Revert.
9881         * d-valprint.c: Revert.
9882         * d-namespace.c: Revert.
9883         * d-lang.c: Revert.
9884         * ctf.c: Revert.
9885         * csky-tdep.c: Revert.
9886         * csky-linux-tdep.c: Revert.
9887         * cris-tdep.c: Revert.
9888         * cris-linux-tdep.c: Revert.
9889         * cp-valprint.c: Revert.
9890         * cp-support.c: Revert.
9891         * cp-namespace.c: Revert.
9892         * cp-abi.c: Revert.
9893         * corelow.c: Revert.
9894         * corefile.c: Revert.
9895         * continuations.c: Revert.
9896         * completer.h: Revert.
9897         * completer.c: Revert.
9898         * complaints.c: Revert.
9899         * coffread.c: Revert.
9900         * coff-pe-read.c: Revert.
9901         * cli-out.h: Revert.
9902         * cli-out.c: Revert.
9903         * charset.c: Revert.
9904         * c-varobj.c: Revert.
9905         * c-valprint.c: Revert.
9906         * c-typeprint.c: Revert.
9907         * c-lang.c: Revert.
9908         * buildsym.c: Revert.
9909         * buildsym-legacy.c: Revert.
9910         * build-id.h: Revert.
9911         * build-id.c: Revert.
9912         * btrace.c: Revert.
9913         * bsd-uthread.c: Revert.
9914         * breakpoint.h: Revert.
9915         * breakpoint.c: Revert.
9916         * break-catch-throw.c: Revert.
9917         * break-catch-syscall.c: Revert.
9918         * break-catch-sig.c: Revert.
9919         * blockframe.c: Revert.
9920         * block.c: Revert.
9921         * bfin-tdep.c: Revert.
9922         * bfin-linux-tdep.c: Revert.
9923         * bfd-target.c: Revert.
9924         * bcache.c: Revert.
9925         * ax-general.c: Revert.
9926         * ax-gdb.h: Revert.
9927         * ax-gdb.c: Revert.
9928         * avr-tdep.c: Revert.
9929         * auxv.c: Revert.
9930         * auto-load.c: Revert.
9931         * arm-wince-tdep.c: Revert.
9932         * arm-tdep.c: Revert.
9933         * arm-symbian-tdep.c: Revert.
9934         * arm-pikeos-tdep.c: Revert.
9935         * arm-obsd-tdep.c: Revert.
9936         * arm-nbsd-tdep.c: Revert.
9937         * arm-nbsd-nat.c: Revert.
9938         * arm-linux-tdep.c: Revert.
9939         * arm-linux-nat.c: Revert.
9940         * arm-fbsd-tdep.c: Revert.
9941         * arm-fbsd-nat.c: Revert.
9942         * arm-bsd-tdep.c: Revert.
9943         * arch-utils.c: Revert.
9944         * arc-tdep.c: Revert.
9945         * arc-newlib-tdep.c: Revert.
9946         * annotate.h: Revert.
9947         * annotate.c: Revert.
9948         * amd64-windows-tdep.c: Revert.
9949         * amd64-windows-nat.c: Revert.
9950         * amd64-tdep.c: Revert.
9951         * amd64-sol2-tdep.c: Revert.
9952         * amd64-obsd-tdep.c: Revert.
9953         * amd64-obsd-nat.c: Revert.
9954         * amd64-nbsd-tdep.c: Revert.
9955         * amd64-nbsd-nat.c: Revert.
9956         * amd64-nat.c: Revert.
9957         * amd64-linux-tdep.c: Revert.
9958         * amd64-linux-nat.c: Revert.
9959         * amd64-fbsd-tdep.c: Revert.
9960         * amd64-fbsd-nat.c: Revert.
9961         * amd64-dicos-tdep.c: Revert.
9962         * amd64-darwin-tdep.c: Revert.
9963         * amd64-bsd-nat.c: Revert.
9964         * alpha-tdep.c: Revert.
9965         * alpha-obsd-tdep.c: Revert.
9966         * alpha-nbsd-tdep.c: Revert.
9967         * alpha-mdebug-tdep.c: Revert.
9968         * alpha-linux-tdep.c: Revert.
9969         * alpha-linux-nat.c: Revert.
9970         * alpha-bsd-tdep.c: Revert.
9971         * alpha-bsd-nat.c: Revert.
9972         * aix-thread.c: Revert.
9973         * agent.c: Revert.
9974         * addrmap.c: Revert.
9975         * ada-varobj.c: Revert.
9976         * ada-valprint.c: Revert.
9977         * ada-typeprint.c: Revert.
9978         * ada-tasks.c: Revert.
9979         * ada-lang.c: Revert.
9980         * aarch64-tdep.c: Revert.
9981         * aarch64-ravenscar-thread.c: Revert.
9982         * aarch64-newlib-tdep.c: Revert.
9983         * aarch64-linux-tdep.c: Revert.
9984         * aarch64-linux-nat.c: Revert.
9985         * aarch64-fbsd-tdep.c: Revert.
9986         * aarch64-fbsd-nat.c: Revert.
9987         * aarch32-linux-nat.c: Revert.
9988
9989 2019-04-05  Tom Tromey  <tom@tromey.com>
9990
9991         * ft32-tdep.c: Sort headers.
9992         * frv-tdep.c: Sort headers.
9993         * frv-linux-tdep.c: Sort headers.
9994         * frame.c: Sort headers.
9995         * frame-unwind.c: Sort headers.
9996         * frame-base.c: Sort headers.
9997         * fork-child.c: Sort headers.
9998         * findvar.c: Sort headers.
9999         * findcmd.c: Sort headers.
10000         * filesystem.c: Sort headers.
10001         * filename-seen-cache.h: Sort headers.
10002         * filename-seen-cache.c: Sort headers.
10003         * fbsd-tdep.c: Sort headers.
10004         * fbsd-nat.h: Sort headers.
10005         * fbsd-nat.c: Sort headers.
10006         * f-valprint.c: Sort headers.
10007         * f-typeprint.c: Sort headers.
10008         * f-lang.c: Sort headers.
10009         * extension.h: Sort headers.
10010         * extension.c: Sort headers.
10011         * extension-priv.h: Sort headers.
10012         * expprint.c: Sort headers.
10013         * exec.h: Sort headers.
10014         * exec.c: Sort headers.
10015         * exceptions.c: Sort headers.
10016         * event-top.c: Sort headers.
10017         * event-loop.c: Sort headers.
10018         * eval.c: Sort headers.
10019         * elfread.c: Sort headers.
10020         * dwarf2read.h: Sort headers.
10021         * dwarf2read.c: Sort headers.
10022         * dwarf2loc.c: Sort headers.
10023         * dwarf2expr.h: Sort headers.
10024         * dwarf2expr.c: Sort headers.
10025         * dwarf2-frame.c: Sort headers.
10026         * dwarf2-frame-tailcall.c: Sort headers.
10027         * dwarf-index-write.h: Sort headers.
10028         * dwarf-index-write.c: Sort headers.
10029         * dwarf-index-common.c: Sort headers.
10030         * dwarf-index-cache.h: Sort headers.
10031         * dwarf-index-cache.c: Sort headers.
10032         * dummy-frame.c: Sort headers.
10033         * dtrace-probe.c: Sort headers.
10034         * disasm.h: Sort headers.
10035         * disasm.c: Sort headers.
10036         * disasm-selftests.c: Sort headers.
10037         * dictionary.c: Sort headers.
10038         * dicos-tdep.c: Sort headers.
10039         * demangle.c: Sort headers.
10040         * dcache.h: Sort headers.
10041         * dcache.c: Sort headers.
10042         * darwin-nat.h: Sort headers.
10043         * darwin-nat.c: Sort headers.
10044         * darwin-nat-info.c: Sort headers.
10045         * d-valprint.c: Sort headers.
10046         * d-namespace.c: Sort headers.
10047         * d-lang.c: Sort headers.
10048         * ctf.c: Sort headers.
10049         * csky-tdep.c: Sort headers.
10050         * csky-linux-tdep.c: Sort headers.
10051         * cris-tdep.c: Sort headers.
10052         * cris-linux-tdep.c: Sort headers.
10053         * cp-valprint.c: Sort headers.
10054         * cp-support.c: Sort headers.
10055         * cp-namespace.c: Sort headers.
10056         * cp-abi.c: Sort headers.
10057         * corelow.c: Sort headers.
10058         * corefile.c: Sort headers.
10059         * continuations.c: Sort headers.
10060         * completer.h: Sort headers.
10061         * completer.c: Sort headers.
10062         * complaints.c: Sort headers.
10063         * coffread.c: Sort headers.
10064         * coff-pe-read.c: Sort headers.
10065         * cli-out.h: Sort headers.
10066         * cli-out.c: Sort headers.
10067         * charset.c: Sort headers.
10068         * c-varobj.c: Sort headers.
10069         * c-valprint.c: Sort headers.
10070         * c-typeprint.c: Sort headers.
10071         * c-lang.c: Sort headers.
10072         * buildsym.c: Sort headers.
10073         * buildsym-legacy.c: Sort headers.
10074         * build-id.h: Sort headers.
10075         * build-id.c: Sort headers.
10076         * btrace.c: Sort headers.
10077         * bsd-uthread.c: Sort headers.
10078         * breakpoint.h: Sort headers.
10079         * breakpoint.c: Sort headers.
10080         * break-catch-throw.c: Sort headers.
10081         * break-catch-syscall.c: Sort headers.
10082         * break-catch-sig.c: Sort headers.
10083         * blockframe.c: Sort headers.
10084         * block.c: Sort headers.
10085         * bfin-tdep.c: Sort headers.
10086         * bfin-linux-tdep.c: Sort headers.
10087         * bfd-target.c: Sort headers.
10088         * bcache.c: Sort headers.
10089         * ax-general.c: Sort headers.
10090         * ax-gdb.h: Sort headers.
10091         * ax-gdb.c: Sort headers.
10092         * avr-tdep.c: Sort headers.
10093         * auxv.c: Sort headers.
10094         * auto-load.c: Sort headers.
10095         * arm-wince-tdep.c: Sort headers.
10096         * arm-tdep.c: Sort headers.
10097         * arm-symbian-tdep.c: Sort headers.
10098         * arm-pikeos-tdep.c: Sort headers.
10099         * arm-obsd-tdep.c: Sort headers.
10100         * arm-nbsd-tdep.c: Sort headers.
10101         * arm-nbsd-nat.c: Sort headers.
10102         * arm-linux-tdep.c: Sort headers.
10103         * arm-linux-nat.c: Sort headers.
10104         * arm-fbsd-tdep.c: Sort headers.
10105         * arm-fbsd-nat.c: Sort headers.
10106         * arm-bsd-tdep.c: Sort headers.
10107         * arch-utils.c: Sort headers.
10108         * arc-tdep.c: Sort headers.
10109         * arc-newlib-tdep.c: Sort headers.
10110         * annotate.h: Sort headers.
10111         * annotate.c: Sort headers.
10112         * amd64-windows-tdep.c: Sort headers.
10113         * amd64-windows-nat.c: Sort headers.
10114         * amd64-tdep.c: Sort headers.
10115         * amd64-sol2-tdep.c: Sort headers.
10116         * amd64-obsd-tdep.c: Sort headers.
10117         * amd64-obsd-nat.c: Sort headers.
10118         * amd64-nbsd-tdep.c: Sort headers.
10119         * amd64-nbsd-nat.c: Sort headers.
10120         * amd64-nat.c: Sort headers.
10121         * amd64-linux-tdep.c: Sort headers.
10122         * amd64-linux-nat.c: Sort headers.
10123         * amd64-fbsd-tdep.c: Sort headers.
10124         * amd64-fbsd-nat.c: Sort headers.
10125         * amd64-dicos-tdep.c: Sort headers.
10126         * amd64-darwin-tdep.c: Sort headers.
10127         * amd64-bsd-nat.c: Sort headers.
10128         * alpha-tdep.c: Sort headers.
10129         * alpha-obsd-tdep.c: Sort headers.
10130         * alpha-nbsd-tdep.c: Sort headers.
10131         * alpha-mdebug-tdep.c: Sort headers.
10132         * alpha-linux-tdep.c: Sort headers.
10133         * alpha-linux-nat.c: Sort headers.
10134         * alpha-bsd-tdep.c: Sort headers.
10135         * alpha-bsd-nat.c: Sort headers.
10136         * aix-thread.c: Sort headers.
10137         * agent.c: Sort headers.
10138         * addrmap.c: Sort headers.
10139         * ada-varobj.c: Sort headers.
10140         * ada-valprint.c: Sort headers.
10141         * ada-typeprint.c: Sort headers.
10142         * ada-tasks.c: Sort headers.
10143         * ada-lang.c: Sort headers.
10144         * aarch64-tdep.c: Sort headers.
10145         * aarch64-ravenscar-thread.c: Sort headers.
10146         * aarch64-newlib-tdep.c: Sort headers.
10147         * aarch64-linux-tdep.c: Sort headers.
10148         * aarch64-linux-nat.c: Sort headers.
10149         * aarch64-fbsd-tdep.c: Sort headers.
10150         * aarch64-fbsd-nat.c: Sort headers.
10151         * aarch32-linux-nat.c: Sort headers.
10152
10153 2019-04-04  Tom Tromey  <tom@tromey.com>
10154
10155         * varobj.c (varobj_create): Update.
10156         * rust-exp.y (struct rust_parser) <update_innermost_block,
10157         lookup_symbol>: New methods.
10158         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10159         Rename.
10160         (rust_parser::rust_lookup_type)
10161         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10162         * printcmd.c (display_command, do_one_display): Update.
10163         * parser-defs.h (struct parser_state) <parser_state>: Add
10164         "tracker" parameter.
10165         (block_tracker): New member.
10166         (class innermost_block_tracker) <innermost_block_tracker>: Add
10167         "types" parameter.
10168         <reset>: Remove method.
10169         (innermost_block): Don't declare.
10170         (null_post_parser): Update.
10171         * parse.c (innermost_block): Remove global.
10172         (write_dollar_variable): Update.
10173         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10174         Remove "tracker_types" parameter.
10175         (parse_expression): Add "tracker" parameter.
10176         (parse_expression_for_completion): Update.
10177         (null_post_parser): Add "tracker" parameter.
10178         * p-exp.y: Update rules.
10179         * m2-exp.y: Update rules.
10180         * language.h (struct language_defn) <la_post_parser>: Add
10181         "tracker" parameter.
10182         * go-exp.y: Update rules.
10183         * f-exp.y: Update rules.
10184         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10185         parameter.
10186         * d-exp.y: Update rules.
10187         * c-exp.y: Update rules.
10188         * breakpoint.c (set_breakpoint_condition): Create an
10189         innermost_block_tracker.
10190         (watch_command_1): Likewise.
10191         * ada-lang.c (resolve): Add "tracker" parameter.
10192         (resolve_subexp): Likewise.
10193         * ada-exp.y (write_var_from_sym): Update.
10194
10195 2019-04-04  Tom Tromey  <tom@tromey.com>
10196
10197         * type-stack.h: New file.
10198         * type-stack.c: New file.
10199         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10200         type-stack.h.
10201         (insert_into_type_stack, insert_type, push_type, push_type_int)
10202         (insert_type_address_space, pop_type, pop_type_int)
10203         (pop_typelist, pop_type_stack, append_type_stack)
10204         (push_type_stack, get_type_stack, push_typelist)
10205         (follow_type_instance_flags, follow_types): Don't declare.
10206         * parse.c (type_stack): Remove global.
10207         (parse_exp_in_context): Update.
10208         (insert_into_type_stack, insert_type, push_type, push_type_int)
10209         (insert_type_address_space, pop_type, pop_type_int)
10210         (pop_typelist, pop_type_stack, append_type_stack)
10211         (push_type_stack, get_type_stack, push_typelist)
10212         (follow_type_instance_flags, follow_types): Remove (moved to
10213         type-stack.c).
10214         * f-exp.y (type_stack): New global.
10215         Update rules.
10216         (push_kind_type, f_parse): Update.
10217         * d-exp.y (type_stack): New global.
10218         Update rules.
10219         (d_parse): Update.
10220         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10221         Update rules.
10222         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10223         (HFILES_NO_SRCDIR): Add type-stack.h.
10224
10225 2019-04-04  Tom Tromey  <tom@tromey.com>
10226
10227         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10228         (rust_parser::convert_ast_to_expression, rust_parse)
10229         (rust_lex_test_completion, rust_lex_tests): Update.
10230         * parser-defs.h (struct expr_completion_state): New.
10231         (struct parser_state) <parser_state>: Add completion parameter.
10232         <mark_struct_expression, mark_completion_tag>: New methods.
10233         <parse_completion, m_completion_state>: New members.
10234         (prefixify_expression, null_post_parser): Update.
10235         (mark_struct_expression, mark_completion_tag): Don't declare.
10236         * parse.c (parse_completion, expout_last_struct)
10237         (expout_tag_completion_type, expout_completion_name): Remove
10238         globals.
10239         (parser_state::mark_struct_expression)
10240         (parser_state::mark_completion_tag): Now methods.
10241         (prefixify_expression): Add last_struct parameter.
10242         (prefixify_subexp): Likewise.
10243         (parse_exp_1): Update.
10244         (parse_exp_in_context): Add cstate parameter.  Update.
10245         (parse_expression_for_completion): Create an
10246         expr_completion_state.
10247         (null_post_parser): Add "completion" parameter.
10248         * p-exp.y: Update rules.
10249         (yylex): Update.
10250         * language.h (struct language_defn) <la_post_parser>: Add
10251         "completing" parameter.
10252         * go-exp.y: Update rules.
10253         (lex_one_token): Update.
10254         * expression.h (parse_completion): Don't declare.
10255         * d-exp.y: Update rules.
10256         (lex_one_token): Update rules.
10257         * c-exp.y: Update rules.
10258         (lex_one_token): Update.
10259         * ada-lang.c (resolve): Add "parse_completion" parameter.
10260         (resolve_subexp): Likewise.
10261         (ada_resolve_function): Likewise.
10262
10263 2019-04-04  Tom Tromey  <tom@tromey.com>
10264
10265         * parser-defs.h (struct parser_state) <start_arglist,
10266         end_arglist>: New methods.
10267         <arglist_len, m_funcall_chain>: New members.
10268         (arglist_len, start_arglist, end_arglist): Don't declare.
10269         * parse.c (arglist_len, funcall_chain): Remove global.
10270         (start_arglist, end_arglist): Remove functions.
10271         (parse_exp_in_context): Update.
10272         * p-exp.y: Update rules.
10273         * m2-exp.y: Update rules.
10274         * go-exp.y: Update rules.
10275         * f-exp.y: Update rules.
10276         * d-exp.y: Update rules.
10277         * c-exp.y: Update rules.
10278
10279 2019-04-04  Tom Tromey  <tom@tromey.com>
10280
10281         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10282         lex_operator, push_back>: New methods.
10283         Update all rules.
10284         (rust_parser::lex_hex, lex_escape): Rename and update.
10285         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10286         (rust_parser::lex_operator): Rename and update.
10287         (rust_parser::lex_number, rustyylex, rustyyerror)
10288         (rust_lex_test_init, rust_lex_test_sequence)
10289         (rust_lex_test_push_back, rust_lex_tests): Update.
10290         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10291         parameter.
10292         <lexptr, prev_lexptr>: New members.
10293         (lexptr, prev_lexptr): Don't declare.
10294         * parse.c (lexptr, prev_lexptr): Remove globals.
10295         (parse_exp_in_context): Update.
10296         * p-exp.y (yylex, yyerror): Update.
10297         * m2-exp.y (parse_number, yylex, yyerror): Update.
10298         * go-exp.y (lex_one_token, yyerror): Update.
10299         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10300         * d-exp.y (lex_one_token, yyerror): Update.
10301         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10302         (lex_one_token, yyerror): Update.
10303         * ada-lex.l (YY_INPUT): Update.
10304         (rewind_to_char): Update.
10305         * ada-exp.y (yyerror): Update.
10306
10307 2019-04-04  Tom Tromey  <tom@tromey.com>
10308
10309         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10310         * parser-defs.h (struct parser_state) <parser_state>: Add new
10311         parameter.
10312         <comma_terminates>: New member.
10313         (comma_terminates): Don't declare global.
10314         * parse.c (comma_terminates): Remove global.
10315         (parse_exp_in_context): Update.
10316         * p-exp.y (yylex): Update.
10317         * m2-exp.y (yylex): Update.
10318         * go-exp.y (lex_one_token): Update.
10319         * f-exp.y (yylex): Update.
10320         * d-exp.y (lex_one_token): Update.
10321         * c-exp.y (lex_one_token): Update.
10322         * ada-lex.l: Update.
10323
10324 2019-04-04  Tom Tromey  <tom@tromey.com>
10325
10326         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10327         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10328         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10329         * parser-defs.h (paren_depth): Don't declare.
10330         * parse.c (paren_depth): Remove global.
10331         (parse_exp_in_context): Update.
10332         * p-exp.y (paren_depth): New global.
10333         (pascal_parse): Initialize it.
10334         * m2-exp.y (paren_depth): New global.
10335         (m2_parse): Initialize it.
10336         * go-exp.y (paren_depth): New global.
10337         (go_parse): Initialize it.
10338         * f-exp.y (paren_depth): New global.
10339         (f_parse): Initialize it.
10340         * d-exp.y (paren_depth): New global.
10341         (d_parse): Initialize it.
10342         * c-exp.y (paren_depth): New global.
10343         (c_parse): Initialize it.
10344         * ada-lex.l (paren_depth): New global.
10345         (lexer_init): Initialize it.
10346
10347 2019-04-04  Tom Tromey  <tom@tromey.com>
10348
10349         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10350         (rust_parser::convert_ast_to_type)
10351         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10352         * parser-defs.h (struct parser_state) <parser_state>: Add
10353         parameters.  Initialize new members.
10354         <expression_context_block, expression_context_pc>: New members.
10355         * parse.c (expression_context_block, expression_context_pc):
10356         Remove globals.
10357         (parse_exp_in_context): Update.
10358         * p-exp.y: Update all rules.
10359         (yylex): Update.
10360         * m2-exp.y: Update all rules.
10361         (yylex): Update.
10362         * go-exp.y (yylex): Update.
10363         * f-exp.y (yylex): Update.
10364         * d-exp.y: Update all rules.
10365         (yylex): Update.
10366         * c-exp.y: Update all rules.
10367         (lex_one_token, classify_name, yylex, c_parse): Update.
10368         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10369
10370 2019-04-04  Tom Tromey  <tom@tromey.com>
10371
10372         * gdbarch.h, gdbarch.c: Rebuild.
10373         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10374         * stap-probe.h:
10375         (struct stap_parse_info): Replace "parser_state" with
10376         "expr_builder".
10377         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10378         (parser_state): New class.
10379         * parse.c (expr_builder): Rename.
10380         (expr_builder::release): Rename.
10381         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10382         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10383         (write_exp_elt_longcst, write_exp_elt_floatcst)
10384         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10385         (write_exp_string_vector, write_exp_bitstring)
10386         (write_exp_msymbol, mark_struct_expression)
10387         (write_dollar_variable)
10388         (insert_type_address_space, increase_expout_size): Replace
10389         "parser_state" with "expr_builder".
10390         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10391         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10392         "parser_state" with "expr_builder".
10393
10394 2019-04-04  Tom Tromey  <tom@tromey.com>
10395
10396         * rust-exp.y: Replace "parse_language" with method call.
10397         * p-exp.y:
10398         (yylex): Replace "parse_language" with method call.
10399         * m2-exp.y:
10400         (yylex): Replace "parse_language" with method call.
10401         * go-exp.y (classify_name): Replace "parse_language" with method
10402         call.
10403         * f-exp.y (yylex): Replace "parse_language" with method call.
10404         * d-exp.y (lex_one_token): Replace "parse_language" with method
10405         call.
10406         * c-exp.y:
10407         (lex_one_token, classify_name, yylex): Replace "parse_language"
10408         with method call.
10409         * ada-exp.y (find_primitive_type, type_char)
10410         (type_system_address): Replace "parse_language" with method call.
10411
10412 2019-04-04  Tom Tromey  <tom@tromey.com>
10413
10414         * rust-exp.y: Replace "parse_gdbarch" with method call.
10415         * parse.c (write_dollar_variable, insert_type_address_space):
10416         Replace "parse_gdbarch" with method call.
10417         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10418         call.
10419         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10420         call.
10421         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10422         "parse_gdbarch" with method call.
10423         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10424         with method call.
10425         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10426         "parse_gdbarch" with method call.
10427         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10428         "parse_gdbarch" with method call.
10429         * c-exp.y (parse_type, parse_number, classify_name): Replace
10430         "parse_gdbarch" with method call.
10431         * ada-lex.l: Replace "parse_gdbarch" with method call.
10432         * ada-exp.y (parse_type, find_primitive_type, type_char)
10433         (type_system_address): Replace "parse_gdbarch" with method call.
10434
10435 2019-04-04  Tom Tromey  <tom@tromey.com>
10436
10437         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10438         * stap-probe.c (stap_parse_argument): Update.
10439         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10440         initial_size parameter.
10441         * rust-exp.y (rust_lex_tests): Update.
10442         * parse.c (parser_state): Update.
10443         (parse_exp_in_context): Update.
10444         * parser-defs.h (struct parser_state) <parser_state>: Remove
10445         "initial_size" parameter.
10446
10447 2019-04-04  Tom Tromey  <tom@tromey.com>
10448
10449         * parser-defs.h (increase_expout_size): Don't declare.
10450         * parse.c (increase_expout_size): Now static.
10451
10452 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10453
10454         * gnu-nat.c (gnu_nat_target::wait): Fix
10455         target_waitstatus_to_string call.
10456
10457 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10458
10459         * eval.c (evaluate_subexp_standard): Handle internal functions
10460         during Fortran function call handling.
10461
10462 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10463
10464         * NEWS: Mention new internal functions.
10465         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10466         (read_base_type): Use dwarf2_init_complex_target_type.
10467         * value.c (creal_internal_fn): New function.
10468         (cimag_internal_fn): New function.
10469         (_initialize_values): Register new internal functions.
10470
10471 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10472
10473         * infrun.c (stop_all_threads): If debug_infrun, always
10474         trace the wait status after wait_one, using
10475         target_waitstatus_to_string and target_pid_to_str.
10476         (handle_inferior_event): Replace various trace of
10477         wait status kind by a single trace.
10478         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10479         wait status kind image by target_waitstatus_to_string.
10480         * target/waitstatus.c (target_waitstatus_to_string): Fix
10481         obsolete comment.
10482
10483 2019-04-01  Tom Tromey  <tromey@adacore.com>
10484
10485         PR symtab/23331:
10486         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10487
10488 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10489             Pedro Alves  <palves@redhat.com>
10490
10491         * top.c (quit_force): Call 'finalize_values'.
10492         * value.c (finalize_values): New function.
10493         * value.h (finalize_values): Declare.
10494
10495 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10496
10497         * NEWS: Announce $_gdb_major and $_gdb_minor.
10498
10499         * top.c (init_gdb_version_vars): New function.
10500         (gdb_init): Call init_gdb_version_vars.
10501
10502 2019-03-29  Tom Tromey  <tromey@adacore.com>
10503
10504         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10505         help text.  Remove dead code.
10506
10507 2019-03-29  Keith Seitz  <keiths@redhat.com>
10508
10509         From Siddhesh Poyarekar:
10510         * f-lang.h (f77_get_upperbound): Return LONGEST.
10511         (f77_get_lowerbound): Likewise.
10512         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10513         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10514         print them.
10515         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10516         plongest to format print it.
10517         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10518         (f77_get_upperbound): Likewise.
10519         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10520         LOWER_BOUND to LONGEST.
10521         (f77_create_arrayprint_offset_tbl): Likewise.
10522
10523 2019-03-29  Keith Seitz  <keiths@redhat.com>
10524
10525         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10526         %s/pulongest for TYPE_LENGTH instead of %d in format
10527         strings.
10528         * ada-typerint.c (ada_print_type): Likewise.
10529         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10530         * compile/compile-c-support.c (generate_register_struct): Likewise.
10531         * gdbtypes.c (recursive_dump_type): Likewise.
10532         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10533         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10534         instead of %d in format strings.
10535         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10536         to std::min to ULONGEST.
10537         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10538         instead of %d in format strings.
10539         * tracepoint.c (info_scope_command): Likewise.
10540         * typeprint.c (print_offset_data::update)
10541         (print_offset_data::finish): Likewise.
10542         * xtensa-tdep.c (xtensa_store_return_value)
10543         (xtensa_push_dummy_call): Likewise.
10544
10545 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10546
10547         * windows-nat.c (display_selector): Fixed format specifications
10548         for 64-bit Cygwin.
10549
10550 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10551
10552         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10553
10554 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10555
10556         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10557         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10558         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10559         (nios2_linux_init_abi): Install it.
10560
10561 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10562
10563         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10564
10565 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10566
10567         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10568
10569 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10570             Tom Tromey  <tromey@adacore.com>
10571
10572         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10573
10574 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10575
10576         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10577         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10578         method to compute the bounds of range types. Also print "[evaluated]"
10579         if the bounds' values come from a dynamic evaluation.
10580
10581 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10582
10583         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10584         whitespace when pretty printing is on.
10585
10586 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10587
10588         * ppc-linux-nat.c: Add include.
10589
10590 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10591
10592         * NEWS: Mention AArch64 Pointer Authentication.
10593
10594 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10595
10596         * arm-linux-nat.c: Add include.
10597
10598 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10599
10600         * source-cache.c (source_cache::get_source_lines): Re-read
10601         fullname after calling open_source_file.
10602
10603 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10604
10605         * NEWS: Mention TLS support for FreeBSD.
10606
10607 2019-03-25  Tom Tromey  <tromey@adacore.com>
10608
10609         * minsyms.c (BUNCH_SIZE): Update comment.
10610         (~minimal_symbol_reader): Remove old comment.
10611         (compact_minimal_symbols): Update comment.
10612         (minimal_symbol_reader::install): Remove old comment.  Update
10613         other comments.
10614
10615 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10616
10617         * s390-linux-nat.c: Add include.
10618
10619 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10620
10621         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10622         Call linux_get_hwcap.
10623         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10624         Likewise.
10625         (aarch64_linux_get_hwcap): Remove function.
10626         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10627         declaration.
10628         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10629         linux_get_hwcap.
10630         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10631         * linux-tdep.c (linux_get_hwcap): Add function.
10632         (linux_get_hwcap2): Likewise.
10633         * linux-tdep.h (linux_get_hwcap): Add declaration.
10634         (linux_get_hwcap2): Likewise.
10635         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10636         (ppc_linux_get_hwcap2): Likewise.
10637         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10638         linux_get_hwcap.
10639         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10640         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10641         (ppc_linux_nat_target::read_description): Likewise.
10642         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10643         * s390-linux-nat.c: Likewise.
10644         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10645
10646 2019-03-24  Tom Tromey  <tom@tromey.com>
10647
10648         * ada-lang.c (standard_lookup): Simplify initialization.
10649         (ada_lookup_symbol_nonlocal): Simplify return.
10650         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10651         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10652         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10653         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10654         initialization.
10655         * solib.c (solib_global_lookup): Simplify.
10656         * symtab.c (null_block_symbol): Remove.
10657         (symbol_cache_lookup): Simplify returns.
10658         (lookup_language_this): Simplify returns.
10659         (lookup_symbol_aux): Simplify return.
10660         (lookup_local_symbol): Simplify returns.
10661         (lookup_global_symbol_from_objfile): Simplify return.
10662         (lookup_symbol_in_objfile_symtabs)
10663         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10664         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10665         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10666         * cp-namespace.c (cp_lookup_bare_symbol)
10667         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10668         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10669         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10670         (cp_lookup_symbol_via_imports): Simplify initialization.
10671         (find_symbol_in_baseclass): Likewise.
10672         * symtab.h (null_block_symbol): Remove.
10673         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10674         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10675         (d_lookup_symbol_module): Likewise.
10676         (find_symbol_in_baseclass): Simplify initialization.
10677
10678 2019-03-24  Tom Tromey  <tom@tromey.com>
10679
10680         * expression.h: Don't include symtab.h.
10681         (struct block): Forward declare.
10682
10683 2019-03-24  Tom Tromey  <tom@tromey.com>
10684
10685         * c-exp.y (typebase): Remove casts.
10686         * gdbtypes.c (lookup_unsigned_typename, )
10687         (lookup_signed_typename): Remove cast.
10688         * eval.c (parse_to_comma_and_eval): Remove cast.
10689         * parse.c (write_dollar_variable): Remove cast.
10690         * block.h (struct block) <superblock>: Now const.
10691         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10692         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10693         (map_block): Make "block" const.
10694         * symfile.h (struct quick_symbol_functions)
10695         <map_matching_symbols>: Constify block argument to "callback".
10696         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10697         const.
10698         (find_pc_sect_compunit_symtab): Make "b" const.
10699         (find_symbol_at_address): Likewise.
10700         (search_symbols): Likewise.
10701         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10702         (dw2_debug_names_lookup_symbol): Likewise.
10703         (dw2_map_matching_symbols): Update.
10704         * p-valprint.c (pascal_val_print): Remove "block".
10705         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10706         (aux_add_nonlocal_symbols): Make "block" const.
10707         (resolve_subexp): Remove cast.
10708         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10709         const.
10710         (iterate_over_file_blocks): Likewise.
10711         * f-exp.y (%union) <bval>: Remove.
10712         * coffread.c (patch_opaque_types): Make "b" const.
10713         * spu-tdep.c (spu_catch_start): Make "block" const.
10714         * c-valprint.c (print_unpacked_pointer): Remove "block".
10715         * symmisc.c (dump_symtab_1): Make "b" const.
10716         (block_depth): Make "block" const.
10717         * d-exp.y (%union) <bval>: Remove.
10718         * cp-support.h (cp_lookup_rtti_type): Update.
10719         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10720         * psymtab.c (psym_lookup_symbol): Make "block" const.
10721         (maintenance_check_psymtabs): Make "b" const.
10722         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10723         (enumerate_locals, enumerate_args): Update.
10724         * python/py-symtab.c (stpy_global_block): Make "block" const.
10725         (stpy_static_block): Likewise.
10726         * inline-frame.c (block_starting_point_at): Make "new_block"
10727         const.
10728         * block.c (find_block_in_blockvector): Make return type const.
10729         (blockvector_for_pc_sect): Make "b" const.
10730         (find_block_in_blockvector): Make "b" const.
10731
10732 2019-03-23  Tom Tromey  <tom@tromey.com>
10733
10734         * varobj.c (varobj_create): Update.
10735         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10736         * printcmd.c (display_command, do_one_display): Don't reset
10737         innermost_block.
10738         * parser-defs.h (enum innermost_block_tracker_type): Move to
10739         expression.h.
10740         (innermost_block): Update comment.
10741         * parse.c (parse_exp_1): Add tracker_types parameter.
10742         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10743         tracker_types parameter.  Reset innermost_block.
10744         (parse_exp_in_context): Remove.
10745         (parse_expression_for_completion): Update.
10746         * objfiles.c (~objfile): Don't reset expression_context_block or
10747         innermost_block.
10748         * expression.h (enum innermost_block_tracker_type): Move from
10749         parser-defs.h.
10750         (parse_exp_1): Add tracker_types parameter.
10751         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10752         reset innermost_block.
10753
10754 2019-03-23  Tom Tromey  <tom@tromey.com>
10755
10756         * objfiles.h: Include bcache.h.
10757
10758 2019-03-23  Tom Tromey  <tom@tromey.com>
10759
10760         * linespec.c (get_current_search_block): Use
10761         scoped_restore_current_language.
10762         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10763
10764 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10765             Jiong Wang  <jiong.wang@arm.com>
10766
10767         * aarch64-linux-tdep.c
10768         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10769         section.
10770         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10771
10772 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10773             Jiong Wang  <jiong.wang@arm.com>
10774
10775         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10776         instructions.
10777         (aarch64_analyze_prologue_test): Add PACIASP test.
10778         (aarch64_prologue_prev_register): Unmask PC value.
10779
10780 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10781             Jiong Wang  <jiong.wang@arm.com>
10782
10783         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10784         (aarch64_dwarf2_prev_register): Unmask PC value.
10785         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10786         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10787         DW_CFA_AARCH64_negate_ra_state.
10788         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10789
10790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10791             Jiong Wang  <jiong.wang@arm.com>
10792
10793         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10794         registers.
10795         (aarch64_pseudo_register_name): Likewise.
10796         (aarch64_pseudo_register_type): Likewise.
10797         (aarch64_pseudo_register_reggroup_p): Likewise.
10798         (aarch64_gdbarch_init): Add pauth registers.
10799         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10800         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10801         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10802         (struct gdbarch_tdep): Add regnum for ra_state.
10803
10804 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10805             Jiong Wang  <jiong.wang@arm.com>
10806
10807         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10808
10809 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10810             Jiong Wang  <jiong.wang@arm.com>
10811
10812         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10813         function.
10814         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10815         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10816         (aarch64_gdbarch_init): Add puth registers.
10817         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10818         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10819         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10820
10821 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10822             Jiong Wang  <jiong.wang@arm.com>
10823
10824         * aarch64-linux-nat.c
10825         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10826         * aarch64-linux-tdep.c
10827         (aarch64_linux_core_read_description): Likewise.
10828         (aarch64_linux_get_hwcap): New function.
10829         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10830         (aarch64_linux_get_hwcap): New declaration.
10831
10832 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10833             Jiong Wang  <jiong.wang@arm.com>
10834
10835         * aarch64-linux-nat.c
10836         (aarch64_linux_nat_target::read_description): Add pauth param.
10837         * aarch64-linux-tdep.c
10838         (aarch64_linux_core_read_description): Likewise.
10839         * aarch64-tdep.c (struct target_desc): Add in pauth.
10840         (aarch64_read_description): Add pauth param.
10841         (aarch64_gdbarch_init): Likewise.
10842         * aarch64-tdep.h (aarch64_read_description): Likewise.
10843         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10844         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10845         * features/Makefile: Add new files.
10846         * features/aarch64-pauth.c: New file.
10847         * features/aarch64-pauth.xml: New file.
10848
10849 2019-03-20  Tom Tromey  <tromey@adacore.com>
10850
10851         * infrun.c (handle_inferior_event): Rename from
10852         handle_inferior_event_1.  Create a scoped_value_mark.
10853         (handle_inferior_event): Remove.
10854
10855 2019-03-19  Tom Tromey  <tromey@adacore.com>
10856
10857         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10858         * infrun.h (print_stop_event): Add "displays" parameter.
10859         * infrun.c (print_stop_event): Add "displays" parameter.
10860
10861 2019-03-19  Pedro Alves  <palves@redhat.com>
10862
10863         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10864         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10865         to -1.  Fix TABs vs spaces.
10866         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10867         * tui/tui-out.h (tui_ui_out) Add intro comments.
10868         <m_line, m_start_of_line>: In-class initialize, and add describing
10869         comment.
10870
10871 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10872
10873         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10874         variable names.
10875         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10876
10877 2019-03-18  Pedro Alves  <palves@redhat.com>
10878             Eli Zaretskii <eliz@gnu.org>
10879
10880         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10881         m_line and m_start_of_line.
10882
10883 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10884
10885         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10886         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10887         it returns a newline.  This fixes a regression in TU mode, whereby
10888         the next line is output on the same screen line as the user input.
10889
10890 2019-03-18  Tom Tromey  <tromey@adacore.com>
10891
10892         * minsyms.c (minimal_symbol_reader::install): Remove call to
10893         obstack_blank.
10894
10895 2019-03-18  Pedro Alves  <palves@redhat.com>
10896
10897         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10898         New globals.
10899         (apply_style): New, factored out from ...
10900         (apply_ansi_escape): ... this.  Handle reverse video mode.
10901         (tui_set_reverse_mode): New function.
10902         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10903         * tui/tui-winsource.c (tui_show_source_line): Use
10904         tui_set_reverse_mode instead of setting A_STANDOUT.
10905         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10906         New setter methods.
10907
10908 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10909
10910         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10911         Handle tabs.
10912
10913 2019-03-18  Tom Tromey  <tromey@adacore.com>
10914
10915         * ada-lang.c (empty_array): Add "high" parameter.
10916         (ada_evaluate_subexp): Update.
10917
10918 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10919
10920         * unittests/string_view-selftests.c: Define
10921         _initialize_string_view_selftests unconditionally.
10922
10923 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10924
10925         PR gdb/24350
10926         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10927
10928 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10929
10930         PR gdb/24351
10931         * windows-nat.c (display_selector): Fix format specifiers.
10932
10933 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10934
10935         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10936         tui_refill_source_window instead of tui_refresh_win, to update the
10937         current execution line.  This fixes redisplay of the current line
10938         when stepping through the code with "next" or "step".
10939
10940 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10941
10942         * source-cache.c (source_cache::get_source_lines): Call
10943         find_source_lines to initialize s->nlines.  This fixes vertical
10944         scrolling of TUI source window when the DOWN arrow is pressed.
10945
10946 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10947
10948         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10949         linux-thread-db.c (_initialize_thread_db): Likewise.
10950
10951 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10952
10953         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10954         wclrtoeol in tui_show_source_line".  This reverts changes made in
10955         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10956
10957 2019-03-15  Tom Tromey  <tom@tromey.com>
10958
10959         * symtab.h (struct minimal_symbol): Derive from
10960         general_symbol_info.
10961         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10962         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10963         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10964         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10965         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10966         (MSYMBOL_SEARCH_NAME): Update.
10967         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10968         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10969         * minsyms.c (minimal_symbol_reader::record_full): Update.
10970
10971 2019-03-15  Tom Tromey  <tom@tromey.com>
10972
10973         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10974
10975 2019-03-15  Tom Tromey  <tom@tromey.com>
10976
10977         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10978         unique_xmalloc_ptr.
10979         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10980         Update.
10981         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10982         (build_minimal_symbol_hash_tables)
10983         (minimal_symbol_reader::install): Update.
10984
10985 2019-03-15  Tom Tromey  <tom@tromey.com>
10986
10987         * symtab.c (create_demangled_names_hash): Update.
10988         (symbol_set_names): Update.
10989         * objfiles.h (struct objfile_per_bfd_storage)
10990         <demangled_names_hash>: Now an htab_up.
10991         * objfiles.c (objfile_per_bfd_storage): Simplify.
10992
10993 2019-03-15  Tom Tromey  <tom@tromey.com>
10994
10995         * objfiles.h (struct objfile_per_bfd_storage): Declare
10996         destructor.
10997         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10998         New.
10999         (get_objfile_bfd_data): Use new.  Don't initialize
11000         language_of_main.
11001         (free_objfile_per_bfd_storage): Remove.
11002         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11003
11004 2019-03-15  Tom Tromey  <tom@tromey.com>
11005
11006         * symfile.c (reread_symbols): Update.
11007         * objfiles.c (objfile::objfile): Update.
11008         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11009         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11010         comment.
11011         (minimal_symbol_reader::install): Update.
11012         (terminate_minimal_symbol_table): Remove.
11013         * jit.c (jit_object_close_impl): Update.
11014
11015 2019-03-15  Tom Tromey  <tom@tromey.com>
11016
11017         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11018         initializations.
11019
11020 2019-03-15  Tom Tromey  <tom@tromey.com>
11021
11022         * objfiles.h (struct objfile_per_bfd_storage)
11023         <demangled_hash_languages>: Now a bitset.
11024         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11025         (lookup_minimal_symbol): Update.
11026
11027 2019-03-15  Tom Tromey  <tom@tromey.com>
11028
11029         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11030         Don't return the symbol.
11031         * coffread.c (record_minimal_symbol): Use record_full.
11032
11033 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11034
11035         The MS-Windows port of ncurses fails to switch to a color pair if
11036         one or both of the colors are the implicit default colors.  This
11037         change records the default colors when TUI is initialized, and
11038         then specifies them explicitly when a color pair uses the default
11039         colors.  This allows color styling in TUI mode on MS-Windows.
11040
11041         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11042         ncurses_norm_attr.
11043         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11044         colors in ncurses_norm_attr.
11045         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11046         "none", replace it with the default color recorded in
11047         ncurses_norm_attr.
11048
11049 2019-03-14  Tom Tromey  <tromey@adacore.com>
11050
11051         * source-cache.h (class source_cache) <get_source_lines>: Return
11052         std::string.
11053         * source-cache.c (source_cache::extract_lines): Handle case where
11054         first_pos==npos.  Return std::string.
11055         (source_cache::get_source_lines): Update.
11056
11057 2019-03-14  Tom Tromey  <tromey@adacore.com>
11058
11059         * NEWS: Add item for "style sources" commands.
11060         * source-cache.c (source_cache::get_source_lines): Check
11061         source_styling.
11062         * cli/cli-style.c (source_styling): New global.
11063         (_initialize_cli_style): Add "style sources" commands.
11064         (show_style_sources): New function.
11065         * cli/cli-style.h (source_styling): Declare.
11066
11067 2019-03-14  Pedro Alves  <palves@redhat.com>
11068             Tom Tromey  <tromey@adacore.com>
11069
11070         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11071         * tui/tui-winsource.c (tui_refill_source_window): New function,
11072         from...
11073         (tui_horizontal_source_scroll): ... here.  Move some logic.
11074         * cli/cli-style.c (set_style_enabled): Notify new observable.
11075         * tui/tui-hooks.c (tui_redisplay_source): New function.
11076         (tui_attach_detach_observers): Attach or detach
11077         tui_redisplay_source.
11078         * observable.h (source_styling_changed): New observable.
11079         * observable.c: Define source_styling_changed observable.
11080
11081 2019-03-13  Tom Tromey  <tromey@adacore.com>
11082
11083         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11084         (i386_gnu_nat_target::store_registers): Update.
11085         * target-debug.h (target_debug_print_std_string): New macro.
11086         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11087         * windows-tdep.c (display_one_tib): Update.
11088         * tui/tui-stack.c (tui_make_status_line): Update.
11089         * top.c (print_inferior_quit_action): Update.
11090         * thread.c (thr_try_catch_cmd): Update.
11091         (add_thread_with_info): Update.
11092         (thread_target_id_str): Update.
11093         (thr_try_catch_cmd): Update.
11094         (thread_command): Update.
11095         (thread_find_command): Update.
11096         * record-btrace.c (record_btrace_target::info_record)
11097         (record_btrace_resume_thread, record_btrace_target::resume)
11098         (record_btrace_cancel_resume, record_btrace_step_thread)
11099         (record_btrace_target::wait, record_btrace_target::wait)
11100         (record_btrace_target::wait, record_btrace_target::stop): Update.
11101         * progspace.c (print_program_space): Update.
11102         * process-stratum-target.c
11103         (process_stratum_target::thread_address_space): Update.
11104         * linux-fork.c (linux_fork_mourn_inferior)
11105         (detach_checkpoint_command, info_checkpoints_command)
11106         (linux_fork_context): Update.
11107         (linux_fork_detach): Update.
11108         (class scoped_switch_fork_info): Update.
11109         (delete_checkpoint_command): Update.
11110         * infrun.c (follow_fork_inferior): Update.
11111         (follow_fork_inferior): Update.
11112         (proceed_after_vfork_done): Update.
11113         (handle_vfork_child_exec_or_exit): Update.
11114         (follow_exec): Update.
11115         (displaced_step_prepare_throw): Update.
11116         (displaced_step_restore): Update.
11117         (start_step_over): Update.
11118         (resume_1): Update.
11119         (clear_proceed_status_thread): Update.
11120         (proceed): Update.
11121         (print_target_wait_results): Update.
11122         (do_target_wait): Update.
11123         (context_switch): Update.
11124         (stop_all_threads): Update.
11125         (restart_threads): Update.
11126         (finish_step_over): Update.
11127         (handle_signal_stop): Update.
11128         (switch_back_to_stepped_thread): Update.
11129         (keep_going_pass_signal): Update.
11130         (print_exited_reason): Update.
11131         (normal_stop): Update.
11132         * inferior.c (inferior_pid_to_str): Change return type.
11133         (print_selected_inferior): Update.
11134         (add_inferior): Update.
11135         (detach_inferior): Update.
11136         * dummy-frame.c (fprint_dummy_frames): Update.
11137         * dcache.c (dcache_info_1): Update.
11138         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11139         (btrace_fetch, btrace_clear): Update.
11140         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11141         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11142         type.
11143         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11144         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11145         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11146         * gdbarch.c, gdbarch.h: Rebuild.
11147         * gdbarch.sh (core_pid_to_str): Change return type.
11148         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11149         return type.
11150         (windows_nat_target::pid_to_str): Change return type.
11151         (windows_delete_thread): Update.
11152         (windows_nat_target::attach): Update.
11153         (windows_nat_target::files_info): Update.
11154         * target-delegates.c: Rebuild.
11155         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11156         return type.
11157         (sol_thread_target::pid_to_str): Change return type.
11158         * remote.c (class remote_target) <pid_to_str>: Change return
11159         type.
11160         (remote_target::pid_to_str): Change return type.
11161         (extended_remote_target::attach, remote_target::remote_stop_ns)
11162         (remote_target::remote_notif_remove_queued_reply)
11163         (remote_target::push_stop_reply, remote_target::disable_btrace):
11164         Update.
11165         (extended_remote_target::attach): Update.
11166         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11167         type.
11168         (gdbsim_target::pid_to_str): Change return type.
11169         * ravenscar-thread.c (struct ravenscar_thread_target)
11170         <pid_to_str>: Change return type.
11171         (ravenscar_thread_target::pid_to_str): Change return type.
11172         * procfs.c (class procfs_target) <pid_to_str>: Change return
11173         type.
11174         (procfs_target::pid_to_str): Change return type.
11175         (procfs_target::attach): Update.
11176         (procfs_target::detach): Update.
11177         (procfs_target::fetch_registers): Update.
11178         (procfs_target::store_registers): Update.
11179         (procfs_target::wait): Update.
11180         (procfs_target::files_info): Update.
11181         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11182         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11183         return type.
11184         (nto_procfs_target::pid_to_str): Change return type.
11185         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11186         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11187         return type.
11188         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11189         (exit_lwp): Update.
11190         (attach_proc_task_lwp_callback, get_detach_signal)
11191         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11192         (linux_nat_target::resume, wait_lwp, stop_callback)
11193         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11194         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11195         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11196         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11197         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11198         type.
11199         (inf_ptrace_target::attach): Update.
11200         (inf_ptrace_target::files_info): Update.
11201         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11202         type.
11203         (go32_nat_target::pid_to_str): Change return type.
11204         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11205         (gnu_nat_target::wait): Update.
11206         (gnu_nat_target::wait): Update.
11207         (gnu_nat_target::resume): Update.
11208         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11209         (fbsd_nat_target::wait): Update.
11210         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11211         type.
11212         (darwin_nat_target::attach): Update.
11213         * corelow.c (class core_target) <pid_to_str>: Change return type.
11214         (core_target::pid_to_str): Change return type.
11215         * target.c (normal_pid_to_str): Change return type.
11216         (default_pid_to_str): Likewise.
11217         (target_pid_to_str): Change return type.
11218         (target_translate_tls_address): Update.
11219         (target_announce_detach): Update.
11220         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11221         return type.
11222         (bsd_uthread_target::pid_to_str): Change return type.
11223         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11224         type.
11225         (bsd_kvm_target::pid_to_str): Change return type.
11226         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11227         return type.
11228         (aix_thread_target::pid_to_str): Change return type.
11229         * target.h (struct target_ops) <pid_to_str>: Change return type.
11230         (target_pid_to_str, normal_pid_to_str): Likewise.
11231         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11232         type.
11233         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11234         type.
11235         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11236         return type.
11237         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11238         type.
11239         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11240         type.
11241         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11242         return type.
11243
11244 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11245
11246         * NEWS: Mention that the new default MI version is 3.  Mention
11247         changes to the output of commands and events that deal with
11248         multi-location breakpoints.
11249         * breakpoint.c: Include "mi/mi-out.h".
11250         (print_one_breakpoint): Change output syntax if using MI version
11251         >= 3.
11252         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11253         New.
11254         (mi_multi_location_breakpoint_output_fixed): New.
11255         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11256         (mi_cmd_fix_multi_location_breakpoint_output): New.
11257         (mi_multi_location_breakpoint_output_fixed): New.
11258         * mi/mi-cmds.c (mi_cmds): Register command
11259         -fix-multi-location-breakpoint-output.
11260         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11261         interpreter "mi".
11262
11263 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11264
11265         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11266         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11267         instantiate mi_ui_out based on interpreter name.
11268         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11269         * mi/mi-main.c (mi_load_progress): Likewise.
11270
11271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11272
11273         * NEWS: Combine separate "New targets" sections for 8.3.
11274
11275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11276
11277         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11278         (ppcfbsd_init_abi): Install gdbarch
11279         "fetch_tls_load_module_address" and "get_thread_local_address"
11280         methods.
11281
11282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11283
11284         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11285         (riscv_fbsd_init_abi): Install gdbarch
11286         "fetch_tls_load_module_address" and "get_thread_local_address"
11287         methods.
11288
11289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11290
11291         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11292         (i386fbsd_init_abi): Install gdbarch
11293         "fetch_tls_load_module_address" and "get_thread_local_address"
11294         methods.
11295
11296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11297
11298         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11299         (amd64fbsd_init_abi): Install gdbarch
11300         "fetch_tls_load_module_address" and "get_thread_local_address"
11301         methods.
11302
11303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11304
11305         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11306         (struct fbsd_pspace_data): New type.
11307         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11308         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11309         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11310         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11311         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11312
11313 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11314
11315         * gdbtypes.c (lookup_struct_elt): New function.
11316         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11317         * gdbtypes.h (struct struct_elt): New type.
11318         (lookup_struct_elt): New prototype.
11319
11320 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11321
11322         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11323         remove disabled code block.
11324
11325 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11326
11327         * gdbarch.sh (get_thread_local_address): New method.
11328         * gdbarch.h, gdbarch.c: Regenerate.
11329         * target.c (target_translate_tls_address): Use
11330         gdbarch_get_thread_local_address if present instead of
11331         target::get_thread_local_address.
11332
11333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11334
11335         * target.h (target::get_thread_local_address): Update comment.
11336
11337 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11338
11339         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11340         objfile->separate_debug_objfile_backlink if not NULL.
11341
11342 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11343
11344         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11345         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11346         (amd64bsd_store_inferior_registers): Likewise.
11347         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11348         Enable segment base registers.
11349         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11350         PT_GETFSBASE and PT_GETGSBASE.
11351         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11352         PT_SETGSBASE.
11353         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11354         segment base registers.
11355         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11356
11357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11358
11359         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11360         Update calls to i386_target_description to add 'segments'
11361         parameter.
11362         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11363         add segment base registers.
11364         * arch/i386.c (i386_create_target_description): Add 'segments'
11365         parameter to enable segment base registers.
11366         * arch/i386.h (i386_create_target_description): Likewise.
11367         * features/i386/32bit-segments.xml: New file.
11368         * features/i386/32bit-segments.c: Generate.
11369         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11370         call to i386_target_description to add 'segments' parameter.
11371         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11372         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11373         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11374         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11375         if feature is present.
11376         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11377         Add 'segments' parameter to call to i386_target_description.
11378         (i386_target_description): Add 'segments' parameter to enable
11379         segment base registers.
11380         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11381         to call to i386_target_description.
11382         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11383         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11384         Define I386_NUM_REGS.
11385         (i386_target_description): Add 'segments' parameter to enable
11386         segment base registers.
11387
11388 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11389
11390         PR/24325
11391         * source-cache.c: #undef open and close, to avoid unresolved
11392         externals during linking.
11393
11394 2019-03-12  Tom Tromey  <tromey@adacore.com>
11395
11396         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11397         const.  Add initializers.
11398         (_initialize_remote): Don't initialize ptid globals.
11399
11400 2019-03-12  Pedro Alves  <palves@redhat.com>
11401
11402         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11403
11404 2019-03-12  Pedro Alves  <palves@redhat.com>
11405
11406         * cp-name-parser.y (main): Remove unused 'len' variable.
11407
11408 2019-03-12  Tom Tromey  <tromey@adacore.com>
11409
11410         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11411         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11412
11413 2019-03-12  Tom Tromey  <tromey@adacore.com>
11414
11415         * linux-nat.c (iterate_over_lwps): Update.
11416         (stop_callback): Remove parameter.
11417         (stop_wait_callback, detach_callback, resume_set_callback)
11418         (select_singlestep_lwp_callback, set_ignore_sigint)
11419         (status_callback, resumed_callback, resume_clear_callback)
11420         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11421         data parameter.
11422         (linux_nat_target::detach, linux_nat_target::resume)
11423         (linux_stop_and_wait_all_lwps, select_event_lwp)
11424         (linux_nat_filter_event, linux_nat_wait_1)
11425         (linux_nat_target::kill, linux_nat_target::stop)
11426         (linux_nat_target::stop): Update.
11427         (linux_nat_resume_callback): Change type.
11428         (resume_stopped_resumed_lwps, count_events_callback)
11429         (select_event_lwp_callback): Likewise.
11430         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11431         * arm-linux-nat.c (struct update_registers_data): Remove.
11432         (update_registers_callback): Change type.
11433         (arm_linux_insert_hw_breakpoint1): Update.
11434         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11435         parameter.
11436         (x86_linux_dr_set_addr): Update.
11437         (x86_linux_dr_set_control): Update.
11438         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11439         (iterate_over_lwps): Use gdb::function_view.
11440         * nat/aarch64-linux-hw-point.c (struct
11441         aarch64_dr_update_callback_param): Remove.
11442         (debug_reg_change_callback): Change type.
11443         (aarch64_notify_debug_reg_change): Update.
11444         * s390-linux-nat.c (s390_refresh_per_info): Update.
11445
11446 2019-03-11  Tom Tromey  <tromey@adacore.com>
11447
11448         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11449         redundant assignment to "this_cu".
11450
11451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11452
11453         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11454
11455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11456
11457         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11458         from...
11459         (rank_one_type): ... this.
11460
11461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11462
11463         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11464         from...
11465         (rank_one_type): ... this.
11466
11467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11468
11469         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11470         from...
11471         (rank_one_type): ... this.
11472
11473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11474
11475         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11476         from...
11477         (rank_one_type): ... this.
11478
11479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11480
11481         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11482         from...
11483         (rank_one_type): ... this.
11484
11485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11486
11487         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11488         from...
11489         (rank_one_type): ... this.
11490
11491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11492
11493         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11494         from...
11495         (rank_one_type): ... this.
11496
11497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11498
11499         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11500         from...
11501         (rank_one_type): ... this.
11502
11503 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11504
11505         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11506         from...
11507         (rank_one_type): ... this.
11508
11509 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11510
11511         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11512         from...
11513         (rank_one_type): ... this.
11514
11515 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11516
11517         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11518         from...
11519         (rank_one_type): ... this.
11520
11521 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11522
11523         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11524         from...
11525         (rank_one_type): ... this.
11526
11527 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11528
11529         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11530         inferior-events' shows the example events.
11531
11532 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11533
11534         Support styling on native MS-Windows console
11535
11536         PR/24315
11537         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11538         on MS-Windows if $TERM is not defined.
11539
11540         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11541
11542         * posix-hdep.c (gdb_console_fputs):
11543         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11544         functions.
11545         * ui-file.h (gdb_console_fputs): Add prototype.
11546
11547         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11548         back to fputs only if the former returns zero.
11549
11550 2019-03-07  Tom Tromey  <tom@tromey.com>
11551
11552         * symmisc.c (print_symbol_bcache_statistics): Update.
11553         (print_objfile_statistics): Update.
11554         * symfile.c (allocate_symtab): Update.
11555         * stabsread.c: Don't include bcache.h.
11556         * psymtab.h (struct psymbol_bcache): Don't declare.
11557         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11558         (psymbol_bcache_init, psymbol_bcache_free)
11559         (psymbol_bcache_get_bcache): Don't declare.
11560         * psymtab.c (struct psymbol_bcache): Remove.
11561         (psymtab_storage::psymtab_storage): Update.
11562         (psymtab_storage::~psymtab_storage): Update.
11563         (psymbol_bcache_init, psymbol_bcache_free)
11564         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11565         (add_psymbol_to_bcache): Update.
11566         (allocate_psymtab): Update.
11567         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11568         macro_cache>: No longer pointers.
11569         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11570         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11571         * macrotab.c (macro_bcache): Update.
11572         * macroexp.c: Don't include bcache.h.
11573         * gdbtypes.c (check_types_worklist): Update.
11574         (types_deeply_equal): Remove TRY/CATCH.  Update.
11575         * elfread.c (elf_symtab_read): Update.
11576         * dwarf2read.c: Don't include bcache.h.
11577         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11578         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11579         (print_bcache_statistics, bcache_memory_used): Don't declare.
11580         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11581         methods.  Rename all data members.
11582         * bcache.c (struct bcache): Move to bcache.h.
11583         (bcache::expand_hash_table): Rename from expand_hash_table.
11584         (bcache): Remove.
11585         (bcache::insert): Rename from bcache_full.
11586         (bcache::compare): Rename from bcache_compare.
11587         (bcache_xmalloc): Remove.
11588         (bcache::~bcache): Rename from bcache_xfree.
11589         (bcache::print_statistics): Rename from print_bcache_statistics.
11590         (bcache::memory_used): Rename from bcache_memory_used.
11591
11592 2019-03-07  Pedro Alves  <palves@redhat.com>
11593
11594         * infrun.c (normal_stop): Also check for
11595         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11596
11597 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11598
11599         * f-lang.c (value_from_host_double): Moved to...
11600         * value.c (value_from_host_double): ...here.
11601         * value.h (value_from_host_double): Declare.
11602         * guile/scm-math.c (vlscm_convert_typed_number): Use
11603         value_from_host_double.
11604         (vlscm_convert_number): Likewise.
11605         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11606         * python/py-value.c (convert_value_from_python): Likewise.
11607
11608 2019-03-06  Tom Tromey  <tom@tromey.com>
11609
11610         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11611
11612 2019-03-06  Tom Tromey  <tom@tromey.com>
11613
11614         * utils.h (free_current_contents): Don't declare.
11615         * utils.c (free_current_contents): Remove.
11616
11617 2019-03-06  Tom Tromey  <tom@tromey.com>
11618
11619         * top.c (quit_force): Update.
11620         * main.c (captured_command_loop): Update.
11621         * common/new-op.c (operator new): Update.
11622         * common/common-exceptions.c (struct catcher)
11623         <save_cleanup_chain>: Remove member.
11624         (exceptions_state_mc_init): Update.
11625         (exception_try_scope_entry): Return nullptr.
11626         (exception_try_scope_exit, exception_rethrow)
11627         (throw_exception_sjlj, throw_exception_cxx): Update.
11628         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11629         (all_cleanups, do_cleanups, discard_cleanups)
11630         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11631         (restore_cleanups, restore_final_cleanups): Don't declare.
11632         (do_final_cleanups): Remove parameter.
11633         * common/cleanups.c (cleanup_chain, make_cleanup)
11634         (make_cleanup_dtor, all_cleanups, do_cleanups)
11635         (discard_my_cleanups, discard_cleanups)
11636         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11637         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11638         (null_cleanup): Remove.
11639         (do_final_cleanups): Remove parameter.
11640
11641 2019-03-06  Tom Tromey  <tom@tromey.com>
11642
11643         * remote.c (remote_target::remote_parse_stop_reply): Use
11644         unique_xmalloc_ptr.
11645
11646 2019-03-06  Tom Tromey  <tom@tromey.com>
11647
11648         * stabsread.c (struct stabs_field_info): Rename from field_info.
11649         <list, fnlist>: Add initializers.
11650         <obstack>: New member.
11651         (read_member_functions, read_struct_fields, read_baseclasses):
11652         Allocate on obstack.  Don't use cleanups.
11653         (read_one_struct_field, read_member_functions, read_struct_fields)
11654         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11655         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11656         (read_struct_type): Update.
11657
11658 2019-03-06  Tom Tromey  <tom@tromey.com>
11659
11660         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11661         * common/filestuff.h (make_cleanup_close): Don't declare.
11662         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11663         Remove.
11664
11665 2019-03-06  Tom Tromey  <tom@tromey.com>
11666
11667         * solib-aix.c: Use make_scope_exit.
11668
11669 2019-03-06  Tom Tromey  <tom@tromey.com>
11670
11671         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11672         Use make_scope_exit.
11673
11674 2019-03-06  Tom Tromey  <tom@tromey.com>
11675
11676         * solib-svr4.c (disable_probes_interface): Remove parameter.
11677         (svr4_handle_solib_event): Use make_scope_exit.
11678
11679 2019-03-06  Tom Tromey  <tom@tromey.com>
11680
11681         * remote.c (struct stop_reply_deleter): Remove.
11682         (stop_reply_up): Update.
11683         (struct stop_reply): Derive from notif_event.  Don't typedef.
11684         <regcache>: Now a std::vector.
11685         (stop_reply_xfree): Remove.
11686         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11687         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11688         (remote_target::discard_pending_stop_replies): Use delete.
11689         (remote_target::remote_parse_stop_reply): Update.
11690         (remote_target::process_stop_reply): Update.
11691         * remote-notif.h (struct notif_event): Add virtual destructor.
11692         Remove "dtr" member.
11693         (struct notif_client) <alloc_event>: Return a unique_ptr.
11694         (notif_event_xfree): Don't declare.
11695         (notif_event_up): New typedef.
11696         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11697         (notif_event_xfree, do_notif_event_xfree): Remove.
11698         (remote_notif_state_xfree): Update.
11699
11700 2019-03-06  Tom Tromey  <tom@tromey.com>
11701
11702         * infrun.c (displaced_step_clear_cleanup): Now a
11703         forward_scope_exit type.
11704         (displaced_step_prepare_throw): Update.
11705         (displaced_step_fixup): Update.
11706
11707 2019-03-06  Tom Tromey  <tom@tromey.com>
11708
11709         * inferior.h (class inferior): Update comment.
11710         * gdbthread.h (class thread_info): Update comment.
11711
11712 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11713             Tom Tromey  <tom@tromey.com>
11714
11715         * stabsread.h (struct stab_section_list): Remove.
11716         (coffstab_build_psymtabs): Update.
11717         * dbxread.c (symbuf_sections): Now a std::vector.
11718         (sect_idx): New global.
11719         (fill_symbuf): Update.
11720         (coffstab_build_psymtabs): Change type of stabsects parameter.
11721         Update.
11722         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11723         std::vector.
11724         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11725         (coff_locate_sections): Update.
11726         (coff_symfile_read): Remove cleanups.  Update.
11727         (init_stringtab): Add storage parameter.
11728         (free_stringtab, free_stringtab_cleanup): Remove.
11729         (init_lineno): Add storage parameter.
11730         (free_linetab, free_linetab_cleanup): Remove.
11731
11732 2019-03-06  Pedro Alves  <palves@redhat.com>
11733
11734         * linux-fork.c (fork_info::clobber_regs): Delete.
11735         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11736         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11737         comment.  Adjust.
11738         (scoped_switch_fork_info::scoped_switch_fork_info)
11739         (checkpoint_command, linux_fork_context): Adjust
11740         fork_save_infrun_state calls.
11741
11742 2019-03-06  Pedro Alves  <palves@redhat.com>
11743
11744         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11745         (inf_has_multiple_threads): Return 'bool' and rewrite using
11746         inferior_info::threads().
11747
11748 2019-03-06  Pedro Alves  <palves@redhat.com>
11749
11750         * linux-fork.c: Include <list>.
11751         (fork_list): Now a std::list instance.
11752         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11753         (forks_exist_p, find_last_fork): Adjust.
11754         (new_fork): Delete.
11755         (one_fork_p): New.
11756         (add_fork): Adjust.
11757         (free_fork): Delete, folded into fork_info::~fork_info().
11758         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11759         Adjust.
11760         (init_fork_list): Delete.
11761         (linux_fork_killall, linux_fork_mourn_inferior)
11762         (linux_fork_detach, info_checkpoints_command): Adjust.
11763         (_initialize_linux_fork): No longer call init_fork_list.
11764
11765 2019-03-06  Pedro Alves  <palves@redhat.com>
11766
11767         * linux-fork.c (new_fork): New, split out of ...
11768         (add_fork): ... this.  Return void.  Move "first fork" special
11769         case from here, to ...
11770         (checkpoint_command): ... here.
11771         * linux-linux.h (add_fork): Return void.
11772
11773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11774
11775         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11776
11777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11778             Chris January  <chris.january@arm.com>
11779             David Lecomber  <david.lecomber@arm.com>
11780
11781         * f-exp.y: New token, UNOP_INTRINSIC.
11782         (exp): New pattern using UNOP_INTRINSIC token.
11783         (f77_keywords): Add 'abs' keyword.
11784         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11785         (value_from_host_double): New function.
11786         (evaluate_subexp_f): Support UNOP_ABS.
11787
11788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11789
11790         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11791         types.
11792
11793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11794
11795         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11796         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11797         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11798
11799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11800
11801         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11802
11803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11804             Chris January  <chris.january@arm.com>
11805
11806         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11807         * f-exp.y: Define 'KIND' token.
11808         (exp): New pattern for KIND expressions.
11809         (ptype): Handle types with a kind extension.
11810         (direct_abs_decl): Extend to spot kind extensions.
11811         (f77_keywords): Add 'kind' to the list.
11812         (push_kind_type): New function.
11813         (convert_to_kind_type): New function.
11814         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11815         * parse.c (operator_length_standard): Likewise.
11816         * parser-defs.h (enum type_pieces): Add tp_kind.
11817         * std-operator.def: Add UNOP_KIND.
11818
11819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11820
11821         * f-exp.y (f_parse): Set yydebug.
11822
11823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11824
11825         * f-lang.c (evaluate_subexp_f): New function.
11826         (exp_descriptor_f): New global.
11827         (f_language_defn): Use exp_descriptor_f instead of
11828         exp_descriptor_standard.
11829
11830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11831
11832         * f-exp.y (struct token): Add comments.
11833         (dot_ops): Remove uppercase versions and the end marker.
11834         (f77_keywords): Likewise.
11835         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11836         entries in the dot_ops array are case insensitive, and use
11837         strncasecmp to compare strings.  Also some whitespace cleanup in
11838         this area.  Similar for the f77_keywords array, except entries in
11839         this list might be case sensitive.
11840
11841 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * f-exp.y (struct f77_boolean_val): Add comments.
11844         (boolean_values): Remove uppercase versions, and end marker.
11845         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11846         and use strncasecmp to achieve case insensitivity.  Additionally,
11847         perform whitespace cleanup around this code.
11848
11849 2019-03-06  Tom Tromey  <tromey@adacore.com>
11850
11851         * remote-sim.c (gdbsim_target_open): Use result of
11852         gdb_argv::release.
11853
11854 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11855         Dirk Schubert  <dirk.schubert@arm.com>
11856         Chris January  <chris.january@arm.com>
11857
11858         * eval.c (evaluate_subexp_standard): Call Fortran argument
11859         wrapping logic.
11860         * f-lang.c (struct value): A value which can be passed into a
11861         Fortran function call.
11862         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11863         where appropriate.
11864         (struct type): Value ready for a Fortran function call.
11865         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11866         is needed.
11867         * f-lang.h (fortran_argument_convert): Declaration.
11868         (fortran_preserve_arg_pointer): Declaration.
11869         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11870
11871 2019-03-05  Tom Tromey  <tromey@adacore.com>
11872
11873         * python/py-prettyprint.c (print_string_repr): Remove #if.
11874         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11875
11876 2019-03-05  Tom Tromey  <tromey@adacore.com>
11877
11878         * target.c (the_dummy_target): Move later.  Change type to
11879         "dummy_target".
11880         (initialize_targets): Don't initialize the_dummy_target.
11881
11882 2019-03-05  Tom Tromey  <tromey@adacore.com>
11883
11884         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11885         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11886
11887 2019-03-05  Tom Tromey  <tromey@adacore.com>
11888
11889         * windows-nat.c (windows_nat_target::attach)
11890         (windows_nat_target::detach): Don't call gdb_flush.
11891         * valprint.c (generic_val_print, val_print, val_print_string):
11892         Don't call gdb_flush.
11893         * utils.c (defaulted_query): Don't call gdb_flush.
11894         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11895         * target.c (target_announce_detach): Don't call gdb_flush.
11896         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11897         * remote.c (extended_remote_target::attach): Don't call
11898         gdb_flush.
11899         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11900         * printcmd.c (do_examine): Don't call gdb_flush.
11901         (info_display_command): Don't call gdb_flush.
11902         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11903         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11904         * memattr.c (info_mem_command): Don't call gdb_flush.
11905         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11906         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11907         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11908         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11909         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11910         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11911         (gnu_nat_target::detach): Don't call gdb_flush.
11912         * f-valprint.c (f_val_print): Don't call gdb_flush.
11913         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11914         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11915         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11916         gdb_flush.
11917         * c-valprint.c (c_val_print): Don't call gdb_flush.
11918         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11919
11920 2019-03-05  Tom Tromey  <tromey@adacore.com>
11921
11922         * varobj.c (update_dynamic_varobj_children): Update.
11923         (install_default_visualizer): Use reset, not release.
11924         * value.c (set_internalvar): Update.
11925         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11926         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11927         ATTRIBUTE_UNUSED_RESULT.
11928
11929 2019-03-05  Tom Tromey  <tromey@adacore.com>
11930
11931         * remote.c (class scoped_remote_fd) <release>: Add
11932         ATTRIBUTE_UNUSED_RESULT.
11933
11934 2019-03-05  Tom Tromey  <tromey@adacore.com>
11935
11936         * macroexp.c (struct macro_buffer) <release>: Add
11937         ATTRIBUTE_UNUSED_RESULT.
11938
11939 2019-03-05  Tom Tromey  <tromey@adacore.com>
11940
11941         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11942         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11943         ATTRIBUTE_UNUSED_RESULT.
11944
11945 2019-03-05  Tom Tromey  <tromey@adacore.com>
11946
11947         * common/scoped_fd.h (class scoped_fd) <release>: Add
11948         ATTRIBUTE_UNUSED_RESULT.
11949
11950 2019-03-05  Tom Tromey  <tromey@adacore.com>
11951
11952         * parser-defs.h (struct parser_state) <release>: Add
11953         ATTRIBUTE_UNUSED_RESULT.
11954
11955 2019-03-05  Tom Tromey  <tromey@adacore.com>
11956
11957         * utils.h (class gdb_argv) <release>: Add
11958         ATTRIBUTE_UNUSED_RESULT.
11959         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11960
11961 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11962
11963         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11964         for-loop range, to avoid compiler warnings.
11965
11966         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11967         avoid compiler warnings about unused variables.
11968
11969         * NEWS: Mention end of support for native debugging on MS-Windows
11970         before XP.
11971
11972         PR gdb/24292
11973         * common/netstuff.c:
11974         * gdbserver/gdbreplay.c
11975         * gdbserver/remote-utils.c:
11976         * ser-tcp.c:
11977         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11978         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11979         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11980         'getaddrinfo' and 'freeaddrinfo' were not available before
11981         Windows XP, and mingw.org's MinGW headers by default define
11982         _WIN32_WINNT to 0x500.
11983
11984 2019-03-01  Gary Benson <gbenson@redhat.com>
11985
11986         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11987
11988 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11989             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11990
11991         PR gdb/8527
11992         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11993         set_sigint_trap, clear_sigint_trap.
11994
11995 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11996
11997         * target.c (target_detach): Clear the regcache and the
11998         frame cache.
11999
12000 2019-02-27  Pedro Alves  <palves@redhat.com>
12001
12002         * utils.c (set_screen_size): When we cap the height/width sizes,
12003         tweak the corresponding command variable to show "unlimited":
12004
12005 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12006             Pedro Alves  <palves@redhat.com>
12007
12008         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12009         before calling rl_set_screen_size.
12010
12011 2019-02-27  Tom Tromey  <tromey@adacore.com>
12012
12013         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12014         define.
12015         * python/py-value.c: Remove Python 2.4 workaround.
12016         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12017         workaround.
12018         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12019         Python 2.4 workaround.
12020         * python/python-internal.h: Remove Python 2.4 comment.
12021         (Py_ssize_t): Don't define.
12022         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12023         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12024         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12025         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12026         * python/python.c (do_start_initialization): Remove Python 2.4
12027         workaround.
12028         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12029         (print_children): Remove Python 2.4 workaround.
12030         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12031         workaround.
12032         (CHARBUFFERPROC_NAME): Remove.
12033         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12034         Python 2.4 workaround.
12035
12036 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12037
12038         * NEWS: Note minimum Python version.
12039
12040 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12041
12042         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12043         code from these functions.  Remove corresponding ifdefs.  Use
12044         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12045         Remove gotos and target of gotos.
12046         (infpy_search_memory): Likewise.
12047
12048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12049
12050         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12051         (hppa_gdbarch_init): Don't register deleted functions with
12052         gdbarch.
12053
12054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12055
12056         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12057         (h8300_unwind_sp): Delete.
12058         (h8300_dummy_id): Delete.
12059         (h8300_gdbarch_init): Don't register deleted functions with
12060         gdbarch.
12061
12062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12063
12064         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12065         (ft32_unwind_pc): Delete.
12066         (ft32_unwind_sp): Delete.
12067         (ft32_gdbarch_init): Don't register deleted functions with
12068         gdbarch.
12069
12070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12071
12072         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12073         (frv_unwind_pc): Delete.
12074         (frv_unwind_sp): Delete.
12075         (frv_gdbarch_init): Don't register deleted functions with
12076         gdbarch.
12077
12078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12079
12080         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12081         (riscv_unwind_pc): Delete.
12082         (riscv_unwind_sp): Delete.
12083         (riscv_gdbarch_init): Don't register deleted functions with
12084         gdbarch.
12085
12086 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12087
12088         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12089         (csky_unwind_pc): Delete.
12090         (csky_unwind_sp): Delete.
12091         (csky_gdbarch_init): Don't register deleted functions with
12092         gdbarch.
12093
12094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12095
12096         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12097         (cris_unwind_pc): Delete.
12098         (cris_unwind_sp): Delete.
12099         (cris_gdbarch_init): Don't register deleted functions with
12100         gdbarch.
12101
12102 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12103
12104         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12105         (bfin_unwind_pc): Delete.
12106         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12107
12108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12109
12110         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12111         (arm_unwind_pc): Delete.
12112         (arm_unwind_sp): Delete.
12113         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12114
12115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12116
12117         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12118         (arc_unwind_pc): Delete.
12119         (arc_unwind_sp): Delete.
12120         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12121
12122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12123
12124         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12125         (alpha_unwind_pc): Delete.
12126         (alpha_gdbarch_init): Don't register deleted functions with
12127         gdbarch.
12128
12129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12130
12131         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12132         (aarch64_unwind_pc): Delete.
12133         (aarch64_unwind_sp): Delete.
12134         (aarch64_gdbarch_init): Don't register deleted functions with
12135         gdbarch.
12136
12137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12138
12139         * gdbtypes.c (type_align): Don't consider static members when
12140         computing structure alignment.
12141
12142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12143
12144         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12145         return 0 for other types.
12146         * arch-utils.c (default_type_align): Always return 0.
12147         * gdbarch.h: Regenerate.
12148         * gdbarch.sh (type_align): Extend comment.
12149         * gdbtypes.c (type_align): Add additional comments, always call
12150         gdbarch_type_align before applying the default rules.
12151         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12152         generic code will then apply a suitable default.
12153         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12154         types, return 0 for other types.
12155
12156 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12157
12158         * NEWS: Create a new section for the next release branch.
12159         Rename the section of the current branch, now that it has
12160         been cut.
12161
12162 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12163
12164         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12165         * version.in: Bump version to 8.3.50.DATE-git.
12166
12167 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12168
12169         * aix-thread.c (ptid_cmp): Remove unused variable.
12170         (get_signaled_thread): Likewise.
12171         (store_regs_user_thread): Likewise.
12172         (store_regs_kernel_thread): Likewise.
12173         (fetch_regs_kernel_thread): Remove shadowed variable.
12174
12175 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12176
12177         * features/riscv/32bit-cpu.xml: Add register numbers.
12178         * features/riscv/32bit-fpu.c: Regenerate.
12179         * features/riscv/32bit-fpu.xml: Add register numbers.
12180         * features/riscv/64bit-cpu.xml: Add register numbers.
12181         * features/riscv/64bit-fpu.c: Regenerate.
12182         * features/riscv/64bit-fpu.xml: Add register numbers.
12183
12184 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12185
12186         * NEWS: Mention two argument form of gdb.Value constructor.
12187         * python/py-value.c (convert_buffer_and_type_to_value): New
12188         function.
12189         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12190         Add support for handling an optional second argument.  Call
12191         convert_buffer_and_type_to_value as appropriate.
12192         * python/python-internal.h (Py_buffer_deleter): New struct.
12193         (Py_buffer_up): New typedef.
12194
12195 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12196
12197         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12198         instead of releasing ownership.
12199
12200 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12201
12202         * dwarf2read.c (open_and_init_dwp_file): Call
12203         elf_numsections instead of bfd_count_sections to initialize
12204         dwp_file->num_sections.
12205
12206 2019-02-25  Tom Tromey  <tromey@adacore.com>
12207
12208         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12209
12210 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12211
12212         * gcore.in: Add '--readnever' option when invoking GDB.
12213
12214 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12215
12216         * MAINTAINERS: Update my email address.
12217
12218 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12219
12220         * build-id.c (build_id_to_debug_bfd_1): New function.
12221         (build_id_to_debug_bfd): Look for separate debug file in
12222         sysroot.
12223
12224 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12225
12226         * gdbarch.sh: Update the copyright year range that is placed into
12227         generated files.
12228
12229 2019-02-22  Keith Seitz  <keiths@redhat.com>
12230
12231         PR symtab/23853
12232         * linespec.c (create_sals_line_offset): Search for the default
12233         symtab's filename instead of its fullname.
12234
12235 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12236
12237         * NEWS: Update style defaults.
12238
12239 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12240
12241         * main.c (captured_main_1): Disable styling in batch mode.
12242
12243 2019-02-20  Tom Tromey  <tom@tromey.com>
12244
12245         * symtab.c (symtab_symbol_info): Fix typos.
12246
12247 2019-02-20  Tom Tromey  <tromey@adacore.com>
12248
12249         * findcmd.c (_initialize_mem_search): Use upper case for
12250         metasyntactic variables.
12251
12252 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12253
12254         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12255         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12256
12257 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12258
12259         * top.h (source_file_name): Change to std::string.
12260         * top.c (source_file_name): Likewise.
12261         (command_line_input): Adjust.
12262         * cli/cli-script.c (script_from_file): Adjust.
12263
12264 2019-02-19  Tom Tromey  <tromey@adacore.com>
12265
12266         * ravenscar-thread.c
12267         (ravenscar_thread_target::update_thread_list): Don't call
12268         ada_build_task_list.
12269         * ada-lang.h (ada_build_task_list): Don't declare.
12270         * ada-tasks.c (struct ada_tasks_inferior_data)
12271         <task_list_valid_p>: Now bool.
12272         (read_known_tasks, ada_task_list_changed)
12273         (ada_tasks_invalidate_inferior_data): Update.
12274         (read_known_tasks_array): Return bool.
12275         (read_known_tasks_list): Likewise.
12276         (read_known_tasks): Return void.
12277         (ada_build_task_list): Now static.
12278
12279 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12280
12281         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12282         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12283
12284 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12285
12286         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12287         variant for ada_tasks_pspace_data_handle and
12288         ada_tasks_inferior_data_handle.
12289         (ada_tasks_pspace_data_cleanup): New function.
12290         (ada_tasks_inferior_data_cleanup): New function.
12291
12292 2019-02-17  Tom Tromey  <tom@tromey.com>
12293
12294         * macrotab.h (macro_source_fullname): Return a std::string.
12295         * macrotab.c (macro_include, check_for_redefinition)
12296         (macro_undef, macro_lookup_definition, foreach_macro)
12297         (foreach_macro_in_scope): Update.
12298         (macro_source_fullname): Return a std::string.
12299         * macrocmd.c (show_pp_source_pos): Update.
12300
12301 2019-02-17  Tom Tromey  <tom@tromey.com>
12302
12303         * macrocmd.c (show_pp_source_pos): Style the file names.
12304
12305 2019-02-17  Tom Tromey  <tom@tromey.com>
12306
12307         PR tui/24197:
12308         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12309
12310 2019-02-17  Tom Tromey  <tom@tromey.com>
12311
12312         * ada-lang.c (user_select_syms): Use filtered printing.
12313         * utils.c (wrap_style): New global.
12314         (desired_style): Remove.
12315         (emit_style_escape): Add stream parameter.
12316         (set_output_style, reset_terminal_style, prompt_for_continue):
12317         Update.
12318         (flush_wrap_buffer): Only flush gdb_stdout.
12319         (wrap_here): Set wrap_style.
12320         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12321         treat escape sequences as a character.  Change when wrap buffer is
12322         flushed.
12323         (fputs_styled): Do not set the output style when the default is
12324         requested.
12325         * ui-style.h (struct ui_file_style) <is_default>: New method.
12326         * source.c (print_source_lines_base): Emit escape sequences in one
12327         piece.
12328
12329 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12330
12331         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12332         integers and enumeration types.
12333
12334 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12335
12336         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12337         instead of lookup_symbol_in_language
12338         (do_exact_match): New function.
12339         (ada_get_symbol_name_matcher): Return do_exact_match when
12340         doing a verbatim match.
12341
12342 2019-02-15  Tom Tromey  <tromey@adacore.com>
12343
12344         * ravenscar-thread.c (ravenscar_thread_target::resume)
12345         (ravenscar_thread_target::wait): Special case wildcard requests.
12346
12347 2019-02-15  Tom Tromey  <tromey@adacore.com>
12348
12349         * ravenscar-thread.c (base_ptid): Remove.
12350         (struct ravenscar_thread_target) <close>: New method.
12351         <m_base_ptid>: New member.
12352         <update_inferior_ptid, active_task, task_is_currently_active,
12353         runtime_initialized>: Declare methods.
12354         <ravenscar_thread_target>: Add constructor.
12355         (ravenscar_thread_target::task_is_currently_active)
12356         (ravenscar_thread_target::update_inferior_ptid)
12357         (ravenscar_runtime_initialized): Rename.  Now methods.
12358         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12359         (ravenscar_thread_target::update_thread_list): Update.
12360         (ravenscar_thread_target::active_task): Now method.
12361         (ravenscar_thread_target::store_registers)
12362         (ravenscar_thread_target::prepare_to_store)
12363         (ravenscar_thread_target::prepare_to_store)
12364         (ravenscar_thread_target::mourn_inferior): Update.
12365         (ravenscar_inferior_created): Use "new" to create target.
12366         (ravenscar_thread_target::get_ada_task_ptid): Update.
12367         (_initialize_ravenscar): Don't initialize base_ptid.
12368         (ravenscar_ops): Remove global.
12369
12370 2019-02-15  Tom Tromey  <tromey@adacore.com>
12371
12372         * target.h (push_target): Declare new overload.
12373         * target.c (push_target): New overload, taking an rvalue reference.
12374         * remote.c (remote_target::open_1): Use push_target overload.
12375         * corelow.c (core_target_open): Use push_target overload.
12376
12377 2019-02-15  Tom Tromey  <tromey@adacore.com>
12378
12379         * ravenscar-thread.c (is_ravenscar_task)
12380         (ravenscar_task_is_currently_active): Return bool.
12381         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12382         (_initialize_ravenscar): Remove "(void)".
12383         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12384         Return bool.
12385
12386 2019-02-15  Tom Tromey  <tromey@adacore.com>
12387
12388         * ravenscar-thread.c (ravenscar_runtime_initializer)
12389         (has_ravenscar_runtime, get_running_thread_id)
12390         (ravenscar_thread_target::resume): Fix indentation.
12391
12392 2019-02-15  Tom Tromey  <tromey@adacore.com>
12393
12394         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12395         from ravenscar_arch_ops.
12396         (sparc_ravenscar_ops::fetch_registers)
12397         (sparc_ravenscar_ops::store_registers): Now methods.
12398         (sparc_ravenscar_prepare_to_store): Remove.
12399         (sparc_ravenscar_ops): Redefine.
12400         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12401         methods and destructor.  Remove members.
12402         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12403         (ravenscar_thread_target::store_registers)
12404         (ravenscar_thread_target::prepare_to_store): Update.
12405         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12406         Remove.
12407         (struct ppc_ravenscar_powerpc_ops): Derive from
12408         ravenscar_arch_ops.
12409         (ppc_ravenscar_powerpc_ops::fetch_registers)
12410         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12411         (ppc_ravenscar_powerpc_ops): Redefine.
12412         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12413         (ppc_ravenscar_e500_ops::fetch_registers)
12414         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12415         (ppc_ravenscar_e500_ops): Redefine.
12416         * aarch64-ravenscar-thread.c
12417         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12418         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12419         (aarch64_ravenscar_fetch_registers)
12420         (aarch64_ravenscar_store_registers): Now methods.
12421         (aarch64_ravenscar_ops): Redefine.
12422
12423 2019-02-15  Tom Tromey  <tromey@adacore.com>
12424
12425         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12426         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12427         (ravenscar_thread_target::stopped_by_watchpoint)
12428         (ravenscar_thread_target::stopped_data_address)
12429         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12430
12431 2019-02-15  Tom Tromey  <tromey@adacore.com>
12432
12433         * ravenscar-thread.c: Fix some typos.
12434
12435 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12436             Tom Tromey  <tromey@adacore.com>
12437
12438         * ada-lang.c (ada_exception_sal): Change addr_string to a
12439         std::string.
12440         (create_ada_exception_catchpoint): Update.
12441
12442 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12443             Tom Tromey  <tromey@adacore.com>
12444
12445         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12446         (bp_location_ops): Remove.
12447         (base_breakpoint_allocate_location): Update.
12448         (free_bp_location): Update.
12449         * ada-lang.c (class ada_catchpoint_location)
12450         <ada_catchpoint_location>: Remove ops parameter.
12451         (ada_catchpoint_location_dtor): Remove.
12452         (ada_catchpoint_location_ops): Remove.
12453         (allocate_location_exception): Update.
12454         * breakpoint.h (struct bp_location_ops): Remove.
12455         (class bp_location) <bp_location>: Remove bp_location_ops
12456         parameter.
12457         <~bp_location>: Add destructor.
12458         <ops>: Remove.
12459
12460 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12461             Pedro Alves  <palves@redhat.com>
12462
12463         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12464         'PATH_MAX'.
12465
12466 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12467             Samuel Thibault  <samuel.thibault@gnu.org>
12468             Thomas Schwinge  <thomas@codesourcery.com>
12469
12470         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12471         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12472
12473 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12474
12475         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12476         (check_empty): Use "const char *".
12477
12478         * gnu-nat.c (gnu_nat_target::detach): Instead of
12479         'detach_inferior (pid)' call
12480         'detach_inferior (find_inferior_pid (pid))'.
12481
12482         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12483         'nat/fork-inferior.o'.
12484         * gnu-nat.c: #include "nat/fork-inferior.h".
12485
12486         * gnu-nat.c (gnu_nat_target::detach): Instead of
12487         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12488         * gnu-nat.h: #include "inf-child.h".
12489         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12490         'i386_gnu_nat_target::fetch_registers'.
12491         (gnu_store_registers): Rename/move to
12492         'i386_gnu_nat_target::store_registers'.
12493
12494         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12495         * gnu-nat.h (mach_thread_info): New function.
12496         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12497
12498         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12499
12500 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12501
12502         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12503
12504 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12505
12506         * windows-nat.c (windows_add_thread): Add new parameter
12507         "main_thread_p" with default value set to false.  Update
12508         function documentation as well as all callers.
12509         (windows_delete_thread): Likewise.
12510         (fake_create_process): Update call to windows_add_thread.
12511         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12512         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12513         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12514         call to windows_delete_thread.
12515
12516 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12517
12518         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12519
12520 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12521
12522         * symfile.c (find_separate_debug_file): Use canonical path of
12523         sysroot with child_path instead of gdb_sysroot if it is valid.
12524
12525 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12526
12527         * symfile.c (find_separate_debug_file): Use child_path to
12528         determine if an object file is under a sysroot.
12529
12530 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12531
12532         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12533         unittests/child-path-selftests.c.
12534         * common/pathstuff.c (child_path): New function.
12535         * common/pathstuff.h (child_path): New prototype.
12536         * unittests/child-path-selftests.c: New file.
12537
12538 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12539
12540         * symfile.c (find_separate_debug_file): Look for separate debug
12541         files in debug directories under the sysroot.
12542
12543 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12544
12545         * symtab.h (struct minimal_symbol data_p): New const method.
12546         (struct minimal_symbol text_p): Likewise.
12547         * symtab.c (output_source_filename): Use file name style
12548         to print file name.
12549         (print_symbol_info): Likewise.
12550         (print_msymbol_info): Use address style to print addresses.
12551         Use function name style to print executable text symbols.
12552         (expand_symtab_containing_pc): Use data_p.
12553         (find_pc_sect_compunit_symtab): Likewise.
12554
12555 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12556
12557         * breakpoint.c (describe_other_breakpoints): Use address style
12558         to print addresses.
12559         (say_where): Likewise.
12560
12561 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12562
12563         * ada-typeprint.c (print_func_type): Print function name
12564         style to print function name.
12565         * c-typeprint.c (c_print_type_1): Likewise.
12566
12567 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12568
12569         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12570         for execve.
12571
12572 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12573
12574         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12575         type_stack.
12576
12577 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12578
12579         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12580         TYPE_CODE_REF types.
12581
12582 2019-02-08  Jim Wilson  <jimw@sifive.com>
12583
12584         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12585         (riscv_linux_fregset): New.
12586         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12587
12588 2019-02-07  Tom Tromey  <tom@tromey.com>
12589
12590         * thread.c (thread_cancel_execution_command): Update.
12591         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12592         methods.
12593         (struct thread_fsm_ops): Remove.
12594         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12595         (thread_fsm_should_stop, thread_fsm_return_value)
12596         (thread_fsm_set_finished, thread_fsm_finished_p)
12597         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12598         Don't declare.
12599         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12600         * infrun.c (clear_proceed_status_thread)
12601         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12602         (print_stop_event): Update.
12603         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12604         Add constructor.
12605         (step_command_fsm_ops): Remove.
12606         (new_step_command_fsm): Remove.
12607         (step_1): Update.
12608         (step_command_fsm::should_stop): Rename from
12609         step_command_fsm_should_stop.
12610         (step_command_fsm::clean_up): Rename from
12611         step_command_fsm_clean_up.
12612         (step_command_fsm::do_async_reply_reason): Rename from
12613         step_command_fsm_async_reply_reason.
12614         (struct until_next_fsm): Inherit from thread_fsm.  Add
12615         constructor.
12616         (until_next_fsm_ops): Remove.
12617         (new_until_next_fsm): Remove.
12618         (until_next_fsm::should_stop): Rename from
12619         until_next_fsm_should_stop.
12620         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12621         (until_next_fsm::do_async_reply_reason): Rename from
12622         until_next_fsm_async_reply_reason.
12623         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12624         constructor.  Change type of breakpoint.
12625         (finish_command_fsm_ops): Remove.
12626         (new_finish_command_fsm): Remove.
12627         (finish_command_fsm::should_stop): Rename from
12628         finish_command_fsm_should_stop.
12629         (finish_command_fsm::clean_up): Rename from
12630         finish_command_fsm_clean_up.
12631         (finish_command_fsm::return_value): Rename from
12632         finish_command_fsm_return_value.
12633         (finish_command_fsm::do_async_reply_reason): Rename from
12634         finish_command_fsm_async_reply_reason.
12635         (finish_command): Update.
12636         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12637         Add constructor.
12638         (call_thread_fsm_ops): Remove.
12639         (call_thread_fsm::call_thread_fsm): Rename from
12640         new_call_thread_fsm.
12641         (call_thread_fsm::should_stop): Rename from
12642         call_thread_fsm_should_stop.
12643         (call_thread_fsm::should_notify_stop): Rename from
12644         call_thread_fsm_should_notify_stop.
12645         (run_inferior_call, call_function_by_hand_dummy): Update.
12646         * cli/cli-interp.c (should_print_stop_to_console): Update.
12647         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12648         Add constructor.  Change type of location_breakpoint,
12649         caller_breakpoint.
12650         (until_break_fsm_ops): Remove.
12651         (new_until_break_fsm): Remove.
12652         (until_break_fsm::should_stop): Rename from
12653         until_break_fsm_should_stop.
12654         (until_break_fsm::clean_up): Rename from
12655         until_break_fsm_clean_up.
12656         (until_break_fsm::do_async_reply_reason): Rename from
12657         until_break_fsm_async_reply_reason.
12658         (until_break_command): Update.
12659         * thread-fsm.c: Remove.
12660         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12661
12662 2019-02-07  Tom Tromey  <tom@tromey.com>
12663
12664         * yy-remap.h: Add include guard.
12665         * xtensa-tdep.h: Add include guard.
12666         * xcoffread.h: Rename include guard.
12667         * varobj-iter.h: Add include guard.
12668         * tui/tui.h: Rename include guard.
12669         * tui/tui-winsource.h: Rename include guard.
12670         * tui/tui-wingeneral.h: Rename include guard.
12671         * tui/tui-windata.h: Rename include guard.
12672         * tui/tui-win.h: Rename include guard.
12673         * tui/tui-stack.h: Rename include guard.
12674         * tui/tui-source.h: Rename include guard.
12675         * tui/tui-regs.h: Rename include guard.
12676         * tui/tui-out.h: Rename include guard.
12677         * tui/tui-layout.h: Rename include guard.
12678         * tui/tui-io.h: Rename include guard.
12679         * tui/tui-hooks.h: Rename include guard.
12680         * tui/tui-file.h: Rename include guard.
12681         * tui/tui-disasm.h: Rename include guard.
12682         * tui/tui-data.h: Rename include guard.
12683         * tui/tui-command.h: Rename include guard.
12684         * tic6x-tdep.h: Add include guard.
12685         * target/waitstatus.h: Rename include guard.
12686         * target/wait.h: Rename include guard.
12687         * target/target.h: Rename include guard.
12688         * target/resume.h: Rename include guard.
12689         * target-float.h: Rename include guard.
12690         * stabsread.h: Add include guard.
12691         * rs6000-tdep.h: Add include guard.
12692         * riscv-fbsd-tdep.h: Add include guard.
12693         * regformats/regdef.h: Rename include guard.
12694         * record.h: Rename include guard.
12695         * python/python.h: Rename include guard.
12696         * python/python-internal.h: Rename include guard.
12697         * python/py-stopevent.h: Rename include guard.
12698         * python/py-ref.h: Rename include guard.
12699         * python/py-record.h: Rename include guard.
12700         * python/py-record-full.h: Rename include guard.
12701         * python/py-record-btrace.h: Rename include guard.
12702         * python/py-instruction.h: Rename include guard.
12703         * python/py-events.h: Rename include guard.
12704         * python/py-event.h: Rename include guard.
12705         * procfs.h: Add include guard.
12706         * proc-utils.h: Add include guard.
12707         * p-lang.h: Add include guard.
12708         * or1k-tdep.h: Rename include guard.
12709         * observable.h: Rename include guard.
12710         * nto-tdep.h: Rename include guard.
12711         * nat/x86-linux.h: Rename include guard.
12712         * nat/x86-linux-dregs.h: Rename include guard.
12713         * nat/x86-gcc-cpuid.h: Add include guard.
12714         * nat/x86-dregs.h: Rename include guard.
12715         * nat/x86-cpuid.h: Rename include guard.
12716         * nat/ppc-linux.h: Rename include guard.
12717         * nat/mips-linux-watch.h: Rename include guard.
12718         * nat/linux-waitpid.h: Rename include guard.
12719         * nat/linux-ptrace.h: Rename include guard.
12720         * nat/linux-procfs.h: Rename include guard.
12721         * nat/linux-osdata.h: Rename include guard.
12722         * nat/linux-nat.h: Rename include guard.
12723         * nat/linux-namespaces.h: Rename include guard.
12724         * nat/linux-btrace.h: Rename include guard.
12725         * nat/glibc_thread_db.h: Rename include guard.
12726         * nat/gdb_thread_db.h: Rename include guard.
12727         * nat/gdb_ptrace.h: Rename include guard.
12728         * nat/fork-inferior.h: Rename include guard.
12729         * nat/amd64-linux-siginfo.h: Rename include guard.
12730         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12731         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12732         * nat/aarch64-linux.h: Rename include guard.
12733         * nat/aarch64-linux-hw-point.h: Rename include guard.
12734         * mn10300-tdep.h: Add include guard.
12735         * mips-linux-tdep.h: Add include guard.
12736         * mi/mi-parse.h: Rename include guard.
12737         * mi/mi-out.h: Rename include guard.
12738         * mi/mi-main.h: Rename include guard.
12739         * mi/mi-interp.h: Rename include guard.
12740         * mi/mi-getopt.h: Rename include guard.
12741         * mi/mi-console.h: Rename include guard.
12742         * mi/mi-common.h: Rename include guard.
12743         * mi/mi-cmds.h: Rename include guard.
12744         * mi/mi-cmd-break.h: Rename include guard.
12745         * m2-lang.h: Add include guard.
12746         * location.h: Rename include guard.
12747         * linux-record.h: Rename include guard.
12748         * linux-nat.h: Add include guard.
12749         * linux-fork.h: Add include guard.
12750         * i386-darwin-tdep.h: Rename include guard.
12751         * hppa-linux-offsets.h: Add include guard.
12752         * guile/guile.h: Rename include guard.
12753         * guile/guile-internal.h: Rename include guard.
12754         * gnu-nat.h: Rename include guard.
12755         * gdb-stabs.h: Rename include guard.
12756         * frv-tdep.h: Add include guard.
12757         * f-lang.h: Add include guard.
12758         * event-loop.h: Add include guard.
12759         * darwin-nat.h: Rename include guard.
12760         * cp-abi.h: Rename include guard.
12761         * config/sparc/nm-sol2.h: Rename include guard.
12762         * config/nm-nto.h: Rename include guard.
12763         * config/nm-linux.h: Add include guard.
12764         * config/i386/nm-i386gnu.h: Rename include guard.
12765         * config/djgpp/nl_types.h: Rename include guard.
12766         * config/djgpp/langinfo.h: Rename include guard.
12767         * compile/gcc-cp-plugin.h: Add include guard.
12768         * compile/gcc-c-plugin.h: Add include guard.
12769         * compile/compile.h: Rename include guard.
12770         * compile/compile-object-run.h: Rename include guard.
12771         * compile/compile-object-load.h: Rename include guard.
12772         * compile/compile-internal.h: Rename include guard.
12773         * compile/compile-cplus.h: Rename include guard.
12774         * compile/compile-c.h: Rename include guard.
12775         * common/xml-utils.h: Rename include guard.
12776         * common/x86-xstate.h: Rename include guard.
12777         * common/version.h: Rename include guard.
12778         * common/vec.h: Rename include guard.
12779         * common/tdesc.h: Rename include guard.
12780         * common/selftest.h: Rename include guard.
12781         * common/scoped_restore.h: Rename include guard.
12782         * common/scoped_mmap.h: Rename include guard.
12783         * common/scoped_fd.h: Rename include guard.
12784         * common/safe-iterator.h: Rename include guard.
12785         * common/run-time-clock.h: Rename include guard.
12786         * common/refcounted-object.h: Rename include guard.
12787         * common/queue.h: Rename include guard.
12788         * common/ptid.h: Rename include guard.
12789         * common/print-utils.h: Rename include guard.
12790         * common/preprocessor.h: Rename include guard.
12791         * common/pathstuff.h: Rename include guard.
12792         * common/observable.h: Rename include guard.
12793         * common/netstuff.h: Rename include guard.
12794         * common/job-control.h: Rename include guard.
12795         * common/host-defs.h: Rename include guard.
12796         * common/gdb_wait.h: Rename include guard.
12797         * common/gdb_vecs.h: Rename include guard.
12798         * common/gdb_unlinker.h: Rename include guard.
12799         * common/gdb_unique_ptr.h: Rename include guard.
12800         * common/gdb_tilde_expand.h: Rename include guard.
12801         * common/gdb_sys_time.h: Rename include guard.
12802         * common/gdb_string_view.h: Rename include guard.
12803         * common/gdb_splay_tree.h: Rename include guard.
12804         * common/gdb_setjmp.h: Rename include guard.
12805         * common/gdb_ref_ptr.h: Rename include guard.
12806         * common/gdb_optional.h: Rename include guard.
12807         * common/gdb_locale.h: Rename include guard.
12808         * common/gdb_assert.h: Rename include guard.
12809         * common/filtered-iterator.h: Rename include guard.
12810         * common/filestuff.h: Rename include guard.
12811         * common/fileio.h: Rename include guard.
12812         * common/environ.h: Rename include guard.
12813         * common/common-utils.h: Rename include guard.
12814         * common/common-types.h: Rename include guard.
12815         * common/common-regcache.h: Rename include guard.
12816         * common/common-inferior.h: Rename include guard.
12817         * common/common-gdbthread.h: Rename include guard.
12818         * common/common-exceptions.h: Rename include guard.
12819         * common/common-defs.h: Rename include guard.
12820         * common/common-debug.h: Rename include guard.
12821         * common/cleanups.h: Rename include guard.
12822         * common/buffer.h: Rename include guard.
12823         * common/btrace-common.h: Rename include guard.
12824         * common/break-common.h: Rename include guard.
12825         * cli/cli-utils.h: Rename include guard.
12826         * cli/cli-style.h: Rename include guard.
12827         * cli/cli-setshow.h: Rename include guard.
12828         * cli/cli-script.h: Rename include guard.
12829         * cli/cli-interp.h: Rename include guard.
12830         * cli/cli-decode.h: Rename include guard.
12831         * cli/cli-cmds.h: Rename include guard.
12832         * charset-list.h: Add include guard.
12833         * buildsym-legacy.h: Rename include guard.
12834         * bfin-tdep.h: Add include guard.
12835         * ax.h: Rename include guard.
12836         * arm-linux-tdep.h: Add include guard.
12837         * arm-fbsd-tdep.h: Add include guard.
12838         * arch/xtensa.h: Rename include guard.
12839         * arch/tic6x.h: Add include guard.
12840         * arch/i386.h: Add include guard.
12841         * arch/arm.h: Rename include guard.
12842         * arch/arm-linux.h: Rename include guard.
12843         * arch/arm-get-next-pcs.h: Rename include guard.
12844         * arch/amd64.h: Add include guard.
12845         * arch/aarch64-insn.h: Rename include guard.
12846         * arch-utils.h: Rename include guard.
12847         * annotate.h: Add include guard.
12848         * amd64-darwin-tdep.h: Rename include guard.
12849         * aarch64-linux-tdep.h: Add include guard.
12850         * aarch64-fbsd-tdep.h: Add include guard.
12851         * aarch32-linux-nat.h: Add include guard.
12852
12853 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12854
12855         * macrotab.c (macro_define_internal): New function that
12856         factorizes macro_define_object_internal and macro_define_function
12857         code.
12858         (macro_define_object_internal): Use macro_define_internal.
12859         (macro_define_function): Likewise.
12860
12861 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12862
12863         * macrocmd.c (extract_identifier): Return
12864         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12865         callers.
12866
12867 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12868
12869         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12870
12871 2019-02-05  Tom Tromey  <tom@tromey.com>
12872
12873         * target.c (target_stack::unpush): Move assertion earlier.
12874
12875 2019-01-30  Tom Tromey  <tom@tromey.com>
12876
12877         PR python/23615:
12878         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12879         (gdbpy_parse_and_eval): Likewise.
12880         * python/python-internal.h (gdbpy_allow_threads): New class.
12881
12882 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12883
12884         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12885         (aarch64_fbsd_fpregmap): Move earlier.
12886         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12887         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12888         instead of individual calls to trad_frame_set_reg_addr.
12889         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12890         earlier.
12891         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12892         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12893         instead of individual calls to trad_frame_set_reg_addr.
12894
12895 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12896
12897         * CONTRIBUTE: Replace contribution list with wiki link.
12898
12899 2019-01-25  Tom Tromey  <tom@tromey.com>
12900
12901         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12902
12903 2019-01-25  Tom Tromey  <tom@tromey.com>
12904
12905         * xtensa-linux-nat.c: Fix common/ includes.
12906         * xml-support.h: Fix common/ includes.
12907         * xml-support.c: Fix common/ includes.
12908         * x86-linux-nat.c: Fix common/ includes.
12909         * windows-nat.c: Fix common/ includes.
12910         * varobj.h: Fix common/ includes.
12911         * varobj.c: Fix common/ includes.
12912         * value.c: Fix common/ includes.
12913         * valops.c: Fix common/ includes.
12914         * utils.c: Fix common/ includes.
12915         * unittests/xml-utils-selftests.c: Fix common/ includes.
12916         * unittests/utils-selftests.c: Fix common/ includes.
12917         * unittests/unpack-selftests.c: Fix common/ includes.
12918         * unittests/tracepoint-selftests.c: Fix common/ includes.
12919         * unittests/style-selftests.c: Fix common/ includes.
12920         * unittests/string_view-selftests.c: Fix common/ includes.
12921         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12922         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12923         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12924         * unittests/rsp-low-selftests.c: Fix common/ includes.
12925         * unittests/parse-connection-spec-selftests.c: Fix common/
12926         includes.
12927         * unittests/optional-selftests.c: Fix common/ includes.
12928         * unittests/offset-type-selftests.c: Fix common/ includes.
12929         * unittests/observable-selftests.c: Fix common/ includes.
12930         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12931         * unittests/memrange-selftests.c: Fix common/ includes.
12932         * unittests/memory-map-selftests.c: Fix common/ includes.
12933         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12934         * unittests/function-view-selftests.c: Fix common/ includes.
12935         * unittests/environ-selftests.c: Fix common/ includes.
12936         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12937         * unittests/common-utils-selftests.c: Fix common/ includes.
12938         * unittests/cli-utils-selftests.c: Fix common/ includes.
12939         * unittests/array-view-selftests.c: Fix common/ includes.
12940         * ui-file.c: Fix common/ includes.
12941         * tui/tui-io.c: Fix common/ includes.
12942         * tracepoint.h: Fix common/ includes.
12943         * tracepoint.c: Fix common/ includes.
12944         * tracefile-tfile.c: Fix common/ includes.
12945         * top.h: Fix common/ includes.
12946         * top.c: Fix common/ includes.
12947         * thread.c: Fix common/ includes.
12948         * target/waitstatus.h: Fix common/ includes.
12949         * target/waitstatus.c: Fix common/ includes.
12950         * target.h: Fix common/ includes.
12951         * target.c: Fix common/ includes.
12952         * target-memory.c: Fix common/ includes.
12953         * target-descriptions.c: Fix common/ includes.
12954         * symtab.h: Fix common/ includes.
12955         * symfile.c: Fix common/ includes.
12956         * stap-probe.c: Fix common/ includes.
12957         * spu-linux-nat.c: Fix common/ includes.
12958         * sparc-nat.c: Fix common/ includes.
12959         * source.c: Fix common/ includes.
12960         * solib.c: Fix common/ includes.
12961         * solib-target.c: Fix common/ includes.
12962         * ser-unix.c: Fix common/ includes.
12963         * ser-tcp.c: Fix common/ includes.
12964         * ser-pipe.c: Fix common/ includes.
12965         * ser-base.c: Fix common/ includes.
12966         * selftest-arch.c: Fix common/ includes.
12967         * s12z-tdep.c: Fix common/ includes.
12968         * rust-exp.y: Fix common/ includes.
12969         * rs6000-aix-tdep.c: Fix common/ includes.
12970         * riscv-tdep.c: Fix common/ includes.
12971         * remote.c: Fix common/ includes.
12972         * remote-notif.h: Fix common/ includes.
12973         * remote-fileio.h: Fix common/ includes.
12974         * remote-fileio.c: Fix common/ includes.
12975         * regcache.h: Fix common/ includes.
12976         * regcache.c: Fix common/ includes.
12977         * record-btrace.c: Fix common/ includes.
12978         * python/python.c: Fix common/ includes.
12979         * python/py-type.c: Fix common/ includes.
12980         * python/py-inferior.c: Fix common/ includes.
12981         * progspace.h: Fix common/ includes.
12982         * producer.c: Fix common/ includes.
12983         * procfs.c: Fix common/ includes.
12984         * proc-api.c: Fix common/ includes.
12985         * printcmd.c: Fix common/ includes.
12986         * ppc-linux-nat.c: Fix common/ includes.
12987         * parser-defs.h: Fix common/ includes.
12988         * osdata.c: Fix common/ includes.
12989         * obsd-nat.c: Fix common/ includes.
12990         * nat/x86-linux.c: Fix common/ includes.
12991         * nat/x86-linux-dregs.c: Fix common/ includes.
12992         * nat/x86-dregs.h: Fix common/ includes.
12993         * nat/x86-dregs.c: Fix common/ includes.
12994         * nat/ppc-linux.c: Fix common/ includes.
12995         * nat/mips-linux-watch.h: Fix common/ includes.
12996         * nat/mips-linux-watch.c: Fix common/ includes.
12997         * nat/linux-waitpid.c: Fix common/ includes.
12998         * nat/linux-ptrace.h: Fix common/ includes.
12999         * nat/linux-ptrace.c: Fix common/ includes.
13000         * nat/linux-procfs.c: Fix common/ includes.
13001         * nat/linux-personality.c: Fix common/ includes.
13002         * nat/linux-osdata.c: Fix common/ includes.
13003         * nat/linux-namespaces.c: Fix common/ includes.
13004         * nat/linux-btrace.h: Fix common/ includes.
13005         * nat/linux-btrace.c: Fix common/ includes.
13006         * nat/fork-inferior.c: Fix common/ includes.
13007         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13008         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13009         * nat/aarch64-linux.c: Fix common/ includes.
13010         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13011         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13012         * namespace.h: Fix common/ includes.
13013         * mips-linux-tdep.c: Fix common/ includes.
13014         * minsyms.c: Fix common/ includes.
13015         * mi/mi-parse.h: Fix common/ includes.
13016         * mi/mi-main.c: Fix common/ includes.
13017         * mi/mi-cmd-env.c: Fix common/ includes.
13018         * memrange.h: Fix common/ includes.
13019         * memattr.c: Fix common/ includes.
13020         * maint.h: Fix common/ includes.
13021         * maint.c: Fix common/ includes.
13022         * main.c: Fix common/ includes.
13023         * machoread.c: Fix common/ includes.
13024         * location.c: Fix common/ includes.
13025         * linux-thread-db.c: Fix common/ includes.
13026         * linux-nat.c: Fix common/ includes.
13027         * linux-fork.c: Fix common/ includes.
13028         * inline-frame.c: Fix common/ includes.
13029         * infrun.c: Fix common/ includes.
13030         * inflow.c: Fix common/ includes.
13031         * inferior.h: Fix common/ includes.
13032         * inferior.c: Fix common/ includes.
13033         * infcmd.c: Fix common/ includes.
13034         * inf-ptrace.c: Fix common/ includes.
13035         * inf-child.c: Fix common/ includes.
13036         * ia64-linux-nat.c: Fix common/ includes.
13037         * i387-tdep.c: Fix common/ includes.
13038         * i386-tdep.c: Fix common/ includes.
13039         * i386-linux-tdep.c: Fix common/ includes.
13040         * i386-linux-nat.c: Fix common/ includes.
13041         * i386-go32-tdep.c: Fix common/ includes.
13042         * i386-fbsd-tdep.c: Fix common/ includes.
13043         * i386-fbsd-nat.c: Fix common/ includes.
13044         * guile/scm-type.c: Fix common/ includes.
13045         * guile/guile.c: Fix common/ includes.
13046         * go32-nat.c: Fix common/ includes.
13047         * gnu-nat.c: Fix common/ includes.
13048         * gdbthread.h: Fix common/ includes.
13049         * gdbarch-selftests.c: Fix common/ includes.
13050         * gdb_usleep.c: Fix common/ includes.
13051         * gdb_select.h: Fix common/ includes.
13052         * gdb_bfd.c: Fix common/ includes.
13053         * gcore.c: Fix common/ includes.
13054         * fork-child.c: Fix common/ includes.
13055         * findvar.c: Fix common/ includes.
13056         * fbsd-nat.c: Fix common/ includes.
13057         * event-top.c: Fix common/ includes.
13058         * event-loop.c: Fix common/ includes.
13059         * dwarf2read.c: Fix common/ includes.
13060         * dwarf2loc.c: Fix common/ includes.
13061         * dwarf2-frame.c: Fix common/ includes.
13062         * dwarf-index-cache.c: Fix common/ includes.
13063         * dtrace-probe.c: Fix common/ includes.
13064         * disasm-selftests.c: Fix common/ includes.
13065         * defs.h: Fix common/ includes.
13066         * csky-tdep.c: Fix common/ includes.
13067         * cp-valprint.c: Fix common/ includes.
13068         * cp-support.h: Fix common/ includes.
13069         * cp-support.c: Fix common/ includes.
13070         * corelow.c: Fix common/ includes.
13071         * completer.h: Fix common/ includes.
13072         * completer.c: Fix common/ includes.
13073         * compile/compile.c: Fix common/ includes.
13074         * compile/compile-loc2c.c: Fix common/ includes.
13075         * compile/compile-cplus-types.c: Fix common/ includes.
13076         * compile/compile-cplus-symbols.c: Fix common/ includes.
13077         * command.h: Fix common/ includes.
13078         * cli/cli-dump.c: Fix common/ includes.
13079         * cli/cli-cmds.c: Fix common/ includes.
13080         * charset.c: Fix common/ includes.
13081         * build-id.c: Fix common/ includes.
13082         * btrace.h: Fix common/ includes.
13083         * btrace.c: Fix common/ includes.
13084         * breakpoint.h: Fix common/ includes.
13085         * breakpoint.c: Fix common/ includes.
13086         * ax.h:
13087         (enum agent_op): Fix common/ includes.
13088         * ax-general.c (struct aop_map): Fix common/ includes.
13089         * ax-gdb.c: Fix common/ includes.
13090         * auxv.c: Fix common/ includes.
13091         * auto-load.c: Fix common/ includes.
13092         * arm-tdep.c: Fix common/ includes.
13093         * arch/riscv.c: Fix common/ includes.
13094         * arch/ppc-linux-common.c: Fix common/ includes.
13095         * arch/i386.c: Fix common/ includes.
13096         * arch/arm.c: Fix common/ includes.
13097         * arch/arm-linux.c: Fix common/ includes.
13098         * arch/arm-get-next-pcs.c: Fix common/ includes.
13099         * arch/amd64.c: Fix common/ includes.
13100         * arch/aarch64.c: Fix common/ includes.
13101         * arch/aarch64-insn.c: Fix common/ includes.
13102         * arch-utils.c: Fix common/ includes.
13103         * amd64-windows-tdep.c: Fix common/ includes.
13104         * amd64-tdep.c: Fix common/ includes.
13105         * amd64-sol2-tdep.c: Fix common/ includes.
13106         * amd64-obsd-tdep.c: Fix common/ includes.
13107         * amd64-nbsd-tdep.c: Fix common/ includes.
13108         * amd64-linux-tdep.c: Fix common/ includes.
13109         * amd64-linux-nat.c: Fix common/ includes.
13110         * amd64-fbsd-tdep.c: Fix common/ includes.
13111         * amd64-fbsd-nat.c: Fix common/ includes.
13112         * amd64-dicos-tdep.c: Fix common/ includes.
13113         * amd64-darwin-tdep.c: Fix common/ includes.
13114         * agent.c: Fix common/ includes.
13115         * ada-lang.h: Fix common/ includes.
13116         * ada-lang.c: Fix common/ includes.
13117         * aarch64-tdep.c: Fix common/ includes.
13118
13119 2019-01-25  Tom Tromey  <tom@tromey.com>
13120
13121         * common/create-version.sh: Use common/version.h.
13122
13123 2019-01-24  Pedro Alves  <palves@redhat.com>
13124
13125         * infrun.c (signal_stop, signal_print, signal_program)
13126         (signal_catch, signal_pass): Now arrays instead of pointers.
13127         (update_signals_program_target, do_target_resume)
13128         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13129         * linux-nat.c (linux_nat_target::pass_signals)
13130         (linux_nat_target::create_inferior, linux_nat_target::attach):
13131         Adjust.
13132         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13133         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13134         * procfs.c (procfs_target::pass_signals): Adjust.
13135         * record-full.c (record_full_target::resume): Adjust.
13136         * remote.c (remote_target::pass_signals)
13137         (remote_target::program_signals): Adjust.
13138         * target-debug.h (target_debug_print_signals): Now takes a
13139         gdb::array_view as parameter.  Adjust.
13140         * target.h (target_ops) <pass_signals, program_signals>: Replace
13141         pointer and length parameters with gdb::array_view.
13142         (target_pass_signals, target_program_signals): Likewise.
13143         * target-delegates.c: Regenerate.
13144
13145 2019-01-24  Pedro Alves  <palves@redhat.com>
13146
13147         * common/forward-scope-exit.h
13148         (forward_scope_exit::forward_scope_exit): Pass arguments to
13149         m_bind_function directly, instead of creating a std::bind and
13150         copying that.
13151
13152 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13153
13154         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13155         for static members.
13156         (pass_in_v_vfp_candidate): Likewise.
13157
13158 2019-01-23  Tom Tromey  <tom@tromey.com>
13159             Pedro Alves  <palves@redhat.com>
13160
13161         * regcache.c (class regcache_invalidator): Remove.
13162         (regcache::raw_write): Use make_scope_exit.
13163
13164 2019-01-23  Tom Tromey  <tom@tromey.com>
13165
13166         * ui-out.h (class ui_out_emit_type): Update comment.
13167
13168 2019-01-23  Tom Tromey  <tom@tromey.com>
13169
13170         * infrun.c (fetch_inferior_event): Update comment.
13171
13172 2019-01-23  Tom Tromey  <tom@tromey.com>
13173             Pedro Alves  <palves@redhat.com>
13174
13175         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13176         parameter.
13177         (fetch_inferior_event): Use SCOPE_EXIT.
13178
13179
13180 2019-01-23  Tom Tromey  <tom@tromey.com>
13181             Pedro Alves  <palves@redhat.com>
13182
13183         * infrun.c (disable_thread_events): Delete.
13184         (stop_all_threads): Use SCOPE_EXIT.
13185
13186 2019-01-23  Tom Tromey  <tom@tromey.com>
13187             Pedro Alves  <palves@redhat.com>
13188
13189         * symfile.c: Include forward-scope-exit.h.
13190         (clear_symtab_users_cleanup): Replace forward declaration with
13191         a FORWARD_SCOPE_EXIT.
13192         (syms_from_objfile_1): Use the forward_scope_exit and
13193         gdb::optional instead of cleanup_function.
13194         (reread_symbols): Use the forward_scope_exit instead of
13195         cleanup_function.
13196         (clear_symtab_users_cleanup): Remove function.
13197
13198 2019-01-23  Tom Tromey  <tom@tromey.com>
13199             Pedro Alves  <palves@redhat.com>
13200
13201         * linux-nat.c: Include scope-exit.h.
13202         (cleanup_target_stop): Remove.
13203         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13204         SCOPE_EXIT.
13205
13206 2019-01-23  Tom Tromey  <tom@tromey.com>
13207             Pedro Alves  <palves@redhat.com>
13208
13209         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13210         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13211
13212 2019-01-23  Tom Tromey  <tom@tromey.com>
13213             Andrew Burgess  <andrew.burgess@embecosm.com>
13214             Pedro Alves  <palves@redhat.com>
13215
13216         * infrun.c (fetch_inferior_event): Use scope_exit.
13217         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13218         * top.c (execute_command): Use scope_exit.
13219         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13220         * utils.c (do_bpstat_clear_actions_cleanup)
13221         (make_bpstat_clear_actions_cleanup): Remove.
13222
13223 2019-01-23  Tom Tromey  <tom@tromey.com>
13224             Pedro Alves  <palves@redhat.com>
13225
13226         * infrun.c: Include "common/scope-exit.h"
13227         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13228         (wait_for_inferior): Use SCOPE_EXIT.
13229         (fetch_inferior_event): Use scope_exit.
13230
13231 2019-01-23  Tom Tromey  <tom@tromey.com>
13232             Pedro Alves  <palves@redhat.com>
13233
13234         * breakpoint.c (create_breakpoint): Remove cleanup.
13235
13236 2019-01-23  Tom Tromey  <tom@tromey.com>
13237             Andrew Burgess  <andrew.burgess@embecosm.com>
13238             Pedro Alves  <palves@redhat.com>
13239
13240 2019-01-23  Pedro Alves  <palves@redhat.com>
13241
13242         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13243
13244 2019-01-23  Pedro Alves  <palves@redhat.com>
13245             Andrew Burgess  <andrew.burgess@embecosm.com>
13246
13247         * gdbthread.h: Include "common/forward-scope-exit.h".
13248         (scoped_finish_thread_state): Redefine custom class in terms of
13249         forward_scope_exit.
13250
13251 2019-01-23  Pedro Alves  <palves@redhat.com>
13252             Andrew Burgess  <andrew.burgess@embecosm.com>
13253
13254         * common/forward-scope-exit.h: New file.
13255
13256 2019-01-23  Pedro Alves  <palves@redhat.com>
13257             Andrew Burgess  <andrew.burgess@embecosm.com>
13258             Tom Tromey  <tom@tromey.com>
13259
13260         * common/scope-exit.h: New file.
13261
13262 2019-01-23  Pedro Alves  <palves@redhat.com>
13263
13264         * common/preprocessor.h (ESC): Rename to ...
13265         (ESC_PARENS): ... this.
13266         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13267         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13268
13269 2019-01-23  Tom Tromey  <tom@tromey.com>
13270
13271         * language.h (class scoped_switch_to_sym_language_if_auto):
13272         Initialize m_lang in both cases.
13273
13274 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13275
13276         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13277         with XCNEW.
13278
13279 2019-01-22  Tom Tromey  <tom@tromey.com>
13280
13281         * corelow.c: Do not include sys/file.h.
13282
13283 2019-01-22  Tom Tromey  <tom@tromey.com>
13284
13285         * tui/tui-wingeneral.h: Include gdb_curses.h.
13286
13287 2019-01-22  Tom Tromey  <tom@tromey.com>
13288
13289         * source-cache.h (class source_cache) <get_source_lines,
13290         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13291
13292 2019-01-22  Tom Tromey  <tom@tromey.com>
13293
13294         * remote-fileio.h (struct remote_target): Declare.
13295
13296 2019-01-22  Tom Tromey  <tom@tromey.com>
13297
13298         * python/py-arch.c: Do not include py-ref.h.
13299         * python/py-bpevent.c: Do not include py-ref.h.
13300         * python/py-cmd.c: Do not include py-ref.h.
13301         * python/py-continueevent.c: Do not include py-ref.h.
13302         * python/py-event.h: Do not include py-ref.h.
13303         * python/py-evtregistry.c: Do not include py-ref.h.
13304         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13305         * python/py-frame.c: Do not include py-ref.h.
13306         * python/py-framefilter.c: Do not include py-ref.h.
13307         * python/py-function.c: Do not include py-ref.h.
13308         * python/py-infevents.c: Do not include py-ref.h.
13309         * python/py-linetable.c: Do not include py-ref.h.
13310         * python/py-objfile.c: Do not include py-ref.h.
13311         * python/py-param.c: Do not include py-ref.h.
13312         * python/py-prettyprint.c: Do not include py-ref.h.
13313         * python/py-progspace.c: Do not include py-ref.h.
13314         * python/py-symbol.c: Do not include py-ref.h.
13315         * python/py-symtab.c: Do not include py-ref.h.
13316         * python/py-type.c: Do not include py-ref.h.
13317         * python/py-unwind.c: Do not include py-ref.h.
13318         * python/py-utils.c: Do not include py-ref.h.
13319         * python/py-value.c: Do not include py-ref.h.
13320         * python/py-varobj.c: Do not include py-ref.h.
13321         * python/py-xmethods.c: Do not include py-ref.h.
13322         * python/python.c: Do not include py-ref.h.
13323         * varobj.c: Do not include py-ref.h.
13324
13325 2019-01-22  Tom Tromey  <tom@tromey.com>
13326
13327         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13328         keyword for bcache.
13329
13330 2019-01-22  Tom Tromey  <tom@tromey.com>
13331
13332         * compile/compile-cplus-types.c: Remove a comment by #include.
13333
13334 2019-01-22  Tom Tromey  <tom@tromey.com>
13335
13336         * compile/gcc-c-plugin.h: Include compile-internal.h.
13337
13338 2019-01-22  Tom Tromey  <tom@tromey.com>
13339
13340         * stabsread.c (EXTERN): Do not define.
13341         (symnum, next_symbol_text_func, processing_gcc_compilation)
13342         (within_function, global_sym_chain, global_stabs)
13343         (previous_stab_code, this_object_header_files)
13344         (n_this_object_header_files)
13345         (n_allocated_this_object_header_files): Define.
13346         * stabsread.h (EXTERN): Never define.  Use "extern".
13347
13348 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13349
13350         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13351         history_value.
13352
13353 2019-01-21  Tom Tromey  <tom@tromey.com>
13354
13355         * ui-out.c: Fix includes.
13356         * tui/tui-source.c: Fix includes.
13357         * target.c: Fix includes.
13358         * remote.c: Fix includes.
13359         * regcache.c: Fix includes.
13360         * python/py-block.c: Fix includes.
13361         * printcmd.c: Fix includes.
13362         * or1k-tdep.c: Fix includes.
13363         * mi/mi-main.c: Fix includes.
13364         * m32r-tdep.c: Fix includes.
13365         * csky-tdep.c: Fix includes.
13366         * compile/compile-cplus-types.c: Fix includes.
13367         * cli/cli-interp.c: Fix includes.
13368
13369 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13370
13371         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13372         for padding.
13373
13374 2019-01-16  Tom Tromey  <tom@tromey.com>
13375
13376         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13377         earlier.
13378         (struct objfile) <msymbols_range>: Move from top level.
13379         <msymbols>: New method.
13380         (class objfile_msymbols): Remove.
13381         * symtab.c (default_collect_symbol_completion_matches_break_on):
13382         Update.
13383         * symmisc.c (dump_msymbols): Update.
13384         * stabsread.c (scan_file_globals): Update.
13385         * objc-lang.c (info_selectors_command, info_classes_command)
13386         (find_methods): Update.
13387         * minsyms.c (find_solib_trampoline_target): Update.
13388         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13389         * coffread.c (coff_symfile_read): Update.
13390         * ada-lang.c (ada_lookup_simple_minsym)
13391         (ada_collect_symbol_completion_matches): Update.
13392
13393 2019-01-16  Tom Tromey  <tom@tromey.com>
13394
13395         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13396         type.  Remove no-argument constructor.
13397         <iterator::operator++>: Simplify.
13398         <begin>: Update.
13399         <end>: Use minimal_symbol_count.
13400
13401 2019-01-16  Tom Tromey  <tom@tromey.com>
13402
13403         * objfiles.h (struct objfile) <psymtabs>: New method.
13404         (class objfile_psymtabs): Remove.
13405         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13406         typedef.
13407         <range>: New method.
13408         (require_partial_symbols): Change return type.
13409         * psymtab.c (require_partial_symbols)
13410         (psym_expand_symtabs_matching): Update.
13411         * mdebugread.c (parse_partial_symbols): Update.
13412         * dbxread.c (dbx_end_psymtab): Update.
13413
13414 2019-01-15  Tom Tromey  <tom@tromey.com>
13415
13416         * symtab.c (lookup_objfile_from_block)
13417         (lookup_symbol_in_objfile_symtabs)
13418         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13419         (find_line_symtab, info_sources_command)
13420         (default_collect_symbol_completion_matches_break_on)
13421         (make_source_files_completion_list): Update.
13422         * symmisc.c (print_objfile_statistics, dump_objfile)
13423         (maintenance_print_symbols, maintenance_info_symtabs)
13424         (maintenance_check_symtabs, maintenance_info_line_tables):
13425         Update.
13426         * source.c (select_source_symtab)
13427         (forget_cached_source_info_for_objfile): Update.
13428         * objfiles.h (class objfile_compunits): Remove.
13429         (struct objfile) <compunits_range>: New typedef.
13430         (compunits): New method.
13431         * objfiles.c (objfile_relocate1): Update.
13432         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13433         * maint.c (count_symtabs_and_blocks): Update.
13434         * linespec.c (iterate_over_all_matching_symtabs): Update.
13435         * cp-support.c (add_symbol_overload_list_qualified): Update.
13436         * coffread.c (coff_symtab_read): Update.
13437         * ada-lang.c (add_nonlocal_symbols)
13438         (ada_collect_symbol_completion_matches)
13439         (ada_add_global_exceptions): Update.
13440
13441 2019-01-15  Tom Tromey  <tom@tromey.com>
13442
13443         * progspace.h (program_space) <objfiles_safe_range>: New
13444         typedef.
13445         <objfiles_safe>: New method.
13446         * objfiles.h (class all_objfiles_safe): Remove.
13447         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13448         * jit.c (jit_inferior_exit_hook): Update.
13449
13450 2019-01-17  Tom Tromey  <tom@tromey.com>
13451
13452         * progspace.h (program_space) <objfiles_range>: New typedef.
13453         <objfiles>: New method.
13454         <objfiles_head>: Rename from objfiles.
13455         (object_files): Update.
13456         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13457         * guile/scm-pretty-print.c
13458         (ppscm_find_pretty_printer_from_objfiles): Update.
13459         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13460         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13461         Update.
13462         * python/py-progspace.c (pspy_get_objfiles): Update.
13463         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13464         Update.
13465         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13466         (objfpy_lookup_objfile_by_build_id): Update.
13467         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13468         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13469         Update.
13470         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13471         (expand_symtab_containing_pc, lookup_objfile_from_block)
13472         (lookup_static_symbol, basic_lookup_transparent_type)
13473         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13474         (find_line_symtab, info_sources_command)
13475         (default_collect_symbol_completion_matches_break_on)
13476         (make_source_files_completion_list, find_main_name): Update.
13477         * symmisc.c (print_symbol_bcache_statistics)
13478         (print_objfile_statistics, maintenance_print_symbols)
13479         (maintenance_print_msymbols, maintenance_print_objfiles)
13480         (maintenance_info_symtabs, maintenance_check_symtabs)
13481         (maintenance_expand_symtabs, maintenance_info_line_tables):
13482         Update.
13483         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13484         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13485         (map_overlay_command, unmap_overlay_command)
13486         (simple_overlay_update, expand_symtabs_matching)
13487         (map_symbol_filenames): Update.
13488         * symfile-debug.c (set_debug_symfile): Update.
13489         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13490         Update.
13491         * source.c (select_source_symtab, forget_cached_source_info):
13492         Update.
13493         * solib.c (solib_read_symbols): Update.
13494         * solib-spu.c (append_ocl_sos): Update.
13495         * psymtab.c (maintenance_print_psymbols)
13496         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13497         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13498         * printcmd.c (info_symbol_command): Update.
13499         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13500         Update.
13501         * objfiles.h (class all_objfiles): Remove.
13502         * objfiles.c (have_partial_symbols, have_full_symbols)
13503         (have_minimal_symbols, qsort_cmp, update_section_map)
13504         (shared_objfile_contains_address_p)
13505         (default_iterate_over_objfiles_in_search_order): Update.
13506         * objc-lang.c (info_selectors_command, info_classes_command)
13507         (find_methods): Update.
13508         * minsyms.c (find_solib_trampoline_target): Update.
13509         * maint.c (maintenance_info_sections)
13510         (maintenance_translate_address, count_symtabs_and_blocks):
13511         Update.
13512         * main.c (captured_main_1): Update.
13513         * linux-thread-db.c (try_thread_db_load_from_pdir)
13514         (has_libpthread): Update.
13515         * linespec.c (iterate_over_all_matching_symtabs)
13516         (search_minsyms_for_name): Update.
13517         * jit.c (jit_find_objf_with_entry_addr): Update.
13518         * hppa-tdep.c (find_unwind_entry)
13519         (hppa_lookup_stub_minimal_symbol): Update.
13520         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13521         Update.
13522         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13523         (elf_gnu_ifunc_resolve_by_got): Update.
13524         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13525         * dwarf-index-write.c (save_gdb_index_command): Update.
13526         * cp-support.c (add_symbol_overload_list_qualified): Update.
13527         * breakpoint.c (create_overlay_event_breakpoint)
13528         (create_longjmp_master_breakpoint)
13529         (create_std_terminate_master_breakpoint)
13530         (create_exception_master_breakpoint): Update.
13531         * blockframe.c (find_pc_partial_function): Update.
13532         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13533         (ada_collect_symbol_completion_matches)
13534         (ada_add_global_exceptions): Update.
13535
13536 2019-01-17  Tom Tromey  <tom@tromey.com>
13537
13538         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13539         declare VEC.
13540         (solib_target_parse_libraries): Change return type.
13541         (library_list_start_segment, library_list_start_section)
13542         (library_list_end_library, library_list_start_library); Update.
13543         (solib_target_free_library_list): Remove.
13544         (solib_target_parse_libraries): Remove cleanup.  Change return
13545         type.
13546         (solib_target_current_sos): Update.
13547
13548 2019-01-17  Tom Tromey  <tromey@bapiya>
13549
13550         * valprint.c: Replace "the the" with "the".
13551         * symtab.c: Replace "the the" with "the".
13552         * solib.c: Replace "the the" with "the".
13553         * solib-dsbt.c: Replace "the the" with "the".
13554         * linespec.c: Replace "the the" with "the".
13555         * dwarf2loc.h: Replace "the the" with "the".
13556         * amd64-windows-tdep.c: Replace "the the" with "the".
13557         * aarch64-tdep.c: Replace "the the" with "the".
13558
13559 2019-01-16  Keith Seitz  <keiths@redhat.com>
13560
13561         PR gdb/23773
13562         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13563         <builder>: Rename to ..
13564         <m_builder>: ... this and make private.
13565         (dwarf2_cu::get_builder): New method.  Change all users of
13566         `builder' to use this method.
13567         (dwarf2_start_symtab): Move to ...
13568         (dwarf2_cu::start_symtab): ... here.  Update all callers
13569         (setup_type_unit_groups): Move to ...
13570         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13571         callers.
13572         (dwarf2_cu::reset_builder): New method.
13573         (process_full_compunit, process_full_type_unit): Use
13574         dwarf2_cu::reset_builder.
13575         (follow_die_offset): Record the ancestor CU if it is different
13576         from the followed DIE's CU.
13577         (follow_die_sig_1): Likewise.
13578
13579 2019-01-15  Tom Tromey  <tom@tromey.com>
13580
13581         * remote.c (class remote_state) <buf>: Now a char_vector.
13582         <buf_size>: Remove.
13583         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13584         parameter.
13585         (remote_target::getpkt_or_notif_sane_1)
13586         (remote_target::getpkt_sane)
13587         (remote_target::getpkt_or_notif_sane): Likewise.
13588         (class remote_target) <putpkt>: New overload.
13589         (remote_target::read_frame): Change type of "buf_p".  Remove
13590         sizeof_p parameter.
13591         (packet_ok): New overload.
13592         (packet_check_result): New overload.
13593         Update all uses.
13594
13595 2019-01-14  Tom Tromey  <tom@tromey.com>
13596
13597         * remote-notif.c (handle_notification, remote_notif_ack)
13598         (remote_notif_parse): Make "buf" const.
13599         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13600         const.
13601         (remote_notif_parse, remote_notif_ack, handle_notification):
13602         Likewise.
13603         * remote.c (remote_notif_stop_parse): Make "buf" const.
13604         (remote_target::remote_parse_stop_reply): Make "buf" const.
13605         (remote_notif_stop_ack): Make "buf" const.
13606
13607 2019-01-14  Tom Tromey  <tom@tromey.com>
13608
13609         * remote.c (remote_console_output): Make parameter const.
13610
13611 2019-01-14  Tom Tromey  <tom@tromey.com>
13612
13613         * target-debug.h (target_debug_print_signals): Constify.
13614         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13615         * procfs.c (procfs_target::pass_signals): Update.
13616         * linux-nat.c (linux_nat_target::pass_signals): Update.
13617         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13618         * target-delegates.c: Rebuild.
13619         * remote.c (remote_target::program_signals): Update.
13620         (remote_target::pass_signals): Update.
13621         * target.c (target_pass_signals): Constify argument.
13622         (target_program_signals): Likewise.
13623         * target.h (struct target_ops) <pass_signals, program_signals>:
13624         Constify argument.
13625         (target_pass_signals, target_program_signals): Constify argument.
13626
13627 2019-01-14  Tom Tromey  <tom@tromey.com>
13628
13629         PR tui/28819:
13630         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13631
13632 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13633
13634         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13635         field.
13636         * rs6000-tdep.c: Include reggroups.h.
13637         (IS_V_ALIAS_PSEUDOREG): Define.
13638         (rs6000_register_name): Return names for the "vX" aliases.
13639         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13640         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13641         aliases.  Call default_register_reggroup_p for all other
13642         pseudo-registers.
13643         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13644         New functions.
13645         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13646         Handle "vX" aliases.
13647         (v_alias_pseudo_register_collect): New function.
13648         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13649         (rs6000_gdbarch_init): Initialize "vX" aliases as
13650         pseudo-registers.  Restore registration of
13651         rs6000_pseudo_register_reggroup_p with
13652         set_tdesc_pseudo_register_reggroup_p.
13653
13654 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13655
13656         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13657         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13658         set_gdbarch_num_pseudo_regs.
13659
13660 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13661
13662         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13663         Remove arg prefixname, add do_set and do_show.
13664         Add member functions set_list and show_list.
13665         * cli/cli-style.c (class cli_style_option): Update accordingly.
13666         (style_set_list): Move to file scope.
13667         (style_show_list): Likewise.
13668         (set_style): Call help_list.
13669         (show_style): Call cmd_show_list.
13670         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13671         Update to use the new macro.
13672
13673 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13674
13675         * ada-lang.c (_initialize_ada_language): Expand the help text
13676         for the "catch exception" command.
13677
13678 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13679
13680         * symtab.c (matching_obj_sections): Initialize obj,
13681         declare it closer to its usage.
13682
13683 2019-01-10  Tom Tromey  <tom@tromey.com>
13684
13685         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13686         (basic_inf_threads_range): Remove.
13687         (inf_threads_range, inf_non_exited_threads_range)
13688         (safe_inf_threads_range): Use next_adapter.
13689
13690 2019-01-10  Keith Seitz  <keiths@redhat.com>
13691
13692         PR gdb/23712
13693         PR symtab/23010
13694         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13695         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13696
13697 2019-01-10  Keith Seitz  <keiths@redhat.com>
13698
13699         PR gdb/23712
13700         PR symtab/23010
13701         * dictionary.c (pending_to_vector): Remove.
13702         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13703         Remove _1 suffix, replacing functions of the same name.  Update
13704         all callers.
13705         (dict_create_hashed, dict_create_hashed_expandable)
13706         (dict_create_linear, dict_create_linear_expandable, dict_free)
13707         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13708         Make functions static.
13709
13710 2019-01-10  Keith Seitz  <keiths@redhat.com>
13711
13712         PR gdb/23712
13713         PR symtab/23010
13714         * dictionary.h (struct dictionary): Replace declaration with
13715         multidictionary.
13716         (dict_create_hashed, dict_create_hashed_expandable)
13717         (dict_create_linear, dict_create_linear_expandable)
13718         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13719         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13720         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13721         taking multidictionary argument.
13722         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13723         * block.h (struct block) <dict>: Change to multidictionary
13724         and rename `multidict'.
13725         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13726         symmisc.c: Update all dictionary references to multidictionary.
13727
13728 2019-01-10  Keith Seitz  <keiths@redhat.com>
13729
13730         PR gdb/23712
13731         PR symtab/23010
13732         * dictionary.c: Include unordered_map.
13733         (pending_to_vector): New function.
13734         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13735         Rewrite the non-"_1" functions to take vector instead
13736         of linked list.
13737         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13738         "new" _1 versions of the same name.
13739         (multidictionary): Define.
13740         (std::hash<enum language): New definition.
13741         (collate_pending_symbols_by_language, mdict_create_hashed)
13742         (mdict_create_hashed_expandable, mdict_create_linear)
13743         (mdict_create_linear_expandable, mdict_free)
13744         (find_language_dictionary, create_new_language_dictionary)
13745         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13746         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13747         (mdict_size, mdict_empty): New functions.
13748         * dictionary.h (mdict_iterator): Define.
13749
13750 2019-01-10  Pedro Alves  <palves@redhat.com>
13751
13752         * breakpoint.c (read_uploaded_action)
13753         (create_tracepoint_from_upload): Adjust to use
13754         gdb::unique_xmalloc_ptr.
13755         * ctf.c (ctf_write_uploaded_tp):
13756         (SET_ARRAY_FIELD): Use emplace_back.
13757         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13758         * tracefile-tfile.c (tfile_write_uploaded_tp):
13759         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13760         gdb::unique_xmalloc_ptr.
13761         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13762         at_string, cond_string, cmd_strings>: Replace char pointers
13763         with gdb::unique_xmalloc_ptr.
13764
13765 2019-01-10  Pedro Alves  <palves@redhat.com>
13766
13767         * solib-target.c (library_list_start_library): Don't xstrdup name.
13768
13769 2019-01-10  Pedro Alves  <palves@redhat.com>
13770
13771         * mdebugread.c (parse_partial_symbols): Use
13772         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13773
13774 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13775
13776         * linux-fork.c (scoped_switch_fork_info)
13777         <~scoped_switch_fork_info>: Fix incorrect variable name.
13778
13779 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13780
13781         * linux-fork.c (scoped_switch_fork_info)
13782         <scoped_switch_fork_info>: Make explicit.
13783         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13784
13785 2019-01-10  Tom Tromey  <tom@tromey.com>
13786
13787         * objfiles.h (objfile::reset_psymtabs): Update.
13788         * objfiles.c (objfile::objfile): Update.
13789         * psymtab.h (psymtab_storage::obstack): Update.
13790         (psymtab_storage::m_obstack): Use gdb::optional.
13791         (class psymtab_storage): Update comment.  Remove objfile
13792         parameter.
13793         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13794
13795 2019-01-10  Tom Tromey  <tom@tromey.com>
13796
13797         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13798         <free_psymtabs>: Now private.
13799         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13800         (allocate_psymtab): Use new method.
13801
13802 2019-01-10  Tom Tromey  <tom@tromey.com>
13803
13804         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13805         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13806         * mdebugread.c (parse_partial_symbols): Use
13807         allocate_dependencies.
13808         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13809         allocate_dependencies.
13810         (process_psymtab_comp_unit_reader)
13811         (build_type_psymtab_dependencies): Likewise.
13812         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13813
13814 2019-01-10  Tom Tromey  <tom@tromey.com>
13815
13816         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13817         PSYMBOL_SET_LANGUAGE.
13818         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13819
13820 2019-01-10  Tom Tromey  <tom@tromey.com>
13821
13822         * psymtab.h (psymtab_storage::obstack): New method.
13823         <m_obstack>: Rename from obstack; now private.
13824         * psymtab.c (psymtab_storage): Update.
13825         * dwarf2read.c (create_addrmap_from_index)
13826         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13827         Update.
13828
13829 2019-01-10  Tom Tromey  <tom@tromey.com>
13830
13831         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13832         * objfiles.h (objfile::reset_psymtabs): New method.
13833
13834 2019-01-10  Tom Tromey  <tom@tromey.com>
13835
13836         * symmisc.c (print_symbol_bcache_statistics): Update.
13837         (print_objfile_statistics): Update.
13838         * symfile.c (reread_symbols): Update.
13839         * psymtab.h (class psymtab_storage): New.
13840         * psymtab.c (psymtab_storage): New constructor.
13841         (~psymtab_storage): New destructor.
13842         (require_partial_symbols): Update.
13843         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13844         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13845         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13846         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13847         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13848         (start_psymtab_common, end_psymtab_common)
13849         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13850         (allocate_psymtab): Update.
13851         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13852         Update.
13853         (dump_psymtab_addrmap, maintenance_print_psymbols)
13854         (maintenance_check_psymtabs): Update.
13855         (class objfile_psymtabs): Move to objfiles.h.
13856         * psympriv.h (discard_psymtab): Now inline.
13857         (psymtab_discarder::psymtab_discarder): Update.
13858         (psymtab_discarder::~psymtab_discarder): Update.
13859         (ALL_OBJFILE_PSYMTABS): Rewrite.
13860         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13861         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13862         Remove fields.
13863         <partial_symtabs>: New field.
13864         (class objfile_psymtabs): Move from psymtab.h.  Update.
13865         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13866         psymbol_cache.
13867         (objfile::~objfile): Don't destroy psymbol_cache.
13868         * mdebugread.c (parse_partial_symbols): Update.
13869         * dwarf2read.c (create_addrmap_from_index)
13870         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13871         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13872         (add_partial_subprogram, dwarf2_ranges_read): Update.
13873         * dwarf-index-write.c (write_address_map)
13874         (write_one_signatured_type, recursively_write_psymbols)
13875         (class debug_names, class debug_names, write_psymtabs_to_index):
13876         Update.
13877
13878 2019-01-10  Tom Tromey  <tom@tromey.com>
13879
13880         * symtab.h (SYMBOL_SET_NAMES): Update.
13881         (symbol_set_names): Update.
13882         (MSYMBOL_SET_NAMES): Update.
13883         * symtab.c (symbol_set_names): Change argument to be an
13884         objfile_per_bfd_storage.
13885         * psymtab.c (add_psymbol_to_bcache): Update.
13886         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13887
13888 2019-01-10  Tom Tromey  <tom@tromey.com>
13889
13890         * symtab.c (create_demangled_names_hash): Change argument to be an
13891         objfile_per_bfd_storage.
13892         (symbol_set_names): Update.
13893
13894 2019-01-10  Tom Tromey  <tom@tromey.com>
13895
13896         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13897         init_psymbol_list.
13898         * psymtab.c (init_psymbol_list): Do nothing if already called.
13899         * psympriv.h (init_psymbol_list): Add comment.
13900         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13901         init_psymbol_list.
13902         * dbxread.c (dbx_symfile_read): Unconditionally call
13903         init_psymbol_list.
13904
13905 2019-01-10  Tom Tromey  <tom@tromey.com>
13906
13907         * xcoffread.c (scan_xcoff_symtab): Update.
13908         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13909         "where".
13910         * mdebugread.c (parse_partial_symbols)
13911         (handle_psymbol_enumerators): Update.
13912         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13913         * dbxread.c (read_dbx_symtab): Update.
13914         * psympriv.h (psymbol_placement): New enum.
13915         (add_psymbol_to_list): Update.
13916
13917 2019-01-10  Tom Tromey  <tom@tromey.com>
13918
13919         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13920         static_psymbols parameters.
13921         (scan_xcoff_symtab): Update.
13922         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13923         static_psymbols parameters.
13924         * psympriv.h (start_psymtab_common): Update.
13925         * mdebugread.c (parse_partial_symbols): Update.
13926         * dwarf2read.c (create_partial_symtab): Update.
13927         * dbxread.c (read_dbx_symtab): Update.
13928         (start_psymtab): Remove global_psymbols and static_psymbols
13929         parameters.
13930
13931 2019-01-10  Tom Tromey  <tom@tromey.com>
13932
13933         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13934         * psymtab.c (allocate_psymtab): Add comment.
13935         * psympriv.h (allocate_psymtab): Add comment.
13936         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13937         initializations.
13938         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13939
13940 2019-01-10  Tom Tromey  <tom@tromey.com>
13941
13942         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13943         Don't declare.
13944         * mipsread.c: Include mdebugread.h.
13945         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13946         Declare.
13947         * elfread.c: Include mdebugread.h.
13948
13949 2019-01-09  Tom Tromey  <tom@tromey.com>
13950
13951         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13952         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13953         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13954         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13955         (psym_lookup_symbol, psym_find_last_source_symtab)
13956         (psym_forget_cached_source_info, psym_print_stats)
13957         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13958         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13959         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13960         (psym_find_compunit_symtab_by_address)
13961         (maintenance_print_psymbols, maintenance_info_psymtabs)
13962         (maintenance_check_psymtabs): Use ranged for.
13963         * psymtab.h (class objfile_psymtabs): New.
13964         (require_partial_symbols): Return objfile_psymtabs.
13965         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13966
13967 2019-01-09  Tom Tromey  <tom@tromey.com>
13968
13969         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13970         (find_pc_mapped_section, list_overlays_command)
13971         (map_overlay_command, unmap_overlay_command)
13972         (simple_overlay_update): Use all_objfiles.
13973         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13974         * printcmd.c (info_symbol_command): Use all_objfiles.
13975         * objfiles.h (ALL_OBJSECTIONS): Remove.
13976         * maint.c (maintenance_translate_address): Use all_objfiles.
13977         * gcore.c (gcore_create_callback): Use all_objfiles.
13978         (objfile_find_memory_regions): Likewise.
13979
13980 2019-01-09  Tom Tromey  <tom@tromey.com>
13981
13982         * symtab.c (find_line_symtab, info_sources_command)
13983         (make_source_files_completion_list): Use objfile_compunits.
13984         * source.c (select_source_symtab): Use objfile_compunits.
13985         * objfiles.h (struct objfile): Update comment.
13986         (ALL_OBJFILES): Remove.
13987         (ALL_FILETABS): Remove.
13988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13989         objfile_compunits.
13990
13991 2019-01-09  Tom Tromey  <tom@tromey.com>
13992
13993         * symmisc.c (print_objfile_statistics, dump_objfile)
13994         (maintenance_print_symbols): Use compunit_filetabs.
13995         * source.c (forget_cached_source_info_for_objfile): Use
13996         compunit_filetabs.
13997         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13998         (ALL_FILETABS): Use compunit_filetabs.
13999         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14000         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14001
14002 2019-01-09  Tom Tromey  <tom@tromey.com>
14003
14004         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14005         (compunit_filetabs): New.
14006         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14007         compunit_filetabs.
14008         (info_sources_command, make_source_files_completion_list): Remove
14009         declaration.
14010         * symmisc.c (print_objfile_statistics, dump_objfile)
14011         (maintenance_print_symbols): Remove declaration.
14012         (maintenance_info_symtabs): Use compunit_filetabs.
14013         (maintenance_info_line_tables): Likewise.
14014         * source.c (select_source_symtab): Change local variable name.
14015         (forget_cached_source_info_for_objfile): Remove declaration.
14016         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14017         * objfiles.c (objfile_relocate1): Remove declaration.
14018         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14019         declaration.
14020         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14021         * coffread.c (coff_symtab_read): Remove declaration.
14022         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14023         compunit_filetabs.
14024
14025 2019-01-09  Tom Tromey  <tom@tromey.com>
14026
14027         * symtab.c (lookup_objfile_from_block)
14028         (find_pc_sect_compunit_symtab, search_symbols)
14029         (default_collect_symbol_completion_matches_break_on): Use
14030         objfile_compunits.
14031         * objfiles.h (ALL_COMPUNITS): Remove.
14032         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14033         * cp-support.c (add_symbol_overload_list_qualified): Use
14034         objfile_compunits.
14035         * ada-lang.c (ada_collect_symbol_completion_matches)
14036         (ada_add_global_exceptions): Use objfile_compunits.
14037
14038 2019-01-09  Tom Tromey  <tom@tromey.com>
14039
14040         * source.c (select_source_symtab)
14041         (forget_cached_source_info_for_objfile): Remove declaration.
14042         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14043         declaration.
14044         * maint.c (count_symtabs_and_blocks): Remove declaration.
14045         * cp-support.c (add_symbol_overload_list_qualified): Remove
14046         declaration.
14047         * coffread.c (coff_symtab_read): Remove declaration.
14048         * symtab.c (lookup_symbol_in_objfile_symtabs)
14049         (basic_lookup_transparent_type_1): Use objfile_compunits.
14050         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14051         (info_sources_command, search_symbols)
14052         (default_collect_symbol_completion_matches_break_on)
14053         (make_source_files_completion_list): Remove declaration.
14054         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14055         (ada_collect_symbol_completion_matches)
14056         (ada_add_global_exceptions): Remove declaration.
14057         * linespec.c (iterate_over_all_matching_symtabs): Use
14058         objfile_compunits.
14059         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14060         (class objfile_compunits): New.
14061         (ALL_COMPUNITS): Use objfile_compunits.
14062         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14063         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14064         objfile_compunits.
14065         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14066
14067 2019-01-09  Tom Tromey  <tom@tromey.com>
14068
14069         * symtab.c (search_symbols)
14070         (default_collect_symbol_completion_matches_break_on): Use
14071         objfile_msymbols.
14072         * ada-lang.c (ada_lookup_simple_minsym)
14073         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14074         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14075         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14076         objfile_msymbols.
14077         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14078         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14079         * objc-lang.c (find_methods): Use objfile_msymbols.
14080         (info_selectors_command, info_classes_command): Likewise.
14081         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14082         * objfiles.h (class objfile_msymbols): New.
14083         (ALL_OBJFILE_MSYMBOLS): Remove.
14084         (ALL_MSYMBOLS): Remove.
14085
14086 2019-01-09  Tom Tromey  <tom@tromey.com>
14087
14088         * common/next-iterator.h (next_adapter): Add Iterator template
14089         parameter.
14090         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14091         (class all_objfiles_safe): New.
14092         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14093         * objfiles.c (put_objfile_before): Update comment.
14094         (add_separate_debug_objfile): Likewise.
14095         (free_all_objfiles): Use all_objfiles_safe.
14096         (objfile_purge_solibs): Likewise.
14097
14098 2019-01-09  Tom Tromey  <tom@tromey.com>
14099
14100         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14101         (expand_symtab_containing_pc, lookup_static_symbol)
14102         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14103         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14104         all_objfiles.
14105         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14106         * breakpoint.c (create_overlay_event_breakpoint)
14107         (create_longjmp_master_breakpoint)
14108         (create_std_terminate_master_breakpoint)
14109         (create_exception_master_breakpoint): Use all_objfiles.
14110         * linux-thread-db.c (try_thread_db_load_from_pdir)
14111         (has_libpthread): Use all_objfiles.
14112         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14113         * linespec.c (iterate_over_all_matching_symtabs)
14114         (search_minsyms_for_name): Use all_objfiles.
14115         * maint.c (maintenance_info_sections): Use all_objfiles.
14116         * main.c (captured_main_1): Use all_objfiles.
14117         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14118         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14119         * guile/scm-pretty-print.c
14120         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14121         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14122         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14123         (maintenance_print_msymbols): Use all_objfiles.
14124         * source.c (select_source_symtab): Use all_objfiles.
14125         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14126         * symfile.c (remove_symbol_file_command)
14127         (expand_symtabs_matching, map_symbol_filenames): Use
14128         all_objfiles.
14129         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14130         all_objfiles.
14131         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14132         * objc-lang.c (find_methods): Use all_objfiles.
14133         * objfiles.c (have_partial_symbols, have_full_symbols)
14134         (have_minimal_symbols, qsort_cmp)
14135         (default_iterate_over_objfiles_in_search_order): Use
14136         all_objfiles.
14137         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14138         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14139         (maintenance_check_psymtabs): Use all_objfiles.
14140         (ALL_PSYMTABS): Remove.
14141         * compile/compile-object-run.c (do_module_cleanup): Use
14142         all_objfiles.
14143         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14144         * cp-support.c (add_symbol_overload_list_qualified): Use
14145         all_objfiles.
14146         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14147         Use all_objfiles.
14148         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14149         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14150         all_objfiles.
14151         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14152         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14153         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14154         Uses all_objfiles.
14155         * solib.c (solib_read_symbols): Use all_objfiles
14156
14157 2019-01-09  Tom Tromey  <tom@tromey.com>
14158
14159         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14160         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14161         all_objfiles.
14162         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14163         * symmisc.c (print_symbol_bcache_statistics)
14164         (print_objfile_statistics, maintenance_print_objfiles)
14165         (maintenance_info_symtabs, maintenance_check_symtabs)
14166         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14167         all_objfiles.
14168         * source.c (forget_cached_source_info): Use all_objfiles.
14169         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14170         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14171         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14172         * objfiles.c (update_section_map): Use all_objfiles.
14173         (shared_objfile_contains_address_p): Likewise.
14174         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14175         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14176
14177 2019-01-09  Tom Tromey  <tom@tromey.com>
14178
14179         * common/next-iterator.h: New file.
14180         * objfiles.h (class all_objfiles): New.
14181         (struct objfile_iterator): New.
14182
14183 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14184
14185         * NEWS: Move the description of the changed "frame", "select-frame",
14186          and "info frame" commands to the Changed commands section.
14187
14188 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14189
14190         * gdbtypes.c (check_stub_method_group): Remove handling of old
14191         mangling schemes.
14192         * linespec.c (find_methods): Likewise.
14193         * stabsread.c (read_member_functions): Likewise.
14194         * valops.c (search_struct_method): Likewise.
14195         (value_struct_elt_for_reference): Likewise.
14196         * NEWS: Mention this change.
14197
14198 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14199
14200         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14201         print_source_lines.
14202         * source.c (print_source_lines_base): Update line number check.
14203         (print_source_lines): New function.
14204         (source_lines_range::source_lines_range): New function.
14205         * source.h (class source_lines_range): New class.
14206         (print_source_lines): New declaration.
14207
14208 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14209
14210         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14211
14212 2019-01-08  Tom Tromey  <tom@tromey.com>
14213             Simon Marchi  <simon.marchi@ericsson.com>
14214
14215         PR gdb/24060
14216         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14217         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14218         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14219         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14220         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14221         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14222
14223 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14224
14225         * source.c (select_source_symtab): Move header comment to
14226         declaration in source.h.
14227         (forget_cached_source_info_for_objfile): Likewise.
14228         (forget_cached_source_info): Likewise.
14229         (identify_source_line): Likewise.
14230         * source.h (identify_source_line): Move declaration from symtab.h
14231         and add comment from source.c
14232         (print_source_lines): Likewise.
14233         (forget_cached_source_info_for_objfile): Likewise.
14234         (forget_cached_source_info): Likewise.
14235         (select_source_symtab): Likewise.
14236         (enum print_source_lines_flag): Move definition from symtab.h.
14237         * symtab.h (identify_source_line): Move declaration to source.h.
14238         (print_source_lines): Likewise.
14239         (forget_cached_source_info_for_objfile): Likewise.
14240         (forget_cached_source_info): Likewise.
14241         (select_source_symtab): Likewise.
14242         (enum print_source_lines_flag): Move definition to source.h.
14243         * tui/tui-hooks.c: Add 'source.h' include.
14244
14245 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14246
14247         * source.c (print_source_lines_base): Handle requests to print
14248         reverse line number sequences, and guard against empty lines
14249         string.
14250
14251 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14252
14253         * source.c (print_source_lines_base): Fix skip of '\r' if next
14254         character is '\n'.
14255
14256 2019-01-06  Tom Tromey  <tom@tromey.com>
14257
14258         * c-exp.y (struct c_parse_state) <macro_original_text,
14259         expansion_obstack>: New member.
14260         (macro_original_text, expansion_obstack): Remove globals.
14261         (scan_macro_expansion, scanning_macro_expansion)
14262         (finished_macro_expansion): Update.
14263         (scan_macro_cleanup): Remove.
14264         (yylex, c_parse): Update.
14265
14266 2019-01-06  Tom Tromey  <tom@tromey.com>
14267
14268         * c-exp.y (struct c_parse_state) <strings>: New member.
14269         (operator_stoken): Update.
14270
14271 2019-01-06  Tom Tromey  <tom@tromey.com>
14272
14273         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14274         (union type_stack_elt) <typelist_val>: Now a pointer to
14275         std::vector.
14276         (type_stack_cleanup): Don't declare.
14277         (push_typelist): Update.
14278         * parse.c (pop_typelist): Return a std::vector.
14279         (push_typelist): Take a std::vector.
14280         (follow_types): Update.  Do not free args.
14281         (type_stack_cleanup): Remove.
14282         * c-exp.y (struct c_parse_state): New.
14283         (cpstate): New global.
14284         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14285         (nonempty_typelist): Update.
14286         (func_mod): Create a new vector.
14287         (c_parse): Create a c_parse_state.
14288         (check_parameter_typelist): Do not delete params.
14289         (function_method): Update.  Do not delete type_list.
14290
14291 2019-01-06  Tom Tromey  <tom@tromey.com>
14292
14293         PR gdb/28155:
14294         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14295         check_typedef.
14296         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14297         (print_return_value): Likewise.
14298
14299 2019-01-05  Tom Tromey  <tom@tromey.com>
14300
14301         * contrib/cleanup_check.py: Remove.
14302         * contrib/gcc-with-excheck: Remove.
14303         * contrib/exsummary.py: Remove.
14304         * contrib/excheck.py: Remove.
14305
14306 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14307
14308         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14309         NULL. Initialize tpprev to NULL instead of assigning it
14310         to NULL on the next statement.
14311         * windows-nat.c (windows_delete_thread): Remove check for
14312         main_thread_id before printing thread exit notifications.
14313         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14314         Remove thread ID check against main_thread_id.
14315         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14316         windows_delete_thread.
14317         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14318
14319 2019-01-04  Tom Tromey  <tom@tromey.com>
14320
14321         * compile/compile.c (_initialize_compile): Use upper case for
14322         metasyntactic variables.
14323         * symmisc.c (_initialize_symmisc): Use upper case for
14324         metasyntactic variables.
14325         * psymtab.c (_initialize_psymtab): Use upper case for
14326         metasyntactic variables.
14327         * demangle.c (demangle_command): Use upper case for metasyntactic
14328         variables.
14329         (_initialize_demangler): Likewise.
14330         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14331         variables.
14332
14333 2019-01-03  Tom Tromey  <tom@tromey.com>
14334
14335         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14336
14337 2019-01-03  Tom Tromey  <tom@tromey.com>
14338
14339         * python/py-symtab.c (salpy_str): Update.
14340         (struct salpy_sal_object) <symtab>: Now a PyObject.
14341         (salpy_dealloc): Update.
14342         (del_objfile_sal): Use gdbpy_ref.
14343
14344 2019-01-03  Tom Tromey  <tom@tromey.com>
14345
14346         * python/py-type.c (convert_field): Use new_reference.  Return
14347         gdbpy_ref.
14348         (make_fielditem): Return gdbpy_ref.
14349         (typy_fields): Update.
14350         (typy_getitem): Update.
14351         (field_name): Return gdbpy_ref.  Use new_reference.
14352         (typy_iterator_iternext): Update.
14353
14354 2019-01-03  Tom Tromey  <tom@tromey.com>
14355
14356         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14357
14358 2019-01-03  Tom Tromey  <tom@tromey.com>
14359
14360         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14361         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14362         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14363         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14364         (pspy_set_type_printers): Likewise.
14365         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14366         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14367         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14368         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14369         (objfpy_set_type_printers): Likewise.
14370
14371 2019-01-03  Tom Tromey  <tom@tromey.com>
14372
14373         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14374         (gdbpy_print_stack): Use gdbpy_err_fetch.
14375         * python/python-internal.h (class gdbpy_err_fetch): New class.
14376         (class gdbpy_enter) <m_error_type, m_error_value,
14377         m_error_traceback>: Remove.
14378         <m_error>: New member.
14379         (gdbpy_exception_to_string): Don't declare.
14380         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14381         * python/py-value.c (convert_value_from_python): Use
14382         gdbpy_err_fetch.
14383         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14384         gdbpy_exception_to_string.
14385         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14386         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14387         gdbpy_err_fetch.
14388
14389 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14390
14391         * linux-nat.c (delete_lwp_cleanup): Delete.
14392         (struct lwp_deleter): New struct.
14393         (lwp_info_up): New typedef.
14394         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14395         lwp_info_up.
14396
14397 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14398
14399         * linux-fork.c (class scoped_switch_fork_info): New class.
14400         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14401
14402 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14403
14404         * valops.c (find_overload_match): Remove use of null_cleanup, and
14405         calls to do_cleanups.
14406
14407 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14408
14409         * compile/compile-cplus-types.c
14410         (compile_cplus_instance::decl_name): Handle changes to
14411         cp_func_name.
14412         * cp-support.c (cp_func_name): Update header comment, update
14413         return type.
14414         * cp-support.h (cp_func_name): Update return type in declaration.
14415         * valops.c (find_overload_match): Move temp_func local to top
14416         level of function and change its type.  Use temp_func to hold and
14417         delete temporary string obtained from cp_func_name.
14418
14419 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14420
14421         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14422         gdb::char_vector, remove cleanup, and update uses of `msg`.
14423
14424 2019-01-03  Jim Wilson  <jimw@sifive.com>
14425
14426         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14427
14428 2019-01-02  Tom Tromey  <tom@tromey.com>
14429
14430         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14431         (tdesc_parse_xml): Remove cleanups.
14432         * target-descriptions.h (make_cleanup_free_target_description):
14433         Don't declare.
14434         (target_desc_deleter): New struct.
14435         (target_desc_up): New typedef.
14436         * target-descriptions.c (target_desc_deleter::operator()): Rename
14437         from free_target_description.
14438         (make_cleanup_free_target_description): Remove.
14439
14440 2019-01-02  Tom Tromey  <tom@tromey.com>
14441
14442         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14443         constructor, destructor.
14444         (linespec_parser): Remove typedef.
14445         (~linespec_parser): Rename from linespec_parser_delete.
14446         (linespec_lex_to_end, linespec_complete_label)
14447         (linespec_complete): Update.
14448         (decode_line_full): Remove cleanups.
14449         (decode_line_1): Update.
14450
14451 2019-01-02  Tom Tromey  <tom@tromey.com>
14452
14453         * python/python-internal.h (inferior_to_inferior_object): Change
14454         return type.
14455         * python/py-exitedevent.c (create_exited_event_object): Update.
14456         * python/py-inferior.c (inferior_to_inferior_object): Return
14457         gdbpy_ref.
14458         (python_new_inferior, python_inferior_deleted)
14459         (thread_to_thread_object, delete_thread_object)
14460         (build_inferior_list, gdbpy_selected_inferior): Update.
14461         * python/py-infthread.c (create_thread_object): Update.  Also fail
14462         if inferior_to_inferior_object fails.
14463
14464 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14465
14466         * inferior.h (class inferior) <displaced_step_state>: New field.
14467         * infrun.h (struct displaced_step_state): Move here from
14468         infrun.c.  Initialize fields, add constructor.
14469         <inf>: Remove field.
14470         <reset>: New method.
14471         * infrun.c (struct displaced_step_inferior_state): Move to
14472         infrun.h.
14473         (displaced_step_inferior_states): Remove.
14474         (get_displaced_stepping_state): Adust.
14475         (displaced_step_in_progress_any_inferior): Adjust.
14476         (displaced_step_in_progress_thread): Adjust.
14477         (displaced_step_in_progress): Adjust.
14478         (add_displaced_stepping_state): Remove.
14479         (get_displaced_step_closure_by_addr): Adjust.
14480         (remove_displaced_stepping_state): Remove.
14481         (infrun_inferior_exit): Call displaced_step_state.reset.
14482         (use_displaced_stepping): Don't check for NULL.
14483         (displaced_step_prepare_throw): Call
14484         get_displaced_stepping_state.
14485         (displaced_step_fixup): Don't check for NULL.
14486         (prepare_for_detach): Don't check for NULL.
14487
14488 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14489
14490         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14491          in case of call that did not complete.
14492
14493 2019-01-02  Andrey Utkin  <autkin@undo.io>
14494
14495         * symfile.c (find_separate_debug_file): Fix search of debug files for
14496         remote debuggee.
14497
14498 2019-01-02  Tom Tromey  <tom@tromey.com>
14499
14500         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14501         indentation.
14502         * python/py-frame.c (frapy_older): Remove cast.
14503         (frapy_newer): Likewise.
14504         * python/py-breakpoint.c (local_setattro): Remove cast.
14505         * python/py-arch.c (archpy_name): Remove local variable.
14506         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14507
14508 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14509
14510         * unittests/basic_string_view/element_access/char/empty.cc:
14511         Fix year range in copyright header.
14512
14513 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14514
14515         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14516         Delete.
14517         <operator==>: Update with for removed field.
14518         <hash>: Likewise.
14519         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14520         <isa_features>: ...this.
14521         <abi_features>: New field.
14522         (riscv_isa_flen): Update comment.
14523         (riscv_abi_xlen): New declaration.
14524         (riscv_abi_flen): New declaration.
14525         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14526         isa_features.
14527         (riscv_abi_xlen): New function.
14528         (riscv_isa_flen): Update to get answer from isa_features.
14529         (riscv_abi_flen): New function.
14530         (riscv_has_fp_abi): Update to get answer from abi_features.
14531         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14532         xlen and flen.
14533         (riscv_call_info) <xlen, flen>: Update comment.
14534         (riscv_call_arg_struct): Remove invalid assertions
14535         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14536         is removed.
14537         (riscv_gdbarch_init): Gather isa features and abi features
14538         separately, ensure both match on the gdbarch when reusing an old
14539         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14540         a target with 64-bit float hardware.
14541
14542 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14543
14544         * source.c (search_command_helper): Stop reverse search
14545         when line 1 has been searched.
14546
14547 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14548
14549         * record-full.c (record_full_base_target::close): Rewrite
14550         record_full_core_buf_list free logic.
14551
14552 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14553
14554         * break-catch-syscall.c (print_one_catch_syscall): xfree
14555         the last text.
14556
14557 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14558
14559         * top.c (print_gdb_version): Update Copyright year in version
14560         message.
14561
14562 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14563
14564         Update copyright year range in all GDB files.
14565
14566 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14567
14568         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14569
14570 For older changes see ChangeLog-2018.
14571 \f
14572 Local Variables:
14573 mode: change-log
14574 left-margin: 8
14575 fill-column: 74
14576 version-control: never
14577 coding: utf-8
14578 End:
14579